1 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3 * nsterm.m (windowDidResize): Call x_set_window_size only when
4 ns_in_resize is true. Otherwise set pixelwidth/height and
5 call change_frame_size (Bug#9628).
7 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
9 Port --enable-checking=all to Fedora 14 x86-64.
10 * charset.c (syms_of_charset): Also account for glibc malloc's
11 internal overhead when calculating the initial malloc maximum.
13 Port --enable-checking=all to Fedora 14 x86.
14 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
16 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
17 (overrun_check_realloc, overrun_check_free):
18 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
19 That way, xmalloc returns a properly-aligned pointer even if
20 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
21 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
22 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
23 into account when calculating the initial malloc maximum.
24 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
25 Move here from alloc.c, so that charset.c can use it too.
26 Properly align; the old code wasn't right for common 32-bit hosts
27 when configured with --enable-checking=all.
28 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
29 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
31 2011-09-29 Eli Zaretskii <eliz@gnu.org>
33 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
36 2011-09-28 Eli Zaretskii <eliz@gnu.org>
38 * xdisp.c (compute_display_string_end): If there's no display
39 string at CHARPOS, return -1.
41 * bidi.c (bidi_fetch_char): When compute_display_string_end
42 returns a negative value, treat the character as a normal
43 character not covered by a display string. (Bug#9624)
45 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
47 * lread.c (Fread_from_string): Fix typo in docstring.
49 2011-09-27 Eli Zaretskii <eliz@gnu.org>
51 * xdisp.c (handle_invisible_prop): If invisible text ends on a
52 newline, reseat the iterator instead of bidi-iterating there one
53 character at a time. (Bug#9610)
54 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail out when
55 past TO_CHARPOS if the bidi iterator is at base embedding level.
57 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
59 * lread.c (readevalloop): Use correct code for NBSP.
60 (read1): Likewise. (Bug#9608)
62 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
64 * dbusbind.c (Fdbus_register_signal): When service is not
65 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
67 2011-09-25 Glenn Morris <rgm@gnu.org>
69 * buffer.c (truncate-lines): Doc fix.
71 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
73 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
74 (Fset_window_next_buffers): Doc fix.
76 2011-09-24 Glenn Morris <rgm@gnu.org>
78 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
80 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
82 Fix minor problems found by static checking.
83 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
84 * indent.c (Fvertical_motion): Fix == vs = typo.
86 2011-09-24 Eli Zaretskii <eliz@gnu.org>
88 * dispnew.c (syms_of_display) <redisplay-dont-pause>: Default
89 value is now t. Doc fix.
91 * indent.c (Fvertical_motion): Compute and apply the overshoot
92 logic also when moving up, not only when moving down. Fix the
93 confusing name and values of the it_overshoot_expected variable;
94 logic changed accordingly. (Bug#9254) (Bug#9549)
96 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
97 CHARPOS is covered by a display string which includes newlines.
98 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
99 is covered by a display string with embedded newlines.
101 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
103 * dbusbind.c (Fdbus_register_signal): Add match rule to
104 Vdbus_registered_objects_table. (Bug#9581)
105 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
108 2011-09-24 Jim Meyering <meyering@redhat.com>
110 Do not ignore write error for any output size.
111 The previous change was incomplete.
112 While it makes emacs --batch detect the vast majority of stdout
113 write failures, errors were still ignored whenever the output size is
114 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
115 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
116 && echo FAIL: ignored write error
117 FAIL: ignored write error
118 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
119 && echo FAIL: ignored write error
120 FAIL: ignored write error
121 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
123 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
125 * emacs.c (Fkill_emacs): In noninteractive mode exit
126 non-successfully if a write error occurred on stdout. (Bug#9574)
128 2011-09-21 Eli Zaretskii <eliz@gnu.org>
130 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
133 * dispextern.h (struct it): Update the comment documenting what
136 2011-09-20 Eli Zaretskii <eliz@gnu.org>
138 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
139 a display string, extend search for cursor position to end of row.
140 (find_row_edges): If the row ends in a newline from a display
141 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
142 Handle the case of a display string with multiple newlines.
143 (Fcurrent_bidi_paragraph_direction): Fix search for previous
144 non-empty line. Fixes confusing cursor motion with arrow keys at
145 the beginning of a line that starts with whitespace.
147 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
149 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
152 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
154 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
157 2011-09-18 Eli Zaretskii <eliz@gnu.org>
159 * xdisp.c (display_line): Record maximum and minimum buffer
160 positions even if no glyphs were produced (e.g., by a zero-width
161 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
162 buffer positions that will be removed from the glyph row because
164 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
165 column is beyond frame width: don't subtract 1 "pixel" when
166 computing width of the stretch.
167 (reseat_at_next_visible_line_start): Undo the change made on
168 2011-09-17 that saved paragraph information and restored it after
169 the call to `reseat'. (Bug#9545)
171 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
173 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
174 and turn window cursor on if cleared (Bug#9415).
176 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
178 * search.c (boyer_moore): Take unibyte characters from pattern
179 literally. (Bug#9458)
181 2011-09-18 Eli Zaretskii <eliz@gnu.org>
183 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
185 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
187 Fix minor problem found by static checking.
188 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
189 initialized, to pacify gcc -Wuninitialized.
191 * fileio.c: Report proper errno when syscall falls.
192 (Finsert_file_contents): Save and restore errno,
193 so that report_file_error outputs the correct diagnostic.
194 (Fwrite_region) [CLASH_DETECTION]: Likewise.
196 2011-09-18 Eli Zaretskii <eliz@gnu.org>
198 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
200 2011-09-17 Eli Zaretskii <eliz@gnu.org>
202 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
203 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
205 2011-09-17 Eli Zaretskii <eliz@gnu.org>
207 * xdisp.c (reseat_at_next_visible_line_start): Keep information
208 about the current paragraph and restore it after the call to
211 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
212 (bidi_find_paragraph_start): Search back for paragraph beginning
213 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
214 (bidi_move_to_visually_next): Only trigger paragraph-related
215 computations when the last character is a newline or at EOB, not
216 just any NEUTRAL_B. (Bug#9470)
218 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
219 truncated lines if point is covered by a display string. (Bug#9524)
221 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
223 * xselect.c: Relax test for outgoing X longs (Bug#9498).
224 (cons_to_x_long): New function.
225 (lisp_data_to_selection_data): Use it. Correct the test for
226 short-versus-long data; it was negated. Break out of vector
227 loop, for efficiency, when a long datum is discovered.
229 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
231 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
233 2011-09-16 Eli Zaretskii <eliz@gnu.org>
235 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
236 GCC PR/17406) by declaring this function with external scope.
238 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
240 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
241 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
243 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
245 * editfns.c (Fformat): Correctly handle text properties on "%%".
247 2011-09-15 Eli Zaretskii <eliz@gnu.org>
249 * xterm.c (x_draw_composite_glyph_string_foreground):
250 * w32term.c (x_draw_composite_glyph_string_foreground):
251 * term.c (encode_terminal_code):
252 * composite.c (composition_update_it, get_composition_id):
253 * xdisp.c (get_next_display_element)
254 (fill_composite_glyph_string): Add comments about special meaning
255 of TAB characters in a composition.
257 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
259 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
260 This occurs when processing a multibyte format.
261 Problem reported by Wolfgang Jenker.
263 2011-09-15 Johan Bockgård <bojohan@gnu.org>
265 * xdisp.c (try_cursor_movement): Only check for exact match if
266 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
268 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
270 Remove unused external symbols.
271 * dispextern.h (calc_pixel_width_or_height): Remove decl.
272 * xdisp.c (calc_pixel_width_or_height): Now static.
273 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
274 * indent.c (check_display_width):
275 * w32term.c: Fix comment to match code.
276 * xterm.c, xterm.h (x_catching_errors): Remove.
278 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
280 * xselect.c: Use signed conversions more consistently (Bug#9498).
281 (selection_data_to_lisp_data): Assume incoming selection data are
282 signed integers, not unsigned. This is to be consistent with
283 outgoing selection data, which was modified to use signed integers
284 in as part of the fix to Bug#9196 in response to Jan D.'s comment
285 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
286 expects long, not unsigned long.
288 2011-09-14 Eli Zaretskii <eliz@gnu.org>
290 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
291 computation of loop end. Reported by Johan Bockgård
294 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
296 * frame.c (Fother_visible_frames_p): Function deleted.
298 2011-09-12 Eli Zaretskii <eliz@gnu.org>
300 * indent.c (compute_motion): Process display vector front to back
301 rather than the other way around. (Bug#2496)
303 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
305 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
307 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
309 * minibuf.c (Fread_from_minibuffer): Doc fix.
311 2011-09-11 Eli Zaretskii <eliz@gnu.org>
313 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
314 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
316 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
318 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
319 value for non-existent files.
321 2011-09-11 Eli Zaretskii <eliz@gnu.org>
323 * fileio.c (Finsert_file_contents): If the file cannot be opened,
324 set its "size" to -1. This will set the modtime_size field of
325 the corresponding buffer to -1, which is what
326 verify-visited-file-modtime expects for files that do not exist.
329 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
331 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
333 * lisp.h: ... from here. push_key_description is no longer
334 defined in keyboard.c, so its declaration should not be in
335 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
336 logically belongs with push_key_description.
338 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
340 * buffer.h: Include <sys/types.h> instead of <time.h>.
341 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
342 Problem reported by Herbert J. Skuhra.
344 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
346 * xml.c (parse_region): Make the parsing work for
347 non-comment-starting XML files again (bug#9144).
349 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
351 * image.c (gif_load): Fix calculation of bottom and right corner.
354 2011-09-10 Eli Zaretskii <eliz@gnu.org>
356 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
357 redisplay in small windows.
359 2011-09-09 Eli Zaretskii <eliz@gnu.org>
361 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
363 2011-09-08 Martin Rudalics <rudalics@gmx.at>
365 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
366 Operate on live windows only.
368 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
370 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
372 2011-09-07 Eli Zaretskii <eliz@gnu.org>
374 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
375 only under bidi iteration.
377 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
379 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
381 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
383 isnan: Fix porting problem to Solaris 10 with bundled gcc.
384 Without this fix, the command to link temacs failed due to an
385 undefined symbol __builtin_isnan. This is because
386 /usr/include/iso/math_c99.h #defines isnan(x) to
387 __builtin_isnan(x), but the bundled gcc, which identifies itself
388 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
390 * floatfns.c (isnan): #undef, and then #define to a clone of
392 (Fisnan): Always define, since it's always available now.
393 (syms_of_floatfns): Always define isnan at the Lisp level.
395 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
397 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
399 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
401 * fileio.c: Fix bugs with large file offsets (Bug#9428).
402 The previous code assumed that file offsets (off_t values) fit in
403 EMACS_INT variables, which is not true on typical 32-bit hosts.
404 The code messed up by falsely reporting buffer overflow in cases
405 such as (insert-file-contents "big" nil 1 2) into an empty buffer
406 when "big" contains more than 2**29 bytes, even though this
407 inserts just one byte and does not overflow the buffer.
408 (Finsert_file_contents): Store file offsets as off_t
409 values, not as EMACS_INT values. Check for overflow when
410 converting between EMACS_INT and off_t. When checking for
411 buffer overflow or for overlap, take the offsets into account.
412 Don't use EMACS_INT for small values where int suffices.
413 When checking for overlap, fix a typo: ZV was used where
414 ZV_BYTE was intended.
415 (Fwrite_region): Don't assume off_t fits into 'long'.
416 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
418 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
420 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
422 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
424 sprintf-related integer and memory overflow issues (Bug#9412).
426 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
427 (esprintf, exprintf, evxprintf): New functions.
428 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
429 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
430 (modify_event_symbol): Do not assume that the length of
431 name_alist_or_stem is safe to alloca and fits in int.
432 (Fexecute_extended_command): Likewise for function name and binding.
433 (Frecursion_depth): Wrap around reliably on integer overflow.
434 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
435 since some callers pass EMACS_INT values.
436 (Fsingle_key_description): Don't crash if symbol name contains more
437 than MAX_ALLOCA bytes.
438 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
439 (get_minibuffer): Arg is now EMACS_INT, not int.
440 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
441 (esprintf, exprintf, evxprintf): New decls.
442 * window.h (command_loop_level, minibuf_level): Reflect API changes.
444 * dbusbind.c (signature_cat): New function.
445 (xd_signature, Fdbus_register_signal):
446 Do not overrun buffer; instead, report string overflow.
448 * dispnew.c (add_window_display_history): Don't overrun buffer.
449 Truncate instead; this is OK since it's just a log.
451 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
452 even if the time zone offset is outlandishly large.
453 Don't mishandle offset == INT_MIN.
455 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
456 when creating daemon; the previous buffer-overflow check was incorrect.
458 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
459 which has the guts of the old verror function.
461 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
462 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
464 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
465 (font_unparse_xlfd): Don't blindly alloca long strings.
466 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
467 fits in int, when using sprintf. Use single snprintf to count
468 length of string rather than counting it via multiple sprintfs;
469 that's simpler and more reliable.
470 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
471 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
472 sprintf, in case result does not fit in int.
474 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
475 (fontset_from_font): Print it.
477 * frame.c (tty_frame_count): Now printmax_t, not int.
478 (make_terminal_frame, set_term_frame_name): Print it.
479 (x_report_frame_params): In X, window IDs are unsigned long,
480 not signed long, so print them as unsigned.
481 (validate_x_resource_name): Check for implausibly long names,
482 and don't assume name length fits in 'int'.
483 (x_get_resource_string): Don't blindly alloca invocation name;
484 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
487 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
488 (xg_check_special_colors, xg_set_geometry):
489 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
491 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
492 Use esprintf, not sprintf, in case result does not fit in int.
494 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
495 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
496 it as a large positive number.
497 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
498 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
500 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
501 in case result does not fit in int.
503 * print.c (float_to_string): Detect width overflow more reliably.
504 (print_object): Make sprintf buffer a bit bigger, to avoid potential
505 buffer overrun. Don't assume list length fits in 'int'. Treat
506 print length of 0 as 0, not as infinity; to be consistent with other
507 uses of print length in this function. Don't overflow print length
508 index. Don't assume hash table size fits in 'long', or that
509 vectorlike size fits in 'unsigned long'.
511 * process.c (make_process): Use printmax_t, not int, to format
512 process-name gensyms.
514 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
516 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
517 to avoid potential buffer overrun.
519 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
520 if X resource line is longer than 512 bytes.
522 * xfns.c (x_window): Make sprintf buffer a bit bigger
523 to avoid potential buffer overrun.
525 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
527 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
529 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
531 Integer overflow fixes for scrolling, etc.
532 Without these, Emacs silently mishandles large integers sometimes.
533 For example, "C-u 4294967297 M-x recenter" was treated as if
534 it were "C-u 1 M-x recenter" on a typical 64-bit host.
536 * xdisp.c (try_window_id): Check Emacs fixnum range before
539 * window.c (window_scroll_line_based, Frecenter):
540 Check that an Emacs fixnum is in range before assigning it to 'int'.
541 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
542 values converted from Emacs fixnums.
543 (Frecenter): Don't wrap around a line count if it is out of 'int'
544 range; instead, treat it as an extreme value.
545 (Fset_window_configuration, compare_window_configurations):
546 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
548 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
549 that can exceed INT_MAX. Check that EMACS_INT value is in range
550 before assigning it to the (possibly-narrower) index.
551 (match_limit): Don't assume that a fixnum can fit in 'int'.
553 * print.c (print_object): Use ptrdiff_t, not int, for index that can
556 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
557 (Fvertical_motion): Don't wrap around LINES values that don't fit
558 in 'int'. Instead, treat them as extreme values. This is good
559 enough for windows, which can't have more than INT_MAX lines anyway.
561 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
563 * Require libxml/parser.h to avoid compilation warning.
565 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
567 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
568 since this reportedly can destroy thread storage.
570 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
572 * syntax.c (find_defun_start): Update all cache variables if
573 exiting early (Bug#9401).
575 2011-08-30 Eli Zaretskii <eliz@gnu.org>
577 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
579 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
580 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
581 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
583 * term.c (tty_append_glyph): New function.
584 (produce_stretch_glyph): Static function and its prototype deleted.
586 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
589 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
591 * image.c (parse_image_spec): Check for nonnegative, not for positive,
592 when checking :margin (Bug#9390).
593 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
594 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
595 so that the name doesn't mislead. All uses changed.
597 2011-08-28 Johan Bockgård <bojohan@gnu.org>
599 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
602 2011-08-27 Eli Zaretskii <eliz@gnu.org>
604 * xdisp.c (move_it_to): Don't bail out early when reaching
605 position beyond to_charpos, if we are scanning backwards.
606 (move_it_vertically_backward): When DY == 0, make sure we get to
607 the first character in the line after the newline.
609 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
611 * ccl.c: Improve and simplify overflow checking (Bug#9196).
612 (ccl_driver): Do not generate an out-of-range pointer.
613 (Fccl_execute_on_string): Remove unnecessary check for
614 integer overflow, noted by Stefan Monnier in
615 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
616 Remove a FIXME that didn't need fixing.
617 Simplify the newly-introduced buffer reallocation code.
619 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
621 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
623 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
625 Integer and memory overflow issues (Bug#9196).
627 * doc.c (get_doc_string): Rework so that
628 get_doc_string_buffer_size is the actual buffer size, rather than
629 being 1 less than the actual buffer size; this makes xpalloc more
632 * image.c (x_allocate_bitmap_record, cache_image):
633 * xselect.c (Fx_register_dnd_atom):
634 Simplify previous changes by using xpalloc.
636 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
637 since either will do and ptrdiff_t is convenient with xpalloc.
639 * charset.c (charset_table_size)
640 (struct charset_sort_data.priority): Now ptrdiff_t.
641 (charset_compare): Don't overflow if priorities differ greatly.
642 (Fsort_charsets): Don't assume list length fits in int.
643 Check for size-calculation overflow when allocating sort data.
644 (syms_of_charset): Allocate an initial charset table that is
645 just under 64 KiB, to avoid problems with glibc malloc and mmap.
647 * cmds.c (internal_self_insert): Check for size-calculation overflow.
649 * composite.h (struct composition.glyph_len): Now int, not unsigned.
650 The actual value is always <= INT_MAX, and leaving it unsigned made
651 overflow checking harder.
653 * dispextern.h (struct glyph_matrix.rows_allocated)
654 (struct face_cache.size): Now ptrdiff_t, for convenience in use
655 with xpalloc. The values are still always <= INT_MAX.
657 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
659 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
660 (SAFE_NALLOCA): New macro.
662 * region-cache.c (struct boundary.pos, find_cache_boundary)
663 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
664 (set_cache_region, invalidate_region_cache)
665 (revalidate_region_cache, know_region_cache, region_cache_forward)
666 (region_cache_backward, pp_cache):
667 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
668 so that ptrdiff_t * can be passed to xpalloc.
669 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
670 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
671 (pp_cache): Don't assume cache_len fits in int.
672 * region-cache.h: Adjust extern decls to match.
674 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
675 EMACS_INT, since either will do, for xpalloc.
677 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
678 (xnmalloc, xnrealloc, xpalloc): New functions.
680 * bidi.c (bidi_shelve_header_size): New constant.
681 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
682 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
684 * bidi.c (bidi_cache_shrink):
685 * buffer.c (overlays_at, overlays_in, record_overlay_string)
687 Don't update size of array until after memory allocation succeeds,
688 because xmalloc/xrealloc may not return.
689 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
690 now that we have proper integer overflow checking.
691 (record_overlay_string, overlay_strings): Catch overflows when
692 calculating size of overlay_str_buf.
694 * callproc.c (Fcall_process): Check for size overflow when
695 calculating size of args2.
696 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
697 Normally we prefer signed values, but sticking with ptrdiff_t would
698 require adding more-complicated checks.
700 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
701 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
702 Redo buffer-overflow calculations to avoid integer overflow.
703 Add a FIXME comment where memory seems to be over-allocated.
705 * character.c (Fstring): Check for size-calculation overflow.
707 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
708 unnecessary integer overflow. Check for size overflow.
709 (encode_coding_object): Don't update size until xmalloc succeeds.
711 * composite.c (get_composition_id): Check for overflow in glyph
714 Integer and memory overflow fixes for display code.
715 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
716 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
717 (scrolling_window): Check for overflow in size calculations.
718 (line_draw_cost, realloc_glyph_pool, add_row_entry):
719 Don't assume glyph table len fits in int.
720 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
721 (row_table_size): Now ptrdiff_t, not int.
722 (scrolling_window): Avoid overflow in size calculations.
723 Don't update size until allocation succeeds.
724 * fns.c (concat): Check for overflow in size calculations.
725 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
726 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
727 (NEXT_ALMOST_PRIME_LIMIT): New constant.
729 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
730 (get_doc_string): Check for size calculation overflow.
731 Don't update size until allocation succeeds.
732 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
733 EMACS_INT, where ptrdiff_t will do.
734 (Fsubstitute_command_keys): Check for string overflow.
736 * editfns.c (set_time_zone_rule): Don't assume environment length
738 (message_length): Now ptrdiff_t, not int.
739 (Fmessage_box): Don't update size until allocation succeeds.
740 Don't assume message length fits in int.
741 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
743 * emacs.c (main): Do not reallocate argv, since there is a null at
744 the end that can be overwritten, and this way there's no need to
745 worry about size-calculation overflow.
746 (sort_args): Check for size-calculation overflow.
748 * eval.c (init_eval_once, grow_specpdl): Don't update size until
750 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
752 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
753 (x_set_scroll_bar_width, x_figure_window_size):
754 Check for integer overflow.
755 (x_set_alpha): Do not assume XINT fits in int.
757 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
758 This is for the members text_lines, text_cols, total_lines, total_cols,
759 where the system imposes an 'int' limit.
761 * fringe.c (Fdefine_fringe_bitmap):
762 Don't update size until alloc works.
764 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
765 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
767 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
768 Check for size-calculation overflow.
769 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
770 do, as we prefer signed integers.
771 (id_to_widget.max_size, id_to_widget.used)
772 (xg_store_widget_in_map, xg_remove_widget_from_map)
773 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
774 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
775 Use and return ptrdiff_t, not int.
776 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
777 * gtkutil.h: Change prototypes to match the above.
779 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
780 are duplicate now that they've been promoted to lisp.h.
781 (x_allocate_bitmap_record, x_alloc_image_color)
782 (make_image_cache, cache_image, xpm_load):
783 Don't update size until alloc is done.
784 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
786 Check for size calculation overflow.
787 (ct_colors_allocated_max): New constant.
788 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
791 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
792 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
793 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
794 Use ptrdiff_t, not int, to count maps.
795 (read_char_minibuf_menu_prompt): Check for overflow in size
796 calculations. Don't update size until allocation succeeds. Redo
797 calculations to avoid overflow.
798 * keyboard.h: Change prototypes to match the above.
800 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
802 (current_minor_maps): Check for size calculation overflow.
803 * keymap.h: Change prototypes to match the above.
805 * lread.c (read1, init_obarray): Don't update size until alloc done.
807 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
808 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
810 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
811 Now ptrdiff_t, not int.
812 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
813 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
815 * process.c (Fnetwork_interface_list): Check for overflow
818 * region-cache.c (move_cache_gap): Check for size calculation overflow.
820 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
821 overflow. Don't bother calling xmalloc when xrealloc will do.
823 * search.c (Freplace_match): Check for size calculation overflow.
824 (Fset_match_data): Don't assume list lengths fit in 'int'.
826 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
827 for command line length. Do not attempt to address one before the
828 beginning of an array, as that's not portable.
830 * term.c (max_frame_lines): Remove; unused.
831 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
833 (encode_terminal_code, calculate_costs): Check for size
834 calculation overflow.
835 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
836 table lengths and related sizes. Don't update size until alloc
837 done. Redo calculations to avoid overflow.
838 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
840 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
841 subtracting pointers.
842 (gobble_line): Check for overflow more carefully. Don't update size
845 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
846 Don't update size until alloc done.
847 Redo size calculations to avoid overflow.
848 Check for size calculation overflow.
849 (main) [DEBUG]: Fix typo in invoking tparam1.
851 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
852 Use ptrdiff_t, not int, for sizes.
853 (store_mode_line_noprop_char): Don't update size until alloc done.
855 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
856 Use ptrdiff_t, not int, for sizes.
857 (Finternal_make_lisp_face, cache_face):
858 Check for size calculation overflow.
859 (cache_face): Treat size calculation overflows as if they were
860 memory exhaustion (the usual treatment), rather than aborting.
862 * xfns.c (x_encode_text, x_set_name_internal)
863 (Fx_change_window_property): Use ptrdiff_t, not int, to count
864 sizes, since they can exceed INT_MAX in size. Check for size
865 calculation overflow.
867 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
868 (xg_select): Check for size calculation overflow.
869 Don't update size until alloc done.
871 * xrdb.c (get_environ_db): Don't assume path length fits in int,
872 as sprintf is limited to int lengths.
874 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
875 (X_LONG_MIN): New macros.
876 Use them to make the following changes clearer.
877 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
878 This change doesn't affect the value now, but it may help remind
879 future maintainers not to raise the value too much later.
880 (SELECTION_QUANTUM): Remove, replacing with ...
881 (selection_quantum): ... new function, which avoids overflow.
883 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
884 assumption that selection length fits in 'int'.
885 (x_reply_selection_request, x_handle_selection_request)
886 (x_get_window_property, receive_incremental_selection)
887 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
888 (lisp_data_to_selection_data, clean_local_selection_data):
889 Use ptrdiff_t, not int, to record length of selection.
890 (x_reply_selection_request, x_get_window_property)
891 (receive_incremental_selection, x_property_data_to_lisp):
892 Redo calculations to avoid overflow.
893 (x_reply_selection_request): When sending hint, ceiling it at
894 X_LONG_MAX rather than relying on wraparound overflow to send
896 (x_get_window_property, receive_incremental_selection)
897 (lisp_data_to_selection_data, x_property_data_to_lisp):
898 Check for size-calculation overflow.
899 (x_get_window_property, receive_incremental_selection)
900 (lisp_data_to_selection_data, Fx_register_dnd_atom):
901 Don't store size until memory allocation succeeds.
902 (x_get_window_property): Plug memory leak on memory exhaustion.
903 Don't double-block input; malloc is safe here. Don't assume 2**34
904 - 4 fits in unsigned long. Add an xassert to check
905 XGetWindowProperty overflow. Be more careful about overflow
906 calculations, and distinguish size from memory overflow better.
907 (receive_incremental_selection): When tracing, don't assume
908 unsigned int is less than INT_MAX.
909 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
910 harmful) conversions of unsigned short to int.
911 (lisp_data_to_selection_data): Don't assume that integers
912 in the range -65535 through -1 fit in an X unsigned short.
913 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
914 result parameters unless successful. Rely on cons_to_unsigned
915 to report problems with elements; the old code wasn't right anyway.
916 (x_check_property_data): Check for int overflow; we cannot use
917 a wider type due to X limits.
918 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
920 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
922 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
923 (x_term_init): Check for size calculation overflow.
924 (x_color_cells): Don't store size until memory allocation succeeds.
925 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
926 Don't assume alloca size is less than MAX_ALLOCA.
927 (x_term_init): Don't assume length fits in int (sprintf is limited
930 Use ptrdiff_t for composition IDs.
931 * character.c (lisp_string_width):
932 * composite.c (composition_table_size, n_compositions)
933 (get_composition_id, composition_gstring_from_id):
934 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
935 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
936 * window.c (Frecenter):
937 Use ptrdiff_t, not int, for composition IDs.
938 * composite.c (get_composition_id): Check for integer overflow.
939 * composite.h: Adjust prototypes to match the above changes.
941 Use ptrdiff_t for hash table indexes.
942 * category.c (hash_get_category_set):
943 * ccl.c (ccl_driver):
944 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
945 * coding.c (coding_system_charset_list, detect_coding_system):
946 * coding.h (struct coding_system.id):
947 * composite.c (get_composition_id, gstring_lookup_cache):
948 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
949 * image.c (xpm_get_color_table_h):
950 * lisp.h (hash_lookup, hash_put):
951 * minibuf.c (Ftest_completion):
952 Use ptrdiff_t for hash table indexes, not int (which is too
953 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
954 32-bit --with-wide-int hosts).
956 * charset.c (Fdefine_charset_internal): Check for integer overflow.
957 Add a FIXME comment about memory leaks.
958 (syms_of_charset): Don't assume xmalloc returns.
960 Don't assume that stated character widths fit in int.
961 * character.c (Fchar_width, c_string_width, lisp_string_width):
962 * character.h (CHAR_WIDTH):
963 * indent.c (MULTIBYTE_BYTES_WIDTH):
964 Use sanitize_char_width to avoid undefined and/or bad behavior
965 with outlandish widths.
966 * character.h (sanitize_tab_width): Renamed from sanitize_width,
967 now that we have two such functions. All uses changed.
968 (sanitize_char_width): New inline function.
970 Don't assume that tab-width fits in int.
971 * character.h (sanitize_width): New inline function.
972 (SANE_TAB_WIDTH): New macro.
973 (ASCII_CHAR_WIDTH): Use it.
974 * indent.c (sane_tab_width): Remove. All uses replaced by
975 SANE_TAB_WIDTH (current_buffer).
976 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
978 * fileio.c: Integer overflow issues with file modes.
979 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
981 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
982 Remove unreachable code.
983 (read_hex, load_charset_map_from_file): Check for integer overflow.
985 * xterm.c: don't go over XClientMessageEvent limit
986 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
987 (x_send_scroll_bar_event): Likewise. Check that the size does not
988 exceed limits imposed by XClientMessageEvent, as well as the usual
989 ptrdiff_t and size_t limits.
991 * keyboard.c: Overflow, signedness and related fixes.
992 (make_lispy_movement): Use same integer type in forward decl
993 that is used in the definition.
994 (read_key_sequence, keyremap_step):
995 Change bufsize argument back to int, undoing my 2011-03-30 change.
996 We prefer signed types, and int is wide enough here.
997 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
998 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
999 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1000 length, not size_t. Use ptrdiff_t for index, not int.
1001 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1002 possibility of integer overflow.
1004 Overflow, signedness and related fixes for images.
1006 * dispextern.h (struct it.stack[0].u.image.image_id)
1007 (struct_it.image_id, struct image.id, struct image_cache.size)
1008 (struct image_cache.used, struct image_cache.ref_count):
1009 * gtkutil.c (update_frame_tool_bar):
1010 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1011 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1012 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1013 * nsmenu.m (update_frame_tool_bar):
1014 * xdisp.c (calc_pixel_width_or_height):
1015 * xfns.c (image_cache_refcount):
1016 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1017 on typical 64-bit hosts.
1019 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1020 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1021 Omit unnecessary casts to int.
1022 (parse_image_spec): Check that integers fall into 'int' range
1023 when the callers expect that.
1024 (image_ascent): Redo ascent calculation to avoid int overflow.
1025 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1026 (lookup_image): Remove unnecessary tests.
1027 (xbm_image_p): Locals are now of int, not EMACS_INT,
1028 since parse_image_check makes sure they fit into int.
1029 (png_load, gif_load, svg_load_image):
1030 Prefer int to unsigned where either will do.
1031 (tiff_handler): New function, combining the cores of the
1032 old tiff_error_handler and tiff_warning_handler. This
1033 function is rewritten to use vsnprintf and thereby avoid
1034 stack buffer overflows. It uses only the features of vsnprintf
1035 that are common to both POSIX and native Microsoft.
1036 (tiff_error_handler, tiff_warning_handler): Use it.
1037 (tiff_load, gif_load, imagemagick_load_image):
1038 Don't assume :index value fits in 'int'.
1039 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1040 (imagemagick_load_image): Check that crop parameters fit into
1041 the integer types that MagickCropImage accepts. Don't assume
1042 Vimagemagick_render_type has a nonnegative value. Don't assume
1043 size_t fits in 'long'.
1044 (gs_load): Use printmax_t to print the widest integers possible.
1045 Check for integer overflow when computing image height and width.
1047 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1049 * xdisp.c (redisplay_window): Don't force window start if point
1050 will be invisible in the resulting window. (Bug#9324)
1052 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1054 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1055 the display spec is of the form `(space ...)'.
1056 (handle_display_spec): Return the value returned by
1057 handle_single_display_spec, not just 1 or zero.
1058 (handle_single_display_spec): If the display spec is of the form
1059 `(space ...)', and specifies display in the text area, return 2
1061 (try_cursor_movement): Check for the need to scroll more
1062 accurately, and prefer exact match for point under bidi. Don't
1063 advance `row' beyond the last row of the window.
1065 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1066 into disp_prop; all users changed.
1068 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1069 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1070 for the text covered by the display property.
1072 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1074 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1075 Change return value to nil.
1076 (Frecord_buffer): Delete unused function.
1078 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1080 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1081 buffers, return left-to-right.
1082 (set_cursor_from_row): Consider candidate row a win if its glyph
1083 represents a newline and point is on that newline. Fixes cursor
1084 positioning on the newline at EOL of R2L text within L2R
1085 paragraph, and vice versa.
1086 (try_cursor_movement): Check continued rows, in addition to
1087 continuation rows. Fixes unwarranted scroll when point enters a
1088 continued line of R2L text within an L2R paragraph, or vice versa.
1089 (cursor_row_p): Consider the case of point being equal to
1090 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1091 from the end of a short line to the beginning of a continued line
1092 of R2L text within L2R paragraph.
1093 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1094 composed characters.
1096 * bidi.c (bidi_check_type): Use xassert.
1097 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1100 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1102 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1105 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1107 * nsfont.m (ns_otf_to_script): Fix typo.
1109 2011-08-22 Kenichi Handa <handa@m17n.org>
1111 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1112 extra slot even if the purpose is char-code-property-table.
1114 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1116 * xdisp.c (redisplay_window): When computing centering_position,
1117 account for the height of the header line. (Bug#8874)
1119 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1120 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1121 candidate is selected by the mouse, and that candidate has a
1122 composed character under the mouse.
1124 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1125 coordinates reported by pos-visible-in-window-p for a composed
1126 character in column zero.
1128 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1130 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1132 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1134 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1135 consider it a hit if to_charpos is anywhere in the range of the
1136 composed buffer positions.
1138 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1140 * image.c (gif_load): Don't assume that each subimage has the same
1141 dimensions as the base image. Handle disposal method that is
1142 "undefined" by the gif spec (Bug#9335).
1144 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1146 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1147 (Fcondition_case): Document `debug' symbol in error handler.
1149 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1151 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1152 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1153 from an Org mode buffer to a Speedbar frame.
1155 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1156 a composition, take its buffer position from IT->cmp_it.charpos.
1157 Fixes cursor positioning at the beginning of a line that begins
1158 with a composed character.
1160 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1162 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1163 character bidirectional type, use STRONG_L instead. Fixes crashes
1164 in a buffer produced by `describe-categories'.
1166 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1167 members before the level stack, so they would be saved and
1168 restored when copying iterator state. Fixes incorrect reordering
1169 around TABs covered by display properties.
1171 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1173 * process.c (Fnetwork_interface_list): Correctly determine buffer
1176 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1178 * eval.c (internal_condition_case, internal_condition_case_1)
1179 (internal_condition_case_2, internal_condition_case_n):
1180 Remove unnecessary aborts (Bug#9081).
1182 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1184 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1185 has no `load' handler, try opening the file locally. (Bug#9311)
1187 2011-08-16 Ken Brown <kbrown@cornell.edu>
1189 * gmalloc.c: Expand comment.
1191 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1193 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1194 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1196 2011-08-16 Ken Brown <kbrown@cornell.edu>
1198 Fix memory allocation problems in Cygwin build (Bug#9273).
1200 * unexcw.c ( __malloc_initialized): Declare external variable.
1201 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1203 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1205 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1207 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1209 [CYGWIN] (special_realloc): New function.
1210 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1211 requests to realloc storage in the static heap.
1213 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1215 * bidi.c (bidi_initialize): Remove unused local.
1217 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1219 * biditype.h: File removed.
1221 * bidimirror.h: File removed.
1223 * deps.mk (bidi.o): Remove biditype.h and
1226 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1229 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1231 * chartab.c: Improve commentary for the uniprop_table API.
1233 * bidi.c (bidi_paragraph_init): Support zero value of
1234 bidi_ignore_explicit_marks_for_paragraph_level.
1235 (bidi_initialize): Use uniprop_table instead of including
1236 biditype.h and bidimirror.h.
1238 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1239 coordinates of the iterator when restoring from ppos_it.
1242 2011-08-14 Kenichi Handa <handa@m17n.org>
1244 * process.c (create_process): Call setup_process_coding_systems
1245 after the pid of the process is set to -1 (Bug#8162).
1247 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1249 * xdisp.c (move_it_in_display_line_to): Don't invoke
1250 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1251 ppos_it. Fixes vertical cursor motion when line beginning is
1252 covered by an image. (Bug#9296)
1254 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1256 * nsterm.h (ns_run_ascript): Declare.
1257 (NSAPP_DATA2_RUNASSCRIPT): Define.
1259 * nsfns.m (as_script, as_result, as_status): New static variables.
1260 (ns_run_ascript): New function.
1261 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1262 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1263 the event loop. Get status from as_status (Bug#7276).
1265 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1266 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1267 the event loop (Bug#7276).
1269 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1271 * gnutls.c (QCgnutls_bootprop_priority)
1272 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1273 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1274 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1275 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1276 (QCgnutls_bootprop_verify_hostname_error)
1277 (QCgnutls_bootprop_callbacks_verify): Rename from
1278 Qgnutls_bootprop_..., all uses changed.
1280 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1283 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1285 * xfaces.c (Qframe_set_background_mode): Now static.
1286 * dispextern.h (Qframe_set_background_mode): Remove decl.
1288 * process.c (Fnetwork_interface_info): Declare local only if needed.
1290 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1292 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1293 (Fnetwork_interface_list): Allocate in increments of bytes instead
1294 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1295 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1297 (struct ifflag_def): notrailers is smart on OSX.
1298 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1299 Get hardware address with getifaddrs if available.
1301 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1303 * xdisp.c (iterate_out_of_display_property): xassert that
1304 IT->position is set to within IT->object's boundaries. Break from
1305 the loop as soon as EOB is reached; avoids infloops in redisplay
1306 when IT->position is set up wrongly due to some bug.
1307 Set IT->current to match the bidi iterator unconditionally.
1308 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1309 entry. Force push_it to save on the stack the current
1310 buffer/string position, to be restored by pop_it. Fix flags in
1311 the iterator structure wrt the object coming from a display
1312 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1313 properties. (Bug#9284)
1315 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1317 * fontset.c (fontset_get_font_group): Add proper type checks.
1320 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1322 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1323 and LC_VERSION_MIN_MACOSX.
1324 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1325 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1327 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1329 * xdisp.c (forward_to_next_line_start): Allow to use the
1330 no-display-properties-and-no-overlays under bidi display.
1331 Set disp_pos in the bidi iterator to avoid searches for display
1332 properties and overlays.
1334 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1336 * editfns.c (Fset_time_zone_rule): Document relationship with the
1339 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1340 the font entity extracted from the cache (Bug#8109).
1342 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1344 * composite.c (autocmp_chars): Don't reset point. That is done by
1345 restore_point_unwind (Bug#5984).
1347 2011-08-07 Juri Linkov <juri@jurta.org>
1349 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1350 to show the arg `TIME' instead of `TIMEVAL'.
1352 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1354 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1355 display property strides EOL and includes a newline, as in
1356 longlines-mode. (Bug#9254)
1357 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1358 word-wrap under bidirectional display. (Bug#9224)
1360 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1361 is non-zero, even if the data buffer is NULL. Fixes a crash in
1362 vertical-motion with longlines-mode. (Bug#9254)
1364 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1366 * bidi.c <bidi_cache_total_alloc>: Now static.
1367 (bidi_initialize): Initialize bidi_cache_total_alloc.
1369 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1372 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1373 amount allocated this far in `bidi_cache_total_alloc'.
1374 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1375 non-zero, only free the data buffer without restoring the cache
1376 contents. All callers changed.
1378 * dispextern.h (bidi_unshelve_cache): Update prototype.
1380 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1381 (move_it_in_display_line, move_it_to)
1382 (move_it_vertically_backward, move_it_by_lines): Replace the call
1383 to xfree to an equivalent call to bidi_unshelve_cache.
1384 (move_it_in_display_line_to): Fix logic of returning
1385 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1387 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1389 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1390 came from a string character with a `cursor' property. (Bug#9229)
1392 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1394 * Makefile.in (LIB_PTHREAD): New variable.
1395 (LIBES): Add LIB_PTHREAD (Bug#9216).
1397 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1398 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1400 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1402 * regex.c (re_iswctype): Remove some redundant boolean
1405 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1407 * xterm.c (x_find_topmost_parent): New function.
1408 (x_set_frame_alpha): Find topmost parent window with
1409 x_find_topmost_parent and set the property there also (bug#9181).
1410 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1412 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1414 * callproc.c (Fcall_process): Avoid vfork clobbering
1415 the local vars buffer, coding_systems, current_dir.
1417 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1419 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1421 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1423 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1424 so that it is not optimized away.
1426 * xdisp.c (compute_display_string_pos): Remove unused local.
1428 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1430 Fix slow cursor motion and scrolling in large buffers with
1431 selective display, like Org Mode buffers. (Bug#9218)
1433 * dispextern.h (struct bidi_it): New member disp_prop_p.
1435 * xdisp.c: Remove one-slot cache of display string positions.
1436 (compute_display_string_pos): Accept an additional argument
1437 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1438 for a display string or property. If found, set DISP_PROP_P
1441 * bidi.c (bidi_fetch_char): Accept an additional argument
1442 DISP_PROP_P, and pass it to compute_display_string_pos.
1443 Only handle text covered by a display string if DISP_PROP_P is returned
1444 non-zero. All callers of bidi_fetch_char changed.
1446 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1448 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1450 2010-12-03 Don March <don@ohspite.net>
1452 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1453 last character M-[char] is translated to ESC [char] (bug#7541).
1455 2011-08-02 Kenichi Handa <handa@m17n.org>
1457 * lisp.h (uniprop_table): Extern it.
1459 * chartab.c (uniprop_table): Make it non-static.
1461 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1463 * xdisp.c (forward_to_next_line_start): Accept additional argument
1464 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1466 (reseat_at_next_visible_line_start): Use the bidi iterator state
1467 returned by forward_to_next_line_start to restore the state of
1468 it->bidi_it after backing up to previous newline. (Bug#9212)
1470 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1472 * regex.c (re_comp): Protoize.
1473 (re_exec): Fix return type.
1474 (regexec): Fix type of `ret'. (Bug#9203)
1476 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1478 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1479 This is needed if max-image-size is a floating-point number.
1481 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1483 * print.c (print_object): Print empty symbol as ##.
1485 * lread.c (read1): Read ## as empty symbol.
1487 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1489 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1490 setting frame foreground color (Bug#9175).
1491 (x_set_background_color): Likewise.
1493 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1494 contents (Bug#9176).
1495 (EmacsTooltip -init): Remove bezels and add shadows to
1498 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1499 or scroll bar (Bug#8470).
1501 * nsfont.m (nsfont_open): Remove assignment to voffset and
1502 unnecessary vars hshink, expand, hd, full_height, min_height.
1503 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1505 * nsterm.h (nsfont_info): Remove voffset field.
1507 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1509 Implement strike-through and overline on NextStep (Bug#8863).
1511 * nsfont.m (nsfont_open): Use underline position provided by font,
1512 instead of hard-coded value of 2.
1513 (nsfont_draw): Call ns_draw_text_decoration instead.
1515 * nsterm.h: Add declaration for ns_draw_text_decoration.
1517 * nsterm.m (ns_draw_text_decoration): New function for drawing
1518 underline, overline, and strike-through.
1519 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1520 ns_draw_text_decoration. Change treatment of cursor drawing to
1521 accommodate underlining, etc.
1523 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1525 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1528 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1530 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1531 Without this fix, if a signal arrives just after memory fills up,
1532 'malloc' might be invoked reentrantly.
1534 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1535 In other words, assume that every image size is allowed, on non-X
1536 hosts. This assumption is probably wrong, but it lets Emacs compile.
1538 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1540 * regex.c (re_iswctype): Convert return values to boolean.
1542 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1544 * xdisp.c (compute_display_string_pos): Don't use cached display
1545 string position if the buffer had its restriction changed.
1548 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1550 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1552 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1554 Integer signedness and overflow and related fixes. (Bug#9079)
1556 * bidi.c: Integer size and overflow fixes.
1557 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1558 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1559 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1560 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1561 (bidi_find_other_level_edge):
1562 Use ptrdiff_t instead of EMACS_INT where either will do.
1563 This works better on 32-bit hosts configured --with-wide-int.
1564 (bidi_cache_ensure_space): Check for size-calculation overflow.
1565 Use % rather than repeated addition, for better worst-case speed.
1566 Don't set bidi_cache_size until after xrealloc returns, because it
1568 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1569 (bidi_cache_ensure_space): Also check that the bidi cache size
1570 does not exceed that of the largest Lisp string or buffer. See Eli
1571 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1573 * alloc.c (__malloc_size_t): Remove.
1574 All uses replaced by size_t. See Andreas Schwab's note
1575 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1577 * image.c: Improve checking for integer overflow.
1578 (check_image_size): Assume that f is nonnull, since
1579 it is always nonnull in practice. This is one less thing to
1580 worry about when checking for integer overflow later.
1581 (x_check_image_size): New function, which checks for integer
1582 overflow issues inside X.
1583 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1584 This removes the need for a memory_full check.
1585 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1586 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1587 (xbm_read_bitmap_data): Change locals back to 'int', since
1588 their values must fit in 'int'.
1589 (xpm_load_image, png_load, tiff_load):
1590 Invoke x_create_x_image_and_pixmap earlier,
1591 to avoid much needless work if the image is too large.
1592 (tiff_load): Treat overly large images as if
1593 x_create_x_image_and_pixmap failed, not as malloc failures.
1594 (gs_load): Use x_check_image_size.
1596 * gtkutil.c: Omit integer casts.
1597 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1598 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1600 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1602 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1603 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1604 would wrongly return t on a 64-bit host.
1606 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1607 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1608 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1609 and therefore cause GCC to emit a bogus diagnostic in some cases.
1611 * image.c: Integer signedness and overflow and related fixes.
1612 This is not an exhaustive set of fixes, but it's time to
1613 record what I've got.
1614 (lookup_pixel_color, check_image_size): Remove redundant decls.
1615 (check_image_size): Don't assume that arbitrary EMACS_INT values
1616 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1617 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1618 (tiff_load, imagemagick_load_image):
1619 Check for overflow in size calculations.
1620 (x_create_x_image_and_pixmap): Remove unnecessary test for
1621 xmalloc returning NULL; that can't happen.
1622 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1623 (xpm_color_bucket): Use better integer hashing function.
1624 (xpm_cache_color): Don't possibly over-allocate memory.
1625 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1626 (gif_memory_source):
1627 Use ptrdiff_t, not int or size_t, to record sizes.
1628 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1629 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1630 either works, as we prefer signed integers.
1631 (tiff_read_from_memory, tiff_write_from_memory):
1632 Return tsize_t, not size_t, since that's what the TIFF API wants.
1633 (tiff_read_from_memory): Don't fail simply because the read would
1634 go past EOF; instead, return a short read.
1635 (tiff_load): Omit no-longer-needed casts.
1636 (Fimagemagick_types): Don't assume size fits into 'int'.
1638 Improve hashing quality when configured --with-wide-int.
1639 * fns.c (hash_string): New function, taken from sxhash_string.
1640 Do not discard information about ASCII character case; this
1641 discarding is no longer needed.
1642 (sxhash-string): Use it. Change sig to match it. Caller changed.
1643 * lisp.h: Declare it.
1644 * lread.c (hash_string): Remove, since we now use fns.c's version.
1645 The fns.c version returns a wider integer if --with-wide-int is
1646 specified, so this should help the quality of the hashing a bit.
1648 * emacs.c: Integer overflow minor fix.
1649 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1650 Define only if GNU_LINUX.
1651 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1653 * dispnew.c: Integer signedness and overflow fixes.
1654 Remove unnecessary forward decls, that were a maintenance hassle.
1655 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1657 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1658 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1659 (prepare_desired_row, line_draw_cost):
1660 Use int, not unsigned, where either works.
1661 (save_current_matrix, restore_current_matrix):
1662 Use ptrdiff_t, not size_t, where either works.
1663 (init_display): Check for overflow more accurately, and without
1664 relying on undefined behavior.
1666 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1667 Remove, replacing with the new symbols in lisp.h. All uses changed.
1668 * fileio.c (make_temp_name):
1669 * filelock.c (lock_file_1, lock_file):
1670 * xdisp.c (message_dolog):
1671 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1672 Use pMd etc. instead.
1673 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1674 replacing the pWIDE etc. symbols removed from editfns.c.
1676 * keyboard.h (num_input_events): Now uintmax_t.
1677 This is (very slightly) less likely to mess up due to wraparound.
1680 * buffer.c: Integer signedness fixes.
1681 (alloc_buffer_text, enlarge_buffer_text):
1682 Use ptrdiff_t rather than size_t when either will do, as we prefer
1685 * alloc.c: Integer signedness and overflow fixes.
1686 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1687 (__malloc_size_t): Default to size_t, not to int.
1688 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1689 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1690 Prefer ptrdiff_t to size_t when either would do, as we prefer
1692 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1693 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1694 Now const. Initialize with values that are in range even if char
1696 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1697 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1698 These functions do the right thing with sizes > 2**32.
1699 (check_depth): Now ptrdiff_t, not int.
1700 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1701 Adjust to new way of storing sizes. Check for size overflow bugs
1703 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1704 slightly wrong anyway, as it missed one instance of
1705 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1706 (refill_memory_reserve): Omit needless cast to size_t.
1707 (mark_object_loop_halt): Mark as externally visible.
1709 * xselect.c: Integer signedness and overflow fixes.
1710 (Fx_register_dnd_atom, x_handle_dnd_message):
1711 Use ptrdiff_t, not size_t, since we prefer signed.
1712 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1713 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1714 x_dnd_atoms_size and x_dnd_atoms_length.
1716 * doprnt.c: Prefer signed to unsigned when either works.
1718 * doprnt.c (doprnt):
1720 * xdisp.c (vmessage):
1721 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1722 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1723 prefer signed arithmetic to avoid comparison confusion.
1724 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1725 but is a bit tricky.
1727 Assume freestanding C89 headers, string.h, stdlib.h.
1728 * data.c, doprnt.c, floatfns.c, print.c:
1729 Include float.h unconditionally.
1730 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1731 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1732 * regex.c: Likewise for stddef.h, string.h.
1733 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1734 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1735 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1736 (STDC_HEADERS): Remove obsolete defines.
1737 * sysdep.c: Include limits.h unconditionally.
1739 Assume support for memcmp, memcpy, memmove, memset.
1740 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1741 * regex.c (memcmp, memcpy):
1742 Remove; we assume C89 now.
1744 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1745 (__malloc_safe_bcopy): Remove; no longer needed.
1747 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1748 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1749 well either way, and we prefer signed to unsigned.
1751 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1753 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1754 closes the connection while we're reading (bug#9182).
1756 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1758 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1759 are specified (Bug#9168).
1761 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1763 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1764 Found by GCC static checking and --with-wide-int on a 32-bit host.
1766 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1768 * xdisp.c (compute_display_string_pos): Fix logic of caching
1769 previous display string position. Initialize cached_prev_pos to
1770 -1. Fixes slow-down at the beginning of a buffer.
1772 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1774 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1775 for attrs[LFACE_FONTSET_INDEX].
1777 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1779 * xml.c (parse_region): Remove unused local
1780 that was recently introduced.
1782 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1784 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1785 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1787 * xdisp.c (move_it_in_display_line_to): Record the best matching
1788 position for TO_CHARPOS while scanning the line, and restore it on
1789 exit if none of the characters scanned was an exact match.
1790 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1791 when exact match is impossible due to invisible text, and the
1792 lines are truncated.
1794 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1796 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1799 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1801 Fix a significant slow-down of cursor motion with C-n, C-p,
1802 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1803 auto-repeat under bidi redisplay in fontified buffers.
1804 * xdisp.c (compute_stop_pos_backwards): New function.
1805 (next_element_from_buffer): Call compute_stop_pos_backwards to
1806 find a suitable prev_stop when we find ourselves before
1808 (reseat): Don't look for prev_stop, as that could mean a very long
1810 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1811 <cached_disp_overlay_modiff>: Cache for last found display string
1813 (compute_display_string_pos): Return the cached position if asked
1814 about the same buffer in the same area of character positions, and
1815 the buffer wasn't changed since the time the display string
1816 position was cached.
1818 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1820 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1821 is an integer, which is important for empty lines. (Bug#9149)
1823 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1825 * frame.c (Fmodify_frame_parameters): In tty case, update the
1826 default face if necessary (Bug#4238).
1828 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1830 * editfns.c (Fstring_to_char): No need to explain what a character
1831 is in the docstring (Bug#6576).
1833 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1835 * xml.c (parse_region): Make sure we always return a tree.
1837 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1839 * xml.c (parse_region): If a document contains only comments,
1842 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1844 * xml.c (make_dom): Return comments, too.
1846 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1849 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1850 and the surrounding thread.
1851 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1852 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1853 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1855 * s/openbsd.h (BROKEN_SIGIO): Define.
1856 * unexelf.c (unexec) [__OpenBSD__]:
1857 Don't update the .mdebug section of the Alpha COFF symbol table.
1859 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1861 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1864 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1866 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1867 This fixes some race conditions on the permissions of any newly
1870 * alloc.c (valid_pointer_p): Use pipe, not open.
1871 This fixes some permissions issues when debugging.
1873 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1874 If fchown fails to set both uid and gid, try to set just gid,
1875 as that is sometimes allowed. Adjust the file's mode to eliminate
1876 setuid or setgid bits that are inappropriate if fchown fails.
1878 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1880 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1881 to compare Lisp_Objects.
1882 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1883 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1884 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1886 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1888 * lread.c (read_integer): Unread even EOF character.
1889 (read1): Likewise. Properly record start position of symbol.
1891 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1892 symbol character follows.
1894 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1896 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1897 This works around a problem with the previous change to Fcopy_file.
1898 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1899 and without this change, GCC might complain about discarding
1900 fchown's return value.
1902 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1904 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1906 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1908 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1910 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1912 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1913 it's used from the C level.
1915 * process.c: Use the same condition for POLL_FOR_INPUT in both
1916 keyboard.c and process.c (bug#1858).
1918 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1920 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1921 (Fgnutls_boot): Use it.
1923 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1925 * doc.c (Fsubstitute_command_keys): Revert last change.
1927 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1929 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1930 quotes the next character, and doesn't affect other longer
1931 sequences (bug#8935).
1933 * lread.c (syms_of_lread): Clarify that is isn't only
1934 `eval-buffer' and `eval-defun' that's affected by
1935 `lexical-binding' (bug#8460).
1937 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1939 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1940 bidi redisplay when a line includes both an image and is
1943 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1945 Fix minor problems found by static checking.
1946 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1947 (elsz): Now a signed constant, not a size_t var. We prefer signed
1948 types to unsigned, to avoid integer comparison confusion. Without
1949 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1950 "cannot optimize loop, the loop counter may overflow", a symptom
1952 * indent.c (Fvertical_motion): Mark locals as initialized.
1953 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1955 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1957 * search.c (Fre_search_backward): Mention `case-fold-search' in
1958 all the re_search_* functions (bug#8138).
1960 * keyboard.c (Fopen_dribble_file): Document when the file is
1963 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1965 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1968 Support bidi reordering of display and overlay strings.
1969 * xdisp.c (compute_display_string_pos)
1970 (compute_display_string_end): Accept additional argument STRING.
1971 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1972 (reseat_to_string): Initialize bidi_it->string.s and
1973 bidi_it->string.schars.
1974 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1975 NULL (avoids a crash in bidi_paragraph_init).
1976 Initialize itb.string.lstring.
1977 (init_iterator): Call bidi_init_it only of a valid
1978 buffer position was specified. Initialize paragraph_embedding to
1980 (reseat_to_string): Initialize the bidi iterator.
1981 (display_string): If we need to ignore text properties of
1982 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1983 original value of -1 will not work with bidi.)
1984 (compute_display_string_pos): First arg is now struct
1985 `text_pos *'; all callers changed. Support display properties on
1987 (compute_display_string_end): Support display properties on Lisp
1989 (init_iterator, reseat_1, reseat_to_string): Initialize the
1990 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1991 when iterating on a string not from display properties).
1992 (compute_display_string_pos, compute_display_string_end):
1993 Fix calculation of the object to scan. Fixes an error when using
1995 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1996 base_level_stop; instead, set base_level_stop to BEGV.
1997 Fixes crashes in vertical-motion.
1998 (next_element_from_buffer): Improve commentary for when
1999 the iterator is before prev_stop.
2000 (init_iterator): Initialize bidi_p from the default value of
2001 bidi-display-reordering, not from buffer-local value. Use the
2002 buffer-local value only if initializing for buffer iteration.
2003 (handle_invisible_prop): Support invisible properties on strings
2004 that are being bidi-reordered.
2005 (set_iterator_to_next): Support bidi reordering of C strings and
2007 (next_element_from_string): Support bidi reordering of Lisp
2009 (handle_stop_backwards): Support Lisp strings as well.
2010 (display_string): Support display of R2L glyph rows.
2011 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2012 (init_iterator): Don't initialize it->bidi_p for strings
2014 (reseat_to_string): Initialize it->bidi_p for strings here.
2015 (next_element_from_string, next_element_from_c_string)
2016 (next_element_from_buffer): Add xassert's for correspondence
2017 between IT's object being iterated and it->bidi_it.string
2019 (face_before_or_after_it_pos): Support bidi iteration.
2020 (next_element_from_c_string): Handle the case of the first string
2021 character that is not the first one in the visual order.
2022 (get_visually_first_element): New function, refactored from common
2023 parts of next_element_from_buffer, next_element_from_string, and
2024 next_element_from_c_string.
2025 (tool_bar_lines_needed, redisplay_tool_bar)
2026 (display_menu_bar): Force left-to-right direction. Add a FIXME
2027 comment for making that be controlled by a user option.
2028 (push_it, pop_it): Save and restore the state of the
2029 bidi iterator. Save and restore the bidi_p flag.
2030 (pop_it): Iterate out of display property for string iteration as
2032 (iterate_out_of_display_property): Support iteration over strings.
2033 (handle_single_display_spec): Set up it->bidi_it for iteration
2034 over a display string, and call bidi_init_it.
2035 (handle_single_display_spec, next_overlay_string)
2036 (get_overlay_strings_1, push_display_prop): Set up the bidi
2037 iterator for displaying display or overlay strings.
2038 (forward_to_next_line_start): Don't use the shortcut if
2040 (back_to_previous_visible_line_start): If handle_display_prop
2041 pushed the iterator stack, restore the internal state of the bidi
2042 iterator by calling bidi_pop_it same number of times.
2043 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2044 and we are bidi-iterating, don't decrement the iterator position;
2045 instead, set the first_elt flag in the bidi iterator, to produce
2047 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2048 (push_display_prop): xassert that we are iterating a buffer.
2049 (push_it, pop_it): Save and restore paragraph_embedding member.
2050 (handle_single_display_spec, next_overlay_string)
2051 (get_overlay_strings_1, reseat_1, reseat_to_string)
2052 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2053 correctly. Don't assume unibyte strings are not bidi-reordered.
2054 (compute_display_string_pos)
2055 (compute_display_string_end): Fix handling the case of C string.
2056 (push_it, pop_it): Save and restore from_disp_prop_p.
2057 (handle_single_display_spec, push_display_prop): Set the
2058 from_disp_prop_p flag.
2059 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2060 (pop_it): Call iterate_out_of_display_property only if we are
2061 popping after iteration over a string that came from a display
2062 property. Fix a typo in popping stretch info. Add an assertion
2063 for verifying that the iterator position is in sync with the bidi
2065 (handle_single_display_spec, get_overlay_strings_1)
2066 (push_display_prop): Fix initialization of paragraph direction for
2067 string when that of the parent object is not yet determined.
2068 (reseat_1): Call bidi_init_it to resync the bidi
2069 iterator with IT's position. (Bug#7616)
2070 (find_row_edges): If ROW->start.pos gives position
2071 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2072 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2073 Reset the from_disp_prop_p flag.
2074 (SAVE_IT, RESTORE_IT): New macros.
2075 (pos_visible_p, face_before_or_after_it_pos)
2076 (back_to_previous_visible_line_start)
2077 (move_it_in_display_line_to, move_it_in_display_line)
2078 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2079 (try_scrolling, redisplay_window, display_line): Use them when
2080 saving a temporary copy of the iterator and restoring it back.
2081 (back_to_previous_visible_line_start, reseat_1)
2082 (init_iterator): Empty the bidi cache "stack".
2083 (move_it_in_display_line_to): If iterator ended up at
2084 EOL, but we never saw any buffer positions smaller than
2085 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2086 motion in bidi-reordered lines.
2087 (move_it_in_display_line_to): Record prev_method and prev_pos
2088 immediately before the call to set_iterator_to_next. Fixes cursor
2089 motion in bidi-reordered lines with stretch glyphs and strings
2090 displayed in margins. (Bug#8133) (Bug#8867)
2091 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2093 (pos_visible_p): Support positions in bidi-reordered lines.
2094 Save and restore bidi cache.
2096 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2097 (bidi_paragraph_info): Delete unused struct.
2098 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2099 (bidi_cache_start): New variable.
2100 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2102 (bidi_cache_fetch_state, bidi_cache_search)
2103 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2104 (bidi_cache_find, bidi_peek_at_next_level)
2105 (bidi_level_of_next_char, bidi_find_other_level_edge)
2106 (bidi_move_to_visually_next): Compare cache index with
2107 bidi_cache_start rather than with zero.
2108 (bidi_fetch_char): Accept new argument STRING; all callers
2109 changed. Support iteration over a string. Support strings with
2110 display properties. Support unibyte strings. Fix the type of
2111 `len' according to what STRING_CHAR_AND_LENGTH expects.
2112 (bidi_paragraph_init, bidi_resolve_explicit_1)
2113 (bidi_resolve_explicit, bidi_resolve_weak)
2114 (bidi_level_of_next_char, bidi_move_to_visually_next):
2115 Support iteration over a string.
2116 (bidi_set_sor_type, bidi_resolve_explicit_1)
2117 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2118 can now be zero (for strings); special values 0 and -1 were
2119 changed to -1 and -2, respectively.
2120 (bidi_char_at_pos): New function.
2121 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2122 Call it instead of FETCH_MULTIBYTE_CHAR.
2123 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2124 initialized to valid values.
2125 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2127 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2128 the test for valid cached positions. Fix the logic for looking up
2129 the sentinel state in the cache. GCPRO the Lisp string we are
2131 (bidi_push_it, bidi_pop_it): New functions.
2132 (bidi_initialize): Initialize the bidi cache start stack pointer.
2133 (bidi_cache_ensure_space): New function, refactored from part of
2134 bidi_cache_iterator_state. Don't assume the required size is just
2135 one BIDI_CACHE_CHUNK away.
2136 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2137 (bidi_count_bytes, bidi_char_at_pos): New functions.
2138 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2139 always valid if bidi_cache_idx is valid.
2140 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2141 is valid if it's going to be used.
2142 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2143 (bidi_cache_fetch_state, bidi_cache_search)
2144 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2145 (bidi_cache_iterator_state, bidi_cache_find)
2146 (bidi_find_other_level_edge, bidi_cache_start_stack):
2147 All variables related to cache indices are now EMACS_INT.
2149 * dispextern.h (struct bidi_string_data): New structure.
2150 (struct bidi_it): New member `string'. Make flag members be 1-bit
2151 fields, and put them last in the struct.
2152 (compute_display_string_pos, compute_display_string_end):
2154 (bidi_push_it, bidi_pop_it): Add prototypes.
2155 (struct iterator_stack_entry): New members bidi_p,
2156 paragraph_embedding, and from_disp_prop_p.
2157 (struct it): Member bidi_p is now a bit field 1 bit wide.
2158 (bidi_shelve_cache, bidi_unshelve_cache):
2161 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2162 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2163 and vector-like objects.
2165 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2166 cache around display iteration.
2168 * window.c (Fwindow_end, window_scroll_pixel_based)
2169 (displayed_window_lines, Frecenter): Save and restore the bidi
2170 cache around display iteration.
2172 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2174 * editfns.c (Fdelete_region): Clarify the use of the named
2175 parameters (bug#6788).
2177 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2179 * indent.c (Fvertical_motion): Set and restore w->pointm when
2180 saving and restoring the window's buffer (Bug#9006).
2182 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2184 * editfns.c (Fstring_to_char): Clarify just what is returned
2185 (bug#6576). Text by Eli Zaretskii.
2187 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2189 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2191 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2193 * buffer.c (mmap_find): Fix a typo.
2195 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2197 Fix execution of x selection hooks.
2198 * xselect.c (Qx_lost_selection_functions)
2199 (Qx_sent_selection_functions): New vars.
2200 (syms_of_xselect): DEFSYM them.
2201 (x_handle_selection_request): Pass Qx_sent_selection_functions
2202 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2203 (x_handle_selection_clear,x_clear_frame_selections):
2204 Pass Qx_lost_selection_functions rather than
2205 Vx_lost_selection_functions to Frun_hook_with_args.
2207 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2209 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2210 The old code sometimes used this field without initializing it.
2212 * alloc.c (gc_sweep): Don't read past end of array.
2213 In theory, the old code could also have corrupted Emacs internals,
2214 though it'd be very unlikely.
2216 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2218 * character.c (Fcharacterp): Don't advertise optional ignored
2219 argument. (Bug#4026)
2221 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2223 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2226 * window.c (Fset_window_start): Doc fix (bug#4199).
2227 (Fset_window_hscroll): Ditto.
2229 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2231 Fix minor new problems caught by GCC 4.6.1.
2232 * term.c (init_tty): Remove unused local.
2233 * xsettings.c (store_monospaced_changed): Define this function only
2234 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2237 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2239 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2241 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2243 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2244 are the mini-buffer and the echo area (bug#3320).
2246 * term.c (init_tty): Remove support for supdup, c10 and perq
2247 terminals, which are no longer supported (bug#1482).
2249 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2251 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2253 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2255 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2256 for non-popups (Bug#3642).
2258 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2260 * alloc.c (reset_malloc_hooks): Protoize.
2261 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2262 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2263 * cm.c (losecursor): Likewise.
2264 * data.c (fmod): Likewise.
2265 * dispnew.c (swap_glyphs_in_rows): Likewise.
2266 * emacs.c (memory_warning_signal): Likewise.
2267 * floatfns.c (float_error): Likewise.
2268 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2269 (otf_open, font_otf_capability, generate_otf_features)
2270 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2272 * image.c (pbm_read_file): Likewise.
2273 * indent.c (string_display_width): Likewise.
2274 * intervals.c (check_for_interval, search_for_interval)
2275 (inc_interval_count, count_intervals, root_interval)
2276 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2277 * lread.c (defalias): Likewise.
2278 * ralloc.c (r_alloc_check): Likewise.
2279 * regex.c (set_image_of_range_1, set_image_of_range)
2280 (regex_grow_registers): Likewise.
2281 * sysdep.c (strerror): Likewise.
2282 * termcap.c (valid_filename_p, tprint, main): Likewise.
2283 * tparam.c (main): Likewise.
2284 * unexhp9k800.c (run_time_remap, save_data_space)
2285 (update_file_ptrs, read_header, write_header, calculate_checksum)
2286 (copy_file, copy_rest, display_header): Likewise.
2287 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2289 * xdisp.c (check_it): Likewise.
2290 * xfaces.c (register_color, unregister_color, unregister_colors):
2292 * xfns.c (print_fontset_result): Likewise.
2293 * xrdb.c (member, fatal, main): Likewise.
2295 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2297 Fix minor problems found by static checking (Bug#9031).
2298 * chartab.c (char_table_set_range, map_sub_char_table):
2299 Remove unused locals.
2300 (uniprop_table): Now static.
2301 * composite.c (_work_char): Remove unused static var.
2303 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2305 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2307 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2309 * gtkutil.c (qttip_cb): Remove code without function.
2311 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2313 * w32.c (pthread_sigmask): New stub.
2315 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2317 Use pthread_sigmask, not sigprocmask (Bug#9010).
2318 sigprocmask is portable only for single-threaded applications, and
2319 Emacs can be multi-threaded when it uses GTK.
2320 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2322 * callproc.c (Fcall_process):
2323 * process.c (create_process):
2324 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2325 Use pthread_sigmask, not sigprocmask.
2327 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2329 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2330 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2333 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2335 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2336 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2337 (xg_hide_tooltip): Fix comment.
2339 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2340 in registerServicesMenuSendTypes.
2341 (validRequestorForSendType): Don't check ns_return_types.
2343 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2346 2011-07-08 Jason Rumney <jasonr@gnu.org>
2348 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2349 frame struct members of non-existent frames (Bug#6284).
2351 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2353 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2354 variable firstTime not needed on OSX >= 10.6.
2355 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2356 >= 10.5. Use setKnobProportion, setDoubleValue.
2358 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2359 (MAC_OS_X_VERSION_10_5): Define if not defined.
2360 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2361 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2362 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2364 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2365 cString and lossyCString on OSX >= 10.4
2367 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2368 sizeToFit on OSX >= 10.2.
2370 * nsimage.m (allocInitFromFile): Don't use deprecated method
2371 bestRepresentationForDevice on OSX >= 10.6.
2373 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2376 * emacs.c: Declare unexec_init_emacs_zone.
2378 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2380 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2382 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2383 on svcsMenu (Bug#8842).
2385 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2387 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2389 * nsterm.m (QUTF8_STRING): Declare.
2390 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2391 (validRequestorForSendType): Return type is (id).
2392 Change indexOfObjectIdenticalTo to indexOfObject.
2393 Check if we have local selection before returning self (Bug#8842).
2394 (writeSelectionToPasteboard): Put local selection into paste board
2395 if we have a local selection (Bug#8842).
2396 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2398 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2399 (ns_get_local_selection): Declare.
2401 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2403 * keymap.c (describe_map_tree): Don't insert a double newline at
2404 the end of the buffer (bug#1169) and return whether we inserted
2407 * callint.c (Fcall_interactively): Change "reading args" to
2408 "providing args" to try to clarify what it does (bug#1010).
2410 2011-07-07 Kenichi Handa <handa@m17n.org>
2412 * composite.c (composition_compute_stop_pos): Ignore a static
2413 composition starting before CHARPOS (Bug#8915).
2415 * xdisp.c (handle_composition_prop): Likewise.
2417 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2419 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2422 2011-07-07 Kenichi Handa <handa@m17n.org>
2424 * character.h (unicode_category_t): New enum type.
2426 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2427 (Qchar_code_property_table): New variable.
2428 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2429 (UNIPROP_COMPRESSED_FORM_P): New macros.
2430 (char_table_ascii): Uncompress the compressed values.
2431 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2432 Uncompress the compressed values.
2433 (sub_char_table_ref_and_range): Likewise.
2434 (char_table_ref_and_range): Uncompress the compressed values.
2435 (sub_char_table_set): New arg is_uniprop. Callers changed.
2436 Uncompress the compressed values.
2437 (sub_char_table_set_range): Args changed. Callers changed.
2438 (char_table_set_range): Adjuted for the above change.
2439 (map_sub_char_table): Delete args default_val and parent. Add arg
2440 top. Give decoded values to a Lisp function.
2441 (map_char_table): Adjust for the above change. Give decoded
2442 values to a Lisp function. Gcpro more variables.
2443 (uniprop_table_uncompress)
2444 (uniprop_decode_value_run_length): New functions.
2445 (uniprop_decoder, uniprop_decoder_count): New variables.
2446 (uniprop_get_decoder, uniprop_encode_value_character)
2447 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2449 (uniprop_encoder, uniprop_encoder_count): New variables.
2450 (uniprop_get_encoder, uniprop_table)
2451 (Funicode_property_table_internal, Fget_unicode_property_internal)
2452 (Fput_unicode_property_internal): New functions.
2453 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2454 Sunicode_property_table_internal, Sget_unicode_property_internal,
2455 and Sput_unicode_property_internal. Defvar_lisp
2456 char-code-property-alist.
2458 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2459 Vunicode_category_table.
2461 * font.c (font_range): Adjust for the change of
2462 Vunicode_category_table.
2464 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2466 * m/iris4d.h: Remove file, move contents ...
2467 * s/irix6-5.h: ... here.
2469 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2471 Remove unportable assumption about struct layout (Bug#8884).
2472 * alloc.c (mark_buffer):
2473 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2474 (clone_per_buffer_values): Don't assume that
2475 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2476 This isn't true in general, and it's particularly not true
2477 if Emacs is configured with --with-wide-int.
2478 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2479 New macros, used in the buffer.c change.
2481 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2483 * xsettings.c: Use both GConf and GSettings if both are available.
2484 (store_config_changed_event): Add comment.
2485 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2486 (store_tool_bar_style_changed): New functions.
2487 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2488 (struct xsettings): Move font inside HAVE_XFT.
2489 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2490 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2491 Move inside HAVE_XFT.
2492 (something_changed_gsettingsCB): Rename from something_changedCB.
2493 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2495 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2496 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2497 (something_changed_gconfCB): Rename from something_changedCB.
2498 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2499 (parse_settings): Move check for font inside HAVE_XFT.
2500 (read_settings, apply_xft_settings): Add comment.
2501 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2502 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2503 call store_font_name_changed.
2504 (xft_settings_event): Add comment.
2505 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2506 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2507 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2508 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2509 (xsettings_initialize): Call init_gsettings last.
2510 (xsettings_get_system_font, xsettings_get_system_normal_font):
2513 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2515 Random fixes. E.g., (random) never returned negative values.
2516 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2517 subseconds part to the entropy, as that's a bit more random.
2518 Prefer signed to unsigned, since the signedness doesn't matter and
2519 in general we prefer signed. When given a limit, use a
2520 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2521 latter isn't right if USE_2_TAGS_FOR_INTS.
2522 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2523 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2525 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2527 * textprop.c (text_property_stickiness):
2528 Obey Vtext_property_default_nonsticky.
2529 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2530 * w32fns.c (syms_of_w32fns):
2531 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2533 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2535 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2536 This is more efficient than Ffile_directory_p and avoids a minor race.
2538 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2540 * buffer.c (Foverlay_put): Say what the return value is
2543 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2544 is a directory before asking whether to use the file name
2546 (barf_or_query_if_file_exists): Make the "File is a directory"
2547 error be more correct.
2549 * fns.c (Frequire): Remove the mention of the .gz files, since
2550 that's installation-specific, but keep the mention of
2551 `get-load-suffixes'.
2553 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2555 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2556 Report string overflow if the output is too long.
2558 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2560 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2561 (syms_of_gnutls): Remove duplicate DEFSYM for
2562 Qgnutls_bootprop_verify_hostname_error, an error for
2563 Qgnutls_bootprop_verify_error (which is no longer used).
2565 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2566 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2567 Also (re)move comments that are misplaced or no longer relevant.
2569 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2571 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2573 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2575 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2576 and background color parameters if they have been changed.
2578 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2580 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2582 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2584 * xsettings.c (SYSTEM_FONT): Define only when used.
2585 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2587 * keymap.c (access_keymap_1): Now static.
2589 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2591 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2592 leave any prefix arg for the up event (Bug#1586).
2594 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2596 * lread.c (syms_of_lread): Mention single symbols defined by
2597 `defvar' or `defconst' (bug#7154).
2599 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2600 (Frequire): Mention get-load-suffixes.
2602 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2604 * window.h (window): Remove clone_number slot.
2605 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2607 (make_parent_window, make_window, saved_window)
2608 (Fset_window_configuration, save_window_save): Don't deal with
2610 * buffer.c (Qclone_number): Remove declaration.
2611 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2613 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2615 Add multiple inheritance to keymaps.
2616 * keymap.c (Fmake_composed_keymap): New function.
2617 (Fset_keymap_parent): Simplify.
2618 (fix_submap_inheritance): Remove.
2619 (access_keymap_1): New function extracted from access_keymap to handle
2620 embedded parents and handle lists of maps.
2621 (access_keymap): Use it.
2622 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2623 (Fcopy_keymap): Handle embedded parents.
2624 (Fcommand_remapping, define_as_prefix): Simplify.
2625 (Fkey_binding): Simplify.
2626 (syms_of_keymap): Move minibuffer-local-completion-map,
2627 minibuffer-local-filename-completion-map,
2628 minibuffer-local-must-match-map, and
2629 minibuffer-local-filename-must-match-map to Elisp.
2630 (syms_of_keymap): Defsubr make-composed-keymap.
2631 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2632 (parse_menu_item): Trivial simplification.
2634 2011-07-01 Glenn Morris <rgm@gnu.org>
2636 * Makefile.in (SETTINGS_LIBS): Fix typo.
2638 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2640 * coding.c (Fencode_coding_string): Record the last coding system
2641 used, as the function doc string says (bug#8738).
2643 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2645 * xsettings.c (store_monospaced_changed): Take new font as arg and
2646 check for change against current_mono_font.
2647 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2648 (emacs_settings_constructor, emacs_settings_get_property)
2649 (emacs_settings_set_property, emacs_settings_class_init)
2650 (emacs_settings_init, gsettings_obj): Remove.
2651 (something_changedCB): New function for HAVE_GSETTINGS.
2652 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2653 with value as argument.
2654 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2655 g_settings_new (Bug#8967). Do not create gsettings_obj.
2656 Remove calls to g_settings_bind. Connect something_changedCB to
2659 * xgselect.c: Add defined (HAVE_GSETTINGS).
2660 (xgselect_initialize): Ditto.
2662 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2663 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2666 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2668 * eval.c (struct backtrace): Simplify and port the data structure.
2669 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2670 signed bit field, as this assumption is not portable and it makes
2671 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2672 "char debug_on_exit : 1" as this is not portable either; instead,
2673 use the portable "unsigned int debug_on_exit : 1". Remove unused
2674 member evalargs. Remove obsolete comments about cc bombing out.
2676 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2678 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2679 Let HAVE_GSETTINGS override HAVE_GCONF.
2680 (store_monospaced_changed): New function.
2681 (EMACS_SETTINGS): A new type derived from GObject to handle
2682 GSettings notifications.
2683 (emacs_settings_constructor, emacs_settings_get_property)
2684 (emacs_settings_set_property, emacs_settings_class_init):
2686 (gsettings_client, gsettings_obj): New variables.
2687 (GSETTINGS_SCHEMA): New define.
2688 (something_changedCB): Call store_monospaced_changed.
2689 (init_gsettings): New function.
2690 (xsettings_initialize): Call init_gsettings.
2691 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2694 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2697 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2699 * window.c (resize_root_window, grow_mini_window)
2700 (shrink_mini_window): Rename Qresize_root_window to
2701 Qwindow_resize_root_window and Qresize_root_window_vertically to
2702 Qwindow_resize_root_window_vertically.
2704 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2706 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2708 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2710 * makefile.w32-in: Redesign dependencies so they reflect more
2711 clearly which files are directly included by each source file,
2712 and not through other includes.
2714 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2716 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2717 (sort_overlays, overlay_strings): When an overlay's clone number
2718 matches the window's clone number process the overlay even if
2719 the overlay's window property doesn't match the current window.
2721 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2722 (Fwindow_hchild): Rename to Fwindow_left_child.
2723 (Fwindow_next): Rename to Fwindow_next_sibling.
2724 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2725 (resize_window_check): Rename to window_resize_check.
2726 (resize_window_apply): Rename to window_resize_apply.
2727 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2728 (Fdelete_other_windows_internal, resize_frame_windows)
2729 (Fsplit_window_internal, Fdelete_window_internal)
2730 (grow_mini_window, shrink_mini_window)
2731 (Fresize_mini_window_internal): Fix callers accordingly.
2733 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2735 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2736 (emacs_fixed_set_min_size): Remove.
2737 (emacs_fixed_new): Take frame as argument.
2739 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2740 (_EmacsFixedPrivate): Remove minwidth/height.
2741 Add struct frame *f.
2742 (emacs_fixed_init): Initialize priv->f.
2743 (get_parent_class, emacs_fixed_set_min_size): Remove.
2744 (emacs_fixed_new): Set priv->f to argument.
2745 (emacs_fixed_get_preferred_width)
2746 (emacs_fixed_get_preferred_height): Use min_width/height from
2747 frames size_hint to set minimum and natural (Bug#8919).
2748 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2749 and use min_width/height from frames size_hint to set
2750 min_width/height (Bug#8919).
2752 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2753 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2756 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2758 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2759 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2762 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2764 * process.c (wait_reading_process_output): Bypass select if
2765 waiting for a cell while ignoring keyboard input, and input is
2766 pending. Suggested by Jan Djärv (Bug#8869).
2768 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2770 Use gnulib's dup2 module instead of rolling our own.
2771 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2773 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2775 * dispnew.c (scrolling_window): Before scrolling, turn off a
2776 mouse-highlight in the window being scrolled.
2778 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2780 Move DEFSYM to lisp.h and use everywhere.
2782 * character.h (DEFSYM): Move declaration...
2783 * lisp.h (DEFSYM): ...here.
2789 * w32select.c: Don't include character.h.
2791 * alloc.c (syms_of_alloc):
2792 * buffer.c (syms_of_buffer):
2793 * bytecode.c (syms_of_bytecode):
2794 * callint.c (syms_of_callint):
2795 * casefiddle.c (syms_of_casefiddle):
2796 * casetab.c (init_casetab_once):
2797 * category.c (init_category_once, syms_of_category):
2798 * ccl.c (syms_of_ccl):
2799 * cmds.c (syms_of_cmds):
2800 * composite.c (syms_of_composite):
2801 * dbusbind.c (syms_of_dbusbind):
2802 * dired.c (syms_of_dired):
2803 * dispnew.c (syms_of_display):
2804 * doc.c (syms_of_doc):
2805 * editfns.c (syms_of_editfns):
2806 * emacs.c (syms_of_emacs):
2807 * eval.c (syms_of_eval):
2808 * fileio.c (syms_of_fileio):
2809 * fns.c (syms_of_fns):
2810 * frame.c (syms_of_frame):
2811 * fringe.c (syms_of_fringe):
2812 * insdel.c (syms_of_insdel):
2813 * keymap.c (syms_of_keymap):
2814 * lread.c (init_obarray, syms_of_lread):
2815 * macros.c (syms_of_macros):
2816 * msdos.c (syms_of_msdos):
2817 * print.c (syms_of_print):
2818 * process.c (syms_of_process):
2819 * search.c (syms_of_search):
2820 * sound.c (syms_of_sound):
2821 * syntax.c (init_syntax_once, syms_of_syntax):
2822 * terminal.c (syms_of_terminal):
2823 * textprop.c (syms_of_textprop):
2824 * undo.c (syms_of_undo):
2825 * w32.c (globals_of_w32):
2826 * window.c (syms_of_window):
2827 * xdisp.c (syms_of_xdisp):
2828 * xfaces.c (syms_of_xfaces):
2829 * xfns.c (syms_of_xfns):
2830 * xmenu.c (syms_of_xmenu):
2831 * xsettings.c (syms_of_xsettings):
2832 * xterm.c (syms_of_xterm): Use DEFSYM.
2834 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2836 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2838 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2840 Integer and buffer overflow fixes (Bug#8873).
2842 * print.c (printchar, strout): Check for string overflow.
2843 (PRINTPREPARE, printchar, strout):
2844 Don't set size unless allocation succeeds.
2846 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2847 for sizes. Check for string overflow more accurately.
2848 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2850 * macros.c: Integer and buffer overflow fixes.
2851 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2852 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2853 Use ptrdiff_t, not int, for sizes.
2854 Don't increment bufsize until after realloc succeeds.
2855 Check for size-calculation overflow.
2856 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2858 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2860 * lread.c: Integer overflow fixes.
2861 (read_integer): Radix is now EMACS_INT, not int,
2862 to improve quality of diagnostics for out-of-range radices.
2863 Calculate buffer size correctly for out-of-range radices.
2864 (read1): Check for integer overflow in radices, and in
2865 read-circle numbers.
2866 (read_escape): Avoid int overflow.
2867 (Fload, openp, read_buffer_size, read1)
2868 (substitute_object_recurse, read_vector, read_list, map_obarray):
2869 Use ptrdiff_t, not int, for sizes.
2870 (read1): Use EMACS_INT, not int, for sizes.
2871 Check for size overflow.
2873 * image.c (cache_image): Check for size arithmetic overflow.
2875 * lread.c: Integer overflow issues.
2876 (saved_doc_string_size, saved_doc_string_length)
2877 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2878 Now ptrdiff_t, not int.
2879 (read1): Don't assume doc string length fits in int. Check for
2880 out-of-range doc string lengths.
2881 (read_list): Don't assume file position fits in int.
2882 (read_escape): Check for hex character overflow.
2884 2011-06-22 Leo Liu <sdl.web@gmail.com>
2886 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2887 Move to minibuffer.el.
2889 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2891 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2892 The following patches are for when GLYPH_DEBUG && !XASSERT.
2893 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2894 * dispnew.c (flush_stdout):
2895 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2896 Mark as externally visible.
2897 * dispnew.c (check_window_matrix_pointers): Now static.
2898 * dispnew.c (window_to_frame_vpos):
2899 * xfns.c (unwind_create_frame):
2900 * xterm.c (x_check_font): Remove unused local.
2901 * scroll.c (CHECK_BOUNDS):
2902 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2903 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2904 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2905 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2906 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2908 (debug_method_add): Use va_list and vsprintf rather than relying
2909 on undefined behavior with wrong number of arguments.
2910 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2911 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2912 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2913 since we're not interested in debugging glyphs with old libraries.
2914 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2915 GCC 4.6.0's static checking.
2917 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2919 Integer overflow and signedness fixes (Bug#8873).
2920 A few related buffer overrun fixes, too.
2922 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2924 * dispextern.h (struct face.stipple):
2925 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2926 (x_bitmap_mask, x_allocate_bitmap_record)
2927 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2928 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2929 (x_create_bitmap_from_xpm_data):
2930 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2931 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2933 * xfaces.c (load_pixmap):
2934 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2935 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2936 (.bitmaps_last, struct x_output.icon_bitmap):
2937 Use ptrdiff_t, not int, for bitmap indexes.
2938 (x_allocate_bitmap_record): Check for size overflow.
2939 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2941 Use ptrdiff_t, not int, for overlay counts.
2942 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2943 * editfns.c (overlays_around, get_pos_property):
2944 * textprop.c (get_char_property_and_overlay):
2945 * xdisp.c (next_overlay_change, note_mouse_highlight):
2946 * xfaces.c (face_at_buffer_position):
2947 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2948 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2949 (Fnext_overlay_change, Fprevious_overlay_change)
2950 (mouse_face_overlay_overlaps, Foverlays_in):
2951 Use ptrdiff_t, not int, for sizes.
2952 (overlays_at, overlays_in): Check for size-calculation overflow.
2954 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2956 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2957 (x_session_initialize): Do not assume string length fits in int.
2959 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2960 This is unlikely, but can occur if DPI is outlandish.
2962 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2963 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2965 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2966 * xrdb.c (magic_file_p, search_magic_path):
2967 Omit last arg SUFFIX; it was always 0. All callers changed.
2968 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2970 * xfont.c (xfont_match): Avoid need for strlen.
2972 * xfns.c: Don't assume strlen fits in int.
2973 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2975 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2976 not unsigned long, as we prefer signed integers. All callers changed.
2977 Detect integer overflow in repeat count.
2978 (message_dolog): Don't assume print length fits in 39 bytes.
2979 (display_mode_element): Don't assume strlen fits in int.
2981 * termcap.c: Don't assume sizes fit in int and never overflow.
2982 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2983 (gobble_line): Check for size-calculation overflow.
2985 * minibuf.c (Fread_buffer):
2986 * lread.c (intern, intern_c_string):
2987 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2988 Don't assume string length fits in int.
2990 * keyboard.c (parse_tool_bar_item):
2991 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2993 * font.c: Don't assume string length fits in int.
2994 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2995 Use ptrdiff_t, not int.
2996 (font_intern_prop): Don't assume string length fits in int.
2997 Don't assume integer property fits in fixnum.
2998 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3000 * filelock.c: Fix some buffer overrun and integer overflow issues.
3001 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3002 Reformulate so as not to need the command string.
3003 Invoke gzip -cd rather than gunzip, as it's more portable.
3004 (lock_info_type, lock_file_1, lock_file):
3005 Don't assume pid_t and time_t fit in unsigned long.
3006 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3007 (current_lock_owner): Prefer signed type for sizes.
3008 Use memcpy, not strncpy, where memcpy is what is really wanted.
3009 Don't assume (via atoi) that time_t and pid_t fit in int.
3010 Check for time_t and/or pid_t out of range, e.g., via a network share.
3011 Don't alloca where an auto var works fine.
3013 * fileio.c: Fix some integer overflow issues.
3014 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3015 Don't assume string length fits in int.
3016 (directory_file_name): Don't assume string length fits in long.
3017 (make_temp_name): Don't assume pid fits in int, or that its print
3018 length is less than 20.
3020 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3022 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3024 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3026 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3027 We prefer signed integers, even for size calculations.
3029 * emacs.c: Don't assume string length fits in 'int'.
3030 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3031 (main): Don't invoke strlen when not needed.
3033 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3034 (XD_DEBUG_MESSAGE): Don't waste a byte.
3036 * callproc.c (getenv_internal_1, getenv_internal)
3038 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3040 * lread.c (invalid_syntax): Omit length argument.
3041 All uses changed. This doesn't fix a bug, but it simplifies the
3042 code away from its former Hollerith-constant appearance, and it's
3043 one less 'int' to worry about when looking at integer-overflow issues.
3044 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3046 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3047 This didn't break anything, but it didn't help either.
3048 It's confusing to put a bogus integer in a place where the actual
3049 value does not matter.
3050 (LIST_END_P): Remove unused macro and its bogus comment.
3051 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3053 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3054 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3056 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3057 We prefer signed types, and the value cannot exceed the EMACS_INT
3058 range anyway (because otherwise the length would not be representable).
3059 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3060 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3061 This avoids a GCC warning when WIDE_EMACS_INT.
3063 * indent.c (sane_tab_width): New function.
3064 (current_column, scan_for_column, Findent_to, position_indentation)
3065 (compute_motion): Use it. This is just for clarity.
3066 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3068 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3070 * lisp.h (lint_assume): New macro.
3071 * composite.c (composition_gstring_put_cache):
3072 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3074 * editfns.c, insdel.c:
3075 Omit unnecessary forward decls, to simplify future changes.
3077 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3079 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3081 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3082 Use much-faster test for byte-length change.
3083 Don't assume string byte-length fits in 'int'.
3084 Check that character arg fits in 'int'.
3085 (mapcar1): Declare byte as byte, for clarity.
3087 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3089 * fns.c (concat): Catch string overflow earlier.
3090 Do not rely on integer wraparound.
3092 * dispextern.h (struct it.overlay_strings_charpos)
3093 (struct it.selective): Now EMACS_INT, not int.
3094 * xdisp.c (forward_to_next_line_start)
3095 (back_to_previous_visible_line_start)
3096 (reseat_at_next_visible_line_start, next_element_from_buffer):
3097 Don't arbitrarily truncate the value of 'selective' to int.
3099 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3101 * composite.c: Don't truncate sizes to 'int'.
3102 (composition_gstring_p, composition_reseat_it)
3103 (composition_adjust_point): Use EMACS_INT, not int.
3104 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3105 not EMACS_UINT, for indexes.
3107 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3109 * buffer.c: Include <verify.h>.
3110 (struct sortvec.priority, struct sortstr.priority):
3111 Now EMACS_INT, not int.
3112 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3113 (struct sortstr.size, record_overlay_string)
3114 (struct sortstrlist.size, struct sortlist.used):
3115 Don't truncate size to int.
3116 (record_overlay_string): Check for size-calculation overflow.
3117 (init_buffer_once): Check at compile-time, not run-time.
3119 2011-06-22 Jim Meyering <meyering@redhat.com>
3121 Don't leak an XBM-image-sized buffer
3122 * image.c (xbm_load): Free the image buffer after using it.
3124 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3127 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3128 that Sun C diagnosed.
3129 * fns.c (secure_hash): Fix pointer signedness issue.
3130 * intervals.c (static_offset_intervals): New function.
3131 (offset_intervals): Use it.
3133 2011-06-21 Leo Liu <sdl.web@gmail.com>
3136 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3139 * fns.c (secure_hash): Rename from crypto_hash_function and change
3140 the first arg to accept symbols.
3141 (Fsecure_hash): New primitive.
3142 (syms_of_fns): New symbols.
3144 2011-06-20 Deniz Dogan <deniz@dogan.se>
3146 * process.c (Fset_process_buffer): Clarify return value in
3149 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3151 * dispnew.c (add_window_display_history): Use BVAR.
3153 * xdisp.c (debug_method_add): Use BVAR.
3154 (check_window_end, dump_glyph_matrix, dump_glyph)
3155 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3157 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3160 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3161 check till after the cache is created in init_frame_faces.
3163 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3165 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3167 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3169 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3170 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3171 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3173 Improve buffer-overflow checking (Bug#8873).
3174 * fileio.c (Finsert_file_contents):
3175 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3176 Remove the old (too-loose) buffer overflow checks.
3177 They weren't needed, since make_gap checks for buffer overflow.
3178 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3179 The old code merely checked for Emacs fixnum overflow, and relied
3180 on undefined (wraparound) behavior. The new code avoids undefined
3181 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3183 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3184 Tune. Don't use wider integers than needed. Don't use alloca.
3185 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3187 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3189 * insdel.c, lisp.h (buffer_overflow): New function.
3190 (insert_from_buffer_1, replace_range, replace_range_2):
3191 * insdel.c (make_gap_larger):
3192 * editfns.c (Finsert_char):
3193 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3195 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3197 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3199 Integer overflow and signedness fixes (Bug#8873).
3201 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3202 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3204 * fileio.c: Don't assume EMACS_INT fits in off_t.
3205 (emacs_lseek): New static function.
3206 (Finsert_file_contents, Fwrite_region): Use it.
3207 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3209 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3211 * fns.c: Don't overflow int when computing a list length.
3212 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3213 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3214 truncation on 64-bit hosts. Check for QUIT every
3215 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3216 faster and is responsive enough.
3217 (Flength): Report an error instead of overflowing an integer.
3218 (Fsafe_length): Return a float if the value is not representable
3219 as a fixnum. This shouldn't happen except in contrived situations.
3220 (Fnthcdr, Fsort): Don't assume list length fits in int.
3221 (Fcopy_sequence): Don't assume vector length fits in int.
3223 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3224 (header_size, word_size): New constants.
3225 (allocate_vectorlike): Don't check size overflow here.
3226 (allocate_vector): Check it here instead, since this is the only
3227 caller of allocate_vectorlike that could cause overflow.
3228 Check that the new vector's length is representable as a fixnum.
3230 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3231 The previous code was bogus. For example, next_almost_prime (32)
3232 returned 39, which is undesirable as it is a multiple of 3; and
3233 next_almost_prime (24) returned 25, which is a multiple of 5 so
3234 why was the code bothering to check for multiples of 7?
3236 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3238 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3240 Variadic C functions now count arguments with ptrdiff_t.
3241 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3242 Back then I didn't know that the Emacs coding style prefers signed int.
3243 Also, in the meantime I found a few more instances where arguments
3244 were being counted with int, which may truncate counts on 64-bit
3245 machines, or EMACS_INT, which may be unnecessarily wide.
3246 * lisp.h (struct Lisp_Subr.function.aMANY)
3247 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3248 Arg counts are now ptrdiff_t, not size_t.
3249 All variadic functions and their callers changed accordingly.
3250 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3251 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3252 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3253 * callint.c (Fcall_interactively): Check arg count for overflow,
3254 to avoid potential buffer overrun. Use signed char, not 'int',
3255 for 'varies' array, so that we needn't bother to check its size
3256 calculation for overflow.
3257 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3258 * eval.c (apply_lambda):
3259 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3260 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3261 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3263 * callint.c (Fcall_interactively): Don't use index var as event count.
3265 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3266 * mem-limits.h (SIZE): Remove; no longer used.
3268 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3270 Remove unnecessary casts.
3271 * xterm.c (x_term_init):
3272 * xfns.c (x_set_border_pixel):
3273 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3274 These aren't needed now that we assume ANSI C.
3276 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3277 It's more likely to cause problems (due to unsigned overflow)
3280 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3282 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3284 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3286 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3288 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3290 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3292 GLYPH_CODE_FACE returns EMACS_INT, not int.
3293 * dispextern.h (merge_faces):
3294 * xfaces.c (merge_faces):
3295 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3296 Don't assume EMACS_INT fits in int.
3298 * character.h (CHAR_VALID_P): Remove unused parameter.
3299 * fontset.c, lisp.h, xdisp.c: All uses changed.
3301 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3303 * fns.c (concat): Minor tuning based on overflow analysis.
3304 This doesn't fix any bugs. Use int to hold character, instead
3305 of constantly refetching from Emacs object. Use XFASTINT, not
3306 XINT, for value known to be a character. Don't bother comparing
3307 a single byte to 0400, as it's always less.
3309 * floatfns.c (Fexpt):
3310 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3312 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3315 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3317 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3318 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3319 incorrectly succeed when S was a string, because 4294967386 was
3320 truncated before it was used.
3322 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3323 Otherwise, an out-of-range integer could cause undefined behavior
3326 * composite.c: Use int, not EMACS_INT, for characters.
3327 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3328 EMACS_INT, for values that are known to be in character range.
3329 This doesn't fix any bugs but is the usual style inside Emacs and
3330 may generate better code on 32-bit machines.
3332 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3333 This is for reasons similar to the recent CHAR_STRING fix.
3334 * charset.c (Fencode_char): Check that character arg is actually
3335 a character. Pass an int to ENCODE_CHAR.
3336 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3337 wider than 'int', as a compile-time check to prevent future regressions
3340 * character.c (char_string): Remove unnecessary casts.
3342 Make sure a 64-bit char is never passed to CHAR_STRING.
3343 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3344 by silently ignoring the top 32 bits, allowing some values
3345 that were far too large to be valid characters.
3346 * character.h: Include <verify.h>.
3347 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3348 arguments are no wider than unsigned, as a compile-time check
3349 to prevent future regressions in this area.
3351 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3352 (Fsubst_char_in_region):
3354 * xdisp.c (decode_mode_spec_coding):
3355 Adjust to CHAR_STRING's new requirement.
3356 * editfns.c (Finsert_char, Fsubst_char_in_region):
3357 * fns.c (concat): Check that character args are actually
3358 characters. Without this test, these functions did the wrong
3359 thing with wildly out-of-range values on 64-bit hosts.
3361 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3362 These casts should not be needed on 32-bit hosts, either.
3363 * keyboard.c (read_char):
3364 * lread.c (Fload): Remove casts to unsigned.
3366 * lisp.h (UNSIGNED_CMP): New macro.
3367 This fixes comparison bugs on 64-bit hosts.
3368 (ASCII_CHAR_P): Use it.
3369 * casefiddle.c (casify_object):
3370 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3371 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3372 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3373 * dispextern.h (FACE_FROM_ID):
3374 * keyboard.c (read_char): Use UNSIGNED_CMP.
3376 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3377 not to EMACS_INT, to avoid GCC warning.
3379 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3381 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3382 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3383 isn't needed on 32-bit machines.
3385 * buffer.c (Fgenerate_new_buffer_name):
3386 Use EMACS_INT for count, not int.
3387 (advance_to_char_boundary): Return EMACS_INT, not int.
3389 * data.c (Qcompiled_function): Now static.
3391 * window.c (window_body_lines): Now static.
3393 * image.c (gif_load): Rename local to avoid shadowing.
3395 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3396 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3397 * alloc.c (make_save_value): Integer argument is now of type
3399 (mark_object): Use ptrdiff_t, not int.
3400 * lisp.h (pD): New macro.
3401 * print.c (print_object): Use it.
3403 * alloc.c: Use EMACS_INT, not int, to count objects.
3404 (total_conses, total_markers, total_symbols, total_vector_size)
3405 (total_free_conses, total_free_markers, total_free_symbols)
3406 (total_free_floats, total_floats, total_free_intervals)
3407 (total_intervals, total_strings, total_free_strings):
3408 Now EMACS_INT, not int. All uses changed.
3409 (Fgarbage_collect): Compute overall total using a double, so that
3410 integer overflow is less likely to be a problem. Check for overflow
3411 when converting back to an integer.
3412 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3413 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3414 These were 'int' variables that could overflow on 64-bit hosts;
3415 they were never used, so remove them instead of repairing them.
3416 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3417 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3418 Previously, this ceilinged at INT_MAX, but that doesn't work on
3420 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3422 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3423 (allocate_vectorlike): Check for ptrdiff_t overflow.
3424 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3425 when a (possibly-narrower) signed value would do just as well.
3426 We prefer using signed arithmetic, to avoid comparison confusion.
3428 * alloc.c: Catch some string size overflows that we were missing.
3429 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3430 for convenience in STRING_BYTES_MAX.
3431 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3432 The definition here is exact; the one in lisp.h was approximate.
3433 (allocate_string_data): Check for string overflow. This catches
3434 some instances we weren't catching before. Also, it catches
3435 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3436 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3437 and ptrdiff_t and EMACS_INT are both 64 bits.
3439 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3440 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3441 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3443 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3445 * alloc.c (Fmake_string): Check for out-of-range init.
3447 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3449 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3451 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3453 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3454 xg_get_default_scrollbar_width.
3456 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3457 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3458 (style_changed_cb): Call update_theme_scrollbar_width and call
3459 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3460 all frames (Bug#8505).
3461 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3462 Call gtk_window_set_resizable if HAVE_GTK3.
3463 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3464 and height if HAVE_GTK3 (Bug#8505).
3465 (scroll_bar_width_for_theme): New variable.
3466 (update_theme_scrollbar_width): New function.
3467 (xg_get_default_scrollbar_width): Move code to
3468 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3469 (xg_initialize): Call update_theme_scrollbar_width.
3471 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3473 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3475 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3477 * frame.c (make_frame): Call other_buffer_safely instead of
3480 * window.c (temp_output_buffer_show): Call display_buffer with
3481 second argument Vtemp_buffer_show_specifiers and reset latter
3482 immediately after the call.
3483 (Vtemp_buffer_show_specifiers): New variable.
3484 (auto_window_vscroll_p, next_screen_context_lines)
3485 (Vscroll_preserve_screen_position): Remove leading asterisks from
3488 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3490 Fix minor problems found by GCC 4.6.0 static checking.
3491 * buffer.c (Qclone_number): Remove for now, as it's unused.
3492 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3493 (record_buffer): Remove unused local.
3494 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3495 (set_frame_buffer_list): Remove; unused.
3496 * frame.h (other_visible_frames): Remove decl.
3497 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3498 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3499 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3501 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3502 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3503 Define only if HAVE_GPM.
3504 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3505 (update_hints_inhibit): Remove; never set. All uses removed.
3506 * widgetprv.h (emacsFrameClassRec): Remove decl.
3507 * window.c (delete_deletable_window): Now returns void, since it
3508 wasn't returning anything.
3509 (compare_window_configurations): Remove unused locals.
3510 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3511 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3512 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3513 the same widths as pointers. This follows up on the 2011-05-06 patch.
3514 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3515 * xterm.h: Likewise.
3516 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3518 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3520 * makefile.w32-in: Update dependencies.
3521 (LISP_H): Add lib/intprops.h.
3523 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3525 * image.c (gif_load): Add animation frame delay to the metadata.
3526 (syms_of_image): Use DEFSYM. New symbol `delay'.
3528 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3530 * window.c (delete_deletable_window): Re-add.
3531 (Fset_window_configuration): Rewrite to handle dead buffers and
3532 consequently deletable windows.
3533 (window_tree, Fwindow_tree): Remove. Supply functionality in
3535 (compare_window_configurations): Simplify code.
3537 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3539 * image.c (imagemagick_load_image): Fix type mismatch.
3540 (Fimagemagick_types): Likewise.
3542 * window.h (replace_buffer_in_windows): Declare.
3544 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3546 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3547 Qclone_number. Remove external declaration of Qdelete_window.
3548 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3550 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3551 Run Qbuffer_list_update_hook if allowed.
3552 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3553 buffer list implementation.
3554 (other_buffer_safely): New function.
3555 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3556 calls to replace_buffer_in_windows and
3557 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3559 (record_buffer): Inhibit quitting and rewrite using quittable
3560 functions. Run Qbuffer_list_update_hook if allowed.
3561 (Frecord_buffer, Funrecord_buffer): New functions.
3562 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3563 Move switch-to-buffer to window.el.
3564 (bury-buffer): Move to window.el.
3565 (Vbuffer_list_update_hook): New variable.
3567 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3570 * window.h (resize_frame_windows): Move up in code.
3571 (Fwindow_frame): Remove EXFUN.
3572 (replace_buffer_in_all_windows): Remove prototype.
3573 (replace_buffer_in_windows_safely): Add prototype.
3575 * window.c: Declare Qdelete_window static again. Move down
3576 declaration of select_count.
3577 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3578 (Fother_window): Move to window.el.
3579 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3580 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3581 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3583 (replace_buffer_in_windows): Implement by calling
3584 Qreplace_buffer_in_windows.
3585 (replace_buffer_in_all_windows): Remove with some functionality
3586 moved into replace_buffer_in_windows_safely.
3587 (replace_buffer_in_windows_safely): New function.
3588 (select_window_norecord, select_frame_norecord): Move in front
3589 of run_window_configuration_change_hook. Remove now obsolete
3591 (Fset_window_buffer): Rewrite doc-string.
3592 Call Qrecord_window_buffer.
3593 (keys_of_window): Move binding for other-window to window.el.
3595 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3597 * dispextern.h (struct image): Replace data member, whose int_val
3598 and ptr_val fields were not used by anything, with a single
3601 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3602 (gif_clear_image, gif_load, imagemagick_load_image)
3603 (gs_clear_image, gs_load): Callers changed.
3605 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3607 * buffer.h: Include <time.h>, for time_t.
3608 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3610 Fix minor problems found by static checking.
3612 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3614 Make identifiers static if they are not used in other modules.
3615 * data.c (Qcompiled_function, Qframe, Qvector):
3616 * image.c (QimageMagick, Qsvg):
3617 * minibuf.c (Qmetadata):
3618 * window.c (resize_window_check, resize_root_window): Now static.
3619 * window.h (resize_window_check, resize_root_window): Remove decls.
3621 * window.c (window_deletion_count, delete_deletable_window):
3623 (window_body_lines): Now static.
3624 (Fdelete_other_windows_internal): Mark vars as initialized.
3625 Make sure 'resize_failed' is initialized.
3626 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3627 (resize_window_apply): Remove unused local.
3628 * window.h (delete_deletable_window): Remove decl.
3630 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3631 (imagemagick_load_image): Fix pointer signedness problem by changing
3632 last arg from unsigned char * to char *. All uses changed.
3633 Also, fix a local for similar reasons.
3634 Remove unused locals. Remove locals to avoid shadowing.
3635 (fn_rsvg_handle_free): Remove; unused.
3636 (svg_load, svg_load_image): Fix pointer signedness problem.
3637 (imagemagick_load_image): Don't use garbage pointer image_wand.
3639 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3641 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3643 * image.c (gif_load): Fix omitted cast error introduced by
3646 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3648 * window.h (resize_proportionally, orig_total_lines)
3649 (orig_top_line): Remove from window structure.
3650 (set_window_height, set_window_width, change_window_heights)
3651 (Fdelete_window): Remove prototypes.
3652 (resize_frame_windows): Remove duplicate declaration.
3654 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3656 * window.h (resize_frame_windows, resize_window_check)
3657 (delete_deletable_window, resize_root_window)
3658 (resize_frame_windows): Declare prototypes.
3660 * window.c (resize_window_apply): Make definition be "static" to
3661 match the prototype.
3663 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3665 * window.c: Remove declarations of Qwindow_size_fixed,
3666 window_min_size_1, window_min_size_2, window_min_size,
3667 size_window, window_fixed_size_p, enlarge_window, delete_window.
3668 Remove static from declaration of Qdelete_window, it's
3669 temporarily needed by Fbury_buffer.
3670 (replace_window): Don't assign orig_top_line and
3672 (Fdelete_window, delete_window): Remove. Window deletion is
3673 handled by window.el.
3674 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3675 Replace Fdelete_window calls with calls to Qdelete_window.
3676 (Fdelete_other_windows): Remove. Deleting other windows is
3677 handled by window.el.
3678 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3679 handled in window.el.
3680 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3681 Window minimum sizes are handled in window.el.
3682 (shrink_windows, size_window, set_window_height)
3683 (set_window_width, change_window_heights, window_height)
3684 (window_width, CURBEG, CURSIZE, enlarge_window)
3685 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3686 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3687 handled in window.el.
3688 (make_dummy_parent): Rename to make_parent_window and give it a
3689 second argument horflag.
3690 (make_window): Don't set resize_proportionally any more.
3691 (Fsplit_window): Remove. Windows are split in window.el.
3692 (save_restore_action, save_restore_orig_size)
3693 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3694 Resize mini windows in window.el.
3695 (grow_mini_window, shrink_mini_window): Implement by calling
3696 Qresize_root_window_vertically, resize_window_check and
3697 resize_window_apply.
3698 (saved_window, Fset_window_configuration, save_window_save):
3699 Do not handle orig_top_line, orig_total_lines, and
3700 resize_proportionally.
3701 (window_min_height, window_min_width): Move to window.el.
3702 (keys_of_window): Move bindings for delete-other-windows,
3703 split-window, delete-window and enlarge-window to window.el.
3705 * buffer.c: Temporarily extern Qdelete_window.
3706 (Fbury_buffer): Temporarily call Qdelete_window instead of
3707 Fdelete_window (Fbury_buffer will move to window.el soon).
3709 * frame.c (set_menu_bar_lines_1): Remove code handling
3710 orig_top_line and orig_total_lines.
3712 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3713 set_window_height but set heights directly.
3714 (change_frame_size_1): Use resize_frame_windows.
3716 * xdisp.c (init_xdisp): Don't use set_window_height but set
3719 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3720 Use resize_frame_windows instead of change_window_heights and run
3721 run_window_configuration_change_hook.
3723 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3724 instead of change_window_heights and run
3725 run_window_configuration_change_hook.
3727 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3729 * window.c (replace_window): Rename second argument REPLACEMENT to
3730 NEW. New third argument SETFLAG. Rewrite.
3731 (delete_window, make_dummy_parent): Call replace_window with
3733 (window_list_1): Move down in code.
3734 (run_window_configuration_change_hook): Move set_buffer part
3735 before select_frame_norecord part in order to unwind correctly.
3736 Rename count1 to count.
3737 (recombine_windows, delete_deletable_window, resize_root_window)
3738 (Fdelete_other_windows_internal)
3739 (Frun_window_configuration_change_hook, make_parent_window)
3740 (resize_window_check, resize_window_apply, Fresize_window_apply)
3741 (resize_frame_windows, Fsplit_window_internal)
3742 (Fdelete_window_internal, Fresize_mini_window_internal):
3744 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3746 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3748 * window.h (window): Add some new members to window structure -
3749 normal_lines, normal_cols, new_total, new_normal, clone_number,
3750 splits, nest, prev_buffers, next_buffers.
3751 (WINDOW_TOTAL_SIZE): Move here from window.c.
3752 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3754 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3756 (make_dummy_parent): Set new members of windows structure.
3757 (make_window): Move down in code. Handle new members of window
3759 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3760 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3761 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3762 (Fset_window_prev_buffers, Fwindow_next_buffers)
3763 (Fset_window_next_buffers, Fset_window_clone_number):
3765 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3766 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3768 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3769 Argument WINDOW can be now internal window too.
3770 (Fwindow_use_time): Move up in code.
3771 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3773 (Fset_window_configuration, saved_window)
3774 (Fcurrent_window_configuration, save_window_save): Handle new
3775 members of window structure.
3776 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3777 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3778 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3779 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3780 Qget_mru_window, Qresize_root_window,
3781 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3782 Qauto_buffer_name; staticpro them.
3784 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3786 * window.c (Fwindow_total_size, Fwindow_left_column)
3787 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3788 (Fwindow_list_1): New functions.
3789 (window_box_text_cols): Replace with window_body_cols.
3790 (Fwindow_width, Fscroll_left, Fscroll_right):
3791 Use window_body_cols instead of window_box_text_cols.
3792 (delete_window, Fset_window_configuration):
3793 Call delete_all_subwindows with window as argument.
3794 (delete_all_subwindows): Take a window as argument and not a
3796 (window_loop): Remove handling of GET_LRU_WINDOW and
3798 (Fget_lru_window, Fget_largest_window): Move to window.el.
3800 * window.h: Extern window_body_cols instead of
3801 window_box_text_cols. delete_all_subwindows now takes a
3802 Lisp_Object as argument.
3804 * indent.c (compute_motion, Fcompute_motion):
3805 Use window_body_cols instead of window_box_text_cols.
3807 * frame.c (delete_frame): Call delete_all_subwindows with root
3810 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3812 * fns.c (Fputhash): Document return value.
3814 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3816 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3818 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3820 Cons<->int and similar integer overflow fixes (Bug#8794).
3822 Check for overflow when converting integer to cons and back.
3823 * charset.c (Fdefine_charset_internal, Fdecode_char):
3824 Use cons_to_unsigned to catch overflow.
3825 (Fencode_char): Use INTEGER_TO_CONS.
3826 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3827 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3828 * data.c (long_to_cons, cons_to_long): Remove.
3829 (cons_to_unsigned, cons_to_signed): New functions.
3830 These signal an error for invalid or out-of-range values.
3831 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3832 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3833 * font.c (Ffont_variation_glyphs):
3834 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3835 * lisp.h: Include <intprops.h>.
3836 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3837 (cons_to_signed, cons_to_unsigned): New decls.
3838 (long_to_cons, cons_to_long): Remove decls.
3839 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3840 (Fprimitive_undo): Use CONS_TO_INTEGER.
3841 * xfns.c (Fx_window_property): Likewise.
3842 * xselect.c: Include <limits.h>.
3843 (x_own_selection, selection_data_to_lisp_data):
3844 Use INTEGER_TO_CONS.
3845 (x_handle_selection_request, x_handle_selection_clear)
3846 (x_get_foreign_selection, Fx_disown_selection_internal)
3847 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3848 (lisp_data_to_selection_data): Use cons_to_unsigned.
3849 (x_fill_property_data): Use cons_to_signed.
3850 Report values out of range.
3852 Check for buffer and string overflow more precisely.
3853 * buffer.h (BUF_BYTES_MAX): New macro.
3854 * lisp.h (STRING_BYTES_MAX): New macro.
3855 * alloc.c (Fmake_string):
3856 * character.c (string_escape_byte8):
3857 * coding.c (coding_alloc_by_realloc):
3858 * doprnt.c (doprnt):
3859 * editfns.c (Fformat):
3861 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3862 since they may not be the same number.
3863 * editfns.c (Finsert_char):
3864 * fileio.c (Finsert_file_contents):
3865 Likewise for BUF_BYTES_MAX.
3867 * image.c: Use ptrdiff_t, not int, for sizes.
3868 (slurp_file): Switch from int to ptrdiff_t.
3870 (slurp_file): Check that file size fits in both size_t (for
3871 malloc) and ptrdiff_t (for sanity and safety).
3873 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3874 if b->modtime has its maximal value.
3876 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3878 Don't assume time_t can fit into int.
3879 * buffer.h (struct buffer.modtime): Now time_t, not int.
3880 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3881 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3883 Minor fixes for signed vs unsigned integers.
3884 * character.h (MAYBE_UNIFY_CHAR):
3885 * charset.c (maybe_unify_char):
3886 * keyboard.c (read_char, reorder_modifiers):
3887 XINT -> XFASTINT, since the integer must be nonnegative.
3888 * ftfont.c (ftfont_spec_pattern):
3889 * keymap.c (access_keymap, silly_event_symbol_error):
3890 XUINT -> XFASTINT, since the integer must be nonnegative.
3891 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3892 since it makes no difference and we prefer signed.
3893 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3894 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3897 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3899 * window.h (Fwindow_frame): Declare.
3901 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3903 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3904 (SPARE_MEMORY): Always define.
3905 (LARGE_REQUEST): Remove.
3906 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3908 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3910 * lisp.h: Move EXFUNS for Fframe_root_window,
3911 Fframe_first_window and Fset_frame_selected_window to window.h.
3913 * window.h: Move EXFUNS for Fframe_root_window,
3914 Fframe_first_window and Fset_frame_selected_window here from
3917 * frame.c (Fwindow_frame, Fframe_first_window)
3918 (Fframe_root_window, Fframe_selected_window)
3919 (Fset_frame_selected_window): Move to window.c.
3920 (Factive_minibuffer_window): Move to minibuf.c.
3921 (Fother_visible_frames_p): New function.
3923 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3925 * window.c (decode_window, decode_any_window): Move up in code.
3926 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3927 (inhibit_frame_unsplittable): Remove unused variable.
3928 (Fwindow_buffer): Move up and rewrite doc-string.
3929 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3930 (Fwindow_prev): New functions.
3931 (Fwindow_frame): Move here from frame.c. Accept any window as
3933 (Fframe_root_window, Fframe_first_window)
3934 (Fframe_selected_window): Move here from frame.c. Accept frame
3935 or arbitrary window as argument. Update doc-strings.
3936 (Fminibuffer_window): Move up in code.
3937 (Fwindow_minibuffer_p): Move up in code and simplify.
3938 (Fset_frame_selected_window): Move here from frame.c.
3940 (Fselected_window, select_window, Fselect_window): Move up in
3941 code. Minor doc-string fixes.
3943 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3945 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3946 Do not assume that spare memory exists; that assumption is valid
3947 only if SYSTEM_MALLOC.
3948 (LARGE_REQUEST): New macro, so that the issue of large requests
3949 is separated from the issue of spare memory.
3951 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3953 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3956 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3958 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3961 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3963 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3965 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3967 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3968 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3970 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3972 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3974 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3976 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3977 (x_clipboard_manager_save): Add return value.
3978 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3980 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3981 Obey Vx_select_enable_clipboard_manager. Catch errors in
3982 x_clipboard_manager_save (Bug#8779).
3983 (Vx_select_enable_clipboard_manager): New variable.
3984 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3986 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3988 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3990 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3992 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3993 in the current matrix if keep_current_p is non-zero.
3995 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3997 * bidi.c (bidi_level_of_next_char): Fix last change.
3999 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4001 Support bidi reordering of text covered by display properties.
4003 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4004 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4005 (bidi_cache_search, bidi_cache_iterator_state)
4006 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4007 (bidi_level_of_next_char, bidi_move_to_visually_next):
4008 Support character positions inside a run of characters covered by a
4010 (bidi_paragraph_init, bidi_resolve_explicit_1)
4011 (bidi_level_of_next_char): Call bidi_fetch_char and
4012 bidi_fetch_char_advance instead of FETCH_CHAR and
4014 (bidi_init_it): Initialize new members.
4015 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4017 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4018 instead of using explicit *_CHAR codes.
4019 (bidi_resolve_explicit, bidi_resolve_weak):
4020 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4021 bidirectional text is supported only in multibyte buffers.
4022 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4023 it to initialize the frame_window_p member of struct bidi_it.
4024 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4025 (bidi_resolve_explicit, bidi_resolve_weak)
4026 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4027 bidi_it->nchars is non-positive.
4028 (bidi_level_of_next_char): Don't try to lookup the cache for the
4029 next/previous character if nothing is cached there yet, or if we
4030 were just reseat()'ed to a new position.
4032 * xdisp.c (set_cursor_from_row): Set start and stop points
4033 according to the row's direction when priming the loop that looks
4034 for the glyph on which to display cursor.
4035 (single_display_spec_intangible_p): Function deleted.
4036 (display_prop_intangible_p): Reimplement to call
4037 handle_display_spec instead of single_display_spec_intangible_p.
4038 Accept 3 additional arguments needed by handle_display_spec.
4039 This fixes incorrect cursor motion across display property with complex
4040 values: lists, `(when COND...)' forms, etc.
4041 (single_display_spec_string_p): Support property values that are
4042 lists with the argument STRING its top-level element.
4043 (display_prop_string_p): Fix the condition for processing a
4044 property that is a list to be consistent with handle_display_spec.
4045 (handle_display_spec): New function, refactored from the
4046 last portion of handle_display_prop.
4047 (compute_display_string_pos): Accept additional argument
4048 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4049 value of a `display' property is a "replacing spec".
4050 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4051 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4052 the display property, but just return a value indicating whether
4053 the display property will replace the characters it covers.
4054 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4055 frame_window_p members of struct bidi_it.
4056 (compute_display_string_pos, compute_display_string_end):
4058 (push_it): Accept second argument POSITION, where pop_it should
4059 jump to continue iteration.
4060 (reseat_1): Initialize bidi_it.disp_pos.
4062 * keyboard.c (adjust_point_for_property): Adjust the call to
4063 display_prop_intangible_p to its new signature.
4065 * dispextern.h (struct bidi_it): New member frame_window_p.
4066 (bidi_init_it): Update prototypes.
4067 (display_prop_intangible_p): Update prototype.
4068 (compute_display_string_pos, compute_display_string_end):
4070 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4073 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4075 Malloc failure behavior now depends on size of allocation.
4076 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4077 * lisp.h: Change signatures accordingly.
4078 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4079 All callers changed. (Bug#8762)
4081 * gnutls.c: Use Emacs's memory allocators.
4082 Without this change, the gnutls library would invoke malloc etc.
4083 directly, which causes problems on non-SYNC_INPUT hosts, and which
4084 runs afoul of improving memory_full behavior. (Bug#8761)
4085 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4086 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4087 xfree instead of the default malloc, realloc, free.
4088 (Fgnutls_boot): No need to check for memory allocation failure,
4089 since xmalloc does that for us.
4091 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4092 * category.c (hash_get_category_set):
4093 * ccl.c (ccl_driver):
4094 * charset.c (Fdefine_charset_internal):
4095 * charset.h (struct charset.hash_index):
4096 * composite.c (get_composition_id, gstring_lookup_cache)
4097 (composition_gstring_put_cache):
4098 * composite.h (struct composition.hash_index):
4099 * dispextern.h (struct image.hash):
4100 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4101 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4102 (hashfn_equal, hashfn_user_defined, make_hash_table)
4103 (maybe_resize_hash_table, hash_lookup, hash_put)
4104 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4105 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4106 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4107 * image.c (make_image, search_image_cache, lookup_image)
4108 (xpm_put_color_table_h):
4109 * lisp.h (struct Lisp_Hash_Table):
4110 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4111 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4112 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4113 * alloc.c (allocate_vectorlike):
4114 Check for overflow in vector size calculations.
4115 * ccl.c (ccl_driver):
4116 Check for overflow when converting EMACS_INT to int.
4117 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4118 need to be updated by these changes.
4119 * fns.c (make_hash_table, maybe_resize_hash_table):
4120 Check for integer overflow with large hash tables.
4121 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4122 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4123 (SXHASH_REDUCE): New macro.
4124 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4125 Use it instead of discarding useful hash info with large hash values.
4126 (sxhash_float): New function.
4127 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4128 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4129 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4130 Rewrite to use FIXNUM_BITS, as this simplifies things.
4131 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4132 Adjust signatures to match updated version of code.
4133 (consing_since_gc): Now EMACS_INT, since a single hash table can
4134 use more than INT_MAX bytes.
4136 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4138 Make it possible to build with GCC-4.6+ -O2 -flto.
4140 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4142 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4144 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4145 Call minibuffer-inactive-mode.
4147 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4149 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4150 Update dependencies.
4152 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4154 * data.c (init_data): Remove code for UTS, this system is not
4157 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4159 Don't force ./temacs to start in terminal mode.
4161 * frame.c (make_initial_frame): Initialize faces in all cases, not
4162 only when CANNOT_DUMP is defined.
4163 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4165 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4167 * dispnew.c (add_window_display_history): Use const for the string
4168 pointer. Remove declaration, not needed.
4170 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4172 Use 'inline', not 'INLINE'.
4173 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4174 * alloc.c, fontset.c (INLINE): Remove.
4175 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4176 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4177 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4178 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4179 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4181 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4183 Make it possible to run ./temacs.
4185 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4186 syms_of_callproc does the same thing. Remove test for
4187 "initialized", do it in the caller.
4188 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4190 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4192 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4193 (read_minibuf): Use get_minibuffer.
4194 (syms_of_minibuf): Use DEFSYM.
4195 (Qmetadata): New var.
4196 * data.c (Qbuffer): Don't make it static.
4197 (syms_of_data): Use DEFSYM.
4199 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4201 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4202 (CCL_CODE_MIN): New macro.
4204 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4206 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4208 * eval.c (Qdebug): Now static.
4209 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4210 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4211 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4213 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4215 * image.c: Various fixes to ImageMagick code comments.
4216 (Fimagemagick_types): Doc fix.
4218 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4220 Minor fixes prompted by GCC 4.6.0 warnings.
4222 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4224 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4225 (x_clipboard_manager_save_all): Move extern decl to ...
4226 * xterm.h: ... here, so that it can be checked for consistency.
4228 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4230 * xselect.c (x_clipboard_manager_save_frame)
4231 (x_clipboard_manager_save_all): New functions.
4232 (Fx_clipboard_manager_save): Lisp function deleted.
4234 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4235 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4237 * xterm.h: Update prototype.
4239 2011-05-28 William Xu <william.xwl@gmail.com>
4241 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4244 2011-05-28 Jim Meyering <meyering@redhat.com>
4246 Avoid a sign-extension bug in crypto_hash_function.
4247 * fns.c (to_uchar): Define.
4248 (crypto_hash_function): Use it to convert some newly-signed
4249 variables to unsigned, to avoid sign-extension bugs. For example,
4250 without this change, (md5 "truc") would evaluate to
4251 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4252 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4253 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4255 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4257 Integer overflow fixes.
4259 * dbusbind.c: Serial number integer overflow fixes.
4260 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4261 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4262 to hold a serial number that is too large for a fixnum.
4263 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4264 Check for serial numbers out of range. Decode any serial number
4265 that was so large that it became a float. (Bug#8722)
4267 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4268 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4269 Use XFASTINT rather than XUINT when numbers are nonnegative.
4270 (xd_append_arg, Fdbus_method_return_internal):
4271 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4272 arguments, check that Lisp number is nonnegative, rather than
4273 silently wrapping negative numbers around. (Bug#8722)
4274 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4277 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4279 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4281 ccl: add integer overflow checks
4282 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4283 (IN_INT_RANGE): New macros.
4284 (ccl_driver): Use them to check for integer overflow when
4285 decoding a CCL program. Many of the new checks are whether XINT (x)
4286 fits in int; it doesn't always, on 64-bit hosts. The new version
4287 doesn't catch all possible integer overflows, but it's an
4288 improvement. (Bug#8719)
4290 * alloc.c (make_event_array): Use XINT, not XUINT.
4291 There's no need for unsigned here.
4293 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4294 This follows up to the 2011-05-06 change that substituted uintptr_t
4295 for EMACS_INT. This case wasn't caught back then.
4297 Rework Fformat to avoid integer overflow issues.
4298 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4299 now (part of C89). Include <verify.h>.
4300 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4301 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4302 (Fformat): Avoid the prepass trying to compute sizes; it was only
4303 approximate and thus did not catch overflow reliably. Instead, walk
4304 through the format just once, formatting and computing sizes as we go,
4305 checking for integer overflow at every step, and allocating a larger
4306 buffer as needed. Keep track separately whether the format is
4307 multibyte. Keep only the most-recently calculated precision, rather
4308 than them all. Record whether each argument has been converted to
4309 string. Use EMACS_INT, not int, for byte and char and arg counts.
4310 Support field widths and precisions larger than INT_MAX. Avoid
4311 sprintf's undefined behavior with conversion specifications such as %#d
4312 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4313 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4314 formatting out-of-range floating point numbers with int
4317 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4319 * data.c: Avoid integer truncation in expressions involving floats.
4320 * data.c: Include <intprops.h>.
4321 (arith_driver): When there's an integer overflow in an expression
4322 involving floating point, convert the integers to floating point
4323 so that the resulting value does not suffer from catastrophic
4324 integer truncation. For example, on a 64-bit host (* 4
4325 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4326 Do not rely on undefined behavior after integer overflow.
4328 merge count_size_as_multibyte, parse_str_to_multibyte
4329 * character.c, character.h (count_size_as_multibyte):
4330 Rename from parse_str_to_multibyte; all uses changed.
4331 Check for integer overflow.
4332 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4333 since it's now a duplicate of the other. This is more of
4334 a character than a buffer op, so better that it's in character.c.
4335 * fns.c, print.c: Adjust to above changes.
4337 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4339 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4341 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4343 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4344 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4345 (x_clipboard_manager_save): Now static.
4346 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4348 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4349 (crypto_hash_function): Now static.
4350 Fix pointer signedness problems. Avoid unnecessary initializations.
4352 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4354 * termhooks.h (Vselection_alist): Make it terminal-local.
4356 * terminal.c (create_terminal): Initialize it.
4358 * xselect.c: Support for clipboard managers.
4359 (Vselection_alist): Move to termhooks.h as terminal-local var.
4360 (LOCAL_SELECTION): New macro.
4361 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4362 (symbol_to_x_atom): Remove gratuitous arg.
4363 (x_handle_selection_request, lisp_data_to_selection_data)
4364 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4365 (x_own_selection, x_get_local_selection, x_convert_selection):
4366 New arg, specifying work frame. Use terminal-local Vselection_alist.
4367 (some_frame_on_display): Delete unused function.
4368 (Fx_own_selection_internal, Fx_get_selection_internal)
4369 (Fx_disown_selection_internal, Fx_selection_owner_p)
4370 (Fx_selection_exists_p): New optional frame arg.
4371 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4372 (x_handle_selection_clear): Don't treat other terminals with the
4373 same keyboard specially. Use the terminal-local Vselection_alist.
4374 (x_clear_frame_selections): Use Frun_hook_with_args.
4376 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4378 * xterm.h: Add support for those atoms.
4380 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4382 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4383 (converted_selections, conversion_fail_tag): New global variables.
4384 (x_selection_request_lisp_error): Free the above.
4385 (x_get_local_selection): Remove unnecessary code.
4386 (x_reply_selection_request): Args changed; handle arbitrary array
4387 of converted selections stored in converted_selections.
4388 Separate the XChangeProperty and SelectionNotify steps.
4389 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4390 (x_convert_selection): New function.
4391 (x_handle_selection_event): Simplify.
4392 (x_get_foreign_selection): Don't ignore incoming requests while
4393 waiting for an answer; this will fail when we implement
4394 SAVE_TARGETS, and seems unnecessary anyway.
4395 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4396 (Vx_sent_selection_functions): Doc fix.
4398 2011-05-26 Leo Liu <sdl.web@gmail.com>
4400 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4402 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4404 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4406 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4407 for fringe update if it has periodic bitmap.
4408 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4409 and fringe_bitmap_periodic_p.
4411 * fringe.c (get_fringe_bitmap_data): New function.
4412 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4413 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4414 row. Mark glyph row for fringe update if periodicity changed.
4416 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4417 for fringe update unless it has periodic bitmap.
4419 2011-05-25 Kenichi Handa <handa@m17n.org>
4421 * xdisp.c (get_next_display_element): Set correct it->face_id for
4422 a static composition.
4424 2011-05-24 Leo Liu <sdl.web@gmail.com>
4427 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4429 * fns.c (crypto_hash_function, Fsha1): New function.
4430 (Fmd5): Use crypto_hash_function.
4431 (syms_of_fns): Add Ssha1.
4433 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4435 * gnutls.c: Remove unused macros.
4436 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4437 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4438 Remove macros that are defined and never used.
4439 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4441 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4443 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4444 (Fx_get_selection_internal): Minor cleanup.
4445 (Fx_own_selection_internal): Rename arguments for consistency with
4448 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4450 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4452 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4454 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4456 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4458 * dispnew.c (scrolling_window): Don't exclude the case that the
4459 last enabled row in the desired matrix touches the bottom boundary.
4461 2011-05-21 Glenn Morris <rgm@gnu.org>
4463 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4464 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4465 and add some more files.
4467 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4469 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4470 report_file_error introduced by the change from 2011-05-07.
4472 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4474 * systime.h (Time): Define only if emacs is defined.
4475 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4476 where the include path doesn't have X11/X.h by default. See
4477 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4479 2011-05-20 Kenichi Handa <handa@m17n.org>
4481 * composite.c (find_automatic_composition): Fix previous change.
4483 2011-05-20 Glenn Morris <rgm@gnu.org>
4485 * lisp.mk: New file, split from Makefile.in.
4486 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4487 (shortlisp): Remove.
4488 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4490 2011-05-19 Glenn Morris <rgm@gnu.org>
4492 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4493 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4494 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4495 (lisp): Set the order to that of loadup.el.
4496 (shortlisp): Make it a copy of $lisp.
4497 (SOME_MACHINE_LISP): Remove.
4498 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4499 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4501 2011-05-18 Kenichi Handa <handa@m17n.org>
4503 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4504 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4505 (find_automatic_composition): Mostly rewrite for efficiency.
4507 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4509 * makefile.w32-in: Update dependencies.
4511 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4513 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4514 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4516 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4518 Fix some integer overflow issues, such as string length overflow.
4520 * insdel.c (count_size_as_multibyte): Check for string overflow.
4522 * character.c (lisp_string_width): Check for string overflow.
4523 Use EMACS_INT, not int, for string indexes and lengths; in
4524 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4525 the resulting string length overflows an EMACS_INT; instead,
4526 report a string overflow if no precision given. When checking for
4527 precision exhaustion, use a check that cannot possibly have
4528 integer overflow. (Bug#8675)
4529 * character.h (lisp_string_width): Adjust to new signature.
4531 * alloc.c (string_overflow): New function.
4532 (Fmake_string): Use it. This doesn't change behavior, but saves
4533 a few bytes and will simplify future changes.
4534 * character.c (string_escape_byte8): Likewise.
4535 * lisp.h (string_overflow): New decl.
4537 Fixups, following up to the user-interface timestamp change.
4538 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4539 for UI timestamps, instead of unsigned long.
4540 * msdos.c (mouse_get_pos): Likewise.
4541 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4542 * w32gui.h (Time): Define by including "systime.h" rather than by
4543 declaring it ourselves. (Bug#8664)
4545 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4546 * image.c (clear_image_cache): Likewise.
4548 * term.c (term_mouse_position): Don't assume time_t wraparound.
4550 Be more systematic about user-interface timestamps.
4551 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4552 and sometimes 'EMACS_UINT', to represent these timestamps.
4553 This change causes it to use 'Time' uniformly, as that's what X uses.
4554 This makes the code easier to follow, and makes it easier to catch
4555 integer overflow bugs such as Bug#8664.
4556 * frame.c (Fmouse_position, Fmouse_pixel_position):
4557 Use Time, not unsigned long, for user-interface timestamps.
4558 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4559 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4560 * keyboard.h (last_event_timestamp): Likewise.
4561 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4562 * menu.h (xmenu_show): Likewise.
4563 * term.c (term_mouse_position): Likewise.
4564 * termhooks.h (struct input_event.timestamp): Likewise.
4565 (struct terminal.mouse_position_hook): Likewise.
4566 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4567 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4568 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4569 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4571 * menu.h, termhooks.h: Include "systime.h", for Time.
4573 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4574 Don't assume that the difference between two unsigned long values
4575 can fit into an integer. At this point, we know button_down_time
4576 <= event->timestamp, so the difference must be nonnegative, so
4577 there's no need to cast the result if double-click-time is
4578 nonnegative, as it should be; check that it's nonnegative, just in
4579 case. This bug is triggered when events are more than 2**31 ms
4580 apart (about 25 days). (Bug#8664)
4582 * xselect.c (last_event_timestamp): Remove duplicate decl.
4583 (x_own_selection): Remove needless cast to unsigned long.
4585 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4586 that always fit in int. Use a sentinel instead of a counter, to
4587 avoid a temp and to allay GCC's concerns about possible int overflow.
4588 * frame.h (struct frame): Use int for menu_bar_items_used
4589 instead of EMACS_INT, since it always fits in int.
4591 * menu.c (grow_menu_items): Check for int overflow.
4593 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4595 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4596 Before, the code was not consistent. These values cannot exceed
4597 2**31 - 1 so there's no need to make them unsigned.
4598 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4599 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4600 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4602 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4604 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4605 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4606 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4607 presumably because the widths might not match.
4609 * window.c (size_window): Avoid needless test at loop start.
4611 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4613 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4615 2011-05-12 Drew Adams <drew.adams@oracle.com>
4617 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4619 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4621 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4622 `width' to `bar_area_x' and `bar_area_width', respectively.
4623 (x_scroll_run): Take account of fringe background extension.
4625 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4626 Rename local vars `left' and `width' to `bar_area_x' and
4627 `bar_area_width', respectively.
4628 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4629 background extension.
4631 2011-05-10 Jim Meyering <meyering@redhat.com>
4633 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4635 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4637 * image.c (Finit_image_library): Return t for built-in image types,
4638 like pbm and xbm. (Bug#8640)
4640 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4642 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4644 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4646 * w32console.c (Fset_screen_color): Doc fix.
4647 (Fget_screen_color): New function.
4648 (syms_of_ntterm): Defsubr it.
4650 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4651 unlink the temporary file if Fcall_process didn't create it in the
4653 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4654 child process will be redirected to a file specified with `:file'.
4655 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4656 cue to call_process_cleanup not to close that handle.
4658 2011-05-07 Ben Key <bkey76@gmail.com>
4660 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4661 one of two shell specific rules, either bootstrap-temacs-CMD or
4662 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4663 to the previous implementation of the bootstrap-temacs rule.
4664 The bootstrap-temacs-CMD rule is similar to the previous
4665 implementation of the bootstrap-temacs rule except that it
4666 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4669 These changes, along with some changes to nt/configure.bat,
4670 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4671 earlier fix to add support for --cflags and --ldflags options
4672 that include quotes so that it works whether make uses cmd or
4675 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4677 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4678 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4680 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4681 a string. Handle both cases.
4682 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4683 (Fdbus_register_method): Use Qinvalid_function.
4685 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4687 * makefile.w32-in: Update dependencies.
4688 (LISP_H): Add inttypes.h and stdin.h.
4689 (PROCESS_H): Add unistd.h.
4691 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4693 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4694 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4696 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4698 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4700 * term.c (vfatal): Remove stray call to va_end.
4701 It's not needed and the C Standard doesn't allow it here anyway.
4703 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4704 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4706 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4709 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4711 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4713 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4715 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4717 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4719 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4720 * charset.c (Fdefine_charset_internal): Don't initialize
4721 charset.code_space[15]. The value was garbage, on hosts with
4722 32-bit int (Bug#8600).
4724 * lread.c (read_integer): Be more consistent with string-to-number.
4725 Use string_to_number to do the actual conversion; this avoids
4726 rounding errors and fixes some other screwups. Without this fix,
4727 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4728 (digit_to_number): Move earlier, for benefit of read_integer.
4729 Return -1 if the digit is out of range for the base, -2 if it is
4730 not a digit in any supported base. (Bug#8602)
4732 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4734 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4735 to match comment at start of function. This also removes a
4736 GCC warning about overflow in a 32+64-bit port.
4738 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4740 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4741 Reported by Stefan Monnier in
4742 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4743 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4744 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4746 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4747 (EMACS_UINTPTR): Likewise, with uintptr_t.
4749 * lisp.h: Prefer 64-bit EMACS_INT if available.
4750 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4751 on 32-bit hosts that have 64-bit int, so that they can access
4753 However, temporarily disable this change unless the temporary
4754 symbol WIDE_EMACS_INT is defined.
4756 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4758 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4759 This removes an assumption that EMACS_INT and long are the same
4760 width as pointers. The assumption is true for Emacs porting targets
4761 now, but we want to make other targets possible.
4762 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4763 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4764 In the rest of the code, change types of integers that hold casted
4765 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4766 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4767 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4768 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4769 No need to cast type when ORing.
4770 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4771 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4772 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4773 assume EMACS_INT is the same width as char *.
4774 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4775 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4776 Remove no-longer-needed casts.
4777 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4778 (xg_tool_bar_help_callback, xg_make_tool_item):
4779 Use EMACS_INTPTR to hold an integer
4780 that will be cast to void *; this can avoid a GCC warning
4781 if EMACS_INT is not the same width as void *.
4782 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4783 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4784 (current_message_1, set_message_1):
4785 Use a local to convert to proper width without a cast.
4786 * xmenu.c (dialog_selection_callback): Likewise.
4788 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4789 Also, don't assume VALBITS / RAND_BITS is less than 5,
4790 and don't rely on undefined behavior when shifting a 1 left into
4792 * lisp.h (get_random): Change signature to match.
4794 * lread.c (hash_string): Use size_t, not int, for hash computation.
4795 Normally we prefer signed values; but hashing is special, because
4796 it's better to use unsigned division on hash table sizes so that
4797 the remainder is nonnegative. Also, size_t is the natural width
4798 for hashing into memory. The previous code used 'int', which doesn't
4799 retain enough info to hash well into very large tables.
4800 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4802 * dbusbind.c: Don't possibly lose pointer info when converting.
4803 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4804 Use XPNTR rather than XHASH, so that the high-order bits of
4805 the pointer aren't lost when converting through void *.
4807 * eval.c (Fautoload): Don't double-shift a pointer.
4809 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4811 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4813 * gnutls.c (DEF_GNUTLS_FN):
4814 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4816 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4818 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4821 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4823 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4824 New version that can reserve upto 2GB of heap space.
4826 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4828 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4830 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4832 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4833 `gnutls_certificate_set_x509_key_file'.
4835 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4837 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4838 Update dependencies.
4840 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4842 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4843 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4844 Remove unused parameter `fildes'.
4845 * process.c (read_process_output, send_process): Don't pass it.
4847 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4849 Fix previous change: the library cache is defined in w32.c.
4850 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4851 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4853 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4855 Implement dynamic loading of GnuTLS on Windows.
4857 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4858 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4859 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4862 * gnutls.c (Qgnutls_dll): Define.
4863 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4864 (gnutls_*): Declare function pointers.
4865 (init_gnutls_functions): New function to initialize function pointers.
4866 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4867 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4868 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4869 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4870 (emacs_gnutls_write, emacs_gnutls_read)
4871 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4872 (Fgnutls_available_p): New function.
4873 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4874 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4875 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4877 * image.c: Include w32.h.
4878 (Vimage_type_cache): Delete.
4879 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4880 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4881 (w32_delayed_load): Move to w32.c.
4883 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4885 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4886 (w32_delayed_load): Move from image.c. When loading a library, record
4887 its filename in the :loaded-from property of the library id.
4888 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4889 Initialize and staticpro them.
4890 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4892 * process.c: Include lisp.h before w32.h, not after.
4893 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4894 instead of gnutls_record_check_pending.
4896 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4898 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4900 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4901 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4904 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4906 * xterm.c (x_set_frame_alpha): Do not set property on anything
4907 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4909 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4911 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4913 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4915 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4916 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4917 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4918 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4919 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4920 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4921 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4922 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4923 (Qgnutls_bootprop_callbacks_verify): Make static.
4925 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4927 * callproc.c: Indentation fixup.
4929 * sysdep.c (wait_for_termination_1): Make static.
4930 (wait_for_termination, interruptible_wait_for_termination):
4931 Move after wait_for_termination_1.
4933 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4935 * sysdep.c (interruptible_wait_for_termination): New function
4936 which is like wait_for_termination, but allows keyboard
4939 * callproc.c (Fcall_process): Add (:file "file") as an option for
4941 (Fcall_process_region): Ditto.
4943 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4945 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4946 rather than `XVECTOR (FOO)->size'.
4948 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4949 inttypes.h, as a gnulib replacement is used if it not available in
4952 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4954 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4955 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4956 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4958 * coding.c (coding_alloc_by_realloc): Error out if destination
4959 will grow beyond MOST_POSITIVE_FIXNUM.
4960 (decode_coding_emacs_mule): Abort if there isn't enough place in
4961 charbuf for the composition carryover bytes. Reserve an extra
4962 space for up to 2 characters produced in a loop.
4963 (decode_coding_iso_2022): Abort if there isn't enough place in
4964 charbuf for the composition carryover bytes.
4966 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4968 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4969 aborting when %lld or %lll format is passed.
4970 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4971 %llo or %llx format is passed. (Bug#8545)
4973 * window.c (window_scroll_line_based): Use a marker instead of
4974 simple variables to record original value of point. (Bug#7952)
4976 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4977 produced by %s or %c overflows available buffer space. (Bug#8545)
4979 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4981 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4982 (SIZE_MAX): Move defn after all includes, as they might #define it.
4984 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4986 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4988 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4990 * keyboard.c (Qdelayed_warnings_hook): Define.
4991 (command_loop_1): Run `delayed-warnings-hook'
4992 if Vdelayed_warnings_list is non-nil.
4993 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4994 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4996 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4998 * doprnt.c (doprnt): Don't return value smaller than the buffer
4999 size if the message was truncated. (Bug#8545).
5001 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5003 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5004 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5006 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5008 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5010 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5012 * makefile.w32-in: Update dependencies.
5014 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5016 Improve `doprnt' and its usage. (Bug#8545)
5017 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5018 `format_end'. Remove support for %l as a conversion specifier.
5019 Don't use xrealloc. Improve diagnostics when the %l size modifier
5020 is used. Update the commentary.
5022 * eval.c (verror): Simplify calculation of size_t.
5024 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5027 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5029 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5032 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5034 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5035 This makes this file independent of the recent pseudovector change.
5037 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5039 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5041 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5042 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5043 Remove unused local.
5044 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5046 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5047 GCC 4.6.0 optimizes based on type-based alias analysis.
5048 For example, if b is of type struct buffer * and v of type struct
5049 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5050 != &v->size, and therefore "v->size = 1; b->size = 2; return
5051 v->size;" must therefore return 1. This assumption is incorrect
5052 for Emacs, since it type-puns struct Lisp_Vector * with many other
5053 types. To fix this problem, this patch adds a new type struct
5054 vectorlike_header that documents the constraints on layout of vectors
5055 and pseudovectors, and helps optimizing compilers not get fooled
5056 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5057 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5058 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5060 (XSETPVECTYPE): Rewrite in terms of new macro.
5061 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5062 This is a bit clearer, and further avoids the possibility of
5063 undesirable aliasing.
5064 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5065 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5066 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5067 since Lisp_Subr is a special case (no "next" field).
5068 (ASIZE): Now uses header.size rather than size.
5069 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5070 to avoid the hassle of writing XVECTOR (foo)->header.size.
5071 (struct vectorlike_header): New type.
5072 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5073 object, to help avoid aliasing.
5074 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5075 (SUBRP): Likewise, since Lisp_Subr is a special case.
5076 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5077 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5078 (struct Lisp_Hash_Table): Combine first two members into a single
5079 struct vectorlike_header member. All uses of "size" and "next" members
5080 changed to be "header.size" and "header.next".
5081 * buffer.h (struct buffer): Likewise.
5082 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5083 * frame.h (struct frame): Likewise.
5084 * process.h (struct Lisp_Process): Likewise.
5085 * termhooks.h (struct terminal): Likewise.
5086 * window.c (struct save_window_data, struct saved_window): Likewise.
5087 * window.h (struct window): Likewise.
5088 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5089 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5090 * buffer.c (init_buffer_once): Likewise.
5091 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5093 * process.c (Fformat_network_address): Use local var for size,
5096 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5098 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5099 * data.c (atof): Remove decl; no longer used or needed.
5100 (digit_to_number): Move to lread.c.
5101 (Fstring_to_number): Use new string_to_number function, to be
5102 consistent with how the Lisp reader treats infinities and NaNs.
5103 Do not assume that floating-point numbers represent EMACS_INT
5104 without losing information; this is not true on most 64-bit hosts.
5105 Avoid double-rounding errors, by insisting on integers when
5106 parsing non-base-10 numbers, as the documentation specifies.
5107 * lisp.h (string_to_number): New decl, replacing ...
5108 (isfloat_string): Remove.
5109 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5110 (read1): Do not accept +. and -. as integers; this
5111 appears to have been a coding error. Similarly, do not accept
5112 strings like +-1e0 as floating point numbers. Do not report
5113 overflow for integer overflows unless the base is not 10 which
5114 means we have no simple and reliable way to continue.
5115 Break out the floating-point parsing into a new
5116 function string_to_number, so that Fstring_to_number parses
5117 floating point numbers consistently with the Lisp reader.
5118 (digit_to_number): Move here from data.c. Make it static inline.
5119 (E_CHAR, EXP_INT): Remove, replacing with ...
5120 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5121 (string_to_number): New function, replacing isfloat_string.
5122 This function checks for valid syntax and produces the resulting
5123 Lisp float number too. Rework it so that string-to-number
5124 no longer mishandles examples like "1.0e+". Use strtoumax,
5125 so that overflow for non-base-10 numbers is reported only when
5126 there's no portable and simple way to convert to floating point.
5128 * textprop.c (set_text_properties_1): Rewrite for clarity,
5129 and to avoid GCC warning about integer overflow.
5131 * intervals.h (struct interval): Use EMACS_INT for members
5132 where EMACS_UINT might cause problems. See
5133 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5134 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5135 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5137 (offset_intervals): Tell GCC not to worry about length overflow
5138 when negating a negative length.
5140 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5141 (overrun_check_free): Likewise.
5143 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5144 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5147 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5148 (gnutls_make_error): Rename local to avoid shadowing.
5149 (gnutls_emacs_global_deinit): ifdef out; not used.
5150 (Fgnutls_boot): Use const for pointer to readonly storage.
5151 Comment out unused local. Fix pointer signedness problems.
5153 * lread.c (openp): Don't stuff size_t into an 'int'.
5154 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5155 about possible signed overflow.
5157 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5158 (GDK_KEY_g): Don't define if already defined.
5159 (xg_prepare_tooltip): Avoid pointer signedness problem.
5160 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5162 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5163 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5165 * xfns.c (Fx_window_property): Simplify a bit,
5166 to make a bit faster and to avoid GCC 4.6.0 warning.
5167 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5169 * fns.c (internal_equal): Don't assume size_t fits in int.
5171 * alloc.c (compact_small_strings): Tighten assertion a little.
5173 Replace pEd with more-general pI, and fix some printf arg casts.
5174 * lisp.h (pI): New macro, generalizing old pEd macro to other
5175 conversion specifiers. For example, use "...%"pI"d..." rather
5176 than "...%"pEd"...".
5177 (pEd): Remove. All uses replaced with similar uses of pI.
5178 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5179 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5180 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5181 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5182 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5183 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5184 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5186 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5187 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5188 * print.c (safe_debug_print, print_object): Likewise.
5189 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5191 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5192 avoiding the 0 flag, which is not portable.
5193 * process.c (Fmake_network_process): Use pI to avoid cast.
5194 * region-cache.c (pp_cache): Likewise.
5195 * xdisp.c (decode_mode_spec): Likewise.
5196 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5197 behavior on 64-bit hosts with printf arg.
5198 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5199 (x_stop_queuing_selection_requests): Likewise.
5200 (x_get_window_property): Don't truncate byte count to an 'int'
5203 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5204 here, since it parses constructs like leading '-' and spaces,
5205 which are not wanted; and it overflows with large numbers.
5206 Instead, simply match F[0-9]+, which is what is wanted anyway.
5208 * alloc.c: Remove unportable assumptions about struct layout.
5209 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5210 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5211 (allocate_vectorlike, make_pure_vector): Use the new macros,
5212 plus offsetof, to remove unportable assumptions about struct layout.
5213 These assumptions hold on all porting targets that I know of, but
5214 they are not guaranteed, they're easy to remove, and removing them
5215 makes further changes easier.
5217 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5218 This doesn't fix a bug but makes the code clearer.
5219 (string_overrun_cookie): Now const. Use initializers that
5220 don't formally overflow signed char, to avoid warnings.
5221 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5222 can cause Emacs to crash when string overrun checking is enabled.
5223 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5224 multiple of sizeof (EMACS_INT); it need not be, if
5225 alignof(EMACS_INT) < sizeof (EMACS_INT).
5226 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5228 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5230 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5232 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5234 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5235 supposed to be handshaking. (Bug#8556)
5236 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5238 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5240 * lisp.h (Qdebug): List symbol.
5241 * eval.c (Qdebug): Restore global linkage.
5242 * keyboard.c (debug-on-event): New variable.
5243 (handle_user_signal): Break into debugger when debug-on-event
5244 matches the current signal symbol.
5246 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5248 * alloc.c (check_sblock, check_string_bytes)
5249 (check_string_free_list): Convert to standard C.
5251 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5253 * w32.c (emacs_gnutls_push): Fix typo.
5255 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5257 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5258 "cast to pointer from integer of different size".
5260 Improve doprnt and its use in verror. (Bug#8545)
5261 * doprnt.c (doprnt): Document the set of format control sequences
5262 supported by the function. Use SAFE_ALLOCA instead of always
5265 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5266 is one byte too soon. Don't use xrealloc; instead xfree and
5269 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5271 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5274 * gnutls.c: Renamed global_initialized to
5275 gnutls_global_initialized. Added internals for the
5276 :verify-hostname-error, :verify-error, and :verify-flags
5277 parameters of `gnutls-boot' and documented those parameters in the
5278 docstring. Start callback support.
5279 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5280 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5281 on error. Return error code.
5282 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5283 (emacs_gnutls_read): Likewise.
5284 (Fgnutls_boot): Return handshake error code.
5285 (emacs_gnutls_handle_error): New function.
5286 (wsaerror_to_errno): Likewise.
5288 * w32.h (emacs_gnutls_pull): Add prototype.
5289 (emacs_gnutls_push): Likewise.
5291 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5292 (emacs_gnutls_push): Likewise.
5294 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5296 * process.c (wait_reading_process_output): Check if GnuTLS
5297 buffered some data internally if no FDs are set for TLS
5300 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5301 (LIBS): Link to USER_LIBS.
5302 ($(BLD)/gnutls.$(0)): New target.
5304 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5306 * xdisp.c (handle_single_display_spec): Rename the
5307 display_replaced_before_p argument into display_replaced_p, to
5308 make it consistent with the commentary. Fix typos in the
5311 * textprop.c (syms_of_textprop): Remove dead code.
5312 (copy_text_properties): Delete obsolete commentary about an
5313 interface that was deleted long ago. Fix typos in the description
5316 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5317 to changes in oldXMenu/XMenu.h from 2011-04-16.
5318 <menu_help_message, prev_menu_help_message>: Constify.
5319 (IT_menu_make_room): menu->help_text is now `const char **';
5322 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5323 to changes in oldXMenu/XMenu.h from 2011-04-16.
5324 (struct XMenu): Declare `help_text' `const char **'.
5326 * xfaces.c <Qunspecified>: Make extern again.
5328 * syntax.c: Include sys/types.h before including regex.h, as
5331 * doc.c (get_doc_string): Improve the format passed to `error'.
5333 * doprnt.c (doprnt): Improve commentary.
5335 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5337 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5340 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5341 changes in globals.h immediately force recompilation.
5342 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5343 $(CURDIR)/s/ms-w32.h.
5344 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5346 * character.c (Fchar_direction): Function deleted.
5347 (syms_of_character): Don't defsubr it.
5348 <char-direction-table>: Deleted.
5350 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5352 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5353 * doprnt.c: Include limits.h.
5354 (SIZE_MAX): New macro.
5355 (doprnt): Return a size_t value. 2nd arg is now size_t.
5356 Many local variables are now size_t instead of int or unsigned.
5357 Improve overflow protection. Support `l' modifier for integer
5358 conversions. Support %l conversion. Don't assume an EMACS_INT
5359 argument for integer conversions and for %c.
5361 * lisp.h (doprnt): Restore prototype.
5363 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5366 * Makefile.in (base_obj): Add back doprnt.o.
5368 * deps.mk (doprnt.o): Add back prerequisites.
5369 (callint.o): Depend on character.h.
5371 * eval.c (internal_lisp_condition_case): Include the handler
5372 representation in the error message.
5373 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5374 when breaking from the loop.
5376 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5378 * callint.c (Fcall_interactively): When displaying error message
5379 about invalid control letter, pass the character's codepoint, not
5380 a pointer to its multibyte form. Improve display of the character
5381 in octal and display also its hex code.
5383 * character.c (char_string): Use %x to display the (unsigned)
5384 codepoint of an invalid character, to avoid displaying a bogus
5387 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5388 `error', not SYMBOL_NAME itself.
5390 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5391 character arguments to `error'.
5393 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5394 to `error' in error message about FINAL_CHAR argument. Make sure
5395 FINAL_CHAR is a character, and use %c when it is passed as
5396 argument to `error'.
5398 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5400 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5402 * w32.c: Include <time.h>.
5403 (sys_localtime): New function.
5405 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5407 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5409 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5411 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5413 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5416 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5418 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5419 gl_state.e_property when gl_state.object is Qt.
5421 * insdel.c (make_gap_larger): Remove limitation of buffer size
5424 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5426 * xdisp.c (lookup_glyphless_char_display)
5427 (produce_glyphless_glyph): Handle cons cell entry in
5428 glyphless-char-display.
5429 (Vglyphless_char_display): Document it.
5431 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5432 glyphless-char-display.
5434 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5436 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5438 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5440 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5441 definition for no-X builds.
5443 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5445 Static checks with GCC 4.6.0 and non-default toolkits.
5447 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5449 * process.c (keyboard_bit_set): Define only if SIGIO.
5450 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5451 (send_process): Repair possible setjmp clobbering.
5453 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5455 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5457 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5459 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5460 Define only if needed.
5462 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5463 by pacifying GCC about it. Maybe it's time to retire it?
5464 * xfaces.c (USG, __TIMEVAL__): Likewise.
5466 * dispextern.h (struct redisplay_interface): Rename param
5468 * termhooks.h (struct terminal): Likewise.
5469 * xterm.c (xembed_send_message): Likewise.
5471 * insdel.c (make_gap_smaller): Define only if
5472 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5474 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5477 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5478 so that we aren't warned about unused symbols.
5480 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5482 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5484 * xfns.c (x_real_positions): Mark locals as initialized.
5486 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5488 * xterm.c: Fix problems found by static analysis with other toolkits.
5489 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5490 (x_dispatch_event): Declare static if USE_GTK, and
5491 define if USE_GTK || USE_X_TOOLKIT.
5492 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5493 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5494 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5495 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5497 * xmenu.c (menu_help_callback): Pointer type fixes.
5498 Use const pointers when pointing at readonly data. Avoid pointer
5500 (FALSE): Remove unused macro.
5501 (update_frame_menubar): Remove unused decl.
5503 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5505 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5506 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5507 (single_menu_item): Rename local to avoid shadowing.
5509 * keyboard.c (make_lispy_event): Remove unused local var.
5511 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5512 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5514 * bitmaps: Change bitmaps from unsigned char back to the X11
5515 compatible char. Avoid the old compiler warnings about
5516 out-of-range initializers by using, for example, '\xab' rather
5519 * xgselect.c (xgselect_initialize): Check vs interface
5520 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5522 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5524 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5525 to read-only memory.
5527 * fns.c (vector): Remove; this old hack is no longer needed.
5529 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5531 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5533 * xrdb.c (x_load_resources): Omit unused local.
5535 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5536 (x_window): Rename locals to avoid shadowing.
5537 (USG): Use the kludged USG macro, to pacify gcc.
5539 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5540 (x_term_init): Remove local to avoid shadowing.
5542 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5544 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5545 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5547 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5549 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5551 Fix regex.c, syntax.c and friends for buffers > 2GB.
5552 * syntax.h (struct gl_state_s): Declare character position members
5555 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5557 * textprop.c (verify_interval_modification, interval_of):
5558 Declare arguments EMACS_INT.
5560 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5563 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5565 * indent.c (Fvertical_motion): Local variable it_start is now
5568 * regex.c (re_match, re_match_2, re_match_2_internal)
5569 (bcmp_translate, regcomp, regexec, print_double_string)
5570 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5571 (re_compile_pattern, re_exec): Declare arguments and local
5572 variables `size_t' and `ssize_t' and return values `regoff_t', as
5574 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5575 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5576 <compile_stack_type>: `size' and `avail' are now `size_t'.
5578 * regex.h <regoff_t>: Use ssize_t, not int.
5579 (re_search, re_search_2, re_match, re_match_2): Arguments that
5580 specify buffer/string position and length are now ssize_t and
5581 size_t. Return type is regoff_t.
5583 2011-04-16 Ben Key <bkey76@gmail.com>
5585 * nsfont.m: Fixed bugs in ns_get_family and
5586 ns_descriptor_to_entity that were caused by using free to
5587 deallocate memory blocks that were allocated by xmalloc (via
5588 xstrdup). This caused Emacs to crash when compiled with
5589 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5590 --enable-checking=xmallocoverrun). xfree is now used to
5591 deallocate these memory blocks.
5593 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5595 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5597 emacs_write: Accept and return EMACS_INT for sizes.
5598 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5600 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5601 Accept and return EMACS_INT.
5602 (emacs_gnutls_write): Return the number of bytes written on
5604 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5605 (emacs_read, emacs_write): Remove check for negative size, as the
5606 Emacs source code has been audited now.
5607 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5608 (emacs_read, emacs_write): Use it.
5609 * process.c (send_process): Adjust to the new signatures of
5610 emacs_write and emacs_gnutls_write. Do not attempt to store
5611 a byte offset into an 'int'; it might overflow.
5612 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5614 * sound.c: Don't assume sizes fit in 'int'.
5615 (struct sound_device.period_size, alsa_period_size):
5616 Return EMACS_INT, not int.
5617 (struct sound_device.write, vox_write, alsa_write):
5618 Accept EMACS_INT, not int.
5619 (wav_play, au_play): Use EMACS_INT to store sizes and to
5620 record read return values.
5622 2011-04-15 Ben Key <bkey76@gmail.com>
5624 * keyboard.c (Qundefined): Don't declare static since it is used
5626 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5627 static since they are used in nsfont.m.
5629 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5631 * process.c (Qprocessp): Don't declare static.
5632 * lisp.h (Qprocessp): Declare again.
5634 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5636 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5638 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5640 Improve C-level modularity by making more things 'static'.
5642 Don't publish debugger-only interfaces to other modules.
5643 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5644 (verify_bytepos, count_markers): Move decls to the only modules
5646 * region-cache.h (pp_cache): Likewise.
5647 * window.h (check_all_windows): Likewise.
5648 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5650 * sysdep.c (croak): Now static, if
5651 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5652 * syssignal.h (croak): Declare only if not static.
5654 * alloc.c (refill_memory_reserve): Now static if
5655 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5656 * lisp.h (refill_memory_reserve): Declare only if not static.
5658 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5659 Define only if USE_LUCID.
5661 * xrdb.c (x_customization_string, x_rm_string): Now static.
5663 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5664 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5666 * xdisp.c (draw_row_with_mouse_face): Now static.
5667 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5669 * window.h (check_all_windows): Mark externally visible.
5671 * window.c (window_deletion_count): Now static.
5673 * undo.c: Make symbols static if they're not exported.
5674 (last_undo_buffer, last_boundary_position, pending_boundary):
5677 * textprop.c (interval_insert_behind_hooks): Now static.
5678 (interval_insert_in_front_hooks): Likewise.
5680 * term.c: Make symbols static if they're not exported.
5681 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5682 (max_frame_lines, tty_set_terminal_modes):
5683 (tty_reset_terminal_modes, tty_turn_off_highlight):
5684 (get_tty_terminal): Now static.
5685 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5686 * termhooks.h (term_mouse_moveto): Do not declare if
5688 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5689 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5691 * sysdep.c: Make symbols static if they're not exported.
5692 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5694 (sigprocmask_set, full_mask): Remove; unused.
5695 (wait_debugging): Mark as visible.
5696 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5697 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5699 * syntax.c (syntax_temp): Define only if !__GNUC__.
5701 * sound.c (current_sound_device, current_sound): Now static.
5703 * search.c (searchbufs, searchbuf_head): Now static.
5705 * scroll.c (scroll_cost): Remove; unused.
5706 * dispextern.h (scroll_cost): Remove decl.
5708 * region-cache.h (pp_cache): Mark as externally visible.
5710 * process.c: Make symbols static if they're not exported.
5711 (process_tick, update_tick, create_process, chan_process):
5712 (Vprocess_alist, proc_buffered_char, datagram_access):
5713 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5714 (deactivate_process): Mark defn as static, as well as decl.
5715 * lisp.h (create_process): Remove decl.
5716 * process.h (chan_process, Vprocess_alist): Remove decls.
5718 * print.c: Make symbols static if they're not exported.
5719 (print_depth, new_backquote_output, being_printed, print_buffer):
5720 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5721 (print_interval, print_number_index, initial_stderr_stream):
5723 * lisp.h (Fprinc): Remove decl.
5724 (debug_output_compilation_hack): Mark as externally visible.
5726 * sysdep.c (croak): Move decl from here to syssignal.h.
5727 * syssignal.h (croak): Put it here, so the API can be checked when
5728 'croak' is called from dissociate_if_controlling_tty.
5730 * minibuf.c: Make symbols static if they're not exported.
5731 (minibuf_save_list, choose_minibuf_frame): Now static.
5732 * lisp.h (choose_minibuf_frame): Remove decl.
5734 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5736 * lread.c: Make symbols static if they're not exported.
5737 (read_objects, initial_obarray, oblookup_last_bucket_number):
5739 (make_symbol): Remove; unused.
5740 * lisp.h (initial_obarray, make_symbol): Remove decls.
5742 * keyboard.c: Make symbols static if they're not exported.
5743 (single_kboard, recent_keys_index, total_keys, recent_keys):
5744 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5745 (this_single_command_key_start, echoing, last_auto_save):
5746 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5747 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5748 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5749 (Vlispy_mouse_stem, double_click_count):
5751 (force_auto_save_soon): Define only if SIGDANGER.
5752 (ignore_mouse_drag_p): Now static if
5753 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5754 (print_help): Remove; unused.
5755 (stop_character, last_timer_event): Mark as externally visible.
5756 * keyboard.h (ignore_mouse_drag_p): Declare only if
5757 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5758 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5759 * lisp.h (echoing): Remove decl.
5760 (force_auto_save_soon): Declare only if SIGDANGER.
5761 * xdisp.c (redisplay_window): Simplify code, to make it more
5762 obvious that ignore_mouse_drag_p is not accessed if !defined
5763 USE_GTK && !defined HAVE_NS.
5765 * intervals.c: Make symbols static if they're not exported.
5766 (merge_properties_sticky, merge_interval_right, delete_interval):
5768 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5770 * insdel.c: Make symbols static if they're not exported.
5771 However, leave prepare_to_modify_buffer alone. It's never
5772 called from outside this function, but that appears to be a bug.
5773 (combine_after_change_list, combine_after_change_buffer):
5774 (adjust_after_replace, signal_before_change): Now static.
5775 (adjust_after_replace_noundo): Remove; unused.
5776 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5777 (signal_before_change): Remove decls.
5779 * indent.c (val_compute_motion, val_vmotion): Now static.
5781 * image.c: Make symbols static if they're not exported.
5782 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5784 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5785 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5787 * fringe.c (standard_bitmaps): Now static.
5788 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5790 * frame.c: Make symbols static if they're not exported.
5791 (x_report_frame_params, make_terminal_frame): Now static.
5792 (get_frame_param): Now static, unless HAVE_NS.
5793 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5794 (x_get_resource_string): Remove; not used.
5795 * frame.h (make_terminal_frame, x_report_frame_params):
5796 (x_get_resource_string); Remove decls.
5797 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5798 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5800 * font.c, fontset.c: Make symbols static if they're not exported.
5801 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5802 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5803 * font.c (font_close_object): Now static.
5804 * font.h (font_close_object): Remove.
5805 * fontset.c (FONTSET_OBJLIST): Remove.
5806 (free_realized_fontset) #if-0 the body, which does nothing.
5807 (face_suitable_for_char_p): #if-0, as it's never called.
5808 * fontset.h (face_suitable_for_char_p): Remove decl.
5809 * xfaces.c (face_at_string_position):
5810 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5811 since 0 is always ASCII.
5813 * fns.c (weak_hash_tables): Now static.
5815 * fileio.c: Make symbols static if they're not exported.
5816 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5817 (Vwrite_region_annotation_buffers): Now static.
5819 * eval.c: Make symbols static if they're not exported.
5820 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5821 * lisp.h (backtrace_list): Remove decl.
5823 * emacs.c: Make symbols static if they're not exported.
5824 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5825 (fatal_error_code, fatal_error_signal_hook, standard_args):
5827 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5828 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5829 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5830 * lisp.h (fatal_error_signal_hook): Remove decl.
5831 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5833 * editfns.c: Move a (normally-unused) function to its only use.
5834 * editfns.c, lisp.h (get_operating_system_release): Remove.
5835 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5836 worth the hassle of breaking this out.
5838 * xterm.c: Make symbols static if they're not exported.
5839 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5840 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5841 (x_destroy_window, x_delete_display):
5843 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5844 (x_mouse_leave): Remove; unused.
5845 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5846 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5847 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5849 (x_mouse_leave): Declare only if WINDOWSNT.
5850 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5851 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5854 * ftxfont.c: Make symbols static if they're not exported.
5855 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5857 * font.h (ftxfont_driver): Likewise.
5859 * xfns.c: Make symbols static if they're not exported.
5860 (x_last_font_name, x_display_info_for_name):
5861 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5862 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5863 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5864 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5865 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5866 (last_show_tip_args): Now static.
5867 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5868 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5869 (x_screen_planes): Remove; unused.
5870 * dispextern.h (x_screen_planes): Remove decl.
5872 * dispnew.c: Make symbols static if they're not exported.
5873 * dispextern.h (redraw_garbaged_frames, scrolling):
5874 (increment_row_positions): Remove.
5875 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5876 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5878 (redraw_garbaged_frames): Remove; unused.
5880 * xfaces.c: Make symbols static if they're not exported.
5881 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5883 * xterm.h (defined_color): Remove decls.
5884 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5885 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5886 (menu_face_changed_default, defined_color, free_realized_face):
5887 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5888 (ascii_face_of_lisp_face): Remove; unused.
5890 * xdisp.c: Make symbols static if they're not exported.
5891 * dispextern.h (scratch_glyph_row, window_box_edges):
5892 (glyph_to_pixel_coords, set_cursor_from_row):
5893 (get_next_display_element, set_iterator_to_next):
5894 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5895 (show_mouse_face): Remove decls
5896 * frame.h (message_buf_print): Likewise.
5897 * lisp.h (pop_message, set_message, check_point_in_composition):
5899 * xterm.h (set_vertical_scroll_bar): Likewise.
5900 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5901 (message_buf_print, scratch_glyph_row, displayed_buffer):
5902 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5903 (get_next_display_element, show_mouse_face, window_box_edges):
5904 (frame_to_window_pixel_xy, check_point_in_composition):
5905 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5906 (glyph_to_pixel_coords): Remove; unused.
5908 * dired.c (file_name_completion): Now static.
5910 * dbusbind.c (xd_in_read_queued_messages): Now static.
5912 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5913 * data.c (circular_list_error): Remove.
5915 * commands.h (last_point_position, last_point_position_buffer):
5916 (last_point_position_window): Remove decls.
5917 * keyboard.c: Make these variables static.
5919 * coding.h (coding, code_convert_region, encode_coding_gap):
5921 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5922 (iso_code_class, detect_coding, code_convert_region): Now static.
5923 (encode_coding_gap): Remove; unused.
5925 * chartab.c (chartab_chars, chartab_bits): Now static.
5927 * charset.h (charset_iso_8859_1): Remove decl.
5928 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5931 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5932 * ccl.c (Vccl_program_table): Now static.
5933 (check_ccl_update): Remove; unused.
5935 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5936 * category.h: ... from here.
5937 * category.c (check_category_table, set_category_set): Now static.
5939 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5940 * lisp.h: Remove these decls.
5942 * buffer.c (buffer_count): Remove unused var.
5944 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5945 so that it's not optimized away.
5946 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5947 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5948 exported only to the debugger.
5950 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5951 * atimer.h (run_all_atimers): Remove; not exported.
5953 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5954 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5955 was inaccessible from Lisp.
5956 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5957 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5959 alloc.c: Import and export fewer symbols, and remove unused items.
5960 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5962 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5963 it's not optimized away by whole-program optimization.
5964 (message_enable_multibyte, free_misc): Remove.
5965 (catchlist, handlerlist, mark_backtrace):
5966 Declare only if BYTE_MARK_STACK.
5967 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5968 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5969 (message_enable_multibyte): Remove decl.
5970 (free_misc, interval_free_list, float_block, float_block_index):
5971 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5972 (cons_free_list, last_marked_index):
5974 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5975 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5976 (mark_backtrace): Define only if BYTE_MARK_STACK.
5977 * xdisp.c (message_enable_multibyte): Now static.
5979 Declare Lisp_Object Q* variables to be 'static' if not exported.
5980 This makes it easier for human readers (and static analyzers)
5981 to see whether these variables are used from other modules.
5982 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5983 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5984 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5985 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5986 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5987 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5988 * xmenu.c, xselect.c:
5989 Declare Q* vars static if they are not used in other modules.
5990 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5991 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5992 Remove decls of unexported vars.
5993 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5995 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5997 Make Emacs functions such as Fatom 'static' by default.
5998 This makes it easier for human readers (and static analyzers)
5999 to see whether these functions can be called from other modules.
6000 DEFUN now defines a static function. To make the function external
6001 so that it can be used in other C modules, use the new macro DEFUE.
6002 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6003 (Finit_image_library):
6004 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6005 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6006 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6007 Remove decls, since these functions are now static.
6008 (Funintern, Fget_internal_run_time): New decls, since these functions
6009 were already external.
6011 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6012 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6013 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6014 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6015 * keyboard.c, keymap.c, lread.c:
6016 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6017 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6018 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6019 Mark functions with DEFUE instead of DEFUN,
6020 if they are used in other modules.
6021 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6022 decls for now-static functions.
6023 * buffer.h (Fdelete_overlay): Remove decl.
6024 * callproc.c (Fgetenv_internal): Mark as internal.
6025 * composite.c (Fremove_list_of_text_properties): Remove decl.
6026 (Fcomposition_get_gstring): New forward static decl.
6027 * composite.h (Fcomposite_get_gstring): Remove decl.
6028 * dired.c (Ffile_attributes): New forward static decl.
6029 * doc.c (Fdocumntation_property): New forward static decl.
6030 * eval.c (Ffetch_bytecode): New forward static decl.
6031 (Funintern): Remove extern decl; now in .h file where it belongs.
6032 * fileio.c (Fmake_symbolic_link): New forward static decl.
6033 * image.c (Finit_image_library): New forward static decl.
6034 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6035 * intervals.h (Fprevious_property_change):
6036 (Fremove_list_of_text_properties): Remove decls.
6037 * keyboard.c (Fthis_command_keys): Remove decl.
6038 (Fcommand_execute): New forward static decl.
6039 * keymap.c (Flookup_key): New forward static decl.
6040 (Fcopy_keymap): Now static.
6041 * keymap.h (Flookup_key): Remove decl.
6042 * process.c (Fget_process): New forward static decl.
6043 (Fprocess_datagram_address): Mark as internal.
6044 * syntax.c (Fsyntax_table_p): New forward static decl.
6045 (skip_chars): Remove duplicate decl.
6046 * textprop.c (Fprevious_property_change): New forward static decl.
6047 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6049 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6050 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6052 * editfns.c (Fformat): Remove unreachable code.
6054 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6056 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6059 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6061 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6062 when at ZV. (Bug#8487)
6064 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6066 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6068 * keyboard.c (parse_tool_bar_item): Likewise.
6069 * sound.c (sound_cleanup, alsa_close): Likewise.
6070 * termcap.c (tgetent): Likewise.
6071 * xfns.c (x_default_font_parameter): Likewise.
6072 * xsettings.c (read_and_apply_settings): Likewise.
6074 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6075 (overrun_check_free): Protoize.
6077 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6079 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6080 since callers should never pass a negative size.
6081 Change the signature to match that of plain 'read' and 'write'; see
6082 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6083 * lisp.h: Update prototypes of emacs_write and emacs_read.
6085 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6087 * xdisp.c (redisplay_window): Don't try to determine the character
6088 position of the scroll margin if the window start point w->startp
6089 is outside the buffer's accessible region. (Bug#8468)
6091 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6093 Fix write-region and its subroutines for buffers > 2GB.
6094 * fileio.c (a_write, e_write): Modify declaration of arguments and
6095 local variables to support buffers larger than 2GB.
6096 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6098 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6099 argument, local variables, and return value.
6101 * lisp.h: Update prototypes of emacs_write and emacs_read.
6103 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6105 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6107 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6109 Fix more problems found by GCC 4.6.0's static checks.
6111 * xdisp.c (vmessage): Use a better test for character truncation.
6113 * charset.c (load_charset_map): <, not <=, for optimization,
6114 and to avoid potential problems with integer overflow.
6115 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6116 * casetab.c (set_identity, shuffle): Likewise.
6117 * editfns.c (Fformat): Likewise.
6118 * syntax.c (skip_chars): Likewise.
6120 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6121 This also lets GCC 4.6.0 generate slightly better loop code.
6123 * callint.c (Fcall_interactively): <, not <=, for optimization.
6124 (Fcall_interactively): Count the number of arguments produced,
6125 not the number of arguments given. This is simpler and lets GCC
6126 4.6.0 generate slightly better code.
6128 * ftfont.c: Distingish more carefully between FcChar8 and char.
6129 The previous code passed unsigned char * to a functions like
6130 strlen and xstrcasecmp that expect char *, which does not
6131 conform to the C standard.
6132 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6133 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6134 char * when the C standard requires it.
6136 * keyboard.c (read_char): Remove unused var.
6138 * eval.c: Port to Windows vsnprintf (Bug#8435).
6140 (SIZE_MAX): Define if the headers do not.
6141 (verror): Do not give up if vsnprintf returns a negative count.
6142 Instead, grow the buffer. This ports to Windows vsnprintf, which
6143 does not conform to C99. Problem reported by Eli Zaretskii.
6144 Also, simplify the allocation scheme, by avoiding the need for
6145 calling realloc, and removing the ALLOCATED variable.
6147 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6149 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6150 But keep the doprint source code for now, as we might revamp it
6151 and use it again (Bug#8435).
6152 * lisp.h (doprnt): Remove.
6153 * Makefile.in (base_obj): Remove doprnt.o.
6154 * deps.mk (doprnt.o): Remove.
6156 error: Print 32- and 64-bit integers portably (Bug#8435).
6157 Without this change, on typical 64-bit hosts error ("...%d...", N)
6158 was used to print both 32- and 64-bit integers N, which relied on
6160 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6162 * lisp.h (error, verror): Mark as printf-like functions.
6163 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6164 Report overflow in size calculations when allocating printf buffer.
6165 Do not truncate output string at its first null byte.
6166 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6167 Truncate the output at a character boundary, since vsnprintf does not
6169 * charset.c (check_iso_charset_parameter): Convert internal
6170 character to string before calling 'error', since %c now has the
6172 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6173 overflow when computing char to be passed to 'error'. Do not
6174 pass Lisp_Object to 'error'; pass the integer instead.
6175 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6176 formatted with plain %d.
6178 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6180 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6182 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6184 * xterm.c (x_catch_errors): Remove duplicate declaration.
6186 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6188 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6190 2011-04-10 Jim Meyering <meyering@redhat.com>
6192 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6193 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6194 return ssize_t not "int", and use size_t as the buffer length.
6195 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6196 * gnutls.h: Update declarations.
6197 * process.c (read_process_output): Use ssize_t, to match.
6198 (send_process): Likewise.
6200 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6202 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6204 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6206 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6207 Use unsigned char, to match FcChar8 type definition.
6209 * xterm.c (handle_one_xevent):
6210 * xmenu.c (create_and_show_popup_menu):
6211 * xselect.c (x_decline_selection_request)
6212 (x_reply_selection_request): Avoid type-punned deref of X events.
6214 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6216 Fix some uses of `int' instead of EMACS_INT.
6217 * search.c (string_match_1, fast_string_match)
6218 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6219 (scan_buffer, find_next_newline_no_quit)
6220 (find_before_next_newline, search_command, Freplace_match)
6221 (Fmatch_data): Make some `int' variables be EMACS_INT.
6223 * xdisp.c (display_count_lines): 3rd argument and return value now
6224 EMACS_INT. All callers changed.
6225 (pint2hrstr): Last argument is now EMACS_INT.
6227 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6228 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6229 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6230 (decode_coding_utf_16, decode_coding_emacs_mule)
6231 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6232 (decode_coding_ccl, decode_coding_charset)
6233 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6234 (decode_coding_iso_2022, decode_coding_emacs_mule)
6235 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6236 <char_offset, last_offset>: Declare EMACS_INT.
6237 (encode_coding_utf_8, encode_coding_utf_16)
6238 (encode_coding_emacs_mule, encode_invocation_designation)
6239 (encode_designation_at_bol, encode_coding_iso_2022)
6240 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6241 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6243 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6244 (encode_invocation_designation): Last argument P_NCHARS is now
6246 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6247 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6249 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6252 * ccl.c (Fccl_execute_on_string): Declare some variables
6255 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6257 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6259 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6261 * process.c (Fformat_network_address): Doc fix.
6263 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6265 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6267 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6269 * keyboard.c (read_char): Call Lisp function help-form-show,
6270 instead of using internal_with_output_to_temp_buffer.
6271 (Qhelp_form_show): New var.
6272 (syms_of_keyboard): Use DEFSYM macro.
6274 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6276 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6278 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6280 * process.c (Flist_processes): Remove to Lisp.
6281 (list_processes_1): Delete.
6283 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6285 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6287 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6289 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6291 Fix more problems found by GCC 4.6.0's static checks.
6293 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6295 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6297 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6299 * xdisp.c (vmessage): Mark as a printf-like function.
6301 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6303 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6305 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6306 printf-like functions.
6307 (tiff_load): Add casts to remove these marks before passing them
6308 to system-supplied API.
6310 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6312 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6313 This avoids several warnings with gcc -Wstrict-overflow.
6314 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6315 directly, rather than having caller test rule sign. This avoids
6316 some unnecessary tests.
6317 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6318 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6319 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6321 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6322 (xfont_open): Avoid unnecessary tests.
6324 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6326 * composite.h, composite.c (composition_gstring_put_cache):
6327 Use EMACS_INT, not int, for length.
6329 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6330 breaking out part of COMPOSITION_DECODE_RULE.
6331 (COMPOSITION_DECODE_RULE): Use it.
6332 * composite.c (get_composition_id): Remove unused local vars,
6333 by using the new macro.
6335 * textprop.c (set_text_properties_1): Change while to do-while,
6336 since the condition is always true at first.
6338 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6339 (interval_deletion_adjustment): Return unsigned value.
6342 * process.c (list_processes_1, create_pty, read_process_output):
6343 (exec_sentinel): Remove vars that were set but not used.
6344 (create_pty): Remove unnecessary "volatile"s.
6345 (Fnetwork_interface_info): Avoid possibility of int overflow.
6346 (read_process_output): Do adaptive read buffering even if carryover.
6347 (read_process_output): Simplify nbytes computation if buffered.
6349 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6351 * syntax.c (scan_words): Remove var that was set but not used.
6352 (update_syntax_table): Use unsigned instead of int.
6354 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6355 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6356 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6358 * print.c (print_error_message): Avoid int overflow.
6360 * font.c (font_list_entities): Redo for clarity,
6361 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6363 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6364 (font_score): Avoid potential overflow in diff calculation.
6366 * fns.c (substring_both): Remove var that is set but not used.
6367 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6369 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6371 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6372 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6373 can always succeed if overflow has undefined behavior.
6375 * search.c (boyer_moore, wordify): Remove vars set but not used.
6376 (wordify): Omit three unnecessary tests.
6378 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6379 All callers changed. This avoids the need for an unused var.
6381 * casefiddle.c (casify_region): Remove var that is set but not used.
6383 * dired.c (file_name_completion): Remove var that is set but not used.
6385 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6387 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6388 (Finsert_file_contents): Remove unnecessary code checking fd.
6390 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6391 Check for integer overflow on size calculations.
6393 * buffer.c (Fprevious_overlay_change): Remove var that is set
6396 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6397 Remove vars that are set but not used.
6398 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6399 (timer_check_2): Mark vars as initialized.
6401 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6403 * image.c (lookup_image): Remove var that is set but not used.
6404 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6406 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6407 that are set but not used.
6409 * xfns.c (make_invisible_cursor): Don't return garbage
6410 if XCreateBitmapFromData fails (Bug#8410).
6412 * xselect.c (x_get_local_selection, x_handle_property_notify):
6413 Remove vars that are set but not used.
6415 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6416 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6418 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6419 Remove var that is set but not used.
6420 (scroll_bar_windows_size): Now size_t, not int.
6421 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6424 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6425 (map_tty_color) [!defined MSDOS]: Likewise.
6427 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6429 * coding.c: Remove vars that are set but not used.
6430 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6431 All callers changed.
6432 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6433 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6434 (decode_coding_charset): Remove vars that are set but not used.
6436 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6437 that is set but not used.
6439 * print.c (print_object): Remove var that is set but not used.
6441 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6442 The gnulib version avoids calling malloc in the usual case,
6443 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6444 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6445 * filelock.c (current_lock_owner): Likewise.
6446 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6447 * sysdep.c: Include allocator.h, careadlinkat.h.
6448 (emacs_no_realloc_allocator): New static constant.
6449 (emacs_readlink): New function.
6450 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6451 ../lib/careadlinkat.h.
6453 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6455 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6456 first non-nil return value).
6458 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6460 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6461 if not defined (Bug#8403).
6463 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6465 * xdisp.c (display_count_lines): Remove parameter `start',
6466 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6467 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6468 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6469 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6470 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6471 and thereabouts. All callers changed.
6472 (get_per_char_metric): Remove parameter `f', unused since
6473 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6475 2011-04-02 Jim Meyering <meyering@redhat.com>
6477 do not dereference NULL upon failed strdup
6478 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6479 (ns_get_family): Likewise.
6481 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6483 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6485 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6487 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6490 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6492 Add lexical binding.
6494 * window.c (Ftemp_output_buffer_show): New fun.
6495 (Fsave_window_excursion):
6496 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6498 * lread.c (lisp_file_lexically_bound_p): New function.
6499 (Fload): Bind Qlexical_binding.
6500 (readevalloop): Remove `evalfun' arg.
6501 Bind Qinternal_interpreter_environment.
6502 (Feval_buffer): Bind Qlexical_binding.
6503 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6505 (syms_of_lread): Declare `lexical-binding'.
6507 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6509 * keyboard.c (eval_dyn): New fun.
6510 (menu_item_eval_property): Use it.
6512 * image.c (parse_image_spec): Use Ffunctionp.
6514 * fns.c (concat, mapcar1): Accept byte-code-functions.
6516 * eval.c (Fsetq): Handle lexical vars.
6517 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6518 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6519 (FletX, Flet): Obey lexical binding.
6520 (Fcommandp): Handle closures.
6521 (Feval): New `lexical' arg.
6522 (eval_sub): New function extracted from Feval. Use it almost
6523 everywhere where Feval was used. Look up vars in lexical env.
6525 (Ffunctionp): Move from subr.el.
6526 (Ffuncall): Handle closures.
6527 (apply_lambda): Remove `eval_flags'.
6528 (funcall_lambda): Handle closures and new byte-code-functions.
6529 (Fspecial_variable_p): New function.
6530 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6531 but without exporting it to Lisp.
6533 * doc.c (Fdocumentation, store_function_docstring):
6534 * data.c (Finteractive_form): Handle closures.
6536 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6539 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6541 (exec_byte_code): New function extracted from Fbyte_code to handle new
6542 calling convention for byte-code-functions. Add new byte-codes.
6544 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6546 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6548 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6550 * xdisp.c (redisplay_internal): Fix prototype.
6552 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6554 * xdisp.c (SCROLL_LIMIT): New macro.
6555 (try_scrolling): Use it when setting scroll_limit.
6556 Limit scrolling to 100 screen lines.
6557 (redisplay_window): Even when falling back on "recentering",
6558 position point in the window according to scroll-conservatively,
6559 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6561 (try_scrolling): When point is above the window, allow searching
6562 as far as scroll_max, or one screenful, to compute vertical
6563 distance from PT to the scroll margin position. This prevents
6564 try_scrolling from unnecessarily failing when
6565 scroll-conservatively is set to a value slightly larger than the
6566 window height. Clean up the case of PT below the margin at bottom
6567 of window: scroll_max can no longer be INT_MAX. When aggressive
6568 scrolling is in use, don't let point enter the opposite scroll
6569 margin as result of the scroll.
6570 (syms_of_xdisp) <scroll-conservatively>: Document the
6571 threshold of 100 lines for never-recentering scrolling.
6573 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6575 * dispextern.h (move_it_by_lines):
6576 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6577 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6578 (message_log_check_duplicate): Remove parameters `prev_bol' and
6579 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6580 (redisplay_internal): Remove parameter `preserve_echo_area',
6581 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6583 * indent.c (Fvertical_motion):
6584 * window.c (window_scroll_pixel_based, Frecenter):
6585 Don't pass `need_y_p' to `move_it_by_lines'.
6587 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6589 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6590 steal a few bits to be more compact.
6591 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6592 Remove unneeded casts.
6594 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6596 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6598 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6599 binding" message (bug#7967).
6601 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6603 Fix more problems found by GCC 4.6.0's static checks.
6605 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6606 Remove unused local var.
6608 * editfns.c (Fmessage_box): Remove unused local var.
6610 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6611 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6612 Omit unused local vars.
6613 * window.c (shrink_windows): Omit unused local var.
6614 * menu.c (digest_single_submenu): Omit unused local var.
6615 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6616 Omit unused local var.
6618 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6619 Don't assume string length fits in int.
6620 (keyremap_step, read_key_sequence): Use size_t for sizes.
6621 (read_key_sequence): Don't check last_real_key_start redundantly.
6623 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6624 instead of alloca (Bug#8344).
6626 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6627 (Fbacktrace_frame): Don't assume nframes fits in int.
6629 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6631 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6634 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6636 * cm.c (calccost): Turn while-do into do-while, for clarity.
6638 * keyboard.c (syms_of_keyboard): Use the same style as later
6639 in this function when indexing through an array. This also
6640 works around GCC bug 48267.
6642 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6644 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6646 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6647 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6649 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6650 This avoids undefined behavior on integer overflow, and is a bit
6651 more convenient anyway since it is compared to a size_t variable.
6653 Variadic C functions now count arguments with size_t, not int.
6654 This avoids an unnecessary limitation on 64-bit machines, which
6655 caused (substring ...) to crash on large vectors (Bug#8344).
6656 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6657 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6658 All variadic functions and their callers changed accordingly.
6659 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6660 * data.c (arith_driver, float_arith_driver): Likewise.
6661 * editfns.c (general_insert_function): Likewise.
6662 * eval.c (struct backtrace.nargs, interactive_p)
6663 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6664 (funcall_lambda, mark_backtrace): Likewise.
6665 * fns.c (concat): Likewise.
6666 * frame.c (x_set_frame_parameters): Likewise.
6667 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6668 0 if not found, not -1. All callers changed.
6670 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6671 (stack_copy_size): Now size_t, not int.
6672 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6674 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6676 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6677 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6678 All callers changed.
6680 * lisp.h (multibyte_char_to_unibyte):
6681 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6682 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6683 * character.h (CHAR_TO_BYTE8):
6684 * cmds.c (internal_self_insert):
6685 * editfns.c (general_insert_function):
6686 * keymap.c (push_key_description):
6687 * search.c (Freplace_match):
6688 * xdisp.c (message_dolog, set_message_1): All callers changed.
6690 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6692 * keyboard.c (safe_run_hook_funcall): New function.
6693 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6694 don't set the hook to nil, but remove the offending function instead.
6695 (Qcommand_hook_internal): Remove, unused.
6696 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6697 Vcommand_hook_internal.
6699 * eval.c (enum run_hooks_condition): Remove.
6700 (funcall_nil, funcall_not): New functions.
6701 (run_hook_with_args): Call each function through a `funcall' argument.
6702 Remove `cond' argument, now redundant.
6703 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6704 (Frun_hook_with_args_until_failure): Adjust accordingly.
6705 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6707 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6709 * dispextern.h (string_buffer_position): Remove declaration.
6711 * print.c (strout): Remove parameter `multibyte', unused since
6712 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6714 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6715 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6716 All callers changed.
6718 * w32.c (_wsa_errlist): Use braces for struct initializers.
6720 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6721 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6722 All callers changed.
6723 (string_buffer_position): Likewise. Also, make static (it's never
6724 used outside xdisp.c).
6725 (cursor_row_p): Remove parameter `w', unused since
6726 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6727 (decode_mode_spec): Remove parameter `precision', introduced during
6728 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6729 All callers changed.
6731 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6733 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6735 2011-03-27 Anders Lindgren <andlind@gmail.com>
6737 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6738 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6739 (ns_update_auto_hide_menu_bar): New functions.
6740 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6741 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6742 ns_constrain_all_frames.
6743 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6744 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6746 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6748 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6750 2011-03-27 Glenn Morris <rgm@gnu.org>
6752 * syssignal.h: Replace RETSIGTYPE with void.
6753 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6754 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6755 Replace SIGTYPE with void everywhere.
6756 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6757 * s/template.h (SIGTYPE): Remove commented out definition.
6759 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6761 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6762 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6764 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6766 * w32.c (read_unc_volume): Use parameter `henum', instead of
6767 global variable `wget_enum_handle'.
6769 * keymap.c (describe_vector): Remove parameters `indices' and
6770 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6771 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6773 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6775 * keyboard.c (timer_check): Remove parameter `do_it_now',
6776 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6777 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6778 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6780 * keyboard.c (read_char):
6781 * w32menu.c (w32_menu_display_help):
6782 * xmenu.c (show_help_event, menu_help_callback):
6783 Adjust calls to `show_help_echo'.
6785 * gtkutil.c (xg_maybe_add_timer):
6786 * keyboard.c (readable_events):
6787 * process.c (wait_reading_process_output):
6788 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6790 * insdel.c (adjust_markers_gap_motion):
6791 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6792 (gap_left, gap_right): Don't call it.
6794 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6796 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6797 incurred during fontification.
6799 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6801 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6802 (DEFVAR_PER_BUFFER): Don't pass it.
6804 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6805 (scrolling_window): Don't pass it.
6807 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6809 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6811 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6813 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6814 of variables specific to SELinux and computation of `encoded_absname'.
6816 * image.c (XPutPixel): Remove unused variable `height'.
6818 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6820 * unexw32.c (get_section_info): Remove unused variable `section'.
6822 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6823 (system_process_attributes): Remove unused variable `sess'.
6824 (sys_read): Remove unused variable `err'.
6826 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6827 (w32_wnd_proc): Remove unused variable `isdead'.
6828 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6829 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6830 (x_create_tip_frame): Remove unused variable `tem'.
6832 * w32inevt.c (w32_console_read_socket):
6833 Remove unused variable `no_events'.
6835 * w32term.c (x_draw_composite_glyph_string_foreground):
6836 Remove unused variable `width'.
6838 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6840 * w32term.c (x_set_glyph_string_clipping):
6841 Don't pass uninitialized region to CombineRgn.
6843 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6845 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6846 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6847 (Fx_close_connection): Remove unused variable `i'.
6849 * w32font.c (w32font_draw): Return number of glyphs.
6850 (w32font_open_internal): Remove unused variable `i'.
6851 (w32font_driver): Add missing initializer.
6853 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6854 (fill_in_menu): Remove unused variable `items_added'.
6856 * w32term.c (last_mouse_press_frame): Remove static global variable.
6857 (w32_clip_to_row): Remove unused variable `f'.
6858 (x_delete_terminal): Remove unused variable `i'.
6860 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6861 (NOTHING): Remove unused static global variable.
6862 (uniscribe_check_otf): Remove unused variable `table'.
6863 (uniscribe_font_driver): Add missing initializers.
6865 2011-03-23 Julien Danjou <julien@danjou.info>
6867 * term.c (Fsuspend_tty, Fresume_tty):
6868 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6869 * window.c (temp_output_buffer_show):
6870 * insdel.c (signal_before_change):
6871 * frame.c (Fhandle_switch_frame):
6872 * fileio.c (Fdo_auto_save):
6873 * emacs.c (Fkill_emacs):
6874 * editfns.c (save_excursion_restore):
6875 * cmds.c (internal_self_insert):
6876 * callint.c (Fcall_interactively):
6877 * buffer.c (Fkill_all_local_variables):
6878 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6880 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6881 unconditionnaly since it does the check itself.
6883 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6885 Fix more problems found by GCC 4.5.2's static checks.
6887 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6888 the first time through the loop, since we know p0 < p1 then.
6889 This also avoids a gcc -Wstrict-overflow warning.
6891 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6892 leading to a memory leak, possible in functions like
6893 load_charset_map_from_file that can allocate an unbounded number
6894 of objects (Bug#8318).
6896 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6897 that could (at least in theory) be that large.
6899 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6900 This is less likely to overflow, and avoids undefined behavior if
6901 overflow does occur. All callers changed. Use strtoul to scan
6902 for the unsigned long integer.
6903 (pint2hrstr): Simplify and tune code slightly.
6904 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6906 * scroll.c (do_scrolling): Work around GCC bug 48228.
6907 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6909 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6910 This also avoids a warning with gcc -Wstrict-overflow.
6911 (validate_x_resource_name): Simplify count usage.
6912 This also avoids a warning with gcc -Wstrict-overflow.
6914 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6917 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6919 * process.c (Fmake_network_process): Use socklen_t, not int,
6920 where POSIX says socklen_t is required in portable programs.
6921 This fixes a porting bug on hosts like 64-bit HP-UX, where
6922 socklen_t is wider than int (Bug#8277).
6923 (Fmake_network_process, server_accept_connection):
6924 (wait_reading_process_output, read_process_output):
6927 * process.c: Rename or move locals to avoid shadowing.
6928 (list_processes_1, Fmake_network_process):
6929 (read_process_output_error_handler, exec_sentinel_error_handler):
6930 Rename or move locals.
6931 (Fmake_network_process): Define label "retry_connect" only if needed.
6932 (Fnetwork_interface_info): Fix pointer signedness.
6933 (process_send_signal): Add cast to avoid pointer signedness problem.
6934 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6935 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6937 Make tparam.h and terminfo.c consistent.
6938 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6939 Include tparam.h instead, since it declares them.
6940 * cm.h (PC): Remove extern decl; tparam.h now does this.
6941 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6942 * terminfo.c: Include tparam.h, to check interfaces.
6943 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6944 (tparam): Adjust signature to match interface in tparam.h;
6945 this removes some undefined behavior. Check that outstring and len
6946 are zero, which they always are with Emacs.
6947 * tparam.h (PC, BC, UP): New extern decls.
6949 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6950 (xftfont_open): Rename locals to avoid shadowing.
6952 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6953 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6954 (OTF_TAG_SYM): Omit macro if not needed.
6955 (ftfont_list): Remove unused local.
6956 (get_adstyle_property, ftfont_pattern_entity):
6957 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6958 Rename locals to avoid shadowing.
6960 * xfont.c (xfont_list_family): Mark var as initialized.
6962 * xml.c (make_dom): Now static.
6964 * composite.c (composition_compute_stop_pos): Rename local to
6966 (composition_reseat_it): Remove unused locals.
6967 (find_automatic_composition, composition_adjust_point): Likewise.
6968 (composition_update_it): Mark var as initialized.
6969 (find_automatic_composition): Mark vars as initialized,
6970 with a FIXME (Bug#8290).
6972 character.h: Rename locals to avoid shadowing.
6973 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6974 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6975 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6976 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6979 * textprop.c (property_change_between_p): Remove; unused.
6981 * intervals.c (interval_start_pos): Now static.
6983 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6985 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6986 Rename locals to avoid shadowing.
6988 * sound.c (wav_play, au_play, Fplay_sound_internal):
6989 Fix pointer signedness.
6990 (alsa_choose_format): Remove unused local var.
6991 (wav_play): Initialize a variable to 0, to prevent undefined
6992 behavior (Bug#8278).
6994 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6996 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6998 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6999 clobbering (Bug#8298).
7000 * sysdep.c (sys_subshell): Likewise.
7001 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7003 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7004 This should get cleaned up, so that child_setup has the
7005 same signature on all platforms.
7007 * callproc.c (call_process_cleanup): Now static.
7008 (relocate_fd): Rename locals to avoid shadowing.
7010 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7012 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7013 not to be necessary, and produces flickering.
7015 2011-03-20 Glenn Morris <rgm@gnu.org>
7017 * config.in: Remove file.
7019 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7021 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7022 are now in src/globals.h.
7023 (syms_of_minibuf): Remove spurious & from previous change.
7025 2011-03-20 Leo <sdl.web@gmail.com>
7027 * minibuf.c (completing-read-function): New variable.
7028 (completing-read-default): Rename from completing-read.
7029 (completing-read): Call completing-read-function.
7031 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7033 * xfaces.c (Fx_load_color_file):
7034 Read color file from absolute filename (bug#8250).
7036 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7038 * makefile.w32-in: Update dependencies.
7040 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7042 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7044 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7046 Fix more problems found by GCC 4.5.2's static checks.
7048 * process.c (make_serial_process_unwind, send_process_trap):
7049 (sigchld_handler): Now static.
7051 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7052 That way, the code declares only the vars that it needs.
7053 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7054 * s/cygwin.h (PTY_ITERATION): Likewise.
7055 * s/darwin.h (PTY_ITERATION): Likewise.
7056 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7058 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7059 * process.c (allocate_pty): Don't declare stb unless it's needed.
7061 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7062 (CONSTANTLIM): Remove; unused.
7063 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7064 Define only if needed.
7066 * unexelf.c (unexec): Name an expression,
7067 to avoid gcc -Wbad-function-cast warning.
7068 Use a different way to cause a compilation error if anyone uses
7069 n rather than nn, a way that does not involve shadowing.
7070 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7072 * deps.mk (unexalpha.o): Remove; unused.
7074 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7075 * unexec.h: New file.
7076 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7077 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7079 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7080 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7081 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7082 Change as necessary to match prototype in unexec.h.
7084 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7086 (back_comment, skip_chars): Mark vars as initialized.
7088 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7089 Rename locals to avoid shadowing.
7091 * lread.c (read1): Rewrite so as not to use empty "else".
7092 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7094 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7096 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7097 warning when compiling print.c.
7099 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7100 instead of using an uninitialized var.
7101 (font_sort_entities): Mark var as initialized.
7103 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7105 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7106 pointers to constants.
7107 (font_parse_fcname): Remove unused vars.
7108 (font_delete_unmatched): Now static.
7109 (font_get_spec): Remove; unused.
7110 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7111 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7112 Rename or move locals to avoid shadowing.
7114 * fns.c (require_nesting_list, require_unwind): Now static.
7115 (Ffillarray): Rename locals to avoid shadowing.
7117 * floatfns.c (domain_error2): Define only if needed.
7118 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7120 * alloc.c (mark_backtrace): Move decl from here ...
7121 * lisp.h: ... to here, so that it can be checked.
7123 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7124 (Fdefvar): Rewrite so as not to use empty "else".
7125 (lisp_indirect_variable): Name an expression,
7126 to avoid gcc -Wbad-function-cast warning.
7127 (Fdefvar): Rename locals to avoid shadowing.
7129 * callint.c (quotify_arg, quotify_args): Now static.
7130 (Fcall_interactively): Rename locals to avoid shadowing.
7131 Use const pointer when appropriate.
7133 * lisp.h (get_system_name, get_operating_system_release):
7134 Move decls here, to check interfaces.
7135 * process.c (get_operating_system_release): Move decl to lisp.h.
7136 * xrdb.c (get_system_name): Likewise.
7137 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7138 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7139 some of which prompt warnings from gcc -Wbad-function-cast.
7140 (Fformat_time_string, Fencode_time, Finsert_char):
7141 (Ftranslate_region_internal, Fformat):
7142 Rename or remove local vars to avoid shadowing.
7143 (Ftranslate_region_internal): Mark var as initialized.
7145 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7148 * lisp.h (eassert): Check that the argument compiles, even if
7149 ENABLE_CHECKING is not defined.
7151 * data.c (Findirect_variable): Name an expression, to avoid
7152 gcc -Wbad-function-cast warning.
7153 (default_value, arithcompare, arith_driver, arith_error): Now static.
7154 (store_symval_forwarding): Rename local to avoid shadowing.
7155 (Fmake_variable_buffer_local, Fmake_local_variable):
7156 Mark variables as initialized.
7157 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7159 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7160 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7161 Rename locals to avoid shadowing.
7162 (mark_stack): Move local variables into the #ifdef region where
7164 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7165 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7167 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7168 (GC_STRING_CHARS): Remove; not used.
7169 (Fmemory_limit): Cast sbrk's returned value to char *.
7171 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7172 avoids undefined behavior in theory.
7174 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7176 Use functions, not macros, for up- and down-casing (Bug#8254).
7177 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7178 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7179 to use the following functions instead of these macros.
7180 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7181 EMACS_INT, since callers assume the returned value fits in int.
7182 (upcase1): Likewise, for UPCASE_TABLE.
7183 (uppercasep, lowercasep, upcase): New static inline functions.
7184 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7185 the race-condition problem in the old DOWNCASE.
7187 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7188 Rename locals to avoid shadowing.
7189 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7190 (regex_compile, re_search_2, re_match_2_internal):
7191 Remove unused local vars.
7192 (FREE_VAR): Rewrite so as not to use empty "else",
7193 which gcc can warn about.
7194 (regex_compile, re_match_2_internal): Mark locals as initialized.
7195 (RETALLOC_IF): Define only if needed.
7196 (WORDCHAR_P): Likewise. This one is never needed, but is used
7197 only in a comment talking about a compiler bug, so put inside
7198 the #if 0 of that comment.
7199 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7200 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7203 * search.c (boyer_moore): Rename locals to avoid shadowing.
7204 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7205 (PREV_CHAR_BOUNDARY): Likewise.
7207 * search.c (simple_search): Remove unused var.
7209 * dired.c (compile_pattern): Move decl from here ...
7210 * lisp.h: ... to here, so that it can be checked.
7211 (struct re_registers): New forward decl.
7213 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7215 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7217 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7218 Rename locals to avoid shadowing.
7219 (Fvertical_motion): Mark locals as initialized.
7221 * casefiddle.c (casify_object, casify_region): Now static.
7222 (casify_region): Mark local as initialized.
7224 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7226 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7227 New macros, so that the caller can use some names other than
7228 gcpro1, gcpro2, etc.
7229 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7231 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7232 argument, for consistency with GCPRO2_VAR, etc: it is now the
7233 prefix of the variable, not the variable itself. All uses
7235 * dired.c (directory_files_internal, file_name_completion):
7236 Rename locals to avoid shadowing.
7238 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7239 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7240 dired.c's scmp function, had undefined behavior.
7241 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7242 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7243 * buffer.h: ... to here, because these macros use current_buffer,
7244 and the new implementation with inline functions needs to have
7245 current_buffer in scope now, rather than later when the macros
7247 (downcase, upcase1): New static inline functions.
7248 (DOWNCASE, UPCASE1): Reimplement using these functions.
7249 This avoids undefined behavior in expressions like
7250 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7251 from race conditions in accessing the global variables
7252 case_temp1 and case_temp2.
7253 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7254 * lisp.h (case_temp1, case_temp2): Remove their decls.
7255 * character.h (ASCII_CHAR_P): Move from here ...
7256 * lisp.h: ... to here, so that the inline functions mentioned
7259 * dired.c (directory_files_internal_unwind): Now static.
7261 * fileio.c (file_name_as_directory, directory_file_name):
7262 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7264 (file_name_as_directory): Use const pointers when appropriate.
7265 (Fexpand_file_name): Likewise. In particular, newdir might
7266 point at constant storage, so make it a const pointer.
7267 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7268 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7270 (Fset_file_times, Finsert_file_contents, auto_save_error):
7271 Rename locals to avoid shadowing.
7273 * minibuf.c (choose_minibuf_frame_1): Now static.
7274 (Ftry_completion, Fall_completions): Rename or remove locals
7277 * marker.c (bytepos_to_charpos): Remove; unused.
7279 * lisp.h (verify_bytepos, count_markers): New decls,
7280 so that gcc does not warn that these functions aren't declared.
7282 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7283 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7284 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7285 (copy_text): Remove unused local var.
7287 * filelock.c (within_one_second): Now static.
7288 (lock_file_1): Rename local to avoid shadowing.
7290 * buffer.c (fix_overlays_before): Mark locals as initialized.
7291 (fix_start_end_in_overlays): Likewise. This function should be
7292 simplified by using pointers-to-pointers, but that's a different
7294 (switch_to_buffer_1): Now static.
7295 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7296 (report_overlay_modification): Rename locals to avoid shadowing.
7298 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7299 Fix pointer signedness issue.
7300 (sys_subshell): Mark local as volatile if checking for lint,
7301 to suppress a gcc -Wclobbered warning that does not seem to be right.
7302 (MAXPATHLEN): Define only if needed.
7304 * process.c (serial_open, serial_configure): Move decls from here ...
7305 * systty.h: ... to here, so that they can be checked.
7307 * fns.c (get_random, seed_random): Move extern decls from here ...
7308 * lisp.h: ... to here, so that they can be checked.
7310 * sysdep.c (reset_io): Now static.
7311 (wait_for_termination_signal): Remove; unused.
7313 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7314 (copy_keymap_item, append_key, push_text_char_description):
7316 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7317 (DENSE_TABLE_SIZE): Remove; unused.
7318 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7319 (describe_map_tree):
7320 Rename locals to avoid shadowing.
7322 * keyboard.c: Declare functions static if they are not used elsewhere.
7323 (echo_char, echo_dash, cmd_error, top_level_2):
7324 (poll_for_input, handle_async_input): Now static.
7325 (read_char, kbd_buffer_get_event, make_lispy_position):
7326 (make_lispy_event, make_lispy_movement, apply_modifiers):
7327 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7328 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7329 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7330 (read_key_sequence, read_char): Mark locals as initialized.
7331 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7333 * keyboard.h (make_ctrl_char): New decl.
7334 (mark_kboards): Move decl here ...
7335 * alloc.c (mark_kboards): ... from here.
7337 * lisp.h (force_auto_save_soon): New decl.
7339 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7340 (DEFINE_DUMMY_FUNCTION): New macro.
7341 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7343 (main): Add casts to avoid warnings
7344 if GCC considers string literals to be constants.
7346 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7348 * dbusbind.c: Pointer signedness fixes.
7349 (xd_signature, xd_append_arg, xd_initialize):
7350 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7351 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7352 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7353 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7355 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7356 if GCC considers string literals to be constants.
7357 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7359 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7361 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7362 (print_preprocess, print_object): New macro to fix last change.
7364 * print.c (print_preprocess): Don't forget font objects.
7366 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7368 * emacs.c (USAGE3): Doc fixes.
7370 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7372 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7375 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7377 * lisp.h (VWindow_system, Qfile_name_history):
7378 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7379 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7380 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7382 * w32select.c: Don't #include "keyboard.h".
7383 (run_protected): Add extern declaration for waiting_for_input.
7385 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7386 * w32console.c (detect_input_pending, read_input_pending)
7387 (encode_terminal_code):
7388 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7389 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7390 (w32_system_caret_y, Qfile_name_history):
7391 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7392 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7393 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7394 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7395 * w32proc.c (Qlocal, report_file_error):
7396 * w32term.c (Vwindow_system, updating_frame):
7397 * w32uniscribe.c (initialized, uniscribe_font_driver):
7398 Remove unneeded extern declarations.
7400 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7402 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7404 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7406 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7407 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7408 These macros can no longer be used for assignment.
7410 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7411 Assign struct members directly, instead of using BUF_BEGV etc.
7412 (record_buffer_markers, fetch_buffer_markers): New functions for
7413 recording and fetching special buffer markers.
7414 (set_buffer_internal_1, set_buffer_temp): Use them.
7416 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7418 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7420 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7421 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7423 * xdisp.c (hscroll_window_tree):
7424 (reconsider_clip_changes): Use PT instead of BUF_PT.
7426 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7428 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7429 $(EMACS_ROOT)/lib/intprops.h.
7431 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7433 Fix more problems found by GCC 4.5.2's static checks.
7435 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7436 to unsigned char * to avoid compiler diagnostic.
7437 (xg_free_frame_widgets): Make it clear that a local variable is
7438 needed only if USE_GTK_TOOLTIP.
7439 (gdk_window_get_screen): Make it clear that this macro is needed
7440 only if USE_GTK_TOOLTIP.
7441 (int_gtk_range_get_value): New function, which avoids a diagnostic
7442 from gcc -Wbad-function-cast.
7443 (xg_set_toolkit_scroll_bar_thumb): Use it.
7444 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7445 diagnostic from gcc -Wbad-function-cast.
7446 (get_utf8_string, xg_get_file_with_chooser):
7447 Rename locals to avoid shadowing.
7448 (create_dialog): Move locals to avoid shadowing.
7450 * xgselect.c (xg_select): Remove unused var.
7452 * image.c (four_corners_best): Mark locals as initialized.
7453 (gif_load): Initialize transparent_p to zero (Bug#8238).
7454 Mark another local as initialized.
7455 (my_png_error, my_error_exit): Mark with NO_RETURN.
7457 * image.c (clear_image_cache): Now static.
7458 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7459 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7460 (x_edge_detection): Remove unnecessary cast that
7461 gcc -Wbad-function-cast diagnoses.
7462 (gif_load): Fix pointer signedness.
7463 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7464 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7466 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7468 Improve quality of tests for time stamp overflow.
7469 For example, without this patch (encode-time 0 0 0 1 1
7470 1152921504606846976) returns the obviously-bogus value (-948597
7471 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7472 reports time overflow. See
7473 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7474 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7475 * editfns.c: Include limits.h and intprops.h.
7476 (TIME_T_MIN, TIME_T_MAX): New macros.
7477 (time_overflow): Move earlier, to before first use.
7478 (hi_time, lo_time): New functions, for an accurate test for
7480 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7481 (Fget_internal_run_time): Don't assume time_t fits in int.
7482 (make_time): Use list2 instead of Fcons twice.
7483 (Fdecode_time): More accurate test for out-of-range times.
7484 (check_tm_member): New function.
7485 (Fencode_time): Use it, to test for out-of-range times.
7486 (lisp_time_argument): Don't rely on undefined left-shift and
7487 right-shift behavior when checking for time stamp overflow.
7489 * editfns.c (time_overflow): New function, refactoring common code.
7490 (Fformat_time_string, Fdecode_time, Fencode_time):
7491 (Fcurrent_time_string): Use it.
7493 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7494 * dired.c (make_time): Move to ...
7495 * editfns.c (make_time): ... here.
7496 * systime.h: Note the move.
7498 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7500 * fringe.c (update_window_fringes): Remove unused variables.
7502 * unexmacosx.c (copy_data_segment): Also copy __got section.
7505 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7507 * termcap.c [MSDOS]: Include "msdos.h".
7508 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7509 Constify `char *' arguments and their references according to
7510 prototypes in tparam.h.
7512 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7514 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7515 Adapt all references accordingly.
7517 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7519 2011-03-11 Tom Tromey <tromey@redhat.com>
7521 * buffer.c (syms_of_buffer): Remove obsolete comment.
7523 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7525 * termhooks.h (encode_terminal_code): Declare prototype.
7527 * msdos.c (encode_terminal_code): Don't declare prototype.
7529 * term.c (encode_terminal_code): Now external again, used by
7530 w32console.c and msdos.c.
7532 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7533 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7535 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7537 Fix some minor problems found by GCC 4.5.2's static checks.
7539 * fringe.c (update_window_fringes): Mark locals as initialized
7541 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7543 * alloc.c (mark_fringe_data): Move decl from here ...
7544 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7545 to check its interface.
7546 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7548 * fontset.c (free_realized_fontset): Now static.
7549 (Fset_fontset_font): Rename local to avoid shadowing.
7550 (fontset_font): Mark local as initialized.
7551 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7553 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7555 * xselect.c (x_disown_buffer_selections): Remove; not used.
7556 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7557 (x_own_selection, Fx_disown_selection_internal): Rename locals
7559 (x_handle_dnd_message): Remove local to avoid shadowing.
7561 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7562 so that the caller can use some name other than gcpro1.
7563 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7564 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7565 (Fx_backspace_delete_keys_p):
7566 Use them to avoid shadowing, and rename vars to avoid shadowing.
7567 (x_decode_color, x_set_name, x_window): Now static.
7568 (Fx_create_frame): Add braces to silence GCC warning.
7569 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7570 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7571 Remove unused locals.
7572 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7573 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7574 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7577 * xterm.h (x_mouse_leave): New decl.
7579 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7580 Remove unused functions.
7581 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7582 (x_calc_absolute_position): Now static.
7583 (XTread_socket): Don't define label "out" unless it's used.
7584 Don't declare local "event" unless it's used.
7585 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7586 unless they are used.
7587 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7588 (x_fatal_error_signal): Remove; not used.
7589 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7590 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7591 (x_error_catcher, x_connection_closed, x_error_handler):
7592 (x_error_quitter, xembed_send_message, x_iconify_frame):
7593 (my_log_handler): Rename locals to avoid shadowing.
7594 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7595 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7597 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7598 Rename or move locals to avoid shadowing.
7599 (tty_defined_color, merge_face_heights): Now static.
7600 (free_realized_faces_for_fontset): Remove; not used.
7601 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7602 does not deduce is never used uninitialized.
7603 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7604 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7606 * terminal.c (store_terminal_param): Now static.
7608 * xmenu.c (menu_highlight_callback): Now static.
7609 (set_frame_menubar): Remove unused local.
7610 (xmenu_show): Rename parameter to avoid shadowing.
7611 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7612 since they might point to immutable storage.
7613 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7614 since it's unused otherwise.
7616 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7617 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7618 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7619 avoids a gcc -Wuninitialized diagnostic.
7620 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7621 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7622 does not deduce are never used uninitialized.
7624 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7626 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7627 * window.c (window_loop, size_window):
7628 (run_window_configuration_change_hook, enlarge_window): Likewise.
7630 * window.c (display_buffer): Now static.
7631 (size_window): Mark variables that gcc -Wuninitialized
7632 does not deduce are never used uninitialized.
7633 * window.h (check_all_windows): New decl, to forestall
7634 gcc -Wmissing-prototypes diagnostic.
7635 * dispextern.h (bidi_dump_cached_states): Likewise.
7637 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7639 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7641 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7642 and to avoid gcc -Wuninitialized warning.
7643 (load_charset_map): Mark variables that gcc -Wuninitialized
7644 does not deduce are never used uninitialized.
7645 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7647 * coding.c (coding_set_source, coding_set_destination):
7648 Use "else { /* comment */ }" rather than "else /* comment */;"
7649 for clarity, and to avoid gcc -Wempty-body warning.
7650 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7651 a block, when the outer 'i' will do.
7652 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7653 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7654 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7655 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7656 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7657 Rename locals to avoid shadowing.
7658 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7659 * coding.c (emacs_mule_char, encode_invocation_designation):
7660 Now static, since they're not used elsewhere.
7661 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7662 (decode_coding_object, encode_coding_object, detect_coding_system):
7663 (decode_coding_emacs_mule): Mark variables that gcc
7664 -Wuninitialized does not deduce are never used uninitialized.
7665 (detect_coding_iso_2022): Initialize a local variable that might
7666 be used uninitialized. Leave a FIXME because it's not clear that
7667 this initialization is needed. (Bug#8211)
7668 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7669 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7670 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7671 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7672 Remove unused macros.
7674 * category.c (hash_get_category_set): Remove unused local var.
7675 (copy_category_table): Now static, since it's not used elsewhere.
7676 * character.c (string_count_byte8): Likewise.
7678 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7679 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7681 * chartab.c (copy_sub_char_table): Now static, since it's not used
7683 (sub_char_table_ref_and_range, char_table_ref_and_range):
7684 Rename locals to avoid shadowing.
7685 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7687 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7688 (BIDI_BOB): Remove unused macro.
7690 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7691 deduce are never used uninitialized.
7692 * term.c (encode_terminal_code): Likewise.
7694 * term.c (encode_terminal_code): Now static. Remove unused local.
7696 * tparam.h: New file.
7697 * term.c, tparam.h: Include it.
7698 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7699 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7700 Move these decls to tparam.h, and make them agree with what
7701 is actually in tparam.c. The previous trick of using incompatible
7702 decls in different modules does not conform to the C standard.
7703 All callers of tparam changed to use tparam's actual API.
7704 * tparam.c (tparam1, tparam, tgoto):
7705 Use const pointers where appropriate.
7707 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7708 * cm.h (struct cm): Likewise.
7709 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7710 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7711 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7712 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7713 (turn_on_face, init_tty): Likewise.
7714 * termchar.h (struct tty_display_info): Likewise.
7716 * term.c (term_mouse_position): Rename local to avoid shadowing.
7718 * alloc.c (mark_ttys): Move decl from here ...
7719 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7721 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7723 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7725 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7727 * search.c (compile_pattern_1): Remove argument regp, unused since
7728 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7729 (compile_pattern): Don't pass it.
7731 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7733 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7734 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7736 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7738 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7740 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7741 gdk_window_get_screen, gdk_window_get_geometry,
7742 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7743 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7744 (xg_get_pixbuf_from_pixmap): New function.
7745 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7746 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7747 Call xg_get_pixbuf_from_pixmap instead of
7748 gdk_pixbuf_get_from_drawable.
7749 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7750 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7751 (xg_check_special_colors): Use GtkStyleContext and its functions
7753 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7754 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7755 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7756 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7757 Call gtk_widget_get_preferred_size.
7758 (xg_frame_resized): gdk_window_get_geometry only takes 5
7760 (xg_win_to_widget, xg_event_is_for_menubar):
7761 Call gdk_x11_window_lookup_for_display.
7762 (xg_set_widget_bg): New function.
7763 (delete_cb): New function.
7764 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7765 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7766 (xg_set_background_color): Call xg_set_widget_bg.
7767 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7768 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7769 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7770 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7772 (update_frame_tool_bar): Call gtk_widget_hide.
7773 (xg_initialize): Use GDK_KEY_g.
7775 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7777 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7779 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7780 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7781 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7783 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7785 * w32xfns.c (select_palette): Check success of RealizePalette against
7786 GDI_ERROR, not zero.
7788 See ChangeLog.11 for earlier changes.
7794 Copyright (C) 2011 Free Software Foundation, Inc.
7796 This file is part of GNU Emacs.
7798 GNU Emacs is free software: you can redistribute it and/or modify
7799 it under the terms of the GNU General Public License as published by
7800 the Free Software Foundation, either version 3 of the License, or
7801 (at your option) any later version.
7803 GNU Emacs is distributed in the hope that it will be useful,
7804 but WITHOUT ANY WARRANTY; without even the implied warranty of
7805 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7806 GNU General Public License for more details.
7808 You should have received a copy of the GNU General Public License
7809 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.