src/xdisp.c (reseat_at_next_visible_line_start): Fix last change.
[bpt/emacs.git] / src / ChangeLog
1 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4
5 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6
7 Fix minor problem found by static checking.
8 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
9 initialized, to pacify gcc -Wuninitialized.
10
11 * fileio.c: Report proper errno when syscall falls.
12 (Finsert_file_contents): Save and restore errno,
13 so that report_file_error outputs the correct diagnostic.
14 (Fwrite_region) [CLASH_DETECTION]: Likewise.
15
16 2011-09-18 Eli Zaretskii <eliz@gnu.org>
17
18 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
19
20 2011-09-17 Eli Zaretskii <eliz@gnu.org>
21
22 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
23 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
24
25 2011-09-17 Eli Zaretskii <eliz@gnu.org>
26
27 * xdisp.c (reseat_at_next_visible_line_start): Keep information
28 about the current paragraph and restore it after the call to
29 reseat.
30
31 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
32 (bidi_find_paragraph_start): Search back for paragraph beginning
33 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
34 (bidi_move_to_visually_next): Only trigger paragraph-related
35 computations when the last character is a newline or at EOB, not
36 just any NEUTRAL_B. (Bug#9470)
37
38 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
39 truncated lines if point is covered by a display string. (Bug#9524)
40
41 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
42
43 * xselect.c: Relax test for outgoing X longs (Bug#9498).
44 (cons_to_x_long): New function.
45 (lisp_data_to_selection_data): Use it. Correct the test for
46 short-versus-long data; it was negated. Break out of vector
47 loop, for efficiency, when a long datum is discovered.
48
49 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
50
51 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
52
53 2011-09-16 Eli Zaretskii <eliz@gnu.org>
54
55 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
56 GCC PR/17406) by declaring this function with external scope.
57
58 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
59
60 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
61 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
62
63 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
64
65 * editfns.c (Fformat): Correctly handle text properties on "%%".
66
67 2011-09-15 Eli Zaretskii <eliz@gnu.org>
68
69 * xterm.c (x_draw_composite_glyph_string_foreground):
70 * w32term.c (x_draw_composite_glyph_string_foreground):
71 * term.c (encode_terminal_code):
72 * composite.c (composition_update_it, get_composition_id):
73 * xdisp.c (get_next_display_element)
74 (fill_composite_glyph_string): Add comments about special meaning
75 of TAB characters in a composition.
76
77 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
78
79 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
80 This occurs when processing a multibyte format.
81 Problem reported by Wolfgang Jenker.
82
83 2011-09-15 Johan Bockgård <bojohan@gnu.org>
84
85 * xdisp.c (try_cursor_movement): Only check for exact match if
86 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
87
88 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
89
90 Remove unused external symbols.
91 * dispextern.h (calc_pixel_width_or_height): Remove decl.
92 * xdisp.c (calc_pixel_width_or_height): Now static.
93 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
94 * indent.c (check_display_width):
95 * w32term.c: Fix comment to match code.
96 * xterm.c, xterm.h (x_catching_errors): Remove.
97
98 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
99
100 * xselect.c: Use signed conversions more consistently (Bug#9498).
101 (selection_data_to_lisp_data): Assume incoming selection data are
102 signed integers, not unsigned. This is to be consistent with
103 outgoing selection data, which was modified to use signed integers
104 in as part of the fix to Bug#9196 in response to Jan D.'s comment
105 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
106 expects long, not unsigned long.
107
108 2011-09-14 Eli Zaretskii <eliz@gnu.org>
109
110 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
111 computation of loop end. Reported by Johan Bockgård
112 <bojohan@gnu.org>.
113
114 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
115
116 * frame.c (Fother_visible_frames_p): Function deleted.
117
118 2011-09-12 Eli Zaretskii <eliz@gnu.org>
119
120 * indent.c (compute_motion): Process display vector front to back
121 rather than the other way around. (Bug#2496)
122
123 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
124
125 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
126
127 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
128
129 * minibuf.c (Fread_from_minibuffer): Doc fix.
130
131 2011-09-11 Eli Zaretskii <eliz@gnu.org>
132
133 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
134 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
135
136 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
137
138 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
139 value for non-existent files.
140
141 2011-09-11 Eli Zaretskii <eliz@gnu.org>
142
143 * fileio.c (Finsert_file_contents): If the file cannot be opened,
144 set its "size" to -1. This will set the modtime_size field of
145 the corresponding buffer to -1, which is what
146 verify-visited-file-modtime expects for files that do not exist.
147 (Bug#9139)
148
149 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
150
151 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
152 here ...
153 * lisp.h: ... from here. push_key_description is no longer
154 defined in keyboard.c, so its declaration should not be in
155 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
156 logically belongs with push_key_description.
157
158 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
159
160 * buffer.h: Include <sys/types.h> instead of <time.h>.
161 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
162 Problem reported by Herbert J. Skuhra.
163
164 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
165
166 * xml.c (parse_region): Make the parsing work for
167 non-comment-starting XML files again (bug#9144).
168
169 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
170
171 * image.c (gif_load): Fix calculation of bottom and right corner.
172 (Bug#9468)
173
174 2011-09-10 Eli Zaretskii <eliz@gnu.org>
175
176 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
177 redisplay in small windows.
178
179 2011-09-09 Eli Zaretskii <eliz@gnu.org>
180
181 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
182
183 2011-09-08 Martin Rudalics <rudalics@gmx.at>
184
185 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
186 Operate on live windows only.
187
188 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
189
190 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
191
192 2011-09-07 Eli Zaretskii <eliz@gnu.org>
193
194 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
195 only under bidi iteration.
196
197 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
198
199 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
200
201 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
202
203 isnan: Fix porting problem to Solaris 10 with bundled gcc.
204 Without this fix, the command to link temacs failed due to an
205 undefined symbol __builtin_isnan. This is because
206 /usr/include/iso/math_c99.h #defines isnan(x) to
207 __builtin_isnan(x), but the bundled gcc, which identifies itself
208 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
209 a __builtin_isnan.
210 * floatfns.c (isnan): #undef, and then #define to a clone of
211 what's in data.c.
212 (Fisnan): Always define, since it's always available now.
213 (syms_of_floatfns): Always define isnan at the Lisp level.
214
215 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
216
217 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
218
219 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
220
221 * fileio.c: Fix bugs with large file offsets (Bug#9428).
222 The previous code assumed that file offsets (off_t values) fit in
223 EMACS_INT variables, which is not true on typical 32-bit hosts.
224 The code messed up by falsely reporting buffer overflow in cases
225 such as (insert-file-contents "big" nil 1 2) into an empty buffer
226 when "big" contains more than 2**29 bytes, even though this
227 inserts just one byte and does not overflow the buffer.
228 (Finsert_file_contents): Store file offsets as off_t
229 values, not as EMACS_INT values. Check for overflow when
230 converting between EMACS_INT and off_t. When checking for
231 buffer overflow or for overlap, take the offsets into account.
232 Don't use EMACS_INT for small values where int suffices.
233 When checking for overlap, fix a typo: ZV was used where
234 ZV_BYTE was intended.
235 (Fwrite_region): Don't assume off_t fits into 'long'.
236 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
237
238 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
239
240 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
241
242 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
243
244 sprintf-related integer and memory overflow issues (Bug#9412).
245
246 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
247 (esprintf, exprintf, evxprintf): New functions.
248 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
249 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
250 (modify_event_symbol): Do not assume that the length of
251 name_alist_or_stem is safe to alloca and fits in int.
252 (Fexecute_extended_command): Likewise for function name and binding.
253 (Frecursion_depth): Wrap around reliably on integer overflow.
254 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
255 since some callers pass EMACS_INT values.
256 (Fsingle_key_description): Don't crash if symbol name contains more
257 than MAX_ALLOCA bytes.
258 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
259 (get_minibuffer): Arg is now EMACS_INT, not int.
260 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
261 (esprintf, exprintf, evxprintf): New decls.
262 * window.h (command_loop_level, minibuf_level): Reflect API changes.
263
264 * dbusbind.c (signature_cat): New function.
265 (xd_signature, Fdbus_register_signal):
266 Do not overrun buffer; instead, report string overflow.
267
268 * dispnew.c (add_window_display_history): Don't overrun buffer.
269 Truncate instead; this is OK since it's just a log.
270
271 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
272 even if the time zone offset is outlandishly large.
273 Don't mishandle offset == INT_MIN.
274
275 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
276 when creating daemon; the previous buffer-overflow check was incorrect.
277
278 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
279 which has the guts of the old verror function.
280
281 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
282 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
283
284 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
285 (font_unparse_xlfd): Don't blindly alloca long strings.
286 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
287 fits in int, when using sprintf. Use single snprintf to count
288 length of string rather than counting it via multiple sprintfs;
289 that's simpler and more reliable.
290 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
291 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
292 sprintf, in case result does not fit in int.
293
294 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
295 (fontset_from_font): Print it.
296
297 * frame.c (tty_frame_count): Now printmax_t, not int.
298 (make_terminal_frame, set_term_frame_name): Print it.
299 (x_report_frame_params): In X, window IDs are unsigned long,
300 not signed long, so print them as unsigned.
301 (validate_x_resource_name): Check for implausibly long names,
302 and don't assume name length fits in 'int'.
303 (x_get_resource_string): Don't blindly alloca invocation name;
304 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
305 not fit in int.
306
307 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
308 (xg_check_special_colors, xg_set_geometry):
309 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
310
311 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
312 Use esprintf, not sprintf, in case result does not fit in int.
313
314 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
315 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
316 it as a large positive number.
317 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
318 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
319
320 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
321 in case result does not fit in int.
322
323 * print.c (float_to_string): Detect width overflow more reliably.
324 (print_object): Make sprintf buffer a bit bigger, to avoid potential
325 buffer overrun. Don't assume list length fits in 'int'. Treat
326 print length of 0 as 0, not as infinity; to be consistent with other
327 uses of print length in this function. Don't overflow print length
328 index. Don't assume hash table size fits in 'long', or that
329 vectorlike size fits in 'unsigned long'.
330
331 * process.c (make_process): Use printmax_t, not int, to format
332 process-name gensyms.
333
334 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
335
336 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
337 to avoid potential buffer overrun.
338
339 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
340 if X resource line is longer than 512 bytes.
341
342 * xfns.c (x_window): Make sprintf buffer a bit bigger
343 to avoid potential buffer overrun.
344
345 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
346
347 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
348
349 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
350
351 Integer overflow fixes for scrolling, etc.
352 Without these, Emacs silently mishandles large integers sometimes.
353 For example, "C-u 4294967297 M-x recenter" was treated as if
354 it were "C-u 1 M-x recenter" on a typical 64-bit host.
355
356 * xdisp.c (try_window_id): Check Emacs fixnum range before
357 converting to 'int'.
358
359 * window.c (window_scroll_line_based, Frecenter):
360 Check that an Emacs fixnum is in range before assigning it to 'int'.
361 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
362 values converted from Emacs fixnums.
363 (Frecenter): Don't wrap around a line count if it is out of 'int'
364 range; instead, treat it as an extreme value.
365 (Fset_window_configuration, compare_window_configurations):
366 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
367
368 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
369 that can exceed INT_MAX. Check that EMACS_INT value is in range
370 before assigning it to the (possibly-narrower) index.
371 (match_limit): Don't assume that a fixnum can fit in 'int'.
372
373 * print.c (print_object): Use ptrdiff_t, not int, for index that can
374 exceed INT_MAX.
375
376 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
377 (Fvertical_motion): Don't wrap around LINES values that don't fit
378 in 'int'. Instead, treat them as extreme values. This is good
379 enough for windows, which can't have more than INT_MAX lines anyway.
380
381 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
382
383 * Require libxml/parser.h to avoid compilation warning.
384
385 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
386
387 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
388 since this reportedly can destroy thread storage.
389
390 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
391
392 * syntax.c (find_defun_start): Update all cache variables if
393 exiting early (Bug#9401).
394
395 2011-08-30 Eli Zaretskii <eliz@gnu.org>
396
397 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
398
399 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
400 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
401 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
402
403 * term.c (tty_append_glyph): New function.
404 (produce_stretch_glyph): Static function and its prototype deleted.
405
406 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
407 prototypes.
408
409 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
410
411 * image.c (parse_image_spec): Check for nonnegative, not for positive,
412 when checking :margin (Bug#9390).
413 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
414 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
415 so that the name doesn't mislead. All uses changed.
416
417 2011-08-28 Johan Bockgård <bojohan@gnu.org>
418
419 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
420 set_tty_hooks.
421
422 2011-08-27 Eli Zaretskii <eliz@gnu.org>
423
424 * xdisp.c (move_it_to): Don't bail out early when reaching
425 position beyond to_charpos, if we are scanning backwards.
426 (move_it_vertically_backward): When DY == 0, make sure we get to
427 the first character in the line after the newline.
428
429 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
430
431 * ccl.c: Improve and simplify overflow checking (Bug#9196).
432 (ccl_driver): Do not generate an out-of-range pointer.
433 (Fccl_execute_on_string): Remove unnecessary check for
434 integer overflow, noted by Stefan Monnier in
435 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
436 Remove a FIXME that didn't need fixing.
437 Simplify the newly-introduced buffer reallocation code.
438
439 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
440
441 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
442
443 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
444
445 Integer and memory overflow issues (Bug#9196).
446
447 * doc.c (get_doc_string): Rework so that
448 get_doc_string_buffer_size is the actual buffer size, rather than
449 being 1 less than the actual buffer size; this makes xpalloc more
450 convenient.
451
452 * image.c (x_allocate_bitmap_record, cache_image):
453 * xselect.c (Fx_register_dnd_atom):
454 Simplify previous changes by using xpalloc.
455
456 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
457 since either will do and ptrdiff_t is convenient with xpalloc.
458
459 * charset.c (charset_table_size)
460 (struct charset_sort_data.priority): Now ptrdiff_t.
461 (charset_compare): Don't overflow if priorities differ greatly.
462 (Fsort_charsets): Don't assume list length fits in int.
463 Check for size-calculation overflow when allocating sort data.
464 (syms_of_charset): Allocate an initial charset table that is
465 just under 64 KiB, to avoid problems with glibc malloc and mmap.
466
467 * cmds.c (internal_self_insert): Check for size-calculation overflow.
468
469 * composite.h (struct composition.glyph_len): Now int, not unsigned.
470 The actual value is always <= INT_MAX, and leaving it unsigned made
471 overflow checking harder.
472
473 * dispextern.h (struct glyph_matrix.rows_allocated)
474 (struct face_cache.size): Now ptrdiff_t, for convenience in use
475 with xpalloc. The values are still always <= INT_MAX.
476
477 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
478
479 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
480 (SAFE_NALLOCA): New macro.
481
482 * region-cache.c (struct boundary.pos, find_cache_boundary)
483 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
484 (set_cache_region, invalidate_region_cache)
485 (revalidate_region_cache, know_region_cache, region_cache_forward)
486 (region_cache_backward, pp_cache):
487 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
488 so that ptrdiff_t * can be passed to xpalloc.
489 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
490 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
491 (pp_cache): Don't assume cache_len fits in int.
492 * region-cache.h: Adjust extern decls to match.
493
494 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
495 EMACS_INT, since either will do, for xpalloc.
496
497 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
498 (xnmalloc, xnrealloc, xpalloc): New functions.
499
500 * bidi.c (bidi_shelve_header_size): New constant.
501 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
502 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
503
504 * bidi.c (bidi_cache_shrink):
505 * buffer.c (overlays_at, overlays_in, record_overlay_string)
506 (overlay_strings):
507 Don't update size of array until after memory allocation succeeds,
508 because xmalloc/xrealloc may not return.
509 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
510 now that we have proper integer overflow checking.
511 (record_overlay_string, overlay_strings): Catch overflows when
512 calculating size of overlay_str_buf.
513
514 * callproc.c (Fcall_process): Check for size overflow when
515 calculating size of args2.
516 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
517 Normally we prefer signed values, but sticking with ptrdiff_t would
518 require adding more-complicated checks.
519
520 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
521 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
522 Redo buffer-overflow calculations to avoid integer overflow.
523 Add a FIXME comment where memory seems to be over-allocated.
524
525 * character.c (Fstring): Check for size-calculation overflow.
526
527 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
528 unnecessary integer overflow. Check for size overflow.
529 (encode_coding_object): Don't update size until xmalloc succeeds.
530
531 * composite.c (get_composition_id): Check for overflow in glyph
532 length calculations.
533
534 Integer and memory overflow fixes for display code.
535 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
536 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
537 (scrolling_window): Check for overflow in size calculations.
538 (line_draw_cost, realloc_glyph_pool, add_row_entry):
539 Don't assume glyph table len fits in int.
540 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
541 (row_table_size): Now ptrdiff_t, not int.
542 (scrolling_window): Avoid overflow in size calculations.
543 Don't update size until allocation succeeds.
544 * fns.c (concat): Check for overflow in size calculations.
545 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
546 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
547 (NEXT_ALMOST_PRIME_LIMIT): New constant.
548
549 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
550 (get_doc_string): Check for size calculation overflow.
551 Don't update size until allocation succeeds.
552 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
553 EMACS_INT, where ptrdiff_t will do.
554 (Fsubstitute_command_keys): Check for string overflow.
555
556 * editfns.c (set_time_zone_rule): Don't assume environment length
557 fits in int.
558 (message_length): Now ptrdiff_t, not int.
559 (Fmessage_box): Don't update size until allocation succeeds.
560 Don't assume message length fits in int.
561 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
562
563 * emacs.c (main): Do not reallocate argv, since there is a null at
564 the end that can be overwritten, and this way there's no need to
565 worry about size-calculation overflow.
566 (sort_args): Check for size-calculation overflow.
567
568 * eval.c (init_eval_once, grow_specpdl): Don't update size until
569 alloc succeeds.
570 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
571
572 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
573 (x_set_scroll_bar_width, x_figure_window_size):
574 Check for integer overflow.
575 (x_set_alpha): Do not assume XINT fits in int.
576
577 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
578 This is for the members text_lines, text_cols, total_lines, total_cols,
579 where the system imposes an 'int' limit.
580
581 * fringe.c (Fdefine_fringe_bitmap):
582 Don't update size until alloc works.
583
584 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
585 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
586
587 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
588 Check for size-calculation overflow.
589 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
590 do, as we prefer signed integers.
591 (id_to_widget.max_size, id_to_widget.used)
592 (xg_store_widget_in_map, xg_remove_widget_from_map)
593 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
594 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
595 Use and return ptrdiff_t, not int.
596 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
597 * gtkutil.h: Change prototypes to match the above.
598
599 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
600 are duplicate now that they've been promoted to lisp.h.
601 (x_allocate_bitmap_record, x_alloc_image_color)
602 (make_image_cache, cache_image, xpm_load):
603 Don't update size until alloc is done.
604 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
605 (x_detect_edges):
606 Check for size calculation overflow.
607 (ct_colors_allocated_max): New constant.
608 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
609 overflow.
610
611 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
612 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
613 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
614 Use ptrdiff_t, not int, to count maps.
615 (read_char_minibuf_menu_prompt): Check for overflow in size
616 calculations. Don't update size until allocation succeeds. Redo
617 calculations to avoid overflow.
618 * keyboard.h: Change prototypes to match the above.
619
620 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
621 to count maps.
622 (current_minor_maps): Check for size calculation overflow.
623 * keymap.h: Change prototypes to match the above.
624
625 * lread.c (read1, init_obarray): Don't update size until alloc done.
626
627 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
628 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
629
630 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
631 Now ptrdiff_t, not int.
632 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
633 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
634
635 * process.c (Fnetwork_interface_list): Check for overflow
636 in size calculation.
637
638 * region-cache.c (move_cache_gap): Check for size calculation overflow.
639
640 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
641 overflow. Don't bother calling xmalloc when xrealloc will do.
642
643 * search.c (Freplace_match): Check for size calculation overflow.
644 (Fset_match_data): Don't assume list lengths fit in 'int'.
645
646 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
647 for command line length. Do not attempt to address one before the
648 beginning of an array, as that's not portable.
649
650 * term.c (max_frame_lines): Remove; unused.
651 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
652 not int.
653 (encode_terminal_code, calculate_costs): Check for size
654 calculation overflow.
655 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
656 table lengths and related sizes. Don't update size until alloc
657 done. Redo calculations to avoid overflow.
658 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
659
660 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
661 subtracting pointers.
662 (gobble_line): Check for overflow more carefully. Don't update size
663 until alloc done.
664
665 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
666 Don't update size until alloc done.
667 Redo size calculations to avoid overflow.
668 Check for size calculation overflow.
669 (main) [DEBUG]: Fix typo in invoking tparam1.
670
671 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
672 Use ptrdiff_t, not int, for sizes.
673 (store_mode_line_noprop_char): Don't update size until alloc done.
674
675 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
676 Use ptrdiff_t, not int, for sizes.
677 (Finternal_make_lisp_face, cache_face):
678 Check for size calculation overflow.
679 (cache_face): Treat size calculation overflows as if they were
680 memory exhaustion (the usual treatment), rather than aborting.
681
682 * xfns.c (x_encode_text, x_set_name_internal)
683 (Fx_change_window_property): Use ptrdiff_t, not int, to count
684 sizes, since they can exceed INT_MAX in size. Check for size
685 calculation overflow.
686
687 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
688 (xg_select): Check for size calculation overflow.
689 Don't update size until alloc done.
690
691 * xrdb.c (get_environ_db): Don't assume path length fits in int,
692 as sprintf is limited to int lengths.
693
694 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
695 (X_LONG_MIN): New macros.
696 Use them to make the following changes clearer.
697 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
698 This change doesn't affect the value now, but it may help remind
699 future maintainers not to raise the value too much later.
700 (SELECTION_QUANTUM): Remove, replacing with ...
701 (selection_quantum): ... new function, which avoids overflow.
702 All uses changed.
703 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
704 assumption that selection length fits in 'int'.
705 (x_reply_selection_request, x_handle_selection_request)
706 (x_get_window_property, receive_incremental_selection)
707 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
708 (lisp_data_to_selection_data, clean_local_selection_data):
709 Use ptrdiff_t, not int, to record length of selection.
710 (x_reply_selection_request, x_get_window_property)
711 (receive_incremental_selection, x_property_data_to_lisp):
712 Redo calculations to avoid overflow.
713 (x_reply_selection_request): When sending hint, ceiling it at
714 X_LONG_MAX rather than relying on wraparound overflow to send
715 something.
716 (x_get_window_property, receive_incremental_selection)
717 (lisp_data_to_selection_data, x_property_data_to_lisp):
718 Check for size-calculation overflow.
719 (x_get_window_property, receive_incremental_selection)
720 (lisp_data_to_selection_data, Fx_register_dnd_atom):
721 Don't store size until memory allocation succeeds.
722 (x_get_window_property): Plug memory leak on memory exhaustion.
723 Don't double-block input; malloc is safe here. Don't assume 2**34
724 - 4 fits in unsigned long. Add an xassert to check
725 XGetWindowProperty overflow. Be more careful about overflow
726 calculations, and distinguish size from memory overflow better.
727 (receive_incremental_selection): When tracing, don't assume
728 unsigned int is less than INT_MAX.
729 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
730 harmful) conversions of unsigned short to int.
731 (lisp_data_to_selection_data): Don't assume that integers
732 in the range -65535 through -1 fit in an X unsigned short.
733 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
734 result parameters unless successful. Rely on cons_to_unsigned
735 to report problems with elements; the old code wasn't right anyway.
736 (x_check_property_data): Check for int overflow; we cannot use
737 a wider type due to X limits.
738 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
739
740 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
741
742 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
743 (x_term_init): Check for size calculation overflow.
744 (x_color_cells): Don't store size until memory allocation succeeds.
745 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
746 Don't assume alloca size is less than MAX_ALLOCA.
747 (x_term_init): Don't assume length fits in int (sprintf is limited
748 to int size).
749
750 Use ptrdiff_t for composition IDs.
751 * character.c (lisp_string_width):
752 * composite.c (composition_table_size, n_compositions)
753 (get_composition_id, composition_gstring_from_id):
754 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
755 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
756 * window.c (Frecenter):
757 Use ptrdiff_t, not int, for composition IDs.
758 * composite.c (get_composition_id): Check for integer overflow.
759 * composite.h: Adjust prototypes to match the above changes.
760
761 Use ptrdiff_t for hash table indexes.
762 * category.c (hash_get_category_set):
763 * ccl.c (ccl_driver):
764 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
765 * coding.c (coding_system_charset_list, detect_coding_system):
766 * coding.h (struct coding_system.id):
767 * composite.c (get_composition_id, gstring_lookup_cache):
768 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
769 * image.c (xpm_get_color_table_h):
770 * lisp.h (hash_lookup, hash_put):
771 * minibuf.c (Ftest_completion):
772 Use ptrdiff_t for hash table indexes, not int (which is too
773 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
774 32-bit --with-wide-int hosts).
775
776 * charset.c (Fdefine_charset_internal): Check for integer overflow.
777 Add a FIXME comment about memory leaks.
778 (syms_of_charset): Don't assume xmalloc returns.
779
780 Don't assume that stated character widths fit in int.
781 * character.c (Fchar_width, c_string_width, lisp_string_width):
782 * character.h (CHAR_WIDTH):
783 * indent.c (MULTIBYTE_BYTES_WIDTH):
784 Use sanitize_char_width to avoid undefined and/or bad behavior
785 with outlandish widths.
786 * character.h (sanitize_tab_width): Renamed from sanitize_width,
787 now that we have two such functions. All uses changed.
788 (sanitize_char_width): New inline function.
789
790 Don't assume that tab-width fits in int.
791 * character.h (sanitize_width): New inline function.
792 (SANE_TAB_WIDTH): New macro.
793 (ASCII_CHAR_WIDTH): Use it.
794 * indent.c (sane_tab_width): Remove. All uses replaced by
795 SANE_TAB_WIDTH (current_buffer).
796 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
797
798 * fileio.c: Integer overflow issues with file modes.
799 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
800
801 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
802 Remove unreachable code.
803 (read_hex, load_charset_map_from_file): Check for integer overflow.
804
805 * xterm.c: don't go over XClientMessageEvent limit
806 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
807 (x_send_scroll_bar_event): Likewise. Check that the size does not
808 exceed limits imposed by XClientMessageEvent, as well as the usual
809 ptrdiff_t and size_t limits.
810
811 * keyboard.c: Overflow, signedness and related fixes.
812 (make_lispy_movement): Use same integer type in forward decl
813 that is used in the definition.
814 (read_key_sequence, keyremap_step):
815 Change bufsize argument back to int, undoing my 2011-03-30 change.
816 We prefer signed types, and int is wide enough here.
817 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
818 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
819 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
820 length, not size_t. Use ptrdiff_t for index, not int.
821 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
822 possibility of integer overflow.
823
824 Overflow, signedness and related fixes for images.
825
826 * dispextern.h (struct it.stack[0].u.image.image_id)
827 (struct_it.image_id, struct image.id, struct image_cache.size)
828 (struct image_cache.used, struct image_cache.ref_count):
829 * gtkutil.c (update_frame_tool_bar):
830 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
831 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
832 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
833 * nsmenu.m (update_frame_tool_bar):
834 * xdisp.c (calc_pixel_width_or_height):
835 * xfns.c (image_cache_refcount):
836 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
837 on typical 64-bit hosts.
838
839 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
840 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
841 Omit unnecessary casts to int.
842 (parse_image_spec): Check that integers fall into 'int' range
843 when the callers expect that.
844 (image_ascent): Redo ascent calculation to avoid int overflow.
845 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
846 (lookup_image): Remove unnecessary tests.
847 (xbm_image_p): Locals are now of int, not EMACS_INT,
848 since parse_image_check makes sure they fit into int.
849 (png_load, gif_load, svg_load_image):
850 Prefer int to unsigned where either will do.
851 (tiff_handler): New function, combining the cores of the
852 old tiff_error_handler and tiff_warning_handler. This
853 function is rewritten to use vsnprintf and thereby avoid
854 stack buffer overflows. It uses only the features of vsnprintf
855 that are common to both POSIX and native Microsoft.
856 (tiff_error_handler, tiff_warning_handler): Use it.
857 (tiff_load, gif_load, imagemagick_load_image):
858 Don't assume :index value fits in 'int'.
859 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
860 (imagemagick_load_image): Check that crop parameters fit into
861 the integer types that MagickCropImage accepts. Don't assume
862 Vimagemagick_render_type has a nonnegative value. Don't assume
863 size_t fits in 'long'.
864 (gs_load): Use printmax_t to print the widest integers possible.
865 Check for integer overflow when computing image height and width.
866
867 2011-08-26 Eli Zaretskii <eliz@gnu.org>
868
869 * xdisp.c (redisplay_window): Don't force window start if point
870 will be invisible in the resulting window. (Bug#9324)
871
872 2011-08-25 Eli Zaretskii <eliz@gnu.org>
873
874 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
875 the display spec is of the form `(space ...)'.
876 (handle_display_spec): Return the value returned by
877 handle_single_display_spec, not just 1 or zero.
878 (handle_single_display_spec): If the display spec is of the form
879 `(space ...)', and specifies display in the text area, return 2
880 rather than 1.
881 (try_cursor_movement): Check for the need to scroll more
882 accurately, and prefer exact match for point under bidi. Don't
883 advance `row' beyond the last row of the window.
884
885 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
886 into disp_prop; all users changed.
887
888 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
889 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
890 for the text covered by the display property.
891
892 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
893
894 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
895 Change return value to nil.
896 (Frecord_buffer): Delete unused function.
897
898 2011-08-24 Eli Zaretskii <eliz@gnu.org>
899
900 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
901 buffers, return left-to-right.
902 (set_cursor_from_row): Consider candidate row a win if its glyph
903 represents a newline and point is on that newline. Fixes cursor
904 positioning on the newline at EOL of R2L text within L2R
905 paragraph, and vice versa.
906 (try_cursor_movement): Check continued rows, in addition to
907 continuation rows. Fixes unwarranted scroll when point enters a
908 continued line of R2L text within an L2R paragraph, or vice versa.
909 (cursor_row_p): Consider the case of point being equal to
910 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
911 from the end of a short line to the beginning of a continued line
912 of R2L text within L2R paragraph.
913 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
914 composed characters.
915
916 * bidi.c (bidi_check_type): Use xassert.
917 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
918 members.
919
920 2011-08-23 Eli Zaretskii <eliz@gnu.org>
921
922 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
923 a character.
924
925 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
926
927 * nsfont.m (ns_otf_to_script): Fix typo.
928
929 2011-08-22 Kenichi Handa <handa@m17n.org>
930
931 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
932 extra slot even if the purpose is char-code-property-table.
933
934 2011-08-23 Eli Zaretskii <eliz@gnu.org>
935
936 * xdisp.c (redisplay_window): When computing centering_position,
937 account for the height of the header line. (Bug#8874)
938
939 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
940 instead of CHAR_TO_BYTE. Fixes a crash when a completion
941 candidate is selected by the mouse, and that candidate has a
942 composed character under the mouse.
943
944 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
945 coordinates reported by pos-visible-in-window-p for a composed
946 character in column zero.
947
948 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
949
950 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
951
952 2011-08-22 Eli Zaretskii <eliz@gnu.org>
953
954 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
955 consider it a hit if to_charpos is anywhere in the range of the
956 composed buffer positions.
957
958 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
959
960 * image.c (gif_load): Don't assume that each subimage has the same
961 dimensions as the base image. Handle disposal method that is
962 "undefined" by the gif spec (Bug#9335).
963
964 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
965
966 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
967 (Fcondition_case): Document `debug' symbol in error handler.
968
969 2011-08-19 Eli Zaretskii <eliz@gnu.org>
970
971 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
972 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
973 from an Org mode buffer to a Speedbar frame.
974
975 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
976 a composition, take its buffer position from IT->cmp_it.charpos.
977 Fixes cursor positioning at the beginning of a line that begins
978 with a composed character.
979
980 2011-08-18 Eli Zaretskii <eliz@gnu.org>
981
982 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
983 character bidirectional type, use STRONG_L instead. Fixes crashes
984 in a buffer produced by `describe-categories'.
985
986 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
987 members before the level stack, so they would be saved and
988 restored when copying iterator state. Fixes incorrect reordering
989 around TABs covered by display properties.
990
991 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
992
993 * process.c (Fnetwork_interface_list): Correctly determine buffer
994 size.
995
996 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
997
998 * eval.c (internal_condition_case, internal_condition_case_1)
999 (internal_condition_case_2, internal_condition_case_n):
1000 Remove unnecessary aborts (Bug#9081).
1001
1002 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1003
1004 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1005 has no `load' handler, try opening the file locally. (Bug#9311)
1006
1007 2011-08-16 Ken Brown <kbrown@cornell.edu>
1008
1009 * gmalloc.c: Expand comment.
1010
1011 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1012
1013 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1014 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1015
1016 2011-08-16 Ken Brown <kbrown@cornell.edu>
1017
1018 Fix memory allocation problems in Cygwin build (Bug#9273).
1019
1020 * unexcw.c ( __malloc_initialized): Declare external variable.
1021 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1022
1023 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1024 New variables.
1025 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1026 dumped emacs.
1027 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1028 in the static heap.
1029 [CYGWIN] (special_realloc): New function.
1030 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1031 requests to realloc storage in the static heap.
1032
1033 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1034
1035 * bidi.c (bidi_initialize): Remove unused local.
1036
1037 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1038
1039 * biditype.h: File removed.
1040
1041 * bidimirror.h: File removed.
1042
1043 * deps.mk (bidi.o): Remove biditype.h and
1044 bidimirror.h.
1045
1046 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1047 bidimirror.h.
1048
1049 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1050
1051 * chartab.c: Improve commentary for the uniprop_table API.
1052
1053 * bidi.c (bidi_paragraph_init): Support zero value of
1054 bidi_ignore_explicit_marks_for_paragraph_level.
1055 (bidi_initialize): Use uniprop_table instead of including
1056 biditype.h and bidimirror.h.
1057
1058 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1059 coordinates of the iterator when restoring from ppos_it.
1060 (Bug#9296)
1061
1062 2011-08-14 Kenichi Handa <handa@m17n.org>
1063
1064 * process.c (create_process): Call setup_process_coding_systems
1065 after the pid of the process is set to -1 (Bug#8162).
1066
1067 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1068
1069 * xdisp.c (move_it_in_display_line_to): Don't invoke
1070 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1071 ppos_it. Fixes vertical cursor motion when line beginning is
1072 covered by an image. (Bug#9296)
1073
1074 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1075
1076 * nsterm.h (ns_run_ascript): Declare.
1077 (NSAPP_DATA2_RUNASSCRIPT): Define.
1078
1079 * nsfns.m (as_script, as_result, as_status): New static variables.
1080 (ns_run_ascript): New function.
1081 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1082 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1083 the event loop. Get status from as_status (Bug#7276).
1084
1085 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1086 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1087 the event loop (Bug#7276).
1088
1089 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1090
1091 * gnutls.c (QCgnutls_bootprop_priority)
1092 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1093 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1094 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1095 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1096 (QCgnutls_bootprop_verify_hostname_error)
1097 (QCgnutls_bootprop_callbacks_verify): Rename from
1098 Qgnutls_bootprop_..., all uses changed.
1099
1100 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1101 uses changed.
1102
1103 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1104
1105 * xfaces.c (Qframe_set_background_mode): Now static.
1106 * dispextern.h (Qframe_set_background_mode): Remove decl.
1107
1108 * process.c (Fnetwork_interface_info): Declare local only if needed.
1109
1110 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1111
1112 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1113 (Fnetwork_interface_list): Allocate in increments of bytes instead
1114 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1115 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1116 sockaddr.
1117 (struct ifflag_def): notrailers is smart on OSX.
1118 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1119 Get hardware address with getifaddrs if available.
1120
1121 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1122
1123 * xdisp.c (iterate_out_of_display_property): xassert that
1124 IT->position is set to within IT->object's boundaries. Break from
1125 the loop as soon as EOB is reached; avoids infloops in redisplay
1126 when IT->position is set up wrongly due to some bug.
1127 Set IT->current to match the bidi iterator unconditionally.
1128 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1129 entry. Force push_it to save on the stack the current
1130 buffer/string position, to be restored by pop_it. Fix flags in
1131 the iterator structure wrt the object coming from a display
1132 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1133 properties. (Bug#9284)
1134
1135 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1136
1137 * fontset.c (fontset_get_font_group): Add proper type checks.
1138 (Bug#9172)
1139
1140 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1141
1142 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1143 and LC_VERSION_MIN_MACOSX.
1144 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1145 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1146
1147 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1148
1149 * xdisp.c (forward_to_next_line_start): Allow to use the
1150 no-display-properties-and-no-overlays under bidi display.
1151 Set disp_pos in the bidi iterator to avoid searches for display
1152 properties and overlays.
1153
1154 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1155
1156 * editfns.c (Fset_time_zone_rule): Document relationship with the
1157 setenv function.
1158
1159 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1160 the font entity extracted from the cache (Bug#8109).
1161
1162 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1163
1164 * composite.c (autocmp_chars): Don't reset point. That is done by
1165 restore_point_unwind (Bug#5984).
1166
1167 2011-08-07 Juri Linkov <juri@jurta.org>
1168
1169 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1170 to show the arg `TIME' instead of `TIMEVAL'.
1171
1172 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1173
1174 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1175 display property strides EOL and includes a newline, as in
1176 longlines-mode. (Bug#9254)
1177 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1178 word-wrap under bidirectional display. (Bug#9224)
1179
1180 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1181 is non-zero, even if the data buffer is NULL. Fixes a crash in
1182 vertical-motion with longlines-mode. (Bug#9254)
1183
1184 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1185
1186 * bidi.c <bidi_cache_total_alloc>: Now static.
1187 (bidi_initialize): Initialize bidi_cache_total_alloc.
1188
1189 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1190 cache. (Bug#9221)
1191
1192 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1193 amount allocated this far in `bidi_cache_total_alloc'.
1194 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1195 non-zero, only free the data buffer without restoring the cache
1196 contents. All callers changed.
1197
1198 * dispextern.h (bidi_unshelve_cache): Update prototype.
1199
1200 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1201 (move_it_in_display_line, move_it_to)
1202 (move_it_vertically_backward, move_it_by_lines): Replace the call
1203 to xfree to an equivalent call to bidi_unshelve_cache.
1204 (move_it_in_display_line_to): Fix logic of returning
1205 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1206
1207 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1208
1209 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1210 came from a string character with a `cursor' property. (Bug#9229)
1211
1212 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1213
1214 * Makefile.in (LIB_PTHREAD): New variable.
1215 (LIBES): Add LIB_PTHREAD (Bug#9216).
1216
1217 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1218 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1219
1220 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1221
1222 * regex.c (re_iswctype): Remove some redundant boolean
1223 conversions.
1224
1225 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1226
1227 * xterm.c (x_find_topmost_parent): New function.
1228 (x_set_frame_alpha): Find topmost parent window with
1229 x_find_topmost_parent and set the property there also (bug#9181).
1230 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1231
1232 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1233
1234 * callproc.c (Fcall_process): Avoid vfork clobbering
1235 the local vars buffer, coding_systems, current_dir.
1236
1237 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1238
1239 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1240
1241 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1242
1243 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1244 so that it is not optimized away.
1245
1246 * xdisp.c (compute_display_string_pos): Remove unused local.
1247
1248 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1249
1250 Fix slow cursor motion and scrolling in large buffers with
1251 selective display, like Org Mode buffers. (Bug#9218)
1252
1253 * dispextern.h (struct bidi_it): New member disp_prop_p.
1254
1255 * xdisp.c: Remove one-slot cache of display string positions.
1256 (compute_display_string_pos): Accept an additional argument
1257 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1258 for a display string or property. If found, set DISP_PROP_P
1259 non-zero.
1260
1261 * bidi.c (bidi_fetch_char): Accept an additional argument
1262 DISP_PROP_P, and pass it to compute_display_string_pos.
1263 Only handle text covered by a display string if DISP_PROP_P is returned
1264 non-zero. All callers of bidi_fetch_char changed.
1265
1266 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1267
1268 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1269
1270 2010-12-03 Don March <don@ohspite.net>
1271
1272 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1273 last character M-[char] is translated to ESC [char] (bug#7541).
1274
1275 2011-08-02 Kenichi Handa <handa@m17n.org>
1276
1277 * lisp.h (uniprop_table): Extern it.
1278
1279 * chartab.c (uniprop_table): Make it non-static.
1280
1281 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1282
1283 * xdisp.c (forward_to_next_line_start): Accept additional argument
1284 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1285 on the newline.
1286 (reseat_at_next_visible_line_start): Use the bidi iterator state
1287 returned by forward_to_next_line_start to restore the state of
1288 it->bidi_it after backing up to previous newline. (Bug#9212)
1289
1290 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1291
1292 * regex.c (re_comp): Protoize.
1293 (re_exec): Fix return type.
1294 (regexec): Fix type of `ret'. (Bug#9203)
1295
1296 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1297
1298 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1299 This is needed if max-image-size is a floating-point number.
1300
1301 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1302
1303 * print.c (print_object): Print empty symbol as ##.
1304
1305 * lread.c (read1): Read ## as empty symbol.
1306
1307 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1308
1309 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1310 setting frame foreground color (Bug#9175).
1311 (x_set_background_color): Likewise.
1312
1313 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1314 contents (Bug#9176).
1315 (EmacsTooltip -init): Remove bezels and add shadows to
1316 tooltip windows.
1317
1318 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1319 or scroll bar (Bug#8470).
1320
1321 * nsfont.m (nsfont_open): Remove assignment to voffset and
1322 unnecessary vars hshink, expand, hd, full_height, min_height.
1323 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1324
1325 * nsterm.h (nsfont_info): Remove voffset field.
1326
1327 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1328
1329 Implement strike-through and overline on NextStep (Bug#8863).
1330
1331 * nsfont.m (nsfont_open): Use underline position provided by font,
1332 instead of hard-coded value of 2.
1333 (nsfont_draw): Call ns_draw_text_decoration instead.
1334
1335 * nsterm.h: Add declaration for ns_draw_text_decoration.
1336
1337 * nsterm.m (ns_draw_text_decoration): New function for drawing
1338 underline, overline, and strike-through.
1339 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1340 ns_draw_text_decoration. Change treatment of cursor drawing to
1341 accommodate underlining, etc.
1342
1343 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1344
1345 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1346 default.
1347
1348 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1349
1350 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1351 Without this fix, if a signal arrives just after memory fills up,
1352 'malloc' might be invoked reentrantly.
1353
1354 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1355 In other words, assume that every image size is allowed, on non-X
1356 hosts. This assumption is probably wrong, but it lets Emacs compile.
1357
1358 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1359
1360 * regex.c (re_iswctype): Convert return values to boolean.
1361
1362 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1363
1364 * xdisp.c (compute_display_string_pos): Don't use cached display
1365 string position if the buffer had its restriction changed.
1366 (Bug#9184)
1367
1368 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1369
1370 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1371
1372 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1373
1374 Integer signedness and overflow and related fixes. (Bug#9079)
1375
1376 * bidi.c: Integer size and overflow fixes.
1377 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1378 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1379 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1380 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1381 (bidi_find_other_level_edge):
1382 Use ptrdiff_t instead of EMACS_INT where either will do.
1383 This works better on 32-bit hosts configured --with-wide-int.
1384 (bidi_cache_ensure_space): Check for size-calculation overflow.
1385 Use % rather than repeated addition, for better worst-case speed.
1386 Don't set bidi_cache_size until after xrealloc returns, because it
1387 might not return.
1388 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1389 (bidi_cache_ensure_space): Also check that the bidi cache size
1390 does not exceed that of the largest Lisp string or buffer. See Eli
1391 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1392
1393 * alloc.c (__malloc_size_t): Remove.
1394 All uses replaced by size_t. See Andreas Schwab's note
1395 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1396
1397 * image.c: Improve checking for integer overflow.
1398 (check_image_size): Assume that f is nonnull, since
1399 it is always nonnull in practice. This is one less thing to
1400 worry about when checking for integer overflow later.
1401 (x_check_image_size): New function, which checks for integer
1402 overflow issues inside X.
1403 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1404 This removes the need for a memory_full check.
1405 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1406 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1407 (xbm_read_bitmap_data): Change locals back to 'int', since
1408 their values must fit in 'int'.
1409 (xpm_load_image, png_load, tiff_load):
1410 Invoke x_create_x_image_and_pixmap earlier,
1411 to avoid much needless work if the image is too large.
1412 (tiff_load): Treat overly large images as if
1413 x_create_x_image_and_pixmap failed, not as malloc failures.
1414 (gs_load): Use x_check_image_size.
1415
1416 * gtkutil.c: Omit integer casts.
1417 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1418 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1419
1420 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1421
1422 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1423 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1424 would wrongly return t on a 64-bit host.
1425
1426 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1427 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1428 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1429 and therefore cause GCC to emit a bogus diagnostic in some cases.
1430
1431 * image.c: Integer signedness and overflow and related fixes.
1432 This is not an exhaustive set of fixes, but it's time to
1433 record what I've got.
1434 (lookup_pixel_color, check_image_size): Remove redundant decls.
1435 (check_image_size): Don't assume that arbitrary EMACS_INT values
1436 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1437 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1438 (tiff_load, imagemagick_load_image):
1439 Check for overflow in size calculations.
1440 (x_create_x_image_and_pixmap): Remove unnecessary test for
1441 xmalloc returning NULL; that can't happen.
1442 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1443 (xpm_color_bucket): Use better integer hashing function.
1444 (xpm_cache_color): Don't possibly over-allocate memory.
1445 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1446 (gif_memory_source):
1447 Use ptrdiff_t, not int or size_t, to record sizes.
1448 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1449 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1450 either works, as we prefer signed integers.
1451 (tiff_read_from_memory, tiff_write_from_memory):
1452 Return tsize_t, not size_t, since that's what the TIFF API wants.
1453 (tiff_read_from_memory): Don't fail simply because the read would
1454 go past EOF; instead, return a short read.
1455 (tiff_load): Omit no-longer-needed casts.
1456 (Fimagemagick_types): Don't assume size fits into 'int'.
1457
1458 Improve hashing quality when configured --with-wide-int.
1459 * fns.c (hash_string): New function, taken from sxhash_string.
1460 Do not discard information about ASCII character case; this
1461 discarding is no longer needed.
1462 (sxhash-string): Use it. Change sig to match it. Caller changed.
1463 * lisp.h: Declare it.
1464 * lread.c (hash_string): Remove, since we now use fns.c's version.
1465 The fns.c version returns a wider integer if --with-wide-int is
1466 specified, so this should help the quality of the hashing a bit.
1467
1468 * emacs.c: Integer overflow minor fix.
1469 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1470 Define only if GNU_LINUX.
1471 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1472
1473 * dispnew.c: Integer signedness and overflow fixes.
1474 Remove unnecessary forward decls, that were a maintenance hassle.
1475 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1476 All uses changed.
1477 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1478 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1479 (prepare_desired_row, line_draw_cost):
1480 Use int, not unsigned, where either works.
1481 (save_current_matrix, restore_current_matrix):
1482 Use ptrdiff_t, not size_t, where either works.
1483 (init_display): Check for overflow more accurately, and without
1484 relying on undefined behavior.
1485
1486 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1487 Remove, replacing with the new symbols in lisp.h. All uses changed.
1488 * fileio.c (make_temp_name):
1489 * filelock.c (lock_file_1, lock_file):
1490 * xdisp.c (message_dolog):
1491 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1492 Use pMd etc. instead.
1493 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1494 replacing the pWIDE etc. symbols removed from editfns.c.
1495
1496 * keyboard.h (num_input_events): Now uintmax_t.
1497 This is (very slightly) less likely to mess up due to wraparound.
1498 All uses changed.
1499
1500 * buffer.c: Integer signedness fixes.
1501 (alloc_buffer_text, enlarge_buffer_text):
1502 Use ptrdiff_t rather than size_t when either will do, as we prefer
1503 signed integers.
1504
1505 * alloc.c: Integer signedness and overflow fixes.
1506 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1507 (__malloc_size_t): Default to size_t, not to int.
1508 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1509 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1510 Prefer ptrdiff_t to size_t when either would do, as we prefer
1511 signed integers.
1512 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1513 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1514 Now const. Initialize with values that are in range even if char
1515 is signed.
1516 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1517 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1518 These functions do the right thing with sizes > 2**32.
1519 (check_depth): Now ptrdiff_t, not int.
1520 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1521 Adjust to new way of storing sizes. Check for size overflow bugs
1522 in rest of code.
1523 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1524 slightly wrong anyway, as it missed one instance of
1525 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1526 (refill_memory_reserve): Omit needless cast to size_t.
1527 (mark_object_loop_halt): Mark as externally visible.
1528
1529 * xselect.c: Integer signedness and overflow fixes.
1530 (Fx_register_dnd_atom, x_handle_dnd_message):
1531 Use ptrdiff_t, not size_t, since we prefer signed.
1532 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1533 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1534 x_dnd_atoms_size and x_dnd_atoms_length.
1535
1536 * doprnt.c: Prefer signed to unsigned when either works.
1537 * eval.c (verror):
1538 * doprnt.c (doprnt):
1539 * lisp.h (doprnt):
1540 * xdisp.c (vmessage):
1541 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1542 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1543 prefer signed arithmetic to avoid comparison confusion.
1544 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1545 but is a bit tricky.
1546
1547 Assume freestanding C89 headers, string.h, stdlib.h.
1548 * data.c, doprnt.c, floatfns.c, print.c:
1549 Include float.h unconditionally.
1550 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1551 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1552 * regex.c: Likewise for stddef.h, string.h.
1553 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1554 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1555 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1556 (STDC_HEADERS): Remove obsolete defines.
1557 * sysdep.c: Include limits.h unconditionally.
1558
1559 Assume support for memcmp, memcpy, memmove, memset.
1560 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1561 * regex.c (memcmp, memcpy):
1562 Remove; we assume C89 now.
1563
1564 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1565 (__malloc_safe_bcopy): Remove; no longer needed.
1566
1567 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1568 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1569 well either way, and we prefer signed to unsigned.
1570
1571 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1572
1573 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1574 closes the connection while we're reading (bug#9182).
1575
1576 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1577
1578 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1579 are specified (Bug#9168).
1580
1581 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1582
1583 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1584 Found by GCC static checking and --with-wide-int on a 32-bit host.
1585
1586 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1587
1588 * xdisp.c (compute_display_string_pos): Fix logic of caching
1589 previous display string position. Initialize cached_prev_pos to
1590 -1. Fixes slow-down at the beginning of a buffer.
1591
1592 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1593
1594 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1595 for attrs[LFACE_FONTSET_INDEX].
1596
1597 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1598
1599 * xml.c (parse_region): Remove unused local
1600 that was recently introduced.
1601
1602 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1603
1604 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1605 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1606
1607 * xdisp.c (move_it_in_display_line_to): Record the best matching
1608 position for TO_CHARPOS while scanning the line, and restore it on
1609 exit if none of the characters scanned was an exact match.
1610 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1611 when exact match is impossible due to invisible text, and the
1612 lines are truncated.
1613
1614 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1615
1616 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1617 for OSX >= 10.7.
1618
1619 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1620
1621 Fix a significant slow-down of cursor motion with C-n, C-p,
1622 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1623 auto-repeat under bidi redisplay in fontified buffers.
1624 * xdisp.c (compute_stop_pos_backwards): New function.
1625 (next_element_from_buffer): Call compute_stop_pos_backwards to
1626 find a suitable prev_stop when we find ourselves before
1627 base_level_stop.
1628 (reseat): Don't look for prev_stop, as that could mean a very long
1629 run.
1630 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1631 <cached_disp_overlay_modiff>: Cache for last found display string
1632 position.
1633 (compute_display_string_pos): Return the cached position if asked
1634 about the same buffer in the same area of character positions, and
1635 the buffer wasn't changed since the time the display string
1636 position was cached.
1637
1638 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1639
1640 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1641 is an integer, which is important for empty lines. (Bug#9149)
1642
1643 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1644
1645 * frame.c (Fmodify_frame_parameters): In tty case, update the
1646 default face if necessary (Bug#4238).
1647
1648 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1649
1650 * editfns.c (Fstring_to_char): No need to explain what a character
1651 is in the docstring (Bug#6576).
1652
1653 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1654
1655 * xml.c (parse_region): Make sure we always return a tree.
1656
1657 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1658
1659 * xml.c (parse_region): If a document contains only comments,
1660 return that, too.
1661
1662 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1663
1664 * xml.c (make_dom): Return comments, too.
1665
1666 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1667
1668 Port to OpenBSD.
1669 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1670 and the surrounding thread.
1671 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1672 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1673 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1674 timer goes off.
1675 * s/openbsd.h (BROKEN_SIGIO): Define.
1676 * unexelf.c (unexec) [__OpenBSD__]:
1677 Don't update the .mdebug section of the Alpha COFF symbol table.
1678
1679 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1680
1681 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1682 (bug#8460).
1683
1684 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1685
1686 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1687 This fixes some race conditions on the permissions of any newly
1688 created file.
1689
1690 * alloc.c (valid_pointer_p): Use pipe, not open.
1691 This fixes some permissions issues when debugging.
1692
1693 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1694 If fchown fails to set both uid and gid, try to set just gid,
1695 as that is sometimes allowed. Adjust the file's mode to eliminate
1696 setuid or setgid bits that are inappropriate if fchown fails.
1697
1698 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1699
1700 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1701 to compare Lisp_Objects.
1702 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1703 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1704 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1705
1706 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1707
1708 * lread.c (read_integer): Unread even EOF character.
1709 (read1): Likewise. Properly record start position of symbol.
1710
1711 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1712 symbol character follows.
1713
1714 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1715
1716 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1717 This works around a problem with the previous change to Fcopy_file.
1718 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1719 and without this change, GCC might complain about discarding
1720 fchown's return value.
1721
1722 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1723
1724 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1725
1726 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1727
1728 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1729
1730 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1731
1732 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1733 it's used from the C level.
1734
1735 * process.c: Use the same condition for POLL_FOR_INPUT in both
1736 keyboard.c and process.c (bug#1858).
1737
1738 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1739
1740 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1741 (Fgnutls_boot): Use it.
1742
1743 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1744
1745 * doc.c (Fsubstitute_command_keys): Revert last change.
1746
1747 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1748
1749 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1750 quotes the next character, and doesn't affect other longer
1751 sequences (bug#8935).
1752
1753 * lread.c (syms_of_lread): Clarify that is isn't only
1754 `eval-buffer' and `eval-defun' that's affected by
1755 `lexical-binding' (bug#8460).
1756
1757 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1758
1759 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1760 bidi redisplay when a line includes both an image and is
1761 truncated.
1762
1763 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1764
1765 Fix minor problems found by static checking.
1766 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1767 (elsz): Now a signed constant, not a size_t var. We prefer signed
1768 types to unsigned, to avoid integer comparison confusion. Without
1769 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1770 "cannot optimize loop, the loop counter may overflow", a symptom
1771 of the confusion.
1772 * indent.c (Fvertical_motion): Mark locals as initialized.
1773 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1774
1775 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1776
1777 * search.c (Fre_search_backward): Mention `case-fold-search' in
1778 all the re_search_* functions (bug#8138).
1779
1780 * keyboard.c (Fopen_dribble_file): Document when the file is
1781 closed (bug#8056).
1782
1783 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1784
1785 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1786 bidi_cache_idx.
1787
1788 Support bidi reordering of display and overlay strings.
1789 * xdisp.c (compute_display_string_pos)
1790 (compute_display_string_end): Accept additional argument STRING.
1791 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1792 (reseat_to_string): Initialize bidi_it->string.s and
1793 bidi_it->string.schars.
1794 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1795 NULL (avoids a crash in bidi_paragraph_init).
1796 Initialize itb.string.lstring.
1797 (init_iterator): Call bidi_init_it only of a valid
1798 buffer position was specified. Initialize paragraph_embedding to
1799 L2R.
1800 (reseat_to_string): Initialize the bidi iterator.
1801 (display_string): If we need to ignore text properties of
1802 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1803 original value of -1 will not work with bidi.)
1804 (compute_display_string_pos): First arg is now struct
1805 `text_pos *'; all callers changed. Support display properties on
1806 Lisp strings.
1807 (compute_display_string_end): Support display properties on Lisp
1808 strings.
1809 (init_iterator, reseat_1, reseat_to_string): Initialize the
1810 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1811 when iterating on a string not from display properties).
1812 (compute_display_string_pos, compute_display_string_end):
1813 Fix calculation of the object to scan. Fixes an error when using
1814 arrow keys.
1815 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1816 base_level_stop; instead, set base_level_stop to BEGV.
1817 Fixes crashes in vertical-motion.
1818 (next_element_from_buffer): Improve commentary for when
1819 the iterator is before prev_stop.
1820 (init_iterator): Initialize bidi_p from the default value of
1821 bidi-display-reordering, not from buffer-local value. Use the
1822 buffer-local value only if initializing for buffer iteration.
1823 (handle_invisible_prop): Support invisible properties on strings
1824 that are being bidi-reordered.
1825 (set_iterator_to_next): Support bidi reordering of C strings and
1826 Lisp strings.
1827 (next_element_from_string): Support bidi reordering of Lisp
1828 strings.
1829 (handle_stop_backwards): Support Lisp strings as well.
1830 (display_string): Support display of R2L glyph rows.
1831 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1832 (init_iterator): Don't initialize it->bidi_p for strings
1833 here.
1834 (reseat_to_string): Initialize it->bidi_p for strings here.
1835 (next_element_from_string, next_element_from_c_string)
1836 (next_element_from_buffer): Add xassert's for correspondence
1837 between IT's object being iterated and it->bidi_it.string
1838 structure.
1839 (face_before_or_after_it_pos): Support bidi iteration.
1840 (next_element_from_c_string): Handle the case of the first string
1841 character that is not the first one in the visual order.
1842 (get_visually_first_element): New function, refactored from common
1843 parts of next_element_from_buffer, next_element_from_string, and
1844 next_element_from_c_string.
1845 (tool_bar_lines_needed, redisplay_tool_bar)
1846 (display_menu_bar): Force left-to-right direction. Add a FIXME
1847 comment for making that be controlled by a user option.
1848 (push_it, pop_it): Save and restore the state of the
1849 bidi iterator. Save and restore the bidi_p flag.
1850 (pop_it): Iterate out of display property for string iteration as
1851 well.
1852 (iterate_out_of_display_property): Support iteration over strings.
1853 (handle_single_display_spec): Set up it->bidi_it for iteration
1854 over a display string, and call bidi_init_it.
1855 (handle_single_display_spec, next_overlay_string)
1856 (get_overlay_strings_1, push_display_prop): Set up the bidi
1857 iterator for displaying display or overlay strings.
1858 (forward_to_next_line_start): Don't use the shortcut if
1859 bidi-iterating.
1860 (back_to_previous_visible_line_start): If handle_display_prop
1861 pushed the iterator stack, restore the internal state of the bidi
1862 iterator by calling bidi_pop_it same number of times.
1863 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1864 and we are bidi-iterating, don't decrement the iterator position;
1865 instead, set the first_elt flag in the bidi iterator, to produce
1866 the same effect.
1867 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1868 (push_display_prop): xassert that we are iterating a buffer.
1869 (push_it, pop_it): Save and restore paragraph_embedding member.
1870 (handle_single_display_spec, next_overlay_string)
1871 (get_overlay_strings_1, reseat_1, reseat_to_string)
1872 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1873 correctly. Don't assume unibyte strings are not bidi-reordered.
1874 (compute_display_string_pos)
1875 (compute_display_string_end): Fix handling the case of C string.
1876 (push_it, pop_it): Save and restore from_disp_prop_p.
1877 (handle_single_display_spec, push_display_prop): Set the
1878 from_disp_prop_p flag.
1879 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1880 (pop_it): Call iterate_out_of_display_property only if we are
1881 popping after iteration over a string that came from a display
1882 property. Fix a typo in popping stretch info. Add an assertion
1883 for verifying that the iterator position is in sync with the bidi
1884 iterator.
1885 (handle_single_display_spec, get_overlay_strings_1)
1886 (push_display_prop): Fix initialization of paragraph direction for
1887 string when that of the parent object is not yet determined.
1888 (reseat_1): Call bidi_init_it to resync the bidi
1889 iterator with IT's position. (Bug#7616)
1890 (find_row_edges): If ROW->start.pos gives position
1891 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1892 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1893 Reset the from_disp_prop_p flag.
1894 (SAVE_IT, RESTORE_IT): New macros.
1895 (pos_visible_p, face_before_or_after_it_pos)
1896 (back_to_previous_visible_line_start)
1897 (move_it_in_display_line_to, move_it_in_display_line)
1898 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1899 (try_scrolling, redisplay_window, display_line): Use them when
1900 saving a temporary copy of the iterator and restoring it back.
1901 (back_to_previous_visible_line_start, reseat_1)
1902 (init_iterator): Empty the bidi cache "stack".
1903 (move_it_in_display_line_to): If iterator ended up at
1904 EOL, but we never saw any buffer positions smaller than
1905 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1906 motion in bidi-reordered lines.
1907 (move_it_in_display_line_to): Record prev_method and prev_pos
1908 immediately before the call to set_iterator_to_next. Fixes cursor
1909 motion in bidi-reordered lines with stretch glyphs and strings
1910 displayed in margins. (Bug#8133) (Bug#8867)
1911 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1912 TO_CHARPOS.
1913 (pos_visible_p): Support positions in bidi-reordered lines.
1914 Save and restore bidi cache.
1915
1916 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1917 (bidi_paragraph_info): Delete unused struct.
1918 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1919 (bidi_cache_start): New variable.
1920 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1921 to zero.
1922 (bidi_cache_fetch_state, bidi_cache_search)
1923 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1924 (bidi_cache_find, bidi_peek_at_next_level)
1925 (bidi_level_of_next_char, bidi_find_other_level_edge)
1926 (bidi_move_to_visually_next): Compare cache index with
1927 bidi_cache_start rather than with zero.
1928 (bidi_fetch_char): Accept new argument STRING; all callers
1929 changed. Support iteration over a string. Support strings with
1930 display properties. Support unibyte strings. Fix the type of
1931 `len' according to what STRING_CHAR_AND_LENGTH expects.
1932 (bidi_paragraph_init, bidi_resolve_explicit_1)
1933 (bidi_resolve_explicit, bidi_resolve_weak)
1934 (bidi_level_of_next_char, bidi_move_to_visually_next):
1935 Support iteration over a string.
1936 (bidi_set_sor_type, bidi_resolve_explicit_1)
1937 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1938 can now be zero (for strings); special values 0 and -1 were
1939 changed to -1 and -2, respectively.
1940 (bidi_char_at_pos): New function.
1941 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1942 Call it instead of FETCH_MULTIBYTE_CHAR.
1943 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1944 initialized to valid values.
1945 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1946 values.
1947 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1948 the test for valid cached positions. Fix the logic for looking up
1949 the sentinel state in the cache. GCPRO the Lisp string we are
1950 iterating.
1951 (bidi_push_it, bidi_pop_it): New functions.
1952 (bidi_initialize): Initialize the bidi cache start stack pointer.
1953 (bidi_cache_ensure_space): New function, refactored from part of
1954 bidi_cache_iterator_state. Don't assume the required size is just
1955 one BIDI_CACHE_CHUNK away.
1956 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1957 (bidi_count_bytes, bidi_char_at_pos): New functions.
1958 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1959 always valid if bidi_cache_idx is valid.
1960 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1961 is valid if it's going to be used.
1962 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1963 (bidi_cache_fetch_state, bidi_cache_search)
1964 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1965 (bidi_cache_iterator_state, bidi_cache_find)
1966 (bidi_find_other_level_edge, bidi_cache_start_stack):
1967 All variables related to cache indices are now EMACS_INT.
1968
1969 * dispextern.h (struct bidi_string_data): New structure.
1970 (struct bidi_it): New member `string'. Make flag members be 1-bit
1971 fields, and put them last in the struct.
1972 (compute_display_string_pos, compute_display_string_end):
1973 Update prototypes.
1974 (bidi_push_it, bidi_pop_it): Add prototypes.
1975 (struct iterator_stack_entry): New members bidi_p,
1976 paragraph_embedding, and from_disp_prop_p.
1977 (struct it): Member bidi_p is now a bit field 1 bit wide.
1978 (bidi_shelve_cache, bidi_unshelve_cache):
1979 Declare prototypes.
1980
1981 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1982 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1983 and vector-like objects.
1984
1985 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1986 cache around display iteration.
1987
1988 * window.c (Fwindow_end, window_scroll_pixel_based)
1989 (displayed_window_lines, Frecenter): Save and restore the bidi
1990 cache around display iteration.
1991
1992 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1993
1994 * editfns.c (Fdelete_region): Clarify the use of the named
1995 parameters (bug#6788).
1996
1997 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1998
1999 * indent.c (Fvertical_motion): Set and restore w->pointm when
2000 saving and restoring the window's buffer (Bug#9006).
2001
2002 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2003
2004 * editfns.c (Fstring_to_char): Clarify just what is returned
2005 (bug#6576). Text by Eli Zaretskii.
2006
2007 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2008
2009 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2010
2011 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2012
2013 * buffer.c (mmap_find): Fix a typo.
2014
2015 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2016
2017 Fix execution of x selection hooks.
2018 * xselect.c (Qx_lost_selection_functions)
2019 (Qx_sent_selection_functions): New vars.
2020 (syms_of_xselect): DEFSYM them.
2021 (x_handle_selection_request): Pass Qx_sent_selection_functions
2022 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2023 (x_handle_selection_clear,x_clear_frame_selections):
2024 Pass Qx_lost_selection_functions rather than
2025 Vx_lost_selection_functions to Frun_hook_with_args.
2026
2027 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2028
2029 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2030 The old code sometimes used this field without initializing it.
2031
2032 * alloc.c (gc_sweep): Don't read past end of array.
2033 In theory, the old code could also have corrupted Emacs internals,
2034 though it'd be very unlikely.
2035
2036 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2037
2038 * character.c (Fcharacterp): Don't advertise optional ignored
2039 argument. (Bug#4026)
2040
2041 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2042
2043 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2044 key" (bug#4257).
2045
2046 * window.c (Fset_window_start): Doc fix (bug#4199).
2047 (Fset_window_hscroll): Ditto.
2048
2049 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2050
2051 Fix minor new problems caught by GCC 4.6.1.
2052 * term.c (init_tty): Remove unused local.
2053 * xsettings.c (store_monospaced_changed): Define this function only
2054 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2055 not used otherwise.
2056
2057 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2058
2059 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2060
2061 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2062
2063 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2064 are the mini-buffer and the echo area (bug#3320).
2065
2066 * term.c (init_tty): Remove support for supdup, c10 and perq
2067 terminals, which are no longer supported (bug#1482).
2068
2069 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2070
2071 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2072
2073 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2074
2075 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2076 for non-popups (Bug#3642).
2077
2078 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2079
2080 * alloc.c (reset_malloc_hooks): Protoize.
2081 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2082 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2083 * cm.c (losecursor): Likewise.
2084 * data.c (fmod): Likewise.
2085 * dispnew.c (swap_glyphs_in_rows): Likewise.
2086 * emacs.c (memory_warning_signal): Likewise.
2087 * floatfns.c (float_error): Likewise.
2088 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2089 (otf_open, font_otf_capability, generate_otf_features)
2090 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2091 Likewise.
2092 * image.c (pbm_read_file): Likewise.
2093 * indent.c (string_display_width): Likewise.
2094 * intervals.c (check_for_interval, search_for_interval)
2095 (inc_interval_count, count_intervals, root_interval)
2096 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2097 * lread.c (defalias): Likewise.
2098 * ralloc.c (r_alloc_check): Likewise.
2099 * regex.c (set_image_of_range_1, set_image_of_range)
2100 (regex_grow_registers): Likewise.
2101 * sysdep.c (strerror): Likewise.
2102 * termcap.c (valid_filename_p, tprint, main): Likewise.
2103 * tparam.c (main): Likewise.
2104 * unexhp9k800.c (run_time_remap, save_data_space)
2105 (update_file_ptrs, read_header, write_header, calculate_checksum)
2106 (copy_file, copy_rest, display_header): Likewise.
2107 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2108 Likewise.
2109 * xdisp.c (check_it): Likewise.
2110 * xfaces.c (register_color, unregister_color, unregister_colors):
2111 Likewise.
2112 * xfns.c (print_fontset_result): Likewise.
2113 * xrdb.c (member, fatal, main): Likewise.
2114
2115 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2116
2117 Fix minor problems found by static checking (Bug#9031).
2118 * chartab.c (char_table_set_range, map_sub_char_table):
2119 Remove unused locals.
2120 (uniprop_table): Now static.
2121 * composite.c (_work_char): Remove unused static var.
2122
2123 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2124
2125 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2126
2127 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2128
2129 * gtkutil.c (qttip_cb): Remove code without function.
2130
2131 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2132
2133 * w32.c (pthread_sigmask): New stub.
2134
2135 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2136
2137 Use pthread_sigmask, not sigprocmask (Bug#9010).
2138 sigprocmask is portable only for single-threaded applications, and
2139 Emacs can be multi-threaded when it uses GTK.
2140 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2141 (LIBES): Use it.
2142 * callproc.c (Fcall_process):
2143 * process.c (create_process):
2144 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2145 Use pthread_sigmask, not sigprocmask.
2146
2147 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2148
2149 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2150 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2151 wrong (Bug#8591).
2152
2153 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2154
2155 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2156 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2157 (xg_hide_tooltip): Fix comment.
2158
2159 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2160 in registerServicesMenuSendTypes.
2161 (validRequestorForSendType): Don't check ns_return_types.
2162
2163 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2164 ns_return_type.
2165
2166 2011-07-08 Jason Rumney <jasonr@gnu.org>
2167
2168 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2169 frame struct members of non-existent frames (Bug#6284).
2170
2171 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2172
2173 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2174 variable firstTime not needed on OSX >= 10.6.
2175 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2176 >= 10.5. Use setKnobProportion, setDoubleValue.
2177
2178 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2179 (MAC_OS_X_VERSION_10_5): Define if not defined.
2180 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2181 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2182 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2183
2184 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2185 cString and lossyCString on OSX >= 10.4
2186
2187 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2188 sizeToFit on OSX >= 10.2.
2189
2190 * nsimage.m (allocInitFromFile): Don't use deprecated method
2191 bestRepresentationForDevice on OSX >= 10.6.
2192
2193 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2194 to avoid warning.
2195
2196 * emacs.c: Declare unexec_init_emacs_zone.
2197
2198 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2199
2200 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2201
2202 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2203 on svcsMenu (Bug#8842).
2204
2205 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2206 ns_return_types.
2207 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2208
2209 * nsterm.m (QUTF8_STRING): Declare.
2210 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2211 (validRequestorForSendType): Return type is (id).
2212 Change indexOfObjectIdenticalTo to indexOfObject.
2213 Check if we have local selection before returning self (Bug#8842).
2214 (writeSelectionToPasteboard): Put local selection into paste board
2215 if we have a local selection (Bug#8842).
2216 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2217
2218 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2219 (ns_get_local_selection): Declare.
2220
2221 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2222
2223 * keymap.c (describe_map_tree): Don't insert a double newline at
2224 the end of the buffer (bug#1169) and return whether we inserted
2225 something.
2226
2227 * callint.c (Fcall_interactively): Change "reading args" to
2228 "providing args" to try to clarify what it does (bug#1010).
2229
2230 2011-07-07 Kenichi Handa <handa@m17n.org>
2231
2232 * composite.c (composition_compute_stop_pos): Ignore a static
2233 composition starting before CHARPOS (Bug#8915).
2234
2235 * xdisp.c (handle_composition_prop): Likewise.
2236
2237 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2238
2239 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2240 (Bug#9015)
2241
2242 2011-07-07 Kenichi Handa <handa@m17n.org>
2243
2244 * character.h (unicode_category_t): New enum type.
2245
2246 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2247 (Qchar_code_property_table): New variable.
2248 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2249 (UNIPROP_COMPRESSED_FORM_P): New macros.
2250 (char_table_ascii): Uncompress the compressed values.
2251 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2252 Uncompress the compressed values.
2253 (sub_char_table_ref_and_range): Likewise.
2254 (char_table_ref_and_range): Uncompress the compressed values.
2255 (sub_char_table_set): New arg is_uniprop. Callers changed.
2256 Uncompress the compressed values.
2257 (sub_char_table_set_range): Args changed. Callers changed.
2258 (char_table_set_range): Adjuted for the above change.
2259 (map_sub_char_table): Delete args default_val and parent. Add arg
2260 top. Give decoded values to a Lisp function.
2261 (map_char_table): Adjust for the above change. Give decoded
2262 values to a Lisp function. Gcpro more variables.
2263 (uniprop_table_uncompress)
2264 (uniprop_decode_value_run_length): New functions.
2265 (uniprop_decoder, uniprop_decoder_count): New variables.
2266 (uniprop_get_decoder, uniprop_encode_value_character)
2267 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2268 New functions.
2269 (uniprop_encoder, uniprop_encoder_count): New variables.
2270 (uniprop_get_encoder, uniprop_table)
2271 (Funicode_property_table_internal, Fget_unicode_property_internal)
2272 (Fput_unicode_property_internal): New functions.
2273 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2274 Sunicode_property_table_internal, Sget_unicode_property_internal,
2275 and Sput_unicode_property_internal. Defvar_lisp
2276 char-code-property-alist.
2277
2278 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2279 Vunicode_category_table.
2280
2281 * font.c (font_range): Adjust for the change of
2282 Vunicode_category_table.
2283
2284 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2285
2286 * m/iris4d.h: Remove file, move contents ...
2287 * s/irix6-5.h: ... here.
2288
2289 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2290
2291 Remove unportable assumption about struct layout (Bug#8884).
2292 * alloc.c (mark_buffer):
2293 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2294 (clone_per_buffer_values): Don't assume that
2295 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2296 This isn't true in general, and it's particularly not true
2297 if Emacs is configured with --with-wide-int.
2298 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2299 New macros, used in the buffer.c change.
2300
2301 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2302
2303 * xsettings.c: Use both GConf and GSettings if both are available.
2304 (store_config_changed_event): Add comment.
2305 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2306 (store_tool_bar_style_changed): New functions.
2307 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2308 (struct xsettings): Move font inside HAVE_XFT.
2309 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2310 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2311 Move inside HAVE_XFT.
2312 (something_changed_gsettingsCB): Rename from something_changedCB.
2313 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2314 also.
2315 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2316 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2317 (something_changed_gconfCB): Rename from something_changedCB.
2318 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2319 (parse_settings): Move check for font inside HAVE_XFT.
2320 (read_settings, apply_xft_settings): Add comment.
2321 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2322 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2323 call store_font_name_changed.
2324 (xft_settings_event): Add comment.
2325 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2326 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2327 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2328 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2329 (xsettings_initialize): Call init_gsettings last.
2330 (xsettings_get_system_font, xsettings_get_system_normal_font):
2331 Add comment.
2332
2333 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2334
2335 Random fixes. E.g., (random) never returned negative values.
2336 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2337 subseconds part to the entropy, as that's a bit more random.
2338 Prefer signed to unsigned, since the signedness doesn't matter and
2339 in general we prefer signed. When given a limit, use a
2340 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2341 latter isn't right if USE_2_TAGS_FOR_INTS.
2342 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2343 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2344
2345 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2346
2347 * textprop.c (text_property_stickiness):
2348 Obey Vtext_property_default_nonsticky.
2349 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2350 * w32fns.c (syms_of_w32fns):
2351 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2352
2353 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2354
2355 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2356 This is more efficient than Ffile_directory_p and avoids a minor race.
2357
2358 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2359
2360 * buffer.c (Foverlay_put): Say what the return value is
2361 (bug#7835).
2362
2363 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2364 is a directory before asking whether to use the file name
2365 (bug#7564).
2366 (barf_or_query_if_file_exists): Make the "File is a directory"
2367 error be more correct.
2368
2369 * fns.c (Frequire): Remove the mention of the .gz files, since
2370 that's installation-specific, but keep the mention of
2371 `get-load-suffixes'.
2372
2373 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2374
2375 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2376 Report string overflow if the output is too long.
2377
2378 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2379
2380 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2381 (syms_of_gnutls): Remove duplicate DEFSYM for
2382 Qgnutls_bootprop_verify_hostname_error, an error for
2383 Qgnutls_bootprop_verify_error (which is no longer used).
2384
2385 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2386 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2387 Also (re)move comments that are misplaced or no longer relevant.
2388
2389 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2390
2391 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2392
2393 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2394
2395 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2396 and background color parameters if they have been changed.
2397
2398 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2399
2400 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2401
2402 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2403
2404 * xsettings.c (SYSTEM_FONT): Define only when used.
2405 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2406
2407 * keymap.c (access_keymap_1): Now static.
2408
2409 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2410
2411 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2412 leave any prefix arg for the up event (Bug#1586).
2413
2414 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2415
2416 * lread.c (syms_of_lread): Mention single symbols defined by
2417 `defvar' or `defconst' (bug#7154).
2418
2419 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2420 (Frequire): Mention get-load-suffixes.
2421
2422 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2423
2424 * window.h (window): Remove clone_number slot.
2425 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2426 Remove.
2427 (make_parent_window, make_window, saved_window)
2428 (Fset_window_configuration, save_window_save): Don't deal with
2429 clone numbers.
2430 * buffer.c (Qclone_number): Remove declaration.
2431 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2432
2433 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2434
2435 Add multiple inheritance to keymaps.
2436 * keymap.c (Fmake_composed_keymap): New function.
2437 (Fset_keymap_parent): Simplify.
2438 (fix_submap_inheritance): Remove.
2439 (access_keymap_1): New function extracted from access_keymap to handle
2440 embedded parents and handle lists of maps.
2441 (access_keymap): Use it.
2442 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2443 (Fcopy_keymap): Handle embedded parents.
2444 (Fcommand_remapping, define_as_prefix): Simplify.
2445 (Fkey_binding): Simplify.
2446 (syms_of_keymap): Move minibuffer-local-completion-map,
2447 minibuffer-local-filename-completion-map,
2448 minibuffer-local-must-match-map, and
2449 minibuffer-local-filename-must-match-map to Elisp.
2450 (syms_of_keymap): Defsubr make-composed-keymap.
2451 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2452 (parse_menu_item): Trivial simplification.
2453
2454 2011-07-01 Glenn Morris <rgm@gnu.org>
2455
2456 * Makefile.in (SETTINGS_LIBS): Fix typo.
2457
2458 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2459
2460 * coding.c (Fencode_coding_string): Record the last coding system
2461 used, as the function doc string says (bug#8738).
2462
2463 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2464
2465 * xsettings.c (store_monospaced_changed): Take new font as arg and
2466 check for change against current_mono_font.
2467 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2468 (emacs_settings_constructor, emacs_settings_get_property)
2469 (emacs_settings_set_property, emacs_settings_class_init)
2470 (emacs_settings_init, gsettings_obj): Remove.
2471 (something_changedCB): New function for HAVE_GSETTINGS.
2472 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2473 with value as argument.
2474 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2475 g_settings_new (Bug#8967). Do not create gsettings_obj.
2476 Remove calls to g_settings_bind. Connect something_changedCB to
2477 "changed".
2478
2479 * xgselect.c: Add defined (HAVE_GSETTINGS).
2480 (xgselect_initialize): Ditto.
2481
2482 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2483 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2484 xg_select.
2485
2486 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2487
2488 * eval.c (struct backtrace): Simplify and port the data structure.
2489 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2490 signed bit field, as this assumption is not portable and it makes
2491 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2492 "char debug_on_exit : 1" as this is not portable either; instead,
2493 use the portable "unsigned int debug_on_exit : 1". Remove unused
2494 member evalargs. Remove obsolete comments about cc bombing out.
2495
2496 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2497
2498 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2499 Let HAVE_GSETTINGS override HAVE_GCONF.
2500 (store_monospaced_changed): New function.
2501 (EMACS_SETTINGS): A new type derived from GObject to handle
2502 GSettings notifications.
2503 (emacs_settings_constructor, emacs_settings_get_property)
2504 (emacs_settings_set_property, emacs_settings_class_init):
2505 New functions.
2506 (gsettings_client, gsettings_obj): New variables.
2507 (GSETTINGS_SCHEMA): New define.
2508 (something_changedCB): Call store_monospaced_changed.
2509 (init_gsettings): New function.
2510 (xsettings_initialize): Call init_gsettings.
2511 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2512 to NULL.
2513
2514 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2515 GCONF_CFLAGS/LIBS.
2516
2517 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2518
2519 * window.c (resize_root_window, grow_mini_window)
2520 (shrink_mini_window): Rename Qresize_root_window to
2521 Qwindow_resize_root_window and Qresize_root_window_vertically to
2522 Qwindow_resize_root_window_vertically.
2523
2524 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2525
2526 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2527
2528 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2529
2530 * makefile.w32-in: Redesign dependencies so they reflect more
2531 clearly which files are directly included by each source file,
2532 and not through other includes.
2533
2534 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2535
2536 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2537 (sort_overlays, overlay_strings): When an overlay's clone number
2538 matches the window's clone number process the overlay even if
2539 the overlay's window property doesn't match the current window.
2540
2541 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2542 (Fwindow_hchild): Rename to Fwindow_left_child.
2543 (Fwindow_next): Rename to Fwindow_next_sibling.
2544 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2545 (resize_window_check): Rename to window_resize_check.
2546 (resize_window_apply): Rename to window_resize_apply.
2547 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2548 (Fdelete_other_windows_internal, resize_frame_windows)
2549 (Fsplit_window_internal, Fdelete_window_internal)
2550 (grow_mini_window, shrink_mini_window)
2551 (Fresize_mini_window_internal): Fix callers accordingly.
2552
2553 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2554
2555 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2556 (emacs_fixed_set_min_size): Remove.
2557 (emacs_fixed_new): Take frame as argument.
2558
2559 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2560 (_EmacsFixedPrivate): Remove minwidth/height.
2561 Add struct frame *f.
2562 (emacs_fixed_init): Initialize priv->f.
2563 (get_parent_class, emacs_fixed_set_min_size): Remove.
2564 (emacs_fixed_new): Set priv->f to argument.
2565 (emacs_fixed_get_preferred_width)
2566 (emacs_fixed_get_preferred_height): Use min_width/height from
2567 frames size_hint to set minimum and natural (Bug#8919).
2568 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2569 and use min_width/height from frames size_hint to set
2570 min_width/height (Bug#8919).
2571
2572 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2573 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2574 Fix indentation.
2575
2576 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2577
2578 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2579 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2580 called at ZV.
2581
2582 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2583
2584 * process.c (wait_reading_process_output): Bypass select if
2585 waiting for a cell while ignoring keyboard input, and input is
2586 pending. Suggested by Jan Djärv (Bug#8869).
2587
2588 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2589
2590 Use gnulib's dup2 module instead of rolling our own.
2591 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2592
2593 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2594
2595 * dispnew.c (scrolling_window): Before scrolling, turn off a
2596 mouse-highlight in the window being scrolled.
2597
2598 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2599
2600 Move DEFSYM to lisp.h and use everywhere.
2601
2602 * character.h (DEFSYM): Move declaration...
2603 * lisp.h (DEFSYM): ...here.
2604
2605 * gnutls.c:
2606 * minibuf.c:
2607 * w32menu.c:
2608 * w32proc.c:
2609 * w32select.c: Don't include character.h.
2610
2611 * alloc.c (syms_of_alloc):
2612 * buffer.c (syms_of_buffer):
2613 * bytecode.c (syms_of_bytecode):
2614 * callint.c (syms_of_callint):
2615 * casefiddle.c (syms_of_casefiddle):
2616 * casetab.c (init_casetab_once):
2617 * category.c (init_category_once, syms_of_category):
2618 * ccl.c (syms_of_ccl):
2619 * cmds.c (syms_of_cmds):
2620 * composite.c (syms_of_composite):
2621 * dbusbind.c (syms_of_dbusbind):
2622 * dired.c (syms_of_dired):
2623 * dispnew.c (syms_of_display):
2624 * doc.c (syms_of_doc):
2625 * editfns.c (syms_of_editfns):
2626 * emacs.c (syms_of_emacs):
2627 * eval.c (syms_of_eval):
2628 * fileio.c (syms_of_fileio):
2629 * fns.c (syms_of_fns):
2630 * frame.c (syms_of_frame):
2631 * fringe.c (syms_of_fringe):
2632 * insdel.c (syms_of_insdel):
2633 * keymap.c (syms_of_keymap):
2634 * lread.c (init_obarray, syms_of_lread):
2635 * macros.c (syms_of_macros):
2636 * msdos.c (syms_of_msdos):
2637 * print.c (syms_of_print):
2638 * process.c (syms_of_process):
2639 * search.c (syms_of_search):
2640 * sound.c (syms_of_sound):
2641 * syntax.c (init_syntax_once, syms_of_syntax):
2642 * terminal.c (syms_of_terminal):
2643 * textprop.c (syms_of_textprop):
2644 * undo.c (syms_of_undo):
2645 * w32.c (globals_of_w32):
2646 * window.c (syms_of_window):
2647 * xdisp.c (syms_of_xdisp):
2648 * xfaces.c (syms_of_xfaces):
2649 * xfns.c (syms_of_xfns):
2650 * xmenu.c (syms_of_xmenu):
2651 * xsettings.c (syms_of_xsettings):
2652 * xterm.c (syms_of_xterm): Use DEFSYM.
2653
2654 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2655
2656 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2657
2658 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2659
2660 Integer and buffer overflow fixes (Bug#8873).
2661
2662 * print.c (printchar, strout): Check for string overflow.
2663 (PRINTPREPARE, printchar, strout):
2664 Don't set size unless allocation succeeds.
2665
2666 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2667 for sizes. Check for string overflow more accurately.
2668 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2669
2670 * macros.c: Integer and buffer overflow fixes.
2671 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2672 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2673 Use ptrdiff_t, not int, for sizes.
2674 Don't increment bufsize until after realloc succeeds.
2675 Check for size-calculation overflow.
2676 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2677
2678 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2679
2680 * lread.c: Integer overflow fixes.
2681 (read_integer): Radix is now EMACS_INT, not int,
2682 to improve quality of diagnostics for out-of-range radices.
2683 Calculate buffer size correctly for out-of-range radices.
2684 (read1): Check for integer overflow in radices, and in
2685 read-circle numbers.
2686 (read_escape): Avoid int overflow.
2687 (Fload, openp, read_buffer_size, read1)
2688 (substitute_object_recurse, read_vector, read_list, map_obarray):
2689 Use ptrdiff_t, not int, for sizes.
2690 (read1): Use EMACS_INT, not int, for sizes.
2691 Check for size overflow.
2692
2693 * image.c (cache_image): Check for size arithmetic overflow.
2694
2695 * lread.c: Integer overflow issues.
2696 (saved_doc_string_size, saved_doc_string_length)
2697 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2698 Now ptrdiff_t, not int.
2699 (read1): Don't assume doc string length fits in int. Check for
2700 out-of-range doc string lengths.
2701 (read_list): Don't assume file position fits in int.
2702 (read_escape): Check for hex character overflow.
2703
2704 2011-06-22 Leo Liu <sdl.web@gmail.com>
2705
2706 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2707 Move to minibuffer.el.
2708
2709 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2710
2711 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2712 The following patches are for when GLYPH_DEBUG && !XASSERT.
2713 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2714 * dispnew.c (flush_stdout):
2715 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2716 Mark as externally visible.
2717 * dispnew.c (check_window_matrix_pointers): Now static.
2718 * dispnew.c (window_to_frame_vpos):
2719 * xfns.c (unwind_create_frame):
2720 * xterm.c (x_check_font): Remove unused local.
2721 * scroll.c (CHECK_BOUNDS):
2722 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2723 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2724 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2725 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2726 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2727 Now static.
2728 (debug_method_add): Use va_list and vsprintf rather than relying
2729 on undefined behavior with wrong number of arguments.
2730 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2731 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2732 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2733 since we're not interested in debugging glyphs with old libraries.
2734 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2735 GCC 4.6.0's static checking.
2736
2737 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2738
2739 Integer overflow and signedness fixes (Bug#8873).
2740 A few related buffer overrun fixes, too.
2741
2742 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2743
2744 * dispextern.h (struct face.stipple):
2745 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2746 (x_bitmap_mask, x_allocate_bitmap_record)
2747 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2748 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2749 (x_create_bitmap_from_xpm_data):
2750 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2751 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2752 (.bitmaps_last):
2753 * xfaces.c (load_pixmap):
2754 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2755 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2756 (.bitmaps_last, struct x_output.icon_bitmap):
2757 Use ptrdiff_t, not int, for bitmap indexes.
2758 (x_allocate_bitmap_record): Check for size overflow.
2759 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2760
2761 Use ptrdiff_t, not int, for overlay counts.
2762 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2763 * editfns.c (overlays_around, get_pos_property):
2764 * textprop.c (get_char_property_and_overlay):
2765 * xdisp.c (next_overlay_change, note_mouse_highlight):
2766 * xfaces.c (face_at_buffer_position):
2767 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2768 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2769 (Fnext_overlay_change, Fprevious_overlay_change)
2770 (mouse_face_overlay_overlaps, Foverlays_in):
2771 Use ptrdiff_t, not int, for sizes.
2772 (overlays_at, overlays_in): Check for size-calculation overflow.
2773
2774 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2775
2776 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2777 (x_session_initialize): Do not assume string length fits in int.
2778
2779 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2780 This is unlikely, but can occur if DPI is outlandish.
2781
2782 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2783 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2784
2785 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2786 * xrdb.c (magic_file_p, search_magic_path):
2787 Omit last arg SUFFIX; it was always 0. All callers changed.
2788 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2789
2790 * xfont.c (xfont_match): Avoid need for strlen.
2791
2792 * xfns.c: Don't assume strlen fits in int.
2793 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2794
2795 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2796 not unsigned long, as we prefer signed integers. All callers changed.
2797 Detect integer overflow in repeat count.
2798 (message_dolog): Don't assume print length fits in 39 bytes.
2799 (display_mode_element): Don't assume strlen fits in int.
2800
2801 * termcap.c: Don't assume sizes fit in int and never overflow.
2802 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2803 (gobble_line): Check for size-calculation overflow.
2804
2805 * minibuf.c (Fread_buffer):
2806 * lread.c (intern, intern_c_string):
2807 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2808 Don't assume string length fits in int.
2809
2810 * keyboard.c (parse_tool_bar_item):
2811 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2812
2813 * font.c: Don't assume string length fits in int.
2814 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2815 Use ptrdiff_t, not int.
2816 (font_intern_prop): Don't assume string length fits in int.
2817 Don't assume integer property fits in fixnum.
2818 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2819
2820 * filelock.c: Fix some buffer overrun and integer overflow issues.
2821 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2822 Reformulate so as not to need the command string.
2823 Invoke gzip -cd rather than gunzip, as it's more portable.
2824 (lock_info_type, lock_file_1, lock_file):
2825 Don't assume pid_t and time_t fit in unsigned long.
2826 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2827 (current_lock_owner): Prefer signed type for sizes.
2828 Use memcpy, not strncpy, where memcpy is what is really wanted.
2829 Don't assume (via atoi) that time_t and pid_t fit in int.
2830 Check for time_t and/or pid_t out of range, e.g., via a network share.
2831 Don't alloca where an auto var works fine.
2832
2833 * fileio.c: Fix some integer overflow issues.
2834 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2835 Don't assume string length fits in int.
2836 (directory_file_name): Don't assume string length fits in long.
2837 (make_temp_name): Don't assume pid fits in int, or that its print
2838 length is less than 20.
2839
2840 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2841
2842 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2843
2844 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2845
2846 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2847 We prefer signed integers, even for size calculations.
2848
2849 * emacs.c: Don't assume string length fits in 'int'.
2850 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2851 (main): Don't invoke strlen when not needed.
2852
2853 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2854 (XD_DEBUG_MESSAGE): Don't waste a byte.
2855
2856 * callproc.c (getenv_internal_1, getenv_internal)
2857 (Fgetenv_internal):
2858 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2859
2860 * lread.c (invalid_syntax): Omit length argument.
2861 All uses changed. This doesn't fix a bug, but it simplifies the
2862 code away from its former Hollerith-constant appearance, and it's
2863 one less 'int' to worry about when looking at integer-overflow issues.
2864 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2865
2866 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2867 This didn't break anything, but it didn't help either.
2868 It's confusing to put a bogus integer in a place where the actual
2869 value does not matter.
2870 (LIST_END_P): Remove unused macro and its bogus comment.
2871 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2872
2873 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2874 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2875 implementation.
2876 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2877 We prefer signed types, and the value cannot exceed the EMACS_INT
2878 range anyway (because otherwise the length would not be representable).
2879 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2880 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2881 This avoids a GCC warning when WIDE_EMACS_INT.
2882
2883 * indent.c (sane_tab_width): New function.
2884 (current_column, scan_for_column, Findent_to, position_indentation)
2885 (compute_motion): Use it. This is just for clarity.
2886 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2887
2888 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2889
2890 * lisp.h (lint_assume): New macro.
2891 * composite.c (composition_gstring_put_cache):
2892 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2893
2894 * editfns.c, insdel.c:
2895 Omit unnecessary forward decls, to simplify future changes.
2896
2897 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2898
2899 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2900
2901 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2902 Use much-faster test for byte-length change.
2903 Don't assume string byte-length fits in 'int'.
2904 Check that character arg fits in 'int'.
2905 (mapcar1): Declare byte as byte, for clarity.
2906
2907 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2908
2909 * fns.c (concat): Catch string overflow earlier.
2910 Do not rely on integer wraparound.
2911
2912 * dispextern.h (struct it.overlay_strings_charpos)
2913 (struct it.selective): Now EMACS_INT, not int.
2914 * xdisp.c (forward_to_next_line_start)
2915 (back_to_previous_visible_line_start)
2916 (reseat_at_next_visible_line_start, next_element_from_buffer):
2917 Don't arbitrarily truncate the value of 'selective' to int.
2918
2919 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2920
2921 * composite.c: Don't truncate sizes to 'int'.
2922 (composition_gstring_p, composition_reseat_it)
2923 (composition_adjust_point): Use EMACS_INT, not int.
2924 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2925 not EMACS_UINT, for indexes.
2926
2927 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2928
2929 * buffer.c: Include <verify.h>.
2930 (struct sortvec.priority, struct sortstr.priority):
2931 Now EMACS_INT, not int.
2932 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2933 (struct sortstr.size, record_overlay_string)
2934 (struct sortstrlist.size, struct sortlist.used):
2935 Don't truncate size to int.
2936 (record_overlay_string): Check for size-calculation overflow.
2937 (init_buffer_once): Check at compile-time, not run-time.
2938
2939 2011-06-22 Jim Meyering <meyering@redhat.com>
2940
2941 Don't leak an XBM-image-sized buffer
2942 * image.c (xbm_load): Free the image buffer after using it.
2943
2944 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2945
2946 Port to Sun C.
2947 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2948 that Sun C diagnosed.
2949 * fns.c (secure_hash): Fix pointer signedness issue.
2950 * intervals.c (static_offset_intervals): New function.
2951 (offset_intervals): Use it.
2952
2953 2011-06-21 Leo Liu <sdl.web@gmail.com>
2954
2955 * deps.mk (fns.o):
2956 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2957 sha512.h.
2958
2959 * fns.c (secure_hash): Rename from crypto_hash_function and change
2960 the first arg to accept symbols.
2961 (Fsecure_hash): New primitive.
2962 (syms_of_fns): New symbols.
2963
2964 2011-06-20 Deniz Dogan <deniz@dogan.se>
2965
2966 * process.c (Fset_process_buffer): Clarify return value in
2967 docstring.
2968
2969 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2970
2971 * dispnew.c (add_window_display_history): Use BVAR.
2972
2973 * xdisp.c (debug_method_add): Use BVAR.
2974 (check_window_end, dump_glyph_matrix, dump_glyph)
2975 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2976
2977 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2978 Likewise.
2979
2980 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2981 check till after the cache is created in init_frame_faces.
2982
2983 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2984
2985 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2986
2987 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2988
2989 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2990 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2991 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2992
2993 Improve buffer-overflow checking (Bug#8873).
2994 * fileio.c (Finsert_file_contents):
2995 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2996 Remove the old (too-loose) buffer overflow checks.
2997 They weren't needed, since make_gap checks for buffer overflow.
2998 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2999 The old code merely checked for Emacs fixnum overflow, and relied
3000 on undefined (wraparound) behavior. The new code avoids undefined
3001 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3002
3003 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3004 Tune. Don't use wider integers than needed. Don't use alloca.
3005 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3006
3007 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3008
3009 * insdel.c, lisp.h (buffer_overflow): New function.
3010 (insert_from_buffer_1, replace_range, replace_range_2):
3011 * insdel.c (make_gap_larger):
3012 * editfns.c (Finsert_char):
3013 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3014
3015 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3016
3017 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3018
3019 Integer overflow and signedness fixes (Bug#8873).
3020
3021 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3022 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3023
3024 * fileio.c: Don't assume EMACS_INT fits in off_t.
3025 (emacs_lseek): New static function.
3026 (Finsert_file_contents, Fwrite_region): Use it.
3027 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3028
3029 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3030
3031 * fns.c: Don't overflow int when computing a list length.
3032 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3033 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3034 truncation on 64-bit hosts. Check for QUIT every
3035 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3036 faster and is responsive enough.
3037 (Flength): Report an error instead of overflowing an integer.
3038 (Fsafe_length): Return a float if the value is not representable
3039 as a fixnum. This shouldn't happen except in contrived situations.
3040 (Fnthcdr, Fsort): Don't assume list length fits in int.
3041 (Fcopy_sequence): Don't assume vector length fits in int.
3042
3043 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3044 (header_size, word_size): New constants.
3045 (allocate_vectorlike): Don't check size overflow here.
3046 (allocate_vector): Check it here instead, since this is the only
3047 caller of allocate_vectorlike that could cause overflow.
3048 Check that the new vector's length is representable as a fixnum.
3049
3050 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3051 The previous code was bogus. For example, next_almost_prime (32)
3052 returned 39, which is undesirable as it is a multiple of 3; and
3053 next_almost_prime (24) returned 25, which is a multiple of 5 so
3054 why was the code bothering to check for multiples of 7?
3055
3056 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3057
3058 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3059
3060 Variadic C functions now count arguments with ptrdiff_t.
3061 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3062 Back then I didn't know that the Emacs coding style prefers signed int.
3063 Also, in the meantime I found a few more instances where arguments
3064 were being counted with int, which may truncate counts on 64-bit
3065 machines, or EMACS_INT, which may be unnecessarily wide.
3066 * lisp.h (struct Lisp_Subr.function.aMANY)
3067 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3068 Arg counts are now ptrdiff_t, not size_t.
3069 All variadic functions and their callers changed accordingly.
3070 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3071 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3072 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3073 * callint.c (Fcall_interactively): Check arg count for overflow,
3074 to avoid potential buffer overrun. Use signed char, not 'int',
3075 for 'varies' array, so that we needn't bother to check its size
3076 calculation for overflow.
3077 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3078 * eval.c (apply_lambda):
3079 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3080 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3081 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3082
3083 * callint.c (Fcall_interactively): Don't use index var as event count.
3084
3085 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3086 * mem-limits.h (SIZE): Remove; no longer used.
3087
3088 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3089
3090 Remove unnecessary casts.
3091 * xterm.c (x_term_init):
3092 * xfns.c (x_set_border_pixel):
3093 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3094 These aren't needed now that we assume ANSI C.
3095
3096 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3097 It's more likely to cause problems (due to unsigned overflow)
3098 than to cure them.
3099
3100 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3101
3102 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3103
3104 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3105
3106 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3107
3108 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3109
3110 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3111
3112 GLYPH_CODE_FACE returns EMACS_INT, not int.
3113 * dispextern.h (merge_faces):
3114 * xfaces.c (merge_faces):
3115 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3116 Don't assume EMACS_INT fits in int.
3117
3118 * character.h (CHAR_VALID_P): Remove unused parameter.
3119 * fontset.c, lisp.h, xdisp.c: All uses changed.
3120
3121 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3122
3123 * fns.c (concat): Minor tuning based on overflow analysis.
3124 This doesn't fix any bugs. Use int to hold character, instead
3125 of constantly refetching from Emacs object. Use XFASTINT, not
3126 XINT, for value known to be a character. Don't bother comparing
3127 a single byte to 0400, as it's always less.
3128
3129 * floatfns.c (Fexpt):
3130 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3131
3132 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3133 for characters.
3134
3135 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3136
3137 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3138 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3139 incorrectly succeed when S was a string, because 4294967386 was
3140 truncated before it was used.
3141
3142 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3143 Otherwise, an out-of-range integer could cause undefined behavior
3144 on a 64-bit host.
3145
3146 * composite.c: Use int, not EMACS_INT, for characters.
3147 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3148 EMACS_INT, for values that are known to be in character range.
3149 This doesn't fix any bugs but is the usual style inside Emacs and
3150 may generate better code on 32-bit machines.
3151
3152 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3153 This is for reasons similar to the recent CHAR_STRING fix.
3154 * charset.c (Fencode_char): Check that character arg is actually
3155 a character. Pass an int to ENCODE_CHAR.
3156 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3157 wider than 'int', as a compile-time check to prevent future regressions
3158 in this area.
3159
3160 * character.c (char_string): Remove unnecessary casts.
3161
3162 Make sure a 64-bit char is never passed to CHAR_STRING.
3163 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3164 by silently ignoring the top 32 bits, allowing some values
3165 that were far too large to be valid characters.
3166 * character.h: Include <verify.h>.
3167 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3168 arguments are no wider than unsigned, as a compile-time check
3169 to prevent future regressions in this area.
3170 * data.c (Faset):
3171 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3172 (Fsubst_char_in_region):
3173 * fns.c (concat):
3174 * xdisp.c (decode_mode_spec_coding):
3175 Adjust to CHAR_STRING's new requirement.
3176 * editfns.c (Finsert_char, Fsubst_char_in_region):
3177 * fns.c (concat): Check that character args are actually
3178 characters. Without this test, these functions did the wrong
3179 thing with wildly out-of-range values on 64-bit hosts.
3180
3181 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3182 These casts should not be needed on 32-bit hosts, either.
3183 * keyboard.c (read_char):
3184 * lread.c (Fload): Remove casts to unsigned.
3185
3186 * lisp.h (UNSIGNED_CMP): New macro.
3187 This fixes comparison bugs on 64-bit hosts.
3188 (ASCII_CHAR_P): Use it.
3189 * casefiddle.c (casify_object):
3190 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3191 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3192 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3193 * dispextern.h (FACE_FROM_ID):
3194 * keyboard.c (read_char): Use UNSIGNED_CMP.
3195
3196 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3197 not to EMACS_INT, to avoid GCC warning.
3198
3199 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3200
3201 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3202 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3203 isn't needed on 32-bit machines.
3204
3205 * buffer.c (Fgenerate_new_buffer_name):
3206 Use EMACS_INT for count, not int.
3207 (advance_to_char_boundary): Return EMACS_INT, not int.
3208
3209 * data.c (Qcompiled_function): Now static.
3210
3211 * window.c (window_body_lines): Now static.
3212
3213 * image.c (gif_load): Rename local to avoid shadowing.
3214
3215 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3216 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3217 * alloc.c (make_save_value): Integer argument is now of type
3218 ptrdiff_t, not int.
3219 (mark_object): Use ptrdiff_t, not int.
3220 * lisp.h (pD): New macro.
3221 * print.c (print_object): Use it.
3222
3223 * alloc.c: Use EMACS_INT, not int, to count objects.
3224 (total_conses, total_markers, total_symbols, total_vector_size)
3225 (total_free_conses, total_free_markers, total_free_symbols)
3226 (total_free_floats, total_floats, total_free_intervals)
3227 (total_intervals, total_strings, total_free_strings):
3228 Now EMACS_INT, not int. All uses changed.
3229 (Fgarbage_collect): Compute overall total using a double, so that
3230 integer overflow is less likely to be a problem. Check for overflow
3231 when converting back to an integer.
3232 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3233 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3234 These were 'int' variables that could overflow on 64-bit hosts;
3235 they were never used, so remove them instead of repairing them.
3236 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3237 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3238 Previously, this ceilinged at INT_MAX, but that doesn't work on
3239 64-bit machines.
3240 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3241
3242 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3243 (allocate_vectorlike): Check for ptrdiff_t overflow.
3244 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3245 when a (possibly-narrower) signed value would do just as well.
3246 We prefer using signed arithmetic, to avoid comparison confusion.
3247
3248 * alloc.c: Catch some string size overflows that we were missing.
3249 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3250 for convenience in STRING_BYTES_MAX.
3251 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3252 The definition here is exact; the one in lisp.h was approximate.
3253 (allocate_string_data): Check for string overflow. This catches
3254 some instances we weren't catching before. Also, it catches
3255 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3256 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3257 and ptrdiff_t and EMACS_INT are both 64 bits.
3258
3259 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3260 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3261 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3262
3263 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3264
3265 * alloc.c (Fmake_string): Check for out-of-range init.
3266
3267 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3268
3269 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3270
3271 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3272
3273 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3274 xg_get_default_scrollbar_width.
3275
3276 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3277 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3278 (style_changed_cb): Call update_theme_scrollbar_width and call
3279 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3280 all frames (Bug#8505).
3281 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3282 Call gtk_window_set_resizable if HAVE_GTK3.
3283 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3284 and height if HAVE_GTK3 (Bug#8505).
3285 (scroll_bar_width_for_theme): New variable.
3286 (update_theme_scrollbar_width): New function.
3287 (xg_get_default_scrollbar_width): Move code to
3288 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3289 (xg_initialize): Call update_theme_scrollbar_width.
3290
3291 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3292
3293 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3294
3295 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3296
3297 * frame.c (make_frame): Call other_buffer_safely instead of
3298 other_buffer.
3299
3300 * window.c (temp_output_buffer_show): Call display_buffer with
3301 second argument Vtemp_buffer_show_specifiers and reset latter
3302 immediately after the call.
3303 (Vtemp_buffer_show_specifiers): New variable.
3304 (auto_window_vscroll_p, next_screen_context_lines)
3305 (Vscroll_preserve_screen_position): Remove leading asterisks from
3306 doc-strings.
3307
3308 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3309
3310 Fix minor problems found by GCC 4.6.0 static checking.
3311 * buffer.c (Qclone_number): Remove for now, as it's unused.
3312 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3313 (record_buffer): Remove unused local.
3314 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3315 (set_frame_buffer_list): Remove; unused.
3316 * frame.h (other_visible_frames): Remove decl.
3317 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3318 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3319 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3320 if HAVE_GPM.
3321 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3322 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3323 Define only if HAVE_GPM.
3324 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3325 (update_hints_inhibit): Remove; never set. All uses removed.
3326 * widgetprv.h (emacsFrameClassRec): Remove decl.
3327 * window.c (delete_deletable_window): Now returns void, since it
3328 wasn't returning anything.
3329 (compare_window_configurations): Remove unused locals.
3330 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3331 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3332 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3333 the same widths as pointers. This follows up on the 2011-05-06 patch.
3334 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3335 * xterm.h: Likewise.
3336 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3337
3338 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3339
3340 * makefile.w32-in: Update dependencies.
3341 (LISP_H): Add lib/intprops.h.
3342
3343 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3344
3345 * image.c (gif_load): Add animation frame delay to the metadata.
3346 (syms_of_image): Use DEFSYM. New symbol `delay'.
3347
3348 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3349
3350 * window.c (delete_deletable_window): Re-add.
3351 (Fset_window_configuration): Rewrite to handle dead buffers and
3352 consequently deletable windows.
3353 (window_tree, Fwindow_tree): Remove. Supply functionality in
3354 window.el.
3355 (compare_window_configurations): Simplify code.
3356
3357 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3358
3359 * image.c (imagemagick_load_image): Fix type mismatch.
3360 (Fimagemagick_types): Likewise.
3361
3362 * window.h (replace_buffer_in_windows): Declare.
3363
3364 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3365
3366 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3367 Qclone_number. Remove external declaration of Qdelete_window.
3368 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3369 code.
3370 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3371 Run Qbuffer_list_update_hook if allowed.
3372 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3373 buffer list implementation.
3374 (other_buffer_safely): New function.
3375 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3376 calls to replace_buffer_in_windows and
3377 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3378 if allowed.
3379 (record_buffer): Inhibit quitting and rewrite using quittable
3380 functions. Run Qbuffer_list_update_hook if allowed.
3381 (Frecord_buffer, Funrecord_buffer): New functions.
3382 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3383 Move switch-to-buffer to window.el.
3384 (bury-buffer): Move to window.el.
3385 (Vbuffer_list_update_hook): New variable.
3386
3387 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3388 section.
3389
3390 * window.h (resize_frame_windows): Move up in code.
3391 (Fwindow_frame): Remove EXFUN.
3392 (replace_buffer_in_all_windows): Remove prototype.
3393 (replace_buffer_in_windows_safely): Add prototype.
3394
3395 * window.c: Declare Qdelete_window static again. Move down
3396 declaration of select_count.
3397 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3398 (Fother_window): Move to window.el.
3399 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3400 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3401 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3402 window.el.
3403 (replace_buffer_in_windows): Implement by calling
3404 Qreplace_buffer_in_windows.
3405 (replace_buffer_in_all_windows): Remove with some functionality
3406 moved into replace_buffer_in_windows_safely.
3407 (replace_buffer_in_windows_safely): New function.
3408 (select_window_norecord, select_frame_norecord): Move in front
3409 of run_window_configuration_change_hook. Remove now obsolete
3410 declarations.
3411 (Fset_window_buffer): Rewrite doc-string.
3412 Call Qrecord_window_buffer.
3413 (keys_of_window): Move binding for other-window to window.el.
3414
3415 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3416
3417 * dispextern.h (struct image): Replace data member, whose int_val
3418 and ptr_val fields were not used by anything, with a single
3419 lisp_val object.
3420
3421 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3422 (gif_clear_image, gif_load, imagemagick_load_image)
3423 (gs_clear_image, gs_load): Callers changed.
3424
3425 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3426
3427 * buffer.h: Include <time.h>, for time_t.
3428 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3429
3430 Fix minor problems found by static checking.
3431
3432 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3433
3434 Make identifiers static if they are not used in other modules.
3435 * data.c (Qcompiled_function, Qframe, Qvector):
3436 * image.c (QimageMagick, Qsvg):
3437 * minibuf.c (Qmetadata):
3438 * window.c (resize_window_check, resize_root_window): Now static.
3439 * window.h (resize_window_check, resize_root_window): Remove decls.
3440
3441 * window.c (window_deletion_count, delete_deletable_window):
3442 Remove; unused.
3443 (window_body_lines): Now static.
3444 (Fdelete_other_windows_internal): Mark vars as initialized.
3445 Make sure 'resize_failed' is initialized.
3446 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3447 (resize_window_apply): Remove unused local.
3448 * window.h (delete_deletable_window): Remove decl.
3449
3450 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3451 (imagemagick_load_image): Fix pointer signedness problem by changing
3452 last arg from unsigned char * to char *. All uses changed.
3453 Also, fix a local for similar reasons.
3454 Remove unused locals. Remove locals to avoid shadowing.
3455 (fn_rsvg_handle_free): Remove; unused.
3456 (svg_load, svg_load_image): Fix pointer signedness problem.
3457 (imagemagick_load_image): Don't use garbage pointer image_wand.
3458
3459 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3460
3461 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3462
3463 * image.c (gif_load): Fix omitted cast error introduced by
3464 2011-06-06 change.
3465
3466 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3467
3468 * window.h (resize_proportionally, orig_total_lines)
3469 (orig_top_line): Remove from window structure.
3470 (set_window_height, set_window_width, change_window_heights)
3471 (Fdelete_window): Remove prototypes.
3472 (resize_frame_windows): Remove duplicate declaration.
3473
3474 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3475
3476 * window.h (resize_frame_windows, resize_window_check)
3477 (delete_deletable_window, resize_root_window)
3478 (resize_frame_windows): Declare prototypes.
3479
3480 * window.c (resize_window_apply): Make definition be "static" to
3481 match the prototype.
3482
3483 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3484
3485 * window.c: Remove declarations of Qwindow_size_fixed,
3486 window_min_size_1, window_min_size_2, window_min_size,
3487 size_window, window_fixed_size_p, enlarge_window, delete_window.
3488 Remove static from declaration of Qdelete_window, it's
3489 temporarily needed by Fbury_buffer.
3490 (replace_window): Don't assign orig_top_line and
3491 orig_total_lines.
3492 (Fdelete_window, delete_window): Remove. Window deletion is
3493 handled by window.el.
3494 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3495 Replace Fdelete_window calls with calls to Qdelete_window.
3496 (Fdelete_other_windows): Remove. Deleting other windows is
3497 handled by window.el.
3498 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3499 handled in window.el.
3500 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3501 Window minimum sizes are handled in window.el.
3502 (shrink_windows, size_window, set_window_height)
3503 (set_window_width, change_window_heights, window_height)
3504 (window_width, CURBEG, CURSIZE, enlarge_window)
3505 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3506 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3507 handled in window.el.
3508 (make_dummy_parent): Rename to make_parent_window and give it a
3509 second argument horflag.
3510 (make_window): Don't set resize_proportionally any more.
3511 (Fsplit_window): Remove. Windows are split in window.el.
3512 (save_restore_action, save_restore_orig_size)
3513 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3514 Resize mini windows in window.el.
3515 (grow_mini_window, shrink_mini_window): Implement by calling
3516 Qresize_root_window_vertically, resize_window_check and
3517 resize_window_apply.
3518 (saved_window, Fset_window_configuration, save_window_save):
3519 Do not handle orig_top_line, orig_total_lines, and
3520 resize_proportionally.
3521 (window_min_height, window_min_width): Move to window.el.
3522 (keys_of_window): Move bindings for delete-other-windows,
3523 split-window, delete-window and enlarge-window to window.el.
3524
3525 * buffer.c: Temporarily extern Qdelete_window.
3526 (Fbury_buffer): Temporarily call Qdelete_window instead of
3527 Fdelete_window (Fbury_buffer will move to window.el soon).
3528
3529 * frame.c (set_menu_bar_lines_1): Remove code handling
3530 orig_top_line and orig_total_lines.
3531
3532 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3533 set_window_height but set heights directly.
3534 (change_frame_size_1): Use resize_frame_windows.
3535
3536 * xdisp.c (init_xdisp): Don't use set_window_height but set
3537 heights directly.
3538
3539 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3540 Use resize_frame_windows instead of change_window_heights and run
3541 run_window_configuration_change_hook.
3542
3543 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3544 instead of change_window_heights and run
3545 run_window_configuration_change_hook.
3546
3547 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3548
3549 * window.c (replace_window): Rename second argument REPLACEMENT to
3550 NEW. New third argument SETFLAG. Rewrite.
3551 (delete_window, make_dummy_parent): Call replace_window with
3552 third argument 1.
3553 (window_list_1): Move down in code.
3554 (run_window_configuration_change_hook): Move set_buffer part
3555 before select_frame_norecord part in order to unwind correctly.
3556 Rename count1 to count.
3557 (recombine_windows, delete_deletable_window, resize_root_window)
3558 (Fdelete_other_windows_internal)
3559 (Frun_window_configuration_change_hook, make_parent_window)
3560 (resize_window_check, resize_window_apply, Fresize_window_apply)
3561 (resize_frame_windows, Fsplit_window_internal)
3562 (Fdelete_window_internal, Fresize_mini_window_internal):
3563 New functions.
3564 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3565
3566 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3567
3568 * window.h (window): Add some new members to window structure -
3569 normal_lines, normal_cols, new_total, new_normal, clone_number,
3570 splits, nest, prev_buffers, next_buffers.
3571 (WINDOW_TOTAL_SIZE): Move here from window.c.
3572 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3573
3574 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3575 Remove.
3576 (make_dummy_parent): Set new members of windows structure.
3577 (make_window): Move down in code. Handle new members of window
3578 structure.
3579 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3580 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3581 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3582 (Fset_window_prev_buffers, Fwindow_next_buffers)
3583 (Fset_window_next_buffers, Fset_window_clone_number):
3584 New functions.
3585 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3586 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3587 Doc-string fixes.
3588 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3589 Argument WINDOW can be now internal window too.
3590 (Fwindow_use_time): Move up in code.
3591 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3592 Rewrite doc-string.
3593 (Fset_window_configuration, saved_window)
3594 (Fcurrent_window_configuration, save_window_save): Handle new
3595 members of window structure.
3596 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3597 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3598 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3599 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3600 Qget_mru_window, Qresize_root_window,
3601 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3602 Qauto_buffer_name; staticpro them.
3603
3604 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3605
3606 * window.c (Fwindow_total_size, Fwindow_left_column)
3607 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3608 (Fwindow_list_1): New functions.
3609 (window_box_text_cols): Replace with window_body_cols.
3610 (Fwindow_width, Fscroll_left, Fscroll_right):
3611 Use window_body_cols instead of window_box_text_cols.
3612 (delete_window, Fset_window_configuration):
3613 Call delete_all_subwindows with window as argument.
3614 (delete_all_subwindows): Take a window as argument and not a
3615 structure. Rewrite.
3616 (window_loop): Remove handling of GET_LRU_WINDOW and
3617 GET_LARGEST_WINDOW.
3618 (Fget_lru_window, Fget_largest_window): Move to window.el.
3619
3620 * window.h: Extern window_body_cols instead of
3621 window_box_text_cols. delete_all_subwindows now takes a
3622 Lisp_Object as argument.
3623
3624 * indent.c (compute_motion, Fcompute_motion):
3625 Use window_body_cols instead of window_box_text_cols.
3626
3627 * frame.c (delete_frame): Call delete_all_subwindows with root
3628 window as argument.
3629
3630 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3631
3632 * fns.c (Fputhash): Document return value.
3633
3634 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3635
3636 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3637
3638 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3639
3640 Cons<->int and similar integer overflow fixes (Bug#8794).
3641
3642 Check for overflow when converting integer to cons and back.
3643 * charset.c (Fdefine_charset_internal, Fdecode_char):
3644 Use cons_to_unsigned to catch overflow.
3645 (Fencode_char): Use INTEGER_TO_CONS.
3646 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3647 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3648 * data.c (long_to_cons, cons_to_long): Remove.
3649 (cons_to_unsigned, cons_to_signed): New functions.
3650 These signal an error for invalid or out-of-range values.
3651 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3652 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3653 * font.c (Ffont_variation_glyphs):
3654 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3655 * lisp.h: Include <intprops.h>.
3656 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3657 (cons_to_signed, cons_to_unsigned): New decls.
3658 (long_to_cons, cons_to_long): Remove decls.
3659 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3660 (Fprimitive_undo): Use CONS_TO_INTEGER.
3661 * xfns.c (Fx_window_property): Likewise.
3662 * xselect.c: Include <limits.h>.
3663 (x_own_selection, selection_data_to_lisp_data):
3664 Use INTEGER_TO_CONS.
3665 (x_handle_selection_request, x_handle_selection_clear)
3666 (x_get_foreign_selection, Fx_disown_selection_internal)
3667 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3668 (lisp_data_to_selection_data): Use cons_to_unsigned.
3669 (x_fill_property_data): Use cons_to_signed.
3670 Report values out of range.
3671
3672 Check for buffer and string overflow more precisely.
3673 * buffer.h (BUF_BYTES_MAX): New macro.
3674 * lisp.h (STRING_BYTES_MAX): New macro.
3675 * alloc.c (Fmake_string):
3676 * character.c (string_escape_byte8):
3677 * coding.c (coding_alloc_by_realloc):
3678 * doprnt.c (doprnt):
3679 * editfns.c (Fformat):
3680 * eval.c (verror):
3681 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3682 since they may not be the same number.
3683 * editfns.c (Finsert_char):
3684 * fileio.c (Finsert_file_contents):
3685 Likewise for BUF_BYTES_MAX.
3686
3687 * image.c: Use ptrdiff_t, not int, for sizes.
3688 (slurp_file): Switch from int to ptrdiff_t.
3689 All uses changed.
3690 (slurp_file): Check that file size fits in both size_t (for
3691 malloc) and ptrdiff_t (for sanity and safety).
3692
3693 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3694 if b->modtime has its maximal value.
3695
3696 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3697
3698 Don't assume time_t can fit into int.
3699 * buffer.h (struct buffer.modtime): Now time_t, not int.
3700 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3701 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3702
3703 Minor fixes for signed vs unsigned integers.
3704 * character.h (MAYBE_UNIFY_CHAR):
3705 * charset.c (maybe_unify_char):
3706 * keyboard.c (read_char, reorder_modifiers):
3707 XINT -> XFASTINT, since the integer must be nonnegative.
3708 * ftfont.c (ftfont_spec_pattern):
3709 * keymap.c (access_keymap, silly_event_symbol_error):
3710 XUINT -> XFASTINT, since the integer must be nonnegative.
3711 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3712 since it makes no difference and we prefer signed.
3713 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3714 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3715 nonnegative.
3716
3717 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3718
3719 * window.h (Fwindow_frame): Declare.
3720
3721 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3722
3723 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3724 (SPARE_MEMORY): Always define.
3725 (LARGE_REQUEST): Remove.
3726 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3727
3728 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3729
3730 * lisp.h: Move EXFUNS for Fframe_root_window,
3731 Fframe_first_window and Fset_frame_selected_window to window.h.
3732
3733 * window.h: Move EXFUNS for Fframe_root_window,
3734 Fframe_first_window and Fset_frame_selected_window here from
3735 lisp.h.
3736
3737 * frame.c (Fwindow_frame, Fframe_first_window)
3738 (Fframe_root_window, Fframe_selected_window)
3739 (Fset_frame_selected_window): Move to window.c.
3740 (Factive_minibuffer_window): Move to minibuf.c.
3741 (Fother_visible_frames_p): New function.
3742
3743 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3744
3745 * window.c (decode_window, decode_any_window): Move up in code.
3746 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3747 (inhibit_frame_unsplittable): Remove unused variable.
3748 (Fwindow_buffer): Move up and rewrite doc-string.
3749 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3750 (Fwindow_prev): New functions.
3751 (Fwindow_frame): Move here from frame.c. Accept any window as
3752 argument.
3753 (Fframe_root_window, Fframe_first_window)
3754 (Fframe_selected_window): Move here from frame.c. Accept frame
3755 or arbitrary window as argument. Update doc-strings.
3756 (Fminibuffer_window): Move up in code.
3757 (Fwindow_minibuffer_p): Move up in code and simplify.
3758 (Fset_frame_selected_window): Move here from frame.c.
3759 Marginal rewrite.
3760 (Fselected_window, select_window, Fselect_window): Move up in
3761 code. Minor doc-string fixes.
3762
3763 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3764
3765 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3766 Do not assume that spare memory exists; that assumption is valid
3767 only if SYSTEM_MALLOC.
3768 (LARGE_REQUEST): New macro, so that the issue of large requests
3769 is separated from the issue of spare memory.
3770
3771 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3772
3773 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3774 format. (Bug#8806)
3775
3776 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3777
3778 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3779 before statements.
3780
3781 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3782
3783 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3784
3785 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3786
3787 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3788 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3789
3790 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3791
3792 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3793
3794 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3795
3796 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3797 (x_clipboard_manager_save): Add return value.
3798 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3799 New error handlers.
3800 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3801 Obey Vx_select_enable_clipboard_manager. Catch errors in
3802 x_clipboard_manager_save (Bug#8779).
3803 (Vx_select_enable_clipboard_manager): New variable.
3804 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3805
3806 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3807
3808 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3809
3810 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3811
3812 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3813 in the current matrix if keep_current_p is non-zero.
3814
3815 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3816
3817 * bidi.c (bidi_level_of_next_char): Fix last change.
3818
3819 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3820
3821 Support bidi reordering of text covered by display properties.
3822
3823 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3824 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3825 (bidi_cache_search, bidi_cache_iterator_state)
3826 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3827 (bidi_level_of_next_char, bidi_move_to_visually_next):
3828 Support character positions inside a run of characters covered by a
3829 display string.
3830 (bidi_paragraph_init, bidi_resolve_explicit_1)
3831 (bidi_level_of_next_char): Call bidi_fetch_char and
3832 bidi_fetch_char_advance instead of FETCH_CHAR and
3833 FETCH_CHAR_ADVANCE.
3834 (bidi_init_it): Initialize new members.
3835 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3836 definitions.
3837 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3838 instead of using explicit *_CHAR codes.
3839 (bidi_resolve_explicit, bidi_resolve_weak):
3840 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3841 bidirectional text is supported only in multibyte buffers.
3842 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3843 it to initialize the frame_window_p member of struct bidi_it.
3844 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3845 (bidi_resolve_explicit, bidi_resolve_weak)
3846 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3847 bidi_it->nchars is non-positive.
3848 (bidi_level_of_next_char): Don't try to lookup the cache for the
3849 next/previous character if nothing is cached there yet, or if we
3850 were just reseat()'ed to a new position.
3851
3852 * xdisp.c (set_cursor_from_row): Set start and stop points
3853 according to the row's direction when priming the loop that looks
3854 for the glyph on which to display cursor.
3855 (single_display_spec_intangible_p): Function deleted.
3856 (display_prop_intangible_p): Reimplement to call
3857 handle_display_spec instead of single_display_spec_intangible_p.
3858 Accept 3 additional arguments needed by handle_display_spec.
3859 This fixes incorrect cursor motion across display property with complex
3860 values: lists, `(when COND...)' forms, etc.
3861 (single_display_spec_string_p): Support property values that are
3862 lists with the argument STRING its top-level element.
3863 (display_prop_string_p): Fix the condition for processing a
3864 property that is a list to be consistent with handle_display_spec.
3865 (handle_display_spec): New function, refactored from the
3866 last portion of handle_display_prop.
3867 (compute_display_string_pos): Accept additional argument
3868 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3869 value of a `display' property is a "replacing spec".
3870 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3871 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3872 the display property, but just return a value indicating whether
3873 the display property will replace the characters it covers.
3874 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3875 frame_window_p members of struct bidi_it.
3876 (compute_display_string_pos, compute_display_string_end):
3877 New functions.
3878 (push_it): Accept second argument POSITION, where pop_it should
3879 jump to continue iteration.
3880 (reseat_1): Initialize bidi_it.disp_pos.
3881
3882 * keyboard.c (adjust_point_for_property): Adjust the call to
3883 display_prop_intangible_p to its new signature.
3884
3885 * dispextern.h (struct bidi_it): New member frame_window_p.
3886 (bidi_init_it): Update prototypes.
3887 (display_prop_intangible_p): Update prototype.
3888 (compute_display_string_pos, compute_display_string_end):
3889 Declare prototypes.
3890 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3891 EMACS_INT.
3892
3893 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3894
3895 Malloc failure behavior now depends on size of allocation.
3896 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3897 * lisp.h: Change signatures accordingly.
3898 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3899 All callers changed. (Bug#8762)
3900
3901 * gnutls.c: Use Emacs's memory allocators.
3902 Without this change, the gnutls library would invoke malloc etc.
3903 directly, which causes problems on non-SYNC_INPUT hosts, and which
3904 runs afoul of improving memory_full behavior. (Bug#8761)
3905 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3906 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3907 xfree instead of the default malloc, realloc, free.
3908 (Fgnutls_boot): No need to check for memory allocation failure,
3909 since xmalloc does that for us.
3910
3911 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3912 * category.c (hash_get_category_set):
3913 * ccl.c (ccl_driver):
3914 * charset.c (Fdefine_charset_internal):
3915 * charset.h (struct charset.hash_index):
3916 * composite.c (get_composition_id, gstring_lookup_cache)
3917 (composition_gstring_put_cache):
3918 * composite.h (struct composition.hash_index):
3919 * dispextern.h (struct image.hash):
3920 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3921 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3922 (hashfn_equal, hashfn_user_defined, make_hash_table)
3923 (maybe_resize_hash_table, hash_lookup, hash_put)
3924 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3925 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3926 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3927 * image.c (make_image, search_image_cache, lookup_image)
3928 (xpm_put_color_table_h):
3929 * lisp.h (struct Lisp_Hash_Table):
3930 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3931 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3932 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3933 * alloc.c (allocate_vectorlike):
3934 Check for overflow in vector size calculations.
3935 * ccl.c (ccl_driver):
3936 Check for overflow when converting EMACS_INT to int.
3937 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3938 need to be updated by these changes.
3939 * fns.c (make_hash_table, maybe_resize_hash_table):
3940 Check for integer overflow with large hash tables.
3941 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3942 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3943 (SXHASH_REDUCE): New macro.
3944 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3945 Use it instead of discarding useful hash info with large hash values.
3946 (sxhash_float): New function.
3947 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3948 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3949 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3950 Rewrite to use FIXNUM_BITS, as this simplifies things.
3951 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3952 Adjust signatures to match updated version of code.
3953 (consing_since_gc): Now EMACS_INT, since a single hash table can
3954 use more than INT_MAX bytes.
3955
3956 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3957
3958 Make it possible to build with GCC-4.6+ -O2 -flto.
3959
3960 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3961
3962 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3963
3964 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3965 Call minibuffer-inactive-mode.
3966
3967 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3968
3969 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3970 Update dependencies.
3971
3972 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3973
3974 * data.c (init_data): Remove code for UTS, this system is not
3975 supported anymore.
3976
3977 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3978
3979 Don't force ./temacs to start in terminal mode.
3980
3981 * frame.c (make_initial_frame): Initialize faces in all cases, not
3982 only when CANNOT_DUMP is defined.
3983 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3984
3985 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3986
3987 * dispnew.c (add_window_display_history): Use const for the string
3988 pointer. Remove declaration, not needed.
3989
3990 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3991
3992 Use 'inline', not 'INLINE'.
3993 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3994 * alloc.c, fontset.c (INLINE): Remove.
3995 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3996 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3997 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3998 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3999 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4000
4001 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4002
4003 Make it possible to run ./temacs.
4004
4005 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4006 syms_of_callproc does the same thing. Remove test for
4007 "initialized", do it in the caller.
4008 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4009
4010 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4011
4012 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4013 (read_minibuf): Use get_minibuffer.
4014 (syms_of_minibuf): Use DEFSYM.
4015 (Qmetadata): New var.
4016 * data.c (Qbuffer): Don't make it static.
4017 (syms_of_data): Use DEFSYM.
4018
4019 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4020
4021 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4022 (CCL_CODE_MIN): New macro.
4023
4024 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4025
4026 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4027
4028 * eval.c (Qdebug): Now static.
4029 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4030 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4031 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4032
4033 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4034
4035 * image.c: Various fixes to ImageMagick code comments.
4036 (Fimagemagick_types): Doc fix.
4037
4038 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4039
4040 Minor fixes prompted by GCC 4.6.0 warnings.
4041
4042 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4043
4044 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4045 (x_clipboard_manager_save_all): Move extern decl to ...
4046 * xterm.h: ... here, so that it can be checked for consistency.
4047
4048 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4049
4050 * xselect.c (x_clipboard_manager_save_frame)
4051 (x_clipboard_manager_save_all): New functions.
4052 (Fx_clipboard_manager_save): Lisp function deleted.
4053
4054 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4055 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4056
4057 * xterm.h: Update prototype.
4058
4059 2011-05-28 William Xu <william.xwl@gmail.com>
4060
4061 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4062 exiting (Bug#8239).
4063
4064 2011-05-28 Jim Meyering <meyering@redhat.com>
4065
4066 Avoid a sign-extension bug in crypto_hash_function.
4067 * fns.c (to_uchar): Define.
4068 (crypto_hash_function): Use it to convert some newly-signed
4069 variables to unsigned, to avoid sign-extension bugs. For example,
4070 without this change, (md5 "truc") would evaluate to
4071 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4072 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4073 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4074
4075 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4076
4077 Integer overflow fixes.
4078
4079 * dbusbind.c: Serial number integer overflow fixes.
4080 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4081 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4082 to hold a serial number that is too large for a fixnum.
4083 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4084 Check for serial numbers out of range. Decode any serial number
4085 that was so large that it became a float. (Bug#8722)
4086
4087 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4088 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4089 Use XFASTINT rather than XUINT when numbers are nonnegative.
4090 (xd_append_arg, Fdbus_method_return_internal):
4091 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4092 arguments, check that Lisp number is nonnegative, rather than
4093 silently wrapping negative numbers around. (Bug#8722)
4094 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4095 (Bug#8722)
4096
4097 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4098
4099 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4100
4101 ccl: add integer overflow checks
4102 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4103 (IN_INT_RANGE): New macros.
4104 (ccl_driver): Use them to check for integer overflow when
4105 decoding a CCL program. Many of the new checks are whether XINT (x)
4106 fits in int; it doesn't always, on 64-bit hosts. The new version
4107 doesn't catch all possible integer overflows, but it's an
4108 improvement. (Bug#8719)
4109
4110 * alloc.c (make_event_array): Use XINT, not XUINT.
4111 There's no need for unsigned here.
4112
4113 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4114 This follows up to the 2011-05-06 change that substituted uintptr_t
4115 for EMACS_INT. This case wasn't caught back then.
4116
4117 Rework Fformat to avoid integer overflow issues.
4118 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4119 now (part of C89). Include <verify.h>.
4120 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4121 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4122 (Fformat): Avoid the prepass trying to compute sizes; it was only
4123 approximate and thus did not catch overflow reliably. Instead, walk
4124 through the format just once, formatting and computing sizes as we go,
4125 checking for integer overflow at every step, and allocating a larger
4126 buffer as needed. Keep track separately whether the format is
4127 multibyte. Keep only the most-recently calculated precision, rather
4128 than them all. Record whether each argument has been converted to
4129 string. Use EMACS_INT, not int, for byte and char and arg counts.
4130 Support field widths and precisions larger than INT_MAX. Avoid
4131 sprintf's undefined behavior with conversion specifications such as %#d
4132 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4133 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4134 formatting out-of-range floating point numbers with int
4135 formats. (Bug#8668)
4136
4137 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4138
4139 * data.c: Avoid integer truncation in expressions involving floats.
4140 * data.c: Include <intprops.h>.
4141 (arith_driver): When there's an integer overflow in an expression
4142 involving floating point, convert the integers to floating point
4143 so that the resulting value does not suffer from catastrophic
4144 integer truncation. For example, on a 64-bit host (* 4
4145 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4146 Do not rely on undefined behavior after integer overflow.
4147
4148 merge count_size_as_multibyte, parse_str_to_multibyte
4149 * character.c, character.h (count_size_as_multibyte):
4150 Rename from parse_str_to_multibyte; all uses changed.
4151 Check for integer overflow.
4152 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4153 since it's now a duplicate of the other. This is more of
4154 a character than a buffer op, so better that it's in character.c.
4155 * fns.c, print.c: Adjust to above changes.
4156
4157 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4158
4159 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4160
4161 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4162
4163 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4164 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4165 (x_clipboard_manager_save): Now static.
4166 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4167
4168 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4169 (crypto_hash_function): Now static.
4170 Fix pointer signedness problems. Avoid unnecessary initializations.
4171
4172 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4173
4174 * termhooks.h (Vselection_alist): Make it terminal-local.
4175
4176 * terminal.c (create_terminal): Initialize it.
4177
4178 * xselect.c: Support for clipboard managers.
4179 (Vselection_alist): Move to termhooks.h as terminal-local var.
4180 (LOCAL_SELECTION): New macro.
4181 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4182 (symbol_to_x_atom): Remove gratuitous arg.
4183 (x_handle_selection_request, lisp_data_to_selection_data)
4184 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4185 (x_own_selection, x_get_local_selection, x_convert_selection):
4186 New arg, specifying work frame. Use terminal-local Vselection_alist.
4187 (some_frame_on_display): Delete unused function.
4188 (Fx_own_selection_internal, Fx_get_selection_internal)
4189 (Fx_disown_selection_internal, Fx_selection_owner_p)
4190 (Fx_selection_exists_p): New optional frame arg.
4191 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4192 (x_handle_selection_clear): Don't treat other terminals with the
4193 same keyboard specially. Use the terminal-local Vselection_alist.
4194 (x_clear_frame_selections): Use Frun_hook_with_args.
4195
4196 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4197
4198 * xterm.h: Add support for those atoms.
4199
4200 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4201
4202 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4203 (converted_selections, conversion_fail_tag): New global variables.
4204 (x_selection_request_lisp_error): Free the above.
4205 (x_get_local_selection): Remove unnecessary code.
4206 (x_reply_selection_request): Args changed; handle arbitrary array
4207 of converted selections stored in converted_selections.
4208 Separate the XChangeProperty and SelectionNotify steps.
4209 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4210 (x_convert_selection): New function.
4211 (x_handle_selection_event): Simplify.
4212 (x_get_foreign_selection): Don't ignore incoming requests while
4213 waiting for an answer; this will fail when we implement
4214 SAVE_TARGETS, and seems unnecessary anyway.
4215 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4216 (Vx_sent_selection_functions): Doc fix.
4217
4218 2011-05-26 Leo Liu <sdl.web@gmail.com>
4219
4220 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4221
4222 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4223
4224 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4225
4226 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4227 for fringe update if it has periodic bitmap.
4228 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4229 and fringe_bitmap_periodic_p.
4230
4231 * fringe.c (get_fringe_bitmap_data): New function.
4232 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4233 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4234 row. Mark glyph row for fringe update if periodicity changed.
4235
4236 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4237 for fringe update unless it has periodic bitmap.
4238
4239 2011-05-25 Kenichi Handa <handa@m17n.org>
4240
4241 * xdisp.c (get_next_display_element): Set correct it->face_id for
4242 a static composition.
4243
4244 2011-05-24 Leo Liu <sdl.web@gmail.com>
4245
4246 * deps.mk (fns.o):
4247 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4248
4249 * fns.c (crypto_hash_function, Fsha1): New function.
4250 (Fmd5): Use crypto_hash_function.
4251 (syms_of_fns): Add Ssha1.
4252
4253 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4254
4255 * gnutls.c: Remove unused macros.
4256 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4257 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4258 Remove macros that are defined and never used.
4259 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4260
4261 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4262
4263 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4264 (Fx_get_selection_internal): Minor cleanup.
4265 (Fx_own_selection_internal): Rename arguments for consistency with
4266 select.el.
4267
4268 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4269
4270 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4271
4272 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4273
4274 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4275
4276 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4277
4278 * dispnew.c (scrolling_window): Don't exclude the case that the
4279 last enabled row in the desired matrix touches the bottom boundary.
4280
4281 2011-05-21 Glenn Morris <rgm@gnu.org>
4282
4283 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4284 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4285 and add some more files.
4286
4287 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4288
4289 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4290 report_file_error introduced by the change from 2011-05-07.
4291
4292 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4293
4294 * systime.h (Time): Define only if emacs is defined.
4295 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4296 where the include path doesn't have X11/X.h by default. See
4297 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4298
4299 2011-05-20 Kenichi Handa <handa@m17n.org>
4300
4301 * composite.c (find_automatic_composition): Fix previous change.
4302
4303 2011-05-20 Glenn Morris <rgm@gnu.org>
4304
4305 * lisp.mk: New file, split from Makefile.in.
4306 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4307 (shortlisp): Remove.
4308 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4309
4310 2011-05-19 Glenn Morris <rgm@gnu.org>
4311
4312 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4313 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4314 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4315 (lisp): Set the order to that of loadup.el.
4316 (shortlisp): Make it a copy of $lisp.
4317 (SOME_MACHINE_LISP): Remove.
4318 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4319 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4320
4321 2011-05-18 Kenichi Handa <handa@m17n.org>
4322
4323 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4324 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4325 (find_automatic_composition): Mostly rewrite for efficiency.
4326
4327 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4328
4329 * makefile.w32-in: Update dependencies.
4330
4331 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4332
4333 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4334 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4335
4336 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4337
4338 Fix some integer overflow issues, such as string length overflow.
4339
4340 * insdel.c (count_size_as_multibyte): Check for string overflow.
4341
4342 * character.c (lisp_string_width): Check for string overflow.
4343 Use EMACS_INT, not int, for string indexes and lengths; in
4344 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4345 the resulting string length overflows an EMACS_INT; instead,
4346 report a string overflow if no precision given. When checking for
4347 precision exhaustion, use a check that cannot possibly have
4348 integer overflow. (Bug#8675)
4349 * character.h (lisp_string_width): Adjust to new signature.
4350
4351 * alloc.c (string_overflow): New function.
4352 (Fmake_string): Use it. This doesn't change behavior, but saves
4353 a few bytes and will simplify future changes.
4354 * character.c (string_escape_byte8): Likewise.
4355 * lisp.h (string_overflow): New decl.
4356
4357 Fixups, following up to the user-interface timestamp change.
4358 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4359 for UI timestamps, instead of unsigned long.
4360 * msdos.c (mouse_get_pos): Likewise.
4361 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4362 * w32gui.h (Time): Define by including "systime.h" rather than by
4363 declaring it ourselves. (Bug#8664)
4364
4365 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4366 * image.c (clear_image_cache): Likewise.
4367
4368 * term.c (term_mouse_position): Don't assume time_t wraparound.
4369
4370 Be more systematic about user-interface timestamps.
4371 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4372 and sometimes 'EMACS_UINT', to represent these timestamps.
4373 This change causes it to use 'Time' uniformly, as that's what X uses.
4374 This makes the code easier to follow, and makes it easier to catch
4375 integer overflow bugs such as Bug#8664.
4376 * frame.c (Fmouse_position, Fmouse_pixel_position):
4377 Use Time, not unsigned long, for user-interface timestamps.
4378 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4379 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4380 * keyboard.h (last_event_timestamp): Likewise.
4381 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4382 * menu.h (xmenu_show): Likewise.
4383 * term.c (term_mouse_position): Likewise.
4384 * termhooks.h (struct input_event.timestamp): Likewise.
4385 (struct terminal.mouse_position_hook): Likewise.
4386 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4387 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4388 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4389 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4390 what it was before.
4391 * menu.h, termhooks.h: Include "systime.h", for Time.
4392
4393 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4394 Don't assume that the difference between two unsigned long values
4395 can fit into an integer. At this point, we know button_down_time
4396 <= event->timestamp, so the difference must be nonnegative, so
4397 there's no need to cast the result if double-click-time is
4398 nonnegative, as it should be; check that it's nonnegative, just in
4399 case. This bug is triggered when events are more than 2**31 ms
4400 apart (about 25 days). (Bug#8664)
4401
4402 * xselect.c (last_event_timestamp): Remove duplicate decl.
4403 (x_own_selection): Remove needless cast to unsigned long.
4404
4405 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4406 that always fit in int. Use a sentinel instead of a counter, to
4407 avoid a temp and to allay GCC's concerns about possible int overflow.
4408 * frame.h (struct frame): Use int for menu_bar_items_used
4409 instead of EMACS_INT, since it always fits in int.
4410
4411 * menu.c (grow_menu_items): Check for int overflow.
4412
4413 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4414
4415 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4416 Before, the code was not consistent. These values cannot exceed
4417 2**31 - 1 so there's no need to make them unsigned.
4418 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4419 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4420 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4421 as modifiers.
4422 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4423
4424 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4425 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4426 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4427 presumably because the widths might not match.
4428
4429 * window.c (size_window): Avoid needless test at loop start.
4430
4431 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4432
4433 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4434
4435 2011-05-12 Drew Adams <drew.adams@oracle.com>
4436
4437 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4438
4439 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4440
4441 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4442 `width' to `bar_area_x' and `bar_area_width', respectively.
4443 (x_scroll_run): Take account of fringe background extension.
4444
4445 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4446 Rename local vars `left' and `width' to `bar_area_x' and
4447 `bar_area_width', respectively.
4448 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4449 background extension.
4450
4451 2011-05-10 Jim Meyering <meyering@redhat.com>
4452
4453 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4454
4455 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4456
4457 * image.c (Finit_image_library): Return t for built-in image types,
4458 like pbm and xbm. (Bug#8640)
4459
4460 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4461
4462 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4463
4464 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4465
4466 * w32console.c (Fset_screen_color): Doc fix.
4467 (Fget_screen_color): New function.
4468 (syms_of_ntterm): Defsubr it.
4469
4470 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4471 unlink the temporary file if Fcall_process didn't create it in the
4472 first place.
4473 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4474 child process will be redirected to a file specified with `:file'.
4475 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4476 cue to call_process_cleanup not to close that handle.
4477
4478 2011-05-07 Ben Key <bkey76@gmail.com>
4479
4480 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4481 one of two shell specific rules, either bootstrap-temacs-CMD or
4482 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4483 to the previous implementation of the bootstrap-temacs rule.
4484 The bootstrap-temacs-CMD rule is similar to the previous
4485 implementation of the bootstrap-temacs rule except that it
4486 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4487 variable.
4488
4489 These changes, along with some changes to nt/configure.bat,
4490 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4491 earlier fix to add support for --cflags and --ldflags options
4492 that include quotes so that it works whether make uses cmd or
4493 sh as the shell.
4494
4495 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4496
4497 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4498 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4499 is a constant.
4500 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4501 a string. Handle both cases.
4502 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4503 (Fdbus_register_method): Use Qinvalid_function.
4504
4505 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4506
4507 * makefile.w32-in: Update dependencies.
4508 (LISP_H): Add inttypes.h and stdin.h.
4509 (PROCESS_H): Add unistd.h.
4510
4511 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4512
4513 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4514 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4515
4516 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4517
4518 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4519
4520 * term.c (vfatal): Remove stray call to va_end.
4521 It's not needed and the C Standard doesn't allow it here anyway.
4522
4523 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4524 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4525
4526 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4527 bytes.
4528
4529 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4530
4531 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4532
4533 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4534
4535 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4536
4537 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4538
4539 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4540 * charset.c (Fdefine_charset_internal): Don't initialize
4541 charset.code_space[15]. The value was garbage, on hosts with
4542 32-bit int (Bug#8600).
4543
4544 * lread.c (read_integer): Be more consistent with string-to-number.
4545 Use string_to_number to do the actual conversion; this avoids
4546 rounding errors and fixes some other screwups. Without this fix,
4547 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4548 (digit_to_number): Move earlier, for benefit of read_integer.
4549 Return -1 if the digit is out of range for the base, -2 if it is
4550 not a digit in any supported base. (Bug#8602)
4551
4552 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4553
4554 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4555 to match comment at start of function. This also removes a
4556 GCC warning about overflow in a 32+64-bit port.
4557
4558 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4559
4560 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4561 Reported by Stefan Monnier in
4562 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4563 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4564 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4565
4566 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4567 (EMACS_UINTPTR): Likewise, with uintptr_t.
4568
4569 * lisp.h: Prefer 64-bit EMACS_INT if available.
4570 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4571 on 32-bit hosts that have 64-bit int, so that they can access
4572 large files.
4573 However, temporarily disable this change unless the temporary
4574 symbol WIDE_EMACS_INT is defined.
4575
4576 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4577
4578 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4579 This removes an assumption that EMACS_INT and long are the same
4580 width as pointers. The assumption is true for Emacs porting targets
4581 now, but we want to make other targets possible.
4582 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4583 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4584 In the rest of the code, change types of integers that hold casted
4585 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4586 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4587 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4588 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4589 No need to cast type when ORing.
4590 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4591 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4592 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4593 assume EMACS_INT is the same width as char *.
4594 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4595 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4596 Remove no-longer-needed casts.
4597 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4598 (xg_tool_bar_help_callback, xg_make_tool_item):
4599 Use EMACS_INTPTR to hold an integer
4600 that will be cast to void *; this can avoid a GCC warning
4601 if EMACS_INT is not the same width as void *.
4602 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4603 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4604 (current_message_1, set_message_1):
4605 Use a local to convert to proper width without a cast.
4606 * xmenu.c (dialog_selection_callback): Likewise.
4607
4608 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4609 Also, don't assume VALBITS / RAND_BITS is less than 5,
4610 and don't rely on undefined behavior when shifting a 1 left into
4611 the sign bit.
4612 * lisp.h (get_random): Change signature to match.
4613
4614 * lread.c (hash_string): Use size_t, not int, for hash computation.
4615 Normally we prefer signed values; but hashing is special, because
4616 it's better to use unsigned division on hash table sizes so that
4617 the remainder is nonnegative. Also, size_t is the natural width
4618 for hashing into memory. The previous code used 'int', which doesn't
4619 retain enough info to hash well into very large tables.
4620 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4621
4622 * dbusbind.c: Don't possibly lose pointer info when converting.
4623 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4624 Use XPNTR rather than XHASH, so that the high-order bits of
4625 the pointer aren't lost when converting through void *.
4626
4627 * eval.c (Fautoload): Don't double-shift a pointer.
4628
4629 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4630
4631 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4632
4633 * gnutls.c (DEF_GNUTLS_FN):
4634 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4635
4636 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4637
4638 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4639 marker. (Bug#8610)
4640
4641 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4642
4643 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4644 New version that can reserve upto 2GB of heap space.
4645
4646 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4647
4648 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4649
4650 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4651
4652 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4653 `gnutls_certificate_set_x509_key_file'.
4654
4655 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4656
4657 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4658 Update dependencies.
4659
4660 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4661
4662 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4663 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4664 Remove unused parameter `fildes'.
4665 * process.c (read_process_output, send_process): Don't pass it.
4666
4667 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4668
4669 Fix previous change: the library cache is defined in w32.c.
4670 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4671 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4672
4673 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4674
4675 Implement dynamic loading of GnuTLS on Windows.
4676
4677 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4678 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4679 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4680 Declare.
4681
4682 * gnutls.c (Qgnutls_dll): Define.
4683 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4684 (gnutls_*): Declare function pointers.
4685 (init_gnutls_functions): New function to initialize function pointers.
4686 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4687 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4688 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4689 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4690 (emacs_gnutls_write, emacs_gnutls_read)
4691 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4692 (Fgnutls_available_p): New function.
4693 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4694 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4695 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4696
4697 * image.c: Include w32.h.
4698 (Vimage_type_cache): Delete.
4699 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4700 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4701 (w32_delayed_load): Move to w32.c.
4702
4703 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4704
4705 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4706 (w32_delayed_load): Move from image.c. When loading a library, record
4707 its filename in the :loaded-from property of the library id.
4708 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4709 Initialize and staticpro them.
4710 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4711
4712 * process.c: Include lisp.h before w32.h, not after.
4713 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4714 instead of gnutls_record_check_pending.
4715
4716 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4717
4718 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4719
4720 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4721 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4722 as passed in.
4723
4724 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4725
4726 * xterm.c (x_set_frame_alpha): Do not set property on anything
4727 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4728
4729 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4730
4731 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4732
4733 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4734
4735 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4736 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4737 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4738 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4739 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4740 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4741 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4742 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4743 (Qgnutls_bootprop_callbacks_verify): Make static.
4744
4745 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4746
4747 * callproc.c: Indentation fixup.
4748
4749 * sysdep.c (wait_for_termination_1): Make static.
4750 (wait_for_termination, interruptible_wait_for_termination):
4751 Move after wait_for_termination_1.
4752
4753 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4754
4755 * sysdep.c (interruptible_wait_for_termination): New function
4756 which is like wait_for_termination, but allows keyboard
4757 interruptions.
4758
4759 * callproc.c (Fcall_process): Add (:file "file") as an option for
4760 the STDOUT buffer.
4761 (Fcall_process_region): Ditto.
4762
4763 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4764
4765 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4766 rather than `XVECTOR (FOO)->size'.
4767
4768 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4769 inttypes.h, as a gnulib replacement is used if it not available in
4770 system headers.
4771
4772 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4773
4774 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4775 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4776 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4777
4778 * coding.c (coding_alloc_by_realloc): Error out if destination
4779 will grow beyond MOST_POSITIVE_FIXNUM.
4780 (decode_coding_emacs_mule): Abort if there isn't enough place in
4781 charbuf for the composition carryover bytes. Reserve an extra
4782 space for up to 2 characters produced in a loop.
4783 (decode_coding_iso_2022): Abort if there isn't enough place in
4784 charbuf for the composition carryover bytes.
4785
4786 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4787
4788 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4789 aborting when %lld or %lll format is passed.
4790 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4791 %llo or %llx format is passed. (Bug#8545)
4792
4793 * window.c (window_scroll_line_based): Use a marker instead of
4794 simple variables to record original value of point. (Bug#7952)
4795
4796 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4797 produced by %s or %c overflows available buffer space. (Bug#8545)
4798
4799 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4800
4801 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4802 (SIZE_MAX): Move defn after all includes, as they might #define it.
4803
4804 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4805
4806 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4807
4808 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4809
4810 * keyboard.c (Qdelayed_warnings_hook): Define.
4811 (command_loop_1): Run `delayed-warnings-hook'
4812 if Vdelayed_warnings_list is non-nil.
4813 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4814 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4815
4816 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4817
4818 * doprnt.c (doprnt): Don't return value smaller than the buffer
4819 size if the message was truncated. (Bug#8545).
4820
4821 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4822
4823 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4824 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4825
4826 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4827
4828 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4829
4830 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4831
4832 * makefile.w32-in: Update dependencies.
4833
4834 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4835
4836 Improve `doprnt' and its usage. (Bug#8545)
4837 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4838 `format_end'. Remove support for %l as a conversion specifier.
4839 Don't use xrealloc. Improve diagnostics when the %l size modifier
4840 is used. Update the commentary.
4841
4842 * eval.c (verror): Simplify calculation of size_t.
4843
4844 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4845 messages.
4846
4847 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4848
4849 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4850 change.
4851
4852 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4853
4854 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4855 This makes this file independent of the recent pseudovector change.
4856
4857 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4858
4859 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4860
4861 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4862 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4863 Remove unused local.
4864 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4865
4866 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4867 GCC 4.6.0 optimizes based on type-based alias analysis.
4868 For example, if b is of type struct buffer * and v of type struct
4869 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4870 != &v->size, and therefore "v->size = 1; b->size = 2; return
4871 v->size;" must therefore return 1. This assumption is incorrect
4872 for Emacs, since it type-puns struct Lisp_Vector * with many other
4873 types. To fix this problem, this patch adds a new type struct
4874 vectorlike_header that documents the constraints on layout of vectors
4875 and pseudovectors, and helps optimizing compilers not get fooled
4876 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4877 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4878 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4879 the size member.
4880 (XSETPVECTYPE): Rewrite in terms of new macro.
4881 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4882 This is a bit clearer, and further avoids the possibility of
4883 undesirable aliasing.
4884 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4885 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4886 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4887 since Lisp_Subr is a special case (no "next" field).
4888 (ASIZE): Now uses header.size rather than size.
4889 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4890 to avoid the hassle of writing XVECTOR (foo)->header.size.
4891 (struct vectorlike_header): New type.
4892 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4893 object, to help avoid aliasing.
4894 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4895 (SUBRP): Likewise, since Lisp_Subr is a special case.
4896 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4897 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4898 (struct Lisp_Hash_Table): Combine first two members into a single
4899 struct vectorlike_header member. All uses of "size" and "next" members
4900 changed to be "header.size" and "header.next".
4901 * buffer.h (struct buffer): Likewise.
4902 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4903 * frame.h (struct frame): Likewise.
4904 * process.h (struct Lisp_Process): Likewise.
4905 * termhooks.h (struct terminal): Likewise.
4906 * window.c (struct save_window_data, struct saved_window): Likewise.
4907 * window.h (struct window): Likewise.
4908 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4909 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4910 * buffer.c (init_buffer_once): Likewise.
4911 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4912 special case.
4913 * process.c (Fformat_network_address): Use local var for size,
4914 for brevity.
4915
4916 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4917
4918 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4919 * data.c (atof): Remove decl; no longer used or needed.
4920 (digit_to_number): Move to lread.c.
4921 (Fstring_to_number): Use new string_to_number function, to be
4922 consistent with how the Lisp reader treats infinities and NaNs.
4923 Do not assume that floating-point numbers represent EMACS_INT
4924 without losing information; this is not true on most 64-bit hosts.
4925 Avoid double-rounding errors, by insisting on integers when
4926 parsing non-base-10 numbers, as the documentation specifies.
4927 * lisp.h (string_to_number): New decl, replacing ...
4928 (isfloat_string): Remove.
4929 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4930 (read1): Do not accept +. and -. as integers; this
4931 appears to have been a coding error. Similarly, do not accept
4932 strings like +-1e0 as floating point numbers. Do not report
4933 overflow for integer overflows unless the base is not 10 which
4934 means we have no simple and reliable way to continue.
4935 Break out the floating-point parsing into a new
4936 function string_to_number, so that Fstring_to_number parses
4937 floating point numbers consistently with the Lisp reader.
4938 (digit_to_number): Move here from data.c. Make it static inline.
4939 (E_CHAR, EXP_INT): Remove, replacing with ...
4940 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4941 (string_to_number): New function, replacing isfloat_string.
4942 This function checks for valid syntax and produces the resulting
4943 Lisp float number too. Rework it so that string-to-number
4944 no longer mishandles examples like "1.0e+". Use strtoumax,
4945 so that overflow for non-base-10 numbers is reported only when
4946 there's no portable and simple way to convert to floating point.
4947
4948 * textprop.c (set_text_properties_1): Rewrite for clarity,
4949 and to avoid GCC warning about integer overflow.
4950
4951 * intervals.h (struct interval): Use EMACS_INT for members
4952 where EMACS_UINT might cause problems. See
4953 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4954 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4955 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4956 All uses changed.
4957 (offset_intervals): Tell GCC not to worry about length overflow
4958 when negating a negative length.
4959
4960 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4961 (overrun_check_free): Likewise.
4962
4963 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4964 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4965 word size.
4966
4967 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4968 (gnutls_make_error): Rename local to avoid shadowing.
4969 (gnutls_emacs_global_deinit): ifdef out; not used.
4970 (Fgnutls_boot): Use const for pointer to readonly storage.
4971 Comment out unused local. Fix pointer signedness problems.
4972
4973 * lread.c (openp): Don't stuff size_t into an 'int'.
4974 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4975 about possible signed overflow.
4976
4977 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4978 (GDK_KEY_g): Don't define if already defined.
4979 (xg_prepare_tooltip): Avoid pointer signedness problem.
4980 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4981
4982 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4983 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4984
4985 * xfns.c (Fx_window_property): Simplify a bit,
4986 to make a bit faster and to avoid GCC 4.6.0 warning.
4987 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4988
4989 * fns.c (internal_equal): Don't assume size_t fits in int.
4990
4991 * alloc.c (compact_small_strings): Tighten assertion a little.
4992
4993 Replace pEd with more-general pI, and fix some printf arg casts.
4994 * lisp.h (pI): New macro, generalizing old pEd macro to other
4995 conversion specifiers. For example, use "...%"pI"d..." rather
4996 than "...%"pEd"...".
4997 (pEd): Remove. All uses replaced with similar uses of pI.
4998 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4999 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5000 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5001 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5002 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5003 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5004 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5005 64-bit hosts.
5006 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5007 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5008 * print.c (safe_debug_print, print_object): Likewise.
5009 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5010 to int.
5011 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5012 avoiding the 0 flag, which is not portable.
5013 * process.c (Fmake_network_process): Use pI to avoid cast.
5014 * region-cache.c (pp_cache): Likewise.
5015 * xdisp.c (decode_mode_spec): Likewise.
5016 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5017 behavior on 64-bit hosts with printf arg.
5018 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5019 (x_stop_queuing_selection_requests): Likewise.
5020 (x_get_window_property): Don't truncate byte count to an 'int'
5021 when tracing.
5022
5023 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5024 here, since it parses constructs like leading '-' and spaces,
5025 which are not wanted; and it overflows with large numbers.
5026 Instead, simply match F[0-9]+, which is what is wanted anyway.
5027
5028 * alloc.c: Remove unportable assumptions about struct layout.
5029 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5030 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5031 (allocate_vectorlike, make_pure_vector): Use the new macros,
5032 plus offsetof, to remove unportable assumptions about struct layout.
5033 These assumptions hold on all porting targets that I know of, but
5034 they are not guaranteed, they're easy to remove, and removing them
5035 makes further changes easier.
5036
5037 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5038 This doesn't fix a bug but makes the code clearer.
5039 (string_overrun_cookie): Now const. Use initializers that
5040 don't formally overflow signed char, to avoid warnings.
5041 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5042 can cause Emacs to crash when string overrun checking is enabled.
5043 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5044 multiple of sizeof (EMACS_INT); it need not be, if
5045 alignof(EMACS_INT) < sizeof (EMACS_INT).
5046 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5047
5048 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5049
5050 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5051
5052 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5053
5054 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5055 supposed to be handshaking. (Bug#8556)
5056 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5057
5058 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5059
5060 * lisp.h (Qdebug): List symbol.
5061 * eval.c (Qdebug): Restore global linkage.
5062 * keyboard.c (debug-on-event): New variable.
5063 (handle_user_signal): Break into debugger when debug-on-event
5064 matches the current signal symbol.
5065
5066 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5067
5068 * alloc.c (check_sblock, check_string_bytes)
5069 (check_string_free_list): Convert to standard C.
5070
5071 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5072
5073 * w32.c (emacs_gnutls_push): Fix typo.
5074
5075 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5076
5077 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5078 "cast to pointer from integer of different size".
5079
5080 Improve doprnt and its use in verror. (Bug#8545)
5081 * doprnt.c (doprnt): Document the set of format control sequences
5082 supported by the function. Use SAFE_ALLOCA instead of always
5083 using `alloca'.
5084
5085 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5086 is one byte too soon. Don't use xrealloc; instead xfree and
5087 xmalloc anew.
5088
5089 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5090
5091 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5092 callbacks stage.
5093
5094 * gnutls.c: Renamed global_initialized to
5095 gnutls_global_initialized. Added internals for the
5096 :verify-hostname-error, :verify-error, and :verify-flags
5097 parameters of `gnutls-boot' and documented those parameters in the
5098 docstring. Start callback support.
5099 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5100 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5101 on error. Return error code.
5102 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5103 (emacs_gnutls_read): Likewise.
5104 (Fgnutls_boot): Return handshake error code.
5105 (emacs_gnutls_handle_error): New function.
5106 (wsaerror_to_errno): Likewise.
5107
5108 * w32.h (emacs_gnutls_pull): Add prototype.
5109 (emacs_gnutls_push): Likewise.
5110
5111 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5112 (emacs_gnutls_push): Likewise.
5113
5114 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5115
5116 * process.c (wait_reading_process_output): Check if GnuTLS
5117 buffered some data internally if no FDs are set for TLS
5118 connections.
5119
5120 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5121 (LIBS): Link to USER_LIBS.
5122 ($(BLD)/gnutls.$(0)): New target.
5123
5124 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5125
5126 * xdisp.c (handle_single_display_spec): Rename the
5127 display_replaced_before_p argument into display_replaced_p, to
5128 make it consistent with the commentary. Fix typos in the
5129 commentary.
5130
5131 * textprop.c (syms_of_textprop): Remove dead code.
5132 (copy_text_properties): Delete obsolete commentary about an
5133 interface that was deleted long ago. Fix typos in the description
5134 of arguments.
5135
5136 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5137 to changes in oldXMenu/XMenu.h from 2011-04-16.
5138 <menu_help_message, prev_menu_help_message>: Constify.
5139 (IT_menu_make_room): menu->help_text is now `const char **';
5140 adjust.
5141
5142 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5143 to changes in oldXMenu/XMenu.h from 2011-04-16.
5144 (struct XMenu): Declare `help_text' `const char **'.
5145
5146 * xfaces.c <Qunspecified>: Make extern again.
5147
5148 * syntax.c: Include sys/types.h before including regex.h, as
5149 required by Posix.
5150
5151 * doc.c (get_doc_string): Improve the format passed to `error'.
5152
5153 * doprnt.c (doprnt): Improve commentary.
5154
5155 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5156
5157 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5158 them with etags.
5159
5160 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5161 changes in globals.h immediately force recompilation.
5162 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5163 $(CURDIR)/s/ms-w32.h.
5164 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5165
5166 * character.c (Fchar_direction): Function deleted.
5167 (syms_of_character): Don't defsubr it.
5168 <char-direction-table>: Deleted.
5169
5170 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5171
5172 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5173 * doprnt.c: Include limits.h.
5174 (SIZE_MAX): New macro.
5175 (doprnt): Return a size_t value. 2nd arg is now size_t.
5176 Many local variables are now size_t instead of int or unsigned.
5177 Improve overflow protection. Support `l' modifier for integer
5178 conversions. Support %l conversion. Don't assume an EMACS_INT
5179 argument for integer conversions and for %c.
5180
5181 * lisp.h (doprnt): Restore prototype.
5182
5183 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5184 $(SRC)/character.h.
5185
5186 * Makefile.in (base_obj): Add back doprnt.o.
5187
5188 * deps.mk (doprnt.o): Add back prerequisites.
5189 (callint.o): Depend on character.h.
5190
5191 * eval.c (internal_lisp_condition_case): Include the handler
5192 representation in the error message.
5193 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5194 when breaking from the loop.
5195
5196 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5197
5198 * callint.c (Fcall_interactively): When displaying error message
5199 about invalid control letter, pass the character's codepoint, not
5200 a pointer to its multibyte form. Improve display of the character
5201 in octal and display also its hex code.
5202
5203 * character.c (char_string): Use %x to display the (unsigned)
5204 codepoint of an invalid character, to avoid displaying a bogus
5205 negative value.
5206
5207 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5208 `error', not SYMBOL_NAME itself.
5209
5210 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5211 character arguments to `error'.
5212
5213 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5214 to `error' in error message about FINAL_CHAR argument. Make sure
5215 FINAL_CHAR is a character, and use %c when it is passed as
5216 argument to `error'.
5217
5218 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5219
5220 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5221
5222 * w32.c: Include <time.h>.
5223 (sys_localtime): New function.
5224
5225 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5226
5227 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5228
5229 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5230
5231 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5232
5233 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5234 zombies (Bug#8467).
5235
5236 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5237
5238 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5239 gl_state.e_property when gl_state.object is Qt.
5240
5241 * insdel.c (make_gap_larger): Remove limitation of buffer size
5242 to <= INT_MAX.
5243
5244 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5245
5246 * xdisp.c (lookup_glyphless_char_display)
5247 (produce_glyphless_glyph): Handle cons cell entry in
5248 glyphless-char-display.
5249 (Vglyphless_char_display): Document it.
5250
5251 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5252 glyphless-char-display.
5253
5254 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5255
5256 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5257
5258 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5259
5260 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5261 definition for no-X builds.
5262
5263 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5264
5265 Static checks with GCC 4.6.0 and non-default toolkits.
5266
5267 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5268
5269 * process.c (keyboard_bit_set): Define only if SIGIO.
5270 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5271 (send_process): Repair possible setjmp clobbering.
5272
5273 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5274
5275 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5276
5277 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5278
5279 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5280 Define only if needed.
5281
5282 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5283 by pacifying GCC about it. Maybe it's time to retire it?
5284 * xfaces.c (USG, __TIMEVAL__): Likewise.
5285
5286 * dispextern.h (struct redisplay_interface): Rename param
5287 to avoid shadowing.
5288 * termhooks.h (struct terminal): Likewise.
5289 * xterm.c (xembed_send_message): Likewise.
5290
5291 * insdel.c (make_gap_smaller): Define only if
5292 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5293
5294 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5295 it.
5296
5297 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5298 so that we aren't warned about unused symbols.
5299
5300 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5301
5302 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5303
5304 * xfns.c (x_real_positions): Mark locals as initialized.
5305
5306 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5307
5308 * xterm.c: Fix problems found by static analysis with other toolkits.
5309 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5310 (x_dispatch_event): Declare static if USE_GTK, and
5311 define if USE_GTK || USE_X_TOOLKIT.
5312 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5313 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5314 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5315 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5316
5317 * xmenu.c (menu_help_callback): Pointer type fixes.
5318 Use const pointers when pointing at readonly data. Avoid pointer
5319 signedness clashes.
5320 (FALSE): Remove unused macro.
5321 (update_frame_menubar): Remove unused decl.
5322
5323 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5324
5325 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5326 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5327 (single_menu_item): Rename local to avoid shadowing.
5328
5329 * keyboard.c (make_lispy_event): Remove unused local var.
5330
5331 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5332 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5333
5334 * bitmaps: Change bitmaps from unsigned char back to the X11
5335 compatible char. Avoid the old compiler warnings about
5336 out-of-range initializers by using, for example, '\xab' rather
5337 than 0xab.
5338
5339 * xgselect.c (xgselect_initialize): Check vs interface
5340 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5341
5342 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5343
5344 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5345 to read-only memory.
5346
5347 * fns.c (vector): Remove; this old hack is no longer needed.
5348
5349 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5350 Remove unused var.
5351 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5352
5353 * xrdb.c (x_load_resources): Omit unused local.
5354
5355 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5356 (x_window): Rename locals to avoid shadowing.
5357 (USG): Use the kludged USG macro, to pacify gcc.
5358
5359 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5360 (x_term_init): Remove local to avoid shadowing.
5361
5362 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5363
5364 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5365 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5366
5367 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5368
5369 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5370
5371 Fix regex.c, syntax.c and friends for buffers > 2GB.
5372 * syntax.h (struct gl_state_s): Declare character position members
5373 EMACS_INT.
5374
5375 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5376
5377 * textprop.c (verify_interval_modification, interval_of):
5378 Declare arguments EMACS_INT.
5379
5380 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5381 EMACS_INT.
5382
5383 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5384
5385 * indent.c (Fvertical_motion): Local variable it_start is now
5386 EMACS_INT.
5387
5388 * regex.c (re_match, re_match_2, re_match_2_internal)
5389 (bcmp_translate, regcomp, regexec, print_double_string)
5390 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5391 (re_compile_pattern, re_exec): Declare arguments and local
5392 variables `size_t' and `ssize_t' and return values `regoff_t', as
5393 appropriate.
5394 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5395 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5396 <compile_stack_type>: `size' and `avail' are now `size_t'.
5397
5398 * regex.h <regoff_t>: Use ssize_t, not int.
5399 (re_search, re_search_2, re_match, re_match_2): Arguments that
5400 specify buffer/string position and length are now ssize_t and
5401 size_t. Return type is regoff_t.
5402
5403 2011-04-16 Ben Key <bkey76@gmail.com>
5404
5405 * nsfont.m: Fixed bugs in ns_get_family and
5406 ns_descriptor_to_entity that were caused by using free to
5407 deallocate memory blocks that were allocated by xmalloc (via
5408 xstrdup). This caused Emacs to crash when compiled with
5409 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5410 --enable-checking=xmallocoverrun). xfree is now used to
5411 deallocate these memory blocks.
5412
5413 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5414
5415 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5416
5417 emacs_write: Accept and return EMACS_INT for sizes.
5418 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5419 et seq.
5420 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5421 Accept and return EMACS_INT.
5422 (emacs_gnutls_write): Return the number of bytes written on
5423 partial writes.
5424 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5425 (emacs_read, emacs_write): Remove check for negative size, as the
5426 Emacs source code has been audited now.
5427 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5428 (emacs_read, emacs_write): Use it.
5429 * process.c (send_process): Adjust to the new signatures of
5430 emacs_write and emacs_gnutls_write. Do not attempt to store
5431 a byte offset into an 'int'; it might overflow.
5432 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5433
5434 * sound.c: Don't assume sizes fit in 'int'.
5435 (struct sound_device.period_size, alsa_period_size):
5436 Return EMACS_INT, not int.
5437 (struct sound_device.write, vox_write, alsa_write):
5438 Accept EMACS_INT, not int.
5439 (wav_play, au_play): Use EMACS_INT to store sizes and to
5440 record read return values.
5441
5442 2011-04-15 Ben Key <bkey76@gmail.com>
5443
5444 * keyboard.c (Qundefined): Don't declare static since it is used
5445 in nsfns.m.
5446 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5447 static since they are used in nsfont.m.
5448
5449 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5450
5451 * process.c (Qprocessp): Don't declare static.
5452 * lisp.h (Qprocessp): Declare again.
5453
5454 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5455
5456 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5457
5458 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5459
5460 Improve C-level modularity by making more things 'static'.
5461
5462 Don't publish debugger-only interfaces to other modules.
5463 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5464 (verify_bytepos, count_markers): Move decls to the only modules
5465 that need them.
5466 * region-cache.h (pp_cache): Likewise.
5467 * window.h (check_all_windows): Likewise.
5468 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5469
5470 * sysdep.c (croak): Now static, if
5471 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5472 * syssignal.h (croak): Declare only if not static.
5473
5474 * alloc.c (refill_memory_reserve): Now static if
5475 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5476 * lisp.h (refill_memory_reserve): Declare only if not static.
5477
5478 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5479 Define only if USE_LUCID.
5480
5481 * xrdb.c (x_customization_string, x_rm_string): Now static.
5482
5483 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5484 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5485
5486 * xdisp.c (draw_row_with_mouse_face): Now static.
5487 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5488
5489 * window.h (check_all_windows): Mark externally visible.
5490
5491 * window.c (window_deletion_count): Now static.
5492
5493 * undo.c: Make symbols static if they're not exported.
5494 (last_undo_buffer, last_boundary_position, pending_boundary):
5495 Now static.
5496
5497 * textprop.c (interval_insert_behind_hooks): Now static.
5498 (interval_insert_in_front_hooks): Likewise.
5499
5500 * term.c: Make symbols static if they're not exported.
5501 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5502 (max_frame_lines, tty_set_terminal_modes):
5503 (tty_reset_terminal_modes, tty_turn_off_highlight):
5504 (get_tty_terminal): Now static.
5505 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5506 * termhooks.h (term_mouse_moveto): Do not declare if
5507 HAVE_WINDOW_SYSTEM.
5508 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5509 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5510
5511 * sysdep.c: Make symbols static if they're not exported.
5512 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5513 Now static.
5514 (sigprocmask_set, full_mask): Remove; unused.
5515 (wait_debugging): Mark as visible.
5516 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5517 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5518
5519 * syntax.c (syntax_temp): Define only if !__GNUC__.
5520
5521 * sound.c (current_sound_device, current_sound): Now static.
5522
5523 * search.c (searchbufs, searchbuf_head): Now static.
5524
5525 * scroll.c (scroll_cost): Remove; unused.
5526 * dispextern.h (scroll_cost): Remove decl.
5527
5528 * region-cache.h (pp_cache): Mark as externally visible.
5529
5530 * process.c: Make symbols static if they're not exported.
5531 (process_tick, update_tick, create_process, chan_process):
5532 (Vprocess_alist, proc_buffered_char, datagram_access):
5533 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5534 (deactivate_process): Mark defn as static, as well as decl.
5535 * lisp.h (create_process): Remove decl.
5536 * process.h (chan_process, Vprocess_alist): Remove decls.
5537
5538 * print.c: Make symbols static if they're not exported.
5539 (print_depth, new_backquote_output, being_printed, print_buffer):
5540 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5541 (print_interval, print_number_index, initial_stderr_stream):
5542 Now static.
5543 * lisp.h (Fprinc): Remove decl.
5544 (debug_output_compilation_hack): Mark as externally visible.
5545
5546 * sysdep.c (croak): Move decl from here to syssignal.h.
5547 * syssignal.h (croak): Put it here, so the API can be checked when
5548 'croak' is called from dissociate_if_controlling_tty.
5549
5550 * minibuf.c: Make symbols static if they're not exported.
5551 (minibuf_save_list, choose_minibuf_frame): Now static.
5552 * lisp.h (choose_minibuf_frame): Remove decl.
5553
5554 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5555
5556 * lread.c: Make symbols static if they're not exported.
5557 (read_objects, initial_obarray, oblookup_last_bucket_number):
5558 Now static.
5559 (make_symbol): Remove; unused.
5560 * lisp.h (initial_obarray, make_symbol): Remove decls.
5561
5562 * keyboard.c: Make symbols static if they're not exported.
5563 (single_kboard, recent_keys_index, total_keys, recent_keys):
5564 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5565 (this_single_command_key_start, echoing, last_auto_save):
5566 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5567 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5568 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5569 (Vlispy_mouse_stem, double_click_count):
5570 Now static.
5571 (force_auto_save_soon): Define only if SIGDANGER.
5572 (ignore_mouse_drag_p): Now static if
5573 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5574 (print_help): Remove; unused.
5575 (stop_character, last_timer_event): Mark as externally visible.
5576 * keyboard.h (ignore_mouse_drag_p): Declare only if
5577 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5578 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5579 * lisp.h (echoing): Remove decl.
5580 (force_auto_save_soon): Declare only if SIGDANGER.
5581 * xdisp.c (redisplay_window): Simplify code, to make it more
5582 obvious that ignore_mouse_drag_p is not accessed if !defined
5583 USE_GTK && !defined HAVE_NS.
5584
5585 * intervals.c: Make symbols static if they're not exported.
5586 (merge_properties_sticky, merge_interval_right, delete_interval):
5587 Now static.
5588 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5589
5590 * insdel.c: Make symbols static if they're not exported.
5591 However, leave prepare_to_modify_buffer alone. It's never
5592 called from outside this function, but that appears to be a bug.
5593 (combine_after_change_list, combine_after_change_buffer):
5594 (adjust_after_replace, signal_before_change): Now static.
5595 (adjust_after_replace_noundo): Remove; unused.
5596 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5597 (signal_before_change): Remove decls.
5598
5599 * indent.c (val_compute_motion, val_vmotion): Now static.
5600
5601 * image.c: Make symbols static if they're not exported.
5602 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5603 if USE_GTK.
5604 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5605 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5606
5607 * fringe.c (standard_bitmaps): Now static.
5608 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5609
5610 * frame.c: Make symbols static if they're not exported.
5611 (x_report_frame_params, make_terminal_frame): Now static.
5612 (get_frame_param): Now static, unless HAVE_NS.
5613 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5614 (x_get_resource_string): Remove; not used.
5615 * frame.h (make_terminal_frame, x_report_frame_params):
5616 (x_get_resource_string); Remove decls.
5617 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5618 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5619
5620 * font.c, fontset.c: Make symbols static if they're not exported.
5621 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5622 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5623 * font.c (font_close_object): Now static.
5624 * font.h (font_close_object): Remove.
5625 * fontset.c (FONTSET_OBJLIST): Remove.
5626 (free_realized_fontset) #if-0 the body, which does nothing.
5627 (face_suitable_for_char_p): #if-0, as it's never called.
5628 * fontset.h (face_suitable_for_char_p): Remove decl.
5629 * xfaces.c (face_at_string_position):
5630 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5631 since 0 is always ASCII.
5632
5633 * fns.c (weak_hash_tables): Now static.
5634
5635 * fileio.c: Make symbols static if they're not exported.
5636 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5637 (Vwrite_region_annotation_buffers): Now static.
5638
5639 * eval.c: Make symbols static if they're not exported.
5640 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5641 * lisp.h (backtrace_list): Remove decl.
5642
5643 * emacs.c: Make symbols static if they're not exported.
5644 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5645 (fatal_error_code, fatal_error_signal_hook, standard_args):
5646 Now static.
5647 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5648 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5649 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5650 * lisp.h (fatal_error_signal_hook): Remove decl.
5651 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5652
5653 * editfns.c: Move a (normally-unused) function to its only use.
5654 * editfns.c, lisp.h (get_operating_system_release): Remove.
5655 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5656 worth the hassle of breaking this out.
5657
5658 * xterm.c: Make symbols static if they're not exported.
5659 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5660 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5661 (x_destroy_window, x_delete_display):
5662 Now static.
5663 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5664 (x_mouse_leave): Remove; unused.
5665 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5666 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5667 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5668 Remove decls.
5669 (x_mouse_leave): Declare only if WINDOWSNT.
5670 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5671 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5672 USE_X_TOOLKIT.
5673
5674 * ftxfont.c: Make symbols static if they're not exported.
5675 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5676 HAVE_FREETYPE.
5677 * font.h (ftxfont_driver): Likewise.
5678
5679 * xfns.c: Make symbols static if they're not exported.
5680 (x_last_font_name, x_display_info_for_name):
5681 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5682 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5683 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5684 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5685 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5686 (last_show_tip_args): Now static.
5687 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5688 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5689 (x_screen_planes): Remove; unused.
5690 * dispextern.h (x_screen_planes): Remove decl.
5691
5692 * dispnew.c: Make symbols static if they're not exported.
5693 * dispextern.h (redraw_garbaged_frames, scrolling):
5694 (increment_row_positions): Remove.
5695 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5696 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5697 Now static.
5698 (redraw_garbaged_frames): Remove; unused.
5699
5700 * xfaces.c: Make symbols static if they're not exported.
5701 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5702 Remove decls.
5703 * xterm.h (defined_color): Remove decls.
5704 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5705 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5706 (menu_face_changed_default, defined_color, free_realized_face):
5707 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5708 (ascii_face_of_lisp_face): Remove; unused.
5709
5710 * xdisp.c: Make symbols static if they're not exported.
5711 * dispextern.h (scratch_glyph_row, window_box_edges):
5712 (glyph_to_pixel_coords, set_cursor_from_row):
5713 (get_next_display_element, set_iterator_to_next):
5714 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5715 (show_mouse_face): Remove decls
5716 * frame.h (message_buf_print): Likewise.
5717 * lisp.h (pop_message, set_message, check_point_in_composition):
5718 Likewise.
5719 * xterm.h (set_vertical_scroll_bar): Likewise.
5720 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5721 (message_buf_print, scratch_glyph_row, displayed_buffer):
5722 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5723 (get_next_display_element, show_mouse_face, window_box_edges):
5724 (frame_to_window_pixel_xy, check_point_in_composition):
5725 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5726 (glyph_to_pixel_coords): Remove; unused.
5727
5728 * dired.c (file_name_completion): Now static.
5729
5730 * dbusbind.c (xd_in_read_queued_messages): Now static.
5731
5732 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5733 * data.c (circular_list_error): Remove.
5734
5735 * commands.h (last_point_position, last_point_position_buffer):
5736 (last_point_position_window): Remove decls.
5737 * keyboard.c: Make these variables static.
5738
5739 * coding.h (coding, code_convert_region, encode_coding_gap):
5740 Remove decls.
5741 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5742 (iso_code_class, detect_coding, code_convert_region): Now static.
5743 (encode_coding_gap): Remove; unused.
5744
5745 * chartab.c (chartab_chars, chartab_bits): Now static.
5746
5747 * charset.h (charset_iso_8859_1): Remove decl.
5748 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5749 Now static.
5750
5751 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5752 * ccl.c (Vccl_program_table): Now static.
5753 (check_ccl_update): Remove; unused.
5754
5755 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5756 * category.h: ... from here.
5757 * category.c (check_category_table, set_category_set): Now static.
5758
5759 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5760 * lisp.h: Remove these decls.
5761
5762 * buffer.c (buffer_count): Remove unused var.
5763
5764 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5765 so that it's not optimized away.
5766 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5767 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5768 exported only to the debugger.
5769
5770 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5771 * atimer.h (run_all_atimers): Remove; not exported.
5772
5773 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5774 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5775 was inaccessible from Lisp.
5776 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5777 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5778
5779 alloc.c: Import and export fewer symbols, and remove unused items.
5780 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5781 is defined.
5782 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5783 it's not optimized away by whole-program optimization.
5784 (message_enable_multibyte, free_misc): Remove.
5785 (catchlist, handlerlist, mark_backtrace):
5786 Declare only if BYTE_MARK_STACK.
5787 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5788 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5789 (message_enable_multibyte): Remove decl.
5790 (free_misc, interval_free_list, float_block, float_block_index):
5791 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5792 (cons_free_list, last_marked_index):
5793 Now static.
5794 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5795 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5796 (mark_backtrace): Define only if BYTE_MARK_STACK.
5797 * xdisp.c (message_enable_multibyte): Now static.
5798
5799 Declare Lisp_Object Q* variables to be 'static' if not exported.
5800 This makes it easier for human readers (and static analyzers)
5801 to see whether these variables are used from other modules.
5802 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5803 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5804 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5805 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5806 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5807 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5808 * xmenu.c, xselect.c:
5809 Declare Q* vars static if they are not used in other modules.
5810 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5811 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5812 Remove decls of unexported vars.
5813 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5814
5815 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5816
5817 Make Emacs functions such as Fatom 'static' by default.
5818 This makes it easier for human readers (and static analyzers)
5819 to see whether these functions can be called from other modules.
5820 DEFUN now defines a static function. To make the function external
5821 so that it can be used in other C modules, use the new macro DEFUE.
5822 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5823 (Finit_image_library):
5824 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5825 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5826 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5827 Remove decls, since these functions are now static.
5828 (Funintern, Fget_internal_run_time): New decls, since these functions
5829 were already external.
5830
5831 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5832 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5833 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5834 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5835 * keyboard.c, keymap.c, lread.c:
5836 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5837 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5838 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5839 Mark functions with DEFUE instead of DEFUN,
5840 if they are used in other modules.
5841 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5842 decls for now-static functions.
5843 * buffer.h (Fdelete_overlay): Remove decl.
5844 * callproc.c (Fgetenv_internal): Mark as internal.
5845 * composite.c (Fremove_list_of_text_properties): Remove decl.
5846 (Fcomposition_get_gstring): New forward static decl.
5847 * composite.h (Fcomposite_get_gstring): Remove decl.
5848 * dired.c (Ffile_attributes): New forward static decl.
5849 * doc.c (Fdocumntation_property): New forward static decl.
5850 * eval.c (Ffetch_bytecode): New forward static decl.
5851 (Funintern): Remove extern decl; now in .h file where it belongs.
5852 * fileio.c (Fmake_symbolic_link): New forward static decl.
5853 * image.c (Finit_image_library): New forward static decl.
5854 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5855 * intervals.h (Fprevious_property_change):
5856 (Fremove_list_of_text_properties): Remove decls.
5857 * keyboard.c (Fthis_command_keys): Remove decl.
5858 (Fcommand_execute): New forward static decl.
5859 * keymap.c (Flookup_key): New forward static decl.
5860 (Fcopy_keymap): Now static.
5861 * keymap.h (Flookup_key): Remove decl.
5862 * process.c (Fget_process): New forward static decl.
5863 (Fprocess_datagram_address): Mark as internal.
5864 * syntax.c (Fsyntax_table_p): New forward static decl.
5865 (skip_chars): Remove duplicate decl.
5866 * textprop.c (Fprevious_property_change): New forward static decl.
5867 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5868 Now internal.
5869 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5870 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5871
5872 * editfns.c (Fformat): Remove unreachable code.
5873
5874 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5875
5876 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5877 change. (Bug#8496)
5878
5879 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5880
5881 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5882 when at ZV. (Bug#8487)
5883
5884 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5885
5886 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5887 (Bug#8437)
5888 * keyboard.c (parse_tool_bar_item): Likewise.
5889 * sound.c (sound_cleanup, alsa_close): Likewise.
5890 * termcap.c (tgetent): Likewise.
5891 * xfns.c (x_default_font_parameter): Likewise.
5892 * xsettings.c (read_and_apply_settings): Likewise.
5893
5894 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5895 (overrun_check_free): Protoize.
5896
5897 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5898
5899 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5900 since callers should never pass a negative size.
5901 Change the signature to match that of plain 'read' and 'write'; see
5902 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5903 * lisp.h: Update prototypes of emacs_write and emacs_read.
5904
5905 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5906
5907 * xdisp.c (redisplay_window): Don't try to determine the character
5908 position of the scroll margin if the window start point w->startp
5909 is outside the buffer's accessible region. (Bug#8468)
5910
5911 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5912
5913 Fix write-region and its subroutines for buffers > 2GB.
5914 * fileio.c (a_write, e_write): Modify declaration of arguments and
5915 local variables to support buffers larger than 2GB.
5916 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5917
5918 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5919 argument, local variables, and return value.
5920
5921 * lisp.h: Update prototypes of emacs_write and emacs_read.
5922
5923 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5924
5925 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5926
5927 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5928
5929 Fix more problems found by GCC 4.6.0's static checks.
5930
5931 * xdisp.c (vmessage): Use a better test for character truncation.
5932
5933 * charset.c (load_charset_map): <, not <=, for optimization,
5934 and to avoid potential problems with integer overflow.
5935 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5936 * casetab.c (set_identity, shuffle): Likewise.
5937 * editfns.c (Fformat): Likewise.
5938 * syntax.c (skip_chars): Likewise.
5939
5940 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5941 This also lets GCC 4.6.0 generate slightly better loop code.
5942
5943 * callint.c (Fcall_interactively): <, not <=, for optimization.
5944 (Fcall_interactively): Count the number of arguments produced,
5945 not the number of arguments given. This is simpler and lets GCC
5946 4.6.0 generate slightly better code.
5947
5948 * ftfont.c: Distingish more carefully between FcChar8 and char.
5949 The previous code passed unsigned char * to a functions like
5950 strlen and xstrcasecmp that expect char *, which does not
5951 conform to the C standard.
5952 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5953 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5954 char * when the C standard requires it.
5955
5956 * keyboard.c (read_char): Remove unused var.
5957
5958 * eval.c: Port to Windows vsnprintf (Bug#8435).
5959 Include <limits.h>.
5960 (SIZE_MAX): Define if the headers do not.
5961 (verror): Do not give up if vsnprintf returns a negative count.
5962 Instead, grow the buffer. This ports to Windows vsnprintf, which
5963 does not conform to C99. Problem reported by Eli Zaretskii.
5964 Also, simplify the allocation scheme, by avoiding the need for
5965 calling realloc, and removing the ALLOCATED variable.
5966
5967 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5968
5969 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5970 But keep the doprint source code for now, as we might revamp it
5971 and use it again (Bug#8435).
5972 * lisp.h (doprnt): Remove.
5973 * Makefile.in (base_obj): Remove doprnt.o.
5974 * deps.mk (doprnt.o): Remove.
5975
5976 error: Print 32- and 64-bit integers portably (Bug#8435).
5977 Without this change, on typical 64-bit hosts error ("...%d...", N)
5978 was used to print both 32- and 64-bit integers N, which relied on
5979 undefined behavior.
5980 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5981 New macro.
5982 * lisp.h (error, verror): Mark as printf-like functions.
5983 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5984 Report overflow in size calculations when allocating printf buffer.
5985 Do not truncate output string at its first null byte.
5986 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5987 Truncate the output at a character boundary, since vsnprintf does not
5988 do that.
5989 * charset.c (check_iso_charset_parameter): Convert internal
5990 character to string before calling 'error', since %c now has the
5991 printf meaning.
5992 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5993 overflow when computing char to be passed to 'error'. Do not
5994 pass Lisp_Object to 'error'; pass the integer instead.
5995 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5996 formatted with plain %d.
5997
5998 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5999
6000 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6001
6002 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6003
6004 * xterm.c (x_catch_errors): Remove duplicate declaration.
6005
6006 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6007
6008 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6009
6010 2011-04-10 Jim Meyering <meyering@redhat.com>
6011
6012 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6013 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6014 return ssize_t not "int", and use size_t as the buffer length.
6015 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6016 * gnutls.h: Update declarations.
6017 * process.c (read_process_output): Use ssize_t, to match.
6018 (send_process): Likewise.
6019
6020 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6021
6022 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6023
6024 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6025
6026 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6027 Use unsigned char, to match FcChar8 type definition.
6028
6029 * xterm.c (handle_one_xevent):
6030 * xmenu.c (create_and_show_popup_menu):
6031 * xselect.c (x_decline_selection_request)
6032 (x_reply_selection_request): Avoid type-punned deref of X events.
6033
6034 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6035
6036 Fix some uses of `int' instead of EMACS_INT.
6037 * search.c (string_match_1, fast_string_match)
6038 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6039 (scan_buffer, find_next_newline_no_quit)
6040 (find_before_next_newline, search_command, Freplace_match)
6041 (Fmatch_data): Make some `int' variables be EMACS_INT.
6042
6043 * xdisp.c (display_count_lines): 3rd argument and return value now
6044 EMACS_INT. All callers changed.
6045 (pint2hrstr): Last argument is now EMACS_INT.
6046
6047 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6048 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6049 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6050 (decode_coding_utf_16, decode_coding_emacs_mule)
6051 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6052 (decode_coding_ccl, decode_coding_charset)
6053 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6054 (decode_coding_iso_2022, decode_coding_emacs_mule)
6055 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6056 <char_offset, last_offset>: Declare EMACS_INT.
6057 (encode_coding_utf_8, encode_coding_utf_16)
6058 (encode_coding_emacs_mule, encode_invocation_designation)
6059 (encode_designation_at_bol, encode_coding_iso_2022)
6060 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6061 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6062 Declare EMACS_INT.
6063 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6064 (encode_invocation_designation): Last argument P_NCHARS is now
6065 EMACS_INT.
6066 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6067 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6068
6069 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6070 All users changed.
6071
6072 * ccl.c (Fccl_execute_on_string): Declare some variables
6073 EMACS_INT.
6074
6075 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6076
6077 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6078
6079 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6080
6081 * process.c (Fformat_network_address): Doc fix.
6082
6083 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6084
6085 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6086
6087 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6088
6089 * keyboard.c (read_char): Call Lisp function help-form-show,
6090 instead of using internal_with_output_to_temp_buffer.
6091 (Qhelp_form_show): New var.
6092 (syms_of_keyboard): Use DEFSYM macro.
6093
6094 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6095
6096 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6097
6098 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6099
6100 * process.c (Flist_processes): Remove to Lisp.
6101 (list_processes_1): Delete.
6102
6103 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6104
6105 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6106
6107 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6108
6109 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6110
6111 Fix more problems found by GCC 4.6.0's static checks.
6112
6113 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6114
6115 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6116
6117 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6118
6119 * xdisp.c (vmessage): Mark as a printf-like function.
6120
6121 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6122
6123 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6124
6125 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6126 printf-like functions.
6127 (tiff_load): Add casts to remove these marks before passing them
6128 to system-supplied API.
6129
6130 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6131
6132 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6133 This avoids several warnings with gcc -Wstrict-overflow.
6134 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6135 directly, rather than having caller test rule sign. This avoids
6136 some unnecessary tests.
6137 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6138 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6139 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6140
6141 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6142 (xfont_open): Avoid unnecessary tests.
6143
6144 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6145
6146 * composite.h, composite.c (composition_gstring_put_cache):
6147 Use EMACS_INT, not int, for length.
6148
6149 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6150 breaking out part of COMPOSITION_DECODE_RULE.
6151 (COMPOSITION_DECODE_RULE): Use it.
6152 * composite.c (get_composition_id): Remove unused local vars,
6153 by using the new macro.
6154
6155 * textprop.c (set_text_properties_1): Change while to do-while,
6156 since the condition is always true at first.
6157
6158 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6159 (interval_deletion_adjustment): Return unsigned value.
6160 All uses changed.
6161
6162 * process.c (list_processes_1, create_pty, read_process_output):
6163 (exec_sentinel): Remove vars that were set but not used.
6164 (create_pty): Remove unnecessary "volatile"s.
6165 (Fnetwork_interface_info): Avoid possibility of int overflow.
6166 (read_process_output): Do adaptive read buffering even if carryover.
6167 (read_process_output): Simplify nbytes computation if buffered.
6168
6169 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6170
6171 * syntax.c (scan_words): Remove var that was set but not used.
6172 (update_syntax_table): Use unsigned instead of int.
6173
6174 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6175 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6176 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6177
6178 * print.c (print_error_message): Avoid int overflow.
6179
6180 * font.c (font_list_entities): Redo for clarity,
6181 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6182
6183 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6184 (font_score): Avoid potential overflow in diff calculation.
6185
6186 * fns.c (substring_both): Remove var that is set but not used.
6187 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6188
6189 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6190
6191 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6192 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6193 can always succeed if overflow has undefined behavior.
6194
6195 * search.c (boyer_moore, wordify): Remove vars set but not used.
6196 (wordify): Omit three unnecessary tests.
6197
6198 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6199 All callers changed. This avoids the need for an unused var.
6200
6201 * casefiddle.c (casify_region): Remove var that is set but not used.
6202
6203 * dired.c (file_name_completion): Remove var that is set but not used.
6204
6205 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6206
6207 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6208 (Finsert_file_contents): Remove unnecessary code checking fd.
6209
6210 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6211 Check for integer overflow on size calculations.
6212
6213 * buffer.c (Fprevious_overlay_change): Remove var that is set
6214 but not used.
6215
6216 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6217 Remove vars that are set but not used.
6218 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6219 (timer_check_2): Mark vars as initialized.
6220
6221 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6222
6223 * image.c (lookup_image): Remove var that is set but not used.
6224 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6225
6226 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6227 that are set but not used.
6228
6229 * xfns.c (make_invisible_cursor): Don't return garbage
6230 if XCreateBitmapFromData fails (Bug#8410).
6231
6232 * xselect.c (x_get_local_selection, x_handle_property_notify):
6233 Remove vars that are set but not used.
6234
6235 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6236 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6237
6238 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6239 Remove var that is set but not used.
6240 (scroll_bar_windows_size): Now size_t, not int.
6241 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6242 Check for overflow.
6243
6244 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6245 (map_tty_color) [!defined MSDOS]: Likewise.
6246
6247 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6248
6249 * coding.c: Remove vars that are set but not used.
6250 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6251 All callers changed.
6252 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6253 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6254 (decode_coding_charset): Remove vars that are set but not used.
6255
6256 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6257 that is set but not used.
6258
6259 * print.c (print_object): Remove var that is set but not used.
6260
6261 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6262 The gnulib version avoids calling malloc in the usual case,
6263 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6264 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6265 * filelock.c (current_lock_owner): Likewise.
6266 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6267 * sysdep.c: Include allocator.h, careadlinkat.h.
6268 (emacs_no_realloc_allocator): New static constant.
6269 (emacs_readlink): New function.
6270 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6271 ../lib/careadlinkat.h.
6272
6273 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6274
6275 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6276 first non-nil return value).
6277
6278 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6279
6280 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6281 if not defined (Bug#8403).
6282
6283 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6284
6285 * xdisp.c (display_count_lines): Remove parameter `start',
6286 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6287 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6288 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6289 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6290 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6291 and thereabouts. All callers changed.
6292 (get_per_char_metric): Remove parameter `f', unused since
6293 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6294
6295 2011-04-02 Jim Meyering <meyering@redhat.com>
6296
6297 do not dereference NULL upon failed strdup
6298 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6299 (ns_get_family): Likewise.
6300
6301 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6302
6303 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6304
6305 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6306
6307 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6308 later (Bug#8403).
6309
6310 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6311
6312 Add lexical binding.
6313
6314 * window.c (Ftemp_output_buffer_show): New fun.
6315 (Fsave_window_excursion):
6316 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6317
6318 * lread.c (lisp_file_lexically_bound_p): New function.
6319 (Fload): Bind Qlexical_binding.
6320 (readevalloop): Remove `evalfun' arg.
6321 Bind Qinternal_interpreter_environment.
6322 (Feval_buffer): Bind Qlexical_binding.
6323 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6324 Mark as dynamic.
6325 (syms_of_lread): Declare `lexical-binding'.
6326
6327 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6328
6329 * keyboard.c (eval_dyn): New fun.
6330 (menu_item_eval_property): Use it.
6331
6332 * image.c (parse_image_spec): Use Ffunctionp.
6333
6334 * fns.c (concat, mapcar1): Accept byte-code-functions.
6335
6336 * eval.c (Fsetq): Handle lexical vars.
6337 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6338 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6339 (FletX, Flet): Obey lexical binding.
6340 (Fcommandp): Handle closures.
6341 (Feval): New `lexical' arg.
6342 (eval_sub): New function extracted from Feval. Use it almost
6343 everywhere where Feval was used. Look up vars in lexical env.
6344 Handle closures.
6345 (Ffunctionp): Move from subr.el.
6346 (Ffuncall): Handle closures.
6347 (apply_lambda): Remove `eval_flags'.
6348 (funcall_lambda): Handle closures and new byte-code-functions.
6349 (Fspecial_variable_p): New function.
6350 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6351 but without exporting it to Lisp.
6352
6353 * doc.c (Fdocumentation, store_function_docstring):
6354 * data.c (Finteractive_form): Handle closures.
6355
6356 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6357 interactive spec.
6358
6359 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6360 New byte-codes.
6361 (exec_byte_code): New function extracted from Fbyte_code to handle new
6362 calling convention for byte-code-functions. Add new byte-codes.
6363
6364 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6365
6366 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6367
6368 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6369
6370 * xdisp.c (redisplay_internal): Fix prototype.
6371
6372 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6373
6374 * xdisp.c (SCROLL_LIMIT): New macro.
6375 (try_scrolling): Use it when setting scroll_limit.
6376 Limit scrolling to 100 screen lines.
6377 (redisplay_window): Even when falling back on "recentering",
6378 position point in the window according to scroll-conservatively,
6379 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6380
6381 (try_scrolling): When point is above the window, allow searching
6382 as far as scroll_max, or one screenful, to compute vertical
6383 distance from PT to the scroll margin position. This prevents
6384 try_scrolling from unnecessarily failing when
6385 scroll-conservatively is set to a value slightly larger than the
6386 window height. Clean up the case of PT below the margin at bottom
6387 of window: scroll_max can no longer be INT_MAX. When aggressive
6388 scrolling is in use, don't let point enter the opposite scroll
6389 margin as result of the scroll.
6390 (syms_of_xdisp) <scroll-conservatively>: Document the
6391 threshold of 100 lines for never-recentering scrolling.
6392
6393 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6394
6395 * dispextern.h (move_it_by_lines):
6396 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6397 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6398 (message_log_check_duplicate): Remove parameters `prev_bol' and
6399 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6400 (redisplay_internal): Remove parameter `preserve_echo_area',
6401 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6402
6403 * indent.c (Fvertical_motion):
6404 * window.c (window_scroll_pixel_based, Frecenter):
6405 Don't pass `need_y_p' to `move_it_by_lines'.
6406
6407 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6408
6409 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6410 steal a few bits to be more compact.
6411 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6412 Remove unneeded casts.
6413
6414 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6415
6416 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6417
6418 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6419 binding" message (bug#7967).
6420
6421 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6422
6423 Fix more problems found by GCC 4.6.0's static checks.
6424
6425 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6426 Remove unused local var.
6427
6428 * editfns.c (Fmessage_box): Remove unused local var.
6429
6430 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6431 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6432 Omit unused local vars.
6433 * window.c (shrink_windows): Omit unused local var.
6434 * menu.c (digest_single_submenu): Omit unused local var.
6435 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6436 Omit unused local var.
6437
6438 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6439 Don't assume string length fits in int.
6440 (keyremap_step, read_key_sequence): Use size_t for sizes.
6441 (read_key_sequence): Don't check last_real_key_start redundantly.
6442
6443 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6444 instead of alloca (Bug#8344).
6445
6446 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6447 (Fbacktrace_frame): Don't assume nframes fits in int.
6448
6449 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6450
6451 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6452 concerns.
6453
6454 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6455
6456 * cm.c (calccost): Turn while-do into do-while, for clarity.
6457
6458 * keyboard.c (syms_of_keyboard): Use the same style as later
6459 in this function when indexing through an array. This also
6460 works around GCC bug 48267.
6461
6462 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6463
6464 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6465
6466 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6467 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6468
6469 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6470 This avoids undefined behavior on integer overflow, and is a bit
6471 more convenient anyway since it is compared to a size_t variable.
6472
6473 Variadic C functions now count arguments with size_t, not int.
6474 This avoids an unnecessary limitation on 64-bit machines, which
6475 caused (substring ...) to crash on large vectors (Bug#8344).
6476 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6477 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6478 All variadic functions and their callers changed accordingly.
6479 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6480 * data.c (arith_driver, float_arith_driver): Likewise.
6481 * editfns.c (general_insert_function): Likewise.
6482 * eval.c (struct backtrace.nargs, interactive_p)
6483 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6484 (funcall_lambda, mark_backtrace): Likewise.
6485 * fns.c (concat): Likewise.
6486 * frame.c (x_set_frame_parameters): Likewise.
6487 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6488 0 if not found, not -1. All callers changed.
6489
6490 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6491 (stack_copy_size): Now size_t, not int.
6492 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6493
6494 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6495
6496 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6497 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6498 All callers changed.
6499
6500 * lisp.h (multibyte_char_to_unibyte):
6501 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6502 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6503 * character.h (CHAR_TO_BYTE8):
6504 * cmds.c (internal_self_insert):
6505 * editfns.c (general_insert_function):
6506 * keymap.c (push_key_description):
6507 * search.c (Freplace_match):
6508 * xdisp.c (message_dolog, set_message_1): All callers changed.
6509
6510 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6511
6512 * keyboard.c (safe_run_hook_funcall): New function.
6513 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6514 don't set the hook to nil, but remove the offending function instead.
6515 (Qcommand_hook_internal): Remove, unused.
6516 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6517 Vcommand_hook_internal.
6518
6519 * eval.c (enum run_hooks_condition): Remove.
6520 (funcall_nil, funcall_not): New functions.
6521 (run_hook_with_args): Call each function through a `funcall' argument.
6522 Remove `cond' argument, now redundant.
6523 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6524 (Frun_hook_with_args_until_failure): Adjust accordingly.
6525 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6526
6527 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6528
6529 * dispextern.h (string_buffer_position): Remove declaration.
6530
6531 * print.c (strout): Remove parameter `multibyte', unused since
6532 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6533
6534 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6535 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6536 All callers changed.
6537
6538 * w32.c (_wsa_errlist): Use braces for struct initializers.
6539
6540 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6541 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6542 All callers changed.
6543 (string_buffer_position): Likewise. Also, make static (it's never
6544 used outside xdisp.c).
6545 (cursor_row_p): Remove parameter `w', unused since
6546 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6547 (decode_mode_spec): Remove parameter `precision', introduced during
6548 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6549 All callers changed.
6550
6551 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6552
6553 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6554
6555 2011-03-27 Anders Lindgren <andlind@gmail.com>
6556
6557 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6558 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6559 (ns_update_auto_hide_menu_bar): New functions.
6560 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6561 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6562 ns_constrain_all_frames.
6563 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6564 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6565
6566 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6567
6568 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6569
6570 2011-03-27 Glenn Morris <rgm@gnu.org>
6571
6572 * syssignal.h: Replace RETSIGTYPE with void.
6573 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6574 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6575 Replace SIGTYPE with void everywhere.
6576 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6577 * s/template.h (SIGTYPE): Remove commented out definition.
6578
6579 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6580
6581 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6582 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6583
6584 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6585
6586 * w32.c (read_unc_volume): Use parameter `henum', instead of
6587 global variable `wget_enum_handle'.
6588
6589 * keymap.c (describe_vector): Remove parameters `indices' and
6590 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6591 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6592
6593 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6594
6595 * keyboard.c (timer_check): Remove parameter `do_it_now',
6596 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6597 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6598 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6599
6600 * keyboard.c (read_char):
6601 * w32menu.c (w32_menu_display_help):
6602 * xmenu.c (show_help_event, menu_help_callback):
6603 Adjust calls to `show_help_echo'.
6604
6605 * gtkutil.c (xg_maybe_add_timer):
6606 * keyboard.c (readable_events):
6607 * process.c (wait_reading_process_output):
6608 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6609
6610 * insdel.c (adjust_markers_gap_motion):
6611 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6612 (gap_left, gap_right): Don't call it.
6613
6614 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6615
6616 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6617 incurred during fontification.
6618
6619 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6620
6621 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6622 (DEFVAR_PER_BUFFER): Don't pass it.
6623
6624 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6625 (scrolling_window): Don't pass it.
6626
6627 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6628
6629 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6630
6631 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6632 and `suffix'.
6633 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6634 of variables specific to SELinux and computation of `encoded_absname'.
6635
6636 * image.c (XPutPixel): Remove unused variable `height'.
6637
6638 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6639
6640 * unexw32.c (get_section_info): Remove unused variable `section'.
6641
6642 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6643 (system_process_attributes): Remove unused variable `sess'.
6644 (sys_read): Remove unused variable `err'.
6645
6646 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6647 (w32_wnd_proc): Remove unused variable `isdead'.
6648 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6649 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6650 (x_create_tip_frame): Remove unused variable `tem'.
6651
6652 * w32inevt.c (w32_console_read_socket):
6653 Remove unused variable `no_events'.
6654
6655 * w32term.c (x_draw_composite_glyph_string_foreground):
6656 Remove unused variable `width'.
6657
6658 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6659
6660 * w32term.c (x_set_glyph_string_clipping):
6661 Don't pass uninitialized region to CombineRgn.
6662
6663 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6664
6665 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6666 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6667 (Fx_close_connection): Remove unused variable `i'.
6668
6669 * w32font.c (w32font_draw): Return number of glyphs.
6670 (w32font_open_internal): Remove unused variable `i'.
6671 (w32font_driver): Add missing initializer.
6672
6673 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6674 (fill_in_menu): Remove unused variable `items_added'.
6675
6676 * w32term.c (last_mouse_press_frame): Remove static global variable.
6677 (w32_clip_to_row): Remove unused variable `f'.
6678 (x_delete_terminal): Remove unused variable `i'.
6679
6680 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6681 (NOTHING): Remove unused static global variable.
6682 (uniscribe_check_otf): Remove unused variable `table'.
6683 (uniscribe_font_driver): Add missing initializers.
6684
6685 2011-03-23 Julien Danjou <julien@danjou.info>
6686
6687 * term.c (Fsuspend_tty, Fresume_tty):
6688 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6689 * window.c (temp_output_buffer_show):
6690 * insdel.c (signal_before_change):
6691 * frame.c (Fhandle_switch_frame):
6692 * fileio.c (Fdo_auto_save):
6693 * emacs.c (Fkill_emacs):
6694 * editfns.c (save_excursion_restore):
6695 * cmds.c (internal_self_insert):
6696 * callint.c (Fcall_interactively):
6697 * buffer.c (Fkill_all_local_variables):
6698 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6699 Use Frun_hooks.
6700 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6701 unconditionnaly since it does the check itself.
6702
6703 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6704
6705 Fix more problems found by GCC 4.5.2's static checks.
6706
6707 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6708 the first time through the loop, since we know p0 < p1 then.
6709 This also avoids a gcc -Wstrict-overflow warning.
6710
6711 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6712 leading to a memory leak, possible in functions like
6713 load_charset_map_from_file that can allocate an unbounded number
6714 of objects (Bug#8318).
6715
6716 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6717 that could (at least in theory) be that large.
6718
6719 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6720 This is less likely to overflow, and avoids undefined behavior if
6721 overflow does occur. All callers changed. Use strtoul to scan
6722 for the unsigned long integer.
6723 (pint2hrstr): Simplify and tune code slightly.
6724 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6725
6726 * scroll.c (do_scrolling): Work around GCC bug 48228.
6727 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6728
6729 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6730 This also avoids a warning with gcc -Wstrict-overflow.
6731 (validate_x_resource_name): Simplify count usage.
6732 This also avoids a warning with gcc -Wstrict-overflow.
6733
6734 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6735 fail (Bug#8306).
6736
6737 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6738
6739 * process.c (Fmake_network_process): Use socklen_t, not int,
6740 where POSIX says socklen_t is required in portable programs.
6741 This fixes a porting bug on hosts like 64-bit HP-UX, where
6742 socklen_t is wider than int (Bug#8277).
6743 (Fmake_network_process, server_accept_connection):
6744 (wait_reading_process_output, read_process_output):
6745 Likewise.
6746
6747 * process.c: Rename or move locals to avoid shadowing.
6748 (list_processes_1, Fmake_network_process):
6749 (read_process_output_error_handler, exec_sentinel_error_handler):
6750 Rename or move locals.
6751 (Fmake_network_process): Define label "retry_connect" only if needed.
6752 (Fnetwork_interface_info): Fix pointer signedness.
6753 (process_send_signal): Add cast to avoid pointer signedness problem.
6754 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6755 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6756
6757 Make tparam.h and terminfo.c consistent.
6758 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6759 Include tparam.h instead, since it declares them.
6760 * cm.h (PC): Remove extern decl; tparam.h now does this.
6761 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6762 * terminfo.c: Include tparam.h, to check interfaces.
6763 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6764 (tparam): Adjust signature to match interface in tparam.h;
6765 this removes some undefined behavior. Check that outstring and len
6766 are zero, which they always are with Emacs.
6767 * tparam.h (PC, BC, UP): New extern decls.
6768
6769 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6770 (xftfont_open): Rename locals to avoid shadowing.
6771
6772 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6773 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6774 (OTF_TAG_SYM): Omit macro if not needed.
6775 (ftfont_list): Remove unused local.
6776 (get_adstyle_property, ftfont_pattern_entity):
6777 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6778 Rename locals to avoid shadowing.
6779
6780 * xfont.c (xfont_list_family): Mark var as initialized.
6781
6782 * xml.c (make_dom): Now static.
6783
6784 * composite.c (composition_compute_stop_pos): Rename local to
6785 avoid shadowing.
6786 (composition_reseat_it): Remove unused locals.
6787 (find_automatic_composition, composition_adjust_point): Likewise.
6788 (composition_update_it): Mark var as initialized.
6789 (find_automatic_composition): Mark vars as initialized,
6790 with a FIXME (Bug#8290).
6791
6792 character.h: Rename locals to avoid shadowing.
6793 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6794 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6795 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6796 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6797 to avoid shadowing.
6798
6799 * textprop.c (property_change_between_p): Remove; unused.
6800
6801 * intervals.c (interval_start_pos): Now static.
6802
6803 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6804
6805 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6806 Rename locals to avoid shadowing.
6807
6808 * sound.c (wav_play, au_play, Fplay_sound_internal):
6809 Fix pointer signedness.
6810 (alsa_choose_format): Remove unused local var.
6811 (wav_play): Initialize a variable to 0, to prevent undefined
6812 behavior (Bug#8278).
6813
6814 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6815
6816 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6817
6818 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6819 clobbering (Bug#8298).
6820 * sysdep.c (sys_subshell): Likewise.
6821 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6822
6823 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6824 This should get cleaned up, so that child_setup has the
6825 same signature on all platforms.
6826
6827 * callproc.c (call_process_cleanup): Now static.
6828 (relocate_fd): Rename locals to avoid shadowing.
6829
6830 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6831
6832 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6833 not to be necessary, and produces flickering.
6834
6835 2011-03-20 Glenn Morris <rgm@gnu.org>
6836
6837 * config.in: Remove file.
6838
6839 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6840
6841 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6842 are now in src/globals.h.
6843 (syms_of_minibuf): Remove spurious & from previous change.
6844
6845 2011-03-20 Leo <sdl.web@gmail.com>
6846
6847 * minibuf.c (completing-read-function): New variable.
6848 (completing-read-default): Rename from completing-read.
6849 (completing-read): Call completing-read-function.
6850
6851 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6852
6853 * xfaces.c (Fx_load_color_file):
6854 Read color file from absolute filename (bug#8250).
6855
6856 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6857
6858 * makefile.w32-in: Update dependencies.
6859
6860 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6861
6862 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6863
6864 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6865
6866 Fix more problems found by GCC 4.5.2's static checks.
6867
6868 * process.c (make_serial_process_unwind, send_process_trap):
6869 (sigchld_handler): Now static.
6870
6871 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6872 That way, the code declares only the vars that it needs.
6873 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6874 * s/cygwin.h (PTY_ITERATION): Likewise.
6875 * s/darwin.h (PTY_ITERATION): Likewise.
6876 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6877
6878 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6879 * process.c (allocate_pty): Don't declare stb unless it's needed.
6880
6881 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6882 (CONSTANTLIM): Remove; unused.
6883 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6884 Define only if needed.
6885
6886 * unexelf.c (unexec): Name an expression,
6887 to avoid gcc -Wbad-function-cast warning.
6888 Use a different way to cause a compilation error if anyone uses
6889 n rather than nn, a way that does not involve shadowing.
6890 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6891
6892 * deps.mk (unexalpha.o): Remove; unused.
6893
6894 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6895 * unexec.h: New file.
6896 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6897 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6898 Depend on unexec.h.
6899 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6900 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6901 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6902 Change as necessary to match prototype in unexec.h.
6903
6904 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6905 shadowing.
6906 (back_comment, skip_chars): Mark vars as initialized.
6907
6908 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6909 Rename locals to avoid shadowing.
6910
6911 * lread.c (read1): Rewrite so as not to use empty "else".
6912 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6913
6914 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6915
6916 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6917 warning when compiling print.c.
6918
6919 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6920 instead of using an uninitialized var.
6921 (font_sort_entities): Mark var as initialized.
6922
6923 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6924
6925 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6926 pointers to constants.
6927 (font_parse_fcname): Remove unused vars.
6928 (font_delete_unmatched): Now static.
6929 (font_get_spec): Remove; unused.
6930 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6931 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6932 Rename or move locals to avoid shadowing.
6933
6934 * fns.c (require_nesting_list, require_unwind): Now static.
6935 (Ffillarray): Rename locals to avoid shadowing.
6936
6937 * floatfns.c (domain_error2): Define only if needed.
6938 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6939
6940 * alloc.c (mark_backtrace): Move decl from here ...
6941 * lisp.h: ... to here, so that it can be checked.
6942
6943 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6944 (Fdefvar): Rewrite so as not to use empty "else".
6945 (lisp_indirect_variable): Name an expression,
6946 to avoid gcc -Wbad-function-cast warning.
6947 (Fdefvar): Rename locals to avoid shadowing.
6948
6949 * callint.c (quotify_arg, quotify_args): Now static.
6950 (Fcall_interactively): Rename locals to avoid shadowing.
6951 Use const pointer when appropriate.
6952
6953 * lisp.h (get_system_name, get_operating_system_release):
6954 Move decls here, to check interfaces.
6955 * process.c (get_operating_system_release): Move decl to lisp.h.
6956 * xrdb.c (get_system_name): Likewise.
6957 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6958 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6959 some of which prompt warnings from gcc -Wbad-function-cast.
6960 (Fformat_time_string, Fencode_time, Finsert_char):
6961 (Ftranslate_region_internal, Fformat):
6962 Rename or remove local vars to avoid shadowing.
6963 (Ftranslate_region_internal): Mark var as initialized.
6964
6965 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6966 avoid shadowing.
6967
6968 * lisp.h (eassert): Check that the argument compiles, even if
6969 ENABLE_CHECKING is not defined.
6970
6971 * data.c (Findirect_variable): Name an expression, to avoid
6972 gcc -Wbad-function-cast warning.
6973 (default_value, arithcompare, arith_driver, arith_error): Now static.
6974 (store_symval_forwarding): Rename local to avoid shadowing.
6975 (Fmake_variable_buffer_local, Fmake_local_variable):
6976 Mark variables as initialized.
6977 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6978
6979 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6980 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6981 Rename locals to avoid shadowing.
6982 (mark_stack): Move local variables into the #ifdef region where
6983 they're used.
6984 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6985 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6986 needed otherwise.
6987 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6988 (GC_STRING_CHARS): Remove; not used.
6989 (Fmemory_limit): Cast sbrk's returned value to char *.
6990
6991 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6992 avoids undefined behavior in theory.
6993
6994 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6995
6996 Use functions, not macros, for up- and down-casing (Bug#8254).
6997 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6998 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6999 to use the following functions instead of these macros.
7000 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7001 EMACS_INT, since callers assume the returned value fits in int.
7002 (upcase1): Likewise, for UPCASE_TABLE.
7003 (uppercasep, lowercasep, upcase): New static inline functions.
7004 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7005 the race-condition problem in the old DOWNCASE.
7006
7007 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7008 Rename locals to avoid shadowing.
7009 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7010 (regex_compile, re_search_2, re_match_2_internal):
7011 Remove unused local vars.
7012 (FREE_VAR): Rewrite so as not to use empty "else",
7013 which gcc can warn about.
7014 (regex_compile, re_match_2_internal): Mark locals as initialized.
7015 (RETALLOC_IF): Define only if needed.
7016 (WORDCHAR_P): Likewise. This one is never needed, but is used
7017 only in a comment talking about a compiler bug, so put inside
7018 the #if 0 of that comment.
7019 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7020 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7021 Remove; unused.
7022
7023 * search.c (boyer_moore): Rename locals to avoid shadowing.
7024 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7025 (PREV_CHAR_BOUNDARY): Likewise.
7026
7027 * search.c (simple_search): Remove unused var.
7028
7029 * dired.c (compile_pattern): Move decl from here ...
7030 * lisp.h: ... to here, so that it can be checked.
7031 (struct re_registers): New forward decl.
7032
7033 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7034
7035 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7036 All uses changed.
7037 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7038 Rename locals to avoid shadowing.
7039 (Fvertical_motion): Mark locals as initialized.
7040
7041 * casefiddle.c (casify_object, casify_region): Now static.
7042 (casify_region): Mark local as initialized.
7043
7044 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7045
7046 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7047 New macros, so that the caller can use some names other than
7048 gcpro1, gcpro2, etc.
7049 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7050 of the new macros.
7051 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7052 argument, for consistency with GCPRO2_VAR, etc: it is now the
7053 prefix of the variable, not the variable itself. All uses
7054 changed.
7055 * dired.c (directory_files_internal, file_name_completion):
7056 Rename locals to avoid shadowing.
7057
7058 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7059 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7060 dired.c's scmp function, had undefined behavior.
7061 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7062 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7063 * buffer.h: ... to here, because these macros use current_buffer,
7064 and the new implementation with inline functions needs to have
7065 current_buffer in scope now, rather than later when the macros
7066 are used.
7067 (downcase, upcase1): New static inline functions.
7068 (DOWNCASE, UPCASE1): Reimplement using these functions.
7069 This avoids undefined behavior in expressions like
7070 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7071 from race conditions in accessing the global variables
7072 case_temp1 and case_temp2.
7073 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7074 * lisp.h (case_temp1, case_temp2): Remove their decls.
7075 * character.h (ASCII_CHAR_P): Move from here ...
7076 * lisp.h: ... to here, so that the inline functions mentioned
7077 above can use them.
7078
7079 * dired.c (directory_files_internal_unwind): Now static.
7080
7081 * fileio.c (file_name_as_directory, directory_file_name):
7082 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7083 Now static.
7084 (file_name_as_directory): Use const pointers when appropriate.
7085 (Fexpand_file_name): Likewise. In particular, newdir might
7086 point at constant storage, so make it a const pointer.
7087 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7088 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7089 signedness issues.
7090 (Fset_file_times, Finsert_file_contents, auto_save_error):
7091 Rename locals to avoid shadowing.
7092
7093 * minibuf.c (choose_minibuf_frame_1): Now static.
7094 (Ftry_completion, Fall_completions): Rename or remove locals
7095 to avoid shadowing.
7096
7097 * marker.c (bytepos_to_charpos): Remove; unused.
7098
7099 * lisp.h (verify_bytepos, count_markers): New decls,
7100 so that gcc does not warn that these functions aren't declared.
7101
7102 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7103 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7104 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7105 (copy_text): Remove unused local var.
7106
7107 * filelock.c (within_one_second): Now static.
7108 (lock_file_1): Rename local to avoid shadowing.
7109
7110 * buffer.c (fix_overlays_before): Mark locals as initialized.
7111 (fix_start_end_in_overlays): Likewise. This function should be
7112 simplified by using pointers-to-pointers, but that's a different
7113 matter.
7114 (switch_to_buffer_1): Now static.
7115 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7116 (report_overlay_modification): Rename locals to avoid shadowing.
7117
7118 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7119 Fix pointer signedness issue.
7120 (sys_subshell): Mark local as volatile if checking for lint,
7121 to suppress a gcc -Wclobbered warning that does not seem to be right.
7122 (MAXPATHLEN): Define only if needed.
7123
7124 * process.c (serial_open, serial_configure): Move decls from here ...
7125 * systty.h: ... to here, so that they can be checked.
7126
7127 * fns.c (get_random, seed_random): Move extern decls from here ...
7128 * lisp.h: ... to here, so that they can be checked.
7129
7130 * sysdep.c (reset_io): Now static.
7131 (wait_for_termination_signal): Remove; unused.
7132
7133 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7134 (copy_keymap_item, append_key, push_text_char_description):
7135 Now static.
7136 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7137 (DENSE_TABLE_SIZE): Remove; unused.
7138 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7139 (describe_map_tree):
7140 Rename locals to avoid shadowing.
7141
7142 * keyboard.c: Declare functions static if they are not used elsewhere.
7143 (echo_char, echo_dash, cmd_error, top_level_2):
7144 (poll_for_input, handle_async_input): Now static.
7145 (read_char, kbd_buffer_get_event, make_lispy_position):
7146 (make_lispy_event, make_lispy_movement, apply_modifiers):
7147 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7148 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7149 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7150 (read_key_sequence, read_char): Mark locals as initialized.
7151 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7152
7153 * keyboard.h (make_ctrl_char): New decl.
7154 (mark_kboards): Move decl here ...
7155 * alloc.c (mark_kboards): ... from here.
7156
7157 * lisp.h (force_auto_save_soon): New decl.
7158
7159 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7160 (DEFINE_DUMMY_FUNCTION): New macro.
7161 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7162 Use it.
7163 (main): Add casts to avoid warnings
7164 if GCC considers string literals to be constants.
7165
7166 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7167
7168 * dbusbind.c: Pointer signedness fixes.
7169 (xd_signature, xd_append_arg, xd_initialize):
7170 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7171 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7172 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7173 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7174
7175 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7176 if GCC considers string literals to be constants.
7177 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7178
7179 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7180
7181 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7182 (print_preprocess, print_object): New macro to fix last change.
7183
7184 * print.c (print_preprocess): Don't forget font objects.
7185
7186 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7187
7188 * emacs.c (USAGE3): Doc fixes.
7189
7190 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7191
7192 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7193 structure.
7194
7195 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7196
7197 * lisp.h (VWindow_system, Qfile_name_history):
7198 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7199 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7200 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7201
7202 * w32select.c: Don't #include "keyboard.h".
7203 (run_protected): Add extern declaration for waiting_for_input.
7204
7205 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7206 * w32console.c (detect_input_pending, read_input_pending)
7207 (encode_terminal_code):
7208 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7209 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7210 (w32_system_caret_y, Qfile_name_history):
7211 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7212 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7213 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7214 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7215 * w32proc.c (Qlocal, report_file_error):
7216 * w32term.c (Vwindow_system, updating_frame):
7217 * w32uniscribe.c (initialized, uniscribe_font_driver):
7218 Remove unneeded extern declarations.
7219
7220 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7221
7222 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7223
7224 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7225
7226 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7227 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7228 These macros can no longer be used for assignment.
7229
7230 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7231 Assign struct members directly, instead of using BUF_BEGV etc.
7232 (record_buffer_markers, fetch_buffer_markers): New functions for
7233 recording and fetching special buffer markers.
7234 (set_buffer_internal_1, set_buffer_temp): Use them.
7235
7236 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7237
7238 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7239
7240 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7241 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7242
7243 * xdisp.c (hscroll_window_tree):
7244 (reconsider_clip_changes): Use PT instead of BUF_PT.
7245
7246 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7247
7248 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7249 $(EMACS_ROOT)/lib/intprops.h.
7250
7251 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7252
7253 Fix more problems found by GCC 4.5.2's static checks.
7254
7255 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7256 to unsigned char * to avoid compiler diagnostic.
7257 (xg_free_frame_widgets): Make it clear that a local variable is
7258 needed only if USE_GTK_TOOLTIP.
7259 (gdk_window_get_screen): Make it clear that this macro is needed
7260 only if USE_GTK_TOOLTIP.
7261 (int_gtk_range_get_value): New function, which avoids a diagnostic
7262 from gcc -Wbad-function-cast.
7263 (xg_set_toolkit_scroll_bar_thumb): Use it.
7264 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7265 diagnostic from gcc -Wbad-function-cast.
7266 (get_utf8_string, xg_get_file_with_chooser):
7267 Rename locals to avoid shadowing.
7268 (create_dialog): Move locals to avoid shadowing.
7269
7270 * xgselect.c (xg_select): Remove unused var.
7271
7272 * image.c (four_corners_best): Mark locals as initialized.
7273 (gif_load): Initialize transparent_p to zero (Bug#8238).
7274 Mark another local as initialized.
7275 (my_png_error, my_error_exit): Mark with NO_RETURN.
7276
7277 * image.c (clear_image_cache): Now static.
7278 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7279 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7280 (x_edge_detection): Remove unnecessary cast that
7281 gcc -Wbad-function-cast diagnoses.
7282 (gif_load): Fix pointer signedness.
7283 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7284 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7285
7286 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7287
7288 Improve quality of tests for time stamp overflow.
7289 For example, without this patch (encode-time 0 0 0 1 1
7290 1152921504606846976) returns the obviously-bogus value (-948597
7291 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7292 reports time overflow. See
7293 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7294 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7295 * editfns.c: Include limits.h and intprops.h.
7296 (TIME_T_MIN, TIME_T_MAX): New macros.
7297 (time_overflow): Move earlier, to before first use.
7298 (hi_time, lo_time): New functions, for an accurate test for
7299 out-of-range times.
7300 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7301 (Fget_internal_run_time): Don't assume time_t fits in int.
7302 (make_time): Use list2 instead of Fcons twice.
7303 (Fdecode_time): More accurate test for out-of-range times.
7304 (check_tm_member): New function.
7305 (Fencode_time): Use it, to test for out-of-range times.
7306 (lisp_time_argument): Don't rely on undefined left-shift and
7307 right-shift behavior when checking for time stamp overflow.
7308
7309 * editfns.c (time_overflow): New function, refactoring common code.
7310 (Fformat_time_string, Fdecode_time, Fencode_time):
7311 (Fcurrent_time_string): Use it.
7312
7313 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7314 * dired.c (make_time): Move to ...
7315 * editfns.c (make_time): ... here.
7316 * systime.h: Note the move.
7317
7318 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7319
7320 * fringe.c (update_window_fringes): Remove unused variables.
7321
7322 * unexmacosx.c (copy_data_segment): Also copy __got section.
7323 (Bug#8223)
7324
7325 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7326
7327 * termcap.c [MSDOS]: Include "msdos.h".
7328 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7329 Constify `char *' arguments and their references according to
7330 prototypes in tparam.h.
7331
7332 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7333
7334 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7335 Adapt all references accordingly.
7336
7337 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7338
7339 2011-03-11 Tom Tromey <tromey@redhat.com>
7340
7341 * buffer.c (syms_of_buffer): Remove obsolete comment.
7342
7343 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7344
7345 * termhooks.h (encode_terminal_code): Declare prototype.
7346
7347 * msdos.c (encode_terminal_code): Don't declare prototype.
7348
7349 * term.c (encode_terminal_code): Now external again, used by
7350 w32console.c and msdos.c.
7351
7352 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7353 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7354
7355 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7356
7357 Fix some minor problems found by GCC 4.5.2's static checks.
7358
7359 * fringe.c (update_window_fringes): Mark locals as initialized
7360 (Bug#8227).
7361 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7362
7363 * alloc.c (mark_fringe_data): Move decl from here ...
7364 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7365 to check its interface.
7366 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7367
7368 * fontset.c (free_realized_fontset): Now static.
7369 (Fset_fontset_font): Rename local to avoid shadowing.
7370 (fontset_font): Mark local as initialized.
7371 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7372
7373 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7374
7375 * xselect.c (x_disown_buffer_selections): Remove; not used.
7376 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7377 (x_own_selection, Fx_disown_selection_internal): Rename locals
7378 to avoid shadowing.
7379 (x_handle_dnd_message): Remove local to avoid shadowing.
7380
7381 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7382 so that the caller can use some name other than gcpro1.
7383 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7384 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7385 (Fx_backspace_delete_keys_p):
7386 Use them to avoid shadowing, and rename vars to avoid shadowing.
7387 (x_decode_color, x_set_name, x_window): Now static.
7388 (Fx_create_frame): Add braces to silence GCC warning.
7389 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7390 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7391 Remove unused locals.
7392 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7393 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7394 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7395 macros.
7396
7397 * xterm.h (x_mouse_leave): New decl.
7398
7399 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7400 Remove unused functions.
7401 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7402 (x_calc_absolute_position): Now static.
7403 (XTread_socket): Don't define label "out" unless it's used.
7404 Don't declare local "event" unless it's used.
7405 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7406 unless they are used.
7407 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7408 (x_fatal_error_signal): Remove; not used.
7409 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7410 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7411 (x_error_catcher, x_connection_closed, x_error_handler):
7412 (x_error_quitter, xembed_send_message, x_iconify_frame):
7413 (my_log_handler): Rename locals to avoid shadowing.
7414 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7415 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7416
7417 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7418 Rename or move locals to avoid shadowing.
7419 (tty_defined_color, merge_face_heights): Now static.
7420 (free_realized_faces_for_fontset): Remove; not used.
7421 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7422 does not deduce is never used uninitialized.
7423 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7424 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7425
7426 * terminal.c (store_terminal_param): Now static.
7427
7428 * xmenu.c (menu_highlight_callback): Now static.
7429 (set_frame_menubar): Remove unused local.
7430 (xmenu_show): Rename parameter to avoid shadowing.
7431 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7432 since they might point to immutable storage.
7433 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7434 since it's unused otherwise.
7435
7436 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7437 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7438 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7439 avoids a gcc -Wuninitialized diagnostic.
7440 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7441 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7442 does not deduce are never used uninitialized.
7443
7444 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7445
7446 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7447 * window.c (window_loop, size_window):
7448 (run_window_configuration_change_hook, enlarge_window): Likewise.
7449
7450 * window.c (display_buffer): Now static.
7451 (size_window): Mark variables that gcc -Wuninitialized
7452 does not deduce are never used uninitialized.
7453 * window.h (check_all_windows): New decl, to forestall
7454 gcc -Wmissing-prototypes diagnostic.
7455 * dispextern.h (bidi_dump_cached_states): Likewise.
7456
7457 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7458 shadowing.
7459 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7460 Include <limits.h>.
7461 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7462 and to avoid gcc -Wuninitialized warning.
7463 (load_charset_map): Mark variables that gcc -Wuninitialized
7464 does not deduce are never used uninitialized.
7465 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7466
7467 * coding.c (coding_set_source, coding_set_destination):
7468 Use "else { /* comment */ }" rather than "else /* comment */;"
7469 for clarity, and to avoid gcc -Wempty-body warning.
7470 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7471 a block, when the outer 'i' will do.
7472 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7473 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7474 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7475 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7476 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7477 Rename locals to avoid shadowing.
7478 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7479 * coding.c (emacs_mule_char, encode_invocation_designation):
7480 Now static, since they're not used elsewhere.
7481 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7482 (decode_coding_object, encode_coding_object, detect_coding_system):
7483 (decode_coding_emacs_mule): Mark variables that gcc
7484 -Wuninitialized does not deduce are never used uninitialized.
7485 (detect_coding_iso_2022): Initialize a local variable that might
7486 be used uninitialized. Leave a FIXME because it's not clear that
7487 this initialization is needed. (Bug#8211)
7488 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7489 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7490 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7491 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7492 Remove unused macros.
7493
7494 * category.c (hash_get_category_set): Remove unused local var.
7495 (copy_category_table): Now static, since it's not used elsewhere.
7496 * character.c (string_count_byte8): Likewise.
7497
7498 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7499 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7500
7501 * chartab.c (copy_sub_char_table): Now static, since it's not used
7502 elsewhere.
7503 (sub_char_table_ref_and_range, char_table_ref_and_range):
7504 Rename locals to avoid shadowing.
7505 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7506
7507 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7508 (BIDI_BOB): Remove unused macro.
7509
7510 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7511 deduce are never used uninitialized.
7512 * term.c (encode_terminal_code): Likewise.
7513
7514 * term.c (encode_terminal_code): Now static. Remove unused local.
7515
7516 * tparam.h: New file.
7517 * term.c, tparam.h: Include it.
7518 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7519 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7520 Move these decls to tparam.h, and make them agree with what
7521 is actually in tparam.c. The previous trick of using incompatible
7522 decls in different modules does not conform to the C standard.
7523 All callers of tparam changed to use tparam's actual API.
7524 * tparam.c (tparam1, tparam, tgoto):
7525 Use const pointers where appropriate.
7526
7527 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7528 * cm.h (struct cm): Likewise.
7529 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7530 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7531 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7532 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7533 (turn_on_face, init_tty): Likewise.
7534 * termchar.h (struct tty_display_info): Likewise.
7535
7536 * term.c (term_mouse_position): Rename local to avoid shadowing.
7537
7538 * alloc.c (mark_ttys): Move decl from here ...
7539 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7540
7541 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7542
7543 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7544
7545 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7546
7547 * search.c (compile_pattern_1): Remove argument regp, unused since
7548 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7549 (compile_pattern): Don't pass it.
7550
7551 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7552
7553 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7554 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7555 for ! HAVE_GTK3.
7556 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7557
7558 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7559
7560 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7561 gdk_window_get_screen, gdk_window_get_geometry,
7562 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7563 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7564 (xg_get_pixbuf_from_pixmap): New function.
7565 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7566 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7567 Call xg_get_pixbuf_from_pixmap instead of
7568 gdk_pixbuf_get_from_drawable.
7569 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7570 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7571 (xg_check_special_colors): Use GtkStyleContext and its functions
7572 for HAVE_GTK3.
7573 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7574 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7575 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7576 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7577 Call gtk_widget_get_preferred_size.
7578 (xg_frame_resized): gdk_window_get_geometry only takes 5
7579 parameters.
7580 (xg_win_to_widget, xg_event_is_for_menubar):
7581 Call gdk_x11_window_lookup_for_display.
7582 (xg_set_widget_bg): New function.
7583 (delete_cb): New function.
7584 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7585 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7586 (xg_set_background_color): Call xg_set_widget_bg.
7587 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7588 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7589 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7590 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7591 if ! HAVE_GTK3.
7592 (update_frame_tool_bar): Call gtk_widget_hide.
7593 (xg_initialize): Use GDK_KEY_g.
7594
7595 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7596 if ! HAVE_GTK3
7597 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7598
7599 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7600 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7601 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7602
7603 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7604
7605 * w32xfns.c (select_palette): Check success of RealizePalette against
7606 GDI_ERROR, not zero.
7607
7608 See ChangeLog.11 for earlier changes.
7609
7610 ;; Local Variables:
7611 ;; coding: utf-8
7612 ;; End:
7613
7614 Copyright (C) 2011 Free Software Foundation, Inc.
7615
7616 This file is part of GNU Emacs.
7617
7618 GNU Emacs is free software: you can redistribute it and/or modify
7619 it under the terms of the GNU General Public License as published by
7620 the Free Software Foundation, either version 3 of the License, or
7621 (at your option) any later version.
7622
7623 GNU Emacs is distributed in the hope that it will be useful,
7624 but WITHOUT ANY WARRANTY; without even the implied warranty of
7625 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7626 GNU General Public License for more details.
7627
7628 You should have received a copy of the GNU General Public License
7629 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.