1 2011-09-08 Martin Rudalics <rudalics@gmx.at>
3 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4 Operate on live windows only.
6 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
8 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
10 2011-09-07 Eli Zaretskii <eliz@gnu.org>
12 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
13 only under bidi iteration.
15 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
17 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
19 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
21 isnan: Fix porting problem to Solaris 10 with bundled gcc.
22 Without this fix, the command to link temacs failed due to an
23 undefined symbol __builtin_isnan. This is because
24 /usr/include/iso/math_c99.h #defines isnan(x) to
25 __builtin_isnan(x), but the bundled gcc, which identifies itself
26 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
28 * floatfns.c (isnan): #undef, and then #define to a clone of
30 (Fisnan): Always define, since it's always available now.
31 (syms_of_floatfns): Always define isnan at the Lisp level.
33 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
35 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
37 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
39 * fileio.c: Fix bugs with large file offsets (Bug#9428).
40 The previous code assumed that file offsets (off_t values) fit in
41 EMACS_INT variables, which is not true on typical 32-bit hosts.
42 The code messed up by falsely reporting buffer overflow in cases
43 such as (insert-file-contents "big" nil 1 2) into an empty buffer
44 when "big" contains more than 2**29 bytes, even though this
45 inserts just one byte and does not overflow the buffer.
46 (Finsert_file_contents): Store file offsets as off_t
47 values, not as EMACS_INT values. Check for overflow when
48 converting between EMACS_INT and off_t. When checking for
49 buffer overflow or for overlap, take the offsets into account.
50 Don't use EMACS_INT for small values where int suffices.
51 When checking for overlap, fix a typo: ZV was used where
53 (Fwrite_region): Don't assume off_t fits into 'long'.
54 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
56 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
58 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
60 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
62 sprintf-related integer and memory overflow issues (Bug#9412).
64 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
65 (esprintf, exprintf, evxprintf): New functions.
66 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
67 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
68 (modify_event_symbol): Do not assume that the length of
69 name_alist_or_stem is safe to alloca and fits in int.
70 (Fexecute_extended_command): Likewise for function name and binding.
71 (Frecursion_depth): Wrap around reliably on integer overflow.
72 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
73 since some callers pass EMACS_INT values.
74 (Fsingle_key_description): Don't crash if symbol name contains more
75 than MAX_ALLOCA bytes.
76 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
77 (get_minibuffer): Arg is now EMACS_INT, not int.
78 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
79 (esprintf, exprintf, evxprintf): New decls.
80 * window.h (command_loop_level, minibuf_level): Reflect API changes.
82 * dbusbind.c (signature_cat): New function.
83 (xd_signature, Fdbus_register_signal):
84 Do not overrun buffer; instead, report string overflow.
86 * dispnew.c (add_window_display_history): Don't overrun buffer.
87 Truncate instead; this is OK since it's just a log.
89 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
90 even if the time zone offset is outlandishly large.
91 Don't mishandle offset == INT_MIN.
93 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
94 when creating daemon; the previous buffer-overflow check was incorrect.
96 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
97 which has the guts of the old verror function.
99 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
100 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
102 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
103 (font_unparse_xlfd): Don't blindly alloca long strings.
104 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
105 fits in int, when using sprintf. Use single snprintf to count
106 length of string rather than counting it via multiple sprintfs;
107 that's simpler and more reliable.
108 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
109 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
110 sprintf, in case result does not fit in int.
112 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
113 (fontset_from_font): Print it.
115 * frame.c (tty_frame_count): Now printmax_t, not int.
116 (make_terminal_frame, set_term_frame_name): Print it.
117 (x_report_frame_params): In X, window IDs are unsigned long,
118 not signed long, so print them as unsigned.
119 (validate_x_resource_name): Check for implausibly long names,
120 and don't assume name length fits in 'int'.
121 (x_get_resource_string): Don't blindly alloca invocation name;
122 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
125 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
126 (xg_check_special_colors, xg_set_geometry):
127 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
129 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
130 Use esprintf, not sprintf, in case result does not fit in int.
132 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
133 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
134 it as a large positive number.
135 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
136 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
138 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
139 in case result does not fit in int.
141 * print.c (float_to_string): Detect width overflow more reliably.
142 (print_object): Make sprintf buffer a bit bigger, to avoid potential
143 buffer overrun. Don't assume list length fits in 'int'. Treat
144 print length of 0 as 0, not as infinity; to be consistent with other
145 uses of print length in this function. Don't overflow print length
146 index. Don't assume hash table size fits in 'long', or that
147 vectorlike size fits in 'unsigned long'.
149 * process.c (make_process): Use printmax_t, not int, to format
150 process-name gensyms.
152 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
154 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
155 to avoid potential buffer overrun.
157 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
158 if X resource line is longer than 512 bytes.
160 * xfns.c (x_window): Make sprintf buffer a bit bigger
161 to avoid potential buffer overrun.
163 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
165 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
167 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
169 Integer overflow fixes for scrolling, etc.
170 Without these, Emacs silently mishandles large integers sometimes.
171 For example, "C-u 4294967297 M-x recenter" was treated as if
172 it were "C-u 1 M-x recenter" on a typical 64-bit host.
174 * xdisp.c (try_window_id): Check Emacs fixnum range before
177 * window.c (window_scroll_line_based, Frecenter):
178 Check that an Emacs fixnum is in range before assigning it to 'int'.
179 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
180 values converted from Emacs fixnums.
181 (Frecenter): Don't wrap around a line count if it is out of 'int'
182 range; instead, treat it as an extreme value.
183 (Fset_window_configuration, compare_window_configurations):
184 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
186 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
187 that can exceed INT_MAX. Check that EMACS_INT value is in range
188 before assigning it to the (possibly-narrower) index.
189 (match_limit): Don't assume that a fixnum can fit in 'int'.
191 * print.c (print_object): Use ptrdiff_t, not int, for index that can
194 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
195 (Fvertical_motion): Don't wrap around LINES values that don't fit
196 in 'int'. Instead, treat them as extreme values. This is good
197 enough for windows, which can't have more than INT_MAX lines anyway.
199 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
201 * Require libxml/parser.h to avoid compilation warning.
203 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
205 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
206 since this reportedly can destroy thread storage.
208 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
210 * syntax.c (find_defun_start): Update all cache variables if
211 exiting early (Bug#9401).
213 2011-08-30 Eli Zaretskii <eliz@gnu.org>
215 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
217 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
218 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
219 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
221 * term.c (tty_append_glyph): New function.
222 (produce_stretch_glyph): Static function and its prototype deleted.
224 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
227 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
229 * image.c (parse_image_spec): Check for nonnegative, not for positive,
230 when checking :margin (Bug#9390).
231 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
232 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
233 so that the name doesn't mislead. All uses changed.
235 2011-08-28 Johan Bockgård <bojohan@gnu.org>
237 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
240 2011-08-27 Eli Zaretskii <eliz@gnu.org>
242 * xdisp.c (move_it_to): Don't bail out early when reaching
243 position beyond to_charpos, if we are scanning backwards.
244 (move_it_vertically_backward): When DY == 0, make sure we get to
245 the first character in the line after the newline.
247 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
249 * ccl.c: Improve and simplify overflow checking (Bug#9196).
250 (ccl_driver): Do not generate an out-of-range pointer.
251 (Fccl_execute_on_string): Remove unnecessary check for
252 integer overflow, noted by Stefan Monnier in
253 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
254 Remove a FIXME that didn't need fixing.
255 Simplify the newly-introduced buffer reallocation code.
257 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
259 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
261 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
263 Integer and memory overflow issues (Bug#9196).
265 * doc.c (get_doc_string): Rework so that
266 get_doc_string_buffer_size is the actual buffer size, rather than
267 being 1 less than the actual buffer size; this makes xpalloc more
270 * image.c (x_allocate_bitmap_record, cache_image):
271 * xselect.c (Fx_register_dnd_atom):
272 Simplify previous changes by using xpalloc.
274 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
275 since either will do and ptrdiff_t is convenient with xpalloc.
277 * charset.c (charset_table_size)
278 (struct charset_sort_data.priority): Now ptrdiff_t.
279 (charset_compare): Don't overflow if priorities differ greatly.
280 (Fsort_charsets): Don't assume list length fits in int.
281 Check for size-calculation overflow when allocating sort data.
282 (syms_of_charset): Allocate an initial charset table that is
283 just under 64 KiB, to avoid problems with glibc malloc and mmap.
285 * cmds.c (internal_self_insert): Check for size-calculation overflow.
287 * composite.h (struct composition.glyph_len): Now int, not unsigned.
288 The actual value is always <= INT_MAX, and leaving it unsigned made
289 overflow checking harder.
291 * dispextern.h (struct glyph_matrix.rows_allocated)
292 (struct face_cache.size): Now ptrdiff_t, for convenience in use
293 with xpalloc. The values are still always <= INT_MAX.
295 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
297 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
298 (SAFE_NALLOCA): New macro.
300 * region-cache.c (struct boundary.pos, find_cache_boundary)
301 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
302 (set_cache_region, invalidate_region_cache)
303 (revalidate_region_cache, know_region_cache, region_cache_forward)
304 (region_cache_backward, pp_cache):
305 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
306 so that ptrdiff_t * can be passed to xpalloc.
307 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
308 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
309 (pp_cache): Don't assume cache_len fits in int.
310 * region-cache.h: Adjust extern decls to match.
312 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
313 EMACS_INT, since either will do, for xpalloc.
315 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
316 (xnmalloc, xnrealloc, xpalloc): New functions.
318 * bidi.c (bidi_shelve_header_size): New constant.
319 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
320 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
322 * bidi.c (bidi_cache_shrink):
323 * buffer.c (overlays_at, overlays_in, record_overlay_string)
325 Don't update size of array until after memory allocation succeeds,
326 because xmalloc/xrealloc may not return.
327 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
328 now that we have proper integer overflow checking.
329 (record_overlay_string, overlay_strings): Catch overflows when
330 calculating size of overlay_str_buf.
332 * callproc.c (Fcall_process): Check for size overflow when
333 calculating size of args2.
334 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
335 Normally we prefer signed values, but sticking with ptrdiff_t would
336 require adding more-complicated checks.
338 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
339 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
340 Redo buffer-overflow calculations to avoid integer overflow.
341 Add a FIXME comment where memory seems to be over-allocated.
343 * character.c (Fstring): Check for size-calculation overflow.
345 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
346 unnecessary integer overflow. Check for size overflow.
347 (encode_coding_object): Don't update size until xmalloc succeeds.
349 * composite.c (get_composition_id): Check for overflow in glyph
352 Integer and memory overflow fixes for display code.
353 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
354 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
355 (scrolling_window): Check for overflow in size calculations.
356 (line_draw_cost, realloc_glyph_pool, add_row_entry):
357 Don't assume glyph table len fits in int.
358 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
359 (row_table_size): Now ptrdiff_t, not int.
360 (scrolling_window): Avoid overflow in size calculations.
361 Don't update size until allocation succeeds.
362 * fns.c (concat): Check for overflow in size calculations.
363 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
364 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
365 (NEXT_ALMOST_PRIME_LIMIT): New constant.
367 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
368 (get_doc_string): Check for size calculation overflow.
369 Don't update size until allocation succeeds.
370 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
371 EMACS_INT, where ptrdiff_t will do.
372 (Fsubstitute_command_keys): Check for string overflow.
374 * editfns.c (set_time_zone_rule): Don't assume environment length
376 (message_length): Now ptrdiff_t, not int.
377 (Fmessage_box): Don't update size until allocation succeeds.
378 Don't assume message length fits in int.
379 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
381 * emacs.c (main): Do not reallocate argv, since there is a null at
382 the end that can be overwritten, and this way there's no need to
383 worry about size-calculation overflow.
384 (sort_args): Check for size-calculation overflow.
386 * eval.c (init_eval_once, grow_specpdl): Don't update size until
388 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
390 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
391 (x_set_scroll_bar_width, x_figure_window_size):
392 Check for integer overflow.
393 (x_set_alpha): Do not assume XINT fits in int.
395 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
396 This is for the members text_lines, text_cols, total_lines, total_cols,
397 where the system imposes an 'int' limit.
399 * fringe.c (Fdefine_fringe_bitmap):
400 Don't update size until alloc works.
402 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
403 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
405 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
406 Check for size-calculation overflow.
407 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
408 do, as we prefer signed integers.
409 (id_to_widget.max_size, id_to_widget.used)
410 (xg_store_widget_in_map, xg_remove_widget_from_map)
411 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
412 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
413 Use and return ptrdiff_t, not int.
414 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
415 * gtkutil.h: Change prototypes to match the above.
417 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
418 are duplicate now that they've been promoted to lisp.h.
419 (x_allocate_bitmap_record, x_alloc_image_color)
420 (make_image_cache, cache_image, xpm_load):
421 Don't update size until alloc is done.
422 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
424 Check for size calculation overflow.
425 (ct_colors_allocated_max): New constant.
426 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
429 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
430 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
431 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
432 Use ptrdiff_t, not int, to count maps.
433 (read_char_minibuf_menu_prompt): Check for overflow in size
434 calculations. Don't update size until allocation succeeds. Redo
435 calculations to avoid overflow.
436 * keyboard.h: Change prototypes to match the above.
438 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
440 (current_minor_maps): Check for size calculation overflow.
441 * keymap.h: Change prototypes to match the above.
443 * lread.c (read1, init_obarray): Don't update size until alloc done.
445 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
446 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
448 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
449 Now ptrdiff_t, not int.
450 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
451 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
453 * process.c (Fnetwork_interface_list): Check for overflow
456 * region-cache.c (move_cache_gap): Check for size calculation overflow.
458 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
459 overflow. Don't bother calling xmalloc when xrealloc will do.
461 * search.c (Freplace_match): Check for size calculation overflow.
462 (Fset_match_data): Don't assume list lengths fit in 'int'.
464 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
465 for command line length. Do not attempt to address one before the
466 beginning of an array, as that's not portable.
468 * term.c (max_frame_lines): Remove; unused.
469 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
471 (encode_terminal_code, calculate_costs): Check for size
472 calculation overflow.
473 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
474 table lengths and related sizes. Don't update size until alloc
475 done. Redo calculations to avoid overflow.
476 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
478 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
479 subtracting pointers.
480 (gobble_line): Check for overflow more carefully. Don't update size
483 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
484 Don't update size until alloc done.
485 Redo size calculations to avoid overflow.
486 Check for size calculation overflow.
487 (main) [DEBUG]: Fix typo in invoking tparam1.
489 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
490 Use ptrdiff_t, not int, for sizes.
491 (store_mode_line_noprop_char): Don't update size until alloc done.
493 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
494 Use ptrdiff_t, not int, for sizes.
495 (Finternal_make_lisp_face, cache_face):
496 Check for size calculation overflow.
497 (cache_face): Treat size calculation overflows as if they were
498 memory exhaustion (the usual treatment), rather than aborting.
500 * xfns.c (x_encode_text, x_set_name_internal)
501 (Fx_change_window_property): Use ptrdiff_t, not int, to count
502 sizes, since they can exceed INT_MAX in size. Check for size
503 calculation overflow.
505 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
506 (xg_select): Check for size calculation overflow.
507 Don't update size until alloc done.
509 * xrdb.c (get_environ_db): Don't assume path length fits in int,
510 as sprintf is limited to int lengths.
512 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
513 (X_LONG_MIN): New macros.
514 Use them to make the following changes clearer.
515 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
516 This change doesn't affect the value now, but it may help remind
517 future maintainers not to raise the value too much later.
518 (SELECTION_QUANTUM): Remove, replacing with ...
519 (selection_quantum): ... new function, which avoids overflow.
521 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
522 assumption that selection length fits in 'int'.
523 (x_reply_selection_request, x_handle_selection_request)
524 (x_get_window_property, receive_incremental_selection)
525 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
526 (lisp_data_to_selection_data, clean_local_selection_data):
527 Use ptrdiff_t, not int, to record length of selection.
528 (x_reply_selection_request, x_get_window_property)
529 (receive_incremental_selection, x_property_data_to_lisp):
530 Redo calculations to avoid overflow.
531 (x_reply_selection_request): When sending hint, ceiling it at
532 X_LONG_MAX rather than relying on wraparound overflow to send
534 (x_get_window_property, receive_incremental_selection)
535 (lisp_data_to_selection_data, x_property_data_to_lisp):
536 Check for size-calculation overflow.
537 (x_get_window_property, receive_incremental_selection)
538 (lisp_data_to_selection_data, Fx_register_dnd_atom):
539 Don't store size until memory allocation succeeds.
540 (x_get_window_property): Plug memory leak on memory exhaustion.
541 Don't double-block input; malloc is safe here. Don't assume 2**34
542 - 4 fits in unsigned long. Add an xassert to check
543 XGetWindowProperty overflow. Be more careful about overflow
544 calculations, and distinguish size from memory overflow better.
545 (receive_incremental_selection): When tracing, don't assume
546 unsigned int is less than INT_MAX.
547 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
548 harmful) conversions of unsigned short to int.
549 (lisp_data_to_selection_data): Don't assume that integers
550 in the range -65535 through -1 fit in an X unsigned short.
551 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
552 result parameters unless successful. Rely on cons_to_unsigned
553 to report problems with elements; the old code wasn't right anyway.
554 (x_check_property_data): Check for int overflow; we cannot use
555 a wider type due to X limits.
556 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
558 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
560 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
561 (x_term_init): Check for size calculation overflow.
562 (x_color_cells): Don't store size until memory allocation succeeds.
563 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
564 Don't assume alloca size is less than MAX_ALLOCA.
565 (x_term_init): Don't assume length fits in int (sprintf is limited
568 Use ptrdiff_t for composition IDs.
569 * character.c (lisp_string_width):
570 * composite.c (composition_table_size, n_compositions)
571 (get_composition_id, composition_gstring_from_id):
572 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
573 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
574 * window.c (Frecenter):
575 Use ptrdiff_t, not int, for composition IDs.
576 * composite.c (get_composition_id): Check for integer overflow.
577 * composite.h: Adjust prototypes to match the above changes.
579 Use ptrdiff_t for hash table indexes.
580 * category.c (hash_get_category_set):
581 * ccl.c (ccl_driver):
582 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
583 * coding.c (coding_system_charset_list, detect_coding_system):
584 * coding.h (struct coding_system.id):
585 * composite.c (get_composition_id, gstring_lookup_cache):
586 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
587 * image.c (xpm_get_color_table_h):
588 * lisp.h (hash_lookup, hash_put):
589 * minibuf.c (Ftest_completion):
590 Use ptrdiff_t for hash table indexes, not int (which is too
591 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
592 32-bit --with-wide-int hosts).
594 * charset.c (Fdefine_charset_internal): Check for integer overflow.
595 Add a FIXME comment about memory leaks.
596 (syms_of_charset): Don't assume xmalloc returns.
598 Don't assume that stated character widths fit in int.
599 * character.c (Fchar_width, c_string_width, lisp_string_width):
600 * character.h (CHAR_WIDTH):
601 * indent.c (MULTIBYTE_BYTES_WIDTH):
602 Use sanitize_char_width to avoid undefined and/or bad behavior
603 with outlandish widths.
604 * character.h (sanitize_tab_width): Renamed from sanitize_width,
605 now that we have two such functions. All uses changed.
606 (sanitize_char_width): New inline function.
608 Don't assume that tab-width fits in int.
609 * character.h (sanitize_width): New inline function.
610 (SANE_TAB_WIDTH): New macro.
611 (ASCII_CHAR_WIDTH): Use it.
612 * indent.c (sane_tab_width): Remove. All uses replaced by
613 SANE_TAB_WIDTH (current_buffer).
614 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
616 * fileio.c: Integer overflow issues with file modes.
617 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
619 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
620 Remove unreachable code.
621 (read_hex, load_charset_map_from_file): Check for integer overflow.
623 * xterm.c: don't go over XClientMessageEvent limit
624 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
625 (x_send_scroll_bar_event): Likewise. Check that the size does not
626 exceed limits imposed by XClientMessageEvent, as well as the usual
627 ptrdiff_t and size_t limits.
629 * keyboard.c: Overflow, signedness and related fixes.
630 (make_lispy_movement): Use same integer type in forward decl
631 that is used in the definition.
632 (read_key_sequence, keyremap_step):
633 Change bufsize argument back to int, undoing my 2011-03-30 change.
634 We prefer signed types, and int is wide enough here.
635 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
636 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
637 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
638 length, not size_t. Use ptrdiff_t for index, not int.
639 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
640 possibility of integer overflow.
642 Overflow, signedness and related fixes for images.
644 * dispextern.h (struct it.stack[0].u.image.image_id)
645 (struct_it.image_id, struct image.id, struct image_cache.size)
646 (struct image_cache.used, struct image_cache.ref_count):
647 * gtkutil.c (update_frame_tool_bar):
648 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
649 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
650 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
651 * nsmenu.m (update_frame_tool_bar):
652 * xdisp.c (calc_pixel_width_or_height):
653 * xfns.c (image_cache_refcount):
654 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
655 on typical 64-bit hosts.
657 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
658 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
659 Omit unnecessary casts to int.
660 (parse_image_spec): Check that integers fall into 'int' range
661 when the callers expect that.
662 (image_ascent): Redo ascent calculation to avoid int overflow.
663 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
664 (lookup_image): Remove unnecessary tests.
665 (xbm_image_p): Locals are now of int, not EMACS_INT,
666 since parse_image_check makes sure they fit into int.
667 (png_load, gif_load, svg_load_image):
668 Prefer int to unsigned where either will do.
669 (tiff_handler): New function, combining the cores of the
670 old tiff_error_handler and tiff_warning_handler. This
671 function is rewritten to use vsnprintf and thereby avoid
672 stack buffer overflows. It uses only the features of vsnprintf
673 that are common to both POSIX and native Microsoft.
674 (tiff_error_handler, tiff_warning_handler): Use it.
675 (tiff_load, gif_load, imagemagick_load_image):
676 Don't assume :index value fits in 'int'.
677 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
678 (imagemagick_load_image): Check that crop parameters fit into
679 the integer types that MagickCropImage accepts. Don't assume
680 Vimagemagick_render_type has a nonnegative value. Don't assume
681 size_t fits in 'long'.
682 (gs_load): Use printmax_t to print the widest integers possible.
683 Check for integer overflow when computing image height and width.
685 2011-08-26 Eli Zaretskii <eliz@gnu.org>
687 * xdisp.c (redisplay_window): Don't force window start if point
688 will be invisible in the resulting window. (Bug#9324)
690 2011-08-25 Eli Zaretskii <eliz@gnu.org>
692 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
693 the display spec is of the form `(space ...)'.
694 (handle_display_spec): Return the value returned by
695 handle_single_display_spec, not just 1 or zero.
696 (handle_single_display_spec): If the display spec is of the form
697 `(space ...)', and specifies display in the text area, return 2
699 (try_cursor_movement): Check for the need to scroll more
700 accurately, and prefer exact match for point under bidi. Don't
701 advance `row' beyond the last row of the window.
703 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
704 into disp_prop; all users changed.
706 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
707 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
708 for the text covered by the display property.
710 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
712 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
713 Change return value to nil.
714 (Frecord_buffer): Delete unused function.
716 2011-08-24 Eli Zaretskii <eliz@gnu.org>
718 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
719 buffers, return left-to-right.
720 (set_cursor_from_row): Consider candidate row a win if its glyph
721 represents a newline and point is on that newline. Fixes cursor
722 positioning on the newline at EOL of R2L text within L2R
723 paragraph, and vice versa.
724 (try_cursor_movement): Check continued rows, in addition to
725 continuation rows. Fixes unwarranted scroll when point enters a
726 continued line of R2L text within an L2R paragraph, or vice versa.
727 (cursor_row_p): Consider the case of point being equal to
728 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
729 from the end of a short line to the beginning of a continued line
730 of R2L text within L2R paragraph.
731 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
734 * bidi.c (bidi_check_type): Use xassert.
735 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
738 2011-08-23 Eli Zaretskii <eliz@gnu.org>
740 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
743 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
745 * nsfont.m (ns_otf_to_script): Fix typo.
747 2011-08-22 Kenichi Handa <handa@m17n.org>
749 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
750 extra slot even if the purpose is char-code-property-table.
752 2011-08-23 Eli Zaretskii <eliz@gnu.org>
754 * xdisp.c (redisplay_window): When computing centering_position,
755 account for the height of the header line. (Bug#8874)
757 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
758 instead of CHAR_TO_BYTE. Fixes a crash when a completion
759 candidate is selected by the mouse, and that candidate has a
760 composed character under the mouse.
762 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
763 coordinates reported by pos-visible-in-window-p for a composed
764 character in column zero.
766 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
768 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
770 2011-08-22 Eli Zaretskii <eliz@gnu.org>
772 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
773 consider it a hit if to_charpos is anywhere in the range of the
774 composed buffer positions.
776 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
778 * image.c (gif_load): Don't assume that each subimage has the same
779 dimensions as the base image. Handle disposal method that is
780 "undefined" by the gif spec (Bug#9335).
782 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
784 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
785 (Fcondition_case): Document `debug' symbol in error handler.
787 2011-08-19 Eli Zaretskii <eliz@gnu.org>
789 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
790 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
791 from an Org mode buffer to a Speedbar frame.
793 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
794 a composition, take its buffer position from IT->cmp_it.charpos.
795 Fixes cursor positioning at the beginning of a line that begins
796 with a composed character.
798 2011-08-18 Eli Zaretskii <eliz@gnu.org>
800 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
801 character bidirectional type, use STRONG_L instead. Fixes crashes
802 in a buffer produced by `describe-categories'.
804 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
805 members before the level stack, so they would be saved and
806 restored when copying iterator state. Fixes incorrect reordering
807 around TABs covered by display properties.
809 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
811 * process.c (Fnetwork_interface_list): Correctly determine buffer
814 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
816 * eval.c (internal_condition_case, internal_condition_case_1)
817 (internal_condition_case_2, internal_condition_case_n):
818 Remove unnecessary aborts (Bug#9081).
820 2011-08-17 Eli Zaretskii <eliz@gnu.org>
822 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
823 has no `load' handler, try opening the file locally. (Bug#9311)
825 2011-08-16 Ken Brown <kbrown@cornell.edu>
827 * gmalloc.c: Expand comment.
829 2011-08-16 Eli Zaretskii <eliz@gnu.org>
831 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
832 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
834 2011-08-16 Ken Brown <kbrown@cornell.edu>
836 Fix memory allocation problems in Cygwin build (Bug#9273).
838 * unexcw.c ( __malloc_initialized): Declare external variable.
839 (fixup_executable): Force the dumped emacs to reinitialize malloc.
841 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
843 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
845 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
847 [CYGWIN] (special_realloc): New function.
848 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
849 requests to realloc storage in the static heap.
851 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
853 * bidi.c (bidi_initialize): Remove unused local.
855 2011-08-15 Eli Zaretskii <eliz@gnu.org>
857 * biditype.h: File removed.
859 * bidimirror.h: File removed.
861 * deps.mk (bidi.o): Remove biditype.h and
864 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
867 * dispextern.h: Fix a typo in the comment to bidi_type_t.
869 * chartab.c: Improve commentary for the uniprop_table API.
871 * bidi.c (bidi_paragraph_init): Support zero value of
872 bidi_ignore_explicit_marks_for_paragraph_level.
873 (bidi_initialize): Use uniprop_table instead of including
874 biditype.h and bidimirror.h.
876 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
877 coordinates of the iterator when restoring from ppos_it.
880 2011-08-14 Kenichi Handa <handa@m17n.org>
882 * process.c (create_process): Call setup_process_coding_systems
883 after the pid of the process is set to -1 (Bug#8162).
885 2011-08-14 Eli Zaretskii <eliz@gnu.org>
887 * xdisp.c (move_it_in_display_line_to): Don't invoke
888 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
889 ppos_it. Fixes vertical cursor motion when line beginning is
890 covered by an image. (Bug#9296)
892 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
894 * nsterm.h (ns_run_ascript): Declare.
895 (NSAPP_DATA2_RUNASSCRIPT): Define.
897 * nsfns.m (as_script, as_result, as_status): New static variables.
898 (ns_run_ascript): New function.
899 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
900 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
901 the event loop. Get status from as_status (Bug#7276).
903 * nsterm.m (sendEvent): If event is NSApplicationDefined and
904 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
905 the event loop (Bug#7276).
907 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
909 * gnutls.c (QCgnutls_bootprop_priority)
910 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
911 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
912 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
913 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
914 (QCgnutls_bootprop_verify_hostname_error)
915 (QCgnutls_bootprop_callbacks_verify): Rename from
916 Qgnutls_bootprop_..., all uses changed.
918 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
921 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
923 * xfaces.c (Qframe_set_background_mode): Now static.
924 * dispextern.h (Qframe_set_background_mode): Remove decl.
926 * process.c (Fnetwork_interface_info): Declare local only if needed.
928 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
930 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
931 (Fnetwork_interface_list): Allocate in increments of bytes instead
932 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
933 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
935 (struct ifflag_def): notrailers is smart on OSX.
936 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
937 Get hardware address with getifaddrs if available.
939 2011-08-12 Eli Zaretskii <eliz@gnu.org>
941 * xdisp.c (iterate_out_of_display_property): xassert that
942 IT->position is set to within IT->object's boundaries. Break from
943 the loop as soon as EOB is reached; avoids infloops in redisplay
944 when IT->position is set up wrongly due to some bug.
945 Set IT->current to match the bidi iterator unconditionally.
946 (push_display_prop): Allow GET_FROM_STRING as IT->method on
947 entry. Force push_it to save on the stack the current
948 buffer/string position, to be restored by pop_it. Fix flags in
949 the iterator structure wrt the object coming from a display
950 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
951 properties. (Bug#9284)
953 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
955 * fontset.c (fontset_get_font_group): Add proper type checks.
958 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
960 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
961 and LC_VERSION_MIN_MACOSX.
962 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
963 (dump_it) [LC_FUNCTION_STARTS]: Use it.
965 2011-08-08 Eli Zaretskii <eliz@gnu.org>
967 * xdisp.c (forward_to_next_line_start): Allow to use the
968 no-display-properties-and-no-overlays under bidi display.
969 Set disp_pos in the bidi iterator to avoid searches for display
970 properties and overlays.
972 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
974 * editfns.c (Fset_time_zone_rule): Document relationship with the
977 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
978 the font entity extracted from the cache (Bug#8109).
980 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
982 * composite.c (autocmp_chars): Don't reset point. That is done by
983 restore_point_unwind (Bug#5984).
985 2011-08-07 Juri Linkov <juri@jurta.org>
987 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
988 to show the arg `TIME' instead of `TIMEVAL'.
990 2011-08-06 Eli Zaretskii <eliz@gnu.org>
992 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
993 display property strides EOL and includes a newline, as in
994 longlines-mode. (Bug#9254)
995 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
996 word-wrap under bidirectional display. (Bug#9224)
998 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
999 is non-zero, even if the data buffer is NULL. Fixes a crash in
1000 vertical-motion with longlines-mode. (Bug#9254)
1002 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1004 * bidi.c <bidi_cache_total_alloc>: Now static.
1005 (bidi_initialize): Initialize bidi_cache_total_alloc.
1007 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1010 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1011 amount allocated this far in `bidi_cache_total_alloc'.
1012 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1013 non-zero, only free the data buffer without restoring the cache
1014 contents. All callers changed.
1016 * dispextern.h (bidi_unshelve_cache): Update prototype.
1018 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1019 (move_it_in_display_line, move_it_to)
1020 (move_it_vertically_backward, move_it_by_lines): Replace the call
1021 to xfree to an equivalent call to bidi_unshelve_cache.
1022 (move_it_in_display_line_to): Fix logic of returning
1023 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1025 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1027 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1028 came from a string character with a `cursor' property. (Bug#9229)
1030 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1032 * Makefile.in (LIB_PTHREAD): New variable.
1033 (LIBES): Add LIB_PTHREAD (Bug#9216).
1035 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1036 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1038 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1040 * regex.c (re_iswctype): Remove some redundant boolean
1043 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1045 * xterm.c (x_find_topmost_parent): New function.
1046 (x_set_frame_alpha): Find topmost parent window with
1047 x_find_topmost_parent and set the property there also (bug#9181).
1048 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1050 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1052 * callproc.c (Fcall_process): Avoid vfork clobbering
1053 the local vars buffer, coding_systems, current_dir.
1055 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1057 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1059 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1061 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1062 so that it is not optimized away.
1064 * xdisp.c (compute_display_string_pos): Remove unused local.
1066 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1068 Fix slow cursor motion and scrolling in large buffers with
1069 selective display, like Org Mode buffers. (Bug#9218)
1071 * dispextern.h (struct bidi_it): New member disp_prop_p.
1073 * xdisp.c: Remove one-slot cache of display string positions.
1074 (compute_display_string_pos): Accept an additional argument
1075 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1076 for a display string or property. If found, set DISP_PROP_P
1079 * bidi.c (bidi_fetch_char): Accept an additional argument
1080 DISP_PROP_P, and pass it to compute_display_string_pos.
1081 Only handle text covered by a display string if DISP_PROP_P is returned
1082 non-zero. All callers of bidi_fetch_char changed.
1084 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1086 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1088 2010-12-03 Don March <don@ohspite.net>
1090 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1091 last character M-[char] is translated to ESC [char] (bug#7541).
1093 2011-08-02 Kenichi Handa <handa@m17n.org>
1095 * lisp.h (uniprop_table): Extern it.
1097 * chartab.c (uniprop_table): Make it non-static.
1099 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1101 * xdisp.c (forward_to_next_line_start): Accept additional argument
1102 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1104 (reseat_at_next_visible_line_start): Use the bidi iterator state
1105 returned by forward_to_next_line_start to restore the state of
1106 it->bidi_it after backing up to previous newline. (Bug#9212)
1108 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1110 * regex.c (re_comp): Protoize.
1111 (re_exec): Fix return type.
1112 (regexec): Fix type of `ret'. (Bug#9203)
1114 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1116 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1117 This is needed if max-image-size is a floating-point number.
1119 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1121 * print.c (print_object): Print empty symbol as ##.
1123 * lread.c (read1): Read ## as empty symbol.
1125 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1127 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1128 setting frame foreground color (Bug#9175).
1129 (x_set_background_color): Likewise.
1131 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1132 contents (Bug#9176).
1133 (EmacsTooltip -init): Remove bezels and add shadows to
1136 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1137 or scroll bar (Bug#8470).
1139 * nsfont.m (nsfont_open): Remove assignment to voffset and
1140 unnecessary vars hshink, expand, hd, full_height, min_height.
1141 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1143 * nsterm.h (nsfont_info): Remove voffset field.
1145 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1147 Implement strike-through and overline on NextStep (Bug#8863).
1149 * nsfont.m (nsfont_open): Use underline position provided by font,
1150 instead of hard-coded value of 2.
1151 (nsfont_draw): Call ns_draw_text_decoration instead.
1153 * nsterm.h: Add declaration for ns_draw_text_decoration.
1155 * nsterm.m (ns_draw_text_decoration): New function for drawing
1156 underline, overline, and strike-through.
1157 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1158 ns_draw_text_decoration. Change treatment of cursor drawing to
1159 accomodate underlining, etc.
1161 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1163 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1166 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1168 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1169 Without this fix, if a signal arrives just after memory fills up,
1170 'malloc' might be invoked reentrantly.
1172 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1173 In other words, assume that every image size is allowed, on non-X
1174 hosts. This assumption is probably wrong, but it lets Emacs compile.
1176 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1178 * regex.c (re_iswctype): Convert return values to boolean.
1180 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1182 * xdisp.c (compute_display_string_pos): Don't use cached display
1183 string position if the buffer had its restriction changed.
1186 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1188 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1190 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1192 Integer signedness and overflow and related fixes. (Bug#9079)
1194 * bidi.c: Integer size and overflow fixes.
1195 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1196 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1197 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1198 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1199 (bidi_find_other_level_edge):
1200 Use ptrdiff_t instead of EMACS_INT where either will do.
1201 This works better on 32-bit hosts configured --with-wide-int.
1202 (bidi_cache_ensure_space): Check for size-calculation overflow.
1203 Use % rather than repeated addition, for better worst-case speed.
1204 Don't set bidi_cache_size until after xrealloc returns, because it
1206 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1207 (bidi_cache_ensure_space): Also check that the bidi cache size
1208 does not exceed that of the largest Lisp string or buffer. See Eli
1209 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1211 * alloc.c (__malloc_size_t): Remove.
1212 All uses replaced by size_t. See Andreas Schwab's note
1213 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1215 * image.c: Improve checking for integer overflow.
1216 (check_image_size): Assume that f is nonnull, since
1217 it is always nonnull in practice. This is one less thing to
1218 worry about when checking for integer overflow later.
1219 (x_check_image_size): New function, which checks for integer
1220 overflow issues inside X.
1221 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1222 This removes the need for a memory_full check.
1223 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1224 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1225 (xbm_read_bitmap_data): Change locals back to 'int', since
1226 their values must fit in 'int'.
1227 (xpm_load_image, png_load, tiff_load):
1228 Invoke x_create_x_image_and_pixmap earlier,
1229 to avoid much needless work if the image is too large.
1230 (tiff_load): Treat overly large images as if
1231 x_create_x_image_and_pixmap failed, not as malloc failures.
1232 (gs_load): Use x_check_image_size.
1234 * gtkutil.c: Omit integer casts.
1235 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1236 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1238 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1240 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1241 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1242 would wrongly return t on a 64-bit host.
1244 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1245 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1246 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1247 and therefore cause GCC to emit a bogus diagnostic in some cases.
1249 * image.c: Integer signedness and overflow and related fixes.
1250 This is not an exhaustive set of fixes, but it's time to
1251 record what I've got.
1252 (lookup_pixel_color, check_image_size): Remove redundant decls.
1253 (check_image_size): Don't assume that arbitrary EMACS_INT values
1254 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1255 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1256 (tiff_load, imagemagick_load_image):
1257 Check for overflow in size calculations.
1258 (x_create_x_image_and_pixmap): Remove unnecessary test for
1259 xmalloc returning NULL; that can't happen.
1260 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1261 (xpm_color_bucket): Use better integer hashing function.
1262 (xpm_cache_color): Don't possibly over-allocate memory.
1263 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1264 (gif_memory_source):
1265 Use ptrdiff_t, not int or size_t, to record sizes.
1266 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1267 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1268 either works, as we prefer signed integers.
1269 (tiff_read_from_memory, tiff_write_from_memory):
1270 Return tsize_t, not size_t, since that's what the TIFF API wants.
1271 (tiff_read_from_memory): Don't fail simply because the read would
1272 go past EOF; instead, return a short read.
1273 (tiff_load): Omit no-longer-needed casts.
1274 (Fimagemagick_types): Don't assume size fits into 'int'.
1276 Improve hashing quality when configured --with-wide-int.
1277 * fns.c (hash_string): New function, taken from sxhash_string.
1278 Do not discard information about ASCII character case; this
1279 discarding is no longer needed.
1280 (sxhash-string): Use it. Change sig to match it. Caller changed.
1281 * lisp.h: Declare it.
1282 * lread.c (hash_string): Remove, since we now use fns.c's version.
1283 The fns.c version returns a wider integer if --with-wide-int is
1284 specified, so this should help the quality of the hashing a bit.
1286 * emacs.c: Integer overflow minor fix.
1287 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1288 Define only if GNU_LINUX.
1289 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1291 * dispnew.c: Integer signedness and overflow fixes.
1292 Remove unnecessary forward decls, that were a maintenance hassle.
1293 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1295 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1296 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1297 (prepare_desired_row, line_draw_cost):
1298 Use int, not unsigned, where either works.
1299 (save_current_matrix, restore_current_matrix):
1300 Use ptrdiff_t, not size_t, where either works.
1301 (init_display): Check for overflow more accurately, and without
1302 relying on undefined behavior.
1304 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1305 Remove, replacing with the new symbols in lisp.h. All uses changed.
1306 * fileio.c (make_temp_name):
1307 * filelock.c (lock_file_1, lock_file):
1308 * xdisp.c (message_dolog):
1309 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1310 Use pMd etc. instead.
1311 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1312 replacing the pWIDE etc. symbols removed from editfns.c.
1314 * keyboard.h (num_input_events): Now uintmax_t.
1315 This is (very slightly) less likely to mess up due to wraparound.
1318 * buffer.c: Integer signedness fixes.
1319 (alloc_buffer_text, enlarge_buffer_text):
1320 Use ptrdiff_t rather than size_t when either will do, as we prefer
1323 * alloc.c: Integer signedness and overflow fixes.
1324 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1325 (__malloc_size_t): Default to size_t, not to int.
1326 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1327 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1328 Prefer ptrdiff_t to size_t when either would do, as we prefer
1330 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1331 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1332 Now const. Initialize with values that are in range even if char
1334 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1335 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1336 These functions do the right thing with sizes > 2**32.
1337 (check_depth): Now ptrdiff_t, not int.
1338 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1339 Adjust to new way of storing sizes. Check for size overflow bugs
1341 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1342 slightly wrong anyway, as it missed one instance of
1343 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1344 (refill_memory_reserve): Omit needless cast to size_t.
1345 (mark_object_loop_halt): Mark as externally visible.
1347 * xselect.c: Integer signedness and overflow fixes.
1348 (Fx_register_dnd_atom, x_handle_dnd_message):
1349 Use ptrdiff_t, not size_t, since we prefer signed.
1350 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1351 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1352 x_dnd_atoms_size and x_dnd_atoms_length.
1354 * doprnt.c: Prefer signed to unsigned when either works.
1356 * doprnt.c (doprnt):
1358 * xdisp.c (vmessage):
1359 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1360 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1361 prefer signed arithmetic to avoid comparison confusion.
1362 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1363 but is a bit tricky.
1365 Assume freestanding C89 headers, string.h, stdlib.h.
1366 * data.c, doprnt.c, floatfns.c, print.c:
1367 Include float.h unconditionally.
1368 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1369 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1370 * regex.c: Likewise for stddef.h, string.h.
1371 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1372 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1373 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1374 (STDC_HEADERS): Remove obsolete defines.
1375 * sysdep.c: Include limits.h unconditionally.
1377 Assume support for memcmp, memcpy, memmove, memset.
1378 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1379 * regex.c (memcmp, memcpy):
1380 Remove; we assume C89 now.
1382 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1383 (__malloc_safe_bcopy): Remove; no longer needed.
1385 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1386 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1387 well either way, and we prefer signed to unsigned.
1389 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1391 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1392 closes the connection while we're reading (bug#9182).
1394 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1396 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1397 are specified (Bug#9168).
1399 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1401 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1402 Found by GCC static checking and --with-wide-int on a 32-bit host.
1404 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1406 * xdisp.c (compute_display_string_pos): Fix logic of caching
1407 previous display string position. Initialize cached_prev_pos to
1408 -1. Fixes slow-down at the beginning of a buffer.
1410 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1412 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1413 for attrs[LFACE_FONTSET_INDEX].
1415 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1417 * xml.c (parse_region): Remove unused local
1418 that was recently introduced.
1420 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1422 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1423 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1425 * xdisp.c (move_it_in_display_line_to): Record the best matching
1426 position for TO_CHARPOS while scanning the line, and restore it on
1427 exit if none of the characters scanned was an exact match.
1428 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1429 when exact match is impossible due to invisible text, and the
1430 lines are truncated.
1432 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1434 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1437 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1439 Fix a significant slow-down of cursor motion with C-n, C-p,
1440 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1441 auto-repeat under bidi redisplay in fontified buffers.
1442 * xdisp.c (compute_stop_pos_backwards): New function.
1443 (next_element_from_buffer): Call compute_stop_pos_backwards to
1444 find a suitable prev_stop when we find ourselves before
1446 (reseat): Don't look for prev_stop, as that could mean a very long
1448 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1449 <cached_disp_overlay_modiff>: Cache for last found display string
1451 (compute_display_string_pos): Return the cached position if asked
1452 about the same buffer in the same area of character positions, and
1453 the buffer wasn't changed since the time the display string
1454 position was cached.
1456 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1458 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1459 is an integer, which is important for empty lines. (Bug#9149)
1461 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1463 * frame.c (Fmodify_frame_parameters): In tty case, update the
1464 default face if necessary (Bug#4238).
1466 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1468 * editfns.c (Fstring_to_char): No need to explain what a character
1469 is in the docstring (Bug#6576).
1471 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1473 * xml.c (parse_region): Make sure we always return a tree.
1475 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1477 * xml.c (parse_region): If a document contains only comments,
1480 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1482 * xml.c (make_dom): Return comments, too.
1484 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1487 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1488 and the surrounding thread.
1489 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1490 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1491 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1493 * s/openbsd.h (BROKEN_SIGIO): Define.
1494 * unexelf.c (unexec) [__OpenBSD__]:
1495 Don't update the .mdebug section of the Alpha COFF symbol table.
1497 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1499 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1502 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1504 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1505 This fixes some race conditions on the permissions of any newly
1508 * alloc.c (valid_pointer_p): Use pipe, not open.
1509 This fixes some permissions issues when debugging.
1511 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1512 If fchown fails to set both uid and gid, try to set just gid,
1513 as that is sometimes allowed. Adjust the file's mode to eliminate
1514 setuid or setgid bits that are inappropriate if fchown fails.
1516 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1518 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1519 to compare Lisp_Objects.
1520 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1521 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1522 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1524 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1526 * lread.c (read_integer): Unread even EOF character.
1527 (read1): Likewise. Properly record start position of symbol.
1529 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1530 symbol character follows.
1532 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1534 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1535 This works around a problem with the previous change to Fcopy_file.
1536 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1537 and without this change, GCC might complain about discarding
1538 fchown's return value.
1540 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1542 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1544 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1546 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1548 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1550 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1551 it's used from the C level.
1553 * process.c: Use the same condition for POLL_FOR_INPUT in both
1554 keyboard.c and process.c (bug#1858).
1556 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1558 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1559 (Fgnutls_boot): Use it.
1561 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1563 * doc.c (Fsubstitute_command_keys): Revert last change.
1565 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1567 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1568 quotes the next character, and doesn't affect other longer
1569 sequences (bug#8935).
1571 * lread.c (syms_of_lread): Clarify that is isn't only
1572 `eval-buffer' and `eval-defun' that's affected by
1573 `lexical-binding' (bug#8460).
1575 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1577 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1578 bidi redisplay when a line includes both an image and is
1581 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1583 Fix minor problems found by static checking.
1584 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1585 (elsz): Now a signed constant, not a size_t var. We prefer signed
1586 types to unsigned, to avoid integer comparison confusion. Without
1587 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1588 "cannot optimize loop, the loop counter may overflow", a symptom
1590 * indent.c (Fvertical_motion): Mark locals as initialized.
1591 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1593 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1595 * search.c (Fre_search_backward): Mention `case-fold-search' in
1596 all the re_search_* functions (bug#8138).
1598 * keyboard.c (Fopen_dribble_file): Document when the file is
1601 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1603 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1606 Support bidi reordering of display and overlay strings.
1607 * xdisp.c (compute_display_string_pos)
1608 (compute_display_string_end): Accept additional argument STRING.
1609 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1610 (reseat_to_string): Initialize bidi_it->string.s and
1611 bidi_it->string.schars.
1612 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1613 NULL (avoids a crash in bidi_paragraph_init).
1614 Initialize itb.string.lstring.
1615 (init_iterator): Call bidi_init_it only of a valid
1616 buffer position was specified. Initialize paragraph_embedding to
1618 (reseat_to_string): Initialize the bidi iterator.
1619 (display_string): If we need to ignore text properties of
1620 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1621 original value of -1 will not work with bidi.)
1622 (compute_display_string_pos): First arg is now struct
1623 `text_pos *'; all callers changed. Support display properties on
1625 (compute_display_string_end): Support display properties on Lisp
1627 (init_iterator, reseat_1, reseat_to_string): Initialize the
1628 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1629 when iterating on a string not from display properties).
1630 (compute_display_string_pos, compute_display_string_end):
1631 Fix calculation of the object to scan. Fixes an error when using
1633 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1634 base_level_stop; instead, set base_level_stop to BEGV.
1635 Fixes crashes in vertical-motion.
1636 (next_element_from_buffer): Improve commentary for when
1637 the iterator is before prev_stop.
1638 (init_iterator): Initialize bidi_p from the default value of
1639 bidi-display-reordering, not from buffer-local value. Use the
1640 buffer-local value only if initializing for buffer iteration.
1641 (handle_invisible_prop): Support invisible properties on strings
1642 that are being bidi-reordered.
1643 (set_iterator_to_next): Support bidi reordering of C strings and
1645 (next_element_from_string): Support bidi reordering of Lisp
1647 (handle_stop_backwards): Support Lisp strings as well.
1648 (display_string): Support display of R2L glyph rows.
1649 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1650 (init_iterator): Don't initialize it->bidi_p for strings
1652 (reseat_to_string): Initialize it->bidi_p for strings here.
1653 (next_element_from_string, next_element_from_c_string)
1654 (next_element_from_buffer): Add xassert's for correspondence
1655 between IT's object being iterated and it->bidi_it.string
1657 (face_before_or_after_it_pos): Support bidi iteration.
1658 (next_element_from_c_string): Handle the case of the first string
1659 character that is not the first one in the visual order.
1660 (get_visually_first_element): New function, refactored from common
1661 parts of next_element_from_buffer, next_element_from_string, and
1662 next_element_from_c_string.
1663 (tool_bar_lines_needed, redisplay_tool_bar)
1664 (display_menu_bar): Force left-to-right direction. Add a FIXME
1665 comment for making that be controlled by a user option.
1666 (push_it, pop_it): Save and restore the state of the
1667 bidi iterator. Save and restore the bidi_p flag.
1668 (pop_it): Iterate out of display property for string iteration as
1670 (iterate_out_of_display_property): Support iteration over strings.
1671 (handle_single_display_spec): Set up it->bidi_it for iteration
1672 over a display string, and call bidi_init_it.
1673 (handle_single_display_spec, next_overlay_string)
1674 (get_overlay_strings_1, push_display_prop): Set up the bidi
1675 iterator for displaying display or overlay strings.
1676 (forward_to_next_line_start): Don't use the shortcut if
1678 (back_to_previous_visible_line_start): If handle_display_prop
1679 pushed the iterator stack, restore the internal state of the bidi
1680 iterator by calling bidi_pop_it same number of times.
1681 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1682 and we are bidi-iterating, don't decrement the iterator position;
1683 instead, set the first_elt flag in the bidi iterator, to produce
1685 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1686 (push_display_prop): xassert that we are iterating a buffer.
1687 (push_it, pop_it): Save and restore paragraph_embedding member.
1688 (handle_single_display_spec, next_overlay_string)
1689 (get_overlay_strings_1, reseat_1, reseat_to_string)
1690 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1691 correctly. Don't assume unibyte strings are not bidi-reordered.
1692 (compute_display_string_pos)
1693 (compute_display_string_end): Fix handling the case of C string.
1694 (push_it, pop_it): Save and restore from_disp_prop_p.
1695 (handle_single_display_spec, push_display_prop): Set the
1696 from_disp_prop_p flag.
1697 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1698 (pop_it): Call iterate_out_of_display_property only if we are
1699 popping after iteration over a string that came from a display
1700 property. Fix a typo in popping stretch info. Add an assertion
1701 for verifying that the iterator position is in sync with the bidi
1703 (handle_single_display_spec, get_overlay_strings_1)
1704 (push_display_prop): Fix initialization of paragraph direction for
1705 string when that of the parent object is not yet determined.
1706 (reseat_1): Call bidi_init_it to resync the bidi
1707 iterator with IT's position. (Bug#7616)
1708 (find_row_edges): If ROW->start.pos gives position
1709 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1710 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1711 Reset the from_disp_prop_p flag.
1712 (SAVE_IT, RESTORE_IT): New macros.
1713 (pos_visible_p, face_before_or_after_it_pos)
1714 (back_to_previous_visible_line_start)
1715 (move_it_in_display_line_to, move_it_in_display_line)
1716 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1717 (try_scrolling, redisplay_window, display_line): Use them when
1718 saving a temporary copy of the iterator and restoring it back.
1719 (back_to_previous_visible_line_start, reseat_1)
1720 (init_iterator): Empty the bidi cache "stack".
1721 (move_it_in_display_line_to): If iterator ended up at
1722 EOL, but we never saw any buffer positions smaller than
1723 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1724 motion in bidi-reordered lines.
1725 (move_it_in_display_line_to): Record prev_method and prev_pos
1726 immediately before the call to set_iterator_to_next. Fixes cursor
1727 motion in bidi-reordered lines with stretch glyphs and strings
1728 displayed in margins. (Bug#8133) (Bug#8867)
1729 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1731 (pos_visible_p): Support positions in bidi-reordered lines.
1732 Save and restore bidi cache.
1734 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1735 (bidi_paragraph_info): Delete unused struct.
1736 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1737 (bidi_cache_start): New variable.
1738 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1740 (bidi_cache_fetch_state, bidi_cache_search)
1741 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1742 (bidi_cache_find, bidi_peek_at_next_level)
1743 (bidi_level_of_next_char, bidi_find_other_level_edge)
1744 (bidi_move_to_visually_next): Compare cache index with
1745 bidi_cache_start rather than with zero.
1746 (bidi_fetch_char): Accept new argument STRING; all callers
1747 changed. Support iteration over a string. Support strings with
1748 display properties. Support unibyte strings. Fix the type of
1749 `len' according to what STRING_CHAR_AND_LENGTH expects.
1750 (bidi_paragraph_init, bidi_resolve_explicit_1)
1751 (bidi_resolve_explicit, bidi_resolve_weak)
1752 (bidi_level_of_next_char, bidi_move_to_visually_next):
1753 Support iteration over a string.
1754 (bidi_set_sor_type, bidi_resolve_explicit_1)
1755 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1756 can now be zero (for strings); special values 0 and -1 were
1757 changed to -1 and -2, respectively.
1758 (bidi_char_at_pos): New function.
1759 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1760 Call it instead of FETCH_MULTIBYTE_CHAR.
1761 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1762 initialized to valid values.
1763 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1765 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1766 the test for valid cached positions. Fix the logic for looking up
1767 the sentinel state in the cache. GCPRO the Lisp string we are
1769 (bidi_push_it, bidi_pop_it): New functions.
1770 (bidi_initialize): Initialize the bidi cache start stack pointer.
1771 (bidi_cache_ensure_space): New function, refactored from part of
1772 bidi_cache_iterator_state. Don't assume the required size is just
1773 one BIDI_CACHE_CHUNK away.
1774 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1775 (bidi_count_bytes, bidi_char_at_pos): New functions.
1776 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1777 always valid if bidi_cache_idx is valid.
1778 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1779 is valid if it's going to be used.
1780 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1781 (bidi_cache_fetch_state, bidi_cache_search)
1782 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1783 (bidi_cache_iterator_state, bidi_cache_find)
1784 (bidi_find_other_level_edge, bidi_cache_start_stack):
1785 All variables related to cache indices are now EMACS_INT.
1787 * dispextern.h (struct bidi_string_data): New structure.
1788 (struct bidi_it): New member `string'. Make flag members be 1-bit
1789 fields, and put them last in the struct.
1790 (compute_display_string_pos, compute_display_string_end):
1792 (bidi_push_it, bidi_pop_it): Add prototypes.
1793 (struct iterator_stack_entry): New members bidi_p,
1794 paragraph_embedding, and from_disp_prop_p.
1795 (struct it): Member bidi_p is now a bit field 1 bit wide.
1796 (bidi_shelve_cache, bidi_unshelve_cache):
1799 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1800 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1801 and vector-like objects.
1803 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1804 cache around display iteration.
1806 * window.c (Fwindow_end, window_scroll_pixel_based)
1807 (displayed_window_lines, Frecenter): Save and restore the bidi
1808 cache around display iteration.
1810 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1812 * editfns.c (Fdelete_region): Clarify the use of the named
1813 parameters (bug#6788).
1815 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1817 * indent.c (Fvertical_motion): Set and restore w->pointm when
1818 saving and restoring the window's buffer (Bug#9006).
1820 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1822 * editfns.c (Fstring_to_char): Clarify just what is returned
1823 (bug#6576). Text by Eli Zaretskii.
1825 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1827 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1829 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1831 * buffer.c (mmap_find): Fix a typo.
1833 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1835 Fix execution of x selection hooks.
1836 * xselect.c (Qx_lost_selection_functions)
1837 (Qx_sent_selection_functions): New vars.
1838 (syms_of_xselect): DEFSYM them.
1839 (x_handle_selection_request): Pass Qx_sent_selection_functions
1840 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1841 (x_handle_selection_clear,x_clear_frame_selections):
1842 Pass Qx_lost_selection_functions rather than
1843 Vx_lost_selection_functions to Frun_hook_with_args.
1845 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1847 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1848 The old code sometimes used this field without initializing it.
1850 * alloc.c (gc_sweep): Don't read past end of array.
1851 In theory, the old code could also have corrupted Emacs internals,
1852 though it'd be very unlikely.
1854 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1856 * character.c (Fcharacterp): Don't advertise optional ignored
1857 argument. (Bug#4026)
1859 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1861 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1864 * window.c (Fset_window_start): Doc fix (bug#4199).
1865 (Fset_window_hscroll): Ditto.
1867 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1869 Fix minor new problems caught by GCC 4.6.1.
1870 * term.c (init_tty): Remove unused local.
1871 * xsettings.c (store_monospaced_changed): Define this function only
1872 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1875 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1877 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1879 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1881 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1882 are the mini-buffer and the echo area (bug#3320).
1884 * term.c (init_tty): Remove support for supdup, c10 and perq
1885 terminals, which are no longer supported (bug#1482).
1887 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1889 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1891 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1893 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1894 for non-popups (Bug#3642).
1896 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1898 * alloc.c (reset_malloc_hooks): Protoize.
1899 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1900 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1901 * cm.c (losecursor): Likewise.
1902 * data.c (fmod): Likewise.
1903 * dispnew.c (swap_glyphs_in_rows): Likewise.
1904 * emacs.c (memory_warning_signal): Likewise.
1905 * floatfns.c (float_error): Likewise.
1906 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1907 (otf_open, font_otf_capability, generate_otf_features)
1908 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1910 * image.c (pbm_read_file): Likewise.
1911 * indent.c (string_display_width): Likewise.
1912 * intervals.c (check_for_interval, search_for_interval)
1913 (inc_interval_count, count_intervals, root_interval)
1914 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1915 * lread.c (defalias): Likewise.
1916 * ralloc.c (r_alloc_check): Likewise.
1917 * regex.c (set_image_of_range_1, set_image_of_range)
1918 (regex_grow_registers): Likewise.
1919 * sysdep.c (strerror): Likewise.
1920 * termcap.c (valid_filename_p, tprint, main): Likewise.
1921 * tparam.c (main): Likewise.
1922 * unexhp9k800.c (run_time_remap, save_data_space)
1923 (update_file_ptrs, read_header, write_header, calculate_checksum)
1924 (copy_file, copy_rest, display_header): Likewise.
1925 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1927 * xdisp.c (check_it): Likewise.
1928 * xfaces.c (register_color, unregister_color, unregister_colors):
1930 * xfns.c (print_fontset_result): Likewise.
1931 * xrdb.c (member, fatal, main): Likewise.
1933 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1935 Fix minor problems found by static checking (Bug#9031).
1936 * chartab.c (char_table_set_range, map_sub_char_table):
1937 Remove unused locals.
1938 (uniprop_table): Now static.
1939 * composite.c (_work_char): Remove unused static var.
1941 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1943 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1945 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1947 * gtkutil.c (qttip_cb): Remove code without function.
1949 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1951 * w32.c (pthread_sigmask): New stub.
1953 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1955 Use pthread_sigmask, not sigprocmask (Bug#9010).
1956 sigprocmask is portable only for single-threaded applications, and
1957 Emacs can be multi-threaded when it uses GTK.
1958 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1960 * callproc.c (Fcall_process):
1961 * process.c (create_process):
1962 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1963 Use pthread_sigmask, not sigprocmask.
1965 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1967 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1968 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1971 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1973 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1974 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1975 (xg_hide_tooltip): Fix comment.
1977 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1978 in registerServicesMenuSendTypes.
1979 (validRequestorForSendType): Don't check ns_return_types.
1981 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1984 2011-07-08 Jason Rumney <jasonr@gnu.org>
1986 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1987 frame struct members of non-existent frames (Bug#6284).
1989 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1991 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1992 variable firstTime not needed on OSX >= 10.6.
1993 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1994 >= 10.5. Use setKnobProportion, setDoubleValue.
1996 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1997 (MAC_OS_X_VERSION_10_5): Define if not defined.
1998 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1999 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2000 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2002 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2003 cString and lossyCString on OSX >= 10.4
2005 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2006 sizeToFit on OSX >= 10.2.
2008 * nsimage.m (allocInitFromFile): Don't use deprecated method
2009 bestRepresentationForDevice on OSX >= 10.6.
2011 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2014 * emacs.c: Declare unexec_init_emacs_zone.
2016 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2018 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2020 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2021 on svcsMenu (Bug#8842).
2023 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2025 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2027 * nsterm.m (QUTF8_STRING): Declare.
2028 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2029 (validRequestorForSendType): Return type is (id).
2030 Change indexOfObjectIdenticalTo to indexOfObject.
2031 Check if we have local selection before returning self (Bug#8842).
2032 (writeSelectionToPasteboard): Put local selection into paste board
2033 if we have a local selection (Bug#8842).
2034 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2036 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2037 (ns_get_local_selection): Declare.
2039 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2041 * keymap.c (describe_map_tree): Don't insert a double newline at
2042 the end of the buffer (bug#1169) and return whether we inserted
2045 * callint.c (Fcall_interactively): Change "reading args" to
2046 "providing args" to try to clarify what it does (bug#1010).
2048 2011-07-07 Kenichi Handa <handa@m17n.org>
2050 * composite.c (composition_compute_stop_pos): Ignore a static
2051 composition starting before CHARPOS (Bug#8915).
2053 * xdisp.c (handle_composition_prop): Likewise.
2055 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2057 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2060 2011-07-07 Kenichi Handa <handa@m17n.org>
2062 * character.h (unicode_category_t): New enum type.
2064 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2065 (Qchar_code_property_table): New variable.
2066 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2067 (UNIPROP_COMPRESSED_FORM_P): New macros.
2068 (char_table_ascii): Uncompress the compressed values.
2069 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2070 Uncompress the compressed values.
2071 (sub_char_table_ref_and_range): Likewise.
2072 (char_table_ref_and_range): Uncompress the compressed values.
2073 (sub_char_table_set): New arg is_uniprop. Callers changed.
2074 Uncompress the compressed values.
2075 (sub_char_table_set_range): Args changed. Callers changed.
2076 (char_table_set_range): Adjuted for the above change.
2077 (map_sub_char_table): Delete args default_val and parent. Add arg
2078 top. Give decoded values to a Lisp function.
2079 (map_char_table): Adjust for the above change. Give decoded
2080 values to a Lisp function. Gcpro more variables.
2081 (uniprop_table_uncompress)
2082 (uniprop_decode_value_run_length): New functions.
2083 (uniprop_decoder, uniprop_decoder_count): New variables.
2084 (uniprop_get_decoder, uniprop_encode_value_character)
2085 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2087 (uniprop_encoder, uniprop_encoder_count): New variables.
2088 (uniprop_get_encoder, uniprop_table)
2089 (Funicode_property_table_internal, Fget_unicode_property_internal)
2090 (Fput_unicode_property_internal): New functions.
2091 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2092 Sunicode_property_table_internal, Sget_unicode_property_internal,
2093 and Sput_unicode_property_internal. Defvar_lisp
2094 char-code-property-alist.
2096 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2097 Vunicode_category_table.
2099 * font.c (font_range): Adjust for the change of
2100 Vunicode_category_table.
2102 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2104 * m/iris4d.h: Remove file, move contents ...
2105 * s/irix6-5.h: ... here.
2107 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2109 Remove unportable assumption about struct layout (Bug#8884).
2110 * alloc.c (mark_buffer):
2111 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2112 (clone_per_buffer_values): Don't assume that
2113 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2114 This isn't true in general, and it's particularly not true
2115 if Emacs is configured with --with-wide-int.
2116 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2117 New macros, used in the buffer.c change.
2119 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2121 * xsettings.c: Use both GConf and GSettings if both are available.
2122 (store_config_changed_event): Add comment.
2123 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2124 (store_tool_bar_style_changed): New functions.
2125 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2126 (struct xsettings): Move font inside HAVE_XFT.
2127 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2128 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2129 Move inside HAVE_XFT.
2130 (something_changed_gsettingsCB): Rename from something_changedCB.
2131 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2133 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2134 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2135 (something_changed_gconfCB): Rename from something_changedCB.
2136 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2137 (parse_settings): Move check for font inside HAVE_XFT.
2138 (read_settings, apply_xft_settings): Add comment.
2139 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2140 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2141 call store_font_name_changed.
2142 (xft_settings_event): Add comment.
2143 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2144 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2145 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2146 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2147 (xsettings_initialize): Call init_gsettings last.
2148 (xsettings_get_system_font, xsettings_get_system_normal_font):
2151 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2153 Random fixes. E.g., (random) never returned negative values.
2154 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2155 subseconds part to the entropy, as that's a bit more random.
2156 Prefer signed to unsigned, since the signedness doesn't matter and
2157 in general we prefer signed. When given a limit, use a
2158 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2159 latter isn't right if USE_2_TAGS_FOR_INTS.
2160 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2161 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2163 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2165 * textprop.c (text_property_stickiness):
2166 Obey Vtext_property_default_nonsticky.
2167 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2168 * w32fns.c (syms_of_w32fns):
2169 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2171 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2173 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2174 This is more efficient than Ffile_directory_p and avoids a minor race.
2176 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2178 * buffer.c (Foverlay_put): Say what the return value is
2181 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2182 is a directory before asking whether to use the file name
2184 (barf_or_query_if_file_exists): Make the "File is a directory"
2185 error be more correct.
2187 * fns.c (Frequire): Remove the mention of the .gz files, since
2188 that's installation-specific, but keep the mention of
2189 `get-load-suffixes'.
2191 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2193 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2194 Report string overflow if the output is too long.
2196 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2198 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2199 (syms_of_gnutls): Remove duplicate DEFSYM for
2200 Qgnutls_bootprop_verify_hostname_error, an error for
2201 Qgnutls_bootprop_verify_error (which is no longer used).
2203 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2204 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2205 Also (re)move comments that are misplaced or no longer relevant.
2207 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2209 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2211 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2213 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2214 and background color parameters if they have been changed.
2216 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2218 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2220 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2222 * xsettings.c (SYSTEM_FONT): Define only when used.
2223 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2225 * keymap.c (access_keymap_1): Now static.
2227 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2229 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2230 leave any prefix arg for the up event (Bug#1586).
2232 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2234 * lread.c (syms_of_lread): Mention single symbols defined by
2235 `defvar' or `defconst' (bug#7154).
2237 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2238 (Frequire): Mention get-load-suffixes.
2240 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2242 * window.h (window): Remove clone_number slot.
2243 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2245 (make_parent_window, make_window, saved_window)
2246 (Fset_window_configuration, save_window_save): Don't deal with
2248 * buffer.c (Qclone_number): Remove declaration.
2249 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2251 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2253 Add multiple inheritance to keymaps.
2254 * keymap.c (Fmake_composed_keymap): New function.
2255 (Fset_keymap_parent): Simplify.
2256 (fix_submap_inheritance): Remove.
2257 (access_keymap_1): New function extracted from access_keymap to handle
2258 embedded parents and handle lists of maps.
2259 (access_keymap): Use it.
2260 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2261 (Fcopy_keymap): Handle embedded parents.
2262 (Fcommand_remapping, define_as_prefix): Simplify.
2263 (Fkey_binding): Simplify.
2264 (syms_of_keymap): Move minibuffer-local-completion-map,
2265 minibuffer-local-filename-completion-map,
2266 minibuffer-local-must-match-map, and
2267 minibuffer-local-filename-must-match-map to Elisp.
2268 (syms_of_keymap): Defsubr make-composed-keymap.
2269 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2270 (parse_menu_item): Trivial simplification.
2272 2011-07-01 Glenn Morris <rgm@gnu.org>
2274 * Makefile.in (SETTINGS_LIBS): Fix typo.
2276 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2278 * coding.c (Fencode_coding_string): Record the last coding system
2279 used, as the function doc string says (bug#8738).
2281 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2283 * xsettings.c (store_monospaced_changed): Take new font as arg and
2284 check for change against current_mono_font.
2285 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2286 (emacs_settings_constructor, emacs_settings_get_property)
2287 (emacs_settings_set_property, emacs_settings_class_init)
2288 (emacs_settings_init, gsettings_obj): Remove.
2289 (something_changedCB): New function for HAVE_GSETTINGS.
2290 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2291 with value as argument.
2292 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2293 g_settings_new (Bug#8967). Do not create gsettings_obj.
2294 Remove calls to g_settings_bind. Connect something_changedCB to
2297 * xgselect.c: Add defined (HAVE_GSETTINGS).
2298 (xgselect_initialize): Ditto.
2300 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2301 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2304 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2306 * eval.c (struct backtrace): Simplify and port the data structure.
2307 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2308 signed bit field, as this assumption is not portable and it makes
2309 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2310 "char debug_on_exit : 1" as this is not portable either; instead,
2311 use the portable "unsigned int debug_on_exit : 1". Remove unused
2312 member evalargs. Remove obsolete comments about cc bombing out.
2314 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2316 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2317 Let HAVE_GSETTINGS override HAVE_GCONF.
2318 (store_monospaced_changed): New function.
2319 (EMACS_SETTINGS): A new type derived from GObject to handle
2320 GSettings notifications.
2321 (emacs_settings_constructor, emacs_settings_get_property)
2322 (emacs_settings_set_property, emacs_settings_class_init):
2324 (gsettings_client, gsettings_obj): New variables.
2325 (GSETTINGS_SCHEMA): New define.
2326 (something_changedCB): Call store_monospaced_changed.
2327 (init_gsettings): New function.
2328 (xsettings_initialize): Call init_gsettings.
2329 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2332 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2335 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2337 * window.c (resize_root_window, grow_mini_window)
2338 (shrink_mini_window): Rename Qresize_root_window to
2339 Qwindow_resize_root_window and Qresize_root_window_vertically to
2340 Qwindow_resize_root_window_vertically.
2342 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2344 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2346 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2348 * makefile.w32-in: Redesign dependencies so they reflect more
2349 clearly which files are directly included by each source file,
2350 and not through other includes.
2352 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2354 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2355 (sort_overlays, overlay_strings): When an overlay's clone number
2356 matches the window's clone number process the overlay even if
2357 the overlay's window property doesn't match the current window.
2359 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2360 (Fwindow_hchild): Rename to Fwindow_left_child.
2361 (Fwindow_next): Rename to Fwindow_next_sibling.
2362 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2363 (resize_window_check): Rename to window_resize_check.
2364 (resize_window_apply): Rename to window_resize_apply.
2365 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2366 (Fdelete_other_windows_internal, resize_frame_windows)
2367 (Fsplit_window_internal, Fdelete_window_internal)
2368 (grow_mini_window, shrink_mini_window)
2369 (Fresize_mini_window_internal): Fix callers accordingly.
2371 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2373 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2374 (emacs_fixed_set_min_size): Remove.
2375 (emacs_fixed_new): Take frame as argument.
2377 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2378 (_EmacsFixedPrivate): Remove minwidth/height.
2379 Add struct frame *f.
2380 (emacs_fixed_init): Initialize priv->f.
2381 (get_parent_class, emacs_fixed_set_min_size): Remove.
2382 (emacs_fixed_new): Set priv->f to argument.
2383 (emacs_fixed_get_preferred_width)
2384 (emacs_fixed_get_preferred_height): Use min_width/height from
2385 frames size_hint to set minimum and natural (Bug#8919).
2386 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2387 and use min_width/height from frames size_hint to set
2388 min_width/height (Bug#8919).
2390 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2391 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2394 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2396 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2397 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2400 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2402 * process.c (wait_reading_process_output): Bypass select if
2403 waiting for a cell while ignoring keyboard input, and input is
2404 pending. Suggested by Jan Djärv (Bug#8869).
2406 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2408 Use gnulib's dup2 module instead of rolling our own.
2409 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2411 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2413 * dispnew.c (scrolling_window): Before scrolling, turn off a
2414 mouse-highlight in the window being scrolled.
2416 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2418 Move DEFSYM to lisp.h and use everywhere.
2420 * character.h (DEFSYM): Move declaration...
2421 * lisp.h (DEFSYM): ...here.
2427 * w32select.c: Don't include character.h.
2429 * alloc.c (syms_of_alloc):
2430 * buffer.c (syms_of_buffer):
2431 * bytecode.c (syms_of_bytecode):
2432 * callint.c (syms_of_callint):
2433 * casefiddle.c (syms_of_casefiddle):
2434 * casetab.c (init_casetab_once):
2435 * category.c (init_category_once, syms_of_category):
2436 * ccl.c (syms_of_ccl):
2437 * cmds.c (syms_of_cmds):
2438 * composite.c (syms_of_composite):
2439 * dbusbind.c (syms_of_dbusbind):
2440 * dired.c (syms_of_dired):
2441 * dispnew.c (syms_of_display):
2442 * doc.c (syms_of_doc):
2443 * editfns.c (syms_of_editfns):
2444 * emacs.c (syms_of_emacs):
2445 * eval.c (syms_of_eval):
2446 * fileio.c (syms_of_fileio):
2447 * fns.c (syms_of_fns):
2448 * frame.c (syms_of_frame):
2449 * fringe.c (syms_of_fringe):
2450 * insdel.c (syms_of_insdel):
2451 * keymap.c (syms_of_keymap):
2452 * lread.c (init_obarray, syms_of_lread):
2453 * macros.c (syms_of_macros):
2454 * msdos.c (syms_of_msdos):
2455 * print.c (syms_of_print):
2456 * process.c (syms_of_process):
2457 * search.c (syms_of_search):
2458 * sound.c (syms_of_sound):
2459 * syntax.c (init_syntax_once, syms_of_syntax):
2460 * terminal.c (syms_of_terminal):
2461 * textprop.c (syms_of_textprop):
2462 * undo.c (syms_of_undo):
2463 * w32.c (globals_of_w32):
2464 * window.c (syms_of_window):
2465 * xdisp.c (syms_of_xdisp):
2466 * xfaces.c (syms_of_xfaces):
2467 * xfns.c (syms_of_xfns):
2468 * xmenu.c (syms_of_xmenu):
2469 * xsettings.c (syms_of_xsettings):
2470 * xterm.c (syms_of_xterm): Use DEFSYM.
2472 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2474 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2476 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2478 Integer and buffer overflow fixes (Bug#8873).
2480 * print.c (printchar, strout): Check for string overflow.
2481 (PRINTPREPARE, printchar, strout):
2482 Don't set size unless allocation succeeds.
2484 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2485 for sizes. Check for string overflow more accurately.
2486 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2488 * macros.c: Integer and buffer overflow fixes.
2489 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2490 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2491 Use ptrdiff_t, not int, for sizes.
2492 Don't increment bufsize until after realloc succeeds.
2493 Check for size-calculation overflow.
2494 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2496 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2498 * lread.c: Integer overflow fixes.
2499 (read_integer): Radix is now EMACS_INT, not int,
2500 to improve quality of diagnostics for out-of-range radices.
2501 Calculate buffer size correctly for out-of-range radices.
2502 (read1): Check for integer overflow in radices, and in
2503 read-circle numbers.
2504 (read_escape): Avoid int overflow.
2505 (Fload, openp, read_buffer_size, read1)
2506 (substitute_object_recurse, read_vector, read_list, map_obarray):
2507 Use ptrdiff_t, not int, for sizes.
2508 (read1): Use EMACS_INT, not int, for sizes.
2509 Check for size overflow.
2511 * image.c (cache_image): Check for size arithmetic overflow.
2513 * lread.c: Integer overflow issues.
2514 (saved_doc_string_size, saved_doc_string_length)
2515 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2516 Now ptrdiff_t, not int.
2517 (read1): Don't assume doc string length fits in int. Check for
2518 out-of-range doc string lengths.
2519 (read_list): Don't assume file position fits in int.
2520 (read_escape): Check for hex character overflow.
2522 2011-06-22 Leo Liu <sdl.web@gmail.com>
2524 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2525 Move to minibuffer.el.
2527 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2529 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2530 The following patches are for when GLYPH_DEBUG && !XASSERT.
2531 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2532 * dispnew.c (flush_stdout):
2533 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2534 Mark as externally visible.
2535 * dispnew.c (check_window_matrix_pointers): Now static.
2536 * dispnew.c (window_to_frame_vpos):
2537 * xfns.c (unwind_create_frame):
2538 * xterm.c (x_check_font): Remove unused local.
2539 * scroll.c (CHECK_BOUNDS):
2540 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2541 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2542 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2543 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2544 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2546 (debug_method_add): Use va_list and vsprintf rather than relying
2547 on undefined behavior with wrong number of arguments.
2548 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2549 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2550 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2551 since we're not interested in debugging glyphs with old libraries.
2552 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2553 GCC 4.6.0's static checking.
2555 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2557 Integer overflow and signedness fixes (Bug#8873).
2558 A few related buffer overrun fixes, too.
2560 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2562 * dispextern.h (struct face.stipple):
2563 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2564 (x_bitmap_mask, x_allocate_bitmap_record)
2565 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2566 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2567 (x_create_bitmap_from_xpm_data):
2568 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2569 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2571 * xfaces.c (load_pixmap):
2572 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2573 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2574 (.bitmaps_last, struct x_output.icon_bitmap):
2575 Use ptrdiff_t, not int, for bitmap indexes.
2576 (x_allocate_bitmap_record): Check for size overflow.
2577 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2579 Use ptrdiff_t, not int, for overlay counts.
2580 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2581 * editfns.c (overlays_around, get_pos_property):
2582 * textprop.c (get_char_property_and_overlay):
2583 * xdisp.c (next_overlay_change, note_mouse_highlight):
2584 * xfaces.c (face_at_buffer_position):
2585 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2586 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2587 (Fnext_overlay_change, Fprevious_overlay_change)
2588 (mouse_face_overlay_overlaps, Foverlays_in):
2589 Use ptrdiff_t, not int, for sizes.
2590 (overlays_at, overlays_in): Check for size-calculation overflow.
2592 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2594 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2595 (x_session_initialize): Do not assume string length fits in int.
2597 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2598 This is unlikely, but can occur if DPI is outlandish.
2600 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2601 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2603 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2604 * xrdb.c (magic_file_p, search_magic_path):
2605 Omit last arg SUFFIX; it was always 0. All callers changed.
2606 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2608 * xfont.c (xfont_match): Avoid need for strlen.
2610 * xfns.c: Don't assume strlen fits in int.
2611 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2613 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2614 not unsigned long, as we prefer signed integers. All callers changed.
2615 Detect integer overflow in repeat count.
2616 (message_dolog): Don't assume print length fits in 39 bytes.
2617 (display_mode_element): Don't assume strlen fits in int.
2619 * termcap.c: Don't assume sizes fit in int and never overflow.
2620 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2621 (gobble_line): Check for size-calculation overflow.
2623 * minibuf.c (Fread_buffer):
2624 * lread.c (intern, intern_c_string):
2625 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2626 Don't assume string length fits in int.
2628 * keyboard.c (parse_tool_bar_item):
2629 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2631 * font.c: Don't assume string length fits in int.
2632 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2633 Use ptrdiff_t, not int.
2634 (font_intern_prop): Don't assume string length fits in int.
2635 Don't assume integer property fits in fixnum.
2636 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2638 * filelock.c: Fix some buffer overrun and integer overflow issues.
2639 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2640 Reformulate so as not to need the command string.
2641 Invoke gzip -cd rather than gunzip, as it's more portable.
2642 (lock_info_type, lock_file_1, lock_file):
2643 Don't assume pid_t and time_t fit in unsigned long.
2644 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2645 (current_lock_owner): Prefer signed type for sizes.
2646 Use memcpy, not strncpy, where memcpy is what is really wanted.
2647 Don't assume (via atoi) that time_t and pid_t fit in int.
2648 Check for time_t and/or pid_t out of range, e.g., via a network share.
2649 Don't alloca where an auto var works fine.
2651 * fileio.c: Fix some integer overflow issues.
2652 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2653 Don't assume string length fits in int.
2654 (directory_file_name): Don't assume string length fits in long.
2655 (make_temp_name): Don't assume pid fits in int, or that its print
2656 length is less than 20.
2658 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2660 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2662 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2664 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2665 We prefer signed integers, even for size calculations.
2667 * emacs.c: Don't assume string length fits in 'int'.
2668 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2669 (main): Don't invoke strlen when not needed.
2671 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2672 (XD_DEBUG_MESSAGE): Don't waste a byte.
2674 * callproc.c (getenv_internal_1, getenv_internal)
2676 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2678 * lread.c (invalid_syntax): Omit length argument.
2679 All uses changed. This doesn't fix a bug, but it simplifies the
2680 code away from its former Hollerith-constant appearance, and it's
2681 one less 'int' to worry about when looking at integer-overflow issues.
2682 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2684 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2685 This didn't break anything, but it didn't help either.
2686 It's confusing to put a bogus integer in a place where the actual
2687 value does not matter.
2688 (LIST_END_P): Remove unused macro and its bogus comment.
2689 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2691 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2692 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2694 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2695 We prefer signed types, and the value cannot exceed the EMACS_INT
2696 range anyway (because otherwise the length would not be representable).
2697 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2698 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2699 This avoids a GCC warning when WIDE_EMACS_INT.
2701 * indent.c (sane_tab_width): New function.
2702 (current_column, scan_for_column, Findent_to, position_indentation)
2703 (compute_motion): Use it. This is just for clarity.
2704 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2706 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2708 * lisp.h (lint_assume): New macro.
2709 * composite.c (composition_gstring_put_cache):
2710 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2712 * editfns.c, insdel.c:
2713 Omit unnecessary forward decls, to simplify future changes.
2715 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2717 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2719 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2720 Use much-faster test for byte-length change.
2721 Don't assume string byte-length fits in 'int'.
2722 Check that character arg fits in 'int'.
2723 (mapcar1): Declare byte as byte, for clarity.
2725 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2727 * fns.c (concat): Catch string overflow earlier.
2728 Do not rely on integer wraparound.
2730 * dispextern.h (struct it.overlay_strings_charpos)
2731 (struct it.selective): Now EMACS_INT, not int.
2732 * xdisp.c (forward_to_next_line_start)
2733 (back_to_previous_visible_line_start)
2734 (reseat_at_next_visible_line_start, next_element_from_buffer):
2735 Don't arbitrarily truncate the value of 'selective' to int.
2737 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2739 * composite.c: Don't truncate sizes to 'int'.
2740 (composition_gstring_p, composition_reseat_it)
2741 (composition_adjust_point): Use EMACS_INT, not int.
2742 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2743 not EMACS_UINT, for indexes.
2745 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2747 * buffer.c: Include <verify.h>.
2748 (struct sortvec.priority, struct sortstr.priority):
2749 Now EMACS_INT, not int.
2750 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2751 (struct sortstr.size, record_overlay_string)
2752 (struct sortstrlist.size, struct sortlist.used):
2753 Don't truncate size to int.
2754 (record_overlay_string): Check for size-calculation overflow.
2755 (init_buffer_once): Check at compile-time, not run-time.
2757 2011-06-22 Jim Meyering <meyering@redhat.com>
2759 Don't leak an XBM-image-sized buffer
2760 * image.c (xbm_load): Free the image buffer after using it.
2762 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2765 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2766 that Sun C diagnosed.
2767 * fns.c (secure_hash): Fix pointer signedness issue.
2768 * intervals.c (static_offset_intervals): New function.
2769 (offset_intervals): Use it.
2771 2011-06-21 Leo Liu <sdl.web@gmail.com>
2774 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2777 * fns.c (secure_hash): Rename from crypto_hash_function and change
2778 the first arg to accept symbols.
2779 (Fsecure_hash): New primitive.
2780 (syms_of_fns): New symbols.
2782 2011-06-20 Deniz Dogan <deniz@dogan.se>
2784 * process.c (Fset_process_buffer): Clarify return value in
2787 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2789 * dispnew.c (add_window_display_history): Use BVAR.
2791 * xdisp.c (debug_method_add): Use BVAR.
2792 (check_window_end, dump_glyph_matrix, dump_glyph)
2793 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2795 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2798 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2799 check till after the cache is created in init_frame_faces.
2801 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2803 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2805 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2807 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2808 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2809 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2811 Improve buffer-overflow checking (Bug#8873).
2812 * fileio.c (Finsert_file_contents):
2813 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2814 Remove the old (too-loose) buffer overflow checks.
2815 They weren't needed, since make_gap checks for buffer overflow.
2816 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2817 The old code merely checked for Emacs fixnum overflow, and relied
2818 on undefined (wraparound) behavior. The new code avoids undefined
2819 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2821 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2822 Tune. Don't use wider integers than needed. Don't use alloca.
2823 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2825 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2827 * insdel.c, lisp.h (buffer_overflow): New function.
2828 (insert_from_buffer_1, replace_range, replace_range_2):
2829 * insdel.c (make_gap_larger):
2830 * editfns.c (Finsert_char):
2831 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2833 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2835 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2837 Integer overflow and signedness fixes (Bug#8873).
2839 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2840 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2842 * fileio.c: Don't assume EMACS_INT fits in off_t.
2843 (emacs_lseek): New static function.
2844 (Finsert_file_contents, Fwrite_region): Use it.
2845 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2847 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2849 * fns.c: Don't overflow int when computing a list length.
2850 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2851 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2852 truncation on 64-bit hosts. Check for QUIT every
2853 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2854 faster and is responsive enough.
2855 (Flength): Report an error instead of overflowing an integer.
2856 (Fsafe_length): Return a float if the value is not representable
2857 as a fixnum. This shouldn't happen except in contrived situations.
2858 (Fnthcdr, Fsort): Don't assume list length fits in int.
2859 (Fcopy_sequence): Don't assume vector length fits in int.
2861 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2862 (header_size, word_size): New constants.
2863 (allocate_vectorlike): Don't check size overflow here.
2864 (allocate_vector): Check it here instead, since this is the only
2865 caller of allocate_vectorlike that could cause overflow.
2866 Check that the new vector's length is representable as a fixnum.
2868 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2869 The previous code was bogus. For example, next_almost_prime (32)
2870 returned 39, which is undesirable as it is a multiple of 3; and
2871 next_almost_prime (24) returned 25, which is a multiple of 5 so
2872 why was the code bothering to check for multiples of 7?
2874 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2876 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2878 Variadic C functions now count arguments with ptrdiff_t.
2879 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2880 Back then I didn't know that the Emacs coding style prefers signed int.
2881 Also, in the meantime I found a few more instances where arguments
2882 were being counted with int, which may truncate counts on 64-bit
2883 machines, or EMACS_INT, which may be unnecessarily wide.
2884 * lisp.h (struct Lisp_Subr.function.aMANY)
2885 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2886 Arg counts are now ptrdiff_t, not size_t.
2887 All variadic functions and their callers changed accordingly.
2888 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2889 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2890 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2891 * callint.c (Fcall_interactively): Check arg count for overflow,
2892 to avoid potential buffer overrun. Use signed char, not 'int',
2893 for 'varies' array, so that we needn't bother to check its size
2894 calculation for overflow.
2895 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2896 * eval.c (apply_lambda):
2897 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2898 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2899 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2901 * callint.c (Fcall_interactively): Don't use index var as event count.
2903 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2904 * mem-limits.h (SIZE): Remove; no longer used.
2906 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2908 Remove unnecessary casts.
2909 * xterm.c (x_term_init):
2910 * xfns.c (x_set_border_pixel):
2911 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2912 These aren't needed now that we assume ANSI C.
2914 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2915 It's more likely to cause problems (due to unsigned overflow)
2918 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2920 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2922 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2924 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2926 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2928 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2930 GLYPH_CODE_FACE returns EMACS_INT, not int.
2931 * dispextern.h (merge_faces):
2932 * xfaces.c (merge_faces):
2933 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2934 Don't assume EMACS_INT fits in int.
2936 * character.h (CHAR_VALID_P): Remove unused parameter.
2937 * fontset.c, lisp.h, xdisp.c: All uses changed.
2939 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2941 * fns.c (concat): Minor tuning based on overflow analysis.
2942 This doesn't fix any bugs. Use int to hold character, instead
2943 of constantly refetching from Emacs object. Use XFASTINT, not
2944 XINT, for value known to be a character. Don't bother comparing
2945 a single byte to 0400, as it's always less.
2947 * floatfns.c (Fexpt):
2948 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2950 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2953 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2955 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2956 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2957 incorrectly succeed when S was a string, because 4294967386 was
2958 truncated before it was used.
2960 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2961 Otherwise, an out-of-range integer could cause undefined behavior
2964 * composite.c: Use int, not EMACS_INT, for characters.
2965 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2966 EMACS_INT, for values that are known to be in character range.
2967 This doesn't fix any bugs but is the usual style inside Emacs and
2968 may generate better code on 32-bit machines.
2970 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2971 This is for reasons similar to the recent CHAR_STRING fix.
2972 * charset.c (Fencode_char): Check that character arg is actually
2973 a character. Pass an int to ENCODE_CHAR.
2974 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2975 wider than 'int', as a compile-time check to prevent future regressions
2978 * character.c (char_string): Remove unnecessary casts.
2980 Make sure a 64-bit char is never passed to CHAR_STRING.
2981 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2982 by silently ignoring the top 32 bits, allowing some values
2983 that were far too large to be valid characters.
2984 * character.h: Include <verify.h>.
2985 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2986 arguments are no wider than unsigned, as a compile-time check
2987 to prevent future regressions in this area.
2989 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2990 (Fsubst_char_in_region):
2992 * xdisp.c (decode_mode_spec_coding):
2993 Adjust to CHAR_STRING's new requirement.
2994 * editfns.c (Finsert_char, Fsubst_char_in_region):
2995 * fns.c (concat): Check that character args are actually
2996 characters. Without this test, these functions did the wrong
2997 thing with wildly out-of-range values on 64-bit hosts.
2999 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3000 These casts should not be needed on 32-bit hosts, either.
3001 * keyboard.c (read_char):
3002 * lread.c (Fload): Remove casts to unsigned.
3004 * lisp.h (UNSIGNED_CMP): New macro.
3005 This fixes comparison bugs on 64-bit hosts.
3006 (ASCII_CHAR_P): Use it.
3007 * casefiddle.c (casify_object):
3008 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3009 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3010 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3011 * dispextern.h (FACE_FROM_ID):
3012 * keyboard.c (read_char): Use UNSIGNED_CMP.
3014 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3015 not to EMACS_INT, to avoid GCC warning.
3017 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3019 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3020 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3021 isn't needed on 32-bit machines.
3023 * buffer.c (Fgenerate_new_buffer_name):
3024 Use EMACS_INT for count, not int.
3025 (advance_to_char_boundary): Return EMACS_INT, not int.
3027 * data.c (Qcompiled_function): Now static.
3029 * window.c (window_body_lines): Now static.
3031 * image.c (gif_load): Rename local to avoid shadowing.
3033 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3034 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3035 * alloc.c (make_save_value): Integer argument is now of type
3037 (mark_object): Use ptrdiff_t, not int.
3038 * lisp.h (pD): New macro.
3039 * print.c (print_object): Use it.
3041 * alloc.c: Use EMACS_INT, not int, to count objects.
3042 (total_conses, total_markers, total_symbols, total_vector_size)
3043 (total_free_conses, total_free_markers, total_free_symbols)
3044 (total_free_floats, total_floats, total_free_intervals)
3045 (total_intervals, total_strings, total_free_strings):
3046 Now EMACS_INT, not int. All uses changed.
3047 (Fgarbage_collect): Compute overall total using a double, so that
3048 integer overflow is less likely to be a problem. Check for overflow
3049 when converting back to an integer.
3050 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3051 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3052 These were 'int' variables that could overflow on 64-bit hosts;
3053 they were never used, so remove them instead of repairing them.
3054 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3055 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3056 Previously, this ceilinged at INT_MAX, but that doesn't work on
3058 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3060 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3061 (allocate_vectorlike): Check for ptrdiff_t overflow.
3062 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3063 when a (possibly-narrower) signed value would do just as well.
3064 We prefer using signed arithmetic, to avoid comparison confusion.
3066 * alloc.c: Catch some string size overflows that we were missing.
3067 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3068 for convenience in STRING_BYTES_MAX.
3069 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3070 The definition here is exact; the one in lisp.h was approximate.
3071 (allocate_string_data): Check for string overflow. This catches
3072 some instances we weren't catching before. Also, it catches
3073 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3074 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3075 and ptrdiff_t and EMACS_INT are both 64 bits.
3077 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3078 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3079 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3081 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3083 * alloc.c (Fmake_string): Check for out-of-range init.
3085 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3087 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3089 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3091 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3092 xg_get_default_scrollbar_width.
3094 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3095 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3096 (style_changed_cb): Call update_theme_scrollbar_width and call
3097 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3098 all frames (Bug#8505).
3099 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3100 Call gtk_window_set_resizable if HAVE_GTK3.
3101 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3102 and height if HAVE_GTK3 (Bug#8505).
3103 (scroll_bar_width_for_theme): New variable.
3104 (update_theme_scrollbar_width): New function.
3105 (xg_get_default_scrollbar_width): Move code to
3106 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3107 (xg_initialize): Call update_theme_scrollbar_width.
3109 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3111 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3113 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3115 * frame.c (make_frame): Call other_buffer_safely instead of
3118 * window.c (temp_output_buffer_show): Call display_buffer with
3119 second argument Vtemp_buffer_show_specifiers and reset latter
3120 immediately after the call.
3121 (Vtemp_buffer_show_specifiers): New variable.
3122 (auto_window_vscroll_p, next_screen_context_lines)
3123 (Vscroll_preserve_screen_position): Remove leading asterisks from
3126 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3128 Fix minor problems found by GCC 4.6.0 static checking.
3129 * buffer.c (Qclone_number): Remove for now, as it's unused.
3130 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3131 (record_buffer): Remove unused local.
3132 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3133 (set_frame_buffer_list): Remove; unused.
3134 * frame.h (other_visible_frames): Remove decl.
3135 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3136 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3137 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3139 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3140 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3141 Define only if HAVE_GPM.
3142 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3143 (update_hints_inhibit): Remove; never set. All uses removed.
3144 * widgetprv.h (emacsFrameClassRec): Remove decl.
3145 * window.c (delete_deletable_window): Now returns void, since it
3146 wasn't returning anything.
3147 (compare_window_configurations): Remove unused locals.
3148 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3149 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3150 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3151 the same widths as pointers. This follows up on the 2011-05-06 patch.
3152 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3153 * xterm.h: Likewise.
3154 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3156 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3158 * makefile.w32-in: Update dependencies.
3159 (LISP_H): Add lib/intprops.h.
3161 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3163 * image.c (gif_load): Add animation frame delay to the metadata.
3164 (syms_of_image): Use DEFSYM. New symbol `delay'.
3166 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3168 * window.c (delete_deletable_window): Re-add.
3169 (Fset_window_configuration): Rewrite to handle dead buffers and
3170 consequently deletable windows.
3171 (window_tree, Fwindow_tree): Remove. Supply functionality in
3173 (compare_window_configurations): Simplify code.
3175 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3177 * image.c (imagemagick_load_image): Fix type mismatch.
3178 (Fimagemagick_types): Likewise.
3180 * window.h (replace_buffer_in_windows): Declare.
3182 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3184 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3185 Qclone_number. Remove external declaration of Qdelete_window.
3186 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3188 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3189 Run Qbuffer_list_update_hook if allowed.
3190 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3191 buffer list implementation.
3192 (other_buffer_safely): New function.
3193 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3194 calls to replace_buffer_in_windows and
3195 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3197 (record_buffer): Inhibit quitting and rewrite using quittable
3198 functions. Run Qbuffer_list_update_hook if allowed.
3199 (Frecord_buffer, Funrecord_buffer): New functions.
3200 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3201 Move switch-to-buffer to window.el.
3202 (bury-buffer): Move to window.el.
3203 (Vbuffer_list_update_hook): New variable.
3205 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3208 * window.h (resize_frame_windows): Move up in code.
3209 (Fwindow_frame): Remove EXFUN.
3210 (replace_buffer_in_all_windows): Remove prototype.
3211 (replace_buffer_in_windows_safely): Add prototype.
3213 * window.c: Declare Qdelete_window static again. Move down
3214 declaration of select_count.
3215 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3216 (Fother_window): Move to window.el.
3217 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3218 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3219 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3221 (replace_buffer_in_windows): Implement by calling
3222 Qreplace_buffer_in_windows.
3223 (replace_buffer_in_all_windows): Remove with some functionality
3224 moved into replace_buffer_in_windows_safely.
3225 (replace_buffer_in_windows_safely): New function.
3226 (select_window_norecord, select_frame_norecord): Move in front
3227 of run_window_configuration_change_hook. Remove now obsolete
3229 (Fset_window_buffer): Rewrite doc-string.
3230 Call Qrecord_window_buffer.
3231 (keys_of_window): Move binding for other-window to window.el.
3233 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3235 * dispextern.h (struct image): Replace data member, whose int_val
3236 and ptr_val fields were not used by anything, with a single
3239 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3240 (gif_clear_image, gif_load, imagemagick_load_image)
3241 (gs_clear_image, gs_load): Callers changed.
3243 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3245 * buffer.h: Include <time.h>, for time_t.
3246 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3248 Fix minor problems found by static checking.
3250 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3252 Make identifiers static if they are not used in other modules.
3253 * data.c (Qcompiled_function, Qframe, Qvector):
3254 * image.c (QimageMagick, Qsvg):
3255 * minibuf.c (Qmetadata):
3256 * window.c (resize_window_check, resize_root_window): Now static.
3257 * window.h (resize_window_check, resize_root_window): Remove decls.
3259 * window.c (window_deletion_count, delete_deletable_window):
3261 (window_body_lines): Now static.
3262 (Fdelete_other_windows_internal): Mark vars as initialized.
3263 Make sure 'resize_failed' is initialized.
3264 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3265 (resize_window_apply): Remove unused local.
3266 * window.h (delete_deletable_window): Remove decl.
3268 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3269 (imagemagick_load_image): Fix pointer signedness problem by changing
3270 last arg from unsigned char * to char *. All uses changed.
3271 Also, fix a local for similar reasons.
3272 Remove unused locals. Remove locals to avoid shadowing.
3273 (fn_rsvg_handle_free): Remove; unused.
3274 (svg_load, svg_load_image): Fix pointer signedness problem.
3275 (imagemagick_load_image): Don't use garbage pointer image_wand.
3277 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3279 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3281 * image.c (gif_load): Fix omitted cast error introduced by
3284 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3286 * window.h (resize_proportionally, orig_total_lines)
3287 (orig_top_line): Remove from window structure.
3288 (set_window_height, set_window_width, change_window_heights)
3289 (Fdelete_window): Remove prototypes.
3290 (resize_frame_windows): Remove duplicate declaration.
3292 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3294 * window.h (resize_frame_windows, resize_window_check)
3295 (delete_deletable_window, resize_root_window)
3296 (resize_frame_windows): Declare prototypes.
3298 * window.c (resize_window_apply): Make definition be "static" to
3299 match the prototype.
3301 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3303 * window.c: Remove declarations of Qwindow_size_fixed,
3304 window_min_size_1, window_min_size_2, window_min_size,
3305 size_window, window_fixed_size_p, enlarge_window, delete_window.
3306 Remove static from declaration of Qdelete_window, it's
3307 temporarily needed by Fbury_buffer.
3308 (replace_window): Don't assign orig_top_line and
3310 (Fdelete_window, delete_window): Remove. Window deletion is
3311 handled by window.el.
3312 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3313 Replace Fdelete_window calls with calls to Qdelete_window.
3314 (Fdelete_other_windows): Remove. Deleting other windows is
3315 handled by window.el.
3316 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3317 handled in window.el.
3318 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3319 Window minimum sizes are handled in window.el.
3320 (shrink_windows, size_window, set_window_height)
3321 (set_window_width, change_window_heights, window_height)
3322 (window_width, CURBEG, CURSIZE, enlarge_window)
3323 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3324 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3325 handled in window.el.
3326 (make_dummy_parent): Rename to make_parent_window and give it a
3327 second argument horflag.
3328 (make_window): Don't set resize_proportionally any more.
3329 (Fsplit_window): Remove. Windows are split in window.el.
3330 (save_restore_action, save_restore_orig_size)
3331 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3332 Resize mini windows in window.el.
3333 (grow_mini_window, shrink_mini_window): Implement by calling
3334 Qresize_root_window_vertically, resize_window_check and
3335 resize_window_apply.
3336 (saved_window, Fset_window_configuration, save_window_save):
3337 Do not handle orig_top_line, orig_total_lines, and
3338 resize_proportionally.
3339 (window_min_height, window_min_width): Move to window.el.
3340 (keys_of_window): Move bindings for delete-other-windows,
3341 split-window, delete-window and enlarge-window to window.el.
3343 * buffer.c: Temporarily extern Qdelete_window.
3344 (Fbury_buffer): Temporarily call Qdelete_window instead of
3345 Fdelete_window (Fbury_buffer will move to window.el soon).
3347 * frame.c (set_menu_bar_lines_1): Remove code handling
3348 orig_top_line and orig_total_lines.
3350 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3351 set_window_height but set heights directly.
3352 (change_frame_size_1): Use resize_frame_windows.
3354 * xdisp.c (init_xdisp): Don't use set_window_height but set
3357 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3358 Use resize_frame_windows instead of change_window_heights and run
3359 run_window_configuration_change_hook.
3361 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3362 instead of change_window_heights and run
3363 run_window_configuration_change_hook.
3365 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3367 * window.c (replace_window): Rename second argument REPLACEMENT to
3368 NEW. New third argument SETFLAG. Rewrite.
3369 (delete_window, make_dummy_parent): Call replace_window with
3371 (window_list_1): Move down in code.
3372 (run_window_configuration_change_hook): Move set_buffer part
3373 before select_frame_norecord part in order to unwind correctly.
3374 Rename count1 to count.
3375 (recombine_windows, delete_deletable_window, resize_root_window)
3376 (Fdelete_other_windows_internal)
3377 (Frun_window_configuration_change_hook, make_parent_window)
3378 (resize_window_check, resize_window_apply, Fresize_window_apply)
3379 (resize_frame_windows, Fsplit_window_internal)
3380 (Fdelete_window_internal, Fresize_mini_window_internal):
3382 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3384 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3386 * window.h (window): Add some new members to window structure -
3387 normal_lines, normal_cols, new_total, new_normal, clone_number,
3388 splits, nest, prev_buffers, next_buffers.
3389 (WINDOW_TOTAL_SIZE): Move here from window.c.
3390 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3392 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3394 (make_dummy_parent): Set new members of windows structure.
3395 (make_window): Move down in code. Handle new members of window
3397 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3398 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3399 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3400 (Fset_window_prev_buffers, Fwindow_next_buffers)
3401 (Fset_window_next_buffers, Fset_window_clone_number):
3403 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3404 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3406 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3407 Argument WINDOW can be now internal window too.
3408 (Fwindow_use_time): Move up in code.
3409 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3411 (Fset_window_configuration, saved_window)
3412 (Fcurrent_window_configuration, save_window_save): Handle new
3413 members of window structure.
3414 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3415 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3416 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3417 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3418 Qget_mru_window, Qresize_root_window,
3419 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3420 Qauto_buffer_name; staticpro them.
3422 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3424 * window.c (Fwindow_total_size, Fwindow_left_column)
3425 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3426 (Fwindow_list_1): New functions.
3427 (window_box_text_cols): Replace with window_body_cols.
3428 (Fwindow_width, Fscroll_left, Fscroll_right):
3429 Use window_body_cols instead of window_box_text_cols.
3430 (delete_window, Fset_window_configuration):
3431 Call delete_all_subwindows with window as argument.
3432 (delete_all_subwindows): Take a window as argument and not a
3434 (window_loop): Remove handling of GET_LRU_WINDOW and
3436 (Fget_lru_window, Fget_largest_window): Move to window.el.
3438 * window.h: Extern window_body_cols instead of
3439 window_box_text_cols. delete_all_subwindows now takes a
3440 Lisp_Object as argument.
3442 * indent.c (compute_motion, Fcompute_motion):
3443 Use window_body_cols instead of window_box_text_cols.
3445 * frame.c (delete_frame): Call delete_all_subwindows with root
3448 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3450 * fns.c (Fputhash): Document return value.
3452 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3454 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3456 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3458 Cons<->int and similar integer overflow fixes (Bug#8794).
3460 Check for overflow when converting integer to cons and back.
3461 * charset.c (Fdefine_charset_internal, Fdecode_char):
3462 Use cons_to_unsigned to catch overflow.
3463 (Fencode_char): Use INTEGER_TO_CONS.
3464 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3465 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3466 * data.c (long_to_cons, cons_to_long): Remove.
3467 (cons_to_unsigned, cons_to_signed): New functions.
3468 These signal an error for invalid or out-of-range values.
3469 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3470 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3471 * font.c (Ffont_variation_glyphs):
3472 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3473 * lisp.h: Include <intprops.h>.
3474 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3475 (cons_to_signed, cons_to_unsigned): New decls.
3476 (long_to_cons, cons_to_long): Remove decls.
3477 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3478 (Fprimitive_undo): Use CONS_TO_INTEGER.
3479 * xfns.c (Fx_window_property): Likewise.
3480 * xselect.c: Include <limits.h>.
3481 (x_own_selection, selection_data_to_lisp_data):
3482 Use INTEGER_TO_CONS.
3483 (x_handle_selection_request, x_handle_selection_clear)
3484 (x_get_foreign_selection, Fx_disown_selection_internal)
3485 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3486 (lisp_data_to_selection_data): Use cons_to_unsigned.
3487 (x_fill_property_data): Use cons_to_signed.
3488 Report values out of range.
3490 Check for buffer and string overflow more precisely.
3491 * buffer.h (BUF_BYTES_MAX): New macro.
3492 * lisp.h (STRING_BYTES_MAX): New macro.
3493 * alloc.c (Fmake_string):
3494 * character.c (string_escape_byte8):
3495 * coding.c (coding_alloc_by_realloc):
3496 * doprnt.c (doprnt):
3497 * editfns.c (Fformat):
3499 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3500 since they may not be the same number.
3501 * editfns.c (Finsert_char):
3502 * fileio.c (Finsert_file_contents):
3503 Likewise for BUF_BYTES_MAX.
3505 * image.c: Use ptrdiff_t, not int, for sizes.
3506 (slurp_file): Switch from int to ptrdiff_t.
3508 (slurp_file): Check that file size fits in both size_t (for
3509 malloc) and ptrdiff_t (for sanity and safety).
3511 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3512 if b->modtime has its maximal value.
3514 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3516 Don't assume time_t can fit into int.
3517 * buffer.h (struct buffer.modtime): Now time_t, not int.
3518 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3519 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3521 Minor fixes for signed vs unsigned integers.
3522 * character.h (MAYBE_UNIFY_CHAR):
3523 * charset.c (maybe_unify_char):
3524 * keyboard.c (read_char, reorder_modifiers):
3525 XINT -> XFASTINT, since the integer must be nonnegative.
3526 * ftfont.c (ftfont_spec_pattern):
3527 * keymap.c (access_keymap, silly_event_symbol_error):
3528 XUINT -> XFASTINT, since the integer must be nonnegative.
3529 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3530 since it makes no difference and we prefer signed.
3531 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3532 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3535 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3537 * window.h (Fwindow_frame): Declare.
3539 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3541 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3542 (SPARE_MEMORY): Always define.
3543 (LARGE_REQUEST): Remove.
3544 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3546 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3548 * lisp.h: Move EXFUNS for Fframe_root_window,
3549 Fframe_first_window and Fset_frame_selected_window to window.h.
3551 * window.h: Move EXFUNS for Fframe_root_window,
3552 Fframe_first_window and Fset_frame_selected_window here from
3555 * frame.c (Fwindow_frame, Fframe_first_window)
3556 (Fframe_root_window, Fframe_selected_window)
3557 (Fset_frame_selected_window): Move to window.c.
3558 (Factive_minibuffer_window): Move to minibuf.c.
3559 (Fother_visible_frames_p): New function.
3561 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3563 * window.c (decode_window, decode_any_window): Move up in code.
3564 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3565 (inhibit_frame_unsplittable): Remove unused variable.
3566 (Fwindow_buffer): Move up and rewrite doc-string.
3567 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3568 (Fwindow_prev): New functions.
3569 (Fwindow_frame): Move here from frame.c. Accept any window as
3571 (Fframe_root_window, Fframe_first_window)
3572 (Fframe_selected_window): Move here from frame.c. Accept frame
3573 or arbitrary window as argument. Update doc-strings.
3574 (Fminibuffer_window): Move up in code.
3575 (Fwindow_minibuffer_p): Move up in code and simplify.
3576 (Fset_frame_selected_window): Move here from frame.c.
3578 (Fselected_window, select_window, Fselect_window): Move up in
3579 code. Minor doc-string fixes.
3581 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3583 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3584 Do not assume that spare memory exists; that assumption is valid
3585 only if SYSTEM_MALLOC.
3586 (LARGE_REQUEST): New macro, so that the issue of large requests
3587 is separated from the issue of spare memory.
3589 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3591 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3594 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3596 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3599 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3601 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3603 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3605 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3606 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3608 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3610 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3612 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3614 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3615 (x_clipboard_manager_save): Add return value.
3616 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3618 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3619 Obey Vx_select_enable_clipboard_manager. Catch errors in
3620 x_clipboard_manager_save (Bug#8779).
3621 (Vx_select_enable_clipboard_manager): New variable.
3622 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3624 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3626 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3628 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3630 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3631 in the current matrix if keep_current_p is non-zero.
3633 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3635 * bidi.c (bidi_level_of_next_char): Fix last change.
3637 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3639 Support bidi reordering of text covered by display properties.
3641 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3642 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3643 (bidi_cache_search, bidi_cache_iterator_state)
3644 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3645 (bidi_level_of_next_char, bidi_move_to_visually_next):
3646 Support character positions inside a run of characters covered by a
3648 (bidi_paragraph_init, bidi_resolve_explicit_1)
3649 (bidi_level_of_next_char): Call bidi_fetch_char and
3650 bidi_fetch_char_advance instead of FETCH_CHAR and
3652 (bidi_init_it): Initialize new members.
3653 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3655 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3656 instead of using explicit *_CHAR codes.
3657 (bidi_resolve_explicit, bidi_resolve_weak):
3658 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3659 bidirectional text is supported only in multibyte buffers.
3660 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3661 it to initialize the frame_window_p member of struct bidi_it.
3662 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3663 (bidi_resolve_explicit, bidi_resolve_weak)
3664 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3665 bidi_it->nchars is non-positive.
3666 (bidi_level_of_next_char): Don't try to lookup the cache for the
3667 next/previous character if nothing is cached there yet, or if we
3668 were just reseat()'ed to a new position.
3670 * xdisp.c (set_cursor_from_row): Set start and stop points
3671 according to the row's direction when priming the loop that looks
3672 for the glyph on which to display cursor.
3673 (single_display_spec_intangible_p): Function deleted.
3674 (display_prop_intangible_p): Reimplement to call
3675 handle_display_spec instead of single_display_spec_intangible_p.
3676 Accept 3 additional arguments needed by handle_display_spec.
3677 This fixes incorrect cursor motion across display property with complex
3678 values: lists, `(when COND...)' forms, etc.
3679 (single_display_spec_string_p): Support property values that are
3680 lists with the argument STRING its top-level element.
3681 (display_prop_string_p): Fix the condition for processing a
3682 property that is a list to be consistent with handle_display_spec.
3683 (handle_display_spec): New function, refactored from the
3684 last portion of handle_display_prop.
3685 (compute_display_string_pos): Accept additional argument
3686 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3687 value of a `display' property is a "replacing spec".
3688 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3689 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3690 the display property, but just return a value indicating whether
3691 the display property will replace the characters it covers.
3692 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3693 frame_window_p members of struct bidi_it.
3694 (compute_display_string_pos, compute_display_string_end):
3696 (push_it): Accept second argument POSITION, where pop_it should
3697 jump to continue iteration.
3698 (reseat_1): Initialize bidi_it.disp_pos.
3700 * keyboard.c (adjust_point_for_property): Adjust the call to
3701 display_prop_intangible_p to its new signature.
3703 * dispextern.h (struct bidi_it): New member frame_window_p.
3704 (bidi_init_it): Update prototypes.
3705 (display_prop_intangible_p): Update prototype.
3706 (compute_display_string_pos, compute_display_string_end):
3708 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3711 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3713 Malloc failure behavior now depends on size of allocation.
3714 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3715 * lisp.h: Change signatures accordingly.
3716 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3717 All callers changed. (Bug#8762)
3719 * gnutls.c: Use Emacs's memory allocators.
3720 Without this change, the gnutls library would invoke malloc etc.
3721 directly, which causes problems on non-SYNC_INPUT hosts, and which
3722 runs afoul of improving memory_full behavior. (Bug#8761)
3723 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3724 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3725 xfree instead of the default malloc, realloc, free.
3726 (Fgnutls_boot): No need to check for memory allocation failure,
3727 since xmalloc does that for us.
3729 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3730 * category.c (hash_get_category_set):
3731 * ccl.c (ccl_driver):
3732 * charset.c (Fdefine_charset_internal):
3733 * charset.h (struct charset.hash_index):
3734 * composite.c (get_composition_id, gstring_lookup_cache)
3735 (composition_gstring_put_cache):
3736 * composite.h (struct composition.hash_index):
3737 * dispextern.h (struct image.hash):
3738 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3739 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3740 (hashfn_equal, hashfn_user_defined, make_hash_table)
3741 (maybe_resize_hash_table, hash_lookup, hash_put)
3742 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3743 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3744 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3745 * image.c (make_image, search_image_cache, lookup_image)
3746 (xpm_put_color_table_h):
3747 * lisp.h (struct Lisp_Hash_Table):
3748 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3749 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3750 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3751 * alloc.c (allocate_vectorlike):
3752 Check for overflow in vector size calculations.
3753 * ccl.c (ccl_driver):
3754 Check for overflow when converting EMACS_INT to int.
3755 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3756 need to be updated by these changes.
3757 * fns.c (make_hash_table, maybe_resize_hash_table):
3758 Check for integer overflow with large hash tables.
3759 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3760 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3761 (SXHASH_REDUCE): New macro.
3762 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3763 Use it instead of discarding useful hash info with large hash values.
3764 (sxhash_float): New function.
3765 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3766 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3767 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3768 Rewrite to use FIXNUM_BITS, as this simplifies things.
3769 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3770 Adjust signatures to match updated version of code.
3771 (consing_since_gc): Now EMACS_INT, since a single hash table can
3772 use more than INT_MAX bytes.
3774 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3776 Make it possible to build with GCC-4.6+ -O2 -flto.
3778 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3780 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3782 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3783 Call minibuffer-inactive-mode.
3785 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3787 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3788 Update dependencies.
3790 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3792 * data.c (init_data): Remove code for UTS, this system is not
3795 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3797 Don't force ./temacs to start in terminal mode.
3799 * frame.c (make_initial_frame): Initialize faces in all cases, not
3800 only when CANNOT_DUMP is defined.
3801 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3803 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3805 * dispnew.c (add_window_display_history): Use const for the string
3806 pointer. Remove declaration, not needed.
3808 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3810 Use 'inline', not 'INLINE'.
3811 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3812 * alloc.c, fontset.c (INLINE): Remove.
3813 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3814 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3815 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3816 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3817 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3819 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3821 Make it possible to run ./temacs.
3823 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3824 syms_of_callproc does the same thing. Remove test for
3825 "initialized", do it in the caller.
3826 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3828 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3830 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3831 (read_minibuf): Use get_minibuffer.
3832 (syms_of_minibuf): Use DEFSYM.
3833 (Qmetadata): New var.
3834 * data.c (Qbuffer): Don't make it static.
3835 (syms_of_data): Use DEFSYM.
3837 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3839 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3840 (CCL_CODE_MIN): New macro.
3842 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3844 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3846 * eval.c (Qdebug): Now static.
3847 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3848 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3849 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3851 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3853 * image.c: Various fixes to ImageMagick code comments.
3854 (Fimagemagick_types): Doc fix.
3856 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3858 Minor fixes prompted by GCC 4.6.0 warnings.
3860 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3862 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3863 (x_clipboard_manager_save_all): Move extern decl to ...
3864 * xterm.h: ... here, so that it can be checked for consistency.
3866 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3868 * xselect.c (x_clipboard_manager_save_frame)
3869 (x_clipboard_manager_save_all): New functions.
3870 (Fx_clipboard_manager_save): Lisp function deleted.
3872 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3873 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3875 * xterm.h: Update prototype.
3877 2011-05-28 William Xu <william.xwl@gmail.com>
3879 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3882 2011-05-28 Jim Meyering <meyering@redhat.com>
3884 Avoid a sign-extension bug in crypto_hash_function.
3885 * fns.c (to_uchar): Define.
3886 (crypto_hash_function): Use it to convert some newly-signed
3887 variables to unsigned, to avoid sign-extension bugs. For example,
3888 without this change, (md5 "truc") would evaluate to
3889 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3890 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3891 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3893 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3895 Integer overflow fixes.
3897 * dbusbind.c: Serial number integer overflow fixes.
3898 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3899 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3900 to hold a serial number that is too large for a fixnum.
3901 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3902 Check for serial numbers out of range. Decode any serial number
3903 that was so large that it became a float. (Bug#8722)
3905 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3906 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3907 Use XFASTINT rather than XUINT when numbers are nonnegative.
3908 (xd_append_arg, Fdbus_method_return_internal):
3909 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3910 arguments, check that Lisp number is nonnegative, rather than
3911 silently wrapping negative numbers around. (Bug#8722)
3912 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3915 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3917 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3919 ccl: add integer overflow checks
3920 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3921 (IN_INT_RANGE): New macros.
3922 (ccl_driver): Use them to check for integer overflow when
3923 decoding a CCL program. Many of the new checks are whether XINT (x)
3924 fits in int; it doesn't always, on 64-bit hosts. The new version
3925 doesn't catch all possible integer overflows, but it's an
3926 improvement. (Bug#8719)
3928 * alloc.c (make_event_array): Use XINT, not XUINT.
3929 There's no need for unsigned here.
3931 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3932 This follows up to the 2011-05-06 change that substituted uintptr_t
3933 for EMACS_INT. This case wasn't caught back then.
3935 Rework Fformat to avoid integer overflow issues.
3936 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3937 now (part of C89). Include <verify.h>.
3938 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3939 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3940 (Fformat): Avoid the prepass trying to compute sizes; it was only
3941 approximate and thus did not catch overflow reliably. Instead, walk
3942 through the format just once, formatting and computing sizes as we go,
3943 checking for integer overflow at every step, and allocating a larger
3944 buffer as needed. Keep track separately whether the format is
3945 multibyte. Keep only the most-recently calculated precision, rather
3946 than them all. Record whether each argument has been converted to
3947 string. Use EMACS_INT, not int, for byte and char and arg counts.
3948 Support field widths and precisions larger than INT_MAX. Avoid
3949 sprintf's undefined behavior with conversion specifications such as %#d
3950 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3951 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3952 formatting out-of-range floating point numbers with int
3955 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3957 * data.c: Avoid integer truncation in expressions involving floats.
3958 * data.c: Include <intprops.h>.
3959 (arith_driver): When there's an integer overflow in an expression
3960 involving floating point, convert the integers to floating point
3961 so that the resulting value does not suffer from catastrophic
3962 integer truncation. For example, on a 64-bit host (* 4
3963 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3964 Do not rely on undefined behavior after integer overflow.
3966 merge count_size_as_multibyte, parse_str_to_multibyte
3967 * character.c, character.h (count_size_as_multibyte):
3968 Rename from parse_str_to_multibyte; all uses changed.
3969 Check for integer overflow.
3970 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3971 since it's now a duplicate of the other. This is more of
3972 a character than a buffer op, so better that it's in character.c.
3973 * fns.c, print.c: Adjust to above changes.
3975 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3977 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3979 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3981 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3982 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3983 (x_clipboard_manager_save): Now static.
3984 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3986 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3987 (crypto_hash_function): Now static.
3988 Fix pointer signedness problems. Avoid unnecessary initializations.
3990 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3992 * termhooks.h (Vselection_alist): Make it terminal-local.
3994 * terminal.c (create_terminal): Initialize it.
3996 * xselect.c: Support for clipboard managers.
3997 (Vselection_alist): Move to termhooks.h as terminal-local var.
3998 (LOCAL_SELECTION): New macro.
3999 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4000 (symbol_to_x_atom): Remove gratuitous arg.
4001 (x_handle_selection_request, lisp_data_to_selection_data)
4002 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4003 (x_own_selection, x_get_local_selection, x_convert_selection):
4004 New arg, specifying work frame. Use terminal-local Vselection_alist.
4005 (some_frame_on_display): Delete unused function.
4006 (Fx_own_selection_internal, Fx_get_selection_internal)
4007 (Fx_disown_selection_internal, Fx_selection_owner_p)
4008 (Fx_selection_exists_p): New optional frame arg.
4009 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4010 (x_handle_selection_clear): Don't treat other terminals with the
4011 same keyboard specially. Use the terminal-local Vselection_alist.
4012 (x_clear_frame_selections): Use Frun_hook_with_args.
4014 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4016 * xterm.h: Add support for those atoms.
4018 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4020 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4021 (converted_selections, conversion_fail_tag): New global variables.
4022 (x_selection_request_lisp_error): Free the above.
4023 (x_get_local_selection): Remove unnecessary code.
4024 (x_reply_selection_request): Args changed; handle arbitrary array
4025 of converted selections stored in converted_selections.
4026 Separate the XChangeProperty and SelectionNotify steps.
4027 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4028 (x_convert_selection): New function.
4029 (x_handle_selection_event): Simplify.
4030 (x_get_foreign_selection): Don't ignore incoming requests while
4031 waiting for an answer; this will fail when we implement
4032 SAVE_TARGETS, and seems unnecessary anyway.
4033 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4034 (Vx_sent_selection_functions): Doc fix.
4036 2011-05-26 Leo Liu <sdl.web@gmail.com>
4038 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4040 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4042 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4044 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4045 for fringe update if it has periodic bitmap.
4046 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4047 and fringe_bitmap_periodic_p.
4049 * fringe.c (get_fringe_bitmap_data): New function.
4050 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4051 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4052 row. Mark glyph row for fringe update if periodicity changed.
4054 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4055 for fringe update unless it has periodic bitmap.
4057 2011-05-25 Kenichi Handa <handa@m17n.org>
4059 * xdisp.c (get_next_display_element): Set correct it->face_id for
4060 a static composition.
4062 2011-05-24 Leo Liu <sdl.web@gmail.com>
4065 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4067 * fns.c (crypto_hash_function, Fsha1): New function.
4068 (Fmd5): Use crypto_hash_function.
4069 (syms_of_fns): Add Ssha1.
4071 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4073 * gnutls.c: Remove unused macros.
4074 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4075 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4076 Remove macros that are defined and never used.
4077 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4079 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4081 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4082 (Fx_get_selection_internal): Minor cleanup.
4083 (Fx_own_selection_internal): Rename arguments for consistency with
4086 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4088 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4090 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4092 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4094 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4096 * dispnew.c (scrolling_window): Don't exclude the case that the
4097 last enabled row in the desired matrix touches the bottom boundary.
4099 2011-05-21 Glenn Morris <rgm@gnu.org>
4101 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4102 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4103 and add some more files.
4105 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4107 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4108 report_file_error introduced by the change from 2011-05-07.
4110 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4112 * systime.h (Time): Define only if emacs is defined.
4113 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4114 where the include path doesn't have X11/X.h by default. See
4115 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4117 2011-05-20 Kenichi Handa <handa@m17n.org>
4119 * composite.c (find_automatic_composition): Fix previous change.
4121 2011-05-20 Glenn Morris <rgm@gnu.org>
4123 * lisp.mk: New file, split from Makefile.in.
4124 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4125 (shortlisp): Remove.
4126 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4128 2011-05-19 Glenn Morris <rgm@gnu.org>
4130 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4131 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4132 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4133 (lisp): Set the order to that of loadup.el.
4134 (shortlisp): Make it a copy of $lisp.
4135 (SOME_MACHINE_LISP): Remove.
4136 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4137 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4139 2011-05-18 Kenichi Handa <handa@m17n.org>
4141 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4142 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4143 (find_automatic_composition): Mostly rewrite for efficiency.
4145 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4147 * makefile.w32-in: Update dependencies.
4149 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4151 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4152 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4154 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4156 Fix some integer overflow issues, such as string length overflow.
4158 * insdel.c (count_size_as_multibyte): Check for string overflow.
4160 * character.c (lisp_string_width): Check for string overflow.
4161 Use EMACS_INT, not int, for string indexes and lengths; in
4162 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4163 the resulting string length overflows an EMACS_INT; instead,
4164 report a string overflow if no precision given. When checking for
4165 precision exhaustion, use a check that cannot possibly have
4166 integer overflow. (Bug#8675)
4167 * character.h (lisp_string_width): Adjust to new signature.
4169 * alloc.c (string_overflow): New function.
4170 (Fmake_string): Use it. This doesn't change behavior, but saves
4171 a few bytes and will simplify future changes.
4172 * character.c (string_escape_byte8): Likewise.
4173 * lisp.h (string_overflow): New decl.
4175 Fixups, following up to the user-interface timestamp change.
4176 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4177 for UI timestamps, instead of unsigned long.
4178 * msdos.c (mouse_get_pos): Likewise.
4179 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4180 * w32gui.h (Time): Define by including "systime.h" rather than by
4181 declaring it ourselves. (Bug#8664)
4183 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4184 * image.c (clear_image_cache): Likewise.
4186 * term.c (term_mouse_position): Don't assume time_t wraparound.
4188 Be more systematic about user-interface timestamps.
4189 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4190 and sometimes 'EMACS_UINT', to represent these timestamps.
4191 This change causes it to use 'Time' uniformly, as that's what X uses.
4192 This makes the code easier to follow, and makes it easier to catch
4193 integer overflow bugs such as Bug#8664.
4194 * frame.c (Fmouse_position, Fmouse_pixel_position):
4195 Use Time, not unsigned long, for user-interface timestamps.
4196 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4197 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4198 * keyboard.h (last_event_timestamp): Likewise.
4199 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4200 * menu.h (xmenu_show): Likewise.
4201 * term.c (term_mouse_position): Likewise.
4202 * termhooks.h (struct input_event.timestamp): Likewise.
4203 (struct terminal.mouse_position_hook): Likewise.
4204 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4205 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4206 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4207 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4209 * menu.h, termhooks.h: Include "systime.h", for Time.
4211 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4212 Don't assume that the difference between two unsigned long values
4213 can fit into an integer. At this point, we know button_down_time
4214 <= event->timestamp, so the difference must be nonnegative, so
4215 there's no need to cast the result if double-click-time is
4216 nonnegative, as it should be; check that it's nonnegative, just in
4217 case. This bug is triggered when events are more than 2**31 ms
4218 apart (about 25 days). (Bug#8664)
4220 * xselect.c (last_event_timestamp): Remove duplicate decl.
4221 (x_own_selection): Remove needless cast to unsigned long.
4223 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4224 that always fit in int. Use a sentinel instead of a counter, to
4225 avoid a temp and to allay GCC's concerns about possible int overflow.
4226 * frame.h (struct frame): Use int for menu_bar_items_used
4227 instead of EMACS_INT, since it always fits in int.
4229 * menu.c (grow_menu_items): Check for int overflow.
4231 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4233 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4234 Before, the code was not consistent. These values cannot exceed
4235 2**31 - 1 so there's no need to make them unsigned.
4236 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4237 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4238 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4240 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4242 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4243 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4244 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4245 presumably because the widths might not match.
4247 * window.c (size_window): Avoid needless test at loop start.
4249 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4251 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4253 2011-05-12 Drew Adams <drew.adams@oracle.com>
4255 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4257 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4259 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4260 `width' to `bar_area_x' and `bar_area_width', respectively.
4261 (x_scroll_run): Take account of fringe background extension.
4263 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4264 Rename local vars `left' and `width' to `bar_area_x' and
4265 `bar_area_width', respectively.
4266 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4267 background extension.
4269 2011-05-10 Jim Meyering <meyering@redhat.com>
4271 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4273 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4275 * image.c (Finit_image_library): Return t for built-in image types,
4276 like pbm and xbm. (Bug#8640)
4278 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4280 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4282 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4284 * w32console.c (Fset_screen_color): Doc fix.
4285 (Fget_screen_color): New function.
4286 (syms_of_ntterm): Defsubr it.
4288 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4289 unlink the temporary file if Fcall_process didn't create it in the
4291 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4292 child process will be redirected to a file specified with `:file'.
4293 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4294 cue to call_process_cleanup not to close that handle.
4296 2011-05-07 Ben Key <bkey76@gmail.com>
4298 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4299 one of two shell specific rules, either bootstrap-temacs-CMD or
4300 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4301 to the previous implementation of the bootstrap-temacs rule.
4302 The bootstrap-temacs-CMD rule is similar to the previous
4303 implementation of the bootstrap-temacs rule except that it
4304 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4307 These changes, along with some changes to nt/configure.bat,
4308 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4309 earlier fix to add support for --cflags and --ldflags options
4310 that include quotes so that it works whether make uses cmd or
4313 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4315 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4316 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4318 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4319 a string. Handle both cases.
4320 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4321 (Fdbus_register_method): Use Qinvalid_function.
4323 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4325 * makefile.w32-in: Update dependencies.
4326 (LISP_H): Add inttypes.h and stdin.h.
4327 (PROCESS_H): Add unistd.h.
4329 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4331 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4332 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4334 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4336 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4338 * term.c (vfatal): Remove stray call to va_end.
4339 It's not needed and the C Standard doesn't allow it here anyway.
4341 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4342 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4344 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4347 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4349 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4351 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4353 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4355 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4357 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4358 * charset.c (Fdefine_charset_internal): Don't initialize
4359 charset.code_space[15]. The value was garbage, on hosts with
4360 32-bit int (Bug#8600).
4362 * lread.c (read_integer): Be more consistent with string-to-number.
4363 Use string_to_number to do the actual conversion; this avoids
4364 rounding errors and fixes some other screwups. Without this fix,
4365 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4366 (digit_to_number): Move earlier, for benefit of read_integer.
4367 Return -1 if the digit is out of range for the base, -2 if it is
4368 not a digit in any supported base. (Bug#8602)
4370 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4372 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4373 to match comment at start of function. This also removes a
4374 GCC warning about overflow in a 32+64-bit port.
4376 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4378 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4379 Reported by Stefan Monnier in
4380 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4381 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4382 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4384 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4385 (EMACS_UINTPTR): Likewise, with uintptr_t.
4387 * lisp.h: Prefer 64-bit EMACS_INT if available.
4388 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4389 on 32-bit hosts that have 64-bit int, so that they can access
4391 However, temporarily disable this change unless the temporary
4392 symbol WIDE_EMACS_INT is defined.
4394 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4396 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4397 This removes an assumption that EMACS_INT and long are the same
4398 width as pointers. The assumption is true for Emacs porting targets
4399 now, but we want to make other targets possible.
4400 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4401 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4402 In the rest of the code, change types of integers that hold casted
4403 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4404 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4405 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4406 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4407 No need to cast type when ORing.
4408 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4409 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4410 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4411 assume EMACS_INT is the same width as char *.
4412 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4413 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4414 Remove no-longer-needed casts.
4415 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4416 (xg_tool_bar_help_callback, xg_make_tool_item):
4417 Use EMACS_INTPTR to hold an integer
4418 that will be cast to void *; this can avoid a GCC warning
4419 if EMACS_INT is not the same width as void *.
4420 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4421 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4422 (current_message_1, set_message_1):
4423 Use a local to convert to proper width without a cast.
4424 * xmenu.c (dialog_selection_callback): Likewise.
4426 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4427 Also, don't assume VALBITS / RAND_BITS is less than 5,
4428 and don't rely on undefined behavior when shifting a 1 left into
4430 * lisp.h (get_random): Change signature to match.
4432 * lread.c (hash_string): Use size_t, not int, for hash computation.
4433 Normally we prefer signed values; but hashing is special, because
4434 it's better to use unsigned division on hash table sizes so that
4435 the remainder is nonnegative. Also, size_t is the natural width
4436 for hashing into memory. The previous code used 'int', which doesn't
4437 retain enough info to hash well into very large tables.
4438 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4440 * dbusbind.c: Don't possibly lose pointer info when converting.
4441 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4442 Use XPNTR rather than XHASH, so that the high-order bits of
4443 the pointer aren't lost when converting through void *.
4445 * eval.c (Fautoload): Don't double-shift a pointer.
4447 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4449 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4451 * gnutls.c (DEF_GNUTLS_FN):
4452 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4454 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4456 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4459 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4461 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4462 New version that can reserve upto 2GB of heap space.
4464 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4466 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4468 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4470 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4471 `gnutls_certificate_set_x509_key_file'.
4473 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4475 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4476 Update dependencies.
4478 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4480 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4481 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4482 Remove unused parameter `fildes'.
4483 * process.c (read_process_output, send_process): Don't pass it.
4485 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4487 Fix previous change: the library cache is defined in w32.c.
4488 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4489 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4491 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4493 Implement dynamic loading of GnuTLS on Windows.
4495 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4496 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4497 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4500 * gnutls.c (Qgnutls_dll): Define.
4501 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4502 (gnutls_*): Declare function pointers.
4503 (init_gnutls_functions): New function to initialize function pointers.
4504 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4505 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4506 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4507 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4508 (emacs_gnutls_write, emacs_gnutls_read)
4509 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4510 (Fgnutls_available_p): New function.
4511 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4512 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4513 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4515 * image.c: Include w32.h.
4516 (Vimage_type_cache): Delete.
4517 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4518 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4519 (w32_delayed_load): Move to w32.c.
4521 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4523 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4524 (w32_delayed_load): Move from image.c. When loading a library, record
4525 its filename in the :loaded-from property of the library id.
4526 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4527 Initialize and staticpro them.
4528 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4530 * process.c: Include lisp.h before w32.h, not after.
4531 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4532 instead of gnutls_record_check_pending.
4534 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4536 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4538 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4539 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4542 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4544 * xterm.c (x_set_frame_alpha): Do not set property on anything
4545 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4547 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4549 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4551 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4553 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4554 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4555 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4556 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4557 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4558 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4559 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4560 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4561 (Qgnutls_bootprop_callbacks_verify): Make static.
4563 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4565 * callproc.c: Indentation fixup.
4567 * sysdep.c (wait_for_termination_1): Make static.
4568 (wait_for_termination, interruptible_wait_for_termination):
4569 Move after wait_for_termination_1.
4571 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4573 * sysdep.c (interruptible_wait_for_termination): New function
4574 which is like wait_for_termination, but allows keyboard
4577 * callproc.c (Fcall_process): Add (:file "file") as an option for
4579 (Fcall_process_region): Ditto.
4581 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4583 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4584 rather than `XVECTOR (FOO)->size'.
4586 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4587 inttypes.h, as a gnulib replacement is used if it not available in
4590 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4592 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4593 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4594 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4596 * coding.c (coding_alloc_by_realloc): Error out if destination
4597 will grow beyond MOST_POSITIVE_FIXNUM.
4598 (decode_coding_emacs_mule): Abort if there isn't enough place in
4599 charbuf for the composition carryover bytes. Reserve an extra
4600 space for up to 2 characters produced in a loop.
4601 (decode_coding_iso_2022): Abort if there isn't enough place in
4602 charbuf for the composition carryover bytes.
4604 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4606 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4607 aborting when %lld or %lll format is passed.
4608 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4609 %llo or %llx format is passed. (Bug#8545)
4611 * window.c (window_scroll_line_based): Use a marker instead of
4612 simple variables to record original value of point. (Bug#7952)
4614 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4615 produced by %s or %c overflows available buffer space. (Bug#8545)
4617 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4619 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4620 (SIZE_MAX): Move defn after all includes, as they might #define it.
4622 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4624 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4626 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4628 * keyboard.c (Qdelayed_warnings_hook): Define.
4629 (command_loop_1): Run `delayed-warnings-hook'
4630 if Vdelayed_warnings_list is non-nil.
4631 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4632 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4634 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4636 * doprnt.c (doprnt): Don't return value smaller than the buffer
4637 size if the message was truncated. (Bug#8545).
4639 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4641 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4642 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4644 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4646 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4648 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4650 * makefile.w32-in: Update dependencies.
4652 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4654 Improve `doprnt' and its usage. (Bug#8545)
4655 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4656 `format_end'. Remove support for %l as a conversion specifier.
4657 Don't use xrealloc. Improve diagnostics when the %l size modifier
4658 is used. Update the commentary.
4660 * eval.c (verror): Simplify calculation of size_t.
4662 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4665 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4667 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4670 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4672 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4673 This makes this file independent of the recent pseudovector change.
4675 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4677 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4679 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4680 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4681 Remove unused local.
4682 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4684 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4685 GCC 4.6.0 optimizes based on type-based alias analysis.
4686 For example, if b is of type struct buffer * and v of type struct
4687 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4688 != &v->size, and therefore "v->size = 1; b->size = 2; return
4689 v->size;" must therefore return 1. This assumption is incorrect
4690 for Emacs, since it type-puns struct Lisp_Vector * with many other
4691 types. To fix this problem, this patch adds a new type struct
4692 vectorlike_header that documents the constraints on layout of vectors
4693 and pseudovectors, and helps optimizing compilers not get fooled
4694 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4695 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4696 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4698 (XSETPVECTYPE): Rewrite in terms of new macro.
4699 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4700 This is a bit clearer, and further avoids the possibility of
4701 undesirable aliasing.
4702 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4703 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4704 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4705 since Lisp_Subr is a special case (no "next" field).
4706 (ASIZE): Now uses header.size rather than size.
4707 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4708 to avoid the hassle of writing XVECTOR (foo)->header.size.
4709 (struct vectorlike_header): New type.
4710 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4711 object, to help avoid aliasing.
4712 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4713 (SUBRP): Likewise, since Lisp_Subr is a special case.
4714 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4715 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4716 (struct Lisp_Hash_Table): Combine first two members into a single
4717 struct vectorlike_header member. All uses of "size" and "next" members
4718 changed to be "header.size" and "header.next".
4719 * buffer.h (struct buffer): Likewise.
4720 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4721 * frame.h (struct frame): Likewise.
4722 * process.h (struct Lisp_Process): Likewise.
4723 * termhooks.h (struct terminal): Likewise.
4724 * window.c (struct save_window_data, struct saved_window): Likewise.
4725 * window.h (struct window): Likewise.
4726 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4727 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4728 * buffer.c (init_buffer_once): Likewise.
4729 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4731 * process.c (Fformat_network_address): Use local var for size,
4734 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4736 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4737 * data.c (atof): Remove decl; no longer used or needed.
4738 (digit_to_number): Move to lread.c.
4739 (Fstring_to_number): Use new string_to_number function, to be
4740 consistent with how the Lisp reader treats infinities and NaNs.
4741 Do not assume that floating-point numbers represent EMACS_INT
4742 without losing information; this is not true on most 64-bit hosts.
4743 Avoid double-rounding errors, by insisting on integers when
4744 parsing non-base-10 numbers, as the documentation specifies.
4745 * lisp.h (string_to_number): New decl, replacing ...
4746 (isfloat_string): Remove.
4747 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4748 (read1): Do not accept +. and -. as integers; this
4749 appears to have been a coding error. Similarly, do not accept
4750 strings like +-1e0 as floating point numbers. Do not report
4751 overflow for integer overflows unless the base is not 10 which
4752 means we have no simple and reliable way to continue.
4753 Break out the floating-point parsing into a new
4754 function string_to_number, so that Fstring_to_number parses
4755 floating point numbers consistently with the Lisp reader.
4756 (digit_to_number): Move here from data.c. Make it static inline.
4757 (E_CHAR, EXP_INT): Remove, replacing with ...
4758 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4759 (string_to_number): New function, replacing isfloat_string.
4760 This function checks for valid syntax and produces the resulting
4761 Lisp float number too. Rework it so that string-to-number
4762 no longer mishandles examples like "1.0e+". Use strtoumax,
4763 so that overflow for non-base-10 numbers is reported only when
4764 there's no portable and simple way to convert to floating point.
4766 * textprop.c (set_text_properties_1): Rewrite for clarity,
4767 and to avoid GCC warning about integer overflow.
4769 * intervals.h (struct interval): Use EMACS_INT for members
4770 where EMACS_UINT might cause problems. See
4771 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4772 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4773 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4775 (offset_intervals): Tell GCC not to worry about length overflow
4776 when negating a negative length.
4778 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4779 (overrun_check_free): Likewise.
4781 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4782 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4785 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4786 (gnutls_make_error): Rename local to avoid shadowing.
4787 (gnutls_emacs_global_deinit): ifdef out; not used.
4788 (Fgnutls_boot): Use const for pointer to readonly storage.
4789 Comment out unused local. Fix pointer signedness problems.
4791 * lread.c (openp): Don't stuff size_t into an 'int'.
4792 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4793 about possible signed overflow.
4795 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4796 (GDK_KEY_g): Don't define if already defined.
4797 (xg_prepare_tooltip): Avoid pointer signedness problem.
4798 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4800 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4801 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4803 * xfns.c (Fx_window_property): Simplify a bit,
4804 to make a bit faster and to avoid GCC 4.6.0 warning.
4805 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4807 * fns.c (internal_equal): Don't assume size_t fits in int.
4809 * alloc.c (compact_small_strings): Tighten assertion a little.
4811 Replace pEd with more-general pI, and fix some printf arg casts.
4812 * lisp.h (pI): New macro, generalizing old pEd macro to other
4813 conversion specifiers. For example, use "...%"pI"d..." rather
4814 than "...%"pEd"...".
4815 (pEd): Remove. All uses replaced with similar uses of pI.
4816 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4817 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4818 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4819 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4820 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4821 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4822 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4824 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4825 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4826 * print.c (safe_debug_print, print_object): Likewise.
4827 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4829 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4830 avoiding the 0 flag, which is not portable.
4831 * process.c (Fmake_network_process): Use pI to avoid cast.
4832 * region-cache.c (pp_cache): Likewise.
4833 * xdisp.c (decode_mode_spec): Likewise.
4834 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4835 behavior on 64-bit hosts with printf arg.
4836 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4837 (x_stop_queuing_selection_requests): Likewise.
4838 (x_get_window_property): Don't truncate byte count to an 'int'
4841 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4842 here, since it parses constructs like leading '-' and spaces,
4843 which are not wanted; and it overflows with large numbers.
4844 Instead, simply match F[0-9]+, which is what is wanted anyway.
4846 * alloc.c: Remove unportable assumptions about struct layout.
4847 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4848 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4849 (allocate_vectorlike, make_pure_vector): Use the new macros,
4850 plus offsetof, to remove unportable assumptions about struct layout.
4851 These assumptions hold on all porting targets that I know of, but
4852 they are not guaranteed, they're easy to remove, and removing them
4853 makes further changes easier.
4855 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4856 This doesn't fix a bug but makes the code clearer.
4857 (string_overrun_cookie): Now const. Use initializers that
4858 don't formally overflow signed char, to avoid warnings.
4859 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4860 can cause Emacs to crash when string overrun checking is enabled.
4861 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4862 multiple of sizeof (EMACS_INT); it need not be, if
4863 alignof(EMACS_INT) < sizeof (EMACS_INT).
4864 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4866 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4868 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4870 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4872 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4873 supposed to be handshaking. (Bug#8556)
4874 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4876 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4878 * lisp.h (Qdebug): List symbol.
4879 * eval.c (Qdebug): Restore global linkage.
4880 * keyboard.c (debug-on-event): New variable.
4881 (handle_user_signal): Break into debugger when debug-on-event
4882 matches the current signal symbol.
4884 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4886 * alloc.c (check_sblock, check_string_bytes)
4887 (check_string_free_list): Convert to standard C.
4889 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4891 * w32.c (emacs_gnutls_push): Fix typo.
4893 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4895 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4896 "cast to pointer from integer of different size".
4898 Improve doprnt and its use in verror. (Bug#8545)
4899 * doprnt.c (doprnt): Document the set of format control sequences
4900 supported by the function. Use SAFE_ALLOCA instead of always
4903 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4904 is one byte too soon. Don't use xrealloc; instead xfree and
4907 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4909 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4912 * gnutls.c: Renamed global_initialized to
4913 gnutls_global_initialized. Added internals for the
4914 :verify-hostname-error, :verify-error, and :verify-flags
4915 parameters of `gnutls-boot' and documented those parameters in the
4916 docstring. Start callback support.
4917 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4918 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4919 on error. Return error code.
4920 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4921 (emacs_gnutls_read): Likewise.
4922 (Fgnutls_boot): Return handshake error code.
4923 (emacs_gnutls_handle_error): New function.
4924 (wsaerror_to_errno): Likewise.
4926 * w32.h (emacs_gnutls_pull): Add prototype.
4927 (emacs_gnutls_push): Likewise.
4929 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4930 (emacs_gnutls_push): Likewise.
4932 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4934 * process.c (wait_reading_process_output): Check if GnuTLS
4935 buffered some data internally if no FDs are set for TLS
4938 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4939 (LIBS): Link to USER_LIBS.
4940 ($(BLD)/gnutls.$(0)): New target.
4942 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4944 * xdisp.c (handle_single_display_spec): Rename the
4945 display_replaced_before_p argument into display_replaced_p, to
4946 make it consistent with the commentary. Fix typos in the
4949 * textprop.c (syms_of_textprop): Remove dead code.
4950 (copy_text_properties): Delete obsolete commentary about an
4951 interface that was deleted long ago. Fix typos in the description
4954 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4955 to changes in oldXMenu/XMenu.h from 2011-04-16.
4956 <menu_help_message, prev_menu_help_message>: Constify.
4957 (IT_menu_make_room): menu->help_text is now `const char **';
4960 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4961 to changes in oldXMenu/XMenu.h from 2011-04-16.
4962 (struct XMenu): Declare `help_text' `const char **'.
4964 * xfaces.c <Qunspecified>: Make extern again.
4966 * syntax.c: Include sys/types.h before including regex.h, as
4969 * doc.c (get_doc_string): Improve the format passed to `error'.
4971 * doprnt.c (doprnt): Improve commentary.
4973 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4975 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4978 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4979 changes in globals.h immediately force recompilation.
4980 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4981 $(CURDIR)/s/ms-w32.h.
4982 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4984 * character.c (Fchar_direction): Function deleted.
4985 (syms_of_character): Don't defsubr it.
4986 <char-direction-table>: Deleted.
4988 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4990 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4991 * doprnt.c: Include limits.h.
4992 (SIZE_MAX): New macro.
4993 (doprnt): Return a size_t value. 2nd arg is now size_t.
4994 Many local variables are now size_t instead of int or unsigned.
4995 Improve overflow protection. Support `l' modifier for integer
4996 conversions. Support %l conversion. Don't assume an EMACS_INT
4997 argument for integer conversions and for %c.
4999 * lisp.h (doprnt): Restore prototype.
5001 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5004 * Makefile.in (base_obj): Add back doprnt.o.
5006 * deps.mk (doprnt.o): Add back prerequisites.
5007 (callint.o): Depend on character.h.
5009 * eval.c (internal_lisp_condition_case): Include the handler
5010 representation in the error message.
5011 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5012 when breaking from the loop.
5014 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5016 * callint.c (Fcall_interactively): When displaying error message
5017 about invalid control letter, pass the character's codepoint, not
5018 a pointer to its multibyte form. Improve display of the character
5019 in octal and display also its hex code.
5021 * character.c (char_string): Use %x to display the (unsigned)
5022 codepoint of an invalid character, to avoid displaying a bogus
5025 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5026 `error', not SYMBOL_NAME itself.
5028 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5029 character arguments to `error'.
5031 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5032 to `error' in error message about FINAL_CHAR argument. Make sure
5033 FINAL_CHAR is a character, and use %c when it is passed as
5034 argument to `error'.
5036 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5038 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5040 * w32.c: Include <time.h>.
5041 (sys_localtime): New function.
5043 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5045 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5047 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5049 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5051 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5054 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5056 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5057 gl_state.e_property when gl_state.object is Qt.
5059 * insdel.c (make_gap_larger): Remove limitation of buffer size
5062 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5064 * xdisp.c (lookup_glyphless_char_display)
5065 (produce_glyphless_glyph): Handle cons cell entry in
5066 glyphless-char-display.
5067 (Vglyphless_char_display): Document it.
5069 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5070 glyphless-char-display.
5072 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5074 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5076 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5078 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5079 definition for no-X builds.
5081 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5083 Static checks with GCC 4.6.0 and non-default toolkits.
5085 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5087 * process.c (keyboard_bit_set): Define only if SIGIO.
5088 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5089 (send_process): Repair possible setjmp clobbering.
5091 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5093 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5095 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5097 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5098 Define only if needed.
5100 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5101 by pacifying GCC about it. Maybe it's time to retire it?
5102 * xfaces.c (USG, __TIMEVAL__): Likewise.
5104 * dispextern.h (struct redisplay_interface): Rename param
5106 * termhooks.h (struct terminal): Likewise.
5107 * xterm.c (xembed_send_message): Likewise.
5109 * insdel.c (make_gap_smaller): Define only if
5110 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5112 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5115 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5116 so that we aren't warned about unused symbols.
5118 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5120 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5122 * xfns.c (x_real_positions): Mark locals as initialized.
5124 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5126 * xterm.c: Fix problems found by static analysis with other toolkits.
5127 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5128 (x_dispatch_event): Declare static if USE_GTK, and
5129 define if USE_GTK || USE_X_TOOLKIT.
5130 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5131 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5132 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5133 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5135 * xmenu.c (menu_help_callback): Pointer type fixes.
5136 Use const pointers when pointing at readonly data. Avoid pointer
5138 (FALSE): Remove unused macro.
5139 (update_frame_menubar): Remove unused decl.
5141 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5143 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5144 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5145 (single_menu_item): Rename local to avoid shadowing.
5147 * keyboard.c (make_lispy_event): Remove unused local var.
5149 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5150 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5152 * bitmaps: Change bitmaps from unsigned char back to the X11
5153 compatible char. Avoid the old compiler warnings about
5154 out-of-range initializers by using, for example, '\xab' rather
5157 * xgselect.c (xgselect_initialize): Check vs interface
5158 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5160 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5162 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5163 to read-only memory.
5165 * fns.c (vector): Remove; this old hack is no longer needed.
5167 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5169 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5171 * xrdb.c (x_load_resources): Omit unused local.
5173 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5174 (x_window): Rename locals to avoid shadowing.
5175 (USG): Use the kludged USG macro, to pacify gcc.
5177 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5178 (x_term_init): Remove local to avoid shadowing.
5180 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5182 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5183 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5185 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5187 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5189 Fix regex.c, syntax.c and friends for buffers > 2GB.
5190 * syntax.h (struct gl_state_s): Declare character position members
5193 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5195 * textprop.c (verify_interval_modification, interval_of):
5196 Declare arguments EMACS_INT.
5198 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5201 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5203 * indent.c (Fvertical_motion): Local variable it_start is now
5206 * regex.c (re_match, re_match_2, re_match_2_internal)
5207 (bcmp_translate, regcomp, regexec, print_double_string)
5208 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5209 (re_compile_pattern, re_exec): Declare arguments and local
5210 variables `size_t' and `ssize_t' and return values `regoff_t', as
5212 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5213 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5214 <compile_stack_type>: `size' and `avail' are now `size_t'.
5216 * regex.h <regoff_t>: Use ssize_t, not int.
5217 (re_search, re_search_2, re_match, re_match_2): Arguments that
5218 specify buffer/string position and length are now ssize_t and
5219 size_t. Return type is regoff_t.
5221 2011-04-16 Ben Key <bkey76@gmail.com>
5223 * nsfont.m: Fixed bugs in ns_get_family and
5224 ns_descriptor_to_entity that were caused by using free to
5225 deallocate memory blocks that were allocated by xmalloc (via
5226 xstrdup). This caused Emacs to crash when compiled with
5227 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5228 --enable-checking=xmallocoverrun). xfree is now used to
5229 deallocate these memory blocks.
5231 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5233 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5235 emacs_write: Accept and return EMACS_INT for sizes.
5236 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5238 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5239 Accept and return EMACS_INT.
5240 (emacs_gnutls_write): Return the number of bytes written on
5242 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5243 (emacs_read, emacs_write): Remove check for negative size, as the
5244 Emacs source code has been audited now.
5245 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5246 (emacs_read, emacs_write): Use it.
5247 * process.c (send_process): Adjust to the new signatures of
5248 emacs_write and emacs_gnutls_write. Do not attempt to store
5249 a byte offset into an 'int'; it might overflow.
5250 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5252 * sound.c: Don't assume sizes fit in 'int'.
5253 (struct sound_device.period_size, alsa_period_size):
5254 Return EMACS_INT, not int.
5255 (struct sound_device.write, vox_write, alsa_write):
5256 Accept EMACS_INT, not int.
5257 (wav_play, au_play): Use EMACS_INT to store sizes and to
5258 record read return values.
5260 2011-04-15 Ben Key <bkey76@gmail.com>
5262 * keyboard.c (Qundefined): Don't declare static since it is used
5264 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5265 static since they are used in nsfont.m.
5267 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5269 * process.c (Qprocessp): Don't declare static.
5270 * lisp.h (Qprocessp): Declare again.
5272 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5274 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5276 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5278 Improve C-level modularity by making more things 'static'.
5280 Don't publish debugger-only interfaces to other modules.
5281 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5282 (verify_bytepos, count_markers): Move decls to the only modules
5284 * region-cache.h (pp_cache): Likewise.
5285 * window.h (check_all_windows): Likewise.
5286 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5288 * sysdep.c (croak): Now static, if
5289 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5290 * syssignal.h (croak): Declare only if not static.
5292 * alloc.c (refill_memory_reserve): Now static if
5293 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5294 * lisp.h (refill_memory_reserve): Declare only if not static.
5296 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5297 Define only if USE_LUCID.
5299 * xrdb.c (x_customization_string, x_rm_string): Now static.
5301 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5302 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5304 * xdisp.c (draw_row_with_mouse_face): Now static.
5305 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5307 * window.h (check_all_windows): Mark externally visible.
5309 * window.c (window_deletion_count): Now static.
5311 * undo.c: Make symbols static if they're not exported.
5312 (last_undo_buffer, last_boundary_position, pending_boundary):
5315 * textprop.c (interval_insert_behind_hooks): Now static.
5316 (interval_insert_in_front_hooks): Likewise.
5318 * term.c: Make symbols static if they're not exported.
5319 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5320 (max_frame_lines, tty_set_terminal_modes):
5321 (tty_reset_terminal_modes, tty_turn_off_highlight):
5322 (get_tty_terminal): Now static.
5323 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5324 * termhooks.h (term_mouse_moveto): Do not declare if
5326 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5327 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5329 * sysdep.c: Make symbols static if they're not exported.
5330 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5332 (sigprocmask_set, full_mask): Remove; unused.
5333 (wait_debugging): Mark as visible.
5334 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5335 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5337 * syntax.c (syntax_temp): Define only if !__GNUC__.
5339 * sound.c (current_sound_device, current_sound): Now static.
5341 * search.c (searchbufs, searchbuf_head): Now static.
5343 * scroll.c (scroll_cost): Remove; unused.
5344 * dispextern.h (scroll_cost): Remove decl.
5346 * region-cache.h (pp_cache): Mark as externally visible.
5348 * process.c: Make symbols static if they're not exported.
5349 (process_tick, update_tick, create_process, chan_process):
5350 (Vprocess_alist, proc_buffered_char, datagram_access):
5351 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5352 (deactivate_process): Mark defn as static, as well as decl.
5353 * lisp.h (create_process): Remove decl.
5354 * process.h (chan_process, Vprocess_alist): Remove decls.
5356 * print.c: Make symbols static if they're not exported.
5357 (print_depth, new_backquote_output, being_printed, print_buffer):
5358 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5359 (print_interval, print_number_index, initial_stderr_stream):
5361 * lisp.h (Fprinc): Remove decl.
5362 (debug_output_compilation_hack): Mark as externally visible.
5364 * sysdep.c (croak): Move decl from here to syssignal.h.
5365 * syssignal.h (croak): Put it here, so the API can be checked when
5366 'croak' is called from dissociate_if_controlling_tty.
5368 * minibuf.c: Make symbols static if they're not exported.
5369 (minibuf_save_list, choose_minibuf_frame): Now static.
5370 * lisp.h (choose_minibuf_frame): Remove decl.
5372 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5374 * lread.c: Make symbols static if they're not exported.
5375 (read_objects, initial_obarray, oblookup_last_bucket_number):
5377 (make_symbol): Remove; unused.
5378 * lisp.h (initial_obarray, make_symbol): Remove decls.
5380 * keyboard.c: Make symbols static if they're not exported.
5381 (single_kboard, recent_keys_index, total_keys, recent_keys):
5382 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5383 (this_single_command_key_start, echoing, last_auto_save):
5384 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5385 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5386 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5387 (Vlispy_mouse_stem, double_click_count):
5389 (force_auto_save_soon): Define only if SIGDANGER.
5390 (ignore_mouse_drag_p): Now static if
5391 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5392 (print_help): Remove; unused.
5393 (stop_character, last_timer_event): Mark as externally visible.
5394 * keyboard.h (ignore_mouse_drag_p): Declare only if
5395 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5396 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5397 * lisp.h (echoing): Remove decl.
5398 (force_auto_save_soon): Declare only if SIGDANGER.
5399 * xdisp.c (redisplay_window): Simplify code, to make it more
5400 obvious that ignore_mouse_drag_p is not accessed if !defined
5401 USE_GTK && !defined HAVE_NS.
5403 * intervals.c: Make symbols static if they're not exported.
5404 (merge_properties_sticky, merge_interval_right, delete_interval):
5406 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5408 * insdel.c: Make symbols static if they're not exported.
5409 However, leave prepare_to_modify_buffer alone. It's never
5410 called from outside this function, but that appears to be a bug.
5411 (combine_after_change_list, combine_after_change_buffer):
5412 (adjust_after_replace, signal_before_change): Now static.
5413 (adjust_after_replace_noundo): Remove; unused.
5414 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5415 (signal_before_change): Remove decls.
5417 * indent.c (val_compute_motion, val_vmotion): Now static.
5419 * image.c: Make symbols static if they're not exported.
5420 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5422 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5423 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5425 * fringe.c (standard_bitmaps): Now static.
5426 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5428 * frame.c: Make symbols static if they're not exported.
5429 (x_report_frame_params, make_terminal_frame): Now static.
5430 (get_frame_param): Now static, unless HAVE_NS.
5431 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5432 (x_get_resource_string): Remove; not used.
5433 * frame.h (make_terminal_frame, x_report_frame_params):
5434 (x_get_resource_string); Remove decls.
5435 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5436 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5438 * font.c, fontset.c: Make symbols static if they're not exported.
5439 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5440 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5441 * font.c (font_close_object): Now static.
5442 * font.h (font_close_object): Remove.
5443 * fontset.c (FONTSET_OBJLIST): Remove.
5444 (free_realized_fontset) #if-0 the body, which does nothing.
5445 (face_suitable_for_char_p): #if-0, as it's never called.
5446 * fontset.h (face_suitable_for_char_p): Remove decl.
5447 * xfaces.c (face_at_string_position):
5448 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5449 since 0 is always ASCII.
5451 * fns.c (weak_hash_tables): Now static.
5453 * fileio.c: Make symbols static if they're not exported.
5454 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5455 (Vwrite_region_annotation_buffers): Now static.
5457 * eval.c: Make symbols static if they're not exported.
5458 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5459 * lisp.h (backtrace_list): Remove decl.
5461 * emacs.c: Make symbols static if they're not exported.
5462 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5463 (fatal_error_code, fatal_error_signal_hook, standard_args):
5465 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5466 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5467 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5468 * lisp.h (fatal_error_signal_hook): Remove decl.
5469 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5471 * editfns.c: Move a (normally-unused) function to its only use.
5472 * editfns.c, lisp.h (get_operating_system_release): Remove.
5473 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5474 worth the hassle of breaking this out.
5476 * xterm.c: Make symbols static if they're not exported.
5477 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5478 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5479 (x_destroy_window, x_delete_display):
5481 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5482 (x_mouse_leave): Remove; unused.
5483 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5484 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5485 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5487 (x_mouse_leave): Declare only if WINDOWSNT.
5488 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5489 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5492 * ftxfont.c: Make symbols static if they're not exported.
5493 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5495 * font.h (ftxfont_driver): Likewise.
5497 * xfns.c: Make symbols static if they're not exported.
5498 (x_last_font_name, x_display_info_for_name):
5499 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5500 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5501 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5502 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5503 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5504 (last_show_tip_args): Now static.
5505 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5506 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5507 (x_screen_planes): Remove; unused.
5508 * dispextern.h (x_screen_planes): Remove decl.
5510 * dispnew.c: Make symbols static if they're not exported.
5511 * dispextern.h (redraw_garbaged_frames, scrolling):
5512 (increment_row_positions): Remove.
5513 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5514 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5516 (redraw_garbaged_frames): Remove; unused.
5518 * xfaces.c: Make symbols static if they're not exported.
5519 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5521 * xterm.h (defined_color): Remove decls.
5522 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5523 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5524 (menu_face_changed_default, defined_color, free_realized_face):
5525 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5526 (ascii_face_of_lisp_face): Remove; unused.
5528 * xdisp.c: Make symbols static if they're not exported.
5529 * dispextern.h (scratch_glyph_row, window_box_edges):
5530 (glyph_to_pixel_coords, set_cursor_from_row):
5531 (get_next_display_element, set_iterator_to_next):
5532 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5533 (show_mouse_face): Remove decls
5534 * frame.h (message_buf_print): Likewise.
5535 * lisp.h (pop_message, set_message, check_point_in_composition):
5537 * xterm.h (set_vertical_scroll_bar): Likewise.
5538 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5539 (message_buf_print, scratch_glyph_row, displayed_buffer):
5540 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5541 (get_next_display_element, show_mouse_face, window_box_edges):
5542 (frame_to_window_pixel_xy, check_point_in_composition):
5543 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5544 (glyph_to_pixel_coords): Remove; unused.
5546 * dired.c (file_name_completion): Now static.
5548 * dbusbind.c (xd_in_read_queued_messages): Now static.
5550 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5551 * data.c (circular_list_error): Remove.
5553 * commands.h (last_point_position, last_point_position_buffer):
5554 (last_point_position_window): Remove decls.
5555 * keyboard.c: Make these variables static.
5557 * coding.h (coding, code_convert_region, encode_coding_gap):
5559 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5560 (iso_code_class, detect_coding, code_convert_region): Now static.
5561 (encode_coding_gap): Remove; unused.
5563 * chartab.c (chartab_chars, chartab_bits): Now static.
5565 * charset.h (charset_iso_8859_1): Remove decl.
5566 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5569 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5570 * ccl.c (Vccl_program_table): Now static.
5571 (check_ccl_update): Remove; unused.
5573 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5574 * category.h: ... from here.
5575 * category.c (check_category_table, set_category_set): Now static.
5577 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5578 * lisp.h: Remove these decls.
5580 * buffer.c (buffer_count): Remove unused var.
5582 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5583 so that it's not optimized away.
5584 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5585 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5586 exported only to the debugger.
5588 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5589 * atimer.h (run_all_atimers): Remove; not exported.
5591 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5592 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5593 was inaccessible from Lisp.
5594 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5595 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5597 alloc.c: Import and export fewer symbols, and remove unused items.
5598 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5600 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5601 it's not optimized away by whole-program optimization.
5602 (message_enable_multibyte, free_misc): Remove.
5603 (catchlist, handlerlist, mark_backtrace):
5604 Declare only if BYTE_MARK_STACK.
5605 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5606 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5607 (message_enable_multibyte): Remove decl.
5608 (free_misc, interval_free_list, float_block, float_block_index):
5609 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5610 (cons_free_list, last_marked_index):
5612 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5613 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5614 (mark_backtrace): Define only if BYTE_MARK_STACK.
5615 * xdisp.c (message_enable_multibyte): Now static.
5617 Declare Lisp_Object Q* variables to be 'static' if not exported.
5618 This makes it easier for human readers (and static analyzers)
5619 to see whether these variables are used from other modules.
5620 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5621 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5622 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5623 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5624 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5625 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5626 * xmenu.c, xselect.c:
5627 Declare Q* vars static if they are not used in other modules.
5628 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5629 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5630 Remove decls of unexported vars.
5631 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5633 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5635 Make Emacs functions such as Fatom 'static' by default.
5636 This makes it easier for human readers (and static analyzers)
5637 to see whether these functions can be called from other modules.
5638 DEFUN now defines a static function. To make the function external
5639 so that it can be used in other C modules, use the new macro DEFUE.
5640 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5641 (Finit_image_library):
5642 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5643 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5644 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5645 Remove decls, since these functions are now static.
5646 (Funintern, Fget_internal_run_time): New decls, since these functions
5647 were already external.
5649 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5650 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5651 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5652 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5653 * keyboard.c, keymap.c, lread.c:
5654 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5655 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5656 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5657 Mark functions with DEFUE instead of DEFUN,
5658 if they are used in other modules.
5659 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5660 decls for now-static functions.
5661 * buffer.h (Fdelete_overlay): Remove decl.
5662 * callproc.c (Fgetenv_internal): Mark as internal.
5663 * composite.c (Fremove_list_of_text_properties): Remove decl.
5664 (Fcomposition_get_gstring): New forward static decl.
5665 * composite.h (Fcomposite_get_gstring): Remove decl.
5666 * dired.c (Ffile_attributes): New forward static decl.
5667 * doc.c (Fdocumntation_property): New forward static decl.
5668 * eval.c (Ffetch_bytecode): New forward static decl.
5669 (Funintern): Remove extern decl; now in .h file where it belongs.
5670 * fileio.c (Fmake_symbolic_link): New forward static decl.
5671 * image.c (Finit_image_library): New forward static decl.
5672 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5673 * intervals.h (Fprevious_property_change):
5674 (Fremove_list_of_text_properties): Remove decls.
5675 * keyboard.c (Fthis_command_keys): Remove decl.
5676 (Fcommand_execute): New forward static decl.
5677 * keymap.c (Flookup_key): New forward static decl.
5678 (Fcopy_keymap): Now static.
5679 * keymap.h (Flookup_key): Remove decl.
5680 * process.c (Fget_process): New forward static decl.
5681 (Fprocess_datagram_address): Mark as internal.
5682 * syntax.c (Fsyntax_table_p): New forward static decl.
5683 (skip_chars): Remove duplicate decl.
5684 * textprop.c (Fprevious_property_change): New forward static decl.
5685 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5687 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5688 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5690 * editfns.c (Fformat): Remove unreachable code.
5692 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5694 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5697 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5699 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5700 when at ZV. (Bug#8487)
5702 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5704 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5706 * keyboard.c (parse_tool_bar_item): Likewise.
5707 * sound.c (sound_cleanup, alsa_close): Likewise.
5708 * termcap.c (tgetent): Likewise.
5709 * xfns.c (x_default_font_parameter): Likewise.
5710 * xsettings.c (read_and_apply_settings): Likewise.
5712 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5713 (overrun_check_free): Protoize.
5715 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5717 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5718 since callers should never pass a negative size.
5719 Change the signature to match that of plain 'read' and 'write'; see
5720 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5721 * lisp.h: Update prototypes of emacs_write and emacs_read.
5723 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5725 * xdisp.c (redisplay_window): Don't try to determine the character
5726 position of the scroll margin if the window start point w->startp
5727 is outside the buffer's accessible region. (Bug#8468)
5729 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5731 Fix write-region and its subroutines for buffers > 2GB.
5732 * fileio.c (a_write, e_write): Modify declaration of arguments and
5733 local variables to support buffers larger than 2GB.
5734 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5736 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5737 argument, local variables, and return value.
5739 * lisp.h: Update prototypes of emacs_write and emacs_read.
5741 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5743 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5745 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5747 Fix more problems found by GCC 4.6.0's static checks.
5749 * xdisp.c (vmessage): Use a better test for character truncation.
5751 * charset.c (load_charset_map): <, not <=, for optimization,
5752 and to avoid potential problems with integer overflow.
5753 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5754 * casetab.c (set_identity, shuffle): Likewise.
5755 * editfns.c (Fformat): Likewise.
5756 * syntax.c (skip_chars): Likewise.
5758 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5759 This also lets GCC 4.6.0 generate slightly better loop code.
5761 * callint.c (Fcall_interactively): <, not <=, for optimization.
5762 (Fcall_interactively): Count the number of arguments produced,
5763 not the number of arguments given. This is simpler and lets GCC
5764 4.6.0 generate slightly better code.
5766 * ftfont.c: Distingish more carefully between FcChar8 and char.
5767 The previous code passed unsigned char * to a functions like
5768 strlen and xstrcasecmp that expect char *, which does not
5769 conform to the C standard.
5770 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5771 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5772 char * when the C standard requires it.
5774 * keyboard.c (read_char): Remove unused var.
5776 * eval.c: Port to Windows vsnprintf (Bug#8435).
5778 (SIZE_MAX): Define if the headers do not.
5779 (verror): Do not give up if vsnprintf returns a negative count.
5780 Instead, grow the buffer. This ports to Windows vsnprintf, which
5781 does not conform to C99. Problem reported by Eli Zaretskii.
5782 Also, simplify the allocation scheme, by avoiding the need for
5783 calling realloc, and removing the ALLOCATED variable.
5785 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5787 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5788 But keep the doprint source code for now, as we might revamp it
5789 and use it again (Bug#8435).
5790 * lisp.h (doprnt): Remove.
5791 * Makefile.in (base_obj): Remove doprnt.o.
5792 * deps.mk (doprnt.o): Remove.
5794 error: Print 32- and 64-bit integers portably (Bug#8435).
5795 Without this change, on typical 64-bit hosts error ("...%d...", N)
5796 was used to print both 32- and 64-bit integers N, which relied on
5798 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5800 * lisp.h (error, verror): Mark as printf-like functions.
5801 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5802 Report overflow in size calculations when allocating printf buffer.
5803 Do not truncate output string at its first null byte.
5804 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5805 Truncate the output at a character boundary, since vsnprintf does not
5807 * charset.c (check_iso_charset_parameter): Convert internal
5808 character to string before calling 'error', since %c now has the
5810 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5811 overflow when computing char to be passed to 'error'. Do not
5812 pass Lisp_Object to 'error'; pass the integer instead.
5813 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5814 formatted with plain %d.
5816 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5818 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5820 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5822 * xterm.c (x_catch_errors): Remove duplicate declaration.
5824 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5826 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5828 2011-04-10 Jim Meyering <meyering@redhat.com>
5830 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5831 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5832 return ssize_t not "int", and use size_t as the buffer length.
5833 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5834 * gnutls.h: Update declarations.
5835 * process.c (read_process_output): Use ssize_t, to match.
5836 (send_process): Likewise.
5838 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5840 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5842 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5844 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5845 Use unsigned char, to match FcChar8 type definition.
5847 * xterm.c (handle_one_xevent):
5848 * xmenu.c (create_and_show_popup_menu):
5849 * xselect.c (x_decline_selection_request)
5850 (x_reply_selection_request): Avoid type-punned deref of X events.
5852 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5854 Fix some uses of `int' instead of EMACS_INT.
5855 * search.c (string_match_1, fast_string_match)
5856 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5857 (scan_buffer, find_next_newline_no_quit)
5858 (find_before_next_newline, search_command, Freplace_match)
5859 (Fmatch_data): Make some `int' variables be EMACS_INT.
5861 * xdisp.c (display_count_lines): 3rd argument and return value now
5862 EMACS_INT. All callers changed.
5863 (pint2hrstr): Last argument is now EMACS_INT.
5865 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5866 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5867 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5868 (decode_coding_utf_16, decode_coding_emacs_mule)
5869 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5870 (decode_coding_ccl, decode_coding_charset)
5871 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5872 (decode_coding_iso_2022, decode_coding_emacs_mule)
5873 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5874 <char_offset, last_offset>: Declare EMACS_INT.
5875 (encode_coding_utf_8, encode_coding_utf_16)
5876 (encode_coding_emacs_mule, encode_invocation_designation)
5877 (encode_designation_at_bol, encode_coding_iso_2022)
5878 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5879 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5881 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5882 (encode_invocation_designation): Last argument P_NCHARS is now
5884 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5885 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5887 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5890 * ccl.c (Fccl_execute_on_string): Declare some variables
5893 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5895 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5897 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5899 * process.c (Fformat_network_address): Doc fix.
5901 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5903 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5905 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5907 * keyboard.c (read_char): Call Lisp function help-form-show,
5908 instead of using internal_with_output_to_temp_buffer.
5909 (Qhelp_form_show): New var.
5910 (syms_of_keyboard): Use DEFSYM macro.
5912 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5914 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5916 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5918 * process.c (Flist_processes): Remove to Lisp.
5919 (list_processes_1): Delete.
5921 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5923 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5925 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5927 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5929 Fix more problems found by GCC 4.6.0's static checks.
5931 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5933 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5935 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5937 * xdisp.c (vmessage): Mark as a printf-like function.
5939 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5941 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5943 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5944 printf-like functions.
5945 (tiff_load): Add casts to remove these marks before passing them
5946 to system-supplied API.
5948 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5950 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5951 This avoids several warnings with gcc -Wstrict-overflow.
5952 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5953 directly, rather than having caller test rule sign. This avoids
5954 some unnecessary tests.
5955 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5956 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5957 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5959 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5960 (xfont_open): Avoid unnecessary tests.
5962 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5964 * composite.h, composite.c (composition_gstring_put_cache):
5965 Use EMACS_INT, not int, for length.
5967 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5968 breaking out part of COMPOSITION_DECODE_RULE.
5969 (COMPOSITION_DECODE_RULE): Use it.
5970 * composite.c (get_composition_id): Remove unused local vars,
5971 by using the new macro.
5973 * textprop.c (set_text_properties_1): Change while to do-while,
5974 since the condition is always true at first.
5976 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5977 (interval_deletion_adjustment): Return unsigned value.
5980 * process.c (list_processes_1, create_pty, read_process_output):
5981 (exec_sentinel): Remove vars that were set but not used.
5982 (create_pty): Remove unnecessary "volatile"s.
5983 (Fnetwork_interface_info): Avoid possibility of int overflow.
5984 (read_process_output): Do adaptive read buffering even if carryover.
5985 (read_process_output): Simplify nbytes computation if buffered.
5987 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5989 * syntax.c (scan_words): Remove var that was set but not used.
5990 (update_syntax_table): Use unsigned instead of int.
5992 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5993 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5994 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5996 * print.c (print_error_message): Avoid int overflow.
5998 * font.c (font_list_entities): Redo for clarity,
5999 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6001 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6002 (font_score): Avoid potential overflow in diff calculation.
6004 * fns.c (substring_both): Remove var that is set but not used.
6005 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6007 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6009 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6010 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6011 can always succeed if overflow has undefined behavior.
6013 * search.c (boyer_moore, wordify): Remove vars set but not used.
6014 (wordify): Omit three unnecessary tests.
6016 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6017 All callers changed. This avoids the need for an unused var.
6019 * casefiddle.c (casify_region): Remove var that is set but not used.
6021 * dired.c (file_name_completion): Remove var that is set but not used.
6023 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6025 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6026 (Finsert_file_contents): Remove unnecessary code checking fd.
6028 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6029 Check for integer overflow on size calculations.
6031 * buffer.c (Fprevious_overlay_change): Remove var that is set
6034 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6035 Remove vars that are set but not used.
6036 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6037 (timer_check_2): Mark vars as initialized.
6039 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6041 * image.c (lookup_image): Remove var that is set but not used.
6042 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6044 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6045 that are set but not used.
6047 * xfns.c (make_invisible_cursor): Don't return garbage
6048 if XCreateBitmapFromData fails (Bug#8410).
6050 * xselect.c (x_get_local_selection, x_handle_property_notify):
6051 Remove vars that are set but not used.
6053 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6054 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6056 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6057 Remove var that is set but not used.
6058 (scroll_bar_windows_size): Now size_t, not int.
6059 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6062 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6063 (map_tty_color) [!defined MSDOS]: Likewise.
6065 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6067 * coding.c: Remove vars that are set but not used.
6068 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6069 All callers changed.
6070 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6071 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6072 (decode_coding_charset): Remove vars that are set but not used.
6074 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6075 that is set but not used.
6077 * print.c (print_object): Remove var that is set but not used.
6079 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6080 The gnulib version avoids calling malloc in the usual case,
6081 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6082 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6083 * filelock.c (current_lock_owner): Likewise.
6084 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6085 * sysdep.c: Include allocator.h, careadlinkat.h.
6086 (emacs_no_realloc_allocator): New static constant.
6087 (emacs_readlink): New function.
6088 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6089 ../lib/careadlinkat.h.
6091 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6093 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6094 first non-nil return value).
6096 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6098 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6099 if not defined (Bug#8403).
6101 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6103 * xdisp.c (display_count_lines): Remove parameter `start',
6104 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6105 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6106 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6107 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6108 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6109 and thereabouts. All callers changed.
6110 (get_per_char_metric): Remove parameter `f', unused since
6111 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6113 2011-04-02 Jim Meyering <meyering@redhat.com>
6115 do not dereference NULL upon failed strdup
6116 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6117 (ns_get_family): Likewise.
6119 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6121 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6123 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6125 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6128 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6130 Add lexical binding.
6132 * window.c (Ftemp_output_buffer_show): New fun.
6133 (Fsave_window_excursion):
6134 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6136 * lread.c (lisp_file_lexically_bound_p): New function.
6137 (Fload): Bind Qlexical_binding.
6138 (readevalloop): Remove `evalfun' arg.
6139 Bind Qinternal_interpreter_environment.
6140 (Feval_buffer): Bind Qlexical_binding.
6141 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6143 (syms_of_lread): Declare `lexical-binding'.
6145 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6147 * keyboard.c (eval_dyn): New fun.
6148 (menu_item_eval_property): Use it.
6150 * image.c (parse_image_spec): Use Ffunctionp.
6152 * fns.c (concat, mapcar1): Accept byte-code-functions.
6154 * eval.c (Fsetq): Handle lexical vars.
6155 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6156 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6157 (FletX, Flet): Obey lexical binding.
6158 (Fcommandp): Handle closures.
6159 (Feval): New `lexical' arg.
6160 (eval_sub): New function extracted from Feval. Use it almost
6161 everywhere where Feval was used. Look up vars in lexical env.
6163 (Ffunctionp): Move from subr.el.
6164 (Ffuncall): Handle closures.
6165 (apply_lambda): Remove `eval_flags'.
6166 (funcall_lambda): Handle closures and new byte-code-functions.
6167 (Fspecial_variable_p): New function.
6168 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6169 but without exporting it to Lisp.
6171 * doc.c (Fdocumentation, store_function_docstring):
6172 * data.c (Finteractive_form): Handle closures.
6174 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6177 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6179 (exec_byte_code): New function extracted from Fbyte_code to handle new
6180 calling convention for byte-code-functions. Add new byte-codes.
6182 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6184 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6186 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6188 * xdisp.c (redisplay_internal): Fix prototype.
6190 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6192 * xdisp.c (SCROLL_LIMIT): New macro.
6193 (try_scrolling): Use it when setting scroll_limit.
6194 Limit scrolling to 100 screen lines.
6195 (redisplay_window): Even when falling back on "recentering",
6196 position point in the window according to scroll-conservatively,
6197 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6199 (try_scrolling): When point is above the window, allow searching
6200 as far as scroll_max, or one screenful, to compute vertical
6201 distance from PT to the scroll margin position. This prevents
6202 try_scrolling from unnecessarily failing when
6203 scroll-conservatively is set to a value slightly larger than the
6204 window height. Clean up the case of PT below the margin at bottom
6205 of window: scroll_max can no longer be INT_MAX. When aggressive
6206 scrolling is in use, don't let point enter the opposite scroll
6207 margin as result of the scroll.
6208 (syms_of_xdisp) <scroll-conservatively>: Document the
6209 threshold of 100 lines for never-recentering scrolling.
6211 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6213 * dispextern.h (move_it_by_lines):
6214 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6215 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6216 (message_log_check_duplicate): Remove parameters `prev_bol' and
6217 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6218 (redisplay_internal): Remove parameter `preserve_echo_area',
6219 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6221 * indent.c (Fvertical_motion):
6222 * window.c (window_scroll_pixel_based, Frecenter):
6223 Don't pass `need_y_p' to `move_it_by_lines'.
6225 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6227 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6228 steal a few bits to be more compact.
6229 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6230 Remove unneeded casts.
6232 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6234 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6236 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6237 binding" message (bug#7967).
6239 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6241 Fix more problems found by GCC 4.6.0's static checks.
6243 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6244 Remove unused local var.
6246 * editfns.c (Fmessage_box): Remove unused local var.
6248 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6249 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6250 Omit unused local vars.
6251 * window.c (shrink_windows): Omit unused local var.
6252 * menu.c (digest_single_submenu): Omit unused local var.
6253 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6254 Omit unused local var.
6256 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6257 Don't assume string length fits in int.
6258 (keyremap_step, read_key_sequence): Use size_t for sizes.
6259 (read_key_sequence): Don't check last_real_key_start redundantly.
6261 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6262 instead of alloca (Bug#8344).
6264 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6265 (Fbacktrace_frame): Don't assume nframes fits in int.
6267 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6269 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6272 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6274 * cm.c (calccost): Turn while-do into do-while, for clarity.
6276 * keyboard.c (syms_of_keyboard): Use the same style as later
6277 in this function when indexing through an array. This also
6278 works around GCC bug 48267.
6280 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6282 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6284 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6285 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6287 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6288 This avoids undefined behavior on integer overflow, and is a bit
6289 more convenient anyway since it is compared to a size_t variable.
6291 Variadic C functions now count arguments with size_t, not int.
6292 This avoids an unnecessary limitation on 64-bit machines, which
6293 caused (substring ...) to crash on large vectors (Bug#8344).
6294 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6295 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6296 All variadic functions and their callers changed accordingly.
6297 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6298 * data.c (arith_driver, float_arith_driver): Likewise.
6299 * editfns.c (general_insert_function): Likewise.
6300 * eval.c (struct backtrace.nargs, interactive_p)
6301 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6302 (funcall_lambda, mark_backtrace): Likewise.
6303 * fns.c (concat): Likewise.
6304 * frame.c (x_set_frame_parameters): Likewise.
6305 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6306 0 if not found, not -1. All callers changed.
6308 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6309 (stack_copy_size): Now size_t, not int.
6310 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6312 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6314 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6315 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6316 All callers changed.
6318 * lisp.h (multibyte_char_to_unibyte):
6319 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6320 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6321 * character.h (CHAR_TO_BYTE8):
6322 * cmds.c (internal_self_insert):
6323 * editfns.c (general_insert_function):
6324 * keymap.c (push_key_description):
6325 * search.c (Freplace_match):
6326 * xdisp.c (message_dolog, set_message_1): All callers changed.
6328 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6330 * keyboard.c (safe_run_hook_funcall): New function.
6331 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6332 don't set the hook to nil, but remove the offending function instead.
6333 (Qcommand_hook_internal): Remove, unused.
6334 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6335 Vcommand_hook_internal.
6337 * eval.c (enum run_hooks_condition): Remove.
6338 (funcall_nil, funcall_not): New functions.
6339 (run_hook_with_args): Call each function through a `funcall' argument.
6340 Remove `cond' argument, now redundant.
6341 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6342 (Frun_hook_with_args_until_failure): Adjust accordingly.
6343 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6345 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6347 * dispextern.h (string_buffer_position): Remove declaration.
6349 * print.c (strout): Remove parameter `multibyte', unused since
6350 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6352 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6353 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6354 All callers changed.
6356 * w32.c (_wsa_errlist): Use braces for struct initializers.
6358 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6359 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6360 All callers changed.
6361 (string_buffer_position): Likewise. Also, make static (it's never
6362 used outside xdisp.c).
6363 (cursor_row_p): Remove parameter `w', unused since
6364 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6365 (decode_mode_spec): Remove parameter `precision', introduced during
6366 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6367 All callers changed.
6369 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6371 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6373 2011-03-27 Anders Lindgren <andlind@gmail.com>
6375 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6376 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6377 (ns_update_auto_hide_menu_bar): New functions.
6378 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6379 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6380 ns_constrain_all_frames.
6381 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6382 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6384 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6386 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6388 2011-03-27 Glenn Morris <rgm@gnu.org>
6390 * syssignal.h: Replace RETSIGTYPE with void.
6391 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6392 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6393 Replace SIGTYPE with void everywhere.
6394 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6395 * s/template.h (SIGTYPE): Remove commented out definition.
6397 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6399 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6400 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6402 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6404 * w32.c (read_unc_volume): Use parameter `henum', instead of
6405 global variable `wget_enum_handle'.
6407 * keymap.c (describe_vector): Remove parameters `indices' and
6408 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6409 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6411 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6413 * keyboard.c (timer_check): Remove parameter `do_it_now',
6414 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6415 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6416 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6418 * keyboard.c (read_char):
6419 * w32menu.c (w32_menu_display_help):
6420 * xmenu.c (show_help_event, menu_help_callback):
6421 Adjust calls to `show_help_echo'.
6423 * gtkutil.c (xg_maybe_add_timer):
6424 * keyboard.c (readable_events):
6425 * process.c (wait_reading_process_output):
6426 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6428 * insdel.c (adjust_markers_gap_motion):
6429 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6430 (gap_left, gap_right): Don't call it.
6432 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6434 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6435 incurred during fontification.
6437 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6439 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6440 (DEFVAR_PER_BUFFER): Don't pass it.
6442 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6443 (scrolling_window): Don't pass it.
6445 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6447 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6449 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6451 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6452 of variables specific to SELinux and computation of `encoded_absname'.
6454 * image.c (XPutPixel): Remove unused variable `height'.
6456 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6458 * unexw32.c (get_section_info): Remove unused variable `section'.
6460 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6461 (system_process_attributes): Remove unused variable `sess'.
6462 (sys_read): Remove unused variable `err'.
6464 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6465 (w32_wnd_proc): Remove unused variable `isdead'.
6466 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6467 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6468 (x_create_tip_frame): Remove unused variable `tem'.
6470 * w32inevt.c (w32_console_read_socket):
6471 Remove unused variable `no_events'.
6473 * w32term.c (x_draw_composite_glyph_string_foreground):
6474 Remove unused variable `width'.
6476 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6478 * w32term.c (x_set_glyph_string_clipping):
6479 Don't pass uninitialized region to CombineRgn.
6481 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6483 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6484 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6485 (Fx_close_connection): Remove unused variable `i'.
6487 * w32font.c (w32font_draw): Return number of glyphs.
6488 (w32font_open_internal): Remove unused variable `i'.
6489 (w32font_driver): Add missing initializer.
6491 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6492 (fill_in_menu): Remove unused variable `items_added'.
6494 * w32term.c (last_mouse_press_frame): Remove static global variable.
6495 (w32_clip_to_row): Remove unused variable `f'.
6496 (x_delete_terminal): Remove unused variable `i'.
6498 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6499 (NOTHING): Remove unused static global variable.
6500 (uniscribe_check_otf): Remove unused variable `table'.
6501 (uniscribe_font_driver): Add missing initializers.
6503 2011-03-23 Julien Danjou <julien@danjou.info>
6505 * term.c (Fsuspend_tty, Fresume_tty):
6506 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6507 * window.c (temp_output_buffer_show):
6508 * insdel.c (signal_before_change):
6509 * frame.c (Fhandle_switch_frame):
6510 * fileio.c (Fdo_auto_save):
6511 * emacs.c (Fkill_emacs):
6512 * editfns.c (save_excursion_restore):
6513 * cmds.c (internal_self_insert):
6514 * callint.c (Fcall_interactively):
6515 * buffer.c (Fkill_all_local_variables):
6516 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6518 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6519 unconditionnaly since it does the check itself.
6521 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6523 Fix more problems found by GCC 4.5.2's static checks.
6525 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6526 the first time through the loop, since we know p0 < p1 then.
6527 This also avoids a gcc -Wstrict-overflow warning.
6529 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6530 leading to a memory leak, possible in functions like
6531 load_charset_map_from_file that can allocate an unbounded number
6532 of objects (Bug#8318).
6534 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6535 that could (at least in theory) be that large.
6537 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6538 This is less likely to overflow, and avoids undefined behavior if
6539 overflow does occur. All callers changed. Use strtoul to scan
6540 for the unsigned long integer.
6541 (pint2hrstr): Simplify and tune code slightly.
6542 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6544 * scroll.c (do_scrolling): Work around GCC bug 48228.
6545 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6547 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6548 This also avoids a warning with gcc -Wstrict-overflow.
6549 (validate_x_resource_name): Simplify count usage.
6550 This also avoids a warning with gcc -Wstrict-overflow.
6552 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6555 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6557 * process.c (Fmake_network_process): Use socklen_t, not int,
6558 where POSIX says socklen_t is required in portable programs.
6559 This fixes a porting bug on hosts like 64-bit HP-UX, where
6560 socklen_t is wider than int (Bug#8277).
6561 (Fmake_network_process, server_accept_connection):
6562 (wait_reading_process_output, read_process_output):
6565 * process.c: Rename or move locals to avoid shadowing.
6566 (list_processes_1, Fmake_network_process):
6567 (read_process_output_error_handler, exec_sentinel_error_handler):
6568 Rename or move locals.
6569 (Fmake_network_process): Define label "retry_connect" only if needed.
6570 (Fnetwork_interface_info): Fix pointer signedness.
6571 (process_send_signal): Add cast to avoid pointer signedness problem.
6572 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6573 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6575 Make tparam.h and terminfo.c consistent.
6576 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6577 Include tparam.h instead, since it declares them.
6578 * cm.h (PC): Remove extern decl; tparam.h now does this.
6579 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6580 * terminfo.c: Include tparam.h, to check interfaces.
6581 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6582 (tparam): Adjust signature to match interface in tparam.h;
6583 this removes some undefined behavior. Check that outstring and len
6584 are zero, which they always are with Emacs.
6585 * tparam.h (PC, BC, UP): New extern decls.
6587 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6588 (xftfont_open): Rename locals to avoid shadowing.
6590 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6591 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6592 (OTF_TAG_SYM): Omit macro if not needed.
6593 (ftfont_list): Remove unused local.
6594 (get_adstyle_property, ftfont_pattern_entity):
6595 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6596 Rename locals to avoid shadowing.
6598 * xfont.c (xfont_list_family): Mark var as initialized.
6600 * xml.c (make_dom): Now static.
6602 * composite.c (composition_compute_stop_pos): Rename local to
6604 (composition_reseat_it): Remove unused locals.
6605 (find_automatic_composition, composition_adjust_point): Likewise.
6606 (composition_update_it): Mark var as initialized.
6607 (find_automatic_composition): Mark vars as initialized,
6608 with a FIXME (Bug#8290).
6610 character.h: Rename locals to avoid shadowing.
6611 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6612 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6613 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6614 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6617 * textprop.c (property_change_between_p): Remove; unused.
6619 * intervals.c (interval_start_pos): Now static.
6621 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6623 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6624 Rename locals to avoid shadowing.
6626 * sound.c (wav_play, au_play, Fplay_sound_internal):
6627 Fix pointer signedness.
6628 (alsa_choose_format): Remove unused local var.
6629 (wav_play): Initialize a variable to 0, to prevent undefined
6630 behavior (Bug#8278).
6632 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6634 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6636 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6637 clobbering (Bug#8298).
6638 * sysdep.c (sys_subshell): Likewise.
6639 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6641 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6642 This should get cleaned up, so that child_setup has the
6643 same signature on all platforms.
6645 * callproc.c (call_process_cleanup): Now static.
6646 (relocate_fd): Rename locals to avoid shadowing.
6648 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6650 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6651 not to be necessary, and produces flickering.
6653 2011-03-20 Glenn Morris <rgm@gnu.org>
6655 * config.in: Remove file.
6657 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6659 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6660 are now in src/globals.h.
6661 (syms_of_minibuf): Remove spurious & from previous change.
6663 2011-03-20 Leo <sdl.web@gmail.com>
6665 * minibuf.c (completing-read-function): New variable.
6666 (completing-read-default): Rename from completing-read.
6667 (completing-read): Call completing-read-function.
6669 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6671 * xfaces.c (Fx_load_color_file):
6672 Read color file from absolute filename (bug#8250).
6674 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6676 * makefile.w32-in: Update dependencies.
6678 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6680 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6682 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6684 Fix more problems found by GCC 4.5.2's static checks.
6686 * process.c (make_serial_process_unwind, send_process_trap):
6687 (sigchld_handler): Now static.
6689 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6690 That way, the code declares only the vars that it needs.
6691 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6692 * s/cygwin.h (PTY_ITERATION): Likewise.
6693 * s/darwin.h (PTY_ITERATION): Likewise.
6694 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6696 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6697 * process.c (allocate_pty): Don't declare stb unless it's needed.
6699 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6700 (CONSTANTLIM): Remove; unused.
6701 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6702 Define only if needed.
6704 * unexelf.c (unexec): Name an expression,
6705 to avoid gcc -Wbad-function-cast warning.
6706 Use a different way to cause a compilation error if anyone uses
6707 n rather than nn, a way that does not involve shadowing.
6708 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6710 * deps.mk (unexalpha.o): Remove; unused.
6712 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6713 * unexec.h: New file.
6714 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6715 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6717 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6718 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6719 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6720 Change as necessary to match prototype in unexec.h.
6722 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6724 (back_comment, skip_chars): Mark vars as initialized.
6726 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6727 Rename locals to avoid shadowing.
6729 * lread.c (read1): Rewrite so as not to use empty "else".
6730 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6732 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6734 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6735 warning when compiling print.c.
6737 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6738 instead of using an uninitialized var.
6739 (font_sort_entities): Mark var as initialized.
6741 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6743 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6744 pointers to constants.
6745 (font_parse_fcname): Remove unused vars.
6746 (font_delete_unmatched): Now static.
6747 (font_get_spec): Remove; unused.
6748 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6749 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6750 Rename or move locals to avoid shadowing.
6752 * fns.c (require_nesting_list, require_unwind): Now static.
6753 (Ffillarray): Rename locals to avoid shadowing.
6755 * floatfns.c (domain_error2): Define only if needed.
6756 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6758 * alloc.c (mark_backtrace): Move decl from here ...
6759 * lisp.h: ... to here, so that it can be checked.
6761 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6762 (Fdefvar): Rewrite so as not to use empty "else".
6763 (lisp_indirect_variable): Name an expression,
6764 to avoid gcc -Wbad-function-cast warning.
6765 (Fdefvar): Rename locals to avoid shadowing.
6767 * callint.c (quotify_arg, quotify_args): Now static.
6768 (Fcall_interactively): Rename locals to avoid shadowing.
6769 Use const pointer when appropriate.
6771 * lisp.h (get_system_name, get_operating_system_release):
6772 Move decls here, to check interfaces.
6773 * process.c (get_operating_system_release): Move decl to lisp.h.
6774 * xrdb.c (get_system_name): Likewise.
6775 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6776 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6777 some of which prompt warnings from gcc -Wbad-function-cast.
6778 (Fformat_time_string, Fencode_time, Finsert_char):
6779 (Ftranslate_region_internal, Fformat):
6780 Rename or remove local vars to avoid shadowing.
6781 (Ftranslate_region_internal): Mark var as initialized.
6783 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6786 * lisp.h (eassert): Check that the argument compiles, even if
6787 ENABLE_CHECKING is not defined.
6789 * data.c (Findirect_variable): Name an expression, to avoid
6790 gcc -Wbad-function-cast warning.
6791 (default_value, arithcompare, arith_driver, arith_error): Now static.
6792 (store_symval_forwarding): Rename local to avoid shadowing.
6793 (Fmake_variable_buffer_local, Fmake_local_variable):
6794 Mark variables as initialized.
6795 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6797 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6798 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6799 Rename locals to avoid shadowing.
6800 (mark_stack): Move local variables into the #ifdef region where
6802 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6803 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6805 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6806 (GC_STRING_CHARS): Remove; not used.
6807 (Fmemory_limit): Cast sbrk's returned value to char *.
6809 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6810 avoids undefined behavior in theory.
6812 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6814 Use functions, not macros, for up- and down-casing (Bug#8254).
6815 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6816 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6817 to use the following functions instead of these macros.
6818 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6819 EMACS_INT, since callers assume the returned value fits in int.
6820 (upcase1): Likewise, for UPCASE_TABLE.
6821 (uppercasep, lowercasep, upcase): New static inline functions.
6822 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6823 the race-condition problem in the old DOWNCASE.
6825 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6826 Rename locals to avoid shadowing.
6827 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6828 (regex_compile, re_search_2, re_match_2_internal):
6829 Remove unused local vars.
6830 (FREE_VAR): Rewrite so as not to use empty "else",
6831 which gcc can warn about.
6832 (regex_compile, re_match_2_internal): Mark locals as initialized.
6833 (RETALLOC_IF): Define only if needed.
6834 (WORDCHAR_P): Likewise. This one is never needed, but is used
6835 only in a comment talking about a compiler bug, so put inside
6836 the #if 0 of that comment.
6837 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6838 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6841 * search.c (boyer_moore): Rename locals to avoid shadowing.
6842 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6843 (PREV_CHAR_BOUNDARY): Likewise.
6845 * search.c (simple_search): Remove unused var.
6847 * dired.c (compile_pattern): Move decl from here ...
6848 * lisp.h: ... to here, so that it can be checked.
6849 (struct re_registers): New forward decl.
6851 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6853 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6855 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6856 Rename locals to avoid shadowing.
6857 (Fvertical_motion): Mark locals as initialized.
6859 * casefiddle.c (casify_object, casify_region): Now static.
6860 (casify_region): Mark local as initialized.
6862 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6864 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6865 New macros, so that the caller can use some names other than
6866 gcpro1, gcpro2, etc.
6867 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6869 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6870 argument, for consistency with GCPRO2_VAR, etc: it is now the
6871 prefix of the variable, not the variable itself. All uses
6873 * dired.c (directory_files_internal, file_name_completion):
6874 Rename locals to avoid shadowing.
6876 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6877 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6878 dired.c's scmp function, had undefined behavior.
6879 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6880 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6881 * buffer.h: ... to here, because these macros use current_buffer,
6882 and the new implementation with inline functions needs to have
6883 current_buffer in scope now, rather than later when the macros
6885 (downcase, upcase1): New static inline functions.
6886 (DOWNCASE, UPCASE1): Reimplement using these functions.
6887 This avoids undefined behavior in expressions like
6888 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6889 from race conditions in accessing the global variables
6890 case_temp1 and case_temp2.
6891 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6892 * lisp.h (case_temp1, case_temp2): Remove their decls.
6893 * character.h (ASCII_CHAR_P): Move from here ...
6894 * lisp.h: ... to here, so that the inline functions mentioned
6897 * dired.c (directory_files_internal_unwind): Now static.
6899 * fileio.c (file_name_as_directory, directory_file_name):
6900 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6902 (file_name_as_directory): Use const pointers when appropriate.
6903 (Fexpand_file_name): Likewise. In particular, newdir might
6904 point at constant storage, so make it a const pointer.
6905 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6906 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6908 (Fset_file_times, Finsert_file_contents, auto_save_error):
6909 Rename locals to avoid shadowing.
6911 * minibuf.c (choose_minibuf_frame_1): Now static.
6912 (Ftry_completion, Fall_completions): Rename or remove locals
6915 * marker.c (bytepos_to_charpos): Remove; unused.
6917 * lisp.h (verify_bytepos, count_markers): New decls,
6918 so that gcc does not warn that these functions aren't declared.
6920 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6921 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6922 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6923 (copy_text): Remove unused local var.
6925 * filelock.c (within_one_second): Now static.
6926 (lock_file_1): Rename local to avoid shadowing.
6928 * buffer.c (fix_overlays_before): Mark locals as initialized.
6929 (fix_start_end_in_overlays): Likewise. This function should be
6930 simplified by using pointers-to-pointers, but that's a different
6932 (switch_to_buffer_1): Now static.
6933 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6934 (report_overlay_modification): Rename locals to avoid shadowing.
6936 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6937 Fix pointer signedness issue.
6938 (sys_subshell): Mark local as volatile if checking for lint,
6939 to suppress a gcc -Wclobbered warning that does not seem to be right.
6940 (MAXPATHLEN): Define only if needed.
6942 * process.c (serial_open, serial_configure): Move decls from here ...
6943 * systty.h: ... to here, so that they can be checked.
6945 * fns.c (get_random, seed_random): Move extern decls from here ...
6946 * lisp.h: ... to here, so that they can be checked.
6948 * sysdep.c (reset_io): Now static.
6949 (wait_for_termination_signal): Remove; unused.
6951 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6952 (copy_keymap_item, append_key, push_text_char_description):
6954 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6955 (DENSE_TABLE_SIZE): Remove; unused.
6956 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6957 (describe_map_tree):
6958 Rename locals to avoid shadowing.
6960 * keyboard.c: Declare functions static if they are not used elsewhere.
6961 (echo_char, echo_dash, cmd_error, top_level_2):
6962 (poll_for_input, handle_async_input): Now static.
6963 (read_char, kbd_buffer_get_event, make_lispy_position):
6964 (make_lispy_event, make_lispy_movement, apply_modifiers):
6965 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6966 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6967 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6968 (read_key_sequence, read_char): Mark locals as initialized.
6969 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6971 * keyboard.h (make_ctrl_char): New decl.
6972 (mark_kboards): Move decl here ...
6973 * alloc.c (mark_kboards): ... from here.
6975 * lisp.h (force_auto_save_soon): New decl.
6977 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6978 (DEFINE_DUMMY_FUNCTION): New macro.
6979 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6981 (main): Add casts to avoid warnings
6982 if GCC considers string literals to be constants.
6984 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6986 * dbusbind.c: Pointer signedness fixes.
6987 (xd_signature, xd_append_arg, xd_initialize):
6988 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6989 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6990 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6991 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6993 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6994 if GCC considers string literals to be constants.
6995 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6997 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6999 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7000 (print_preprocess, print_object): New macro to fix last change.
7002 * print.c (print_preprocess): Don't forget font objects.
7004 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7006 * emacs.c (USAGE3): Doc fixes.
7008 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7010 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7013 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7015 * lisp.h (VWindow_system, Qfile_name_history):
7016 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7017 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7018 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7020 * w32select.c: Don't #include "keyboard.h".
7021 (run_protected): Add extern declaration for waiting_for_input.
7023 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7024 * w32console.c (detect_input_pending, read_input_pending)
7025 (encode_terminal_code):
7026 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7027 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7028 (w32_system_caret_y, Qfile_name_history):
7029 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7030 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7031 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7032 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7033 * w32proc.c (Qlocal, report_file_error):
7034 * w32term.c (Vwindow_system, updating_frame):
7035 * w32uniscribe.c (initialized, uniscribe_font_driver):
7036 Remove unneeded extern declarations.
7038 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7040 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7042 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7044 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7045 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7046 These macros can no longer be used for assignment.
7048 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7049 Assign struct members directly, instead of using BUF_BEGV etc.
7050 (record_buffer_markers, fetch_buffer_markers): New functions for
7051 recording and fetching special buffer markers.
7052 (set_buffer_internal_1, set_buffer_temp): Use them.
7054 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7056 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7058 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7059 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7061 * xdisp.c (hscroll_window_tree):
7062 (reconsider_clip_changes): Use PT instead of BUF_PT.
7064 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7066 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7067 $(EMACS_ROOT)/lib/intprops.h.
7069 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7071 Fix more problems found by GCC 4.5.2's static checks.
7073 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7074 to unsigned char * to avoid compiler diagnostic.
7075 (xg_free_frame_widgets): Make it clear that a local variable is
7076 needed only if USE_GTK_TOOLTIP.
7077 (gdk_window_get_screen): Make it clear that this macro is needed
7078 only if USE_GTK_TOOLTIP.
7079 (int_gtk_range_get_value): New function, which avoids a diagnostic
7080 from gcc -Wbad-function-cast.
7081 (xg_set_toolkit_scroll_bar_thumb): Use it.
7082 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7083 diagnostic from gcc -Wbad-function-cast.
7084 (get_utf8_string, xg_get_file_with_chooser):
7085 Rename locals to avoid shadowing.
7086 (create_dialog): Move locals to avoid shadowing.
7088 * xgselect.c (xg_select): Remove unused var.
7090 * image.c (four_corners_best): Mark locals as initialized.
7091 (gif_load): Initialize transparent_p to zero (Bug#8238).
7092 Mark another local as initialized.
7093 (my_png_error, my_error_exit): Mark with NO_RETURN.
7095 * image.c (clear_image_cache): Now static.
7096 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7097 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7098 (x_edge_detection): Remove unnecessary cast that
7099 gcc -Wbad-function-cast diagnoses.
7100 (gif_load): Fix pointer signedness.
7101 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7102 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7104 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7106 Improve quality of tests for time stamp overflow.
7107 For example, without this patch (encode-time 0 0 0 1 1
7108 1152921504606846976) returns the obviously-bogus value (-948597
7109 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7110 reports time overflow. See
7111 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7112 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7113 * editfns.c: Include limits.h and intprops.h.
7114 (TIME_T_MIN, TIME_T_MAX): New macros.
7115 (time_overflow): Move earlier, to before first use.
7116 (hi_time, lo_time): New functions, for an accurate test for
7118 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7119 (Fget_internal_run_time): Don't assume time_t fits in int.
7120 (make_time): Use list2 instead of Fcons twice.
7121 (Fdecode_time): More accurate test for out-of-range times.
7122 (check_tm_member): New function.
7123 (Fencode_time): Use it, to test for out-of-range times.
7124 (lisp_time_argument): Don't rely on undefined left-shift and
7125 right-shift behavior when checking for time stamp overflow.
7127 * editfns.c (time_overflow): New function, refactoring common code.
7128 (Fformat_time_string, Fdecode_time, Fencode_time):
7129 (Fcurrent_time_string): Use it.
7131 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7132 * dired.c (make_time): Move to ...
7133 * editfns.c (make_time): ... here.
7134 * systime.h: Note the move.
7136 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7138 * fringe.c (update_window_fringes): Remove unused variables.
7140 * unexmacosx.c (copy_data_segment): Also copy __got section.
7143 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7145 * termcap.c [MSDOS]: Include "msdos.h".
7146 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7147 Constify `char *' arguments and their references according to
7148 prototypes in tparam.h.
7150 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7152 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7153 Adapt all references accordingly.
7155 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7157 2011-03-11 Tom Tromey <tromey@redhat.com>
7159 * buffer.c (syms_of_buffer): Remove obsolete comment.
7161 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7163 * termhooks.h (encode_terminal_code): Declare prototype.
7165 * msdos.c (encode_terminal_code): Don't declare prototype.
7167 * term.c (encode_terminal_code): Now external again, used by
7168 w32console.c and msdos.c.
7170 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7171 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7173 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7175 Fix some minor problems found by GCC 4.5.2's static checks.
7177 * fringe.c (update_window_fringes): Mark locals as initialized
7179 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7181 * alloc.c (mark_fringe_data): Move decl from here ...
7182 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7183 to check its interface.
7184 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7186 * fontset.c (free_realized_fontset): Now static.
7187 (Fset_fontset_font): Rename local to avoid shadowing.
7188 (fontset_font): Mark local as initialized.
7189 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7191 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7193 * xselect.c (x_disown_buffer_selections): Remove; not used.
7194 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7195 (x_own_selection, Fx_disown_selection_internal): Rename locals
7197 (x_handle_dnd_message): Remove local to avoid shadowing.
7199 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7200 so that the caller can use some name other than gcpro1.
7201 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7202 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7203 (Fx_backspace_delete_keys_p):
7204 Use them to avoid shadowing, and rename vars to avoid shadowing.
7205 (x_decode_color, x_set_name, x_window): Now static.
7206 (Fx_create_frame): Add braces to silence GCC warning.
7207 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7208 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7209 Remove unused locals.
7210 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7211 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7212 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7215 * xterm.h (x_mouse_leave): New decl.
7217 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7218 Remove unused functions.
7219 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7220 (x_calc_absolute_position): Now static.
7221 (XTread_socket): Don't define label "out" unless it's used.
7222 Don't declare local "event" unless it's used.
7223 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7224 unless they are used.
7225 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7226 (x_fatal_error_signal): Remove; not used.
7227 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7228 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7229 (x_error_catcher, x_connection_closed, x_error_handler):
7230 (x_error_quitter, xembed_send_message, x_iconify_frame):
7231 (my_log_handler): Rename locals to avoid shadowing.
7232 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7233 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7235 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7236 Rename or move locals to avoid shadowing.
7237 (tty_defined_color, merge_face_heights): Now static.
7238 (free_realized_faces_for_fontset): Remove; not used.
7239 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7240 does not deduce is never used uninitialized.
7241 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7242 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7244 * terminal.c (store_terminal_param): Now static.
7246 * xmenu.c (menu_highlight_callback): Now static.
7247 (set_frame_menubar): Remove unused local.
7248 (xmenu_show): Rename parameter to avoid shadowing.
7249 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7250 since they might point to immutable storage.
7251 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7252 since it's unused otherwise.
7254 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7255 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7256 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7257 avoids a gcc -Wuninitialized diagnostic.
7258 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7259 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7260 does not deduce are never used uninitialized.
7262 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7264 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7265 * window.c (window_loop, size_window):
7266 (run_window_configuration_change_hook, enlarge_window): Likewise.
7268 * window.c (display_buffer): Now static.
7269 (size_window): Mark variables that gcc -Wuninitialized
7270 does not deduce are never used uninitialized.
7271 * window.h (check_all_windows): New decl, to forestall
7272 gcc -Wmissing-prototypes diagnostic.
7273 * dispextern.h (bidi_dump_cached_states): Likewise.
7275 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7277 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7279 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7280 and to avoid gcc -Wuninitialized warning.
7281 (load_charset_map): Mark variables that gcc -Wuninitialized
7282 does not deduce are never used uninitialized.
7283 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7285 * coding.c (coding_set_source, coding_set_destination):
7286 Use "else { /* comment */ }" rather than "else /* comment */;"
7287 for clarity, and to avoid gcc -Wempty-body warning.
7288 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7289 a block, when the outer 'i' will do.
7290 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7291 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7292 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7293 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7294 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7295 Rename locals to avoid shadowing.
7296 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7297 * coding.c (emacs_mule_char, encode_invocation_designation):
7298 Now static, since they're not used elsewhere.
7299 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7300 (decode_coding_object, encode_coding_object, detect_coding_system):
7301 (decode_coding_emacs_mule): Mark variables that gcc
7302 -Wuninitialized does not deduce are never used uninitialized.
7303 (detect_coding_iso_2022): Initialize a local variable that might
7304 be used uninitialized. Leave a FIXME because it's not clear that
7305 this initialization is needed. (Bug#8211)
7306 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7307 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7308 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7309 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7310 Remove unused macros.
7312 * category.c (hash_get_category_set): Remove unused local var.
7313 (copy_category_table): Now static, since it's not used elsewhere.
7314 * character.c (string_count_byte8): Likewise.
7316 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7317 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7319 * chartab.c (copy_sub_char_table): Now static, since it's not used
7321 (sub_char_table_ref_and_range, char_table_ref_and_range):
7322 Rename locals to avoid shadowing.
7323 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7325 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7326 (BIDI_BOB): Remove unused macro.
7328 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7329 deduce are never used uninitialized.
7330 * term.c (encode_terminal_code): Likewise.
7332 * term.c (encode_terminal_code): Now static. Remove unused local.
7334 * tparam.h: New file.
7335 * term.c, tparam.h: Include it.
7336 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7337 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7338 Move these decls to tparam.h, and make them agree with what
7339 is actually in tparam.c. The previous trick of using incompatible
7340 decls in different modules does not conform to the C standard.
7341 All callers of tparam changed to use tparam's actual API.
7342 * tparam.c (tparam1, tparam, tgoto):
7343 Use const pointers where appropriate.
7345 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7346 * cm.h (struct cm): Likewise.
7347 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7348 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7349 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7350 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7351 (turn_on_face, init_tty): Likewise.
7352 * termchar.h (struct tty_display_info): Likewise.
7354 * term.c (term_mouse_position): Rename local to avoid shadowing.
7356 * alloc.c (mark_ttys): Move decl from here ...
7357 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7359 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7361 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7363 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7365 * search.c (compile_pattern_1): Remove argument regp, unused since
7366 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7367 (compile_pattern): Don't pass it.
7369 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7371 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7372 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7374 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7376 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7378 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7379 gdk_window_get_screen, gdk_window_get_geometry,
7380 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7381 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7382 (xg_get_pixbuf_from_pixmap): New function.
7383 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7384 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7385 Call xg_get_pixbuf_from_pixmap instead of
7386 gdk_pixbuf_get_from_drawable.
7387 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7388 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7389 (xg_check_special_colors): Use GtkStyleContext and its functions
7391 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7392 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7393 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7394 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7395 Call gtk_widget_get_preferred_size.
7396 (xg_frame_resized): gdk_window_get_geometry only takes 5
7398 (xg_win_to_widget, xg_event_is_for_menubar):
7399 Call gdk_x11_window_lookup_for_display.
7400 (xg_set_widget_bg): New function.
7401 (delete_cb): New function.
7402 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7403 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7404 (xg_set_background_color): Call xg_set_widget_bg.
7405 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7406 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7407 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7408 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7410 (update_frame_tool_bar): Call gtk_widget_hide.
7411 (xg_initialize): Use GDK_KEY_g.
7413 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7415 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7417 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7418 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7419 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7421 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7423 * w32xfns.c (select_palette): Check success of RealizePalette against
7424 GDI_ERROR, not zero.
7426 See ChangeLog.11 for earlier changes.
7432 Copyright (C) 2011 Free Software Foundation, Inc.
7434 This file is part of GNU Emacs.
7436 GNU Emacs is free software: you can redistribute it and/or modify
7437 it under the terms of the GNU General Public License as published by
7438 the Free Software Foundation, either version 3 of the License, or
7439 (at your option) any later version.
7441 GNU Emacs is distributed in the hope that it will be useful,
7442 but WITHOUT ANY WARRANTY; without even the implied warranty of
7443 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7444 GNU General Public License for more details.
7446 You should have received a copy of the GNU General Public License
7447 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.