1 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5 2012-03-12 Chong Yidong <cyd@gnu.org>
7 * eval.c (inhibit_lisp_code): Rename from
8 inhibit_window_configuration_change_hook; move from window.c.
10 * xfns.c (unwind_create_frame_1, Fx_create_frame):
11 * window.c (run_window_configuration_change_hook)
12 (syms_of_window): Callers changed.
14 2012-03-11 Chong Yidong <cyd@gnu.org>
16 * keymap.c (Fkey_description): Doc fix (Bug#9700).
18 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
20 2012-03-10 Chong Yidong <cyd@gnu.org>
22 * frame.c (other_visible_frames): Don't assume the selected frame
23 is visible (Bug#10955).
25 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
27 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
29 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
31 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
32 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
35 2012-03-03 Glenn Morris <rgm@gnu.org>
37 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
39 2012-03-02 Eli Zaretskii <eliz@gnu.org>
41 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
42 position past the first glyph_row that ends at ZV. (Bug#10902)
43 (redisplay_window, next_element_from_string): Fix typos in
45 (redisplay_window): Pass to move_it_vertically the margin in
46 pixels, not in screen lines.
48 2012-03-02 Glenn Morris <rgm@gnu.org>
50 * buffer.c (buffer-list-update-hook): Doc fix.
52 2012-02-29 Eli Zaretskii <eliz@gnu.org>
54 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
55 push_it before setting up the iterator for the first overlay
56 string, even if we have an empty string loaded.
57 (next_overlay_string): If there's an empty string on the iterator
58 stack, pop the stack. (Bug#10903)
60 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
62 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
63 Suggested by Stefan Monnier in
64 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
65 * alloc.c (widen_to_Lisp_Object): New static function.
66 (mark_memory): Also mark Lisp_Objects by fetching pointer words
67 and widening them to Lisp_Objects. This would work even if
68 USE_LSB_TAG is defined and wide integers are used, which might
69 happen in a future version of Emacs.
71 2012-02-25 Chong Yidong <cyd@gnu.org>
73 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
76 * xselect.c (Fx_selection_exists_p): Doc fix.
77 (x_clipboard_manager_save_all): Print an informative message
78 before saving to clipboard manager.
80 2012-02-24 Chong Yidong <cyd@gnu.org>
82 * keyboard.c (process_special_events): Handle all X selection
83 requests in kbd_buffer, not just the next one (Bug#8869).
85 2012-02-23 Chong Yidong <cyd@gnu.org>
87 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
88 call when setting menu-bar-lines and tool-bar-lines parameters.
89 (unwind_create_frame_1): New helper function.
91 * window.c (inhibit_window_configuration_change_hook): New var.
92 (run_window_configuration_change_hook): Obey it.
93 (syms_of_window): Initialize it.
95 2012-02-22 Chong Yidong <cyd@gnu.org>
97 * xterm.c (x_draw_image_relief): Add missing type check for
98 Vtool_bar_button_margin (Bug#10743).
100 2012-02-21 Chong Yidong <cyd@gnu.org>
102 * fileio.c (Vfile_name_handler_alist): Doc fix.
104 * buffer.c (Fget_file_buffer): Protect against invalid file
105 handler return value.
107 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
109 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
110 when computing $valmask.
112 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
113 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
114 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
115 It's useless in that case, and it can cause problems on hosts
116 that allocate halves of EMACS_INT values separately.
117 Reported by Dan Horák. Diagnosed by Andreas Schwab in
118 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
119 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
120 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
121 it avoids undefined behavior on hosts where shifting right by more
122 than the word width has undefined behavior.
124 2012-02-19 Chong Yidong <cyd@gnu.org>
126 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
127 (Funhandled_file_name_directory, Ffile_name_as_directory)
128 (Fdirectory_file_name, Fexpand_file_name)
129 (Fsubstitute_in_file_name): Protect against invalid file handler
130 return values (Bug#10845).
132 2012-02-18 Eli Zaretskii <eliz@gnu.org>
134 * .gdbinit (pitx): Fix incorrect references to fields of the
137 2012-02-17 Chong Yidong <cyd@gnu.org>
139 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
141 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
143 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
144 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
146 2012-02-15 Chong Yidong <cyd@gnu.org>
148 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
149 marked as special. Also, starting docstrings with * is obsolete.
151 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
153 * gnutls.c (emacs_gnutls_write): Fix last change.
155 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
157 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
160 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
162 * keymap.c (Fsingle_key_description): Handle char ranges.
164 2012-02-12 Chong Yidong <cyd@gnu.org>
166 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
167 as that creates a dangerous corner case.
169 * window.c (Fdelete_window_internal): Invalidate the mouse
170 highlight (Bug#9904).
172 2012-02-12 Glenn Morris <rgm@gnu.org>
174 * xselect.c (Fx_own_selection_internal)
175 (Fx_get_selection_internal, Fx_disown_selection_internal)
176 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
177 * nsselect.m (Fx_own_selection_internal)
178 (Fx_disown_selection_internal, Fx_selection_exists_p)
179 (Fx_selection_owner_p, Fx_get_selection_internal):
180 Sync docs and argument specs with the xselect.c versions.
182 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
184 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
186 2012-02-11 Eli Zaretskii <eliz@gnu.org>
188 * w32select.c (Fx_selection_exists_p): Sync doc string and
189 argument list with xselect.c. (Bug#10783)
191 * w16select.c (Fx_selection_exists_p): Sync doc string and
192 argument list with xselect.c. (Bug#10783)
194 2012-02-10 Glenn Morris <rgm@gnu.org>
196 * fns.c (Fsecure_hash): Doc fix.
198 2012-02-09 Kenichi Handa <handa@m17n.org>
200 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
202 2012-02-07 Chong Yidong <cyd@gnu.org>
204 * buffer.c (Fbuffer_local_variables)
205 (buffer_lisp_local_variables): Handle unbound vars correctly;
206 don't let Qunbound leak into Lisp.
208 2012-02-07 Glenn Morris <rgm@gnu.org>
210 * image.c (Fimagemagick_types): Doc fix.
212 * image.c (imagemagick-render-type): Change it from a lisp object
213 to an integer. Move the doc here from the lisp manual.
214 Treat all values not equal to 0 the same.
216 2012-02-06 Chong Yidong <cyd@gnu.org>
218 * doc.c (store_function_docstring): Avoid applying docstring of
219 alias to base function (Bug#2603).
221 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
223 * .gdbinit (pp1, pv1): Remove redundant defines.
226 2012-02-04 Chong Yidong <cyd@gnu.org>
228 * nsterm.m: Declare a global (Bug#10694).
230 2012-02-04 Eli Zaretskii <eliz@gnu.org>
232 * w32.c (get_emacs_configuration_options):
233 Include --enable-checking, if specified, in the return value.
235 2012-02-04 Martin Rudalics <rudalics@gmx.at>
237 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
238 after rounding frame sizes. (Bug#9723)
240 2012-02-04 Eli Zaretskii <eliz@gnu.org>
242 * keyboard.c (adjust_point_for_property): Don't position point
243 before BEGV. (Bug#10696)
245 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
247 Handle overflow when computing char display width (Bug#9496).
248 * character.c (char_width): Return EMACS_INT, not int.
249 (char_width, c_string_width): Check for overflow when
250 computing the width; this is possible now that individual
251 characters can have unbounded width. Problem introduced
252 by merge from Emacs 23 on 2012-01-19.
254 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
256 * dbusbind.c (Fdbus_register_method): Mention the return value
257 :ignore in the docstring.
259 2012-02-02 Glenn Morris <rgm@gnu.org>
261 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
263 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
264 Unconditionally set to t. (Bug#10673)
265 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
266 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
267 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
269 2012-02-02 Kenichi Handa <handa@m17n.org>
271 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
272 0, do not call append_composite_glyph.
274 2012-02-02 Kenichi Handa <handa@m17n.org>
276 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
278 (x_produce_glyphs): If the component of a composition is a null
279 string, set it->pixel_width to 1 to avoid zero-width glyph.
281 2012-02-01 Eli Zaretskii <eliz@gnu.org>
283 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
284 first 2 arguments are identical. This makes inserting large
285 output from a subprocess an order of magnitude faster on
286 MS-Windows, where all sbrk'ed memory is always contiguous.
288 2012-01-31 Glenn Morris <rgm@gnu.org>
290 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
291 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
292 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
294 2012-01-29 Glenn Morris <rgm@gnu.org>
296 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
298 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
300 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
302 2012-01-28 Chong Yidong <cyd@gnu.org>
304 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
306 2012-01-26 Chong Yidong <cyd@gnu.org>
308 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
310 * search.c (Fsearch_forward, Fsearch_backward): Document negative
311 repeat counts (Bug#10507).
313 2012-01-26 Glenn Morris <rgm@gnu.org>
315 * lread.c (syms_of_lread): Doc fix.
317 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
319 * coding.c (encode_designation_at_bol): Change return value to
322 2012-01-25 Chong Yidong <cyd@gnu.org>
324 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
326 2012-01-21 Chong Yidong <cyd@gnu.org>
328 * floatfns.c (Fcopysign): Make the second argument non-optional,
329 since nil is not allowed anyway.
331 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
333 * process.c (read_process_output): Use p instead of XPROCESS (proc).
334 (send_process): Likewise.
336 2012-01-19 Martin Rudalics <rudalics@gmx.at>
338 * window.c (save_window_save, Fcurrent_window_configuration)
339 (Vwindow_persistent_parameters): Do not use Qstate.
342 2012-01-19 Kenichi Handa <handa@m17n.org>
344 * character.c (char_width): New function.
345 (Fchar_width, c_string_width, lisp_string_width):
346 Use char_width (Bug#9496).
348 2012-01-16 Martin Rudalics <rudalics@gmx.at>
350 * window.c (Vwindow_persistent_parameters): New variable.
351 (Fset_window_configuration, save_window_save): Handle persistent
354 2012-01-14 Eli Zaretskii <eliz@gnu.org>
356 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
357 thrashing the stack of the thread. (Bug#9087)
359 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
361 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
363 2012-01-11 Eli Zaretskii <eliz@gnu.org>
365 * xdisp.c (rows_from_pos_range): Handle the case where the
366 highlight ends on a newline. (Bug#10464)
367 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
368 he end column for display of highlight that ends on a newline
371 2012-01-11 Glenn Morris <rgm@gnu.org>
373 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
374 from load-path also when installation-directory is nil. (Bug#10208)
376 2012-01-10 Glenn Morris <rgm@gnu.org>
378 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
380 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
381 Update template values to be closer to their typical values these days.
383 2012-01-09 Eli Zaretskii <eliz@gnu.org>
385 * xdisp.c (rows_from_pos_range): Accept additional argument
386 DISP_STRING, and accept any glyph in a row whose object is that
387 string as eligible for mouse highlight. Fixes mouse highlight of
388 display strings from overlays. (Bug#10464)
390 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
392 emacs: fix an auto-save permissions race condition (Bug#10400)
393 * fileio.c (auto_saving_dir_umask): New static var.
394 (Fmake_directory_internal): Use it.
395 (do_auto_save_make_dir): Set it, instead of invoking chmod after
396 creating the directory. The old code temporarily assigns
397 too-generous permissions to the directory.
398 (do_auto_save_eh): Clear it.
399 (Fdo_auto_save): Catch all errors, not just file errors, so
400 that the var is always cleared.
402 2012-01-07 Eli Zaretskii <eliz@gnu.org>
404 * search.c (scan_buffer): Pass character positions to
405 know_region_cache, not byte positions. (Bug#6540)
407 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
409 * w32.c (sys_rename): Report EXDEV when rename of a directory
410 fails because the target is on another logical disk. (Bug#10284)
412 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
414 * xterm.c (x_embed_request_focus): New function.
416 * xterm.h: Add prototype.
418 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
420 2012-01-05 Glenn Morris <rgm@gnu.org>
422 * emacs.c (emacs_copyright): Update short copyright year to 2012.
424 2012-01-01 Eli Zaretskii <eliz@gnu.org>
426 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
427 Load gnutls_transport_set_lowat only if GnuTLS version is below
429 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
430 GnuTLS versions below 2.11.1.
432 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
434 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
435 to the doc string advising against its use for altering the way
436 windows are scrolled.
438 2011-12-28 Kenichi Handa <handa@m17n.org>
440 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
441 coding-system ASCII compatible only when it does not produce BOM
442 on encoding (Bug#10383).
444 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
446 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
448 (create_and_show_popup_menu): Always use menu_position_func for
451 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
453 * callint.c (Fcall_interactively): Don't truncate prompt string.
455 2011-12-23 Eli Zaretskii <eliz@gnu.org>
457 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
458 property that ends at ZV, so that the bidi iteration could be
459 resumed from there (after widening). (Bug#10360)
461 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
463 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
465 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
467 * nsterm.m (x_free_frame_resources):
468 Release f->output_data.ns->miniimage.
469 (ns_index_color): Fix indentation. Do not retain
470 color_table->colors[i].
472 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
475 * nsfns.m (x_set_background_color): Assign return value from
476 ns_index_color to face-background instead of NSColor*.
477 (ns_implicitly_set_icon_type): Fix indentation.
478 Change assignment in for loop to comparison.
480 * emacs.c (ns_pool): New variable.
481 (main): Assign ns_pool.
482 (Fkill_emacs): Call ns_release_autorelease_pool.
484 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
485 autorelease fdesc, release fdAttrs and tdict.
486 (ns_get_covering_families): Release charset.
487 (ns_findfonts): Release NSFontDescriptor created with new.
488 (ns_uni_to_glyphs): Fix indentation.
489 (setString): Release attrStr before assigning new value.
491 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
493 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
495 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
496 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
498 2011-12-18 David Reitter <reitter@cmu.edu>
500 * nsterm.m (ns_term_init): Subscribe for notifications
501 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
502 to method trackingNotification in EmacsMenu.
504 * nsmenu.m (trackingMenu): New variable.
505 (trackingNotification): New method (from Aquamacs).
506 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
507 from Aquamacs (Bug#7030).
509 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
511 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
512 (symbol_to_nsstring): Fix indentation.
513 (ns_symbol_to_pb): New function.
514 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
515 (Fns_rotate_cut_buffers_internal): Remove.
516 (Fns_store_selection_internal): Rename from
517 Fns_store_cut_buffer_internal.
518 (ns_get_foreign_selection, Fx_own_selection_internal)
519 (Fx_disown_selection_internal, Fx_selection_exists_p)
520 (Fns_get_selection_internal, Fns_store_selection_internal):
521 Use ns_symbol_to_pb and check if return value is nil.
522 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
523 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
524 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
525 renamed to Sns_store_selection_internal.
526 (ns_handle_selection_request): Move code to Fx_own_selection_internal
527 and remove this function.
528 (ns_handle_selection_clear): Remove, never used.
529 (Fx_own_selection_internal): Move code from ns_handle_selection_request
532 2011-12-17 Ken Brown <kbrown@cornell.edu>
534 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
535 GID is unknown (Bug#10257).
537 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
539 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
540 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
541 which caused a build failure on GNU/Linux IA-64. This problem was
542 introduced by my 2011-10-07 patch.
544 2011-12-15 Juri Linkov <juri@jurta.org>
546 * image.c (imagemagick_error): New function. (Bug#10112)
547 (imagemagick_load_image): Comment out `MagickSetResolution' call.
548 Use `imagemagick_error' where ImageMagick functions return
550 (Fimagemagick_types): Add `Fnreverse' to return the list in the
553 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
555 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
556 fill background (Bug#8992).
558 2011-12-13 Martin Rudalics <rudalics@gmx.at>
560 * window.c (Vwindow_combination_resize)
561 (Vwindow_combination_limit): Use t instead of non-nil in
563 (Vrecenter_redisplay): Add first sentence of doc-string on
565 (Frecenter): Fix doc-string typo.
567 2011-12-11 Kenichi Handa <handa@m17n.org>
569 * coding.c (Funencodable_char_position): Pay attention to the
570 buffer text relocation (Bug#9389).
572 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
574 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
575 gtk_init (Bug#10100).
577 2011-12-10 Eli Zaretskii <eliz@gnu.org>
579 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
580 IT->string is nil. (Bug#10263)
582 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
584 * nsterm.h (x_free_frame_resources): Declare.
586 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
587 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
589 * nsterm.h (ns_get_defaults_value): Declare.
591 * nsterm.m (ns_default): Call ns_get_defaults_value.
593 2011-12-09 Eli Zaretskii <eliz@gnu.org>
595 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
598 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
600 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
601 that where the value of an _OBJC_* symbol points to is in the .bss
604 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
606 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
607 after the loop to call ccl_driver at least once (Bug#8619).
609 2011-12-08 Kenichi Handa <handa@m17n.org>
611 * ftfont.c (get_adstyle_property): Fix previous change
614 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
616 * w32.c (init_environment): If no_site_lisp, remove site-lisp
617 dirs from the default value of EMACSLOADPATH (bug#10208).
619 2011-12-07 Glenn Morris <rgm@gnu.org>
621 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
622 installation and source directories as well. (Bug#10208)
624 2011-12-06 Chong Yidong <cyd@gnu.org>
626 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
628 2011-12-06 Glenn Morris <rgm@gnu.org>
630 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
631 as an error, not just -1. (Bug#10217)
633 2011-12-05 Chong Yidong <cyd@gnu.org>
635 * keyboard.c (process_special_events): New function.
636 (swallow_events, Finput_pending_p): Use it (Bug#10195).
638 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
640 * coding.c (encode_designation_at_bol): Don't use uninitialized
641 local variable (Bug#9318).
643 2011-12-05 Kenichi Handa <handa@m17n.org>
645 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
646 return Qnil (Bug#8046, Bug#10193).
648 2011-12-05 Kenichi Handa <handa@m17n.org>
650 * coding.c (encode_designation_at_bol): New args charbuf_end and
651 dst. Return the number of produced bytes. Callers changed.
652 (coding_set_source): Return how many bytes coding->source was
654 (coding_set_destination): Return how many bytes
655 coding->destination was relocated.
656 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
657 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
659 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
661 * coding.c (CODING_CHAR_CHARSET_P): New macro.
662 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
665 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
667 The following changes are to fix Bug#9318.
669 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
670 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
671 (encode_coding_iso_2022, encode_coding_sjis)
672 (encode_coding_big5, encode_coding_charset): Use the above macros.
674 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
676 * lisp.h (process_quit_flag): Fix external declaration.
678 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
680 Don't macro-inline non-performance-critical code.
681 * eval.c (process_quit_flag): New function.
682 * lisp.h (QUIT): Use it.
684 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
686 * nsfns.m (get_geometry_from_preferences): New function.
687 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
689 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
691 * emacs.c (Qkill_emacs): Define.
692 (syms_of_emacs): Initialize it.
693 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
694 Qquit_flag to `kill-emacs' instead.
695 (quit_throw_to_read_char): Add parameter `from_signal'.
696 All callers changed. Call Fkill_emacs if requested and safe.
697 * lisp.h (QUIT): Call Fkill_emacs if requested.
699 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
701 * widget.c (update_wm_hints): Return if wmshell is null.
702 (widget_update_wm_size_hints): New function.
704 * widget.h (widget_update_wm_size_hints): Declare.
706 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
707 widget_update_wm_size_hints (Bug#10104).
709 2011-12-03 Eli Zaretskii <eliz@gnu.org>
711 * xdisp.c (handle_invisible_prop): If the invisible text ends just
712 before a newline, prepare the bidi iterator for consuming the
713 newline, and keep the current paragraph direction. (Bug#10183)
714 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
716 2011-12-02 Juri Linkov <juri@jurta.org>
718 * search.c (Fword_search_regexp): New Lisp function created from
719 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
720 (Fword_search_backward, Fword_search_forward)
721 (Fword_search_backward_lax, Fword_search_forward_lax):
722 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
723 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
725 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
727 * fileio.c (Finsert_file_contents): Move after-change-function call
728 to before the "handled:" label, since all "goto handled" appear in
729 cases where the *-change-functions have already been properly called
732 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
734 * keyboard.c (interrupt_signal): Don't call kill-emacs when
735 waiting for input. (Bug#10169)
737 2011-11-30 Eli Zaretskii <eliz@gnu.org>
739 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
740 verifies glyph row's hash code--we have just reallocated the
741 glyphs, so their contents can be complete garbage. (Bug#10164)
743 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
745 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
747 2011-11-30 Eli Zaretskii <eliz@gnu.org>
749 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
750 attributes are tested _before_ calling verify_row_hash, to protect
751 against GCC re-ordering of the tests. (Bug#10164)
753 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
755 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
757 * xterm.c (handle_one_xevent): Only set async_visible and friends
758 if net_wm_state_hidden_seen is non-zero (Bug#10002)
759 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
760 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
762 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
764 Remove GCPRO-related macros that exist only to avoid shadowing locals.
765 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
766 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
767 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
768 All uses changed to use GCPRO1 etc.
769 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
770 Revert to old implementation (i.e., before 2011-03-11).
772 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
774 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
775 of scroll runs so as to avoid assigning disabled bogus rows and
776 unnecessary graphics copy operations.
778 2011-11-27 Eli Zaretskii <eliz@gnu.org>
780 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
781 (snprintf) [_MSC_VER]: Redirect to _snprintf.
782 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
783 (malloc, free, realloc, calloc): Redirect to e_* only when
786 * lisp.h (GCTYPEBITS): Move before first use.
787 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
788 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
789 this macro definition.
791 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
794 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
796 * gtkutil.c (xg_create_frame_widgets):
797 Call gtk_window_set_has_resize_grip (FALSE) if that function is
798 present with Gtk+ 2.0.
800 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
802 * fileio.c (Finsert_file_contents): Undo previous change; see
803 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
805 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
807 Rename locals to avoid shadowing.
808 * fileio.c (Finsert_file_contents):
809 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
810 * process.c (wait_reading_process_output):
811 Rename inner 'proc' to 'p' to avoid shadowing.
812 Indent for consistency with usual Emacs style.
814 2011-11-25 Eli Zaretskii <eliz@gnu.org>
816 * xdisp.c (redisplay_window): If cursor row is not fully visible
817 after recentering, and scroll-conservatively is set to a large
818 number, scroll window by a few more lines to make the cursor fully
819 visible and out of scroll-margin. (Bug#10105)
820 (start_display): Don't move to the next line if the display should
821 start at a newline that is part of a display vector or an overlay
824 2011-11-24 Juri Linkov <juri@jurta.org>
826 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
827 after the `MagickPingImage' call. (Bug#10112)
829 2011-11-23 Chong Yidong <cyd@gnu.org>
831 * window.c (Fcoordinates_in_window_p): Accept only live windows.
833 2011-11-23 Martin Rudalics <rudalics@gmx.at>
835 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
836 making another buffer current. (Bug#10114)
838 2011-11-23 Glenn Morris <rgm@gnu.org>
840 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
842 2011-11-23 Chong Yidong <cyd@gnu.org>
844 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
847 2011-11-22 Eli Zaretskii <eliz@gnu.org>
849 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
850 and header-lines, as they don't have one computed for them.
853 * .gdbinit (prow): Make displayed values more self-explaining.
856 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
858 * process.c (wait_reading_process_output): Fix asynchrounous
859 GnuTLS socket handling on some versions of the GnuTLS library.
860 (wait_reading_process_output): Add comment and URL.
862 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
864 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
866 2011-11-21 Chong Yidong <cyd@gnu.org>
868 * window.c (Fnext_window, Fprevious_window): Doc fix.
870 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
872 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
874 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
876 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
878 2011-11-20 Martin Rudalics <rudalics@gmx.at>
880 * window.c (Fset_window_combination_limit): Rename argument
882 (Vwindow_combination_limit): Remove "status" from doc-string.
884 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
886 * m/ibms390.h: Remove.
887 * m/ibms390x.h: Don't include "ibms390.h".
889 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
891 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
892 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
894 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
896 * casetab.c (Fset_case_table):
897 * charset.c (Fcharset_after): Fix typos.
899 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
901 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
902 Otherwise, valgrind does not work on some platforms.
903 Problem reported by Andreas Schwab in
904 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
905 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
906 is set, removing the need for VIRT_ADDRESS_VARIES.
907 (PURE_P): Use a more-efficient implementation that needs just one
908 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
909 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
910 to 4 (xorl, subq, cmpq, setbe).
911 * alloc.c (pure): Always extern now, since that's the
912 VIRT_ADDR_VARIES behavior.
913 (PURE_POINTER_P): Use a single comparison, not two, for
914 consistency with the new puresize.h.
915 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
916 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
917 Remove VIRT_ADDR_VARIES no longer needed.
919 2011-11-19 Eli Zaretskii <eliz@gnu.org>
921 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
922 (erase_phys_cursor, update_window_cursor, show_mouse_face)
923 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
924 behave as if the cursor position were at the window margin.
926 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
927 and the cursor position is out of bounds, behave as if the cursor
928 position were at the window margin. (Bug#10075)
930 2011-11-18 Chong Yidong <cyd@gnu.org>
932 * window.c (Fwindow_combination_limit): Make first argument
933 non-optional, since it is meaningless for live windows like the
936 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
938 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
940 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
942 * intervals.c: Fix grafting over the whole buffer (bug#10071).
943 (graft_intervals_into_buffer): Simplify.
945 2011-11-18 Eli Zaretskii <eliz@gnu.org>
947 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
948 hash values of the two rows.
949 (copy_row_except_pointers): Preserve the used[] arrays and the
950 hash values of the two rows. (Bug#10035)
951 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
953 * xdisp.c (row_hash): New function, body extracted from
954 compute_line_metrics.
955 (compute_line_metrics): Call row_hash, instead of computing the
958 * dispnew.c (verify_row_hash): Call row_hash for computing the
959 hash code of a row, instead of duplicating code from xdisp.c.
961 * dispextern.h (row_hash): Add prototype.
963 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
965 * frame.c (delete_frame): Don't delete the terminal when the last
966 X frame is closed if emacs is built with GTK toolkit.
968 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
970 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
972 2011-11-17 Martin Rudalics <rudalics@gmx.at>
974 * window.c (Vwindow_splits): Rename to
975 Vwindow_combination_resize. Suggested by Juri Linkov.
976 (Fsplit_window_internal): Use Vwindow_combination_resize instead
979 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
981 * nsfns.m (Fns_font_name):
982 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
984 2011-11-16 Martin Rudalics <rudalics@gmx.at>
986 * window.h (window): Rename slot "nest" to "combination_limit".
987 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
988 (Fset_window_nest): Rename to Fset_window_combination_limit.
989 (Vwindow_nest): Rename to Vwindow_combination_limit.
990 (recombine_windows, make_parent_window, make_window)
991 (Fsplit_window_internal, saved_window)
992 (Fset_window_configuration, save_window_save): Rename all
993 occurrences of window_nest to window_combination_limit.
995 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
997 * image.c (imagemagick_load_image): Fix typo.
999 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1001 * xdisp.c (display_line): Move the call to
1002 highlight_trailing_whitespace before the call to
1003 compute_line_metrics, since the latter needs to see the final
1004 faces of all the glyphs to compute ROW's hash value.
1005 Fixes assertion violations in row_equal_p. (Bug#10035)
1007 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1009 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1010 just return (bug#10044).
1012 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1014 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1015 with user-defined heap size. Bump the default size of the temacs
1016 heap to 27MB, to avoid memory warning when running temacs.
1017 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1019 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1020 current_matrix and desired_matrix. (Bug#9990)
1021 (verify_row_hash) [XASSERTS]: New function.
1022 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1023 that the hash value of glyph rows is correct.
1025 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1027 * window.h (window): Remove splits slot.
1028 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1029 (Fdelete_other_windows_internal, make_parent_window)
1030 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1031 (Fset_window_configuration, save_window_save): Don't deal with
1032 split status of windows.
1033 (saved_window): Remove splits slot.
1034 (Vwindow_splits): Rewrite doc-string.
1036 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1038 * xfns.c (unwind_create_frame):
1039 * nsfns.m (unwind_create_frame):
1040 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1041 Vframe_list (Bug#9999).
1043 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1045 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1047 2011-11-11 Kenichi Handa <handa@m17n.org>
1049 * callproc.c (Fcall_process): Set the member dst_multibyte of
1052 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1054 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1055 avoid a crash (bug#9496).
1057 2011-11-09 Chong Yidong <cyd@gnu.org>
1059 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1060 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1062 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1064 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1066 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1068 Avoid some portability problems by eschewing 'extern inline' functions.
1069 The trivial performance wins aren't worth the portability hassles; see
1070 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1072 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1073 (window_box_width, window_box_left, window_box_left_offset)
1074 (window_box_right, window_box_right_offset): Undo previous change,
1075 by removing the "extern"s.
1076 * intervals.c (adjust_intervals_for_insertion)
1077 (adjust_intervals_for_deletion): Undo previous change,
1078 making these static again.
1079 (offset_intervals, temp_set_point_both, temp_set_point)
1080 (copy_intervals_to_string): No longer inline.
1081 * xdisp.c (window_text_bottom_y, window_box_width)
1082 (window_box_height, window_box_left_offset)
1083 (window_box_right_offset, window_box_left, window_box_right)
1084 (window_box): No longer inline.
1086 2011-11-08 Chong Yidong <cyd@gnu.org>
1088 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1089 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1090 Signal an error if not a live window.
1091 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1092 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1094 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1096 * lisp.h (syms_of_abbrev): Remove declaration.
1097 Reported by CHENG Gao <chenggao@royau.me>.
1099 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1101 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1102 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1103 of temacs in GUI mode.
1105 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1107 * window.h: Declare delete_all_child_windows instead of
1108 delete_all_subwindows.
1109 * window.c (Fwindow_nest, Fset_window_nest)
1110 (Fset_window_new_total, Fset_window_new_normal)
1111 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1112 (delete_all_subwindows): Rename to delete_all_child_windows.
1113 (Fdelete_other_windows_internal, Fset_window_configuration):
1114 Call delete_all_child_windows instead of delete_all_subwindows.
1115 * frame.c (delete_frame): Call delete_all_child_windows instead
1116 of delete_all_subwindows.
1118 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1120 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1121 This is also needed for porting to any host where GC_MARK_STACK is
1122 not GC_MAKE_GCPROS_NOOPS.
1123 (which_symbols): Use it.
1125 2011-11-07 Kenichi Handa <handa@m17n.org>
1127 * coding.c (coding_set_destination): Check coding->src_pos only
1128 when coding->src_object is a buffer (bug#9910).
1130 * process.c (send_process): Set the member src_multibyte of coding
1131 to 0 (bug#9911) when sending a unibyte text.
1133 * callproc.c (Fcall_process): Set the member src_multibyte of
1134 process_coding to 0 (bug#9912).
1136 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1138 * xmenu.c (cleanup_widget_value_tree): New function.
1139 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1140 calling free_menubar_widget_value_tree directly (Bug#9830).
1142 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1144 Fix some portability problems with 'inline'.
1145 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1146 (window_box_width, window_box_left, window_box_left_offset)
1147 (window_box_right, window_box_right_offset): Declare extern.
1148 Otherwise, these inline functions do not conform to C99 and
1149 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1150 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1151 * intervals.c (adjust_intervals_for_insertion)
1152 (adjust_intervals_for_deletion): Now extern, because otherwise the
1153 extern inline functions 'offset_intervals' couldn't refer to it.
1154 (static_offset_intervals): Remove.
1155 (offset_intervals): Rewrite using the old contents of
1156 static_offset_intervals. The old version didn't conform to C99
1157 because an extern inline function contained a reference to an
1158 identifier with static linkage.
1160 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1162 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1165 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1167 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1168 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1169 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1170 return Qleft_to_right.
1172 2011-11-06 Chong Yidong <cyd@gnu.org>
1174 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1175 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1176 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1177 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1178 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1179 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1180 (Fwindow_vscroll): Doc fix.
1181 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1182 argument, since it makes no sense to pass a live window and for
1183 consistency with window-child.
1185 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1187 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1190 2011-11-05 Jason Rumney <jasonr@gnu.org>
1192 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1193 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1195 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1196 bitwise arithmetic preventing use of unicode-sip and non-truetype
1199 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1201 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1204 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1205 initialization code to keep similarity to xfns.c after changes
1208 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1210 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1211 (unwind_create_frame): New function (Bug#9943).
1212 (Fx_create_frame): Restructure code to be more similar to the one in
1213 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1214 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1215 Move terminal->reference_count++ just before making the frame official
1218 * nsterm.m (x_free_frame_resources): New function.
1219 (x_destroy_window): Move code to x_free_frame_resources.
1221 * xfns.c (unwind_create_frame): Fix comment.
1222 (Fx_create_frame, x_create_tip_frame):
1223 Move terminal->reference_count++ just before making the frame
1224 official. Move initialization of image_cache_refcount and
1225 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1227 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1229 Support MSVC build with newer versions of Visual Studio.
1230 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1231 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1234 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1235 which are not supported by MSVC.
1236 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1237 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1239 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1241 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1243 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1245 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1247 Support MSVC build with newer versions of Visual Studio.
1248 * w32.c: Don't include w32api.h for MSVC.
1249 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1251 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1252 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1253 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1254 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1256 (alloca) [_MSC_VER]: Define to _alloca.
1258 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1260 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1262 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1264 * xdisp.c (note_mouse_highlight): If either of
1265 previous/next-single-property-change returns nil, treat that as
1266 the beginning or the end of the buffer. (Bug#9955)
1268 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1270 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1271 label is not null (Bug#9951).
1272 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1275 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1277 * window.c (Fwindow_body_size): Mention in the doc string that the
1278 return value is in frame's canonical units. (Bug#9949)
1280 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1282 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1284 * w32fns.c (unwind_create_frame): If needed, free the glyph
1285 matrices of the partially constructed frame. (Bug#9943)
1286 * xfns.c (unwind_create_frame): Likewise.
1288 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1290 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1291 Don't stop backward scan on the continuation glyph, even though
1292 its CHARPOS is positive.
1293 (mouse_face_from_buffer_pos, note_mouse_highlight):
1294 Rename cover_string to disp_string.
1296 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1298 * window.c (temp_output_buffer_show): Don't use
1299 Vtemp_buffer_show_specifiers.
1300 (Vtemp_buffer_show_specifiers): Remove unused variable.
1302 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1304 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1305 past the beginning of the current glyph matrix.
1307 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1309 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1310 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1311 HAVE_GTK3 (Bug#9869).
1313 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1314 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1316 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1318 * xterm.c: Declare x_handle_net_wm_state to return int.
1319 (handle_one_xevent): Check if we are iconified but don't have
1320 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1321 (get_current_wm_state): Return non-zero if not hidden,
1322 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1323 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1324 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1325 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1327 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1329 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1330 so that this new function doesn't get optimized away by a
1331 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1333 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1335 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1337 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1339 Fix the `xbytecode' command.
1340 * .gdbinit (xprintbytestr): New command.
1341 (xwhichsymbols): Rename from `which'; all callers changed.
1342 (xbytecode): Print the byte-code string as well.
1344 2011-10-29 Kim Storm <storm@cua.dk>
1346 * alloc.c (which_symbols): New function.
1348 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1350 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1353 2011-10-29 Glenn Morris <rgm@gnu.org>
1355 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1356 Not clear what it was for, and it causes various bugs. (Bug#9839)
1358 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1360 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1361 possible random value that matches one of those tested as
1362 condition to clear the mouse face.
1364 2011-10-28 Chong Yidong <cyd@gnu.org>
1366 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1368 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1370 * window.c (make_window): Initialize phys_cursor_on_p.
1372 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1374 * lisp.h (struct Lisp_Symbol): Update comments.
1376 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1378 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1380 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1382 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1383 <oslsachem@gmail.com> for helping to debug this.
1385 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1386 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1387 (g_b_init_get_glyph_outline_w): New static variables.
1388 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1389 (GetGlyphOutlineW_Proc): New typedefs.
1390 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1391 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1393 (w32font_open_internal, compute_metrics):
1394 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1395 instead of calling the "wide" APIs directly.
1397 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1399 * w32.h (syms_of_w32font): Add prototype.
1401 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1403 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1404 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1405 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1406 (Fmove_to_window_line): Doc fix.
1408 2011-10-27 Chong Yidong <cyd@gnu.org>
1410 * process.c (make_process): Set gnutls_state to NULL.
1412 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1413 non-NULL, regardless of GNUTLS_INITSTAGE.
1414 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1415 an error. Set process slots as soon as we allocate them.
1417 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1419 2011-10-27 Chong Yidong <cyd@gnu.org>
1421 * gnutls.c (emacs_gnutls_deinit): New function.
1422 Deallocate credentials structures as well as calling gnutls_deinit.
1423 (Fgnutls_deinit, Fgnutls_boot): Use it.
1425 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1426 (deactivate_process): Call emacs_gnutls_deinit.
1428 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1430 * image.c (x_create_x_image_and_pixmap):
1431 * w32.c (sys_rename, w32_delayed_load):
1432 * w32font.c (fill_in_logfont):
1433 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1435 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1437 * w32fns.c (w32_default_color_map): New function,
1438 extracted from Fw32_default_color_map.
1439 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1441 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1443 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1445 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1447 * keyboard.c (test_undefined): New function (bug#9751).
1448 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1450 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1452 * sysdep.c (init_sys_modes): Fix the check for the controlling
1453 terminal (Bug#6649).
1455 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1457 * dispextern.h (struct bidi_it): New member next_en_type.
1459 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1460 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1461 current character, check also for next_en_type being WEAK_EN.
1462 (bidi_resolve_weak): Don't enter the expensive loop if the current
1463 position is before next_en_pos. Record the bidi type of the first
1464 non-ET, non-BN character we find, in addition to its position.
1465 (bidi_level_of_next_char): Invalidate next_en_type when
1466 next_en_pos is over-stepped.
1468 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1470 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1471 * editfns.c: Rewrite current-time-zone so that it invokes
1472 the equivalent of (format-time-string "%Z") to get the time zone name.
1473 This fixes a bug when the time zone name contains characters that
1474 need converting from the system time locale to Emacs internal format.
1475 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1476 that patch fixed format-time-string to do the conversion, but
1477 I forgot to fix current-time-zone.
1478 (format_time_string): New function, containing most of
1479 what Fformat_time_string used to contain.
1480 (Fformat_time_string): Rewrite in terms of format_time_string.
1481 This doesn't change this function's behavior.
1482 (current-time-zone): Rewrite to use format_time_string.
1483 This fixes the bug reported by Michael Schierl in
1484 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1485 Jason Rumney's 2007-06-07 change worked around this bug, but
1487 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1489 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1491 * xdisp.c (start_display): If the character at POS is displayed
1492 via a display vector, reset IT->current.dpvec_index to zero.
1493 (try_window_reusing_current_matrix): If a line ends in a display
1494 vector or the next line starts in a display vector, continue
1495 redrawing the window even though the character position of
1496 start_row was reached.
1499 2011-10-18 Chong Yidong <cyd@gnu.org>
1501 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1502 with nobreak-char-display too.
1504 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1506 Fix part 3 of bug#9771.
1507 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1508 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1509 non-neutral characters if the current character is a paragraph
1510 separator (a.k.a. Newline). This avoids running the same
1511 expensive loop twice, once when we consume the preceding newline
1512 and the other time when the line actually needs to be displayed.
1513 Avoid the loop when we see neutrals on the base embedding level
1514 following a character whose directionality is the same as the
1515 paragraph's. This avoids running the expensive loop when a line
1516 ends in a long sequence of neutrals, like control characters.
1517 Add assertion against STRONG_AL type. Slightly rearrange code
1518 that determines the type of a neutral given the first non-neutral
1520 (bidi_level_of_next_char): Set next_en_pos to zero when
1521 invalidating its info.
1523 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1525 * xdisp.c (push_display_prop): Determine whether to record string
1526 or buffer position by IT->string, not by IT->method. Allow
1527 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1528 (move_it_vertically_backward): Don't look for character position
1529 immediately after the newline when in a continuation line.
1532 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1534 * window.c (coordinates_in_window): Rewrite and delabelize
1535 vertical border check. (Bug#5357) (Bug#9618)
1537 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1539 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1540 errors in XSetWindowBorder (bug#9310).
1542 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1544 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1545 avoid crash when xmalloc overrun checking is enabled.
1547 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1549 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1550 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1551 cursor motion with <left> and <right> arrow keys.
1553 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1554 some callers set that themselves.
1556 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1558 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1559 display string and the previous row comes from the same string and
1560 is empty. (Bug#9739) (Bug#9738)
1562 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1564 * doc.c (get_doc_string): Encode file name (bug#9735).
1566 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1568 * bidi.c (bidi_level_of_next_char):
1569 * xdisp.c (get_visually_first_element): Remove old incorrect
1570 comments regarding the Unicode Line Separator character.
1572 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1574 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1576 * alloc.c (Fgc_status): Do not access beyond zombies array
1577 boundary if nzombies > MAX_ZOMBIES.
1578 * alloc.c (dump_zombies): Add missing format specifier.
1580 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1582 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1583 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1585 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1586 Some packages use them to denote characters with modifiers.
1588 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1590 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1591 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1592 matching a pp-number. Rename parameter var to var1.
1594 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1596 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1598 2011-10-08 Glenn Morris <rgm@gnu.org>
1600 * callint.c (Fcall_interactively): Give a more explicit error for the
1601 'c' case with a non-character input. (Bug#8479)
1603 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1605 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1607 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1608 lines that are hscrolled on the left.
1610 * dispnew.c (buffer_posn_from_coords): Account for a possible
1611 presence of header-line. (Bug#4426)
1613 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1615 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1616 Don't advertise functionality which we discourage or doesn't work.
1618 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1620 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1621 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1622 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1623 this makes Emacs dump core during garbage collection on rare
1624 occasions. sizeof is obviously inferior to offsetof here, so
1625 stick with offsetof.
1626 (GC_POINTER_ALIGNMENT): New macro.
1627 (mark_memory): Omit 3rd (offset) arg; caller changed.
1628 Don't assume EMACS_INT alignment is the same as pointer alignment.
1630 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1632 * keyboard.c (read_key_sequence_remapped): New var.
1633 (read_key_sequence): Compute remapping in the right buffer.
1634 (command_loop_1): Use read_key_sequence's remapping directly.
1636 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1638 * dired.c (file_name_completion): Don't expand file name.
1639 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1640 before checking file name handler.
1642 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1643 they've been requested explicitly (bug#9591).
1645 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1647 * keymap.c (Fsingle_key_description): Use make_specified_string
1648 instead of build_string to build string from push_key_description.
1651 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1653 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1654 This fixes a Y2038 bug on 64-bit hosts.
1655 * buffer.c (reset_buffer):
1656 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1657 (Fclear_buffer_auto_save_failure):
1658 Use 0, not -1, to represent an unset failure time, since time_t
1659 might not be signed.
1661 Remove dependency on glibc malloc internals.
1662 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1663 Move back here from lisp.h, but with their new implementations.
1664 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1665 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1666 * charset.c (charset_table_init): New static var.
1667 (syms_of_charset): Use it instead of xmalloc. This removes a
1668 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1669 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1670 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1671 Move back to alloc.c.
1672 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1673 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1675 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1677 * nsterm.m (windowDidResize): Call x_set_window_size only when
1678 ns_in_resize is true. Otherwise set pixelwidth/height and
1679 call change_frame_size (Bug#9628).
1681 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1683 Port --enable-checking=all to Fedora 14 x86-64.
1684 * charset.c (syms_of_charset): Also account for glibc malloc's
1685 internal overhead when calculating the initial malloc maximum.
1687 Port --enable-checking=all to Fedora 14 x86.
1688 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1690 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1691 (overrun_check_realloc, overrun_check_free):
1692 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1693 That way, xmalloc returns a properly-aligned pointer even if
1694 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1695 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1696 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1697 into account when calculating the initial malloc maximum.
1698 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1699 Move here from alloc.c, so that charset.c can use it too.
1700 Properly align; the old code wasn't right for common 32-bit hosts
1701 when configured with --enable-checking=all.
1702 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1703 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1705 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1707 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1710 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1712 * xdisp.c (compute_display_string_end): If there's no display
1713 string at CHARPOS, return -1.
1715 * bidi.c (bidi_fetch_char): When compute_display_string_end
1716 returns a negative value, treat the character as a normal
1717 character not covered by a display string. (Bug#9624)
1719 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1721 * lread.c (Fread_from_string): Fix typo in docstring.
1723 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1725 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1726 newline, reseat the iterator instead of bidi-iterating there one
1727 character at a time. (Bug#9610)
1728 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1729 TO_CHARPOS if the bidi iterator is at base embedding level.
1731 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1733 * lread.c (readevalloop): Use correct code for NBSP.
1734 (read1): Likewise. (Bug#9608)
1736 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1738 * dbusbind.c (Fdbus_register_signal): When service is not
1739 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1741 2011-09-25 Glenn Morris <rgm@gnu.org>
1743 * buffer.c (truncate-lines): Doc fix.
1745 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1747 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1748 (Fset_window_next_buffers): Doc fix.
1750 2011-09-24 Glenn Morris <rgm@gnu.org>
1752 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1754 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1756 Fix minor problems found by static checking.
1757 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1758 * indent.c (Fvertical_motion): Fix == vs = typo.
1760 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1762 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1763 Default value is now t. Doc fix.
1765 * indent.c (Fvertical_motion): Compute and apply the overshoot
1766 logic when moving up, not only when moving down. Fix the
1767 confusing name and values of the it_overshoot_expected variable;
1768 logic changes accordingly. (Bug#9254) (Bug#9549)
1770 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1771 CHARPOS is covered by a display string which includes newlines.
1772 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1773 is covered by a display string with embedded newlines.
1775 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1777 * dbusbind.c (Fdbus_register_signal): Add match rule to
1778 Vdbus_registered_objects_table. (Bug#9581)
1779 (Fdbus_register_method, Vdbus_registered_objects_table):
1782 2011-09-24 Jim Meyering <meyering@redhat.com>
1784 do not ignore write error for any output size
1785 The previous change was incomplete.
1786 While it makes emacs --batch detect the vast majority of stdout
1787 write failures, errors were still ignored whenever the output size is
1788 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1789 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1790 && echo FAIL: ignored write error
1791 FAIL: ignored write error
1792 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1793 && echo FAIL: ignored write error
1794 FAIL: ignored write error
1795 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1797 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1799 * emacs.c (Fkill_emacs): In noninteractive mode exit
1800 non-successfully if a write error occurred on stdout. (Bug#9574)
1802 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1804 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1807 * dispextern.h (struct it): Update the comment documenting what
1810 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1812 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1813 a display string, extend search for cursor position to end of row.
1814 (find_row_edges): If the row ends in a newline from a display
1815 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1816 Handle the case of a display string with multiple newlines.
1817 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1818 non-empty line. Fixes confusing cursor motion with arrow keys at
1819 the beginning of a line that starts with whitespace.
1821 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1823 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1826 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1828 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1831 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1833 * xdisp.c (display_line): Record maximum and minimum buffer
1834 positions even if no glyphs were produced (e.g., by a zero-width
1835 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1836 buffer positions that will be removed from the glyph row because
1838 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1839 column is beyond frame width: don't subtract 1 "pixel" when
1840 computing width of the stretch.
1841 (reseat_at_next_visible_line_start): Undo the change made on
1842 2011-09-17 that saved paragraph information and restored it after
1843 the call to `reseat'. (Bug#9545)
1845 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1847 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1848 and turn window cursor on if cleared (Bug#9415).
1850 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1852 * search.c (boyer_moore): Take unibyte characters from pattern
1853 literally. (Bug#9458)
1855 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1857 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1859 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1861 Fix minor problem found by static checking.
1862 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1863 initialized, to pacify gcc -Wuninitialized.
1865 * fileio.c: Report proper errno when syscall falls.
1866 (Finsert_file_contents): Save and restore errno,
1867 so that report_file_error outputs the correct diagnostic.
1868 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1870 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1872 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1874 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1876 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1877 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1879 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1881 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1882 about the current paragraph and restore it after the call to reseat.
1884 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1885 (bidi_find_paragraph_start): Search back for paragraph beginning
1886 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1887 (bidi_move_to_visually_next): Only trigger paragraph-related
1888 computations when the last character is a newline or at EOB, not
1889 just any NEUTRAL_B. (Bug#9470)
1891 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1892 truncated lines if point is covered by a display string. (Bug#9524)
1894 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1896 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1897 (cons_to_x_long): New function.
1898 (lisp_data_to_selection_data): Use it. Correct the test for
1899 short-versus-long data; it was negated. Break out of vector
1900 loop, for efficiency, when a long datum is discovered.
1902 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1904 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1906 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1908 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1909 GCC PR/17406) by declaring this function with external scope.
1911 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1913 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1914 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1916 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1918 * editfns.c (Fformat): Correctly handle text properties on "%%".
1920 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1922 * xterm.c (x_draw_composite_glyph_string_foreground):
1923 * w32term.c (x_draw_composite_glyph_string_foreground):
1924 * term.c (encode_terminal_code):
1925 * composite.c (composition_update_it, get_composition_id):
1926 * xdisp.c (get_next_display_element)
1927 (fill_composite_glyph_string): Add comments about special meaning
1928 of TAB characters in a composition.
1930 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1932 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1933 This occurs when processing a multibyte format.
1934 Problem reported by Wolfgang Jenker.
1936 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1938 * xdisp.c (try_cursor_movement): Only check for exact match if
1939 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1941 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1943 Remove unused external symbols.
1944 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1945 * xdisp.c (calc_pixel_width_or_height): Now static.
1946 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1947 * indent.c (check_display_width):
1948 * w32term.c: Fix comment to match code.
1949 * xterm.c, xterm.h (x_catching_errors): Remove.
1951 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1953 * xselect.c: Use signed conversions more consistently (Bug#9498).
1954 (selection_data_to_lisp_data): Assume incoming selection data are
1955 signed integers, not unsigned. This is to be consistent with
1956 outgoing selection data, which was modified to use signed integers
1957 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1958 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1959 expects long, not unsigned long.
1961 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1963 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1964 computation of loop end. Reported by Johan Bockgård
1967 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1969 * frame.c (Fother_visible_frames_p): Function deleted.
1971 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1973 * indent.c (compute_motion): Process display vector front to back
1974 rather than the other way around. (Bug#2496)
1976 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1978 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1980 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1982 * minibuf.c (Fread_from_minibuffer): Doc fix.
1984 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1986 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1987 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1989 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1991 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1992 value for non-existent files.
1994 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1996 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1997 set its "size" to -1. This will set the modtime_size field of
1998 the corresponding buffer to -1, which is what
1999 verify-visited-file-modtime expects for files that do not exist.
2002 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2004 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2006 * lisp.h: ... from here. push_key_description is no longer
2007 defined in keyboard.c, so its declaration should not be in
2008 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2009 logically belongs with push_key_description.
2011 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2013 * buffer.h: Include <sys/types.h> instead of <time.h>.
2014 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2015 Problem reported by Herbert J. Skuhra.
2017 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2019 * xml.c (parse_region): Make the parsing work for
2020 non-comment-starting XML files again (bug#9144).
2022 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2024 * image.c (gif_load): Fix calculation of bottom and right corner.
2027 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2029 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2030 redisplay in small windows.
2032 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2034 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2036 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2038 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2039 Operate on live windows only.
2041 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2043 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2045 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2047 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2048 only under bidi iteration.
2050 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2052 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2054 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2056 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2057 Without this fix, the command to link temacs failed due to an
2058 undefined symbol __builtin_isnan. This is because
2059 /usr/include/iso/math_c99.h #defines isnan(x) to
2060 __builtin_isnan(x), but the bundled gcc, which identifies itself
2061 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2063 * floatfns.c (isnan): #undef, and then #define to a clone of
2065 (Fisnan): Always define, since it's always available now.
2066 (syms_of_floatfns): Always define isnan at the Lisp level.
2068 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2070 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2072 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2074 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2075 The previous code assumed that file offsets (off_t values) fit in
2076 EMACS_INT variables, which is not true on typical 32-bit hosts.
2077 The code messed up by falsely reporting buffer overflow in cases
2078 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2079 when "big" contains more than 2**29 bytes, even though this
2080 inserts just one byte and does not overflow the buffer.
2081 (Finsert_file_contents): Store file offsets as off_t
2082 values, not as EMACS_INT values. Check for overflow when
2083 converting between EMACS_INT and off_t. When checking for
2084 buffer overflow or for overlap, take the offsets into account.
2085 Don't use EMACS_INT for small values where int suffices.
2086 When checking for overlap, fix a typo: ZV was used where
2087 ZV_BYTE was intended.
2088 (Fwrite_region): Don't assume off_t fits into 'long'.
2089 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2091 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2093 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2095 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2097 sprintf-related integer and memory overflow issues (Bug#9412).
2099 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2100 (esprintf, exprintf, evxprintf): New functions.
2101 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2102 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2103 (modify_event_symbol): Do not assume that the length of
2104 name_alist_or_stem is safe to alloca and fits in int.
2105 (Fexecute_extended_command): Likewise for function name and binding.
2106 (Frecursion_depth): Wrap around reliably on integer overflow.
2107 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2108 since some callers pass EMACS_INT values.
2109 (Fsingle_key_description): Don't crash if symbol name contains more
2110 than MAX_ALLOCA bytes.
2111 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2112 (get_minibuffer): Arg is now EMACS_INT, not int.
2113 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2114 (esprintf, exprintf, evxprintf): New decls.
2115 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2117 * dbusbind.c (signature_cat): New function.
2118 (xd_signature, Fdbus_register_signal):
2119 Do not overrun buffer; instead, report string overflow.
2121 * dispnew.c (add_window_display_history): Don't overrun buffer.
2122 Truncate instead; this is OK since it's just a log.
2124 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2125 even if the time zone offset is outlandishly large.
2126 Don't mishandle offset == INT_MIN.
2128 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2129 when creating daemon; the previous buffer-overflow check was incorrect.
2131 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2132 which has the guts of the old verror function.
2134 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2135 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2137 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2138 (font_unparse_xlfd): Don't blindly alloca long strings.
2139 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2140 fits in int, when using sprintf. Use single snprintf to count
2141 length of string rather than counting it via multiple sprintfs;
2142 that's simpler and more reliable.
2143 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2144 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2145 sprintf, in case result does not fit in int.
2147 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2148 (fontset_from_font): Print it.
2150 * frame.c (tty_frame_count): Now printmax_t, not int.
2151 (make_terminal_frame, set_term_frame_name): Print it.
2152 (x_report_frame_params): In X, window IDs are unsigned long,
2153 not signed long, so print them as unsigned.
2154 (validate_x_resource_name): Check for implausibly long names,
2155 and don't assume name length fits in 'int'.
2156 (x_get_resource_string): Don't blindly alloca invocation name;
2157 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2160 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2161 (xg_check_special_colors, xg_set_geometry):
2162 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2164 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2165 Use esprintf, not sprintf, in case result does not fit in int.
2167 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2168 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2169 it as a large positive number.
2170 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2171 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2173 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2174 in case result does not fit in int.
2176 * print.c (float_to_string): Detect width overflow more reliably.
2177 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2178 buffer overrun. Don't assume list length fits in 'int'. Treat
2179 print length of 0 as 0, not as infinity; to be consistent with other
2180 uses of print length in this function. Don't overflow print length
2181 index. Don't assume hash table size fits in 'long', or that
2182 vectorlike size fits in 'unsigned long'.
2184 * process.c (make_process): Use printmax_t, not int, to format
2185 process-name gensyms.
2187 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2189 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2190 to avoid potential buffer overrun.
2192 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2193 if X resource line is longer than 512 bytes.
2195 * xfns.c (x_window): Make sprintf buffer a bit bigger
2196 to avoid potential buffer overrun.
2198 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2200 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2202 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2204 Integer overflow fixes for scrolling, etc.
2205 Without these, Emacs silently mishandles large integers sometimes.
2206 For example, "C-u 4294967297 M-x recenter" was treated as if
2207 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2209 * xdisp.c (try_window_id): Check Emacs fixnum range before
2210 converting to 'int'.
2212 * window.c (window_scroll_line_based, Frecenter):
2213 Check that an Emacs fixnum is in range before assigning it to 'int'.
2214 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2215 values converted from Emacs fixnums.
2216 (Frecenter): Don't wrap around a line count if it is out of 'int'
2217 range; instead, treat it as an extreme value.
2218 (Fset_window_configuration, compare_window_configurations):
2219 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2221 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2222 that can exceed INT_MAX. Check that EMACS_INT value is in range
2223 before assigning it to the (possibly-narrower) index.
2224 (match_limit): Don't assume that a fixnum can fit in 'int'.
2226 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2229 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2230 (Fvertical_motion): Don't wrap around LINES values that don't fit
2231 in 'int'. Instead, treat them as extreme values. This is good
2232 enough for windows, which can't have more than INT_MAX lines anyway.
2234 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2236 * Require libxml/parser.h to avoid compilation warning.
2238 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2240 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2241 since this reportedly can destroy thread storage.
2243 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2245 * syntax.c (find_defun_start): Update all cache variables if
2246 exiting early (Bug#9401).
2248 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2250 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2252 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2253 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2254 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2256 * term.c (tty_append_glyph): New function.
2257 (produce_stretch_glyph): Static function and its prototype deleted.
2259 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2262 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2264 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2265 when checking :margin (Bug#9390).
2266 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2267 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2268 so that the name doesn't mislead. All uses changed.
2270 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2272 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2275 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2277 * xdisp.c (move_it_to): Don't bail out early when reaching
2278 position beyond to_charpos, if we are scanning backwards.
2279 (move_it_vertically_backward): When DY == 0, make sure we get to
2280 the first character in the line after the newline.
2282 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2284 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2285 (ccl_driver): Do not generate an out-of-range pointer.
2286 (Fccl_execute_on_string): Remove unnecessary check for
2287 integer overflow, noted by Stefan Monnier in
2288 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2289 Remove a FIXME that didn't need fixing.
2290 Simplify the newly-introduced buffer reallocation code.
2292 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2294 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2296 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2298 Integer and memory overflow issues (Bug#9196).
2300 * doc.c (get_doc_string): Rework so that
2301 get_doc_string_buffer_size is the actual buffer size, rather than
2302 being 1 less than the actual buffer size; this makes xpalloc more
2305 * image.c (x_allocate_bitmap_record, cache_image):
2306 * xselect.c (Fx_register_dnd_atom):
2307 Simplify previous changes by using xpalloc.
2309 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2310 since either will do and ptrdiff_t is convenient with xpalloc.
2312 * charset.c (charset_table_size)
2313 (struct charset_sort_data.priority): Now ptrdiff_t.
2314 (charset_compare): Don't overflow if priorities differ greatly.
2315 (Fsort_charsets): Don't assume list length fits in int.
2316 Check for size-calculation overflow when allocating sort data.
2317 (syms_of_charset): Allocate an initial charset table that is
2318 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2320 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2322 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2323 The actual value is always <= INT_MAX, and leaving it unsigned made
2324 overflow checking harder.
2326 * dispextern.h (struct glyph_matrix.rows_allocated)
2327 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2328 with xpalloc. The values are still always <= INT_MAX.
2330 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2332 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2333 (SAFE_NALLOCA): New macro.
2335 * region-cache.c (struct boundary.pos, find_cache_boundary)
2336 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2337 (set_cache_region, invalidate_region_cache)
2338 (revalidate_region_cache, know_region_cache, region_cache_forward)
2339 (region_cache_backward, pp_cache):
2340 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2341 so that ptrdiff_t * can be passed to xpalloc.
2342 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2343 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2344 (pp_cache): Don't assume cache_len fits in int.
2345 * region-cache.h: Adjust extern decls to match.
2347 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2348 EMACS_INT, since either will do, for xpalloc.
2350 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2351 (xnmalloc, xnrealloc, xpalloc): New functions.
2353 * bidi.c (bidi_shelve_header_size): New constant.
2354 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2355 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2357 * bidi.c (bidi_cache_shrink):
2358 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2360 Don't update size of array until after memory allocation succeeds,
2361 because xmalloc/xrealloc may not return.
2362 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2363 now that we have proper integer overflow checking.
2364 (record_overlay_string, overlay_strings): Catch overflows when
2365 calculating size of overlay_str_buf.
2367 * callproc.c (Fcall_process): Check for size overflow when
2368 calculating size of args2.
2369 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2370 Normally we prefer signed values, but sticking with ptrdiff_t would
2371 require adding more-complicated checks.
2373 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2374 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2375 Redo buffer-overflow calculations to avoid integer overflow.
2376 Add a FIXME comment where memory seems to be over-allocated.
2378 * character.c (Fstring): Check for size-calculation overflow.
2380 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2381 unnecessary integer overflow. Check for size overflow.
2382 (encode_coding_object): Don't update size until xmalloc succeeds.
2384 * composite.c (get_composition_id): Check for overflow in glyph
2385 length calculations.
2387 Integer and memory overflow fixes for display code.
2388 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2389 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2390 (scrolling_window): Check for overflow in size calculations.
2391 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2392 Don't assume glyph table len fits in int.
2393 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2394 (row_table_size): Now ptrdiff_t, not int.
2395 (scrolling_window): Avoid overflow in size calculations.
2396 Don't update size until allocation succeeds.
2397 * fns.c (concat): Check for overflow in size calculations.
2398 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2399 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2400 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2402 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2403 (get_doc_string): Check for size calculation overflow.
2404 Don't update size until allocation succeeds.
2405 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2406 EMACS_INT, where ptrdiff_t will do.
2407 (Fsubstitute_command_keys): Check for string overflow.
2409 * editfns.c (set_time_zone_rule): Don't assume environment length
2411 (message_length): Now ptrdiff_t, not int.
2412 (Fmessage_box): Don't update size until allocation succeeds.
2413 Don't assume message length fits in int.
2414 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2416 * emacs.c (main): Do not reallocate argv, since there is a null at
2417 the end that can be overwritten, and this way there's no need to
2418 worry about size-calculation overflow.
2419 (sort_args): Check for size-calculation overflow.
2421 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2423 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2425 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2426 (x_set_scroll_bar_width, x_figure_window_size):
2427 Check for integer overflow.
2428 (x_set_alpha): Do not assume XINT fits in int.
2430 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2431 This is for the members text_lines, text_cols, total_lines, total_cols,
2432 where the system imposes an 'int' limit.
2434 * fringe.c (Fdefine_fringe_bitmap):
2435 Don't update size until alloc works.
2437 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2438 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2440 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2441 Check for size-calculation overflow.
2442 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2443 do, as we prefer signed integers.
2444 (id_to_widget.max_size, id_to_widget.used)
2445 (xg_store_widget_in_map, xg_remove_widget_from_map)
2446 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2447 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2448 Use and return ptrdiff_t, not int.
2449 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2450 * gtkutil.h: Change prototypes to match the above.
2452 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2453 are duplicate now that they've been promoted to lisp.h.
2454 (x_allocate_bitmap_record, x_alloc_image_color)
2455 (make_image_cache, cache_image, xpm_load):
2456 Don't update size until alloc is done.
2457 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2459 Check for size calculation overflow.
2460 (ct_colors_allocated_max): New constant.
2461 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2464 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2465 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2466 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2467 Use ptrdiff_t, not int, to count maps.
2468 (read_char_minibuf_menu_prompt): Check for overflow in size
2469 calculations. Don't update size until allocation succeeds.
2470 Redo calculations to avoid overflow.
2471 * keyboard.h: Change prototypes to match the above.
2473 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2475 (current_minor_maps): Check for size calculation overflow.
2476 * keymap.h: Change prototypes to match the above.
2478 * lread.c (read1, init_obarray): Don't update size until alloc done.
2480 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2481 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2483 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2484 Now ptrdiff_t, not int.
2485 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2486 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2488 * process.c (Fnetwork_interface_list): Check for overflow
2489 in size calculation.
2491 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2493 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2494 overflow. Don't bother calling xmalloc when xrealloc will do.
2496 * search.c (Freplace_match): Check for size calculation overflow.
2497 (Fset_match_data): Don't assume list lengths fit in 'int'.
2499 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2500 for command line length. Do not attempt to address one before the
2501 beginning of an array, as that's not portable.
2503 * term.c (max_frame_lines): Remove; unused.
2504 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2506 (encode_terminal_code, calculate_costs): Check for size
2507 calculation overflow.
2508 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2509 table lengths and related sizes. Don't update size until alloc
2510 done. Redo calculations to avoid overflow.
2511 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2513 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2514 subtracting pointers.
2515 (gobble_line): Check for overflow more carefully. Don't update size
2518 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2519 Don't update size until alloc done.
2520 Redo size calculations to avoid overflow.
2521 Check for size calculation overflow.
2522 (main) [DEBUG]: Fix typo in invoking tparam1.
2524 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2525 Use ptrdiff_t, not int, for sizes.
2526 (store_mode_line_noprop_char): Don't update size until alloc done.
2528 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2529 Use ptrdiff_t, not int, for sizes.
2530 (Finternal_make_lisp_face, cache_face):
2531 Check for size calculation overflow.
2532 (cache_face): Treat size calculation overflows as if they were
2533 memory exhaustion (the usual treatment), rather than aborting.
2535 * xfns.c (x_encode_text, x_set_name_internal)
2536 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2537 sizes, since they can exceed INT_MAX in size. Check for size
2538 calculation overflow.
2540 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2541 (xg_select): Check for size calculation overflow.
2542 Don't update size until alloc done.
2544 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2545 as sprintf is limited to int lengths.
2547 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2548 (X_LONG_MIN): New macros.
2549 Use them to make the following changes clearer.
2550 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2551 This change doesn't affect the value now, but it may help remind
2552 future maintainers not to raise the value too much later.
2553 (SELECTION_QUANTUM): Remove, replacing with ...
2554 (selection_quantum): ... new function, which avoids overflow.
2556 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2557 assumption that selection length fits in 'int'.
2558 (x_reply_selection_request, x_handle_selection_request)
2559 (x_get_window_property, receive_incremental_selection)
2560 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2561 (lisp_data_to_selection_data, clean_local_selection_data):
2562 Use ptrdiff_t, not int, to record length of selection.
2563 (x_reply_selection_request, x_get_window_property)
2564 (receive_incremental_selection, x_property_data_to_lisp):
2565 Redo calculations to avoid overflow.
2566 (x_reply_selection_request): When sending hint, ceiling it at
2567 X_LONG_MAX rather than relying on wraparound overflow to send
2569 (x_get_window_property, receive_incremental_selection)
2570 (lisp_data_to_selection_data, x_property_data_to_lisp):
2571 Check for size-calculation overflow.
2572 (x_get_window_property, receive_incremental_selection)
2573 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2574 Don't store size until memory allocation succeeds.
2575 (x_get_window_property): Plug memory leak on memory exhaustion.
2576 Don't double-block input; malloc is safe here. Don't assume 2**34
2577 - 4 fits in unsigned long. Add an xassert to check
2578 XGetWindowProperty overflow. Be more careful about overflow
2579 calculations, and distinguish size from memory overflow better.
2580 (receive_incremental_selection): When tracing, don't assume
2581 unsigned int is less than INT_MAX.
2582 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2583 harmful) conversions of unsigned short to int.
2584 (lisp_data_to_selection_data): Don't assume that integers
2585 in the range -65535 through -1 fit in an X unsigned short.
2586 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2587 result parameters unless successful. Rely on cons_to_unsigned
2588 to report problems with elements; the old code wasn't right anyway.
2589 (x_check_property_data): Check for int overflow; we cannot use
2590 a wider type due to X limits.
2591 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2593 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2595 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2596 (x_term_init): Check for size calculation overflow.
2597 (x_color_cells): Don't store size until memory allocation succeeds.
2598 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2599 Don't assume alloca size is less than MAX_ALLOCA.
2600 (x_term_init): Don't assume length fits in int (sprintf is limited
2603 Use ptrdiff_t for composition IDs.
2604 * character.c (lisp_string_width):
2605 * composite.c (composition_table_size, n_compositions)
2606 (get_composition_id, composition_gstring_from_id):
2607 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2608 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2609 * window.c (Frecenter):
2610 Use ptrdiff_t, not int, for composition IDs.
2611 * composite.c (get_composition_id): Check for integer overflow.
2612 * composite.h: Adjust prototypes to match the above changes.
2614 Use ptrdiff_t for hash table indexes.
2615 * category.c (hash_get_category_set):
2616 * ccl.c (ccl_driver):
2617 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2618 * coding.c (coding_system_charset_list, detect_coding_system):
2619 * coding.h (struct coding_system.id):
2620 * composite.c (get_composition_id, gstring_lookup_cache):
2621 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2622 * image.c (xpm_get_color_table_h):
2623 * lisp.h (hash_lookup, hash_put):
2624 * minibuf.c (Ftest_completion):
2625 Use ptrdiff_t for hash table indexes, not int (which is too
2626 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2627 32-bit --with-wide-int hosts).
2629 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2630 Add a FIXME comment about memory leaks.
2631 (syms_of_charset): Don't assume xmalloc returns.
2633 Don't assume that stated character widths fit in int.
2634 * character.c (Fchar_width, c_string_width, lisp_string_width):
2635 * character.h (CHAR_WIDTH):
2636 * indent.c (MULTIBYTE_BYTES_WIDTH):
2637 Use sanitize_char_width to avoid undefined and/or bad behavior
2638 with outlandish widths.
2639 * character.h (sanitize_tab_width): Rename from sanitize_width,
2640 now that we have two such functions. All uses changed.
2641 (sanitize_char_width): New inline function.
2643 Don't assume that tab-width fits in int.
2644 * character.h (sanitize_width): New inline function.
2645 (SANE_TAB_WIDTH): New macro.
2646 (ASCII_CHAR_WIDTH): Use it.
2647 * indent.c (sane_tab_width): Remove. All uses replaced by
2648 SANE_TAB_WIDTH (current_buffer).
2649 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2651 * fileio.c: Integer overflow issues with file modes.
2652 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2654 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2655 Remove unreachable code.
2656 (read_hex, load_charset_map_from_file): Check for integer overflow.
2658 * xterm.c: Don't go over XClientMessageEvent limit.
2659 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2660 (x_send_scroll_bar_event): Likewise. Check that the size does not
2661 exceed limits imposed by XClientMessageEvent, as well as the usual
2662 ptrdiff_t and size_t limits.
2664 * keyboard.c: Overflow, signedness and related fixes.
2665 (make_lispy_movement): Use same integer type in forward decl
2666 that is used in the definition.
2667 (read_key_sequence, keyremap_step):
2668 Change bufsize argument back to int, undoing my 2011-03-30 change.
2669 We prefer signed types, and int is wide enough here.
2670 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2671 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2672 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2673 length, not size_t. Use ptrdiff_t for index, not int.
2674 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2675 possibility of integer overflow.
2677 Overflow, signedness and related fixes for images.
2679 * dispextern.h (struct it.stack[0].u.image.image_id)
2680 (struct_it.image_id, struct image.id, struct image_cache.size)
2681 (struct image_cache.used, struct image_cache.ref_count):
2682 * gtkutil.c (update_frame_tool_bar):
2683 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2684 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2685 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2686 * nsmenu.m (update_frame_tool_bar):
2687 * xdisp.c (calc_pixel_width_or_height):
2688 * xfns.c (image_cache_refcount):
2689 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2690 on typical 64-bit hosts.
2692 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2693 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2694 Omit unnecessary casts to int.
2695 (parse_image_spec): Check that integers fall into 'int' range
2696 when the callers expect that.
2697 (image_ascent): Redo ascent calculation to avoid int overflow.
2698 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2699 (lookup_image): Remove unnecessary tests.
2700 (xbm_image_p): Locals are now of int, not EMACS_INT,
2701 since parse_image_check makes sure they fit into int.
2702 (png_load, gif_load, svg_load_image):
2703 Prefer int to unsigned where either will do.
2704 (tiff_handler): New function, combining the cores of the
2705 old tiff_error_handler and tiff_warning_handler.
2706 This function is rewritten to use vsnprintf and thereby avoid
2707 stack buffer overflows. It uses only the features of vsnprintf
2708 that are common to both POSIX and native Microsoft.
2709 (tiff_error_handler, tiff_warning_handler): Use it.
2710 (tiff_load, gif_load, imagemagick_load_image):
2711 Don't assume :index value fits in 'int'.
2712 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2713 (imagemagick_load_image): Check that crop parameters fit into
2714 the integer types that MagickCropImage accepts. Don't assume
2715 Vimagemagick_render_type has a nonnegative value. Don't assume
2716 size_t fits in 'long'.
2717 (gs_load): Use printmax_t to print the widest integers possible.
2718 Check for integer overflow when computing image height and width.
2720 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2722 * xdisp.c (redisplay_window): Don't force window start if point
2723 will be invisible in the resulting window. (Bug#9324)
2725 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2727 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2728 the display spec is of the form `(space ...)'.
2729 (handle_display_spec): Return the value returned by
2730 handle_single_display_spec, not just 1 or zero.
2731 (handle_single_display_spec): If the display spec is of the form
2732 `(space ...)', and specifies display in the text area, return 2
2734 (try_cursor_movement): Check for the need to scroll more
2735 accurately, and prefer exact match for point under bidi.
2736 Don't advance `row' beyond the last row of the window.
2738 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2739 into disp_prop; all users changed.
2741 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2742 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2743 for the text covered by the display property.
2745 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2747 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2748 Change return value to nil.
2749 (Frecord_buffer): Delete unused function.
2751 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2753 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2754 buffers, return left-to-right.
2755 (set_cursor_from_row): Consider candidate row a win if its glyph
2756 represents a newline and point is on that newline. Fixes cursor
2757 positioning on the newline at EOL of R2L text within L2R
2758 paragraph, and vice versa.
2759 (try_cursor_movement): Check continued rows, in addition to
2760 continuation rows. Fixes unwarranted scroll when point enters a
2761 continued line of R2L text within an L2R paragraph, or vice versa.
2762 (cursor_row_p): Consider the case of point being equal to
2763 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2764 from the end of a short line to the beginning of a continued line
2765 of R2L text within L2R paragraph.
2766 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2767 composed characters.
2769 * bidi.c (bidi_check_type): Use xassert.
2770 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2773 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2775 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2778 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2780 * nsfont.m (ns_otf_to_script): Fix typo.
2782 2011-08-22 Kenichi Handa <handa@m17n.org>
2784 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2785 extra slot even if the purpose is char-code-property-table.
2787 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2789 * xdisp.c (redisplay_window): When computing centering_position,
2790 account for the height of the header line. (Bug#8874)
2792 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2793 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2794 candidate is selected by the mouse, and that candidate has a
2795 composed character under the mouse.
2797 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2798 coordinates reported by pos-visible-in-window-p for a composed
2799 character in column zero.
2801 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2803 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2805 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2807 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2808 consider it a hit if to_charpos is anywhere in the range of the
2809 composed buffer positions.
2811 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2813 * image.c (gif_load): Don't assume that each subimage has the same
2814 dimensions as the base image. Handle disposal method that is
2815 "undefined" by the gif spec (Bug#9335).
2817 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2819 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2820 (Fcondition_case): Document `debug' symbol in error handler.
2822 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2824 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2825 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2826 from an Org mode buffer to a Speedbar frame.
2828 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2829 a composition, take its buffer position from IT->cmp_it.charpos.
2830 Fixes cursor positioning at the beginning of a line that begins
2831 with a composed character.
2833 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2835 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2836 character bidirectional type, use STRONG_L instead. Fixes crashes
2837 in a buffer produced by `describe-categories'.
2839 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2840 members before the level stack, so they would be saved and
2841 restored when copying iterator state. Fixes incorrect reordering
2842 around TABs covered by display properties.
2844 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2846 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2848 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2850 * eval.c (internal_condition_case, internal_condition_case_1)
2851 (internal_condition_case_2, internal_condition_case_n):
2852 Remove unnecessary aborts (Bug#9081).
2854 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2856 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2857 has no `load' handler, try opening the file locally. (Bug#9311)
2859 2011-08-16 Ken Brown <kbrown@cornell.edu>
2861 * gmalloc.c: Expand comment.
2863 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2865 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2866 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2868 2011-08-16 Ken Brown <kbrown@cornell.edu>
2870 Fix memory allocation problems in Cygwin build (Bug#9273).
2872 * unexcw.c ( __malloc_initialized): Declare external variable.
2873 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2875 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2877 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2879 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2881 [CYGWIN] (special_realloc): New function.
2882 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2883 requests to realloc storage in the static heap.
2885 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2887 * bidi.c (bidi_initialize): Remove unused local.
2889 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2892 * biditype.h: Remove file.
2893 * makefile.w32-in ($(BLD)/bidi.$(O)):
2894 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2896 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2898 * chartab.c: Improve commentary for the uniprop_table API.
2900 * bidi.c (bidi_paragraph_init): Support zero value of
2901 bidi_ignore_explicit_marks_for_paragraph_level.
2902 (bidi_initialize): Use uniprop_table instead of including
2903 biditype.h and bidimirror.h.
2905 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2906 coordinates of the iterator when restoring from ppos_it.
2909 2011-08-14 Kenichi Handa <handa@m17n.org>
2911 * process.c (create_process): Call setup_process_coding_systems
2912 after the pid of the process is set to -1 (Bug#8162).
2914 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2916 * xdisp.c (move_it_in_display_line_to): Don't invoke
2917 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2918 ppos_it. Fixes vertical cursor motion when line beginning is
2919 covered by an image. (Bug#9296)
2921 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2923 * nsterm.h (ns_run_ascript): Declare.
2924 (NSAPP_DATA2_RUNASSCRIPT): Define.
2926 * nsfns.m (as_script, as_result, as_status): New static variables.
2927 (ns_run_ascript): New function.
2928 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2929 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2930 the event loop. Get status from as_status (Bug#7276).
2932 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2933 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2934 the event loop (Bug#7276).
2936 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2938 * gnutls.c (QCgnutls_bootprop_priority)
2939 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2940 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2941 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2942 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2943 (QCgnutls_bootprop_verify_hostname_error)
2944 (QCgnutls_bootprop_callbacks_verify): Rename from
2945 Qgnutls_bootprop_..., all uses changed.
2947 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2950 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2952 * xfaces.c (Qframe_set_background_mode): Now static.
2953 * dispextern.h (Qframe_set_background_mode): Remove decl.
2955 * process.c (Fnetwork_interface_info): Declare local only if needed.
2957 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2959 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2960 (Fnetwork_interface_list): Allocate in increments of bytes instead
2961 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2962 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2964 (struct ifflag_def): notrailers is smart on OSX.
2965 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2966 Get hardware address with getifaddrs if available.
2968 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2970 * xdisp.c (iterate_out_of_display_property): xassert that
2971 IT->position is set to within IT->object's boundaries. Break from
2972 the loop as soon as EOB is reached; avoids infloops in redisplay
2973 when IT->position is set up wrongly due to some bug.
2974 Set IT->current to match the bidi iterator unconditionally.
2975 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2976 entry. Force push_it to save on the stack the current
2977 buffer/string position, to be restored by pop_it. Fix flags in
2978 the iterator structure wrt the object coming from a display
2979 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2980 properties. (Bug#9284)
2982 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2984 * fontset.c (fontset_get_font_group): Add proper type checks.
2987 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2989 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2990 and LC_VERSION_MIN_MACOSX.
2991 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2992 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2994 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2996 * xdisp.c (forward_to_next_line_start): Allow to use the
2997 no-display-properties-and-no-overlays under bidi display.
2998 Set disp_pos in the bidi iterator to avoid searches for display
2999 properties and overlays.
3001 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3003 * editfns.c (Fset_time_zone_rule): Document relationship with the
3006 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3007 the font entity extracted from the cache (Bug#8109).
3009 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3011 * composite.c (autocmp_chars): Don't reset point. That is done by
3012 restore_point_unwind (Bug#5984).
3014 2011-08-07 Juri Linkov <juri@jurta.org>
3016 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3017 to show the arg `TIME' instead of `TIMEVAL'.
3019 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3021 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3022 display property strides EOL and includes a newline, as in
3023 longlines-mode. (Bug#9254)
3024 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3025 word-wrap under bidirectional display. (Bug#9224)
3027 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3028 is non-zero, even if the data buffer is NULL. Fixes a crash in
3029 vertical-motion with longlines-mode. (Bug#9254)
3031 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3033 * bidi.c <bidi_cache_total_alloc>: Now static.
3034 (bidi_initialize): Initialize bidi_cache_total_alloc.
3036 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3039 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3040 amount allocated this far in `bidi_cache_total_alloc'.
3041 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3042 non-zero, only free the data buffer without restoring the cache
3043 contents. All callers changed.
3045 * dispextern.h (bidi_unshelve_cache): Update prototype.
3047 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3048 (move_it_in_display_line, move_it_to)
3049 (move_it_vertically_backward, move_it_by_lines): Replace the call
3050 to xfree to an equivalent call to bidi_unshelve_cache.
3051 (move_it_in_display_line_to): Fix logic of returning
3052 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3054 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3056 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3057 came from a string character with a `cursor' property. (Bug#9229)
3059 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3061 * Makefile.in (LIB_PTHREAD): New variable.
3062 (LIBES): Add LIB_PTHREAD (Bug#9216).
3064 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3065 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3067 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3069 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3071 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3073 * xterm.c (x_find_topmost_parent): New function.
3074 (x_set_frame_alpha): Find topmost parent window with
3075 x_find_topmost_parent and set the property there also (bug#9181).
3076 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3078 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3080 * callproc.c (Fcall_process): Avoid vfork clobbering
3081 the local vars buffer, coding_systems, current_dir.
3083 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3085 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3087 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3089 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3090 so that it is not optimized away.
3092 * xdisp.c (compute_display_string_pos): Remove unused local.
3094 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3096 Fix slow cursor motion and scrolling in large buffers with
3097 selective display, like Org Mode buffers. (Bug#9218)
3099 * dispextern.h (struct bidi_it): New member disp_prop_p.
3101 * xdisp.c: Remove one-slot cache of display string positions.
3102 (compute_display_string_pos): Accept an additional argument
3103 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3104 for a display string or property. If found, set DISP_PROP_P
3107 * bidi.c (bidi_fetch_char): Accept an additional argument
3108 DISP_PROP_P, and pass it to compute_display_string_pos.
3109 Only handle text covered by a display string if DISP_PROP_P is returned
3110 non-zero. All callers of bidi_fetch_char changed.
3112 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3114 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3116 2010-12-03 Don March <don@ohspite.net>
3118 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3119 last character M-[char] is translated to ESC [char] (bug#7541).
3121 2011-08-02 Kenichi Handa <handa@m17n.org>
3123 * lisp.h (uniprop_table): Extern it.
3125 * chartab.c (uniprop_table): Make it non-static.
3127 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3129 * xdisp.c (forward_to_next_line_start): Accept additional argument
3130 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3132 (reseat_at_next_visible_line_start): Use the bidi iterator state
3133 returned by forward_to_next_line_start to restore the state of
3134 it->bidi_it after backing up to previous newline. (Bug#9212)
3136 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3138 * regex.c (re_comp): Protoize.
3139 (re_exec): Fix return type.
3140 (regexec): Fix type of `ret'. (Bug#9203)
3142 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3144 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3145 This is needed if max-image-size is a floating-point number.
3147 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3149 * print.c (print_object): Print empty symbol as ##.
3151 * lread.c (read1): Read ## as empty symbol.
3153 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3155 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3156 setting frame foreground color (Bug#9175).
3157 (x_set_background_color): Likewise.
3159 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3160 contents (Bug#9176).
3161 (EmacsTooltip -init): Remove bezels and add shadows to
3164 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3165 or scroll bar (Bug#8470).
3167 * nsfont.m (nsfont_open): Remove assignment to voffset and
3168 unnecessary vars hshink, expand, hd, full_height, min_height.
3169 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3171 * nsterm.h (nsfont_info): Remove voffset field.
3173 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3175 Implement strike-through and overline on NextStep (Bug#8863).
3177 * nsfont.m (nsfont_open): Use underline position provided by font,
3178 instead of hard-coded value of 2.
3179 (nsfont_draw): Call ns_draw_text_decoration instead.
3181 * nsterm.h: Add declaration for ns_draw_text_decoration.
3183 * nsterm.m (ns_draw_text_decoration): New function for drawing
3184 underline, overline, and strike-through.
3185 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3186 ns_draw_text_decoration. Change treatment of cursor drawing to
3187 accommodate underlining, etc.
3189 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3191 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3194 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3196 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3197 Without this fix, if a signal arrives just after memory fills up,
3198 'malloc' might be invoked reentrantly.
3200 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3201 In other words, assume that every image size is allowed, on non-X
3202 hosts. This assumption is probably wrong, but it lets Emacs compile.
3204 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3206 * regex.c (re_iswctype): Convert return values to boolean.
3208 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3210 * xdisp.c (compute_display_string_pos): Don't use cached display
3211 string position if the buffer had its restriction changed.
3214 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3216 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3218 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3220 Integer signedness and overflow and related fixes. (Bug#9079)
3222 * bidi.c: Integer size and overflow fixes.
3223 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3224 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3225 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3226 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3227 (bidi_find_other_level_edge):
3228 Use ptrdiff_t instead of EMACS_INT where either will do.
3229 This works better on 32-bit hosts configured --with-wide-int.
3230 (bidi_cache_ensure_space): Check for size-calculation overflow.
3231 Use % rather than repeated addition, for better worst-case speed.
3232 Don't set bidi_cache_size until after xrealloc returns, because it
3234 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3235 (bidi_cache_ensure_space): Also check that the bidi cache size
3236 does not exceed that of the largest Lisp string or buffer. See Eli
3237 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3239 * alloc.c (__malloc_size_t): Remove.
3240 All uses replaced by size_t. See Andreas Schwab's note
3241 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3243 * image.c: Improve checking for integer overflow.
3244 (check_image_size): Assume that f is nonnull, since
3245 it is always nonnull in practice. This is one less thing to
3246 worry about when checking for integer overflow later.
3247 (x_check_image_size): New function, which checks for integer
3248 overflow issues inside X.
3249 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3250 This removes the need for a memory_full check.
3251 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3252 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3253 (xbm_read_bitmap_data): Change locals back to 'int', since
3254 their values must fit in 'int'.
3255 (xpm_load_image, png_load, tiff_load):
3256 Invoke x_create_x_image_and_pixmap earlier,
3257 to avoid much needless work if the image is too large.
3258 (tiff_load): Treat overly large images as if
3259 x_create_x_image_and_pixmap failed, not as malloc failures.
3260 (gs_load): Use x_check_image_size.
3262 * gtkutil.c: Omit integer casts.
3263 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3264 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3266 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3268 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3269 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3270 would wrongly return t on a 64-bit host.
3272 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3273 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3274 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3275 and therefore cause GCC to emit a bogus diagnostic in some cases.
3277 * image.c: Integer signedness and overflow and related fixes.
3278 This is not an exhaustive set of fixes, but it's time to
3279 record what I've got.
3280 (lookup_pixel_color, check_image_size): Remove redundant decls.
3281 (check_image_size): Don't assume that arbitrary EMACS_INT values
3282 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3283 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3284 (tiff_load, imagemagick_load_image):
3285 Check for overflow in size calculations.
3286 (x_create_x_image_and_pixmap): Remove unnecessary test for
3287 xmalloc returning NULL; that can't happen.
3288 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3289 (xpm_color_bucket): Use better integer hashing function.
3290 (xpm_cache_color): Don't possibly over-allocate memory.
3291 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3292 (gif_memory_source):
3293 Use ptrdiff_t, not int or size_t, to record sizes.
3294 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3295 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3296 either works, as we prefer signed integers.
3297 (tiff_read_from_memory, tiff_write_from_memory):
3298 Return tsize_t, not size_t, since that's what the TIFF API wants.
3299 (tiff_read_from_memory): Don't fail simply because the read would
3300 go past EOF; instead, return a short read.
3301 (tiff_load): Omit no-longer-needed casts.
3302 (Fimagemagick_types): Don't assume size fits into 'int'.
3304 Improve hashing quality when configured --with-wide-int.
3305 * fns.c (hash_string): New function, taken from sxhash_string.
3306 Do not discard information about ASCII character case; this
3307 discarding is no longer needed.
3308 (sxhash-string): Use it. Change sig to match it. Caller changed.
3309 * lisp.h: Declare it.
3310 * lread.c (hash_string): Remove, since we now use fns.c's version.
3311 The fns.c version returns a wider integer if --with-wide-int is
3312 specified, so this should help the quality of the hashing a bit.
3314 * emacs.c: Integer overflow minor fix.
3315 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3316 Define only if GNU_LINUX.
3317 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3319 * dispnew.c: Integer signedness and overflow fixes.
3320 Remove unnecessary forward decls, that were a maintenance hassle.
3321 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3323 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3324 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3325 (prepare_desired_row, line_draw_cost):
3326 Use int, not unsigned, where either works.
3327 (save_current_matrix, restore_current_matrix):
3328 Use ptrdiff_t, not size_t, where either works.
3329 (init_display): Check for overflow more accurately, and without
3330 relying on undefined behavior.
3332 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3333 Remove, replacing with the new symbols in lisp.h. All uses changed.
3334 * fileio.c (make_temp_name):
3335 * filelock.c (lock_file_1, lock_file):
3336 * xdisp.c (message_dolog):
3337 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3338 Use pMd etc. instead.
3339 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3340 replacing the pWIDE etc. symbols removed from editfns.c.
3342 * keyboard.h (num_input_events): Now uintmax_t.
3343 This is (very slightly) less likely to mess up due to wraparound.
3346 * buffer.c: Integer signedness fixes.
3347 (alloc_buffer_text, enlarge_buffer_text):
3348 Use ptrdiff_t rather than size_t when either will do, as we prefer
3351 * alloc.c: Integer signedness and overflow fixes.
3352 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3353 (__malloc_size_t): Default to size_t, not to int.
3354 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3355 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3356 Prefer ptrdiff_t to size_t when either would do, as we prefer
3358 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3359 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3360 Now const. Initialize with values that are in range even if char
3362 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3363 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3364 These functions do the right thing with sizes > 2**32.
3365 (check_depth): Now ptrdiff_t, not int.
3366 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3367 Adjust to new way of storing sizes. Check for size overflow bugs
3369 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3370 slightly wrong anyway, as it missed one instance of
3371 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3372 (refill_memory_reserve): Omit needless cast to size_t.
3373 (mark_object_loop_halt): Mark as externally visible.
3375 * xselect.c: Integer signedness and overflow fixes.
3376 (Fx_register_dnd_atom, x_handle_dnd_message):
3377 Use ptrdiff_t, not size_t, since we prefer signed.
3378 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3379 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3380 x_dnd_atoms_size and x_dnd_atoms_length.
3382 * doprnt.c: Prefer signed to unsigned when either works.
3384 * doprnt.c (doprnt):
3386 * xdisp.c (vmessage):
3387 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3388 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3389 prefer signed arithmetic to avoid comparison confusion.
3390 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3391 but is a bit tricky.
3393 Assume freestanding C89 headers, string.h, stdlib.h.
3394 * data.c, doprnt.c, floatfns.c, print.c:
3395 Include float.h unconditionally.
3396 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3397 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3398 * regex.c: Likewise for stddef.h, string.h.
3399 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3400 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3401 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3402 (STDC_HEADERS): Remove obsolete defines.
3403 * sysdep.c: Include limits.h unconditionally.
3405 Assume support for memcmp, memcpy, memmove, memset.
3406 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3407 * regex.c (memcmp, memcpy):
3408 Remove; we assume C89 now.
3410 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3411 (__malloc_safe_bcopy): Remove; no longer needed.
3413 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3414 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3415 well either way, and we prefer signed to unsigned.
3417 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3419 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3420 closes the connection while we're reading (bug#9182).
3422 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3424 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3425 are specified (Bug#9168).
3427 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3429 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3430 Found by GCC static checking and --with-wide-int on a 32-bit host.
3432 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3434 * xdisp.c (compute_display_string_pos): Fix logic of caching
3435 previous display string position. Initialize cached_prev_pos to
3436 -1. Fixes slow-down at the beginning of a buffer.
3438 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3440 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3441 for attrs[LFACE_FONTSET_INDEX].
3443 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3445 * xml.c (parse_region): Remove unused local
3446 that was recently introduced.
3448 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3450 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3451 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3453 * xdisp.c (move_it_in_display_line_to): Record the best matching
3454 position for TO_CHARPOS while scanning the line, and restore it on
3455 exit if none of the characters scanned was an exact match.
3456 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3457 when exact match is impossible due to invisible text, and the
3458 lines are truncated.
3460 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3462 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3465 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3467 Fix a significant slow-down of cursor motion with C-n, C-p,
3468 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3469 auto-repeat under bidi redisplay in fontified buffers.
3470 * xdisp.c (compute_stop_pos_backwards): New function.
3471 (next_element_from_buffer): Call compute_stop_pos_backwards to
3472 find a suitable prev_stop when we find ourselves before
3474 (reseat): Don't look for prev_stop, as that could mean a very long
3476 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3477 <cached_disp_overlay_modiff>: Cache for last found display string
3479 (compute_display_string_pos): Return the cached position if asked
3480 about the same buffer in the same area of character positions, and
3481 the buffer wasn't changed since the time the display string
3482 position was cached.
3484 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3486 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3487 is an integer, which is important for empty lines. (Bug#9149)
3489 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3491 * frame.c (Fmodify_frame_parameters): In tty case, update the
3492 default face if necessary (Bug#4238).
3494 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3496 * editfns.c (Fstring_to_char): No need to explain what a character
3497 is in the docstring (Bug#6576).
3499 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3501 * xml.c (parse_region): Make sure we always return a tree.
3503 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3505 * xml.c (parse_region): If a document contains only comments,
3508 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3510 * xml.c (make_dom): Return comments, too.
3512 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3515 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3516 and the surrounding thread.
3517 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3518 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3519 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3521 * s/openbsd.h (BROKEN_SIGIO): Define.
3522 * unexelf.c (unexec) [__OpenBSD__]:
3523 Don't update the .mdebug section of the Alpha COFF symbol table.
3525 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3527 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3530 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3532 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3533 This fixes some race conditions on the permissions of any newly
3536 * alloc.c (valid_pointer_p): Use pipe, not open.
3537 This fixes some permissions issues when debugging.
3539 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3540 If fchown fails to set both uid and gid, try to set just gid,
3541 as that is sometimes allowed. Adjust the file's mode to eliminate
3542 setuid or setgid bits that are inappropriate if fchown fails.
3544 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3546 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3547 to compare Lisp_Objects.
3548 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3549 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3550 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3552 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3554 * lread.c (read_integer): Unread even EOF character.
3555 (read1): Likewise. Properly record start position of symbol.
3557 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3558 symbol character follows.
3560 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3562 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3563 This works around a problem with the previous change to Fcopy_file.
3564 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3565 and without this change, GCC might complain about discarding
3566 fchown's return value.
3568 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3570 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3572 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3574 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3576 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3578 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3579 it's used from the C level.
3581 * process.c: Use the same condition for POLL_FOR_INPUT in both
3582 keyboard.c and process.c (bug#1858).
3584 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3586 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3587 (Fgnutls_boot): Use it.
3589 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3591 * doc.c (Fsubstitute_command_keys): Revert last change.
3593 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3595 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3596 quotes the next character, and doesn't affect other longer
3597 sequences (bug#8935).
3599 * lread.c (syms_of_lread): Clarify that is isn't only
3600 `eval-buffer' and `eval-defun' that's affected by
3601 `lexical-binding' (bug#8460).
3603 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3605 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3606 bidi redisplay when a line includes both an image and is truncated.
3608 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3610 Fix minor problems found by static checking.
3611 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3612 (elsz): Now a signed constant, not a size_t var. We prefer signed
3613 types to unsigned, to avoid integer comparison confusion. Without
3614 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3615 "cannot optimize loop, the loop counter may overflow", a symptom
3617 * indent.c (Fvertical_motion): Mark locals as initialized.
3618 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3620 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3622 * search.c (Fre_search_backward): Mention `case-fold-search' in
3623 all the re_search_* functions (bug#8138).
3625 * keyboard.c (Fopen_dribble_file): Document when the file is
3628 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3630 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3633 Support bidi reordering of display and overlay strings.
3634 * xdisp.c (compute_display_string_pos)
3635 (compute_display_string_end): Accept additional argument STRING.
3636 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3637 (reseat_to_string): Initialize bidi_it->string.s and
3638 bidi_it->string.schars.
3639 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3640 NULL (avoids a crash in bidi_paragraph_init).
3641 Initialize itb.string.lstring.
3642 (init_iterator): Call bidi_init_it only of a valid
3643 buffer position was specified. Initialize paragraph_embedding to
3645 (reseat_to_string): Initialize the bidi iterator.
3646 (display_string): If we need to ignore text properties of
3647 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3648 original value of -1 will not work with bidi.)
3649 (compute_display_string_pos): First arg is now struct
3650 `text_pos *'; all callers changed. Support display properties on
3652 (compute_display_string_end): Support display properties on Lisp
3654 (init_iterator, reseat_1, reseat_to_string): Initialize the
3655 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3656 when iterating on a string not from display properties).
3657 (compute_display_string_pos, compute_display_string_end):
3658 Fix calculation of the object to scan. Fixes an error when using
3660 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3661 base_level_stop; instead, set base_level_stop to BEGV.
3662 Fixes crashes in vertical-motion.
3663 (next_element_from_buffer): Improve commentary for when
3664 the iterator is before prev_stop.
3665 (init_iterator): Initialize bidi_p from the default value of
3666 bidi-display-reordering, not from buffer-local value. Use the
3667 buffer-local value only if initializing for buffer iteration.
3668 (handle_invisible_prop): Support invisible properties on strings
3669 that are being bidi-reordered.
3670 (set_iterator_to_next): Support bidi reordering of C strings and
3672 (next_element_from_string): Support bidi reordering of Lisp
3674 (handle_stop_backwards): Support Lisp strings as well.
3675 (display_string): Support display of R2L glyph rows.
3676 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3677 (init_iterator): Don't initialize it->bidi_p for strings
3679 (reseat_to_string): Initialize it->bidi_p for strings here.
3680 (next_element_from_string, next_element_from_c_string)
3681 (next_element_from_buffer): Add xassert's for correspondence
3682 between IT's object being iterated and it->bidi_it.string
3684 (face_before_or_after_it_pos): Support bidi iteration.
3685 (next_element_from_c_string): Handle the case of the first string
3686 character that is not the first one in the visual order.
3687 (get_visually_first_element): New function, refactored from common
3688 parts of next_element_from_buffer, next_element_from_string, and
3689 next_element_from_c_string.
3690 (tool_bar_lines_needed, redisplay_tool_bar)
3691 (display_menu_bar): Force left-to-right direction. Add a FIXME
3692 comment for making that be controlled by a user option.
3693 (push_it, pop_it): Save and restore the state of the
3694 bidi iterator. Save and restore the bidi_p flag.
3695 (pop_it): Iterate out of display property for string iteration as
3697 (iterate_out_of_display_property): Support iteration over strings.
3698 (handle_single_display_spec): Set up it->bidi_it for iteration
3699 over a display string, and call bidi_init_it.
3700 (handle_single_display_spec, next_overlay_string)
3701 (get_overlay_strings_1, push_display_prop): Set up the bidi
3702 iterator for displaying display or overlay strings.
3703 (forward_to_next_line_start): Don't use the shortcut if
3705 (back_to_previous_visible_line_start): If handle_display_prop
3706 pushed the iterator stack, restore the internal state of the bidi
3707 iterator by calling bidi_pop_it same number of times.
3708 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3709 and we are bidi-iterating, don't decrement the iterator position;
3710 instead, set the first_elt flag in the bidi iterator, to produce
3712 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3713 (push_display_prop): xassert that we are iterating a buffer.
3714 (push_it, pop_it): Save and restore paragraph_embedding member.
3715 (handle_single_display_spec, next_overlay_string)
3716 (get_overlay_strings_1, reseat_1, reseat_to_string)
3717 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3718 correctly. Don't assume unibyte strings are not bidi-reordered.
3719 (compute_display_string_pos)
3720 (compute_display_string_end): Fix handling the case of C string.
3721 (push_it, pop_it): Save and restore from_disp_prop_p.
3722 (handle_single_display_spec, push_display_prop): Set the
3723 from_disp_prop_p flag.
3724 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3725 (pop_it): Call iterate_out_of_display_property only if we are
3726 popping after iteration over a string that came from a display
3727 property. Fix a typo in popping stretch info. Add an assertion
3728 for verifying that the iterator position is in sync with the bidi
3730 (handle_single_display_spec, get_overlay_strings_1)
3731 (push_display_prop): Fix initialization of paragraph direction for
3732 string when that of the parent object is not yet determined.
3733 (reseat_1): Call bidi_init_it to resync the bidi
3734 iterator with IT's position. (Bug#7616)
3735 (find_row_edges): If ROW->start.pos gives position
3736 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3737 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3738 Reset the from_disp_prop_p flag.
3739 (SAVE_IT, RESTORE_IT): New macros.
3740 (pos_visible_p, face_before_or_after_it_pos)
3741 (back_to_previous_visible_line_start)
3742 (move_it_in_display_line_to, move_it_in_display_line)
3743 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3744 (try_scrolling, redisplay_window, display_line): Use them when
3745 saving a temporary copy of the iterator and restoring it back.
3746 (back_to_previous_visible_line_start, reseat_1)
3747 (init_iterator): Empty the bidi cache "stack".
3748 (move_it_in_display_line_to): If iterator ended up at
3749 EOL, but we never saw any buffer positions smaller than
3750 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3751 motion in bidi-reordered lines.
3752 (move_it_in_display_line_to): Record prev_method and prev_pos
3753 immediately before the call to set_iterator_to_next. Fixes cursor
3754 motion in bidi-reordered lines with stretch glyphs and strings
3755 displayed in margins. (Bug#8133) (Bug#8867)
3756 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3758 (pos_visible_p): Support positions in bidi-reordered lines.
3759 Save and restore bidi cache.
3761 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3762 (bidi_paragraph_info): Delete unused struct.
3763 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3764 (bidi_cache_start): New variable.
3765 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3767 (bidi_cache_fetch_state, bidi_cache_search)
3768 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3769 (bidi_cache_find, bidi_peek_at_next_level)
3770 (bidi_level_of_next_char, bidi_find_other_level_edge)
3771 (bidi_move_to_visually_next): Compare cache index with
3772 bidi_cache_start rather than with zero.
3773 (bidi_fetch_char): Accept new argument STRING; all callers
3774 changed. Support iteration over a string. Support strings with
3775 display properties. Support unibyte strings. Fix the type of
3776 `len' according to what STRING_CHAR_AND_LENGTH expects.
3777 (bidi_paragraph_init, bidi_resolve_explicit_1)
3778 (bidi_resolve_explicit, bidi_resolve_weak)
3779 (bidi_level_of_next_char, bidi_move_to_visually_next):
3780 Support iteration over a string.
3781 (bidi_set_sor_type, bidi_resolve_explicit_1)
3782 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3783 can now be zero (for strings); special values 0 and -1 were
3784 changed to -1 and -2, respectively.
3785 (bidi_char_at_pos): New function.
3786 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3787 Call it instead of FETCH_MULTIBYTE_CHAR.
3788 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3789 initialized to valid values.
3790 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3792 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3793 the test for valid cached positions. Fix the logic for looking up
3794 the sentinel state in the cache. GCPRO the Lisp string we are
3796 (bidi_push_it, bidi_pop_it): New functions.
3797 (bidi_initialize): Initialize the bidi cache start stack pointer.
3798 (bidi_cache_ensure_space): New function, refactored from part of
3799 bidi_cache_iterator_state. Don't assume the required size is just
3800 one BIDI_CACHE_CHUNK away.
3801 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3802 (bidi_count_bytes, bidi_char_at_pos): New functions.
3803 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3804 always valid if bidi_cache_idx is valid.
3805 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3806 is valid if it's going to be used.
3807 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3808 (bidi_cache_fetch_state, bidi_cache_search)
3809 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3810 (bidi_cache_iterator_state, bidi_cache_find)
3811 (bidi_find_other_level_edge, bidi_cache_start_stack):
3812 All variables related to cache indices are now EMACS_INT.
3814 * dispextern.h (struct bidi_string_data): New structure.
3815 (struct bidi_it): New member `string'. Make flag members be 1-bit
3816 fields, and put them last in the struct.
3817 (compute_display_string_pos, compute_display_string_end):
3819 (bidi_push_it, bidi_pop_it): Add prototypes.
3820 (struct iterator_stack_entry): New members bidi_p,
3821 paragraph_embedding, and from_disp_prop_p.
3822 (struct it): Member bidi_p is now a bit field 1 bit wide.
3823 (bidi_shelve_cache, bidi_unshelve_cache):
3826 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3827 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3828 and vector-like objects.
3830 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3831 cache around display iteration.
3833 * window.c (Fwindow_end, window_scroll_pixel_based)
3834 (displayed_window_lines, Frecenter): Save and restore the bidi
3835 cache around display iteration.
3837 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3839 * editfns.c (Fdelete_region): Clarify the use of the named
3840 parameters (bug#6788).
3842 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3844 * indent.c (Fvertical_motion): Set and restore w->pointm when
3845 saving and restoring the window's buffer (Bug#9006).
3847 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3849 * editfns.c (Fstring_to_char): Clarify just what is returned
3850 (bug#6576). Text by Eli Zaretskii.
3852 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3854 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3856 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3858 * buffer.c (mmap_find): Fix a typo.
3860 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3862 Fix execution of x selection hooks.
3863 * xselect.c (Qx_lost_selection_functions)
3864 (Qx_sent_selection_functions): New vars.
3865 (syms_of_xselect): DEFSYM them.
3866 (x_handle_selection_request): Pass Qx_sent_selection_functions
3867 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3868 (x_handle_selection_clear,x_clear_frame_selections):
3869 Pass Qx_lost_selection_functions rather than
3870 Vx_lost_selection_functions to Frun_hook_with_args.
3872 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3874 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3875 The old code sometimes used this field without initializing it.
3877 * alloc.c (gc_sweep): Don't read past end of array.
3878 In theory, the old code could also have corrupted Emacs internals,
3879 though it'd be very unlikely.
3881 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3883 * character.c (Fcharacterp): Don't advertise optional ignored
3884 argument. (Bug#4026)
3886 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3888 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3891 * window.c (Fset_window_start): Doc fix (bug#4199).
3892 (Fset_window_hscroll): Ditto.
3894 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3896 Fix minor new problems caught by GCC 4.6.1.
3897 * term.c (init_tty): Remove unused local.
3898 * xsettings.c (store_monospaced_changed): Define this function only
3899 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3902 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3904 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3906 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3908 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3909 are the mini-buffer and the echo area (bug#3320).
3911 * term.c (init_tty): Remove support for supdup, c10 and perq
3912 terminals, which are no longer supported (bug#1482).
3914 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3916 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3918 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3920 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3921 for non-popups (Bug#3642).
3923 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3925 * alloc.c (reset_malloc_hooks): Protoize.
3926 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3927 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3928 * cm.c (losecursor): Likewise.
3929 * data.c (fmod): Likewise.
3930 * dispnew.c (swap_glyphs_in_rows): Likewise.
3931 * emacs.c (memory_warning_signal): Likewise.
3932 * floatfns.c (float_error): Likewise.
3933 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3934 (otf_open, font_otf_capability, generate_otf_features)
3935 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3937 * image.c (pbm_read_file): Likewise.
3938 * indent.c (string_display_width): Likewise.
3939 * intervals.c (check_for_interval, search_for_interval)
3940 (inc_interval_count, count_intervals, root_interval)
3941 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3942 * lread.c (defalias): Likewise.
3943 * ralloc.c (r_alloc_check): Likewise.
3944 * regex.c (set_image_of_range_1, set_image_of_range)
3945 (regex_grow_registers): Likewise.
3946 * sysdep.c (strerror): Likewise.
3947 * termcap.c (valid_filename_p, tprint, main): Likewise.
3948 * tparam.c (main): Likewise.
3949 * unexhp9k800.c (run_time_remap, save_data_space)
3950 (update_file_ptrs, read_header, write_header, calculate_checksum)
3951 (copy_file, copy_rest, display_header): Likewise.
3952 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3954 * xdisp.c (check_it): Likewise.
3955 * xfaces.c (register_color, unregister_color, unregister_colors):
3957 * xfns.c (print_fontset_result): Likewise.
3958 * xrdb.c (member, fatal, main): Likewise.
3960 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3962 Fix minor problems found by static checking (Bug#9031).
3963 * chartab.c (char_table_set_range, map_sub_char_table):
3964 Remove unused locals.
3965 (uniprop_table): Now static.
3966 * composite.c (_work_char): Remove unused static var.
3968 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3970 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3972 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3974 * gtkutil.c (qttip_cb): Remove code without function.
3976 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3978 * w32.c (pthread_sigmask): New stub.
3980 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3982 Use pthread_sigmask, not sigprocmask (Bug#9010).
3983 sigprocmask is portable only for single-threaded applications, and
3984 Emacs can be multi-threaded when it uses GTK.
3985 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3987 * callproc.c (Fcall_process):
3988 * process.c (create_process):
3989 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3990 Use pthread_sigmask, not sigprocmask.
3992 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3994 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3995 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3998 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4000 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4001 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4002 (xg_hide_tooltip): Fix comment.
4004 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4005 in registerServicesMenuSendTypes.
4006 (validRequestorForSendType): Don't check ns_return_types.
4008 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4011 2011-07-08 Jason Rumney <jasonr@gnu.org>
4013 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4014 SH_SHOW for hidden windows (Bug#5482).
4016 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4017 frame struct members of non-existent frames (Bug#6284).
4019 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4021 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4022 variable firstTime not needed on OSX >= 10.6.
4023 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4024 >= 10.5. Use setKnobProportion, setDoubleValue.
4026 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4027 (MAC_OS_X_VERSION_10_5): Define if not defined.
4028 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4029 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4030 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4032 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4033 cString and lossyCString on OSX >= 10.4
4035 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4036 sizeToFit on OSX >= 10.2.
4038 * nsimage.m (allocInitFromFile): Don't use deprecated method
4039 bestRepresentationForDevice on OSX >= 10.6.
4041 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4044 * emacs.c: Declare unexec_init_emacs_zone.
4046 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4048 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4050 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4051 on svcsMenu (Bug#8842).
4053 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4055 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4057 * nsterm.m (QUTF8_STRING): Declare.
4058 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4059 (validRequestorForSendType): Return type is (id).
4060 Change indexOfObjectIdenticalTo to indexOfObject.
4061 Check if we have local selection before returning self (Bug#8842).
4062 (writeSelectionToPasteboard): Put local selection into paste board
4063 if we have a local selection (Bug#8842).
4064 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4066 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4067 (ns_get_local_selection): Declare.
4069 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4071 * keymap.c (describe_map_tree): Don't insert a double newline at
4072 the end of the buffer (bug#1169) and return whether we inserted
4075 * callint.c (Fcall_interactively): Change "reading args" to
4076 "providing args" to try to clarify what it does (bug#1010).
4078 2011-07-07 Kenichi Handa <handa@m17n.org>
4080 * composite.c (composition_compute_stop_pos): Ignore a static
4081 composition starting before CHARPOS (Bug#8915).
4083 * xdisp.c (handle_composition_prop): Likewise.
4085 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4087 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4090 2011-07-07 Kenichi Handa <handa@m17n.org>
4092 * character.h (unicode_category_t): New enum type.
4094 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4095 (Qchar_code_property_table): New variable.
4096 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4097 (UNIPROP_COMPRESSED_FORM_P): New macros.
4098 (char_table_ascii): Uncompress the compressed values.
4099 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4100 Uncompress the compressed values.
4101 (sub_char_table_ref_and_range): Likewise.
4102 (char_table_ref_and_range): Uncompress the compressed values.
4103 (sub_char_table_set): New arg is_uniprop. Callers changed.
4104 Uncompress the compressed values.
4105 (sub_char_table_set_range): Args changed. Callers changed.
4106 (char_table_set_range): Adjuted for the above change.
4107 (map_sub_char_table): Delete args default_val and parent. Add arg
4108 top. Give decoded values to a Lisp function.
4109 (map_char_table): Adjust for the above change. Give decoded
4110 values to a Lisp function. Gcpro more variables.
4111 (uniprop_table_uncompress)
4112 (uniprop_decode_value_run_length): New functions.
4113 (uniprop_decoder, uniprop_decoder_count): New variables.
4114 (uniprop_get_decoder, uniprop_encode_value_character)
4115 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4117 (uniprop_encoder, uniprop_encoder_count): New variables.
4118 (uniprop_get_encoder, uniprop_table)
4119 (Funicode_property_table_internal, Fget_unicode_property_internal)
4120 (Fput_unicode_property_internal): New functions.
4121 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4122 Sunicode_property_table_internal, Sget_unicode_property_internal,
4123 and Sput_unicode_property_internal. Defvar_lisp
4124 char-code-property-alist.
4126 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4127 Vunicode_category_table.
4129 * font.c (font_range): Adjust for the change of
4130 Vunicode_category_table.
4132 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4134 * m/iris4d.h: Remove file, move contents ...
4135 * s/irix6-5.h: ... here.
4137 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4139 Remove unportable assumption about struct layout (Bug#8884).
4140 * alloc.c (mark_buffer):
4141 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4142 (clone_per_buffer_values): Don't assume that
4143 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4144 This isn't true in general, and it's particularly not true
4145 if Emacs is configured with --with-wide-int.
4146 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4147 New macros, used in the buffer.c change.
4149 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4151 * xsettings.c: Use both GConf and GSettings if both are available.
4152 (store_config_changed_event): Add comment.
4153 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4154 (store_tool_bar_style_changed): New functions.
4155 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4156 (struct xsettings): Move font inside HAVE_XFT.
4157 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4158 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4159 Move inside HAVE_XFT.
4160 (something_changed_gsettingsCB): Rename from something_changedCB.
4161 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4163 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4164 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4165 (something_changed_gconfCB): Rename from something_changedCB.
4166 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4167 (parse_settings): Move check for font inside HAVE_XFT.
4168 (read_settings, apply_xft_settings): Add comment.
4169 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4170 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4171 call store_font_name_changed.
4172 (xft_settings_event): Add comment.
4173 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4174 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4175 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4176 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4177 (xsettings_initialize): Call init_gsettings last.
4178 (xsettings_get_system_font, xsettings_get_system_normal_font):
4181 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4183 Random fixes. E.g., (random) never returned negative values.
4184 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4185 subseconds part to the entropy, as that's a bit more random.
4186 Prefer signed to unsigned, since the signedness doesn't matter and
4187 in general we prefer signed. When given a limit, use a
4188 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4189 latter isn't right if USE_2_TAGS_FOR_INTS.
4190 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4191 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4193 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4195 * textprop.c (text_property_stickiness):
4196 Obey Vtext_property_default_nonsticky.
4197 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4198 * w32fns.c (syms_of_w32fns):
4199 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4201 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4203 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4204 This is more efficient than Ffile_directory_p and avoids a minor race.
4206 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4208 * buffer.c (Foverlay_put): Say what the return value is
4211 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4212 is a directory before asking whether to use the file name
4214 (barf_or_query_if_file_exists): Make the "File is a directory"
4215 error be more correct.
4217 * fns.c (Frequire): Remove the mention of the .gz files, since
4218 that's installation-specific, but keep the mention of
4219 `get-load-suffixes'.
4221 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4223 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4224 Report string overflow if the output is too long.
4226 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4228 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4229 (syms_of_gnutls): Remove duplicate DEFSYM for
4230 Qgnutls_bootprop_verify_hostname_error, an error for
4231 Qgnutls_bootprop_verify_error (which is no longer used).
4233 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4234 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4235 Also (re)move comments that are misplaced or no longer relevant.
4237 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4239 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4241 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4243 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4244 and background color parameters if they have been changed.
4246 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4248 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4250 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4252 * xsettings.c (SYSTEM_FONT): Define only when used.
4253 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4255 * keymap.c (access_keymap_1): Now static.
4257 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4259 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4260 leave any prefix arg for the up event (Bug#1586).
4262 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4264 * lread.c (syms_of_lread): Mention single symbols defined by
4265 `defvar' or `defconst' (bug#7154).
4267 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4268 (Frequire): Mention get-load-suffixes.
4270 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4272 * window.h (window): Remove clone_number slot.
4273 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4275 (make_parent_window, make_window, saved_window)
4276 (Fset_window_configuration, save_window_save): Don't deal with
4278 * buffer.c (Qclone_number): Remove declaration.
4279 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4281 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4283 Add multiple inheritance to keymaps.
4284 * keymap.c (Fmake_composed_keymap): New function.
4285 (Fset_keymap_parent): Simplify.
4286 (fix_submap_inheritance): Remove.
4287 (access_keymap_1): New function extracted from access_keymap to handle
4288 embedded parents and handle lists of maps.
4289 (access_keymap): Use it.
4290 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4291 (Fcopy_keymap): Handle embedded parents.
4292 (Fcommand_remapping, define_as_prefix): Simplify.
4293 (Fkey_binding): Simplify.
4294 (syms_of_keymap): Move minibuffer-local-completion-map,
4295 minibuffer-local-filename-completion-map,
4296 minibuffer-local-must-match-map, and
4297 minibuffer-local-filename-must-match-map to Elisp.
4298 (syms_of_keymap): Defsubr make-composed-keymap.
4299 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4300 (parse_menu_item): Trivial simplification.
4302 2011-07-01 Glenn Morris <rgm@gnu.org>
4304 * Makefile.in (SETTINGS_LIBS): Fix typo.
4306 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4308 * coding.c (Fencode_coding_string): Record the last coding system
4309 used, as the function doc string says (bug#8738).
4311 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4313 * xsettings.c (store_monospaced_changed): Take new font as arg and
4314 check for change against current_mono_font.
4315 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4316 (emacs_settings_constructor, emacs_settings_get_property)
4317 (emacs_settings_set_property, emacs_settings_class_init)
4318 (emacs_settings_init, gsettings_obj): Remove.
4319 (something_changedCB): New function for HAVE_GSETTINGS.
4320 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4321 with value as argument.
4322 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4323 g_settings_new (Bug#8967). Do not create gsettings_obj.
4324 Remove calls to g_settings_bind. Connect something_changedCB to
4327 * xgselect.c: Add defined (HAVE_GSETTINGS).
4328 (xgselect_initialize): Ditto.
4330 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4331 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4334 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4336 * eval.c (struct backtrace): Simplify and port the data structure.
4337 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4338 signed bit field, as this assumption is not portable and it makes
4339 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4340 "char debug_on_exit : 1" as this is not portable either; instead,
4341 use the portable "unsigned int debug_on_exit : 1". Remove unused
4342 member evalargs. Remove obsolete comments about cc bombing out.
4344 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4346 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4347 Let HAVE_GSETTINGS override HAVE_GCONF.
4348 (store_monospaced_changed): New function.
4349 (EMACS_SETTINGS): A new type derived from GObject to handle
4350 GSettings notifications.
4351 (emacs_settings_constructor, emacs_settings_get_property)
4352 (emacs_settings_set_property, emacs_settings_class_init):
4354 (gsettings_client, gsettings_obj): New variables.
4355 (GSETTINGS_SCHEMA): New define.
4356 (something_changedCB): Call store_monospaced_changed.
4357 (init_gsettings): New function.
4358 (xsettings_initialize): Call init_gsettings.
4359 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4362 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4365 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4367 * window.c (resize_root_window, grow_mini_window)
4368 (shrink_mini_window): Rename Qresize_root_window to
4369 Qwindow_resize_root_window and Qresize_root_window_vertically to
4370 Qwindow_resize_root_window_vertically.
4372 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4374 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4376 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4378 * makefile.w32-in: Redesign dependencies so they reflect more
4379 clearly which files are directly included by each source file,
4380 and not through other includes.
4382 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4384 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4385 (sort_overlays, overlay_strings): When an overlay's clone number
4386 matches the window's clone number process the overlay even if
4387 the overlay's window property doesn't match the current window.
4389 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4390 (Fwindow_hchild): Rename to Fwindow_left_child.
4391 (Fwindow_next): Rename to Fwindow_next_sibling.
4392 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4393 (resize_window_check): Rename to window_resize_check.
4394 (resize_window_apply): Rename to window_resize_apply.
4395 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4396 (Fdelete_other_windows_internal, resize_frame_windows)
4397 (Fsplit_window_internal, Fdelete_window_internal)
4398 (grow_mini_window, shrink_mini_window)
4399 (Fresize_mini_window_internal): Fix callers accordingly.
4401 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4403 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4404 (emacs_fixed_set_min_size): Remove.
4405 (emacs_fixed_new): Take frame as argument.
4407 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4408 (_EmacsFixedPrivate): Remove minwidth/height.
4409 Add struct frame *f.
4410 (emacs_fixed_init): Initialize priv->f.
4411 (get_parent_class, emacs_fixed_set_min_size): Remove.
4412 (emacs_fixed_new): Set priv->f to argument.
4413 (emacs_fixed_get_preferred_width)
4414 (emacs_fixed_get_preferred_height): Use min_width/height from
4415 frames size_hint to set minimum and natural (Bug#8919).
4416 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4417 and use min_width/height from frames size_hint to set
4418 min_width/height (Bug#8919).
4420 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4421 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4424 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4426 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4427 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4430 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4432 * process.c (wait_reading_process_output): Bypass select if
4433 waiting for a cell while ignoring keyboard input, and input is
4434 pending. Suggested by Jan Djärv (Bug#8869).
4436 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4438 Use gnulib's dup2 module instead of rolling our own.
4439 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4441 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4443 * dispnew.c (scrolling_window): Before scrolling, turn off a
4444 mouse-highlight in the window being scrolled.
4446 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4448 Move DEFSYM to lisp.h and use everywhere.
4450 * character.h (DEFSYM): Move declaration...
4451 * lisp.h (DEFSYM): ...here.
4457 * w32select.c: Don't include character.h.
4459 * alloc.c (syms_of_alloc):
4460 * buffer.c (syms_of_buffer):
4461 * bytecode.c (syms_of_bytecode):
4462 * callint.c (syms_of_callint):
4463 * casefiddle.c (syms_of_casefiddle):
4464 * casetab.c (init_casetab_once):
4465 * category.c (init_category_once, syms_of_category):
4466 * ccl.c (syms_of_ccl):
4467 * cmds.c (syms_of_cmds):
4468 * composite.c (syms_of_composite):
4469 * dbusbind.c (syms_of_dbusbind):
4470 * dired.c (syms_of_dired):
4471 * dispnew.c (syms_of_display):
4472 * doc.c (syms_of_doc):
4473 * editfns.c (syms_of_editfns):
4474 * emacs.c (syms_of_emacs):
4475 * eval.c (syms_of_eval):
4476 * fileio.c (syms_of_fileio):
4477 * fns.c (syms_of_fns):
4478 * frame.c (syms_of_frame):
4479 * fringe.c (syms_of_fringe):
4480 * insdel.c (syms_of_insdel):
4481 * keymap.c (syms_of_keymap):
4482 * lread.c (init_obarray, syms_of_lread):
4483 * macros.c (syms_of_macros):
4484 * msdos.c (syms_of_msdos):
4485 * print.c (syms_of_print):
4486 * process.c (syms_of_process):
4487 * search.c (syms_of_search):
4488 * sound.c (syms_of_sound):
4489 * syntax.c (init_syntax_once, syms_of_syntax):
4490 * terminal.c (syms_of_terminal):
4491 * textprop.c (syms_of_textprop):
4492 * undo.c (syms_of_undo):
4493 * w32.c (globals_of_w32):
4494 * window.c (syms_of_window):
4495 * xdisp.c (syms_of_xdisp):
4496 * xfaces.c (syms_of_xfaces):
4497 * xfns.c (syms_of_xfns):
4498 * xmenu.c (syms_of_xmenu):
4499 * xsettings.c (syms_of_xsettings):
4500 * xterm.c (syms_of_xterm): Use DEFSYM.
4502 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4504 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4506 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4508 Integer and buffer overflow fixes (Bug#8873).
4510 * print.c (printchar, strout): Check for string overflow.
4511 (PRINTPREPARE, printchar, strout):
4512 Don't set size unless allocation succeeds.
4514 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4515 for sizes. Check for string overflow more accurately.
4516 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4518 * macros.c: Integer and buffer overflow fixes.
4519 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4520 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4521 Use ptrdiff_t, not int, for sizes.
4522 Don't increment bufsize until after realloc succeeds.
4523 Check for size-calculation overflow.
4524 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4526 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4528 * lread.c: Integer overflow fixes.
4529 (read_integer): Radix is now EMACS_INT, not int,
4530 to improve quality of diagnostics for out-of-range radices.
4531 Calculate buffer size correctly for out-of-range radices.
4532 (read1): Check for integer overflow in radices, and in
4533 read-circle numbers.
4534 (read_escape): Avoid int overflow.
4535 (Fload, openp, read_buffer_size, read1)
4536 (substitute_object_recurse, read_vector, read_list, map_obarray):
4537 Use ptrdiff_t, not int, for sizes.
4538 (read1): Use EMACS_INT, not int, for sizes.
4539 Check for size overflow.
4541 * image.c (cache_image): Check for size arithmetic overflow.
4543 * lread.c: Integer overflow issues.
4544 (saved_doc_string_size, saved_doc_string_length)
4545 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4546 Now ptrdiff_t, not int.
4547 (read1): Don't assume doc string length fits in int. Check for
4548 out-of-range doc string lengths.
4549 (read_list): Don't assume file position fits in int.
4550 (read_escape): Check for hex character overflow.
4552 2011-06-22 Leo Liu <sdl.web@gmail.com>
4554 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4555 Move to minibuffer.el.
4557 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4559 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4560 The following patches are for when GLYPH_DEBUG && !XASSERT.
4561 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4562 * dispnew.c (flush_stdout):
4563 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4564 Mark as externally visible.
4565 * dispnew.c (check_window_matrix_pointers): Now static.
4566 * dispnew.c (window_to_frame_vpos):
4567 * xfns.c (unwind_create_frame):
4568 * xterm.c (x_check_font): Remove unused local.
4569 * scroll.c (CHECK_BOUNDS):
4570 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4571 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4572 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4573 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4574 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4576 (debug_method_add): Use va_list and vsprintf rather than relying
4577 on undefined behavior with wrong number of arguments.
4578 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4579 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4580 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4581 since we're not interested in debugging glyphs with old libraries.
4582 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4583 GCC 4.6.0's static checking.
4585 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4587 Integer overflow and signedness fixes (Bug#8873).
4588 A few related buffer overrun fixes, too.
4590 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4592 * dispextern.h (struct face.stipple):
4593 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4594 (x_bitmap_mask, x_allocate_bitmap_record)
4595 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4596 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4597 (x_create_bitmap_from_xpm_data):
4598 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4599 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4601 * xfaces.c (load_pixmap):
4602 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4603 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4604 (.bitmaps_last, struct x_output.icon_bitmap):
4605 Use ptrdiff_t, not int, for bitmap indexes.
4606 (x_allocate_bitmap_record): Check for size overflow.
4607 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4609 Use ptrdiff_t, not int, for overlay counts.
4610 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4611 * editfns.c (overlays_around, get_pos_property):
4612 * textprop.c (get_char_property_and_overlay):
4613 * xdisp.c (next_overlay_change, note_mouse_highlight):
4614 * xfaces.c (face_at_buffer_position):
4615 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4616 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4617 (Fnext_overlay_change, Fprevious_overlay_change)
4618 (mouse_face_overlay_overlaps, Foverlays_in):
4619 Use ptrdiff_t, not int, for sizes.
4620 (overlays_at, overlays_in): Check for size-calculation overflow.
4622 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4624 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4625 (x_session_initialize): Do not assume string length fits in int.
4627 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4628 This is unlikely, but can occur if DPI is outlandish.
4630 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4631 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4633 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4634 * xrdb.c (magic_file_p, search_magic_path):
4635 Omit last arg SUFFIX; it was always 0. All callers changed.
4636 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4638 * xfont.c (xfont_match): Avoid need for strlen.
4640 * xfns.c: Don't assume strlen fits in int.
4641 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4643 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4644 not unsigned long, as we prefer signed integers. All callers changed.
4645 Detect integer overflow in repeat count.
4646 (message_dolog): Don't assume print length fits in 39 bytes.
4647 (display_mode_element): Don't assume strlen fits in int.
4649 * termcap.c: Don't assume sizes fit in int and never overflow.
4650 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4651 (gobble_line): Check for size-calculation overflow.
4653 * minibuf.c (Fread_buffer):
4654 * lread.c (intern, intern_c_string):
4655 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4656 Don't assume string length fits in int.
4658 * keyboard.c (parse_tool_bar_item):
4659 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4661 * font.c: Don't assume string length fits in int.
4662 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4663 Use ptrdiff_t, not int.
4664 (font_intern_prop): Don't assume string length fits in int.
4665 Don't assume integer property fits in fixnum.
4666 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4668 * filelock.c: Fix some buffer overrun and integer overflow issues.
4669 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4670 Reformulate so as not to need the command string.
4671 Invoke gzip -cd rather than gunzip, as it's more portable.
4672 (lock_info_type, lock_file_1, lock_file):
4673 Don't assume pid_t and time_t fit in unsigned long.
4674 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4675 (current_lock_owner): Prefer signed type for sizes.
4676 Use memcpy, not strncpy, where memcpy is what is really wanted.
4677 Don't assume (via atoi) that time_t and pid_t fit in int.
4678 Check for time_t and/or pid_t out of range, e.g., via a network share.
4679 Don't alloca where an auto var works fine.
4681 * fileio.c: Fix some integer overflow issues.
4682 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4683 Don't assume string length fits in int.
4684 (directory_file_name): Don't assume string length fits in long.
4685 (make_temp_name): Don't assume pid fits in int, or that its print
4686 length is less than 20.
4688 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4690 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4692 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4694 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4695 We prefer signed integers, even for size calculations.
4697 * emacs.c: Don't assume string length fits in 'int'.
4698 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4699 (main): Don't invoke strlen when not needed.
4701 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4702 (XD_DEBUG_MESSAGE): Don't waste a byte.
4704 * callproc.c (getenv_internal_1, getenv_internal)
4706 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4708 * lread.c (invalid_syntax): Omit length argument.
4709 All uses changed. This doesn't fix a bug, but it simplifies the
4710 code away from its former Hollerith-constant appearance, and it's
4711 one less 'int' to worry about when looking at integer-overflow issues.
4712 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4714 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4715 This didn't break anything, but it didn't help either.
4716 It's confusing to put a bogus integer in a place where the actual
4717 value does not matter.
4718 (LIST_END_P): Remove unused macro and its bogus comment.
4719 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4721 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4722 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4724 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4725 We prefer signed types, and the value cannot exceed the EMACS_INT
4726 range anyway (because otherwise the length would not be representable).
4727 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4728 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4729 This avoids a GCC warning when WIDE_EMACS_INT.
4731 * indent.c (sane_tab_width): New function.
4732 (current_column, scan_for_column, Findent_to, position_indentation)
4733 (compute_motion): Use it. This is just for clarity.
4734 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4736 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4738 * lisp.h (lint_assume): New macro.
4739 * composite.c (composition_gstring_put_cache):
4740 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4742 * editfns.c, insdel.c:
4743 Omit unnecessary forward decls, to simplify future changes.
4745 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4747 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4749 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4750 Use much-faster test for byte-length change.
4751 Don't assume string byte-length fits in 'int'.
4752 Check that character arg fits in 'int'.
4753 (mapcar1): Declare byte as byte, for clarity.
4755 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4757 * fns.c (concat): Catch string overflow earlier.
4758 Do not rely on integer wraparound.
4760 * dispextern.h (struct it.overlay_strings_charpos)
4761 (struct it.selective): Now EMACS_INT, not int.
4762 * xdisp.c (forward_to_next_line_start)
4763 (back_to_previous_visible_line_start)
4764 (reseat_at_next_visible_line_start, next_element_from_buffer):
4765 Don't arbitrarily truncate the value of 'selective' to int.
4767 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4769 * composite.c: Don't truncate sizes to 'int'.
4770 (composition_gstring_p, composition_reseat_it)
4771 (composition_adjust_point): Use EMACS_INT, not int.
4772 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4773 not EMACS_UINT, for indexes.
4775 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4777 * buffer.c: Include <verify.h>.
4778 (struct sortvec.priority, struct sortstr.priority):
4779 Now EMACS_INT, not int.
4780 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4781 (struct sortstr.size, record_overlay_string)
4782 (struct sortstrlist.size, struct sortlist.used):
4783 Don't truncate size to int.
4784 (record_overlay_string): Check for size-calculation overflow.
4785 (init_buffer_once): Check at compile-time, not run-time.
4787 2011-06-22 Jim Meyering <meyering@redhat.com>
4789 Don't leak an XBM-image-sized buffer
4790 * image.c (xbm_load): Free the image buffer after using it.
4792 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4795 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4796 that Sun C diagnosed.
4797 * fns.c (secure_hash): Fix pointer signedness issue.
4798 * intervals.c (static_offset_intervals): New function.
4799 (offset_intervals): Use it.
4801 2011-06-21 Leo Liu <sdl.web@gmail.com>
4804 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4807 * fns.c (secure_hash): Rename from crypto_hash_function and change
4808 the first arg to accept symbols.
4809 (Fsecure_hash): New primitive.
4810 (syms_of_fns): New symbols.
4812 2011-06-20 Deniz Dogan <deniz@dogan.se>
4814 * process.c (Fset_process_buffer): Clarify return value in
4817 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4819 * dispnew.c (add_window_display_history): Use BVAR.
4821 * xdisp.c (debug_method_add): Use BVAR.
4822 (check_window_end, dump_glyph_matrix, dump_glyph)
4823 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4825 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4828 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4829 check till after the cache is created in init_frame_faces.
4831 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4833 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4835 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4837 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4838 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4839 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4841 Improve buffer-overflow checking (Bug#8873).
4842 * fileio.c (Finsert_file_contents):
4843 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4844 Remove the old (too-loose) buffer overflow checks.
4845 They weren't needed, since make_gap checks for buffer overflow.
4846 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4847 The old code merely checked for Emacs fixnum overflow, and relied
4848 on undefined (wraparound) behavior. The new code avoids undefined
4849 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4851 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4852 Tune. Don't use wider integers than needed. Don't use alloca.
4853 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4855 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4857 * insdel.c, lisp.h (buffer_overflow): New function.
4858 (insert_from_buffer_1, replace_range, replace_range_2):
4859 * insdel.c (make_gap_larger):
4860 * editfns.c (Finsert_char):
4861 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4863 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4865 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4867 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4869 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4870 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4872 * fileio.c: Don't assume EMACS_INT fits in off_t.
4873 (emacs_lseek): New static function.
4874 (Finsert_file_contents, Fwrite_region): Use it.
4875 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4877 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4879 * fns.c: Don't overflow int when computing a list length.
4880 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4881 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4882 truncation on 64-bit hosts. Check for QUIT every
4883 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4884 faster and is responsive enough.
4885 (Flength): Report an error instead of overflowing an integer.
4886 (Fsafe_length): Return a float if the value is not representable
4887 as a fixnum. This shouldn't happen except in contrived situations.
4888 (Fnthcdr, Fsort): Don't assume list length fits in int.
4889 (Fcopy_sequence): Don't assume vector length fits in int.
4891 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4892 (header_size, word_size): New constants.
4893 (allocate_vectorlike): Don't check size overflow here.
4894 (allocate_vector): Check it here instead, since this is the only
4895 caller of allocate_vectorlike that could cause overflow.
4896 Check that the new vector's length is representable as a fixnum.
4898 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4899 The previous code was bogus. For example, next_almost_prime (32)
4900 returned 39, which is undesirable as it is a multiple of 3; and
4901 next_almost_prime (24) returned 25, which is a multiple of 5 so
4902 why was the code bothering to check for multiples of 7?
4904 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4906 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4908 Variadic C functions now count arguments with ptrdiff_t.
4909 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4910 Back then I didn't know that the Emacs coding style prefers signed int.
4911 Also, in the meantime I found a few more instances where arguments
4912 were being counted with int, which may truncate counts on 64-bit
4913 machines, or EMACS_INT, which may be unnecessarily wide.
4914 * lisp.h (struct Lisp_Subr.function.aMANY)
4915 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4916 Arg counts are now ptrdiff_t, not size_t.
4917 All variadic functions and their callers changed accordingly.
4918 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4919 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4920 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4921 * callint.c (Fcall_interactively): Check arg count for overflow,
4922 to avoid potential buffer overrun. Use signed char, not 'int',
4923 for 'varies' array, so that we needn't bother to check its size
4924 calculation for overflow.
4925 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4926 * eval.c (apply_lambda):
4927 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4928 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4929 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4931 * callint.c (Fcall_interactively): Don't use index var as event count.
4933 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4934 * mem-limits.h (SIZE): Remove; no longer used.
4936 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4938 Remove unnecessary casts.
4939 * xterm.c (x_term_init):
4940 * xfns.c (x_set_border_pixel):
4941 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4942 These aren't needed now that we assume ANSI C.
4944 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4945 It's more likely to cause problems (due to unsigned overflow)
4948 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4950 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4952 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4954 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4956 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4958 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4960 GLYPH_CODE_FACE returns EMACS_INT, not int.
4961 * dispextern.h (merge_faces):
4962 * xfaces.c (merge_faces):
4963 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4964 Don't assume EMACS_INT fits in int.
4966 * character.h (CHAR_VALID_P): Remove unused parameter.
4967 * fontset.c, lisp.h, xdisp.c: All uses changed.
4969 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4971 * fns.c (concat): Minor tuning based on overflow analysis.
4972 This doesn't fix any bugs. Use int to hold character, instead
4973 of constantly refetching from Emacs object. Use XFASTINT, not
4974 XINT, for value known to be a character. Don't bother comparing
4975 a single byte to 0400, as it's always less.
4977 * floatfns.c (Fexpt):
4978 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4980 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4983 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4985 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4986 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4987 incorrectly succeed when S was a string, because 4294967386 was
4988 truncated before it was used.
4990 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4991 Otherwise, an out-of-range integer could cause undefined behavior
4994 * composite.c: Use int, not EMACS_INT, for characters.
4995 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4996 EMACS_INT, for values that are known to be in character range.
4997 This doesn't fix any bugs but is the usual style inside Emacs and
4998 may generate better code on 32-bit machines.
5000 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5001 This is for reasons similar to the recent CHAR_STRING fix.
5002 * charset.c (Fencode_char): Check that character arg is actually
5003 a character. Pass an int to ENCODE_CHAR.
5004 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5005 wider than 'int', as a compile-time check to prevent future regressions
5008 * character.c (char_string): Remove unnecessary casts.
5010 Make sure a 64-bit char is never passed to CHAR_STRING.
5011 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5012 by silently ignoring the top 32 bits, allowing some values
5013 that were far too large to be valid characters.
5014 * character.h: Include <verify.h>.
5015 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5016 arguments are no wider than unsigned, as a compile-time check
5017 to prevent future regressions in this area.
5019 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5020 (Fsubst_char_in_region):
5022 * xdisp.c (decode_mode_spec_coding):
5023 Adjust to CHAR_STRING's new requirement.
5024 * editfns.c (Finsert_char, Fsubst_char_in_region):
5025 * fns.c (concat): Check that character args are actually
5026 characters. Without this test, these functions did the wrong
5027 thing with wildly out-of-range values on 64-bit hosts.
5029 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5030 These casts should not be needed on 32-bit hosts, either.
5031 * keyboard.c (read_char):
5032 * lread.c (Fload): Remove casts to unsigned.
5034 * lisp.h (UNSIGNED_CMP): New macro.
5035 This fixes comparison bugs on 64-bit hosts.
5036 (ASCII_CHAR_P): Use it.
5037 * casefiddle.c (casify_object):
5038 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5039 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5040 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5041 * dispextern.h (FACE_FROM_ID):
5042 * keyboard.c (read_char): Use UNSIGNED_CMP.
5044 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5045 not to EMACS_INT, to avoid GCC warning.
5047 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5049 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5050 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5051 isn't needed on 32-bit machines.
5053 * buffer.c (Fgenerate_new_buffer_name):
5054 Use EMACS_INT for count, not int.
5055 (advance_to_char_boundary): Return EMACS_INT, not int.
5057 * data.c (Qcompiled_function): Now static.
5059 * window.c (window_body_lines): Now static.
5061 * image.c (gif_load): Rename local to avoid shadowing.
5063 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5064 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5065 * alloc.c (make_save_value): Integer argument is now of type
5067 (mark_object): Use ptrdiff_t, not int.
5068 * lisp.h (pD): New macro.
5069 * print.c (print_object): Use it.
5071 * alloc.c: Use EMACS_INT, not int, to count objects.
5072 (total_conses, total_markers, total_symbols, total_vector_size)
5073 (total_free_conses, total_free_markers, total_free_symbols)
5074 (total_free_floats, total_floats, total_free_intervals)
5075 (total_intervals, total_strings, total_free_strings):
5076 Now EMACS_INT, not int. All uses changed.
5077 (Fgarbage_collect): Compute overall total using a double, so that
5078 integer overflow is less likely to be a problem. Check for overflow
5079 when converting back to an integer.
5080 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5081 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5082 These were 'int' variables that could overflow on 64-bit hosts;
5083 they were never used, so remove them instead of repairing them.
5084 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5085 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5086 Previously, this ceilinged at INT_MAX, but that doesn't work on
5088 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5090 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5091 (allocate_vectorlike): Check for ptrdiff_t overflow.
5092 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5093 when a (possibly-narrower) signed value would do just as well.
5094 We prefer using signed arithmetic, to avoid comparison confusion.
5096 * alloc.c: Catch some string size overflows that we were missing.
5097 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5098 for convenience in STRING_BYTES_MAX.
5099 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5100 The definition here is exact; the one in lisp.h was approximate.
5101 (allocate_string_data): Check for string overflow. This catches
5102 some instances we weren't catching before. Also, it catches
5103 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5104 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5105 and ptrdiff_t and EMACS_INT are both 64 bits.
5107 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5108 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5109 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5111 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5113 * alloc.c (Fmake_string): Check for out-of-range init.
5115 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5117 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5119 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5121 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5122 xg_get_default_scrollbar_width.
5124 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5125 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5126 (style_changed_cb): Call update_theme_scrollbar_width and call
5127 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5128 all frames (Bug#8505).
5129 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5130 Call gtk_window_set_resizable if HAVE_GTK3.
5131 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5132 and height if HAVE_GTK3 (Bug#8505).
5133 (scroll_bar_width_for_theme): New variable.
5134 (update_theme_scrollbar_width): New function.
5135 (xg_get_default_scrollbar_width): Move code to
5136 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5137 (xg_initialize): Call update_theme_scrollbar_width.
5139 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5141 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5143 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5145 * frame.c (make_frame): Call other_buffer_safely instead of
5148 * window.c (temp_output_buffer_show): Call display_buffer with
5149 second argument Vtemp_buffer_show_specifiers and reset latter
5150 immediately after the call.
5151 (Vtemp_buffer_show_specifiers): New variable.
5152 (auto_window_vscroll_p, next_screen_context_lines)
5153 (Vscroll_preserve_screen_position): Remove leading asterisks from
5156 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5158 Fix minor problems found by GCC 4.6.0 static checking.
5159 * buffer.c (Qclone_number): Remove for now, as it's unused.
5160 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5161 (record_buffer): Remove unused local.
5162 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5163 (set_frame_buffer_list): Remove; unused.
5164 * frame.h (other_visible_frames): Remove decl.
5165 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5166 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5167 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5169 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5170 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5171 Define only if HAVE_GPM.
5172 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5173 (update_hints_inhibit): Remove; never set. All uses removed.
5174 * widgetprv.h (emacsFrameClassRec): Remove decl.
5175 * window.c (delete_deletable_window): Now returns void, since it
5176 wasn't returning anything.
5177 (compare_window_configurations): Remove unused locals.
5178 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5179 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5180 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5181 the same widths as pointers. This follows up on the 2011-05-06 patch.
5182 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5183 * xterm.h: Likewise.
5184 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5186 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5188 * makefile.w32-in: Update dependencies.
5189 (LISP_H): Add lib/intprops.h.
5191 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5193 * image.c (gif_load): Add animation frame delay to the metadata.
5194 (syms_of_image): Use DEFSYM. New symbol `delay'.
5196 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5198 * window.c (delete_deletable_window): Re-add.
5199 (Fset_window_configuration): Rewrite to handle dead buffers and
5200 consequently deletable windows.
5201 (window_tree, Fwindow_tree): Remove. Supply functionality in
5203 (compare_window_configurations): Simplify code.
5205 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5207 * image.c (imagemagick_load_image): Fix type mismatch.
5208 (Fimagemagick_types): Likewise.
5210 * window.h (replace_buffer_in_windows): Declare.
5212 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5214 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5215 Qclone_number. Remove external declaration of Qdelete_window.
5216 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5218 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5219 Run Qbuffer_list_update_hook if allowed.
5220 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5221 buffer list implementation.
5222 (other_buffer_safely): New function.
5223 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5224 calls to replace_buffer_in_windows and
5225 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5227 (record_buffer): Inhibit quitting and rewrite using quittable
5228 functions. Run Qbuffer_list_update_hook if allowed.
5229 (Frecord_buffer, Funrecord_buffer): New functions.
5230 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5231 Move switch-to-buffer to window.el.
5232 (bury-buffer): Move to window.el.
5233 (Vbuffer_list_update_hook): New variable.
5235 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5238 * window.h (resize_frame_windows): Move up in code.
5239 (Fwindow_frame): Remove EXFUN.
5240 (replace_buffer_in_all_windows): Remove prototype.
5241 (replace_buffer_in_windows_safely): Add prototype.
5243 * window.c: Declare Qdelete_window static again. Move down
5244 declaration of select_count.
5245 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5246 (Fother_window): Move to window.el.
5247 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5248 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5249 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5251 (replace_buffer_in_windows): Implement by calling
5252 Qreplace_buffer_in_windows.
5253 (replace_buffer_in_all_windows): Remove with some functionality
5254 moved into replace_buffer_in_windows_safely.
5255 (replace_buffer_in_windows_safely): New function.
5256 (select_window_norecord, select_frame_norecord): Move in front
5257 of run_window_configuration_change_hook. Remove now obsolete
5259 (Fset_window_buffer): Rewrite doc-string.
5260 Call Qrecord_window_buffer.
5261 (keys_of_window): Move binding for other-window to window.el.
5263 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5265 * dispextern.h (struct image): Replace data member, whose int_val
5266 and ptr_val fields were not used by anything, with a single
5269 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5270 (gif_clear_image, gif_load, imagemagick_load_image)
5271 (gs_clear_image, gs_load): Callers changed.
5273 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5275 * buffer.h: Include <time.h>, for time_t.
5276 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5278 Fix minor problems found by static checking.
5280 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5282 Make identifiers static if they are not used in other modules.
5283 * data.c (Qcompiled_function, Qframe, Qvector):
5284 * image.c (QimageMagick, Qsvg):
5285 * minibuf.c (Qmetadata):
5286 * window.c (resize_window_check, resize_root_window): Now static.
5287 * window.h (resize_window_check, resize_root_window): Remove decls.
5289 * window.c (window_deletion_count, delete_deletable_window):
5291 (window_body_lines): Now static.
5292 (Fdelete_other_windows_internal): Mark vars as initialized.
5293 Make sure 'resize_failed' is initialized.
5294 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5295 (resize_window_apply): Remove unused local.
5296 * window.h (delete_deletable_window): Remove decl.
5298 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5299 (imagemagick_load_image): Fix pointer signedness problem by changing
5300 last arg from unsigned char * to char *. All uses changed.
5301 Also, fix a local for similar reasons.
5302 Remove unused locals. Remove locals to avoid shadowing.
5303 (fn_rsvg_handle_free): Remove; unused.
5304 (svg_load, svg_load_image): Fix pointer signedness problem.
5305 (imagemagick_load_image): Don't use garbage pointer image_wand.
5307 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5309 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5311 * image.c (gif_load): Fix omitted cast error introduced by
5314 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5316 * window.h (resize_proportionally, orig_total_lines)
5317 (orig_top_line): Remove from window structure.
5318 (set_window_height, set_window_width, change_window_heights)
5319 (Fdelete_window): Remove prototypes.
5320 (resize_frame_windows): Remove duplicate declaration.
5322 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5324 * window.h (resize_frame_windows, resize_window_check)
5325 (delete_deletable_window, resize_root_window)
5326 (resize_frame_windows): Declare prototypes.
5328 * window.c (resize_window_apply): Make definition be "static" to
5329 match the prototype.
5331 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5333 * window.c: Remove declarations of Qwindow_size_fixed,
5334 window_min_size_1, window_min_size_2, window_min_size,
5335 size_window, window_fixed_size_p, enlarge_window, delete_window.
5336 Remove static from declaration of Qdelete_window, it's
5337 temporarily needed by Fbury_buffer.
5338 (replace_window): Don't assign orig_top_line and
5340 (Fdelete_window, delete_window): Remove. Window deletion is
5341 handled by window.el.
5342 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5343 Replace Fdelete_window calls with calls to Qdelete_window.
5344 (Fdelete_other_windows): Remove. Deleting other windows is
5345 handled by window.el.
5346 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5347 handled in window.el.
5348 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5349 Window minimum sizes are handled in window.el.
5350 (shrink_windows, size_window, set_window_height)
5351 (set_window_width, change_window_heights, window_height)
5352 (window_width, CURBEG, CURSIZE, enlarge_window)
5353 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5354 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5355 handled in window.el.
5356 (make_dummy_parent): Rename to make_parent_window and give it a
5357 second argument horflag.
5358 (make_window): Don't set resize_proportionally any more.
5359 (Fsplit_window): Remove. Windows are split in window.el.
5360 (save_restore_action, save_restore_orig_size)
5361 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5362 Resize mini windows in window.el.
5363 (grow_mini_window, shrink_mini_window): Implement by calling
5364 Qresize_root_window_vertically, resize_window_check and
5365 resize_window_apply.
5366 (saved_window, Fset_window_configuration, save_window_save):
5367 Do not handle orig_top_line, orig_total_lines, and
5368 resize_proportionally.
5369 (window_min_height, window_min_width): Move to window.el.
5370 (keys_of_window): Move bindings for delete-other-windows,
5371 split-window, delete-window and enlarge-window to window.el.
5373 * buffer.c: Temporarily extern Qdelete_window.
5374 (Fbury_buffer): Temporarily call Qdelete_window instead of
5375 Fdelete_window (Fbury_buffer will move to window.el soon).
5377 * frame.c (set_menu_bar_lines_1): Remove code handling
5378 orig_top_line and orig_total_lines.
5380 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5381 set_window_height but set heights directly.
5382 (change_frame_size_1): Use resize_frame_windows.
5384 * xdisp.c (init_xdisp): Don't use set_window_height but set
5387 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5388 Use resize_frame_windows instead of change_window_heights and run
5389 run_window_configuration_change_hook.
5391 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5392 instead of change_window_heights and run
5393 run_window_configuration_change_hook.
5395 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5397 * window.c (replace_window): Rename second argument REPLACEMENT to
5398 NEW. New third argument SETFLAG. Rewrite.
5399 (delete_window, make_dummy_parent): Call replace_window with
5401 (window_list_1): Move down in code.
5402 (run_window_configuration_change_hook): Move set_buffer part
5403 before select_frame_norecord part in order to unwind correctly.
5404 Rename count1 to count.
5405 (recombine_windows, delete_deletable_window, resize_root_window)
5406 (Fdelete_other_windows_internal)
5407 (Frun_window_configuration_change_hook, make_parent_window)
5408 (resize_window_check, resize_window_apply, Fresize_window_apply)
5409 (resize_frame_windows, Fsplit_window_internal)
5410 (Fdelete_window_internal, Fresize_mini_window_internal):
5412 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5414 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5416 * window.h (window): Add some new members to window structure -
5417 normal_lines, normal_cols, new_total, new_normal, clone_number,
5418 splits, nest, prev_buffers, next_buffers.
5419 (WINDOW_TOTAL_SIZE): Move here from window.c.
5420 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5422 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5424 (make_dummy_parent): Set new members of windows structure.
5425 (make_window): Move down in code. Handle new members of window
5427 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5428 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5429 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5430 (Fset_window_prev_buffers, Fwindow_next_buffers)
5431 (Fset_window_next_buffers, Fset_window_clone_number):
5433 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5434 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5436 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5437 Argument WINDOW can be now internal window too.
5438 (Fwindow_use_time): Move up in code.
5439 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5441 (Fset_window_configuration, saved_window)
5442 (Fcurrent_window_configuration, save_window_save): Handle new
5443 members of window structure.
5444 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5445 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5446 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5447 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5448 Qget_mru_window, Qresize_root_window,
5449 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5450 Qauto_buffer_name; staticpro them.
5452 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5454 * window.c (Fwindow_total_size, Fwindow_left_column)
5455 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5456 (Fwindow_list_1): New functions.
5457 (window_box_text_cols): Replace with window_body_cols.
5458 (Fwindow_width, Fscroll_left, Fscroll_right):
5459 Use window_body_cols instead of window_box_text_cols.
5460 (delete_window, Fset_window_configuration):
5461 Call delete_all_subwindows with window as argument.
5462 (delete_all_subwindows): Take a window as argument and not a
5464 (window_loop): Remove handling of GET_LRU_WINDOW and
5466 (Fget_lru_window, Fget_largest_window): Move to window.el.
5468 * window.h: Extern window_body_cols instead of
5469 window_box_text_cols. delete_all_subwindows now takes a
5470 Lisp_Object as argument.
5472 * indent.c (compute_motion, Fcompute_motion):
5473 Use window_body_cols instead of window_box_text_cols.
5475 * frame.c (delete_frame): Call delete_all_subwindows with root
5478 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5480 * fns.c (Fputhash): Document return value.
5482 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5484 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5486 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5488 Cons<->int and similar integer overflow fixes (Bug#8794).
5490 Check for overflow when converting integer to cons and back.
5491 * charset.c (Fdefine_charset_internal, Fdecode_char):
5492 Use cons_to_unsigned to catch overflow.
5493 (Fencode_char): Use INTEGER_TO_CONS.
5494 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5495 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5496 * data.c (long_to_cons, cons_to_long): Remove.
5497 (cons_to_unsigned, cons_to_signed): New functions.
5498 These signal an error for invalid or out-of-range values.
5499 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5500 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5501 * font.c (Ffont_variation_glyphs):
5502 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5503 * lisp.h: Include <intprops.h>.
5504 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5505 (cons_to_signed, cons_to_unsigned): New decls.
5506 (long_to_cons, cons_to_long): Remove decls.
5507 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5508 (Fprimitive_undo): Use CONS_TO_INTEGER.
5509 * xfns.c (Fx_window_property): Likewise.
5510 * xselect.c: Include <limits.h>.
5511 (x_own_selection, selection_data_to_lisp_data):
5512 Use INTEGER_TO_CONS.
5513 (x_handle_selection_request, x_handle_selection_clear)
5514 (x_get_foreign_selection, Fx_disown_selection_internal)
5515 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5516 (lisp_data_to_selection_data): Use cons_to_unsigned.
5517 (x_fill_property_data): Use cons_to_signed.
5518 Report values out of range.
5520 Check for buffer and string overflow more precisely.
5521 * buffer.h (BUF_BYTES_MAX): New macro.
5522 * lisp.h (STRING_BYTES_MAX): New macro.
5523 * alloc.c (Fmake_string):
5524 * character.c (string_escape_byte8):
5525 * coding.c (coding_alloc_by_realloc):
5526 * doprnt.c (doprnt):
5527 * editfns.c (Fformat):
5529 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5530 since they may not be the same number.
5531 * editfns.c (Finsert_char):
5532 * fileio.c (Finsert_file_contents):
5533 Likewise for BUF_BYTES_MAX.
5535 * image.c: Use ptrdiff_t, not int, for sizes.
5536 (slurp_file): Switch from int to ptrdiff_t.
5538 (slurp_file): Check that file size fits in both size_t (for
5539 malloc) and ptrdiff_t (for sanity and safety).
5541 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5542 if b->modtime has its maximal value.
5544 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5546 Don't assume time_t can fit into int.
5547 * buffer.h (struct buffer.modtime): Now time_t, not int.
5548 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5549 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5551 Minor fixes for signed vs unsigned integers.
5552 * character.h (MAYBE_UNIFY_CHAR):
5553 * charset.c (maybe_unify_char):
5554 * keyboard.c (read_char, reorder_modifiers):
5555 XINT -> XFASTINT, since the integer must be nonnegative.
5556 * ftfont.c (ftfont_spec_pattern):
5557 * keymap.c (access_keymap, silly_event_symbol_error):
5558 XUINT -> XFASTINT, since the integer must be nonnegative.
5559 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5560 since it makes no difference and we prefer signed.
5561 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5562 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5565 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5567 * window.h (Fwindow_frame): Declare.
5569 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5571 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5572 (SPARE_MEMORY): Always define.
5573 (LARGE_REQUEST): Remove.
5574 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5576 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5578 * lisp.h: Move EXFUNS for Fframe_root_window,
5579 Fframe_first_window and Fset_frame_selected_window to window.h.
5581 * window.h: Move EXFUNS for Fframe_root_window,
5582 Fframe_first_window and Fset_frame_selected_window here from
5585 * frame.c (Fwindow_frame, Fframe_first_window)
5586 (Fframe_root_window, Fframe_selected_window)
5587 (Fset_frame_selected_window): Move to window.c.
5588 (Factive_minibuffer_window): Move to minibuf.c.
5589 (Fother_visible_frames_p): New function.
5591 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5593 * window.c (decode_window, decode_any_window): Move up in code.
5594 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5595 (inhibit_frame_unsplittable): Remove unused variable.
5596 (Fwindow_buffer): Move up and rewrite doc-string.
5597 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5598 (Fwindow_prev): New functions.
5599 (Fwindow_frame): Move here from frame.c. Accept any window as
5601 (Fframe_root_window, Fframe_first_window)
5602 (Fframe_selected_window): Move here from frame.c. Accept frame
5603 or arbitrary window as argument. Update doc-strings.
5604 (Fminibuffer_window): Move up in code.
5605 (Fwindow_minibuffer_p): Move up in code and simplify.
5606 (Fset_frame_selected_window): Move here from frame.c.
5608 (Fselected_window, select_window, Fselect_window): Move up in
5609 code. Minor doc-string fixes.
5611 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5613 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5614 Do not assume that spare memory exists; that assumption is valid
5615 only if SYSTEM_MALLOC.
5616 (LARGE_REQUEST): New macro, so that the issue of large requests
5617 is separated from the issue of spare memory.
5619 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5621 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5624 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5626 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5629 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5631 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5633 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5635 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5636 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5638 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5640 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5642 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5644 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5645 (x_clipboard_manager_save): Add return value.
5646 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5648 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5649 Obey Vx_select_enable_clipboard_manager. Catch errors in
5650 x_clipboard_manager_save (Bug#8779).
5651 (Vx_select_enable_clipboard_manager): New variable.
5652 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5654 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5656 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5658 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5660 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5661 in the current matrix if keep_current_p is non-zero.
5663 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5665 * bidi.c (bidi_level_of_next_char): Fix last change.
5667 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5669 Support bidi reordering of text covered by display properties.
5671 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5672 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5673 (bidi_cache_search, bidi_cache_iterator_state)
5674 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5675 (bidi_level_of_next_char, bidi_move_to_visually_next):
5676 Support character positions inside a run of characters covered by a
5678 (bidi_paragraph_init, bidi_resolve_explicit_1)
5679 (bidi_level_of_next_char): Call bidi_fetch_char and
5680 bidi_fetch_char_advance instead of FETCH_CHAR and
5682 (bidi_init_it): Initialize new members.
5683 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5685 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5686 instead of using explicit *_CHAR codes.
5687 (bidi_resolve_explicit, bidi_resolve_weak):
5688 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5689 bidirectional text is supported only in multibyte buffers.
5690 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5691 it to initialize the frame_window_p member of struct bidi_it.
5692 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5693 (bidi_resolve_explicit, bidi_resolve_weak)
5694 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5695 bidi_it->nchars is non-positive.
5696 (bidi_level_of_next_char): Don't try to lookup the cache for the
5697 next/previous character if nothing is cached there yet, or if we
5698 were just reseat()'ed to a new position.
5700 * xdisp.c (set_cursor_from_row): Set start and stop points
5701 according to the row's direction when priming the loop that looks
5702 for the glyph on which to display cursor.
5703 (single_display_spec_intangible_p): Function deleted.
5704 (display_prop_intangible_p): Reimplement to call
5705 handle_display_spec instead of single_display_spec_intangible_p.
5706 Accept 3 additional arguments needed by handle_display_spec.
5707 This fixes incorrect cursor motion across display property with complex
5708 values: lists, `(when COND...)' forms, etc.
5709 (single_display_spec_string_p): Support property values that are
5710 lists with the argument STRING its top-level element.
5711 (display_prop_string_p): Fix the condition for processing a
5712 property that is a list to be consistent with handle_display_spec.
5713 (handle_display_spec): New function, refactored from the
5714 last portion of handle_display_prop.
5715 (compute_display_string_pos): Accept additional argument
5716 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5717 value of a `display' property is a "replacing spec".
5718 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5719 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5720 the display property, but just return a value indicating whether
5721 the display property will replace the characters it covers.
5722 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5723 frame_window_p members of struct bidi_it.
5724 (compute_display_string_pos, compute_display_string_end):
5726 (push_it): Accept second argument POSITION, where pop_it should
5727 jump to continue iteration.
5728 (reseat_1): Initialize bidi_it.disp_pos.
5730 * keyboard.c (adjust_point_for_property): Adjust the call to
5731 display_prop_intangible_p to its new signature.
5733 * dispextern.h (struct bidi_it): New member frame_window_p.
5734 (bidi_init_it): Update prototypes.
5735 (display_prop_intangible_p): Update prototype.
5736 (compute_display_string_pos, compute_display_string_end):
5738 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5741 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5743 Malloc failure behavior now depends on size of allocation.
5744 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5745 * lisp.h: Change signatures accordingly.
5746 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5747 All callers changed. (Bug#8762)
5749 * gnutls.c: Use Emacs's memory allocators.
5750 Without this change, the gnutls library would invoke malloc etc.
5751 directly, which causes problems on non-SYNC_INPUT hosts, and which
5752 runs afoul of improving memory_full behavior. (Bug#8761)
5753 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5754 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5755 xfree instead of the default malloc, realloc, free.
5756 (Fgnutls_boot): No need to check for memory allocation failure,
5757 since xmalloc does that for us.
5759 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5760 * category.c (hash_get_category_set):
5761 * ccl.c (ccl_driver):
5762 * charset.c (Fdefine_charset_internal):
5763 * charset.h (struct charset.hash_index):
5764 * composite.c (get_composition_id, gstring_lookup_cache)
5765 (composition_gstring_put_cache):
5766 * composite.h (struct composition.hash_index):
5767 * dispextern.h (struct image.hash):
5768 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5769 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5770 (hashfn_equal, hashfn_user_defined, make_hash_table)
5771 (maybe_resize_hash_table, hash_lookup, hash_put)
5772 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5773 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5774 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5775 * image.c (make_image, search_image_cache, lookup_image)
5776 (xpm_put_color_table_h):
5777 * lisp.h (struct Lisp_Hash_Table):
5778 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5779 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5780 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5781 * alloc.c (allocate_vectorlike):
5782 Check for overflow in vector size calculations.
5783 * ccl.c (ccl_driver):
5784 Check for overflow when converting EMACS_INT to int.
5785 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5786 need to be updated by these changes.
5787 * fns.c (make_hash_table, maybe_resize_hash_table):
5788 Check for integer overflow with large hash tables.
5789 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5790 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5791 (SXHASH_REDUCE): New macro.
5792 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5793 Use it instead of discarding useful hash info with large hash values.
5794 (sxhash_float): New function.
5795 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5796 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5797 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5798 Rewrite to use FIXNUM_BITS, as this simplifies things.
5799 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5800 Adjust signatures to match updated version of code.
5801 (consing_since_gc): Now EMACS_INT, since a single hash table can
5802 use more than INT_MAX bytes.
5804 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5806 Make it possible to build with GCC-4.6+ -O2 -flto.
5808 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5810 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5812 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5813 Call minibuffer-inactive-mode.
5815 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5817 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5818 Update dependencies.
5820 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5822 * data.c (init_data): Remove code for UTS, this system is not
5825 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5827 Don't force ./temacs to start in terminal mode.
5829 * frame.c (make_initial_frame): Initialize faces in all cases, not
5830 only when CANNOT_DUMP is defined.
5831 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5833 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5835 * dispnew.c (add_window_display_history): Use const for the string
5836 pointer. Remove declaration, not needed.
5838 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5840 Use 'inline', not 'INLINE'.
5841 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5842 * alloc.c, fontset.c (INLINE): Remove.
5843 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5844 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5845 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5846 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5847 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5849 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5851 Make it possible to run ./temacs.
5853 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5854 syms_of_callproc does the same thing. Remove test for
5855 "initialized", do it in the caller.
5856 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5858 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5860 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5861 (read_minibuf): Use get_minibuffer.
5862 (syms_of_minibuf): Use DEFSYM.
5863 (Qmetadata): New var.
5864 * data.c (Qbuffer): Don't make it static.
5865 (syms_of_data): Use DEFSYM.
5867 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5869 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5870 (CCL_CODE_MIN): New macro.
5872 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5874 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5876 * eval.c (Qdebug): Now static.
5877 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5878 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5879 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5881 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5883 * image.c: Various fixes to ImageMagick code comments.
5884 (Fimagemagick_types): Doc fix.
5886 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5888 Minor fixes prompted by GCC 4.6.0 warnings.
5890 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5892 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5893 (x_clipboard_manager_save_all): Move extern decl to ...
5894 * xterm.h: ... here, so that it can be checked for consistency.
5896 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5898 * xselect.c (x_clipboard_manager_save_frame)
5899 (x_clipboard_manager_save_all): New functions.
5900 (Fx_clipboard_manager_save): Lisp function deleted.
5902 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5903 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5905 * xterm.h: Update prototype.
5907 2011-05-28 William Xu <william.xwl@gmail.com>
5909 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5912 2011-05-28 Jim Meyering <meyering@redhat.com>
5914 Avoid a sign-extension bug in crypto_hash_function.
5915 * fns.c (to_uchar): Define.
5916 (crypto_hash_function): Use it to convert some newly-signed
5917 variables to unsigned, to avoid sign-extension bugs. For example,
5918 without this change, (md5 "truc") would evaluate to
5919 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5920 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5921 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5923 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5925 Integer overflow fixes.
5927 * dbusbind.c: Serial number integer overflow fixes.
5928 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5929 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5930 to hold a serial number that is too large for a fixnum.
5931 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5932 Check for serial numbers out of range. Decode any serial number
5933 that was so large that it became a float. (Bug#8722)
5935 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5936 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5937 Use XFASTINT rather than XUINT when numbers are nonnegative.
5938 (xd_append_arg, Fdbus_method_return_internal):
5939 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5940 arguments, check that Lisp number is nonnegative, rather than
5941 silently wrapping negative numbers around. (Bug#8722)
5942 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5945 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5947 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5949 ccl: Add integer overflow checks.
5950 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5951 (IN_INT_RANGE): New macros.
5952 (ccl_driver): Use them to check for integer overflow when
5953 decoding a CCL program. Many of the new checks are whether XINT (x)
5954 fits in int; it doesn't always, on 64-bit hosts. The new version
5955 doesn't catch all possible integer overflows, but it's an
5956 improvement. (Bug#8719)
5958 * alloc.c (make_event_array): Use XINT, not XUINT.
5959 There's no need for unsigned here.
5961 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5962 This follows up to the 2011-05-06 change that substituted uintptr_t
5963 for EMACS_INT. This case wasn't caught back then.
5965 Rework Fformat to avoid integer overflow issues.
5966 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5967 now (part of C89). Include <verify.h>.
5968 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5969 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5970 (Fformat): Avoid the prepass trying to compute sizes; it was only
5971 approximate and thus did not catch overflow reliably. Instead, walk
5972 through the format just once, formatting and computing sizes as we go,
5973 checking for integer overflow at every step, and allocating a larger
5974 buffer as needed. Keep track separately whether the format is
5975 multibyte. Keep only the most-recently calculated precision, rather
5976 than them all. Record whether each argument has been converted to
5977 string. Use EMACS_INT, not int, for byte and char and arg counts.
5978 Support field widths and precisions larger than INT_MAX. Avoid
5979 sprintf's undefined behavior with conversion specifications such as %#d
5980 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5981 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5982 formatting out-of-range floating point numbers with int
5985 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5987 * data.c: Avoid integer truncation in expressions involving floats.
5988 * data.c: Include <intprops.h>.
5989 (arith_driver): When there's an integer overflow in an expression
5990 involving floating point, convert the integers to floating point
5991 so that the resulting value does not suffer from catastrophic
5992 integer truncation. For example, on a 64-bit host (* 4
5993 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5994 Do not rely on undefined behavior after integer overflow.
5996 merge count_size_as_multibyte, parse_str_to_multibyte
5997 * character.c, character.h (count_size_as_multibyte):
5998 Rename from parse_str_to_multibyte; all uses changed.
5999 Check for integer overflow.
6000 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6001 since it's now a duplicate of the other. This is more of
6002 a character than a buffer op, so better that it's in character.c.
6003 * fns.c, print.c: Adjust to above changes.
6005 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6007 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6009 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6011 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6012 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6013 (x_clipboard_manager_save): Now static.
6014 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6016 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6017 (crypto_hash_function): Now static.
6018 Fix pointer signedness problems. Avoid unnecessary initializations.
6020 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6022 * termhooks.h (Vselection_alist): Make it terminal-local.
6024 * terminal.c (create_terminal): Initialize it.
6026 * xselect.c: Support for clipboard managers.
6027 (Vselection_alist): Move to termhooks.h as terminal-local var.
6028 (LOCAL_SELECTION): New macro.
6029 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6030 (symbol_to_x_atom): Remove gratuitous arg.
6031 (x_handle_selection_request, lisp_data_to_selection_data)
6032 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6033 (x_own_selection, x_get_local_selection, x_convert_selection):
6034 New arg, specifying work frame. Use terminal-local Vselection_alist.
6035 (some_frame_on_display): Delete unused function.
6036 (Fx_own_selection_internal, Fx_get_selection_internal)
6037 (Fx_disown_selection_internal, Fx_selection_owner_p)
6038 (Fx_selection_exists_p): New optional frame arg.
6039 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6040 (x_handle_selection_clear): Don't treat other terminals with the
6041 same keyboard specially. Use the terminal-local Vselection_alist.
6042 (x_clear_frame_selections): Use Frun_hook_with_args.
6044 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6046 * xterm.h: Add support for those atoms.
6048 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6050 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6051 (converted_selections, conversion_fail_tag): New global variables.
6052 (x_selection_request_lisp_error): Free the above.
6053 (x_get_local_selection): Remove unnecessary code.
6054 (x_reply_selection_request): Args changed; handle arbitrary array
6055 of converted selections stored in converted_selections.
6056 Separate the XChangeProperty and SelectionNotify steps.
6057 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6058 (x_convert_selection): New function.
6059 (x_handle_selection_event): Simplify.
6060 (x_get_foreign_selection): Don't ignore incoming requests while
6061 waiting for an answer; this will fail when we implement
6062 SAVE_TARGETS, and seems unnecessary anyway.
6063 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6064 (Vx_sent_selection_functions): Doc fix.
6066 2011-05-26 Leo Liu <sdl.web@gmail.com>
6068 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6070 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6072 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6074 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6075 for fringe update if it has periodic bitmap.
6076 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6077 and fringe_bitmap_periodic_p.
6079 * fringe.c (get_fringe_bitmap_data): New function.
6080 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6081 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6082 row. Mark glyph row for fringe update if periodicity changed.
6084 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6085 for fringe update unless it has periodic bitmap.
6087 2011-05-25 Kenichi Handa <handa@m17n.org>
6089 * xdisp.c (get_next_display_element): Set correct it->face_id for
6090 a static composition.
6092 2011-05-24 Leo Liu <sdl.web@gmail.com>
6095 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6097 * fns.c (crypto_hash_function, Fsha1): New function.
6098 (Fmd5): Use crypto_hash_function.
6099 (syms_of_fns): Add Ssha1.
6101 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6103 * gnutls.c: Remove unused macros.
6104 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6105 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6106 Remove macros that are defined and never used.
6107 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6109 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6111 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6112 (Fx_get_selection_internal): Minor cleanup.
6113 (Fx_own_selection_internal): Rename arguments for consistency with
6116 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6118 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6120 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6122 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6124 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6126 * dispnew.c (scrolling_window): Don't exclude the case that the
6127 last enabled row in the desired matrix touches the bottom boundary.
6129 2011-05-21 Glenn Morris <rgm@gnu.org>
6131 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6132 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6133 and add some more files.
6135 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6137 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6138 report_file_error introduced by the change from 2011-05-07.
6140 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6142 * systime.h (Time): Define only if emacs is defined.
6143 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6144 where the include path doesn't have X11/X.h by default. See
6145 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6147 2011-05-20 Kenichi Handa <handa@m17n.org>
6149 * composite.c (find_automatic_composition): Fix previous change.
6151 2011-05-20 Glenn Morris <rgm@gnu.org>
6153 * lisp.mk: New file, split from Makefile.in.
6154 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6155 (shortlisp): Remove.
6156 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6158 2011-05-19 Glenn Morris <rgm@gnu.org>
6160 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6161 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6162 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6163 (lisp): Set the order to that of loadup.el.
6164 (shortlisp): Make it a copy of $lisp.
6165 (SOME_MACHINE_LISP): Remove.
6166 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6167 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6169 2011-05-18 Kenichi Handa <handa@m17n.org>
6171 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6172 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6173 (find_automatic_composition): Mostly rewrite for efficiency.
6175 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6177 * makefile.w32-in: Update dependencies.
6179 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6181 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6182 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6184 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6186 Fix some integer overflow issues, such as string length overflow.
6188 * insdel.c (count_size_as_multibyte): Check for string overflow.
6190 * character.c (lisp_string_width): Check for string overflow.
6191 Use EMACS_INT, not int, for string indexes and lengths; in
6192 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6193 the resulting string length overflows an EMACS_INT; instead,
6194 report a string overflow if no precision given. When checking for
6195 precision exhaustion, use a check that cannot possibly have
6196 integer overflow. (Bug#8675)
6197 * character.h (lisp_string_width): Adjust to new signature.
6199 * alloc.c (string_overflow): New function.
6200 (Fmake_string): Use it. This doesn't change behavior, but saves
6201 a few bytes and will simplify future changes.
6202 * character.c (string_escape_byte8): Likewise.
6203 * lisp.h (string_overflow): New decl.
6205 Fixups, following up to the user-interface timestamp change.
6206 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6207 for UI timestamps, instead of unsigned long.
6208 * msdos.c (mouse_get_pos): Likewise.
6209 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6210 * w32gui.h (Time): Define by including "systime.h" rather than by
6211 declaring it ourselves. (Bug#8664)
6213 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6214 * image.c (clear_image_cache): Likewise.
6216 * term.c (term_mouse_position): Don't assume time_t wraparound.
6218 Be more systematic about user-interface timestamps.
6219 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6220 and sometimes 'EMACS_UINT', to represent these timestamps.
6221 This change causes it to use 'Time' uniformly, as that's what X uses.
6222 This makes the code easier to follow, and makes it easier to catch
6223 integer overflow bugs such as Bug#8664.
6224 * frame.c (Fmouse_position, Fmouse_pixel_position):
6225 Use Time, not unsigned long, for user-interface timestamps.
6226 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6227 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6228 * keyboard.h (last_event_timestamp): Likewise.
6229 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6230 * menu.h (xmenu_show): Likewise.
6231 * term.c (term_mouse_position): Likewise.
6232 * termhooks.h (struct input_event.timestamp): Likewise.
6233 (struct terminal.mouse_position_hook): Likewise.
6234 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6235 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6236 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6237 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6239 * menu.h, termhooks.h: Include "systime.h", for Time.
6241 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6242 Don't assume that the difference between two unsigned long values
6243 can fit into an integer. At this point, we know button_down_time
6244 <= event->timestamp, so the difference must be nonnegative, so
6245 there's no need to cast the result if double-click-time is
6246 nonnegative, as it should be; check that it's nonnegative, just in
6247 case. This bug is triggered when events are more than 2**31 ms
6248 apart (about 25 days). (Bug#8664)
6250 * xselect.c (last_event_timestamp): Remove duplicate decl.
6251 (x_own_selection): Remove needless cast to unsigned long.
6253 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6254 that always fit in int. Use a sentinel instead of a counter, to
6255 avoid a temp and to allay GCC's concerns about possible int overflow.
6256 * frame.h (struct frame): Use int for menu_bar_items_used
6257 instead of EMACS_INT, since it always fits in int.
6259 * menu.c (grow_menu_items): Check for int overflow.
6261 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6263 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6264 Before, the code was not consistent. These values cannot exceed
6265 2**31 - 1 so there's no need to make them unsigned.
6266 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6267 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6268 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6270 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6272 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6273 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6274 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6275 presumably because the widths might not match.
6277 * window.c (size_window): Avoid needless test at loop start.
6279 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6281 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6283 2011-05-12 Drew Adams <drew.adams@oracle.com>
6285 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6287 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6289 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6290 `width' to `bar_area_x' and `bar_area_width', respectively.
6291 (x_scroll_run): Take account of fringe background extension.
6293 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6294 Rename local vars `left' and `width' to `bar_area_x' and
6295 `bar_area_width', respectively.
6296 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6297 background extension.
6299 2011-05-10 Jim Meyering <meyering@redhat.com>
6301 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6303 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6305 * image.c (Finit_image_library): Return t for built-in image types,
6306 like pbm and xbm. (Bug#8640)
6308 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6310 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6312 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6314 * w32console.c (Fset_screen_color): Doc fix.
6315 (Fget_screen_color): New function.
6316 (syms_of_ntterm): Defsubr it.
6318 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6319 unlink the temporary file if Fcall_process didn't create it in the
6321 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6322 child process will be redirected to a file specified with `:file'.
6323 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6324 cue to call_process_cleanup not to close that handle.
6326 2011-05-07 Ben Key <bkey76@gmail.com>
6328 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6329 one of two shell specific rules, either bootstrap-temacs-CMD or
6330 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6331 to the previous implementation of the bootstrap-temacs rule.
6332 The bootstrap-temacs-CMD rule is similar to the previous
6333 implementation of the bootstrap-temacs rule except that it
6334 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6337 These changes, along with some changes to nt/configure.bat,
6338 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6339 earlier fix to add support for --cflags and --ldflags options
6340 that include quotes so that it works whether make uses cmd or
6343 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6345 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6346 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6348 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6349 a string. Handle both cases.
6350 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6351 (Fdbus_register_method): Use Qinvalid_function.
6353 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6355 * makefile.w32-in: Update dependencies.
6356 (LISP_H): Add inttypes.h and stdin.h.
6357 (PROCESS_H): Add unistd.h.
6359 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6361 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6362 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6364 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6366 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6368 * term.c (vfatal): Remove stray call to va_end.
6369 It's not needed and the C Standard doesn't allow it here anyway.
6371 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6372 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6374 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6377 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6379 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6381 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6383 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6385 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6387 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6388 * charset.c (Fdefine_charset_internal): Don't initialize
6389 charset.code_space[15]. The value was garbage, on hosts with
6390 32-bit int (Bug#8600).
6392 * lread.c (read_integer): Be more consistent with string-to-number.
6393 Use string_to_number to do the actual conversion; this avoids
6394 rounding errors and fixes some other screwups. Without this fix,
6395 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6396 (digit_to_number): Move earlier, for benefit of read_integer.
6397 Return -1 if the digit is out of range for the base, -2 if it is
6398 not a digit in any supported base. (Bug#8602)
6400 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6402 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6403 to match comment at start of function. This also removes a
6404 GCC warning about overflow in a 32+64-bit port.
6406 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6408 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6409 Reported by Stefan Monnier in
6410 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6411 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6412 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6414 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6415 (EMACS_UINTPTR): Likewise, with uintptr_t.
6417 * lisp.h: Prefer 64-bit EMACS_INT if available.
6418 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6419 on 32-bit hosts that have 64-bit int, so that they can access
6421 However, temporarily disable this change unless the temporary
6422 symbol WIDE_EMACS_INT is defined.
6424 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6426 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6427 This removes an assumption that EMACS_INT and long are the same
6428 width as pointers. The assumption is true for Emacs porting targets
6429 now, but we want to make other targets possible.
6430 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6431 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6432 In the rest of the code, change types of integers that hold casted
6433 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6434 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6435 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6436 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6437 No need to cast type when ORing.
6438 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6439 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6440 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6441 assume EMACS_INT is the same width as char *.
6442 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6443 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6444 Remove no-longer-needed casts.
6445 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6446 (xg_tool_bar_help_callback, xg_make_tool_item):
6447 Use EMACS_INTPTR to hold an integer
6448 that will be cast to void *; this can avoid a GCC warning
6449 if EMACS_INT is not the same width as void *.
6450 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6451 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6452 (current_message_1, set_message_1):
6453 Use a local to convert to proper width without a cast.
6454 * xmenu.c (dialog_selection_callback): Likewise.
6456 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6457 Also, don't assume VALBITS / RAND_BITS is less than 5,
6458 and don't rely on undefined behavior when shifting a 1 left into
6460 * lisp.h (get_random): Change signature to match.
6462 * lread.c (hash_string): Use size_t, not int, for hash computation.
6463 Normally we prefer signed values; but hashing is special, because
6464 it's better to use unsigned division on hash table sizes so that
6465 the remainder is nonnegative. Also, size_t is the natural width
6466 for hashing into memory. The previous code used 'int', which doesn't
6467 retain enough info to hash well into very large tables.
6468 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6470 * dbusbind.c: Don't possibly lose pointer info when converting.
6471 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6472 Use XPNTR rather than XHASH, so that the high-order bits of
6473 the pointer aren't lost when converting through void *.
6475 * eval.c (Fautoload): Don't double-shift a pointer.
6477 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6479 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6481 * gnutls.c (DEF_GNUTLS_FN):
6482 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6484 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6486 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6489 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6491 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6492 New version that can reserve upto 2GB of heap space.
6494 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6496 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6498 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6500 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6501 `gnutls_certificate_set_x509_key_file'.
6503 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6505 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6506 Update dependencies.
6508 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6510 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6511 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6512 Remove unused parameter `fildes'.
6513 * process.c (read_process_output, send_process): Don't pass it.
6515 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6517 Fix previous change: the library cache is defined in w32.c.
6518 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6519 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6521 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6523 Implement dynamic loading of GnuTLS on Windows.
6525 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6526 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6527 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6530 * gnutls.c (Qgnutls_dll): Define.
6531 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6532 (gnutls_*): Declare function pointers.
6533 (init_gnutls_functions): New function to initialize function pointers.
6534 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6535 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6536 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6537 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6538 (emacs_gnutls_write, emacs_gnutls_read)
6539 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6540 (Fgnutls_available_p): New function.
6541 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6542 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6543 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6545 * image.c: Include w32.h.
6546 (Vimage_type_cache): Delete.
6547 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6548 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6549 (w32_delayed_load): Move to w32.c.
6551 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6553 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6554 (w32_delayed_load): Move from image.c. When loading a library, record
6555 its filename in the :loaded-from property of the library id.
6556 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6557 Initialize and staticpro them.
6558 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6560 * process.c: Include lisp.h before w32.h, not after.
6561 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6562 instead of gnutls_record_check_pending.
6564 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6566 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6568 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6569 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6572 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6574 * xterm.c (x_set_frame_alpha): Do not set property on anything
6575 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6577 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6579 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6581 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6583 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6584 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6585 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6586 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6587 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6588 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6589 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6590 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6591 (Qgnutls_bootprop_callbacks_verify): Make static.
6593 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6595 * callproc.c: Indentation fixup.
6597 * sysdep.c (wait_for_termination_1): Make static.
6598 (wait_for_termination, interruptible_wait_for_termination):
6599 Move after wait_for_termination_1.
6601 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6603 * sysdep.c (interruptible_wait_for_termination): New function
6604 which is like wait_for_termination, but allows keyboard
6607 * callproc.c (Fcall_process): Add (:file "file") as an option for
6609 (Fcall_process_region): Ditto.
6611 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6613 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6614 rather than `XVECTOR (FOO)->size'.
6616 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6617 inttypes.h, as a gnulib replacement is used if it not available in
6620 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6622 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6623 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6624 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6626 * coding.c (coding_alloc_by_realloc): Error out if destination
6627 will grow beyond MOST_POSITIVE_FIXNUM.
6628 (decode_coding_emacs_mule): Abort if there isn't enough place in
6629 charbuf for the composition carryover bytes. Reserve an extra
6630 space for up to 2 characters produced in a loop.
6631 (decode_coding_iso_2022): Abort if there isn't enough place in
6632 charbuf for the composition carryover bytes.
6634 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6636 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6637 aborting when %lld or %lll format is passed.
6638 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6639 %llo or %llx format is passed. (Bug#8545)
6641 * window.c (window_scroll_line_based): Use a marker instead of
6642 simple variables to record original value of point. (Bug#7952)
6644 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6645 produced by %s or %c overflows available buffer space. (Bug#8545)
6647 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6649 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6650 (SIZE_MAX): Move defn after all includes, as they might #define it.
6652 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6654 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6656 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6658 * keyboard.c (Qdelayed_warnings_hook): Define.
6659 (command_loop_1): Run `delayed-warnings-hook'
6660 if Vdelayed_warnings_list is non-nil.
6661 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6662 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6664 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6666 * doprnt.c (doprnt): Don't return value smaller than the buffer
6667 size if the message was truncated. (Bug#8545).
6669 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6671 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6672 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6674 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6676 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6678 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6680 * makefile.w32-in: Update dependencies.
6682 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6684 Improve `doprnt' and its usage. (Bug#8545)
6685 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6686 `format_end'. Remove support for %l as a conversion specifier.
6687 Don't use xrealloc. Improve diagnostics when the %l size modifier
6688 is used. Update the commentary.
6690 * eval.c (verror): Simplify calculation of size_t.
6692 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6695 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6697 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6700 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6702 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6703 This makes this file independent of the recent pseudovector change.
6705 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6707 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6709 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6710 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6711 Remove unused local.
6712 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6714 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6715 GCC 4.6.0 optimizes based on type-based alias analysis.
6716 For example, if b is of type struct buffer * and v of type struct
6717 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6718 != &v->size, and therefore "v->size = 1; b->size = 2; return
6719 v->size;" must therefore return 1. This assumption is incorrect
6720 for Emacs, since it type-puns struct Lisp_Vector * with many other
6721 types. To fix this problem, this patch adds a new type struct
6722 vectorlike_header that documents the constraints on layout of vectors
6723 and pseudovectors, and helps optimizing compilers not get fooled
6724 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6725 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6726 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6728 (XSETPVECTYPE): Rewrite in terms of new macro.
6729 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6730 This is a bit clearer, and further avoids the possibility of
6731 undesirable aliasing.
6732 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6733 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6734 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6735 since Lisp_Subr is a special case (no "next" field).
6736 (ASIZE): Now uses header.size rather than size.
6737 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6738 to avoid the hassle of writing XVECTOR (foo)->header.size.
6739 (struct vectorlike_header): New type.
6740 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6741 object, to help avoid aliasing.
6742 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6743 (SUBRP): Likewise, since Lisp_Subr is a special case.
6744 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6745 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6746 (struct Lisp_Hash_Table): Combine first two members into a single
6747 struct vectorlike_header member. All uses of "size" and "next" members
6748 changed to be "header.size" and "header.next".
6749 * buffer.h (struct buffer): Likewise.
6750 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6751 * frame.h (struct frame): Likewise.
6752 * process.h (struct Lisp_Process): Likewise.
6753 * termhooks.h (struct terminal): Likewise.
6754 * window.c (struct save_window_data, struct saved_window): Likewise.
6755 * window.h (struct window): Likewise.
6756 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6757 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6758 * buffer.c (init_buffer_once): Likewise.
6759 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6761 * process.c (Fformat_network_address): Use local var for size,
6764 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6766 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6767 * data.c (atof): Remove decl; no longer used or needed.
6768 (digit_to_number): Move to lread.c.
6769 (Fstring_to_number): Use new string_to_number function, to be
6770 consistent with how the Lisp reader treats infinities and NaNs.
6771 Do not assume that floating-point numbers represent EMACS_INT
6772 without losing information; this is not true on most 64-bit hosts.
6773 Avoid double-rounding errors, by insisting on integers when
6774 parsing non-base-10 numbers, as the documentation specifies.
6775 * lisp.h (string_to_number): New decl, replacing ...
6776 (isfloat_string): Remove.
6777 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6778 (read1): Do not accept +. and -. as integers; this
6779 appears to have been a coding error. Similarly, do not accept
6780 strings like +-1e0 as floating point numbers. Do not report
6781 overflow for integer overflows unless the base is not 10 which
6782 means we have no simple and reliable way to continue.
6783 Break out the floating-point parsing into a new
6784 function string_to_number, so that Fstring_to_number parses
6785 floating point numbers consistently with the Lisp reader.
6786 (digit_to_number): Move here from data.c. Make it static inline.
6787 (E_CHAR, EXP_INT): Remove, replacing with ...
6788 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6789 (string_to_number): New function, replacing isfloat_string.
6790 This function checks for valid syntax and produces the resulting
6791 Lisp float number too. Rework it so that string-to-number
6792 no longer mishandles examples like "1.0e+". Use strtoumax,
6793 so that overflow for non-base-10 numbers is reported only when
6794 there's no portable and simple way to convert to floating point.
6796 * textprop.c (set_text_properties_1): Rewrite for clarity,
6797 and to avoid GCC warning about integer overflow.
6799 * intervals.h (struct interval): Use EMACS_INT for members
6800 where EMACS_UINT might cause problems. See
6801 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6802 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6803 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6805 (offset_intervals): Tell GCC not to worry about length overflow
6806 when negating a negative length.
6808 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6809 (overrun_check_free): Likewise.
6811 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6812 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6815 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6816 (gnutls_make_error): Rename local to avoid shadowing.
6817 (gnutls_emacs_global_deinit): ifdef out; not used.
6818 (Fgnutls_boot): Use const for pointer to readonly storage.
6819 Comment out unused local. Fix pointer signedness problems.
6821 * lread.c (openp): Don't stuff size_t into an 'int'.
6822 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6823 about possible signed overflow.
6825 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6826 (GDK_KEY_g): Don't define if already defined.
6827 (xg_prepare_tooltip): Avoid pointer signedness problem.
6828 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6830 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6831 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6833 * xfns.c (Fx_window_property): Simplify a bit,
6834 to make a bit faster and to avoid GCC 4.6.0 warning.
6835 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6837 * fns.c (internal_equal): Don't assume size_t fits in int.
6839 * alloc.c (compact_small_strings): Tighten assertion a little.
6841 Replace pEd with more-general pI, and fix some printf arg casts.
6842 * lisp.h (pI): New macro, generalizing old pEd macro to other
6843 conversion specifiers. For example, use "...%"pI"d..." rather
6844 than "...%"pEd"...".
6845 (pEd): Remove. All uses replaced with similar uses of pI.
6846 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6847 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6848 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6849 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6850 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6851 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6852 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6854 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6855 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6856 * print.c (safe_debug_print, print_object): Likewise.
6857 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6859 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6860 avoiding the 0 flag, which is not portable.
6861 * process.c (Fmake_network_process): Use pI to avoid cast.
6862 * region-cache.c (pp_cache): Likewise.
6863 * xdisp.c (decode_mode_spec): Likewise.
6864 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6865 behavior on 64-bit hosts with printf arg.
6866 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6867 (x_stop_queuing_selection_requests): Likewise.
6868 (x_get_window_property): Don't truncate byte count to an 'int'
6871 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6872 here, since it parses constructs like leading '-' and spaces,
6873 which are not wanted; and it overflows with large numbers.
6874 Instead, simply match F[0-9]+, which is what is wanted anyway.
6876 * alloc.c: Remove unportable assumptions about struct layout.
6877 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6878 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6879 (allocate_vectorlike, make_pure_vector): Use the new macros,
6880 plus offsetof, to remove unportable assumptions about struct layout.
6881 These assumptions hold on all porting targets that I know of, but
6882 they are not guaranteed, they're easy to remove, and removing them
6883 makes further changes easier.
6885 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6886 This doesn't fix a bug but makes the code clearer.
6887 (string_overrun_cookie): Now const. Use initializers that
6888 don't formally overflow signed char, to avoid warnings.
6889 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6890 can cause Emacs to crash when string overrun checking is enabled.
6891 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6892 multiple of sizeof (EMACS_INT); it need not be, if
6893 alignof(EMACS_INT) < sizeof (EMACS_INT).
6894 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6896 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6898 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6900 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6902 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6903 supposed to be handshaking. (Bug#8556)
6904 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6906 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6908 * lisp.h (Qdebug): List symbol.
6909 * eval.c (Qdebug): Restore global linkage.
6910 * keyboard.c (debug-on-event): New variable.
6911 (handle_user_signal): Break into debugger when debug-on-event
6912 matches the current signal symbol.
6914 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6916 * alloc.c (check_sblock, check_string_bytes)
6917 (check_string_free_list): Convert to standard C.
6919 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6921 * w32.c (emacs_gnutls_push): Fix typo.
6923 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6925 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6926 "cast to pointer from integer of different size".
6928 Improve doprnt and its use in verror. (Bug#8545)
6929 * doprnt.c (doprnt): Document the set of format control sequences
6930 supported by the function. Use SAFE_ALLOCA instead of always
6933 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6934 is one byte too soon. Don't use xrealloc; instead xfree and
6937 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6939 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6942 * gnutls.c: Renamed global_initialized to
6943 gnutls_global_initialized. Added internals for the
6944 :verify-hostname-error, :verify-error, and :verify-flags
6945 parameters of `gnutls-boot' and documented those parameters in the
6946 docstring. Start callback support.
6947 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6948 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6949 on error. Return error code.
6950 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6951 (emacs_gnutls_read): Likewise.
6952 (Fgnutls_boot): Return handshake error code.
6953 (emacs_gnutls_handle_error): New function.
6954 (wsaerror_to_errno): Likewise.
6956 * w32.h (emacs_gnutls_pull): Add prototype.
6957 (emacs_gnutls_push): Likewise.
6959 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6960 (emacs_gnutls_push): Likewise.
6962 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6964 * process.c (wait_reading_process_output): Check if GnuTLS
6965 buffered some data internally if no FDs are set for TLS
6968 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6969 (LIBS): Link to USER_LIBS.
6970 ($(BLD)/gnutls.$(0)): New target.
6972 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6974 * xdisp.c (handle_single_display_spec): Rename the
6975 display_replaced_before_p argument into display_replaced_p, to
6976 make it consistent with the commentary. Fix typos in the
6979 * textprop.c (syms_of_textprop): Remove dead code.
6980 (copy_text_properties): Delete obsolete commentary about an
6981 interface that was deleted long ago. Fix typos in the description
6984 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6985 to changes in oldXMenu/XMenu.h from 2011-04-16.
6986 <menu_help_message, prev_menu_help_message>: Constify.
6987 (IT_menu_make_room): menu->help_text is now `const char **';
6990 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6991 to changes in oldXMenu/XMenu.h from 2011-04-16.
6992 (struct XMenu): Declare `help_text' `const char **'.
6994 * xfaces.c <Qunspecified>: Make extern again.
6996 * syntax.c: Include sys/types.h before including regex.h, as
6999 * doc.c (get_doc_string): Improve the format passed to `error'.
7001 * doprnt.c (doprnt): Improve commentary.
7003 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7005 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7008 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7009 changes in globals.h immediately force recompilation.
7010 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7011 $(CURDIR)/s/ms-w32.h.
7012 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7014 * character.c (Fchar_direction): Function deleted.
7015 (syms_of_character): Don't defsubr it.
7016 <char-direction-table>: Deleted.
7018 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7020 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7021 * doprnt.c: Include limits.h.
7022 (SIZE_MAX): New macro.
7023 (doprnt): Return a size_t value. 2nd arg is now size_t.
7024 Many local variables are now size_t instead of int or unsigned.
7025 Improve overflow protection. Support `l' modifier for integer
7026 conversions. Support %l conversion. Don't assume an EMACS_INT
7027 argument for integer conversions and for %c.
7029 * lisp.h (doprnt): Restore prototype.
7031 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7034 * Makefile.in (base_obj): Add back doprnt.o.
7036 * deps.mk (doprnt.o): Add back prerequisites.
7037 (callint.o): Depend on character.h.
7039 * eval.c (internal_lisp_condition_case): Include the handler
7040 representation in the error message.
7041 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7042 when breaking from the loop.
7044 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7046 * callint.c (Fcall_interactively): When displaying error message
7047 about invalid control letter, pass the character's codepoint, not
7048 a pointer to its multibyte form. Improve display of the character
7049 in octal and display also its hex code.
7051 * character.c (char_string): Use %x to display the (unsigned)
7052 codepoint of an invalid character, to avoid displaying a bogus
7055 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7056 `error', not SYMBOL_NAME itself.
7058 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7059 character arguments to `error'.
7061 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7062 to `error' in error message about FINAL_CHAR argument. Make sure
7063 FINAL_CHAR is a character, and use %c when it is passed as
7064 argument to `error'.
7066 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7068 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7070 * w32.c: Include <time.h>.
7071 (sys_localtime): New function.
7073 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7075 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7077 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7079 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7081 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7084 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7086 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7087 gl_state.e_property when gl_state.object is Qt.
7089 * insdel.c (make_gap_larger): Remove limitation of buffer size
7092 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7094 * xdisp.c (lookup_glyphless_char_display)
7095 (produce_glyphless_glyph): Handle cons cell entry in
7096 glyphless-char-display.
7097 (Vglyphless_char_display): Document it.
7099 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7100 glyphless-char-display.
7102 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7104 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7106 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7108 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7109 definition for no-X builds.
7111 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7113 Static checks with GCC 4.6.0 and non-default toolkits.
7115 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7117 * process.c (keyboard_bit_set): Define only if SIGIO.
7118 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7119 (send_process): Repair possible setjmp clobbering.
7121 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7123 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7125 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7127 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7128 Define only if needed.
7130 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7131 by pacifying GCC about it. Maybe it's time to retire it?
7132 * xfaces.c (USG, __TIMEVAL__): Likewise.
7134 * dispextern.h (struct redisplay_interface): Rename param
7136 * termhooks.h (struct terminal): Likewise.
7137 * xterm.c (xembed_send_message): Likewise.
7139 * insdel.c (make_gap_smaller): Define only if
7140 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7142 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7145 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7146 so that we aren't warned about unused symbols.
7148 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7150 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7152 * xfns.c (x_real_positions): Mark locals as initialized.
7154 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7156 * xterm.c: Fix problems found by static analysis with other toolkits.
7157 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7158 (x_dispatch_event): Declare static if USE_GTK, and
7159 define if USE_GTK || USE_X_TOOLKIT.
7160 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7161 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7162 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7163 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7165 * xmenu.c (menu_help_callback): Pointer type fixes.
7166 Use const pointers when pointing at readonly data. Avoid pointer
7168 (FALSE): Remove unused macro.
7169 (update_frame_menubar): Remove unused decl.
7171 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7173 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7174 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7175 (single_menu_item): Rename local to avoid shadowing.
7177 * keyboard.c (make_lispy_event): Remove unused local var.
7179 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7180 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7182 * bitmaps: Change bitmaps from unsigned char back to the X11
7183 compatible char. Avoid the old compiler warnings about
7184 out-of-range initializers by using, for example, '\xab' rather
7187 * xgselect.c (xgselect_initialize): Check vs interface
7188 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7190 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7192 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7193 to read-only memory.
7195 * fns.c (vector): Remove; this old hack is no longer needed.
7197 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7199 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7201 * xrdb.c (x_load_resources): Omit unused local.
7203 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7204 (x_window): Rename locals to avoid shadowing.
7205 (USG): Use the kludged USG macro, to pacify gcc.
7207 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7208 (x_term_init): Remove local to avoid shadowing.
7210 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7212 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7213 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7215 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7217 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7219 Fix regex.c, syntax.c and friends for buffers > 2GB.
7220 * syntax.h (struct gl_state_s): Declare character position members
7223 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7225 * textprop.c (verify_interval_modification, interval_of):
7226 Declare arguments EMACS_INT.
7228 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7231 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7233 * indent.c (Fvertical_motion): Local variable it_start is now
7236 * regex.c (re_match, re_match_2, re_match_2_internal)
7237 (bcmp_translate, regcomp, regexec, print_double_string)
7238 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7239 (re_compile_pattern, re_exec): Declare arguments and local
7240 variables `size_t' and `ssize_t' and return values `regoff_t', as
7242 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7243 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7244 <compile_stack_type>: `size' and `avail' are now `size_t'.
7246 * regex.h <regoff_t>: Use ssize_t, not int.
7247 (re_search, re_search_2, re_match, re_match_2): Arguments that
7248 specify buffer/string position and length are now ssize_t and
7249 size_t. Return type is regoff_t.
7251 2011-04-16 Ben Key <bkey76@gmail.com>
7253 * nsfont.m: Fixed bugs in ns_get_family and
7254 ns_descriptor_to_entity that were caused by using free to
7255 deallocate memory blocks that were allocated by xmalloc (via
7256 xstrdup). This caused Emacs to crash when compiled with
7257 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7258 --enable-checking=xmallocoverrun). xfree is now used to
7259 deallocate these memory blocks.
7261 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7263 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7265 emacs_write: Accept and return EMACS_INT for sizes.
7266 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7268 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7269 Accept and return EMACS_INT.
7270 (emacs_gnutls_write): Return the number of bytes written on
7272 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7273 (emacs_read, emacs_write): Remove check for negative size, as the
7274 Emacs source code has been audited now.
7275 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7276 (emacs_read, emacs_write): Use it.
7277 * process.c (send_process): Adjust to the new signatures of
7278 emacs_write and emacs_gnutls_write. Do not attempt to store
7279 a byte offset into an 'int'; it might overflow.
7280 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7282 * sound.c: Don't assume sizes fit in 'int'.
7283 (struct sound_device.period_size, alsa_period_size):
7284 Return EMACS_INT, not int.
7285 (struct sound_device.write, vox_write, alsa_write):
7286 Accept EMACS_INT, not int.
7287 (wav_play, au_play): Use EMACS_INT to store sizes and to
7288 record read return values.
7290 2011-04-15 Ben Key <bkey76@gmail.com>
7292 * keyboard.c (Qundefined): Don't declare static since it is used
7294 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7295 static since they are used in nsfont.m.
7297 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7299 * process.c (Qprocessp): Don't declare static.
7300 * lisp.h (Qprocessp): Declare again.
7302 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7304 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7306 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7308 Improve C-level modularity by making more things 'static'.
7310 Don't publish debugger-only interfaces to other modules.
7311 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7312 (verify_bytepos, count_markers): Move decls to the only modules
7314 * region-cache.h (pp_cache): Likewise.
7315 * window.h (check_all_windows): Likewise.
7316 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7318 * sysdep.c (croak): Now static, if
7319 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7320 * syssignal.h (croak): Declare only if not static.
7322 * alloc.c (refill_memory_reserve): Now static if
7323 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7324 * lisp.h (refill_memory_reserve): Declare only if not static.
7326 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7327 Define only if USE_LUCID.
7329 * xrdb.c (x_customization_string, x_rm_string): Now static.
7331 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7332 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7334 * xdisp.c (draw_row_with_mouse_face): Now static.
7335 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7337 * window.h (check_all_windows): Mark externally visible.
7339 * window.c (window_deletion_count): Now static.
7341 * undo.c: Make symbols static if they're not exported.
7342 (last_undo_buffer, last_boundary_position, pending_boundary):
7345 * textprop.c (interval_insert_behind_hooks): Now static.
7346 (interval_insert_in_front_hooks): Likewise.
7348 * term.c: Make symbols static if they're not exported.
7349 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7350 (max_frame_lines, tty_set_terminal_modes):
7351 (tty_reset_terminal_modes, tty_turn_off_highlight):
7352 (get_tty_terminal): Now static.
7353 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7354 * termhooks.h (term_mouse_moveto): Do not declare if
7356 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7357 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7359 * sysdep.c: Make symbols static if they're not exported.
7360 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7362 (sigprocmask_set, full_mask): Remove; unused.
7363 (wait_debugging): Mark as visible.
7364 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7365 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7367 * syntax.c (syntax_temp): Define only if !__GNUC__.
7369 * sound.c (current_sound_device, current_sound): Now static.
7371 * search.c (searchbufs, searchbuf_head): Now static.
7373 * scroll.c (scroll_cost): Remove; unused.
7374 * dispextern.h (scroll_cost): Remove decl.
7376 * region-cache.h (pp_cache): Mark as externally visible.
7378 * process.c: Make symbols static if they're not exported.
7379 (process_tick, update_tick, create_process, chan_process):
7380 (Vprocess_alist, proc_buffered_char, datagram_access):
7381 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7382 (deactivate_process): Mark defn as static, as well as decl.
7383 * lisp.h (create_process): Remove decl.
7384 * process.h (chan_process, Vprocess_alist): Remove decls.
7386 * print.c: Make symbols static if they're not exported.
7387 (print_depth, new_backquote_output, being_printed, print_buffer):
7388 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7389 (print_interval, print_number_index, initial_stderr_stream):
7391 * lisp.h (Fprinc): Remove decl.
7392 (debug_output_compilation_hack): Mark as externally visible.
7394 * sysdep.c (croak): Move decl from here to syssignal.h.
7395 * syssignal.h (croak): Put it here, so the API can be checked when
7396 'croak' is called from dissociate_if_controlling_tty.
7398 * minibuf.c: Make symbols static if they're not exported.
7399 (minibuf_save_list, choose_minibuf_frame): Now static.
7400 * lisp.h (choose_minibuf_frame): Remove decl.
7402 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7404 * lread.c: Make symbols static if they're not exported.
7405 (read_objects, initial_obarray, oblookup_last_bucket_number):
7407 (make_symbol): Remove; unused.
7408 * lisp.h (initial_obarray, make_symbol): Remove decls.
7410 * keyboard.c: Make symbols static if they're not exported.
7411 (single_kboard, recent_keys_index, total_keys, recent_keys):
7412 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7413 (this_single_command_key_start, echoing, last_auto_save):
7414 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7415 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7416 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7417 (Vlispy_mouse_stem, double_click_count):
7419 (force_auto_save_soon): Define only if SIGDANGER.
7420 (ignore_mouse_drag_p): Now static if
7421 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7422 (print_help): Remove; unused.
7423 (stop_character, last_timer_event): Mark as externally visible.
7424 * keyboard.h (ignore_mouse_drag_p): Declare only if
7425 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7426 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7427 * lisp.h (echoing): Remove decl.
7428 (force_auto_save_soon): Declare only if SIGDANGER.
7429 * xdisp.c (redisplay_window): Simplify code, to make it more
7430 obvious that ignore_mouse_drag_p is not accessed if !defined
7431 USE_GTK && !defined HAVE_NS.
7433 * intervals.c: Make symbols static if they're not exported.
7434 (merge_properties_sticky, merge_interval_right, delete_interval):
7436 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7438 * insdel.c: Make symbols static if they're not exported.
7439 However, leave prepare_to_modify_buffer alone. It's never
7440 called from outside this function, but that appears to be a bug.
7441 (combine_after_change_list, combine_after_change_buffer):
7442 (adjust_after_replace, signal_before_change): Now static.
7443 (adjust_after_replace_noundo): Remove; unused.
7444 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7445 (signal_before_change): Remove decls.
7447 * indent.c (val_compute_motion, val_vmotion): Now static.
7449 * image.c: Make symbols static if they're not exported.
7450 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7452 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7453 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7455 * fringe.c (standard_bitmaps): Now static.
7456 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7458 * frame.c: Make symbols static if they're not exported.
7459 (x_report_frame_params, make_terminal_frame): Now static.
7460 (get_frame_param): Now static, unless HAVE_NS.
7461 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7462 (x_get_resource_string): Remove; not used.
7463 * frame.h (make_terminal_frame, x_report_frame_params):
7464 (x_get_resource_string); Remove decls.
7465 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7466 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7468 * font.c, fontset.c: Make symbols static if they're not exported.
7469 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7470 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7471 * font.c (font_close_object): Now static.
7472 * font.h (font_close_object): Remove.
7473 * fontset.c (FONTSET_OBJLIST): Remove.
7474 (free_realized_fontset) #if-0 the body, which does nothing.
7475 (face_suitable_for_char_p): #if-0, as it's never called.
7476 * fontset.h (face_suitable_for_char_p): Remove decl.
7477 * xfaces.c (face_at_string_position):
7478 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7479 since 0 is always ASCII.
7481 * fns.c (weak_hash_tables): Now static.
7483 * fileio.c: Make symbols static if they're not exported.
7484 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7485 (Vwrite_region_annotation_buffers): Now static.
7487 * eval.c: Make symbols static if they're not exported.
7488 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7489 * lisp.h (backtrace_list): Remove decl.
7491 * emacs.c: Make symbols static if they're not exported.
7492 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7493 (fatal_error_code, fatal_error_signal_hook, standard_args):
7495 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7496 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7497 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7498 * lisp.h (fatal_error_signal_hook): Remove decl.
7499 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7501 * editfns.c: Move a (normally-unused) function to its only use.
7502 * editfns.c, lisp.h (get_operating_system_release): Remove.
7503 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7504 worth the hassle of breaking this out.
7506 * xterm.c: Make symbols static if they're not exported.
7507 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7508 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7509 (x_destroy_window, x_delete_display):
7511 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7512 (x_mouse_leave): Remove; unused.
7513 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7514 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7515 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7517 (x_mouse_leave): Declare only if WINDOWSNT.
7518 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7519 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7522 * ftxfont.c: Make symbols static if they're not exported.
7523 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7525 * font.h (ftxfont_driver): Likewise.
7527 * xfns.c: Make symbols static if they're not exported.
7528 (x_last_font_name, x_display_info_for_name):
7529 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7530 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7531 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7532 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7533 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7534 (last_show_tip_args): Now static.
7535 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7536 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7537 (x_screen_planes): Remove; unused.
7538 * dispextern.h (x_screen_planes): Remove decl.
7540 * dispnew.c: Make symbols static if they're not exported.
7541 * dispextern.h (redraw_garbaged_frames, scrolling):
7542 (increment_row_positions): Remove.
7543 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7544 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7546 (redraw_garbaged_frames): Remove; unused.
7548 * xfaces.c: Make symbols static if they're not exported.
7549 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7551 * xterm.h (defined_color): Remove decls.
7552 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7553 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7554 (menu_face_changed_default, defined_color, free_realized_face):
7555 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7556 (ascii_face_of_lisp_face): Remove; unused.
7558 * xdisp.c: Make symbols static if they're not exported.
7559 * dispextern.h (scratch_glyph_row, window_box_edges):
7560 (glyph_to_pixel_coords, set_cursor_from_row):
7561 (get_next_display_element, set_iterator_to_next):
7562 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7563 (show_mouse_face): Remove decls
7564 * frame.h (message_buf_print): Likewise.
7565 * lisp.h (pop_message, set_message, check_point_in_composition):
7567 * xterm.h (set_vertical_scroll_bar): Likewise.
7568 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7569 (message_buf_print, scratch_glyph_row, displayed_buffer):
7570 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7571 (get_next_display_element, show_mouse_face, window_box_edges):
7572 (frame_to_window_pixel_xy, check_point_in_composition):
7573 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7574 (glyph_to_pixel_coords): Remove; unused.
7576 * dired.c (file_name_completion): Now static.
7578 * dbusbind.c (xd_in_read_queued_messages): Now static.
7580 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7581 * data.c (circular_list_error): Remove.
7583 * commands.h (last_point_position, last_point_position_buffer):
7584 (last_point_position_window): Remove decls.
7585 * keyboard.c: Make these variables static.
7587 * coding.h (coding, code_convert_region, encode_coding_gap):
7589 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7590 (iso_code_class, detect_coding, code_convert_region): Now static.
7591 (encode_coding_gap): Remove; unused.
7593 * chartab.c (chartab_chars, chartab_bits): Now static.
7595 * charset.h (charset_iso_8859_1): Remove decl.
7596 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7599 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7600 * ccl.c (Vccl_program_table): Now static.
7601 (check_ccl_update): Remove; unused.
7603 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7604 * category.h: ... from here.
7605 * category.c (check_category_table, set_category_set): Now static.
7607 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7608 * lisp.h: Remove these decls.
7610 * buffer.c (buffer_count): Remove unused var.
7612 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7613 so that it's not optimized away.
7614 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7615 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7616 exported only to the debugger.
7618 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7619 * atimer.h (run_all_atimers): Remove; not exported.
7621 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7622 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7623 was inaccessible from Lisp.
7624 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7625 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7627 alloc.c: Import and export fewer symbols, and remove unused items.
7628 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7630 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7631 it's not optimized away by whole-program optimization.
7632 (message_enable_multibyte, free_misc): Remove.
7633 (catchlist, handlerlist, mark_backtrace):
7634 Declare only if BYTE_MARK_STACK.
7635 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7636 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7637 (message_enable_multibyte): Remove decl.
7638 (free_misc, interval_free_list, float_block, float_block_index):
7639 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7640 (cons_free_list, last_marked_index):
7642 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7643 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7644 (mark_backtrace): Define only if BYTE_MARK_STACK.
7645 * xdisp.c (message_enable_multibyte): Now static.
7647 Declare Lisp_Object Q* variables to be 'static' if not exported.
7648 This makes it easier for human readers (and static analyzers)
7649 to see whether these variables are used from other modules.
7650 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7651 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7652 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7653 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7654 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7655 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7656 * xmenu.c, xselect.c:
7657 Declare Q* vars static if they are not used in other modules.
7658 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7659 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7660 Remove decls of unexported vars.
7661 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7663 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7665 Make Emacs functions such as Fatom 'static' by default.
7666 This makes it easier for human readers (and static analyzers)
7667 to see whether these functions can be called from other modules.
7668 DEFUN now defines a static function. To make the function external
7669 so that it can be used in other C modules, use the new macro DEFUE.
7670 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7671 (Finit_image_library):
7672 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7673 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7674 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7675 Remove decls, since these functions are now static.
7676 (Funintern, Fget_internal_run_time): New decls, since these functions
7677 were already external.
7679 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7680 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7681 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7682 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7683 * keyboard.c, keymap.c, lread.c:
7684 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7685 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7686 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7687 Mark functions with DEFUE instead of DEFUN,
7688 if they are used in other modules.
7689 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7690 decls for now-static functions.
7691 * buffer.h (Fdelete_overlay): Remove decl.
7692 * callproc.c (Fgetenv_internal): Mark as internal.
7693 * composite.c (Fremove_list_of_text_properties): Remove decl.
7694 (Fcomposition_get_gstring): New forward static decl.
7695 * composite.h (Fcomposite_get_gstring): Remove decl.
7696 * dired.c (Ffile_attributes): New forward static decl.
7697 * doc.c (Fdocumntation_property): New forward static decl.
7698 * eval.c (Ffetch_bytecode): New forward static decl.
7699 (Funintern): Remove extern decl; now in .h file where it belongs.
7700 * fileio.c (Fmake_symbolic_link): New forward static decl.
7701 * image.c (Finit_image_library): New forward static decl.
7702 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7703 * intervals.h (Fprevious_property_change):
7704 (Fremove_list_of_text_properties): Remove decls.
7705 * keyboard.c (Fthis_command_keys): Remove decl.
7706 (Fcommand_execute): New forward static decl.
7707 * keymap.c (Flookup_key): New forward static decl.
7708 (Fcopy_keymap): Now static.
7709 * keymap.h (Flookup_key): Remove decl.
7710 * process.c (Fget_process): New forward static decl.
7711 (Fprocess_datagram_address): Mark as internal.
7712 * syntax.c (Fsyntax_table_p): New forward static decl.
7713 (skip_chars): Remove duplicate decl.
7714 * textprop.c (Fprevious_property_change): New forward static decl.
7715 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7717 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7718 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7720 * editfns.c (Fformat): Remove unreachable code.
7722 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7724 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7727 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7729 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7730 when at ZV. (Bug#8487)
7732 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7734 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7736 * keyboard.c (parse_tool_bar_item): Likewise.
7737 * sound.c (sound_cleanup, alsa_close): Likewise.
7738 * termcap.c (tgetent): Likewise.
7739 * xfns.c (x_default_font_parameter): Likewise.
7740 * xsettings.c (read_and_apply_settings): Likewise.
7742 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7743 (overrun_check_free): Protoize.
7745 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7747 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7748 since callers should never pass a negative size.
7749 Change the signature to match that of plain 'read' and 'write'; see
7750 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7751 * lisp.h: Update prototypes of emacs_write and emacs_read.
7753 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7755 * xdisp.c (redisplay_window): Don't try to determine the character
7756 position of the scroll margin if the window start point w->startp
7757 is outside the buffer's accessible region. (Bug#8468)
7759 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7761 Fix write-region and its subroutines for buffers > 2GB.
7762 * fileio.c (a_write, e_write): Modify declaration of arguments and
7763 local variables to support buffers larger than 2GB.
7764 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7766 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7767 argument, local variables, and return value.
7769 * lisp.h: Update prototypes of emacs_write and emacs_read.
7771 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7773 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7775 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7777 Fix more problems found by GCC 4.6.0's static checks.
7779 * xdisp.c (vmessage): Use a better test for character truncation.
7781 * charset.c (load_charset_map): <, not <=, for optimization,
7782 and to avoid potential problems with integer overflow.
7783 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7784 * casetab.c (set_identity, shuffle): Likewise.
7785 * editfns.c (Fformat): Likewise.
7786 * syntax.c (skip_chars): Likewise.
7788 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7789 This also lets GCC 4.6.0 generate slightly better loop code.
7791 * callint.c (Fcall_interactively): <, not <=, for optimization.
7792 (Fcall_interactively): Count the number of arguments produced,
7793 not the number of arguments given. This is simpler and lets GCC
7794 4.6.0 generate slightly better code.
7796 * ftfont.c: Distingish more carefully between FcChar8 and char.
7797 The previous code passed unsigned char * to a functions like
7798 strlen and xstrcasecmp that expect char *, which does not
7799 conform to the C standard.
7800 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7801 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7802 char * when the C standard requires it.
7804 * keyboard.c (read_char): Remove unused var.
7806 * eval.c: Port to Windows vsnprintf (Bug#8435).
7808 (SIZE_MAX): Define if the headers do not.
7809 (verror): Do not give up if vsnprintf returns a negative count.
7810 Instead, grow the buffer. This ports to Windows vsnprintf, which
7811 does not conform to C99. Problem reported by Eli Zaretskii.
7812 Also, simplify the allocation scheme, by avoiding the need for
7813 calling realloc, and removing the ALLOCATED variable.
7815 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7817 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7818 But keep the doprint source code for now, as we might revamp it
7819 and use it again (Bug#8435).
7820 * lisp.h (doprnt): Remove.
7821 * Makefile.in (base_obj): Remove doprnt.o.
7822 * deps.mk (doprnt.o): Remove.
7824 error: Print 32- and 64-bit integers portably (Bug#8435).
7825 Without this change, on typical 64-bit hosts error ("...%d...", N)
7826 was used to print both 32- and 64-bit integers N, which relied on
7828 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7829 * lisp.h (error, verror): Mark as printf-like functions.
7830 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7831 Report overflow in size calculations when allocating printf buffer.
7832 Do not truncate output string at its first null byte.
7833 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7834 Truncate the output at a character boundary, since vsnprintf does not
7836 * charset.c (check_iso_charset_parameter): Convert internal
7837 character to string before calling 'error', since %c now has the
7839 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7840 overflow when computing char to be passed to 'error'. Do not
7841 pass Lisp_Object to 'error'; pass the integer instead.
7842 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7843 formatted with plain %d.
7845 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7847 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7849 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7851 * xterm.c (x_catch_errors): Remove duplicate declaration.
7853 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7855 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7857 2011-04-10 Jim Meyering <meyering@redhat.com>
7859 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7860 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7861 return ssize_t not "int", and use size_t as the buffer length.
7862 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7863 * gnutls.h: Update declarations.
7864 * process.c (read_process_output): Use ssize_t, to match.
7865 (send_process): Likewise.
7867 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7869 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7871 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7873 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7874 Use unsigned char, to match FcChar8 type definition.
7876 * xterm.c (handle_one_xevent):
7877 * xmenu.c (create_and_show_popup_menu):
7878 * xselect.c (x_decline_selection_request)
7879 (x_reply_selection_request): Avoid type-punned deref of X events.
7881 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7883 Fix some uses of `int' instead of EMACS_INT.
7884 * search.c (string_match_1, fast_string_match)
7885 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7886 (scan_buffer, find_next_newline_no_quit)
7887 (find_before_next_newline, search_command, Freplace_match)
7888 (Fmatch_data): Make some `int' variables be EMACS_INT.
7890 * xdisp.c (display_count_lines): 3rd argument and return value now
7891 EMACS_INT. All callers changed.
7892 (pint2hrstr): Last argument is now EMACS_INT.
7894 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7895 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7896 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7897 (decode_coding_utf_16, decode_coding_emacs_mule)
7898 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7899 (decode_coding_ccl, decode_coding_charset)
7900 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7901 (decode_coding_iso_2022, decode_coding_emacs_mule)
7902 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7903 <char_offset, last_offset>: Declare EMACS_INT.
7904 (encode_coding_utf_8, encode_coding_utf_16)
7905 (encode_coding_emacs_mule, encode_invocation_designation)
7906 (encode_designation_at_bol, encode_coding_iso_2022)
7907 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7908 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7910 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7911 (encode_invocation_designation): Last argument P_NCHARS is now
7913 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7914 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7916 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7919 * ccl.c (Fccl_execute_on_string): Declare some variables
7922 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7924 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7926 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7928 * process.c (Fformat_network_address): Doc fix.
7930 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7932 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7934 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7936 * keyboard.c (read_char): Call Lisp function help-form-show,
7937 instead of using internal_with_output_to_temp_buffer.
7938 (Qhelp_form_show): New var.
7939 (syms_of_keyboard): Use DEFSYM macro.
7941 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7943 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7945 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7947 * process.c (Flist_processes): Remove to Lisp.
7948 (list_processes_1): Delete.
7950 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7952 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7954 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7956 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7958 Fix more problems found by GCC 4.6.0's static checks.
7960 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7962 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7964 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7966 * xdisp.c (vmessage): Mark as a printf-like function.
7968 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7970 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7972 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7973 printf-like functions.
7974 (tiff_load): Add casts to remove these marks before passing them
7975 to system-supplied API.
7977 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7979 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7980 This avoids several warnings with gcc -Wstrict-overflow.
7981 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7982 directly, rather than having caller test rule sign. This avoids
7983 some unnecessary tests.
7984 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7985 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7986 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7988 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7989 (xfont_open): Avoid unnecessary tests.
7991 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7993 * composite.h, composite.c (composition_gstring_put_cache):
7994 Use EMACS_INT, not int, for length.
7996 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7997 breaking out part of COMPOSITION_DECODE_RULE.
7998 (COMPOSITION_DECODE_RULE): Use it.
7999 * composite.c (get_composition_id): Remove unused local vars,
8000 by using the new macro.
8002 * textprop.c (set_text_properties_1): Change while to do-while,
8003 since the condition is always true at first.
8005 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8006 (interval_deletion_adjustment): Return unsigned value.
8009 * process.c (list_processes_1, create_pty, read_process_output):
8010 (exec_sentinel): Remove vars that were set but not used.
8011 (create_pty): Remove unnecessary "volatile"s.
8012 (Fnetwork_interface_info): Avoid possibility of int overflow.
8013 (read_process_output): Do adaptive read buffering even if carryover.
8014 (read_process_output): Simplify nbytes computation if buffered.
8016 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8018 * syntax.c (scan_words): Remove var that was set but not used.
8019 (update_syntax_table): Use unsigned instead of int.
8021 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8022 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8023 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8025 * print.c (print_error_message): Avoid int overflow.
8027 * font.c (font_list_entities): Redo for clarity,
8028 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8030 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8031 (font_score): Avoid potential overflow in diff calculation.
8033 * fns.c (substring_both): Remove var that is set but not used.
8034 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8036 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8038 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8039 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8040 can always succeed if overflow has undefined behavior.
8042 * search.c (boyer_moore, wordify): Remove vars set but not used.
8043 (wordify): Omit three unnecessary tests.
8045 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8046 All callers changed. This avoids the need for an unused var.
8048 * casefiddle.c (casify_region): Remove var that is set but not used.
8050 * dired.c (file_name_completion): Remove var that is set but not used.
8052 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8054 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8055 (Finsert_file_contents): Remove unnecessary code checking fd.
8057 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8058 Check for integer overflow on size calculations.
8060 * buffer.c (Fprevious_overlay_change): Remove var that is set
8063 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8064 Remove vars that are set but not used.
8065 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8066 (timer_check_2): Mark vars as initialized.
8068 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8070 * image.c (lookup_image): Remove var that is set but not used.
8071 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8073 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8074 that are set but not used.
8076 * xfns.c (make_invisible_cursor): Don't return garbage
8077 if XCreateBitmapFromData fails (Bug#8410).
8079 * xselect.c (x_get_local_selection, x_handle_property_notify):
8080 Remove vars that are set but not used.
8082 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8083 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8085 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8086 Remove var that is set but not used.
8087 (scroll_bar_windows_size): Now size_t, not int.
8088 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8091 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8092 (map_tty_color) [!defined MSDOS]: Likewise.
8094 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8096 * coding.c: Remove vars that are set but not used.
8097 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8098 All callers changed.
8099 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8100 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8101 (decode_coding_charset): Remove vars that are set but not used.
8103 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8104 that is set but not used.
8106 * print.c (print_object): Remove var that is set but not used.
8108 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8109 The gnulib version avoids calling malloc in the usual case,
8110 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8111 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8112 * filelock.c (current_lock_owner): Likewise.
8113 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8114 * sysdep.c: Include allocator.h, careadlinkat.h.
8115 (emacs_no_realloc_allocator): New static constant.
8116 (emacs_readlink): New function.
8117 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8118 ../lib/careadlinkat.h.
8120 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8122 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8123 first non-nil return value).
8125 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8127 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8128 if not defined (Bug#8403).
8130 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8132 * xdisp.c (display_count_lines): Remove parameter `start',
8133 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8134 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8135 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8136 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8137 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8138 and thereabouts. All callers changed.
8139 (get_per_char_metric): Remove parameter `f', unused since
8140 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8142 2011-04-02 Jim Meyering <meyering@redhat.com>
8144 do not dereference NULL upon failed strdup
8145 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8146 (ns_get_family): Likewise.
8148 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8150 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8152 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8154 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8157 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8159 Add lexical binding.
8161 * window.c (Ftemp_output_buffer_show): New fun.
8162 (Fsave_window_excursion):
8163 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8165 * lread.c (lisp_file_lexically_bound_p): New function.
8166 (Fload): Bind Qlexical_binding.
8167 (readevalloop): Remove `evalfun' arg.
8168 Bind Qinternal_interpreter_environment.
8169 (Feval_buffer): Bind Qlexical_binding.
8170 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8172 (syms_of_lread): Declare `lexical-binding'.
8174 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8176 * keyboard.c (eval_dyn): New fun.
8177 (menu_item_eval_property): Use it.
8179 * image.c (parse_image_spec): Use Ffunctionp.
8181 * fns.c (concat, mapcar1): Accept byte-code-functions.
8183 * eval.c (Fsetq): Handle lexical vars.
8184 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8185 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8186 (FletX, Flet): Obey lexical binding.
8187 (Fcommandp): Handle closures.
8188 (Feval): New `lexical' arg.
8189 (eval_sub): New function extracted from Feval. Use it almost
8190 everywhere where Feval was used. Look up vars in lexical env.
8192 (Ffunctionp): Move from subr.el.
8193 (Ffuncall): Handle closures.
8194 (apply_lambda): Remove `eval_flags'.
8195 (funcall_lambda): Handle closures and new byte-code-functions.
8196 (Fspecial_variable_p): New function.
8197 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8198 but without exporting it to Lisp.
8200 * doc.c (Fdocumentation, store_function_docstring):
8201 * data.c (Finteractive_form): Handle closures.
8203 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8206 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8208 (exec_byte_code): New function extracted from Fbyte_code to handle new
8209 calling convention for byte-code-functions. Add new byte-codes.
8211 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8213 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8215 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8217 * xdisp.c (redisplay_internal): Fix prototype.
8219 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8221 * xdisp.c (SCROLL_LIMIT): New macro.
8222 (try_scrolling): Use it when setting scroll_limit.
8223 Limit scrolling to 100 screen lines.
8224 (redisplay_window): Even when falling back on "recentering",
8225 position point in the window according to scroll-conservatively,
8226 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8228 (try_scrolling): When point is above the window, allow searching
8229 as far as scroll_max, or one screenful, to compute vertical
8230 distance from PT to the scroll margin position. This prevents
8231 try_scrolling from unnecessarily failing when
8232 scroll-conservatively is set to a value slightly larger than the
8233 window height. Clean up the case of PT below the margin at bottom
8234 of window: scroll_max can no longer be INT_MAX. When aggressive
8235 scrolling is in use, don't let point enter the opposite scroll
8236 margin as result of the scroll.
8237 (syms_of_xdisp) <scroll-conservatively>: Document the
8238 threshold of 100 lines for never-recentering scrolling.
8240 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8242 * dispextern.h (move_it_by_lines):
8243 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8244 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8245 (message_log_check_duplicate): Remove parameters `prev_bol' and
8246 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8247 (redisplay_internal): Remove parameter `preserve_echo_area',
8248 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8250 * indent.c (Fvertical_motion):
8251 * window.c (window_scroll_pixel_based, Frecenter):
8252 Don't pass `need_y_p' to `move_it_by_lines'.
8254 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8256 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8257 steal a few bits to be more compact.
8258 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8259 Remove unneeded casts.
8261 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8263 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8265 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8266 binding" message (bug#7967).
8268 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8270 Fix more problems found by GCC 4.6.0's static checks.
8272 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8273 Remove unused local var.
8275 * editfns.c (Fmessage_box): Remove unused local var.
8277 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8278 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8279 Omit unused local vars.
8280 * window.c (shrink_windows): Omit unused local var.
8281 * menu.c (digest_single_submenu): Omit unused local var.
8282 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8283 Omit unused local var.
8285 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8286 Don't assume string length fits in int.
8287 (keyremap_step, read_key_sequence): Use size_t for sizes.
8288 (read_key_sequence): Don't check last_real_key_start redundantly.
8290 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8291 instead of alloca (Bug#8344).
8293 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8294 (Fbacktrace_frame): Don't assume nframes fits in int.
8296 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8298 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8301 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8303 * cm.c (calccost): Turn while-do into do-while, for clarity.
8305 * keyboard.c (syms_of_keyboard): Use the same style as later
8306 in this function when indexing through an array. This also
8307 works around GCC bug 48267.
8309 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8311 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8313 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8314 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8316 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8317 This avoids undefined behavior on integer overflow, and is a bit
8318 more convenient anyway since it is compared to a size_t variable.
8320 Variadic C functions now count arguments with size_t, not int.
8321 This avoids an unnecessary limitation on 64-bit machines, which
8322 caused (substring ...) to crash on large vectors (Bug#8344).
8323 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8324 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8325 All variadic functions and their callers changed accordingly.
8326 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8327 * data.c (arith_driver, float_arith_driver): Likewise.
8328 * editfns.c (general_insert_function): Likewise.
8329 * eval.c (struct backtrace.nargs, interactive_p)
8330 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8331 (funcall_lambda, mark_backtrace): Likewise.
8332 * fns.c (concat): Likewise.
8333 * frame.c (x_set_frame_parameters): Likewise.
8334 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8335 0 if not found, not -1. All callers changed.
8337 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8338 (stack_copy_size): Now size_t, not int.
8339 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8341 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8343 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8344 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8345 All callers changed.
8347 * lisp.h (multibyte_char_to_unibyte):
8348 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8349 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8350 * character.h (CHAR_TO_BYTE8):
8351 * cmds.c (internal_self_insert):
8352 * editfns.c (general_insert_function):
8353 * keymap.c (push_key_description):
8354 * search.c (Freplace_match):
8355 * xdisp.c (message_dolog, set_message_1): All callers changed.
8357 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8359 * keyboard.c (safe_run_hook_funcall): New function.
8360 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8361 don't set the hook to nil, but remove the offending function instead.
8362 (Qcommand_hook_internal): Remove, unused.
8363 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8364 Vcommand_hook_internal.
8366 * eval.c (enum run_hooks_condition): Remove.
8367 (funcall_nil, funcall_not): New functions.
8368 (run_hook_with_args): Call each function through a `funcall' argument.
8369 Remove `cond' argument, now redundant.
8370 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8371 (Frun_hook_with_args_until_failure): Adjust accordingly.
8372 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8374 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8376 * dispextern.h (string_buffer_position): Remove declaration.
8378 * print.c (strout): Remove parameter `multibyte', unused since
8379 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8381 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8382 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8383 All callers changed.
8385 * w32.c (_wsa_errlist): Use braces for struct initializers.
8387 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8388 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8389 All callers changed.
8390 (string_buffer_position): Likewise. Also, make static (it's never
8391 used outside xdisp.c).
8392 (cursor_row_p): Remove parameter `w', unused since
8393 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8394 (decode_mode_spec): Remove parameter `precision', introduced during
8395 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8396 All callers changed.
8398 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8400 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8402 2011-03-27 Anders Lindgren <andlind@gmail.com>
8404 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8405 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8406 (ns_update_auto_hide_menu_bar): New functions.
8407 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8408 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8409 ns_constrain_all_frames.
8410 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8411 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8413 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8415 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8417 2011-03-27 Glenn Morris <rgm@gnu.org>
8419 * syssignal.h: Replace RETSIGTYPE with void.
8420 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8421 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8422 Replace SIGTYPE with void everywhere.
8423 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8424 * s/template.h (SIGTYPE): Remove commented out definition.
8426 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8428 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8429 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8431 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8433 * w32.c (read_unc_volume): Use parameter `henum', instead of
8434 global variable `wget_enum_handle'.
8436 * keymap.c (describe_vector): Remove parameters `indices' and
8437 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8438 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8440 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8442 * keyboard.c (timer_check): Remove parameter `do_it_now',
8443 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8444 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8445 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8447 * keyboard.c (read_char):
8448 * w32menu.c (w32_menu_display_help):
8449 * xmenu.c (show_help_event, menu_help_callback):
8450 Adjust calls to `show_help_echo'.
8452 * gtkutil.c (xg_maybe_add_timer):
8453 * keyboard.c (readable_events):
8454 * process.c (wait_reading_process_output):
8455 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8457 * insdel.c (adjust_markers_gap_motion):
8458 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8459 (gap_left, gap_right): Don't call it.
8461 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8463 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8464 incurred during fontification.
8466 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8468 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8469 (DEFVAR_PER_BUFFER): Don't pass it.
8471 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8472 (scrolling_window): Don't pass it.
8474 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8476 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8478 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8480 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8481 of variables specific to SELinux and computation of `encoded_absname'.
8483 * image.c (XPutPixel): Remove unused variable `height'.
8485 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8487 * unexw32.c (get_section_info): Remove unused variable `section'.
8489 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8490 (system_process_attributes): Remove unused variable `sess'.
8491 (sys_read): Remove unused variable `err'.
8493 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8494 (w32_wnd_proc): Remove unused variable `isdead'.
8495 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8496 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8497 (x_create_tip_frame): Remove unused variable `tem'.
8499 * w32inevt.c (w32_console_read_socket):
8500 Remove unused variable `no_events'.
8502 * w32term.c (x_draw_composite_glyph_string_foreground):
8503 Remove unused variable `width'.
8505 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8507 * w32term.c (x_set_glyph_string_clipping):
8508 Don't pass uninitialized region to CombineRgn.
8510 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8512 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8513 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8514 (Fx_close_connection): Remove unused variable `i'.
8516 * w32font.c (w32font_draw): Return number of glyphs.
8517 (w32font_open_internal): Remove unused variable `i'.
8518 (w32font_driver): Add missing initializer.
8520 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8521 (fill_in_menu): Remove unused variable `items_added'.
8523 * w32term.c (last_mouse_press_frame): Remove static global variable.
8524 (w32_clip_to_row): Remove unused variable `f'.
8525 (x_delete_terminal): Remove unused variable `i'.
8527 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8528 (NOTHING): Remove unused static global variable.
8529 (uniscribe_check_otf): Remove unused variable `table'.
8530 (uniscribe_font_driver): Add missing initializers.
8532 2011-03-23 Julien Danjou <julien@danjou.info>
8534 * term.c (Fsuspend_tty, Fresume_tty):
8535 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8536 * window.c (temp_output_buffer_show):
8537 * insdel.c (signal_before_change):
8538 * frame.c (Fhandle_switch_frame):
8539 * fileio.c (Fdo_auto_save):
8540 * emacs.c (Fkill_emacs):
8541 * editfns.c (save_excursion_restore):
8542 * cmds.c (internal_self_insert):
8543 * callint.c (Fcall_interactively):
8544 * buffer.c (Fkill_all_local_variables):
8545 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8547 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8548 unconditionally since it does the check itself.
8550 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8552 Fix more problems found by GCC 4.5.2's static checks.
8554 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8555 the first time through the loop, since we know p0 < p1 then.
8556 This also avoids a gcc -Wstrict-overflow warning.
8558 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8559 leading to a memory leak, possible in functions like
8560 load_charset_map_from_file that can allocate an unbounded number
8561 of objects (Bug#8318).
8563 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8564 that could (at least in theory) be that large.
8566 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8567 This is less likely to overflow, and avoids undefined behavior if
8568 overflow does occur. All callers changed. Use strtoul to scan
8569 for the unsigned long integer.
8570 (pint2hrstr): Simplify and tune code slightly.
8571 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8573 * scroll.c (do_scrolling): Work around GCC bug 48228.
8574 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8576 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8577 This also avoids a warning with gcc -Wstrict-overflow.
8578 (validate_x_resource_name): Simplify count usage.
8579 This also avoids a warning with gcc -Wstrict-overflow.
8581 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8584 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8586 * process.c (Fmake_network_process): Use socklen_t, not int,
8587 where POSIX says socklen_t is required in portable programs.
8588 This fixes a porting bug on hosts like 64-bit HP-UX, where
8589 socklen_t is wider than int (Bug#8277).
8590 (Fmake_network_process, server_accept_connection):
8591 (wait_reading_process_output, read_process_output):
8594 * process.c: Rename or move locals to avoid shadowing.
8595 (list_processes_1, Fmake_network_process):
8596 (read_process_output_error_handler, exec_sentinel_error_handler):
8597 Rename or move locals.
8598 (Fmake_network_process): Define label "retry_connect" only if needed.
8599 (Fnetwork_interface_info): Fix pointer signedness.
8600 (process_send_signal): Add cast to avoid pointer signedness problem.
8601 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8602 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8604 Make tparam.h and terminfo.c consistent.
8605 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8606 Include tparam.h instead, since it declares them.
8607 * cm.h (PC): Remove extern decl; tparam.h now does this.
8608 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8609 * terminfo.c: Include tparam.h, to check interfaces.
8610 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8611 (tparam): Adjust signature to match interface in tparam.h;
8612 this removes some undefined behavior. Check that outstring and len
8613 are zero, which they always are with Emacs.
8614 * tparam.h (PC, BC, UP): New extern decls.
8616 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8617 (xftfont_open): Rename locals to avoid shadowing.
8619 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8620 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8621 (OTF_TAG_SYM): Omit macro if not needed.
8622 (ftfont_list): Remove unused local.
8623 (get_adstyle_property, ftfont_pattern_entity):
8624 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8625 Rename locals to avoid shadowing.
8627 * xfont.c (xfont_list_family): Mark var as initialized.
8629 * xml.c (make_dom): Now static.
8631 * composite.c (composition_compute_stop_pos): Rename local to
8633 (composition_reseat_it): Remove unused locals.
8634 (find_automatic_composition, composition_adjust_point): Likewise.
8635 (composition_update_it): Mark var as initialized.
8636 (find_automatic_composition): Mark vars as initialized,
8637 with a FIXME (Bug#8290).
8639 character.h: Rename locals to avoid shadowing.
8640 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8641 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8642 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8643 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8646 * textprop.c (property_change_between_p): Remove; unused.
8648 * intervals.c (interval_start_pos): Now static.
8650 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8652 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8653 Rename locals to avoid shadowing.
8655 * sound.c (wav_play, au_play, Fplay_sound_internal):
8656 Fix pointer signedness.
8657 (alsa_choose_format): Remove unused local var.
8658 (wav_play): Initialize a variable to 0, to prevent undefined
8659 behavior (Bug#8278).
8661 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8663 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8665 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8666 clobbering (Bug#8298).
8667 * sysdep.c (sys_subshell): Likewise.
8668 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8670 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8671 This should get cleaned up, so that child_setup has the
8672 same signature on all platforms.
8674 * callproc.c (call_process_cleanup): Now static.
8675 (relocate_fd): Rename locals to avoid shadowing.
8677 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8679 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8680 not to be necessary, and produces flickering.
8682 2011-03-20 Glenn Morris <rgm@gnu.org>
8684 * config.in: Remove file.
8686 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8688 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8689 are now in src/globals.h.
8690 (syms_of_minibuf): Remove spurious & from previous change.
8692 2011-03-20 Leo Liu <sdl.web@gmail.com>
8694 * minibuf.c (completing-read-function): New variable.
8695 (completing-read-default): Rename from completing-read.
8696 (completing-read): Call completing-read-function.
8698 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8700 * xfaces.c (Fx_load_color_file):
8701 Read color file from absolute filename (bug#8250).
8703 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8705 * makefile.w32-in: Update dependencies.
8707 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8709 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8711 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8713 Fix more problems found by GCC 4.5.2's static checks.
8715 * process.c (make_serial_process_unwind, send_process_trap):
8716 (sigchld_handler): Now static.
8718 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8719 That way, the code declares only the vars that it needs.
8720 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8721 * s/cygwin.h (PTY_ITERATION): Likewise.
8722 * s/darwin.h (PTY_ITERATION): Likewise.
8723 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8725 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8726 * process.c (allocate_pty): Don't declare stb unless it's needed.
8728 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8729 (CONSTANTLIM): Remove; unused.
8730 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8731 Define only if needed.
8733 * unexelf.c (unexec): Name an expression,
8734 to avoid gcc -Wbad-function-cast warning.
8735 Use a different way to cause a compilation error if anyone uses
8736 n rather than nn, a way that does not involve shadowing.
8737 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8739 * deps.mk (unexalpha.o): Remove; unused.
8741 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8742 * unexec.h: New file.
8743 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8744 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8746 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8747 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8748 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8749 Change as necessary to match prototype in unexec.h.
8751 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8753 (back_comment, skip_chars): Mark vars as initialized.
8755 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8756 Rename locals to avoid shadowing.
8758 * lread.c (read1): Rewrite so as not to use empty "else".
8759 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8761 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8763 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8764 warning when compiling print.c.
8766 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8767 instead of using an uninitialized var.
8768 (font_sort_entities): Mark var as initialized.
8770 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8772 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8773 pointers to constants.
8774 (font_parse_fcname): Remove unused vars.
8775 (font_delete_unmatched): Now static.
8776 (font_get_spec): Remove; unused.
8777 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8778 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8779 Rename or move locals to avoid shadowing.
8781 * fns.c (require_nesting_list, require_unwind): Now static.
8782 (Ffillarray): Rename locals to avoid shadowing.
8784 * floatfns.c (domain_error2): Define only if needed.
8785 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8787 * alloc.c (mark_backtrace): Move decl from here ...
8788 * lisp.h: ... to here, so that it can be checked.
8790 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8791 (Fdefvar): Rewrite so as not to use empty "else".
8792 (lisp_indirect_variable): Name an expression,
8793 to avoid gcc -Wbad-function-cast warning.
8794 (Fdefvar): Rename locals to avoid shadowing.
8796 * callint.c (quotify_arg, quotify_args): Now static.
8797 (Fcall_interactively): Rename locals to avoid shadowing.
8798 Use const pointer when appropriate.
8800 * lisp.h (get_system_name, get_operating_system_release):
8801 Move decls here, to check interfaces.
8802 * process.c (get_operating_system_release): Move decl to lisp.h.
8803 * xrdb.c (get_system_name): Likewise.
8804 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8805 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8806 some of which prompt warnings from gcc -Wbad-function-cast.
8807 (Fformat_time_string, Fencode_time, Finsert_char):
8808 (Ftranslate_region_internal, Fformat):
8809 Rename or remove local vars to avoid shadowing.
8810 (Ftranslate_region_internal): Mark var as initialized.
8812 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8815 * lisp.h (eassert): Check that the argument compiles, even if
8816 ENABLE_CHECKING is not defined.
8818 * data.c (Findirect_variable): Name an expression, to avoid
8819 gcc -Wbad-function-cast warning.
8820 (default_value, arithcompare, arith_driver, arith_error): Now static.
8821 (store_symval_forwarding): Rename local to avoid shadowing.
8822 (Fmake_variable_buffer_local, Fmake_local_variable):
8823 Mark variables as initialized.
8824 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8826 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8827 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8828 Rename locals to avoid shadowing.
8829 (mark_stack): Move local variables into the #ifdef region where
8831 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8832 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8834 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8835 (GC_STRING_CHARS): Remove; not used.
8836 (Fmemory_limit): Cast sbrk's returned value to char *.
8838 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8839 avoids undefined behavior in theory.
8841 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8843 Use functions, not macros, for up- and down-casing (Bug#8254).
8844 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8845 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8846 to use the following functions instead of these macros.
8847 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8848 EMACS_INT, since callers assume the returned value fits in int.
8849 (upcase1): Likewise, for UPCASE_TABLE.
8850 (uppercasep, lowercasep, upcase): New static inline functions.
8851 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8852 the race-condition problem in the old DOWNCASE.
8854 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8855 Rename locals to avoid shadowing.
8856 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8857 (regex_compile, re_search_2, re_match_2_internal):
8858 Remove unused local vars.
8859 (FREE_VAR): Rewrite so as not to use empty "else",
8860 which gcc can warn about.
8861 (regex_compile, re_match_2_internal): Mark locals as initialized.
8862 (RETALLOC_IF): Define only if needed.
8863 (WORDCHAR_P): Likewise. This one is never needed, but is used
8864 only in a comment talking about a compiler bug, so put inside
8865 the #if 0 of that comment.
8866 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8867 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8870 * search.c (boyer_moore): Rename locals to avoid shadowing.
8871 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8872 (PREV_CHAR_BOUNDARY): Likewise.
8874 * search.c (simple_search): Remove unused var.
8876 * dired.c (compile_pattern): Move decl from here ...
8877 * lisp.h: ... to here, so that it can be checked.
8878 (struct re_registers): New forward decl.
8880 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8882 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8884 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8885 Rename locals to avoid shadowing.
8886 (Fvertical_motion): Mark locals as initialized.
8888 * casefiddle.c (casify_object, casify_region): Now static.
8889 (casify_region): Mark local as initialized.
8891 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8893 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8894 New macros, so that the caller can use some names other than
8895 gcpro1, gcpro2, etc.
8896 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8898 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8899 argument, for consistency with GCPRO2_VAR, etc: it is now the
8900 prefix of the variable, not the variable itself. All uses
8902 * dired.c (directory_files_internal, file_name_completion):
8903 Rename locals to avoid shadowing.
8905 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8906 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8907 dired.c's scmp function, had undefined behavior.
8908 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8909 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8910 * buffer.h: ... to here, because these macros use current_buffer,
8911 and the new implementation with inline functions needs to have
8912 current_buffer in scope now, rather than later when the macros
8914 (downcase, upcase1): New static inline functions.
8915 (DOWNCASE, UPCASE1): Reimplement using these functions.
8916 This avoids undefined behavior in expressions like
8917 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8918 from race conditions in accessing the global variables
8919 case_temp1 and case_temp2.
8920 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8921 * lisp.h (case_temp1, case_temp2): Remove their decls.
8922 * character.h (ASCII_CHAR_P): Move from here ...
8923 * lisp.h: ... to here, so that the inline functions mentioned
8926 * dired.c (directory_files_internal_unwind): Now static.
8928 * fileio.c (file_name_as_directory, directory_file_name):
8929 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8931 (file_name_as_directory): Use const pointers when appropriate.
8932 (Fexpand_file_name): Likewise. In particular, newdir might
8933 point at constant storage, so make it a const pointer.
8934 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8935 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8937 (Fset_file_times, Finsert_file_contents, auto_save_error):
8938 Rename locals to avoid shadowing.
8940 * minibuf.c (choose_minibuf_frame_1): Now static.
8941 (Ftry_completion, Fall_completions): Rename or remove locals
8944 * marker.c (bytepos_to_charpos): Remove; unused.
8946 * lisp.h (verify_bytepos, count_markers): New decls,
8947 so that gcc does not warn that these functions aren't declared.
8949 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8950 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8951 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8952 (copy_text): Remove unused local var.
8954 * filelock.c (within_one_second): Now static.
8955 (lock_file_1): Rename local to avoid shadowing.
8957 * buffer.c (fix_overlays_before): Mark locals as initialized.
8958 (fix_start_end_in_overlays): Likewise. This function should be
8959 simplified by using pointers-to-pointers, but that's a different
8961 (switch_to_buffer_1): Now static.
8962 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8963 (report_overlay_modification): Rename locals to avoid shadowing.
8965 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8966 Fix pointer signedness issue.
8967 (sys_subshell): Mark local as volatile if checking for lint,
8968 to suppress a gcc -Wclobbered warning that does not seem to be right.
8969 (MAXPATHLEN): Define only if needed.
8971 * process.c (serial_open, serial_configure): Move decls from here ...
8972 * systty.h: ... to here, so that they can be checked.
8974 * fns.c (get_random, seed_random): Move extern decls from here ...
8975 * lisp.h: ... to here, so that they can be checked.
8977 * sysdep.c (reset_io): Now static.
8978 (wait_for_termination_signal): Remove; unused.
8980 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8981 (copy_keymap_item, append_key, push_text_char_description):
8983 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8984 (DENSE_TABLE_SIZE): Remove; unused.
8985 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8986 (describe_map_tree):
8987 Rename locals to avoid shadowing.
8989 * keyboard.c: Declare functions static if they are not used elsewhere.
8990 (echo_char, echo_dash, cmd_error, top_level_2):
8991 (poll_for_input, handle_async_input): Now static.
8992 (read_char, kbd_buffer_get_event, make_lispy_position):
8993 (make_lispy_event, make_lispy_movement, apply_modifiers):
8994 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8995 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8996 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8997 (read_key_sequence, read_char): Mark locals as initialized.
8998 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9000 * keyboard.h (make_ctrl_char): New decl.
9001 (mark_kboards): Move decl here ...
9002 * alloc.c (mark_kboards): ... from here.
9004 * lisp.h (force_auto_save_soon): New decl.
9006 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9007 (DEFINE_DUMMY_FUNCTION): New macro.
9008 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9010 (main): Add casts to avoid warnings
9011 if GCC considers string literals to be constants.
9013 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9015 * dbusbind.c: Pointer signedness fixes.
9016 (xd_signature, xd_append_arg, xd_initialize):
9017 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9018 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9019 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9020 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9022 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9023 if GCC considers string literals to be constants.
9024 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9026 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9028 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9029 (print_preprocess, print_object): New macro to fix last change.
9031 * print.c (print_preprocess): Don't forget font objects.
9033 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9035 * emacs.c (USAGE3): Doc fixes.
9037 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9039 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9042 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9044 * lisp.h (VWindow_system, Qfile_name_history):
9045 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9046 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9047 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9049 * w32select.c: Don't #include "keyboard.h".
9050 (run_protected): Add extern declaration for waiting_for_input.
9052 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9053 * w32console.c (detect_input_pending, read_input_pending)
9054 (encode_terminal_code):
9055 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9056 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9057 (w32_system_caret_y, Qfile_name_history):
9058 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9059 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9060 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9061 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9062 * w32proc.c (Qlocal, report_file_error):
9063 * w32term.c (Vwindow_system, updating_frame):
9064 * w32uniscribe.c (initialized, uniscribe_font_driver):
9065 Remove unneeded extern declarations.
9067 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9069 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9071 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9073 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9074 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9075 These macros can no longer be used for assignment.
9077 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9078 Assign struct members directly, instead of using BUF_BEGV etc.
9079 (record_buffer_markers, fetch_buffer_markers): New functions for
9080 recording and fetching special buffer markers.
9081 (set_buffer_internal_1, set_buffer_temp): Use them.
9083 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9085 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9087 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9088 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9090 * xdisp.c (hscroll_window_tree):
9091 (reconsider_clip_changes): Use PT instead of BUF_PT.
9093 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9095 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9096 $(EMACS_ROOT)/lib/intprops.h.
9098 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9100 Fix more problems found by GCC 4.5.2's static checks.
9102 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9103 to unsigned char * to avoid compiler diagnostic.
9104 (xg_free_frame_widgets): Make it clear that a local variable is
9105 needed only if USE_GTK_TOOLTIP.
9106 (gdk_window_get_screen): Make it clear that this macro is needed
9107 only if USE_GTK_TOOLTIP.
9108 (int_gtk_range_get_value): New function, which avoids a diagnostic
9109 from gcc -Wbad-function-cast.
9110 (xg_set_toolkit_scroll_bar_thumb): Use it.
9111 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9112 diagnostic from gcc -Wbad-function-cast.
9113 (get_utf8_string, xg_get_file_with_chooser):
9114 Rename locals to avoid shadowing.
9115 (create_dialog): Move locals to avoid shadowing.
9117 * xgselect.c (xg_select): Remove unused var.
9119 * image.c (four_corners_best): Mark locals as initialized.
9120 (gif_load): Initialize transparent_p to zero (Bug#8238).
9121 Mark another local as initialized.
9122 (my_png_error, my_error_exit): Mark with NO_RETURN.
9124 * image.c (clear_image_cache): Now static.
9125 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9126 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9127 (x_edge_detection): Remove unnecessary cast that
9128 gcc -Wbad-function-cast diagnoses.
9129 (gif_load): Fix pointer signedness.
9130 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9131 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9133 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9135 Improve quality of tests for time stamp overflow.
9136 For example, without this patch (encode-time 0 0 0 1 1
9137 1152921504606846976) returns the obviously-bogus value (-948597
9138 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9139 reports time overflow. See
9140 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9141 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9142 * editfns.c: Include limits.h and intprops.h.
9143 (TIME_T_MIN, TIME_T_MAX): New macros.
9144 (time_overflow): Move earlier, to before first use.
9145 (hi_time, lo_time): New functions, for an accurate test for
9147 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9148 (Fget_internal_run_time): Don't assume time_t fits in int.
9149 (make_time): Use list2 instead of Fcons twice.
9150 (Fdecode_time): More accurate test for out-of-range times.
9151 (check_tm_member): New function.
9152 (Fencode_time): Use it, to test for out-of-range times.
9153 (lisp_time_argument): Don't rely on undefined left-shift and
9154 right-shift behavior when checking for time stamp overflow.
9156 * editfns.c (time_overflow): New function, refactoring common code.
9157 (Fformat_time_string, Fdecode_time, Fencode_time):
9158 (Fcurrent_time_string): Use it.
9160 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9161 * dired.c (make_time): Move to ...
9162 * editfns.c (make_time): ... here.
9163 * systime.h: Note the move.
9165 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9167 * fringe.c (update_window_fringes): Remove unused variables.
9169 * unexmacosx.c (copy_data_segment): Also copy __got section.
9172 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9174 * termcap.c [MSDOS]: Include "msdos.h".
9175 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9176 Constify `char *' arguments and their references according to
9177 prototypes in tparam.h.
9179 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9181 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9182 Adapt all references accordingly.
9184 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9186 2011-03-11 Tom Tromey <tromey@redhat.com>
9188 * buffer.c (syms_of_buffer): Remove obsolete comment.
9190 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9192 * termhooks.h (encode_terminal_code): Declare prototype.
9194 * msdos.c (encode_terminal_code): Don't declare prototype.
9196 * term.c (encode_terminal_code): Now external again, used by
9197 w32console.c and msdos.c.
9199 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9200 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9202 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9204 Fix some minor problems found by GCC 4.5.2's static checks.
9206 * fringe.c (update_window_fringes): Mark locals as initialized
9208 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9210 * alloc.c (mark_fringe_data): Move decl from here ...
9211 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9212 to check its interface.
9213 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9215 * fontset.c (free_realized_fontset): Now static.
9216 (Fset_fontset_font): Rename local to avoid shadowing.
9217 (fontset_font): Mark local as initialized.
9218 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9220 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9222 * xselect.c (x_disown_buffer_selections): Remove; not used.
9223 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9224 (x_own_selection, Fx_disown_selection_internal): Rename locals
9226 (x_handle_dnd_message): Remove local to avoid shadowing.
9228 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9229 so that the caller can use some name other than gcpro1.
9230 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9231 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9232 (Fx_backspace_delete_keys_p):
9233 Use them to avoid shadowing, and rename vars to avoid shadowing.
9234 (x_decode_color, x_set_name, x_window): Now static.
9235 (Fx_create_frame): Add braces to silence GCC warning.
9236 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9237 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9238 Remove unused locals.
9239 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9240 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9241 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9244 * xterm.h (x_mouse_leave): New decl.
9246 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9247 Remove unused functions.
9248 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9249 (x_calc_absolute_position): Now static.
9250 (XTread_socket): Don't define label "out" unless it's used.
9251 Don't declare local "event" unless it's used.
9252 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9253 unless they are used.
9254 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9255 (x_fatal_error_signal): Remove; not used.
9256 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9257 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9258 (x_error_catcher, x_connection_closed, x_error_handler):
9259 (x_error_quitter, xembed_send_message, x_iconify_frame):
9260 (my_log_handler): Rename locals to avoid shadowing.
9261 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9262 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9264 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9265 Rename or move locals to avoid shadowing.
9266 (tty_defined_color, merge_face_heights): Now static.
9267 (free_realized_faces_for_fontset): Remove; not used.
9268 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9269 does not deduce is never used uninitialized.
9270 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9271 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9273 * terminal.c (store_terminal_param): Now static.
9275 * xmenu.c (menu_highlight_callback): Now static.
9276 (set_frame_menubar): Remove unused local.
9277 (xmenu_show): Rename parameter to avoid shadowing.
9278 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9279 since they might point to immutable storage.
9280 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9281 since it's unused otherwise.
9283 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9284 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9285 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9286 avoids a gcc -Wuninitialized diagnostic.
9287 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9288 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9289 does not deduce are never used uninitialized.
9291 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9293 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9294 * window.c (window_loop, size_window):
9295 (run_window_configuration_change_hook, enlarge_window): Likewise.
9297 * window.c (display_buffer): Now static.
9298 (size_window): Mark variables that gcc -Wuninitialized
9299 does not deduce are never used uninitialized.
9300 * window.h (check_all_windows): New decl, to forestall
9301 gcc -Wmissing-prototypes diagnostic.
9302 * dispextern.h (bidi_dump_cached_states): Likewise.
9304 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9306 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9308 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9309 and to avoid gcc -Wuninitialized warning.
9310 (load_charset_map): Mark variables that gcc -Wuninitialized
9311 does not deduce are never used uninitialized.
9312 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9314 * coding.c (coding_set_source, coding_set_destination):
9315 Use "else { /* comment */ }" rather than "else /* comment */;"
9316 for clarity, and to avoid gcc -Wempty-body warning.
9317 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9318 a block, when the outer 'i' will do.
9319 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9320 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9321 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9322 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9323 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9324 Rename locals to avoid shadowing.
9325 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9326 * coding.c (emacs_mule_char, encode_invocation_designation):
9327 Now static, since they're not used elsewhere.
9328 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9329 (decode_coding_object, encode_coding_object, detect_coding_system):
9330 (decode_coding_emacs_mule): Mark variables that gcc
9331 -Wuninitialized does not deduce are never used uninitialized.
9332 (detect_coding_iso_2022): Initialize a local variable that might
9333 be used uninitialized. Leave a FIXME because it's not clear that
9334 this initialization is needed. (Bug#8211)
9335 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9336 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9337 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9338 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9339 Remove unused macros.
9341 * category.c (hash_get_category_set): Remove unused local var.
9342 (copy_category_table): Now static, since it's not used elsewhere.
9343 * character.c (string_count_byte8): Likewise.
9345 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9346 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9348 * chartab.c (copy_sub_char_table): Now static, since it's not used
9350 (sub_char_table_ref_and_range, char_table_ref_and_range):
9351 Rename locals to avoid shadowing.
9352 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9354 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9355 (BIDI_BOB): Remove unused macro.
9357 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9358 deduce are never used uninitialized.
9359 * term.c (encode_terminal_code): Likewise.
9361 * term.c (encode_terminal_code): Now static. Remove unused local.
9363 * tparam.h: New file.
9364 * term.c, tparam.h: Include it.
9365 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9366 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9367 Move these decls to tparam.h, and make them agree with what
9368 is actually in tparam.c. The previous trick of using incompatible
9369 decls in different modules does not conform to the C standard.
9370 All callers of tparam changed to use tparam's actual API.
9371 * tparam.c (tparam1, tparam, tgoto):
9372 Use const pointers where appropriate.
9374 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9375 * cm.h (struct cm): Likewise.
9376 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9377 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9378 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9379 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9380 (turn_on_face, init_tty): Likewise.
9381 * termchar.h (struct tty_display_info): Likewise.
9383 * term.c (term_mouse_position): Rename local to avoid shadowing.
9385 * alloc.c (mark_ttys): Move decl from here ...
9386 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9388 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9390 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9392 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9394 * search.c (compile_pattern_1): Remove argument regp, unused since
9395 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9396 (compile_pattern): Don't pass it.
9398 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9400 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9401 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9403 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9405 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9407 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9408 gdk_window_get_screen, gdk_window_get_geometry,
9409 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9410 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9411 (xg_get_pixbuf_from_pixmap): New function.
9412 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9413 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9414 Call xg_get_pixbuf_from_pixmap instead of
9415 gdk_pixbuf_get_from_drawable.
9416 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9417 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9418 (xg_check_special_colors): Use GtkStyleContext and its functions
9420 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9421 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9422 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9423 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9424 Call gtk_widget_get_preferred_size.
9425 (xg_frame_resized): gdk_window_get_geometry only takes 5
9427 (xg_win_to_widget, xg_event_is_for_menubar):
9428 Call gdk_x11_window_lookup_for_display.
9429 (xg_set_widget_bg): New function.
9430 (delete_cb): New function.
9431 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9432 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9433 (xg_set_background_color): Call xg_set_widget_bg.
9434 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9435 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9436 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9437 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9439 (update_frame_tool_bar): Call gtk_widget_hide.
9440 (xg_initialize): Use GDK_KEY_g.
9442 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9444 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9446 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9447 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9448 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9450 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9452 * w32xfns.c (select_palette): Check success of RealizePalette against
9453 GDI_ERROR, not zero.
9455 See ChangeLog.11 for earlier changes.
9461 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9463 This file is part of GNU Emacs.
9465 GNU Emacs is free software: you can redistribute it and/or modify
9466 it under the terms of the GNU General Public License as published by
9467 the Free Software Foundation, either version 3 of the License, or
9468 (at your option) any later version.
9470 GNU Emacs is distributed in the hope that it will be useful,
9471 but WITHOUT ANY WARRANTY; without even the implied warranty of
9472 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9473 GNU General Public License for more details.
9475 You should have received a copy of the GNU General Public License
9476 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.