merge trunk
[bpt/emacs.git] / src / ChangeLog
1 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2
3 * dbusbind.c (Fdbus_register_signal): When service is not
4 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5
6 2011-09-25 Glenn Morris <rgm@gnu.org>
7
8 * buffer.c (truncate-lines): Doc fix.
9
10 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
11
12 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
13 (Fset_window_next_buffers): Doc fix.
14
15 2011-09-24 Glenn Morris <rgm@gnu.org>
16
17 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
18
19 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
20
21 Fix minor problems found by static checking.
22 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
23 * indent.c (Fvertical_motion): Fix == vs = typo.
24
25 2011-09-24 Eli Zaretskii <eliz@gnu.org>
26
27 * dispnew.c (syms_of_display) <redisplay-dont-pause>: Default
28 value is now t. Doc fix.
29
30 * indent.c (Fvertical_motion): Compute and apply the overshoot
31 logic when moving up, not only when moving down. Fix the
32 confusing name and values of the it_overshoot_expected variable;
33 logic changes accordingly. (Bug#9254) (Bug#9549)
34
35 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
36 CHARPOS is covered by a display string which includes newlines.
37 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
38 is covered by a display string with embedded newlines.
39
40 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
41
42 * dbusbind.c (Fdbus_register_signal): Add match rule to
43 Vdbus_registered_objects_table. (Bug#9581)
44 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
45 docstring.
46
47 2011-09-24 Jim Meyering <meyering@redhat.com>
48
49 do not ignore write error for any output size
50 The previous change was incomplete.
51 While it makes emacs --batch detect the vast majority of stdout
52 write failures, errors were still ignored whenever the output size is
53 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
54 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
55 && echo FAIL: ignored write error
56 FAIL: ignored write error
57 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
58 && echo FAIL: ignored write error
59 FAIL: ignored write error
60 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
61
62 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
63
64 * emacs.c (Fkill_emacs): In noninteractive mode exit
65 non-successfully if a write error occurred on stdout. (Bug#9574)
66
67 2011-09-21 Eli Zaretskii <eliz@gnu.org>
68
69 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
70 the xassert test.
71
72 * dispextern.h (struct it): Update the comment documenting what
73 can it->OBJECT be.
74
75 2011-09-20 Eli Zaretskii <eliz@gnu.org>
76
77 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
78 a display string, extend search for cursor position to end of row.
79 (find_row_edges): If the row ends in a newline from a display
80 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
81 Handle the case of a display string with multiple newlines.
82 (Fcurrent_bidi_paragraph_direction): Fix search for previous
83 non-empty line. Fixes confusing cursor motion with arrow keys at
84 the beginning of a line that starts with whitespace.
85
86 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
87
88 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
89 (bug#9493).
90
91 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
92
93 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
94 boolean (Bug#9154).
95
96 2011-09-18 Eli Zaretskii <eliz@gnu.org>
97
98 * xdisp.c (display_line): Record maximum and minimum buffer
99 positions even if no glyphs were produced (e.g., by a zero-width
100 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
101 buffer positions that will be removed from the glyph row because
102 they don't fit.
103 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
104 column is beyond frame width: don't subtract 1 "pixel" when
105 computing width of the stretch.
106 (reseat_at_next_visible_line_start): Undo the change made on
107 2011-09-17 that saved paragraph information and restored it after
108 the call to `reseat'. (Bug#9545)
109
110 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
111
112 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
113 and turn window cursor on if cleared (Bug#9415).
114
115 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
116
117 * search.c (boyer_moore): Take unibyte characters from pattern
118 literally. (Bug#9458)
119
120 2011-09-18 Eli Zaretskii <eliz@gnu.org>
121
122 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
123
124 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
125
126 Fix minor problem found by static checking.
127 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
128 initialized, to pacify gcc -Wuninitialized.
129
130 * fileio.c: Report proper errno when syscall falls.
131 (Finsert_file_contents): Save and restore errno,
132 so that report_file_error outputs the correct diagnostic.
133 (Fwrite_region) [CLASH_DETECTION]: Likewise.
134
135 2011-09-18 Eli Zaretskii <eliz@gnu.org>
136
137 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
138
139 2011-09-17 Eli Zaretskii <eliz@gnu.org>
140
141 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
142 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
143
144 2011-09-17 Eli Zaretskii <eliz@gnu.org>
145
146 * xdisp.c (reseat_at_next_visible_line_start): Keep information
147 about the current paragraph and restore it after the call to
148 reseat.
149
150 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
151 (bidi_find_paragraph_start): Search back for paragraph beginning
152 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
153 (bidi_move_to_visually_next): Only trigger paragraph-related
154 computations when the last character is a newline or at EOB, not
155 just any NEUTRAL_B. (Bug#9470)
156
157 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
158 truncated lines if point is covered by a display string. (Bug#9524)
159
160 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
161
162 * xselect.c: Relax test for outgoing X longs (Bug#9498).
163 (cons_to_x_long): New function.
164 (lisp_data_to_selection_data): Use it. Correct the test for
165 short-versus-long data; it was negated. Break out of vector
166 loop, for efficiency, when a long datum is discovered.
167
168 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
169
170 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
171
172 2011-09-16 Eli Zaretskii <eliz@gnu.org>
173
174 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
175 GCC PR/17406) by declaring this function with external scope.
176
177 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
178
179 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
180 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
181
182 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
183
184 * editfns.c (Fformat): Correctly handle text properties on "%%".
185
186 2011-09-15 Eli Zaretskii <eliz@gnu.org>
187
188 * xterm.c (x_draw_composite_glyph_string_foreground):
189 * w32term.c (x_draw_composite_glyph_string_foreground):
190 * term.c (encode_terminal_code):
191 * composite.c (composition_update_it, get_composition_id):
192 * xdisp.c (get_next_display_element)
193 (fill_composite_glyph_string): Add comments about special meaning
194 of TAB characters in a composition.
195
196 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
197
198 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
199 This occurs when processing a multibyte format.
200 Problem reported by Wolfgang Jenker.
201
202 2011-09-15 Johan Bockgård <bojohan@gnu.org>
203
204 * xdisp.c (try_cursor_movement): Only check for exact match if
205 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
206
207 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
208
209 Remove unused external symbols.
210 * dispextern.h (calc_pixel_width_or_height): Remove decl.
211 * xdisp.c (calc_pixel_width_or_height): Now static.
212 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
213 * indent.c (check_display_width):
214 * w32term.c: Fix comment to match code.
215 * xterm.c, xterm.h (x_catching_errors): Remove.
216
217 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
218
219 * xselect.c: Use signed conversions more consistently (Bug#9498).
220 (selection_data_to_lisp_data): Assume incoming selection data are
221 signed integers, not unsigned. This is to be consistent with
222 outgoing selection data, which was modified to use signed integers
223 in as part of the fix to Bug#9196 in response to Jan D.'s comment
224 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
225 expects long, not unsigned long.
226
227 2011-09-14 Eli Zaretskii <eliz@gnu.org>
228
229 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
230 computation of loop end. Reported by Johan Bockgård
231 <bojohan@gnu.org>.
232
233 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
234
235 * frame.c (Fother_visible_frames_p): Function deleted.
236
237 2011-09-12 Eli Zaretskii <eliz@gnu.org>
238
239 * indent.c (compute_motion): Process display vector front to back
240 rather than the other way around. (Bug#2496)
241
242 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
243
244 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
245
246 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
247
248 * minibuf.c (Fread_from_minibuffer): Doc fix.
249
250 2011-09-11 Eli Zaretskii <eliz@gnu.org>
251
252 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
253 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
254
255 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
256
257 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
258 value for non-existent files.
259
260 2011-09-11 Eli Zaretskii <eliz@gnu.org>
261
262 * fileio.c (Finsert_file_contents): If the file cannot be opened,
263 set its "size" to -1. This will set the modtime_size field of
264 the corresponding buffer to -1, which is what
265 verify-visited-file-modtime expects for files that do not exist.
266 (Bug#9139)
267
268 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
269
270 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
271 here ...
272 * lisp.h: ... from here. push_key_description is no longer
273 defined in keyboard.c, so its declaration should not be in
274 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
275 logically belongs with push_key_description.
276
277 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
278
279 * buffer.h: Include <sys/types.h> instead of <time.h>.
280 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
281 Problem reported by Herbert J. Skuhra.
282
283 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
284
285 * xml.c (parse_region): Make the parsing work for
286 non-comment-starting XML files again (bug#9144).
287
288 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
289
290 * image.c (gif_load): Fix calculation of bottom and right corner.
291 (Bug#9468)
292
293 2011-09-10 Eli Zaretskii <eliz@gnu.org>
294
295 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
296 redisplay in small windows.
297
298 2011-09-09 Eli Zaretskii <eliz@gnu.org>
299
300 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
301
302 2011-09-08 Martin Rudalics <rudalics@gmx.at>
303
304 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
305 Operate on live windows only.
306
307 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
308
309 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
310
311 2011-09-07 Eli Zaretskii <eliz@gnu.org>
312
313 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
314 only under bidi iteration.
315
316 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
317
318 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
319
320 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
321
322 isnan: Fix porting problem to Solaris 10 with bundled gcc.
323 Without this fix, the command to link temacs failed due to an
324 undefined symbol __builtin_isnan. This is because
325 /usr/include/iso/math_c99.h #defines isnan(x) to
326 __builtin_isnan(x), but the bundled gcc, which identifies itself
327 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
328 a __builtin_isnan.
329 * floatfns.c (isnan): #undef, and then #define to a clone of
330 what's in data.c.
331 (Fisnan): Always define, since it's always available now.
332 (syms_of_floatfns): Always define isnan at the Lisp level.
333
334 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
335
336 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
337
338 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
339
340 * fileio.c: Fix bugs with large file offsets (Bug#9428).
341 The previous code assumed that file offsets (off_t values) fit in
342 EMACS_INT variables, which is not true on typical 32-bit hosts.
343 The code messed up by falsely reporting buffer overflow in cases
344 such as (insert-file-contents "big" nil 1 2) into an empty buffer
345 when "big" contains more than 2**29 bytes, even though this
346 inserts just one byte and does not overflow the buffer.
347 (Finsert_file_contents): Store file offsets as off_t
348 values, not as EMACS_INT values. Check for overflow when
349 converting between EMACS_INT and off_t. When checking for
350 buffer overflow or for overlap, take the offsets into account.
351 Don't use EMACS_INT for small values where int suffices.
352 When checking for overlap, fix a typo: ZV was used where
353 ZV_BYTE was intended.
354 (Fwrite_region): Don't assume off_t fits into 'long'.
355 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
356
357 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
358
359 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
360
361 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
362
363 sprintf-related integer and memory overflow issues (Bug#9412).
364
365 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
366 (esprintf, exprintf, evxprintf): New functions.
367 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
368 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
369 (modify_event_symbol): Do not assume that the length of
370 name_alist_or_stem is safe to alloca and fits in int.
371 (Fexecute_extended_command): Likewise for function name and binding.
372 (Frecursion_depth): Wrap around reliably on integer overflow.
373 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
374 since some callers pass EMACS_INT values.
375 (Fsingle_key_description): Don't crash if symbol name contains more
376 than MAX_ALLOCA bytes.
377 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
378 (get_minibuffer): Arg is now EMACS_INT, not int.
379 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
380 (esprintf, exprintf, evxprintf): New decls.
381 * window.h (command_loop_level, minibuf_level): Reflect API changes.
382
383 * dbusbind.c (signature_cat): New function.
384 (xd_signature, Fdbus_register_signal):
385 Do not overrun buffer; instead, report string overflow.
386
387 * dispnew.c (add_window_display_history): Don't overrun buffer.
388 Truncate instead; this is OK since it's just a log.
389
390 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
391 even if the time zone offset is outlandishly large.
392 Don't mishandle offset == INT_MIN.
393
394 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
395 when creating daemon; the previous buffer-overflow check was incorrect.
396
397 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
398 which has the guts of the old verror function.
399
400 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
401 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
402
403 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
404 (font_unparse_xlfd): Don't blindly alloca long strings.
405 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
406 fits in int, when using sprintf. Use single snprintf to count
407 length of string rather than counting it via multiple sprintfs;
408 that's simpler and more reliable.
409 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
410 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
411 sprintf, in case result does not fit in int.
412
413 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
414 (fontset_from_font): Print it.
415
416 * frame.c (tty_frame_count): Now printmax_t, not int.
417 (make_terminal_frame, set_term_frame_name): Print it.
418 (x_report_frame_params): In X, window IDs are unsigned long,
419 not signed long, so print them as unsigned.
420 (validate_x_resource_name): Check for implausibly long names,
421 and don't assume name length fits in 'int'.
422 (x_get_resource_string): Don't blindly alloca invocation name;
423 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
424 not fit in int.
425
426 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
427 (xg_check_special_colors, xg_set_geometry):
428 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
429
430 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
431 Use esprintf, not sprintf, in case result does not fit in int.
432
433 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
434 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
435 it as a large positive number.
436 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
437 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
438
439 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
440 in case result does not fit in int.
441
442 * print.c (float_to_string): Detect width overflow more reliably.
443 (print_object): Make sprintf buffer a bit bigger, to avoid potential
444 buffer overrun. Don't assume list length fits in 'int'. Treat
445 print length of 0 as 0, not as infinity; to be consistent with other
446 uses of print length in this function. Don't overflow print length
447 index. Don't assume hash table size fits in 'long', or that
448 vectorlike size fits in 'unsigned long'.
449
450 * process.c (make_process): Use printmax_t, not int, to format
451 process-name gensyms.
452
453 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
454
455 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
456 to avoid potential buffer overrun.
457
458 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
459 if X resource line is longer than 512 bytes.
460
461 * xfns.c (x_window): Make sprintf buffer a bit bigger
462 to avoid potential buffer overrun.
463
464 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
465
466 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
467
468 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
469
470 Integer overflow fixes for scrolling, etc.
471 Without these, Emacs silently mishandles large integers sometimes.
472 For example, "C-u 4294967297 M-x recenter" was treated as if
473 it were "C-u 1 M-x recenter" on a typical 64-bit host.
474
475 * xdisp.c (try_window_id): Check Emacs fixnum range before
476 converting to 'int'.
477
478 * window.c (window_scroll_line_based, Frecenter):
479 Check that an Emacs fixnum is in range before assigning it to 'int'.
480 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
481 values converted from Emacs fixnums.
482 (Frecenter): Don't wrap around a line count if it is out of 'int'
483 range; instead, treat it as an extreme value.
484 (Fset_window_configuration, compare_window_configurations):
485 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
486
487 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
488 that can exceed INT_MAX. Check that EMACS_INT value is in range
489 before assigning it to the (possibly-narrower) index.
490 (match_limit): Don't assume that a fixnum can fit in 'int'.
491
492 * print.c (print_object): Use ptrdiff_t, not int, for index that can
493 exceed INT_MAX.
494
495 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
496 (Fvertical_motion): Don't wrap around LINES values that don't fit
497 in 'int'. Instead, treat them as extreme values. This is good
498 enough for windows, which can't have more than INT_MAX lines anyway.
499
500 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
501
502 * Require libxml/parser.h to avoid compilation warning.
503
504 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
505
506 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
507 since this reportedly can destroy thread storage.
508
509 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
510
511 * syntax.c (find_defun_start): Update all cache variables if
512 exiting early (Bug#9401).
513
514 2011-08-30 Eli Zaretskii <eliz@gnu.org>
515
516 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
517
518 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
519 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
520 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
521
522 * term.c (tty_append_glyph): New function.
523 (produce_stretch_glyph): Static function and its prototype deleted.
524
525 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
526 prototypes.
527
528 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
529
530 * image.c (parse_image_spec): Check for nonnegative, not for positive,
531 when checking :margin (Bug#9390).
532 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
533 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
534 so that the name doesn't mislead. All uses changed.
535
536 2011-08-28 Johan Bockgård <bojohan@gnu.org>
537
538 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
539 set_tty_hooks.
540
541 2011-08-27 Eli Zaretskii <eliz@gnu.org>
542
543 * xdisp.c (move_it_to): Don't bail out early when reaching
544 position beyond to_charpos, if we are scanning backwards.
545 (move_it_vertically_backward): When DY == 0, make sure we get to
546 the first character in the line after the newline.
547
548 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
549
550 * ccl.c: Improve and simplify overflow checking (Bug#9196).
551 (ccl_driver): Do not generate an out-of-range pointer.
552 (Fccl_execute_on_string): Remove unnecessary check for
553 integer overflow, noted by Stefan Monnier in
554 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
555 Remove a FIXME that didn't need fixing.
556 Simplify the newly-introduced buffer reallocation code.
557
558 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
559
560 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
561
562 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
563
564 Integer and memory overflow issues (Bug#9196).
565
566 * doc.c (get_doc_string): Rework so that
567 get_doc_string_buffer_size is the actual buffer size, rather than
568 being 1 less than the actual buffer size; this makes xpalloc more
569 convenient.
570
571 * image.c (x_allocate_bitmap_record, cache_image):
572 * xselect.c (Fx_register_dnd_atom):
573 Simplify previous changes by using xpalloc.
574
575 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
576 since either will do and ptrdiff_t is convenient with xpalloc.
577
578 * charset.c (charset_table_size)
579 (struct charset_sort_data.priority): Now ptrdiff_t.
580 (charset_compare): Don't overflow if priorities differ greatly.
581 (Fsort_charsets): Don't assume list length fits in int.
582 Check for size-calculation overflow when allocating sort data.
583 (syms_of_charset): Allocate an initial charset table that is
584 just under 64 KiB, to avoid problems with glibc malloc and mmap.
585
586 * cmds.c (internal_self_insert): Check for size-calculation overflow.
587
588 * composite.h (struct composition.glyph_len): Now int, not unsigned.
589 The actual value is always <= INT_MAX, and leaving it unsigned made
590 overflow checking harder.
591
592 * dispextern.h (struct glyph_matrix.rows_allocated)
593 (struct face_cache.size): Now ptrdiff_t, for convenience in use
594 with xpalloc. The values are still always <= INT_MAX.
595
596 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
597
598 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
599 (SAFE_NALLOCA): New macro.
600
601 * region-cache.c (struct boundary.pos, find_cache_boundary)
602 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
603 (set_cache_region, invalidate_region_cache)
604 (revalidate_region_cache, know_region_cache, region_cache_forward)
605 (region_cache_backward, pp_cache):
606 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
607 so that ptrdiff_t * can be passed to xpalloc.
608 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
609 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
610 (pp_cache): Don't assume cache_len fits in int.
611 * region-cache.h: Adjust extern decls to match.
612
613 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
614 EMACS_INT, since either will do, for xpalloc.
615
616 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
617 (xnmalloc, xnrealloc, xpalloc): New functions.
618
619 * bidi.c (bidi_shelve_header_size): New constant.
620 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
621 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
622
623 * bidi.c (bidi_cache_shrink):
624 * buffer.c (overlays_at, overlays_in, record_overlay_string)
625 (overlay_strings):
626 Don't update size of array until after memory allocation succeeds,
627 because xmalloc/xrealloc may not return.
628 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
629 now that we have proper integer overflow checking.
630 (record_overlay_string, overlay_strings): Catch overflows when
631 calculating size of overlay_str_buf.
632
633 * callproc.c (Fcall_process): Check for size overflow when
634 calculating size of args2.
635 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
636 Normally we prefer signed values, but sticking with ptrdiff_t would
637 require adding more-complicated checks.
638
639 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
640 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
641 Redo buffer-overflow calculations to avoid integer overflow.
642 Add a FIXME comment where memory seems to be over-allocated.
643
644 * character.c (Fstring): Check for size-calculation overflow.
645
646 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
647 unnecessary integer overflow. Check for size overflow.
648 (encode_coding_object): Don't update size until xmalloc succeeds.
649
650 * composite.c (get_composition_id): Check for overflow in glyph
651 length calculations.
652
653 Integer and memory overflow fixes for display code.
654 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
655 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
656 (scrolling_window): Check for overflow in size calculations.
657 (line_draw_cost, realloc_glyph_pool, add_row_entry):
658 Don't assume glyph table len fits in int.
659 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
660 (row_table_size): Now ptrdiff_t, not int.
661 (scrolling_window): Avoid overflow in size calculations.
662 Don't update size until allocation succeeds.
663 * fns.c (concat): Check for overflow in size calculations.
664 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
665 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
666 (NEXT_ALMOST_PRIME_LIMIT): New constant.
667
668 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
669 (get_doc_string): Check for size calculation overflow.
670 Don't update size until allocation succeeds.
671 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
672 EMACS_INT, where ptrdiff_t will do.
673 (Fsubstitute_command_keys): Check for string overflow.
674
675 * editfns.c (set_time_zone_rule): Don't assume environment length
676 fits in int.
677 (message_length): Now ptrdiff_t, not int.
678 (Fmessage_box): Don't update size until allocation succeeds.
679 Don't assume message length fits in int.
680 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
681
682 * emacs.c (main): Do not reallocate argv, since there is a null at
683 the end that can be overwritten, and this way there's no need to
684 worry about size-calculation overflow.
685 (sort_args): Check for size-calculation overflow.
686
687 * eval.c (init_eval_once, grow_specpdl): Don't update size until
688 alloc succeeds.
689 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
690
691 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
692 (x_set_scroll_bar_width, x_figure_window_size):
693 Check for integer overflow.
694 (x_set_alpha): Do not assume XINT fits in int.
695
696 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
697 This is for the members text_lines, text_cols, total_lines, total_cols,
698 where the system imposes an 'int' limit.
699
700 * fringe.c (Fdefine_fringe_bitmap):
701 Don't update size until alloc works.
702
703 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
704 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
705
706 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
707 Check for size-calculation overflow.
708 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
709 do, as we prefer signed integers.
710 (id_to_widget.max_size, id_to_widget.used)
711 (xg_store_widget_in_map, xg_remove_widget_from_map)
712 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
713 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
714 Use and return ptrdiff_t, not int.
715 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
716 * gtkutil.h: Change prototypes to match the above.
717
718 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
719 are duplicate now that they've been promoted to lisp.h.
720 (x_allocate_bitmap_record, x_alloc_image_color)
721 (make_image_cache, cache_image, xpm_load):
722 Don't update size until alloc is done.
723 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
724 (x_detect_edges):
725 Check for size calculation overflow.
726 (ct_colors_allocated_max): New constant.
727 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
728 overflow.
729
730 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
731 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
732 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
733 Use ptrdiff_t, not int, to count maps.
734 (read_char_minibuf_menu_prompt): Check for overflow in size
735 calculations. Don't update size until allocation succeeds. Redo
736 calculations to avoid overflow.
737 * keyboard.h: Change prototypes to match the above.
738
739 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
740 to count maps.
741 (current_minor_maps): Check for size calculation overflow.
742 * keymap.h: Change prototypes to match the above.
743
744 * lread.c (read1, init_obarray): Don't update size until alloc done.
745
746 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
747 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
748
749 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
750 Now ptrdiff_t, not int.
751 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
752 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
753
754 * process.c (Fnetwork_interface_list): Check for overflow
755 in size calculation.
756
757 * region-cache.c (move_cache_gap): Check for size calculation overflow.
758
759 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
760 overflow. Don't bother calling xmalloc when xrealloc will do.
761
762 * search.c (Freplace_match): Check for size calculation overflow.
763 (Fset_match_data): Don't assume list lengths fit in 'int'.
764
765 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
766 for command line length. Do not attempt to address one before the
767 beginning of an array, as that's not portable.
768
769 * term.c (max_frame_lines): Remove; unused.
770 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
771 not int.
772 (encode_terminal_code, calculate_costs): Check for size
773 calculation overflow.
774 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
775 table lengths and related sizes. Don't update size until alloc
776 done. Redo calculations to avoid overflow.
777 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
778
779 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
780 subtracting pointers.
781 (gobble_line): Check for overflow more carefully. Don't update size
782 until alloc done.
783
784 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
785 Don't update size until alloc done.
786 Redo size calculations to avoid overflow.
787 Check for size calculation overflow.
788 (main) [DEBUG]: Fix typo in invoking tparam1.
789
790 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
791 Use ptrdiff_t, not int, for sizes.
792 (store_mode_line_noprop_char): Don't update size until alloc done.
793
794 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
795 Use ptrdiff_t, not int, for sizes.
796 (Finternal_make_lisp_face, cache_face):
797 Check for size calculation overflow.
798 (cache_face): Treat size calculation overflows as if they were
799 memory exhaustion (the usual treatment), rather than aborting.
800
801 * xfns.c (x_encode_text, x_set_name_internal)
802 (Fx_change_window_property): Use ptrdiff_t, not int, to count
803 sizes, since they can exceed INT_MAX in size. Check for size
804 calculation overflow.
805
806 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
807 (xg_select): Check for size calculation overflow.
808 Don't update size until alloc done.
809
810 * xrdb.c (get_environ_db): Don't assume path length fits in int,
811 as sprintf is limited to int lengths.
812
813 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
814 (X_LONG_MIN): New macros.
815 Use them to make the following changes clearer.
816 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
817 This change doesn't affect the value now, but it may help remind
818 future maintainers not to raise the value too much later.
819 (SELECTION_QUANTUM): Remove, replacing with ...
820 (selection_quantum): ... new function, which avoids overflow.
821 All uses changed.
822 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
823 assumption that selection length fits in 'int'.
824 (x_reply_selection_request, x_handle_selection_request)
825 (x_get_window_property, receive_incremental_selection)
826 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
827 (lisp_data_to_selection_data, clean_local_selection_data):
828 Use ptrdiff_t, not int, to record length of selection.
829 (x_reply_selection_request, x_get_window_property)
830 (receive_incremental_selection, x_property_data_to_lisp):
831 Redo calculations to avoid overflow.
832 (x_reply_selection_request): When sending hint, ceiling it at
833 X_LONG_MAX rather than relying on wraparound overflow to send
834 something.
835 (x_get_window_property, receive_incremental_selection)
836 (lisp_data_to_selection_data, x_property_data_to_lisp):
837 Check for size-calculation overflow.
838 (x_get_window_property, receive_incremental_selection)
839 (lisp_data_to_selection_data, Fx_register_dnd_atom):
840 Don't store size until memory allocation succeeds.
841 (x_get_window_property): Plug memory leak on memory exhaustion.
842 Don't double-block input; malloc is safe here. Don't assume 2**34
843 - 4 fits in unsigned long. Add an xassert to check
844 XGetWindowProperty overflow. Be more careful about overflow
845 calculations, and distinguish size from memory overflow better.
846 (receive_incremental_selection): When tracing, don't assume
847 unsigned int is less than INT_MAX.
848 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
849 harmful) conversions of unsigned short to int.
850 (lisp_data_to_selection_data): Don't assume that integers
851 in the range -65535 through -1 fit in an X unsigned short.
852 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
853 result parameters unless successful. Rely on cons_to_unsigned
854 to report problems with elements; the old code wasn't right anyway.
855 (x_check_property_data): Check for int overflow; we cannot use
856 a wider type due to X limits.
857 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
858
859 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
860
861 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
862 (x_term_init): Check for size calculation overflow.
863 (x_color_cells): Don't store size until memory allocation succeeds.
864 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
865 Don't assume alloca size is less than MAX_ALLOCA.
866 (x_term_init): Don't assume length fits in int (sprintf is limited
867 to int size).
868
869 Use ptrdiff_t for composition IDs.
870 * character.c (lisp_string_width):
871 * composite.c (composition_table_size, n_compositions)
872 (get_composition_id, composition_gstring_from_id):
873 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
874 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
875 * window.c (Frecenter):
876 Use ptrdiff_t, not int, for composition IDs.
877 * composite.c (get_composition_id): Check for integer overflow.
878 * composite.h: Adjust prototypes to match the above changes.
879
880 Use ptrdiff_t for hash table indexes.
881 * category.c (hash_get_category_set):
882 * ccl.c (ccl_driver):
883 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
884 * coding.c (coding_system_charset_list, detect_coding_system):
885 * coding.h (struct coding_system.id):
886 * composite.c (get_composition_id, gstring_lookup_cache):
887 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
888 * image.c (xpm_get_color_table_h):
889 * lisp.h (hash_lookup, hash_put):
890 * minibuf.c (Ftest_completion):
891 Use ptrdiff_t for hash table indexes, not int (which is too
892 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
893 32-bit --with-wide-int hosts).
894
895 * charset.c (Fdefine_charset_internal): Check for integer overflow.
896 Add a FIXME comment about memory leaks.
897 (syms_of_charset): Don't assume xmalloc returns.
898
899 Don't assume that stated character widths fit in int.
900 * character.c (Fchar_width, c_string_width, lisp_string_width):
901 * character.h (CHAR_WIDTH):
902 * indent.c (MULTIBYTE_BYTES_WIDTH):
903 Use sanitize_char_width to avoid undefined and/or bad behavior
904 with outlandish widths.
905 * character.h (sanitize_tab_width): Renamed from sanitize_width,
906 now that we have two such functions. All uses changed.
907 (sanitize_char_width): New inline function.
908
909 Don't assume that tab-width fits in int.
910 * character.h (sanitize_width): New inline function.
911 (SANE_TAB_WIDTH): New macro.
912 (ASCII_CHAR_WIDTH): Use it.
913 * indent.c (sane_tab_width): Remove. All uses replaced by
914 SANE_TAB_WIDTH (current_buffer).
915 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
916
917 * fileio.c: Integer overflow issues with file modes.
918 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
919
920 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
921 Remove unreachable code.
922 (read_hex, load_charset_map_from_file): Check for integer overflow.
923
924 * xterm.c: don't go over XClientMessageEvent limit
925 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
926 (x_send_scroll_bar_event): Likewise. Check that the size does not
927 exceed limits imposed by XClientMessageEvent, as well as the usual
928 ptrdiff_t and size_t limits.
929
930 * keyboard.c: Overflow, signedness and related fixes.
931 (make_lispy_movement): Use same integer type in forward decl
932 that is used in the definition.
933 (read_key_sequence, keyremap_step):
934 Change bufsize argument back to int, undoing my 2011-03-30 change.
935 We prefer signed types, and int is wide enough here.
936 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
937 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
938 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
939 length, not size_t. Use ptrdiff_t for index, not int.
940 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
941 possibility of integer overflow.
942
943 Overflow, signedness and related fixes for images.
944
945 * dispextern.h (struct it.stack[0].u.image.image_id)
946 (struct_it.image_id, struct image.id, struct image_cache.size)
947 (struct image_cache.used, struct image_cache.ref_count):
948 * gtkutil.c (update_frame_tool_bar):
949 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
950 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
951 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
952 * nsmenu.m (update_frame_tool_bar):
953 * xdisp.c (calc_pixel_width_or_height):
954 * xfns.c (image_cache_refcount):
955 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
956 on typical 64-bit hosts.
957
958 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
959 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
960 Omit unnecessary casts to int.
961 (parse_image_spec): Check that integers fall into 'int' range
962 when the callers expect that.
963 (image_ascent): Redo ascent calculation to avoid int overflow.
964 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
965 (lookup_image): Remove unnecessary tests.
966 (xbm_image_p): Locals are now of int, not EMACS_INT,
967 since parse_image_check makes sure they fit into int.
968 (png_load, gif_load, svg_load_image):
969 Prefer int to unsigned where either will do.
970 (tiff_handler): New function, combining the cores of the
971 old tiff_error_handler and tiff_warning_handler. This
972 function is rewritten to use vsnprintf and thereby avoid
973 stack buffer overflows. It uses only the features of vsnprintf
974 that are common to both POSIX and native Microsoft.
975 (tiff_error_handler, tiff_warning_handler): Use it.
976 (tiff_load, gif_load, imagemagick_load_image):
977 Don't assume :index value fits in 'int'.
978 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
979 (imagemagick_load_image): Check that crop parameters fit into
980 the integer types that MagickCropImage accepts. Don't assume
981 Vimagemagick_render_type has a nonnegative value. Don't assume
982 size_t fits in 'long'.
983 (gs_load): Use printmax_t to print the widest integers possible.
984 Check for integer overflow when computing image height and width.
985
986 2011-08-26 Eli Zaretskii <eliz@gnu.org>
987
988 * xdisp.c (redisplay_window): Don't force window start if point
989 will be invisible in the resulting window. (Bug#9324)
990
991 2011-08-25 Eli Zaretskii <eliz@gnu.org>
992
993 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
994 the display spec is of the form `(space ...)'.
995 (handle_display_spec): Return the value returned by
996 handle_single_display_spec, not just 1 or zero.
997 (handle_single_display_spec): If the display spec is of the form
998 `(space ...)', and specifies display in the text area, return 2
999 rather than 1.
1000 (try_cursor_movement): Check for the need to scroll more
1001 accurately, and prefer exact match for point under bidi. Don't
1002 advance `row' beyond the last row of the window.
1003
1004 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1005 into disp_prop; all users changed.
1006
1007 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1008 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1009 for the text covered by the display property.
1010
1011 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1012
1013 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1014 Change return value to nil.
1015 (Frecord_buffer): Delete unused function.
1016
1017 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1018
1019 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1020 buffers, return left-to-right.
1021 (set_cursor_from_row): Consider candidate row a win if its glyph
1022 represents a newline and point is on that newline. Fixes cursor
1023 positioning on the newline at EOL of R2L text within L2R
1024 paragraph, and vice versa.
1025 (try_cursor_movement): Check continued rows, in addition to
1026 continuation rows. Fixes unwarranted scroll when point enters a
1027 continued line of R2L text within an L2R paragraph, or vice versa.
1028 (cursor_row_p): Consider the case of point being equal to
1029 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1030 from the end of a short line to the beginning of a continued line
1031 of R2L text within L2R paragraph.
1032 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1033 composed characters.
1034
1035 * bidi.c (bidi_check_type): Use xassert.
1036 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1037 members.
1038
1039 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1040
1041 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1042 a character.
1043
1044 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1045
1046 * nsfont.m (ns_otf_to_script): Fix typo.
1047
1048 2011-08-22 Kenichi Handa <handa@m17n.org>
1049
1050 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1051 extra slot even if the purpose is char-code-property-table.
1052
1053 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1054
1055 * xdisp.c (redisplay_window): When computing centering_position,
1056 account for the height of the header line. (Bug#8874)
1057
1058 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1059 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1060 candidate is selected by the mouse, and that candidate has a
1061 composed character under the mouse.
1062
1063 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1064 coordinates reported by pos-visible-in-window-p for a composed
1065 character in column zero.
1066
1067 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1068
1069 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1070
1071 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1072
1073 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1074 consider it a hit if to_charpos is anywhere in the range of the
1075 composed buffer positions.
1076
1077 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1078
1079 * image.c (gif_load): Don't assume that each subimage has the same
1080 dimensions as the base image. Handle disposal method that is
1081 "undefined" by the gif spec (Bug#9335).
1082
1083 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1084
1085 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1086 (Fcondition_case): Document `debug' symbol in error handler.
1087
1088 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1089
1090 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1091 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1092 from an Org mode buffer to a Speedbar frame.
1093
1094 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1095 a composition, take its buffer position from IT->cmp_it.charpos.
1096 Fixes cursor positioning at the beginning of a line that begins
1097 with a composed character.
1098
1099 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1100
1101 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1102 character bidirectional type, use STRONG_L instead. Fixes crashes
1103 in a buffer produced by `describe-categories'.
1104
1105 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1106 members before the level stack, so they would be saved and
1107 restored when copying iterator state. Fixes incorrect reordering
1108 around TABs covered by display properties.
1109
1110 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1111
1112 * process.c (Fnetwork_interface_list): Correctly determine buffer
1113 size.
1114
1115 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1116
1117 * eval.c (internal_condition_case, internal_condition_case_1)
1118 (internal_condition_case_2, internal_condition_case_n):
1119 Remove unnecessary aborts (Bug#9081).
1120
1121 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1122
1123 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1124 has no `load' handler, try opening the file locally. (Bug#9311)
1125
1126 2011-08-16 Ken Brown <kbrown@cornell.edu>
1127
1128 * gmalloc.c: Expand comment.
1129
1130 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1131
1132 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1133 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1134
1135 2011-08-16 Ken Brown <kbrown@cornell.edu>
1136
1137 Fix memory allocation problems in Cygwin build (Bug#9273).
1138
1139 * unexcw.c ( __malloc_initialized): Declare external variable.
1140 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1141
1142 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1143 New variables.
1144 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1145 dumped emacs.
1146 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1147 in the static heap.
1148 [CYGWIN] (special_realloc): New function.
1149 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1150 requests to realloc storage in the static heap.
1151
1152 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1153
1154 * bidi.c (bidi_initialize): Remove unused local.
1155
1156 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1157
1158 * biditype.h: File removed.
1159
1160 * bidimirror.h: File removed.
1161
1162 * deps.mk (bidi.o): Remove biditype.h and
1163 bidimirror.h.
1164
1165 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1166 bidimirror.h.
1167
1168 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1169
1170 * chartab.c: Improve commentary for the uniprop_table API.
1171
1172 * bidi.c (bidi_paragraph_init): Support zero value of
1173 bidi_ignore_explicit_marks_for_paragraph_level.
1174 (bidi_initialize): Use uniprop_table instead of including
1175 biditype.h and bidimirror.h.
1176
1177 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1178 coordinates of the iterator when restoring from ppos_it.
1179 (Bug#9296)
1180
1181 2011-08-14 Kenichi Handa <handa@m17n.org>
1182
1183 * process.c (create_process): Call setup_process_coding_systems
1184 after the pid of the process is set to -1 (Bug#8162).
1185
1186 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1187
1188 * xdisp.c (move_it_in_display_line_to): Don't invoke
1189 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1190 ppos_it. Fixes vertical cursor motion when line beginning is
1191 covered by an image. (Bug#9296)
1192
1193 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1194
1195 * nsterm.h (ns_run_ascript): Declare.
1196 (NSAPP_DATA2_RUNASSCRIPT): Define.
1197
1198 * nsfns.m (as_script, as_result, as_status): New static variables.
1199 (ns_run_ascript): New function.
1200 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1201 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1202 the event loop. Get status from as_status (Bug#7276).
1203
1204 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1205 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1206 the event loop (Bug#7276).
1207
1208 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1209
1210 * gnutls.c (QCgnutls_bootprop_priority)
1211 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1212 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1213 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1214 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1215 (QCgnutls_bootprop_verify_hostname_error)
1216 (QCgnutls_bootprop_callbacks_verify): Rename from
1217 Qgnutls_bootprop_..., all uses changed.
1218
1219 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1220 uses changed.
1221
1222 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1223
1224 * xfaces.c (Qframe_set_background_mode): Now static.
1225 * dispextern.h (Qframe_set_background_mode): Remove decl.
1226
1227 * process.c (Fnetwork_interface_info): Declare local only if needed.
1228
1229 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1230
1231 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1232 (Fnetwork_interface_list): Allocate in increments of bytes instead
1233 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1234 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1235 sockaddr.
1236 (struct ifflag_def): notrailers is smart on OSX.
1237 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1238 Get hardware address with getifaddrs if available.
1239
1240 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1241
1242 * xdisp.c (iterate_out_of_display_property): xassert that
1243 IT->position is set to within IT->object's boundaries. Break from
1244 the loop as soon as EOB is reached; avoids infloops in redisplay
1245 when IT->position is set up wrongly due to some bug.
1246 Set IT->current to match the bidi iterator unconditionally.
1247 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1248 entry. Force push_it to save on the stack the current
1249 buffer/string position, to be restored by pop_it. Fix flags in
1250 the iterator structure wrt the object coming from a display
1251 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1252 properties. (Bug#9284)
1253
1254 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1255
1256 * fontset.c (fontset_get_font_group): Add proper type checks.
1257 (Bug#9172)
1258
1259 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1260
1261 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1262 and LC_VERSION_MIN_MACOSX.
1263 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1264 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1265
1266 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1267
1268 * xdisp.c (forward_to_next_line_start): Allow to use the
1269 no-display-properties-and-no-overlays under bidi display.
1270 Set disp_pos in the bidi iterator to avoid searches for display
1271 properties and overlays.
1272
1273 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1274
1275 * editfns.c (Fset_time_zone_rule): Document relationship with the
1276 setenv function.
1277
1278 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1279 the font entity extracted from the cache (Bug#8109).
1280
1281 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1282
1283 * composite.c (autocmp_chars): Don't reset point. That is done by
1284 restore_point_unwind (Bug#5984).
1285
1286 2011-08-07 Juri Linkov <juri@jurta.org>
1287
1288 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1289 to show the arg `TIME' instead of `TIMEVAL'.
1290
1291 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1292
1293 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1294 display property strides EOL and includes a newline, as in
1295 longlines-mode. (Bug#9254)
1296 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1297 word-wrap under bidirectional display. (Bug#9224)
1298
1299 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1300 is non-zero, even if the data buffer is NULL. Fixes a crash in
1301 vertical-motion with longlines-mode. (Bug#9254)
1302
1303 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1304
1305 * bidi.c <bidi_cache_total_alloc>: Now static.
1306 (bidi_initialize): Initialize bidi_cache_total_alloc.
1307
1308 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1309 cache. (Bug#9221)
1310
1311 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1312 amount allocated this far in `bidi_cache_total_alloc'.
1313 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1314 non-zero, only free the data buffer without restoring the cache
1315 contents. All callers changed.
1316
1317 * dispextern.h (bidi_unshelve_cache): Update prototype.
1318
1319 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1320 (move_it_in_display_line, move_it_to)
1321 (move_it_vertically_backward, move_it_by_lines): Replace the call
1322 to xfree to an equivalent call to bidi_unshelve_cache.
1323 (move_it_in_display_line_to): Fix logic of returning
1324 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1325
1326 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1327
1328 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1329 came from a string character with a `cursor' property. (Bug#9229)
1330
1331 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1332
1333 * Makefile.in (LIB_PTHREAD): New variable.
1334 (LIBES): Add LIB_PTHREAD (Bug#9216).
1335
1336 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1337 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1338
1339 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1340
1341 * regex.c (re_iswctype): Remove some redundant boolean
1342 conversions.
1343
1344 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1345
1346 * xterm.c (x_find_topmost_parent): New function.
1347 (x_set_frame_alpha): Find topmost parent window with
1348 x_find_topmost_parent and set the property there also (bug#9181).
1349 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1350
1351 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1352
1353 * callproc.c (Fcall_process): Avoid vfork clobbering
1354 the local vars buffer, coding_systems, current_dir.
1355
1356 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1357
1358 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1359
1360 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1361
1362 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1363 so that it is not optimized away.
1364
1365 * xdisp.c (compute_display_string_pos): Remove unused local.
1366
1367 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1368
1369 Fix slow cursor motion and scrolling in large buffers with
1370 selective display, like Org Mode buffers. (Bug#9218)
1371
1372 * dispextern.h (struct bidi_it): New member disp_prop_p.
1373
1374 * xdisp.c: Remove one-slot cache of display string positions.
1375 (compute_display_string_pos): Accept an additional argument
1376 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1377 for a display string or property. If found, set DISP_PROP_P
1378 non-zero.
1379
1380 * bidi.c (bidi_fetch_char): Accept an additional argument
1381 DISP_PROP_P, and pass it to compute_display_string_pos.
1382 Only handle text covered by a display string if DISP_PROP_P is returned
1383 non-zero. All callers of bidi_fetch_char changed.
1384
1385 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1386
1387 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1388
1389 2010-12-03 Don March <don@ohspite.net>
1390
1391 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1392 last character M-[char] is translated to ESC [char] (bug#7541).
1393
1394 2011-08-02 Kenichi Handa <handa@m17n.org>
1395
1396 * lisp.h (uniprop_table): Extern it.
1397
1398 * chartab.c (uniprop_table): Make it non-static.
1399
1400 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1401
1402 * xdisp.c (forward_to_next_line_start): Accept additional argument
1403 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1404 on the newline.
1405 (reseat_at_next_visible_line_start): Use the bidi iterator state
1406 returned by forward_to_next_line_start to restore the state of
1407 it->bidi_it after backing up to previous newline. (Bug#9212)
1408
1409 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1410
1411 * regex.c (re_comp): Protoize.
1412 (re_exec): Fix return type.
1413 (regexec): Fix type of `ret'. (Bug#9203)
1414
1415 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1416
1417 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1418 This is needed if max-image-size is a floating-point number.
1419
1420 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1421
1422 * print.c (print_object): Print empty symbol as ##.
1423
1424 * lread.c (read1): Read ## as empty symbol.
1425
1426 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1427
1428 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1429 setting frame foreground color (Bug#9175).
1430 (x_set_background_color): Likewise.
1431
1432 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1433 contents (Bug#9176).
1434 (EmacsTooltip -init): Remove bezels and add shadows to
1435 tooltip windows.
1436
1437 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1438 or scroll bar (Bug#8470).
1439
1440 * nsfont.m (nsfont_open): Remove assignment to voffset and
1441 unnecessary vars hshink, expand, hd, full_height, min_height.
1442 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1443
1444 * nsterm.h (nsfont_info): Remove voffset field.
1445
1446 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1447
1448 Implement strike-through and overline on NextStep (Bug#8863).
1449
1450 * nsfont.m (nsfont_open): Use underline position provided by font,
1451 instead of hard-coded value of 2.
1452 (nsfont_draw): Call ns_draw_text_decoration instead.
1453
1454 * nsterm.h: Add declaration for ns_draw_text_decoration.
1455
1456 * nsterm.m (ns_draw_text_decoration): New function for drawing
1457 underline, overline, and strike-through.
1458 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1459 ns_draw_text_decoration. Change treatment of cursor drawing to
1460 accommodate underlining, etc.
1461
1462 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1463
1464 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1465 default.
1466
1467 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1468
1469 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1470 Without this fix, if a signal arrives just after memory fills up,
1471 'malloc' might be invoked reentrantly.
1472
1473 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1474 In other words, assume that every image size is allowed, on non-X
1475 hosts. This assumption is probably wrong, but it lets Emacs compile.
1476
1477 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1478
1479 * regex.c (re_iswctype): Convert return values to boolean.
1480
1481 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1482
1483 * xdisp.c (compute_display_string_pos): Don't use cached display
1484 string position if the buffer had its restriction changed.
1485 (Bug#9184)
1486
1487 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1488
1489 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1490
1491 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1492
1493 Integer signedness and overflow and related fixes. (Bug#9079)
1494
1495 * bidi.c: Integer size and overflow fixes.
1496 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1497 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1498 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1499 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1500 (bidi_find_other_level_edge):
1501 Use ptrdiff_t instead of EMACS_INT where either will do.
1502 This works better on 32-bit hosts configured --with-wide-int.
1503 (bidi_cache_ensure_space): Check for size-calculation overflow.
1504 Use % rather than repeated addition, for better worst-case speed.
1505 Don't set bidi_cache_size until after xrealloc returns, because it
1506 might not return.
1507 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1508 (bidi_cache_ensure_space): Also check that the bidi cache size
1509 does not exceed that of the largest Lisp string or buffer. See Eli
1510 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1511
1512 * alloc.c (__malloc_size_t): Remove.
1513 All uses replaced by size_t. See Andreas Schwab's note
1514 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1515
1516 * image.c: Improve checking for integer overflow.
1517 (check_image_size): Assume that f is nonnull, since
1518 it is always nonnull in practice. This is one less thing to
1519 worry about when checking for integer overflow later.
1520 (x_check_image_size): New function, which checks for integer
1521 overflow issues inside X.
1522 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1523 This removes the need for a memory_full check.
1524 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1525 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1526 (xbm_read_bitmap_data): Change locals back to 'int', since
1527 their values must fit in 'int'.
1528 (xpm_load_image, png_load, tiff_load):
1529 Invoke x_create_x_image_and_pixmap earlier,
1530 to avoid much needless work if the image is too large.
1531 (tiff_load): Treat overly large images as if
1532 x_create_x_image_and_pixmap failed, not as malloc failures.
1533 (gs_load): Use x_check_image_size.
1534
1535 * gtkutil.c: Omit integer casts.
1536 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1537 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1538
1539 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1540
1541 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1542 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1543 would wrongly return t on a 64-bit host.
1544
1545 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1546 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1547 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1548 and therefore cause GCC to emit a bogus diagnostic in some cases.
1549
1550 * image.c: Integer signedness and overflow and related fixes.
1551 This is not an exhaustive set of fixes, but it's time to
1552 record what I've got.
1553 (lookup_pixel_color, check_image_size): Remove redundant decls.
1554 (check_image_size): Don't assume that arbitrary EMACS_INT values
1555 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1556 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1557 (tiff_load, imagemagick_load_image):
1558 Check for overflow in size calculations.
1559 (x_create_x_image_and_pixmap): Remove unnecessary test for
1560 xmalloc returning NULL; that can't happen.
1561 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1562 (xpm_color_bucket): Use better integer hashing function.
1563 (xpm_cache_color): Don't possibly over-allocate memory.
1564 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1565 (gif_memory_source):
1566 Use ptrdiff_t, not int or size_t, to record sizes.
1567 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1568 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1569 either works, as we prefer signed integers.
1570 (tiff_read_from_memory, tiff_write_from_memory):
1571 Return tsize_t, not size_t, since that's what the TIFF API wants.
1572 (tiff_read_from_memory): Don't fail simply because the read would
1573 go past EOF; instead, return a short read.
1574 (tiff_load): Omit no-longer-needed casts.
1575 (Fimagemagick_types): Don't assume size fits into 'int'.
1576
1577 Improve hashing quality when configured --with-wide-int.
1578 * fns.c (hash_string): New function, taken from sxhash_string.
1579 Do not discard information about ASCII character case; this
1580 discarding is no longer needed.
1581 (sxhash-string): Use it. Change sig to match it. Caller changed.
1582 * lisp.h: Declare it.
1583 * lread.c (hash_string): Remove, since we now use fns.c's version.
1584 The fns.c version returns a wider integer if --with-wide-int is
1585 specified, so this should help the quality of the hashing a bit.
1586
1587 * emacs.c: Integer overflow minor fix.
1588 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1589 Define only if GNU_LINUX.
1590 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1591
1592 * dispnew.c: Integer signedness and overflow fixes.
1593 Remove unnecessary forward decls, that were a maintenance hassle.
1594 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1595 All uses changed.
1596 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1597 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1598 (prepare_desired_row, line_draw_cost):
1599 Use int, not unsigned, where either works.
1600 (save_current_matrix, restore_current_matrix):
1601 Use ptrdiff_t, not size_t, where either works.
1602 (init_display): Check for overflow more accurately, and without
1603 relying on undefined behavior.
1604
1605 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1606 Remove, replacing with the new symbols in lisp.h. All uses changed.
1607 * fileio.c (make_temp_name):
1608 * filelock.c (lock_file_1, lock_file):
1609 * xdisp.c (message_dolog):
1610 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1611 Use pMd etc. instead.
1612 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1613 replacing the pWIDE etc. symbols removed from editfns.c.
1614
1615 * keyboard.h (num_input_events): Now uintmax_t.
1616 This is (very slightly) less likely to mess up due to wraparound.
1617 All uses changed.
1618
1619 * buffer.c: Integer signedness fixes.
1620 (alloc_buffer_text, enlarge_buffer_text):
1621 Use ptrdiff_t rather than size_t when either will do, as we prefer
1622 signed integers.
1623
1624 * alloc.c: Integer signedness and overflow fixes.
1625 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1626 (__malloc_size_t): Default to size_t, not to int.
1627 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1628 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1629 Prefer ptrdiff_t to size_t when either would do, as we prefer
1630 signed integers.
1631 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1632 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1633 Now const. Initialize with values that are in range even if char
1634 is signed.
1635 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1636 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1637 These functions do the right thing with sizes > 2**32.
1638 (check_depth): Now ptrdiff_t, not int.
1639 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1640 Adjust to new way of storing sizes. Check for size overflow bugs
1641 in rest of code.
1642 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1643 slightly wrong anyway, as it missed one instance of
1644 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1645 (refill_memory_reserve): Omit needless cast to size_t.
1646 (mark_object_loop_halt): Mark as externally visible.
1647
1648 * xselect.c: Integer signedness and overflow fixes.
1649 (Fx_register_dnd_atom, x_handle_dnd_message):
1650 Use ptrdiff_t, not size_t, since we prefer signed.
1651 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1652 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1653 x_dnd_atoms_size and x_dnd_atoms_length.
1654
1655 * doprnt.c: Prefer signed to unsigned when either works.
1656 * eval.c (verror):
1657 * doprnt.c (doprnt):
1658 * lisp.h (doprnt):
1659 * xdisp.c (vmessage):
1660 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1661 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1662 prefer signed arithmetic to avoid comparison confusion.
1663 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1664 but is a bit tricky.
1665
1666 Assume freestanding C89 headers, string.h, stdlib.h.
1667 * data.c, doprnt.c, floatfns.c, print.c:
1668 Include float.h unconditionally.
1669 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1670 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1671 * regex.c: Likewise for stddef.h, string.h.
1672 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1673 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1674 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1675 (STDC_HEADERS): Remove obsolete defines.
1676 * sysdep.c: Include limits.h unconditionally.
1677
1678 Assume support for memcmp, memcpy, memmove, memset.
1679 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1680 * regex.c (memcmp, memcpy):
1681 Remove; we assume C89 now.
1682
1683 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1684 (__malloc_safe_bcopy): Remove; no longer needed.
1685
1686 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1687 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1688 well either way, and we prefer signed to unsigned.
1689
1690 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1691
1692 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1693 closes the connection while we're reading (bug#9182).
1694
1695 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1696
1697 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1698 are specified (Bug#9168).
1699
1700 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1701
1702 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1703 Found by GCC static checking and --with-wide-int on a 32-bit host.
1704
1705 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1706
1707 * xdisp.c (compute_display_string_pos): Fix logic of caching
1708 previous display string position. Initialize cached_prev_pos to
1709 -1. Fixes slow-down at the beginning of a buffer.
1710
1711 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1712
1713 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1714 for attrs[LFACE_FONTSET_INDEX].
1715
1716 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1717
1718 * xml.c (parse_region): Remove unused local
1719 that was recently introduced.
1720
1721 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1722
1723 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1724 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1725
1726 * xdisp.c (move_it_in_display_line_to): Record the best matching
1727 position for TO_CHARPOS while scanning the line, and restore it on
1728 exit if none of the characters scanned was an exact match.
1729 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1730 when exact match is impossible due to invisible text, and the
1731 lines are truncated.
1732
1733 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1734
1735 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1736 for OSX >= 10.7.
1737
1738 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1739
1740 Fix a significant slow-down of cursor motion with C-n, C-p,
1741 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1742 auto-repeat under bidi redisplay in fontified buffers.
1743 * xdisp.c (compute_stop_pos_backwards): New function.
1744 (next_element_from_buffer): Call compute_stop_pos_backwards to
1745 find a suitable prev_stop when we find ourselves before
1746 base_level_stop.
1747 (reseat): Don't look for prev_stop, as that could mean a very long
1748 run.
1749 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1750 <cached_disp_overlay_modiff>: Cache for last found display string
1751 position.
1752 (compute_display_string_pos): Return the cached position if asked
1753 about the same buffer in the same area of character positions, and
1754 the buffer wasn't changed since the time the display string
1755 position was cached.
1756
1757 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1758
1759 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1760 is an integer, which is important for empty lines. (Bug#9149)
1761
1762 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1763
1764 * frame.c (Fmodify_frame_parameters): In tty case, update the
1765 default face if necessary (Bug#4238).
1766
1767 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1768
1769 * editfns.c (Fstring_to_char): No need to explain what a character
1770 is in the docstring (Bug#6576).
1771
1772 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1773
1774 * xml.c (parse_region): Make sure we always return a tree.
1775
1776 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1777
1778 * xml.c (parse_region): If a document contains only comments,
1779 return that, too.
1780
1781 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1782
1783 * xml.c (make_dom): Return comments, too.
1784
1785 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1786
1787 Port to OpenBSD.
1788 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1789 and the surrounding thread.
1790 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1791 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1792 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1793 timer goes off.
1794 * s/openbsd.h (BROKEN_SIGIO): Define.
1795 * unexelf.c (unexec) [__OpenBSD__]:
1796 Don't update the .mdebug section of the Alpha COFF symbol table.
1797
1798 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1799
1800 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1801 (bug#8460).
1802
1803 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1804
1805 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1806 This fixes some race conditions on the permissions of any newly
1807 created file.
1808
1809 * alloc.c (valid_pointer_p): Use pipe, not open.
1810 This fixes some permissions issues when debugging.
1811
1812 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1813 If fchown fails to set both uid and gid, try to set just gid,
1814 as that is sometimes allowed. Adjust the file's mode to eliminate
1815 setuid or setgid bits that are inappropriate if fchown fails.
1816
1817 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1818
1819 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1820 to compare Lisp_Objects.
1821 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1822 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1823 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1824
1825 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1826
1827 * lread.c (read_integer): Unread even EOF character.
1828 (read1): Likewise. Properly record start position of symbol.
1829
1830 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1831 symbol character follows.
1832
1833 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1834
1835 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1836 This works around a problem with the previous change to Fcopy_file.
1837 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1838 and without this change, GCC might complain about discarding
1839 fchown's return value.
1840
1841 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1842
1843 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1844
1845 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1846
1847 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1848
1849 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1850
1851 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1852 it's used from the C level.
1853
1854 * process.c: Use the same condition for POLL_FOR_INPUT in both
1855 keyboard.c and process.c (bug#1858).
1856
1857 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1858
1859 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1860 (Fgnutls_boot): Use it.
1861
1862 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1863
1864 * doc.c (Fsubstitute_command_keys): Revert last change.
1865
1866 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1867
1868 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1869 quotes the next character, and doesn't affect other longer
1870 sequences (bug#8935).
1871
1872 * lread.c (syms_of_lread): Clarify that is isn't only
1873 `eval-buffer' and `eval-defun' that's affected by
1874 `lexical-binding' (bug#8460).
1875
1876 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1877
1878 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1879 bidi redisplay when a line includes both an image and is
1880 truncated.
1881
1882 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1883
1884 Fix minor problems found by static checking.
1885 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1886 (elsz): Now a signed constant, not a size_t var. We prefer signed
1887 types to unsigned, to avoid integer comparison confusion. Without
1888 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1889 "cannot optimize loop, the loop counter may overflow", a symptom
1890 of the confusion.
1891 * indent.c (Fvertical_motion): Mark locals as initialized.
1892 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1893
1894 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1895
1896 * search.c (Fre_search_backward): Mention `case-fold-search' in
1897 all the re_search_* functions (bug#8138).
1898
1899 * keyboard.c (Fopen_dribble_file): Document when the file is
1900 closed (bug#8056).
1901
1902 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1903
1904 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1905 bidi_cache_idx.
1906
1907 Support bidi reordering of display and overlay strings.
1908 * xdisp.c (compute_display_string_pos)
1909 (compute_display_string_end): Accept additional argument STRING.
1910 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1911 (reseat_to_string): Initialize bidi_it->string.s and
1912 bidi_it->string.schars.
1913 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1914 NULL (avoids a crash in bidi_paragraph_init).
1915 Initialize itb.string.lstring.
1916 (init_iterator): Call bidi_init_it only of a valid
1917 buffer position was specified. Initialize paragraph_embedding to
1918 L2R.
1919 (reseat_to_string): Initialize the bidi iterator.
1920 (display_string): If we need to ignore text properties of
1921 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1922 original value of -1 will not work with bidi.)
1923 (compute_display_string_pos): First arg is now struct
1924 `text_pos *'; all callers changed. Support display properties on
1925 Lisp strings.
1926 (compute_display_string_end): Support display properties on Lisp
1927 strings.
1928 (init_iterator, reseat_1, reseat_to_string): Initialize the
1929 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1930 when iterating on a string not from display properties).
1931 (compute_display_string_pos, compute_display_string_end):
1932 Fix calculation of the object to scan. Fixes an error when using
1933 arrow keys.
1934 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1935 base_level_stop; instead, set base_level_stop to BEGV.
1936 Fixes crashes in vertical-motion.
1937 (next_element_from_buffer): Improve commentary for when
1938 the iterator is before prev_stop.
1939 (init_iterator): Initialize bidi_p from the default value of
1940 bidi-display-reordering, not from buffer-local value. Use the
1941 buffer-local value only if initializing for buffer iteration.
1942 (handle_invisible_prop): Support invisible properties on strings
1943 that are being bidi-reordered.
1944 (set_iterator_to_next): Support bidi reordering of C strings and
1945 Lisp strings.
1946 (next_element_from_string): Support bidi reordering of Lisp
1947 strings.
1948 (handle_stop_backwards): Support Lisp strings as well.
1949 (display_string): Support display of R2L glyph rows.
1950 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1951 (init_iterator): Don't initialize it->bidi_p for strings
1952 here.
1953 (reseat_to_string): Initialize it->bidi_p for strings here.
1954 (next_element_from_string, next_element_from_c_string)
1955 (next_element_from_buffer): Add xassert's for correspondence
1956 between IT's object being iterated and it->bidi_it.string
1957 structure.
1958 (face_before_or_after_it_pos): Support bidi iteration.
1959 (next_element_from_c_string): Handle the case of the first string
1960 character that is not the first one in the visual order.
1961 (get_visually_first_element): New function, refactored from common
1962 parts of next_element_from_buffer, next_element_from_string, and
1963 next_element_from_c_string.
1964 (tool_bar_lines_needed, redisplay_tool_bar)
1965 (display_menu_bar): Force left-to-right direction. Add a FIXME
1966 comment for making that be controlled by a user option.
1967 (push_it, pop_it): Save and restore the state of the
1968 bidi iterator. Save and restore the bidi_p flag.
1969 (pop_it): Iterate out of display property for string iteration as
1970 well.
1971 (iterate_out_of_display_property): Support iteration over strings.
1972 (handle_single_display_spec): Set up it->bidi_it for iteration
1973 over a display string, and call bidi_init_it.
1974 (handle_single_display_spec, next_overlay_string)
1975 (get_overlay_strings_1, push_display_prop): Set up the bidi
1976 iterator for displaying display or overlay strings.
1977 (forward_to_next_line_start): Don't use the shortcut if
1978 bidi-iterating.
1979 (back_to_previous_visible_line_start): If handle_display_prop
1980 pushed the iterator stack, restore the internal state of the bidi
1981 iterator by calling bidi_pop_it same number of times.
1982 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1983 and we are bidi-iterating, don't decrement the iterator position;
1984 instead, set the first_elt flag in the bidi iterator, to produce
1985 the same effect.
1986 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1987 (push_display_prop): xassert that we are iterating a buffer.
1988 (push_it, pop_it): Save and restore paragraph_embedding member.
1989 (handle_single_display_spec, next_overlay_string)
1990 (get_overlay_strings_1, reseat_1, reseat_to_string)
1991 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1992 correctly. Don't assume unibyte strings are not bidi-reordered.
1993 (compute_display_string_pos)
1994 (compute_display_string_end): Fix handling the case of C string.
1995 (push_it, pop_it): Save and restore from_disp_prop_p.
1996 (handle_single_display_spec, push_display_prop): Set the
1997 from_disp_prop_p flag.
1998 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1999 (pop_it): Call iterate_out_of_display_property only if we are
2000 popping after iteration over a string that came from a display
2001 property. Fix a typo in popping stretch info. Add an assertion
2002 for verifying that the iterator position is in sync with the bidi
2003 iterator.
2004 (handle_single_display_spec, get_overlay_strings_1)
2005 (push_display_prop): Fix initialization of paragraph direction for
2006 string when that of the parent object is not yet determined.
2007 (reseat_1): Call bidi_init_it to resync the bidi
2008 iterator with IT's position. (Bug#7616)
2009 (find_row_edges): If ROW->start.pos gives position
2010 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2011 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2012 Reset the from_disp_prop_p flag.
2013 (SAVE_IT, RESTORE_IT): New macros.
2014 (pos_visible_p, face_before_or_after_it_pos)
2015 (back_to_previous_visible_line_start)
2016 (move_it_in_display_line_to, move_it_in_display_line)
2017 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2018 (try_scrolling, redisplay_window, display_line): Use them when
2019 saving a temporary copy of the iterator and restoring it back.
2020 (back_to_previous_visible_line_start, reseat_1)
2021 (init_iterator): Empty the bidi cache "stack".
2022 (move_it_in_display_line_to): If iterator ended up at
2023 EOL, but we never saw any buffer positions smaller than
2024 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2025 motion in bidi-reordered lines.
2026 (move_it_in_display_line_to): Record prev_method and prev_pos
2027 immediately before the call to set_iterator_to_next. Fixes cursor
2028 motion in bidi-reordered lines with stretch glyphs and strings
2029 displayed in margins. (Bug#8133) (Bug#8867)
2030 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2031 TO_CHARPOS.
2032 (pos_visible_p): Support positions in bidi-reordered lines.
2033 Save and restore bidi cache.
2034
2035 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2036 (bidi_paragraph_info): Delete unused struct.
2037 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2038 (bidi_cache_start): New variable.
2039 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2040 to zero.
2041 (bidi_cache_fetch_state, bidi_cache_search)
2042 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2043 (bidi_cache_find, bidi_peek_at_next_level)
2044 (bidi_level_of_next_char, bidi_find_other_level_edge)
2045 (bidi_move_to_visually_next): Compare cache index with
2046 bidi_cache_start rather than with zero.
2047 (bidi_fetch_char): Accept new argument STRING; all callers
2048 changed. Support iteration over a string. Support strings with
2049 display properties. Support unibyte strings. Fix the type of
2050 `len' according to what STRING_CHAR_AND_LENGTH expects.
2051 (bidi_paragraph_init, bidi_resolve_explicit_1)
2052 (bidi_resolve_explicit, bidi_resolve_weak)
2053 (bidi_level_of_next_char, bidi_move_to_visually_next):
2054 Support iteration over a string.
2055 (bidi_set_sor_type, bidi_resolve_explicit_1)
2056 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2057 can now be zero (for strings); special values 0 and -1 were
2058 changed to -1 and -2, respectively.
2059 (bidi_char_at_pos): New function.
2060 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2061 Call it instead of FETCH_MULTIBYTE_CHAR.
2062 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2063 initialized to valid values.
2064 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2065 values.
2066 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2067 the test for valid cached positions. Fix the logic for looking up
2068 the sentinel state in the cache. GCPRO the Lisp string we are
2069 iterating.
2070 (bidi_push_it, bidi_pop_it): New functions.
2071 (bidi_initialize): Initialize the bidi cache start stack pointer.
2072 (bidi_cache_ensure_space): New function, refactored from part of
2073 bidi_cache_iterator_state. Don't assume the required size is just
2074 one BIDI_CACHE_CHUNK away.
2075 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2076 (bidi_count_bytes, bidi_char_at_pos): New functions.
2077 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2078 always valid if bidi_cache_idx is valid.
2079 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2080 is valid if it's going to be used.
2081 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2082 (bidi_cache_fetch_state, bidi_cache_search)
2083 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2084 (bidi_cache_iterator_state, bidi_cache_find)
2085 (bidi_find_other_level_edge, bidi_cache_start_stack):
2086 All variables related to cache indices are now EMACS_INT.
2087
2088 * dispextern.h (struct bidi_string_data): New structure.
2089 (struct bidi_it): New member `string'. Make flag members be 1-bit
2090 fields, and put them last in the struct.
2091 (compute_display_string_pos, compute_display_string_end):
2092 Update prototypes.
2093 (bidi_push_it, bidi_pop_it): Add prototypes.
2094 (struct iterator_stack_entry): New members bidi_p,
2095 paragraph_embedding, and from_disp_prop_p.
2096 (struct it): Member bidi_p is now a bit field 1 bit wide.
2097 (bidi_shelve_cache, bidi_unshelve_cache):
2098 Declare prototypes.
2099
2100 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2101 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2102 and vector-like objects.
2103
2104 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2105 cache around display iteration.
2106
2107 * window.c (Fwindow_end, window_scroll_pixel_based)
2108 (displayed_window_lines, Frecenter): Save and restore the bidi
2109 cache around display iteration.
2110
2111 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2112
2113 * editfns.c (Fdelete_region): Clarify the use of the named
2114 parameters (bug#6788).
2115
2116 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2117
2118 * indent.c (Fvertical_motion): Set and restore w->pointm when
2119 saving and restoring the window's buffer (Bug#9006).
2120
2121 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2122
2123 * editfns.c (Fstring_to_char): Clarify just what is returned
2124 (bug#6576). Text by Eli Zaretskii.
2125
2126 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2127
2128 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2129
2130 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2131
2132 * buffer.c (mmap_find): Fix a typo.
2133
2134 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2135
2136 Fix execution of x selection hooks.
2137 * xselect.c (Qx_lost_selection_functions)
2138 (Qx_sent_selection_functions): New vars.
2139 (syms_of_xselect): DEFSYM them.
2140 (x_handle_selection_request): Pass Qx_sent_selection_functions
2141 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2142 (x_handle_selection_clear,x_clear_frame_selections):
2143 Pass Qx_lost_selection_functions rather than
2144 Vx_lost_selection_functions to Frun_hook_with_args.
2145
2146 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2147
2148 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2149 The old code sometimes used this field without initializing it.
2150
2151 * alloc.c (gc_sweep): Don't read past end of array.
2152 In theory, the old code could also have corrupted Emacs internals,
2153 though it'd be very unlikely.
2154
2155 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2156
2157 * character.c (Fcharacterp): Don't advertise optional ignored
2158 argument. (Bug#4026)
2159
2160 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2161
2162 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2163 key" (bug#4257).
2164
2165 * window.c (Fset_window_start): Doc fix (bug#4199).
2166 (Fset_window_hscroll): Ditto.
2167
2168 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2169
2170 Fix minor new problems caught by GCC 4.6.1.
2171 * term.c (init_tty): Remove unused local.
2172 * xsettings.c (store_monospaced_changed): Define this function only
2173 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2174 not used otherwise.
2175
2176 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2177
2178 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2179
2180 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2181
2182 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2183 are the mini-buffer and the echo area (bug#3320).
2184
2185 * term.c (init_tty): Remove support for supdup, c10 and perq
2186 terminals, which are no longer supported (bug#1482).
2187
2188 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2189
2190 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2191
2192 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2193
2194 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2195 for non-popups (Bug#3642).
2196
2197 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2198
2199 * alloc.c (reset_malloc_hooks): Protoize.
2200 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2201 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2202 * cm.c (losecursor): Likewise.
2203 * data.c (fmod): Likewise.
2204 * dispnew.c (swap_glyphs_in_rows): Likewise.
2205 * emacs.c (memory_warning_signal): Likewise.
2206 * floatfns.c (float_error): Likewise.
2207 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2208 (otf_open, font_otf_capability, generate_otf_features)
2209 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2210 Likewise.
2211 * image.c (pbm_read_file): Likewise.
2212 * indent.c (string_display_width): Likewise.
2213 * intervals.c (check_for_interval, search_for_interval)
2214 (inc_interval_count, count_intervals, root_interval)
2215 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2216 * lread.c (defalias): Likewise.
2217 * ralloc.c (r_alloc_check): Likewise.
2218 * regex.c (set_image_of_range_1, set_image_of_range)
2219 (regex_grow_registers): Likewise.
2220 * sysdep.c (strerror): Likewise.
2221 * termcap.c (valid_filename_p, tprint, main): Likewise.
2222 * tparam.c (main): Likewise.
2223 * unexhp9k800.c (run_time_remap, save_data_space)
2224 (update_file_ptrs, read_header, write_header, calculate_checksum)
2225 (copy_file, copy_rest, display_header): Likewise.
2226 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2227 Likewise.
2228 * xdisp.c (check_it): Likewise.
2229 * xfaces.c (register_color, unregister_color, unregister_colors):
2230 Likewise.
2231 * xfns.c (print_fontset_result): Likewise.
2232 * xrdb.c (member, fatal, main): Likewise.
2233
2234 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2235
2236 Fix minor problems found by static checking (Bug#9031).
2237 * chartab.c (char_table_set_range, map_sub_char_table):
2238 Remove unused locals.
2239 (uniprop_table): Now static.
2240 * composite.c (_work_char): Remove unused static var.
2241
2242 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2243
2244 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2245
2246 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2247
2248 * gtkutil.c (qttip_cb): Remove code without function.
2249
2250 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2251
2252 * w32.c (pthread_sigmask): New stub.
2253
2254 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2255
2256 Use pthread_sigmask, not sigprocmask (Bug#9010).
2257 sigprocmask is portable only for single-threaded applications, and
2258 Emacs can be multi-threaded when it uses GTK.
2259 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2260 (LIBES): Use it.
2261 * callproc.c (Fcall_process):
2262 * process.c (create_process):
2263 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2264 Use pthread_sigmask, not sigprocmask.
2265
2266 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2267
2268 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2269 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2270 wrong (Bug#8591).
2271
2272 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2273
2274 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2275 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2276 (xg_hide_tooltip): Fix comment.
2277
2278 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2279 in registerServicesMenuSendTypes.
2280 (validRequestorForSendType): Don't check ns_return_types.
2281
2282 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2283 ns_return_type.
2284
2285 2011-07-08 Jason Rumney <jasonr@gnu.org>
2286
2287 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2288 frame struct members of non-existent frames (Bug#6284).
2289
2290 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2291
2292 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2293 variable firstTime not needed on OSX >= 10.6.
2294 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2295 >= 10.5. Use setKnobProportion, setDoubleValue.
2296
2297 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2298 (MAC_OS_X_VERSION_10_5): Define if not defined.
2299 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2300 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2301 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2302
2303 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2304 cString and lossyCString on OSX >= 10.4
2305
2306 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2307 sizeToFit on OSX >= 10.2.
2308
2309 * nsimage.m (allocInitFromFile): Don't use deprecated method
2310 bestRepresentationForDevice on OSX >= 10.6.
2311
2312 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2313 to avoid warning.
2314
2315 * emacs.c: Declare unexec_init_emacs_zone.
2316
2317 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2318
2319 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2320
2321 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2322 on svcsMenu (Bug#8842).
2323
2324 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2325 ns_return_types.
2326 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2327
2328 * nsterm.m (QUTF8_STRING): Declare.
2329 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2330 (validRequestorForSendType): Return type is (id).
2331 Change indexOfObjectIdenticalTo to indexOfObject.
2332 Check if we have local selection before returning self (Bug#8842).
2333 (writeSelectionToPasteboard): Put local selection into paste board
2334 if we have a local selection (Bug#8842).
2335 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2336
2337 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2338 (ns_get_local_selection): Declare.
2339
2340 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2341
2342 * keymap.c (describe_map_tree): Don't insert a double newline at
2343 the end of the buffer (bug#1169) and return whether we inserted
2344 something.
2345
2346 * callint.c (Fcall_interactively): Change "reading args" to
2347 "providing args" to try to clarify what it does (bug#1010).
2348
2349 2011-07-07 Kenichi Handa <handa@m17n.org>
2350
2351 * composite.c (composition_compute_stop_pos): Ignore a static
2352 composition starting before CHARPOS (Bug#8915).
2353
2354 * xdisp.c (handle_composition_prop): Likewise.
2355
2356 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2357
2358 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2359 (Bug#9015)
2360
2361 2011-07-07 Kenichi Handa <handa@m17n.org>
2362
2363 * character.h (unicode_category_t): New enum type.
2364
2365 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2366 (Qchar_code_property_table): New variable.
2367 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2368 (UNIPROP_COMPRESSED_FORM_P): New macros.
2369 (char_table_ascii): Uncompress the compressed values.
2370 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2371 Uncompress the compressed values.
2372 (sub_char_table_ref_and_range): Likewise.
2373 (char_table_ref_and_range): Uncompress the compressed values.
2374 (sub_char_table_set): New arg is_uniprop. Callers changed.
2375 Uncompress the compressed values.
2376 (sub_char_table_set_range): Args changed. Callers changed.
2377 (char_table_set_range): Adjuted for the above change.
2378 (map_sub_char_table): Delete args default_val and parent. Add arg
2379 top. Give decoded values to a Lisp function.
2380 (map_char_table): Adjust for the above change. Give decoded
2381 values to a Lisp function. Gcpro more variables.
2382 (uniprop_table_uncompress)
2383 (uniprop_decode_value_run_length): New functions.
2384 (uniprop_decoder, uniprop_decoder_count): New variables.
2385 (uniprop_get_decoder, uniprop_encode_value_character)
2386 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2387 New functions.
2388 (uniprop_encoder, uniprop_encoder_count): New variables.
2389 (uniprop_get_encoder, uniprop_table)
2390 (Funicode_property_table_internal, Fget_unicode_property_internal)
2391 (Fput_unicode_property_internal): New functions.
2392 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2393 Sunicode_property_table_internal, Sget_unicode_property_internal,
2394 and Sput_unicode_property_internal. Defvar_lisp
2395 char-code-property-alist.
2396
2397 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2398 Vunicode_category_table.
2399
2400 * font.c (font_range): Adjust for the change of
2401 Vunicode_category_table.
2402
2403 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2404
2405 * m/iris4d.h: Remove file, move contents ...
2406 * s/irix6-5.h: ... here.
2407
2408 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2409
2410 Remove unportable assumption about struct layout (Bug#8884).
2411 * alloc.c (mark_buffer):
2412 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2413 (clone_per_buffer_values): Don't assume that
2414 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2415 This isn't true in general, and it's particularly not true
2416 if Emacs is configured with --with-wide-int.
2417 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2418 New macros, used in the buffer.c change.
2419
2420 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2421
2422 * xsettings.c: Use both GConf and GSettings if both are available.
2423 (store_config_changed_event): Add comment.
2424 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2425 (store_tool_bar_style_changed): New functions.
2426 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2427 (struct xsettings): Move font inside HAVE_XFT.
2428 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2429 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2430 Move inside HAVE_XFT.
2431 (something_changed_gsettingsCB): Rename from something_changedCB.
2432 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2433 also.
2434 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2435 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2436 (something_changed_gconfCB): Rename from something_changedCB.
2437 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2438 (parse_settings): Move check for font inside HAVE_XFT.
2439 (read_settings, apply_xft_settings): Add comment.
2440 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2441 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2442 call store_font_name_changed.
2443 (xft_settings_event): Add comment.
2444 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2445 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2446 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2447 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2448 (xsettings_initialize): Call init_gsettings last.
2449 (xsettings_get_system_font, xsettings_get_system_normal_font):
2450 Add comment.
2451
2452 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2453
2454 Random fixes. E.g., (random) never returned negative values.
2455 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2456 subseconds part to the entropy, as that's a bit more random.
2457 Prefer signed to unsigned, since the signedness doesn't matter and
2458 in general we prefer signed. When given a limit, use a
2459 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2460 latter isn't right if USE_2_TAGS_FOR_INTS.
2461 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2462 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2463
2464 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2465
2466 * textprop.c (text_property_stickiness):
2467 Obey Vtext_property_default_nonsticky.
2468 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2469 * w32fns.c (syms_of_w32fns):
2470 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2471
2472 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2473
2474 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2475 This is more efficient than Ffile_directory_p and avoids a minor race.
2476
2477 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2478
2479 * buffer.c (Foverlay_put): Say what the return value is
2480 (bug#7835).
2481
2482 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2483 is a directory before asking whether to use the file name
2484 (bug#7564).
2485 (barf_or_query_if_file_exists): Make the "File is a directory"
2486 error be more correct.
2487
2488 * fns.c (Frequire): Remove the mention of the .gz files, since
2489 that's installation-specific, but keep the mention of
2490 `get-load-suffixes'.
2491
2492 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2493
2494 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2495 Report string overflow if the output is too long.
2496
2497 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2498
2499 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2500 (syms_of_gnutls): Remove duplicate DEFSYM for
2501 Qgnutls_bootprop_verify_hostname_error, an error for
2502 Qgnutls_bootprop_verify_error (which is no longer used).
2503
2504 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2505 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2506 Also (re)move comments that are misplaced or no longer relevant.
2507
2508 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2509
2510 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2511
2512 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2513
2514 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2515 and background color parameters if they have been changed.
2516
2517 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2518
2519 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2520
2521 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2522
2523 * xsettings.c (SYSTEM_FONT): Define only when used.
2524 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2525
2526 * keymap.c (access_keymap_1): Now static.
2527
2528 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2529
2530 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2531 leave any prefix arg for the up event (Bug#1586).
2532
2533 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2534
2535 * lread.c (syms_of_lread): Mention single symbols defined by
2536 `defvar' or `defconst' (bug#7154).
2537
2538 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2539 (Frequire): Mention get-load-suffixes.
2540
2541 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2542
2543 * window.h (window): Remove clone_number slot.
2544 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2545 Remove.
2546 (make_parent_window, make_window, saved_window)
2547 (Fset_window_configuration, save_window_save): Don't deal with
2548 clone numbers.
2549 * buffer.c (Qclone_number): Remove declaration.
2550 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2551
2552 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2553
2554 Add multiple inheritance to keymaps.
2555 * keymap.c (Fmake_composed_keymap): New function.
2556 (Fset_keymap_parent): Simplify.
2557 (fix_submap_inheritance): Remove.
2558 (access_keymap_1): New function extracted from access_keymap to handle
2559 embedded parents and handle lists of maps.
2560 (access_keymap): Use it.
2561 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2562 (Fcopy_keymap): Handle embedded parents.
2563 (Fcommand_remapping, define_as_prefix): Simplify.
2564 (Fkey_binding): Simplify.
2565 (syms_of_keymap): Move minibuffer-local-completion-map,
2566 minibuffer-local-filename-completion-map,
2567 minibuffer-local-must-match-map, and
2568 minibuffer-local-filename-must-match-map to Elisp.
2569 (syms_of_keymap): Defsubr make-composed-keymap.
2570 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2571 (parse_menu_item): Trivial simplification.
2572
2573 2011-07-01 Glenn Morris <rgm@gnu.org>
2574
2575 * Makefile.in (SETTINGS_LIBS): Fix typo.
2576
2577 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2578
2579 * coding.c (Fencode_coding_string): Record the last coding system
2580 used, as the function doc string says (bug#8738).
2581
2582 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2583
2584 * xsettings.c (store_monospaced_changed): Take new font as arg and
2585 check for change against current_mono_font.
2586 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2587 (emacs_settings_constructor, emacs_settings_get_property)
2588 (emacs_settings_set_property, emacs_settings_class_init)
2589 (emacs_settings_init, gsettings_obj): Remove.
2590 (something_changedCB): New function for HAVE_GSETTINGS.
2591 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2592 with value as argument.
2593 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2594 g_settings_new (Bug#8967). Do not create gsettings_obj.
2595 Remove calls to g_settings_bind. Connect something_changedCB to
2596 "changed".
2597
2598 * xgselect.c: Add defined (HAVE_GSETTINGS).
2599 (xgselect_initialize): Ditto.
2600
2601 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2602 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2603 xg_select.
2604
2605 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2606
2607 * eval.c (struct backtrace): Simplify and port the data structure.
2608 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2609 signed bit field, as this assumption is not portable and it makes
2610 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2611 "char debug_on_exit : 1" as this is not portable either; instead,
2612 use the portable "unsigned int debug_on_exit : 1". Remove unused
2613 member evalargs. Remove obsolete comments about cc bombing out.
2614
2615 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2616
2617 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2618 Let HAVE_GSETTINGS override HAVE_GCONF.
2619 (store_monospaced_changed): New function.
2620 (EMACS_SETTINGS): A new type derived from GObject to handle
2621 GSettings notifications.
2622 (emacs_settings_constructor, emacs_settings_get_property)
2623 (emacs_settings_set_property, emacs_settings_class_init):
2624 New functions.
2625 (gsettings_client, gsettings_obj): New variables.
2626 (GSETTINGS_SCHEMA): New define.
2627 (something_changedCB): Call store_monospaced_changed.
2628 (init_gsettings): New function.
2629 (xsettings_initialize): Call init_gsettings.
2630 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2631 to NULL.
2632
2633 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2634 GCONF_CFLAGS/LIBS.
2635
2636 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2637
2638 * window.c (resize_root_window, grow_mini_window)
2639 (shrink_mini_window): Rename Qresize_root_window to
2640 Qwindow_resize_root_window and Qresize_root_window_vertically to
2641 Qwindow_resize_root_window_vertically.
2642
2643 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2644
2645 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2646
2647 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2648
2649 * makefile.w32-in: Redesign dependencies so they reflect more
2650 clearly which files are directly included by each source file,
2651 and not through other includes.
2652
2653 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2654
2655 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2656 (sort_overlays, overlay_strings): When an overlay's clone number
2657 matches the window's clone number process the overlay even if
2658 the overlay's window property doesn't match the current window.
2659
2660 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2661 (Fwindow_hchild): Rename to Fwindow_left_child.
2662 (Fwindow_next): Rename to Fwindow_next_sibling.
2663 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2664 (resize_window_check): Rename to window_resize_check.
2665 (resize_window_apply): Rename to window_resize_apply.
2666 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2667 (Fdelete_other_windows_internal, resize_frame_windows)
2668 (Fsplit_window_internal, Fdelete_window_internal)
2669 (grow_mini_window, shrink_mini_window)
2670 (Fresize_mini_window_internal): Fix callers accordingly.
2671
2672 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2673
2674 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2675 (emacs_fixed_set_min_size): Remove.
2676 (emacs_fixed_new): Take frame as argument.
2677
2678 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2679 (_EmacsFixedPrivate): Remove minwidth/height.
2680 Add struct frame *f.
2681 (emacs_fixed_init): Initialize priv->f.
2682 (get_parent_class, emacs_fixed_set_min_size): Remove.
2683 (emacs_fixed_new): Set priv->f to argument.
2684 (emacs_fixed_get_preferred_width)
2685 (emacs_fixed_get_preferred_height): Use min_width/height from
2686 frames size_hint to set minimum and natural (Bug#8919).
2687 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2688 and use min_width/height from frames size_hint to set
2689 min_width/height (Bug#8919).
2690
2691 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2692 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2693 Fix indentation.
2694
2695 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2696
2697 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2698 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2699 called at ZV.
2700
2701 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2702
2703 * process.c (wait_reading_process_output): Bypass select if
2704 waiting for a cell while ignoring keyboard input, and input is
2705 pending. Suggested by Jan Djärv (Bug#8869).
2706
2707 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2708
2709 Use gnulib's dup2 module instead of rolling our own.
2710 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2711
2712 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2713
2714 * dispnew.c (scrolling_window): Before scrolling, turn off a
2715 mouse-highlight in the window being scrolled.
2716
2717 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2718
2719 Move DEFSYM to lisp.h and use everywhere.
2720
2721 * character.h (DEFSYM): Move declaration...
2722 * lisp.h (DEFSYM): ...here.
2723
2724 * gnutls.c:
2725 * minibuf.c:
2726 * w32menu.c:
2727 * w32proc.c:
2728 * w32select.c: Don't include character.h.
2729
2730 * alloc.c (syms_of_alloc):
2731 * buffer.c (syms_of_buffer):
2732 * bytecode.c (syms_of_bytecode):
2733 * callint.c (syms_of_callint):
2734 * casefiddle.c (syms_of_casefiddle):
2735 * casetab.c (init_casetab_once):
2736 * category.c (init_category_once, syms_of_category):
2737 * ccl.c (syms_of_ccl):
2738 * cmds.c (syms_of_cmds):
2739 * composite.c (syms_of_composite):
2740 * dbusbind.c (syms_of_dbusbind):
2741 * dired.c (syms_of_dired):
2742 * dispnew.c (syms_of_display):
2743 * doc.c (syms_of_doc):
2744 * editfns.c (syms_of_editfns):
2745 * emacs.c (syms_of_emacs):
2746 * eval.c (syms_of_eval):
2747 * fileio.c (syms_of_fileio):
2748 * fns.c (syms_of_fns):
2749 * frame.c (syms_of_frame):
2750 * fringe.c (syms_of_fringe):
2751 * insdel.c (syms_of_insdel):
2752 * keymap.c (syms_of_keymap):
2753 * lread.c (init_obarray, syms_of_lread):
2754 * macros.c (syms_of_macros):
2755 * msdos.c (syms_of_msdos):
2756 * print.c (syms_of_print):
2757 * process.c (syms_of_process):
2758 * search.c (syms_of_search):
2759 * sound.c (syms_of_sound):
2760 * syntax.c (init_syntax_once, syms_of_syntax):
2761 * terminal.c (syms_of_terminal):
2762 * textprop.c (syms_of_textprop):
2763 * undo.c (syms_of_undo):
2764 * w32.c (globals_of_w32):
2765 * window.c (syms_of_window):
2766 * xdisp.c (syms_of_xdisp):
2767 * xfaces.c (syms_of_xfaces):
2768 * xfns.c (syms_of_xfns):
2769 * xmenu.c (syms_of_xmenu):
2770 * xsettings.c (syms_of_xsettings):
2771 * xterm.c (syms_of_xterm): Use DEFSYM.
2772
2773 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2774
2775 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2776
2777 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2778
2779 Integer and buffer overflow fixes (Bug#8873).
2780
2781 * print.c (printchar, strout): Check for string overflow.
2782 (PRINTPREPARE, printchar, strout):
2783 Don't set size unless allocation succeeds.
2784
2785 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2786 for sizes. Check for string overflow more accurately.
2787 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2788
2789 * macros.c: Integer and buffer overflow fixes.
2790 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2791 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2792 Use ptrdiff_t, not int, for sizes.
2793 Don't increment bufsize until after realloc succeeds.
2794 Check for size-calculation overflow.
2795 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2796
2797 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2798
2799 * lread.c: Integer overflow fixes.
2800 (read_integer): Radix is now EMACS_INT, not int,
2801 to improve quality of diagnostics for out-of-range radices.
2802 Calculate buffer size correctly for out-of-range radices.
2803 (read1): Check for integer overflow in radices, and in
2804 read-circle numbers.
2805 (read_escape): Avoid int overflow.
2806 (Fload, openp, read_buffer_size, read1)
2807 (substitute_object_recurse, read_vector, read_list, map_obarray):
2808 Use ptrdiff_t, not int, for sizes.
2809 (read1): Use EMACS_INT, not int, for sizes.
2810 Check for size overflow.
2811
2812 * image.c (cache_image): Check for size arithmetic overflow.
2813
2814 * lread.c: Integer overflow issues.
2815 (saved_doc_string_size, saved_doc_string_length)
2816 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2817 Now ptrdiff_t, not int.
2818 (read1): Don't assume doc string length fits in int. Check for
2819 out-of-range doc string lengths.
2820 (read_list): Don't assume file position fits in int.
2821 (read_escape): Check for hex character overflow.
2822
2823 2011-06-22 Leo Liu <sdl.web@gmail.com>
2824
2825 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2826 Move to minibuffer.el.
2827
2828 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2829
2830 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2831 The following patches are for when GLYPH_DEBUG && !XASSERT.
2832 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2833 * dispnew.c (flush_stdout):
2834 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2835 Mark as externally visible.
2836 * dispnew.c (check_window_matrix_pointers): Now static.
2837 * dispnew.c (window_to_frame_vpos):
2838 * xfns.c (unwind_create_frame):
2839 * xterm.c (x_check_font): Remove unused local.
2840 * scroll.c (CHECK_BOUNDS):
2841 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2842 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2843 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2844 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2845 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2846 Now static.
2847 (debug_method_add): Use va_list and vsprintf rather than relying
2848 on undefined behavior with wrong number of arguments.
2849 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2850 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2851 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2852 since we're not interested in debugging glyphs with old libraries.
2853 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2854 GCC 4.6.0's static checking.
2855
2856 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2857
2858 Integer overflow and signedness fixes (Bug#8873).
2859 A few related buffer overrun fixes, too.
2860
2861 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2862
2863 * dispextern.h (struct face.stipple):
2864 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2865 (x_bitmap_mask, x_allocate_bitmap_record)
2866 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2867 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2868 (x_create_bitmap_from_xpm_data):
2869 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2870 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2871 (.bitmaps_last):
2872 * xfaces.c (load_pixmap):
2873 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2874 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2875 (.bitmaps_last, struct x_output.icon_bitmap):
2876 Use ptrdiff_t, not int, for bitmap indexes.
2877 (x_allocate_bitmap_record): Check for size overflow.
2878 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2879
2880 Use ptrdiff_t, not int, for overlay counts.
2881 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2882 * editfns.c (overlays_around, get_pos_property):
2883 * textprop.c (get_char_property_and_overlay):
2884 * xdisp.c (next_overlay_change, note_mouse_highlight):
2885 * xfaces.c (face_at_buffer_position):
2886 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2887 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2888 (Fnext_overlay_change, Fprevious_overlay_change)
2889 (mouse_face_overlay_overlaps, Foverlays_in):
2890 Use ptrdiff_t, not int, for sizes.
2891 (overlays_at, overlays_in): Check for size-calculation overflow.
2892
2893 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2894
2895 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2896 (x_session_initialize): Do not assume string length fits in int.
2897
2898 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2899 This is unlikely, but can occur if DPI is outlandish.
2900
2901 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2902 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2903
2904 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2905 * xrdb.c (magic_file_p, search_magic_path):
2906 Omit last arg SUFFIX; it was always 0. All callers changed.
2907 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2908
2909 * xfont.c (xfont_match): Avoid need for strlen.
2910
2911 * xfns.c: Don't assume strlen fits in int.
2912 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2913
2914 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2915 not unsigned long, as we prefer signed integers. All callers changed.
2916 Detect integer overflow in repeat count.
2917 (message_dolog): Don't assume print length fits in 39 bytes.
2918 (display_mode_element): Don't assume strlen fits in int.
2919
2920 * termcap.c: Don't assume sizes fit in int and never overflow.
2921 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2922 (gobble_line): Check for size-calculation overflow.
2923
2924 * minibuf.c (Fread_buffer):
2925 * lread.c (intern, intern_c_string):
2926 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2927 Don't assume string length fits in int.
2928
2929 * keyboard.c (parse_tool_bar_item):
2930 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2931
2932 * font.c: Don't assume string length fits in int.
2933 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2934 Use ptrdiff_t, not int.
2935 (font_intern_prop): Don't assume string length fits in int.
2936 Don't assume integer property fits in fixnum.
2937 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2938
2939 * filelock.c: Fix some buffer overrun and integer overflow issues.
2940 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2941 Reformulate so as not to need the command string.
2942 Invoke gzip -cd rather than gunzip, as it's more portable.
2943 (lock_info_type, lock_file_1, lock_file):
2944 Don't assume pid_t and time_t fit in unsigned long.
2945 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2946 (current_lock_owner): Prefer signed type for sizes.
2947 Use memcpy, not strncpy, where memcpy is what is really wanted.
2948 Don't assume (via atoi) that time_t and pid_t fit in int.
2949 Check for time_t and/or pid_t out of range, e.g., via a network share.
2950 Don't alloca where an auto var works fine.
2951
2952 * fileio.c: Fix some integer overflow issues.
2953 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2954 Don't assume string length fits in int.
2955 (directory_file_name): Don't assume string length fits in long.
2956 (make_temp_name): Don't assume pid fits in int, or that its print
2957 length is less than 20.
2958
2959 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2960
2961 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2962
2963 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2964
2965 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2966 We prefer signed integers, even for size calculations.
2967
2968 * emacs.c: Don't assume string length fits in 'int'.
2969 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2970 (main): Don't invoke strlen when not needed.
2971
2972 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2973 (XD_DEBUG_MESSAGE): Don't waste a byte.
2974
2975 * callproc.c (getenv_internal_1, getenv_internal)
2976 (Fgetenv_internal):
2977 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2978
2979 * lread.c (invalid_syntax): Omit length argument.
2980 All uses changed. This doesn't fix a bug, but it simplifies the
2981 code away from its former Hollerith-constant appearance, and it's
2982 one less 'int' to worry about when looking at integer-overflow issues.
2983 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2984
2985 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2986 This didn't break anything, but it didn't help either.
2987 It's confusing to put a bogus integer in a place where the actual
2988 value does not matter.
2989 (LIST_END_P): Remove unused macro and its bogus comment.
2990 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2991
2992 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2993 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2994 implementation.
2995 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2996 We prefer signed types, and the value cannot exceed the EMACS_INT
2997 range anyway (because otherwise the length would not be representable).
2998 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2999 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3000 This avoids a GCC warning when WIDE_EMACS_INT.
3001
3002 * indent.c (sane_tab_width): New function.
3003 (current_column, scan_for_column, Findent_to, position_indentation)
3004 (compute_motion): Use it. This is just for clarity.
3005 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3006
3007 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3008
3009 * lisp.h (lint_assume): New macro.
3010 * composite.c (composition_gstring_put_cache):
3011 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3012
3013 * editfns.c, insdel.c:
3014 Omit unnecessary forward decls, to simplify future changes.
3015
3016 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3017
3018 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3019
3020 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3021 Use much-faster test for byte-length change.
3022 Don't assume string byte-length fits in 'int'.
3023 Check that character arg fits in 'int'.
3024 (mapcar1): Declare byte as byte, for clarity.
3025
3026 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3027
3028 * fns.c (concat): Catch string overflow earlier.
3029 Do not rely on integer wraparound.
3030
3031 * dispextern.h (struct it.overlay_strings_charpos)
3032 (struct it.selective): Now EMACS_INT, not int.
3033 * xdisp.c (forward_to_next_line_start)
3034 (back_to_previous_visible_line_start)
3035 (reseat_at_next_visible_line_start, next_element_from_buffer):
3036 Don't arbitrarily truncate the value of 'selective' to int.
3037
3038 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3039
3040 * composite.c: Don't truncate sizes to 'int'.
3041 (composition_gstring_p, composition_reseat_it)
3042 (composition_adjust_point): Use EMACS_INT, not int.
3043 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3044 not EMACS_UINT, for indexes.
3045
3046 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3047
3048 * buffer.c: Include <verify.h>.
3049 (struct sortvec.priority, struct sortstr.priority):
3050 Now EMACS_INT, not int.
3051 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3052 (struct sortstr.size, record_overlay_string)
3053 (struct sortstrlist.size, struct sortlist.used):
3054 Don't truncate size to int.
3055 (record_overlay_string): Check for size-calculation overflow.
3056 (init_buffer_once): Check at compile-time, not run-time.
3057
3058 2011-06-22 Jim Meyering <meyering@redhat.com>
3059
3060 Don't leak an XBM-image-sized buffer
3061 * image.c (xbm_load): Free the image buffer after using it.
3062
3063 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3064
3065 Port to Sun C.
3066 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3067 that Sun C diagnosed.
3068 * fns.c (secure_hash): Fix pointer signedness issue.
3069 * intervals.c (static_offset_intervals): New function.
3070 (offset_intervals): Use it.
3071
3072 2011-06-21 Leo Liu <sdl.web@gmail.com>
3073
3074 * deps.mk (fns.o):
3075 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3076 sha512.h.
3077
3078 * fns.c (secure_hash): Rename from crypto_hash_function and change
3079 the first arg to accept symbols.
3080 (Fsecure_hash): New primitive.
3081 (syms_of_fns): New symbols.
3082
3083 2011-06-20 Deniz Dogan <deniz@dogan.se>
3084
3085 * process.c (Fset_process_buffer): Clarify return value in
3086 docstring.
3087
3088 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3089
3090 * dispnew.c (add_window_display_history): Use BVAR.
3091
3092 * xdisp.c (debug_method_add): Use BVAR.
3093 (check_window_end, dump_glyph_matrix, dump_glyph)
3094 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3095
3096 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3097 Likewise.
3098
3099 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3100 check till after the cache is created in init_frame_faces.
3101
3102 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3103
3104 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3105
3106 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3107
3108 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3109 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3110 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3111
3112 Improve buffer-overflow checking (Bug#8873).
3113 * fileio.c (Finsert_file_contents):
3114 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3115 Remove the old (too-loose) buffer overflow checks.
3116 They weren't needed, since make_gap checks for buffer overflow.
3117 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3118 The old code merely checked for Emacs fixnum overflow, and relied
3119 on undefined (wraparound) behavior. The new code avoids undefined
3120 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3121
3122 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3123 Tune. Don't use wider integers than needed. Don't use alloca.
3124 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3125
3126 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3127
3128 * insdel.c, lisp.h (buffer_overflow): New function.
3129 (insert_from_buffer_1, replace_range, replace_range_2):
3130 * insdel.c (make_gap_larger):
3131 * editfns.c (Finsert_char):
3132 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3133
3134 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3135
3136 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3137
3138 Integer overflow and signedness fixes (Bug#8873).
3139
3140 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3141 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3142
3143 * fileio.c: Don't assume EMACS_INT fits in off_t.
3144 (emacs_lseek): New static function.
3145 (Finsert_file_contents, Fwrite_region): Use it.
3146 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3147
3148 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3149
3150 * fns.c: Don't overflow int when computing a list length.
3151 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3152 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3153 truncation on 64-bit hosts. Check for QUIT every
3154 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3155 faster and is responsive enough.
3156 (Flength): Report an error instead of overflowing an integer.
3157 (Fsafe_length): Return a float if the value is not representable
3158 as a fixnum. This shouldn't happen except in contrived situations.
3159 (Fnthcdr, Fsort): Don't assume list length fits in int.
3160 (Fcopy_sequence): Don't assume vector length fits in int.
3161
3162 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3163 (header_size, word_size): New constants.
3164 (allocate_vectorlike): Don't check size overflow here.
3165 (allocate_vector): Check it here instead, since this is the only
3166 caller of allocate_vectorlike that could cause overflow.
3167 Check that the new vector's length is representable as a fixnum.
3168
3169 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3170 The previous code was bogus. For example, next_almost_prime (32)
3171 returned 39, which is undesirable as it is a multiple of 3; and
3172 next_almost_prime (24) returned 25, which is a multiple of 5 so
3173 why was the code bothering to check for multiples of 7?
3174
3175 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3176
3177 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3178
3179 Variadic C functions now count arguments with ptrdiff_t.
3180 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3181 Back then I didn't know that the Emacs coding style prefers signed int.
3182 Also, in the meantime I found a few more instances where arguments
3183 were being counted with int, which may truncate counts on 64-bit
3184 machines, or EMACS_INT, which may be unnecessarily wide.
3185 * lisp.h (struct Lisp_Subr.function.aMANY)
3186 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3187 Arg counts are now ptrdiff_t, not size_t.
3188 All variadic functions and their callers changed accordingly.
3189 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3190 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3191 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3192 * callint.c (Fcall_interactively): Check arg count for overflow,
3193 to avoid potential buffer overrun. Use signed char, not 'int',
3194 for 'varies' array, so that we needn't bother to check its size
3195 calculation for overflow.
3196 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3197 * eval.c (apply_lambda):
3198 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3199 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3200 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3201
3202 * callint.c (Fcall_interactively): Don't use index var as event count.
3203
3204 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3205 * mem-limits.h (SIZE): Remove; no longer used.
3206
3207 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3208
3209 Remove unnecessary casts.
3210 * xterm.c (x_term_init):
3211 * xfns.c (x_set_border_pixel):
3212 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3213 These aren't needed now that we assume ANSI C.
3214
3215 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3216 It's more likely to cause problems (due to unsigned overflow)
3217 than to cure them.
3218
3219 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3220
3221 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3222
3223 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3224
3225 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3226
3227 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3228
3229 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3230
3231 GLYPH_CODE_FACE returns EMACS_INT, not int.
3232 * dispextern.h (merge_faces):
3233 * xfaces.c (merge_faces):
3234 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3235 Don't assume EMACS_INT fits in int.
3236
3237 * character.h (CHAR_VALID_P): Remove unused parameter.
3238 * fontset.c, lisp.h, xdisp.c: All uses changed.
3239
3240 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3241
3242 * fns.c (concat): Minor tuning based on overflow analysis.
3243 This doesn't fix any bugs. Use int to hold character, instead
3244 of constantly refetching from Emacs object. Use XFASTINT, not
3245 XINT, for value known to be a character. Don't bother comparing
3246 a single byte to 0400, as it's always less.
3247
3248 * floatfns.c (Fexpt):
3249 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3250
3251 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3252 for characters.
3253
3254 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3255
3256 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3257 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3258 incorrectly succeed when S was a string, because 4294967386 was
3259 truncated before it was used.
3260
3261 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3262 Otherwise, an out-of-range integer could cause undefined behavior
3263 on a 64-bit host.
3264
3265 * composite.c: Use int, not EMACS_INT, for characters.
3266 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3267 EMACS_INT, for values that are known to be in character range.
3268 This doesn't fix any bugs but is the usual style inside Emacs and
3269 may generate better code on 32-bit machines.
3270
3271 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3272 This is for reasons similar to the recent CHAR_STRING fix.
3273 * charset.c (Fencode_char): Check that character arg is actually
3274 a character. Pass an int to ENCODE_CHAR.
3275 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3276 wider than 'int', as a compile-time check to prevent future regressions
3277 in this area.
3278
3279 * character.c (char_string): Remove unnecessary casts.
3280
3281 Make sure a 64-bit char is never passed to CHAR_STRING.
3282 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3283 by silently ignoring the top 32 bits, allowing some values
3284 that were far too large to be valid characters.
3285 * character.h: Include <verify.h>.
3286 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3287 arguments are no wider than unsigned, as a compile-time check
3288 to prevent future regressions in this area.
3289 * data.c (Faset):
3290 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3291 (Fsubst_char_in_region):
3292 * fns.c (concat):
3293 * xdisp.c (decode_mode_spec_coding):
3294 Adjust to CHAR_STRING's new requirement.
3295 * editfns.c (Finsert_char, Fsubst_char_in_region):
3296 * fns.c (concat): Check that character args are actually
3297 characters. Without this test, these functions did the wrong
3298 thing with wildly out-of-range values on 64-bit hosts.
3299
3300 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3301 These casts should not be needed on 32-bit hosts, either.
3302 * keyboard.c (read_char):
3303 * lread.c (Fload): Remove casts to unsigned.
3304
3305 * lisp.h (UNSIGNED_CMP): New macro.
3306 This fixes comparison bugs on 64-bit hosts.
3307 (ASCII_CHAR_P): Use it.
3308 * casefiddle.c (casify_object):
3309 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3310 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3311 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3312 * dispextern.h (FACE_FROM_ID):
3313 * keyboard.c (read_char): Use UNSIGNED_CMP.
3314
3315 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3316 not to EMACS_INT, to avoid GCC warning.
3317
3318 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3319
3320 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3321 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3322 isn't needed on 32-bit machines.
3323
3324 * buffer.c (Fgenerate_new_buffer_name):
3325 Use EMACS_INT for count, not int.
3326 (advance_to_char_boundary): Return EMACS_INT, not int.
3327
3328 * data.c (Qcompiled_function): Now static.
3329
3330 * window.c (window_body_lines): Now static.
3331
3332 * image.c (gif_load): Rename local to avoid shadowing.
3333
3334 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3335 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3336 * alloc.c (make_save_value): Integer argument is now of type
3337 ptrdiff_t, not int.
3338 (mark_object): Use ptrdiff_t, not int.
3339 * lisp.h (pD): New macro.
3340 * print.c (print_object): Use it.
3341
3342 * alloc.c: Use EMACS_INT, not int, to count objects.
3343 (total_conses, total_markers, total_symbols, total_vector_size)
3344 (total_free_conses, total_free_markers, total_free_symbols)
3345 (total_free_floats, total_floats, total_free_intervals)
3346 (total_intervals, total_strings, total_free_strings):
3347 Now EMACS_INT, not int. All uses changed.
3348 (Fgarbage_collect): Compute overall total using a double, so that
3349 integer overflow is less likely to be a problem. Check for overflow
3350 when converting back to an integer.
3351 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3352 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3353 These were 'int' variables that could overflow on 64-bit hosts;
3354 they were never used, so remove them instead of repairing them.
3355 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3356 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3357 Previously, this ceilinged at INT_MAX, but that doesn't work on
3358 64-bit machines.
3359 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3360
3361 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3362 (allocate_vectorlike): Check for ptrdiff_t overflow.
3363 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3364 when a (possibly-narrower) signed value would do just as well.
3365 We prefer using signed arithmetic, to avoid comparison confusion.
3366
3367 * alloc.c: Catch some string size overflows that we were missing.
3368 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3369 for convenience in STRING_BYTES_MAX.
3370 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3371 The definition here is exact; the one in lisp.h was approximate.
3372 (allocate_string_data): Check for string overflow. This catches
3373 some instances we weren't catching before. Also, it catches
3374 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3375 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3376 and ptrdiff_t and EMACS_INT are both 64 bits.
3377
3378 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3379 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3380 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3381
3382 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3383
3384 * alloc.c (Fmake_string): Check for out-of-range init.
3385
3386 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3387
3388 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3389
3390 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3391
3392 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3393 xg_get_default_scrollbar_width.
3394
3395 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3396 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3397 (style_changed_cb): Call update_theme_scrollbar_width and call
3398 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3399 all frames (Bug#8505).
3400 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3401 Call gtk_window_set_resizable if HAVE_GTK3.
3402 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3403 and height if HAVE_GTK3 (Bug#8505).
3404 (scroll_bar_width_for_theme): New variable.
3405 (update_theme_scrollbar_width): New function.
3406 (xg_get_default_scrollbar_width): Move code to
3407 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3408 (xg_initialize): Call update_theme_scrollbar_width.
3409
3410 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3411
3412 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3413
3414 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3415
3416 * frame.c (make_frame): Call other_buffer_safely instead of
3417 other_buffer.
3418
3419 * window.c (temp_output_buffer_show): Call display_buffer with
3420 second argument Vtemp_buffer_show_specifiers and reset latter
3421 immediately after the call.
3422 (Vtemp_buffer_show_specifiers): New variable.
3423 (auto_window_vscroll_p, next_screen_context_lines)
3424 (Vscroll_preserve_screen_position): Remove leading asterisks from
3425 doc-strings.
3426
3427 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3428
3429 Fix minor problems found by GCC 4.6.0 static checking.
3430 * buffer.c (Qclone_number): Remove for now, as it's unused.
3431 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3432 (record_buffer): Remove unused local.
3433 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3434 (set_frame_buffer_list): Remove; unused.
3435 * frame.h (other_visible_frames): Remove decl.
3436 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3437 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3438 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3439 if HAVE_GPM.
3440 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3441 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3442 Define only if HAVE_GPM.
3443 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3444 (update_hints_inhibit): Remove; never set. All uses removed.
3445 * widgetprv.h (emacsFrameClassRec): Remove decl.
3446 * window.c (delete_deletable_window): Now returns void, since it
3447 wasn't returning anything.
3448 (compare_window_configurations): Remove unused locals.
3449 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3450 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3451 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3452 the same widths as pointers. This follows up on the 2011-05-06 patch.
3453 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3454 * xterm.h: Likewise.
3455 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3456
3457 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3458
3459 * makefile.w32-in: Update dependencies.
3460 (LISP_H): Add lib/intprops.h.
3461
3462 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3463
3464 * image.c (gif_load): Add animation frame delay to the metadata.
3465 (syms_of_image): Use DEFSYM. New symbol `delay'.
3466
3467 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3468
3469 * window.c (delete_deletable_window): Re-add.
3470 (Fset_window_configuration): Rewrite to handle dead buffers and
3471 consequently deletable windows.
3472 (window_tree, Fwindow_tree): Remove. Supply functionality in
3473 window.el.
3474 (compare_window_configurations): Simplify code.
3475
3476 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3477
3478 * image.c (imagemagick_load_image): Fix type mismatch.
3479 (Fimagemagick_types): Likewise.
3480
3481 * window.h (replace_buffer_in_windows): Declare.
3482
3483 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3484
3485 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3486 Qclone_number. Remove external declaration of Qdelete_window.
3487 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3488 code.
3489 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3490 Run Qbuffer_list_update_hook if allowed.
3491 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3492 buffer list implementation.
3493 (other_buffer_safely): New function.
3494 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3495 calls to replace_buffer_in_windows and
3496 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3497 if allowed.
3498 (record_buffer): Inhibit quitting and rewrite using quittable
3499 functions. Run Qbuffer_list_update_hook if allowed.
3500 (Frecord_buffer, Funrecord_buffer): New functions.
3501 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3502 Move switch-to-buffer to window.el.
3503 (bury-buffer): Move to window.el.
3504 (Vbuffer_list_update_hook): New variable.
3505
3506 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3507 section.
3508
3509 * window.h (resize_frame_windows): Move up in code.
3510 (Fwindow_frame): Remove EXFUN.
3511 (replace_buffer_in_all_windows): Remove prototype.
3512 (replace_buffer_in_windows_safely): Add prototype.
3513
3514 * window.c: Declare Qdelete_window static again. Move down
3515 declaration of select_count.
3516 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3517 (Fother_window): Move to window.el.
3518 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3519 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3520 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3521 window.el.
3522 (replace_buffer_in_windows): Implement by calling
3523 Qreplace_buffer_in_windows.
3524 (replace_buffer_in_all_windows): Remove with some functionality
3525 moved into replace_buffer_in_windows_safely.
3526 (replace_buffer_in_windows_safely): New function.
3527 (select_window_norecord, select_frame_norecord): Move in front
3528 of run_window_configuration_change_hook. Remove now obsolete
3529 declarations.
3530 (Fset_window_buffer): Rewrite doc-string.
3531 Call Qrecord_window_buffer.
3532 (keys_of_window): Move binding for other-window to window.el.
3533
3534 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3535
3536 * dispextern.h (struct image): Replace data member, whose int_val
3537 and ptr_val fields were not used by anything, with a single
3538 lisp_val object.
3539
3540 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3541 (gif_clear_image, gif_load, imagemagick_load_image)
3542 (gs_clear_image, gs_load): Callers changed.
3543
3544 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3545
3546 * buffer.h: Include <time.h>, for time_t.
3547 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3548
3549 Fix minor problems found by static checking.
3550
3551 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3552
3553 Make identifiers static if they are not used in other modules.
3554 * data.c (Qcompiled_function, Qframe, Qvector):
3555 * image.c (QimageMagick, Qsvg):
3556 * minibuf.c (Qmetadata):
3557 * window.c (resize_window_check, resize_root_window): Now static.
3558 * window.h (resize_window_check, resize_root_window): Remove decls.
3559
3560 * window.c (window_deletion_count, delete_deletable_window):
3561 Remove; unused.
3562 (window_body_lines): Now static.
3563 (Fdelete_other_windows_internal): Mark vars as initialized.
3564 Make sure 'resize_failed' is initialized.
3565 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3566 (resize_window_apply): Remove unused local.
3567 * window.h (delete_deletable_window): Remove decl.
3568
3569 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3570 (imagemagick_load_image): Fix pointer signedness problem by changing
3571 last arg from unsigned char * to char *. All uses changed.
3572 Also, fix a local for similar reasons.
3573 Remove unused locals. Remove locals to avoid shadowing.
3574 (fn_rsvg_handle_free): Remove; unused.
3575 (svg_load, svg_load_image): Fix pointer signedness problem.
3576 (imagemagick_load_image): Don't use garbage pointer image_wand.
3577
3578 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3579
3580 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3581
3582 * image.c (gif_load): Fix omitted cast error introduced by
3583 2011-06-06 change.
3584
3585 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3586
3587 * window.h (resize_proportionally, orig_total_lines)
3588 (orig_top_line): Remove from window structure.
3589 (set_window_height, set_window_width, change_window_heights)
3590 (Fdelete_window): Remove prototypes.
3591 (resize_frame_windows): Remove duplicate declaration.
3592
3593 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3594
3595 * window.h (resize_frame_windows, resize_window_check)
3596 (delete_deletable_window, resize_root_window)
3597 (resize_frame_windows): Declare prototypes.
3598
3599 * window.c (resize_window_apply): Make definition be "static" to
3600 match the prototype.
3601
3602 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3603
3604 * window.c: Remove declarations of Qwindow_size_fixed,
3605 window_min_size_1, window_min_size_2, window_min_size,
3606 size_window, window_fixed_size_p, enlarge_window, delete_window.
3607 Remove static from declaration of Qdelete_window, it's
3608 temporarily needed by Fbury_buffer.
3609 (replace_window): Don't assign orig_top_line and
3610 orig_total_lines.
3611 (Fdelete_window, delete_window): Remove. Window deletion is
3612 handled by window.el.
3613 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3614 Replace Fdelete_window calls with calls to Qdelete_window.
3615 (Fdelete_other_windows): Remove. Deleting other windows is
3616 handled by window.el.
3617 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3618 handled in window.el.
3619 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3620 Window minimum sizes are handled in window.el.
3621 (shrink_windows, size_window, set_window_height)
3622 (set_window_width, change_window_heights, window_height)
3623 (window_width, CURBEG, CURSIZE, enlarge_window)
3624 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3625 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3626 handled in window.el.
3627 (make_dummy_parent): Rename to make_parent_window and give it a
3628 second argument horflag.
3629 (make_window): Don't set resize_proportionally any more.
3630 (Fsplit_window): Remove. Windows are split in window.el.
3631 (save_restore_action, save_restore_orig_size)
3632 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3633 Resize mini windows in window.el.
3634 (grow_mini_window, shrink_mini_window): Implement by calling
3635 Qresize_root_window_vertically, resize_window_check and
3636 resize_window_apply.
3637 (saved_window, Fset_window_configuration, save_window_save):
3638 Do not handle orig_top_line, orig_total_lines, and
3639 resize_proportionally.
3640 (window_min_height, window_min_width): Move to window.el.
3641 (keys_of_window): Move bindings for delete-other-windows,
3642 split-window, delete-window and enlarge-window to window.el.
3643
3644 * buffer.c: Temporarily extern Qdelete_window.
3645 (Fbury_buffer): Temporarily call Qdelete_window instead of
3646 Fdelete_window (Fbury_buffer will move to window.el soon).
3647
3648 * frame.c (set_menu_bar_lines_1): Remove code handling
3649 orig_top_line and orig_total_lines.
3650
3651 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3652 set_window_height but set heights directly.
3653 (change_frame_size_1): Use resize_frame_windows.
3654
3655 * xdisp.c (init_xdisp): Don't use set_window_height but set
3656 heights directly.
3657
3658 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3659 Use resize_frame_windows instead of change_window_heights and run
3660 run_window_configuration_change_hook.
3661
3662 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3663 instead of change_window_heights and run
3664 run_window_configuration_change_hook.
3665
3666 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3667
3668 * window.c (replace_window): Rename second argument REPLACEMENT to
3669 NEW. New third argument SETFLAG. Rewrite.
3670 (delete_window, make_dummy_parent): Call replace_window with
3671 third argument 1.
3672 (window_list_1): Move down in code.
3673 (run_window_configuration_change_hook): Move set_buffer part
3674 before select_frame_norecord part in order to unwind correctly.
3675 Rename count1 to count.
3676 (recombine_windows, delete_deletable_window, resize_root_window)
3677 (Fdelete_other_windows_internal)
3678 (Frun_window_configuration_change_hook, make_parent_window)
3679 (resize_window_check, resize_window_apply, Fresize_window_apply)
3680 (resize_frame_windows, Fsplit_window_internal)
3681 (Fdelete_window_internal, Fresize_mini_window_internal):
3682 New functions.
3683 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3684
3685 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3686
3687 * window.h (window): Add some new members to window structure -
3688 normal_lines, normal_cols, new_total, new_normal, clone_number,
3689 splits, nest, prev_buffers, next_buffers.
3690 (WINDOW_TOTAL_SIZE): Move here from window.c.
3691 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3692
3693 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3694 Remove.
3695 (make_dummy_parent): Set new members of windows structure.
3696 (make_window): Move down in code. Handle new members of window
3697 structure.
3698 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3699 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3700 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3701 (Fset_window_prev_buffers, Fwindow_next_buffers)
3702 (Fset_window_next_buffers, Fset_window_clone_number):
3703 New functions.
3704 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3705 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3706 Doc-string fixes.
3707 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3708 Argument WINDOW can be now internal window too.
3709 (Fwindow_use_time): Move up in code.
3710 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3711 Rewrite doc-string.
3712 (Fset_window_configuration, saved_window)
3713 (Fcurrent_window_configuration, save_window_save): Handle new
3714 members of window structure.
3715 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3716 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3717 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3718 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3719 Qget_mru_window, Qresize_root_window,
3720 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3721 Qauto_buffer_name; staticpro them.
3722
3723 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3724
3725 * window.c (Fwindow_total_size, Fwindow_left_column)
3726 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3727 (Fwindow_list_1): New functions.
3728 (window_box_text_cols): Replace with window_body_cols.
3729 (Fwindow_width, Fscroll_left, Fscroll_right):
3730 Use window_body_cols instead of window_box_text_cols.
3731 (delete_window, Fset_window_configuration):
3732 Call delete_all_subwindows with window as argument.
3733 (delete_all_subwindows): Take a window as argument and not a
3734 structure. Rewrite.
3735 (window_loop): Remove handling of GET_LRU_WINDOW and
3736 GET_LARGEST_WINDOW.
3737 (Fget_lru_window, Fget_largest_window): Move to window.el.
3738
3739 * window.h: Extern window_body_cols instead of
3740 window_box_text_cols. delete_all_subwindows now takes a
3741 Lisp_Object as argument.
3742
3743 * indent.c (compute_motion, Fcompute_motion):
3744 Use window_body_cols instead of window_box_text_cols.
3745
3746 * frame.c (delete_frame): Call delete_all_subwindows with root
3747 window as argument.
3748
3749 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3750
3751 * fns.c (Fputhash): Document return value.
3752
3753 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3754
3755 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3756
3757 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3758
3759 Cons<->int and similar integer overflow fixes (Bug#8794).
3760
3761 Check for overflow when converting integer to cons and back.
3762 * charset.c (Fdefine_charset_internal, Fdecode_char):
3763 Use cons_to_unsigned to catch overflow.
3764 (Fencode_char): Use INTEGER_TO_CONS.
3765 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3766 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3767 * data.c (long_to_cons, cons_to_long): Remove.
3768 (cons_to_unsigned, cons_to_signed): New functions.
3769 These signal an error for invalid or out-of-range values.
3770 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3771 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3772 * font.c (Ffont_variation_glyphs):
3773 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3774 * lisp.h: Include <intprops.h>.
3775 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3776 (cons_to_signed, cons_to_unsigned): New decls.
3777 (long_to_cons, cons_to_long): Remove decls.
3778 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3779 (Fprimitive_undo): Use CONS_TO_INTEGER.
3780 * xfns.c (Fx_window_property): Likewise.
3781 * xselect.c: Include <limits.h>.
3782 (x_own_selection, selection_data_to_lisp_data):
3783 Use INTEGER_TO_CONS.
3784 (x_handle_selection_request, x_handle_selection_clear)
3785 (x_get_foreign_selection, Fx_disown_selection_internal)
3786 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3787 (lisp_data_to_selection_data): Use cons_to_unsigned.
3788 (x_fill_property_data): Use cons_to_signed.
3789 Report values out of range.
3790
3791 Check for buffer and string overflow more precisely.
3792 * buffer.h (BUF_BYTES_MAX): New macro.
3793 * lisp.h (STRING_BYTES_MAX): New macro.
3794 * alloc.c (Fmake_string):
3795 * character.c (string_escape_byte8):
3796 * coding.c (coding_alloc_by_realloc):
3797 * doprnt.c (doprnt):
3798 * editfns.c (Fformat):
3799 * eval.c (verror):
3800 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3801 since they may not be the same number.
3802 * editfns.c (Finsert_char):
3803 * fileio.c (Finsert_file_contents):
3804 Likewise for BUF_BYTES_MAX.
3805
3806 * image.c: Use ptrdiff_t, not int, for sizes.
3807 (slurp_file): Switch from int to ptrdiff_t.
3808 All uses changed.
3809 (slurp_file): Check that file size fits in both size_t (for
3810 malloc) and ptrdiff_t (for sanity and safety).
3811
3812 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3813 if b->modtime has its maximal value.
3814
3815 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3816
3817 Don't assume time_t can fit into int.
3818 * buffer.h (struct buffer.modtime): Now time_t, not int.
3819 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3820 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3821
3822 Minor fixes for signed vs unsigned integers.
3823 * character.h (MAYBE_UNIFY_CHAR):
3824 * charset.c (maybe_unify_char):
3825 * keyboard.c (read_char, reorder_modifiers):
3826 XINT -> XFASTINT, since the integer must be nonnegative.
3827 * ftfont.c (ftfont_spec_pattern):
3828 * keymap.c (access_keymap, silly_event_symbol_error):
3829 XUINT -> XFASTINT, since the integer must be nonnegative.
3830 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3831 since it makes no difference and we prefer signed.
3832 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3833 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3834 nonnegative.
3835
3836 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3837
3838 * window.h (Fwindow_frame): Declare.
3839
3840 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3841
3842 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3843 (SPARE_MEMORY): Always define.
3844 (LARGE_REQUEST): Remove.
3845 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3846
3847 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3848
3849 * lisp.h: Move EXFUNS for Fframe_root_window,
3850 Fframe_first_window and Fset_frame_selected_window to window.h.
3851
3852 * window.h: Move EXFUNS for Fframe_root_window,
3853 Fframe_first_window and Fset_frame_selected_window here from
3854 lisp.h.
3855
3856 * frame.c (Fwindow_frame, Fframe_first_window)
3857 (Fframe_root_window, Fframe_selected_window)
3858 (Fset_frame_selected_window): Move to window.c.
3859 (Factive_minibuffer_window): Move to minibuf.c.
3860 (Fother_visible_frames_p): New function.
3861
3862 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3863
3864 * window.c (decode_window, decode_any_window): Move up in code.
3865 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3866 (inhibit_frame_unsplittable): Remove unused variable.
3867 (Fwindow_buffer): Move up and rewrite doc-string.
3868 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3869 (Fwindow_prev): New functions.
3870 (Fwindow_frame): Move here from frame.c. Accept any window as
3871 argument.
3872 (Fframe_root_window, Fframe_first_window)
3873 (Fframe_selected_window): Move here from frame.c. Accept frame
3874 or arbitrary window as argument. Update doc-strings.
3875 (Fminibuffer_window): Move up in code.
3876 (Fwindow_minibuffer_p): Move up in code and simplify.
3877 (Fset_frame_selected_window): Move here from frame.c.
3878 Marginal rewrite.
3879 (Fselected_window, select_window, Fselect_window): Move up in
3880 code. Minor doc-string fixes.
3881
3882 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3883
3884 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3885 Do not assume that spare memory exists; that assumption is valid
3886 only if SYSTEM_MALLOC.
3887 (LARGE_REQUEST): New macro, so that the issue of large requests
3888 is separated from the issue of spare memory.
3889
3890 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3891
3892 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3893 format. (Bug#8806)
3894
3895 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3896
3897 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3898 before statements.
3899
3900 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3901
3902 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3903
3904 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3905
3906 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3907 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3908
3909 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3910
3911 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3912
3913 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3914
3915 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3916 (x_clipboard_manager_save): Add return value.
3917 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3918 New error handlers.
3919 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3920 Obey Vx_select_enable_clipboard_manager. Catch errors in
3921 x_clipboard_manager_save (Bug#8779).
3922 (Vx_select_enable_clipboard_manager): New variable.
3923 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3924
3925 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3926
3927 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3928
3929 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3930
3931 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3932 in the current matrix if keep_current_p is non-zero.
3933
3934 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3935
3936 * bidi.c (bidi_level_of_next_char): Fix last change.
3937
3938 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3939
3940 Support bidi reordering of text covered by display properties.
3941
3942 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3943 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3944 (bidi_cache_search, bidi_cache_iterator_state)
3945 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3946 (bidi_level_of_next_char, bidi_move_to_visually_next):
3947 Support character positions inside a run of characters covered by a
3948 display string.
3949 (bidi_paragraph_init, bidi_resolve_explicit_1)
3950 (bidi_level_of_next_char): Call bidi_fetch_char and
3951 bidi_fetch_char_advance instead of FETCH_CHAR and
3952 FETCH_CHAR_ADVANCE.
3953 (bidi_init_it): Initialize new members.
3954 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3955 definitions.
3956 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3957 instead of using explicit *_CHAR codes.
3958 (bidi_resolve_explicit, bidi_resolve_weak):
3959 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3960 bidirectional text is supported only in multibyte buffers.
3961 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3962 it to initialize the frame_window_p member of struct bidi_it.
3963 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3964 (bidi_resolve_explicit, bidi_resolve_weak)
3965 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3966 bidi_it->nchars is non-positive.
3967 (bidi_level_of_next_char): Don't try to lookup the cache for the
3968 next/previous character if nothing is cached there yet, or if we
3969 were just reseat()'ed to a new position.
3970
3971 * xdisp.c (set_cursor_from_row): Set start and stop points
3972 according to the row's direction when priming the loop that looks
3973 for the glyph on which to display cursor.
3974 (single_display_spec_intangible_p): Function deleted.
3975 (display_prop_intangible_p): Reimplement to call
3976 handle_display_spec instead of single_display_spec_intangible_p.
3977 Accept 3 additional arguments needed by handle_display_spec.
3978 This fixes incorrect cursor motion across display property with complex
3979 values: lists, `(when COND...)' forms, etc.
3980 (single_display_spec_string_p): Support property values that are
3981 lists with the argument STRING its top-level element.
3982 (display_prop_string_p): Fix the condition for processing a
3983 property that is a list to be consistent with handle_display_spec.
3984 (handle_display_spec): New function, refactored from the
3985 last portion of handle_display_prop.
3986 (compute_display_string_pos): Accept additional argument
3987 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3988 value of a `display' property is a "replacing spec".
3989 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3990 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3991 the display property, but just return a value indicating whether
3992 the display property will replace the characters it covers.
3993 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3994 frame_window_p members of struct bidi_it.
3995 (compute_display_string_pos, compute_display_string_end):
3996 New functions.
3997 (push_it): Accept second argument POSITION, where pop_it should
3998 jump to continue iteration.
3999 (reseat_1): Initialize bidi_it.disp_pos.
4000
4001 * keyboard.c (adjust_point_for_property): Adjust the call to
4002 display_prop_intangible_p to its new signature.
4003
4004 * dispextern.h (struct bidi_it): New member frame_window_p.
4005 (bidi_init_it): Update prototypes.
4006 (display_prop_intangible_p): Update prototype.
4007 (compute_display_string_pos, compute_display_string_end):
4008 Declare prototypes.
4009 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4010 EMACS_INT.
4011
4012 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4013
4014 Malloc failure behavior now depends on size of allocation.
4015 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4016 * lisp.h: Change signatures accordingly.
4017 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4018 All callers changed. (Bug#8762)
4019
4020 * gnutls.c: Use Emacs's memory allocators.
4021 Without this change, the gnutls library would invoke malloc etc.
4022 directly, which causes problems on non-SYNC_INPUT hosts, and which
4023 runs afoul of improving memory_full behavior. (Bug#8761)
4024 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4025 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4026 xfree instead of the default malloc, realloc, free.
4027 (Fgnutls_boot): No need to check for memory allocation failure,
4028 since xmalloc does that for us.
4029
4030 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4031 * category.c (hash_get_category_set):
4032 * ccl.c (ccl_driver):
4033 * charset.c (Fdefine_charset_internal):
4034 * charset.h (struct charset.hash_index):
4035 * composite.c (get_composition_id, gstring_lookup_cache)
4036 (composition_gstring_put_cache):
4037 * composite.h (struct composition.hash_index):
4038 * dispextern.h (struct image.hash):
4039 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4040 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4041 (hashfn_equal, hashfn_user_defined, make_hash_table)
4042 (maybe_resize_hash_table, hash_lookup, hash_put)
4043 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4044 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4045 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4046 * image.c (make_image, search_image_cache, lookup_image)
4047 (xpm_put_color_table_h):
4048 * lisp.h (struct Lisp_Hash_Table):
4049 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4050 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4051 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4052 * alloc.c (allocate_vectorlike):
4053 Check for overflow in vector size calculations.
4054 * ccl.c (ccl_driver):
4055 Check for overflow when converting EMACS_INT to int.
4056 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4057 need to be updated by these changes.
4058 * fns.c (make_hash_table, maybe_resize_hash_table):
4059 Check for integer overflow with large hash tables.
4060 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4061 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4062 (SXHASH_REDUCE): New macro.
4063 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4064 Use it instead of discarding useful hash info with large hash values.
4065 (sxhash_float): New function.
4066 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4067 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4068 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4069 Rewrite to use FIXNUM_BITS, as this simplifies things.
4070 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4071 Adjust signatures to match updated version of code.
4072 (consing_since_gc): Now EMACS_INT, since a single hash table can
4073 use more than INT_MAX bytes.
4074
4075 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4076
4077 Make it possible to build with GCC-4.6+ -O2 -flto.
4078
4079 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4080
4081 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4082
4083 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4084 Call minibuffer-inactive-mode.
4085
4086 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4087
4088 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4089 Update dependencies.
4090
4091 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4092
4093 * data.c (init_data): Remove code for UTS, this system is not
4094 supported anymore.
4095
4096 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4097
4098 Don't force ./temacs to start in terminal mode.
4099
4100 * frame.c (make_initial_frame): Initialize faces in all cases, not
4101 only when CANNOT_DUMP is defined.
4102 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4103
4104 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4105
4106 * dispnew.c (add_window_display_history): Use const for the string
4107 pointer. Remove declaration, not needed.
4108
4109 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4110
4111 Use 'inline', not 'INLINE'.
4112 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4113 * alloc.c, fontset.c (INLINE): Remove.
4114 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4115 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4116 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4117 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4118 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4119
4120 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4121
4122 Make it possible to run ./temacs.
4123
4124 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4125 syms_of_callproc does the same thing. Remove test for
4126 "initialized", do it in the caller.
4127 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4128
4129 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4130
4131 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4132 (read_minibuf): Use get_minibuffer.
4133 (syms_of_minibuf): Use DEFSYM.
4134 (Qmetadata): New var.
4135 * data.c (Qbuffer): Don't make it static.
4136 (syms_of_data): Use DEFSYM.
4137
4138 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4139
4140 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4141 (CCL_CODE_MIN): New macro.
4142
4143 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4144
4145 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4146
4147 * eval.c (Qdebug): Now static.
4148 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4149 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4150 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4151
4152 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4153
4154 * image.c: Various fixes to ImageMagick code comments.
4155 (Fimagemagick_types): Doc fix.
4156
4157 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4158
4159 Minor fixes prompted by GCC 4.6.0 warnings.
4160
4161 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4162
4163 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4164 (x_clipboard_manager_save_all): Move extern decl to ...
4165 * xterm.h: ... here, so that it can be checked for consistency.
4166
4167 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4168
4169 * xselect.c (x_clipboard_manager_save_frame)
4170 (x_clipboard_manager_save_all): New functions.
4171 (Fx_clipboard_manager_save): Lisp function deleted.
4172
4173 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4174 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4175
4176 * xterm.h: Update prototype.
4177
4178 2011-05-28 William Xu <william.xwl@gmail.com>
4179
4180 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4181 exiting (Bug#8239).
4182
4183 2011-05-28 Jim Meyering <meyering@redhat.com>
4184
4185 Avoid a sign-extension bug in crypto_hash_function.
4186 * fns.c (to_uchar): Define.
4187 (crypto_hash_function): Use it to convert some newly-signed
4188 variables to unsigned, to avoid sign-extension bugs. For example,
4189 without this change, (md5 "truc") would evaluate to
4190 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4191 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4192 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4193
4194 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4195
4196 Integer overflow fixes.
4197
4198 * dbusbind.c: Serial number integer overflow fixes.
4199 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4200 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4201 to hold a serial number that is too large for a fixnum.
4202 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4203 Check for serial numbers out of range. Decode any serial number
4204 that was so large that it became a float. (Bug#8722)
4205
4206 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4207 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4208 Use XFASTINT rather than XUINT when numbers are nonnegative.
4209 (xd_append_arg, Fdbus_method_return_internal):
4210 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4211 arguments, check that Lisp number is nonnegative, rather than
4212 silently wrapping negative numbers around. (Bug#8722)
4213 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4214 (Bug#8722)
4215
4216 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4217
4218 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4219
4220 ccl: add integer overflow checks
4221 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4222 (IN_INT_RANGE): New macros.
4223 (ccl_driver): Use them to check for integer overflow when
4224 decoding a CCL program. Many of the new checks are whether XINT (x)
4225 fits in int; it doesn't always, on 64-bit hosts. The new version
4226 doesn't catch all possible integer overflows, but it's an
4227 improvement. (Bug#8719)
4228
4229 * alloc.c (make_event_array): Use XINT, not XUINT.
4230 There's no need for unsigned here.
4231
4232 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4233 This follows up to the 2011-05-06 change that substituted uintptr_t
4234 for EMACS_INT. This case wasn't caught back then.
4235
4236 Rework Fformat to avoid integer overflow issues.
4237 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4238 now (part of C89). Include <verify.h>.
4239 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4240 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4241 (Fformat): Avoid the prepass trying to compute sizes; it was only
4242 approximate and thus did not catch overflow reliably. Instead, walk
4243 through the format just once, formatting and computing sizes as we go,
4244 checking for integer overflow at every step, and allocating a larger
4245 buffer as needed. Keep track separately whether the format is
4246 multibyte. Keep only the most-recently calculated precision, rather
4247 than them all. Record whether each argument has been converted to
4248 string. Use EMACS_INT, not int, for byte and char and arg counts.
4249 Support field widths and precisions larger than INT_MAX. Avoid
4250 sprintf's undefined behavior with conversion specifications such as %#d
4251 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4252 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4253 formatting out-of-range floating point numbers with int
4254 formats. (Bug#8668)
4255
4256 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4257
4258 * data.c: Avoid integer truncation in expressions involving floats.
4259 * data.c: Include <intprops.h>.
4260 (arith_driver): When there's an integer overflow in an expression
4261 involving floating point, convert the integers to floating point
4262 so that the resulting value does not suffer from catastrophic
4263 integer truncation. For example, on a 64-bit host (* 4
4264 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4265 Do not rely on undefined behavior after integer overflow.
4266
4267 merge count_size_as_multibyte, parse_str_to_multibyte
4268 * character.c, character.h (count_size_as_multibyte):
4269 Rename from parse_str_to_multibyte; all uses changed.
4270 Check for integer overflow.
4271 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4272 since it's now a duplicate of the other. This is more of
4273 a character than a buffer op, so better that it's in character.c.
4274 * fns.c, print.c: Adjust to above changes.
4275
4276 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4277
4278 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4279
4280 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4281
4282 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4283 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4284 (x_clipboard_manager_save): Now static.
4285 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4286
4287 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4288 (crypto_hash_function): Now static.
4289 Fix pointer signedness problems. Avoid unnecessary initializations.
4290
4291 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4292
4293 * termhooks.h (Vselection_alist): Make it terminal-local.
4294
4295 * terminal.c (create_terminal): Initialize it.
4296
4297 * xselect.c: Support for clipboard managers.
4298 (Vselection_alist): Move to termhooks.h as terminal-local var.
4299 (LOCAL_SELECTION): New macro.
4300 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4301 (symbol_to_x_atom): Remove gratuitous arg.
4302 (x_handle_selection_request, lisp_data_to_selection_data)
4303 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4304 (x_own_selection, x_get_local_selection, x_convert_selection):
4305 New arg, specifying work frame. Use terminal-local Vselection_alist.
4306 (some_frame_on_display): Delete unused function.
4307 (Fx_own_selection_internal, Fx_get_selection_internal)
4308 (Fx_disown_selection_internal, Fx_selection_owner_p)
4309 (Fx_selection_exists_p): New optional frame arg.
4310 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4311 (x_handle_selection_clear): Don't treat other terminals with the
4312 same keyboard specially. Use the terminal-local Vselection_alist.
4313 (x_clear_frame_selections): Use Frun_hook_with_args.
4314
4315 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4316
4317 * xterm.h: Add support for those atoms.
4318
4319 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4320
4321 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4322 (converted_selections, conversion_fail_tag): New global variables.
4323 (x_selection_request_lisp_error): Free the above.
4324 (x_get_local_selection): Remove unnecessary code.
4325 (x_reply_selection_request): Args changed; handle arbitrary array
4326 of converted selections stored in converted_selections.
4327 Separate the XChangeProperty and SelectionNotify steps.
4328 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4329 (x_convert_selection): New function.
4330 (x_handle_selection_event): Simplify.
4331 (x_get_foreign_selection): Don't ignore incoming requests while
4332 waiting for an answer; this will fail when we implement
4333 SAVE_TARGETS, and seems unnecessary anyway.
4334 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4335 (Vx_sent_selection_functions): Doc fix.
4336
4337 2011-05-26 Leo Liu <sdl.web@gmail.com>
4338
4339 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4340
4341 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4342
4343 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4344
4345 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4346 for fringe update if it has periodic bitmap.
4347 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4348 and fringe_bitmap_periodic_p.
4349
4350 * fringe.c (get_fringe_bitmap_data): New function.
4351 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4352 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4353 row. Mark glyph row for fringe update if periodicity changed.
4354
4355 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4356 for fringe update unless it has periodic bitmap.
4357
4358 2011-05-25 Kenichi Handa <handa@m17n.org>
4359
4360 * xdisp.c (get_next_display_element): Set correct it->face_id for
4361 a static composition.
4362
4363 2011-05-24 Leo Liu <sdl.web@gmail.com>
4364
4365 * deps.mk (fns.o):
4366 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4367
4368 * fns.c (crypto_hash_function, Fsha1): New function.
4369 (Fmd5): Use crypto_hash_function.
4370 (syms_of_fns): Add Ssha1.
4371
4372 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4373
4374 * gnutls.c: Remove unused macros.
4375 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4376 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4377 Remove macros that are defined and never used.
4378 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4379
4380 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4381
4382 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4383 (Fx_get_selection_internal): Minor cleanup.
4384 (Fx_own_selection_internal): Rename arguments for consistency with
4385 select.el.
4386
4387 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4388
4389 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4390
4391 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4392
4393 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4394
4395 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4396
4397 * dispnew.c (scrolling_window): Don't exclude the case that the
4398 last enabled row in the desired matrix touches the bottom boundary.
4399
4400 2011-05-21 Glenn Morris <rgm@gnu.org>
4401
4402 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4403 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4404 and add some more files.
4405
4406 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4407
4408 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4409 report_file_error introduced by the change from 2011-05-07.
4410
4411 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4412
4413 * systime.h (Time): Define only if emacs is defined.
4414 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4415 where the include path doesn't have X11/X.h by default. See
4416 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4417
4418 2011-05-20 Kenichi Handa <handa@m17n.org>
4419
4420 * composite.c (find_automatic_composition): Fix previous change.
4421
4422 2011-05-20 Glenn Morris <rgm@gnu.org>
4423
4424 * lisp.mk: New file, split from Makefile.in.
4425 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4426 (shortlisp): Remove.
4427 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4428
4429 2011-05-19 Glenn Morris <rgm@gnu.org>
4430
4431 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4432 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4433 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4434 (lisp): Set the order to that of loadup.el.
4435 (shortlisp): Make it a copy of $lisp.
4436 (SOME_MACHINE_LISP): Remove.
4437 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4438 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4439
4440 2011-05-18 Kenichi Handa <handa@m17n.org>
4441
4442 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4443 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4444 (find_automatic_composition): Mostly rewrite for efficiency.
4445
4446 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4447
4448 * makefile.w32-in: Update dependencies.
4449
4450 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4451
4452 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4453 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4454
4455 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4456
4457 Fix some integer overflow issues, such as string length overflow.
4458
4459 * insdel.c (count_size_as_multibyte): Check for string overflow.
4460
4461 * character.c (lisp_string_width): Check for string overflow.
4462 Use EMACS_INT, not int, for string indexes and lengths; in
4463 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4464 the resulting string length overflows an EMACS_INT; instead,
4465 report a string overflow if no precision given. When checking for
4466 precision exhaustion, use a check that cannot possibly have
4467 integer overflow. (Bug#8675)
4468 * character.h (lisp_string_width): Adjust to new signature.
4469
4470 * alloc.c (string_overflow): New function.
4471 (Fmake_string): Use it. This doesn't change behavior, but saves
4472 a few bytes and will simplify future changes.
4473 * character.c (string_escape_byte8): Likewise.
4474 * lisp.h (string_overflow): New decl.
4475
4476 Fixups, following up to the user-interface timestamp change.
4477 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4478 for UI timestamps, instead of unsigned long.
4479 * msdos.c (mouse_get_pos): Likewise.
4480 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4481 * w32gui.h (Time): Define by including "systime.h" rather than by
4482 declaring it ourselves. (Bug#8664)
4483
4484 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4485 * image.c (clear_image_cache): Likewise.
4486
4487 * term.c (term_mouse_position): Don't assume time_t wraparound.
4488
4489 Be more systematic about user-interface timestamps.
4490 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4491 and sometimes 'EMACS_UINT', to represent these timestamps.
4492 This change causes it to use 'Time' uniformly, as that's what X uses.
4493 This makes the code easier to follow, and makes it easier to catch
4494 integer overflow bugs such as Bug#8664.
4495 * frame.c (Fmouse_position, Fmouse_pixel_position):
4496 Use Time, not unsigned long, for user-interface timestamps.
4497 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4498 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4499 * keyboard.h (last_event_timestamp): Likewise.
4500 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4501 * menu.h (xmenu_show): Likewise.
4502 * term.c (term_mouse_position): Likewise.
4503 * termhooks.h (struct input_event.timestamp): Likewise.
4504 (struct terminal.mouse_position_hook): Likewise.
4505 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4506 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4507 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4508 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4509 what it was before.
4510 * menu.h, termhooks.h: Include "systime.h", for Time.
4511
4512 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4513 Don't assume that the difference between two unsigned long values
4514 can fit into an integer. At this point, we know button_down_time
4515 <= event->timestamp, so the difference must be nonnegative, so
4516 there's no need to cast the result if double-click-time is
4517 nonnegative, as it should be; check that it's nonnegative, just in
4518 case. This bug is triggered when events are more than 2**31 ms
4519 apart (about 25 days). (Bug#8664)
4520
4521 * xselect.c (last_event_timestamp): Remove duplicate decl.
4522 (x_own_selection): Remove needless cast to unsigned long.
4523
4524 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4525 that always fit in int. Use a sentinel instead of a counter, to
4526 avoid a temp and to allay GCC's concerns about possible int overflow.
4527 * frame.h (struct frame): Use int for menu_bar_items_used
4528 instead of EMACS_INT, since it always fits in int.
4529
4530 * menu.c (grow_menu_items): Check for int overflow.
4531
4532 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4533
4534 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4535 Before, the code was not consistent. These values cannot exceed
4536 2**31 - 1 so there's no need to make them unsigned.
4537 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4538 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4539 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4540 as modifiers.
4541 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4542
4543 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4544 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4545 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4546 presumably because the widths might not match.
4547
4548 * window.c (size_window): Avoid needless test at loop start.
4549
4550 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4551
4552 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4553
4554 2011-05-12 Drew Adams <drew.adams@oracle.com>
4555
4556 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4557
4558 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4559
4560 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4561 `width' to `bar_area_x' and `bar_area_width', respectively.
4562 (x_scroll_run): Take account of fringe background extension.
4563
4564 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4565 Rename local vars `left' and `width' to `bar_area_x' and
4566 `bar_area_width', respectively.
4567 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4568 background extension.
4569
4570 2011-05-10 Jim Meyering <meyering@redhat.com>
4571
4572 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4573
4574 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4575
4576 * image.c (Finit_image_library): Return t for built-in image types,
4577 like pbm and xbm. (Bug#8640)
4578
4579 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4580
4581 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4582
4583 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4584
4585 * w32console.c (Fset_screen_color): Doc fix.
4586 (Fget_screen_color): New function.
4587 (syms_of_ntterm): Defsubr it.
4588
4589 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4590 unlink the temporary file if Fcall_process didn't create it in the
4591 first place.
4592 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4593 child process will be redirected to a file specified with `:file'.
4594 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4595 cue to call_process_cleanup not to close that handle.
4596
4597 2011-05-07 Ben Key <bkey76@gmail.com>
4598
4599 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4600 one of two shell specific rules, either bootstrap-temacs-CMD or
4601 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4602 to the previous implementation of the bootstrap-temacs rule.
4603 The bootstrap-temacs-CMD rule is similar to the previous
4604 implementation of the bootstrap-temacs rule except that it
4605 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4606 variable.
4607
4608 These changes, along with some changes to nt/configure.bat,
4609 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4610 earlier fix to add support for --cflags and --ldflags options
4611 that include quotes so that it works whether make uses cmd or
4612 sh as the shell.
4613
4614 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4615
4616 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4617 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4618 is a constant.
4619 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4620 a string. Handle both cases.
4621 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4622 (Fdbus_register_method): Use Qinvalid_function.
4623
4624 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4625
4626 * makefile.w32-in: Update dependencies.
4627 (LISP_H): Add inttypes.h and stdin.h.
4628 (PROCESS_H): Add unistd.h.
4629
4630 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4631
4632 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4633 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4634
4635 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4636
4637 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4638
4639 * term.c (vfatal): Remove stray call to va_end.
4640 It's not needed and the C Standard doesn't allow it here anyway.
4641
4642 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4643 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4644
4645 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4646 bytes.
4647
4648 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4649
4650 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4651
4652 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4653
4654 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4655
4656 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4657
4658 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4659 * charset.c (Fdefine_charset_internal): Don't initialize
4660 charset.code_space[15]. The value was garbage, on hosts with
4661 32-bit int (Bug#8600).
4662
4663 * lread.c (read_integer): Be more consistent with string-to-number.
4664 Use string_to_number to do the actual conversion; this avoids
4665 rounding errors and fixes some other screwups. Without this fix,
4666 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4667 (digit_to_number): Move earlier, for benefit of read_integer.
4668 Return -1 if the digit is out of range for the base, -2 if it is
4669 not a digit in any supported base. (Bug#8602)
4670
4671 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4672
4673 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4674 to match comment at start of function. This also removes a
4675 GCC warning about overflow in a 32+64-bit port.
4676
4677 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4678
4679 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4680 Reported by Stefan Monnier in
4681 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4682 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4683 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4684
4685 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4686 (EMACS_UINTPTR): Likewise, with uintptr_t.
4687
4688 * lisp.h: Prefer 64-bit EMACS_INT if available.
4689 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4690 on 32-bit hosts that have 64-bit int, so that they can access
4691 large files.
4692 However, temporarily disable this change unless the temporary
4693 symbol WIDE_EMACS_INT is defined.
4694
4695 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4696
4697 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4698 This removes an assumption that EMACS_INT and long are the same
4699 width as pointers. The assumption is true for Emacs porting targets
4700 now, but we want to make other targets possible.
4701 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4702 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4703 In the rest of the code, change types of integers that hold casted
4704 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4705 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4706 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4707 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4708 No need to cast type when ORing.
4709 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4710 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4711 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4712 assume EMACS_INT is the same width as char *.
4713 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4714 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4715 Remove no-longer-needed casts.
4716 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4717 (xg_tool_bar_help_callback, xg_make_tool_item):
4718 Use EMACS_INTPTR to hold an integer
4719 that will be cast to void *; this can avoid a GCC warning
4720 if EMACS_INT is not the same width as void *.
4721 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4722 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4723 (current_message_1, set_message_1):
4724 Use a local to convert to proper width without a cast.
4725 * xmenu.c (dialog_selection_callback): Likewise.
4726
4727 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4728 Also, don't assume VALBITS / RAND_BITS is less than 5,
4729 and don't rely on undefined behavior when shifting a 1 left into
4730 the sign bit.
4731 * lisp.h (get_random): Change signature to match.
4732
4733 * lread.c (hash_string): Use size_t, not int, for hash computation.
4734 Normally we prefer signed values; but hashing is special, because
4735 it's better to use unsigned division on hash table sizes so that
4736 the remainder is nonnegative. Also, size_t is the natural width
4737 for hashing into memory. The previous code used 'int', which doesn't
4738 retain enough info to hash well into very large tables.
4739 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4740
4741 * dbusbind.c: Don't possibly lose pointer info when converting.
4742 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4743 Use XPNTR rather than XHASH, so that the high-order bits of
4744 the pointer aren't lost when converting through void *.
4745
4746 * eval.c (Fautoload): Don't double-shift a pointer.
4747
4748 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4749
4750 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4751
4752 * gnutls.c (DEF_GNUTLS_FN):
4753 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4754
4755 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4756
4757 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4758 marker. (Bug#8610)
4759
4760 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4761
4762 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4763 New version that can reserve upto 2GB of heap space.
4764
4765 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4766
4767 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4768
4769 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4770
4771 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4772 `gnutls_certificate_set_x509_key_file'.
4773
4774 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4775
4776 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4777 Update dependencies.
4778
4779 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4780
4781 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4782 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4783 Remove unused parameter `fildes'.
4784 * process.c (read_process_output, send_process): Don't pass it.
4785
4786 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4787
4788 Fix previous change: the library cache is defined in w32.c.
4789 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4790 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4791
4792 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4793
4794 Implement dynamic loading of GnuTLS on Windows.
4795
4796 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4797 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4798 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4799 Declare.
4800
4801 * gnutls.c (Qgnutls_dll): Define.
4802 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4803 (gnutls_*): Declare function pointers.
4804 (init_gnutls_functions): New function to initialize function pointers.
4805 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4806 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4807 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4808 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4809 (emacs_gnutls_write, emacs_gnutls_read)
4810 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4811 (Fgnutls_available_p): New function.
4812 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4813 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4814 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4815
4816 * image.c: Include w32.h.
4817 (Vimage_type_cache): Delete.
4818 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4819 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4820 (w32_delayed_load): Move to w32.c.
4821
4822 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4823
4824 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4825 (w32_delayed_load): Move from image.c. When loading a library, record
4826 its filename in the :loaded-from property of the library id.
4827 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4828 Initialize and staticpro them.
4829 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4830
4831 * process.c: Include lisp.h before w32.h, not after.
4832 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4833 instead of gnutls_record_check_pending.
4834
4835 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4836
4837 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4838
4839 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4840 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4841 as passed in.
4842
4843 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4844
4845 * xterm.c (x_set_frame_alpha): Do not set property on anything
4846 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4847
4848 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4849
4850 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4851
4852 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4853
4854 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4855 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4856 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4857 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4858 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4859 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4860 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4861 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4862 (Qgnutls_bootprop_callbacks_verify): Make static.
4863
4864 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4865
4866 * callproc.c: Indentation fixup.
4867
4868 * sysdep.c (wait_for_termination_1): Make static.
4869 (wait_for_termination, interruptible_wait_for_termination):
4870 Move after wait_for_termination_1.
4871
4872 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4873
4874 * sysdep.c (interruptible_wait_for_termination): New function
4875 which is like wait_for_termination, but allows keyboard
4876 interruptions.
4877
4878 * callproc.c (Fcall_process): Add (:file "file") as an option for
4879 the STDOUT buffer.
4880 (Fcall_process_region): Ditto.
4881
4882 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4883
4884 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4885 rather than `XVECTOR (FOO)->size'.
4886
4887 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4888 inttypes.h, as a gnulib replacement is used if it not available in
4889 system headers.
4890
4891 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4892
4893 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4894 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4895 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4896
4897 * coding.c (coding_alloc_by_realloc): Error out if destination
4898 will grow beyond MOST_POSITIVE_FIXNUM.
4899 (decode_coding_emacs_mule): Abort if there isn't enough place in
4900 charbuf for the composition carryover bytes. Reserve an extra
4901 space for up to 2 characters produced in a loop.
4902 (decode_coding_iso_2022): Abort if there isn't enough place in
4903 charbuf for the composition carryover bytes.
4904
4905 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4906
4907 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4908 aborting when %lld or %lll format is passed.
4909 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4910 %llo or %llx format is passed. (Bug#8545)
4911
4912 * window.c (window_scroll_line_based): Use a marker instead of
4913 simple variables to record original value of point. (Bug#7952)
4914
4915 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4916 produced by %s or %c overflows available buffer space. (Bug#8545)
4917
4918 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4919
4920 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4921 (SIZE_MAX): Move defn after all includes, as they might #define it.
4922
4923 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4924
4925 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4926
4927 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4928
4929 * keyboard.c (Qdelayed_warnings_hook): Define.
4930 (command_loop_1): Run `delayed-warnings-hook'
4931 if Vdelayed_warnings_list is non-nil.
4932 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4933 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4934
4935 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4936
4937 * doprnt.c (doprnt): Don't return value smaller than the buffer
4938 size if the message was truncated. (Bug#8545).
4939
4940 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4941
4942 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4943 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4944
4945 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4946
4947 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4948
4949 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4950
4951 * makefile.w32-in: Update dependencies.
4952
4953 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4954
4955 Improve `doprnt' and its usage. (Bug#8545)
4956 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4957 `format_end'. Remove support for %l as a conversion specifier.
4958 Don't use xrealloc. Improve diagnostics when the %l size modifier
4959 is used. Update the commentary.
4960
4961 * eval.c (verror): Simplify calculation of size_t.
4962
4963 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4964 messages.
4965
4966 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4967
4968 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4969 change.
4970
4971 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4972
4973 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4974 This makes this file independent of the recent pseudovector change.
4975
4976 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4977
4978 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4979
4980 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4981 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4982 Remove unused local.
4983 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4984
4985 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4986 GCC 4.6.0 optimizes based on type-based alias analysis.
4987 For example, if b is of type struct buffer * and v of type struct
4988 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4989 != &v->size, and therefore "v->size = 1; b->size = 2; return
4990 v->size;" must therefore return 1. This assumption is incorrect
4991 for Emacs, since it type-puns struct Lisp_Vector * with many other
4992 types. To fix this problem, this patch adds a new type struct
4993 vectorlike_header that documents the constraints on layout of vectors
4994 and pseudovectors, and helps optimizing compilers not get fooled
4995 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4996 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4997 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4998 the size member.
4999 (XSETPVECTYPE): Rewrite in terms of new macro.
5000 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5001 This is a bit clearer, and further avoids the possibility of
5002 undesirable aliasing.
5003 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5004 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5005 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5006 since Lisp_Subr is a special case (no "next" field).
5007 (ASIZE): Now uses header.size rather than size.
5008 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5009 to avoid the hassle of writing XVECTOR (foo)->header.size.
5010 (struct vectorlike_header): New type.
5011 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5012 object, to help avoid aliasing.
5013 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5014 (SUBRP): Likewise, since Lisp_Subr is a special case.
5015 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5016 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5017 (struct Lisp_Hash_Table): Combine first two members into a single
5018 struct vectorlike_header member. All uses of "size" and "next" members
5019 changed to be "header.size" and "header.next".
5020 * buffer.h (struct buffer): Likewise.
5021 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5022 * frame.h (struct frame): Likewise.
5023 * process.h (struct Lisp_Process): Likewise.
5024 * termhooks.h (struct terminal): Likewise.
5025 * window.c (struct save_window_data, struct saved_window): Likewise.
5026 * window.h (struct window): Likewise.
5027 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5028 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5029 * buffer.c (init_buffer_once): Likewise.
5030 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5031 special case.
5032 * process.c (Fformat_network_address): Use local var for size,
5033 for brevity.
5034
5035 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5036
5037 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5038 * data.c (atof): Remove decl; no longer used or needed.
5039 (digit_to_number): Move to lread.c.
5040 (Fstring_to_number): Use new string_to_number function, to be
5041 consistent with how the Lisp reader treats infinities and NaNs.
5042 Do not assume that floating-point numbers represent EMACS_INT
5043 without losing information; this is not true on most 64-bit hosts.
5044 Avoid double-rounding errors, by insisting on integers when
5045 parsing non-base-10 numbers, as the documentation specifies.
5046 * lisp.h (string_to_number): New decl, replacing ...
5047 (isfloat_string): Remove.
5048 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5049 (read1): Do not accept +. and -. as integers; this
5050 appears to have been a coding error. Similarly, do not accept
5051 strings like +-1e0 as floating point numbers. Do not report
5052 overflow for integer overflows unless the base is not 10 which
5053 means we have no simple and reliable way to continue.
5054 Break out the floating-point parsing into a new
5055 function string_to_number, so that Fstring_to_number parses
5056 floating point numbers consistently with the Lisp reader.
5057 (digit_to_number): Move here from data.c. Make it static inline.
5058 (E_CHAR, EXP_INT): Remove, replacing with ...
5059 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5060 (string_to_number): New function, replacing isfloat_string.
5061 This function checks for valid syntax and produces the resulting
5062 Lisp float number too. Rework it so that string-to-number
5063 no longer mishandles examples like "1.0e+". Use strtoumax,
5064 so that overflow for non-base-10 numbers is reported only when
5065 there's no portable and simple way to convert to floating point.
5066
5067 * textprop.c (set_text_properties_1): Rewrite for clarity,
5068 and to avoid GCC warning about integer overflow.
5069
5070 * intervals.h (struct interval): Use EMACS_INT for members
5071 where EMACS_UINT might cause problems. See
5072 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5073 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5074 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5075 All uses changed.
5076 (offset_intervals): Tell GCC not to worry about length overflow
5077 when negating a negative length.
5078
5079 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5080 (overrun_check_free): Likewise.
5081
5082 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5083 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5084 word size.
5085
5086 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5087 (gnutls_make_error): Rename local to avoid shadowing.
5088 (gnutls_emacs_global_deinit): ifdef out; not used.
5089 (Fgnutls_boot): Use const for pointer to readonly storage.
5090 Comment out unused local. Fix pointer signedness problems.
5091
5092 * lread.c (openp): Don't stuff size_t into an 'int'.
5093 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5094 about possible signed overflow.
5095
5096 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5097 (GDK_KEY_g): Don't define if already defined.
5098 (xg_prepare_tooltip): Avoid pointer signedness problem.
5099 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5100
5101 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5102 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5103
5104 * xfns.c (Fx_window_property): Simplify a bit,
5105 to make a bit faster and to avoid GCC 4.6.0 warning.
5106 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5107
5108 * fns.c (internal_equal): Don't assume size_t fits in int.
5109
5110 * alloc.c (compact_small_strings): Tighten assertion a little.
5111
5112 Replace pEd with more-general pI, and fix some printf arg casts.
5113 * lisp.h (pI): New macro, generalizing old pEd macro to other
5114 conversion specifiers. For example, use "...%"pI"d..." rather
5115 than "...%"pEd"...".
5116 (pEd): Remove. All uses replaced with similar uses of pI.
5117 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5118 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5119 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5120 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5121 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5122 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5123 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5124 64-bit hosts.
5125 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5126 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5127 * print.c (safe_debug_print, print_object): Likewise.
5128 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5129 to int.
5130 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5131 avoiding the 0 flag, which is not portable.
5132 * process.c (Fmake_network_process): Use pI to avoid cast.
5133 * region-cache.c (pp_cache): Likewise.
5134 * xdisp.c (decode_mode_spec): Likewise.
5135 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5136 behavior on 64-bit hosts with printf arg.
5137 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5138 (x_stop_queuing_selection_requests): Likewise.
5139 (x_get_window_property): Don't truncate byte count to an 'int'
5140 when tracing.
5141
5142 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5143 here, since it parses constructs like leading '-' and spaces,
5144 which are not wanted; and it overflows with large numbers.
5145 Instead, simply match F[0-9]+, which is what is wanted anyway.
5146
5147 * alloc.c: Remove unportable assumptions about struct layout.
5148 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5149 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5150 (allocate_vectorlike, make_pure_vector): Use the new macros,
5151 plus offsetof, to remove unportable assumptions about struct layout.
5152 These assumptions hold on all porting targets that I know of, but
5153 they are not guaranteed, they're easy to remove, and removing them
5154 makes further changes easier.
5155
5156 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5157 This doesn't fix a bug but makes the code clearer.
5158 (string_overrun_cookie): Now const. Use initializers that
5159 don't formally overflow signed char, to avoid warnings.
5160 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5161 can cause Emacs to crash when string overrun checking is enabled.
5162 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5163 multiple of sizeof (EMACS_INT); it need not be, if
5164 alignof(EMACS_INT) < sizeof (EMACS_INT).
5165 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5166
5167 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5168
5169 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5170
5171 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5172
5173 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5174 supposed to be handshaking. (Bug#8556)
5175 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5176
5177 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5178
5179 * lisp.h (Qdebug): List symbol.
5180 * eval.c (Qdebug): Restore global linkage.
5181 * keyboard.c (debug-on-event): New variable.
5182 (handle_user_signal): Break into debugger when debug-on-event
5183 matches the current signal symbol.
5184
5185 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5186
5187 * alloc.c (check_sblock, check_string_bytes)
5188 (check_string_free_list): Convert to standard C.
5189
5190 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5191
5192 * w32.c (emacs_gnutls_push): Fix typo.
5193
5194 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5195
5196 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5197 "cast to pointer from integer of different size".
5198
5199 Improve doprnt and its use in verror. (Bug#8545)
5200 * doprnt.c (doprnt): Document the set of format control sequences
5201 supported by the function. Use SAFE_ALLOCA instead of always
5202 using `alloca'.
5203
5204 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5205 is one byte too soon. Don't use xrealloc; instead xfree and
5206 xmalloc anew.
5207
5208 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5209
5210 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5211 callbacks stage.
5212
5213 * gnutls.c: Renamed global_initialized to
5214 gnutls_global_initialized. Added internals for the
5215 :verify-hostname-error, :verify-error, and :verify-flags
5216 parameters of `gnutls-boot' and documented those parameters in the
5217 docstring. Start callback support.
5218 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5219 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5220 on error. Return error code.
5221 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5222 (emacs_gnutls_read): Likewise.
5223 (Fgnutls_boot): Return handshake error code.
5224 (emacs_gnutls_handle_error): New function.
5225 (wsaerror_to_errno): Likewise.
5226
5227 * w32.h (emacs_gnutls_pull): Add prototype.
5228 (emacs_gnutls_push): Likewise.
5229
5230 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5231 (emacs_gnutls_push): Likewise.
5232
5233 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5234
5235 * process.c (wait_reading_process_output): Check if GnuTLS
5236 buffered some data internally if no FDs are set for TLS
5237 connections.
5238
5239 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5240 (LIBS): Link to USER_LIBS.
5241 ($(BLD)/gnutls.$(0)): New target.
5242
5243 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5244
5245 * xdisp.c (handle_single_display_spec): Rename the
5246 display_replaced_before_p argument into display_replaced_p, to
5247 make it consistent with the commentary. Fix typos in the
5248 commentary.
5249
5250 * textprop.c (syms_of_textprop): Remove dead code.
5251 (copy_text_properties): Delete obsolete commentary about an
5252 interface that was deleted long ago. Fix typos in the description
5253 of arguments.
5254
5255 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5256 to changes in oldXMenu/XMenu.h from 2011-04-16.
5257 <menu_help_message, prev_menu_help_message>: Constify.
5258 (IT_menu_make_room): menu->help_text is now `const char **';
5259 adjust.
5260
5261 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5262 to changes in oldXMenu/XMenu.h from 2011-04-16.
5263 (struct XMenu): Declare `help_text' `const char **'.
5264
5265 * xfaces.c <Qunspecified>: Make extern again.
5266
5267 * syntax.c: Include sys/types.h before including regex.h, as
5268 required by Posix.
5269
5270 * doc.c (get_doc_string): Improve the format passed to `error'.
5271
5272 * doprnt.c (doprnt): Improve commentary.
5273
5274 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5275
5276 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5277 them with etags.
5278
5279 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5280 changes in globals.h immediately force recompilation.
5281 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5282 $(CURDIR)/s/ms-w32.h.
5283 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5284
5285 * character.c (Fchar_direction): Function deleted.
5286 (syms_of_character): Don't defsubr it.
5287 <char-direction-table>: Deleted.
5288
5289 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5290
5291 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5292 * doprnt.c: Include limits.h.
5293 (SIZE_MAX): New macro.
5294 (doprnt): Return a size_t value. 2nd arg is now size_t.
5295 Many local variables are now size_t instead of int or unsigned.
5296 Improve overflow protection. Support `l' modifier for integer
5297 conversions. Support %l conversion. Don't assume an EMACS_INT
5298 argument for integer conversions and for %c.
5299
5300 * lisp.h (doprnt): Restore prototype.
5301
5302 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5303 $(SRC)/character.h.
5304
5305 * Makefile.in (base_obj): Add back doprnt.o.
5306
5307 * deps.mk (doprnt.o): Add back prerequisites.
5308 (callint.o): Depend on character.h.
5309
5310 * eval.c (internal_lisp_condition_case): Include the handler
5311 representation in the error message.
5312 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5313 when breaking from the loop.
5314
5315 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5316
5317 * callint.c (Fcall_interactively): When displaying error message
5318 about invalid control letter, pass the character's codepoint, not
5319 a pointer to its multibyte form. Improve display of the character
5320 in octal and display also its hex code.
5321
5322 * character.c (char_string): Use %x to display the (unsigned)
5323 codepoint of an invalid character, to avoid displaying a bogus
5324 negative value.
5325
5326 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5327 `error', not SYMBOL_NAME itself.
5328
5329 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5330 character arguments to `error'.
5331
5332 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5333 to `error' in error message about FINAL_CHAR argument. Make sure
5334 FINAL_CHAR is a character, and use %c when it is passed as
5335 argument to `error'.
5336
5337 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5338
5339 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5340
5341 * w32.c: Include <time.h>.
5342 (sys_localtime): New function.
5343
5344 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5345
5346 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5347
5348 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5349
5350 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5351
5352 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5353 zombies (Bug#8467).
5354
5355 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5356
5357 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5358 gl_state.e_property when gl_state.object is Qt.
5359
5360 * insdel.c (make_gap_larger): Remove limitation of buffer size
5361 to <= INT_MAX.
5362
5363 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5364
5365 * xdisp.c (lookup_glyphless_char_display)
5366 (produce_glyphless_glyph): Handle cons cell entry in
5367 glyphless-char-display.
5368 (Vglyphless_char_display): Document it.
5369
5370 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5371 glyphless-char-display.
5372
5373 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5374
5375 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5376
5377 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5378
5379 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5380 definition for no-X builds.
5381
5382 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5383
5384 Static checks with GCC 4.6.0 and non-default toolkits.
5385
5386 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5387
5388 * process.c (keyboard_bit_set): Define only if SIGIO.
5389 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5390 (send_process): Repair possible setjmp clobbering.
5391
5392 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5393
5394 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5395
5396 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5397
5398 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5399 Define only if needed.
5400
5401 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5402 by pacifying GCC about it. Maybe it's time to retire it?
5403 * xfaces.c (USG, __TIMEVAL__): Likewise.
5404
5405 * dispextern.h (struct redisplay_interface): Rename param
5406 to avoid shadowing.
5407 * termhooks.h (struct terminal): Likewise.
5408 * xterm.c (xembed_send_message): Likewise.
5409
5410 * insdel.c (make_gap_smaller): Define only if
5411 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5412
5413 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5414 it.
5415
5416 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5417 so that we aren't warned about unused symbols.
5418
5419 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5420
5421 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5422
5423 * xfns.c (x_real_positions): Mark locals as initialized.
5424
5425 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5426
5427 * xterm.c: Fix problems found by static analysis with other toolkits.
5428 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5429 (x_dispatch_event): Declare static if USE_GTK, and
5430 define if USE_GTK || USE_X_TOOLKIT.
5431 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5432 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5433 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5434 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5435
5436 * xmenu.c (menu_help_callback): Pointer type fixes.
5437 Use const pointers when pointing at readonly data. Avoid pointer
5438 signedness clashes.
5439 (FALSE): Remove unused macro.
5440 (update_frame_menubar): Remove unused decl.
5441
5442 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5443
5444 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5445 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5446 (single_menu_item): Rename local to avoid shadowing.
5447
5448 * keyboard.c (make_lispy_event): Remove unused local var.
5449
5450 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5451 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5452
5453 * bitmaps: Change bitmaps from unsigned char back to the X11
5454 compatible char. Avoid the old compiler warnings about
5455 out-of-range initializers by using, for example, '\xab' rather
5456 than 0xab.
5457
5458 * xgselect.c (xgselect_initialize): Check vs interface
5459 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5460
5461 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5462
5463 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5464 to read-only memory.
5465
5466 * fns.c (vector): Remove; this old hack is no longer needed.
5467
5468 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5469 Remove unused var.
5470 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5471
5472 * xrdb.c (x_load_resources): Omit unused local.
5473
5474 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5475 (x_window): Rename locals to avoid shadowing.
5476 (USG): Use the kludged USG macro, to pacify gcc.
5477
5478 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5479 (x_term_init): Remove local to avoid shadowing.
5480
5481 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5482
5483 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5484 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5485
5486 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5487
5488 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5489
5490 Fix regex.c, syntax.c and friends for buffers > 2GB.
5491 * syntax.h (struct gl_state_s): Declare character position members
5492 EMACS_INT.
5493
5494 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5495
5496 * textprop.c (verify_interval_modification, interval_of):
5497 Declare arguments EMACS_INT.
5498
5499 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5500 EMACS_INT.
5501
5502 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5503
5504 * indent.c (Fvertical_motion): Local variable it_start is now
5505 EMACS_INT.
5506
5507 * regex.c (re_match, re_match_2, re_match_2_internal)
5508 (bcmp_translate, regcomp, regexec, print_double_string)
5509 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5510 (re_compile_pattern, re_exec): Declare arguments and local
5511 variables `size_t' and `ssize_t' and return values `regoff_t', as
5512 appropriate.
5513 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5514 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5515 <compile_stack_type>: `size' and `avail' are now `size_t'.
5516
5517 * regex.h <regoff_t>: Use ssize_t, not int.
5518 (re_search, re_search_2, re_match, re_match_2): Arguments that
5519 specify buffer/string position and length are now ssize_t and
5520 size_t. Return type is regoff_t.
5521
5522 2011-04-16 Ben Key <bkey76@gmail.com>
5523
5524 * nsfont.m: Fixed bugs in ns_get_family and
5525 ns_descriptor_to_entity that were caused by using free to
5526 deallocate memory blocks that were allocated by xmalloc (via
5527 xstrdup). This caused Emacs to crash when compiled with
5528 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5529 --enable-checking=xmallocoverrun). xfree is now used to
5530 deallocate these memory blocks.
5531
5532 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5533
5534 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5535
5536 emacs_write: Accept and return EMACS_INT for sizes.
5537 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5538 et seq.
5539 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5540 Accept and return EMACS_INT.
5541 (emacs_gnutls_write): Return the number of bytes written on
5542 partial writes.
5543 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5544 (emacs_read, emacs_write): Remove check for negative size, as the
5545 Emacs source code has been audited now.
5546 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5547 (emacs_read, emacs_write): Use it.
5548 * process.c (send_process): Adjust to the new signatures of
5549 emacs_write and emacs_gnutls_write. Do not attempt to store
5550 a byte offset into an 'int'; it might overflow.
5551 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5552
5553 * sound.c: Don't assume sizes fit in 'int'.
5554 (struct sound_device.period_size, alsa_period_size):
5555 Return EMACS_INT, not int.
5556 (struct sound_device.write, vox_write, alsa_write):
5557 Accept EMACS_INT, not int.
5558 (wav_play, au_play): Use EMACS_INT to store sizes and to
5559 record read return values.
5560
5561 2011-04-15 Ben Key <bkey76@gmail.com>
5562
5563 * keyboard.c (Qundefined): Don't declare static since it is used
5564 in nsfns.m.
5565 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5566 static since they are used in nsfont.m.
5567
5568 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5569
5570 * process.c (Qprocessp): Don't declare static.
5571 * lisp.h (Qprocessp): Declare again.
5572
5573 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5574
5575 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5576
5577 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5578
5579 Improve C-level modularity by making more things 'static'.
5580
5581 Don't publish debugger-only interfaces to other modules.
5582 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5583 (verify_bytepos, count_markers): Move decls to the only modules
5584 that need them.
5585 * region-cache.h (pp_cache): Likewise.
5586 * window.h (check_all_windows): Likewise.
5587 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5588
5589 * sysdep.c (croak): Now static, if
5590 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5591 * syssignal.h (croak): Declare only if not static.
5592
5593 * alloc.c (refill_memory_reserve): Now static if
5594 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5595 * lisp.h (refill_memory_reserve): Declare only if not static.
5596
5597 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5598 Define only if USE_LUCID.
5599
5600 * xrdb.c (x_customization_string, x_rm_string): Now static.
5601
5602 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5603 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5604
5605 * xdisp.c (draw_row_with_mouse_face): Now static.
5606 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5607
5608 * window.h (check_all_windows): Mark externally visible.
5609
5610 * window.c (window_deletion_count): Now static.
5611
5612 * undo.c: Make symbols static if they're not exported.
5613 (last_undo_buffer, last_boundary_position, pending_boundary):
5614 Now static.
5615
5616 * textprop.c (interval_insert_behind_hooks): Now static.
5617 (interval_insert_in_front_hooks): Likewise.
5618
5619 * term.c: Make symbols static if they're not exported.
5620 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5621 (max_frame_lines, tty_set_terminal_modes):
5622 (tty_reset_terminal_modes, tty_turn_off_highlight):
5623 (get_tty_terminal): Now static.
5624 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5625 * termhooks.h (term_mouse_moveto): Do not declare if
5626 HAVE_WINDOW_SYSTEM.
5627 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5628 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5629
5630 * sysdep.c: Make symbols static if they're not exported.
5631 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5632 Now static.
5633 (sigprocmask_set, full_mask): Remove; unused.
5634 (wait_debugging): Mark as visible.
5635 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5636 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5637
5638 * syntax.c (syntax_temp): Define only if !__GNUC__.
5639
5640 * sound.c (current_sound_device, current_sound): Now static.
5641
5642 * search.c (searchbufs, searchbuf_head): Now static.
5643
5644 * scroll.c (scroll_cost): Remove; unused.
5645 * dispextern.h (scroll_cost): Remove decl.
5646
5647 * region-cache.h (pp_cache): Mark as externally visible.
5648
5649 * process.c: Make symbols static if they're not exported.
5650 (process_tick, update_tick, create_process, chan_process):
5651 (Vprocess_alist, proc_buffered_char, datagram_access):
5652 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5653 (deactivate_process): Mark defn as static, as well as decl.
5654 * lisp.h (create_process): Remove decl.
5655 * process.h (chan_process, Vprocess_alist): Remove decls.
5656
5657 * print.c: Make symbols static if they're not exported.
5658 (print_depth, new_backquote_output, being_printed, print_buffer):
5659 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5660 (print_interval, print_number_index, initial_stderr_stream):
5661 Now static.
5662 * lisp.h (Fprinc): Remove decl.
5663 (debug_output_compilation_hack): Mark as externally visible.
5664
5665 * sysdep.c (croak): Move decl from here to syssignal.h.
5666 * syssignal.h (croak): Put it here, so the API can be checked when
5667 'croak' is called from dissociate_if_controlling_tty.
5668
5669 * minibuf.c: Make symbols static if they're not exported.
5670 (minibuf_save_list, choose_minibuf_frame): Now static.
5671 * lisp.h (choose_minibuf_frame): Remove decl.
5672
5673 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5674
5675 * lread.c: Make symbols static if they're not exported.
5676 (read_objects, initial_obarray, oblookup_last_bucket_number):
5677 Now static.
5678 (make_symbol): Remove; unused.
5679 * lisp.h (initial_obarray, make_symbol): Remove decls.
5680
5681 * keyboard.c: Make symbols static if they're not exported.
5682 (single_kboard, recent_keys_index, total_keys, recent_keys):
5683 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5684 (this_single_command_key_start, echoing, last_auto_save):
5685 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5686 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5687 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5688 (Vlispy_mouse_stem, double_click_count):
5689 Now static.
5690 (force_auto_save_soon): Define only if SIGDANGER.
5691 (ignore_mouse_drag_p): Now static if
5692 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5693 (print_help): Remove; unused.
5694 (stop_character, last_timer_event): Mark as externally visible.
5695 * keyboard.h (ignore_mouse_drag_p): Declare only if
5696 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5697 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5698 * lisp.h (echoing): Remove decl.
5699 (force_auto_save_soon): Declare only if SIGDANGER.
5700 * xdisp.c (redisplay_window): Simplify code, to make it more
5701 obvious that ignore_mouse_drag_p is not accessed if !defined
5702 USE_GTK && !defined HAVE_NS.
5703
5704 * intervals.c: Make symbols static if they're not exported.
5705 (merge_properties_sticky, merge_interval_right, delete_interval):
5706 Now static.
5707 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5708
5709 * insdel.c: Make symbols static if they're not exported.
5710 However, leave prepare_to_modify_buffer alone. It's never
5711 called from outside this function, but that appears to be a bug.
5712 (combine_after_change_list, combine_after_change_buffer):
5713 (adjust_after_replace, signal_before_change): Now static.
5714 (adjust_after_replace_noundo): Remove; unused.
5715 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5716 (signal_before_change): Remove decls.
5717
5718 * indent.c (val_compute_motion, val_vmotion): Now static.
5719
5720 * image.c: Make symbols static if they're not exported.
5721 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5722 if USE_GTK.
5723 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5724 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5725
5726 * fringe.c (standard_bitmaps): Now static.
5727 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5728
5729 * frame.c: Make symbols static if they're not exported.
5730 (x_report_frame_params, make_terminal_frame): Now static.
5731 (get_frame_param): Now static, unless HAVE_NS.
5732 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5733 (x_get_resource_string): Remove; not used.
5734 * frame.h (make_terminal_frame, x_report_frame_params):
5735 (x_get_resource_string); Remove decls.
5736 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5737 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5738
5739 * font.c, fontset.c: Make symbols static if they're not exported.
5740 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5741 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5742 * font.c (font_close_object): Now static.
5743 * font.h (font_close_object): Remove.
5744 * fontset.c (FONTSET_OBJLIST): Remove.
5745 (free_realized_fontset) #if-0 the body, which does nothing.
5746 (face_suitable_for_char_p): #if-0, as it's never called.
5747 * fontset.h (face_suitable_for_char_p): Remove decl.
5748 * xfaces.c (face_at_string_position):
5749 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5750 since 0 is always ASCII.
5751
5752 * fns.c (weak_hash_tables): Now static.
5753
5754 * fileio.c: Make symbols static if they're not exported.
5755 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5756 (Vwrite_region_annotation_buffers): Now static.
5757
5758 * eval.c: Make symbols static if they're not exported.
5759 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5760 * lisp.h (backtrace_list): Remove decl.
5761
5762 * emacs.c: Make symbols static if they're not exported.
5763 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5764 (fatal_error_code, fatal_error_signal_hook, standard_args):
5765 Now static.
5766 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5767 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5768 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5769 * lisp.h (fatal_error_signal_hook): Remove decl.
5770 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5771
5772 * editfns.c: Move a (normally-unused) function to its only use.
5773 * editfns.c, lisp.h (get_operating_system_release): Remove.
5774 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5775 worth the hassle of breaking this out.
5776
5777 * xterm.c: Make symbols static if they're not exported.
5778 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5779 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5780 (x_destroy_window, x_delete_display):
5781 Now static.
5782 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5783 (x_mouse_leave): Remove; unused.
5784 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5785 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5786 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5787 Remove decls.
5788 (x_mouse_leave): Declare only if WINDOWSNT.
5789 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5790 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5791 USE_X_TOOLKIT.
5792
5793 * ftxfont.c: Make symbols static if they're not exported.
5794 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5795 HAVE_FREETYPE.
5796 * font.h (ftxfont_driver): Likewise.
5797
5798 * xfns.c: Make symbols static if they're not exported.
5799 (x_last_font_name, x_display_info_for_name):
5800 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5801 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5802 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5803 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5804 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5805 (last_show_tip_args): Now static.
5806 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5807 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5808 (x_screen_planes): Remove; unused.
5809 * dispextern.h (x_screen_planes): Remove decl.
5810
5811 * dispnew.c: Make symbols static if they're not exported.
5812 * dispextern.h (redraw_garbaged_frames, scrolling):
5813 (increment_row_positions): Remove.
5814 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5815 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5816 Now static.
5817 (redraw_garbaged_frames): Remove; unused.
5818
5819 * xfaces.c: Make symbols static if they're not exported.
5820 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5821 Remove decls.
5822 * xterm.h (defined_color): Remove decls.
5823 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5824 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5825 (menu_face_changed_default, defined_color, free_realized_face):
5826 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5827 (ascii_face_of_lisp_face): Remove; unused.
5828
5829 * xdisp.c: Make symbols static if they're not exported.
5830 * dispextern.h (scratch_glyph_row, window_box_edges):
5831 (glyph_to_pixel_coords, set_cursor_from_row):
5832 (get_next_display_element, set_iterator_to_next):
5833 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5834 (show_mouse_face): Remove decls
5835 * frame.h (message_buf_print): Likewise.
5836 * lisp.h (pop_message, set_message, check_point_in_composition):
5837 Likewise.
5838 * xterm.h (set_vertical_scroll_bar): Likewise.
5839 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5840 (message_buf_print, scratch_glyph_row, displayed_buffer):
5841 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5842 (get_next_display_element, show_mouse_face, window_box_edges):
5843 (frame_to_window_pixel_xy, check_point_in_composition):
5844 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5845 (glyph_to_pixel_coords): Remove; unused.
5846
5847 * dired.c (file_name_completion): Now static.
5848
5849 * dbusbind.c (xd_in_read_queued_messages): Now static.
5850
5851 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5852 * data.c (circular_list_error): Remove.
5853
5854 * commands.h (last_point_position, last_point_position_buffer):
5855 (last_point_position_window): Remove decls.
5856 * keyboard.c: Make these variables static.
5857
5858 * coding.h (coding, code_convert_region, encode_coding_gap):
5859 Remove decls.
5860 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5861 (iso_code_class, detect_coding, code_convert_region): Now static.
5862 (encode_coding_gap): Remove; unused.
5863
5864 * chartab.c (chartab_chars, chartab_bits): Now static.
5865
5866 * charset.h (charset_iso_8859_1): Remove decl.
5867 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5868 Now static.
5869
5870 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5871 * ccl.c (Vccl_program_table): Now static.
5872 (check_ccl_update): Remove; unused.
5873
5874 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5875 * category.h: ... from here.
5876 * category.c (check_category_table, set_category_set): Now static.
5877
5878 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5879 * lisp.h: Remove these decls.
5880
5881 * buffer.c (buffer_count): Remove unused var.
5882
5883 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5884 so that it's not optimized away.
5885 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5886 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5887 exported only to the debugger.
5888
5889 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5890 * atimer.h (run_all_atimers): Remove; not exported.
5891
5892 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5893 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5894 was inaccessible from Lisp.
5895 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5896 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5897
5898 alloc.c: Import and export fewer symbols, and remove unused items.
5899 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5900 is defined.
5901 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5902 it's not optimized away by whole-program optimization.
5903 (message_enable_multibyte, free_misc): Remove.
5904 (catchlist, handlerlist, mark_backtrace):
5905 Declare only if BYTE_MARK_STACK.
5906 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5907 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5908 (message_enable_multibyte): Remove decl.
5909 (free_misc, interval_free_list, float_block, float_block_index):
5910 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5911 (cons_free_list, last_marked_index):
5912 Now static.
5913 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5914 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5915 (mark_backtrace): Define only if BYTE_MARK_STACK.
5916 * xdisp.c (message_enable_multibyte): Now static.
5917
5918 Declare Lisp_Object Q* variables to be 'static' if not exported.
5919 This makes it easier for human readers (and static analyzers)
5920 to see whether these variables are used from other modules.
5921 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5922 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5923 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5924 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5925 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5926 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5927 * xmenu.c, xselect.c:
5928 Declare Q* vars static if they are not used in other modules.
5929 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5930 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5931 Remove decls of unexported vars.
5932 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5933
5934 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5935
5936 Make Emacs functions such as Fatom 'static' by default.
5937 This makes it easier for human readers (and static analyzers)
5938 to see whether these functions can be called from other modules.
5939 DEFUN now defines a static function. To make the function external
5940 so that it can be used in other C modules, use the new macro DEFUE.
5941 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5942 (Finit_image_library):
5943 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5944 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5945 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5946 Remove decls, since these functions are now static.
5947 (Funintern, Fget_internal_run_time): New decls, since these functions
5948 were already external.
5949
5950 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5951 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5952 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5953 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5954 * keyboard.c, keymap.c, lread.c:
5955 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5956 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5957 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5958 Mark functions with DEFUE instead of DEFUN,
5959 if they are used in other modules.
5960 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5961 decls for now-static functions.
5962 * buffer.h (Fdelete_overlay): Remove decl.
5963 * callproc.c (Fgetenv_internal): Mark as internal.
5964 * composite.c (Fremove_list_of_text_properties): Remove decl.
5965 (Fcomposition_get_gstring): New forward static decl.
5966 * composite.h (Fcomposite_get_gstring): Remove decl.
5967 * dired.c (Ffile_attributes): New forward static decl.
5968 * doc.c (Fdocumntation_property): New forward static decl.
5969 * eval.c (Ffetch_bytecode): New forward static decl.
5970 (Funintern): Remove extern decl; now in .h file where it belongs.
5971 * fileio.c (Fmake_symbolic_link): New forward static decl.
5972 * image.c (Finit_image_library): New forward static decl.
5973 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5974 * intervals.h (Fprevious_property_change):
5975 (Fremove_list_of_text_properties): Remove decls.
5976 * keyboard.c (Fthis_command_keys): Remove decl.
5977 (Fcommand_execute): New forward static decl.
5978 * keymap.c (Flookup_key): New forward static decl.
5979 (Fcopy_keymap): Now static.
5980 * keymap.h (Flookup_key): Remove decl.
5981 * process.c (Fget_process): New forward static decl.
5982 (Fprocess_datagram_address): Mark as internal.
5983 * syntax.c (Fsyntax_table_p): New forward static decl.
5984 (skip_chars): Remove duplicate decl.
5985 * textprop.c (Fprevious_property_change): New forward static decl.
5986 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5987 Now internal.
5988 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5989 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5990
5991 * editfns.c (Fformat): Remove unreachable code.
5992
5993 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5994
5995 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5996 change. (Bug#8496)
5997
5998 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5999
6000 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6001 when at ZV. (Bug#8487)
6002
6003 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6004
6005 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6006 (Bug#8437)
6007 * keyboard.c (parse_tool_bar_item): Likewise.
6008 * sound.c (sound_cleanup, alsa_close): Likewise.
6009 * termcap.c (tgetent): Likewise.
6010 * xfns.c (x_default_font_parameter): Likewise.
6011 * xsettings.c (read_and_apply_settings): Likewise.
6012
6013 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6014 (overrun_check_free): Protoize.
6015
6016 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6017
6018 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6019 since callers should never pass a negative size.
6020 Change the signature to match that of plain 'read' and 'write'; see
6021 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6022 * lisp.h: Update prototypes of emacs_write and emacs_read.
6023
6024 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6025
6026 * xdisp.c (redisplay_window): Don't try to determine the character
6027 position of the scroll margin if the window start point w->startp
6028 is outside the buffer's accessible region. (Bug#8468)
6029
6030 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6031
6032 Fix write-region and its subroutines for buffers > 2GB.
6033 * fileio.c (a_write, e_write): Modify declaration of arguments and
6034 local variables to support buffers larger than 2GB.
6035 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6036
6037 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6038 argument, local variables, and return value.
6039
6040 * lisp.h: Update prototypes of emacs_write and emacs_read.
6041
6042 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6043
6044 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6045
6046 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6047
6048 Fix more problems found by GCC 4.6.0's static checks.
6049
6050 * xdisp.c (vmessage): Use a better test for character truncation.
6051
6052 * charset.c (load_charset_map): <, not <=, for optimization,
6053 and to avoid potential problems with integer overflow.
6054 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6055 * casetab.c (set_identity, shuffle): Likewise.
6056 * editfns.c (Fformat): Likewise.
6057 * syntax.c (skip_chars): Likewise.
6058
6059 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6060 This also lets GCC 4.6.0 generate slightly better loop code.
6061
6062 * callint.c (Fcall_interactively): <, not <=, for optimization.
6063 (Fcall_interactively): Count the number of arguments produced,
6064 not the number of arguments given. This is simpler and lets GCC
6065 4.6.0 generate slightly better code.
6066
6067 * ftfont.c: Distingish more carefully between FcChar8 and char.
6068 The previous code passed unsigned char * to a functions like
6069 strlen and xstrcasecmp that expect char *, which does not
6070 conform to the C standard.
6071 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6072 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6073 char * when the C standard requires it.
6074
6075 * keyboard.c (read_char): Remove unused var.
6076
6077 * eval.c: Port to Windows vsnprintf (Bug#8435).
6078 Include <limits.h>.
6079 (SIZE_MAX): Define if the headers do not.
6080 (verror): Do not give up if vsnprintf returns a negative count.
6081 Instead, grow the buffer. This ports to Windows vsnprintf, which
6082 does not conform to C99. Problem reported by Eli Zaretskii.
6083 Also, simplify the allocation scheme, by avoiding the need for
6084 calling realloc, and removing the ALLOCATED variable.
6085
6086 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6087
6088 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6089 But keep the doprint source code for now, as we might revamp it
6090 and use it again (Bug#8435).
6091 * lisp.h (doprnt): Remove.
6092 * Makefile.in (base_obj): Remove doprnt.o.
6093 * deps.mk (doprnt.o): Remove.
6094
6095 error: Print 32- and 64-bit integers portably (Bug#8435).
6096 Without this change, on typical 64-bit hosts error ("...%d...", N)
6097 was used to print both 32- and 64-bit integers N, which relied on
6098 undefined behavior.
6099 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6100 New macro.
6101 * lisp.h (error, verror): Mark as printf-like functions.
6102 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6103 Report overflow in size calculations when allocating printf buffer.
6104 Do not truncate output string at its first null byte.
6105 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6106 Truncate the output at a character boundary, since vsnprintf does not
6107 do that.
6108 * charset.c (check_iso_charset_parameter): Convert internal
6109 character to string before calling 'error', since %c now has the
6110 printf meaning.
6111 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6112 overflow when computing char to be passed to 'error'. Do not
6113 pass Lisp_Object to 'error'; pass the integer instead.
6114 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6115 formatted with plain %d.
6116
6117 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6118
6119 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6120
6121 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6122
6123 * xterm.c (x_catch_errors): Remove duplicate declaration.
6124
6125 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6126
6127 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6128
6129 2011-04-10 Jim Meyering <meyering@redhat.com>
6130
6131 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6132 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6133 return ssize_t not "int", and use size_t as the buffer length.
6134 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6135 * gnutls.h: Update declarations.
6136 * process.c (read_process_output): Use ssize_t, to match.
6137 (send_process): Likewise.
6138
6139 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6140
6141 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6142
6143 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6144
6145 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6146 Use unsigned char, to match FcChar8 type definition.
6147
6148 * xterm.c (handle_one_xevent):
6149 * xmenu.c (create_and_show_popup_menu):
6150 * xselect.c (x_decline_selection_request)
6151 (x_reply_selection_request): Avoid type-punned deref of X events.
6152
6153 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6154
6155 Fix some uses of `int' instead of EMACS_INT.
6156 * search.c (string_match_1, fast_string_match)
6157 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6158 (scan_buffer, find_next_newline_no_quit)
6159 (find_before_next_newline, search_command, Freplace_match)
6160 (Fmatch_data): Make some `int' variables be EMACS_INT.
6161
6162 * xdisp.c (display_count_lines): 3rd argument and return value now
6163 EMACS_INT. All callers changed.
6164 (pint2hrstr): Last argument is now EMACS_INT.
6165
6166 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6167 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6168 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6169 (decode_coding_utf_16, decode_coding_emacs_mule)
6170 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6171 (decode_coding_ccl, decode_coding_charset)
6172 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6173 (decode_coding_iso_2022, decode_coding_emacs_mule)
6174 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6175 <char_offset, last_offset>: Declare EMACS_INT.
6176 (encode_coding_utf_8, encode_coding_utf_16)
6177 (encode_coding_emacs_mule, encode_invocation_designation)
6178 (encode_designation_at_bol, encode_coding_iso_2022)
6179 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6180 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6181 Declare EMACS_INT.
6182 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6183 (encode_invocation_designation): Last argument P_NCHARS is now
6184 EMACS_INT.
6185 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6186 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6187
6188 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6189 All users changed.
6190
6191 * ccl.c (Fccl_execute_on_string): Declare some variables
6192 EMACS_INT.
6193
6194 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6195
6196 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6197
6198 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6199
6200 * process.c (Fformat_network_address): Doc fix.
6201
6202 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6203
6204 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6205
6206 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6207
6208 * keyboard.c (read_char): Call Lisp function help-form-show,
6209 instead of using internal_with_output_to_temp_buffer.
6210 (Qhelp_form_show): New var.
6211 (syms_of_keyboard): Use DEFSYM macro.
6212
6213 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6214
6215 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6216
6217 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6218
6219 * process.c (Flist_processes): Remove to Lisp.
6220 (list_processes_1): Delete.
6221
6222 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6223
6224 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6225
6226 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6227
6228 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6229
6230 Fix more problems found by GCC 4.6.0's static checks.
6231
6232 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6233
6234 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6235
6236 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6237
6238 * xdisp.c (vmessage): Mark as a printf-like function.
6239
6240 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6241
6242 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6243
6244 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6245 printf-like functions.
6246 (tiff_load): Add casts to remove these marks before passing them
6247 to system-supplied API.
6248
6249 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6250
6251 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6252 This avoids several warnings with gcc -Wstrict-overflow.
6253 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6254 directly, rather than having caller test rule sign. This avoids
6255 some unnecessary tests.
6256 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6257 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6258 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6259
6260 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6261 (xfont_open): Avoid unnecessary tests.
6262
6263 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6264
6265 * composite.h, composite.c (composition_gstring_put_cache):
6266 Use EMACS_INT, not int, for length.
6267
6268 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6269 breaking out part of COMPOSITION_DECODE_RULE.
6270 (COMPOSITION_DECODE_RULE): Use it.
6271 * composite.c (get_composition_id): Remove unused local vars,
6272 by using the new macro.
6273
6274 * textprop.c (set_text_properties_1): Change while to do-while,
6275 since the condition is always true at first.
6276
6277 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6278 (interval_deletion_adjustment): Return unsigned value.
6279 All uses changed.
6280
6281 * process.c (list_processes_1, create_pty, read_process_output):
6282 (exec_sentinel): Remove vars that were set but not used.
6283 (create_pty): Remove unnecessary "volatile"s.
6284 (Fnetwork_interface_info): Avoid possibility of int overflow.
6285 (read_process_output): Do adaptive read buffering even if carryover.
6286 (read_process_output): Simplify nbytes computation if buffered.
6287
6288 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6289
6290 * syntax.c (scan_words): Remove var that was set but not used.
6291 (update_syntax_table): Use unsigned instead of int.
6292
6293 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6294 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6295 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6296
6297 * print.c (print_error_message): Avoid int overflow.
6298
6299 * font.c (font_list_entities): Redo for clarity,
6300 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6301
6302 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6303 (font_score): Avoid potential overflow in diff calculation.
6304
6305 * fns.c (substring_both): Remove var that is set but not used.
6306 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6307
6308 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6309
6310 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6311 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6312 can always succeed if overflow has undefined behavior.
6313
6314 * search.c (boyer_moore, wordify): Remove vars set but not used.
6315 (wordify): Omit three unnecessary tests.
6316
6317 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6318 All callers changed. This avoids the need for an unused var.
6319
6320 * casefiddle.c (casify_region): Remove var that is set but not used.
6321
6322 * dired.c (file_name_completion): Remove var that is set but not used.
6323
6324 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6325
6326 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6327 (Finsert_file_contents): Remove unnecessary code checking fd.
6328
6329 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6330 Check for integer overflow on size calculations.
6331
6332 * buffer.c (Fprevious_overlay_change): Remove var that is set
6333 but not used.
6334
6335 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6336 Remove vars that are set but not used.
6337 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6338 (timer_check_2): Mark vars as initialized.
6339
6340 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6341
6342 * image.c (lookup_image): Remove var that is set but not used.
6343 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6344
6345 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6346 that are set but not used.
6347
6348 * xfns.c (make_invisible_cursor): Don't return garbage
6349 if XCreateBitmapFromData fails (Bug#8410).
6350
6351 * xselect.c (x_get_local_selection, x_handle_property_notify):
6352 Remove vars that are set but not used.
6353
6354 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6355 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6356
6357 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6358 Remove var that is set but not used.
6359 (scroll_bar_windows_size): Now size_t, not int.
6360 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6361 Check for overflow.
6362
6363 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6364 (map_tty_color) [!defined MSDOS]: Likewise.
6365
6366 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6367
6368 * coding.c: Remove vars that are set but not used.
6369 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6370 All callers changed.
6371 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6372 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6373 (decode_coding_charset): Remove vars that are set but not used.
6374
6375 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6376 that is set but not used.
6377
6378 * print.c (print_object): Remove var that is set but not used.
6379
6380 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6381 The gnulib version avoids calling malloc in the usual case,
6382 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6383 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6384 * filelock.c (current_lock_owner): Likewise.
6385 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6386 * sysdep.c: Include allocator.h, careadlinkat.h.
6387 (emacs_no_realloc_allocator): New static constant.
6388 (emacs_readlink): New function.
6389 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6390 ../lib/careadlinkat.h.
6391
6392 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6393
6394 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6395 first non-nil return value).
6396
6397 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6398
6399 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6400 if not defined (Bug#8403).
6401
6402 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6403
6404 * xdisp.c (display_count_lines): Remove parameter `start',
6405 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6406 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6407 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6408 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6409 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6410 and thereabouts. All callers changed.
6411 (get_per_char_metric): Remove parameter `f', unused since
6412 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6413
6414 2011-04-02 Jim Meyering <meyering@redhat.com>
6415
6416 do not dereference NULL upon failed strdup
6417 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6418 (ns_get_family): Likewise.
6419
6420 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6421
6422 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6423
6424 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6425
6426 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6427 later (Bug#8403).
6428
6429 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6430
6431 Add lexical binding.
6432
6433 * window.c (Ftemp_output_buffer_show): New fun.
6434 (Fsave_window_excursion):
6435 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6436
6437 * lread.c (lisp_file_lexically_bound_p): New function.
6438 (Fload): Bind Qlexical_binding.
6439 (readevalloop): Remove `evalfun' arg.
6440 Bind Qinternal_interpreter_environment.
6441 (Feval_buffer): Bind Qlexical_binding.
6442 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6443 Mark as dynamic.
6444 (syms_of_lread): Declare `lexical-binding'.
6445
6446 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6447
6448 * keyboard.c (eval_dyn): New fun.
6449 (menu_item_eval_property): Use it.
6450
6451 * image.c (parse_image_spec): Use Ffunctionp.
6452
6453 * fns.c (concat, mapcar1): Accept byte-code-functions.
6454
6455 * eval.c (Fsetq): Handle lexical vars.
6456 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6457 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6458 (FletX, Flet): Obey lexical binding.
6459 (Fcommandp): Handle closures.
6460 (Feval): New `lexical' arg.
6461 (eval_sub): New function extracted from Feval. Use it almost
6462 everywhere where Feval was used. Look up vars in lexical env.
6463 Handle closures.
6464 (Ffunctionp): Move from subr.el.
6465 (Ffuncall): Handle closures.
6466 (apply_lambda): Remove `eval_flags'.
6467 (funcall_lambda): Handle closures and new byte-code-functions.
6468 (Fspecial_variable_p): New function.
6469 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6470 but without exporting it to Lisp.
6471
6472 * doc.c (Fdocumentation, store_function_docstring):
6473 * data.c (Finteractive_form): Handle closures.
6474
6475 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6476 interactive spec.
6477
6478 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6479 New byte-codes.
6480 (exec_byte_code): New function extracted from Fbyte_code to handle new
6481 calling convention for byte-code-functions. Add new byte-codes.
6482
6483 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6484
6485 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6486
6487 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6488
6489 * xdisp.c (redisplay_internal): Fix prototype.
6490
6491 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6492
6493 * xdisp.c (SCROLL_LIMIT): New macro.
6494 (try_scrolling): Use it when setting scroll_limit.
6495 Limit scrolling to 100 screen lines.
6496 (redisplay_window): Even when falling back on "recentering",
6497 position point in the window according to scroll-conservatively,
6498 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6499
6500 (try_scrolling): When point is above the window, allow searching
6501 as far as scroll_max, or one screenful, to compute vertical
6502 distance from PT to the scroll margin position. This prevents
6503 try_scrolling from unnecessarily failing when
6504 scroll-conservatively is set to a value slightly larger than the
6505 window height. Clean up the case of PT below the margin at bottom
6506 of window: scroll_max can no longer be INT_MAX. When aggressive
6507 scrolling is in use, don't let point enter the opposite scroll
6508 margin as result of the scroll.
6509 (syms_of_xdisp) <scroll-conservatively>: Document the
6510 threshold of 100 lines for never-recentering scrolling.
6511
6512 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6513
6514 * dispextern.h (move_it_by_lines):
6515 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6516 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6517 (message_log_check_duplicate): Remove parameters `prev_bol' and
6518 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6519 (redisplay_internal): Remove parameter `preserve_echo_area',
6520 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6521
6522 * indent.c (Fvertical_motion):
6523 * window.c (window_scroll_pixel_based, Frecenter):
6524 Don't pass `need_y_p' to `move_it_by_lines'.
6525
6526 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6527
6528 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6529 steal a few bits to be more compact.
6530 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6531 Remove unneeded casts.
6532
6533 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6534
6535 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6536
6537 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6538 binding" message (bug#7967).
6539
6540 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6541
6542 Fix more problems found by GCC 4.6.0's static checks.
6543
6544 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6545 Remove unused local var.
6546
6547 * editfns.c (Fmessage_box): Remove unused local var.
6548
6549 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6550 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6551 Omit unused local vars.
6552 * window.c (shrink_windows): Omit unused local var.
6553 * menu.c (digest_single_submenu): Omit unused local var.
6554 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6555 Omit unused local var.
6556
6557 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6558 Don't assume string length fits in int.
6559 (keyremap_step, read_key_sequence): Use size_t for sizes.
6560 (read_key_sequence): Don't check last_real_key_start redundantly.
6561
6562 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6563 instead of alloca (Bug#8344).
6564
6565 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6566 (Fbacktrace_frame): Don't assume nframes fits in int.
6567
6568 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6569
6570 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6571 concerns.
6572
6573 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6574
6575 * cm.c (calccost): Turn while-do into do-while, for clarity.
6576
6577 * keyboard.c (syms_of_keyboard): Use the same style as later
6578 in this function when indexing through an array. This also
6579 works around GCC bug 48267.
6580
6581 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6582
6583 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6584
6585 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6586 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6587
6588 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6589 This avoids undefined behavior on integer overflow, and is a bit
6590 more convenient anyway since it is compared to a size_t variable.
6591
6592 Variadic C functions now count arguments with size_t, not int.
6593 This avoids an unnecessary limitation on 64-bit machines, which
6594 caused (substring ...) to crash on large vectors (Bug#8344).
6595 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6596 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6597 All variadic functions and their callers changed accordingly.
6598 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6599 * data.c (arith_driver, float_arith_driver): Likewise.
6600 * editfns.c (general_insert_function): Likewise.
6601 * eval.c (struct backtrace.nargs, interactive_p)
6602 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6603 (funcall_lambda, mark_backtrace): Likewise.
6604 * fns.c (concat): Likewise.
6605 * frame.c (x_set_frame_parameters): Likewise.
6606 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6607 0 if not found, not -1. All callers changed.
6608
6609 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6610 (stack_copy_size): Now size_t, not int.
6611 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6612
6613 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6614
6615 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6616 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6617 All callers changed.
6618
6619 * lisp.h (multibyte_char_to_unibyte):
6620 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6621 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6622 * character.h (CHAR_TO_BYTE8):
6623 * cmds.c (internal_self_insert):
6624 * editfns.c (general_insert_function):
6625 * keymap.c (push_key_description):
6626 * search.c (Freplace_match):
6627 * xdisp.c (message_dolog, set_message_1): All callers changed.
6628
6629 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6630
6631 * keyboard.c (safe_run_hook_funcall): New function.
6632 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6633 don't set the hook to nil, but remove the offending function instead.
6634 (Qcommand_hook_internal): Remove, unused.
6635 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6636 Vcommand_hook_internal.
6637
6638 * eval.c (enum run_hooks_condition): Remove.
6639 (funcall_nil, funcall_not): New functions.
6640 (run_hook_with_args): Call each function through a `funcall' argument.
6641 Remove `cond' argument, now redundant.
6642 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6643 (Frun_hook_with_args_until_failure): Adjust accordingly.
6644 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6645
6646 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6647
6648 * dispextern.h (string_buffer_position): Remove declaration.
6649
6650 * print.c (strout): Remove parameter `multibyte', unused since
6651 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6652
6653 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6654 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6655 All callers changed.
6656
6657 * w32.c (_wsa_errlist): Use braces for struct initializers.
6658
6659 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6660 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6661 All callers changed.
6662 (string_buffer_position): Likewise. Also, make static (it's never
6663 used outside xdisp.c).
6664 (cursor_row_p): Remove parameter `w', unused since
6665 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6666 (decode_mode_spec): Remove parameter `precision', introduced during
6667 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6668 All callers changed.
6669
6670 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6671
6672 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6673
6674 2011-03-27 Anders Lindgren <andlind@gmail.com>
6675
6676 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6677 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6678 (ns_update_auto_hide_menu_bar): New functions.
6679 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6680 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6681 ns_constrain_all_frames.
6682 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6683 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6684
6685 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6686
6687 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6688
6689 2011-03-27 Glenn Morris <rgm@gnu.org>
6690
6691 * syssignal.h: Replace RETSIGTYPE with void.
6692 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6693 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6694 Replace SIGTYPE with void everywhere.
6695 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6696 * s/template.h (SIGTYPE): Remove commented out definition.
6697
6698 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6699
6700 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6701 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6702
6703 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6704
6705 * w32.c (read_unc_volume): Use parameter `henum', instead of
6706 global variable `wget_enum_handle'.
6707
6708 * keymap.c (describe_vector): Remove parameters `indices' and
6709 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6710 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6711
6712 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6713
6714 * keyboard.c (timer_check): Remove parameter `do_it_now',
6715 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6716 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6717 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6718
6719 * keyboard.c (read_char):
6720 * w32menu.c (w32_menu_display_help):
6721 * xmenu.c (show_help_event, menu_help_callback):
6722 Adjust calls to `show_help_echo'.
6723
6724 * gtkutil.c (xg_maybe_add_timer):
6725 * keyboard.c (readable_events):
6726 * process.c (wait_reading_process_output):
6727 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6728
6729 * insdel.c (adjust_markers_gap_motion):
6730 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6731 (gap_left, gap_right): Don't call it.
6732
6733 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6734
6735 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6736 incurred during fontification.
6737
6738 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6739
6740 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6741 (DEFVAR_PER_BUFFER): Don't pass it.
6742
6743 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6744 (scrolling_window): Don't pass it.
6745
6746 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6747
6748 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6749
6750 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6751 and `suffix'.
6752 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6753 of variables specific to SELinux and computation of `encoded_absname'.
6754
6755 * image.c (XPutPixel): Remove unused variable `height'.
6756
6757 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6758
6759 * unexw32.c (get_section_info): Remove unused variable `section'.
6760
6761 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6762 (system_process_attributes): Remove unused variable `sess'.
6763 (sys_read): Remove unused variable `err'.
6764
6765 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6766 (w32_wnd_proc): Remove unused variable `isdead'.
6767 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6768 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6769 (x_create_tip_frame): Remove unused variable `tem'.
6770
6771 * w32inevt.c (w32_console_read_socket):
6772 Remove unused variable `no_events'.
6773
6774 * w32term.c (x_draw_composite_glyph_string_foreground):
6775 Remove unused variable `width'.
6776
6777 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6778
6779 * w32term.c (x_set_glyph_string_clipping):
6780 Don't pass uninitialized region to CombineRgn.
6781
6782 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6783
6784 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6785 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6786 (Fx_close_connection): Remove unused variable `i'.
6787
6788 * w32font.c (w32font_draw): Return number of glyphs.
6789 (w32font_open_internal): Remove unused variable `i'.
6790 (w32font_driver): Add missing initializer.
6791
6792 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6793 (fill_in_menu): Remove unused variable `items_added'.
6794
6795 * w32term.c (last_mouse_press_frame): Remove static global variable.
6796 (w32_clip_to_row): Remove unused variable `f'.
6797 (x_delete_terminal): Remove unused variable `i'.
6798
6799 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6800 (NOTHING): Remove unused static global variable.
6801 (uniscribe_check_otf): Remove unused variable `table'.
6802 (uniscribe_font_driver): Add missing initializers.
6803
6804 2011-03-23 Julien Danjou <julien@danjou.info>
6805
6806 * term.c (Fsuspend_tty, Fresume_tty):
6807 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6808 * window.c (temp_output_buffer_show):
6809 * insdel.c (signal_before_change):
6810 * frame.c (Fhandle_switch_frame):
6811 * fileio.c (Fdo_auto_save):
6812 * emacs.c (Fkill_emacs):
6813 * editfns.c (save_excursion_restore):
6814 * cmds.c (internal_self_insert):
6815 * callint.c (Fcall_interactively):
6816 * buffer.c (Fkill_all_local_variables):
6817 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6818 Use Frun_hooks.
6819 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6820 unconditionnaly since it does the check itself.
6821
6822 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6823
6824 Fix more problems found by GCC 4.5.2's static checks.
6825
6826 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6827 the first time through the loop, since we know p0 < p1 then.
6828 This also avoids a gcc -Wstrict-overflow warning.
6829
6830 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6831 leading to a memory leak, possible in functions like
6832 load_charset_map_from_file that can allocate an unbounded number
6833 of objects (Bug#8318).
6834
6835 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6836 that could (at least in theory) be that large.
6837
6838 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6839 This is less likely to overflow, and avoids undefined behavior if
6840 overflow does occur. All callers changed. Use strtoul to scan
6841 for the unsigned long integer.
6842 (pint2hrstr): Simplify and tune code slightly.
6843 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6844
6845 * scroll.c (do_scrolling): Work around GCC bug 48228.
6846 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6847
6848 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6849 This also avoids a warning with gcc -Wstrict-overflow.
6850 (validate_x_resource_name): Simplify count usage.
6851 This also avoids a warning with gcc -Wstrict-overflow.
6852
6853 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6854 fail (Bug#8306).
6855
6856 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6857
6858 * process.c (Fmake_network_process): Use socklen_t, not int,
6859 where POSIX says socklen_t is required in portable programs.
6860 This fixes a porting bug on hosts like 64-bit HP-UX, where
6861 socklen_t is wider than int (Bug#8277).
6862 (Fmake_network_process, server_accept_connection):
6863 (wait_reading_process_output, read_process_output):
6864 Likewise.
6865
6866 * process.c: Rename or move locals to avoid shadowing.
6867 (list_processes_1, Fmake_network_process):
6868 (read_process_output_error_handler, exec_sentinel_error_handler):
6869 Rename or move locals.
6870 (Fmake_network_process): Define label "retry_connect" only if needed.
6871 (Fnetwork_interface_info): Fix pointer signedness.
6872 (process_send_signal): Add cast to avoid pointer signedness problem.
6873 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6874 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6875
6876 Make tparam.h and terminfo.c consistent.
6877 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6878 Include tparam.h instead, since it declares them.
6879 * cm.h (PC): Remove extern decl; tparam.h now does this.
6880 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6881 * terminfo.c: Include tparam.h, to check interfaces.
6882 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6883 (tparam): Adjust signature to match interface in tparam.h;
6884 this removes some undefined behavior. Check that outstring and len
6885 are zero, which they always are with Emacs.
6886 * tparam.h (PC, BC, UP): New extern decls.
6887
6888 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6889 (xftfont_open): Rename locals to avoid shadowing.
6890
6891 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6892 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6893 (OTF_TAG_SYM): Omit macro if not needed.
6894 (ftfont_list): Remove unused local.
6895 (get_adstyle_property, ftfont_pattern_entity):
6896 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6897 Rename locals to avoid shadowing.
6898
6899 * xfont.c (xfont_list_family): Mark var as initialized.
6900
6901 * xml.c (make_dom): Now static.
6902
6903 * composite.c (composition_compute_stop_pos): Rename local to
6904 avoid shadowing.
6905 (composition_reseat_it): Remove unused locals.
6906 (find_automatic_composition, composition_adjust_point): Likewise.
6907 (composition_update_it): Mark var as initialized.
6908 (find_automatic_composition): Mark vars as initialized,
6909 with a FIXME (Bug#8290).
6910
6911 character.h: Rename locals to avoid shadowing.
6912 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6913 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6914 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6915 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6916 to avoid shadowing.
6917
6918 * textprop.c (property_change_between_p): Remove; unused.
6919
6920 * intervals.c (interval_start_pos): Now static.
6921
6922 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6923
6924 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6925 Rename locals to avoid shadowing.
6926
6927 * sound.c (wav_play, au_play, Fplay_sound_internal):
6928 Fix pointer signedness.
6929 (alsa_choose_format): Remove unused local var.
6930 (wav_play): Initialize a variable to 0, to prevent undefined
6931 behavior (Bug#8278).
6932
6933 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6934
6935 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6936
6937 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6938 clobbering (Bug#8298).
6939 * sysdep.c (sys_subshell): Likewise.
6940 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6941
6942 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6943 This should get cleaned up, so that child_setup has the
6944 same signature on all platforms.
6945
6946 * callproc.c (call_process_cleanup): Now static.
6947 (relocate_fd): Rename locals to avoid shadowing.
6948
6949 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6950
6951 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6952 not to be necessary, and produces flickering.
6953
6954 2011-03-20 Glenn Morris <rgm@gnu.org>
6955
6956 * config.in: Remove file.
6957
6958 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6959
6960 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6961 are now in src/globals.h.
6962 (syms_of_minibuf): Remove spurious & from previous change.
6963
6964 2011-03-20 Leo <sdl.web@gmail.com>
6965
6966 * minibuf.c (completing-read-function): New variable.
6967 (completing-read-default): Rename from completing-read.
6968 (completing-read): Call completing-read-function.
6969
6970 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6971
6972 * xfaces.c (Fx_load_color_file):
6973 Read color file from absolute filename (bug#8250).
6974
6975 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6976
6977 * makefile.w32-in: Update dependencies.
6978
6979 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6980
6981 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6982
6983 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6984
6985 Fix more problems found by GCC 4.5.2's static checks.
6986
6987 * process.c (make_serial_process_unwind, send_process_trap):
6988 (sigchld_handler): Now static.
6989
6990 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6991 That way, the code declares only the vars that it needs.
6992 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6993 * s/cygwin.h (PTY_ITERATION): Likewise.
6994 * s/darwin.h (PTY_ITERATION): Likewise.
6995 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6996
6997 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6998 * process.c (allocate_pty): Don't declare stb unless it's needed.
6999
7000 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7001 (CONSTANTLIM): Remove; unused.
7002 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7003 Define only if needed.
7004
7005 * unexelf.c (unexec): Name an expression,
7006 to avoid gcc -Wbad-function-cast warning.
7007 Use a different way to cause a compilation error if anyone uses
7008 n rather than nn, a way that does not involve shadowing.
7009 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7010
7011 * deps.mk (unexalpha.o): Remove; unused.
7012
7013 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7014 * unexec.h: New file.
7015 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7016 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7017 Depend on unexec.h.
7018 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7019 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7020 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7021 Change as necessary to match prototype in unexec.h.
7022
7023 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7024 shadowing.
7025 (back_comment, skip_chars): Mark vars as initialized.
7026
7027 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7028 Rename locals to avoid shadowing.
7029
7030 * lread.c (read1): Rewrite so as not to use empty "else".
7031 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7032
7033 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7034
7035 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7036 warning when compiling print.c.
7037
7038 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7039 instead of using an uninitialized var.
7040 (font_sort_entities): Mark var as initialized.
7041
7042 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7043
7044 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7045 pointers to constants.
7046 (font_parse_fcname): Remove unused vars.
7047 (font_delete_unmatched): Now static.
7048 (font_get_spec): Remove; unused.
7049 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7050 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7051 Rename or move locals to avoid shadowing.
7052
7053 * fns.c (require_nesting_list, require_unwind): Now static.
7054 (Ffillarray): Rename locals to avoid shadowing.
7055
7056 * floatfns.c (domain_error2): Define only if needed.
7057 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7058
7059 * alloc.c (mark_backtrace): Move decl from here ...
7060 * lisp.h: ... to here, so that it can be checked.
7061
7062 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7063 (Fdefvar): Rewrite so as not to use empty "else".
7064 (lisp_indirect_variable): Name an expression,
7065 to avoid gcc -Wbad-function-cast warning.
7066 (Fdefvar): Rename locals to avoid shadowing.
7067
7068 * callint.c (quotify_arg, quotify_args): Now static.
7069 (Fcall_interactively): Rename locals to avoid shadowing.
7070 Use const pointer when appropriate.
7071
7072 * lisp.h (get_system_name, get_operating_system_release):
7073 Move decls here, to check interfaces.
7074 * process.c (get_operating_system_release): Move decl to lisp.h.
7075 * xrdb.c (get_system_name): Likewise.
7076 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7077 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7078 some of which prompt warnings from gcc -Wbad-function-cast.
7079 (Fformat_time_string, Fencode_time, Finsert_char):
7080 (Ftranslate_region_internal, Fformat):
7081 Rename or remove local vars to avoid shadowing.
7082 (Ftranslate_region_internal): Mark var as initialized.
7083
7084 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7085 avoid shadowing.
7086
7087 * lisp.h (eassert): Check that the argument compiles, even if
7088 ENABLE_CHECKING is not defined.
7089
7090 * data.c (Findirect_variable): Name an expression, to avoid
7091 gcc -Wbad-function-cast warning.
7092 (default_value, arithcompare, arith_driver, arith_error): Now static.
7093 (store_symval_forwarding): Rename local to avoid shadowing.
7094 (Fmake_variable_buffer_local, Fmake_local_variable):
7095 Mark variables as initialized.
7096 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7097
7098 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7099 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7100 Rename locals to avoid shadowing.
7101 (mark_stack): Move local variables into the #ifdef region where
7102 they're used.
7103 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7104 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7105 needed otherwise.
7106 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7107 (GC_STRING_CHARS): Remove; not used.
7108 (Fmemory_limit): Cast sbrk's returned value to char *.
7109
7110 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7111 avoids undefined behavior in theory.
7112
7113 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7114
7115 Use functions, not macros, for up- and down-casing (Bug#8254).
7116 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7117 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7118 to use the following functions instead of these macros.
7119 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7120 EMACS_INT, since callers assume the returned value fits in int.
7121 (upcase1): Likewise, for UPCASE_TABLE.
7122 (uppercasep, lowercasep, upcase): New static inline functions.
7123 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7124 the race-condition problem in the old DOWNCASE.
7125
7126 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7127 Rename locals to avoid shadowing.
7128 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7129 (regex_compile, re_search_2, re_match_2_internal):
7130 Remove unused local vars.
7131 (FREE_VAR): Rewrite so as not to use empty "else",
7132 which gcc can warn about.
7133 (regex_compile, re_match_2_internal): Mark locals as initialized.
7134 (RETALLOC_IF): Define only if needed.
7135 (WORDCHAR_P): Likewise. This one is never needed, but is used
7136 only in a comment talking about a compiler bug, so put inside
7137 the #if 0 of that comment.
7138 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7139 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7140 Remove; unused.
7141
7142 * search.c (boyer_moore): Rename locals to avoid shadowing.
7143 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7144 (PREV_CHAR_BOUNDARY): Likewise.
7145
7146 * search.c (simple_search): Remove unused var.
7147
7148 * dired.c (compile_pattern): Move decl from here ...
7149 * lisp.h: ... to here, so that it can be checked.
7150 (struct re_registers): New forward decl.
7151
7152 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7153
7154 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7155 All uses changed.
7156 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7157 Rename locals to avoid shadowing.
7158 (Fvertical_motion): Mark locals as initialized.
7159
7160 * casefiddle.c (casify_object, casify_region): Now static.
7161 (casify_region): Mark local as initialized.
7162
7163 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7164
7165 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7166 New macros, so that the caller can use some names other than
7167 gcpro1, gcpro2, etc.
7168 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7169 of the new macros.
7170 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7171 argument, for consistency with GCPRO2_VAR, etc: it is now the
7172 prefix of the variable, not the variable itself. All uses
7173 changed.
7174 * dired.c (directory_files_internal, file_name_completion):
7175 Rename locals to avoid shadowing.
7176
7177 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7178 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7179 dired.c's scmp function, had undefined behavior.
7180 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7181 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7182 * buffer.h: ... to here, because these macros use current_buffer,
7183 and the new implementation with inline functions needs to have
7184 current_buffer in scope now, rather than later when the macros
7185 are used.
7186 (downcase, upcase1): New static inline functions.
7187 (DOWNCASE, UPCASE1): Reimplement using these functions.
7188 This avoids undefined behavior in expressions like
7189 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7190 from race conditions in accessing the global variables
7191 case_temp1 and case_temp2.
7192 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7193 * lisp.h (case_temp1, case_temp2): Remove their decls.
7194 * character.h (ASCII_CHAR_P): Move from here ...
7195 * lisp.h: ... to here, so that the inline functions mentioned
7196 above can use them.
7197
7198 * dired.c (directory_files_internal_unwind): Now static.
7199
7200 * fileio.c (file_name_as_directory, directory_file_name):
7201 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7202 Now static.
7203 (file_name_as_directory): Use const pointers when appropriate.
7204 (Fexpand_file_name): Likewise. In particular, newdir might
7205 point at constant storage, so make it a const pointer.
7206 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7207 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7208 signedness issues.
7209 (Fset_file_times, Finsert_file_contents, auto_save_error):
7210 Rename locals to avoid shadowing.
7211
7212 * minibuf.c (choose_minibuf_frame_1): Now static.
7213 (Ftry_completion, Fall_completions): Rename or remove locals
7214 to avoid shadowing.
7215
7216 * marker.c (bytepos_to_charpos): Remove; unused.
7217
7218 * lisp.h (verify_bytepos, count_markers): New decls,
7219 so that gcc does not warn that these functions aren't declared.
7220
7221 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7222 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7223 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7224 (copy_text): Remove unused local var.
7225
7226 * filelock.c (within_one_second): Now static.
7227 (lock_file_1): Rename local to avoid shadowing.
7228
7229 * buffer.c (fix_overlays_before): Mark locals as initialized.
7230 (fix_start_end_in_overlays): Likewise. This function should be
7231 simplified by using pointers-to-pointers, but that's a different
7232 matter.
7233 (switch_to_buffer_1): Now static.
7234 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7235 (report_overlay_modification): Rename locals to avoid shadowing.
7236
7237 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7238 Fix pointer signedness issue.
7239 (sys_subshell): Mark local as volatile if checking for lint,
7240 to suppress a gcc -Wclobbered warning that does not seem to be right.
7241 (MAXPATHLEN): Define only if needed.
7242
7243 * process.c (serial_open, serial_configure): Move decls from here ...
7244 * systty.h: ... to here, so that they can be checked.
7245
7246 * fns.c (get_random, seed_random): Move extern decls from here ...
7247 * lisp.h: ... to here, so that they can be checked.
7248
7249 * sysdep.c (reset_io): Now static.
7250 (wait_for_termination_signal): Remove; unused.
7251
7252 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7253 (copy_keymap_item, append_key, push_text_char_description):
7254 Now static.
7255 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7256 (DENSE_TABLE_SIZE): Remove; unused.
7257 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7258 (describe_map_tree):
7259 Rename locals to avoid shadowing.
7260
7261 * keyboard.c: Declare functions static if they are not used elsewhere.
7262 (echo_char, echo_dash, cmd_error, top_level_2):
7263 (poll_for_input, handle_async_input): Now static.
7264 (read_char, kbd_buffer_get_event, make_lispy_position):
7265 (make_lispy_event, make_lispy_movement, apply_modifiers):
7266 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7267 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7268 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7269 (read_key_sequence, read_char): Mark locals as initialized.
7270 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7271
7272 * keyboard.h (make_ctrl_char): New decl.
7273 (mark_kboards): Move decl here ...
7274 * alloc.c (mark_kboards): ... from here.
7275
7276 * lisp.h (force_auto_save_soon): New decl.
7277
7278 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7279 (DEFINE_DUMMY_FUNCTION): New macro.
7280 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7281 Use it.
7282 (main): Add casts to avoid warnings
7283 if GCC considers string literals to be constants.
7284
7285 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7286
7287 * dbusbind.c: Pointer signedness fixes.
7288 (xd_signature, xd_append_arg, xd_initialize):
7289 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7290 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7291 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7292 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7293
7294 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7295 if GCC considers string literals to be constants.
7296 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7297
7298 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7299
7300 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7301 (print_preprocess, print_object): New macro to fix last change.
7302
7303 * print.c (print_preprocess): Don't forget font objects.
7304
7305 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7306
7307 * emacs.c (USAGE3): Doc fixes.
7308
7309 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7310
7311 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7312 structure.
7313
7314 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7315
7316 * lisp.h (VWindow_system, Qfile_name_history):
7317 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7318 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7319 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7320
7321 * w32select.c: Don't #include "keyboard.h".
7322 (run_protected): Add extern declaration for waiting_for_input.
7323
7324 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7325 * w32console.c (detect_input_pending, read_input_pending)
7326 (encode_terminal_code):
7327 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7328 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7329 (w32_system_caret_y, Qfile_name_history):
7330 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7331 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7332 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7333 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7334 * w32proc.c (Qlocal, report_file_error):
7335 * w32term.c (Vwindow_system, updating_frame):
7336 * w32uniscribe.c (initialized, uniscribe_font_driver):
7337 Remove unneeded extern declarations.
7338
7339 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7340
7341 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7342
7343 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7344
7345 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7346 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7347 These macros can no longer be used for assignment.
7348
7349 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7350 Assign struct members directly, instead of using BUF_BEGV etc.
7351 (record_buffer_markers, fetch_buffer_markers): New functions for
7352 recording and fetching special buffer markers.
7353 (set_buffer_internal_1, set_buffer_temp): Use them.
7354
7355 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7356
7357 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7358
7359 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7360 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7361
7362 * xdisp.c (hscroll_window_tree):
7363 (reconsider_clip_changes): Use PT instead of BUF_PT.
7364
7365 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7366
7367 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7368 $(EMACS_ROOT)/lib/intprops.h.
7369
7370 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7371
7372 Fix more problems found by GCC 4.5.2's static checks.
7373
7374 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7375 to unsigned char * to avoid compiler diagnostic.
7376 (xg_free_frame_widgets): Make it clear that a local variable is
7377 needed only if USE_GTK_TOOLTIP.
7378 (gdk_window_get_screen): Make it clear that this macro is needed
7379 only if USE_GTK_TOOLTIP.
7380 (int_gtk_range_get_value): New function, which avoids a diagnostic
7381 from gcc -Wbad-function-cast.
7382 (xg_set_toolkit_scroll_bar_thumb): Use it.
7383 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7384 diagnostic from gcc -Wbad-function-cast.
7385 (get_utf8_string, xg_get_file_with_chooser):
7386 Rename locals to avoid shadowing.
7387 (create_dialog): Move locals to avoid shadowing.
7388
7389 * xgselect.c (xg_select): Remove unused var.
7390
7391 * image.c (four_corners_best): Mark locals as initialized.
7392 (gif_load): Initialize transparent_p to zero (Bug#8238).
7393 Mark another local as initialized.
7394 (my_png_error, my_error_exit): Mark with NO_RETURN.
7395
7396 * image.c (clear_image_cache): Now static.
7397 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7398 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7399 (x_edge_detection): Remove unnecessary cast that
7400 gcc -Wbad-function-cast diagnoses.
7401 (gif_load): Fix pointer signedness.
7402 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7403 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7404
7405 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7406
7407 Improve quality of tests for time stamp overflow.
7408 For example, without this patch (encode-time 0 0 0 1 1
7409 1152921504606846976) returns the obviously-bogus value (-948597
7410 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7411 reports time overflow. See
7412 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7413 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7414 * editfns.c: Include limits.h and intprops.h.
7415 (TIME_T_MIN, TIME_T_MAX): New macros.
7416 (time_overflow): Move earlier, to before first use.
7417 (hi_time, lo_time): New functions, for an accurate test for
7418 out-of-range times.
7419 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7420 (Fget_internal_run_time): Don't assume time_t fits in int.
7421 (make_time): Use list2 instead of Fcons twice.
7422 (Fdecode_time): More accurate test for out-of-range times.
7423 (check_tm_member): New function.
7424 (Fencode_time): Use it, to test for out-of-range times.
7425 (lisp_time_argument): Don't rely on undefined left-shift and
7426 right-shift behavior when checking for time stamp overflow.
7427
7428 * editfns.c (time_overflow): New function, refactoring common code.
7429 (Fformat_time_string, Fdecode_time, Fencode_time):
7430 (Fcurrent_time_string): Use it.
7431
7432 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7433 * dired.c (make_time): Move to ...
7434 * editfns.c (make_time): ... here.
7435 * systime.h: Note the move.
7436
7437 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7438
7439 * fringe.c (update_window_fringes): Remove unused variables.
7440
7441 * unexmacosx.c (copy_data_segment): Also copy __got section.
7442 (Bug#8223)
7443
7444 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7445
7446 * termcap.c [MSDOS]: Include "msdos.h".
7447 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7448 Constify `char *' arguments and their references according to
7449 prototypes in tparam.h.
7450
7451 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7452
7453 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7454 Adapt all references accordingly.
7455
7456 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7457
7458 2011-03-11 Tom Tromey <tromey@redhat.com>
7459
7460 * buffer.c (syms_of_buffer): Remove obsolete comment.
7461
7462 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7463
7464 * termhooks.h (encode_terminal_code): Declare prototype.
7465
7466 * msdos.c (encode_terminal_code): Don't declare prototype.
7467
7468 * term.c (encode_terminal_code): Now external again, used by
7469 w32console.c and msdos.c.
7470
7471 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7472 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7473
7474 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7475
7476 Fix some minor problems found by GCC 4.5.2's static checks.
7477
7478 * fringe.c (update_window_fringes): Mark locals as initialized
7479 (Bug#8227).
7480 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7481
7482 * alloc.c (mark_fringe_data): Move decl from here ...
7483 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7484 to check its interface.
7485 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7486
7487 * fontset.c (free_realized_fontset): Now static.
7488 (Fset_fontset_font): Rename local to avoid shadowing.
7489 (fontset_font): Mark local as initialized.
7490 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7491
7492 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7493
7494 * xselect.c (x_disown_buffer_selections): Remove; not used.
7495 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7496 (x_own_selection, Fx_disown_selection_internal): Rename locals
7497 to avoid shadowing.
7498 (x_handle_dnd_message): Remove local to avoid shadowing.
7499
7500 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7501 so that the caller can use some name other than gcpro1.
7502 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7503 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7504 (Fx_backspace_delete_keys_p):
7505 Use them to avoid shadowing, and rename vars to avoid shadowing.
7506 (x_decode_color, x_set_name, x_window): Now static.
7507 (Fx_create_frame): Add braces to silence GCC warning.
7508 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7509 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7510 Remove unused locals.
7511 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7512 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7513 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7514 macros.
7515
7516 * xterm.h (x_mouse_leave): New decl.
7517
7518 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7519 Remove unused functions.
7520 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7521 (x_calc_absolute_position): Now static.
7522 (XTread_socket): Don't define label "out" unless it's used.
7523 Don't declare local "event" unless it's used.
7524 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7525 unless they are used.
7526 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7527 (x_fatal_error_signal): Remove; not used.
7528 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7529 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7530 (x_error_catcher, x_connection_closed, x_error_handler):
7531 (x_error_quitter, xembed_send_message, x_iconify_frame):
7532 (my_log_handler): Rename locals to avoid shadowing.
7533 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7534 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7535
7536 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7537 Rename or move locals to avoid shadowing.
7538 (tty_defined_color, merge_face_heights): Now static.
7539 (free_realized_faces_for_fontset): Remove; not used.
7540 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7541 does not deduce is never used uninitialized.
7542 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7543 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7544
7545 * terminal.c (store_terminal_param): Now static.
7546
7547 * xmenu.c (menu_highlight_callback): Now static.
7548 (set_frame_menubar): Remove unused local.
7549 (xmenu_show): Rename parameter to avoid shadowing.
7550 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7551 since they might point to immutable storage.
7552 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7553 since it's unused otherwise.
7554
7555 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7556 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7557 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7558 avoids a gcc -Wuninitialized diagnostic.
7559 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7560 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7561 does not deduce are never used uninitialized.
7562
7563 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7564
7565 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7566 * window.c (window_loop, size_window):
7567 (run_window_configuration_change_hook, enlarge_window): Likewise.
7568
7569 * window.c (display_buffer): Now static.
7570 (size_window): Mark variables that gcc -Wuninitialized
7571 does not deduce are never used uninitialized.
7572 * window.h (check_all_windows): New decl, to forestall
7573 gcc -Wmissing-prototypes diagnostic.
7574 * dispextern.h (bidi_dump_cached_states): Likewise.
7575
7576 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7577 shadowing.
7578 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7579 Include <limits.h>.
7580 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7581 and to avoid gcc -Wuninitialized warning.
7582 (load_charset_map): Mark variables that gcc -Wuninitialized
7583 does not deduce are never used uninitialized.
7584 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7585
7586 * coding.c (coding_set_source, coding_set_destination):
7587 Use "else { /* comment */ }" rather than "else /* comment */;"
7588 for clarity, and to avoid gcc -Wempty-body warning.
7589 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7590 a block, when the outer 'i' will do.
7591 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7592 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7593 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7594 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7595 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7596 Rename locals to avoid shadowing.
7597 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7598 * coding.c (emacs_mule_char, encode_invocation_designation):
7599 Now static, since they're not used elsewhere.
7600 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7601 (decode_coding_object, encode_coding_object, detect_coding_system):
7602 (decode_coding_emacs_mule): Mark variables that gcc
7603 -Wuninitialized does not deduce are never used uninitialized.
7604 (detect_coding_iso_2022): Initialize a local variable that might
7605 be used uninitialized. Leave a FIXME because it's not clear that
7606 this initialization is needed. (Bug#8211)
7607 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7608 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7609 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7610 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7611 Remove unused macros.
7612
7613 * category.c (hash_get_category_set): Remove unused local var.
7614 (copy_category_table): Now static, since it's not used elsewhere.
7615 * character.c (string_count_byte8): Likewise.
7616
7617 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7618 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7619
7620 * chartab.c (copy_sub_char_table): Now static, since it's not used
7621 elsewhere.
7622 (sub_char_table_ref_and_range, char_table_ref_and_range):
7623 Rename locals to avoid shadowing.
7624 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7625
7626 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7627 (BIDI_BOB): Remove unused macro.
7628
7629 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7630 deduce are never used uninitialized.
7631 * term.c (encode_terminal_code): Likewise.
7632
7633 * term.c (encode_terminal_code): Now static. Remove unused local.
7634
7635 * tparam.h: New file.
7636 * term.c, tparam.h: Include it.
7637 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7638 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7639 Move these decls to tparam.h, and make them agree with what
7640 is actually in tparam.c. The previous trick of using incompatible
7641 decls in different modules does not conform to the C standard.
7642 All callers of tparam changed to use tparam's actual API.
7643 * tparam.c (tparam1, tparam, tgoto):
7644 Use const pointers where appropriate.
7645
7646 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7647 * cm.h (struct cm): Likewise.
7648 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7649 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7650 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7651 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7652 (turn_on_face, init_tty): Likewise.
7653 * termchar.h (struct tty_display_info): Likewise.
7654
7655 * term.c (term_mouse_position): Rename local to avoid shadowing.
7656
7657 * alloc.c (mark_ttys): Move decl from here ...
7658 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7659
7660 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7661
7662 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7663
7664 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7665
7666 * search.c (compile_pattern_1): Remove argument regp, unused since
7667 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7668 (compile_pattern): Don't pass it.
7669
7670 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7671
7672 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7673 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7674 for ! HAVE_GTK3.
7675 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7676
7677 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7678
7679 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7680 gdk_window_get_screen, gdk_window_get_geometry,
7681 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7682 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7683 (xg_get_pixbuf_from_pixmap): New function.
7684 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7685 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7686 Call xg_get_pixbuf_from_pixmap instead of
7687 gdk_pixbuf_get_from_drawable.
7688 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7689 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7690 (xg_check_special_colors): Use GtkStyleContext and its functions
7691 for HAVE_GTK3.
7692 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7693 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7694 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7695 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7696 Call gtk_widget_get_preferred_size.
7697 (xg_frame_resized): gdk_window_get_geometry only takes 5
7698 parameters.
7699 (xg_win_to_widget, xg_event_is_for_menubar):
7700 Call gdk_x11_window_lookup_for_display.
7701 (xg_set_widget_bg): New function.
7702 (delete_cb): New function.
7703 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7704 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7705 (xg_set_background_color): Call xg_set_widget_bg.
7706 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7707 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7708 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7709 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7710 if ! HAVE_GTK3.
7711 (update_frame_tool_bar): Call gtk_widget_hide.
7712 (xg_initialize): Use GDK_KEY_g.
7713
7714 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7715 if ! HAVE_GTK3
7716 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7717
7718 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7719 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7720 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7721
7722 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7723
7724 * w32xfns.c (select_palette): Check success of RealizePalette against
7725 GDI_ERROR, not zero.
7726
7727 See ChangeLog.11 for earlier changes.
7728
7729 ;; Local Variables:
7730 ;; coding: utf-8
7731 ;; End:
7732
7733 Copyright (C) 2011 Free Software Foundation, Inc.
7734
7735 This file is part of GNU Emacs.
7736
7737 GNU Emacs is free software: you can redistribute it and/or modify
7738 it under the terms of the GNU General Public License as published by
7739 the Free Software Foundation, either version 3 of the License, or
7740 (at your option) any later version.
7741
7742 GNU Emacs is distributed in the hope that it will be useful,
7743 but WITHOUT ANY WARRANTY; without even the implied warranty of
7744 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7745 GNU General Public License for more details.
7746
7747 You should have received a copy of the GNU General Public License
7748 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.