1 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3 * print.c (print_object): Print empty symbol as ##.
5 * lread.c (read1): Read ## as empty symbol.
7 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
9 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
10 setting frame foreground color (Bug#9175).
11 (x_set_background_color): Likewise.
13 * nsmenu.m (-setText): Size tooltip dimensions precisely to
15 (EmacsTooltip -init): Remove bezels and add shadows to
18 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
19 or scroll bar (Bug#8470).
21 * nsfont.m (nsfont_open): Remove assignment to voffset and
22 unnecessary vars hshink, expand, hd, full_height, min_height.
23 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
25 * nsterm.h (nsfont_info): Remove voffset field.
27 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
29 Implement strike-through and overline on NextStep (Bug#8863).
31 * nsfont.m (nsfont_open): Use underline position provided by font,
32 instead of hard-coded value of 2.
33 (nsfont_draw): Call ns_draw_text_decoration instead.
35 * nsterm.h: Add declaration for ns_draw_text_decoration.
37 * nsterm.m (ns_draw_text_decoration): New function for drawing
38 underline, overline, and strike-through.
39 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
40 ns_draw_text_decoration. Change treatment of cursor drawing to
41 accomodate underlining, etc.
43 2011-07-28 Eli Zaretskii <eliz@gnu.org>
45 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
48 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
50 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
51 Without this fix, if a signal arrives just after memory fills up,
52 'malloc' might be invoked reentrantly.
54 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
55 In other words, assume that every image size is allowed, on non-X
56 hosts. This assumption is probably wrong, but it lets Emacs compile.
58 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
60 * regex.c (re_iswctype): Convert return values to boolean.
62 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
64 * xdisp.c (compute_display_string_pos): Don't use cached display
65 string position if the buffer had its restriction changed.
68 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
70 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
72 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
74 Integer signedness and overflow and related fixes. (Bug#9079)
76 * bidi.c: Integer size and overflow fixes.
77 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
78 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
79 (bidi_cache_find_level_change, bidi_cache_ensure_space)
80 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
81 (bidi_find_other_level_edge):
82 Use ptrdiff_t instead of EMACS_INT where either will do.
83 This works better on 32-bit hosts configured --with-wide-int.
84 (bidi_cache_ensure_space): Check for size-calculation overflow.
85 Use % rather than repeated addition, for better worst-case speed.
86 Don't set bidi_cache_size until after xrealloc returns, because it
88 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
89 (bidi_cache_ensure_space): Also check that the bidi cache size
90 does not exceed that of the largest Lisp string or buffer. See Eli
91 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
93 * alloc.c (__malloc_size_t): Remove.
94 All uses replaced by size_t. See Andreas Schwab's note
95 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
97 * image.c: Improve checking for integer overflow.
98 (check_image_size): Assume that f is nonnull, since
99 it is always nonnull in practice. This is one less thing to
100 worry about when checking for integer overflow later.
101 (x_check_image_size): New function, which checks for integer
102 overflow issues inside X.
103 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
104 This removes the need for a memory_full check.
105 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
106 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
107 (xbm_read_bitmap_data): Change locals back to 'int', since
108 their values must fit in 'int'.
109 (xpm_load_image, png_load, tiff_load):
110 Invoke x_create_x_image_and_pixmap earlier,
111 to avoid much needless work if the image is too large.
112 (tiff_load): Treat overly large images as if
113 x_create_x_image_and_pixmap failed, not as malloc failures.
114 (gs_load): Use x_check_image_size.
116 * gtkutil.c: Omit integer casts.
117 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
118 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
120 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
122 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
123 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
124 would wrongly return t on a 64-bit host.
126 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
127 The plain *_OVERFLOW macros run afoul of GCC bug 49705
128 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
129 and therefore cause GCC to emit a bogus diagnostic in some cases.
131 * image.c: Integer signedness and overflow and related fixes.
132 This is not an exhaustive set of fixes, but it's time to
133 record what I've got.
134 (lookup_pixel_color, check_image_size): Remove redundant decls.
135 (check_image_size): Don't assume that arbitrary EMACS_INT values
136 fit in 'int', or that arbitrary 'double' values fit in 'int'.
137 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
138 (tiff_load, imagemagick_load_image):
139 Check for overflow in size calculations.
140 (x_create_x_image_and_pixmap): Remove unnecessary test for
141 xmalloc returning NULL; that can't happen.
142 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
143 (xpm_color_bucket): Use better integer hashing function.
144 (xpm_cache_color): Don't possibly over-allocate memory.
145 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
147 Use ptrdiff_t, not int or size_t, to record sizes.
148 (png_load): Don't assume values greater than 2**31 fit in 'int'.
149 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
150 either works, as we prefer signed integers.
151 (tiff_read_from_memory, tiff_write_from_memory):
152 Return tsize_t, not size_t, since that's what the TIFF API wants.
153 (tiff_read_from_memory): Don't fail simply because the read would
154 go past EOF; instead, return a short read.
155 (tiff_load): Omit no-longer-needed casts.
156 (Fimagemagick_types): Don't assume size fits into 'int'.
158 Improve hashing quality when configured --with-wide-int.
159 * fns.c (hash_string): New function, taken from sxhash_string.
160 Do not discard information about ASCII character case; this
161 discarding is no longer needed.
162 (sxhash-string): Use it. Change sig to match it. Caller changed.
163 * lisp.h: Declare it.
164 * lread.c (hash_string): Remove, since we now use fns.c's version.
165 The fns.c version returns a wider integer if --with-wide-int is
166 specified, so this should help the quality of the hashing a bit.
168 * emacs.c: Integer overflow minor fix.
169 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
170 Define only if GNU_LINUX.
171 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
173 * dispnew.c: Integer signedness and overflow fixes.
174 Remove unnecessary forward decls, that were a maintenance hassle.
175 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
177 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
178 (scrolling_window): Use ptrdiff_t, not int, for byte count.
179 (prepare_desired_row, line_draw_cost):
180 Use int, not unsigned, where either works.
181 (save_current_matrix, restore_current_matrix):
182 Use ptrdiff_t, not size_t, where either works.
183 (init_display): Check for overflow more accurately, and without
184 relying on undefined behavior.
186 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
187 Remove, replacing with the new symbols in lisp.h. All uses changed.
188 * fileio.c (make_temp_name):
189 * filelock.c (lock_file_1, lock_file):
190 * xdisp.c (message_dolog):
191 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
192 Use pMd etc. instead.
193 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
194 replacing the pWIDE etc. symbols removed from editfns.c.
196 * keyboard.h (num_input_events): Now uintmax_t.
197 This is (very slightly) less likely to mess up due to wraparound.
200 * buffer.c: Integer signedness fixes.
201 (alloc_buffer_text, enlarge_buffer_text):
202 Use ptrdiff_t rather than size_t when either will do, as we prefer
205 * alloc.c: Integer signedness and overflow fixes.
206 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
207 (__malloc_size_t): Default to size_t, not to int.
208 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
209 (Fgarbage_collect, mark_object_loop_halt, mark_object):
210 Prefer ptrdiff_t to size_t when either would do, as we prefer
212 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
213 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
214 Now const. Initialize with values that are in range even if char
216 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
217 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
218 These functions do the right thing with sizes > 2**32.
219 (check_depth): Now ptrdiff_t, not int.
220 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
221 Adjust to new way of storing sizes. Check for size overflow bugs
223 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
224 slightly wrong anyway, as it missed one instance of
225 XMALLOC_OVERRUN_CHECK_OVERHEAD.
226 (refill_memory_reserve): Omit needless cast to size_t.
227 (mark_object_loop_halt): Mark as externally visible.
229 * xselect.c: Integer signedness and overflow fixes.
230 (Fx_register_dnd_atom, x_handle_dnd_message):
231 Use ptrdiff_t, not size_t, since we prefer signed.
232 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
233 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
234 x_dnd_atoms_size and x_dnd_atoms_length.
236 * doprnt.c: Prefer signed to unsigned when either works.
240 * xdisp.c (vmessage):
241 Use ptrdiff_t, not size_t, when using or implementing doprnt,
242 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
243 prefer signed arithmetic to avoid comparison confusion.
244 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
247 Assume freestanding C89 headers, string.h, stdlib.h.
248 * data.c, doprnt.c, floatfns.c, print.c:
249 Include float.h unconditionally.
250 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
251 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
252 * regex.c: Likewise for stddef.h, string.h.
253 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
254 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
255 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
256 (STDC_HEADERS): Remove obsolete defines.
257 * sysdep.c: Include limits.h unconditionally.
259 Assume support for memcmp, memcpy, memmove, memset.
260 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
261 * regex.c (memcmp, memcpy):
262 Remove; we assume C89 now.
264 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
265 (__malloc_safe_bcopy): Remove; no longer needed.
267 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
268 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
269 well either way, and we prefer signed to unsigned.
271 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
273 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
274 closes the connection while we're reading (bug#9182).
276 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
278 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
279 are specified (Bug#9168).
281 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
283 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
284 Found by GCC static checking and --with-wide-int on a 32-bit host.
286 2011-07-25 Eli Zaretskii <eliz@gnu.org>
288 * xdisp.c (compute_display_string_pos): Fix logic of caching
289 previous display string position. Initialize cached_prev_pos to
290 -1. Fixes slow-down at the beginning of a buffer.
292 2011-07-24 Eli Zaretskii <eliz@gnu.org>
294 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
295 for attrs[LFACE_FONTSET_INDEX].
297 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
299 * xml.c (parse_region): Remove unused local
300 that was recently introduced.
302 2011-07-23 Eli Zaretskii <eliz@gnu.org>
304 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
305 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
307 * xdisp.c (move_it_in_display_line_to): Record the best matching
308 position for TO_CHARPOS while scanning the line, and restore it on
309 exit if none of the characters scanned was an exact match. Fixes
310 vertical-motion and pos-visible-in-window-p under bidi redisplay
311 when exact match is impossible due to invisible text, and the
314 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
316 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
319 2011-07-22 Eli Zaretskii <eliz@gnu.org>
321 Fix a significant slow-down of cursor motion with C-n, C-p,
322 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
323 auto-repeat under bidi redisplay in fontified buffers.
324 * xdisp.c (compute_stop_pos_backwards): New function.
325 (next_element_from_buffer): Call compute_stop_pos_backwards to
326 find a suitable prev_stop when we find ourselves before
328 (reseat): Don't look for prev_stop, as that could mean a very long
330 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
331 <cached_disp_overlay_modiff>: Cache for last found display string
333 (compute_display_string_pos): Return the cached position if asked
334 about the same buffer in the same area of character positions, and
335 the buffer wasn't changed since the time the display string
338 2011-07-22 Eli Zaretskii <eliz@gnu.org>
340 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
341 is an integer, which is important for empty lines. (Bug#9149)
343 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
345 * frame.c (Fmodify_frame_parameters): In tty case, update the
346 default face if necessary (Bug#4238).
348 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
350 * editfns.c (Fstring_to_char): No need to explain what a character
351 is in the docstring (Bug#6576).
353 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
355 * xml.c (parse_region): Make sure we always return a tree.
357 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
359 * xml.c (parse_region): If a document contains only comments,
362 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
364 * xml.c (make_dom): Return comments, too.
366 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
369 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
370 and the surrounding thread.
371 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
372 rather than fgets, and retry after EINTR. Otherwise, 'emacs
373 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
375 * s/openbsd.h (BROKEN_SIGIO): Define.
376 * unexelf.c (unexec) [__OpenBSD__]:
377 Don't update the .mdebug section of the Alpha COFF symbol table.
379 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
381 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
384 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
386 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
387 This fixes some race conditions on the permissions of any newly
390 * alloc.c (valid_pointer_p): Use pipe, not open.
391 This fixes some permissions issues when debugging.
393 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
394 If fchown fails to set both uid and gid, try to set just gid,
395 as that is sometimes allowed. Adjust the file's mode to eliminate
396 setuid or setgid bits that are inappropriate if fchown fails.
398 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
400 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
401 to compare Lisp_Objects.
402 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
403 global_gnutls_log_level, don't mistake it for a Lisp_Object.
404 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
406 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
408 * lread.c (read_integer): Unread even EOF character.
409 (read1): Likewise. Properly record start position of symbol.
411 * lread.c (read1): Read `#:' as empty uninterned symbol if no
412 symbol character follows.
414 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
416 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
417 This works around a problem with the previous change to Fcopy_file.
418 Recent glibc declares fchown with __attribute__((warn_unused_result)),
419 and without this change, GCC might complain about discarding
420 fchown's return value.
422 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
424 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
426 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
428 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
430 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
432 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
433 it's used from the C level.
435 * process.c: Use the same condition for POLL_FOR_INPUT in both
436 keyboard.c and process.c (bug#1858).
438 2011-07-09 Lawrence Mitchell <wence@gmx.li>
440 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
441 (Fgnutls_boot): Use it.
443 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
445 * doc.c (Fsubstitute_command_keys): Revert last change.
447 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
449 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
450 quotes the next character, and doesn't affect other longer
451 sequences (bug#8935).
453 * lread.c (syms_of_lread): Clarify that is isn't only
454 `eval-buffer' and `eval-defun' that's affected by
455 `lexical-binding' (bug#8460).
457 2011-07-15 Eli Zaretskii <eliz@gnu.org>
459 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
460 bidi redisplay when a line includes both an image and is
463 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
465 Fix minor problems found by static checking.
466 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
467 (elsz): Now a signed constant, not a size_t var. We prefer signed
468 types to unsigned, to avoid integer comparison confusion. Without
469 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
470 "cannot optimize loop, the loop counter may overflow", a symptom
472 * indent.c (Fvertical_motion): Mark locals as initialized.
473 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
475 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
477 * search.c (Fre_search_backward): Mention `case-fold-search' in
478 all the re_search_* functions (bug#8138).
480 * keyboard.c (Fopen_dribble_file): Document when the file is
483 2011-07-14 Eli Zaretskii <eliz@gnu.org>
485 * bidi.c (bidi_dump_cached_states): Fix format of displaying
488 Support bidi reordering of display and overlay strings.
489 * xdisp.c (compute_display_string_pos)
490 (compute_display_string_end): Accept additional argument STRING.
491 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
492 (reseat_to_string): Initialize bidi_it->string.s and
493 bidi_it->string.schars.
494 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
495 NULL (avoids a crash in bidi_paragraph_init). Initialize
497 (init_iterator): Call bidi_init_it only of a valid
498 buffer position was specified. Initialize paragraph_embedding to
500 (reseat_to_string): Initialize the bidi iterator.
501 (display_string): If we need to ignore text properties of
502 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
503 original value of -1 will not work with bidi.)
504 (compute_display_string_pos): First arg is now struct
505 `text_pos *'; all callers changed. Support display properties on
507 (compute_display_string_end): Support display properties on Lisp
509 (init_iterator, reseat_1, reseat_to_string): Initialize the
510 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
511 when iterating on a string not from display properties).
512 (compute_display_string_pos, compute_display_string_end): Fix
513 calculation of the object to scan. Fixes an error when using
515 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
516 base_level_stop; instead, set base_level_stop to BEGV. Fixes
517 crashes in vertical-motion.
518 (next_element_from_buffer): Improve commentary for when
519 the iterator is before prev_stop.
520 (init_iterator): Initialize bidi_p from the default value of
521 bidi-display-reordering, not from buffer-local value. Use the
522 buffer-local value only if initializing for buffer iteration.
523 (handle_invisible_prop): Support invisible properties on strings
524 that are being bidi-reordered.
525 (set_iterator_to_next): Support bidi reordering of C strings and
527 (next_element_from_string): Support bidi reordering of Lisp
529 (handle_stop_backwards): Support Lisp strings as well.
530 (display_string): Support display of R2L glyph rows. Use
531 IT_STRING_CHARPOS when displaying from a Lisp string.
532 (init_iterator): Don't initialize it->bidi_p for strings
534 (reseat_to_string): Initialize it->bidi_p for strings here.
535 (next_element_from_string, next_element_from_c_string)
536 (next_element_from_buffer): Add xassert's for correspondence
537 between IT's object being iterated and it->bidi_it.string
539 (face_before_or_after_it_pos): Support bidi iteration.
540 (next_element_from_c_string): Handle the case of the first string
541 character that is not the first one in the visual order.
542 (get_visually_first_element): New function, refactored from common
543 parts of next_element_from_buffer, next_element_from_string, and
544 next_element_from_c_string.
545 (tool_bar_lines_needed, redisplay_tool_bar)
546 (display_menu_bar): Force left-to-right direction. Add a FIXME
547 comment for making that be controlled by a user option.
548 (push_it, pop_it): Save and restore the state of the
549 bidi iterator. Save and restore the bidi_p flag.
550 (pop_it): Iterate out of display property for string iteration as
552 (iterate_out_of_display_property): Support iteration over strings.
553 (handle_single_display_spec): Set up it->bidi_it for iteration
554 over a display string, and call bidi_init_it.
555 (handle_single_display_spec, next_overlay_string)
556 (get_overlay_strings_1, push_display_prop): Set up the bidi
557 iterator for displaying display or overlay strings.
558 (forward_to_next_line_start): Don't use the shortcut if
560 (back_to_previous_visible_line_start): If handle_display_prop
561 pushed the iterator stack, restore the internal state of the bidi
562 iterator by calling bidi_pop_it same number of times.
563 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
564 and we are bidi-iterating, don't decrement the iterator position;
565 instead, set the first_elt flag in the bidi iterator, to produce
567 (reseat_1): Remove redundant setting of string_from_display_prop_p.
568 (push_display_prop): xassert that we are iterating a buffer.
569 (push_it, pop_it): Save and restore paragraph_embedding member.
570 (handle_single_display_spec, next_overlay_string)
571 (get_overlay_strings_1, reseat_1, reseat_to_string)
572 (push_display_prop): Set up the `unibyte' member of bidi_it.string
573 correctly. Don't assume unibyte strings are not bidi-reordered.
574 (compute_display_string_pos)
575 (compute_display_string_end): Fix handling the case of C string.
576 (push_it, pop_it): Save and restore from_disp_prop_p.
577 (handle_single_display_spec, push_display_prop): Set the
578 from_disp_prop_p flag.
579 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
580 (pop_it): Call iterate_out_of_display_property only if we are
581 popping after iteration over a string that came from a display
582 property. Fix a typo in popping stretch info. Add an assertion
583 for verifying that the iterator position is in sync with the bidi
585 (handle_single_display_spec, get_overlay_strings_1)
586 (push_display_prop): Fix initialization of paragraph direction for
587 string when that of the parent object is not yet determined.
588 (reseat_1): Call bidi_init_it to resync the bidi
589 iterator with IT's position. (Bug#7616)
590 (find_row_edges): If ROW->start.pos gives position
591 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
592 (handle_stop, back_to_previous_visible_line_start, reseat_1):
593 Reset the from_disp_prop_p flag.
594 (SAVE_IT, RESTORE_IT): New macros.
595 (pos_visible_p, face_before_or_after_it_pos)
596 (back_to_previous_visible_line_start)
597 (move_it_in_display_line_to, move_it_in_display_line)
598 (move_it_to, move_it_vertically_backward, move_it_by_lines)
599 (try_scrolling, redisplay_window, display_line): Use them when
600 saving a temporary copy of the iterator and restoring it back.
601 (back_to_previous_visible_line_start, reseat_1)
602 (init_iterator): Empty the bidi cache "stack".
603 (move_it_in_display_line_to): If iterator ended up at
604 EOL, but we never saw any buffer positions smaller than
605 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
606 motion in bidi-reordered lines.
607 (move_it_in_display_line_to): Record prev_method and prev_pos
608 immediately before the call to set_iterator_to_next. Fixes cursor
609 motion in bidi-reordered lines with stretch glyphs and strings
610 displayed in margins. (Bug#8133) (Bug#8867)
611 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
613 (pos_visible_p): Support positions in bidi-reordered lines. Save
614 and restore bidi cache.
616 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
617 (bidi_paragraph_info): Delete unused struct.
618 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
619 (bidi_cache_start): New variable.
620 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
622 (bidi_cache_fetch_state, bidi_cache_search)
623 (bidi_cache_find_level_change, bidi_cache_iterator_state)
624 (bidi_cache_find, bidi_peek_at_next_level)
625 (bidi_level_of_next_char, bidi_find_other_level_edge)
626 (bidi_move_to_visually_next): Compare cache index with
627 bidi_cache_start rather than with zero.
628 (bidi_fetch_char): Accept new argument STRING; all callers
629 changed. Support iteration over a string. Support strings with
630 display properties. Support unibyte strings. Fix the type of
631 `len' according to what STRING_CHAR_AND_LENGTH expects.
632 (bidi_paragraph_init, bidi_resolve_explicit_1)
633 (bidi_resolve_explicit, bidi_resolve_weak)
634 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
635 iteration over a string.
636 (bidi_set_sor_type, bidi_resolve_explicit_1)
637 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
638 can now be zero (for strings); special values 0 and -1 were
639 changed to -1 and -2, respectively.
640 (bidi_char_at_pos): New function.
641 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
642 Call it instead of FETCH_MULTIBYTE_CHAR.
643 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
644 initialized to valid values.
645 (bidi_init_it): Don't initialize charpos and bytepos with invalid
647 (bidi_level_of_next_char): Allow the sentinel "position" to pass
648 the test for valid cached positions. Fix the logic for looking up
649 the sentinel state in the cache. GCPRO the Lisp string we are
651 (bidi_push_it, bidi_pop_it): New functions.
652 (bidi_initialize): Initialize the bidi cache start stack pointer.
653 (bidi_cache_ensure_space): New function, refactored from part of
654 bidi_cache_iterator_state. Don't assume the required size is just
655 one BIDI_CACHE_CHUNK away.
656 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
657 (bidi_count_bytes, bidi_char_at_pos): New functions.
658 (bidi_cache_search): Don't assume bidi_cache_last_idx is
659 always valid if bidi_cache_idx is valid.
660 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
661 is valid if it's going to be used.
662 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
663 (bidi_cache_fetch_state, bidi_cache_search)
664 (bidi_cache_find_level_change, bidi_cache_ensure_space)
665 (bidi_cache_iterator_state, bidi_cache_find)
666 (bidi_find_other_level_edge, bidi_cache_start_stack): All
667 variables related to cache indices are now EMACS_INT.
669 * dispextern.h (struct bidi_string_data): New structure.
670 (struct bidi_it): New member `string'. Make flag members be 1-bit
671 fields, and put them last in the struct.
672 (compute_display_string_pos, compute_display_string_end): Update
674 (bidi_push_it, bidi_pop_it): Add prototypes.
675 (struct iterator_stack_entry): New members bidi_p,
676 paragraph_embedding, and from_disp_prop_p.
677 (struct it): Member bidi_p is now a bit field 1 bit wide.
678 (bidi_shelve_cache, bidi_unshelve_cache): Declare
681 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
682 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
683 and vector-like objects.
685 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
686 cache around display iteration.
688 * window.c (Fwindow_end, window_scroll_pixel_based)
689 (displayed_window_lines, Frecenter): Save and restore the bidi
690 cache around display iteration.
692 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
694 * editfns.c (Fdelete_region): Clarify the use of the named
695 parameters (bug#6788).
697 2011-07-14 Martin Rudalics <rudalics@gmx.at>
699 * indent.c (Fvertical_motion): Set and restore w->pointm when
700 saving and restoring the window's buffer (Bug#9006).
702 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
704 * editfns.c (Fstring_to_char): Clarify just what is returned
705 (bug#6576). Text by Eli Zaretskii.
707 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
709 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
711 2011-07-13 Eli Zaretskii <eliz@gnu.org>
713 * buffer.c (mmap_find): Fix a typo.
715 2011-07-13 Johan Bockgård <bojohan@gnu.org>
717 Fix execution of x selection hooks.
718 * xselect.c (Qx_lost_selection_functions)
719 (Qx_sent_selection_functions): New vars.
720 (syms_of_xselect): DEFSYM them.
721 (x_handle_selection_request): Pass Qx_sent_selection_functions
722 rather than Vx_sent_selection_functions to Frun_hook_with_args.
723 (x_handle_selection_clear,x_clear_frame_selections):
724 Pass Qx_lost_selection_functions rather than
725 Vx_lost_selection_functions to Frun_hook_with_args.
727 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
729 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
730 The old code sometimes used this field without initializing it.
732 * alloc.c (gc_sweep): Don't read past end of array.
733 In theory, the old code could also have corrupted Emacs internals,
734 though it'd be very unlikely.
736 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
738 * character.c (Fcharacterp): Don't advertise optional ignored
741 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
743 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
746 * window.c (Fset_window_start): Doc fix (bug#4199).
747 (Fset_window_hscroll): Ditto.
749 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
751 Fix minor new problems caught by GCC 4.6.1.
752 * term.c (init_tty): Remove unused local.
753 * xsettings.c (store_monospaced_changed): Define this function only
754 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
757 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
759 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
761 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
763 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
764 are the mini-buffer and the echo area (bug#3320).
766 * term.c (init_tty): Remove support for supdup, c10 and perq
767 terminals, which are no longer supported (bug#1482).
769 2011-07-10 Johan Bockgård <bojohan@gnu.org>
771 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
773 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
775 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
776 for non-popups (Bug#3642).
778 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
780 * alloc.c (reset_malloc_hooks): Protoize.
781 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
782 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
783 * cm.c (losecursor): Likewise.
784 * data.c (fmod): Likewise.
785 * dispnew.c (swap_glyphs_in_rows): Likewise.
786 * emacs.c (memory_warning_signal): Likewise.
787 * floatfns.c (float_error): Likewise.
788 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
789 (otf_open, font_otf_capability, generate_otf_features)
790 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
792 * image.c (pbm_read_file): Likewise.
793 * indent.c (string_display_width): Likewise.
794 * intervals.c (check_for_interval, search_for_interval)
795 (inc_interval_count, count_intervals, root_interval)
796 (adjust_intervals_for_insertion, make_new_interval): Likewise.
797 * lread.c (defalias): Likewise.
798 * ralloc.c (r_alloc_check): Likewise.
799 * regex.c (set_image_of_range_1, set_image_of_range)
800 (regex_grow_registers): Likewise.
801 * sysdep.c (strerror): Likewise.
802 * termcap.c (valid_filename_p, tprint, main): Likewise.
803 * tparam.c (main): Likewise.
804 * unexhp9k800.c (run_time_remap, save_data_space)
805 (update_file_ptrs, read_header, write_header, calculate_checksum)
806 (copy_file, copy_rest, display_header): Likewise.
807 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
809 * xdisp.c (check_it): Likewise.
810 * xfaces.c (register_color, unregister_color, unregister_colors):
812 * xfns.c (print_fontset_result): Likewise.
813 * xrdb.c (member, fatal, main): Likewise.
815 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
817 Fix minor problems found by static checking (Bug#9031).
818 * chartab.c (char_table_set_range, map_sub_char_table):
819 Remove unused locals.
820 (uniprop_table): Now static.
821 * composite.c (_work_char): Remove unused static var.
823 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
825 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
827 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
829 * gtkutil.c (qttip_cb): Remove code without function.
831 2011-07-09 Eli Zaretskii <eliz@gnu.org>
833 * w32.c (pthread_sigmask): New stub.
835 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
837 Use pthread_sigmask, not sigprocmask (Bug#9010).
838 sigprocmask is portable only for single-threaded applications, and
839 Emacs can be multi-threaded when it uses GTK.
840 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
842 * callproc.c (Fcall_process):
843 * process.c (create_process):
844 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
845 Use pthread_sigmask, not sigprocmask.
847 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
849 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
850 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
853 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
855 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
856 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
857 (xg_hide_tooltip): Fix comment.
859 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
860 in registerServicesMenuSendTypes.
861 (validRequestorForSendType): Don't check ns_return_types.
863 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
866 2011-07-08 Jason Rumney <jasonr@gnu.org>
868 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
869 frame struct members of non-existent frames (Bug#6284).
871 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
873 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
874 variable firstTime not needed on OSX >= 10.6.
875 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
876 >= 10.5. Use setKnobProportion, setDoubleValue.
878 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
879 (MAC_OS_X_VERSION_10_5): Define if not defined.
880 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
881 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
882 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
884 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
885 cString and lossyCString on OSX >= 10.4
887 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
888 sizeToFit on OSX >= 10.2.
890 * nsimage.m (allocInitFromFile): Don't use deprecated method
891 bestRepresentationForDevice on OSX >= 10.6.
893 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
896 * emacs.c: Declare unexec_init_emacs_zone.
898 * nsgui.h: Fix compiler warning about gnulib redefining verify.
900 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
902 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
903 on svcsMenu (Bug#8842).
905 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
907 (Fns_list_services): Just return Qnil on 10.6, code not working there.
909 * nsterm.m (QUTF8_STRING): Declare.
910 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
911 (validRequestorForSendType): Return type is (id).
912 Change indexOfObjectIdenticalTo to indexOfObject.
913 Check if we have local selection before returning self (Bug#8842).
914 (writeSelectionToPasteboard): Put local selection into paste board
915 if we have a local selection (Bug#8842).
916 (syms_of_nsterm): DEFSYM QUTF8_STRING.
918 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
919 (ns_get_local_selection): Declare.
921 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
923 * keymap.c (describe_map_tree): Don't insert a double newline at
924 the end of the buffer (bug#1169) and return whether we inserted
927 * callint.c (Fcall_interactively): Change "reading args" to
928 "providing args" to try to clarify what it does (bug#1010).
930 2011-07-07 Kenichi Handa <handa@m17n.org>
932 * composite.c (composition_compute_stop_pos): Ignore a static
933 composition starting before CHARPOS (Bug#8915).
935 * xdisp.c (handle_composition_prop): Likewise.
937 2011-07-07 Eli Zaretskii <eliz@gnu.org>
939 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
942 2011-07-07 Kenichi Handa <handa@m17n.org>
944 * character.h (unicode_category_t): New enum type.
946 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
947 (Qchar_code_property_table): New variable.
948 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
949 (UNIPROP_COMPRESSED_FORM_P): New macros.
950 (char_table_ascii): Uncompress the compressed values.
951 (sub_char_table_ref): New arg is_uniprop. Callers changed.
952 Uncompress the compressed values.
953 (sub_char_table_ref_and_range): Likewise.
954 (char_table_ref_and_range): Uncompress the compressed values.
955 (sub_char_table_set): New arg is_uniprop. Callers changed.
956 Uncompress the compressed values.
957 (sub_char_table_set_range): Args changed. Callers changed.
958 (char_table_set_range): Adjuted for the above change.
959 (map_sub_char_table): Delete args default_val and parent. Add arg
960 top. Give decoded values to a Lisp function.
961 (map_char_table): Adjusted for the above change. Give decoded
962 values to a Lisp function. Gcpro more variables.
963 (uniprop_table_uncompress)
964 (uniprop_decode_value_run_length): New functions.
965 (uniprop_decoder, uniprop_decoder_count): New variables.
966 (uniprop_get_decoder, uniprop_encode_value_character)
967 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
969 (uniprop_encoder, uniprop_encoder_count): New variables.
970 (uniprop_get_encoder, uniprop_table)
971 (Funicode_property_table_internal, Fget_unicode_property_internal)
972 (Fput_unicode_property_internal): New functions.
973 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
974 Sunicode_property_table_internal, Sget_unicode_property_internal,
975 and Sput_unicode_property_internal. Defvar_lisp
976 char-code-property-alist.
978 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
979 Vunicode_category_table.
981 * font.c (font_range): Adjusted for the change of
982 Vunicode_category_table.
984 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
986 * m/iris4d.h: Remove file, move contents ...
987 * s/irix6-5.h: ... here.
989 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
991 Remove unportable assumption about struct layout (Bug#8884).
992 * alloc.c (mark_buffer):
993 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
994 (clone_per_buffer_values): Don't assume that
995 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
996 This isn't true in general, and it's particularly not true
997 if Emacs is configured with --with-wide-int.
998 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
999 New macros, used in the buffer.c change.
1001 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1003 * xsettings.c: Use both GConf and GSettings if both are available.
1004 (store_config_changed_event): Add comment.
1005 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1006 (store_tool_bar_style_changed): New functions.
1007 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1008 (struct xsettings): Move font inside HAVE_XFT.
1009 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1010 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1011 Move inside HAVE_XFT.
1012 (something_changed_gsettingsCB): Renamed from something_changedCB.
1013 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1015 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1016 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1017 (something_changed_gconfCB): Renamed from something_changedCB.
1018 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1019 (parse_settings): Move check for font inside HAVE_XFT.
1020 (read_settings, apply_xft_settings): Add comment.
1021 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1022 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1023 call store_font_name_changed.
1024 (xft_settings_event): Add comment.
1025 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1026 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1027 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1028 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1029 (xsettings_initialize): Call init_gsettings last.
1030 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1033 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1035 Random fixes. E.g., (random) never returned negative values.
1036 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1037 subseconds part to the entropy, as that's a bit more random.
1038 Prefer signed to unsigned, since the signedness doesn't matter and
1039 in general we prefer signed. When given a limit, use a
1040 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1041 latter isn't right if USE_2_TAGS_FOR_INTS.
1042 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1043 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1045 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1047 * textprop.c (text_property_stickiness):
1048 Obey Vtext_property_default_nonsticky.
1049 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1050 * w32fns.c (syms_of_w32fns):
1051 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1053 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1055 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1056 This is more efficient than Ffile_directory_p and avoids a minor race.
1058 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1060 * buffer.c (Foverlay_put): Say what the return value is
1063 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1064 is a directory before asking whether to use the file name
1066 (barf_or_query_if_file_exists): Make the "File is a directory"
1067 error be more correct.
1069 * fns.c (Frequire): Remove the mention of the .gz files, since
1070 that's installation-specific, but keep the mention of
1071 `get-load-suffixes'.
1073 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1075 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1076 Report string overflow if the output is too long.
1078 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1080 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1081 (syms_of_gnutls): Remove duplicate DEFSYM for
1082 Qgnutls_bootprop_verify_hostname_error, an error for
1083 Qgnutls_bootprop_verify_error (which is no longer used).
1085 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1086 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1087 Also (re)move comments that are misplaced or no longer relevant.
1089 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1091 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1093 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1095 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1096 and background color parameters if they have been changed.
1098 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1100 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1102 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1104 * xsettings.c (SYSTEM_FONT): Define only when used.
1105 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1107 * keymap.c (access_keymap_1): Now static.
1109 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1111 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1112 leave any prefix arg for the up event (Bug#1586).
1114 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1116 * lread.c (syms_of_lread): Mention single symbols defined by
1117 `defvar' or `defconst' (bug#7154).
1119 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1120 (Frequire): Mention get-load-suffixes.
1122 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1124 * window.h (window): Remove clone_number slot.
1125 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1127 (make_parent_window, make_window, saved_window)
1128 (Fset_window_configuration, save_window_save): Don't deal with
1130 * buffer.c (Qclone_number): Remove declaration.
1131 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1133 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1135 Add multiple inheritance to keymaps.
1136 * keymap.c (Fmake_composed_keymap): New function.
1137 (Fset_keymap_parent): Simplify.
1138 (fix_submap_inheritance): Remove.
1139 (access_keymap_1): New function extracted from access_keymap to handle
1140 embedded parents and handle lists of maps.
1141 (access_keymap): Use it.
1142 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1143 (Fcopy_keymap): Handle embedded parents.
1144 (Fcommand_remapping, define_as_prefix): Simplify.
1145 (Fkey_binding): Simplify.
1146 (syms_of_keymap): Move minibuffer-local-completion-map,
1147 minibuffer-local-filename-completion-map,
1148 minibuffer-local-must-match-map, and
1149 minibuffer-local-filename-must-match-map to Elisp.
1150 (syms_of_keymap): Defsubr make-composed-keymap.
1151 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1152 (parse_menu_item): Trivial simplification.
1154 2011-07-01 Glenn Morris <rgm@gnu.org>
1156 * Makefile.in (SETTINGS_LIBS): Fix typo.
1158 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1160 * coding.c (Fencode_coding_string): Record the last coding system
1161 used, as the function doc string says (bug#8738).
1163 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1165 * xsettings.c (store_monospaced_changed): Take new font as arg and
1166 check for change against current_mono_font.
1167 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1168 (emacs_settings_constructor, emacs_settings_get_property)
1169 (emacs_settings_set_property, emacs_settings_class_init)
1170 (emacs_settings_init, gsettings_obj): Remove.
1171 (something_changedCB): New function for HAVE_GSETTINGS.
1172 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1173 with value as argument.
1174 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1175 g_settings_new (Bug#8967). Do not create gsettings_obj.
1176 Remove calls to g_settings_bind. Connect something_changedCB to
1179 * xgselect.c: Add defined (HAVE_GSETTINGS).
1180 (xgselect_initialize): Ditto.
1182 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1183 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1186 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1188 * eval.c (struct backtrace): Simplify and port the data structure.
1189 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1190 signed bit field, as this assumption is not portable and it makes
1191 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1192 "char debug_on_exit : 1" as this is not portable either; instead,
1193 use the portable "unsigned int debug_on_exit : 1". Remove unused
1194 member evalargs. Remove obsolete comments about cc bombing out.
1196 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1198 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1199 Let HAVE_GSETTINGS override HAVE_GCONF.
1200 (store_monospaced_changed): New function.
1201 (EMACS_SETTINGS): A new type derived from GObject to handle
1202 GSettings notifications.
1203 (emacs_settings_constructor, emacs_settings_get_property)
1204 (emacs_settings_set_property, emacs_settings_class_init):
1206 (gsettings_client, gsettings_obj): New variables.
1207 (GSETTINGS_SCHEMA): New define.
1208 (something_changedCB): Call store_monospaced_changed.
1209 (init_gsettings): New function.
1210 (xsettings_initialize): Call init_gsettings.
1211 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1214 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1217 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1219 * window.c (resize_root_window, grow_mini_window)
1220 (shrink_mini_window): Rename Qresize_root_window to
1221 Qwindow_resize_root_window and Qresize_root_window_vertically to
1222 Qwindow_resize_root_window_vertically.
1224 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1226 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1228 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1230 * makefile.w32-in: Redesign dependencies so they reflect more
1231 clearly which files are directly included by each source file,
1232 and not through other includes.
1234 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1236 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1237 (sort_overlays, overlay_strings): When an overlay's clone number
1238 matches the window's clone number process the overlay even if
1239 the overlay's window property doesn't match the current window.
1241 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1242 (Fwindow_hchild): Rename to Fwindow_left_child.
1243 (Fwindow_next): Rename to Fwindow_next_sibling.
1244 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1245 (resize_window_check): Rename to window_resize_check.
1246 (resize_window_apply): Rename to window_resize_apply.
1247 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1248 (Fdelete_other_windows_internal, resize_frame_windows)
1249 (Fsplit_window_internal, Fdelete_window_internal)
1250 (grow_mini_window, shrink_mini_window)
1251 (Fresize_mini_window_internal): Fix callers accordingly.
1253 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1255 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1256 (emacs_fixed_set_min_size): Remove.
1257 (emacs_fixed_new): Take frame as argument.
1259 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1260 (_EmacsFixedPrivate): Remove minwidth/height.
1261 Add struct frame *f.
1262 (emacs_fixed_init): Initialize priv->f.
1263 (get_parent_class, emacs_fixed_set_min_size): Remove.
1264 (emacs_fixed_new): Set priv->f to argument.
1265 (emacs_fixed_get_preferred_width)
1266 (emacs_fixed_get_preferred_height): Use min_width/height from
1267 frames size_hint to set minimum and natural (Bug#8919).
1268 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1269 and use min_width/height from frames size_hint to set
1270 min_width/height (Bug#8919).
1272 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1273 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1276 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1278 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1279 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1282 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1284 * process.c (wait_reading_process_output): Bypass select if
1285 waiting for a cell while ignoring keyboard input, and input is
1286 pending. Suggested by Jan Djärv (Bug#8869).
1288 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1290 Use gnulib's dup2 module instead of rolling our own.
1291 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1293 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1295 * dispnew.c (scrolling_window): Before scrolling, turn off a
1296 mouse-highlight in the window being scrolled.
1298 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1300 Move DEFSYM to lisp.h and use everywhere.
1302 * character.h (DEFSYM): Move declaration...
1303 * lisp.h (DEFSYM): ...here.
1309 * w32select.c: Don't include character.h.
1311 * alloc.c (syms_of_alloc):
1312 * buffer.c (syms_of_buffer):
1313 * bytecode.c (syms_of_bytecode):
1314 * callint.c (syms_of_callint):
1315 * casefiddle.c (syms_of_casefiddle):
1316 * casetab.c (init_casetab_once):
1317 * category.c (init_category_once, syms_of_category):
1318 * ccl.c (syms_of_ccl):
1319 * cmds.c (syms_of_cmds):
1320 * composite.c (syms_of_composite):
1321 * dbusbind.c (syms_of_dbusbind):
1322 * dired.c (syms_of_dired):
1323 * dispnew.c (syms_of_display):
1324 * doc.c (syms_of_doc):
1325 * editfns.c (syms_of_editfns):
1326 * emacs.c (syms_of_emacs):
1327 * eval.c (syms_of_eval):
1328 * fileio.c (syms_of_fileio):
1329 * fns.c (syms_of_fns):
1330 * frame.c (syms_of_frame):
1331 * fringe.c (syms_of_fringe):
1332 * insdel.c (syms_of_insdel):
1333 * keymap.c (syms_of_keymap):
1334 * lread.c (init_obarray, syms_of_lread):
1335 * macros.c (syms_of_macros):
1336 * msdos.c (syms_of_msdos):
1337 * print.c (syms_of_print):
1338 * process.c (syms_of_process):
1339 * search.c (syms_of_search):
1340 * sound.c (syms_of_sound):
1341 * syntax.c (init_syntax_once, syms_of_syntax):
1342 * terminal.c (syms_of_terminal):
1343 * textprop.c (syms_of_textprop):
1344 * undo.c (syms_of_undo):
1345 * w32.c (globals_of_w32):
1346 * window.c (syms_of_window):
1347 * xdisp.c (syms_of_xdisp):
1348 * xfaces.c (syms_of_xfaces):
1349 * xfns.c (syms_of_xfns):
1350 * xmenu.c (syms_of_xmenu):
1351 * xsettings.c (syms_of_xsettings):
1352 * xterm.c (syms_of_xterm): Use DEFSYM.
1354 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1356 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1358 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1360 Integer and buffer overflow fixes (Bug#8873).
1362 * print.c (printchar, strout): Check for string overflow.
1363 (PRINTPREPARE, printchar, strout):
1364 Don't set size unless allocation succeeds.
1366 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1367 for sizes. Check for string overflow more accurately.
1368 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1370 * macros.c: Integer and buffer overflow fixes.
1371 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1372 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1373 Use ptrdiff_t, not int, for sizes.
1374 Don't increment bufsize until after realloc succeeds.
1375 Check for size-calculation overflow.
1376 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1378 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1380 * lread.c: Integer overflow fixes.
1381 (read_integer): Radix is now EMACS_INT, not int,
1382 to improve quality of diagnostics for out-of-range radices.
1383 Calculate buffer size correctly for out-of-range radices.
1384 (read1): Check for integer overflow in radices, and in
1385 read-circle numbers.
1386 (read_escape): Avoid int overflow.
1387 (Fload, openp, read_buffer_size, read1)
1388 (substitute_object_recurse, read_vector, read_list, map_obarray):
1389 Use ptrdiff_t, not int, for sizes.
1390 (read1): Use EMACS_INT, not int, for sizes.
1391 Check for size overflow.
1393 * image.c (cache_image): Check for size arithmetic overflow.
1395 * lread.c: Integer overflow issues.
1396 (saved_doc_string_size, saved_doc_string_length)
1397 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1398 Now ptrdiff_t, not int.
1399 (read1): Don't assume doc string length fits in int. Check for
1400 out-of-range doc string lengths.
1401 (read_list): Don't assume file position fits in int.
1402 (read_escape): Check for hex character overflow.
1404 2011-06-22 Leo Liu <sdl.web@gmail.com>
1406 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1407 Move to minibuffer.el.
1409 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1411 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1412 The following patches are for when GLYPH_DEBUG && !XASSERT.
1413 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1414 * dispnew.c (flush_stdout):
1415 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1416 Mark as externally visible.
1417 * dispnew.c (check_window_matrix_pointers): Now static.
1418 * dispnew.c (window_to_frame_vpos):
1419 * xfns.c (unwind_create_frame):
1420 * xterm.c (x_check_font): Remove unused local.
1421 * scroll.c (CHECK_BOUNDS):
1422 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1423 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1424 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1425 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1426 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1428 (debug_method_add): Use va_list and vsprintf rather than relying
1429 on undefined behavior with wrong number of arguments.
1430 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1431 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1432 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1433 since we're not interested in debugging glyphs with old libraries.
1434 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1435 GCC 4.6.0's static checking.
1437 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1439 Integer overflow and signedness fixes (Bug#8873).
1440 A few related buffer overrun fixes, too.
1442 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1444 * dispextern.h (struct face.stipple):
1445 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1446 (x_bitmap_mask, x_allocate_bitmap_record)
1447 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1448 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1449 (x_create_bitmap_from_xpm_data):
1450 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1451 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1453 * xfaces.c (load_pixmap):
1454 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1455 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1456 (.bitmaps_last, struct x_output.icon_bitmap):
1457 Use ptrdiff_t, not int, for bitmap indexes.
1458 (x_allocate_bitmap_record): Check for size overflow.
1459 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1461 Use ptrdiff_t, not int, for overlay counts.
1462 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1463 * editfns.c (overlays_around, get_pos_property):
1464 * textprop.c (get_char_property_and_overlay):
1465 * xdisp.c (next_overlay_change, note_mouse_highlight):
1466 * xfaces.c (face_at_buffer_position):
1467 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1468 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1469 (Fnext_overlay_change, Fprevious_overlay_change)
1470 (mouse_face_overlay_overlaps, Foverlays_in):
1471 Use ptrdiff_t, not int, for sizes.
1472 (overlays_at, overlays_in): Check for size-calculation overflow.
1474 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1476 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1477 (x_session_initialize): Do not assume string length fits in int.
1479 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1480 This is unlikely, but can occur if DPI is outlandish.
1482 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1483 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1485 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1486 * xrdb.c (magic_file_p, search_magic_path):
1487 Omit last arg SUFFIX; it was always 0. All callers changed.
1488 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1490 * xfont.c (xfont_match): Avoid need for strlen.
1492 * xfns.c: Don't assume strlen fits in int.
1493 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1495 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1496 not unsigned long, as we prefer signed integers. All callers changed.
1497 Detect integer overflow in repeat count.
1498 (message_dolog): Don't assume print length fits in 39 bytes.
1499 (display_mode_element): Don't assume strlen fits in int.
1501 * termcap.c: Don't assume sizes fit in int and never overflow.
1502 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1503 (gobble_line): Check for size-calculation overflow.
1505 * minibuf.c (Fread_buffer):
1506 * lread.c (intern, intern_c_string):
1507 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1508 Don't assume string length fits in int.
1510 * keyboard.c (parse_tool_bar_item):
1511 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1513 * font.c: Don't assume string length fits in int.
1514 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1515 Use ptrdiff_t, not int.
1516 (font_intern_prop): Don't assume string length fits in int.
1517 Don't assume integer property fits in fixnum.
1518 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1520 * filelock.c: Fix some buffer overrun and integer overflow issues.
1521 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1522 Reformulate so as not to need the command string.
1523 Invoke gzip -cd rather than gunzip, as it's more portable.
1524 (lock_info_type, lock_file_1, lock_file):
1525 Don't assume pid_t and time_t fit in unsigned long.
1526 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1527 (current_lock_owner): Prefer signed type for sizes.
1528 Use memcpy, not strncpy, where memcpy is what is really wanted.
1529 Don't assume (via atoi) that time_t and pid_t fit in int.
1530 Check for time_t and/or pid_t out of range, e.g., via a network share.
1531 Don't alloca where an auto var works fine.
1533 * fileio.c: Fix some integer overflow issues.
1534 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1535 Don't assume string length fits in int.
1536 (directory_file_name): Don't assume string length fits in long.
1537 (make_temp_name): Don't assume pid fits in int, or that its print
1538 length is less than 20.
1540 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1542 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1544 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1546 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1547 We prefer signed integers, even for size calculations.
1549 * emacs.c: Don't assume string length fits in 'int'.
1550 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1551 (main): Don't invoke strlen when not needed.
1553 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1554 (XD_DEBUG_MESSAGE): Don't waste a byte.
1556 * callproc.c (getenv_internal_1, getenv_internal)
1558 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1560 * lread.c (invalid_syntax): Omit length argument.
1561 All uses changed. This doesn't fix a bug, but it simplifies the
1562 code away from its former Hollerith-constant appearance, and it's
1563 one less 'int' to worry about when looking at integer-overflow issues.
1564 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1566 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1567 This didn't break anything, but it didn't help either.
1568 It's confusing to put a bogus integer in a place where the actual
1569 value does not matter.
1570 (LIST_END_P): Remove unused macro and its bogus comment.
1571 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1573 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1574 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1576 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1577 We prefer signed types, and the value cannot exceed the EMACS_INT
1578 range anyway (because otherwise the length would not be representable).
1579 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1580 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1581 This avoids a GCC warning when WIDE_EMACS_INT.
1583 * indent.c (sane_tab_width): New function.
1584 (current_column, scan_for_column, Findent_to, position_indentation)
1585 (compute_motion): Use it. This is just for clarity.
1586 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1588 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1590 * lisp.h (lint_assume): New macro.
1591 * composite.c (composition_gstring_put_cache):
1592 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1594 * editfns.c, insdel.c:
1595 Omit unnecessary forward decls, to simplify future changes.
1597 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1599 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1601 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1602 Use much-faster test for byte-length change.
1603 Don't assume string byte-length fits in 'int'.
1604 Check that character arg fits in 'int'.
1605 (mapcar1): Declare byte as byte, for clarity.
1607 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1609 * fns.c (concat): Catch string overflow earlier.
1610 Do not rely on integer wraparound.
1612 * dispextern.h (struct it.overlay_strings_charpos)
1613 (struct it.selective): Now EMACS_INT, not int.
1614 * xdisp.c (forward_to_next_line_start)
1615 (back_to_previous_visible_line_start)
1616 (reseat_at_next_visible_line_start, next_element_from_buffer):
1617 Don't arbitrarily truncate the value of 'selective' to int.
1619 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1621 * composite.c: Don't truncate sizes to 'int'.
1622 (composition_gstring_p, composition_reseat_it)
1623 (composition_adjust_point): Use EMACS_INT, not int.
1624 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1625 not EMACS_UINT, for indexes.
1627 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1629 * buffer.c: Include <verify.h>.
1630 (struct sortvec.priority, struct sortstr.priority):
1631 Now EMACS_INT, not int.
1632 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1633 (struct sortstr.size, record_overlay_string)
1634 (struct sortstrlist.size, struct sortlist.used):
1635 Don't truncate size to int.
1636 (record_overlay_string): Check for size-calculation overflow.
1637 (init_buffer_once): Check at compile-time, not run-time.
1639 2011-06-22 Jim Meyering <meyering@redhat.com>
1641 Don't leak an XBM-image-sized buffer
1642 * image.c (xbm_load): Free the image buffer after using it.
1644 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1647 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1648 that Sun C diagnosed.
1649 * fns.c (secure_hash): Fix pointer signedness issue.
1650 * intervals.c (static_offset_intervals): New function.
1651 (offset_intervals): Use it.
1653 2011-06-21 Leo Liu <sdl.web@gmail.com>
1656 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1659 * fns.c (secure_hash): Rename from crypto_hash_function and change
1660 the first arg to accept symbols.
1661 (Fsecure_hash): New primitive.
1662 (syms_of_fns): New symbols.
1664 2011-06-20 Deniz Dogan <deniz@dogan.se>
1666 * process.c (Fset_process_buffer): Clarify return value in
1669 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1671 * dispnew.c (add_window_display_history): Use BVAR.
1673 * xdisp.c (debug_method_add): Use BVAR.
1674 (check_window_end, dump_glyph_matrix, dump_glyph)
1675 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1677 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1680 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1681 check till after the cache is created in init_frame_faces.
1683 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1685 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1687 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1689 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1690 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1691 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1693 Improve buffer-overflow checking (Bug#8873).
1694 * fileio.c (Finsert_file_contents):
1695 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1696 Remove the old (too-loose) buffer overflow checks.
1697 They weren't needed, since make_gap checks for buffer overflow.
1698 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1699 The old code merely checked for Emacs fixnum overflow, and relied
1700 on undefined (wraparound) behavior. The new code avoids undefined
1701 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1703 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1704 Tune. Don't use wider integers than needed. Don't use alloca.
1705 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1707 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1709 * insdel.c, lisp.h (buffer_overflow): New function.
1710 (insert_from_buffer_1, replace_range, replace_range_2):
1711 * insdel.c (make_gap_larger):
1712 * editfns.c (Finsert_char):
1713 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1715 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1717 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1719 Integer overflow and signedness fixes (Bug#8873).
1721 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1722 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1724 * fileio.c: Don't assume EMACS_INT fits in off_t.
1725 (emacs_lseek): New static function.
1726 (Finsert_file_contents, Fwrite_region): Use it.
1727 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1729 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1731 * fns.c: Don't overflow int when computing a list length.
1732 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1733 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1734 truncation on 64-bit hosts. Check for QUIT every
1735 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1736 faster and is responsive enough.
1737 (Flength): Report an error instead of overflowing an integer.
1738 (Fsafe_length): Return a float if the value is not representable
1739 as a fixnum. This shouldn't happen except in contrived situations.
1740 (Fnthcdr, Fsort): Don't assume list length fits in int.
1741 (Fcopy_sequence): Don't assume vector length fits in int.
1743 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1744 (header_size, word_size): New constants.
1745 (allocate_vectorlike): Don't check size overflow here.
1746 (allocate_vector): Check it here instead, since this is the only
1747 caller of allocate_vectorlike that could cause overflow.
1748 Check that the new vector's length is representable as a fixnum.
1750 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1751 The previous code was bogus. For example, next_almost_prime (32)
1752 returned 39, which is undesirable as it is a multiple of 3; and
1753 next_almost_prime (24) returned 25, which is a multiple of 5 so
1754 why was the code bothering to check for multiples of 7?
1756 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1758 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1760 Variadic C functions now count arguments with ptrdiff_t.
1761 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1762 Back then I didn't know that the Emacs coding style prefers signed int.
1763 Also, in the meantime I found a few more instances where arguments
1764 were being counted with int, which may truncate counts on 64-bit
1765 machines, or EMACS_INT, which may be unnecessarily wide.
1766 * lisp.h (struct Lisp_Subr.function.aMANY)
1767 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1768 Arg counts are now ptrdiff_t, not size_t.
1769 All variadic functions and their callers changed accordingly.
1770 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1771 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1772 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1773 * callint.c (Fcall_interactively): Check arg count for overflow,
1774 to avoid potential buffer overrun. Use signed char, not 'int',
1775 for 'varies' array, so that we needn't bother to check its size
1776 calculation for overflow.
1777 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1778 * eval.c (apply_lambda):
1779 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1780 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1781 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1783 * callint.c (Fcall_interactively): Don't use index var as event count.
1785 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1786 * mem-limits.h (SIZE): Remove; no longer used.
1788 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1790 Remove unnecessary casts.
1791 * xterm.c (x_term_init):
1792 * xfns.c (x_set_border_pixel):
1793 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1794 These aren't needed now that we assume ANSI C.
1796 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1797 It's more likely to cause problems (due to unsigned overflow)
1800 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1802 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1804 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1806 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1808 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1810 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1812 GLYPH_CODE_FACE returns EMACS_INT, not int.
1813 * dispextern.h (merge_faces):
1814 * xfaces.c (merge_faces):
1815 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1816 Don't assume EMACS_INT fits in int.
1818 * character.h (CHAR_VALID_P): Remove unused parameter.
1819 * fontset.c, lisp.h, xdisp.c: All uses changed.
1821 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1823 * fns.c (concat): Minor tuning based on overflow analysis.
1824 This doesn't fix any bugs. Use int to hold character, instead
1825 of constantly refetching from Emacs object. Use XFASTINT, not
1826 XINT, for value known to be a character. Don't bother comparing
1827 a single byte to 0400, as it's always less.
1829 * floatfns.c (Fexpt):
1830 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1832 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1835 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1837 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1838 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1839 incorrectly succeed when S was a string, because 4294967386 was
1840 truncated before it was used.
1842 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1843 Otherwise, an out-of-range integer could cause undefined behavior
1846 * composite.c: Use int, not EMACS_INT, for characters.
1847 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1848 EMACS_INT, for values that are known to be in character range.
1849 This doesn't fix any bugs but is the usual style inside Emacs and
1850 may generate better code on 32-bit machines.
1852 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1853 This is for reasons similar to the recent CHAR_STRING fix.
1854 * charset.c (Fencode_char): Check that character arg is actually
1855 a character. Pass an int to ENCODE_CHAR.
1856 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1857 wider than 'int', as a compile-time check to prevent future regressions
1860 * character.c (char_string): Remove unnecessary casts.
1862 Make sure a 64-bit char is never passed to CHAR_STRING.
1863 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1864 by silently ignoring the top 32 bits, allowing some values
1865 that were far too large to be valid characters.
1866 * character.h: Include <verify.h>.
1867 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1868 arguments are no wider than unsigned, as a compile-time check
1869 to prevent future regressions in this area.
1871 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1872 (Fsubst_char_in_region):
1874 * xdisp.c (decode_mode_spec_coding):
1875 Adjust to CHAR_STRING's new requirement.
1876 * editfns.c (Finsert_char, Fsubst_char_in_region):
1877 * fns.c (concat): Check that character args are actually
1878 characters. Without this test, these functions did the wrong
1879 thing with wildly out-of-range values on 64-bit hosts.
1881 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1882 These casts should not be needed on 32-bit hosts, either.
1883 * keyboard.c (read_char):
1884 * lread.c (Fload): Remove casts to unsigned.
1886 * lisp.h (UNSIGNED_CMP): New macro.
1887 This fixes comparison bugs on 64-bit hosts.
1888 (ASCII_CHAR_P): Use it.
1889 * casefiddle.c (casify_object):
1890 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1891 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1892 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1893 * dispextern.h (FACE_FROM_ID):
1894 * keyboard.c (read_char): Use UNSIGNED_CMP.
1896 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1897 not to EMACS_INT, to avoid GCC warning.
1899 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1901 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1902 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1903 isn't needed on 32-bit machines.
1905 * buffer.c (Fgenerate_new_buffer_name):
1906 Use EMACS_INT for count, not int.
1907 (advance_to_char_boundary): Return EMACS_INT, not int.
1909 * data.c (Qcompiled_function): Now static.
1911 * window.c (window_body_lines): Now static.
1913 * image.c (gif_load): Rename local to avoid shadowing.
1915 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1916 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1917 * alloc.c (make_save_value): Integer argument is now of type
1919 (mark_object): Use ptrdiff_t, not int.
1920 * lisp.h (pD): New macro.
1921 * print.c (print_object): Use it.
1923 * alloc.c: Use EMACS_INT, not int, to count objects.
1924 (total_conses, total_markers, total_symbols, total_vector_size)
1925 (total_free_conses, total_free_markers, total_free_symbols)
1926 (total_free_floats, total_floats, total_free_intervals)
1927 (total_intervals, total_strings, total_free_strings):
1928 Now EMACS_INT, not int. All uses changed.
1929 (Fgarbage_collect): Compute overall total using a double, so that
1930 integer overflow is less likely to be a problem. Check for overflow
1931 when converting back to an integer.
1932 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1933 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1934 These were 'int' variables that could overflow on 64-bit hosts;
1935 they were never used, so remove them instead of repairing them.
1936 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1937 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1938 Previously, this ceilinged at INT_MAX, but that doesn't work on
1940 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1942 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1943 (allocate_vectorlike): Check for ptrdiff_t overflow.
1944 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1945 when a (possibly-narrower) signed value would do just as well.
1946 We prefer using signed arithmetic, to avoid comparison confusion.
1948 * alloc.c: Catch some string size overflows that we were missing.
1949 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1950 for convenience in STRING_BYTES_MAX.
1951 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1952 The definition here is exact; the one in lisp.h was approximate.
1953 (allocate_string_data): Check for string overflow. This catches
1954 some instances we weren't catching before. Also, it catches
1955 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1956 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1957 and ptrdiff_t and EMACS_INT are both 64 bits.
1959 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1960 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1961 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1963 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1965 * alloc.c (Fmake_string): Check for out-of-range init.
1967 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1969 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1971 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1973 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1974 xg_get_default_scrollbar_width.
1976 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1977 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1978 (style_changed_cb): Call update_theme_scrollbar_width and call
1979 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1980 all frames (Bug#8505).
1981 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1982 Call gtk_window_set_resizable if HAVE_GTK3.
1983 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1984 and height if HAVE_GTK3 (Bug#8505).
1985 (scroll_bar_width_for_theme): New variable.
1986 (update_theme_scrollbar_width): New function.
1987 (xg_get_default_scrollbar_width): Move code to
1988 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1989 (xg_initialize): Call update_theme_scrollbar_width.
1991 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1993 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1995 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1997 * frame.c (make_frame): Call other_buffer_safely instead of
2000 * window.c (temp_output_buffer_show): Call display_buffer with
2001 second argument Vtemp_buffer_show_specifiers and reset latter
2002 immediately after the call.
2003 (Vtemp_buffer_show_specifiers): New variable.
2004 (auto_window_vscroll_p, next_screen_context_lines)
2005 (Vscroll_preserve_screen_position): Remove leading asterisks from
2008 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2010 Fix minor problems found by GCC 4.6.0 static checking.
2011 * buffer.c (Qclone_number): Remove for now, as it's unused.
2012 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2013 (record_buffer): Remove unused local.
2014 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2015 (set_frame_buffer_list): Remove; unused.
2016 * frame.h (other_visible_frames): Remove decl.
2017 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2018 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2019 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2021 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2022 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2023 Define only if HAVE_GPM.
2024 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2025 (update_hints_inhibit): Remove; never set. All uses removed.
2026 * widgetprv.h (emacsFrameClassRec): Remove decl.
2027 * window.c (delete_deletable_window): Now returns void, since it
2028 wasn't returning anything.
2029 (compare_window_configurations): Remove unused locals.
2030 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2031 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2032 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2033 the same widths as pointers. This follows up on the 2011-05-06 patch.
2034 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2035 * xterm.h: Likewise.
2036 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2038 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2040 * makefile.w32-in: Update dependencies.
2041 (LISP_H): Add lib/intprops.h.
2043 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2045 * image.c (gif_load): Add animation frame delay to the metadata.
2046 (syms_of_image): Use DEFSYM. New symbol `delay'.
2048 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2050 * window.c (delete_deletable_window): Re-add.
2051 (Fset_window_configuration): Rewrite to handle dead buffers and
2052 consequently deletable windows.
2053 (window_tree, Fwindow_tree): Remove. Supply functionality in
2055 (compare_window_configurations): Simplify code.
2057 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2059 * image.c (imagemagick_load_image): Fix type mismatch.
2060 (Fimagemagick_types): Likewise.
2062 * window.h (replace_buffer_in_windows): Declare.
2064 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2066 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2067 Qclone_number. Remove external declaration of Qdelete_window.
2068 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2070 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2071 Qbuffer_list_update_hook if allowed.
2072 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2073 buffer list implementation.
2074 (other_buffer_safely): New function.
2075 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2076 calls to replace_buffer_in_windows and
2077 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2079 (record_buffer): Inhibit quitting and rewrite using quittable
2080 functions. Run Qbuffer_list_update_hook if allowed.
2081 (Frecord_buffer, Funrecord_buffer): New functions.
2082 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2083 switch-to-buffer to window.el.
2084 (bury-buffer): Move to window.el.
2085 (Vbuffer_list_update_hook): New variable.
2087 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2090 * window.h (resize_frame_windows): Move up in code.
2091 (Fwindow_frame): Remove EXFUN.
2092 (replace_buffer_in_all_windows): Remove prototype.
2093 (replace_buffer_in_windows_safely): Add prototype.
2095 * window.c: Declare Qdelete_window static again. Move down
2096 declaration of select_count.
2097 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2098 (Fother_window): Move to window.el.
2099 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2100 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2101 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2103 (replace_buffer_in_windows): Implement by calling
2104 Qreplace_buffer_in_windows.
2105 (replace_buffer_in_all_windows): Remove with some functionality
2106 moved into replace_buffer_in_windows_safely.
2107 (replace_buffer_in_windows_safely): New function.
2108 (select_window_norecord, select_frame_norecord): Move in front
2109 of run_window_configuration_change_hook. Remove now obsolete
2111 (Fset_window_buffer): Rewrite doc-string. Call
2112 Qrecord_window_buffer.
2113 (keys_of_window): Move binding for other-window to window.el.
2115 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2117 * dispextern.h (struct image): Replace data member, whose int_val
2118 and ptr_val fields were not used by anything, with a single
2121 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2122 (gif_clear_image, gif_load, imagemagick_load_image)
2123 (gs_clear_image, gs_load): Callers changed.
2125 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2127 * buffer.h: Include <time.h>, for time_t.
2128 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2130 Fix minor problems found by static checking.
2132 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2134 Make identifiers static if they are not used in other modules.
2135 * data.c (Qcompiled_function, Qframe, Qvector):
2136 * image.c (QimageMagick, Qsvg):
2137 * minibuf.c (Qmetadata):
2138 * window.c (resize_window_check, resize_root_window): Now static.
2139 * window.h (resize_window_check, resize_root_window): Remove decls.
2141 * window.c (window_deletion_count, delete_deletable_window):
2143 (window_body_lines): Now static.
2144 (Fdelete_other_windows_internal): Mark vars as initialized.
2145 Make sure 'resize_failed' is initialized.
2146 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2147 (resize_window_apply): Remove unused local.
2148 * window.h (delete_deletable_window): Remove decl.
2150 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2151 (imagemagick_load_image): Fix pointer signedness problem by changing
2152 last arg from unsigned char * to char *. All uses changed.
2153 Also, fix a local for similar reasons.
2154 Remove unused locals. Remove locals to avoid shadowing.
2155 (fn_rsvg_handle_free): Remove; unused.
2156 (svg_load, svg_load_image): Fix pointer signedness problem.
2157 (imagemagick_load_image): Don't use garbage pointer image_wand.
2159 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2161 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2163 * image.c (gif_load): Fix omitted cast error introduced by
2166 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2168 * window.h (resize_proportionally, orig_total_lines)
2169 (orig_top_line): Remove from window structure.
2170 (set_window_height, set_window_width, change_window_heights)
2171 (Fdelete_window): Remove prototypes.
2172 (resize_frame_windows): Remove duplicate declaration.
2174 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2176 * window.h (resize_frame_windows, resize_window_check)
2177 (delete_deletable_window, resize_root_window)
2178 (resize_frame_windows): Declare prototypes.
2180 * window.c (resize_window_apply): Make definition be "static" to
2181 match the prototype.
2183 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2185 * window.c: Remove declarations of Qwindow_size_fixed,
2186 window_min_size_1, window_min_size_2, window_min_size,
2187 size_window, window_fixed_size_p, enlarge_window, delete_window.
2188 Remove static from declaration of Qdelete_window, it's
2189 temporarily needed by Fbury_buffer.
2190 (replace_window): Don't assign orig_top_line and
2192 (Fdelete_window, delete_window): Remove. Window deletion is
2193 handled by window.el.
2194 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2195 Fdelete_window calls with calls to Qdelete_window.
2196 (Fdelete_other_windows): Remove. Deleting other windows is
2197 handled by window.el.
2198 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2199 handled in window.el.
2200 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2201 Window minimum sizes are handled in window.el.
2202 (shrink_windows, size_window, set_window_height)
2203 (set_window_width, change_window_heights, window_height)
2204 (window_width, CURBEG, CURSIZE, enlarge_window)
2205 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2206 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2207 handled in window.el.
2208 (make_dummy_parent): Rename to make_parent_window and give it a
2209 second argument horflag.
2210 (make_window): Don't set resize_proportionally any more.
2211 (Fsplit_window): Remove. Windows are split in window.el.
2212 (save_restore_action, save_restore_orig_size)
2213 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2214 Resize mini windows in window.el.
2215 (grow_mini_window, shrink_mini_window): Implement by calling
2216 Qresize_root_window_vertically, resize_window_check and
2217 resize_window_apply.
2218 (saved_window, Fset_window_configuration, save_window_save): Do
2219 not handle orig_top_line, orig_total_lines, and
2220 resize_proportionally.
2221 (window_min_height, window_min_width): Move to window.el.
2222 (keys_of_window): Move bindings for delete-other-windows,
2223 split-window, delete-window and enlarge-window to window.el.
2225 * buffer.c: Temporarily extern Qdelete_window.
2226 (Fbury_buffer): Temporarily call Qdelete_window instead of
2227 Fdelete_window (Fbury_buffer will move to window.el soon).
2229 * frame.c (set_menu_bar_lines_1): Remove code handling
2230 orig_top_line and orig_total_lines.
2232 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2233 set_window_height but set heights directly.
2234 (change_frame_size_1): Use resize_frame_windows.
2236 * xdisp.c (init_xdisp): Don't use set_window_height but set
2239 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2240 resize_frame_windows instead of change_window_heights and run
2241 run_window_configuration_change_hook.
2243 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2244 instead of change_window_heights and run
2245 run_window_configuration_change_hook.
2247 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2249 * window.c (replace_window): Rename second argument REPLACEMENT to
2250 NEW. New third argument SETFLAG. Rewrite.
2251 (delete_window, make_dummy_parent): Call replace_window with
2253 (window_list_1): Move down in code.
2254 (run_window_configuration_change_hook): Move set_buffer part
2255 before select_frame_norecord part in order to unwind correctly.
2256 Rename count1 to count.
2257 (recombine_windows, delete_deletable_window, resize_root_window)
2258 (Fdelete_other_windows_internal)
2259 (Frun_window_configuration_change_hook, make_parent_window)
2260 (resize_window_check, resize_window_apply, Fresize_window_apply)
2261 (resize_frame_windows, Fsplit_window_internal)
2262 (Fdelete_window_internal, Fresize_mini_window_internal): New
2264 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2266 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2268 * window.h (window): Add some new members to window structure -
2269 normal_lines, normal_cols, new_total, new_normal, clone_number,
2270 splits, nest, prev_buffers, next_buffers.
2271 (WINDOW_TOTAL_SIZE): Move here from window.c.
2272 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2274 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2276 (make_dummy_parent): Set new members of windows structure.
2277 (make_window): Move down in code. Handle new members of window
2279 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2280 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2281 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2282 (Fset_window_prev_buffers, Fwindow_next_buffers)
2283 (Fset_window_next_buffers, Fset_window_clone_number): New
2285 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2286 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2288 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2289 Argument WINDOW can be now internal window too.
2290 (Fwindow_use_time): Move up in code.
2291 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2293 (Fset_window_configuration, saved_window)
2294 (Fcurrent_window_configuration, save_window_save): Handle new
2295 members of window structure.
2296 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2297 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2298 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2299 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2300 Qget_mru_window, Qresize_root_window,
2301 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2302 Qauto_buffer_name; staticpro them.
2304 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2306 * window.c (Fwindow_total_size, Fwindow_left_column)
2307 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2308 (Fwindow_list_1): New functions.
2309 (window_box_text_cols): Replace with window_body_cols.
2310 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2311 window_body_cols instead of window_box_text_cols.
2312 (delete_window, Fset_window_configuration): Call
2313 delete_all_subwindows with window as argument.
2314 (delete_all_subwindows): Take a window as argument and not a
2316 (window_loop): Remove handling of GET_LRU_WINDOW and
2318 (Fget_lru_window, Fget_largest_window): Move to window.el.
2320 * window.h: Extern window_body_cols instead of
2321 window_box_text_cols. delete_all_subwindows now takes a
2322 Lisp_Object as argument.
2324 * indent.c (compute_motion, Fcompute_motion): Use
2325 window_body_cols instead of window_box_text_cols.
2327 * frame.c (delete_frame): Call delete_all_subwindows with root
2330 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2332 * fns.c (Fputhash): Document return value.
2334 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2336 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2338 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2340 Cons<->int and similar integer overflow fixes (Bug#8794).
2342 Check for overflow when converting integer to cons and back.
2343 * charset.c (Fdefine_charset_internal, Fdecode_char):
2344 Use cons_to_unsigned to catch overflow.
2345 (Fencode_char): Use INTEGER_TO_CONS.
2346 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2347 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2348 * data.c (long_to_cons, cons_to_long): Remove.
2349 (cons_to_unsigned, cons_to_signed): New functions.
2350 These signal an error for invalid or out-of-range values.
2351 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2352 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2353 * font.c (Ffont_variation_glyphs):
2354 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2355 * lisp.h: Include <intprops.h>.
2356 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2357 (cons_to_signed, cons_to_unsigned): New decls.
2358 (long_to_cons, cons_to_long): Remove decls.
2359 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2360 (Fprimitive_undo): Use CONS_TO_INTEGER.
2361 * xfns.c (Fx_window_property): Likewise.
2362 * xselect.c: Include <limits.h>.
2363 (x_own_selection, selection_data_to_lisp_data):
2364 Use INTEGER_TO_CONS.
2365 (x_handle_selection_request, x_handle_selection_clear)
2366 (x_get_foreign_selection, Fx_disown_selection_internal)
2367 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2368 (lisp_data_to_selection_data): Use cons_to_unsigned.
2369 (x_fill_property_data): Use cons_to_signed.
2370 Report values out of range.
2372 Check for buffer and string overflow more precisely.
2373 * buffer.h (BUF_BYTES_MAX): New macro.
2374 * lisp.h (STRING_BYTES_MAX): New macro.
2375 * alloc.c (Fmake_string):
2376 * character.c (string_escape_byte8):
2377 * coding.c (coding_alloc_by_realloc):
2378 * doprnt.c (doprnt):
2379 * editfns.c (Fformat):
2381 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2382 since they may not be the same number.
2383 * editfns.c (Finsert_char):
2384 * fileio.c (Finsert_file_contents):
2385 Likewise for BUF_BYTES_MAX.
2387 * image.c: Use ptrdiff_t, not int, for sizes.
2388 (slurp_file): Switch from int to ptrdiff_t.
2390 (slurp_file): Check that file size fits in both size_t (for
2391 malloc) and ptrdiff_t (for sanity and safety).
2393 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2394 if b->modtime has its maximal value.
2396 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2398 Don't assume time_t can fit into int.
2399 * buffer.h (struct buffer.modtime): Now time_t, not int.
2400 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2401 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2403 Minor fixes for signed vs unsigned integers.
2404 * character.h (MAYBE_UNIFY_CHAR):
2405 * charset.c (maybe_unify_char):
2406 * keyboard.c (read_char, reorder_modifiers):
2407 XINT -> XFASTINT, since the integer must be nonnegative.
2408 * ftfont.c (ftfont_spec_pattern):
2409 * keymap.c (access_keymap, silly_event_symbol_error):
2410 XUINT -> XFASTINT, since the integer must be nonnegative.
2411 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2412 since it makes no difference and we prefer signed.
2413 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2414 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2417 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2419 * window.h (Fwindow_frame): Declare.
2421 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2423 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2424 (SPARE_MEMORY): Always define.
2425 (LARGE_REQUEST): Remove.
2426 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2428 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2430 * lisp.h: Move EXFUNS for Fframe_root_window,
2431 Fframe_first_window and Fset_frame_selected_window to window.h.
2433 * window.h: Move EXFUNS for Fframe_root_window,
2434 Fframe_first_window and Fset_frame_selected_window here from
2437 * frame.c (Fwindow_frame, Fframe_first_window)
2438 (Fframe_root_window, Fframe_selected_window)
2439 (Fset_frame_selected_window): Move to window.c.
2440 (Factive_minibuffer_window): Move to minibuf.c.
2441 (Fother_visible_frames_p): New function.
2443 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2445 * window.c (decode_window, decode_any_window): Move up in code.
2446 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2447 (inhibit_frame_unsplittable): Remove unused variable.
2448 (Fwindow_buffer): Move up and rewrite doc-string.
2449 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2450 (Fwindow_prev): New functions.
2451 (Fwindow_frame): Move here from frame.c. Accept any window as
2453 (Fframe_root_window, Fframe_first_window)
2454 (Fframe_selected_window): Move here from frame.c. Accept frame
2455 or arbitrary window as argument. Update doc-strings.
2456 (Fminibuffer_window): Move up in code.
2457 (Fwindow_minibuffer_p): Move up in code and simplify.
2458 (Fset_frame_selected_window): Move here from frame.c.
2460 (Fselected_window, select_window, Fselect_window): Move up in
2461 code. Minor doc-string fixes.
2463 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2465 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2466 Do not assume that spare memory exists; that assumption is valid
2467 only if SYSTEM_MALLOC.
2468 (LARGE_REQUEST): New macro, so that the issue of large requests
2469 is separated from the issue of spare memory.
2471 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2473 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2476 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2478 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2481 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2483 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2485 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2487 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2488 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2490 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2492 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2494 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2496 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2497 (x_clipboard_manager_save): Add return value.
2498 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2500 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2501 Obey Vx_select_enable_clipboard_manager. Catch errors in
2502 x_clipboard_manager_save (Bug#8779).
2503 (Vx_select_enable_clipboard_manager): New variable.
2504 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2506 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2508 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2510 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2512 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2513 in the current matrix if keep_current_p is non-zero.
2515 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2517 * bidi.c (bidi_level_of_next_char): Fix last change.
2519 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2521 Support bidi reordering of text covered by display properties.
2523 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2524 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2525 (bidi_cache_search, bidi_cache_iterator_state)
2526 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2527 (bidi_level_of_next_char, bidi_move_to_visually_next):
2528 Support character positions inside a run of characters covered by a
2530 (bidi_paragraph_init, bidi_resolve_explicit_1)
2531 (bidi_level_of_next_char): Call bidi_fetch_char and
2532 bidi_fetch_char_advance instead of FETCH_CHAR and
2534 (bidi_init_it): Initialize new members.
2535 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2537 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2538 instead of using explicit *_CHAR codes.
2539 (bidi_resolve_explicit, bidi_resolve_weak):
2540 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2541 bidirectional text is supported only in multibyte buffers.
2542 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2543 it to initialize the frame_window_p member of struct bidi_it.
2544 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2545 (bidi_resolve_explicit, bidi_resolve_weak)
2546 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2547 bidi_it->nchars is non-positive.
2548 (bidi_level_of_next_char): Don't try to lookup the cache for the
2549 next/previous character if nothing is cached there yet, or if we
2550 were just reseat()'ed to a new position.
2552 * xdisp.c (set_cursor_from_row): Set start and stop points
2553 according to the row's direction when priming the loop that looks
2554 for the glyph on which to display cursor.
2555 (single_display_spec_intangible_p): Function deleted.
2556 (display_prop_intangible_p): Reimplement to call
2557 handle_display_spec instead of single_display_spec_intangible_p.
2558 Accept 3 additional arguments needed by handle_display_spec.
2559 This fixes incorrect cursor motion across display property with complex
2560 values: lists, `(when COND...)' forms, etc.
2561 (single_display_spec_string_p): Support property values that are
2562 lists with the argument STRING its top-level element.
2563 (display_prop_string_p): Fix the condition for processing a
2564 property that is a list to be consistent with handle_display_spec.
2565 (handle_display_spec): New function, refactored from the
2566 last portion of handle_display_prop.
2567 (compute_display_string_pos): Accept additional argument
2568 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2569 value of a `display' property is a "replacing spec".
2570 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2571 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2572 the display property, but just return a value indicating whether
2573 the display property will replace the characters it covers.
2574 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2575 frame_window_p members of struct bidi_it.
2576 (compute_display_string_pos, compute_display_string_end):
2578 (push_it): Accept second argument POSITION, where pop_it should
2579 jump to continue iteration.
2580 (reseat_1): Initialize bidi_it.disp_pos.
2582 * keyboard.c (adjust_point_for_property): Adjust the call to
2583 display_prop_intangible_p to its new signature.
2585 * dispextern.h (struct bidi_it): New member frame_window_p.
2586 (bidi_init_it): Update prototypes.
2587 (display_prop_intangible_p): Update prototype.
2588 (compute_display_string_pos, compute_display_string_end):
2590 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2593 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2595 Malloc failure behavior now depends on size of allocation.
2596 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2597 * lisp.h: Change signatures accordingly.
2598 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2599 All callers changed. (Bug#8762)
2601 * gnutls.c: Use Emacs's memory allocators.
2602 Without this change, the gnutls library would invoke malloc etc.
2603 directly, which causes problems on non-SYNC_INPUT hosts, and which
2604 runs afoul of improving memory_full behavior. (Bug#8761)
2605 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2606 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2607 xfree instead of the default malloc, realloc, free.
2608 (Fgnutls_boot): No need to check for memory allocation failure,
2609 since xmalloc does that for us.
2611 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2612 * category.c (hash_get_category_set):
2613 * ccl.c (ccl_driver):
2614 * charset.c (Fdefine_charset_internal):
2615 * charset.h (struct charset.hash_index):
2616 * composite.c (get_composition_id, gstring_lookup_cache)
2617 (composition_gstring_put_cache):
2618 * composite.h (struct composition.hash_index):
2619 * dispextern.h (struct image.hash):
2620 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2621 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2622 (hashfn_equal, hashfn_user_defined, make_hash_table)
2623 (maybe_resize_hash_table, hash_lookup, hash_put)
2624 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2625 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2626 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2627 * image.c (make_image, search_image_cache, lookup_image)
2628 (xpm_put_color_table_h):
2629 * lisp.h (struct Lisp_Hash_Table):
2630 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2631 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2632 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2633 * alloc.c (allocate_vectorlike):
2634 Check for overflow in vector size calculations.
2635 * ccl.c (ccl_driver):
2636 Check for overflow when converting EMACS_INT to int.
2637 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2638 need to be updated by these changes.
2639 * fns.c (make_hash_table, maybe_resize_hash_table):
2640 Check for integer overflow with large hash tables.
2641 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2642 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2643 (SXHASH_REDUCE): New macro.
2644 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2645 Use it instead of discarding useful hash info with large hash values.
2646 (sxhash_float): New function.
2647 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2648 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2649 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2650 Rewrite to use FIXNUM_BITS, as this simplifies things.
2651 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2652 Adjust signatures to match updated version of code.
2653 (consing_since_gc): Now EMACS_INT, since a single hash table can
2654 use more than INT_MAX bytes.
2656 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2658 Make it possible to build with GCC-4.6+ -O2 -flto.
2660 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2662 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2664 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2665 Call minibuffer-inactive-mode.
2667 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2669 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2670 Update dependencies.
2672 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2674 * data.c (init_data): Remove code for UTS, this system is not
2677 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2679 Don't force ./temacs to start in terminal mode.
2681 * frame.c (make_initial_frame): Initialize faces in all cases, not
2682 only when CANNOT_DUMP is defined.
2683 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2685 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2687 * dispnew.c (add_window_display_history): Use const for the string
2688 pointer. Remove declaration, not needed.
2690 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2692 Use 'inline', not 'INLINE'.
2693 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2694 * alloc.c, fontset.c (INLINE): Remove.
2695 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2696 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2697 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2698 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2699 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2701 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2703 Make it possible to run ./temacs.
2705 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2706 syms_of_callproc does the same thing. Remove test for
2707 "initialized", do it in the caller.
2708 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2710 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2712 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2713 (read_minibuf): Use get_minibuffer.
2714 (syms_of_minibuf): Use DEFSYM.
2715 (Qmetadata): New var.
2716 * data.c (Qbuffer): Don't make it static.
2717 (syms_of_data): Use DEFSYM.
2719 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2721 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2722 (CCL_CODE_MIN): New macro.
2724 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2726 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2728 * eval.c (Qdebug): Now static.
2729 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2730 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2731 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2733 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2735 * image.c: Various fixes to ImageMagick code comments.
2736 (Fimagemagick_types): Doc fix.
2738 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2740 Minor fixes prompted by GCC 4.6.0 warnings.
2742 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2744 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2745 (x_clipboard_manager_save_all): Move extern decl to ...
2746 * xterm.h: ... here, so that it can be checked for consistency.
2748 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2750 * xselect.c (x_clipboard_manager_save_frame)
2751 (x_clipboard_manager_save_all): New functions.
2752 (Fx_clipboard_manager_save): Lisp function deleted.
2754 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2755 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2757 * xterm.h: Update prototype.
2759 2011-05-28 William Xu <william.xwl@gmail.com>
2761 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2764 2011-05-28 Jim Meyering <meyering@redhat.com>
2766 Avoid a sign-extension bug in crypto_hash_function.
2767 * fns.c (to_uchar): Define.
2768 (crypto_hash_function): Use it to convert some newly-signed
2769 variables to unsigned, to avoid sign-extension bugs. For example,
2770 without this change, (md5 "truc") would evaluate to
2771 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2772 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2773 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2775 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2777 Integer overflow fixes.
2779 * dbusbind.c: Serial number integer overflow fixes.
2780 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2781 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2782 to hold a serial number that is too large for a fixnum.
2783 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2784 Check for serial numbers out of range. Decode any serial number
2785 that was so large that it became a float. (Bug#8722)
2787 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2788 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2789 Use XFASTINT rather than XUINT when numbers are nonnegative.
2790 (xd_append_arg, Fdbus_method_return_internal):
2791 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2792 arguments, check that Lisp number is nonnegative, rather than
2793 silently wrapping negative numbers around. (Bug#8722)
2794 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2797 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2799 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2801 ccl: add integer overflow checks
2802 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2803 (IN_INT_RANGE): New macros.
2804 (ccl_driver): Use them to check for integer overflow when
2805 decoding a CCL program. Many of the new checks are whether XINT (x)
2806 fits in int; it doesn't always, on 64-bit hosts. The new version
2807 doesn't catch all possible integer overflows, but it's an
2808 improvement. (Bug#8719)
2810 * alloc.c (make_event_array): Use XINT, not XUINT.
2811 There's no need for unsigned here.
2813 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2814 This follows up to the 2011-05-06 change that substituted uintptr_t
2815 for EMACS_INT. This case wasn't caught back then.
2817 Rework Fformat to avoid integer overflow issues.
2818 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2819 now (part of C89). Include <verify.h>.
2820 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2821 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2822 (Fformat): Avoid the prepass trying to compute sizes; it was only
2823 approximate and thus did not catch overflow reliably. Instead, walk
2824 through the format just once, formatting and computing sizes as we go,
2825 checking for integer overflow at every step, and allocating a larger
2826 buffer as needed. Keep track separately whether the format is
2827 multibyte. Keep only the most-recently calculated precision, rather
2828 than them all. Record whether each argument has been converted to
2829 string. Use EMACS_INT, not int, for byte and char and arg counts.
2830 Support field widths and precisions larger than INT_MAX. Avoid
2831 sprintf's undefined behavior with conversion specifications such as %#d
2832 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2833 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2834 formatting out-of-range floating point numbers with int
2837 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2839 * data.c: Avoid integer truncation in expressions involving floats.
2840 * data.c: Include <intprops.h>.
2841 (arith_driver): When there's an integer overflow in an expression
2842 involving floating point, convert the integers to floating point
2843 so that the resulting value does not suffer from catastrophic
2844 integer truncation. For example, on a 64-bit host (* 4
2845 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2846 Do not rely on undefined behavior after integer overflow.
2848 merge count_size_as_multibyte, parse_str_to_multibyte
2849 * character.c, character.h (count_size_as_multibyte):
2850 Rename from parse_str_to_multibyte; all uses changed.
2851 Check for integer overflow.
2852 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2853 since it's now a duplicate of the other. This is more of
2854 a character than a buffer op, so better that it's in character.c.
2855 * fns.c, print.c: Adjust to above changes.
2857 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2859 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2861 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2863 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2864 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2865 (x_clipboard_manager_save): Now static.
2866 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2868 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2869 (crypto_hash_function): Now static.
2870 Fix pointer signedness problems. Avoid unnecessary initializations.
2872 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2874 * termhooks.h (Vselection_alist): Make it terminal-local.
2876 * terminal.c (create_terminal): Initialize it.
2878 * xselect.c: Support for clipboard managers.
2879 (Vselection_alist): Move to termhooks.h as terminal-local var.
2880 (LOCAL_SELECTION): New macro.
2881 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2882 (symbol_to_x_atom): Remove gratuitous arg.
2883 (x_handle_selection_request, lisp_data_to_selection_data)
2884 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2885 (x_own_selection, x_get_local_selection, x_convert_selection):
2886 New arg, specifying work frame. Use terminal-local Vselection_alist.
2887 (some_frame_on_display): Delete unused function.
2888 (Fx_own_selection_internal, Fx_get_selection_internal)
2889 (Fx_disown_selection_internal, Fx_selection_owner_p)
2890 (Fx_selection_exists_p): New optional frame arg.
2891 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2892 (x_handle_selection_clear): Don't treat other terminals with the
2893 same keyboard specially. Use the terminal-local Vselection_alist.
2894 (x_clear_frame_selections): Use Frun_hook_with_args.
2896 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2898 * xterm.h: Add support for those atoms.
2900 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2902 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2903 (converted_selections, conversion_fail_tag): New global variables.
2904 (x_selection_request_lisp_error): Free the above.
2905 (x_get_local_selection): Remove unnecessary code.
2906 (x_reply_selection_request): Args changed; handle arbitrary array
2907 of converted selections stored in converted_selections.
2908 Separate the XChangeProperty and SelectionNotify steps.
2909 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2910 (x_convert_selection): New function.
2911 (x_handle_selection_event): Simplify.
2912 (x_get_foreign_selection): Don't ignore incoming requests while
2913 waiting for an answer; this will fail when we implement
2914 SAVE_TARGETS, and seems unnecessary anyway.
2915 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2916 (Vx_sent_selection_functions): Doc fix.
2918 2011-05-26 Leo Liu <sdl.web@gmail.com>
2920 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2922 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2924 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2926 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2927 for fringe update if it has periodic bitmap.
2928 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2929 and fringe_bitmap_periodic_p.
2931 * fringe.c (get_fringe_bitmap_data): New function.
2932 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2933 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2934 row. Mark glyph row for fringe update if periodicity changed.
2936 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2937 for fringe update unless it has periodic bitmap.
2939 2011-05-25 Kenichi Handa <handa@m17n.org>
2941 * xdisp.c (get_next_display_element): Set correct it->face_id for
2942 a static composition.
2944 2011-05-24 Leo Liu <sdl.web@gmail.com>
2947 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2949 * fns.c (crypto_hash_function, Fsha1): New function.
2950 (Fmd5): Use crypto_hash_function.
2951 (syms_of_fns): Add Ssha1.
2953 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2955 * gnutls.c: Remove unused macros.
2956 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2957 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2958 Remove macros that are defined and never used.
2959 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2961 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2963 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2964 (Fx_get_selection_internal): Minor cleanup.
2965 (Fx_own_selection_internal): Rename arguments for consistency with
2968 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2970 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2972 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2974 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2976 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2978 * dispnew.c (scrolling_window): Don't exclude the case that the
2979 last enabled row in the desired matrix touches the bottom boundary.
2981 2011-05-21 Glenn Morris <rgm@gnu.org>
2983 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2984 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2985 and add some more files.
2987 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2989 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2990 report_file_error introduced by the change from 2011-05-07.
2992 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2994 * systime.h (Time): Define only if emacs is defined.
2995 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2996 where the include path doesn't have X11/X.h by default. See
2997 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2999 2011-05-20 Kenichi Handa <handa@m17n.org>
3001 * composite.c (find_automatic_composition): Fix previous change.
3003 2011-05-20 Glenn Morris <rgm@gnu.org>
3005 * lisp.mk: New file, split from Makefile.in.
3006 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3007 (shortlisp): Remove.
3008 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3010 2011-05-19 Glenn Morris <rgm@gnu.org>
3012 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3013 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3014 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3015 (lisp): Set the order to that of loadup.el.
3016 (shortlisp): Make it a copy of $lisp.
3017 (SOME_MACHINE_LISP): Remove.
3018 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3019 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3021 2011-05-18 Kenichi Handa <handa@m17n.org>
3023 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3024 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3025 (find_automatic_composition): Mostly rewrite for efficiency.
3027 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3029 * makefile.w32-in: Update dependencies.
3031 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3033 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3034 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3036 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3038 Fix some integer overflow issues, such as string length overflow.
3040 * insdel.c (count_size_as_multibyte): Check for string overflow.
3042 * character.c (lisp_string_width): Check for string overflow.
3043 Use EMACS_INT, not int, for string indexes and lengths; in
3044 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3045 the resulting string length overflows an EMACS_INT; instead,
3046 report a string overflow if no precision given. When checking for
3047 precision exhaustion, use a check that cannot possibly have
3048 integer overflow. (Bug#8675)
3049 * character.h (lisp_string_width): Adjust to new signature.
3051 * alloc.c (string_overflow): New function.
3052 (Fmake_string): Use it. This doesn't change behavior, but saves
3053 a few bytes and will simplify future changes.
3054 * character.c (string_escape_byte8): Likewise.
3055 * lisp.h (string_overflow): New decl.
3057 Fixups, following up to the user-interface timestamp change.
3058 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3059 for UI timestamps, instead of unsigned long.
3060 * msdos.c (mouse_get_pos): Likewise.
3061 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3062 * w32gui.h (Time): Define by including "systime.h" rather than by
3063 declaring it ourselves. (Bug#8664)
3065 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3066 * image.c (clear_image_cache): Likewise.
3068 * term.c (term_mouse_position): Don't assume time_t wraparound.
3070 Be more systematic about user-interface timestamps.
3071 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3072 and sometimes 'EMACS_UINT', to represent these timestamps.
3073 This change causes it to use 'Time' uniformly, as that's what X uses.
3074 This makes the code easier to follow, and makes it easier to catch
3075 integer overflow bugs such as Bug#8664.
3076 * frame.c (Fmouse_position, Fmouse_pixel_position):
3077 Use Time, not unsigned long, for user-interface timestamps.
3078 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3079 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3080 * keyboard.h (last_event_timestamp): Likewise.
3081 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3082 * menu.h (xmenu_show): Likewise.
3083 * term.c (term_mouse_position): Likewise.
3084 * termhooks.h (struct input_event.timestamp): Likewise.
3085 (struct terminal.mouse_position_hook): Likewise.
3086 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3087 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3088 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3089 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3091 * menu.h, termhooks.h: Include "systime.h", for Time.
3093 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3094 Don't assume that the difference between two unsigned long values
3095 can fit into an integer. At this point, we know button_down_time
3096 <= event->timestamp, so the difference must be nonnegative, so
3097 there's no need to cast the result if double-click-time is
3098 nonnegative, as it should be; check that it's nonnegative, just in
3099 case. This bug is triggered when events are more than 2**31 ms
3100 apart (about 25 days). (Bug#8664)
3102 * xselect.c (last_event_timestamp): Remove duplicate decl.
3103 (x_own_selection): Remove needless cast to unsigned long.
3105 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3106 that always fit in int. Use a sentinel instead of a counter, to
3107 avoid a temp and to allay GCC's concerns about possible int overflow.
3108 * frame.h (struct frame): Use int for menu_bar_items_used
3109 instead of EMACS_INT, since it always fits in int.
3111 * menu.c (grow_menu_items): Check for int overflow.
3113 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3115 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3116 Before, the code was not consistent. These values cannot exceed
3117 2**31 - 1 so there's no need to make them unsigned.
3118 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3119 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3120 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3122 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3124 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3125 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3126 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3127 presumably because the widths might not match.
3129 * window.c (size_window): Avoid needless test at loop start.
3131 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3133 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3135 2011-05-12 Drew Adams <drew.adams@oracle.com>
3137 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3139 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3141 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3142 `width' to `bar_area_x' and `bar_area_width', respectively.
3143 (x_scroll_run): Take account of fringe background extension.
3145 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3146 Rename local vars `left' and `width' to `bar_area_x' and
3147 `bar_area_width', respectively.
3148 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3149 background extension.
3151 2011-05-10 Jim Meyering <meyering@redhat.com>
3153 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3155 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3157 * image.c (Finit_image_library): Return t for built-in image types,
3158 like pbm and xbm. (Bug#8640)
3160 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3162 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3164 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3166 * w32console.c (Fset_screen_color): Doc fix.
3167 (Fget_screen_color): New function.
3168 (syms_of_ntterm): Defsubr it.
3170 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3171 unlink the temporary file if Fcall_process didn't create it in the
3173 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3174 child process will be redirected to a file specified with `:file'.
3175 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3176 cue to call_process_cleanup not to close that handle.
3178 2011-05-07 Ben Key <bkey76@gmail.com>
3180 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3181 one of two shell specific rules, either bootstrap-temacs-CMD or
3182 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3183 to the previous implementation of the bootstrap-temacs rule.
3184 The bootstrap-temacs-CMD rule is similar to the previous
3185 implementation of the bootstrap-temacs rule except that it
3186 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3189 These changes, along with some changes to nt/configure.bat,
3190 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3191 earlier fix to add support for --cflags and --ldflags options
3192 that include quotes so that it works whether make uses cmd or
3195 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3197 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3198 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3200 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3201 a string. Handle both cases.
3202 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3203 (Fdbus_register_method): Use Qinvalid_function.
3205 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3207 * makefile.w32-in: Update dependencies.
3208 (LISP_H): Add inttypes.h and stdin.h.
3209 (PROCESS_H): Add unistd.h.
3211 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3213 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3214 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3216 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3218 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3220 * term.c (vfatal): Remove stray call to va_end.
3221 It's not needed and the C Standard doesn't allow it here anyway.
3223 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3224 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3226 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3229 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3231 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3233 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3235 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3237 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3239 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3240 * charset.c (Fdefine_charset_internal): Don't initialize
3241 charset.code_space[15]. The value was garbage, on hosts with
3242 32-bit int (Bug#8600).
3244 * lread.c (read_integer): Be more consistent with string-to-number.
3245 Use string_to_number to do the actual conversion; this avoids
3246 rounding errors and fixes some other screwups. Without this fix,
3247 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3248 (digit_to_number): Move earlier, for benefit of read_integer.
3249 Return -1 if the digit is out of range for the base, -2 if it is
3250 not a digit in any supported base. (Bug#8602)
3252 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3254 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3255 to match comment at start of function. This also removes a
3256 GCC warning about overflow in a 32+64-bit port.
3258 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3260 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3261 Reported by Stefan Monnier in
3262 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3263 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3264 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3266 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3267 (EMACS_UINTPTR): Likewise, with uintptr_t.
3269 * lisp.h: Prefer 64-bit EMACS_INT if available.
3270 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3271 on 32-bit hosts that have 64-bit int, so that they can access
3273 However, temporarily disable this change unless the temporary
3274 symbol WIDE_EMACS_INT is defined.
3276 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3278 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3279 This removes an assumption that EMACS_INT and long are the same
3280 width as pointers. The assumption is true for Emacs porting targets
3281 now, but we want to make other targets possible.
3282 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3283 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3284 In the rest of the code, change types of integers that hold casted
3285 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3286 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3287 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3288 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3289 No need to cast type when ORing.
3290 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3291 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3292 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3293 assume EMACS_INT is the same width as char *.
3294 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3295 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3296 Remove no-longer-needed casts.
3297 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3298 (xg_tool_bar_help_callback, xg_make_tool_item):
3299 Use EMACS_INTPTR to hold an integer
3300 that will be cast to void *; this can avoid a GCC warning
3301 if EMACS_INT is not the same width as void *.
3302 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3303 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3304 (current_message_1, set_message_1):
3305 Use a local to convert to proper width without a cast.
3306 * xmenu.c (dialog_selection_callback): Likewise.
3308 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3309 Also, don't assume VALBITS / RAND_BITS is less than 5,
3310 and don't rely on undefined behavior when shifting a 1 left into
3312 * lisp.h (get_random): Change signature to match.
3314 * lread.c (hash_string): Use size_t, not int, for hash computation.
3315 Normally we prefer signed values; but hashing is special, because
3316 it's better to use unsigned division on hash table sizes so that
3317 the remainder is nonnegative. Also, size_t is the natural width
3318 for hashing into memory. The previous code used 'int', which doesn't
3319 retain enough info to hash well into very large tables.
3320 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3322 * dbusbind.c: Don't possibly lose pointer info when converting.
3323 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3324 Use XPNTR rather than XHASH, so that the high-order bits of
3325 the pointer aren't lost when converting through void *.
3327 * eval.c (Fautoload): Don't double-shift a pointer.
3329 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3331 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3333 * gnutls.c (DEF_GNUTLS_FN):
3334 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3336 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3338 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3341 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3343 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3344 New version that can reserve upto 2GB of heap space.
3346 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3348 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3350 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3352 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3353 `gnutls_certificate_set_x509_key_file'.
3355 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3357 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3358 Update dependencies.
3360 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3362 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3363 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3364 Remove unused parameter `fildes'.
3365 * process.c (read_process_output, send_process): Don't pass it.
3367 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3369 Fix previous change: the library cache is defined in w32.c.
3370 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3371 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3373 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3375 Implement dynamic loading of GnuTLS on Windows.
3377 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3378 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3379 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3382 * gnutls.c (Qgnutls_dll): Define.
3383 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3384 (gnutls_*): Declare function pointers.
3385 (init_gnutls_functions): New function to initialize function pointers.
3386 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3387 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3388 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3389 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3390 (emacs_gnutls_write, emacs_gnutls_read)
3391 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3392 (Fgnutls_available_p): New function.
3393 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3394 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3395 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3397 * image.c: Include w32.h.
3398 (Vimage_type_cache): Delete.
3399 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3400 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3401 (w32_delayed_load): Move to w32.c.
3403 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3405 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3406 (w32_delayed_load): Move from image.c. When loading a library, record
3407 its filename in the :loaded-from property of the library id.
3408 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3409 Initialize and staticpro them.
3410 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3412 * process.c: Include lisp.h before w32.h, not after.
3413 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3414 instead of gnutls_record_check_pending.
3416 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3418 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3420 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3421 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3424 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3426 * xterm.c (x_set_frame_alpha): Do not set property on anything
3427 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3429 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3431 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3433 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3435 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3436 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3437 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3438 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3439 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3440 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3441 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3442 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3443 (Qgnutls_bootprop_callbacks_verify): Make static.
3445 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3447 * callproc.c: Indentation fixup.
3449 * sysdep.c (wait_for_termination_1): Make static.
3450 (wait_for_termination, interruptible_wait_for_termination):
3451 Move after wait_for_termination_1.
3453 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3455 * sysdep.c (interruptible_wait_for_termination): New function
3456 which is like wait_for_termination, but allows keyboard
3459 * callproc.c (Fcall_process): Add (:file "file") as an option for
3461 (Fcall_process_region): Ditto.
3463 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3465 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3466 rather than `XVECTOR (FOO)->size'.
3468 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3469 inttypes.h, as a gnulib replacement is used if it not available in
3472 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3474 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3475 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3476 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3478 * coding.c (coding_alloc_by_realloc): Error out if destination
3479 will grow beyond MOST_POSITIVE_FIXNUM.
3480 (decode_coding_emacs_mule): Abort if there isn't enough place in
3481 charbuf for the composition carryover bytes. Reserve an extra
3482 space for up to 2 characters produced in a loop.
3483 (decode_coding_iso_2022): Abort if there isn't enough place in
3484 charbuf for the composition carryover bytes.
3486 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3488 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3489 aborting when %lld or %lll format is passed.
3490 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3491 %llo or %llx format is passed. (Bug#8545)
3493 * window.c (window_scroll_line_based): Use a marker instead of
3494 simple variables to record original value of point. (Bug#7952)
3496 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3497 produced by %s or %c overflows available buffer space. (Bug#8545)
3499 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3501 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3502 (SIZE_MAX): Move defn after all includes, as they might #define it.
3504 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3506 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3508 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3510 * keyboard.c (Qdelayed_warnings_hook): Define.
3511 (command_loop_1): Run `delayed-warnings-hook'
3512 if Vdelayed_warnings_list is non-nil.
3513 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3514 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3516 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3518 * doprnt.c (doprnt): Don't return value smaller than the buffer
3519 size if the message was truncated. (Bug#8545).
3521 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3523 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3524 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3526 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3528 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3530 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3532 * makefile.w32-in: Update dependencies.
3534 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3536 Improve `doprnt' and its usage. (Bug#8545)
3537 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3538 `format_end'. Remove support for %l as a conversion specifier.
3539 Don't use xrealloc. Improve diagnostics when the %l size modifier
3540 is used. Update the commentary.
3542 * eval.c (verror): Simplify calculation of size_t.
3544 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3547 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3549 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3552 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3554 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3555 This makes this file independent of the recent pseudovector change.
3557 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3559 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3561 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3562 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3563 Remove unused local.
3564 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3566 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3567 GCC 4.6.0 optimizes based on type-based alias analysis.
3568 For example, if b is of type struct buffer * and v of type struct
3569 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3570 != &v->size, and therefore "v->size = 1; b->size = 2; return
3571 v->size;" must therefore return 1. This assumption is incorrect
3572 for Emacs, since it type-puns struct Lisp_Vector * with many other
3573 types. To fix this problem, this patch adds a new type struct
3574 vectorlike_header that documents the constraints on layout of vectors
3575 and pseudovectors, and helps optimizing compilers not get fooled
3576 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3577 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3578 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3580 (XSETPVECTYPE): Rewrite in terms of new macro.
3581 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3582 This is a bit clearer, and further avoids the possibility of
3583 undesirable aliasing.
3584 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3585 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3586 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3587 since Lisp_Subr is a special case (no "next" field).
3588 (ASIZE): Now uses header.size rather than size.
3589 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3590 to avoid the hassle of writing XVECTOR (foo)->header.size.
3591 (struct vectorlike_header): New type.
3592 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3593 object, to help avoid aliasing.
3594 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3595 (SUBRP): Likewise, since Lisp_Subr is a special case.
3596 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3597 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3598 (struct Lisp_Hash_Table): Combine first two members into a single
3599 struct vectorlike_header member. All uses of "size" and "next" members
3600 changed to be "header.size" and "header.next".
3601 * buffer.h (struct buffer): Likewise.
3602 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3603 * frame.h (struct frame): Likewise.
3604 * process.h (struct Lisp_Process): Likewise.
3605 * termhooks.h (struct terminal): Likewise.
3606 * window.c (struct save_window_data, struct saved_window): Likewise.
3607 * window.h (struct window): Likewise.
3608 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3609 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3610 * buffer.c (init_buffer_once): Likewise.
3611 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3613 * process.c (Fformat_network_address): Use local var for size,
3616 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3618 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3619 * data.c (atof): Remove decl; no longer used or needed.
3620 (digit_to_number): Move to lread.c.
3621 (Fstring_to_number): Use new string_to_number function, to be
3622 consistent with how the Lisp reader treats infinities and NaNs.
3623 Do not assume that floating-point numbers represent EMACS_INT
3624 without losing information; this is not true on most 64-bit hosts.
3625 Avoid double-rounding errors, by insisting on integers when
3626 parsing non-base-10 numbers, as the documentation specifies.
3627 * lisp.h (string_to_number): New decl, replacing ...
3628 (isfloat_string): Remove.
3629 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3630 (read1): Do not accept +. and -. as integers; this
3631 appears to have been a coding error. Similarly, do not accept
3632 strings like +-1e0 as floating point numbers. Do not report
3633 overflow for integer overflows unless the base is not 10 which
3634 means we have no simple and reliable way to continue.
3635 Break out the floating-point parsing into a new
3636 function string_to_number, so that Fstring_to_number parses
3637 floating point numbers consistently with the Lisp reader.
3638 (digit_to_number): Move here from data.c. Make it static inline.
3639 (E_CHAR, EXP_INT): Remove, replacing with ...
3640 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3641 (string_to_number): New function, replacing isfloat_string.
3642 This function checks for valid syntax and produces the resulting
3643 Lisp float number too. Rework it so that string-to-number
3644 no longer mishandles examples like "1.0e+". Use strtoumax,
3645 so that overflow for non-base-10 numbers is reported only when
3646 there's no portable and simple way to convert to floating point.
3648 * textprop.c (set_text_properties_1): Rewrite for clarity,
3649 and to avoid GCC warning about integer overflow.
3651 * intervals.h (struct interval): Use EMACS_INT for members
3652 where EMACS_UINT might cause problems. See
3653 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3654 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3655 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3657 (offset_intervals): Tell GCC not to worry about length overflow
3658 when negating a negative length.
3660 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3661 (overrun_check_free): Likewise.
3663 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3664 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3667 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3668 (gnutls_make_error): Rename local to avoid shadowing.
3669 (gnutls_emacs_global_deinit): ifdef out; not used.
3670 (Fgnutls_boot): Use const for pointer to readonly storage.
3671 Comment out unused local. Fix pointer signedness problems.
3673 * lread.c (openp): Don't stuff size_t into an 'int'.
3674 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3675 about possible signed overflow.
3677 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3678 (GDK_KEY_g): Don't define if already defined.
3679 (xg_prepare_tooltip): Avoid pointer signedness problem.
3680 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3682 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3683 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3685 * xfns.c (Fx_window_property): Simplify a bit,
3686 to make a bit faster and to avoid GCC 4.6.0 warning.
3687 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3689 * fns.c (internal_equal): Don't assume size_t fits in int.
3691 * alloc.c (compact_small_strings): Tighten assertion a little.
3693 Replace pEd with more-general pI, and fix some printf arg casts.
3694 * lisp.h (pI): New macro, generalizing old pEd macro to other
3695 conversion specifiers. For example, use "...%"pI"d..." rather
3696 than "...%"pEd"...".
3697 (pEd): Remove. All uses replaced with similar uses of pI.
3698 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3699 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3700 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3701 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3702 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3703 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3704 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3706 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3707 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3708 * print.c (safe_debug_print, print_object): Likewise.
3709 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3711 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3712 avoiding the 0 flag, which is not portable.
3713 * process.c (Fmake_network_process): Use pI to avoid cast.
3714 * region-cache.c (pp_cache): Likewise.
3715 * xdisp.c (decode_mode_spec): Likewise.
3716 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3717 behavior on 64-bit hosts with printf arg.
3718 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3719 (x_stop_queuing_selection_requests): Likewise.
3720 (x_get_window_property): Don't truncate byte count to an 'int'
3723 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3724 here, since it parses constructs like leading '-' and spaces,
3725 which are not wanted; and it overflows with large numbers.
3726 Instead, simply match F[0-9]+, which is what is wanted anyway.
3728 * alloc.c: Remove unportable assumptions about struct layout.
3729 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3730 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3731 (allocate_vectorlike, make_pure_vector): Use the new macros,
3732 plus offsetof, to remove unportable assumptions about struct layout.
3733 These assumptions hold on all porting targets that I know of, but
3734 they are not guaranteed, they're easy to remove, and removing them
3735 makes further changes easier.
3737 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3738 This doesn't fix a bug but makes the code clearer.
3739 (string_overrun_cookie): Now const. Use initializers that
3740 don't formally overflow signed char, to avoid warnings.
3741 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3742 can cause Emacs to crash when string overrun checking is enabled.
3743 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3744 multiple of sizeof (EMACS_INT); it need not be, if
3745 alignof(EMACS_INT) < sizeof (EMACS_INT).
3746 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3748 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3750 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3752 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3754 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3755 supposed to be handshaking. (Bug#8556)
3756 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3758 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3760 * lisp.h (Qdebug): List symbol.
3761 * eval.c (Qdebug): Restore global linkage.
3762 * keyboard.c (debug-on-event): New variable.
3763 (handle_user_signal): Break into debugger when debug-on-event
3764 matches the current signal symbol.
3766 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3768 * alloc.c (check_sblock, check_string_bytes)
3769 (check_string_free_list): Convert to standard C.
3771 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3773 * w32.c (emacs_gnutls_push): Fix typo.
3775 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3777 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3778 "cast to pointer from integer of different size".
3780 Improve doprnt and its use in verror. (Bug#8545)
3781 * doprnt.c (doprnt): Document the set of format control sequences
3782 supported by the function. Use SAFE_ALLOCA instead of always
3785 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3786 is one byte too soon. Don't use xrealloc; instead xfree and
3789 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3791 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3794 * gnutls.c: Renamed global_initialized to
3795 gnutls_global_initialized. Added internals for the
3796 :verify-hostname-error, :verify-error, and :verify-flags
3797 parameters of `gnutls-boot' and documented those parameters in the
3798 docstring. Start callback support.
3799 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3800 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3801 on error. Return error code.
3802 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3803 (emacs_gnutls_read): Likewise.
3804 (Fgnutls_boot): Return handshake error code.
3805 (emacs_gnutls_handle_error): New function.
3806 (wsaerror_to_errno): Likewise.
3808 * w32.h (emacs_gnutls_pull): Add prototype.
3809 (emacs_gnutls_push): Likewise.
3811 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3812 (emacs_gnutls_push): Likewise.
3814 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3816 * process.c (wait_reading_process_output): Check if GnuTLS
3817 buffered some data internally if no FDs are set for TLS
3820 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3821 (LIBS): Link to USER_LIBS.
3822 ($(BLD)/gnutls.$(0)): New target.
3824 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3826 * xdisp.c (handle_single_display_spec): Rename the
3827 display_replaced_before_p argument into display_replaced_p, to
3828 make it consistent with the commentary. Fix typos in the
3831 * textprop.c (syms_of_textprop): Remove dead code.
3832 (copy_text_properties): Delete obsolete commentary about an
3833 interface that was deleted long ago. Fix typos in the description
3836 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3837 to changes in oldXMenu/XMenu.h from 2011-04-16.
3838 <menu_help_message, prev_menu_help_message>: Constify.
3839 (IT_menu_make_room): menu->help_text is now `const char **';
3842 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3843 to changes in oldXMenu/XMenu.h from 2011-04-16.
3844 (struct XMenu): Declare `help_text' `const char **'.
3846 * xfaces.c <Qunspecified>: Make extern again.
3848 * syntax.c: Include sys/types.h before including regex.h, as
3851 * doc.c (get_doc_string): Improve the format passed to `error'.
3853 * doprnt.c (doprnt): Improve commentary.
3855 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3857 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3860 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3861 changes in globals.h immediately force recompilation.
3862 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3863 $(CURDIR)/s/ms-w32.h.
3864 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3866 * character.c (Fchar_direction): Function deleted.
3867 (syms_of_character): Don't defsubr it.
3868 <char-direction-table>: Deleted.
3870 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3872 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3873 * doprnt.c: Include limits.h.
3874 (SIZE_MAX): New macro.
3875 (doprnt): Return a size_t value. 2nd arg is now size_t.
3876 Many local variables are now size_t instead of int or unsigned.
3877 Improve overflow protection. Support `l' modifier for integer
3878 conversions. Support %l conversion. Don't assume an EMACS_INT
3879 argument for integer conversions and for %c.
3881 * lisp.h (doprnt): Restore prototype.
3883 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3886 * Makefile.in (base_obj): Add back doprnt.o.
3888 * deps.mk (doprnt.o): Add back prerequisites.
3889 (callint.o): Depend on character.h.
3891 * eval.c (internal_lisp_condition_case): Include the handler
3892 representation in the error message.
3893 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3894 when breaking from the loop.
3896 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3898 * callint.c (Fcall_interactively): When displaying error message
3899 about invalid control letter, pass the character's codepoint, not
3900 a pointer to its multibyte form. Improve display of the character
3901 in octal and display also its hex code.
3903 * character.c (char_string): Use %x to display the (unsigned)
3904 codepoint of an invalid character, to avoid displaying a bogus
3907 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3908 `error', not SYMBOL_NAME itself.
3910 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3911 character arguments to `error'.
3913 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3914 to `error' in error message about FINAL_CHAR argument. Make sure
3915 FINAL_CHAR is a character, and use %c when it is passed as
3916 argument to `error'.
3918 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3920 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3922 * w32.c: Include <time.h>.
3923 (sys_localtime): New function.
3925 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3927 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3929 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3931 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3933 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3936 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3938 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3939 gl_state.e_property when gl_state.object is Qt.
3941 * insdel.c (make_gap_larger): Remove limitation of buffer size
3944 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3946 * xdisp.c (lookup_glyphless_char_display)
3947 (produce_glyphless_glyph): Handle cons cell entry in
3948 glyphless-char-display.
3949 (Vglyphless_char_display): Document it.
3951 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3952 glyphless-char-display.
3954 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3956 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3958 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3960 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3961 definition for no-X builds.
3963 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3965 Static checks with GCC 4.6.0 and non-default toolkits.
3967 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3969 * process.c (keyboard_bit_set): Define only if SIGIO.
3970 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3971 (send_process): Repair possible setjmp clobbering.
3973 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3975 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3977 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3979 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3980 Define only if needed.
3982 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3983 by pacifying GCC about it. Maybe it's time to retire it?
3984 * xfaces.c (USG, __TIMEVAL__): Likewise.
3986 * dispextern.h (struct redisplay_interface): Rename param
3988 * termhooks.h (struct terminal): Likewise.
3989 * xterm.c (xembed_send_message): Likewise.
3991 * insdel.c (make_gap_smaller): Define only if
3992 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3994 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3997 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3998 so that we aren't warned about unused symbols.
4000 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4002 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4004 * xfns.c (x_real_positions): Mark locals as initialized.
4006 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4008 * xterm.c: Fix problems found by static analysis with other toolkits.
4009 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4010 (x_dispatch_event): Declare static if USE_GTK, and
4011 define if USE_GTK || USE_X_TOOLKIT.
4012 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4013 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4014 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4015 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4017 * xmenu.c (menu_help_callback): Pointer type fixes.
4018 Use const pointers when pointing at readonly data. Avoid pointer
4020 (FALSE): Remove unused macro.
4021 (update_frame_menubar): Remove unused decl.
4023 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4025 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4026 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4027 (single_menu_item): Rename local to avoid shadowing.
4029 * keyboard.c (make_lispy_event): Remove unused local var.
4031 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4032 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4034 * bitmaps: Change bitmaps from unsigned char back to the X11
4035 compatible char. Avoid the old compiler warnings about
4036 out-of-range initializers by using, for example, '\xab' rather
4039 * xgselect.c (xgselect_initialize): Check vs interface
4040 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4042 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4044 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4045 to read-only memory.
4047 * fns.c (vector): Remove; this old hack is no longer needed.
4049 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4051 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4053 * xrdb.c (x_load_resources): Omit unused local.
4055 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4056 (x_window): Rename locals to avoid shadowing.
4057 (USG): Use the kludged USG macro, to pacify gcc.
4059 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4060 (x_term_init): Remove local to avoid shadowing.
4062 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4064 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4065 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4067 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4069 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4071 Fix regex.c, syntax.c and friends for buffers > 2GB.
4072 * syntax.h (struct gl_state_s): Declare character position members
4075 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4077 * textprop.c (verify_interval_modification, interval_of):
4078 Declare arguments EMACS_INT.
4080 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4083 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4085 * indent.c (Fvertical_motion): Local variable it_start is now
4088 * regex.c (re_match, re_match_2, re_match_2_internal)
4089 (bcmp_translate, regcomp, regexec, print_double_string)
4090 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4091 (re_compile_pattern, re_exec): Declare arguments and local
4092 variables `size_t' and `ssize_t' and return values `regoff_t', as
4094 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4095 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4096 <compile_stack_type>: `size' and `avail' are now `size_t'.
4098 * regex.h <regoff_t>: Use ssize_t, not int.
4099 (re_search, re_search_2, re_match, re_match_2): Arguments that
4100 specify buffer/string position and length are now ssize_t and
4101 size_t. Return type is regoff_t.
4103 2011-04-16 Ben Key <bkey76@gmail.com>
4105 * nsfont.m: Fixed bugs in ns_get_family and
4106 ns_descriptor_to_entity that were caused by using free to
4107 deallocate memory blocks that were allocated by xmalloc (via
4108 xstrdup). This caused Emacs to crash when compiled with
4109 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4110 --enable-checking=xmallocoverrun). xfree is now used to
4111 deallocate these memory blocks.
4113 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4115 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4117 emacs_write: Accept and return EMACS_INT for sizes.
4118 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4120 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4121 Accept and return EMACS_INT.
4122 (emacs_gnutls_write): Return the number of bytes written on
4124 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4125 (emacs_read, emacs_write): Remove check for negative size, as the
4126 Emacs source code has been audited now.
4127 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4128 (emacs_read, emacs_write): Use it.
4129 * process.c (send_process): Adjust to the new signatures of
4130 emacs_write and emacs_gnutls_write. Do not attempt to store
4131 a byte offset into an 'int'; it might overflow.
4132 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4134 * sound.c: Don't assume sizes fit in 'int'.
4135 (struct sound_device.period_size, alsa_period_size):
4136 Return EMACS_INT, not int.
4137 (struct sound_device.write, vox_write, alsa_write):
4138 Accept EMACS_INT, not int.
4139 (wav_play, au_play): Use EMACS_INT to store sizes and to
4140 record read return values.
4142 2011-04-15 Ben Key <bkey76@gmail.com>
4144 * keyboard.c (Qundefined): Don't declare static since it is used
4146 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4147 static since they are used in nsfont.m.
4149 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4151 * process.c (Qprocessp): Don't declare static.
4152 * lisp.h (Qprocessp): Declare again.
4154 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4156 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4158 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4160 Improve C-level modularity by making more things 'static'.
4162 Don't publish debugger-only interfaces to other modules.
4163 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4164 (verify_bytepos, count_markers): Move decls to the only modules
4166 * region-cache.h (pp_cache): Likewise.
4167 * window.h (check_all_windows): Likewise.
4168 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4170 * sysdep.c (croak): Now static, if
4171 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4172 * syssignal.h (croak): Declare only if not static.
4174 * alloc.c (refill_memory_reserve): Now static if
4175 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4176 * lisp.h (refill_memory_reserve): Declare only if not static.
4178 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4179 Define only if USE_LUCID.
4181 * xrdb.c (x_customization_string, x_rm_string): Now static.
4183 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4184 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4186 * xdisp.c (draw_row_with_mouse_face): Now static.
4187 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4189 * window.h (check_all_windows): Mark externally visible.
4191 * window.c (window_deletion_count): Now static.
4193 * undo.c: Make symbols static if they're not exported.
4194 (last_undo_buffer, last_boundary_position, pending_boundary):
4197 * textprop.c (interval_insert_behind_hooks): Now static.
4198 (interval_insert_in_front_hooks): Likewise.
4200 * term.c: Make symbols static if they're not exported.
4201 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4202 (max_frame_lines, tty_set_terminal_modes):
4203 (tty_reset_terminal_modes, tty_turn_off_highlight):
4204 (get_tty_terminal): Now static.
4205 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4206 * termhooks.h (term_mouse_moveto): Do not declare if
4208 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4209 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4211 * sysdep.c: Make symbols static if they're not exported.
4212 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4214 (sigprocmask_set, full_mask): Remove; unused.
4215 (wait_debugging): Mark as visible.
4216 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4217 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4219 * syntax.c (syntax_temp): Define only if !__GNUC__.
4221 * sound.c (current_sound_device, current_sound): Now static.
4223 * search.c (searchbufs, searchbuf_head): Now static.
4225 * scroll.c (scroll_cost): Remove; unused.
4226 * dispextern.h (scroll_cost): Remove decl.
4228 * region-cache.h (pp_cache): Mark as externally visible.
4230 * process.c: Make symbols static if they're not exported.
4231 (process_tick, update_tick, create_process, chan_process):
4232 (Vprocess_alist, proc_buffered_char, datagram_access):
4233 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4234 (deactivate_process): Mark defn as static, as well as decl.
4235 * lisp.h (create_process): Remove decl.
4236 * process.h (chan_process, Vprocess_alist): Remove decls.
4238 * print.c: Make symbols static if they're not exported.
4239 (print_depth, new_backquote_output, being_printed, print_buffer):
4240 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4241 (print_interval, print_number_index, initial_stderr_stream):
4243 * lisp.h (Fprinc): Remove decl.
4244 (debug_output_compilation_hack): Mark as externally visible.
4246 * sysdep.c (croak): Move decl from here to syssignal.h.
4247 * syssignal.h (croak): Put it here, so the API can be checked when
4248 'croak' is called from dissociate_if_controlling_tty.
4250 * minibuf.c: Make symbols static if they're not exported.
4251 (minibuf_save_list, choose_minibuf_frame): Now static.
4252 * lisp.h (choose_minibuf_frame): Remove decl.
4254 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4256 * lread.c: Make symbols static if they're not exported.
4257 (read_objects, initial_obarray, oblookup_last_bucket_number):
4259 (make_symbol): Remove; unused.
4260 * lisp.h (initial_obarray, make_symbol): Remove decls.
4262 * keyboard.c: Make symbols static if they're not exported.
4263 (single_kboard, recent_keys_index, total_keys, recent_keys):
4264 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4265 (this_single_command_key_start, echoing, last_auto_save):
4266 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4267 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4268 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4269 (Vlispy_mouse_stem, double_click_count):
4271 (force_auto_save_soon): Define only if SIGDANGER.
4272 (ignore_mouse_drag_p): Now static if
4273 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4274 (print_help): Remove; unused.
4275 (stop_character, last_timer_event): Mark as externally visible.
4276 * keyboard.h (ignore_mouse_drag_p): Declare only if
4277 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4278 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4279 * lisp.h (echoing): Remove decl.
4280 (force_auto_save_soon): Declare only if SIGDANGER.
4281 * xdisp.c (redisplay_window): Simplify code, to make it more
4282 obvious that ignore_mouse_drag_p is not accessed if !defined
4283 USE_GTK && !defined HAVE_NS.
4285 * intervals.c: Make symbols static if they're not exported.
4286 (merge_properties_sticky, merge_interval_right, delete_interval):
4288 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4290 * insdel.c: Make symbols static if they're not exported.
4291 However, leave prepare_to_modify_buffer alone. It's never
4292 called from outside this function, but that appears to be a bug.
4293 (combine_after_change_list, combine_after_change_buffer):
4294 (adjust_after_replace, signal_before_change): Now static.
4295 (adjust_after_replace_noundo): Remove; unused.
4296 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4297 (signal_before_change): Remove decls.
4299 * indent.c (val_compute_motion, val_vmotion): Now static.
4301 * image.c: Make symbols static if they're not exported.
4302 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4304 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4305 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4307 * fringe.c (standard_bitmaps): Now static.
4308 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4310 * frame.c: Make symbols static if they're not exported.
4311 (x_report_frame_params, make_terminal_frame): Now static.
4312 (get_frame_param): Now static, unless HAVE_NS.
4313 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4314 (x_get_resource_string): Remove; not used.
4315 * frame.h (make_terminal_frame, x_report_frame_params):
4316 (x_get_resource_string); Remove decls.
4317 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4318 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4320 * font.c, fontset.c: Make symbols static if they're not exported.
4321 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4322 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4323 * font.c (font_close_object): Now static.
4324 * font.h (font_close_object): Remove.
4325 * fontset.c (FONTSET_OBJLIST): Remove.
4326 (free_realized_fontset) #if-0 the body, which does nothing.
4327 (face_suitable_for_char_p): #if-0, as it's never called.
4328 * fontset.h (face_suitable_for_char_p): Remove decl.
4329 * xfaces.c (face_at_string_position):
4330 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4331 since 0 is always ASCII.
4333 * fns.c (weak_hash_tables): Now static.
4335 * fileio.c: Make symbols static if they're not exported.
4336 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4337 (Vwrite_region_annotation_buffers): Now static.
4339 * eval.c: Make symbols static if they're not exported.
4340 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4341 * lisp.h (backtrace_list): Remove decl.
4343 * emacs.c: Make symbols static if they're not exported.
4344 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4345 (fatal_error_code, fatal_error_signal_hook, standard_args):
4347 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4348 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4349 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4350 * lisp.h (fatal_error_signal_hook): Remove decl.
4351 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4353 * editfns.c: Move a (normally-unused) function to its only use.
4354 * editfns.c, lisp.h (get_operating_system_release): Remove.
4355 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4356 worth the hassle of breaking this out.
4358 * xterm.c: Make symbols static if they're not exported.
4359 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4360 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4361 (x_destroy_window, x_delete_display):
4363 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4364 (x_mouse_leave): Remove; unused.
4365 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4366 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4367 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4369 (x_mouse_leave): Declare only if WINDOWSNT.
4370 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4371 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4374 * ftxfont.c: Make symbols static if they're not exported.
4375 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4377 * font.h (ftxfont_driver): Likewise.
4379 * xfns.c: Make symbols static if they're not exported.
4380 (x_last_font_name, x_display_info_for_name):
4381 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4382 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4383 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4384 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4385 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4386 (last_show_tip_args): Now static.
4387 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4388 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4389 (x_screen_planes): Remove; unused.
4390 * dispextern.h (x_screen_planes): Remove decl.
4392 * dispnew.c: Make symbols static if they're not exported.
4393 * dispextern.h (redraw_garbaged_frames, scrolling):
4394 (increment_row_positions): Remove.
4395 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4396 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4398 (redraw_garbaged_frames): Remove; unused.
4400 * xfaces.c: Make symbols static if they're not exported.
4401 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4403 * xterm.h (defined_color): Remove decls.
4404 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4405 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4406 (menu_face_changed_default, defined_color, free_realized_face):
4407 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4408 (ascii_face_of_lisp_face): Remove; unused.
4410 * xdisp.c: Make symbols static if they're not exported.
4411 * dispextern.h (scratch_glyph_row, window_box_edges):
4412 (glyph_to_pixel_coords, set_cursor_from_row):
4413 (get_next_display_element, set_iterator_to_next):
4414 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4415 (show_mouse_face): Remove decls
4416 * frame.h (message_buf_print): Likewise.
4417 * lisp.h (pop_message, set_message, check_point_in_composition):
4419 * xterm.h (set_vertical_scroll_bar): Likewise.
4420 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4421 (message_buf_print, scratch_glyph_row, displayed_buffer):
4422 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4423 (get_next_display_element, show_mouse_face, window_box_edges):
4424 (frame_to_window_pixel_xy, check_point_in_composition):
4425 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4426 (glyph_to_pixel_coords): Remove; unused.
4428 * dired.c (file_name_completion): Now static.
4430 * dbusbind.c (xd_in_read_queued_messages): Now static.
4432 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4433 * data.c (circular_list_error): Remove.
4435 * commands.h (last_point_position, last_point_position_buffer):
4436 (last_point_position_window): Remove decls.
4437 * keyboard.c: Make these variables static.
4439 * coding.h (coding, code_convert_region, encode_coding_gap):
4441 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4442 (iso_code_class, detect_coding, code_convert_region): Now static.
4443 (encode_coding_gap): Remove; unused.
4445 * chartab.c (chartab_chars, chartab_bits): Now static.
4447 * charset.h (charset_iso_8859_1): Remove decl.
4448 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4451 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4452 * ccl.c (Vccl_program_table): Now static.
4453 (check_ccl_update): Remove; unused.
4455 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4456 * category.h: ... from here.
4457 * category.c (check_category_table, set_category_set): Now static.
4459 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4460 * lisp.h: Remove these decls.
4462 * buffer.c (buffer_count): Remove unused var.
4464 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4465 so that it's not optimized away.
4466 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4467 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4468 exported only to the debugger.
4470 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4471 * atimer.h (run_all_atimers): Remove; not exported.
4473 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4474 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4475 was inaccessible from Lisp.
4476 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4477 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4479 alloc.c: Import and export fewer symbols, and remove unused items.
4480 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4482 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4483 it's not optimized away by whole-program optimization.
4484 (message_enable_multibyte, free_misc): Remove.
4485 (catchlist, handlerlist, mark_backtrace):
4486 Declare only if BYTE_MARK_STACK.
4487 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4488 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4489 (message_enable_multibyte): Remove decl.
4490 (free_misc, interval_free_list, float_block, float_block_index):
4491 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4492 (cons_free_list, last_marked_index):
4494 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4495 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4496 (mark_backtrace): Define only if BYTE_MARK_STACK.
4497 * xdisp.c (message_enable_multibyte): Now static.
4499 Declare Lisp_Object Q* variables to be 'static' if not exported.
4500 This makes it easier for human readers (and static analyzers)
4501 to see whether these variables are used from other modules.
4502 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4503 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4504 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4505 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4506 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4507 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4508 * xmenu.c, xselect.c:
4509 Declare Q* vars static if they are not used in other modules.
4510 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4511 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4512 Remove decls of unexported vars.
4513 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4515 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4517 Make Emacs functions such as Fatom 'static' by default.
4518 This makes it easier for human readers (and static analyzers)
4519 to see whether these functions can be called from other modules.
4520 DEFUN now defines a static function. To make the function external
4521 so that it can be used in other C modules, use the new macro DEFUE.
4522 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4523 (Finit_image_library):
4524 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4525 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4526 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4527 Remove decls, since these functions are now static.
4528 (Funintern, Fget_internal_run_time): New decls, since these functions
4529 were already external.
4531 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4532 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4533 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4534 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4535 * keyboard.c, keymap.c, lread.c:
4536 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4537 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4538 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4539 Mark functions with DEFUE instead of DEFUN,
4540 if they are used in other modules.
4541 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4542 decls for now-static functions.
4543 * buffer.h (Fdelete_overlay): Remove decl.
4544 * callproc.c (Fgetenv_internal): Mark as internal.
4545 * composite.c (Fremove_list_of_text_properties): Remove decl.
4546 (Fcomposition_get_gstring): New forward static decl.
4547 * composite.h (Fcomposite_get_gstring): Remove decl.
4548 * dired.c (Ffile_attributes): New forward static decl.
4549 * doc.c (Fdocumntation_property): New forward static decl.
4550 * eval.c (Ffetch_bytecode): New forward static decl.
4551 (Funintern): Remove extern decl; now in .h file where it belongs.
4552 * fileio.c (Fmake_symbolic_link): New forward static decl.
4553 * image.c (Finit_image_library): New forward static decl.
4554 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4555 * intervals.h (Fprevious_property_change):
4556 (Fremove_list_of_text_properties): Remove decls.
4557 * keyboard.c (Fthis_command_keys): Remove decl.
4558 (Fcommand_execute): New forward static decl.
4559 * keymap.c (Flookup_key): New forward static decl.
4560 (Fcopy_keymap): Now static.
4561 * keymap.h (Flookup_key): Remove decl.
4562 * process.c (Fget_process): New forward static decl.
4563 (Fprocess_datagram_address): Mark as internal.
4564 * syntax.c (Fsyntax_table_p): New forward static decl.
4565 (skip_chars): Remove duplicate decl.
4566 * textprop.c (Fprevious_property_change): New forward static decl.
4567 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4569 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4570 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4572 * editfns.c (Fformat): Remove unreachable code.
4574 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4576 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4579 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4581 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4582 when at ZV. (Bug#8487)
4584 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4586 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4588 * keyboard.c (parse_tool_bar_item): Likewise.
4589 * sound.c (sound_cleanup, alsa_close): Likewise.
4590 * termcap.c (tgetent): Likewise.
4591 * xfns.c (x_default_font_parameter): Likewise.
4592 * xsettings.c (read_and_apply_settings): Likewise.
4594 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4595 (overrun_check_free): Protoize.
4597 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4599 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4600 since callers should never pass a negative size.
4601 Change the signature to match that of plain 'read' and 'write'; see
4602 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4603 * lisp.h: Update prototypes of emacs_write and emacs_read.
4605 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4607 * xdisp.c (redisplay_window): Don't try to determine the character
4608 position of the scroll margin if the window start point w->startp
4609 is outside the buffer's accessible region. (Bug#8468)
4611 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4613 Fix write-region and its subroutines for buffers > 2GB.
4614 * fileio.c (a_write, e_write): Modify declaration of arguments and
4615 local variables to support buffers larger than 2GB.
4616 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4618 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4619 argument, local variables, and return value.
4621 * lisp.h: Update prototypes of emacs_write and emacs_read.
4623 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4625 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4627 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4629 Fix more problems found by GCC 4.6.0's static checks.
4631 * xdisp.c (vmessage): Use a better test for character truncation.
4633 * charset.c (load_charset_map): <, not <=, for optimization,
4634 and to avoid potential problems with integer overflow.
4635 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4636 * casetab.c (set_identity, shuffle): Likewise.
4637 * editfns.c (Fformat): Likewise.
4638 * syntax.c (skip_chars): Likewise.
4640 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4641 This also lets GCC 4.6.0 generate slightly better loop code.
4643 * callint.c (Fcall_interactively): <, not <=, for optimization.
4644 (Fcall_interactively): Count the number of arguments produced,
4645 not the number of arguments given. This is simpler and lets GCC
4646 4.6.0 generate slightly better code.
4648 * ftfont.c: Distingish more carefully between FcChar8 and char.
4649 The previous code passed unsigned char * to a functions like
4650 strlen and xstrcasecmp that expect char *, which does not
4651 conform to the C standard.
4652 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4653 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4654 char * when the C standard requires it.
4656 * keyboard.c (read_char): Remove unused var.
4658 * eval.c: Port to Windows vsnprintf (Bug#8435).
4660 (SIZE_MAX): Define if the headers do not.
4661 (verror): Do not give up if vsnprintf returns a negative count.
4662 Instead, grow the buffer. This ports to Windows vsnprintf, which
4663 does not conform to C99. Problem reported by Eli Zaretskii.
4664 Also, simplify the allocation scheme, by avoiding the need for
4665 calling realloc, and removing the ALLOCATED variable.
4667 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4669 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4670 But keep the doprint source code for now, as we might revamp it
4671 and use it again (Bug#8435).
4672 * lisp.h (doprnt): Remove.
4673 * Makefile.in (base_obj): Remove doprnt.o.
4674 * deps.mk (doprnt.o): Remove.
4676 error: Print 32- and 64-bit integers portably (Bug#8435).
4677 Without this change, on typical 64-bit hosts error ("...%d...", N)
4678 was used to print both 32- and 64-bit integers N, which relied on
4680 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4682 * lisp.h (error, verror): Mark as printf-like functions.
4683 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4684 Report overflow in size calculations when allocating printf buffer.
4685 Do not truncate output string at its first null byte.
4686 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4687 Truncate the output at a character boundary, since vsnprintf does not
4689 * charset.c (check_iso_charset_parameter): Convert internal
4690 character to string before calling 'error', since %c now has the
4692 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4693 overflow when computing char to be passed to 'error'. Do not
4694 pass Lisp_Object to 'error'; pass the integer instead.
4695 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4696 formatted with plain %d.
4698 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4700 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4702 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4704 * xterm.c (x_catch_errors): Remove duplicate declaration.
4706 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4708 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4710 2011-04-10 Jim Meyering <meyering@redhat.com>
4712 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4713 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4714 return ssize_t not "int", and use size_t as the buffer length.
4715 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4716 * gnutls.h: Update declarations.
4717 * process.c (read_process_output): Use ssize_t, to match.
4718 (send_process): Likewise.
4720 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4722 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4724 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4726 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4727 Use unsigned char, to match FcChar8 type definition.
4729 * xterm.c (handle_one_xevent):
4730 * xmenu.c (create_and_show_popup_menu):
4731 * xselect.c (x_decline_selection_request)
4732 (x_reply_selection_request): Avoid type-punned deref of X events.
4734 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4736 Fix some uses of `int' instead of EMACS_INT.
4737 * search.c (string_match_1, fast_string_match)
4738 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4739 (scan_buffer, find_next_newline_no_quit)
4740 (find_before_next_newline, search_command, Freplace_match)
4741 (Fmatch_data): Make some `int' variables be EMACS_INT.
4743 * xdisp.c (display_count_lines): 3rd argument and return value now
4744 EMACS_INT. All callers changed.
4745 (pint2hrstr): Last argument is now EMACS_INT.
4747 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4748 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4749 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4750 (decode_coding_utf_16, decode_coding_emacs_mule)
4751 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4752 (decode_coding_ccl, decode_coding_charset)
4753 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4754 (decode_coding_iso_2022, decode_coding_emacs_mule)
4755 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4756 <char_offset, last_offset>: Declare EMACS_INT.
4757 (encode_coding_utf_8, encode_coding_utf_16)
4758 (encode_coding_emacs_mule, encode_invocation_designation)
4759 (encode_designation_at_bol, encode_coding_iso_2022)
4760 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4761 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4763 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4764 (encode_invocation_designation): Last argument P_NCHARS is now
4766 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4767 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4769 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4772 * ccl.c (Fccl_execute_on_string): Declare some variables
4775 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4777 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4779 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4781 * process.c (Fformat_network_address): Doc fix.
4783 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4785 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4787 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4789 * keyboard.c (read_char): Call Lisp function help-form-show,
4790 instead of using internal_with_output_to_temp_buffer.
4791 (Qhelp_form_show): New var.
4792 (syms_of_keyboard): Use DEFSYM macro.
4794 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4796 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4798 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4800 * process.c (Flist_processes): Remove to Lisp.
4801 (list_processes_1): Delete.
4803 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4805 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4807 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4809 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4811 Fix more problems found by GCC 4.6.0's static checks.
4813 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4815 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4817 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4819 * xdisp.c (vmessage): Mark as a printf-like function.
4821 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4823 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4825 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4826 printf-like functions.
4827 (tiff_load): Add casts to remove these marks before passing them
4828 to system-supplied API.
4830 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4832 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4833 This avoids several warnings with gcc -Wstrict-overflow.
4834 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4835 directly, rather than having caller test rule sign. This avoids
4836 some unnecessary tests.
4837 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4838 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4839 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4841 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4842 (xfont_open): Avoid unnecessary tests.
4844 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4846 * composite.h, composite.c (composition_gstring_put_cache):
4847 Use EMACS_INT, not int, for length.
4849 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4850 breaking out part of COMPOSITION_DECODE_RULE.
4851 (COMPOSITION_DECODE_RULE): Use it.
4852 * composite.c (get_composition_id): Remove unused local vars,
4853 by using the new macro.
4855 * textprop.c (set_text_properties_1): Change while to do-while,
4856 since the condition is always true at first.
4858 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4859 (interval_deletion_adjustment): Return unsigned value.
4862 * process.c (list_processes_1, create_pty, read_process_output):
4863 (exec_sentinel): Remove vars that were set but not used.
4864 (create_pty): Remove unnecessary "volatile"s.
4865 (Fnetwork_interface_info): Avoid possibility of int overflow.
4866 (read_process_output): Do adaptive read buffering even if carryover.
4867 (read_process_output): Simplify nbytes computation if buffered.
4869 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4871 * syntax.c (scan_words): Remove var that was set but not used.
4872 (update_syntax_table): Use unsigned instead of int.
4874 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4875 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4876 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4878 * print.c (print_error_message): Avoid int overflow.
4880 * font.c (font_list_entities): Redo for clarity,
4881 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4883 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4884 (font_score): Avoid potential overflow in diff calculation.
4886 * fns.c (substring_both): Remove var that is set but not used.
4887 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4889 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4891 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4892 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4893 can always succeed if overflow has undefined behavior.
4895 * search.c (boyer_moore, wordify): Remove vars set but not used.
4896 (wordify): Omit three unnecessary tests.
4898 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4899 All callers changed. This avoids the need for an unused var.
4901 * casefiddle.c (casify_region): Remove var that is set but not used.
4903 * dired.c (file_name_completion): Remove var that is set but not used.
4905 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4907 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4908 (Finsert_file_contents): Remove unnecessary code checking fd.
4910 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4911 Check for integer overflow on size calculations.
4913 * buffer.c (Fprevious_overlay_change): Remove var that is set
4916 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4917 Remove vars that are set but not used.
4918 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4919 (timer_check_2): Mark vars as initialized.
4921 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4923 * image.c (lookup_image): Remove var that is set but not used.
4924 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4926 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4927 that are set but not used.
4929 * xfns.c (make_invisible_cursor): Don't return garbage
4930 if XCreateBitmapFromData fails (Bug#8410).
4932 * xselect.c (x_get_local_selection, x_handle_property_notify):
4933 Remove vars that are set but not used.
4935 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4936 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4938 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4939 Remove var that is set but not used.
4940 (scroll_bar_windows_size): Now size_t, not int.
4941 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4944 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4945 (map_tty_color) [!defined MSDOS]: Likewise.
4947 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4949 * coding.c: Remove vars that are set but not used.
4950 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4951 All callers changed.
4952 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4953 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4954 (decode_coding_charset): Remove vars that are set but not used.
4956 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4957 that is set but not used.
4959 * print.c (print_object): Remove var that is set but not used.
4961 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4962 The gnulib version avoids calling malloc in the usual case,
4963 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4964 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4965 * filelock.c (current_lock_owner): Likewise.
4966 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4967 * sysdep.c: Include allocator.h, careadlinkat.h.
4968 (emacs_no_realloc_allocator): New static constant.
4969 (emacs_readlink): New function.
4970 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4971 ../lib/careadlinkat.h.
4973 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4975 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4976 first non-nil return value).
4978 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4980 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4981 if not defined (Bug#8403).
4983 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4985 * xdisp.c (display_count_lines): Remove parameter `start',
4986 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4987 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4988 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4989 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4990 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4991 and thereabouts. All callers changed.
4992 (get_per_char_metric): Remove parameter `f', unused since
4993 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4995 2011-04-02 Jim Meyering <meyering@redhat.com>
4997 do not dereference NULL upon failed strdup
4998 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4999 (ns_get_family): Likewise.
5001 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5003 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5005 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5007 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5010 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5012 Add lexical binding.
5014 * window.c (Ftemp_output_buffer_show): New fun.
5015 (Fsave_window_excursion):
5016 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5018 * lread.c (lisp_file_lexically_bound_p): New function.
5019 (Fload): Bind Qlexical_binding.
5020 (readevalloop): Remove `evalfun' arg.
5021 Bind Qinternal_interpreter_environment.
5022 (Feval_buffer): Bind Qlexical_binding.
5023 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5025 (syms_of_lread): Declare `lexical-binding'.
5027 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5029 * keyboard.c (eval_dyn): New fun.
5030 (menu_item_eval_property): Use it.
5032 * image.c (parse_image_spec): Use Ffunctionp.
5034 * fns.c (concat, mapcar1): Accept byte-code-functions.
5036 * eval.c (Fsetq): Handle lexical vars.
5037 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5038 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5039 (FletX, Flet): Obey lexical binding.
5040 (Fcommandp): Handle closures.
5041 (Feval): New `lexical' arg.
5042 (eval_sub): New function extracted from Feval. Use it almost
5043 everywhere where Feval was used. Look up vars in lexical env.
5045 (Ffunctionp): Move from subr.el.
5046 (Ffuncall): Handle closures.
5047 (apply_lambda): Remove `eval_flags'.
5048 (funcall_lambda): Handle closures and new byte-code-functions.
5049 (Fspecial_variable_p): New function.
5050 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5051 but without exporting it to Lisp.
5053 * doc.c (Fdocumentation, store_function_docstring):
5054 * data.c (Finteractive_form): Handle closures.
5056 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5059 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5061 (exec_byte_code): New function extracted from Fbyte_code to handle new
5062 calling convention for byte-code-functions. Add new byte-codes.
5064 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5066 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5068 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5070 * xdisp.c (redisplay_internal): Fix prototype.
5072 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5074 * xdisp.c (SCROLL_LIMIT): New macro.
5075 (try_scrolling): Use it when setting scroll_limit.
5076 Limit scrolling to 100 screen lines.
5077 (redisplay_window): Even when falling back on "recentering",
5078 position point in the window according to scroll-conservatively,
5079 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5081 (try_scrolling): When point is above the window, allow searching
5082 as far as scroll_max, or one screenful, to compute vertical
5083 distance from PT to the scroll margin position. This prevents
5084 try_scrolling from unnecessarily failing when
5085 scroll-conservatively is set to a value slightly larger than the
5086 window height. Clean up the case of PT below the margin at bottom
5087 of window: scroll_max can no longer be INT_MAX. When aggressive
5088 scrolling is in use, don't let point enter the opposite scroll
5089 margin as result of the scroll.
5090 (syms_of_xdisp) <scroll-conservatively>: Document the
5091 threshold of 100 lines for never-recentering scrolling.
5093 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5095 * dispextern.h (move_it_by_lines):
5096 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5097 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5098 (message_log_check_duplicate): Remove parameters `prev_bol' and
5099 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5100 (redisplay_internal): Remove parameter `preserve_echo_area',
5101 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5103 * indent.c (Fvertical_motion):
5104 * window.c (window_scroll_pixel_based, Frecenter):
5105 Don't pass `need_y_p' to `move_it_by_lines'.
5107 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5109 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5110 steal a few bits to be more compact.
5111 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5112 Remove unneeded casts.
5114 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5116 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5118 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5119 binding" message (bug#7967).
5121 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5123 Fix more problems found by GCC 4.6.0's static checks.
5125 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5126 Remove unused local var.
5128 * editfns.c (Fmessage_box): Remove unused local var.
5130 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5131 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5132 Omit unused local vars.
5133 * window.c (shrink_windows): Omit unused local var.
5134 * menu.c (digest_single_submenu): Omit unused local var.
5135 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5136 Omit unused local var.
5138 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5139 Don't assume string length fits in int.
5140 (keyremap_step, read_key_sequence): Use size_t for sizes.
5141 (read_key_sequence): Don't check last_real_key_start redundantly.
5143 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5144 instead of alloca (Bug#8344).
5146 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5147 (Fbacktrace_frame): Don't assume nframes fits in int.
5149 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5151 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5154 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5156 * cm.c (calccost): Turn while-do into do-while, for clarity.
5158 * keyboard.c (syms_of_keyboard): Use the same style as later
5159 in this function when indexing through an array. This also
5160 works around GCC bug 48267.
5162 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5164 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5166 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5167 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5169 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5170 This avoids undefined behavior on integer overflow, and is a bit
5171 more convenient anyway since it is compared to a size_t variable.
5173 Variadic C functions now count arguments with size_t, not int.
5174 This avoids an unnecessary limitation on 64-bit machines, which
5175 caused (substring ...) to crash on large vectors (Bug#8344).
5176 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5177 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5178 All variadic functions and their callers changed accordingly.
5179 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5180 * data.c (arith_driver, float_arith_driver): Likewise.
5181 * editfns.c (general_insert_function): Likewise.
5182 * eval.c (struct backtrace.nargs, interactive_p)
5183 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5184 (funcall_lambda, mark_backtrace): Likewise.
5185 * fns.c (concat): Likewise.
5186 * frame.c (x_set_frame_parameters): Likewise.
5187 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5188 0 if not found, not -1. All callers changed.
5190 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5191 (stack_copy_size): Now size_t, not int.
5192 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5194 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5196 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5197 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5198 All callers changed.
5200 * lisp.h (multibyte_char_to_unibyte):
5201 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5202 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5203 * character.h (CHAR_TO_BYTE8):
5204 * cmds.c (internal_self_insert):
5205 * editfns.c (general_insert_function):
5206 * keymap.c (push_key_description):
5207 * search.c (Freplace_match):
5208 * xdisp.c (message_dolog, set_message_1): All callers changed.
5210 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5212 * keyboard.c (safe_run_hook_funcall): New function.
5213 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5214 don't set the hook to nil, but remove the offending function instead.
5215 (Qcommand_hook_internal): Remove, unused.
5216 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5217 Vcommand_hook_internal.
5219 * eval.c (enum run_hooks_condition): Remove.
5220 (funcall_nil, funcall_not): New functions.
5221 (run_hook_with_args): Call each function through a `funcall' argument.
5222 Remove `cond' argument, now redundant.
5223 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5224 (Frun_hook_with_args_until_failure): Adjust accordingly.
5225 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5227 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5229 * dispextern.h (string_buffer_position): Remove declaration.
5231 * print.c (strout): Remove parameter `multibyte', unused since
5232 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5234 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5235 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5236 All callers changed.
5238 * w32.c (_wsa_errlist): Use braces for struct initializers.
5240 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5241 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5242 All callers changed.
5243 (string_buffer_position): Likewise. Also, make static (it's never
5244 used outside xdisp.c).
5245 (cursor_row_p): Remove parameter `w', unused since
5246 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5247 (decode_mode_spec): Remove parameter `precision', introduced during
5248 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5249 All callers changed.
5251 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5253 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5255 2011-03-27 Anders Lindgren <andlind@gmail.com>
5257 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5258 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5259 (ns_update_auto_hide_menu_bar): New functions.
5260 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5261 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5262 ns_constrain_all_frames.
5263 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5264 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5266 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5268 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5270 2011-03-27 Glenn Morris <rgm@gnu.org>
5272 * syssignal.h: Replace RETSIGTYPE with void.
5273 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5274 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5275 Replace SIGTYPE with void everywhere.
5276 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5277 * s/template.h (SIGTYPE): Remove commented out definition.
5279 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5281 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5282 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5284 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5286 * w32.c (read_unc_volume): Use parameter `henum', instead of
5287 global variable `wget_enum_handle'.
5289 * keymap.c (describe_vector): Remove parameters `indices' and
5290 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5291 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5293 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5295 * keyboard.c (timer_check): Remove parameter `do_it_now',
5296 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5297 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5298 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5300 * keyboard.c (read_char):
5301 * w32menu.c (w32_menu_display_help):
5302 * xmenu.c (show_help_event, menu_help_callback):
5303 Adjust calls to `show_help_echo'.
5305 * gtkutil.c (xg_maybe_add_timer):
5306 * keyboard.c (readable_events):
5307 * process.c (wait_reading_process_output):
5308 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5310 * insdel.c (adjust_markers_gap_motion):
5311 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5312 (gap_left, gap_right): Don't call it.
5314 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5316 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5317 incurred during fontification.
5319 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5321 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5322 (DEFVAR_PER_BUFFER): Don't pass it.
5324 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5325 (scrolling_window): Don't pass it.
5327 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5329 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5331 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5333 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5334 of variables specific to SELinux and computation of `encoded_absname'.
5336 * image.c (XPutPixel): Remove unused variable `height'.
5338 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5340 * unexw32.c (get_section_info): Remove unused variable `section'.
5342 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5343 (system_process_attributes): Remove unused variable `sess'.
5344 (sys_read): Remove unused variable `err'.
5346 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5347 (w32_wnd_proc): Remove unused variable `isdead'.
5348 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5349 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5350 (x_create_tip_frame): Remove unused variable `tem'.
5352 * w32inevt.c (w32_console_read_socket):
5353 Remove unused variable `no_events'.
5355 * w32term.c (x_draw_composite_glyph_string_foreground):
5356 Remove unused variable `width'.
5358 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5360 * w32term.c (x_set_glyph_string_clipping):
5361 Don't pass uninitialized region to CombineRgn.
5363 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5365 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5366 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5367 (Fx_close_connection): Remove unused variable `i'.
5369 * w32font.c (w32font_draw): Return number of glyphs.
5370 (w32font_open_internal): Remove unused variable `i'.
5371 (w32font_driver): Add missing initializer.
5373 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5374 (fill_in_menu): Remove unused variable `items_added'.
5376 * w32term.c (last_mouse_press_frame): Remove static global variable.
5377 (w32_clip_to_row): Remove unused variable `f'.
5378 (x_delete_terminal): Remove unused variable `i'.
5380 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5381 (NOTHING): Remove unused static global variable.
5382 (uniscribe_check_otf): Remove unused variable `table'.
5383 (uniscribe_font_driver): Add missing initializers.
5385 2011-03-23 Julien Danjou <julien@danjou.info>
5387 * term.c (Fsuspend_tty, Fresume_tty):
5388 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5389 * window.c (temp_output_buffer_show):
5390 * insdel.c (signal_before_change):
5391 * frame.c (Fhandle_switch_frame):
5392 * fileio.c (Fdo_auto_save):
5393 * emacs.c (Fkill_emacs):
5394 * editfns.c (save_excursion_restore):
5395 * cmds.c (internal_self_insert):
5396 * callint.c (Fcall_interactively):
5397 * buffer.c (Fkill_all_local_variables):
5398 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5400 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5401 unconditionnaly since it does the check itself.
5403 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5405 Fix more problems found by GCC 4.5.2's static checks.
5407 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5408 the first time through the loop, since we know p0 < p1 then.
5409 This also avoids a gcc -Wstrict-overflow warning.
5411 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5412 leading to a memory leak, possible in functions like
5413 load_charset_map_from_file that can allocate an unbounded number
5414 of objects (Bug#8318).
5416 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5417 that could (at least in theory) be that large.
5419 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5420 This is less likely to overflow, and avoids undefined behavior if
5421 overflow does occur. All callers changed. Use strtoul to scan
5422 for the unsigned long integer.
5423 (pint2hrstr): Simplify and tune code slightly.
5424 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5426 * scroll.c (do_scrolling): Work around GCC bug 48228.
5427 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5429 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5430 This also avoids a warning with gcc -Wstrict-overflow.
5431 (validate_x_resource_name): Simplify count usage.
5432 This also avoids a warning with gcc -Wstrict-overflow.
5434 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5437 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5439 * process.c (Fmake_network_process): Use socklen_t, not int,
5440 where POSIX says socklen_t is required in portable programs.
5441 This fixes a porting bug on hosts like 64-bit HP-UX, where
5442 socklen_t is wider than int (Bug#8277).
5443 (Fmake_network_process, server_accept_connection):
5444 (wait_reading_process_output, read_process_output):
5447 * process.c: Rename or move locals to avoid shadowing.
5448 (list_processes_1, Fmake_network_process):
5449 (read_process_output_error_handler, exec_sentinel_error_handler):
5450 Rename or move locals.
5451 (Fmake_network_process): Define label "retry_connect" only if needed.
5452 (Fnetwork_interface_info): Fix pointer signedness.
5453 (process_send_signal): Add cast to avoid pointer signedness problem.
5454 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5455 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5457 Make tparam.h and terminfo.c consistent.
5458 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5459 Include tparam.h instead, since it declares them.
5460 * cm.h (PC): Remove extern decl; tparam.h now does this.
5461 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5462 * terminfo.c: Include tparam.h, to check interfaces.
5463 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5464 (tparam): Adjust signature to match interface in tparam.h;
5465 this removes some undefined behavior. Check that outstring and len
5466 are zero, which they always are with Emacs.
5467 * tparam.h (PC, BC, UP): New extern decls.
5469 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5470 (xftfont_open): Rename locals to avoid shadowing.
5472 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5473 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5474 (OTF_TAG_SYM): Omit macro if not needed.
5475 (ftfont_list): Remove unused local.
5476 (get_adstyle_property, ftfont_pattern_entity):
5477 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5478 Rename locals to avoid shadowing.
5480 * xfont.c (xfont_list_family): Mark var as initialized.
5482 * xml.c (make_dom): Now static.
5484 * composite.c (composition_compute_stop_pos): Rename local to
5486 (composition_reseat_it): Remove unused locals.
5487 (find_automatic_composition, composition_adjust_point): Likewise.
5488 (composition_update_it): Mark var as initialized.
5489 (find_automatic_composition): Mark vars as initialized,
5490 with a FIXME (Bug#8290).
5492 character.h: Rename locals to avoid shadowing.
5493 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5494 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5495 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5496 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5499 * textprop.c (property_change_between_p): Remove; unused.
5501 * intervals.c (interval_start_pos): Now static.
5503 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5505 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5506 Rename locals to avoid shadowing.
5508 * sound.c (wav_play, au_play, Fplay_sound_internal):
5509 Fix pointer signedness.
5510 (alsa_choose_format): Remove unused local var.
5511 (wav_play): Initialize a variable to 0, to prevent undefined
5512 behavior (Bug#8278).
5514 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5516 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5518 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5519 clobbering (Bug#8298).
5520 * sysdep.c (sys_subshell): Likewise.
5521 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5523 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5524 This should get cleaned up, so that child_setup has the
5525 same signature on all platforms.
5527 * callproc.c (call_process_cleanup): Now static.
5528 (relocate_fd): Rename locals to avoid shadowing.
5530 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5532 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5533 not to be necessary, and produces flickering.
5535 2011-03-20 Glenn Morris <rgm@gnu.org>
5537 * config.in: Remove file.
5539 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5541 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5542 are now in src/globals.h.
5543 (syms_of_minibuf): Remove spurious & from previous change.
5545 2011-03-20 Leo <sdl.web@gmail.com>
5547 * minibuf.c (completing-read-function): New variable.
5548 (completing-read-default): Rename from completing-read.
5549 (completing-read): Call completing-read-function.
5551 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5553 * xfaces.c (Fx_load_color_file):
5554 Read color file from absolute filename (bug#8250).
5556 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5558 * makefile.w32-in: Update dependencies.
5560 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5562 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5564 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5566 Fix more problems found by GCC 4.5.2's static checks.
5568 * process.c (make_serial_process_unwind, send_process_trap):
5569 (sigchld_handler): Now static.
5571 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5572 That way, the code declares only the vars that it needs.
5573 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5574 * s/cygwin.h (PTY_ITERATION): Likewise.
5575 * s/darwin.h (PTY_ITERATION): Likewise.
5576 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5578 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5579 * process.c (allocate_pty): Don't declare stb unless it's needed.
5581 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5582 (CONSTANTLIM): Remove; unused.
5583 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5584 Define only if needed.
5586 * unexelf.c (unexec): Name an expression,
5587 to avoid gcc -Wbad-function-cast warning.
5588 Use a different way to cause a compilation error if anyone uses
5589 n rather than nn, a way that does not involve shadowing.
5590 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5592 * deps.mk (unexalpha.o): Remove; unused.
5594 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5595 * unexec.h: New file.
5596 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5597 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5599 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5600 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5601 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5602 Change as necessary to match prototype in unexec.h.
5604 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5606 (back_comment, skip_chars): Mark vars as initialized.
5608 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5609 Rename locals to avoid shadowing.
5611 * lread.c (read1): Rewrite so as not to use empty "else".
5612 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5614 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5616 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5617 warning when compiling print.c.
5619 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5620 instead of using an uninitialized var.
5621 (font_sort_entities): Mark var as initialized.
5623 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5625 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5626 pointers to constants.
5627 (font_parse_fcname): Remove unused vars.
5628 (font_delete_unmatched): Now static.
5629 (font_get_spec): Remove; unused.
5630 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5631 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5632 Rename or move locals to avoid shadowing.
5634 * fns.c (require_nesting_list, require_unwind): Now static.
5635 (Ffillarray): Rename locals to avoid shadowing.
5637 * floatfns.c (domain_error2): Define only if needed.
5638 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5640 * alloc.c (mark_backtrace): Move decl from here ...
5641 * lisp.h: ... to here, so that it can be checked.
5643 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5644 (Fdefvar): Rewrite so as not to use empty "else".
5645 (lisp_indirect_variable): Name an expression,
5646 to avoid gcc -Wbad-function-cast warning.
5647 (Fdefvar): Rename locals to avoid shadowing.
5649 * callint.c (quotify_arg, quotify_args): Now static.
5650 (Fcall_interactively): Rename locals to avoid shadowing.
5651 Use const pointer when appropriate.
5653 * lisp.h (get_system_name, get_operating_system_release):
5654 Move decls here, to check interfaces.
5655 * process.c (get_operating_system_release): Move decl to lisp.h.
5656 * xrdb.c (get_system_name): Likewise.
5657 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5658 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5659 some of which prompt warnings from gcc -Wbad-function-cast.
5660 (Fformat_time_string, Fencode_time, Finsert_char):
5661 (Ftranslate_region_internal, Fformat):
5662 Rename or remove local vars to avoid shadowing.
5663 (Ftranslate_region_internal): Mark var as initialized.
5665 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5668 * lisp.h (eassert): Check that the argument compiles, even if
5669 ENABLE_CHECKING is not defined.
5671 * data.c (Findirect_variable): Name an expression, to avoid
5672 gcc -Wbad-function-cast warning.
5673 (default_value, arithcompare, arith_driver, arith_error): Now static.
5674 (store_symval_forwarding): Rename local to avoid shadowing.
5675 (Fmake_variable_buffer_local, Fmake_local_variable):
5676 Mark variables as initialized.
5677 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5679 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5680 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5681 Rename locals to avoid shadowing.
5682 (mark_stack): Move local variables into the #ifdef region where
5684 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5685 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5687 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5688 (GC_STRING_CHARS): Remove; not used.
5689 (Fmemory_limit): Cast sbrk's returned value to char *.
5691 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5692 avoids undefined behavior in theory.
5694 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5696 Use functions, not macros, for up- and down-casing (Bug#8254).
5697 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5698 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5699 to use the following functions instead of these macros.
5700 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5701 EMACS_INT, since callers assume the returned value fits in int.
5702 (upcase1): Likewise, for UPCASE_TABLE.
5703 (uppercasep, lowercasep, upcase): New static inline functions.
5704 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5705 the race-condition problem in the old DOWNCASE.
5707 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5708 Rename locals to avoid shadowing.
5709 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5710 (regex_compile, re_search_2, re_match_2_internal):
5711 Remove unused local vars.
5712 (FREE_VAR): Rewrite so as not to use empty "else",
5713 which gcc can warn about.
5714 (regex_compile, re_match_2_internal): Mark locals as initialized.
5715 (RETALLOC_IF): Define only if needed.
5716 (WORDCHAR_P): Likewise. This one is never needed, but is used
5717 only in a comment talking about a compiler bug, so put inside
5718 the #if 0 of that comment.
5719 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5720 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5723 * search.c (boyer_moore): Rename locals to avoid shadowing.
5724 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5725 (PREV_CHAR_BOUNDARY): Likewise.
5727 * search.c (simple_search): Remove unused var.
5729 * dired.c (compile_pattern): Move decl from here ...
5730 * lisp.h: ... to here, so that it can be checked.
5731 (struct re_registers): New forward decl.
5733 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5735 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5737 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5738 Rename locals to avoid shadowing.
5739 (Fvertical_motion): Mark locals as initialized.
5741 * casefiddle.c (casify_object, casify_region): Now static.
5742 (casify_region): Mark local as initialized.
5744 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5746 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5747 New macros, so that the caller can use some names other than
5748 gcpro1, gcpro2, etc.
5749 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5751 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5752 argument, for consistency with GCPRO2_VAR, etc: it is now the
5753 prefix of the variable, not the variable itself. All uses
5755 * dired.c (directory_files_internal, file_name_completion):
5756 Rename locals to avoid shadowing.
5758 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5759 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5760 dired.c's scmp function, had undefined behavior.
5761 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5762 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5763 * buffer.h: ... to here, because these macros use current_buffer,
5764 and the new implementation with inline functions needs to have
5765 current_buffer in scope now, rather than later when the macros
5767 (downcase, upcase1): New static inline functions.
5768 (DOWNCASE, UPCASE1): Reimplement using these functions.
5769 This avoids undefined behavior in expressions like
5770 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5771 from race conditions in accessing the global variables
5772 case_temp1 and case_temp2.
5773 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5774 * lisp.h (case_temp1, case_temp2): Remove their decls.
5775 * character.h (ASCII_CHAR_P): Move from here ...
5776 * lisp.h: ... to here, so that the inline functions mentioned
5779 * dired.c (directory_files_internal_unwind): Now static.
5781 * fileio.c (file_name_as_directory, directory_file_name):
5782 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5784 (file_name_as_directory): Use const pointers when appropriate.
5785 (Fexpand_file_name): Likewise. In particular, newdir might
5786 point at constant storage, so make it a const pointer.
5787 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5788 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5790 (Fset_file_times, Finsert_file_contents, auto_save_error):
5791 Rename locals to avoid shadowing.
5793 * minibuf.c (choose_minibuf_frame_1): Now static.
5794 (Ftry_completion, Fall_completions): Rename or remove locals
5797 * marker.c (bytepos_to_charpos): Remove; unused.
5799 * lisp.h (verify_bytepos, count_markers): New decls,
5800 so that gcc does not warn that these functions aren't declared.
5802 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5803 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5804 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5805 (copy_text): Remove unused local var.
5807 * filelock.c (within_one_second): Now static.
5808 (lock_file_1): Rename local to avoid shadowing.
5810 * buffer.c (fix_overlays_before): Mark locals as initialized.
5811 (fix_start_end_in_overlays): Likewise. This function should be
5812 simplified by using pointers-to-pointers, but that's a different
5814 (switch_to_buffer_1): Now static.
5815 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5816 (report_overlay_modification): Rename locals to avoid shadowing.
5818 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5819 Fix pointer signedness issue.
5820 (sys_subshell): Mark local as volatile if checking for lint,
5821 to suppress a gcc -Wclobbered warning that does not seem to be right.
5822 (MAXPATHLEN): Define only if needed.
5824 * process.c (serial_open, serial_configure): Move decls from here ...
5825 * systty.h: ... to here, so that they can be checked.
5827 * fns.c (get_random, seed_random): Move extern decls from here ...
5828 * lisp.h: ... to here, so that they can be checked.
5830 * sysdep.c (reset_io): Now static.
5831 (wait_for_termination_signal): Remove; unused.
5833 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5834 (copy_keymap_item, append_key, push_text_char_description):
5836 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5837 (DENSE_TABLE_SIZE): Remove; unused.
5838 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5839 (describe_map_tree):
5840 Rename locals to avoid shadowing.
5842 * keyboard.c: Declare functions static if they are not used elsewhere.
5843 (echo_char, echo_dash, cmd_error, top_level_2):
5844 (poll_for_input, handle_async_input): Now static.
5845 (read_char, kbd_buffer_get_event, make_lispy_position):
5846 (make_lispy_event, make_lispy_movement, apply_modifiers):
5847 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5848 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5849 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5850 (read_key_sequence, read_char): Mark locals as initialized.
5851 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5853 * keyboard.h (make_ctrl_char): New decl.
5854 (mark_kboards): Move decl here ...
5855 * alloc.c (mark_kboards): ... from here.
5857 * lisp.h (force_auto_save_soon): New decl.
5859 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5860 (DEFINE_DUMMY_FUNCTION): New macro.
5861 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5863 (main): Add casts to avoid warnings
5864 if GCC considers string literals to be constants.
5866 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5868 * dbusbind.c: Pointer signedness fixes.
5869 (xd_signature, xd_append_arg, xd_initialize):
5870 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5871 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5872 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5873 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5875 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5876 if GCC considers string literals to be constants.
5877 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5879 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5881 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5882 (print_preprocess, print_object): New macro to fix last change.
5884 * print.c (print_preprocess): Don't forget font objects.
5886 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5888 * emacs.c (USAGE3): Doc fixes.
5890 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5892 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5895 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5897 * lisp.h (VWindow_system, Qfile_name_history):
5898 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5899 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5900 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5902 * w32select.c: Don't #include "keyboard.h".
5903 (run_protected): Add extern declaration for waiting_for_input.
5905 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5906 * w32console.c (detect_input_pending, read_input_pending)
5907 (encode_terminal_code):
5908 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5909 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5910 (w32_system_caret_y, Qfile_name_history):
5911 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5912 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5913 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5914 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5915 * w32proc.c (Qlocal, report_file_error):
5916 * w32term.c (Vwindow_system, updating_frame):
5917 * w32uniscribe.c (initialized, uniscribe_font_driver):
5918 Remove unneeded extern declarations.
5920 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5922 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5924 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5926 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5927 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5928 These macros can no longer be used for assignment.
5930 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5931 Assign struct members directly, instead of using BUF_BEGV etc.
5932 (record_buffer_markers, fetch_buffer_markers): New functions for
5933 recording and fetching special buffer markers.
5934 (set_buffer_internal_1, set_buffer_temp): Use them.
5936 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5938 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5940 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5941 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5943 * xdisp.c (hscroll_window_tree):
5944 (reconsider_clip_changes): Use PT instead of BUF_PT.
5946 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5948 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5949 $(EMACS_ROOT)/lib/intprops.h.
5951 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5953 Fix more problems found by GCC 4.5.2's static checks.
5955 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5956 to unsigned char * to avoid compiler diagnostic.
5957 (xg_free_frame_widgets): Make it clear that a local variable is
5958 needed only if USE_GTK_TOOLTIP.
5959 (gdk_window_get_screen): Make it clear that this macro is needed
5960 only if USE_GTK_TOOLTIP.
5961 (int_gtk_range_get_value): New function, which avoids a diagnostic
5962 from gcc -Wbad-function-cast.
5963 (xg_set_toolkit_scroll_bar_thumb): Use it.
5964 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5965 diagnostic from gcc -Wbad-function-cast.
5966 (get_utf8_string, xg_get_file_with_chooser):
5967 Rename locals to avoid shadowing.
5968 (create_dialog): Move locals to avoid shadowing.
5970 * xgselect.c (xg_select): Remove unused var.
5972 * image.c (four_corners_best): Mark locals as initialized.
5973 (gif_load): Initialize transparent_p to zero (Bug#8238).
5974 Mark another local as initialized.
5975 (my_png_error, my_error_exit): Mark with NO_RETURN.
5977 * image.c (clear_image_cache): Now static.
5978 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5979 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5980 (x_edge_detection): Remove unnecessary cast that
5981 gcc -Wbad-function-cast diagnoses.
5982 (gif_load): Fix pointer signedness.
5983 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5984 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5986 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5988 Improve quality of tests for time stamp overflow.
5989 For example, without this patch (encode-time 0 0 0 1 1
5990 1152921504606846976) returns the obviously-bogus value (-948597
5991 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5992 reports time overflow. See
5993 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5994 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5995 * editfns.c: Include limits.h and intprops.h.
5996 (TIME_T_MIN, TIME_T_MAX): New macros.
5997 (time_overflow): Move earlier, to before first use.
5998 (hi_time, lo_time): New functions, for an accurate test for
6000 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6001 (Fget_internal_run_time): Don't assume time_t fits in int.
6002 (make_time): Use list2 instead of Fcons twice.
6003 (Fdecode_time): More accurate test for out-of-range times.
6004 (check_tm_member): New function.
6005 (Fencode_time): Use it, to test for out-of-range times.
6006 (lisp_time_argument): Don't rely on undefined left-shift and
6007 right-shift behavior when checking for time stamp overflow.
6009 * editfns.c (time_overflow): New function, refactoring common code.
6010 (Fformat_time_string, Fdecode_time, Fencode_time):
6011 (Fcurrent_time_string): Use it.
6013 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6014 * dired.c (make_time): Move to ...
6015 * editfns.c (make_time): ... here.
6016 * systime.h: Note the move.
6018 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6020 * fringe.c (update_window_fringes): Remove unused variables.
6022 * unexmacosx.c (copy_data_segment): Also copy __got section.
6025 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6027 * termcap.c [MSDOS]: Include "msdos.h".
6028 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6029 Constify `char *' arguments and their references according to
6030 prototypes in tparam.h.
6032 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6034 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6035 Adapt all references accordingly.
6037 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6039 2011-03-11 Tom Tromey <tromey@redhat.com>
6041 * buffer.c (syms_of_buffer): Remove obsolete comment.
6043 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6045 * termhooks.h (encode_terminal_code): Declare prototype.
6047 * msdos.c (encode_terminal_code): Don't declare prototype.
6049 * term.c (encode_terminal_code): Now external again, used by
6050 w32console.c and msdos.c.
6052 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6053 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6055 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6057 Fix some minor problems found by GCC 4.5.2's static checks.
6059 * fringe.c (update_window_fringes): Mark locals as initialized
6061 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6063 * alloc.c (mark_fringe_data): Move decl from here ...
6064 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6065 to check its interface.
6066 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6068 * fontset.c (free_realized_fontset): Now static.
6069 (Fset_fontset_font): Rename local to avoid shadowing.
6070 (fontset_font): Mark local as initialized.
6071 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6073 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6075 * xselect.c (x_disown_buffer_selections): Remove; not used.
6076 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6077 (x_own_selection, Fx_disown_selection_internal): Rename locals
6079 (x_handle_dnd_message): Remove local to avoid shadowing.
6081 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6082 so that the caller can use some name other than gcpro1.
6083 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6084 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6085 (Fx_backspace_delete_keys_p):
6086 Use them to avoid shadowing, and rename vars to avoid shadowing.
6087 (x_decode_color, x_set_name, x_window): Now static.
6088 (Fx_create_frame): Add braces to silence GCC warning.
6089 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6090 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6091 Remove unused locals.
6092 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6093 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6094 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6097 * xterm.h (x_mouse_leave): New decl.
6099 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6100 Remove unused functions.
6101 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6102 (x_calc_absolute_position): Now static.
6103 (XTread_socket): Don't define label "out" unless it's used.
6104 Don't declare local "event" unless it's used.
6105 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6106 unless they are used.
6107 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6108 (x_fatal_error_signal): Remove; not used.
6109 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6110 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6111 (x_error_catcher, x_connection_closed, x_error_handler):
6112 (x_error_quitter, xembed_send_message, x_iconify_frame):
6113 (my_log_handler): Rename locals to avoid shadowing.
6114 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6115 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6117 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6118 Rename or move locals to avoid shadowing.
6119 (tty_defined_color, merge_face_heights): Now static.
6120 (free_realized_faces_for_fontset): Remove; not used.
6121 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6122 does not deduce is never used uninitialized.
6123 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6124 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6126 * terminal.c (store_terminal_param): Now static.
6128 * xmenu.c (menu_highlight_callback): Now static.
6129 (set_frame_menubar): Remove unused local.
6130 (xmenu_show): Rename parameter to avoid shadowing.
6131 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6132 since they might point to immutable storage.
6133 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6134 since it's unused otherwise.
6136 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6137 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6138 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6139 avoids a gcc -Wuninitialized diagnostic.
6140 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6141 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6142 does not deduce are never used uninitialized.
6144 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6146 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6147 * window.c (window_loop, size_window):
6148 (run_window_configuration_change_hook, enlarge_window): Likewise.
6150 * window.c (display_buffer): Now static.
6151 (size_window): Mark variables that gcc -Wuninitialized
6152 does not deduce are never used uninitialized.
6153 * window.h (check_all_windows): New decl, to forestall
6154 gcc -Wmissing-prototypes diagnostic.
6155 * dispextern.h (bidi_dump_cached_states): Likewise.
6157 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6159 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6161 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6162 and to avoid gcc -Wuninitialized warning.
6163 (load_charset_map): Mark variables that gcc -Wuninitialized
6164 does not deduce are never used uninitialized.
6165 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6167 * coding.c (coding_set_source, coding_set_destination):
6168 Use "else { /* comment */ }" rather than "else /* comment */;"
6169 for clarity, and to avoid gcc -Wempty-body warning.
6170 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6171 a block, when the outer 'i' will do.
6172 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6173 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6174 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6175 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6176 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6177 Rename locals to avoid shadowing.
6178 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6179 * coding.c (emacs_mule_char, encode_invocation_designation):
6180 Now static, since they're not used elsewhere.
6181 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6182 (decode_coding_object, encode_coding_object, detect_coding_system):
6183 (decode_coding_emacs_mule): Mark variables that gcc
6184 -Wuninitialized does not deduce are never used uninitialized.
6185 (detect_coding_iso_2022): Initialize a local variable that might
6186 be used uninitialized. Leave a FIXME because it's not clear that
6187 this initialization is needed. (Bug#8211)
6188 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6189 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6190 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6191 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6192 Remove unused macros.
6194 * category.c (hash_get_category_set): Remove unused local var.
6195 (copy_category_table): Now static, since it's not used elsewhere.
6196 * character.c (string_count_byte8): Likewise.
6198 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6199 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6201 * chartab.c (copy_sub_char_table): Now static, since it's not used
6203 (sub_char_table_ref_and_range, char_table_ref_and_range):
6204 Rename locals to avoid shadowing.
6205 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6207 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6208 (BIDI_BOB): Remove unused macro.
6210 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6211 deduce are never used uninitialized.
6212 * term.c (encode_terminal_code): Likewise.
6214 * term.c (encode_terminal_code): Now static. Remove unused local.
6216 * tparam.h: New file.
6217 * term.c, tparam.h: Include it.
6218 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6219 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6220 Move these decls to tparam.h, and make them agree with what
6221 is actually in tparam.c. The previous trick of using incompatible
6222 decls in different modules does not conform to the C standard.
6223 All callers of tparam changed to use tparam's actual API.
6224 * tparam.c (tparam1, tparam, tgoto):
6225 Use const pointers where appropriate.
6227 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6228 * cm.h (struct cm): Likewise.
6229 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6230 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6231 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6232 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6233 (turn_on_face, init_tty): Likewise.
6234 * termchar.h (struct tty_display_info): Likewise.
6236 * term.c (term_mouse_position): Rename local to avoid shadowing.
6238 * alloc.c (mark_ttys): Move decl from here ...
6239 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6241 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6243 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6245 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6247 * search.c (compile_pattern_1): Remove argument regp, unused since
6248 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6249 (compile_pattern): Don't pass it.
6251 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6253 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6254 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6256 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6258 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6260 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6261 gdk_window_get_screen, gdk_window_get_geometry,
6262 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6263 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6264 (xg_get_pixbuf_from_pixmap): New function.
6265 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6266 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6267 Call xg_get_pixbuf_from_pixmap instead of
6268 gdk_pixbuf_get_from_drawable.
6269 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6270 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6271 (xg_check_special_colors): Use GtkStyleContext and its functions
6273 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6274 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6275 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6276 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6277 Call gtk_widget_get_preferred_size.
6278 (xg_frame_resized): gdk_window_get_geometry only takes 5
6280 (xg_win_to_widget, xg_event_is_for_menubar):
6281 Call gdk_x11_window_lookup_for_display.
6282 (xg_set_widget_bg): New function.
6283 (delete_cb): New function.
6284 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6285 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6286 (xg_set_background_color): Call xg_set_widget_bg.
6287 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6288 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6289 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6290 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6292 (update_frame_tool_bar): Call gtk_widget_hide.
6293 (xg_initialize): Use GDK_KEY_g.
6295 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6297 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6299 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6300 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6301 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6303 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6305 * w32xfns.c (select_palette): Check success of RealizePalette against
6306 GDI_ERROR, not zero.
6308 See ChangeLog.11 for earlier changes.
6314 Copyright (C) 2011 Free Software Foundation, Inc.
6316 This file is part of GNU Emacs.
6318 GNU Emacs is free software: you can redistribute it and/or modify
6319 it under the terms of the GNU General Public License as published by
6320 the Free Software Foundation, either version 3 of the License, or
6321 (at your option) any later version.
6323 GNU Emacs is distributed in the hope that it will be useful,
6324 but WITHOUT ANY WARRANTY; without even the implied warranty of
6325 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6326 GNU General Public License for more details.
6328 You should have received a copy of the GNU General Public License
6329 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.