1 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3 Fix minor problems found by static checking (Bug#9031).
4 * chartab.c (char_table_set_range, map_sub_char_table):
6 (uniprop_table): Now static.
7 * composite.c (_work_char): Remove unused static var.
9 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
11 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
13 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
15 * gtkutil.c (qttip_cb): Remove code without function.
17 2011-07-09 Eli Zaretskii <eliz@gnu.org>
19 * w32.c (pthread_sigmask): New stub.
21 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
23 Use pthread_sigmask, not sigprocmask (Bug#9010).
24 sigprocmask is portable only for single-threaded applications, and
25 Emacs can be multi-threaded when it uses GTK.
26 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
28 * callproc.c (Fcall_process):
29 * process.c (create_process):
30 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
31 Use pthread_sigmask, not sigprocmask.
33 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
35 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
36 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
39 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
41 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
42 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
43 (xg_hide_tooltip): Fix comment.
45 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
46 in registerServicesMenuSendTypes.
47 (validRequestorForSendType): Don't check ns_return_types.
49 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
52 2011-07-08 Jason Rumney <jasonr@gnu.org>
54 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
55 frame struct members of non-existent frames (Bug#6284).
57 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
59 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
60 variable firstTime not needed on OSX >= 10.6.
61 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
62 >= 10.5. Use setKnobProportion, setDoubleValue.
64 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
65 (MAC_OS_X_VERSION_10_5): Define if not defined.
66 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
67 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
68 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
70 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
71 cString and lossyCString on OSX >= 10.4
73 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
74 sizeToFit on OSX >= 10.2.
76 * nsimage.m (allocInitFromFile): Don't use deprecated method
77 bestRepresentationForDevice on OSX >= 10.6.
79 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
82 * emacs.c: Declare unexec_init_emacs_zone.
84 * nsgui.h: Fix compiler warning about gnulib redefining verify.
86 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
88 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
89 on svcsMenu (Bug#8842).
91 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
93 (Fns_list_services): Just return Qnil on 10.6, code not working there.
95 * nsterm.m (QUTF8_STRING): Declare.
96 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
97 (validRequestorForSendType): Return type is (id).
98 Change indexOfObjectIdenticalTo to indexOfObject.
99 Check if we have local selection before returning self (Bug#8842).
100 (writeSelectionToPasteboard): Put local selection into paste board
101 if we have a local selection (Bug#8842).
102 (syms_of_nsterm): DEFSYM QUTF8_STRING.
104 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
105 (ns_get_local_selection): Declare.
107 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
109 * keymap.c (describe_map_tree): Don't insert a double newline at
110 the end of the buffer (bug#1169) and return whether we inserted
113 * callint.c (Fcall_interactively): Change "reading args" to
114 "providing args" to try to clarify what it does (bug#1010).
116 2011-07-07 Kenichi Handa <handa@m17n.org>
118 * composite.c (composition_compute_stop_pos): Ignore a static
119 composition starting before CHARPOS (Bug#8915).
121 * xdisp.c (handle_composition_prop): Likewise.
123 2011-07-07 Eli Zaretskii <eliz@gnu.org>
125 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
128 2011-07-07 Kenichi Handa <handa@m17n.org>
130 * character.h (unicode_category_t): New enum type.
132 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
133 (Qchar_code_property_table): New variable.
134 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
135 (UNIPROP_COMPRESSED_FORM_P): New macros.
136 (char_table_ascii): Uncompress the compressed values.
137 (sub_char_table_ref): New arg is_uniprop. Callers changed.
138 Uncompress the compressed values.
139 (sub_char_table_ref_and_range): Likewise.
140 (char_table_ref_and_range): Uncompress the compressed values.
141 (sub_char_table_set): New arg is_uniprop. Callers changed.
142 Uncompress the compressed values.
143 (sub_char_table_set_range): Args changed. Callers changed.
144 (char_table_set_range): Adjuted for the above change.
145 (map_sub_char_table): Delete args default_val and parent. Add arg
146 top. Give decoded values to a Lisp function.
147 (map_char_table): Adjusted for the above change. Give decoded
148 values to a Lisp function. Gcpro more variables.
149 (uniprop_table_uncompress)
150 (uniprop_decode_value_run_length): New functions.
151 (uniprop_decoder, uniprop_decoder_count): New variables.
152 (uniprop_get_decoder, uniprop_encode_value_character)
153 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
155 (uniprop_encoder, uniprop_encoder_count): New variables.
156 (uniprop_get_encoder, uniprop_table)
157 (Funicode_property_table_internal, Fget_unicode_property_internal)
158 (Fput_unicode_property_internal): New functions.
159 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
160 Sunicode_property_table_internal, Sget_unicode_property_internal,
161 and Sput_unicode_property_internal. Defvar_lisp
162 char-code-property-alist.
164 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
165 Vunicode_category_table.
167 * font.c (font_range): Adjusted for the change of
168 Vunicode_category_table.
170 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
172 * m/iris4d.h: Remove file, move contents ...
173 * s/irix6-5.h: ... here.
175 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
177 Remove unportable assumption about struct layout (Bug#8884).
178 * alloc.c (mark_buffer):
179 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
180 (clone_per_buffer_values): Don't assume that
181 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
182 This isn't true in general, and it's particularly not true
183 if Emacs is configured with --with-wide-int.
184 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
185 New macros, used in the buffer.c change.
187 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
189 * xsettings.c: Use both GConf and GSettings if both are available.
190 (store_config_changed_event): Add comment.
191 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
192 (store_tool_bar_style_changed): New functions.
193 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
194 (struct xsettings): Move font inside HAVE_XFT.
195 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
196 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
197 Move inside HAVE_XFT.
198 (something_changed_gsettingsCB): Renamed from something_changedCB.
199 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
201 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
202 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
203 (something_changed_gconfCB): Renamed from something_changedCB.
204 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
205 (parse_settings): Move check for font inside HAVE_XFT.
206 (read_settings, apply_xft_settings): Add comment.
207 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
208 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
209 call store_font_name_changed.
210 (xft_settings_event): Add comment.
211 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
212 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
213 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
214 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
215 (xsettings_initialize): Call init_gsettings last.
216 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
219 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
221 Random fixes. E.g., (random) never returned negative values.
222 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
223 subseconds part to the entropy, as that's a bit more random.
224 Prefer signed to unsigned, since the signedness doesn't matter and
225 in general we prefer signed. When given a limit, use a
226 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
227 latter isn't right if USE_2_TAGS_FOR_INTS.
228 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
229 not 0..VALMASK. Don't discard "excess" bits that random () returns.
231 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
233 * textprop.c (text_property_stickiness):
234 Obey Vtext_property_default_nonsticky.
235 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
236 * w32fns.c (syms_of_w32fns):
237 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
239 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
241 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
242 This is more efficient than Ffile_directory_p and avoids a minor race.
244 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
246 * buffer.c (Foverlay_put): Say what the return value is
249 * fileio.c (barf_or_query_if_file_exists): Check first if the file
250 is a directory before asking whether to use the file name
252 (barf_or_query_if_file_exists): Make the "File is a directory"
253 error be more correct.
255 * fns.c (Frequire): Remove the mention of the .gz files, since
256 that's installation-specific, but keep the mention of
259 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
261 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
262 Report string overflow if the output is too long.
264 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
266 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
267 (syms_of_gnutls): Remove duplicate DEFSYM for
268 Qgnutls_bootprop_verify_hostname_error, an error for
269 Qgnutls_bootprop_verify_error (which is no longer used).
271 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
272 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
273 Also (re)move comments that are misplaced or no longer relevant.
275 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
277 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
279 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
281 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
282 and background color parameters if they have been changed.
284 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
286 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
288 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
290 * xsettings.c (SYSTEM_FONT): Define only when used.
291 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
293 * keymap.c (access_keymap_1): Now static.
295 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
297 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
298 leave any prefix arg for the up event (Bug#1586).
300 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
302 * lread.c (syms_of_lread): Mention single symbols defined by
303 `defvar' or `defconst' (bug#7154).
305 * fns.c (Frequire): Mention .el.gz files (bug#7314).
306 (Frequire): Mention get-load-suffixes.
308 2011-07-02 Martin Rudalics <rudalics@gmx.at>
310 * window.h (window): Remove clone_number slot.
311 * window.c (Fwindow_clone_number, Fset_window_clone_number):
313 (make_parent_window, make_window, saved_window)
314 (Fset_window_configuration, save_window_save): Don't deal with
316 * buffer.c (Qclone_number): Remove declaration.
317 (sort_overlays, overlay_strings): Don't deal with clone numbers.
319 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
321 Add multiple inheritance to keymaps.
322 * keymap.c (Fmake_composed_keymap): New function.
323 (Fset_keymap_parent): Simplify.
324 (fix_submap_inheritance): Remove.
325 (access_keymap_1): New function extracted from access_keymap to handle
326 embedded parents and handle lists of maps.
327 (access_keymap): Use it.
328 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
329 (Fcopy_keymap): Handle embedded parents.
330 (Fcommand_remapping, define_as_prefix): Simplify.
331 (Fkey_binding): Simplify.
332 (syms_of_keymap): Move minibuffer-local-completion-map,
333 minibuffer-local-filename-completion-map,
334 minibuffer-local-must-match-map, and
335 minibuffer-local-filename-must-match-map to Elisp.
336 (syms_of_keymap): Defsubr make-composed-keymap.
337 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
338 (parse_menu_item): Trivial simplification.
340 2011-07-01 Glenn Morris <rgm@gnu.org>
342 * Makefile.in (SETTINGS_LIBS): Fix typo.
344 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
346 * coding.c (Fencode_coding_string): Record the last coding system
347 used, as the function doc string says (bug#8738).
349 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
351 * xsettings.c (store_monospaced_changed): Take new font as arg and
352 check for change against current_mono_font.
353 (EMACS_TYPE_SETTINGS): Remove this and related defines.
354 (emacs_settings_constructor, emacs_settings_get_property)
355 (emacs_settings_set_property, emacs_settings_class_init)
356 (emacs_settings_init, gsettings_obj): Remove.
357 (something_changedCB): New function for HAVE_GSETTINGS.
358 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
359 with value as argument.
360 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
361 g_settings_new (Bug#8967). Do not create gsettings_obj.
362 Remove calls to g_settings_bind. Connect something_changedCB to
365 * xgselect.c: Add defined (HAVE_GSETTINGS).
366 (xgselect_initialize): Ditto.
368 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
369 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
372 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
374 * eval.c (struct backtrace): Simplify and port the data structure.
375 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
376 signed bit field, as this assumption is not portable and it makes
377 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
378 "char debug_on_exit : 1" as this is not portable either; instead,
379 use the portable "unsigned int debug_on_exit : 1". Remove unused
380 member evalargs. Remove obsolete comments about cc bombing out.
382 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
384 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
385 Let HAVE_GSETTINGS override HAVE_GCONF.
386 (store_monospaced_changed): New function.
387 (EMACS_SETTINGS): A new type derived from GObject to handle
388 GSettings notifications.
389 (emacs_settings_constructor, emacs_settings_get_property)
390 (emacs_settings_set_property, emacs_settings_class_init):
392 (gsettings_client, gsettings_obj): New variables.
393 (GSETTINGS_SCHEMA): New define.
394 (something_changedCB): Call store_monospaced_changed.
395 (init_gsettings): New function.
396 (xsettings_initialize): Call init_gsettings.
397 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
400 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
403 2011-06-29 Martin Rudalics <rudalics@gmx.at>
405 * window.c (resize_root_window, grow_mini_window)
406 (shrink_mini_window): Rename Qresize_root_window to
407 Qwindow_resize_root_window and Qresize_root_window_vertically to
408 Qwindow_resize_root_window_vertically.
410 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
412 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
414 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
416 * makefile.w32-in: Redesign dependencies so they reflect more
417 clearly which files are directly included by each source file,
418 and not through other includes.
420 2011-06-27 Martin Rudalics <rudalics@gmx.at>
422 * buffer.c (Qclone_number): Declare static and DEFSYM it.
423 (sort_overlays, overlay_strings): When an overlay's clone number
424 matches the window's clone number process the overlay even if
425 the overlay's window property doesn't match the current window.
427 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
428 (Fwindow_hchild): Rename to Fwindow_left_child.
429 (Fwindow_next): Rename to Fwindow_next_sibling.
430 (Fwindow_prev): Rename to Fwindow_prev_sibling.
431 (resize_window_check): Rename to window_resize_check.
432 (resize_window_apply): Rename to window_resize_apply.
433 (Fresize_window_apply): Rename to Fwindow_resize_apply.
434 (Fdelete_other_windows_internal, resize_frame_windows)
435 (Fsplit_window_internal, Fdelete_window_internal)
436 (grow_mini_window, shrink_mini_window)
437 (Fresize_mini_window_internal): Fix callers accordingly.
439 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
441 * emacsgtkfixed.h: State that this is only used with Gtk+3.
442 (emacs_fixed_set_min_size): Remove.
443 (emacs_fixed_new): Take frame as argument.
445 * emacsgtkfixed.c: State that this is only used with Gtk+3.
446 (_EmacsFixedPrivate): Remove minwidth/height.
448 (emacs_fixed_init): Initialize priv->f.
449 (get_parent_class, emacs_fixed_set_min_size): Remove.
450 (emacs_fixed_new): Set priv->f to argument.
451 (emacs_fixed_get_preferred_width)
452 (emacs_fixed_get_preferred_height): Use min_width/height from
453 frames size_hint to set minimum and natural (Bug#8919).
454 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
455 and use min_width/height from frames size_hint to set
456 min_width/height (Bug#8919).
458 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
459 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
462 2011-06-26 Eli Zaretskii <eliz@gnu.org>
464 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
465 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
468 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
470 * process.c (wait_reading_process_output): Bypass select if
471 waiting for a cell while ignoring keyboard input, and input is
472 pending. Suggested by Jan Djärv (Bug#8869).
474 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
476 Use gnulib's dup2 module instead of rolling our own.
477 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
479 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
481 * dispnew.c (scrolling_window): Before scrolling, turn off a
482 mouse-highlight in the window being scrolled.
484 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
486 Move DEFSYM to lisp.h and use everywhere.
488 * character.h (DEFSYM): Move declaration...
489 * lisp.h (DEFSYM): ...here.
495 * w32select.c: Don't include character.h.
497 * alloc.c (syms_of_alloc):
498 * buffer.c (syms_of_buffer):
499 * bytecode.c (syms_of_bytecode):
500 * callint.c (syms_of_callint):
501 * casefiddle.c (syms_of_casefiddle):
502 * casetab.c (init_casetab_once):
503 * category.c (init_category_once, syms_of_category):
504 * ccl.c (syms_of_ccl):
505 * cmds.c (syms_of_cmds):
506 * composite.c (syms_of_composite):
507 * dbusbind.c (syms_of_dbusbind):
508 * dired.c (syms_of_dired):
509 * dispnew.c (syms_of_display):
510 * doc.c (syms_of_doc):
511 * editfns.c (syms_of_editfns):
512 * emacs.c (syms_of_emacs):
513 * eval.c (syms_of_eval):
514 * fileio.c (syms_of_fileio):
515 * fns.c (syms_of_fns):
516 * frame.c (syms_of_frame):
517 * fringe.c (syms_of_fringe):
518 * insdel.c (syms_of_insdel):
519 * keymap.c (syms_of_keymap):
520 * lread.c (init_obarray, syms_of_lread):
521 * macros.c (syms_of_macros):
522 * msdos.c (syms_of_msdos):
523 * print.c (syms_of_print):
524 * process.c (syms_of_process):
525 * search.c (syms_of_search):
526 * sound.c (syms_of_sound):
527 * syntax.c (init_syntax_once, syms_of_syntax):
528 * terminal.c (syms_of_terminal):
529 * textprop.c (syms_of_textprop):
530 * undo.c (syms_of_undo):
531 * w32.c (globals_of_w32):
532 * window.c (syms_of_window):
533 * xdisp.c (syms_of_xdisp):
534 * xfaces.c (syms_of_xfaces):
535 * xfns.c (syms_of_xfns):
536 * xmenu.c (syms_of_xmenu):
537 * xsettings.c (syms_of_xsettings):
538 * xterm.c (syms_of_xterm): Use DEFSYM.
540 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
542 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
544 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
546 Integer and buffer overflow fixes (Bug#8873).
548 * print.c (printchar, strout): Check for string overflow.
549 (PRINTPREPARE, printchar, strout):
550 Don't set size unless allocation succeeds.
552 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
553 for sizes. Check for string overflow more accurately.
554 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
556 * macros.c: Integer and buffer overflow fixes.
557 * keyboard.h (struct keyboard.kbd_macro_bufsize):
558 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
559 Use ptrdiff_t, not int, for sizes.
560 Don't increment bufsize until after realloc succeeds.
561 Check for size-calculation overflow.
562 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
564 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
566 * lread.c: Integer overflow fixes.
567 (read_integer): Radix is now EMACS_INT, not int,
568 to improve quality of diagnostics for out-of-range radices.
569 Calculate buffer size correctly for out-of-range radices.
570 (read1): Check for integer overflow in radices, and in
572 (read_escape): Avoid int overflow.
573 (Fload, openp, read_buffer_size, read1)
574 (substitute_object_recurse, read_vector, read_list, map_obarray):
575 Use ptrdiff_t, not int, for sizes.
576 (read1): Use EMACS_INT, not int, for sizes.
577 Check for size overflow.
579 * image.c (cache_image): Check for size arithmetic overflow.
581 * lread.c: Integer overflow issues.
582 (saved_doc_string_size, saved_doc_string_length)
583 (prev_saved_doc_string_size, prev_saved_doc_string_length):
584 Now ptrdiff_t, not int.
585 (read1): Don't assume doc string length fits in int. Check for
586 out-of-range doc string lengths.
587 (read_list): Don't assume file position fits in int.
588 (read_escape): Check for hex character overflow.
590 2011-06-22 Leo Liu <sdl.web@gmail.com>
592 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
593 Move to minibuffer.el.
595 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
597 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
598 The following patches are for when GLYPH_DEBUG && !XASSERT.
599 * dispextern.h (trace_redisplay_p, dump_glyph_string):
600 * dispnew.c (flush_stdout):
601 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
602 Mark as externally visible.
603 * dispnew.c (check_window_matrix_pointers): Now static.
604 * dispnew.c (window_to_frame_vpos):
605 * xfns.c (unwind_create_frame):
606 * xterm.c (x_check_font): Remove unused local.
607 * scroll.c (CHECK_BOUNDS):
608 * xfaces.c (cache_fache): Rename local to avoid shadowing.
609 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
610 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
611 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
612 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
614 (debug_method_add): Use va_list and vsprintf rather than relying
615 on undefined behavior with wrong number of arguments.
616 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
617 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
618 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
619 since we're not interested in debugging glyphs with old libraries.
620 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
621 GCC 4.6.0's static checking.
623 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
625 Integer overflow and signedness fixes (Bug#8873).
626 A few related buffer overrun fixes, too.
628 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
630 * dispextern.h (struct face.stipple):
631 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
632 (x_bitmap_mask, x_allocate_bitmap_record)
633 (x_create_bitmap_from_data, x_create_bitmap_from_file)
634 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
635 (x_create_bitmap_from_xpm_data):
636 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
637 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
639 * xfaces.c (load_pixmap):
640 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
641 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
642 (.bitmaps_last, struct x_output.icon_bitmap):
643 Use ptrdiff_t, not int, for bitmap indexes.
644 (x_allocate_bitmap_record): Check for size overflow.
645 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
647 Use ptrdiff_t, not int, for overlay counts.
648 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
649 * editfns.c (overlays_around, get_pos_property):
650 * textprop.c (get_char_property_and_overlay):
651 * xdisp.c (next_overlay_change, note_mouse_highlight):
652 * xfaces.c (face_at_buffer_position):
653 * buffer.c (OVERLAY_COUNT_MAX): New macro.
654 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
655 (Fnext_overlay_change, Fprevious_overlay_change)
656 (mouse_face_overlay_overlaps, Foverlays_in):
657 Use ptrdiff_t, not int, for sizes.
658 (overlays_at, overlays_in): Check for size-calculation overflow.
660 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
662 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
663 (x_session_initialize): Do not assume string length fits in int.
665 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
666 This is unlikely, but can occur if DPI is outlandish.
668 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
669 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
671 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
672 * xrdb.c (magic_file_p, search_magic_path):
673 Omit last arg SUFFIX; it was always 0. All callers changed.
674 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
676 * xfont.c (xfont_match): Avoid need for strlen.
678 * xfns.c: Don't assume strlen fits in int.
679 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
681 * xdisp.c (message_log_check_duplicate): Return intmax_t,
682 not unsigned long, as we prefer signed integers. All callers changed.
683 Detect integer overflow in repeat count.
684 (message_dolog): Don't assume print length fits in 39 bytes.
685 (display_mode_element): Don't assume strlen fits in int.
687 * termcap.c: Don't assume sizes fit in int and never overflow.
688 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
689 (gobble_line): Check for size-calculation overflow.
691 * minibuf.c (Fread_buffer):
692 * lread.c (intern, intern_c_string):
693 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
694 Don't assume string length fits in int.
696 * keyboard.c (parse_tool_bar_item):
697 * gtkutil.c (style_changed_cb): Avoid need for strlen.
699 * font.c: Don't assume string length fits in int.
700 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
701 Use ptrdiff_t, not int.
702 (font_intern_prop): Don't assume string length fits in int.
703 Don't assume integer property fits in fixnum.
704 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
706 * filelock.c: Fix some buffer overrun and integer overflow issues.
707 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
708 Reformulate so as not to need the command string.
709 Invoke gzip -cd rather than gunzip, as it's more portable.
710 (lock_info_type, lock_file_1, lock_file):
711 Don't assume pid_t and time_t fit in unsigned long.
712 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
713 (current_lock_owner): Prefer signed type for sizes.
714 Use memcpy, not strncpy, where memcpy is what is really wanted.
715 Don't assume (via atoi) that time_t and pid_t fit in int.
716 Check for time_t and/or pid_t out of range, e.g., via a network share.
717 Don't alloca where an auto var works fine.
719 * fileio.c: Fix some integer overflow issues.
720 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
721 Don't assume string length fits in int.
722 (directory_file_name): Don't assume string length fits in long.
723 (make_temp_name): Don't assume pid fits in int, or that its print
724 length is less than 20.
726 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
728 * coding.c (make_subsidiaries): Don't assume string length fits in int.
730 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
732 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
733 We prefer signed integers, even for size calculations.
735 * emacs.c: Don't assume string length fits in 'int'.
736 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
737 (main): Don't invoke strlen when not needed.
739 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
740 (XD_DEBUG_MESSAGE): Don't waste a byte.
742 * callproc.c (getenv_internal_1, getenv_internal)
744 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
746 * lread.c (invalid_syntax): Omit length argument.
747 All uses changed. This doesn't fix a bug, but it simplifies the
748 code away from its former Hollerith-constant appearance, and it's
749 one less 'int' to worry about when looking at integer-overflow issues.
750 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
752 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
753 This didn't break anything, but it didn't help either.
754 It's confusing to put a bogus integer in a place where the actual
755 value does not matter.
756 (LIST_END_P): Remove unused macro and its bogus comment.
757 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
759 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
760 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
762 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
763 We prefer signed types, and the value cannot exceed the EMACS_INT
764 range anyway (because otherwise the length would not be representable).
765 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
766 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
767 This avoids a GCC warning when WIDE_EMACS_INT.
769 * indent.c (sane_tab_width): New function.
770 (current_column, scan_for_column, Findent_to, position_indentation)
771 (compute_motion): Use it. This is just for clarity.
772 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
774 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
776 * lisp.h (lint_assume): New macro.
777 * composite.c (composition_gstring_put_cache):
778 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
780 * editfns.c, insdel.c:
781 Omit unnecessary forward decls, to simplify future changes.
783 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
785 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
787 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
788 Use much-faster test for byte-length change.
789 Don't assume string byte-length fits in 'int'.
790 Check that character arg fits in 'int'.
791 (mapcar1): Declare byte as byte, for clarity.
793 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
795 * fns.c (concat): Catch string overflow earlier.
796 Do not rely on integer wraparound.
798 * dispextern.h (struct it.overlay_strings_charpos)
799 (struct it.selective): Now EMACS_INT, not int.
800 * xdisp.c (forward_to_next_line_start)
801 (back_to_previous_visible_line_start)
802 (reseat_at_next_visible_line_start, next_element_from_buffer):
803 Don't arbitrarily truncate the value of 'selective' to int.
805 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
807 * composite.c: Don't truncate sizes to 'int'.
808 (composition_gstring_p, composition_reseat_it)
809 (composition_adjust_point): Use EMACS_INT, not int.
810 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
811 not EMACS_UINT, for indexes.
813 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
815 * buffer.c: Include <verify.h>.
816 (struct sortvec.priority, struct sortstr.priority):
817 Now EMACS_INT, not int.
818 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
819 (struct sortstr.size, record_overlay_string)
820 (struct sortstrlist.size, struct sortlist.used):
821 Don't truncate size to int.
822 (record_overlay_string): Check for size-calculation overflow.
823 (init_buffer_once): Check at compile-time, not run-time.
825 2011-06-22 Jim Meyering <meyering@redhat.com>
827 Don't leak an XBM-image-sized buffer
828 * image.c (xbm_load): Free the image buffer after using it.
830 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
833 * composite.c (find_automatic_composition): Omit needless 'return 0;'
834 that Sun C diagnosed.
835 * fns.c (secure_hash): Fix pointer signedness issue.
836 * intervals.c (static_offset_intervals): New function.
837 (offset_intervals): Use it.
839 2011-06-21 Leo Liu <sdl.web@gmail.com>
842 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
845 * fns.c (secure_hash): Rename from crypto_hash_function and change
846 the first arg to accept symbols.
847 (Fsecure_hash): New primitive.
848 (syms_of_fns): New symbols.
850 2011-06-20 Deniz Dogan <deniz@dogan.se>
852 * process.c (Fset_process_buffer): Clarify return value in
855 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
857 * dispnew.c (add_window_display_history): Use BVAR.
859 * xdisp.c (debug_method_add): Use BVAR.
860 (check_window_end, dump_glyph_matrix, dump_glyph)
861 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
863 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
866 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
867 check till after the cache is created in init_frame_faces.
869 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
871 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
873 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
875 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
876 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
877 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
879 Improve buffer-overflow checking (Bug#8873).
880 * fileio.c (Finsert_file_contents):
881 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
882 Remove the old (too-loose) buffer overflow checks.
883 They weren't needed, since make_gap checks for buffer overflow.
884 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
885 The old code merely checked for Emacs fixnum overflow, and relied
886 on undefined (wraparound) behavior. The new code avoids undefined
887 behavior, and also checks for ptrdiff_t and/or size_t overflow.
889 * editfns.c (Finsert_char): Don't dump core with very negative counts.
890 Tune. Don't use wider integers than needed. Don't use alloca.
891 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
893 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
895 * insdel.c, lisp.h (buffer_overflow): New function.
896 (insert_from_buffer_1, replace_range, replace_range_2):
897 * insdel.c (make_gap_larger):
898 * editfns.c (Finsert_char):
899 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
901 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
903 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
905 Integer overflow and signedness fixes (Bug#8873).
907 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
908 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
910 * fileio.c: Don't assume EMACS_INT fits in off_t.
911 (emacs_lseek): New static function.
912 (Finsert_file_contents, Fwrite_region): Use it.
913 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
915 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
917 * fns.c: Don't overflow int when computing a list length.
918 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
919 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
920 truncation on 64-bit hosts. Check for QUIT every
921 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
922 faster and is responsive enough.
923 (Flength): Report an error instead of overflowing an integer.
924 (Fsafe_length): Return a float if the value is not representable
925 as a fixnum. This shouldn't happen except in contrived situations.
926 (Fnthcdr, Fsort): Don't assume list length fits in int.
927 (Fcopy_sequence): Don't assume vector length fits in int.
929 * alloc.c: Check that resized vectors' lengths fit in fixnums.
930 (header_size, word_size): New constants.
931 (allocate_vectorlike): Don't check size overflow here.
932 (allocate_vector): Check it here instead, since this is the only
933 caller of allocate_vectorlike that could cause overflow.
934 Check that the new vector's length is representable as a fixnum.
936 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
937 The previous code was bogus. For example, next_almost_prime (32)
938 returned 39, which is undesirable as it is a multiple of 3; and
939 next_almost_prime (24) returned 25, which is a multiple of 5 so
940 why was the code bothering to check for multiples of 7?
942 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
944 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
946 Variadic C functions now count arguments with ptrdiff_t.
947 This partly undoes my 2011-03-30 change, which replaced int with size_t.
948 Back then I didn't know that the Emacs coding style prefers signed int.
949 Also, in the meantime I found a few more instances where arguments
950 were being counted with int, which may truncate counts on 64-bit
951 machines, or EMACS_INT, which may be unnecessarily wide.
952 * lisp.h (struct Lisp_Subr.function.aMANY)
953 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
954 Arg counts are now ptrdiff_t, not size_t.
955 All variadic functions and their callers changed accordingly.
956 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
957 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
958 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
959 * callint.c (Fcall_interactively): Check arg count for overflow,
960 to avoid potential buffer overrun. Use signed char, not 'int',
961 for 'varies' array, so that we needn't bother to check its size
962 calculation for overflow.
963 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
964 * eval.c (apply_lambda):
965 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
966 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
967 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
969 * callint.c (Fcall_interactively): Don't use index var as event count.
971 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
972 * mem-limits.h (SIZE): Remove; no longer used.
974 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
976 Remove unnecessary casts.
977 * xterm.c (x_term_init):
978 * xfns.c (x_set_border_pixel):
979 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
980 These aren't needed now that we assume ANSI C.
982 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
983 It's more likely to cause problems (due to unsigned overflow)
986 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
988 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
990 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
992 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
994 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
996 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
998 GLYPH_CODE_FACE returns EMACS_INT, not int.
999 * dispextern.h (merge_faces):
1000 * xfaces.c (merge_faces):
1001 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1002 Don't assume EMACS_INT fits in int.
1004 * character.h (CHAR_VALID_P): Remove unused parameter.
1005 * fontset.c, lisp.h, xdisp.c: All uses changed.
1007 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1009 * fns.c (concat): Minor tuning based on overflow analysis.
1010 This doesn't fix any bugs. Use int to hold character, instead
1011 of constantly refetching from Emacs object. Use XFASTINT, not
1012 XINT, for value known to be a character. Don't bother comparing
1013 a single byte to 0400, as it's always less.
1015 * floatfns.c (Fexpt):
1016 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1018 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1021 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1023 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1024 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1025 incorrectly succeed when S was a string, because 4294967386 was
1026 truncated before it was used.
1028 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1029 Otherwise, an out-of-range integer could cause undefined behavior
1032 * composite.c: Use int, not EMACS_INT, for characters.
1033 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1034 EMACS_INT, for values that are known to be in character range.
1035 This doesn't fix any bugs but is the usual style inside Emacs and
1036 may generate better code on 32-bit machines.
1038 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1039 This is for reasons similar to the recent CHAR_STRING fix.
1040 * charset.c (Fencode_char): Check that character arg is actually
1041 a character. Pass an int to ENCODE_CHAR.
1042 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1043 wider than 'int', as a compile-time check to prevent future regressions
1046 * character.c (char_string): Remove unnecessary casts.
1048 Make sure a 64-bit char is never passed to CHAR_STRING.
1049 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1050 by silently ignoring the top 32 bits, allowing some values
1051 that were far too large to be valid characters.
1052 * character.h: Include <verify.h>.
1053 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1054 arguments are no wider than unsigned, as a compile-time check
1055 to prevent future regressions in this area.
1057 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1058 (Fsubst_char_in_region):
1060 * xdisp.c (decode_mode_spec_coding):
1061 Adjust to CHAR_STRING's new requirement.
1062 * editfns.c (Finsert_char, Fsubst_char_in_region):
1063 * fns.c (concat): Check that character args are actually
1064 characters. Without this test, these functions did the wrong
1065 thing with wildly out-of-range values on 64-bit hosts.
1067 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1068 These casts should not be needed on 32-bit hosts, either.
1069 * keyboard.c (read_char):
1070 * lread.c (Fload): Remove casts to unsigned.
1072 * lisp.h (UNSIGNED_CMP): New macro.
1073 This fixes comparison bugs on 64-bit hosts.
1074 (ASCII_CHAR_P): Use it.
1075 * casefiddle.c (casify_object):
1076 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1077 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1078 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1079 * dispextern.h (FACE_FROM_ID):
1080 * keyboard.c (read_char): Use UNSIGNED_CMP.
1082 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1083 not to EMACS_INT, to avoid GCC warning.
1085 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1087 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1088 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1089 isn't needed on 32-bit machines.
1091 * buffer.c (Fgenerate_new_buffer_name):
1092 Use EMACS_INT for count, not int.
1093 (advance_to_char_boundary): Return EMACS_INT, not int.
1095 * data.c (Qcompiled_function): Now static.
1097 * window.c (window_body_lines): Now static.
1099 * image.c (gif_load): Rename local to avoid shadowing.
1101 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1102 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1103 * alloc.c (make_save_value): Integer argument is now of type
1105 (mark_object): Use ptrdiff_t, not int.
1106 * lisp.h (pD): New macro.
1107 * print.c (print_object): Use it.
1109 * alloc.c: Use EMACS_INT, not int, to count objects.
1110 (total_conses, total_markers, total_symbols, total_vector_size)
1111 (total_free_conses, total_free_markers, total_free_symbols)
1112 (total_free_floats, total_floats, total_free_intervals)
1113 (total_intervals, total_strings, total_free_strings):
1114 Now EMACS_INT, not int. All uses changed.
1115 (Fgarbage_collect): Compute overall total using a double, so that
1116 integer overflow is less likely to be a problem. Check for overflow
1117 when converting back to an integer.
1118 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1119 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1120 These were 'int' variables that could overflow on 64-bit hosts;
1121 they were never used, so remove them instead of repairing them.
1122 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1123 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1124 Previously, this ceilinged at INT_MAX, but that doesn't work on
1126 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1128 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1129 (allocate_vectorlike): Check for ptrdiff_t overflow.
1130 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1131 when a (possibly-narrower) signed value would do just as well.
1132 We prefer using signed arithmetic, to avoid comparison confusion.
1134 * alloc.c: Catch some string size overflows that we were missing.
1135 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1136 for convenience in STRING_BYTES_MAX.
1137 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1138 The definition here is exact; the one in lisp.h was approximate.
1139 (allocate_string_data): Check for string overflow. This catches
1140 some instances we weren't catching before. Also, it catches
1141 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1142 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1143 and ptrdiff_t and EMACS_INT are both 64 bits.
1145 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1146 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1147 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1149 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1151 * alloc.c (Fmake_string): Check for out-of-range init.
1153 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1155 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1157 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1159 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1160 xg_get_default_scrollbar_width.
1162 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1163 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1164 (style_changed_cb): Call update_theme_scrollbar_width and call
1165 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1166 all frames (Bug#8505).
1167 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1168 Call gtk_window_set_resizable if HAVE_GTK3.
1169 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1170 and height if HAVE_GTK3 (Bug#8505).
1171 (scroll_bar_width_for_theme): New variable.
1172 (update_theme_scrollbar_width): New function.
1173 (xg_get_default_scrollbar_width): Move code to
1174 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1175 (xg_initialize): Call update_theme_scrollbar_width.
1177 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1179 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1181 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1183 * frame.c (make_frame): Call other_buffer_safely instead of
1186 * window.c (temp_output_buffer_show): Call display_buffer with
1187 second argument Vtemp_buffer_show_specifiers and reset latter
1188 immediately after the call.
1189 (Vtemp_buffer_show_specifiers): New variable.
1190 (auto_window_vscroll_p, next_screen_context_lines)
1191 (Vscroll_preserve_screen_position): Remove leading asterisks from
1194 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1196 Fix minor problems found by GCC 4.6.0 static checking.
1197 * buffer.c (Qclone_number): Remove for now, as it's unused.
1198 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1199 (record_buffer): Remove unused local.
1200 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1201 (set_frame_buffer_list): Remove; unused.
1202 * frame.h (other_visible_frames): Remove decl.
1203 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1204 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1205 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1207 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1208 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1209 Define only if HAVE_GPM.
1210 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1211 (update_hints_inhibit): Remove; never set. All uses removed.
1212 * widgetprv.h (emacsFrameClassRec): Remove decl.
1213 * window.c (delete_deletable_window): Now returns void, since it
1214 wasn't returning anything.
1215 (compare_window_configurations): Remove unused locals.
1216 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1217 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1218 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1219 the same widths as pointers. This follows up on the 2011-05-06 patch.
1220 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1221 * xterm.h: Likewise.
1222 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1224 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1226 * makefile.w32-in: Update dependencies.
1227 (LISP_H): Add lib/intprops.h.
1229 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1231 * image.c (gif_load): Add animation frame delay to the metadata.
1232 (syms_of_image): Use DEFSYM. New symbol `delay'.
1234 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1236 * window.c (delete_deletable_window): Re-add.
1237 (Fset_window_configuration): Rewrite to handle dead buffers and
1238 consequently deletable windows.
1239 (window_tree, Fwindow_tree): Remove. Supply functionality in
1241 (compare_window_configurations): Simplify code.
1243 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1245 * image.c (imagemagick_load_image): Fix type mismatch.
1246 (Fimagemagick_types): Likewise.
1248 * window.h (replace_buffer_in_windows): Declare.
1250 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1252 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1253 Qclone_number. Remove external declaration of Qdelete_window.
1254 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1256 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1257 Qbuffer_list_update_hook if allowed.
1258 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1259 buffer list implementation.
1260 (other_buffer_safely): New function.
1261 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1262 calls to replace_buffer_in_windows and
1263 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1265 (record_buffer): Inhibit quitting and rewrite using quittable
1266 functions. Run Qbuffer_list_update_hook if allowed.
1267 (Frecord_buffer, Funrecord_buffer): New functions.
1268 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1269 switch-to-buffer to window.el.
1270 (bury-buffer): Move to window.el.
1271 (Vbuffer_list_update_hook): New variable.
1273 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1276 * window.h (resize_frame_windows): Move up in code.
1277 (Fwindow_frame): Remove EXFUN.
1278 (replace_buffer_in_all_windows): Remove prototype.
1279 (replace_buffer_in_windows_safely): Add prototype.
1281 * window.c: Declare Qdelete_window static again. Move down
1282 declaration of select_count.
1283 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1284 (Fother_window): Move to window.el.
1285 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1286 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1287 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1289 (replace_buffer_in_windows): Implement by calling
1290 Qreplace_buffer_in_windows.
1291 (replace_buffer_in_all_windows): Remove with some functionality
1292 moved into replace_buffer_in_windows_safely.
1293 (replace_buffer_in_windows_safely): New function.
1294 (select_window_norecord, select_frame_norecord): Move in front
1295 of run_window_configuration_change_hook. Remove now obsolete
1297 (Fset_window_buffer): Rewrite doc-string. Call
1298 Qrecord_window_buffer.
1299 (keys_of_window): Move binding for other-window to window.el.
1301 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1303 * dispextern.h (struct image): Replace data member, whose int_val
1304 and ptr_val fields were not used by anything, with a single
1307 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1308 (gif_clear_image, gif_load, imagemagick_load_image)
1309 (gs_clear_image, gs_load): Callers changed.
1311 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1313 * buffer.h: Include <time.h>, for time_t.
1314 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1316 Fix minor problems found by static checking.
1318 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1320 Make identifiers static if they are not used in other modules.
1321 * data.c (Qcompiled_function, Qframe, Qvector):
1322 * image.c (QimageMagick, Qsvg):
1323 * minibuf.c (Qmetadata):
1324 * window.c (resize_window_check, resize_root_window): Now static.
1325 * window.h (resize_window_check, resize_root_window): Remove decls.
1327 * window.c (window_deletion_count, delete_deletable_window):
1329 (window_body_lines): Now static.
1330 (Fdelete_other_windows_internal): Mark vars as initialized.
1331 Make sure 'resize_failed' is initialized.
1332 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1333 (resize_window_apply): Remove unused local.
1334 * window.h (delete_deletable_window): Remove decl.
1336 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1337 (imagemagick_load_image): Fix pointer signedness problem by changing
1338 last arg from unsigned char * to char *. All uses changed.
1339 Also, fix a local for similar reasons.
1340 Remove unused locals. Remove locals to avoid shadowing.
1341 (fn_rsvg_handle_free): Remove; unused.
1342 (svg_load, svg_load_image): Fix pointer signedness problem.
1343 (imagemagick_load_image): Don't use garbage pointer image_wand.
1345 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1347 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1349 * image.c (gif_load): Fix omitted cast error introduced by
1352 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1354 * window.h (resize_proportionally, orig_total_lines)
1355 (orig_top_line): Remove from window structure.
1356 (set_window_height, set_window_width, change_window_heights)
1357 (Fdelete_window): Remove prototypes.
1358 (resize_frame_windows): Remove duplicate declaration.
1360 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1362 * window.h (resize_frame_windows, resize_window_check)
1363 (delete_deletable_window, resize_root_window)
1364 (resize_frame_windows): Declare prototypes.
1366 * window.c (resize_window_apply): Make definition be "static" to
1367 match the prototype.
1369 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1371 * window.c: Remove declarations of Qwindow_size_fixed,
1372 window_min_size_1, window_min_size_2, window_min_size,
1373 size_window, window_fixed_size_p, enlarge_window, delete_window.
1374 Remove static from declaration of Qdelete_window, it's
1375 temporarily needed by Fbury_buffer.
1376 (replace_window): Don't assign orig_top_line and
1378 (Fdelete_window, delete_window): Remove. Window deletion is
1379 handled by window.el.
1380 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1381 Fdelete_window calls with calls to Qdelete_window.
1382 (Fdelete_other_windows): Remove. Deleting other windows is
1383 handled by window.el.
1384 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1385 handled in window.el.
1386 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1387 Window minimum sizes are handled in window.el.
1388 (shrink_windows, size_window, set_window_height)
1389 (set_window_width, change_window_heights, window_height)
1390 (window_width, CURBEG, CURSIZE, enlarge_window)
1391 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1392 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1393 handled in window.el.
1394 (make_dummy_parent): Rename to make_parent_window and give it a
1395 second argument horflag.
1396 (make_window): Don't set resize_proportionally any more.
1397 (Fsplit_window): Remove. Windows are split in window.el.
1398 (save_restore_action, save_restore_orig_size)
1399 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1400 Resize mini windows in window.el.
1401 (grow_mini_window, shrink_mini_window): Implement by calling
1402 Qresize_root_window_vertically, resize_window_check and
1403 resize_window_apply.
1404 (saved_window, Fset_window_configuration, save_window_save): Do
1405 not handle orig_top_line, orig_total_lines, and
1406 resize_proportionally.
1407 (window_min_height, window_min_width): Move to window.el.
1408 (keys_of_window): Move bindings for delete-other-windows,
1409 split-window, delete-window and enlarge-window to window.el.
1411 * buffer.c: Temporarily extern Qdelete_window.
1412 (Fbury_buffer): Temporarily call Qdelete_window instead of
1413 Fdelete_window (Fbury_buffer will move to window.el soon).
1415 * frame.c (set_menu_bar_lines_1): Remove code handling
1416 orig_top_line and orig_total_lines.
1418 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1419 set_window_height but set heights directly.
1420 (change_frame_size_1): Use resize_frame_windows.
1422 * xdisp.c (init_xdisp): Don't use set_window_height but set
1425 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1426 resize_frame_windows instead of change_window_heights and run
1427 run_window_configuration_change_hook.
1429 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1430 instead of change_window_heights and run
1431 run_window_configuration_change_hook.
1433 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1435 * window.c (replace_window): Rename second argument REPLACEMENT to
1436 NEW. New third argument SETFLAG. Rewrite.
1437 (delete_window, make_dummy_parent): Call replace_window with
1439 (window_list_1): Move down in code.
1440 (run_window_configuration_change_hook): Move set_buffer part
1441 before select_frame_norecord part in order to unwind correctly.
1442 Rename count1 to count.
1443 (recombine_windows, delete_deletable_window, resize_root_window)
1444 (Fdelete_other_windows_internal)
1445 (Frun_window_configuration_change_hook, make_parent_window)
1446 (resize_window_check, resize_window_apply, Fresize_window_apply)
1447 (resize_frame_windows, Fsplit_window_internal)
1448 (Fdelete_window_internal, Fresize_mini_window_internal): New
1450 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1452 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1454 * window.h (window): Add some new members to window structure -
1455 normal_lines, normal_cols, new_total, new_normal, clone_number,
1456 splits, nest, prev_buffers, next_buffers.
1457 (WINDOW_TOTAL_SIZE): Move here from window.c.
1458 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1460 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1462 (make_dummy_parent): Set new members of windows structure.
1463 (make_window): Move down in code. Handle new members of window
1465 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1466 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1467 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1468 (Fset_window_prev_buffers, Fwindow_next_buffers)
1469 (Fset_window_next_buffers, Fset_window_clone_number): New
1471 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1472 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1474 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1475 Argument WINDOW can be now internal window too.
1476 (Fwindow_use_time): Move up in code.
1477 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1479 (Fset_window_configuration, saved_window)
1480 (Fcurrent_window_configuration, save_window_save): Handle new
1481 members of window structure.
1482 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1483 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1484 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1485 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1486 Qget_mru_window, Qresize_root_window,
1487 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1488 Qauto_buffer_name; staticpro them.
1490 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1492 * window.c (Fwindow_total_size, Fwindow_left_column)
1493 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1494 (Fwindow_list_1): New functions.
1495 (window_box_text_cols): Replace with window_body_cols.
1496 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1497 window_body_cols instead of window_box_text_cols.
1498 (delete_window, Fset_window_configuration): Call
1499 delete_all_subwindows with window as argument.
1500 (delete_all_subwindows): Take a window as argument and not a
1502 (window_loop): Remove handling of GET_LRU_WINDOW and
1504 (Fget_lru_window, Fget_largest_window): Move to window.el.
1506 * window.h: Extern window_body_cols instead of
1507 window_box_text_cols. delete_all_subwindows now takes a
1508 Lisp_Object as argument.
1510 * indent.c (compute_motion, Fcompute_motion): Use
1511 window_body_cols instead of window_box_text_cols.
1513 * frame.c (delete_frame): Call delete_all_subwindows with root
1516 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1518 * fns.c (Fputhash): Document return value.
1520 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1522 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1524 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1526 Cons<->int and similar integer overflow fixes (Bug#8794).
1528 Check for overflow when converting integer to cons and back.
1529 * charset.c (Fdefine_charset_internal, Fdecode_char):
1530 Use cons_to_unsigned to catch overflow.
1531 (Fencode_char): Use INTEGER_TO_CONS.
1532 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1533 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1534 * data.c (long_to_cons, cons_to_long): Remove.
1535 (cons_to_unsigned, cons_to_signed): New functions.
1536 These signal an error for invalid or out-of-range values.
1537 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1538 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1539 * font.c (Ffont_variation_glyphs):
1540 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1541 * lisp.h: Include <intprops.h>.
1542 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1543 (cons_to_signed, cons_to_unsigned): New decls.
1544 (long_to_cons, cons_to_long): Remove decls.
1545 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1546 (Fprimitive_undo): Use CONS_TO_INTEGER.
1547 * xfns.c (Fx_window_property): Likewise.
1548 * xselect.c: Include <limits.h>.
1549 (x_own_selection, selection_data_to_lisp_data):
1550 Use INTEGER_TO_CONS.
1551 (x_handle_selection_request, x_handle_selection_clear)
1552 (x_get_foreign_selection, Fx_disown_selection_internal)
1553 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1554 (lisp_data_to_selection_data): Use cons_to_unsigned.
1555 (x_fill_property_data): Use cons_to_signed.
1556 Report values out of range.
1558 Check for buffer and string overflow more precisely.
1559 * buffer.h (BUF_BYTES_MAX): New macro.
1560 * lisp.h (STRING_BYTES_MAX): New macro.
1561 * alloc.c (Fmake_string):
1562 * character.c (string_escape_byte8):
1563 * coding.c (coding_alloc_by_realloc):
1564 * doprnt.c (doprnt):
1565 * editfns.c (Fformat):
1567 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1568 since they may not be the same number.
1569 * editfns.c (Finsert_char):
1570 * fileio.c (Finsert_file_contents):
1571 Likewise for BUF_BYTES_MAX.
1573 * image.c: Use ptrdiff_t, not int, for sizes.
1574 (slurp_file): Switch from int to ptrdiff_t.
1576 (slurp_file): Check that file size fits in both size_t (for
1577 malloc) and ptrdiff_t (for sanity and safety).
1579 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1580 if b->modtime has its maximal value.
1582 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1584 Don't assume time_t can fit into int.
1585 * buffer.h (struct buffer.modtime): Now time_t, not int.
1586 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1587 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1589 Minor fixes for signed vs unsigned integers.
1590 * character.h (MAYBE_UNIFY_CHAR):
1591 * charset.c (maybe_unify_char):
1592 * keyboard.c (read_char, reorder_modifiers):
1593 XINT -> XFASTINT, since the integer must be nonnegative.
1594 * ftfont.c (ftfont_spec_pattern):
1595 * keymap.c (access_keymap, silly_event_symbol_error):
1596 XUINT -> XFASTINT, since the integer must be nonnegative.
1597 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1598 since it makes no difference and we prefer signed.
1599 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1600 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1603 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1605 * window.h (Fwindow_frame): Declare.
1607 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1609 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1610 (SPARE_MEMORY): Always define.
1611 (LARGE_REQUEST): Remove.
1612 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1614 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1616 * lisp.h: Move EXFUNS for Fframe_root_window,
1617 Fframe_first_window and Fset_frame_selected_window to window.h.
1619 * window.h: Move EXFUNS for Fframe_root_window,
1620 Fframe_first_window and Fset_frame_selected_window here from
1623 * frame.c (Fwindow_frame, Fframe_first_window)
1624 (Fframe_root_window, Fframe_selected_window)
1625 (Fset_frame_selected_window): Move to window.c.
1626 (Factive_minibuffer_window): Move to minibuf.c.
1627 (Fother_visible_frames_p): New function.
1629 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1631 * window.c (decode_window, decode_any_window): Move up in code.
1632 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1633 (inhibit_frame_unsplittable): Remove unused variable.
1634 (Fwindow_buffer): Move up and rewrite doc-string.
1635 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1636 (Fwindow_prev): New functions.
1637 (Fwindow_frame): Move here from frame.c. Accept any window as
1639 (Fframe_root_window, Fframe_first_window)
1640 (Fframe_selected_window): Move here from frame.c. Accept frame
1641 or arbitrary window as argument. Update doc-strings.
1642 (Fminibuffer_window): Move up in code.
1643 (Fwindow_minibuffer_p): Move up in code and simplify.
1644 (Fset_frame_selected_window): Move here from frame.c.
1646 (Fselected_window, select_window, Fselect_window): Move up in
1647 code. Minor doc-string fixes.
1649 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1651 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1652 Do not assume that spare memory exists; that assumption is valid
1653 only if SYSTEM_MALLOC.
1654 (LARGE_REQUEST): New macro, so that the issue of large requests
1655 is separated from the issue of spare memory.
1657 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1659 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1662 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1664 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1667 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1669 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1671 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1673 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1674 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1676 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1678 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1680 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1682 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1683 (x_clipboard_manager_save): Add return value.
1684 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1686 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1687 Obey Vx_select_enable_clipboard_manager. Catch errors in
1688 x_clipboard_manager_save (Bug#8779).
1689 (Vx_select_enable_clipboard_manager): New variable.
1690 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1692 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1694 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1696 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1698 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1699 in the current matrix if keep_current_p is non-zero.
1701 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1703 * bidi.c (bidi_level_of_next_char): Fix last change.
1705 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1707 Support bidi reordering of text covered by display properties.
1709 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1710 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1711 (bidi_cache_search, bidi_cache_iterator_state)
1712 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1713 (bidi_level_of_next_char, bidi_move_to_visually_next):
1714 Support character positions inside a run of characters covered by a
1716 (bidi_paragraph_init, bidi_resolve_explicit_1)
1717 (bidi_level_of_next_char): Call bidi_fetch_char and
1718 bidi_fetch_char_advance instead of FETCH_CHAR and
1720 (bidi_init_it): Initialize new members.
1721 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1723 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1724 instead of using explicit *_CHAR codes.
1725 (bidi_resolve_explicit, bidi_resolve_weak):
1726 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1727 bidirectional text is supported only in multibyte buffers.
1728 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1729 it to initialize the frame_window_p member of struct bidi_it.
1730 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1731 (bidi_resolve_explicit, bidi_resolve_weak)
1732 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1733 bidi_it->nchars is non-positive.
1734 (bidi_level_of_next_char): Don't try to lookup the cache for the
1735 next/previous character if nothing is cached there yet, or if we
1736 were just reseat()'ed to a new position.
1738 * xdisp.c (set_cursor_from_row): Set start and stop points
1739 according to the row's direction when priming the loop that looks
1740 for the glyph on which to display cursor.
1741 (single_display_spec_intangible_p): Function deleted.
1742 (display_prop_intangible_p): Reimplement to call
1743 handle_display_spec instead of single_display_spec_intangible_p.
1744 Accept 3 additional arguments needed by handle_display_spec.
1745 This fixes incorrect cursor motion across display property with complex
1746 values: lists, `(when COND...)' forms, etc.
1747 (single_display_spec_string_p): Support property values that are
1748 lists with the argument STRING its top-level element.
1749 (display_prop_string_p): Fix the condition for processing a
1750 property that is a list to be consistent with handle_display_spec.
1751 (handle_display_spec): New function, refactored from the
1752 last portion of handle_display_prop.
1753 (compute_display_string_pos): Accept additional argument
1754 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1755 value of a `display' property is a "replacing spec".
1756 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1757 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1758 the display property, but just return a value indicating whether
1759 the display property will replace the characters it covers.
1760 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1761 frame_window_p members of struct bidi_it.
1762 (compute_display_string_pos, compute_display_string_end):
1764 (push_it): Accept second argument POSITION, where pop_it should
1765 jump to continue iteration.
1766 (reseat_1): Initialize bidi_it.disp_pos.
1768 * keyboard.c (adjust_point_for_property): Adjust the call to
1769 display_prop_intangible_p to its new signature.
1771 * dispextern.h (struct bidi_it): New member frame_window_p.
1772 (bidi_init_it): Update prototypes.
1773 (display_prop_intangible_p): Update prototype.
1774 (compute_display_string_pos, compute_display_string_end):
1776 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1779 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1781 Malloc failure behavior now depends on size of allocation.
1782 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1783 * lisp.h: Change signatures accordingly.
1784 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1785 All callers changed. (Bug#8762)
1787 * gnutls.c: Use Emacs's memory allocators.
1788 Without this change, the gnutls library would invoke malloc etc.
1789 directly, which causes problems on non-SYNC_INPUT hosts, and which
1790 runs afoul of improving memory_full behavior. (Bug#8761)
1791 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1792 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1793 xfree instead of the default malloc, realloc, free.
1794 (Fgnutls_boot): No need to check for memory allocation failure,
1795 since xmalloc does that for us.
1797 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1798 * category.c (hash_get_category_set):
1799 * ccl.c (ccl_driver):
1800 * charset.c (Fdefine_charset_internal):
1801 * charset.h (struct charset.hash_index):
1802 * composite.c (get_composition_id, gstring_lookup_cache)
1803 (composition_gstring_put_cache):
1804 * composite.h (struct composition.hash_index):
1805 * dispextern.h (struct image.hash):
1806 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1807 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1808 (hashfn_equal, hashfn_user_defined, make_hash_table)
1809 (maybe_resize_hash_table, hash_lookup, hash_put)
1810 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1811 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1812 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1813 * image.c (make_image, search_image_cache, lookup_image)
1814 (xpm_put_color_table_h):
1815 * lisp.h (struct Lisp_Hash_Table):
1816 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1817 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1818 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1819 * alloc.c (allocate_vectorlike):
1820 Check for overflow in vector size calculations.
1821 * ccl.c (ccl_driver):
1822 Check for overflow when converting EMACS_INT to int.
1823 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1824 need to be updated by these changes.
1825 * fns.c (make_hash_table, maybe_resize_hash_table):
1826 Check for integer overflow with large hash tables.
1827 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1828 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1829 (SXHASH_REDUCE): New macro.
1830 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1831 Use it instead of discarding useful hash info with large hash values.
1832 (sxhash_float): New function.
1833 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1834 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1835 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1836 Rewrite to use FIXNUM_BITS, as this simplifies things.
1837 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1838 Adjust signatures to match updated version of code.
1839 (consing_since_gc): Now EMACS_INT, since a single hash table can
1840 use more than INT_MAX bytes.
1842 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1844 Make it possible to build with GCC-4.6+ -O2 -flto.
1846 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1848 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1850 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1851 Call minibuffer-inactive-mode.
1853 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1855 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1856 Update dependencies.
1858 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1860 * data.c (init_data): Remove code for UTS, this system is not
1863 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1865 Don't force ./temacs to start in terminal mode.
1867 * frame.c (make_initial_frame): Initialize faces in all cases, not
1868 only when CANNOT_DUMP is defined.
1869 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1871 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1873 * dispnew.c (add_window_display_history): Use const for the string
1874 pointer. Remove declaration, not needed.
1876 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1878 Use 'inline', not 'INLINE'.
1879 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1880 * alloc.c, fontset.c (INLINE): Remove.
1881 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1882 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1883 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1884 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1885 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1887 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1889 Make it possible to run ./temacs.
1891 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1892 syms_of_callproc does the same thing. Remove test for
1893 "initialized", do it in the caller.
1894 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1896 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1898 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1899 (read_minibuf): Use get_minibuffer.
1900 (syms_of_minibuf): Use DEFSYM.
1901 (Qmetadata): New var.
1902 * data.c (Qbuffer): Don't make it static.
1903 (syms_of_data): Use DEFSYM.
1905 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1907 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1908 (CCL_CODE_MIN): New macro.
1910 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1912 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1914 * eval.c (Qdebug): Now static.
1915 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1916 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1917 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1919 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1921 * image.c: Various fixes to ImageMagick code comments.
1922 (Fimagemagick_types): Doc fix.
1924 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1926 Minor fixes prompted by GCC 4.6.0 warnings.
1928 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1930 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1931 (x_clipboard_manager_save_all): Move extern decl to ...
1932 * xterm.h: ... here, so that it can be checked for consistency.
1934 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1936 * xselect.c (x_clipboard_manager_save_frame)
1937 (x_clipboard_manager_save_all): New functions.
1938 (Fx_clipboard_manager_save): Lisp function deleted.
1940 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1941 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1943 * xterm.h: Update prototype.
1945 2011-05-28 William Xu <william.xwl@gmail.com>
1947 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1950 2011-05-28 Jim Meyering <meyering@redhat.com>
1952 Avoid a sign-extension bug in crypto_hash_function.
1953 * fns.c (to_uchar): Define.
1954 (crypto_hash_function): Use it to convert some newly-signed
1955 variables to unsigned, to avoid sign-extension bugs. For example,
1956 without this change, (md5 "truc") would evaluate to
1957 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1958 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1959 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1961 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1963 Integer overflow fixes.
1965 * dbusbind.c: Serial number integer overflow fixes.
1966 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1967 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1968 to hold a serial number that is too large for a fixnum.
1969 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1970 Check for serial numbers out of range. Decode any serial number
1971 that was so large that it became a float. (Bug#8722)
1973 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1974 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1975 Use XFASTINT rather than XUINT when numbers are nonnegative.
1976 (xd_append_arg, Fdbus_method_return_internal):
1977 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1978 arguments, check that Lisp number is nonnegative, rather than
1979 silently wrapping negative numbers around. (Bug#8722)
1980 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1983 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1985 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1987 ccl: add integer overflow checks
1988 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1989 (IN_INT_RANGE): New macros.
1990 (ccl_driver): Use them to check for integer overflow when
1991 decoding a CCL program. Many of the new checks are whether XINT (x)
1992 fits in int; it doesn't always, on 64-bit hosts. The new version
1993 doesn't catch all possible integer overflows, but it's an
1994 improvement. (Bug#8719)
1996 * alloc.c (make_event_array): Use XINT, not XUINT.
1997 There's no need for unsigned here.
1999 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2000 This follows up to the 2011-05-06 change that substituted uintptr_t
2001 for EMACS_INT. This case wasn't caught back then.
2003 Rework Fformat to avoid integer overflow issues.
2004 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2005 now (part of C89). Include <verify.h>.
2006 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2007 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2008 (Fformat): Avoid the prepass trying to compute sizes; it was only
2009 approximate and thus did not catch overflow reliably. Instead, walk
2010 through the format just once, formatting and computing sizes as we go,
2011 checking for integer overflow at every step, and allocating a larger
2012 buffer as needed. Keep track separately whether the format is
2013 multibyte. Keep only the most-recently calculated precision, rather
2014 than them all. Record whether each argument has been converted to
2015 string. Use EMACS_INT, not int, for byte and char and arg counts.
2016 Support field widths and precisions larger than INT_MAX. Avoid
2017 sprintf's undefined behavior with conversion specifications such as %#d
2018 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2019 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2020 formatting out-of-range floating point numbers with int
2023 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2025 * data.c: Avoid integer truncation in expressions involving floats.
2026 * data.c: Include <intprops.h>.
2027 (arith_driver): When there's an integer overflow in an expression
2028 involving floating point, convert the integers to floating point
2029 so that the resulting value does not suffer from catastrophic
2030 integer truncation. For example, on a 64-bit host (* 4
2031 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2032 Do not rely on undefined behavior after integer overflow.
2034 merge count_size_as_multibyte, parse_str_to_multibyte
2035 * character.c, character.h (count_size_as_multibyte):
2036 Rename from parse_str_to_multibyte; all uses changed.
2037 Check for integer overflow.
2038 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2039 since it's now a duplicate of the other. This is more of
2040 a character than a buffer op, so better that it's in character.c.
2041 * fns.c, print.c: Adjust to above changes.
2043 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2045 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2047 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2049 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2050 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2051 (x_clipboard_manager_save): Now static.
2052 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2054 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2055 (crypto_hash_function): Now static.
2056 Fix pointer signedness problems. Avoid unnecessary initializations.
2058 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2060 * termhooks.h (Vselection_alist): Make it terminal-local.
2062 * terminal.c (create_terminal): Initialize it.
2064 * xselect.c: Support for clipboard managers.
2065 (Vselection_alist): Move to termhooks.h as terminal-local var.
2066 (LOCAL_SELECTION): New macro.
2067 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2068 (symbol_to_x_atom): Remove gratuitous arg.
2069 (x_handle_selection_request, lisp_data_to_selection_data)
2070 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2071 (x_own_selection, x_get_local_selection, x_convert_selection):
2072 New arg, specifying work frame. Use terminal-local Vselection_alist.
2073 (some_frame_on_display): Delete unused function.
2074 (Fx_own_selection_internal, Fx_get_selection_internal)
2075 (Fx_disown_selection_internal, Fx_selection_owner_p)
2076 (Fx_selection_exists_p): New optional frame arg.
2077 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2078 (x_handle_selection_clear): Don't treat other terminals with the
2079 same keyboard specially. Use the terminal-local Vselection_alist.
2080 (x_clear_frame_selections): Use Frun_hook_with_args.
2082 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2084 * xterm.h: Add support for those atoms.
2086 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2088 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2089 (converted_selections, conversion_fail_tag): New global variables.
2090 (x_selection_request_lisp_error): Free the above.
2091 (x_get_local_selection): Remove unnecessary code.
2092 (x_reply_selection_request): Args changed; handle arbitrary array
2093 of converted selections stored in converted_selections.
2094 Separate the XChangeProperty and SelectionNotify steps.
2095 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2096 (x_convert_selection): New function.
2097 (x_handle_selection_event): Simplify.
2098 (x_get_foreign_selection): Don't ignore incoming requests while
2099 waiting for an answer; this will fail when we implement
2100 SAVE_TARGETS, and seems unnecessary anyway.
2101 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2102 (Vx_sent_selection_functions): Doc fix.
2104 2011-05-26 Leo Liu <sdl.web@gmail.com>
2106 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2108 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2110 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2112 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2113 for fringe update if it has periodic bitmap.
2114 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2115 and fringe_bitmap_periodic_p.
2117 * fringe.c (get_fringe_bitmap_data): New function.
2118 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2119 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2120 row. Mark glyph row for fringe update if periodicity changed.
2122 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2123 for fringe update unless it has periodic bitmap.
2125 2011-05-25 Kenichi Handa <handa@m17n.org>
2127 * xdisp.c (get_next_display_element): Set correct it->face_id for
2128 a static composition.
2130 2011-05-24 Leo Liu <sdl.web@gmail.com>
2133 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2135 * fns.c (crypto_hash_function, Fsha1): New function.
2136 (Fmd5): Use crypto_hash_function.
2137 (syms_of_fns): Add Ssha1.
2139 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2141 * gnutls.c: Remove unused macros.
2142 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2143 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2144 Remove macros that are defined and never used.
2145 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2147 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2149 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2150 (Fx_get_selection_internal): Minor cleanup.
2151 (Fx_own_selection_internal): Rename arguments for consistency with
2154 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2156 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2158 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2160 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2162 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2164 * dispnew.c (scrolling_window): Don't exclude the case that the
2165 last enabled row in the desired matrix touches the bottom boundary.
2167 2011-05-21 Glenn Morris <rgm@gnu.org>
2169 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2170 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2171 and add some more files.
2173 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2175 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2176 report_file_error introduced by the change from 2011-05-07.
2178 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2180 * systime.h (Time): Define only if emacs is defined.
2181 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2182 where the include path doesn't have X11/X.h by default. See
2183 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2185 2011-05-20 Kenichi Handa <handa@m17n.org>
2187 * composite.c (find_automatic_composition): Fix previous change.
2189 2011-05-20 Glenn Morris <rgm@gnu.org>
2191 * lisp.mk: New file, split from Makefile.in.
2192 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2193 (shortlisp): Remove.
2194 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2196 2011-05-19 Glenn Morris <rgm@gnu.org>
2198 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2199 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2200 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2201 (lisp): Set the order to that of loadup.el.
2202 (shortlisp): Make it a copy of $lisp.
2203 (SOME_MACHINE_LISP): Remove.
2204 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2205 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2207 2011-05-18 Kenichi Handa <handa@m17n.org>
2209 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2210 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2211 (find_automatic_composition): Mostly rewrite for efficiency.
2213 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2215 * makefile.w32-in: Update dependencies.
2217 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2219 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2220 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2222 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2224 Fix some integer overflow issues, such as string length overflow.
2226 * insdel.c (count_size_as_multibyte): Check for string overflow.
2228 * character.c (lisp_string_width): Check for string overflow.
2229 Use EMACS_INT, not int, for string indexes and lengths; in
2230 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2231 the resulting string length overflows an EMACS_INT; instead,
2232 report a string overflow if no precision given. When checking for
2233 precision exhaustion, use a check that cannot possibly have
2234 integer overflow. (Bug#8675)
2235 * character.h (lisp_string_width): Adjust to new signature.
2237 * alloc.c (string_overflow): New function.
2238 (Fmake_string): Use it. This doesn't change behavior, but saves
2239 a few bytes and will simplify future changes.
2240 * character.c (string_escape_byte8): Likewise.
2241 * lisp.h (string_overflow): New decl.
2243 Fixups, following up to the user-interface timestamp change.
2244 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2245 for UI timestamps, instead of unsigned long.
2246 * msdos.c (mouse_get_pos): Likewise.
2247 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2248 * w32gui.h (Time): Define by including "systime.h" rather than by
2249 declaring it ourselves. (Bug#8664)
2251 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2252 * image.c (clear_image_cache): Likewise.
2254 * term.c (term_mouse_position): Don't assume time_t wraparound.
2256 Be more systematic about user-interface timestamps.
2257 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2258 and sometimes 'EMACS_UINT', to represent these timestamps.
2259 This change causes it to use 'Time' uniformly, as that's what X uses.
2260 This makes the code easier to follow, and makes it easier to catch
2261 integer overflow bugs such as Bug#8664.
2262 * frame.c (Fmouse_position, Fmouse_pixel_position):
2263 Use Time, not unsigned long, for user-interface timestamps.
2264 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2265 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2266 * keyboard.h (last_event_timestamp): Likewise.
2267 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2268 * menu.h (xmenu_show): Likewise.
2269 * term.c (term_mouse_position): Likewise.
2270 * termhooks.h (struct input_event.timestamp): Likewise.
2271 (struct terminal.mouse_position_hook): Likewise.
2272 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2273 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2274 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2275 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2277 * menu.h, termhooks.h: Include "systime.h", for Time.
2279 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2280 Don't assume that the difference between two unsigned long values
2281 can fit into an integer. At this point, we know button_down_time
2282 <= event->timestamp, so the difference must be nonnegative, so
2283 there's no need to cast the result if double-click-time is
2284 nonnegative, as it should be; check that it's nonnegative, just in
2285 case. This bug is triggered when events are more than 2**31 ms
2286 apart (about 25 days). (Bug#8664)
2288 * xselect.c (last_event_timestamp): Remove duplicate decl.
2289 (x_own_selection): Remove needless cast to unsigned long.
2291 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2292 that always fit in int. Use a sentinel instead of a counter, to
2293 avoid a temp and to allay GCC's concerns about possible int overflow.
2294 * frame.h (struct frame): Use int for menu_bar_items_used
2295 instead of EMACS_INT, since it always fits in int.
2297 * menu.c (grow_menu_items): Check for int overflow.
2299 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2301 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2302 Before, the code was not consistent. These values cannot exceed
2303 2**31 - 1 so there's no need to make them unsigned.
2304 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2305 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2306 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2308 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2310 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2311 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2312 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2313 presumably because the widths might not match.
2315 * window.c (size_window): Avoid needless test at loop start.
2317 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2319 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2321 2011-05-12 Drew Adams <drew.adams@oracle.com>
2323 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2325 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2327 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2328 `width' to `bar_area_x' and `bar_area_width', respectively.
2329 (x_scroll_run): Take account of fringe background extension.
2331 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2332 Rename local vars `left' and `width' to `bar_area_x' and
2333 `bar_area_width', respectively.
2334 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2335 background extension.
2337 2011-05-10 Jim Meyering <meyering@redhat.com>
2339 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2341 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2343 * image.c (Finit_image_library): Return t for built-in image types,
2344 like pbm and xbm. (Bug#8640)
2346 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2348 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2350 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2352 * w32console.c (Fset_screen_color): Doc fix.
2353 (Fget_screen_color): New function.
2354 (syms_of_ntterm): Defsubr it.
2356 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2357 unlink the temporary file if Fcall_process didn't create it in the
2359 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2360 child process will be redirected to a file specified with `:file'.
2361 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2362 cue to call_process_cleanup not to close that handle.
2364 2011-05-07 Ben Key <bkey76@gmail.com>
2366 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2367 one of two shell specific rules, either bootstrap-temacs-CMD or
2368 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2369 to the previous implementation of the bootstrap-temacs rule.
2370 The bootstrap-temacs-CMD rule is similar to the previous
2371 implementation of the bootstrap-temacs rule except that it
2372 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2375 These changes, along with some changes to nt/configure.bat,
2376 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2377 earlier fix to add support for --cflags and --ldflags options
2378 that include quotes so that it works whether make uses cmd or
2381 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2383 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2384 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2386 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2387 a string. Handle both cases.
2388 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2389 (Fdbus_register_method): Use Qinvalid_function.
2391 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2393 * makefile.w32-in: Update dependencies.
2394 (LISP_H): Add inttypes.h and stdin.h.
2395 (PROCESS_H): Add unistd.h.
2397 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2399 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2400 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2402 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2404 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2406 * term.c (vfatal): Remove stray call to va_end.
2407 It's not needed and the C Standard doesn't allow it here anyway.
2409 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2410 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2412 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2415 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2417 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2419 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2421 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2423 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2425 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2426 * charset.c (Fdefine_charset_internal): Don't initialize
2427 charset.code_space[15]. The value was garbage, on hosts with
2428 32-bit int (Bug#8600).
2430 * lread.c (read_integer): Be more consistent with string-to-number.
2431 Use string_to_number to do the actual conversion; this avoids
2432 rounding errors and fixes some other screwups. Without this fix,
2433 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2434 (digit_to_number): Move earlier, for benefit of read_integer.
2435 Return -1 if the digit is out of range for the base, -2 if it is
2436 not a digit in any supported base. (Bug#8602)
2438 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2440 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2441 to match comment at start of function. This also removes a
2442 GCC warning about overflow in a 32+64-bit port.
2444 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2446 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2447 Reported by Stefan Monnier in
2448 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2449 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2450 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2452 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2453 (EMACS_UINTPTR): Likewise, with uintptr_t.
2455 * lisp.h: Prefer 64-bit EMACS_INT if available.
2456 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2457 on 32-bit hosts that have 64-bit int, so that they can access
2459 However, temporarily disable this change unless the temporary
2460 symbol WIDE_EMACS_INT is defined.
2462 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2464 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2465 This removes an assumption that EMACS_INT and long are the same
2466 width as pointers. The assumption is true for Emacs porting targets
2467 now, but we want to make other targets possible.
2468 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2469 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2470 In the rest of the code, change types of integers that hold casted
2471 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2472 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2473 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2474 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2475 No need to cast type when ORing.
2476 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2477 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2478 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2479 assume EMACS_INT is the same width as char *.
2480 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2481 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2482 Remove no-longer-needed casts.
2483 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2484 (xg_tool_bar_help_callback, xg_make_tool_item):
2485 Use EMACS_INTPTR to hold an integer
2486 that will be cast to void *; this can avoid a GCC warning
2487 if EMACS_INT is not the same width as void *.
2488 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2489 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2490 (current_message_1, set_message_1):
2491 Use a local to convert to proper width without a cast.
2492 * xmenu.c (dialog_selection_callback): Likewise.
2494 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2495 Also, don't assume VALBITS / RAND_BITS is less than 5,
2496 and don't rely on undefined behavior when shifting a 1 left into
2498 * lisp.h (get_random): Change signature to match.
2500 * lread.c (hash_string): Use size_t, not int, for hash computation.
2501 Normally we prefer signed values; but hashing is special, because
2502 it's better to use unsigned division on hash table sizes so that
2503 the remainder is nonnegative. Also, size_t is the natural width
2504 for hashing into memory. The previous code used 'int', which doesn't
2505 retain enough info to hash well into very large tables.
2506 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2508 * dbusbind.c: Don't possibly lose pointer info when converting.
2509 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2510 Use XPNTR rather than XHASH, so that the high-order bits of
2511 the pointer aren't lost when converting through void *.
2513 * eval.c (Fautoload): Don't double-shift a pointer.
2515 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2517 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2519 * gnutls.c (DEF_GNUTLS_FN):
2520 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2522 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2524 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2527 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2529 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2530 New version that can reserve upto 2GB of heap space.
2532 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2534 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2536 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2538 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2539 `gnutls_certificate_set_x509_key_file'.
2541 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2543 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2544 Update dependencies.
2546 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2548 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2549 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2550 Remove unused parameter `fildes'.
2551 * process.c (read_process_output, send_process): Don't pass it.
2553 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2555 Fix previous change: the library cache is defined in w32.c.
2556 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2557 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2559 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2561 Implement dynamic loading of GnuTLS on Windows.
2563 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2564 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2565 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2568 * gnutls.c (Qgnutls_dll): Define.
2569 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2570 (gnutls_*): Declare function pointers.
2571 (init_gnutls_functions): New function to initialize function pointers.
2572 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2573 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2574 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2575 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2576 (emacs_gnutls_write, emacs_gnutls_read)
2577 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2578 (Fgnutls_available_p): New function.
2579 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2580 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2581 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2583 * image.c: Include w32.h.
2584 (Vimage_type_cache): Delete.
2585 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2586 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2587 (w32_delayed_load): Move to w32.c.
2589 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2591 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2592 (w32_delayed_load): Move from image.c. When loading a library, record
2593 its filename in the :loaded-from property of the library id.
2594 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2595 Initialize and staticpro them.
2596 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2598 * process.c: Include lisp.h before w32.h, not after.
2599 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2600 instead of gnutls_record_check_pending.
2602 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2604 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2606 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2607 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2610 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2612 * xterm.c (x_set_frame_alpha): Do not set property on anything
2613 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2615 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2617 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2619 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2621 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2622 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2623 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2624 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2625 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2626 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2627 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2628 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2629 (Qgnutls_bootprop_callbacks_verify): Make static.
2631 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2633 * callproc.c: Indentation fixup.
2635 * sysdep.c (wait_for_termination_1): Make static.
2636 (wait_for_termination, interruptible_wait_for_termination):
2637 Move after wait_for_termination_1.
2639 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2641 * sysdep.c (interruptible_wait_for_termination): New function
2642 which is like wait_for_termination, but allows keyboard
2645 * callproc.c (Fcall_process): Add (:file "file") as an option for
2647 (Fcall_process_region): Ditto.
2649 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2651 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2652 rather than `XVECTOR (FOO)->size'.
2654 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2655 inttypes.h, as a gnulib replacement is used if it not available in
2658 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2660 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2661 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2662 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2664 * coding.c (coding_alloc_by_realloc): Error out if destination
2665 will grow beyond MOST_POSITIVE_FIXNUM.
2666 (decode_coding_emacs_mule): Abort if there isn't enough place in
2667 charbuf for the composition carryover bytes. Reserve an extra
2668 space for up to 2 characters produced in a loop.
2669 (decode_coding_iso_2022): Abort if there isn't enough place in
2670 charbuf for the composition carryover bytes.
2672 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2674 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2675 aborting when %lld or %lll format is passed.
2676 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2677 %llo or %llx format is passed. (Bug#8545)
2679 * window.c (window_scroll_line_based): Use a marker instead of
2680 simple variables to record original value of point. (Bug#7952)
2682 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2683 produced by %s or %c overflows available buffer space. (Bug#8545)
2685 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2687 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2688 (SIZE_MAX): Move defn after all includes, as they might #define it.
2690 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2692 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2694 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2696 * keyboard.c (Qdelayed_warnings_hook): Define.
2697 (command_loop_1): Run `delayed-warnings-hook'
2698 if Vdelayed_warnings_list is non-nil.
2699 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2700 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2702 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2704 * doprnt.c (doprnt): Don't return value smaller than the buffer
2705 size if the message was truncated. (Bug#8545).
2707 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2709 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2710 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2712 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2714 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2716 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2718 * makefile.w32-in: Update dependencies.
2720 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2722 Improve `doprnt' and its usage. (Bug#8545)
2723 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2724 `format_end'. Remove support for %l as a conversion specifier.
2725 Don't use xrealloc. Improve diagnostics when the %l size modifier
2726 is used. Update the commentary.
2728 * eval.c (verror): Simplify calculation of size_t.
2730 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2733 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2735 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2738 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2740 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2741 This makes this file independent of the recent pseudovector change.
2743 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2745 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2747 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2748 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2749 Remove unused local.
2750 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2752 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2753 GCC 4.6.0 optimizes based on type-based alias analysis.
2754 For example, if b is of type struct buffer * and v of type struct
2755 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2756 != &v->size, and therefore "v->size = 1; b->size = 2; return
2757 v->size;" must therefore return 1. This assumption is incorrect
2758 for Emacs, since it type-puns struct Lisp_Vector * with many other
2759 types. To fix this problem, this patch adds a new type struct
2760 vectorlike_header that documents the constraints on layout of vectors
2761 and pseudovectors, and helps optimizing compilers not get fooled
2762 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2763 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2764 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2766 (XSETPVECTYPE): Rewrite in terms of new macro.
2767 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2768 This is a bit clearer, and further avoids the possibility of
2769 undesirable aliasing.
2770 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2771 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2772 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2773 since Lisp_Subr is a special case (no "next" field).
2774 (ASIZE): Now uses header.size rather than size.
2775 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2776 to avoid the hassle of writing XVECTOR (foo)->header.size.
2777 (struct vectorlike_header): New type.
2778 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2779 object, to help avoid aliasing.
2780 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2781 (SUBRP): Likewise, since Lisp_Subr is a special case.
2782 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2783 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2784 (struct Lisp_Hash_Table): Combine first two members into a single
2785 struct vectorlike_header member. All uses of "size" and "next" members
2786 changed to be "header.size" and "header.next".
2787 * buffer.h (struct buffer): Likewise.
2788 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2789 * frame.h (struct frame): Likewise.
2790 * process.h (struct Lisp_Process): Likewise.
2791 * termhooks.h (struct terminal): Likewise.
2792 * window.c (struct save_window_data, struct saved_window): Likewise.
2793 * window.h (struct window): Likewise.
2794 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2795 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2796 * buffer.c (init_buffer_once): Likewise.
2797 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2799 * process.c (Fformat_network_address): Use local var for size,
2802 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2804 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2805 * data.c (atof): Remove decl; no longer used or needed.
2806 (digit_to_number): Move to lread.c.
2807 (Fstring_to_number): Use new string_to_number function, to be
2808 consistent with how the Lisp reader treats infinities and NaNs.
2809 Do not assume that floating-point numbers represent EMACS_INT
2810 without losing information; this is not true on most 64-bit hosts.
2811 Avoid double-rounding errors, by insisting on integers when
2812 parsing non-base-10 numbers, as the documentation specifies.
2813 * lisp.h (string_to_number): New decl, replacing ...
2814 (isfloat_string): Remove.
2815 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2816 (read1): Do not accept +. and -. as integers; this
2817 appears to have been a coding error. Similarly, do not accept
2818 strings like +-1e0 as floating point numbers. Do not report
2819 overflow for integer overflows unless the base is not 10 which
2820 means we have no simple and reliable way to continue.
2821 Break out the floating-point parsing into a new
2822 function string_to_number, so that Fstring_to_number parses
2823 floating point numbers consistently with the Lisp reader.
2824 (digit_to_number): Move here from data.c. Make it static inline.
2825 (E_CHAR, EXP_INT): Remove, replacing with ...
2826 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2827 (string_to_number): New function, replacing isfloat_string.
2828 This function checks for valid syntax and produces the resulting
2829 Lisp float number too. Rework it so that string-to-number
2830 no longer mishandles examples like "1.0e+". Use strtoumax,
2831 so that overflow for non-base-10 numbers is reported only when
2832 there's no portable and simple way to convert to floating point.
2834 * textprop.c (set_text_properties_1): Rewrite for clarity,
2835 and to avoid GCC warning about integer overflow.
2837 * intervals.h (struct interval): Use EMACS_INT for members
2838 where EMACS_UINT might cause problems. See
2839 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2840 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2841 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2843 (offset_intervals): Tell GCC not to worry about length overflow
2844 when negating a negative length.
2846 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2847 (overrun_check_free): Likewise.
2849 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2850 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2853 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2854 (gnutls_make_error): Rename local to avoid shadowing.
2855 (gnutls_emacs_global_deinit): ifdef out; not used.
2856 (Fgnutls_boot): Use const for pointer to readonly storage.
2857 Comment out unused local. Fix pointer signedness problems.
2859 * lread.c (openp): Don't stuff size_t into an 'int'.
2860 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2861 about possible signed overflow.
2863 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2864 (GDK_KEY_g): Don't define if already defined.
2865 (xg_prepare_tooltip): Avoid pointer signedness problem.
2866 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2868 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2869 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2871 * xfns.c (Fx_window_property): Simplify a bit,
2872 to make a bit faster and to avoid GCC 4.6.0 warning.
2873 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2875 * fns.c (internal_equal): Don't assume size_t fits in int.
2877 * alloc.c (compact_small_strings): Tighten assertion a little.
2879 Replace pEd with more-general pI, and fix some printf arg casts.
2880 * lisp.h (pI): New macro, generalizing old pEd macro to other
2881 conversion specifiers. For example, use "...%"pI"d..." rather
2882 than "...%"pEd"...".
2883 (pEd): Remove. All uses replaced with similar uses of pI.
2884 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2885 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2886 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2887 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2888 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2889 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2890 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2892 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2893 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2894 * print.c (safe_debug_print, print_object): Likewise.
2895 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2897 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2898 avoiding the 0 flag, which is not portable.
2899 * process.c (Fmake_network_process): Use pI to avoid cast.
2900 * region-cache.c (pp_cache): Likewise.
2901 * xdisp.c (decode_mode_spec): Likewise.
2902 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2903 behavior on 64-bit hosts with printf arg.
2904 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2905 (x_stop_queuing_selection_requests): Likewise.
2906 (x_get_window_property): Don't truncate byte count to an 'int'
2909 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2910 here, since it parses constructs like leading '-' and spaces,
2911 which are not wanted; and it overflows with large numbers.
2912 Instead, simply match F[0-9]+, which is what is wanted anyway.
2914 * alloc.c: Remove unportable assumptions about struct layout.
2915 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2916 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2917 (allocate_vectorlike, make_pure_vector): Use the new macros,
2918 plus offsetof, to remove unportable assumptions about struct layout.
2919 These assumptions hold on all porting targets that I know of, but
2920 they are not guaranteed, they're easy to remove, and removing them
2921 makes further changes easier.
2923 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2924 This doesn't fix a bug but makes the code clearer.
2925 (string_overrun_cookie): Now const. Use initializers that
2926 don't formally overflow signed char, to avoid warnings.
2927 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2928 can cause Emacs to crash when string overrun checking is enabled.
2929 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2930 multiple of sizeof (EMACS_INT); it need not be, if
2931 alignof(EMACS_INT) < sizeof (EMACS_INT).
2932 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2934 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2936 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2938 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2940 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2941 supposed to be handshaking. (Bug#8556)
2942 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2944 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2946 * lisp.h (Qdebug): List symbol.
2947 * eval.c (Qdebug): Restore global linkage.
2948 * keyboard.c (debug-on-event): New variable.
2949 (handle_user_signal): Break into debugger when debug-on-event
2950 matches the current signal symbol.
2952 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2954 * alloc.c (check_sblock, check_string_bytes)
2955 (check_string_free_list): Convert to standard C.
2957 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2959 * w32.c (emacs_gnutls_push): Fix typo.
2961 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2963 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2964 "cast to pointer from integer of different size".
2966 Improve doprnt and its use in verror. (Bug#8545)
2967 * doprnt.c (doprnt): Document the set of format control sequences
2968 supported by the function. Use SAFE_ALLOCA instead of always
2971 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2972 is one byte too soon. Don't use xrealloc; instead xfree and
2975 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2977 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2980 * gnutls.c: Renamed global_initialized to
2981 gnutls_global_initialized. Added internals for the
2982 :verify-hostname-error, :verify-error, and :verify-flags
2983 parameters of `gnutls-boot' and documented those parameters in the
2984 docstring. Start callback support.
2985 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2986 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2987 on error. Return error code.
2988 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2989 (emacs_gnutls_read): Likewise.
2990 (Fgnutls_boot): Return handshake error code.
2991 (emacs_gnutls_handle_error): New function.
2992 (wsaerror_to_errno): Likewise.
2994 * w32.h (emacs_gnutls_pull): Add prototype.
2995 (emacs_gnutls_push): Likewise.
2997 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2998 (emacs_gnutls_push): Likewise.
3000 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3002 * process.c (wait_reading_process_output): Check if GnuTLS
3003 buffered some data internally if no FDs are set for TLS
3006 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3007 (LIBS): Link to USER_LIBS.
3008 ($(BLD)/gnutls.$(0)): New target.
3010 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3012 * xdisp.c (handle_single_display_spec): Rename the
3013 display_replaced_before_p argument into display_replaced_p, to
3014 make it consistent with the commentary. Fix typos in the
3017 * textprop.c (syms_of_textprop): Remove dead code.
3018 (copy_text_properties): Delete obsolete commentary about an
3019 interface that was deleted long ago. Fix typos in the description
3022 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3023 to changes in oldXMenu/XMenu.h from 2011-04-16.
3024 <menu_help_message, prev_menu_help_message>: Constify.
3025 (IT_menu_make_room): menu->help_text is now `const char **';
3028 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3029 to changes in oldXMenu/XMenu.h from 2011-04-16.
3030 (struct XMenu): Declare `help_text' `const char **'.
3032 * xfaces.c <Qunspecified>: Make extern again.
3034 * syntax.c: Include sys/types.h before including regex.h, as
3037 * doc.c (get_doc_string): Improve the format passed to `error'.
3039 * doprnt.c (doprnt): Improve commentary.
3041 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3043 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3046 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3047 changes in globals.h immediately force recompilation.
3048 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3049 $(CURDIR)/s/ms-w32.h.
3050 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3052 * character.c (Fchar_direction): Function deleted.
3053 (syms_of_character): Don't defsubr it.
3054 <char-direction-table>: Deleted.
3056 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3058 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3059 * doprnt.c: Include limits.h.
3060 (SIZE_MAX): New macro.
3061 (doprnt): Return a size_t value. 2nd arg is now size_t.
3062 Many local variables are now size_t instead of int or unsigned.
3063 Improve overflow protection. Support `l' modifier for integer
3064 conversions. Support %l conversion. Don't assume an EMACS_INT
3065 argument for integer conversions and for %c.
3067 * lisp.h (doprnt): Restore prototype.
3069 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3072 * Makefile.in (base_obj): Add back doprnt.o.
3074 * deps.mk (doprnt.o): Add back prerequisites.
3075 (callint.o): Depend on character.h.
3077 * eval.c (internal_lisp_condition_case): Include the handler
3078 representation in the error message.
3079 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3080 when breaking from the loop.
3082 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3084 * callint.c (Fcall_interactively): When displaying error message
3085 about invalid control letter, pass the character's codepoint, not
3086 a pointer to its multibyte form. Improve display of the character
3087 in octal and display also its hex code.
3089 * character.c (char_string): Use %x to display the (unsigned)
3090 codepoint of an invalid character, to avoid displaying a bogus
3093 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3094 `error', not SYMBOL_NAME itself.
3096 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3097 character arguments to `error'.
3099 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3100 to `error' in error message about FINAL_CHAR argument. Make sure
3101 FINAL_CHAR is a character, and use %c when it is passed as
3102 argument to `error'.
3104 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3106 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3108 * w32.c: Include <time.h>.
3109 (sys_localtime): New function.
3111 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3113 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3115 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3117 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3119 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3122 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3124 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3125 gl_state.e_property when gl_state.object is Qt.
3127 * insdel.c (make_gap_larger): Remove limitation of buffer size
3130 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3132 * xdisp.c (lookup_glyphless_char_display)
3133 (produce_glyphless_glyph): Handle cons cell entry in
3134 glyphless-char-display.
3135 (Vglyphless_char_display): Document it.
3137 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3138 glyphless-char-display.
3140 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3142 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3144 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3146 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3147 definition for no-X builds.
3149 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3151 Static checks with GCC 4.6.0 and non-default toolkits.
3153 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3155 * process.c (keyboard_bit_set): Define only if SIGIO.
3156 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3157 (send_process): Repair possible setjmp clobbering.
3159 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3161 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3163 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3165 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3166 Define only if needed.
3168 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3169 by pacifying GCC about it. Maybe it's time to retire it?
3170 * xfaces.c (USG, __TIMEVAL__): Likewise.
3172 * dispextern.h (struct redisplay_interface): Rename param
3174 * termhooks.h (struct terminal): Likewise.
3175 * xterm.c (xembed_send_message): Likewise.
3177 * insdel.c (make_gap_smaller): Define only if
3178 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3180 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3183 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3184 so that we aren't warned about unused symbols.
3186 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3188 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3190 * xfns.c (x_real_positions): Mark locals as initialized.
3192 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3194 * xterm.c: Fix problems found by static analysis with other toolkits.
3195 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3196 (x_dispatch_event): Declare static if USE_GTK, and
3197 define if USE_GTK || USE_X_TOOLKIT.
3198 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3199 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3200 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3201 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3203 * xmenu.c (menu_help_callback): Pointer type fixes.
3204 Use const pointers when pointing at readonly data. Avoid pointer
3206 (FALSE): Remove unused macro.
3207 (update_frame_menubar): Remove unused decl.
3209 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3211 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3212 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3213 (single_menu_item): Rename local to avoid shadowing.
3215 * keyboard.c (make_lispy_event): Remove unused local var.
3217 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3218 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3220 * bitmaps: Change bitmaps from unsigned char back to the X11
3221 compatible char. Avoid the old compiler warnings about
3222 out-of-range initializers by using, for example, '\xab' rather
3225 * xgselect.c (xgselect_initialize): Check vs interface
3226 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3228 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3230 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3231 to read-only memory.
3233 * fns.c (vector): Remove; this old hack is no longer needed.
3235 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3237 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3239 * xrdb.c (x_load_resources): Omit unused local.
3241 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3242 (x_window): Rename locals to avoid shadowing.
3243 (USG): Use the kludged USG macro, to pacify gcc.
3245 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3246 (x_term_init): Remove local to avoid shadowing.
3248 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3250 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3251 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3253 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3255 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3257 Fix regex.c, syntax.c and friends for buffers > 2GB.
3258 * syntax.h (struct gl_state_s): Declare character position members
3261 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3263 * textprop.c (verify_interval_modification, interval_of):
3264 Declare arguments EMACS_INT.
3266 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3269 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3271 * indent.c (Fvertical_motion): Local variable it_start is now
3274 * regex.c (re_match, re_match_2, re_match_2_internal)
3275 (bcmp_translate, regcomp, regexec, print_double_string)
3276 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3277 (re_compile_pattern, re_exec): Declare arguments and local
3278 variables `size_t' and `ssize_t' and return values `regoff_t', as
3280 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3281 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3282 <compile_stack_type>: `size' and `avail' are now `size_t'.
3284 * regex.h <regoff_t>: Use ssize_t, not int.
3285 (re_search, re_search_2, re_match, re_match_2): Arguments that
3286 specify buffer/string position and length are now ssize_t and
3287 size_t. Return type is regoff_t.
3289 2011-04-16 Ben Key <bkey76@gmail.com>
3291 * nsfont.m: Fixed bugs in ns_get_family and
3292 ns_descriptor_to_entity that were caused by using free to
3293 deallocate memory blocks that were allocated by xmalloc (via
3294 xstrdup). This caused Emacs to crash when compiled with
3295 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3296 --enable-checking=xmallocoverrun). xfree is now used to
3297 deallocate these memory blocks.
3299 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3301 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3303 emacs_write: Accept and return EMACS_INT for sizes.
3304 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3306 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3307 Accept and return EMACS_INT.
3308 (emacs_gnutls_write): Return the number of bytes written on
3310 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3311 (emacs_read, emacs_write): Remove check for negative size, as the
3312 Emacs source code has been audited now.
3313 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3314 (emacs_read, emacs_write): Use it.
3315 * process.c (send_process): Adjust to the new signatures of
3316 emacs_write and emacs_gnutls_write. Do not attempt to store
3317 a byte offset into an 'int'; it might overflow.
3318 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3320 * sound.c: Don't assume sizes fit in 'int'.
3321 (struct sound_device.period_size, alsa_period_size):
3322 Return EMACS_INT, not int.
3323 (struct sound_device.write, vox_write, alsa_write):
3324 Accept EMACS_INT, not int.
3325 (wav_play, au_play): Use EMACS_INT to store sizes and to
3326 record read return values.
3328 2011-04-15 Ben Key <bkey76@gmail.com>
3330 * keyboard.c (Qundefined): Don't declare static since it is used
3332 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3333 static since they are used in nsfont.m.
3335 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3337 * process.c (Qprocessp): Don't declare static.
3338 * lisp.h (Qprocessp): Declare again.
3340 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3342 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3344 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3346 Improve C-level modularity by making more things 'static'.
3348 Don't publish debugger-only interfaces to other modules.
3349 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3350 (verify_bytepos, count_markers): Move decls to the only modules
3352 * region-cache.h (pp_cache): Likewise.
3353 * window.h (check_all_windows): Likewise.
3354 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3356 * sysdep.c (croak): Now static, if
3357 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3358 * syssignal.h (croak): Declare only if not static.
3360 * alloc.c (refill_memory_reserve): Now static if
3361 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3362 * lisp.h (refill_memory_reserve): Declare only if not static.
3364 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3365 Define only if USE_LUCID.
3367 * xrdb.c (x_customization_string, x_rm_string): Now static.
3369 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3370 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3372 * xdisp.c (draw_row_with_mouse_face): Now static.
3373 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3375 * window.h (check_all_windows): Mark externally visible.
3377 * window.c (window_deletion_count): Now static.
3379 * undo.c: Make symbols static if they're not exported.
3380 (last_undo_buffer, last_boundary_position, pending_boundary):
3383 * textprop.c (interval_insert_behind_hooks): Now static.
3384 (interval_insert_in_front_hooks): Likewise.
3386 * term.c: Make symbols static if they're not exported.
3387 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3388 (max_frame_lines, tty_set_terminal_modes):
3389 (tty_reset_terminal_modes, tty_turn_off_highlight):
3390 (get_tty_terminal): Now static.
3391 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3392 * termhooks.h (term_mouse_moveto): Do not declare if
3394 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3395 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3397 * sysdep.c: Make symbols static if they're not exported.
3398 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3400 (sigprocmask_set, full_mask): Remove; unused.
3401 (wait_debugging): Mark as visible.
3402 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3403 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3405 * syntax.c (syntax_temp): Define only if !__GNUC__.
3407 * sound.c (current_sound_device, current_sound): Now static.
3409 * search.c (searchbufs, searchbuf_head): Now static.
3411 * scroll.c (scroll_cost): Remove; unused.
3412 * dispextern.h (scroll_cost): Remove decl.
3414 * region-cache.h (pp_cache): Mark as externally visible.
3416 * process.c: Make symbols static if they're not exported.
3417 (process_tick, update_tick, create_process, chan_process):
3418 (Vprocess_alist, proc_buffered_char, datagram_access):
3419 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3420 (deactivate_process): Mark defn as static, as well as decl.
3421 * lisp.h (create_process): Remove decl.
3422 * process.h (chan_process, Vprocess_alist): Remove decls.
3424 * print.c: Make symbols static if they're not exported.
3425 (print_depth, new_backquote_output, being_printed, print_buffer):
3426 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3427 (print_interval, print_number_index, initial_stderr_stream):
3429 * lisp.h (Fprinc): Remove decl.
3430 (debug_output_compilation_hack): Mark as externally visible.
3432 * sysdep.c (croak): Move decl from here to syssignal.h.
3433 * syssignal.h (croak): Put it here, so the API can be checked when
3434 'croak' is called from dissociate_if_controlling_tty.
3436 * minibuf.c: Make symbols static if they're not exported.
3437 (minibuf_save_list, choose_minibuf_frame): Now static.
3438 * lisp.h (choose_minibuf_frame): Remove decl.
3440 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3442 * lread.c: Make symbols static if they're not exported.
3443 (read_objects, initial_obarray, oblookup_last_bucket_number):
3445 (make_symbol): Remove; unused.
3446 * lisp.h (initial_obarray, make_symbol): Remove decls.
3448 * keyboard.c: Make symbols static if they're not exported.
3449 (single_kboard, recent_keys_index, total_keys, recent_keys):
3450 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3451 (this_single_command_key_start, echoing, last_auto_save):
3452 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3453 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3454 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3455 (Vlispy_mouse_stem, double_click_count):
3457 (force_auto_save_soon): Define only if SIGDANGER.
3458 (ignore_mouse_drag_p): Now static if
3459 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3460 (print_help): Remove; unused.
3461 (stop_character, last_timer_event): Mark as externally visible.
3462 * keyboard.h (ignore_mouse_drag_p): Declare only if
3463 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3464 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3465 * lisp.h (echoing): Remove decl.
3466 (force_auto_save_soon): Declare only if SIGDANGER.
3467 * xdisp.c (redisplay_window): Simplify code, to make it more
3468 obvious that ignore_mouse_drag_p is not accessed if !defined
3469 USE_GTK && !defined HAVE_NS.
3471 * intervals.c: Make symbols static if they're not exported.
3472 (merge_properties_sticky, merge_interval_right, delete_interval):
3474 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3476 * insdel.c: Make symbols static if they're not exported.
3477 However, leave prepare_to_modify_buffer alone. It's never
3478 called from outside this function, but that appears to be a bug.
3479 (combine_after_change_list, combine_after_change_buffer):
3480 (adjust_after_replace, signal_before_change): Now static.
3481 (adjust_after_replace_noundo): Remove; unused.
3482 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3483 (signal_before_change): Remove decls.
3485 * indent.c (val_compute_motion, val_vmotion): Now static.
3487 * image.c: Make symbols static if they're not exported.
3488 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3490 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3491 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3493 * fringe.c (standard_bitmaps): Now static.
3494 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3496 * frame.c: Make symbols static if they're not exported.
3497 (x_report_frame_params, make_terminal_frame): Now static.
3498 (get_frame_param): Now static, unless HAVE_NS.
3499 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3500 (x_get_resource_string): Remove; not used.
3501 * frame.h (make_terminal_frame, x_report_frame_params):
3502 (x_get_resource_string); Remove decls.
3503 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3504 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3506 * font.c, fontset.c: Make symbols static if they're not exported.
3507 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3508 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3509 * font.c (font_close_object): Now static.
3510 * font.h (font_close_object): Remove.
3511 * fontset.c (FONTSET_OBJLIST): Remove.
3512 (free_realized_fontset) #if-0 the body, which does nothing.
3513 (face_suitable_for_char_p): #if-0, as it's never called.
3514 * fontset.h (face_suitable_for_char_p): Remove decl.
3515 * xfaces.c (face_at_string_position):
3516 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3517 since 0 is always ASCII.
3519 * fns.c (weak_hash_tables): Now static.
3521 * fileio.c: Make symbols static if they're not exported.
3522 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3523 (Vwrite_region_annotation_buffers): Now static.
3525 * eval.c: Make symbols static if they're not exported.
3526 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3527 * lisp.h (backtrace_list): Remove decl.
3529 * emacs.c: Make symbols static if they're not exported.
3530 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3531 (fatal_error_code, fatal_error_signal_hook, standard_args):
3533 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3534 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3535 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3536 * lisp.h (fatal_error_signal_hook): Remove decl.
3537 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3539 * editfns.c: Move a (normally-unused) function to its only use.
3540 * editfns.c, lisp.h (get_operating_system_release): Remove.
3541 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3542 worth the hassle of breaking this out.
3544 * xterm.c: Make symbols static if they're not exported.
3545 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3546 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3547 (x_destroy_window, x_delete_display):
3549 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3550 (x_mouse_leave): Remove; unused.
3551 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3552 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3553 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3555 (x_mouse_leave): Declare only if WINDOWSNT.
3556 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3557 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3560 * ftxfont.c: Make symbols static if they're not exported.
3561 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3563 * font.h (ftxfont_driver): Likewise.
3565 * xfns.c: Make symbols static if they're not exported.
3566 (x_last_font_name, x_display_info_for_name):
3567 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3568 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3569 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3570 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3571 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3572 (last_show_tip_args): Now static.
3573 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3574 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3575 (x_screen_planes): Remove; unused.
3576 * dispextern.h (x_screen_planes): Remove decl.
3578 * dispnew.c: Make symbols static if they're not exported.
3579 * dispextern.h (redraw_garbaged_frames, scrolling):
3580 (increment_row_positions): Remove.
3581 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3582 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3584 (redraw_garbaged_frames): Remove; unused.
3586 * xfaces.c: Make symbols static if they're not exported.
3587 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3589 * xterm.h (defined_color): Remove decls.
3590 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3591 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3592 (menu_face_changed_default, defined_color, free_realized_face):
3593 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3594 (ascii_face_of_lisp_face): Remove; unused.
3596 * xdisp.c: Make symbols static if they're not exported.
3597 * dispextern.h (scratch_glyph_row, window_box_edges):
3598 (glyph_to_pixel_coords, set_cursor_from_row):
3599 (get_next_display_element, set_iterator_to_next):
3600 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3601 (show_mouse_face): Remove decls
3602 * frame.h (message_buf_print): Likewise.
3603 * lisp.h (pop_message, set_message, check_point_in_composition):
3605 * xterm.h (set_vertical_scroll_bar): Likewise.
3606 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3607 (message_buf_print, scratch_glyph_row, displayed_buffer):
3608 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3609 (get_next_display_element, show_mouse_face, window_box_edges):
3610 (frame_to_window_pixel_xy, check_point_in_composition):
3611 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3612 (glyph_to_pixel_coords): Remove; unused.
3614 * dired.c (file_name_completion): Now static.
3616 * dbusbind.c (xd_in_read_queued_messages): Now static.
3618 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3619 * data.c (circular_list_error): Remove.
3621 * commands.h (last_point_position, last_point_position_buffer):
3622 (last_point_position_window): Remove decls.
3623 * keyboard.c: Make these variables static.
3625 * coding.h (coding, code_convert_region, encode_coding_gap):
3627 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3628 (iso_code_class, detect_coding, code_convert_region): Now static.
3629 (encode_coding_gap): Remove; unused.
3631 * chartab.c (chartab_chars, chartab_bits): Now static.
3633 * charset.h (charset_iso_8859_1): Remove decl.
3634 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3637 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3638 * ccl.c (Vccl_program_table): Now static.
3639 (check_ccl_update): Remove; unused.
3641 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3642 * category.h: ... from here.
3643 * category.c (check_category_table, set_category_set): Now static.
3645 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3646 * lisp.h: Remove these decls.
3648 * buffer.c (buffer_count): Remove unused var.
3650 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3651 so that it's not optimized away.
3652 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3653 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3654 exported only to the debugger.
3656 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3657 * atimer.h (run_all_atimers): Remove; not exported.
3659 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3660 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3661 was inaccessible from Lisp.
3662 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3663 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3665 alloc.c: Import and export fewer symbols, and remove unused items.
3666 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3668 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3669 it's not optimized away by whole-program optimization.
3670 (message_enable_multibyte, free_misc): Remove.
3671 (catchlist, handlerlist, mark_backtrace):
3672 Declare only if BYTE_MARK_STACK.
3673 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3674 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3675 (message_enable_multibyte): Remove decl.
3676 (free_misc, interval_free_list, float_block, float_block_index):
3677 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3678 (cons_free_list, last_marked_index):
3680 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3681 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3682 (mark_backtrace): Define only if BYTE_MARK_STACK.
3683 * xdisp.c (message_enable_multibyte): Now static.
3685 Declare Lisp_Object Q* variables to be 'static' if not exported.
3686 This makes it easier for human readers (and static analyzers)
3687 to see whether these variables are used from other modules.
3688 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3689 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3690 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3691 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3692 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3693 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3694 * xmenu.c, xselect.c:
3695 Declare Q* vars static if they are not used in other modules.
3696 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3697 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3698 Remove decls of unexported vars.
3699 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3701 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3703 Make Emacs functions such as Fatom 'static' by default.
3704 This makes it easier for human readers (and static analyzers)
3705 to see whether these functions can be called from other modules.
3706 DEFUN now defines a static function. To make the function external
3707 so that it can be used in other C modules, use the new macro DEFUE.
3708 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3709 (Finit_image_library):
3710 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3711 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3712 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3713 Remove decls, since these functions are now static.
3714 (Funintern, Fget_internal_run_time): New decls, since these functions
3715 were already external.
3717 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3718 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3719 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3720 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3721 * keyboard.c, keymap.c, lread.c:
3722 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3723 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3724 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3725 Mark functions with DEFUE instead of DEFUN,
3726 if they are used in other modules.
3727 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3728 decls for now-static functions.
3729 * buffer.h (Fdelete_overlay): Remove decl.
3730 * callproc.c (Fgetenv_internal): Mark as internal.
3731 * composite.c (Fremove_list_of_text_properties): Remove decl.
3732 (Fcomposition_get_gstring): New forward static decl.
3733 * composite.h (Fcomposite_get_gstring): Remove decl.
3734 * dired.c (Ffile_attributes): New forward static decl.
3735 * doc.c (Fdocumntation_property): New forward static decl.
3736 * eval.c (Ffetch_bytecode): New forward static decl.
3737 (Funintern): Remove extern decl; now in .h file where it belongs.
3738 * fileio.c (Fmake_symbolic_link): New forward static decl.
3739 * image.c (Finit_image_library): New forward static decl.
3740 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3741 * intervals.h (Fprevious_property_change):
3742 (Fremove_list_of_text_properties): Remove decls.
3743 * keyboard.c (Fthis_command_keys): Remove decl.
3744 (Fcommand_execute): New forward static decl.
3745 * keymap.c (Flookup_key): New forward static decl.
3746 (Fcopy_keymap): Now static.
3747 * keymap.h (Flookup_key): Remove decl.
3748 * process.c (Fget_process): New forward static decl.
3749 (Fprocess_datagram_address): Mark as internal.
3750 * syntax.c (Fsyntax_table_p): New forward static decl.
3751 (skip_chars): Remove duplicate decl.
3752 * textprop.c (Fprevious_property_change): New forward static decl.
3753 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3755 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3756 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3758 * editfns.c (Fformat): Remove unreachable code.
3760 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3762 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3765 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3767 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3768 when at ZV. (Bug#8487)
3770 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3772 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3774 * keyboard.c (parse_tool_bar_item): Likewise.
3775 * sound.c (sound_cleanup, alsa_close): Likewise.
3776 * termcap.c (tgetent): Likewise.
3777 * xfns.c (x_default_font_parameter): Likewise.
3778 * xsettings.c (read_and_apply_settings): Likewise.
3780 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3781 (overrun_check_free): Protoize.
3783 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3785 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3786 since callers should never pass a negative size.
3787 Change the signature to match that of plain 'read' and 'write'; see
3788 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3789 * lisp.h: Update prototypes of emacs_write and emacs_read.
3791 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3793 * xdisp.c (redisplay_window): Don't try to determine the character
3794 position of the scroll margin if the window start point w->startp
3795 is outside the buffer's accessible region. (Bug#8468)
3797 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3799 Fix write-region and its subroutines for buffers > 2GB.
3800 * fileio.c (a_write, e_write): Modify declaration of arguments and
3801 local variables to support buffers larger than 2GB.
3802 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3804 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3805 argument, local variables, and return value.
3807 * lisp.h: Update prototypes of emacs_write and emacs_read.
3809 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3811 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3813 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3815 Fix more problems found by GCC 4.6.0's static checks.
3817 * xdisp.c (vmessage): Use a better test for character truncation.
3819 * charset.c (load_charset_map): <, not <=, for optimization,
3820 and to avoid potential problems with integer overflow.
3821 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3822 * casetab.c (set_identity, shuffle): Likewise.
3823 * editfns.c (Fformat): Likewise.
3824 * syntax.c (skip_chars): Likewise.
3826 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3827 This also lets GCC 4.6.0 generate slightly better loop code.
3829 * callint.c (Fcall_interactively): <, not <=, for optimization.
3830 (Fcall_interactively): Count the number of arguments produced,
3831 not the number of arguments given. This is simpler and lets GCC
3832 4.6.0 generate slightly better code.
3834 * ftfont.c: Distingish more carefully between FcChar8 and char.
3835 The previous code passed unsigned char * to a functions like
3836 strlen and xstrcasecmp that expect char *, which does not
3837 conform to the C standard.
3838 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3839 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3840 char * when the C standard requires it.
3842 * keyboard.c (read_char): Remove unused var.
3844 * eval.c: Port to Windows vsnprintf (Bug#8435).
3846 (SIZE_MAX): Define if the headers do not.
3847 (verror): Do not give up if vsnprintf returns a negative count.
3848 Instead, grow the buffer. This ports to Windows vsnprintf, which
3849 does not conform to C99. Problem reported by Eli Zaretskii.
3850 Also, simplify the allocation scheme, by avoiding the need for
3851 calling realloc, and removing the ALLOCATED variable.
3853 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3855 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3856 But keep the doprint source code for now, as we might revamp it
3857 and use it again (Bug#8435).
3858 * lisp.h (doprnt): Remove.
3859 * Makefile.in (base_obj): Remove doprnt.o.
3860 * deps.mk (doprnt.o): Remove.
3862 error: Print 32- and 64-bit integers portably (Bug#8435).
3863 Without this change, on typical 64-bit hosts error ("...%d...", N)
3864 was used to print both 32- and 64-bit integers N, which relied on
3866 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3868 * lisp.h (error, verror): Mark as printf-like functions.
3869 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3870 Report overflow in size calculations when allocating printf buffer.
3871 Do not truncate output string at its first null byte.
3872 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3873 Truncate the output at a character boundary, since vsnprintf does not
3875 * charset.c (check_iso_charset_parameter): Convert internal
3876 character to string before calling 'error', since %c now has the
3878 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3879 overflow when computing char to be passed to 'error'. Do not
3880 pass Lisp_Object to 'error'; pass the integer instead.
3881 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3882 formatted with plain %d.
3884 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3886 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3888 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3890 * xterm.c (x_catch_errors): Remove duplicate declaration.
3892 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3894 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3896 2011-04-10 Jim Meyering <meyering@redhat.com>
3898 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3899 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3900 return ssize_t not "int", and use size_t as the buffer length.
3901 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3902 * gnutls.h: Update declarations.
3903 * process.c (read_process_output): Use ssize_t, to match.
3904 (send_process): Likewise.
3906 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3908 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3910 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3912 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3913 Use unsigned char, to match FcChar8 type definition.
3915 * xterm.c (handle_one_xevent):
3916 * xmenu.c (create_and_show_popup_menu):
3917 * xselect.c (x_decline_selection_request)
3918 (x_reply_selection_request): Avoid type-punned deref of X events.
3920 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3922 Fix some uses of `int' instead of EMACS_INT.
3923 * search.c (string_match_1, fast_string_match)
3924 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3925 (scan_buffer, find_next_newline_no_quit)
3926 (find_before_next_newline, search_command, Freplace_match)
3927 (Fmatch_data): Make some `int' variables be EMACS_INT.
3929 * xdisp.c (display_count_lines): 3rd argument and return value now
3930 EMACS_INT. All callers changed.
3931 (pint2hrstr): Last argument is now EMACS_INT.
3933 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3934 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3935 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3936 (decode_coding_utf_16, decode_coding_emacs_mule)
3937 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3938 (decode_coding_ccl, decode_coding_charset)
3939 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3940 (decode_coding_iso_2022, decode_coding_emacs_mule)
3941 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3942 <char_offset, last_offset>: Declare EMACS_INT.
3943 (encode_coding_utf_8, encode_coding_utf_16)
3944 (encode_coding_emacs_mule, encode_invocation_designation)
3945 (encode_designation_at_bol, encode_coding_iso_2022)
3946 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3947 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3949 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3950 (encode_invocation_designation): Last argument P_NCHARS is now
3952 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3953 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3955 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3958 * ccl.c (Fccl_execute_on_string): Declare some variables
3961 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3963 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3965 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3967 * process.c (Fformat_network_address): Doc fix.
3969 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3971 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3973 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3975 * keyboard.c (read_char): Call Lisp function help-form-show,
3976 instead of using internal_with_output_to_temp_buffer.
3977 (Qhelp_form_show): New var.
3978 (syms_of_keyboard): Use DEFSYM macro.
3980 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3982 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3984 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3986 * process.c (Flist_processes): Remove to Lisp.
3987 (list_processes_1): Delete.
3989 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3991 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3993 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3995 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3997 Fix more problems found by GCC 4.6.0's static checks.
3999 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4001 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4003 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4005 * xdisp.c (vmessage): Mark as a printf-like function.
4007 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4009 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4011 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4012 printf-like functions.
4013 (tiff_load): Add casts to remove these marks before passing them
4014 to system-supplied API.
4016 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4018 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4019 This avoids several warnings with gcc -Wstrict-overflow.
4020 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4021 directly, rather than having caller test rule sign. This avoids
4022 some unnecessary tests.
4023 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4024 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4025 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4027 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4028 (xfont_open): Avoid unnecessary tests.
4030 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4032 * composite.h, composite.c (composition_gstring_put_cache):
4033 Use EMACS_INT, not int, for length.
4035 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4036 breaking out part of COMPOSITION_DECODE_RULE.
4037 (COMPOSITION_DECODE_RULE): Use it.
4038 * composite.c (get_composition_id): Remove unused local vars,
4039 by using the new macro.
4041 * textprop.c (set_text_properties_1): Change while to do-while,
4042 since the condition is always true at first.
4044 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4045 (interval_deletion_adjustment): Return unsigned value.
4048 * process.c (list_processes_1, create_pty, read_process_output):
4049 (exec_sentinel): Remove vars that were set but not used.
4050 (create_pty): Remove unnecessary "volatile"s.
4051 (Fnetwork_interface_info): Avoid possibility of int overflow.
4052 (read_process_output): Do adaptive read buffering even if carryover.
4053 (read_process_output): Simplify nbytes computation if buffered.
4055 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4057 * syntax.c (scan_words): Remove var that was set but not used.
4058 (update_syntax_table): Use unsigned instead of int.
4060 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4061 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4062 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4064 * print.c (print_error_message): Avoid int overflow.
4066 * font.c (font_list_entities): Redo for clarity,
4067 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4069 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4070 (font_score): Avoid potential overflow in diff calculation.
4072 * fns.c (substring_both): Remove var that is set but not used.
4073 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4075 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4077 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4078 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4079 can always succeed if overflow has undefined behavior.
4081 * search.c (boyer_moore, wordify): Remove vars set but not used.
4082 (wordify): Omit three unnecessary tests.
4084 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4085 All callers changed. This avoids the need for an unused var.
4087 * casefiddle.c (casify_region): Remove var that is set but not used.
4089 * dired.c (file_name_completion): Remove var that is set but not used.
4091 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4093 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4094 (Finsert_file_contents): Remove unnecessary code checking fd.
4096 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4097 Check for integer overflow on size calculations.
4099 * buffer.c (Fprevious_overlay_change): Remove var that is set
4102 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4103 Remove vars that are set but not used.
4104 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4105 (timer_check_2): Mark vars as initialized.
4107 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4109 * image.c (lookup_image): Remove var that is set but not used.
4110 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4112 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4113 that are set but not used.
4115 * xfns.c (make_invisible_cursor): Don't return garbage
4116 if XCreateBitmapFromData fails (Bug#8410).
4118 * xselect.c (x_get_local_selection, x_handle_property_notify):
4119 Remove vars that are set but not used.
4121 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4122 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4124 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4125 Remove var that is set but not used.
4126 (scroll_bar_windows_size): Now size_t, not int.
4127 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4130 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4131 (map_tty_color) [!defined MSDOS]: Likewise.
4133 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4135 * coding.c: Remove vars that are set but not used.
4136 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4137 All callers changed.
4138 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4139 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4140 (decode_coding_charset): Remove vars that are set but not used.
4142 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4143 that is set but not used.
4145 * print.c (print_object): Remove var that is set but not used.
4147 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4148 The gnulib version avoids calling malloc in the usual case,
4149 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4150 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4151 * filelock.c (current_lock_owner): Likewise.
4152 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4153 * sysdep.c: Include allocator.h, careadlinkat.h.
4154 (emacs_no_realloc_allocator): New static constant.
4155 (emacs_readlink): New function.
4156 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4157 ../lib/careadlinkat.h.
4159 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4161 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4162 first non-nil return value).
4164 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4166 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4167 if not defined (Bug#8403).
4169 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4171 * xdisp.c (display_count_lines): Remove parameter `start',
4172 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4173 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4174 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4175 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4176 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4177 and thereabouts. All callers changed.
4178 (get_per_char_metric): Remove parameter `f', unused since
4179 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4181 2011-04-02 Jim Meyering <meyering@redhat.com>
4183 do not dereference NULL upon failed strdup
4184 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4185 (ns_get_family): Likewise.
4187 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4189 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4191 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4193 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4196 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4198 Add lexical binding.
4200 * window.c (Ftemp_output_buffer_show): New fun.
4201 (Fsave_window_excursion):
4202 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4204 * lread.c (lisp_file_lexically_bound_p): New function.
4205 (Fload): Bind Qlexical_binding.
4206 (readevalloop): Remove `evalfun' arg.
4207 Bind Qinternal_interpreter_environment.
4208 (Feval_buffer): Bind Qlexical_binding.
4209 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4211 (syms_of_lread): Declare `lexical-binding'.
4213 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4215 * keyboard.c (eval_dyn): New fun.
4216 (menu_item_eval_property): Use it.
4218 * image.c (parse_image_spec): Use Ffunctionp.
4220 * fns.c (concat, mapcar1): Accept byte-code-functions.
4222 * eval.c (Fsetq): Handle lexical vars.
4223 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4224 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4225 (FletX, Flet): Obey lexical binding.
4226 (Fcommandp): Handle closures.
4227 (Feval): New `lexical' arg.
4228 (eval_sub): New function extracted from Feval. Use it almost
4229 everywhere where Feval was used. Look up vars in lexical env.
4231 (Ffunctionp): Move from subr.el.
4232 (Ffuncall): Handle closures.
4233 (apply_lambda): Remove `eval_flags'.
4234 (funcall_lambda): Handle closures and new byte-code-functions.
4235 (Fspecial_variable_p): New function.
4236 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4237 but without exporting it to Lisp.
4239 * doc.c (Fdocumentation, store_function_docstring):
4240 * data.c (Finteractive_form): Handle closures.
4242 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4245 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4247 (exec_byte_code): New function extracted from Fbyte_code to handle new
4248 calling convention for byte-code-functions. Add new byte-codes.
4250 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4252 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4254 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4256 * xdisp.c (redisplay_internal): Fix prototype.
4258 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4260 * xdisp.c (SCROLL_LIMIT): New macro.
4261 (try_scrolling): Use it when setting scroll_limit.
4262 Limit scrolling to 100 screen lines.
4263 (redisplay_window): Even when falling back on "recentering",
4264 position point in the window according to scroll-conservatively,
4265 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4267 (try_scrolling): When point is above the window, allow searching
4268 as far as scroll_max, or one screenful, to compute vertical
4269 distance from PT to the scroll margin position. This prevents
4270 try_scrolling from unnecessarily failing when
4271 scroll-conservatively is set to a value slightly larger than the
4272 window height. Clean up the case of PT below the margin at bottom
4273 of window: scroll_max can no longer be INT_MAX. When aggressive
4274 scrolling is in use, don't let point enter the opposite scroll
4275 margin as result of the scroll.
4276 (syms_of_xdisp) <scroll-conservatively>: Document the
4277 threshold of 100 lines for never-recentering scrolling.
4279 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4281 * dispextern.h (move_it_by_lines):
4282 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4283 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4284 (message_log_check_duplicate): Remove parameters `prev_bol' and
4285 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4286 (redisplay_internal): Remove parameter `preserve_echo_area',
4287 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4289 * indent.c (Fvertical_motion):
4290 * window.c (window_scroll_pixel_based, Frecenter):
4291 Don't pass `need_y_p' to `move_it_by_lines'.
4293 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4295 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4296 steal a few bits to be more compact.
4297 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4298 Remove unneeded casts.
4300 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4302 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4304 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4305 binding" message (bug#7967).
4307 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4309 Fix more problems found by GCC 4.6.0's static checks.
4311 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4312 Remove unused local var.
4314 * editfns.c (Fmessage_box): Remove unused local var.
4316 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4317 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4318 Omit unused local vars.
4319 * window.c (shrink_windows): Omit unused local var.
4320 * menu.c (digest_single_submenu): Omit unused local var.
4321 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4322 Omit unused local var.
4324 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4325 Don't assume string length fits in int.
4326 (keyremap_step, read_key_sequence): Use size_t for sizes.
4327 (read_key_sequence): Don't check last_real_key_start redundantly.
4329 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4330 instead of alloca (Bug#8344).
4332 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4333 (Fbacktrace_frame): Don't assume nframes fits in int.
4335 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4337 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4340 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4342 * cm.c (calccost): Turn while-do into do-while, for clarity.
4344 * keyboard.c (syms_of_keyboard): Use the same style as later
4345 in this function when indexing through an array. This also
4346 works around GCC bug 48267.
4348 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4350 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4352 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4353 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4355 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4356 This avoids undefined behavior on integer overflow, and is a bit
4357 more convenient anyway since it is compared to a size_t variable.
4359 Variadic C functions now count arguments with size_t, not int.
4360 This avoids an unnecessary limitation on 64-bit machines, which
4361 caused (substring ...) to crash on large vectors (Bug#8344).
4362 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4363 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4364 All variadic functions and their callers changed accordingly.
4365 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4366 * data.c (arith_driver, float_arith_driver): Likewise.
4367 * editfns.c (general_insert_function): Likewise.
4368 * eval.c (struct backtrace.nargs, interactive_p)
4369 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4370 (funcall_lambda, mark_backtrace): Likewise.
4371 * fns.c (concat): Likewise.
4372 * frame.c (x_set_frame_parameters): Likewise.
4373 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4374 0 if not found, not -1. All callers changed.
4376 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4377 (stack_copy_size): Now size_t, not int.
4378 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4380 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4382 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4383 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4384 All callers changed.
4386 * lisp.h (multibyte_char_to_unibyte):
4387 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4388 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4389 * character.h (CHAR_TO_BYTE8):
4390 * cmds.c (internal_self_insert):
4391 * editfns.c (general_insert_function):
4392 * keymap.c (push_key_description):
4393 * search.c (Freplace_match):
4394 * xdisp.c (message_dolog, set_message_1): All callers changed.
4396 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4398 * keyboard.c (safe_run_hook_funcall): New function.
4399 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4400 don't set the hook to nil, but remove the offending function instead.
4401 (Qcommand_hook_internal): Remove, unused.
4402 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4403 Vcommand_hook_internal.
4405 * eval.c (enum run_hooks_condition): Remove.
4406 (funcall_nil, funcall_not): New functions.
4407 (run_hook_with_args): Call each function through a `funcall' argument.
4408 Remove `cond' argument, now redundant.
4409 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4410 (Frun_hook_with_args_until_failure): Adjust accordingly.
4411 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4413 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4415 * dispextern.h (string_buffer_position): Remove declaration.
4417 * print.c (strout): Remove parameter `multibyte', unused since
4418 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4420 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4421 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4422 All callers changed.
4424 * w32.c (_wsa_errlist): Use braces for struct initializers.
4426 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4427 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4428 All callers changed.
4429 (string_buffer_position): Likewise. Also, make static (it's never
4430 used outside xdisp.c).
4431 (cursor_row_p): Remove parameter `w', unused since
4432 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4433 (decode_mode_spec): Remove parameter `precision', introduced during
4434 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4435 All callers changed.
4437 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4439 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4441 2011-03-27 Anders Lindgren <andlind@gmail.com>
4443 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4444 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4445 (ns_update_auto_hide_menu_bar): New functions.
4446 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4447 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4448 ns_constrain_all_frames.
4449 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4450 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4452 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4454 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4456 2011-03-27 Glenn Morris <rgm@gnu.org>
4458 * syssignal.h: Replace RETSIGTYPE with void.
4459 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4460 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4461 Replace SIGTYPE with void everywhere.
4462 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4463 * s/template.h (SIGTYPE): Remove commented out definition.
4465 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4467 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4468 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4470 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4472 * w32.c (read_unc_volume): Use parameter `henum', instead of
4473 global variable `wget_enum_handle'.
4475 * keymap.c (describe_vector): Remove parameters `indices' and
4476 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4477 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4479 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4481 * keyboard.c (timer_check): Remove parameter `do_it_now',
4482 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4483 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4484 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4486 * keyboard.c (read_char):
4487 * w32menu.c (w32_menu_display_help):
4488 * xmenu.c (show_help_event, menu_help_callback):
4489 Adjust calls to `show_help_echo'.
4491 * gtkutil.c (xg_maybe_add_timer):
4492 * keyboard.c (readable_events):
4493 * process.c (wait_reading_process_output):
4494 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4496 * insdel.c (adjust_markers_gap_motion):
4497 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4498 (gap_left, gap_right): Don't call it.
4500 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4502 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4503 incurred during fontification.
4505 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4507 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4508 (DEFVAR_PER_BUFFER): Don't pass it.
4510 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4511 (scrolling_window): Don't pass it.
4513 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4515 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4517 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4519 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4520 of variables specific to SELinux and computation of `encoded_absname'.
4522 * image.c (XPutPixel): Remove unused variable `height'.
4524 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4526 * unexw32.c (get_section_info): Remove unused variable `section'.
4528 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4529 (system_process_attributes): Remove unused variable `sess'.
4530 (sys_read): Remove unused variable `err'.
4532 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4533 (w32_wnd_proc): Remove unused variable `isdead'.
4534 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4535 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4536 (x_create_tip_frame): Remove unused variable `tem'.
4538 * w32inevt.c (w32_console_read_socket):
4539 Remove unused variable `no_events'.
4541 * w32term.c (x_draw_composite_glyph_string_foreground):
4542 Remove unused variable `width'.
4544 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4546 * w32term.c (x_set_glyph_string_clipping):
4547 Don't pass uninitialized region to CombineRgn.
4549 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4551 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4552 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4553 (Fx_close_connection): Remove unused variable `i'.
4555 * w32font.c (w32font_draw): Return number of glyphs.
4556 (w32font_open_internal): Remove unused variable `i'.
4557 (w32font_driver): Add missing initializer.
4559 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4560 (fill_in_menu): Remove unused variable `items_added'.
4562 * w32term.c (last_mouse_press_frame): Remove static global variable.
4563 (w32_clip_to_row): Remove unused variable `f'.
4564 (x_delete_terminal): Remove unused variable `i'.
4566 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4567 (NOTHING): Remove unused static global variable.
4568 (uniscribe_check_otf): Remove unused variable `table'.
4569 (uniscribe_font_driver): Add missing initializers.
4571 2011-03-23 Julien Danjou <julien@danjou.info>
4573 * term.c (Fsuspend_tty, Fresume_tty):
4574 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4575 * window.c (temp_output_buffer_show):
4576 * insdel.c (signal_before_change):
4577 * frame.c (Fhandle_switch_frame):
4578 * fileio.c (Fdo_auto_save):
4579 * emacs.c (Fkill_emacs):
4580 * editfns.c (save_excursion_restore):
4581 * cmds.c (internal_self_insert):
4582 * callint.c (Fcall_interactively):
4583 * buffer.c (Fkill_all_local_variables):
4584 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4586 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4587 unconditionnaly since it does the check itself.
4589 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4591 Fix more problems found by GCC 4.5.2's static checks.
4593 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4594 the first time through the loop, since we know p0 < p1 then.
4595 This also avoids a gcc -Wstrict-overflow warning.
4597 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4598 leading to a memory leak, possible in functions like
4599 load_charset_map_from_file that can allocate an unbounded number
4600 of objects (Bug#8318).
4602 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4603 that could (at least in theory) be that large.
4605 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4606 This is less likely to overflow, and avoids undefined behavior if
4607 overflow does occur. All callers changed. Use strtoul to scan
4608 for the unsigned long integer.
4609 (pint2hrstr): Simplify and tune code slightly.
4610 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4612 * scroll.c (do_scrolling): Work around GCC bug 48228.
4613 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4615 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4616 This also avoids a warning with gcc -Wstrict-overflow.
4617 (validate_x_resource_name): Simplify count usage.
4618 This also avoids a warning with gcc -Wstrict-overflow.
4620 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4623 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4625 * process.c (Fmake_network_process): Use socklen_t, not int,
4626 where POSIX says socklen_t is required in portable programs.
4627 This fixes a porting bug on hosts like 64-bit HP-UX, where
4628 socklen_t is wider than int (Bug#8277).
4629 (Fmake_network_process, server_accept_connection):
4630 (wait_reading_process_output, read_process_output):
4633 * process.c: Rename or move locals to avoid shadowing.
4634 (list_processes_1, Fmake_network_process):
4635 (read_process_output_error_handler, exec_sentinel_error_handler):
4636 Rename or move locals.
4637 (Fmake_network_process): Define label "retry_connect" only if needed.
4638 (Fnetwork_interface_info): Fix pointer signedness.
4639 (process_send_signal): Add cast to avoid pointer signedness problem.
4640 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4641 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4643 Make tparam.h and terminfo.c consistent.
4644 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4645 Include tparam.h instead, since it declares them.
4646 * cm.h (PC): Remove extern decl; tparam.h now does this.
4647 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4648 * terminfo.c: Include tparam.h, to check interfaces.
4649 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4650 (tparam): Adjust signature to match interface in tparam.h;
4651 this removes some undefined behavior. Check that outstring and len
4652 are zero, which they always are with Emacs.
4653 * tparam.h (PC, BC, UP): New extern decls.
4655 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4656 (xftfont_open): Rename locals to avoid shadowing.
4658 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4659 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4660 (OTF_TAG_SYM): Omit macro if not needed.
4661 (ftfont_list): Remove unused local.
4662 (get_adstyle_property, ftfont_pattern_entity):
4663 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4664 Rename locals to avoid shadowing.
4666 * xfont.c (xfont_list_family): Mark var as initialized.
4668 * xml.c (make_dom): Now static.
4670 * composite.c (composition_compute_stop_pos): Rename local to
4672 (composition_reseat_it): Remove unused locals.
4673 (find_automatic_composition, composition_adjust_point): Likewise.
4674 (composition_update_it): Mark var as initialized.
4675 (find_automatic_composition): Mark vars as initialized,
4676 with a FIXME (Bug#8290).
4678 character.h: Rename locals to avoid shadowing.
4679 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4680 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4681 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4682 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4685 * textprop.c (property_change_between_p): Remove; unused.
4687 * intervals.c (interval_start_pos): Now static.
4689 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4691 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4692 Rename locals to avoid shadowing.
4694 * sound.c (wav_play, au_play, Fplay_sound_internal):
4695 Fix pointer signedness.
4696 (alsa_choose_format): Remove unused local var.
4697 (wav_play): Initialize a variable to 0, to prevent undefined
4698 behavior (Bug#8278).
4700 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4702 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4704 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4705 clobbering (Bug#8298).
4706 * sysdep.c (sys_subshell): Likewise.
4707 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4709 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4710 This should get cleaned up, so that child_setup has the
4711 same signature on all platforms.
4713 * callproc.c (call_process_cleanup): Now static.
4714 (relocate_fd): Rename locals to avoid shadowing.
4716 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4718 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4719 not to be necessary, and produces flickering.
4721 2011-03-20 Glenn Morris <rgm@gnu.org>
4723 * config.in: Remove file.
4725 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4727 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4728 are now in src/globals.h.
4729 (syms_of_minibuf): Remove spurious & from previous change.
4731 2011-03-20 Leo <sdl.web@gmail.com>
4733 * minibuf.c (completing-read-function): New variable.
4734 (completing-read-default): Rename from completing-read.
4735 (completing-read): Call completing-read-function.
4737 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4739 * xfaces.c (Fx_load_color_file):
4740 Read color file from absolute filename (bug#8250).
4742 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4744 * makefile.w32-in: Update dependencies.
4746 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4748 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4750 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4752 Fix more problems found by GCC 4.5.2's static checks.
4754 * process.c (make_serial_process_unwind, send_process_trap):
4755 (sigchld_handler): Now static.
4757 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4758 That way, the code declares only the vars that it needs.
4759 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4760 * s/cygwin.h (PTY_ITERATION): Likewise.
4761 * s/darwin.h (PTY_ITERATION): Likewise.
4762 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4764 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4765 * process.c (allocate_pty): Don't declare stb unless it's needed.
4767 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4768 (CONSTANTLIM): Remove; unused.
4769 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4770 Define only if needed.
4772 * unexelf.c (unexec): Name an expression,
4773 to avoid gcc -Wbad-function-cast warning.
4774 Use a different way to cause a compilation error if anyone uses
4775 n rather than nn, a way that does not involve shadowing.
4776 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4778 * deps.mk (unexalpha.o): Remove; unused.
4780 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4781 * unexec.h: New file.
4782 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4783 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4785 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4786 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4787 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4788 Change as necessary to match prototype in unexec.h.
4790 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4792 (back_comment, skip_chars): Mark vars as initialized.
4794 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4795 Rename locals to avoid shadowing.
4797 * lread.c (read1): Rewrite so as not to use empty "else".
4798 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4800 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4802 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4803 warning when compiling print.c.
4805 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4806 instead of using an uninitialized var.
4807 (font_sort_entities): Mark var as initialized.
4809 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4811 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4812 pointers to constants.
4813 (font_parse_fcname): Remove unused vars.
4814 (font_delete_unmatched): Now static.
4815 (font_get_spec): Remove; unused.
4816 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4817 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4818 Rename or move locals to avoid shadowing.
4820 * fns.c (require_nesting_list, require_unwind): Now static.
4821 (Ffillarray): Rename locals to avoid shadowing.
4823 * floatfns.c (domain_error2): Define only if needed.
4824 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4826 * alloc.c (mark_backtrace): Move decl from here ...
4827 * lisp.h: ... to here, so that it can be checked.
4829 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4830 (Fdefvar): Rewrite so as not to use empty "else".
4831 (lisp_indirect_variable): Name an expression,
4832 to avoid gcc -Wbad-function-cast warning.
4833 (Fdefvar): Rename locals to avoid shadowing.
4835 * callint.c (quotify_arg, quotify_args): Now static.
4836 (Fcall_interactively): Rename locals to avoid shadowing.
4837 Use const pointer when appropriate.
4839 * lisp.h (get_system_name, get_operating_system_release):
4840 Move decls here, to check interfaces.
4841 * process.c (get_operating_system_release): Move decl to lisp.h.
4842 * xrdb.c (get_system_name): Likewise.
4843 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4844 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4845 some of which prompt warnings from gcc -Wbad-function-cast.
4846 (Fformat_time_string, Fencode_time, Finsert_char):
4847 (Ftranslate_region_internal, Fformat):
4848 Rename or remove local vars to avoid shadowing.
4849 (Ftranslate_region_internal): Mark var as initialized.
4851 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4854 * lisp.h (eassert): Check that the argument compiles, even if
4855 ENABLE_CHECKING is not defined.
4857 * data.c (Findirect_variable): Name an expression, to avoid
4858 gcc -Wbad-function-cast warning.
4859 (default_value, arithcompare, arith_driver, arith_error): Now static.
4860 (store_symval_forwarding): Rename local to avoid shadowing.
4861 (Fmake_variable_buffer_local, Fmake_local_variable):
4862 Mark variables as initialized.
4863 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4865 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4866 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4867 Rename locals to avoid shadowing.
4868 (mark_stack): Move local variables into the #ifdef region where
4870 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4871 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4873 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4874 (GC_STRING_CHARS): Remove; not used.
4875 (Fmemory_limit): Cast sbrk's returned value to char *.
4877 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4878 avoids undefined behavior in theory.
4880 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4882 Use functions, not macros, for up- and down-casing (Bug#8254).
4883 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4884 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4885 to use the following functions instead of these macros.
4886 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4887 EMACS_INT, since callers assume the returned value fits in int.
4888 (upcase1): Likewise, for UPCASE_TABLE.
4889 (uppercasep, lowercasep, upcase): New static inline functions.
4890 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4891 the race-condition problem in the old DOWNCASE.
4893 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4894 Rename locals to avoid shadowing.
4895 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4896 (regex_compile, re_search_2, re_match_2_internal):
4897 Remove unused local vars.
4898 (FREE_VAR): Rewrite so as not to use empty "else",
4899 which gcc can warn about.
4900 (regex_compile, re_match_2_internal): Mark locals as initialized.
4901 (RETALLOC_IF): Define only if needed.
4902 (WORDCHAR_P): Likewise. This one is never needed, but is used
4903 only in a comment talking about a compiler bug, so put inside
4904 the #if 0 of that comment.
4905 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4906 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4909 * search.c (boyer_moore): Rename locals to avoid shadowing.
4910 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4911 (PREV_CHAR_BOUNDARY): Likewise.
4913 * search.c (simple_search): Remove unused var.
4915 * dired.c (compile_pattern): Move decl from here ...
4916 * lisp.h: ... to here, so that it can be checked.
4917 (struct re_registers): New forward decl.
4919 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4921 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4923 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4924 Rename locals to avoid shadowing.
4925 (Fvertical_motion): Mark locals as initialized.
4927 * casefiddle.c (casify_object, casify_region): Now static.
4928 (casify_region): Mark local as initialized.
4930 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4932 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4933 New macros, so that the caller can use some names other than
4934 gcpro1, gcpro2, etc.
4935 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4937 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4938 argument, for consistency with GCPRO2_VAR, etc: it is now the
4939 prefix of the variable, not the variable itself. All uses
4941 * dired.c (directory_files_internal, file_name_completion):
4942 Rename locals to avoid shadowing.
4944 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4945 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4946 dired.c's scmp function, had undefined behavior.
4947 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4948 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4949 * buffer.h: ... to here, because these macros use current_buffer,
4950 and the new implementation with inline functions needs to have
4951 current_buffer in scope now, rather than later when the macros
4953 (downcase, upcase1): New static inline functions.
4954 (DOWNCASE, UPCASE1): Reimplement using these functions.
4955 This avoids undefined behavior in expressions like
4956 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4957 from race conditions in accessing the global variables
4958 case_temp1 and case_temp2.
4959 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4960 * lisp.h (case_temp1, case_temp2): Remove their decls.
4961 * character.h (ASCII_CHAR_P): Move from here ...
4962 * lisp.h: ... to here, so that the inline functions mentioned
4965 * dired.c (directory_files_internal_unwind): Now static.
4967 * fileio.c (file_name_as_directory, directory_file_name):
4968 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4970 (file_name_as_directory): Use const pointers when appropriate.
4971 (Fexpand_file_name): Likewise. In particular, newdir might
4972 point at constant storage, so make it a const pointer.
4973 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4974 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4976 (Fset_file_times, Finsert_file_contents, auto_save_error):
4977 Rename locals to avoid shadowing.
4979 * minibuf.c (choose_minibuf_frame_1): Now static.
4980 (Ftry_completion, Fall_completions): Rename or remove locals
4983 * marker.c (bytepos_to_charpos): Remove; unused.
4985 * lisp.h (verify_bytepos, count_markers): New decls,
4986 so that gcc does not warn that these functions aren't declared.
4988 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4989 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4990 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4991 (copy_text): Remove unused local var.
4993 * filelock.c (within_one_second): Now static.
4994 (lock_file_1): Rename local to avoid shadowing.
4996 * buffer.c (fix_overlays_before): Mark locals as initialized.
4997 (fix_start_end_in_overlays): Likewise. This function should be
4998 simplified by using pointers-to-pointers, but that's a different
5000 (switch_to_buffer_1): Now static.
5001 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5002 (report_overlay_modification): Rename locals to avoid shadowing.
5004 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5005 Fix pointer signedness issue.
5006 (sys_subshell): Mark local as volatile if checking for lint,
5007 to suppress a gcc -Wclobbered warning that does not seem to be right.
5008 (MAXPATHLEN): Define only if needed.
5010 * process.c (serial_open, serial_configure): Move decls from here ...
5011 * systty.h: ... to here, so that they can be checked.
5013 * fns.c (get_random, seed_random): Move extern decls from here ...
5014 * lisp.h: ... to here, so that they can be checked.
5016 * sysdep.c (reset_io): Now static.
5017 (wait_for_termination_signal): Remove; unused.
5019 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5020 (copy_keymap_item, append_key, push_text_char_description):
5022 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5023 (DENSE_TABLE_SIZE): Remove; unused.
5024 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5025 (describe_map_tree):
5026 Rename locals to avoid shadowing.
5028 * keyboard.c: Declare functions static if they are not used elsewhere.
5029 (echo_char, echo_dash, cmd_error, top_level_2):
5030 (poll_for_input, handle_async_input): Now static.
5031 (read_char, kbd_buffer_get_event, make_lispy_position):
5032 (make_lispy_event, make_lispy_movement, apply_modifiers):
5033 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5034 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5035 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5036 (read_key_sequence, read_char): Mark locals as initialized.
5037 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5039 * keyboard.h (make_ctrl_char): New decl.
5040 (mark_kboards): Move decl here ...
5041 * alloc.c (mark_kboards): ... from here.
5043 * lisp.h (force_auto_save_soon): New decl.
5045 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5046 (DEFINE_DUMMY_FUNCTION): New macro.
5047 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5049 (main): Add casts to avoid warnings
5050 if GCC considers string literals to be constants.
5052 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5054 * dbusbind.c: Pointer signedness fixes.
5055 (xd_signature, xd_append_arg, xd_initialize):
5056 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5057 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5058 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5059 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5061 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5062 if GCC considers string literals to be constants.
5063 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5065 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5067 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5068 (print_preprocess, print_object): New macro to fix last change.
5070 * print.c (print_preprocess): Don't forget font objects.
5072 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5074 * emacs.c (USAGE3): Doc fixes.
5076 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5078 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5081 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5083 * lisp.h (VWindow_system, Qfile_name_history):
5084 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5085 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5086 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5088 * w32select.c: Don't #include "keyboard.h".
5089 (run_protected): Add extern declaration for waiting_for_input.
5091 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5092 * w32console.c (detect_input_pending, read_input_pending)
5093 (encode_terminal_code):
5094 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5095 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5096 (w32_system_caret_y, Qfile_name_history):
5097 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5098 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5099 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5100 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5101 * w32proc.c (Qlocal, report_file_error):
5102 * w32term.c (Vwindow_system, updating_frame):
5103 * w32uniscribe.c (initialized, uniscribe_font_driver):
5104 Remove unneeded extern declarations.
5106 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5108 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5110 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5112 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5113 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5114 These macros can no longer be used for assignment.
5116 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5117 Assign struct members directly, instead of using BUF_BEGV etc.
5118 (record_buffer_markers, fetch_buffer_markers): New functions for
5119 recording and fetching special buffer markers.
5120 (set_buffer_internal_1, set_buffer_temp): Use them.
5122 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5124 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5126 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5127 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5129 * xdisp.c (hscroll_window_tree):
5130 (reconsider_clip_changes): Use PT instead of BUF_PT.
5132 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5134 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5135 $(EMACS_ROOT)/lib/intprops.h.
5137 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5139 Fix more problems found by GCC 4.5.2's static checks.
5141 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5142 to unsigned char * to avoid compiler diagnostic.
5143 (xg_free_frame_widgets): Make it clear that a local variable is
5144 needed only if USE_GTK_TOOLTIP.
5145 (gdk_window_get_screen): Make it clear that this macro is needed
5146 only if USE_GTK_TOOLTIP.
5147 (int_gtk_range_get_value): New function, which avoids a diagnostic
5148 from gcc -Wbad-function-cast.
5149 (xg_set_toolkit_scroll_bar_thumb): Use it.
5150 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5151 diagnostic from gcc -Wbad-function-cast.
5152 (get_utf8_string, xg_get_file_with_chooser):
5153 Rename locals to avoid shadowing.
5154 (create_dialog): Move locals to avoid shadowing.
5156 * xgselect.c (xg_select): Remove unused var.
5158 * image.c (four_corners_best): Mark locals as initialized.
5159 (gif_load): Initialize transparent_p to zero (Bug#8238).
5160 Mark another local as initialized.
5161 (my_png_error, my_error_exit): Mark with NO_RETURN.
5163 * image.c (clear_image_cache): Now static.
5164 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5165 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5166 (x_edge_detection): Remove unnecessary cast that
5167 gcc -Wbad-function-cast diagnoses.
5168 (gif_load): Fix pointer signedness.
5169 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5170 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5172 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5174 Improve quality of tests for time stamp overflow.
5175 For example, without this patch (encode-time 0 0 0 1 1
5176 1152921504606846976) returns the obviously-bogus value (-948597
5177 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5178 reports time overflow. See
5179 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5180 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5181 * editfns.c: Include limits.h and intprops.h.
5182 (TIME_T_MIN, TIME_T_MAX): New macros.
5183 (time_overflow): Move earlier, to before first use.
5184 (hi_time, lo_time): New functions, for an accurate test for
5186 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5187 (Fget_internal_run_time): Don't assume time_t fits in int.
5188 (make_time): Use list2 instead of Fcons twice.
5189 (Fdecode_time): More accurate test for out-of-range times.
5190 (check_tm_member): New function.
5191 (Fencode_time): Use it, to test for out-of-range times.
5192 (lisp_time_argument): Don't rely on undefined left-shift and
5193 right-shift behavior when checking for time stamp overflow.
5195 * editfns.c (time_overflow): New function, refactoring common code.
5196 (Fformat_time_string, Fdecode_time, Fencode_time):
5197 (Fcurrent_time_string): Use it.
5199 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5200 * dired.c (make_time): Move to ...
5201 * editfns.c (make_time): ... here.
5202 * systime.h: Note the move.
5204 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5206 * fringe.c (update_window_fringes): Remove unused variables.
5208 * unexmacosx.c (copy_data_segment): Also copy __got section.
5211 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5213 * termcap.c [MSDOS]: Include "msdos.h".
5214 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5215 Constify `char *' arguments and their references according to
5216 prototypes in tparam.h.
5218 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5220 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5221 Adapt all references accordingly.
5223 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5225 2011-03-11 Tom Tromey <tromey@redhat.com>
5227 * buffer.c (syms_of_buffer): Remove obsolete comment.
5229 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5231 * termhooks.h (encode_terminal_code): Declare prototype.
5233 * msdos.c (encode_terminal_code): Don't declare prototype.
5235 * term.c (encode_terminal_code): Now external again, used by
5236 w32console.c and msdos.c.
5238 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5239 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5241 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5243 Fix some minor problems found by GCC 4.5.2's static checks.
5245 * fringe.c (update_window_fringes): Mark locals as initialized
5247 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5249 * alloc.c (mark_fringe_data): Move decl from here ...
5250 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5251 to check its interface.
5252 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5254 * fontset.c (free_realized_fontset): Now static.
5255 (Fset_fontset_font): Rename local to avoid shadowing.
5256 (fontset_font): Mark local as initialized.
5257 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5259 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5261 * xselect.c (x_disown_buffer_selections): Remove; not used.
5262 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5263 (x_own_selection, Fx_disown_selection_internal): Rename locals
5265 (x_handle_dnd_message): Remove local to avoid shadowing.
5267 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5268 so that the caller can use some name other than gcpro1.
5269 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5270 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5271 (Fx_backspace_delete_keys_p):
5272 Use them to avoid shadowing, and rename vars to avoid shadowing.
5273 (x_decode_color, x_set_name, x_window): Now static.
5274 (Fx_create_frame): Add braces to silence GCC warning.
5275 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5276 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5277 Remove unused locals.
5278 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5279 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5280 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5283 * xterm.h (x_mouse_leave): New decl.
5285 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5286 Remove unused functions.
5287 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5288 (x_calc_absolute_position): Now static.
5289 (XTread_socket): Don't define label "out" unless it's used.
5290 Don't declare local "event" unless it's used.
5291 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5292 unless they are used.
5293 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5294 (x_fatal_error_signal): Remove; not used.
5295 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5296 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5297 (x_error_catcher, x_connection_closed, x_error_handler):
5298 (x_error_quitter, xembed_send_message, x_iconify_frame):
5299 (my_log_handler): Rename locals to avoid shadowing.
5300 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5301 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5303 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5304 Rename or move locals to avoid shadowing.
5305 (tty_defined_color, merge_face_heights): Now static.
5306 (free_realized_faces_for_fontset): Remove; not used.
5307 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5308 does not deduce is never used uninitialized.
5309 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5310 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5312 * terminal.c (store_terminal_param): Now static.
5314 * xmenu.c (menu_highlight_callback): Now static.
5315 (set_frame_menubar): Remove unused local.
5316 (xmenu_show): Rename parameter to avoid shadowing.
5317 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5318 since they might point to immutable storage.
5319 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5320 since it's unused otherwise.
5322 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5323 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5324 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5325 avoids a gcc -Wuninitialized diagnostic.
5326 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5327 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5328 does not deduce are never used uninitialized.
5330 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5332 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5333 * window.c (window_loop, size_window):
5334 (run_window_configuration_change_hook, enlarge_window): Likewise.
5336 * window.c (display_buffer): Now static.
5337 (size_window): Mark variables that gcc -Wuninitialized
5338 does not deduce are never used uninitialized.
5339 * window.h (check_all_windows): New decl, to forestall
5340 gcc -Wmissing-prototypes diagnostic.
5341 * dispextern.h (bidi_dump_cached_states): Likewise.
5343 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5345 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5347 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5348 and to avoid gcc -Wuninitialized warning.
5349 (load_charset_map): Mark variables that gcc -Wuninitialized
5350 does not deduce are never used uninitialized.
5351 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5353 * coding.c (coding_set_source, coding_set_destination):
5354 Use "else { /* comment */ }" rather than "else /* comment */;"
5355 for clarity, and to avoid gcc -Wempty-body warning.
5356 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5357 a block, when the outer 'i' will do.
5358 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5359 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5360 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5361 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5362 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5363 Rename locals to avoid shadowing.
5364 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5365 * coding.c (emacs_mule_char, encode_invocation_designation):
5366 Now static, since they're not used elsewhere.
5367 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5368 (decode_coding_object, encode_coding_object, detect_coding_system):
5369 (decode_coding_emacs_mule): Mark variables that gcc
5370 -Wuninitialized does not deduce are never used uninitialized.
5371 (detect_coding_iso_2022): Initialize a local variable that might
5372 be used uninitialized. Leave a FIXME because it's not clear that
5373 this initialization is needed. (Bug#8211)
5374 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5375 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5376 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5377 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5378 Remove unused macros.
5380 * category.c (hash_get_category_set): Remove unused local var.
5381 (copy_category_table): Now static, since it's not used elsewhere.
5382 * character.c (string_count_byte8): Likewise.
5384 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5385 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5387 * chartab.c (copy_sub_char_table): Now static, since it's not used
5389 (sub_char_table_ref_and_range, char_table_ref_and_range):
5390 Rename locals to avoid shadowing.
5391 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5393 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5394 (BIDI_BOB): Remove unused macro.
5396 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5397 deduce are never used uninitialized.
5398 * term.c (encode_terminal_code): Likewise.
5400 * term.c (encode_terminal_code): Now static. Remove unused local.
5402 * tparam.h: New file.
5403 * term.c, tparam.h: Include it.
5404 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5405 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5406 Move these decls to tparam.h, and make them agree with what
5407 is actually in tparam.c. The previous trick of using incompatible
5408 decls in different modules does not conform to the C standard.
5409 All callers of tparam changed to use tparam's actual API.
5410 * tparam.c (tparam1, tparam, tgoto):
5411 Use const pointers where appropriate.
5413 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5414 * cm.h (struct cm): Likewise.
5415 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5416 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5417 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5418 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5419 (turn_on_face, init_tty): Likewise.
5420 * termchar.h (struct tty_display_info): Likewise.
5422 * term.c (term_mouse_position): Rename local to avoid shadowing.
5424 * alloc.c (mark_ttys): Move decl from here ...
5425 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5427 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5429 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5431 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5433 * search.c (compile_pattern_1): Remove argument regp, unused since
5434 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5435 (compile_pattern): Don't pass it.
5437 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5439 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5440 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5442 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5444 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5446 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5447 gdk_window_get_screen, gdk_window_get_geometry,
5448 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5449 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5450 (xg_get_pixbuf_from_pixmap): New function.
5451 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5452 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5453 Call xg_get_pixbuf_from_pixmap instead of
5454 gdk_pixbuf_get_from_drawable.
5455 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5456 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5457 (xg_check_special_colors): Use GtkStyleContext and its functions
5459 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5460 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5461 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5462 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5463 Call gtk_widget_get_preferred_size.
5464 (xg_frame_resized): gdk_window_get_geometry only takes 5
5466 (xg_win_to_widget, xg_event_is_for_menubar):
5467 Call gdk_x11_window_lookup_for_display.
5468 (xg_set_widget_bg): New function.
5469 (delete_cb): New function.
5470 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5471 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5472 (xg_set_background_color): Call xg_set_widget_bg.
5473 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5474 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5475 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5476 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5478 (update_frame_tool_bar): Call gtk_widget_hide.
5479 (xg_initialize): Use GDK_KEY_g.
5481 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5483 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5485 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5486 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5487 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5489 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5491 * w32xfns.c (select_palette): Check success of RealizePalette against
5492 GDI_ERROR, not zero.
5494 See ChangeLog.11 for earlier changes.
5500 Copyright (C) 2011 Free Software Foundation, Inc.
5502 This file is part of GNU Emacs.
5504 GNU Emacs is free software: you can redistribute it and/or modify
5505 it under the terms of the GNU General Public License as published by
5506 the Free Software Foundation, either version 3 of the License, or
5507 (at your option) any later version.
5509 GNU Emacs is distributed in the hope that it will be useful,
5510 but WITHOUT ANY WARRANTY; without even the implied warranty of
5511 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5512 GNU General Public License for more details.
5514 You should have received a copy of the GNU General Public License
5515 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.