Fix earlier half-done eieio-defmethod change.
[bpt/emacs.git] / src / ChangeLog
1 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2
3 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4 `gnutls_certificate_set_x509_key_file'.
5
6 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7
8 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9 Update dependencies.
10
11 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
12
13 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
14 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
15 Remove unused parameter `fildes'.
16 * process.c (read_process_output, send_process): Don't pass it.
17
18 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
19
20 Fix previous change: the library cache is defined in w32.c.
21 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
22 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
23
24 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
25
26 Implement dynamic loading of GnuTLS on Windows.
27
28 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
29 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
30 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
31 Declare.
32
33 * gnutls.c (Qgnutls_dll): Define.
34 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
35 (gnutls_*): Declare function pointers.
36 (init_gnutls_functions): New function to initialize function pointers.
37 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
38 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
39 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
40 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
41 (emacs_gnutls_write, emacs_gnutls_read)
42 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
43 (Fgnutls_available_p): New function.
44 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
45 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
46 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
47
48 * image.c: Include w32.h.
49 (Vimage_type_cache): Delete.
50 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
51 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
52 (w32_delayed_load): Move to w32.c.
53
54 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
55
56 * w32.c (QCloaded_from, Vlibrary_cache): Define.
57 (w32_delayed_load): Move from image.c. When loading a library, record
58 its filename in the :loaded-from property of the library id.
59 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
60 Initialize and staticpro them.
61 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
62
63 * process.c: Include lisp.h before w32.h, not after.
64 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
65 instead of gnutls_record_check_pending.
66
67 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
68
69 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
70
71 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
72 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
73 as passed in.
74
75 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
76
77 * xterm.c (x_set_frame_alpha): Do not set property on anything
78 else than FRAME_X_OUTER_WINDOW (Bug#8608).
79
80 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
81
82 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
83
84 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
85
86 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
87 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
88 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
89 (gnutls_global_initialized, Qgnutls_bootprop_priority)
90 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
91 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
92 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
93 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
94 (Qgnutls_bootprop_callbacks_verify): Make static.
95
96 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
97
98 * callproc.c: Indentation fixup.
99
100 * sysdep.c (wait_for_termination_1): Make static.
101 (wait_for_termination, interruptible_wait_for_termination): Move
102 after wait_for_termination_1.
103
104 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
105
106 * sysdep.c (interruptible_wait_for_termination): New function
107 which is like wait_for_termination, but allows keyboard
108 interruptions.
109
110 * callproc.c (Fcall_process): Add (:file "file") as an option for
111 the STDOUT buffer.
112 (Fcall_process_region): Ditto.
113
114 2011-04-30 Eli Zaretskii <eliz@gnu.org>
115
116 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
117 rather than `XVECTOR (FOO)->size'.
118
119 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
120 inttypes.h, as a gnulib replacement is used if it not available in
121 system headers.
122
123 2011-04-21 Eli Zaretskii <eliz@gnu.org>
124
125 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
126 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
127 of MOST_POSITIVE_FIXNUM. (Bug#8528)
128
129 * coding.c (coding_alloc_by_realloc): Error out if destination
130 will grow beyond MOST_POSITIVE_FIXNUM.
131 (decode_coding_emacs_mule): Abort if there isn't enough place in
132 charbuf for the composition carryover bytes. Reserve an extra
133 space for up to 2 characters produced in a loop.
134 (decode_coding_iso_2022): Abort if there isn't enough place in
135 charbuf for the composition carryover bytes.
136
137 2011-04-21 Eli Zaretskii <eliz@gnu.org>
138
139 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
140 aborting when %lld or %lll format is passed.
141 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
142 %llo or %llx format is passed. (Bug#8545)
143
144 * window.c (window_scroll_line_based): Use a marker instead of
145 simple variables to record original value of point. (Bug#7952)
146
147 * doprnt.c (doprnt): Fix the case where a multibyte sequence
148 produced by %s or %c overflows available buffer space. (Bug#8545)
149
150 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
151
152 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
153 (SIZE_MAX): Move defn after all includes, as they might #define it.
154
155 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
156
157 * w32.c (init_environment): Warn about defaulting HOME to C:\.
158
159 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
160
161 * keyboard.c (Qdelayed_warnings_hook): Define.
162 (command_loop_1): Run `delayed-warnings-hook'
163 if Vdelayed_warnings_list is non-nil.
164 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
165 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
166
167 2011-04-28 Eli Zaretskii <eliz@gnu.org>
168
169 * doprnt.c (doprnt): Don't return value smaller than the buffer
170 size if the message was truncated. (Bug#8545).
171
172 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
173
174 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
175 (Fx_window_property): #if-0 the whole functions, not just the bodies.
176
177 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
178
179 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
180
181 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
182
183 * makefile.w32-in: Update dependencies.
184
185 2011-04-27 Eli Zaretskii <eliz@gnu.org>
186
187 Improve `doprnt' and its usage. (Bug#8545)
188 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
189 `format_end'. Remove support for %l as a conversion specifier.
190 Don't use xrealloc. Improve diagnostics when the %l size modifier
191 is used. Update the commentary.
192
193 * eval.c (verror): Simplify calculation of size_t.
194
195 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
196 messages.
197
198 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
199
200 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
201 change.
202
203 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
204
205 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
206 This makes this file independent of the recent pseudovector change.
207
208 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
209
210 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
211
212 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
213 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
214 Remove unused local.
215 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
216
217 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
218 GCC 4.6.0 optimizes based on type-based alias analysis. For
219 example, if b is of type struct buffer * and v of type struct
220 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
221 != &v->size, and therefore "v->size = 1; b->size = 2; return
222 v->size;" must therefore return 1. This assumption is incorrect
223 for Emacs, since it type-puns struct Lisp_Vector * with many other
224 types. To fix this problem, this patch adds a new type struct
225 vectorlike_header that documents the constraints on layout of vectors
226 and pseudovectors, and helps optimizing compilers not get fooled
227 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
228 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
229 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
230 the size member.
231 (XSETPVECTYPE): Rewrite in terms of new macro.
232 (XSETPVECTYPESIZE): New macro, specifying both type and size.
233 This is a bit clearer, and further avoids the possibility of
234 undesirable aliasing.
235 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
236 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
237 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
238 since Lisp_Subr is a special case (no "next" field).
239 (ASIZE): Now uses header.size rather than size. All
240 previous uses of XVECTOR (foo)->size replaced to use this macro,
241 to avoid the hassle of writing XVECTOR (foo)->header.size.
242 (struct vectorlike_header): New type.
243 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
244 object, to help avoid aliasing.
245 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
246 (SUBRP): Likewise, since Lisp_Subr is a special case.
247 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
248 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
249 (struct Lisp_Hash_Table): Combine first two members into a single
250 struct vectorlike_header member. All uses of "size" and "next" members
251 changed to be "header.size" and "header.next".
252 * buffer.h (struct buffer): Likewise.
253 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
254 * frame.h (struct frame): Likewise.
255 * process.h (struct Lisp_Process): Likewise.
256 * termhooks.h (struct terminal): Likewise.
257 * window.c (struct save_window_data, struct saved_window): Likewise.
258 * window.h (struct window): Likewise.
259 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
260 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
261 * buffer.c (init_buffer_once): Likewise.
262 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
263 special case.
264 * process.c (Fformat_network_address): Use local var for size,
265 for brevity.
266
267 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
268
269 Make the Lisp reader and string-to-float more consistent (Bug#8525)
270 * data.c (atof): Remove decl; no longer used or needed.
271 (digit_to_number): Move to lread.c.
272 (Fstring_to_number): Use new string_to_number function, to be
273 consistent with how the Lisp reader treats infinities and NaNs.
274 Do not assume that floating-point numbers represent EMACS_INT
275 without losing information; this is not true on most 64-bit hosts.
276 Avoid double-rounding errors, by insisting on integers when
277 parsing non-base-10 numbers, as the documentation specifies.
278 * lisp.h (string_to_number): New decl, replacing ...
279 (isfloat_string): Remove.
280 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
281 (read1): Do not accept +. and -. as integers; this
282 appears to have been a coding error. Similarly, do not accept
283 strings like +-1e0 as floating point numbers. Do not report
284 overflow for integer overflows unless the base is not 10 which
285 means we have no simple and reliable way to continue.
286 Break out the floating-point parsing into a new
287 function string_to_number, so that Fstring_to_number parses
288 floating point numbers consistently with the Lisp reader.
289 (digit_to_number): Moved here from data.c. Make it static inline.
290 (E_CHAR, EXP_INT): Remove, replacing with ...
291 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
292 (string_to_number): New function, replacing isfloat_string.
293 This function checks for valid syntax and produces the resulting
294 Lisp float number too. Rework it so that string-to-number
295 no longer mishandles examples like "1.0e+". Use strtoumax,
296 so that overflow for non-base-10 numbers is reported only when
297 there's no portable and simple way to convert to floating point.
298
299 * textprop.c (set_text_properties_1): Rewrite for clarity,
300 and to avoid GCC warning about integer overflow.
301
302 * intervals.h (struct interval): Use EMACS_INT for members
303 where EMACS_UINT might cause problems. See
304 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
305 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
306 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
307 All uses changed.
308 (offset_intervals): Tell GCC not to worry about length overflow
309 when negating a negative length.
310
311 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
312 (overrun_check_free): Likewise.
313
314 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
315 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
316 word size.
317
318 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
319 (gnutls_make_error): Rename local to avoid shadowing.
320 (gnutls_emacs_global_deinit): ifdef out; not used.
321 (Fgnutls_boot): Use const for pointer to readonly storage.
322 Comment out unused local. Fix pointer signedness problems.
323
324 * lread.c (openp): Don't stuff size_t into an 'int'.
325 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
326 about possible signed overflow.
327
328 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
329 (GDK_KEY_g): Don't define if already defined.
330 (xg_prepare_tooltip): Avoid pointer signedness problem.
331 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
332
333 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
334 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
335
336 * xfns.c (Fx_window_property): Simplify a bit,
337 to make a bit faster and to avoid GCC 4.6.0 warning.
338 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
339
340 * fns.c (internal_equal): Don't assume size_t fits in int.
341
342 * alloc.c (compact_small_strings): Tighten assertion a little.
343
344 Replace pEd with more-general pI, and fix some printf arg casts.
345 * lisp.h (pI): New macro, generalizing old pEd macro to other
346 conversion specifiers. For example, use "...%"pI"d..." rather
347 than "...%"pEd"...".
348 (pEd): Remove. All uses replaced with similar uses of pI.
349 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
350 * alloc.c (check_pure_size): Don't overflow by converting size to int.
351 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
352 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
353 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
354 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
355 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
356 64-bit hosts.
357 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
358 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
359 * print.c (safe_debug_print, print_object): Likewise.
360 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
361 to int.
362 Use pI instead of if-then-else-abort. Use %p to avoid casts,
363 avoiding the 0 flag, which is not portable.
364 * process.c (Fmake_network_process): Use pI to avoid cast.
365 * region-cache.c (pp_cache): Likewise.
366 * xdisp.c (decode_mode_spec): Likewise.
367 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
368 behavior on 64-bit hosts with printf arg.
369 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
370 (x_stop_queuing_selection_requests): Likewise.
371 (x_get_window_property): Don't truncate byte count to an 'int'
372 when tracing.
373
374 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
375 here, since it parses constructs like leading '-' and spaces,
376 which are not wanted; and it overflows with large numbers.
377 Instead, simply match F[0-9]+, which is what is wanted anyway.
378
379 * alloc.c: Remove unportable assumptions about struct layout.
380 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
381 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
382 (allocate_vectorlike, make_pure_vector): Use the new macros,
383 plus offsetof, to remove unportable assumptions about struct layout.
384 These assumptions hold on all porting targets that I know of, but
385 they are not guaranteed, they're easy to remove, and removing them
386 makes further changes easier.
387
388 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
389 This doesn't fix a bug but makes the code clearer.
390 (string_overrun_cookie): Now const. Use initializers that
391 don't formally overflow signed char, to avoid warnings.
392 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
393 can cause Emacs to crash when string overrun checking is enabled.
394 (allocate_buffer): Don't assume sizeof (struct buffer) is a
395 multiple of sizeof (EMACS_INT); it need not be, if
396 alignof(EMACS_INT) < sizeof (EMACS_INT).
397 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
398
399 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
400
401 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
402
403 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
404
405 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
406 supposed to be handshaking. (Bug#8556)
407 Reported by Paul Eggert <eggert@cs.ucla.edu>.
408
409 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
410
411 * lisp.h (Qdebug): List symbol.
412 * eval.c (Qdebug): Restore global linkage.
413 * keyboard.c (debug-on-event): New variable.
414 (handle_user_signal): Break into debugger when debug-on-event
415 matches the current signal symbol.
416
417 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
418
419 * alloc.c (check_sblock, check_string_bytes)
420 (check_string_free_list): Convert to standard C.
421
422 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
423
424 * w32.c (emacs_gnutls_push): Fix typo.
425
426 2011-04-25 Eli Zaretskii <eliz@gnu.org>
427
428 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
429 "cast to pointer from integer of different size".
430
431 Improve doprnt and its use in verror. (Bug#8545)
432 * doprnt.c (doprnt): Document the set of format control sequences
433 supported by the function. Use SAFE_ALLOCA instead of always
434 using `alloca'.
435
436 * eval.c (verror): Don't limit the buffer size at size_max-1, that
437 is one byte too soon. Don't use xrealloc; instead xfree and
438 xmalloc anew.
439
440 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
441
442 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
443 callbacks stage.
444
445 * gnutls.c: Renamed global_initialized to
446 gnutls_global_initialized. Added internals for the
447 :verify-hostname-error, :verify-error, and :verify-flags
448 parameters of `gnutls-boot' and documented those parameters in the
449 docstring. Start callback support.
450 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
451 unless a fatal error occured. Call gnutls_alert_send_appropriate
452 on error. Return error code.
453 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
454 (emacs_gnutls_read): Likewise.
455 (Fgnutls_boot): Return handshake error code.
456 (emacs_gnutls_handle_error): New function.
457 (wsaerror_to_errno): Likewise.
458
459 * w32.h (emacs_gnutls_pull): Add prototype.
460 (emacs_gnutls_push): Likewise.
461
462 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
463 (emacs_gnutls_push): Likewise.
464
465 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
466
467 * process.c (wait_reading_process_output): Check if GnuTLS
468 buffered some data internally if no FDs are set for TLS
469 connections.
470
471 * makefile.w32-in (OBJ2): Add gnutls.$(O).
472 (LIBS): Link to USER_LIBS.
473 ($(BLD)/gnutls.$(0)): New target.
474
475 2011-04-24 Eli Zaretskii <eliz@gnu.org>
476
477 * xdisp.c (handle_single_display_spec): Rename the
478 display_replaced_before_p argument into display_replaced_p, to
479 make it consistent with the commentary. Fix typos in the
480 commentary.
481
482 * textprop.c (syms_of_textprop): Remove dead code.
483 (copy_text_properties): Delete obsolete commentary about an
484 interface that was deleted long ago. Fix typos in the description
485 of arguments.
486
487 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
488 to changes in oldXMenu/XMenu.h from 2011-04-16.
489 <menu_help_message, prev_menu_help_message>: Constify.
490 (IT_menu_make_room): menu->help_text is now `const char **';
491 adjust.
492
493 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
494 to changes in oldXMenu/XMenu.h from 2011-04-16.
495 (struct XMenu): Declare `help_text' `const char **'.
496
497 * xfaces.c <Qunspecified>: Make extern again.
498
499 * syntax.c: Include sys/types.h before including regex.h, as
500 required by Posix.
501
502 * doc.c (get_doc_string): Improve the format passed to `error'.
503
504 * doprnt.c (doprnt): Improve commentary.
505
506 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
507
508 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
509 them with etags.
510
511 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
512 changes in globals.h immediately force recompilation.
513 (TAGS): Depend on $(CURDIR)/m/intel386.h and
514 $(CURDIR)/s/ms-w32.h.
515 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
516
517 * character.c (Fchar_direction): Function deleted.
518 (syms_of_character): Don't defsubr it.
519 <char-direction-table>: Deleted.
520
521 2011-04-23 Eli Zaretskii <eliz@gnu.org>
522
523 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
524 * doprnt.c: Include limits.h.
525 (SIZE_MAX): New macro.
526 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
527 local variables are now size_t instead of int or unsigned.
528 Improve overflow protection. Support `l' modifier for integer
529 conversions. Support %l conversion. Don't assume an EMACS_INT
530 argument for integer conversions and for %c.
531
532 * lisp.h (doprnt): Restore prototype.
533
534 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
535 $(SRC)/character.h.
536
537 * Makefile.in (base_obj): Add back doprnt.o.
538
539 * deps.mk (doprnt.o): Add back prerequisites.
540 (callint.o): Depend on character.h.
541
542 * eval.c (internal_lisp_condition_case): Include the handler
543 representation in the error message.
544 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
545 when breaking from the loop.
546
547 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
548
549 * callint.c (Fcall_interactively): When displaying error message
550 about invalid control letter, pass the character's codepoint, not
551 a pointer to its multibyte form. Improve display of the character
552 in octal and display also its hex code.
553
554 * character.c (char_string): Use %x to display the (unsigned)
555 codepoint of an invalid character, to avoid displaying a bogus
556 negative value.
557
558 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
559 `error', not SYMBOL_NAME itself.
560
561 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
562 character arguments to `error'.
563
564 * charset.c (check_iso_charset_parameter): Fix incorrect argument
565 to `error' in error message about FINAL_CHAR argument. Make sure
566 FINAL_CHAR is a character, and use %c when it is passed as
567 argument to `error'.
568
569 2011-04-23 Eli Zaretskii <eliz@gnu.org>
570
571 * s/ms-w32.h (localtime): Redirect to sys_localtime.
572
573 * w32.c: Include <time.h>.
574 (sys_localtime): New function.
575
576 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
577
578 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
579
580 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
581
582 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
583
584 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
585 zombies (Bug#8467).
586
587 2011-04-19 Eli Zaretskii <eliz@gnu.org>
588
589 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
590 gl_state.e_property when gl_state.object is Qt.
591
592 * insdel.c (make_gap_larger): Remove limitation of buffer size
593 to <= INT_MAX.
594
595 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
596
597 * xdisp.c (lookup_glyphless_char_display)
598 (produce_glyphless_glyph): Handle cons cell entry in
599 glyphless-char-display.
600 (Vglyphless_char_display): Document it.
601
602 * term.c (produce_glyphless_glyph): Handle cons cell entry in
603 glyphless-char-display.
604
605 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
606
607 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
608
609 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
610
611 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
612 definition for no-X builds.
613
614 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
615
616 Static checks with GCC 4.6.0 and non-default toolkits.
617
618 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
619
620 * process.c (keyboard_bit_set): Define only if SIGIO.
621 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
622 (send_process): Repair possible setjmp clobbering.
623
624 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
625
626 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
627
628 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
629
630 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
631 Define only if needed.
632
633 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
634 by pacifying GCC about it. Maybe it's time to retire it?
635 * xfaces.c (USG, __TIMEVAL__): Likewise.
636
637 * dispextern.h (struct redisplay_interface): Rename param
638 to avoid shadowing.
639 * termhooks.h (struct terminal): Likewise.
640 * xterm.c (xembed_send_message): Likewise.
641
642 * insdel.c (make_gap_smaller): Define only if
643 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
644
645 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
646 it.
647
648 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
649 so that we aren't warned about unused symbols.
650
651 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
652
653 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
654
655 * xfns.c (x_real_positions): Mark locals as initialized.
656
657 * xmenu.c (xmenu_show): Don't use uninitialized vars.
658
659 * xterm.c: Fix problems found by static analysis with other toolkits.
660 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
661 (x_dispatch_event): Declare static if USE_GTK, and
662 define if USE_GTK || USE_X_TOOLKIT.
663 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
664 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
665 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
666 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
667
668 * xmenu.c (menu_help_callback): Pointer type fixes.
669 Use const pointers when pointing at readonly data. Avoid pointer
670 signedness clashes.
671 (FALSE): Remove unused macro.
672 (update_frame_menubar): Remove unused decl.
673
674 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
675
676 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
677 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
678 (single_menu_item): Rename local to avoid shadowing.
679
680 * keyboard.c (make_lispy_event): Remove unused local var.
681
682 * frame.c, frame.h (x_get_resource_string): Bring this back, but
683 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
684
685 * bitmaps: Change bitmaps from unsigned char back to the X11
686 compatible char. Avoid the old compiler warnings about
687 out-of-range initializers by using, for example, '\xab' rather
688 than 0xab.
689
690 * xgselect.c (xgselect_initialize): Check vs interface
691 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
692
693 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
694
695 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
696 to read-only memory.
697
698 * fns.c (vector): Remove; this old hack is no longer needed.
699
700 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
701 Remove unused var.
702 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
703
704 * xrdb.c (x_load_resources): Omit unused local.
705
706 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
707 (x_window): Rename locals to avoid shadowing.
708 (USG): Use the kludged USG macro, to pacify gcc.
709
710 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
711 (x_term_init): Remove local to avoid shadowing.
712
713 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
714
715 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
716 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
717
718 2011-04-16 Eli Zaretskii <eliz@gnu.org>
719
720 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
721
722 Fix regex.c, syntax.c and friends for buffers > 2GB.
723 * syntax.h (struct gl_state_s): Declare character position members
724 EMACS_INT.
725
726 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
727
728 * textprop.c (verify_interval_modification, interval_of): Declare
729 arguments EMACS_INT.
730
731 * intervals.c (adjust_intervals_for_insertion): Declare arguments
732 EMACS_INT.
733
734 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
735
736 * indent.c (Fvertical_motion): Local variable it_start is now
737 EMACS_INT.
738
739 * regex.c (re_match, re_match_2, re_match_2_internal)
740 (bcmp_translate, regcomp, regexec, print_double_string)
741 (group_in_compile_stack, re_search, re_search_2, regex_compile)
742 (re_compile_pattern, re_exec): Declare arguments and local
743 variables `size_t' and `ssize_t' and return values `regoff_t', as
744 appropriate.
745 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
746 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
747 <compile_stack_type>: `size' and `avail' are now `size_t'.
748
749 * regex.h <regoff_t>: Use ssize_t, not int.
750 (re_search, re_search_2, re_match, re_match_2): Arguments that
751 specify buffer/string position and length are now ssize_t and
752 size_t. Return type is regoff_t.
753
754 2011-04-16 Ben Key <bkey76@gmail.com>
755
756 * nsfont.m: Fixed bugs in ns_get_family and
757 ns_descriptor_to_entity that were caused by using free to
758 deallocate memory blocks that were allocated by xmalloc (via
759 xstrdup). This caused Emacs to crash when compiled with
760 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
761 --enable-checking=xmallocoverrun). xfree is now used to
762 deallocate these memory blocks.
763
764 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
765
766 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
767
768 emacs_write: Accept and return EMACS_INT for sizes.
769 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
770 et seq.
771 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
772 Accept and return EMACS_INT.
773 (emacs_gnutls_write): Return the number of bytes written on
774 partial writes.
775 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
776 (emacs_read, emacs_write): Remove check for negative size, as the
777 Emacs source code has been audited now.
778 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
779 (emacs_read, emacs_write): Use it.
780 * process.c (send_process): Adjust to the new signatures of
781 emacs_write and emacs_gnutls_write. Do not attempt to store
782 a byte offset into an 'int'; it might overflow.
783 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
784
785 * sound.c: Don't assume sizes fit in 'int'.
786 (struct sound_device.period_size, alsa_period_size):
787 Return EMACS_INT, not int.
788 (struct sound_device.write, vox_write, alsa_write):
789 Accept EMACS_INT, not int.
790 (wav_play, au_play): Use EMACS_INT to store sizes and to
791 record read return values.
792
793 2011-04-15 Ben Key <bkey76@gmail.com>
794
795 * keyboard.c (Qundefined): Don't declare static since it is used
796 in nsfns.m.
797 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
798 static since they are used in nsfont.m.
799
800 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
801
802 * process.c (Qprocessp): Don't declare static.
803 * lisp.h (Qprocessp): Declare again.
804
805 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
806
807 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
808
809 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
810
811 Improve C-level modularity by making more things 'static'.
812
813 Don't publish debugger-only interfaces to other modules.
814 * lisp.h (safe_debug_print, debug_output_compilation_hack):
815 (verify_bytepos, count_markers): Move decls to the only modules
816 that need them.
817 * region-cache.h (pp_cache): Likewise.
818 * window.h (check_all_windows): Likewise.
819 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
820
821 * sysdep.c (croak): Now static, if
822 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
823 * syssignal.h (croak): Declare only if not static.
824
825 * alloc.c (refill_memory_reserve): Now static if
826 !defined REL_ALLOC || defined SYSTEM_MALLOC.
827 * lisp.h (refill_memory_reserve): Declare only if not static.
828
829 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
830 Define only if USE_LUCID.
831
832 * xrdb.c (x_customization_string, x_rm_string): Now static.
833
834 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
835 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
836
837 * xdisp.c (draw_row_with_mouse_face): Now static.
838 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
839
840 * window.h (check_all_windows): Mark externally visible.
841
842 * window.c (window_deletion_count): Now static.
843
844 * undo.c: Make symbols static if they're not exported.
845 (last_undo_buffer, last_boundary_position, pending_boundary):
846 Now static.
847
848 * textprop.c (interval_insert_behind_hooks): Now static.
849 (interval_insert_in_front_hooks): Likewise.
850
851 * term.c: Make symbols static if they're not exported.
852 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
853 (max_frame_lines, tty_set_terminal_modes):
854 (tty_reset_terminal_modes, tty_turn_off_highlight):
855 (get_tty_terminal): Now static.
856 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
857 * termhooks.h (term_mouse_moveto): Do not declare if
858 HAVE_WINDOW_SYSTEM.
859 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
860 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
861
862 * sysdep.c: Make symbols static if they're not exported.
863 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
864 Now static.
865 (sigprocmask_set, full_mask): Remove; unused.
866 (wait_debugging): Mark as visible.
867 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
868 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
869
870 * syntax.c (syntax_temp): Define only if !__GNUC__.
871
872 * sound.c (current_sound_device, current_sound): Now static.
873
874 * search.c (searchbufs, searchbuf_head): Now static.
875
876 * scroll.c (scroll_cost): Remove; unused.
877 * dispextern.h (scroll_cost): Remove decl.
878
879 * region-cache.h (pp_cache): Mark as externally visible.
880
881 * process.c: Make symbols static if they're not exported.
882 (process_tick, update_tick, create_process, chan_process):
883 (Vprocess_alist, proc_buffered_char, datagram_access):
884 (fd_callback_data, send_process_frame, process_sent_to): Now static.
885 (deactivate_process): Mark defn as static, as well as decl.
886 * lisp.h (create_process): Remove decl.
887 * process.h (chan_process, Vprocess_alist): Remove decls.
888
889 * print.c: Make symbols static if they're not exported.
890 (print_depth, new_backquote_output, being_printed, print_buffer):
891 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
892 (print_interval, print_number_index, initial_stderr_stream):
893 Now static.
894 * lisp.h (Fprinc): Remove decl.
895 (debug_output_compilation_hack): Mark as externally visible.
896
897 * sysdep.c (croak): Move decl from here to syssignal.h.
898 * syssignal.h (croak): Put it here, so the API can be checked when
899 'croak' is called from dissociate_if_controlling_tty.
900
901 * minibuf.c: Make symbols static if they're not exported.
902 (minibuf_save_list, choose_minibuf_frame): Now static.
903 * lisp.h (choose_minibuf_frame): Remove decl.
904
905 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
906
907 * lread.c: Make symbols static if they're not exported.
908 (read_objects, initial_obarray, oblookup_last_bucket_number):
909 Now static.
910 (make_symbol): Remove; unused.
911 * lisp.h (initial_obarray, make_symbol): Remove decls.
912
913 * keyboard.c: Make symbols static if they're not exported.
914 (single_kboard, recent_keys_index, total_keys, recent_keys):
915 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
916 (this_single_command_key_start, echoing, last_auto_save):
917 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
918 (command_loop, echo_now, keyboard_init_hook, help_char_p):
919 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
920 (Vlispy_mouse_stem, double_click_count):
921 Now static.
922 (force_auto_save_soon): Define only if SIGDANGER.
923 (ignore_mouse_drag_p): Now static if
924 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
925 (print_help): Remove; unused.
926 (stop_character, last_timer_event): Mark as externally visible.
927 * keyboard.h (ignore_mouse_drag_p): Declare only if
928 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
929 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
930 * lisp.h (echoing): Remove decl.
931 (force_auto_save_soon): Declare only if SIGDANGER.
932 * xdisp.c (redisplay_window): Simplify code, to make it more
933 obvious that ignore_mouse_drag_p is not accessed if !defined
934 USE_GTK && !defined HAVE_NS.
935
936 * intervals.c: Make symbols static if they're not exported.
937 (merge_properties_sticky, merge_interval_right, delete_interval):
938 Now static.
939 * intervals.h (merge_interval_right, delete_interval): Remove decls.
940
941 * insdel.c: Make symbols static if they're not exported.
942 However, leave prepare_to_modify_buffer alone. It's never
943 called from outside this function, but that appears to be a bug.
944 (combine_after_change_list, combine_after_change_buffer):
945 (adjust_after_replace, signal_before_change): Now static.
946 (adjust_after_replace_noundo): Remove; unused.
947 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
948 (signal_before_change): Remove decls.
949
950 * indent.c (val_compute_motion, val_vmotion): Now static.
951
952 * image.c: Make symbols static if they're not exported.
953 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
954 if USE_GTK.
955 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
956 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
957
958 * fringe.c (standard_bitmaps): Now static.
959 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
960
961 * frame.c: Make symbols static if they're not exported.
962 (x_report_frame_params, make_terminal_frame): Now static.
963 (get_frame_param): Now static, unless HAVE_NS.
964 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
965 (x_get_resource_string): Remove; not used.
966 * frame.h (make_terminal_frame, x_report_frame_params):
967 (x_get_resource_string); Remove decls.
968 (x_fullscreen_adjust): Declare only if WINDOWSNT.
969 * lisp.h (get_frame_param): Declare only if HAVE_NS.
970
971 * font.c, fontset.c: Make symbols static if they're not exported.
972 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
973 (FACE_SUITABLE_FOR_CHAR_P): Use it.
974 * font.c (font_close_object): Now static.
975 * font.h (font_close_object): Remove.
976 * fontset.c (FONTSET_OBJLIST): Remove.
977 (free_realized_fontset) #if-0 the body, which does nothing.
978 (face_suitable_for_char_p): #if-0, as it's never called.
979 * fontset.h (face_suitable_for_char_p): Remove decl.
980 * xfaces.c (face_at_string_position): Use
981 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
982 since 0 is always ASCII.
983
984 * fns.c (weak_hash_tables): Now static.
985
986 * fileio.c: Make symbols static if they're not exported.
987 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
988 (Vwrite_region_annotation_buffers): Now static.
989
990 * eval.c: Make symbols static if they're not exported.
991 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
992 * lisp.h (backtrace_list): Remove decl.
993
994 * emacs.c: Make symbols static if they're not exported.
995 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
996 (fatal_error_code, fatal_error_signal_hook, standard_args):
997 Now static.
998 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
999 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1000 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1001 * lisp.h (fatal_error_signal_hook): Remove decl.
1002 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1003
1004 * editfns.c: Move a (normally-unused) function to its only use.
1005 * editfns.c, lisp.h (get_operating_system_release): Remove.
1006 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1007 worth the hassle of breaking this out.
1008
1009 * xterm.c: Make symbols static if they're not exported.
1010 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1011 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1012 (x_destroy_window, x_delete_display):
1013 Now static.
1014 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1015 (x_mouse_leave): Remove; unused.
1016 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1017 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1018 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1019 Remove decls.
1020 (x_mouse_leave): Declare only if WINDOWSNT.
1021 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1022 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1023 USE_X_TOOLKIT.
1024
1025 * ftxfont.c: Make symbols static if they're not exported.
1026 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1027 HAVE_FREETYPE.
1028 * font.h (ftxfont_driver): Likewise.
1029
1030 * xfns.c: Make symbols static if they're not exported.
1031 (x_last_font_name, x_display_info_for_name):
1032 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1033 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1034 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1035 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1036 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1037 (last_show_tip_args): Now static.
1038 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1039 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1040 (x_screen_planes): Remove; unused.
1041 * dispextern.h (x_screen_planes): Remove decl.
1042
1043 * dispnew.c: Make symbols static if they're not exported.
1044 * dispextern.h (redraw_garbaged_frames, scrolling):
1045 (increment_row_positions): Remove.
1046 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1047 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1048 Now static.
1049 (redraw_garbaged_frames): Remove; unused.
1050
1051 * xfaces.c: Make symbols static if they're not exported.
1052 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1053 Remove decls.
1054 * xterm.h (defined_color): Remove decls.
1055 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1056 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1057 (menu_face_changed_default, defined_color, free_realized_face):
1058 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1059 (ascii_face_of_lisp_face): Remove; unused.
1060
1061 * xdisp.c: Make symbols static if they're not exported.
1062 * dispextern.h (scratch_glyph_row, window_box_edges):
1063 (glyph_to_pixel_coords, set_cursor_from_row):
1064 (get_next_display_element, set_iterator_to_next):
1065 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1066 (show_mouse_face): Remove decls
1067 * frame.h (message_buf_print): Likewise.
1068 * lisp.h (pop_message, set_message, check_point_in_composition):
1069 Likewise.
1070 * xterm.h (set_vertical_scroll_bar): Likewise.
1071 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1072 (message_buf_print, scratch_glyph_row, displayed_buffer):
1073 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1074 (get_next_display_element, show_mouse_face, window_box_edges):
1075 (frame_to_window_pixel_xy, check_point_in_composition):
1076 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1077 (glyph_to_pixel_coords): Remove; unused.
1078
1079 * dired.c (file_name_completion): Now static.
1080
1081 * dbusbind.c (xd_in_read_queued_messages): Now static.
1082
1083 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1084 * data.c (circular_list_error): Remove.
1085
1086 * commands.h (last_point_position, last_point_position_buffer):
1087 (last_point_position_window): Remove decls.
1088 * keyboard.c: Make these variables static.
1089
1090 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1091 decls.
1092 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1093 (iso_code_class, detect_coding, code_convert_region): Now static.
1094 (encode_coding_gap): Remove; unused.
1095
1096 * chartab.c (chartab_chars, chartab_bits): Now static.
1097
1098 * charset.h (charset_iso_8859_1): Remove decl.
1099 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1100 Now static.
1101
1102 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1103 * ccl.c (Vccl_program_table): Now static.
1104 (check_ccl_update): Remove; unused.
1105
1106 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1107 * category.h: ... from here.
1108 * category.c (check_category_table, set_category_set): Now static.
1109
1110 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1111 * lisp.h: Remove these decls.
1112
1113 * buffer.c (buffer_count): Remove unused var.
1114
1115 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1116 so that it's not optimized away.
1117 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1118 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1119 exported only to the debugger.
1120
1121 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1122 * atimer.h (run_all_atimers): Removed; not exported.
1123
1124 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1125 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1126 was inaccessible from Lisp.
1127 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1128 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1129
1130 alloc.c: Import and export fewer symbols, and remove unused items.
1131 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1132 is defined.
1133 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1134 it's not optimized away by whole-program optimization.
1135 (message_enable_multibyte, free_misc): Remove.
1136 (catchlist, handlerlist, mark_backtrace):
1137 Declare only if BYTE_MARK_STACK.
1138 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1139 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1140 (message_enable_multibyte): Remove decl.
1141 (free_misc, interval_free_list, float_block, float_block_index):
1142 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1143 (cons_free_list, last_marked_index):
1144 Now static.
1145 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1146 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1147 (mark_backtrace): Define only if BYTE_MARK_STACK.
1148 * xdisp.c (message_enable_multibyte): Now static.
1149
1150 Declare Lisp_Object Q* variables to be 'static' if not exported.
1151 This makes it easier for human readers (and static analyzers)
1152 to see whether these variables are used from other modules.
1153 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1154 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1155 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1156 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1157 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1158 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1159 * xmenu.c, xselect.c:
1160 Declare Q* vars static if they are not used in other modules.
1161 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1162 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1163 Remove decls of unexported vars.
1164 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1165
1166 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1167
1168 Make Emacs functions such as Fatom 'static' by default.
1169 This makes it easier for human readers (and static analyzers)
1170 to see whether these functions can be called from other modules.
1171 DEFUN now defines a static function. To make the function external
1172 so that it can be used in other C modules, use the new macro DEFUE.
1173 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1174 (Finit_image_library):
1175 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1176 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1177 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1178 Remove decls, since these functions are now static.
1179 (Funintern, Fget_internal_run_time): New decls, since these functions
1180 were already external.
1181
1182 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1183 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1184 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1185 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1186 * keyboard.c, keymap.c, lread.c:
1187 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1188 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1189 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1190 Mark functions with DEFUE instead of DEFUN,
1191 if they are used in other modules.
1192 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1193 decls for now-static functions.
1194 * buffer.h (Fdelete_overlay): Remove decl.
1195 * callproc.c (Fgetenv_internal): Mark as internal.
1196 * composite.c (Fremove_list_of_text_properties): Remove decl.
1197 (Fcomposition_get_gstring): New forward static decl.
1198 * composite.h (Fcomposite_get_gstring): Remove decl.
1199 * dired.c (Ffile_attributes): New forward static decl.
1200 * doc.c (Fdocumntation_property): New forward static decl.
1201 * eval.c (Ffetch_bytecode): New forward static decl.
1202 (Funintern): Remove extern decl; now in .h file where it belongs.
1203 * fileio.c (Fmake_symbolic_link): New forward static decl.
1204 * image.c (Finit_image_library): New forward static decl.
1205 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1206 * intervals.h (Fprevious_property_change):
1207 (Fremove_list_of_text_properties): Remove decls.
1208 * keyboard.c (Fthis_command_keys): Remove decl.
1209 (Fcommand_execute): New forward static decl.
1210 * keymap.c (Flookup_key): New forward static decl.
1211 (Fcopy_keymap): Now static.
1212 * keymap.h (Flookup_key): Remove decl.
1213 * process.c (Fget_process): New forward static decl.
1214 (Fprocess_datagram_address): Mark as internal.
1215 * syntax.c (Fsyntax_table_p): New forward static decl.
1216 (skip_chars): Remove duplicate decl.
1217 * textprop.c (Fprevious_property_change): New forward static decl.
1218 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1219 Now internal.
1220 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1221 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1222
1223 * editfns.c (Fformat): Remove unreachable code.
1224
1225 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1226
1227 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1228 change. (Bug#8496)
1229
1230 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1231
1232 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1233 when at ZV. (Bug#8487)
1234
1235 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1236
1237 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1238 (Bug#8437)
1239 * keyboard.c (parse_tool_bar_item): Likewise.
1240 * sound.c (sound_cleanup, alsa_close): Likewise.
1241 * termcap.c (tgetent): Likewise.
1242 * xfns.c (x_default_font_parameter): Likewise.
1243 * xsettings.c (read_and_apply_settings): Likewise.
1244
1245 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1246 (overrun_check_free): Protoize.
1247
1248 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1249
1250 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1251 since callers should never pass a negative size.
1252 Change the signature to match that of plain 'read' and 'write'; see
1253 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1254 * lisp.h: Update prototypes of emacs_write and emacs_read.
1255
1256 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1257
1258 * xdisp.c (redisplay_window): Don't try to determine the character
1259 position of the scroll margin if the window start point w->startp
1260 is outside the buffer's accessible region. (Bug#8468)
1261
1262 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1263
1264 Fix write-region and its subroutines for buffers > 2GB.
1265 * fileio.c (a_write, e_write): Modify declaration of arguments and
1266 local variables to support buffers larger than 2GB.
1267 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1268
1269 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1270 argument, local variables, and return value.
1271
1272 * lisp.h: Update prototypes of emacs_write and emacs_read.
1273
1274 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1275
1276 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1277
1278 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1279
1280 Fix more problems found by GCC 4.6.0's static checks.
1281
1282 * xdisp.c (vmessage): Use a better test for character truncation.
1283
1284 * charset.c (load_charset_map): <, not <=, for optimization,
1285 and to avoid potential problems with integer overflow.
1286 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1287 * casetab.c (set_identity, shuffle): Likewise.
1288 * editfns.c (Fformat): Likewise.
1289 * syntax.c (skip_chars): Likewise.
1290
1291 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1292 This also lets GCC 4.6.0 generate slightly better loop code.
1293
1294 * callint.c (Fcall_interactively): <, not <=, for optimization.
1295 (Fcall_interactively): Count the number of arguments produced,
1296 not the number of arguments given. This is simpler and lets GCC
1297 4.6.0 generate slightly better code.
1298
1299 * ftfont.c: Distingish more carefully between FcChar8 and char.
1300 The previous code passed unsigned char * to a functions like
1301 strlen and xstrcasecmp that expect char *, which does not
1302 conform to the C standard.
1303 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1304 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1305 char * when the C standard requires it.
1306
1307 * keyboard.c (read_char): Remove unused var.
1308
1309 * eval.c: Port to Windows vsnprintf (Bug#8435).
1310 Include <limits.h>.
1311 (SIZE_MAX): Define if the headers do not.
1312 (verror): Do not give up if vsnprintf returns a negative count.
1313 Instead, grow the buffer. This ports to Windows vsnprintf, which
1314 does not conform to C99. Problem reported by Eli Zaretskii.
1315 Also, simplify the allocation scheme, by avoiding the need for
1316 calling realloc, and removing the ALLOCATED variable.
1317
1318 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1319
1320 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1321 But keep the doprint source code for now, as we might revamp it
1322 and use it again (Bug#8435).
1323 * lisp.h (doprnt): Remove.
1324 * Makefile.in (base_obj): Remove doprnt.o.
1325 * deps.mk (doprnt.o): Remove.
1326
1327 error: Print 32- and 64-bit integers portably (Bug#8435).
1328 Without this change, on typical 64-bit hosts error ("...%d...", N)
1329 was used to print both 32- and 64-bit integers N, which relied on
1330 undefined behavior.
1331 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1332 New macro.
1333 * lisp.h (error, verror): Mark as printf-like functions.
1334 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1335 Report overflow in size calculations when allocating printf buffer.
1336 Do not truncate output string at its first null byte.
1337 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1338 Truncate the output at a character boundary, since vsnprintf does not
1339 do that.
1340 * charset.c (check_iso_charset_parameter): Convert internal
1341 character to string before calling 'error', since %c now has the
1342 printf meaning.
1343 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1344 overflow when computing char to be passed to 'error'. Do not
1345 pass Lisp_Object to 'error'; pass the integer instead.
1346 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1347 formatted with plain %d.
1348
1349 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1350
1351 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1352
1353 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1354
1355 * xterm.c (x_catch_errors): Remove duplicate declaration.
1356
1357 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1358
1359 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1360
1361 2011-04-10 Jim Meyering <meyering@redhat.com>
1362
1363 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1364 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1365 return ssize_t not "int", and use size_t as the buffer length.
1366 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1367 * gnutls.h: Update declarations.
1368 * process.c (read_process_output): Use ssize_t, to match.
1369 (send_process): Likewise.
1370
1371 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1372
1373 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1374
1375 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1376
1377 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1378 unsigned char, to match FcChar8 type definition.
1379
1380 * xterm.c (handle_one_xevent):
1381 * xmenu.c (create_and_show_popup_menu):
1382 * xselect.c (x_decline_selection_request)
1383 (x_reply_selection_request): Avoid type-punned deref of X events.
1384
1385 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1386
1387 Fix some uses of `int' instead of EMACS_INT.
1388 * search.c (string_match_1, fast_string_match)
1389 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1390 (scan_buffer, find_next_newline_no_quit)
1391 (find_before_next_newline, search_command, Freplace_match)
1392 (Fmatch_data): Make some `int' variables be EMACS_INT.
1393
1394 * xdisp.c (display_count_lines): 3rd argument and return value now
1395 EMACS_INT. All callers changed.
1396 (pint2hrstr): Last argument is now EMACS_INT.
1397
1398 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1399 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1400 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1401 (decode_coding_utf_16, decode_coding_emacs_mule)
1402 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1403 (decode_coding_ccl, decode_coding_charset)
1404 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1405 (decode_coding_iso_2022, decode_coding_emacs_mule)
1406 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1407 <char_offset, last_offset>: Declare EMACS_INT.
1408 (encode_coding_utf_8, encode_coding_utf_16)
1409 (encode_coding_emacs_mule, encode_invocation_designation)
1410 (encode_designation_at_bol, encode_coding_iso_2022)
1411 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1412 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1413 Declare EMACS_INT.
1414 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1415 (encode_invocation_designation): Last argument P_NCHARS is now
1416 EMACS_INT.
1417 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1418 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1419
1420 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1421 All users changed.
1422
1423 * ccl.c (Fccl_execute_on_string): Declare some variables
1424 EMACS_INT.
1425
1426 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1427
1428 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1429
1430 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1431
1432 * process.c (Fformat_network_address): Doc fix.
1433
1434 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1435
1436 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1437
1438 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1439
1440 * keyboard.c (read_char): Call Lisp function help-form-show,
1441 instead of using internal_with_output_to_temp_buffer.
1442 (Qhelp_form_show): New var.
1443 (syms_of_keyboard): Use DEFSYM macro.
1444
1445 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1446
1447 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1448
1449 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1450
1451 * process.c (Flist_processes): Removed to Lisp.
1452 (list_processes_1): Deleted.
1453
1454 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1455
1456 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1457
1458 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1459
1460 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1461
1462 Fix more problems found by GCC 4.6.0's static checks.
1463
1464 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1465
1466 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1467
1468 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1469
1470 * xdisp.c (vmessage): Mark as a printf-like function.
1471
1472 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1473
1474 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1475
1476 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1477 printf-like functions.
1478 (tiff_load): Add casts to remove these marks before passing them
1479 to system-supplied API.
1480
1481 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1482
1483 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1484 This avoids several warnings with gcc -Wstrict-overflow.
1485 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1486 directly, rather than having caller test rule sign. This avoids
1487 some unnecessary tests.
1488 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1489 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1490 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1491
1492 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1493 (xfont_open): Avoid unnecessary tests.
1494
1495 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1496
1497 * composite.h, composite.c (composition_gstring_put_cache):
1498 Use EMACS_INT, not int, for length.
1499
1500 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1501 breaking out part of COMPOSITION_DECODE_RULE.
1502 (COMPOSITION_DECODE_RULE): Use it.
1503 * composite.c (get_composition_id): Remove unused local vars,
1504 by using the new macro.
1505
1506 * textprop.c (set_text_properties_1): Change while to do-while,
1507 since the condition is always true at first.
1508
1509 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1510 (interval_deletion_adjustment): Return unsigned value.
1511 All uses changed.
1512
1513 * process.c (list_processes_1, create_pty, read_process_output):
1514 (exec_sentinel): Remove vars that were set but not used.
1515 (create_pty): Remove unnecessary "volatile"s.
1516 (Fnetwork_interface_info): Avoid possibility of int overflow.
1517 (read_process_output): Do adaptive read buffering even if carryover.
1518 (read_process_output): Simplify nbytes computation if buffered.
1519
1520 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1521
1522 * syntax.c (scan_words): Remove var that was set but not used.
1523 (update_syntax_table): Use unsigned instead of int.
1524
1525 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1526 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1527 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1528
1529 * print.c (print_error_message): Avoid int overflow.
1530
1531 * font.c (font_list_entities): Redo for clarity,
1532 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1533
1534 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1535 (font_score): Avoid potential overflow in diff calculation.
1536
1537 * fns.c (substring_both): Remove var that is set but not used.
1538 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1539
1540 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1541
1542 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1543 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1544 can always succeed if overflow has undefined behavior.
1545
1546 * search.c (boyer_moore, wordify): Remove vars set but not used.
1547 (wordify): Omit three unnecessary tests.
1548
1549 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1550 All callers changed. This avoids the need for an unused var.
1551
1552 * casefiddle.c (casify_region): Remove var that is set but not used.
1553
1554 * dired.c (file_name_completion): Remove var that is set but not used.
1555
1556 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1557
1558 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1559 (Finsert_file_contents): Remove unnecessary code checking fd.
1560
1561 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1562 Check for integer overflow on size calculations.
1563
1564 * buffer.c (Fprevious_overlay_change): Remove var that is set
1565 but not used.
1566
1567 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1568 Remove vars that are set but not used.
1569 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1570 (timer_check_2): Mark vars as initialized.
1571
1572 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1573
1574 * image.c (lookup_image): Remove var that is set but not used.
1575 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1576
1577 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1578 that are set but not used.
1579
1580 * xfns.c (make_invisible_cursor): Don't return garbage
1581 if XCreateBitmapFromData fails (Bug#8410).
1582
1583 * xselect.c (x_get_local_selection, x_handle_property_notify):
1584 Remove vars that are set but not used.
1585
1586 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1587 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1588
1589 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1590 Remove var that is set but not used.
1591 (scroll_bar_windows_size): Now size_t, not int.
1592 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1593 Check for overflow.
1594
1595 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1596 (map_tty_color) [!defined MSDOS]: Likewise.
1597
1598 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1599
1600 * coding.c: Remove vars that are set but not used.
1601 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1602 All callers changed.
1603 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1604 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1605 (decode_coding_charset): Remove vars that are set but not used.
1606
1607 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1608 that is set but not used.
1609
1610 * print.c (print_object): Remove var that is set but not used.
1611
1612 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1613 The gnulib version avoids calling malloc in the usual case,
1614 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1615 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1616 * filelock.c (current_lock_owner): Likewise.
1617 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1618 * sysdep.c: Include allocator.h, careadlinkat.h.
1619 (emacs_no_realloc_allocator): New static constant.
1620 (emacs_readlink): New function.
1621 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1622 ../lib/careadlinkat.h.
1623
1624 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1625
1626 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1627 first non-nil return value).
1628
1629 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1630
1631 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1632 if not defined (Bug#8403).
1633
1634 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1635
1636 * xdisp.c (display_count_lines): Remove parameter `start',
1637 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1638 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1639 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1640 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1641 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1642 and thereabouts. All callers changed.
1643 (get_per_char_metric): Remove parameter `f', unused since
1644 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1645
1646 2011-04-02 Jim Meyering <meyering@redhat.com>
1647
1648 do not dereference NULL upon failed strdup
1649 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1650 (ns_get_family): Likewise.
1651
1652 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1653
1654 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1655
1656 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1657
1658 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1659 later (Bug#8403).
1660
1661 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1662
1663 Add lexical binding.
1664
1665 * window.c (Ftemp_output_buffer_show): New fun.
1666 (Fsave_window_excursion):
1667 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1668
1669 * lread.c (lisp_file_lexically_bound_p): New function.
1670 (Fload): Bind Qlexical_binding.
1671 (readevalloop): Remove `evalfun' arg.
1672 Bind Qinternal_interpreter_environment.
1673 (Feval_buffer): Bind Qlexical_binding.
1674 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1675 Mark as dynamic.
1676 (syms_of_lread): Declare `lexical-binding'.
1677
1678 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1679
1680 * keyboard.c (eval_dyn): New fun.
1681 (menu_item_eval_property): Use it.
1682
1683 * image.c (parse_image_spec): Use Ffunctionp.
1684
1685 * fns.c (concat, mapcar1): Accept byte-code-functions.
1686
1687 * eval.c (Fsetq): Handle lexical vars.
1688 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1689 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1690 (FletX, Flet): Obey lexical binding.
1691 (Fcommandp): Handle closures.
1692 (Feval): New `lexical' arg.
1693 (eval_sub): New function extracted from Feval. Use it almost
1694 everywhere where Feval was used. Look up vars in lexical env.
1695 Handle closures.
1696 (Ffunctionp): Move from subr.el.
1697 (Ffuncall): Handle closures.
1698 (apply_lambda): Remove `eval_flags'.
1699 (funcall_lambda): Handle closures and new byte-code-functions.
1700 (Fspecial_variable_p): New function.
1701 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1702 but without exporting it to Lisp.
1703
1704 * doc.c (Fdocumentation, store_function_docstring):
1705 * data.c (Finteractive_form): Handle closures.
1706
1707 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1708 interactive spec.
1709
1710 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1711 byte-codes.
1712 (exec_byte_code): New function extracted from Fbyte_code to handle new
1713 calling convention for byte-code-functions. Add new byte-codes.
1714
1715 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1716
1717 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1718
1719 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1720
1721 * xdisp.c (redisplay_internal): Fix prototype.
1722
1723 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1724
1725 * xdisp.c (SCROLL_LIMIT): New macro.
1726 (try_scrolling): Use it when setting scroll_limit. Limit
1727 scrolling to 100 screen lines.
1728 (redisplay_window): Even when falling back on "recentering",
1729 position point in the window according to scroll-conservatively,
1730 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1731
1732 (try_scrolling): When point is above the window, allow searching
1733 as far as scroll_max, or one screenful, to compute vertical
1734 distance from PT to the scroll margin position. This prevents
1735 try_scrolling from unnecessarily failing when
1736 scroll-conservatively is set to a value slightly larger than the
1737 window height. Clean up the case of PT below the margin at bottom
1738 of window: scroll_max can no longer be INT_MAX. When aggressive
1739 scrolling is in use, don't let point enter the opposite scroll
1740 margin as result of the scroll.
1741 (syms_of_xdisp) <scroll-conservatively>: Document the
1742 threshold of 100 lines for never-recentering scrolling.
1743
1744 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1745
1746 * dispextern.h (move_it_by_lines):
1747 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1748 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1749 (message_log_check_duplicate): Remove parameters `prev_bol' and
1750 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1751 (redisplay_internal): Remove parameter `preserve_echo_area',
1752 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1753
1754 * indent.c (Fvertical_motion):
1755 * window.c (window_scroll_pixel_based, Frecenter):
1756 Don't pass `need_y_p' to `move_it_by_lines'.
1757
1758 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1759
1760 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1761 steal a few bits to be more compact.
1762 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1763 Remove unneeded casts.
1764
1765 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1766
1767 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1768
1769 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1770 binding" message (bug#7967).
1771
1772 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1773
1774 Fix more problems found by GCC 4.6.0's static checks.
1775
1776 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1777 Remove unused local var.
1778
1779 * editfns.c (Fmessage_box): Remove unused local var.
1780
1781 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1782 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1783 Omit unused local vars.
1784 * window.c (shrink_windows): Omit unused local var.
1785 * menu.c (digest_single_submenu): Omit unused local var.
1786 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1787 Omit unused local var.
1788
1789 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1790 Don't assume string length fits in int.
1791 (keyremap_step, read_key_sequence): Use size_t for sizes.
1792 (read_key_sequence): Don't check last_real_key_start redundantly.
1793
1794 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1795 instead of alloca (Bug#8344).
1796
1797 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1798 (Fbacktrace_frame): Don't assume nframes fits in int.
1799
1800 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1801
1802 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1803 concerns.
1804
1805 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1806
1807 * cm.c (calccost): Turn while-do into do-while, for clarity.
1808
1809 * keyboard.c (syms_of_keyboard): Use the same style as later
1810 in this function when indexing through an array. This also
1811 works around GCC bug 48267.
1812
1813 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1814
1815 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1816
1817 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1818 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1819
1820 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1821 This avoids undefined behavior on integer overflow, and is a bit
1822 more convenient anyway since it is compared to a size_t variable.
1823
1824 Variadic C functions now count arguments with size_t, not int.
1825 This avoids an unnecessary limitation on 64-bit machines, which
1826 caused (substring ...) to crash on large vectors (Bug#8344).
1827 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1828 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1829 All variadic functions and their callers changed accordingly.
1830 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1831 * data.c (arith_driver, float_arith_driver): Likewise.
1832 * editfns.c (general_insert_function): Likewise.
1833 * eval.c (struct backtrace.nargs, interactive_p)
1834 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1835 (funcall_lambda, mark_backtrace): Likewise.
1836 * fns.c (concat): Likewise.
1837 * frame.c (x_set_frame_parameters): Likewise.
1838 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1839 0 if not found, not -1. All callers changed.
1840
1841 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1842 (stack_copy_size): Now size_t, not int.
1843 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1844
1845 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1846
1847 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1848 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1849 All callers changed.
1850
1851 * lisp.h (multibyte_char_to_unibyte):
1852 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1853 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1854 * character.h (CHAR_TO_BYTE8):
1855 * cmds.c (internal_self_insert):
1856 * editfns.c (general_insert_function):
1857 * keymap.c (push_key_description):
1858 * search.c (Freplace_match):
1859 * xdisp.c (message_dolog, set_message_1): All callers changed.
1860
1861 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1862
1863 * keyboard.c (safe_run_hook_funcall): New function.
1864 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1865 don't set the hook to nil, but remove the offending function instead.
1866 (Qcommand_hook_internal): Remove, unused.
1867 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1868 Vcommand_hook_internal.
1869
1870 * eval.c (enum run_hooks_condition): Remove.
1871 (funcall_nil, funcall_not): New functions.
1872 (run_hook_with_args): Call each function through a `funcall' argument.
1873 Remove `cond' argument, now redundant.
1874 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1875 (Frun_hook_with_args_until_failure): Adjust accordingly.
1876 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1877
1878 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1879
1880 * dispextern.h (string_buffer_position): Remove declaration.
1881
1882 * print.c (strout): Remove parameter `multibyte', unused since
1883 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1884
1885 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1886 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1887 All callers changed.
1888
1889 * w32.c (_wsa_errlist): Use braces for struct initializers.
1890
1891 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1892 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1893 All callers changed.
1894 (string_buffer_position): Likewise. Also, make static (it's never
1895 used outside xdisp.c).
1896 (cursor_row_p): Remove parameter `w', unused since
1897 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1898 (decode_mode_spec): Remove parameter `precision', introduced during
1899 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1900 All callers changed.
1901
1902 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1903
1904 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1905
1906 2011-03-27 Anders Lindgren <andlind@gmail.com>
1907
1908 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1909 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1910 (ns_update_auto_hide_menu_bar): New functions.
1911 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1912 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1913 ns_constrain_all_frames.
1914 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1915 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1916
1917 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1918
1919 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1920
1921 2011-03-27 Glenn Morris <rgm@gnu.org>
1922
1923 * syssignal.h: Replace RETSIGTYPE with void.
1924 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1925 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1926 Replace SIGTYPE with void everywhere.
1927 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1928 * s/template.h (SIGTYPE): Remove commented out definition.
1929
1930 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1931
1932 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1933 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1934
1935 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1936
1937 * w32.c (read_unc_volume): Use parameter `henum', instead of
1938 global variable `wget_enum_handle'.
1939
1940 * keymap.c (describe_vector): Remove parameters `indices' and
1941 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1942 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1943
1944 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1945
1946 * keyboard.c (timer_check): Remove parameter `do_it_now',
1947 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1948 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1949 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1950
1951 * keyboard.c (read_char):
1952 * w32menu.c (w32_menu_display_help):
1953 * xmenu.c (show_help_event, menu_help_callback):
1954 Adjust calls to `show_help_echo'.
1955
1956 * gtkutil.c (xg_maybe_add_timer):
1957 * keyboard.c (readable_events):
1958 * process.c (wait_reading_process_output):
1959 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1960
1961 * insdel.c (adjust_markers_gap_motion):
1962 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1963 (gap_left, gap_right): Don't call it.
1964
1965 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1966
1967 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1968 incurred during fontification.
1969
1970 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1971
1972 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1973 (DEFVAR_PER_BUFFER): Don't pass it.
1974
1975 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1976 (scrolling_window): Don't pass it.
1977
1978 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1979
1980 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1981
1982 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1983 and `suffix'.
1984 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1985 of variables specific to SELinux and computation of `encoded_absname'.
1986
1987 * image.c (XPutPixel): Remove unused variable `height'.
1988
1989 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1990
1991 * unexw32.c (get_section_info): Remove unused variable `section'.
1992
1993 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1994 (system_process_attributes): Remove unused variable `sess'.
1995 (sys_read): Remove unused variable `err'.
1996
1997 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1998 (w32_wnd_proc): Remove unused variable `isdead'.
1999 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2000 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2001 (x_create_tip_frame): Remove unused variable `tem'.
2002
2003 * w32inevt.c (w32_console_read_socket):
2004 Remove unused variable `no_events'.
2005
2006 * w32term.c (x_draw_composite_glyph_string_foreground):
2007 Remove unused variable `width'.
2008
2009 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2010
2011 * w32term.c (x_set_glyph_string_clipping):
2012 Don't pass uninitialized region to CombineRgn.
2013
2014 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2015
2016 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2017 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2018 (Fx_close_connection): Remove unused variable `i'.
2019
2020 * w32font.c (w32font_draw): Return number of glyphs.
2021 (w32font_open_internal): Remove unused variable `i'.
2022 (w32font_driver): Add missing initializer.
2023
2024 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2025 (fill_in_menu): Remove unused variable `items_added'.
2026
2027 * w32term.c (last_mouse_press_frame): Remove static global variable.
2028 (w32_clip_to_row): Remove unused variable `f'.
2029 (x_delete_terminal): Remove unused variable `i'.
2030
2031 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2032 (NOTHING): Remove unused static global variable.
2033 (uniscribe_check_otf): Remove unused variable `table'.
2034 (uniscribe_font_driver): Add missing initializers.
2035
2036 2011-03-23 Julien Danjou <julien@danjou.info>
2037
2038 * term.c (Fsuspend_tty, Fresume_tty):
2039 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2040 * window.c (temp_output_buffer_show):
2041 * insdel.c (signal_before_change):
2042 * frame.c (Fhandle_switch_frame):
2043 * fileio.c (Fdo_auto_save):
2044 * emacs.c (Fkill_emacs):
2045 * editfns.c (save_excursion_restore):
2046 * cmds.c (internal_self_insert):
2047 * callint.c (Fcall_interactively):
2048 * buffer.c (Fkill_all_local_variables):
2049 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2050 Use Frun_hooks.
2051 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2052 unconditionnaly since it does the check itself.
2053
2054 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2055
2056 Fix more problems found by GCC 4.5.2's static checks.
2057
2058 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2059 the first time through the loop, since we know p0 < p1 then.
2060 This also avoids a gcc -Wstrict-overflow warning.
2061
2062 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2063 leading to a memory leak, possible in functions like
2064 load_charset_map_from_file that can allocate an unbounded number
2065 of objects (Bug#8318).
2066
2067 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2068 that could (at least in theory) be that large.
2069
2070 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2071 This is less likely to overflow, and avoids undefined behavior if
2072 overflow does occur. All callers changed. Use strtoul to scan
2073 for the unsigned long integer.
2074 (pint2hrstr): Simplify and tune code slightly.
2075 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2076
2077 * scroll.c (do_scrolling): Work around GCC bug 48228.
2078 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2079
2080 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2081 This also avoids a warning with gcc -Wstrict-overflow.
2082 (validate_x_resource_name): Simplify count usage.
2083 This also avoids a warning with gcc -Wstrict-overflow.
2084
2085 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2086 fail (Bug#8306).
2087
2088 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2089
2090 * process.c (Fmake_network_process): Use socklen_t, not int,
2091 where POSIX says socklen_t is required in portable programs.
2092 This fixes a porting bug on hosts like 64-bit HP-UX, where
2093 socklen_t is wider than int (Bug#8277).
2094 (Fmake_network_process, server_accept_connection):
2095 (wait_reading_process_output, read_process_output):
2096 Likewise.
2097
2098 * process.c: Rename or move locals to avoid shadowing.
2099 (list_processes_1, Fmake_network_process):
2100 (read_process_output_error_handler, exec_sentinel_error_handler):
2101 Rename or move locals.
2102 (Fmake_network_process): Define label "retry_connect" only if needed.
2103 (Fnetwork_interface_info): Fix pointer signedness.
2104 (process_send_signal): Add cast to avoid pointer signedness problem.
2105 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2106 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2107
2108 Make tparam.h and terminfo.c consistent.
2109 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2110 Include tparam.h instead, since it declares them.
2111 * cm.h (PC): Remove extern decl; tparam.h now does this.
2112 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2113 * terminfo.c: Include tparam.h, to check interfaces.
2114 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2115 (tparam): Adjust signature to match interface in tparam.h;
2116 this removes some undefined behavior. Check that outstring and len
2117 are zero, which they always are with Emacs.
2118 * tparam.h (PC, BC, UP): New extern decls.
2119
2120 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2121 (xftfont_open): Rename locals to avoid shadowing.
2122
2123 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2124 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2125 (OTF_TAG_SYM): Omit macro if not needed.
2126 (ftfont_list): Remove unused local.
2127 (get_adstyle_property, ftfont_pattern_entity):
2128 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2129 Rename locals to avoid shadowing.
2130
2131 * xfont.c (xfont_list_family): Mark var as initialized.
2132
2133 * xml.c (make_dom): Now static.
2134
2135 * composite.c (composition_compute_stop_pos): Rename local to
2136 avoid shadowing.
2137 (composition_reseat_it): Remove unused locals.
2138 (find_automatic_composition, composition_adjust_point): Likewise.
2139 (composition_update_it): Mark var as initialized.
2140 (find_automatic_composition): Mark vars as initialized,
2141 with a FIXME (Bug#8290).
2142
2143 character.h: Rename locals to avoid shadowing.
2144 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2145 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2146 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2147 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2148 to avoid shadowing.
2149
2150 * textprop.c (property_change_between_p): Remove; unused.
2151
2152 * intervals.c (interval_start_pos): Now static.
2153
2154 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2155
2156 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2157 Rename locals to avoid shadowing.
2158
2159 * sound.c (wav_play, au_play, Fplay_sound_internal):
2160 Fix pointer signedness.
2161 (alsa_choose_format): Remove unused local var.
2162 (wav_play): Initialize a variable to 0, to prevent undefined
2163 behavior (Bug#8278).
2164
2165 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2166
2167 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2168
2169 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2170 clobbering (Bug#8298).
2171 * sysdep.c (sys_subshell): Likewise.
2172 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2173
2174 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2175 This should get cleaned up, so that child_setup has the
2176 same signature on all platforms.
2177
2178 * callproc.c (call_process_cleanup): Now static.
2179 (relocate_fd): Rename locals to avoid shadowing.
2180
2181 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2182
2183 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2184 not to be necessary, and produces flickering.
2185
2186 2011-03-20 Glenn Morris <rgm@gnu.org>
2187
2188 * config.in: Remove file.
2189
2190 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2191
2192 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2193 are now in src/globals.h.
2194 (syms_of_minibuf): Remove spurious & from previous change.
2195
2196 2011-03-20 Leo <sdl.web@gmail.com>
2197
2198 * minibuf.c (completing-read-function): New variable.
2199 (completing-read-default): Rename from completing-read.
2200 (completing-read): Call completing-read-function.
2201
2202 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2203
2204 * xfaces.c (Fx_load_color_file):
2205 Read color file from absolute filename (bug#8250).
2206
2207 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2208
2209 * makefile.w32-in: Update dependencies.
2210
2211 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2212
2213 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2214
2215 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2216
2217 Fix more problems found by GCC 4.5.2's static checks.
2218
2219 * process.c (make_serial_process_unwind, send_process_trap):
2220 (sigchld_handler): Now static.
2221
2222 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2223 That way, the code declares only the vars that it needs.
2224 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2225 * s/cygwin.h (PTY_ITERATION): Likewise.
2226 * s/darwin.h (PTY_ITERATION): Likewise.
2227 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2228
2229 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2230 * process.c (allocate_pty): Don't declare stb unless it's needed.
2231
2232 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2233 (CONSTANTLIM): Remove; unused.
2234 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2235 Define only if needed.
2236
2237 * unexelf.c (unexec): Name an expression,
2238 to avoid gcc -Wbad-function-cast warning.
2239 Use a different way to cause a compilation error if anyone uses
2240 n rather than nn, a way that does not involve shadowing.
2241 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2242
2243 * deps.mk (unexalpha.o): Remove; unused.
2244
2245 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2246 * unexec.h: New file.
2247 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2248 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2249 Depend on unexec.h.
2250 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2251 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2252 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2253 Change as necessary to match prototype in unexec.h.
2254
2255 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2256 shadowing.
2257 (back_comment, skip_chars): Mark vars as initialized.
2258
2259 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2260 Rename locals to avoid shadowing.
2261
2262 * lread.c (read1): Rewrite so as not to use empty "else".
2263 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2264
2265 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2266
2267 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2268 warning when compiling print.c.
2269
2270 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2271 instead of using an uninitialized var.
2272 (font_sort_entities): Mark var as initialized.
2273
2274 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2275
2276 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2277 pointers to constants.
2278 (font_parse_fcname): Remove unused vars.
2279 (font_delete_unmatched): Now static.
2280 (font_get_spec): Remove; unused.
2281 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2282 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2283 Rename or move locals to avoid shadowing.
2284
2285 * fns.c (require_nesting_list, require_unwind): Now static.
2286 (Ffillarray): Rename locals to avoid shadowing.
2287
2288 * floatfns.c (domain_error2): Define only if needed.
2289 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2290
2291 * alloc.c (mark_backtrace): Move decl from here ...
2292 * lisp.h: ... to here, so that it can be checked.
2293
2294 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2295 (Fdefvar): Rewrite so as not to use empty "else".
2296 (lisp_indirect_variable): Name an expression,
2297 to avoid gcc -Wbad-function-cast warning.
2298 (Fdefvar): Rename locals to avoid shadowing.
2299
2300 * callint.c (quotify_arg, quotify_args): Now static.
2301 (Fcall_interactively): Rename locals to avoid shadowing.
2302 Use const pointer when appropriate.
2303
2304 * lisp.h (get_system_name, get_operating_system_release):
2305 Move decls here, to check interfaces.
2306 * process.c (get_operating_system_release): Move decl to lisp.h.
2307 * xrdb.c (get_system_name): Likewise.
2308 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2309 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2310 some of which prompt warnings from gcc -Wbad-function-cast.
2311 (Fformat_time_string, Fencode_time, Finsert_char):
2312 (Ftranslate_region_internal, Fformat):
2313 Rename or remove local vars to avoid shadowing.
2314 (Ftranslate_region_internal): Mark var as initialized.
2315
2316 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2317 avoid shadowing.
2318
2319 * lisp.h (eassert): Check that the argument compiles, even if
2320 ENABLE_CHECKING is not defined.
2321
2322 * data.c (Findirect_variable): Name an expression, to avoid
2323 gcc -Wbad-function-cast warning.
2324 (default_value, arithcompare, arith_driver, arith_error): Now static.
2325 (store_symval_forwarding): Rename local to avoid shadowing.
2326 (Fmake_variable_buffer_local, Fmake_local_variable):
2327 Mark variables as initialized.
2328 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2329
2330 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2331 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2332 Rename locals to avoid shadowing.
2333 (mark_stack): Move local variables into the #ifdef region where
2334 they're used.
2335 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2336 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2337 needed otherwise.
2338 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2339 (GC_STRING_CHARS): Remove; not used.
2340 (Fmemory_limit): Cast sbrk's returned value to char *.
2341
2342 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2343 avoids undefined behavior in theory.
2344
2345 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2346
2347 Use functions, not macros, for up- and down-casing (Bug#8254).
2348 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2349 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2350 to use the following functions instead of these macros.
2351 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2352 EMACS_INT, since callers assume the returned value fits in int.
2353 (upcase1): Likewise, for UPCASE_TABLE.
2354 (uppercasep, lowercasep, upcase): New static inline functions.
2355 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2356 the race-condition problem in the old DOWNCASE.
2357
2358 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2359 Rename locals to avoid shadowing.
2360 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2361 (regex_compile, re_search_2, re_match_2_internal):
2362 Remove unused local vars.
2363 (FREE_VAR): Rewrite so as not to use empty "else",
2364 which gcc can warn about.
2365 (regex_compile, re_match_2_internal): Mark locals as initialized.
2366 (RETALLOC_IF): Define only if needed.
2367 (WORDCHAR_P): Likewise. This one is never needed, but is used
2368 only in a comment talking about a compiler bug, so put inside
2369 the #if 0 of that comment.
2370 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2371 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2372 Remove; unused.
2373
2374 * search.c (boyer_moore): Rename locals to avoid shadowing.
2375 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2376 (PREV_CHAR_BOUNDARY): Likewise.
2377
2378 * search.c (simple_search): Remove unused var.
2379
2380 * dired.c (compile_pattern): Move decl from here ...
2381 * lisp.h: ... to here, so that it can be checked.
2382 (struct re_registers): New forward decl.
2383
2384 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2385
2386 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2387 All uses changed.
2388 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2389 Rename locals to avoid shadowing.
2390 (Fvertical_motion): Mark locals as initialized.
2391
2392 * casefiddle.c (casify_object, casify_region): Now static.
2393 (casify_region): Mark local as initialized.
2394
2395 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2396
2397 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2398 New macros, so that the caller can use some names other than
2399 gcpro1, gcpro2, etc.
2400 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2401 of the new macros.
2402 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2403 argument, for consistency with GCPRO2_VAR, etc: it is now the
2404 prefix of the variable, not the variable itself. All uses
2405 changed.
2406 * dired.c (directory_files_internal, file_name_completion):
2407 Rename locals to avoid shadowing.
2408
2409 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2410 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2411 dired.c's scmp function, had undefined behavior.
2412 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2413 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2414 * buffer.h: ... to here, because these macros use current_buffer,
2415 and the new implementation with inline functions needs to have
2416 current_buffer in scope now, rather than later when the macros
2417 are used.
2418 (downcase, upcase1): New static inline functions.
2419 (DOWNCASE, UPCASE1): Reimplement using these functions.
2420 This avoids undefined behavior in expressions like
2421 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2422 from race conditions in accessing the global variables
2423 case_temp1 and case_temp2.
2424 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2425 * lisp.h (case_temp1, case_temp2): Remove their decls.
2426 * character.h (ASCII_CHAR_P): Move from here ...
2427 * lisp.h: ... to here, so that the inline functions mentioned
2428 above can use them.
2429
2430 * dired.c (directory_files_internal_unwind): Now static.
2431
2432 * fileio.c (file_name_as_directory, directory_file_name):
2433 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2434 Now static.
2435 (file_name_as_directory): Use const pointers when appropriate.
2436 (Fexpand_file_name): Likewise. In particular, newdir might
2437 point at constant storage, so make it a const pointer.
2438 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2439 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2440 signedness issues.
2441 (Fset_file_times, Finsert_file_contents, auto_save_error):
2442 Rename locals to avoid shadowing.
2443
2444 * minibuf.c (choose_minibuf_frame_1): Now static.
2445 (Ftry_completion, Fall_completions): Rename or remove locals
2446 to avoid shadowing.
2447
2448 * marker.c (bytepos_to_charpos): Remove; unused.
2449
2450 * lisp.h (verify_bytepos, count_markers): New decls,
2451 so that gcc does not warn that these functions aren't declared.
2452
2453 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2454 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2455 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2456 (copy_text): Remove unused local var.
2457
2458 * filelock.c (within_one_second): Now static.
2459 (lock_file_1): Rename local to avoid shadowing.
2460
2461 * buffer.c (fix_overlays_before): Mark locals as initialized.
2462 (fix_start_end_in_overlays): Likewise. This function should be
2463 simplified by using pointers-to-pointers, but that's a different
2464 matter.
2465 (switch_to_buffer_1): Now static.
2466 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2467 (report_overlay_modification): Rename locals to avoid shadowing.
2468
2469 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2470 Fix pointer signedness issue.
2471 (sys_subshell): Mark local as volatile if checking for lint,
2472 to suppress a gcc -Wclobbered warning that does not seem to be right.
2473 (MAXPATHLEN): Define only if needed.
2474
2475 * process.c (serial_open, serial_configure): Move decls from here ...
2476 * systty.h: ... to here, so that they can be checked.
2477
2478 * fns.c (get_random, seed_random): Move extern decls from here ...
2479 * lisp.h: ... to here, so that they can be checked.
2480
2481 * sysdep.c (reset_io): Now static.
2482 (wait_for_termination_signal): Remove; unused.
2483
2484 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2485 (copy_keymap_item, append_key, push_text_char_description):
2486 Now static.
2487 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2488 (DENSE_TABLE_SIZE): Remove; unused.
2489 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2490 (describe_map_tree):
2491 Rename locals to avoid shadowing.
2492
2493 * keyboard.c: Declare functions static if they are not used elsewhere.
2494 (echo_char, echo_dash, cmd_error, top_level_2):
2495 (poll_for_input, handle_async_input): Now static.
2496 (read_char, kbd_buffer_get_event, make_lispy_position):
2497 (make_lispy_event, make_lispy_movement, apply_modifiers):
2498 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2499 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2500 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2501 (read_key_sequence, read_char): Mark locals as initialized.
2502 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2503
2504 * keyboard.h (make_ctrl_char): New decl.
2505 (mark_kboards): Move decl here ...
2506 * alloc.c (mark_kboards): ... from here.
2507
2508 * lisp.h (force_auto_save_soon): New decl.
2509
2510 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2511 (DEFINE_DUMMY_FUNCTION): New macro.
2512 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2513 Use it.
2514 (main): Add casts to avoid warnings
2515 if GCC considers string literals to be constants.
2516
2517 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2518
2519 * dbusbind.c: Pointer signedness fixes.
2520 (xd_signature, xd_append_arg, xd_initialize):
2521 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2522 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2523 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2524 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2525
2526 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2527 if GCC considers string literals to be constants.
2528 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2529
2530 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2531
2532 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2533 (print_preprocess, print_object): New macro to fix last change.
2534
2535 * print.c (print_preprocess): Don't forget font objects.
2536
2537 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2538
2539 * emacs.c (USAGE3): Doc fixes.
2540
2541 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2542
2543 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2544 structure.
2545
2546 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2547
2548 * lisp.h (VWindow_system, Qfile_name_history):
2549 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2550 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2551 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2552
2553 * w32select.c: Don't #include "keyboard.h".
2554 (run_protected): Add extern declaration for waiting_for_input.
2555
2556 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2557 * w32console.c (detect_input_pending, read_input_pending)
2558 (encode_terminal_code):
2559 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2560 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2561 (w32_system_caret_y, Qfile_name_history):
2562 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2563 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2564 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2565 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2566 * w32proc.c (Qlocal, report_file_error):
2567 * w32term.c (Vwindow_system, updating_frame):
2568 * w32uniscribe.c (initialized, uniscribe_font_driver):
2569 Remove unneeded extern declarations.
2570
2571 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2572
2573 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2574
2575 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2576
2577 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2578 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2579 These macros can no longer be used for assignment.
2580
2581 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2582 Assign struct members directly, instead of using BUF_BEGV etc.
2583 (record_buffer_markers, fetch_buffer_markers): New functions for
2584 recording and fetching special buffer markers.
2585 (set_buffer_internal_1, set_buffer_temp): Use them.
2586
2587 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2588
2589 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2590
2591 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2592 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2593
2594 * xdisp.c (hscroll_window_tree):
2595 (reconsider_clip_changes): Use PT instead of BUF_PT.
2596
2597 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2598
2599 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2600 $(EMACS_ROOT)/lib/intprops.h.
2601
2602 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2603
2604 Fix more problems found by GCC 4.5.2's static checks.
2605
2606 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2607 to unsigned char * to avoid compiler diagnostic.
2608 (xg_free_frame_widgets): Make it clear that a local variable is
2609 needed only if USE_GTK_TOOLTIP.
2610 (gdk_window_get_screen): Make it clear that this macro is needed
2611 only if USE_GTK_TOOLTIP.
2612 (int_gtk_range_get_value): New function, which avoids a diagnostic
2613 from gcc -Wbad-function-cast.
2614 (xg_set_toolkit_scroll_bar_thumb): Use it.
2615 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2616 diagnostic from gcc -Wbad-function-cast.
2617 (get_utf8_string, xg_get_file_with_chooser):
2618 Rename locals to avoid shadowing.
2619 (create_dialog): Move locals to avoid shadowing.
2620
2621 * xgselect.c (xg_select): Remove unused var.
2622
2623 * image.c (four_corners_best): Mark locals as initialized.
2624 (gif_load): Initialize transparent_p to zero (Bug#8238).
2625 Mark another local as initialized.
2626 (my_png_error, my_error_exit): Mark with NO_RETURN.
2627
2628 * image.c (clear_image_cache): Now static.
2629 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2630 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2631 (x_edge_detection): Remove unnecessary cast that
2632 gcc -Wbad-function-cast diagnoses.
2633 (gif_load): Fix pointer signedness.
2634 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2635 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2636
2637 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2638
2639 Improve quality of tests for time stamp overflow.
2640 For example, without this patch (encode-time 0 0 0 1 1
2641 1152921504606846976) returns the obviously-bogus value (-948597
2642 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2643 reports time overflow. See
2644 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2645 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2646 * editfns.c: Include limits.h and intprops.h.
2647 (TIME_T_MIN, TIME_T_MAX): New macros.
2648 (time_overflow): Move earlier, to before first use.
2649 (hi_time, lo_time): New functions, for an accurate test for
2650 out-of-range times.
2651 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2652 (Fget_internal_run_time): Don't assume time_t fits in int.
2653 (make_time): Use list2 instead of Fcons twice.
2654 (Fdecode_time): More accurate test for out-of-range times.
2655 (check_tm_member): New function.
2656 (Fencode_time): Use it, to test for out-of-range times.
2657 (lisp_time_argument): Don't rely on undefined left-shift and
2658 right-shift behavior when checking for time stamp overflow.
2659
2660 * editfns.c (time_overflow): New function, refactoring common code.
2661 (Fformat_time_string, Fdecode_time, Fencode_time):
2662 (Fcurrent_time_string): Use it.
2663
2664 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2665 * dired.c (make_time): Move to ...
2666 * editfns.c (make_time): ... here.
2667 * systime.h: Note the move.
2668
2669 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2670
2671 * fringe.c (update_window_fringes): Remove unused variables.
2672
2673 * unexmacosx.c (copy_data_segment): Also copy __got section.
2674 (Bug#8223)
2675
2676 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2677
2678 * termcap.c [MSDOS]: Include "msdos.h".
2679 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2680 Constify `char *' arguments and their references according to
2681 prototypes in tparam.h.
2682
2683 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2684
2685 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2686 Adapt all references accordingly.
2687
2688 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2689
2690 2011-03-11 Tom Tromey <tromey@redhat.com>
2691
2692 * buffer.c (syms_of_buffer): Remove obsolete comment.
2693
2694 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2695
2696 * termhooks.h (encode_terminal_code): Declare prototype.
2697
2698 * msdos.c (encode_terminal_code): Don't declare prototype.
2699
2700 * term.c (encode_terminal_code): Now external again, used by
2701 w32console.c and msdos.c.
2702
2703 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2704 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2705
2706 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2707
2708 Fix some minor problems found by GCC 4.5.2's static checks.
2709
2710 * fringe.c (update_window_fringes): Mark locals as initialized
2711 (Bug#8227).
2712 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2713
2714 * alloc.c (mark_fringe_data): Move decl from here ...
2715 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2716 to check its interface.
2717 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2718
2719 * fontset.c (free_realized_fontset): Now static.
2720 (Fset_fontset_font): Rename local to avoid shadowing.
2721 (fontset_font): Mark local as initialized.
2722 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2723
2724 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2725
2726 * xselect.c (x_disown_buffer_selections): Remove; not used.
2727 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2728 (x_own_selection, Fx_disown_selection_internal): Rename locals
2729 to avoid shadowing.
2730 (x_handle_dnd_message): Remove local to avoid shadowing.
2731
2732 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2733 so that the caller can use some name other than gcpro1.
2734 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2735 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2736 (Fx_backspace_delete_keys_p):
2737 Use them to avoid shadowing, and rename vars to avoid shadowing.
2738 (x_decode_color, x_set_name, x_window): Now static.
2739 (Fx_create_frame): Add braces to silence GCC warning.
2740 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2741 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2742 Remove unused locals.
2743 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2744 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2745 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2746 macros.
2747
2748 * xterm.h (x_mouse_leave): New decl.
2749
2750 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2751 Remove unused functions.
2752 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2753 (x_calc_absolute_position): Now static.
2754 (XTread_socket): Don't define label "out" unless it's used.
2755 Don't declare local "event" unless it's used.
2756 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2757 unless they are used.
2758 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2759 (x_fatal_error_signal): Remove; not used.
2760 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2761 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2762 (x_error_catcher, x_connection_closed, x_error_handler):
2763 (x_error_quitter, xembed_send_message, x_iconify_frame):
2764 (my_log_handler): Rename locals to avoid shadowing.
2765 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2766 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2767
2768 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2769 Rename or move locals to avoid shadowing.
2770 (tty_defined_color, merge_face_heights): Now static.
2771 (free_realized_faces_for_fontset): Remove; not used.
2772 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2773 does not deduce is never used uninitialized.
2774 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2775 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2776
2777 * terminal.c (store_terminal_param): Now static.
2778
2779 * xmenu.c (menu_highlight_callback): Now static.
2780 (set_frame_menubar): Remove unused local.
2781 (xmenu_show): Rename parameter to avoid shadowing.
2782 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2783 since they might point to immutable storage.
2784 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2785 since it's unused otherwise.
2786
2787 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2788 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2789 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2790 avoids a gcc -Wuninitialized diagnostic.
2791 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2792 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2793 does not deduce are never used uninitialized.
2794
2795 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2796
2797 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2798 * window.c (window_loop, size_window):
2799 (run_window_configuration_change_hook, enlarge_window): Likewise.
2800
2801 * window.c (display_buffer): Now static.
2802 (size_window): Mark variables that gcc -Wuninitialized
2803 does not deduce are never used uninitialized.
2804 * window.h (check_all_windows): New decl, to forestall
2805 gcc -Wmissing-prototypes diagnostic.
2806 * dispextern.h (bidi_dump_cached_states): Likewise.
2807
2808 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2809 shadowing.
2810 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2811 Include <limits.h>.
2812 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2813 and to avoid gcc -Wuninitialized warning.
2814 (load_charset_map): Mark variables that gcc -Wuninitialized
2815 does not deduce are never used uninitialized.
2816 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2817
2818 * coding.c (coding_set_source, coding_set_destination):
2819 Use "else { /* comment */ }" rather than "else /* comment */;"
2820 for clarity, and to avoid gcc -Wempty-body warning.
2821 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2822 a block, when the outer 'i' will do.
2823 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2824 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2825 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2826 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2827 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2828 Rename locals to avoid shadowing.
2829 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2830 * coding.c (emacs_mule_char, encode_invocation_designation):
2831 Now static, since they're not used elsewhere.
2832 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2833 (decode_coding_object, encode_coding_object, detect_coding_system):
2834 (decode_coding_emacs_mule): Mark variables that gcc
2835 -Wuninitialized does not deduce are never used uninitialized.
2836 (detect_coding_iso_2022): Initialize a local variable that might
2837 be used uninitialized. Leave a FIXME because it's not clear that
2838 this initialization is needed. (Bug#8211)
2839 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2840 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2841 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2842 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2843 Remove unused macros.
2844
2845 * category.c (hash_get_category_set): Remove unused local var.
2846 (copy_category_table): Now static, since it's not used elsewhere.
2847 * character.c (string_count_byte8): Likewise.
2848
2849 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2850 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2851
2852 * chartab.c (copy_sub_char_table): Now static, since it's not used
2853 elsewhere.
2854 (sub_char_table_ref_and_range, char_table_ref_and_range):
2855 Rename locals to avoid shadowing.
2856 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2857
2858 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2859 (BIDI_BOB): Remove unused macro.
2860
2861 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2862 deduce are never used uninitialized.
2863 * term.c (encode_terminal_code): Likewise.
2864
2865 * term.c (encode_terminal_code): Now static. Remove unused local.
2866
2867 * tparam.h: New file.
2868 * term.c, tparam.h: Include it.
2869 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2870 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2871 Move these decls to tparam.h, and make them agree with what
2872 is actually in tparam.c. The previous trick of using incompatible
2873 decls in different modules does not conform to the C standard.
2874 All callers of tparam changed to use tparam's actual API.
2875 * tparam.c (tparam1, tparam, tgoto):
2876 Use const pointers where appropriate.
2877
2878 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2879 * cm.h (struct cm): Likewise.
2880 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2881 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2882 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2883 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2884 (turn_on_face, init_tty): Likewise.
2885 * termchar.h (struct tty_display_info): Likewise.
2886
2887 * term.c (term_mouse_position): Rename local to avoid shadowing.
2888
2889 * alloc.c (mark_ttys): Move decl from here ...
2890 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2891
2892 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2893
2894 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2895
2896 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2897
2898 * search.c (compile_pattern_1): Remove argument regp, unused since
2899 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2900 (compile_pattern): Don't pass it.
2901
2902 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2903
2904 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2905 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2906 for ! HAVE_GTK3.
2907 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2908
2909 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2910
2911 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2912 gdk_window_get_screen, gdk_window_get_geometry,
2913 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2914 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2915 (xg_get_pixbuf_from_pixmap): New function.
2916 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2917 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2918 Call xg_get_pixbuf_from_pixmap instead of
2919 gdk_pixbuf_get_from_drawable.
2920 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2921 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2922 (xg_check_special_colors): Use GtkStyleContext and its functions
2923 for HAVE_GTK3.
2924 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2925 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2926 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2927 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2928 Call gtk_widget_get_preferred_size.
2929 (xg_frame_resized): gdk_window_get_geometry only takes 5
2930 parameters.
2931 (xg_win_to_widget, xg_event_is_for_menubar):
2932 Call gdk_x11_window_lookup_for_display.
2933 (xg_set_widget_bg): New function.
2934 (delete_cb): New function.
2935 (xg_create_frame_widgets): Connect delete-event to delete_cb.
2936 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2937 (xg_set_background_color): Call xg_set_widget_bg.
2938 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2939 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2940 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2941 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2942 if ! HAVE_GTK3.
2943 (update_frame_tool_bar): Call gtk_widget_hide.
2944 (xg_initialize): Use GDK_KEY_g.
2945
2946 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2947 if ! HAVE_GTK3
2948 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2949
2950 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2951 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2952 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2953
2954 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2955
2956 * w32xfns.c (select_palette): Check success of RealizePalette against
2957 GDI_ERROR, not zero.
2958
2959 See ChangeLog.11 for earlier changes.
2960
2961 ;; Local Variables:
2962 ;; coding: utf-8
2963 ;; End:
2964
2965 Copyright (C) 2011 Free Software Foundation, Inc.
2966
2967 This file is part of GNU Emacs.
2968
2969 GNU Emacs is free software: you can redistribute it and/or modify
2970 it under the terms of the GNU General Public License as published by
2971 the Free Software Foundation, either version 3 of the License, or
2972 (at your option) any later version.
2973
2974 GNU Emacs is distributed in the hope that it will be useful,
2975 but WITHOUT ANY WARRANTY; without even the implied warranty of
2976 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2977 GNU General Public License for more details.
2978
2979 You should have received a copy of the GNU General Public License
2980 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.