Remove HAVE_LIBNCURSES; it is required to be true
[bpt/emacs.git] / src / ChangeLog
1 2012-05-01 Glenn Morris <rgm@gnu.org>
2
3 * dispnew.c: Remove HAVE_LIBNCURSES test;
4 it is always true on relevant platforms.
5
6 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
7 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
8
9 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
10
11 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
12
13 * .gdbinit (xpr): Remove checks for no longer existing misc types.
14 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
15 Remove.
16
17 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
18
19 Do not avoid creating empty evaporating overlays (Bug#9642).
20 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
21 That is, do not delete an evaporating overlay if it becomes
22 empty after its bounds are adjusted to fit within its buffer.
23 This fix caused other problems, and I'm reverting it until we get
24 to the bottom of them.
25
26 2012-04-27 Chong Yidong <cyd@gnu.org>
27
28 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
29
30 2012-04-27 Eli Zaretskii <eliz@gnu.org>
31
32 * xdisp.c (pos_visible_p): If the window start position is beyond
33 ZV, start the display from buffer beginning. Prevents assertion
34 violation in init_iterator when the minibuffer window is scrolled
35 via the scroll bar.
36
37 * window.c (window_scroll_pixel_based): Likewise.
38
39 2012-04-27 Chong Yidong <cyd@gnu.org>
40
41 * keymap.c (where_is_internal): Doc fix (Bug#10872).
42
43 2012-04-27 Glenn Morris <rgm@gnu.org>
44
45 * fileio.c (Fcopy_file, Fset_file_selinux_context):
46 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
47
48 2012-04-27 Eli Zaretskii <eliz@gnu.org>
49
50 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
51 overrun array limits of glyph row's used[] array. (Bug#11288)
52
53 2012-04-26 Eli Zaretskii <eliz@gnu.org>
54
55 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
56 display element, check also the underlying string or buffer
57 character. (Bug#11341)
58
59 * w32menu.c: Include w32heap.h.
60 (add_menu_item): If the call to AppendMenuW (via
61 unicode_append_menu) fails, disable Unicode menus only if we are
62 running on Windows 9X/Me.
63
64 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
65
66 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
67 (xgetint): Add missing shift for LSB tags.
68
69 2012-04-24 Martin Rudalics <rudalics@gmx.at>
70
71 * keyboard.c (read_char): Don't wipe echo area for select window
72 events: These might get delayed via `mouse-autoselect-window'
73 (Bug#11304).
74
75 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
76
77 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
78 manipulation of :loaded-from data.
79
80 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
81
82 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
83 now a cons (bug#11311).
84
85 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
86
87 Do not create empty overlays with the evaporate property (Bug#9642).
88 * buffer.c (Fmove_overlay): Delete an evaporating overlay
89 if it becomes empty after its bounds are adjusted to fit within
90 its buffer. Without this fix, in a nonempty buffer (let ((o
91 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
92 yields an empty overlay that has the evaporate property, which is
93 not supposed to happen.
94
95 Fix minor GTK3 problems found by static checking.
96 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
97 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
98 (struct _EmacsFixedClass, emacs_fixed_get_type):
99 Move decls here from emacsgtkfixed.h, since they needn't be public.
100 (emacs_fixed_get_type): Now static.
101 (emacs_fixed_class_init): Omit unused local.
102 (emacs_fixed_child_type): Remove; unused.
103 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
104 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
105 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
106 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
107 (EMACS_FIXED_GET_CLASS): Remove; unused.
108 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
109
110 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
111 Problem reported by Juanma Barranquero for Windows -Wunused-function.
112
113 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
114
115 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
116 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
117 (__malloc_size_t, __malloc_ptrdiff_t):
118 Remove. All uses removed, replaced by the definiens if needed,
119 since we can assume C89 or better now.
120 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
121 (protect_malloc_state, align, get_contiguous_space)
122 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
123 (malloc_atfork_handler_child, malloc_enable_thread)
124 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
125 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
126 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
127 (special_realloc, _realloc_internal_nolock, _realloc_internal)
128 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
129 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
130 Define using prototypes, not old style.
131 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
132 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
133 (align): Don't assume that signed integer overflow wraps around.
134 Omit unused local var.
135 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
136 (_free_internal_nolock, memalign, mallochook, reallochook):
137 Omit no-longer-needed casts.
138 (valloc): Use getpagesize, not __getpagesize.
139 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
140 (struct hdr): The 'magic' member is now size_t, not unsigned long.
141
142 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
143
144 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
145
146 Move functions from C to Lisp. Make non-blocking method calls
147 the default. Implement further D-Bus standard interfaces.
148
149 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
150 (QCdbus_request_name_allow_replacement)
151 (QCdbus_request_name_replace_existing)
152 (QCdbus_request_name_do_not_queue)
153 (QCdbus_request_name_reply_primary_owner)
154 (QCdbus_request_name_reply_in_queue)
155 (QCdbus_request_name_reply_exists)
156 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
157 (QCdbus_registered_serial, QCdbus_registered_method)
158 (QCdbus_registered_signal): New Lisp objects.
159 (XD_DEBUG_MESSAGE): Use sizeof.
160 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
161 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
162 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
163 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
164 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
165 (xd_signature, xd_append_arg): Allow float for integer types.
166 (xd_get_connection_references): New function.
167 (xd_get_connection_address): Rename from xd_initialize. Return
168 cached address.
169 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
170 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
171 level.
172 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
173 Return number of recounts.
174 (Fdbus_get_unique_name): Make stronger parameter check.
175 (Fdbus_message_internal): New defun.
176 (Fdbus_call_method, Fdbus_call_method_asynchronously)
177 (Fdbus_method_return_internal, Fdbus_method_error_internal)
178 (Fdbus_send_signal, Fdbus_register_service)
179 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
180 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
181 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
182 (Vdbus_compiled_version, Vdbus_runtime_version)
183 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
184 (Vdbus_message_type_method_return, Vdbus_message_type_error)
185 (Vdbus_message_type_signal): New defvars.
186 (Vdbus_registered_buses, Vdbus_registered_objects_table): Adapt
187 docstring.
188
189 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
190
191 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
192 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
193 Do not assume ptrdiff_t is the same width as 'int'.
194
195 * alloc.c: Handle unusual debugging option combinations.
196 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
197 since the two debugging options are incompatible.
198 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
199 is defined.
200 (mem_init, mem_insert, mem_insert_fixup):
201 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
202 (NEED_MEM_INSERT): Remove; no longer needed.
203
204 2012-04-22 Leo Liu <sdl.web@gmail.com>
205
206 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
207
208 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
209
210 * sysdep.c [__FreeBSD__]: Minor cleanups.
211 (list_system_processes, system_process_attributes) [__FreeBSD__]:
212 Use Emacs indenting style more consistently. Avoid some casts.
213 Use 'double' consistently rather than mixing 'float' and 'double'.
214
215 2012-04-21 Eduard Wiebe <usenet@pusto.de>
216
217 * sysdep.c (list_system_processes, system_process_attributes): Add
218 implementation for FreeBSD (Bug#5243).
219
220 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
221
222 * lisp.mk (lisp): Update.
223
224 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
225
226 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
227 It is never used otherwise.
228
229 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
230
231 * print.c (print_preprocess): Only check print_depth if print-circle
232 is nil.
233 (print_object): Check for cycles even when print-circle is nil and
234 print-gensym is t, but only check print_depth if print-circle is nil.
235
236 2012-04-20 Chong Yidong <cyd@gnu.org>
237
238 * process.c (wait_reading_process_output): If EIO occurs on a pty,
239 set the status to "failed" and ensure that sentinel is run.
240
241 2012-04-20 Glenn Morris <rgm@gnu.org>
242
243 * process.c (Fset_process_inherit_coding_system_flag)
244 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
245 (Fmake_network_process, Fmake_serial_process): Doc fix.
246
247 2012-04-20 Eli Zaretskii <eliz@gnu.org>
248
249 * xdisp.c (string_buffer_position_lim): Limit starting position to
250 BEGV.
251 (set_cursor_from_row): If called for a mode-line or header-line
252 row, return zero immediately.
253 (try_cursor_movement): If inside continuation line, don't back up
254 farther than the first row after the header line, if any.
255 Don't consider the header-line row as "partially visible", even if
256 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
257
258 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
259
260 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
261 (bug#11238).
262
263 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
264 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
265
266 configure: new option --enable-gcc-warnings (Bug#11207)
267 * Makefile.in (C_WARNINGS_SWITCH): Remove.
268 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
269 (ALL_CFLAGS): Use new macros rather than old.
270 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
271 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
272 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
273 -Wunused-result, -Wunused-variable. This should go away once
274 the Emacs and Gnulib regex code is merged.
275 (xmalloc, xrealloc): Now static.
276
277 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
278
279 * dired.c (Fsystem_groups): Remove unused local.
280
281 2012-04-17 Glenn Morris <rgm@gnu.org>
282
283 * dired.c (Fsystem_users): Doc fix.
284
285 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
286
287 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
288 (syms_of_dired): Add them.
289
290 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
291
292 Fix minor alloc.c problems found by static checking.
293 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
294 New extern decls, to avoid calling undeclared functions.
295 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
296 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
297 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
298 (NEED_MEM_INSERT): New macro.
299 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
300 Remove one incorrect comment and fix another.
301
302 Fix minor ralloc.c problems found by static checking.
303 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
304 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
305 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
306 (r_alloc_sbrk): Now static.
307
308 Improve ralloc.c interface checking.
309 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
310 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
311 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
312 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
313 [REL_ALLOC]: ... to here, to check interface.
314 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
315 Remove decls. This fixes an "It stinks!".
316
317 * alloc.c (which_symbols): Fix alignment issue / type clash.
318
319 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
320
321 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
322 (struct Lisp_Misc_Any): Likewise.
323 (struct Lisp_Free): Likewise.
324 * alloc.c (union aligned_Lisp_Symbol): Define.
325 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
326 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
327 (union aligned_Lisp_Misc): Define.
328 (MARKER_BLOCK_SIZE, struct marker_block): Use union
329 aligned_Lisp_Misc instead of union Lisp_Misc.
330 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
331
332 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
333
334 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
335 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
336 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
337 * s/netbsd.h, s/sol2-6.h:
338 Remove definition of GC_MARK_STACK, since the default now works.
339 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
340 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
341 no longer the default.
342 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
343
344 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
345
346 * lread.c (lisp_file_lexically_bound_p):
347 Fix hang at ";-*-\n" (bug#11238).
348
349 2012-04-14 Eli Zaretskii <eliz@gnu.org>
350
351 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
352 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
353
354 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
355
356 * nsterm.m (constrainFrameRect): Always constrain when there is only
357 one screen (Bug#10962).
358
359 2012-04-13 Ken Brown <kbrown@cornell.edu>
360
361 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
362
363 2012-04-13 Reuben Thomas <rrt@sc3d.org>
364
365 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
366
367 2012-04-11 Daniel Colascione <dancol@dancol.org>
368
369 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
370 against is gone. It's better to use vfork now so that when Cygwin
371 gains a new, working vfork, we use it automatically (bug#10398).
372
373 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
374
375 * window.c (save_window_save): Obey window-point-insertion-type.
376
377 2012-04-11 Glenn Morris <rgm@gnu.org>
378
379 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
380
381 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
382
383 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
384
385 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
386
387 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
388 (force_quit_count): New var.
389 (handle_interrupt): Use it.
390
391 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
392
393 * w32.c (w32_delayed_load): Record the full path of the library
394 being loaded (bug#10424).
395
396 2012-04-09 Glenn Morris <rgm@gnu.org>
397
398 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
399 not just in the obarray, before snarfing them. (Bug#11036)
400
401 * Makefile.in ($(leimdir)/leim-list.el):
402 Pass EMACS rather than BUILT_EMACS.
403
404 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
405
406 * process.c (make_process):
407 * process.h: Add integer `gnutls_handshakes_tried' member to
408 process struct.
409
410 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
411 Add convenience `GNUTLS_LOG2i' macro.
412
413 * gnutls.c (gnutls_log_function2i): Convenience log function.
414 (emacs_gnutls_read): Use new log functions,
415 `gnutls_handshakes_tried' process member, and
416 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
417 attempts per process (connection).
418
419 2012-04-09 Chong Yidong <cyd@gnu.org>
420
421 * eval.c (Fuser_variable_p, user_variable_p_eh)
422 (lisp_indirect_variable): Functions deleted.
423 (Fdefvar): Caller changed.
424
425 * callint.c (Finteractive, Fcall_interactively):
426 * minibuf.c (Fread_variable): Callers changed.
427
428 2012-04-09 Eli Zaretskii <eliz@gnu.org>
429
430 * xdisp.c (set_cursor_from_row): If the display string appears in
431 the buffer at position that is closer to point than the position
432 after the display string, display the cursor on the first glyph of
433 the display string. Fixes cursor display when a 'display' text
434 property immediately follows invisible text. (Bug#11094)
435
436 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
437
438 composite.c: use 'double' consistently
439 * composite.c (get_composition_id): Use 'double' consistently
440 instead of converting 'float' to 'double' and vice versa; this is
441 easier to understand and avoids a GCC warning.
442
443 2012-04-09 Glenn Morris <rgm@gnu.org>
444
445 * Makefile.in: Generate leim-list with bootstrap-emacs, in
446 preparation for dumping it with emacs. (Bug#4789)
447 (leimdir): New variable.
448 ($(leimdir)/leim-list.el): New rule.
449 (emacs$(EXEEXT)): Depend on leim-list.el.
450
451 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
452 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
453 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
454
455 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
456
457 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
458 proper alignment.
459
460 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
461
462 * xml.c (init_libxml2_functions) [WINDOWSNT]:
463 Remove unused local variable.
464
465 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
466
467 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
468 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
469 (mark_memory): Mark Lisp_Objects only if pointers might hide in
470 objects, as mark_maybe_pointer will catch them otherwise.
471 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
472 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
473
474 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
475
476 Fix typo that broke non-Windows builds.
477 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
478
479 2012-04-07 Eli Zaretskii <eliz@gnu.org>
480
481 Support building on MS-Windows with libxml2.
482
483 * makefile.w32-in (OBJ2): Add xml.$(O).
484 (GLOBAL_SOURCES): Add xml.c.
485 ($(BLD)/xml.$(O)): New dependency list.
486
487 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
488 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
489 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
490 [!WINDOWSNT]: New macros.
491 (init_libxml2_functions, libxml2_loaded_p): New functions.
492 (parse_region): Call fn_xmlCheckVersion instead of using the macro
493 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
494 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
495 Calls xmlCleanupParser only if libxml2 was loaded (or statically
496 linked in).
497 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
498 Call init_libxml2_functions before calling libxml2 functions.
499 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
500
501 * emacs.c: Don't include libxml/parser.h.
502 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
503 xmlCleanupParser directly.
504
505 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
506
507 2012-04-07 Eli Zaretskii <eliz@gnu.org>
508
509 * indent.c (Fvertical_motion): If there is a display string at
510 point, use it.vpos to compute how many lines to backtrack after
511 move_it_to point. (Bug#11133)
512
513 2012-04-06 Eli Zaretskii <eliz@gnu.org>
514
515 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
516 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
517 about subtle differences between FETCH_CHAR* and STRING_CHAR*
518 macros related to unification of CJK characters. For the details,
519 see the discussion following the message here:
520 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
521
522 2012-04-04 Chong Yidong <cyd@gnu.org>
523
524 * keyboard.c (Vdelayed_warnings_list): Doc fix.
525
526 2012-04-01 Eli Zaretskii <eliz@gnu.org>
527
528 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
529 instead of alloca. (Bug#11138)
530
531 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
532
533 * w32menu.c (is_simple_dialog): Properly check lisp types.
534 (Bug#11141)
535
536 2012-03-31 Eli Zaretskii <eliz@gnu.org>
537
538 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
539 position we get to after a call to move_it_to fails the
540 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
541 only if we wind up in a string from display property. (Bug#11063)
542
543 * window.c (Fdelete_other_windows_internal): Invalidate the row
544 and column information about mouse highlight, so that redisplay
545 restores it after reallocating the glyph matrices. (Bug#7464)
546
547 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
548 string comes from a `display' text property, use the buffer
549 position of that property as if we actually saw that position in
550 the row's glyphs.
551 (move_it_by_lines): Remove the assertion that
552 "it->current_x == 0 && it->hpos == 0" which can be legitimately
553 violated when there's a before-string at the beginning of a line.
554 (Bug#11063)
555
556 2012-03-30 Eli Zaretskii <eliz@gnu.org>
557
558 * xdisp.c (append_space_for_newline): If the default face was
559 remapped, use the remapped face for the appended newline.
560 (extend_face_to_end_of_line): Use the remapped default face for
561 extending the face to the end of the line.
562 (display_line): Call extend_face_to_end_of_line when the default
563 face was remapped. (Bug#11068)
564
565 2012-03-29 Eli Zaretskii <eliz@gnu.org>
566
567 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
568
569 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
570
571 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
572
573 2012-03-27 Glenn Morris <rgm@gnu.org>
574
575 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
576 Doc fixes.
577
578 2012-03-26 Kenichi Handa <handa@m17n.org>
579
580 * dispextern.h (struct glyph): Fix previous change. Change the
581 bit length of glyphless.ch to 25 (Bug#11082).
582
583 2012-03-26 Chong Yidong <cyd@gnu.org>
584
585 * keyboard.c (Vselection_inhibit_update_commands): New variable.
586 (command_loop_1): Use it; inhibit selection update for
587 handle-select-window too (Bug#8996).
588
589 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
590
591 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
592
593 2012-03-25 Kenichi Handa <handa@m17n.org>
594
595 * dispextern.h (struct glyph): Change the bit length of
596 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
597
598 2012-03-24 Eli Zaretskii <eliz@gnu.org>
599
600 * s/ms-w32.h (tzname): Include time.h before redirecting to
601 _tzname. Fixes the MSVC build. (Bug#9960)
602
603 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
604
605 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
606 characters.
607
608 * xterm.c (XTread_socket): Only modify handling_signal if
609 !SYNC_INPUT. (Bug#11080)
610
611 2012-03-23 Eli Zaretskii <eliz@gnu.org>
612
613 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
614 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
615 when fetching a multibyte character consumes more bytes than
616 CHAR_BYTES returns, due to unification of CJK characters in
617 string_char. (Bug#11073)
618
619 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
620
621 * process.c (wait_reading_process_output): Handle pty disconnect
622 by refraining from sending oneself a SIGCHLD (bug#10933).
623
624 2012-03-22 Chong Yidong <cyd@gnu.org>
625
626 * dispextern.h (struct it): New member string_from_prefix_prop_p.
627
628 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
629 Mark string as coming from a prefix property.
630 (handle_face_prop): Use default face for prefix strings (Bug#4281).
631 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
632
633 2012-03-21 Chong Yidong <cyd@gnu.org>
634
635 * xfaces.c (Vface_remapping_alist): Doc fix.
636
637 2012-03-20 Eli Zaretskii <eliz@gnu.org>
638
639 * w32proc.c (Fw32_set_console_codepage)
640 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
641 Doc fixes.
642
643 2012-03-20 Chong Yidong <cyd@gnu.org>
644
645 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
646 to reflect default non-nil value of redisplay-dont-pause.
647
648 2012-03-19 Kenichi Handa <handa@m17n.org>
649
650 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
651 it fit in a valid range (Bug#11003).
652
653 2012-03-18 Eli Zaretskii <eliz@gnu.org>
654
655 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
656 that is not from display property, accept the row as a "cursor
657 row" if one of the string's character has a non-nil `cursor'
658 property. Fixes cursor positioning when there are newlines in
659 overlay strings, e.g. in icomplete.el. (Bug#11035)
660
661 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
662
663 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
664
665 2012-03-12 Chong Yidong <cyd@gnu.org>
666
667 * eval.c (inhibit_lisp_code): Rename from
668 inhibit_window_configuration_change_hook; move from window.c.
669
670 * xfns.c (unwind_create_frame_1, Fx_create_frame):
671 * window.c (run_window_configuration_change_hook)
672 (syms_of_window): Callers changed.
673
674 2012-03-11 Chong Yidong <cyd@gnu.org>
675
676 * keymap.c (Fkey_description): Doc fix (Bug#9700).
677
678 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
679
680 2012-03-10 Chong Yidong <cyd@gnu.org>
681
682 * frame.c (other_visible_frames): Don't assume the selected frame
683 is visible (Bug#10955).
684
685 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
686
687 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
688
689 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
690
691 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
692 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
693 zero (Bug#10954).
694
695 2012-03-03 Glenn Morris <rgm@gnu.org>
696
697 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
698
699 2012-03-02 Eli Zaretskii <eliz@gnu.org>
700
701 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
702 position past the first glyph_row that ends at ZV. (Bug#10902)
703 (redisplay_window, next_element_from_string): Fix typos in
704 comments.
705 (redisplay_window): Pass to move_it_vertically the margin in
706 pixels, not in screen lines.
707
708 2012-03-02 Glenn Morris <rgm@gnu.org>
709
710 * buffer.c (buffer-list-update-hook): Doc fix.
711
712 2012-02-29 Eli Zaretskii <eliz@gnu.org>
713
714 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
715 push_it before setting up the iterator for the first overlay
716 string, even if we have an empty string loaded.
717 (next_overlay_string): If there's an empty string on the iterator
718 stack, pop the stack. (Bug#10903)
719
720 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
721
722 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
723 Suggested by Stefan Monnier in
724 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
725 * alloc.c (widen_to_Lisp_Object): New static function.
726 (mark_memory): Also mark Lisp_Objects by fetching pointer words
727 and widening them to Lisp_Objects. This would work even if
728 USE_LSB_TAG is defined and wide integers are used, which might
729 happen in a future version of Emacs.
730
731 2012-02-25 Chong Yidong <cyd@gnu.org>
732
733 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
734 Doc fix.
735
736 * xselect.c (Fx_selection_exists_p): Doc fix.
737 (x_clipboard_manager_save_all): Print an informative message
738 before saving to clipboard manager.
739
740 2012-02-24 Chong Yidong <cyd@gnu.org>
741
742 * keyboard.c (process_special_events): Handle all X selection
743 requests in kbd_buffer, not just the next one (Bug#8869).
744
745 2012-02-23 Chong Yidong <cyd@gnu.org>
746
747 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
748 call when setting menu-bar-lines and tool-bar-lines parameters.
749 (unwind_create_frame_1): New helper function.
750
751 * window.c (inhibit_window_configuration_change_hook): New var.
752 (run_window_configuration_change_hook): Obey it.
753 (syms_of_window): Initialize it.
754
755 2012-02-22 Chong Yidong <cyd@gnu.org>
756
757 * xterm.c (x_draw_image_relief): Add missing type check for
758 Vtool_bar_button_margin (Bug#10743).
759
760 2012-02-21 Chong Yidong <cyd@gnu.org>
761
762 * fileio.c (Vfile_name_handler_alist): Doc fix.
763
764 * buffer.c (Fget_file_buffer): Protect against invalid file
765 handler return value.
766
767 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
768
769 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
770 when computing $valmask.
771
772 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
773 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
774 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
775 It's useless in that case, and it can cause problems on hosts
776 that allocate halves of EMACS_INT values separately.
777 Reported by Dan Horák. Diagnosed by Andreas Schwab in
778 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
779 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
780 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
781 it avoids undefined behavior on hosts where shifting right by more
782 than the word width has undefined behavior.
783
784 2012-02-19 Chong Yidong <cyd@gnu.org>
785
786 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
787 (Funhandled_file_name_directory, Ffile_name_as_directory)
788 (Fdirectory_file_name, Fexpand_file_name)
789 (Fsubstitute_in_file_name): Protect against invalid file handler
790 return values (Bug#10845).
791
792 2012-02-18 Eli Zaretskii <eliz@gnu.org>
793
794 * .gdbinit (pitx): Fix incorrect references to fields of the
795 iterator stack.
796
797 2012-02-17 Chong Yidong <cyd@gnu.org>
798
799 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
800
801 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
802
803 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
804 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
805
806 2012-02-15 Chong Yidong <cyd@gnu.org>
807
808 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
809 marked as special. Also, starting docstrings with * is obsolete.
810
811 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
812
813 * gnutls.c (emacs_gnutls_write): Fix last change.
814
815 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
816
817 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
818 send_process.
819
820 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
821
822 * keymap.c (Fsingle_key_description): Handle char ranges.
823
824 2012-02-12 Chong Yidong <cyd@gnu.org>
825
826 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
827 as that creates a dangerous corner case.
828
829 * window.c (Fdelete_window_internal): Invalidate the mouse
830 highlight (Bug#9904).
831
832 2012-02-12 Glenn Morris <rgm@gnu.org>
833
834 * xselect.c (Fx_own_selection_internal)
835 (Fx_get_selection_internal, Fx_disown_selection_internal)
836 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
837 * nsselect.m (Fx_own_selection_internal)
838 (Fx_disown_selection_internal, Fx_selection_exists_p)
839 (Fx_selection_owner_p, Fx_get_selection_internal):
840 Sync docs and argument specs with the xselect.c versions.
841
842 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
843
844 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
845
846 2012-02-11 Eli Zaretskii <eliz@gnu.org>
847
848 * w32select.c (Fx_selection_exists_p): Sync doc string and
849 argument list with xselect.c. (Bug#10783)
850
851 * w16select.c (Fx_selection_exists_p): Sync doc string and
852 argument list with xselect.c. (Bug#10783)
853
854 2012-02-10 Glenn Morris <rgm@gnu.org>
855
856 * fns.c (Fsecure_hash): Doc fix.
857
858 2012-02-09 Kenichi Handa <handa@m17n.org>
859
860 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
861
862 2012-02-07 Chong Yidong <cyd@gnu.org>
863
864 * buffer.c (Fbuffer_local_variables)
865 (buffer_lisp_local_variables): Handle unbound vars correctly;
866 don't let Qunbound leak into Lisp.
867
868 2012-02-07 Glenn Morris <rgm@gnu.org>
869
870 * image.c (Fimagemagick_types): Doc fix.
871
872 * image.c (imagemagick-render-type): Change it from a lisp object
873 to an integer. Move the doc here from the lisp manual.
874 Treat all values not equal to 0 the same.
875
876 2012-02-06 Chong Yidong <cyd@gnu.org>
877
878 * doc.c (store_function_docstring): Avoid applying docstring of
879 alias to base function (Bug#2603).
880
881 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
882
883 * .gdbinit (pp1, pv1): Remove redundant defines.
884 (pr): Use pp.
885
886 2012-02-04 Chong Yidong <cyd@gnu.org>
887
888 * nsterm.m: Declare a global (Bug#10694).
889
890 2012-02-04 Eli Zaretskii <eliz@gnu.org>
891
892 * w32.c (get_emacs_configuration_options):
893 Include --enable-checking, if specified, in the return value.
894
895 2012-02-04 Martin Rudalics <rudalics@gmx.at>
896
897 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
898 after rounding frame sizes. (Bug#9723)
899
900 2012-02-04 Eli Zaretskii <eliz@gnu.org>
901
902 * keyboard.c (adjust_point_for_property): Don't position point
903 before BEGV. (Bug#10696)
904
905 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
906
907 Handle overflow when computing char display width (Bug#9496).
908 * character.c (char_width): Return EMACS_INT, not int.
909 (char_width, c_string_width): Check for overflow when
910 computing the width; this is possible now that individual
911 characters can have unbounded width. Problem introduced
912 by merge from Emacs 23 on 2012-01-19.
913
914 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
915
916 * dbusbind.c (Fdbus_register_method): Mention the return value
917 :ignore in the docstring.
918
919 2012-02-02 Glenn Morris <rgm@gnu.org>
920
921 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
922
923 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
924 Unconditionally set to t. (Bug#10673)
925 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
926 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
927 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
928
929 2012-02-02 Kenichi Handa <handa@m17n.org>
930
931 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
932 0, do not call append_composite_glyph.
933
934 2012-02-02 Kenichi Handa <handa@m17n.org>
935
936 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
937 NULL (Bug#6988).
938 (x_produce_glyphs): If the component of a composition is a null
939 string, set it->pixel_width to 1 to avoid zero-width glyph.
940
941 2012-02-01 Eli Zaretskii <eliz@gnu.org>
942
943 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
944 first 2 arguments are identical. This makes inserting large
945 output from a subprocess an order of magnitude faster on
946 MS-Windows, where all sbrk'ed memory is always contiguous.
947
948 2012-01-31 Glenn Morris <rgm@gnu.org>
949
950 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
951 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
952 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
953
954 2012-01-29 Glenn Morris <rgm@gnu.org>
955
956 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
957
958 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
959
960 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
961
962 2012-01-28 Chong Yidong <cyd@gnu.org>
963
964 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
965
966 2012-01-26 Chong Yidong <cyd@gnu.org>
967
968 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
969
970 * search.c (Fsearch_forward, Fsearch_backward): Document negative
971 repeat counts (Bug#10507).
972
973 2012-01-26 Glenn Morris <rgm@gnu.org>
974
975 * lread.c (syms_of_lread): Doc fix.
976
977 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
978
979 * coding.c (encode_designation_at_bol): Change return value to
980 EMACS_INT.
981
982 2012-01-25 Chong Yidong <cyd@gnu.org>
983
984 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
985
986 2012-01-21 Chong Yidong <cyd@gnu.org>
987
988 * floatfns.c (Fcopysign): Make the second argument non-optional,
989 since nil is not allowed anyway.
990
991 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
992
993 * process.c (read_process_output): Use p instead of XPROCESS (proc).
994 (send_process): Likewise.
995
996 2012-01-19 Martin Rudalics <rudalics@gmx.at>
997
998 * window.c (save_window_save, Fcurrent_window_configuration)
999 (Vwindow_persistent_parameters): Do not use Qstate.
1000 Rewrite doc-strings.
1001
1002 2012-01-19 Kenichi Handa <handa@m17n.org>
1003
1004 * character.c (char_width): New function.
1005 (Fchar_width, c_string_width, lisp_string_width):
1006 Use char_width (Bug#9496).
1007
1008 2012-01-16 Martin Rudalics <rudalics@gmx.at>
1009
1010 * window.c (Vwindow_persistent_parameters): New variable.
1011 (Fset_window_configuration, save_window_save): Handle persistent
1012 window parameters.
1013
1014 2012-01-14 Eli Zaretskii <eliz@gnu.org>
1015
1016 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1017 thrashing the stack of the thread. (Bug#9087)
1018
1019 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1020
1021 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1022
1023 2012-01-11 Eli Zaretskii <eliz@gnu.org>
1024
1025 * xdisp.c (rows_from_pos_range): Handle the case where the
1026 highlight ends on a newline. (Bug#10464)
1027 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1028 he end column for display of highlight that ends on a newline
1029 before a R2L line.
1030
1031 2012-01-11 Glenn Morris <rgm@gnu.org>
1032
1033 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1034 from load-path also when installation-directory is nil. (Bug#10208)
1035
1036 2012-01-10 Glenn Morris <rgm@gnu.org>
1037
1038 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1039
1040 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1041 Update template values to be closer to their typical values these days.
1042
1043 2012-01-09 Eli Zaretskii <eliz@gnu.org>
1044
1045 * xdisp.c (rows_from_pos_range): Accept additional argument
1046 DISP_STRING, and accept any glyph in a row whose object is that
1047 string as eligible for mouse highlight. Fixes mouse highlight of
1048 display strings from overlays. (Bug#10464)
1049
1050 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
1051
1052 emacs: fix an auto-save permissions race condition (Bug#10400)
1053 * fileio.c (auto_saving_dir_umask): New static var.
1054 (Fmake_directory_internal): Use it.
1055 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1056 creating the directory. The old code temporarily assigns
1057 too-generous permissions to the directory.
1058 (do_auto_save_eh): Clear it.
1059 (Fdo_auto_save): Catch all errors, not just file errors, so
1060 that the var is always cleared.
1061
1062 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1063
1064 * search.c (scan_buffer): Pass character positions to
1065 know_region_cache, not byte positions. (Bug#6540)
1066
1067 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1068
1069 * w32.c (sys_rename): Report EXDEV when rename of a directory
1070 fails because the target is on another logical disk. (Bug#10284)
1071
1072 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1073
1074 * xterm.c (x_embed_request_focus): New function.
1075
1076 * xterm.h: Add prototype.
1077
1078 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1079
1080 2012-01-05 Glenn Morris <rgm@gnu.org>
1081
1082 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1083
1084 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1085
1086 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1087 Load gnutls_transport_set_lowat only if GnuTLS version is below
1088 2.11.1.
1089 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1090 GnuTLS versions below 2.11.1.
1091
1092 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1093
1094 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1095 to the doc string advising against its use for altering the way
1096 windows are scrolled.
1097
1098 2011-12-28 Kenichi Handa <handa@m17n.org>
1099
1100 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1101 coding-system ASCII compatible only when it does not produce BOM
1102 on encoding (Bug#10383).
1103
1104 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1105
1106 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1107 can scroll.
1108 (create_and_show_popup_menu): Always use menu_position_func for
1109 Gtk3 (Bug#10361).
1110
1111 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1112
1113 * callint.c (Fcall_interactively): Don't truncate prompt string.
1114
1115 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1116
1117 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1118 property that ends at ZV, so that the bidi iteration could be
1119 resumed from there (after widening). (Bug#10360)
1120
1121 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1122
1123 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1124
1125 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1126
1127 * nsterm.m (x_free_frame_resources):
1128 Release f->output_data.ns->miniimage.
1129 (ns_index_color): Fix indentation. Do not retain
1130 color_table->colors[i].
1131
1132 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1133 before returning.
1134
1135 * nsfns.m (x_set_background_color): Assign return value from
1136 ns_index_color to face-background instead of NSColor*.
1137 (ns_implicitly_set_icon_type): Fix indentation.
1138 Change assignment in for loop to comparison.
1139
1140 * emacs.c (ns_pool): New variable.
1141 (main): Assign ns_pool.
1142 (Fkill_emacs): Call ns_release_autorelease_pool.
1143
1144 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1145 autorelease fdesc, release fdAttrs and tdict.
1146 (ns_get_covering_families): Release charset.
1147 (ns_findfonts): Release NSFontDescriptor created with new.
1148 (ns_uni_to_glyphs): Fix indentation.
1149 (setString): Release attrStr before assigning new value.
1150
1151 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1152
1153 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1154 and NS_IMPL_COCOA.
1155 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1156 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1157
1158 2011-12-18 David Reitter <reitter@cmu.edu>
1159
1160 * nsterm.m (ns_term_init): Subscribe for notifications
1161 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1162 to method trackingNotification in EmacsMenu.
1163
1164 * nsmenu.m (trackingMenu): New variable.
1165 (trackingNotification): New method (from Aquamacs).
1166 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1167 from Aquamacs (Bug#7030).
1168
1169 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1170
1171 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1172 (symbol_to_nsstring): Fix indentation.
1173 (ns_symbol_to_pb): New function.
1174 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1175 (Fns_rotate_cut_buffers_internal): Remove.
1176 (Fns_store_selection_internal): Rename from
1177 Fns_store_cut_buffer_internal.
1178 (ns_get_foreign_selection, Fx_own_selection_internal)
1179 (Fx_disown_selection_internal, Fx_selection_exists_p)
1180 (Fns_get_selection_internal, Fns_store_selection_internal):
1181 Use ns_symbol_to_pb and check if return value is nil.
1182 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1183 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1184 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1185 renamed to Sns_store_selection_internal.
1186 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1187 and remove this function.
1188 (ns_handle_selection_clear): Remove, never used.
1189 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1190 here.
1191
1192 2011-12-17 Ken Brown <kbrown@cornell.edu>
1193
1194 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1195 GID is unknown (Bug#10257).
1196
1197 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1198
1199 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1200 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1201 which caused a build failure on GNU/Linux IA-64. This problem was
1202 introduced by my 2011-10-07 patch.
1203
1204 2011-12-15 Juri Linkov <juri@jurta.org>
1205
1206 * image.c (imagemagick_error): New function. (Bug#10112)
1207 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1208 Use `imagemagick_error' where ImageMagick functions return
1209 `MagickFalse'.
1210 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1211 proper order.
1212
1213 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1214
1215 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1216 fill background (Bug#8992).
1217
1218 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1219
1220 * window.c (Vwindow_combination_resize)
1221 (Vwindow_combination_limit): Use t instead of non-nil in
1222 doc-strings.
1223 (Vrecenter_redisplay): Add first sentence of doc-string on
1224 separate line.
1225 (Frecenter): Fix doc-string typo.
1226
1227 2011-12-11 Kenichi Handa <handa@m17n.org>
1228
1229 * coding.c (Funencodable_char_position): Pay attention to the
1230 buffer text relocation (Bug#9389).
1231
1232 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1233
1234 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1235 gtk_init (Bug#10100).
1236
1237 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1238
1239 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1240 IT->string is nil. (Bug#10263)
1241
1242 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1243
1244 * nsterm.h (x_free_frame_resources): Declare.
1245
1246 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1247 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1248
1249 * nsterm.h (ns_get_defaults_value): Declare.
1250
1251 * nsterm.m (ns_default): Call ns_get_defaults_value.
1252
1253 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1254
1255 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1256 (Bug#10170)
1257
1258 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1259
1260 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1261 that where the value of an _OBJC_* symbol points to is in the .bss
1262 section (Bug#10240).
1263
1264 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1265
1266 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1267 after the loop to call ccl_driver at least once (Bug#8619).
1268
1269 2011-12-08 Kenichi Handa <handa@m17n.org>
1270
1271 * ftfont.c (get_adstyle_property): Fix previous change
1272 (Bug#10233).
1273
1274 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1275
1276 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1277 dirs from the default value of EMACSLOADPATH (bug#10208).
1278
1279 2011-12-07 Glenn Morris <rgm@gnu.org>
1280
1281 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1282 installation and source directories as well. (Bug#10208)
1283
1284 2011-12-06 Chong Yidong <cyd@gnu.org>
1285
1286 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1287
1288 2011-12-06 Glenn Morris <rgm@gnu.org>
1289
1290 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1291 as an error, not just -1. (Bug#10217)
1292
1293 2011-12-05 Chong Yidong <cyd@gnu.org>
1294
1295 * keyboard.c (process_special_events): New function.
1296 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1297
1298 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1299
1300 * coding.c (encode_designation_at_bol): Don't use uninitialized
1301 local variable (Bug#9318).
1302
1303 2011-12-05 Kenichi Handa <handa@m17n.org>
1304
1305 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1306 return Qnil (Bug#8046, Bug#10193).
1307
1308 2011-12-05 Kenichi Handa <handa@m17n.org>
1309
1310 * coding.c (encode_designation_at_bol): New args charbuf_end and
1311 dst. Return the number of produced bytes. Callers changed.
1312 (coding_set_source): Return how many bytes coding->source was
1313 relocated.
1314 (coding_set_destination): Return how many bytes
1315 coding->destination was relocated.
1316 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1317 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1318
1319 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1320
1321 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1322 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1323 macro (Bug#9318).
1324
1325 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1326
1327 The following changes are to fix Bug#9318.
1328
1329 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1330 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1331 (encode_coding_iso_2022, encode_coding_sjis)
1332 (encode_coding_big5, encode_coding_charset): Use the above macros.
1333
1334 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1335
1336 * lisp.h (process_quit_flag): Fix external declaration.
1337
1338 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1339
1340 Don't macro-inline non-performance-critical code.
1341 * eval.c (process_quit_flag): New function.
1342 * lisp.h (QUIT): Use it.
1343
1344 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1345
1346 * nsfns.m (get_geometry_from_preferences): New function.
1347 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1348
1349 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1350
1351 * emacs.c (Qkill_emacs): Define.
1352 (syms_of_emacs): Initialize it.
1353 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1354 Qquit_flag to `kill-emacs' instead.
1355 (quit_throw_to_read_char): Add parameter `from_signal'.
1356 All callers changed. Call Fkill_emacs if requested and safe.
1357 * lisp.h (QUIT): Call Fkill_emacs if requested.
1358
1359 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1360
1361 * widget.c (update_wm_hints): Return if wmshell is null.
1362 (widget_update_wm_size_hints): New function.
1363
1364 * widget.h (widget_update_wm_size_hints): Declare.
1365
1366 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1367 widget_update_wm_size_hints (Bug#10104).
1368
1369 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1370
1371 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1372 before a newline, prepare the bidi iterator for consuming the
1373 newline, and keep the current paragraph direction. (Bug#10183)
1374 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1375
1376 2011-12-02 Juri Linkov <juri@jurta.org>
1377
1378 * search.c (Fword_search_regexp): New Lisp function created from
1379 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1380 (Fword_search_backward, Fword_search_forward)
1381 (Fword_search_backward_lax, Fword_search_forward_lax):
1382 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1383 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1384
1385 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1386
1387 * fileio.c (Finsert_file_contents): Move after-change-function call
1388 to before the "handled:" label, since all "goto handled" appear in
1389 cases where the *-change-functions have already been properly called
1390 (bug#10117).
1391
1392 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1393
1394 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1395 waiting for input. (Bug#10169)
1396
1397 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1398
1399 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1400 verifies glyph row's hash code--we have just reallocated the
1401 glyphs, so their contents can be complete garbage. (Bug#10164)
1402
1403 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1404
1405 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1406
1407 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1408
1409 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1410 attributes are tested _before_ calling verify_row_hash, to protect
1411 against GCC re-ordering of the tests. (Bug#10164)
1412
1413 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1414
1415 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1416
1417 * xterm.c (handle_one_xevent): Only set async_visible and friends
1418 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1419 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1420 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1421
1422 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1423
1424 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1425 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1426 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1427 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1428 All uses changed to use GCPRO1 etc.
1429 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1430 Revert to old implementation (i.e., before 2011-03-11).
1431
1432 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1433
1434 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1435 of scroll runs so as to avoid assigning disabled bogus rows and
1436 unnecessary graphics copy operations.
1437
1438 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1439
1440 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1441 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1442 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1443 (malloc, free, realloc, calloc): Redirect to e_* only when
1444 compiling Emacs.
1445
1446 * lisp.h (GCTYPEBITS): Move before first use.
1447 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1448 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1449 this macro definition.
1450
1451 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1452 _MSC_VER.
1453
1454 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1455
1456 * gtkutil.c (xg_create_frame_widgets):
1457 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1458 present with Gtk+ 2.0.
1459
1460 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1461
1462 * fileio.c (Finsert_file_contents): Undo previous change; see
1463 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1464
1465 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1466
1467 Rename locals to avoid shadowing.
1468 * fileio.c (Finsert_file_contents):
1469 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1470 * process.c (wait_reading_process_output):
1471 Rename inner 'proc' to 'p' to avoid shadowing.
1472 Indent for consistency with usual Emacs style.
1473
1474 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1475
1476 * xdisp.c (redisplay_window): If cursor row is not fully visible
1477 after recentering, and scroll-conservatively is set to a large
1478 number, scroll window by a few more lines to make the cursor fully
1479 visible and out of scroll-margin. (Bug#10105)
1480 (start_display): Don't move to the next line if the display should
1481 start at a newline that is part of a display vector or an overlay
1482 string. (Bug#10119)
1483
1484 2011-11-24 Juri Linkov <juri@jurta.org>
1485
1486 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1487 after the `MagickPingImage' call. (Bug#10112)
1488
1489 2011-11-23 Chong Yidong <cyd@gnu.org>
1490
1491 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1492
1493 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1494
1495 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1496 making another buffer current. (Bug#10114)
1497
1498 2011-11-23 Glenn Morris <rgm@gnu.org>
1499
1500 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1501
1502 2011-11-23 Chong Yidong <cyd@gnu.org>
1503
1504 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1505 using it (Bug#5984).
1506
1507 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1508
1509 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1510 and header-lines, as they don't have one computed for them.
1511 (Bug#10098)
1512
1513 * .gdbinit (prow): Make displayed values more self-explaining.
1514 Add row's hash code.
1515
1516 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1517
1518 * process.c (wait_reading_process_output): Fix asynchrounous
1519 GnuTLS socket handling on some versions of the GnuTLS library.
1520 (wait_reading_process_output): Add comment and URL.
1521
1522 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1523
1524 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1525
1526 2011-11-21 Chong Yidong <cyd@gnu.org>
1527
1528 * window.c (Fnext_window, Fprevious_window): Doc fix.
1529
1530 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1531
1532 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1533
1534 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1535
1536 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1537
1538 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1539
1540 * window.c (Fset_window_combination_limit): Rename argument
1541 STATUS to LIMIT.
1542 (Vwindow_combination_limit): Remove "status" from doc-string.
1543
1544 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1545
1546 * m/ibms390.h: Remove.
1547 * m/ibms390x.h: Don't include "ibms390.h".
1548
1549 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1550
1551 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1552 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1553
1554 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1555
1556 * casetab.c (Fset_case_table):
1557 * charset.c (Fcharset_after): Fix typos.
1558
1559 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1560
1561 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1562 Otherwise, valgrind does not work on some platforms.
1563 Problem reported by Andreas Schwab in
1564 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1565 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1566 is set, removing the need for VIRT_ADDRESS_VARIES.
1567 (PURE_P): Use a more-efficient implementation that needs just one
1568 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1569 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1570 to 4 (xorl, subq, cmpq, setbe).
1571 * alloc.c (pure): Always extern now, since that's the
1572 VIRT_ADDR_VARIES behavior.
1573 (PURE_POINTER_P): Use a single comparison, not two, for
1574 consistency with the new puresize.h.
1575 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1576 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1577 Remove VIRT_ADDR_VARIES no longer needed.
1578
1579 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1580
1581 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1582 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1583 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1584 behave as if the cursor position were at the window margin.
1585
1586 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1587 and the cursor position is out of bounds, behave as if the cursor
1588 position were at the window margin. (Bug#10075)
1589
1590 2011-11-18 Chong Yidong <cyd@gnu.org>
1591
1592 * window.c (Fwindow_combination_limit): Make first argument
1593 non-optional, since it is meaningless for live windows like the
1594 selected window.
1595
1596 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1597
1598 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1599
1600 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1601
1602 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1603 (graft_intervals_into_buffer): Simplify.
1604
1605 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1606
1607 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1608 hash values of the two rows.
1609 (copy_row_except_pointers): Preserve the used[] arrays and the
1610 hash values of the two rows. (Bug#10035)
1611 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1612
1613 * xdisp.c (row_hash): New function, body extracted from
1614 compute_line_metrics.
1615 (compute_line_metrics): Call row_hash, instead of computing the
1616 hash code inline.
1617
1618 * dispnew.c (verify_row_hash): Call row_hash for computing the
1619 hash code of a row, instead of duplicating code from xdisp.c.
1620
1621 * dispextern.h (row_hash): Add prototype.
1622
1623 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1624
1625 * frame.c (delete_frame): Don't delete the terminal when the last
1626 X frame is closed if emacs is built with GTK toolkit.
1627
1628 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1629
1630 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1631
1632 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1633
1634 * window.c (Vwindow_splits): Rename to
1635 Vwindow_combination_resize. Suggested by Juri Linkov.
1636 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1637 of Vwindow_splits.
1638
1639 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1640
1641 * nsfns.m (Fns_font_name):
1642 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1643
1644 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1645
1646 * window.h (window): Rename slot "nest" to "combination_limit".
1647 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1648 (Fset_window_nest): Rename to Fset_window_combination_limit.
1649 (Vwindow_nest): Rename to Vwindow_combination_limit.
1650 (recombine_windows, make_parent_window, make_window)
1651 (Fsplit_window_internal, saved_window)
1652 (Fset_window_configuration, save_window_save): Rename all
1653 occurrences of window_nest to window_combination_limit.
1654
1655 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1656
1657 * image.c (imagemagick_load_image): Fix typo.
1658
1659 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1660
1661 * xdisp.c (display_line): Move the call to
1662 highlight_trailing_whitespace before the call to
1663 compute_line_metrics, since the latter needs to see the final
1664 faces of all the glyphs to compute ROW's hash value.
1665 Fixes assertion violations in row_equal_p. (Bug#10035)
1666
1667 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1668
1669 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1670 just return (bug#10044).
1671
1672 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1673
1674 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1675 with user-defined heap size. Bump the default size of the temacs
1676 heap to 27MB, to avoid memory warning when running temacs.
1677 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1678
1679 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1680 current_matrix and desired_matrix. (Bug#9990)
1681 (verify_row_hash) [XASSERTS]: New function.
1682 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1683 that the hash value of glyph rows is correct.
1684
1685 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1686
1687 * window.h (window): Remove splits slot.
1688 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1689 (Fdelete_other_windows_internal, make_parent_window)
1690 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1691 (Fset_window_configuration, save_window_save): Don't deal with
1692 split status of windows.
1693 (saved_window): Remove splits slot.
1694 (Vwindow_splits): Rewrite doc-string.
1695
1696 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1697
1698 * xfns.c (unwind_create_frame):
1699 * nsfns.m (unwind_create_frame):
1700 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1701 Vframe_list (Bug#9999).
1702
1703 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1704
1705 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1706
1707 2011-11-11 Kenichi Handa <handa@m17n.org>
1708
1709 * callproc.c (Fcall_process): Set the member dst_multibyte of
1710 process_coding.
1711
1712 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1713
1714 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1715 avoid a crash (bug#9496).
1716
1717 2011-11-09 Chong Yidong <cyd@gnu.org>
1718
1719 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1720 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1721
1722 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1723
1724 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1725
1726 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1727
1728 Avoid some portability problems by eschewing 'extern inline' functions.
1729 The trivial performance wins aren't worth the portability hassles; see
1730 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1731 et seq.
1732 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1733 (window_box_width, window_box_left, window_box_left_offset)
1734 (window_box_right, window_box_right_offset): Undo previous change,
1735 by removing the "extern"s.
1736 * intervals.c (adjust_intervals_for_insertion)
1737 (adjust_intervals_for_deletion): Undo previous change,
1738 making these static again.
1739 (offset_intervals, temp_set_point_both, temp_set_point)
1740 (copy_intervals_to_string): No longer inline.
1741 * xdisp.c (window_text_bottom_y, window_box_width)
1742 (window_box_height, window_box_left_offset)
1743 (window_box_right_offset, window_box_left, window_box_right)
1744 (window_box): No longer inline.
1745
1746 2011-11-08 Chong Yidong <cyd@gnu.org>
1747
1748 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1749 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1750 Signal an error if not a live window.
1751 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1752 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1753
1754 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1755
1756 * lisp.h (syms_of_abbrev): Remove declaration.
1757 Reported by CHENG Gao <chenggao@royau.me>.
1758
1759 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1760
1761 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1762 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1763 of temacs in GUI mode.
1764
1765 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1766
1767 * window.h: Declare delete_all_child_windows instead of
1768 delete_all_subwindows.
1769 * window.c (Fwindow_nest, Fset_window_nest)
1770 (Fset_window_new_total, Fset_window_new_normal)
1771 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1772 (delete_all_subwindows): Rename to delete_all_child_windows.
1773 (Fdelete_other_windows_internal, Fset_window_configuration):
1774 Call delete_all_child_windows instead of delete_all_subwindows.
1775 * frame.c (delete_frame): Call delete_all_child_windows instead
1776 of delete_all_subwindows.
1777
1778 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1779
1780 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1781 This is also needed for porting to any host where GC_MARK_STACK is
1782 not GC_MAKE_GCPROS_NOOPS.
1783 (which_symbols): Use it.
1784
1785 2011-11-07 Kenichi Handa <handa@m17n.org>
1786
1787 * coding.c (coding_set_destination): Check coding->src_pos only
1788 when coding->src_object is a buffer (bug#9910).
1789
1790 * process.c (send_process): Set the member src_multibyte of coding
1791 to 0 (bug#9911) when sending a unibyte text.
1792
1793 * callproc.c (Fcall_process): Set the member src_multibyte of
1794 process_coding to 0 (bug#9912).
1795
1796 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1797
1798 * xmenu.c (cleanup_widget_value_tree): New function.
1799 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1800 calling free_menubar_widget_value_tree directly (Bug#9830).
1801
1802 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1803
1804 Fix some portability problems with 'inline'.
1805 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1806 (window_box_width, window_box_left, window_box_left_offset)
1807 (window_box_right, window_box_right_offset): Declare extern.
1808 Otherwise, these inline functions do not conform to C99 and
1809 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1810 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1811 * intervals.c (adjust_intervals_for_insertion)
1812 (adjust_intervals_for_deletion): Now extern, because otherwise the
1813 extern inline functions 'offset_intervals' couldn't refer to it.
1814 (static_offset_intervals): Remove.
1815 (offset_intervals): Rewrite using the old contents of
1816 static_offset_intervals. The old version didn't conform to C99
1817 because an extern inline function contained a reference to an
1818 identifier with static linkage.
1819
1820 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1821
1822 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1823 GC.
1824
1825 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1826
1827 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1828 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1829 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1830 return Qleft_to_right.
1831
1832 2011-11-06 Chong Yidong <cyd@gnu.org>
1833
1834 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1835 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1836 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1837 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1838 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1839 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1840 (Fwindow_vscroll): Doc fix.
1841 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1842 argument, since it makes no sense to pass a live window and for
1843 consistency with window-child.
1844
1845 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1846
1847 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1848 support MSVC.
1849
1850 2011-11-05 Jason Rumney <jasonr@gnu.org>
1851
1852 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1853 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1854 fonts (Bug#6029).
1855 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1856 bitwise arithmetic preventing use of unicode-sip and non-truetype
1857 opentype fonts.
1858
1859 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1860
1861 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1862 "emacs"-only part.
1863
1864 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1865 initialization code to keep similarity to xfns.c after changes
1866 from 2011-11-05.
1867
1868 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1869
1870 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1871 (unwind_create_frame): New function (Bug#9943).
1872 (Fx_create_frame): Restructure code to be more similar to the one in
1873 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1874 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1875 Move terminal->reference_count++ just before making the frame official
1876 (Bug#9943).
1877
1878 * nsterm.m (x_free_frame_resources): New function.
1879 (x_destroy_window): Move code to x_free_frame_resources.
1880
1881 * xfns.c (unwind_create_frame): Fix comment.
1882 (Fx_create_frame, x_create_tip_frame):
1883 Move terminal->reference_count++ just before making the frame
1884 official. Move initialization of image_cache_refcount and
1885 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1886
1887 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1888
1889 Support MSVC build with newer versions of Visual Studio.
1890 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1891 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1892 nt/gmake.defs.
1893
1894 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1895 which are not supported by MSVC.
1896 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1897 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1898 bitfields.
1899 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1900 types in bitfields.
1901 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1902
1903 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1904
1905 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1906
1907 Support MSVC build with newer versions of Visual Studio.
1908 * w32.c: Don't include w32api.h for MSVC.
1909 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1910
1911 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1912 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1913 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1914 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1915 e_* cousins.
1916 (alloca) [_MSC_VER]: Define to _alloca.
1917
1918 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1919
1920 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1921
1922 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1923
1924 * xdisp.c (note_mouse_highlight): If either of
1925 previous/next-single-property-change returns nil, treat that as
1926 the beginning or the end of the buffer. (Bug#9955)
1927
1928 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1929
1930 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1931 label is not null (Bug#9951).
1932 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1933 may be NULL.
1934
1935 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1936
1937 * window.c (Fwindow_body_size): Mention in the doc string that the
1938 return value is in frame's canonical units. (Bug#9949)
1939
1940 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1941
1942 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1943
1944 * w32fns.c (unwind_create_frame): If needed, free the glyph
1945 matrices of the partially constructed frame. (Bug#9943)
1946 * xfns.c (unwind_create_frame): Likewise.
1947
1948 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1949
1950 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1951 Don't stop backward scan on the continuation glyph, even though
1952 its CHARPOS is positive.
1953 (mouse_face_from_buffer_pos, note_mouse_highlight):
1954 Rename cover_string to disp_string.
1955
1956 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1957
1958 * window.c (temp_output_buffer_show): Don't use
1959 Vtemp_buffer_show_specifiers.
1960 (Vtemp_buffer_show_specifiers): Remove unused variable.
1961
1962 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1963
1964 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1965 past the beginning of the current glyph matrix.
1966
1967 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1968
1969 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1970 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1971 HAVE_GTK3 (Bug#9869).
1972
1973 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1974 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1975
1976 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1977
1978 * xterm.c: Declare x_handle_net_wm_state to return int.
1979 (handle_one_xevent): Check if we are iconified but don't have
1980 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1981 (get_current_wm_state): Return non-zero if not hidden,
1982 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1983 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1984 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1985 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1986
1987 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1988
1989 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1990 so that this new function doesn't get optimized away by a
1991 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1992
1993 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1994
1995 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1996
1997 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1998
1999 Fix the `xbytecode' command.
2000 * .gdbinit (xprintbytestr): New command.
2001 (xwhichsymbols): Rename from `which'; all callers changed.
2002 (xbytecode): Print the byte-code string as well.
2003
2004 2011-10-29 Kim Storm <storm@cua.dk>
2005
2006 * alloc.c (which_symbols): New function.
2007
2008 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2009
2010 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2011 line. (Bug#9903)
2012
2013 2011-10-29 Glenn Morris <rgm@gnu.org>
2014
2015 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2016 Not clear what it was for, and it causes various bugs. (Bug#9839)
2017
2018 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2019
2020 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2021 possible random value that matches one of those tested as
2022 condition to clear the mouse face.
2023
2024 2011-10-28 Chong Yidong <cyd@gnu.org>
2025
2026 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2027
2028 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2029
2030 * window.c (make_window): Initialize phys_cursor_on_p.
2031
2032 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2033
2034 * lisp.h (struct Lisp_Symbol): Update comments.
2035
2036 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
2037
2038 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2039
2040 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2041
2042 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2043 <oslsachem@gmail.com> for helping to debug this.
2044
2045 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2046 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2047 (g_b_init_get_glyph_outline_w): New static variables.
2048 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2049 (GetGlyphOutlineW_Proc): New typedefs.
2050 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
2051 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2052 New functions.
2053 (w32font_open_internal, compute_metrics):
2054 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2055 instead of calling the "wide" APIs directly.
2056
2057 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2058
2059 * w32.h (syms_of_w32font): Add prototype.
2060
2061 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2062
2063 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2064 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2065 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2066 (Fmove_to_window_line): Doc fix.
2067
2068 2011-10-27 Chong Yidong <cyd@gnu.org>
2069
2070 * process.c (make_process): Set gnutls_state to NULL.
2071
2072 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2073 non-NULL, regardless of GNUTLS_INITSTAGE.
2074 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2075 an error. Set process slots as soon as we allocate them.
2076
2077 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2078
2079 2011-10-27 Chong Yidong <cyd@gnu.org>
2080
2081 * gnutls.c (emacs_gnutls_deinit): New function.
2082 Deallocate credentials structures as well as calling gnutls_deinit.
2083 (Fgnutls_deinit, Fgnutls_boot): Use it.
2084
2085 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2086 (deactivate_process): Call emacs_gnutls_deinit.
2087
2088 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2089
2090 * image.c (x_create_x_image_and_pixmap):
2091 * w32.c (sys_rename, w32_delayed_load):
2092 * w32font.c (fill_in_logfont):
2093 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2094
2095 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2096
2097 * w32fns.c (w32_default_color_map): New function,
2098 extracted from Fw32_default_color_map.
2099 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2100
2101 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2102
2103 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2104
2105 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2106
2107 * keyboard.c (test_undefined): New function (bug#9751).
2108 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2109
2110 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2111
2112 * sysdep.c (init_sys_modes): Fix the check for the controlling
2113 terminal (Bug#6649).
2114
2115 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2116
2117 * dispextern.h (struct bidi_it): New member next_en_type.
2118
2119 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2120 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2121 current character, check also for next_en_type being WEAK_EN.
2122 (bidi_resolve_weak): Don't enter the expensive loop if the current
2123 position is before next_en_pos. Record the bidi type of the first
2124 non-ET, non-BN character we find, in addition to its position.
2125 (bidi_level_of_next_char): Invalidate next_en_type when
2126 next_en_pos is over-stepped.
2127
2128 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2129
2130 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2131 * editfns.c: Rewrite current-time-zone so that it invokes
2132 the equivalent of (format-time-string "%Z") to get the time zone name.
2133 This fixes a bug when the time zone name contains characters that
2134 need converting from the system time locale to Emacs internal format.
2135 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2136 that patch fixed format-time-string to do the conversion, but
2137 I forgot to fix current-time-zone.
2138 (format_time_string): New function, containing most of
2139 what Fformat_time_string used to contain.
2140 (Fformat_time_string): Rewrite in terms of format_time_string.
2141 This doesn't change this function's behavior.
2142 (current-time-zone): Rewrite to use format_time_string.
2143 This fixes the bug reported by Michael Schierl in
2144 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2145 Jason Rumney's 2007-06-07 change worked around this bug, but
2146 didn't fix it.
2147 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2148
2149 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2150
2151 * xdisp.c (start_display): If the character at POS is displayed
2152 via a display vector, reset IT->current.dpvec_index to zero.
2153 (try_window_reusing_current_matrix): If a line ends in a display
2154 vector or the next line starts in a display vector, continue
2155 redrawing the window even though the character position of
2156 start_row was reached.
2157 (Bug#9771, part 2)
2158
2159 2011-10-18 Chong Yidong <cyd@gnu.org>
2160
2161 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2162 with nobreak-char-display too.
2163
2164 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2165
2166 Fix part 3 of bug#9771.
2167 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2168 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2169 non-neutral characters if the current character is a paragraph
2170 separator (a.k.a. Newline). This avoids running the same
2171 expensive loop twice, once when we consume the preceding newline
2172 and the other time when the line actually needs to be displayed.
2173 Avoid the loop when we see neutrals on the base embedding level
2174 following a character whose directionality is the same as the
2175 paragraph's. This avoids running the expensive loop when a line
2176 ends in a long sequence of neutrals, like control characters.
2177 Add assertion against STRONG_AL type. Slightly rearrange code
2178 that determines the type of a neutral given the first non-neutral
2179 that follows it.
2180 (bidi_level_of_next_char): Set next_en_pos to zero when
2181 invalidating its info.
2182
2183 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2184
2185 * xdisp.c (push_display_prop): Determine whether to record string
2186 or buffer position by IT->string, not by IT->method. Allow
2187 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2188 (move_it_vertically_backward): Don't look for character position
2189 immediately after the newline when in a continuation line.
2190 (Bug#9771, part 1)
2191
2192 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2193
2194 * window.c (coordinates_in_window): Rewrite and delabelize
2195 vertical border check. (Bug#5357) (Bug#9618)
2196
2197 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2198
2199 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2200 errors in XSetWindowBorder (bug#9310).
2201
2202 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2203
2204 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2205 avoid crash when xmalloc overrun checking is enabled.
2206
2207 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2208
2209 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2210 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2211 cursor motion with <left> and <right> arrow keys.
2212
2213 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2214 some callers set that themselves.
2215
2216 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2217
2218 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2219 display string and the previous row comes from the same string and
2220 is empty. (Bug#9739) (Bug#9738)
2221
2222 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2223
2224 * doc.c (get_doc_string): Encode file name (bug#9735).
2225
2226 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2227
2228 * bidi.c (bidi_level_of_next_char):
2229 * xdisp.c (get_visually_first_element): Remove old incorrect
2230 comments regarding the Unicode Line Separator character.
2231
2232 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2233
2234 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2235
2236 * alloc.c (Fgc_status): Do not access beyond zombies array
2237 boundary if nzombies > MAX_ZOMBIES.
2238 * alloc.c (dump_zombies): Add missing format specifier.
2239
2240 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2241
2242 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2243 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2244
2245 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2246 Some packages use them to denote characters with modifiers.
2247
2248 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2249
2250 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2251 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2252 matching a pp-number. Rename parameter var to var1.
2253
2254 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2255
2256 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2257
2258 2011-10-08 Glenn Morris <rgm@gnu.org>
2259
2260 * callint.c (Fcall_interactively): Give a more explicit error for the
2261 'c' case with a non-character input. (Bug#8479)
2262
2263 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2264
2265 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2266 lines.
2267 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2268 lines that are hscrolled on the left.
2269
2270 * dispnew.c (buffer_posn_from_coords): Account for a possible
2271 presence of header-line. (Bug#4426)
2272
2273 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2274
2275 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2276 Don't advertise functionality which we discourage or doesn't work.
2277
2278 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2279
2280 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2281 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2282 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2283 this makes Emacs dump core during garbage collection on rare
2284 occasions. sizeof is obviously inferior to offsetof here, so
2285 stick with offsetof.
2286 (GC_POINTER_ALIGNMENT): New macro.
2287 (mark_memory): Omit 3rd (offset) arg; caller changed.
2288 Don't assume EMACS_INT alignment is the same as pointer alignment.
2289
2290 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2291
2292 * keyboard.c (read_key_sequence_remapped): New var.
2293 (read_key_sequence): Compute remapping in the right buffer.
2294 (command_loop_1): Use read_key_sequence's remapping directly.
2295
2296 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2297
2298 * dired.c (file_name_completion): Don't expand file name.
2299 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2300 before checking file name handler.
2301
2302 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2303 they've been requested explicitly (bug#9591).
2304
2305 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2306
2307 * keymap.c (Fsingle_key_description): Use make_specified_string
2308 instead of build_string to build string from push_key_description.
2309 (Bug#5193)
2310
2311 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2312
2313 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2314 This fixes a Y2038 bug on 64-bit hosts.
2315 * buffer.c (reset_buffer):
2316 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2317 (Fclear_buffer_auto_save_failure):
2318 Use 0, not -1, to represent an unset failure time, since time_t
2319 might not be signed.
2320
2321 Remove dependency on glibc malloc internals.
2322 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2323 Move back here from lisp.h, but with their new implementations.
2324 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2325 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2326 * charset.c (charset_table_init): New static var.
2327 (syms_of_charset): Use it instead of xmalloc. This removes a
2328 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2329 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2330 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2331 Move back to alloc.c.
2332 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2333 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2334
2335 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2336
2337 * nsterm.m (windowDidResize): Call x_set_window_size only when
2338 ns_in_resize is true. Otherwise set pixelwidth/height and
2339 call change_frame_size (Bug#9628).
2340
2341 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2342
2343 Port --enable-checking=all to Fedora 14 x86-64.
2344 * charset.c (syms_of_charset): Also account for glibc malloc's
2345 internal overhead when calculating the initial malloc maximum.
2346
2347 Port --enable-checking=all to Fedora 14 x86.
2348 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2349 Move to lisp.h.
2350 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2351 (overrun_check_realloc, overrun_check_free):
2352 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2353 That way, xmalloc returns a properly-aligned pointer even if
2354 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2355 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2356 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2357 into account when calculating the initial malloc maximum.
2358 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2359 Move here from alloc.c, so that charset.c can use it too.
2360 Properly align; the old code wasn't right for common 32-bit hosts
2361 when configured with --enable-checking=all.
2362 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2363 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2364
2365 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2366
2367 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2368 use EDOM.
2369
2370 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2371
2372 * xdisp.c (compute_display_string_end): If there's no display
2373 string at CHARPOS, return -1.
2374
2375 * bidi.c (bidi_fetch_char): When compute_display_string_end
2376 returns a negative value, treat the character as a normal
2377 character not covered by a display string. (Bug#9624)
2378
2379 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2380
2381 * lread.c (Fread_from_string): Fix typo in docstring.
2382
2383 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2384
2385 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2386 newline, reseat the iterator instead of bidi-iterating there one
2387 character at a time. (Bug#9610)
2388 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2389 TO_CHARPOS if the bidi iterator is at base embedding level.
2390
2391 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2392
2393 * lread.c (readevalloop): Use correct code for NBSP.
2394 (read1): Likewise. (Bug#9608)
2395
2396 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2397
2398 * dbusbind.c (Fdbus_register_signal): When service is not
2399 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2400
2401 2011-09-25 Glenn Morris <rgm@gnu.org>
2402
2403 * buffer.c (truncate-lines): Doc fix.
2404
2405 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2406
2407 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2408 (Fset_window_next_buffers): Doc fix.
2409
2410 2011-09-24 Glenn Morris <rgm@gnu.org>
2411
2412 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2413
2414 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2415
2416 Fix minor problems found by static checking.
2417 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2418 * indent.c (Fvertical_motion): Fix == vs = typo.
2419
2420 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2421
2422 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2423 Default value is now t. Doc fix.
2424
2425 * indent.c (Fvertical_motion): Compute and apply the overshoot
2426 logic when moving up, not only when moving down. Fix the
2427 confusing name and values of the it_overshoot_expected variable;
2428 logic changes accordingly. (Bug#9254) (Bug#9549)
2429
2430 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2431 CHARPOS is covered by a display string which includes newlines.
2432 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2433 is covered by a display string with embedded newlines.
2434
2435 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2436
2437 * dbusbind.c (Fdbus_register_signal): Add match rule to
2438 Vdbus_registered_objects_table. (Bug#9581)
2439 (Fdbus_register_method, Vdbus_registered_objects_table):
2440 Fix docstring.
2441
2442 2011-09-24 Jim Meyering <meyering@redhat.com>
2443
2444 do not ignore write error for any output size
2445 The previous change was incomplete.
2446 While it makes emacs --batch detect the vast majority of stdout
2447 write failures, errors were still ignored whenever the output size is
2448 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2449 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2450 && echo FAIL: ignored write error
2451 FAIL: ignored write error
2452 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2453 && echo FAIL: ignored write error
2454 FAIL: ignored write error
2455 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2456
2457 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2458
2459 * emacs.c (Fkill_emacs): In noninteractive mode exit
2460 non-successfully if a write error occurred on stdout. (Bug#9574)
2461
2462 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2463
2464 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2465 the xassert test.
2466
2467 * dispextern.h (struct it): Update the comment documenting what
2468 can it->OBJECT be.
2469
2470 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2471
2472 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2473 a display string, extend search for cursor position to end of row.
2474 (find_row_edges): If the row ends in a newline from a display
2475 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2476 Handle the case of a display string with multiple newlines.
2477 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2478 non-empty line. Fixes confusing cursor motion with arrow keys at
2479 the beginning of a line that starts with whitespace.
2480
2481 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2482
2483 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2484 (bug#9493).
2485
2486 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2487
2488 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2489 boolean (Bug#9154).
2490
2491 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2492
2493 * xdisp.c (display_line): Record maximum and minimum buffer
2494 positions even if no glyphs were produced (e.g., by a zero-width
2495 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2496 buffer positions that will be removed from the glyph row because
2497 they don't fit.
2498 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2499 column is beyond frame width: don't subtract 1 "pixel" when
2500 computing width of the stretch.
2501 (reseat_at_next_visible_line_start): Undo the change made on
2502 2011-09-17 that saved paragraph information and restored it after
2503 the call to `reseat'. (Bug#9545)
2504
2505 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2506
2507 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2508 and turn window cursor on if cleared (Bug#9415).
2509
2510 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2511
2512 * search.c (boyer_moore): Take unibyte characters from pattern
2513 literally. (Bug#9458)
2514
2515 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2516
2517 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2518
2519 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2520
2521 Fix minor problem found by static checking.
2522 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2523 initialized, to pacify gcc -Wuninitialized.
2524
2525 * fileio.c: Report proper errno when syscall falls.
2526 (Finsert_file_contents): Save and restore errno,
2527 so that report_file_error outputs the correct diagnostic.
2528 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2529
2530 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2531
2532 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2533
2534 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2535
2536 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2537 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2538
2539 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2540
2541 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2542 about the current paragraph and restore it after the call to reseat.
2543
2544 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2545 (bidi_find_paragraph_start): Search back for paragraph beginning
2546 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2547 (bidi_move_to_visually_next): Only trigger paragraph-related
2548 computations when the last character is a newline or at EOB, not
2549 just any NEUTRAL_B. (Bug#9470)
2550
2551 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2552 truncated lines if point is covered by a display string. (Bug#9524)
2553
2554 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2555
2556 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2557 (cons_to_x_long): New function.
2558 (lisp_data_to_selection_data): Use it. Correct the test for
2559 short-versus-long data; it was negated. Break out of vector
2560 loop, for efficiency, when a long datum is discovered.
2561
2562 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2563
2564 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2565
2566 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2567
2568 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2569 GCC PR/17406) by declaring this function with external scope.
2570
2571 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2572
2573 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2574 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2575
2576 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2577
2578 * editfns.c (Fformat): Correctly handle text properties on "%%".
2579
2580 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2581
2582 * xterm.c (x_draw_composite_glyph_string_foreground):
2583 * w32term.c (x_draw_composite_glyph_string_foreground):
2584 * term.c (encode_terminal_code):
2585 * composite.c (composition_update_it, get_composition_id):
2586 * xdisp.c (get_next_display_element)
2587 (fill_composite_glyph_string): Add comments about special meaning
2588 of TAB characters in a composition.
2589
2590 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2591
2592 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2593 This occurs when processing a multibyte format.
2594 Problem reported by Wolfgang Jenker.
2595
2596 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2597
2598 * xdisp.c (try_cursor_movement): Only check for exact match if
2599 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2600
2601 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2602
2603 Remove unused external symbols.
2604 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2605 * xdisp.c (calc_pixel_width_or_height): Now static.
2606 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2607 * indent.c (check_display_width):
2608 * w32term.c: Fix comment to match code.
2609 * xterm.c, xterm.h (x_catching_errors): Remove.
2610
2611 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2612
2613 * xselect.c: Use signed conversions more consistently (Bug#9498).
2614 (selection_data_to_lisp_data): Assume incoming selection data are
2615 signed integers, not unsigned. This is to be consistent with
2616 outgoing selection data, which was modified to use signed integers
2617 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2618 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2619 expects long, not unsigned long.
2620
2621 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2622
2623 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2624 computation of loop end. Reported by Johan Bockgård
2625 <bojohan@gnu.org>.
2626
2627 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2628
2629 * frame.c (Fother_visible_frames_p): Function deleted.
2630
2631 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2632
2633 * indent.c (compute_motion): Process display vector front to back
2634 rather than the other way around. (Bug#2496)
2635
2636 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2637
2638 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2639
2640 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2641
2642 * minibuf.c (Fread_from_minibuffer): Doc fix.
2643
2644 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2645
2646 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2647 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2648
2649 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2650
2651 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2652 value for non-existent files.
2653
2654 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2655
2656 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2657 set its "size" to -1. This will set the modtime_size field of
2658 the corresponding buffer to -1, which is what
2659 verify-visited-file-modtime expects for files that do not exist.
2660 (Bug#9139)
2661
2662 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2663
2664 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2665 here ...
2666 * lisp.h: ... from here. push_key_description is no longer
2667 defined in keyboard.c, so its declaration should not be in
2668 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2669 logically belongs with push_key_description.
2670
2671 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2672
2673 * buffer.h: Include <sys/types.h> instead of <time.h>.
2674 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2675 Problem reported by Herbert J. Skuhra.
2676
2677 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2678
2679 * xml.c (parse_region): Make the parsing work for
2680 non-comment-starting XML files again (bug#9144).
2681
2682 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2683
2684 * image.c (gif_load): Fix calculation of bottom and right corner.
2685 (Bug#9468)
2686
2687 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2688
2689 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2690 redisplay in small windows.
2691
2692 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2693
2694 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2695
2696 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2697
2698 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2699 Operate on live windows only.
2700
2701 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2702
2703 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2704
2705 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2706
2707 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2708 only under bidi iteration.
2709
2710 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2711
2712 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2713
2714 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2715
2716 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2717 Without this fix, the command to link temacs failed due to an
2718 undefined symbol __builtin_isnan. This is because
2719 /usr/include/iso/math_c99.h #defines isnan(x) to
2720 __builtin_isnan(x), but the bundled gcc, which identifies itself
2721 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2722 a __builtin_isnan.
2723 * floatfns.c (isnan): #undef, and then #define to a clone of
2724 what's in data.c.
2725 (Fisnan): Always define, since it's always available now.
2726 (syms_of_floatfns): Always define isnan at the Lisp level.
2727
2728 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2729
2730 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2731
2732 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2733
2734 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2735 The previous code assumed that file offsets (off_t values) fit in
2736 EMACS_INT variables, which is not true on typical 32-bit hosts.
2737 The code messed up by falsely reporting buffer overflow in cases
2738 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2739 when "big" contains more than 2**29 bytes, even though this
2740 inserts just one byte and does not overflow the buffer.
2741 (Finsert_file_contents): Store file offsets as off_t
2742 values, not as EMACS_INT values. Check for overflow when
2743 converting between EMACS_INT and off_t. When checking for
2744 buffer overflow or for overlap, take the offsets into account.
2745 Don't use EMACS_INT for small values where int suffices.
2746 When checking for overlap, fix a typo: ZV was used where
2747 ZV_BYTE was intended.
2748 (Fwrite_region): Don't assume off_t fits into 'long'.
2749 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2750
2751 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2752
2753 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2754
2755 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2756
2757 sprintf-related integer and memory overflow issues (Bug#9412).
2758
2759 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2760 (esprintf, exprintf, evxprintf): New functions.
2761 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2762 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2763 (modify_event_symbol): Do not assume that the length of
2764 name_alist_or_stem is safe to alloca and fits in int.
2765 (Fexecute_extended_command): Likewise for function name and binding.
2766 (Frecursion_depth): Wrap around reliably on integer overflow.
2767 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2768 since some callers pass EMACS_INT values.
2769 (Fsingle_key_description): Don't crash if symbol name contains more
2770 than MAX_ALLOCA bytes.
2771 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2772 (get_minibuffer): Arg is now EMACS_INT, not int.
2773 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2774 (esprintf, exprintf, evxprintf): New decls.
2775 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2776
2777 * dbusbind.c (signature_cat): New function.
2778 (xd_signature, Fdbus_register_signal):
2779 Do not overrun buffer; instead, report string overflow.
2780
2781 * dispnew.c (add_window_display_history): Don't overrun buffer.
2782 Truncate instead; this is OK since it's just a log.
2783
2784 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2785 even if the time zone offset is outlandishly large.
2786 Don't mishandle offset == INT_MIN.
2787
2788 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2789 when creating daemon; the previous buffer-overflow check was incorrect.
2790
2791 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2792 which has the guts of the old verror function.
2793
2794 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2795 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2796
2797 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2798 (font_unparse_xlfd): Don't blindly alloca long strings.
2799 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2800 fits in int, when using sprintf. Use single snprintf to count
2801 length of string rather than counting it via multiple sprintfs;
2802 that's simpler and more reliable.
2803 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2804 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2805 sprintf, in case result does not fit in int.
2806
2807 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2808 (fontset_from_font): Print it.
2809
2810 * frame.c (tty_frame_count): Now printmax_t, not int.
2811 (make_terminal_frame, set_term_frame_name): Print it.
2812 (x_report_frame_params): In X, window IDs are unsigned long,
2813 not signed long, so print them as unsigned.
2814 (validate_x_resource_name): Check for implausibly long names,
2815 and don't assume name length fits in 'int'.
2816 (x_get_resource_string): Don't blindly alloca invocation name;
2817 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2818 not fit in int.
2819
2820 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2821 (xg_check_special_colors, xg_set_geometry):
2822 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2823
2824 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2825 Use esprintf, not sprintf, in case result does not fit in int.
2826
2827 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2828 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2829 it as a large positive number.
2830 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2831 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2832
2833 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2834 in case result does not fit in int.
2835
2836 * print.c (float_to_string): Detect width overflow more reliably.
2837 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2838 buffer overrun. Don't assume list length fits in 'int'. Treat
2839 print length of 0 as 0, not as infinity; to be consistent with other
2840 uses of print length in this function. Don't overflow print length
2841 index. Don't assume hash table size fits in 'long', or that
2842 vectorlike size fits in 'unsigned long'.
2843
2844 * process.c (make_process): Use printmax_t, not int, to format
2845 process-name gensyms.
2846
2847 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2848
2849 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2850 to avoid potential buffer overrun.
2851
2852 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2853 if X resource line is longer than 512 bytes.
2854
2855 * xfns.c (x_window): Make sprintf buffer a bit bigger
2856 to avoid potential buffer overrun.
2857
2858 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2859
2860 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2861
2862 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2863
2864 Integer overflow fixes for scrolling, etc.
2865 Without these, Emacs silently mishandles large integers sometimes.
2866 For example, "C-u 4294967297 M-x recenter" was treated as if
2867 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2868
2869 * xdisp.c (try_window_id): Check Emacs fixnum range before
2870 converting to 'int'.
2871
2872 * window.c (window_scroll_line_based, Frecenter):
2873 Check that an Emacs fixnum is in range before assigning it to 'int'.
2874 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2875 values converted from Emacs fixnums.
2876 (Frecenter): Don't wrap around a line count if it is out of 'int'
2877 range; instead, treat it as an extreme value.
2878 (Fset_window_configuration, compare_window_configurations):
2879 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2880
2881 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2882 that can exceed INT_MAX. Check that EMACS_INT value is in range
2883 before assigning it to the (possibly-narrower) index.
2884 (match_limit): Don't assume that a fixnum can fit in 'int'.
2885
2886 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2887 exceed INT_MAX.
2888
2889 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2890 (Fvertical_motion): Don't wrap around LINES values that don't fit
2891 in 'int'. Instead, treat them as extreme values. This is good
2892 enough for windows, which can't have more than INT_MAX lines anyway.
2893
2894 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2895
2896 * Require libxml/parser.h to avoid compilation warning.
2897
2898 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2899
2900 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2901 since this reportedly can destroy thread storage.
2902
2903 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2904
2905 * syntax.c (find_defun_start): Update all cache variables if
2906 exiting early (Bug#9401).
2907
2908 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2909
2910 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2911
2912 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2913 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2914 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2915
2916 * term.c (tty_append_glyph): New function.
2917 (produce_stretch_glyph): Static function and its prototype deleted.
2918
2919 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2920 Add prototypes.
2921
2922 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2923
2924 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2925 when checking :margin (Bug#9390).
2926 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2927 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2928 so that the name doesn't mislead. All uses changed.
2929
2930 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2931
2932 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2933 set_tty_hooks.
2934
2935 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2936
2937 * xdisp.c (move_it_to): Don't bail out early when reaching
2938 position beyond to_charpos, if we are scanning backwards.
2939 (move_it_vertically_backward): When DY == 0, make sure we get to
2940 the first character in the line after the newline.
2941
2942 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2943
2944 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2945 (ccl_driver): Do not generate an out-of-range pointer.
2946 (Fccl_execute_on_string): Remove unnecessary check for
2947 integer overflow, noted by Stefan Monnier in
2948 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2949 Remove a FIXME that didn't need fixing.
2950 Simplify the newly-introduced buffer reallocation code.
2951
2952 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2953
2954 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2955
2956 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2957
2958 Integer and memory overflow issues (Bug#9196).
2959
2960 * doc.c (get_doc_string): Rework so that
2961 get_doc_string_buffer_size is the actual buffer size, rather than
2962 being 1 less than the actual buffer size; this makes xpalloc more
2963 convenient.
2964
2965 * image.c (x_allocate_bitmap_record, cache_image):
2966 * xselect.c (Fx_register_dnd_atom):
2967 Simplify previous changes by using xpalloc.
2968
2969 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2970 since either will do and ptrdiff_t is convenient with xpalloc.
2971
2972 * charset.c (charset_table_size)
2973 (struct charset_sort_data.priority): Now ptrdiff_t.
2974 (charset_compare): Don't overflow if priorities differ greatly.
2975 (Fsort_charsets): Don't assume list length fits in int.
2976 Check for size-calculation overflow when allocating sort data.
2977 (syms_of_charset): Allocate an initial charset table that is
2978 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2979
2980 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2981
2982 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2983 The actual value is always <= INT_MAX, and leaving it unsigned made
2984 overflow checking harder.
2985
2986 * dispextern.h (struct glyph_matrix.rows_allocated)
2987 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2988 with xpalloc. The values are still always <= INT_MAX.
2989
2990 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2991
2992 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2993 (SAFE_NALLOCA): New macro.
2994
2995 * region-cache.c (struct boundary.pos, find_cache_boundary)
2996 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2997 (set_cache_region, invalidate_region_cache)
2998 (revalidate_region_cache, know_region_cache, region_cache_forward)
2999 (region_cache_backward, pp_cache):
3000 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3001 so that ptrdiff_t * can be passed to xpalloc.
3002 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3003 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3004 (pp_cache): Don't assume cache_len fits in int.
3005 * region-cache.h: Adjust extern decls to match.
3006
3007 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3008 EMACS_INT, since either will do, for xpalloc.
3009
3010 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3011 (xnmalloc, xnrealloc, xpalloc): New functions.
3012
3013 * bidi.c (bidi_shelve_header_size): New constant.
3014 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3015 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3016
3017 * bidi.c (bidi_cache_shrink):
3018 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3019 (overlay_strings):
3020 Don't update size of array until after memory allocation succeeds,
3021 because xmalloc/xrealloc may not return.
3022 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3023 now that we have proper integer overflow checking.
3024 (record_overlay_string, overlay_strings): Catch overflows when
3025 calculating size of overlay_str_buf.
3026
3027 * callproc.c (Fcall_process): Check for size overflow when
3028 calculating size of args2.
3029 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3030 Normally we prefer signed values, but sticking with ptrdiff_t would
3031 require adding more-complicated checks.
3032
3033 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3034 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3035 Redo buffer-overflow calculations to avoid integer overflow.
3036 Add a FIXME comment where memory seems to be over-allocated.
3037
3038 * character.c (Fstring): Check for size-calculation overflow.
3039
3040 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3041 unnecessary integer overflow. Check for size overflow.
3042 (encode_coding_object): Don't update size until xmalloc succeeds.
3043
3044 * composite.c (get_composition_id): Check for overflow in glyph
3045 length calculations.
3046
3047 Integer and memory overflow fixes for display code.
3048 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3049 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3050 (scrolling_window): Check for overflow in size calculations.
3051 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3052 Don't assume glyph table len fits in int.
3053 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3054 (row_table_size): Now ptrdiff_t, not int.
3055 (scrolling_window): Avoid overflow in size calculations.
3056 Don't update size until allocation succeeds.
3057 * fns.c (concat): Check for overflow in size calculations.
3058 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3059 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3060 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3061
3062 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3063 (get_doc_string): Check for size calculation overflow.
3064 Don't update size until allocation succeeds.
3065 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3066 EMACS_INT, where ptrdiff_t will do.
3067 (Fsubstitute_command_keys): Check for string overflow.
3068
3069 * editfns.c (set_time_zone_rule): Don't assume environment length
3070 fits in int.
3071 (message_length): Now ptrdiff_t, not int.
3072 (Fmessage_box): Don't update size until allocation succeeds.
3073 Don't assume message length fits in int.
3074 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3075
3076 * emacs.c (main): Do not reallocate argv, since there is a null at
3077 the end that can be overwritten, and this way there's no need to
3078 worry about size-calculation overflow.
3079 (sort_args): Check for size-calculation overflow.
3080
3081 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3082 alloc succeeds.
3083 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3084
3085 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3086 (x_set_scroll_bar_width, x_figure_window_size):
3087 Check for integer overflow.
3088 (x_set_alpha): Do not assume XINT fits in int.
3089
3090 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3091 This is for the members text_lines, text_cols, total_lines, total_cols,
3092 where the system imposes an 'int' limit.
3093
3094 * fringe.c (Fdefine_fringe_bitmap):
3095 Don't update size until alloc works.
3096
3097 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3098 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3099
3100 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3101 Check for size-calculation overflow.
3102 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3103 do, as we prefer signed integers.
3104 (id_to_widget.max_size, id_to_widget.used)
3105 (xg_store_widget_in_map, xg_remove_widget_from_map)
3106 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3107 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3108 Use and return ptrdiff_t, not int.
3109 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3110 * gtkutil.h: Change prototypes to match the above.
3111
3112 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3113 are duplicate now that they've been promoted to lisp.h.
3114 (x_allocate_bitmap_record, x_alloc_image_color)
3115 (make_image_cache, cache_image, xpm_load):
3116 Don't update size until alloc is done.
3117 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3118 (x_detect_edges):
3119 Check for size calculation overflow.
3120 (ct_colors_allocated_max): New constant.
3121 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3122 overflow.
3123
3124 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3125 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3126 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3127 Use ptrdiff_t, not int, to count maps.
3128 (read_char_minibuf_menu_prompt): Check for overflow in size
3129 calculations. Don't update size until allocation succeeds.
3130 Redo calculations to avoid overflow.
3131 * keyboard.h: Change prototypes to match the above.
3132
3133 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3134 to count maps.
3135 (current_minor_maps): Check for size calculation overflow.
3136 * keymap.h: Change prototypes to match the above.
3137
3138 * lread.c (read1, init_obarray): Don't update size until alloc done.
3139
3140 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3141 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3142
3143 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3144 Now ptrdiff_t, not int.
3145 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3146 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3147
3148 * process.c (Fnetwork_interface_list): Check for overflow
3149 in size calculation.
3150
3151 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3152
3153 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3154 overflow. Don't bother calling xmalloc when xrealloc will do.
3155
3156 * search.c (Freplace_match): Check for size calculation overflow.
3157 (Fset_match_data): Don't assume list lengths fit in 'int'.
3158
3159 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3160 for command line length. Do not attempt to address one before the
3161 beginning of an array, as that's not portable.
3162
3163 * term.c (max_frame_lines): Remove; unused.
3164 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3165 not int.
3166 (encode_terminal_code, calculate_costs): Check for size
3167 calculation overflow.
3168 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3169 table lengths and related sizes. Don't update size until alloc
3170 done. Redo calculations to avoid overflow.
3171 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3172
3173 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3174 subtracting pointers.
3175 (gobble_line): Check for overflow more carefully. Don't update size
3176 until alloc done.
3177
3178 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3179 Don't update size until alloc done.
3180 Redo size calculations to avoid overflow.
3181 Check for size calculation overflow.
3182 (main) [DEBUG]: Fix typo in invoking tparam1.
3183
3184 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3185 Use ptrdiff_t, not int, for sizes.
3186 (store_mode_line_noprop_char): Don't update size until alloc done.
3187
3188 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3189 Use ptrdiff_t, not int, for sizes.
3190 (Finternal_make_lisp_face, cache_face):
3191 Check for size calculation overflow.
3192 (cache_face): Treat size calculation overflows as if they were
3193 memory exhaustion (the usual treatment), rather than aborting.
3194
3195 * xfns.c (x_encode_text, x_set_name_internal)
3196 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3197 sizes, since they can exceed INT_MAX in size. Check for size
3198 calculation overflow.
3199
3200 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3201 (xg_select): Check for size calculation overflow.
3202 Don't update size until alloc done.
3203
3204 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3205 as sprintf is limited to int lengths.
3206
3207 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3208 (X_LONG_MIN): New macros.
3209 Use them to make the following changes clearer.
3210 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3211 This change doesn't affect the value now, but it may help remind
3212 future maintainers not to raise the value too much later.
3213 (SELECTION_QUANTUM): Remove, replacing with ...
3214 (selection_quantum): ... new function, which avoids overflow.
3215 All uses changed.
3216 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3217 assumption that selection length fits in 'int'.
3218 (x_reply_selection_request, x_handle_selection_request)
3219 (x_get_window_property, receive_incremental_selection)
3220 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3221 (lisp_data_to_selection_data, clean_local_selection_data):
3222 Use ptrdiff_t, not int, to record length of selection.
3223 (x_reply_selection_request, x_get_window_property)
3224 (receive_incremental_selection, x_property_data_to_lisp):
3225 Redo calculations to avoid overflow.
3226 (x_reply_selection_request): When sending hint, ceiling it at
3227 X_LONG_MAX rather than relying on wraparound overflow to send
3228 something.
3229 (x_get_window_property, receive_incremental_selection)
3230 (lisp_data_to_selection_data, x_property_data_to_lisp):
3231 Check for size-calculation overflow.
3232 (x_get_window_property, receive_incremental_selection)
3233 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3234 Don't store size until memory allocation succeeds.
3235 (x_get_window_property): Plug memory leak on memory exhaustion.
3236 Don't double-block input; malloc is safe here. Don't assume 2**34
3237 - 4 fits in unsigned long. Add an xassert to check
3238 XGetWindowProperty overflow. Be more careful about overflow
3239 calculations, and distinguish size from memory overflow better.
3240 (receive_incremental_selection): When tracing, don't assume
3241 unsigned int is less than INT_MAX.
3242 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3243 harmful) conversions of unsigned short to int.
3244 (lisp_data_to_selection_data): Don't assume that integers
3245 in the range -65535 through -1 fit in an X unsigned short.
3246 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3247 result parameters unless successful. Rely on cons_to_unsigned
3248 to report problems with elements; the old code wasn't right anyway.
3249 (x_check_property_data): Check for int overflow; we cannot use
3250 a wider type due to X limits.
3251 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3252
3253 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3254
3255 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3256 (x_term_init): Check for size calculation overflow.
3257 (x_color_cells): Don't store size until memory allocation succeeds.
3258 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3259 Don't assume alloca size is less than MAX_ALLOCA.
3260 (x_term_init): Don't assume length fits in int (sprintf is limited
3261 to int size).
3262
3263 Use ptrdiff_t for composition IDs.
3264 * character.c (lisp_string_width):
3265 * composite.c (composition_table_size, n_compositions)
3266 (get_composition_id, composition_gstring_from_id):
3267 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3268 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3269 * window.c (Frecenter):
3270 Use ptrdiff_t, not int, for composition IDs.
3271 * composite.c (get_composition_id): Check for integer overflow.
3272 * composite.h: Adjust prototypes to match the above changes.
3273
3274 Use ptrdiff_t for hash table indexes.
3275 * category.c (hash_get_category_set):
3276 * ccl.c (ccl_driver):
3277 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3278 * coding.c (coding_system_charset_list, detect_coding_system):
3279 * coding.h (struct coding_system.id):
3280 * composite.c (get_composition_id, gstring_lookup_cache):
3281 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3282 * image.c (xpm_get_color_table_h):
3283 * lisp.h (hash_lookup, hash_put):
3284 * minibuf.c (Ftest_completion):
3285 Use ptrdiff_t for hash table indexes, not int (which is too
3286 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3287 32-bit --with-wide-int hosts).
3288
3289 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3290 Add a FIXME comment about memory leaks.
3291 (syms_of_charset): Don't assume xmalloc returns.
3292
3293 Don't assume that stated character widths fit in int.
3294 * character.c (Fchar_width, c_string_width, lisp_string_width):
3295 * character.h (CHAR_WIDTH):
3296 * indent.c (MULTIBYTE_BYTES_WIDTH):
3297 Use sanitize_char_width to avoid undefined and/or bad behavior
3298 with outlandish widths.
3299 * character.h (sanitize_tab_width): Rename from sanitize_width,
3300 now that we have two such functions. All uses changed.
3301 (sanitize_char_width): New inline function.
3302
3303 Don't assume that tab-width fits in int.
3304 * character.h (sanitize_width): New inline function.
3305 (SANE_TAB_WIDTH): New macro.
3306 (ASCII_CHAR_WIDTH): Use it.
3307 * indent.c (sane_tab_width): Remove. All uses replaced by
3308 SANE_TAB_WIDTH (current_buffer).
3309 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3310
3311 * fileio.c: Integer overflow issues with file modes.
3312 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3313
3314 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3315 Remove unreachable code.
3316 (read_hex, load_charset_map_from_file): Check for integer overflow.
3317
3318 * xterm.c: Don't go over XClientMessageEvent limit.
3319 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3320 (x_send_scroll_bar_event): Likewise. Check that the size does not
3321 exceed limits imposed by XClientMessageEvent, as well as the usual
3322 ptrdiff_t and size_t limits.
3323
3324 * keyboard.c: Overflow, signedness and related fixes.
3325 (make_lispy_movement): Use same integer type in forward decl
3326 that is used in the definition.
3327 (read_key_sequence, keyremap_step):
3328 Change bufsize argument back to int, undoing my 2011-03-30 change.
3329 We prefer signed types, and int is wide enough here.
3330 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3331 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3332 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3333 length, not size_t. Use ptrdiff_t for index, not int.
3334 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3335 possibility of integer overflow.
3336
3337 Overflow, signedness and related fixes for images.
3338
3339 * dispextern.h (struct it.stack[0].u.image.image_id)
3340 (struct_it.image_id, struct image.id, struct image_cache.size)
3341 (struct image_cache.used, struct image_cache.ref_count):
3342 * gtkutil.c (update_frame_tool_bar):
3343 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3344 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3345 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3346 * nsmenu.m (update_frame_tool_bar):
3347 * xdisp.c (calc_pixel_width_or_height):
3348 * xfns.c (image_cache_refcount):
3349 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3350 on typical 64-bit hosts.
3351
3352 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3353 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3354 Omit unnecessary casts to int.
3355 (parse_image_spec): Check that integers fall into 'int' range
3356 when the callers expect that.
3357 (image_ascent): Redo ascent calculation to avoid int overflow.
3358 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3359 (lookup_image): Remove unnecessary tests.
3360 (xbm_image_p): Locals are now of int, not EMACS_INT,
3361 since parse_image_check makes sure they fit into int.
3362 (png_load, gif_load, svg_load_image):
3363 Prefer int to unsigned where either will do.
3364 (tiff_handler): New function, combining the cores of the
3365 old tiff_error_handler and tiff_warning_handler.
3366 This function is rewritten to use vsnprintf and thereby avoid
3367 stack buffer overflows. It uses only the features of vsnprintf
3368 that are common to both POSIX and native Microsoft.
3369 (tiff_error_handler, tiff_warning_handler): Use it.
3370 (tiff_load, gif_load, imagemagick_load_image):
3371 Don't assume :index value fits in 'int'.
3372 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3373 (imagemagick_load_image): Check that crop parameters fit into
3374 the integer types that MagickCropImage accepts. Don't assume
3375 Vimagemagick_render_type has a nonnegative value. Don't assume
3376 size_t fits in 'long'.
3377 (gs_load): Use printmax_t to print the widest integers possible.
3378 Check for integer overflow when computing image height and width.
3379
3380 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3381
3382 * xdisp.c (redisplay_window): Don't force window start if point
3383 will be invisible in the resulting window. (Bug#9324)
3384
3385 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3386
3387 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3388 the display spec is of the form `(space ...)'.
3389 (handle_display_spec): Return the value returned by
3390 handle_single_display_spec, not just 1 or zero.
3391 (handle_single_display_spec): If the display spec is of the form
3392 `(space ...)', and specifies display in the text area, return 2
3393 rather than 1.
3394 (try_cursor_movement): Check for the need to scroll more
3395 accurately, and prefer exact match for point under bidi.
3396 Don't advance `row' beyond the last row of the window.
3397
3398 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3399 into disp_prop; all users changed.
3400
3401 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3402 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3403 for the text covered by the display property.
3404
3405 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3406
3407 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3408 Change return value to nil.
3409 (Frecord_buffer): Delete unused function.
3410
3411 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3412
3413 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3414 buffers, return left-to-right.
3415 (set_cursor_from_row): Consider candidate row a win if its glyph
3416 represents a newline and point is on that newline. Fixes cursor
3417 positioning on the newline at EOL of R2L text within L2R
3418 paragraph, and vice versa.
3419 (try_cursor_movement): Check continued rows, in addition to
3420 continuation rows. Fixes unwarranted scroll when point enters a
3421 continued line of R2L text within an L2R paragraph, or vice versa.
3422 (cursor_row_p): Consider the case of point being equal to
3423 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3424 from the end of a short line to the beginning of a continued line
3425 of R2L text within L2R paragraph.
3426 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3427 composed characters.
3428
3429 * bidi.c (bidi_check_type): Use xassert.
3430 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3431 members.
3432
3433 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3434
3435 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3436 a character.
3437
3438 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3439
3440 * nsfont.m (ns_otf_to_script): Fix typo.
3441
3442 2011-08-22 Kenichi Handa <handa@m17n.org>
3443
3444 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3445 extra slot even if the purpose is char-code-property-table.
3446
3447 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3448
3449 * xdisp.c (redisplay_window): When computing centering_position,
3450 account for the height of the header line. (Bug#8874)
3451
3452 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3453 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3454 candidate is selected by the mouse, and that candidate has a
3455 composed character under the mouse.
3456
3457 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3458 coordinates reported by pos-visible-in-window-p for a composed
3459 character in column zero.
3460
3461 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3462
3463 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3464
3465 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3466
3467 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3468 consider it a hit if to_charpos is anywhere in the range of the
3469 composed buffer positions.
3470
3471 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3472
3473 * image.c (gif_load): Don't assume that each subimage has the same
3474 dimensions as the base image. Handle disposal method that is
3475 "undefined" by the gif spec (Bug#9335).
3476
3477 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3478
3479 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3480 (Fcondition_case): Document `debug' symbol in error handler.
3481
3482 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3483
3484 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3485 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3486 from an Org mode buffer to a Speedbar frame.
3487
3488 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3489 a composition, take its buffer position from IT->cmp_it.charpos.
3490 Fixes cursor positioning at the beginning of a line that begins
3491 with a composed character.
3492
3493 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3494
3495 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3496 character bidirectional type, use STRONG_L instead. Fixes crashes
3497 in a buffer produced by `describe-categories'.
3498
3499 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3500 members before the level stack, so they would be saved and
3501 restored when copying iterator state. Fixes incorrect reordering
3502 around TABs covered by display properties.
3503
3504 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3505
3506 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3507
3508 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3509
3510 * eval.c (internal_condition_case, internal_condition_case_1)
3511 (internal_condition_case_2, internal_condition_case_n):
3512 Remove unnecessary aborts (Bug#9081).
3513
3514 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3515
3516 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3517 has no `load' handler, try opening the file locally. (Bug#9311)
3518
3519 2011-08-16 Ken Brown <kbrown@cornell.edu>
3520
3521 * gmalloc.c: Expand comment.
3522
3523 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3524
3525 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3526 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3527
3528 2011-08-16 Ken Brown <kbrown@cornell.edu>
3529
3530 Fix memory allocation problems in Cygwin build (Bug#9273).
3531
3532 * unexcw.c ( __malloc_initialized): Declare external variable.
3533 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3534
3535 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3536 New variables.
3537 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3538 dumped emacs.
3539 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3540 in the static heap.
3541 [CYGWIN] (special_realloc): New function.
3542 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3543 requests to realloc storage in the static heap.
3544
3545 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3546
3547 * bidi.c (bidi_initialize): Remove unused local.
3548
3549 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3550
3551 * bidimirror.h:
3552 * biditype.h: Remove file.
3553 * makefile.w32-in ($(BLD)/bidi.$(O)):
3554 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3555
3556 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3557
3558 * chartab.c: Improve commentary for the uniprop_table API.
3559
3560 * bidi.c (bidi_paragraph_init): Support zero value of
3561 bidi_ignore_explicit_marks_for_paragraph_level.
3562 (bidi_initialize): Use uniprop_table instead of including
3563 biditype.h and bidimirror.h.
3564
3565 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3566 coordinates of the iterator when restoring from ppos_it.
3567 (Bug#9296)
3568
3569 2011-08-14 Kenichi Handa <handa@m17n.org>
3570
3571 * process.c (create_process): Call setup_process_coding_systems
3572 after the pid of the process is set to -1 (Bug#8162).
3573
3574 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3575
3576 * xdisp.c (move_it_in_display_line_to): Don't invoke
3577 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3578 ppos_it. Fixes vertical cursor motion when line beginning is
3579 covered by an image. (Bug#9296)
3580
3581 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3582
3583 * nsterm.h (ns_run_ascript): Declare.
3584 (NSAPP_DATA2_RUNASSCRIPT): Define.
3585
3586 * nsfns.m (as_script, as_result, as_status): New static variables.
3587 (ns_run_ascript): New function.
3588 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3589 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3590 the event loop. Get status from as_status (Bug#7276).
3591
3592 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3593 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3594 the event loop (Bug#7276).
3595
3596 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3597
3598 * gnutls.c (QCgnutls_bootprop_priority)
3599 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3600 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3601 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3602 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3603 (QCgnutls_bootprop_verify_hostname_error)
3604 (QCgnutls_bootprop_callbacks_verify): Rename from
3605 Qgnutls_bootprop_..., all uses changed.
3606
3607 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3608 uses changed.
3609
3610 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3611
3612 * xfaces.c (Qframe_set_background_mode): Now static.
3613 * dispextern.h (Qframe_set_background_mode): Remove decl.
3614
3615 * process.c (Fnetwork_interface_info): Declare local only if needed.
3616
3617 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3618
3619 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3620 (Fnetwork_interface_list): Allocate in increments of bytes instead
3621 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3622 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3623 sockaddr.
3624 (struct ifflag_def): notrailers is smart on OSX.
3625 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3626 Get hardware address with getifaddrs if available.
3627
3628 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3629
3630 * xdisp.c (iterate_out_of_display_property): xassert that
3631 IT->position is set to within IT->object's boundaries. Break from
3632 the loop as soon as EOB is reached; avoids infloops in redisplay
3633 when IT->position is set up wrongly due to some bug.
3634 Set IT->current to match the bidi iterator unconditionally.
3635 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3636 entry. Force push_it to save on the stack the current
3637 buffer/string position, to be restored by pop_it. Fix flags in
3638 the iterator structure wrt the object coming from a display
3639 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3640 properties. (Bug#9284)
3641
3642 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3643
3644 * fontset.c (fontset_get_font_group): Add proper type checks.
3645 (Bug#9172)
3646
3647 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3648
3649 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3650 and LC_VERSION_MIN_MACOSX.
3651 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3652 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3653
3654 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3655
3656 * xdisp.c (forward_to_next_line_start): Allow to use the
3657 no-display-properties-and-no-overlays under bidi display.
3658 Set disp_pos in the bidi iterator to avoid searches for display
3659 properties and overlays.
3660
3661 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3662
3663 * editfns.c (Fset_time_zone_rule): Document relationship with the
3664 setenv function.
3665
3666 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3667 the font entity extracted from the cache (Bug#8109).
3668
3669 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3670
3671 * composite.c (autocmp_chars): Don't reset point. That is done by
3672 restore_point_unwind (Bug#5984).
3673
3674 2011-08-07 Juri Linkov <juri@jurta.org>
3675
3676 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3677 to show the arg `TIME' instead of `TIMEVAL'.
3678
3679 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3680
3681 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3682 display property strides EOL and includes a newline, as in
3683 longlines-mode. (Bug#9254)
3684 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3685 word-wrap under bidirectional display. (Bug#9224)
3686
3687 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3688 is non-zero, even if the data buffer is NULL. Fixes a crash in
3689 vertical-motion with longlines-mode. (Bug#9254)
3690
3691 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3692
3693 * bidi.c <bidi_cache_total_alloc>: Now static.
3694 (bidi_initialize): Initialize bidi_cache_total_alloc.
3695
3696 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3697 cache. (Bug#9221)
3698
3699 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3700 amount allocated this far in `bidi_cache_total_alloc'.
3701 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3702 non-zero, only free the data buffer without restoring the cache
3703 contents. All callers changed.
3704
3705 * dispextern.h (bidi_unshelve_cache): Update prototype.
3706
3707 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3708 (move_it_in_display_line, move_it_to)
3709 (move_it_vertically_backward, move_it_by_lines): Replace the call
3710 to xfree to an equivalent call to bidi_unshelve_cache.
3711 (move_it_in_display_line_to): Fix logic of returning
3712 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3713
3714 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3715
3716 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3717 came from a string character with a `cursor' property. (Bug#9229)
3718
3719 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3720
3721 * Makefile.in (LIB_PTHREAD): New variable.
3722 (LIBES): Add LIB_PTHREAD (Bug#9216).
3723
3724 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3725 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3726
3727 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3728
3729 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3730
3731 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3732
3733 * xterm.c (x_find_topmost_parent): New function.
3734 (x_set_frame_alpha): Find topmost parent window with
3735 x_find_topmost_parent and set the property there also (bug#9181).
3736 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3737
3738 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3739
3740 * callproc.c (Fcall_process): Avoid vfork clobbering
3741 the local vars buffer, coding_systems, current_dir.
3742
3743 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3744
3745 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3746
3747 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3748
3749 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3750 so that it is not optimized away.
3751
3752 * xdisp.c (compute_display_string_pos): Remove unused local.
3753
3754 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3755
3756 Fix slow cursor motion and scrolling in large buffers with
3757 selective display, like Org Mode buffers. (Bug#9218)
3758
3759 * dispextern.h (struct bidi_it): New member disp_prop_p.
3760
3761 * xdisp.c: Remove one-slot cache of display string positions.
3762 (compute_display_string_pos): Accept an additional argument
3763 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3764 for a display string or property. If found, set DISP_PROP_P
3765 non-zero.
3766
3767 * bidi.c (bidi_fetch_char): Accept an additional argument
3768 DISP_PROP_P, and pass it to compute_display_string_pos.
3769 Only handle text covered by a display string if DISP_PROP_P is returned
3770 non-zero. All callers of bidi_fetch_char changed.
3771
3772 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3773
3774 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3775
3776 2010-12-03 Don March <don@ohspite.net>
3777
3778 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3779 last character M-[char] is translated to ESC [char] (bug#7541).
3780
3781 2011-08-02 Kenichi Handa <handa@m17n.org>
3782
3783 * lisp.h (uniprop_table): Extern it.
3784
3785 * chartab.c (uniprop_table): Make it non-static.
3786
3787 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3788
3789 * xdisp.c (forward_to_next_line_start): Accept additional argument
3790 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3791 on the newline.
3792 (reseat_at_next_visible_line_start): Use the bidi iterator state
3793 returned by forward_to_next_line_start to restore the state of
3794 it->bidi_it after backing up to previous newline. (Bug#9212)
3795
3796 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3797
3798 * regex.c (re_comp): Protoize.
3799 (re_exec): Fix return type.
3800 (regexec): Fix type of `ret'. (Bug#9203)
3801
3802 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3803
3804 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3805 This is needed if max-image-size is a floating-point number.
3806
3807 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3808
3809 * print.c (print_object): Print empty symbol as ##.
3810
3811 * lread.c (read1): Read ## as empty symbol.
3812
3813 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3814
3815 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3816 setting frame foreground color (Bug#9175).
3817 (x_set_background_color): Likewise.
3818
3819 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3820 contents (Bug#9176).
3821 (EmacsTooltip -init): Remove bezels and add shadows to
3822 tooltip windows.
3823
3824 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3825 or scroll bar (Bug#8470).
3826
3827 * nsfont.m (nsfont_open): Remove assignment to voffset and
3828 unnecessary vars hshink, expand, hd, full_height, min_height.
3829 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3830
3831 * nsterm.h (nsfont_info): Remove voffset field.
3832
3833 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3834
3835 Implement strike-through and overline on NextStep (Bug#8863).
3836
3837 * nsfont.m (nsfont_open): Use underline position provided by font,
3838 instead of hard-coded value of 2.
3839 (nsfont_draw): Call ns_draw_text_decoration instead.
3840
3841 * nsterm.h: Add declaration for ns_draw_text_decoration.
3842
3843 * nsterm.m (ns_draw_text_decoration): New function for drawing
3844 underline, overline, and strike-through.
3845 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3846 ns_draw_text_decoration. Change treatment of cursor drawing to
3847 accommodate underlining, etc.
3848
3849 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3850
3851 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3852 default.
3853
3854 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3855
3856 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3857 Without this fix, if a signal arrives just after memory fills up,
3858 'malloc' might be invoked reentrantly.
3859
3860 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3861 In other words, assume that every image size is allowed, on non-X
3862 hosts. This assumption is probably wrong, but it lets Emacs compile.
3863
3864 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3865
3866 * regex.c (re_iswctype): Convert return values to boolean.
3867
3868 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3869
3870 * xdisp.c (compute_display_string_pos): Don't use cached display
3871 string position if the buffer had its restriction changed.
3872 (Bug#9184)
3873
3874 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3875
3876 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3877
3878 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3879
3880 Integer signedness and overflow and related fixes. (Bug#9079)
3881
3882 * bidi.c: Integer size and overflow fixes.
3883 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3884 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3885 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3886 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3887 (bidi_find_other_level_edge):
3888 Use ptrdiff_t instead of EMACS_INT where either will do.
3889 This works better on 32-bit hosts configured --with-wide-int.
3890 (bidi_cache_ensure_space): Check for size-calculation overflow.
3891 Use % rather than repeated addition, for better worst-case speed.
3892 Don't set bidi_cache_size until after xrealloc returns, because it
3893 might not return.
3894 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3895 (bidi_cache_ensure_space): Also check that the bidi cache size
3896 does not exceed that of the largest Lisp string or buffer. See Eli
3897 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3898
3899 * alloc.c (__malloc_size_t): Remove.
3900 All uses replaced by size_t. See Andreas Schwab's note
3901 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3902
3903 * image.c: Improve checking for integer overflow.
3904 (check_image_size): Assume that f is nonnull, since
3905 it is always nonnull in practice. This is one less thing to
3906 worry about when checking for integer overflow later.
3907 (x_check_image_size): New function, which checks for integer
3908 overflow issues inside X.
3909 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3910 This removes the need for a memory_full check.
3911 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3912 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3913 (xbm_read_bitmap_data): Change locals back to 'int', since
3914 their values must fit in 'int'.
3915 (xpm_load_image, png_load, tiff_load):
3916 Invoke x_create_x_image_and_pixmap earlier,
3917 to avoid much needless work if the image is too large.
3918 (tiff_load): Treat overly large images as if
3919 x_create_x_image_and_pixmap failed, not as malloc failures.
3920 (gs_load): Use x_check_image_size.
3921
3922 * gtkutil.c: Omit integer casts.
3923 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3924 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3925
3926 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3927
3928 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3929 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3930 would wrongly return t on a 64-bit host.
3931
3932 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3933 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3934 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3935 and therefore cause GCC to emit a bogus diagnostic in some cases.
3936
3937 * image.c: Integer signedness and overflow and related fixes.
3938 This is not an exhaustive set of fixes, but it's time to
3939 record what I've got.
3940 (lookup_pixel_color, check_image_size): Remove redundant decls.
3941 (check_image_size): Don't assume that arbitrary EMACS_INT values
3942 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3943 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3944 (tiff_load, imagemagick_load_image):
3945 Check for overflow in size calculations.
3946 (x_create_x_image_and_pixmap): Remove unnecessary test for
3947 xmalloc returning NULL; that can't happen.
3948 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3949 (xpm_color_bucket): Use better integer hashing function.
3950 (xpm_cache_color): Don't possibly over-allocate memory.
3951 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3952 (gif_memory_source):
3953 Use ptrdiff_t, not int or size_t, to record sizes.
3954 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3955 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3956 either works, as we prefer signed integers.
3957 (tiff_read_from_memory, tiff_write_from_memory):
3958 Return tsize_t, not size_t, since that's what the TIFF API wants.
3959 (tiff_read_from_memory): Don't fail simply because the read would
3960 go past EOF; instead, return a short read.
3961 (tiff_load): Omit no-longer-needed casts.
3962 (Fimagemagick_types): Don't assume size fits into 'int'.
3963
3964 Improve hashing quality when configured --with-wide-int.
3965 * fns.c (hash_string): New function, taken from sxhash_string.
3966 Do not discard information about ASCII character case; this
3967 discarding is no longer needed.
3968 (sxhash-string): Use it. Change sig to match it. Caller changed.
3969 * lisp.h: Declare it.
3970 * lread.c (hash_string): Remove, since we now use fns.c's version.
3971 The fns.c version returns a wider integer if --with-wide-int is
3972 specified, so this should help the quality of the hashing a bit.
3973
3974 * emacs.c: Integer overflow minor fix.
3975 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3976 Define only if GNU_LINUX.
3977 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3978
3979 * dispnew.c: Integer signedness and overflow fixes.
3980 Remove unnecessary forward decls, that were a maintenance hassle.
3981 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3982 All uses changed.
3983 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3984 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3985 (prepare_desired_row, line_draw_cost):
3986 Use int, not unsigned, where either works.
3987 (save_current_matrix, restore_current_matrix):
3988 Use ptrdiff_t, not size_t, where either works.
3989 (init_display): Check for overflow more accurately, and without
3990 relying on undefined behavior.
3991
3992 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3993 Remove, replacing with the new symbols in lisp.h. All uses changed.
3994 * fileio.c (make_temp_name):
3995 * filelock.c (lock_file_1, lock_file):
3996 * xdisp.c (message_dolog):
3997 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3998 Use pMd etc. instead.
3999 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4000 replacing the pWIDE etc. symbols removed from editfns.c.
4001
4002 * keyboard.h (num_input_events): Now uintmax_t.
4003 This is (very slightly) less likely to mess up due to wraparound.
4004 All uses changed.
4005
4006 * buffer.c: Integer signedness fixes.
4007 (alloc_buffer_text, enlarge_buffer_text):
4008 Use ptrdiff_t rather than size_t when either will do, as we prefer
4009 signed integers.
4010
4011 * alloc.c: Integer signedness and overflow fixes.
4012 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4013 (__malloc_size_t): Default to size_t, not to int.
4014 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4015 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4016 Prefer ptrdiff_t to size_t when either would do, as we prefer
4017 signed integers.
4018 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4019 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4020 Now const. Initialize with values that are in range even if char
4021 is signed.
4022 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4023 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4024 These functions do the right thing with sizes > 2**32.
4025 (check_depth): Now ptrdiff_t, not int.
4026 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4027 Adjust to new way of storing sizes. Check for size overflow bugs
4028 in rest of code.
4029 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4030 slightly wrong anyway, as it missed one instance of
4031 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4032 (refill_memory_reserve): Omit needless cast to size_t.
4033 (mark_object_loop_halt): Mark as externally visible.
4034
4035 * xselect.c: Integer signedness and overflow fixes.
4036 (Fx_register_dnd_atom, x_handle_dnd_message):
4037 Use ptrdiff_t, not size_t, since we prefer signed.
4038 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4039 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4040 x_dnd_atoms_size and x_dnd_atoms_length.
4041
4042 * doprnt.c: Prefer signed to unsigned when either works.
4043 * eval.c (verror):
4044 * doprnt.c (doprnt):
4045 * lisp.h (doprnt):
4046 * xdisp.c (vmessage):
4047 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4048 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4049 prefer signed arithmetic to avoid comparison confusion.
4050 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4051 but is a bit tricky.
4052
4053 Assume freestanding C89 headers, string.h, stdlib.h.
4054 * data.c, doprnt.c, floatfns.c, print.c:
4055 Include float.h unconditionally.
4056 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4057 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4058 * regex.c: Likewise for stddef.h, string.h.
4059 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4060 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4061 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4062 (STDC_HEADERS): Remove obsolete defines.
4063 * sysdep.c: Include limits.h unconditionally.
4064
4065 Assume support for memcmp, memcpy, memmove, memset.
4066 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4067 * regex.c (memcmp, memcpy):
4068 Remove; we assume C89 now.
4069
4070 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4071 (__malloc_safe_bcopy): Remove; no longer needed.
4072
4073 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4074 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4075 well either way, and we prefer signed to unsigned.
4076
4077 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4078
4079 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4080 closes the connection while we're reading (bug#9182).
4081
4082 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4083
4084 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4085 are specified (Bug#9168).
4086
4087 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4088
4089 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4090 Found by GCC static checking and --with-wide-int on a 32-bit host.
4091
4092 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4093
4094 * xdisp.c (compute_display_string_pos): Fix logic of caching
4095 previous display string position. Initialize cached_prev_pos to
4096 -1. Fixes slow-down at the beginning of a buffer.
4097
4098 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4099
4100 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4101 for attrs[LFACE_FONTSET_INDEX].
4102
4103 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4104
4105 * xml.c (parse_region): Remove unused local
4106 that was recently introduced.
4107
4108 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4109
4110 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4111 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4112
4113 * xdisp.c (move_it_in_display_line_to): Record the best matching
4114 position for TO_CHARPOS while scanning the line, and restore it on
4115 exit if none of the characters scanned was an exact match.
4116 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4117 when exact match is impossible due to invisible text, and the
4118 lines are truncated.
4119
4120 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4121
4122 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4123 for OSX >= 10.7.
4124
4125 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4126
4127 Fix a significant slow-down of cursor motion with C-n, C-p,
4128 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4129 auto-repeat under bidi redisplay in fontified buffers.
4130 * xdisp.c (compute_stop_pos_backwards): New function.
4131 (next_element_from_buffer): Call compute_stop_pos_backwards to
4132 find a suitable prev_stop when we find ourselves before
4133 base_level_stop.
4134 (reseat): Don't look for prev_stop, as that could mean a very long
4135 run.
4136 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4137 <cached_disp_overlay_modiff>: Cache for last found display string
4138 position.
4139 (compute_display_string_pos): Return the cached position if asked
4140 about the same buffer in the same area of character positions, and
4141 the buffer wasn't changed since the time the display string
4142 position was cached.
4143
4144 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4145
4146 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4147 is an integer, which is important for empty lines. (Bug#9149)
4148
4149 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4150
4151 * frame.c (Fmodify_frame_parameters): In tty case, update the
4152 default face if necessary (Bug#4238).
4153
4154 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4155
4156 * editfns.c (Fstring_to_char): No need to explain what a character
4157 is in the docstring (Bug#6576).
4158
4159 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4160
4161 * xml.c (parse_region): Make sure we always return a tree.
4162
4163 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4164
4165 * xml.c (parse_region): If a document contains only comments,
4166 return that, too.
4167
4168 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4169
4170 * xml.c (make_dom): Return comments, too.
4171
4172 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4173
4174 Port to OpenBSD.
4175 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4176 and the surrounding thread.
4177 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4178 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4179 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4180 timer goes off.
4181 * s/openbsd.h (BROKEN_SIGIO): Define.
4182 * unexelf.c (unexec) [__OpenBSD__]:
4183 Don't update the .mdebug section of the Alpha COFF symbol table.
4184
4185 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4186
4187 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4188 (bug#8460).
4189
4190 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4191
4192 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4193 This fixes some race conditions on the permissions of any newly
4194 created file.
4195
4196 * alloc.c (valid_pointer_p): Use pipe, not open.
4197 This fixes some permissions issues when debugging.
4198
4199 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4200 If fchown fails to set both uid and gid, try to set just gid,
4201 as that is sometimes allowed. Adjust the file's mode to eliminate
4202 setuid or setgid bits that are inappropriate if fchown fails.
4203
4204 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4205
4206 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4207 to compare Lisp_Objects.
4208 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4209 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4210 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4211
4212 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4213
4214 * lread.c (read_integer): Unread even EOF character.
4215 (read1): Likewise. Properly record start position of symbol.
4216
4217 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4218 symbol character follows.
4219
4220 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4221
4222 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4223 This works around a problem with the previous change to Fcopy_file.
4224 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4225 and without this change, GCC might complain about discarding
4226 fchown's return value.
4227
4228 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4229
4230 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4231
4232 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4233
4234 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4235
4236 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4237
4238 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4239 it's used from the C level.
4240
4241 * process.c: Use the same condition for POLL_FOR_INPUT in both
4242 keyboard.c and process.c (bug#1858).
4243
4244 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4245
4246 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4247 (Fgnutls_boot): Use it.
4248
4249 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4250
4251 * doc.c (Fsubstitute_command_keys): Revert last change.
4252
4253 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4254
4255 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4256 quotes the next character, and doesn't affect other longer
4257 sequences (bug#8935).
4258
4259 * lread.c (syms_of_lread): Clarify that is isn't only
4260 `eval-buffer' and `eval-defun' that's affected by
4261 `lexical-binding' (bug#8460).
4262
4263 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4264
4265 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4266 bidi redisplay when a line includes both an image and is truncated.
4267
4268 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4269
4270 Fix minor problems found by static checking.
4271 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4272 (elsz): Now a signed constant, not a size_t var. We prefer signed
4273 types to unsigned, to avoid integer comparison confusion. Without
4274 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4275 "cannot optimize loop, the loop counter may overflow", a symptom
4276 of the confusion.
4277 * indent.c (Fvertical_motion): Mark locals as initialized.
4278 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4279
4280 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4281
4282 * search.c (Fre_search_backward): Mention `case-fold-search' in
4283 all the re_search_* functions (bug#8138).
4284
4285 * keyboard.c (Fopen_dribble_file): Document when the file is
4286 closed (bug#8056).
4287
4288 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4289
4290 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4291 bidi_cache_idx.
4292
4293 Support bidi reordering of display and overlay strings.
4294 * xdisp.c (compute_display_string_pos)
4295 (compute_display_string_end): Accept additional argument STRING.
4296 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4297 (reseat_to_string): Initialize bidi_it->string.s and
4298 bidi_it->string.schars.
4299 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4300 NULL (avoids a crash in bidi_paragraph_init).
4301 Initialize itb.string.lstring.
4302 (init_iterator): Call bidi_init_it only of a valid
4303 buffer position was specified. Initialize paragraph_embedding to
4304 L2R.
4305 (reseat_to_string): Initialize the bidi iterator.
4306 (display_string): If we need to ignore text properties of
4307 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4308 original value of -1 will not work with bidi.)
4309 (compute_display_string_pos): First arg is now struct
4310 `text_pos *'; all callers changed. Support display properties on
4311 Lisp strings.
4312 (compute_display_string_end): Support display properties on Lisp
4313 strings.
4314 (init_iterator, reseat_1, reseat_to_string): Initialize the
4315 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4316 when iterating on a string not from display properties).
4317 (compute_display_string_pos, compute_display_string_end):
4318 Fix calculation of the object to scan. Fixes an error when using
4319 arrow keys.
4320 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4321 base_level_stop; instead, set base_level_stop to BEGV.
4322 Fixes crashes in vertical-motion.
4323 (next_element_from_buffer): Improve commentary for when
4324 the iterator is before prev_stop.
4325 (init_iterator): Initialize bidi_p from the default value of
4326 bidi-display-reordering, not from buffer-local value. Use the
4327 buffer-local value only if initializing for buffer iteration.
4328 (handle_invisible_prop): Support invisible properties on strings
4329 that are being bidi-reordered.
4330 (set_iterator_to_next): Support bidi reordering of C strings and
4331 Lisp strings.
4332 (next_element_from_string): Support bidi reordering of Lisp
4333 strings.
4334 (handle_stop_backwards): Support Lisp strings as well.
4335 (display_string): Support display of R2L glyph rows.
4336 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4337 (init_iterator): Don't initialize it->bidi_p for strings
4338 here.
4339 (reseat_to_string): Initialize it->bidi_p for strings here.
4340 (next_element_from_string, next_element_from_c_string)
4341 (next_element_from_buffer): Add xassert's for correspondence
4342 between IT's object being iterated and it->bidi_it.string
4343 structure.
4344 (face_before_or_after_it_pos): Support bidi iteration.
4345 (next_element_from_c_string): Handle the case of the first string
4346 character that is not the first one in the visual order.
4347 (get_visually_first_element): New function, refactored from common
4348 parts of next_element_from_buffer, next_element_from_string, and
4349 next_element_from_c_string.
4350 (tool_bar_lines_needed, redisplay_tool_bar)
4351 (display_menu_bar): Force left-to-right direction. Add a FIXME
4352 comment for making that be controlled by a user option.
4353 (push_it, pop_it): Save and restore the state of the
4354 bidi iterator. Save and restore the bidi_p flag.
4355 (pop_it): Iterate out of display property for string iteration as
4356 well.
4357 (iterate_out_of_display_property): Support iteration over strings.
4358 (handle_single_display_spec): Set up it->bidi_it for iteration
4359 over a display string, and call bidi_init_it.
4360 (handle_single_display_spec, next_overlay_string)
4361 (get_overlay_strings_1, push_display_prop): Set up the bidi
4362 iterator for displaying display or overlay strings.
4363 (forward_to_next_line_start): Don't use the shortcut if
4364 bidi-iterating.
4365 (back_to_previous_visible_line_start): If handle_display_prop
4366 pushed the iterator stack, restore the internal state of the bidi
4367 iterator by calling bidi_pop_it same number of times.
4368 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4369 and we are bidi-iterating, don't decrement the iterator position;
4370 instead, set the first_elt flag in the bidi iterator, to produce
4371 the same effect.
4372 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4373 (push_display_prop): xassert that we are iterating a buffer.
4374 (push_it, pop_it): Save and restore paragraph_embedding member.
4375 (handle_single_display_spec, next_overlay_string)
4376 (get_overlay_strings_1, reseat_1, reseat_to_string)
4377 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4378 correctly. Don't assume unibyte strings are not bidi-reordered.
4379 (compute_display_string_pos)
4380 (compute_display_string_end): Fix handling the case of C string.
4381 (push_it, pop_it): Save and restore from_disp_prop_p.
4382 (handle_single_display_spec, push_display_prop): Set the
4383 from_disp_prop_p flag.
4384 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4385 (pop_it): Call iterate_out_of_display_property only if we are
4386 popping after iteration over a string that came from a display
4387 property. Fix a typo in popping stretch info. Add an assertion
4388 for verifying that the iterator position is in sync with the bidi
4389 iterator.
4390 (handle_single_display_spec, get_overlay_strings_1)
4391 (push_display_prop): Fix initialization of paragraph direction for
4392 string when that of the parent object is not yet determined.
4393 (reseat_1): Call bidi_init_it to resync the bidi
4394 iterator with IT's position. (Bug#7616)
4395 (find_row_edges): If ROW->start.pos gives position
4396 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4397 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4398 Reset the from_disp_prop_p flag.
4399 (SAVE_IT, RESTORE_IT): New macros.
4400 (pos_visible_p, face_before_or_after_it_pos)
4401 (back_to_previous_visible_line_start)
4402 (move_it_in_display_line_to, move_it_in_display_line)
4403 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4404 (try_scrolling, redisplay_window, display_line): Use them when
4405 saving a temporary copy of the iterator and restoring it back.
4406 (back_to_previous_visible_line_start, reseat_1)
4407 (init_iterator): Empty the bidi cache "stack".
4408 (move_it_in_display_line_to): If iterator ended up at
4409 EOL, but we never saw any buffer positions smaller than
4410 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4411 motion in bidi-reordered lines.
4412 (move_it_in_display_line_to): Record prev_method and prev_pos
4413 immediately before the call to set_iterator_to_next. Fixes cursor
4414 motion in bidi-reordered lines with stretch glyphs and strings
4415 displayed in margins. (Bug#8133) (Bug#8867)
4416 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4417 TO_CHARPOS.
4418 (pos_visible_p): Support positions in bidi-reordered lines.
4419 Save and restore bidi cache.
4420
4421 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4422 (bidi_paragraph_info): Delete unused struct.
4423 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4424 (bidi_cache_start): New variable.
4425 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4426 to zero.
4427 (bidi_cache_fetch_state, bidi_cache_search)
4428 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4429 (bidi_cache_find, bidi_peek_at_next_level)
4430 (bidi_level_of_next_char, bidi_find_other_level_edge)
4431 (bidi_move_to_visually_next): Compare cache index with
4432 bidi_cache_start rather than with zero.
4433 (bidi_fetch_char): Accept new argument STRING; all callers
4434 changed. Support iteration over a string. Support strings with
4435 display properties. Support unibyte strings. Fix the type of
4436 `len' according to what STRING_CHAR_AND_LENGTH expects.
4437 (bidi_paragraph_init, bidi_resolve_explicit_1)
4438 (bidi_resolve_explicit, bidi_resolve_weak)
4439 (bidi_level_of_next_char, bidi_move_to_visually_next):
4440 Support iteration over a string.
4441 (bidi_set_sor_type, bidi_resolve_explicit_1)
4442 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4443 can now be zero (for strings); special values 0 and -1 were
4444 changed to -1 and -2, respectively.
4445 (bidi_char_at_pos): New function.
4446 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4447 Call it instead of FETCH_MULTIBYTE_CHAR.
4448 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4449 initialized to valid values.
4450 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4451 values.
4452 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4453 the test for valid cached positions. Fix the logic for looking up
4454 the sentinel state in the cache. GCPRO the Lisp string we are
4455 iterating.
4456 (bidi_push_it, bidi_pop_it): New functions.
4457 (bidi_initialize): Initialize the bidi cache start stack pointer.
4458 (bidi_cache_ensure_space): New function, refactored from part of
4459 bidi_cache_iterator_state. Don't assume the required size is just
4460 one BIDI_CACHE_CHUNK away.
4461 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4462 (bidi_count_bytes, bidi_char_at_pos): New functions.
4463 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4464 always valid if bidi_cache_idx is valid.
4465 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4466 is valid if it's going to be used.
4467 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4468 (bidi_cache_fetch_state, bidi_cache_search)
4469 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4470 (bidi_cache_iterator_state, bidi_cache_find)
4471 (bidi_find_other_level_edge, bidi_cache_start_stack):
4472 All variables related to cache indices are now EMACS_INT.
4473
4474 * dispextern.h (struct bidi_string_data): New structure.
4475 (struct bidi_it): New member `string'. Make flag members be 1-bit
4476 fields, and put them last in the struct.
4477 (compute_display_string_pos, compute_display_string_end):
4478 Update prototypes.
4479 (bidi_push_it, bidi_pop_it): Add prototypes.
4480 (struct iterator_stack_entry): New members bidi_p,
4481 paragraph_embedding, and from_disp_prop_p.
4482 (struct it): Member bidi_p is now a bit field 1 bit wide.
4483 (bidi_shelve_cache, bidi_unshelve_cache):
4484 Declare prototypes.
4485
4486 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4487 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4488 and vector-like objects.
4489
4490 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4491 cache around display iteration.
4492
4493 * window.c (Fwindow_end, window_scroll_pixel_based)
4494 (displayed_window_lines, Frecenter): Save and restore the bidi
4495 cache around display iteration.
4496
4497 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4498
4499 * editfns.c (Fdelete_region): Clarify the use of the named
4500 parameters (bug#6788).
4501
4502 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4503
4504 * indent.c (Fvertical_motion): Set and restore w->pointm when
4505 saving and restoring the window's buffer (Bug#9006).
4506
4507 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4508
4509 * editfns.c (Fstring_to_char): Clarify just what is returned
4510 (bug#6576). Text by Eli Zaretskii.
4511
4512 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4513
4514 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4515
4516 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4517
4518 * buffer.c (mmap_find): Fix a typo.
4519
4520 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4521
4522 Fix execution of x selection hooks.
4523 * xselect.c (Qx_lost_selection_functions)
4524 (Qx_sent_selection_functions): New vars.
4525 (syms_of_xselect): DEFSYM them.
4526 (x_handle_selection_request): Pass Qx_sent_selection_functions
4527 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4528 (x_handle_selection_clear,x_clear_frame_selections):
4529 Pass Qx_lost_selection_functions rather than
4530 Vx_lost_selection_functions to Frun_hook_with_args.
4531
4532 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4533
4534 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4535 The old code sometimes used this field without initializing it.
4536
4537 * alloc.c (gc_sweep): Don't read past end of array.
4538 In theory, the old code could also have corrupted Emacs internals,
4539 though it'd be very unlikely.
4540
4541 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4542
4543 * character.c (Fcharacterp): Don't advertise optional ignored
4544 argument. (Bug#4026)
4545
4546 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4547
4548 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4549 key" (bug#4257).
4550
4551 * window.c (Fset_window_start): Doc fix (bug#4199).
4552 (Fset_window_hscroll): Ditto.
4553
4554 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4555
4556 Fix minor new problems caught by GCC 4.6.1.
4557 * term.c (init_tty): Remove unused local.
4558 * xsettings.c (store_monospaced_changed): Define this function only
4559 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4560 not used otherwise.
4561
4562 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4563
4564 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4565
4566 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4567
4568 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4569 are the mini-buffer and the echo area (bug#3320).
4570
4571 * term.c (init_tty): Remove support for supdup, c10 and perq
4572 terminals, which are no longer supported (bug#1482).
4573
4574 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4575
4576 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4577
4578 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4579
4580 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4581 for non-popups (Bug#3642).
4582
4583 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4584
4585 * alloc.c (reset_malloc_hooks): Protoize.
4586 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4587 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4588 * cm.c (losecursor): Likewise.
4589 * data.c (fmod): Likewise.
4590 * dispnew.c (swap_glyphs_in_rows): Likewise.
4591 * emacs.c (memory_warning_signal): Likewise.
4592 * floatfns.c (float_error): Likewise.
4593 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4594 (otf_open, font_otf_capability, generate_otf_features)
4595 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4596 Likewise.
4597 * image.c (pbm_read_file): Likewise.
4598 * indent.c (string_display_width): Likewise.
4599 * intervals.c (check_for_interval, search_for_interval)
4600 (inc_interval_count, count_intervals, root_interval)
4601 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4602 * lread.c (defalias): Likewise.
4603 * ralloc.c (r_alloc_check): Likewise.
4604 * regex.c (set_image_of_range_1, set_image_of_range)
4605 (regex_grow_registers): Likewise.
4606 * sysdep.c (strerror): Likewise.
4607 * termcap.c (valid_filename_p, tprint, main): Likewise.
4608 * tparam.c (main): Likewise.
4609 * unexhp9k800.c (run_time_remap, save_data_space)
4610 (update_file_ptrs, read_header, write_header, calculate_checksum)
4611 (copy_file, copy_rest, display_header): Likewise.
4612 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4613 Likewise.
4614 * xdisp.c (check_it): Likewise.
4615 * xfaces.c (register_color, unregister_color, unregister_colors):
4616 Likewise.
4617 * xfns.c (print_fontset_result): Likewise.
4618 * xrdb.c (member, fatal, main): Likewise.
4619
4620 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4621
4622 Fix minor problems found by static checking (Bug#9031).
4623 * chartab.c (char_table_set_range, map_sub_char_table):
4624 Remove unused locals.
4625 (uniprop_table): Now static.
4626 * composite.c (_work_char): Remove unused static var.
4627
4628 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4629
4630 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4631
4632 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4633
4634 * gtkutil.c (qttip_cb): Remove code without function.
4635
4636 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4637
4638 * w32.c (pthread_sigmask): New stub.
4639
4640 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4641
4642 Use pthread_sigmask, not sigprocmask (Bug#9010).
4643 sigprocmask is portable only for single-threaded applications, and
4644 Emacs can be multi-threaded when it uses GTK.
4645 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4646 (LIBES): Use it.
4647 * callproc.c (Fcall_process):
4648 * process.c (create_process):
4649 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4650 Use pthread_sigmask, not sigprocmask.
4651
4652 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4653
4654 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4655 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4656 wrong (Bug#8591).
4657
4658 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4659
4660 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4661 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4662 (xg_hide_tooltip): Fix comment.
4663
4664 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4665 in registerServicesMenuSendTypes.
4666 (validRequestorForSendType): Don't check ns_return_types.
4667
4668 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4669 ns_return_type.
4670
4671 2011-07-08 Jason Rumney <jasonr@gnu.org>
4672
4673 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4674 SH_SHOW for hidden windows (Bug#5482).
4675
4676 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4677 frame struct members of non-existent frames (Bug#6284).
4678
4679 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4680
4681 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4682 variable firstTime not needed on OSX >= 10.6.
4683 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4684 >= 10.5. Use setKnobProportion, setDoubleValue.
4685
4686 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4687 (MAC_OS_X_VERSION_10_5): Define if not defined.
4688 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4689 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4690 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4691
4692 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4693 cString and lossyCString on OSX >= 10.4
4694
4695 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4696 sizeToFit on OSX >= 10.2.
4697
4698 * nsimage.m (allocInitFromFile): Don't use deprecated method
4699 bestRepresentationForDevice on OSX >= 10.6.
4700
4701 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4702 to avoid warning.
4703
4704 * emacs.c: Declare unexec_init_emacs_zone.
4705
4706 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4707
4708 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4709
4710 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4711 on svcsMenu (Bug#8842).
4712
4713 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4714 ns_return_types.
4715 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4716
4717 * nsterm.m (QUTF8_STRING): Declare.
4718 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4719 (validRequestorForSendType): Return type is (id).
4720 Change indexOfObjectIdenticalTo to indexOfObject.
4721 Check if we have local selection before returning self (Bug#8842).
4722 (writeSelectionToPasteboard): Put local selection into paste board
4723 if we have a local selection (Bug#8842).
4724 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4725
4726 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4727 (ns_get_local_selection): Declare.
4728
4729 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4730
4731 * keymap.c (describe_map_tree): Don't insert a double newline at
4732 the end of the buffer (bug#1169) and return whether we inserted
4733 something.
4734
4735 * callint.c (Fcall_interactively): Change "reading args" to
4736 "providing args" to try to clarify what it does (bug#1010).
4737
4738 2011-07-07 Kenichi Handa <handa@m17n.org>
4739
4740 * composite.c (composition_compute_stop_pos): Ignore a static
4741 composition starting before CHARPOS (Bug#8915).
4742
4743 * xdisp.c (handle_composition_prop): Likewise.
4744
4745 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4746
4747 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4748 (Bug#9015)
4749
4750 2011-07-07 Kenichi Handa <handa@m17n.org>
4751
4752 * character.h (unicode_category_t): New enum type.
4753
4754 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4755 (Qchar_code_property_table): New variable.
4756 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4757 (UNIPROP_COMPRESSED_FORM_P): New macros.
4758 (char_table_ascii): Uncompress the compressed values.
4759 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4760 Uncompress the compressed values.
4761 (sub_char_table_ref_and_range): Likewise.
4762 (char_table_ref_and_range): Uncompress the compressed values.
4763 (sub_char_table_set): New arg is_uniprop. Callers changed.
4764 Uncompress the compressed values.
4765 (sub_char_table_set_range): Args changed. Callers changed.
4766 (char_table_set_range): Adjuted for the above change.
4767 (map_sub_char_table): Delete args default_val and parent. Add arg
4768 top. Give decoded values to a Lisp function.
4769 (map_char_table): Adjust for the above change. Give decoded
4770 values to a Lisp function. Gcpro more variables.
4771 (uniprop_table_uncompress)
4772 (uniprop_decode_value_run_length): New functions.
4773 (uniprop_decoder, uniprop_decoder_count): New variables.
4774 (uniprop_get_decoder, uniprop_encode_value_character)
4775 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4776 New functions.
4777 (uniprop_encoder, uniprop_encoder_count): New variables.
4778 (uniprop_get_encoder, uniprop_table)
4779 (Funicode_property_table_internal, Fget_unicode_property_internal)
4780 (Fput_unicode_property_internal): New functions.
4781 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4782 Sunicode_property_table_internal, Sget_unicode_property_internal,
4783 and Sput_unicode_property_internal. Defvar_lisp
4784 char-code-property-alist.
4785
4786 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4787 Vunicode_category_table.
4788
4789 * font.c (font_range): Adjust for the change of
4790 Vunicode_category_table.
4791
4792 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4793
4794 * m/iris4d.h: Remove file, move contents ...
4795 * s/irix6-5.h: ... here.
4796
4797 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4798
4799 Remove unportable assumption about struct layout (Bug#8884).
4800 * alloc.c (mark_buffer):
4801 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4802 (clone_per_buffer_values): Don't assume that
4803 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4804 This isn't true in general, and it's particularly not true
4805 if Emacs is configured with --with-wide-int.
4806 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4807 New macros, used in the buffer.c change.
4808
4809 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4810
4811 * xsettings.c: Use both GConf and GSettings if both are available.
4812 (store_config_changed_event): Add comment.
4813 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4814 (store_tool_bar_style_changed): New functions.
4815 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4816 (struct xsettings): Move font inside HAVE_XFT.
4817 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4818 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4819 Move inside HAVE_XFT.
4820 (something_changed_gsettingsCB): Rename from something_changedCB.
4821 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4822 also.
4823 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4824 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4825 (something_changed_gconfCB): Rename from something_changedCB.
4826 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4827 (parse_settings): Move check for font inside HAVE_XFT.
4828 (read_settings, apply_xft_settings): Add comment.
4829 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4830 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4831 call store_font_name_changed.
4832 (xft_settings_event): Add comment.
4833 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4834 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4835 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4836 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4837 (xsettings_initialize): Call init_gsettings last.
4838 (xsettings_get_system_font, xsettings_get_system_normal_font):
4839 Add comment.
4840
4841 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4842
4843 Random fixes. E.g., (random) never returned negative values.
4844 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4845 subseconds part to the entropy, as that's a bit more random.
4846 Prefer signed to unsigned, since the signedness doesn't matter and
4847 in general we prefer signed. When given a limit, use a
4848 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4849 latter isn't right if USE_2_TAGS_FOR_INTS.
4850 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4851 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4852
4853 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4854
4855 * textprop.c (text_property_stickiness):
4856 Obey Vtext_property_default_nonsticky.
4857 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4858 * w32fns.c (syms_of_w32fns):
4859 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4860
4861 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4862
4863 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4864 This is more efficient than Ffile_directory_p and avoids a minor race.
4865
4866 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4867
4868 * buffer.c (Foverlay_put): Say what the return value is
4869 (bug#7835).
4870
4871 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4872 is a directory before asking whether to use the file name
4873 (bug#7564).
4874 (barf_or_query_if_file_exists): Make the "File is a directory"
4875 error be more correct.
4876
4877 * fns.c (Frequire): Remove the mention of the .gz files, since
4878 that's installation-specific, but keep the mention of
4879 `get-load-suffixes'.
4880
4881 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4882
4883 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4884 Report string overflow if the output is too long.
4885
4886 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4887
4888 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4889 (syms_of_gnutls): Remove duplicate DEFSYM for
4890 Qgnutls_bootprop_verify_hostname_error, an error for
4891 Qgnutls_bootprop_verify_error (which is no longer used).
4892
4893 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4894 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4895 Also (re)move comments that are misplaced or no longer relevant.
4896
4897 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4898
4899 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4900
4901 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4902
4903 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4904 and background color parameters if they have been changed.
4905
4906 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4907
4908 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4909
4910 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4911
4912 * xsettings.c (SYSTEM_FONT): Define only when used.
4913 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4914
4915 * keymap.c (access_keymap_1): Now static.
4916
4917 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4918
4919 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4920 leave any prefix arg for the up event (Bug#1586).
4921
4922 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4923
4924 * lread.c (syms_of_lread): Mention single symbols defined by
4925 `defvar' or `defconst' (bug#7154).
4926
4927 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4928 (Frequire): Mention get-load-suffixes.
4929
4930 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4931
4932 * window.h (window): Remove clone_number slot.
4933 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4934 Remove.
4935 (make_parent_window, make_window, saved_window)
4936 (Fset_window_configuration, save_window_save): Don't deal with
4937 clone numbers.
4938 * buffer.c (Qclone_number): Remove declaration.
4939 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4940
4941 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4942
4943 Add multiple inheritance to keymaps.
4944 * keymap.c (Fmake_composed_keymap): New function.
4945 (Fset_keymap_parent): Simplify.
4946 (fix_submap_inheritance): Remove.
4947 (access_keymap_1): New function extracted from access_keymap to handle
4948 embedded parents and handle lists of maps.
4949 (access_keymap): Use it.
4950 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4951 (Fcopy_keymap): Handle embedded parents.
4952 (Fcommand_remapping, define_as_prefix): Simplify.
4953 (Fkey_binding): Simplify.
4954 (syms_of_keymap): Move minibuffer-local-completion-map,
4955 minibuffer-local-filename-completion-map,
4956 minibuffer-local-must-match-map, and
4957 minibuffer-local-filename-must-match-map to Elisp.
4958 (syms_of_keymap): Defsubr make-composed-keymap.
4959 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4960 (parse_menu_item): Trivial simplification.
4961
4962 2011-07-01 Glenn Morris <rgm@gnu.org>
4963
4964 * Makefile.in (SETTINGS_LIBS): Fix typo.
4965
4966 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4967
4968 * coding.c (Fencode_coding_string): Record the last coding system
4969 used, as the function doc string says (bug#8738).
4970
4971 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4972
4973 * xsettings.c (store_monospaced_changed): Take new font as arg and
4974 check for change against current_mono_font.
4975 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4976 (emacs_settings_constructor, emacs_settings_get_property)
4977 (emacs_settings_set_property, emacs_settings_class_init)
4978 (emacs_settings_init, gsettings_obj): Remove.
4979 (something_changedCB): New function for HAVE_GSETTINGS.
4980 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4981 with value as argument.
4982 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4983 g_settings_new (Bug#8967). Do not create gsettings_obj.
4984 Remove calls to g_settings_bind. Connect something_changedCB to
4985 "changed".
4986
4987 * xgselect.c: Add defined (HAVE_GSETTINGS).
4988 (xgselect_initialize): Ditto.
4989
4990 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4991 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4992 xg_select.
4993
4994 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4995
4996 * eval.c (struct backtrace): Simplify and port the data structure.
4997 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4998 signed bit field, as this assumption is not portable and it makes
4999 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5000 "char debug_on_exit : 1" as this is not portable either; instead,
5001 use the portable "unsigned int debug_on_exit : 1". Remove unused
5002 member evalargs. Remove obsolete comments about cc bombing out.
5003
5004 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5005
5006 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
5007 Let HAVE_GSETTINGS override HAVE_GCONF.
5008 (store_monospaced_changed): New function.
5009 (EMACS_SETTINGS): A new type derived from GObject to handle
5010 GSettings notifications.
5011 (emacs_settings_constructor, emacs_settings_get_property)
5012 (emacs_settings_set_property, emacs_settings_class_init):
5013 New functions.
5014 (gsettings_client, gsettings_obj): New variables.
5015 (GSETTINGS_SCHEMA): New define.
5016 (something_changedCB): Call store_monospaced_changed.
5017 (init_gsettings): New function.
5018 (xsettings_initialize): Call init_gsettings.
5019 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5020 to NULL.
5021
5022 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
5023 GCONF_CFLAGS/LIBS.
5024
5025 2011-06-29 Martin Rudalics <rudalics@gmx.at>
5026
5027 * window.c (resize_root_window, grow_mini_window)
5028 (shrink_mini_window): Rename Qresize_root_window to
5029 Qwindow_resize_root_window and Qresize_root_window_vertically to
5030 Qwindow_resize_root_window_vertically.
5031
5032 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5033
5034 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5035
5036 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
5037
5038 * makefile.w32-in: Redesign dependencies so they reflect more
5039 clearly which files are directly included by each source file,
5040 and not through other includes.
5041
5042 2011-06-27 Martin Rudalics <rudalics@gmx.at>
5043
5044 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5045 (sort_overlays, overlay_strings): When an overlay's clone number
5046 matches the window's clone number process the overlay even if
5047 the overlay's window property doesn't match the current window.
5048
5049 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5050 (Fwindow_hchild): Rename to Fwindow_left_child.
5051 (Fwindow_next): Rename to Fwindow_next_sibling.
5052 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5053 (resize_window_check): Rename to window_resize_check.
5054 (resize_window_apply): Rename to window_resize_apply.
5055 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5056 (Fdelete_other_windows_internal, resize_frame_windows)
5057 (Fsplit_window_internal, Fdelete_window_internal)
5058 (grow_mini_window, shrink_mini_window)
5059 (Fresize_mini_window_internal): Fix callers accordingly.
5060
5061 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5062
5063 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5064 (emacs_fixed_set_min_size): Remove.
5065 (emacs_fixed_new): Take frame as argument.
5066
5067 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5068 (_EmacsFixedPrivate): Remove minwidth/height.
5069 Add struct frame *f.
5070 (emacs_fixed_init): Initialize priv->f.
5071 (get_parent_class, emacs_fixed_set_min_size): Remove.
5072 (emacs_fixed_new): Set priv->f to argument.
5073 (emacs_fixed_get_preferred_width)
5074 (emacs_fixed_get_preferred_height): Use min_width/height from
5075 frames size_hint to set minimum and natural (Bug#8919).
5076 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5077 and use min_width/height from frames size_hint to set
5078 min_width/height (Bug#8919).
5079
5080 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5081 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5082 Fix indentation.
5083
5084 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5085
5086 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5087 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5088 called at ZV.
5089
5090 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5091
5092 * process.c (wait_reading_process_output): Bypass select if
5093 waiting for a cell while ignoring keyboard input, and input is
5094 pending. Suggested by Jan Djärv (Bug#8869).
5095
5096 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5097
5098 Use gnulib's dup2 module instead of rolling our own.
5099 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5100
5101 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5102
5103 * dispnew.c (scrolling_window): Before scrolling, turn off a
5104 mouse-highlight in the window being scrolled.
5105
5106 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5107
5108 Move DEFSYM to lisp.h and use everywhere.
5109
5110 * character.h (DEFSYM): Move declaration...
5111 * lisp.h (DEFSYM): ...here.
5112
5113 * gnutls.c:
5114 * minibuf.c:
5115 * w32menu.c:
5116 * w32proc.c:
5117 * w32select.c: Don't include character.h.
5118
5119 * alloc.c (syms_of_alloc):
5120 * buffer.c (syms_of_buffer):
5121 * bytecode.c (syms_of_bytecode):
5122 * callint.c (syms_of_callint):
5123 * casefiddle.c (syms_of_casefiddle):
5124 * casetab.c (init_casetab_once):
5125 * category.c (init_category_once, syms_of_category):
5126 * ccl.c (syms_of_ccl):
5127 * cmds.c (syms_of_cmds):
5128 * composite.c (syms_of_composite):
5129 * dbusbind.c (syms_of_dbusbind):
5130 * dired.c (syms_of_dired):
5131 * dispnew.c (syms_of_display):
5132 * doc.c (syms_of_doc):
5133 * editfns.c (syms_of_editfns):
5134 * emacs.c (syms_of_emacs):
5135 * eval.c (syms_of_eval):
5136 * fileio.c (syms_of_fileio):
5137 * fns.c (syms_of_fns):
5138 * frame.c (syms_of_frame):
5139 * fringe.c (syms_of_fringe):
5140 * insdel.c (syms_of_insdel):
5141 * keymap.c (syms_of_keymap):
5142 * lread.c (init_obarray, syms_of_lread):
5143 * macros.c (syms_of_macros):
5144 * msdos.c (syms_of_msdos):
5145 * print.c (syms_of_print):
5146 * process.c (syms_of_process):
5147 * search.c (syms_of_search):
5148 * sound.c (syms_of_sound):
5149 * syntax.c (init_syntax_once, syms_of_syntax):
5150 * terminal.c (syms_of_terminal):
5151 * textprop.c (syms_of_textprop):
5152 * undo.c (syms_of_undo):
5153 * w32.c (globals_of_w32):
5154 * window.c (syms_of_window):
5155 * xdisp.c (syms_of_xdisp):
5156 * xfaces.c (syms_of_xfaces):
5157 * xfns.c (syms_of_xfns):
5158 * xmenu.c (syms_of_xmenu):
5159 * xsettings.c (syms_of_xsettings):
5160 * xterm.c (syms_of_xterm): Use DEFSYM.
5161
5162 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5163
5164 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5165
5166 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5167
5168 Integer and buffer overflow fixes (Bug#8873).
5169
5170 * print.c (printchar, strout): Check for string overflow.
5171 (PRINTPREPARE, printchar, strout):
5172 Don't set size unless allocation succeeds.
5173
5174 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5175 for sizes. Check for string overflow more accurately.
5176 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5177
5178 * macros.c: Integer and buffer overflow fixes.
5179 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5180 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5181 Use ptrdiff_t, not int, for sizes.
5182 Don't increment bufsize until after realloc succeeds.
5183 Check for size-calculation overflow.
5184 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5185
5186 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5187
5188 * lread.c: Integer overflow fixes.
5189 (read_integer): Radix is now EMACS_INT, not int,
5190 to improve quality of diagnostics for out-of-range radices.
5191 Calculate buffer size correctly for out-of-range radices.
5192 (read1): Check for integer overflow in radices, and in
5193 read-circle numbers.
5194 (read_escape): Avoid int overflow.
5195 (Fload, openp, read_buffer_size, read1)
5196 (substitute_object_recurse, read_vector, read_list, map_obarray):
5197 Use ptrdiff_t, not int, for sizes.
5198 (read1): Use EMACS_INT, not int, for sizes.
5199 Check for size overflow.
5200
5201 * image.c (cache_image): Check for size arithmetic overflow.
5202
5203 * lread.c: Integer overflow issues.
5204 (saved_doc_string_size, saved_doc_string_length)
5205 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5206 Now ptrdiff_t, not int.
5207 (read1): Don't assume doc string length fits in int. Check for
5208 out-of-range doc string lengths.
5209 (read_list): Don't assume file position fits in int.
5210 (read_escape): Check for hex character overflow.
5211
5212 2011-06-22 Leo Liu <sdl.web@gmail.com>
5213
5214 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5215 Move to minibuffer.el.
5216
5217 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5218
5219 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5220 The following patches are for when GLYPH_DEBUG && !XASSERT.
5221 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5222 * dispnew.c (flush_stdout):
5223 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5224 Mark as externally visible.
5225 * dispnew.c (check_window_matrix_pointers): Now static.
5226 * dispnew.c (window_to_frame_vpos):
5227 * xfns.c (unwind_create_frame):
5228 * xterm.c (x_check_font): Remove unused local.
5229 * scroll.c (CHECK_BOUNDS):
5230 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5231 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5232 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5233 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5234 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5235 Now static.
5236 (debug_method_add): Use va_list and vsprintf rather than relying
5237 on undefined behavior with wrong number of arguments.
5238 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5239 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5240 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5241 since we're not interested in debugging glyphs with old libraries.
5242 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5243 GCC 4.6.0's static checking.
5244
5245 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5246
5247 Integer overflow and signedness fixes (Bug#8873).
5248 A few related buffer overrun fixes, too.
5249
5250 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5251
5252 * dispextern.h (struct face.stipple):
5253 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5254 (x_bitmap_mask, x_allocate_bitmap_record)
5255 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5256 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5257 (x_create_bitmap_from_xpm_data):
5258 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5259 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5260 (.bitmaps_last):
5261 * xfaces.c (load_pixmap):
5262 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5263 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5264 (.bitmaps_last, struct x_output.icon_bitmap):
5265 Use ptrdiff_t, not int, for bitmap indexes.
5266 (x_allocate_bitmap_record): Check for size overflow.
5267 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5268
5269 Use ptrdiff_t, not int, for overlay counts.
5270 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5271 * editfns.c (overlays_around, get_pos_property):
5272 * textprop.c (get_char_property_and_overlay):
5273 * xdisp.c (next_overlay_change, note_mouse_highlight):
5274 * xfaces.c (face_at_buffer_position):
5275 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5276 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5277 (Fnext_overlay_change, Fprevious_overlay_change)
5278 (mouse_face_overlay_overlaps, Foverlays_in):
5279 Use ptrdiff_t, not int, for sizes.
5280 (overlays_at, overlays_in): Check for size-calculation overflow.
5281
5282 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5283
5284 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5285 (x_session_initialize): Do not assume string length fits in int.
5286
5287 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5288 This is unlikely, but can occur if DPI is outlandish.
5289
5290 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5291 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5292
5293 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5294 * xrdb.c (magic_file_p, search_magic_path):
5295 Omit last arg SUFFIX; it was always 0. All callers changed.
5296 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5297
5298 * xfont.c (xfont_match): Avoid need for strlen.
5299
5300 * xfns.c: Don't assume strlen fits in int.
5301 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5302
5303 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5304 not unsigned long, as we prefer signed integers. All callers changed.
5305 Detect integer overflow in repeat count.
5306 (message_dolog): Don't assume print length fits in 39 bytes.
5307 (display_mode_element): Don't assume strlen fits in int.
5308
5309 * termcap.c: Don't assume sizes fit in int and never overflow.
5310 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5311 (gobble_line): Check for size-calculation overflow.
5312
5313 * minibuf.c (Fread_buffer):
5314 * lread.c (intern, intern_c_string):
5315 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5316 Don't assume string length fits in int.
5317
5318 * keyboard.c (parse_tool_bar_item):
5319 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5320
5321 * font.c: Don't assume string length fits in int.
5322 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5323 Use ptrdiff_t, not int.
5324 (font_intern_prop): Don't assume string length fits in int.
5325 Don't assume integer property fits in fixnum.
5326 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5327
5328 * filelock.c: Fix some buffer overrun and integer overflow issues.
5329 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5330 Reformulate so as not to need the command string.
5331 Invoke gzip -cd rather than gunzip, as it's more portable.
5332 (lock_info_type, lock_file_1, lock_file):
5333 Don't assume pid_t and time_t fit in unsigned long.
5334 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5335 (current_lock_owner): Prefer signed type for sizes.
5336 Use memcpy, not strncpy, where memcpy is what is really wanted.
5337 Don't assume (via atoi) that time_t and pid_t fit in int.
5338 Check for time_t and/or pid_t out of range, e.g., via a network share.
5339 Don't alloca where an auto var works fine.
5340
5341 * fileio.c: Fix some integer overflow issues.
5342 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5343 Don't assume string length fits in int.
5344 (directory_file_name): Don't assume string length fits in long.
5345 (make_temp_name): Don't assume pid fits in int, or that its print
5346 length is less than 20.
5347
5348 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5349
5350 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5351
5352 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5353
5354 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5355 We prefer signed integers, even for size calculations.
5356
5357 * emacs.c: Don't assume string length fits in 'int'.
5358 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5359 (main): Don't invoke strlen when not needed.
5360
5361 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5362 (XD_DEBUG_MESSAGE): Don't waste a byte.
5363
5364 * callproc.c (getenv_internal_1, getenv_internal)
5365 (Fgetenv_internal):
5366 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5367
5368 * lread.c (invalid_syntax): Omit length argument.
5369 All uses changed. This doesn't fix a bug, but it simplifies the
5370 code away from its former Hollerith-constant appearance, and it's
5371 one less 'int' to worry about when looking at integer-overflow issues.
5372 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5373
5374 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5375 This didn't break anything, but it didn't help either.
5376 It's confusing to put a bogus integer in a place where the actual
5377 value does not matter.
5378 (LIST_END_P): Remove unused macro and its bogus comment.
5379 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5380
5381 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5382 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5383 implementation.
5384 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5385 We prefer signed types, and the value cannot exceed the EMACS_INT
5386 range anyway (because otherwise the length would not be representable).
5387 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5388 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5389 This avoids a GCC warning when WIDE_EMACS_INT.
5390
5391 * indent.c (sane_tab_width): New function.
5392 (current_column, scan_for_column, Findent_to, position_indentation)
5393 (compute_motion): Use it. This is just for clarity.
5394 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5395
5396 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5397
5398 * lisp.h (lint_assume): New macro.
5399 * composite.c (composition_gstring_put_cache):
5400 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5401
5402 * editfns.c, insdel.c:
5403 Omit unnecessary forward decls, to simplify future changes.
5404
5405 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5406
5407 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5408
5409 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5410 Use much-faster test for byte-length change.
5411 Don't assume string byte-length fits in 'int'.
5412 Check that character arg fits in 'int'.
5413 (mapcar1): Declare byte as byte, for clarity.
5414
5415 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5416
5417 * fns.c (concat): Catch string overflow earlier.
5418 Do not rely on integer wraparound.
5419
5420 * dispextern.h (struct it.overlay_strings_charpos)
5421 (struct it.selective): Now EMACS_INT, not int.
5422 * xdisp.c (forward_to_next_line_start)
5423 (back_to_previous_visible_line_start)
5424 (reseat_at_next_visible_line_start, next_element_from_buffer):
5425 Don't arbitrarily truncate the value of 'selective' to int.
5426
5427 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5428
5429 * composite.c: Don't truncate sizes to 'int'.
5430 (composition_gstring_p, composition_reseat_it)
5431 (composition_adjust_point): Use EMACS_INT, not int.
5432 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5433 not EMACS_UINT, for indexes.
5434
5435 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5436
5437 * buffer.c: Include <verify.h>.
5438 (struct sortvec.priority, struct sortstr.priority):
5439 Now EMACS_INT, not int.
5440 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5441 (struct sortstr.size, record_overlay_string)
5442 (struct sortstrlist.size, struct sortlist.used):
5443 Don't truncate size to int.
5444 (record_overlay_string): Check for size-calculation overflow.
5445 (init_buffer_once): Check at compile-time, not run-time.
5446
5447 2011-06-22 Jim Meyering <meyering@redhat.com>
5448
5449 Don't leak an XBM-image-sized buffer
5450 * image.c (xbm_load): Free the image buffer after using it.
5451
5452 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5453
5454 Port to Sun C.
5455 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5456 that Sun C diagnosed.
5457 * fns.c (secure_hash): Fix pointer signedness issue.
5458 * intervals.c (static_offset_intervals): New function.
5459 (offset_intervals): Use it.
5460
5461 2011-06-21 Leo Liu <sdl.web@gmail.com>
5462
5463 * deps.mk (fns.o):
5464 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5465 sha512.h.
5466
5467 * fns.c (secure_hash): Rename from crypto_hash_function and change
5468 the first arg to accept symbols.
5469 (Fsecure_hash): New primitive.
5470 (syms_of_fns): New symbols.
5471
5472 2011-06-20 Deniz Dogan <deniz@dogan.se>
5473
5474 * process.c (Fset_process_buffer): Clarify return value in
5475 docstring.
5476
5477 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5478
5479 * dispnew.c (add_window_display_history): Use BVAR.
5480
5481 * xdisp.c (debug_method_add): Use BVAR.
5482 (check_window_end, dump_glyph_matrix, dump_glyph)
5483 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5484
5485 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5486 Likewise.
5487
5488 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5489 check till after the cache is created in init_frame_faces.
5490
5491 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5492
5493 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5494
5495 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5496
5497 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5498 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5499 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5500
5501 Improve buffer-overflow checking (Bug#8873).
5502 * fileio.c (Finsert_file_contents):
5503 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5504 Remove the old (too-loose) buffer overflow checks.
5505 They weren't needed, since make_gap checks for buffer overflow.
5506 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5507 The old code merely checked for Emacs fixnum overflow, and relied
5508 on undefined (wraparound) behavior. The new code avoids undefined
5509 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5510
5511 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5512 Tune. Don't use wider integers than needed. Don't use alloca.
5513 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5514
5515 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5516
5517 * insdel.c, lisp.h (buffer_overflow): New function.
5518 (insert_from_buffer_1, replace_range, replace_range_2):
5519 * insdel.c (make_gap_larger):
5520 * editfns.c (Finsert_char):
5521 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5522
5523 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5524
5525 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5526
5527 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5528
5529 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5530 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5531
5532 * fileio.c: Don't assume EMACS_INT fits in off_t.
5533 (emacs_lseek): New static function.
5534 (Finsert_file_contents, Fwrite_region): Use it.
5535 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5536
5537 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5538
5539 * fns.c: Don't overflow int when computing a list length.
5540 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5541 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5542 truncation on 64-bit hosts. Check for QUIT every
5543 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5544 faster and is responsive enough.
5545 (Flength): Report an error instead of overflowing an integer.
5546 (Fsafe_length): Return a float if the value is not representable
5547 as a fixnum. This shouldn't happen except in contrived situations.
5548 (Fnthcdr, Fsort): Don't assume list length fits in int.
5549 (Fcopy_sequence): Don't assume vector length fits in int.
5550
5551 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5552 (header_size, word_size): New constants.
5553 (allocate_vectorlike): Don't check size overflow here.
5554 (allocate_vector): Check it here instead, since this is the only
5555 caller of allocate_vectorlike that could cause overflow.
5556 Check that the new vector's length is representable as a fixnum.
5557
5558 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5559 The previous code was bogus. For example, next_almost_prime (32)
5560 returned 39, which is undesirable as it is a multiple of 3; and
5561 next_almost_prime (24) returned 25, which is a multiple of 5 so
5562 why was the code bothering to check for multiples of 7?
5563
5564 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5565
5566 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5567
5568 Variadic C functions now count arguments with ptrdiff_t.
5569 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5570 Back then I didn't know that the Emacs coding style prefers signed int.
5571 Also, in the meantime I found a few more instances where arguments
5572 were being counted with int, which may truncate counts on 64-bit
5573 machines, or EMACS_INT, which may be unnecessarily wide.
5574 * lisp.h (struct Lisp_Subr.function.aMANY)
5575 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5576 Arg counts are now ptrdiff_t, not size_t.
5577 All variadic functions and their callers changed accordingly.
5578 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5579 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5580 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5581 * callint.c (Fcall_interactively): Check arg count for overflow,
5582 to avoid potential buffer overrun. Use signed char, not 'int',
5583 for 'varies' array, so that we needn't bother to check its size
5584 calculation for overflow.
5585 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5586 * eval.c (apply_lambda):
5587 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5588 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5589 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5590
5591 * callint.c (Fcall_interactively): Don't use index var as event count.
5592
5593 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5594 * mem-limits.h (SIZE): Remove; no longer used.
5595
5596 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5597
5598 Remove unnecessary casts.
5599 * xterm.c (x_term_init):
5600 * xfns.c (x_set_border_pixel):
5601 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5602 These aren't needed now that we assume ANSI C.
5603
5604 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5605 It's more likely to cause problems (due to unsigned overflow)
5606 than to cure them.
5607
5608 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5609
5610 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5611
5612 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5613
5614 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5615
5616 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5617
5618 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5619
5620 GLYPH_CODE_FACE returns EMACS_INT, not int.
5621 * dispextern.h (merge_faces):
5622 * xfaces.c (merge_faces):
5623 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5624 Don't assume EMACS_INT fits in int.
5625
5626 * character.h (CHAR_VALID_P): Remove unused parameter.
5627 * fontset.c, lisp.h, xdisp.c: All uses changed.
5628
5629 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5630
5631 * fns.c (concat): Minor tuning based on overflow analysis.
5632 This doesn't fix any bugs. Use int to hold character, instead
5633 of constantly refetching from Emacs object. Use XFASTINT, not
5634 XINT, for value known to be a character. Don't bother comparing
5635 a single byte to 0400, as it's always less.
5636
5637 * floatfns.c (Fexpt):
5638 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5639
5640 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5641 for characters.
5642
5643 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5644
5645 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5646 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5647 incorrectly succeed when S was a string, because 4294967386 was
5648 truncated before it was used.
5649
5650 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5651 Otherwise, an out-of-range integer could cause undefined behavior
5652 on a 64-bit host.
5653
5654 * composite.c: Use int, not EMACS_INT, for characters.
5655 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5656 EMACS_INT, for values that are known to be in character range.
5657 This doesn't fix any bugs but is the usual style inside Emacs and
5658 may generate better code on 32-bit machines.
5659
5660 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5661 This is for reasons similar to the recent CHAR_STRING fix.
5662 * charset.c (Fencode_char): Check that character arg is actually
5663 a character. Pass an int to ENCODE_CHAR.
5664 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5665 wider than 'int', as a compile-time check to prevent future regressions
5666 in this area.
5667
5668 * character.c (char_string): Remove unnecessary casts.
5669
5670 Make sure a 64-bit char is never passed to CHAR_STRING.
5671 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5672 by silently ignoring the top 32 bits, allowing some values
5673 that were far too large to be valid characters.
5674 * character.h: Include <verify.h>.
5675 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5676 arguments are no wider than unsigned, as a compile-time check
5677 to prevent future regressions in this area.
5678 * data.c (Faset):
5679 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5680 (Fsubst_char_in_region):
5681 * fns.c (concat):
5682 * xdisp.c (decode_mode_spec_coding):
5683 Adjust to CHAR_STRING's new requirement.
5684 * editfns.c (Finsert_char, Fsubst_char_in_region):
5685 * fns.c (concat): Check that character args are actually
5686 characters. Without this test, these functions did the wrong
5687 thing with wildly out-of-range values on 64-bit hosts.
5688
5689 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5690 These casts should not be needed on 32-bit hosts, either.
5691 * keyboard.c (read_char):
5692 * lread.c (Fload): Remove casts to unsigned.
5693
5694 * lisp.h (UNSIGNED_CMP): New macro.
5695 This fixes comparison bugs on 64-bit hosts.
5696 (ASCII_CHAR_P): Use it.
5697 * casefiddle.c (casify_object):
5698 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5699 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5700 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5701 * dispextern.h (FACE_FROM_ID):
5702 * keyboard.c (read_char): Use UNSIGNED_CMP.
5703
5704 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5705 not to EMACS_INT, to avoid GCC warning.
5706
5707 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5708
5709 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5710 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5711 isn't needed on 32-bit machines.
5712
5713 * buffer.c (Fgenerate_new_buffer_name):
5714 Use EMACS_INT for count, not int.
5715 (advance_to_char_boundary): Return EMACS_INT, not int.
5716
5717 * data.c (Qcompiled_function): Now static.
5718
5719 * window.c (window_body_lines): Now static.
5720
5721 * image.c (gif_load): Rename local to avoid shadowing.
5722
5723 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5724 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5725 * alloc.c (make_save_value): Integer argument is now of type
5726 ptrdiff_t, not int.
5727 (mark_object): Use ptrdiff_t, not int.
5728 * lisp.h (pD): New macro.
5729 * print.c (print_object): Use it.
5730
5731 * alloc.c: Use EMACS_INT, not int, to count objects.
5732 (total_conses, total_markers, total_symbols, total_vector_size)
5733 (total_free_conses, total_free_markers, total_free_symbols)
5734 (total_free_floats, total_floats, total_free_intervals)
5735 (total_intervals, total_strings, total_free_strings):
5736 Now EMACS_INT, not int. All uses changed.
5737 (Fgarbage_collect): Compute overall total using a double, so that
5738 integer overflow is less likely to be a problem. Check for overflow
5739 when converting back to an integer.
5740 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5741 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5742 These were 'int' variables that could overflow on 64-bit hosts;
5743 they were never used, so remove them instead of repairing them.
5744 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5745 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5746 Previously, this ceilinged at INT_MAX, but that doesn't work on
5747 64-bit machines.
5748 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5749
5750 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5751 (allocate_vectorlike): Check for ptrdiff_t overflow.
5752 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5753 when a (possibly-narrower) signed value would do just as well.
5754 We prefer using signed arithmetic, to avoid comparison confusion.
5755
5756 * alloc.c: Catch some string size overflows that we were missing.
5757 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5758 for convenience in STRING_BYTES_MAX.
5759 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5760 The definition here is exact; the one in lisp.h was approximate.
5761 (allocate_string_data): Check for string overflow. This catches
5762 some instances we weren't catching before. Also, it catches
5763 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5764 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5765 and ptrdiff_t and EMACS_INT are both 64 bits.
5766
5767 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5768 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5769 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5770
5771 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5772
5773 * alloc.c (Fmake_string): Check for out-of-range init.
5774
5775 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5776
5777 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5778
5779 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5780
5781 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5782 xg_get_default_scrollbar_width.
5783
5784 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5785 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5786 (style_changed_cb): Call update_theme_scrollbar_width and call
5787 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5788 all frames (Bug#8505).
5789 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5790 Call gtk_window_set_resizable if HAVE_GTK3.
5791 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5792 and height if HAVE_GTK3 (Bug#8505).
5793 (scroll_bar_width_for_theme): New variable.
5794 (update_theme_scrollbar_width): New function.
5795 (xg_get_default_scrollbar_width): Move code to
5796 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5797 (xg_initialize): Call update_theme_scrollbar_width.
5798
5799 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5800
5801 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5802
5803 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5804
5805 * frame.c (make_frame): Call other_buffer_safely instead of
5806 other_buffer.
5807
5808 * window.c (temp_output_buffer_show): Call display_buffer with
5809 second argument Vtemp_buffer_show_specifiers and reset latter
5810 immediately after the call.
5811 (Vtemp_buffer_show_specifiers): New variable.
5812 (auto_window_vscroll_p, next_screen_context_lines)
5813 (Vscroll_preserve_screen_position): Remove leading asterisks from
5814 doc-strings.
5815
5816 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5817
5818 Fix minor problems found by GCC 4.6.0 static checking.
5819 * buffer.c (Qclone_number): Remove for now, as it's unused.
5820 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5821 (record_buffer): Remove unused local.
5822 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5823 (set_frame_buffer_list): Remove; unused.
5824 * frame.h (other_visible_frames): Remove decl.
5825 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5826 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5827 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5828 if HAVE_GPM.
5829 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5830 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5831 Define only if HAVE_GPM.
5832 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5833 (update_hints_inhibit): Remove; never set. All uses removed.
5834 * widgetprv.h (emacsFrameClassRec): Remove decl.
5835 * window.c (delete_deletable_window): Now returns void, since it
5836 wasn't returning anything.
5837 (compare_window_configurations): Remove unused locals.
5838 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5839 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5840 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5841 the same widths as pointers. This follows up on the 2011-05-06 patch.
5842 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5843 * xterm.h: Likewise.
5844 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5845
5846 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5847
5848 * makefile.w32-in: Update dependencies.
5849 (LISP_H): Add lib/intprops.h.
5850
5851 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5852
5853 * image.c (gif_load): Add animation frame delay to the metadata.
5854 (syms_of_image): Use DEFSYM. New symbol `delay'.
5855
5856 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5857
5858 * window.c (delete_deletable_window): Re-add.
5859 (Fset_window_configuration): Rewrite to handle dead buffers and
5860 consequently deletable windows.
5861 (window_tree, Fwindow_tree): Remove. Supply functionality in
5862 window.el.
5863 (compare_window_configurations): Simplify code.
5864
5865 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5866
5867 * image.c (imagemagick_load_image): Fix type mismatch.
5868 (Fimagemagick_types): Likewise.
5869
5870 * window.h (replace_buffer_in_windows): Declare.
5871
5872 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5873
5874 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5875 Qclone_number. Remove external declaration of Qdelete_window.
5876 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5877 code.
5878 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5879 Run Qbuffer_list_update_hook if allowed.
5880 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5881 buffer list implementation.
5882 (other_buffer_safely): New function.
5883 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5884 calls to replace_buffer_in_windows and
5885 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5886 if allowed.
5887 (record_buffer): Inhibit quitting and rewrite using quittable
5888 functions. Run Qbuffer_list_update_hook if allowed.
5889 (Frecord_buffer, Funrecord_buffer): New functions.
5890 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5891 Move switch-to-buffer to window.el.
5892 (bury-buffer): Move to window.el.
5893 (Vbuffer_list_update_hook): New variable.
5894
5895 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5896 section.
5897
5898 * window.h (resize_frame_windows): Move up in code.
5899 (Fwindow_frame): Remove EXFUN.
5900 (replace_buffer_in_all_windows): Remove prototype.
5901 (replace_buffer_in_windows_safely): Add prototype.
5902
5903 * window.c: Declare Qdelete_window static again. Move down
5904 declaration of select_count.
5905 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5906 (Fother_window): Move to window.el.
5907 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5908 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5909 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5910 window.el.
5911 (replace_buffer_in_windows): Implement by calling
5912 Qreplace_buffer_in_windows.
5913 (replace_buffer_in_all_windows): Remove with some functionality
5914 moved into replace_buffer_in_windows_safely.
5915 (replace_buffer_in_windows_safely): New function.
5916 (select_window_norecord, select_frame_norecord): Move in front
5917 of run_window_configuration_change_hook. Remove now obsolete
5918 declarations.
5919 (Fset_window_buffer): Rewrite doc-string.
5920 Call Qrecord_window_buffer.
5921 (keys_of_window): Move binding for other-window to window.el.
5922
5923 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5924
5925 * dispextern.h (struct image): Replace data member, whose int_val
5926 and ptr_val fields were not used by anything, with a single
5927 lisp_val object.
5928
5929 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5930 (gif_clear_image, gif_load, imagemagick_load_image)
5931 (gs_clear_image, gs_load): Callers changed.
5932
5933 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5934
5935 * buffer.h: Include <time.h>, for time_t.
5936 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5937
5938 Fix minor problems found by static checking.
5939
5940 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5941
5942 Make identifiers static if they are not used in other modules.
5943 * data.c (Qcompiled_function, Qframe, Qvector):
5944 * image.c (QimageMagick, Qsvg):
5945 * minibuf.c (Qmetadata):
5946 * window.c (resize_window_check, resize_root_window): Now static.
5947 * window.h (resize_window_check, resize_root_window): Remove decls.
5948
5949 * window.c (window_deletion_count, delete_deletable_window):
5950 Remove; unused.
5951 (window_body_lines): Now static.
5952 (Fdelete_other_windows_internal): Mark vars as initialized.
5953 Make sure 'resize_failed' is initialized.
5954 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5955 (resize_window_apply): Remove unused local.
5956 * window.h (delete_deletable_window): Remove decl.
5957
5958 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5959 (imagemagick_load_image): Fix pointer signedness problem by changing
5960 last arg from unsigned char * to char *. All uses changed.
5961 Also, fix a local for similar reasons.
5962 Remove unused locals. Remove locals to avoid shadowing.
5963 (fn_rsvg_handle_free): Remove; unused.
5964 (svg_load, svg_load_image): Fix pointer signedness problem.
5965 (imagemagick_load_image): Don't use garbage pointer image_wand.
5966
5967 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5968
5969 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5970
5971 * image.c (gif_load): Fix omitted cast error introduced by
5972 2011-06-06 change.
5973
5974 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5975
5976 * window.h (resize_proportionally, orig_total_lines)
5977 (orig_top_line): Remove from window structure.
5978 (set_window_height, set_window_width, change_window_heights)
5979 (Fdelete_window): Remove prototypes.
5980 (resize_frame_windows): Remove duplicate declaration.
5981
5982 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5983
5984 * window.h (resize_frame_windows, resize_window_check)
5985 (delete_deletable_window, resize_root_window)
5986 (resize_frame_windows): Declare prototypes.
5987
5988 * window.c (resize_window_apply): Make definition be "static" to
5989 match the prototype.
5990
5991 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5992
5993 * window.c: Remove declarations of Qwindow_size_fixed,
5994 window_min_size_1, window_min_size_2, window_min_size,
5995 size_window, window_fixed_size_p, enlarge_window, delete_window.
5996 Remove static from declaration of Qdelete_window, it's
5997 temporarily needed by Fbury_buffer.
5998 (replace_window): Don't assign orig_top_line and
5999 orig_total_lines.
6000 (Fdelete_window, delete_window): Remove. Window deletion is
6001 handled by window.el.
6002 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6003 Replace Fdelete_window calls with calls to Qdelete_window.
6004 (Fdelete_other_windows): Remove. Deleting other windows is
6005 handled by window.el.
6006 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6007 handled in window.el.
6008 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6009 Window minimum sizes are handled in window.el.
6010 (shrink_windows, size_window, set_window_height)
6011 (set_window_width, change_window_heights, window_height)
6012 (window_width, CURBEG, CURSIZE, enlarge_window)
6013 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6014 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6015 handled in window.el.
6016 (make_dummy_parent): Rename to make_parent_window and give it a
6017 second argument horflag.
6018 (make_window): Don't set resize_proportionally any more.
6019 (Fsplit_window): Remove. Windows are split in window.el.
6020 (save_restore_action, save_restore_orig_size)
6021 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6022 Resize mini windows in window.el.
6023 (grow_mini_window, shrink_mini_window): Implement by calling
6024 Qresize_root_window_vertically, resize_window_check and
6025 resize_window_apply.
6026 (saved_window, Fset_window_configuration, save_window_save):
6027 Do not handle orig_top_line, orig_total_lines, and
6028 resize_proportionally.
6029 (window_min_height, window_min_width): Move to window.el.
6030 (keys_of_window): Move bindings for delete-other-windows,
6031 split-window, delete-window and enlarge-window to window.el.
6032
6033 * buffer.c: Temporarily extern Qdelete_window.
6034 (Fbury_buffer): Temporarily call Qdelete_window instead of
6035 Fdelete_window (Fbury_buffer will move to window.el soon).
6036
6037 * frame.c (set_menu_bar_lines_1): Remove code handling
6038 orig_top_line and orig_total_lines.
6039
6040 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6041 set_window_height but set heights directly.
6042 (change_frame_size_1): Use resize_frame_windows.
6043
6044 * xdisp.c (init_xdisp): Don't use set_window_height but set
6045 heights directly.
6046
6047 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6048 Use resize_frame_windows instead of change_window_heights and run
6049 run_window_configuration_change_hook.
6050
6051 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6052 instead of change_window_heights and run
6053 run_window_configuration_change_hook.
6054
6055 2011-06-09 Martin Rudalics <rudalics@gmx.at>
6056
6057 * window.c (replace_window): Rename second argument REPLACEMENT to
6058 NEW. New third argument SETFLAG. Rewrite.
6059 (delete_window, make_dummy_parent): Call replace_window with
6060 third argument 1.
6061 (window_list_1): Move down in code.
6062 (run_window_configuration_change_hook): Move set_buffer part
6063 before select_frame_norecord part in order to unwind correctly.
6064 Rename count1 to count.
6065 (recombine_windows, delete_deletable_window, resize_root_window)
6066 (Fdelete_other_windows_internal)
6067 (Frun_window_configuration_change_hook, make_parent_window)
6068 (resize_window_check, resize_window_apply, Fresize_window_apply)
6069 (resize_frame_windows, Fsplit_window_internal)
6070 (Fdelete_window_internal, Fresize_mini_window_internal):
6071 New functions.
6072 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6073
6074 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6075
6076 * window.h (window): Add some new members to window structure -
6077 normal_lines, normal_cols, new_total, new_normal, clone_number,
6078 splits, nest, prev_buffers, next_buffers.
6079 (WINDOW_TOTAL_SIZE): Move here from window.c.
6080 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6081
6082 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6083 Remove.
6084 (make_dummy_parent): Set new members of windows structure.
6085 (make_window): Move down in code. Handle new members of window
6086 structure.
6087 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6088 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6089 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6090 (Fset_window_prev_buffers, Fwindow_next_buffers)
6091 (Fset_window_next_buffers, Fset_window_clone_number):
6092 New functions.
6093 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6094 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6095 Doc-string fixes.
6096 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6097 Argument WINDOW can be now internal window too.
6098 (Fwindow_use_time): Move up in code.
6099 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6100 Rewrite doc-string.
6101 (Fset_window_configuration, saved_window)
6102 (Fcurrent_window_configuration, save_window_save): Handle new
6103 members of window structure.
6104 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6105 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6106 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6107 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6108 Qget_mru_window, Qresize_root_window,
6109 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6110 Qauto_buffer_name; staticpro them.
6111
6112 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6113
6114 * window.c (Fwindow_total_size, Fwindow_left_column)
6115 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6116 (Fwindow_list_1): New functions.
6117 (window_box_text_cols): Replace with window_body_cols.
6118 (Fwindow_width, Fscroll_left, Fscroll_right):
6119 Use window_body_cols instead of window_box_text_cols.
6120 (delete_window, Fset_window_configuration):
6121 Call delete_all_subwindows with window as argument.
6122 (delete_all_subwindows): Take a window as argument and not a
6123 structure. Rewrite.
6124 (window_loop): Remove handling of GET_LRU_WINDOW and
6125 GET_LARGEST_WINDOW.
6126 (Fget_lru_window, Fget_largest_window): Move to window.el.
6127
6128 * window.h: Extern window_body_cols instead of
6129 window_box_text_cols. delete_all_subwindows now takes a
6130 Lisp_Object as argument.
6131
6132 * indent.c (compute_motion, Fcompute_motion):
6133 Use window_body_cols instead of window_box_text_cols.
6134
6135 * frame.c (delete_frame): Call delete_all_subwindows with root
6136 window as argument.
6137
6138 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6139
6140 * fns.c (Fputhash): Document return value.
6141
6142 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6143
6144 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6145
6146 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6147
6148 Cons<->int and similar integer overflow fixes (Bug#8794).
6149
6150 Check for overflow when converting integer to cons and back.
6151 * charset.c (Fdefine_charset_internal, Fdecode_char):
6152 Use cons_to_unsigned to catch overflow.
6153 (Fencode_char): Use INTEGER_TO_CONS.
6154 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6155 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6156 * data.c (long_to_cons, cons_to_long): Remove.
6157 (cons_to_unsigned, cons_to_signed): New functions.
6158 These signal an error for invalid or out-of-range values.
6159 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6160 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6161 * font.c (Ffont_variation_glyphs):
6162 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6163 * lisp.h: Include <intprops.h>.
6164 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6165 (cons_to_signed, cons_to_unsigned): New decls.
6166 (long_to_cons, cons_to_long): Remove decls.
6167 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6168 (Fprimitive_undo): Use CONS_TO_INTEGER.
6169 * xfns.c (Fx_window_property): Likewise.
6170 * xselect.c: Include <limits.h>.
6171 (x_own_selection, selection_data_to_lisp_data):
6172 Use INTEGER_TO_CONS.
6173 (x_handle_selection_request, x_handle_selection_clear)
6174 (x_get_foreign_selection, Fx_disown_selection_internal)
6175 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6176 (lisp_data_to_selection_data): Use cons_to_unsigned.
6177 (x_fill_property_data): Use cons_to_signed.
6178 Report values out of range.
6179
6180 Check for buffer and string overflow more precisely.
6181 * buffer.h (BUF_BYTES_MAX): New macro.
6182 * lisp.h (STRING_BYTES_MAX): New macro.
6183 * alloc.c (Fmake_string):
6184 * character.c (string_escape_byte8):
6185 * coding.c (coding_alloc_by_realloc):
6186 * doprnt.c (doprnt):
6187 * editfns.c (Fformat):
6188 * eval.c (verror):
6189 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6190 since they may not be the same number.
6191 * editfns.c (Finsert_char):
6192 * fileio.c (Finsert_file_contents):
6193 Likewise for BUF_BYTES_MAX.
6194
6195 * image.c: Use ptrdiff_t, not int, for sizes.
6196 (slurp_file): Switch from int to ptrdiff_t.
6197 All uses changed.
6198 (slurp_file): Check that file size fits in both size_t (for
6199 malloc) and ptrdiff_t (for sanity and safety).
6200
6201 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6202 if b->modtime has its maximal value.
6203
6204 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6205
6206 Don't assume time_t can fit into int.
6207 * buffer.h (struct buffer.modtime): Now time_t, not int.
6208 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6209 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6210
6211 Minor fixes for signed vs unsigned integers.
6212 * character.h (MAYBE_UNIFY_CHAR):
6213 * charset.c (maybe_unify_char):
6214 * keyboard.c (read_char, reorder_modifiers):
6215 XINT -> XFASTINT, since the integer must be nonnegative.
6216 * ftfont.c (ftfont_spec_pattern):
6217 * keymap.c (access_keymap, silly_event_symbol_error):
6218 XUINT -> XFASTINT, since the integer must be nonnegative.
6219 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6220 since it makes no difference and we prefer signed.
6221 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6222 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6223 nonnegative.
6224
6225 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6226
6227 * window.h (Fwindow_frame): Declare.
6228
6229 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6230
6231 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6232 (SPARE_MEMORY): Always define.
6233 (LARGE_REQUEST): Remove.
6234 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6235
6236 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6237
6238 * lisp.h: Move EXFUNS for Fframe_root_window,
6239 Fframe_first_window and Fset_frame_selected_window to window.h.
6240
6241 * window.h: Move EXFUNS for Fframe_root_window,
6242 Fframe_first_window and Fset_frame_selected_window here from
6243 lisp.h.
6244
6245 * frame.c (Fwindow_frame, Fframe_first_window)
6246 (Fframe_root_window, Fframe_selected_window)
6247 (Fset_frame_selected_window): Move to window.c.
6248 (Factive_minibuffer_window): Move to minibuf.c.
6249 (Fother_visible_frames_p): New function.
6250
6251 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6252
6253 * window.c (decode_window, decode_any_window): Move up in code.
6254 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6255 (inhibit_frame_unsplittable): Remove unused variable.
6256 (Fwindow_buffer): Move up and rewrite doc-string.
6257 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6258 (Fwindow_prev): New functions.
6259 (Fwindow_frame): Move here from frame.c. Accept any window as
6260 argument.
6261 (Fframe_root_window, Fframe_first_window)
6262 (Fframe_selected_window): Move here from frame.c. Accept frame
6263 or arbitrary window as argument. Update doc-strings.
6264 (Fminibuffer_window): Move up in code.
6265 (Fwindow_minibuffer_p): Move up in code and simplify.
6266 (Fset_frame_selected_window): Move here from frame.c.
6267 Marginal rewrite.
6268 (Fselected_window, select_window, Fselect_window): Move up in
6269 code. Minor doc-string fixes.
6270
6271 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6272
6273 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6274 Do not assume that spare memory exists; that assumption is valid
6275 only if SYSTEM_MALLOC.
6276 (LARGE_REQUEST): New macro, so that the issue of large requests
6277 is separated from the issue of spare memory.
6278
6279 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6280
6281 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6282 format. (Bug#8806)
6283
6284 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6285
6286 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6287 before statements.
6288
6289 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6290
6291 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6292
6293 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6294
6295 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6296 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6297
6298 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6299
6300 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6301
6302 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6303
6304 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6305 (x_clipboard_manager_save): Add return value.
6306 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6307 New error handlers.
6308 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6309 Obey Vx_select_enable_clipboard_manager. Catch errors in
6310 x_clipboard_manager_save (Bug#8779).
6311 (Vx_select_enable_clipboard_manager): New variable.
6312 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6313
6314 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6315
6316 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6317
6318 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6319
6320 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6321 in the current matrix if keep_current_p is non-zero.
6322
6323 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6324
6325 * bidi.c (bidi_level_of_next_char): Fix last change.
6326
6327 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6328
6329 Support bidi reordering of text covered by display properties.
6330
6331 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6332 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6333 (bidi_cache_search, bidi_cache_iterator_state)
6334 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6335 (bidi_level_of_next_char, bidi_move_to_visually_next):
6336 Support character positions inside a run of characters covered by a
6337 display string.
6338 (bidi_paragraph_init, bidi_resolve_explicit_1)
6339 (bidi_level_of_next_char): Call bidi_fetch_char and
6340 bidi_fetch_char_advance instead of FETCH_CHAR and
6341 FETCH_CHAR_ADVANCE.
6342 (bidi_init_it): Initialize new members.
6343 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6344 definitions.
6345 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6346 instead of using explicit *_CHAR codes.
6347 (bidi_resolve_explicit, bidi_resolve_weak):
6348 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6349 bidirectional text is supported only in multibyte buffers.
6350 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6351 it to initialize the frame_window_p member of struct bidi_it.
6352 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6353 (bidi_resolve_explicit, bidi_resolve_weak)
6354 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6355 bidi_it->nchars is non-positive.
6356 (bidi_level_of_next_char): Don't try to lookup the cache for the
6357 next/previous character if nothing is cached there yet, or if we
6358 were just reseat()'ed to a new position.
6359
6360 * xdisp.c (set_cursor_from_row): Set start and stop points
6361 according to the row's direction when priming the loop that looks
6362 for the glyph on which to display cursor.
6363 (single_display_spec_intangible_p): Function deleted.
6364 (display_prop_intangible_p): Reimplement to call
6365 handle_display_spec instead of single_display_spec_intangible_p.
6366 Accept 3 additional arguments needed by handle_display_spec.
6367 This fixes incorrect cursor motion across display property with complex
6368 values: lists, `(when COND...)' forms, etc.
6369 (single_display_spec_string_p): Support property values that are
6370 lists with the argument STRING its top-level element.
6371 (display_prop_string_p): Fix the condition for processing a
6372 property that is a list to be consistent with handle_display_spec.
6373 (handle_display_spec): New function, refactored from the
6374 last portion of handle_display_prop.
6375 (compute_display_string_pos): Accept additional argument
6376 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6377 value of a `display' property is a "replacing spec".
6378 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6379 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6380 the display property, but just return a value indicating whether
6381 the display property will replace the characters it covers.
6382 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6383 frame_window_p members of struct bidi_it.
6384 (compute_display_string_pos, compute_display_string_end):
6385 New functions.
6386 (push_it): Accept second argument POSITION, where pop_it should
6387 jump to continue iteration.
6388 (reseat_1): Initialize bidi_it.disp_pos.
6389
6390 * keyboard.c (adjust_point_for_property): Adjust the call to
6391 display_prop_intangible_p to its new signature.
6392
6393 * dispextern.h (struct bidi_it): New member frame_window_p.
6394 (bidi_init_it): Update prototypes.
6395 (display_prop_intangible_p): Update prototype.
6396 (compute_display_string_pos, compute_display_string_end):
6397 Declare prototypes.
6398 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6399 EMACS_INT.
6400
6401 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6402
6403 Malloc failure behavior now depends on size of allocation.
6404 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6405 * lisp.h: Change signatures accordingly.
6406 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6407 All callers changed. (Bug#8762)
6408
6409 * gnutls.c: Use Emacs's memory allocators.
6410 Without this change, the gnutls library would invoke malloc etc.
6411 directly, which causes problems on non-SYNC_INPUT hosts, and which
6412 runs afoul of improving memory_full behavior. (Bug#8761)
6413 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6414 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6415 xfree instead of the default malloc, realloc, free.
6416 (Fgnutls_boot): No need to check for memory allocation failure,
6417 since xmalloc does that for us.
6418
6419 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6420 * category.c (hash_get_category_set):
6421 * ccl.c (ccl_driver):
6422 * charset.c (Fdefine_charset_internal):
6423 * charset.h (struct charset.hash_index):
6424 * composite.c (get_composition_id, gstring_lookup_cache)
6425 (composition_gstring_put_cache):
6426 * composite.h (struct composition.hash_index):
6427 * dispextern.h (struct image.hash):
6428 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6429 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6430 (hashfn_equal, hashfn_user_defined, make_hash_table)
6431 (maybe_resize_hash_table, hash_lookup, hash_put)
6432 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6433 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6434 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6435 * image.c (make_image, search_image_cache, lookup_image)
6436 (xpm_put_color_table_h):
6437 * lisp.h (struct Lisp_Hash_Table):
6438 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6439 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6440 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6441 * alloc.c (allocate_vectorlike):
6442 Check for overflow in vector size calculations.
6443 * ccl.c (ccl_driver):
6444 Check for overflow when converting EMACS_INT to int.
6445 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6446 need to be updated by these changes.
6447 * fns.c (make_hash_table, maybe_resize_hash_table):
6448 Check for integer overflow with large hash tables.
6449 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6450 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6451 (SXHASH_REDUCE): New macro.
6452 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6453 Use it instead of discarding useful hash info with large hash values.
6454 (sxhash_float): New function.
6455 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6456 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6457 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6458 Rewrite to use FIXNUM_BITS, as this simplifies things.
6459 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6460 Adjust signatures to match updated version of code.
6461 (consing_since_gc): Now EMACS_INT, since a single hash table can
6462 use more than INT_MAX bytes.
6463
6464 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6465
6466 Make it possible to build with GCC-4.6+ -O2 -flto.
6467
6468 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6469
6470 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6471
6472 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6473 Call minibuffer-inactive-mode.
6474
6475 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6476
6477 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6478 Update dependencies.
6479
6480 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6481
6482 * data.c (init_data): Remove code for UTS, this system is not
6483 supported anymore.
6484
6485 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6486
6487 Don't force ./temacs to start in terminal mode.
6488
6489 * frame.c (make_initial_frame): Initialize faces in all cases, not
6490 only when CANNOT_DUMP is defined.
6491 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6492
6493 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6494
6495 * dispnew.c (add_window_display_history): Use const for the string
6496 pointer. Remove declaration, not needed.
6497
6498 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6499
6500 Use 'inline', not 'INLINE'.
6501 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6502 * alloc.c, fontset.c (INLINE): Remove.
6503 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6504 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6505 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6506 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6507 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6508
6509 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6510
6511 Make it possible to run ./temacs.
6512
6513 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6514 syms_of_callproc does the same thing. Remove test for
6515 "initialized", do it in the caller.
6516 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6517
6518 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6519
6520 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6521 (read_minibuf): Use get_minibuffer.
6522 (syms_of_minibuf): Use DEFSYM.
6523 (Qmetadata): New var.
6524 * data.c (Qbuffer): Don't make it static.
6525 (syms_of_data): Use DEFSYM.
6526
6527 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6528
6529 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6530 (CCL_CODE_MIN): New macro.
6531
6532 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6533
6534 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6535
6536 * eval.c (Qdebug): Now static.
6537 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6538 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6539 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6540
6541 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6542
6543 * image.c: Various fixes to ImageMagick code comments.
6544 (Fimagemagick_types): Doc fix.
6545
6546 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6547
6548 Minor fixes prompted by GCC 4.6.0 warnings.
6549
6550 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6551
6552 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6553 (x_clipboard_manager_save_all): Move extern decl to ...
6554 * xterm.h: ... here, so that it can be checked for consistency.
6555
6556 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6557
6558 * xselect.c (x_clipboard_manager_save_frame)
6559 (x_clipboard_manager_save_all): New functions.
6560 (Fx_clipboard_manager_save): Lisp function deleted.
6561
6562 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6563 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6564
6565 * xterm.h: Update prototype.
6566
6567 2011-05-28 William Xu <william.xwl@gmail.com>
6568
6569 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6570 exiting (Bug#8239).
6571
6572 2011-05-28 Jim Meyering <meyering@redhat.com>
6573
6574 Avoid a sign-extension bug in crypto_hash_function.
6575 * fns.c (to_uchar): Define.
6576 (crypto_hash_function): Use it to convert some newly-signed
6577 variables to unsigned, to avoid sign-extension bugs. For example,
6578 without this change, (md5 "truc") would evaluate to
6579 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6580 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6581 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6582
6583 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6584
6585 Integer overflow fixes.
6586
6587 * dbusbind.c: Serial number integer overflow fixes.
6588 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6589 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6590 to hold a serial number that is too large for a fixnum.
6591 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6592 Check for serial numbers out of range. Decode any serial number
6593 that was so large that it became a float. (Bug#8722)
6594
6595 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6596 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6597 Use XFASTINT rather than XUINT when numbers are nonnegative.
6598 (xd_append_arg, Fdbus_method_return_internal):
6599 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6600 arguments, check that Lisp number is nonnegative, rather than
6601 silently wrapping negative numbers around. (Bug#8722)
6602 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6603 (Bug#8722)
6604
6605 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6606
6607 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6608
6609 ccl: Add integer overflow checks.
6610 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6611 (IN_INT_RANGE): New macros.
6612 (ccl_driver): Use them to check for integer overflow when
6613 decoding a CCL program. Many of the new checks are whether XINT (x)
6614 fits in int; it doesn't always, on 64-bit hosts. The new version
6615 doesn't catch all possible integer overflows, but it's an
6616 improvement. (Bug#8719)
6617
6618 * alloc.c (make_event_array): Use XINT, not XUINT.
6619 There's no need for unsigned here.
6620
6621 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6622 This follows up to the 2011-05-06 change that substituted uintptr_t
6623 for EMACS_INT. This case wasn't caught back then.
6624
6625 Rework Fformat to avoid integer overflow issues.
6626 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6627 now (part of C89). Include <verify.h>.
6628 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6629 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6630 (Fformat): Avoid the prepass trying to compute sizes; it was only
6631 approximate and thus did not catch overflow reliably. Instead, walk
6632 through the format just once, formatting and computing sizes as we go,
6633 checking for integer overflow at every step, and allocating a larger
6634 buffer as needed. Keep track separately whether the format is
6635 multibyte. Keep only the most-recently calculated precision, rather
6636 than them all. Record whether each argument has been converted to
6637 string. Use EMACS_INT, not int, for byte and char and arg counts.
6638 Support field widths and precisions larger than INT_MAX. Avoid
6639 sprintf's undefined behavior with conversion specifications such as %#d
6640 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6641 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6642 formatting out-of-range floating point numbers with int
6643 formats. (Bug#8668)
6644
6645 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6646
6647 * data.c: Avoid integer truncation in expressions involving floats.
6648 * data.c: Include <intprops.h>.
6649 (arith_driver): When there's an integer overflow in an expression
6650 involving floating point, convert the integers to floating point
6651 so that the resulting value does not suffer from catastrophic
6652 integer truncation. For example, on a 64-bit host (* 4
6653 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6654 Do not rely on undefined behavior after integer overflow.
6655
6656 merge count_size_as_multibyte, parse_str_to_multibyte
6657 * character.c, character.h (count_size_as_multibyte):
6658 Rename from parse_str_to_multibyte; all uses changed.
6659 Check for integer overflow.
6660 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6661 since it's now a duplicate of the other. This is more of
6662 a character than a buffer op, so better that it's in character.c.
6663 * fns.c, print.c: Adjust to above changes.
6664
6665 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6666
6667 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6668
6669 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6670
6671 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6672 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6673 (x_clipboard_manager_save): Now static.
6674 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6675
6676 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6677 (crypto_hash_function): Now static.
6678 Fix pointer signedness problems. Avoid unnecessary initializations.
6679
6680 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6681
6682 * termhooks.h (Vselection_alist): Make it terminal-local.
6683
6684 * terminal.c (create_terminal): Initialize it.
6685
6686 * xselect.c: Support for clipboard managers.
6687 (Vselection_alist): Move to termhooks.h as terminal-local var.
6688 (LOCAL_SELECTION): New macro.
6689 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6690 (symbol_to_x_atom): Remove gratuitous arg.
6691 (x_handle_selection_request, lisp_data_to_selection_data)
6692 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6693 (x_own_selection, x_get_local_selection, x_convert_selection):
6694 New arg, specifying work frame. Use terminal-local Vselection_alist.
6695 (some_frame_on_display): Delete unused function.
6696 (Fx_own_selection_internal, Fx_get_selection_internal)
6697 (Fx_disown_selection_internal, Fx_selection_owner_p)
6698 (Fx_selection_exists_p): New optional frame arg.
6699 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6700 (x_handle_selection_clear): Don't treat other terminals with the
6701 same keyboard specially. Use the terminal-local Vselection_alist.
6702 (x_clear_frame_selections): Use Frun_hook_with_args.
6703
6704 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6705
6706 * xterm.h: Add support for those atoms.
6707
6708 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6709
6710 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6711 (converted_selections, conversion_fail_tag): New global variables.
6712 (x_selection_request_lisp_error): Free the above.
6713 (x_get_local_selection): Remove unnecessary code.
6714 (x_reply_selection_request): Args changed; handle arbitrary array
6715 of converted selections stored in converted_selections.
6716 Separate the XChangeProperty and SelectionNotify steps.
6717 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6718 (x_convert_selection): New function.
6719 (x_handle_selection_event): Simplify.
6720 (x_get_foreign_selection): Don't ignore incoming requests while
6721 waiting for an answer; this will fail when we implement
6722 SAVE_TARGETS, and seems unnecessary anyway.
6723 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6724 (Vx_sent_selection_functions): Doc fix.
6725
6726 2011-05-26 Leo Liu <sdl.web@gmail.com>
6727
6728 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6729
6730 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6731
6732 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6733
6734 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6735 for fringe update if it has periodic bitmap.
6736 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6737 and fringe_bitmap_periodic_p.
6738
6739 * fringe.c (get_fringe_bitmap_data): New function.
6740 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6741 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6742 row. Mark glyph row for fringe update if periodicity changed.
6743
6744 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6745 for fringe update unless it has periodic bitmap.
6746
6747 2011-05-25 Kenichi Handa <handa@m17n.org>
6748
6749 * xdisp.c (get_next_display_element): Set correct it->face_id for
6750 a static composition.
6751
6752 2011-05-24 Leo Liu <sdl.web@gmail.com>
6753
6754 * deps.mk (fns.o):
6755 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6756
6757 * fns.c (crypto_hash_function, Fsha1): New function.
6758 (Fmd5): Use crypto_hash_function.
6759 (syms_of_fns): Add Ssha1.
6760
6761 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6762
6763 * gnutls.c: Remove unused macros.
6764 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6765 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6766 Remove macros that are defined and never used.
6767 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6768
6769 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6770
6771 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6772 (Fx_get_selection_internal): Minor cleanup.
6773 (Fx_own_selection_internal): Rename arguments for consistency with
6774 select.el.
6775
6776 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6777
6778 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6779
6780 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6781
6782 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6783
6784 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6785
6786 * dispnew.c (scrolling_window): Don't exclude the case that the
6787 last enabled row in the desired matrix touches the bottom boundary.
6788
6789 2011-05-21 Glenn Morris <rgm@gnu.org>
6790
6791 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6792 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6793 and add some more files.
6794
6795 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6796
6797 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6798 report_file_error introduced by the change from 2011-05-07.
6799
6800 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6801
6802 * systime.h (Time): Define only if emacs is defined.
6803 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6804 where the include path doesn't have X11/X.h by default. See
6805 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6806
6807 2011-05-20 Kenichi Handa <handa@m17n.org>
6808
6809 * composite.c (find_automatic_composition): Fix previous change.
6810
6811 2011-05-20 Glenn Morris <rgm@gnu.org>
6812
6813 * lisp.mk: New file, split from Makefile.in.
6814 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6815 (shortlisp): Remove.
6816 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6817
6818 2011-05-19 Glenn Morris <rgm@gnu.org>
6819
6820 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6821 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6822 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6823 (lisp): Set the order to that of loadup.el.
6824 (shortlisp): Make it a copy of $lisp.
6825 (SOME_MACHINE_LISP): Remove.
6826 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6827 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6828
6829 2011-05-18 Kenichi Handa <handa@m17n.org>
6830
6831 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6832 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6833 (find_automatic_composition): Mostly rewrite for efficiency.
6834
6835 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6836
6837 * makefile.w32-in: Update dependencies.
6838
6839 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6840
6841 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6842 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6843
6844 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6845
6846 Fix some integer overflow issues, such as string length overflow.
6847
6848 * insdel.c (count_size_as_multibyte): Check for string overflow.
6849
6850 * character.c (lisp_string_width): Check for string overflow.
6851 Use EMACS_INT, not int, for string indexes and lengths; in
6852 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6853 the resulting string length overflows an EMACS_INT; instead,
6854 report a string overflow if no precision given. When checking for
6855 precision exhaustion, use a check that cannot possibly have
6856 integer overflow. (Bug#8675)
6857 * character.h (lisp_string_width): Adjust to new signature.
6858
6859 * alloc.c (string_overflow): New function.
6860 (Fmake_string): Use it. This doesn't change behavior, but saves
6861 a few bytes and will simplify future changes.
6862 * character.c (string_escape_byte8): Likewise.
6863 * lisp.h (string_overflow): New decl.
6864
6865 Fixups, following up to the user-interface timestamp change.
6866 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6867 for UI timestamps, instead of unsigned long.
6868 * msdos.c (mouse_get_pos): Likewise.
6869 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6870 * w32gui.h (Time): Define by including "systime.h" rather than by
6871 declaring it ourselves. (Bug#8664)
6872
6873 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6874 * image.c (clear_image_cache): Likewise.
6875
6876 * term.c (term_mouse_position): Don't assume time_t wraparound.
6877
6878 Be more systematic about user-interface timestamps.
6879 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6880 and sometimes 'EMACS_UINT', to represent these timestamps.
6881 This change causes it to use 'Time' uniformly, as that's what X uses.
6882 This makes the code easier to follow, and makes it easier to catch
6883 integer overflow bugs such as Bug#8664.
6884 * frame.c (Fmouse_position, Fmouse_pixel_position):
6885 Use Time, not unsigned long, for user-interface timestamps.
6886 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6887 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6888 * keyboard.h (last_event_timestamp): Likewise.
6889 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6890 * menu.h (xmenu_show): Likewise.
6891 * term.c (term_mouse_position): Likewise.
6892 * termhooks.h (struct input_event.timestamp): Likewise.
6893 (struct terminal.mouse_position_hook): Likewise.
6894 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6895 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6896 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6897 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6898 what it was before.
6899 * menu.h, termhooks.h: Include "systime.h", for Time.
6900
6901 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6902 Don't assume that the difference between two unsigned long values
6903 can fit into an integer. At this point, we know button_down_time
6904 <= event->timestamp, so the difference must be nonnegative, so
6905 there's no need to cast the result if double-click-time is
6906 nonnegative, as it should be; check that it's nonnegative, just in
6907 case. This bug is triggered when events are more than 2**31 ms
6908 apart (about 25 days). (Bug#8664)
6909
6910 * xselect.c (last_event_timestamp): Remove duplicate decl.
6911 (x_own_selection): Remove needless cast to unsigned long.
6912
6913 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6914 that always fit in int. Use a sentinel instead of a counter, to
6915 avoid a temp and to allay GCC's concerns about possible int overflow.
6916 * frame.h (struct frame): Use int for menu_bar_items_used
6917 instead of EMACS_INT, since it always fits in int.
6918
6919 * menu.c (grow_menu_items): Check for int overflow.
6920
6921 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6922
6923 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6924 Before, the code was not consistent. These values cannot exceed
6925 2**31 - 1 so there's no need to make them unsigned.
6926 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6927 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6928 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6929 as modifiers.
6930 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6931
6932 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6933 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6934 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6935 presumably because the widths might not match.
6936
6937 * window.c (size_window): Avoid needless test at loop start.
6938
6939 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6940
6941 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6942
6943 2011-05-12 Drew Adams <drew.adams@oracle.com>
6944
6945 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6946
6947 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6948
6949 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6950 `width' to `bar_area_x' and `bar_area_width', respectively.
6951 (x_scroll_run): Take account of fringe background extension.
6952
6953 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6954 Rename local vars `left' and `width' to `bar_area_x' and
6955 `bar_area_width', respectively.
6956 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6957 background extension.
6958
6959 2011-05-10 Jim Meyering <meyering@redhat.com>
6960
6961 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6962
6963 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6964
6965 * image.c (Finit_image_library): Return t for built-in image types,
6966 like pbm and xbm. (Bug#8640)
6967
6968 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6969
6970 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6971
6972 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6973
6974 * w32console.c (Fset_screen_color): Doc fix.
6975 (Fget_screen_color): New function.
6976 (syms_of_ntterm): Defsubr it.
6977
6978 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6979 unlink the temporary file if Fcall_process didn't create it in the
6980 first place.
6981 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6982 child process will be redirected to a file specified with `:file'.
6983 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6984 cue to call_process_cleanup not to close that handle.
6985
6986 2011-05-07 Ben Key <bkey76@gmail.com>
6987
6988 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6989 one of two shell specific rules, either bootstrap-temacs-CMD or
6990 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6991 to the previous implementation of the bootstrap-temacs rule.
6992 The bootstrap-temacs-CMD rule is similar to the previous
6993 implementation of the bootstrap-temacs rule except that it
6994 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6995 variable.
6996
6997 These changes, along with some changes to nt/configure.bat,
6998 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6999 earlier fix to add support for --cflags and --ldflags options
7000 that include quotes so that it works whether make uses cmd or
7001 sh as the shell.
7002
7003 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
7004
7005 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7006 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7007 is a constant.
7008 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7009 a string. Handle both cases.
7010 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7011 (Fdbus_register_method): Use Qinvalid_function.
7012
7013 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7014
7015 * makefile.w32-in: Update dependencies.
7016 (LISP_H): Add inttypes.h and stdin.h.
7017 (PROCESS_H): Add unistd.h.
7018
7019 2011-05-06 Eli Zaretskii <eliz@gnu.org>
7020
7021 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7022 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7023
7024 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
7025
7026 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7027
7028 * term.c (vfatal): Remove stray call to va_end.
7029 It's not needed and the C Standard doesn't allow it here anyway.
7030
7031 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7032 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7033
7034 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7035 bytes.
7036
7037 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7038
7039 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7040
7041 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7042
7043 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7044
7045 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7046
7047 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7048 * charset.c (Fdefine_charset_internal): Don't initialize
7049 charset.code_space[15]. The value was garbage, on hosts with
7050 32-bit int (Bug#8600).
7051
7052 * lread.c (read_integer): Be more consistent with string-to-number.
7053 Use string_to_number to do the actual conversion; this avoids
7054 rounding errors and fixes some other screwups. Without this fix,
7055 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7056 (digit_to_number): Move earlier, for benefit of read_integer.
7057 Return -1 if the digit is out of range for the base, -2 if it is
7058 not a digit in any supported base. (Bug#8602)
7059
7060 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7061
7062 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7063 to match comment at start of function. This also removes a
7064 GCC warning about overflow in a 32+64-bit port.
7065
7066 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7067
7068 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7069 Reported by Stefan Monnier in
7070 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7071 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7072 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7073
7074 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7075 (EMACS_UINTPTR): Likewise, with uintptr_t.
7076
7077 * lisp.h: Prefer 64-bit EMACS_INT if available.
7078 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7079 on 32-bit hosts that have 64-bit int, so that they can access
7080 large files.
7081 However, temporarily disable this change unless the temporary
7082 symbol WIDE_EMACS_INT is defined.
7083
7084 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7085
7086 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7087 This removes an assumption that EMACS_INT and long are the same
7088 width as pointers. The assumption is true for Emacs porting targets
7089 now, but we want to make other targets possible.
7090 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7091 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7092 In the rest of the code, change types of integers that hold casted
7093 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7094 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7095 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7096 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7097 No need to cast type when ORing.
7098 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7099 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7100 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7101 assume EMACS_INT is the same width as char *.
7102 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7103 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7104 Remove no-longer-needed casts.
7105 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7106 (xg_tool_bar_help_callback, xg_make_tool_item):
7107 Use EMACS_INTPTR to hold an integer
7108 that will be cast to void *; this can avoid a GCC warning
7109 if EMACS_INT is not the same width as void *.
7110 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7111 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7112 (current_message_1, set_message_1):
7113 Use a local to convert to proper width without a cast.
7114 * xmenu.c (dialog_selection_callback): Likewise.
7115
7116 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7117 Also, don't assume VALBITS / RAND_BITS is less than 5,
7118 and don't rely on undefined behavior when shifting a 1 left into
7119 the sign bit.
7120 * lisp.h (get_random): Change signature to match.
7121
7122 * lread.c (hash_string): Use size_t, not int, for hash computation.
7123 Normally we prefer signed values; but hashing is special, because
7124 it's better to use unsigned division on hash table sizes so that
7125 the remainder is nonnegative. Also, size_t is the natural width
7126 for hashing into memory. The previous code used 'int', which doesn't
7127 retain enough info to hash well into very large tables.
7128 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7129
7130 * dbusbind.c: Don't possibly lose pointer info when converting.
7131 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7132 Use XPNTR rather than XHASH, so that the high-order bits of
7133 the pointer aren't lost when converting through void *.
7134
7135 * eval.c (Fautoload): Don't double-shift a pointer.
7136
7137 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7138
7139 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7140
7141 * gnutls.c (DEF_GNUTLS_FN):
7142 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7143
7144 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7145
7146 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7147 marker. (Bug#8610)
7148
7149 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7150
7151 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7152 New version that can reserve upto 2GB of heap space.
7153
7154 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7155
7156 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7157
7158 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7159
7160 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7161 `gnutls_certificate_set_x509_key_file'.
7162
7163 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7164
7165 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7166 Update dependencies.
7167
7168 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7169
7170 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7171 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7172 Remove unused parameter `fildes'.
7173 * process.c (read_process_output, send_process): Don't pass it.
7174
7175 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7176
7177 Fix previous change: the library cache is defined in w32.c.
7178 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7179 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7180
7181 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7182
7183 Implement dynamic loading of GnuTLS on Windows.
7184
7185 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7186 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7187 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7188 Declare.
7189
7190 * gnutls.c (Qgnutls_dll): Define.
7191 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7192 (gnutls_*): Declare function pointers.
7193 (init_gnutls_functions): New function to initialize function pointers.
7194 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7195 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7196 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7197 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7198 (emacs_gnutls_write, emacs_gnutls_read)
7199 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7200 (Fgnutls_available_p): New function.
7201 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7202 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7203 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7204
7205 * image.c: Include w32.h.
7206 (Vimage_type_cache): Delete.
7207 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7208 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7209 (w32_delayed_load): Move to w32.c.
7210
7211 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7212
7213 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7214 (w32_delayed_load): Move from image.c. When loading a library, record
7215 its filename in the :loaded-from property of the library id.
7216 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7217 Initialize and staticpro them.
7218 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7219
7220 * process.c: Include lisp.h before w32.h, not after.
7221 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7222 instead of gnutls_record_check_pending.
7223
7224 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7225
7226 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7227
7228 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7229 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7230 as passed in.
7231
7232 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7233
7234 * xterm.c (x_set_frame_alpha): Do not set property on anything
7235 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7236
7237 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7238
7239 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7240
7241 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7242
7243 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7244 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7245 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7246 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7247 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7248 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7249 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7250 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7251 (Qgnutls_bootprop_callbacks_verify): Make static.
7252
7253 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7254
7255 * callproc.c: Indentation fixup.
7256
7257 * sysdep.c (wait_for_termination_1): Make static.
7258 (wait_for_termination, interruptible_wait_for_termination):
7259 Move after wait_for_termination_1.
7260
7261 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7262
7263 * sysdep.c (interruptible_wait_for_termination): New function
7264 which is like wait_for_termination, but allows keyboard
7265 interruptions.
7266
7267 * callproc.c (Fcall_process): Add (:file "file") as an option for
7268 the STDOUT buffer.
7269 (Fcall_process_region): Ditto.
7270
7271 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7272
7273 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7274 rather than `XVECTOR (FOO)->size'.
7275
7276 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7277 inttypes.h, as a gnulib replacement is used if it not available in
7278 system headers.
7279
7280 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7281
7282 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7283 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7284 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7285
7286 * coding.c (coding_alloc_by_realloc): Error out if destination
7287 will grow beyond MOST_POSITIVE_FIXNUM.
7288 (decode_coding_emacs_mule): Abort if there isn't enough place in
7289 charbuf for the composition carryover bytes. Reserve an extra
7290 space for up to 2 characters produced in a loop.
7291 (decode_coding_iso_2022): Abort if there isn't enough place in
7292 charbuf for the composition carryover bytes.
7293
7294 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7295
7296 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7297 aborting when %lld or %lll format is passed.
7298 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7299 %llo or %llx format is passed. (Bug#8545)
7300
7301 * window.c (window_scroll_line_based): Use a marker instead of
7302 simple variables to record original value of point. (Bug#7952)
7303
7304 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7305 produced by %s or %c overflows available buffer space. (Bug#8545)
7306
7307 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7308
7309 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7310 (SIZE_MAX): Move defn after all includes, as they might #define it.
7311
7312 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7313
7314 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7315
7316 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7317
7318 * keyboard.c (Qdelayed_warnings_hook): Define.
7319 (command_loop_1): Run `delayed-warnings-hook'
7320 if Vdelayed_warnings_list is non-nil.
7321 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7322 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7323
7324 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7325
7326 * doprnt.c (doprnt): Don't return value smaller than the buffer
7327 size if the message was truncated. (Bug#8545).
7328
7329 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7330
7331 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7332 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7333
7334 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7335
7336 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7337
7338 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7339
7340 * makefile.w32-in: Update dependencies.
7341
7342 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7343
7344 Improve `doprnt' and its usage. (Bug#8545)
7345 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7346 `format_end'. Remove support for %l as a conversion specifier.
7347 Don't use xrealloc. Improve diagnostics when the %l size modifier
7348 is used. Update the commentary.
7349
7350 * eval.c (verror): Simplify calculation of size_t.
7351
7352 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7353 messages.
7354
7355 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7356
7357 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7358 change.
7359
7360 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7361
7362 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7363 This makes this file independent of the recent pseudovector change.
7364
7365 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7366
7367 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7368
7369 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7370 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7371 Remove unused local.
7372 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7373
7374 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7375 GCC 4.6.0 optimizes based on type-based alias analysis.
7376 For example, if b is of type struct buffer * and v of type struct
7377 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7378 != &v->size, and therefore "v->size = 1; b->size = 2; return
7379 v->size;" must therefore return 1. This assumption is incorrect
7380 for Emacs, since it type-puns struct Lisp_Vector * with many other
7381 types. To fix this problem, this patch adds a new type struct
7382 vectorlike_header that documents the constraints on layout of vectors
7383 and pseudovectors, and helps optimizing compilers not get fooled
7384 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7385 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7386 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7387 the size member.
7388 (XSETPVECTYPE): Rewrite in terms of new macro.
7389 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7390 This is a bit clearer, and further avoids the possibility of
7391 undesirable aliasing.
7392 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7393 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7394 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7395 since Lisp_Subr is a special case (no "next" field).
7396 (ASIZE): Now uses header.size rather than size.
7397 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7398 to avoid the hassle of writing XVECTOR (foo)->header.size.
7399 (struct vectorlike_header): New type.
7400 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7401 object, to help avoid aliasing.
7402 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7403 (SUBRP): Likewise, since Lisp_Subr is a special case.
7404 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7405 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7406 (struct Lisp_Hash_Table): Combine first two members into a single
7407 struct vectorlike_header member. All uses of "size" and "next" members
7408 changed to be "header.size" and "header.next".
7409 * buffer.h (struct buffer): Likewise.
7410 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7411 * frame.h (struct frame): Likewise.
7412 * process.h (struct Lisp_Process): Likewise.
7413 * termhooks.h (struct terminal): Likewise.
7414 * window.c (struct save_window_data, struct saved_window): Likewise.
7415 * window.h (struct window): Likewise.
7416 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7417 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7418 * buffer.c (init_buffer_once): Likewise.
7419 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7420 special case.
7421 * process.c (Fformat_network_address): Use local var for size,
7422 for brevity.
7423
7424 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7425
7426 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7427 * data.c (atof): Remove decl; no longer used or needed.
7428 (digit_to_number): Move to lread.c.
7429 (Fstring_to_number): Use new string_to_number function, to be
7430 consistent with how the Lisp reader treats infinities and NaNs.
7431 Do not assume that floating-point numbers represent EMACS_INT
7432 without losing information; this is not true on most 64-bit hosts.
7433 Avoid double-rounding errors, by insisting on integers when
7434 parsing non-base-10 numbers, as the documentation specifies.
7435 * lisp.h (string_to_number): New decl, replacing ...
7436 (isfloat_string): Remove.
7437 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7438 (read1): Do not accept +. and -. as integers; this
7439 appears to have been a coding error. Similarly, do not accept
7440 strings like +-1e0 as floating point numbers. Do not report
7441 overflow for integer overflows unless the base is not 10 which
7442 means we have no simple and reliable way to continue.
7443 Break out the floating-point parsing into a new
7444 function string_to_number, so that Fstring_to_number parses
7445 floating point numbers consistently with the Lisp reader.
7446 (digit_to_number): Move here from data.c. Make it static inline.
7447 (E_CHAR, EXP_INT): Remove, replacing with ...
7448 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7449 (string_to_number): New function, replacing isfloat_string.
7450 This function checks for valid syntax and produces the resulting
7451 Lisp float number too. Rework it so that string-to-number
7452 no longer mishandles examples like "1.0e+". Use strtoumax,
7453 so that overflow for non-base-10 numbers is reported only when
7454 there's no portable and simple way to convert to floating point.
7455
7456 * textprop.c (set_text_properties_1): Rewrite for clarity,
7457 and to avoid GCC warning about integer overflow.
7458
7459 * intervals.h (struct interval): Use EMACS_INT for members
7460 where EMACS_UINT might cause problems. See
7461 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7462 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7463 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7464 All uses changed.
7465 (offset_intervals): Tell GCC not to worry about length overflow
7466 when negating a negative length.
7467
7468 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7469 (overrun_check_free): Likewise.
7470
7471 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7472 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7473 word size.
7474
7475 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7476 (gnutls_make_error): Rename local to avoid shadowing.
7477 (gnutls_emacs_global_deinit): ifdef out; not used.
7478 (Fgnutls_boot): Use const for pointer to readonly storage.
7479 Comment out unused local. Fix pointer signedness problems.
7480
7481 * lread.c (openp): Don't stuff size_t into an 'int'.
7482 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7483 about possible signed overflow.
7484
7485 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7486 (GDK_KEY_g): Don't define if already defined.
7487 (xg_prepare_tooltip): Avoid pointer signedness problem.
7488 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7489
7490 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7491 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7492
7493 * xfns.c (Fx_window_property): Simplify a bit,
7494 to make a bit faster and to avoid GCC 4.6.0 warning.
7495 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7496
7497 * fns.c (internal_equal): Don't assume size_t fits in int.
7498
7499 * alloc.c (compact_small_strings): Tighten assertion a little.
7500
7501 Replace pEd with more-general pI, and fix some printf arg casts.
7502 * lisp.h (pI): New macro, generalizing old pEd macro to other
7503 conversion specifiers. For example, use "...%"pI"d..." rather
7504 than "...%"pEd"...".
7505 (pEd): Remove. All uses replaced with similar uses of pI.
7506 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7507 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7508 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7509 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7510 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7511 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7512 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7513 64-bit hosts.
7514 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7515 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7516 * print.c (safe_debug_print, print_object): Likewise.
7517 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7518 to int.
7519 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7520 avoiding the 0 flag, which is not portable.
7521 * process.c (Fmake_network_process): Use pI to avoid cast.
7522 * region-cache.c (pp_cache): Likewise.
7523 * xdisp.c (decode_mode_spec): Likewise.
7524 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7525 behavior on 64-bit hosts with printf arg.
7526 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7527 (x_stop_queuing_selection_requests): Likewise.
7528 (x_get_window_property): Don't truncate byte count to an 'int'
7529 when tracing.
7530
7531 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7532 here, since it parses constructs like leading '-' and spaces,
7533 which are not wanted; and it overflows with large numbers.
7534 Instead, simply match F[0-9]+, which is what is wanted anyway.
7535
7536 * alloc.c: Remove unportable assumptions about struct layout.
7537 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7538 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7539 (allocate_vectorlike, make_pure_vector): Use the new macros,
7540 plus offsetof, to remove unportable assumptions about struct layout.
7541 These assumptions hold on all porting targets that I know of, but
7542 they are not guaranteed, they're easy to remove, and removing them
7543 makes further changes easier.
7544
7545 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7546 This doesn't fix a bug but makes the code clearer.
7547 (string_overrun_cookie): Now const. Use initializers that
7548 don't formally overflow signed char, to avoid warnings.
7549 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7550 can cause Emacs to crash when string overrun checking is enabled.
7551 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7552 multiple of sizeof (EMACS_INT); it need not be, if
7553 alignof(EMACS_INT) < sizeof (EMACS_INT).
7554 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7555
7556 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7557
7558 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7559
7560 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7561
7562 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7563 supposed to be handshaking. (Bug#8556)
7564 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7565
7566 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7567
7568 * lisp.h (Qdebug): List symbol.
7569 * eval.c (Qdebug): Restore global linkage.
7570 * keyboard.c (debug-on-event): New variable.
7571 (handle_user_signal): Break into debugger when debug-on-event
7572 matches the current signal symbol.
7573
7574 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7575
7576 * alloc.c (check_sblock, check_string_bytes)
7577 (check_string_free_list): Convert to standard C.
7578
7579 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7580
7581 * w32.c (emacs_gnutls_push): Fix typo.
7582
7583 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7584
7585 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7586 "cast to pointer from integer of different size".
7587
7588 Improve doprnt and its use in verror. (Bug#8545)
7589 * doprnt.c (doprnt): Document the set of format control sequences
7590 supported by the function. Use SAFE_ALLOCA instead of always
7591 using `alloca'.
7592
7593 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7594 is one byte too soon. Don't use xrealloc; instead xfree and
7595 xmalloc anew.
7596
7597 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7598
7599 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7600 callbacks stage.
7601
7602 * gnutls.c: Renamed global_initialized to
7603 gnutls_global_initialized. Added internals for the
7604 :verify-hostname-error, :verify-error, and :verify-flags
7605 parameters of `gnutls-boot' and documented those parameters in the
7606 docstring. Start callback support.
7607 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7608 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7609 on error. Return error code.
7610 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7611 (emacs_gnutls_read): Likewise.
7612 (Fgnutls_boot): Return handshake error code.
7613 (emacs_gnutls_handle_error): New function.
7614 (wsaerror_to_errno): Likewise.
7615
7616 * w32.h (emacs_gnutls_pull): Add prototype.
7617 (emacs_gnutls_push): Likewise.
7618
7619 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7620 (emacs_gnutls_push): Likewise.
7621
7622 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7623
7624 * process.c (wait_reading_process_output): Check if GnuTLS
7625 buffered some data internally if no FDs are set for TLS
7626 connections.
7627
7628 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7629 (LIBS): Link to USER_LIBS.
7630 ($(BLD)/gnutls.$(0)): New target.
7631
7632 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7633
7634 * xdisp.c (handle_single_display_spec): Rename the
7635 display_replaced_before_p argument into display_replaced_p, to
7636 make it consistent with the commentary. Fix typos in the
7637 commentary.
7638
7639 * textprop.c (syms_of_textprop): Remove dead code.
7640 (copy_text_properties): Delete obsolete commentary about an
7641 interface that was deleted long ago. Fix typos in the description
7642 of arguments.
7643
7644 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7645 to changes in oldXMenu/XMenu.h from 2011-04-16.
7646 <menu_help_message, prev_menu_help_message>: Constify.
7647 (IT_menu_make_room): menu->help_text is now `const char **';
7648 adjust.
7649
7650 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7651 to changes in oldXMenu/XMenu.h from 2011-04-16.
7652 (struct XMenu): Declare `help_text' `const char **'.
7653
7654 * xfaces.c <Qunspecified>: Make extern again.
7655
7656 * syntax.c: Include sys/types.h before including regex.h, as
7657 required by POSIX.
7658
7659 * doc.c (get_doc_string): Improve the format passed to `error'.
7660
7661 * doprnt.c (doprnt): Improve commentary.
7662
7663 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7664
7665 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7666 them with etags.
7667
7668 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7669 changes in globals.h immediately force recompilation.
7670 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7671 $(CURDIR)/s/ms-w32.h.
7672 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7673
7674 * character.c (Fchar_direction): Function deleted.
7675 (syms_of_character): Don't defsubr it.
7676 <char-direction-table>: Deleted.
7677
7678 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7679
7680 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7681 * doprnt.c: Include limits.h.
7682 (SIZE_MAX): New macro.
7683 (doprnt): Return a size_t value. 2nd arg is now size_t.
7684 Many local variables are now size_t instead of int or unsigned.
7685 Improve overflow protection. Support `l' modifier for integer
7686 conversions. Support %l conversion. Don't assume an EMACS_INT
7687 argument for integer conversions and for %c.
7688
7689 * lisp.h (doprnt): Restore prototype.
7690
7691 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7692 $(SRC)/character.h.
7693
7694 * Makefile.in (base_obj): Add back doprnt.o.
7695
7696 * deps.mk (doprnt.o): Add back prerequisites.
7697 (callint.o): Depend on character.h.
7698
7699 * eval.c (internal_lisp_condition_case): Include the handler
7700 representation in the error message.
7701 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7702 when breaking from the loop.
7703
7704 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7705
7706 * callint.c (Fcall_interactively): When displaying error message
7707 about invalid control letter, pass the character's codepoint, not
7708 a pointer to its multibyte form. Improve display of the character
7709 in octal and display also its hex code.
7710
7711 * character.c (char_string): Use %x to display the (unsigned)
7712 codepoint of an invalid character, to avoid displaying a bogus
7713 negative value.
7714
7715 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7716 `error', not SYMBOL_NAME itself.
7717
7718 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7719 character arguments to `error'.
7720
7721 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7722 to `error' in error message about FINAL_CHAR argument. Make sure
7723 FINAL_CHAR is a character, and use %c when it is passed as
7724 argument to `error'.
7725
7726 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7727
7728 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7729
7730 * w32.c: Include <time.h>.
7731 (sys_localtime): New function.
7732
7733 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7734
7735 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7736
7737 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7738
7739 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7740
7741 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7742 zombies (Bug#8467).
7743
7744 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7745
7746 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7747 gl_state.e_property when gl_state.object is Qt.
7748
7749 * insdel.c (make_gap_larger): Remove limitation of buffer size
7750 to <= INT_MAX.
7751
7752 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7753
7754 * xdisp.c (lookup_glyphless_char_display)
7755 (produce_glyphless_glyph): Handle cons cell entry in
7756 glyphless-char-display.
7757 (Vglyphless_char_display): Document it.
7758
7759 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7760 glyphless-char-display.
7761
7762 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7763
7764 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7765
7766 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7767
7768 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7769 definition for no-X builds.
7770
7771 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7772
7773 Static checks with GCC 4.6.0 and non-default toolkits.
7774
7775 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7776
7777 * process.c (keyboard_bit_set): Define only if SIGIO.
7778 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7779 (send_process): Repair possible setjmp clobbering.
7780
7781 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7782
7783 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7784
7785 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7786
7787 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7788 Define only if needed.
7789
7790 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7791 by pacifying GCC about it. Maybe it's time to retire it?
7792 * xfaces.c (USG, __TIMEVAL__): Likewise.
7793
7794 * dispextern.h (struct redisplay_interface): Rename param
7795 to avoid shadowing.
7796 * termhooks.h (struct terminal): Likewise.
7797 * xterm.c (xembed_send_message): Likewise.
7798
7799 * insdel.c (make_gap_smaller): Define only if
7800 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7801
7802 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7803 it.
7804
7805 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7806 so that we aren't warned about unused symbols.
7807
7808 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7809
7810 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7811
7812 * xfns.c (x_real_positions): Mark locals as initialized.
7813
7814 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7815
7816 * xterm.c: Fix problems found by static analysis with other toolkits.
7817 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7818 (x_dispatch_event): Declare static if USE_GTK, and
7819 define if USE_GTK || USE_X_TOOLKIT.
7820 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7821 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7822 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7823 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7824
7825 * xmenu.c (menu_help_callback): Pointer type fixes.
7826 Use const pointers when pointing at readonly data. Avoid pointer
7827 signedness clashes.
7828 (FALSE): Remove unused macro.
7829 (update_frame_menubar): Remove unused decl.
7830
7831 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7832
7833 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7834 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7835 (single_menu_item): Rename local to avoid shadowing.
7836
7837 * keyboard.c (make_lispy_event): Remove unused local var.
7838
7839 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7840 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7841
7842 * bitmaps: Change bitmaps from unsigned char back to the X11
7843 compatible char. Avoid the old compiler warnings about
7844 out-of-range initializers by using, for example, '\xab' rather
7845 than 0xab.
7846
7847 * xgselect.c (xgselect_initialize): Check vs interface
7848 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7849
7850 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7851
7852 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7853 to read-only memory.
7854
7855 * fns.c (vector): Remove; this old hack is no longer needed.
7856
7857 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7858 Remove unused var.
7859 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7860
7861 * xrdb.c (x_load_resources): Omit unused local.
7862
7863 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7864 (x_window): Rename locals to avoid shadowing.
7865 (USG): Use the kludged USG macro, to pacify gcc.
7866
7867 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7868 (x_term_init): Remove local to avoid shadowing.
7869
7870 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7871
7872 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7873 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7874
7875 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7876
7877 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7878
7879 Fix regex.c, syntax.c and friends for buffers > 2GB.
7880 * syntax.h (struct gl_state_s): Declare character position members
7881 EMACS_INT.
7882
7883 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7884
7885 * textprop.c (verify_interval_modification, interval_of):
7886 Declare arguments EMACS_INT.
7887
7888 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7889 EMACS_INT.
7890
7891 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7892
7893 * indent.c (Fvertical_motion): Local variable it_start is now
7894 EMACS_INT.
7895
7896 * regex.c (re_match, re_match_2, re_match_2_internal)
7897 (bcmp_translate, regcomp, regexec, print_double_string)
7898 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7899 (re_compile_pattern, re_exec): Declare arguments and local
7900 variables `size_t' and `ssize_t' and return values `regoff_t', as
7901 appropriate.
7902 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7903 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7904 <compile_stack_type>: `size' and `avail' are now `size_t'.
7905
7906 * regex.h <regoff_t>: Use ssize_t, not int.
7907 (re_search, re_search_2, re_match, re_match_2): Arguments that
7908 specify buffer/string position and length are now ssize_t and
7909 size_t. Return type is regoff_t.
7910
7911 2011-04-16 Ben Key <bkey76@gmail.com>
7912
7913 * nsfont.m: Fixed bugs in ns_get_family and
7914 ns_descriptor_to_entity that were caused by using free to
7915 deallocate memory blocks that were allocated by xmalloc (via
7916 xstrdup). This caused Emacs to crash when compiled with
7917 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7918 --enable-checking=xmallocoverrun). xfree is now used to
7919 deallocate these memory blocks.
7920
7921 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7922
7923 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7924
7925 emacs_write: Accept and return EMACS_INT for sizes.
7926 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7927 et seq.
7928 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7929 Accept and return EMACS_INT.
7930 (emacs_gnutls_write): Return the number of bytes written on
7931 partial writes.
7932 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7933 (emacs_read, emacs_write): Remove check for negative size, as the
7934 Emacs source code has been audited now.
7935 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7936 (emacs_read, emacs_write): Use it.
7937 * process.c (send_process): Adjust to the new signatures of
7938 emacs_write and emacs_gnutls_write. Do not attempt to store
7939 a byte offset into an 'int'; it might overflow.
7940 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7941
7942 * sound.c: Don't assume sizes fit in 'int'.
7943 (struct sound_device.period_size, alsa_period_size):
7944 Return EMACS_INT, not int.
7945 (struct sound_device.write, vox_write, alsa_write):
7946 Accept EMACS_INT, not int.
7947 (wav_play, au_play): Use EMACS_INT to store sizes and to
7948 record read return values.
7949
7950 2011-04-15 Ben Key <bkey76@gmail.com>
7951
7952 * keyboard.c (Qundefined): Don't declare static since it is used
7953 in nsfns.m.
7954 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7955 static since they are used in nsfont.m.
7956
7957 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7958
7959 * process.c (Qprocessp): Don't declare static.
7960 * lisp.h (Qprocessp): Declare again.
7961
7962 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7963
7964 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7965
7966 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7967
7968 Improve C-level modularity by making more things 'static'.
7969
7970 Don't publish debugger-only interfaces to other modules.
7971 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7972 (verify_bytepos, count_markers): Move decls to the only modules
7973 that need them.
7974 * region-cache.h (pp_cache): Likewise.
7975 * window.h (check_all_windows): Likewise.
7976 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7977
7978 * sysdep.c (croak): Now static, if
7979 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7980 * syssignal.h (croak): Declare only if not static.
7981
7982 * alloc.c (refill_memory_reserve): Now static if
7983 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7984 * lisp.h (refill_memory_reserve): Declare only if not static.
7985
7986 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7987 Define only if USE_LUCID.
7988
7989 * xrdb.c (x_customization_string, x_rm_string): Now static.
7990
7991 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7992 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7993
7994 * xdisp.c (draw_row_with_mouse_face): Now static.
7995 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7996
7997 * window.h (check_all_windows): Mark externally visible.
7998
7999 * window.c (window_deletion_count): Now static.
8000
8001 * undo.c: Make symbols static if they're not exported.
8002 (last_undo_buffer, last_boundary_position, pending_boundary):
8003 Now static.
8004
8005 * textprop.c (interval_insert_behind_hooks): Now static.
8006 (interval_insert_in_front_hooks): Likewise.
8007
8008 * term.c: Make symbols static if they're not exported.
8009 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8010 (max_frame_lines, tty_set_terminal_modes):
8011 (tty_reset_terminal_modes, tty_turn_off_highlight):
8012 (get_tty_terminal): Now static.
8013 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8014 * termhooks.h (term_mouse_moveto): Do not declare if
8015 HAVE_WINDOW_SYSTEM.
8016 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8017 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8018
8019 * sysdep.c: Make symbols static if they're not exported.
8020 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8021 Now static.
8022 (sigprocmask_set, full_mask): Remove; unused.
8023 (wait_debugging): Mark as visible.
8024 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8025 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8026
8027 * syntax.c (syntax_temp): Define only if !__GNUC__.
8028
8029 * sound.c (current_sound_device, current_sound): Now static.
8030
8031 * search.c (searchbufs, searchbuf_head): Now static.
8032
8033 * scroll.c (scroll_cost): Remove; unused.
8034 * dispextern.h (scroll_cost): Remove decl.
8035
8036 * region-cache.h (pp_cache): Mark as externally visible.
8037
8038 * process.c: Make symbols static if they're not exported.
8039 (process_tick, update_tick, create_process, chan_process):
8040 (Vprocess_alist, proc_buffered_char, datagram_access):
8041 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8042 (deactivate_process): Mark defn as static, as well as decl.
8043 * lisp.h (create_process): Remove decl.
8044 * process.h (chan_process, Vprocess_alist): Remove decls.
8045
8046 * print.c: Make symbols static if they're not exported.
8047 (print_depth, new_backquote_output, being_printed, print_buffer):
8048 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8049 (print_interval, print_number_index, initial_stderr_stream):
8050 Now static.
8051 * lisp.h (Fprinc): Remove decl.
8052 (debug_output_compilation_hack): Mark as externally visible.
8053
8054 * sysdep.c (croak): Move decl from here to syssignal.h.
8055 * syssignal.h (croak): Put it here, so the API can be checked when
8056 'croak' is called from dissociate_if_controlling_tty.
8057
8058 * minibuf.c: Make symbols static if they're not exported.
8059 (minibuf_save_list, choose_minibuf_frame): Now static.
8060 * lisp.h (choose_minibuf_frame): Remove decl.
8061
8062 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8063
8064 * lread.c: Make symbols static if they're not exported.
8065 (read_objects, initial_obarray, oblookup_last_bucket_number):
8066 Now static.
8067 (make_symbol): Remove; unused.
8068 * lisp.h (initial_obarray, make_symbol): Remove decls.
8069
8070 * keyboard.c: Make symbols static if they're not exported.
8071 (single_kboard, recent_keys_index, total_keys, recent_keys):
8072 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8073 (this_single_command_key_start, echoing, last_auto_save):
8074 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8075 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8076 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8077 (Vlispy_mouse_stem, double_click_count):
8078 Now static.
8079 (force_auto_save_soon): Define only if SIGDANGER.
8080 (ignore_mouse_drag_p): Now static if
8081 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8082 (print_help): Remove; unused.
8083 (stop_character, last_timer_event): Mark as externally visible.
8084 * keyboard.h (ignore_mouse_drag_p): Declare only if
8085 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8086 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8087 * lisp.h (echoing): Remove decl.
8088 (force_auto_save_soon): Declare only if SIGDANGER.
8089 * xdisp.c (redisplay_window): Simplify code, to make it more
8090 obvious that ignore_mouse_drag_p is not accessed if !defined
8091 USE_GTK && !defined HAVE_NS.
8092
8093 * intervals.c: Make symbols static if they're not exported.
8094 (merge_properties_sticky, merge_interval_right, delete_interval):
8095 Now static.
8096 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8097
8098 * insdel.c: Make symbols static if they're not exported.
8099 However, leave prepare_to_modify_buffer alone. It's never
8100 called from outside this function, but that appears to be a bug.
8101 (combine_after_change_list, combine_after_change_buffer):
8102 (adjust_after_replace, signal_before_change): Now static.
8103 (adjust_after_replace_noundo): Remove; unused.
8104 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8105 (signal_before_change): Remove decls.
8106
8107 * indent.c (val_compute_motion, val_vmotion): Now static.
8108
8109 * image.c: Make symbols static if they're not exported.
8110 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8111 if USE_GTK.
8112 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8113 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8114
8115 * fringe.c (standard_bitmaps): Now static.
8116 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8117
8118 * frame.c: Make symbols static if they're not exported.
8119 (x_report_frame_params, make_terminal_frame): Now static.
8120 (get_frame_param): Now static, unless HAVE_NS.
8121 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8122 (x_get_resource_string): Remove; not used.
8123 * frame.h (make_terminal_frame, x_report_frame_params):
8124 (x_get_resource_string); Remove decls.
8125 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8126 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8127
8128 * font.c, fontset.c: Make symbols static if they're not exported.
8129 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8130 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8131 * font.c (font_close_object): Now static.
8132 * font.h (font_close_object): Remove.
8133 * fontset.c (FONTSET_OBJLIST): Remove.
8134 (free_realized_fontset) #if-0 the body, which does nothing.
8135 (face_suitable_for_char_p): #if-0, as it's never called.
8136 * fontset.h (face_suitable_for_char_p): Remove decl.
8137 * xfaces.c (face_at_string_position):
8138 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8139 since 0 is always ASCII.
8140
8141 * fns.c (weak_hash_tables): Now static.
8142
8143 * fileio.c: Make symbols static if they're not exported.
8144 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8145 (Vwrite_region_annotation_buffers): Now static.
8146
8147 * eval.c: Make symbols static if they're not exported.
8148 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8149 * lisp.h (backtrace_list): Remove decl.
8150
8151 * emacs.c: Make symbols static if they're not exported.
8152 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8153 (fatal_error_code, fatal_error_signal_hook, standard_args):
8154 Now static.
8155 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8156 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8157 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8158 * lisp.h (fatal_error_signal_hook): Remove decl.
8159 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8160
8161 * editfns.c: Move a (normally-unused) function to its only use.
8162 * editfns.c, lisp.h (get_operating_system_release): Remove.
8163 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8164 worth the hassle of breaking this out.
8165
8166 * xterm.c: Make symbols static if they're not exported.
8167 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8168 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8169 (x_destroy_window, x_delete_display):
8170 Now static.
8171 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8172 (x_mouse_leave): Remove; unused.
8173 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8174 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8175 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8176 Remove decls.
8177 (x_mouse_leave): Declare only if WINDOWSNT.
8178 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8179 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8180 USE_X_TOOLKIT.
8181
8182 * ftxfont.c: Make symbols static if they're not exported.
8183 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8184 HAVE_FREETYPE.
8185 * font.h (ftxfont_driver): Likewise.
8186
8187 * xfns.c: Make symbols static if they're not exported.
8188 (x_last_font_name, x_display_info_for_name):
8189 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8190 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8191 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8192 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8193 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8194 (last_show_tip_args): Now static.
8195 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8196 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8197 (x_screen_planes): Remove; unused.
8198 * dispextern.h (x_screen_planes): Remove decl.
8199
8200 * dispnew.c: Make symbols static if they're not exported.
8201 * dispextern.h (redraw_garbaged_frames, scrolling):
8202 (increment_row_positions): Remove.
8203 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8204 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8205 Now static.
8206 (redraw_garbaged_frames): Remove; unused.
8207
8208 * xfaces.c: Make symbols static if they're not exported.
8209 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8210 Remove decls.
8211 * xterm.h (defined_color): Remove decls.
8212 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8213 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8214 (menu_face_changed_default, defined_color, free_realized_face):
8215 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8216 (ascii_face_of_lisp_face): Remove; unused.
8217
8218 * xdisp.c: Make symbols static if they're not exported.
8219 * dispextern.h (scratch_glyph_row, window_box_edges):
8220 (glyph_to_pixel_coords, set_cursor_from_row):
8221 (get_next_display_element, set_iterator_to_next):
8222 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8223 (show_mouse_face): Remove decls
8224 * frame.h (message_buf_print): Likewise.
8225 * lisp.h (pop_message, set_message, check_point_in_composition):
8226 Likewise.
8227 * xterm.h (set_vertical_scroll_bar): Likewise.
8228 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8229 (message_buf_print, scratch_glyph_row, displayed_buffer):
8230 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8231 (get_next_display_element, show_mouse_face, window_box_edges):
8232 (frame_to_window_pixel_xy, check_point_in_composition):
8233 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8234 (glyph_to_pixel_coords): Remove; unused.
8235
8236 * dired.c (file_name_completion): Now static.
8237
8238 * dbusbind.c (xd_in_read_queued_messages): Now static.
8239
8240 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8241 * data.c (circular_list_error): Remove.
8242
8243 * commands.h (last_point_position, last_point_position_buffer):
8244 (last_point_position_window): Remove decls.
8245 * keyboard.c: Make these variables static.
8246
8247 * coding.h (coding, code_convert_region, encode_coding_gap):
8248 Remove decls.
8249 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8250 (iso_code_class, detect_coding, code_convert_region): Now static.
8251 (encode_coding_gap): Remove; unused.
8252
8253 * chartab.c (chartab_chars, chartab_bits): Now static.
8254
8255 * charset.h (charset_iso_8859_1): Remove decl.
8256 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8257 Now static.
8258
8259 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8260 * ccl.c (Vccl_program_table): Now static.
8261 (check_ccl_update): Remove; unused.
8262
8263 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8264 * category.h: ... from here.
8265 * category.c (check_category_table, set_category_set): Now static.
8266
8267 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8268 * lisp.h: Remove these decls.
8269
8270 * buffer.c (buffer_count): Remove unused var.
8271
8272 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8273 so that it's not optimized away.
8274 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8275 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8276 exported only to the debugger.
8277
8278 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8279 * atimer.h (run_all_atimers): Remove; not exported.
8280
8281 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8282 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8283 was inaccessible from Lisp.
8284 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8285 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8286
8287 alloc.c: Import and export fewer symbols, and remove unused items.
8288 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8289 is defined.
8290 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8291 it's not optimized away by whole-program optimization.
8292 (message_enable_multibyte, free_misc): Remove.
8293 (catchlist, handlerlist, mark_backtrace):
8294 Declare only if BYTE_MARK_STACK.
8295 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8296 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8297 (message_enable_multibyte): Remove decl.
8298 (free_misc, interval_free_list, float_block, float_block_index):
8299 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8300 (cons_free_list, last_marked_index):
8301 Now static.
8302 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8303 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8304 (mark_backtrace): Define only if BYTE_MARK_STACK.
8305 * xdisp.c (message_enable_multibyte): Now static.
8306
8307 Declare Lisp_Object Q* variables to be 'static' if not exported.
8308 This makes it easier for human readers (and static analyzers)
8309 to see whether these variables are used from other modules.
8310 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8311 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8312 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8313 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8314 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8315 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8316 * xmenu.c, xselect.c:
8317 Declare Q* vars static if they are not used in other modules.
8318 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8319 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8320 Remove decls of unexported vars.
8321 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8322
8323 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8324
8325 Make Emacs functions such as Fatom 'static' by default.
8326 This makes it easier for human readers (and static analyzers)
8327 to see whether these functions can be called from other modules.
8328 DEFUN now defines a static function. To make the function external
8329 so that it can be used in other C modules, use the new macro DEFUE.
8330 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8331 (Finit_image_library):
8332 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8333 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8334 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8335 Remove decls, since these functions are now static.
8336 (Funintern, Fget_internal_run_time): New decls, since these functions
8337 were already external.
8338
8339 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8340 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8341 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8342 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8343 * keyboard.c, keymap.c, lread.c:
8344 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8345 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8346 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8347 Mark functions with DEFUE instead of DEFUN,
8348 if they are used in other modules.
8349 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8350 decls for now-static functions.
8351 * buffer.h (Fdelete_overlay): Remove decl.
8352 * callproc.c (Fgetenv_internal): Mark as internal.
8353 * composite.c (Fremove_list_of_text_properties): Remove decl.
8354 (Fcomposition_get_gstring): New forward static decl.
8355 * composite.h (Fcomposite_get_gstring): Remove decl.
8356 * dired.c (Ffile_attributes): New forward static decl.
8357 * doc.c (Fdocumntation_property): New forward static decl.
8358 * eval.c (Ffetch_bytecode): New forward static decl.
8359 (Funintern): Remove extern decl; now in .h file where it belongs.
8360 * fileio.c (Fmake_symbolic_link): New forward static decl.
8361 * image.c (Finit_image_library): New forward static decl.
8362 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8363 * intervals.h (Fprevious_property_change):
8364 (Fremove_list_of_text_properties): Remove decls.
8365 * keyboard.c (Fthis_command_keys): Remove decl.
8366 (Fcommand_execute): New forward static decl.
8367 * keymap.c (Flookup_key): New forward static decl.
8368 (Fcopy_keymap): Now static.
8369 * keymap.h (Flookup_key): Remove decl.
8370 * process.c (Fget_process): New forward static decl.
8371 (Fprocess_datagram_address): Mark as internal.
8372 * syntax.c (Fsyntax_table_p): New forward static decl.
8373 (skip_chars): Remove duplicate decl.
8374 * textprop.c (Fprevious_property_change): New forward static decl.
8375 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8376 Now internal.
8377 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8378 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8379
8380 * editfns.c (Fformat): Remove unreachable code.
8381
8382 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8383
8384 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8385 change. (Bug#8496)
8386
8387 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8388
8389 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8390 when at ZV. (Bug#8487)
8391
8392 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8393
8394 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8395 (Bug#8437)
8396 * keyboard.c (parse_tool_bar_item): Likewise.
8397 * sound.c (sound_cleanup, alsa_close): Likewise.
8398 * termcap.c (tgetent): Likewise.
8399 * xfns.c (x_default_font_parameter): Likewise.
8400 * xsettings.c (read_and_apply_settings): Likewise.
8401
8402 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8403 (overrun_check_free): Protoize.
8404
8405 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8406
8407 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8408 since callers should never pass a negative size.
8409 Change the signature to match that of plain 'read' and 'write'; see
8410 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8411 * lisp.h: Update prototypes of emacs_write and emacs_read.
8412
8413 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8414
8415 * xdisp.c (redisplay_window): Don't try to determine the character
8416 position of the scroll margin if the window start point w->startp
8417 is outside the buffer's accessible region. (Bug#8468)
8418
8419 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8420
8421 Fix write-region and its subroutines for buffers > 2GB.
8422 * fileio.c (a_write, e_write): Modify declaration of arguments and
8423 local variables to support buffers larger than 2GB.
8424 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8425
8426 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8427 argument, local variables, and return value.
8428
8429 * lisp.h: Update prototypes of emacs_write and emacs_read.
8430
8431 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8432
8433 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8434
8435 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8436
8437 Fix more problems found by GCC 4.6.0's static checks.
8438
8439 * xdisp.c (vmessage): Use a better test for character truncation.
8440
8441 * charset.c (load_charset_map): <, not <=, for optimization,
8442 and to avoid potential problems with integer overflow.
8443 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8444 * casetab.c (set_identity, shuffle): Likewise.
8445 * editfns.c (Fformat): Likewise.
8446 * syntax.c (skip_chars): Likewise.
8447
8448 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8449 This also lets GCC 4.6.0 generate slightly better loop code.
8450
8451 * callint.c (Fcall_interactively): <, not <=, for optimization.
8452 (Fcall_interactively): Count the number of arguments produced,
8453 not the number of arguments given. This is simpler and lets GCC
8454 4.6.0 generate slightly better code.
8455
8456 * ftfont.c: Distingish more carefully between FcChar8 and char.
8457 The previous code passed unsigned char * to a functions like
8458 strlen and xstrcasecmp that expect char *, which does not
8459 conform to the C standard.
8460 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8461 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8462 char * when the C standard requires it.
8463
8464 * keyboard.c (read_char): Remove unused var.
8465
8466 * eval.c: Port to Windows vsnprintf (Bug#8435).
8467 Include <limits.h>.
8468 (SIZE_MAX): Define if the headers do not.
8469 (verror): Do not give up if vsnprintf returns a negative count.
8470 Instead, grow the buffer. This ports to Windows vsnprintf, which
8471 does not conform to C99. Problem reported by Eli Zaretskii.
8472 Also, simplify the allocation scheme, by avoiding the need for
8473 calling realloc, and removing the ALLOCATED variable.
8474
8475 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8476
8477 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8478 But keep the doprint source code for now, as we might revamp it
8479 and use it again (Bug#8435).
8480 * lisp.h (doprnt): Remove.
8481 * Makefile.in (base_obj): Remove doprnt.o.
8482 * deps.mk (doprnt.o): Remove.
8483
8484 error: Print 32- and 64-bit integers portably (Bug#8435).
8485 Without this change, on typical 64-bit hosts error ("...%d...", N)
8486 was used to print both 32- and 64-bit integers N, which relied on
8487 undefined behavior.
8488 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8489 * lisp.h (error, verror): Mark as printf-like functions.
8490 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8491 Report overflow in size calculations when allocating printf buffer.
8492 Do not truncate output string at its first null byte.
8493 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8494 Truncate the output at a character boundary, since vsnprintf does not
8495 do that.
8496 * charset.c (check_iso_charset_parameter): Convert internal
8497 character to string before calling 'error', since %c now has the
8498 printf meaning.
8499 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8500 overflow when computing char to be passed to 'error'. Do not
8501 pass Lisp_Object to 'error'; pass the integer instead.
8502 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8503 formatted with plain %d.
8504
8505 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8506
8507 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8508
8509 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8510
8511 * xterm.c (x_catch_errors): Remove duplicate declaration.
8512
8513 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8514
8515 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8516
8517 2011-04-10 Jim Meyering <meyering@redhat.com>
8518
8519 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8520 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8521 return ssize_t not "int", and use size_t as the buffer length.
8522 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8523 * gnutls.h: Update declarations.
8524 * process.c (read_process_output): Use ssize_t, to match.
8525 (send_process): Likewise.
8526
8527 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8528
8529 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8530
8531 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8532
8533 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8534 Use unsigned char, to match FcChar8 type definition.
8535
8536 * xterm.c (handle_one_xevent):
8537 * xmenu.c (create_and_show_popup_menu):
8538 * xselect.c (x_decline_selection_request)
8539 (x_reply_selection_request): Avoid type-punned deref of X events.
8540
8541 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8542
8543 Fix some uses of `int' instead of EMACS_INT.
8544 * search.c (string_match_1, fast_string_match)
8545 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8546 (scan_buffer, find_next_newline_no_quit)
8547 (find_before_next_newline, search_command, Freplace_match)
8548 (Fmatch_data): Make some `int' variables be EMACS_INT.
8549
8550 * xdisp.c (display_count_lines): 3rd argument and return value now
8551 EMACS_INT. All callers changed.
8552 (pint2hrstr): Last argument is now EMACS_INT.
8553
8554 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8555 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8556 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8557 (decode_coding_utf_16, decode_coding_emacs_mule)
8558 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8559 (decode_coding_ccl, decode_coding_charset)
8560 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8561 (decode_coding_iso_2022, decode_coding_emacs_mule)
8562 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8563 <char_offset, last_offset>: Declare EMACS_INT.
8564 (encode_coding_utf_8, encode_coding_utf_16)
8565 (encode_coding_emacs_mule, encode_invocation_designation)
8566 (encode_designation_at_bol, encode_coding_iso_2022)
8567 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8568 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8569 Declare EMACS_INT.
8570 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8571 (encode_invocation_designation): Last argument P_NCHARS is now
8572 EMACS_INT.
8573 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8574 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8575
8576 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8577 All users changed.
8578
8579 * ccl.c (Fccl_execute_on_string): Declare some variables
8580 EMACS_INT.
8581
8582 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8583
8584 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8585
8586 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8587
8588 * process.c (Fformat_network_address): Doc fix.
8589
8590 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8591
8592 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8593
8594 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8595
8596 * keyboard.c (read_char): Call Lisp function help-form-show,
8597 instead of using internal_with_output_to_temp_buffer.
8598 (Qhelp_form_show): New var.
8599 (syms_of_keyboard): Use DEFSYM macro.
8600
8601 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8602
8603 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8604
8605 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8606
8607 * process.c (Flist_processes): Remove to Lisp.
8608 (list_processes_1): Delete.
8609
8610 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8611
8612 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8613
8614 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8615
8616 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8617
8618 Fix more problems found by GCC 4.6.0's static checks.
8619
8620 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8621
8622 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8623
8624 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8625
8626 * xdisp.c (vmessage): Mark as a printf-like function.
8627
8628 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8629
8630 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8631
8632 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8633 printf-like functions.
8634 (tiff_load): Add casts to remove these marks before passing them
8635 to system-supplied API.
8636
8637 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8638
8639 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8640 This avoids several warnings with gcc -Wstrict-overflow.
8641 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8642 directly, rather than having caller test rule sign. This avoids
8643 some unnecessary tests.
8644 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8645 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8646 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8647
8648 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8649 (xfont_open): Avoid unnecessary tests.
8650
8651 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8652
8653 * composite.h, composite.c (composition_gstring_put_cache):
8654 Use EMACS_INT, not int, for length.
8655
8656 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8657 breaking out part of COMPOSITION_DECODE_RULE.
8658 (COMPOSITION_DECODE_RULE): Use it.
8659 * composite.c (get_composition_id): Remove unused local vars,
8660 by using the new macro.
8661
8662 * textprop.c (set_text_properties_1): Change while to do-while,
8663 since the condition is always true at first.
8664
8665 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8666 (interval_deletion_adjustment): Return unsigned value.
8667 All uses changed.
8668
8669 * process.c (list_processes_1, create_pty, read_process_output):
8670 (exec_sentinel): Remove vars that were set but not used.
8671 (create_pty): Remove unnecessary "volatile"s.
8672 (Fnetwork_interface_info): Avoid possibility of int overflow.
8673 (read_process_output): Do adaptive read buffering even if carryover.
8674 (read_process_output): Simplify nbytes computation if buffered.
8675
8676 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8677
8678 * syntax.c (scan_words): Remove var that was set but not used.
8679 (update_syntax_table): Use unsigned instead of int.
8680
8681 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8682 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8683 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8684
8685 * print.c (print_error_message): Avoid int overflow.
8686
8687 * font.c (font_list_entities): Redo for clarity,
8688 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8689
8690 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8691 (font_score): Avoid potential overflow in diff calculation.
8692
8693 * fns.c (substring_both): Remove var that is set but not used.
8694 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8695
8696 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8697
8698 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8699 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8700 can always succeed if overflow has undefined behavior.
8701
8702 * search.c (boyer_moore, wordify): Remove vars set but not used.
8703 (wordify): Omit three unnecessary tests.
8704
8705 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8706 All callers changed. This avoids the need for an unused var.
8707
8708 * casefiddle.c (casify_region): Remove var that is set but not used.
8709
8710 * dired.c (file_name_completion): Remove var that is set but not used.
8711
8712 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8713
8714 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8715 (Finsert_file_contents): Remove unnecessary code checking fd.
8716
8717 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8718 Check for integer overflow on size calculations.
8719
8720 * buffer.c (Fprevious_overlay_change): Remove var that is set
8721 but not used.
8722
8723 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8724 Remove vars that are set but not used.
8725 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8726 (timer_check_2): Mark vars as initialized.
8727
8728 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8729
8730 * image.c (lookup_image): Remove var that is set but not used.
8731 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8732
8733 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8734 that are set but not used.
8735
8736 * xfns.c (make_invisible_cursor): Don't return garbage
8737 if XCreateBitmapFromData fails (Bug#8410).
8738
8739 * xselect.c (x_get_local_selection, x_handle_property_notify):
8740 Remove vars that are set but not used.
8741
8742 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8743 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8744
8745 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8746 Remove var that is set but not used.
8747 (scroll_bar_windows_size): Now size_t, not int.
8748 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8749 Check for overflow.
8750
8751 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8752 (map_tty_color) [!defined MSDOS]: Likewise.
8753
8754 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8755
8756 * coding.c: Remove vars that are set but not used.
8757 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8758 All callers changed.
8759 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8760 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8761 (decode_coding_charset): Remove vars that are set but not used.
8762
8763 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8764 that is set but not used.
8765
8766 * print.c (print_object): Remove var that is set but not used.
8767
8768 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8769 The gnulib version avoids calling malloc in the usual case,
8770 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8771 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8772 * filelock.c (current_lock_owner): Likewise.
8773 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8774 * sysdep.c: Include allocator.h, careadlinkat.h.
8775 (emacs_no_realloc_allocator): New static constant.
8776 (emacs_readlink): New function.
8777 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8778 ../lib/careadlinkat.h.
8779
8780 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8781
8782 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8783 first non-nil return value).
8784
8785 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8786
8787 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8788 if not defined (Bug#8403).
8789
8790 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8791
8792 * xdisp.c (display_count_lines): Remove parameter `start',
8793 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8794 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8795 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8796 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8797 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8798 and thereabouts. All callers changed.
8799 (get_per_char_metric): Remove parameter `f', unused since
8800 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8801
8802 2011-04-02 Jim Meyering <meyering@redhat.com>
8803
8804 do not dereference NULL upon failed strdup
8805 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8806 (ns_get_family): Likewise.
8807
8808 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8809
8810 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8811
8812 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8813
8814 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8815 later (Bug#8403).
8816
8817 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8818
8819 Add lexical binding.
8820
8821 * window.c (Ftemp_output_buffer_show): New fun.
8822 (Fsave_window_excursion):
8823 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8824
8825 * lread.c (lisp_file_lexically_bound_p): New function.
8826 (Fload): Bind Qlexical_binding.
8827 (readevalloop): Remove `evalfun' arg.
8828 Bind Qinternal_interpreter_environment.
8829 (Feval_buffer): Bind Qlexical_binding.
8830 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8831 Mark as dynamic.
8832 (syms_of_lread): Declare `lexical-binding'.
8833
8834 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8835
8836 * keyboard.c (eval_dyn): New fun.
8837 (menu_item_eval_property): Use it.
8838
8839 * image.c (parse_image_spec): Use Ffunctionp.
8840
8841 * fns.c (concat, mapcar1): Accept byte-code-functions.
8842
8843 * eval.c (Fsetq): Handle lexical vars.
8844 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8845 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8846 (FletX, Flet): Obey lexical binding.
8847 (Fcommandp): Handle closures.
8848 (Feval): New `lexical' arg.
8849 (eval_sub): New function extracted from Feval. Use it almost
8850 everywhere where Feval was used. Look up vars in lexical env.
8851 Handle closures.
8852 (Ffunctionp): Move from subr.el.
8853 (Ffuncall): Handle closures.
8854 (apply_lambda): Remove `eval_flags'.
8855 (funcall_lambda): Handle closures and new byte-code-functions.
8856 (Fspecial_variable_p): New function.
8857 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8858 but without exporting it to Lisp.
8859
8860 * doc.c (Fdocumentation, store_function_docstring):
8861 * data.c (Finteractive_form): Handle closures.
8862
8863 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8864 interactive spec.
8865
8866 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8867 New byte-codes.
8868 (exec_byte_code): New function extracted from Fbyte_code to handle new
8869 calling convention for byte-code-functions. Add new byte-codes.
8870
8871 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8872
8873 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8874
8875 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8876
8877 * xdisp.c (redisplay_internal): Fix prototype.
8878
8879 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8880
8881 * xdisp.c (SCROLL_LIMIT): New macro.
8882 (try_scrolling): Use it when setting scroll_limit.
8883 Limit scrolling to 100 screen lines.
8884 (redisplay_window): Even when falling back on "recentering",
8885 position point in the window according to scroll-conservatively,
8886 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8887
8888 (try_scrolling): When point is above the window, allow searching
8889 as far as scroll_max, or one screenful, to compute vertical
8890 distance from PT to the scroll margin position. This prevents
8891 try_scrolling from unnecessarily failing when
8892 scroll-conservatively is set to a value slightly larger than the
8893 window height. Clean up the case of PT below the margin at bottom
8894 of window: scroll_max can no longer be INT_MAX. When aggressive
8895 scrolling is in use, don't let point enter the opposite scroll
8896 margin as result of the scroll.
8897 (syms_of_xdisp) <scroll-conservatively>: Document the
8898 threshold of 100 lines for never-recentering scrolling.
8899
8900 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8901
8902 * dispextern.h (move_it_by_lines):
8903 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8904 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8905 (message_log_check_duplicate): Remove parameters `prev_bol' and
8906 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8907 (redisplay_internal): Remove parameter `preserve_echo_area',
8908 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8909
8910 * indent.c (Fvertical_motion):
8911 * window.c (window_scroll_pixel_based, Frecenter):
8912 Don't pass `need_y_p' to `move_it_by_lines'.
8913
8914 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8915
8916 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8917 steal a few bits to be more compact.
8918 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8919 Remove unneeded casts.
8920
8921 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8922
8923 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8924
8925 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8926 binding" message (bug#7967).
8927
8928 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8929
8930 Fix more problems found by GCC 4.6.0's static checks.
8931
8932 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8933 Remove unused local var.
8934
8935 * editfns.c (Fmessage_box): Remove unused local var.
8936
8937 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8938 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8939 Omit unused local vars.
8940 * window.c (shrink_windows): Omit unused local var.
8941 * menu.c (digest_single_submenu): Omit unused local var.
8942 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8943 Omit unused local var.
8944
8945 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8946 Don't assume string length fits in int.
8947 (keyremap_step, read_key_sequence): Use size_t for sizes.
8948 (read_key_sequence): Don't check last_real_key_start redundantly.
8949
8950 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8951 instead of alloca (Bug#8344).
8952
8953 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8954 (Fbacktrace_frame): Don't assume nframes fits in int.
8955
8956 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8957
8958 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8959 concerns.
8960
8961 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8962
8963 * cm.c (calccost): Turn while-do into do-while, for clarity.
8964
8965 * keyboard.c (syms_of_keyboard): Use the same style as later
8966 in this function when indexing through an array. This also
8967 works around GCC bug 48267.
8968
8969 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8970
8971 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8972
8973 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8974 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8975
8976 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8977 This avoids undefined behavior on integer overflow, and is a bit
8978 more convenient anyway since it is compared to a size_t variable.
8979
8980 Variadic C functions now count arguments with size_t, not int.
8981 This avoids an unnecessary limitation on 64-bit machines, which
8982 caused (substring ...) to crash on large vectors (Bug#8344).
8983 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8984 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8985 All variadic functions and their callers changed accordingly.
8986 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8987 * data.c (arith_driver, float_arith_driver): Likewise.
8988 * editfns.c (general_insert_function): Likewise.
8989 * eval.c (struct backtrace.nargs, interactive_p)
8990 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8991 (funcall_lambda, mark_backtrace): Likewise.
8992 * fns.c (concat): Likewise.
8993 * frame.c (x_set_frame_parameters): Likewise.
8994 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8995 0 if not found, not -1. All callers changed.
8996
8997 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8998 (stack_copy_size): Now size_t, not int.
8999 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9000
9001 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9002
9003 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9004 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9005 All callers changed.
9006
9007 * lisp.h (multibyte_char_to_unibyte):
9008 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9009 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9010 * character.h (CHAR_TO_BYTE8):
9011 * cmds.c (internal_self_insert):
9012 * editfns.c (general_insert_function):
9013 * keymap.c (push_key_description):
9014 * search.c (Freplace_match):
9015 * xdisp.c (message_dolog, set_message_1): All callers changed.
9016
9017 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9018
9019 * keyboard.c (safe_run_hook_funcall): New function.
9020 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9021 don't set the hook to nil, but remove the offending function instead.
9022 (Qcommand_hook_internal): Remove, unused.
9023 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9024 Vcommand_hook_internal.
9025
9026 * eval.c (enum run_hooks_condition): Remove.
9027 (funcall_nil, funcall_not): New functions.
9028 (run_hook_with_args): Call each function through a `funcall' argument.
9029 Remove `cond' argument, now redundant.
9030 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9031 (Frun_hook_with_args_until_failure): Adjust accordingly.
9032 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9033
9034 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9035
9036 * dispextern.h (string_buffer_position): Remove declaration.
9037
9038 * print.c (strout): Remove parameter `multibyte', unused since
9039 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9040
9041 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9042 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9043 All callers changed.
9044
9045 * w32.c (_wsa_errlist): Use braces for struct initializers.
9046
9047 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9048 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9049 All callers changed.
9050 (string_buffer_position): Likewise. Also, make static (it's never
9051 used outside xdisp.c).
9052 (cursor_row_p): Remove parameter `w', unused since
9053 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9054 (decode_mode_spec): Remove parameter `precision', introduced during
9055 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9056 All callers changed.
9057
9058 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9059
9060 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9061
9062 2011-03-27 Anders Lindgren <andlind@gmail.com>
9063
9064 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9065 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9066 (ns_update_auto_hide_menu_bar): New functions.
9067 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9068 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9069 ns_constrain_all_frames.
9070 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9071 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9072
9073 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9074
9075 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9076
9077 2011-03-27 Glenn Morris <rgm@gnu.org>
9078
9079 * syssignal.h: Replace RETSIGTYPE with void.
9080 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9081 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9082 Replace SIGTYPE with void everywhere.
9083 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9084 * s/template.h (SIGTYPE): Remove commented out definition.
9085
9086 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9087
9088 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9089 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9090
9091 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9092
9093 * w32.c (read_unc_volume): Use parameter `henum', instead of
9094 global variable `wget_enum_handle'.
9095
9096 * keymap.c (describe_vector): Remove parameters `indices' and
9097 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9098 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9099
9100 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9101
9102 * keyboard.c (timer_check): Remove parameter `do_it_now',
9103 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9104 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9105 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9106
9107 * keyboard.c (read_char):
9108 * w32menu.c (w32_menu_display_help):
9109 * xmenu.c (show_help_event, menu_help_callback):
9110 Adjust calls to `show_help_echo'.
9111
9112 * gtkutil.c (xg_maybe_add_timer):
9113 * keyboard.c (readable_events):
9114 * process.c (wait_reading_process_output):
9115 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9116
9117 * insdel.c (adjust_markers_gap_motion):
9118 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9119 (gap_left, gap_right): Don't call it.
9120
9121 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9122
9123 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9124 incurred during fontification.
9125
9126 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9127
9128 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9129 (DEFVAR_PER_BUFFER): Don't pass it.
9130
9131 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9132 (scrolling_window): Don't pass it.
9133
9134 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9135
9136 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9137
9138 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9139 and `suffix'.
9140 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9141 of variables specific to SELinux and computation of `encoded_absname'.
9142
9143 * image.c (XPutPixel): Remove unused variable `height'.
9144
9145 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9146
9147 * unexw32.c (get_section_info): Remove unused variable `section'.
9148
9149 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9150 (system_process_attributes): Remove unused variable `sess'.
9151 (sys_read): Remove unused variable `err'.
9152
9153 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9154 (w32_wnd_proc): Remove unused variable `isdead'.
9155 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9156 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9157 (x_create_tip_frame): Remove unused variable `tem'.
9158
9159 * w32inevt.c (w32_console_read_socket):
9160 Remove unused variable `no_events'.
9161
9162 * w32term.c (x_draw_composite_glyph_string_foreground):
9163 Remove unused variable `width'.
9164
9165 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9166
9167 * w32term.c (x_set_glyph_string_clipping):
9168 Don't pass uninitialized region to CombineRgn.
9169
9170 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9171
9172 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9173 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9174 (Fx_close_connection): Remove unused variable `i'.
9175
9176 * w32font.c (w32font_draw): Return number of glyphs.
9177 (w32font_open_internal): Remove unused variable `i'.
9178 (w32font_driver): Add missing initializer.
9179
9180 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9181 (fill_in_menu): Remove unused variable `items_added'.
9182
9183 * w32term.c (last_mouse_press_frame): Remove static global variable.
9184 (w32_clip_to_row): Remove unused variable `f'.
9185 (x_delete_terminal): Remove unused variable `i'.
9186
9187 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9188 (NOTHING): Remove unused static global variable.
9189 (uniscribe_check_otf): Remove unused variable `table'.
9190 (uniscribe_font_driver): Add missing initializers.
9191
9192 2011-03-23 Julien Danjou <julien@danjou.info>
9193
9194 * term.c (Fsuspend_tty, Fresume_tty):
9195 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9196 * window.c (temp_output_buffer_show):
9197 * insdel.c (signal_before_change):
9198 * frame.c (Fhandle_switch_frame):
9199 * fileio.c (Fdo_auto_save):
9200 * emacs.c (Fkill_emacs):
9201 * editfns.c (save_excursion_restore):
9202 * cmds.c (internal_self_insert):
9203 * callint.c (Fcall_interactively):
9204 * buffer.c (Fkill_all_local_variables):
9205 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9206 Use Frun_hooks.
9207 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9208 unconditionally since it does the check itself.
9209
9210 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9211
9212 Fix more problems found by GCC 4.5.2's static checks.
9213
9214 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9215 the first time through the loop, since we know p0 < p1 then.
9216 This also avoids a gcc -Wstrict-overflow warning.
9217
9218 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9219 leading to a memory leak, possible in functions like
9220 load_charset_map_from_file that can allocate an unbounded number
9221 of objects (Bug#8318).
9222
9223 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9224 that could (at least in theory) be that large.
9225
9226 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9227 This is less likely to overflow, and avoids undefined behavior if
9228 overflow does occur. All callers changed. Use strtoul to scan
9229 for the unsigned long integer.
9230 (pint2hrstr): Simplify and tune code slightly.
9231 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9232
9233 * scroll.c (do_scrolling): Work around GCC bug 48228.
9234 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9235
9236 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9237 This also avoids a warning with gcc -Wstrict-overflow.
9238 (validate_x_resource_name): Simplify count usage.
9239 This also avoids a warning with gcc -Wstrict-overflow.
9240
9241 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9242 fail (Bug#8306).
9243
9244 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9245
9246 * process.c (Fmake_network_process): Use socklen_t, not int,
9247 where POSIX says socklen_t is required in portable programs.
9248 This fixes a porting bug on hosts like 64-bit HP-UX, where
9249 socklen_t is wider than int (Bug#8277).
9250 (Fmake_network_process, server_accept_connection):
9251 (wait_reading_process_output, read_process_output):
9252 Likewise.
9253
9254 * process.c: Rename or move locals to avoid shadowing.
9255 (list_processes_1, Fmake_network_process):
9256 (read_process_output_error_handler, exec_sentinel_error_handler):
9257 Rename or move locals.
9258 (Fmake_network_process): Define label "retry_connect" only if needed.
9259 (Fnetwork_interface_info): Fix pointer signedness.
9260 (process_send_signal): Add cast to avoid pointer signedness problem.
9261 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9262 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9263
9264 Make tparam.h and terminfo.c consistent.
9265 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9266 Include tparam.h instead, since it declares them.
9267 * cm.h (PC): Remove extern decl; tparam.h now does this.
9268 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9269 * terminfo.c: Include tparam.h, to check interfaces.
9270 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9271 (tparam): Adjust signature to match interface in tparam.h;
9272 this removes some undefined behavior. Check that outstring and len
9273 are zero, which they always are with Emacs.
9274 * tparam.h (PC, BC, UP): New extern decls.
9275
9276 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9277 (xftfont_open): Rename locals to avoid shadowing.
9278
9279 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9280 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9281 (OTF_TAG_SYM): Omit macro if not needed.
9282 (ftfont_list): Remove unused local.
9283 (get_adstyle_property, ftfont_pattern_entity):
9284 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9285 Rename locals to avoid shadowing.
9286
9287 * xfont.c (xfont_list_family): Mark var as initialized.
9288
9289 * xml.c (make_dom): Now static.
9290
9291 * composite.c (composition_compute_stop_pos): Rename local to
9292 avoid shadowing.
9293 (composition_reseat_it): Remove unused locals.
9294 (find_automatic_composition, composition_adjust_point): Likewise.
9295 (composition_update_it): Mark var as initialized.
9296 (find_automatic_composition): Mark vars as initialized,
9297 with a FIXME (Bug#8290).
9298
9299 character.h: Rename locals to avoid shadowing.
9300 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9301 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9302 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9303 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9304 to avoid shadowing.
9305
9306 * textprop.c (property_change_between_p): Remove; unused.
9307
9308 * intervals.c (interval_start_pos): Now static.
9309
9310 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9311
9312 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9313 Rename locals to avoid shadowing.
9314
9315 * sound.c (wav_play, au_play, Fplay_sound_internal):
9316 Fix pointer signedness.
9317 (alsa_choose_format): Remove unused local var.
9318 (wav_play): Initialize a variable to 0, to prevent undefined
9319 behavior (Bug#8278).
9320
9321 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9322
9323 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9324
9325 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9326 clobbering (Bug#8298).
9327 * sysdep.c (sys_subshell): Likewise.
9328 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9329
9330 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9331 This should get cleaned up, so that child_setup has the
9332 same signature on all platforms.
9333
9334 * callproc.c (call_process_cleanup): Now static.
9335 (relocate_fd): Rename locals to avoid shadowing.
9336
9337 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9338
9339 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9340 not to be necessary, and produces flickering.
9341
9342 2011-03-20 Glenn Morris <rgm@gnu.org>
9343
9344 * config.in: Remove file.
9345
9346 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9347
9348 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9349 are now in src/globals.h.
9350 (syms_of_minibuf): Remove spurious & from previous change.
9351
9352 2011-03-20 Leo Liu <sdl.web@gmail.com>
9353
9354 * minibuf.c (completing-read-function): New variable.
9355 (completing-read-default): Rename from completing-read.
9356 (completing-read): Call completing-read-function.
9357
9358 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9359
9360 * xfaces.c (Fx_load_color_file):
9361 Read color file from absolute filename (bug#8250).
9362
9363 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9364
9365 * makefile.w32-in: Update dependencies.
9366
9367 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9368
9369 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9370
9371 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9372
9373 Fix more problems found by GCC 4.5.2's static checks.
9374
9375 * process.c (make_serial_process_unwind, send_process_trap):
9376 (sigchld_handler): Now static.
9377
9378 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9379 That way, the code declares only the vars that it needs.
9380 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9381 * s/cygwin.h (PTY_ITERATION): Likewise.
9382 * s/darwin.h (PTY_ITERATION): Likewise.
9383 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9384
9385 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9386 * process.c (allocate_pty): Don't declare stb unless it's needed.
9387
9388 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9389 (CONSTANTLIM): Remove; unused.
9390 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9391 Define only if needed.
9392
9393 * unexelf.c (unexec): Name an expression,
9394 to avoid gcc -Wbad-function-cast warning.
9395 Use a different way to cause a compilation error if anyone uses
9396 n rather than nn, a way that does not involve shadowing.
9397 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9398
9399 * deps.mk (unexalpha.o): Remove; unused.
9400
9401 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9402 * unexec.h: New file.
9403 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9404 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9405 Depend on unexec.h.
9406 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9407 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9408 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9409 Change as necessary to match prototype in unexec.h.
9410
9411 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9412 shadowing.
9413 (back_comment, skip_chars): Mark vars as initialized.
9414
9415 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9416 Rename locals to avoid shadowing.
9417
9418 * lread.c (read1): Rewrite so as not to use empty "else".
9419 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9420
9421 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9422
9423 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9424 warning when compiling print.c.
9425
9426 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9427 instead of using an uninitialized var.
9428 (font_sort_entities): Mark var as initialized.
9429
9430 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9431
9432 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9433 pointers to constants.
9434 (font_parse_fcname): Remove unused vars.
9435 (font_delete_unmatched): Now static.
9436 (font_get_spec): Remove; unused.
9437 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9438 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9439 Rename or move locals to avoid shadowing.
9440
9441 * fns.c (require_nesting_list, require_unwind): Now static.
9442 (Ffillarray): Rename locals to avoid shadowing.
9443
9444 * floatfns.c (domain_error2): Define only if needed.
9445 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9446
9447 * alloc.c (mark_backtrace): Move decl from here ...
9448 * lisp.h: ... to here, so that it can be checked.
9449
9450 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9451 (Fdefvar): Rewrite so as not to use empty "else".
9452 (lisp_indirect_variable): Name an expression,
9453 to avoid gcc -Wbad-function-cast warning.
9454 (Fdefvar): Rename locals to avoid shadowing.
9455
9456 * callint.c (quotify_arg, quotify_args): Now static.
9457 (Fcall_interactively): Rename locals to avoid shadowing.
9458 Use const pointer when appropriate.
9459
9460 * lisp.h (get_system_name, get_operating_system_release):
9461 Move decls here, to check interfaces.
9462 * process.c (get_operating_system_release): Move decl to lisp.h.
9463 * xrdb.c (get_system_name): Likewise.
9464 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9465 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9466 some of which prompt warnings from gcc -Wbad-function-cast.
9467 (Fformat_time_string, Fencode_time, Finsert_char):
9468 (Ftranslate_region_internal, Fformat):
9469 Rename or remove local vars to avoid shadowing.
9470 (Ftranslate_region_internal): Mark var as initialized.
9471
9472 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9473 avoid shadowing.
9474
9475 * lisp.h (eassert): Check that the argument compiles, even if
9476 ENABLE_CHECKING is not defined.
9477
9478 * data.c (Findirect_variable): Name an expression, to avoid
9479 gcc -Wbad-function-cast warning.
9480 (default_value, arithcompare, arith_driver, arith_error): Now static.
9481 (store_symval_forwarding): Rename local to avoid shadowing.
9482 (Fmake_variable_buffer_local, Fmake_local_variable):
9483 Mark variables as initialized.
9484 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9485
9486 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9487 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9488 Rename locals to avoid shadowing.
9489 (mark_stack): Move local variables into the #ifdef region where
9490 they're used.
9491 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9492 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9493 needed otherwise.
9494 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9495 (GC_STRING_CHARS): Remove; not used.
9496 (Fmemory_limit): Cast sbrk's returned value to char *.
9497
9498 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9499 avoids undefined behavior in theory.
9500
9501 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9502
9503 Use functions, not macros, for up- and down-casing (Bug#8254).
9504 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9505 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9506 to use the following functions instead of these macros.
9507 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9508 EMACS_INT, since callers assume the returned value fits in int.
9509 (upcase1): Likewise, for UPCASE_TABLE.
9510 (uppercasep, lowercasep, upcase): New static inline functions.
9511 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9512 the race-condition problem in the old DOWNCASE.
9513
9514 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9515 Rename locals to avoid shadowing.
9516 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9517 (regex_compile, re_search_2, re_match_2_internal):
9518 Remove unused local vars.
9519 (FREE_VAR): Rewrite so as not to use empty "else",
9520 which gcc can warn about.
9521 (regex_compile, re_match_2_internal): Mark locals as initialized.
9522 (RETALLOC_IF): Define only if needed.
9523 (WORDCHAR_P): Likewise. This one is never needed, but is used
9524 only in a comment talking about a compiler bug, so put inside
9525 the #if 0 of that comment.
9526 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9527 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9528 Remove; unused.
9529
9530 * search.c (boyer_moore): Rename locals to avoid shadowing.
9531 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9532 (PREV_CHAR_BOUNDARY): Likewise.
9533
9534 * search.c (simple_search): Remove unused var.
9535
9536 * dired.c (compile_pattern): Move decl from here ...
9537 * lisp.h: ... to here, so that it can be checked.
9538 (struct re_registers): New forward decl.
9539
9540 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9541
9542 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9543 All uses changed.
9544 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9545 Rename locals to avoid shadowing.
9546 (Fvertical_motion): Mark locals as initialized.
9547
9548 * casefiddle.c (casify_object, casify_region): Now static.
9549 (casify_region): Mark local as initialized.
9550
9551 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9552
9553 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9554 New macros, so that the caller can use some names other than
9555 gcpro1, gcpro2, etc.
9556 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9557 of the new macros.
9558 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9559 argument, for consistency with GCPRO2_VAR, etc: it is now the
9560 prefix of the variable, not the variable itself. All uses
9561 changed.
9562 * dired.c (directory_files_internal, file_name_completion):
9563 Rename locals to avoid shadowing.
9564
9565 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9566 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9567 dired.c's scmp function, had undefined behavior.
9568 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9569 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9570 * buffer.h: ... to here, because these macros use current_buffer,
9571 and the new implementation with inline functions needs to have
9572 current_buffer in scope now, rather than later when the macros
9573 are used.
9574 (downcase, upcase1): New static inline functions.
9575 (DOWNCASE, UPCASE1): Reimplement using these functions.
9576 This avoids undefined behavior in expressions like
9577 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9578 from race conditions in accessing the global variables
9579 case_temp1 and case_temp2.
9580 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9581 * lisp.h (case_temp1, case_temp2): Remove their decls.
9582 * character.h (ASCII_CHAR_P): Move from here ...
9583 * lisp.h: ... to here, so that the inline functions mentioned
9584 above can use them.
9585
9586 * dired.c (directory_files_internal_unwind): Now static.
9587
9588 * fileio.c (file_name_as_directory, directory_file_name):
9589 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9590 Now static.
9591 (file_name_as_directory): Use const pointers when appropriate.
9592 (Fexpand_file_name): Likewise. In particular, newdir might
9593 point at constant storage, so make it a const pointer.
9594 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9595 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9596 signedness issues.
9597 (Fset_file_times, Finsert_file_contents, auto_save_error):
9598 Rename locals to avoid shadowing.
9599
9600 * minibuf.c (choose_minibuf_frame_1): Now static.
9601 (Ftry_completion, Fall_completions): Rename or remove locals
9602 to avoid shadowing.
9603
9604 * marker.c (bytepos_to_charpos): Remove; unused.
9605
9606 * lisp.h (verify_bytepos, count_markers): New decls,
9607 so that gcc does not warn that these functions aren't declared.
9608
9609 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9610 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9611 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9612 (copy_text): Remove unused local var.
9613
9614 * filelock.c (within_one_second): Now static.
9615 (lock_file_1): Rename local to avoid shadowing.
9616
9617 * buffer.c (fix_overlays_before): Mark locals as initialized.
9618 (fix_start_end_in_overlays): Likewise. This function should be
9619 simplified by using pointers-to-pointers, but that's a different
9620 matter.
9621 (switch_to_buffer_1): Now static.
9622 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9623 (report_overlay_modification): Rename locals to avoid shadowing.
9624
9625 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9626 Fix pointer signedness issue.
9627 (sys_subshell): Mark local as volatile if checking for lint,
9628 to suppress a gcc -Wclobbered warning that does not seem to be right.
9629 (MAXPATHLEN): Define only if needed.
9630
9631 * process.c (serial_open, serial_configure): Move decls from here ...
9632 * systty.h: ... to here, so that they can be checked.
9633
9634 * fns.c (get_random, seed_random): Move extern decls from here ...
9635 * lisp.h: ... to here, so that they can be checked.
9636
9637 * sysdep.c (reset_io): Now static.
9638 (wait_for_termination_signal): Remove; unused.
9639
9640 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9641 (copy_keymap_item, append_key, push_text_char_description):
9642 Now static.
9643 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9644 (DENSE_TABLE_SIZE): Remove; unused.
9645 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9646 (describe_map_tree):
9647 Rename locals to avoid shadowing.
9648
9649 * keyboard.c: Declare functions static if they are not used elsewhere.
9650 (echo_char, echo_dash, cmd_error, top_level_2):
9651 (poll_for_input, handle_async_input): Now static.
9652 (read_char, kbd_buffer_get_event, make_lispy_position):
9653 (make_lispy_event, make_lispy_movement, apply_modifiers):
9654 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9655 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9656 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9657 (read_key_sequence, read_char): Mark locals as initialized.
9658 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9659
9660 * keyboard.h (make_ctrl_char): New decl.
9661 (mark_kboards): Move decl here ...
9662 * alloc.c (mark_kboards): ... from here.
9663
9664 * lisp.h (force_auto_save_soon): New decl.
9665
9666 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9667 (DEFINE_DUMMY_FUNCTION): New macro.
9668 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9669 Use it.
9670 (main): Add casts to avoid warnings
9671 if GCC considers string literals to be constants.
9672
9673 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9674
9675 * dbusbind.c: Pointer signedness fixes.
9676 (xd_signature, xd_append_arg, xd_initialize):
9677 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9678 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9679 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9680 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9681
9682 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9683 if GCC considers string literals to be constants.
9684 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9685
9686 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9687
9688 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9689 (print_preprocess, print_object): New macro to fix last change.
9690
9691 * print.c (print_preprocess): Don't forget font objects.
9692
9693 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9694
9695 * emacs.c (USAGE3): Doc fixes.
9696
9697 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9698
9699 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9700 structure.
9701
9702 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9703
9704 * lisp.h (VWindow_system, Qfile_name_history):
9705 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9706 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9707 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9708
9709 * w32select.c: Don't #include "keyboard.h".
9710 (run_protected): Add extern declaration for waiting_for_input.
9711
9712 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9713 * w32console.c (detect_input_pending, read_input_pending)
9714 (encode_terminal_code):
9715 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9716 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9717 (w32_system_caret_y, Qfile_name_history):
9718 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9719 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9720 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9721 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9722 * w32proc.c (Qlocal, report_file_error):
9723 * w32term.c (Vwindow_system, updating_frame):
9724 * w32uniscribe.c (initialized, uniscribe_font_driver):
9725 Remove unneeded extern declarations.
9726
9727 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9728
9729 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9730
9731 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9732
9733 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9734 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9735 These macros can no longer be used for assignment.
9736
9737 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9738 Assign struct members directly, instead of using BUF_BEGV etc.
9739 (record_buffer_markers, fetch_buffer_markers): New functions for
9740 recording and fetching special buffer markers.
9741 (set_buffer_internal_1, set_buffer_temp): Use them.
9742
9743 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9744
9745 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9746
9747 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9748 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9749
9750 * xdisp.c (hscroll_window_tree):
9751 (reconsider_clip_changes): Use PT instead of BUF_PT.
9752
9753 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9754
9755 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9756 $(EMACS_ROOT)/lib/intprops.h.
9757
9758 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9759
9760 Fix more problems found by GCC 4.5.2's static checks.
9761
9762 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9763 to unsigned char * to avoid compiler diagnostic.
9764 (xg_free_frame_widgets): Make it clear that a local variable is
9765 needed only if USE_GTK_TOOLTIP.
9766 (gdk_window_get_screen): Make it clear that this macro is needed
9767 only if USE_GTK_TOOLTIP.
9768 (int_gtk_range_get_value): New function, which avoids a diagnostic
9769 from gcc -Wbad-function-cast.
9770 (xg_set_toolkit_scroll_bar_thumb): Use it.
9771 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9772 diagnostic from gcc -Wbad-function-cast.
9773 (get_utf8_string, xg_get_file_with_chooser):
9774 Rename locals to avoid shadowing.
9775 (create_dialog): Move locals to avoid shadowing.
9776
9777 * xgselect.c (xg_select): Remove unused var.
9778
9779 * image.c (four_corners_best): Mark locals as initialized.
9780 (gif_load): Initialize transparent_p to zero (Bug#8238).
9781 Mark another local as initialized.
9782 (my_png_error, my_error_exit): Mark with NO_RETURN.
9783
9784 * image.c (clear_image_cache): Now static.
9785 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9786 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9787 (x_edge_detection): Remove unnecessary cast that
9788 gcc -Wbad-function-cast diagnoses.
9789 (gif_load): Fix pointer signedness.
9790 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9791 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9792
9793 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9794
9795 Improve quality of tests for time stamp overflow.
9796 For example, without this patch (encode-time 0 0 0 1 1
9797 1152921504606846976) returns the obviously-bogus value (-948597
9798 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9799 reports time overflow. See
9800 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9801 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9802 * editfns.c: Include limits.h and intprops.h.
9803 (TIME_T_MIN, TIME_T_MAX): New macros.
9804 (time_overflow): Move earlier, to before first use.
9805 (hi_time, lo_time): New functions, for an accurate test for
9806 out-of-range times.
9807 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9808 (Fget_internal_run_time): Don't assume time_t fits in int.
9809 (make_time): Use list2 instead of Fcons twice.
9810 (Fdecode_time): More accurate test for out-of-range times.
9811 (check_tm_member): New function.
9812 (Fencode_time): Use it, to test for out-of-range times.
9813 (lisp_time_argument): Don't rely on undefined left-shift and
9814 right-shift behavior when checking for time stamp overflow.
9815
9816 * editfns.c (time_overflow): New function, refactoring common code.
9817 (Fformat_time_string, Fdecode_time, Fencode_time):
9818 (Fcurrent_time_string): Use it.
9819
9820 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9821 * dired.c (make_time): Move to ...
9822 * editfns.c (make_time): ... here.
9823 * systime.h: Note the move.
9824
9825 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9826
9827 * fringe.c (update_window_fringes): Remove unused variables.
9828
9829 * unexmacosx.c (copy_data_segment): Also copy __got section.
9830 (Bug#8223)
9831
9832 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9833
9834 * termcap.c [MSDOS]: Include "msdos.h".
9835 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9836 Constify `char *' arguments and their references according to
9837 prototypes in tparam.h.
9838
9839 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9840
9841 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9842 Adapt all references accordingly.
9843
9844 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9845
9846 2011-03-11 Tom Tromey <tromey@redhat.com>
9847
9848 * buffer.c (syms_of_buffer): Remove obsolete comment.
9849
9850 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9851
9852 * termhooks.h (encode_terminal_code): Declare prototype.
9853
9854 * msdos.c (encode_terminal_code): Don't declare prototype.
9855
9856 * term.c (encode_terminal_code): Now external again, used by
9857 w32console.c and msdos.c.
9858
9859 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9860 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9861
9862 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9863
9864 Fix some minor problems found by GCC 4.5.2's static checks.
9865
9866 * fringe.c (update_window_fringes): Mark locals as initialized
9867 (Bug#8227).
9868 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9869
9870 * alloc.c (mark_fringe_data): Move decl from here ...
9871 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9872 to check its interface.
9873 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9874
9875 * fontset.c (free_realized_fontset): Now static.
9876 (Fset_fontset_font): Rename local to avoid shadowing.
9877 (fontset_font): Mark local as initialized.
9878 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9879
9880 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9881
9882 * xselect.c (x_disown_buffer_selections): Remove; not used.
9883 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9884 (x_own_selection, Fx_disown_selection_internal): Rename locals
9885 to avoid shadowing.
9886 (x_handle_dnd_message): Remove local to avoid shadowing.
9887
9888 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9889 so that the caller can use some name other than gcpro1.
9890 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9891 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9892 (Fx_backspace_delete_keys_p):
9893 Use them to avoid shadowing, and rename vars to avoid shadowing.
9894 (x_decode_color, x_set_name, x_window): Now static.
9895 (Fx_create_frame): Add braces to silence GCC warning.
9896 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9897 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9898 Remove unused locals.
9899 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9900 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9901 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9902 macros.
9903
9904 * xterm.h (x_mouse_leave): New decl.
9905
9906 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9907 Remove unused functions.
9908 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9909 (x_calc_absolute_position): Now static.
9910 (XTread_socket): Don't define label "out" unless it's used.
9911 Don't declare local "event" unless it's used.
9912 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9913 unless they are used.
9914 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9915 (x_fatal_error_signal): Remove; not used.
9916 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9917 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9918 (x_error_catcher, x_connection_closed, x_error_handler):
9919 (x_error_quitter, xembed_send_message, x_iconify_frame):
9920 (my_log_handler): Rename locals to avoid shadowing.
9921 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9922 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9923
9924 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9925 Rename or move locals to avoid shadowing.
9926 (tty_defined_color, merge_face_heights): Now static.
9927 (free_realized_faces_for_fontset): Remove; not used.
9928 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9929 does not deduce is never used uninitialized.
9930 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9931 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9932
9933 * terminal.c (store_terminal_param): Now static.
9934
9935 * xmenu.c (menu_highlight_callback): Now static.
9936 (set_frame_menubar): Remove unused local.
9937 (xmenu_show): Rename parameter to avoid shadowing.
9938 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9939 since they might point to immutable storage.
9940 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9941 since it's unused otherwise.
9942
9943 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9944 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9945 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9946 avoids a gcc -Wuninitialized diagnostic.
9947 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9948 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9949 does not deduce are never used uninitialized.
9950
9951 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9952
9953 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9954 * window.c (window_loop, size_window):
9955 (run_window_configuration_change_hook, enlarge_window): Likewise.
9956
9957 * window.c (display_buffer): Now static.
9958 (size_window): Mark variables that gcc -Wuninitialized
9959 does not deduce are never used uninitialized.
9960 * window.h (check_all_windows): New decl, to forestall
9961 gcc -Wmissing-prototypes diagnostic.
9962 * dispextern.h (bidi_dump_cached_states): Likewise.
9963
9964 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9965 shadowing.
9966 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9967 Include <limits.h>.
9968 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9969 and to avoid gcc -Wuninitialized warning.
9970 (load_charset_map): Mark variables that gcc -Wuninitialized
9971 does not deduce are never used uninitialized.
9972 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9973
9974 * coding.c (coding_set_source, coding_set_destination):
9975 Use "else { /* comment */ }" rather than "else /* comment */;"
9976 for clarity, and to avoid gcc -Wempty-body warning.
9977 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9978 a block, when the outer 'i' will do.
9979 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9980 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9981 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9982 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9983 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9984 Rename locals to avoid shadowing.
9985 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9986 * coding.c (emacs_mule_char, encode_invocation_designation):
9987 Now static, since they're not used elsewhere.
9988 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9989 (decode_coding_object, encode_coding_object, detect_coding_system):
9990 (decode_coding_emacs_mule): Mark variables that gcc
9991 -Wuninitialized does not deduce are never used uninitialized.
9992 (detect_coding_iso_2022): Initialize a local variable that might
9993 be used uninitialized. Leave a FIXME because it's not clear that
9994 this initialization is needed. (Bug#8211)
9995 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9996 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9997 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9998 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9999 Remove unused macros.
10000
10001 * category.c (hash_get_category_set): Remove unused local var.
10002 (copy_category_table): Now static, since it's not used elsewhere.
10003 * character.c (string_count_byte8): Likewise.
10004
10005 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10006 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10007
10008 * chartab.c (copy_sub_char_table): Now static, since it's not used
10009 elsewhere.
10010 (sub_char_table_ref_and_range, char_table_ref_and_range):
10011 Rename locals to avoid shadowing.
10012 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
10013
10014 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
10015 (BIDI_BOB): Remove unused macro.
10016
10017 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10018 deduce are never used uninitialized.
10019 * term.c (encode_terminal_code): Likewise.
10020
10021 * term.c (encode_terminal_code): Now static. Remove unused local.
10022
10023 * tparam.h: New file.
10024 * term.c, tparam.h: Include it.
10025 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10026 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10027 Move these decls to tparam.h, and make them agree with what
10028 is actually in tparam.c. The previous trick of using incompatible
10029 decls in different modules does not conform to the C standard.
10030 All callers of tparam changed to use tparam's actual API.
10031 * tparam.c (tparam1, tparam, tgoto):
10032 Use const pointers where appropriate.
10033
10034 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10035 * cm.h (struct cm): Likewise.
10036 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10037 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10038 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10039 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10040 (turn_on_face, init_tty): Likewise.
10041 * termchar.h (struct tty_display_info): Likewise.
10042
10043 * term.c (term_mouse_position): Rename local to avoid shadowing.
10044
10045 * alloc.c (mark_ttys): Move decl from here ...
10046 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10047
10048 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10049
10050 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10051
10052 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
10053
10054 * search.c (compile_pattern_1): Remove argument regp, unused since
10055 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10056 (compile_pattern): Don't pass it.
10057
10058 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10059
10060 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10061 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10062 for ! HAVE_GTK3.
10063 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10064
10065 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10066
10067 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10068 gdk_window_get_screen, gdk_window_get_geometry,
10069 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10070 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10071 (xg_get_pixbuf_from_pixmap): New function.
10072 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10073 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10074 Call xg_get_pixbuf_from_pixmap instead of
10075 gdk_pixbuf_get_from_drawable.
10076 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10077 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10078 (xg_check_special_colors): Use GtkStyleContext and its functions
10079 for HAVE_GTK3.
10080 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10081 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10082 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10083 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10084 Call gtk_widget_get_preferred_size.
10085 (xg_frame_resized): gdk_window_get_geometry only takes 5
10086 parameters.
10087 (xg_win_to_widget, xg_event_is_for_menubar):
10088 Call gdk_x11_window_lookup_for_display.
10089 (xg_set_widget_bg): New function.
10090 (delete_cb): New function.
10091 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10092 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10093 (xg_set_background_color): Call xg_set_widget_bg.
10094 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10095 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10096 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10097 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10098 if ! HAVE_GTK3.
10099 (update_frame_tool_bar): Call gtk_widget_hide.
10100 (xg_initialize): Use GDK_KEY_g.
10101
10102 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10103 if ! HAVE_GTK3
10104 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10105
10106 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10107 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10108 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10109
10110 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10111
10112 * w32xfns.c (select_palette): Check success of RealizePalette against
10113 GDI_ERROR, not zero.
10114
10115 See ChangeLog.11 for earlier changes.
10116
10117 ;; Local Variables:
10118 ;; coding: utf-8
10119 ;; End:
10120
10121 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10122
10123 This file is part of GNU Emacs.
10124
10125 GNU Emacs is free software: you can redistribute it and/or modify
10126 it under the terms of the GNU General Public License as published by
10127 the Free Software Foundation, either version 3 of the License, or
10128 (at your option) any later version.
10129
10130 GNU Emacs is distributed in the hope that it will be useful,
10131 but WITHOUT ANY WARRANTY; without even the implied warranty of
10132 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10133 GNU General Public License for more details.
10134
10135 You should have received a copy of the GNU General Public License
10136 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.