* src/eval.c (Fquote): Document its non-consing behavior.
[bpt/emacs.git] / src / ChangeLog
1 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4
5 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6
7 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
8 GCC PR/17406) by declaring this function with external scope.
9
10 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
11
12 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
13 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
14
15 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
16
17 * editfns.c (Fformat): Correctly handle text properties on "%%".
18
19 2011-09-15 Eli Zaretskii <eliz@gnu.org>
20
21 * xterm.c (x_draw_composite_glyph_string_foreground):
22 * w32term.c (x_draw_composite_glyph_string_foreground):
23 * term.c (encode_terminal_code):
24 * composite.c (composition_update_it, get_composition_id):
25 * xdisp.c (get_next_display_element)
26 (fill_composite_glyph_string): Add comments about special meaning
27 of TAB characters in a composition.
28
29 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
30
31 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
32 This occurs when processing a multibyte format.
33 Problem reported by Wolfgang Jenker.
34
35 2011-09-15 Johan Bockgård <bojohan@gnu.org>
36
37 * xdisp.c (try_cursor_movement): Only check for exact match if
38 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
39
40 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
41
42 Remove unused external symbols.
43 * dispextern.h (calc_pixel_width_or_height): Remove decl.
44 * xdisp.c (calc_pixel_width_or_height): Now static.
45 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
46 * indent.c (check_display_width):
47 * w32term.c: Fix comment to match code.
48 * xterm.c, xterm.h (x_catching_errors): Remove.
49
50 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
51
52 * xselect.c: Use signed conversions more consistently (Bug#9498).
53 (selection_data_to_lisp_data): Assume incoming selection data are
54 signed integers, not unsigned. This is to be consistent with
55 outgoing selection data, which was modified to use signed integers
56 in as part of the fix to Bug#9196 in response to Jan D.'s comment
57 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
58 expects long, not unsigned long.
59
60 2011-09-14 Eli Zaretskii <eliz@gnu.org>
61
62 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
63 computation of loop end. Reported by Johan Bockgård
64 <bojohan@gnu.org>.
65
66 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
67
68 * frame.c (Fother_visible_frames_p): Function deleted.
69
70 2011-09-12 Eli Zaretskii <eliz@gnu.org>
71
72 * indent.c (compute_motion): Process display vector front to back
73 rather than the other way around. (Bug#2496)
74
75 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
76
77 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
78
79 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
80
81 * minibuf.c (Fread_from_minibuffer): Doc fix.
82
83 2011-09-11 Eli Zaretskii <eliz@gnu.org>
84
85 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
86 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
87
88 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
89
90 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
91 value for non-existent files.
92
93 2011-09-11 Eli Zaretskii <eliz@gnu.org>
94
95 * fileio.c (Finsert_file_contents): If the file cannot be opened,
96 set its "size" to -1. This will set the modtime_size field of
97 the corresponding buffer to -1, which is what
98 verify-visited-file-modtime expects for files that do not exist.
99 (Bug#9139)
100
101 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
102
103 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
104 here ...
105 * lisp.h: ... from here. push_key_description is no longer
106 defined in keyboard.c, so its declaration should not be in
107 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
108 logically belongs with push_key_description.
109
110 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
111
112 * buffer.h: Include <sys/types.h> instead of <time.h>.
113 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
114 Problem reported by Herbert J. Skuhra.
115
116 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
117
118 * xml.c (parse_region): Make the parsing work for
119 non-comment-starting XML files again (bug#9144).
120
121 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
122
123 * image.c (gif_load): Fix calculation of bottom and right corner.
124 (Bug#9468)
125
126 2011-09-10 Eli Zaretskii <eliz@gnu.org>
127
128 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
129 redisplay in small windows.
130
131 2011-09-09 Eli Zaretskii <eliz@gnu.org>
132
133 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
134
135 2011-09-08 Martin Rudalics <rudalics@gmx.at>
136
137 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
138 Operate on live windows only.
139
140 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
141
142 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
143
144 2011-09-07 Eli Zaretskii <eliz@gnu.org>
145
146 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
147 only under bidi iteration.
148
149 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
150
151 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
152
153 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
154
155 isnan: Fix porting problem to Solaris 10 with bundled gcc.
156 Without this fix, the command to link temacs failed due to an
157 undefined symbol __builtin_isnan. This is because
158 /usr/include/iso/math_c99.h #defines isnan(x) to
159 __builtin_isnan(x), but the bundled gcc, which identifies itself
160 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
161 a __builtin_isnan.
162 * floatfns.c (isnan): #undef, and then #define to a clone of
163 what's in data.c.
164 (Fisnan): Always define, since it's always available now.
165 (syms_of_floatfns): Always define isnan at the Lisp level.
166
167 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
168
169 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
170
171 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
172
173 * fileio.c: Fix bugs with large file offsets (Bug#9428).
174 The previous code assumed that file offsets (off_t values) fit in
175 EMACS_INT variables, which is not true on typical 32-bit hosts.
176 The code messed up by falsely reporting buffer overflow in cases
177 such as (insert-file-contents "big" nil 1 2) into an empty buffer
178 when "big" contains more than 2**29 bytes, even though this
179 inserts just one byte and does not overflow the buffer.
180 (Finsert_file_contents): Store file offsets as off_t
181 values, not as EMACS_INT values. Check for overflow when
182 converting between EMACS_INT and off_t. When checking for
183 buffer overflow or for overlap, take the offsets into account.
184 Don't use EMACS_INT for small values where int suffices.
185 When checking for overlap, fix a typo: ZV was used where
186 ZV_BYTE was intended.
187 (Fwrite_region): Don't assume off_t fits into 'long'.
188 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
189
190 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
191
192 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
193
194 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
195
196 sprintf-related integer and memory overflow issues (Bug#9412).
197
198 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
199 (esprintf, exprintf, evxprintf): New functions.
200 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
201 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
202 (modify_event_symbol): Do not assume that the length of
203 name_alist_or_stem is safe to alloca and fits in int.
204 (Fexecute_extended_command): Likewise for function name and binding.
205 (Frecursion_depth): Wrap around reliably on integer overflow.
206 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
207 since some callers pass EMACS_INT values.
208 (Fsingle_key_description): Don't crash if symbol name contains more
209 than MAX_ALLOCA bytes.
210 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
211 (get_minibuffer): Arg is now EMACS_INT, not int.
212 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
213 (esprintf, exprintf, evxprintf): New decls.
214 * window.h (command_loop_level, minibuf_level): Reflect API changes.
215
216 * dbusbind.c (signature_cat): New function.
217 (xd_signature, Fdbus_register_signal):
218 Do not overrun buffer; instead, report string overflow.
219
220 * dispnew.c (add_window_display_history): Don't overrun buffer.
221 Truncate instead; this is OK since it's just a log.
222
223 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
224 even if the time zone offset is outlandishly large.
225 Don't mishandle offset == INT_MIN.
226
227 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
228 when creating daemon; the previous buffer-overflow check was incorrect.
229
230 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
231 which has the guts of the old verror function.
232
233 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
234 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
235
236 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
237 (font_unparse_xlfd): Don't blindly alloca long strings.
238 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
239 fits in int, when using sprintf. Use single snprintf to count
240 length of string rather than counting it via multiple sprintfs;
241 that's simpler and more reliable.
242 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
243 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
244 sprintf, in case result does not fit in int.
245
246 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
247 (fontset_from_font): Print it.
248
249 * frame.c (tty_frame_count): Now printmax_t, not int.
250 (make_terminal_frame, set_term_frame_name): Print it.
251 (x_report_frame_params): In X, window IDs are unsigned long,
252 not signed long, so print them as unsigned.
253 (validate_x_resource_name): Check for implausibly long names,
254 and don't assume name length fits in 'int'.
255 (x_get_resource_string): Don't blindly alloca invocation name;
256 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
257 not fit in int.
258
259 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
260 (xg_check_special_colors, xg_set_geometry):
261 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
262
263 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
264 Use esprintf, not sprintf, in case result does not fit in int.
265
266 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
267 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
268 it as a large positive number.
269 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
270 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
271
272 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
273 in case result does not fit in int.
274
275 * print.c (float_to_string): Detect width overflow more reliably.
276 (print_object): Make sprintf buffer a bit bigger, to avoid potential
277 buffer overrun. Don't assume list length fits in 'int'. Treat
278 print length of 0 as 0, not as infinity; to be consistent with other
279 uses of print length in this function. Don't overflow print length
280 index. Don't assume hash table size fits in 'long', or that
281 vectorlike size fits in 'unsigned long'.
282
283 * process.c (make_process): Use printmax_t, not int, to format
284 process-name gensyms.
285
286 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
287
288 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
289 to avoid potential buffer overrun.
290
291 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
292 if X resource line is longer than 512 bytes.
293
294 * xfns.c (x_window): Make sprintf buffer a bit bigger
295 to avoid potential buffer overrun.
296
297 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
298
299 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
300
301 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
302
303 Integer overflow fixes for scrolling, etc.
304 Without these, Emacs silently mishandles large integers sometimes.
305 For example, "C-u 4294967297 M-x recenter" was treated as if
306 it were "C-u 1 M-x recenter" on a typical 64-bit host.
307
308 * xdisp.c (try_window_id): Check Emacs fixnum range before
309 converting to 'int'.
310
311 * window.c (window_scroll_line_based, Frecenter):
312 Check that an Emacs fixnum is in range before assigning it to 'int'.
313 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
314 values converted from Emacs fixnums.
315 (Frecenter): Don't wrap around a line count if it is out of 'int'
316 range; instead, treat it as an extreme value.
317 (Fset_window_configuration, compare_window_configurations):
318 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
319
320 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
321 that can exceed INT_MAX. Check that EMACS_INT value is in range
322 before assigning it to the (possibly-narrower) index.
323 (match_limit): Don't assume that a fixnum can fit in 'int'.
324
325 * print.c (print_object): Use ptrdiff_t, not int, for index that can
326 exceed INT_MAX.
327
328 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
329 (Fvertical_motion): Don't wrap around LINES values that don't fit
330 in 'int'. Instead, treat them as extreme values. This is good
331 enough for windows, which can't have more than INT_MAX lines anyway.
332
333 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
334
335 * Require libxml/parser.h to avoid compilation warning.
336
337 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
338
339 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
340 since this reportedly can destroy thread storage.
341
342 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
343
344 * syntax.c (find_defun_start): Update all cache variables if
345 exiting early (Bug#9401).
346
347 2011-08-30 Eli Zaretskii <eliz@gnu.org>
348
349 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
350
351 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
352 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
353 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
354
355 * term.c (tty_append_glyph): New function.
356 (produce_stretch_glyph): Static function and its prototype deleted.
357
358 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
359 prototypes.
360
361 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
362
363 * image.c (parse_image_spec): Check for nonnegative, not for positive,
364 when checking :margin (Bug#9390).
365 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
366 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
367 so that the name doesn't mislead. All uses changed.
368
369 2011-08-28 Johan Bockgård <bojohan@gnu.org>
370
371 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
372 set_tty_hooks.
373
374 2011-08-27 Eli Zaretskii <eliz@gnu.org>
375
376 * xdisp.c (move_it_to): Don't bail out early when reaching
377 position beyond to_charpos, if we are scanning backwards.
378 (move_it_vertically_backward): When DY == 0, make sure we get to
379 the first character in the line after the newline.
380
381 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
382
383 * ccl.c: Improve and simplify overflow checking (Bug#9196).
384 (ccl_driver): Do not generate an out-of-range pointer.
385 (Fccl_execute_on_string): Remove unnecessary check for
386 integer overflow, noted by Stefan Monnier in
387 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
388 Remove a FIXME that didn't need fixing.
389 Simplify the newly-introduced buffer reallocation code.
390
391 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
392
393 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
394
395 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
396
397 Integer and memory overflow issues (Bug#9196).
398
399 * doc.c (get_doc_string): Rework so that
400 get_doc_string_buffer_size is the actual buffer size, rather than
401 being 1 less than the actual buffer size; this makes xpalloc more
402 convenient.
403
404 * image.c (x_allocate_bitmap_record, cache_image):
405 * xselect.c (Fx_register_dnd_atom):
406 Simplify previous changes by using xpalloc.
407
408 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
409 since either will do and ptrdiff_t is convenient with xpalloc.
410
411 * charset.c (charset_table_size)
412 (struct charset_sort_data.priority): Now ptrdiff_t.
413 (charset_compare): Don't overflow if priorities differ greatly.
414 (Fsort_charsets): Don't assume list length fits in int.
415 Check for size-calculation overflow when allocating sort data.
416 (syms_of_charset): Allocate an initial charset table that is
417 just under 64 KiB, to avoid problems with glibc malloc and mmap.
418
419 * cmds.c (internal_self_insert): Check for size-calculation overflow.
420
421 * composite.h (struct composition.glyph_len): Now int, not unsigned.
422 The actual value is always <= INT_MAX, and leaving it unsigned made
423 overflow checking harder.
424
425 * dispextern.h (struct glyph_matrix.rows_allocated)
426 (struct face_cache.size): Now ptrdiff_t, for convenience in use
427 with xpalloc. The values are still always <= INT_MAX.
428
429 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
430
431 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
432 (SAFE_NALLOCA): New macro.
433
434 * region-cache.c (struct boundary.pos, find_cache_boundary)
435 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
436 (set_cache_region, invalidate_region_cache)
437 (revalidate_region_cache, know_region_cache, region_cache_forward)
438 (region_cache_backward, pp_cache):
439 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
440 so that ptrdiff_t * can be passed to xpalloc.
441 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
442 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
443 (pp_cache): Don't assume cache_len fits in int.
444 * region-cache.h: Adjust extern decls to match.
445
446 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
447 EMACS_INT, since either will do, for xpalloc.
448
449 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
450 (xnmalloc, xnrealloc, xpalloc): New functions.
451
452 * bidi.c (bidi_shelve_header_size): New constant.
453 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
454 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
455
456 * bidi.c (bidi_cache_shrink):
457 * buffer.c (overlays_at, overlays_in, record_overlay_string)
458 (overlay_strings):
459 Don't update size of array until after memory allocation succeeds,
460 because xmalloc/xrealloc may not return.
461 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
462 now that we have proper integer overflow checking.
463 (record_overlay_string, overlay_strings): Catch overflows when
464 calculating size of overlay_str_buf.
465
466 * callproc.c (Fcall_process): Check for size overflow when
467 calculating size of args2.
468 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
469 Normally we prefer signed values, but sticking with ptrdiff_t would
470 require adding more-complicated checks.
471
472 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
473 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
474 Redo buffer-overflow calculations to avoid integer overflow.
475 Add a FIXME comment where memory seems to be over-allocated.
476
477 * character.c (Fstring): Check for size-calculation overflow.
478
479 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
480 unnecessary integer overflow. Check for size overflow.
481 (encode_coding_object): Don't update size until xmalloc succeeds.
482
483 * composite.c (get_composition_id): Check for overflow in glyph
484 length calculations.
485
486 Integer and memory overflow fixes for display code.
487 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
488 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
489 (scrolling_window): Check for overflow in size calculations.
490 (line_draw_cost, realloc_glyph_pool, add_row_entry):
491 Don't assume glyph table len fits in int.
492 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
493 (row_table_size): Now ptrdiff_t, not int.
494 (scrolling_window): Avoid overflow in size calculations.
495 Don't update size until allocation succeeds.
496 * fns.c (concat): Check for overflow in size calculations.
497 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
498 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
499 (NEXT_ALMOST_PRIME_LIMIT): New constant.
500
501 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
502 (get_doc_string): Check for size calculation overflow.
503 Don't update size until allocation succeeds.
504 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
505 EMACS_INT, where ptrdiff_t will do.
506 (Fsubstitute_command_keys): Check for string overflow.
507
508 * editfns.c (set_time_zone_rule): Don't assume environment length
509 fits in int.
510 (message_length): Now ptrdiff_t, not int.
511 (Fmessage_box): Don't update size until allocation succeeds.
512 Don't assume message length fits in int.
513 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
514
515 * emacs.c (main): Do not reallocate argv, since there is a null at
516 the end that can be overwritten, and this way there's no need to
517 worry about size-calculation overflow.
518 (sort_args): Check for size-calculation overflow.
519
520 * eval.c (init_eval_once, grow_specpdl): Don't update size until
521 alloc succeeds.
522 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
523
524 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
525 (x_set_scroll_bar_width, x_figure_window_size):
526 Check for integer overflow.
527 (x_set_alpha): Do not assume XINT fits in int.
528
529 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
530 This is for the members text_lines, text_cols, total_lines, total_cols,
531 where the system imposes an 'int' limit.
532
533 * fringe.c (Fdefine_fringe_bitmap):
534 Don't update size until alloc works.
535
536 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
537 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
538
539 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
540 Check for size-calculation overflow.
541 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
542 do, as we prefer signed integers.
543 (id_to_widget.max_size, id_to_widget.used)
544 (xg_store_widget_in_map, xg_remove_widget_from_map)
545 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
546 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
547 Use and return ptrdiff_t, not int.
548 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
549 * gtkutil.h: Change prototypes to match the above.
550
551 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
552 are duplicate now that they've been promoted to lisp.h.
553 (x_allocate_bitmap_record, x_alloc_image_color)
554 (make_image_cache, cache_image, xpm_load):
555 Don't update size until alloc is done.
556 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
557 (x_detect_edges):
558 Check for size calculation overflow.
559 (ct_colors_allocated_max): New constant.
560 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
561 overflow.
562
563 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
564 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
565 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
566 Use ptrdiff_t, not int, to count maps.
567 (read_char_minibuf_menu_prompt): Check for overflow in size
568 calculations. Don't update size until allocation succeeds. Redo
569 calculations to avoid overflow.
570 * keyboard.h: Change prototypes to match the above.
571
572 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
573 to count maps.
574 (current_minor_maps): Check for size calculation overflow.
575 * keymap.h: Change prototypes to match the above.
576
577 * lread.c (read1, init_obarray): Don't update size until alloc done.
578
579 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
580 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
581
582 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
583 Now ptrdiff_t, not int.
584 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
585 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
586
587 * process.c (Fnetwork_interface_list): Check for overflow
588 in size calculation.
589
590 * region-cache.c (move_cache_gap): Check for size calculation overflow.
591
592 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
593 overflow. Don't bother calling xmalloc when xrealloc will do.
594
595 * search.c (Freplace_match): Check for size calculation overflow.
596 (Fset_match_data): Don't assume list lengths fit in 'int'.
597
598 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
599 for command line length. Do not attempt to address one before the
600 beginning of an array, as that's not portable.
601
602 * term.c (max_frame_lines): Remove; unused.
603 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
604 not int.
605 (encode_terminal_code, calculate_costs): Check for size
606 calculation overflow.
607 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
608 table lengths and related sizes. Don't update size until alloc
609 done. Redo calculations to avoid overflow.
610 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
611
612 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
613 subtracting pointers.
614 (gobble_line): Check for overflow more carefully. Don't update size
615 until alloc done.
616
617 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
618 Don't update size until alloc done.
619 Redo size calculations to avoid overflow.
620 Check for size calculation overflow.
621 (main) [DEBUG]: Fix typo in invoking tparam1.
622
623 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
624 Use ptrdiff_t, not int, for sizes.
625 (store_mode_line_noprop_char): Don't update size until alloc done.
626
627 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
628 Use ptrdiff_t, not int, for sizes.
629 (Finternal_make_lisp_face, cache_face):
630 Check for size calculation overflow.
631 (cache_face): Treat size calculation overflows as if they were
632 memory exhaustion (the usual treatment), rather than aborting.
633
634 * xfns.c (x_encode_text, x_set_name_internal)
635 (Fx_change_window_property): Use ptrdiff_t, not int, to count
636 sizes, since they can exceed INT_MAX in size. Check for size
637 calculation overflow.
638
639 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
640 (xg_select): Check for size calculation overflow.
641 Don't update size until alloc done.
642
643 * xrdb.c (get_environ_db): Don't assume path length fits in int,
644 as sprintf is limited to int lengths.
645
646 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
647 (X_LONG_MIN): New macros.
648 Use them to make the following changes clearer.
649 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
650 This change doesn't affect the value now, but it may help remind
651 future maintainers not to raise the value too much later.
652 (SELECTION_QUANTUM): Remove, replacing with ...
653 (selection_quantum): ... new function, which avoids overflow.
654 All uses changed.
655 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
656 assumption that selection length fits in 'int'.
657 (x_reply_selection_request, x_handle_selection_request)
658 (x_get_window_property, receive_incremental_selection)
659 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
660 (lisp_data_to_selection_data, clean_local_selection_data):
661 Use ptrdiff_t, not int, to record length of selection.
662 (x_reply_selection_request, x_get_window_property)
663 (receive_incremental_selection, x_property_data_to_lisp):
664 Redo calculations to avoid overflow.
665 (x_reply_selection_request): When sending hint, ceiling it at
666 X_LONG_MAX rather than relying on wraparound overflow to send
667 something.
668 (x_get_window_property, receive_incremental_selection)
669 (lisp_data_to_selection_data, x_property_data_to_lisp):
670 Check for size-calculation overflow.
671 (x_get_window_property, receive_incremental_selection)
672 (lisp_data_to_selection_data, Fx_register_dnd_atom):
673 Don't store size until memory allocation succeeds.
674 (x_get_window_property): Plug memory leak on memory exhaustion.
675 Don't double-block input; malloc is safe here. Don't assume 2**34
676 - 4 fits in unsigned long. Add an xassert to check
677 XGetWindowProperty overflow. Be more careful about overflow
678 calculations, and distinguish size from memory overflow better.
679 (receive_incremental_selection): When tracing, don't assume
680 unsigned int is less than INT_MAX.
681 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
682 harmful) conversions of unsigned short to int.
683 (lisp_data_to_selection_data): Don't assume that integers
684 in the range -65535 through -1 fit in an X unsigned short.
685 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
686 result parameters unless successful. Rely on cons_to_unsigned
687 to report problems with elements; the old code wasn't right anyway.
688 (x_check_property_data): Check for int overflow; we cannot use
689 a wider type due to X limits.
690 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
691
692 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
693
694 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
695 (x_term_init): Check for size calculation overflow.
696 (x_color_cells): Don't store size until memory allocation succeeds.
697 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
698 Don't assume alloca size is less than MAX_ALLOCA.
699 (x_term_init): Don't assume length fits in int (sprintf is limited
700 to int size).
701
702 Use ptrdiff_t for composition IDs.
703 * character.c (lisp_string_width):
704 * composite.c (composition_table_size, n_compositions)
705 (get_composition_id, composition_gstring_from_id):
706 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
707 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
708 * window.c (Frecenter):
709 Use ptrdiff_t, not int, for composition IDs.
710 * composite.c (get_composition_id): Check for integer overflow.
711 * composite.h: Adjust prototypes to match the above changes.
712
713 Use ptrdiff_t for hash table indexes.
714 * category.c (hash_get_category_set):
715 * ccl.c (ccl_driver):
716 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
717 * coding.c (coding_system_charset_list, detect_coding_system):
718 * coding.h (struct coding_system.id):
719 * composite.c (get_composition_id, gstring_lookup_cache):
720 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
721 * image.c (xpm_get_color_table_h):
722 * lisp.h (hash_lookup, hash_put):
723 * minibuf.c (Ftest_completion):
724 Use ptrdiff_t for hash table indexes, not int (which is too
725 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
726 32-bit --with-wide-int hosts).
727
728 * charset.c (Fdefine_charset_internal): Check for integer overflow.
729 Add a FIXME comment about memory leaks.
730 (syms_of_charset): Don't assume xmalloc returns.
731
732 Don't assume that stated character widths fit in int.
733 * character.c (Fchar_width, c_string_width, lisp_string_width):
734 * character.h (CHAR_WIDTH):
735 * indent.c (MULTIBYTE_BYTES_WIDTH):
736 Use sanitize_char_width to avoid undefined and/or bad behavior
737 with outlandish widths.
738 * character.h (sanitize_tab_width): Renamed from sanitize_width,
739 now that we have two such functions. All uses changed.
740 (sanitize_char_width): New inline function.
741
742 Don't assume that tab-width fits in int.
743 * character.h (sanitize_width): New inline function.
744 (SANE_TAB_WIDTH): New macro.
745 (ASCII_CHAR_WIDTH): Use it.
746 * indent.c (sane_tab_width): Remove. All uses replaced by
747 SANE_TAB_WIDTH (current_buffer).
748 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
749
750 * fileio.c: Integer overflow issues with file modes.
751 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
752
753 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
754 Remove unreachable code.
755 (read_hex, load_charset_map_from_file): Check for integer overflow.
756
757 * xterm.c: don't go over XClientMessageEvent limit
758 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
759 (x_send_scroll_bar_event): Likewise. Check that the size does not
760 exceed limits imposed by XClientMessageEvent, as well as the usual
761 ptrdiff_t and size_t limits.
762
763 * keyboard.c: Overflow, signedness and related fixes.
764 (make_lispy_movement): Use same integer type in forward decl
765 that is used in the definition.
766 (read_key_sequence, keyremap_step):
767 Change bufsize argument back to int, undoing my 2011-03-30 change.
768 We prefer signed types, and int is wide enough here.
769 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
770 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
771 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
772 length, not size_t. Use ptrdiff_t for index, not int.
773 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
774 possibility of integer overflow.
775
776 Overflow, signedness and related fixes for images.
777
778 * dispextern.h (struct it.stack[0].u.image.image_id)
779 (struct_it.image_id, struct image.id, struct image_cache.size)
780 (struct image_cache.used, struct image_cache.ref_count):
781 * gtkutil.c (update_frame_tool_bar):
782 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
783 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
784 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
785 * nsmenu.m (update_frame_tool_bar):
786 * xdisp.c (calc_pixel_width_or_height):
787 * xfns.c (image_cache_refcount):
788 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
789 on typical 64-bit hosts.
790
791 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
792 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
793 Omit unnecessary casts to int.
794 (parse_image_spec): Check that integers fall into 'int' range
795 when the callers expect that.
796 (image_ascent): Redo ascent calculation to avoid int overflow.
797 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
798 (lookup_image): Remove unnecessary tests.
799 (xbm_image_p): Locals are now of int, not EMACS_INT,
800 since parse_image_check makes sure they fit into int.
801 (png_load, gif_load, svg_load_image):
802 Prefer int to unsigned where either will do.
803 (tiff_handler): New function, combining the cores of the
804 old tiff_error_handler and tiff_warning_handler. This
805 function is rewritten to use vsnprintf and thereby avoid
806 stack buffer overflows. It uses only the features of vsnprintf
807 that are common to both POSIX and native Microsoft.
808 (tiff_error_handler, tiff_warning_handler): Use it.
809 (tiff_load, gif_load, imagemagick_load_image):
810 Don't assume :index value fits in 'int'.
811 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
812 (imagemagick_load_image): Check that crop parameters fit into
813 the integer types that MagickCropImage accepts. Don't assume
814 Vimagemagick_render_type has a nonnegative value. Don't assume
815 size_t fits in 'long'.
816 (gs_load): Use printmax_t to print the widest integers possible.
817 Check for integer overflow when computing image height and width.
818
819 2011-08-26 Eli Zaretskii <eliz@gnu.org>
820
821 * xdisp.c (redisplay_window): Don't force window start if point
822 will be invisible in the resulting window. (Bug#9324)
823
824 2011-08-25 Eli Zaretskii <eliz@gnu.org>
825
826 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
827 the display spec is of the form `(space ...)'.
828 (handle_display_spec): Return the value returned by
829 handle_single_display_spec, not just 1 or zero.
830 (handle_single_display_spec): If the display spec is of the form
831 `(space ...)', and specifies display in the text area, return 2
832 rather than 1.
833 (try_cursor_movement): Check for the need to scroll more
834 accurately, and prefer exact match for point under bidi. Don't
835 advance `row' beyond the last row of the window.
836
837 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
838 into disp_prop; all users changed.
839
840 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
841 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
842 for the text covered by the display property.
843
844 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
845
846 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
847 Change return value to nil.
848 (Frecord_buffer): Delete unused function.
849
850 2011-08-24 Eli Zaretskii <eliz@gnu.org>
851
852 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
853 buffers, return left-to-right.
854 (set_cursor_from_row): Consider candidate row a win if its glyph
855 represents a newline and point is on that newline. Fixes cursor
856 positioning on the newline at EOL of R2L text within L2R
857 paragraph, and vice versa.
858 (try_cursor_movement): Check continued rows, in addition to
859 continuation rows. Fixes unwarranted scroll when point enters a
860 continued line of R2L text within an L2R paragraph, or vice versa.
861 (cursor_row_p): Consider the case of point being equal to
862 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
863 from the end of a short line to the beginning of a continued line
864 of R2L text within L2R paragraph.
865 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
866 composed characters.
867
868 * bidi.c (bidi_check_type): Use xassert.
869 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
870 members.
871
872 2011-08-23 Eli Zaretskii <eliz@gnu.org>
873
874 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
875 a character.
876
877 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
878
879 * nsfont.m (ns_otf_to_script): Fix typo.
880
881 2011-08-22 Kenichi Handa <handa@m17n.org>
882
883 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
884 extra slot even if the purpose is char-code-property-table.
885
886 2011-08-23 Eli Zaretskii <eliz@gnu.org>
887
888 * xdisp.c (redisplay_window): When computing centering_position,
889 account for the height of the header line. (Bug#8874)
890
891 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
892 instead of CHAR_TO_BYTE. Fixes a crash when a completion
893 candidate is selected by the mouse, and that candidate has a
894 composed character under the mouse.
895
896 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
897 coordinates reported by pos-visible-in-window-p for a composed
898 character in column zero.
899
900 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
901
902 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
903
904 2011-08-22 Eli Zaretskii <eliz@gnu.org>
905
906 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
907 consider it a hit if to_charpos is anywhere in the range of the
908 composed buffer positions.
909
910 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
911
912 * image.c (gif_load): Don't assume that each subimage has the same
913 dimensions as the base image. Handle disposal method that is
914 "undefined" by the gif spec (Bug#9335).
915
916 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
917
918 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
919 (Fcondition_case): Document `debug' symbol in error handler.
920
921 2011-08-19 Eli Zaretskii <eliz@gnu.org>
922
923 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
924 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
925 from an Org mode buffer to a Speedbar frame.
926
927 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
928 a composition, take its buffer position from IT->cmp_it.charpos.
929 Fixes cursor positioning at the beginning of a line that begins
930 with a composed character.
931
932 2011-08-18 Eli Zaretskii <eliz@gnu.org>
933
934 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
935 character bidirectional type, use STRONG_L instead. Fixes crashes
936 in a buffer produced by `describe-categories'.
937
938 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
939 members before the level stack, so they would be saved and
940 restored when copying iterator state. Fixes incorrect reordering
941 around TABs covered by display properties.
942
943 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
944
945 * process.c (Fnetwork_interface_list): Correctly determine buffer
946 size.
947
948 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
949
950 * eval.c (internal_condition_case, internal_condition_case_1)
951 (internal_condition_case_2, internal_condition_case_n):
952 Remove unnecessary aborts (Bug#9081).
953
954 2011-08-17 Eli Zaretskii <eliz@gnu.org>
955
956 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
957 has no `load' handler, try opening the file locally. (Bug#9311)
958
959 2011-08-16 Ken Brown <kbrown@cornell.edu>
960
961 * gmalloc.c: Expand comment.
962
963 2011-08-16 Eli Zaretskii <eliz@gnu.org>
964
965 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
966 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
967
968 2011-08-16 Ken Brown <kbrown@cornell.edu>
969
970 Fix memory allocation problems in Cygwin build (Bug#9273).
971
972 * unexcw.c ( __malloc_initialized): Declare external variable.
973 (fixup_executable): Force the dumped emacs to reinitialize malloc.
974
975 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
976 New variables.
977 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
978 dumped emacs.
979 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
980 in the static heap.
981 [CYGWIN] (special_realloc): New function.
982 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
983 requests to realloc storage in the static heap.
984
985 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
986
987 * bidi.c (bidi_initialize): Remove unused local.
988
989 2011-08-15 Eli Zaretskii <eliz@gnu.org>
990
991 * biditype.h: File removed.
992
993 * bidimirror.h: File removed.
994
995 * deps.mk (bidi.o): Remove biditype.h and
996 bidimirror.h.
997
998 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
999 bidimirror.h.
1000
1001 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1002
1003 * chartab.c: Improve commentary for the uniprop_table API.
1004
1005 * bidi.c (bidi_paragraph_init): Support zero value of
1006 bidi_ignore_explicit_marks_for_paragraph_level.
1007 (bidi_initialize): Use uniprop_table instead of including
1008 biditype.h and bidimirror.h.
1009
1010 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1011 coordinates of the iterator when restoring from ppos_it.
1012 (Bug#9296)
1013
1014 2011-08-14 Kenichi Handa <handa@m17n.org>
1015
1016 * process.c (create_process): Call setup_process_coding_systems
1017 after the pid of the process is set to -1 (Bug#8162).
1018
1019 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1020
1021 * xdisp.c (move_it_in_display_line_to): Don't invoke
1022 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1023 ppos_it. Fixes vertical cursor motion when line beginning is
1024 covered by an image. (Bug#9296)
1025
1026 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1027
1028 * nsterm.h (ns_run_ascript): Declare.
1029 (NSAPP_DATA2_RUNASSCRIPT): Define.
1030
1031 * nsfns.m (as_script, as_result, as_status): New static variables.
1032 (ns_run_ascript): New function.
1033 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1034 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1035 the event loop. Get status from as_status (Bug#7276).
1036
1037 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1038 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1039 the event loop (Bug#7276).
1040
1041 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1042
1043 * gnutls.c (QCgnutls_bootprop_priority)
1044 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1045 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1046 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1047 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1048 (QCgnutls_bootprop_verify_hostname_error)
1049 (QCgnutls_bootprop_callbacks_verify): Rename from
1050 Qgnutls_bootprop_..., all uses changed.
1051
1052 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1053 uses changed.
1054
1055 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1056
1057 * xfaces.c (Qframe_set_background_mode): Now static.
1058 * dispextern.h (Qframe_set_background_mode): Remove decl.
1059
1060 * process.c (Fnetwork_interface_info): Declare local only if needed.
1061
1062 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1063
1064 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1065 (Fnetwork_interface_list): Allocate in increments of bytes instead
1066 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1067 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1068 sockaddr.
1069 (struct ifflag_def): notrailers is smart on OSX.
1070 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1071 Get hardware address with getifaddrs if available.
1072
1073 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1074
1075 * xdisp.c (iterate_out_of_display_property): xassert that
1076 IT->position is set to within IT->object's boundaries. Break from
1077 the loop as soon as EOB is reached; avoids infloops in redisplay
1078 when IT->position is set up wrongly due to some bug.
1079 Set IT->current to match the bidi iterator unconditionally.
1080 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1081 entry. Force push_it to save on the stack the current
1082 buffer/string position, to be restored by pop_it. Fix flags in
1083 the iterator structure wrt the object coming from a display
1084 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1085 properties. (Bug#9284)
1086
1087 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1088
1089 * fontset.c (fontset_get_font_group): Add proper type checks.
1090 (Bug#9172)
1091
1092 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1093
1094 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1095 and LC_VERSION_MIN_MACOSX.
1096 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1097 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1098
1099 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1100
1101 * xdisp.c (forward_to_next_line_start): Allow to use the
1102 no-display-properties-and-no-overlays under bidi display.
1103 Set disp_pos in the bidi iterator to avoid searches for display
1104 properties and overlays.
1105
1106 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1107
1108 * editfns.c (Fset_time_zone_rule): Document relationship with the
1109 setenv function.
1110
1111 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1112 the font entity extracted from the cache (Bug#8109).
1113
1114 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1115
1116 * composite.c (autocmp_chars): Don't reset point. That is done by
1117 restore_point_unwind (Bug#5984).
1118
1119 2011-08-07 Juri Linkov <juri@jurta.org>
1120
1121 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1122 to show the arg `TIME' instead of `TIMEVAL'.
1123
1124 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1125
1126 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1127 display property strides EOL and includes a newline, as in
1128 longlines-mode. (Bug#9254)
1129 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1130 word-wrap under bidirectional display. (Bug#9224)
1131
1132 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1133 is non-zero, even if the data buffer is NULL. Fixes a crash in
1134 vertical-motion with longlines-mode. (Bug#9254)
1135
1136 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1137
1138 * bidi.c <bidi_cache_total_alloc>: Now static.
1139 (bidi_initialize): Initialize bidi_cache_total_alloc.
1140
1141 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1142 cache. (Bug#9221)
1143
1144 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1145 amount allocated this far in `bidi_cache_total_alloc'.
1146 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1147 non-zero, only free the data buffer without restoring the cache
1148 contents. All callers changed.
1149
1150 * dispextern.h (bidi_unshelve_cache): Update prototype.
1151
1152 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1153 (move_it_in_display_line, move_it_to)
1154 (move_it_vertically_backward, move_it_by_lines): Replace the call
1155 to xfree to an equivalent call to bidi_unshelve_cache.
1156 (move_it_in_display_line_to): Fix logic of returning
1157 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1158
1159 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1160
1161 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1162 came from a string character with a `cursor' property. (Bug#9229)
1163
1164 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1165
1166 * Makefile.in (LIB_PTHREAD): New variable.
1167 (LIBES): Add LIB_PTHREAD (Bug#9216).
1168
1169 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1170 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1171
1172 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1173
1174 * regex.c (re_iswctype): Remove some redundant boolean
1175 conversions.
1176
1177 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1178
1179 * xterm.c (x_find_topmost_parent): New function.
1180 (x_set_frame_alpha): Find topmost parent window with
1181 x_find_topmost_parent and set the property there also (bug#9181).
1182 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1183
1184 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1185
1186 * callproc.c (Fcall_process): Avoid vfork clobbering
1187 the local vars buffer, coding_systems, current_dir.
1188
1189 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1190
1191 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1192
1193 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1194
1195 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1196 so that it is not optimized away.
1197
1198 * xdisp.c (compute_display_string_pos): Remove unused local.
1199
1200 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1201
1202 Fix slow cursor motion and scrolling in large buffers with
1203 selective display, like Org Mode buffers. (Bug#9218)
1204
1205 * dispextern.h (struct bidi_it): New member disp_prop_p.
1206
1207 * xdisp.c: Remove one-slot cache of display string positions.
1208 (compute_display_string_pos): Accept an additional argument
1209 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1210 for a display string or property. If found, set DISP_PROP_P
1211 non-zero.
1212
1213 * bidi.c (bidi_fetch_char): Accept an additional argument
1214 DISP_PROP_P, and pass it to compute_display_string_pos.
1215 Only handle text covered by a display string if DISP_PROP_P is returned
1216 non-zero. All callers of bidi_fetch_char changed.
1217
1218 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1219
1220 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1221
1222 2010-12-03 Don March <don@ohspite.net>
1223
1224 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1225 last character M-[char] is translated to ESC [char] (bug#7541).
1226
1227 2011-08-02 Kenichi Handa <handa@m17n.org>
1228
1229 * lisp.h (uniprop_table): Extern it.
1230
1231 * chartab.c (uniprop_table): Make it non-static.
1232
1233 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1234
1235 * xdisp.c (forward_to_next_line_start): Accept additional argument
1236 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1237 on the newline.
1238 (reseat_at_next_visible_line_start): Use the bidi iterator state
1239 returned by forward_to_next_line_start to restore the state of
1240 it->bidi_it after backing up to previous newline. (Bug#9212)
1241
1242 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1243
1244 * regex.c (re_comp): Protoize.
1245 (re_exec): Fix return type.
1246 (regexec): Fix type of `ret'. (Bug#9203)
1247
1248 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1249
1250 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1251 This is needed if max-image-size is a floating-point number.
1252
1253 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1254
1255 * print.c (print_object): Print empty symbol as ##.
1256
1257 * lread.c (read1): Read ## as empty symbol.
1258
1259 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1260
1261 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1262 setting frame foreground color (Bug#9175).
1263 (x_set_background_color): Likewise.
1264
1265 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1266 contents (Bug#9176).
1267 (EmacsTooltip -init): Remove bezels and add shadows to
1268 tooltip windows.
1269
1270 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1271 or scroll bar (Bug#8470).
1272
1273 * nsfont.m (nsfont_open): Remove assignment to voffset and
1274 unnecessary vars hshink, expand, hd, full_height, min_height.
1275 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1276
1277 * nsterm.h (nsfont_info): Remove voffset field.
1278
1279 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1280
1281 Implement strike-through and overline on NextStep (Bug#8863).
1282
1283 * nsfont.m (nsfont_open): Use underline position provided by font,
1284 instead of hard-coded value of 2.
1285 (nsfont_draw): Call ns_draw_text_decoration instead.
1286
1287 * nsterm.h: Add declaration for ns_draw_text_decoration.
1288
1289 * nsterm.m (ns_draw_text_decoration): New function for drawing
1290 underline, overline, and strike-through.
1291 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1292 ns_draw_text_decoration. Change treatment of cursor drawing to
1293 accomodate underlining, etc.
1294
1295 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1296
1297 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1298 default.
1299
1300 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1301
1302 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1303 Without this fix, if a signal arrives just after memory fills up,
1304 'malloc' might be invoked reentrantly.
1305
1306 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1307 In other words, assume that every image size is allowed, on non-X
1308 hosts. This assumption is probably wrong, but it lets Emacs compile.
1309
1310 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1311
1312 * regex.c (re_iswctype): Convert return values to boolean.
1313
1314 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1315
1316 * xdisp.c (compute_display_string_pos): Don't use cached display
1317 string position if the buffer had its restriction changed.
1318 (Bug#9184)
1319
1320 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1321
1322 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1323
1324 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1325
1326 Integer signedness and overflow and related fixes. (Bug#9079)
1327
1328 * bidi.c: Integer size and overflow fixes.
1329 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1330 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1331 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1332 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1333 (bidi_find_other_level_edge):
1334 Use ptrdiff_t instead of EMACS_INT where either will do.
1335 This works better on 32-bit hosts configured --with-wide-int.
1336 (bidi_cache_ensure_space): Check for size-calculation overflow.
1337 Use % rather than repeated addition, for better worst-case speed.
1338 Don't set bidi_cache_size until after xrealloc returns, because it
1339 might not return.
1340 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1341 (bidi_cache_ensure_space): Also check that the bidi cache size
1342 does not exceed that of the largest Lisp string or buffer. See Eli
1343 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1344
1345 * alloc.c (__malloc_size_t): Remove.
1346 All uses replaced by size_t. See Andreas Schwab's note
1347 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1348
1349 * image.c: Improve checking for integer overflow.
1350 (check_image_size): Assume that f is nonnull, since
1351 it is always nonnull in practice. This is one less thing to
1352 worry about when checking for integer overflow later.
1353 (x_check_image_size): New function, which checks for integer
1354 overflow issues inside X.
1355 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1356 This removes the need for a memory_full check.
1357 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1358 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1359 (xbm_read_bitmap_data): Change locals back to 'int', since
1360 their values must fit in 'int'.
1361 (xpm_load_image, png_load, tiff_load):
1362 Invoke x_create_x_image_and_pixmap earlier,
1363 to avoid much needless work if the image is too large.
1364 (tiff_load): Treat overly large images as if
1365 x_create_x_image_and_pixmap failed, not as malloc failures.
1366 (gs_load): Use x_check_image_size.
1367
1368 * gtkutil.c: Omit integer casts.
1369 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1370 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1371
1372 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1373
1374 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1375 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1376 would wrongly return t on a 64-bit host.
1377
1378 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1379 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1380 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1381 and therefore cause GCC to emit a bogus diagnostic in some cases.
1382
1383 * image.c: Integer signedness and overflow and related fixes.
1384 This is not an exhaustive set of fixes, but it's time to
1385 record what I've got.
1386 (lookup_pixel_color, check_image_size): Remove redundant decls.
1387 (check_image_size): Don't assume that arbitrary EMACS_INT values
1388 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1389 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1390 (tiff_load, imagemagick_load_image):
1391 Check for overflow in size calculations.
1392 (x_create_x_image_and_pixmap): Remove unnecessary test for
1393 xmalloc returning NULL; that can't happen.
1394 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1395 (xpm_color_bucket): Use better integer hashing function.
1396 (xpm_cache_color): Don't possibly over-allocate memory.
1397 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1398 (gif_memory_source):
1399 Use ptrdiff_t, not int or size_t, to record sizes.
1400 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1401 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1402 either works, as we prefer signed integers.
1403 (tiff_read_from_memory, tiff_write_from_memory):
1404 Return tsize_t, not size_t, since that's what the TIFF API wants.
1405 (tiff_read_from_memory): Don't fail simply because the read would
1406 go past EOF; instead, return a short read.
1407 (tiff_load): Omit no-longer-needed casts.
1408 (Fimagemagick_types): Don't assume size fits into 'int'.
1409
1410 Improve hashing quality when configured --with-wide-int.
1411 * fns.c (hash_string): New function, taken from sxhash_string.
1412 Do not discard information about ASCII character case; this
1413 discarding is no longer needed.
1414 (sxhash-string): Use it. Change sig to match it. Caller changed.
1415 * lisp.h: Declare it.
1416 * lread.c (hash_string): Remove, since we now use fns.c's version.
1417 The fns.c version returns a wider integer if --with-wide-int is
1418 specified, so this should help the quality of the hashing a bit.
1419
1420 * emacs.c: Integer overflow minor fix.
1421 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1422 Define only if GNU_LINUX.
1423 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1424
1425 * dispnew.c: Integer signedness and overflow fixes.
1426 Remove unnecessary forward decls, that were a maintenance hassle.
1427 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1428 All uses changed.
1429 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1430 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1431 (prepare_desired_row, line_draw_cost):
1432 Use int, not unsigned, where either works.
1433 (save_current_matrix, restore_current_matrix):
1434 Use ptrdiff_t, not size_t, where either works.
1435 (init_display): Check for overflow more accurately, and without
1436 relying on undefined behavior.
1437
1438 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1439 Remove, replacing with the new symbols in lisp.h. All uses changed.
1440 * fileio.c (make_temp_name):
1441 * filelock.c (lock_file_1, lock_file):
1442 * xdisp.c (message_dolog):
1443 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1444 Use pMd etc. instead.
1445 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1446 replacing the pWIDE etc. symbols removed from editfns.c.
1447
1448 * keyboard.h (num_input_events): Now uintmax_t.
1449 This is (very slightly) less likely to mess up due to wraparound.
1450 All uses changed.
1451
1452 * buffer.c: Integer signedness fixes.
1453 (alloc_buffer_text, enlarge_buffer_text):
1454 Use ptrdiff_t rather than size_t when either will do, as we prefer
1455 signed integers.
1456
1457 * alloc.c: Integer signedness and overflow fixes.
1458 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1459 (__malloc_size_t): Default to size_t, not to int.
1460 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1461 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1462 Prefer ptrdiff_t to size_t when either would do, as we prefer
1463 signed integers.
1464 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1465 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1466 Now const. Initialize with values that are in range even if char
1467 is signed.
1468 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1469 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1470 These functions do the right thing with sizes > 2**32.
1471 (check_depth): Now ptrdiff_t, not int.
1472 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1473 Adjust to new way of storing sizes. Check for size overflow bugs
1474 in rest of code.
1475 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1476 slightly wrong anyway, as it missed one instance of
1477 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1478 (refill_memory_reserve): Omit needless cast to size_t.
1479 (mark_object_loop_halt): Mark as externally visible.
1480
1481 * xselect.c: Integer signedness and overflow fixes.
1482 (Fx_register_dnd_atom, x_handle_dnd_message):
1483 Use ptrdiff_t, not size_t, since we prefer signed.
1484 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1485 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1486 x_dnd_atoms_size and x_dnd_atoms_length.
1487
1488 * doprnt.c: Prefer signed to unsigned when either works.
1489 * eval.c (verror):
1490 * doprnt.c (doprnt):
1491 * lisp.h (doprnt):
1492 * xdisp.c (vmessage):
1493 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1494 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1495 prefer signed arithmetic to avoid comparison confusion.
1496 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1497 but is a bit tricky.
1498
1499 Assume freestanding C89 headers, string.h, stdlib.h.
1500 * data.c, doprnt.c, floatfns.c, print.c:
1501 Include float.h unconditionally.
1502 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1503 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1504 * regex.c: Likewise for stddef.h, string.h.
1505 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1506 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1507 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1508 (STDC_HEADERS): Remove obsolete defines.
1509 * sysdep.c: Include limits.h unconditionally.
1510
1511 Assume support for memcmp, memcpy, memmove, memset.
1512 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1513 * regex.c (memcmp, memcpy):
1514 Remove; we assume C89 now.
1515
1516 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1517 (__malloc_safe_bcopy): Remove; no longer needed.
1518
1519 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1520 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1521 well either way, and we prefer signed to unsigned.
1522
1523 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1524
1525 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1526 closes the connection while we're reading (bug#9182).
1527
1528 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1529
1530 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1531 are specified (Bug#9168).
1532
1533 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1534
1535 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1536 Found by GCC static checking and --with-wide-int on a 32-bit host.
1537
1538 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1539
1540 * xdisp.c (compute_display_string_pos): Fix logic of caching
1541 previous display string position. Initialize cached_prev_pos to
1542 -1. Fixes slow-down at the beginning of a buffer.
1543
1544 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1545
1546 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1547 for attrs[LFACE_FONTSET_INDEX].
1548
1549 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1550
1551 * xml.c (parse_region): Remove unused local
1552 that was recently introduced.
1553
1554 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1555
1556 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1557 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1558
1559 * xdisp.c (move_it_in_display_line_to): Record the best matching
1560 position for TO_CHARPOS while scanning the line, and restore it on
1561 exit if none of the characters scanned was an exact match.
1562 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1563 when exact match is impossible due to invisible text, and the
1564 lines are truncated.
1565
1566 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1567
1568 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1569 for OSX >= 10.7.
1570
1571 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1572
1573 Fix a significant slow-down of cursor motion with C-n, C-p,
1574 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1575 auto-repeat under bidi redisplay in fontified buffers.
1576 * xdisp.c (compute_stop_pos_backwards): New function.
1577 (next_element_from_buffer): Call compute_stop_pos_backwards to
1578 find a suitable prev_stop when we find ourselves before
1579 base_level_stop.
1580 (reseat): Don't look for prev_stop, as that could mean a very long
1581 run.
1582 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1583 <cached_disp_overlay_modiff>: Cache for last found display string
1584 position.
1585 (compute_display_string_pos): Return the cached position if asked
1586 about the same buffer in the same area of character positions, and
1587 the buffer wasn't changed since the time the display string
1588 position was cached.
1589
1590 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1591
1592 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1593 is an integer, which is important for empty lines. (Bug#9149)
1594
1595 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1596
1597 * frame.c (Fmodify_frame_parameters): In tty case, update the
1598 default face if necessary (Bug#4238).
1599
1600 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1601
1602 * editfns.c (Fstring_to_char): No need to explain what a character
1603 is in the docstring (Bug#6576).
1604
1605 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1606
1607 * xml.c (parse_region): Make sure we always return a tree.
1608
1609 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1610
1611 * xml.c (parse_region): If a document contains only comments,
1612 return that, too.
1613
1614 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1615
1616 * xml.c (make_dom): Return comments, too.
1617
1618 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1619
1620 Port to OpenBSD.
1621 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1622 and the surrounding thread.
1623 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1624 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1625 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1626 timer goes off.
1627 * s/openbsd.h (BROKEN_SIGIO): Define.
1628 * unexelf.c (unexec) [__OpenBSD__]:
1629 Don't update the .mdebug section of the Alpha COFF symbol table.
1630
1631 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1632
1633 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1634 (bug#8460).
1635
1636 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1637
1638 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1639 This fixes some race conditions on the permissions of any newly
1640 created file.
1641
1642 * alloc.c (valid_pointer_p): Use pipe, not open.
1643 This fixes some permissions issues when debugging.
1644
1645 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1646 If fchown fails to set both uid and gid, try to set just gid,
1647 as that is sometimes allowed. Adjust the file's mode to eliminate
1648 setuid or setgid bits that are inappropriate if fchown fails.
1649
1650 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1651
1652 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1653 to compare Lisp_Objects.
1654 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1655 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1656 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1657
1658 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1659
1660 * lread.c (read_integer): Unread even EOF character.
1661 (read1): Likewise. Properly record start position of symbol.
1662
1663 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1664 symbol character follows.
1665
1666 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1667
1668 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1669 This works around a problem with the previous change to Fcopy_file.
1670 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1671 and without this change, GCC might complain about discarding
1672 fchown's return value.
1673
1674 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1675
1676 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1677
1678 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1679
1680 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1681
1682 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1683
1684 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1685 it's used from the C level.
1686
1687 * process.c: Use the same condition for POLL_FOR_INPUT in both
1688 keyboard.c and process.c (bug#1858).
1689
1690 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1691
1692 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1693 (Fgnutls_boot): Use it.
1694
1695 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1696
1697 * doc.c (Fsubstitute_command_keys): Revert last change.
1698
1699 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1700
1701 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1702 quotes the next character, and doesn't affect other longer
1703 sequences (bug#8935).
1704
1705 * lread.c (syms_of_lread): Clarify that is isn't only
1706 `eval-buffer' and `eval-defun' that's affected by
1707 `lexical-binding' (bug#8460).
1708
1709 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1710
1711 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1712 bidi redisplay when a line includes both an image and is
1713 truncated.
1714
1715 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1716
1717 Fix minor problems found by static checking.
1718 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1719 (elsz): Now a signed constant, not a size_t var. We prefer signed
1720 types to unsigned, to avoid integer comparison confusion. Without
1721 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1722 "cannot optimize loop, the loop counter may overflow", a symptom
1723 of the confusion.
1724 * indent.c (Fvertical_motion): Mark locals as initialized.
1725 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1726
1727 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1728
1729 * search.c (Fre_search_backward): Mention `case-fold-search' in
1730 all the re_search_* functions (bug#8138).
1731
1732 * keyboard.c (Fopen_dribble_file): Document when the file is
1733 closed (bug#8056).
1734
1735 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1736
1737 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1738 bidi_cache_idx.
1739
1740 Support bidi reordering of display and overlay strings.
1741 * xdisp.c (compute_display_string_pos)
1742 (compute_display_string_end): Accept additional argument STRING.
1743 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1744 (reseat_to_string): Initialize bidi_it->string.s and
1745 bidi_it->string.schars.
1746 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1747 NULL (avoids a crash in bidi_paragraph_init).
1748 Initialize itb.string.lstring.
1749 (init_iterator): Call bidi_init_it only of a valid
1750 buffer position was specified. Initialize paragraph_embedding to
1751 L2R.
1752 (reseat_to_string): Initialize the bidi iterator.
1753 (display_string): If we need to ignore text properties of
1754 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1755 original value of -1 will not work with bidi.)
1756 (compute_display_string_pos): First arg is now struct
1757 `text_pos *'; all callers changed. Support display properties on
1758 Lisp strings.
1759 (compute_display_string_end): Support display properties on Lisp
1760 strings.
1761 (init_iterator, reseat_1, reseat_to_string): Initialize the
1762 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1763 when iterating on a string not from display properties).
1764 (compute_display_string_pos, compute_display_string_end):
1765 Fix calculation of the object to scan. Fixes an error when using
1766 arrow keys.
1767 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1768 base_level_stop; instead, set base_level_stop to BEGV.
1769 Fixes crashes in vertical-motion.
1770 (next_element_from_buffer): Improve commentary for when
1771 the iterator is before prev_stop.
1772 (init_iterator): Initialize bidi_p from the default value of
1773 bidi-display-reordering, not from buffer-local value. Use the
1774 buffer-local value only if initializing for buffer iteration.
1775 (handle_invisible_prop): Support invisible properties on strings
1776 that are being bidi-reordered.
1777 (set_iterator_to_next): Support bidi reordering of C strings and
1778 Lisp strings.
1779 (next_element_from_string): Support bidi reordering of Lisp
1780 strings.
1781 (handle_stop_backwards): Support Lisp strings as well.
1782 (display_string): Support display of R2L glyph rows.
1783 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1784 (init_iterator): Don't initialize it->bidi_p for strings
1785 here.
1786 (reseat_to_string): Initialize it->bidi_p for strings here.
1787 (next_element_from_string, next_element_from_c_string)
1788 (next_element_from_buffer): Add xassert's for correspondence
1789 between IT's object being iterated and it->bidi_it.string
1790 structure.
1791 (face_before_or_after_it_pos): Support bidi iteration.
1792 (next_element_from_c_string): Handle the case of the first string
1793 character that is not the first one in the visual order.
1794 (get_visually_first_element): New function, refactored from common
1795 parts of next_element_from_buffer, next_element_from_string, and
1796 next_element_from_c_string.
1797 (tool_bar_lines_needed, redisplay_tool_bar)
1798 (display_menu_bar): Force left-to-right direction. Add a FIXME
1799 comment for making that be controlled by a user option.
1800 (push_it, pop_it): Save and restore the state of the
1801 bidi iterator. Save and restore the bidi_p flag.
1802 (pop_it): Iterate out of display property for string iteration as
1803 well.
1804 (iterate_out_of_display_property): Support iteration over strings.
1805 (handle_single_display_spec): Set up it->bidi_it for iteration
1806 over a display string, and call bidi_init_it.
1807 (handle_single_display_spec, next_overlay_string)
1808 (get_overlay_strings_1, push_display_prop): Set up the bidi
1809 iterator for displaying display or overlay strings.
1810 (forward_to_next_line_start): Don't use the shortcut if
1811 bidi-iterating.
1812 (back_to_previous_visible_line_start): If handle_display_prop
1813 pushed the iterator stack, restore the internal state of the bidi
1814 iterator by calling bidi_pop_it same number of times.
1815 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1816 and we are bidi-iterating, don't decrement the iterator position;
1817 instead, set the first_elt flag in the bidi iterator, to produce
1818 the same effect.
1819 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1820 (push_display_prop): xassert that we are iterating a buffer.
1821 (push_it, pop_it): Save and restore paragraph_embedding member.
1822 (handle_single_display_spec, next_overlay_string)
1823 (get_overlay_strings_1, reseat_1, reseat_to_string)
1824 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1825 correctly. Don't assume unibyte strings are not bidi-reordered.
1826 (compute_display_string_pos)
1827 (compute_display_string_end): Fix handling the case of C string.
1828 (push_it, pop_it): Save and restore from_disp_prop_p.
1829 (handle_single_display_spec, push_display_prop): Set the
1830 from_disp_prop_p flag.
1831 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1832 (pop_it): Call iterate_out_of_display_property only if we are
1833 popping after iteration over a string that came from a display
1834 property. Fix a typo in popping stretch info. Add an assertion
1835 for verifying that the iterator position is in sync with the bidi
1836 iterator.
1837 (handle_single_display_spec, get_overlay_strings_1)
1838 (push_display_prop): Fix initialization of paragraph direction for
1839 string when that of the parent object is not yet determined.
1840 (reseat_1): Call bidi_init_it to resync the bidi
1841 iterator with IT's position. (Bug#7616)
1842 (find_row_edges): If ROW->start.pos gives position
1843 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1844 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1845 Reset the from_disp_prop_p flag.
1846 (SAVE_IT, RESTORE_IT): New macros.
1847 (pos_visible_p, face_before_or_after_it_pos)
1848 (back_to_previous_visible_line_start)
1849 (move_it_in_display_line_to, move_it_in_display_line)
1850 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1851 (try_scrolling, redisplay_window, display_line): Use them when
1852 saving a temporary copy of the iterator and restoring it back.
1853 (back_to_previous_visible_line_start, reseat_1)
1854 (init_iterator): Empty the bidi cache "stack".
1855 (move_it_in_display_line_to): If iterator ended up at
1856 EOL, but we never saw any buffer positions smaller than
1857 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1858 motion in bidi-reordered lines.
1859 (move_it_in_display_line_to): Record prev_method and prev_pos
1860 immediately before the call to set_iterator_to_next. Fixes cursor
1861 motion in bidi-reordered lines with stretch glyphs and strings
1862 displayed in margins. (Bug#8133) (Bug#8867)
1863 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1864 TO_CHARPOS.
1865 (pos_visible_p): Support positions in bidi-reordered lines.
1866 Save and restore bidi cache.
1867
1868 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1869 (bidi_paragraph_info): Delete unused struct.
1870 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1871 (bidi_cache_start): New variable.
1872 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1873 to zero.
1874 (bidi_cache_fetch_state, bidi_cache_search)
1875 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1876 (bidi_cache_find, bidi_peek_at_next_level)
1877 (bidi_level_of_next_char, bidi_find_other_level_edge)
1878 (bidi_move_to_visually_next): Compare cache index with
1879 bidi_cache_start rather than with zero.
1880 (bidi_fetch_char): Accept new argument STRING; all callers
1881 changed. Support iteration over a string. Support strings with
1882 display properties. Support unibyte strings. Fix the type of
1883 `len' according to what STRING_CHAR_AND_LENGTH expects.
1884 (bidi_paragraph_init, bidi_resolve_explicit_1)
1885 (bidi_resolve_explicit, bidi_resolve_weak)
1886 (bidi_level_of_next_char, bidi_move_to_visually_next):
1887 Support iteration over a string.
1888 (bidi_set_sor_type, bidi_resolve_explicit_1)
1889 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1890 can now be zero (for strings); special values 0 and -1 were
1891 changed to -1 and -2, respectively.
1892 (bidi_char_at_pos): New function.
1893 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1894 Call it instead of FETCH_MULTIBYTE_CHAR.
1895 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1896 initialized to valid values.
1897 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1898 values.
1899 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1900 the test for valid cached positions. Fix the logic for looking up
1901 the sentinel state in the cache. GCPRO the Lisp string we are
1902 iterating.
1903 (bidi_push_it, bidi_pop_it): New functions.
1904 (bidi_initialize): Initialize the bidi cache start stack pointer.
1905 (bidi_cache_ensure_space): New function, refactored from part of
1906 bidi_cache_iterator_state. Don't assume the required size is just
1907 one BIDI_CACHE_CHUNK away.
1908 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1909 (bidi_count_bytes, bidi_char_at_pos): New functions.
1910 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1911 always valid if bidi_cache_idx is valid.
1912 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1913 is valid if it's going to be used.
1914 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1915 (bidi_cache_fetch_state, bidi_cache_search)
1916 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1917 (bidi_cache_iterator_state, bidi_cache_find)
1918 (bidi_find_other_level_edge, bidi_cache_start_stack):
1919 All variables related to cache indices are now EMACS_INT.
1920
1921 * dispextern.h (struct bidi_string_data): New structure.
1922 (struct bidi_it): New member `string'. Make flag members be 1-bit
1923 fields, and put them last in the struct.
1924 (compute_display_string_pos, compute_display_string_end):
1925 Update prototypes.
1926 (bidi_push_it, bidi_pop_it): Add prototypes.
1927 (struct iterator_stack_entry): New members bidi_p,
1928 paragraph_embedding, and from_disp_prop_p.
1929 (struct it): Member bidi_p is now a bit field 1 bit wide.
1930 (bidi_shelve_cache, bidi_unshelve_cache):
1931 Declare prototypes.
1932
1933 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1934 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1935 and vector-like objects.
1936
1937 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1938 cache around display iteration.
1939
1940 * window.c (Fwindow_end, window_scroll_pixel_based)
1941 (displayed_window_lines, Frecenter): Save and restore the bidi
1942 cache around display iteration.
1943
1944 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1945
1946 * editfns.c (Fdelete_region): Clarify the use of the named
1947 parameters (bug#6788).
1948
1949 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1950
1951 * indent.c (Fvertical_motion): Set and restore w->pointm when
1952 saving and restoring the window's buffer (Bug#9006).
1953
1954 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1955
1956 * editfns.c (Fstring_to_char): Clarify just what is returned
1957 (bug#6576). Text by Eli Zaretskii.
1958
1959 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1960
1961 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1962
1963 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1964
1965 * buffer.c (mmap_find): Fix a typo.
1966
1967 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1968
1969 Fix execution of x selection hooks.
1970 * xselect.c (Qx_lost_selection_functions)
1971 (Qx_sent_selection_functions): New vars.
1972 (syms_of_xselect): DEFSYM them.
1973 (x_handle_selection_request): Pass Qx_sent_selection_functions
1974 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1975 (x_handle_selection_clear,x_clear_frame_selections):
1976 Pass Qx_lost_selection_functions rather than
1977 Vx_lost_selection_functions to Frun_hook_with_args.
1978
1979 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1980
1981 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1982 The old code sometimes used this field without initializing it.
1983
1984 * alloc.c (gc_sweep): Don't read past end of array.
1985 In theory, the old code could also have corrupted Emacs internals,
1986 though it'd be very unlikely.
1987
1988 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1989
1990 * character.c (Fcharacterp): Don't advertise optional ignored
1991 argument. (Bug#4026)
1992
1993 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1994
1995 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1996 key" (bug#4257).
1997
1998 * window.c (Fset_window_start): Doc fix (bug#4199).
1999 (Fset_window_hscroll): Ditto.
2000
2001 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2002
2003 Fix minor new problems caught by GCC 4.6.1.
2004 * term.c (init_tty): Remove unused local.
2005 * xsettings.c (store_monospaced_changed): Define this function only
2006 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2007 not used otherwise.
2008
2009 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2010
2011 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2012
2013 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2014
2015 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2016 are the mini-buffer and the echo area (bug#3320).
2017
2018 * term.c (init_tty): Remove support for supdup, c10 and perq
2019 terminals, which are no longer supported (bug#1482).
2020
2021 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2022
2023 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2024
2025 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2026
2027 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2028 for non-popups (Bug#3642).
2029
2030 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2031
2032 * alloc.c (reset_malloc_hooks): Protoize.
2033 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2034 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2035 * cm.c (losecursor): Likewise.
2036 * data.c (fmod): Likewise.
2037 * dispnew.c (swap_glyphs_in_rows): Likewise.
2038 * emacs.c (memory_warning_signal): Likewise.
2039 * floatfns.c (float_error): Likewise.
2040 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2041 (otf_open, font_otf_capability, generate_otf_features)
2042 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2043 Likewise.
2044 * image.c (pbm_read_file): Likewise.
2045 * indent.c (string_display_width): Likewise.
2046 * intervals.c (check_for_interval, search_for_interval)
2047 (inc_interval_count, count_intervals, root_interval)
2048 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2049 * lread.c (defalias): Likewise.
2050 * ralloc.c (r_alloc_check): Likewise.
2051 * regex.c (set_image_of_range_1, set_image_of_range)
2052 (regex_grow_registers): Likewise.
2053 * sysdep.c (strerror): Likewise.
2054 * termcap.c (valid_filename_p, tprint, main): Likewise.
2055 * tparam.c (main): Likewise.
2056 * unexhp9k800.c (run_time_remap, save_data_space)
2057 (update_file_ptrs, read_header, write_header, calculate_checksum)
2058 (copy_file, copy_rest, display_header): Likewise.
2059 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2060 Likewise.
2061 * xdisp.c (check_it): Likewise.
2062 * xfaces.c (register_color, unregister_color, unregister_colors):
2063 Likewise.
2064 * xfns.c (print_fontset_result): Likewise.
2065 * xrdb.c (member, fatal, main): Likewise.
2066
2067 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2068
2069 Fix minor problems found by static checking (Bug#9031).
2070 * chartab.c (char_table_set_range, map_sub_char_table):
2071 Remove unused locals.
2072 (uniprop_table): Now static.
2073 * composite.c (_work_char): Remove unused static var.
2074
2075 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2076
2077 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2078
2079 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2080
2081 * gtkutil.c (qttip_cb): Remove code without function.
2082
2083 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2084
2085 * w32.c (pthread_sigmask): New stub.
2086
2087 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2088
2089 Use pthread_sigmask, not sigprocmask (Bug#9010).
2090 sigprocmask is portable only for single-threaded applications, and
2091 Emacs can be multi-threaded when it uses GTK.
2092 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2093 (LIBES): Use it.
2094 * callproc.c (Fcall_process):
2095 * process.c (create_process):
2096 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2097 Use pthread_sigmask, not sigprocmask.
2098
2099 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2100
2101 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2102 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2103 wrong (Bug#8591).
2104
2105 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2106
2107 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2108 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2109 (xg_hide_tooltip): Fix comment.
2110
2111 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2112 in registerServicesMenuSendTypes.
2113 (validRequestorForSendType): Don't check ns_return_types.
2114
2115 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2116 ns_return_type.
2117
2118 2011-07-08 Jason Rumney <jasonr@gnu.org>
2119
2120 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2121 frame struct members of non-existent frames (Bug#6284).
2122
2123 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2124
2125 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2126 variable firstTime not needed on OSX >= 10.6.
2127 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2128 >= 10.5. Use setKnobProportion, setDoubleValue.
2129
2130 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2131 (MAC_OS_X_VERSION_10_5): Define if not defined.
2132 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2133 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2134 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2135
2136 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2137 cString and lossyCString on OSX >= 10.4
2138
2139 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2140 sizeToFit on OSX >= 10.2.
2141
2142 * nsimage.m (allocInitFromFile): Don't use deprecated method
2143 bestRepresentationForDevice on OSX >= 10.6.
2144
2145 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2146 to avoid warning.
2147
2148 * emacs.c: Declare unexec_init_emacs_zone.
2149
2150 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2151
2152 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2153
2154 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2155 on svcsMenu (Bug#8842).
2156
2157 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2158 ns_return_types.
2159 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2160
2161 * nsterm.m (QUTF8_STRING): Declare.
2162 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2163 (validRequestorForSendType): Return type is (id).
2164 Change indexOfObjectIdenticalTo to indexOfObject.
2165 Check if we have local selection before returning self (Bug#8842).
2166 (writeSelectionToPasteboard): Put local selection into paste board
2167 if we have a local selection (Bug#8842).
2168 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2169
2170 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2171 (ns_get_local_selection): Declare.
2172
2173 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2174
2175 * keymap.c (describe_map_tree): Don't insert a double newline at
2176 the end of the buffer (bug#1169) and return whether we inserted
2177 something.
2178
2179 * callint.c (Fcall_interactively): Change "reading args" to
2180 "providing args" to try to clarify what it does (bug#1010).
2181
2182 2011-07-07 Kenichi Handa <handa@m17n.org>
2183
2184 * composite.c (composition_compute_stop_pos): Ignore a static
2185 composition starting before CHARPOS (Bug#8915).
2186
2187 * xdisp.c (handle_composition_prop): Likewise.
2188
2189 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2190
2191 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2192 (Bug#9015)
2193
2194 2011-07-07 Kenichi Handa <handa@m17n.org>
2195
2196 * character.h (unicode_category_t): New enum type.
2197
2198 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2199 (Qchar_code_property_table): New variable.
2200 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2201 (UNIPROP_COMPRESSED_FORM_P): New macros.
2202 (char_table_ascii): Uncompress the compressed values.
2203 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2204 Uncompress the compressed values.
2205 (sub_char_table_ref_and_range): Likewise.
2206 (char_table_ref_and_range): Uncompress the compressed values.
2207 (sub_char_table_set): New arg is_uniprop. Callers changed.
2208 Uncompress the compressed values.
2209 (sub_char_table_set_range): Args changed. Callers changed.
2210 (char_table_set_range): Adjuted for the above change.
2211 (map_sub_char_table): Delete args default_val and parent. Add arg
2212 top. Give decoded values to a Lisp function.
2213 (map_char_table): Adjust for the above change. Give decoded
2214 values to a Lisp function. Gcpro more variables.
2215 (uniprop_table_uncompress)
2216 (uniprop_decode_value_run_length): New functions.
2217 (uniprop_decoder, uniprop_decoder_count): New variables.
2218 (uniprop_get_decoder, uniprop_encode_value_character)
2219 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2220 New functions.
2221 (uniprop_encoder, uniprop_encoder_count): New variables.
2222 (uniprop_get_encoder, uniprop_table)
2223 (Funicode_property_table_internal, Fget_unicode_property_internal)
2224 (Fput_unicode_property_internal): New functions.
2225 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2226 Sunicode_property_table_internal, Sget_unicode_property_internal,
2227 and Sput_unicode_property_internal. Defvar_lisp
2228 char-code-property-alist.
2229
2230 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2231 Vunicode_category_table.
2232
2233 * font.c (font_range): Adjust for the change of
2234 Vunicode_category_table.
2235
2236 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2237
2238 * m/iris4d.h: Remove file, move contents ...
2239 * s/irix6-5.h: ... here.
2240
2241 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2242
2243 Remove unportable assumption about struct layout (Bug#8884).
2244 * alloc.c (mark_buffer):
2245 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2246 (clone_per_buffer_values): Don't assume that
2247 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2248 This isn't true in general, and it's particularly not true
2249 if Emacs is configured with --with-wide-int.
2250 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2251 New macros, used in the buffer.c change.
2252
2253 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2254
2255 * xsettings.c: Use both GConf and GSettings if both are available.
2256 (store_config_changed_event): Add comment.
2257 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2258 (store_tool_bar_style_changed): New functions.
2259 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2260 (struct xsettings): Move font inside HAVE_XFT.
2261 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2262 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2263 Move inside HAVE_XFT.
2264 (something_changed_gsettingsCB): Rename from something_changedCB.
2265 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2266 also.
2267 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2268 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2269 (something_changed_gconfCB): Rename from something_changedCB.
2270 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2271 (parse_settings): Move check for font inside HAVE_XFT.
2272 (read_settings, apply_xft_settings): Add comment.
2273 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2274 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2275 call store_font_name_changed.
2276 (xft_settings_event): Add comment.
2277 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2278 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2279 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2280 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2281 (xsettings_initialize): Call init_gsettings last.
2282 (xsettings_get_system_font, xsettings_get_system_normal_font):
2283 Add comment.
2284
2285 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2286
2287 Random fixes. E.g., (random) never returned negative values.
2288 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2289 subseconds part to the entropy, as that's a bit more random.
2290 Prefer signed to unsigned, since the signedness doesn't matter and
2291 in general we prefer signed. When given a limit, use a
2292 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2293 latter isn't right if USE_2_TAGS_FOR_INTS.
2294 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2295 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2296
2297 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2298
2299 * textprop.c (text_property_stickiness):
2300 Obey Vtext_property_default_nonsticky.
2301 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2302 * w32fns.c (syms_of_w32fns):
2303 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2304
2305 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2306
2307 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2308 This is more efficient than Ffile_directory_p and avoids a minor race.
2309
2310 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2311
2312 * buffer.c (Foverlay_put): Say what the return value is
2313 (bug#7835).
2314
2315 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2316 is a directory before asking whether to use the file name
2317 (bug#7564).
2318 (barf_or_query_if_file_exists): Make the "File is a directory"
2319 error be more correct.
2320
2321 * fns.c (Frequire): Remove the mention of the .gz files, since
2322 that's installation-specific, but keep the mention of
2323 `get-load-suffixes'.
2324
2325 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2326
2327 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2328 Report string overflow if the output is too long.
2329
2330 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2331
2332 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2333 (syms_of_gnutls): Remove duplicate DEFSYM for
2334 Qgnutls_bootprop_verify_hostname_error, an error for
2335 Qgnutls_bootprop_verify_error (which is no longer used).
2336
2337 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2338 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2339 Also (re)move comments that are misplaced or no longer relevant.
2340
2341 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2342
2343 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2344
2345 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2346
2347 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2348 and background color parameters if they have been changed.
2349
2350 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2351
2352 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2353
2354 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2355
2356 * xsettings.c (SYSTEM_FONT): Define only when used.
2357 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2358
2359 * keymap.c (access_keymap_1): Now static.
2360
2361 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2362
2363 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2364 leave any prefix arg for the up event (Bug#1586).
2365
2366 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2367
2368 * lread.c (syms_of_lread): Mention single symbols defined by
2369 `defvar' or `defconst' (bug#7154).
2370
2371 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2372 (Frequire): Mention get-load-suffixes.
2373
2374 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2375
2376 * window.h (window): Remove clone_number slot.
2377 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2378 Remove.
2379 (make_parent_window, make_window, saved_window)
2380 (Fset_window_configuration, save_window_save): Don't deal with
2381 clone numbers.
2382 * buffer.c (Qclone_number): Remove declaration.
2383 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2384
2385 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2386
2387 Add multiple inheritance to keymaps.
2388 * keymap.c (Fmake_composed_keymap): New function.
2389 (Fset_keymap_parent): Simplify.
2390 (fix_submap_inheritance): Remove.
2391 (access_keymap_1): New function extracted from access_keymap to handle
2392 embedded parents and handle lists of maps.
2393 (access_keymap): Use it.
2394 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2395 (Fcopy_keymap): Handle embedded parents.
2396 (Fcommand_remapping, define_as_prefix): Simplify.
2397 (Fkey_binding): Simplify.
2398 (syms_of_keymap): Move minibuffer-local-completion-map,
2399 minibuffer-local-filename-completion-map,
2400 minibuffer-local-must-match-map, and
2401 minibuffer-local-filename-must-match-map to Elisp.
2402 (syms_of_keymap): Defsubr make-composed-keymap.
2403 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2404 (parse_menu_item): Trivial simplification.
2405
2406 2011-07-01 Glenn Morris <rgm@gnu.org>
2407
2408 * Makefile.in (SETTINGS_LIBS): Fix typo.
2409
2410 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2411
2412 * coding.c (Fencode_coding_string): Record the last coding system
2413 used, as the function doc string says (bug#8738).
2414
2415 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2416
2417 * xsettings.c (store_monospaced_changed): Take new font as arg and
2418 check for change against current_mono_font.
2419 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2420 (emacs_settings_constructor, emacs_settings_get_property)
2421 (emacs_settings_set_property, emacs_settings_class_init)
2422 (emacs_settings_init, gsettings_obj): Remove.
2423 (something_changedCB): New function for HAVE_GSETTINGS.
2424 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2425 with value as argument.
2426 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2427 g_settings_new (Bug#8967). Do not create gsettings_obj.
2428 Remove calls to g_settings_bind. Connect something_changedCB to
2429 "changed".
2430
2431 * xgselect.c: Add defined (HAVE_GSETTINGS).
2432 (xgselect_initialize): Ditto.
2433
2434 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2435 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2436 xg_select.
2437
2438 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2439
2440 * eval.c (struct backtrace): Simplify and port the data structure.
2441 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2442 signed bit field, as this assumption is not portable and it makes
2443 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2444 "char debug_on_exit : 1" as this is not portable either; instead,
2445 use the portable "unsigned int debug_on_exit : 1". Remove unused
2446 member evalargs. Remove obsolete comments about cc bombing out.
2447
2448 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2449
2450 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2451 Let HAVE_GSETTINGS override HAVE_GCONF.
2452 (store_monospaced_changed): New function.
2453 (EMACS_SETTINGS): A new type derived from GObject to handle
2454 GSettings notifications.
2455 (emacs_settings_constructor, emacs_settings_get_property)
2456 (emacs_settings_set_property, emacs_settings_class_init):
2457 New functions.
2458 (gsettings_client, gsettings_obj): New variables.
2459 (GSETTINGS_SCHEMA): New define.
2460 (something_changedCB): Call store_monospaced_changed.
2461 (init_gsettings): New function.
2462 (xsettings_initialize): Call init_gsettings.
2463 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2464 to NULL.
2465
2466 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2467 GCONF_CFLAGS/LIBS.
2468
2469 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2470
2471 * window.c (resize_root_window, grow_mini_window)
2472 (shrink_mini_window): Rename Qresize_root_window to
2473 Qwindow_resize_root_window and Qresize_root_window_vertically to
2474 Qwindow_resize_root_window_vertically.
2475
2476 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2477
2478 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2479
2480 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2481
2482 * makefile.w32-in: Redesign dependencies so they reflect more
2483 clearly which files are directly included by each source file,
2484 and not through other includes.
2485
2486 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2487
2488 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2489 (sort_overlays, overlay_strings): When an overlay's clone number
2490 matches the window's clone number process the overlay even if
2491 the overlay's window property doesn't match the current window.
2492
2493 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2494 (Fwindow_hchild): Rename to Fwindow_left_child.
2495 (Fwindow_next): Rename to Fwindow_next_sibling.
2496 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2497 (resize_window_check): Rename to window_resize_check.
2498 (resize_window_apply): Rename to window_resize_apply.
2499 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2500 (Fdelete_other_windows_internal, resize_frame_windows)
2501 (Fsplit_window_internal, Fdelete_window_internal)
2502 (grow_mini_window, shrink_mini_window)
2503 (Fresize_mini_window_internal): Fix callers accordingly.
2504
2505 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2506
2507 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2508 (emacs_fixed_set_min_size): Remove.
2509 (emacs_fixed_new): Take frame as argument.
2510
2511 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2512 (_EmacsFixedPrivate): Remove minwidth/height.
2513 Add struct frame *f.
2514 (emacs_fixed_init): Initialize priv->f.
2515 (get_parent_class, emacs_fixed_set_min_size): Remove.
2516 (emacs_fixed_new): Set priv->f to argument.
2517 (emacs_fixed_get_preferred_width)
2518 (emacs_fixed_get_preferred_height): Use min_width/height from
2519 frames size_hint to set minimum and natural (Bug#8919).
2520 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2521 and use min_width/height from frames size_hint to set
2522 min_width/height (Bug#8919).
2523
2524 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2525 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2526 Fix indentation.
2527
2528 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2529
2530 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2531 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2532 called at ZV.
2533
2534 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2535
2536 * process.c (wait_reading_process_output): Bypass select if
2537 waiting for a cell while ignoring keyboard input, and input is
2538 pending. Suggested by Jan Djärv (Bug#8869).
2539
2540 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2541
2542 Use gnulib's dup2 module instead of rolling our own.
2543 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2544
2545 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2546
2547 * dispnew.c (scrolling_window): Before scrolling, turn off a
2548 mouse-highlight in the window being scrolled.
2549
2550 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2551
2552 Move DEFSYM to lisp.h and use everywhere.
2553
2554 * character.h (DEFSYM): Move declaration...
2555 * lisp.h (DEFSYM): ...here.
2556
2557 * gnutls.c:
2558 * minibuf.c:
2559 * w32menu.c:
2560 * w32proc.c:
2561 * w32select.c: Don't include character.h.
2562
2563 * alloc.c (syms_of_alloc):
2564 * buffer.c (syms_of_buffer):
2565 * bytecode.c (syms_of_bytecode):
2566 * callint.c (syms_of_callint):
2567 * casefiddle.c (syms_of_casefiddle):
2568 * casetab.c (init_casetab_once):
2569 * category.c (init_category_once, syms_of_category):
2570 * ccl.c (syms_of_ccl):
2571 * cmds.c (syms_of_cmds):
2572 * composite.c (syms_of_composite):
2573 * dbusbind.c (syms_of_dbusbind):
2574 * dired.c (syms_of_dired):
2575 * dispnew.c (syms_of_display):
2576 * doc.c (syms_of_doc):
2577 * editfns.c (syms_of_editfns):
2578 * emacs.c (syms_of_emacs):
2579 * eval.c (syms_of_eval):
2580 * fileio.c (syms_of_fileio):
2581 * fns.c (syms_of_fns):
2582 * frame.c (syms_of_frame):
2583 * fringe.c (syms_of_fringe):
2584 * insdel.c (syms_of_insdel):
2585 * keymap.c (syms_of_keymap):
2586 * lread.c (init_obarray, syms_of_lread):
2587 * macros.c (syms_of_macros):
2588 * msdos.c (syms_of_msdos):
2589 * print.c (syms_of_print):
2590 * process.c (syms_of_process):
2591 * search.c (syms_of_search):
2592 * sound.c (syms_of_sound):
2593 * syntax.c (init_syntax_once, syms_of_syntax):
2594 * terminal.c (syms_of_terminal):
2595 * textprop.c (syms_of_textprop):
2596 * undo.c (syms_of_undo):
2597 * w32.c (globals_of_w32):
2598 * window.c (syms_of_window):
2599 * xdisp.c (syms_of_xdisp):
2600 * xfaces.c (syms_of_xfaces):
2601 * xfns.c (syms_of_xfns):
2602 * xmenu.c (syms_of_xmenu):
2603 * xsettings.c (syms_of_xsettings):
2604 * xterm.c (syms_of_xterm): Use DEFSYM.
2605
2606 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2607
2608 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2609
2610 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2611
2612 Integer and buffer overflow fixes (Bug#8873).
2613
2614 * print.c (printchar, strout): Check for string overflow.
2615 (PRINTPREPARE, printchar, strout):
2616 Don't set size unless allocation succeeds.
2617
2618 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2619 for sizes. Check for string overflow more accurately.
2620 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2621
2622 * macros.c: Integer and buffer overflow fixes.
2623 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2624 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2625 Use ptrdiff_t, not int, for sizes.
2626 Don't increment bufsize until after realloc succeeds.
2627 Check for size-calculation overflow.
2628 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2629
2630 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2631
2632 * lread.c: Integer overflow fixes.
2633 (read_integer): Radix is now EMACS_INT, not int,
2634 to improve quality of diagnostics for out-of-range radices.
2635 Calculate buffer size correctly for out-of-range radices.
2636 (read1): Check for integer overflow in radices, and in
2637 read-circle numbers.
2638 (read_escape): Avoid int overflow.
2639 (Fload, openp, read_buffer_size, read1)
2640 (substitute_object_recurse, read_vector, read_list, map_obarray):
2641 Use ptrdiff_t, not int, for sizes.
2642 (read1): Use EMACS_INT, not int, for sizes.
2643 Check for size overflow.
2644
2645 * image.c (cache_image): Check for size arithmetic overflow.
2646
2647 * lread.c: Integer overflow issues.
2648 (saved_doc_string_size, saved_doc_string_length)
2649 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2650 Now ptrdiff_t, not int.
2651 (read1): Don't assume doc string length fits in int. Check for
2652 out-of-range doc string lengths.
2653 (read_list): Don't assume file position fits in int.
2654 (read_escape): Check for hex character overflow.
2655
2656 2011-06-22 Leo Liu <sdl.web@gmail.com>
2657
2658 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2659 Move to minibuffer.el.
2660
2661 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2662
2663 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2664 The following patches are for when GLYPH_DEBUG && !XASSERT.
2665 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2666 * dispnew.c (flush_stdout):
2667 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2668 Mark as externally visible.
2669 * dispnew.c (check_window_matrix_pointers): Now static.
2670 * dispnew.c (window_to_frame_vpos):
2671 * xfns.c (unwind_create_frame):
2672 * xterm.c (x_check_font): Remove unused local.
2673 * scroll.c (CHECK_BOUNDS):
2674 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2675 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2676 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2677 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2678 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2679 Now static.
2680 (debug_method_add): Use va_list and vsprintf rather than relying
2681 on undefined behavior with wrong number of arguments.
2682 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2683 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2684 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2685 since we're not interested in debugging glyphs with old libraries.
2686 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2687 GCC 4.6.0's static checking.
2688
2689 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2690
2691 Integer overflow and signedness fixes (Bug#8873).
2692 A few related buffer overrun fixes, too.
2693
2694 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2695
2696 * dispextern.h (struct face.stipple):
2697 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2698 (x_bitmap_mask, x_allocate_bitmap_record)
2699 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2700 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2701 (x_create_bitmap_from_xpm_data):
2702 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2703 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2704 (.bitmaps_last):
2705 * xfaces.c (load_pixmap):
2706 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2707 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2708 (.bitmaps_last, struct x_output.icon_bitmap):
2709 Use ptrdiff_t, not int, for bitmap indexes.
2710 (x_allocate_bitmap_record): Check for size overflow.
2711 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2712
2713 Use ptrdiff_t, not int, for overlay counts.
2714 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2715 * editfns.c (overlays_around, get_pos_property):
2716 * textprop.c (get_char_property_and_overlay):
2717 * xdisp.c (next_overlay_change, note_mouse_highlight):
2718 * xfaces.c (face_at_buffer_position):
2719 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2720 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2721 (Fnext_overlay_change, Fprevious_overlay_change)
2722 (mouse_face_overlay_overlaps, Foverlays_in):
2723 Use ptrdiff_t, not int, for sizes.
2724 (overlays_at, overlays_in): Check for size-calculation overflow.
2725
2726 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2727
2728 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2729 (x_session_initialize): Do not assume string length fits in int.
2730
2731 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2732 This is unlikely, but can occur if DPI is outlandish.
2733
2734 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2735 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2736
2737 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2738 * xrdb.c (magic_file_p, search_magic_path):
2739 Omit last arg SUFFIX; it was always 0. All callers changed.
2740 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2741
2742 * xfont.c (xfont_match): Avoid need for strlen.
2743
2744 * xfns.c: Don't assume strlen fits in int.
2745 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2746
2747 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2748 not unsigned long, as we prefer signed integers. All callers changed.
2749 Detect integer overflow in repeat count.
2750 (message_dolog): Don't assume print length fits in 39 bytes.
2751 (display_mode_element): Don't assume strlen fits in int.
2752
2753 * termcap.c: Don't assume sizes fit in int and never overflow.
2754 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2755 (gobble_line): Check for size-calculation overflow.
2756
2757 * minibuf.c (Fread_buffer):
2758 * lread.c (intern, intern_c_string):
2759 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2760 Don't assume string length fits in int.
2761
2762 * keyboard.c (parse_tool_bar_item):
2763 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2764
2765 * font.c: Don't assume string length fits in int.
2766 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2767 Use ptrdiff_t, not int.
2768 (font_intern_prop): Don't assume string length fits in int.
2769 Don't assume integer property fits in fixnum.
2770 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2771
2772 * filelock.c: Fix some buffer overrun and integer overflow issues.
2773 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2774 Reformulate so as not to need the command string.
2775 Invoke gzip -cd rather than gunzip, as it's more portable.
2776 (lock_info_type, lock_file_1, lock_file):
2777 Don't assume pid_t and time_t fit in unsigned long.
2778 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2779 (current_lock_owner): Prefer signed type for sizes.
2780 Use memcpy, not strncpy, where memcpy is what is really wanted.
2781 Don't assume (via atoi) that time_t and pid_t fit in int.
2782 Check for time_t and/or pid_t out of range, e.g., via a network share.
2783 Don't alloca where an auto var works fine.
2784
2785 * fileio.c: Fix some integer overflow issues.
2786 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2787 Don't assume string length fits in int.
2788 (directory_file_name): Don't assume string length fits in long.
2789 (make_temp_name): Don't assume pid fits in int, or that its print
2790 length is less than 20.
2791
2792 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2793
2794 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2795
2796 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2797
2798 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2799 We prefer signed integers, even for size calculations.
2800
2801 * emacs.c: Don't assume string length fits in 'int'.
2802 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2803 (main): Don't invoke strlen when not needed.
2804
2805 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2806 (XD_DEBUG_MESSAGE): Don't waste a byte.
2807
2808 * callproc.c (getenv_internal_1, getenv_internal)
2809 (Fgetenv_internal):
2810 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2811
2812 * lread.c (invalid_syntax): Omit length argument.
2813 All uses changed. This doesn't fix a bug, but it simplifies the
2814 code away from its former Hollerith-constant appearance, and it's
2815 one less 'int' to worry about when looking at integer-overflow issues.
2816 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2817
2818 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2819 This didn't break anything, but it didn't help either.
2820 It's confusing to put a bogus integer in a place where the actual
2821 value does not matter.
2822 (LIST_END_P): Remove unused macro and its bogus comment.
2823 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2824
2825 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2826 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2827 implementation.
2828 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2829 We prefer signed types, and the value cannot exceed the EMACS_INT
2830 range anyway (because otherwise the length would not be representable).
2831 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2832 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2833 This avoids a GCC warning when WIDE_EMACS_INT.
2834
2835 * indent.c (sane_tab_width): New function.
2836 (current_column, scan_for_column, Findent_to, position_indentation)
2837 (compute_motion): Use it. This is just for clarity.
2838 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2839
2840 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2841
2842 * lisp.h (lint_assume): New macro.
2843 * composite.c (composition_gstring_put_cache):
2844 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2845
2846 * editfns.c, insdel.c:
2847 Omit unnecessary forward decls, to simplify future changes.
2848
2849 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2850
2851 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2852
2853 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2854 Use much-faster test for byte-length change.
2855 Don't assume string byte-length fits in 'int'.
2856 Check that character arg fits in 'int'.
2857 (mapcar1): Declare byte as byte, for clarity.
2858
2859 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2860
2861 * fns.c (concat): Catch string overflow earlier.
2862 Do not rely on integer wraparound.
2863
2864 * dispextern.h (struct it.overlay_strings_charpos)
2865 (struct it.selective): Now EMACS_INT, not int.
2866 * xdisp.c (forward_to_next_line_start)
2867 (back_to_previous_visible_line_start)
2868 (reseat_at_next_visible_line_start, next_element_from_buffer):
2869 Don't arbitrarily truncate the value of 'selective' to int.
2870
2871 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2872
2873 * composite.c: Don't truncate sizes to 'int'.
2874 (composition_gstring_p, composition_reseat_it)
2875 (composition_adjust_point): Use EMACS_INT, not int.
2876 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2877 not EMACS_UINT, for indexes.
2878
2879 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2880
2881 * buffer.c: Include <verify.h>.
2882 (struct sortvec.priority, struct sortstr.priority):
2883 Now EMACS_INT, not int.
2884 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2885 (struct sortstr.size, record_overlay_string)
2886 (struct sortstrlist.size, struct sortlist.used):
2887 Don't truncate size to int.
2888 (record_overlay_string): Check for size-calculation overflow.
2889 (init_buffer_once): Check at compile-time, not run-time.
2890
2891 2011-06-22 Jim Meyering <meyering@redhat.com>
2892
2893 Don't leak an XBM-image-sized buffer
2894 * image.c (xbm_load): Free the image buffer after using it.
2895
2896 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2897
2898 Port to Sun C.
2899 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2900 that Sun C diagnosed.
2901 * fns.c (secure_hash): Fix pointer signedness issue.
2902 * intervals.c (static_offset_intervals): New function.
2903 (offset_intervals): Use it.
2904
2905 2011-06-21 Leo Liu <sdl.web@gmail.com>
2906
2907 * deps.mk (fns.o):
2908 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2909 sha512.h.
2910
2911 * fns.c (secure_hash): Rename from crypto_hash_function and change
2912 the first arg to accept symbols.
2913 (Fsecure_hash): New primitive.
2914 (syms_of_fns): New symbols.
2915
2916 2011-06-20 Deniz Dogan <deniz@dogan.se>
2917
2918 * process.c (Fset_process_buffer): Clarify return value in
2919 docstring.
2920
2921 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2922
2923 * dispnew.c (add_window_display_history): Use BVAR.
2924
2925 * xdisp.c (debug_method_add): Use BVAR.
2926 (check_window_end, dump_glyph_matrix, dump_glyph)
2927 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2928
2929 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2930 Likewise.
2931
2932 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2933 check till after the cache is created in init_frame_faces.
2934
2935 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2936
2937 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2938
2939 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2940
2941 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2942 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2943 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2944
2945 Improve buffer-overflow checking (Bug#8873).
2946 * fileio.c (Finsert_file_contents):
2947 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2948 Remove the old (too-loose) buffer overflow checks.
2949 They weren't needed, since make_gap checks for buffer overflow.
2950 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2951 The old code merely checked for Emacs fixnum overflow, and relied
2952 on undefined (wraparound) behavior. The new code avoids undefined
2953 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2954
2955 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2956 Tune. Don't use wider integers than needed. Don't use alloca.
2957 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2958
2959 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2960
2961 * insdel.c, lisp.h (buffer_overflow): New function.
2962 (insert_from_buffer_1, replace_range, replace_range_2):
2963 * insdel.c (make_gap_larger):
2964 * editfns.c (Finsert_char):
2965 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2966
2967 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2968
2969 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2970
2971 Integer overflow and signedness fixes (Bug#8873).
2972
2973 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2974 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2975
2976 * fileio.c: Don't assume EMACS_INT fits in off_t.
2977 (emacs_lseek): New static function.
2978 (Finsert_file_contents, Fwrite_region): Use it.
2979 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2980
2981 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2982
2983 * fns.c: Don't overflow int when computing a list length.
2984 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2985 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2986 truncation on 64-bit hosts. Check for QUIT every
2987 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2988 faster and is responsive enough.
2989 (Flength): Report an error instead of overflowing an integer.
2990 (Fsafe_length): Return a float if the value is not representable
2991 as a fixnum. This shouldn't happen except in contrived situations.
2992 (Fnthcdr, Fsort): Don't assume list length fits in int.
2993 (Fcopy_sequence): Don't assume vector length fits in int.
2994
2995 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2996 (header_size, word_size): New constants.
2997 (allocate_vectorlike): Don't check size overflow here.
2998 (allocate_vector): Check it here instead, since this is the only
2999 caller of allocate_vectorlike that could cause overflow.
3000 Check that the new vector's length is representable as a fixnum.
3001
3002 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3003 The previous code was bogus. For example, next_almost_prime (32)
3004 returned 39, which is undesirable as it is a multiple of 3; and
3005 next_almost_prime (24) returned 25, which is a multiple of 5 so
3006 why was the code bothering to check for multiples of 7?
3007
3008 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3009
3010 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3011
3012 Variadic C functions now count arguments with ptrdiff_t.
3013 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3014 Back then I didn't know that the Emacs coding style prefers signed int.
3015 Also, in the meantime I found a few more instances where arguments
3016 were being counted with int, which may truncate counts on 64-bit
3017 machines, or EMACS_INT, which may be unnecessarily wide.
3018 * lisp.h (struct Lisp_Subr.function.aMANY)
3019 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3020 Arg counts are now ptrdiff_t, not size_t.
3021 All variadic functions and their callers changed accordingly.
3022 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3023 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3024 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3025 * callint.c (Fcall_interactively): Check arg count for overflow,
3026 to avoid potential buffer overrun. Use signed char, not 'int',
3027 for 'varies' array, so that we needn't bother to check its size
3028 calculation for overflow.
3029 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3030 * eval.c (apply_lambda):
3031 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3032 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3033 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3034
3035 * callint.c (Fcall_interactively): Don't use index var as event count.
3036
3037 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3038 * mem-limits.h (SIZE): Remove; no longer used.
3039
3040 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3041
3042 Remove unnecessary casts.
3043 * xterm.c (x_term_init):
3044 * xfns.c (x_set_border_pixel):
3045 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3046 These aren't needed now that we assume ANSI C.
3047
3048 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3049 It's more likely to cause problems (due to unsigned overflow)
3050 than to cure them.
3051
3052 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3053
3054 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3055
3056 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3057
3058 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3059
3060 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3061
3062 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3063
3064 GLYPH_CODE_FACE returns EMACS_INT, not int.
3065 * dispextern.h (merge_faces):
3066 * xfaces.c (merge_faces):
3067 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3068 Don't assume EMACS_INT fits in int.
3069
3070 * character.h (CHAR_VALID_P): Remove unused parameter.
3071 * fontset.c, lisp.h, xdisp.c: All uses changed.
3072
3073 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3074
3075 * fns.c (concat): Minor tuning based on overflow analysis.
3076 This doesn't fix any bugs. Use int to hold character, instead
3077 of constantly refetching from Emacs object. Use XFASTINT, not
3078 XINT, for value known to be a character. Don't bother comparing
3079 a single byte to 0400, as it's always less.
3080
3081 * floatfns.c (Fexpt):
3082 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3083
3084 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3085 for characters.
3086
3087 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3088
3089 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3090 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3091 incorrectly succeed when S was a string, because 4294967386 was
3092 truncated before it was used.
3093
3094 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3095 Otherwise, an out-of-range integer could cause undefined behavior
3096 on a 64-bit host.
3097
3098 * composite.c: Use int, not EMACS_INT, for characters.
3099 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3100 EMACS_INT, for values that are known to be in character range.
3101 This doesn't fix any bugs but is the usual style inside Emacs and
3102 may generate better code on 32-bit machines.
3103
3104 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3105 This is for reasons similar to the recent CHAR_STRING fix.
3106 * charset.c (Fencode_char): Check that character arg is actually
3107 a character. Pass an int to ENCODE_CHAR.
3108 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3109 wider than 'int', as a compile-time check to prevent future regressions
3110 in this area.
3111
3112 * character.c (char_string): Remove unnecessary casts.
3113
3114 Make sure a 64-bit char is never passed to CHAR_STRING.
3115 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3116 by silently ignoring the top 32 bits, allowing some values
3117 that were far too large to be valid characters.
3118 * character.h: Include <verify.h>.
3119 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3120 arguments are no wider than unsigned, as a compile-time check
3121 to prevent future regressions in this area.
3122 * data.c (Faset):
3123 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3124 (Fsubst_char_in_region):
3125 * fns.c (concat):
3126 * xdisp.c (decode_mode_spec_coding):
3127 Adjust to CHAR_STRING's new requirement.
3128 * editfns.c (Finsert_char, Fsubst_char_in_region):
3129 * fns.c (concat): Check that character args are actually
3130 characters. Without this test, these functions did the wrong
3131 thing with wildly out-of-range values on 64-bit hosts.
3132
3133 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3134 These casts should not be needed on 32-bit hosts, either.
3135 * keyboard.c (read_char):
3136 * lread.c (Fload): Remove casts to unsigned.
3137
3138 * lisp.h (UNSIGNED_CMP): New macro.
3139 This fixes comparison bugs on 64-bit hosts.
3140 (ASCII_CHAR_P): Use it.
3141 * casefiddle.c (casify_object):
3142 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3143 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3144 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3145 * dispextern.h (FACE_FROM_ID):
3146 * keyboard.c (read_char): Use UNSIGNED_CMP.
3147
3148 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3149 not to EMACS_INT, to avoid GCC warning.
3150
3151 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3152
3153 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3154 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3155 isn't needed on 32-bit machines.
3156
3157 * buffer.c (Fgenerate_new_buffer_name):
3158 Use EMACS_INT for count, not int.
3159 (advance_to_char_boundary): Return EMACS_INT, not int.
3160
3161 * data.c (Qcompiled_function): Now static.
3162
3163 * window.c (window_body_lines): Now static.
3164
3165 * image.c (gif_load): Rename local to avoid shadowing.
3166
3167 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3168 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3169 * alloc.c (make_save_value): Integer argument is now of type
3170 ptrdiff_t, not int.
3171 (mark_object): Use ptrdiff_t, not int.
3172 * lisp.h (pD): New macro.
3173 * print.c (print_object): Use it.
3174
3175 * alloc.c: Use EMACS_INT, not int, to count objects.
3176 (total_conses, total_markers, total_symbols, total_vector_size)
3177 (total_free_conses, total_free_markers, total_free_symbols)
3178 (total_free_floats, total_floats, total_free_intervals)
3179 (total_intervals, total_strings, total_free_strings):
3180 Now EMACS_INT, not int. All uses changed.
3181 (Fgarbage_collect): Compute overall total using a double, so that
3182 integer overflow is less likely to be a problem. Check for overflow
3183 when converting back to an integer.
3184 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3185 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3186 These were 'int' variables that could overflow on 64-bit hosts;
3187 they were never used, so remove them instead of repairing them.
3188 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3189 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3190 Previously, this ceilinged at INT_MAX, but that doesn't work on
3191 64-bit machines.
3192 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3193
3194 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3195 (allocate_vectorlike): Check for ptrdiff_t overflow.
3196 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3197 when a (possibly-narrower) signed value would do just as well.
3198 We prefer using signed arithmetic, to avoid comparison confusion.
3199
3200 * alloc.c: Catch some string size overflows that we were missing.
3201 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3202 for convenience in STRING_BYTES_MAX.
3203 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3204 The definition here is exact; the one in lisp.h was approximate.
3205 (allocate_string_data): Check for string overflow. This catches
3206 some instances we weren't catching before. Also, it catches
3207 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3208 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3209 and ptrdiff_t and EMACS_INT are both 64 bits.
3210
3211 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3212 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3213 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3214
3215 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3216
3217 * alloc.c (Fmake_string): Check for out-of-range init.
3218
3219 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3220
3221 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3222
3223 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3224
3225 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3226 xg_get_default_scrollbar_width.
3227
3228 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3229 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3230 (style_changed_cb): Call update_theme_scrollbar_width and call
3231 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3232 all frames (Bug#8505).
3233 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3234 Call gtk_window_set_resizable if HAVE_GTK3.
3235 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3236 and height if HAVE_GTK3 (Bug#8505).
3237 (scroll_bar_width_for_theme): New variable.
3238 (update_theme_scrollbar_width): New function.
3239 (xg_get_default_scrollbar_width): Move code to
3240 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3241 (xg_initialize): Call update_theme_scrollbar_width.
3242
3243 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3244
3245 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3246
3247 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3248
3249 * frame.c (make_frame): Call other_buffer_safely instead of
3250 other_buffer.
3251
3252 * window.c (temp_output_buffer_show): Call display_buffer with
3253 second argument Vtemp_buffer_show_specifiers and reset latter
3254 immediately after the call.
3255 (Vtemp_buffer_show_specifiers): New variable.
3256 (auto_window_vscroll_p, next_screen_context_lines)
3257 (Vscroll_preserve_screen_position): Remove leading asterisks from
3258 doc-strings.
3259
3260 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3261
3262 Fix minor problems found by GCC 4.6.0 static checking.
3263 * buffer.c (Qclone_number): Remove for now, as it's unused.
3264 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3265 (record_buffer): Remove unused local.
3266 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3267 (set_frame_buffer_list): Remove; unused.
3268 * frame.h (other_visible_frames): Remove decl.
3269 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3270 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3271 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3272 if HAVE_GPM.
3273 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3274 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3275 Define only if HAVE_GPM.
3276 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3277 (update_hints_inhibit): Remove; never set. All uses removed.
3278 * widgetprv.h (emacsFrameClassRec): Remove decl.
3279 * window.c (delete_deletable_window): Now returns void, since it
3280 wasn't returning anything.
3281 (compare_window_configurations): Remove unused locals.
3282 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3283 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3284 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3285 the same widths as pointers. This follows up on the 2011-05-06 patch.
3286 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3287 * xterm.h: Likewise.
3288 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3289
3290 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3291
3292 * makefile.w32-in: Update dependencies.
3293 (LISP_H): Add lib/intprops.h.
3294
3295 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3296
3297 * image.c (gif_load): Add animation frame delay to the metadata.
3298 (syms_of_image): Use DEFSYM. New symbol `delay'.
3299
3300 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3301
3302 * window.c (delete_deletable_window): Re-add.
3303 (Fset_window_configuration): Rewrite to handle dead buffers and
3304 consequently deletable windows.
3305 (window_tree, Fwindow_tree): Remove. Supply functionality in
3306 window.el.
3307 (compare_window_configurations): Simplify code.
3308
3309 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3310
3311 * image.c (imagemagick_load_image): Fix type mismatch.
3312 (Fimagemagick_types): Likewise.
3313
3314 * window.h (replace_buffer_in_windows): Declare.
3315
3316 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3317
3318 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3319 Qclone_number. Remove external declaration of Qdelete_window.
3320 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3321 code.
3322 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3323 Run Qbuffer_list_update_hook if allowed.
3324 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3325 buffer list implementation.
3326 (other_buffer_safely): New function.
3327 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3328 calls to replace_buffer_in_windows and
3329 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3330 if allowed.
3331 (record_buffer): Inhibit quitting and rewrite using quittable
3332 functions. Run Qbuffer_list_update_hook if allowed.
3333 (Frecord_buffer, Funrecord_buffer): New functions.
3334 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3335 Move switch-to-buffer to window.el.
3336 (bury-buffer): Move to window.el.
3337 (Vbuffer_list_update_hook): New variable.
3338
3339 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3340 section.
3341
3342 * window.h (resize_frame_windows): Move up in code.
3343 (Fwindow_frame): Remove EXFUN.
3344 (replace_buffer_in_all_windows): Remove prototype.
3345 (replace_buffer_in_windows_safely): Add prototype.
3346
3347 * window.c: Declare Qdelete_window static again. Move down
3348 declaration of select_count.
3349 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3350 (Fother_window): Move to window.el.
3351 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3352 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3353 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3354 window.el.
3355 (replace_buffer_in_windows): Implement by calling
3356 Qreplace_buffer_in_windows.
3357 (replace_buffer_in_all_windows): Remove with some functionality
3358 moved into replace_buffer_in_windows_safely.
3359 (replace_buffer_in_windows_safely): New function.
3360 (select_window_norecord, select_frame_norecord): Move in front
3361 of run_window_configuration_change_hook. Remove now obsolete
3362 declarations.
3363 (Fset_window_buffer): Rewrite doc-string.
3364 Call Qrecord_window_buffer.
3365 (keys_of_window): Move binding for other-window to window.el.
3366
3367 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3368
3369 * dispextern.h (struct image): Replace data member, whose int_val
3370 and ptr_val fields were not used by anything, with a single
3371 lisp_val object.
3372
3373 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3374 (gif_clear_image, gif_load, imagemagick_load_image)
3375 (gs_clear_image, gs_load): Callers changed.
3376
3377 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3378
3379 * buffer.h: Include <time.h>, for time_t.
3380 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3381
3382 Fix minor problems found by static checking.
3383
3384 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3385
3386 Make identifiers static if they are not used in other modules.
3387 * data.c (Qcompiled_function, Qframe, Qvector):
3388 * image.c (QimageMagick, Qsvg):
3389 * minibuf.c (Qmetadata):
3390 * window.c (resize_window_check, resize_root_window): Now static.
3391 * window.h (resize_window_check, resize_root_window): Remove decls.
3392
3393 * window.c (window_deletion_count, delete_deletable_window):
3394 Remove; unused.
3395 (window_body_lines): Now static.
3396 (Fdelete_other_windows_internal): Mark vars as initialized.
3397 Make sure 'resize_failed' is initialized.
3398 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3399 (resize_window_apply): Remove unused local.
3400 * window.h (delete_deletable_window): Remove decl.
3401
3402 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3403 (imagemagick_load_image): Fix pointer signedness problem by changing
3404 last arg from unsigned char * to char *. All uses changed.
3405 Also, fix a local for similar reasons.
3406 Remove unused locals. Remove locals to avoid shadowing.
3407 (fn_rsvg_handle_free): Remove; unused.
3408 (svg_load, svg_load_image): Fix pointer signedness problem.
3409 (imagemagick_load_image): Don't use garbage pointer image_wand.
3410
3411 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3412
3413 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3414
3415 * image.c (gif_load): Fix omitted cast error introduced by
3416 2011-06-06 change.
3417
3418 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3419
3420 * window.h (resize_proportionally, orig_total_lines)
3421 (orig_top_line): Remove from window structure.
3422 (set_window_height, set_window_width, change_window_heights)
3423 (Fdelete_window): Remove prototypes.
3424 (resize_frame_windows): Remove duplicate declaration.
3425
3426 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3427
3428 * window.h (resize_frame_windows, resize_window_check)
3429 (delete_deletable_window, resize_root_window)
3430 (resize_frame_windows): Declare prototypes.
3431
3432 * window.c (resize_window_apply): Make definition be "static" to
3433 match the prototype.
3434
3435 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3436
3437 * window.c: Remove declarations of Qwindow_size_fixed,
3438 window_min_size_1, window_min_size_2, window_min_size,
3439 size_window, window_fixed_size_p, enlarge_window, delete_window.
3440 Remove static from declaration of Qdelete_window, it's
3441 temporarily needed by Fbury_buffer.
3442 (replace_window): Don't assign orig_top_line and
3443 orig_total_lines.
3444 (Fdelete_window, delete_window): Remove. Window deletion is
3445 handled by window.el.
3446 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3447 Replace Fdelete_window calls with calls to Qdelete_window.
3448 (Fdelete_other_windows): Remove. Deleting other windows is
3449 handled by window.el.
3450 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3451 handled in window.el.
3452 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3453 Window minimum sizes are handled in window.el.
3454 (shrink_windows, size_window, set_window_height)
3455 (set_window_width, change_window_heights, window_height)
3456 (window_width, CURBEG, CURSIZE, enlarge_window)
3457 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3458 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3459 handled in window.el.
3460 (make_dummy_parent): Rename to make_parent_window and give it a
3461 second argument horflag.
3462 (make_window): Don't set resize_proportionally any more.
3463 (Fsplit_window): Remove. Windows are split in window.el.
3464 (save_restore_action, save_restore_orig_size)
3465 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3466 Resize mini windows in window.el.
3467 (grow_mini_window, shrink_mini_window): Implement by calling
3468 Qresize_root_window_vertically, resize_window_check and
3469 resize_window_apply.
3470 (saved_window, Fset_window_configuration, save_window_save):
3471 Do not handle orig_top_line, orig_total_lines, and
3472 resize_proportionally.
3473 (window_min_height, window_min_width): Move to window.el.
3474 (keys_of_window): Move bindings for delete-other-windows,
3475 split-window, delete-window and enlarge-window to window.el.
3476
3477 * buffer.c: Temporarily extern Qdelete_window.
3478 (Fbury_buffer): Temporarily call Qdelete_window instead of
3479 Fdelete_window (Fbury_buffer will move to window.el soon).
3480
3481 * frame.c (set_menu_bar_lines_1): Remove code handling
3482 orig_top_line and orig_total_lines.
3483
3484 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3485 set_window_height but set heights directly.
3486 (change_frame_size_1): Use resize_frame_windows.
3487
3488 * xdisp.c (init_xdisp): Don't use set_window_height but set
3489 heights directly.
3490
3491 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3492 Use resize_frame_windows instead of change_window_heights and run
3493 run_window_configuration_change_hook.
3494
3495 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3496 instead of change_window_heights and run
3497 run_window_configuration_change_hook.
3498
3499 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3500
3501 * window.c (replace_window): Rename second argument REPLACEMENT to
3502 NEW. New third argument SETFLAG. Rewrite.
3503 (delete_window, make_dummy_parent): Call replace_window with
3504 third argument 1.
3505 (window_list_1): Move down in code.
3506 (run_window_configuration_change_hook): Move set_buffer part
3507 before select_frame_norecord part in order to unwind correctly.
3508 Rename count1 to count.
3509 (recombine_windows, delete_deletable_window, resize_root_window)
3510 (Fdelete_other_windows_internal)
3511 (Frun_window_configuration_change_hook, make_parent_window)
3512 (resize_window_check, resize_window_apply, Fresize_window_apply)
3513 (resize_frame_windows, Fsplit_window_internal)
3514 (Fdelete_window_internal, Fresize_mini_window_internal):
3515 New functions.
3516 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3517
3518 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3519
3520 * window.h (window): Add some new members to window structure -
3521 normal_lines, normal_cols, new_total, new_normal, clone_number,
3522 splits, nest, prev_buffers, next_buffers.
3523 (WINDOW_TOTAL_SIZE): Move here from window.c.
3524 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3525
3526 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3527 Remove.
3528 (make_dummy_parent): Set new members of windows structure.
3529 (make_window): Move down in code. Handle new members of window
3530 structure.
3531 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3532 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3533 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3534 (Fset_window_prev_buffers, Fwindow_next_buffers)
3535 (Fset_window_next_buffers, Fset_window_clone_number):
3536 New functions.
3537 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3538 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3539 Doc-string fixes.
3540 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3541 Argument WINDOW can be now internal window too.
3542 (Fwindow_use_time): Move up in code.
3543 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3544 Rewrite doc-string.
3545 (Fset_window_configuration, saved_window)
3546 (Fcurrent_window_configuration, save_window_save): Handle new
3547 members of window structure.
3548 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3549 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3550 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3551 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3552 Qget_mru_window, Qresize_root_window,
3553 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3554 Qauto_buffer_name; staticpro them.
3555
3556 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3557
3558 * window.c (Fwindow_total_size, Fwindow_left_column)
3559 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3560 (Fwindow_list_1): New functions.
3561 (window_box_text_cols): Replace with window_body_cols.
3562 (Fwindow_width, Fscroll_left, Fscroll_right):
3563 Use window_body_cols instead of window_box_text_cols.
3564 (delete_window, Fset_window_configuration):
3565 Call delete_all_subwindows with window as argument.
3566 (delete_all_subwindows): Take a window as argument and not a
3567 structure. Rewrite.
3568 (window_loop): Remove handling of GET_LRU_WINDOW and
3569 GET_LARGEST_WINDOW.
3570 (Fget_lru_window, Fget_largest_window): Move to window.el.
3571
3572 * window.h: Extern window_body_cols instead of
3573 window_box_text_cols. delete_all_subwindows now takes a
3574 Lisp_Object as argument.
3575
3576 * indent.c (compute_motion, Fcompute_motion):
3577 Use window_body_cols instead of window_box_text_cols.
3578
3579 * frame.c (delete_frame): Call delete_all_subwindows with root
3580 window as argument.
3581
3582 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3583
3584 * fns.c (Fputhash): Document return value.
3585
3586 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3587
3588 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3589
3590 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3591
3592 Cons<->int and similar integer overflow fixes (Bug#8794).
3593
3594 Check for overflow when converting integer to cons and back.
3595 * charset.c (Fdefine_charset_internal, Fdecode_char):
3596 Use cons_to_unsigned to catch overflow.
3597 (Fencode_char): Use INTEGER_TO_CONS.
3598 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3599 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3600 * data.c (long_to_cons, cons_to_long): Remove.
3601 (cons_to_unsigned, cons_to_signed): New functions.
3602 These signal an error for invalid or out-of-range values.
3603 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3604 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3605 * font.c (Ffont_variation_glyphs):
3606 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3607 * lisp.h: Include <intprops.h>.
3608 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3609 (cons_to_signed, cons_to_unsigned): New decls.
3610 (long_to_cons, cons_to_long): Remove decls.
3611 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3612 (Fprimitive_undo): Use CONS_TO_INTEGER.
3613 * xfns.c (Fx_window_property): Likewise.
3614 * xselect.c: Include <limits.h>.
3615 (x_own_selection, selection_data_to_lisp_data):
3616 Use INTEGER_TO_CONS.
3617 (x_handle_selection_request, x_handle_selection_clear)
3618 (x_get_foreign_selection, Fx_disown_selection_internal)
3619 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3620 (lisp_data_to_selection_data): Use cons_to_unsigned.
3621 (x_fill_property_data): Use cons_to_signed.
3622 Report values out of range.
3623
3624 Check for buffer and string overflow more precisely.
3625 * buffer.h (BUF_BYTES_MAX): New macro.
3626 * lisp.h (STRING_BYTES_MAX): New macro.
3627 * alloc.c (Fmake_string):
3628 * character.c (string_escape_byte8):
3629 * coding.c (coding_alloc_by_realloc):
3630 * doprnt.c (doprnt):
3631 * editfns.c (Fformat):
3632 * eval.c (verror):
3633 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3634 since they may not be the same number.
3635 * editfns.c (Finsert_char):
3636 * fileio.c (Finsert_file_contents):
3637 Likewise for BUF_BYTES_MAX.
3638
3639 * image.c: Use ptrdiff_t, not int, for sizes.
3640 (slurp_file): Switch from int to ptrdiff_t.
3641 All uses changed.
3642 (slurp_file): Check that file size fits in both size_t (for
3643 malloc) and ptrdiff_t (for sanity and safety).
3644
3645 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3646 if b->modtime has its maximal value.
3647
3648 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3649
3650 Don't assume time_t can fit into int.
3651 * buffer.h (struct buffer.modtime): Now time_t, not int.
3652 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3653 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3654
3655 Minor fixes for signed vs unsigned integers.
3656 * character.h (MAYBE_UNIFY_CHAR):
3657 * charset.c (maybe_unify_char):
3658 * keyboard.c (read_char, reorder_modifiers):
3659 XINT -> XFASTINT, since the integer must be nonnegative.
3660 * ftfont.c (ftfont_spec_pattern):
3661 * keymap.c (access_keymap, silly_event_symbol_error):
3662 XUINT -> XFASTINT, since the integer must be nonnegative.
3663 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3664 since it makes no difference and we prefer signed.
3665 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3666 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3667 nonnegative.
3668
3669 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3670
3671 * window.h (Fwindow_frame): Declare.
3672
3673 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3674
3675 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3676 (SPARE_MEMORY): Always define.
3677 (LARGE_REQUEST): Remove.
3678 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3679
3680 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3681
3682 * lisp.h: Move EXFUNS for Fframe_root_window,
3683 Fframe_first_window and Fset_frame_selected_window to window.h.
3684
3685 * window.h: Move EXFUNS for Fframe_root_window,
3686 Fframe_first_window and Fset_frame_selected_window here from
3687 lisp.h.
3688
3689 * frame.c (Fwindow_frame, Fframe_first_window)
3690 (Fframe_root_window, Fframe_selected_window)
3691 (Fset_frame_selected_window): Move to window.c.
3692 (Factive_minibuffer_window): Move to minibuf.c.
3693 (Fother_visible_frames_p): New function.
3694
3695 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3696
3697 * window.c (decode_window, decode_any_window): Move up in code.
3698 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3699 (inhibit_frame_unsplittable): Remove unused variable.
3700 (Fwindow_buffer): Move up and rewrite doc-string.
3701 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3702 (Fwindow_prev): New functions.
3703 (Fwindow_frame): Move here from frame.c. Accept any window as
3704 argument.
3705 (Fframe_root_window, Fframe_first_window)
3706 (Fframe_selected_window): Move here from frame.c. Accept frame
3707 or arbitrary window as argument. Update doc-strings.
3708 (Fminibuffer_window): Move up in code.
3709 (Fwindow_minibuffer_p): Move up in code and simplify.
3710 (Fset_frame_selected_window): Move here from frame.c.
3711 Marginal rewrite.
3712 (Fselected_window, select_window, Fselect_window): Move up in
3713 code. Minor doc-string fixes.
3714
3715 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3716
3717 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3718 Do not assume that spare memory exists; that assumption is valid
3719 only if SYSTEM_MALLOC.
3720 (LARGE_REQUEST): New macro, so that the issue of large requests
3721 is separated from the issue of spare memory.
3722
3723 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3724
3725 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3726 format. (Bug#8806)
3727
3728 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3729
3730 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3731 before statements.
3732
3733 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3734
3735 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3736
3737 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3738
3739 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3740 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3741
3742 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3743
3744 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3745
3746 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3747
3748 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3749 (x_clipboard_manager_save): Add return value.
3750 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3751 New error handlers.
3752 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3753 Obey Vx_select_enable_clipboard_manager. Catch errors in
3754 x_clipboard_manager_save (Bug#8779).
3755 (Vx_select_enable_clipboard_manager): New variable.
3756 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3757
3758 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3759
3760 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3761
3762 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3763
3764 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3765 in the current matrix if keep_current_p is non-zero.
3766
3767 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3768
3769 * bidi.c (bidi_level_of_next_char): Fix last change.
3770
3771 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3772
3773 Support bidi reordering of text covered by display properties.
3774
3775 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3776 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3777 (bidi_cache_search, bidi_cache_iterator_state)
3778 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3779 (bidi_level_of_next_char, bidi_move_to_visually_next):
3780 Support character positions inside a run of characters covered by a
3781 display string.
3782 (bidi_paragraph_init, bidi_resolve_explicit_1)
3783 (bidi_level_of_next_char): Call bidi_fetch_char and
3784 bidi_fetch_char_advance instead of FETCH_CHAR and
3785 FETCH_CHAR_ADVANCE.
3786 (bidi_init_it): Initialize new members.
3787 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3788 definitions.
3789 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3790 instead of using explicit *_CHAR codes.
3791 (bidi_resolve_explicit, bidi_resolve_weak):
3792 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3793 bidirectional text is supported only in multibyte buffers.
3794 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3795 it to initialize the frame_window_p member of struct bidi_it.
3796 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3797 (bidi_resolve_explicit, bidi_resolve_weak)
3798 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3799 bidi_it->nchars is non-positive.
3800 (bidi_level_of_next_char): Don't try to lookup the cache for the
3801 next/previous character if nothing is cached there yet, or if we
3802 were just reseat()'ed to a new position.
3803
3804 * xdisp.c (set_cursor_from_row): Set start and stop points
3805 according to the row's direction when priming the loop that looks
3806 for the glyph on which to display cursor.
3807 (single_display_spec_intangible_p): Function deleted.
3808 (display_prop_intangible_p): Reimplement to call
3809 handle_display_spec instead of single_display_spec_intangible_p.
3810 Accept 3 additional arguments needed by handle_display_spec.
3811 This fixes incorrect cursor motion across display property with complex
3812 values: lists, `(when COND...)' forms, etc.
3813 (single_display_spec_string_p): Support property values that are
3814 lists with the argument STRING its top-level element.
3815 (display_prop_string_p): Fix the condition for processing a
3816 property that is a list to be consistent with handle_display_spec.
3817 (handle_display_spec): New function, refactored from the
3818 last portion of handle_display_prop.
3819 (compute_display_string_pos): Accept additional argument
3820 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3821 value of a `display' property is a "replacing spec".
3822 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3823 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3824 the display property, but just return a value indicating whether
3825 the display property will replace the characters it covers.
3826 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3827 frame_window_p members of struct bidi_it.
3828 (compute_display_string_pos, compute_display_string_end):
3829 New functions.
3830 (push_it): Accept second argument POSITION, where pop_it should
3831 jump to continue iteration.
3832 (reseat_1): Initialize bidi_it.disp_pos.
3833
3834 * keyboard.c (adjust_point_for_property): Adjust the call to
3835 display_prop_intangible_p to its new signature.
3836
3837 * dispextern.h (struct bidi_it): New member frame_window_p.
3838 (bidi_init_it): Update prototypes.
3839 (display_prop_intangible_p): Update prototype.
3840 (compute_display_string_pos, compute_display_string_end):
3841 Declare prototypes.
3842 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3843 EMACS_INT.
3844
3845 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3846
3847 Malloc failure behavior now depends on size of allocation.
3848 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3849 * lisp.h: Change signatures accordingly.
3850 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3851 All callers changed. (Bug#8762)
3852
3853 * gnutls.c: Use Emacs's memory allocators.
3854 Without this change, the gnutls library would invoke malloc etc.
3855 directly, which causes problems on non-SYNC_INPUT hosts, and which
3856 runs afoul of improving memory_full behavior. (Bug#8761)
3857 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3858 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3859 xfree instead of the default malloc, realloc, free.
3860 (Fgnutls_boot): No need to check for memory allocation failure,
3861 since xmalloc does that for us.
3862
3863 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3864 * category.c (hash_get_category_set):
3865 * ccl.c (ccl_driver):
3866 * charset.c (Fdefine_charset_internal):
3867 * charset.h (struct charset.hash_index):
3868 * composite.c (get_composition_id, gstring_lookup_cache)
3869 (composition_gstring_put_cache):
3870 * composite.h (struct composition.hash_index):
3871 * dispextern.h (struct image.hash):
3872 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3873 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3874 (hashfn_equal, hashfn_user_defined, make_hash_table)
3875 (maybe_resize_hash_table, hash_lookup, hash_put)
3876 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3877 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3878 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3879 * image.c (make_image, search_image_cache, lookup_image)
3880 (xpm_put_color_table_h):
3881 * lisp.h (struct Lisp_Hash_Table):
3882 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3883 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3884 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3885 * alloc.c (allocate_vectorlike):
3886 Check for overflow in vector size calculations.
3887 * ccl.c (ccl_driver):
3888 Check for overflow when converting EMACS_INT to int.
3889 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3890 need to be updated by these changes.
3891 * fns.c (make_hash_table, maybe_resize_hash_table):
3892 Check for integer overflow with large hash tables.
3893 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3894 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3895 (SXHASH_REDUCE): New macro.
3896 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3897 Use it instead of discarding useful hash info with large hash values.
3898 (sxhash_float): New function.
3899 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3900 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3901 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3902 Rewrite to use FIXNUM_BITS, as this simplifies things.
3903 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3904 Adjust signatures to match updated version of code.
3905 (consing_since_gc): Now EMACS_INT, since a single hash table can
3906 use more than INT_MAX bytes.
3907
3908 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3909
3910 Make it possible to build with GCC-4.6+ -O2 -flto.
3911
3912 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3913
3914 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3915
3916 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3917 Call minibuffer-inactive-mode.
3918
3919 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3920
3921 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3922 Update dependencies.
3923
3924 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3925
3926 * data.c (init_data): Remove code for UTS, this system is not
3927 supported anymore.
3928
3929 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3930
3931 Don't force ./temacs to start in terminal mode.
3932
3933 * frame.c (make_initial_frame): Initialize faces in all cases, not
3934 only when CANNOT_DUMP is defined.
3935 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3936
3937 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3938
3939 * dispnew.c (add_window_display_history): Use const for the string
3940 pointer. Remove declaration, not needed.
3941
3942 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3943
3944 Use 'inline', not 'INLINE'.
3945 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3946 * alloc.c, fontset.c (INLINE): Remove.
3947 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3948 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3949 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3950 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3951 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3952
3953 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3954
3955 Make it possible to run ./temacs.
3956
3957 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3958 syms_of_callproc does the same thing. Remove test for
3959 "initialized", do it in the caller.
3960 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3961
3962 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3963
3964 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3965 (read_minibuf): Use get_minibuffer.
3966 (syms_of_minibuf): Use DEFSYM.
3967 (Qmetadata): New var.
3968 * data.c (Qbuffer): Don't make it static.
3969 (syms_of_data): Use DEFSYM.
3970
3971 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3972
3973 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3974 (CCL_CODE_MIN): New macro.
3975
3976 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3977
3978 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3979
3980 * eval.c (Qdebug): Now static.
3981 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3982 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3983 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3984
3985 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3986
3987 * image.c: Various fixes to ImageMagick code comments.
3988 (Fimagemagick_types): Doc fix.
3989
3990 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3991
3992 Minor fixes prompted by GCC 4.6.0 warnings.
3993
3994 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3995
3996 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3997 (x_clipboard_manager_save_all): Move extern decl to ...
3998 * xterm.h: ... here, so that it can be checked for consistency.
3999
4000 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4001
4002 * xselect.c (x_clipboard_manager_save_frame)
4003 (x_clipboard_manager_save_all): New functions.
4004 (Fx_clipboard_manager_save): Lisp function deleted.
4005
4006 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4007 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4008
4009 * xterm.h: Update prototype.
4010
4011 2011-05-28 William Xu <william.xwl@gmail.com>
4012
4013 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4014 exiting (Bug#8239).
4015
4016 2011-05-28 Jim Meyering <meyering@redhat.com>
4017
4018 Avoid a sign-extension bug in crypto_hash_function.
4019 * fns.c (to_uchar): Define.
4020 (crypto_hash_function): Use it to convert some newly-signed
4021 variables to unsigned, to avoid sign-extension bugs. For example,
4022 without this change, (md5 "truc") would evaluate to
4023 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4024 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4025 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4026
4027 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4028
4029 Integer overflow fixes.
4030
4031 * dbusbind.c: Serial number integer overflow fixes.
4032 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4033 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4034 to hold a serial number that is too large for a fixnum.
4035 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4036 Check for serial numbers out of range. Decode any serial number
4037 that was so large that it became a float. (Bug#8722)
4038
4039 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4040 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4041 Use XFASTINT rather than XUINT when numbers are nonnegative.
4042 (xd_append_arg, Fdbus_method_return_internal):
4043 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4044 arguments, check that Lisp number is nonnegative, rather than
4045 silently wrapping negative numbers around. (Bug#8722)
4046 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4047 (Bug#8722)
4048
4049 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4050
4051 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4052
4053 ccl: add integer overflow checks
4054 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4055 (IN_INT_RANGE): New macros.
4056 (ccl_driver): Use them to check for integer overflow when
4057 decoding a CCL program. Many of the new checks are whether XINT (x)
4058 fits in int; it doesn't always, on 64-bit hosts. The new version
4059 doesn't catch all possible integer overflows, but it's an
4060 improvement. (Bug#8719)
4061
4062 * alloc.c (make_event_array): Use XINT, not XUINT.
4063 There's no need for unsigned here.
4064
4065 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4066 This follows up to the 2011-05-06 change that substituted uintptr_t
4067 for EMACS_INT. This case wasn't caught back then.
4068
4069 Rework Fformat to avoid integer overflow issues.
4070 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4071 now (part of C89). Include <verify.h>.
4072 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4073 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4074 (Fformat): Avoid the prepass trying to compute sizes; it was only
4075 approximate and thus did not catch overflow reliably. Instead, walk
4076 through the format just once, formatting and computing sizes as we go,
4077 checking for integer overflow at every step, and allocating a larger
4078 buffer as needed. Keep track separately whether the format is
4079 multibyte. Keep only the most-recently calculated precision, rather
4080 than them all. Record whether each argument has been converted to
4081 string. Use EMACS_INT, not int, for byte and char and arg counts.
4082 Support field widths and precisions larger than INT_MAX. Avoid
4083 sprintf's undefined behavior with conversion specifications such as %#d
4084 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4085 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4086 formatting out-of-range floating point numbers with int
4087 formats. (Bug#8668)
4088
4089 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4090
4091 * data.c: Avoid integer truncation in expressions involving floats.
4092 * data.c: Include <intprops.h>.
4093 (arith_driver): When there's an integer overflow in an expression
4094 involving floating point, convert the integers to floating point
4095 so that the resulting value does not suffer from catastrophic
4096 integer truncation. For example, on a 64-bit host (* 4
4097 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4098 Do not rely on undefined behavior after integer overflow.
4099
4100 merge count_size_as_multibyte, parse_str_to_multibyte
4101 * character.c, character.h (count_size_as_multibyte):
4102 Rename from parse_str_to_multibyte; all uses changed.
4103 Check for integer overflow.
4104 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4105 since it's now a duplicate of the other. This is more of
4106 a character than a buffer op, so better that it's in character.c.
4107 * fns.c, print.c: Adjust to above changes.
4108
4109 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4110
4111 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4112
4113 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4114
4115 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4116 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4117 (x_clipboard_manager_save): Now static.
4118 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4119
4120 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4121 (crypto_hash_function): Now static.
4122 Fix pointer signedness problems. Avoid unnecessary initializations.
4123
4124 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4125
4126 * termhooks.h (Vselection_alist): Make it terminal-local.
4127
4128 * terminal.c (create_terminal): Initialize it.
4129
4130 * xselect.c: Support for clipboard managers.
4131 (Vselection_alist): Move to termhooks.h as terminal-local var.
4132 (LOCAL_SELECTION): New macro.
4133 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4134 (symbol_to_x_atom): Remove gratuitous arg.
4135 (x_handle_selection_request, lisp_data_to_selection_data)
4136 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4137 (x_own_selection, x_get_local_selection, x_convert_selection):
4138 New arg, specifying work frame. Use terminal-local Vselection_alist.
4139 (some_frame_on_display): Delete unused function.
4140 (Fx_own_selection_internal, Fx_get_selection_internal)
4141 (Fx_disown_selection_internal, Fx_selection_owner_p)
4142 (Fx_selection_exists_p): New optional frame arg.
4143 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4144 (x_handle_selection_clear): Don't treat other terminals with the
4145 same keyboard specially. Use the terminal-local Vselection_alist.
4146 (x_clear_frame_selections): Use Frun_hook_with_args.
4147
4148 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4149
4150 * xterm.h: Add support for those atoms.
4151
4152 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4153
4154 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4155 (converted_selections, conversion_fail_tag): New global variables.
4156 (x_selection_request_lisp_error): Free the above.
4157 (x_get_local_selection): Remove unnecessary code.
4158 (x_reply_selection_request): Args changed; handle arbitrary array
4159 of converted selections stored in converted_selections.
4160 Separate the XChangeProperty and SelectionNotify steps.
4161 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4162 (x_convert_selection): New function.
4163 (x_handle_selection_event): Simplify.
4164 (x_get_foreign_selection): Don't ignore incoming requests while
4165 waiting for an answer; this will fail when we implement
4166 SAVE_TARGETS, and seems unnecessary anyway.
4167 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4168 (Vx_sent_selection_functions): Doc fix.
4169
4170 2011-05-26 Leo Liu <sdl.web@gmail.com>
4171
4172 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4173
4174 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4175
4176 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4177
4178 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4179 for fringe update if it has periodic bitmap.
4180 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4181 and fringe_bitmap_periodic_p.
4182
4183 * fringe.c (get_fringe_bitmap_data): New function.
4184 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4185 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4186 row. Mark glyph row for fringe update if periodicity changed.
4187
4188 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4189 for fringe update unless it has periodic bitmap.
4190
4191 2011-05-25 Kenichi Handa <handa@m17n.org>
4192
4193 * xdisp.c (get_next_display_element): Set correct it->face_id for
4194 a static composition.
4195
4196 2011-05-24 Leo Liu <sdl.web@gmail.com>
4197
4198 * deps.mk (fns.o):
4199 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4200
4201 * fns.c (crypto_hash_function, Fsha1): New function.
4202 (Fmd5): Use crypto_hash_function.
4203 (syms_of_fns): Add Ssha1.
4204
4205 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4206
4207 * gnutls.c: Remove unused macros.
4208 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4209 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4210 Remove macros that are defined and never used.
4211 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4212
4213 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4214
4215 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4216 (Fx_get_selection_internal): Minor cleanup.
4217 (Fx_own_selection_internal): Rename arguments for consistency with
4218 select.el.
4219
4220 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4221
4222 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4223
4224 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4225
4226 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4227
4228 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4229
4230 * dispnew.c (scrolling_window): Don't exclude the case that the
4231 last enabled row in the desired matrix touches the bottom boundary.
4232
4233 2011-05-21 Glenn Morris <rgm@gnu.org>
4234
4235 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4236 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4237 and add some more files.
4238
4239 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4240
4241 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4242 report_file_error introduced by the change from 2011-05-07.
4243
4244 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4245
4246 * systime.h (Time): Define only if emacs is defined.
4247 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4248 where the include path doesn't have X11/X.h by default. See
4249 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4250
4251 2011-05-20 Kenichi Handa <handa@m17n.org>
4252
4253 * composite.c (find_automatic_composition): Fix previous change.
4254
4255 2011-05-20 Glenn Morris <rgm@gnu.org>
4256
4257 * lisp.mk: New file, split from Makefile.in.
4258 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4259 (shortlisp): Remove.
4260 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4261
4262 2011-05-19 Glenn Morris <rgm@gnu.org>
4263
4264 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4265 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4266 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4267 (lisp): Set the order to that of loadup.el.
4268 (shortlisp): Make it a copy of $lisp.
4269 (SOME_MACHINE_LISP): Remove.
4270 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4271 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4272
4273 2011-05-18 Kenichi Handa <handa@m17n.org>
4274
4275 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4276 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4277 (find_automatic_composition): Mostly rewrite for efficiency.
4278
4279 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4280
4281 * makefile.w32-in: Update dependencies.
4282
4283 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4284
4285 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4286 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4287
4288 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4289
4290 Fix some integer overflow issues, such as string length overflow.
4291
4292 * insdel.c (count_size_as_multibyte): Check for string overflow.
4293
4294 * character.c (lisp_string_width): Check for string overflow.
4295 Use EMACS_INT, not int, for string indexes and lengths; in
4296 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4297 the resulting string length overflows an EMACS_INT; instead,
4298 report a string overflow if no precision given. When checking for
4299 precision exhaustion, use a check that cannot possibly have
4300 integer overflow. (Bug#8675)
4301 * character.h (lisp_string_width): Adjust to new signature.
4302
4303 * alloc.c (string_overflow): New function.
4304 (Fmake_string): Use it. This doesn't change behavior, but saves
4305 a few bytes and will simplify future changes.
4306 * character.c (string_escape_byte8): Likewise.
4307 * lisp.h (string_overflow): New decl.
4308
4309 Fixups, following up to the user-interface timestamp change.
4310 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4311 for UI timestamps, instead of unsigned long.
4312 * msdos.c (mouse_get_pos): Likewise.
4313 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4314 * w32gui.h (Time): Define by including "systime.h" rather than by
4315 declaring it ourselves. (Bug#8664)
4316
4317 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4318 * image.c (clear_image_cache): Likewise.
4319
4320 * term.c (term_mouse_position): Don't assume time_t wraparound.
4321
4322 Be more systematic about user-interface timestamps.
4323 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4324 and sometimes 'EMACS_UINT', to represent these timestamps.
4325 This change causes it to use 'Time' uniformly, as that's what X uses.
4326 This makes the code easier to follow, and makes it easier to catch
4327 integer overflow bugs such as Bug#8664.
4328 * frame.c (Fmouse_position, Fmouse_pixel_position):
4329 Use Time, not unsigned long, for user-interface timestamps.
4330 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4331 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4332 * keyboard.h (last_event_timestamp): Likewise.
4333 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4334 * menu.h (xmenu_show): Likewise.
4335 * term.c (term_mouse_position): Likewise.
4336 * termhooks.h (struct input_event.timestamp): Likewise.
4337 (struct terminal.mouse_position_hook): Likewise.
4338 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4339 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4340 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4341 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4342 what it was before.
4343 * menu.h, termhooks.h: Include "systime.h", for Time.
4344
4345 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4346 Don't assume that the difference between two unsigned long values
4347 can fit into an integer. At this point, we know button_down_time
4348 <= event->timestamp, so the difference must be nonnegative, so
4349 there's no need to cast the result if double-click-time is
4350 nonnegative, as it should be; check that it's nonnegative, just in
4351 case. This bug is triggered when events are more than 2**31 ms
4352 apart (about 25 days). (Bug#8664)
4353
4354 * xselect.c (last_event_timestamp): Remove duplicate decl.
4355 (x_own_selection): Remove needless cast to unsigned long.
4356
4357 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4358 that always fit in int. Use a sentinel instead of a counter, to
4359 avoid a temp and to allay GCC's concerns about possible int overflow.
4360 * frame.h (struct frame): Use int for menu_bar_items_used
4361 instead of EMACS_INT, since it always fits in int.
4362
4363 * menu.c (grow_menu_items): Check for int overflow.
4364
4365 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4366
4367 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4368 Before, the code was not consistent. These values cannot exceed
4369 2**31 - 1 so there's no need to make them unsigned.
4370 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4371 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4372 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4373 as modifiers.
4374 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4375
4376 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4377 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4378 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4379 presumably because the widths might not match.
4380
4381 * window.c (size_window): Avoid needless test at loop start.
4382
4383 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4384
4385 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4386
4387 2011-05-12 Drew Adams <drew.adams@oracle.com>
4388
4389 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4390
4391 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4392
4393 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4394 `width' to `bar_area_x' and `bar_area_width', respectively.
4395 (x_scroll_run): Take account of fringe background extension.
4396
4397 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4398 Rename local vars `left' and `width' to `bar_area_x' and
4399 `bar_area_width', respectively.
4400 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4401 background extension.
4402
4403 2011-05-10 Jim Meyering <meyering@redhat.com>
4404
4405 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4406
4407 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4408
4409 * image.c (Finit_image_library): Return t for built-in image types,
4410 like pbm and xbm. (Bug#8640)
4411
4412 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4413
4414 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4415
4416 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4417
4418 * w32console.c (Fset_screen_color): Doc fix.
4419 (Fget_screen_color): New function.
4420 (syms_of_ntterm): Defsubr it.
4421
4422 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4423 unlink the temporary file if Fcall_process didn't create it in the
4424 first place.
4425 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4426 child process will be redirected to a file specified with `:file'.
4427 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4428 cue to call_process_cleanup not to close that handle.
4429
4430 2011-05-07 Ben Key <bkey76@gmail.com>
4431
4432 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4433 one of two shell specific rules, either bootstrap-temacs-CMD or
4434 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4435 to the previous implementation of the bootstrap-temacs rule.
4436 The bootstrap-temacs-CMD rule is similar to the previous
4437 implementation of the bootstrap-temacs rule except that it
4438 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4439 variable.
4440
4441 These changes, along with some changes to nt/configure.bat,
4442 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4443 earlier fix to add support for --cflags and --ldflags options
4444 that include quotes so that it works whether make uses cmd or
4445 sh as the shell.
4446
4447 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4448
4449 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4450 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4451 is a constant.
4452 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4453 a string. Handle both cases.
4454 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4455 (Fdbus_register_method): Use Qinvalid_function.
4456
4457 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4458
4459 * makefile.w32-in: Update dependencies.
4460 (LISP_H): Add inttypes.h and stdin.h.
4461 (PROCESS_H): Add unistd.h.
4462
4463 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4464
4465 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4466 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4467
4468 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4469
4470 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4471
4472 * term.c (vfatal): Remove stray call to va_end.
4473 It's not needed and the C Standard doesn't allow it here anyway.
4474
4475 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4476 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4477
4478 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4479 bytes.
4480
4481 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4482
4483 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4484
4485 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4486
4487 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4488
4489 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4490
4491 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4492 * charset.c (Fdefine_charset_internal): Don't initialize
4493 charset.code_space[15]. The value was garbage, on hosts with
4494 32-bit int (Bug#8600).
4495
4496 * lread.c (read_integer): Be more consistent with string-to-number.
4497 Use string_to_number to do the actual conversion; this avoids
4498 rounding errors and fixes some other screwups. Without this fix,
4499 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4500 (digit_to_number): Move earlier, for benefit of read_integer.
4501 Return -1 if the digit is out of range for the base, -2 if it is
4502 not a digit in any supported base. (Bug#8602)
4503
4504 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4505
4506 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4507 to match comment at start of function. This also removes a
4508 GCC warning about overflow in a 32+64-bit port.
4509
4510 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4511
4512 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4513 Reported by Stefan Monnier in
4514 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4515 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4516 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4517
4518 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4519 (EMACS_UINTPTR): Likewise, with uintptr_t.
4520
4521 * lisp.h: Prefer 64-bit EMACS_INT if available.
4522 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4523 on 32-bit hosts that have 64-bit int, so that they can access
4524 large files.
4525 However, temporarily disable this change unless the temporary
4526 symbol WIDE_EMACS_INT is defined.
4527
4528 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4529
4530 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4531 This removes an assumption that EMACS_INT and long are the same
4532 width as pointers. The assumption is true for Emacs porting targets
4533 now, but we want to make other targets possible.
4534 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4535 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4536 In the rest of the code, change types of integers that hold casted
4537 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4538 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4539 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4540 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4541 No need to cast type when ORing.
4542 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4543 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4544 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4545 assume EMACS_INT is the same width as char *.
4546 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4547 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4548 Remove no-longer-needed casts.
4549 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4550 (xg_tool_bar_help_callback, xg_make_tool_item):
4551 Use EMACS_INTPTR to hold an integer
4552 that will be cast to void *; this can avoid a GCC warning
4553 if EMACS_INT is not the same width as void *.
4554 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4555 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4556 (current_message_1, set_message_1):
4557 Use a local to convert to proper width without a cast.
4558 * xmenu.c (dialog_selection_callback): Likewise.
4559
4560 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4561 Also, don't assume VALBITS / RAND_BITS is less than 5,
4562 and don't rely on undefined behavior when shifting a 1 left into
4563 the sign bit.
4564 * lisp.h (get_random): Change signature to match.
4565
4566 * lread.c (hash_string): Use size_t, not int, for hash computation.
4567 Normally we prefer signed values; but hashing is special, because
4568 it's better to use unsigned division on hash table sizes so that
4569 the remainder is nonnegative. Also, size_t is the natural width
4570 for hashing into memory. The previous code used 'int', which doesn't
4571 retain enough info to hash well into very large tables.
4572 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4573
4574 * dbusbind.c: Don't possibly lose pointer info when converting.
4575 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4576 Use XPNTR rather than XHASH, so that the high-order bits of
4577 the pointer aren't lost when converting through void *.
4578
4579 * eval.c (Fautoload): Don't double-shift a pointer.
4580
4581 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4582
4583 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4584
4585 * gnutls.c (DEF_GNUTLS_FN):
4586 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4587
4588 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4589
4590 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4591 marker. (Bug#8610)
4592
4593 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4594
4595 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4596 New version that can reserve upto 2GB of heap space.
4597
4598 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4599
4600 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4601
4602 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4603
4604 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4605 `gnutls_certificate_set_x509_key_file'.
4606
4607 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4608
4609 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4610 Update dependencies.
4611
4612 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4613
4614 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4615 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4616 Remove unused parameter `fildes'.
4617 * process.c (read_process_output, send_process): Don't pass it.
4618
4619 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4620
4621 Fix previous change: the library cache is defined in w32.c.
4622 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4623 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4624
4625 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4626
4627 Implement dynamic loading of GnuTLS on Windows.
4628
4629 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4630 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4631 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4632 Declare.
4633
4634 * gnutls.c (Qgnutls_dll): Define.
4635 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4636 (gnutls_*): Declare function pointers.
4637 (init_gnutls_functions): New function to initialize function pointers.
4638 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4639 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4640 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4641 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4642 (emacs_gnutls_write, emacs_gnutls_read)
4643 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4644 (Fgnutls_available_p): New function.
4645 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4646 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4647 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4648
4649 * image.c: Include w32.h.
4650 (Vimage_type_cache): Delete.
4651 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4652 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4653 (w32_delayed_load): Move to w32.c.
4654
4655 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4656
4657 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4658 (w32_delayed_load): Move from image.c. When loading a library, record
4659 its filename in the :loaded-from property of the library id.
4660 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4661 Initialize and staticpro them.
4662 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4663
4664 * process.c: Include lisp.h before w32.h, not after.
4665 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4666 instead of gnutls_record_check_pending.
4667
4668 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4669
4670 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4671
4672 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4673 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4674 as passed in.
4675
4676 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4677
4678 * xterm.c (x_set_frame_alpha): Do not set property on anything
4679 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4680
4681 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4682
4683 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4684
4685 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4686
4687 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4688 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4689 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4690 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4691 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4692 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4693 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4694 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4695 (Qgnutls_bootprop_callbacks_verify): Make static.
4696
4697 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4698
4699 * callproc.c: Indentation fixup.
4700
4701 * sysdep.c (wait_for_termination_1): Make static.
4702 (wait_for_termination, interruptible_wait_for_termination):
4703 Move after wait_for_termination_1.
4704
4705 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4706
4707 * sysdep.c (interruptible_wait_for_termination): New function
4708 which is like wait_for_termination, but allows keyboard
4709 interruptions.
4710
4711 * callproc.c (Fcall_process): Add (:file "file") as an option for
4712 the STDOUT buffer.
4713 (Fcall_process_region): Ditto.
4714
4715 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4716
4717 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4718 rather than `XVECTOR (FOO)->size'.
4719
4720 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4721 inttypes.h, as a gnulib replacement is used if it not available in
4722 system headers.
4723
4724 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4725
4726 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4727 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4728 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4729
4730 * coding.c (coding_alloc_by_realloc): Error out if destination
4731 will grow beyond MOST_POSITIVE_FIXNUM.
4732 (decode_coding_emacs_mule): Abort if there isn't enough place in
4733 charbuf for the composition carryover bytes. Reserve an extra
4734 space for up to 2 characters produced in a loop.
4735 (decode_coding_iso_2022): Abort if there isn't enough place in
4736 charbuf for the composition carryover bytes.
4737
4738 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4739
4740 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4741 aborting when %lld or %lll format is passed.
4742 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4743 %llo or %llx format is passed. (Bug#8545)
4744
4745 * window.c (window_scroll_line_based): Use a marker instead of
4746 simple variables to record original value of point. (Bug#7952)
4747
4748 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4749 produced by %s or %c overflows available buffer space. (Bug#8545)
4750
4751 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4752
4753 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4754 (SIZE_MAX): Move defn after all includes, as they might #define it.
4755
4756 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4757
4758 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4759
4760 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4761
4762 * keyboard.c (Qdelayed_warnings_hook): Define.
4763 (command_loop_1): Run `delayed-warnings-hook'
4764 if Vdelayed_warnings_list is non-nil.
4765 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4766 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4767
4768 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4769
4770 * doprnt.c (doprnt): Don't return value smaller than the buffer
4771 size if the message was truncated. (Bug#8545).
4772
4773 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4774
4775 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4776 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4777
4778 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4779
4780 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4781
4782 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4783
4784 * makefile.w32-in: Update dependencies.
4785
4786 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4787
4788 Improve `doprnt' and its usage. (Bug#8545)
4789 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4790 `format_end'. Remove support for %l as a conversion specifier.
4791 Don't use xrealloc. Improve diagnostics when the %l size modifier
4792 is used. Update the commentary.
4793
4794 * eval.c (verror): Simplify calculation of size_t.
4795
4796 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4797 messages.
4798
4799 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4800
4801 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4802 change.
4803
4804 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4805
4806 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4807 This makes this file independent of the recent pseudovector change.
4808
4809 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4810
4811 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4812
4813 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4814 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4815 Remove unused local.
4816 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4817
4818 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4819 GCC 4.6.0 optimizes based on type-based alias analysis.
4820 For example, if b is of type struct buffer * and v of type struct
4821 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4822 != &v->size, and therefore "v->size = 1; b->size = 2; return
4823 v->size;" must therefore return 1. This assumption is incorrect
4824 for Emacs, since it type-puns struct Lisp_Vector * with many other
4825 types. To fix this problem, this patch adds a new type struct
4826 vectorlike_header that documents the constraints on layout of vectors
4827 and pseudovectors, and helps optimizing compilers not get fooled
4828 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4829 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4830 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4831 the size member.
4832 (XSETPVECTYPE): Rewrite in terms of new macro.
4833 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4834 This is a bit clearer, and further avoids the possibility of
4835 undesirable aliasing.
4836 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4837 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4838 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4839 since Lisp_Subr is a special case (no "next" field).
4840 (ASIZE): Now uses header.size rather than size.
4841 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4842 to avoid the hassle of writing XVECTOR (foo)->header.size.
4843 (struct vectorlike_header): New type.
4844 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4845 object, to help avoid aliasing.
4846 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4847 (SUBRP): Likewise, since Lisp_Subr is a special case.
4848 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4849 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4850 (struct Lisp_Hash_Table): Combine first two members into a single
4851 struct vectorlike_header member. All uses of "size" and "next" members
4852 changed to be "header.size" and "header.next".
4853 * buffer.h (struct buffer): Likewise.
4854 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4855 * frame.h (struct frame): Likewise.
4856 * process.h (struct Lisp_Process): Likewise.
4857 * termhooks.h (struct terminal): Likewise.
4858 * window.c (struct save_window_data, struct saved_window): Likewise.
4859 * window.h (struct window): Likewise.
4860 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4861 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4862 * buffer.c (init_buffer_once): Likewise.
4863 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4864 special case.
4865 * process.c (Fformat_network_address): Use local var for size,
4866 for brevity.
4867
4868 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4869
4870 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4871 * data.c (atof): Remove decl; no longer used or needed.
4872 (digit_to_number): Move to lread.c.
4873 (Fstring_to_number): Use new string_to_number function, to be
4874 consistent with how the Lisp reader treats infinities and NaNs.
4875 Do not assume that floating-point numbers represent EMACS_INT
4876 without losing information; this is not true on most 64-bit hosts.
4877 Avoid double-rounding errors, by insisting on integers when
4878 parsing non-base-10 numbers, as the documentation specifies.
4879 * lisp.h (string_to_number): New decl, replacing ...
4880 (isfloat_string): Remove.
4881 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4882 (read1): Do not accept +. and -. as integers; this
4883 appears to have been a coding error. Similarly, do not accept
4884 strings like +-1e0 as floating point numbers. Do not report
4885 overflow for integer overflows unless the base is not 10 which
4886 means we have no simple and reliable way to continue.
4887 Break out the floating-point parsing into a new
4888 function string_to_number, so that Fstring_to_number parses
4889 floating point numbers consistently with the Lisp reader.
4890 (digit_to_number): Move here from data.c. Make it static inline.
4891 (E_CHAR, EXP_INT): Remove, replacing with ...
4892 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4893 (string_to_number): New function, replacing isfloat_string.
4894 This function checks for valid syntax and produces the resulting
4895 Lisp float number too. Rework it so that string-to-number
4896 no longer mishandles examples like "1.0e+". Use strtoumax,
4897 so that overflow for non-base-10 numbers is reported only when
4898 there's no portable and simple way to convert to floating point.
4899
4900 * textprop.c (set_text_properties_1): Rewrite for clarity,
4901 and to avoid GCC warning about integer overflow.
4902
4903 * intervals.h (struct interval): Use EMACS_INT for members
4904 where EMACS_UINT might cause problems. See
4905 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4906 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4907 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4908 All uses changed.
4909 (offset_intervals): Tell GCC not to worry about length overflow
4910 when negating a negative length.
4911
4912 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4913 (overrun_check_free): Likewise.
4914
4915 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4916 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4917 word size.
4918
4919 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4920 (gnutls_make_error): Rename local to avoid shadowing.
4921 (gnutls_emacs_global_deinit): ifdef out; not used.
4922 (Fgnutls_boot): Use const for pointer to readonly storage.
4923 Comment out unused local. Fix pointer signedness problems.
4924
4925 * lread.c (openp): Don't stuff size_t into an 'int'.
4926 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4927 about possible signed overflow.
4928
4929 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4930 (GDK_KEY_g): Don't define if already defined.
4931 (xg_prepare_tooltip): Avoid pointer signedness problem.
4932 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4933
4934 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4935 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4936
4937 * xfns.c (Fx_window_property): Simplify a bit,
4938 to make a bit faster and to avoid GCC 4.6.0 warning.
4939 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4940
4941 * fns.c (internal_equal): Don't assume size_t fits in int.
4942
4943 * alloc.c (compact_small_strings): Tighten assertion a little.
4944
4945 Replace pEd with more-general pI, and fix some printf arg casts.
4946 * lisp.h (pI): New macro, generalizing old pEd macro to other
4947 conversion specifiers. For example, use "...%"pI"d..." rather
4948 than "...%"pEd"...".
4949 (pEd): Remove. All uses replaced with similar uses of pI.
4950 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4951 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4952 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4953 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4954 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4955 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4956 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4957 64-bit hosts.
4958 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4959 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4960 * print.c (safe_debug_print, print_object): Likewise.
4961 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4962 to int.
4963 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4964 avoiding the 0 flag, which is not portable.
4965 * process.c (Fmake_network_process): Use pI to avoid cast.
4966 * region-cache.c (pp_cache): Likewise.
4967 * xdisp.c (decode_mode_spec): Likewise.
4968 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4969 behavior on 64-bit hosts with printf arg.
4970 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4971 (x_stop_queuing_selection_requests): Likewise.
4972 (x_get_window_property): Don't truncate byte count to an 'int'
4973 when tracing.
4974
4975 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4976 here, since it parses constructs like leading '-' and spaces,
4977 which are not wanted; and it overflows with large numbers.
4978 Instead, simply match F[0-9]+, which is what is wanted anyway.
4979
4980 * alloc.c: Remove unportable assumptions about struct layout.
4981 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4982 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4983 (allocate_vectorlike, make_pure_vector): Use the new macros,
4984 plus offsetof, to remove unportable assumptions about struct layout.
4985 These assumptions hold on all porting targets that I know of, but
4986 they are not guaranteed, they're easy to remove, and removing them
4987 makes further changes easier.
4988
4989 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4990 This doesn't fix a bug but makes the code clearer.
4991 (string_overrun_cookie): Now const. Use initializers that
4992 don't formally overflow signed char, to avoid warnings.
4993 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4994 can cause Emacs to crash when string overrun checking is enabled.
4995 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4996 multiple of sizeof (EMACS_INT); it need not be, if
4997 alignof(EMACS_INT) < sizeof (EMACS_INT).
4998 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4999
5000 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5001
5002 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5003
5004 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5005
5006 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5007 supposed to be handshaking. (Bug#8556)
5008 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5009
5010 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5011
5012 * lisp.h (Qdebug): List symbol.
5013 * eval.c (Qdebug): Restore global linkage.
5014 * keyboard.c (debug-on-event): New variable.
5015 (handle_user_signal): Break into debugger when debug-on-event
5016 matches the current signal symbol.
5017
5018 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5019
5020 * alloc.c (check_sblock, check_string_bytes)
5021 (check_string_free_list): Convert to standard C.
5022
5023 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5024
5025 * w32.c (emacs_gnutls_push): Fix typo.
5026
5027 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5028
5029 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5030 "cast to pointer from integer of different size".
5031
5032 Improve doprnt and its use in verror. (Bug#8545)
5033 * doprnt.c (doprnt): Document the set of format control sequences
5034 supported by the function. Use SAFE_ALLOCA instead of always
5035 using `alloca'.
5036
5037 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5038 is one byte too soon. Don't use xrealloc; instead xfree and
5039 xmalloc anew.
5040
5041 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5042
5043 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5044 callbacks stage.
5045
5046 * gnutls.c: Renamed global_initialized to
5047 gnutls_global_initialized. Added internals for the
5048 :verify-hostname-error, :verify-error, and :verify-flags
5049 parameters of `gnutls-boot' and documented those parameters in the
5050 docstring. Start callback support.
5051 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5052 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5053 on error. Return error code.
5054 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5055 (emacs_gnutls_read): Likewise.
5056 (Fgnutls_boot): Return handshake error code.
5057 (emacs_gnutls_handle_error): New function.
5058 (wsaerror_to_errno): Likewise.
5059
5060 * w32.h (emacs_gnutls_pull): Add prototype.
5061 (emacs_gnutls_push): Likewise.
5062
5063 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5064 (emacs_gnutls_push): Likewise.
5065
5066 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5067
5068 * process.c (wait_reading_process_output): Check if GnuTLS
5069 buffered some data internally if no FDs are set for TLS
5070 connections.
5071
5072 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5073 (LIBS): Link to USER_LIBS.
5074 ($(BLD)/gnutls.$(0)): New target.
5075
5076 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5077
5078 * xdisp.c (handle_single_display_spec): Rename the
5079 display_replaced_before_p argument into display_replaced_p, to
5080 make it consistent with the commentary. Fix typos in the
5081 commentary.
5082
5083 * textprop.c (syms_of_textprop): Remove dead code.
5084 (copy_text_properties): Delete obsolete commentary about an
5085 interface that was deleted long ago. Fix typos in the description
5086 of arguments.
5087
5088 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5089 to changes in oldXMenu/XMenu.h from 2011-04-16.
5090 <menu_help_message, prev_menu_help_message>: Constify.
5091 (IT_menu_make_room): menu->help_text is now `const char **';
5092 adjust.
5093
5094 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5095 to changes in oldXMenu/XMenu.h from 2011-04-16.
5096 (struct XMenu): Declare `help_text' `const char **'.
5097
5098 * xfaces.c <Qunspecified>: Make extern again.
5099
5100 * syntax.c: Include sys/types.h before including regex.h, as
5101 required by Posix.
5102
5103 * doc.c (get_doc_string): Improve the format passed to `error'.
5104
5105 * doprnt.c (doprnt): Improve commentary.
5106
5107 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5108
5109 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5110 them with etags.
5111
5112 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5113 changes in globals.h immediately force recompilation.
5114 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5115 $(CURDIR)/s/ms-w32.h.
5116 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5117
5118 * character.c (Fchar_direction): Function deleted.
5119 (syms_of_character): Don't defsubr it.
5120 <char-direction-table>: Deleted.
5121
5122 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5123
5124 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5125 * doprnt.c: Include limits.h.
5126 (SIZE_MAX): New macro.
5127 (doprnt): Return a size_t value. 2nd arg is now size_t.
5128 Many local variables are now size_t instead of int or unsigned.
5129 Improve overflow protection. Support `l' modifier for integer
5130 conversions. Support %l conversion. Don't assume an EMACS_INT
5131 argument for integer conversions and for %c.
5132
5133 * lisp.h (doprnt): Restore prototype.
5134
5135 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5136 $(SRC)/character.h.
5137
5138 * Makefile.in (base_obj): Add back doprnt.o.
5139
5140 * deps.mk (doprnt.o): Add back prerequisites.
5141 (callint.o): Depend on character.h.
5142
5143 * eval.c (internal_lisp_condition_case): Include the handler
5144 representation in the error message.
5145 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5146 when breaking from the loop.
5147
5148 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5149
5150 * callint.c (Fcall_interactively): When displaying error message
5151 about invalid control letter, pass the character's codepoint, not
5152 a pointer to its multibyte form. Improve display of the character
5153 in octal and display also its hex code.
5154
5155 * character.c (char_string): Use %x to display the (unsigned)
5156 codepoint of an invalid character, to avoid displaying a bogus
5157 negative value.
5158
5159 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5160 `error', not SYMBOL_NAME itself.
5161
5162 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5163 character arguments to `error'.
5164
5165 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5166 to `error' in error message about FINAL_CHAR argument. Make sure
5167 FINAL_CHAR is a character, and use %c when it is passed as
5168 argument to `error'.
5169
5170 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5171
5172 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5173
5174 * w32.c: Include <time.h>.
5175 (sys_localtime): New function.
5176
5177 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5178
5179 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5180
5181 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5182
5183 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5184
5185 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5186 zombies (Bug#8467).
5187
5188 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5189
5190 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5191 gl_state.e_property when gl_state.object is Qt.
5192
5193 * insdel.c (make_gap_larger): Remove limitation of buffer size
5194 to <= INT_MAX.
5195
5196 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5197
5198 * xdisp.c (lookup_glyphless_char_display)
5199 (produce_glyphless_glyph): Handle cons cell entry in
5200 glyphless-char-display.
5201 (Vglyphless_char_display): Document it.
5202
5203 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5204 glyphless-char-display.
5205
5206 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5207
5208 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5209
5210 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5211
5212 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5213 definition for no-X builds.
5214
5215 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5216
5217 Static checks with GCC 4.6.0 and non-default toolkits.
5218
5219 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5220
5221 * process.c (keyboard_bit_set): Define only if SIGIO.
5222 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5223 (send_process): Repair possible setjmp clobbering.
5224
5225 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5226
5227 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5228
5229 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5230
5231 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5232 Define only if needed.
5233
5234 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5235 by pacifying GCC about it. Maybe it's time to retire it?
5236 * xfaces.c (USG, __TIMEVAL__): Likewise.
5237
5238 * dispextern.h (struct redisplay_interface): Rename param
5239 to avoid shadowing.
5240 * termhooks.h (struct terminal): Likewise.
5241 * xterm.c (xembed_send_message): Likewise.
5242
5243 * insdel.c (make_gap_smaller): Define only if
5244 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5245
5246 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5247 it.
5248
5249 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5250 so that we aren't warned about unused symbols.
5251
5252 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5253
5254 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5255
5256 * xfns.c (x_real_positions): Mark locals as initialized.
5257
5258 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5259
5260 * xterm.c: Fix problems found by static analysis with other toolkits.
5261 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5262 (x_dispatch_event): Declare static if USE_GTK, and
5263 define if USE_GTK || USE_X_TOOLKIT.
5264 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5265 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5266 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5267 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5268
5269 * xmenu.c (menu_help_callback): Pointer type fixes.
5270 Use const pointers when pointing at readonly data. Avoid pointer
5271 signedness clashes.
5272 (FALSE): Remove unused macro.
5273 (update_frame_menubar): Remove unused decl.
5274
5275 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5276
5277 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5278 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5279 (single_menu_item): Rename local to avoid shadowing.
5280
5281 * keyboard.c (make_lispy_event): Remove unused local var.
5282
5283 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5284 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5285
5286 * bitmaps: Change bitmaps from unsigned char back to the X11
5287 compatible char. Avoid the old compiler warnings about
5288 out-of-range initializers by using, for example, '\xab' rather
5289 than 0xab.
5290
5291 * xgselect.c (xgselect_initialize): Check vs interface
5292 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5293
5294 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5295
5296 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5297 to read-only memory.
5298
5299 * fns.c (vector): Remove; this old hack is no longer needed.
5300
5301 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5302 Remove unused var.
5303 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5304
5305 * xrdb.c (x_load_resources): Omit unused local.
5306
5307 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5308 (x_window): Rename locals to avoid shadowing.
5309 (USG): Use the kludged USG macro, to pacify gcc.
5310
5311 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5312 (x_term_init): Remove local to avoid shadowing.
5313
5314 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5315
5316 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5317 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5318
5319 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5320
5321 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5322
5323 Fix regex.c, syntax.c and friends for buffers > 2GB.
5324 * syntax.h (struct gl_state_s): Declare character position members
5325 EMACS_INT.
5326
5327 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5328
5329 * textprop.c (verify_interval_modification, interval_of):
5330 Declare arguments EMACS_INT.
5331
5332 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5333 EMACS_INT.
5334
5335 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5336
5337 * indent.c (Fvertical_motion): Local variable it_start is now
5338 EMACS_INT.
5339
5340 * regex.c (re_match, re_match_2, re_match_2_internal)
5341 (bcmp_translate, regcomp, regexec, print_double_string)
5342 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5343 (re_compile_pattern, re_exec): Declare arguments and local
5344 variables `size_t' and `ssize_t' and return values `regoff_t', as
5345 appropriate.
5346 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5347 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5348 <compile_stack_type>: `size' and `avail' are now `size_t'.
5349
5350 * regex.h <regoff_t>: Use ssize_t, not int.
5351 (re_search, re_search_2, re_match, re_match_2): Arguments that
5352 specify buffer/string position and length are now ssize_t and
5353 size_t. Return type is regoff_t.
5354
5355 2011-04-16 Ben Key <bkey76@gmail.com>
5356
5357 * nsfont.m: Fixed bugs in ns_get_family and
5358 ns_descriptor_to_entity that were caused by using free to
5359 deallocate memory blocks that were allocated by xmalloc (via
5360 xstrdup). This caused Emacs to crash when compiled with
5361 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5362 --enable-checking=xmallocoverrun). xfree is now used to
5363 deallocate these memory blocks.
5364
5365 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5366
5367 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5368
5369 emacs_write: Accept and return EMACS_INT for sizes.
5370 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5371 et seq.
5372 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5373 Accept and return EMACS_INT.
5374 (emacs_gnutls_write): Return the number of bytes written on
5375 partial writes.
5376 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5377 (emacs_read, emacs_write): Remove check for negative size, as the
5378 Emacs source code has been audited now.
5379 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5380 (emacs_read, emacs_write): Use it.
5381 * process.c (send_process): Adjust to the new signatures of
5382 emacs_write and emacs_gnutls_write. Do not attempt to store
5383 a byte offset into an 'int'; it might overflow.
5384 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5385
5386 * sound.c: Don't assume sizes fit in 'int'.
5387 (struct sound_device.period_size, alsa_period_size):
5388 Return EMACS_INT, not int.
5389 (struct sound_device.write, vox_write, alsa_write):
5390 Accept EMACS_INT, not int.
5391 (wav_play, au_play): Use EMACS_INT to store sizes and to
5392 record read return values.
5393
5394 2011-04-15 Ben Key <bkey76@gmail.com>
5395
5396 * keyboard.c (Qundefined): Don't declare static since it is used
5397 in nsfns.m.
5398 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5399 static since they are used in nsfont.m.
5400
5401 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5402
5403 * process.c (Qprocessp): Don't declare static.
5404 * lisp.h (Qprocessp): Declare again.
5405
5406 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5407
5408 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5409
5410 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5411
5412 Improve C-level modularity by making more things 'static'.
5413
5414 Don't publish debugger-only interfaces to other modules.
5415 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5416 (verify_bytepos, count_markers): Move decls to the only modules
5417 that need them.
5418 * region-cache.h (pp_cache): Likewise.
5419 * window.h (check_all_windows): Likewise.
5420 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5421
5422 * sysdep.c (croak): Now static, if
5423 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5424 * syssignal.h (croak): Declare only if not static.
5425
5426 * alloc.c (refill_memory_reserve): Now static if
5427 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5428 * lisp.h (refill_memory_reserve): Declare only if not static.
5429
5430 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5431 Define only if USE_LUCID.
5432
5433 * xrdb.c (x_customization_string, x_rm_string): Now static.
5434
5435 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5436 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5437
5438 * xdisp.c (draw_row_with_mouse_face): Now static.
5439 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5440
5441 * window.h (check_all_windows): Mark externally visible.
5442
5443 * window.c (window_deletion_count): Now static.
5444
5445 * undo.c: Make symbols static if they're not exported.
5446 (last_undo_buffer, last_boundary_position, pending_boundary):
5447 Now static.
5448
5449 * textprop.c (interval_insert_behind_hooks): Now static.
5450 (interval_insert_in_front_hooks): Likewise.
5451
5452 * term.c: Make symbols static if they're not exported.
5453 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5454 (max_frame_lines, tty_set_terminal_modes):
5455 (tty_reset_terminal_modes, tty_turn_off_highlight):
5456 (get_tty_terminal): Now static.
5457 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5458 * termhooks.h (term_mouse_moveto): Do not declare if
5459 HAVE_WINDOW_SYSTEM.
5460 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5461 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5462
5463 * sysdep.c: Make symbols static if they're not exported.
5464 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5465 Now static.
5466 (sigprocmask_set, full_mask): Remove; unused.
5467 (wait_debugging): Mark as visible.
5468 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5469 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5470
5471 * syntax.c (syntax_temp): Define only if !__GNUC__.
5472
5473 * sound.c (current_sound_device, current_sound): Now static.
5474
5475 * search.c (searchbufs, searchbuf_head): Now static.
5476
5477 * scroll.c (scroll_cost): Remove; unused.
5478 * dispextern.h (scroll_cost): Remove decl.
5479
5480 * region-cache.h (pp_cache): Mark as externally visible.
5481
5482 * process.c: Make symbols static if they're not exported.
5483 (process_tick, update_tick, create_process, chan_process):
5484 (Vprocess_alist, proc_buffered_char, datagram_access):
5485 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5486 (deactivate_process): Mark defn as static, as well as decl.
5487 * lisp.h (create_process): Remove decl.
5488 * process.h (chan_process, Vprocess_alist): Remove decls.
5489
5490 * print.c: Make symbols static if they're not exported.
5491 (print_depth, new_backquote_output, being_printed, print_buffer):
5492 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5493 (print_interval, print_number_index, initial_stderr_stream):
5494 Now static.
5495 * lisp.h (Fprinc): Remove decl.
5496 (debug_output_compilation_hack): Mark as externally visible.
5497
5498 * sysdep.c (croak): Move decl from here to syssignal.h.
5499 * syssignal.h (croak): Put it here, so the API can be checked when
5500 'croak' is called from dissociate_if_controlling_tty.
5501
5502 * minibuf.c: Make symbols static if they're not exported.
5503 (minibuf_save_list, choose_minibuf_frame): Now static.
5504 * lisp.h (choose_minibuf_frame): Remove decl.
5505
5506 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5507
5508 * lread.c: Make symbols static if they're not exported.
5509 (read_objects, initial_obarray, oblookup_last_bucket_number):
5510 Now static.
5511 (make_symbol): Remove; unused.
5512 * lisp.h (initial_obarray, make_symbol): Remove decls.
5513
5514 * keyboard.c: Make symbols static if they're not exported.
5515 (single_kboard, recent_keys_index, total_keys, recent_keys):
5516 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5517 (this_single_command_key_start, echoing, last_auto_save):
5518 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5519 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5520 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5521 (Vlispy_mouse_stem, double_click_count):
5522 Now static.
5523 (force_auto_save_soon): Define only if SIGDANGER.
5524 (ignore_mouse_drag_p): Now static if
5525 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5526 (print_help): Remove; unused.
5527 (stop_character, last_timer_event): Mark as externally visible.
5528 * keyboard.h (ignore_mouse_drag_p): Declare only if
5529 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5530 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5531 * lisp.h (echoing): Remove decl.
5532 (force_auto_save_soon): Declare only if SIGDANGER.
5533 * xdisp.c (redisplay_window): Simplify code, to make it more
5534 obvious that ignore_mouse_drag_p is not accessed if !defined
5535 USE_GTK && !defined HAVE_NS.
5536
5537 * intervals.c: Make symbols static if they're not exported.
5538 (merge_properties_sticky, merge_interval_right, delete_interval):
5539 Now static.
5540 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5541
5542 * insdel.c: Make symbols static if they're not exported.
5543 However, leave prepare_to_modify_buffer alone. It's never
5544 called from outside this function, but that appears to be a bug.
5545 (combine_after_change_list, combine_after_change_buffer):
5546 (adjust_after_replace, signal_before_change): Now static.
5547 (adjust_after_replace_noundo): Remove; unused.
5548 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5549 (signal_before_change): Remove decls.
5550
5551 * indent.c (val_compute_motion, val_vmotion): Now static.
5552
5553 * image.c: Make symbols static if they're not exported.
5554 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5555 if USE_GTK.
5556 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5557 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5558
5559 * fringe.c (standard_bitmaps): Now static.
5560 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5561
5562 * frame.c: Make symbols static if they're not exported.
5563 (x_report_frame_params, make_terminal_frame): Now static.
5564 (get_frame_param): Now static, unless HAVE_NS.
5565 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5566 (x_get_resource_string): Remove; not used.
5567 * frame.h (make_terminal_frame, x_report_frame_params):
5568 (x_get_resource_string); Remove decls.
5569 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5570 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5571
5572 * font.c, fontset.c: Make symbols static if they're not exported.
5573 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5574 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5575 * font.c (font_close_object): Now static.
5576 * font.h (font_close_object): Remove.
5577 * fontset.c (FONTSET_OBJLIST): Remove.
5578 (free_realized_fontset) #if-0 the body, which does nothing.
5579 (face_suitable_for_char_p): #if-0, as it's never called.
5580 * fontset.h (face_suitable_for_char_p): Remove decl.
5581 * xfaces.c (face_at_string_position):
5582 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5583 since 0 is always ASCII.
5584
5585 * fns.c (weak_hash_tables): Now static.
5586
5587 * fileio.c: Make symbols static if they're not exported.
5588 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5589 (Vwrite_region_annotation_buffers): Now static.
5590
5591 * eval.c: Make symbols static if they're not exported.
5592 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5593 * lisp.h (backtrace_list): Remove decl.
5594
5595 * emacs.c: Make symbols static if they're not exported.
5596 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5597 (fatal_error_code, fatal_error_signal_hook, standard_args):
5598 Now static.
5599 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5600 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5601 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5602 * lisp.h (fatal_error_signal_hook): Remove decl.
5603 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5604
5605 * editfns.c: Move a (normally-unused) function to its only use.
5606 * editfns.c, lisp.h (get_operating_system_release): Remove.
5607 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5608 worth the hassle of breaking this out.
5609
5610 * xterm.c: Make symbols static if they're not exported.
5611 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5612 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5613 (x_destroy_window, x_delete_display):
5614 Now static.
5615 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5616 (x_mouse_leave): Remove; unused.
5617 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5618 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5619 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5620 Remove decls.
5621 (x_mouse_leave): Declare only if WINDOWSNT.
5622 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5623 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5624 USE_X_TOOLKIT.
5625
5626 * ftxfont.c: Make symbols static if they're not exported.
5627 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5628 HAVE_FREETYPE.
5629 * font.h (ftxfont_driver): Likewise.
5630
5631 * xfns.c: Make symbols static if they're not exported.
5632 (x_last_font_name, x_display_info_for_name):
5633 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5634 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5635 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5636 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5637 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5638 (last_show_tip_args): Now static.
5639 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5640 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5641 (x_screen_planes): Remove; unused.
5642 * dispextern.h (x_screen_planes): Remove decl.
5643
5644 * dispnew.c: Make symbols static if they're not exported.
5645 * dispextern.h (redraw_garbaged_frames, scrolling):
5646 (increment_row_positions): Remove.
5647 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5648 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5649 Now static.
5650 (redraw_garbaged_frames): Remove; unused.
5651
5652 * xfaces.c: Make symbols static if they're not exported.
5653 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5654 Remove decls.
5655 * xterm.h (defined_color): Remove decls.
5656 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5657 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5658 (menu_face_changed_default, defined_color, free_realized_face):
5659 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5660 (ascii_face_of_lisp_face): Remove; unused.
5661
5662 * xdisp.c: Make symbols static if they're not exported.
5663 * dispextern.h (scratch_glyph_row, window_box_edges):
5664 (glyph_to_pixel_coords, set_cursor_from_row):
5665 (get_next_display_element, set_iterator_to_next):
5666 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5667 (show_mouse_face): Remove decls
5668 * frame.h (message_buf_print): Likewise.
5669 * lisp.h (pop_message, set_message, check_point_in_composition):
5670 Likewise.
5671 * xterm.h (set_vertical_scroll_bar): Likewise.
5672 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5673 (message_buf_print, scratch_glyph_row, displayed_buffer):
5674 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5675 (get_next_display_element, show_mouse_face, window_box_edges):
5676 (frame_to_window_pixel_xy, check_point_in_composition):
5677 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5678 (glyph_to_pixel_coords): Remove; unused.
5679
5680 * dired.c (file_name_completion): Now static.
5681
5682 * dbusbind.c (xd_in_read_queued_messages): Now static.
5683
5684 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5685 * data.c (circular_list_error): Remove.
5686
5687 * commands.h (last_point_position, last_point_position_buffer):
5688 (last_point_position_window): Remove decls.
5689 * keyboard.c: Make these variables static.
5690
5691 * coding.h (coding, code_convert_region, encode_coding_gap):
5692 Remove decls.
5693 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5694 (iso_code_class, detect_coding, code_convert_region): Now static.
5695 (encode_coding_gap): Remove; unused.
5696
5697 * chartab.c (chartab_chars, chartab_bits): Now static.
5698
5699 * charset.h (charset_iso_8859_1): Remove decl.
5700 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5701 Now static.
5702
5703 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5704 * ccl.c (Vccl_program_table): Now static.
5705 (check_ccl_update): Remove; unused.
5706
5707 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5708 * category.h: ... from here.
5709 * category.c (check_category_table, set_category_set): Now static.
5710
5711 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5712 * lisp.h: Remove these decls.
5713
5714 * buffer.c (buffer_count): Remove unused var.
5715
5716 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5717 so that it's not optimized away.
5718 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5719 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5720 exported only to the debugger.
5721
5722 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5723 * atimer.h (run_all_atimers): Remove; not exported.
5724
5725 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5726 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5727 was inaccessible from Lisp.
5728 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5729 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5730
5731 alloc.c: Import and export fewer symbols, and remove unused items.
5732 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5733 is defined.
5734 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5735 it's not optimized away by whole-program optimization.
5736 (message_enable_multibyte, free_misc): Remove.
5737 (catchlist, handlerlist, mark_backtrace):
5738 Declare only if BYTE_MARK_STACK.
5739 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5740 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5741 (message_enable_multibyte): Remove decl.
5742 (free_misc, interval_free_list, float_block, float_block_index):
5743 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5744 (cons_free_list, last_marked_index):
5745 Now static.
5746 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5747 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5748 (mark_backtrace): Define only if BYTE_MARK_STACK.
5749 * xdisp.c (message_enable_multibyte): Now static.
5750
5751 Declare Lisp_Object Q* variables to be 'static' if not exported.
5752 This makes it easier for human readers (and static analyzers)
5753 to see whether these variables are used from other modules.
5754 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5755 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5756 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5757 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5758 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5759 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5760 * xmenu.c, xselect.c:
5761 Declare Q* vars static if they are not used in other modules.
5762 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5763 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5764 Remove decls of unexported vars.
5765 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5766
5767 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5768
5769 Make Emacs functions such as Fatom 'static' by default.
5770 This makes it easier for human readers (and static analyzers)
5771 to see whether these functions can be called from other modules.
5772 DEFUN now defines a static function. To make the function external
5773 so that it can be used in other C modules, use the new macro DEFUE.
5774 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5775 (Finit_image_library):
5776 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5777 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5778 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5779 Remove decls, since these functions are now static.
5780 (Funintern, Fget_internal_run_time): New decls, since these functions
5781 were already external.
5782
5783 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5784 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5785 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5786 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5787 * keyboard.c, keymap.c, lread.c:
5788 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5789 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5790 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5791 Mark functions with DEFUE instead of DEFUN,
5792 if they are used in other modules.
5793 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5794 decls for now-static functions.
5795 * buffer.h (Fdelete_overlay): Remove decl.
5796 * callproc.c (Fgetenv_internal): Mark as internal.
5797 * composite.c (Fremove_list_of_text_properties): Remove decl.
5798 (Fcomposition_get_gstring): New forward static decl.
5799 * composite.h (Fcomposite_get_gstring): Remove decl.
5800 * dired.c (Ffile_attributes): New forward static decl.
5801 * doc.c (Fdocumntation_property): New forward static decl.
5802 * eval.c (Ffetch_bytecode): New forward static decl.
5803 (Funintern): Remove extern decl; now in .h file where it belongs.
5804 * fileio.c (Fmake_symbolic_link): New forward static decl.
5805 * image.c (Finit_image_library): New forward static decl.
5806 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5807 * intervals.h (Fprevious_property_change):
5808 (Fremove_list_of_text_properties): Remove decls.
5809 * keyboard.c (Fthis_command_keys): Remove decl.
5810 (Fcommand_execute): New forward static decl.
5811 * keymap.c (Flookup_key): New forward static decl.
5812 (Fcopy_keymap): Now static.
5813 * keymap.h (Flookup_key): Remove decl.
5814 * process.c (Fget_process): New forward static decl.
5815 (Fprocess_datagram_address): Mark as internal.
5816 * syntax.c (Fsyntax_table_p): New forward static decl.
5817 (skip_chars): Remove duplicate decl.
5818 * textprop.c (Fprevious_property_change): New forward static decl.
5819 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5820 Now internal.
5821 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5822 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5823
5824 * editfns.c (Fformat): Remove unreachable code.
5825
5826 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5827
5828 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5829 change. (Bug#8496)
5830
5831 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5832
5833 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5834 when at ZV. (Bug#8487)
5835
5836 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5837
5838 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5839 (Bug#8437)
5840 * keyboard.c (parse_tool_bar_item): Likewise.
5841 * sound.c (sound_cleanup, alsa_close): Likewise.
5842 * termcap.c (tgetent): Likewise.
5843 * xfns.c (x_default_font_parameter): Likewise.
5844 * xsettings.c (read_and_apply_settings): Likewise.
5845
5846 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5847 (overrun_check_free): Protoize.
5848
5849 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5850
5851 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5852 since callers should never pass a negative size.
5853 Change the signature to match that of plain 'read' and 'write'; see
5854 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5855 * lisp.h: Update prototypes of emacs_write and emacs_read.
5856
5857 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5858
5859 * xdisp.c (redisplay_window): Don't try to determine the character
5860 position of the scroll margin if the window start point w->startp
5861 is outside the buffer's accessible region. (Bug#8468)
5862
5863 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5864
5865 Fix write-region and its subroutines for buffers > 2GB.
5866 * fileio.c (a_write, e_write): Modify declaration of arguments and
5867 local variables to support buffers larger than 2GB.
5868 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5869
5870 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5871 argument, local variables, and return value.
5872
5873 * lisp.h: Update prototypes of emacs_write and emacs_read.
5874
5875 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5876
5877 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5878
5879 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5880
5881 Fix more problems found by GCC 4.6.0's static checks.
5882
5883 * xdisp.c (vmessage): Use a better test for character truncation.
5884
5885 * charset.c (load_charset_map): <, not <=, for optimization,
5886 and to avoid potential problems with integer overflow.
5887 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5888 * casetab.c (set_identity, shuffle): Likewise.
5889 * editfns.c (Fformat): Likewise.
5890 * syntax.c (skip_chars): Likewise.
5891
5892 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5893 This also lets GCC 4.6.0 generate slightly better loop code.
5894
5895 * callint.c (Fcall_interactively): <, not <=, for optimization.
5896 (Fcall_interactively): Count the number of arguments produced,
5897 not the number of arguments given. This is simpler and lets GCC
5898 4.6.0 generate slightly better code.
5899
5900 * ftfont.c: Distingish more carefully between FcChar8 and char.
5901 The previous code passed unsigned char * to a functions like
5902 strlen and xstrcasecmp that expect char *, which does not
5903 conform to the C standard.
5904 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5905 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5906 char * when the C standard requires it.
5907
5908 * keyboard.c (read_char): Remove unused var.
5909
5910 * eval.c: Port to Windows vsnprintf (Bug#8435).
5911 Include <limits.h>.
5912 (SIZE_MAX): Define if the headers do not.
5913 (verror): Do not give up if vsnprintf returns a negative count.
5914 Instead, grow the buffer. This ports to Windows vsnprintf, which
5915 does not conform to C99. Problem reported by Eli Zaretskii.
5916 Also, simplify the allocation scheme, by avoiding the need for
5917 calling realloc, and removing the ALLOCATED variable.
5918
5919 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5920
5921 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5922 But keep the doprint source code for now, as we might revamp it
5923 and use it again (Bug#8435).
5924 * lisp.h (doprnt): Remove.
5925 * Makefile.in (base_obj): Remove doprnt.o.
5926 * deps.mk (doprnt.o): Remove.
5927
5928 error: Print 32- and 64-bit integers portably (Bug#8435).
5929 Without this change, on typical 64-bit hosts error ("...%d...", N)
5930 was used to print both 32- and 64-bit integers N, which relied on
5931 undefined behavior.
5932 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5933 New macro.
5934 * lisp.h (error, verror): Mark as printf-like functions.
5935 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5936 Report overflow in size calculations when allocating printf buffer.
5937 Do not truncate output string at its first null byte.
5938 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5939 Truncate the output at a character boundary, since vsnprintf does not
5940 do that.
5941 * charset.c (check_iso_charset_parameter): Convert internal
5942 character to string before calling 'error', since %c now has the
5943 printf meaning.
5944 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5945 overflow when computing char to be passed to 'error'. Do not
5946 pass Lisp_Object to 'error'; pass the integer instead.
5947 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5948 formatted with plain %d.
5949
5950 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5951
5952 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5953
5954 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5955
5956 * xterm.c (x_catch_errors): Remove duplicate declaration.
5957
5958 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5959
5960 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5961
5962 2011-04-10 Jim Meyering <meyering@redhat.com>
5963
5964 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5965 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5966 return ssize_t not "int", and use size_t as the buffer length.
5967 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5968 * gnutls.h: Update declarations.
5969 * process.c (read_process_output): Use ssize_t, to match.
5970 (send_process): Likewise.
5971
5972 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5973
5974 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5975
5976 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5977
5978 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5979 Use unsigned char, to match FcChar8 type definition.
5980
5981 * xterm.c (handle_one_xevent):
5982 * xmenu.c (create_and_show_popup_menu):
5983 * xselect.c (x_decline_selection_request)
5984 (x_reply_selection_request): Avoid type-punned deref of X events.
5985
5986 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5987
5988 Fix some uses of `int' instead of EMACS_INT.
5989 * search.c (string_match_1, fast_string_match)
5990 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5991 (scan_buffer, find_next_newline_no_quit)
5992 (find_before_next_newline, search_command, Freplace_match)
5993 (Fmatch_data): Make some `int' variables be EMACS_INT.
5994
5995 * xdisp.c (display_count_lines): 3rd argument and return value now
5996 EMACS_INT. All callers changed.
5997 (pint2hrstr): Last argument is now EMACS_INT.
5998
5999 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6000 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6001 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6002 (decode_coding_utf_16, decode_coding_emacs_mule)
6003 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6004 (decode_coding_ccl, decode_coding_charset)
6005 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6006 (decode_coding_iso_2022, decode_coding_emacs_mule)
6007 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6008 <char_offset, last_offset>: Declare EMACS_INT.
6009 (encode_coding_utf_8, encode_coding_utf_16)
6010 (encode_coding_emacs_mule, encode_invocation_designation)
6011 (encode_designation_at_bol, encode_coding_iso_2022)
6012 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6013 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6014 Declare EMACS_INT.
6015 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6016 (encode_invocation_designation): Last argument P_NCHARS is now
6017 EMACS_INT.
6018 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6019 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6020
6021 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6022 All users changed.
6023
6024 * ccl.c (Fccl_execute_on_string): Declare some variables
6025 EMACS_INT.
6026
6027 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6028
6029 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6030
6031 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6032
6033 * process.c (Fformat_network_address): Doc fix.
6034
6035 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6036
6037 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6038
6039 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6040
6041 * keyboard.c (read_char): Call Lisp function help-form-show,
6042 instead of using internal_with_output_to_temp_buffer.
6043 (Qhelp_form_show): New var.
6044 (syms_of_keyboard): Use DEFSYM macro.
6045
6046 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6047
6048 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6049
6050 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6051
6052 * process.c (Flist_processes): Remove to Lisp.
6053 (list_processes_1): Delete.
6054
6055 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6056
6057 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6058
6059 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6060
6061 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6062
6063 Fix more problems found by GCC 4.6.0's static checks.
6064
6065 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6066
6067 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6068
6069 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6070
6071 * xdisp.c (vmessage): Mark as a printf-like function.
6072
6073 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6074
6075 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6076
6077 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6078 printf-like functions.
6079 (tiff_load): Add casts to remove these marks before passing them
6080 to system-supplied API.
6081
6082 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6083
6084 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6085 This avoids several warnings with gcc -Wstrict-overflow.
6086 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6087 directly, rather than having caller test rule sign. This avoids
6088 some unnecessary tests.
6089 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6090 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6091 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6092
6093 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6094 (xfont_open): Avoid unnecessary tests.
6095
6096 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6097
6098 * composite.h, composite.c (composition_gstring_put_cache):
6099 Use EMACS_INT, not int, for length.
6100
6101 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6102 breaking out part of COMPOSITION_DECODE_RULE.
6103 (COMPOSITION_DECODE_RULE): Use it.
6104 * composite.c (get_composition_id): Remove unused local vars,
6105 by using the new macro.
6106
6107 * textprop.c (set_text_properties_1): Change while to do-while,
6108 since the condition is always true at first.
6109
6110 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6111 (interval_deletion_adjustment): Return unsigned value.
6112 All uses changed.
6113
6114 * process.c (list_processes_1, create_pty, read_process_output):
6115 (exec_sentinel): Remove vars that were set but not used.
6116 (create_pty): Remove unnecessary "volatile"s.
6117 (Fnetwork_interface_info): Avoid possibility of int overflow.
6118 (read_process_output): Do adaptive read buffering even if carryover.
6119 (read_process_output): Simplify nbytes computation if buffered.
6120
6121 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6122
6123 * syntax.c (scan_words): Remove var that was set but not used.
6124 (update_syntax_table): Use unsigned instead of int.
6125
6126 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6127 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6128 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6129
6130 * print.c (print_error_message): Avoid int overflow.
6131
6132 * font.c (font_list_entities): Redo for clarity,
6133 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6134
6135 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6136 (font_score): Avoid potential overflow in diff calculation.
6137
6138 * fns.c (substring_both): Remove var that is set but not used.
6139 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6140
6141 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6142
6143 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6144 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6145 can always succeed if overflow has undefined behavior.
6146
6147 * search.c (boyer_moore, wordify): Remove vars set but not used.
6148 (wordify): Omit three unnecessary tests.
6149
6150 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6151 All callers changed. This avoids the need for an unused var.
6152
6153 * casefiddle.c (casify_region): Remove var that is set but not used.
6154
6155 * dired.c (file_name_completion): Remove var that is set but not used.
6156
6157 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6158
6159 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6160 (Finsert_file_contents): Remove unnecessary code checking fd.
6161
6162 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6163 Check for integer overflow on size calculations.
6164
6165 * buffer.c (Fprevious_overlay_change): Remove var that is set
6166 but not used.
6167
6168 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6169 Remove vars that are set but not used.
6170 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6171 (timer_check_2): Mark vars as initialized.
6172
6173 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6174
6175 * image.c (lookup_image): Remove var that is set but not used.
6176 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6177
6178 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6179 that are set but not used.
6180
6181 * xfns.c (make_invisible_cursor): Don't return garbage
6182 if XCreateBitmapFromData fails (Bug#8410).
6183
6184 * xselect.c (x_get_local_selection, x_handle_property_notify):
6185 Remove vars that are set but not used.
6186
6187 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6188 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6189
6190 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6191 Remove var that is set but not used.
6192 (scroll_bar_windows_size): Now size_t, not int.
6193 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6194 Check for overflow.
6195
6196 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6197 (map_tty_color) [!defined MSDOS]: Likewise.
6198
6199 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6200
6201 * coding.c: Remove vars that are set but not used.
6202 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6203 All callers changed.
6204 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6205 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6206 (decode_coding_charset): Remove vars that are set but not used.
6207
6208 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6209 that is set but not used.
6210
6211 * print.c (print_object): Remove var that is set but not used.
6212
6213 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6214 The gnulib version avoids calling malloc in the usual case,
6215 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6216 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6217 * filelock.c (current_lock_owner): Likewise.
6218 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6219 * sysdep.c: Include allocator.h, careadlinkat.h.
6220 (emacs_no_realloc_allocator): New static constant.
6221 (emacs_readlink): New function.
6222 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6223 ../lib/careadlinkat.h.
6224
6225 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6226
6227 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6228 first non-nil return value).
6229
6230 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6231
6232 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6233 if not defined (Bug#8403).
6234
6235 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6236
6237 * xdisp.c (display_count_lines): Remove parameter `start',
6238 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6239 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6240 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6241 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6242 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6243 and thereabouts. All callers changed.
6244 (get_per_char_metric): Remove parameter `f', unused since
6245 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6246
6247 2011-04-02 Jim Meyering <meyering@redhat.com>
6248
6249 do not dereference NULL upon failed strdup
6250 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6251 (ns_get_family): Likewise.
6252
6253 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6254
6255 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6256
6257 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6258
6259 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6260 later (Bug#8403).
6261
6262 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6263
6264 Add lexical binding.
6265
6266 * window.c (Ftemp_output_buffer_show): New fun.
6267 (Fsave_window_excursion):
6268 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6269
6270 * lread.c (lisp_file_lexically_bound_p): New function.
6271 (Fload): Bind Qlexical_binding.
6272 (readevalloop): Remove `evalfun' arg.
6273 Bind Qinternal_interpreter_environment.
6274 (Feval_buffer): Bind Qlexical_binding.
6275 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6276 Mark as dynamic.
6277 (syms_of_lread): Declare `lexical-binding'.
6278
6279 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6280
6281 * keyboard.c (eval_dyn): New fun.
6282 (menu_item_eval_property): Use it.
6283
6284 * image.c (parse_image_spec): Use Ffunctionp.
6285
6286 * fns.c (concat, mapcar1): Accept byte-code-functions.
6287
6288 * eval.c (Fsetq): Handle lexical vars.
6289 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6290 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6291 (FletX, Flet): Obey lexical binding.
6292 (Fcommandp): Handle closures.
6293 (Feval): New `lexical' arg.
6294 (eval_sub): New function extracted from Feval. Use it almost
6295 everywhere where Feval was used. Look up vars in lexical env.
6296 Handle closures.
6297 (Ffunctionp): Move from subr.el.
6298 (Ffuncall): Handle closures.
6299 (apply_lambda): Remove `eval_flags'.
6300 (funcall_lambda): Handle closures and new byte-code-functions.
6301 (Fspecial_variable_p): New function.
6302 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6303 but without exporting it to Lisp.
6304
6305 * doc.c (Fdocumentation, store_function_docstring):
6306 * data.c (Finteractive_form): Handle closures.
6307
6308 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6309 interactive spec.
6310
6311 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6312 New byte-codes.
6313 (exec_byte_code): New function extracted from Fbyte_code to handle new
6314 calling convention for byte-code-functions. Add new byte-codes.
6315
6316 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6317
6318 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6319
6320 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6321
6322 * xdisp.c (redisplay_internal): Fix prototype.
6323
6324 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6325
6326 * xdisp.c (SCROLL_LIMIT): New macro.
6327 (try_scrolling): Use it when setting scroll_limit.
6328 Limit scrolling to 100 screen lines.
6329 (redisplay_window): Even when falling back on "recentering",
6330 position point in the window according to scroll-conservatively,
6331 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6332
6333 (try_scrolling): When point is above the window, allow searching
6334 as far as scroll_max, or one screenful, to compute vertical
6335 distance from PT to the scroll margin position. This prevents
6336 try_scrolling from unnecessarily failing when
6337 scroll-conservatively is set to a value slightly larger than the
6338 window height. Clean up the case of PT below the margin at bottom
6339 of window: scroll_max can no longer be INT_MAX. When aggressive
6340 scrolling is in use, don't let point enter the opposite scroll
6341 margin as result of the scroll.
6342 (syms_of_xdisp) <scroll-conservatively>: Document the
6343 threshold of 100 lines for never-recentering scrolling.
6344
6345 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6346
6347 * dispextern.h (move_it_by_lines):
6348 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6349 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6350 (message_log_check_duplicate): Remove parameters `prev_bol' and
6351 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6352 (redisplay_internal): Remove parameter `preserve_echo_area',
6353 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6354
6355 * indent.c (Fvertical_motion):
6356 * window.c (window_scroll_pixel_based, Frecenter):
6357 Don't pass `need_y_p' to `move_it_by_lines'.
6358
6359 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6360
6361 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6362 steal a few bits to be more compact.
6363 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6364 Remove unneeded casts.
6365
6366 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6367
6368 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6369
6370 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6371 binding" message (bug#7967).
6372
6373 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6374
6375 Fix more problems found by GCC 4.6.0's static checks.
6376
6377 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6378 Remove unused local var.
6379
6380 * editfns.c (Fmessage_box): Remove unused local var.
6381
6382 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6383 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6384 Omit unused local vars.
6385 * window.c (shrink_windows): Omit unused local var.
6386 * menu.c (digest_single_submenu): Omit unused local var.
6387 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6388 Omit unused local var.
6389
6390 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6391 Don't assume string length fits in int.
6392 (keyremap_step, read_key_sequence): Use size_t for sizes.
6393 (read_key_sequence): Don't check last_real_key_start redundantly.
6394
6395 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6396 instead of alloca (Bug#8344).
6397
6398 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6399 (Fbacktrace_frame): Don't assume nframes fits in int.
6400
6401 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6402
6403 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6404 concerns.
6405
6406 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6407
6408 * cm.c (calccost): Turn while-do into do-while, for clarity.
6409
6410 * keyboard.c (syms_of_keyboard): Use the same style as later
6411 in this function when indexing through an array. This also
6412 works around GCC bug 48267.
6413
6414 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6415
6416 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6417
6418 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6419 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6420
6421 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6422 This avoids undefined behavior on integer overflow, and is a bit
6423 more convenient anyway since it is compared to a size_t variable.
6424
6425 Variadic C functions now count arguments with size_t, not int.
6426 This avoids an unnecessary limitation on 64-bit machines, which
6427 caused (substring ...) to crash on large vectors (Bug#8344).
6428 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6429 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6430 All variadic functions and their callers changed accordingly.
6431 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6432 * data.c (arith_driver, float_arith_driver): Likewise.
6433 * editfns.c (general_insert_function): Likewise.
6434 * eval.c (struct backtrace.nargs, interactive_p)
6435 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6436 (funcall_lambda, mark_backtrace): Likewise.
6437 * fns.c (concat): Likewise.
6438 * frame.c (x_set_frame_parameters): Likewise.
6439 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6440 0 if not found, not -1. All callers changed.
6441
6442 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6443 (stack_copy_size): Now size_t, not int.
6444 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6445
6446 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6447
6448 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6449 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6450 All callers changed.
6451
6452 * lisp.h (multibyte_char_to_unibyte):
6453 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6454 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6455 * character.h (CHAR_TO_BYTE8):
6456 * cmds.c (internal_self_insert):
6457 * editfns.c (general_insert_function):
6458 * keymap.c (push_key_description):
6459 * search.c (Freplace_match):
6460 * xdisp.c (message_dolog, set_message_1): All callers changed.
6461
6462 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6463
6464 * keyboard.c (safe_run_hook_funcall): New function.
6465 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6466 don't set the hook to nil, but remove the offending function instead.
6467 (Qcommand_hook_internal): Remove, unused.
6468 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6469 Vcommand_hook_internal.
6470
6471 * eval.c (enum run_hooks_condition): Remove.
6472 (funcall_nil, funcall_not): New functions.
6473 (run_hook_with_args): Call each function through a `funcall' argument.
6474 Remove `cond' argument, now redundant.
6475 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6476 (Frun_hook_with_args_until_failure): Adjust accordingly.
6477 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6478
6479 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6480
6481 * dispextern.h (string_buffer_position): Remove declaration.
6482
6483 * print.c (strout): Remove parameter `multibyte', unused since
6484 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6485
6486 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6487 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6488 All callers changed.
6489
6490 * w32.c (_wsa_errlist): Use braces for struct initializers.
6491
6492 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6493 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6494 All callers changed.
6495 (string_buffer_position): Likewise. Also, make static (it's never
6496 used outside xdisp.c).
6497 (cursor_row_p): Remove parameter `w', unused since
6498 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6499 (decode_mode_spec): Remove parameter `precision', introduced during
6500 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6501 All callers changed.
6502
6503 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6504
6505 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6506
6507 2011-03-27 Anders Lindgren <andlind@gmail.com>
6508
6509 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6510 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6511 (ns_update_auto_hide_menu_bar): New functions.
6512 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6513 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6514 ns_constrain_all_frames.
6515 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6516 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6517
6518 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6519
6520 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6521
6522 2011-03-27 Glenn Morris <rgm@gnu.org>
6523
6524 * syssignal.h: Replace RETSIGTYPE with void.
6525 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6526 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6527 Replace SIGTYPE with void everywhere.
6528 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6529 * s/template.h (SIGTYPE): Remove commented out definition.
6530
6531 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6532
6533 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6534 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6535
6536 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6537
6538 * w32.c (read_unc_volume): Use parameter `henum', instead of
6539 global variable `wget_enum_handle'.
6540
6541 * keymap.c (describe_vector): Remove parameters `indices' and
6542 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6543 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6544
6545 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6546
6547 * keyboard.c (timer_check): Remove parameter `do_it_now',
6548 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6549 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6550 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6551
6552 * keyboard.c (read_char):
6553 * w32menu.c (w32_menu_display_help):
6554 * xmenu.c (show_help_event, menu_help_callback):
6555 Adjust calls to `show_help_echo'.
6556
6557 * gtkutil.c (xg_maybe_add_timer):
6558 * keyboard.c (readable_events):
6559 * process.c (wait_reading_process_output):
6560 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6561
6562 * insdel.c (adjust_markers_gap_motion):
6563 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6564 (gap_left, gap_right): Don't call it.
6565
6566 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6567
6568 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6569 incurred during fontification.
6570
6571 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6572
6573 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6574 (DEFVAR_PER_BUFFER): Don't pass it.
6575
6576 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6577 (scrolling_window): Don't pass it.
6578
6579 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6580
6581 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6582
6583 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6584 and `suffix'.
6585 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6586 of variables specific to SELinux and computation of `encoded_absname'.
6587
6588 * image.c (XPutPixel): Remove unused variable `height'.
6589
6590 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6591
6592 * unexw32.c (get_section_info): Remove unused variable `section'.
6593
6594 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6595 (system_process_attributes): Remove unused variable `sess'.
6596 (sys_read): Remove unused variable `err'.
6597
6598 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6599 (w32_wnd_proc): Remove unused variable `isdead'.
6600 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6601 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6602 (x_create_tip_frame): Remove unused variable `tem'.
6603
6604 * w32inevt.c (w32_console_read_socket):
6605 Remove unused variable `no_events'.
6606
6607 * w32term.c (x_draw_composite_glyph_string_foreground):
6608 Remove unused variable `width'.
6609
6610 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6611
6612 * w32term.c (x_set_glyph_string_clipping):
6613 Don't pass uninitialized region to CombineRgn.
6614
6615 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6616
6617 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6618 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6619 (Fx_close_connection): Remove unused variable `i'.
6620
6621 * w32font.c (w32font_draw): Return number of glyphs.
6622 (w32font_open_internal): Remove unused variable `i'.
6623 (w32font_driver): Add missing initializer.
6624
6625 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6626 (fill_in_menu): Remove unused variable `items_added'.
6627
6628 * w32term.c (last_mouse_press_frame): Remove static global variable.
6629 (w32_clip_to_row): Remove unused variable `f'.
6630 (x_delete_terminal): Remove unused variable `i'.
6631
6632 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6633 (NOTHING): Remove unused static global variable.
6634 (uniscribe_check_otf): Remove unused variable `table'.
6635 (uniscribe_font_driver): Add missing initializers.
6636
6637 2011-03-23 Julien Danjou <julien@danjou.info>
6638
6639 * term.c (Fsuspend_tty, Fresume_tty):
6640 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6641 * window.c (temp_output_buffer_show):
6642 * insdel.c (signal_before_change):
6643 * frame.c (Fhandle_switch_frame):
6644 * fileio.c (Fdo_auto_save):
6645 * emacs.c (Fkill_emacs):
6646 * editfns.c (save_excursion_restore):
6647 * cmds.c (internal_self_insert):
6648 * callint.c (Fcall_interactively):
6649 * buffer.c (Fkill_all_local_variables):
6650 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6651 Use Frun_hooks.
6652 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6653 unconditionnaly since it does the check itself.
6654
6655 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6656
6657 Fix more problems found by GCC 4.5.2's static checks.
6658
6659 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6660 the first time through the loop, since we know p0 < p1 then.
6661 This also avoids a gcc -Wstrict-overflow warning.
6662
6663 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6664 leading to a memory leak, possible in functions like
6665 load_charset_map_from_file that can allocate an unbounded number
6666 of objects (Bug#8318).
6667
6668 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6669 that could (at least in theory) be that large.
6670
6671 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6672 This is less likely to overflow, and avoids undefined behavior if
6673 overflow does occur. All callers changed. Use strtoul to scan
6674 for the unsigned long integer.
6675 (pint2hrstr): Simplify and tune code slightly.
6676 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6677
6678 * scroll.c (do_scrolling): Work around GCC bug 48228.
6679 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6680
6681 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6682 This also avoids a warning with gcc -Wstrict-overflow.
6683 (validate_x_resource_name): Simplify count usage.
6684 This also avoids a warning with gcc -Wstrict-overflow.
6685
6686 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6687 fail (Bug#8306).
6688
6689 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6690
6691 * process.c (Fmake_network_process): Use socklen_t, not int,
6692 where POSIX says socklen_t is required in portable programs.
6693 This fixes a porting bug on hosts like 64-bit HP-UX, where
6694 socklen_t is wider than int (Bug#8277).
6695 (Fmake_network_process, server_accept_connection):
6696 (wait_reading_process_output, read_process_output):
6697 Likewise.
6698
6699 * process.c: Rename or move locals to avoid shadowing.
6700 (list_processes_1, Fmake_network_process):
6701 (read_process_output_error_handler, exec_sentinel_error_handler):
6702 Rename or move locals.
6703 (Fmake_network_process): Define label "retry_connect" only if needed.
6704 (Fnetwork_interface_info): Fix pointer signedness.
6705 (process_send_signal): Add cast to avoid pointer signedness problem.
6706 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6707 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6708
6709 Make tparam.h and terminfo.c consistent.
6710 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6711 Include tparam.h instead, since it declares them.
6712 * cm.h (PC): Remove extern decl; tparam.h now does this.
6713 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6714 * terminfo.c: Include tparam.h, to check interfaces.
6715 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6716 (tparam): Adjust signature to match interface in tparam.h;
6717 this removes some undefined behavior. Check that outstring and len
6718 are zero, which they always are with Emacs.
6719 * tparam.h (PC, BC, UP): New extern decls.
6720
6721 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6722 (xftfont_open): Rename locals to avoid shadowing.
6723
6724 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6725 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6726 (OTF_TAG_SYM): Omit macro if not needed.
6727 (ftfont_list): Remove unused local.
6728 (get_adstyle_property, ftfont_pattern_entity):
6729 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6730 Rename locals to avoid shadowing.
6731
6732 * xfont.c (xfont_list_family): Mark var as initialized.
6733
6734 * xml.c (make_dom): Now static.
6735
6736 * composite.c (composition_compute_stop_pos): Rename local to
6737 avoid shadowing.
6738 (composition_reseat_it): Remove unused locals.
6739 (find_automatic_composition, composition_adjust_point): Likewise.
6740 (composition_update_it): Mark var as initialized.
6741 (find_automatic_composition): Mark vars as initialized,
6742 with a FIXME (Bug#8290).
6743
6744 character.h: Rename locals to avoid shadowing.
6745 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6746 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6747 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6748 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6749 to avoid shadowing.
6750
6751 * textprop.c (property_change_between_p): Remove; unused.
6752
6753 * intervals.c (interval_start_pos): Now static.
6754
6755 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6756
6757 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6758 Rename locals to avoid shadowing.
6759
6760 * sound.c (wav_play, au_play, Fplay_sound_internal):
6761 Fix pointer signedness.
6762 (alsa_choose_format): Remove unused local var.
6763 (wav_play): Initialize a variable to 0, to prevent undefined
6764 behavior (Bug#8278).
6765
6766 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6767
6768 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6769
6770 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6771 clobbering (Bug#8298).
6772 * sysdep.c (sys_subshell): Likewise.
6773 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6774
6775 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6776 This should get cleaned up, so that child_setup has the
6777 same signature on all platforms.
6778
6779 * callproc.c (call_process_cleanup): Now static.
6780 (relocate_fd): Rename locals to avoid shadowing.
6781
6782 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6783
6784 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6785 not to be necessary, and produces flickering.
6786
6787 2011-03-20 Glenn Morris <rgm@gnu.org>
6788
6789 * config.in: Remove file.
6790
6791 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6792
6793 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6794 are now in src/globals.h.
6795 (syms_of_minibuf): Remove spurious & from previous change.
6796
6797 2011-03-20 Leo <sdl.web@gmail.com>
6798
6799 * minibuf.c (completing-read-function): New variable.
6800 (completing-read-default): Rename from completing-read.
6801 (completing-read): Call completing-read-function.
6802
6803 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6804
6805 * xfaces.c (Fx_load_color_file):
6806 Read color file from absolute filename (bug#8250).
6807
6808 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6809
6810 * makefile.w32-in: Update dependencies.
6811
6812 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6813
6814 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6815
6816 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6817
6818 Fix more problems found by GCC 4.5.2's static checks.
6819
6820 * process.c (make_serial_process_unwind, send_process_trap):
6821 (sigchld_handler): Now static.
6822
6823 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6824 That way, the code declares only the vars that it needs.
6825 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6826 * s/cygwin.h (PTY_ITERATION): Likewise.
6827 * s/darwin.h (PTY_ITERATION): Likewise.
6828 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6829
6830 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6831 * process.c (allocate_pty): Don't declare stb unless it's needed.
6832
6833 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6834 (CONSTANTLIM): Remove; unused.
6835 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6836 Define only if needed.
6837
6838 * unexelf.c (unexec): Name an expression,
6839 to avoid gcc -Wbad-function-cast warning.
6840 Use a different way to cause a compilation error if anyone uses
6841 n rather than nn, a way that does not involve shadowing.
6842 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6843
6844 * deps.mk (unexalpha.o): Remove; unused.
6845
6846 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6847 * unexec.h: New file.
6848 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6849 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6850 Depend on unexec.h.
6851 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6852 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6853 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6854 Change as necessary to match prototype in unexec.h.
6855
6856 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6857 shadowing.
6858 (back_comment, skip_chars): Mark vars as initialized.
6859
6860 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6861 Rename locals to avoid shadowing.
6862
6863 * lread.c (read1): Rewrite so as not to use empty "else".
6864 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6865
6866 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6867
6868 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6869 warning when compiling print.c.
6870
6871 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6872 instead of using an uninitialized var.
6873 (font_sort_entities): Mark var as initialized.
6874
6875 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6876
6877 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6878 pointers to constants.
6879 (font_parse_fcname): Remove unused vars.
6880 (font_delete_unmatched): Now static.
6881 (font_get_spec): Remove; unused.
6882 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6883 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6884 Rename or move locals to avoid shadowing.
6885
6886 * fns.c (require_nesting_list, require_unwind): Now static.
6887 (Ffillarray): Rename locals to avoid shadowing.
6888
6889 * floatfns.c (domain_error2): Define only if needed.
6890 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6891
6892 * alloc.c (mark_backtrace): Move decl from here ...
6893 * lisp.h: ... to here, so that it can be checked.
6894
6895 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6896 (Fdefvar): Rewrite so as not to use empty "else".
6897 (lisp_indirect_variable): Name an expression,
6898 to avoid gcc -Wbad-function-cast warning.
6899 (Fdefvar): Rename locals to avoid shadowing.
6900
6901 * callint.c (quotify_arg, quotify_args): Now static.
6902 (Fcall_interactively): Rename locals to avoid shadowing.
6903 Use const pointer when appropriate.
6904
6905 * lisp.h (get_system_name, get_operating_system_release):
6906 Move decls here, to check interfaces.
6907 * process.c (get_operating_system_release): Move decl to lisp.h.
6908 * xrdb.c (get_system_name): Likewise.
6909 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6910 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6911 some of which prompt warnings from gcc -Wbad-function-cast.
6912 (Fformat_time_string, Fencode_time, Finsert_char):
6913 (Ftranslate_region_internal, Fformat):
6914 Rename or remove local vars to avoid shadowing.
6915 (Ftranslate_region_internal): Mark var as initialized.
6916
6917 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6918 avoid shadowing.
6919
6920 * lisp.h (eassert): Check that the argument compiles, even if
6921 ENABLE_CHECKING is not defined.
6922
6923 * data.c (Findirect_variable): Name an expression, to avoid
6924 gcc -Wbad-function-cast warning.
6925 (default_value, arithcompare, arith_driver, arith_error): Now static.
6926 (store_symval_forwarding): Rename local to avoid shadowing.
6927 (Fmake_variable_buffer_local, Fmake_local_variable):
6928 Mark variables as initialized.
6929 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6930
6931 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6932 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6933 Rename locals to avoid shadowing.
6934 (mark_stack): Move local variables into the #ifdef region where
6935 they're used.
6936 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6937 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6938 needed otherwise.
6939 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6940 (GC_STRING_CHARS): Remove; not used.
6941 (Fmemory_limit): Cast sbrk's returned value to char *.
6942
6943 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6944 avoids undefined behavior in theory.
6945
6946 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6947
6948 Use functions, not macros, for up- and down-casing (Bug#8254).
6949 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6950 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6951 to use the following functions instead of these macros.
6952 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6953 EMACS_INT, since callers assume the returned value fits in int.
6954 (upcase1): Likewise, for UPCASE_TABLE.
6955 (uppercasep, lowercasep, upcase): New static inline functions.
6956 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6957 the race-condition problem in the old DOWNCASE.
6958
6959 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6960 Rename locals to avoid shadowing.
6961 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6962 (regex_compile, re_search_2, re_match_2_internal):
6963 Remove unused local vars.
6964 (FREE_VAR): Rewrite so as not to use empty "else",
6965 which gcc can warn about.
6966 (regex_compile, re_match_2_internal): Mark locals as initialized.
6967 (RETALLOC_IF): Define only if needed.
6968 (WORDCHAR_P): Likewise. This one is never needed, but is used
6969 only in a comment talking about a compiler bug, so put inside
6970 the #if 0 of that comment.
6971 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6972 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6973 Remove; unused.
6974
6975 * search.c (boyer_moore): Rename locals to avoid shadowing.
6976 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6977 (PREV_CHAR_BOUNDARY): Likewise.
6978
6979 * search.c (simple_search): Remove unused var.
6980
6981 * dired.c (compile_pattern): Move decl from here ...
6982 * lisp.h: ... to here, so that it can be checked.
6983 (struct re_registers): New forward decl.
6984
6985 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6986
6987 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6988 All uses changed.
6989 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6990 Rename locals to avoid shadowing.
6991 (Fvertical_motion): Mark locals as initialized.
6992
6993 * casefiddle.c (casify_object, casify_region): Now static.
6994 (casify_region): Mark local as initialized.
6995
6996 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6997
6998 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6999 New macros, so that the caller can use some names other than
7000 gcpro1, gcpro2, etc.
7001 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7002 of the new macros.
7003 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7004 argument, for consistency with GCPRO2_VAR, etc: it is now the
7005 prefix of the variable, not the variable itself. All uses
7006 changed.
7007 * dired.c (directory_files_internal, file_name_completion):
7008 Rename locals to avoid shadowing.
7009
7010 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7011 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7012 dired.c's scmp function, had undefined behavior.
7013 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7014 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7015 * buffer.h: ... to here, because these macros use current_buffer,
7016 and the new implementation with inline functions needs to have
7017 current_buffer in scope now, rather than later when the macros
7018 are used.
7019 (downcase, upcase1): New static inline functions.
7020 (DOWNCASE, UPCASE1): Reimplement using these functions.
7021 This avoids undefined behavior in expressions like
7022 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7023 from race conditions in accessing the global variables
7024 case_temp1 and case_temp2.
7025 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7026 * lisp.h (case_temp1, case_temp2): Remove their decls.
7027 * character.h (ASCII_CHAR_P): Move from here ...
7028 * lisp.h: ... to here, so that the inline functions mentioned
7029 above can use them.
7030
7031 * dired.c (directory_files_internal_unwind): Now static.
7032
7033 * fileio.c (file_name_as_directory, directory_file_name):
7034 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7035 Now static.
7036 (file_name_as_directory): Use const pointers when appropriate.
7037 (Fexpand_file_name): Likewise. In particular, newdir might
7038 point at constant storage, so make it a const pointer.
7039 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7040 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7041 signedness issues.
7042 (Fset_file_times, Finsert_file_contents, auto_save_error):
7043 Rename locals to avoid shadowing.
7044
7045 * minibuf.c (choose_minibuf_frame_1): Now static.
7046 (Ftry_completion, Fall_completions): Rename or remove locals
7047 to avoid shadowing.
7048
7049 * marker.c (bytepos_to_charpos): Remove; unused.
7050
7051 * lisp.h (verify_bytepos, count_markers): New decls,
7052 so that gcc does not warn that these functions aren't declared.
7053
7054 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7055 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7056 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7057 (copy_text): Remove unused local var.
7058
7059 * filelock.c (within_one_second): Now static.
7060 (lock_file_1): Rename local to avoid shadowing.
7061
7062 * buffer.c (fix_overlays_before): Mark locals as initialized.
7063 (fix_start_end_in_overlays): Likewise. This function should be
7064 simplified by using pointers-to-pointers, but that's a different
7065 matter.
7066 (switch_to_buffer_1): Now static.
7067 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7068 (report_overlay_modification): Rename locals to avoid shadowing.
7069
7070 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7071 Fix pointer signedness issue.
7072 (sys_subshell): Mark local as volatile if checking for lint,
7073 to suppress a gcc -Wclobbered warning that does not seem to be right.
7074 (MAXPATHLEN): Define only if needed.
7075
7076 * process.c (serial_open, serial_configure): Move decls from here ...
7077 * systty.h: ... to here, so that they can be checked.
7078
7079 * fns.c (get_random, seed_random): Move extern decls from here ...
7080 * lisp.h: ... to here, so that they can be checked.
7081
7082 * sysdep.c (reset_io): Now static.
7083 (wait_for_termination_signal): Remove; unused.
7084
7085 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7086 (copy_keymap_item, append_key, push_text_char_description):
7087 Now static.
7088 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7089 (DENSE_TABLE_SIZE): Remove; unused.
7090 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7091 (describe_map_tree):
7092 Rename locals to avoid shadowing.
7093
7094 * keyboard.c: Declare functions static if they are not used elsewhere.
7095 (echo_char, echo_dash, cmd_error, top_level_2):
7096 (poll_for_input, handle_async_input): Now static.
7097 (read_char, kbd_buffer_get_event, make_lispy_position):
7098 (make_lispy_event, make_lispy_movement, apply_modifiers):
7099 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7100 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7101 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7102 (read_key_sequence, read_char): Mark locals as initialized.
7103 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7104
7105 * keyboard.h (make_ctrl_char): New decl.
7106 (mark_kboards): Move decl here ...
7107 * alloc.c (mark_kboards): ... from here.
7108
7109 * lisp.h (force_auto_save_soon): New decl.
7110
7111 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7112 (DEFINE_DUMMY_FUNCTION): New macro.
7113 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7114 Use it.
7115 (main): Add casts to avoid warnings
7116 if GCC considers string literals to be constants.
7117
7118 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7119
7120 * dbusbind.c: Pointer signedness fixes.
7121 (xd_signature, xd_append_arg, xd_initialize):
7122 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7123 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7124 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7125 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7126
7127 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7128 if GCC considers string literals to be constants.
7129 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7130
7131 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7132
7133 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7134 (print_preprocess, print_object): New macro to fix last change.
7135
7136 * print.c (print_preprocess): Don't forget font objects.
7137
7138 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7139
7140 * emacs.c (USAGE3): Doc fixes.
7141
7142 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7143
7144 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7145 structure.
7146
7147 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7148
7149 * lisp.h (VWindow_system, Qfile_name_history):
7150 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7151 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7152 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7153
7154 * w32select.c: Don't #include "keyboard.h".
7155 (run_protected): Add extern declaration for waiting_for_input.
7156
7157 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7158 * w32console.c (detect_input_pending, read_input_pending)
7159 (encode_terminal_code):
7160 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7161 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7162 (w32_system_caret_y, Qfile_name_history):
7163 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7164 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7165 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7166 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7167 * w32proc.c (Qlocal, report_file_error):
7168 * w32term.c (Vwindow_system, updating_frame):
7169 * w32uniscribe.c (initialized, uniscribe_font_driver):
7170 Remove unneeded extern declarations.
7171
7172 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7173
7174 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7175
7176 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7177
7178 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7179 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7180 These macros can no longer be used for assignment.
7181
7182 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7183 Assign struct members directly, instead of using BUF_BEGV etc.
7184 (record_buffer_markers, fetch_buffer_markers): New functions for
7185 recording and fetching special buffer markers.
7186 (set_buffer_internal_1, set_buffer_temp): Use them.
7187
7188 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7189
7190 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7191
7192 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7193 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7194
7195 * xdisp.c (hscroll_window_tree):
7196 (reconsider_clip_changes): Use PT instead of BUF_PT.
7197
7198 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7199
7200 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7201 $(EMACS_ROOT)/lib/intprops.h.
7202
7203 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7204
7205 Fix more problems found by GCC 4.5.2's static checks.
7206
7207 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7208 to unsigned char * to avoid compiler diagnostic.
7209 (xg_free_frame_widgets): Make it clear that a local variable is
7210 needed only if USE_GTK_TOOLTIP.
7211 (gdk_window_get_screen): Make it clear that this macro is needed
7212 only if USE_GTK_TOOLTIP.
7213 (int_gtk_range_get_value): New function, which avoids a diagnostic
7214 from gcc -Wbad-function-cast.
7215 (xg_set_toolkit_scroll_bar_thumb): Use it.
7216 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7217 diagnostic from gcc -Wbad-function-cast.
7218 (get_utf8_string, xg_get_file_with_chooser):
7219 Rename locals to avoid shadowing.
7220 (create_dialog): Move locals to avoid shadowing.
7221
7222 * xgselect.c (xg_select): Remove unused var.
7223
7224 * image.c (four_corners_best): Mark locals as initialized.
7225 (gif_load): Initialize transparent_p to zero (Bug#8238).
7226 Mark another local as initialized.
7227 (my_png_error, my_error_exit): Mark with NO_RETURN.
7228
7229 * image.c (clear_image_cache): Now static.
7230 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7231 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7232 (x_edge_detection): Remove unnecessary cast that
7233 gcc -Wbad-function-cast diagnoses.
7234 (gif_load): Fix pointer signedness.
7235 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7236 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7237
7238 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7239
7240 Improve quality of tests for time stamp overflow.
7241 For example, without this patch (encode-time 0 0 0 1 1
7242 1152921504606846976) returns the obviously-bogus value (-948597
7243 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7244 reports time overflow. See
7245 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7246 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7247 * editfns.c: Include limits.h and intprops.h.
7248 (TIME_T_MIN, TIME_T_MAX): New macros.
7249 (time_overflow): Move earlier, to before first use.
7250 (hi_time, lo_time): New functions, for an accurate test for
7251 out-of-range times.
7252 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7253 (Fget_internal_run_time): Don't assume time_t fits in int.
7254 (make_time): Use list2 instead of Fcons twice.
7255 (Fdecode_time): More accurate test for out-of-range times.
7256 (check_tm_member): New function.
7257 (Fencode_time): Use it, to test for out-of-range times.
7258 (lisp_time_argument): Don't rely on undefined left-shift and
7259 right-shift behavior when checking for time stamp overflow.
7260
7261 * editfns.c (time_overflow): New function, refactoring common code.
7262 (Fformat_time_string, Fdecode_time, Fencode_time):
7263 (Fcurrent_time_string): Use it.
7264
7265 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7266 * dired.c (make_time): Move to ...
7267 * editfns.c (make_time): ... here.
7268 * systime.h: Note the move.
7269
7270 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7271
7272 * fringe.c (update_window_fringes): Remove unused variables.
7273
7274 * unexmacosx.c (copy_data_segment): Also copy __got section.
7275 (Bug#8223)
7276
7277 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7278
7279 * termcap.c [MSDOS]: Include "msdos.h".
7280 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7281 Constify `char *' arguments and their references according to
7282 prototypes in tparam.h.
7283
7284 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7285
7286 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7287 Adapt all references accordingly.
7288
7289 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7290
7291 2011-03-11 Tom Tromey <tromey@redhat.com>
7292
7293 * buffer.c (syms_of_buffer): Remove obsolete comment.
7294
7295 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7296
7297 * termhooks.h (encode_terminal_code): Declare prototype.
7298
7299 * msdos.c (encode_terminal_code): Don't declare prototype.
7300
7301 * term.c (encode_terminal_code): Now external again, used by
7302 w32console.c and msdos.c.
7303
7304 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7305 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7306
7307 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7308
7309 Fix some minor problems found by GCC 4.5.2's static checks.
7310
7311 * fringe.c (update_window_fringes): Mark locals as initialized
7312 (Bug#8227).
7313 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7314
7315 * alloc.c (mark_fringe_data): Move decl from here ...
7316 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7317 to check its interface.
7318 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7319
7320 * fontset.c (free_realized_fontset): Now static.
7321 (Fset_fontset_font): Rename local to avoid shadowing.
7322 (fontset_font): Mark local as initialized.
7323 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7324
7325 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7326
7327 * xselect.c (x_disown_buffer_selections): Remove; not used.
7328 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7329 (x_own_selection, Fx_disown_selection_internal): Rename locals
7330 to avoid shadowing.
7331 (x_handle_dnd_message): Remove local to avoid shadowing.
7332
7333 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7334 so that the caller can use some name other than gcpro1.
7335 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7336 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7337 (Fx_backspace_delete_keys_p):
7338 Use them to avoid shadowing, and rename vars to avoid shadowing.
7339 (x_decode_color, x_set_name, x_window): Now static.
7340 (Fx_create_frame): Add braces to silence GCC warning.
7341 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7342 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7343 Remove unused locals.
7344 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7345 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7346 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7347 macros.
7348
7349 * xterm.h (x_mouse_leave): New decl.
7350
7351 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7352 Remove unused functions.
7353 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7354 (x_calc_absolute_position): Now static.
7355 (XTread_socket): Don't define label "out" unless it's used.
7356 Don't declare local "event" unless it's used.
7357 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7358 unless they are used.
7359 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7360 (x_fatal_error_signal): Remove; not used.
7361 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7362 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7363 (x_error_catcher, x_connection_closed, x_error_handler):
7364 (x_error_quitter, xembed_send_message, x_iconify_frame):
7365 (my_log_handler): Rename locals to avoid shadowing.
7366 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7367 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7368
7369 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7370 Rename or move locals to avoid shadowing.
7371 (tty_defined_color, merge_face_heights): Now static.
7372 (free_realized_faces_for_fontset): Remove; not used.
7373 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7374 does not deduce is never used uninitialized.
7375 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7376 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7377
7378 * terminal.c (store_terminal_param): Now static.
7379
7380 * xmenu.c (menu_highlight_callback): Now static.
7381 (set_frame_menubar): Remove unused local.
7382 (xmenu_show): Rename parameter to avoid shadowing.
7383 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7384 since they might point to immutable storage.
7385 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7386 since it's unused otherwise.
7387
7388 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7389 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7390 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7391 avoids a gcc -Wuninitialized diagnostic.
7392 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7393 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7394 does not deduce are never used uninitialized.
7395
7396 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7397
7398 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7399 * window.c (window_loop, size_window):
7400 (run_window_configuration_change_hook, enlarge_window): Likewise.
7401
7402 * window.c (display_buffer): Now static.
7403 (size_window): Mark variables that gcc -Wuninitialized
7404 does not deduce are never used uninitialized.
7405 * window.h (check_all_windows): New decl, to forestall
7406 gcc -Wmissing-prototypes diagnostic.
7407 * dispextern.h (bidi_dump_cached_states): Likewise.
7408
7409 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7410 shadowing.
7411 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7412 Include <limits.h>.
7413 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7414 and to avoid gcc -Wuninitialized warning.
7415 (load_charset_map): Mark variables that gcc -Wuninitialized
7416 does not deduce are never used uninitialized.
7417 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7418
7419 * coding.c (coding_set_source, coding_set_destination):
7420 Use "else { /* comment */ }" rather than "else /* comment */;"
7421 for clarity, and to avoid gcc -Wempty-body warning.
7422 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7423 a block, when the outer 'i' will do.
7424 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7425 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7426 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7427 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7428 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7429 Rename locals to avoid shadowing.
7430 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7431 * coding.c (emacs_mule_char, encode_invocation_designation):
7432 Now static, since they're not used elsewhere.
7433 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7434 (decode_coding_object, encode_coding_object, detect_coding_system):
7435 (decode_coding_emacs_mule): Mark variables that gcc
7436 -Wuninitialized does not deduce are never used uninitialized.
7437 (detect_coding_iso_2022): Initialize a local variable that might
7438 be used uninitialized. Leave a FIXME because it's not clear that
7439 this initialization is needed. (Bug#8211)
7440 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7441 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7442 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7443 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7444 Remove unused macros.
7445
7446 * category.c (hash_get_category_set): Remove unused local var.
7447 (copy_category_table): Now static, since it's not used elsewhere.
7448 * character.c (string_count_byte8): Likewise.
7449
7450 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7451 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7452
7453 * chartab.c (copy_sub_char_table): Now static, since it's not used
7454 elsewhere.
7455 (sub_char_table_ref_and_range, char_table_ref_and_range):
7456 Rename locals to avoid shadowing.
7457 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7458
7459 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7460 (BIDI_BOB): Remove unused macro.
7461
7462 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7463 deduce are never used uninitialized.
7464 * term.c (encode_terminal_code): Likewise.
7465
7466 * term.c (encode_terminal_code): Now static. Remove unused local.
7467
7468 * tparam.h: New file.
7469 * term.c, tparam.h: Include it.
7470 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7471 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7472 Move these decls to tparam.h, and make them agree with what
7473 is actually in tparam.c. The previous trick of using incompatible
7474 decls in different modules does not conform to the C standard.
7475 All callers of tparam changed to use tparam's actual API.
7476 * tparam.c (tparam1, tparam, tgoto):
7477 Use const pointers where appropriate.
7478
7479 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7480 * cm.h (struct cm): Likewise.
7481 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7482 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7483 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7484 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7485 (turn_on_face, init_tty): Likewise.
7486 * termchar.h (struct tty_display_info): Likewise.
7487
7488 * term.c (term_mouse_position): Rename local to avoid shadowing.
7489
7490 * alloc.c (mark_ttys): Move decl from here ...
7491 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7492
7493 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7494
7495 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7496
7497 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7498
7499 * search.c (compile_pattern_1): Remove argument regp, unused since
7500 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7501 (compile_pattern): Don't pass it.
7502
7503 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7504
7505 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7506 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7507 for ! HAVE_GTK3.
7508 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7509
7510 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7511
7512 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7513 gdk_window_get_screen, gdk_window_get_geometry,
7514 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7515 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7516 (xg_get_pixbuf_from_pixmap): New function.
7517 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7518 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7519 Call xg_get_pixbuf_from_pixmap instead of
7520 gdk_pixbuf_get_from_drawable.
7521 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7522 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7523 (xg_check_special_colors): Use GtkStyleContext and its functions
7524 for HAVE_GTK3.
7525 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7526 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7527 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7528 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7529 Call gtk_widget_get_preferred_size.
7530 (xg_frame_resized): gdk_window_get_geometry only takes 5
7531 parameters.
7532 (xg_win_to_widget, xg_event_is_for_menubar):
7533 Call gdk_x11_window_lookup_for_display.
7534 (xg_set_widget_bg): New function.
7535 (delete_cb): New function.
7536 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7537 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7538 (xg_set_background_color): Call xg_set_widget_bg.
7539 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7540 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7541 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7542 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7543 if ! HAVE_GTK3.
7544 (update_frame_tool_bar): Call gtk_widget_hide.
7545 (xg_initialize): Use GDK_KEY_g.
7546
7547 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7548 if ! HAVE_GTK3
7549 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7550
7551 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7552 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7553 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7554
7555 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7556
7557 * w32xfns.c (select_palette): Check success of RealizePalette against
7558 GDI_ERROR, not zero.
7559
7560 See ChangeLog.11 for earlier changes.
7561
7562 ;; Local Variables:
7563 ;; coding: utf-8
7564 ;; End:
7565
7566 Copyright (C) 2011 Free Software Foundation, Inc.
7567
7568 This file is part of GNU Emacs.
7569
7570 GNU Emacs is free software: you can redistribute it and/or modify
7571 it under the terms of the GNU General Public License as published by
7572 the Free Software Foundation, either version 3 of the License, or
7573 (at your option) any later version.
7574
7575 GNU Emacs is distributed in the hope that it will be useful,
7576 but WITHOUT ANY WARRANTY; without even the implied warranty of
7577 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7578 GNU General Public License for more details.
7579
7580 You should have received a copy of the GNU General Public License
7581 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.