Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
1 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2
3 Use 'inline', not 'INLINE'.
4 * alloc.c, fontset.c (INLINE): Remove.
5 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10
11 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
12
13 * image.c: Various fixes to ImageMagick code comments.
14 (Fimagemagick_types): Doc fix.
15
16 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
17
18 Minor fixes prompted by GCC 4.6.0 warnings.
19
20 * xselect.c (converted_selections, conversion_fail_tag): Now static.
21
22 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
23 (x_clipboard_manager_save_all): Move extern decl to ...
24 * xterm.h: ... here, so that it can be checked for consistency.
25
26 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
27
28 * xselect.c (x_clipboard_manager_save_frame)
29 (x_clipboard_manager_save_all): New functions.
30 (Fx_clipboard_manager_save): Lisp function deleted.
31
32 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
33 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
34
35 * xterm.h: Update prototype.
36
37 2011-05-28 William Xu <william.xwl@gmail.com>
38
39 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
40 exiting (Bug#8239).
41
42 2011-05-28 Jim Meyering <meyering@redhat.com>
43
44 Avoid a sign-extension bug in crypto_hash_function.
45 * fns.c (to_uchar): Define.
46 (crypto_hash_function): Use it to convert some newly-signed
47 variables to unsigned, to avoid sign-extension bugs. For example,
48 without this change, (md5 "truc") would evaluate to
49 45723a2aff78ff4fff7fff1114760e62 rather than the expected
50 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
51 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
52
53 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
54
55 Integer overflow fixes.
56
57 * dbusbind.c: Serial number integer overflow fixes.
58 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
59 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
60 to hold a serial number that is too large for a fixnum.
61 (Fdbus_method_return_internal, Fdbus_method_error_internal):
62 Check for serial numbers out of range. Decode any serial number
63 that was so large that it became a float. (Bug#8722)
64
65 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
66 (Fdbus_call_method, Fdbus_call_method_asynchronously):
67 Use XFASTINT rather than XUINT when numbers are nonnegative.
68 (xd_append_arg, Fdbus_method_return_internal):
69 (Fdbus_method_error_internal): Likewise. Also, for unsigned
70 arguments, check that Lisp number is nonnegative, rather than
71 silently wrapping negative numbers around. (Bug#8722)
72 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
73 (Bug#8722)
74
75 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
76
77 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
78
79 ccl: add integer overflow checks
80 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
81 (IN_INT_RANGE): New macros.
82 (ccl_driver): Use them to check for integer overflow when
83 decoding a CCL program. Many of the new checks are whether XINT (x)
84 fits in int; it doesn't always, on 64-bit hosts. The new version
85 doesn't catch all possible integer overflows, but it's an
86 improvement. (Bug#8719)
87
88 * alloc.c (make_event_array): Use XINT, not XUINT.
89 There's no need for unsigned here.
90
91 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
92 This follows up to the 2011-05-06 change that substituted uintptr_t
93 for EMACS_INT. This case wasn't caught back then.
94
95 Rework Fformat to avoid integer overflow issues.
96 * editfns.c: Include <float.h> unconditionally, as it's everywhere
97 now (part of C89). Include <verify.h>.
98 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
99 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
100 (Fformat): Avoid the prepass trying to compute sizes; it was only
101 approximate and thus did not catch overflow reliably. Instead, walk
102 through the format just once, formatting and computing sizes as we go,
103 checking for integer overflow at every step, and allocating a larger
104 buffer as needed. Keep track separately whether the format is
105 multibyte. Keep only the most-recently calculated precision, rather
106 than them all. Record whether each argument has been converted to
107 string. Use EMACS_INT, not int, for byte and char and arg counts.
108 Support field widths and precisions larger than INT_MAX. Avoid
109 sprintf's undefined behavior with conversion specifications such as %#d
110 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
111 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
112 formatting out-of-range floating point numbers with int
113 formats. (Bug#8668)
114
115 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
116
117 * data.c: Avoid integer truncation in expressions involving floats.
118 * data.c: Include <intprops.h>.
119 (arith_driver): When there's an integer overflow in an expression
120 involving floating point, convert the integers to floating point
121 so that the resulting value does not suffer from catastrophic
122 integer truncation. For example, on a 64-bit host (* 4
123 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
124 Do not rely on undefined behavior after integer overflow.
125
126 merge count_size_as_multibyte, parse_str_to_multibyte
127 * character.c, character.h (count_size_as_multibyte):
128 Renamed from parse_str_to_multibyte; all uses changed.
129 Check for integer overflow.
130 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
131 since it's now a duplicate of the other. This is more of
132 a character than a buffer op, so better that it's in character.c.
133 * fns.c, print.c: Adjust to above changes.
134
135 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
136
137 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
138
139 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
140
141 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
142 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
143 (x_clipboard_manager_save): Now static.
144 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
145
146 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
147 (crypto_hash_function): Now static.
148 Fix pointer signedness problems. Avoid unnecessary initializations.
149
150 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
151
152 * termhooks.h (Vselection_alist): Make it terminal-local.
153
154 * terminal.c (create_terminal): Initialize it.
155
156 * xselect.c: Support for clipboard managers.
157 (Vselection_alist): Move to termhooks.h as terminal-local var.
158 (LOCAL_SELECTION): New macro.
159 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
160 (symbol_to_x_atom): Remove gratuitous arg.
161 (x_handle_selection_request, lisp_data_to_selection_data)
162 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
163 (x_own_selection, x_get_local_selection, x_convert_selection): New
164 arg, specifying work frame. Use terminal-local Vselection_alist.
165 (some_frame_on_display): Delete unused function.
166 (Fx_own_selection_internal, Fx_get_selection_internal)
167 (Fx_disown_selection_internal, Fx_selection_owner_p)
168 (Fx_selection_exists_p): New optional frame arg.
169 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
170 (x_handle_selection_clear): Don't treat other terminals with the
171 same keyboard specially. Use the terminal-local Vselection_alist.
172 (x_clear_frame_selections): Use Frun_hook_with_args.
173
174 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
175
176 * xterm.h: Add support for those atoms.
177
178 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
179
180 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
181 (converted_selections, conversion_fail_tag): New global variables.
182 (x_selection_request_lisp_error): Free the above.
183 (x_get_local_selection): Remove unnecessary code.
184 (x_reply_selection_request): Args changed; handle arbitrary array
185 of converted selections stored in converted_selections. Separate
186 the XChangeProperty and SelectionNotify steps.
187 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
188 (x_convert_selection): New function.
189 (x_handle_selection_event): Simplify.
190 (x_get_foreign_selection): Don't ignore incoming requests while
191 waiting for an answer; this will fail when we implement
192 SAVE_TARGETS, and seems unnecessary anyway.
193 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
194 (Vx_sent_selection_functions): Doc fix.
195
196 2011-05-26 Leo Liu <sdl.web@gmail.com>
197
198 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
199
200 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
201
202 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
203
204 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
205 for fringe update if it has periodic bitmap.
206 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
207 and fringe_bitmap_periodic_p.
208
209 * fringe.c (get_fringe_bitmap_data): New function.
210 (draw_fringe_bitmap_1, update_window_fringes): Use it.
211 (update_window_fringes): Record periodicity of fringe bitmap in glyph
212 row. Mark glyph row for fringe update if periodicity changed.
213
214 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
215 for fringe update unless it has periodic bitmap.
216
217 2011-05-25 Kenichi Handa <handa@m17n.org>
218
219 * xdisp.c (get_next_display_element): Set correct it->face_id for
220 a static composition.
221
222 2011-05-24 Leo Liu <sdl.web@gmail.com>
223
224 * deps.mk (fns.o):
225 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
226
227 * fns.c (crypto_hash_function, Fsha1): New function.
228 (Fmd5): Use crypto_hash_function.
229 (syms_of_fns): Add Ssha1.
230
231 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
232
233 * gnutls.c: Remove unused macros.
234 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
235 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
236 Remove macros that are defined and never used.
237 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
238
239 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
240
241 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
242 (Fx_get_selection_internal): Minor cleanup.
243 (Fx_own_selection_internal): Rename arguments for consistency with
244 select.el.
245
246 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
247
248 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
249
250 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
251
252 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
253
254 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
255
256 * dispnew.c (scrolling_window): Don't exclude the case that the
257 last enabled row in the desired matrix touches the bottom boundary.
258
259 2011-05-21 Glenn Morris <rgm@gnu.org>
260
261 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
262 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
263 and add some more files.
264
265 2011-05-20 Eli Zaretskii <eliz@gnu.org>
266
267 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
268 report_file_error introduced by the change from 2011-05-07.
269
270 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
271
272 * systime.h (Time): Define only if emacs is defined.
273 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
274 where the include path doesn't have X11/X.h by default. See
275 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
276
277 2011-05-20 Kenichi Handa <handa@m17n.org>
278
279 * composite.c (find_automatic_composition): Fix previous change.
280
281 2011-05-20 Glenn Morris <rgm@gnu.org>
282
283 * lisp.mk: New file, split from Makefile.in.
284 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
285 (shortlisp): Remove.
286 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
287
288 2011-05-19 Glenn Morris <rgm@gnu.org>
289
290 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
291 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
292 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
293 (lisp): Set the order to that of loadup.el.
294 (shortlisp): Make it a copy of $lisp.
295 (SOME_MACHINE_LISP): Remove.
296 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
297 Use just $shortlisp, not $SOME_MACHINE_LISP too.
298
299 2011-05-18 Kenichi Handa <handa@m17n.org>
300
301 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
302 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
303 (find_automatic_composition): Mostly rewrite for efficiency.
304
305 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
306
307 * makefile.w32-in: Update dependencies.
308
309 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
310
311 * menu.c: Include limits.h (fixes the MS-Windows build broken by
312 revision 104625).
313
314 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
315
316 Fix some integer overflow issues, such as string length overflow.
317
318 * insdel.c (count_size_as_multibyte): Check for string overflow.
319
320 * character.c (lisp_string_width): Check for string overflow.
321 Use EMACS_INT, not int, for string indexes and lengths; in
322 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
323 the resulting string length overflows an EMACS_INT; instead,
324 report a string overflow if no precision given. When checking for
325 precision exhaustion, use a check that cannot possibly have
326 integer overflow. (Bug#8675)
327 * character.h (lisp_string_width): Adjust to new signature.
328
329 * alloc.c (string_overflow): New function.
330 (Fmake_string): Use it. This doesn't change behavior, but saves
331 a few bytes and will simplify future changes.
332 * character.c (string_escape_byte8): Likewise.
333 * lisp.h (string_overflow): New decl.
334
335 Fixups, following up to the user-interface timestamp change.
336 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
337 for UI timestamps, instead of unsigned long.
338 * msdos.c (mouse_get_pos): Likewise.
339 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
340 * w32gui.h (Time): Define by including "systime.h" rather than by
341 declaring it ourselves. (Bug#8664)
342
343 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
344 * image.c (clear_image_cache): Likewise.
345
346 * term.c (term_mouse_position): Don't assume time_t wraparound.
347
348 Be more systematic about user-interface timestamps.
349 Before, the code sometimes used 'Time', sometimes 'unsigned long',
350 and sometimes 'EMACS_UINT', to represent these timestamps. This
351 change causes it to use 'Time' uniformly, as that's what X uses.
352 This makes the code easier to follow, and makes it easier to catch
353 integer overflow bugs such as Bug#8664.
354 * frame.c (Fmouse_position, Fmouse_pixel_position):
355 Use Time, not unsigned long, for user-interface timestamps.
356 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
357 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
358 * keyboard.h (last_event_timestamp): Likewise.
359 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
360 * menu.h (xmenu_show): Likewise.
361 * term.c (term_mouse_position): Likewise.
362 * termhooks.h (struct input_event.timestamp): Likewise.
363 (struct terminal.mouse_position_hook): Likewise.
364 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
365 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
366 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
367 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
368 what it was before.
369 * menu.h, termhooks.h: Include "systime.h", for Time.
370
371 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
372 Don't assume that the difference between two unsigned long values
373 can fit into an integer. At this point, we know button_down_time
374 <= event->timestamp, so the difference must be nonnegative, so
375 there's no need to cast the result if double-click-time is
376 nonnegative, as it should be; check that it's nonnegative, just in
377 case. This bug is triggered when events are more than 2**31 ms
378 apart (about 25 days). (Bug#8664)
379
380 * xselect.c (last_event_timestamp): Remove duplicate decl.
381 (x_own_selection): Remove needless cast to unsigned long.
382
383 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
384 that always fit in int. Use a sentinel instead of a counter, to
385 avoid a temp and to allay GCC's concerns about possible int overflow.
386 * frame.h (struct frame): Use int for menu_bar_items_used
387 instead of EMACS_INT, since it always fits in int.
388
389 * menu.c (grow_menu_items): Check for int overflow.
390
391 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
392
393 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
394 Before, the code was not consistent. These values cannot exceed
395 2**31 - 1 so there's no need to make them unsigned.
396 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
397 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
398 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
399 as modifiers.
400 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
401
402 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
403 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
404 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
405 presumably because the widths might not match.
406
407 * window.c (size_window): Avoid needless test at loop start.
408
409 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
410
411 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
412
413 2011-05-12 Drew Adams <drew.adams@oracle.com>
414
415 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
416
417 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
418
419 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
420 `width' to `bar_area_x' and `bar_area_width', respectively.
421 (x_scroll_run): Take account of fringe background extension.
422
423 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
424 Rename local vars `left' and `width' to `bar_area_x' and
425 `bar_area_width', respectively.
426 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
427 background extension.
428
429 2011-05-10 Jim Meyering <meyering@redhat.com>
430
431 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
432
433 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
434
435 * image.c (Finit_image_library): Return t for built-in image types,
436 like pbm and xbm. (Bug#8640)
437
438 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
439
440 * w32menu.c (set_frame_menubar): Fix submenu allocation.
441
442 2011-05-07 Eli Zaretskii <eliz@gnu.org>
443
444 * w32console.c (Fset_screen_color): Doc fix.
445 (Fget_screen_color): New function.
446 (syms_of_ntterm): Defsubr it.
447
448 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
449 unlink the temporary file if Fcall_process didn't create it in the
450 first place.
451 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
452 child process will be redirected to a file specified with `:file'.
453 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
454 cue to call_process_cleanup not to close that handle.
455
456 2011-05-07 Ben Key <bkey76@gmail.com>
457
458 * makefile.w32-in: The bootstrap-temacs rule now makes use of
459 one of two shell specific rules, either bootstrap-temacs-CMD or
460 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
461 to the previous implementation of the bootstrap-temacs rule.
462 The bootstrap-temacs-CMD rule is similar to the previous
463 implementation of the bootstrap-temacs rule except that it
464 makes use of the ESC_CFLAGS variable instead of the CFLAGS
465 variable.
466
467 These changes, along with some changes to nt/configure.bat,
468 nt/gmake.defs, and nt/nmake.defs, are required to extend my
469 earlier fix to add support for --cflags and --ldflags options
470 that include quotes so that it works whether make uses cmd or
471 sh as the shell.
472
473 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
474
475 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
476 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
477 is a constant.
478 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
479 a string. Handle both cases.
480 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
481 (Fdbus_register_method): Use Qinvalid_function.
482
483 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
484
485 * makefile.w32-in: Update dependencies.
486 (LISP_H): Add inttypes.h and stdin.h.
487 (PROCESS_H): Add unistd.h.
488
489 2011-05-06 Eli Zaretskii <eliz@gnu.org>
490
491 * lread.c: Include limits.h (fixes the MS-Windows build broken by
492 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
493
494 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
495
496 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
497
498 * term.c (vfatal): Remove stray call to va_end.
499 It's not needed and the C Standard doesn't allow it here anyway.
500
501 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
502 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
503
504 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
505 bytes.
506
507 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
508
509 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
510
511 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
512
513 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
514
515 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
516
517 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
518 * charset.c (Fdefine_charset_internal): Don't initialize
519 charset.code_space[15]. The value was garbage, on hosts with
520 32-bit int (Bug#8600).
521
522 * lread.c (read_integer): Be more consistent with string-to-number.
523 Use string_to_number to do the actual conversion; this avoids
524 rounding errors and fixes some other screwups. Without this fix,
525 for example, #x1fffffffffffffff was misread as -2305843009213693952.
526 (digit_to_number): Move earlier, for benefit of read_integer.
527 Return -1 if the digit is out of range for the base, -2 if it is
528 not a digit in any supported base. (Bug#8602)
529
530 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
531
532 * dispnew.c (scrolling_window): Return 1 if we scrolled,
533 to match comment at start of function. This also removes a
534 GCC warning about overflow in a 32+64-bit port.
535
536 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
537
538 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
539 Reported by Stefan Monnier in
540 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
541 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
542 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
543
544 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
545 (EMACS_UINTPTR): Likewise, with uintptr_t.
546
547 * lisp.h: Prefer 64-bit EMACS_INT if available.
548 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
549 on 32-bit hosts that have 64-bit int, so that they can access
550 large files.
551 However, temporarily disable this change unless the temporary
552 symbol WIDE_EMACS_INT is defined.
553
554 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
555
556 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
557 This removes an assumption that EMACS_INT and long are the same
558 width as pointers. The assumption is true for Emacs porting targets
559 now, but we want to make other targets possible.
560 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
561 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
562 In the rest of the code, change types of integers that hold casted
563 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
564 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
565 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
566 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
567 No need to cast type when ORing.
568 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
569 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
570 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
571 assume EMACS_INT is the same width as char *.
572 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
573 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
574 Remove no-longer-needed casts.
575 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
576 (xg_tool_bar_help_callback, xg_make_tool_item):
577 Use EMACS_INTPTR to hold an integer
578 that will be cast to void *; this can avoid a GCC warning
579 if EMACS_INT is not the same width as void *.
580 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
581 * xdisp.c (display_echo_area_1, resize_mini_window_1):
582 (current_message_1, set_message_1):
583 Use a local to convert to proper width without a cast.
584 * xmenu.c (dialog_selection_callback): Likewise.
585
586 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
587 Also, don't assume VALBITS / RAND_BITS is less than 5,
588 and don't rely on undefined behavior when shifting a 1 left into
589 the sign bit.
590 * lisp.h (get_random): Change signature to match.
591
592 * lread.c (hash_string): Use size_t, not int, for hash computation.
593 Normally we prefer signed values; but hashing is special, because
594 it's better to use unsigned division on hash table sizes so that
595 the remainder is nonnegative. Also, size_t is the natural width
596 for hashing into memory. The previous code used 'int', which doesn't
597 retain enough info to hash well into very large tables.
598 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
599
600 * dbusbind.c: Don't possibly lose pointer info when converting.
601 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
602 Use XPNTR rather than XHASH, so that the high-order bits of
603 the pointer aren't lost when converting through void *.
604
605 * eval.c (Fautoload): Don't double-shift a pointer.
606
607 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
608
609 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
610
611 * gnutls.c (DEF_GNUTLS_FN):
612 * image.c (DEF_IMGLIB_FN): Make function pointers static.
613
614 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
615
616 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
617 marker. (Bug#8610)
618
619 2011-05-05 Eli Zaretskii <eliz@gnu.org>
620
621 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
622 New version that can reserve upto 2GB of heap space.
623
624 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
625
626 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
627
628 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
629
630 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
631 `gnutls_certificate_set_x509_key_file'.
632
633 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
634
635 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
636 Update dependencies.
637
638 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
639
640 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
641 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
642 Remove unused parameter `fildes'.
643 * process.c (read_process_output, send_process): Don't pass it.
644
645 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
646
647 Fix previous change: the library cache is defined in w32.c.
648 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
649 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
650
651 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
652
653 Implement dynamic loading of GnuTLS on Windows.
654
655 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
656 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
657 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
658 Declare.
659
660 * gnutls.c (Qgnutls_dll): Define.
661 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
662 (gnutls_*): Declare function pointers.
663 (init_gnutls_functions): New function to initialize function pointers.
664 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
665 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
666 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
667 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
668 (emacs_gnutls_write, emacs_gnutls_read)
669 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
670 (Fgnutls_available_p): New function.
671 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
672 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
673 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
674
675 * image.c: Include w32.h.
676 (Vimage_type_cache): Delete.
677 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
678 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
679 (w32_delayed_load): Move to w32.c.
680
681 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
682
683 * w32.c (QCloaded_from, Vlibrary_cache): Define.
684 (w32_delayed_load): Move from image.c. When loading a library, record
685 its filename in the :loaded-from property of the library id.
686 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
687 Initialize and staticpro them.
688 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
689
690 * process.c: Include lisp.h before w32.h, not after.
691 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
692 instead of gnutls_record_check_pending.
693
694 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
695
696 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
697
698 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
699 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
700 as passed in.
701
702 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
703
704 * xterm.c (x_set_frame_alpha): Do not set property on anything
705 else than FRAME_X_OUTER_WINDOW (Bug#8608).
706
707 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
708
709 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
710
711 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
712
713 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
714 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
715 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
716 (gnutls_global_initialized, Qgnutls_bootprop_priority)
717 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
718 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
719 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
720 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
721 (Qgnutls_bootprop_callbacks_verify): Make static.
722
723 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
724
725 * callproc.c: Indentation fixup.
726
727 * sysdep.c (wait_for_termination_1): Make static.
728 (wait_for_termination, interruptible_wait_for_termination):
729 Move after wait_for_termination_1.
730
731 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
732
733 * sysdep.c (interruptible_wait_for_termination): New function
734 which is like wait_for_termination, but allows keyboard
735 interruptions.
736
737 * callproc.c (Fcall_process): Add (:file "file") as an option for
738 the STDOUT buffer.
739 (Fcall_process_region): Ditto.
740
741 2011-04-30 Eli Zaretskii <eliz@gnu.org>
742
743 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
744 rather than `XVECTOR (FOO)->size'.
745
746 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
747 inttypes.h, as a gnulib replacement is used if it not available in
748 system headers.
749
750 2011-04-21 Eli Zaretskii <eliz@gnu.org>
751
752 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
753 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
754 of MOST_POSITIVE_FIXNUM. (Bug#8528)
755
756 * coding.c (coding_alloc_by_realloc): Error out if destination
757 will grow beyond MOST_POSITIVE_FIXNUM.
758 (decode_coding_emacs_mule): Abort if there isn't enough place in
759 charbuf for the composition carryover bytes. Reserve an extra
760 space for up to 2 characters produced in a loop.
761 (decode_coding_iso_2022): Abort if there isn't enough place in
762 charbuf for the composition carryover bytes.
763
764 2011-04-21 Eli Zaretskii <eliz@gnu.org>
765
766 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
767 aborting when %lld or %lll format is passed.
768 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
769 %llo or %llx format is passed. (Bug#8545)
770
771 * window.c (window_scroll_line_based): Use a marker instead of
772 simple variables to record original value of point. (Bug#7952)
773
774 * doprnt.c (doprnt): Fix the case where a multibyte sequence
775 produced by %s or %c overflows available buffer space. (Bug#8545)
776
777 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
778
779 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
780 (SIZE_MAX): Move defn after all includes, as they might #define it.
781
782 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
783
784 * w32.c (init_environment): Warn about defaulting HOME to C:\.
785
786 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
787
788 * keyboard.c (Qdelayed_warnings_hook): Define.
789 (command_loop_1): Run `delayed-warnings-hook'
790 if Vdelayed_warnings_list is non-nil.
791 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
792 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
793
794 2011-04-28 Eli Zaretskii <eliz@gnu.org>
795
796 * doprnt.c (doprnt): Don't return value smaller than the buffer
797 size if the message was truncated. (Bug#8545).
798
799 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
800
801 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
802 (Fx_window_property): #if-0 the whole functions, not just the bodies.
803
804 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
805
806 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
807
808 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
809
810 * makefile.w32-in: Update dependencies.
811
812 2011-04-27 Eli Zaretskii <eliz@gnu.org>
813
814 Improve `doprnt' and its usage. (Bug#8545)
815 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
816 `format_end'. Remove support for %l as a conversion specifier.
817 Don't use xrealloc. Improve diagnostics when the %l size modifier
818 is used. Update the commentary.
819
820 * eval.c (verror): Simplify calculation of size_t.
821
822 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
823 messages.
824
825 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
826
827 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
828 change.
829
830 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
831
832 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
833 This makes this file independent of the recent pseudovector change.
834
835 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
836
837 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
838
839 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
840 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
841 Remove unused local.
842 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
843
844 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
845 GCC 4.6.0 optimizes based on type-based alias analysis.
846 For example, if b is of type struct buffer * and v of type struct
847 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
848 != &v->size, and therefore "v->size = 1; b->size = 2; return
849 v->size;" must therefore return 1. This assumption is incorrect
850 for Emacs, since it type-puns struct Lisp_Vector * with many other
851 types. To fix this problem, this patch adds a new type struct
852 vectorlike_header that documents the constraints on layout of vectors
853 and pseudovectors, and helps optimizing compilers not get fooled
854 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
855 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
856 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
857 the size member.
858 (XSETPVECTYPE): Rewrite in terms of new macro.
859 (XSETPVECTYPESIZE): New macro, specifying both type and size.
860 This is a bit clearer, and further avoids the possibility of
861 undesirable aliasing.
862 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
863 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
864 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
865 since Lisp_Subr is a special case (no "next" field).
866 (ASIZE): Now uses header.size rather than size.
867 All previous uses of XVECTOR (foo)->size replaced to use this macro,
868 to avoid the hassle of writing XVECTOR (foo)->header.size.
869 (struct vectorlike_header): New type.
870 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
871 object, to help avoid aliasing.
872 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
873 (SUBRP): Likewise, since Lisp_Subr is a special case.
874 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
875 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
876 (struct Lisp_Hash_Table): Combine first two members into a single
877 struct vectorlike_header member. All uses of "size" and "next" members
878 changed to be "header.size" and "header.next".
879 * buffer.h (struct buffer): Likewise.
880 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
881 * frame.h (struct frame): Likewise.
882 * process.h (struct Lisp_Process): Likewise.
883 * termhooks.h (struct terminal): Likewise.
884 * window.c (struct save_window_data, struct saved_window): Likewise.
885 * window.h (struct window): Likewise.
886 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
887 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
888 * buffer.c (init_buffer_once): Likewise.
889 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
890 special case.
891 * process.c (Fformat_network_address): Use local var for size,
892 for brevity.
893
894 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
895
896 Make the Lisp reader and string-to-float more consistent (Bug#8525)
897 * data.c (atof): Remove decl; no longer used or needed.
898 (digit_to_number): Move to lread.c.
899 (Fstring_to_number): Use new string_to_number function, to be
900 consistent with how the Lisp reader treats infinities and NaNs.
901 Do not assume that floating-point numbers represent EMACS_INT
902 without losing information; this is not true on most 64-bit hosts.
903 Avoid double-rounding errors, by insisting on integers when
904 parsing non-base-10 numbers, as the documentation specifies.
905 * lisp.h (string_to_number): New decl, replacing ...
906 (isfloat_string): Remove.
907 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
908 (read1): Do not accept +. and -. as integers; this
909 appears to have been a coding error. Similarly, do not accept
910 strings like +-1e0 as floating point numbers. Do not report
911 overflow for integer overflows unless the base is not 10 which
912 means we have no simple and reliable way to continue.
913 Break out the floating-point parsing into a new
914 function string_to_number, so that Fstring_to_number parses
915 floating point numbers consistently with the Lisp reader.
916 (digit_to_number): Move here from data.c. Make it static inline.
917 (E_CHAR, EXP_INT): Remove, replacing with ...
918 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
919 (string_to_number): New function, replacing isfloat_string.
920 This function checks for valid syntax and produces the resulting
921 Lisp float number too. Rework it so that string-to-number
922 no longer mishandles examples like "1.0e+". Use strtoumax,
923 so that overflow for non-base-10 numbers is reported only when
924 there's no portable and simple way to convert to floating point.
925
926 * textprop.c (set_text_properties_1): Rewrite for clarity,
927 and to avoid GCC warning about integer overflow.
928
929 * intervals.h (struct interval): Use EMACS_INT for members
930 where EMACS_UINT might cause problems. See
931 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
932 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
933 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
934 All uses changed.
935 (offset_intervals): Tell GCC not to worry about length overflow
936 when negating a negative length.
937
938 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
939 (overrun_check_free): Likewise.
940
941 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
942 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
943 word size.
944
945 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
946 (gnutls_make_error): Rename local to avoid shadowing.
947 (gnutls_emacs_global_deinit): ifdef out; not used.
948 (Fgnutls_boot): Use const for pointer to readonly storage.
949 Comment out unused local. Fix pointer signedness problems.
950
951 * lread.c (openp): Don't stuff size_t into an 'int'.
952 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
953 about possible signed overflow.
954
955 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
956 (GDK_KEY_g): Don't define if already defined.
957 (xg_prepare_tooltip): Avoid pointer signedness problem.
958 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
959
960 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
961 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
962
963 * xfns.c (Fx_window_property): Simplify a bit,
964 to make a bit faster and to avoid GCC 4.6.0 warning.
965 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
966
967 * fns.c (internal_equal): Don't assume size_t fits in int.
968
969 * alloc.c (compact_small_strings): Tighten assertion a little.
970
971 Replace pEd with more-general pI, and fix some printf arg casts.
972 * lisp.h (pI): New macro, generalizing old pEd macro to other
973 conversion specifiers. For example, use "...%"pI"d..." rather
974 than "...%"pEd"...".
975 (pEd): Remove. All uses replaced with similar uses of pI.
976 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
977 * alloc.c (check_pure_size): Don't overflow by converting size to int.
978 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
979 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
980 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
981 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
982 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
983 64-bit hosts.
984 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
985 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
986 * print.c (safe_debug_print, print_object): Likewise.
987 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
988 to int.
989 Use pI instead of if-then-else-abort. Use %p to avoid casts,
990 avoiding the 0 flag, which is not portable.
991 * process.c (Fmake_network_process): Use pI to avoid cast.
992 * region-cache.c (pp_cache): Likewise.
993 * xdisp.c (decode_mode_spec): Likewise.
994 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
995 behavior on 64-bit hosts with printf arg.
996 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
997 (x_stop_queuing_selection_requests): Likewise.
998 (x_get_window_property): Don't truncate byte count to an 'int'
999 when tracing.
1000
1001 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1002 here, since it parses constructs like leading '-' and spaces,
1003 which are not wanted; and it overflows with large numbers.
1004 Instead, simply match F[0-9]+, which is what is wanted anyway.
1005
1006 * alloc.c: Remove unportable assumptions about struct layout.
1007 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1008 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1009 (allocate_vectorlike, make_pure_vector): Use the new macros,
1010 plus offsetof, to remove unportable assumptions about struct layout.
1011 These assumptions hold on all porting targets that I know of, but
1012 they are not guaranteed, they're easy to remove, and removing them
1013 makes further changes easier.
1014
1015 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1016 This doesn't fix a bug but makes the code clearer.
1017 (string_overrun_cookie): Now const. Use initializers that
1018 don't formally overflow signed char, to avoid warnings.
1019 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1020 can cause Emacs to crash when string overrun checking is enabled.
1021 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1022 multiple of sizeof (EMACS_INT); it need not be, if
1023 alignof(EMACS_INT) < sizeof (EMACS_INT).
1024 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1025
1026 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1027
1028 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1029
1030 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1031
1032 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1033 supposed to be handshaking. (Bug#8556)
1034 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1035
1036 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1037
1038 * lisp.h (Qdebug): List symbol.
1039 * eval.c (Qdebug): Restore global linkage.
1040 * keyboard.c (debug-on-event): New variable.
1041 (handle_user_signal): Break into debugger when debug-on-event
1042 matches the current signal symbol.
1043
1044 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1045
1046 * alloc.c (check_sblock, check_string_bytes)
1047 (check_string_free_list): Convert to standard C.
1048
1049 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1050
1051 * w32.c (emacs_gnutls_push): Fix typo.
1052
1053 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1054
1055 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1056 "cast to pointer from integer of different size".
1057
1058 Improve doprnt and its use in verror. (Bug#8545)
1059 * doprnt.c (doprnt): Document the set of format control sequences
1060 supported by the function. Use SAFE_ALLOCA instead of always
1061 using `alloca'.
1062
1063 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1064 is one byte too soon. Don't use xrealloc; instead xfree and
1065 xmalloc anew.
1066
1067 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1068
1069 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1070 callbacks stage.
1071
1072 * gnutls.c: Renamed global_initialized to
1073 gnutls_global_initialized. Added internals for the
1074 :verify-hostname-error, :verify-error, and :verify-flags
1075 parameters of `gnutls-boot' and documented those parameters in the
1076 docstring. Start callback support.
1077 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1078 unless a fatal error occured. Call gnutls_alert_send_appropriate
1079 on error. Return error code.
1080 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1081 (emacs_gnutls_read): Likewise.
1082 (Fgnutls_boot): Return handshake error code.
1083 (emacs_gnutls_handle_error): New function.
1084 (wsaerror_to_errno): Likewise.
1085
1086 * w32.h (emacs_gnutls_pull): Add prototype.
1087 (emacs_gnutls_push): Likewise.
1088
1089 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1090 (emacs_gnutls_push): Likewise.
1091
1092 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1093
1094 * process.c (wait_reading_process_output): Check if GnuTLS
1095 buffered some data internally if no FDs are set for TLS
1096 connections.
1097
1098 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1099 (LIBS): Link to USER_LIBS.
1100 ($(BLD)/gnutls.$(0)): New target.
1101
1102 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1103
1104 * xdisp.c (handle_single_display_spec): Rename the
1105 display_replaced_before_p argument into display_replaced_p, to
1106 make it consistent with the commentary. Fix typos in the
1107 commentary.
1108
1109 * textprop.c (syms_of_textprop): Remove dead code.
1110 (copy_text_properties): Delete obsolete commentary about an
1111 interface that was deleted long ago. Fix typos in the description
1112 of arguments.
1113
1114 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1115 to changes in oldXMenu/XMenu.h from 2011-04-16.
1116 <menu_help_message, prev_menu_help_message>: Constify.
1117 (IT_menu_make_room): menu->help_text is now `const char **';
1118 adjust.
1119
1120 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1121 to changes in oldXMenu/XMenu.h from 2011-04-16.
1122 (struct XMenu): Declare `help_text' `const char **'.
1123
1124 * xfaces.c <Qunspecified>: Make extern again.
1125
1126 * syntax.c: Include sys/types.h before including regex.h, as
1127 required by Posix.
1128
1129 * doc.c (get_doc_string): Improve the format passed to `error'.
1130
1131 * doprnt.c (doprnt): Improve commentary.
1132
1133 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1134
1135 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1136 them with etags.
1137
1138 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1139 changes in globals.h immediately force recompilation.
1140 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1141 $(CURDIR)/s/ms-w32.h.
1142 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1143
1144 * character.c (Fchar_direction): Function deleted.
1145 (syms_of_character): Don't defsubr it.
1146 <char-direction-table>: Deleted.
1147
1148 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1149
1150 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1151 * doprnt.c: Include limits.h.
1152 (SIZE_MAX): New macro.
1153 (doprnt): Return a size_t value. 2nd arg is now size_t.
1154 Many local variables are now size_t instead of int or unsigned.
1155 Improve overflow protection. Support `l' modifier for integer
1156 conversions. Support %l conversion. Don't assume an EMACS_INT
1157 argument for integer conversions and for %c.
1158
1159 * lisp.h (doprnt): Restore prototype.
1160
1161 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1162 $(SRC)/character.h.
1163
1164 * Makefile.in (base_obj): Add back doprnt.o.
1165
1166 * deps.mk (doprnt.o): Add back prerequisites.
1167 (callint.o): Depend on character.h.
1168
1169 * eval.c (internal_lisp_condition_case): Include the handler
1170 representation in the error message.
1171 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1172 when breaking from the loop.
1173
1174 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1175
1176 * callint.c (Fcall_interactively): When displaying error message
1177 about invalid control letter, pass the character's codepoint, not
1178 a pointer to its multibyte form. Improve display of the character
1179 in octal and display also its hex code.
1180
1181 * character.c (char_string): Use %x to display the (unsigned)
1182 codepoint of an invalid character, to avoid displaying a bogus
1183 negative value.
1184
1185 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1186 `error', not SYMBOL_NAME itself.
1187
1188 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1189 character arguments to `error'.
1190
1191 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1192 to `error' in error message about FINAL_CHAR argument. Make sure
1193 FINAL_CHAR is a character, and use %c when it is passed as
1194 argument to `error'.
1195
1196 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1197
1198 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1199
1200 * w32.c: Include <time.h>.
1201 (sys_localtime): New function.
1202
1203 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1204
1205 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1206
1207 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1208
1209 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1210
1211 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1212 zombies (Bug#8467).
1213
1214 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1215
1216 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1217 gl_state.e_property when gl_state.object is Qt.
1218
1219 * insdel.c (make_gap_larger): Remove limitation of buffer size
1220 to <= INT_MAX.
1221
1222 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1223
1224 * xdisp.c (lookup_glyphless_char_display)
1225 (produce_glyphless_glyph): Handle cons cell entry in
1226 glyphless-char-display.
1227 (Vglyphless_char_display): Document it.
1228
1229 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1230 glyphless-char-display.
1231
1232 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1233
1234 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1235
1236 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1237
1238 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1239 definition for no-X builds.
1240
1241 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1242
1243 Static checks with GCC 4.6.0 and non-default toolkits.
1244
1245 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1246
1247 * process.c (keyboard_bit_set): Define only if SIGIO.
1248 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1249 (send_process): Repair possible setjmp clobbering.
1250
1251 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1252
1253 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1254
1255 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1256
1257 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1258 Define only if needed.
1259
1260 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1261 by pacifying GCC about it. Maybe it's time to retire it?
1262 * xfaces.c (USG, __TIMEVAL__): Likewise.
1263
1264 * dispextern.h (struct redisplay_interface): Rename param
1265 to avoid shadowing.
1266 * termhooks.h (struct terminal): Likewise.
1267 * xterm.c (xembed_send_message): Likewise.
1268
1269 * insdel.c (make_gap_smaller): Define only if
1270 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1271
1272 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1273 it.
1274
1275 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1276 so that we aren't warned about unused symbols.
1277
1278 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1279
1280 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1281
1282 * xfns.c (x_real_positions): Mark locals as initialized.
1283
1284 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1285
1286 * xterm.c: Fix problems found by static analysis with other toolkits.
1287 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1288 (x_dispatch_event): Declare static if USE_GTK, and
1289 define if USE_GTK || USE_X_TOOLKIT.
1290 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1291 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1292 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1293 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1294
1295 * xmenu.c (menu_help_callback): Pointer type fixes.
1296 Use const pointers when pointing at readonly data. Avoid pointer
1297 signedness clashes.
1298 (FALSE): Remove unused macro.
1299 (update_frame_menubar): Remove unused decl.
1300
1301 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1302
1303 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1304 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1305 (single_menu_item): Rename local to avoid shadowing.
1306
1307 * keyboard.c (make_lispy_event): Remove unused local var.
1308
1309 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1310 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1311
1312 * bitmaps: Change bitmaps from unsigned char back to the X11
1313 compatible char. Avoid the old compiler warnings about
1314 out-of-range initializers by using, for example, '\xab' rather
1315 than 0xab.
1316
1317 * xgselect.c (xgselect_initialize): Check vs interface
1318 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1319
1320 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1321
1322 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1323 to read-only memory.
1324
1325 * fns.c (vector): Remove; this old hack is no longer needed.
1326
1327 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1328 Remove unused var.
1329 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1330
1331 * xrdb.c (x_load_resources): Omit unused local.
1332
1333 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1334 (x_window): Rename locals to avoid shadowing.
1335 (USG): Use the kludged USG macro, to pacify gcc.
1336
1337 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1338 (x_term_init): Remove local to avoid shadowing.
1339
1340 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1341
1342 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1343 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1344
1345 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1346
1347 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1348
1349 Fix regex.c, syntax.c and friends for buffers > 2GB.
1350 * syntax.h (struct gl_state_s): Declare character position members
1351 EMACS_INT.
1352
1353 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1354
1355 * textprop.c (verify_interval_modification, interval_of):
1356 Declare arguments EMACS_INT.
1357
1358 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1359 EMACS_INT.
1360
1361 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1362
1363 * indent.c (Fvertical_motion): Local variable it_start is now
1364 EMACS_INT.
1365
1366 * regex.c (re_match, re_match_2, re_match_2_internal)
1367 (bcmp_translate, regcomp, regexec, print_double_string)
1368 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1369 (re_compile_pattern, re_exec): Declare arguments and local
1370 variables `size_t' and `ssize_t' and return values `regoff_t', as
1371 appropriate.
1372 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1373 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1374 <compile_stack_type>: `size' and `avail' are now `size_t'.
1375
1376 * regex.h <regoff_t>: Use ssize_t, not int.
1377 (re_search, re_search_2, re_match, re_match_2): Arguments that
1378 specify buffer/string position and length are now ssize_t and
1379 size_t. Return type is regoff_t.
1380
1381 2011-04-16 Ben Key <bkey76@gmail.com>
1382
1383 * nsfont.m: Fixed bugs in ns_get_family and
1384 ns_descriptor_to_entity that were caused by using free to
1385 deallocate memory blocks that were allocated by xmalloc (via
1386 xstrdup). This caused Emacs to crash when compiled with
1387 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1388 --enable-checking=xmallocoverrun). xfree is now used to
1389 deallocate these memory blocks.
1390
1391 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1392
1393 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1394
1395 emacs_write: Accept and return EMACS_INT for sizes.
1396 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1397 et seq.
1398 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1399 Accept and return EMACS_INT.
1400 (emacs_gnutls_write): Return the number of bytes written on
1401 partial writes.
1402 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1403 (emacs_read, emacs_write): Remove check for negative size, as the
1404 Emacs source code has been audited now.
1405 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1406 (emacs_read, emacs_write): Use it.
1407 * process.c (send_process): Adjust to the new signatures of
1408 emacs_write and emacs_gnutls_write. Do not attempt to store
1409 a byte offset into an 'int'; it might overflow.
1410 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1411
1412 * sound.c: Don't assume sizes fit in 'int'.
1413 (struct sound_device.period_size, alsa_period_size):
1414 Return EMACS_INT, not int.
1415 (struct sound_device.write, vox_write, alsa_write):
1416 Accept EMACS_INT, not int.
1417 (wav_play, au_play): Use EMACS_INT to store sizes and to
1418 record read return values.
1419
1420 2011-04-15 Ben Key <bkey76@gmail.com>
1421
1422 * keyboard.c (Qundefined): Don't declare static since it is used
1423 in nsfns.m.
1424 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1425 static since they are used in nsfont.m.
1426
1427 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1428
1429 * process.c (Qprocessp): Don't declare static.
1430 * lisp.h (Qprocessp): Declare again.
1431
1432 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1433
1434 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1435
1436 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1437
1438 Improve C-level modularity by making more things 'static'.
1439
1440 Don't publish debugger-only interfaces to other modules.
1441 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1442 (verify_bytepos, count_markers): Move decls to the only modules
1443 that need them.
1444 * region-cache.h (pp_cache): Likewise.
1445 * window.h (check_all_windows): Likewise.
1446 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1447
1448 * sysdep.c (croak): Now static, if
1449 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1450 * syssignal.h (croak): Declare only if not static.
1451
1452 * alloc.c (refill_memory_reserve): Now static if
1453 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1454 * lisp.h (refill_memory_reserve): Declare only if not static.
1455
1456 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1457 Define only if USE_LUCID.
1458
1459 * xrdb.c (x_customization_string, x_rm_string): Now static.
1460
1461 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1462 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1463
1464 * xdisp.c (draw_row_with_mouse_face): Now static.
1465 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1466
1467 * window.h (check_all_windows): Mark externally visible.
1468
1469 * window.c (window_deletion_count): Now static.
1470
1471 * undo.c: Make symbols static if they're not exported.
1472 (last_undo_buffer, last_boundary_position, pending_boundary):
1473 Now static.
1474
1475 * textprop.c (interval_insert_behind_hooks): Now static.
1476 (interval_insert_in_front_hooks): Likewise.
1477
1478 * term.c: Make symbols static if they're not exported.
1479 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1480 (max_frame_lines, tty_set_terminal_modes):
1481 (tty_reset_terminal_modes, tty_turn_off_highlight):
1482 (get_tty_terminal): Now static.
1483 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1484 * termhooks.h (term_mouse_moveto): Do not declare if
1485 HAVE_WINDOW_SYSTEM.
1486 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1487 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1488
1489 * sysdep.c: Make symbols static if they're not exported.
1490 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1491 Now static.
1492 (sigprocmask_set, full_mask): Remove; unused.
1493 (wait_debugging): Mark as visible.
1494 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1495 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1496
1497 * syntax.c (syntax_temp): Define only if !__GNUC__.
1498
1499 * sound.c (current_sound_device, current_sound): Now static.
1500
1501 * search.c (searchbufs, searchbuf_head): Now static.
1502
1503 * scroll.c (scroll_cost): Remove; unused.
1504 * dispextern.h (scroll_cost): Remove decl.
1505
1506 * region-cache.h (pp_cache): Mark as externally visible.
1507
1508 * process.c: Make symbols static if they're not exported.
1509 (process_tick, update_tick, create_process, chan_process):
1510 (Vprocess_alist, proc_buffered_char, datagram_access):
1511 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1512 (deactivate_process): Mark defn as static, as well as decl.
1513 * lisp.h (create_process): Remove decl.
1514 * process.h (chan_process, Vprocess_alist): Remove decls.
1515
1516 * print.c: Make symbols static if they're not exported.
1517 (print_depth, new_backquote_output, being_printed, print_buffer):
1518 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1519 (print_interval, print_number_index, initial_stderr_stream):
1520 Now static.
1521 * lisp.h (Fprinc): Remove decl.
1522 (debug_output_compilation_hack): Mark as externally visible.
1523
1524 * sysdep.c (croak): Move decl from here to syssignal.h.
1525 * syssignal.h (croak): Put it here, so the API can be checked when
1526 'croak' is called from dissociate_if_controlling_tty.
1527
1528 * minibuf.c: Make symbols static if they're not exported.
1529 (minibuf_save_list, choose_minibuf_frame): Now static.
1530 * lisp.h (choose_minibuf_frame): Remove decl.
1531
1532 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1533
1534 * lread.c: Make symbols static if they're not exported.
1535 (read_objects, initial_obarray, oblookup_last_bucket_number):
1536 Now static.
1537 (make_symbol): Remove; unused.
1538 * lisp.h (initial_obarray, make_symbol): Remove decls.
1539
1540 * keyboard.c: Make symbols static if they're not exported.
1541 (single_kboard, recent_keys_index, total_keys, recent_keys):
1542 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1543 (this_single_command_key_start, echoing, last_auto_save):
1544 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1545 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1546 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1547 (Vlispy_mouse_stem, double_click_count):
1548 Now static.
1549 (force_auto_save_soon): Define only if SIGDANGER.
1550 (ignore_mouse_drag_p): Now static if
1551 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1552 (print_help): Remove; unused.
1553 (stop_character, last_timer_event): Mark as externally visible.
1554 * keyboard.h (ignore_mouse_drag_p): Declare only if
1555 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1556 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1557 * lisp.h (echoing): Remove decl.
1558 (force_auto_save_soon): Declare only if SIGDANGER.
1559 * xdisp.c (redisplay_window): Simplify code, to make it more
1560 obvious that ignore_mouse_drag_p is not accessed if !defined
1561 USE_GTK && !defined HAVE_NS.
1562
1563 * intervals.c: Make symbols static if they're not exported.
1564 (merge_properties_sticky, merge_interval_right, delete_interval):
1565 Now static.
1566 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1567
1568 * insdel.c: Make symbols static if they're not exported.
1569 However, leave prepare_to_modify_buffer alone. It's never
1570 called from outside this function, but that appears to be a bug.
1571 (combine_after_change_list, combine_after_change_buffer):
1572 (adjust_after_replace, signal_before_change): Now static.
1573 (adjust_after_replace_noundo): Remove; unused.
1574 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1575 (signal_before_change): Remove decls.
1576
1577 * indent.c (val_compute_motion, val_vmotion): Now static.
1578
1579 * image.c: Make symbols static if they're not exported.
1580 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1581 if USE_GTK.
1582 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1583 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1584
1585 * fringe.c (standard_bitmaps): Now static.
1586 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1587
1588 * frame.c: Make symbols static if they're not exported.
1589 (x_report_frame_params, make_terminal_frame): Now static.
1590 (get_frame_param): Now static, unless HAVE_NS.
1591 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1592 (x_get_resource_string): Remove; not used.
1593 * frame.h (make_terminal_frame, x_report_frame_params):
1594 (x_get_resource_string); Remove decls.
1595 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1596 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1597
1598 * font.c, fontset.c: Make symbols static if they're not exported.
1599 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1600 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1601 * font.c (font_close_object): Now static.
1602 * font.h (font_close_object): Remove.
1603 * fontset.c (FONTSET_OBJLIST): Remove.
1604 (free_realized_fontset) #if-0 the body, which does nothing.
1605 (face_suitable_for_char_p): #if-0, as it's never called.
1606 * fontset.h (face_suitable_for_char_p): Remove decl.
1607 * xfaces.c (face_at_string_position):
1608 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1609 since 0 is always ASCII.
1610
1611 * fns.c (weak_hash_tables): Now static.
1612
1613 * fileio.c: Make symbols static if they're not exported.
1614 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1615 (Vwrite_region_annotation_buffers): Now static.
1616
1617 * eval.c: Make symbols static if they're not exported.
1618 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1619 * lisp.h (backtrace_list): Remove decl.
1620
1621 * emacs.c: Make symbols static if they're not exported.
1622 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1623 (fatal_error_code, fatal_error_signal_hook, standard_args):
1624 Now static.
1625 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1626 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1627 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1628 * lisp.h (fatal_error_signal_hook): Remove decl.
1629 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1630
1631 * editfns.c: Move a (normally-unused) function to its only use.
1632 * editfns.c, lisp.h (get_operating_system_release): Remove.
1633 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1634 worth the hassle of breaking this out.
1635
1636 * xterm.c: Make symbols static if they're not exported.
1637 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1638 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1639 (x_destroy_window, x_delete_display):
1640 Now static.
1641 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1642 (x_mouse_leave): Remove; unused.
1643 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1644 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1645 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1646 Remove decls.
1647 (x_mouse_leave): Declare only if WINDOWSNT.
1648 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1649 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1650 USE_X_TOOLKIT.
1651
1652 * ftxfont.c: Make symbols static if they're not exported.
1653 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1654 HAVE_FREETYPE.
1655 * font.h (ftxfont_driver): Likewise.
1656
1657 * xfns.c: Make symbols static if they're not exported.
1658 (x_last_font_name, x_display_info_for_name):
1659 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1660 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1661 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1662 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1663 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1664 (last_show_tip_args): Now static.
1665 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1666 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1667 (x_screen_planes): Remove; unused.
1668 * dispextern.h (x_screen_planes): Remove decl.
1669
1670 * dispnew.c: Make symbols static if they're not exported.
1671 * dispextern.h (redraw_garbaged_frames, scrolling):
1672 (increment_row_positions): Remove.
1673 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1674 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1675 Now static.
1676 (redraw_garbaged_frames): Remove; unused.
1677
1678 * xfaces.c: Make symbols static if they're not exported.
1679 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1680 Remove decls.
1681 * xterm.h (defined_color): Remove decls.
1682 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1683 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1684 (menu_face_changed_default, defined_color, free_realized_face):
1685 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1686 (ascii_face_of_lisp_face): Remove; unused.
1687
1688 * xdisp.c: Make symbols static if they're not exported.
1689 * dispextern.h (scratch_glyph_row, window_box_edges):
1690 (glyph_to_pixel_coords, set_cursor_from_row):
1691 (get_next_display_element, set_iterator_to_next):
1692 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1693 (show_mouse_face): Remove decls
1694 * frame.h (message_buf_print): Likewise.
1695 * lisp.h (pop_message, set_message, check_point_in_composition):
1696 Likewise.
1697 * xterm.h (set_vertical_scroll_bar): Likewise.
1698 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1699 (message_buf_print, scratch_glyph_row, displayed_buffer):
1700 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1701 (get_next_display_element, show_mouse_face, window_box_edges):
1702 (frame_to_window_pixel_xy, check_point_in_composition):
1703 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1704 (glyph_to_pixel_coords): Remove; unused.
1705
1706 * dired.c (file_name_completion): Now static.
1707
1708 * dbusbind.c (xd_in_read_queued_messages): Now static.
1709
1710 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1711 * data.c (circular_list_error): Remove.
1712
1713 * commands.h (last_point_position, last_point_position_buffer):
1714 (last_point_position_window): Remove decls.
1715 * keyboard.c: Make these variables static.
1716
1717 * coding.h (coding, code_convert_region, encode_coding_gap):
1718 Remove decls.
1719 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1720 (iso_code_class, detect_coding, code_convert_region): Now static.
1721 (encode_coding_gap): Remove; unused.
1722
1723 * chartab.c (chartab_chars, chartab_bits): Now static.
1724
1725 * charset.h (charset_iso_8859_1): Remove decl.
1726 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1727 Now static.
1728
1729 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1730 * ccl.c (Vccl_program_table): Now static.
1731 (check_ccl_update): Remove; unused.
1732
1733 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1734 * category.h: ... from here.
1735 * category.c (check_category_table, set_category_set): Now static.
1736
1737 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1738 * lisp.h: Remove these decls.
1739
1740 * buffer.c (buffer_count): Remove unused var.
1741
1742 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1743 so that it's not optimized away.
1744 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1745 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1746 exported only to the debugger.
1747
1748 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1749 * atimer.h (run_all_atimers): Remove; not exported.
1750
1751 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1752 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1753 was inaccessible from Lisp.
1754 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1755 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1756
1757 alloc.c: Import and export fewer symbols, and remove unused items.
1758 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1759 is defined.
1760 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1761 it's not optimized away by whole-program optimization.
1762 (message_enable_multibyte, free_misc): Remove.
1763 (catchlist, handlerlist, mark_backtrace):
1764 Declare only if BYTE_MARK_STACK.
1765 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1766 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1767 (message_enable_multibyte): Remove decl.
1768 (free_misc, interval_free_list, float_block, float_block_index):
1769 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1770 (cons_free_list, last_marked_index):
1771 Now static.
1772 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1773 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1774 (mark_backtrace): Define only if BYTE_MARK_STACK.
1775 * xdisp.c (message_enable_multibyte): Now static.
1776
1777 Declare Lisp_Object Q* variables to be 'static' if not exported.
1778 This makes it easier for human readers (and static analyzers)
1779 to see whether these variables are used from other modules.
1780 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1781 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1782 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1783 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1784 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1785 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1786 * xmenu.c, xselect.c:
1787 Declare Q* vars static if they are not used in other modules.
1788 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1789 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1790 Remove decls of unexported vars.
1791 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1792
1793 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1794
1795 Make Emacs functions such as Fatom 'static' by default.
1796 This makes it easier for human readers (and static analyzers)
1797 to see whether these functions can be called from other modules.
1798 DEFUN now defines a static function. To make the function external
1799 so that it can be used in other C modules, use the new macro DEFUE.
1800 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1801 (Finit_image_library):
1802 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1803 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1804 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1805 Remove decls, since these functions are now static.
1806 (Funintern, Fget_internal_run_time): New decls, since these functions
1807 were already external.
1808
1809 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1810 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1811 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1812 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1813 * keyboard.c, keymap.c, lread.c:
1814 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1815 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1816 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1817 Mark functions with DEFUE instead of DEFUN,
1818 if they are used in other modules.
1819 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1820 decls for now-static functions.
1821 * buffer.h (Fdelete_overlay): Remove decl.
1822 * callproc.c (Fgetenv_internal): Mark as internal.
1823 * composite.c (Fremove_list_of_text_properties): Remove decl.
1824 (Fcomposition_get_gstring): New forward static decl.
1825 * composite.h (Fcomposite_get_gstring): Remove decl.
1826 * dired.c (Ffile_attributes): New forward static decl.
1827 * doc.c (Fdocumntation_property): New forward static decl.
1828 * eval.c (Ffetch_bytecode): New forward static decl.
1829 (Funintern): Remove extern decl; now in .h file where it belongs.
1830 * fileio.c (Fmake_symbolic_link): New forward static decl.
1831 * image.c (Finit_image_library): New forward static decl.
1832 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1833 * intervals.h (Fprevious_property_change):
1834 (Fremove_list_of_text_properties): Remove decls.
1835 * keyboard.c (Fthis_command_keys): Remove decl.
1836 (Fcommand_execute): New forward static decl.
1837 * keymap.c (Flookup_key): New forward static decl.
1838 (Fcopy_keymap): Now static.
1839 * keymap.h (Flookup_key): Remove decl.
1840 * process.c (Fget_process): New forward static decl.
1841 (Fprocess_datagram_address): Mark as internal.
1842 * syntax.c (Fsyntax_table_p): New forward static decl.
1843 (skip_chars): Remove duplicate decl.
1844 * textprop.c (Fprevious_property_change): New forward static decl.
1845 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1846 Now internal.
1847 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1848 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1849
1850 * editfns.c (Fformat): Remove unreachable code.
1851
1852 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1853
1854 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1855 change. (Bug#8496)
1856
1857 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1858
1859 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1860 when at ZV. (Bug#8487)
1861
1862 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1863
1864 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1865 (Bug#8437)
1866 * keyboard.c (parse_tool_bar_item): Likewise.
1867 * sound.c (sound_cleanup, alsa_close): Likewise.
1868 * termcap.c (tgetent): Likewise.
1869 * xfns.c (x_default_font_parameter): Likewise.
1870 * xsettings.c (read_and_apply_settings): Likewise.
1871
1872 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1873 (overrun_check_free): Protoize.
1874
1875 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1876
1877 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1878 since callers should never pass a negative size.
1879 Change the signature to match that of plain 'read' and 'write'; see
1880 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1881 * lisp.h: Update prototypes of emacs_write and emacs_read.
1882
1883 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1884
1885 * xdisp.c (redisplay_window): Don't try to determine the character
1886 position of the scroll margin if the window start point w->startp
1887 is outside the buffer's accessible region. (Bug#8468)
1888
1889 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1890
1891 Fix write-region and its subroutines for buffers > 2GB.
1892 * fileio.c (a_write, e_write): Modify declaration of arguments and
1893 local variables to support buffers larger than 2GB.
1894 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1895
1896 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1897 argument, local variables, and return value.
1898
1899 * lisp.h: Update prototypes of emacs_write and emacs_read.
1900
1901 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1902
1903 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1904
1905 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1906
1907 Fix more problems found by GCC 4.6.0's static checks.
1908
1909 * xdisp.c (vmessage): Use a better test for character truncation.
1910
1911 * charset.c (load_charset_map): <, not <=, for optimization,
1912 and to avoid potential problems with integer overflow.
1913 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1914 * casetab.c (set_identity, shuffle): Likewise.
1915 * editfns.c (Fformat): Likewise.
1916 * syntax.c (skip_chars): Likewise.
1917
1918 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1919 This also lets GCC 4.6.0 generate slightly better loop code.
1920
1921 * callint.c (Fcall_interactively): <, not <=, for optimization.
1922 (Fcall_interactively): Count the number of arguments produced,
1923 not the number of arguments given. This is simpler and lets GCC
1924 4.6.0 generate slightly better code.
1925
1926 * ftfont.c: Distingish more carefully between FcChar8 and char.
1927 The previous code passed unsigned char * to a functions like
1928 strlen and xstrcasecmp that expect char *, which does not
1929 conform to the C standard.
1930 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1931 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1932 char * when the C standard requires it.
1933
1934 * keyboard.c (read_char): Remove unused var.
1935
1936 * eval.c: Port to Windows vsnprintf (Bug#8435).
1937 Include <limits.h>.
1938 (SIZE_MAX): Define if the headers do not.
1939 (verror): Do not give up if vsnprintf returns a negative count.
1940 Instead, grow the buffer. This ports to Windows vsnprintf, which
1941 does not conform to C99. Problem reported by Eli Zaretskii.
1942 Also, simplify the allocation scheme, by avoiding the need for
1943 calling realloc, and removing the ALLOCATED variable.
1944
1945 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1946
1947 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1948 But keep the doprint source code for now, as we might revamp it
1949 and use it again (Bug#8435).
1950 * lisp.h (doprnt): Remove.
1951 * Makefile.in (base_obj): Remove doprnt.o.
1952 * deps.mk (doprnt.o): Remove.
1953
1954 error: Print 32- and 64-bit integers portably (Bug#8435).
1955 Without this change, on typical 64-bit hosts error ("...%d...", N)
1956 was used to print both 32- and 64-bit integers N, which relied on
1957 undefined behavior.
1958 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1959 New macro.
1960 * lisp.h (error, verror): Mark as printf-like functions.
1961 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1962 Report overflow in size calculations when allocating printf buffer.
1963 Do not truncate output string at its first null byte.
1964 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1965 Truncate the output at a character boundary, since vsnprintf does not
1966 do that.
1967 * charset.c (check_iso_charset_parameter): Convert internal
1968 character to string before calling 'error', since %c now has the
1969 printf meaning.
1970 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1971 overflow when computing char to be passed to 'error'. Do not
1972 pass Lisp_Object to 'error'; pass the integer instead.
1973 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1974 formatted with plain %d.
1975
1976 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1977
1978 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1979
1980 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1981
1982 * xterm.c (x_catch_errors): Remove duplicate declaration.
1983
1984 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1985
1986 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1987
1988 2011-04-10 Jim Meyering <meyering@redhat.com>
1989
1990 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1991 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1992 return ssize_t not "int", and use size_t as the buffer length.
1993 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1994 * gnutls.h: Update declarations.
1995 * process.c (read_process_output): Use ssize_t, to match.
1996 (send_process): Likewise.
1997
1998 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1999
2000 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2001
2002 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2003
2004 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2005 Use unsigned char, to match FcChar8 type definition.
2006
2007 * xterm.c (handle_one_xevent):
2008 * xmenu.c (create_and_show_popup_menu):
2009 * xselect.c (x_decline_selection_request)
2010 (x_reply_selection_request): Avoid type-punned deref of X events.
2011
2012 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2013
2014 Fix some uses of `int' instead of EMACS_INT.
2015 * search.c (string_match_1, fast_string_match)
2016 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2017 (scan_buffer, find_next_newline_no_quit)
2018 (find_before_next_newline, search_command, Freplace_match)
2019 (Fmatch_data): Make some `int' variables be EMACS_INT.
2020
2021 * xdisp.c (display_count_lines): 3rd argument and return value now
2022 EMACS_INT. All callers changed.
2023 (pint2hrstr): Last argument is now EMACS_INT.
2024
2025 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2026 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2027 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2028 (decode_coding_utf_16, decode_coding_emacs_mule)
2029 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2030 (decode_coding_ccl, decode_coding_charset)
2031 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2032 (decode_coding_iso_2022, decode_coding_emacs_mule)
2033 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2034 <char_offset, last_offset>: Declare EMACS_INT.
2035 (encode_coding_utf_8, encode_coding_utf_16)
2036 (encode_coding_emacs_mule, encode_invocation_designation)
2037 (encode_designation_at_bol, encode_coding_iso_2022)
2038 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2039 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2040 Declare EMACS_INT.
2041 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2042 (encode_invocation_designation): Last argument P_NCHARS is now
2043 EMACS_INT.
2044 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2045 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2046
2047 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2048 All users changed.
2049
2050 * ccl.c (Fccl_execute_on_string): Declare some variables
2051 EMACS_INT.
2052
2053 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2054
2055 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2056
2057 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2058
2059 * process.c (Fformat_network_address): Doc fix.
2060
2061 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2062
2063 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2064
2065 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2066
2067 * keyboard.c (read_char): Call Lisp function help-form-show,
2068 instead of using internal_with_output_to_temp_buffer.
2069 (Qhelp_form_show): New var.
2070 (syms_of_keyboard): Use DEFSYM macro.
2071
2072 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2073
2074 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2075
2076 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2077
2078 * process.c (Flist_processes): Remove to Lisp.
2079 (list_processes_1): Delete.
2080
2081 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2082
2083 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2084
2085 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2086
2087 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2088
2089 Fix more problems found by GCC 4.6.0's static checks.
2090
2091 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2092
2093 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2094
2095 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2096
2097 * xdisp.c (vmessage): Mark as a printf-like function.
2098
2099 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2100
2101 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2102
2103 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2104 printf-like functions.
2105 (tiff_load): Add casts to remove these marks before passing them
2106 to system-supplied API.
2107
2108 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2109
2110 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2111 This avoids several warnings with gcc -Wstrict-overflow.
2112 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2113 directly, rather than having caller test rule sign. This avoids
2114 some unnecessary tests.
2115 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2116 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2117 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2118
2119 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2120 (xfont_open): Avoid unnecessary tests.
2121
2122 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2123
2124 * composite.h, composite.c (composition_gstring_put_cache):
2125 Use EMACS_INT, not int, for length.
2126
2127 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2128 breaking out part of COMPOSITION_DECODE_RULE.
2129 (COMPOSITION_DECODE_RULE): Use it.
2130 * composite.c (get_composition_id): Remove unused local vars,
2131 by using the new macro.
2132
2133 * textprop.c (set_text_properties_1): Change while to do-while,
2134 since the condition is always true at first.
2135
2136 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2137 (interval_deletion_adjustment): Return unsigned value.
2138 All uses changed.
2139
2140 * process.c (list_processes_1, create_pty, read_process_output):
2141 (exec_sentinel): Remove vars that were set but not used.
2142 (create_pty): Remove unnecessary "volatile"s.
2143 (Fnetwork_interface_info): Avoid possibility of int overflow.
2144 (read_process_output): Do adaptive read buffering even if carryover.
2145 (read_process_output): Simplify nbytes computation if buffered.
2146
2147 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2148
2149 * syntax.c (scan_words): Remove var that was set but not used.
2150 (update_syntax_table): Use unsigned instead of int.
2151
2152 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2153 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2154 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2155
2156 * print.c (print_error_message): Avoid int overflow.
2157
2158 * font.c (font_list_entities): Redo for clarity,
2159 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2160
2161 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2162 (font_score): Avoid potential overflow in diff calculation.
2163
2164 * fns.c (substring_both): Remove var that is set but not used.
2165 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2166
2167 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2168
2169 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2170 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2171 can always succeed if overflow has undefined behavior.
2172
2173 * search.c (boyer_moore, wordify): Remove vars set but not used.
2174 (wordify): Omit three unnecessary tests.
2175
2176 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2177 All callers changed. This avoids the need for an unused var.
2178
2179 * casefiddle.c (casify_region): Remove var that is set but not used.
2180
2181 * dired.c (file_name_completion): Remove var that is set but not used.
2182
2183 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2184
2185 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2186 (Finsert_file_contents): Remove unnecessary code checking fd.
2187
2188 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2189 Check for integer overflow on size calculations.
2190
2191 * buffer.c (Fprevious_overlay_change): Remove var that is set
2192 but not used.
2193
2194 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2195 Remove vars that are set but not used.
2196 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2197 (timer_check_2): Mark vars as initialized.
2198
2199 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2200
2201 * image.c (lookup_image): Remove var that is set but not used.
2202 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2203
2204 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2205 that are set but not used.
2206
2207 * xfns.c (make_invisible_cursor): Don't return garbage
2208 if XCreateBitmapFromData fails (Bug#8410).
2209
2210 * xselect.c (x_get_local_selection, x_handle_property_notify):
2211 Remove vars that are set but not used.
2212
2213 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2214 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2215
2216 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2217 Remove var that is set but not used.
2218 (scroll_bar_windows_size): Now size_t, not int.
2219 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2220 Check for overflow.
2221
2222 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2223 (map_tty_color) [!defined MSDOS]: Likewise.
2224
2225 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2226
2227 * coding.c: Remove vars that are set but not used.
2228 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2229 All callers changed.
2230 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2231 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2232 (decode_coding_charset): Remove vars that are set but not used.
2233
2234 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2235 that is set but not used.
2236
2237 * print.c (print_object): Remove var that is set but not used.
2238
2239 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2240 The gnulib version avoids calling malloc in the usual case,
2241 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2242 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2243 * filelock.c (current_lock_owner): Likewise.
2244 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2245 * sysdep.c: Include allocator.h, careadlinkat.h.
2246 (emacs_no_realloc_allocator): New static constant.
2247 (emacs_readlink): New function.
2248 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2249 ../lib/careadlinkat.h.
2250
2251 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2252
2253 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2254 first non-nil return value).
2255
2256 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2257
2258 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2259 if not defined (Bug#8403).
2260
2261 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2262
2263 * xdisp.c (display_count_lines): Remove parameter `start',
2264 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2265 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2266 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2267 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2268 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2269 and thereabouts. All callers changed.
2270 (get_per_char_metric): Remove parameter `f', unused since
2271 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2272
2273 2011-04-02 Jim Meyering <meyering@redhat.com>
2274
2275 do not dereference NULL upon failed strdup
2276 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2277 (ns_get_family): Likewise.
2278
2279 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2280
2281 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2282
2283 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2284
2285 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2286 later (Bug#8403).
2287
2288 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2289
2290 Add lexical binding.
2291
2292 * window.c (Ftemp_output_buffer_show): New fun.
2293 (Fsave_window_excursion):
2294 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2295
2296 * lread.c (lisp_file_lexically_bound_p): New function.
2297 (Fload): Bind Qlexical_binding.
2298 (readevalloop): Remove `evalfun' arg.
2299 Bind Qinternal_interpreter_environment.
2300 (Feval_buffer): Bind Qlexical_binding.
2301 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2302 Mark as dynamic.
2303 (syms_of_lread): Declare `lexical-binding'.
2304
2305 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2306
2307 * keyboard.c (eval_dyn): New fun.
2308 (menu_item_eval_property): Use it.
2309
2310 * image.c (parse_image_spec): Use Ffunctionp.
2311
2312 * fns.c (concat, mapcar1): Accept byte-code-functions.
2313
2314 * eval.c (Fsetq): Handle lexical vars.
2315 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2316 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2317 (FletX, Flet): Obey lexical binding.
2318 (Fcommandp): Handle closures.
2319 (Feval): New `lexical' arg.
2320 (eval_sub): New function extracted from Feval. Use it almost
2321 everywhere where Feval was used. Look up vars in lexical env.
2322 Handle closures.
2323 (Ffunctionp): Move from subr.el.
2324 (Ffuncall): Handle closures.
2325 (apply_lambda): Remove `eval_flags'.
2326 (funcall_lambda): Handle closures and new byte-code-functions.
2327 (Fspecial_variable_p): New function.
2328 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2329 but without exporting it to Lisp.
2330
2331 * doc.c (Fdocumentation, store_function_docstring):
2332 * data.c (Finteractive_form): Handle closures.
2333
2334 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2335 interactive spec.
2336
2337 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2338 New byte-codes.
2339 (exec_byte_code): New function extracted from Fbyte_code to handle new
2340 calling convention for byte-code-functions. Add new byte-codes.
2341
2342 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2343
2344 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2345
2346 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2347
2348 * xdisp.c (redisplay_internal): Fix prototype.
2349
2350 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2351
2352 * xdisp.c (SCROLL_LIMIT): New macro.
2353 (try_scrolling): Use it when setting scroll_limit.
2354 Limit scrolling to 100 screen lines.
2355 (redisplay_window): Even when falling back on "recentering",
2356 position point in the window according to scroll-conservatively,
2357 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2358
2359 (try_scrolling): When point is above the window, allow searching
2360 as far as scroll_max, or one screenful, to compute vertical
2361 distance from PT to the scroll margin position. This prevents
2362 try_scrolling from unnecessarily failing when
2363 scroll-conservatively is set to a value slightly larger than the
2364 window height. Clean up the case of PT below the margin at bottom
2365 of window: scroll_max can no longer be INT_MAX. When aggressive
2366 scrolling is in use, don't let point enter the opposite scroll
2367 margin as result of the scroll.
2368 (syms_of_xdisp) <scroll-conservatively>: Document the
2369 threshold of 100 lines for never-recentering scrolling.
2370
2371 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2372
2373 * dispextern.h (move_it_by_lines):
2374 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2375 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2376 (message_log_check_duplicate): Remove parameters `prev_bol' and
2377 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2378 (redisplay_internal): Remove parameter `preserve_echo_area',
2379 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2380
2381 * indent.c (Fvertical_motion):
2382 * window.c (window_scroll_pixel_based, Frecenter):
2383 Don't pass `need_y_p' to `move_it_by_lines'.
2384
2385 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2386
2387 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2388 steal a few bits to be more compact.
2389 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2390 Remove unneeded casts.
2391
2392 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2393
2394 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2395
2396 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2397 binding" message (bug#7967).
2398
2399 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2400
2401 Fix more problems found by GCC 4.6.0's static checks.
2402
2403 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2404 Remove unused local var.
2405
2406 * editfns.c (Fmessage_box): Remove unused local var.
2407
2408 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2409 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2410 Omit unused local vars.
2411 * window.c (shrink_windows): Omit unused local var.
2412 * menu.c (digest_single_submenu): Omit unused local var.
2413 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2414 Omit unused local var.
2415
2416 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2417 Don't assume string length fits in int.
2418 (keyremap_step, read_key_sequence): Use size_t for sizes.
2419 (read_key_sequence): Don't check last_real_key_start redundantly.
2420
2421 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2422 instead of alloca (Bug#8344).
2423
2424 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2425 (Fbacktrace_frame): Don't assume nframes fits in int.
2426
2427 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2428
2429 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2430 concerns.
2431
2432 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2433
2434 * cm.c (calccost): Turn while-do into do-while, for clarity.
2435
2436 * keyboard.c (syms_of_keyboard): Use the same style as later
2437 in this function when indexing through an array. This also
2438 works around GCC bug 48267.
2439
2440 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2441
2442 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2443
2444 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2445 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2446
2447 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2448 This avoids undefined behavior on integer overflow, and is a bit
2449 more convenient anyway since it is compared to a size_t variable.
2450
2451 Variadic C functions now count arguments with size_t, not int.
2452 This avoids an unnecessary limitation on 64-bit machines, which
2453 caused (substring ...) to crash on large vectors (Bug#8344).
2454 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2455 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2456 All variadic functions and their callers changed accordingly.
2457 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2458 * data.c (arith_driver, float_arith_driver): Likewise.
2459 * editfns.c (general_insert_function): Likewise.
2460 * eval.c (struct backtrace.nargs, interactive_p)
2461 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2462 (funcall_lambda, mark_backtrace): Likewise.
2463 * fns.c (concat): Likewise.
2464 * frame.c (x_set_frame_parameters): Likewise.
2465 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2466 0 if not found, not -1. All callers changed.
2467
2468 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2469 (stack_copy_size): Now size_t, not int.
2470 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2471
2472 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2473
2474 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2475 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2476 All callers changed.
2477
2478 * lisp.h (multibyte_char_to_unibyte):
2479 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2480 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2481 * character.h (CHAR_TO_BYTE8):
2482 * cmds.c (internal_self_insert):
2483 * editfns.c (general_insert_function):
2484 * keymap.c (push_key_description):
2485 * search.c (Freplace_match):
2486 * xdisp.c (message_dolog, set_message_1): All callers changed.
2487
2488 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2489
2490 * keyboard.c (safe_run_hook_funcall): New function.
2491 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2492 don't set the hook to nil, but remove the offending function instead.
2493 (Qcommand_hook_internal): Remove, unused.
2494 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2495 Vcommand_hook_internal.
2496
2497 * eval.c (enum run_hooks_condition): Remove.
2498 (funcall_nil, funcall_not): New functions.
2499 (run_hook_with_args): Call each function through a `funcall' argument.
2500 Remove `cond' argument, now redundant.
2501 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2502 (Frun_hook_with_args_until_failure): Adjust accordingly.
2503 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2504
2505 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2506
2507 * dispextern.h (string_buffer_position): Remove declaration.
2508
2509 * print.c (strout): Remove parameter `multibyte', unused since
2510 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2511
2512 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2513 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2514 All callers changed.
2515
2516 * w32.c (_wsa_errlist): Use braces for struct initializers.
2517
2518 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2519 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2520 All callers changed.
2521 (string_buffer_position): Likewise. Also, make static (it's never
2522 used outside xdisp.c).
2523 (cursor_row_p): Remove parameter `w', unused since
2524 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2525 (decode_mode_spec): Remove parameter `precision', introduced during
2526 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2527 All callers changed.
2528
2529 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2530
2531 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2532
2533 2011-03-27 Anders Lindgren <andlind@gmail.com>
2534
2535 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2536 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2537 (ns_update_auto_hide_menu_bar): New functions.
2538 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2539 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2540 ns_constrain_all_frames.
2541 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2542 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2543
2544 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2545
2546 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2547
2548 2011-03-27 Glenn Morris <rgm@gnu.org>
2549
2550 * syssignal.h: Replace RETSIGTYPE with void.
2551 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2552 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2553 Replace SIGTYPE with void everywhere.
2554 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2555 * s/template.h (SIGTYPE): Remove commented out definition.
2556
2557 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2558
2559 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2560 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2561
2562 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2563
2564 * w32.c (read_unc_volume): Use parameter `henum', instead of
2565 global variable `wget_enum_handle'.
2566
2567 * keymap.c (describe_vector): Remove parameters `indices' and
2568 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2569 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2570
2571 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2572
2573 * keyboard.c (timer_check): Remove parameter `do_it_now',
2574 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2575 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2576 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2577
2578 * keyboard.c (read_char):
2579 * w32menu.c (w32_menu_display_help):
2580 * xmenu.c (show_help_event, menu_help_callback):
2581 Adjust calls to `show_help_echo'.
2582
2583 * gtkutil.c (xg_maybe_add_timer):
2584 * keyboard.c (readable_events):
2585 * process.c (wait_reading_process_output):
2586 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2587
2588 * insdel.c (adjust_markers_gap_motion):
2589 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2590 (gap_left, gap_right): Don't call it.
2591
2592 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2593
2594 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2595 incurred during fontification.
2596
2597 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2598
2599 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2600 (DEFVAR_PER_BUFFER): Don't pass it.
2601
2602 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2603 (scrolling_window): Don't pass it.
2604
2605 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2606
2607 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2608
2609 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2610 and `suffix'.
2611 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2612 of variables specific to SELinux and computation of `encoded_absname'.
2613
2614 * image.c (XPutPixel): Remove unused variable `height'.
2615
2616 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2617
2618 * unexw32.c (get_section_info): Remove unused variable `section'.
2619
2620 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2621 (system_process_attributes): Remove unused variable `sess'.
2622 (sys_read): Remove unused variable `err'.
2623
2624 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2625 (w32_wnd_proc): Remove unused variable `isdead'.
2626 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2627 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2628 (x_create_tip_frame): Remove unused variable `tem'.
2629
2630 * w32inevt.c (w32_console_read_socket):
2631 Remove unused variable `no_events'.
2632
2633 * w32term.c (x_draw_composite_glyph_string_foreground):
2634 Remove unused variable `width'.
2635
2636 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2637
2638 * w32term.c (x_set_glyph_string_clipping):
2639 Don't pass uninitialized region to CombineRgn.
2640
2641 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2642
2643 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2644 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2645 (Fx_close_connection): Remove unused variable `i'.
2646
2647 * w32font.c (w32font_draw): Return number of glyphs.
2648 (w32font_open_internal): Remove unused variable `i'.
2649 (w32font_driver): Add missing initializer.
2650
2651 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2652 (fill_in_menu): Remove unused variable `items_added'.
2653
2654 * w32term.c (last_mouse_press_frame): Remove static global variable.
2655 (w32_clip_to_row): Remove unused variable `f'.
2656 (x_delete_terminal): Remove unused variable `i'.
2657
2658 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2659 (NOTHING): Remove unused static global variable.
2660 (uniscribe_check_otf): Remove unused variable `table'.
2661 (uniscribe_font_driver): Add missing initializers.
2662
2663 2011-03-23 Julien Danjou <julien@danjou.info>
2664
2665 * term.c (Fsuspend_tty, Fresume_tty):
2666 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2667 * window.c (temp_output_buffer_show):
2668 * insdel.c (signal_before_change):
2669 * frame.c (Fhandle_switch_frame):
2670 * fileio.c (Fdo_auto_save):
2671 * emacs.c (Fkill_emacs):
2672 * editfns.c (save_excursion_restore):
2673 * cmds.c (internal_self_insert):
2674 * callint.c (Fcall_interactively):
2675 * buffer.c (Fkill_all_local_variables):
2676 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2677 Use Frun_hooks.
2678 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2679 unconditionnaly since it does the check itself.
2680
2681 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2682
2683 Fix more problems found by GCC 4.5.2's static checks.
2684
2685 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2686 the first time through the loop, since we know p0 < p1 then.
2687 This also avoids a gcc -Wstrict-overflow warning.
2688
2689 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2690 leading to a memory leak, possible in functions like
2691 load_charset_map_from_file that can allocate an unbounded number
2692 of objects (Bug#8318).
2693
2694 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2695 that could (at least in theory) be that large.
2696
2697 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2698 This is less likely to overflow, and avoids undefined behavior if
2699 overflow does occur. All callers changed. Use strtoul to scan
2700 for the unsigned long integer.
2701 (pint2hrstr): Simplify and tune code slightly.
2702 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2703
2704 * scroll.c (do_scrolling): Work around GCC bug 48228.
2705 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2706
2707 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2708 This also avoids a warning with gcc -Wstrict-overflow.
2709 (validate_x_resource_name): Simplify count usage.
2710 This also avoids a warning with gcc -Wstrict-overflow.
2711
2712 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2713 fail (Bug#8306).
2714
2715 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2716
2717 * process.c (Fmake_network_process): Use socklen_t, not int,
2718 where POSIX says socklen_t is required in portable programs.
2719 This fixes a porting bug on hosts like 64-bit HP-UX, where
2720 socklen_t is wider than int (Bug#8277).
2721 (Fmake_network_process, server_accept_connection):
2722 (wait_reading_process_output, read_process_output):
2723 Likewise.
2724
2725 * process.c: Rename or move locals to avoid shadowing.
2726 (list_processes_1, Fmake_network_process):
2727 (read_process_output_error_handler, exec_sentinel_error_handler):
2728 Rename or move locals.
2729 (Fmake_network_process): Define label "retry_connect" only if needed.
2730 (Fnetwork_interface_info): Fix pointer signedness.
2731 (process_send_signal): Add cast to avoid pointer signedness problem.
2732 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2733 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2734
2735 Make tparam.h and terminfo.c consistent.
2736 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2737 Include tparam.h instead, since it declares them.
2738 * cm.h (PC): Remove extern decl; tparam.h now does this.
2739 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2740 * terminfo.c: Include tparam.h, to check interfaces.
2741 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2742 (tparam): Adjust signature to match interface in tparam.h;
2743 this removes some undefined behavior. Check that outstring and len
2744 are zero, which they always are with Emacs.
2745 * tparam.h (PC, BC, UP): New extern decls.
2746
2747 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2748 (xftfont_open): Rename locals to avoid shadowing.
2749
2750 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2751 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2752 (OTF_TAG_SYM): Omit macro if not needed.
2753 (ftfont_list): Remove unused local.
2754 (get_adstyle_property, ftfont_pattern_entity):
2755 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2756 Rename locals to avoid shadowing.
2757
2758 * xfont.c (xfont_list_family): Mark var as initialized.
2759
2760 * xml.c (make_dom): Now static.
2761
2762 * composite.c (composition_compute_stop_pos): Rename local to
2763 avoid shadowing.
2764 (composition_reseat_it): Remove unused locals.
2765 (find_automatic_composition, composition_adjust_point): Likewise.
2766 (composition_update_it): Mark var as initialized.
2767 (find_automatic_composition): Mark vars as initialized,
2768 with a FIXME (Bug#8290).
2769
2770 character.h: Rename locals to avoid shadowing.
2771 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2772 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2773 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2774 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2775 to avoid shadowing.
2776
2777 * textprop.c (property_change_between_p): Remove; unused.
2778
2779 * intervals.c (interval_start_pos): Now static.
2780
2781 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2782
2783 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2784 Rename locals to avoid shadowing.
2785
2786 * sound.c (wav_play, au_play, Fplay_sound_internal):
2787 Fix pointer signedness.
2788 (alsa_choose_format): Remove unused local var.
2789 (wav_play): Initialize a variable to 0, to prevent undefined
2790 behavior (Bug#8278).
2791
2792 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2793
2794 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2795
2796 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2797 clobbering (Bug#8298).
2798 * sysdep.c (sys_subshell): Likewise.
2799 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2800
2801 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2802 This should get cleaned up, so that child_setup has the
2803 same signature on all platforms.
2804
2805 * callproc.c (call_process_cleanup): Now static.
2806 (relocate_fd): Rename locals to avoid shadowing.
2807
2808 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2809
2810 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2811 not to be necessary, and produces flickering.
2812
2813 2011-03-20 Glenn Morris <rgm@gnu.org>
2814
2815 * config.in: Remove file.
2816
2817 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2818
2819 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2820 are now in src/globals.h.
2821 (syms_of_minibuf): Remove spurious & from previous change.
2822
2823 2011-03-20 Leo <sdl.web@gmail.com>
2824
2825 * minibuf.c (completing-read-function): New variable.
2826 (completing-read-default): Rename from completing-read.
2827 (completing-read): Call completing-read-function.
2828
2829 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2830
2831 * xfaces.c (Fx_load_color_file):
2832 Read color file from absolute filename (bug#8250).
2833
2834 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2835
2836 * makefile.w32-in: Update dependencies.
2837
2838 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2839
2840 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2841
2842 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2843
2844 Fix more problems found by GCC 4.5.2's static checks.
2845
2846 * process.c (make_serial_process_unwind, send_process_trap):
2847 (sigchld_handler): Now static.
2848
2849 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2850 That way, the code declares only the vars that it needs.
2851 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2852 * s/cygwin.h (PTY_ITERATION): Likewise.
2853 * s/darwin.h (PTY_ITERATION): Likewise.
2854 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2855
2856 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2857 * process.c (allocate_pty): Don't declare stb unless it's needed.
2858
2859 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2860 (CONSTANTLIM): Remove; unused.
2861 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2862 Define only if needed.
2863
2864 * unexelf.c (unexec): Name an expression,
2865 to avoid gcc -Wbad-function-cast warning.
2866 Use a different way to cause a compilation error if anyone uses
2867 n rather than nn, a way that does not involve shadowing.
2868 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2869
2870 * deps.mk (unexalpha.o): Remove; unused.
2871
2872 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2873 * unexec.h: New file.
2874 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2875 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2876 Depend on unexec.h.
2877 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2878 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2879 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2880 Change as necessary to match prototype in unexec.h.
2881
2882 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2883 shadowing.
2884 (back_comment, skip_chars): Mark vars as initialized.
2885
2886 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2887 Rename locals to avoid shadowing.
2888
2889 * lread.c (read1): Rewrite so as not to use empty "else".
2890 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2891
2892 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2893
2894 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2895 warning when compiling print.c.
2896
2897 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2898 instead of using an uninitialized var.
2899 (font_sort_entities): Mark var as initialized.
2900
2901 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2902
2903 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2904 pointers to constants.
2905 (font_parse_fcname): Remove unused vars.
2906 (font_delete_unmatched): Now static.
2907 (font_get_spec): Remove; unused.
2908 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2909 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2910 Rename or move locals to avoid shadowing.
2911
2912 * fns.c (require_nesting_list, require_unwind): Now static.
2913 (Ffillarray): Rename locals to avoid shadowing.
2914
2915 * floatfns.c (domain_error2): Define only if needed.
2916 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2917
2918 * alloc.c (mark_backtrace): Move decl from here ...
2919 * lisp.h: ... to here, so that it can be checked.
2920
2921 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2922 (Fdefvar): Rewrite so as not to use empty "else".
2923 (lisp_indirect_variable): Name an expression,
2924 to avoid gcc -Wbad-function-cast warning.
2925 (Fdefvar): Rename locals to avoid shadowing.
2926
2927 * callint.c (quotify_arg, quotify_args): Now static.
2928 (Fcall_interactively): Rename locals to avoid shadowing.
2929 Use const pointer when appropriate.
2930
2931 * lisp.h (get_system_name, get_operating_system_release):
2932 Move decls here, to check interfaces.
2933 * process.c (get_operating_system_release): Move decl to lisp.h.
2934 * xrdb.c (get_system_name): Likewise.
2935 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2936 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2937 some of which prompt warnings from gcc -Wbad-function-cast.
2938 (Fformat_time_string, Fencode_time, Finsert_char):
2939 (Ftranslate_region_internal, Fformat):
2940 Rename or remove local vars to avoid shadowing.
2941 (Ftranslate_region_internal): Mark var as initialized.
2942
2943 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2944 avoid shadowing.
2945
2946 * lisp.h (eassert): Check that the argument compiles, even if
2947 ENABLE_CHECKING is not defined.
2948
2949 * data.c (Findirect_variable): Name an expression, to avoid
2950 gcc -Wbad-function-cast warning.
2951 (default_value, arithcompare, arith_driver, arith_error): Now static.
2952 (store_symval_forwarding): Rename local to avoid shadowing.
2953 (Fmake_variable_buffer_local, Fmake_local_variable):
2954 Mark variables as initialized.
2955 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2956
2957 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2958 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2959 Rename locals to avoid shadowing.
2960 (mark_stack): Move local variables into the #ifdef region where
2961 they're used.
2962 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2963 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2964 needed otherwise.
2965 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2966 (GC_STRING_CHARS): Remove; not used.
2967 (Fmemory_limit): Cast sbrk's returned value to char *.
2968
2969 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2970 avoids undefined behavior in theory.
2971
2972 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2973
2974 Use functions, not macros, for up- and down-casing (Bug#8254).
2975 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2976 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2977 to use the following functions instead of these macros.
2978 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2979 EMACS_INT, since callers assume the returned value fits in int.
2980 (upcase1): Likewise, for UPCASE_TABLE.
2981 (uppercasep, lowercasep, upcase): New static inline functions.
2982 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2983 the race-condition problem in the old DOWNCASE.
2984
2985 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2986 Rename locals to avoid shadowing.
2987 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2988 (regex_compile, re_search_2, re_match_2_internal):
2989 Remove unused local vars.
2990 (FREE_VAR): Rewrite so as not to use empty "else",
2991 which gcc can warn about.
2992 (regex_compile, re_match_2_internal): Mark locals as initialized.
2993 (RETALLOC_IF): Define only if needed.
2994 (WORDCHAR_P): Likewise. This one is never needed, but is used
2995 only in a comment talking about a compiler bug, so put inside
2996 the #if 0 of that comment.
2997 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2998 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2999 Remove; unused.
3000
3001 * search.c (boyer_moore): Rename locals to avoid shadowing.
3002 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3003 (PREV_CHAR_BOUNDARY): Likewise.
3004
3005 * search.c (simple_search): Remove unused var.
3006
3007 * dired.c (compile_pattern): Move decl from here ...
3008 * lisp.h: ... to here, so that it can be checked.
3009 (struct re_registers): New forward decl.
3010
3011 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3012
3013 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3014 All uses changed.
3015 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3016 Rename locals to avoid shadowing.
3017 (Fvertical_motion): Mark locals as initialized.
3018
3019 * casefiddle.c (casify_object, casify_region): Now static.
3020 (casify_region): Mark local as initialized.
3021
3022 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3023
3024 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3025 New macros, so that the caller can use some names other than
3026 gcpro1, gcpro2, etc.
3027 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3028 of the new macros.
3029 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3030 argument, for consistency with GCPRO2_VAR, etc: it is now the
3031 prefix of the variable, not the variable itself. All uses
3032 changed.
3033 * dired.c (directory_files_internal, file_name_completion):
3034 Rename locals to avoid shadowing.
3035
3036 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3037 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3038 dired.c's scmp function, had undefined behavior.
3039 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3040 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3041 * buffer.h: ... to here, because these macros use current_buffer,
3042 and the new implementation with inline functions needs to have
3043 current_buffer in scope now, rather than later when the macros
3044 are used.
3045 (downcase, upcase1): New static inline functions.
3046 (DOWNCASE, UPCASE1): Reimplement using these functions.
3047 This avoids undefined behavior in expressions like
3048 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3049 from race conditions in accessing the global variables
3050 case_temp1 and case_temp2.
3051 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3052 * lisp.h (case_temp1, case_temp2): Remove their decls.
3053 * character.h (ASCII_CHAR_P): Move from here ...
3054 * lisp.h: ... to here, so that the inline functions mentioned
3055 above can use them.
3056
3057 * dired.c (directory_files_internal_unwind): Now static.
3058
3059 * fileio.c (file_name_as_directory, directory_file_name):
3060 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3061 Now static.
3062 (file_name_as_directory): Use const pointers when appropriate.
3063 (Fexpand_file_name): Likewise. In particular, newdir might
3064 point at constant storage, so make it a const pointer.
3065 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3066 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3067 signedness issues.
3068 (Fset_file_times, Finsert_file_contents, auto_save_error):
3069 Rename locals to avoid shadowing.
3070
3071 * minibuf.c (choose_minibuf_frame_1): Now static.
3072 (Ftry_completion, Fall_completions): Rename or remove locals
3073 to avoid shadowing.
3074
3075 * marker.c (bytepos_to_charpos): Remove; unused.
3076
3077 * lisp.h (verify_bytepos, count_markers): New decls,
3078 so that gcc does not warn that these functions aren't declared.
3079
3080 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3081 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3082 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3083 (copy_text): Remove unused local var.
3084
3085 * filelock.c (within_one_second): Now static.
3086 (lock_file_1): Rename local to avoid shadowing.
3087
3088 * buffer.c (fix_overlays_before): Mark locals as initialized.
3089 (fix_start_end_in_overlays): Likewise. This function should be
3090 simplified by using pointers-to-pointers, but that's a different
3091 matter.
3092 (switch_to_buffer_1): Now static.
3093 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3094 (report_overlay_modification): Rename locals to avoid shadowing.
3095
3096 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3097 Fix pointer signedness issue.
3098 (sys_subshell): Mark local as volatile if checking for lint,
3099 to suppress a gcc -Wclobbered warning that does not seem to be right.
3100 (MAXPATHLEN): Define only if needed.
3101
3102 * process.c (serial_open, serial_configure): Move decls from here ...
3103 * systty.h: ... to here, so that they can be checked.
3104
3105 * fns.c (get_random, seed_random): Move extern decls from here ...
3106 * lisp.h: ... to here, so that they can be checked.
3107
3108 * sysdep.c (reset_io): Now static.
3109 (wait_for_termination_signal): Remove; unused.
3110
3111 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3112 (copy_keymap_item, append_key, push_text_char_description):
3113 Now static.
3114 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3115 (DENSE_TABLE_SIZE): Remove; unused.
3116 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3117 (describe_map_tree):
3118 Rename locals to avoid shadowing.
3119
3120 * keyboard.c: Declare functions static if they are not used elsewhere.
3121 (echo_char, echo_dash, cmd_error, top_level_2):
3122 (poll_for_input, handle_async_input): Now static.
3123 (read_char, kbd_buffer_get_event, make_lispy_position):
3124 (make_lispy_event, make_lispy_movement, apply_modifiers):
3125 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3126 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3127 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3128 (read_key_sequence, read_char): Mark locals as initialized.
3129 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3130
3131 * keyboard.h (make_ctrl_char): New decl.
3132 (mark_kboards): Move decl here ...
3133 * alloc.c (mark_kboards): ... from here.
3134
3135 * lisp.h (force_auto_save_soon): New decl.
3136
3137 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3138 (DEFINE_DUMMY_FUNCTION): New macro.
3139 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3140 Use it.
3141 (main): Add casts to avoid warnings
3142 if GCC considers string literals to be constants.
3143
3144 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3145
3146 * dbusbind.c: Pointer signedness fixes.
3147 (xd_signature, xd_append_arg, xd_initialize):
3148 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3149 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3150 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3151 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3152
3153 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3154 if GCC considers string literals to be constants.
3155 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3156
3157 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3158
3159 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3160 (print_preprocess, print_object): New macro to fix last change.
3161
3162 * print.c (print_preprocess): Don't forget font objects.
3163
3164 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3165
3166 * emacs.c (USAGE3): Doc fixes.
3167
3168 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3169
3170 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3171 structure.
3172
3173 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3174
3175 * lisp.h (VWindow_system, Qfile_name_history):
3176 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3177 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3178 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3179
3180 * w32select.c: Don't #include "keyboard.h".
3181 (run_protected): Add extern declaration for waiting_for_input.
3182
3183 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3184 * w32console.c (detect_input_pending, read_input_pending)
3185 (encode_terminal_code):
3186 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3187 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3188 (w32_system_caret_y, Qfile_name_history):
3189 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3190 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3191 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3192 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3193 * w32proc.c (Qlocal, report_file_error):
3194 * w32term.c (Vwindow_system, updating_frame):
3195 * w32uniscribe.c (initialized, uniscribe_font_driver):
3196 Remove unneeded extern declarations.
3197
3198 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3199
3200 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3201
3202 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3203
3204 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3205 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3206 These macros can no longer be used for assignment.
3207
3208 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3209 Assign struct members directly, instead of using BUF_BEGV etc.
3210 (record_buffer_markers, fetch_buffer_markers): New functions for
3211 recording and fetching special buffer markers.
3212 (set_buffer_internal_1, set_buffer_temp): Use them.
3213
3214 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3215
3216 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3217
3218 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3219 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3220
3221 * xdisp.c (hscroll_window_tree):
3222 (reconsider_clip_changes): Use PT instead of BUF_PT.
3223
3224 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3225
3226 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3227 $(EMACS_ROOT)/lib/intprops.h.
3228
3229 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3230
3231 Fix more problems found by GCC 4.5.2's static checks.
3232
3233 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3234 to unsigned char * to avoid compiler diagnostic.
3235 (xg_free_frame_widgets): Make it clear that a local variable is
3236 needed only if USE_GTK_TOOLTIP.
3237 (gdk_window_get_screen): Make it clear that this macro is needed
3238 only if USE_GTK_TOOLTIP.
3239 (int_gtk_range_get_value): New function, which avoids a diagnostic
3240 from gcc -Wbad-function-cast.
3241 (xg_set_toolkit_scroll_bar_thumb): Use it.
3242 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3243 diagnostic from gcc -Wbad-function-cast.
3244 (get_utf8_string, xg_get_file_with_chooser):
3245 Rename locals to avoid shadowing.
3246 (create_dialog): Move locals to avoid shadowing.
3247
3248 * xgselect.c (xg_select): Remove unused var.
3249
3250 * image.c (four_corners_best): Mark locals as initialized.
3251 (gif_load): Initialize transparent_p to zero (Bug#8238).
3252 Mark another local as initialized.
3253 (my_png_error, my_error_exit): Mark with NO_RETURN.
3254
3255 * image.c (clear_image_cache): Now static.
3256 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3257 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3258 (x_edge_detection): Remove unnecessary cast that
3259 gcc -Wbad-function-cast diagnoses.
3260 (gif_load): Fix pointer signedness.
3261 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3262 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3263
3264 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3265
3266 Improve quality of tests for time stamp overflow.
3267 For example, without this patch (encode-time 0 0 0 1 1
3268 1152921504606846976) returns the obviously-bogus value (-948597
3269 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3270 reports time overflow. See
3271 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3272 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3273 * editfns.c: Include limits.h and intprops.h.
3274 (TIME_T_MIN, TIME_T_MAX): New macros.
3275 (time_overflow): Move earlier, to before first use.
3276 (hi_time, lo_time): New functions, for an accurate test for
3277 out-of-range times.
3278 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3279 (Fget_internal_run_time): Don't assume time_t fits in int.
3280 (make_time): Use list2 instead of Fcons twice.
3281 (Fdecode_time): More accurate test for out-of-range times.
3282 (check_tm_member): New function.
3283 (Fencode_time): Use it, to test for out-of-range times.
3284 (lisp_time_argument): Don't rely on undefined left-shift and
3285 right-shift behavior when checking for time stamp overflow.
3286
3287 * editfns.c (time_overflow): New function, refactoring common code.
3288 (Fformat_time_string, Fdecode_time, Fencode_time):
3289 (Fcurrent_time_string): Use it.
3290
3291 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3292 * dired.c (make_time): Move to ...
3293 * editfns.c (make_time): ... here.
3294 * systime.h: Note the move.
3295
3296 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3297
3298 * fringe.c (update_window_fringes): Remove unused variables.
3299
3300 * unexmacosx.c (copy_data_segment): Also copy __got section.
3301 (Bug#8223)
3302
3303 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3304
3305 * termcap.c [MSDOS]: Include "msdos.h".
3306 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3307 Constify `char *' arguments and their references according to
3308 prototypes in tparam.h.
3309
3310 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3311
3312 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3313 Adapt all references accordingly.
3314
3315 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3316
3317 2011-03-11 Tom Tromey <tromey@redhat.com>
3318
3319 * buffer.c (syms_of_buffer): Remove obsolete comment.
3320
3321 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3322
3323 * termhooks.h (encode_terminal_code): Declare prototype.
3324
3325 * msdos.c (encode_terminal_code): Don't declare prototype.
3326
3327 * term.c (encode_terminal_code): Now external again, used by
3328 w32console.c and msdos.c.
3329
3330 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3331 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3332
3333 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3334
3335 Fix some minor problems found by GCC 4.5.2's static checks.
3336
3337 * fringe.c (update_window_fringes): Mark locals as initialized
3338 (Bug#8227).
3339 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3340
3341 * alloc.c (mark_fringe_data): Move decl from here ...
3342 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3343 to check its interface.
3344 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3345
3346 * fontset.c (free_realized_fontset): Now static.
3347 (Fset_fontset_font): Rename local to avoid shadowing.
3348 (fontset_font): Mark local as initialized.
3349 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3350
3351 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3352
3353 * xselect.c (x_disown_buffer_selections): Remove; not used.
3354 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3355 (x_own_selection, Fx_disown_selection_internal): Rename locals
3356 to avoid shadowing.
3357 (x_handle_dnd_message): Remove local to avoid shadowing.
3358
3359 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3360 so that the caller can use some name other than gcpro1.
3361 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3362 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3363 (Fx_backspace_delete_keys_p):
3364 Use them to avoid shadowing, and rename vars to avoid shadowing.
3365 (x_decode_color, x_set_name, x_window): Now static.
3366 (Fx_create_frame): Add braces to silence GCC warning.
3367 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3368 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3369 Remove unused locals.
3370 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3371 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3372 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3373 macros.
3374
3375 * xterm.h (x_mouse_leave): New decl.
3376
3377 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3378 Remove unused functions.
3379 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3380 (x_calc_absolute_position): Now static.
3381 (XTread_socket): Don't define label "out" unless it's used.
3382 Don't declare local "event" unless it's used.
3383 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3384 unless they are used.
3385 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3386 (x_fatal_error_signal): Remove; not used.
3387 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3388 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3389 (x_error_catcher, x_connection_closed, x_error_handler):
3390 (x_error_quitter, xembed_send_message, x_iconify_frame):
3391 (my_log_handler): Rename locals to avoid shadowing.
3392 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3393 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3394
3395 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3396 Rename or move locals to avoid shadowing.
3397 (tty_defined_color, merge_face_heights): Now static.
3398 (free_realized_faces_for_fontset): Remove; not used.
3399 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3400 does not deduce is never used uninitialized.
3401 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3402 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3403
3404 * terminal.c (store_terminal_param): Now static.
3405
3406 * xmenu.c (menu_highlight_callback): Now static.
3407 (set_frame_menubar): Remove unused local.
3408 (xmenu_show): Rename parameter to avoid shadowing.
3409 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3410 since they might point to immutable storage.
3411 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3412 since it's unused otherwise.
3413
3414 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3415 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3416 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3417 avoids a gcc -Wuninitialized diagnostic.
3418 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3419 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3420 does not deduce are never used uninitialized.
3421
3422 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3423
3424 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3425 * window.c (window_loop, size_window):
3426 (run_window_configuration_change_hook, enlarge_window): Likewise.
3427
3428 * window.c (display_buffer): Now static.
3429 (size_window): Mark variables that gcc -Wuninitialized
3430 does not deduce are never used uninitialized.
3431 * window.h (check_all_windows): New decl, to forestall
3432 gcc -Wmissing-prototypes diagnostic.
3433 * dispextern.h (bidi_dump_cached_states): Likewise.
3434
3435 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3436 shadowing.
3437 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3438 Include <limits.h>.
3439 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3440 and to avoid gcc -Wuninitialized warning.
3441 (load_charset_map): Mark variables that gcc -Wuninitialized
3442 does not deduce are never used uninitialized.
3443 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3444
3445 * coding.c (coding_set_source, coding_set_destination):
3446 Use "else { /* comment */ }" rather than "else /* comment */;"
3447 for clarity, and to avoid gcc -Wempty-body warning.
3448 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3449 a block, when the outer 'i' will do.
3450 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3451 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3452 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3453 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3454 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3455 Rename locals to avoid shadowing.
3456 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3457 * coding.c (emacs_mule_char, encode_invocation_designation):
3458 Now static, since they're not used elsewhere.
3459 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3460 (decode_coding_object, encode_coding_object, detect_coding_system):
3461 (decode_coding_emacs_mule): Mark variables that gcc
3462 -Wuninitialized does not deduce are never used uninitialized.
3463 (detect_coding_iso_2022): Initialize a local variable that might
3464 be used uninitialized. Leave a FIXME because it's not clear that
3465 this initialization is needed. (Bug#8211)
3466 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3467 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3468 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3469 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3470 Remove unused macros.
3471
3472 * category.c (hash_get_category_set): Remove unused local var.
3473 (copy_category_table): Now static, since it's not used elsewhere.
3474 * character.c (string_count_byte8): Likewise.
3475
3476 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3477 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3478
3479 * chartab.c (copy_sub_char_table): Now static, since it's not used
3480 elsewhere.
3481 (sub_char_table_ref_and_range, char_table_ref_and_range):
3482 Rename locals to avoid shadowing.
3483 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3484
3485 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3486 (BIDI_BOB): Remove unused macro.
3487
3488 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3489 deduce are never used uninitialized.
3490 * term.c (encode_terminal_code): Likewise.
3491
3492 * term.c (encode_terminal_code): Now static. Remove unused local.
3493
3494 * tparam.h: New file.
3495 * term.c, tparam.h: Include it.
3496 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3497 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3498 Move these decls to tparam.h, and make them agree with what
3499 is actually in tparam.c. The previous trick of using incompatible
3500 decls in different modules does not conform to the C standard.
3501 All callers of tparam changed to use tparam's actual API.
3502 * tparam.c (tparam1, tparam, tgoto):
3503 Use const pointers where appropriate.
3504
3505 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3506 * cm.h (struct cm): Likewise.
3507 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3508 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3509 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3510 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3511 (turn_on_face, init_tty): Likewise.
3512 * termchar.h (struct tty_display_info): Likewise.
3513
3514 * term.c (term_mouse_position): Rename local to avoid shadowing.
3515
3516 * alloc.c (mark_ttys): Move decl from here ...
3517 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3518
3519 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3520
3521 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3522
3523 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3524
3525 * search.c (compile_pattern_1): Remove argument regp, unused since
3526 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3527 (compile_pattern): Don't pass it.
3528
3529 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3530
3531 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3532 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3533 for ! HAVE_GTK3.
3534 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3535
3536 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3537
3538 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3539 gdk_window_get_screen, gdk_window_get_geometry,
3540 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3541 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3542 (xg_get_pixbuf_from_pixmap): New function.
3543 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3544 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3545 Call xg_get_pixbuf_from_pixmap instead of
3546 gdk_pixbuf_get_from_drawable.
3547 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3548 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3549 (xg_check_special_colors): Use GtkStyleContext and its functions
3550 for HAVE_GTK3.
3551 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3552 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3553 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3554 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3555 Call gtk_widget_get_preferred_size.
3556 (xg_frame_resized): gdk_window_get_geometry only takes 5
3557 parameters.
3558 (xg_win_to_widget, xg_event_is_for_menubar):
3559 Call gdk_x11_window_lookup_for_display.
3560 (xg_set_widget_bg): New function.
3561 (delete_cb): New function.
3562 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3563 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3564 (xg_set_background_color): Call xg_set_widget_bg.
3565 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3566 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3567 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3568 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3569 if ! HAVE_GTK3.
3570 (update_frame_tool_bar): Call gtk_widget_hide.
3571 (xg_initialize): Use GDK_KEY_g.
3572
3573 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3574 if ! HAVE_GTK3
3575 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3576
3577 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3578 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3579 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3580
3581 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3582
3583 * w32xfns.c (select_palette): Check success of RealizePalette against
3584 GDI_ERROR, not zero.
3585
3586 See ChangeLog.11 for earlier changes.
3587
3588 ;; Local Variables:
3589 ;; coding: utf-8
3590 ;; End:
3591
3592 Copyright (C) 2011 Free Software Foundation, Inc.
3593
3594 This file is part of GNU Emacs.
3595
3596 GNU Emacs is free software: you can redistribute it and/or modify
3597 it under the terms of the GNU General Public License as published by
3598 the Free Software Foundation, either version 3 of the License, or
3599 (at your option) any later version.
3600
3601 GNU Emacs is distributed in the hope that it will be useful,
3602 but WITHOUT ANY WARRANTY; without even the implied warranty of
3603 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3604 GNU General Public License for more details.
3605
3606 You should have received a copy of the GNU General Public License
3607 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.