1 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3 Support building on MS-Windows with libxml2.
5 * makefile.w32-in (OBJ2): Add xml.$(O).
6 (GLOBAL_SOURCES): Add xml.c.
7 ($(BLD)/xml.$(O)): New dependency list.
9 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
10 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
11 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
12 [!WINDOWSNT]: New macros.
13 (init_libxml2_functions, libxml2_loaded_p): New functions.
14 (parse_region): Call fn_xmlCheckVersion instead of using the macro
15 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
16 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
17 Calls xmlCleanupParser only if libxml2 was loaded (or statically
19 (Flibxml_parse_html_region, Flibxml_parse_xml_region): Call
20 init_libxml2_functions before calling libxml2 functions.
21 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
23 * emacs.c: Don't include libxml/parser.h.
24 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
25 xmlCleanupParser directly.
27 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
29 2012-04-07 Eli Zaretskii <eliz@gnu.org>
31 * indent.c (Fvertical_motion): If there is a display string at
32 point, use it.vpos to compute how many lines to backtrack after
33 move_it_to point. (Bug#11133)
35 2012-04-06 Eli Zaretskii <eliz@gnu.org>
37 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
38 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
39 about subtle differences between FETCH_CHAR* and STRING_CHAR*
40 macros related to unification of CJK characters. For the details,
41 see the discussion following the message here:
42 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
44 2012-04-04 Chong Yidong <cyd@gnu.org>
46 * keyboard.c (Vdelayed_warnings_list): Doc fix.
48 2012-04-01 Eli Zaretskii <eliz@gnu.org>
50 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
51 instead of alloca. (Bug#11138)
53 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
55 * w32menu.c (is_simple_dialog): Properly check lisp types.
58 2012-03-31 Eli Zaretskii <eliz@gnu.org>
60 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
61 position we get to after a call to move_it_to fails the
62 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
63 only if we wind up in a string from display property. (Bug#11063)
65 * window.c (Fdelete_other_windows_internal): Invalidate the row
66 and column information about mouse highlight, so that redisplay
67 restores it after reallocating the glyph matrices. (Bug#7464)
69 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
70 string comes from a `display' text property, use the buffer
71 position of that property as if we actually saw that position in
73 (move_it_by_lines): Remove the assertion that
74 "it->current_x == 0 && it->hpos == 0" which can be legitimately
75 violated when there's a before-string at the beginning of a line.
78 2012-03-30 Eli Zaretskii <eliz@gnu.org>
80 * xdisp.c (append_space_for_newline): If the default face was
81 remapped, use the remapped face for the appended newline.
82 (extend_face_to_end_of_line): Use the remapped default face for
83 extending the face to the end of the line.
84 (display_line): Call extend_face_to_end_of_line when the default
85 face was remapped. (Bug#11068)
87 2012-03-29 Eli Zaretskii <eliz@gnu.org>
89 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
91 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
93 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
95 2012-03-27 Glenn Morris <rgm@gnu.org>
97 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
100 2012-03-26 Kenichi Handa <handa@m17n.org>
102 * dispextern.h (struct glyph): Fix previous change. Change the
103 bit length of glyphless.ch to 25 (Bug#11082).
105 2012-03-26 Chong Yidong <cyd@gnu.org>
107 * keyboard.c (Vselection_inhibit_update_commands): New variable.
108 (command_loop_1): Use it; inhibit selection update for
109 handle-select-window too (Bug#8996).
111 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
113 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
115 2012-03-25 Kenichi Handa <handa@m17n.org>
117 * dispextern.h (struct glyph): Change the bit length of
118 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
120 2012-03-24 Eli Zaretskii <eliz@gnu.org>
122 * s/ms-w32.h (tzname): Include time.h before redirecting to
123 _tzname. Fixes the MSVC build. (Bug#9960)
125 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
127 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
130 * xterm.c (XTread_socket): Only modify handling_signal if
131 !SYNC_INPUT. (Bug#11080)
133 2012-03-23 Eli Zaretskii <eliz@gnu.org>
135 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
136 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
137 when fetching a multibyte character consumes more bytes than
138 CHAR_BYTES returns, due to unification of CJK characters in
139 string_char. (Bug#11073)
141 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
143 * process.c (wait_reading_process_output): Handle pty disconnect
144 by refraining from sending oneself a SIGCHLD (bug#10933).
146 2012-03-22 Chong Yidong <cyd@gnu.org>
148 * dispextern.h (struct it): New member string_from_prefix_prop_p.
150 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
151 Mark string as coming from a prefix property.
152 (handle_face_prop): Use default face for prefix strings (Bug#4281).
153 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
155 2012-03-21 Chong Yidong <cyd@gnu.org>
157 * xfaces.c (Vface_remapping_alist): Doc fix.
159 2012-03-20 Eli Zaretskii <eliz@gnu.org>
161 * w32proc.c (Fw32_set_console_codepage)
162 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
165 2012-03-20 Chong Yidong <cyd@gnu.org>
167 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
168 to reflect default non-nil value of redisplay-dont-pause.
170 2012-03-19 Kenichi Handa <handa@m17n.org>
172 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
173 it fit in a valid range (Bug#11003).
175 2012-03-18 Eli Zaretskii <eliz@gnu.org>
177 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
178 that is not from display property, accept the row as a "cursor
179 row" if one of the string's character has a non-nil `cursor'
180 property. Fixes cursor positioning when there are newlines in
181 overlay strings, e.g. in icomplete.el. (Bug#11035)
183 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
185 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
187 2012-03-12 Chong Yidong <cyd@gnu.org>
189 * eval.c (inhibit_lisp_code): Rename from
190 inhibit_window_configuration_change_hook; move from window.c.
192 * xfns.c (unwind_create_frame_1, Fx_create_frame):
193 * window.c (run_window_configuration_change_hook)
194 (syms_of_window): Callers changed.
196 2012-03-11 Chong Yidong <cyd@gnu.org>
198 * keymap.c (Fkey_description): Doc fix (Bug#9700).
200 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
202 2012-03-10 Chong Yidong <cyd@gnu.org>
204 * frame.c (other_visible_frames): Don't assume the selected frame
205 is visible (Bug#10955).
207 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
209 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
211 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
213 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
214 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
217 2012-03-03 Glenn Morris <rgm@gnu.org>
219 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
221 2012-03-02 Eli Zaretskii <eliz@gnu.org>
223 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
224 position past the first glyph_row that ends at ZV. (Bug#10902)
225 (redisplay_window, next_element_from_string): Fix typos in
227 (redisplay_window): Pass to move_it_vertically the margin in
228 pixels, not in screen lines.
230 2012-03-02 Glenn Morris <rgm@gnu.org>
232 * buffer.c (buffer-list-update-hook): Doc fix.
234 2012-02-29 Eli Zaretskii <eliz@gnu.org>
236 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
237 push_it before setting up the iterator for the first overlay
238 string, even if we have an empty string loaded.
239 (next_overlay_string): If there's an empty string on the iterator
240 stack, pop the stack. (Bug#10903)
242 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
244 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
245 Suggested by Stefan Monnier in
246 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
247 * alloc.c (widen_to_Lisp_Object): New static function.
248 (mark_memory): Also mark Lisp_Objects by fetching pointer words
249 and widening them to Lisp_Objects. This would work even if
250 USE_LSB_TAG is defined and wide integers are used, which might
251 happen in a future version of Emacs.
253 2012-02-25 Chong Yidong <cyd@gnu.org>
255 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
258 * xselect.c (Fx_selection_exists_p): Doc fix.
259 (x_clipboard_manager_save_all): Print an informative message
260 before saving to clipboard manager.
262 2012-02-24 Chong Yidong <cyd@gnu.org>
264 * keyboard.c (process_special_events): Handle all X selection
265 requests in kbd_buffer, not just the next one (Bug#8869).
267 2012-02-23 Chong Yidong <cyd@gnu.org>
269 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
270 call when setting menu-bar-lines and tool-bar-lines parameters.
271 (unwind_create_frame_1): New helper function.
273 * window.c (inhibit_window_configuration_change_hook): New var.
274 (run_window_configuration_change_hook): Obey it.
275 (syms_of_window): Initialize it.
277 2012-02-22 Chong Yidong <cyd@gnu.org>
279 * xterm.c (x_draw_image_relief): Add missing type check for
280 Vtool_bar_button_margin (Bug#10743).
282 2012-02-21 Chong Yidong <cyd@gnu.org>
284 * fileio.c (Vfile_name_handler_alist): Doc fix.
286 * buffer.c (Fget_file_buffer): Protect against invalid file
287 handler return value.
289 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
291 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
292 when computing $valmask.
294 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
295 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
296 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
297 It's useless in that case, and it can cause problems on hosts
298 that allocate halves of EMACS_INT values separately.
299 Reported by Dan Horák. Diagnosed by Andreas Schwab in
300 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
301 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
302 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
303 it avoids undefined behavior on hosts where shifting right by more
304 than the word width has undefined behavior.
306 2012-02-19 Chong Yidong <cyd@gnu.org>
308 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
309 (Funhandled_file_name_directory, Ffile_name_as_directory)
310 (Fdirectory_file_name, Fexpand_file_name)
311 (Fsubstitute_in_file_name): Protect against invalid file handler
312 return values (Bug#10845).
314 2012-02-18 Eli Zaretskii <eliz@gnu.org>
316 * .gdbinit (pitx): Fix incorrect references to fields of the
319 2012-02-17 Chong Yidong <cyd@gnu.org>
321 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
323 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
325 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
326 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
328 2012-02-15 Chong Yidong <cyd@gnu.org>
330 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
331 marked as special. Also, starting docstrings with * is obsolete.
333 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
335 * gnutls.c (emacs_gnutls_write): Fix last change.
337 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
339 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
342 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
344 * keymap.c (Fsingle_key_description): Handle char ranges.
346 2012-02-12 Chong Yidong <cyd@gnu.org>
348 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
349 as that creates a dangerous corner case.
351 * window.c (Fdelete_window_internal): Invalidate the mouse
352 highlight (Bug#9904).
354 2012-02-12 Glenn Morris <rgm@gnu.org>
356 * xselect.c (Fx_own_selection_internal)
357 (Fx_get_selection_internal, Fx_disown_selection_internal)
358 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
359 * nsselect.m (Fx_own_selection_internal)
360 (Fx_disown_selection_internal, Fx_selection_exists_p)
361 (Fx_selection_owner_p, Fx_get_selection_internal):
362 Sync docs and argument specs with the xselect.c versions.
364 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
366 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
368 2012-02-11 Eli Zaretskii <eliz@gnu.org>
370 * w32select.c (Fx_selection_exists_p): Sync doc string and
371 argument list with xselect.c. (Bug#10783)
373 * w16select.c (Fx_selection_exists_p): Sync doc string and
374 argument list with xselect.c. (Bug#10783)
376 2012-02-10 Glenn Morris <rgm@gnu.org>
378 * fns.c (Fsecure_hash): Doc fix.
380 2012-02-09 Kenichi Handa <handa@m17n.org>
382 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
384 2012-02-07 Chong Yidong <cyd@gnu.org>
386 * buffer.c (Fbuffer_local_variables)
387 (buffer_lisp_local_variables): Handle unbound vars correctly;
388 don't let Qunbound leak into Lisp.
390 2012-02-07 Glenn Morris <rgm@gnu.org>
392 * image.c (Fimagemagick_types): Doc fix.
394 * image.c (imagemagick-render-type): Change it from a lisp object
395 to an integer. Move the doc here from the lisp manual.
396 Treat all values not equal to 0 the same.
398 2012-02-06 Chong Yidong <cyd@gnu.org>
400 * doc.c (store_function_docstring): Avoid applying docstring of
401 alias to base function (Bug#2603).
403 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
405 * .gdbinit (pp1, pv1): Remove redundant defines.
408 2012-02-04 Chong Yidong <cyd@gnu.org>
410 * nsterm.m: Declare a global (Bug#10694).
412 2012-02-04 Eli Zaretskii <eliz@gnu.org>
414 * w32.c (get_emacs_configuration_options):
415 Include --enable-checking, if specified, in the return value.
417 2012-02-04 Martin Rudalics <rudalics@gmx.at>
419 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
420 after rounding frame sizes. (Bug#9723)
422 2012-02-04 Eli Zaretskii <eliz@gnu.org>
424 * keyboard.c (adjust_point_for_property): Don't position point
425 before BEGV. (Bug#10696)
427 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
429 Handle overflow when computing char display width (Bug#9496).
430 * character.c (char_width): Return EMACS_INT, not int.
431 (char_width, c_string_width): Check for overflow when
432 computing the width; this is possible now that individual
433 characters can have unbounded width. Problem introduced
434 by merge from Emacs 23 on 2012-01-19.
436 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
438 * dbusbind.c (Fdbus_register_method): Mention the return value
439 :ignore in the docstring.
441 2012-02-02 Glenn Morris <rgm@gnu.org>
443 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
445 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
446 Unconditionally set to t. (Bug#10673)
447 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
448 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
449 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
451 2012-02-02 Kenichi Handa <handa@m17n.org>
453 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
454 0, do not call append_composite_glyph.
456 2012-02-02 Kenichi Handa <handa@m17n.org>
458 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
460 (x_produce_glyphs): If the component of a composition is a null
461 string, set it->pixel_width to 1 to avoid zero-width glyph.
463 2012-02-01 Eli Zaretskii <eliz@gnu.org>
465 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
466 first 2 arguments are identical. This makes inserting large
467 output from a subprocess an order of magnitude faster on
468 MS-Windows, where all sbrk'ed memory is always contiguous.
470 2012-01-31 Glenn Morris <rgm@gnu.org>
472 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
473 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
474 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
476 2012-01-29 Glenn Morris <rgm@gnu.org>
478 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
480 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
482 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
484 2012-01-28 Chong Yidong <cyd@gnu.org>
486 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
488 2012-01-26 Chong Yidong <cyd@gnu.org>
490 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
492 * search.c (Fsearch_forward, Fsearch_backward): Document negative
493 repeat counts (Bug#10507).
495 2012-01-26 Glenn Morris <rgm@gnu.org>
497 * lread.c (syms_of_lread): Doc fix.
499 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
501 * coding.c (encode_designation_at_bol): Change return value to
504 2012-01-25 Chong Yidong <cyd@gnu.org>
506 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
508 2012-01-21 Chong Yidong <cyd@gnu.org>
510 * floatfns.c (Fcopysign): Make the second argument non-optional,
511 since nil is not allowed anyway.
513 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
515 * process.c (read_process_output): Use p instead of XPROCESS (proc).
516 (send_process): Likewise.
518 2012-01-19 Martin Rudalics <rudalics@gmx.at>
520 * window.c (save_window_save, Fcurrent_window_configuration)
521 (Vwindow_persistent_parameters): Do not use Qstate.
524 2012-01-19 Kenichi Handa <handa@m17n.org>
526 * character.c (char_width): New function.
527 (Fchar_width, c_string_width, lisp_string_width):
528 Use char_width (Bug#9496).
530 2012-01-16 Martin Rudalics <rudalics@gmx.at>
532 * window.c (Vwindow_persistent_parameters): New variable.
533 (Fset_window_configuration, save_window_save): Handle persistent
536 2012-01-14 Eli Zaretskii <eliz@gnu.org>
538 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
539 thrashing the stack of the thread. (Bug#9087)
541 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
543 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
545 2012-01-11 Eli Zaretskii <eliz@gnu.org>
547 * xdisp.c (rows_from_pos_range): Handle the case where the
548 highlight ends on a newline. (Bug#10464)
549 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
550 he end column for display of highlight that ends on a newline
553 2012-01-11 Glenn Morris <rgm@gnu.org>
555 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
556 from load-path also when installation-directory is nil. (Bug#10208)
558 2012-01-10 Glenn Morris <rgm@gnu.org>
560 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
562 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
563 Update template values to be closer to their typical values these days.
565 2012-01-09 Eli Zaretskii <eliz@gnu.org>
567 * xdisp.c (rows_from_pos_range): Accept additional argument
568 DISP_STRING, and accept any glyph in a row whose object is that
569 string as eligible for mouse highlight. Fixes mouse highlight of
570 display strings from overlays. (Bug#10464)
572 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
574 emacs: fix an auto-save permissions race condition (Bug#10400)
575 * fileio.c (auto_saving_dir_umask): New static var.
576 (Fmake_directory_internal): Use it.
577 (do_auto_save_make_dir): Set it, instead of invoking chmod after
578 creating the directory. The old code temporarily assigns
579 too-generous permissions to the directory.
580 (do_auto_save_eh): Clear it.
581 (Fdo_auto_save): Catch all errors, not just file errors, so
582 that the var is always cleared.
584 2012-01-07 Eli Zaretskii <eliz@gnu.org>
586 * search.c (scan_buffer): Pass character positions to
587 know_region_cache, not byte positions. (Bug#6540)
589 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
591 * w32.c (sys_rename): Report EXDEV when rename of a directory
592 fails because the target is on another logical disk. (Bug#10284)
594 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
596 * xterm.c (x_embed_request_focus): New function.
598 * xterm.h: Add prototype.
600 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
602 2012-01-05 Glenn Morris <rgm@gnu.org>
604 * emacs.c (emacs_copyright): Update short copyright year to 2012.
606 2012-01-01 Eli Zaretskii <eliz@gnu.org>
608 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
609 Load gnutls_transport_set_lowat only if GnuTLS version is below
611 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
612 GnuTLS versions below 2.11.1.
614 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
616 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
617 to the doc string advising against its use for altering the way
618 windows are scrolled.
620 2011-12-28 Kenichi Handa <handa@m17n.org>
622 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
623 coding-system ASCII compatible only when it does not produce BOM
624 on encoding (Bug#10383).
626 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
628 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
630 (create_and_show_popup_menu): Always use menu_position_func for
633 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
635 * callint.c (Fcall_interactively): Don't truncate prompt string.
637 2011-12-23 Eli Zaretskii <eliz@gnu.org>
639 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
640 property that ends at ZV, so that the bidi iteration could be
641 resumed from there (after widening). (Bug#10360)
643 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
645 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
647 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
649 * nsterm.m (x_free_frame_resources):
650 Release f->output_data.ns->miniimage.
651 (ns_index_color): Fix indentation. Do not retain
652 color_table->colors[i].
654 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
657 * nsfns.m (x_set_background_color): Assign return value from
658 ns_index_color to face-background instead of NSColor*.
659 (ns_implicitly_set_icon_type): Fix indentation.
660 Change assignment in for loop to comparison.
662 * emacs.c (ns_pool): New variable.
663 (main): Assign ns_pool.
664 (Fkill_emacs): Call ns_release_autorelease_pool.
666 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
667 autorelease fdesc, release fdAttrs and tdict.
668 (ns_get_covering_families): Release charset.
669 (ns_findfonts): Release NSFontDescriptor created with new.
670 (ns_uni_to_glyphs): Fix indentation.
671 (setString): Release attrStr before assigning new value.
673 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
675 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
677 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
678 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
680 2011-12-18 David Reitter <reitter@cmu.edu>
682 * nsterm.m (ns_term_init): Subscribe for notifications
683 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
684 to method trackingNotification in EmacsMenu.
686 * nsmenu.m (trackingMenu): New variable.
687 (trackingNotification): New method (from Aquamacs).
688 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
689 from Aquamacs (Bug#7030).
691 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
693 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
694 (symbol_to_nsstring): Fix indentation.
695 (ns_symbol_to_pb): New function.
696 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
697 (Fns_rotate_cut_buffers_internal): Remove.
698 (Fns_store_selection_internal): Rename from
699 Fns_store_cut_buffer_internal.
700 (ns_get_foreign_selection, Fx_own_selection_internal)
701 (Fx_disown_selection_internal, Fx_selection_exists_p)
702 (Fns_get_selection_internal, Fns_store_selection_internal):
703 Use ns_symbol_to_pb and check if return value is nil.
704 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
705 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
706 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
707 renamed to Sns_store_selection_internal.
708 (ns_handle_selection_request): Move code to Fx_own_selection_internal
709 and remove this function.
710 (ns_handle_selection_clear): Remove, never used.
711 (Fx_own_selection_internal): Move code from ns_handle_selection_request
714 2011-12-17 Ken Brown <kbrown@cornell.edu>
716 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
717 GID is unknown (Bug#10257).
719 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
721 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
722 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
723 which caused a build failure on GNU/Linux IA-64. This problem was
724 introduced by my 2011-10-07 patch.
726 2011-12-15 Juri Linkov <juri@jurta.org>
728 * image.c (imagemagick_error): New function. (Bug#10112)
729 (imagemagick_load_image): Comment out `MagickSetResolution' call.
730 Use `imagemagick_error' where ImageMagick functions return
732 (Fimagemagick_types): Add `Fnreverse' to return the list in the
735 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
737 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
738 fill background (Bug#8992).
740 2011-12-13 Martin Rudalics <rudalics@gmx.at>
742 * window.c (Vwindow_combination_resize)
743 (Vwindow_combination_limit): Use t instead of non-nil in
745 (Vrecenter_redisplay): Add first sentence of doc-string on
747 (Frecenter): Fix doc-string typo.
749 2011-12-11 Kenichi Handa <handa@m17n.org>
751 * coding.c (Funencodable_char_position): Pay attention to the
752 buffer text relocation (Bug#9389).
754 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
756 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
757 gtk_init (Bug#10100).
759 2011-12-10 Eli Zaretskii <eliz@gnu.org>
761 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
762 IT->string is nil. (Bug#10263)
764 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
766 * nsterm.h (x_free_frame_resources): Declare.
768 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
769 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
771 * nsterm.h (ns_get_defaults_value): Declare.
773 * nsterm.m (ns_default): Call ns_get_defaults_value.
775 2011-12-09 Eli Zaretskii <eliz@gnu.org>
777 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
780 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
782 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
783 that where the value of an _OBJC_* symbol points to is in the .bss
786 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
788 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
789 after the loop to call ccl_driver at least once (Bug#8619).
791 2011-12-08 Kenichi Handa <handa@m17n.org>
793 * ftfont.c (get_adstyle_property): Fix previous change
796 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
798 * w32.c (init_environment): If no_site_lisp, remove site-lisp
799 dirs from the default value of EMACSLOADPATH (bug#10208).
801 2011-12-07 Glenn Morris <rgm@gnu.org>
803 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
804 installation and source directories as well. (Bug#10208)
806 2011-12-06 Chong Yidong <cyd@gnu.org>
808 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
810 2011-12-06 Glenn Morris <rgm@gnu.org>
812 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
813 as an error, not just -1. (Bug#10217)
815 2011-12-05 Chong Yidong <cyd@gnu.org>
817 * keyboard.c (process_special_events): New function.
818 (swallow_events, Finput_pending_p): Use it (Bug#10195).
820 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
822 * coding.c (encode_designation_at_bol): Don't use uninitialized
823 local variable (Bug#9318).
825 2011-12-05 Kenichi Handa <handa@m17n.org>
827 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
828 return Qnil (Bug#8046, Bug#10193).
830 2011-12-05 Kenichi Handa <handa@m17n.org>
832 * coding.c (encode_designation_at_bol): New args charbuf_end and
833 dst. Return the number of produced bytes. Callers changed.
834 (coding_set_source): Return how many bytes coding->source was
836 (coding_set_destination): Return how many bytes
837 coding->destination was relocated.
838 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
839 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
841 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
843 * coding.c (CODING_CHAR_CHARSET_P): New macro.
844 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
847 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
849 The following changes are to fix Bug#9318.
851 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
852 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
853 (encode_coding_iso_2022, encode_coding_sjis)
854 (encode_coding_big5, encode_coding_charset): Use the above macros.
856 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
858 * lisp.h (process_quit_flag): Fix external declaration.
860 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
862 Don't macro-inline non-performance-critical code.
863 * eval.c (process_quit_flag): New function.
864 * lisp.h (QUIT): Use it.
866 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
868 * nsfns.m (get_geometry_from_preferences): New function.
869 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
871 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
873 * emacs.c (Qkill_emacs): Define.
874 (syms_of_emacs): Initialize it.
875 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
876 Qquit_flag to `kill-emacs' instead.
877 (quit_throw_to_read_char): Add parameter `from_signal'.
878 All callers changed. Call Fkill_emacs if requested and safe.
879 * lisp.h (QUIT): Call Fkill_emacs if requested.
881 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
883 * widget.c (update_wm_hints): Return if wmshell is null.
884 (widget_update_wm_size_hints): New function.
886 * widget.h (widget_update_wm_size_hints): Declare.
888 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
889 widget_update_wm_size_hints (Bug#10104).
891 2011-12-03 Eli Zaretskii <eliz@gnu.org>
893 * xdisp.c (handle_invisible_prop): If the invisible text ends just
894 before a newline, prepare the bidi iterator for consuming the
895 newline, and keep the current paragraph direction. (Bug#10183)
896 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
898 2011-12-02 Juri Linkov <juri@jurta.org>
900 * search.c (Fword_search_regexp): New Lisp function created from
901 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
902 (Fword_search_backward, Fword_search_forward)
903 (Fword_search_backward_lax, Fword_search_forward_lax):
904 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
905 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
907 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
909 * fileio.c (Finsert_file_contents): Move after-change-function call
910 to before the "handled:" label, since all "goto handled" appear in
911 cases where the *-change-functions have already been properly called
914 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
916 * keyboard.c (interrupt_signal): Don't call kill-emacs when
917 waiting for input. (Bug#10169)
919 2011-11-30 Eli Zaretskii <eliz@gnu.org>
921 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
922 verifies glyph row's hash code--we have just reallocated the
923 glyphs, so their contents can be complete garbage. (Bug#10164)
925 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
927 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
929 2011-11-30 Eli Zaretskii <eliz@gnu.org>
931 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
932 attributes are tested _before_ calling verify_row_hash, to protect
933 against GCC re-ordering of the tests. (Bug#10164)
935 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
937 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
939 * xterm.c (handle_one_xevent): Only set async_visible and friends
940 if net_wm_state_hidden_seen is non-zero (Bug#10002)
941 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
942 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
944 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
946 Remove GCPRO-related macros that exist only to avoid shadowing locals.
947 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
948 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
949 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
950 All uses changed to use GCPRO1 etc.
951 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
952 Revert to old implementation (i.e., before 2011-03-11).
954 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
956 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
957 of scroll runs so as to avoid assigning disabled bogus rows and
958 unnecessary graphics copy operations.
960 2011-11-27 Eli Zaretskii <eliz@gnu.org>
962 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
963 (snprintf) [_MSC_VER]: Redirect to _snprintf.
964 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
965 (malloc, free, realloc, calloc): Redirect to e_* only when
968 * lisp.h (GCTYPEBITS): Move before first use.
969 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
970 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
971 this macro definition.
973 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
976 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
978 * gtkutil.c (xg_create_frame_widgets):
979 Call gtk_window_set_has_resize_grip (FALSE) if that function is
980 present with Gtk+ 2.0.
982 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
984 * fileio.c (Finsert_file_contents): Undo previous change; see
985 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
987 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
989 Rename locals to avoid shadowing.
990 * fileio.c (Finsert_file_contents):
991 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
992 * process.c (wait_reading_process_output):
993 Rename inner 'proc' to 'p' to avoid shadowing.
994 Indent for consistency with usual Emacs style.
996 2011-11-25 Eli Zaretskii <eliz@gnu.org>
998 * xdisp.c (redisplay_window): If cursor row is not fully visible
999 after recentering, and scroll-conservatively is set to a large
1000 number, scroll window by a few more lines to make the cursor fully
1001 visible and out of scroll-margin. (Bug#10105)
1002 (start_display): Don't move to the next line if the display should
1003 start at a newline that is part of a display vector or an overlay
1006 2011-11-24 Juri Linkov <juri@jurta.org>
1008 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1009 after the `MagickPingImage' call. (Bug#10112)
1011 2011-11-23 Chong Yidong <cyd@gnu.org>
1013 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1015 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1017 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1018 making another buffer current. (Bug#10114)
1020 2011-11-23 Glenn Morris <rgm@gnu.org>
1022 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1024 2011-11-23 Chong Yidong <cyd@gnu.org>
1026 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1027 using it (Bug#5984).
1029 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1031 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1032 and header-lines, as they don't have one computed for them.
1035 * .gdbinit (prow): Make displayed values more self-explaining.
1036 Add row's hash code.
1038 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1040 * process.c (wait_reading_process_output): Fix asynchrounous
1041 GnuTLS socket handling on some versions of the GnuTLS library.
1042 (wait_reading_process_output): Add comment and URL.
1044 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1046 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1048 2011-11-21 Chong Yidong <cyd@gnu.org>
1050 * window.c (Fnext_window, Fprevious_window): Doc fix.
1052 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1054 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1056 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1058 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1060 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1062 * window.c (Fset_window_combination_limit): Rename argument
1064 (Vwindow_combination_limit): Remove "status" from doc-string.
1066 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1068 * m/ibms390.h: Remove.
1069 * m/ibms390x.h: Don't include "ibms390.h".
1071 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1073 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1074 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1076 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1078 * casetab.c (Fset_case_table):
1079 * charset.c (Fcharset_after): Fix typos.
1081 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1083 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1084 Otherwise, valgrind does not work on some platforms.
1085 Problem reported by Andreas Schwab in
1086 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1087 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1088 is set, removing the need for VIRT_ADDRESS_VARIES.
1089 (PURE_P): Use a more-efficient implementation that needs just one
1090 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1091 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1092 to 4 (xorl, subq, cmpq, setbe).
1093 * alloc.c (pure): Always extern now, since that's the
1094 VIRT_ADDR_VARIES behavior.
1095 (PURE_POINTER_P): Use a single comparison, not two, for
1096 consistency with the new puresize.h.
1097 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1098 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1099 Remove VIRT_ADDR_VARIES no longer needed.
1101 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1103 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1104 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1105 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1106 behave as if the cursor position were at the window margin.
1108 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1109 and the cursor position is out of bounds, behave as if the cursor
1110 position were at the window margin. (Bug#10075)
1112 2011-11-18 Chong Yidong <cyd@gnu.org>
1114 * window.c (Fwindow_combination_limit): Make first argument
1115 non-optional, since it is meaningless for live windows like the
1118 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1120 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1122 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1124 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1125 (graft_intervals_into_buffer): Simplify.
1127 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1129 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1130 hash values of the two rows.
1131 (copy_row_except_pointers): Preserve the used[] arrays and the
1132 hash values of the two rows. (Bug#10035)
1133 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1135 * xdisp.c (row_hash): New function, body extracted from
1136 compute_line_metrics.
1137 (compute_line_metrics): Call row_hash, instead of computing the
1140 * dispnew.c (verify_row_hash): Call row_hash for computing the
1141 hash code of a row, instead of duplicating code from xdisp.c.
1143 * dispextern.h (row_hash): Add prototype.
1145 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1147 * frame.c (delete_frame): Don't delete the terminal when the last
1148 X frame is closed if emacs is built with GTK toolkit.
1150 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1152 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1154 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1156 * window.c (Vwindow_splits): Rename to
1157 Vwindow_combination_resize. Suggested by Juri Linkov.
1158 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1161 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1163 * nsfns.m (Fns_font_name):
1164 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1166 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1168 * window.h (window): Rename slot "nest" to "combination_limit".
1169 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1170 (Fset_window_nest): Rename to Fset_window_combination_limit.
1171 (Vwindow_nest): Rename to Vwindow_combination_limit.
1172 (recombine_windows, make_parent_window, make_window)
1173 (Fsplit_window_internal, saved_window)
1174 (Fset_window_configuration, save_window_save): Rename all
1175 occurrences of window_nest to window_combination_limit.
1177 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1179 * image.c (imagemagick_load_image): Fix typo.
1181 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1183 * xdisp.c (display_line): Move the call to
1184 highlight_trailing_whitespace before the call to
1185 compute_line_metrics, since the latter needs to see the final
1186 faces of all the glyphs to compute ROW's hash value.
1187 Fixes assertion violations in row_equal_p. (Bug#10035)
1189 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1191 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1192 just return (bug#10044).
1194 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1196 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1197 with user-defined heap size. Bump the default size of the temacs
1198 heap to 27MB, to avoid memory warning when running temacs.
1199 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1201 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1202 current_matrix and desired_matrix. (Bug#9990)
1203 (verify_row_hash) [XASSERTS]: New function.
1204 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1205 that the hash value of glyph rows is correct.
1207 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1209 * window.h (window): Remove splits slot.
1210 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1211 (Fdelete_other_windows_internal, make_parent_window)
1212 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1213 (Fset_window_configuration, save_window_save): Don't deal with
1214 split status of windows.
1215 (saved_window): Remove splits slot.
1216 (Vwindow_splits): Rewrite doc-string.
1218 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1220 * xfns.c (unwind_create_frame):
1221 * nsfns.m (unwind_create_frame):
1222 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1223 Vframe_list (Bug#9999).
1225 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1227 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1229 2011-11-11 Kenichi Handa <handa@m17n.org>
1231 * callproc.c (Fcall_process): Set the member dst_multibyte of
1234 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1236 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1237 avoid a crash (bug#9496).
1239 2011-11-09 Chong Yidong <cyd@gnu.org>
1241 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1242 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1244 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1246 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1248 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1250 Avoid some portability problems by eschewing 'extern inline' functions.
1251 The trivial performance wins aren't worth the portability hassles; see
1252 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1254 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1255 (window_box_width, window_box_left, window_box_left_offset)
1256 (window_box_right, window_box_right_offset): Undo previous change,
1257 by removing the "extern"s.
1258 * intervals.c (adjust_intervals_for_insertion)
1259 (adjust_intervals_for_deletion): Undo previous change,
1260 making these static again.
1261 (offset_intervals, temp_set_point_both, temp_set_point)
1262 (copy_intervals_to_string): No longer inline.
1263 * xdisp.c (window_text_bottom_y, window_box_width)
1264 (window_box_height, window_box_left_offset)
1265 (window_box_right_offset, window_box_left, window_box_right)
1266 (window_box): No longer inline.
1268 2011-11-08 Chong Yidong <cyd@gnu.org>
1270 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1271 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1272 Signal an error if not a live window.
1273 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1274 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1276 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1278 * lisp.h (syms_of_abbrev): Remove declaration.
1279 Reported by CHENG Gao <chenggao@royau.me>.
1281 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1283 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1284 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1285 of temacs in GUI mode.
1287 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1289 * window.h: Declare delete_all_child_windows instead of
1290 delete_all_subwindows.
1291 * window.c (Fwindow_nest, Fset_window_nest)
1292 (Fset_window_new_total, Fset_window_new_normal)
1293 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1294 (delete_all_subwindows): Rename to delete_all_child_windows.
1295 (Fdelete_other_windows_internal, Fset_window_configuration):
1296 Call delete_all_child_windows instead of delete_all_subwindows.
1297 * frame.c (delete_frame): Call delete_all_child_windows instead
1298 of delete_all_subwindows.
1300 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1302 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1303 This is also needed for porting to any host where GC_MARK_STACK is
1304 not GC_MAKE_GCPROS_NOOPS.
1305 (which_symbols): Use it.
1307 2011-11-07 Kenichi Handa <handa@m17n.org>
1309 * coding.c (coding_set_destination): Check coding->src_pos only
1310 when coding->src_object is a buffer (bug#9910).
1312 * process.c (send_process): Set the member src_multibyte of coding
1313 to 0 (bug#9911) when sending a unibyte text.
1315 * callproc.c (Fcall_process): Set the member src_multibyte of
1316 process_coding to 0 (bug#9912).
1318 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1320 * xmenu.c (cleanup_widget_value_tree): New function.
1321 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1322 calling free_menubar_widget_value_tree directly (Bug#9830).
1324 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1326 Fix some portability problems with 'inline'.
1327 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1328 (window_box_width, window_box_left, window_box_left_offset)
1329 (window_box_right, window_box_right_offset): Declare extern.
1330 Otherwise, these inline functions do not conform to C99 and
1331 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1332 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1333 * intervals.c (adjust_intervals_for_insertion)
1334 (adjust_intervals_for_deletion): Now extern, because otherwise the
1335 extern inline functions 'offset_intervals' couldn't refer to it.
1336 (static_offset_intervals): Remove.
1337 (offset_intervals): Rewrite using the old contents of
1338 static_offset_intervals. The old version didn't conform to C99
1339 because an extern inline function contained a reference to an
1340 identifier with static linkage.
1342 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1344 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1347 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1349 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1350 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1351 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1352 return Qleft_to_right.
1354 2011-11-06 Chong Yidong <cyd@gnu.org>
1356 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1357 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1358 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1359 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1360 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1361 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1362 (Fwindow_vscroll): Doc fix.
1363 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1364 argument, since it makes no sense to pass a live window and for
1365 consistency with window-child.
1367 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1369 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1372 2011-11-05 Jason Rumney <jasonr@gnu.org>
1374 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1375 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1377 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1378 bitwise arithmetic preventing use of unicode-sip and non-truetype
1381 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1383 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1386 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1387 initialization code to keep similarity to xfns.c after changes
1390 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1392 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1393 (unwind_create_frame): New function (Bug#9943).
1394 (Fx_create_frame): Restructure code to be more similar to the one in
1395 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1396 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1397 Move terminal->reference_count++ just before making the frame official
1400 * nsterm.m (x_free_frame_resources): New function.
1401 (x_destroy_window): Move code to x_free_frame_resources.
1403 * xfns.c (unwind_create_frame): Fix comment.
1404 (Fx_create_frame, x_create_tip_frame):
1405 Move terminal->reference_count++ just before making the frame
1406 official. Move initialization of image_cache_refcount and
1407 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1409 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1411 Support MSVC build with newer versions of Visual Studio.
1412 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1413 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1416 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1417 which are not supported by MSVC.
1418 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1419 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1421 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1423 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1425 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1427 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1429 Support MSVC build with newer versions of Visual Studio.
1430 * w32.c: Don't include w32api.h for MSVC.
1431 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1433 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1434 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1435 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1436 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1438 (alloca) [_MSC_VER]: Define to _alloca.
1440 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1442 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1444 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1446 * xdisp.c (note_mouse_highlight): If either of
1447 previous/next-single-property-change returns nil, treat that as
1448 the beginning or the end of the buffer. (Bug#9955)
1450 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1452 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1453 label is not null (Bug#9951).
1454 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1457 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1459 * window.c (Fwindow_body_size): Mention in the doc string that the
1460 return value is in frame's canonical units. (Bug#9949)
1462 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1464 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1466 * w32fns.c (unwind_create_frame): If needed, free the glyph
1467 matrices of the partially constructed frame. (Bug#9943)
1468 * xfns.c (unwind_create_frame): Likewise.
1470 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1472 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1473 Don't stop backward scan on the continuation glyph, even though
1474 its CHARPOS is positive.
1475 (mouse_face_from_buffer_pos, note_mouse_highlight):
1476 Rename cover_string to disp_string.
1478 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1480 * window.c (temp_output_buffer_show): Don't use
1481 Vtemp_buffer_show_specifiers.
1482 (Vtemp_buffer_show_specifiers): Remove unused variable.
1484 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1486 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1487 past the beginning of the current glyph matrix.
1489 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1491 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1492 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1493 HAVE_GTK3 (Bug#9869).
1495 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1496 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1498 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1500 * xterm.c: Declare x_handle_net_wm_state to return int.
1501 (handle_one_xevent): Check if we are iconified but don't have
1502 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1503 (get_current_wm_state): Return non-zero if not hidden,
1504 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1505 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1506 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1507 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1509 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1511 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1512 so that this new function doesn't get optimized away by a
1513 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1515 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1517 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1519 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1521 Fix the `xbytecode' command.
1522 * .gdbinit (xprintbytestr): New command.
1523 (xwhichsymbols): Rename from `which'; all callers changed.
1524 (xbytecode): Print the byte-code string as well.
1526 2011-10-29 Kim Storm <storm@cua.dk>
1528 * alloc.c (which_symbols): New function.
1530 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1532 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1535 2011-10-29 Glenn Morris <rgm@gnu.org>
1537 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1538 Not clear what it was for, and it causes various bugs. (Bug#9839)
1540 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1542 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1543 possible random value that matches one of those tested as
1544 condition to clear the mouse face.
1546 2011-10-28 Chong Yidong <cyd@gnu.org>
1548 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1550 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1552 * window.c (make_window): Initialize phys_cursor_on_p.
1554 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1556 * lisp.h (struct Lisp_Symbol): Update comments.
1558 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1560 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1562 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1564 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1565 <oslsachem@gmail.com> for helping to debug this.
1567 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1568 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1569 (g_b_init_get_glyph_outline_w): New static variables.
1570 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1571 (GetGlyphOutlineW_Proc): New typedefs.
1572 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1573 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1575 (w32font_open_internal, compute_metrics):
1576 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1577 instead of calling the "wide" APIs directly.
1579 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1581 * w32.h (syms_of_w32font): Add prototype.
1583 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1585 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1586 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1587 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1588 (Fmove_to_window_line): Doc fix.
1590 2011-10-27 Chong Yidong <cyd@gnu.org>
1592 * process.c (make_process): Set gnutls_state to NULL.
1594 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1595 non-NULL, regardless of GNUTLS_INITSTAGE.
1596 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1597 an error. Set process slots as soon as we allocate them.
1599 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1601 2011-10-27 Chong Yidong <cyd@gnu.org>
1603 * gnutls.c (emacs_gnutls_deinit): New function.
1604 Deallocate credentials structures as well as calling gnutls_deinit.
1605 (Fgnutls_deinit, Fgnutls_boot): Use it.
1607 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1608 (deactivate_process): Call emacs_gnutls_deinit.
1610 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1612 * image.c (x_create_x_image_and_pixmap):
1613 * w32.c (sys_rename, w32_delayed_load):
1614 * w32font.c (fill_in_logfont):
1615 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1617 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1619 * w32fns.c (w32_default_color_map): New function,
1620 extracted from Fw32_default_color_map.
1621 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1623 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1625 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1627 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1629 * keyboard.c (test_undefined): New function (bug#9751).
1630 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1632 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1634 * sysdep.c (init_sys_modes): Fix the check for the controlling
1635 terminal (Bug#6649).
1637 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1639 * dispextern.h (struct bidi_it): New member next_en_type.
1641 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1642 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1643 current character, check also for next_en_type being WEAK_EN.
1644 (bidi_resolve_weak): Don't enter the expensive loop if the current
1645 position is before next_en_pos. Record the bidi type of the first
1646 non-ET, non-BN character we find, in addition to its position.
1647 (bidi_level_of_next_char): Invalidate next_en_type when
1648 next_en_pos is over-stepped.
1650 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1652 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1653 * editfns.c: Rewrite current-time-zone so that it invokes
1654 the equivalent of (format-time-string "%Z") to get the time zone name.
1655 This fixes a bug when the time zone name contains characters that
1656 need converting from the system time locale to Emacs internal format.
1657 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1658 that patch fixed format-time-string to do the conversion, but
1659 I forgot to fix current-time-zone.
1660 (format_time_string): New function, containing most of
1661 what Fformat_time_string used to contain.
1662 (Fformat_time_string): Rewrite in terms of format_time_string.
1663 This doesn't change this function's behavior.
1664 (current-time-zone): Rewrite to use format_time_string.
1665 This fixes the bug reported by Michael Schierl in
1666 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1667 Jason Rumney's 2007-06-07 change worked around this bug, but
1669 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1671 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1673 * xdisp.c (start_display): If the character at POS is displayed
1674 via a display vector, reset IT->current.dpvec_index to zero.
1675 (try_window_reusing_current_matrix): If a line ends in a display
1676 vector or the next line starts in a display vector, continue
1677 redrawing the window even though the character position of
1678 start_row was reached.
1681 2011-10-18 Chong Yidong <cyd@gnu.org>
1683 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1684 with nobreak-char-display too.
1686 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1688 Fix part 3 of bug#9771.
1689 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1690 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1691 non-neutral characters if the current character is a paragraph
1692 separator (a.k.a. Newline). This avoids running the same
1693 expensive loop twice, once when we consume the preceding newline
1694 and the other time when the line actually needs to be displayed.
1695 Avoid the loop when we see neutrals on the base embedding level
1696 following a character whose directionality is the same as the
1697 paragraph's. This avoids running the expensive loop when a line
1698 ends in a long sequence of neutrals, like control characters.
1699 Add assertion against STRONG_AL type. Slightly rearrange code
1700 that determines the type of a neutral given the first non-neutral
1702 (bidi_level_of_next_char): Set next_en_pos to zero when
1703 invalidating its info.
1705 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1707 * xdisp.c (push_display_prop): Determine whether to record string
1708 or buffer position by IT->string, not by IT->method. Allow
1709 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1710 (move_it_vertically_backward): Don't look for character position
1711 immediately after the newline when in a continuation line.
1714 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1716 * window.c (coordinates_in_window): Rewrite and delabelize
1717 vertical border check. (Bug#5357) (Bug#9618)
1719 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1721 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1722 errors in XSetWindowBorder (bug#9310).
1724 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1726 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1727 avoid crash when xmalloc overrun checking is enabled.
1729 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1731 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1732 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1733 cursor motion with <left> and <right> arrow keys.
1735 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1736 some callers set that themselves.
1738 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1740 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1741 display string and the previous row comes from the same string and
1742 is empty. (Bug#9739) (Bug#9738)
1744 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1746 * doc.c (get_doc_string): Encode file name (bug#9735).
1748 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1750 * bidi.c (bidi_level_of_next_char):
1751 * xdisp.c (get_visually_first_element): Remove old incorrect
1752 comments regarding the Unicode Line Separator character.
1754 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1756 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1758 * alloc.c (Fgc_status): Do not access beyond zombies array
1759 boundary if nzombies > MAX_ZOMBIES.
1760 * alloc.c (dump_zombies): Add missing format specifier.
1762 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1764 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1765 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1767 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1768 Some packages use them to denote characters with modifiers.
1770 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1772 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1773 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1774 matching a pp-number. Rename parameter var to var1.
1776 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1778 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1780 2011-10-08 Glenn Morris <rgm@gnu.org>
1782 * callint.c (Fcall_interactively): Give a more explicit error for the
1783 'c' case with a non-character input. (Bug#8479)
1785 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1787 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1789 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1790 lines that are hscrolled on the left.
1792 * dispnew.c (buffer_posn_from_coords): Account for a possible
1793 presence of header-line. (Bug#4426)
1795 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1797 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1798 Don't advertise functionality which we discourage or doesn't work.
1800 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1802 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1803 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1804 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1805 this makes Emacs dump core during garbage collection on rare
1806 occasions. sizeof is obviously inferior to offsetof here, so
1807 stick with offsetof.
1808 (GC_POINTER_ALIGNMENT): New macro.
1809 (mark_memory): Omit 3rd (offset) arg; caller changed.
1810 Don't assume EMACS_INT alignment is the same as pointer alignment.
1812 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1814 * keyboard.c (read_key_sequence_remapped): New var.
1815 (read_key_sequence): Compute remapping in the right buffer.
1816 (command_loop_1): Use read_key_sequence's remapping directly.
1818 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1820 * dired.c (file_name_completion): Don't expand file name.
1821 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1822 before checking file name handler.
1824 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1825 they've been requested explicitly (bug#9591).
1827 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1829 * keymap.c (Fsingle_key_description): Use make_specified_string
1830 instead of build_string to build string from push_key_description.
1833 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1835 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1836 This fixes a Y2038 bug on 64-bit hosts.
1837 * buffer.c (reset_buffer):
1838 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1839 (Fclear_buffer_auto_save_failure):
1840 Use 0, not -1, to represent an unset failure time, since time_t
1841 might not be signed.
1843 Remove dependency on glibc malloc internals.
1844 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1845 Move back here from lisp.h, but with their new implementations.
1846 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1847 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1848 * charset.c (charset_table_init): New static var.
1849 (syms_of_charset): Use it instead of xmalloc. This removes a
1850 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1851 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1852 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1853 Move back to alloc.c.
1854 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1855 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1857 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1859 * nsterm.m (windowDidResize): Call x_set_window_size only when
1860 ns_in_resize is true. Otherwise set pixelwidth/height and
1861 call change_frame_size (Bug#9628).
1863 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1865 Port --enable-checking=all to Fedora 14 x86-64.
1866 * charset.c (syms_of_charset): Also account for glibc malloc's
1867 internal overhead when calculating the initial malloc maximum.
1869 Port --enable-checking=all to Fedora 14 x86.
1870 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1872 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1873 (overrun_check_realloc, overrun_check_free):
1874 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1875 That way, xmalloc returns a properly-aligned pointer even if
1876 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1877 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1878 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1879 into account when calculating the initial malloc maximum.
1880 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1881 Move here from alloc.c, so that charset.c can use it too.
1882 Properly align; the old code wasn't right for common 32-bit hosts
1883 when configured with --enable-checking=all.
1884 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1885 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1887 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1889 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1892 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1894 * xdisp.c (compute_display_string_end): If there's no display
1895 string at CHARPOS, return -1.
1897 * bidi.c (bidi_fetch_char): When compute_display_string_end
1898 returns a negative value, treat the character as a normal
1899 character not covered by a display string. (Bug#9624)
1901 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1903 * lread.c (Fread_from_string): Fix typo in docstring.
1905 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1907 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1908 newline, reseat the iterator instead of bidi-iterating there one
1909 character at a time. (Bug#9610)
1910 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1911 TO_CHARPOS if the bidi iterator is at base embedding level.
1913 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1915 * lread.c (readevalloop): Use correct code for NBSP.
1916 (read1): Likewise. (Bug#9608)
1918 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1920 * dbusbind.c (Fdbus_register_signal): When service is not
1921 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1923 2011-09-25 Glenn Morris <rgm@gnu.org>
1925 * buffer.c (truncate-lines): Doc fix.
1927 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1929 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1930 (Fset_window_next_buffers): Doc fix.
1932 2011-09-24 Glenn Morris <rgm@gnu.org>
1934 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1936 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1938 Fix minor problems found by static checking.
1939 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1940 * indent.c (Fvertical_motion): Fix == vs = typo.
1942 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1944 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1945 Default value is now t. Doc fix.
1947 * indent.c (Fvertical_motion): Compute and apply the overshoot
1948 logic when moving up, not only when moving down. Fix the
1949 confusing name and values of the it_overshoot_expected variable;
1950 logic changes accordingly. (Bug#9254) (Bug#9549)
1952 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1953 CHARPOS is covered by a display string which includes newlines.
1954 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1955 is covered by a display string with embedded newlines.
1957 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1959 * dbusbind.c (Fdbus_register_signal): Add match rule to
1960 Vdbus_registered_objects_table. (Bug#9581)
1961 (Fdbus_register_method, Vdbus_registered_objects_table):
1964 2011-09-24 Jim Meyering <meyering@redhat.com>
1966 do not ignore write error for any output size
1967 The previous change was incomplete.
1968 While it makes emacs --batch detect the vast majority of stdout
1969 write failures, errors were still ignored whenever the output size is
1970 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1971 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1972 && echo FAIL: ignored write error
1973 FAIL: ignored write error
1974 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1975 && echo FAIL: ignored write error
1976 FAIL: ignored write error
1977 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1979 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1981 * emacs.c (Fkill_emacs): In noninteractive mode exit
1982 non-successfully if a write error occurred on stdout. (Bug#9574)
1984 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1986 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1989 * dispextern.h (struct it): Update the comment documenting what
1992 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1994 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1995 a display string, extend search for cursor position to end of row.
1996 (find_row_edges): If the row ends in a newline from a display
1997 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1998 Handle the case of a display string with multiple newlines.
1999 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2000 non-empty line. Fixes confusing cursor motion with arrow keys at
2001 the beginning of a line that starts with whitespace.
2003 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2005 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2008 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2010 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2013 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2015 * xdisp.c (display_line): Record maximum and minimum buffer
2016 positions even if no glyphs were produced (e.g., by a zero-width
2017 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2018 buffer positions that will be removed from the glyph row because
2020 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2021 column is beyond frame width: don't subtract 1 "pixel" when
2022 computing width of the stretch.
2023 (reseat_at_next_visible_line_start): Undo the change made on
2024 2011-09-17 that saved paragraph information and restored it after
2025 the call to `reseat'. (Bug#9545)
2027 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2029 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2030 and turn window cursor on if cleared (Bug#9415).
2032 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2034 * search.c (boyer_moore): Take unibyte characters from pattern
2035 literally. (Bug#9458)
2037 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2039 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2041 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2043 Fix minor problem found by static checking.
2044 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2045 initialized, to pacify gcc -Wuninitialized.
2047 * fileio.c: Report proper errno when syscall falls.
2048 (Finsert_file_contents): Save and restore errno,
2049 so that report_file_error outputs the correct diagnostic.
2050 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2052 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2054 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2056 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2058 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2059 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2061 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2063 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2064 about the current paragraph and restore it after the call to reseat.
2066 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2067 (bidi_find_paragraph_start): Search back for paragraph beginning
2068 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2069 (bidi_move_to_visually_next): Only trigger paragraph-related
2070 computations when the last character is a newline or at EOB, not
2071 just any NEUTRAL_B. (Bug#9470)
2073 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2074 truncated lines if point is covered by a display string. (Bug#9524)
2076 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2078 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2079 (cons_to_x_long): New function.
2080 (lisp_data_to_selection_data): Use it. Correct the test for
2081 short-versus-long data; it was negated. Break out of vector
2082 loop, for efficiency, when a long datum is discovered.
2084 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2086 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2088 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2090 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2091 GCC PR/17406) by declaring this function with external scope.
2093 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2095 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2096 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2098 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2100 * editfns.c (Fformat): Correctly handle text properties on "%%".
2102 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2104 * xterm.c (x_draw_composite_glyph_string_foreground):
2105 * w32term.c (x_draw_composite_glyph_string_foreground):
2106 * term.c (encode_terminal_code):
2107 * composite.c (composition_update_it, get_composition_id):
2108 * xdisp.c (get_next_display_element)
2109 (fill_composite_glyph_string): Add comments about special meaning
2110 of TAB characters in a composition.
2112 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2114 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2115 This occurs when processing a multibyte format.
2116 Problem reported by Wolfgang Jenker.
2118 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2120 * xdisp.c (try_cursor_movement): Only check for exact match if
2121 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2123 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2125 Remove unused external symbols.
2126 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2127 * xdisp.c (calc_pixel_width_or_height): Now static.
2128 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2129 * indent.c (check_display_width):
2130 * w32term.c: Fix comment to match code.
2131 * xterm.c, xterm.h (x_catching_errors): Remove.
2133 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2135 * xselect.c: Use signed conversions more consistently (Bug#9498).
2136 (selection_data_to_lisp_data): Assume incoming selection data are
2137 signed integers, not unsigned. This is to be consistent with
2138 outgoing selection data, which was modified to use signed integers
2139 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2140 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2141 expects long, not unsigned long.
2143 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2145 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2146 computation of loop end. Reported by Johan Bockgård
2149 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2151 * frame.c (Fother_visible_frames_p): Function deleted.
2153 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2155 * indent.c (compute_motion): Process display vector front to back
2156 rather than the other way around. (Bug#2496)
2158 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2160 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2162 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2164 * minibuf.c (Fread_from_minibuffer): Doc fix.
2166 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2168 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2169 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2171 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2173 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2174 value for non-existent files.
2176 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2178 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2179 set its "size" to -1. This will set the modtime_size field of
2180 the corresponding buffer to -1, which is what
2181 verify-visited-file-modtime expects for files that do not exist.
2184 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2186 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2188 * lisp.h: ... from here. push_key_description is no longer
2189 defined in keyboard.c, so its declaration should not be in
2190 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2191 logically belongs with push_key_description.
2193 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2195 * buffer.h: Include <sys/types.h> instead of <time.h>.
2196 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2197 Problem reported by Herbert J. Skuhra.
2199 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2201 * xml.c (parse_region): Make the parsing work for
2202 non-comment-starting XML files again (bug#9144).
2204 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2206 * image.c (gif_load): Fix calculation of bottom and right corner.
2209 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2211 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2212 redisplay in small windows.
2214 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2216 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2218 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2220 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2221 Operate on live windows only.
2223 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2225 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2227 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2229 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2230 only under bidi iteration.
2232 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2234 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2236 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2238 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2239 Without this fix, the command to link temacs failed due to an
2240 undefined symbol __builtin_isnan. This is because
2241 /usr/include/iso/math_c99.h #defines isnan(x) to
2242 __builtin_isnan(x), but the bundled gcc, which identifies itself
2243 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2245 * floatfns.c (isnan): #undef, and then #define to a clone of
2247 (Fisnan): Always define, since it's always available now.
2248 (syms_of_floatfns): Always define isnan at the Lisp level.
2250 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2252 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2254 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2256 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2257 The previous code assumed that file offsets (off_t values) fit in
2258 EMACS_INT variables, which is not true on typical 32-bit hosts.
2259 The code messed up by falsely reporting buffer overflow in cases
2260 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2261 when "big" contains more than 2**29 bytes, even though this
2262 inserts just one byte and does not overflow the buffer.
2263 (Finsert_file_contents): Store file offsets as off_t
2264 values, not as EMACS_INT values. Check for overflow when
2265 converting between EMACS_INT and off_t. When checking for
2266 buffer overflow or for overlap, take the offsets into account.
2267 Don't use EMACS_INT for small values where int suffices.
2268 When checking for overlap, fix a typo: ZV was used where
2269 ZV_BYTE was intended.
2270 (Fwrite_region): Don't assume off_t fits into 'long'.
2271 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2273 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2275 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2277 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2279 sprintf-related integer and memory overflow issues (Bug#9412).
2281 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2282 (esprintf, exprintf, evxprintf): New functions.
2283 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2284 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2285 (modify_event_symbol): Do not assume that the length of
2286 name_alist_or_stem is safe to alloca and fits in int.
2287 (Fexecute_extended_command): Likewise for function name and binding.
2288 (Frecursion_depth): Wrap around reliably on integer overflow.
2289 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2290 since some callers pass EMACS_INT values.
2291 (Fsingle_key_description): Don't crash if symbol name contains more
2292 than MAX_ALLOCA bytes.
2293 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2294 (get_minibuffer): Arg is now EMACS_INT, not int.
2295 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2296 (esprintf, exprintf, evxprintf): New decls.
2297 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2299 * dbusbind.c (signature_cat): New function.
2300 (xd_signature, Fdbus_register_signal):
2301 Do not overrun buffer; instead, report string overflow.
2303 * dispnew.c (add_window_display_history): Don't overrun buffer.
2304 Truncate instead; this is OK since it's just a log.
2306 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2307 even if the time zone offset is outlandishly large.
2308 Don't mishandle offset == INT_MIN.
2310 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2311 when creating daemon; the previous buffer-overflow check was incorrect.
2313 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2314 which has the guts of the old verror function.
2316 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2317 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2319 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2320 (font_unparse_xlfd): Don't blindly alloca long strings.
2321 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2322 fits in int, when using sprintf. Use single snprintf to count
2323 length of string rather than counting it via multiple sprintfs;
2324 that's simpler and more reliable.
2325 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2326 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2327 sprintf, in case result does not fit in int.
2329 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2330 (fontset_from_font): Print it.
2332 * frame.c (tty_frame_count): Now printmax_t, not int.
2333 (make_terminal_frame, set_term_frame_name): Print it.
2334 (x_report_frame_params): In X, window IDs are unsigned long,
2335 not signed long, so print them as unsigned.
2336 (validate_x_resource_name): Check for implausibly long names,
2337 and don't assume name length fits in 'int'.
2338 (x_get_resource_string): Don't blindly alloca invocation name;
2339 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2342 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2343 (xg_check_special_colors, xg_set_geometry):
2344 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2346 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2347 Use esprintf, not sprintf, in case result does not fit in int.
2349 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2350 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2351 it as a large positive number.
2352 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2353 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2355 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2356 in case result does not fit in int.
2358 * print.c (float_to_string): Detect width overflow more reliably.
2359 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2360 buffer overrun. Don't assume list length fits in 'int'. Treat
2361 print length of 0 as 0, not as infinity; to be consistent with other
2362 uses of print length in this function. Don't overflow print length
2363 index. Don't assume hash table size fits in 'long', or that
2364 vectorlike size fits in 'unsigned long'.
2366 * process.c (make_process): Use printmax_t, not int, to format
2367 process-name gensyms.
2369 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2371 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2372 to avoid potential buffer overrun.
2374 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2375 if X resource line is longer than 512 bytes.
2377 * xfns.c (x_window): Make sprintf buffer a bit bigger
2378 to avoid potential buffer overrun.
2380 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2382 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2384 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2386 Integer overflow fixes for scrolling, etc.
2387 Without these, Emacs silently mishandles large integers sometimes.
2388 For example, "C-u 4294967297 M-x recenter" was treated as if
2389 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2391 * xdisp.c (try_window_id): Check Emacs fixnum range before
2392 converting to 'int'.
2394 * window.c (window_scroll_line_based, Frecenter):
2395 Check that an Emacs fixnum is in range before assigning it to 'int'.
2396 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2397 values converted from Emacs fixnums.
2398 (Frecenter): Don't wrap around a line count if it is out of 'int'
2399 range; instead, treat it as an extreme value.
2400 (Fset_window_configuration, compare_window_configurations):
2401 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2403 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2404 that can exceed INT_MAX. Check that EMACS_INT value is in range
2405 before assigning it to the (possibly-narrower) index.
2406 (match_limit): Don't assume that a fixnum can fit in 'int'.
2408 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2411 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2412 (Fvertical_motion): Don't wrap around LINES values that don't fit
2413 in 'int'. Instead, treat them as extreme values. This is good
2414 enough for windows, which can't have more than INT_MAX lines anyway.
2416 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2418 * Require libxml/parser.h to avoid compilation warning.
2420 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2422 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2423 since this reportedly can destroy thread storage.
2425 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2427 * syntax.c (find_defun_start): Update all cache variables if
2428 exiting early (Bug#9401).
2430 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2432 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2434 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2435 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2436 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2438 * term.c (tty_append_glyph): New function.
2439 (produce_stretch_glyph): Static function and its prototype deleted.
2441 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2444 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2446 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2447 when checking :margin (Bug#9390).
2448 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2449 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2450 so that the name doesn't mislead. All uses changed.
2452 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2454 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2457 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2459 * xdisp.c (move_it_to): Don't bail out early when reaching
2460 position beyond to_charpos, if we are scanning backwards.
2461 (move_it_vertically_backward): When DY == 0, make sure we get to
2462 the first character in the line after the newline.
2464 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2466 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2467 (ccl_driver): Do not generate an out-of-range pointer.
2468 (Fccl_execute_on_string): Remove unnecessary check for
2469 integer overflow, noted by Stefan Monnier in
2470 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2471 Remove a FIXME that didn't need fixing.
2472 Simplify the newly-introduced buffer reallocation code.
2474 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2476 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2478 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2480 Integer and memory overflow issues (Bug#9196).
2482 * doc.c (get_doc_string): Rework so that
2483 get_doc_string_buffer_size is the actual buffer size, rather than
2484 being 1 less than the actual buffer size; this makes xpalloc more
2487 * image.c (x_allocate_bitmap_record, cache_image):
2488 * xselect.c (Fx_register_dnd_atom):
2489 Simplify previous changes by using xpalloc.
2491 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2492 since either will do and ptrdiff_t is convenient with xpalloc.
2494 * charset.c (charset_table_size)
2495 (struct charset_sort_data.priority): Now ptrdiff_t.
2496 (charset_compare): Don't overflow if priorities differ greatly.
2497 (Fsort_charsets): Don't assume list length fits in int.
2498 Check for size-calculation overflow when allocating sort data.
2499 (syms_of_charset): Allocate an initial charset table that is
2500 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2502 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2504 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2505 The actual value is always <= INT_MAX, and leaving it unsigned made
2506 overflow checking harder.
2508 * dispextern.h (struct glyph_matrix.rows_allocated)
2509 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2510 with xpalloc. The values are still always <= INT_MAX.
2512 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2514 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2515 (SAFE_NALLOCA): New macro.
2517 * region-cache.c (struct boundary.pos, find_cache_boundary)
2518 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2519 (set_cache_region, invalidate_region_cache)
2520 (revalidate_region_cache, know_region_cache, region_cache_forward)
2521 (region_cache_backward, pp_cache):
2522 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2523 so that ptrdiff_t * can be passed to xpalloc.
2524 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2525 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2526 (pp_cache): Don't assume cache_len fits in int.
2527 * region-cache.h: Adjust extern decls to match.
2529 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2530 EMACS_INT, since either will do, for xpalloc.
2532 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2533 (xnmalloc, xnrealloc, xpalloc): New functions.
2535 * bidi.c (bidi_shelve_header_size): New constant.
2536 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2537 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2539 * bidi.c (bidi_cache_shrink):
2540 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2542 Don't update size of array until after memory allocation succeeds,
2543 because xmalloc/xrealloc may not return.
2544 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2545 now that we have proper integer overflow checking.
2546 (record_overlay_string, overlay_strings): Catch overflows when
2547 calculating size of overlay_str_buf.
2549 * callproc.c (Fcall_process): Check for size overflow when
2550 calculating size of args2.
2551 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2552 Normally we prefer signed values, but sticking with ptrdiff_t would
2553 require adding more-complicated checks.
2555 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2556 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2557 Redo buffer-overflow calculations to avoid integer overflow.
2558 Add a FIXME comment where memory seems to be over-allocated.
2560 * character.c (Fstring): Check for size-calculation overflow.
2562 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2563 unnecessary integer overflow. Check for size overflow.
2564 (encode_coding_object): Don't update size until xmalloc succeeds.
2566 * composite.c (get_composition_id): Check for overflow in glyph
2567 length calculations.
2569 Integer and memory overflow fixes for display code.
2570 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2571 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2572 (scrolling_window): Check for overflow in size calculations.
2573 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2574 Don't assume glyph table len fits in int.
2575 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2576 (row_table_size): Now ptrdiff_t, not int.
2577 (scrolling_window): Avoid overflow in size calculations.
2578 Don't update size until allocation succeeds.
2579 * fns.c (concat): Check for overflow in size calculations.
2580 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2581 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2582 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2584 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2585 (get_doc_string): Check for size calculation overflow.
2586 Don't update size until allocation succeeds.
2587 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2588 EMACS_INT, where ptrdiff_t will do.
2589 (Fsubstitute_command_keys): Check for string overflow.
2591 * editfns.c (set_time_zone_rule): Don't assume environment length
2593 (message_length): Now ptrdiff_t, not int.
2594 (Fmessage_box): Don't update size until allocation succeeds.
2595 Don't assume message length fits in int.
2596 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2598 * emacs.c (main): Do not reallocate argv, since there is a null at
2599 the end that can be overwritten, and this way there's no need to
2600 worry about size-calculation overflow.
2601 (sort_args): Check for size-calculation overflow.
2603 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2605 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2607 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2608 (x_set_scroll_bar_width, x_figure_window_size):
2609 Check for integer overflow.
2610 (x_set_alpha): Do not assume XINT fits in int.
2612 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2613 This is for the members text_lines, text_cols, total_lines, total_cols,
2614 where the system imposes an 'int' limit.
2616 * fringe.c (Fdefine_fringe_bitmap):
2617 Don't update size until alloc works.
2619 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2620 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2622 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2623 Check for size-calculation overflow.
2624 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2625 do, as we prefer signed integers.
2626 (id_to_widget.max_size, id_to_widget.used)
2627 (xg_store_widget_in_map, xg_remove_widget_from_map)
2628 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2629 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2630 Use and return ptrdiff_t, not int.
2631 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2632 * gtkutil.h: Change prototypes to match the above.
2634 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2635 are duplicate now that they've been promoted to lisp.h.
2636 (x_allocate_bitmap_record, x_alloc_image_color)
2637 (make_image_cache, cache_image, xpm_load):
2638 Don't update size until alloc is done.
2639 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2641 Check for size calculation overflow.
2642 (ct_colors_allocated_max): New constant.
2643 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2646 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2647 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2648 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2649 Use ptrdiff_t, not int, to count maps.
2650 (read_char_minibuf_menu_prompt): Check for overflow in size
2651 calculations. Don't update size until allocation succeeds.
2652 Redo calculations to avoid overflow.
2653 * keyboard.h: Change prototypes to match the above.
2655 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2657 (current_minor_maps): Check for size calculation overflow.
2658 * keymap.h: Change prototypes to match the above.
2660 * lread.c (read1, init_obarray): Don't update size until alloc done.
2662 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2663 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2665 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2666 Now ptrdiff_t, not int.
2667 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2668 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2670 * process.c (Fnetwork_interface_list): Check for overflow
2671 in size calculation.
2673 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2675 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2676 overflow. Don't bother calling xmalloc when xrealloc will do.
2678 * search.c (Freplace_match): Check for size calculation overflow.
2679 (Fset_match_data): Don't assume list lengths fit in 'int'.
2681 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2682 for command line length. Do not attempt to address one before the
2683 beginning of an array, as that's not portable.
2685 * term.c (max_frame_lines): Remove; unused.
2686 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2688 (encode_terminal_code, calculate_costs): Check for size
2689 calculation overflow.
2690 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2691 table lengths and related sizes. Don't update size until alloc
2692 done. Redo calculations to avoid overflow.
2693 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2695 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2696 subtracting pointers.
2697 (gobble_line): Check for overflow more carefully. Don't update size
2700 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2701 Don't update size until alloc done.
2702 Redo size calculations to avoid overflow.
2703 Check for size calculation overflow.
2704 (main) [DEBUG]: Fix typo in invoking tparam1.
2706 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2707 Use ptrdiff_t, not int, for sizes.
2708 (store_mode_line_noprop_char): Don't update size until alloc done.
2710 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2711 Use ptrdiff_t, not int, for sizes.
2712 (Finternal_make_lisp_face, cache_face):
2713 Check for size calculation overflow.
2714 (cache_face): Treat size calculation overflows as if they were
2715 memory exhaustion (the usual treatment), rather than aborting.
2717 * xfns.c (x_encode_text, x_set_name_internal)
2718 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2719 sizes, since they can exceed INT_MAX in size. Check for size
2720 calculation overflow.
2722 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2723 (xg_select): Check for size calculation overflow.
2724 Don't update size until alloc done.
2726 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2727 as sprintf is limited to int lengths.
2729 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2730 (X_LONG_MIN): New macros.
2731 Use them to make the following changes clearer.
2732 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2733 This change doesn't affect the value now, but it may help remind
2734 future maintainers not to raise the value too much later.
2735 (SELECTION_QUANTUM): Remove, replacing with ...
2736 (selection_quantum): ... new function, which avoids overflow.
2738 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2739 assumption that selection length fits in 'int'.
2740 (x_reply_selection_request, x_handle_selection_request)
2741 (x_get_window_property, receive_incremental_selection)
2742 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2743 (lisp_data_to_selection_data, clean_local_selection_data):
2744 Use ptrdiff_t, not int, to record length of selection.
2745 (x_reply_selection_request, x_get_window_property)
2746 (receive_incremental_selection, x_property_data_to_lisp):
2747 Redo calculations to avoid overflow.
2748 (x_reply_selection_request): When sending hint, ceiling it at
2749 X_LONG_MAX rather than relying on wraparound overflow to send
2751 (x_get_window_property, receive_incremental_selection)
2752 (lisp_data_to_selection_data, x_property_data_to_lisp):
2753 Check for size-calculation overflow.
2754 (x_get_window_property, receive_incremental_selection)
2755 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2756 Don't store size until memory allocation succeeds.
2757 (x_get_window_property): Plug memory leak on memory exhaustion.
2758 Don't double-block input; malloc is safe here. Don't assume 2**34
2759 - 4 fits in unsigned long. Add an xassert to check
2760 XGetWindowProperty overflow. Be more careful about overflow
2761 calculations, and distinguish size from memory overflow better.
2762 (receive_incremental_selection): When tracing, don't assume
2763 unsigned int is less than INT_MAX.
2764 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2765 harmful) conversions of unsigned short to int.
2766 (lisp_data_to_selection_data): Don't assume that integers
2767 in the range -65535 through -1 fit in an X unsigned short.
2768 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2769 result parameters unless successful. Rely on cons_to_unsigned
2770 to report problems with elements; the old code wasn't right anyway.
2771 (x_check_property_data): Check for int overflow; we cannot use
2772 a wider type due to X limits.
2773 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2775 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2777 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2778 (x_term_init): Check for size calculation overflow.
2779 (x_color_cells): Don't store size until memory allocation succeeds.
2780 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2781 Don't assume alloca size is less than MAX_ALLOCA.
2782 (x_term_init): Don't assume length fits in int (sprintf is limited
2785 Use ptrdiff_t for composition IDs.
2786 * character.c (lisp_string_width):
2787 * composite.c (composition_table_size, n_compositions)
2788 (get_composition_id, composition_gstring_from_id):
2789 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2790 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2791 * window.c (Frecenter):
2792 Use ptrdiff_t, not int, for composition IDs.
2793 * composite.c (get_composition_id): Check for integer overflow.
2794 * composite.h: Adjust prototypes to match the above changes.
2796 Use ptrdiff_t for hash table indexes.
2797 * category.c (hash_get_category_set):
2798 * ccl.c (ccl_driver):
2799 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2800 * coding.c (coding_system_charset_list, detect_coding_system):
2801 * coding.h (struct coding_system.id):
2802 * composite.c (get_composition_id, gstring_lookup_cache):
2803 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2804 * image.c (xpm_get_color_table_h):
2805 * lisp.h (hash_lookup, hash_put):
2806 * minibuf.c (Ftest_completion):
2807 Use ptrdiff_t for hash table indexes, not int (which is too
2808 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2809 32-bit --with-wide-int hosts).
2811 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2812 Add a FIXME comment about memory leaks.
2813 (syms_of_charset): Don't assume xmalloc returns.
2815 Don't assume that stated character widths fit in int.
2816 * character.c (Fchar_width, c_string_width, lisp_string_width):
2817 * character.h (CHAR_WIDTH):
2818 * indent.c (MULTIBYTE_BYTES_WIDTH):
2819 Use sanitize_char_width to avoid undefined and/or bad behavior
2820 with outlandish widths.
2821 * character.h (sanitize_tab_width): Rename from sanitize_width,
2822 now that we have two such functions. All uses changed.
2823 (sanitize_char_width): New inline function.
2825 Don't assume that tab-width fits in int.
2826 * character.h (sanitize_width): New inline function.
2827 (SANE_TAB_WIDTH): New macro.
2828 (ASCII_CHAR_WIDTH): Use it.
2829 * indent.c (sane_tab_width): Remove. All uses replaced by
2830 SANE_TAB_WIDTH (current_buffer).
2831 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2833 * fileio.c: Integer overflow issues with file modes.
2834 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2836 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2837 Remove unreachable code.
2838 (read_hex, load_charset_map_from_file): Check for integer overflow.
2840 * xterm.c: Don't go over XClientMessageEvent limit.
2841 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2842 (x_send_scroll_bar_event): Likewise. Check that the size does not
2843 exceed limits imposed by XClientMessageEvent, as well as the usual
2844 ptrdiff_t and size_t limits.
2846 * keyboard.c: Overflow, signedness and related fixes.
2847 (make_lispy_movement): Use same integer type in forward decl
2848 that is used in the definition.
2849 (read_key_sequence, keyremap_step):
2850 Change bufsize argument back to int, undoing my 2011-03-30 change.
2851 We prefer signed types, and int is wide enough here.
2852 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2853 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2854 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2855 length, not size_t. Use ptrdiff_t for index, not int.
2856 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2857 possibility of integer overflow.
2859 Overflow, signedness and related fixes for images.
2861 * dispextern.h (struct it.stack[0].u.image.image_id)
2862 (struct_it.image_id, struct image.id, struct image_cache.size)
2863 (struct image_cache.used, struct image_cache.ref_count):
2864 * gtkutil.c (update_frame_tool_bar):
2865 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2866 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2867 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2868 * nsmenu.m (update_frame_tool_bar):
2869 * xdisp.c (calc_pixel_width_or_height):
2870 * xfns.c (image_cache_refcount):
2871 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2872 on typical 64-bit hosts.
2874 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2875 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2876 Omit unnecessary casts to int.
2877 (parse_image_spec): Check that integers fall into 'int' range
2878 when the callers expect that.
2879 (image_ascent): Redo ascent calculation to avoid int overflow.
2880 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2881 (lookup_image): Remove unnecessary tests.
2882 (xbm_image_p): Locals are now of int, not EMACS_INT,
2883 since parse_image_check makes sure they fit into int.
2884 (png_load, gif_load, svg_load_image):
2885 Prefer int to unsigned where either will do.
2886 (tiff_handler): New function, combining the cores of the
2887 old tiff_error_handler and tiff_warning_handler.
2888 This function is rewritten to use vsnprintf and thereby avoid
2889 stack buffer overflows. It uses only the features of vsnprintf
2890 that are common to both POSIX and native Microsoft.
2891 (tiff_error_handler, tiff_warning_handler): Use it.
2892 (tiff_load, gif_load, imagemagick_load_image):
2893 Don't assume :index value fits in 'int'.
2894 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2895 (imagemagick_load_image): Check that crop parameters fit into
2896 the integer types that MagickCropImage accepts. Don't assume
2897 Vimagemagick_render_type has a nonnegative value. Don't assume
2898 size_t fits in 'long'.
2899 (gs_load): Use printmax_t to print the widest integers possible.
2900 Check for integer overflow when computing image height and width.
2902 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2904 * xdisp.c (redisplay_window): Don't force window start if point
2905 will be invisible in the resulting window. (Bug#9324)
2907 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2909 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2910 the display spec is of the form `(space ...)'.
2911 (handle_display_spec): Return the value returned by
2912 handle_single_display_spec, not just 1 or zero.
2913 (handle_single_display_spec): If the display spec is of the form
2914 `(space ...)', and specifies display in the text area, return 2
2916 (try_cursor_movement): Check for the need to scroll more
2917 accurately, and prefer exact match for point under bidi.
2918 Don't advance `row' beyond the last row of the window.
2920 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2921 into disp_prop; all users changed.
2923 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2924 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2925 for the text covered by the display property.
2927 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2929 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2930 Change return value to nil.
2931 (Frecord_buffer): Delete unused function.
2933 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2935 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2936 buffers, return left-to-right.
2937 (set_cursor_from_row): Consider candidate row a win if its glyph
2938 represents a newline and point is on that newline. Fixes cursor
2939 positioning on the newline at EOL of R2L text within L2R
2940 paragraph, and vice versa.
2941 (try_cursor_movement): Check continued rows, in addition to
2942 continuation rows. Fixes unwarranted scroll when point enters a
2943 continued line of R2L text within an L2R paragraph, or vice versa.
2944 (cursor_row_p): Consider the case of point being equal to
2945 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2946 from the end of a short line to the beginning of a continued line
2947 of R2L text within L2R paragraph.
2948 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2949 composed characters.
2951 * bidi.c (bidi_check_type): Use xassert.
2952 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2955 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2957 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2960 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2962 * nsfont.m (ns_otf_to_script): Fix typo.
2964 2011-08-22 Kenichi Handa <handa@m17n.org>
2966 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2967 extra slot even if the purpose is char-code-property-table.
2969 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2971 * xdisp.c (redisplay_window): When computing centering_position,
2972 account for the height of the header line. (Bug#8874)
2974 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2975 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2976 candidate is selected by the mouse, and that candidate has a
2977 composed character under the mouse.
2979 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2980 coordinates reported by pos-visible-in-window-p for a composed
2981 character in column zero.
2983 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2985 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2987 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2989 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2990 consider it a hit if to_charpos is anywhere in the range of the
2991 composed buffer positions.
2993 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2995 * image.c (gif_load): Don't assume that each subimage has the same
2996 dimensions as the base image. Handle disposal method that is
2997 "undefined" by the gif spec (Bug#9335).
2999 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3001 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3002 (Fcondition_case): Document `debug' symbol in error handler.
3004 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3006 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3007 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3008 from an Org mode buffer to a Speedbar frame.
3010 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3011 a composition, take its buffer position from IT->cmp_it.charpos.
3012 Fixes cursor positioning at the beginning of a line that begins
3013 with a composed character.
3015 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3017 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3018 character bidirectional type, use STRONG_L instead. Fixes crashes
3019 in a buffer produced by `describe-categories'.
3021 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3022 members before the level stack, so they would be saved and
3023 restored when copying iterator state. Fixes incorrect reordering
3024 around TABs covered by display properties.
3026 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3028 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3030 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3032 * eval.c (internal_condition_case, internal_condition_case_1)
3033 (internal_condition_case_2, internal_condition_case_n):
3034 Remove unnecessary aborts (Bug#9081).
3036 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3038 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3039 has no `load' handler, try opening the file locally. (Bug#9311)
3041 2011-08-16 Ken Brown <kbrown@cornell.edu>
3043 * gmalloc.c: Expand comment.
3045 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3047 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3048 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3050 2011-08-16 Ken Brown <kbrown@cornell.edu>
3052 Fix memory allocation problems in Cygwin build (Bug#9273).
3054 * unexcw.c ( __malloc_initialized): Declare external variable.
3055 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3057 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3059 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3061 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3063 [CYGWIN] (special_realloc): New function.
3064 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3065 requests to realloc storage in the static heap.
3067 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3069 * bidi.c (bidi_initialize): Remove unused local.
3071 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3074 * biditype.h: Remove file.
3075 * makefile.w32-in ($(BLD)/bidi.$(O)):
3076 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3078 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3080 * chartab.c: Improve commentary for the uniprop_table API.
3082 * bidi.c (bidi_paragraph_init): Support zero value of
3083 bidi_ignore_explicit_marks_for_paragraph_level.
3084 (bidi_initialize): Use uniprop_table instead of including
3085 biditype.h and bidimirror.h.
3087 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3088 coordinates of the iterator when restoring from ppos_it.
3091 2011-08-14 Kenichi Handa <handa@m17n.org>
3093 * process.c (create_process): Call setup_process_coding_systems
3094 after the pid of the process is set to -1 (Bug#8162).
3096 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3098 * xdisp.c (move_it_in_display_line_to): Don't invoke
3099 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3100 ppos_it. Fixes vertical cursor motion when line beginning is
3101 covered by an image. (Bug#9296)
3103 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3105 * nsterm.h (ns_run_ascript): Declare.
3106 (NSAPP_DATA2_RUNASSCRIPT): Define.
3108 * nsfns.m (as_script, as_result, as_status): New static variables.
3109 (ns_run_ascript): New function.
3110 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3111 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3112 the event loop. Get status from as_status (Bug#7276).
3114 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3115 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3116 the event loop (Bug#7276).
3118 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3120 * gnutls.c (QCgnutls_bootprop_priority)
3121 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3122 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3123 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3124 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3125 (QCgnutls_bootprop_verify_hostname_error)
3126 (QCgnutls_bootprop_callbacks_verify): Rename from
3127 Qgnutls_bootprop_..., all uses changed.
3129 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3132 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3134 * xfaces.c (Qframe_set_background_mode): Now static.
3135 * dispextern.h (Qframe_set_background_mode): Remove decl.
3137 * process.c (Fnetwork_interface_info): Declare local only if needed.
3139 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3141 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3142 (Fnetwork_interface_list): Allocate in increments of bytes instead
3143 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3144 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3146 (struct ifflag_def): notrailers is smart on OSX.
3147 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3148 Get hardware address with getifaddrs if available.
3150 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3152 * xdisp.c (iterate_out_of_display_property): xassert that
3153 IT->position is set to within IT->object's boundaries. Break from
3154 the loop as soon as EOB is reached; avoids infloops in redisplay
3155 when IT->position is set up wrongly due to some bug.
3156 Set IT->current to match the bidi iterator unconditionally.
3157 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3158 entry. Force push_it to save on the stack the current
3159 buffer/string position, to be restored by pop_it. Fix flags in
3160 the iterator structure wrt the object coming from a display
3161 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3162 properties. (Bug#9284)
3164 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3166 * fontset.c (fontset_get_font_group): Add proper type checks.
3169 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3171 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3172 and LC_VERSION_MIN_MACOSX.
3173 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3174 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3176 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3178 * xdisp.c (forward_to_next_line_start): Allow to use the
3179 no-display-properties-and-no-overlays under bidi display.
3180 Set disp_pos in the bidi iterator to avoid searches for display
3181 properties and overlays.
3183 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3185 * editfns.c (Fset_time_zone_rule): Document relationship with the
3188 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3189 the font entity extracted from the cache (Bug#8109).
3191 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3193 * composite.c (autocmp_chars): Don't reset point. That is done by
3194 restore_point_unwind (Bug#5984).
3196 2011-08-07 Juri Linkov <juri@jurta.org>
3198 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3199 to show the arg `TIME' instead of `TIMEVAL'.
3201 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3203 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3204 display property strides EOL and includes a newline, as in
3205 longlines-mode. (Bug#9254)
3206 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3207 word-wrap under bidirectional display. (Bug#9224)
3209 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3210 is non-zero, even if the data buffer is NULL. Fixes a crash in
3211 vertical-motion with longlines-mode. (Bug#9254)
3213 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3215 * bidi.c <bidi_cache_total_alloc>: Now static.
3216 (bidi_initialize): Initialize bidi_cache_total_alloc.
3218 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3221 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3222 amount allocated this far in `bidi_cache_total_alloc'.
3223 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3224 non-zero, only free the data buffer without restoring the cache
3225 contents. All callers changed.
3227 * dispextern.h (bidi_unshelve_cache): Update prototype.
3229 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3230 (move_it_in_display_line, move_it_to)
3231 (move_it_vertically_backward, move_it_by_lines): Replace the call
3232 to xfree to an equivalent call to bidi_unshelve_cache.
3233 (move_it_in_display_line_to): Fix logic of returning
3234 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3236 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3238 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3239 came from a string character with a `cursor' property. (Bug#9229)
3241 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3243 * Makefile.in (LIB_PTHREAD): New variable.
3244 (LIBES): Add LIB_PTHREAD (Bug#9216).
3246 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3247 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3249 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3251 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3253 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3255 * xterm.c (x_find_topmost_parent): New function.
3256 (x_set_frame_alpha): Find topmost parent window with
3257 x_find_topmost_parent and set the property there also (bug#9181).
3258 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3260 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3262 * callproc.c (Fcall_process): Avoid vfork clobbering
3263 the local vars buffer, coding_systems, current_dir.
3265 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3267 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3269 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3271 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3272 so that it is not optimized away.
3274 * xdisp.c (compute_display_string_pos): Remove unused local.
3276 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3278 Fix slow cursor motion and scrolling in large buffers with
3279 selective display, like Org Mode buffers. (Bug#9218)
3281 * dispextern.h (struct bidi_it): New member disp_prop_p.
3283 * xdisp.c: Remove one-slot cache of display string positions.
3284 (compute_display_string_pos): Accept an additional argument
3285 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3286 for a display string or property. If found, set DISP_PROP_P
3289 * bidi.c (bidi_fetch_char): Accept an additional argument
3290 DISP_PROP_P, and pass it to compute_display_string_pos.
3291 Only handle text covered by a display string if DISP_PROP_P is returned
3292 non-zero. All callers of bidi_fetch_char changed.
3294 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3296 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3298 2010-12-03 Don March <don@ohspite.net>
3300 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3301 last character M-[char] is translated to ESC [char] (bug#7541).
3303 2011-08-02 Kenichi Handa <handa@m17n.org>
3305 * lisp.h (uniprop_table): Extern it.
3307 * chartab.c (uniprop_table): Make it non-static.
3309 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3311 * xdisp.c (forward_to_next_line_start): Accept additional argument
3312 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3314 (reseat_at_next_visible_line_start): Use the bidi iterator state
3315 returned by forward_to_next_line_start to restore the state of
3316 it->bidi_it after backing up to previous newline. (Bug#9212)
3318 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3320 * regex.c (re_comp): Protoize.
3321 (re_exec): Fix return type.
3322 (regexec): Fix type of `ret'. (Bug#9203)
3324 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3326 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3327 This is needed if max-image-size is a floating-point number.
3329 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3331 * print.c (print_object): Print empty symbol as ##.
3333 * lread.c (read1): Read ## as empty symbol.
3335 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3337 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3338 setting frame foreground color (Bug#9175).
3339 (x_set_background_color): Likewise.
3341 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3342 contents (Bug#9176).
3343 (EmacsTooltip -init): Remove bezels and add shadows to
3346 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3347 or scroll bar (Bug#8470).
3349 * nsfont.m (nsfont_open): Remove assignment to voffset and
3350 unnecessary vars hshink, expand, hd, full_height, min_height.
3351 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3353 * nsterm.h (nsfont_info): Remove voffset field.
3355 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3357 Implement strike-through and overline on NextStep (Bug#8863).
3359 * nsfont.m (nsfont_open): Use underline position provided by font,
3360 instead of hard-coded value of 2.
3361 (nsfont_draw): Call ns_draw_text_decoration instead.
3363 * nsterm.h: Add declaration for ns_draw_text_decoration.
3365 * nsterm.m (ns_draw_text_decoration): New function for drawing
3366 underline, overline, and strike-through.
3367 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3368 ns_draw_text_decoration. Change treatment of cursor drawing to
3369 accommodate underlining, etc.
3371 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3373 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3376 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3378 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3379 Without this fix, if a signal arrives just after memory fills up,
3380 'malloc' might be invoked reentrantly.
3382 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3383 In other words, assume that every image size is allowed, on non-X
3384 hosts. This assumption is probably wrong, but it lets Emacs compile.
3386 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3388 * regex.c (re_iswctype): Convert return values to boolean.
3390 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3392 * xdisp.c (compute_display_string_pos): Don't use cached display
3393 string position if the buffer had its restriction changed.
3396 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3398 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3400 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3402 Integer signedness and overflow and related fixes. (Bug#9079)
3404 * bidi.c: Integer size and overflow fixes.
3405 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3406 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3407 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3408 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3409 (bidi_find_other_level_edge):
3410 Use ptrdiff_t instead of EMACS_INT where either will do.
3411 This works better on 32-bit hosts configured --with-wide-int.
3412 (bidi_cache_ensure_space): Check for size-calculation overflow.
3413 Use % rather than repeated addition, for better worst-case speed.
3414 Don't set bidi_cache_size until after xrealloc returns, because it
3416 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3417 (bidi_cache_ensure_space): Also check that the bidi cache size
3418 does not exceed that of the largest Lisp string or buffer. See Eli
3419 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3421 * alloc.c (__malloc_size_t): Remove.
3422 All uses replaced by size_t. See Andreas Schwab's note
3423 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3425 * image.c: Improve checking for integer overflow.
3426 (check_image_size): Assume that f is nonnull, since
3427 it is always nonnull in practice. This is one less thing to
3428 worry about when checking for integer overflow later.
3429 (x_check_image_size): New function, which checks for integer
3430 overflow issues inside X.
3431 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3432 This removes the need for a memory_full check.
3433 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3434 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3435 (xbm_read_bitmap_data): Change locals back to 'int', since
3436 their values must fit in 'int'.
3437 (xpm_load_image, png_load, tiff_load):
3438 Invoke x_create_x_image_and_pixmap earlier,
3439 to avoid much needless work if the image is too large.
3440 (tiff_load): Treat overly large images as if
3441 x_create_x_image_and_pixmap failed, not as malloc failures.
3442 (gs_load): Use x_check_image_size.
3444 * gtkutil.c: Omit integer casts.
3445 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3446 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3448 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3450 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3451 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3452 would wrongly return t on a 64-bit host.
3454 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3455 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3456 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3457 and therefore cause GCC to emit a bogus diagnostic in some cases.
3459 * image.c: Integer signedness and overflow and related fixes.
3460 This is not an exhaustive set of fixes, but it's time to
3461 record what I've got.
3462 (lookup_pixel_color, check_image_size): Remove redundant decls.
3463 (check_image_size): Don't assume that arbitrary EMACS_INT values
3464 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3465 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3466 (tiff_load, imagemagick_load_image):
3467 Check for overflow in size calculations.
3468 (x_create_x_image_and_pixmap): Remove unnecessary test for
3469 xmalloc returning NULL; that can't happen.
3470 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3471 (xpm_color_bucket): Use better integer hashing function.
3472 (xpm_cache_color): Don't possibly over-allocate memory.
3473 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3474 (gif_memory_source):
3475 Use ptrdiff_t, not int or size_t, to record sizes.
3476 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3477 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3478 either works, as we prefer signed integers.
3479 (tiff_read_from_memory, tiff_write_from_memory):
3480 Return tsize_t, not size_t, since that's what the TIFF API wants.
3481 (tiff_read_from_memory): Don't fail simply because the read would
3482 go past EOF; instead, return a short read.
3483 (tiff_load): Omit no-longer-needed casts.
3484 (Fimagemagick_types): Don't assume size fits into 'int'.
3486 Improve hashing quality when configured --with-wide-int.
3487 * fns.c (hash_string): New function, taken from sxhash_string.
3488 Do not discard information about ASCII character case; this
3489 discarding is no longer needed.
3490 (sxhash-string): Use it. Change sig to match it. Caller changed.
3491 * lisp.h: Declare it.
3492 * lread.c (hash_string): Remove, since we now use fns.c's version.
3493 The fns.c version returns a wider integer if --with-wide-int is
3494 specified, so this should help the quality of the hashing a bit.
3496 * emacs.c: Integer overflow minor fix.
3497 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3498 Define only if GNU_LINUX.
3499 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3501 * dispnew.c: Integer signedness and overflow fixes.
3502 Remove unnecessary forward decls, that were a maintenance hassle.
3503 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3505 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3506 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3507 (prepare_desired_row, line_draw_cost):
3508 Use int, not unsigned, where either works.
3509 (save_current_matrix, restore_current_matrix):
3510 Use ptrdiff_t, not size_t, where either works.
3511 (init_display): Check for overflow more accurately, and without
3512 relying on undefined behavior.
3514 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3515 Remove, replacing with the new symbols in lisp.h. All uses changed.
3516 * fileio.c (make_temp_name):
3517 * filelock.c (lock_file_1, lock_file):
3518 * xdisp.c (message_dolog):
3519 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3520 Use pMd etc. instead.
3521 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3522 replacing the pWIDE etc. symbols removed from editfns.c.
3524 * keyboard.h (num_input_events): Now uintmax_t.
3525 This is (very slightly) less likely to mess up due to wraparound.
3528 * buffer.c: Integer signedness fixes.
3529 (alloc_buffer_text, enlarge_buffer_text):
3530 Use ptrdiff_t rather than size_t when either will do, as we prefer
3533 * alloc.c: Integer signedness and overflow fixes.
3534 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3535 (__malloc_size_t): Default to size_t, not to int.
3536 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3537 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3538 Prefer ptrdiff_t to size_t when either would do, as we prefer
3540 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3541 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3542 Now const. Initialize with values that are in range even if char
3544 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3545 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3546 These functions do the right thing with sizes > 2**32.
3547 (check_depth): Now ptrdiff_t, not int.
3548 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3549 Adjust to new way of storing sizes. Check for size overflow bugs
3551 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3552 slightly wrong anyway, as it missed one instance of
3553 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3554 (refill_memory_reserve): Omit needless cast to size_t.
3555 (mark_object_loop_halt): Mark as externally visible.
3557 * xselect.c: Integer signedness and overflow fixes.
3558 (Fx_register_dnd_atom, x_handle_dnd_message):
3559 Use ptrdiff_t, not size_t, since we prefer signed.
3560 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3561 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3562 x_dnd_atoms_size and x_dnd_atoms_length.
3564 * doprnt.c: Prefer signed to unsigned when either works.
3566 * doprnt.c (doprnt):
3568 * xdisp.c (vmessage):
3569 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3570 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3571 prefer signed arithmetic to avoid comparison confusion.
3572 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3573 but is a bit tricky.
3575 Assume freestanding C89 headers, string.h, stdlib.h.
3576 * data.c, doprnt.c, floatfns.c, print.c:
3577 Include float.h unconditionally.
3578 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3579 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3580 * regex.c: Likewise for stddef.h, string.h.
3581 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3582 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3583 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3584 (STDC_HEADERS): Remove obsolete defines.
3585 * sysdep.c: Include limits.h unconditionally.
3587 Assume support for memcmp, memcpy, memmove, memset.
3588 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3589 * regex.c (memcmp, memcpy):
3590 Remove; we assume C89 now.
3592 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3593 (__malloc_safe_bcopy): Remove; no longer needed.
3595 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3596 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3597 well either way, and we prefer signed to unsigned.
3599 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3601 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3602 closes the connection while we're reading (bug#9182).
3604 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3606 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3607 are specified (Bug#9168).
3609 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3611 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3612 Found by GCC static checking and --with-wide-int on a 32-bit host.
3614 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3616 * xdisp.c (compute_display_string_pos): Fix logic of caching
3617 previous display string position. Initialize cached_prev_pos to
3618 -1. Fixes slow-down at the beginning of a buffer.
3620 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3622 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3623 for attrs[LFACE_FONTSET_INDEX].
3625 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3627 * xml.c (parse_region): Remove unused local
3628 that was recently introduced.
3630 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3632 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3633 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3635 * xdisp.c (move_it_in_display_line_to): Record the best matching
3636 position for TO_CHARPOS while scanning the line, and restore it on
3637 exit if none of the characters scanned was an exact match.
3638 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3639 when exact match is impossible due to invisible text, and the
3640 lines are truncated.
3642 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3644 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3647 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3649 Fix a significant slow-down of cursor motion with C-n, C-p,
3650 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3651 auto-repeat under bidi redisplay in fontified buffers.
3652 * xdisp.c (compute_stop_pos_backwards): New function.
3653 (next_element_from_buffer): Call compute_stop_pos_backwards to
3654 find a suitable prev_stop when we find ourselves before
3656 (reseat): Don't look for prev_stop, as that could mean a very long
3658 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3659 <cached_disp_overlay_modiff>: Cache for last found display string
3661 (compute_display_string_pos): Return the cached position if asked
3662 about the same buffer in the same area of character positions, and
3663 the buffer wasn't changed since the time the display string
3664 position was cached.
3666 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3668 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3669 is an integer, which is important for empty lines. (Bug#9149)
3671 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3673 * frame.c (Fmodify_frame_parameters): In tty case, update the
3674 default face if necessary (Bug#4238).
3676 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3678 * editfns.c (Fstring_to_char): No need to explain what a character
3679 is in the docstring (Bug#6576).
3681 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3683 * xml.c (parse_region): Make sure we always return a tree.
3685 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3687 * xml.c (parse_region): If a document contains only comments,
3690 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3692 * xml.c (make_dom): Return comments, too.
3694 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3697 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3698 and the surrounding thread.
3699 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3700 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3701 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3703 * s/openbsd.h (BROKEN_SIGIO): Define.
3704 * unexelf.c (unexec) [__OpenBSD__]:
3705 Don't update the .mdebug section of the Alpha COFF symbol table.
3707 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3709 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3712 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3714 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3715 This fixes some race conditions on the permissions of any newly
3718 * alloc.c (valid_pointer_p): Use pipe, not open.
3719 This fixes some permissions issues when debugging.
3721 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3722 If fchown fails to set both uid and gid, try to set just gid,
3723 as that is sometimes allowed. Adjust the file's mode to eliminate
3724 setuid or setgid bits that are inappropriate if fchown fails.
3726 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3728 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3729 to compare Lisp_Objects.
3730 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3731 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3732 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3734 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3736 * lread.c (read_integer): Unread even EOF character.
3737 (read1): Likewise. Properly record start position of symbol.
3739 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3740 symbol character follows.
3742 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3744 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3745 This works around a problem with the previous change to Fcopy_file.
3746 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3747 and without this change, GCC might complain about discarding
3748 fchown's return value.
3750 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3752 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3754 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3756 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3758 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3760 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3761 it's used from the C level.
3763 * process.c: Use the same condition for POLL_FOR_INPUT in both
3764 keyboard.c and process.c (bug#1858).
3766 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3768 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3769 (Fgnutls_boot): Use it.
3771 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3773 * doc.c (Fsubstitute_command_keys): Revert last change.
3775 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3777 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3778 quotes the next character, and doesn't affect other longer
3779 sequences (bug#8935).
3781 * lread.c (syms_of_lread): Clarify that is isn't only
3782 `eval-buffer' and `eval-defun' that's affected by
3783 `lexical-binding' (bug#8460).
3785 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3787 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3788 bidi redisplay when a line includes both an image and is truncated.
3790 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3792 Fix minor problems found by static checking.
3793 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3794 (elsz): Now a signed constant, not a size_t var. We prefer signed
3795 types to unsigned, to avoid integer comparison confusion. Without
3796 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3797 "cannot optimize loop, the loop counter may overflow", a symptom
3799 * indent.c (Fvertical_motion): Mark locals as initialized.
3800 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3802 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3804 * search.c (Fre_search_backward): Mention `case-fold-search' in
3805 all the re_search_* functions (bug#8138).
3807 * keyboard.c (Fopen_dribble_file): Document when the file is
3810 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3812 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3815 Support bidi reordering of display and overlay strings.
3816 * xdisp.c (compute_display_string_pos)
3817 (compute_display_string_end): Accept additional argument STRING.
3818 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3819 (reseat_to_string): Initialize bidi_it->string.s and
3820 bidi_it->string.schars.
3821 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3822 NULL (avoids a crash in bidi_paragraph_init).
3823 Initialize itb.string.lstring.
3824 (init_iterator): Call bidi_init_it only of a valid
3825 buffer position was specified. Initialize paragraph_embedding to
3827 (reseat_to_string): Initialize the bidi iterator.
3828 (display_string): If we need to ignore text properties of
3829 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3830 original value of -1 will not work with bidi.)
3831 (compute_display_string_pos): First arg is now struct
3832 `text_pos *'; all callers changed. Support display properties on
3834 (compute_display_string_end): Support display properties on Lisp
3836 (init_iterator, reseat_1, reseat_to_string): Initialize the
3837 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3838 when iterating on a string not from display properties).
3839 (compute_display_string_pos, compute_display_string_end):
3840 Fix calculation of the object to scan. Fixes an error when using
3842 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3843 base_level_stop; instead, set base_level_stop to BEGV.
3844 Fixes crashes in vertical-motion.
3845 (next_element_from_buffer): Improve commentary for when
3846 the iterator is before prev_stop.
3847 (init_iterator): Initialize bidi_p from the default value of
3848 bidi-display-reordering, not from buffer-local value. Use the
3849 buffer-local value only if initializing for buffer iteration.
3850 (handle_invisible_prop): Support invisible properties on strings
3851 that are being bidi-reordered.
3852 (set_iterator_to_next): Support bidi reordering of C strings and
3854 (next_element_from_string): Support bidi reordering of Lisp
3856 (handle_stop_backwards): Support Lisp strings as well.
3857 (display_string): Support display of R2L glyph rows.
3858 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3859 (init_iterator): Don't initialize it->bidi_p for strings
3861 (reseat_to_string): Initialize it->bidi_p for strings here.
3862 (next_element_from_string, next_element_from_c_string)
3863 (next_element_from_buffer): Add xassert's for correspondence
3864 between IT's object being iterated and it->bidi_it.string
3866 (face_before_or_after_it_pos): Support bidi iteration.
3867 (next_element_from_c_string): Handle the case of the first string
3868 character that is not the first one in the visual order.
3869 (get_visually_first_element): New function, refactored from common
3870 parts of next_element_from_buffer, next_element_from_string, and
3871 next_element_from_c_string.
3872 (tool_bar_lines_needed, redisplay_tool_bar)
3873 (display_menu_bar): Force left-to-right direction. Add a FIXME
3874 comment for making that be controlled by a user option.
3875 (push_it, pop_it): Save and restore the state of the
3876 bidi iterator. Save and restore the bidi_p flag.
3877 (pop_it): Iterate out of display property for string iteration as
3879 (iterate_out_of_display_property): Support iteration over strings.
3880 (handle_single_display_spec): Set up it->bidi_it for iteration
3881 over a display string, and call bidi_init_it.
3882 (handle_single_display_spec, next_overlay_string)
3883 (get_overlay_strings_1, push_display_prop): Set up the bidi
3884 iterator for displaying display or overlay strings.
3885 (forward_to_next_line_start): Don't use the shortcut if
3887 (back_to_previous_visible_line_start): If handle_display_prop
3888 pushed the iterator stack, restore the internal state of the bidi
3889 iterator by calling bidi_pop_it same number of times.
3890 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3891 and we are bidi-iterating, don't decrement the iterator position;
3892 instead, set the first_elt flag in the bidi iterator, to produce
3894 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3895 (push_display_prop): xassert that we are iterating a buffer.
3896 (push_it, pop_it): Save and restore paragraph_embedding member.
3897 (handle_single_display_spec, next_overlay_string)
3898 (get_overlay_strings_1, reseat_1, reseat_to_string)
3899 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3900 correctly. Don't assume unibyte strings are not bidi-reordered.
3901 (compute_display_string_pos)
3902 (compute_display_string_end): Fix handling the case of C string.
3903 (push_it, pop_it): Save and restore from_disp_prop_p.
3904 (handle_single_display_spec, push_display_prop): Set the
3905 from_disp_prop_p flag.
3906 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3907 (pop_it): Call iterate_out_of_display_property only if we are
3908 popping after iteration over a string that came from a display
3909 property. Fix a typo in popping stretch info. Add an assertion
3910 for verifying that the iterator position is in sync with the bidi
3912 (handle_single_display_spec, get_overlay_strings_1)
3913 (push_display_prop): Fix initialization of paragraph direction for
3914 string when that of the parent object is not yet determined.
3915 (reseat_1): Call bidi_init_it to resync the bidi
3916 iterator with IT's position. (Bug#7616)
3917 (find_row_edges): If ROW->start.pos gives position
3918 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3919 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3920 Reset the from_disp_prop_p flag.
3921 (SAVE_IT, RESTORE_IT): New macros.
3922 (pos_visible_p, face_before_or_after_it_pos)
3923 (back_to_previous_visible_line_start)
3924 (move_it_in_display_line_to, move_it_in_display_line)
3925 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3926 (try_scrolling, redisplay_window, display_line): Use them when
3927 saving a temporary copy of the iterator and restoring it back.
3928 (back_to_previous_visible_line_start, reseat_1)
3929 (init_iterator): Empty the bidi cache "stack".
3930 (move_it_in_display_line_to): If iterator ended up at
3931 EOL, but we never saw any buffer positions smaller than
3932 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3933 motion in bidi-reordered lines.
3934 (move_it_in_display_line_to): Record prev_method and prev_pos
3935 immediately before the call to set_iterator_to_next. Fixes cursor
3936 motion in bidi-reordered lines with stretch glyphs and strings
3937 displayed in margins. (Bug#8133) (Bug#8867)
3938 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3940 (pos_visible_p): Support positions in bidi-reordered lines.
3941 Save and restore bidi cache.
3943 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3944 (bidi_paragraph_info): Delete unused struct.
3945 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3946 (bidi_cache_start): New variable.
3947 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3949 (bidi_cache_fetch_state, bidi_cache_search)
3950 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3951 (bidi_cache_find, bidi_peek_at_next_level)
3952 (bidi_level_of_next_char, bidi_find_other_level_edge)
3953 (bidi_move_to_visually_next): Compare cache index with
3954 bidi_cache_start rather than with zero.
3955 (bidi_fetch_char): Accept new argument STRING; all callers
3956 changed. Support iteration over a string. Support strings with
3957 display properties. Support unibyte strings. Fix the type of
3958 `len' according to what STRING_CHAR_AND_LENGTH expects.
3959 (bidi_paragraph_init, bidi_resolve_explicit_1)
3960 (bidi_resolve_explicit, bidi_resolve_weak)
3961 (bidi_level_of_next_char, bidi_move_to_visually_next):
3962 Support iteration over a string.
3963 (bidi_set_sor_type, bidi_resolve_explicit_1)
3964 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3965 can now be zero (for strings); special values 0 and -1 were
3966 changed to -1 and -2, respectively.
3967 (bidi_char_at_pos): New function.
3968 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3969 Call it instead of FETCH_MULTIBYTE_CHAR.
3970 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3971 initialized to valid values.
3972 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3974 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3975 the test for valid cached positions. Fix the logic for looking up
3976 the sentinel state in the cache. GCPRO the Lisp string we are
3978 (bidi_push_it, bidi_pop_it): New functions.
3979 (bidi_initialize): Initialize the bidi cache start stack pointer.
3980 (bidi_cache_ensure_space): New function, refactored from part of
3981 bidi_cache_iterator_state. Don't assume the required size is just
3982 one BIDI_CACHE_CHUNK away.
3983 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3984 (bidi_count_bytes, bidi_char_at_pos): New functions.
3985 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3986 always valid if bidi_cache_idx is valid.
3987 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3988 is valid if it's going to be used.
3989 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3990 (bidi_cache_fetch_state, bidi_cache_search)
3991 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3992 (bidi_cache_iterator_state, bidi_cache_find)
3993 (bidi_find_other_level_edge, bidi_cache_start_stack):
3994 All variables related to cache indices are now EMACS_INT.
3996 * dispextern.h (struct bidi_string_data): New structure.
3997 (struct bidi_it): New member `string'. Make flag members be 1-bit
3998 fields, and put them last in the struct.
3999 (compute_display_string_pos, compute_display_string_end):
4001 (bidi_push_it, bidi_pop_it): Add prototypes.
4002 (struct iterator_stack_entry): New members bidi_p,
4003 paragraph_embedding, and from_disp_prop_p.
4004 (struct it): Member bidi_p is now a bit field 1 bit wide.
4005 (bidi_shelve_cache, bidi_unshelve_cache):
4008 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4009 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4010 and vector-like objects.
4012 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4013 cache around display iteration.
4015 * window.c (Fwindow_end, window_scroll_pixel_based)
4016 (displayed_window_lines, Frecenter): Save and restore the bidi
4017 cache around display iteration.
4019 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4021 * editfns.c (Fdelete_region): Clarify the use of the named
4022 parameters (bug#6788).
4024 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4026 * indent.c (Fvertical_motion): Set and restore w->pointm when
4027 saving and restoring the window's buffer (Bug#9006).
4029 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4031 * editfns.c (Fstring_to_char): Clarify just what is returned
4032 (bug#6576). Text by Eli Zaretskii.
4034 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4036 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4038 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4040 * buffer.c (mmap_find): Fix a typo.
4042 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4044 Fix execution of x selection hooks.
4045 * xselect.c (Qx_lost_selection_functions)
4046 (Qx_sent_selection_functions): New vars.
4047 (syms_of_xselect): DEFSYM them.
4048 (x_handle_selection_request): Pass Qx_sent_selection_functions
4049 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4050 (x_handle_selection_clear,x_clear_frame_selections):
4051 Pass Qx_lost_selection_functions rather than
4052 Vx_lost_selection_functions to Frun_hook_with_args.
4054 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4056 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4057 The old code sometimes used this field without initializing it.
4059 * alloc.c (gc_sweep): Don't read past end of array.
4060 In theory, the old code could also have corrupted Emacs internals,
4061 though it'd be very unlikely.
4063 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4065 * character.c (Fcharacterp): Don't advertise optional ignored
4066 argument. (Bug#4026)
4068 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4070 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4073 * window.c (Fset_window_start): Doc fix (bug#4199).
4074 (Fset_window_hscroll): Ditto.
4076 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4078 Fix minor new problems caught by GCC 4.6.1.
4079 * term.c (init_tty): Remove unused local.
4080 * xsettings.c (store_monospaced_changed): Define this function only
4081 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4084 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4086 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4088 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4090 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4091 are the mini-buffer and the echo area (bug#3320).
4093 * term.c (init_tty): Remove support for supdup, c10 and perq
4094 terminals, which are no longer supported (bug#1482).
4096 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4098 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4100 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4102 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4103 for non-popups (Bug#3642).
4105 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4107 * alloc.c (reset_malloc_hooks): Protoize.
4108 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4109 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4110 * cm.c (losecursor): Likewise.
4111 * data.c (fmod): Likewise.
4112 * dispnew.c (swap_glyphs_in_rows): Likewise.
4113 * emacs.c (memory_warning_signal): Likewise.
4114 * floatfns.c (float_error): Likewise.
4115 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4116 (otf_open, font_otf_capability, generate_otf_features)
4117 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4119 * image.c (pbm_read_file): Likewise.
4120 * indent.c (string_display_width): Likewise.
4121 * intervals.c (check_for_interval, search_for_interval)
4122 (inc_interval_count, count_intervals, root_interval)
4123 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4124 * lread.c (defalias): Likewise.
4125 * ralloc.c (r_alloc_check): Likewise.
4126 * regex.c (set_image_of_range_1, set_image_of_range)
4127 (regex_grow_registers): Likewise.
4128 * sysdep.c (strerror): Likewise.
4129 * termcap.c (valid_filename_p, tprint, main): Likewise.
4130 * tparam.c (main): Likewise.
4131 * unexhp9k800.c (run_time_remap, save_data_space)
4132 (update_file_ptrs, read_header, write_header, calculate_checksum)
4133 (copy_file, copy_rest, display_header): Likewise.
4134 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4136 * xdisp.c (check_it): Likewise.
4137 * xfaces.c (register_color, unregister_color, unregister_colors):
4139 * xfns.c (print_fontset_result): Likewise.
4140 * xrdb.c (member, fatal, main): Likewise.
4142 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4144 Fix minor problems found by static checking (Bug#9031).
4145 * chartab.c (char_table_set_range, map_sub_char_table):
4146 Remove unused locals.
4147 (uniprop_table): Now static.
4148 * composite.c (_work_char): Remove unused static var.
4150 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4152 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4154 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4156 * gtkutil.c (qttip_cb): Remove code without function.
4158 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4160 * w32.c (pthread_sigmask): New stub.
4162 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4164 Use pthread_sigmask, not sigprocmask (Bug#9010).
4165 sigprocmask is portable only for single-threaded applications, and
4166 Emacs can be multi-threaded when it uses GTK.
4167 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4169 * callproc.c (Fcall_process):
4170 * process.c (create_process):
4171 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4172 Use pthread_sigmask, not sigprocmask.
4174 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4176 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4177 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4180 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4182 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4183 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4184 (xg_hide_tooltip): Fix comment.
4186 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4187 in registerServicesMenuSendTypes.
4188 (validRequestorForSendType): Don't check ns_return_types.
4190 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4193 2011-07-08 Jason Rumney <jasonr@gnu.org>
4195 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4196 SH_SHOW for hidden windows (Bug#5482).
4198 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4199 frame struct members of non-existent frames (Bug#6284).
4201 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4203 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4204 variable firstTime not needed on OSX >= 10.6.
4205 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4206 >= 10.5. Use setKnobProportion, setDoubleValue.
4208 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4209 (MAC_OS_X_VERSION_10_5): Define if not defined.
4210 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4211 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4212 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4214 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4215 cString and lossyCString on OSX >= 10.4
4217 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4218 sizeToFit on OSX >= 10.2.
4220 * nsimage.m (allocInitFromFile): Don't use deprecated method
4221 bestRepresentationForDevice on OSX >= 10.6.
4223 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4226 * emacs.c: Declare unexec_init_emacs_zone.
4228 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4230 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4232 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4233 on svcsMenu (Bug#8842).
4235 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4237 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4239 * nsterm.m (QUTF8_STRING): Declare.
4240 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4241 (validRequestorForSendType): Return type is (id).
4242 Change indexOfObjectIdenticalTo to indexOfObject.
4243 Check if we have local selection before returning self (Bug#8842).
4244 (writeSelectionToPasteboard): Put local selection into paste board
4245 if we have a local selection (Bug#8842).
4246 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4248 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4249 (ns_get_local_selection): Declare.
4251 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4253 * keymap.c (describe_map_tree): Don't insert a double newline at
4254 the end of the buffer (bug#1169) and return whether we inserted
4257 * callint.c (Fcall_interactively): Change "reading args" to
4258 "providing args" to try to clarify what it does (bug#1010).
4260 2011-07-07 Kenichi Handa <handa@m17n.org>
4262 * composite.c (composition_compute_stop_pos): Ignore a static
4263 composition starting before CHARPOS (Bug#8915).
4265 * xdisp.c (handle_composition_prop): Likewise.
4267 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4269 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4272 2011-07-07 Kenichi Handa <handa@m17n.org>
4274 * character.h (unicode_category_t): New enum type.
4276 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4277 (Qchar_code_property_table): New variable.
4278 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4279 (UNIPROP_COMPRESSED_FORM_P): New macros.
4280 (char_table_ascii): Uncompress the compressed values.
4281 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4282 Uncompress the compressed values.
4283 (sub_char_table_ref_and_range): Likewise.
4284 (char_table_ref_and_range): Uncompress the compressed values.
4285 (sub_char_table_set): New arg is_uniprop. Callers changed.
4286 Uncompress the compressed values.
4287 (sub_char_table_set_range): Args changed. Callers changed.
4288 (char_table_set_range): Adjuted for the above change.
4289 (map_sub_char_table): Delete args default_val and parent. Add arg
4290 top. Give decoded values to a Lisp function.
4291 (map_char_table): Adjust for the above change. Give decoded
4292 values to a Lisp function. Gcpro more variables.
4293 (uniprop_table_uncompress)
4294 (uniprop_decode_value_run_length): New functions.
4295 (uniprop_decoder, uniprop_decoder_count): New variables.
4296 (uniprop_get_decoder, uniprop_encode_value_character)
4297 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4299 (uniprop_encoder, uniprop_encoder_count): New variables.
4300 (uniprop_get_encoder, uniprop_table)
4301 (Funicode_property_table_internal, Fget_unicode_property_internal)
4302 (Fput_unicode_property_internal): New functions.
4303 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4304 Sunicode_property_table_internal, Sget_unicode_property_internal,
4305 and Sput_unicode_property_internal. Defvar_lisp
4306 char-code-property-alist.
4308 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4309 Vunicode_category_table.
4311 * font.c (font_range): Adjust for the change of
4312 Vunicode_category_table.
4314 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4316 * m/iris4d.h: Remove file, move contents ...
4317 * s/irix6-5.h: ... here.
4319 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4321 Remove unportable assumption about struct layout (Bug#8884).
4322 * alloc.c (mark_buffer):
4323 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4324 (clone_per_buffer_values): Don't assume that
4325 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4326 This isn't true in general, and it's particularly not true
4327 if Emacs is configured with --with-wide-int.
4328 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4329 New macros, used in the buffer.c change.
4331 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4333 * xsettings.c: Use both GConf and GSettings if both are available.
4334 (store_config_changed_event): Add comment.
4335 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4336 (store_tool_bar_style_changed): New functions.
4337 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4338 (struct xsettings): Move font inside HAVE_XFT.
4339 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4340 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4341 Move inside HAVE_XFT.
4342 (something_changed_gsettingsCB): Rename from something_changedCB.
4343 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4345 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4346 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4347 (something_changed_gconfCB): Rename from something_changedCB.
4348 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4349 (parse_settings): Move check for font inside HAVE_XFT.
4350 (read_settings, apply_xft_settings): Add comment.
4351 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4352 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4353 call store_font_name_changed.
4354 (xft_settings_event): Add comment.
4355 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4356 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4357 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4358 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4359 (xsettings_initialize): Call init_gsettings last.
4360 (xsettings_get_system_font, xsettings_get_system_normal_font):
4363 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4365 Random fixes. E.g., (random) never returned negative values.
4366 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4367 subseconds part to the entropy, as that's a bit more random.
4368 Prefer signed to unsigned, since the signedness doesn't matter and
4369 in general we prefer signed. When given a limit, use a
4370 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4371 latter isn't right if USE_2_TAGS_FOR_INTS.
4372 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4373 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4375 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4377 * textprop.c (text_property_stickiness):
4378 Obey Vtext_property_default_nonsticky.
4379 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4380 * w32fns.c (syms_of_w32fns):
4381 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4383 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4385 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4386 This is more efficient than Ffile_directory_p and avoids a minor race.
4388 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4390 * buffer.c (Foverlay_put): Say what the return value is
4393 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4394 is a directory before asking whether to use the file name
4396 (barf_or_query_if_file_exists): Make the "File is a directory"
4397 error be more correct.
4399 * fns.c (Frequire): Remove the mention of the .gz files, since
4400 that's installation-specific, but keep the mention of
4401 `get-load-suffixes'.
4403 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4405 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4406 Report string overflow if the output is too long.
4408 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4410 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4411 (syms_of_gnutls): Remove duplicate DEFSYM for
4412 Qgnutls_bootprop_verify_hostname_error, an error for
4413 Qgnutls_bootprop_verify_error (which is no longer used).
4415 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4416 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4417 Also (re)move comments that are misplaced or no longer relevant.
4419 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4421 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4423 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4425 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4426 and background color parameters if they have been changed.
4428 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4430 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4432 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4434 * xsettings.c (SYSTEM_FONT): Define only when used.
4435 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4437 * keymap.c (access_keymap_1): Now static.
4439 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4441 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4442 leave any prefix arg for the up event (Bug#1586).
4444 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4446 * lread.c (syms_of_lread): Mention single symbols defined by
4447 `defvar' or `defconst' (bug#7154).
4449 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4450 (Frequire): Mention get-load-suffixes.
4452 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4454 * window.h (window): Remove clone_number slot.
4455 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4457 (make_parent_window, make_window, saved_window)
4458 (Fset_window_configuration, save_window_save): Don't deal with
4460 * buffer.c (Qclone_number): Remove declaration.
4461 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4463 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4465 Add multiple inheritance to keymaps.
4466 * keymap.c (Fmake_composed_keymap): New function.
4467 (Fset_keymap_parent): Simplify.
4468 (fix_submap_inheritance): Remove.
4469 (access_keymap_1): New function extracted from access_keymap to handle
4470 embedded parents and handle lists of maps.
4471 (access_keymap): Use it.
4472 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4473 (Fcopy_keymap): Handle embedded parents.
4474 (Fcommand_remapping, define_as_prefix): Simplify.
4475 (Fkey_binding): Simplify.
4476 (syms_of_keymap): Move minibuffer-local-completion-map,
4477 minibuffer-local-filename-completion-map,
4478 minibuffer-local-must-match-map, and
4479 minibuffer-local-filename-must-match-map to Elisp.
4480 (syms_of_keymap): Defsubr make-composed-keymap.
4481 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4482 (parse_menu_item): Trivial simplification.
4484 2011-07-01 Glenn Morris <rgm@gnu.org>
4486 * Makefile.in (SETTINGS_LIBS): Fix typo.
4488 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4490 * coding.c (Fencode_coding_string): Record the last coding system
4491 used, as the function doc string says (bug#8738).
4493 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4495 * xsettings.c (store_monospaced_changed): Take new font as arg and
4496 check for change against current_mono_font.
4497 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4498 (emacs_settings_constructor, emacs_settings_get_property)
4499 (emacs_settings_set_property, emacs_settings_class_init)
4500 (emacs_settings_init, gsettings_obj): Remove.
4501 (something_changedCB): New function for HAVE_GSETTINGS.
4502 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4503 with value as argument.
4504 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4505 g_settings_new (Bug#8967). Do not create gsettings_obj.
4506 Remove calls to g_settings_bind. Connect something_changedCB to
4509 * xgselect.c: Add defined (HAVE_GSETTINGS).
4510 (xgselect_initialize): Ditto.
4512 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4513 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4516 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4518 * eval.c (struct backtrace): Simplify and port the data structure.
4519 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4520 signed bit field, as this assumption is not portable and it makes
4521 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4522 "char debug_on_exit : 1" as this is not portable either; instead,
4523 use the portable "unsigned int debug_on_exit : 1". Remove unused
4524 member evalargs. Remove obsolete comments about cc bombing out.
4526 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4528 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4529 Let HAVE_GSETTINGS override HAVE_GCONF.
4530 (store_monospaced_changed): New function.
4531 (EMACS_SETTINGS): A new type derived from GObject to handle
4532 GSettings notifications.
4533 (emacs_settings_constructor, emacs_settings_get_property)
4534 (emacs_settings_set_property, emacs_settings_class_init):
4536 (gsettings_client, gsettings_obj): New variables.
4537 (GSETTINGS_SCHEMA): New define.
4538 (something_changedCB): Call store_monospaced_changed.
4539 (init_gsettings): New function.
4540 (xsettings_initialize): Call init_gsettings.
4541 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4544 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4547 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4549 * window.c (resize_root_window, grow_mini_window)
4550 (shrink_mini_window): Rename Qresize_root_window to
4551 Qwindow_resize_root_window and Qresize_root_window_vertically to
4552 Qwindow_resize_root_window_vertically.
4554 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4556 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4558 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4560 * makefile.w32-in: Redesign dependencies so they reflect more
4561 clearly which files are directly included by each source file,
4562 and not through other includes.
4564 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4566 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4567 (sort_overlays, overlay_strings): When an overlay's clone number
4568 matches the window's clone number process the overlay even if
4569 the overlay's window property doesn't match the current window.
4571 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4572 (Fwindow_hchild): Rename to Fwindow_left_child.
4573 (Fwindow_next): Rename to Fwindow_next_sibling.
4574 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4575 (resize_window_check): Rename to window_resize_check.
4576 (resize_window_apply): Rename to window_resize_apply.
4577 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4578 (Fdelete_other_windows_internal, resize_frame_windows)
4579 (Fsplit_window_internal, Fdelete_window_internal)
4580 (grow_mini_window, shrink_mini_window)
4581 (Fresize_mini_window_internal): Fix callers accordingly.
4583 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4585 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4586 (emacs_fixed_set_min_size): Remove.
4587 (emacs_fixed_new): Take frame as argument.
4589 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4590 (_EmacsFixedPrivate): Remove minwidth/height.
4591 Add struct frame *f.
4592 (emacs_fixed_init): Initialize priv->f.
4593 (get_parent_class, emacs_fixed_set_min_size): Remove.
4594 (emacs_fixed_new): Set priv->f to argument.
4595 (emacs_fixed_get_preferred_width)
4596 (emacs_fixed_get_preferred_height): Use min_width/height from
4597 frames size_hint to set minimum and natural (Bug#8919).
4598 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4599 and use min_width/height from frames size_hint to set
4600 min_width/height (Bug#8919).
4602 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4603 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4606 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4608 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4609 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4612 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4614 * process.c (wait_reading_process_output): Bypass select if
4615 waiting for a cell while ignoring keyboard input, and input is
4616 pending. Suggested by Jan Djärv (Bug#8869).
4618 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4620 Use gnulib's dup2 module instead of rolling our own.
4621 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4623 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4625 * dispnew.c (scrolling_window): Before scrolling, turn off a
4626 mouse-highlight in the window being scrolled.
4628 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4630 Move DEFSYM to lisp.h and use everywhere.
4632 * character.h (DEFSYM): Move declaration...
4633 * lisp.h (DEFSYM): ...here.
4639 * w32select.c: Don't include character.h.
4641 * alloc.c (syms_of_alloc):
4642 * buffer.c (syms_of_buffer):
4643 * bytecode.c (syms_of_bytecode):
4644 * callint.c (syms_of_callint):
4645 * casefiddle.c (syms_of_casefiddle):
4646 * casetab.c (init_casetab_once):
4647 * category.c (init_category_once, syms_of_category):
4648 * ccl.c (syms_of_ccl):
4649 * cmds.c (syms_of_cmds):
4650 * composite.c (syms_of_composite):
4651 * dbusbind.c (syms_of_dbusbind):
4652 * dired.c (syms_of_dired):
4653 * dispnew.c (syms_of_display):
4654 * doc.c (syms_of_doc):
4655 * editfns.c (syms_of_editfns):
4656 * emacs.c (syms_of_emacs):
4657 * eval.c (syms_of_eval):
4658 * fileio.c (syms_of_fileio):
4659 * fns.c (syms_of_fns):
4660 * frame.c (syms_of_frame):
4661 * fringe.c (syms_of_fringe):
4662 * insdel.c (syms_of_insdel):
4663 * keymap.c (syms_of_keymap):
4664 * lread.c (init_obarray, syms_of_lread):
4665 * macros.c (syms_of_macros):
4666 * msdos.c (syms_of_msdos):
4667 * print.c (syms_of_print):
4668 * process.c (syms_of_process):
4669 * search.c (syms_of_search):
4670 * sound.c (syms_of_sound):
4671 * syntax.c (init_syntax_once, syms_of_syntax):
4672 * terminal.c (syms_of_terminal):
4673 * textprop.c (syms_of_textprop):
4674 * undo.c (syms_of_undo):
4675 * w32.c (globals_of_w32):
4676 * window.c (syms_of_window):
4677 * xdisp.c (syms_of_xdisp):
4678 * xfaces.c (syms_of_xfaces):
4679 * xfns.c (syms_of_xfns):
4680 * xmenu.c (syms_of_xmenu):
4681 * xsettings.c (syms_of_xsettings):
4682 * xterm.c (syms_of_xterm): Use DEFSYM.
4684 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4686 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4688 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4690 Integer and buffer overflow fixes (Bug#8873).
4692 * print.c (printchar, strout): Check for string overflow.
4693 (PRINTPREPARE, printchar, strout):
4694 Don't set size unless allocation succeeds.
4696 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4697 for sizes. Check for string overflow more accurately.
4698 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4700 * macros.c: Integer and buffer overflow fixes.
4701 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4702 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4703 Use ptrdiff_t, not int, for sizes.
4704 Don't increment bufsize until after realloc succeeds.
4705 Check for size-calculation overflow.
4706 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4708 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4710 * lread.c: Integer overflow fixes.
4711 (read_integer): Radix is now EMACS_INT, not int,
4712 to improve quality of diagnostics for out-of-range radices.
4713 Calculate buffer size correctly for out-of-range radices.
4714 (read1): Check for integer overflow in radices, and in
4715 read-circle numbers.
4716 (read_escape): Avoid int overflow.
4717 (Fload, openp, read_buffer_size, read1)
4718 (substitute_object_recurse, read_vector, read_list, map_obarray):
4719 Use ptrdiff_t, not int, for sizes.
4720 (read1): Use EMACS_INT, not int, for sizes.
4721 Check for size overflow.
4723 * image.c (cache_image): Check for size arithmetic overflow.
4725 * lread.c: Integer overflow issues.
4726 (saved_doc_string_size, saved_doc_string_length)
4727 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4728 Now ptrdiff_t, not int.
4729 (read1): Don't assume doc string length fits in int. Check for
4730 out-of-range doc string lengths.
4731 (read_list): Don't assume file position fits in int.
4732 (read_escape): Check for hex character overflow.
4734 2011-06-22 Leo Liu <sdl.web@gmail.com>
4736 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4737 Move to minibuffer.el.
4739 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4741 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4742 The following patches are for when GLYPH_DEBUG && !XASSERT.
4743 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4744 * dispnew.c (flush_stdout):
4745 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4746 Mark as externally visible.
4747 * dispnew.c (check_window_matrix_pointers): Now static.
4748 * dispnew.c (window_to_frame_vpos):
4749 * xfns.c (unwind_create_frame):
4750 * xterm.c (x_check_font): Remove unused local.
4751 * scroll.c (CHECK_BOUNDS):
4752 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4753 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4754 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4755 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4756 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4758 (debug_method_add): Use va_list and vsprintf rather than relying
4759 on undefined behavior with wrong number of arguments.
4760 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4761 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4762 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4763 since we're not interested in debugging glyphs with old libraries.
4764 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4765 GCC 4.6.0's static checking.
4767 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4769 Integer overflow and signedness fixes (Bug#8873).
4770 A few related buffer overrun fixes, too.
4772 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4774 * dispextern.h (struct face.stipple):
4775 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4776 (x_bitmap_mask, x_allocate_bitmap_record)
4777 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4778 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4779 (x_create_bitmap_from_xpm_data):
4780 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4781 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4783 * xfaces.c (load_pixmap):
4784 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4785 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4786 (.bitmaps_last, struct x_output.icon_bitmap):
4787 Use ptrdiff_t, not int, for bitmap indexes.
4788 (x_allocate_bitmap_record): Check for size overflow.
4789 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4791 Use ptrdiff_t, not int, for overlay counts.
4792 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4793 * editfns.c (overlays_around, get_pos_property):
4794 * textprop.c (get_char_property_and_overlay):
4795 * xdisp.c (next_overlay_change, note_mouse_highlight):
4796 * xfaces.c (face_at_buffer_position):
4797 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4798 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4799 (Fnext_overlay_change, Fprevious_overlay_change)
4800 (mouse_face_overlay_overlaps, Foverlays_in):
4801 Use ptrdiff_t, not int, for sizes.
4802 (overlays_at, overlays_in): Check for size-calculation overflow.
4804 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4806 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4807 (x_session_initialize): Do not assume string length fits in int.
4809 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4810 This is unlikely, but can occur if DPI is outlandish.
4812 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4813 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4815 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4816 * xrdb.c (magic_file_p, search_magic_path):
4817 Omit last arg SUFFIX; it was always 0. All callers changed.
4818 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4820 * xfont.c (xfont_match): Avoid need for strlen.
4822 * xfns.c: Don't assume strlen fits in int.
4823 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4825 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4826 not unsigned long, as we prefer signed integers. All callers changed.
4827 Detect integer overflow in repeat count.
4828 (message_dolog): Don't assume print length fits in 39 bytes.
4829 (display_mode_element): Don't assume strlen fits in int.
4831 * termcap.c: Don't assume sizes fit in int and never overflow.
4832 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4833 (gobble_line): Check for size-calculation overflow.
4835 * minibuf.c (Fread_buffer):
4836 * lread.c (intern, intern_c_string):
4837 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4838 Don't assume string length fits in int.
4840 * keyboard.c (parse_tool_bar_item):
4841 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4843 * font.c: Don't assume string length fits in int.
4844 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4845 Use ptrdiff_t, not int.
4846 (font_intern_prop): Don't assume string length fits in int.
4847 Don't assume integer property fits in fixnum.
4848 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4850 * filelock.c: Fix some buffer overrun and integer overflow issues.
4851 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4852 Reformulate so as not to need the command string.
4853 Invoke gzip -cd rather than gunzip, as it's more portable.
4854 (lock_info_type, lock_file_1, lock_file):
4855 Don't assume pid_t and time_t fit in unsigned long.
4856 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4857 (current_lock_owner): Prefer signed type for sizes.
4858 Use memcpy, not strncpy, where memcpy is what is really wanted.
4859 Don't assume (via atoi) that time_t and pid_t fit in int.
4860 Check for time_t and/or pid_t out of range, e.g., via a network share.
4861 Don't alloca where an auto var works fine.
4863 * fileio.c: Fix some integer overflow issues.
4864 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4865 Don't assume string length fits in int.
4866 (directory_file_name): Don't assume string length fits in long.
4867 (make_temp_name): Don't assume pid fits in int, or that its print
4868 length is less than 20.
4870 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4872 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4874 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4876 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4877 We prefer signed integers, even for size calculations.
4879 * emacs.c: Don't assume string length fits in 'int'.
4880 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4881 (main): Don't invoke strlen when not needed.
4883 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4884 (XD_DEBUG_MESSAGE): Don't waste a byte.
4886 * callproc.c (getenv_internal_1, getenv_internal)
4888 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4890 * lread.c (invalid_syntax): Omit length argument.
4891 All uses changed. This doesn't fix a bug, but it simplifies the
4892 code away from its former Hollerith-constant appearance, and it's
4893 one less 'int' to worry about when looking at integer-overflow issues.
4894 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4896 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4897 This didn't break anything, but it didn't help either.
4898 It's confusing to put a bogus integer in a place where the actual
4899 value does not matter.
4900 (LIST_END_P): Remove unused macro and its bogus comment.
4901 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4903 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4904 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4906 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4907 We prefer signed types, and the value cannot exceed the EMACS_INT
4908 range anyway (because otherwise the length would not be representable).
4909 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4910 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4911 This avoids a GCC warning when WIDE_EMACS_INT.
4913 * indent.c (sane_tab_width): New function.
4914 (current_column, scan_for_column, Findent_to, position_indentation)
4915 (compute_motion): Use it. This is just for clarity.
4916 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4918 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4920 * lisp.h (lint_assume): New macro.
4921 * composite.c (composition_gstring_put_cache):
4922 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4924 * editfns.c, insdel.c:
4925 Omit unnecessary forward decls, to simplify future changes.
4927 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4929 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4931 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4932 Use much-faster test for byte-length change.
4933 Don't assume string byte-length fits in 'int'.
4934 Check that character arg fits in 'int'.
4935 (mapcar1): Declare byte as byte, for clarity.
4937 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4939 * fns.c (concat): Catch string overflow earlier.
4940 Do not rely on integer wraparound.
4942 * dispextern.h (struct it.overlay_strings_charpos)
4943 (struct it.selective): Now EMACS_INT, not int.
4944 * xdisp.c (forward_to_next_line_start)
4945 (back_to_previous_visible_line_start)
4946 (reseat_at_next_visible_line_start, next_element_from_buffer):
4947 Don't arbitrarily truncate the value of 'selective' to int.
4949 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4951 * composite.c: Don't truncate sizes to 'int'.
4952 (composition_gstring_p, composition_reseat_it)
4953 (composition_adjust_point): Use EMACS_INT, not int.
4954 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4955 not EMACS_UINT, for indexes.
4957 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4959 * buffer.c: Include <verify.h>.
4960 (struct sortvec.priority, struct sortstr.priority):
4961 Now EMACS_INT, not int.
4962 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4963 (struct sortstr.size, record_overlay_string)
4964 (struct sortstrlist.size, struct sortlist.used):
4965 Don't truncate size to int.
4966 (record_overlay_string): Check for size-calculation overflow.
4967 (init_buffer_once): Check at compile-time, not run-time.
4969 2011-06-22 Jim Meyering <meyering@redhat.com>
4971 Don't leak an XBM-image-sized buffer
4972 * image.c (xbm_load): Free the image buffer after using it.
4974 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4977 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4978 that Sun C diagnosed.
4979 * fns.c (secure_hash): Fix pointer signedness issue.
4980 * intervals.c (static_offset_intervals): New function.
4981 (offset_intervals): Use it.
4983 2011-06-21 Leo Liu <sdl.web@gmail.com>
4986 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4989 * fns.c (secure_hash): Rename from crypto_hash_function and change
4990 the first arg to accept symbols.
4991 (Fsecure_hash): New primitive.
4992 (syms_of_fns): New symbols.
4994 2011-06-20 Deniz Dogan <deniz@dogan.se>
4996 * process.c (Fset_process_buffer): Clarify return value in
4999 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5001 * dispnew.c (add_window_display_history): Use BVAR.
5003 * xdisp.c (debug_method_add): Use BVAR.
5004 (check_window_end, dump_glyph_matrix, dump_glyph)
5005 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5007 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5010 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5011 check till after the cache is created in init_frame_faces.
5013 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5015 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5017 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5019 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5020 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5021 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5023 Improve buffer-overflow checking (Bug#8873).
5024 * fileio.c (Finsert_file_contents):
5025 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5026 Remove the old (too-loose) buffer overflow checks.
5027 They weren't needed, since make_gap checks for buffer overflow.
5028 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5029 The old code merely checked for Emacs fixnum overflow, and relied
5030 on undefined (wraparound) behavior. The new code avoids undefined
5031 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5033 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5034 Tune. Don't use wider integers than needed. Don't use alloca.
5035 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5037 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5039 * insdel.c, lisp.h (buffer_overflow): New function.
5040 (insert_from_buffer_1, replace_range, replace_range_2):
5041 * insdel.c (make_gap_larger):
5042 * editfns.c (Finsert_char):
5043 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5045 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5047 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5049 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5051 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5052 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5054 * fileio.c: Don't assume EMACS_INT fits in off_t.
5055 (emacs_lseek): New static function.
5056 (Finsert_file_contents, Fwrite_region): Use it.
5057 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5059 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5061 * fns.c: Don't overflow int when computing a list length.
5062 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5063 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5064 truncation on 64-bit hosts. Check for QUIT every
5065 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5066 faster and is responsive enough.
5067 (Flength): Report an error instead of overflowing an integer.
5068 (Fsafe_length): Return a float if the value is not representable
5069 as a fixnum. This shouldn't happen except in contrived situations.
5070 (Fnthcdr, Fsort): Don't assume list length fits in int.
5071 (Fcopy_sequence): Don't assume vector length fits in int.
5073 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5074 (header_size, word_size): New constants.
5075 (allocate_vectorlike): Don't check size overflow here.
5076 (allocate_vector): Check it here instead, since this is the only
5077 caller of allocate_vectorlike that could cause overflow.
5078 Check that the new vector's length is representable as a fixnum.
5080 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5081 The previous code was bogus. For example, next_almost_prime (32)
5082 returned 39, which is undesirable as it is a multiple of 3; and
5083 next_almost_prime (24) returned 25, which is a multiple of 5 so
5084 why was the code bothering to check for multiples of 7?
5086 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5088 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5090 Variadic C functions now count arguments with ptrdiff_t.
5091 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5092 Back then I didn't know that the Emacs coding style prefers signed int.
5093 Also, in the meantime I found a few more instances where arguments
5094 were being counted with int, which may truncate counts on 64-bit
5095 machines, or EMACS_INT, which may be unnecessarily wide.
5096 * lisp.h (struct Lisp_Subr.function.aMANY)
5097 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5098 Arg counts are now ptrdiff_t, not size_t.
5099 All variadic functions and their callers changed accordingly.
5100 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5101 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5102 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5103 * callint.c (Fcall_interactively): Check arg count for overflow,
5104 to avoid potential buffer overrun. Use signed char, not 'int',
5105 for 'varies' array, so that we needn't bother to check its size
5106 calculation for overflow.
5107 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5108 * eval.c (apply_lambda):
5109 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5110 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5111 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5113 * callint.c (Fcall_interactively): Don't use index var as event count.
5115 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5116 * mem-limits.h (SIZE): Remove; no longer used.
5118 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5120 Remove unnecessary casts.
5121 * xterm.c (x_term_init):
5122 * xfns.c (x_set_border_pixel):
5123 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5124 These aren't needed now that we assume ANSI C.
5126 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5127 It's more likely to cause problems (due to unsigned overflow)
5130 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5132 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5134 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5136 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5138 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5140 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5142 GLYPH_CODE_FACE returns EMACS_INT, not int.
5143 * dispextern.h (merge_faces):
5144 * xfaces.c (merge_faces):
5145 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5146 Don't assume EMACS_INT fits in int.
5148 * character.h (CHAR_VALID_P): Remove unused parameter.
5149 * fontset.c, lisp.h, xdisp.c: All uses changed.
5151 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5153 * fns.c (concat): Minor tuning based on overflow analysis.
5154 This doesn't fix any bugs. Use int to hold character, instead
5155 of constantly refetching from Emacs object. Use XFASTINT, not
5156 XINT, for value known to be a character. Don't bother comparing
5157 a single byte to 0400, as it's always less.
5159 * floatfns.c (Fexpt):
5160 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5162 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5165 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5167 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5168 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5169 incorrectly succeed when S was a string, because 4294967386 was
5170 truncated before it was used.
5172 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5173 Otherwise, an out-of-range integer could cause undefined behavior
5176 * composite.c: Use int, not EMACS_INT, for characters.
5177 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5178 EMACS_INT, for values that are known to be in character range.
5179 This doesn't fix any bugs but is the usual style inside Emacs and
5180 may generate better code on 32-bit machines.
5182 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5183 This is for reasons similar to the recent CHAR_STRING fix.
5184 * charset.c (Fencode_char): Check that character arg is actually
5185 a character. Pass an int to ENCODE_CHAR.
5186 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5187 wider than 'int', as a compile-time check to prevent future regressions
5190 * character.c (char_string): Remove unnecessary casts.
5192 Make sure a 64-bit char is never passed to CHAR_STRING.
5193 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5194 by silently ignoring the top 32 bits, allowing some values
5195 that were far too large to be valid characters.
5196 * character.h: Include <verify.h>.
5197 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5198 arguments are no wider than unsigned, as a compile-time check
5199 to prevent future regressions in this area.
5201 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5202 (Fsubst_char_in_region):
5204 * xdisp.c (decode_mode_spec_coding):
5205 Adjust to CHAR_STRING's new requirement.
5206 * editfns.c (Finsert_char, Fsubst_char_in_region):
5207 * fns.c (concat): Check that character args are actually
5208 characters. Without this test, these functions did the wrong
5209 thing with wildly out-of-range values on 64-bit hosts.
5211 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5212 These casts should not be needed on 32-bit hosts, either.
5213 * keyboard.c (read_char):
5214 * lread.c (Fload): Remove casts to unsigned.
5216 * lisp.h (UNSIGNED_CMP): New macro.
5217 This fixes comparison bugs on 64-bit hosts.
5218 (ASCII_CHAR_P): Use it.
5219 * casefiddle.c (casify_object):
5220 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5221 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5222 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5223 * dispextern.h (FACE_FROM_ID):
5224 * keyboard.c (read_char): Use UNSIGNED_CMP.
5226 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5227 not to EMACS_INT, to avoid GCC warning.
5229 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5231 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5232 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5233 isn't needed on 32-bit machines.
5235 * buffer.c (Fgenerate_new_buffer_name):
5236 Use EMACS_INT for count, not int.
5237 (advance_to_char_boundary): Return EMACS_INT, not int.
5239 * data.c (Qcompiled_function): Now static.
5241 * window.c (window_body_lines): Now static.
5243 * image.c (gif_load): Rename local to avoid shadowing.
5245 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5246 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5247 * alloc.c (make_save_value): Integer argument is now of type
5249 (mark_object): Use ptrdiff_t, not int.
5250 * lisp.h (pD): New macro.
5251 * print.c (print_object): Use it.
5253 * alloc.c: Use EMACS_INT, not int, to count objects.
5254 (total_conses, total_markers, total_symbols, total_vector_size)
5255 (total_free_conses, total_free_markers, total_free_symbols)
5256 (total_free_floats, total_floats, total_free_intervals)
5257 (total_intervals, total_strings, total_free_strings):
5258 Now EMACS_INT, not int. All uses changed.
5259 (Fgarbage_collect): Compute overall total using a double, so that
5260 integer overflow is less likely to be a problem. Check for overflow
5261 when converting back to an integer.
5262 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5263 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5264 These were 'int' variables that could overflow on 64-bit hosts;
5265 they were never used, so remove them instead of repairing them.
5266 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5267 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5268 Previously, this ceilinged at INT_MAX, but that doesn't work on
5270 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5272 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5273 (allocate_vectorlike): Check for ptrdiff_t overflow.
5274 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5275 when a (possibly-narrower) signed value would do just as well.
5276 We prefer using signed arithmetic, to avoid comparison confusion.
5278 * alloc.c: Catch some string size overflows that we were missing.
5279 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5280 for convenience in STRING_BYTES_MAX.
5281 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5282 The definition here is exact; the one in lisp.h was approximate.
5283 (allocate_string_data): Check for string overflow. This catches
5284 some instances we weren't catching before. Also, it catches
5285 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5286 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5287 and ptrdiff_t and EMACS_INT are both 64 bits.
5289 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5290 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5291 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5293 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5295 * alloc.c (Fmake_string): Check for out-of-range init.
5297 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5299 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5301 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5303 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5304 xg_get_default_scrollbar_width.
5306 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5307 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5308 (style_changed_cb): Call update_theme_scrollbar_width and call
5309 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5310 all frames (Bug#8505).
5311 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5312 Call gtk_window_set_resizable if HAVE_GTK3.
5313 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5314 and height if HAVE_GTK3 (Bug#8505).
5315 (scroll_bar_width_for_theme): New variable.
5316 (update_theme_scrollbar_width): New function.
5317 (xg_get_default_scrollbar_width): Move code to
5318 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5319 (xg_initialize): Call update_theme_scrollbar_width.
5321 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5323 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5325 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5327 * frame.c (make_frame): Call other_buffer_safely instead of
5330 * window.c (temp_output_buffer_show): Call display_buffer with
5331 second argument Vtemp_buffer_show_specifiers and reset latter
5332 immediately after the call.
5333 (Vtemp_buffer_show_specifiers): New variable.
5334 (auto_window_vscroll_p, next_screen_context_lines)
5335 (Vscroll_preserve_screen_position): Remove leading asterisks from
5338 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5340 Fix minor problems found by GCC 4.6.0 static checking.
5341 * buffer.c (Qclone_number): Remove for now, as it's unused.
5342 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5343 (record_buffer): Remove unused local.
5344 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5345 (set_frame_buffer_list): Remove; unused.
5346 * frame.h (other_visible_frames): Remove decl.
5347 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5348 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5349 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5351 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5352 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5353 Define only if HAVE_GPM.
5354 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5355 (update_hints_inhibit): Remove; never set. All uses removed.
5356 * widgetprv.h (emacsFrameClassRec): Remove decl.
5357 * window.c (delete_deletable_window): Now returns void, since it
5358 wasn't returning anything.
5359 (compare_window_configurations): Remove unused locals.
5360 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5361 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5362 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5363 the same widths as pointers. This follows up on the 2011-05-06 patch.
5364 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5365 * xterm.h: Likewise.
5366 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5368 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5370 * makefile.w32-in: Update dependencies.
5371 (LISP_H): Add lib/intprops.h.
5373 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5375 * image.c (gif_load): Add animation frame delay to the metadata.
5376 (syms_of_image): Use DEFSYM. New symbol `delay'.
5378 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5380 * window.c (delete_deletable_window): Re-add.
5381 (Fset_window_configuration): Rewrite to handle dead buffers and
5382 consequently deletable windows.
5383 (window_tree, Fwindow_tree): Remove. Supply functionality in
5385 (compare_window_configurations): Simplify code.
5387 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5389 * image.c (imagemagick_load_image): Fix type mismatch.
5390 (Fimagemagick_types): Likewise.
5392 * window.h (replace_buffer_in_windows): Declare.
5394 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5396 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5397 Qclone_number. Remove external declaration of Qdelete_window.
5398 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5400 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5401 Run Qbuffer_list_update_hook if allowed.
5402 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5403 buffer list implementation.
5404 (other_buffer_safely): New function.
5405 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5406 calls to replace_buffer_in_windows and
5407 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5409 (record_buffer): Inhibit quitting and rewrite using quittable
5410 functions. Run Qbuffer_list_update_hook if allowed.
5411 (Frecord_buffer, Funrecord_buffer): New functions.
5412 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5413 Move switch-to-buffer to window.el.
5414 (bury-buffer): Move to window.el.
5415 (Vbuffer_list_update_hook): New variable.
5417 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5420 * window.h (resize_frame_windows): Move up in code.
5421 (Fwindow_frame): Remove EXFUN.
5422 (replace_buffer_in_all_windows): Remove prototype.
5423 (replace_buffer_in_windows_safely): Add prototype.
5425 * window.c: Declare Qdelete_window static again. Move down
5426 declaration of select_count.
5427 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5428 (Fother_window): Move to window.el.
5429 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5430 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5431 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5433 (replace_buffer_in_windows): Implement by calling
5434 Qreplace_buffer_in_windows.
5435 (replace_buffer_in_all_windows): Remove with some functionality
5436 moved into replace_buffer_in_windows_safely.
5437 (replace_buffer_in_windows_safely): New function.
5438 (select_window_norecord, select_frame_norecord): Move in front
5439 of run_window_configuration_change_hook. Remove now obsolete
5441 (Fset_window_buffer): Rewrite doc-string.
5442 Call Qrecord_window_buffer.
5443 (keys_of_window): Move binding for other-window to window.el.
5445 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5447 * dispextern.h (struct image): Replace data member, whose int_val
5448 and ptr_val fields were not used by anything, with a single
5451 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5452 (gif_clear_image, gif_load, imagemagick_load_image)
5453 (gs_clear_image, gs_load): Callers changed.
5455 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5457 * buffer.h: Include <time.h>, for time_t.
5458 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5460 Fix minor problems found by static checking.
5462 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5464 Make identifiers static if they are not used in other modules.
5465 * data.c (Qcompiled_function, Qframe, Qvector):
5466 * image.c (QimageMagick, Qsvg):
5467 * minibuf.c (Qmetadata):
5468 * window.c (resize_window_check, resize_root_window): Now static.
5469 * window.h (resize_window_check, resize_root_window): Remove decls.
5471 * window.c (window_deletion_count, delete_deletable_window):
5473 (window_body_lines): Now static.
5474 (Fdelete_other_windows_internal): Mark vars as initialized.
5475 Make sure 'resize_failed' is initialized.
5476 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5477 (resize_window_apply): Remove unused local.
5478 * window.h (delete_deletable_window): Remove decl.
5480 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5481 (imagemagick_load_image): Fix pointer signedness problem by changing
5482 last arg from unsigned char * to char *. All uses changed.
5483 Also, fix a local for similar reasons.
5484 Remove unused locals. Remove locals to avoid shadowing.
5485 (fn_rsvg_handle_free): Remove; unused.
5486 (svg_load, svg_load_image): Fix pointer signedness problem.
5487 (imagemagick_load_image): Don't use garbage pointer image_wand.
5489 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5491 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5493 * image.c (gif_load): Fix omitted cast error introduced by
5496 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5498 * window.h (resize_proportionally, orig_total_lines)
5499 (orig_top_line): Remove from window structure.
5500 (set_window_height, set_window_width, change_window_heights)
5501 (Fdelete_window): Remove prototypes.
5502 (resize_frame_windows): Remove duplicate declaration.
5504 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5506 * window.h (resize_frame_windows, resize_window_check)
5507 (delete_deletable_window, resize_root_window)
5508 (resize_frame_windows): Declare prototypes.
5510 * window.c (resize_window_apply): Make definition be "static" to
5511 match the prototype.
5513 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5515 * window.c: Remove declarations of Qwindow_size_fixed,
5516 window_min_size_1, window_min_size_2, window_min_size,
5517 size_window, window_fixed_size_p, enlarge_window, delete_window.
5518 Remove static from declaration of Qdelete_window, it's
5519 temporarily needed by Fbury_buffer.
5520 (replace_window): Don't assign orig_top_line and
5522 (Fdelete_window, delete_window): Remove. Window deletion is
5523 handled by window.el.
5524 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5525 Replace Fdelete_window calls with calls to Qdelete_window.
5526 (Fdelete_other_windows): Remove. Deleting other windows is
5527 handled by window.el.
5528 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5529 handled in window.el.
5530 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5531 Window minimum sizes are handled in window.el.
5532 (shrink_windows, size_window, set_window_height)
5533 (set_window_width, change_window_heights, window_height)
5534 (window_width, CURBEG, CURSIZE, enlarge_window)
5535 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5536 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5537 handled in window.el.
5538 (make_dummy_parent): Rename to make_parent_window and give it a
5539 second argument horflag.
5540 (make_window): Don't set resize_proportionally any more.
5541 (Fsplit_window): Remove. Windows are split in window.el.
5542 (save_restore_action, save_restore_orig_size)
5543 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5544 Resize mini windows in window.el.
5545 (grow_mini_window, shrink_mini_window): Implement by calling
5546 Qresize_root_window_vertically, resize_window_check and
5547 resize_window_apply.
5548 (saved_window, Fset_window_configuration, save_window_save):
5549 Do not handle orig_top_line, orig_total_lines, and
5550 resize_proportionally.
5551 (window_min_height, window_min_width): Move to window.el.
5552 (keys_of_window): Move bindings for delete-other-windows,
5553 split-window, delete-window and enlarge-window to window.el.
5555 * buffer.c: Temporarily extern Qdelete_window.
5556 (Fbury_buffer): Temporarily call Qdelete_window instead of
5557 Fdelete_window (Fbury_buffer will move to window.el soon).
5559 * frame.c (set_menu_bar_lines_1): Remove code handling
5560 orig_top_line and orig_total_lines.
5562 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5563 set_window_height but set heights directly.
5564 (change_frame_size_1): Use resize_frame_windows.
5566 * xdisp.c (init_xdisp): Don't use set_window_height but set
5569 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5570 Use resize_frame_windows instead of change_window_heights and run
5571 run_window_configuration_change_hook.
5573 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5574 instead of change_window_heights and run
5575 run_window_configuration_change_hook.
5577 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5579 * window.c (replace_window): Rename second argument REPLACEMENT to
5580 NEW. New third argument SETFLAG. Rewrite.
5581 (delete_window, make_dummy_parent): Call replace_window with
5583 (window_list_1): Move down in code.
5584 (run_window_configuration_change_hook): Move set_buffer part
5585 before select_frame_norecord part in order to unwind correctly.
5586 Rename count1 to count.
5587 (recombine_windows, delete_deletable_window, resize_root_window)
5588 (Fdelete_other_windows_internal)
5589 (Frun_window_configuration_change_hook, make_parent_window)
5590 (resize_window_check, resize_window_apply, Fresize_window_apply)
5591 (resize_frame_windows, Fsplit_window_internal)
5592 (Fdelete_window_internal, Fresize_mini_window_internal):
5594 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5596 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5598 * window.h (window): Add some new members to window structure -
5599 normal_lines, normal_cols, new_total, new_normal, clone_number,
5600 splits, nest, prev_buffers, next_buffers.
5601 (WINDOW_TOTAL_SIZE): Move here from window.c.
5602 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5604 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5606 (make_dummy_parent): Set new members of windows structure.
5607 (make_window): Move down in code. Handle new members of window
5609 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5610 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5611 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5612 (Fset_window_prev_buffers, Fwindow_next_buffers)
5613 (Fset_window_next_buffers, Fset_window_clone_number):
5615 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5616 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5618 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5619 Argument WINDOW can be now internal window too.
5620 (Fwindow_use_time): Move up in code.
5621 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5623 (Fset_window_configuration, saved_window)
5624 (Fcurrent_window_configuration, save_window_save): Handle new
5625 members of window structure.
5626 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5627 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5628 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5629 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5630 Qget_mru_window, Qresize_root_window,
5631 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5632 Qauto_buffer_name; staticpro them.
5634 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5636 * window.c (Fwindow_total_size, Fwindow_left_column)
5637 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5638 (Fwindow_list_1): New functions.
5639 (window_box_text_cols): Replace with window_body_cols.
5640 (Fwindow_width, Fscroll_left, Fscroll_right):
5641 Use window_body_cols instead of window_box_text_cols.
5642 (delete_window, Fset_window_configuration):
5643 Call delete_all_subwindows with window as argument.
5644 (delete_all_subwindows): Take a window as argument and not a
5646 (window_loop): Remove handling of GET_LRU_WINDOW and
5648 (Fget_lru_window, Fget_largest_window): Move to window.el.
5650 * window.h: Extern window_body_cols instead of
5651 window_box_text_cols. delete_all_subwindows now takes a
5652 Lisp_Object as argument.
5654 * indent.c (compute_motion, Fcompute_motion):
5655 Use window_body_cols instead of window_box_text_cols.
5657 * frame.c (delete_frame): Call delete_all_subwindows with root
5660 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5662 * fns.c (Fputhash): Document return value.
5664 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5666 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5668 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5670 Cons<->int and similar integer overflow fixes (Bug#8794).
5672 Check for overflow when converting integer to cons and back.
5673 * charset.c (Fdefine_charset_internal, Fdecode_char):
5674 Use cons_to_unsigned to catch overflow.
5675 (Fencode_char): Use INTEGER_TO_CONS.
5676 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5677 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5678 * data.c (long_to_cons, cons_to_long): Remove.
5679 (cons_to_unsigned, cons_to_signed): New functions.
5680 These signal an error for invalid or out-of-range values.
5681 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5682 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5683 * font.c (Ffont_variation_glyphs):
5684 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5685 * lisp.h: Include <intprops.h>.
5686 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5687 (cons_to_signed, cons_to_unsigned): New decls.
5688 (long_to_cons, cons_to_long): Remove decls.
5689 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5690 (Fprimitive_undo): Use CONS_TO_INTEGER.
5691 * xfns.c (Fx_window_property): Likewise.
5692 * xselect.c: Include <limits.h>.
5693 (x_own_selection, selection_data_to_lisp_data):
5694 Use INTEGER_TO_CONS.
5695 (x_handle_selection_request, x_handle_selection_clear)
5696 (x_get_foreign_selection, Fx_disown_selection_internal)
5697 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5698 (lisp_data_to_selection_data): Use cons_to_unsigned.
5699 (x_fill_property_data): Use cons_to_signed.
5700 Report values out of range.
5702 Check for buffer and string overflow more precisely.
5703 * buffer.h (BUF_BYTES_MAX): New macro.
5704 * lisp.h (STRING_BYTES_MAX): New macro.
5705 * alloc.c (Fmake_string):
5706 * character.c (string_escape_byte8):
5707 * coding.c (coding_alloc_by_realloc):
5708 * doprnt.c (doprnt):
5709 * editfns.c (Fformat):
5711 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5712 since they may not be the same number.
5713 * editfns.c (Finsert_char):
5714 * fileio.c (Finsert_file_contents):
5715 Likewise for BUF_BYTES_MAX.
5717 * image.c: Use ptrdiff_t, not int, for sizes.
5718 (slurp_file): Switch from int to ptrdiff_t.
5720 (slurp_file): Check that file size fits in both size_t (for
5721 malloc) and ptrdiff_t (for sanity and safety).
5723 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5724 if b->modtime has its maximal value.
5726 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5728 Don't assume time_t can fit into int.
5729 * buffer.h (struct buffer.modtime): Now time_t, not int.
5730 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5731 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5733 Minor fixes for signed vs unsigned integers.
5734 * character.h (MAYBE_UNIFY_CHAR):
5735 * charset.c (maybe_unify_char):
5736 * keyboard.c (read_char, reorder_modifiers):
5737 XINT -> XFASTINT, since the integer must be nonnegative.
5738 * ftfont.c (ftfont_spec_pattern):
5739 * keymap.c (access_keymap, silly_event_symbol_error):
5740 XUINT -> XFASTINT, since the integer must be nonnegative.
5741 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5742 since it makes no difference and we prefer signed.
5743 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5744 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5747 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5749 * window.h (Fwindow_frame): Declare.
5751 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5753 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5754 (SPARE_MEMORY): Always define.
5755 (LARGE_REQUEST): Remove.
5756 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5758 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5760 * lisp.h: Move EXFUNS for Fframe_root_window,
5761 Fframe_first_window and Fset_frame_selected_window to window.h.
5763 * window.h: Move EXFUNS for Fframe_root_window,
5764 Fframe_first_window and Fset_frame_selected_window here from
5767 * frame.c (Fwindow_frame, Fframe_first_window)
5768 (Fframe_root_window, Fframe_selected_window)
5769 (Fset_frame_selected_window): Move to window.c.
5770 (Factive_minibuffer_window): Move to minibuf.c.
5771 (Fother_visible_frames_p): New function.
5773 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5775 * window.c (decode_window, decode_any_window): Move up in code.
5776 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5777 (inhibit_frame_unsplittable): Remove unused variable.
5778 (Fwindow_buffer): Move up and rewrite doc-string.
5779 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5780 (Fwindow_prev): New functions.
5781 (Fwindow_frame): Move here from frame.c. Accept any window as
5783 (Fframe_root_window, Fframe_first_window)
5784 (Fframe_selected_window): Move here from frame.c. Accept frame
5785 or arbitrary window as argument. Update doc-strings.
5786 (Fminibuffer_window): Move up in code.
5787 (Fwindow_minibuffer_p): Move up in code and simplify.
5788 (Fset_frame_selected_window): Move here from frame.c.
5790 (Fselected_window, select_window, Fselect_window): Move up in
5791 code. Minor doc-string fixes.
5793 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5795 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5796 Do not assume that spare memory exists; that assumption is valid
5797 only if SYSTEM_MALLOC.
5798 (LARGE_REQUEST): New macro, so that the issue of large requests
5799 is separated from the issue of spare memory.
5801 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5803 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5806 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5808 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5811 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5813 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5815 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5817 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5818 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5820 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5822 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5824 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5826 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5827 (x_clipboard_manager_save): Add return value.
5828 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5830 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5831 Obey Vx_select_enable_clipboard_manager. Catch errors in
5832 x_clipboard_manager_save (Bug#8779).
5833 (Vx_select_enable_clipboard_manager): New variable.
5834 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5836 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5838 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5840 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5842 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5843 in the current matrix if keep_current_p is non-zero.
5845 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5847 * bidi.c (bidi_level_of_next_char): Fix last change.
5849 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5851 Support bidi reordering of text covered by display properties.
5853 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5854 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5855 (bidi_cache_search, bidi_cache_iterator_state)
5856 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5857 (bidi_level_of_next_char, bidi_move_to_visually_next):
5858 Support character positions inside a run of characters covered by a
5860 (bidi_paragraph_init, bidi_resolve_explicit_1)
5861 (bidi_level_of_next_char): Call bidi_fetch_char and
5862 bidi_fetch_char_advance instead of FETCH_CHAR and
5864 (bidi_init_it): Initialize new members.
5865 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5867 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5868 instead of using explicit *_CHAR codes.
5869 (bidi_resolve_explicit, bidi_resolve_weak):
5870 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5871 bidirectional text is supported only in multibyte buffers.
5872 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5873 it to initialize the frame_window_p member of struct bidi_it.
5874 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5875 (bidi_resolve_explicit, bidi_resolve_weak)
5876 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5877 bidi_it->nchars is non-positive.
5878 (bidi_level_of_next_char): Don't try to lookup the cache for the
5879 next/previous character if nothing is cached there yet, or if we
5880 were just reseat()'ed to a new position.
5882 * xdisp.c (set_cursor_from_row): Set start and stop points
5883 according to the row's direction when priming the loop that looks
5884 for the glyph on which to display cursor.
5885 (single_display_spec_intangible_p): Function deleted.
5886 (display_prop_intangible_p): Reimplement to call
5887 handle_display_spec instead of single_display_spec_intangible_p.
5888 Accept 3 additional arguments needed by handle_display_spec.
5889 This fixes incorrect cursor motion across display property with complex
5890 values: lists, `(when COND...)' forms, etc.
5891 (single_display_spec_string_p): Support property values that are
5892 lists with the argument STRING its top-level element.
5893 (display_prop_string_p): Fix the condition for processing a
5894 property that is a list to be consistent with handle_display_spec.
5895 (handle_display_spec): New function, refactored from the
5896 last portion of handle_display_prop.
5897 (compute_display_string_pos): Accept additional argument
5898 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5899 value of a `display' property is a "replacing spec".
5900 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5901 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5902 the display property, but just return a value indicating whether
5903 the display property will replace the characters it covers.
5904 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5905 frame_window_p members of struct bidi_it.
5906 (compute_display_string_pos, compute_display_string_end):
5908 (push_it): Accept second argument POSITION, where pop_it should
5909 jump to continue iteration.
5910 (reseat_1): Initialize bidi_it.disp_pos.
5912 * keyboard.c (adjust_point_for_property): Adjust the call to
5913 display_prop_intangible_p to its new signature.
5915 * dispextern.h (struct bidi_it): New member frame_window_p.
5916 (bidi_init_it): Update prototypes.
5917 (display_prop_intangible_p): Update prototype.
5918 (compute_display_string_pos, compute_display_string_end):
5920 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5923 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5925 Malloc failure behavior now depends on size of allocation.
5926 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5927 * lisp.h: Change signatures accordingly.
5928 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5929 All callers changed. (Bug#8762)
5931 * gnutls.c: Use Emacs's memory allocators.
5932 Without this change, the gnutls library would invoke malloc etc.
5933 directly, which causes problems on non-SYNC_INPUT hosts, and which
5934 runs afoul of improving memory_full behavior. (Bug#8761)
5935 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5936 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5937 xfree instead of the default malloc, realloc, free.
5938 (Fgnutls_boot): No need to check for memory allocation failure,
5939 since xmalloc does that for us.
5941 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5942 * category.c (hash_get_category_set):
5943 * ccl.c (ccl_driver):
5944 * charset.c (Fdefine_charset_internal):
5945 * charset.h (struct charset.hash_index):
5946 * composite.c (get_composition_id, gstring_lookup_cache)
5947 (composition_gstring_put_cache):
5948 * composite.h (struct composition.hash_index):
5949 * dispextern.h (struct image.hash):
5950 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5951 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5952 (hashfn_equal, hashfn_user_defined, make_hash_table)
5953 (maybe_resize_hash_table, hash_lookup, hash_put)
5954 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5955 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5956 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5957 * image.c (make_image, search_image_cache, lookup_image)
5958 (xpm_put_color_table_h):
5959 * lisp.h (struct Lisp_Hash_Table):
5960 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5961 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5962 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5963 * alloc.c (allocate_vectorlike):
5964 Check for overflow in vector size calculations.
5965 * ccl.c (ccl_driver):
5966 Check for overflow when converting EMACS_INT to int.
5967 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5968 need to be updated by these changes.
5969 * fns.c (make_hash_table, maybe_resize_hash_table):
5970 Check for integer overflow with large hash tables.
5971 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5972 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5973 (SXHASH_REDUCE): New macro.
5974 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5975 Use it instead of discarding useful hash info with large hash values.
5976 (sxhash_float): New function.
5977 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5978 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5979 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5980 Rewrite to use FIXNUM_BITS, as this simplifies things.
5981 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5982 Adjust signatures to match updated version of code.
5983 (consing_since_gc): Now EMACS_INT, since a single hash table can
5984 use more than INT_MAX bytes.
5986 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5988 Make it possible to build with GCC-4.6+ -O2 -flto.
5990 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5992 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5994 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5995 Call minibuffer-inactive-mode.
5997 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5999 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6000 Update dependencies.
6002 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6004 * data.c (init_data): Remove code for UTS, this system is not
6007 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6009 Don't force ./temacs to start in terminal mode.
6011 * frame.c (make_initial_frame): Initialize faces in all cases, not
6012 only when CANNOT_DUMP is defined.
6013 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6015 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6017 * dispnew.c (add_window_display_history): Use const for the string
6018 pointer. Remove declaration, not needed.
6020 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6022 Use 'inline', not 'INLINE'.
6023 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6024 * alloc.c, fontset.c (INLINE): Remove.
6025 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6026 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6027 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6028 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6029 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6031 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6033 Make it possible to run ./temacs.
6035 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6036 syms_of_callproc does the same thing. Remove test for
6037 "initialized", do it in the caller.
6038 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6040 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6042 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6043 (read_minibuf): Use get_minibuffer.
6044 (syms_of_minibuf): Use DEFSYM.
6045 (Qmetadata): New var.
6046 * data.c (Qbuffer): Don't make it static.
6047 (syms_of_data): Use DEFSYM.
6049 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6051 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6052 (CCL_CODE_MIN): New macro.
6054 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6056 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6058 * eval.c (Qdebug): Now static.
6059 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6060 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6061 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6063 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6065 * image.c: Various fixes to ImageMagick code comments.
6066 (Fimagemagick_types): Doc fix.
6068 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6070 Minor fixes prompted by GCC 4.6.0 warnings.
6072 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6074 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6075 (x_clipboard_manager_save_all): Move extern decl to ...
6076 * xterm.h: ... here, so that it can be checked for consistency.
6078 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6080 * xselect.c (x_clipboard_manager_save_frame)
6081 (x_clipboard_manager_save_all): New functions.
6082 (Fx_clipboard_manager_save): Lisp function deleted.
6084 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6085 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6087 * xterm.h: Update prototype.
6089 2011-05-28 William Xu <william.xwl@gmail.com>
6091 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6094 2011-05-28 Jim Meyering <meyering@redhat.com>
6096 Avoid a sign-extension bug in crypto_hash_function.
6097 * fns.c (to_uchar): Define.
6098 (crypto_hash_function): Use it to convert some newly-signed
6099 variables to unsigned, to avoid sign-extension bugs. For example,
6100 without this change, (md5 "truc") would evaluate to
6101 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6102 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6103 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6105 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6107 Integer overflow fixes.
6109 * dbusbind.c: Serial number integer overflow fixes.
6110 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6111 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6112 to hold a serial number that is too large for a fixnum.
6113 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6114 Check for serial numbers out of range. Decode any serial number
6115 that was so large that it became a float. (Bug#8722)
6117 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6118 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6119 Use XFASTINT rather than XUINT when numbers are nonnegative.
6120 (xd_append_arg, Fdbus_method_return_internal):
6121 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6122 arguments, check that Lisp number is nonnegative, rather than
6123 silently wrapping negative numbers around. (Bug#8722)
6124 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6127 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6129 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6131 ccl: Add integer overflow checks.
6132 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6133 (IN_INT_RANGE): New macros.
6134 (ccl_driver): Use them to check for integer overflow when
6135 decoding a CCL program. Many of the new checks are whether XINT (x)
6136 fits in int; it doesn't always, on 64-bit hosts. The new version
6137 doesn't catch all possible integer overflows, but it's an
6138 improvement. (Bug#8719)
6140 * alloc.c (make_event_array): Use XINT, not XUINT.
6141 There's no need for unsigned here.
6143 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6144 This follows up to the 2011-05-06 change that substituted uintptr_t
6145 for EMACS_INT. This case wasn't caught back then.
6147 Rework Fformat to avoid integer overflow issues.
6148 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6149 now (part of C89). Include <verify.h>.
6150 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6151 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6152 (Fformat): Avoid the prepass trying to compute sizes; it was only
6153 approximate and thus did not catch overflow reliably. Instead, walk
6154 through the format just once, formatting and computing sizes as we go,
6155 checking for integer overflow at every step, and allocating a larger
6156 buffer as needed. Keep track separately whether the format is
6157 multibyte. Keep only the most-recently calculated precision, rather
6158 than them all. Record whether each argument has been converted to
6159 string. Use EMACS_INT, not int, for byte and char and arg counts.
6160 Support field widths and precisions larger than INT_MAX. Avoid
6161 sprintf's undefined behavior with conversion specifications such as %#d
6162 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6163 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6164 formatting out-of-range floating point numbers with int
6167 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6169 * data.c: Avoid integer truncation in expressions involving floats.
6170 * data.c: Include <intprops.h>.
6171 (arith_driver): When there's an integer overflow in an expression
6172 involving floating point, convert the integers to floating point
6173 so that the resulting value does not suffer from catastrophic
6174 integer truncation. For example, on a 64-bit host (* 4
6175 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6176 Do not rely on undefined behavior after integer overflow.
6178 merge count_size_as_multibyte, parse_str_to_multibyte
6179 * character.c, character.h (count_size_as_multibyte):
6180 Rename from parse_str_to_multibyte; all uses changed.
6181 Check for integer overflow.
6182 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6183 since it's now a duplicate of the other. This is more of
6184 a character than a buffer op, so better that it's in character.c.
6185 * fns.c, print.c: Adjust to above changes.
6187 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6189 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6191 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6193 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6194 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6195 (x_clipboard_manager_save): Now static.
6196 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6198 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6199 (crypto_hash_function): Now static.
6200 Fix pointer signedness problems. Avoid unnecessary initializations.
6202 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6204 * termhooks.h (Vselection_alist): Make it terminal-local.
6206 * terminal.c (create_terminal): Initialize it.
6208 * xselect.c: Support for clipboard managers.
6209 (Vselection_alist): Move to termhooks.h as terminal-local var.
6210 (LOCAL_SELECTION): New macro.
6211 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6212 (symbol_to_x_atom): Remove gratuitous arg.
6213 (x_handle_selection_request, lisp_data_to_selection_data)
6214 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6215 (x_own_selection, x_get_local_selection, x_convert_selection):
6216 New arg, specifying work frame. Use terminal-local Vselection_alist.
6217 (some_frame_on_display): Delete unused function.
6218 (Fx_own_selection_internal, Fx_get_selection_internal)
6219 (Fx_disown_selection_internal, Fx_selection_owner_p)
6220 (Fx_selection_exists_p): New optional frame arg.
6221 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6222 (x_handle_selection_clear): Don't treat other terminals with the
6223 same keyboard specially. Use the terminal-local Vselection_alist.
6224 (x_clear_frame_selections): Use Frun_hook_with_args.
6226 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6228 * xterm.h: Add support for those atoms.
6230 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6232 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6233 (converted_selections, conversion_fail_tag): New global variables.
6234 (x_selection_request_lisp_error): Free the above.
6235 (x_get_local_selection): Remove unnecessary code.
6236 (x_reply_selection_request): Args changed; handle arbitrary array
6237 of converted selections stored in converted_selections.
6238 Separate the XChangeProperty and SelectionNotify steps.
6239 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6240 (x_convert_selection): New function.
6241 (x_handle_selection_event): Simplify.
6242 (x_get_foreign_selection): Don't ignore incoming requests while
6243 waiting for an answer; this will fail when we implement
6244 SAVE_TARGETS, and seems unnecessary anyway.
6245 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6246 (Vx_sent_selection_functions): Doc fix.
6248 2011-05-26 Leo Liu <sdl.web@gmail.com>
6250 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6252 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6254 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6256 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6257 for fringe update if it has periodic bitmap.
6258 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6259 and fringe_bitmap_periodic_p.
6261 * fringe.c (get_fringe_bitmap_data): New function.
6262 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6263 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6264 row. Mark glyph row for fringe update if periodicity changed.
6266 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6267 for fringe update unless it has periodic bitmap.
6269 2011-05-25 Kenichi Handa <handa@m17n.org>
6271 * xdisp.c (get_next_display_element): Set correct it->face_id for
6272 a static composition.
6274 2011-05-24 Leo Liu <sdl.web@gmail.com>
6277 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6279 * fns.c (crypto_hash_function, Fsha1): New function.
6280 (Fmd5): Use crypto_hash_function.
6281 (syms_of_fns): Add Ssha1.
6283 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6285 * gnutls.c: Remove unused macros.
6286 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6287 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6288 Remove macros that are defined and never used.
6289 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6291 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6293 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6294 (Fx_get_selection_internal): Minor cleanup.
6295 (Fx_own_selection_internal): Rename arguments for consistency with
6298 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6300 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6302 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6304 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6306 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6308 * dispnew.c (scrolling_window): Don't exclude the case that the
6309 last enabled row in the desired matrix touches the bottom boundary.
6311 2011-05-21 Glenn Morris <rgm@gnu.org>
6313 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6314 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6315 and add some more files.
6317 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6319 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6320 report_file_error introduced by the change from 2011-05-07.
6322 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6324 * systime.h (Time): Define only if emacs is defined.
6325 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6326 where the include path doesn't have X11/X.h by default. See
6327 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6329 2011-05-20 Kenichi Handa <handa@m17n.org>
6331 * composite.c (find_automatic_composition): Fix previous change.
6333 2011-05-20 Glenn Morris <rgm@gnu.org>
6335 * lisp.mk: New file, split from Makefile.in.
6336 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6337 (shortlisp): Remove.
6338 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6340 2011-05-19 Glenn Morris <rgm@gnu.org>
6342 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6343 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6344 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6345 (lisp): Set the order to that of loadup.el.
6346 (shortlisp): Make it a copy of $lisp.
6347 (SOME_MACHINE_LISP): Remove.
6348 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6349 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6351 2011-05-18 Kenichi Handa <handa@m17n.org>
6353 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6354 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6355 (find_automatic_composition): Mostly rewrite for efficiency.
6357 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6359 * makefile.w32-in: Update dependencies.
6361 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6363 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6364 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6366 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6368 Fix some integer overflow issues, such as string length overflow.
6370 * insdel.c (count_size_as_multibyte): Check for string overflow.
6372 * character.c (lisp_string_width): Check for string overflow.
6373 Use EMACS_INT, not int, for string indexes and lengths; in
6374 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6375 the resulting string length overflows an EMACS_INT; instead,
6376 report a string overflow if no precision given. When checking for
6377 precision exhaustion, use a check that cannot possibly have
6378 integer overflow. (Bug#8675)
6379 * character.h (lisp_string_width): Adjust to new signature.
6381 * alloc.c (string_overflow): New function.
6382 (Fmake_string): Use it. This doesn't change behavior, but saves
6383 a few bytes and will simplify future changes.
6384 * character.c (string_escape_byte8): Likewise.
6385 * lisp.h (string_overflow): New decl.
6387 Fixups, following up to the user-interface timestamp change.
6388 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6389 for UI timestamps, instead of unsigned long.
6390 * msdos.c (mouse_get_pos): Likewise.
6391 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6392 * w32gui.h (Time): Define by including "systime.h" rather than by
6393 declaring it ourselves. (Bug#8664)
6395 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6396 * image.c (clear_image_cache): Likewise.
6398 * term.c (term_mouse_position): Don't assume time_t wraparound.
6400 Be more systematic about user-interface timestamps.
6401 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6402 and sometimes 'EMACS_UINT', to represent these timestamps.
6403 This change causes it to use 'Time' uniformly, as that's what X uses.
6404 This makes the code easier to follow, and makes it easier to catch
6405 integer overflow bugs such as Bug#8664.
6406 * frame.c (Fmouse_position, Fmouse_pixel_position):
6407 Use Time, not unsigned long, for user-interface timestamps.
6408 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6409 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6410 * keyboard.h (last_event_timestamp): Likewise.
6411 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6412 * menu.h (xmenu_show): Likewise.
6413 * term.c (term_mouse_position): Likewise.
6414 * termhooks.h (struct input_event.timestamp): Likewise.
6415 (struct terminal.mouse_position_hook): Likewise.
6416 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6417 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6418 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6419 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6421 * menu.h, termhooks.h: Include "systime.h", for Time.
6423 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6424 Don't assume that the difference between two unsigned long values
6425 can fit into an integer. At this point, we know button_down_time
6426 <= event->timestamp, so the difference must be nonnegative, so
6427 there's no need to cast the result if double-click-time is
6428 nonnegative, as it should be; check that it's nonnegative, just in
6429 case. This bug is triggered when events are more than 2**31 ms
6430 apart (about 25 days). (Bug#8664)
6432 * xselect.c (last_event_timestamp): Remove duplicate decl.
6433 (x_own_selection): Remove needless cast to unsigned long.
6435 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6436 that always fit in int. Use a sentinel instead of a counter, to
6437 avoid a temp and to allay GCC's concerns about possible int overflow.
6438 * frame.h (struct frame): Use int for menu_bar_items_used
6439 instead of EMACS_INT, since it always fits in int.
6441 * menu.c (grow_menu_items): Check for int overflow.
6443 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6445 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6446 Before, the code was not consistent. These values cannot exceed
6447 2**31 - 1 so there's no need to make them unsigned.
6448 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6449 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6450 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6452 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6454 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6455 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6456 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6457 presumably because the widths might not match.
6459 * window.c (size_window): Avoid needless test at loop start.
6461 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6463 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6465 2011-05-12 Drew Adams <drew.adams@oracle.com>
6467 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6469 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6471 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6472 `width' to `bar_area_x' and `bar_area_width', respectively.
6473 (x_scroll_run): Take account of fringe background extension.
6475 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6476 Rename local vars `left' and `width' to `bar_area_x' and
6477 `bar_area_width', respectively.
6478 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6479 background extension.
6481 2011-05-10 Jim Meyering <meyering@redhat.com>
6483 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6485 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6487 * image.c (Finit_image_library): Return t for built-in image types,
6488 like pbm and xbm. (Bug#8640)
6490 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6492 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6494 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6496 * w32console.c (Fset_screen_color): Doc fix.
6497 (Fget_screen_color): New function.
6498 (syms_of_ntterm): Defsubr it.
6500 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6501 unlink the temporary file if Fcall_process didn't create it in the
6503 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6504 child process will be redirected to a file specified with `:file'.
6505 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6506 cue to call_process_cleanup not to close that handle.
6508 2011-05-07 Ben Key <bkey76@gmail.com>
6510 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6511 one of two shell specific rules, either bootstrap-temacs-CMD or
6512 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6513 to the previous implementation of the bootstrap-temacs rule.
6514 The bootstrap-temacs-CMD rule is similar to the previous
6515 implementation of the bootstrap-temacs rule except that it
6516 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6519 These changes, along with some changes to nt/configure.bat,
6520 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6521 earlier fix to add support for --cflags and --ldflags options
6522 that include quotes so that it works whether make uses cmd or
6525 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6527 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6528 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6530 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6531 a string. Handle both cases.
6532 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6533 (Fdbus_register_method): Use Qinvalid_function.
6535 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6537 * makefile.w32-in: Update dependencies.
6538 (LISP_H): Add inttypes.h and stdin.h.
6539 (PROCESS_H): Add unistd.h.
6541 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6543 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6544 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6546 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6548 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6550 * term.c (vfatal): Remove stray call to va_end.
6551 It's not needed and the C Standard doesn't allow it here anyway.
6553 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6554 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6556 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6559 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6561 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6563 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6565 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6567 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6569 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6570 * charset.c (Fdefine_charset_internal): Don't initialize
6571 charset.code_space[15]. The value was garbage, on hosts with
6572 32-bit int (Bug#8600).
6574 * lread.c (read_integer): Be more consistent with string-to-number.
6575 Use string_to_number to do the actual conversion; this avoids
6576 rounding errors and fixes some other screwups. Without this fix,
6577 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6578 (digit_to_number): Move earlier, for benefit of read_integer.
6579 Return -1 if the digit is out of range for the base, -2 if it is
6580 not a digit in any supported base. (Bug#8602)
6582 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6584 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6585 to match comment at start of function. This also removes a
6586 GCC warning about overflow in a 32+64-bit port.
6588 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6590 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6591 Reported by Stefan Monnier in
6592 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6593 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6594 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6596 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6597 (EMACS_UINTPTR): Likewise, with uintptr_t.
6599 * lisp.h: Prefer 64-bit EMACS_INT if available.
6600 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6601 on 32-bit hosts that have 64-bit int, so that they can access
6603 However, temporarily disable this change unless the temporary
6604 symbol WIDE_EMACS_INT is defined.
6606 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6608 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6609 This removes an assumption that EMACS_INT and long are the same
6610 width as pointers. The assumption is true for Emacs porting targets
6611 now, but we want to make other targets possible.
6612 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6613 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6614 In the rest of the code, change types of integers that hold casted
6615 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6616 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6617 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6618 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6619 No need to cast type when ORing.
6620 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6621 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6622 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6623 assume EMACS_INT is the same width as char *.
6624 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6625 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6626 Remove no-longer-needed casts.
6627 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6628 (xg_tool_bar_help_callback, xg_make_tool_item):
6629 Use EMACS_INTPTR to hold an integer
6630 that will be cast to void *; this can avoid a GCC warning
6631 if EMACS_INT is not the same width as void *.
6632 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6633 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6634 (current_message_1, set_message_1):
6635 Use a local to convert to proper width without a cast.
6636 * xmenu.c (dialog_selection_callback): Likewise.
6638 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6639 Also, don't assume VALBITS / RAND_BITS is less than 5,
6640 and don't rely on undefined behavior when shifting a 1 left into
6642 * lisp.h (get_random): Change signature to match.
6644 * lread.c (hash_string): Use size_t, not int, for hash computation.
6645 Normally we prefer signed values; but hashing is special, because
6646 it's better to use unsigned division on hash table sizes so that
6647 the remainder is nonnegative. Also, size_t is the natural width
6648 for hashing into memory. The previous code used 'int', which doesn't
6649 retain enough info to hash well into very large tables.
6650 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6652 * dbusbind.c: Don't possibly lose pointer info when converting.
6653 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6654 Use XPNTR rather than XHASH, so that the high-order bits of
6655 the pointer aren't lost when converting through void *.
6657 * eval.c (Fautoload): Don't double-shift a pointer.
6659 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6661 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6663 * gnutls.c (DEF_GNUTLS_FN):
6664 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6666 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6668 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6671 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6673 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6674 New version that can reserve upto 2GB of heap space.
6676 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6678 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6680 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6682 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6683 `gnutls_certificate_set_x509_key_file'.
6685 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6687 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6688 Update dependencies.
6690 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6692 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6693 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6694 Remove unused parameter `fildes'.
6695 * process.c (read_process_output, send_process): Don't pass it.
6697 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6699 Fix previous change: the library cache is defined in w32.c.
6700 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6701 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6703 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6705 Implement dynamic loading of GnuTLS on Windows.
6707 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6708 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6709 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6712 * gnutls.c (Qgnutls_dll): Define.
6713 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6714 (gnutls_*): Declare function pointers.
6715 (init_gnutls_functions): New function to initialize function pointers.
6716 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6717 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6718 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6719 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6720 (emacs_gnutls_write, emacs_gnutls_read)
6721 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6722 (Fgnutls_available_p): New function.
6723 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6724 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6725 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6727 * image.c: Include w32.h.
6728 (Vimage_type_cache): Delete.
6729 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6730 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6731 (w32_delayed_load): Move to w32.c.
6733 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6735 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6736 (w32_delayed_load): Move from image.c. When loading a library, record
6737 its filename in the :loaded-from property of the library id.
6738 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6739 Initialize and staticpro them.
6740 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6742 * process.c: Include lisp.h before w32.h, not after.
6743 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6744 instead of gnutls_record_check_pending.
6746 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6748 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6750 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6751 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6754 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6756 * xterm.c (x_set_frame_alpha): Do not set property on anything
6757 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6759 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6761 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6763 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6765 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6766 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6767 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6768 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6769 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6770 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6771 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6772 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6773 (Qgnutls_bootprop_callbacks_verify): Make static.
6775 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6777 * callproc.c: Indentation fixup.
6779 * sysdep.c (wait_for_termination_1): Make static.
6780 (wait_for_termination, interruptible_wait_for_termination):
6781 Move after wait_for_termination_1.
6783 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6785 * sysdep.c (interruptible_wait_for_termination): New function
6786 which is like wait_for_termination, but allows keyboard
6789 * callproc.c (Fcall_process): Add (:file "file") as an option for
6791 (Fcall_process_region): Ditto.
6793 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6795 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6796 rather than `XVECTOR (FOO)->size'.
6798 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6799 inttypes.h, as a gnulib replacement is used if it not available in
6802 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6804 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6805 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6806 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6808 * coding.c (coding_alloc_by_realloc): Error out if destination
6809 will grow beyond MOST_POSITIVE_FIXNUM.
6810 (decode_coding_emacs_mule): Abort if there isn't enough place in
6811 charbuf for the composition carryover bytes. Reserve an extra
6812 space for up to 2 characters produced in a loop.
6813 (decode_coding_iso_2022): Abort if there isn't enough place in
6814 charbuf for the composition carryover bytes.
6816 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6818 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6819 aborting when %lld or %lll format is passed.
6820 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6821 %llo or %llx format is passed. (Bug#8545)
6823 * window.c (window_scroll_line_based): Use a marker instead of
6824 simple variables to record original value of point. (Bug#7952)
6826 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6827 produced by %s or %c overflows available buffer space. (Bug#8545)
6829 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6831 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6832 (SIZE_MAX): Move defn after all includes, as they might #define it.
6834 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6836 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6838 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6840 * keyboard.c (Qdelayed_warnings_hook): Define.
6841 (command_loop_1): Run `delayed-warnings-hook'
6842 if Vdelayed_warnings_list is non-nil.
6843 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6844 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6846 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6848 * doprnt.c (doprnt): Don't return value smaller than the buffer
6849 size if the message was truncated. (Bug#8545).
6851 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6853 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6854 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6856 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6858 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6860 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6862 * makefile.w32-in: Update dependencies.
6864 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6866 Improve `doprnt' and its usage. (Bug#8545)
6867 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6868 `format_end'. Remove support for %l as a conversion specifier.
6869 Don't use xrealloc. Improve diagnostics when the %l size modifier
6870 is used. Update the commentary.
6872 * eval.c (verror): Simplify calculation of size_t.
6874 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6877 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6879 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6882 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6884 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6885 This makes this file independent of the recent pseudovector change.
6887 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6889 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6891 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6892 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6893 Remove unused local.
6894 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6896 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6897 GCC 4.6.0 optimizes based on type-based alias analysis.
6898 For example, if b is of type struct buffer * and v of type struct
6899 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6900 != &v->size, and therefore "v->size = 1; b->size = 2; return
6901 v->size;" must therefore return 1. This assumption is incorrect
6902 for Emacs, since it type-puns struct Lisp_Vector * with many other
6903 types. To fix this problem, this patch adds a new type struct
6904 vectorlike_header that documents the constraints on layout of vectors
6905 and pseudovectors, and helps optimizing compilers not get fooled
6906 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6907 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6908 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6910 (XSETPVECTYPE): Rewrite in terms of new macro.
6911 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6912 This is a bit clearer, and further avoids the possibility of
6913 undesirable aliasing.
6914 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6915 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6916 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6917 since Lisp_Subr is a special case (no "next" field).
6918 (ASIZE): Now uses header.size rather than size.
6919 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6920 to avoid the hassle of writing XVECTOR (foo)->header.size.
6921 (struct vectorlike_header): New type.
6922 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6923 object, to help avoid aliasing.
6924 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6925 (SUBRP): Likewise, since Lisp_Subr is a special case.
6926 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6927 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6928 (struct Lisp_Hash_Table): Combine first two members into a single
6929 struct vectorlike_header member. All uses of "size" and "next" members
6930 changed to be "header.size" and "header.next".
6931 * buffer.h (struct buffer): Likewise.
6932 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6933 * frame.h (struct frame): Likewise.
6934 * process.h (struct Lisp_Process): Likewise.
6935 * termhooks.h (struct terminal): Likewise.
6936 * window.c (struct save_window_data, struct saved_window): Likewise.
6937 * window.h (struct window): Likewise.
6938 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6939 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6940 * buffer.c (init_buffer_once): Likewise.
6941 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6943 * process.c (Fformat_network_address): Use local var for size,
6946 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6948 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6949 * data.c (atof): Remove decl; no longer used or needed.
6950 (digit_to_number): Move to lread.c.
6951 (Fstring_to_number): Use new string_to_number function, to be
6952 consistent with how the Lisp reader treats infinities and NaNs.
6953 Do not assume that floating-point numbers represent EMACS_INT
6954 without losing information; this is not true on most 64-bit hosts.
6955 Avoid double-rounding errors, by insisting on integers when
6956 parsing non-base-10 numbers, as the documentation specifies.
6957 * lisp.h (string_to_number): New decl, replacing ...
6958 (isfloat_string): Remove.
6959 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6960 (read1): Do not accept +. and -. as integers; this
6961 appears to have been a coding error. Similarly, do not accept
6962 strings like +-1e0 as floating point numbers. Do not report
6963 overflow for integer overflows unless the base is not 10 which
6964 means we have no simple and reliable way to continue.
6965 Break out the floating-point parsing into a new
6966 function string_to_number, so that Fstring_to_number parses
6967 floating point numbers consistently with the Lisp reader.
6968 (digit_to_number): Move here from data.c. Make it static inline.
6969 (E_CHAR, EXP_INT): Remove, replacing with ...
6970 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6971 (string_to_number): New function, replacing isfloat_string.
6972 This function checks for valid syntax and produces the resulting
6973 Lisp float number too. Rework it so that string-to-number
6974 no longer mishandles examples like "1.0e+". Use strtoumax,
6975 so that overflow for non-base-10 numbers is reported only when
6976 there's no portable and simple way to convert to floating point.
6978 * textprop.c (set_text_properties_1): Rewrite for clarity,
6979 and to avoid GCC warning about integer overflow.
6981 * intervals.h (struct interval): Use EMACS_INT for members
6982 where EMACS_UINT might cause problems. See
6983 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6984 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6985 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6987 (offset_intervals): Tell GCC not to worry about length overflow
6988 when negating a negative length.
6990 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6991 (overrun_check_free): Likewise.
6993 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6994 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6997 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6998 (gnutls_make_error): Rename local to avoid shadowing.
6999 (gnutls_emacs_global_deinit): ifdef out; not used.
7000 (Fgnutls_boot): Use const for pointer to readonly storage.
7001 Comment out unused local. Fix pointer signedness problems.
7003 * lread.c (openp): Don't stuff size_t into an 'int'.
7004 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7005 about possible signed overflow.
7007 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7008 (GDK_KEY_g): Don't define if already defined.
7009 (xg_prepare_tooltip): Avoid pointer signedness problem.
7010 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7012 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7013 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7015 * xfns.c (Fx_window_property): Simplify a bit,
7016 to make a bit faster and to avoid GCC 4.6.0 warning.
7017 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7019 * fns.c (internal_equal): Don't assume size_t fits in int.
7021 * alloc.c (compact_small_strings): Tighten assertion a little.
7023 Replace pEd with more-general pI, and fix some printf arg casts.
7024 * lisp.h (pI): New macro, generalizing old pEd macro to other
7025 conversion specifiers. For example, use "...%"pI"d..." rather
7026 than "...%"pEd"...".
7027 (pEd): Remove. All uses replaced with similar uses of pI.
7028 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7029 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7030 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7031 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7032 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7033 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7034 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7036 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7037 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7038 * print.c (safe_debug_print, print_object): Likewise.
7039 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7041 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7042 avoiding the 0 flag, which is not portable.
7043 * process.c (Fmake_network_process): Use pI to avoid cast.
7044 * region-cache.c (pp_cache): Likewise.
7045 * xdisp.c (decode_mode_spec): Likewise.
7046 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7047 behavior on 64-bit hosts with printf arg.
7048 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7049 (x_stop_queuing_selection_requests): Likewise.
7050 (x_get_window_property): Don't truncate byte count to an 'int'
7053 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7054 here, since it parses constructs like leading '-' and spaces,
7055 which are not wanted; and it overflows with large numbers.
7056 Instead, simply match F[0-9]+, which is what is wanted anyway.
7058 * alloc.c: Remove unportable assumptions about struct layout.
7059 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7060 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7061 (allocate_vectorlike, make_pure_vector): Use the new macros,
7062 plus offsetof, to remove unportable assumptions about struct layout.
7063 These assumptions hold on all porting targets that I know of, but
7064 they are not guaranteed, they're easy to remove, and removing them
7065 makes further changes easier.
7067 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7068 This doesn't fix a bug but makes the code clearer.
7069 (string_overrun_cookie): Now const. Use initializers that
7070 don't formally overflow signed char, to avoid warnings.
7071 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7072 can cause Emacs to crash when string overrun checking is enabled.
7073 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7074 multiple of sizeof (EMACS_INT); it need not be, if
7075 alignof(EMACS_INT) < sizeof (EMACS_INT).
7076 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7078 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7080 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7082 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7084 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7085 supposed to be handshaking. (Bug#8556)
7086 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7088 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7090 * lisp.h (Qdebug): List symbol.
7091 * eval.c (Qdebug): Restore global linkage.
7092 * keyboard.c (debug-on-event): New variable.
7093 (handle_user_signal): Break into debugger when debug-on-event
7094 matches the current signal symbol.
7096 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7098 * alloc.c (check_sblock, check_string_bytes)
7099 (check_string_free_list): Convert to standard C.
7101 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7103 * w32.c (emacs_gnutls_push): Fix typo.
7105 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7107 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7108 "cast to pointer from integer of different size".
7110 Improve doprnt and its use in verror. (Bug#8545)
7111 * doprnt.c (doprnt): Document the set of format control sequences
7112 supported by the function. Use SAFE_ALLOCA instead of always
7115 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7116 is one byte too soon. Don't use xrealloc; instead xfree and
7119 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7121 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7124 * gnutls.c: Renamed global_initialized to
7125 gnutls_global_initialized. Added internals for the
7126 :verify-hostname-error, :verify-error, and :verify-flags
7127 parameters of `gnutls-boot' and documented those parameters in the
7128 docstring. Start callback support.
7129 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7130 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7131 on error. Return error code.
7132 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7133 (emacs_gnutls_read): Likewise.
7134 (Fgnutls_boot): Return handshake error code.
7135 (emacs_gnutls_handle_error): New function.
7136 (wsaerror_to_errno): Likewise.
7138 * w32.h (emacs_gnutls_pull): Add prototype.
7139 (emacs_gnutls_push): Likewise.
7141 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7142 (emacs_gnutls_push): Likewise.
7144 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7146 * process.c (wait_reading_process_output): Check if GnuTLS
7147 buffered some data internally if no FDs are set for TLS
7150 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7151 (LIBS): Link to USER_LIBS.
7152 ($(BLD)/gnutls.$(0)): New target.
7154 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7156 * xdisp.c (handle_single_display_spec): Rename the
7157 display_replaced_before_p argument into display_replaced_p, to
7158 make it consistent with the commentary. Fix typos in the
7161 * textprop.c (syms_of_textprop): Remove dead code.
7162 (copy_text_properties): Delete obsolete commentary about an
7163 interface that was deleted long ago. Fix typos in the description
7166 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7167 to changes in oldXMenu/XMenu.h from 2011-04-16.
7168 <menu_help_message, prev_menu_help_message>: Constify.
7169 (IT_menu_make_room): menu->help_text is now `const char **';
7172 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7173 to changes in oldXMenu/XMenu.h from 2011-04-16.
7174 (struct XMenu): Declare `help_text' `const char **'.
7176 * xfaces.c <Qunspecified>: Make extern again.
7178 * syntax.c: Include sys/types.h before including regex.h, as
7181 * doc.c (get_doc_string): Improve the format passed to `error'.
7183 * doprnt.c (doprnt): Improve commentary.
7185 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7187 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7190 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7191 changes in globals.h immediately force recompilation.
7192 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7193 $(CURDIR)/s/ms-w32.h.
7194 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7196 * character.c (Fchar_direction): Function deleted.
7197 (syms_of_character): Don't defsubr it.
7198 <char-direction-table>: Deleted.
7200 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7202 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7203 * doprnt.c: Include limits.h.
7204 (SIZE_MAX): New macro.
7205 (doprnt): Return a size_t value. 2nd arg is now size_t.
7206 Many local variables are now size_t instead of int or unsigned.
7207 Improve overflow protection. Support `l' modifier for integer
7208 conversions. Support %l conversion. Don't assume an EMACS_INT
7209 argument for integer conversions and for %c.
7211 * lisp.h (doprnt): Restore prototype.
7213 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7216 * Makefile.in (base_obj): Add back doprnt.o.
7218 * deps.mk (doprnt.o): Add back prerequisites.
7219 (callint.o): Depend on character.h.
7221 * eval.c (internal_lisp_condition_case): Include the handler
7222 representation in the error message.
7223 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7224 when breaking from the loop.
7226 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7228 * callint.c (Fcall_interactively): When displaying error message
7229 about invalid control letter, pass the character's codepoint, not
7230 a pointer to its multibyte form. Improve display of the character
7231 in octal and display also its hex code.
7233 * character.c (char_string): Use %x to display the (unsigned)
7234 codepoint of an invalid character, to avoid displaying a bogus
7237 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7238 `error', not SYMBOL_NAME itself.
7240 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7241 character arguments to `error'.
7243 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7244 to `error' in error message about FINAL_CHAR argument. Make sure
7245 FINAL_CHAR is a character, and use %c when it is passed as
7246 argument to `error'.
7248 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7250 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7252 * w32.c: Include <time.h>.
7253 (sys_localtime): New function.
7255 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7257 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7259 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7261 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7263 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7266 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7268 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7269 gl_state.e_property when gl_state.object is Qt.
7271 * insdel.c (make_gap_larger): Remove limitation of buffer size
7274 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7276 * xdisp.c (lookup_glyphless_char_display)
7277 (produce_glyphless_glyph): Handle cons cell entry in
7278 glyphless-char-display.
7279 (Vglyphless_char_display): Document it.
7281 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7282 glyphless-char-display.
7284 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7286 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7288 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7290 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7291 definition for no-X builds.
7293 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7295 Static checks with GCC 4.6.0 and non-default toolkits.
7297 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7299 * process.c (keyboard_bit_set): Define only if SIGIO.
7300 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7301 (send_process): Repair possible setjmp clobbering.
7303 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7305 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7307 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7309 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7310 Define only if needed.
7312 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7313 by pacifying GCC about it. Maybe it's time to retire it?
7314 * xfaces.c (USG, __TIMEVAL__): Likewise.
7316 * dispextern.h (struct redisplay_interface): Rename param
7318 * termhooks.h (struct terminal): Likewise.
7319 * xterm.c (xembed_send_message): Likewise.
7321 * insdel.c (make_gap_smaller): Define only if
7322 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7324 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7327 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7328 so that we aren't warned about unused symbols.
7330 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7332 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7334 * xfns.c (x_real_positions): Mark locals as initialized.
7336 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7338 * xterm.c: Fix problems found by static analysis with other toolkits.
7339 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7340 (x_dispatch_event): Declare static if USE_GTK, and
7341 define if USE_GTK || USE_X_TOOLKIT.
7342 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7343 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7344 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7345 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7347 * xmenu.c (menu_help_callback): Pointer type fixes.
7348 Use const pointers when pointing at readonly data. Avoid pointer
7350 (FALSE): Remove unused macro.
7351 (update_frame_menubar): Remove unused decl.
7353 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7355 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7356 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7357 (single_menu_item): Rename local to avoid shadowing.
7359 * keyboard.c (make_lispy_event): Remove unused local var.
7361 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7362 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7364 * bitmaps: Change bitmaps from unsigned char back to the X11
7365 compatible char. Avoid the old compiler warnings about
7366 out-of-range initializers by using, for example, '\xab' rather
7369 * xgselect.c (xgselect_initialize): Check vs interface
7370 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7372 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7374 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7375 to read-only memory.
7377 * fns.c (vector): Remove; this old hack is no longer needed.
7379 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7381 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7383 * xrdb.c (x_load_resources): Omit unused local.
7385 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7386 (x_window): Rename locals to avoid shadowing.
7387 (USG): Use the kludged USG macro, to pacify gcc.
7389 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7390 (x_term_init): Remove local to avoid shadowing.
7392 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7394 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7395 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7397 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7399 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7401 Fix regex.c, syntax.c and friends for buffers > 2GB.
7402 * syntax.h (struct gl_state_s): Declare character position members
7405 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7407 * textprop.c (verify_interval_modification, interval_of):
7408 Declare arguments EMACS_INT.
7410 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7413 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7415 * indent.c (Fvertical_motion): Local variable it_start is now
7418 * regex.c (re_match, re_match_2, re_match_2_internal)
7419 (bcmp_translate, regcomp, regexec, print_double_string)
7420 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7421 (re_compile_pattern, re_exec): Declare arguments and local
7422 variables `size_t' and `ssize_t' and return values `regoff_t', as
7424 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7425 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7426 <compile_stack_type>: `size' and `avail' are now `size_t'.
7428 * regex.h <regoff_t>: Use ssize_t, not int.
7429 (re_search, re_search_2, re_match, re_match_2): Arguments that
7430 specify buffer/string position and length are now ssize_t and
7431 size_t. Return type is regoff_t.
7433 2011-04-16 Ben Key <bkey76@gmail.com>
7435 * nsfont.m: Fixed bugs in ns_get_family and
7436 ns_descriptor_to_entity that were caused by using free to
7437 deallocate memory blocks that were allocated by xmalloc (via
7438 xstrdup). This caused Emacs to crash when compiled with
7439 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7440 --enable-checking=xmallocoverrun). xfree is now used to
7441 deallocate these memory blocks.
7443 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7445 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7447 emacs_write: Accept and return EMACS_INT for sizes.
7448 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7450 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7451 Accept and return EMACS_INT.
7452 (emacs_gnutls_write): Return the number of bytes written on
7454 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7455 (emacs_read, emacs_write): Remove check for negative size, as the
7456 Emacs source code has been audited now.
7457 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7458 (emacs_read, emacs_write): Use it.
7459 * process.c (send_process): Adjust to the new signatures of
7460 emacs_write and emacs_gnutls_write. Do not attempt to store
7461 a byte offset into an 'int'; it might overflow.
7462 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7464 * sound.c: Don't assume sizes fit in 'int'.
7465 (struct sound_device.period_size, alsa_period_size):
7466 Return EMACS_INT, not int.
7467 (struct sound_device.write, vox_write, alsa_write):
7468 Accept EMACS_INT, not int.
7469 (wav_play, au_play): Use EMACS_INT to store sizes and to
7470 record read return values.
7472 2011-04-15 Ben Key <bkey76@gmail.com>
7474 * keyboard.c (Qundefined): Don't declare static since it is used
7476 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7477 static since they are used in nsfont.m.
7479 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7481 * process.c (Qprocessp): Don't declare static.
7482 * lisp.h (Qprocessp): Declare again.
7484 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7486 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7488 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7490 Improve C-level modularity by making more things 'static'.
7492 Don't publish debugger-only interfaces to other modules.
7493 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7494 (verify_bytepos, count_markers): Move decls to the only modules
7496 * region-cache.h (pp_cache): Likewise.
7497 * window.h (check_all_windows): Likewise.
7498 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7500 * sysdep.c (croak): Now static, if
7501 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7502 * syssignal.h (croak): Declare only if not static.
7504 * alloc.c (refill_memory_reserve): Now static if
7505 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7506 * lisp.h (refill_memory_reserve): Declare only if not static.
7508 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7509 Define only if USE_LUCID.
7511 * xrdb.c (x_customization_string, x_rm_string): Now static.
7513 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7514 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7516 * xdisp.c (draw_row_with_mouse_face): Now static.
7517 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7519 * window.h (check_all_windows): Mark externally visible.
7521 * window.c (window_deletion_count): Now static.
7523 * undo.c: Make symbols static if they're not exported.
7524 (last_undo_buffer, last_boundary_position, pending_boundary):
7527 * textprop.c (interval_insert_behind_hooks): Now static.
7528 (interval_insert_in_front_hooks): Likewise.
7530 * term.c: Make symbols static if they're not exported.
7531 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7532 (max_frame_lines, tty_set_terminal_modes):
7533 (tty_reset_terminal_modes, tty_turn_off_highlight):
7534 (get_tty_terminal): Now static.
7535 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7536 * termhooks.h (term_mouse_moveto): Do not declare if
7538 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7539 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7541 * sysdep.c: Make symbols static if they're not exported.
7542 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7544 (sigprocmask_set, full_mask): Remove; unused.
7545 (wait_debugging): Mark as visible.
7546 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7547 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7549 * syntax.c (syntax_temp): Define only if !__GNUC__.
7551 * sound.c (current_sound_device, current_sound): Now static.
7553 * search.c (searchbufs, searchbuf_head): Now static.
7555 * scroll.c (scroll_cost): Remove; unused.
7556 * dispextern.h (scroll_cost): Remove decl.
7558 * region-cache.h (pp_cache): Mark as externally visible.
7560 * process.c: Make symbols static if they're not exported.
7561 (process_tick, update_tick, create_process, chan_process):
7562 (Vprocess_alist, proc_buffered_char, datagram_access):
7563 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7564 (deactivate_process): Mark defn as static, as well as decl.
7565 * lisp.h (create_process): Remove decl.
7566 * process.h (chan_process, Vprocess_alist): Remove decls.
7568 * print.c: Make symbols static if they're not exported.
7569 (print_depth, new_backquote_output, being_printed, print_buffer):
7570 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7571 (print_interval, print_number_index, initial_stderr_stream):
7573 * lisp.h (Fprinc): Remove decl.
7574 (debug_output_compilation_hack): Mark as externally visible.
7576 * sysdep.c (croak): Move decl from here to syssignal.h.
7577 * syssignal.h (croak): Put it here, so the API can be checked when
7578 'croak' is called from dissociate_if_controlling_tty.
7580 * minibuf.c: Make symbols static if they're not exported.
7581 (minibuf_save_list, choose_minibuf_frame): Now static.
7582 * lisp.h (choose_minibuf_frame): Remove decl.
7584 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7586 * lread.c: Make symbols static if they're not exported.
7587 (read_objects, initial_obarray, oblookup_last_bucket_number):
7589 (make_symbol): Remove; unused.
7590 * lisp.h (initial_obarray, make_symbol): Remove decls.
7592 * keyboard.c: Make symbols static if they're not exported.
7593 (single_kboard, recent_keys_index, total_keys, recent_keys):
7594 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7595 (this_single_command_key_start, echoing, last_auto_save):
7596 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7597 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7598 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7599 (Vlispy_mouse_stem, double_click_count):
7601 (force_auto_save_soon): Define only if SIGDANGER.
7602 (ignore_mouse_drag_p): Now static if
7603 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7604 (print_help): Remove; unused.
7605 (stop_character, last_timer_event): Mark as externally visible.
7606 * keyboard.h (ignore_mouse_drag_p): Declare only if
7607 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7608 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7609 * lisp.h (echoing): Remove decl.
7610 (force_auto_save_soon): Declare only if SIGDANGER.
7611 * xdisp.c (redisplay_window): Simplify code, to make it more
7612 obvious that ignore_mouse_drag_p is not accessed if !defined
7613 USE_GTK && !defined HAVE_NS.
7615 * intervals.c: Make symbols static if they're not exported.
7616 (merge_properties_sticky, merge_interval_right, delete_interval):
7618 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7620 * insdel.c: Make symbols static if they're not exported.
7621 However, leave prepare_to_modify_buffer alone. It's never
7622 called from outside this function, but that appears to be a bug.
7623 (combine_after_change_list, combine_after_change_buffer):
7624 (adjust_after_replace, signal_before_change): Now static.
7625 (adjust_after_replace_noundo): Remove; unused.
7626 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7627 (signal_before_change): Remove decls.
7629 * indent.c (val_compute_motion, val_vmotion): Now static.
7631 * image.c: Make symbols static if they're not exported.
7632 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7634 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7635 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7637 * fringe.c (standard_bitmaps): Now static.
7638 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7640 * frame.c: Make symbols static if they're not exported.
7641 (x_report_frame_params, make_terminal_frame): Now static.
7642 (get_frame_param): Now static, unless HAVE_NS.
7643 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7644 (x_get_resource_string): Remove; not used.
7645 * frame.h (make_terminal_frame, x_report_frame_params):
7646 (x_get_resource_string); Remove decls.
7647 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7648 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7650 * font.c, fontset.c: Make symbols static if they're not exported.
7651 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7652 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7653 * font.c (font_close_object): Now static.
7654 * font.h (font_close_object): Remove.
7655 * fontset.c (FONTSET_OBJLIST): Remove.
7656 (free_realized_fontset) #if-0 the body, which does nothing.
7657 (face_suitable_for_char_p): #if-0, as it's never called.
7658 * fontset.h (face_suitable_for_char_p): Remove decl.
7659 * xfaces.c (face_at_string_position):
7660 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7661 since 0 is always ASCII.
7663 * fns.c (weak_hash_tables): Now static.
7665 * fileio.c: Make symbols static if they're not exported.
7666 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7667 (Vwrite_region_annotation_buffers): Now static.
7669 * eval.c: Make symbols static if they're not exported.
7670 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7671 * lisp.h (backtrace_list): Remove decl.
7673 * emacs.c: Make symbols static if they're not exported.
7674 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7675 (fatal_error_code, fatal_error_signal_hook, standard_args):
7677 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7678 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7679 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7680 * lisp.h (fatal_error_signal_hook): Remove decl.
7681 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7683 * editfns.c: Move a (normally-unused) function to its only use.
7684 * editfns.c, lisp.h (get_operating_system_release): Remove.
7685 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7686 worth the hassle of breaking this out.
7688 * xterm.c: Make symbols static if they're not exported.
7689 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7690 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7691 (x_destroy_window, x_delete_display):
7693 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7694 (x_mouse_leave): Remove; unused.
7695 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7696 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7697 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7699 (x_mouse_leave): Declare only if WINDOWSNT.
7700 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7701 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7704 * ftxfont.c: Make symbols static if they're not exported.
7705 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7707 * font.h (ftxfont_driver): Likewise.
7709 * xfns.c: Make symbols static if they're not exported.
7710 (x_last_font_name, x_display_info_for_name):
7711 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7712 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7713 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7714 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7715 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7716 (last_show_tip_args): Now static.
7717 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7718 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7719 (x_screen_planes): Remove; unused.
7720 * dispextern.h (x_screen_planes): Remove decl.
7722 * dispnew.c: Make symbols static if they're not exported.
7723 * dispextern.h (redraw_garbaged_frames, scrolling):
7724 (increment_row_positions): Remove.
7725 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7726 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7728 (redraw_garbaged_frames): Remove; unused.
7730 * xfaces.c: Make symbols static if they're not exported.
7731 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7733 * xterm.h (defined_color): Remove decls.
7734 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7735 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7736 (menu_face_changed_default, defined_color, free_realized_face):
7737 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7738 (ascii_face_of_lisp_face): Remove; unused.
7740 * xdisp.c: Make symbols static if they're not exported.
7741 * dispextern.h (scratch_glyph_row, window_box_edges):
7742 (glyph_to_pixel_coords, set_cursor_from_row):
7743 (get_next_display_element, set_iterator_to_next):
7744 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7745 (show_mouse_face): Remove decls
7746 * frame.h (message_buf_print): Likewise.
7747 * lisp.h (pop_message, set_message, check_point_in_composition):
7749 * xterm.h (set_vertical_scroll_bar): Likewise.
7750 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7751 (message_buf_print, scratch_glyph_row, displayed_buffer):
7752 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7753 (get_next_display_element, show_mouse_face, window_box_edges):
7754 (frame_to_window_pixel_xy, check_point_in_composition):
7755 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7756 (glyph_to_pixel_coords): Remove; unused.
7758 * dired.c (file_name_completion): Now static.
7760 * dbusbind.c (xd_in_read_queued_messages): Now static.
7762 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7763 * data.c (circular_list_error): Remove.
7765 * commands.h (last_point_position, last_point_position_buffer):
7766 (last_point_position_window): Remove decls.
7767 * keyboard.c: Make these variables static.
7769 * coding.h (coding, code_convert_region, encode_coding_gap):
7771 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7772 (iso_code_class, detect_coding, code_convert_region): Now static.
7773 (encode_coding_gap): Remove; unused.
7775 * chartab.c (chartab_chars, chartab_bits): Now static.
7777 * charset.h (charset_iso_8859_1): Remove decl.
7778 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7781 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7782 * ccl.c (Vccl_program_table): Now static.
7783 (check_ccl_update): Remove; unused.
7785 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7786 * category.h: ... from here.
7787 * category.c (check_category_table, set_category_set): Now static.
7789 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7790 * lisp.h: Remove these decls.
7792 * buffer.c (buffer_count): Remove unused var.
7794 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7795 so that it's not optimized away.
7796 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7797 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7798 exported only to the debugger.
7800 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7801 * atimer.h (run_all_atimers): Remove; not exported.
7803 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7804 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7805 was inaccessible from Lisp.
7806 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7807 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7809 alloc.c: Import and export fewer symbols, and remove unused items.
7810 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7812 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7813 it's not optimized away by whole-program optimization.
7814 (message_enable_multibyte, free_misc): Remove.
7815 (catchlist, handlerlist, mark_backtrace):
7816 Declare only if BYTE_MARK_STACK.
7817 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7818 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7819 (message_enable_multibyte): Remove decl.
7820 (free_misc, interval_free_list, float_block, float_block_index):
7821 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7822 (cons_free_list, last_marked_index):
7824 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7825 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7826 (mark_backtrace): Define only if BYTE_MARK_STACK.
7827 * xdisp.c (message_enable_multibyte): Now static.
7829 Declare Lisp_Object Q* variables to be 'static' if not exported.
7830 This makes it easier for human readers (and static analyzers)
7831 to see whether these variables are used from other modules.
7832 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7833 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7834 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7835 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7836 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7837 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7838 * xmenu.c, xselect.c:
7839 Declare Q* vars static if they are not used in other modules.
7840 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7841 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7842 Remove decls of unexported vars.
7843 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7845 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7847 Make Emacs functions such as Fatom 'static' by default.
7848 This makes it easier for human readers (and static analyzers)
7849 to see whether these functions can be called from other modules.
7850 DEFUN now defines a static function. To make the function external
7851 so that it can be used in other C modules, use the new macro DEFUE.
7852 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7853 (Finit_image_library):
7854 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7855 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7856 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7857 Remove decls, since these functions are now static.
7858 (Funintern, Fget_internal_run_time): New decls, since these functions
7859 were already external.
7861 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7862 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7863 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7864 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7865 * keyboard.c, keymap.c, lread.c:
7866 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7867 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7868 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7869 Mark functions with DEFUE instead of DEFUN,
7870 if they are used in other modules.
7871 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7872 decls for now-static functions.
7873 * buffer.h (Fdelete_overlay): Remove decl.
7874 * callproc.c (Fgetenv_internal): Mark as internal.
7875 * composite.c (Fremove_list_of_text_properties): Remove decl.
7876 (Fcomposition_get_gstring): New forward static decl.
7877 * composite.h (Fcomposite_get_gstring): Remove decl.
7878 * dired.c (Ffile_attributes): New forward static decl.
7879 * doc.c (Fdocumntation_property): New forward static decl.
7880 * eval.c (Ffetch_bytecode): New forward static decl.
7881 (Funintern): Remove extern decl; now in .h file where it belongs.
7882 * fileio.c (Fmake_symbolic_link): New forward static decl.
7883 * image.c (Finit_image_library): New forward static decl.
7884 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7885 * intervals.h (Fprevious_property_change):
7886 (Fremove_list_of_text_properties): Remove decls.
7887 * keyboard.c (Fthis_command_keys): Remove decl.
7888 (Fcommand_execute): New forward static decl.
7889 * keymap.c (Flookup_key): New forward static decl.
7890 (Fcopy_keymap): Now static.
7891 * keymap.h (Flookup_key): Remove decl.
7892 * process.c (Fget_process): New forward static decl.
7893 (Fprocess_datagram_address): Mark as internal.
7894 * syntax.c (Fsyntax_table_p): New forward static decl.
7895 (skip_chars): Remove duplicate decl.
7896 * textprop.c (Fprevious_property_change): New forward static decl.
7897 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7899 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7900 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7902 * editfns.c (Fformat): Remove unreachable code.
7904 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7906 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7909 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7911 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7912 when at ZV. (Bug#8487)
7914 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7916 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7918 * keyboard.c (parse_tool_bar_item): Likewise.
7919 * sound.c (sound_cleanup, alsa_close): Likewise.
7920 * termcap.c (tgetent): Likewise.
7921 * xfns.c (x_default_font_parameter): Likewise.
7922 * xsettings.c (read_and_apply_settings): Likewise.
7924 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7925 (overrun_check_free): Protoize.
7927 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7929 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7930 since callers should never pass a negative size.
7931 Change the signature to match that of plain 'read' and 'write'; see
7932 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7933 * lisp.h: Update prototypes of emacs_write and emacs_read.
7935 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7937 * xdisp.c (redisplay_window): Don't try to determine the character
7938 position of the scroll margin if the window start point w->startp
7939 is outside the buffer's accessible region. (Bug#8468)
7941 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7943 Fix write-region and its subroutines for buffers > 2GB.
7944 * fileio.c (a_write, e_write): Modify declaration of arguments and
7945 local variables to support buffers larger than 2GB.
7946 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7948 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7949 argument, local variables, and return value.
7951 * lisp.h: Update prototypes of emacs_write and emacs_read.
7953 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7955 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7957 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7959 Fix more problems found by GCC 4.6.0's static checks.
7961 * xdisp.c (vmessage): Use a better test for character truncation.
7963 * charset.c (load_charset_map): <, not <=, for optimization,
7964 and to avoid potential problems with integer overflow.
7965 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7966 * casetab.c (set_identity, shuffle): Likewise.
7967 * editfns.c (Fformat): Likewise.
7968 * syntax.c (skip_chars): Likewise.
7970 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7971 This also lets GCC 4.6.0 generate slightly better loop code.
7973 * callint.c (Fcall_interactively): <, not <=, for optimization.
7974 (Fcall_interactively): Count the number of arguments produced,
7975 not the number of arguments given. This is simpler and lets GCC
7976 4.6.0 generate slightly better code.
7978 * ftfont.c: Distingish more carefully between FcChar8 and char.
7979 The previous code passed unsigned char * to a functions like
7980 strlen and xstrcasecmp that expect char *, which does not
7981 conform to the C standard.
7982 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7983 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7984 char * when the C standard requires it.
7986 * keyboard.c (read_char): Remove unused var.
7988 * eval.c: Port to Windows vsnprintf (Bug#8435).
7990 (SIZE_MAX): Define if the headers do not.
7991 (verror): Do not give up if vsnprintf returns a negative count.
7992 Instead, grow the buffer. This ports to Windows vsnprintf, which
7993 does not conform to C99. Problem reported by Eli Zaretskii.
7994 Also, simplify the allocation scheme, by avoiding the need for
7995 calling realloc, and removing the ALLOCATED variable.
7997 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7999 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8000 But keep the doprint source code for now, as we might revamp it
8001 and use it again (Bug#8435).
8002 * lisp.h (doprnt): Remove.
8003 * Makefile.in (base_obj): Remove doprnt.o.
8004 * deps.mk (doprnt.o): Remove.
8006 error: Print 32- and 64-bit integers portably (Bug#8435).
8007 Without this change, on typical 64-bit hosts error ("...%d...", N)
8008 was used to print both 32- and 64-bit integers N, which relied on
8010 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8011 * lisp.h (error, verror): Mark as printf-like functions.
8012 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8013 Report overflow in size calculations when allocating printf buffer.
8014 Do not truncate output string at its first null byte.
8015 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8016 Truncate the output at a character boundary, since vsnprintf does not
8018 * charset.c (check_iso_charset_parameter): Convert internal
8019 character to string before calling 'error', since %c now has the
8021 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8022 overflow when computing char to be passed to 'error'. Do not
8023 pass Lisp_Object to 'error'; pass the integer instead.
8024 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8025 formatted with plain %d.
8027 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8029 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8031 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8033 * xterm.c (x_catch_errors): Remove duplicate declaration.
8035 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8037 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8039 2011-04-10 Jim Meyering <meyering@redhat.com>
8041 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8042 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8043 return ssize_t not "int", and use size_t as the buffer length.
8044 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8045 * gnutls.h: Update declarations.
8046 * process.c (read_process_output): Use ssize_t, to match.
8047 (send_process): Likewise.
8049 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8051 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8053 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8055 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8056 Use unsigned char, to match FcChar8 type definition.
8058 * xterm.c (handle_one_xevent):
8059 * xmenu.c (create_and_show_popup_menu):
8060 * xselect.c (x_decline_selection_request)
8061 (x_reply_selection_request): Avoid type-punned deref of X events.
8063 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8065 Fix some uses of `int' instead of EMACS_INT.
8066 * search.c (string_match_1, fast_string_match)
8067 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8068 (scan_buffer, find_next_newline_no_quit)
8069 (find_before_next_newline, search_command, Freplace_match)
8070 (Fmatch_data): Make some `int' variables be EMACS_INT.
8072 * xdisp.c (display_count_lines): 3rd argument and return value now
8073 EMACS_INT. All callers changed.
8074 (pint2hrstr): Last argument is now EMACS_INT.
8076 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8077 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8078 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8079 (decode_coding_utf_16, decode_coding_emacs_mule)
8080 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8081 (decode_coding_ccl, decode_coding_charset)
8082 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8083 (decode_coding_iso_2022, decode_coding_emacs_mule)
8084 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8085 <char_offset, last_offset>: Declare EMACS_INT.
8086 (encode_coding_utf_8, encode_coding_utf_16)
8087 (encode_coding_emacs_mule, encode_invocation_designation)
8088 (encode_designation_at_bol, encode_coding_iso_2022)
8089 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8090 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8092 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8093 (encode_invocation_designation): Last argument P_NCHARS is now
8095 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8096 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8098 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8101 * ccl.c (Fccl_execute_on_string): Declare some variables
8104 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8106 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8108 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8110 * process.c (Fformat_network_address): Doc fix.
8112 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8114 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8116 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8118 * keyboard.c (read_char): Call Lisp function help-form-show,
8119 instead of using internal_with_output_to_temp_buffer.
8120 (Qhelp_form_show): New var.
8121 (syms_of_keyboard): Use DEFSYM macro.
8123 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8125 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8127 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8129 * process.c (Flist_processes): Remove to Lisp.
8130 (list_processes_1): Delete.
8132 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8134 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8136 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8138 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8140 Fix more problems found by GCC 4.6.0's static checks.
8142 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8144 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8146 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8148 * xdisp.c (vmessage): Mark as a printf-like function.
8150 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8152 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8154 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8155 printf-like functions.
8156 (tiff_load): Add casts to remove these marks before passing them
8157 to system-supplied API.
8159 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8161 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8162 This avoids several warnings with gcc -Wstrict-overflow.
8163 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8164 directly, rather than having caller test rule sign. This avoids
8165 some unnecessary tests.
8166 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8167 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8168 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8170 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8171 (xfont_open): Avoid unnecessary tests.
8173 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8175 * composite.h, composite.c (composition_gstring_put_cache):
8176 Use EMACS_INT, not int, for length.
8178 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8179 breaking out part of COMPOSITION_DECODE_RULE.
8180 (COMPOSITION_DECODE_RULE): Use it.
8181 * composite.c (get_composition_id): Remove unused local vars,
8182 by using the new macro.
8184 * textprop.c (set_text_properties_1): Change while to do-while,
8185 since the condition is always true at first.
8187 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8188 (interval_deletion_adjustment): Return unsigned value.
8191 * process.c (list_processes_1, create_pty, read_process_output):
8192 (exec_sentinel): Remove vars that were set but not used.
8193 (create_pty): Remove unnecessary "volatile"s.
8194 (Fnetwork_interface_info): Avoid possibility of int overflow.
8195 (read_process_output): Do adaptive read buffering even if carryover.
8196 (read_process_output): Simplify nbytes computation if buffered.
8198 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8200 * syntax.c (scan_words): Remove var that was set but not used.
8201 (update_syntax_table): Use unsigned instead of int.
8203 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8204 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8205 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8207 * print.c (print_error_message): Avoid int overflow.
8209 * font.c (font_list_entities): Redo for clarity,
8210 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8212 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8213 (font_score): Avoid potential overflow in diff calculation.
8215 * fns.c (substring_both): Remove var that is set but not used.
8216 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8218 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8220 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8221 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8222 can always succeed if overflow has undefined behavior.
8224 * search.c (boyer_moore, wordify): Remove vars set but not used.
8225 (wordify): Omit three unnecessary tests.
8227 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8228 All callers changed. This avoids the need for an unused var.
8230 * casefiddle.c (casify_region): Remove var that is set but not used.
8232 * dired.c (file_name_completion): Remove var that is set but not used.
8234 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8236 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8237 (Finsert_file_contents): Remove unnecessary code checking fd.
8239 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8240 Check for integer overflow on size calculations.
8242 * buffer.c (Fprevious_overlay_change): Remove var that is set
8245 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8246 Remove vars that are set but not used.
8247 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8248 (timer_check_2): Mark vars as initialized.
8250 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8252 * image.c (lookup_image): Remove var that is set but not used.
8253 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8255 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8256 that are set but not used.
8258 * xfns.c (make_invisible_cursor): Don't return garbage
8259 if XCreateBitmapFromData fails (Bug#8410).
8261 * xselect.c (x_get_local_selection, x_handle_property_notify):
8262 Remove vars that are set but not used.
8264 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8265 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8267 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8268 Remove var that is set but not used.
8269 (scroll_bar_windows_size): Now size_t, not int.
8270 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8273 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8274 (map_tty_color) [!defined MSDOS]: Likewise.
8276 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8278 * coding.c: Remove vars that are set but not used.
8279 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8280 All callers changed.
8281 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8282 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8283 (decode_coding_charset): Remove vars that are set but not used.
8285 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8286 that is set but not used.
8288 * print.c (print_object): Remove var that is set but not used.
8290 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8291 The gnulib version avoids calling malloc in the usual case,
8292 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8293 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8294 * filelock.c (current_lock_owner): Likewise.
8295 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8296 * sysdep.c: Include allocator.h, careadlinkat.h.
8297 (emacs_no_realloc_allocator): New static constant.
8298 (emacs_readlink): New function.
8299 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8300 ../lib/careadlinkat.h.
8302 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8304 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8305 first non-nil return value).
8307 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8309 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8310 if not defined (Bug#8403).
8312 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8314 * xdisp.c (display_count_lines): Remove parameter `start',
8315 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8316 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8317 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8318 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8319 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8320 and thereabouts. All callers changed.
8321 (get_per_char_metric): Remove parameter `f', unused since
8322 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8324 2011-04-02 Jim Meyering <meyering@redhat.com>
8326 do not dereference NULL upon failed strdup
8327 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8328 (ns_get_family): Likewise.
8330 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8332 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8334 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8336 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8339 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8341 Add lexical binding.
8343 * window.c (Ftemp_output_buffer_show): New fun.
8344 (Fsave_window_excursion):
8345 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8347 * lread.c (lisp_file_lexically_bound_p): New function.
8348 (Fload): Bind Qlexical_binding.
8349 (readevalloop): Remove `evalfun' arg.
8350 Bind Qinternal_interpreter_environment.
8351 (Feval_buffer): Bind Qlexical_binding.
8352 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8354 (syms_of_lread): Declare `lexical-binding'.
8356 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8358 * keyboard.c (eval_dyn): New fun.
8359 (menu_item_eval_property): Use it.
8361 * image.c (parse_image_spec): Use Ffunctionp.
8363 * fns.c (concat, mapcar1): Accept byte-code-functions.
8365 * eval.c (Fsetq): Handle lexical vars.
8366 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8367 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8368 (FletX, Flet): Obey lexical binding.
8369 (Fcommandp): Handle closures.
8370 (Feval): New `lexical' arg.
8371 (eval_sub): New function extracted from Feval. Use it almost
8372 everywhere where Feval was used. Look up vars in lexical env.
8374 (Ffunctionp): Move from subr.el.
8375 (Ffuncall): Handle closures.
8376 (apply_lambda): Remove `eval_flags'.
8377 (funcall_lambda): Handle closures and new byte-code-functions.
8378 (Fspecial_variable_p): New function.
8379 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8380 but without exporting it to Lisp.
8382 * doc.c (Fdocumentation, store_function_docstring):
8383 * data.c (Finteractive_form): Handle closures.
8385 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8388 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8390 (exec_byte_code): New function extracted from Fbyte_code to handle new
8391 calling convention for byte-code-functions. Add new byte-codes.
8393 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8395 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8397 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8399 * xdisp.c (redisplay_internal): Fix prototype.
8401 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8403 * xdisp.c (SCROLL_LIMIT): New macro.
8404 (try_scrolling): Use it when setting scroll_limit.
8405 Limit scrolling to 100 screen lines.
8406 (redisplay_window): Even when falling back on "recentering",
8407 position point in the window according to scroll-conservatively,
8408 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8410 (try_scrolling): When point is above the window, allow searching
8411 as far as scroll_max, or one screenful, to compute vertical
8412 distance from PT to the scroll margin position. This prevents
8413 try_scrolling from unnecessarily failing when
8414 scroll-conservatively is set to a value slightly larger than the
8415 window height. Clean up the case of PT below the margin at bottom
8416 of window: scroll_max can no longer be INT_MAX. When aggressive
8417 scrolling is in use, don't let point enter the opposite scroll
8418 margin as result of the scroll.
8419 (syms_of_xdisp) <scroll-conservatively>: Document the
8420 threshold of 100 lines for never-recentering scrolling.
8422 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8424 * dispextern.h (move_it_by_lines):
8425 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8426 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8427 (message_log_check_duplicate): Remove parameters `prev_bol' and
8428 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8429 (redisplay_internal): Remove parameter `preserve_echo_area',
8430 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8432 * indent.c (Fvertical_motion):
8433 * window.c (window_scroll_pixel_based, Frecenter):
8434 Don't pass `need_y_p' to `move_it_by_lines'.
8436 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8438 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8439 steal a few bits to be more compact.
8440 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8441 Remove unneeded casts.
8443 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8445 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8447 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8448 binding" message (bug#7967).
8450 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8452 Fix more problems found by GCC 4.6.0's static checks.
8454 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8455 Remove unused local var.
8457 * editfns.c (Fmessage_box): Remove unused local var.
8459 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8460 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8461 Omit unused local vars.
8462 * window.c (shrink_windows): Omit unused local var.
8463 * menu.c (digest_single_submenu): Omit unused local var.
8464 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8465 Omit unused local var.
8467 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8468 Don't assume string length fits in int.
8469 (keyremap_step, read_key_sequence): Use size_t for sizes.
8470 (read_key_sequence): Don't check last_real_key_start redundantly.
8472 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8473 instead of alloca (Bug#8344).
8475 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8476 (Fbacktrace_frame): Don't assume nframes fits in int.
8478 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8480 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8483 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8485 * cm.c (calccost): Turn while-do into do-while, for clarity.
8487 * keyboard.c (syms_of_keyboard): Use the same style as later
8488 in this function when indexing through an array. This also
8489 works around GCC bug 48267.
8491 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8493 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8495 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8496 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8498 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8499 This avoids undefined behavior on integer overflow, and is a bit
8500 more convenient anyway since it is compared to a size_t variable.
8502 Variadic C functions now count arguments with size_t, not int.
8503 This avoids an unnecessary limitation on 64-bit machines, which
8504 caused (substring ...) to crash on large vectors (Bug#8344).
8505 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8506 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8507 All variadic functions and their callers changed accordingly.
8508 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8509 * data.c (arith_driver, float_arith_driver): Likewise.
8510 * editfns.c (general_insert_function): Likewise.
8511 * eval.c (struct backtrace.nargs, interactive_p)
8512 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8513 (funcall_lambda, mark_backtrace): Likewise.
8514 * fns.c (concat): Likewise.
8515 * frame.c (x_set_frame_parameters): Likewise.
8516 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8517 0 if not found, not -1. All callers changed.
8519 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8520 (stack_copy_size): Now size_t, not int.
8521 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8523 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8525 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8526 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8527 All callers changed.
8529 * lisp.h (multibyte_char_to_unibyte):
8530 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8531 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8532 * character.h (CHAR_TO_BYTE8):
8533 * cmds.c (internal_self_insert):
8534 * editfns.c (general_insert_function):
8535 * keymap.c (push_key_description):
8536 * search.c (Freplace_match):
8537 * xdisp.c (message_dolog, set_message_1): All callers changed.
8539 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8541 * keyboard.c (safe_run_hook_funcall): New function.
8542 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8543 don't set the hook to nil, but remove the offending function instead.
8544 (Qcommand_hook_internal): Remove, unused.
8545 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8546 Vcommand_hook_internal.
8548 * eval.c (enum run_hooks_condition): Remove.
8549 (funcall_nil, funcall_not): New functions.
8550 (run_hook_with_args): Call each function through a `funcall' argument.
8551 Remove `cond' argument, now redundant.
8552 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8553 (Frun_hook_with_args_until_failure): Adjust accordingly.
8554 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8556 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8558 * dispextern.h (string_buffer_position): Remove declaration.
8560 * print.c (strout): Remove parameter `multibyte', unused since
8561 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8563 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8564 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8565 All callers changed.
8567 * w32.c (_wsa_errlist): Use braces for struct initializers.
8569 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8570 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8571 All callers changed.
8572 (string_buffer_position): Likewise. Also, make static (it's never
8573 used outside xdisp.c).
8574 (cursor_row_p): Remove parameter `w', unused since
8575 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8576 (decode_mode_spec): Remove parameter `precision', introduced during
8577 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8578 All callers changed.
8580 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8582 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8584 2011-03-27 Anders Lindgren <andlind@gmail.com>
8586 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8587 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8588 (ns_update_auto_hide_menu_bar): New functions.
8589 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8590 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8591 ns_constrain_all_frames.
8592 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8593 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8595 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8597 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8599 2011-03-27 Glenn Morris <rgm@gnu.org>
8601 * syssignal.h: Replace RETSIGTYPE with void.
8602 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8603 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8604 Replace SIGTYPE with void everywhere.
8605 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8606 * s/template.h (SIGTYPE): Remove commented out definition.
8608 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8610 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8611 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8613 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8615 * w32.c (read_unc_volume): Use parameter `henum', instead of
8616 global variable `wget_enum_handle'.
8618 * keymap.c (describe_vector): Remove parameters `indices' and
8619 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8620 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8622 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8624 * keyboard.c (timer_check): Remove parameter `do_it_now',
8625 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8626 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8627 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8629 * keyboard.c (read_char):
8630 * w32menu.c (w32_menu_display_help):
8631 * xmenu.c (show_help_event, menu_help_callback):
8632 Adjust calls to `show_help_echo'.
8634 * gtkutil.c (xg_maybe_add_timer):
8635 * keyboard.c (readable_events):
8636 * process.c (wait_reading_process_output):
8637 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8639 * insdel.c (adjust_markers_gap_motion):
8640 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8641 (gap_left, gap_right): Don't call it.
8643 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8645 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8646 incurred during fontification.
8648 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8650 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8651 (DEFVAR_PER_BUFFER): Don't pass it.
8653 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8654 (scrolling_window): Don't pass it.
8656 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8658 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8660 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8662 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8663 of variables specific to SELinux and computation of `encoded_absname'.
8665 * image.c (XPutPixel): Remove unused variable `height'.
8667 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8669 * unexw32.c (get_section_info): Remove unused variable `section'.
8671 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8672 (system_process_attributes): Remove unused variable `sess'.
8673 (sys_read): Remove unused variable `err'.
8675 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8676 (w32_wnd_proc): Remove unused variable `isdead'.
8677 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8678 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8679 (x_create_tip_frame): Remove unused variable `tem'.
8681 * w32inevt.c (w32_console_read_socket):
8682 Remove unused variable `no_events'.
8684 * w32term.c (x_draw_composite_glyph_string_foreground):
8685 Remove unused variable `width'.
8687 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8689 * w32term.c (x_set_glyph_string_clipping):
8690 Don't pass uninitialized region to CombineRgn.
8692 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8694 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8695 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8696 (Fx_close_connection): Remove unused variable `i'.
8698 * w32font.c (w32font_draw): Return number of glyphs.
8699 (w32font_open_internal): Remove unused variable `i'.
8700 (w32font_driver): Add missing initializer.
8702 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8703 (fill_in_menu): Remove unused variable `items_added'.
8705 * w32term.c (last_mouse_press_frame): Remove static global variable.
8706 (w32_clip_to_row): Remove unused variable `f'.
8707 (x_delete_terminal): Remove unused variable `i'.
8709 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8710 (NOTHING): Remove unused static global variable.
8711 (uniscribe_check_otf): Remove unused variable `table'.
8712 (uniscribe_font_driver): Add missing initializers.
8714 2011-03-23 Julien Danjou <julien@danjou.info>
8716 * term.c (Fsuspend_tty, Fresume_tty):
8717 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8718 * window.c (temp_output_buffer_show):
8719 * insdel.c (signal_before_change):
8720 * frame.c (Fhandle_switch_frame):
8721 * fileio.c (Fdo_auto_save):
8722 * emacs.c (Fkill_emacs):
8723 * editfns.c (save_excursion_restore):
8724 * cmds.c (internal_self_insert):
8725 * callint.c (Fcall_interactively):
8726 * buffer.c (Fkill_all_local_variables):
8727 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8729 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8730 unconditionally since it does the check itself.
8732 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8734 Fix more problems found by GCC 4.5.2's static checks.
8736 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8737 the first time through the loop, since we know p0 < p1 then.
8738 This also avoids a gcc -Wstrict-overflow warning.
8740 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8741 leading to a memory leak, possible in functions like
8742 load_charset_map_from_file that can allocate an unbounded number
8743 of objects (Bug#8318).
8745 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8746 that could (at least in theory) be that large.
8748 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8749 This is less likely to overflow, and avoids undefined behavior if
8750 overflow does occur. All callers changed. Use strtoul to scan
8751 for the unsigned long integer.
8752 (pint2hrstr): Simplify and tune code slightly.
8753 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8755 * scroll.c (do_scrolling): Work around GCC bug 48228.
8756 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8758 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8759 This also avoids a warning with gcc -Wstrict-overflow.
8760 (validate_x_resource_name): Simplify count usage.
8761 This also avoids a warning with gcc -Wstrict-overflow.
8763 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8766 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8768 * process.c (Fmake_network_process): Use socklen_t, not int,
8769 where POSIX says socklen_t is required in portable programs.
8770 This fixes a porting bug on hosts like 64-bit HP-UX, where
8771 socklen_t is wider than int (Bug#8277).
8772 (Fmake_network_process, server_accept_connection):
8773 (wait_reading_process_output, read_process_output):
8776 * process.c: Rename or move locals to avoid shadowing.
8777 (list_processes_1, Fmake_network_process):
8778 (read_process_output_error_handler, exec_sentinel_error_handler):
8779 Rename or move locals.
8780 (Fmake_network_process): Define label "retry_connect" only if needed.
8781 (Fnetwork_interface_info): Fix pointer signedness.
8782 (process_send_signal): Add cast to avoid pointer signedness problem.
8783 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8784 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8786 Make tparam.h and terminfo.c consistent.
8787 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8788 Include tparam.h instead, since it declares them.
8789 * cm.h (PC): Remove extern decl; tparam.h now does this.
8790 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8791 * terminfo.c: Include tparam.h, to check interfaces.
8792 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8793 (tparam): Adjust signature to match interface in tparam.h;
8794 this removes some undefined behavior. Check that outstring and len
8795 are zero, which they always are with Emacs.
8796 * tparam.h (PC, BC, UP): New extern decls.
8798 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8799 (xftfont_open): Rename locals to avoid shadowing.
8801 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8802 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8803 (OTF_TAG_SYM): Omit macro if not needed.
8804 (ftfont_list): Remove unused local.
8805 (get_adstyle_property, ftfont_pattern_entity):
8806 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8807 Rename locals to avoid shadowing.
8809 * xfont.c (xfont_list_family): Mark var as initialized.
8811 * xml.c (make_dom): Now static.
8813 * composite.c (composition_compute_stop_pos): Rename local to
8815 (composition_reseat_it): Remove unused locals.
8816 (find_automatic_composition, composition_adjust_point): Likewise.
8817 (composition_update_it): Mark var as initialized.
8818 (find_automatic_composition): Mark vars as initialized,
8819 with a FIXME (Bug#8290).
8821 character.h: Rename locals to avoid shadowing.
8822 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8823 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8824 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8825 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8828 * textprop.c (property_change_between_p): Remove; unused.
8830 * intervals.c (interval_start_pos): Now static.
8832 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8834 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8835 Rename locals to avoid shadowing.
8837 * sound.c (wav_play, au_play, Fplay_sound_internal):
8838 Fix pointer signedness.
8839 (alsa_choose_format): Remove unused local var.
8840 (wav_play): Initialize a variable to 0, to prevent undefined
8841 behavior (Bug#8278).
8843 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8845 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8847 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8848 clobbering (Bug#8298).
8849 * sysdep.c (sys_subshell): Likewise.
8850 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8852 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8853 This should get cleaned up, so that child_setup has the
8854 same signature on all platforms.
8856 * callproc.c (call_process_cleanup): Now static.
8857 (relocate_fd): Rename locals to avoid shadowing.
8859 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8861 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8862 not to be necessary, and produces flickering.
8864 2011-03-20 Glenn Morris <rgm@gnu.org>
8866 * config.in: Remove file.
8868 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8870 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8871 are now in src/globals.h.
8872 (syms_of_minibuf): Remove spurious & from previous change.
8874 2011-03-20 Leo Liu <sdl.web@gmail.com>
8876 * minibuf.c (completing-read-function): New variable.
8877 (completing-read-default): Rename from completing-read.
8878 (completing-read): Call completing-read-function.
8880 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8882 * xfaces.c (Fx_load_color_file):
8883 Read color file from absolute filename (bug#8250).
8885 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8887 * makefile.w32-in: Update dependencies.
8889 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8891 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8893 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8895 Fix more problems found by GCC 4.5.2's static checks.
8897 * process.c (make_serial_process_unwind, send_process_trap):
8898 (sigchld_handler): Now static.
8900 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8901 That way, the code declares only the vars that it needs.
8902 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8903 * s/cygwin.h (PTY_ITERATION): Likewise.
8904 * s/darwin.h (PTY_ITERATION): Likewise.
8905 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8907 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8908 * process.c (allocate_pty): Don't declare stb unless it's needed.
8910 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8911 (CONSTANTLIM): Remove; unused.
8912 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8913 Define only if needed.
8915 * unexelf.c (unexec): Name an expression,
8916 to avoid gcc -Wbad-function-cast warning.
8917 Use a different way to cause a compilation error if anyone uses
8918 n rather than nn, a way that does not involve shadowing.
8919 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8921 * deps.mk (unexalpha.o): Remove; unused.
8923 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8924 * unexec.h: New file.
8925 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8926 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8928 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8929 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8930 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8931 Change as necessary to match prototype in unexec.h.
8933 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8935 (back_comment, skip_chars): Mark vars as initialized.
8937 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8938 Rename locals to avoid shadowing.
8940 * lread.c (read1): Rewrite so as not to use empty "else".
8941 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8943 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8945 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8946 warning when compiling print.c.
8948 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8949 instead of using an uninitialized var.
8950 (font_sort_entities): Mark var as initialized.
8952 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8954 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8955 pointers to constants.
8956 (font_parse_fcname): Remove unused vars.
8957 (font_delete_unmatched): Now static.
8958 (font_get_spec): Remove; unused.
8959 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8960 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8961 Rename or move locals to avoid shadowing.
8963 * fns.c (require_nesting_list, require_unwind): Now static.
8964 (Ffillarray): Rename locals to avoid shadowing.
8966 * floatfns.c (domain_error2): Define only if needed.
8967 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8969 * alloc.c (mark_backtrace): Move decl from here ...
8970 * lisp.h: ... to here, so that it can be checked.
8972 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8973 (Fdefvar): Rewrite so as not to use empty "else".
8974 (lisp_indirect_variable): Name an expression,
8975 to avoid gcc -Wbad-function-cast warning.
8976 (Fdefvar): Rename locals to avoid shadowing.
8978 * callint.c (quotify_arg, quotify_args): Now static.
8979 (Fcall_interactively): Rename locals to avoid shadowing.
8980 Use const pointer when appropriate.
8982 * lisp.h (get_system_name, get_operating_system_release):
8983 Move decls here, to check interfaces.
8984 * process.c (get_operating_system_release): Move decl to lisp.h.
8985 * xrdb.c (get_system_name): Likewise.
8986 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8987 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8988 some of which prompt warnings from gcc -Wbad-function-cast.
8989 (Fformat_time_string, Fencode_time, Finsert_char):
8990 (Ftranslate_region_internal, Fformat):
8991 Rename or remove local vars to avoid shadowing.
8992 (Ftranslate_region_internal): Mark var as initialized.
8994 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8997 * lisp.h (eassert): Check that the argument compiles, even if
8998 ENABLE_CHECKING is not defined.
9000 * data.c (Findirect_variable): Name an expression, to avoid
9001 gcc -Wbad-function-cast warning.
9002 (default_value, arithcompare, arith_driver, arith_error): Now static.
9003 (store_symval_forwarding): Rename local to avoid shadowing.
9004 (Fmake_variable_buffer_local, Fmake_local_variable):
9005 Mark variables as initialized.
9006 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9008 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9009 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9010 Rename locals to avoid shadowing.
9011 (mark_stack): Move local variables into the #ifdef region where
9013 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9014 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9016 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9017 (GC_STRING_CHARS): Remove; not used.
9018 (Fmemory_limit): Cast sbrk's returned value to char *.
9020 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9021 avoids undefined behavior in theory.
9023 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9025 Use functions, not macros, for up- and down-casing (Bug#8254).
9026 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9027 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9028 to use the following functions instead of these macros.
9029 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9030 EMACS_INT, since callers assume the returned value fits in int.
9031 (upcase1): Likewise, for UPCASE_TABLE.
9032 (uppercasep, lowercasep, upcase): New static inline functions.
9033 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9034 the race-condition problem in the old DOWNCASE.
9036 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9037 Rename locals to avoid shadowing.
9038 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9039 (regex_compile, re_search_2, re_match_2_internal):
9040 Remove unused local vars.
9041 (FREE_VAR): Rewrite so as not to use empty "else",
9042 which gcc can warn about.
9043 (regex_compile, re_match_2_internal): Mark locals as initialized.
9044 (RETALLOC_IF): Define only if needed.
9045 (WORDCHAR_P): Likewise. This one is never needed, but is used
9046 only in a comment talking about a compiler bug, so put inside
9047 the #if 0 of that comment.
9048 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9049 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9052 * search.c (boyer_moore): Rename locals to avoid shadowing.
9053 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9054 (PREV_CHAR_BOUNDARY): Likewise.
9056 * search.c (simple_search): Remove unused var.
9058 * dired.c (compile_pattern): Move decl from here ...
9059 * lisp.h: ... to here, so that it can be checked.
9060 (struct re_registers): New forward decl.
9062 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9064 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9066 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9067 Rename locals to avoid shadowing.
9068 (Fvertical_motion): Mark locals as initialized.
9070 * casefiddle.c (casify_object, casify_region): Now static.
9071 (casify_region): Mark local as initialized.
9073 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9075 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9076 New macros, so that the caller can use some names other than
9077 gcpro1, gcpro2, etc.
9078 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9080 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9081 argument, for consistency with GCPRO2_VAR, etc: it is now the
9082 prefix of the variable, not the variable itself. All uses
9084 * dired.c (directory_files_internal, file_name_completion):
9085 Rename locals to avoid shadowing.
9087 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9088 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9089 dired.c's scmp function, had undefined behavior.
9090 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9091 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9092 * buffer.h: ... to here, because these macros use current_buffer,
9093 and the new implementation with inline functions needs to have
9094 current_buffer in scope now, rather than later when the macros
9096 (downcase, upcase1): New static inline functions.
9097 (DOWNCASE, UPCASE1): Reimplement using these functions.
9098 This avoids undefined behavior in expressions like
9099 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9100 from race conditions in accessing the global variables
9101 case_temp1 and case_temp2.
9102 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9103 * lisp.h (case_temp1, case_temp2): Remove their decls.
9104 * character.h (ASCII_CHAR_P): Move from here ...
9105 * lisp.h: ... to here, so that the inline functions mentioned
9108 * dired.c (directory_files_internal_unwind): Now static.
9110 * fileio.c (file_name_as_directory, directory_file_name):
9111 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9113 (file_name_as_directory): Use const pointers when appropriate.
9114 (Fexpand_file_name): Likewise. In particular, newdir might
9115 point at constant storage, so make it a const pointer.
9116 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9117 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9119 (Fset_file_times, Finsert_file_contents, auto_save_error):
9120 Rename locals to avoid shadowing.
9122 * minibuf.c (choose_minibuf_frame_1): Now static.
9123 (Ftry_completion, Fall_completions): Rename or remove locals
9126 * marker.c (bytepos_to_charpos): Remove; unused.
9128 * lisp.h (verify_bytepos, count_markers): New decls,
9129 so that gcc does not warn that these functions aren't declared.
9131 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9132 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9133 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9134 (copy_text): Remove unused local var.
9136 * filelock.c (within_one_second): Now static.
9137 (lock_file_1): Rename local to avoid shadowing.
9139 * buffer.c (fix_overlays_before): Mark locals as initialized.
9140 (fix_start_end_in_overlays): Likewise. This function should be
9141 simplified by using pointers-to-pointers, but that's a different
9143 (switch_to_buffer_1): Now static.
9144 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9145 (report_overlay_modification): Rename locals to avoid shadowing.
9147 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9148 Fix pointer signedness issue.
9149 (sys_subshell): Mark local as volatile if checking for lint,
9150 to suppress a gcc -Wclobbered warning that does not seem to be right.
9151 (MAXPATHLEN): Define only if needed.
9153 * process.c (serial_open, serial_configure): Move decls from here ...
9154 * systty.h: ... to here, so that they can be checked.
9156 * fns.c (get_random, seed_random): Move extern decls from here ...
9157 * lisp.h: ... to here, so that they can be checked.
9159 * sysdep.c (reset_io): Now static.
9160 (wait_for_termination_signal): Remove; unused.
9162 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9163 (copy_keymap_item, append_key, push_text_char_description):
9165 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9166 (DENSE_TABLE_SIZE): Remove; unused.
9167 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9168 (describe_map_tree):
9169 Rename locals to avoid shadowing.
9171 * keyboard.c: Declare functions static if they are not used elsewhere.
9172 (echo_char, echo_dash, cmd_error, top_level_2):
9173 (poll_for_input, handle_async_input): Now static.
9174 (read_char, kbd_buffer_get_event, make_lispy_position):
9175 (make_lispy_event, make_lispy_movement, apply_modifiers):
9176 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9177 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9178 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9179 (read_key_sequence, read_char): Mark locals as initialized.
9180 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9182 * keyboard.h (make_ctrl_char): New decl.
9183 (mark_kboards): Move decl here ...
9184 * alloc.c (mark_kboards): ... from here.
9186 * lisp.h (force_auto_save_soon): New decl.
9188 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9189 (DEFINE_DUMMY_FUNCTION): New macro.
9190 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9192 (main): Add casts to avoid warnings
9193 if GCC considers string literals to be constants.
9195 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9197 * dbusbind.c: Pointer signedness fixes.
9198 (xd_signature, xd_append_arg, xd_initialize):
9199 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9200 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9201 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9202 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9204 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9205 if GCC considers string literals to be constants.
9206 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9208 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9210 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9211 (print_preprocess, print_object): New macro to fix last change.
9213 * print.c (print_preprocess): Don't forget font objects.
9215 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9217 * emacs.c (USAGE3): Doc fixes.
9219 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9221 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9224 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9226 * lisp.h (VWindow_system, Qfile_name_history):
9227 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9228 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9229 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9231 * w32select.c: Don't #include "keyboard.h".
9232 (run_protected): Add extern declaration for waiting_for_input.
9234 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9235 * w32console.c (detect_input_pending, read_input_pending)
9236 (encode_terminal_code):
9237 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9238 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9239 (w32_system_caret_y, Qfile_name_history):
9240 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9241 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9242 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9243 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9244 * w32proc.c (Qlocal, report_file_error):
9245 * w32term.c (Vwindow_system, updating_frame):
9246 * w32uniscribe.c (initialized, uniscribe_font_driver):
9247 Remove unneeded extern declarations.
9249 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9251 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9253 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9255 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9256 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9257 These macros can no longer be used for assignment.
9259 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9260 Assign struct members directly, instead of using BUF_BEGV etc.
9261 (record_buffer_markers, fetch_buffer_markers): New functions for
9262 recording and fetching special buffer markers.
9263 (set_buffer_internal_1, set_buffer_temp): Use them.
9265 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9267 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9269 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9270 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9272 * xdisp.c (hscroll_window_tree):
9273 (reconsider_clip_changes): Use PT instead of BUF_PT.
9275 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9277 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9278 $(EMACS_ROOT)/lib/intprops.h.
9280 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9282 Fix more problems found by GCC 4.5.2's static checks.
9284 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9285 to unsigned char * to avoid compiler diagnostic.
9286 (xg_free_frame_widgets): Make it clear that a local variable is
9287 needed only if USE_GTK_TOOLTIP.
9288 (gdk_window_get_screen): Make it clear that this macro is needed
9289 only if USE_GTK_TOOLTIP.
9290 (int_gtk_range_get_value): New function, which avoids a diagnostic
9291 from gcc -Wbad-function-cast.
9292 (xg_set_toolkit_scroll_bar_thumb): Use it.
9293 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9294 diagnostic from gcc -Wbad-function-cast.
9295 (get_utf8_string, xg_get_file_with_chooser):
9296 Rename locals to avoid shadowing.
9297 (create_dialog): Move locals to avoid shadowing.
9299 * xgselect.c (xg_select): Remove unused var.
9301 * image.c (four_corners_best): Mark locals as initialized.
9302 (gif_load): Initialize transparent_p to zero (Bug#8238).
9303 Mark another local as initialized.
9304 (my_png_error, my_error_exit): Mark with NO_RETURN.
9306 * image.c (clear_image_cache): Now static.
9307 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9308 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9309 (x_edge_detection): Remove unnecessary cast that
9310 gcc -Wbad-function-cast diagnoses.
9311 (gif_load): Fix pointer signedness.
9312 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9313 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9315 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9317 Improve quality of tests for time stamp overflow.
9318 For example, without this patch (encode-time 0 0 0 1 1
9319 1152921504606846976) returns the obviously-bogus value (-948597
9320 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9321 reports time overflow. See
9322 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9323 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9324 * editfns.c: Include limits.h and intprops.h.
9325 (TIME_T_MIN, TIME_T_MAX): New macros.
9326 (time_overflow): Move earlier, to before first use.
9327 (hi_time, lo_time): New functions, for an accurate test for
9329 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9330 (Fget_internal_run_time): Don't assume time_t fits in int.
9331 (make_time): Use list2 instead of Fcons twice.
9332 (Fdecode_time): More accurate test for out-of-range times.
9333 (check_tm_member): New function.
9334 (Fencode_time): Use it, to test for out-of-range times.
9335 (lisp_time_argument): Don't rely on undefined left-shift and
9336 right-shift behavior when checking for time stamp overflow.
9338 * editfns.c (time_overflow): New function, refactoring common code.
9339 (Fformat_time_string, Fdecode_time, Fencode_time):
9340 (Fcurrent_time_string): Use it.
9342 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9343 * dired.c (make_time): Move to ...
9344 * editfns.c (make_time): ... here.
9345 * systime.h: Note the move.
9347 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9349 * fringe.c (update_window_fringes): Remove unused variables.
9351 * unexmacosx.c (copy_data_segment): Also copy __got section.
9354 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9356 * termcap.c [MSDOS]: Include "msdos.h".
9357 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9358 Constify `char *' arguments and their references according to
9359 prototypes in tparam.h.
9361 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9363 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9364 Adapt all references accordingly.
9366 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9368 2011-03-11 Tom Tromey <tromey@redhat.com>
9370 * buffer.c (syms_of_buffer): Remove obsolete comment.
9372 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9374 * termhooks.h (encode_terminal_code): Declare prototype.
9376 * msdos.c (encode_terminal_code): Don't declare prototype.
9378 * term.c (encode_terminal_code): Now external again, used by
9379 w32console.c and msdos.c.
9381 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9382 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9384 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9386 Fix some minor problems found by GCC 4.5.2's static checks.
9388 * fringe.c (update_window_fringes): Mark locals as initialized
9390 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9392 * alloc.c (mark_fringe_data): Move decl from here ...
9393 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9394 to check its interface.
9395 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9397 * fontset.c (free_realized_fontset): Now static.
9398 (Fset_fontset_font): Rename local to avoid shadowing.
9399 (fontset_font): Mark local as initialized.
9400 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9402 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9404 * xselect.c (x_disown_buffer_selections): Remove; not used.
9405 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9406 (x_own_selection, Fx_disown_selection_internal): Rename locals
9408 (x_handle_dnd_message): Remove local to avoid shadowing.
9410 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9411 so that the caller can use some name other than gcpro1.
9412 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9413 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9414 (Fx_backspace_delete_keys_p):
9415 Use them to avoid shadowing, and rename vars to avoid shadowing.
9416 (x_decode_color, x_set_name, x_window): Now static.
9417 (Fx_create_frame): Add braces to silence GCC warning.
9418 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9419 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9420 Remove unused locals.
9421 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9422 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9423 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9426 * xterm.h (x_mouse_leave): New decl.
9428 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9429 Remove unused functions.
9430 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9431 (x_calc_absolute_position): Now static.
9432 (XTread_socket): Don't define label "out" unless it's used.
9433 Don't declare local "event" unless it's used.
9434 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9435 unless they are used.
9436 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9437 (x_fatal_error_signal): Remove; not used.
9438 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9439 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9440 (x_error_catcher, x_connection_closed, x_error_handler):
9441 (x_error_quitter, xembed_send_message, x_iconify_frame):
9442 (my_log_handler): Rename locals to avoid shadowing.
9443 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9444 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9446 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9447 Rename or move locals to avoid shadowing.
9448 (tty_defined_color, merge_face_heights): Now static.
9449 (free_realized_faces_for_fontset): Remove; not used.
9450 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9451 does not deduce is never used uninitialized.
9452 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9453 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9455 * terminal.c (store_terminal_param): Now static.
9457 * xmenu.c (menu_highlight_callback): Now static.
9458 (set_frame_menubar): Remove unused local.
9459 (xmenu_show): Rename parameter to avoid shadowing.
9460 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9461 since they might point to immutable storage.
9462 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9463 since it's unused otherwise.
9465 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9466 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9467 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9468 avoids a gcc -Wuninitialized diagnostic.
9469 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9470 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9471 does not deduce are never used uninitialized.
9473 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9475 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9476 * window.c (window_loop, size_window):
9477 (run_window_configuration_change_hook, enlarge_window): Likewise.
9479 * window.c (display_buffer): Now static.
9480 (size_window): Mark variables that gcc -Wuninitialized
9481 does not deduce are never used uninitialized.
9482 * window.h (check_all_windows): New decl, to forestall
9483 gcc -Wmissing-prototypes diagnostic.
9484 * dispextern.h (bidi_dump_cached_states): Likewise.
9486 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9488 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9490 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9491 and to avoid gcc -Wuninitialized warning.
9492 (load_charset_map): Mark variables that gcc -Wuninitialized
9493 does not deduce are never used uninitialized.
9494 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9496 * coding.c (coding_set_source, coding_set_destination):
9497 Use "else { /* comment */ }" rather than "else /* comment */;"
9498 for clarity, and to avoid gcc -Wempty-body warning.
9499 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9500 a block, when the outer 'i' will do.
9501 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9502 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9503 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9504 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9505 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9506 Rename locals to avoid shadowing.
9507 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9508 * coding.c (emacs_mule_char, encode_invocation_designation):
9509 Now static, since they're not used elsewhere.
9510 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9511 (decode_coding_object, encode_coding_object, detect_coding_system):
9512 (decode_coding_emacs_mule): Mark variables that gcc
9513 -Wuninitialized does not deduce are never used uninitialized.
9514 (detect_coding_iso_2022): Initialize a local variable that might
9515 be used uninitialized. Leave a FIXME because it's not clear that
9516 this initialization is needed. (Bug#8211)
9517 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9518 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9519 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9520 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9521 Remove unused macros.
9523 * category.c (hash_get_category_set): Remove unused local var.
9524 (copy_category_table): Now static, since it's not used elsewhere.
9525 * character.c (string_count_byte8): Likewise.
9527 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9528 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9530 * chartab.c (copy_sub_char_table): Now static, since it's not used
9532 (sub_char_table_ref_and_range, char_table_ref_and_range):
9533 Rename locals to avoid shadowing.
9534 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9536 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9537 (BIDI_BOB): Remove unused macro.
9539 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9540 deduce are never used uninitialized.
9541 * term.c (encode_terminal_code): Likewise.
9543 * term.c (encode_terminal_code): Now static. Remove unused local.
9545 * tparam.h: New file.
9546 * term.c, tparam.h: Include it.
9547 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9548 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9549 Move these decls to tparam.h, and make them agree with what
9550 is actually in tparam.c. The previous trick of using incompatible
9551 decls in different modules does not conform to the C standard.
9552 All callers of tparam changed to use tparam's actual API.
9553 * tparam.c (tparam1, tparam, tgoto):
9554 Use const pointers where appropriate.
9556 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9557 * cm.h (struct cm): Likewise.
9558 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9559 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9560 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9561 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9562 (turn_on_face, init_tty): Likewise.
9563 * termchar.h (struct tty_display_info): Likewise.
9565 * term.c (term_mouse_position): Rename local to avoid shadowing.
9567 * alloc.c (mark_ttys): Move decl from here ...
9568 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9570 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9572 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9574 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9576 * search.c (compile_pattern_1): Remove argument regp, unused since
9577 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9578 (compile_pattern): Don't pass it.
9580 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9582 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9583 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9585 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9587 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9589 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9590 gdk_window_get_screen, gdk_window_get_geometry,
9591 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9592 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9593 (xg_get_pixbuf_from_pixmap): New function.
9594 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9595 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9596 Call xg_get_pixbuf_from_pixmap instead of
9597 gdk_pixbuf_get_from_drawable.
9598 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9599 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9600 (xg_check_special_colors): Use GtkStyleContext and its functions
9602 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9603 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9604 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9605 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9606 Call gtk_widget_get_preferred_size.
9607 (xg_frame_resized): gdk_window_get_geometry only takes 5
9609 (xg_win_to_widget, xg_event_is_for_menubar):
9610 Call gdk_x11_window_lookup_for_display.
9611 (xg_set_widget_bg): New function.
9612 (delete_cb): New function.
9613 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9614 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9615 (xg_set_background_color): Call xg_set_widget_bg.
9616 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9617 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9618 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9619 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9621 (update_frame_tool_bar): Call gtk_widget_hide.
9622 (xg_initialize): Use GDK_KEY_g.
9624 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9626 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9628 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9629 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9630 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9632 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9634 * w32xfns.c (select_palette): Check success of RealizePalette against
9635 GDI_ERROR, not zero.
9637 See ChangeLog.11 for earlier changes.
9643 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9645 This file is part of GNU Emacs.
9647 GNU Emacs is free software: you can redistribute it and/or modify
9648 it under the terms of the GNU General Public License as published by
9649 the Free Software Foundation, either version 3 of the License, or
9650 (at your option) any later version.
9652 GNU Emacs is distributed in the hope that it will be useful,
9653 but WITHOUT ANY WARRANTY; without even the implied warranty of
9654 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9655 GNU General Public License for more details.
9657 You should have received a copy of the GNU General Public License
9658 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.