Remove more assumptions re struct layout (Bug#8884).
[bpt/emacs.git] / src / ChangeLog
1 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2
3 Remove unportable assumption about struct layout (Bug#8884).
4 * alloc.c (mark_buffer):
5 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6 (clone_per_buffer_values): Don't assume that
7 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8 This isn't true in general, and it's particularly not true
9 if Emacs is configured with --with-wide-int.
10 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
11 New macros, used in the buffer.c change.
12
13 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
14
15 * xsettings.c: Use both GConf and GSettings if both are available.
16 (store_config_changed_event): Add comment.
17 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
18 (store_tool_bar_style_changed): New functions.
19 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
20 (struct xsettings): Move font inside HAVE_XFT.
21 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
22 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
23 Move inside HAVE_XFT.
24 (something_changed_gsettingsCB): Renamed from something_changedCB.
25 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
26 also.
27 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
28 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
29 (something_changed_gconfCB): Renamed from something_changedCB.
30 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
31 (parse_settings): Move check for font inside HAVE_XFT.
32 (read_settings, apply_xft_settings): Add comment.
33 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
34 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
35 call store_font_name_changed.
36 (xft_settings_event): Add comment.
37 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
38 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
39 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
40 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
41 (xsettings_initialize): Call init_gsettings last.
42 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
43 comment.
44
45 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
46
47 Random fixes. E.g., (random) never returned negative values.
48 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
49 subseconds part to the entropy, as that's a bit more random.
50 Prefer signed to unsigned, since the signedness doesn't matter and
51 in general we prefer signed. When given a limit, use a
52 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
53 latter isn't right if USE_2_TAGS_FOR_INTS.
54 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
55 not 0..VALMASK. Don't discard "excess" bits that random () returns.
56
57 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
58
59 * textprop.c (text_property_stickiness):
60 Obey Vtext_property_default_nonsticky.
61 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
62 * w32fns.c (syms_of_w32fns):
63 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
64
65 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
66
67 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
68 This is more efficient than Ffile_directory_p and avoids a minor race.
69
70 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
71
72 * buffer.c (Foverlay_put): Say what the return value is
73 (bug#7835).
74
75 * fileio.c (barf_or_query_if_file_exists): Check first if the file
76 is a directory before asking whether to use the file name
77 (bug#7564).
78 (barf_or_query_if_file_exists): Make the "File is a directory"
79 error be more correct.
80
81 * fns.c (Frequire): Remove the mention of the .gz files, since
82 that's installation-specific, but keep the mention of
83 `get-load-suffixes'.
84
85 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
86
87 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
88 Report string overflow if the output is too long.
89
90 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
91
92 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
93 (syms_of_gnutls): Remove duplicate DEFSYM for
94 Qgnutls_bootprop_verify_hostname_error, an error for
95 Qgnutls_bootprop_verify_error (which is no longer used).
96
97 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
98 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
99 Also (re)move comments that are misplaced or no longer relevant.
100
101 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
102
103 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
104
105 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
106
107 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
108 and background color parameters if they have been changed.
109
110 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
111
112 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
113
114 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
115
116 * xsettings.c (SYSTEM_FONT): Define only when used.
117 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
118
119 * keymap.c (access_keymap_1): Now static.
120
121 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
122
123 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
124 leave any prefix arg for the up event (Bug#1586).
125
126 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
127
128 * lread.c (syms_of_lread): Mention single symbols defined by
129 `defvar' or `defconst' (bug#7154).
130
131 * fns.c (Frequire): Mention .el.gz files (bug#7314).
132 (Frequire): Mention get-load-suffixes.
133
134 2011-07-02 Martin Rudalics <rudalics@gmx.at>
135
136 * window.h (window): Remove clone_number slot.
137 * window.c (Fwindow_clone_number, Fset_window_clone_number):
138 Remove.
139 (make_parent_window, make_window, saved_window)
140 (Fset_window_configuration, save_window_save): Don't deal with
141 clone numbers.
142 * buffer.c (Qclone_number): Remove declaration.
143 (sort_overlays, overlay_strings): Don't deal with clone numbers.
144
145 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
146
147 Add multiple inheritance to keymaps.
148 * keymap.c (Fmake_composed_keymap): New function.
149 (Fset_keymap_parent): Simplify.
150 (fix_submap_inheritance): Remove.
151 (access_keymap_1): New function extracted from access_keymap to handle
152 embedded parents and handle lists of maps.
153 (access_keymap): Use it.
154 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
155 (Fcopy_keymap): Handle embedded parents.
156 (Fcommand_remapping, define_as_prefix): Simplify.
157 (Fkey_binding): Simplify.
158 (syms_of_keymap): Move minibuffer-local-completion-map,
159 minibuffer-local-filename-completion-map,
160 minibuffer-local-must-match-map, and
161 minibuffer-local-filename-must-match-map to Elisp.
162 (syms_of_keymap): Defsubr make-composed-keymap.
163 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
164 (parse_menu_item): Trivial simplification.
165
166 2011-07-01 Glenn Morris <rgm@gnu.org>
167
168 * Makefile.in (SETTINGS_LIBS): Fix typo.
169
170 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
171
172 * coding.c (Fencode_coding_string): Record the last coding system
173 used, as the function doc string says (bug#8738).
174
175 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
176
177 * xsettings.c (store_monospaced_changed): Take new font as arg and
178 check for change against current_mono_font.
179 (EMACS_TYPE_SETTINGS): Remove this and related defines.
180 (emacs_settings_constructor, emacs_settings_get_property)
181 (emacs_settings_set_property, emacs_settings_class_init)
182 (emacs_settings_init, gsettings_obj): Remove.
183 (something_changedCB): New function for HAVE_GSETTINGS.
184 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
185 with value as argument.
186 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
187 g_settings_new (Bug#8967). Do not create gsettings_obj.
188 Remove calls to g_settings_bind. Connect something_changedCB to
189 "changed".
190
191 * xgselect.c: Add defined (HAVE_GSETTINGS).
192 (xgselect_initialize): Ditto.
193
194 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
195 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
196 xg_select.
197
198 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
199
200 * eval.c (struct backtrace): Simplify and port the data structure.
201 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
202 signed bit field, as this assumption is not portable and it makes
203 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
204 "char debug_on_exit : 1" as this is not portable either; instead,
205 use the portable "unsigned int debug_on_exit : 1". Remove unused
206 member evalargs. Remove obsolete comments about cc bombing out.
207
208 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
209
210 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
211 Let HAVE_GSETTINGS override HAVE_GCONF.
212 (store_monospaced_changed): New function.
213 (EMACS_SETTINGS): A new type derived from GObject to handle
214 GSettings notifications.
215 (emacs_settings_constructor, emacs_settings_get_property)
216 (emacs_settings_set_property, emacs_settings_class_init):
217 New functions.
218 (gsettings_client, gsettings_obj): New variables.
219 (GSETTINGS_SCHEMA): New define.
220 (something_changedCB): Call store_monospaced_changed.
221 (init_gsettings): New function.
222 (xsettings_initialize): Call init_gsettings.
223 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
224 to NULL.
225
226 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
227 GCONF_CFLAGS/LIBS.
228
229 2011-06-29 Martin Rudalics <rudalics@gmx.at>
230
231 * window.c (resize_root_window, grow_mini_window)
232 (shrink_mini_window): Rename Qresize_root_window to
233 Qwindow_resize_root_window and Qresize_root_window_vertically to
234 Qwindow_resize_root_window_vertically.
235
236 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
237
238 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
239
240 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
241
242 * makefile.w32-in: Redesign dependencies so they reflect more
243 clearly which files are directly included by each source file,
244 and not through other includes.
245
246 2011-06-27 Martin Rudalics <rudalics@gmx.at>
247
248 * buffer.c (Qclone_number): Declare static and DEFSYM it.
249 (sort_overlays, overlay_strings): When an overlay's clone number
250 matches the window's clone number process the overlay even if
251 the overlay's window property doesn't match the current window.
252
253 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
254 (Fwindow_hchild): Rename to Fwindow_left_child.
255 (Fwindow_next): Rename to Fwindow_next_sibling.
256 (Fwindow_prev): Rename to Fwindow_prev_sibling.
257 (resize_window_check): Rename to window_resize_check.
258 (resize_window_apply): Rename to window_resize_apply.
259 (Fresize_window_apply): Rename to Fwindow_resize_apply.
260 (Fdelete_other_windows_internal, resize_frame_windows)
261 (Fsplit_window_internal, Fdelete_window_internal)
262 (grow_mini_window, shrink_mini_window)
263 (Fresize_mini_window_internal): Fix callers accordingly.
264
265 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
266
267 * emacsgtkfixed.h: State that this is only used with Gtk+3.
268 (emacs_fixed_set_min_size): Remove.
269 (emacs_fixed_new): Take frame as argument.
270
271 * emacsgtkfixed.c: State that this is only used with Gtk+3.
272 (_EmacsFixedPrivate): Remove minwidth/height.
273 Add struct frame *f.
274 (emacs_fixed_init): Initialize priv->f.
275 (get_parent_class, emacs_fixed_set_min_size): Remove.
276 (emacs_fixed_new): Set priv->f to argument.
277 (emacs_fixed_get_preferred_width)
278 (emacs_fixed_get_preferred_height): Use min_width/height from
279 frames size_hint to set minimum and natural (Bug#8919).
280 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
281 and use min_width/height from frames size_hint to set
282 min_width/height (Bug#8919).
283
284 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
285 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
286 Fix indentation.
287
288 2011-06-26 Eli Zaretskii <eliz@gnu.org>
289
290 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
291 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
292 called at ZV.
293
294 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
295
296 * process.c (wait_reading_process_output): Bypass select if
297 waiting for a cell while ignoring keyboard input, and input is
298 pending. Suggested by Jan Djärv (Bug#8869).
299
300 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
301
302 Use gnulib's dup2 module instead of rolling our own.
303 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
304
305 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
306
307 * dispnew.c (scrolling_window): Before scrolling, turn off a
308 mouse-highlight in the window being scrolled.
309
310 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
311
312 Move DEFSYM to lisp.h and use everywhere.
313
314 * character.h (DEFSYM): Move declaration...
315 * lisp.h (DEFSYM): ...here.
316
317 * gnutls.c:
318 * minibuf.c:
319 * w32menu.c:
320 * w32proc.c:
321 * w32select.c: Don't include character.h.
322
323 * alloc.c (syms_of_alloc):
324 * buffer.c (syms_of_buffer):
325 * bytecode.c (syms_of_bytecode):
326 * callint.c (syms_of_callint):
327 * casefiddle.c (syms_of_casefiddle):
328 * casetab.c (init_casetab_once):
329 * category.c (init_category_once, syms_of_category):
330 * ccl.c (syms_of_ccl):
331 * cmds.c (syms_of_cmds):
332 * composite.c (syms_of_composite):
333 * dbusbind.c (syms_of_dbusbind):
334 * dired.c (syms_of_dired):
335 * dispnew.c (syms_of_display):
336 * doc.c (syms_of_doc):
337 * editfns.c (syms_of_editfns):
338 * emacs.c (syms_of_emacs):
339 * eval.c (syms_of_eval):
340 * fileio.c (syms_of_fileio):
341 * fns.c (syms_of_fns):
342 * frame.c (syms_of_frame):
343 * fringe.c (syms_of_fringe):
344 * insdel.c (syms_of_insdel):
345 * keymap.c (syms_of_keymap):
346 * lread.c (init_obarray, syms_of_lread):
347 * macros.c (syms_of_macros):
348 * msdos.c (syms_of_msdos):
349 * print.c (syms_of_print):
350 * process.c (syms_of_process):
351 * search.c (syms_of_search):
352 * sound.c (syms_of_sound):
353 * syntax.c (init_syntax_once, syms_of_syntax):
354 * terminal.c (syms_of_terminal):
355 * textprop.c (syms_of_textprop):
356 * undo.c (syms_of_undo):
357 * w32.c (globals_of_w32):
358 * window.c (syms_of_window):
359 * xdisp.c (syms_of_xdisp):
360 * xfaces.c (syms_of_xfaces):
361 * xfns.c (syms_of_xfns):
362 * xmenu.c (syms_of_xmenu):
363 * xsettings.c (syms_of_xsettings):
364 * xterm.c (syms_of_xterm): Use DEFSYM.
365
366 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
367
368 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
369
370 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
371
372 Integer and buffer overflow fixes (Bug#8873).
373
374 * print.c (printchar, strout): Check for string overflow.
375 (PRINTPREPARE, printchar, strout):
376 Don't set size unless allocation succeeds.
377
378 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
379 for sizes. Check for string overflow more accurately.
380 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
381
382 * macros.c: Integer and buffer overflow fixes.
383 * keyboard.h (struct keyboard.kbd_macro_bufsize):
384 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
385 Use ptrdiff_t, not int, for sizes.
386 Don't increment bufsize until after realloc succeeds.
387 Check for size-calculation overflow.
388 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
389
390 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
391
392 * lread.c: Integer overflow fixes.
393 (read_integer): Radix is now EMACS_INT, not int,
394 to improve quality of diagnostics for out-of-range radices.
395 Calculate buffer size correctly for out-of-range radices.
396 (read1): Check for integer overflow in radices, and in
397 read-circle numbers.
398 (read_escape): Avoid int overflow.
399 (Fload, openp, read_buffer_size, read1)
400 (substitute_object_recurse, read_vector, read_list, map_obarray):
401 Use ptrdiff_t, not int, for sizes.
402 (read1): Use EMACS_INT, not int, for sizes.
403 Check for size overflow.
404
405 * image.c (cache_image): Check for size arithmetic overflow.
406
407 * lread.c: Integer overflow issues.
408 (saved_doc_string_size, saved_doc_string_length)
409 (prev_saved_doc_string_size, prev_saved_doc_string_length):
410 Now ptrdiff_t, not int.
411 (read1): Don't assume doc string length fits in int. Check for
412 out-of-range doc string lengths.
413 (read_list): Don't assume file position fits in int.
414 (read_escape): Check for hex character overflow.
415
416 2011-06-22 Leo Liu <sdl.web@gmail.com>
417
418 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
419 Move to minibuffer.el.
420
421 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
422
423 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
424 The following patches are for when GLYPH_DEBUG && !XASSERT.
425 * dispextern.h (trace_redisplay_p, dump_glyph_string):
426 * dispnew.c (flush_stdout):
427 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
428 Mark as externally visible.
429 * dispnew.c (check_window_matrix_pointers): Now static.
430 * dispnew.c (window_to_frame_vpos):
431 * xfns.c (unwind_create_frame):
432 * xterm.c (x_check_font): Remove unused local.
433 * scroll.c (CHECK_BOUNDS):
434 * xfaces.c (cache_fache): Rename local to avoid shadowing.
435 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
436 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
437 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
438 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
439 Now static.
440 (debug_method_add): Use va_list and vsprintf rather than relying
441 on undefined behavior with wrong number of arguments.
442 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
443 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
444 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
445 since we're not interested in debugging glyphs with old libraries.
446 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
447 GCC 4.6.0's static checking.
448
449 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
450
451 Integer overflow and signedness fixes (Bug#8873).
452 A few related buffer overrun fixes, too.
453
454 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
455
456 * dispextern.h (struct face.stipple):
457 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
458 (x_bitmap_mask, x_allocate_bitmap_record)
459 (x_create_bitmap_from_data, x_create_bitmap_from_file)
460 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
461 (x_create_bitmap_from_xpm_data):
462 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
463 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
464 (.bitmaps_last):
465 * xfaces.c (load_pixmap):
466 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
467 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
468 (.bitmaps_last, struct x_output.icon_bitmap):
469 Use ptrdiff_t, not int, for bitmap indexes.
470 (x_allocate_bitmap_record): Check for size overflow.
471 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
472
473 Use ptrdiff_t, not int, for overlay counts.
474 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
475 * editfns.c (overlays_around, get_pos_property):
476 * textprop.c (get_char_property_and_overlay):
477 * xdisp.c (next_overlay_change, note_mouse_highlight):
478 * xfaces.c (face_at_buffer_position):
479 * buffer.c (OVERLAY_COUNT_MAX): New macro.
480 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
481 (Fnext_overlay_change, Fprevious_overlay_change)
482 (mouse_face_overlay_overlaps, Foverlays_in):
483 Use ptrdiff_t, not int, for sizes.
484 (overlays_at, overlays_in): Check for size-calculation overflow.
485
486 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
487
488 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
489 (x_session_initialize): Do not assume string length fits in int.
490
491 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
492 This is unlikely, but can occur if DPI is outlandish.
493
494 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
495 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
496
497 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
498 * xrdb.c (magic_file_p, search_magic_path):
499 Omit last arg SUFFIX; it was always 0. All callers changed.
500 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
501
502 * xfont.c (xfont_match): Avoid need for strlen.
503
504 * xfns.c: Don't assume strlen fits in int.
505 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
506
507 * xdisp.c (message_log_check_duplicate): Return intmax_t,
508 not unsigned long, as we prefer signed integers. All callers changed.
509 Detect integer overflow in repeat count.
510 (message_dolog): Don't assume print length fits in 39 bytes.
511 (display_mode_element): Don't assume strlen fits in int.
512
513 * termcap.c: Don't assume sizes fit in int and never overflow.
514 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
515 (gobble_line): Check for size-calculation overflow.
516
517 * minibuf.c (Fread_buffer):
518 * lread.c (intern, intern_c_string):
519 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
520 Don't assume string length fits in int.
521
522 * keyboard.c (parse_tool_bar_item):
523 * gtkutil.c (style_changed_cb): Avoid need for strlen.
524
525 * font.c: Don't assume string length fits in int.
526 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
527 Use ptrdiff_t, not int.
528 (font_intern_prop): Don't assume string length fits in int.
529 Don't assume integer property fits in fixnum.
530 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
531
532 * filelock.c: Fix some buffer overrun and integer overflow issues.
533 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
534 Reformulate so as not to need the command string.
535 Invoke gzip -cd rather than gunzip, as it's more portable.
536 (lock_info_type, lock_file_1, lock_file):
537 Don't assume pid_t and time_t fit in unsigned long.
538 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
539 (current_lock_owner): Prefer signed type for sizes.
540 Use memcpy, not strncpy, where memcpy is what is really wanted.
541 Don't assume (via atoi) that time_t and pid_t fit in int.
542 Check for time_t and/or pid_t out of range, e.g., via a network share.
543 Don't alloca where an auto var works fine.
544
545 * fileio.c: Fix some integer overflow issues.
546 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
547 Don't assume string length fits in int.
548 (directory_file_name): Don't assume string length fits in long.
549 (make_temp_name): Don't assume pid fits in int, or that its print
550 length is less than 20.
551
552 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
553
554 * coding.c (make_subsidiaries): Don't assume string length fits in int.
555
556 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
557
558 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
559 We prefer signed integers, even for size calculations.
560
561 * emacs.c: Don't assume string length fits in 'int'.
562 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
563 (main): Don't invoke strlen when not needed.
564
565 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
566 (XD_DEBUG_MESSAGE): Don't waste a byte.
567
568 * callproc.c (getenv_internal_1, getenv_internal)
569 (Fgetenv_internal):
570 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
571
572 * lread.c (invalid_syntax): Omit length argument.
573 All uses changed. This doesn't fix a bug, but it simplifies the
574 code away from its former Hollerith-constant appearance, and it's
575 one less 'int' to worry about when looking at integer-overflow issues.
576 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
577
578 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
579 This didn't break anything, but it didn't help either.
580 It's confusing to put a bogus integer in a place where the actual
581 value does not matter.
582 (LIST_END_P): Remove unused macro and its bogus comment.
583 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
584
585 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
586 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
587 implementation.
588 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
589 We prefer signed types, and the value cannot exceed the EMACS_INT
590 range anyway (because otherwise the length would not be representable).
591 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
592 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
593 This avoids a GCC warning when WIDE_EMACS_INT.
594
595 * indent.c (sane_tab_width): New function.
596 (current_column, scan_for_column, Findent_to, position_indentation)
597 (compute_motion): Use it. This is just for clarity.
598 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
599
600 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
601
602 * lisp.h (lint_assume): New macro.
603 * composite.c (composition_gstring_put_cache):
604 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
605
606 * editfns.c, insdel.c:
607 Omit unnecessary forward decls, to simplify future changes.
608
609 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
610
611 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
612
613 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
614 Use much-faster test for byte-length change.
615 Don't assume string byte-length fits in 'int'.
616 Check that character arg fits in 'int'.
617 (mapcar1): Declare byte as byte, for clarity.
618
619 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
620
621 * fns.c (concat): Catch string overflow earlier.
622 Do not rely on integer wraparound.
623
624 * dispextern.h (struct it.overlay_strings_charpos)
625 (struct it.selective): Now EMACS_INT, not int.
626 * xdisp.c (forward_to_next_line_start)
627 (back_to_previous_visible_line_start)
628 (reseat_at_next_visible_line_start, next_element_from_buffer):
629 Don't arbitrarily truncate the value of 'selective' to int.
630
631 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
632
633 * composite.c: Don't truncate sizes to 'int'.
634 (composition_gstring_p, composition_reseat_it)
635 (composition_adjust_point): Use EMACS_INT, not int.
636 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
637 not EMACS_UINT, for indexes.
638
639 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
640
641 * buffer.c: Include <verify.h>.
642 (struct sortvec.priority, struct sortstr.priority):
643 Now EMACS_INT, not int.
644 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
645 (struct sortstr.size, record_overlay_string)
646 (struct sortstrlist.size, struct sortlist.used):
647 Don't truncate size to int.
648 (record_overlay_string): Check for size-calculation overflow.
649 (init_buffer_once): Check at compile-time, not run-time.
650
651 2011-06-22 Jim Meyering <meyering@redhat.com>
652
653 Don't leak an XBM-image-sized buffer
654 * image.c (xbm_load): Free the image buffer after using it.
655
656 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
657
658 Port to Sun C.
659 * composite.c (find_automatic_composition): Omit needless 'return 0;'
660 that Sun C diagnosed.
661 * fns.c (secure_hash): Fix pointer signedness issue.
662 * intervals.c (static_offset_intervals): New function.
663 (offset_intervals): Use it.
664
665 2011-06-21 Leo Liu <sdl.web@gmail.com>
666
667 * deps.mk (fns.o):
668 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
669 sha512.h.
670
671 * fns.c (secure_hash): Rename from crypto_hash_function and change
672 the first arg to accept symbols.
673 (Fsecure_hash): New primitive.
674 (syms_of_fns): New symbols.
675
676 2011-06-20 Deniz Dogan <deniz@dogan.se>
677
678 * process.c (Fset_process_buffer): Clarify return value in
679 docstring.
680
681 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
682
683 * dispnew.c (add_window_display_history): Use BVAR.
684
685 * xdisp.c (debug_method_add): Use BVAR.
686 (check_window_end, dump_glyph_matrix, dump_glyph)
687 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
688
689 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
690 Likewise.
691
692 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
693 check till after the cache is created in init_frame_faces.
694
695 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
696
697 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
698
699 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
700
701 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
702 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
703 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
704
705 Improve buffer-overflow checking (Bug#8873).
706 * fileio.c (Finsert_file_contents):
707 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
708 Remove the old (too-loose) buffer overflow checks.
709 They weren't needed, since make_gap checks for buffer overflow.
710 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
711 The old code merely checked for Emacs fixnum overflow, and relied
712 on undefined (wraparound) behavior. The new code avoids undefined
713 behavior, and also checks for ptrdiff_t and/or size_t overflow.
714
715 * editfns.c (Finsert_char): Don't dump core with very negative counts.
716 Tune. Don't use wider integers than needed. Don't use alloca.
717 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
718
719 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
720
721 * insdel.c, lisp.h (buffer_overflow): New function.
722 (insert_from_buffer_1, replace_range, replace_range_2):
723 * insdel.c (make_gap_larger):
724 * editfns.c (Finsert_char):
725 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
726
727 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
728
729 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
730
731 Integer overflow and signedness fixes (Bug#8873).
732
733 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
734 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
735
736 * fileio.c: Don't assume EMACS_INT fits in off_t.
737 (emacs_lseek): New static function.
738 (Finsert_file_contents, Fwrite_region): Use it.
739 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
740
741 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
742
743 * fns.c: Don't overflow int when computing a list length.
744 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
745 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
746 truncation on 64-bit hosts. Check for QUIT every
747 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
748 faster and is responsive enough.
749 (Flength): Report an error instead of overflowing an integer.
750 (Fsafe_length): Return a float if the value is not representable
751 as a fixnum. This shouldn't happen except in contrived situations.
752 (Fnthcdr, Fsort): Don't assume list length fits in int.
753 (Fcopy_sequence): Don't assume vector length fits in int.
754
755 * alloc.c: Check that resized vectors' lengths fit in fixnums.
756 (header_size, word_size): New constants.
757 (allocate_vectorlike): Don't check size overflow here.
758 (allocate_vector): Check it here instead, since this is the only
759 caller of allocate_vectorlike that could cause overflow.
760 Check that the new vector's length is representable as a fixnum.
761
762 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
763 The previous code was bogus. For example, next_almost_prime (32)
764 returned 39, which is undesirable as it is a multiple of 3; and
765 next_almost_prime (24) returned 25, which is a multiple of 5 so
766 why was the code bothering to check for multiples of 7?
767
768 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
769
770 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
771
772 Variadic C functions now count arguments with ptrdiff_t.
773 This partly undoes my 2011-03-30 change, which replaced int with size_t.
774 Back then I didn't know that the Emacs coding style prefers signed int.
775 Also, in the meantime I found a few more instances where arguments
776 were being counted with int, which may truncate counts on 64-bit
777 machines, or EMACS_INT, which may be unnecessarily wide.
778 * lisp.h (struct Lisp_Subr.function.aMANY)
779 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
780 Arg counts are now ptrdiff_t, not size_t.
781 All variadic functions and their callers changed accordingly.
782 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
783 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
784 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
785 * callint.c (Fcall_interactively): Check arg count for overflow,
786 to avoid potential buffer overrun. Use signed char, not 'int',
787 for 'varies' array, so that we needn't bother to check its size
788 calculation for overflow.
789 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
790 * eval.c (apply_lambda):
791 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
792 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
793 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
794
795 * callint.c (Fcall_interactively): Don't use index var as event count.
796
797 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
798 * mem-limits.h (SIZE): Remove; no longer used.
799
800 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
801
802 Remove unnecessary casts.
803 * xterm.c (x_term_init):
804 * xfns.c (x_set_border_pixel):
805 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
806 These aren't needed now that we assume ANSI C.
807
808 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
809 It's more likely to cause problems (due to unsigned overflow)
810 than to cure them.
811
812 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
813
814 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
815
816 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
817
818 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
819
820 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
821
822 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
823
824 GLYPH_CODE_FACE returns EMACS_INT, not int.
825 * dispextern.h (merge_faces):
826 * xfaces.c (merge_faces):
827 * xdisp.c (get_next_display_element, next_element_from_display_vector):
828 Don't assume EMACS_INT fits in int.
829
830 * character.h (CHAR_VALID_P): Remove unused parameter.
831 * fontset.c, lisp.h, xdisp.c: All uses changed.
832
833 * editfns.c (Ftranslate_region_internal): Omit redundant test.
834
835 * fns.c (concat): Minor tuning based on overflow analysis.
836 This doesn't fix any bugs. Use int to hold character, instead
837 of constantly refetching from Emacs object. Use XFASTINT, not
838 XINT, for value known to be a character. Don't bother comparing
839 a single byte to 0400, as it's always less.
840
841 * floatfns.c (Fexpt):
842 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
843
844 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
845 for characters.
846
847 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
848
849 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
850 Without this fix, on a 64-bit host (aset S 0 4294967386) would
851 incorrectly succeed when S was a string, because 4294967386 was
852 truncated before it was used.
853
854 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
855 Otherwise, an out-of-range integer could cause undefined behavior
856 on a 64-bit host.
857
858 * composite.c: Use int, not EMACS_INT, for characters.
859 (fill_gstring_body, composition_compute_stop_pos): Use int, not
860 EMACS_INT, for values that are known to be in character range.
861 This doesn't fix any bugs but is the usual style inside Emacs and
862 may generate better code on 32-bit machines.
863
864 Make sure a 64-bit char is never passed to ENCODE_CHAR.
865 This is for reasons similar to the recent CHAR_STRING fix.
866 * charset.c (Fencode_char): Check that character arg is actually
867 a character. Pass an int to ENCODE_CHAR.
868 * charset.h (ENCODE_CHAR): Verify that the character argument is no
869 wider than 'int', as a compile-time check to prevent future regressions
870 in this area.
871
872 * character.c (char_string): Remove unnecessary casts.
873
874 Make sure a 64-bit char is never passed to CHAR_STRING.
875 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
876 by silently ignoring the top 32 bits, allowing some values
877 that were far too large to be valid characters.
878 * character.h: Include <verify.h>.
879 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
880 arguments are no wider than unsigned, as a compile-time check
881 to prevent future regressions in this area.
882 * data.c (Faset):
883 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
884 (Fsubst_char_in_region):
885 * fns.c (concat):
886 * xdisp.c (decode_mode_spec_coding):
887 Adjust to CHAR_STRING's new requirement.
888 * editfns.c (Finsert_char, Fsubst_char_in_region):
889 * fns.c (concat): Check that character args are actually
890 characters. Without this test, these functions did the wrong
891 thing with wildly out-of-range values on 64-bit hosts.
892
893 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
894 These casts should not be needed on 32-bit hosts, either.
895 * keyboard.c (read_char):
896 * lread.c (Fload): Remove casts to unsigned.
897
898 * lisp.h (UNSIGNED_CMP): New macro.
899 This fixes comparison bugs on 64-bit hosts.
900 (ASCII_CHAR_P): Use it.
901 * casefiddle.c (casify_object):
902 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
903 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
904 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
905 * dispextern.h (FACE_FROM_ID):
906 * keyboard.c (read_char): Use UNSIGNED_CMP.
907
908 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
909 not to EMACS_INT, to avoid GCC warning.
910
911 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
912
913 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
914 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
915 isn't needed on 32-bit machines.
916
917 * buffer.c (Fgenerate_new_buffer_name):
918 Use EMACS_INT for count, not int.
919 (advance_to_char_boundary): Return EMACS_INT, not int.
920
921 * data.c (Qcompiled_function): Now static.
922
923 * window.c (window_body_lines): Now static.
924
925 * image.c (gif_load): Rename local to avoid shadowing.
926
927 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
928 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
929 * alloc.c (make_save_value): Integer argument is now of type
930 ptrdiff_t, not int.
931 (mark_object): Use ptrdiff_t, not int.
932 * lisp.h (pD): New macro.
933 * print.c (print_object): Use it.
934
935 * alloc.c: Use EMACS_INT, not int, to count objects.
936 (total_conses, total_markers, total_symbols, total_vector_size)
937 (total_free_conses, total_free_markers, total_free_symbols)
938 (total_free_floats, total_floats, total_free_intervals)
939 (total_intervals, total_strings, total_free_strings):
940 Now EMACS_INT, not int. All uses changed.
941 (Fgarbage_collect): Compute overall total using a double, so that
942 integer overflow is less likely to be a problem. Check for overflow
943 when converting back to an integer.
944 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
945 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
946 These were 'int' variables that could overflow on 64-bit hosts;
947 they were never used, so remove them instead of repairing them.
948 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
949 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
950 Previously, this ceilinged at INT_MAX, but that doesn't work on
951 64-bit machines.
952 (allocate_pseudovector): Don't use EMACS_INT when int would do.
953
954 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
955 (allocate_vectorlike): Check for ptrdiff_t overflow.
956 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
957 when a (possibly-narrower) signed value would do just as well.
958 We prefer using signed arithmetic, to avoid comparison confusion.
959
960 * alloc.c: Catch some string size overflows that we were missing.
961 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
962 for convenience in STRING_BYTES_MAX.
963 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
964 The definition here is exact; the one in lisp.h was approximate.
965 (allocate_string_data): Check for string overflow. This catches
966 some instances we weren't catching before. Also, it catches
967 size_t overflow on (unusual) hosts where SIZE_MAX <= min
968 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
969 and ptrdiff_t and EMACS_INT are both 64 bits.
970
971 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
972 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
973 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
974
975 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
976
977 * alloc.c (Fmake_string): Check for out-of-range init.
978
979 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
980
981 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
982
983 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
984
985 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
986 xg_get_default_scrollbar_width.
987
988 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
989 (int_gtk_range_get_value): Move to the scroll bar part of the file.
990 (style_changed_cb): Call update_theme_scrollbar_width and call
991 x_set_scroll_bar_default_width and xg_frame_set_char_size for
992 all frames (Bug#8505).
993 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
994 Call gtk_window_set_resizable if HAVE_GTK3.
995 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
996 and height if HAVE_GTK3 (Bug#8505).
997 (scroll_bar_width_for_theme): New variable.
998 (update_theme_scrollbar_width): New function.
999 (xg_get_default_scrollbar_width): Move code to
1000 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1001 (xg_initialize): Call update_theme_scrollbar_width.
1002
1003 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1004
1005 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1006
1007 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1008
1009 * frame.c (make_frame): Call other_buffer_safely instead of
1010 other_buffer.
1011
1012 * window.c (temp_output_buffer_show): Call display_buffer with
1013 second argument Vtemp_buffer_show_specifiers and reset latter
1014 immediately after the call.
1015 (Vtemp_buffer_show_specifiers): New variable.
1016 (auto_window_vscroll_p, next_screen_context_lines)
1017 (Vscroll_preserve_screen_position): Remove leading asterisks from
1018 doc-strings.
1019
1020 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1021
1022 Fix minor problems found by GCC 4.6.0 static checking.
1023 * buffer.c (Qclone_number): Remove for now, as it's unused.
1024 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1025 (record_buffer): Remove unused local.
1026 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1027 (set_frame_buffer_list): Remove; unused.
1028 * frame.h (other_visible_frames): Remove decl.
1029 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1030 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1031 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1032 if HAVE_GPM.
1033 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1034 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1035 Define only if HAVE_GPM.
1036 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1037 (update_hints_inhibit): Remove; never set. All uses removed.
1038 * widgetprv.h (emacsFrameClassRec): Remove decl.
1039 * window.c (delete_deletable_window): Now returns void, since it
1040 wasn't returning anything.
1041 (compare_window_configurations): Remove unused locals.
1042 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1043 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1044 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1045 the same widths as pointers. This follows up on the 2011-05-06 patch.
1046 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1047 * xterm.h: Likewise.
1048 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1049
1050 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1051
1052 * makefile.w32-in: Update dependencies.
1053 (LISP_H): Add lib/intprops.h.
1054
1055 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1056
1057 * image.c (gif_load): Add animation frame delay to the metadata.
1058 (syms_of_image): Use DEFSYM. New symbol `delay'.
1059
1060 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1061
1062 * window.c (delete_deletable_window): Re-add.
1063 (Fset_window_configuration): Rewrite to handle dead buffers and
1064 consequently deletable windows.
1065 (window_tree, Fwindow_tree): Remove. Supply functionality in
1066 window.el.
1067 (compare_window_configurations): Simplify code.
1068
1069 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1070
1071 * image.c (imagemagick_load_image): Fix type mismatch.
1072 (Fimagemagick_types): Likewise.
1073
1074 * window.h (replace_buffer_in_windows): Declare.
1075
1076 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1077
1078 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1079 Qclone_number. Remove external declaration of Qdelete_window.
1080 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1081 code.
1082 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1083 Qbuffer_list_update_hook if allowed.
1084 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1085 buffer list implementation.
1086 (other_buffer_safely): New function.
1087 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1088 calls to replace_buffer_in_windows and
1089 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1090 if allowed.
1091 (record_buffer): Inhibit quitting and rewrite using quittable
1092 functions. Run Qbuffer_list_update_hook if allowed.
1093 (Frecord_buffer, Funrecord_buffer): New functions.
1094 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1095 switch-to-buffer to window.el.
1096 (bury-buffer): Move to window.el.
1097 (Vbuffer_list_update_hook): New variable.
1098
1099 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1100 section.
1101
1102 * window.h (resize_frame_windows): Move up in code.
1103 (Fwindow_frame): Remove EXFUN.
1104 (replace_buffer_in_all_windows): Remove prototype.
1105 (replace_buffer_in_windows_safely): Add prototype.
1106
1107 * window.c: Declare Qdelete_window static again. Move down
1108 declaration of select_count.
1109 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1110 (Fother_window): Move to window.el.
1111 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1112 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1113 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1114 window.el.
1115 (replace_buffer_in_windows): Implement by calling
1116 Qreplace_buffer_in_windows.
1117 (replace_buffer_in_all_windows): Remove with some functionality
1118 moved into replace_buffer_in_windows_safely.
1119 (replace_buffer_in_windows_safely): New function.
1120 (select_window_norecord, select_frame_norecord): Move in front
1121 of run_window_configuration_change_hook. Remove now obsolete
1122 declarations.
1123 (Fset_window_buffer): Rewrite doc-string. Call
1124 Qrecord_window_buffer.
1125 (keys_of_window): Move binding for other-window to window.el.
1126
1127 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1128
1129 * dispextern.h (struct image): Replace data member, whose int_val
1130 and ptr_val fields were not used by anything, with a single
1131 lisp_val object.
1132
1133 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1134 (gif_clear_image, gif_load, imagemagick_load_image)
1135 (gs_clear_image, gs_load): Callers changed.
1136
1137 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1138
1139 * buffer.h: Include <time.h>, for time_t.
1140 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1141
1142 Fix minor problems found by static checking.
1143
1144 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1145
1146 Make identifiers static if they are not used in other modules.
1147 * data.c (Qcompiled_function, Qframe, Qvector):
1148 * image.c (QimageMagick, Qsvg):
1149 * minibuf.c (Qmetadata):
1150 * window.c (resize_window_check, resize_root_window): Now static.
1151 * window.h (resize_window_check, resize_root_window): Remove decls.
1152
1153 * window.c (window_deletion_count, delete_deletable_window):
1154 Remove; unused.
1155 (window_body_lines): Now static.
1156 (Fdelete_other_windows_internal): Mark vars as initialized.
1157 Make sure 'resize_failed' is initialized.
1158 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1159 (resize_window_apply): Remove unused local.
1160 * window.h (delete_deletable_window): Remove decl.
1161
1162 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1163 (imagemagick_load_image): Fix pointer signedness problem by changing
1164 last arg from unsigned char * to char *. All uses changed.
1165 Also, fix a local for similar reasons.
1166 Remove unused locals. Remove locals to avoid shadowing.
1167 (fn_rsvg_handle_free): Remove; unused.
1168 (svg_load, svg_load_image): Fix pointer signedness problem.
1169 (imagemagick_load_image): Don't use garbage pointer image_wand.
1170
1171 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1172
1173 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1174
1175 * image.c (gif_load): Fix omitted cast error introduced by
1176 2011-06-06 change.
1177
1178 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1179
1180 * window.h (resize_proportionally, orig_total_lines)
1181 (orig_top_line): Remove from window structure.
1182 (set_window_height, set_window_width, change_window_heights)
1183 (Fdelete_window): Remove prototypes.
1184 (resize_frame_windows): Remove duplicate declaration.
1185
1186 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1187
1188 * window.h (resize_frame_windows, resize_window_check)
1189 (delete_deletable_window, resize_root_window)
1190 (resize_frame_windows): Declare prototypes.
1191
1192 * window.c (resize_window_apply): Make definition be "static" to
1193 match the prototype.
1194
1195 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1196
1197 * window.c: Remove declarations of Qwindow_size_fixed,
1198 window_min_size_1, window_min_size_2, window_min_size,
1199 size_window, window_fixed_size_p, enlarge_window, delete_window.
1200 Remove static from declaration of Qdelete_window, it's
1201 temporarily needed by Fbury_buffer.
1202 (replace_window): Don't assign orig_top_line and
1203 orig_total_lines.
1204 (Fdelete_window, delete_window): Remove. Window deletion is
1205 handled by window.el.
1206 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1207 Fdelete_window calls with calls to Qdelete_window.
1208 (Fdelete_other_windows): Remove. Deleting other windows is
1209 handled by window.el.
1210 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1211 handled in window.el.
1212 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1213 Window minimum sizes are handled in window.el.
1214 (shrink_windows, size_window, set_window_height)
1215 (set_window_width, change_window_heights, window_height)
1216 (window_width, CURBEG, CURSIZE, enlarge_window)
1217 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1218 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1219 handled in window.el.
1220 (make_dummy_parent): Rename to make_parent_window and give it a
1221 second argument horflag.
1222 (make_window): Don't set resize_proportionally any more.
1223 (Fsplit_window): Remove. Windows are split in window.el.
1224 (save_restore_action, save_restore_orig_size)
1225 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1226 Resize mini windows in window.el.
1227 (grow_mini_window, shrink_mini_window): Implement by calling
1228 Qresize_root_window_vertically, resize_window_check and
1229 resize_window_apply.
1230 (saved_window, Fset_window_configuration, save_window_save): Do
1231 not handle orig_top_line, orig_total_lines, and
1232 resize_proportionally.
1233 (window_min_height, window_min_width): Move to window.el.
1234 (keys_of_window): Move bindings for delete-other-windows,
1235 split-window, delete-window and enlarge-window to window.el.
1236
1237 * buffer.c: Temporarily extern Qdelete_window.
1238 (Fbury_buffer): Temporarily call Qdelete_window instead of
1239 Fdelete_window (Fbury_buffer will move to window.el soon).
1240
1241 * frame.c (set_menu_bar_lines_1): Remove code handling
1242 orig_top_line and orig_total_lines.
1243
1244 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1245 set_window_height but set heights directly.
1246 (change_frame_size_1): Use resize_frame_windows.
1247
1248 * xdisp.c (init_xdisp): Don't use set_window_height but set
1249 heights directly.
1250
1251 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1252 resize_frame_windows instead of change_window_heights and run
1253 run_window_configuration_change_hook.
1254
1255 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1256 instead of change_window_heights and run
1257 run_window_configuration_change_hook.
1258
1259 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1260
1261 * window.c (replace_window): Rename second argument REPLACEMENT to
1262 NEW. New third argument SETFLAG. Rewrite.
1263 (delete_window, make_dummy_parent): Call replace_window with
1264 third argument 1.
1265 (window_list_1): Move down in code.
1266 (run_window_configuration_change_hook): Move set_buffer part
1267 before select_frame_norecord part in order to unwind correctly.
1268 Rename count1 to count.
1269 (recombine_windows, delete_deletable_window, resize_root_window)
1270 (Fdelete_other_windows_internal)
1271 (Frun_window_configuration_change_hook, make_parent_window)
1272 (resize_window_check, resize_window_apply, Fresize_window_apply)
1273 (resize_frame_windows, Fsplit_window_internal)
1274 (Fdelete_window_internal, Fresize_mini_window_internal): New
1275 functions.
1276 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1277
1278 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1279
1280 * window.h (window): Add some new members to window structure -
1281 normal_lines, normal_cols, new_total, new_normal, clone_number,
1282 splits, nest, prev_buffers, next_buffers.
1283 (WINDOW_TOTAL_SIZE): Move here from window.c.
1284 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1285
1286 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1287 Remove.
1288 (make_dummy_parent): Set new members of windows structure.
1289 (make_window): Move down in code. Handle new members of window
1290 structure.
1291 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1292 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1293 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1294 (Fset_window_prev_buffers, Fwindow_next_buffers)
1295 (Fset_window_next_buffers, Fset_window_clone_number): New
1296 functions.
1297 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1298 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1299 Doc-string fixes.
1300 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1301 Argument WINDOW can be now internal window too.
1302 (Fwindow_use_time): Move up in code.
1303 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1304 Rewrite doc-string.
1305 (Fset_window_configuration, saved_window)
1306 (Fcurrent_window_configuration, save_window_save): Handle new
1307 members of window structure.
1308 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1309 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1310 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1311 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1312 Qget_mru_window, Qresize_root_window,
1313 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1314 Qauto_buffer_name; staticpro them.
1315
1316 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1317
1318 * window.c (Fwindow_total_size, Fwindow_left_column)
1319 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1320 (Fwindow_list_1): New functions.
1321 (window_box_text_cols): Replace with window_body_cols.
1322 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1323 window_body_cols instead of window_box_text_cols.
1324 (delete_window, Fset_window_configuration): Call
1325 delete_all_subwindows with window as argument.
1326 (delete_all_subwindows): Take a window as argument and not a
1327 structure. Rewrite.
1328 (window_loop): Remove handling of GET_LRU_WINDOW and
1329 GET_LARGEST_WINDOW.
1330 (Fget_lru_window, Fget_largest_window): Move to window.el.
1331
1332 * window.h: Extern window_body_cols instead of
1333 window_box_text_cols. delete_all_subwindows now takes a
1334 Lisp_Object as argument.
1335
1336 * indent.c (compute_motion, Fcompute_motion): Use
1337 window_body_cols instead of window_box_text_cols.
1338
1339 * frame.c (delete_frame): Call delete_all_subwindows with root
1340 window as argument.
1341
1342 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1343
1344 * fns.c (Fputhash): Document return value.
1345
1346 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1347
1348 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1349
1350 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1351
1352 Cons<->int and similar integer overflow fixes (Bug#8794).
1353
1354 Check for overflow when converting integer to cons and back.
1355 * charset.c (Fdefine_charset_internal, Fdecode_char):
1356 Use cons_to_unsigned to catch overflow.
1357 (Fencode_char): Use INTEGER_TO_CONS.
1358 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1359 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1360 * data.c (long_to_cons, cons_to_long): Remove.
1361 (cons_to_unsigned, cons_to_signed): New functions.
1362 These signal an error for invalid or out-of-range values.
1363 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1364 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1365 * font.c (Ffont_variation_glyphs):
1366 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1367 * lisp.h: Include <intprops.h>.
1368 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1369 (cons_to_signed, cons_to_unsigned): New decls.
1370 (long_to_cons, cons_to_long): Remove decls.
1371 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1372 (Fprimitive_undo): Use CONS_TO_INTEGER.
1373 * xfns.c (Fx_window_property): Likewise.
1374 * xselect.c: Include <limits.h>.
1375 (x_own_selection, selection_data_to_lisp_data):
1376 Use INTEGER_TO_CONS.
1377 (x_handle_selection_request, x_handle_selection_clear)
1378 (x_get_foreign_selection, Fx_disown_selection_internal)
1379 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1380 (lisp_data_to_selection_data): Use cons_to_unsigned.
1381 (x_fill_property_data): Use cons_to_signed.
1382 Report values out of range.
1383
1384 Check for buffer and string overflow more precisely.
1385 * buffer.h (BUF_BYTES_MAX): New macro.
1386 * lisp.h (STRING_BYTES_MAX): New macro.
1387 * alloc.c (Fmake_string):
1388 * character.c (string_escape_byte8):
1389 * coding.c (coding_alloc_by_realloc):
1390 * doprnt.c (doprnt):
1391 * editfns.c (Fformat):
1392 * eval.c (verror):
1393 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1394 since they may not be the same number.
1395 * editfns.c (Finsert_char):
1396 * fileio.c (Finsert_file_contents):
1397 Likewise for BUF_BYTES_MAX.
1398
1399 * image.c: Use ptrdiff_t, not int, for sizes.
1400 (slurp_file): Switch from int to ptrdiff_t.
1401 All uses changed.
1402 (slurp_file): Check that file size fits in both size_t (for
1403 malloc) and ptrdiff_t (for sanity and safety).
1404
1405 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1406 if b->modtime has its maximal value.
1407
1408 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1409
1410 Don't assume time_t can fit into int.
1411 * buffer.h (struct buffer.modtime): Now time_t, not int.
1412 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1413 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1414
1415 Minor fixes for signed vs unsigned integers.
1416 * character.h (MAYBE_UNIFY_CHAR):
1417 * charset.c (maybe_unify_char):
1418 * keyboard.c (read_char, reorder_modifiers):
1419 XINT -> XFASTINT, since the integer must be nonnegative.
1420 * ftfont.c (ftfont_spec_pattern):
1421 * keymap.c (access_keymap, silly_event_symbol_error):
1422 XUINT -> XFASTINT, since the integer must be nonnegative.
1423 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1424 since it makes no difference and we prefer signed.
1425 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1426 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1427 nonnegative.
1428
1429 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1430
1431 * window.h (Fwindow_frame): Declare.
1432
1433 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1434
1435 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1436 (SPARE_MEMORY): Always define.
1437 (LARGE_REQUEST): Remove.
1438 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1439
1440 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1441
1442 * lisp.h: Move EXFUNS for Fframe_root_window,
1443 Fframe_first_window and Fset_frame_selected_window to window.h.
1444
1445 * window.h: Move EXFUNS for Fframe_root_window,
1446 Fframe_first_window and Fset_frame_selected_window here from
1447 lisp.h.
1448
1449 * frame.c (Fwindow_frame, Fframe_first_window)
1450 (Fframe_root_window, Fframe_selected_window)
1451 (Fset_frame_selected_window): Move to window.c.
1452 (Factive_minibuffer_window): Move to minibuf.c.
1453 (Fother_visible_frames_p): New function.
1454
1455 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1456
1457 * window.c (decode_window, decode_any_window): Move up in code.
1458 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1459 (inhibit_frame_unsplittable): Remove unused variable.
1460 (Fwindow_buffer): Move up and rewrite doc-string.
1461 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1462 (Fwindow_prev): New functions.
1463 (Fwindow_frame): Move here from frame.c. Accept any window as
1464 argument.
1465 (Fframe_root_window, Fframe_first_window)
1466 (Fframe_selected_window): Move here from frame.c. Accept frame
1467 or arbitrary window as argument. Update doc-strings.
1468 (Fminibuffer_window): Move up in code.
1469 (Fwindow_minibuffer_p): Move up in code and simplify.
1470 (Fset_frame_selected_window): Move here from frame.c.
1471 Marginal rewrite.
1472 (Fselected_window, select_window, Fselect_window): Move up in
1473 code. Minor doc-string fixes.
1474
1475 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1476
1477 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1478 Do not assume that spare memory exists; that assumption is valid
1479 only if SYSTEM_MALLOC.
1480 (LARGE_REQUEST): New macro, so that the issue of large requests
1481 is separated from the issue of spare memory.
1482
1483 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1484
1485 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1486 format. (Bug#8806)
1487
1488 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1489
1490 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1491 before statements.
1492
1493 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1494
1495 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1496
1497 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1498
1499 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1500 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1501
1502 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1503
1504 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1505
1506 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1507
1508 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1509 (x_clipboard_manager_save): Add return value.
1510 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1511 New error handlers.
1512 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1513 Obey Vx_select_enable_clipboard_manager. Catch errors in
1514 x_clipboard_manager_save (Bug#8779).
1515 (Vx_select_enable_clipboard_manager): New variable.
1516 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1517
1518 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1519
1520 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1521
1522 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1523
1524 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1525 in the current matrix if keep_current_p is non-zero.
1526
1527 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1528
1529 * bidi.c (bidi_level_of_next_char): Fix last change.
1530
1531 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1532
1533 Support bidi reordering of text covered by display properties.
1534
1535 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1536 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1537 (bidi_cache_search, bidi_cache_iterator_state)
1538 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1539 (bidi_level_of_next_char, bidi_move_to_visually_next):
1540 Support character positions inside a run of characters covered by a
1541 display string.
1542 (bidi_paragraph_init, bidi_resolve_explicit_1)
1543 (bidi_level_of_next_char): Call bidi_fetch_char and
1544 bidi_fetch_char_advance instead of FETCH_CHAR and
1545 FETCH_CHAR_ADVANCE.
1546 (bidi_init_it): Initialize new members.
1547 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1548 definitions.
1549 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1550 instead of using explicit *_CHAR codes.
1551 (bidi_resolve_explicit, bidi_resolve_weak):
1552 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1553 bidirectional text is supported only in multibyte buffers.
1554 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1555 it to initialize the frame_window_p member of struct bidi_it.
1556 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1557 (bidi_resolve_explicit, bidi_resolve_weak)
1558 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1559 bidi_it->nchars is non-positive.
1560 (bidi_level_of_next_char): Don't try to lookup the cache for the
1561 next/previous character if nothing is cached there yet, or if we
1562 were just reseat()'ed to a new position.
1563
1564 * xdisp.c (set_cursor_from_row): Set start and stop points
1565 according to the row's direction when priming the loop that looks
1566 for the glyph on which to display cursor.
1567 (single_display_spec_intangible_p): Function deleted.
1568 (display_prop_intangible_p): Reimplement to call
1569 handle_display_spec instead of single_display_spec_intangible_p.
1570 Accept 3 additional arguments needed by handle_display_spec.
1571 This fixes incorrect cursor motion across display property with complex
1572 values: lists, `(when COND...)' forms, etc.
1573 (single_display_spec_string_p): Support property values that are
1574 lists with the argument STRING its top-level element.
1575 (display_prop_string_p): Fix the condition for processing a
1576 property that is a list to be consistent with handle_display_spec.
1577 (handle_display_spec): New function, refactored from the
1578 last portion of handle_display_prop.
1579 (compute_display_string_pos): Accept additional argument
1580 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1581 value of a `display' property is a "replacing spec".
1582 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1583 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1584 the display property, but just return a value indicating whether
1585 the display property will replace the characters it covers.
1586 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1587 frame_window_p members of struct bidi_it.
1588 (compute_display_string_pos, compute_display_string_end):
1589 New functions.
1590 (push_it): Accept second argument POSITION, where pop_it should
1591 jump to continue iteration.
1592 (reseat_1): Initialize bidi_it.disp_pos.
1593
1594 * keyboard.c (adjust_point_for_property): Adjust the call to
1595 display_prop_intangible_p to its new signature.
1596
1597 * dispextern.h (struct bidi_it): New member frame_window_p.
1598 (bidi_init_it): Update prototypes.
1599 (display_prop_intangible_p): Update prototype.
1600 (compute_display_string_pos, compute_display_string_end):
1601 Declare prototypes.
1602 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1603 EMACS_INT.
1604
1605 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1606
1607 Malloc failure behavior now depends on size of allocation.
1608 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1609 * lisp.h: Change signatures accordingly.
1610 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1611 All callers changed. (Bug#8762)
1612
1613 * gnutls.c: Use Emacs's memory allocators.
1614 Without this change, the gnutls library would invoke malloc etc.
1615 directly, which causes problems on non-SYNC_INPUT hosts, and which
1616 runs afoul of improving memory_full behavior. (Bug#8761)
1617 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1618 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1619 xfree instead of the default malloc, realloc, free.
1620 (Fgnutls_boot): No need to check for memory allocation failure,
1621 since xmalloc does that for us.
1622
1623 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1624 * category.c (hash_get_category_set):
1625 * ccl.c (ccl_driver):
1626 * charset.c (Fdefine_charset_internal):
1627 * charset.h (struct charset.hash_index):
1628 * composite.c (get_composition_id, gstring_lookup_cache)
1629 (composition_gstring_put_cache):
1630 * composite.h (struct composition.hash_index):
1631 * dispextern.h (struct image.hash):
1632 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1633 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1634 (hashfn_equal, hashfn_user_defined, make_hash_table)
1635 (maybe_resize_hash_table, hash_lookup, hash_put)
1636 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1637 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1638 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1639 * image.c (make_image, search_image_cache, lookup_image)
1640 (xpm_put_color_table_h):
1641 * lisp.h (struct Lisp_Hash_Table):
1642 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1643 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1644 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1645 * alloc.c (allocate_vectorlike):
1646 Check for overflow in vector size calculations.
1647 * ccl.c (ccl_driver):
1648 Check for overflow when converting EMACS_INT to int.
1649 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1650 need to be updated by these changes.
1651 * fns.c (make_hash_table, maybe_resize_hash_table):
1652 Check for integer overflow with large hash tables.
1653 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1654 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1655 (SXHASH_REDUCE): New macro.
1656 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1657 Use it instead of discarding useful hash info with large hash values.
1658 (sxhash_float): New function.
1659 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1660 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1661 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1662 Rewrite to use FIXNUM_BITS, as this simplifies things.
1663 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1664 Adjust signatures to match updated version of code.
1665 (consing_since_gc): Now EMACS_INT, since a single hash table can
1666 use more than INT_MAX bytes.
1667
1668 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1669
1670 Make it possible to build with GCC-4.6+ -O2 -flto.
1671
1672 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1673
1674 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1675
1676 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1677 Call minibuffer-inactive-mode.
1678
1679 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1680
1681 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1682 Update dependencies.
1683
1684 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1685
1686 * data.c (init_data): Remove code for UTS, this system is not
1687 supported anymore.
1688
1689 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1690
1691 Don't force ./temacs to start in terminal mode.
1692
1693 * frame.c (make_initial_frame): Initialize faces in all cases, not
1694 only when CANNOT_DUMP is defined.
1695 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1696
1697 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1698
1699 * dispnew.c (add_window_display_history): Use const for the string
1700 pointer. Remove declaration, not needed.
1701
1702 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1703
1704 Use 'inline', not 'INLINE'.
1705 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1706 * alloc.c, fontset.c (INLINE): Remove.
1707 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1708 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1709 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1710 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1711 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1712
1713 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1714
1715 Make it possible to run ./temacs.
1716
1717 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1718 syms_of_callproc does the same thing. Remove test for
1719 "initialized", do it in the caller.
1720 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1721
1722 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1723
1724 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1725 (read_minibuf): Use get_minibuffer.
1726 (syms_of_minibuf): Use DEFSYM.
1727 (Qmetadata): New var.
1728 * data.c (Qbuffer): Don't make it static.
1729 (syms_of_data): Use DEFSYM.
1730
1731 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1732
1733 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1734 (CCL_CODE_MIN): New macro.
1735
1736 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1737
1738 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1739
1740 * eval.c (Qdebug): Now static.
1741 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1742 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1743 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1744
1745 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1746
1747 * image.c: Various fixes to ImageMagick code comments.
1748 (Fimagemagick_types): Doc fix.
1749
1750 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1751
1752 Minor fixes prompted by GCC 4.6.0 warnings.
1753
1754 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1755
1756 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1757 (x_clipboard_manager_save_all): Move extern decl to ...
1758 * xterm.h: ... here, so that it can be checked for consistency.
1759
1760 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1761
1762 * xselect.c (x_clipboard_manager_save_frame)
1763 (x_clipboard_manager_save_all): New functions.
1764 (Fx_clipboard_manager_save): Lisp function deleted.
1765
1766 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1767 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1768
1769 * xterm.h: Update prototype.
1770
1771 2011-05-28 William Xu <william.xwl@gmail.com>
1772
1773 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1774 exiting (Bug#8239).
1775
1776 2011-05-28 Jim Meyering <meyering@redhat.com>
1777
1778 Avoid a sign-extension bug in crypto_hash_function.
1779 * fns.c (to_uchar): Define.
1780 (crypto_hash_function): Use it to convert some newly-signed
1781 variables to unsigned, to avoid sign-extension bugs. For example,
1782 without this change, (md5 "truc") would evaluate to
1783 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1784 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1785 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1786
1787 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1788
1789 Integer overflow fixes.
1790
1791 * dbusbind.c: Serial number integer overflow fixes.
1792 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1793 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1794 to hold a serial number that is too large for a fixnum.
1795 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1796 Check for serial numbers out of range. Decode any serial number
1797 that was so large that it became a float. (Bug#8722)
1798
1799 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1800 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1801 Use XFASTINT rather than XUINT when numbers are nonnegative.
1802 (xd_append_arg, Fdbus_method_return_internal):
1803 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1804 arguments, check that Lisp number is nonnegative, rather than
1805 silently wrapping negative numbers around. (Bug#8722)
1806 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1807 (Bug#8722)
1808
1809 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1810
1811 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1812
1813 ccl: add integer overflow checks
1814 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1815 (IN_INT_RANGE): New macros.
1816 (ccl_driver): Use them to check for integer overflow when
1817 decoding a CCL program. Many of the new checks are whether XINT (x)
1818 fits in int; it doesn't always, on 64-bit hosts. The new version
1819 doesn't catch all possible integer overflows, but it's an
1820 improvement. (Bug#8719)
1821
1822 * alloc.c (make_event_array): Use XINT, not XUINT.
1823 There's no need for unsigned here.
1824
1825 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1826 This follows up to the 2011-05-06 change that substituted uintptr_t
1827 for EMACS_INT. This case wasn't caught back then.
1828
1829 Rework Fformat to avoid integer overflow issues.
1830 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1831 now (part of C89). Include <verify.h>.
1832 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1833 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1834 (Fformat): Avoid the prepass trying to compute sizes; it was only
1835 approximate and thus did not catch overflow reliably. Instead, walk
1836 through the format just once, formatting and computing sizes as we go,
1837 checking for integer overflow at every step, and allocating a larger
1838 buffer as needed. Keep track separately whether the format is
1839 multibyte. Keep only the most-recently calculated precision, rather
1840 than them all. Record whether each argument has been converted to
1841 string. Use EMACS_INT, not int, for byte and char and arg counts.
1842 Support field widths and precisions larger than INT_MAX. Avoid
1843 sprintf's undefined behavior with conversion specifications such as %#d
1844 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1845 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1846 formatting out-of-range floating point numbers with int
1847 formats. (Bug#8668)
1848
1849 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1850
1851 * data.c: Avoid integer truncation in expressions involving floats.
1852 * data.c: Include <intprops.h>.
1853 (arith_driver): When there's an integer overflow in an expression
1854 involving floating point, convert the integers to floating point
1855 so that the resulting value does not suffer from catastrophic
1856 integer truncation. For example, on a 64-bit host (* 4
1857 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1858 Do not rely on undefined behavior after integer overflow.
1859
1860 merge count_size_as_multibyte, parse_str_to_multibyte
1861 * character.c, character.h (count_size_as_multibyte):
1862 Rename from parse_str_to_multibyte; all uses changed.
1863 Check for integer overflow.
1864 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1865 since it's now a duplicate of the other. This is more of
1866 a character than a buffer op, so better that it's in character.c.
1867 * fns.c, print.c: Adjust to above changes.
1868
1869 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1870
1871 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1872
1873 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1874
1875 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1876 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1877 (x_clipboard_manager_save): Now static.
1878 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1879
1880 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1881 (crypto_hash_function): Now static.
1882 Fix pointer signedness problems. Avoid unnecessary initializations.
1883
1884 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1885
1886 * termhooks.h (Vselection_alist): Make it terminal-local.
1887
1888 * terminal.c (create_terminal): Initialize it.
1889
1890 * xselect.c: Support for clipboard managers.
1891 (Vselection_alist): Move to termhooks.h as terminal-local var.
1892 (LOCAL_SELECTION): New macro.
1893 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1894 (symbol_to_x_atom): Remove gratuitous arg.
1895 (x_handle_selection_request, lisp_data_to_selection_data)
1896 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1897 (x_own_selection, x_get_local_selection, x_convert_selection):
1898 New arg, specifying work frame. Use terminal-local Vselection_alist.
1899 (some_frame_on_display): Delete unused function.
1900 (Fx_own_selection_internal, Fx_get_selection_internal)
1901 (Fx_disown_selection_internal, Fx_selection_owner_p)
1902 (Fx_selection_exists_p): New optional frame arg.
1903 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1904 (x_handle_selection_clear): Don't treat other terminals with the
1905 same keyboard specially. Use the terminal-local Vselection_alist.
1906 (x_clear_frame_selections): Use Frun_hook_with_args.
1907
1908 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1909
1910 * xterm.h: Add support for those atoms.
1911
1912 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1913
1914 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1915 (converted_selections, conversion_fail_tag): New global variables.
1916 (x_selection_request_lisp_error): Free the above.
1917 (x_get_local_selection): Remove unnecessary code.
1918 (x_reply_selection_request): Args changed; handle arbitrary array
1919 of converted selections stored in converted_selections.
1920 Separate the XChangeProperty and SelectionNotify steps.
1921 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1922 (x_convert_selection): New function.
1923 (x_handle_selection_event): Simplify.
1924 (x_get_foreign_selection): Don't ignore incoming requests while
1925 waiting for an answer; this will fail when we implement
1926 SAVE_TARGETS, and seems unnecessary anyway.
1927 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1928 (Vx_sent_selection_functions): Doc fix.
1929
1930 2011-05-26 Leo Liu <sdl.web@gmail.com>
1931
1932 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1933
1934 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1935
1936 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1937
1938 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1939 for fringe update if it has periodic bitmap.
1940 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1941 and fringe_bitmap_periodic_p.
1942
1943 * fringe.c (get_fringe_bitmap_data): New function.
1944 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1945 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1946 row. Mark glyph row for fringe update if periodicity changed.
1947
1948 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1949 for fringe update unless it has periodic bitmap.
1950
1951 2011-05-25 Kenichi Handa <handa@m17n.org>
1952
1953 * xdisp.c (get_next_display_element): Set correct it->face_id for
1954 a static composition.
1955
1956 2011-05-24 Leo Liu <sdl.web@gmail.com>
1957
1958 * deps.mk (fns.o):
1959 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1960
1961 * fns.c (crypto_hash_function, Fsha1): New function.
1962 (Fmd5): Use crypto_hash_function.
1963 (syms_of_fns): Add Ssha1.
1964
1965 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1966
1967 * gnutls.c: Remove unused macros.
1968 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1969 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1970 Remove macros that are defined and never used.
1971 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1972
1973 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1974
1975 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1976 (Fx_get_selection_internal): Minor cleanup.
1977 (Fx_own_selection_internal): Rename arguments for consistency with
1978 select.el.
1979
1980 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1981
1982 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1983
1984 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1985
1986 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1987
1988 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1989
1990 * dispnew.c (scrolling_window): Don't exclude the case that the
1991 last enabled row in the desired matrix touches the bottom boundary.
1992
1993 2011-05-21 Glenn Morris <rgm@gnu.org>
1994
1995 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1996 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1997 and add some more files.
1998
1999 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2000
2001 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2002 report_file_error introduced by the change from 2011-05-07.
2003
2004 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2005
2006 * systime.h (Time): Define only if emacs is defined.
2007 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2008 where the include path doesn't have X11/X.h by default. See
2009 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2010
2011 2011-05-20 Kenichi Handa <handa@m17n.org>
2012
2013 * composite.c (find_automatic_composition): Fix previous change.
2014
2015 2011-05-20 Glenn Morris <rgm@gnu.org>
2016
2017 * lisp.mk: New file, split from Makefile.in.
2018 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2019 (shortlisp): Remove.
2020 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2021
2022 2011-05-19 Glenn Morris <rgm@gnu.org>
2023
2024 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2025 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2026 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2027 (lisp): Set the order to that of loadup.el.
2028 (shortlisp): Make it a copy of $lisp.
2029 (SOME_MACHINE_LISP): Remove.
2030 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2031 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2032
2033 2011-05-18 Kenichi Handa <handa@m17n.org>
2034
2035 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2036 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2037 (find_automatic_composition): Mostly rewrite for efficiency.
2038
2039 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2040
2041 * makefile.w32-in: Update dependencies.
2042
2043 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2044
2045 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2046 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2047
2048 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2049
2050 Fix some integer overflow issues, such as string length overflow.
2051
2052 * insdel.c (count_size_as_multibyte): Check for string overflow.
2053
2054 * character.c (lisp_string_width): Check for string overflow.
2055 Use EMACS_INT, not int, for string indexes and lengths; in
2056 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2057 the resulting string length overflows an EMACS_INT; instead,
2058 report a string overflow if no precision given. When checking for
2059 precision exhaustion, use a check that cannot possibly have
2060 integer overflow. (Bug#8675)
2061 * character.h (lisp_string_width): Adjust to new signature.
2062
2063 * alloc.c (string_overflow): New function.
2064 (Fmake_string): Use it. This doesn't change behavior, but saves
2065 a few bytes and will simplify future changes.
2066 * character.c (string_escape_byte8): Likewise.
2067 * lisp.h (string_overflow): New decl.
2068
2069 Fixups, following up to the user-interface timestamp change.
2070 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2071 for UI timestamps, instead of unsigned long.
2072 * msdos.c (mouse_get_pos): Likewise.
2073 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2074 * w32gui.h (Time): Define by including "systime.h" rather than by
2075 declaring it ourselves. (Bug#8664)
2076
2077 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2078 * image.c (clear_image_cache): Likewise.
2079
2080 * term.c (term_mouse_position): Don't assume time_t wraparound.
2081
2082 Be more systematic about user-interface timestamps.
2083 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2084 and sometimes 'EMACS_UINT', to represent these timestamps.
2085 This change causes it to use 'Time' uniformly, as that's what X uses.
2086 This makes the code easier to follow, and makes it easier to catch
2087 integer overflow bugs such as Bug#8664.
2088 * frame.c (Fmouse_position, Fmouse_pixel_position):
2089 Use Time, not unsigned long, for user-interface timestamps.
2090 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2091 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2092 * keyboard.h (last_event_timestamp): Likewise.
2093 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2094 * menu.h (xmenu_show): Likewise.
2095 * term.c (term_mouse_position): Likewise.
2096 * termhooks.h (struct input_event.timestamp): Likewise.
2097 (struct terminal.mouse_position_hook): Likewise.
2098 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2099 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2100 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2101 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2102 what it was before.
2103 * menu.h, termhooks.h: Include "systime.h", for Time.
2104
2105 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2106 Don't assume that the difference between two unsigned long values
2107 can fit into an integer. At this point, we know button_down_time
2108 <= event->timestamp, so the difference must be nonnegative, so
2109 there's no need to cast the result if double-click-time is
2110 nonnegative, as it should be; check that it's nonnegative, just in
2111 case. This bug is triggered when events are more than 2**31 ms
2112 apart (about 25 days). (Bug#8664)
2113
2114 * xselect.c (last_event_timestamp): Remove duplicate decl.
2115 (x_own_selection): Remove needless cast to unsigned long.
2116
2117 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2118 that always fit in int. Use a sentinel instead of a counter, to
2119 avoid a temp and to allay GCC's concerns about possible int overflow.
2120 * frame.h (struct frame): Use int for menu_bar_items_used
2121 instead of EMACS_INT, since it always fits in int.
2122
2123 * menu.c (grow_menu_items): Check for int overflow.
2124
2125 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2126
2127 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2128 Before, the code was not consistent. These values cannot exceed
2129 2**31 - 1 so there's no need to make them unsigned.
2130 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2131 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2132 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2133 as modifiers.
2134 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2135
2136 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2137 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2138 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2139 presumably because the widths might not match.
2140
2141 * window.c (size_window): Avoid needless test at loop start.
2142
2143 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2144
2145 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2146
2147 2011-05-12 Drew Adams <drew.adams@oracle.com>
2148
2149 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2150
2151 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2152
2153 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2154 `width' to `bar_area_x' and `bar_area_width', respectively.
2155 (x_scroll_run): Take account of fringe background extension.
2156
2157 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2158 Rename local vars `left' and `width' to `bar_area_x' and
2159 `bar_area_width', respectively.
2160 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2161 background extension.
2162
2163 2011-05-10 Jim Meyering <meyering@redhat.com>
2164
2165 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2166
2167 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2168
2169 * image.c (Finit_image_library): Return t for built-in image types,
2170 like pbm and xbm. (Bug#8640)
2171
2172 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2173
2174 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2175
2176 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2177
2178 * w32console.c (Fset_screen_color): Doc fix.
2179 (Fget_screen_color): New function.
2180 (syms_of_ntterm): Defsubr it.
2181
2182 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2183 unlink the temporary file if Fcall_process didn't create it in the
2184 first place.
2185 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2186 child process will be redirected to a file specified with `:file'.
2187 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2188 cue to call_process_cleanup not to close that handle.
2189
2190 2011-05-07 Ben Key <bkey76@gmail.com>
2191
2192 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2193 one of two shell specific rules, either bootstrap-temacs-CMD or
2194 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2195 to the previous implementation of the bootstrap-temacs rule.
2196 The bootstrap-temacs-CMD rule is similar to the previous
2197 implementation of the bootstrap-temacs rule except that it
2198 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2199 variable.
2200
2201 These changes, along with some changes to nt/configure.bat,
2202 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2203 earlier fix to add support for --cflags and --ldflags options
2204 that include quotes so that it works whether make uses cmd or
2205 sh as the shell.
2206
2207 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2208
2209 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2210 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2211 is a constant.
2212 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2213 a string. Handle both cases.
2214 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2215 (Fdbus_register_method): Use Qinvalid_function.
2216
2217 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2218
2219 * makefile.w32-in: Update dependencies.
2220 (LISP_H): Add inttypes.h and stdin.h.
2221 (PROCESS_H): Add unistd.h.
2222
2223 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2224
2225 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2226 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2227
2228 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2229
2230 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2231
2232 * term.c (vfatal): Remove stray call to va_end.
2233 It's not needed and the C Standard doesn't allow it here anyway.
2234
2235 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2236 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2237
2238 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2239 bytes.
2240
2241 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2242
2243 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2244
2245 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2246
2247 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2248
2249 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2250
2251 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2252 * charset.c (Fdefine_charset_internal): Don't initialize
2253 charset.code_space[15]. The value was garbage, on hosts with
2254 32-bit int (Bug#8600).
2255
2256 * lread.c (read_integer): Be more consistent with string-to-number.
2257 Use string_to_number to do the actual conversion; this avoids
2258 rounding errors and fixes some other screwups. Without this fix,
2259 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2260 (digit_to_number): Move earlier, for benefit of read_integer.
2261 Return -1 if the digit is out of range for the base, -2 if it is
2262 not a digit in any supported base. (Bug#8602)
2263
2264 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2265
2266 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2267 to match comment at start of function. This also removes a
2268 GCC warning about overflow in a 32+64-bit port.
2269
2270 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2271
2272 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2273 Reported by Stefan Monnier in
2274 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2275 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2276 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2277
2278 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2279 (EMACS_UINTPTR): Likewise, with uintptr_t.
2280
2281 * lisp.h: Prefer 64-bit EMACS_INT if available.
2282 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2283 on 32-bit hosts that have 64-bit int, so that they can access
2284 large files.
2285 However, temporarily disable this change unless the temporary
2286 symbol WIDE_EMACS_INT is defined.
2287
2288 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2289
2290 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2291 This removes an assumption that EMACS_INT and long are the same
2292 width as pointers. The assumption is true for Emacs porting targets
2293 now, but we want to make other targets possible.
2294 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2295 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2296 In the rest of the code, change types of integers that hold casted
2297 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2298 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2299 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2300 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2301 No need to cast type when ORing.
2302 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2303 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2304 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2305 assume EMACS_INT is the same width as char *.
2306 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2307 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2308 Remove no-longer-needed casts.
2309 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2310 (xg_tool_bar_help_callback, xg_make_tool_item):
2311 Use EMACS_INTPTR to hold an integer
2312 that will be cast to void *; this can avoid a GCC warning
2313 if EMACS_INT is not the same width as void *.
2314 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2315 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2316 (current_message_1, set_message_1):
2317 Use a local to convert to proper width without a cast.
2318 * xmenu.c (dialog_selection_callback): Likewise.
2319
2320 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2321 Also, don't assume VALBITS / RAND_BITS is less than 5,
2322 and don't rely on undefined behavior when shifting a 1 left into
2323 the sign bit.
2324 * lisp.h (get_random): Change signature to match.
2325
2326 * lread.c (hash_string): Use size_t, not int, for hash computation.
2327 Normally we prefer signed values; but hashing is special, because
2328 it's better to use unsigned division on hash table sizes so that
2329 the remainder is nonnegative. Also, size_t is the natural width
2330 for hashing into memory. The previous code used 'int', which doesn't
2331 retain enough info to hash well into very large tables.
2332 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2333
2334 * dbusbind.c: Don't possibly lose pointer info when converting.
2335 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2336 Use XPNTR rather than XHASH, so that the high-order bits of
2337 the pointer aren't lost when converting through void *.
2338
2339 * eval.c (Fautoload): Don't double-shift a pointer.
2340
2341 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2342
2343 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2344
2345 * gnutls.c (DEF_GNUTLS_FN):
2346 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2347
2348 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2349
2350 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2351 marker. (Bug#8610)
2352
2353 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2354
2355 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2356 New version that can reserve upto 2GB of heap space.
2357
2358 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2359
2360 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2361
2362 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2363
2364 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2365 `gnutls_certificate_set_x509_key_file'.
2366
2367 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2368
2369 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2370 Update dependencies.
2371
2372 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2373
2374 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2375 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2376 Remove unused parameter `fildes'.
2377 * process.c (read_process_output, send_process): Don't pass it.
2378
2379 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2380
2381 Fix previous change: the library cache is defined in w32.c.
2382 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2383 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2384
2385 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2386
2387 Implement dynamic loading of GnuTLS on Windows.
2388
2389 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2390 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2391 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2392 Declare.
2393
2394 * gnutls.c (Qgnutls_dll): Define.
2395 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2396 (gnutls_*): Declare function pointers.
2397 (init_gnutls_functions): New function to initialize function pointers.
2398 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2399 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2400 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2401 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2402 (emacs_gnutls_write, emacs_gnutls_read)
2403 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2404 (Fgnutls_available_p): New function.
2405 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2406 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2407 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2408
2409 * image.c: Include w32.h.
2410 (Vimage_type_cache): Delete.
2411 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2412 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2413 (w32_delayed_load): Move to w32.c.
2414
2415 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2416
2417 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2418 (w32_delayed_load): Move from image.c. When loading a library, record
2419 its filename in the :loaded-from property of the library id.
2420 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2421 Initialize and staticpro them.
2422 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2423
2424 * process.c: Include lisp.h before w32.h, not after.
2425 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2426 instead of gnutls_record_check_pending.
2427
2428 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2429
2430 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2431
2432 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2433 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2434 as passed in.
2435
2436 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2437
2438 * xterm.c (x_set_frame_alpha): Do not set property on anything
2439 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2440
2441 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2442
2443 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2444
2445 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2446
2447 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2448 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2449 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2450 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2451 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2452 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2453 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2454 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2455 (Qgnutls_bootprop_callbacks_verify): Make static.
2456
2457 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2458
2459 * callproc.c: Indentation fixup.
2460
2461 * sysdep.c (wait_for_termination_1): Make static.
2462 (wait_for_termination, interruptible_wait_for_termination):
2463 Move after wait_for_termination_1.
2464
2465 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2466
2467 * sysdep.c (interruptible_wait_for_termination): New function
2468 which is like wait_for_termination, but allows keyboard
2469 interruptions.
2470
2471 * callproc.c (Fcall_process): Add (:file "file") as an option for
2472 the STDOUT buffer.
2473 (Fcall_process_region): Ditto.
2474
2475 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2476
2477 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2478 rather than `XVECTOR (FOO)->size'.
2479
2480 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2481 inttypes.h, as a gnulib replacement is used if it not available in
2482 system headers.
2483
2484 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2485
2486 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2487 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2488 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2489
2490 * coding.c (coding_alloc_by_realloc): Error out if destination
2491 will grow beyond MOST_POSITIVE_FIXNUM.
2492 (decode_coding_emacs_mule): Abort if there isn't enough place in
2493 charbuf for the composition carryover bytes. Reserve an extra
2494 space for up to 2 characters produced in a loop.
2495 (decode_coding_iso_2022): Abort if there isn't enough place in
2496 charbuf for the composition carryover bytes.
2497
2498 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2499
2500 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2501 aborting when %lld or %lll format is passed.
2502 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2503 %llo or %llx format is passed. (Bug#8545)
2504
2505 * window.c (window_scroll_line_based): Use a marker instead of
2506 simple variables to record original value of point. (Bug#7952)
2507
2508 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2509 produced by %s or %c overflows available buffer space. (Bug#8545)
2510
2511 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2512
2513 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2514 (SIZE_MAX): Move defn after all includes, as they might #define it.
2515
2516 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2517
2518 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2519
2520 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2521
2522 * keyboard.c (Qdelayed_warnings_hook): Define.
2523 (command_loop_1): Run `delayed-warnings-hook'
2524 if Vdelayed_warnings_list is non-nil.
2525 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2526 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2527
2528 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2529
2530 * doprnt.c (doprnt): Don't return value smaller than the buffer
2531 size if the message was truncated. (Bug#8545).
2532
2533 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2534
2535 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2536 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2537
2538 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2539
2540 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2541
2542 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2543
2544 * makefile.w32-in: Update dependencies.
2545
2546 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2547
2548 Improve `doprnt' and its usage. (Bug#8545)
2549 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2550 `format_end'. Remove support for %l as a conversion specifier.
2551 Don't use xrealloc. Improve diagnostics when the %l size modifier
2552 is used. Update the commentary.
2553
2554 * eval.c (verror): Simplify calculation of size_t.
2555
2556 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2557 messages.
2558
2559 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2560
2561 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2562 change.
2563
2564 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2565
2566 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2567 This makes this file independent of the recent pseudovector change.
2568
2569 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2570
2571 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2572
2573 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2574 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2575 Remove unused local.
2576 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2577
2578 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2579 GCC 4.6.0 optimizes based on type-based alias analysis.
2580 For example, if b is of type struct buffer * and v of type struct
2581 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2582 != &v->size, and therefore "v->size = 1; b->size = 2; return
2583 v->size;" must therefore return 1. This assumption is incorrect
2584 for Emacs, since it type-puns struct Lisp_Vector * with many other
2585 types. To fix this problem, this patch adds a new type struct
2586 vectorlike_header that documents the constraints on layout of vectors
2587 and pseudovectors, and helps optimizing compilers not get fooled
2588 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2589 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2590 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2591 the size member.
2592 (XSETPVECTYPE): Rewrite in terms of new macro.
2593 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2594 This is a bit clearer, and further avoids the possibility of
2595 undesirable aliasing.
2596 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2597 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2598 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2599 since Lisp_Subr is a special case (no "next" field).
2600 (ASIZE): Now uses header.size rather than size.
2601 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2602 to avoid the hassle of writing XVECTOR (foo)->header.size.
2603 (struct vectorlike_header): New type.
2604 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2605 object, to help avoid aliasing.
2606 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2607 (SUBRP): Likewise, since Lisp_Subr is a special case.
2608 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2609 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2610 (struct Lisp_Hash_Table): Combine first two members into a single
2611 struct vectorlike_header member. All uses of "size" and "next" members
2612 changed to be "header.size" and "header.next".
2613 * buffer.h (struct buffer): Likewise.
2614 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2615 * frame.h (struct frame): Likewise.
2616 * process.h (struct Lisp_Process): Likewise.
2617 * termhooks.h (struct terminal): Likewise.
2618 * window.c (struct save_window_data, struct saved_window): Likewise.
2619 * window.h (struct window): Likewise.
2620 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2621 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2622 * buffer.c (init_buffer_once): Likewise.
2623 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2624 special case.
2625 * process.c (Fformat_network_address): Use local var for size,
2626 for brevity.
2627
2628 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2629
2630 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2631 * data.c (atof): Remove decl; no longer used or needed.
2632 (digit_to_number): Move to lread.c.
2633 (Fstring_to_number): Use new string_to_number function, to be
2634 consistent with how the Lisp reader treats infinities and NaNs.
2635 Do not assume that floating-point numbers represent EMACS_INT
2636 without losing information; this is not true on most 64-bit hosts.
2637 Avoid double-rounding errors, by insisting on integers when
2638 parsing non-base-10 numbers, as the documentation specifies.
2639 * lisp.h (string_to_number): New decl, replacing ...
2640 (isfloat_string): Remove.
2641 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2642 (read1): Do not accept +. and -. as integers; this
2643 appears to have been a coding error. Similarly, do not accept
2644 strings like +-1e0 as floating point numbers. Do not report
2645 overflow for integer overflows unless the base is not 10 which
2646 means we have no simple and reliable way to continue.
2647 Break out the floating-point parsing into a new
2648 function string_to_number, so that Fstring_to_number parses
2649 floating point numbers consistently with the Lisp reader.
2650 (digit_to_number): Move here from data.c. Make it static inline.
2651 (E_CHAR, EXP_INT): Remove, replacing with ...
2652 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2653 (string_to_number): New function, replacing isfloat_string.
2654 This function checks for valid syntax and produces the resulting
2655 Lisp float number too. Rework it so that string-to-number
2656 no longer mishandles examples like "1.0e+". Use strtoumax,
2657 so that overflow for non-base-10 numbers is reported only when
2658 there's no portable and simple way to convert to floating point.
2659
2660 * textprop.c (set_text_properties_1): Rewrite for clarity,
2661 and to avoid GCC warning about integer overflow.
2662
2663 * intervals.h (struct interval): Use EMACS_INT for members
2664 where EMACS_UINT might cause problems. See
2665 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2666 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2667 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2668 All uses changed.
2669 (offset_intervals): Tell GCC not to worry about length overflow
2670 when negating a negative length.
2671
2672 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2673 (overrun_check_free): Likewise.
2674
2675 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2676 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2677 word size.
2678
2679 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2680 (gnutls_make_error): Rename local to avoid shadowing.
2681 (gnutls_emacs_global_deinit): ifdef out; not used.
2682 (Fgnutls_boot): Use const for pointer to readonly storage.
2683 Comment out unused local. Fix pointer signedness problems.
2684
2685 * lread.c (openp): Don't stuff size_t into an 'int'.
2686 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2687 about possible signed overflow.
2688
2689 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2690 (GDK_KEY_g): Don't define if already defined.
2691 (xg_prepare_tooltip): Avoid pointer signedness problem.
2692 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2693
2694 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2695 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2696
2697 * xfns.c (Fx_window_property): Simplify a bit,
2698 to make a bit faster and to avoid GCC 4.6.0 warning.
2699 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2700
2701 * fns.c (internal_equal): Don't assume size_t fits in int.
2702
2703 * alloc.c (compact_small_strings): Tighten assertion a little.
2704
2705 Replace pEd with more-general pI, and fix some printf arg casts.
2706 * lisp.h (pI): New macro, generalizing old pEd macro to other
2707 conversion specifiers. For example, use "...%"pI"d..." rather
2708 than "...%"pEd"...".
2709 (pEd): Remove. All uses replaced with similar uses of pI.
2710 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2711 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2712 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2713 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2714 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2715 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2716 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2717 64-bit hosts.
2718 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2719 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2720 * print.c (safe_debug_print, print_object): Likewise.
2721 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2722 to int.
2723 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2724 avoiding the 0 flag, which is not portable.
2725 * process.c (Fmake_network_process): Use pI to avoid cast.
2726 * region-cache.c (pp_cache): Likewise.
2727 * xdisp.c (decode_mode_spec): Likewise.
2728 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2729 behavior on 64-bit hosts with printf arg.
2730 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2731 (x_stop_queuing_selection_requests): Likewise.
2732 (x_get_window_property): Don't truncate byte count to an 'int'
2733 when tracing.
2734
2735 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2736 here, since it parses constructs like leading '-' and spaces,
2737 which are not wanted; and it overflows with large numbers.
2738 Instead, simply match F[0-9]+, which is what is wanted anyway.
2739
2740 * alloc.c: Remove unportable assumptions about struct layout.
2741 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2742 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2743 (allocate_vectorlike, make_pure_vector): Use the new macros,
2744 plus offsetof, to remove unportable assumptions about struct layout.
2745 These assumptions hold on all porting targets that I know of, but
2746 they are not guaranteed, they're easy to remove, and removing them
2747 makes further changes easier.
2748
2749 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2750 This doesn't fix a bug but makes the code clearer.
2751 (string_overrun_cookie): Now const. Use initializers that
2752 don't formally overflow signed char, to avoid warnings.
2753 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2754 can cause Emacs to crash when string overrun checking is enabled.
2755 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2756 multiple of sizeof (EMACS_INT); it need not be, if
2757 alignof(EMACS_INT) < sizeof (EMACS_INT).
2758 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2759
2760 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2761
2762 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2763
2764 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2765
2766 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2767 supposed to be handshaking. (Bug#8556)
2768 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2769
2770 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2771
2772 * lisp.h (Qdebug): List symbol.
2773 * eval.c (Qdebug): Restore global linkage.
2774 * keyboard.c (debug-on-event): New variable.
2775 (handle_user_signal): Break into debugger when debug-on-event
2776 matches the current signal symbol.
2777
2778 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2779
2780 * alloc.c (check_sblock, check_string_bytes)
2781 (check_string_free_list): Convert to standard C.
2782
2783 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2784
2785 * w32.c (emacs_gnutls_push): Fix typo.
2786
2787 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2788
2789 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2790 "cast to pointer from integer of different size".
2791
2792 Improve doprnt and its use in verror. (Bug#8545)
2793 * doprnt.c (doprnt): Document the set of format control sequences
2794 supported by the function. Use SAFE_ALLOCA instead of always
2795 using `alloca'.
2796
2797 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2798 is one byte too soon. Don't use xrealloc; instead xfree and
2799 xmalloc anew.
2800
2801 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2802
2803 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2804 callbacks stage.
2805
2806 * gnutls.c: Renamed global_initialized to
2807 gnutls_global_initialized. Added internals for the
2808 :verify-hostname-error, :verify-error, and :verify-flags
2809 parameters of `gnutls-boot' and documented those parameters in the
2810 docstring. Start callback support.
2811 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2812 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2813 on error. Return error code.
2814 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2815 (emacs_gnutls_read): Likewise.
2816 (Fgnutls_boot): Return handshake error code.
2817 (emacs_gnutls_handle_error): New function.
2818 (wsaerror_to_errno): Likewise.
2819
2820 * w32.h (emacs_gnutls_pull): Add prototype.
2821 (emacs_gnutls_push): Likewise.
2822
2823 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2824 (emacs_gnutls_push): Likewise.
2825
2826 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2827
2828 * process.c (wait_reading_process_output): Check if GnuTLS
2829 buffered some data internally if no FDs are set for TLS
2830 connections.
2831
2832 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2833 (LIBS): Link to USER_LIBS.
2834 ($(BLD)/gnutls.$(0)): New target.
2835
2836 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2837
2838 * xdisp.c (handle_single_display_spec): Rename the
2839 display_replaced_before_p argument into display_replaced_p, to
2840 make it consistent with the commentary. Fix typos in the
2841 commentary.
2842
2843 * textprop.c (syms_of_textprop): Remove dead code.
2844 (copy_text_properties): Delete obsolete commentary about an
2845 interface that was deleted long ago. Fix typos in the description
2846 of arguments.
2847
2848 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2849 to changes in oldXMenu/XMenu.h from 2011-04-16.
2850 <menu_help_message, prev_menu_help_message>: Constify.
2851 (IT_menu_make_room): menu->help_text is now `const char **';
2852 adjust.
2853
2854 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2855 to changes in oldXMenu/XMenu.h from 2011-04-16.
2856 (struct XMenu): Declare `help_text' `const char **'.
2857
2858 * xfaces.c <Qunspecified>: Make extern again.
2859
2860 * syntax.c: Include sys/types.h before including regex.h, as
2861 required by Posix.
2862
2863 * doc.c (get_doc_string): Improve the format passed to `error'.
2864
2865 * doprnt.c (doprnt): Improve commentary.
2866
2867 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2868
2869 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2870 them with etags.
2871
2872 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2873 changes in globals.h immediately force recompilation.
2874 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2875 $(CURDIR)/s/ms-w32.h.
2876 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2877
2878 * character.c (Fchar_direction): Function deleted.
2879 (syms_of_character): Don't defsubr it.
2880 <char-direction-table>: Deleted.
2881
2882 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2883
2884 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2885 * doprnt.c: Include limits.h.
2886 (SIZE_MAX): New macro.
2887 (doprnt): Return a size_t value. 2nd arg is now size_t.
2888 Many local variables are now size_t instead of int or unsigned.
2889 Improve overflow protection. Support `l' modifier for integer
2890 conversions. Support %l conversion. Don't assume an EMACS_INT
2891 argument for integer conversions and for %c.
2892
2893 * lisp.h (doprnt): Restore prototype.
2894
2895 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2896 $(SRC)/character.h.
2897
2898 * Makefile.in (base_obj): Add back doprnt.o.
2899
2900 * deps.mk (doprnt.o): Add back prerequisites.
2901 (callint.o): Depend on character.h.
2902
2903 * eval.c (internal_lisp_condition_case): Include the handler
2904 representation in the error message.
2905 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2906 when breaking from the loop.
2907
2908 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2909
2910 * callint.c (Fcall_interactively): When displaying error message
2911 about invalid control letter, pass the character's codepoint, not
2912 a pointer to its multibyte form. Improve display of the character
2913 in octal and display also its hex code.
2914
2915 * character.c (char_string): Use %x to display the (unsigned)
2916 codepoint of an invalid character, to avoid displaying a bogus
2917 negative value.
2918
2919 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2920 `error', not SYMBOL_NAME itself.
2921
2922 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2923 character arguments to `error'.
2924
2925 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2926 to `error' in error message about FINAL_CHAR argument. Make sure
2927 FINAL_CHAR is a character, and use %c when it is passed as
2928 argument to `error'.
2929
2930 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2931
2932 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2933
2934 * w32.c: Include <time.h>.
2935 (sys_localtime): New function.
2936
2937 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2938
2939 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2940
2941 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2942
2943 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2944
2945 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2946 zombies (Bug#8467).
2947
2948 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2949
2950 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2951 gl_state.e_property when gl_state.object is Qt.
2952
2953 * insdel.c (make_gap_larger): Remove limitation of buffer size
2954 to <= INT_MAX.
2955
2956 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2957
2958 * xdisp.c (lookup_glyphless_char_display)
2959 (produce_glyphless_glyph): Handle cons cell entry in
2960 glyphless-char-display.
2961 (Vglyphless_char_display): Document it.
2962
2963 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2964 glyphless-char-display.
2965
2966 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2967
2968 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2969
2970 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2971
2972 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2973 definition for no-X builds.
2974
2975 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2976
2977 Static checks with GCC 4.6.0 and non-default toolkits.
2978
2979 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2980
2981 * process.c (keyboard_bit_set): Define only if SIGIO.
2982 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2983 (send_process): Repair possible setjmp clobbering.
2984
2985 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2986
2987 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2988
2989 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2990
2991 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2992 Define only if needed.
2993
2994 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2995 by pacifying GCC about it. Maybe it's time to retire it?
2996 * xfaces.c (USG, __TIMEVAL__): Likewise.
2997
2998 * dispextern.h (struct redisplay_interface): Rename param
2999 to avoid shadowing.
3000 * termhooks.h (struct terminal): Likewise.
3001 * xterm.c (xembed_send_message): Likewise.
3002
3003 * insdel.c (make_gap_smaller): Define only if
3004 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3005
3006 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3007 it.
3008
3009 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3010 so that we aren't warned about unused symbols.
3011
3012 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3013
3014 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3015
3016 * xfns.c (x_real_positions): Mark locals as initialized.
3017
3018 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3019
3020 * xterm.c: Fix problems found by static analysis with other toolkits.
3021 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3022 (x_dispatch_event): Declare static if USE_GTK, and
3023 define if USE_GTK || USE_X_TOOLKIT.
3024 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3025 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3026 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3027 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3028
3029 * xmenu.c (menu_help_callback): Pointer type fixes.
3030 Use const pointers when pointing at readonly data. Avoid pointer
3031 signedness clashes.
3032 (FALSE): Remove unused macro.
3033 (update_frame_menubar): Remove unused decl.
3034
3035 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3036
3037 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3038 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3039 (single_menu_item): Rename local to avoid shadowing.
3040
3041 * keyboard.c (make_lispy_event): Remove unused local var.
3042
3043 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3044 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3045
3046 * bitmaps: Change bitmaps from unsigned char back to the X11
3047 compatible char. Avoid the old compiler warnings about
3048 out-of-range initializers by using, for example, '\xab' rather
3049 than 0xab.
3050
3051 * xgselect.c (xgselect_initialize): Check vs interface
3052 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3053
3054 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3055
3056 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3057 to read-only memory.
3058
3059 * fns.c (vector): Remove; this old hack is no longer needed.
3060
3061 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3062 Remove unused var.
3063 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3064
3065 * xrdb.c (x_load_resources): Omit unused local.
3066
3067 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3068 (x_window): Rename locals to avoid shadowing.
3069 (USG): Use the kludged USG macro, to pacify gcc.
3070
3071 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3072 (x_term_init): Remove local to avoid shadowing.
3073
3074 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3075
3076 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3077 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3078
3079 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3080
3081 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3082
3083 Fix regex.c, syntax.c and friends for buffers > 2GB.
3084 * syntax.h (struct gl_state_s): Declare character position members
3085 EMACS_INT.
3086
3087 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3088
3089 * textprop.c (verify_interval_modification, interval_of):
3090 Declare arguments EMACS_INT.
3091
3092 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3093 EMACS_INT.
3094
3095 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3096
3097 * indent.c (Fvertical_motion): Local variable it_start is now
3098 EMACS_INT.
3099
3100 * regex.c (re_match, re_match_2, re_match_2_internal)
3101 (bcmp_translate, regcomp, regexec, print_double_string)
3102 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3103 (re_compile_pattern, re_exec): Declare arguments and local
3104 variables `size_t' and `ssize_t' and return values `regoff_t', as
3105 appropriate.
3106 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3107 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3108 <compile_stack_type>: `size' and `avail' are now `size_t'.
3109
3110 * regex.h <regoff_t>: Use ssize_t, not int.
3111 (re_search, re_search_2, re_match, re_match_2): Arguments that
3112 specify buffer/string position and length are now ssize_t and
3113 size_t. Return type is regoff_t.
3114
3115 2011-04-16 Ben Key <bkey76@gmail.com>
3116
3117 * nsfont.m: Fixed bugs in ns_get_family and
3118 ns_descriptor_to_entity that were caused by using free to
3119 deallocate memory blocks that were allocated by xmalloc (via
3120 xstrdup). This caused Emacs to crash when compiled with
3121 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3122 --enable-checking=xmallocoverrun). xfree is now used to
3123 deallocate these memory blocks.
3124
3125 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3126
3127 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3128
3129 emacs_write: Accept and return EMACS_INT for sizes.
3130 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3131 et seq.
3132 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3133 Accept and return EMACS_INT.
3134 (emacs_gnutls_write): Return the number of bytes written on
3135 partial writes.
3136 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3137 (emacs_read, emacs_write): Remove check for negative size, as the
3138 Emacs source code has been audited now.
3139 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3140 (emacs_read, emacs_write): Use it.
3141 * process.c (send_process): Adjust to the new signatures of
3142 emacs_write and emacs_gnutls_write. Do not attempt to store
3143 a byte offset into an 'int'; it might overflow.
3144 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3145
3146 * sound.c: Don't assume sizes fit in 'int'.
3147 (struct sound_device.period_size, alsa_period_size):
3148 Return EMACS_INT, not int.
3149 (struct sound_device.write, vox_write, alsa_write):
3150 Accept EMACS_INT, not int.
3151 (wav_play, au_play): Use EMACS_INT to store sizes and to
3152 record read return values.
3153
3154 2011-04-15 Ben Key <bkey76@gmail.com>
3155
3156 * keyboard.c (Qundefined): Don't declare static since it is used
3157 in nsfns.m.
3158 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3159 static since they are used in nsfont.m.
3160
3161 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3162
3163 * process.c (Qprocessp): Don't declare static.
3164 * lisp.h (Qprocessp): Declare again.
3165
3166 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3167
3168 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3169
3170 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3171
3172 Improve C-level modularity by making more things 'static'.
3173
3174 Don't publish debugger-only interfaces to other modules.
3175 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3176 (verify_bytepos, count_markers): Move decls to the only modules
3177 that need them.
3178 * region-cache.h (pp_cache): Likewise.
3179 * window.h (check_all_windows): Likewise.
3180 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3181
3182 * sysdep.c (croak): Now static, if
3183 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3184 * syssignal.h (croak): Declare only if not static.
3185
3186 * alloc.c (refill_memory_reserve): Now static if
3187 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3188 * lisp.h (refill_memory_reserve): Declare only if not static.
3189
3190 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3191 Define only if USE_LUCID.
3192
3193 * xrdb.c (x_customization_string, x_rm_string): Now static.
3194
3195 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3196 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3197
3198 * xdisp.c (draw_row_with_mouse_face): Now static.
3199 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3200
3201 * window.h (check_all_windows): Mark externally visible.
3202
3203 * window.c (window_deletion_count): Now static.
3204
3205 * undo.c: Make symbols static if they're not exported.
3206 (last_undo_buffer, last_boundary_position, pending_boundary):
3207 Now static.
3208
3209 * textprop.c (interval_insert_behind_hooks): Now static.
3210 (interval_insert_in_front_hooks): Likewise.
3211
3212 * term.c: Make symbols static if they're not exported.
3213 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3214 (max_frame_lines, tty_set_terminal_modes):
3215 (tty_reset_terminal_modes, tty_turn_off_highlight):
3216 (get_tty_terminal): Now static.
3217 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3218 * termhooks.h (term_mouse_moveto): Do not declare if
3219 HAVE_WINDOW_SYSTEM.
3220 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3221 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3222
3223 * sysdep.c: Make symbols static if they're not exported.
3224 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3225 Now static.
3226 (sigprocmask_set, full_mask): Remove; unused.
3227 (wait_debugging): Mark as visible.
3228 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3229 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3230
3231 * syntax.c (syntax_temp): Define only if !__GNUC__.
3232
3233 * sound.c (current_sound_device, current_sound): Now static.
3234
3235 * search.c (searchbufs, searchbuf_head): Now static.
3236
3237 * scroll.c (scroll_cost): Remove; unused.
3238 * dispextern.h (scroll_cost): Remove decl.
3239
3240 * region-cache.h (pp_cache): Mark as externally visible.
3241
3242 * process.c: Make symbols static if they're not exported.
3243 (process_tick, update_tick, create_process, chan_process):
3244 (Vprocess_alist, proc_buffered_char, datagram_access):
3245 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3246 (deactivate_process): Mark defn as static, as well as decl.
3247 * lisp.h (create_process): Remove decl.
3248 * process.h (chan_process, Vprocess_alist): Remove decls.
3249
3250 * print.c: Make symbols static if they're not exported.
3251 (print_depth, new_backquote_output, being_printed, print_buffer):
3252 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3253 (print_interval, print_number_index, initial_stderr_stream):
3254 Now static.
3255 * lisp.h (Fprinc): Remove decl.
3256 (debug_output_compilation_hack): Mark as externally visible.
3257
3258 * sysdep.c (croak): Move decl from here to syssignal.h.
3259 * syssignal.h (croak): Put it here, so the API can be checked when
3260 'croak' is called from dissociate_if_controlling_tty.
3261
3262 * minibuf.c: Make symbols static if they're not exported.
3263 (minibuf_save_list, choose_minibuf_frame): Now static.
3264 * lisp.h (choose_minibuf_frame): Remove decl.
3265
3266 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3267
3268 * lread.c: Make symbols static if they're not exported.
3269 (read_objects, initial_obarray, oblookup_last_bucket_number):
3270 Now static.
3271 (make_symbol): Remove; unused.
3272 * lisp.h (initial_obarray, make_symbol): Remove decls.
3273
3274 * keyboard.c: Make symbols static if they're not exported.
3275 (single_kboard, recent_keys_index, total_keys, recent_keys):
3276 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3277 (this_single_command_key_start, echoing, last_auto_save):
3278 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3279 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3280 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3281 (Vlispy_mouse_stem, double_click_count):
3282 Now static.
3283 (force_auto_save_soon): Define only if SIGDANGER.
3284 (ignore_mouse_drag_p): Now static if
3285 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3286 (print_help): Remove; unused.
3287 (stop_character, last_timer_event): Mark as externally visible.
3288 * keyboard.h (ignore_mouse_drag_p): Declare only if
3289 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3290 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3291 * lisp.h (echoing): Remove decl.
3292 (force_auto_save_soon): Declare only if SIGDANGER.
3293 * xdisp.c (redisplay_window): Simplify code, to make it more
3294 obvious that ignore_mouse_drag_p is not accessed if !defined
3295 USE_GTK && !defined HAVE_NS.
3296
3297 * intervals.c: Make symbols static if they're not exported.
3298 (merge_properties_sticky, merge_interval_right, delete_interval):
3299 Now static.
3300 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3301
3302 * insdel.c: Make symbols static if they're not exported.
3303 However, leave prepare_to_modify_buffer alone. It's never
3304 called from outside this function, but that appears to be a bug.
3305 (combine_after_change_list, combine_after_change_buffer):
3306 (adjust_after_replace, signal_before_change): Now static.
3307 (adjust_after_replace_noundo): Remove; unused.
3308 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3309 (signal_before_change): Remove decls.
3310
3311 * indent.c (val_compute_motion, val_vmotion): Now static.
3312
3313 * image.c: Make symbols static if they're not exported.
3314 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3315 if USE_GTK.
3316 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3317 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3318
3319 * fringe.c (standard_bitmaps): Now static.
3320 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3321
3322 * frame.c: Make symbols static if they're not exported.
3323 (x_report_frame_params, make_terminal_frame): Now static.
3324 (get_frame_param): Now static, unless HAVE_NS.
3325 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3326 (x_get_resource_string): Remove; not used.
3327 * frame.h (make_terminal_frame, x_report_frame_params):
3328 (x_get_resource_string); Remove decls.
3329 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3330 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3331
3332 * font.c, fontset.c: Make symbols static if they're not exported.
3333 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3334 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3335 * font.c (font_close_object): Now static.
3336 * font.h (font_close_object): Remove.
3337 * fontset.c (FONTSET_OBJLIST): Remove.
3338 (free_realized_fontset) #if-0 the body, which does nothing.
3339 (face_suitable_for_char_p): #if-0, as it's never called.
3340 * fontset.h (face_suitable_for_char_p): Remove decl.
3341 * xfaces.c (face_at_string_position):
3342 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3343 since 0 is always ASCII.
3344
3345 * fns.c (weak_hash_tables): Now static.
3346
3347 * fileio.c: Make symbols static if they're not exported.
3348 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3349 (Vwrite_region_annotation_buffers): Now static.
3350
3351 * eval.c: Make symbols static if they're not exported.
3352 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3353 * lisp.h (backtrace_list): Remove decl.
3354
3355 * emacs.c: Make symbols static if they're not exported.
3356 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3357 (fatal_error_code, fatal_error_signal_hook, standard_args):
3358 Now static.
3359 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3360 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3361 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3362 * lisp.h (fatal_error_signal_hook): Remove decl.
3363 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3364
3365 * editfns.c: Move a (normally-unused) function to its only use.
3366 * editfns.c, lisp.h (get_operating_system_release): Remove.
3367 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3368 worth the hassle of breaking this out.
3369
3370 * xterm.c: Make symbols static if they're not exported.
3371 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3372 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3373 (x_destroy_window, x_delete_display):
3374 Now static.
3375 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3376 (x_mouse_leave): Remove; unused.
3377 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3378 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3379 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3380 Remove decls.
3381 (x_mouse_leave): Declare only if WINDOWSNT.
3382 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3383 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3384 USE_X_TOOLKIT.
3385
3386 * ftxfont.c: Make symbols static if they're not exported.
3387 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3388 HAVE_FREETYPE.
3389 * font.h (ftxfont_driver): Likewise.
3390
3391 * xfns.c: Make symbols static if they're not exported.
3392 (x_last_font_name, x_display_info_for_name):
3393 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3394 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3395 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3396 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3397 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3398 (last_show_tip_args): Now static.
3399 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3400 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3401 (x_screen_planes): Remove; unused.
3402 * dispextern.h (x_screen_planes): Remove decl.
3403
3404 * dispnew.c: Make symbols static if they're not exported.
3405 * dispextern.h (redraw_garbaged_frames, scrolling):
3406 (increment_row_positions): Remove.
3407 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3408 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3409 Now static.
3410 (redraw_garbaged_frames): Remove; unused.
3411
3412 * xfaces.c: Make symbols static if they're not exported.
3413 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3414 Remove decls.
3415 * xterm.h (defined_color): Remove decls.
3416 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3417 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3418 (menu_face_changed_default, defined_color, free_realized_face):
3419 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3420 (ascii_face_of_lisp_face): Remove; unused.
3421
3422 * xdisp.c: Make symbols static if they're not exported.
3423 * dispextern.h (scratch_glyph_row, window_box_edges):
3424 (glyph_to_pixel_coords, set_cursor_from_row):
3425 (get_next_display_element, set_iterator_to_next):
3426 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3427 (show_mouse_face): Remove decls
3428 * frame.h (message_buf_print): Likewise.
3429 * lisp.h (pop_message, set_message, check_point_in_composition):
3430 Likewise.
3431 * xterm.h (set_vertical_scroll_bar): Likewise.
3432 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3433 (message_buf_print, scratch_glyph_row, displayed_buffer):
3434 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3435 (get_next_display_element, show_mouse_face, window_box_edges):
3436 (frame_to_window_pixel_xy, check_point_in_composition):
3437 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3438 (glyph_to_pixel_coords): Remove; unused.
3439
3440 * dired.c (file_name_completion): Now static.
3441
3442 * dbusbind.c (xd_in_read_queued_messages): Now static.
3443
3444 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3445 * data.c (circular_list_error): Remove.
3446
3447 * commands.h (last_point_position, last_point_position_buffer):
3448 (last_point_position_window): Remove decls.
3449 * keyboard.c: Make these variables static.
3450
3451 * coding.h (coding, code_convert_region, encode_coding_gap):
3452 Remove decls.
3453 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3454 (iso_code_class, detect_coding, code_convert_region): Now static.
3455 (encode_coding_gap): Remove; unused.
3456
3457 * chartab.c (chartab_chars, chartab_bits): Now static.
3458
3459 * charset.h (charset_iso_8859_1): Remove decl.
3460 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3461 Now static.
3462
3463 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3464 * ccl.c (Vccl_program_table): Now static.
3465 (check_ccl_update): Remove; unused.
3466
3467 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3468 * category.h: ... from here.
3469 * category.c (check_category_table, set_category_set): Now static.
3470
3471 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3472 * lisp.h: Remove these decls.
3473
3474 * buffer.c (buffer_count): Remove unused var.
3475
3476 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3477 so that it's not optimized away.
3478 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3479 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3480 exported only to the debugger.
3481
3482 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3483 * atimer.h (run_all_atimers): Remove; not exported.
3484
3485 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3486 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3487 was inaccessible from Lisp.
3488 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3489 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3490
3491 alloc.c: Import and export fewer symbols, and remove unused items.
3492 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3493 is defined.
3494 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3495 it's not optimized away by whole-program optimization.
3496 (message_enable_multibyte, free_misc): Remove.
3497 (catchlist, handlerlist, mark_backtrace):
3498 Declare only if BYTE_MARK_STACK.
3499 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3500 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3501 (message_enable_multibyte): Remove decl.
3502 (free_misc, interval_free_list, float_block, float_block_index):
3503 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3504 (cons_free_list, last_marked_index):
3505 Now static.
3506 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3507 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3508 (mark_backtrace): Define only if BYTE_MARK_STACK.
3509 * xdisp.c (message_enable_multibyte): Now static.
3510
3511 Declare Lisp_Object Q* variables to be 'static' if not exported.
3512 This makes it easier for human readers (and static analyzers)
3513 to see whether these variables are used from other modules.
3514 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3515 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3516 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3517 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3518 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3519 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3520 * xmenu.c, xselect.c:
3521 Declare Q* vars static if they are not used in other modules.
3522 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3523 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3524 Remove decls of unexported vars.
3525 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3526
3527 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3528
3529 Make Emacs functions such as Fatom 'static' by default.
3530 This makes it easier for human readers (and static analyzers)
3531 to see whether these functions can be called from other modules.
3532 DEFUN now defines a static function. To make the function external
3533 so that it can be used in other C modules, use the new macro DEFUE.
3534 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3535 (Finit_image_library):
3536 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3537 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3538 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3539 Remove decls, since these functions are now static.
3540 (Funintern, Fget_internal_run_time): New decls, since these functions
3541 were already external.
3542
3543 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3544 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3545 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3546 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3547 * keyboard.c, keymap.c, lread.c:
3548 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3549 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3550 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3551 Mark functions with DEFUE instead of DEFUN,
3552 if they are used in other modules.
3553 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3554 decls for now-static functions.
3555 * buffer.h (Fdelete_overlay): Remove decl.
3556 * callproc.c (Fgetenv_internal): Mark as internal.
3557 * composite.c (Fremove_list_of_text_properties): Remove decl.
3558 (Fcomposition_get_gstring): New forward static decl.
3559 * composite.h (Fcomposite_get_gstring): Remove decl.
3560 * dired.c (Ffile_attributes): New forward static decl.
3561 * doc.c (Fdocumntation_property): New forward static decl.
3562 * eval.c (Ffetch_bytecode): New forward static decl.
3563 (Funintern): Remove extern decl; now in .h file where it belongs.
3564 * fileio.c (Fmake_symbolic_link): New forward static decl.
3565 * image.c (Finit_image_library): New forward static decl.
3566 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3567 * intervals.h (Fprevious_property_change):
3568 (Fremove_list_of_text_properties): Remove decls.
3569 * keyboard.c (Fthis_command_keys): Remove decl.
3570 (Fcommand_execute): New forward static decl.
3571 * keymap.c (Flookup_key): New forward static decl.
3572 (Fcopy_keymap): Now static.
3573 * keymap.h (Flookup_key): Remove decl.
3574 * process.c (Fget_process): New forward static decl.
3575 (Fprocess_datagram_address): Mark as internal.
3576 * syntax.c (Fsyntax_table_p): New forward static decl.
3577 (skip_chars): Remove duplicate decl.
3578 * textprop.c (Fprevious_property_change): New forward static decl.
3579 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3580 Now internal.
3581 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3582 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3583
3584 * editfns.c (Fformat): Remove unreachable code.
3585
3586 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3587
3588 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3589 change. (Bug#8496)
3590
3591 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3592
3593 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3594 when at ZV. (Bug#8487)
3595
3596 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3597
3598 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3599 (Bug#8437)
3600 * keyboard.c (parse_tool_bar_item): Likewise.
3601 * sound.c (sound_cleanup, alsa_close): Likewise.
3602 * termcap.c (tgetent): Likewise.
3603 * xfns.c (x_default_font_parameter): Likewise.
3604 * xsettings.c (read_and_apply_settings): Likewise.
3605
3606 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3607 (overrun_check_free): Protoize.
3608
3609 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3610
3611 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3612 since callers should never pass a negative size.
3613 Change the signature to match that of plain 'read' and 'write'; see
3614 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3615 * lisp.h: Update prototypes of emacs_write and emacs_read.
3616
3617 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3618
3619 * xdisp.c (redisplay_window): Don't try to determine the character
3620 position of the scroll margin if the window start point w->startp
3621 is outside the buffer's accessible region. (Bug#8468)
3622
3623 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3624
3625 Fix write-region and its subroutines for buffers > 2GB.
3626 * fileio.c (a_write, e_write): Modify declaration of arguments and
3627 local variables to support buffers larger than 2GB.
3628 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3629
3630 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3631 argument, local variables, and return value.
3632
3633 * lisp.h: Update prototypes of emacs_write and emacs_read.
3634
3635 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3636
3637 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3638
3639 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3640
3641 Fix more problems found by GCC 4.6.0's static checks.
3642
3643 * xdisp.c (vmessage): Use a better test for character truncation.
3644
3645 * charset.c (load_charset_map): <, not <=, for optimization,
3646 and to avoid potential problems with integer overflow.
3647 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3648 * casetab.c (set_identity, shuffle): Likewise.
3649 * editfns.c (Fformat): Likewise.
3650 * syntax.c (skip_chars): Likewise.
3651
3652 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3653 This also lets GCC 4.6.0 generate slightly better loop code.
3654
3655 * callint.c (Fcall_interactively): <, not <=, for optimization.
3656 (Fcall_interactively): Count the number of arguments produced,
3657 not the number of arguments given. This is simpler and lets GCC
3658 4.6.0 generate slightly better code.
3659
3660 * ftfont.c: Distingish more carefully between FcChar8 and char.
3661 The previous code passed unsigned char * to a functions like
3662 strlen and xstrcasecmp that expect char *, which does not
3663 conform to the C standard.
3664 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3665 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3666 char * when the C standard requires it.
3667
3668 * keyboard.c (read_char): Remove unused var.
3669
3670 * eval.c: Port to Windows vsnprintf (Bug#8435).
3671 Include <limits.h>.
3672 (SIZE_MAX): Define if the headers do not.
3673 (verror): Do not give up if vsnprintf returns a negative count.
3674 Instead, grow the buffer. This ports to Windows vsnprintf, which
3675 does not conform to C99. Problem reported by Eli Zaretskii.
3676 Also, simplify the allocation scheme, by avoiding the need for
3677 calling realloc, and removing the ALLOCATED variable.
3678
3679 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3680
3681 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3682 But keep the doprint source code for now, as we might revamp it
3683 and use it again (Bug#8435).
3684 * lisp.h (doprnt): Remove.
3685 * Makefile.in (base_obj): Remove doprnt.o.
3686 * deps.mk (doprnt.o): Remove.
3687
3688 error: Print 32- and 64-bit integers portably (Bug#8435).
3689 Without this change, on typical 64-bit hosts error ("...%d...", N)
3690 was used to print both 32- and 64-bit integers N, which relied on
3691 undefined behavior.
3692 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3693 New macro.
3694 * lisp.h (error, verror): Mark as printf-like functions.
3695 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3696 Report overflow in size calculations when allocating printf buffer.
3697 Do not truncate output string at its first null byte.
3698 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3699 Truncate the output at a character boundary, since vsnprintf does not
3700 do that.
3701 * charset.c (check_iso_charset_parameter): Convert internal
3702 character to string before calling 'error', since %c now has the
3703 printf meaning.
3704 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3705 overflow when computing char to be passed to 'error'. Do not
3706 pass Lisp_Object to 'error'; pass the integer instead.
3707 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3708 formatted with plain %d.
3709
3710 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3711
3712 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3713
3714 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3715
3716 * xterm.c (x_catch_errors): Remove duplicate declaration.
3717
3718 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3719
3720 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3721
3722 2011-04-10 Jim Meyering <meyering@redhat.com>
3723
3724 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3725 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3726 return ssize_t not "int", and use size_t as the buffer length.
3727 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3728 * gnutls.h: Update declarations.
3729 * process.c (read_process_output): Use ssize_t, to match.
3730 (send_process): Likewise.
3731
3732 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3733
3734 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3735
3736 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3737
3738 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3739 Use unsigned char, to match FcChar8 type definition.
3740
3741 * xterm.c (handle_one_xevent):
3742 * xmenu.c (create_and_show_popup_menu):
3743 * xselect.c (x_decline_selection_request)
3744 (x_reply_selection_request): Avoid type-punned deref of X events.
3745
3746 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3747
3748 Fix some uses of `int' instead of EMACS_INT.
3749 * search.c (string_match_1, fast_string_match)
3750 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3751 (scan_buffer, find_next_newline_no_quit)
3752 (find_before_next_newline, search_command, Freplace_match)
3753 (Fmatch_data): Make some `int' variables be EMACS_INT.
3754
3755 * xdisp.c (display_count_lines): 3rd argument and return value now
3756 EMACS_INT. All callers changed.
3757 (pint2hrstr): Last argument is now EMACS_INT.
3758
3759 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3760 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3761 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3762 (decode_coding_utf_16, decode_coding_emacs_mule)
3763 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3764 (decode_coding_ccl, decode_coding_charset)
3765 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3766 (decode_coding_iso_2022, decode_coding_emacs_mule)
3767 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3768 <char_offset, last_offset>: Declare EMACS_INT.
3769 (encode_coding_utf_8, encode_coding_utf_16)
3770 (encode_coding_emacs_mule, encode_invocation_designation)
3771 (encode_designation_at_bol, encode_coding_iso_2022)
3772 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3773 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3774 Declare EMACS_INT.
3775 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3776 (encode_invocation_designation): Last argument P_NCHARS is now
3777 EMACS_INT.
3778 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3779 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3780
3781 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3782 All users changed.
3783
3784 * ccl.c (Fccl_execute_on_string): Declare some variables
3785 EMACS_INT.
3786
3787 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3788
3789 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3790
3791 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3792
3793 * process.c (Fformat_network_address): Doc fix.
3794
3795 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3796
3797 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3798
3799 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3800
3801 * keyboard.c (read_char): Call Lisp function help-form-show,
3802 instead of using internal_with_output_to_temp_buffer.
3803 (Qhelp_form_show): New var.
3804 (syms_of_keyboard): Use DEFSYM macro.
3805
3806 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3807
3808 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3809
3810 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3811
3812 * process.c (Flist_processes): Remove to Lisp.
3813 (list_processes_1): Delete.
3814
3815 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3816
3817 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3818
3819 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3820
3821 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3822
3823 Fix more problems found by GCC 4.6.0's static checks.
3824
3825 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3826
3827 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3828
3829 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3830
3831 * xdisp.c (vmessage): Mark as a printf-like function.
3832
3833 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3834
3835 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3836
3837 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3838 printf-like functions.
3839 (tiff_load): Add casts to remove these marks before passing them
3840 to system-supplied API.
3841
3842 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3843
3844 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3845 This avoids several warnings with gcc -Wstrict-overflow.
3846 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3847 directly, rather than having caller test rule sign. This avoids
3848 some unnecessary tests.
3849 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3850 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3851 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3852
3853 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3854 (xfont_open): Avoid unnecessary tests.
3855
3856 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3857
3858 * composite.h, composite.c (composition_gstring_put_cache):
3859 Use EMACS_INT, not int, for length.
3860
3861 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3862 breaking out part of COMPOSITION_DECODE_RULE.
3863 (COMPOSITION_DECODE_RULE): Use it.
3864 * composite.c (get_composition_id): Remove unused local vars,
3865 by using the new macro.
3866
3867 * textprop.c (set_text_properties_1): Change while to do-while,
3868 since the condition is always true at first.
3869
3870 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3871 (interval_deletion_adjustment): Return unsigned value.
3872 All uses changed.
3873
3874 * process.c (list_processes_1, create_pty, read_process_output):
3875 (exec_sentinel): Remove vars that were set but not used.
3876 (create_pty): Remove unnecessary "volatile"s.
3877 (Fnetwork_interface_info): Avoid possibility of int overflow.
3878 (read_process_output): Do adaptive read buffering even if carryover.
3879 (read_process_output): Simplify nbytes computation if buffered.
3880
3881 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3882
3883 * syntax.c (scan_words): Remove var that was set but not used.
3884 (update_syntax_table): Use unsigned instead of int.
3885
3886 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3887 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3888 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3889
3890 * print.c (print_error_message): Avoid int overflow.
3891
3892 * font.c (font_list_entities): Redo for clarity,
3893 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3894
3895 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3896 (font_score): Avoid potential overflow in diff calculation.
3897
3898 * fns.c (substring_both): Remove var that is set but not used.
3899 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3900
3901 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3902
3903 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3904 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3905 can always succeed if overflow has undefined behavior.
3906
3907 * search.c (boyer_moore, wordify): Remove vars set but not used.
3908 (wordify): Omit three unnecessary tests.
3909
3910 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3911 All callers changed. This avoids the need for an unused var.
3912
3913 * casefiddle.c (casify_region): Remove var that is set but not used.
3914
3915 * dired.c (file_name_completion): Remove var that is set but not used.
3916
3917 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3918
3919 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3920 (Finsert_file_contents): Remove unnecessary code checking fd.
3921
3922 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3923 Check for integer overflow on size calculations.
3924
3925 * buffer.c (Fprevious_overlay_change): Remove var that is set
3926 but not used.
3927
3928 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3929 Remove vars that are set but not used.
3930 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3931 (timer_check_2): Mark vars as initialized.
3932
3933 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3934
3935 * image.c (lookup_image): Remove var that is set but not used.
3936 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3937
3938 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3939 that are set but not used.
3940
3941 * xfns.c (make_invisible_cursor): Don't return garbage
3942 if XCreateBitmapFromData fails (Bug#8410).
3943
3944 * xselect.c (x_get_local_selection, x_handle_property_notify):
3945 Remove vars that are set but not used.
3946
3947 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3948 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3949
3950 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3951 Remove var that is set but not used.
3952 (scroll_bar_windows_size): Now size_t, not int.
3953 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3954 Check for overflow.
3955
3956 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3957 (map_tty_color) [!defined MSDOS]: Likewise.
3958
3959 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3960
3961 * coding.c: Remove vars that are set but not used.
3962 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3963 All callers changed.
3964 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3965 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3966 (decode_coding_charset): Remove vars that are set but not used.
3967
3968 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3969 that is set but not used.
3970
3971 * print.c (print_object): Remove var that is set but not used.
3972
3973 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3974 The gnulib version avoids calling malloc in the usual case,
3975 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3976 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3977 * filelock.c (current_lock_owner): Likewise.
3978 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3979 * sysdep.c: Include allocator.h, careadlinkat.h.
3980 (emacs_no_realloc_allocator): New static constant.
3981 (emacs_readlink): New function.
3982 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3983 ../lib/careadlinkat.h.
3984
3985 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3986
3987 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3988 first non-nil return value).
3989
3990 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3991
3992 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3993 if not defined (Bug#8403).
3994
3995 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3996
3997 * xdisp.c (display_count_lines): Remove parameter `start',
3998 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3999 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4000 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4001 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4002 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4003 and thereabouts. All callers changed.
4004 (get_per_char_metric): Remove parameter `f', unused since
4005 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4006
4007 2011-04-02 Jim Meyering <meyering@redhat.com>
4008
4009 do not dereference NULL upon failed strdup
4010 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4011 (ns_get_family): Likewise.
4012
4013 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4014
4015 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4016
4017 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4018
4019 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4020 later (Bug#8403).
4021
4022 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4023
4024 Add lexical binding.
4025
4026 * window.c (Ftemp_output_buffer_show): New fun.
4027 (Fsave_window_excursion):
4028 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4029
4030 * lread.c (lisp_file_lexically_bound_p): New function.
4031 (Fload): Bind Qlexical_binding.
4032 (readevalloop): Remove `evalfun' arg.
4033 Bind Qinternal_interpreter_environment.
4034 (Feval_buffer): Bind Qlexical_binding.
4035 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4036 Mark as dynamic.
4037 (syms_of_lread): Declare `lexical-binding'.
4038
4039 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4040
4041 * keyboard.c (eval_dyn): New fun.
4042 (menu_item_eval_property): Use it.
4043
4044 * image.c (parse_image_spec): Use Ffunctionp.
4045
4046 * fns.c (concat, mapcar1): Accept byte-code-functions.
4047
4048 * eval.c (Fsetq): Handle lexical vars.
4049 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4050 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4051 (FletX, Flet): Obey lexical binding.
4052 (Fcommandp): Handle closures.
4053 (Feval): New `lexical' arg.
4054 (eval_sub): New function extracted from Feval. Use it almost
4055 everywhere where Feval was used. Look up vars in lexical env.
4056 Handle closures.
4057 (Ffunctionp): Move from subr.el.
4058 (Ffuncall): Handle closures.
4059 (apply_lambda): Remove `eval_flags'.
4060 (funcall_lambda): Handle closures and new byte-code-functions.
4061 (Fspecial_variable_p): New function.
4062 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4063 but without exporting it to Lisp.
4064
4065 * doc.c (Fdocumentation, store_function_docstring):
4066 * data.c (Finteractive_form): Handle closures.
4067
4068 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4069 interactive spec.
4070
4071 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4072 New byte-codes.
4073 (exec_byte_code): New function extracted from Fbyte_code to handle new
4074 calling convention for byte-code-functions. Add new byte-codes.
4075
4076 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4077
4078 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4079
4080 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4081
4082 * xdisp.c (redisplay_internal): Fix prototype.
4083
4084 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4085
4086 * xdisp.c (SCROLL_LIMIT): New macro.
4087 (try_scrolling): Use it when setting scroll_limit.
4088 Limit scrolling to 100 screen lines.
4089 (redisplay_window): Even when falling back on "recentering",
4090 position point in the window according to scroll-conservatively,
4091 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4092
4093 (try_scrolling): When point is above the window, allow searching
4094 as far as scroll_max, or one screenful, to compute vertical
4095 distance from PT to the scroll margin position. This prevents
4096 try_scrolling from unnecessarily failing when
4097 scroll-conservatively is set to a value slightly larger than the
4098 window height. Clean up the case of PT below the margin at bottom
4099 of window: scroll_max can no longer be INT_MAX. When aggressive
4100 scrolling is in use, don't let point enter the opposite scroll
4101 margin as result of the scroll.
4102 (syms_of_xdisp) <scroll-conservatively>: Document the
4103 threshold of 100 lines for never-recentering scrolling.
4104
4105 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4106
4107 * dispextern.h (move_it_by_lines):
4108 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4109 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4110 (message_log_check_duplicate): Remove parameters `prev_bol' and
4111 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4112 (redisplay_internal): Remove parameter `preserve_echo_area',
4113 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4114
4115 * indent.c (Fvertical_motion):
4116 * window.c (window_scroll_pixel_based, Frecenter):
4117 Don't pass `need_y_p' to `move_it_by_lines'.
4118
4119 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4120
4121 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4122 steal a few bits to be more compact.
4123 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4124 Remove unneeded casts.
4125
4126 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4127
4128 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4129
4130 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4131 binding" message (bug#7967).
4132
4133 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4134
4135 Fix more problems found by GCC 4.6.0's static checks.
4136
4137 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4138 Remove unused local var.
4139
4140 * editfns.c (Fmessage_box): Remove unused local var.
4141
4142 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4143 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4144 Omit unused local vars.
4145 * window.c (shrink_windows): Omit unused local var.
4146 * menu.c (digest_single_submenu): Omit unused local var.
4147 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4148 Omit unused local var.
4149
4150 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4151 Don't assume string length fits in int.
4152 (keyremap_step, read_key_sequence): Use size_t for sizes.
4153 (read_key_sequence): Don't check last_real_key_start redundantly.
4154
4155 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4156 instead of alloca (Bug#8344).
4157
4158 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4159 (Fbacktrace_frame): Don't assume nframes fits in int.
4160
4161 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4162
4163 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4164 concerns.
4165
4166 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4167
4168 * cm.c (calccost): Turn while-do into do-while, for clarity.
4169
4170 * keyboard.c (syms_of_keyboard): Use the same style as later
4171 in this function when indexing through an array. This also
4172 works around GCC bug 48267.
4173
4174 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4175
4176 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4177
4178 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4179 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4180
4181 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4182 This avoids undefined behavior on integer overflow, and is a bit
4183 more convenient anyway since it is compared to a size_t variable.
4184
4185 Variadic C functions now count arguments with size_t, not int.
4186 This avoids an unnecessary limitation on 64-bit machines, which
4187 caused (substring ...) to crash on large vectors (Bug#8344).
4188 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4189 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4190 All variadic functions and their callers changed accordingly.
4191 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4192 * data.c (arith_driver, float_arith_driver): Likewise.
4193 * editfns.c (general_insert_function): Likewise.
4194 * eval.c (struct backtrace.nargs, interactive_p)
4195 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4196 (funcall_lambda, mark_backtrace): Likewise.
4197 * fns.c (concat): Likewise.
4198 * frame.c (x_set_frame_parameters): Likewise.
4199 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4200 0 if not found, not -1. All callers changed.
4201
4202 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4203 (stack_copy_size): Now size_t, not int.
4204 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4205
4206 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4207
4208 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4209 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4210 All callers changed.
4211
4212 * lisp.h (multibyte_char_to_unibyte):
4213 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4214 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4215 * character.h (CHAR_TO_BYTE8):
4216 * cmds.c (internal_self_insert):
4217 * editfns.c (general_insert_function):
4218 * keymap.c (push_key_description):
4219 * search.c (Freplace_match):
4220 * xdisp.c (message_dolog, set_message_1): All callers changed.
4221
4222 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4223
4224 * keyboard.c (safe_run_hook_funcall): New function.
4225 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4226 don't set the hook to nil, but remove the offending function instead.
4227 (Qcommand_hook_internal): Remove, unused.
4228 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4229 Vcommand_hook_internal.
4230
4231 * eval.c (enum run_hooks_condition): Remove.
4232 (funcall_nil, funcall_not): New functions.
4233 (run_hook_with_args): Call each function through a `funcall' argument.
4234 Remove `cond' argument, now redundant.
4235 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4236 (Frun_hook_with_args_until_failure): Adjust accordingly.
4237 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4238
4239 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4240
4241 * dispextern.h (string_buffer_position): Remove declaration.
4242
4243 * print.c (strout): Remove parameter `multibyte', unused since
4244 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4245
4246 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4247 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4248 All callers changed.
4249
4250 * w32.c (_wsa_errlist): Use braces for struct initializers.
4251
4252 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4253 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4254 All callers changed.
4255 (string_buffer_position): Likewise. Also, make static (it's never
4256 used outside xdisp.c).
4257 (cursor_row_p): Remove parameter `w', unused since
4258 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4259 (decode_mode_spec): Remove parameter `precision', introduced during
4260 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4261 All callers changed.
4262
4263 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4264
4265 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4266
4267 2011-03-27 Anders Lindgren <andlind@gmail.com>
4268
4269 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4270 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4271 (ns_update_auto_hide_menu_bar): New functions.
4272 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4273 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4274 ns_constrain_all_frames.
4275 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4276 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4277
4278 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4279
4280 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4281
4282 2011-03-27 Glenn Morris <rgm@gnu.org>
4283
4284 * syssignal.h: Replace RETSIGTYPE with void.
4285 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4286 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4287 Replace SIGTYPE with void everywhere.
4288 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4289 * s/template.h (SIGTYPE): Remove commented out definition.
4290
4291 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4292
4293 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4294 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4295
4296 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4297
4298 * w32.c (read_unc_volume): Use parameter `henum', instead of
4299 global variable `wget_enum_handle'.
4300
4301 * keymap.c (describe_vector): Remove parameters `indices' and
4302 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4303 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4304
4305 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4306
4307 * keyboard.c (timer_check): Remove parameter `do_it_now',
4308 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4309 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4310 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4311
4312 * keyboard.c (read_char):
4313 * w32menu.c (w32_menu_display_help):
4314 * xmenu.c (show_help_event, menu_help_callback):
4315 Adjust calls to `show_help_echo'.
4316
4317 * gtkutil.c (xg_maybe_add_timer):
4318 * keyboard.c (readable_events):
4319 * process.c (wait_reading_process_output):
4320 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4321
4322 * insdel.c (adjust_markers_gap_motion):
4323 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4324 (gap_left, gap_right): Don't call it.
4325
4326 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4327
4328 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4329 incurred during fontification.
4330
4331 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4332
4333 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4334 (DEFVAR_PER_BUFFER): Don't pass it.
4335
4336 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4337 (scrolling_window): Don't pass it.
4338
4339 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4340
4341 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4342
4343 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4344 and `suffix'.
4345 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4346 of variables specific to SELinux and computation of `encoded_absname'.
4347
4348 * image.c (XPutPixel): Remove unused variable `height'.
4349
4350 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4351
4352 * unexw32.c (get_section_info): Remove unused variable `section'.
4353
4354 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4355 (system_process_attributes): Remove unused variable `sess'.
4356 (sys_read): Remove unused variable `err'.
4357
4358 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4359 (w32_wnd_proc): Remove unused variable `isdead'.
4360 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4361 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4362 (x_create_tip_frame): Remove unused variable `tem'.
4363
4364 * w32inevt.c (w32_console_read_socket):
4365 Remove unused variable `no_events'.
4366
4367 * w32term.c (x_draw_composite_glyph_string_foreground):
4368 Remove unused variable `width'.
4369
4370 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4371
4372 * w32term.c (x_set_glyph_string_clipping):
4373 Don't pass uninitialized region to CombineRgn.
4374
4375 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4376
4377 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4378 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4379 (Fx_close_connection): Remove unused variable `i'.
4380
4381 * w32font.c (w32font_draw): Return number of glyphs.
4382 (w32font_open_internal): Remove unused variable `i'.
4383 (w32font_driver): Add missing initializer.
4384
4385 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4386 (fill_in_menu): Remove unused variable `items_added'.
4387
4388 * w32term.c (last_mouse_press_frame): Remove static global variable.
4389 (w32_clip_to_row): Remove unused variable `f'.
4390 (x_delete_terminal): Remove unused variable `i'.
4391
4392 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4393 (NOTHING): Remove unused static global variable.
4394 (uniscribe_check_otf): Remove unused variable `table'.
4395 (uniscribe_font_driver): Add missing initializers.
4396
4397 2011-03-23 Julien Danjou <julien@danjou.info>
4398
4399 * term.c (Fsuspend_tty, Fresume_tty):
4400 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4401 * window.c (temp_output_buffer_show):
4402 * insdel.c (signal_before_change):
4403 * frame.c (Fhandle_switch_frame):
4404 * fileio.c (Fdo_auto_save):
4405 * emacs.c (Fkill_emacs):
4406 * editfns.c (save_excursion_restore):
4407 * cmds.c (internal_self_insert):
4408 * callint.c (Fcall_interactively):
4409 * buffer.c (Fkill_all_local_variables):
4410 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4411 Use Frun_hooks.
4412 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4413 unconditionnaly since it does the check itself.
4414
4415 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4416
4417 Fix more problems found by GCC 4.5.2's static checks.
4418
4419 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4420 the first time through the loop, since we know p0 < p1 then.
4421 This also avoids a gcc -Wstrict-overflow warning.
4422
4423 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4424 leading to a memory leak, possible in functions like
4425 load_charset_map_from_file that can allocate an unbounded number
4426 of objects (Bug#8318).
4427
4428 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4429 that could (at least in theory) be that large.
4430
4431 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4432 This is less likely to overflow, and avoids undefined behavior if
4433 overflow does occur. All callers changed. Use strtoul to scan
4434 for the unsigned long integer.
4435 (pint2hrstr): Simplify and tune code slightly.
4436 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4437
4438 * scroll.c (do_scrolling): Work around GCC bug 48228.
4439 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4440
4441 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4442 This also avoids a warning with gcc -Wstrict-overflow.
4443 (validate_x_resource_name): Simplify count usage.
4444 This also avoids a warning with gcc -Wstrict-overflow.
4445
4446 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4447 fail (Bug#8306).
4448
4449 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4450
4451 * process.c (Fmake_network_process): Use socklen_t, not int,
4452 where POSIX says socklen_t is required in portable programs.
4453 This fixes a porting bug on hosts like 64-bit HP-UX, where
4454 socklen_t is wider than int (Bug#8277).
4455 (Fmake_network_process, server_accept_connection):
4456 (wait_reading_process_output, read_process_output):
4457 Likewise.
4458
4459 * process.c: Rename or move locals to avoid shadowing.
4460 (list_processes_1, Fmake_network_process):
4461 (read_process_output_error_handler, exec_sentinel_error_handler):
4462 Rename or move locals.
4463 (Fmake_network_process): Define label "retry_connect" only if needed.
4464 (Fnetwork_interface_info): Fix pointer signedness.
4465 (process_send_signal): Add cast to avoid pointer signedness problem.
4466 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4467 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4468
4469 Make tparam.h and terminfo.c consistent.
4470 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4471 Include tparam.h instead, since it declares them.
4472 * cm.h (PC): Remove extern decl; tparam.h now does this.
4473 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4474 * terminfo.c: Include tparam.h, to check interfaces.
4475 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4476 (tparam): Adjust signature to match interface in tparam.h;
4477 this removes some undefined behavior. Check that outstring and len
4478 are zero, which they always are with Emacs.
4479 * tparam.h (PC, BC, UP): New extern decls.
4480
4481 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4482 (xftfont_open): Rename locals to avoid shadowing.
4483
4484 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4485 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4486 (OTF_TAG_SYM): Omit macro if not needed.
4487 (ftfont_list): Remove unused local.
4488 (get_adstyle_property, ftfont_pattern_entity):
4489 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4490 Rename locals to avoid shadowing.
4491
4492 * xfont.c (xfont_list_family): Mark var as initialized.
4493
4494 * xml.c (make_dom): Now static.
4495
4496 * composite.c (composition_compute_stop_pos): Rename local to
4497 avoid shadowing.
4498 (composition_reseat_it): Remove unused locals.
4499 (find_automatic_composition, composition_adjust_point): Likewise.
4500 (composition_update_it): Mark var as initialized.
4501 (find_automatic_composition): Mark vars as initialized,
4502 with a FIXME (Bug#8290).
4503
4504 character.h: Rename locals to avoid shadowing.
4505 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4506 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4507 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4508 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4509 to avoid shadowing.
4510
4511 * textprop.c (property_change_between_p): Remove; unused.
4512
4513 * intervals.c (interval_start_pos): Now static.
4514
4515 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4516
4517 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4518 Rename locals to avoid shadowing.
4519
4520 * sound.c (wav_play, au_play, Fplay_sound_internal):
4521 Fix pointer signedness.
4522 (alsa_choose_format): Remove unused local var.
4523 (wav_play): Initialize a variable to 0, to prevent undefined
4524 behavior (Bug#8278).
4525
4526 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4527
4528 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4529
4530 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4531 clobbering (Bug#8298).
4532 * sysdep.c (sys_subshell): Likewise.
4533 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4534
4535 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4536 This should get cleaned up, so that child_setup has the
4537 same signature on all platforms.
4538
4539 * callproc.c (call_process_cleanup): Now static.
4540 (relocate_fd): Rename locals to avoid shadowing.
4541
4542 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4543
4544 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4545 not to be necessary, and produces flickering.
4546
4547 2011-03-20 Glenn Morris <rgm@gnu.org>
4548
4549 * config.in: Remove file.
4550
4551 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4552
4553 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4554 are now in src/globals.h.
4555 (syms_of_minibuf): Remove spurious & from previous change.
4556
4557 2011-03-20 Leo <sdl.web@gmail.com>
4558
4559 * minibuf.c (completing-read-function): New variable.
4560 (completing-read-default): Rename from completing-read.
4561 (completing-read): Call completing-read-function.
4562
4563 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4564
4565 * xfaces.c (Fx_load_color_file):
4566 Read color file from absolute filename (bug#8250).
4567
4568 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4569
4570 * makefile.w32-in: Update dependencies.
4571
4572 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4573
4574 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4575
4576 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4577
4578 Fix more problems found by GCC 4.5.2's static checks.
4579
4580 * process.c (make_serial_process_unwind, send_process_trap):
4581 (sigchld_handler): Now static.
4582
4583 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4584 That way, the code declares only the vars that it needs.
4585 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4586 * s/cygwin.h (PTY_ITERATION): Likewise.
4587 * s/darwin.h (PTY_ITERATION): Likewise.
4588 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4589
4590 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4591 * process.c (allocate_pty): Don't declare stb unless it's needed.
4592
4593 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4594 (CONSTANTLIM): Remove; unused.
4595 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4596 Define only if needed.
4597
4598 * unexelf.c (unexec): Name an expression,
4599 to avoid gcc -Wbad-function-cast warning.
4600 Use a different way to cause a compilation error if anyone uses
4601 n rather than nn, a way that does not involve shadowing.
4602 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4603
4604 * deps.mk (unexalpha.o): Remove; unused.
4605
4606 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4607 * unexec.h: New file.
4608 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4609 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4610 Depend on unexec.h.
4611 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4612 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4613 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4614 Change as necessary to match prototype in unexec.h.
4615
4616 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4617 shadowing.
4618 (back_comment, skip_chars): Mark vars as initialized.
4619
4620 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4621 Rename locals to avoid shadowing.
4622
4623 * lread.c (read1): Rewrite so as not to use empty "else".
4624 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4625
4626 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4627
4628 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4629 warning when compiling print.c.
4630
4631 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4632 instead of using an uninitialized var.
4633 (font_sort_entities): Mark var as initialized.
4634
4635 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4636
4637 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4638 pointers to constants.
4639 (font_parse_fcname): Remove unused vars.
4640 (font_delete_unmatched): Now static.
4641 (font_get_spec): Remove; unused.
4642 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4643 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4644 Rename or move locals to avoid shadowing.
4645
4646 * fns.c (require_nesting_list, require_unwind): Now static.
4647 (Ffillarray): Rename locals to avoid shadowing.
4648
4649 * floatfns.c (domain_error2): Define only if needed.
4650 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4651
4652 * alloc.c (mark_backtrace): Move decl from here ...
4653 * lisp.h: ... to here, so that it can be checked.
4654
4655 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4656 (Fdefvar): Rewrite so as not to use empty "else".
4657 (lisp_indirect_variable): Name an expression,
4658 to avoid gcc -Wbad-function-cast warning.
4659 (Fdefvar): Rename locals to avoid shadowing.
4660
4661 * callint.c (quotify_arg, quotify_args): Now static.
4662 (Fcall_interactively): Rename locals to avoid shadowing.
4663 Use const pointer when appropriate.
4664
4665 * lisp.h (get_system_name, get_operating_system_release):
4666 Move decls here, to check interfaces.
4667 * process.c (get_operating_system_release): Move decl to lisp.h.
4668 * xrdb.c (get_system_name): Likewise.
4669 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4670 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4671 some of which prompt warnings from gcc -Wbad-function-cast.
4672 (Fformat_time_string, Fencode_time, Finsert_char):
4673 (Ftranslate_region_internal, Fformat):
4674 Rename or remove local vars to avoid shadowing.
4675 (Ftranslate_region_internal): Mark var as initialized.
4676
4677 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4678 avoid shadowing.
4679
4680 * lisp.h (eassert): Check that the argument compiles, even if
4681 ENABLE_CHECKING is not defined.
4682
4683 * data.c (Findirect_variable): Name an expression, to avoid
4684 gcc -Wbad-function-cast warning.
4685 (default_value, arithcompare, arith_driver, arith_error): Now static.
4686 (store_symval_forwarding): Rename local to avoid shadowing.
4687 (Fmake_variable_buffer_local, Fmake_local_variable):
4688 Mark variables as initialized.
4689 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4690
4691 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4692 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4693 Rename locals to avoid shadowing.
4694 (mark_stack): Move local variables into the #ifdef region where
4695 they're used.
4696 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4697 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4698 needed otherwise.
4699 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4700 (GC_STRING_CHARS): Remove; not used.
4701 (Fmemory_limit): Cast sbrk's returned value to char *.
4702
4703 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4704 avoids undefined behavior in theory.
4705
4706 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4707
4708 Use functions, not macros, for up- and down-casing (Bug#8254).
4709 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4710 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4711 to use the following functions instead of these macros.
4712 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4713 EMACS_INT, since callers assume the returned value fits in int.
4714 (upcase1): Likewise, for UPCASE_TABLE.
4715 (uppercasep, lowercasep, upcase): New static inline functions.
4716 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4717 the race-condition problem in the old DOWNCASE.
4718
4719 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4720 Rename locals to avoid shadowing.
4721 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4722 (regex_compile, re_search_2, re_match_2_internal):
4723 Remove unused local vars.
4724 (FREE_VAR): Rewrite so as not to use empty "else",
4725 which gcc can warn about.
4726 (regex_compile, re_match_2_internal): Mark locals as initialized.
4727 (RETALLOC_IF): Define only if needed.
4728 (WORDCHAR_P): Likewise. This one is never needed, but is used
4729 only in a comment talking about a compiler bug, so put inside
4730 the #if 0 of that comment.
4731 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4732 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4733 Remove; unused.
4734
4735 * search.c (boyer_moore): Rename locals to avoid shadowing.
4736 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4737 (PREV_CHAR_BOUNDARY): Likewise.
4738
4739 * search.c (simple_search): Remove unused var.
4740
4741 * dired.c (compile_pattern): Move decl from here ...
4742 * lisp.h: ... to here, so that it can be checked.
4743 (struct re_registers): New forward decl.
4744
4745 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4746
4747 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4748 All uses changed.
4749 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4750 Rename locals to avoid shadowing.
4751 (Fvertical_motion): Mark locals as initialized.
4752
4753 * casefiddle.c (casify_object, casify_region): Now static.
4754 (casify_region): Mark local as initialized.
4755
4756 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4757
4758 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4759 New macros, so that the caller can use some names other than
4760 gcpro1, gcpro2, etc.
4761 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4762 of the new macros.
4763 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4764 argument, for consistency with GCPRO2_VAR, etc: it is now the
4765 prefix of the variable, not the variable itself. All uses
4766 changed.
4767 * dired.c (directory_files_internal, file_name_completion):
4768 Rename locals to avoid shadowing.
4769
4770 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4771 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4772 dired.c's scmp function, had undefined behavior.
4773 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4774 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4775 * buffer.h: ... to here, because these macros use current_buffer,
4776 and the new implementation with inline functions needs to have
4777 current_buffer in scope now, rather than later when the macros
4778 are used.
4779 (downcase, upcase1): New static inline functions.
4780 (DOWNCASE, UPCASE1): Reimplement using these functions.
4781 This avoids undefined behavior in expressions like
4782 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4783 from race conditions in accessing the global variables
4784 case_temp1 and case_temp2.
4785 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4786 * lisp.h (case_temp1, case_temp2): Remove their decls.
4787 * character.h (ASCII_CHAR_P): Move from here ...
4788 * lisp.h: ... to here, so that the inline functions mentioned
4789 above can use them.
4790
4791 * dired.c (directory_files_internal_unwind): Now static.
4792
4793 * fileio.c (file_name_as_directory, directory_file_name):
4794 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4795 Now static.
4796 (file_name_as_directory): Use const pointers when appropriate.
4797 (Fexpand_file_name): Likewise. In particular, newdir might
4798 point at constant storage, so make it a const pointer.
4799 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4800 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4801 signedness issues.
4802 (Fset_file_times, Finsert_file_contents, auto_save_error):
4803 Rename locals to avoid shadowing.
4804
4805 * minibuf.c (choose_minibuf_frame_1): Now static.
4806 (Ftry_completion, Fall_completions): Rename or remove locals
4807 to avoid shadowing.
4808
4809 * marker.c (bytepos_to_charpos): Remove; unused.
4810
4811 * lisp.h (verify_bytepos, count_markers): New decls,
4812 so that gcc does not warn that these functions aren't declared.
4813
4814 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4815 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4816 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4817 (copy_text): Remove unused local var.
4818
4819 * filelock.c (within_one_second): Now static.
4820 (lock_file_1): Rename local to avoid shadowing.
4821
4822 * buffer.c (fix_overlays_before): Mark locals as initialized.
4823 (fix_start_end_in_overlays): Likewise. This function should be
4824 simplified by using pointers-to-pointers, but that's a different
4825 matter.
4826 (switch_to_buffer_1): Now static.
4827 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4828 (report_overlay_modification): Rename locals to avoid shadowing.
4829
4830 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4831 Fix pointer signedness issue.
4832 (sys_subshell): Mark local as volatile if checking for lint,
4833 to suppress a gcc -Wclobbered warning that does not seem to be right.
4834 (MAXPATHLEN): Define only if needed.
4835
4836 * process.c (serial_open, serial_configure): Move decls from here ...
4837 * systty.h: ... to here, so that they can be checked.
4838
4839 * fns.c (get_random, seed_random): Move extern decls from here ...
4840 * lisp.h: ... to here, so that they can be checked.
4841
4842 * sysdep.c (reset_io): Now static.
4843 (wait_for_termination_signal): Remove; unused.
4844
4845 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4846 (copy_keymap_item, append_key, push_text_char_description):
4847 Now static.
4848 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4849 (DENSE_TABLE_SIZE): Remove; unused.
4850 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4851 (describe_map_tree):
4852 Rename locals to avoid shadowing.
4853
4854 * keyboard.c: Declare functions static if they are not used elsewhere.
4855 (echo_char, echo_dash, cmd_error, top_level_2):
4856 (poll_for_input, handle_async_input): Now static.
4857 (read_char, kbd_buffer_get_event, make_lispy_position):
4858 (make_lispy_event, make_lispy_movement, apply_modifiers):
4859 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4860 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4861 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4862 (read_key_sequence, read_char): Mark locals as initialized.
4863 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4864
4865 * keyboard.h (make_ctrl_char): New decl.
4866 (mark_kboards): Move decl here ...
4867 * alloc.c (mark_kboards): ... from here.
4868
4869 * lisp.h (force_auto_save_soon): New decl.
4870
4871 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4872 (DEFINE_DUMMY_FUNCTION): New macro.
4873 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4874 Use it.
4875 (main): Add casts to avoid warnings
4876 if GCC considers string literals to be constants.
4877
4878 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4879
4880 * dbusbind.c: Pointer signedness fixes.
4881 (xd_signature, xd_append_arg, xd_initialize):
4882 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4883 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4884 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4885 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4886
4887 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4888 if GCC considers string literals to be constants.
4889 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4890
4891 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4892
4893 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4894 (print_preprocess, print_object): New macro to fix last change.
4895
4896 * print.c (print_preprocess): Don't forget font objects.
4897
4898 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4899
4900 * emacs.c (USAGE3): Doc fixes.
4901
4902 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4903
4904 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4905 structure.
4906
4907 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4908
4909 * lisp.h (VWindow_system, Qfile_name_history):
4910 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4911 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4912 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4913
4914 * w32select.c: Don't #include "keyboard.h".
4915 (run_protected): Add extern declaration for waiting_for_input.
4916
4917 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4918 * w32console.c (detect_input_pending, read_input_pending)
4919 (encode_terminal_code):
4920 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4921 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4922 (w32_system_caret_y, Qfile_name_history):
4923 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4924 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4925 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4926 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4927 * w32proc.c (Qlocal, report_file_error):
4928 * w32term.c (Vwindow_system, updating_frame):
4929 * w32uniscribe.c (initialized, uniscribe_font_driver):
4930 Remove unneeded extern declarations.
4931
4932 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4933
4934 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4935
4936 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4937
4938 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4939 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4940 These macros can no longer be used for assignment.
4941
4942 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4943 Assign struct members directly, instead of using BUF_BEGV etc.
4944 (record_buffer_markers, fetch_buffer_markers): New functions for
4945 recording and fetching special buffer markers.
4946 (set_buffer_internal_1, set_buffer_temp): Use them.
4947
4948 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4949
4950 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4951
4952 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4953 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4954
4955 * xdisp.c (hscroll_window_tree):
4956 (reconsider_clip_changes): Use PT instead of BUF_PT.
4957
4958 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4959
4960 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4961 $(EMACS_ROOT)/lib/intprops.h.
4962
4963 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4964
4965 Fix more problems found by GCC 4.5.2's static checks.
4966
4967 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4968 to unsigned char * to avoid compiler diagnostic.
4969 (xg_free_frame_widgets): Make it clear that a local variable is
4970 needed only if USE_GTK_TOOLTIP.
4971 (gdk_window_get_screen): Make it clear that this macro is needed
4972 only if USE_GTK_TOOLTIP.
4973 (int_gtk_range_get_value): New function, which avoids a diagnostic
4974 from gcc -Wbad-function-cast.
4975 (xg_set_toolkit_scroll_bar_thumb): Use it.
4976 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4977 diagnostic from gcc -Wbad-function-cast.
4978 (get_utf8_string, xg_get_file_with_chooser):
4979 Rename locals to avoid shadowing.
4980 (create_dialog): Move locals to avoid shadowing.
4981
4982 * xgselect.c (xg_select): Remove unused var.
4983
4984 * image.c (four_corners_best): Mark locals as initialized.
4985 (gif_load): Initialize transparent_p to zero (Bug#8238).
4986 Mark another local as initialized.
4987 (my_png_error, my_error_exit): Mark with NO_RETURN.
4988
4989 * image.c (clear_image_cache): Now static.
4990 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4991 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4992 (x_edge_detection): Remove unnecessary cast that
4993 gcc -Wbad-function-cast diagnoses.
4994 (gif_load): Fix pointer signedness.
4995 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4996 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4997
4998 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4999
5000 Improve quality of tests for time stamp overflow.
5001 For example, without this patch (encode-time 0 0 0 1 1
5002 1152921504606846976) returns the obviously-bogus value (-948597
5003 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5004 reports time overflow. See
5005 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5006 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5007 * editfns.c: Include limits.h and intprops.h.
5008 (TIME_T_MIN, TIME_T_MAX): New macros.
5009 (time_overflow): Move earlier, to before first use.
5010 (hi_time, lo_time): New functions, for an accurate test for
5011 out-of-range times.
5012 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5013 (Fget_internal_run_time): Don't assume time_t fits in int.
5014 (make_time): Use list2 instead of Fcons twice.
5015 (Fdecode_time): More accurate test for out-of-range times.
5016 (check_tm_member): New function.
5017 (Fencode_time): Use it, to test for out-of-range times.
5018 (lisp_time_argument): Don't rely on undefined left-shift and
5019 right-shift behavior when checking for time stamp overflow.
5020
5021 * editfns.c (time_overflow): New function, refactoring common code.
5022 (Fformat_time_string, Fdecode_time, Fencode_time):
5023 (Fcurrent_time_string): Use it.
5024
5025 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5026 * dired.c (make_time): Move to ...
5027 * editfns.c (make_time): ... here.
5028 * systime.h: Note the move.
5029
5030 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5031
5032 * fringe.c (update_window_fringes): Remove unused variables.
5033
5034 * unexmacosx.c (copy_data_segment): Also copy __got section.
5035 (Bug#8223)
5036
5037 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5038
5039 * termcap.c [MSDOS]: Include "msdos.h".
5040 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5041 Constify `char *' arguments and their references according to
5042 prototypes in tparam.h.
5043
5044 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5045
5046 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5047 Adapt all references accordingly.
5048
5049 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5050
5051 2011-03-11 Tom Tromey <tromey@redhat.com>
5052
5053 * buffer.c (syms_of_buffer): Remove obsolete comment.
5054
5055 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5056
5057 * termhooks.h (encode_terminal_code): Declare prototype.
5058
5059 * msdos.c (encode_terminal_code): Don't declare prototype.
5060
5061 * term.c (encode_terminal_code): Now external again, used by
5062 w32console.c and msdos.c.
5063
5064 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5065 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5066
5067 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5068
5069 Fix some minor problems found by GCC 4.5.2's static checks.
5070
5071 * fringe.c (update_window_fringes): Mark locals as initialized
5072 (Bug#8227).
5073 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5074
5075 * alloc.c (mark_fringe_data): Move decl from here ...
5076 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5077 to check its interface.
5078 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5079
5080 * fontset.c (free_realized_fontset): Now static.
5081 (Fset_fontset_font): Rename local to avoid shadowing.
5082 (fontset_font): Mark local as initialized.
5083 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5084
5085 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5086
5087 * xselect.c (x_disown_buffer_selections): Remove; not used.
5088 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5089 (x_own_selection, Fx_disown_selection_internal): Rename locals
5090 to avoid shadowing.
5091 (x_handle_dnd_message): Remove local to avoid shadowing.
5092
5093 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5094 so that the caller can use some name other than gcpro1.
5095 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5096 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5097 (Fx_backspace_delete_keys_p):
5098 Use them to avoid shadowing, and rename vars to avoid shadowing.
5099 (x_decode_color, x_set_name, x_window): Now static.
5100 (Fx_create_frame): Add braces to silence GCC warning.
5101 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5102 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5103 Remove unused locals.
5104 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5105 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5106 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5107 macros.
5108
5109 * xterm.h (x_mouse_leave): New decl.
5110
5111 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5112 Remove unused functions.
5113 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5114 (x_calc_absolute_position): Now static.
5115 (XTread_socket): Don't define label "out" unless it's used.
5116 Don't declare local "event" unless it's used.
5117 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5118 unless they are used.
5119 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5120 (x_fatal_error_signal): Remove; not used.
5121 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5122 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5123 (x_error_catcher, x_connection_closed, x_error_handler):
5124 (x_error_quitter, xembed_send_message, x_iconify_frame):
5125 (my_log_handler): Rename locals to avoid shadowing.
5126 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5127 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5128
5129 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5130 Rename or move locals to avoid shadowing.
5131 (tty_defined_color, merge_face_heights): Now static.
5132 (free_realized_faces_for_fontset): Remove; not used.
5133 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5134 does not deduce is never used uninitialized.
5135 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5136 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5137
5138 * terminal.c (store_terminal_param): Now static.
5139
5140 * xmenu.c (menu_highlight_callback): Now static.
5141 (set_frame_menubar): Remove unused local.
5142 (xmenu_show): Rename parameter to avoid shadowing.
5143 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5144 since they might point to immutable storage.
5145 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5146 since it's unused otherwise.
5147
5148 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5149 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5150 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5151 avoids a gcc -Wuninitialized diagnostic.
5152 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5153 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5154 does not deduce are never used uninitialized.
5155
5156 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5157
5158 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5159 * window.c (window_loop, size_window):
5160 (run_window_configuration_change_hook, enlarge_window): Likewise.
5161
5162 * window.c (display_buffer): Now static.
5163 (size_window): Mark variables that gcc -Wuninitialized
5164 does not deduce are never used uninitialized.
5165 * window.h (check_all_windows): New decl, to forestall
5166 gcc -Wmissing-prototypes diagnostic.
5167 * dispextern.h (bidi_dump_cached_states): Likewise.
5168
5169 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5170 shadowing.
5171 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5172 Include <limits.h>.
5173 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5174 and to avoid gcc -Wuninitialized warning.
5175 (load_charset_map): Mark variables that gcc -Wuninitialized
5176 does not deduce are never used uninitialized.
5177 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5178
5179 * coding.c (coding_set_source, coding_set_destination):
5180 Use "else { /* comment */ }" rather than "else /* comment */;"
5181 for clarity, and to avoid gcc -Wempty-body warning.
5182 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5183 a block, when the outer 'i' will do.
5184 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5185 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5186 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5187 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5188 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5189 Rename locals to avoid shadowing.
5190 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5191 * coding.c (emacs_mule_char, encode_invocation_designation):
5192 Now static, since they're not used elsewhere.
5193 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5194 (decode_coding_object, encode_coding_object, detect_coding_system):
5195 (decode_coding_emacs_mule): Mark variables that gcc
5196 -Wuninitialized does not deduce are never used uninitialized.
5197 (detect_coding_iso_2022): Initialize a local variable that might
5198 be used uninitialized. Leave a FIXME because it's not clear that
5199 this initialization is needed. (Bug#8211)
5200 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5201 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5202 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5203 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5204 Remove unused macros.
5205
5206 * category.c (hash_get_category_set): Remove unused local var.
5207 (copy_category_table): Now static, since it's not used elsewhere.
5208 * character.c (string_count_byte8): Likewise.
5209
5210 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5211 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5212
5213 * chartab.c (copy_sub_char_table): Now static, since it's not used
5214 elsewhere.
5215 (sub_char_table_ref_and_range, char_table_ref_and_range):
5216 Rename locals to avoid shadowing.
5217 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5218
5219 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5220 (BIDI_BOB): Remove unused macro.
5221
5222 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5223 deduce are never used uninitialized.
5224 * term.c (encode_terminal_code): Likewise.
5225
5226 * term.c (encode_terminal_code): Now static. Remove unused local.
5227
5228 * tparam.h: New file.
5229 * term.c, tparam.h: Include it.
5230 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5231 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5232 Move these decls to tparam.h, and make them agree with what
5233 is actually in tparam.c. The previous trick of using incompatible
5234 decls in different modules does not conform to the C standard.
5235 All callers of tparam changed to use tparam's actual API.
5236 * tparam.c (tparam1, tparam, tgoto):
5237 Use const pointers where appropriate.
5238
5239 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5240 * cm.h (struct cm): Likewise.
5241 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5242 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5243 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5244 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5245 (turn_on_face, init_tty): Likewise.
5246 * termchar.h (struct tty_display_info): Likewise.
5247
5248 * term.c (term_mouse_position): Rename local to avoid shadowing.
5249
5250 * alloc.c (mark_ttys): Move decl from here ...
5251 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5252
5253 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5254
5255 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5256
5257 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5258
5259 * search.c (compile_pattern_1): Remove argument regp, unused since
5260 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5261 (compile_pattern): Don't pass it.
5262
5263 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5264
5265 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5266 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5267 for ! HAVE_GTK3.
5268 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5269
5270 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5271
5272 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5273 gdk_window_get_screen, gdk_window_get_geometry,
5274 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5275 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5276 (xg_get_pixbuf_from_pixmap): New function.
5277 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5278 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5279 Call xg_get_pixbuf_from_pixmap instead of
5280 gdk_pixbuf_get_from_drawable.
5281 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5282 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5283 (xg_check_special_colors): Use GtkStyleContext and its functions
5284 for HAVE_GTK3.
5285 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5286 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5287 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5288 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5289 Call gtk_widget_get_preferred_size.
5290 (xg_frame_resized): gdk_window_get_geometry only takes 5
5291 parameters.
5292 (xg_win_to_widget, xg_event_is_for_menubar):
5293 Call gdk_x11_window_lookup_for_display.
5294 (xg_set_widget_bg): New function.
5295 (delete_cb): New function.
5296 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5297 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5298 (xg_set_background_color): Call xg_set_widget_bg.
5299 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5300 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5301 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5302 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5303 if ! HAVE_GTK3.
5304 (update_frame_tool_bar): Call gtk_widget_hide.
5305 (xg_initialize): Use GDK_KEY_g.
5306
5307 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5308 if ! HAVE_GTK3
5309 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5310
5311 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5312 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5313 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5314
5315 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5316
5317 * w32xfns.c (select_palette): Check success of RealizePalette against
5318 GDI_ERROR, not zero.
5319
5320 See ChangeLog.11 for earlier changes.
5321
5322 ;; Local Variables:
5323 ;; coding: utf-8
5324 ;; End:
5325
5326 Copyright (C) 2011 Free Software Foundation, Inc.
5327
5328 This file is part of GNU Emacs.
5329
5330 GNU Emacs is free software: you can redistribute it and/or modify
5331 it under the terms of the GNU General Public License as published by
5332 the Free Software Foundation, either version 3 of the License, or
5333 (at your option) any later version.
5334
5335 GNU Emacs is distributed in the hope that it will be useful,
5336 but WITHOUT ANY WARRANTY; without even the implied warranty of
5337 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5338 GNU General Public License for more details.
5339
5340 You should have received a copy of the GNU General Public License
5341 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.