1 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
8 2011-11-06 Chong Yidong <cyd@gnu.org>
10 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
11 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
12 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
13 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
14 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
15 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
16 (Fwindow_vscroll): Doc fix.
17 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
18 argument, since it makes no sense to pass a live window and for
19 consistency with window-child.
21 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
23 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
26 2011-11-05 Jason Rumney <jasonr@gnu.org>
28 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
29 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
31 (add_font_entity_to_list): Fix logic errors in mixed boolean and
32 bitwise arithmetic preventing use of unicode-sip and non-truetype
35 2011-11-05 Eli Zaretskii <eliz@gnu.org>
37 * s/ms-w32.h (fstat, stat, utime): Move redirections to
40 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
41 initialization code to keep similarity to xfns.c after changes
44 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
46 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
47 (unwind_create_frame): New function (Bug#9943).
48 (Fx_create_frame): Restructure code to be more similar to the one in
49 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
50 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
51 Move terminal->reference_count++ just before making the frame official
54 * nsterm.m (x_free_frame_resources): New function.
55 (x_destroy_window): Move code to x_free_frame_resources.
57 * xfns.c (unwind_create_frame): Fix comment.
58 (Fx_create_frame, x_create_tip_frame): Move
59 terminal->reference_count++ just before making the frame
60 official. Move initialization of image_cache_refcount and
61 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
63 2011-11-05 Eli Zaretskii <eliz@gnu.org>
65 Support MSVC build with newer versions of Visual Studio.
66 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
67 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
70 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
71 which are not supported by MSVC.
72 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
73 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
75 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
77 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
79 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
81 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
83 Support MSVC build with newer versions of Visual Studio.
84 * w32.c: Don't include w32api.h for MSVC.
85 (init_environment) [_MSC_VER]: Call sys_access, not _access.
87 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
88 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
89 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
90 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
92 (alloca) [_MSC_VER]: Define to _alloca.
94 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
96 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
98 2011-11-04 Eli Zaretskii <eliz@gnu.org>
100 * xdisp.c (note_mouse_highlight): If either of
101 previous/next-single-property-change returns nil, treat that as
102 the beginning or the end of the buffer. (Bug#9955)
104 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
106 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
107 label is not null (Bug#9951).
108 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
111 2011-11-04 Eli Zaretskii <eliz@gnu.org>
113 * window.c (Fwindow_body_size): Mention in the doc string that the
114 return value is in frame's canonical units. (Bug#9949)
116 2011-11-03 Eli Zaretskii <eliz@gnu.org>
118 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
120 * w32fns.c (unwind_create_frame): If needed, free the glyph
121 matrices of the partially constructed frame. (Bug#9943)
122 * xfns.c (unwind_create_frame): Likewise.
124 2011-11-01 Eli Zaretskii <eliz@gnu.org>
126 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
127 Don't stop backward scan on the continuation glyph, even though
128 its CHARPOS is positive.
129 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
130 cover_string to disp_string.
132 2011-11-01 Martin Rudalics <rudalics@gmx.at>
134 * window.c (temp_output_buffer_show): Don't use
135 Vtemp_buffer_show_specifiers.
136 (Vtemp_buffer_show_specifiers): Remove unused variable.
138 2011-10-30 Eli Zaretskii <eliz@gnu.org>
140 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
141 past the beginning of the current glyph matrix.
143 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
145 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
146 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
147 HAVE_GTK3 (Bug#9869).
149 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
150 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
152 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
154 * xterm.c: Declare x_handle_net_wm_state to return int.
155 (handle_one_xevent): Check if we are iconified but don't have
156 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
157 (get_current_wm_state): Return non-zero if not hidden,
158 check for _NET_WM_STATE_HIDDEN (Bug#9893).
159 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
160 (x_handle_net_wm_state): Return what get_current_wm_state returns.
161 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
163 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
165 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
166 so that this new function doesn't get optimized away by a
167 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
169 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
171 * frame.h (MOUSE_HL_INFO): Remove excess parens.
173 2011-10-29 Eli Zaretskii <eliz@gnu.org>
175 Fix the `xbytecode' command.
176 * .gdbinit (xprintbytestr): New command.
177 (xwhichsymbols): Renamed from `which'; all callers changed.
178 (xbytecode): Print the byte-code string as well.
180 2011-10-29 Kim Storm <storm@cua.dk>
182 * alloc.c (which_symbols): New function.
184 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
186 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
189 2011-10-29 Glenn Morris <rgm@gnu.org>
191 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
192 Not clear what it was for, and it causes various bugs. (Bug#9839)
194 2011-10-28 Eli Zaretskii <eliz@gnu.org>
196 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
197 possible random value that matches one of those tested as
198 condition to clear the mouse face.
200 2011-10-28 Chong Yidong <cyd@gnu.org>
202 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
204 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
206 * window.c (make_window): Initialize phys_cursor_on_p.
208 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
210 * lisp.h (struct Lisp_Symbol): Update comments.
212 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
214 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
216 2011-10-28 Eli Zaretskii <eliz@gnu.org>
218 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
219 <oslsachem@gmail.com> for helping to debug this.
221 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
222 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
223 (g_b_init_get_glyph_outline_w): New static variables.
224 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
225 (GetGlyphOutlineW_Proc): New typedefs.
226 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
227 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
229 (w32font_open_internal, compute_metrics):
230 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
231 instead of calling the "wide" APIs directly.
233 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
235 * w32.h (syms_of_w32font): Add prototype.
237 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
239 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
240 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
241 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
242 (Fmove_to_window_line): Doc fix.
244 2011-10-27 Chong Yidong <cyd@gnu.org>
246 * process.c (make_process): Set gnutls_state to NULL.
248 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
249 non-NULL, regardless of GNUTLS_INITSTAGE.
250 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
251 an error. Set process slots as soon as we allocate them.
253 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
255 2011-10-27 Chong Yidong <cyd@gnu.org>
257 * gnutls.c (emacs_gnutls_deinit): New function.
258 Deallocate credentials structures as well as calling gnutls_deinit.
259 (Fgnutls_deinit, Fgnutls_boot): Use it.
261 * process.c (make_process): Initialize GnuTLS credentials to NULL.
262 (deactivate_process): Call emacs_gnutls_deinit.
264 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
266 * image.c (x_create_x_image_and_pixmap):
267 * w32.c (sys_rename, w32_delayed_load):
268 * w32font.c (fill_in_logfont):
269 * w32reg.c (x_get_string_resource): Silence compiler warnings.
271 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
273 * w32fns.c (w32_default_color_map): New function,
274 extracted from Fw32_default_color_map.
275 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
277 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
279 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
281 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
283 * keyboard.c (test_undefined): New function (bug#9751).
284 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
286 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
288 * sysdep.c (init_sys_modes): Fix the check for the controlling
291 2011-10-20 Eli Zaretskii <eliz@gnu.org>
293 * dispextern.h (struct bidi_it): New member next_en_type.
295 * bidi.c (bidi_line_init): Initialize the next_en_type member.
296 (bidi_resolve_explicit_1): When next_en_pos is valid for the
297 current character, check also for next_en_type being WEAK_EN.
298 (bidi_resolve_weak): Don't enter the expensive loop if the current
299 position is before next_en_pos. Record the bidi type of the first
300 non-ET, non-BN character we find, in addition to its position.
301 (bidi_level_of_next_char): Invalidate next_en_type when
302 next_en_pos is over-stepped.
304 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
306 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
307 * editfns.c: Rewrite current-time-zone so that it invokes
308 the equivalent of (format-time-string "%Z") to get the time zone name.
309 This fixes a bug when the time zone name contains characters that
310 need converting from the system time locale to Emacs internal format.
311 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
312 that patch fixed format-time-string to do the conversion, but
313 I forgot to fix current-time-zone.
314 (format_time_string): New function, containing most of
315 what Fformat_time_string used to contain.
316 (Fformat_time_string): Rewrite in terms of format_time_string.
317 This doesn't change this function's behavior.
318 (current-time-zone): Rewrite to use format_time_string.
319 This fixes the bug reported by Michael Schierl in
320 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
321 Jason Rumney's 2007-06-07 change worked around this bug, but
323 * systime.h (tzname, timezone): Remove no-longer-used declarations.
325 2011-10-19 Eli Zaretskii <eliz@gnu.org>
327 * xdisp.c (start_display): If the character at POS is displayed
328 via a display vector, reset IT->current.dpvec_index to zero.
329 (try_window_reusing_current_matrix): If a line ends in a display
330 vector or the next line starts in a display vector, continue
331 redrawing the window even though the character position of
332 start_row was reached.
335 2011-10-18 Chong Yidong <cyd@gnu.org>
337 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
338 with nobreak-char-display too.
340 2011-10-18 Eli Zaretskii <eliz@gnu.org>
342 Fix part 3 of bug#9771.
343 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
344 (bidi_resolve_neutral): Don't enter the expensive loop looking for
345 non-neutral characters if the current character is a paragraph
346 separator (a.k.a. Newline). This avoids running the same
347 expensive loop twice, once when we consume the preceding newline
348 and the other time when the line actually needs to be displayed.
349 Avoid the loop when we see neutrals on the base embedding level
350 following a character whose directionality is the same as the
351 paragraph's. This avoids running the expensive loop when a line
352 ends in a long sequence of neutrals, like control characters.
353 Add assertion against STRONG_AL type. Slightly rearrange code
354 that determines the type of a neutral given the first non-neutral
356 (bidi_level_of_next_char): Set next_en_pos to zero when
357 invalidating its info.
359 2011-10-17 Eli Zaretskii <eliz@gnu.org>
361 * xdisp.c (push_display_prop): Determine whether to record string
362 or buffer position by IT->string, not by IT->method. Allow
363 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
364 (move_it_vertically_backward): Don't look for character position
365 immediately after the newline when in a continuation line.
368 2011-10-15 Martin Rudalics <rudalics@gmx.at>
370 * window.c (coordinates_in_window): Rewrite and delabelize
371 vertical border check. (Bug#5357) (Bug#9618)
373 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
375 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
376 errors in XSetWindowBorder (bug#9310).
378 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
380 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
381 avoid crash when xmalloc overrun checking is enabled.
383 2011-10-13 Eli Zaretskii <eliz@gnu.org>
385 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
386 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
387 cursor motion with <left> and <right> arrow keys.
389 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
390 some callers set that themselves.
392 2011-10-12 Eli Zaretskii <eliz@gnu.org>
394 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
395 display string and the previous row comes from the same string and
396 is empty. (Bug#9739) (Bug#9738)
398 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
400 * doc.c (get_doc_string): Encode file name (bug#9735).
402 2011-10-12 Eli Zaretskii <eliz@gnu.org>
404 * bidi.c (bidi_level_of_next_char):
405 * xdisp.c (get_visually_first_element): Remove old incorrect
406 comments regarding the Unicode Line Separator character.
408 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
410 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
412 * alloc.c (Fgc_status): Do not access beyond zombies array
413 boundary if nzombies > MAX_ZOMBIES.
414 * alloc.c (dump_zombies): Add missing format specifier.
416 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
418 * xdisp.c (set_cursor_from_row): Simplify conditionals,
419 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
421 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
422 Some packages use them to denote characters with modifiers.
424 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
426 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
427 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
428 matching a pp-number. Rename parameter var to var1.
430 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
432 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
434 2011-10-08 Glenn Morris <rgm@gnu.org>
436 * callint.c (Fcall_interactively): Give a more explicit error for the
437 'c' case with a non-character input. (Bug#8479)
439 2011-10-08 Eli Zaretskii <eliz@gnu.org>
441 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
443 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
444 lines that are hscrolled on the left.
446 * dispnew.c (buffer_posn_from_coords): Account for a possible
447 presence of header-line. (Bug#4426)
449 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
451 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
452 Don't advertise functionality which we discourage or doesn't work.
454 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
456 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
457 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
458 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
459 this makes Emacs dump core during garbage collection on rare
460 occasions. sizeof is obviously inferior to offsetof here, so
462 (GC_POINTER_ALIGNMENT): New macro.
463 (mark_memory): Omit 3rd (offset) arg; caller changed.
464 Don't assume EMACS_INT alignment is the same as pointer alignment.
466 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
468 * keyboard.c (read_key_sequence_remapped): New var.
469 (read_key_sequence): Compute remapping in the right buffer.
470 (command_loop_1): Use read_key_sequence's remapping directly.
472 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
474 * dired.c (file_name_completion): Don't expand file name.
475 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
476 before checking file name handler.
478 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
479 they've been requested explicitly (bug#9591).
481 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
483 * keymap.c (Fsingle_key_description): Use make_specified_string
484 instead of build_string to build string from push_key_description.
487 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
489 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
490 This fixes a Y2038 bug on 64-bit hosts.
491 * buffer.c (reset_buffer):
492 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
493 (Fclear_buffer_auto_save_failure):
494 Use 0, not -1, to represent an unset failure time, since time_t
497 Remove dependency on glibc malloc internals.
498 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
499 Move back here from lisp.h, but with their new implementations.
500 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
501 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
502 * charset.c (charset_table_init): New static var.
503 (syms_of_charset): Use it instead of xmalloc. This removes a
504 dependency on glibc malloc internals. See Eli Zaretskii's comment in
505 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
506 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
507 Move back to alloc.c.
508 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
509 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
511 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
513 * nsterm.m (windowDidResize): Call x_set_window_size only when
514 ns_in_resize is true. Otherwise set pixelwidth/height and
515 call change_frame_size (Bug#9628).
517 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
519 Port --enable-checking=all to Fedora 14 x86-64.
520 * charset.c (syms_of_charset): Also account for glibc malloc's
521 internal overhead when calculating the initial malloc maximum.
523 Port --enable-checking=all to Fedora 14 x86.
524 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
526 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
527 (overrun_check_realloc, overrun_check_free):
528 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
529 That way, xmalloc returns a properly-aligned pointer even if
530 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
531 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
532 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
533 into account when calculating the initial malloc maximum.
534 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
535 Move here from alloc.c, so that charset.c can use it too.
536 Properly align; the old code wasn't right for common 32-bit hosts
537 when configured with --enable-checking=all.
538 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
539 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
541 2011-09-29 Eli Zaretskii <eliz@gnu.org>
543 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
546 2011-09-28 Eli Zaretskii <eliz@gnu.org>
548 * xdisp.c (compute_display_string_end): If there's no display
549 string at CHARPOS, return -1.
551 * bidi.c (bidi_fetch_char): When compute_display_string_end
552 returns a negative value, treat the character as a normal
553 character not covered by a display string. (Bug#9624)
555 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
557 * lread.c (Fread_from_string): Fix typo in docstring.
559 2011-09-27 Eli Zaretskii <eliz@gnu.org>
561 * xdisp.c (handle_invisible_prop): If invisible text ends on a
562 newline, reseat the iterator instead of bidi-iterating there one
563 character at a time. (Bug#9610)
564 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
565 TO_CHARPOS if the bidi iterator is at base embedding level.
567 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
569 * lread.c (readevalloop): Use correct code for NBSP.
570 (read1): Likewise. (Bug#9608)
572 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
574 * dbusbind.c (Fdbus_register_signal): When service is not
575 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
577 2011-09-25 Glenn Morris <rgm@gnu.org>
579 * buffer.c (truncate-lines): Doc fix.
581 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
583 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
584 (Fset_window_next_buffers): Doc fix.
586 2011-09-24 Glenn Morris <rgm@gnu.org>
588 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
590 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
592 Fix minor problems found by static checking.
593 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
594 * indent.c (Fvertical_motion): Fix == vs = typo.
596 2011-09-24 Eli Zaretskii <eliz@gnu.org>
598 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
599 Default value is now t. Doc fix.
601 * indent.c (Fvertical_motion): Compute and apply the overshoot
602 logic when moving up, not only when moving down. Fix the
603 confusing name and values of the it_overshoot_expected variable;
604 logic changes accordingly. (Bug#9254) (Bug#9549)
606 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
607 CHARPOS is covered by a display string which includes newlines.
608 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
609 is covered by a display string with embedded newlines.
611 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
613 * dbusbind.c (Fdbus_register_signal): Add match rule to
614 Vdbus_registered_objects_table. (Bug#9581)
615 (Fdbus_register_method, Vdbus_registered_objects_table):
618 2011-09-24 Jim Meyering <meyering@redhat.com>
620 do not ignore write error for any output size
621 The previous change was incomplete.
622 While it makes emacs --batch detect the vast majority of stdout
623 write failures, errors were still ignored whenever the output size is
624 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
625 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
626 && echo FAIL: ignored write error
627 FAIL: ignored write error
628 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
629 && echo FAIL: ignored write error
630 FAIL: ignored write error
631 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
633 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
635 * emacs.c (Fkill_emacs): In noninteractive mode exit
636 non-successfully if a write error occurred on stdout. (Bug#9574)
638 2011-09-21 Eli Zaretskii <eliz@gnu.org>
640 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
643 * dispextern.h (struct it): Update the comment documenting what
646 2011-09-20 Eli Zaretskii <eliz@gnu.org>
648 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
649 a display string, extend search for cursor position to end of row.
650 (find_row_edges): If the row ends in a newline from a display
651 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
652 Handle the case of a display string with multiple newlines.
653 (Fcurrent_bidi_paragraph_direction): Fix search for previous
654 non-empty line. Fixes confusing cursor motion with arrow keys at
655 the beginning of a line that starts with whitespace.
657 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
659 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
662 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
664 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
667 2011-09-18 Eli Zaretskii <eliz@gnu.org>
669 * xdisp.c (display_line): Record maximum and minimum buffer
670 positions even if no glyphs were produced (e.g., by a zero-width
671 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
672 buffer positions that will be removed from the glyph row because
674 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
675 column is beyond frame width: don't subtract 1 "pixel" when
676 computing width of the stretch.
677 (reseat_at_next_visible_line_start): Undo the change made on
678 2011-09-17 that saved paragraph information and restored it after
679 the call to `reseat'. (Bug#9545)
681 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
683 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
684 and turn window cursor on if cleared (Bug#9415).
686 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
688 * search.c (boyer_moore): Take unibyte characters from pattern
689 literally. (Bug#9458)
691 2011-09-18 Eli Zaretskii <eliz@gnu.org>
693 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
695 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
697 Fix minor problem found by static checking.
698 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
699 initialized, to pacify gcc -Wuninitialized.
701 * fileio.c: Report proper errno when syscall falls.
702 (Finsert_file_contents): Save and restore errno,
703 so that report_file_error outputs the correct diagnostic.
704 (Fwrite_region) [CLASH_DETECTION]: Likewise.
706 2011-09-18 Eli Zaretskii <eliz@gnu.org>
708 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
710 2011-09-17 Eli Zaretskii <eliz@gnu.org>
712 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
713 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
715 2011-09-17 Eli Zaretskii <eliz@gnu.org>
717 * xdisp.c (reseat_at_next_visible_line_start): Keep information
718 about the current paragraph and restore it after the call to reseat.
720 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
721 (bidi_find_paragraph_start): Search back for paragraph beginning
722 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
723 (bidi_move_to_visually_next): Only trigger paragraph-related
724 computations when the last character is a newline or at EOB, not
725 just any NEUTRAL_B. (Bug#9470)
727 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
728 truncated lines if point is covered by a display string. (Bug#9524)
730 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
732 * xselect.c: Relax test for outgoing X longs (Bug#9498).
733 (cons_to_x_long): New function.
734 (lisp_data_to_selection_data): Use it. Correct the test for
735 short-versus-long data; it was negated. Break out of vector
736 loop, for efficiency, when a long datum is discovered.
738 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
740 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
742 2011-09-16 Eli Zaretskii <eliz@gnu.org>
744 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
745 GCC PR/17406) by declaring this function with external scope.
747 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
749 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
750 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
752 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
754 * editfns.c (Fformat): Correctly handle text properties on "%%".
756 2011-09-15 Eli Zaretskii <eliz@gnu.org>
758 * xterm.c (x_draw_composite_glyph_string_foreground):
759 * w32term.c (x_draw_composite_glyph_string_foreground):
760 * term.c (encode_terminal_code):
761 * composite.c (composition_update_it, get_composition_id):
762 * xdisp.c (get_next_display_element)
763 (fill_composite_glyph_string): Add comments about special meaning
764 of TAB characters in a composition.
766 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
768 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
769 This occurs when processing a multibyte format.
770 Problem reported by Wolfgang Jenker.
772 2011-09-15 Johan Bockgård <bojohan@gnu.org>
774 * xdisp.c (try_cursor_movement): Only check for exact match if
775 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
777 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
779 Remove unused external symbols.
780 * dispextern.h (calc_pixel_width_or_height): Remove decl.
781 * xdisp.c (calc_pixel_width_or_height): Now static.
782 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
783 * indent.c (check_display_width):
784 * w32term.c: Fix comment to match code.
785 * xterm.c, xterm.h (x_catching_errors): Remove.
787 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
789 * xselect.c: Use signed conversions more consistently (Bug#9498).
790 (selection_data_to_lisp_data): Assume incoming selection data are
791 signed integers, not unsigned. This is to be consistent with
792 outgoing selection data, which was modified to use signed integers
793 in as part of the fix to Bug#9196 in response to Jan D.'s comment
794 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
795 expects long, not unsigned long.
797 2011-09-14 Eli Zaretskii <eliz@gnu.org>
799 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
800 computation of loop end. Reported by Johan Bockgård
803 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
805 * frame.c (Fother_visible_frames_p): Function deleted.
807 2011-09-12 Eli Zaretskii <eliz@gnu.org>
809 * indent.c (compute_motion): Process display vector front to back
810 rather than the other way around. (Bug#2496)
812 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
814 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
816 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
818 * minibuf.c (Fread_from_minibuffer): Doc fix.
820 2011-09-11 Eli Zaretskii <eliz@gnu.org>
822 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
823 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
825 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
827 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
828 value for non-existent files.
830 2011-09-11 Eli Zaretskii <eliz@gnu.org>
832 * fileio.c (Finsert_file_contents): If the file cannot be opened,
833 set its "size" to -1. This will set the modtime_size field of
834 the corresponding buffer to -1, which is what
835 verify-visited-file-modtime expects for files that do not exist.
838 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
840 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
842 * lisp.h: ... from here. push_key_description is no longer
843 defined in keyboard.c, so its declaration should not be in
844 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
845 logically belongs with push_key_description.
847 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
849 * buffer.h: Include <sys/types.h> instead of <time.h>.
850 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
851 Problem reported by Herbert J. Skuhra.
853 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
855 * xml.c (parse_region): Make the parsing work for
856 non-comment-starting XML files again (bug#9144).
858 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
860 * image.c (gif_load): Fix calculation of bottom and right corner.
863 2011-09-10 Eli Zaretskii <eliz@gnu.org>
865 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
866 redisplay in small windows.
868 2011-09-09 Eli Zaretskii <eliz@gnu.org>
870 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
872 2011-09-08 Martin Rudalics <rudalics@gmx.at>
874 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
875 Operate on live windows only.
877 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
879 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
881 2011-09-07 Eli Zaretskii <eliz@gnu.org>
883 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
884 only under bidi iteration.
886 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
888 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
890 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
892 isnan: Fix porting problem to Solaris 10 with bundled gcc.
893 Without this fix, the command to link temacs failed due to an
894 undefined symbol __builtin_isnan. This is because
895 /usr/include/iso/math_c99.h #defines isnan(x) to
896 __builtin_isnan(x), but the bundled gcc, which identifies itself
897 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
899 * floatfns.c (isnan): #undef, and then #define to a clone of
901 (Fisnan): Always define, since it's always available now.
902 (syms_of_floatfns): Always define isnan at the Lisp level.
904 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
906 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
908 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
910 * fileio.c: Fix bugs with large file offsets (Bug#9428).
911 The previous code assumed that file offsets (off_t values) fit in
912 EMACS_INT variables, which is not true on typical 32-bit hosts.
913 The code messed up by falsely reporting buffer overflow in cases
914 such as (insert-file-contents "big" nil 1 2) into an empty buffer
915 when "big" contains more than 2**29 bytes, even though this
916 inserts just one byte and does not overflow the buffer.
917 (Finsert_file_contents): Store file offsets as off_t
918 values, not as EMACS_INT values. Check for overflow when
919 converting between EMACS_INT and off_t. When checking for
920 buffer overflow or for overlap, take the offsets into account.
921 Don't use EMACS_INT for small values where int suffices.
922 When checking for overlap, fix a typo: ZV was used where
923 ZV_BYTE was intended.
924 (Fwrite_region): Don't assume off_t fits into 'long'.
925 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
927 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
929 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
931 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
933 sprintf-related integer and memory overflow issues (Bug#9412).
935 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
936 (esprintf, exprintf, evxprintf): New functions.
937 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
938 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
939 (modify_event_symbol): Do not assume that the length of
940 name_alist_or_stem is safe to alloca and fits in int.
941 (Fexecute_extended_command): Likewise for function name and binding.
942 (Frecursion_depth): Wrap around reliably on integer overflow.
943 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
944 since some callers pass EMACS_INT values.
945 (Fsingle_key_description): Don't crash if symbol name contains more
946 than MAX_ALLOCA bytes.
947 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
948 (get_minibuffer): Arg is now EMACS_INT, not int.
949 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
950 (esprintf, exprintf, evxprintf): New decls.
951 * window.h (command_loop_level, minibuf_level): Reflect API changes.
953 * dbusbind.c (signature_cat): New function.
954 (xd_signature, Fdbus_register_signal):
955 Do not overrun buffer; instead, report string overflow.
957 * dispnew.c (add_window_display_history): Don't overrun buffer.
958 Truncate instead; this is OK since it's just a log.
960 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
961 even if the time zone offset is outlandishly large.
962 Don't mishandle offset == INT_MIN.
964 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
965 when creating daemon; the previous buffer-overflow check was incorrect.
967 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
968 which has the guts of the old verror function.
970 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
971 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
973 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
974 (font_unparse_xlfd): Don't blindly alloca long strings.
975 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
976 fits in int, when using sprintf. Use single snprintf to count
977 length of string rather than counting it via multiple sprintfs;
978 that's simpler and more reliable.
979 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
980 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
981 sprintf, in case result does not fit in int.
983 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
984 (fontset_from_font): Print it.
986 * frame.c (tty_frame_count): Now printmax_t, not int.
987 (make_terminal_frame, set_term_frame_name): Print it.
988 (x_report_frame_params): In X, window IDs are unsigned long,
989 not signed long, so print them as unsigned.
990 (validate_x_resource_name): Check for implausibly long names,
991 and don't assume name length fits in 'int'.
992 (x_get_resource_string): Don't blindly alloca invocation name;
993 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
996 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
997 (xg_check_special_colors, xg_set_geometry):
998 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1000 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1001 Use esprintf, not sprintf, in case result does not fit in int.
1003 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1004 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1005 it as a large positive number.
1006 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1007 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1009 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1010 in case result does not fit in int.
1012 * print.c (float_to_string): Detect width overflow more reliably.
1013 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1014 buffer overrun. Don't assume list length fits in 'int'. Treat
1015 print length of 0 as 0, not as infinity; to be consistent with other
1016 uses of print length in this function. Don't overflow print length
1017 index. Don't assume hash table size fits in 'long', or that
1018 vectorlike size fits in 'unsigned long'.
1020 * process.c (make_process): Use printmax_t, not int, to format
1021 process-name gensyms.
1023 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1025 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1026 to avoid potential buffer overrun.
1028 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1029 if X resource line is longer than 512 bytes.
1031 * xfns.c (x_window): Make sprintf buffer a bit bigger
1032 to avoid potential buffer overrun.
1034 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1036 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1038 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1040 Integer overflow fixes for scrolling, etc.
1041 Without these, Emacs silently mishandles large integers sometimes.
1042 For example, "C-u 4294967297 M-x recenter" was treated as if
1043 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1045 * xdisp.c (try_window_id): Check Emacs fixnum range before
1046 converting to 'int'.
1048 * window.c (window_scroll_line_based, Frecenter):
1049 Check that an Emacs fixnum is in range before assigning it to 'int'.
1050 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1051 values converted from Emacs fixnums.
1052 (Frecenter): Don't wrap around a line count if it is out of 'int'
1053 range; instead, treat it as an extreme value.
1054 (Fset_window_configuration, compare_window_configurations):
1055 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1057 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1058 that can exceed INT_MAX. Check that EMACS_INT value is in range
1059 before assigning it to the (possibly-narrower) index.
1060 (match_limit): Don't assume that a fixnum can fit in 'int'.
1062 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1065 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1066 (Fvertical_motion): Don't wrap around LINES values that don't fit
1067 in 'int'. Instead, treat them as extreme values. This is good
1068 enough for windows, which can't have more than INT_MAX lines anyway.
1070 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1072 * Require libxml/parser.h to avoid compilation warning.
1074 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1076 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1077 since this reportedly can destroy thread storage.
1079 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1081 * syntax.c (find_defun_start): Update all cache variables if
1082 exiting early (Bug#9401).
1084 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1086 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1088 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1089 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1090 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1092 * term.c (tty_append_glyph): New function.
1093 (produce_stretch_glyph): Static function and its prototype deleted.
1095 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1098 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1100 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1101 when checking :margin (Bug#9390).
1102 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1103 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1104 so that the name doesn't mislead. All uses changed.
1106 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1108 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1111 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1113 * xdisp.c (move_it_to): Don't bail out early when reaching
1114 position beyond to_charpos, if we are scanning backwards.
1115 (move_it_vertically_backward): When DY == 0, make sure we get to
1116 the first character in the line after the newline.
1118 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1120 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1121 (ccl_driver): Do not generate an out-of-range pointer.
1122 (Fccl_execute_on_string): Remove unnecessary check for
1123 integer overflow, noted by Stefan Monnier in
1124 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1125 Remove a FIXME that didn't need fixing.
1126 Simplify the newly-introduced buffer reallocation code.
1128 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1130 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1132 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1134 Integer and memory overflow issues (Bug#9196).
1136 * doc.c (get_doc_string): Rework so that
1137 get_doc_string_buffer_size is the actual buffer size, rather than
1138 being 1 less than the actual buffer size; this makes xpalloc more
1141 * image.c (x_allocate_bitmap_record, cache_image):
1142 * xselect.c (Fx_register_dnd_atom):
1143 Simplify previous changes by using xpalloc.
1145 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1146 since either will do and ptrdiff_t is convenient with xpalloc.
1148 * charset.c (charset_table_size)
1149 (struct charset_sort_data.priority): Now ptrdiff_t.
1150 (charset_compare): Don't overflow if priorities differ greatly.
1151 (Fsort_charsets): Don't assume list length fits in int.
1152 Check for size-calculation overflow when allocating sort data.
1153 (syms_of_charset): Allocate an initial charset table that is
1154 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1156 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1158 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1159 The actual value is always <= INT_MAX, and leaving it unsigned made
1160 overflow checking harder.
1162 * dispextern.h (struct glyph_matrix.rows_allocated)
1163 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1164 with xpalloc. The values are still always <= INT_MAX.
1166 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1168 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1169 (SAFE_NALLOCA): New macro.
1171 * region-cache.c (struct boundary.pos, find_cache_boundary)
1172 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1173 (set_cache_region, invalidate_region_cache)
1174 (revalidate_region_cache, know_region_cache, region_cache_forward)
1175 (region_cache_backward, pp_cache):
1176 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1177 so that ptrdiff_t * can be passed to xpalloc.
1178 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1179 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1180 (pp_cache): Don't assume cache_len fits in int.
1181 * region-cache.h: Adjust extern decls to match.
1183 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1184 EMACS_INT, since either will do, for xpalloc.
1186 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1187 (xnmalloc, xnrealloc, xpalloc): New functions.
1189 * bidi.c (bidi_shelve_header_size): New constant.
1190 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1191 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1193 * bidi.c (bidi_cache_shrink):
1194 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1196 Don't update size of array until after memory allocation succeeds,
1197 because xmalloc/xrealloc may not return.
1198 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1199 now that we have proper integer overflow checking.
1200 (record_overlay_string, overlay_strings): Catch overflows when
1201 calculating size of overlay_str_buf.
1203 * callproc.c (Fcall_process): Check for size overflow when
1204 calculating size of args2.
1205 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1206 Normally we prefer signed values, but sticking with ptrdiff_t would
1207 require adding more-complicated checks.
1209 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1210 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1211 Redo buffer-overflow calculations to avoid integer overflow.
1212 Add a FIXME comment where memory seems to be over-allocated.
1214 * character.c (Fstring): Check for size-calculation overflow.
1216 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1217 unnecessary integer overflow. Check for size overflow.
1218 (encode_coding_object): Don't update size until xmalloc succeeds.
1220 * composite.c (get_composition_id): Check for overflow in glyph
1221 length calculations.
1223 Integer and memory overflow fixes for display code.
1224 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1225 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1226 (scrolling_window): Check for overflow in size calculations.
1227 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1228 Don't assume glyph table len fits in int.
1229 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1230 (row_table_size): Now ptrdiff_t, not int.
1231 (scrolling_window): Avoid overflow in size calculations.
1232 Don't update size until allocation succeeds.
1233 * fns.c (concat): Check for overflow in size calculations.
1234 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1235 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1236 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1238 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1239 (get_doc_string): Check for size calculation overflow.
1240 Don't update size until allocation succeeds.
1241 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1242 EMACS_INT, where ptrdiff_t will do.
1243 (Fsubstitute_command_keys): Check for string overflow.
1245 * editfns.c (set_time_zone_rule): Don't assume environment length
1247 (message_length): Now ptrdiff_t, not int.
1248 (Fmessage_box): Don't update size until allocation succeeds.
1249 Don't assume message length fits in int.
1250 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1252 * emacs.c (main): Do not reallocate argv, since there is a null at
1253 the end that can be overwritten, and this way there's no need to
1254 worry about size-calculation overflow.
1255 (sort_args): Check for size-calculation overflow.
1257 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1259 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1261 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1262 (x_set_scroll_bar_width, x_figure_window_size):
1263 Check for integer overflow.
1264 (x_set_alpha): Do not assume XINT fits in int.
1266 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1267 This is for the members text_lines, text_cols, total_lines, total_cols,
1268 where the system imposes an 'int' limit.
1270 * fringe.c (Fdefine_fringe_bitmap):
1271 Don't update size until alloc works.
1273 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1274 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1276 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1277 Check for size-calculation overflow.
1278 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1279 do, as we prefer signed integers.
1280 (id_to_widget.max_size, id_to_widget.used)
1281 (xg_store_widget_in_map, xg_remove_widget_from_map)
1282 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1283 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1284 Use and return ptrdiff_t, not int.
1285 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1286 * gtkutil.h: Change prototypes to match the above.
1288 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1289 are duplicate now that they've been promoted to lisp.h.
1290 (x_allocate_bitmap_record, x_alloc_image_color)
1291 (make_image_cache, cache_image, xpm_load):
1292 Don't update size until alloc is done.
1293 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1295 Check for size calculation overflow.
1296 (ct_colors_allocated_max): New constant.
1297 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1300 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1301 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1302 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1303 Use ptrdiff_t, not int, to count maps.
1304 (read_char_minibuf_menu_prompt): Check for overflow in size
1305 calculations. Don't update size until allocation succeeds.
1306 Redo calculations to avoid overflow.
1307 * keyboard.h: Change prototypes to match the above.
1309 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1311 (current_minor_maps): Check for size calculation overflow.
1312 * keymap.h: Change prototypes to match the above.
1314 * lread.c (read1, init_obarray): Don't update size until alloc done.
1316 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1317 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1319 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1320 Now ptrdiff_t, not int.
1321 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1322 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1324 * process.c (Fnetwork_interface_list): Check for overflow
1325 in size calculation.
1327 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1329 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1330 overflow. Don't bother calling xmalloc when xrealloc will do.
1332 * search.c (Freplace_match): Check for size calculation overflow.
1333 (Fset_match_data): Don't assume list lengths fit in 'int'.
1335 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1336 for command line length. Do not attempt to address one before the
1337 beginning of an array, as that's not portable.
1339 * term.c (max_frame_lines): Remove; unused.
1340 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1342 (encode_terminal_code, calculate_costs): Check for size
1343 calculation overflow.
1344 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1345 table lengths and related sizes. Don't update size until alloc
1346 done. Redo calculations to avoid overflow.
1347 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1349 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1350 subtracting pointers.
1351 (gobble_line): Check for overflow more carefully. Don't update size
1354 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1355 Don't update size until alloc done.
1356 Redo size calculations to avoid overflow.
1357 Check for size calculation overflow.
1358 (main) [DEBUG]: Fix typo in invoking tparam1.
1360 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1361 Use ptrdiff_t, not int, for sizes.
1362 (store_mode_line_noprop_char): Don't update size until alloc done.
1364 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1365 Use ptrdiff_t, not int, for sizes.
1366 (Finternal_make_lisp_face, cache_face):
1367 Check for size calculation overflow.
1368 (cache_face): Treat size calculation overflows as if they were
1369 memory exhaustion (the usual treatment), rather than aborting.
1371 * xfns.c (x_encode_text, x_set_name_internal)
1372 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1373 sizes, since they can exceed INT_MAX in size. Check for size
1374 calculation overflow.
1376 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1377 (xg_select): Check for size calculation overflow.
1378 Don't update size until alloc done.
1380 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1381 as sprintf is limited to int lengths.
1383 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1384 (X_LONG_MIN): New macros.
1385 Use them to make the following changes clearer.
1386 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1387 This change doesn't affect the value now, but it may help remind
1388 future maintainers not to raise the value too much later.
1389 (SELECTION_QUANTUM): Remove, replacing with ...
1390 (selection_quantum): ... new function, which avoids overflow.
1392 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1393 assumption that selection length fits in 'int'.
1394 (x_reply_selection_request, x_handle_selection_request)
1395 (x_get_window_property, receive_incremental_selection)
1396 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1397 (lisp_data_to_selection_data, clean_local_selection_data):
1398 Use ptrdiff_t, not int, to record length of selection.
1399 (x_reply_selection_request, x_get_window_property)
1400 (receive_incremental_selection, x_property_data_to_lisp):
1401 Redo calculations to avoid overflow.
1402 (x_reply_selection_request): When sending hint, ceiling it at
1403 X_LONG_MAX rather than relying on wraparound overflow to send
1405 (x_get_window_property, receive_incremental_selection)
1406 (lisp_data_to_selection_data, x_property_data_to_lisp):
1407 Check for size-calculation overflow.
1408 (x_get_window_property, receive_incremental_selection)
1409 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1410 Don't store size until memory allocation succeeds.
1411 (x_get_window_property): Plug memory leak on memory exhaustion.
1412 Don't double-block input; malloc is safe here. Don't assume 2**34
1413 - 4 fits in unsigned long. Add an xassert to check
1414 XGetWindowProperty overflow. Be more careful about overflow
1415 calculations, and distinguish size from memory overflow better.
1416 (receive_incremental_selection): When tracing, don't assume
1417 unsigned int is less than INT_MAX.
1418 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1419 harmful) conversions of unsigned short to int.
1420 (lisp_data_to_selection_data): Don't assume that integers
1421 in the range -65535 through -1 fit in an X unsigned short.
1422 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1423 result parameters unless successful. Rely on cons_to_unsigned
1424 to report problems with elements; the old code wasn't right anyway.
1425 (x_check_property_data): Check for int overflow; we cannot use
1426 a wider type due to X limits.
1427 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1429 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1431 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1432 (x_term_init): Check for size calculation overflow.
1433 (x_color_cells): Don't store size until memory allocation succeeds.
1434 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1435 Don't assume alloca size is less than MAX_ALLOCA.
1436 (x_term_init): Don't assume length fits in int (sprintf is limited
1439 Use ptrdiff_t for composition IDs.
1440 * character.c (lisp_string_width):
1441 * composite.c (composition_table_size, n_compositions)
1442 (get_composition_id, composition_gstring_from_id):
1443 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1444 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1445 * window.c (Frecenter):
1446 Use ptrdiff_t, not int, for composition IDs.
1447 * composite.c (get_composition_id): Check for integer overflow.
1448 * composite.h: Adjust prototypes to match the above changes.
1450 Use ptrdiff_t for hash table indexes.
1451 * category.c (hash_get_category_set):
1452 * ccl.c (ccl_driver):
1453 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1454 * coding.c (coding_system_charset_list, detect_coding_system):
1455 * coding.h (struct coding_system.id):
1456 * composite.c (get_composition_id, gstring_lookup_cache):
1457 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1458 * image.c (xpm_get_color_table_h):
1459 * lisp.h (hash_lookup, hash_put):
1460 * minibuf.c (Ftest_completion):
1461 Use ptrdiff_t for hash table indexes, not int (which is too
1462 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1463 32-bit --with-wide-int hosts).
1465 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1466 Add a FIXME comment about memory leaks.
1467 (syms_of_charset): Don't assume xmalloc returns.
1469 Don't assume that stated character widths fit in int.
1470 * character.c (Fchar_width, c_string_width, lisp_string_width):
1471 * character.h (CHAR_WIDTH):
1472 * indent.c (MULTIBYTE_BYTES_WIDTH):
1473 Use sanitize_char_width to avoid undefined and/or bad behavior
1474 with outlandish widths.
1475 * character.h (sanitize_tab_width): Rename from sanitize_width,
1476 now that we have two such functions. All uses changed.
1477 (sanitize_char_width): New inline function.
1479 Don't assume that tab-width fits in int.
1480 * character.h (sanitize_width): New inline function.
1481 (SANE_TAB_WIDTH): New macro.
1482 (ASCII_CHAR_WIDTH): Use it.
1483 * indent.c (sane_tab_width): Remove. All uses replaced by
1484 SANE_TAB_WIDTH (current_buffer).
1485 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1487 * fileio.c: Integer overflow issues with file modes.
1488 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1490 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1491 Remove unreachable code.
1492 (read_hex, load_charset_map_from_file): Check for integer overflow.
1494 * xterm.c: don't go over XClientMessageEvent limit
1495 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1496 (x_send_scroll_bar_event): Likewise. Check that the size does not
1497 exceed limits imposed by XClientMessageEvent, as well as the usual
1498 ptrdiff_t and size_t limits.
1500 * keyboard.c: Overflow, signedness and related fixes.
1501 (make_lispy_movement): Use same integer type in forward decl
1502 that is used in the definition.
1503 (read_key_sequence, keyremap_step):
1504 Change bufsize argument back to int, undoing my 2011-03-30 change.
1505 We prefer signed types, and int is wide enough here.
1506 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1507 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1508 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1509 length, not size_t. Use ptrdiff_t for index, not int.
1510 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1511 possibility of integer overflow.
1513 Overflow, signedness and related fixes for images.
1515 * dispextern.h (struct it.stack[0].u.image.image_id)
1516 (struct_it.image_id, struct image.id, struct image_cache.size)
1517 (struct image_cache.used, struct image_cache.ref_count):
1518 * gtkutil.c (update_frame_tool_bar):
1519 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1520 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1521 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1522 * nsmenu.m (update_frame_tool_bar):
1523 * xdisp.c (calc_pixel_width_or_height):
1524 * xfns.c (image_cache_refcount):
1525 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1526 on typical 64-bit hosts.
1528 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1529 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1530 Omit unnecessary casts to int.
1531 (parse_image_spec): Check that integers fall into 'int' range
1532 when the callers expect that.
1533 (image_ascent): Redo ascent calculation to avoid int overflow.
1534 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1535 (lookup_image): Remove unnecessary tests.
1536 (xbm_image_p): Locals are now of int, not EMACS_INT,
1537 since parse_image_check makes sure they fit into int.
1538 (png_load, gif_load, svg_load_image):
1539 Prefer int to unsigned where either will do.
1540 (tiff_handler): New function, combining the cores of the
1541 old tiff_error_handler and tiff_warning_handler.
1542 This function is rewritten to use vsnprintf and thereby avoid
1543 stack buffer overflows. It uses only the features of vsnprintf
1544 that are common to both POSIX and native Microsoft.
1545 (tiff_error_handler, tiff_warning_handler): Use it.
1546 (tiff_load, gif_load, imagemagick_load_image):
1547 Don't assume :index value fits in 'int'.
1548 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1549 (imagemagick_load_image): Check that crop parameters fit into
1550 the integer types that MagickCropImage accepts. Don't assume
1551 Vimagemagick_render_type has a nonnegative value. Don't assume
1552 size_t fits in 'long'.
1553 (gs_load): Use printmax_t to print the widest integers possible.
1554 Check for integer overflow when computing image height and width.
1556 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1558 * xdisp.c (redisplay_window): Don't force window start if point
1559 will be invisible in the resulting window. (Bug#9324)
1561 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1563 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1564 the display spec is of the form `(space ...)'.
1565 (handle_display_spec): Return the value returned by
1566 handle_single_display_spec, not just 1 or zero.
1567 (handle_single_display_spec): If the display spec is of the form
1568 `(space ...)', and specifies display in the text area, return 2
1570 (try_cursor_movement): Check for the need to scroll more
1571 accurately, and prefer exact match for point under bidi.
1572 Don't advance `row' beyond the last row of the window.
1574 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1575 into disp_prop; all users changed.
1577 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1578 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1579 for the text covered by the display property.
1581 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1583 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1584 Change return value to nil.
1585 (Frecord_buffer): Delete unused function.
1587 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1589 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1590 buffers, return left-to-right.
1591 (set_cursor_from_row): Consider candidate row a win if its glyph
1592 represents a newline and point is on that newline. Fixes cursor
1593 positioning on the newline at EOL of R2L text within L2R
1594 paragraph, and vice versa.
1595 (try_cursor_movement): Check continued rows, in addition to
1596 continuation rows. Fixes unwarranted scroll when point enters a
1597 continued line of R2L text within an L2R paragraph, or vice versa.
1598 (cursor_row_p): Consider the case of point being equal to
1599 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1600 from the end of a short line to the beginning of a continued line
1601 of R2L text within L2R paragraph.
1602 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1603 composed characters.
1605 * bidi.c (bidi_check_type): Use xassert.
1606 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1609 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1611 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1614 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1616 * nsfont.m (ns_otf_to_script): Fix typo.
1618 2011-08-22 Kenichi Handa <handa@m17n.org>
1620 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1621 extra slot even if the purpose is char-code-property-table.
1623 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1625 * xdisp.c (redisplay_window): When computing centering_position,
1626 account for the height of the header line. (Bug#8874)
1628 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1629 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1630 candidate is selected by the mouse, and that candidate has a
1631 composed character under the mouse.
1633 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1634 coordinates reported by pos-visible-in-window-p for a composed
1635 character in column zero.
1637 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1639 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1641 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1643 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1644 consider it a hit if to_charpos is anywhere in the range of the
1645 composed buffer positions.
1647 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1649 * image.c (gif_load): Don't assume that each subimage has the same
1650 dimensions as the base image. Handle disposal method that is
1651 "undefined" by the gif spec (Bug#9335).
1653 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1655 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1656 (Fcondition_case): Document `debug' symbol in error handler.
1658 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1660 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1661 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1662 from an Org mode buffer to a Speedbar frame.
1664 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1665 a composition, take its buffer position from IT->cmp_it.charpos.
1666 Fixes cursor positioning at the beginning of a line that begins
1667 with a composed character.
1669 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1671 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1672 character bidirectional type, use STRONG_L instead. Fixes crashes
1673 in a buffer produced by `describe-categories'.
1675 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1676 members before the level stack, so they would be saved and
1677 restored when copying iterator state. Fixes incorrect reordering
1678 around TABs covered by display properties.
1680 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1682 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1684 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1686 * eval.c (internal_condition_case, internal_condition_case_1)
1687 (internal_condition_case_2, internal_condition_case_n):
1688 Remove unnecessary aborts (Bug#9081).
1690 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1692 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1693 has no `load' handler, try opening the file locally. (Bug#9311)
1695 2011-08-16 Ken Brown <kbrown@cornell.edu>
1697 * gmalloc.c: Expand comment.
1699 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1701 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1702 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1704 2011-08-16 Ken Brown <kbrown@cornell.edu>
1706 Fix memory allocation problems in Cygwin build (Bug#9273).
1708 * unexcw.c ( __malloc_initialized): Declare external variable.
1709 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1711 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1713 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1715 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1717 [CYGWIN] (special_realloc): New function.
1718 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1719 requests to realloc storage in the static heap.
1721 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1723 * bidi.c (bidi_initialize): Remove unused local.
1725 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1728 * biditype.h: Remove file.
1729 * makefile.w32-in ($(BLD)/bidi.$(O)):
1730 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1732 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1734 * chartab.c: Improve commentary for the uniprop_table API.
1736 * bidi.c (bidi_paragraph_init): Support zero value of
1737 bidi_ignore_explicit_marks_for_paragraph_level.
1738 (bidi_initialize): Use uniprop_table instead of including
1739 biditype.h and bidimirror.h.
1741 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1742 coordinates of the iterator when restoring from ppos_it.
1745 2011-08-14 Kenichi Handa <handa@m17n.org>
1747 * process.c (create_process): Call setup_process_coding_systems
1748 after the pid of the process is set to -1 (Bug#8162).
1750 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1752 * xdisp.c (move_it_in_display_line_to): Don't invoke
1753 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1754 ppos_it. Fixes vertical cursor motion when line beginning is
1755 covered by an image. (Bug#9296)
1757 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1759 * nsterm.h (ns_run_ascript): Declare.
1760 (NSAPP_DATA2_RUNASSCRIPT): Define.
1762 * nsfns.m (as_script, as_result, as_status): New static variables.
1763 (ns_run_ascript): New function.
1764 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1765 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1766 the event loop. Get status from as_status (Bug#7276).
1768 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1769 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1770 the event loop (Bug#7276).
1772 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1774 * gnutls.c (QCgnutls_bootprop_priority)
1775 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1776 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1777 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1778 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1779 (QCgnutls_bootprop_verify_hostname_error)
1780 (QCgnutls_bootprop_callbacks_verify): Rename from
1781 Qgnutls_bootprop_..., all uses changed.
1783 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1786 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1788 * xfaces.c (Qframe_set_background_mode): Now static.
1789 * dispextern.h (Qframe_set_background_mode): Remove decl.
1791 * process.c (Fnetwork_interface_info): Declare local only if needed.
1793 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1795 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1796 (Fnetwork_interface_list): Allocate in increments of bytes instead
1797 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1798 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1800 (struct ifflag_def): notrailers is smart on OSX.
1801 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1802 Get hardware address with getifaddrs if available.
1804 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1806 * xdisp.c (iterate_out_of_display_property): xassert that
1807 IT->position is set to within IT->object's boundaries. Break from
1808 the loop as soon as EOB is reached; avoids infloops in redisplay
1809 when IT->position is set up wrongly due to some bug.
1810 Set IT->current to match the bidi iterator unconditionally.
1811 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1812 entry. Force push_it to save on the stack the current
1813 buffer/string position, to be restored by pop_it. Fix flags in
1814 the iterator structure wrt the object coming from a display
1815 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1816 properties. (Bug#9284)
1818 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1820 * fontset.c (fontset_get_font_group): Add proper type checks.
1823 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1825 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1826 and LC_VERSION_MIN_MACOSX.
1827 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1828 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1830 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1832 * xdisp.c (forward_to_next_line_start): Allow to use the
1833 no-display-properties-and-no-overlays under bidi display.
1834 Set disp_pos in the bidi iterator to avoid searches for display
1835 properties and overlays.
1837 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1839 * editfns.c (Fset_time_zone_rule): Document relationship with the
1842 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1843 the font entity extracted from the cache (Bug#8109).
1845 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1847 * composite.c (autocmp_chars): Don't reset point. That is done by
1848 restore_point_unwind (Bug#5984).
1850 2011-08-07 Juri Linkov <juri@jurta.org>
1852 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1853 to show the arg `TIME' instead of `TIMEVAL'.
1855 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1857 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1858 display property strides EOL and includes a newline, as in
1859 longlines-mode. (Bug#9254)
1860 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1861 word-wrap under bidirectional display. (Bug#9224)
1863 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1864 is non-zero, even if the data buffer is NULL. Fixes a crash in
1865 vertical-motion with longlines-mode. (Bug#9254)
1867 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1869 * bidi.c <bidi_cache_total_alloc>: Now static.
1870 (bidi_initialize): Initialize bidi_cache_total_alloc.
1872 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1875 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1876 amount allocated this far in `bidi_cache_total_alloc'.
1877 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1878 non-zero, only free the data buffer without restoring the cache
1879 contents. All callers changed.
1881 * dispextern.h (bidi_unshelve_cache): Update prototype.
1883 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1884 (move_it_in_display_line, move_it_to)
1885 (move_it_vertically_backward, move_it_by_lines): Replace the call
1886 to xfree to an equivalent call to bidi_unshelve_cache.
1887 (move_it_in_display_line_to): Fix logic of returning
1888 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1890 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1892 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1893 came from a string character with a `cursor' property. (Bug#9229)
1895 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1897 * Makefile.in (LIB_PTHREAD): New variable.
1898 (LIBES): Add LIB_PTHREAD (Bug#9216).
1900 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1901 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1903 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1905 * regex.c (re_iswctype): Remove some redundant boolean conversions.
1907 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1909 * xterm.c (x_find_topmost_parent): New function.
1910 (x_set_frame_alpha): Find topmost parent window with
1911 x_find_topmost_parent and set the property there also (bug#9181).
1912 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1914 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1916 * callproc.c (Fcall_process): Avoid vfork clobbering
1917 the local vars buffer, coding_systems, current_dir.
1919 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1921 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1923 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1925 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1926 so that it is not optimized away.
1928 * xdisp.c (compute_display_string_pos): Remove unused local.
1930 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1932 Fix slow cursor motion and scrolling in large buffers with
1933 selective display, like Org Mode buffers. (Bug#9218)
1935 * dispextern.h (struct bidi_it): New member disp_prop_p.
1937 * xdisp.c: Remove one-slot cache of display string positions.
1938 (compute_display_string_pos): Accept an additional argument
1939 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1940 for a display string or property. If found, set DISP_PROP_P
1943 * bidi.c (bidi_fetch_char): Accept an additional argument
1944 DISP_PROP_P, and pass it to compute_display_string_pos.
1945 Only handle text covered by a display string if DISP_PROP_P is returned
1946 non-zero. All callers of bidi_fetch_char changed.
1948 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1950 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1952 2010-12-03 Don March <don@ohspite.net>
1954 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1955 last character M-[char] is translated to ESC [char] (bug#7541).
1957 2011-08-02 Kenichi Handa <handa@m17n.org>
1959 * lisp.h (uniprop_table): Extern it.
1961 * chartab.c (uniprop_table): Make it non-static.
1963 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1965 * xdisp.c (forward_to_next_line_start): Accept additional argument
1966 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1968 (reseat_at_next_visible_line_start): Use the bidi iterator state
1969 returned by forward_to_next_line_start to restore the state of
1970 it->bidi_it after backing up to previous newline. (Bug#9212)
1972 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1974 * regex.c (re_comp): Protoize.
1975 (re_exec): Fix return type.
1976 (regexec): Fix type of `ret'. (Bug#9203)
1978 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1980 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1981 This is needed if max-image-size is a floating-point number.
1983 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1985 * print.c (print_object): Print empty symbol as ##.
1987 * lread.c (read1): Read ## as empty symbol.
1989 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1991 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1992 setting frame foreground color (Bug#9175).
1993 (x_set_background_color): Likewise.
1995 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1996 contents (Bug#9176).
1997 (EmacsTooltip -init): Remove bezels and add shadows to
2000 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2001 or scroll bar (Bug#8470).
2003 * nsfont.m (nsfont_open): Remove assignment to voffset and
2004 unnecessary vars hshink, expand, hd, full_height, min_height.
2005 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2007 * nsterm.h (nsfont_info): Remove voffset field.
2009 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2011 Implement strike-through and overline on NextStep (Bug#8863).
2013 * nsfont.m (nsfont_open): Use underline position provided by font,
2014 instead of hard-coded value of 2.
2015 (nsfont_draw): Call ns_draw_text_decoration instead.
2017 * nsterm.h: Add declaration for ns_draw_text_decoration.
2019 * nsterm.m (ns_draw_text_decoration): New function for drawing
2020 underline, overline, and strike-through.
2021 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2022 ns_draw_text_decoration. Change treatment of cursor drawing to
2023 accommodate underlining, etc.
2025 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2027 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2030 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2032 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2033 Without this fix, if a signal arrives just after memory fills up,
2034 'malloc' might be invoked reentrantly.
2036 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2037 In other words, assume that every image size is allowed, on non-X
2038 hosts. This assumption is probably wrong, but it lets Emacs compile.
2040 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2042 * regex.c (re_iswctype): Convert return values to boolean.
2044 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2046 * xdisp.c (compute_display_string_pos): Don't use cached display
2047 string position if the buffer had its restriction changed.
2050 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2052 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2054 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2056 Integer signedness and overflow and related fixes. (Bug#9079)
2058 * bidi.c: Integer size and overflow fixes.
2059 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2060 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2061 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2062 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2063 (bidi_find_other_level_edge):
2064 Use ptrdiff_t instead of EMACS_INT where either will do.
2065 This works better on 32-bit hosts configured --with-wide-int.
2066 (bidi_cache_ensure_space): Check for size-calculation overflow.
2067 Use % rather than repeated addition, for better worst-case speed.
2068 Don't set bidi_cache_size until after xrealloc returns, because it
2070 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2071 (bidi_cache_ensure_space): Also check that the bidi cache size
2072 does not exceed that of the largest Lisp string or buffer. See Eli
2073 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2075 * alloc.c (__malloc_size_t): Remove.
2076 All uses replaced by size_t. See Andreas Schwab's note
2077 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2079 * image.c: Improve checking for integer overflow.
2080 (check_image_size): Assume that f is nonnull, since
2081 it is always nonnull in practice. This is one less thing to
2082 worry about when checking for integer overflow later.
2083 (x_check_image_size): New function, which checks for integer
2084 overflow issues inside X.
2085 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2086 This removes the need for a memory_full check.
2087 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2088 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2089 (xbm_read_bitmap_data): Change locals back to 'int', since
2090 their values must fit in 'int'.
2091 (xpm_load_image, png_load, tiff_load):
2092 Invoke x_create_x_image_and_pixmap earlier,
2093 to avoid much needless work if the image is too large.
2094 (tiff_load): Treat overly large images as if
2095 x_create_x_image_and_pixmap failed, not as malloc failures.
2096 (gs_load): Use x_check_image_size.
2098 * gtkutil.c: Omit integer casts.
2099 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2100 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2102 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2104 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2105 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2106 would wrongly return t on a 64-bit host.
2108 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2109 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2110 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2111 and therefore cause GCC to emit a bogus diagnostic in some cases.
2113 * image.c: Integer signedness and overflow and related fixes.
2114 This is not an exhaustive set of fixes, but it's time to
2115 record what I've got.
2116 (lookup_pixel_color, check_image_size): Remove redundant decls.
2117 (check_image_size): Don't assume that arbitrary EMACS_INT values
2118 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2119 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2120 (tiff_load, imagemagick_load_image):
2121 Check for overflow in size calculations.
2122 (x_create_x_image_and_pixmap): Remove unnecessary test for
2123 xmalloc returning NULL; that can't happen.
2124 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2125 (xpm_color_bucket): Use better integer hashing function.
2126 (xpm_cache_color): Don't possibly over-allocate memory.
2127 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2128 (gif_memory_source):
2129 Use ptrdiff_t, not int or size_t, to record sizes.
2130 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2131 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2132 either works, as we prefer signed integers.
2133 (tiff_read_from_memory, tiff_write_from_memory):
2134 Return tsize_t, not size_t, since that's what the TIFF API wants.
2135 (tiff_read_from_memory): Don't fail simply because the read would
2136 go past EOF; instead, return a short read.
2137 (tiff_load): Omit no-longer-needed casts.
2138 (Fimagemagick_types): Don't assume size fits into 'int'.
2140 Improve hashing quality when configured --with-wide-int.
2141 * fns.c (hash_string): New function, taken from sxhash_string.
2142 Do not discard information about ASCII character case; this
2143 discarding is no longer needed.
2144 (sxhash-string): Use it. Change sig to match it. Caller changed.
2145 * lisp.h: Declare it.
2146 * lread.c (hash_string): Remove, since we now use fns.c's version.
2147 The fns.c version returns a wider integer if --with-wide-int is
2148 specified, so this should help the quality of the hashing a bit.
2150 * emacs.c: Integer overflow minor fix.
2151 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2152 Define only if GNU_LINUX.
2153 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2155 * dispnew.c: Integer signedness and overflow fixes.
2156 Remove unnecessary forward decls, that were a maintenance hassle.
2157 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2159 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2160 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2161 (prepare_desired_row, line_draw_cost):
2162 Use int, not unsigned, where either works.
2163 (save_current_matrix, restore_current_matrix):
2164 Use ptrdiff_t, not size_t, where either works.
2165 (init_display): Check for overflow more accurately, and without
2166 relying on undefined behavior.
2168 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2169 Remove, replacing with the new symbols in lisp.h. All uses changed.
2170 * fileio.c (make_temp_name):
2171 * filelock.c (lock_file_1, lock_file):
2172 * xdisp.c (message_dolog):
2173 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2174 Use pMd etc. instead.
2175 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2176 replacing the pWIDE etc. symbols removed from editfns.c.
2178 * keyboard.h (num_input_events): Now uintmax_t.
2179 This is (very slightly) less likely to mess up due to wraparound.
2182 * buffer.c: Integer signedness fixes.
2183 (alloc_buffer_text, enlarge_buffer_text):
2184 Use ptrdiff_t rather than size_t when either will do, as we prefer
2187 * alloc.c: Integer signedness and overflow fixes.
2188 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2189 (__malloc_size_t): Default to size_t, not to int.
2190 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2191 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2192 Prefer ptrdiff_t to size_t when either would do, as we prefer
2194 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2195 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2196 Now const. Initialize with values that are in range even if char
2198 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2199 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2200 These functions do the right thing with sizes > 2**32.
2201 (check_depth): Now ptrdiff_t, not int.
2202 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2203 Adjust to new way of storing sizes. Check for size overflow bugs
2205 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2206 slightly wrong anyway, as it missed one instance of
2207 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2208 (refill_memory_reserve): Omit needless cast to size_t.
2209 (mark_object_loop_halt): Mark as externally visible.
2211 * xselect.c: Integer signedness and overflow fixes.
2212 (Fx_register_dnd_atom, x_handle_dnd_message):
2213 Use ptrdiff_t, not size_t, since we prefer signed.
2214 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2215 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2216 x_dnd_atoms_size and x_dnd_atoms_length.
2218 * doprnt.c: Prefer signed to unsigned when either works.
2220 * doprnt.c (doprnt):
2222 * xdisp.c (vmessage):
2223 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2224 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2225 prefer signed arithmetic to avoid comparison confusion.
2226 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2227 but is a bit tricky.
2229 Assume freestanding C89 headers, string.h, stdlib.h.
2230 * data.c, doprnt.c, floatfns.c, print.c:
2231 Include float.h unconditionally.
2232 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2233 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2234 * regex.c: Likewise for stddef.h, string.h.
2235 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2236 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2237 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2238 (STDC_HEADERS): Remove obsolete defines.
2239 * sysdep.c: Include limits.h unconditionally.
2241 Assume support for memcmp, memcpy, memmove, memset.
2242 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2243 * regex.c (memcmp, memcpy):
2244 Remove; we assume C89 now.
2246 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2247 (__malloc_safe_bcopy): Remove; no longer needed.
2249 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2250 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2251 well either way, and we prefer signed to unsigned.
2253 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2255 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2256 closes the connection while we're reading (bug#9182).
2258 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2260 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2261 are specified (Bug#9168).
2263 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2265 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2266 Found by GCC static checking and --with-wide-int on a 32-bit host.
2268 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2270 * xdisp.c (compute_display_string_pos): Fix logic of caching
2271 previous display string position. Initialize cached_prev_pos to
2272 -1. Fixes slow-down at the beginning of a buffer.
2274 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2276 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2277 for attrs[LFACE_FONTSET_INDEX].
2279 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2281 * xml.c (parse_region): Remove unused local
2282 that was recently introduced.
2284 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2286 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2287 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2289 * xdisp.c (move_it_in_display_line_to): Record the best matching
2290 position for TO_CHARPOS while scanning the line, and restore it on
2291 exit if none of the characters scanned was an exact match.
2292 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2293 when exact match is impossible due to invisible text, and the
2294 lines are truncated.
2296 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2298 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2301 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2303 Fix a significant slow-down of cursor motion with C-n, C-p,
2304 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2305 auto-repeat under bidi redisplay in fontified buffers.
2306 * xdisp.c (compute_stop_pos_backwards): New function.
2307 (next_element_from_buffer): Call compute_stop_pos_backwards to
2308 find a suitable prev_stop when we find ourselves before
2310 (reseat): Don't look for prev_stop, as that could mean a very long
2312 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2313 <cached_disp_overlay_modiff>: Cache for last found display string
2315 (compute_display_string_pos): Return the cached position if asked
2316 about the same buffer in the same area of character positions, and
2317 the buffer wasn't changed since the time the display string
2318 position was cached.
2320 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2322 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2323 is an integer, which is important for empty lines. (Bug#9149)
2325 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2327 * frame.c (Fmodify_frame_parameters): In tty case, update the
2328 default face if necessary (Bug#4238).
2330 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2332 * editfns.c (Fstring_to_char): No need to explain what a character
2333 is in the docstring (Bug#6576).
2335 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2337 * xml.c (parse_region): Make sure we always return a tree.
2339 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2341 * xml.c (parse_region): If a document contains only comments,
2344 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2346 * xml.c (make_dom): Return comments, too.
2348 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2351 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2352 and the surrounding thread.
2353 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2354 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2355 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2357 * s/openbsd.h (BROKEN_SIGIO): Define.
2358 * unexelf.c (unexec) [__OpenBSD__]:
2359 Don't update the .mdebug section of the Alpha COFF symbol table.
2361 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2363 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2366 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2368 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2369 This fixes some race conditions on the permissions of any newly
2372 * alloc.c (valid_pointer_p): Use pipe, not open.
2373 This fixes some permissions issues when debugging.
2375 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2376 If fchown fails to set both uid and gid, try to set just gid,
2377 as that is sometimes allowed. Adjust the file's mode to eliminate
2378 setuid or setgid bits that are inappropriate if fchown fails.
2380 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2382 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2383 to compare Lisp_Objects.
2384 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2385 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2386 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2388 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2390 * lread.c (read_integer): Unread even EOF character.
2391 (read1): Likewise. Properly record start position of symbol.
2393 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2394 symbol character follows.
2396 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2398 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2399 This works around a problem with the previous change to Fcopy_file.
2400 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2401 and without this change, GCC might complain about discarding
2402 fchown's return value.
2404 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2406 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2408 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2410 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2412 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2414 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2415 it's used from the C level.
2417 * process.c: Use the same condition for POLL_FOR_INPUT in both
2418 keyboard.c and process.c (bug#1858).
2420 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2422 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2423 (Fgnutls_boot): Use it.
2425 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2427 * doc.c (Fsubstitute_command_keys): Revert last change.
2429 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2431 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2432 quotes the next character, and doesn't affect other longer
2433 sequences (bug#8935).
2435 * lread.c (syms_of_lread): Clarify that is isn't only
2436 `eval-buffer' and `eval-defun' that's affected by
2437 `lexical-binding' (bug#8460).
2439 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2441 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2442 bidi redisplay when a line includes both an image and is truncated.
2444 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2446 Fix minor problems found by static checking.
2447 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2448 (elsz): Now a signed constant, not a size_t var. We prefer signed
2449 types to unsigned, to avoid integer comparison confusion. Without
2450 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2451 "cannot optimize loop, the loop counter may overflow", a symptom
2453 * indent.c (Fvertical_motion): Mark locals as initialized.
2454 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2456 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2458 * search.c (Fre_search_backward): Mention `case-fold-search' in
2459 all the re_search_* functions (bug#8138).
2461 * keyboard.c (Fopen_dribble_file): Document when the file is
2464 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2466 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2469 Support bidi reordering of display and overlay strings.
2470 * xdisp.c (compute_display_string_pos)
2471 (compute_display_string_end): Accept additional argument STRING.
2472 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2473 (reseat_to_string): Initialize bidi_it->string.s and
2474 bidi_it->string.schars.
2475 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2476 NULL (avoids a crash in bidi_paragraph_init).
2477 Initialize itb.string.lstring.
2478 (init_iterator): Call bidi_init_it only of a valid
2479 buffer position was specified. Initialize paragraph_embedding to
2481 (reseat_to_string): Initialize the bidi iterator.
2482 (display_string): If we need to ignore text properties of
2483 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2484 original value of -1 will not work with bidi.)
2485 (compute_display_string_pos): First arg is now struct
2486 `text_pos *'; all callers changed. Support display properties on
2488 (compute_display_string_end): Support display properties on Lisp
2490 (init_iterator, reseat_1, reseat_to_string): Initialize the
2491 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2492 when iterating on a string not from display properties).
2493 (compute_display_string_pos, compute_display_string_end):
2494 Fix calculation of the object to scan. Fixes an error when using
2496 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2497 base_level_stop; instead, set base_level_stop to BEGV.
2498 Fixes crashes in vertical-motion.
2499 (next_element_from_buffer): Improve commentary for when
2500 the iterator is before prev_stop.
2501 (init_iterator): Initialize bidi_p from the default value of
2502 bidi-display-reordering, not from buffer-local value. Use the
2503 buffer-local value only if initializing for buffer iteration.
2504 (handle_invisible_prop): Support invisible properties on strings
2505 that are being bidi-reordered.
2506 (set_iterator_to_next): Support bidi reordering of C strings and
2508 (next_element_from_string): Support bidi reordering of Lisp
2510 (handle_stop_backwards): Support Lisp strings as well.
2511 (display_string): Support display of R2L glyph rows.
2512 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2513 (init_iterator): Don't initialize it->bidi_p for strings
2515 (reseat_to_string): Initialize it->bidi_p for strings here.
2516 (next_element_from_string, next_element_from_c_string)
2517 (next_element_from_buffer): Add xassert's for correspondence
2518 between IT's object being iterated and it->bidi_it.string
2520 (face_before_or_after_it_pos): Support bidi iteration.
2521 (next_element_from_c_string): Handle the case of the first string
2522 character that is not the first one in the visual order.
2523 (get_visually_first_element): New function, refactored from common
2524 parts of next_element_from_buffer, next_element_from_string, and
2525 next_element_from_c_string.
2526 (tool_bar_lines_needed, redisplay_tool_bar)
2527 (display_menu_bar): Force left-to-right direction. Add a FIXME
2528 comment for making that be controlled by a user option.
2529 (push_it, pop_it): Save and restore the state of the
2530 bidi iterator. Save and restore the bidi_p flag.
2531 (pop_it): Iterate out of display property for string iteration as
2533 (iterate_out_of_display_property): Support iteration over strings.
2534 (handle_single_display_spec): Set up it->bidi_it for iteration
2535 over a display string, and call bidi_init_it.
2536 (handle_single_display_spec, next_overlay_string)
2537 (get_overlay_strings_1, push_display_prop): Set up the bidi
2538 iterator for displaying display or overlay strings.
2539 (forward_to_next_line_start): Don't use the shortcut if
2541 (back_to_previous_visible_line_start): If handle_display_prop
2542 pushed the iterator stack, restore the internal state of the bidi
2543 iterator by calling bidi_pop_it same number of times.
2544 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2545 and we are bidi-iterating, don't decrement the iterator position;
2546 instead, set the first_elt flag in the bidi iterator, to produce
2548 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2549 (push_display_prop): xassert that we are iterating a buffer.
2550 (push_it, pop_it): Save and restore paragraph_embedding member.
2551 (handle_single_display_spec, next_overlay_string)
2552 (get_overlay_strings_1, reseat_1, reseat_to_string)
2553 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2554 correctly. Don't assume unibyte strings are not bidi-reordered.
2555 (compute_display_string_pos)
2556 (compute_display_string_end): Fix handling the case of C string.
2557 (push_it, pop_it): Save and restore from_disp_prop_p.
2558 (handle_single_display_spec, push_display_prop): Set the
2559 from_disp_prop_p flag.
2560 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2561 (pop_it): Call iterate_out_of_display_property only if we are
2562 popping after iteration over a string that came from a display
2563 property. Fix a typo in popping stretch info. Add an assertion
2564 for verifying that the iterator position is in sync with the bidi
2566 (handle_single_display_spec, get_overlay_strings_1)
2567 (push_display_prop): Fix initialization of paragraph direction for
2568 string when that of the parent object is not yet determined.
2569 (reseat_1): Call bidi_init_it to resync the bidi
2570 iterator with IT's position. (Bug#7616)
2571 (find_row_edges): If ROW->start.pos gives position
2572 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2573 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2574 Reset the from_disp_prop_p flag.
2575 (SAVE_IT, RESTORE_IT): New macros.
2576 (pos_visible_p, face_before_or_after_it_pos)
2577 (back_to_previous_visible_line_start)
2578 (move_it_in_display_line_to, move_it_in_display_line)
2579 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2580 (try_scrolling, redisplay_window, display_line): Use them when
2581 saving a temporary copy of the iterator and restoring it back.
2582 (back_to_previous_visible_line_start, reseat_1)
2583 (init_iterator): Empty the bidi cache "stack".
2584 (move_it_in_display_line_to): If iterator ended up at
2585 EOL, but we never saw any buffer positions smaller than
2586 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2587 motion in bidi-reordered lines.
2588 (move_it_in_display_line_to): Record prev_method and prev_pos
2589 immediately before the call to set_iterator_to_next. Fixes cursor
2590 motion in bidi-reordered lines with stretch glyphs and strings
2591 displayed in margins. (Bug#8133) (Bug#8867)
2592 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2594 (pos_visible_p): Support positions in bidi-reordered lines.
2595 Save and restore bidi cache.
2597 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2598 (bidi_paragraph_info): Delete unused struct.
2599 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2600 (bidi_cache_start): New variable.
2601 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2603 (bidi_cache_fetch_state, bidi_cache_search)
2604 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2605 (bidi_cache_find, bidi_peek_at_next_level)
2606 (bidi_level_of_next_char, bidi_find_other_level_edge)
2607 (bidi_move_to_visually_next): Compare cache index with
2608 bidi_cache_start rather than with zero.
2609 (bidi_fetch_char): Accept new argument STRING; all callers
2610 changed. Support iteration over a string. Support strings with
2611 display properties. Support unibyte strings. Fix the type of
2612 `len' according to what STRING_CHAR_AND_LENGTH expects.
2613 (bidi_paragraph_init, bidi_resolve_explicit_1)
2614 (bidi_resolve_explicit, bidi_resolve_weak)
2615 (bidi_level_of_next_char, bidi_move_to_visually_next):
2616 Support iteration over a string.
2617 (bidi_set_sor_type, bidi_resolve_explicit_1)
2618 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2619 can now be zero (for strings); special values 0 and -1 were
2620 changed to -1 and -2, respectively.
2621 (bidi_char_at_pos): New function.
2622 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2623 Call it instead of FETCH_MULTIBYTE_CHAR.
2624 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2625 initialized to valid values.
2626 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2628 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2629 the test for valid cached positions. Fix the logic for looking up
2630 the sentinel state in the cache. GCPRO the Lisp string we are
2632 (bidi_push_it, bidi_pop_it): New functions.
2633 (bidi_initialize): Initialize the bidi cache start stack pointer.
2634 (bidi_cache_ensure_space): New function, refactored from part of
2635 bidi_cache_iterator_state. Don't assume the required size is just
2636 one BIDI_CACHE_CHUNK away.
2637 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2638 (bidi_count_bytes, bidi_char_at_pos): New functions.
2639 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2640 always valid if bidi_cache_idx is valid.
2641 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2642 is valid if it's going to be used.
2643 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2644 (bidi_cache_fetch_state, bidi_cache_search)
2645 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2646 (bidi_cache_iterator_state, bidi_cache_find)
2647 (bidi_find_other_level_edge, bidi_cache_start_stack):
2648 All variables related to cache indices are now EMACS_INT.
2650 * dispextern.h (struct bidi_string_data): New structure.
2651 (struct bidi_it): New member `string'. Make flag members be 1-bit
2652 fields, and put them last in the struct.
2653 (compute_display_string_pos, compute_display_string_end):
2655 (bidi_push_it, bidi_pop_it): Add prototypes.
2656 (struct iterator_stack_entry): New members bidi_p,
2657 paragraph_embedding, and from_disp_prop_p.
2658 (struct it): Member bidi_p is now a bit field 1 bit wide.
2659 (bidi_shelve_cache, bidi_unshelve_cache):
2662 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2663 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2664 and vector-like objects.
2666 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2667 cache around display iteration.
2669 * window.c (Fwindow_end, window_scroll_pixel_based)
2670 (displayed_window_lines, Frecenter): Save and restore the bidi
2671 cache around display iteration.
2673 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2675 * editfns.c (Fdelete_region): Clarify the use of the named
2676 parameters (bug#6788).
2678 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2680 * indent.c (Fvertical_motion): Set and restore w->pointm when
2681 saving and restoring the window's buffer (Bug#9006).
2683 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2685 * editfns.c (Fstring_to_char): Clarify just what is returned
2686 (bug#6576). Text by Eli Zaretskii.
2688 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2690 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2692 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2694 * buffer.c (mmap_find): Fix a typo.
2696 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2698 Fix execution of x selection hooks.
2699 * xselect.c (Qx_lost_selection_functions)
2700 (Qx_sent_selection_functions): New vars.
2701 (syms_of_xselect): DEFSYM them.
2702 (x_handle_selection_request): Pass Qx_sent_selection_functions
2703 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2704 (x_handle_selection_clear,x_clear_frame_selections):
2705 Pass Qx_lost_selection_functions rather than
2706 Vx_lost_selection_functions to Frun_hook_with_args.
2708 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2710 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2711 The old code sometimes used this field without initializing it.
2713 * alloc.c (gc_sweep): Don't read past end of array.
2714 In theory, the old code could also have corrupted Emacs internals,
2715 though it'd be very unlikely.
2717 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2719 * character.c (Fcharacterp): Don't advertise optional ignored
2720 argument. (Bug#4026)
2722 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2724 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2727 * window.c (Fset_window_start): Doc fix (bug#4199).
2728 (Fset_window_hscroll): Ditto.
2730 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2732 Fix minor new problems caught by GCC 4.6.1.
2733 * term.c (init_tty): Remove unused local.
2734 * xsettings.c (store_monospaced_changed): Define this function only
2735 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2738 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2740 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2742 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2744 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2745 are the mini-buffer and the echo area (bug#3320).
2747 * term.c (init_tty): Remove support for supdup, c10 and perq
2748 terminals, which are no longer supported (bug#1482).
2750 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2752 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2754 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2756 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2757 for non-popups (Bug#3642).
2759 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2761 * alloc.c (reset_malloc_hooks): Protoize.
2762 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2763 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2764 * cm.c (losecursor): Likewise.
2765 * data.c (fmod): Likewise.
2766 * dispnew.c (swap_glyphs_in_rows): Likewise.
2767 * emacs.c (memory_warning_signal): Likewise.
2768 * floatfns.c (float_error): Likewise.
2769 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2770 (otf_open, font_otf_capability, generate_otf_features)
2771 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2773 * image.c (pbm_read_file): Likewise.
2774 * indent.c (string_display_width): Likewise.
2775 * intervals.c (check_for_interval, search_for_interval)
2776 (inc_interval_count, count_intervals, root_interval)
2777 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2778 * lread.c (defalias): Likewise.
2779 * ralloc.c (r_alloc_check): Likewise.
2780 * regex.c (set_image_of_range_1, set_image_of_range)
2781 (regex_grow_registers): Likewise.
2782 * sysdep.c (strerror): Likewise.
2783 * termcap.c (valid_filename_p, tprint, main): Likewise.
2784 * tparam.c (main): Likewise.
2785 * unexhp9k800.c (run_time_remap, save_data_space)
2786 (update_file_ptrs, read_header, write_header, calculate_checksum)
2787 (copy_file, copy_rest, display_header): Likewise.
2788 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2790 * xdisp.c (check_it): Likewise.
2791 * xfaces.c (register_color, unregister_color, unregister_colors):
2793 * xfns.c (print_fontset_result): Likewise.
2794 * xrdb.c (member, fatal, main): Likewise.
2796 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2798 Fix minor problems found by static checking (Bug#9031).
2799 * chartab.c (char_table_set_range, map_sub_char_table):
2800 Remove unused locals.
2801 (uniprop_table): Now static.
2802 * composite.c (_work_char): Remove unused static var.
2804 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2806 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2808 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2810 * gtkutil.c (qttip_cb): Remove code without function.
2812 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2814 * w32.c (pthread_sigmask): New stub.
2816 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2818 Use pthread_sigmask, not sigprocmask (Bug#9010).
2819 sigprocmask is portable only for single-threaded applications, and
2820 Emacs can be multi-threaded when it uses GTK.
2821 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2823 * callproc.c (Fcall_process):
2824 * process.c (create_process):
2825 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2826 Use pthread_sigmask, not sigprocmask.
2828 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2830 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2831 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2834 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2836 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2837 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2838 (xg_hide_tooltip): Fix comment.
2840 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2841 in registerServicesMenuSendTypes.
2842 (validRequestorForSendType): Don't check ns_return_types.
2844 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2847 2011-07-08 Jason Rumney <jasonr@gnu.org>
2849 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
2850 SH_SHOW for hidden windows (Bug#5482).
2852 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2853 frame struct members of non-existent frames (Bug#6284).
2855 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2857 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2858 variable firstTime not needed on OSX >= 10.6.
2859 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2860 >= 10.5. Use setKnobProportion, setDoubleValue.
2862 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2863 (MAC_OS_X_VERSION_10_5): Define if not defined.
2864 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2865 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2866 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2868 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2869 cString and lossyCString on OSX >= 10.4
2871 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2872 sizeToFit on OSX >= 10.2.
2874 * nsimage.m (allocInitFromFile): Don't use deprecated method
2875 bestRepresentationForDevice on OSX >= 10.6.
2877 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2880 * emacs.c: Declare unexec_init_emacs_zone.
2882 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2884 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2886 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2887 on svcsMenu (Bug#8842).
2889 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2891 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2893 * nsterm.m (QUTF8_STRING): Declare.
2894 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2895 (validRequestorForSendType): Return type is (id).
2896 Change indexOfObjectIdenticalTo to indexOfObject.
2897 Check if we have local selection before returning self (Bug#8842).
2898 (writeSelectionToPasteboard): Put local selection into paste board
2899 if we have a local selection (Bug#8842).
2900 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2902 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2903 (ns_get_local_selection): Declare.
2905 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2907 * keymap.c (describe_map_tree): Don't insert a double newline at
2908 the end of the buffer (bug#1169) and return whether we inserted
2911 * callint.c (Fcall_interactively): Change "reading args" to
2912 "providing args" to try to clarify what it does (bug#1010).
2914 2011-07-07 Kenichi Handa <handa@m17n.org>
2916 * composite.c (composition_compute_stop_pos): Ignore a static
2917 composition starting before CHARPOS (Bug#8915).
2919 * xdisp.c (handle_composition_prop): Likewise.
2921 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2923 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2926 2011-07-07 Kenichi Handa <handa@m17n.org>
2928 * character.h (unicode_category_t): New enum type.
2930 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2931 (Qchar_code_property_table): New variable.
2932 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2933 (UNIPROP_COMPRESSED_FORM_P): New macros.
2934 (char_table_ascii): Uncompress the compressed values.
2935 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2936 Uncompress the compressed values.
2937 (sub_char_table_ref_and_range): Likewise.
2938 (char_table_ref_and_range): Uncompress the compressed values.
2939 (sub_char_table_set): New arg is_uniprop. Callers changed.
2940 Uncompress the compressed values.
2941 (sub_char_table_set_range): Args changed. Callers changed.
2942 (char_table_set_range): Adjuted for the above change.
2943 (map_sub_char_table): Delete args default_val and parent. Add arg
2944 top. Give decoded values to a Lisp function.
2945 (map_char_table): Adjust for the above change. Give decoded
2946 values to a Lisp function. Gcpro more variables.
2947 (uniprop_table_uncompress)
2948 (uniprop_decode_value_run_length): New functions.
2949 (uniprop_decoder, uniprop_decoder_count): New variables.
2950 (uniprop_get_decoder, uniprop_encode_value_character)
2951 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2953 (uniprop_encoder, uniprop_encoder_count): New variables.
2954 (uniprop_get_encoder, uniprop_table)
2955 (Funicode_property_table_internal, Fget_unicode_property_internal)
2956 (Fput_unicode_property_internal): New functions.
2957 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2958 Sunicode_property_table_internal, Sget_unicode_property_internal,
2959 and Sput_unicode_property_internal. Defvar_lisp
2960 char-code-property-alist.
2962 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2963 Vunicode_category_table.
2965 * font.c (font_range): Adjust for the change of
2966 Vunicode_category_table.
2968 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2970 * m/iris4d.h: Remove file, move contents ...
2971 * s/irix6-5.h: ... here.
2973 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2975 Remove unportable assumption about struct layout (Bug#8884).
2976 * alloc.c (mark_buffer):
2977 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2978 (clone_per_buffer_values): Don't assume that
2979 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2980 This isn't true in general, and it's particularly not true
2981 if Emacs is configured with --with-wide-int.
2982 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2983 New macros, used in the buffer.c change.
2985 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2987 * xsettings.c: Use both GConf and GSettings if both are available.
2988 (store_config_changed_event): Add comment.
2989 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2990 (store_tool_bar_style_changed): New functions.
2991 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2992 (struct xsettings): Move font inside HAVE_XFT.
2993 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2994 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2995 Move inside HAVE_XFT.
2996 (something_changed_gsettingsCB): Rename from something_changedCB.
2997 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2999 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3000 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3001 (something_changed_gconfCB): Rename from something_changedCB.
3002 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3003 (parse_settings): Move check for font inside HAVE_XFT.
3004 (read_settings, apply_xft_settings): Add comment.
3005 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3006 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3007 call store_font_name_changed.
3008 (xft_settings_event): Add comment.
3009 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3010 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3011 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3012 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3013 (xsettings_initialize): Call init_gsettings last.
3014 (xsettings_get_system_font, xsettings_get_system_normal_font):
3017 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3019 Random fixes. E.g., (random) never returned negative values.
3020 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3021 subseconds part to the entropy, as that's a bit more random.
3022 Prefer signed to unsigned, since the signedness doesn't matter and
3023 in general we prefer signed. When given a limit, use a
3024 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3025 latter isn't right if USE_2_TAGS_FOR_INTS.
3026 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3027 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3029 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3031 * textprop.c (text_property_stickiness):
3032 Obey Vtext_property_default_nonsticky.
3033 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3034 * w32fns.c (syms_of_w32fns):
3035 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3037 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3039 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3040 This is more efficient than Ffile_directory_p and avoids a minor race.
3042 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3044 * buffer.c (Foverlay_put): Say what the return value is
3047 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3048 is a directory before asking whether to use the file name
3050 (barf_or_query_if_file_exists): Make the "File is a directory"
3051 error be more correct.
3053 * fns.c (Frequire): Remove the mention of the .gz files, since
3054 that's installation-specific, but keep the mention of
3055 `get-load-suffixes'.
3057 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3059 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3060 Report string overflow if the output is too long.
3062 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3064 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3065 (syms_of_gnutls): Remove duplicate DEFSYM for
3066 Qgnutls_bootprop_verify_hostname_error, an error for
3067 Qgnutls_bootprop_verify_error (which is no longer used).
3069 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3070 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3071 Also (re)move comments that are misplaced or no longer relevant.
3073 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3075 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3077 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3079 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3080 and background color parameters if they have been changed.
3082 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3084 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3086 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3088 * xsettings.c (SYSTEM_FONT): Define only when used.
3089 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3091 * keymap.c (access_keymap_1): Now static.
3093 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3095 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3096 leave any prefix arg for the up event (Bug#1586).
3098 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3100 * lread.c (syms_of_lread): Mention single symbols defined by
3101 `defvar' or `defconst' (bug#7154).
3103 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3104 (Frequire): Mention get-load-suffixes.
3106 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3108 * window.h (window): Remove clone_number slot.
3109 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3111 (make_parent_window, make_window, saved_window)
3112 (Fset_window_configuration, save_window_save): Don't deal with
3114 * buffer.c (Qclone_number): Remove declaration.
3115 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3117 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3119 Add multiple inheritance to keymaps.
3120 * keymap.c (Fmake_composed_keymap): New function.
3121 (Fset_keymap_parent): Simplify.
3122 (fix_submap_inheritance): Remove.
3123 (access_keymap_1): New function extracted from access_keymap to handle
3124 embedded parents and handle lists of maps.
3125 (access_keymap): Use it.
3126 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3127 (Fcopy_keymap): Handle embedded parents.
3128 (Fcommand_remapping, define_as_prefix): Simplify.
3129 (Fkey_binding): Simplify.
3130 (syms_of_keymap): Move minibuffer-local-completion-map,
3131 minibuffer-local-filename-completion-map,
3132 minibuffer-local-must-match-map, and
3133 minibuffer-local-filename-must-match-map to Elisp.
3134 (syms_of_keymap): Defsubr make-composed-keymap.
3135 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3136 (parse_menu_item): Trivial simplification.
3138 2011-07-01 Glenn Morris <rgm@gnu.org>
3140 * Makefile.in (SETTINGS_LIBS): Fix typo.
3142 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3144 * coding.c (Fencode_coding_string): Record the last coding system
3145 used, as the function doc string says (bug#8738).
3147 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3149 * xsettings.c (store_monospaced_changed): Take new font as arg and
3150 check for change against current_mono_font.
3151 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3152 (emacs_settings_constructor, emacs_settings_get_property)
3153 (emacs_settings_set_property, emacs_settings_class_init)
3154 (emacs_settings_init, gsettings_obj): Remove.
3155 (something_changedCB): New function for HAVE_GSETTINGS.
3156 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3157 with value as argument.
3158 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3159 g_settings_new (Bug#8967). Do not create gsettings_obj.
3160 Remove calls to g_settings_bind. Connect something_changedCB to
3163 * xgselect.c: Add defined (HAVE_GSETTINGS).
3164 (xgselect_initialize): Ditto.
3166 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3167 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3170 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3172 * eval.c (struct backtrace): Simplify and port the data structure.
3173 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3174 signed bit field, as this assumption is not portable and it makes
3175 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3176 "char debug_on_exit : 1" as this is not portable either; instead,
3177 use the portable "unsigned int debug_on_exit : 1". Remove unused
3178 member evalargs. Remove obsolete comments about cc bombing out.
3180 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3182 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3183 Let HAVE_GSETTINGS override HAVE_GCONF.
3184 (store_monospaced_changed): New function.
3185 (EMACS_SETTINGS): A new type derived from GObject to handle
3186 GSettings notifications.
3187 (emacs_settings_constructor, emacs_settings_get_property)
3188 (emacs_settings_set_property, emacs_settings_class_init):
3190 (gsettings_client, gsettings_obj): New variables.
3191 (GSETTINGS_SCHEMA): New define.
3192 (something_changedCB): Call store_monospaced_changed.
3193 (init_gsettings): New function.
3194 (xsettings_initialize): Call init_gsettings.
3195 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3198 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3201 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3203 * window.c (resize_root_window, grow_mini_window)
3204 (shrink_mini_window): Rename Qresize_root_window to
3205 Qwindow_resize_root_window and Qresize_root_window_vertically to
3206 Qwindow_resize_root_window_vertically.
3208 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3210 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3212 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3214 * makefile.w32-in: Redesign dependencies so they reflect more
3215 clearly which files are directly included by each source file,
3216 and not through other includes.
3218 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3220 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3221 (sort_overlays, overlay_strings): When an overlay's clone number
3222 matches the window's clone number process the overlay even if
3223 the overlay's window property doesn't match the current window.
3225 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3226 (Fwindow_hchild): Rename to Fwindow_left_child.
3227 (Fwindow_next): Rename to Fwindow_next_sibling.
3228 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3229 (resize_window_check): Rename to window_resize_check.
3230 (resize_window_apply): Rename to window_resize_apply.
3231 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3232 (Fdelete_other_windows_internal, resize_frame_windows)
3233 (Fsplit_window_internal, Fdelete_window_internal)
3234 (grow_mini_window, shrink_mini_window)
3235 (Fresize_mini_window_internal): Fix callers accordingly.
3237 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3239 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3240 (emacs_fixed_set_min_size): Remove.
3241 (emacs_fixed_new): Take frame as argument.
3243 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3244 (_EmacsFixedPrivate): Remove minwidth/height.
3245 Add struct frame *f.
3246 (emacs_fixed_init): Initialize priv->f.
3247 (get_parent_class, emacs_fixed_set_min_size): Remove.
3248 (emacs_fixed_new): Set priv->f to argument.
3249 (emacs_fixed_get_preferred_width)
3250 (emacs_fixed_get_preferred_height): Use min_width/height from
3251 frames size_hint to set minimum and natural (Bug#8919).
3252 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3253 and use min_width/height from frames size_hint to set
3254 min_width/height (Bug#8919).
3256 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3257 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3260 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3262 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3263 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3266 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3268 * process.c (wait_reading_process_output): Bypass select if
3269 waiting for a cell while ignoring keyboard input, and input is
3270 pending. Suggested by Jan Djärv (Bug#8869).
3272 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3274 Use gnulib's dup2 module instead of rolling our own.
3275 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3277 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3279 * dispnew.c (scrolling_window): Before scrolling, turn off a
3280 mouse-highlight in the window being scrolled.
3282 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3284 Move DEFSYM to lisp.h and use everywhere.
3286 * character.h (DEFSYM): Move declaration...
3287 * lisp.h (DEFSYM): ...here.
3293 * w32select.c: Don't include character.h.
3295 * alloc.c (syms_of_alloc):
3296 * buffer.c (syms_of_buffer):
3297 * bytecode.c (syms_of_bytecode):
3298 * callint.c (syms_of_callint):
3299 * casefiddle.c (syms_of_casefiddle):
3300 * casetab.c (init_casetab_once):
3301 * category.c (init_category_once, syms_of_category):
3302 * ccl.c (syms_of_ccl):
3303 * cmds.c (syms_of_cmds):
3304 * composite.c (syms_of_composite):
3305 * dbusbind.c (syms_of_dbusbind):
3306 * dired.c (syms_of_dired):
3307 * dispnew.c (syms_of_display):
3308 * doc.c (syms_of_doc):
3309 * editfns.c (syms_of_editfns):
3310 * emacs.c (syms_of_emacs):
3311 * eval.c (syms_of_eval):
3312 * fileio.c (syms_of_fileio):
3313 * fns.c (syms_of_fns):
3314 * frame.c (syms_of_frame):
3315 * fringe.c (syms_of_fringe):
3316 * insdel.c (syms_of_insdel):
3317 * keymap.c (syms_of_keymap):
3318 * lread.c (init_obarray, syms_of_lread):
3319 * macros.c (syms_of_macros):
3320 * msdos.c (syms_of_msdos):
3321 * print.c (syms_of_print):
3322 * process.c (syms_of_process):
3323 * search.c (syms_of_search):
3324 * sound.c (syms_of_sound):
3325 * syntax.c (init_syntax_once, syms_of_syntax):
3326 * terminal.c (syms_of_terminal):
3327 * textprop.c (syms_of_textprop):
3328 * undo.c (syms_of_undo):
3329 * w32.c (globals_of_w32):
3330 * window.c (syms_of_window):
3331 * xdisp.c (syms_of_xdisp):
3332 * xfaces.c (syms_of_xfaces):
3333 * xfns.c (syms_of_xfns):
3334 * xmenu.c (syms_of_xmenu):
3335 * xsettings.c (syms_of_xsettings):
3336 * xterm.c (syms_of_xterm): Use DEFSYM.
3338 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3340 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3342 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3344 Integer and buffer overflow fixes (Bug#8873).
3346 * print.c (printchar, strout): Check for string overflow.
3347 (PRINTPREPARE, printchar, strout):
3348 Don't set size unless allocation succeeds.
3350 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3351 for sizes. Check for string overflow more accurately.
3352 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3354 * macros.c: Integer and buffer overflow fixes.
3355 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3356 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3357 Use ptrdiff_t, not int, for sizes.
3358 Don't increment bufsize until after realloc succeeds.
3359 Check for size-calculation overflow.
3360 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3362 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3364 * lread.c: Integer overflow fixes.
3365 (read_integer): Radix is now EMACS_INT, not int,
3366 to improve quality of diagnostics for out-of-range radices.
3367 Calculate buffer size correctly for out-of-range radices.
3368 (read1): Check for integer overflow in radices, and in
3369 read-circle numbers.
3370 (read_escape): Avoid int overflow.
3371 (Fload, openp, read_buffer_size, read1)
3372 (substitute_object_recurse, read_vector, read_list, map_obarray):
3373 Use ptrdiff_t, not int, for sizes.
3374 (read1): Use EMACS_INT, not int, for sizes.
3375 Check for size overflow.
3377 * image.c (cache_image): Check for size arithmetic overflow.
3379 * lread.c: Integer overflow issues.
3380 (saved_doc_string_size, saved_doc_string_length)
3381 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3382 Now ptrdiff_t, not int.
3383 (read1): Don't assume doc string length fits in int. Check for
3384 out-of-range doc string lengths.
3385 (read_list): Don't assume file position fits in int.
3386 (read_escape): Check for hex character overflow.
3388 2011-06-22 Leo Liu <sdl.web@gmail.com>
3390 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3391 Move to minibuffer.el.
3393 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3395 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3396 The following patches are for when GLYPH_DEBUG && !XASSERT.
3397 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3398 * dispnew.c (flush_stdout):
3399 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3400 Mark as externally visible.
3401 * dispnew.c (check_window_matrix_pointers): Now static.
3402 * dispnew.c (window_to_frame_vpos):
3403 * xfns.c (unwind_create_frame):
3404 * xterm.c (x_check_font): Remove unused local.
3405 * scroll.c (CHECK_BOUNDS):
3406 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3407 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3408 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3409 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3410 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3412 (debug_method_add): Use va_list and vsprintf rather than relying
3413 on undefined behavior with wrong number of arguments.
3414 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3415 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3416 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3417 since we're not interested in debugging glyphs with old libraries.
3418 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3419 GCC 4.6.0's static checking.
3421 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3423 Integer overflow and signedness fixes (Bug#8873).
3424 A few related buffer overrun fixes, too.
3426 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3428 * dispextern.h (struct face.stipple):
3429 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3430 (x_bitmap_mask, x_allocate_bitmap_record)
3431 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3432 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3433 (x_create_bitmap_from_xpm_data):
3434 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3435 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3437 * xfaces.c (load_pixmap):
3438 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3439 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3440 (.bitmaps_last, struct x_output.icon_bitmap):
3441 Use ptrdiff_t, not int, for bitmap indexes.
3442 (x_allocate_bitmap_record): Check for size overflow.
3443 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3445 Use ptrdiff_t, not int, for overlay counts.
3446 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3447 * editfns.c (overlays_around, get_pos_property):
3448 * textprop.c (get_char_property_and_overlay):
3449 * xdisp.c (next_overlay_change, note_mouse_highlight):
3450 * xfaces.c (face_at_buffer_position):
3451 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3452 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3453 (Fnext_overlay_change, Fprevious_overlay_change)
3454 (mouse_face_overlay_overlaps, Foverlays_in):
3455 Use ptrdiff_t, not int, for sizes.
3456 (overlays_at, overlays_in): Check for size-calculation overflow.
3458 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3460 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3461 (x_session_initialize): Do not assume string length fits in int.
3463 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3464 This is unlikely, but can occur if DPI is outlandish.
3466 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3467 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3469 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3470 * xrdb.c (magic_file_p, search_magic_path):
3471 Omit last arg SUFFIX; it was always 0. All callers changed.
3472 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3474 * xfont.c (xfont_match): Avoid need for strlen.
3476 * xfns.c: Don't assume strlen fits in int.
3477 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3479 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3480 not unsigned long, as we prefer signed integers. All callers changed.
3481 Detect integer overflow in repeat count.
3482 (message_dolog): Don't assume print length fits in 39 bytes.
3483 (display_mode_element): Don't assume strlen fits in int.
3485 * termcap.c: Don't assume sizes fit in int and never overflow.
3486 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3487 (gobble_line): Check for size-calculation overflow.
3489 * minibuf.c (Fread_buffer):
3490 * lread.c (intern, intern_c_string):
3491 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3492 Don't assume string length fits in int.
3494 * keyboard.c (parse_tool_bar_item):
3495 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3497 * font.c: Don't assume string length fits in int.
3498 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3499 Use ptrdiff_t, not int.
3500 (font_intern_prop): Don't assume string length fits in int.
3501 Don't assume integer property fits in fixnum.
3502 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3504 * filelock.c: Fix some buffer overrun and integer overflow issues.
3505 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3506 Reformulate so as not to need the command string.
3507 Invoke gzip -cd rather than gunzip, as it's more portable.
3508 (lock_info_type, lock_file_1, lock_file):
3509 Don't assume pid_t and time_t fit in unsigned long.
3510 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3511 (current_lock_owner): Prefer signed type for sizes.
3512 Use memcpy, not strncpy, where memcpy is what is really wanted.
3513 Don't assume (via atoi) that time_t and pid_t fit in int.
3514 Check for time_t and/or pid_t out of range, e.g., via a network share.
3515 Don't alloca where an auto var works fine.
3517 * fileio.c: Fix some integer overflow issues.
3518 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3519 Don't assume string length fits in int.
3520 (directory_file_name): Don't assume string length fits in long.
3521 (make_temp_name): Don't assume pid fits in int, or that its print
3522 length is less than 20.
3524 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3526 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3528 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3530 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3531 We prefer signed integers, even for size calculations.
3533 * emacs.c: Don't assume string length fits in 'int'.
3534 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3535 (main): Don't invoke strlen when not needed.
3537 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3538 (XD_DEBUG_MESSAGE): Don't waste a byte.
3540 * callproc.c (getenv_internal_1, getenv_internal)
3542 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3544 * lread.c (invalid_syntax): Omit length argument.
3545 All uses changed. This doesn't fix a bug, but it simplifies the
3546 code away from its former Hollerith-constant appearance, and it's
3547 one less 'int' to worry about when looking at integer-overflow issues.
3548 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3550 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3551 This didn't break anything, but it didn't help either.
3552 It's confusing to put a bogus integer in a place where the actual
3553 value does not matter.
3554 (LIST_END_P): Remove unused macro and its bogus comment.
3555 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3557 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3558 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3560 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3561 We prefer signed types, and the value cannot exceed the EMACS_INT
3562 range anyway (because otherwise the length would not be representable).
3563 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3564 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3565 This avoids a GCC warning when WIDE_EMACS_INT.
3567 * indent.c (sane_tab_width): New function.
3568 (current_column, scan_for_column, Findent_to, position_indentation)
3569 (compute_motion): Use it. This is just for clarity.
3570 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3572 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3574 * lisp.h (lint_assume): New macro.
3575 * composite.c (composition_gstring_put_cache):
3576 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3578 * editfns.c, insdel.c:
3579 Omit unnecessary forward decls, to simplify future changes.
3581 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3583 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3585 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3586 Use much-faster test for byte-length change.
3587 Don't assume string byte-length fits in 'int'.
3588 Check that character arg fits in 'int'.
3589 (mapcar1): Declare byte as byte, for clarity.
3591 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3593 * fns.c (concat): Catch string overflow earlier.
3594 Do not rely on integer wraparound.
3596 * dispextern.h (struct it.overlay_strings_charpos)
3597 (struct it.selective): Now EMACS_INT, not int.
3598 * xdisp.c (forward_to_next_line_start)
3599 (back_to_previous_visible_line_start)
3600 (reseat_at_next_visible_line_start, next_element_from_buffer):
3601 Don't arbitrarily truncate the value of 'selective' to int.
3603 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3605 * composite.c: Don't truncate sizes to 'int'.
3606 (composition_gstring_p, composition_reseat_it)
3607 (composition_adjust_point): Use EMACS_INT, not int.
3608 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3609 not EMACS_UINT, for indexes.
3611 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3613 * buffer.c: Include <verify.h>.
3614 (struct sortvec.priority, struct sortstr.priority):
3615 Now EMACS_INT, not int.
3616 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3617 (struct sortstr.size, record_overlay_string)
3618 (struct sortstrlist.size, struct sortlist.used):
3619 Don't truncate size to int.
3620 (record_overlay_string): Check for size-calculation overflow.
3621 (init_buffer_once): Check at compile-time, not run-time.
3623 2011-06-22 Jim Meyering <meyering@redhat.com>
3625 Don't leak an XBM-image-sized buffer
3626 * image.c (xbm_load): Free the image buffer after using it.
3628 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3631 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3632 that Sun C diagnosed.
3633 * fns.c (secure_hash): Fix pointer signedness issue.
3634 * intervals.c (static_offset_intervals): New function.
3635 (offset_intervals): Use it.
3637 2011-06-21 Leo Liu <sdl.web@gmail.com>
3640 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3643 * fns.c (secure_hash): Rename from crypto_hash_function and change
3644 the first arg to accept symbols.
3645 (Fsecure_hash): New primitive.
3646 (syms_of_fns): New symbols.
3648 2011-06-20 Deniz Dogan <deniz@dogan.se>
3650 * process.c (Fset_process_buffer): Clarify return value in
3653 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3655 * dispnew.c (add_window_display_history): Use BVAR.
3657 * xdisp.c (debug_method_add): Use BVAR.
3658 (check_window_end, dump_glyph_matrix, dump_glyph)
3659 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3661 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3664 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3665 check till after the cache is created in init_frame_faces.
3667 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3669 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3671 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3673 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3674 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3675 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3677 Improve buffer-overflow checking (Bug#8873).
3678 * fileio.c (Finsert_file_contents):
3679 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3680 Remove the old (too-loose) buffer overflow checks.
3681 They weren't needed, since make_gap checks for buffer overflow.
3682 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3683 The old code merely checked for Emacs fixnum overflow, and relied
3684 on undefined (wraparound) behavior. The new code avoids undefined
3685 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3687 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3688 Tune. Don't use wider integers than needed. Don't use alloca.
3689 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3691 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3693 * insdel.c, lisp.h (buffer_overflow): New function.
3694 (insert_from_buffer_1, replace_range, replace_range_2):
3695 * insdel.c (make_gap_larger):
3696 * editfns.c (Finsert_char):
3697 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3699 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3701 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3703 Integer overflow and signedness fixes (Bug#8873).
3705 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3706 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3708 * fileio.c: Don't assume EMACS_INT fits in off_t.
3709 (emacs_lseek): New static function.
3710 (Finsert_file_contents, Fwrite_region): Use it.
3711 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3713 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3715 * fns.c: Don't overflow int when computing a list length.
3716 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3717 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3718 truncation on 64-bit hosts. Check for QUIT every
3719 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3720 faster and is responsive enough.
3721 (Flength): Report an error instead of overflowing an integer.
3722 (Fsafe_length): Return a float if the value is not representable
3723 as a fixnum. This shouldn't happen except in contrived situations.
3724 (Fnthcdr, Fsort): Don't assume list length fits in int.
3725 (Fcopy_sequence): Don't assume vector length fits in int.
3727 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3728 (header_size, word_size): New constants.
3729 (allocate_vectorlike): Don't check size overflow here.
3730 (allocate_vector): Check it here instead, since this is the only
3731 caller of allocate_vectorlike that could cause overflow.
3732 Check that the new vector's length is representable as a fixnum.
3734 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3735 The previous code was bogus. For example, next_almost_prime (32)
3736 returned 39, which is undesirable as it is a multiple of 3; and
3737 next_almost_prime (24) returned 25, which is a multiple of 5 so
3738 why was the code bothering to check for multiples of 7?
3740 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3742 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3744 Variadic C functions now count arguments with ptrdiff_t.
3745 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3746 Back then I didn't know that the Emacs coding style prefers signed int.
3747 Also, in the meantime I found a few more instances where arguments
3748 were being counted with int, which may truncate counts on 64-bit
3749 machines, or EMACS_INT, which may be unnecessarily wide.
3750 * lisp.h (struct Lisp_Subr.function.aMANY)
3751 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3752 Arg counts are now ptrdiff_t, not size_t.
3753 All variadic functions and their callers changed accordingly.
3754 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3755 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3756 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3757 * callint.c (Fcall_interactively): Check arg count for overflow,
3758 to avoid potential buffer overrun. Use signed char, not 'int',
3759 for 'varies' array, so that we needn't bother to check its size
3760 calculation for overflow.
3761 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3762 * eval.c (apply_lambda):
3763 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3764 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3765 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3767 * callint.c (Fcall_interactively): Don't use index var as event count.
3769 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3770 * mem-limits.h (SIZE): Remove; no longer used.
3772 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3774 Remove unnecessary casts.
3775 * xterm.c (x_term_init):
3776 * xfns.c (x_set_border_pixel):
3777 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3778 These aren't needed now that we assume ANSI C.
3780 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3781 It's more likely to cause problems (due to unsigned overflow)
3784 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3786 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3788 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3790 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3792 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3794 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3796 GLYPH_CODE_FACE returns EMACS_INT, not int.
3797 * dispextern.h (merge_faces):
3798 * xfaces.c (merge_faces):
3799 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3800 Don't assume EMACS_INT fits in int.
3802 * character.h (CHAR_VALID_P): Remove unused parameter.
3803 * fontset.c, lisp.h, xdisp.c: All uses changed.
3805 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3807 * fns.c (concat): Minor tuning based on overflow analysis.
3808 This doesn't fix any bugs. Use int to hold character, instead
3809 of constantly refetching from Emacs object. Use XFASTINT, not
3810 XINT, for value known to be a character. Don't bother comparing
3811 a single byte to 0400, as it's always less.
3813 * floatfns.c (Fexpt):
3814 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3816 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3819 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3821 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3822 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3823 incorrectly succeed when S was a string, because 4294967386 was
3824 truncated before it was used.
3826 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3827 Otherwise, an out-of-range integer could cause undefined behavior
3830 * composite.c: Use int, not EMACS_INT, for characters.
3831 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3832 EMACS_INT, for values that are known to be in character range.
3833 This doesn't fix any bugs but is the usual style inside Emacs and
3834 may generate better code on 32-bit machines.
3836 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3837 This is for reasons similar to the recent CHAR_STRING fix.
3838 * charset.c (Fencode_char): Check that character arg is actually
3839 a character. Pass an int to ENCODE_CHAR.
3840 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3841 wider than 'int', as a compile-time check to prevent future regressions
3844 * character.c (char_string): Remove unnecessary casts.
3846 Make sure a 64-bit char is never passed to CHAR_STRING.
3847 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3848 by silently ignoring the top 32 bits, allowing some values
3849 that were far too large to be valid characters.
3850 * character.h: Include <verify.h>.
3851 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3852 arguments are no wider than unsigned, as a compile-time check
3853 to prevent future regressions in this area.
3855 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3856 (Fsubst_char_in_region):
3858 * xdisp.c (decode_mode_spec_coding):
3859 Adjust to CHAR_STRING's new requirement.
3860 * editfns.c (Finsert_char, Fsubst_char_in_region):
3861 * fns.c (concat): Check that character args are actually
3862 characters. Without this test, these functions did the wrong
3863 thing with wildly out-of-range values on 64-bit hosts.
3865 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3866 These casts should not be needed on 32-bit hosts, either.
3867 * keyboard.c (read_char):
3868 * lread.c (Fload): Remove casts to unsigned.
3870 * lisp.h (UNSIGNED_CMP): New macro.
3871 This fixes comparison bugs on 64-bit hosts.
3872 (ASCII_CHAR_P): Use it.
3873 * casefiddle.c (casify_object):
3874 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3875 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3876 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3877 * dispextern.h (FACE_FROM_ID):
3878 * keyboard.c (read_char): Use UNSIGNED_CMP.
3880 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3881 not to EMACS_INT, to avoid GCC warning.
3883 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3885 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3886 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3887 isn't needed on 32-bit machines.
3889 * buffer.c (Fgenerate_new_buffer_name):
3890 Use EMACS_INT for count, not int.
3891 (advance_to_char_boundary): Return EMACS_INT, not int.
3893 * data.c (Qcompiled_function): Now static.
3895 * window.c (window_body_lines): Now static.
3897 * image.c (gif_load): Rename local to avoid shadowing.
3899 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3900 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3901 * alloc.c (make_save_value): Integer argument is now of type
3903 (mark_object): Use ptrdiff_t, not int.
3904 * lisp.h (pD): New macro.
3905 * print.c (print_object): Use it.
3907 * alloc.c: Use EMACS_INT, not int, to count objects.
3908 (total_conses, total_markers, total_symbols, total_vector_size)
3909 (total_free_conses, total_free_markers, total_free_symbols)
3910 (total_free_floats, total_floats, total_free_intervals)
3911 (total_intervals, total_strings, total_free_strings):
3912 Now EMACS_INT, not int. All uses changed.
3913 (Fgarbage_collect): Compute overall total using a double, so that
3914 integer overflow is less likely to be a problem. Check for overflow
3915 when converting back to an integer.
3916 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3917 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3918 These were 'int' variables that could overflow on 64-bit hosts;
3919 they were never used, so remove them instead of repairing them.
3920 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3921 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3922 Previously, this ceilinged at INT_MAX, but that doesn't work on
3924 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3926 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3927 (allocate_vectorlike): Check for ptrdiff_t overflow.
3928 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3929 when a (possibly-narrower) signed value would do just as well.
3930 We prefer using signed arithmetic, to avoid comparison confusion.
3932 * alloc.c: Catch some string size overflows that we were missing.
3933 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3934 for convenience in STRING_BYTES_MAX.
3935 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3936 The definition here is exact; the one in lisp.h was approximate.
3937 (allocate_string_data): Check for string overflow. This catches
3938 some instances we weren't catching before. Also, it catches
3939 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3940 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3941 and ptrdiff_t and EMACS_INT are both 64 bits.
3943 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3944 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3945 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3947 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3949 * alloc.c (Fmake_string): Check for out-of-range init.
3951 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3953 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3955 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3957 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3958 xg_get_default_scrollbar_width.
3960 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3961 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3962 (style_changed_cb): Call update_theme_scrollbar_width and call
3963 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3964 all frames (Bug#8505).
3965 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3966 Call gtk_window_set_resizable if HAVE_GTK3.
3967 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3968 and height if HAVE_GTK3 (Bug#8505).
3969 (scroll_bar_width_for_theme): New variable.
3970 (update_theme_scrollbar_width): New function.
3971 (xg_get_default_scrollbar_width): Move code to
3972 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3973 (xg_initialize): Call update_theme_scrollbar_width.
3975 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3977 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3979 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3981 * frame.c (make_frame): Call other_buffer_safely instead of
3984 * window.c (temp_output_buffer_show): Call display_buffer with
3985 second argument Vtemp_buffer_show_specifiers and reset latter
3986 immediately after the call.
3987 (Vtemp_buffer_show_specifiers): New variable.
3988 (auto_window_vscroll_p, next_screen_context_lines)
3989 (Vscroll_preserve_screen_position): Remove leading asterisks from
3992 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3994 Fix minor problems found by GCC 4.6.0 static checking.
3995 * buffer.c (Qclone_number): Remove for now, as it's unused.
3996 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3997 (record_buffer): Remove unused local.
3998 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3999 (set_frame_buffer_list): Remove; unused.
4000 * frame.h (other_visible_frames): Remove decl.
4001 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4002 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4003 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4005 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4006 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4007 Define only if HAVE_GPM.
4008 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4009 (update_hints_inhibit): Remove; never set. All uses removed.
4010 * widgetprv.h (emacsFrameClassRec): Remove decl.
4011 * window.c (delete_deletable_window): Now returns void, since it
4012 wasn't returning anything.
4013 (compare_window_configurations): Remove unused locals.
4014 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4015 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4016 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4017 the same widths as pointers. This follows up on the 2011-05-06 patch.
4018 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4019 * xterm.h: Likewise.
4020 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4022 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4024 * makefile.w32-in: Update dependencies.
4025 (LISP_H): Add lib/intprops.h.
4027 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4029 * image.c (gif_load): Add animation frame delay to the metadata.
4030 (syms_of_image): Use DEFSYM. New symbol `delay'.
4032 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4034 * window.c (delete_deletable_window): Re-add.
4035 (Fset_window_configuration): Rewrite to handle dead buffers and
4036 consequently deletable windows.
4037 (window_tree, Fwindow_tree): Remove. Supply functionality in
4039 (compare_window_configurations): Simplify code.
4041 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4043 * image.c (imagemagick_load_image): Fix type mismatch.
4044 (Fimagemagick_types): Likewise.
4046 * window.h (replace_buffer_in_windows): Declare.
4048 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4050 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4051 Qclone_number. Remove external declaration of Qdelete_window.
4052 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4054 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4055 Run Qbuffer_list_update_hook if allowed.
4056 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4057 buffer list implementation.
4058 (other_buffer_safely): New function.
4059 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4060 calls to replace_buffer_in_windows and
4061 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4063 (record_buffer): Inhibit quitting and rewrite using quittable
4064 functions. Run Qbuffer_list_update_hook if allowed.
4065 (Frecord_buffer, Funrecord_buffer): New functions.
4066 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4067 Move switch-to-buffer to window.el.
4068 (bury-buffer): Move to window.el.
4069 (Vbuffer_list_update_hook): New variable.
4071 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4074 * window.h (resize_frame_windows): Move up in code.
4075 (Fwindow_frame): Remove EXFUN.
4076 (replace_buffer_in_all_windows): Remove prototype.
4077 (replace_buffer_in_windows_safely): Add prototype.
4079 * window.c: Declare Qdelete_window static again. Move down
4080 declaration of select_count.
4081 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4082 (Fother_window): Move to window.el.
4083 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4084 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4085 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4087 (replace_buffer_in_windows): Implement by calling
4088 Qreplace_buffer_in_windows.
4089 (replace_buffer_in_all_windows): Remove with some functionality
4090 moved into replace_buffer_in_windows_safely.
4091 (replace_buffer_in_windows_safely): New function.
4092 (select_window_norecord, select_frame_norecord): Move in front
4093 of run_window_configuration_change_hook. Remove now obsolete
4095 (Fset_window_buffer): Rewrite doc-string.
4096 Call Qrecord_window_buffer.
4097 (keys_of_window): Move binding for other-window to window.el.
4099 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4101 * dispextern.h (struct image): Replace data member, whose int_val
4102 and ptr_val fields were not used by anything, with a single
4105 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4106 (gif_clear_image, gif_load, imagemagick_load_image)
4107 (gs_clear_image, gs_load): Callers changed.
4109 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4111 * buffer.h: Include <time.h>, for time_t.
4112 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4114 Fix minor problems found by static checking.
4116 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4118 Make identifiers static if they are not used in other modules.
4119 * data.c (Qcompiled_function, Qframe, Qvector):
4120 * image.c (QimageMagick, Qsvg):
4121 * minibuf.c (Qmetadata):
4122 * window.c (resize_window_check, resize_root_window): Now static.
4123 * window.h (resize_window_check, resize_root_window): Remove decls.
4125 * window.c (window_deletion_count, delete_deletable_window):
4127 (window_body_lines): Now static.
4128 (Fdelete_other_windows_internal): Mark vars as initialized.
4129 Make sure 'resize_failed' is initialized.
4130 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4131 (resize_window_apply): Remove unused local.
4132 * window.h (delete_deletable_window): Remove decl.
4134 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4135 (imagemagick_load_image): Fix pointer signedness problem by changing
4136 last arg from unsigned char * to char *. All uses changed.
4137 Also, fix a local for similar reasons.
4138 Remove unused locals. Remove locals to avoid shadowing.
4139 (fn_rsvg_handle_free): Remove; unused.
4140 (svg_load, svg_load_image): Fix pointer signedness problem.
4141 (imagemagick_load_image): Don't use garbage pointer image_wand.
4143 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4145 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4147 * image.c (gif_load): Fix omitted cast error introduced by
4150 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4152 * window.h (resize_proportionally, orig_total_lines)
4153 (orig_top_line): Remove from window structure.
4154 (set_window_height, set_window_width, change_window_heights)
4155 (Fdelete_window): Remove prototypes.
4156 (resize_frame_windows): Remove duplicate declaration.
4158 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4160 * window.h (resize_frame_windows, resize_window_check)
4161 (delete_deletable_window, resize_root_window)
4162 (resize_frame_windows): Declare prototypes.
4164 * window.c (resize_window_apply): Make definition be "static" to
4165 match the prototype.
4167 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4169 * window.c: Remove declarations of Qwindow_size_fixed,
4170 window_min_size_1, window_min_size_2, window_min_size,
4171 size_window, window_fixed_size_p, enlarge_window, delete_window.
4172 Remove static from declaration of Qdelete_window, it's
4173 temporarily needed by Fbury_buffer.
4174 (replace_window): Don't assign orig_top_line and
4176 (Fdelete_window, delete_window): Remove. Window deletion is
4177 handled by window.el.
4178 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4179 Replace Fdelete_window calls with calls to Qdelete_window.
4180 (Fdelete_other_windows): Remove. Deleting other windows is
4181 handled by window.el.
4182 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4183 handled in window.el.
4184 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4185 Window minimum sizes are handled in window.el.
4186 (shrink_windows, size_window, set_window_height)
4187 (set_window_width, change_window_heights, window_height)
4188 (window_width, CURBEG, CURSIZE, enlarge_window)
4189 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4190 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4191 handled in window.el.
4192 (make_dummy_parent): Rename to make_parent_window and give it a
4193 second argument horflag.
4194 (make_window): Don't set resize_proportionally any more.
4195 (Fsplit_window): Remove. Windows are split in window.el.
4196 (save_restore_action, save_restore_orig_size)
4197 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4198 Resize mini windows in window.el.
4199 (grow_mini_window, shrink_mini_window): Implement by calling
4200 Qresize_root_window_vertically, resize_window_check and
4201 resize_window_apply.
4202 (saved_window, Fset_window_configuration, save_window_save):
4203 Do not handle orig_top_line, orig_total_lines, and
4204 resize_proportionally.
4205 (window_min_height, window_min_width): Move to window.el.
4206 (keys_of_window): Move bindings for delete-other-windows,
4207 split-window, delete-window and enlarge-window to window.el.
4209 * buffer.c: Temporarily extern Qdelete_window.
4210 (Fbury_buffer): Temporarily call Qdelete_window instead of
4211 Fdelete_window (Fbury_buffer will move to window.el soon).
4213 * frame.c (set_menu_bar_lines_1): Remove code handling
4214 orig_top_line and orig_total_lines.
4216 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4217 set_window_height but set heights directly.
4218 (change_frame_size_1): Use resize_frame_windows.
4220 * xdisp.c (init_xdisp): Don't use set_window_height but set
4223 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4224 Use resize_frame_windows instead of change_window_heights and run
4225 run_window_configuration_change_hook.
4227 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4228 instead of change_window_heights and run
4229 run_window_configuration_change_hook.
4231 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4233 * window.c (replace_window): Rename second argument REPLACEMENT to
4234 NEW. New third argument SETFLAG. Rewrite.
4235 (delete_window, make_dummy_parent): Call replace_window with
4237 (window_list_1): Move down in code.
4238 (run_window_configuration_change_hook): Move set_buffer part
4239 before select_frame_norecord part in order to unwind correctly.
4240 Rename count1 to count.
4241 (recombine_windows, delete_deletable_window, resize_root_window)
4242 (Fdelete_other_windows_internal)
4243 (Frun_window_configuration_change_hook, make_parent_window)
4244 (resize_window_check, resize_window_apply, Fresize_window_apply)
4245 (resize_frame_windows, Fsplit_window_internal)
4246 (Fdelete_window_internal, Fresize_mini_window_internal):
4248 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4250 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4252 * window.h (window): Add some new members to window structure -
4253 normal_lines, normal_cols, new_total, new_normal, clone_number,
4254 splits, nest, prev_buffers, next_buffers.
4255 (WINDOW_TOTAL_SIZE): Move here from window.c.
4256 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4258 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4260 (make_dummy_parent): Set new members of windows structure.
4261 (make_window): Move down in code. Handle new members of window
4263 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4264 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4265 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4266 (Fset_window_prev_buffers, Fwindow_next_buffers)
4267 (Fset_window_next_buffers, Fset_window_clone_number):
4269 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4270 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4272 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4273 Argument WINDOW can be now internal window too.
4274 (Fwindow_use_time): Move up in code.
4275 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4277 (Fset_window_configuration, saved_window)
4278 (Fcurrent_window_configuration, save_window_save): Handle new
4279 members of window structure.
4280 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4281 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4282 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4283 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4284 Qget_mru_window, Qresize_root_window,
4285 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4286 Qauto_buffer_name; staticpro them.
4288 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4290 * window.c (Fwindow_total_size, Fwindow_left_column)
4291 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4292 (Fwindow_list_1): New functions.
4293 (window_box_text_cols): Replace with window_body_cols.
4294 (Fwindow_width, Fscroll_left, Fscroll_right):
4295 Use window_body_cols instead of window_box_text_cols.
4296 (delete_window, Fset_window_configuration):
4297 Call delete_all_subwindows with window as argument.
4298 (delete_all_subwindows): Take a window as argument and not a
4300 (window_loop): Remove handling of GET_LRU_WINDOW and
4302 (Fget_lru_window, Fget_largest_window): Move to window.el.
4304 * window.h: Extern window_body_cols instead of
4305 window_box_text_cols. delete_all_subwindows now takes a
4306 Lisp_Object as argument.
4308 * indent.c (compute_motion, Fcompute_motion):
4309 Use window_body_cols instead of window_box_text_cols.
4311 * frame.c (delete_frame): Call delete_all_subwindows with root
4314 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4316 * fns.c (Fputhash): Document return value.
4318 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4320 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4322 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4324 Cons<->int and similar integer overflow fixes (Bug#8794).
4326 Check for overflow when converting integer to cons and back.
4327 * charset.c (Fdefine_charset_internal, Fdecode_char):
4328 Use cons_to_unsigned to catch overflow.
4329 (Fencode_char): Use INTEGER_TO_CONS.
4330 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4331 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4332 * data.c (long_to_cons, cons_to_long): Remove.
4333 (cons_to_unsigned, cons_to_signed): New functions.
4334 These signal an error for invalid or out-of-range values.
4335 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4336 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4337 * font.c (Ffont_variation_glyphs):
4338 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4339 * lisp.h: Include <intprops.h>.
4340 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4341 (cons_to_signed, cons_to_unsigned): New decls.
4342 (long_to_cons, cons_to_long): Remove decls.
4343 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4344 (Fprimitive_undo): Use CONS_TO_INTEGER.
4345 * xfns.c (Fx_window_property): Likewise.
4346 * xselect.c: Include <limits.h>.
4347 (x_own_selection, selection_data_to_lisp_data):
4348 Use INTEGER_TO_CONS.
4349 (x_handle_selection_request, x_handle_selection_clear)
4350 (x_get_foreign_selection, Fx_disown_selection_internal)
4351 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4352 (lisp_data_to_selection_data): Use cons_to_unsigned.
4353 (x_fill_property_data): Use cons_to_signed.
4354 Report values out of range.
4356 Check for buffer and string overflow more precisely.
4357 * buffer.h (BUF_BYTES_MAX): New macro.
4358 * lisp.h (STRING_BYTES_MAX): New macro.
4359 * alloc.c (Fmake_string):
4360 * character.c (string_escape_byte8):
4361 * coding.c (coding_alloc_by_realloc):
4362 * doprnt.c (doprnt):
4363 * editfns.c (Fformat):
4365 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4366 since they may not be the same number.
4367 * editfns.c (Finsert_char):
4368 * fileio.c (Finsert_file_contents):
4369 Likewise for BUF_BYTES_MAX.
4371 * image.c: Use ptrdiff_t, not int, for sizes.
4372 (slurp_file): Switch from int to ptrdiff_t.
4374 (slurp_file): Check that file size fits in both size_t (for
4375 malloc) and ptrdiff_t (for sanity and safety).
4377 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4378 if b->modtime has its maximal value.
4380 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4382 Don't assume time_t can fit into int.
4383 * buffer.h (struct buffer.modtime): Now time_t, not int.
4384 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4385 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4387 Minor fixes for signed vs unsigned integers.
4388 * character.h (MAYBE_UNIFY_CHAR):
4389 * charset.c (maybe_unify_char):
4390 * keyboard.c (read_char, reorder_modifiers):
4391 XINT -> XFASTINT, since the integer must be nonnegative.
4392 * ftfont.c (ftfont_spec_pattern):
4393 * keymap.c (access_keymap, silly_event_symbol_error):
4394 XUINT -> XFASTINT, since the integer must be nonnegative.
4395 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4396 since it makes no difference and we prefer signed.
4397 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4398 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4401 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4403 * window.h (Fwindow_frame): Declare.
4405 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4407 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4408 (SPARE_MEMORY): Always define.
4409 (LARGE_REQUEST): Remove.
4410 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4412 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4414 * lisp.h: Move EXFUNS for Fframe_root_window,
4415 Fframe_first_window and Fset_frame_selected_window to window.h.
4417 * window.h: Move EXFUNS for Fframe_root_window,
4418 Fframe_first_window and Fset_frame_selected_window here from
4421 * frame.c (Fwindow_frame, Fframe_first_window)
4422 (Fframe_root_window, Fframe_selected_window)
4423 (Fset_frame_selected_window): Move to window.c.
4424 (Factive_minibuffer_window): Move to minibuf.c.
4425 (Fother_visible_frames_p): New function.
4427 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4429 * window.c (decode_window, decode_any_window): Move up in code.
4430 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4431 (inhibit_frame_unsplittable): Remove unused variable.
4432 (Fwindow_buffer): Move up and rewrite doc-string.
4433 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4434 (Fwindow_prev): New functions.
4435 (Fwindow_frame): Move here from frame.c. Accept any window as
4437 (Fframe_root_window, Fframe_first_window)
4438 (Fframe_selected_window): Move here from frame.c. Accept frame
4439 or arbitrary window as argument. Update doc-strings.
4440 (Fminibuffer_window): Move up in code.
4441 (Fwindow_minibuffer_p): Move up in code and simplify.
4442 (Fset_frame_selected_window): Move here from frame.c.
4444 (Fselected_window, select_window, Fselect_window): Move up in
4445 code. Minor doc-string fixes.
4447 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4449 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4450 Do not assume that spare memory exists; that assumption is valid
4451 only if SYSTEM_MALLOC.
4452 (LARGE_REQUEST): New macro, so that the issue of large requests
4453 is separated from the issue of spare memory.
4455 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4457 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4460 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4462 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4465 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4467 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4469 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4471 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4472 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4474 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4476 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4478 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4480 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4481 (x_clipboard_manager_save): Add return value.
4482 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4484 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4485 Obey Vx_select_enable_clipboard_manager. Catch errors in
4486 x_clipboard_manager_save (Bug#8779).
4487 (Vx_select_enable_clipboard_manager): New variable.
4488 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4490 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4492 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4494 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4496 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4497 in the current matrix if keep_current_p is non-zero.
4499 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4501 * bidi.c (bidi_level_of_next_char): Fix last change.
4503 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4505 Support bidi reordering of text covered by display properties.
4507 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4508 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4509 (bidi_cache_search, bidi_cache_iterator_state)
4510 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4511 (bidi_level_of_next_char, bidi_move_to_visually_next):
4512 Support character positions inside a run of characters covered by a
4514 (bidi_paragraph_init, bidi_resolve_explicit_1)
4515 (bidi_level_of_next_char): Call bidi_fetch_char and
4516 bidi_fetch_char_advance instead of FETCH_CHAR and
4518 (bidi_init_it): Initialize new members.
4519 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4521 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4522 instead of using explicit *_CHAR codes.
4523 (bidi_resolve_explicit, bidi_resolve_weak):
4524 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4525 bidirectional text is supported only in multibyte buffers.
4526 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4527 it to initialize the frame_window_p member of struct bidi_it.
4528 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4529 (bidi_resolve_explicit, bidi_resolve_weak)
4530 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4531 bidi_it->nchars is non-positive.
4532 (bidi_level_of_next_char): Don't try to lookup the cache for the
4533 next/previous character if nothing is cached there yet, or if we
4534 were just reseat()'ed to a new position.
4536 * xdisp.c (set_cursor_from_row): Set start and stop points
4537 according to the row's direction when priming the loop that looks
4538 for the glyph on which to display cursor.
4539 (single_display_spec_intangible_p): Function deleted.
4540 (display_prop_intangible_p): Reimplement to call
4541 handle_display_spec instead of single_display_spec_intangible_p.
4542 Accept 3 additional arguments needed by handle_display_spec.
4543 This fixes incorrect cursor motion across display property with complex
4544 values: lists, `(when COND...)' forms, etc.
4545 (single_display_spec_string_p): Support property values that are
4546 lists with the argument STRING its top-level element.
4547 (display_prop_string_p): Fix the condition for processing a
4548 property that is a list to be consistent with handle_display_spec.
4549 (handle_display_spec): New function, refactored from the
4550 last portion of handle_display_prop.
4551 (compute_display_string_pos): Accept additional argument
4552 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4553 value of a `display' property is a "replacing spec".
4554 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4555 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4556 the display property, but just return a value indicating whether
4557 the display property will replace the characters it covers.
4558 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4559 frame_window_p members of struct bidi_it.
4560 (compute_display_string_pos, compute_display_string_end):
4562 (push_it): Accept second argument POSITION, where pop_it should
4563 jump to continue iteration.
4564 (reseat_1): Initialize bidi_it.disp_pos.
4566 * keyboard.c (adjust_point_for_property): Adjust the call to
4567 display_prop_intangible_p to its new signature.
4569 * dispextern.h (struct bidi_it): New member frame_window_p.
4570 (bidi_init_it): Update prototypes.
4571 (display_prop_intangible_p): Update prototype.
4572 (compute_display_string_pos, compute_display_string_end):
4574 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4577 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4579 Malloc failure behavior now depends on size of allocation.
4580 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4581 * lisp.h: Change signatures accordingly.
4582 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4583 All callers changed. (Bug#8762)
4585 * gnutls.c: Use Emacs's memory allocators.
4586 Without this change, the gnutls library would invoke malloc etc.
4587 directly, which causes problems on non-SYNC_INPUT hosts, and which
4588 runs afoul of improving memory_full behavior. (Bug#8761)
4589 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4590 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4591 xfree instead of the default malloc, realloc, free.
4592 (Fgnutls_boot): No need to check for memory allocation failure,
4593 since xmalloc does that for us.
4595 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4596 * category.c (hash_get_category_set):
4597 * ccl.c (ccl_driver):
4598 * charset.c (Fdefine_charset_internal):
4599 * charset.h (struct charset.hash_index):
4600 * composite.c (get_composition_id, gstring_lookup_cache)
4601 (composition_gstring_put_cache):
4602 * composite.h (struct composition.hash_index):
4603 * dispextern.h (struct image.hash):
4604 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4605 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4606 (hashfn_equal, hashfn_user_defined, make_hash_table)
4607 (maybe_resize_hash_table, hash_lookup, hash_put)
4608 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4609 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4610 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4611 * image.c (make_image, search_image_cache, lookup_image)
4612 (xpm_put_color_table_h):
4613 * lisp.h (struct Lisp_Hash_Table):
4614 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4615 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4616 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4617 * alloc.c (allocate_vectorlike):
4618 Check for overflow in vector size calculations.
4619 * ccl.c (ccl_driver):
4620 Check for overflow when converting EMACS_INT to int.
4621 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4622 need to be updated by these changes.
4623 * fns.c (make_hash_table, maybe_resize_hash_table):
4624 Check for integer overflow with large hash tables.
4625 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4626 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4627 (SXHASH_REDUCE): New macro.
4628 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4629 Use it instead of discarding useful hash info with large hash values.
4630 (sxhash_float): New function.
4631 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4632 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4633 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4634 Rewrite to use FIXNUM_BITS, as this simplifies things.
4635 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4636 Adjust signatures to match updated version of code.
4637 (consing_since_gc): Now EMACS_INT, since a single hash table can
4638 use more than INT_MAX bytes.
4640 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4642 Make it possible to build with GCC-4.6+ -O2 -flto.
4644 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4646 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4648 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4649 Call minibuffer-inactive-mode.
4651 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4653 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4654 Update dependencies.
4656 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4658 * data.c (init_data): Remove code for UTS, this system is not
4661 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4663 Don't force ./temacs to start in terminal mode.
4665 * frame.c (make_initial_frame): Initialize faces in all cases, not
4666 only when CANNOT_DUMP is defined.
4667 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4669 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4671 * dispnew.c (add_window_display_history): Use const for the string
4672 pointer. Remove declaration, not needed.
4674 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4676 Use 'inline', not 'INLINE'.
4677 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4678 * alloc.c, fontset.c (INLINE): Remove.
4679 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4680 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4681 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4682 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4683 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4685 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4687 Make it possible to run ./temacs.
4689 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4690 syms_of_callproc does the same thing. Remove test for
4691 "initialized", do it in the caller.
4692 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4694 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4696 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4697 (read_minibuf): Use get_minibuffer.
4698 (syms_of_minibuf): Use DEFSYM.
4699 (Qmetadata): New var.
4700 * data.c (Qbuffer): Don't make it static.
4701 (syms_of_data): Use DEFSYM.
4703 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4705 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4706 (CCL_CODE_MIN): New macro.
4708 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4710 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4712 * eval.c (Qdebug): Now static.
4713 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4714 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4715 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4717 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4719 * image.c: Various fixes to ImageMagick code comments.
4720 (Fimagemagick_types): Doc fix.
4722 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4724 Minor fixes prompted by GCC 4.6.0 warnings.
4726 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4728 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4729 (x_clipboard_manager_save_all): Move extern decl to ...
4730 * xterm.h: ... here, so that it can be checked for consistency.
4732 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4734 * xselect.c (x_clipboard_manager_save_frame)
4735 (x_clipboard_manager_save_all): New functions.
4736 (Fx_clipboard_manager_save): Lisp function deleted.
4738 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4739 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4741 * xterm.h: Update prototype.
4743 2011-05-28 William Xu <william.xwl@gmail.com>
4745 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4748 2011-05-28 Jim Meyering <meyering@redhat.com>
4750 Avoid a sign-extension bug in crypto_hash_function.
4751 * fns.c (to_uchar): Define.
4752 (crypto_hash_function): Use it to convert some newly-signed
4753 variables to unsigned, to avoid sign-extension bugs. For example,
4754 without this change, (md5 "truc") would evaluate to
4755 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4756 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4757 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4759 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4761 Integer overflow fixes.
4763 * dbusbind.c: Serial number integer overflow fixes.
4764 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4765 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4766 to hold a serial number that is too large for a fixnum.
4767 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4768 Check for serial numbers out of range. Decode any serial number
4769 that was so large that it became a float. (Bug#8722)
4771 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4772 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4773 Use XFASTINT rather than XUINT when numbers are nonnegative.
4774 (xd_append_arg, Fdbus_method_return_internal):
4775 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4776 arguments, check that Lisp number is nonnegative, rather than
4777 silently wrapping negative numbers around. (Bug#8722)
4778 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4781 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4783 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4785 ccl: add integer overflow checks
4786 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4787 (IN_INT_RANGE): New macros.
4788 (ccl_driver): Use them to check for integer overflow when
4789 decoding a CCL program. Many of the new checks are whether XINT (x)
4790 fits in int; it doesn't always, on 64-bit hosts. The new version
4791 doesn't catch all possible integer overflows, but it's an
4792 improvement. (Bug#8719)
4794 * alloc.c (make_event_array): Use XINT, not XUINT.
4795 There's no need for unsigned here.
4797 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4798 This follows up to the 2011-05-06 change that substituted uintptr_t
4799 for EMACS_INT. This case wasn't caught back then.
4801 Rework Fformat to avoid integer overflow issues.
4802 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4803 now (part of C89). Include <verify.h>.
4804 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4805 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4806 (Fformat): Avoid the prepass trying to compute sizes; it was only
4807 approximate and thus did not catch overflow reliably. Instead, walk
4808 through the format just once, formatting and computing sizes as we go,
4809 checking for integer overflow at every step, and allocating a larger
4810 buffer as needed. Keep track separately whether the format is
4811 multibyte. Keep only the most-recently calculated precision, rather
4812 than them all. Record whether each argument has been converted to
4813 string. Use EMACS_INT, not int, for byte and char and arg counts.
4814 Support field widths and precisions larger than INT_MAX. Avoid
4815 sprintf's undefined behavior with conversion specifications such as %#d
4816 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4817 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4818 formatting out-of-range floating point numbers with int
4821 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4823 * data.c: Avoid integer truncation in expressions involving floats.
4824 * data.c: Include <intprops.h>.
4825 (arith_driver): When there's an integer overflow in an expression
4826 involving floating point, convert the integers to floating point
4827 so that the resulting value does not suffer from catastrophic
4828 integer truncation. For example, on a 64-bit host (* 4
4829 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4830 Do not rely on undefined behavior after integer overflow.
4832 merge count_size_as_multibyte, parse_str_to_multibyte
4833 * character.c, character.h (count_size_as_multibyte):
4834 Rename from parse_str_to_multibyte; all uses changed.
4835 Check for integer overflow.
4836 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4837 since it's now a duplicate of the other. This is more of
4838 a character than a buffer op, so better that it's in character.c.
4839 * fns.c, print.c: Adjust to above changes.
4841 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4843 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4845 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4847 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4848 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4849 (x_clipboard_manager_save): Now static.
4850 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4852 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4853 (crypto_hash_function): Now static.
4854 Fix pointer signedness problems. Avoid unnecessary initializations.
4856 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4858 * termhooks.h (Vselection_alist): Make it terminal-local.
4860 * terminal.c (create_terminal): Initialize it.
4862 * xselect.c: Support for clipboard managers.
4863 (Vselection_alist): Move to termhooks.h as terminal-local var.
4864 (LOCAL_SELECTION): New macro.
4865 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4866 (symbol_to_x_atom): Remove gratuitous arg.
4867 (x_handle_selection_request, lisp_data_to_selection_data)
4868 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4869 (x_own_selection, x_get_local_selection, x_convert_selection):
4870 New arg, specifying work frame. Use terminal-local Vselection_alist.
4871 (some_frame_on_display): Delete unused function.
4872 (Fx_own_selection_internal, Fx_get_selection_internal)
4873 (Fx_disown_selection_internal, Fx_selection_owner_p)
4874 (Fx_selection_exists_p): New optional frame arg.
4875 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4876 (x_handle_selection_clear): Don't treat other terminals with the
4877 same keyboard specially. Use the terminal-local Vselection_alist.
4878 (x_clear_frame_selections): Use Frun_hook_with_args.
4880 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4882 * xterm.h: Add support for those atoms.
4884 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4886 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4887 (converted_selections, conversion_fail_tag): New global variables.
4888 (x_selection_request_lisp_error): Free the above.
4889 (x_get_local_selection): Remove unnecessary code.
4890 (x_reply_selection_request): Args changed; handle arbitrary array
4891 of converted selections stored in converted_selections.
4892 Separate the XChangeProperty and SelectionNotify steps.
4893 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4894 (x_convert_selection): New function.
4895 (x_handle_selection_event): Simplify.
4896 (x_get_foreign_selection): Don't ignore incoming requests while
4897 waiting for an answer; this will fail when we implement
4898 SAVE_TARGETS, and seems unnecessary anyway.
4899 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4900 (Vx_sent_selection_functions): Doc fix.
4902 2011-05-26 Leo Liu <sdl.web@gmail.com>
4904 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4906 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4908 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4910 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4911 for fringe update if it has periodic bitmap.
4912 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4913 and fringe_bitmap_periodic_p.
4915 * fringe.c (get_fringe_bitmap_data): New function.
4916 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4917 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4918 row. Mark glyph row for fringe update if periodicity changed.
4920 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4921 for fringe update unless it has periodic bitmap.
4923 2011-05-25 Kenichi Handa <handa@m17n.org>
4925 * xdisp.c (get_next_display_element): Set correct it->face_id for
4926 a static composition.
4928 2011-05-24 Leo Liu <sdl.web@gmail.com>
4931 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4933 * fns.c (crypto_hash_function, Fsha1): New function.
4934 (Fmd5): Use crypto_hash_function.
4935 (syms_of_fns): Add Ssha1.
4937 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4939 * gnutls.c: Remove unused macros.
4940 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4941 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4942 Remove macros that are defined and never used.
4943 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4945 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4947 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4948 (Fx_get_selection_internal): Minor cleanup.
4949 (Fx_own_selection_internal): Rename arguments for consistency with
4952 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4954 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4956 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4958 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4960 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4962 * dispnew.c (scrolling_window): Don't exclude the case that the
4963 last enabled row in the desired matrix touches the bottom boundary.
4965 2011-05-21 Glenn Morris <rgm@gnu.org>
4967 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4968 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4969 and add some more files.
4971 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4973 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4974 report_file_error introduced by the change from 2011-05-07.
4976 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4978 * systime.h (Time): Define only if emacs is defined.
4979 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4980 where the include path doesn't have X11/X.h by default. See
4981 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4983 2011-05-20 Kenichi Handa <handa@m17n.org>
4985 * composite.c (find_automatic_composition): Fix previous change.
4987 2011-05-20 Glenn Morris <rgm@gnu.org>
4989 * lisp.mk: New file, split from Makefile.in.
4990 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4991 (shortlisp): Remove.
4992 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4994 2011-05-19 Glenn Morris <rgm@gnu.org>
4996 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4997 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4998 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4999 (lisp): Set the order to that of loadup.el.
5000 (shortlisp): Make it a copy of $lisp.
5001 (SOME_MACHINE_LISP): Remove.
5002 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5003 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5005 2011-05-18 Kenichi Handa <handa@m17n.org>
5007 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5008 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5009 (find_automatic_composition): Mostly rewrite for efficiency.
5011 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5013 * makefile.w32-in: Update dependencies.
5015 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5017 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5018 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5020 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5022 Fix some integer overflow issues, such as string length overflow.
5024 * insdel.c (count_size_as_multibyte): Check for string overflow.
5026 * character.c (lisp_string_width): Check for string overflow.
5027 Use EMACS_INT, not int, for string indexes and lengths; in
5028 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5029 the resulting string length overflows an EMACS_INT; instead,
5030 report a string overflow if no precision given. When checking for
5031 precision exhaustion, use a check that cannot possibly have
5032 integer overflow. (Bug#8675)
5033 * character.h (lisp_string_width): Adjust to new signature.
5035 * alloc.c (string_overflow): New function.
5036 (Fmake_string): Use it. This doesn't change behavior, but saves
5037 a few bytes and will simplify future changes.
5038 * character.c (string_escape_byte8): Likewise.
5039 * lisp.h (string_overflow): New decl.
5041 Fixups, following up to the user-interface timestamp change.
5042 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5043 for UI timestamps, instead of unsigned long.
5044 * msdos.c (mouse_get_pos): Likewise.
5045 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5046 * w32gui.h (Time): Define by including "systime.h" rather than by
5047 declaring it ourselves. (Bug#8664)
5049 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5050 * image.c (clear_image_cache): Likewise.
5052 * term.c (term_mouse_position): Don't assume time_t wraparound.
5054 Be more systematic about user-interface timestamps.
5055 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5056 and sometimes 'EMACS_UINT', to represent these timestamps.
5057 This change causes it to use 'Time' uniformly, as that's what X uses.
5058 This makes the code easier to follow, and makes it easier to catch
5059 integer overflow bugs such as Bug#8664.
5060 * frame.c (Fmouse_position, Fmouse_pixel_position):
5061 Use Time, not unsigned long, for user-interface timestamps.
5062 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5063 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5064 * keyboard.h (last_event_timestamp): Likewise.
5065 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5066 * menu.h (xmenu_show): Likewise.
5067 * term.c (term_mouse_position): Likewise.
5068 * termhooks.h (struct input_event.timestamp): Likewise.
5069 (struct terminal.mouse_position_hook): Likewise.
5070 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5071 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5072 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5073 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5075 * menu.h, termhooks.h: Include "systime.h", for Time.
5077 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5078 Don't assume that the difference between two unsigned long values
5079 can fit into an integer. At this point, we know button_down_time
5080 <= event->timestamp, so the difference must be nonnegative, so
5081 there's no need to cast the result if double-click-time is
5082 nonnegative, as it should be; check that it's nonnegative, just in
5083 case. This bug is triggered when events are more than 2**31 ms
5084 apart (about 25 days). (Bug#8664)
5086 * xselect.c (last_event_timestamp): Remove duplicate decl.
5087 (x_own_selection): Remove needless cast to unsigned long.
5089 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5090 that always fit in int. Use a sentinel instead of a counter, to
5091 avoid a temp and to allay GCC's concerns about possible int overflow.
5092 * frame.h (struct frame): Use int for menu_bar_items_used
5093 instead of EMACS_INT, since it always fits in int.
5095 * menu.c (grow_menu_items): Check for int overflow.
5097 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5099 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5100 Before, the code was not consistent. These values cannot exceed
5101 2**31 - 1 so there's no need to make them unsigned.
5102 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5103 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5104 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5106 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5108 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5109 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5110 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5111 presumably because the widths might not match.
5113 * window.c (size_window): Avoid needless test at loop start.
5115 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5117 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5119 2011-05-12 Drew Adams <drew.adams@oracle.com>
5121 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5123 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5125 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5126 `width' to `bar_area_x' and `bar_area_width', respectively.
5127 (x_scroll_run): Take account of fringe background extension.
5129 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5130 Rename local vars `left' and `width' to `bar_area_x' and
5131 `bar_area_width', respectively.
5132 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5133 background extension.
5135 2011-05-10 Jim Meyering <meyering@redhat.com>
5137 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5139 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5141 * image.c (Finit_image_library): Return t for built-in image types,
5142 like pbm and xbm. (Bug#8640)
5144 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5146 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5148 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5150 * w32console.c (Fset_screen_color): Doc fix.
5151 (Fget_screen_color): New function.
5152 (syms_of_ntterm): Defsubr it.
5154 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5155 unlink the temporary file if Fcall_process didn't create it in the
5157 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5158 child process will be redirected to a file specified with `:file'.
5159 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5160 cue to call_process_cleanup not to close that handle.
5162 2011-05-07 Ben Key <bkey76@gmail.com>
5164 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5165 one of two shell specific rules, either bootstrap-temacs-CMD or
5166 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5167 to the previous implementation of the bootstrap-temacs rule.
5168 The bootstrap-temacs-CMD rule is similar to the previous
5169 implementation of the bootstrap-temacs rule except that it
5170 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5173 These changes, along with some changes to nt/configure.bat,
5174 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5175 earlier fix to add support for --cflags and --ldflags options
5176 that include quotes so that it works whether make uses cmd or
5179 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5181 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5182 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5184 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5185 a string. Handle both cases.
5186 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5187 (Fdbus_register_method): Use Qinvalid_function.
5189 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5191 * makefile.w32-in: Update dependencies.
5192 (LISP_H): Add inttypes.h and stdin.h.
5193 (PROCESS_H): Add unistd.h.
5195 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5197 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5198 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5200 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5202 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5204 * term.c (vfatal): Remove stray call to va_end.
5205 It's not needed and the C Standard doesn't allow it here anyway.
5207 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5208 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5210 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5213 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5215 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5217 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5219 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5221 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5223 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5224 * charset.c (Fdefine_charset_internal): Don't initialize
5225 charset.code_space[15]. The value was garbage, on hosts with
5226 32-bit int (Bug#8600).
5228 * lread.c (read_integer): Be more consistent with string-to-number.
5229 Use string_to_number to do the actual conversion; this avoids
5230 rounding errors and fixes some other screwups. Without this fix,
5231 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5232 (digit_to_number): Move earlier, for benefit of read_integer.
5233 Return -1 if the digit is out of range for the base, -2 if it is
5234 not a digit in any supported base. (Bug#8602)
5236 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5238 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5239 to match comment at start of function. This also removes a
5240 GCC warning about overflow in a 32+64-bit port.
5242 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5244 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5245 Reported by Stefan Monnier in
5246 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5247 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5248 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5250 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5251 (EMACS_UINTPTR): Likewise, with uintptr_t.
5253 * lisp.h: Prefer 64-bit EMACS_INT if available.
5254 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5255 on 32-bit hosts that have 64-bit int, so that they can access
5257 However, temporarily disable this change unless the temporary
5258 symbol WIDE_EMACS_INT is defined.
5260 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5262 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5263 This removes an assumption that EMACS_INT and long are the same
5264 width as pointers. The assumption is true for Emacs porting targets
5265 now, but we want to make other targets possible.
5266 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5267 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5268 In the rest of the code, change types of integers that hold casted
5269 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5270 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5271 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5272 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5273 No need to cast type when ORing.
5274 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5275 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5276 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5277 assume EMACS_INT is the same width as char *.
5278 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5279 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5280 Remove no-longer-needed casts.
5281 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5282 (xg_tool_bar_help_callback, xg_make_tool_item):
5283 Use EMACS_INTPTR to hold an integer
5284 that will be cast to void *; this can avoid a GCC warning
5285 if EMACS_INT is not the same width as void *.
5286 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5287 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5288 (current_message_1, set_message_1):
5289 Use a local to convert to proper width without a cast.
5290 * xmenu.c (dialog_selection_callback): Likewise.
5292 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5293 Also, don't assume VALBITS / RAND_BITS is less than 5,
5294 and don't rely on undefined behavior when shifting a 1 left into
5296 * lisp.h (get_random): Change signature to match.
5298 * lread.c (hash_string): Use size_t, not int, for hash computation.
5299 Normally we prefer signed values; but hashing is special, because
5300 it's better to use unsigned division on hash table sizes so that
5301 the remainder is nonnegative. Also, size_t is the natural width
5302 for hashing into memory. The previous code used 'int', which doesn't
5303 retain enough info to hash well into very large tables.
5304 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5306 * dbusbind.c: Don't possibly lose pointer info when converting.
5307 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5308 Use XPNTR rather than XHASH, so that the high-order bits of
5309 the pointer aren't lost when converting through void *.
5311 * eval.c (Fautoload): Don't double-shift a pointer.
5313 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5315 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5317 * gnutls.c (DEF_GNUTLS_FN):
5318 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5320 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5322 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5325 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5327 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5328 New version that can reserve upto 2GB of heap space.
5330 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5332 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5334 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5336 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5337 `gnutls_certificate_set_x509_key_file'.
5339 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5341 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5342 Update dependencies.
5344 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5346 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5347 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5348 Remove unused parameter `fildes'.
5349 * process.c (read_process_output, send_process): Don't pass it.
5351 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5353 Fix previous change: the library cache is defined in w32.c.
5354 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5355 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5357 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5359 Implement dynamic loading of GnuTLS on Windows.
5361 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5362 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5363 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5366 * gnutls.c (Qgnutls_dll): Define.
5367 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5368 (gnutls_*): Declare function pointers.
5369 (init_gnutls_functions): New function to initialize function pointers.
5370 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5371 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5372 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5373 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5374 (emacs_gnutls_write, emacs_gnutls_read)
5375 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5376 (Fgnutls_available_p): New function.
5377 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5378 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5379 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5381 * image.c: Include w32.h.
5382 (Vimage_type_cache): Delete.
5383 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5384 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5385 (w32_delayed_load): Move to w32.c.
5387 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5389 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5390 (w32_delayed_load): Move from image.c. When loading a library, record
5391 its filename in the :loaded-from property of the library id.
5392 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5393 Initialize and staticpro them.
5394 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5396 * process.c: Include lisp.h before w32.h, not after.
5397 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5398 instead of gnutls_record_check_pending.
5400 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5402 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5404 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5405 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5408 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5410 * xterm.c (x_set_frame_alpha): Do not set property on anything
5411 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5413 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5415 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5417 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5419 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5420 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5421 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5422 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5423 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5424 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5425 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5426 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5427 (Qgnutls_bootprop_callbacks_verify): Make static.
5429 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5431 * callproc.c: Indentation fixup.
5433 * sysdep.c (wait_for_termination_1): Make static.
5434 (wait_for_termination, interruptible_wait_for_termination):
5435 Move after wait_for_termination_1.
5437 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5439 * sysdep.c (interruptible_wait_for_termination): New function
5440 which is like wait_for_termination, but allows keyboard
5443 * callproc.c (Fcall_process): Add (:file "file") as an option for
5445 (Fcall_process_region): Ditto.
5447 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5449 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5450 rather than `XVECTOR (FOO)->size'.
5452 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5453 inttypes.h, as a gnulib replacement is used if it not available in
5456 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5458 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5459 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5460 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5462 * coding.c (coding_alloc_by_realloc): Error out if destination
5463 will grow beyond MOST_POSITIVE_FIXNUM.
5464 (decode_coding_emacs_mule): Abort if there isn't enough place in
5465 charbuf for the composition carryover bytes. Reserve an extra
5466 space for up to 2 characters produced in a loop.
5467 (decode_coding_iso_2022): Abort if there isn't enough place in
5468 charbuf for the composition carryover bytes.
5470 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5472 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5473 aborting when %lld or %lll format is passed.
5474 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5475 %llo or %llx format is passed. (Bug#8545)
5477 * window.c (window_scroll_line_based): Use a marker instead of
5478 simple variables to record original value of point. (Bug#7952)
5480 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5481 produced by %s or %c overflows available buffer space. (Bug#8545)
5483 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5485 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5486 (SIZE_MAX): Move defn after all includes, as they might #define it.
5488 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5490 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5492 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5494 * keyboard.c (Qdelayed_warnings_hook): Define.
5495 (command_loop_1): Run `delayed-warnings-hook'
5496 if Vdelayed_warnings_list is non-nil.
5497 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5498 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5500 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5502 * doprnt.c (doprnt): Don't return value smaller than the buffer
5503 size if the message was truncated. (Bug#8545).
5505 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5507 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5508 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5510 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5512 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5514 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5516 * makefile.w32-in: Update dependencies.
5518 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5520 Improve `doprnt' and its usage. (Bug#8545)
5521 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5522 `format_end'. Remove support for %l as a conversion specifier.
5523 Don't use xrealloc. Improve diagnostics when the %l size modifier
5524 is used. Update the commentary.
5526 * eval.c (verror): Simplify calculation of size_t.
5528 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5531 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5533 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5536 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5538 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5539 This makes this file independent of the recent pseudovector change.
5541 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5543 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5545 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5546 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5547 Remove unused local.
5548 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5550 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5551 GCC 4.6.0 optimizes based on type-based alias analysis.
5552 For example, if b is of type struct buffer * and v of type struct
5553 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5554 != &v->size, and therefore "v->size = 1; b->size = 2; return
5555 v->size;" must therefore return 1. This assumption is incorrect
5556 for Emacs, since it type-puns struct Lisp_Vector * with many other
5557 types. To fix this problem, this patch adds a new type struct
5558 vectorlike_header that documents the constraints on layout of vectors
5559 and pseudovectors, and helps optimizing compilers not get fooled
5560 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5561 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5562 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5564 (XSETPVECTYPE): Rewrite in terms of new macro.
5565 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5566 This is a bit clearer, and further avoids the possibility of
5567 undesirable aliasing.
5568 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5569 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5570 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5571 since Lisp_Subr is a special case (no "next" field).
5572 (ASIZE): Now uses header.size rather than size.
5573 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5574 to avoid the hassle of writing XVECTOR (foo)->header.size.
5575 (struct vectorlike_header): New type.
5576 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5577 object, to help avoid aliasing.
5578 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5579 (SUBRP): Likewise, since Lisp_Subr is a special case.
5580 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5581 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5582 (struct Lisp_Hash_Table): Combine first two members into a single
5583 struct vectorlike_header member. All uses of "size" and "next" members
5584 changed to be "header.size" and "header.next".
5585 * buffer.h (struct buffer): Likewise.
5586 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5587 * frame.h (struct frame): Likewise.
5588 * process.h (struct Lisp_Process): Likewise.
5589 * termhooks.h (struct terminal): Likewise.
5590 * window.c (struct save_window_data, struct saved_window): Likewise.
5591 * window.h (struct window): Likewise.
5592 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5593 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5594 * buffer.c (init_buffer_once): Likewise.
5595 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5597 * process.c (Fformat_network_address): Use local var for size,
5600 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5602 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5603 * data.c (atof): Remove decl; no longer used or needed.
5604 (digit_to_number): Move to lread.c.
5605 (Fstring_to_number): Use new string_to_number function, to be
5606 consistent with how the Lisp reader treats infinities and NaNs.
5607 Do not assume that floating-point numbers represent EMACS_INT
5608 without losing information; this is not true on most 64-bit hosts.
5609 Avoid double-rounding errors, by insisting on integers when
5610 parsing non-base-10 numbers, as the documentation specifies.
5611 * lisp.h (string_to_number): New decl, replacing ...
5612 (isfloat_string): Remove.
5613 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5614 (read1): Do not accept +. and -. as integers; this
5615 appears to have been a coding error. Similarly, do not accept
5616 strings like +-1e0 as floating point numbers. Do not report
5617 overflow for integer overflows unless the base is not 10 which
5618 means we have no simple and reliable way to continue.
5619 Break out the floating-point parsing into a new
5620 function string_to_number, so that Fstring_to_number parses
5621 floating point numbers consistently with the Lisp reader.
5622 (digit_to_number): Move here from data.c. Make it static inline.
5623 (E_CHAR, EXP_INT): Remove, replacing with ...
5624 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5625 (string_to_number): New function, replacing isfloat_string.
5626 This function checks for valid syntax and produces the resulting
5627 Lisp float number too. Rework it so that string-to-number
5628 no longer mishandles examples like "1.0e+". Use strtoumax,
5629 so that overflow for non-base-10 numbers is reported only when
5630 there's no portable and simple way to convert to floating point.
5632 * textprop.c (set_text_properties_1): Rewrite for clarity,
5633 and to avoid GCC warning about integer overflow.
5635 * intervals.h (struct interval): Use EMACS_INT for members
5636 where EMACS_UINT might cause problems. See
5637 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5638 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5639 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5641 (offset_intervals): Tell GCC not to worry about length overflow
5642 when negating a negative length.
5644 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5645 (overrun_check_free): Likewise.
5647 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5648 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5651 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5652 (gnutls_make_error): Rename local to avoid shadowing.
5653 (gnutls_emacs_global_deinit): ifdef out; not used.
5654 (Fgnutls_boot): Use const for pointer to readonly storage.
5655 Comment out unused local. Fix pointer signedness problems.
5657 * lread.c (openp): Don't stuff size_t into an 'int'.
5658 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5659 about possible signed overflow.
5661 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5662 (GDK_KEY_g): Don't define if already defined.
5663 (xg_prepare_tooltip): Avoid pointer signedness problem.
5664 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5666 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5667 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5669 * xfns.c (Fx_window_property): Simplify a bit,
5670 to make a bit faster and to avoid GCC 4.6.0 warning.
5671 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5673 * fns.c (internal_equal): Don't assume size_t fits in int.
5675 * alloc.c (compact_small_strings): Tighten assertion a little.
5677 Replace pEd with more-general pI, and fix some printf arg casts.
5678 * lisp.h (pI): New macro, generalizing old pEd macro to other
5679 conversion specifiers. For example, use "...%"pI"d..." rather
5680 than "...%"pEd"...".
5681 (pEd): Remove. All uses replaced with similar uses of pI.
5682 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5683 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5684 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5685 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5686 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5687 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5688 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5690 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5691 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5692 * print.c (safe_debug_print, print_object): Likewise.
5693 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5695 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5696 avoiding the 0 flag, which is not portable.
5697 * process.c (Fmake_network_process): Use pI to avoid cast.
5698 * region-cache.c (pp_cache): Likewise.
5699 * xdisp.c (decode_mode_spec): Likewise.
5700 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5701 behavior on 64-bit hosts with printf arg.
5702 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5703 (x_stop_queuing_selection_requests): Likewise.
5704 (x_get_window_property): Don't truncate byte count to an 'int'
5707 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5708 here, since it parses constructs like leading '-' and spaces,
5709 which are not wanted; and it overflows with large numbers.
5710 Instead, simply match F[0-9]+, which is what is wanted anyway.
5712 * alloc.c: Remove unportable assumptions about struct layout.
5713 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5714 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5715 (allocate_vectorlike, make_pure_vector): Use the new macros,
5716 plus offsetof, to remove unportable assumptions about struct layout.
5717 These assumptions hold on all porting targets that I know of, but
5718 they are not guaranteed, they're easy to remove, and removing them
5719 makes further changes easier.
5721 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5722 This doesn't fix a bug but makes the code clearer.
5723 (string_overrun_cookie): Now const. Use initializers that
5724 don't formally overflow signed char, to avoid warnings.
5725 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5726 can cause Emacs to crash when string overrun checking is enabled.
5727 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5728 multiple of sizeof (EMACS_INT); it need not be, if
5729 alignof(EMACS_INT) < sizeof (EMACS_INT).
5730 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5732 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5734 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5736 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5738 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5739 supposed to be handshaking. (Bug#8556)
5740 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5742 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5744 * lisp.h (Qdebug): List symbol.
5745 * eval.c (Qdebug): Restore global linkage.
5746 * keyboard.c (debug-on-event): New variable.
5747 (handle_user_signal): Break into debugger when debug-on-event
5748 matches the current signal symbol.
5750 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5752 * alloc.c (check_sblock, check_string_bytes)
5753 (check_string_free_list): Convert to standard C.
5755 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5757 * w32.c (emacs_gnutls_push): Fix typo.
5759 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5761 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5762 "cast to pointer from integer of different size".
5764 Improve doprnt and its use in verror. (Bug#8545)
5765 * doprnt.c (doprnt): Document the set of format control sequences
5766 supported by the function. Use SAFE_ALLOCA instead of always
5769 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5770 is one byte too soon. Don't use xrealloc; instead xfree and
5773 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5775 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5778 * gnutls.c: Renamed global_initialized to
5779 gnutls_global_initialized. Added internals for the
5780 :verify-hostname-error, :verify-error, and :verify-flags
5781 parameters of `gnutls-boot' and documented those parameters in the
5782 docstring. Start callback support.
5783 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5784 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5785 on error. Return error code.
5786 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5787 (emacs_gnutls_read): Likewise.
5788 (Fgnutls_boot): Return handshake error code.
5789 (emacs_gnutls_handle_error): New function.
5790 (wsaerror_to_errno): Likewise.
5792 * w32.h (emacs_gnutls_pull): Add prototype.
5793 (emacs_gnutls_push): Likewise.
5795 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5796 (emacs_gnutls_push): Likewise.
5798 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5800 * process.c (wait_reading_process_output): Check if GnuTLS
5801 buffered some data internally if no FDs are set for TLS
5804 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5805 (LIBS): Link to USER_LIBS.
5806 ($(BLD)/gnutls.$(0)): New target.
5808 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5810 * xdisp.c (handle_single_display_spec): Rename the
5811 display_replaced_before_p argument into display_replaced_p, to
5812 make it consistent with the commentary. Fix typos in the
5815 * textprop.c (syms_of_textprop): Remove dead code.
5816 (copy_text_properties): Delete obsolete commentary about an
5817 interface that was deleted long ago. Fix typos in the description
5820 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5821 to changes in oldXMenu/XMenu.h from 2011-04-16.
5822 <menu_help_message, prev_menu_help_message>: Constify.
5823 (IT_menu_make_room): menu->help_text is now `const char **';
5826 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5827 to changes in oldXMenu/XMenu.h from 2011-04-16.
5828 (struct XMenu): Declare `help_text' `const char **'.
5830 * xfaces.c <Qunspecified>: Make extern again.
5832 * syntax.c: Include sys/types.h before including regex.h, as
5835 * doc.c (get_doc_string): Improve the format passed to `error'.
5837 * doprnt.c (doprnt): Improve commentary.
5839 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5841 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5844 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5845 changes in globals.h immediately force recompilation.
5846 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5847 $(CURDIR)/s/ms-w32.h.
5848 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5850 * character.c (Fchar_direction): Function deleted.
5851 (syms_of_character): Don't defsubr it.
5852 <char-direction-table>: Deleted.
5854 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5856 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5857 * doprnt.c: Include limits.h.
5858 (SIZE_MAX): New macro.
5859 (doprnt): Return a size_t value. 2nd arg is now size_t.
5860 Many local variables are now size_t instead of int or unsigned.
5861 Improve overflow protection. Support `l' modifier for integer
5862 conversions. Support %l conversion. Don't assume an EMACS_INT
5863 argument for integer conversions and for %c.
5865 * lisp.h (doprnt): Restore prototype.
5867 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5870 * Makefile.in (base_obj): Add back doprnt.o.
5872 * deps.mk (doprnt.o): Add back prerequisites.
5873 (callint.o): Depend on character.h.
5875 * eval.c (internal_lisp_condition_case): Include the handler
5876 representation in the error message.
5877 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5878 when breaking from the loop.
5880 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5882 * callint.c (Fcall_interactively): When displaying error message
5883 about invalid control letter, pass the character's codepoint, not
5884 a pointer to its multibyte form. Improve display of the character
5885 in octal and display also its hex code.
5887 * character.c (char_string): Use %x to display the (unsigned)
5888 codepoint of an invalid character, to avoid displaying a bogus
5891 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5892 `error', not SYMBOL_NAME itself.
5894 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5895 character arguments to `error'.
5897 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5898 to `error' in error message about FINAL_CHAR argument. Make sure
5899 FINAL_CHAR is a character, and use %c when it is passed as
5900 argument to `error'.
5902 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5904 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5906 * w32.c: Include <time.h>.
5907 (sys_localtime): New function.
5909 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5911 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5913 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5915 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5917 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5920 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5922 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5923 gl_state.e_property when gl_state.object is Qt.
5925 * insdel.c (make_gap_larger): Remove limitation of buffer size
5928 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5930 * xdisp.c (lookup_glyphless_char_display)
5931 (produce_glyphless_glyph): Handle cons cell entry in
5932 glyphless-char-display.
5933 (Vglyphless_char_display): Document it.
5935 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5936 glyphless-char-display.
5938 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5940 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5942 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5944 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5945 definition for no-X builds.
5947 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5949 Static checks with GCC 4.6.0 and non-default toolkits.
5951 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5953 * process.c (keyboard_bit_set): Define only if SIGIO.
5954 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5955 (send_process): Repair possible setjmp clobbering.
5957 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5959 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5961 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5963 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5964 Define only if needed.
5966 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5967 by pacifying GCC about it. Maybe it's time to retire it?
5968 * xfaces.c (USG, __TIMEVAL__): Likewise.
5970 * dispextern.h (struct redisplay_interface): Rename param
5972 * termhooks.h (struct terminal): Likewise.
5973 * xterm.c (xembed_send_message): Likewise.
5975 * insdel.c (make_gap_smaller): Define only if
5976 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5978 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5981 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5982 so that we aren't warned about unused symbols.
5984 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5986 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5988 * xfns.c (x_real_positions): Mark locals as initialized.
5990 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5992 * xterm.c: Fix problems found by static analysis with other toolkits.
5993 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5994 (x_dispatch_event): Declare static if USE_GTK, and
5995 define if USE_GTK || USE_X_TOOLKIT.
5996 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5997 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5998 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5999 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6001 * xmenu.c (menu_help_callback): Pointer type fixes.
6002 Use const pointers when pointing at readonly data. Avoid pointer
6004 (FALSE): Remove unused macro.
6005 (update_frame_menubar): Remove unused decl.
6007 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6009 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6010 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6011 (single_menu_item): Rename local to avoid shadowing.
6013 * keyboard.c (make_lispy_event): Remove unused local var.
6015 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6016 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6018 * bitmaps: Change bitmaps from unsigned char back to the X11
6019 compatible char. Avoid the old compiler warnings about
6020 out-of-range initializers by using, for example, '\xab' rather
6023 * xgselect.c (xgselect_initialize): Check vs interface
6024 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6026 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6028 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6029 to read-only memory.
6031 * fns.c (vector): Remove; this old hack is no longer needed.
6033 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6035 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6037 * xrdb.c (x_load_resources): Omit unused local.
6039 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6040 (x_window): Rename locals to avoid shadowing.
6041 (USG): Use the kludged USG macro, to pacify gcc.
6043 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6044 (x_term_init): Remove local to avoid shadowing.
6046 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6048 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6049 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6051 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6053 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6055 Fix regex.c, syntax.c and friends for buffers > 2GB.
6056 * syntax.h (struct gl_state_s): Declare character position members
6059 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6061 * textprop.c (verify_interval_modification, interval_of):
6062 Declare arguments EMACS_INT.
6064 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6067 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6069 * indent.c (Fvertical_motion): Local variable it_start is now
6072 * regex.c (re_match, re_match_2, re_match_2_internal)
6073 (bcmp_translate, regcomp, regexec, print_double_string)
6074 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6075 (re_compile_pattern, re_exec): Declare arguments and local
6076 variables `size_t' and `ssize_t' and return values `regoff_t', as
6078 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6079 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6080 <compile_stack_type>: `size' and `avail' are now `size_t'.
6082 * regex.h <regoff_t>: Use ssize_t, not int.
6083 (re_search, re_search_2, re_match, re_match_2): Arguments that
6084 specify buffer/string position and length are now ssize_t and
6085 size_t. Return type is regoff_t.
6087 2011-04-16 Ben Key <bkey76@gmail.com>
6089 * nsfont.m: Fixed bugs in ns_get_family and
6090 ns_descriptor_to_entity that were caused by using free to
6091 deallocate memory blocks that were allocated by xmalloc (via
6092 xstrdup). This caused Emacs to crash when compiled with
6093 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6094 --enable-checking=xmallocoverrun). xfree is now used to
6095 deallocate these memory blocks.
6097 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6099 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6101 emacs_write: Accept and return EMACS_INT for sizes.
6102 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6104 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6105 Accept and return EMACS_INT.
6106 (emacs_gnutls_write): Return the number of bytes written on
6108 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6109 (emacs_read, emacs_write): Remove check for negative size, as the
6110 Emacs source code has been audited now.
6111 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6112 (emacs_read, emacs_write): Use it.
6113 * process.c (send_process): Adjust to the new signatures of
6114 emacs_write and emacs_gnutls_write. Do not attempt to store
6115 a byte offset into an 'int'; it might overflow.
6116 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6118 * sound.c: Don't assume sizes fit in 'int'.
6119 (struct sound_device.period_size, alsa_period_size):
6120 Return EMACS_INT, not int.
6121 (struct sound_device.write, vox_write, alsa_write):
6122 Accept EMACS_INT, not int.
6123 (wav_play, au_play): Use EMACS_INT to store sizes and to
6124 record read return values.
6126 2011-04-15 Ben Key <bkey76@gmail.com>
6128 * keyboard.c (Qundefined): Don't declare static since it is used
6130 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6131 static since they are used in nsfont.m.
6133 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6135 * process.c (Qprocessp): Don't declare static.
6136 * lisp.h (Qprocessp): Declare again.
6138 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6140 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6142 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6144 Improve C-level modularity by making more things 'static'.
6146 Don't publish debugger-only interfaces to other modules.
6147 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6148 (verify_bytepos, count_markers): Move decls to the only modules
6150 * region-cache.h (pp_cache): Likewise.
6151 * window.h (check_all_windows): Likewise.
6152 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6154 * sysdep.c (croak): Now static, if
6155 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6156 * syssignal.h (croak): Declare only if not static.
6158 * alloc.c (refill_memory_reserve): Now static if
6159 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6160 * lisp.h (refill_memory_reserve): Declare only if not static.
6162 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6163 Define only if USE_LUCID.
6165 * xrdb.c (x_customization_string, x_rm_string): Now static.
6167 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6168 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6170 * xdisp.c (draw_row_with_mouse_face): Now static.
6171 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6173 * window.h (check_all_windows): Mark externally visible.
6175 * window.c (window_deletion_count): Now static.
6177 * undo.c: Make symbols static if they're not exported.
6178 (last_undo_buffer, last_boundary_position, pending_boundary):
6181 * textprop.c (interval_insert_behind_hooks): Now static.
6182 (interval_insert_in_front_hooks): Likewise.
6184 * term.c: Make symbols static if they're not exported.
6185 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6186 (max_frame_lines, tty_set_terminal_modes):
6187 (tty_reset_terminal_modes, tty_turn_off_highlight):
6188 (get_tty_terminal): Now static.
6189 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6190 * termhooks.h (term_mouse_moveto): Do not declare if
6192 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6193 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6195 * sysdep.c: Make symbols static if they're not exported.
6196 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6198 (sigprocmask_set, full_mask): Remove; unused.
6199 (wait_debugging): Mark as visible.
6200 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6201 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6203 * syntax.c (syntax_temp): Define only if !__GNUC__.
6205 * sound.c (current_sound_device, current_sound): Now static.
6207 * search.c (searchbufs, searchbuf_head): Now static.
6209 * scroll.c (scroll_cost): Remove; unused.
6210 * dispextern.h (scroll_cost): Remove decl.
6212 * region-cache.h (pp_cache): Mark as externally visible.
6214 * process.c: Make symbols static if they're not exported.
6215 (process_tick, update_tick, create_process, chan_process):
6216 (Vprocess_alist, proc_buffered_char, datagram_access):
6217 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6218 (deactivate_process): Mark defn as static, as well as decl.
6219 * lisp.h (create_process): Remove decl.
6220 * process.h (chan_process, Vprocess_alist): Remove decls.
6222 * print.c: Make symbols static if they're not exported.
6223 (print_depth, new_backquote_output, being_printed, print_buffer):
6224 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6225 (print_interval, print_number_index, initial_stderr_stream):
6227 * lisp.h (Fprinc): Remove decl.
6228 (debug_output_compilation_hack): Mark as externally visible.
6230 * sysdep.c (croak): Move decl from here to syssignal.h.
6231 * syssignal.h (croak): Put it here, so the API can be checked when
6232 'croak' is called from dissociate_if_controlling_tty.
6234 * minibuf.c: Make symbols static if they're not exported.
6235 (minibuf_save_list, choose_minibuf_frame): Now static.
6236 * lisp.h (choose_minibuf_frame): Remove decl.
6238 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6240 * lread.c: Make symbols static if they're not exported.
6241 (read_objects, initial_obarray, oblookup_last_bucket_number):
6243 (make_symbol): Remove; unused.
6244 * lisp.h (initial_obarray, make_symbol): Remove decls.
6246 * keyboard.c: Make symbols static if they're not exported.
6247 (single_kboard, recent_keys_index, total_keys, recent_keys):
6248 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6249 (this_single_command_key_start, echoing, last_auto_save):
6250 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6251 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6252 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6253 (Vlispy_mouse_stem, double_click_count):
6255 (force_auto_save_soon): Define only if SIGDANGER.
6256 (ignore_mouse_drag_p): Now static if
6257 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6258 (print_help): Remove; unused.
6259 (stop_character, last_timer_event): Mark as externally visible.
6260 * keyboard.h (ignore_mouse_drag_p): Declare only if
6261 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6262 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6263 * lisp.h (echoing): Remove decl.
6264 (force_auto_save_soon): Declare only if SIGDANGER.
6265 * xdisp.c (redisplay_window): Simplify code, to make it more
6266 obvious that ignore_mouse_drag_p is not accessed if !defined
6267 USE_GTK && !defined HAVE_NS.
6269 * intervals.c: Make symbols static if they're not exported.
6270 (merge_properties_sticky, merge_interval_right, delete_interval):
6272 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6274 * insdel.c: Make symbols static if they're not exported.
6275 However, leave prepare_to_modify_buffer alone. It's never
6276 called from outside this function, but that appears to be a bug.
6277 (combine_after_change_list, combine_after_change_buffer):
6278 (adjust_after_replace, signal_before_change): Now static.
6279 (adjust_after_replace_noundo): Remove; unused.
6280 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6281 (signal_before_change): Remove decls.
6283 * indent.c (val_compute_motion, val_vmotion): Now static.
6285 * image.c: Make symbols static if they're not exported.
6286 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6288 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6289 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6291 * fringe.c (standard_bitmaps): Now static.
6292 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6294 * frame.c: Make symbols static if they're not exported.
6295 (x_report_frame_params, make_terminal_frame): Now static.
6296 (get_frame_param): Now static, unless HAVE_NS.
6297 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6298 (x_get_resource_string): Remove; not used.
6299 * frame.h (make_terminal_frame, x_report_frame_params):
6300 (x_get_resource_string); Remove decls.
6301 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6302 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6304 * font.c, fontset.c: Make symbols static if they're not exported.
6305 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6306 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6307 * font.c (font_close_object): Now static.
6308 * font.h (font_close_object): Remove.
6309 * fontset.c (FONTSET_OBJLIST): Remove.
6310 (free_realized_fontset) #if-0 the body, which does nothing.
6311 (face_suitable_for_char_p): #if-0, as it's never called.
6312 * fontset.h (face_suitable_for_char_p): Remove decl.
6313 * xfaces.c (face_at_string_position):
6314 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6315 since 0 is always ASCII.
6317 * fns.c (weak_hash_tables): Now static.
6319 * fileio.c: Make symbols static if they're not exported.
6320 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6321 (Vwrite_region_annotation_buffers): Now static.
6323 * eval.c: Make symbols static if they're not exported.
6324 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6325 * lisp.h (backtrace_list): Remove decl.
6327 * emacs.c: Make symbols static if they're not exported.
6328 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6329 (fatal_error_code, fatal_error_signal_hook, standard_args):
6331 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6332 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6333 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6334 * lisp.h (fatal_error_signal_hook): Remove decl.
6335 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6337 * editfns.c: Move a (normally-unused) function to its only use.
6338 * editfns.c, lisp.h (get_operating_system_release): Remove.
6339 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6340 worth the hassle of breaking this out.
6342 * xterm.c: Make symbols static if they're not exported.
6343 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6344 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6345 (x_destroy_window, x_delete_display):
6347 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6348 (x_mouse_leave): Remove; unused.
6349 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6350 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6351 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6353 (x_mouse_leave): Declare only if WINDOWSNT.
6354 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6355 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6358 * ftxfont.c: Make symbols static if they're not exported.
6359 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6361 * font.h (ftxfont_driver): Likewise.
6363 * xfns.c: Make symbols static if they're not exported.
6364 (x_last_font_name, x_display_info_for_name):
6365 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6366 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6367 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6368 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6369 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6370 (last_show_tip_args): Now static.
6371 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6372 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6373 (x_screen_planes): Remove; unused.
6374 * dispextern.h (x_screen_planes): Remove decl.
6376 * dispnew.c: Make symbols static if they're not exported.
6377 * dispextern.h (redraw_garbaged_frames, scrolling):
6378 (increment_row_positions): Remove.
6379 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6380 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6382 (redraw_garbaged_frames): Remove; unused.
6384 * xfaces.c: Make symbols static if they're not exported.
6385 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6387 * xterm.h (defined_color): Remove decls.
6388 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6389 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6390 (menu_face_changed_default, defined_color, free_realized_face):
6391 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6392 (ascii_face_of_lisp_face): Remove; unused.
6394 * xdisp.c: Make symbols static if they're not exported.
6395 * dispextern.h (scratch_glyph_row, window_box_edges):
6396 (glyph_to_pixel_coords, set_cursor_from_row):
6397 (get_next_display_element, set_iterator_to_next):
6398 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6399 (show_mouse_face): Remove decls
6400 * frame.h (message_buf_print): Likewise.
6401 * lisp.h (pop_message, set_message, check_point_in_composition):
6403 * xterm.h (set_vertical_scroll_bar): Likewise.
6404 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6405 (message_buf_print, scratch_glyph_row, displayed_buffer):
6406 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6407 (get_next_display_element, show_mouse_face, window_box_edges):
6408 (frame_to_window_pixel_xy, check_point_in_composition):
6409 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6410 (glyph_to_pixel_coords): Remove; unused.
6412 * dired.c (file_name_completion): Now static.
6414 * dbusbind.c (xd_in_read_queued_messages): Now static.
6416 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6417 * data.c (circular_list_error): Remove.
6419 * commands.h (last_point_position, last_point_position_buffer):
6420 (last_point_position_window): Remove decls.
6421 * keyboard.c: Make these variables static.
6423 * coding.h (coding, code_convert_region, encode_coding_gap):
6425 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6426 (iso_code_class, detect_coding, code_convert_region): Now static.
6427 (encode_coding_gap): Remove; unused.
6429 * chartab.c (chartab_chars, chartab_bits): Now static.
6431 * charset.h (charset_iso_8859_1): Remove decl.
6432 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6435 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6436 * ccl.c (Vccl_program_table): Now static.
6437 (check_ccl_update): Remove; unused.
6439 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6440 * category.h: ... from here.
6441 * category.c (check_category_table, set_category_set): Now static.
6443 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6444 * lisp.h: Remove these decls.
6446 * buffer.c (buffer_count): Remove unused var.
6448 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6449 so that it's not optimized away.
6450 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6451 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6452 exported only to the debugger.
6454 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6455 * atimer.h (run_all_atimers): Remove; not exported.
6457 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6458 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6459 was inaccessible from Lisp.
6460 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6461 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6463 alloc.c: Import and export fewer symbols, and remove unused items.
6464 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6466 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6467 it's not optimized away by whole-program optimization.
6468 (message_enable_multibyte, free_misc): Remove.
6469 (catchlist, handlerlist, mark_backtrace):
6470 Declare only if BYTE_MARK_STACK.
6471 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6472 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6473 (message_enable_multibyte): Remove decl.
6474 (free_misc, interval_free_list, float_block, float_block_index):
6475 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6476 (cons_free_list, last_marked_index):
6478 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6479 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6480 (mark_backtrace): Define only if BYTE_MARK_STACK.
6481 * xdisp.c (message_enable_multibyte): Now static.
6483 Declare Lisp_Object Q* variables to be 'static' if not exported.
6484 This makes it easier for human readers (and static analyzers)
6485 to see whether these variables are used from other modules.
6486 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6487 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6488 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6489 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6490 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6491 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6492 * xmenu.c, xselect.c:
6493 Declare Q* vars static if they are not used in other modules.
6494 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6495 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6496 Remove decls of unexported vars.
6497 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6499 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6501 Make Emacs functions such as Fatom 'static' by default.
6502 This makes it easier for human readers (and static analyzers)
6503 to see whether these functions can be called from other modules.
6504 DEFUN now defines a static function. To make the function external
6505 so that it can be used in other C modules, use the new macro DEFUE.
6506 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6507 (Finit_image_library):
6508 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6509 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6510 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6511 Remove decls, since these functions are now static.
6512 (Funintern, Fget_internal_run_time): New decls, since these functions
6513 were already external.
6515 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6516 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6517 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6518 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6519 * keyboard.c, keymap.c, lread.c:
6520 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6521 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6522 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6523 Mark functions with DEFUE instead of DEFUN,
6524 if they are used in other modules.
6525 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6526 decls for now-static functions.
6527 * buffer.h (Fdelete_overlay): Remove decl.
6528 * callproc.c (Fgetenv_internal): Mark as internal.
6529 * composite.c (Fremove_list_of_text_properties): Remove decl.
6530 (Fcomposition_get_gstring): New forward static decl.
6531 * composite.h (Fcomposite_get_gstring): Remove decl.
6532 * dired.c (Ffile_attributes): New forward static decl.
6533 * doc.c (Fdocumntation_property): New forward static decl.
6534 * eval.c (Ffetch_bytecode): New forward static decl.
6535 (Funintern): Remove extern decl; now in .h file where it belongs.
6536 * fileio.c (Fmake_symbolic_link): New forward static decl.
6537 * image.c (Finit_image_library): New forward static decl.
6538 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6539 * intervals.h (Fprevious_property_change):
6540 (Fremove_list_of_text_properties): Remove decls.
6541 * keyboard.c (Fthis_command_keys): Remove decl.
6542 (Fcommand_execute): New forward static decl.
6543 * keymap.c (Flookup_key): New forward static decl.
6544 (Fcopy_keymap): Now static.
6545 * keymap.h (Flookup_key): Remove decl.
6546 * process.c (Fget_process): New forward static decl.
6547 (Fprocess_datagram_address): Mark as internal.
6548 * syntax.c (Fsyntax_table_p): New forward static decl.
6549 (skip_chars): Remove duplicate decl.
6550 * textprop.c (Fprevious_property_change): New forward static decl.
6551 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6553 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6554 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6556 * editfns.c (Fformat): Remove unreachable code.
6558 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6560 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6563 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6565 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6566 when at ZV. (Bug#8487)
6568 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6570 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6572 * keyboard.c (parse_tool_bar_item): Likewise.
6573 * sound.c (sound_cleanup, alsa_close): Likewise.
6574 * termcap.c (tgetent): Likewise.
6575 * xfns.c (x_default_font_parameter): Likewise.
6576 * xsettings.c (read_and_apply_settings): Likewise.
6578 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6579 (overrun_check_free): Protoize.
6581 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6583 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6584 since callers should never pass a negative size.
6585 Change the signature to match that of plain 'read' and 'write'; see
6586 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6587 * lisp.h: Update prototypes of emacs_write and emacs_read.
6589 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6591 * xdisp.c (redisplay_window): Don't try to determine the character
6592 position of the scroll margin if the window start point w->startp
6593 is outside the buffer's accessible region. (Bug#8468)
6595 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6597 Fix write-region and its subroutines for buffers > 2GB.
6598 * fileio.c (a_write, e_write): Modify declaration of arguments and
6599 local variables to support buffers larger than 2GB.
6600 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6602 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6603 argument, local variables, and return value.
6605 * lisp.h: Update prototypes of emacs_write and emacs_read.
6607 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6609 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6611 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6613 Fix more problems found by GCC 4.6.0's static checks.
6615 * xdisp.c (vmessage): Use a better test for character truncation.
6617 * charset.c (load_charset_map): <, not <=, for optimization,
6618 and to avoid potential problems with integer overflow.
6619 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6620 * casetab.c (set_identity, shuffle): Likewise.
6621 * editfns.c (Fformat): Likewise.
6622 * syntax.c (skip_chars): Likewise.
6624 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6625 This also lets GCC 4.6.0 generate slightly better loop code.
6627 * callint.c (Fcall_interactively): <, not <=, for optimization.
6628 (Fcall_interactively): Count the number of arguments produced,
6629 not the number of arguments given. This is simpler and lets GCC
6630 4.6.0 generate slightly better code.
6632 * ftfont.c: Distingish more carefully between FcChar8 and char.
6633 The previous code passed unsigned char * to a functions like
6634 strlen and xstrcasecmp that expect char *, which does not
6635 conform to the C standard.
6636 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6637 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6638 char * when the C standard requires it.
6640 * keyboard.c (read_char): Remove unused var.
6642 * eval.c: Port to Windows vsnprintf (Bug#8435).
6644 (SIZE_MAX): Define if the headers do not.
6645 (verror): Do not give up if vsnprintf returns a negative count.
6646 Instead, grow the buffer. This ports to Windows vsnprintf, which
6647 does not conform to C99. Problem reported by Eli Zaretskii.
6648 Also, simplify the allocation scheme, by avoiding the need for
6649 calling realloc, and removing the ALLOCATED variable.
6651 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6653 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6654 But keep the doprint source code for now, as we might revamp it
6655 and use it again (Bug#8435).
6656 * lisp.h (doprnt): Remove.
6657 * Makefile.in (base_obj): Remove doprnt.o.
6658 * deps.mk (doprnt.o): Remove.
6660 error: Print 32- and 64-bit integers portably (Bug#8435).
6661 Without this change, on typical 64-bit hosts error ("...%d...", N)
6662 was used to print both 32- and 64-bit integers N, which relied on
6664 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6666 * lisp.h (error, verror): Mark as printf-like functions.
6667 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6668 Report overflow in size calculations when allocating printf buffer.
6669 Do not truncate output string at its first null byte.
6670 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6671 Truncate the output at a character boundary, since vsnprintf does not
6673 * charset.c (check_iso_charset_parameter): Convert internal
6674 character to string before calling 'error', since %c now has the
6676 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6677 overflow when computing char to be passed to 'error'. Do not
6678 pass Lisp_Object to 'error'; pass the integer instead.
6679 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6680 formatted with plain %d.
6682 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6684 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6686 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6688 * xterm.c (x_catch_errors): Remove duplicate declaration.
6690 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6692 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6694 2011-04-10 Jim Meyering <meyering@redhat.com>
6696 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6697 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6698 return ssize_t not "int", and use size_t as the buffer length.
6699 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6700 * gnutls.h: Update declarations.
6701 * process.c (read_process_output): Use ssize_t, to match.
6702 (send_process): Likewise.
6704 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6706 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6708 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6710 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6711 Use unsigned char, to match FcChar8 type definition.
6713 * xterm.c (handle_one_xevent):
6714 * xmenu.c (create_and_show_popup_menu):
6715 * xselect.c (x_decline_selection_request)
6716 (x_reply_selection_request): Avoid type-punned deref of X events.
6718 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6720 Fix some uses of `int' instead of EMACS_INT.
6721 * search.c (string_match_1, fast_string_match)
6722 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6723 (scan_buffer, find_next_newline_no_quit)
6724 (find_before_next_newline, search_command, Freplace_match)
6725 (Fmatch_data): Make some `int' variables be EMACS_INT.
6727 * xdisp.c (display_count_lines): 3rd argument and return value now
6728 EMACS_INT. All callers changed.
6729 (pint2hrstr): Last argument is now EMACS_INT.
6731 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6732 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6733 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6734 (decode_coding_utf_16, decode_coding_emacs_mule)
6735 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6736 (decode_coding_ccl, decode_coding_charset)
6737 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6738 (decode_coding_iso_2022, decode_coding_emacs_mule)
6739 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6740 <char_offset, last_offset>: Declare EMACS_INT.
6741 (encode_coding_utf_8, encode_coding_utf_16)
6742 (encode_coding_emacs_mule, encode_invocation_designation)
6743 (encode_designation_at_bol, encode_coding_iso_2022)
6744 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6745 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6747 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6748 (encode_invocation_designation): Last argument P_NCHARS is now
6750 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6751 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6753 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6756 * ccl.c (Fccl_execute_on_string): Declare some variables
6759 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6761 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6763 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6765 * process.c (Fformat_network_address): Doc fix.
6767 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6769 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6771 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6773 * keyboard.c (read_char): Call Lisp function help-form-show,
6774 instead of using internal_with_output_to_temp_buffer.
6775 (Qhelp_form_show): New var.
6776 (syms_of_keyboard): Use DEFSYM macro.
6778 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6780 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6782 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6784 * process.c (Flist_processes): Remove to Lisp.
6785 (list_processes_1): Delete.
6787 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6789 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6791 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6793 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6795 Fix more problems found by GCC 4.6.0's static checks.
6797 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6799 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6801 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6803 * xdisp.c (vmessage): Mark as a printf-like function.
6805 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6807 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6809 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6810 printf-like functions.
6811 (tiff_load): Add casts to remove these marks before passing them
6812 to system-supplied API.
6814 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6816 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6817 This avoids several warnings with gcc -Wstrict-overflow.
6818 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6819 directly, rather than having caller test rule sign. This avoids
6820 some unnecessary tests.
6821 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6822 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6823 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6825 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6826 (xfont_open): Avoid unnecessary tests.
6828 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6830 * composite.h, composite.c (composition_gstring_put_cache):
6831 Use EMACS_INT, not int, for length.
6833 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6834 breaking out part of COMPOSITION_DECODE_RULE.
6835 (COMPOSITION_DECODE_RULE): Use it.
6836 * composite.c (get_composition_id): Remove unused local vars,
6837 by using the new macro.
6839 * textprop.c (set_text_properties_1): Change while to do-while,
6840 since the condition is always true at first.
6842 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6843 (interval_deletion_adjustment): Return unsigned value.
6846 * process.c (list_processes_1, create_pty, read_process_output):
6847 (exec_sentinel): Remove vars that were set but not used.
6848 (create_pty): Remove unnecessary "volatile"s.
6849 (Fnetwork_interface_info): Avoid possibility of int overflow.
6850 (read_process_output): Do adaptive read buffering even if carryover.
6851 (read_process_output): Simplify nbytes computation if buffered.
6853 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6855 * syntax.c (scan_words): Remove var that was set but not used.
6856 (update_syntax_table): Use unsigned instead of int.
6858 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6859 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6860 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6862 * print.c (print_error_message): Avoid int overflow.
6864 * font.c (font_list_entities): Redo for clarity,
6865 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6867 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6868 (font_score): Avoid potential overflow in diff calculation.
6870 * fns.c (substring_both): Remove var that is set but not used.
6871 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6873 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6875 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6876 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6877 can always succeed if overflow has undefined behavior.
6879 * search.c (boyer_moore, wordify): Remove vars set but not used.
6880 (wordify): Omit three unnecessary tests.
6882 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6883 All callers changed. This avoids the need for an unused var.
6885 * casefiddle.c (casify_region): Remove var that is set but not used.
6887 * dired.c (file_name_completion): Remove var that is set but not used.
6889 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6891 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6892 (Finsert_file_contents): Remove unnecessary code checking fd.
6894 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6895 Check for integer overflow on size calculations.
6897 * buffer.c (Fprevious_overlay_change): Remove var that is set
6900 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6901 Remove vars that are set but not used.
6902 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6903 (timer_check_2): Mark vars as initialized.
6905 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6907 * image.c (lookup_image): Remove var that is set but not used.
6908 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6910 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6911 that are set but not used.
6913 * xfns.c (make_invisible_cursor): Don't return garbage
6914 if XCreateBitmapFromData fails (Bug#8410).
6916 * xselect.c (x_get_local_selection, x_handle_property_notify):
6917 Remove vars that are set but not used.
6919 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6920 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6922 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6923 Remove var that is set but not used.
6924 (scroll_bar_windows_size): Now size_t, not int.
6925 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6928 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6929 (map_tty_color) [!defined MSDOS]: Likewise.
6931 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6933 * coding.c: Remove vars that are set but not used.
6934 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6935 All callers changed.
6936 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6937 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6938 (decode_coding_charset): Remove vars that are set but not used.
6940 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6941 that is set but not used.
6943 * print.c (print_object): Remove var that is set but not used.
6945 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6946 The gnulib version avoids calling malloc in the usual case,
6947 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6948 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6949 * filelock.c (current_lock_owner): Likewise.
6950 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6951 * sysdep.c: Include allocator.h, careadlinkat.h.
6952 (emacs_no_realloc_allocator): New static constant.
6953 (emacs_readlink): New function.
6954 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6955 ../lib/careadlinkat.h.
6957 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6959 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6960 first non-nil return value).
6962 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6964 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6965 if not defined (Bug#8403).
6967 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6969 * xdisp.c (display_count_lines): Remove parameter `start',
6970 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6971 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6972 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6973 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6974 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6975 and thereabouts. All callers changed.
6976 (get_per_char_metric): Remove parameter `f', unused since
6977 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6979 2011-04-02 Jim Meyering <meyering@redhat.com>
6981 do not dereference NULL upon failed strdup
6982 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6983 (ns_get_family): Likewise.
6985 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6987 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6989 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6991 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6994 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6996 Add lexical binding.
6998 * window.c (Ftemp_output_buffer_show): New fun.
6999 (Fsave_window_excursion):
7000 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7002 * lread.c (lisp_file_lexically_bound_p): New function.
7003 (Fload): Bind Qlexical_binding.
7004 (readevalloop): Remove `evalfun' arg.
7005 Bind Qinternal_interpreter_environment.
7006 (Feval_buffer): Bind Qlexical_binding.
7007 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7009 (syms_of_lread): Declare `lexical-binding'.
7011 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7013 * keyboard.c (eval_dyn): New fun.
7014 (menu_item_eval_property): Use it.
7016 * image.c (parse_image_spec): Use Ffunctionp.
7018 * fns.c (concat, mapcar1): Accept byte-code-functions.
7020 * eval.c (Fsetq): Handle lexical vars.
7021 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7022 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7023 (FletX, Flet): Obey lexical binding.
7024 (Fcommandp): Handle closures.
7025 (Feval): New `lexical' arg.
7026 (eval_sub): New function extracted from Feval. Use it almost
7027 everywhere where Feval was used. Look up vars in lexical env.
7029 (Ffunctionp): Move from subr.el.
7030 (Ffuncall): Handle closures.
7031 (apply_lambda): Remove `eval_flags'.
7032 (funcall_lambda): Handle closures and new byte-code-functions.
7033 (Fspecial_variable_p): New function.
7034 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7035 but without exporting it to Lisp.
7037 * doc.c (Fdocumentation, store_function_docstring):
7038 * data.c (Finteractive_form): Handle closures.
7040 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7043 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7045 (exec_byte_code): New function extracted from Fbyte_code to handle new
7046 calling convention for byte-code-functions. Add new byte-codes.
7048 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7050 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7052 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7054 * xdisp.c (redisplay_internal): Fix prototype.
7056 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7058 * xdisp.c (SCROLL_LIMIT): New macro.
7059 (try_scrolling): Use it when setting scroll_limit.
7060 Limit scrolling to 100 screen lines.
7061 (redisplay_window): Even when falling back on "recentering",
7062 position point in the window according to scroll-conservatively,
7063 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7065 (try_scrolling): When point is above the window, allow searching
7066 as far as scroll_max, or one screenful, to compute vertical
7067 distance from PT to the scroll margin position. This prevents
7068 try_scrolling from unnecessarily failing when
7069 scroll-conservatively is set to a value slightly larger than the
7070 window height. Clean up the case of PT below the margin at bottom
7071 of window: scroll_max can no longer be INT_MAX. When aggressive
7072 scrolling is in use, don't let point enter the opposite scroll
7073 margin as result of the scroll.
7074 (syms_of_xdisp) <scroll-conservatively>: Document the
7075 threshold of 100 lines for never-recentering scrolling.
7077 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7079 * dispextern.h (move_it_by_lines):
7080 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7081 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7082 (message_log_check_duplicate): Remove parameters `prev_bol' and
7083 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7084 (redisplay_internal): Remove parameter `preserve_echo_area',
7085 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7087 * indent.c (Fvertical_motion):
7088 * window.c (window_scroll_pixel_based, Frecenter):
7089 Don't pass `need_y_p' to `move_it_by_lines'.
7091 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7093 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7094 steal a few bits to be more compact.
7095 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7096 Remove unneeded casts.
7098 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7100 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7102 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7103 binding" message (bug#7967).
7105 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7107 Fix more problems found by GCC 4.6.0's static checks.
7109 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7110 Remove unused local var.
7112 * editfns.c (Fmessage_box): Remove unused local var.
7114 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7115 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7116 Omit unused local vars.
7117 * window.c (shrink_windows): Omit unused local var.
7118 * menu.c (digest_single_submenu): Omit unused local var.
7119 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7120 Omit unused local var.
7122 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7123 Don't assume string length fits in int.
7124 (keyremap_step, read_key_sequence): Use size_t for sizes.
7125 (read_key_sequence): Don't check last_real_key_start redundantly.
7127 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7128 instead of alloca (Bug#8344).
7130 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7131 (Fbacktrace_frame): Don't assume nframes fits in int.
7133 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7135 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7138 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7140 * cm.c (calccost): Turn while-do into do-while, for clarity.
7142 * keyboard.c (syms_of_keyboard): Use the same style as later
7143 in this function when indexing through an array. This also
7144 works around GCC bug 48267.
7146 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7148 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7150 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7151 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7153 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7154 This avoids undefined behavior on integer overflow, and is a bit
7155 more convenient anyway since it is compared to a size_t variable.
7157 Variadic C functions now count arguments with size_t, not int.
7158 This avoids an unnecessary limitation on 64-bit machines, which
7159 caused (substring ...) to crash on large vectors (Bug#8344).
7160 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7161 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7162 All variadic functions and their callers changed accordingly.
7163 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7164 * data.c (arith_driver, float_arith_driver): Likewise.
7165 * editfns.c (general_insert_function): Likewise.
7166 * eval.c (struct backtrace.nargs, interactive_p)
7167 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7168 (funcall_lambda, mark_backtrace): Likewise.
7169 * fns.c (concat): Likewise.
7170 * frame.c (x_set_frame_parameters): Likewise.
7171 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7172 0 if not found, not -1. All callers changed.
7174 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7175 (stack_copy_size): Now size_t, not int.
7176 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7178 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7180 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7181 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7182 All callers changed.
7184 * lisp.h (multibyte_char_to_unibyte):
7185 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7186 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7187 * character.h (CHAR_TO_BYTE8):
7188 * cmds.c (internal_self_insert):
7189 * editfns.c (general_insert_function):
7190 * keymap.c (push_key_description):
7191 * search.c (Freplace_match):
7192 * xdisp.c (message_dolog, set_message_1): All callers changed.
7194 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7196 * keyboard.c (safe_run_hook_funcall): New function.
7197 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7198 don't set the hook to nil, but remove the offending function instead.
7199 (Qcommand_hook_internal): Remove, unused.
7200 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7201 Vcommand_hook_internal.
7203 * eval.c (enum run_hooks_condition): Remove.
7204 (funcall_nil, funcall_not): New functions.
7205 (run_hook_with_args): Call each function through a `funcall' argument.
7206 Remove `cond' argument, now redundant.
7207 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7208 (Frun_hook_with_args_until_failure): Adjust accordingly.
7209 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7211 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7213 * dispextern.h (string_buffer_position): Remove declaration.
7215 * print.c (strout): Remove parameter `multibyte', unused since
7216 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7218 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7219 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7220 All callers changed.
7222 * w32.c (_wsa_errlist): Use braces for struct initializers.
7224 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7225 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7226 All callers changed.
7227 (string_buffer_position): Likewise. Also, make static (it's never
7228 used outside xdisp.c).
7229 (cursor_row_p): Remove parameter `w', unused since
7230 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7231 (decode_mode_spec): Remove parameter `precision', introduced during
7232 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7233 All callers changed.
7235 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7237 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7239 2011-03-27 Anders Lindgren <andlind@gmail.com>
7241 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7242 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7243 (ns_update_auto_hide_menu_bar): New functions.
7244 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7245 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7246 ns_constrain_all_frames.
7247 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7248 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7250 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7252 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7254 2011-03-27 Glenn Morris <rgm@gnu.org>
7256 * syssignal.h: Replace RETSIGTYPE with void.
7257 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7258 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7259 Replace SIGTYPE with void everywhere.
7260 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7261 * s/template.h (SIGTYPE): Remove commented out definition.
7263 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7265 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7266 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7268 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7270 * w32.c (read_unc_volume): Use parameter `henum', instead of
7271 global variable `wget_enum_handle'.
7273 * keymap.c (describe_vector): Remove parameters `indices' and
7274 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7275 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7277 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7279 * keyboard.c (timer_check): Remove parameter `do_it_now',
7280 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7281 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7282 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7284 * keyboard.c (read_char):
7285 * w32menu.c (w32_menu_display_help):
7286 * xmenu.c (show_help_event, menu_help_callback):
7287 Adjust calls to `show_help_echo'.
7289 * gtkutil.c (xg_maybe_add_timer):
7290 * keyboard.c (readable_events):
7291 * process.c (wait_reading_process_output):
7292 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7294 * insdel.c (adjust_markers_gap_motion):
7295 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7296 (gap_left, gap_right): Don't call it.
7298 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7300 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7301 incurred during fontification.
7303 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7305 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7306 (DEFVAR_PER_BUFFER): Don't pass it.
7308 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7309 (scrolling_window): Don't pass it.
7311 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7313 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7315 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7317 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7318 of variables specific to SELinux and computation of `encoded_absname'.
7320 * image.c (XPutPixel): Remove unused variable `height'.
7322 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7324 * unexw32.c (get_section_info): Remove unused variable `section'.
7326 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7327 (system_process_attributes): Remove unused variable `sess'.
7328 (sys_read): Remove unused variable `err'.
7330 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7331 (w32_wnd_proc): Remove unused variable `isdead'.
7332 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7333 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7334 (x_create_tip_frame): Remove unused variable `tem'.
7336 * w32inevt.c (w32_console_read_socket):
7337 Remove unused variable `no_events'.
7339 * w32term.c (x_draw_composite_glyph_string_foreground):
7340 Remove unused variable `width'.
7342 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7344 * w32term.c (x_set_glyph_string_clipping):
7345 Don't pass uninitialized region to CombineRgn.
7347 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7349 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7350 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7351 (Fx_close_connection): Remove unused variable `i'.
7353 * w32font.c (w32font_draw): Return number of glyphs.
7354 (w32font_open_internal): Remove unused variable `i'.
7355 (w32font_driver): Add missing initializer.
7357 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7358 (fill_in_menu): Remove unused variable `items_added'.
7360 * w32term.c (last_mouse_press_frame): Remove static global variable.
7361 (w32_clip_to_row): Remove unused variable `f'.
7362 (x_delete_terminal): Remove unused variable `i'.
7364 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7365 (NOTHING): Remove unused static global variable.
7366 (uniscribe_check_otf): Remove unused variable `table'.
7367 (uniscribe_font_driver): Add missing initializers.
7369 2011-03-23 Julien Danjou <julien@danjou.info>
7371 * term.c (Fsuspend_tty, Fresume_tty):
7372 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7373 * window.c (temp_output_buffer_show):
7374 * insdel.c (signal_before_change):
7375 * frame.c (Fhandle_switch_frame):
7376 * fileio.c (Fdo_auto_save):
7377 * emacs.c (Fkill_emacs):
7378 * editfns.c (save_excursion_restore):
7379 * cmds.c (internal_self_insert):
7380 * callint.c (Fcall_interactively):
7381 * buffer.c (Fkill_all_local_variables):
7382 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7384 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7385 unconditionnaly since it does the check itself.
7387 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7389 Fix more problems found by GCC 4.5.2's static checks.
7391 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7392 the first time through the loop, since we know p0 < p1 then.
7393 This also avoids a gcc -Wstrict-overflow warning.
7395 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7396 leading to a memory leak, possible in functions like
7397 load_charset_map_from_file that can allocate an unbounded number
7398 of objects (Bug#8318).
7400 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7401 that could (at least in theory) be that large.
7403 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7404 This is less likely to overflow, and avoids undefined behavior if
7405 overflow does occur. All callers changed. Use strtoul to scan
7406 for the unsigned long integer.
7407 (pint2hrstr): Simplify and tune code slightly.
7408 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7410 * scroll.c (do_scrolling): Work around GCC bug 48228.
7411 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7413 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7414 This also avoids a warning with gcc -Wstrict-overflow.
7415 (validate_x_resource_name): Simplify count usage.
7416 This also avoids a warning with gcc -Wstrict-overflow.
7418 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7421 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7423 * process.c (Fmake_network_process): Use socklen_t, not int,
7424 where POSIX says socklen_t is required in portable programs.
7425 This fixes a porting bug on hosts like 64-bit HP-UX, where
7426 socklen_t is wider than int (Bug#8277).
7427 (Fmake_network_process, server_accept_connection):
7428 (wait_reading_process_output, read_process_output):
7431 * process.c: Rename or move locals to avoid shadowing.
7432 (list_processes_1, Fmake_network_process):
7433 (read_process_output_error_handler, exec_sentinel_error_handler):
7434 Rename or move locals.
7435 (Fmake_network_process): Define label "retry_connect" only if needed.
7436 (Fnetwork_interface_info): Fix pointer signedness.
7437 (process_send_signal): Add cast to avoid pointer signedness problem.
7438 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7439 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7441 Make tparam.h and terminfo.c consistent.
7442 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7443 Include tparam.h instead, since it declares them.
7444 * cm.h (PC): Remove extern decl; tparam.h now does this.
7445 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7446 * terminfo.c: Include tparam.h, to check interfaces.
7447 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7448 (tparam): Adjust signature to match interface in tparam.h;
7449 this removes some undefined behavior. Check that outstring and len
7450 are zero, which they always are with Emacs.
7451 * tparam.h (PC, BC, UP): New extern decls.
7453 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7454 (xftfont_open): Rename locals to avoid shadowing.
7456 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7457 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7458 (OTF_TAG_SYM): Omit macro if not needed.
7459 (ftfont_list): Remove unused local.
7460 (get_adstyle_property, ftfont_pattern_entity):
7461 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7462 Rename locals to avoid shadowing.
7464 * xfont.c (xfont_list_family): Mark var as initialized.
7466 * xml.c (make_dom): Now static.
7468 * composite.c (composition_compute_stop_pos): Rename local to
7470 (composition_reseat_it): Remove unused locals.
7471 (find_automatic_composition, composition_adjust_point): Likewise.
7472 (composition_update_it): Mark var as initialized.
7473 (find_automatic_composition): Mark vars as initialized,
7474 with a FIXME (Bug#8290).
7476 character.h: Rename locals to avoid shadowing.
7477 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7478 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7479 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7480 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7483 * textprop.c (property_change_between_p): Remove; unused.
7485 * intervals.c (interval_start_pos): Now static.
7487 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7489 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7490 Rename locals to avoid shadowing.
7492 * sound.c (wav_play, au_play, Fplay_sound_internal):
7493 Fix pointer signedness.
7494 (alsa_choose_format): Remove unused local var.
7495 (wav_play): Initialize a variable to 0, to prevent undefined
7496 behavior (Bug#8278).
7498 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7500 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7502 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7503 clobbering (Bug#8298).
7504 * sysdep.c (sys_subshell): Likewise.
7505 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7507 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7508 This should get cleaned up, so that child_setup has the
7509 same signature on all platforms.
7511 * callproc.c (call_process_cleanup): Now static.
7512 (relocate_fd): Rename locals to avoid shadowing.
7514 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7516 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7517 not to be necessary, and produces flickering.
7519 2011-03-20 Glenn Morris <rgm@gnu.org>
7521 * config.in: Remove file.
7523 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7525 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7526 are now in src/globals.h.
7527 (syms_of_minibuf): Remove spurious & from previous change.
7529 2011-03-20 Leo <sdl.web@gmail.com>
7531 * minibuf.c (completing-read-function): New variable.
7532 (completing-read-default): Rename from completing-read.
7533 (completing-read): Call completing-read-function.
7535 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7537 * xfaces.c (Fx_load_color_file):
7538 Read color file from absolute filename (bug#8250).
7540 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7542 * makefile.w32-in: Update dependencies.
7544 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7546 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7548 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7550 Fix more problems found by GCC 4.5.2's static checks.
7552 * process.c (make_serial_process_unwind, send_process_trap):
7553 (sigchld_handler): Now static.
7555 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7556 That way, the code declares only the vars that it needs.
7557 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7558 * s/cygwin.h (PTY_ITERATION): Likewise.
7559 * s/darwin.h (PTY_ITERATION): Likewise.
7560 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7562 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7563 * process.c (allocate_pty): Don't declare stb unless it's needed.
7565 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7566 (CONSTANTLIM): Remove; unused.
7567 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7568 Define only if needed.
7570 * unexelf.c (unexec): Name an expression,
7571 to avoid gcc -Wbad-function-cast warning.
7572 Use a different way to cause a compilation error if anyone uses
7573 n rather than nn, a way that does not involve shadowing.
7574 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7576 * deps.mk (unexalpha.o): Remove; unused.
7578 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7579 * unexec.h: New file.
7580 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7581 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7583 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7584 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7585 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7586 Change as necessary to match prototype in unexec.h.
7588 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7590 (back_comment, skip_chars): Mark vars as initialized.
7592 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7593 Rename locals to avoid shadowing.
7595 * lread.c (read1): Rewrite so as not to use empty "else".
7596 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7598 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7600 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7601 warning when compiling print.c.
7603 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7604 instead of using an uninitialized var.
7605 (font_sort_entities): Mark var as initialized.
7607 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7609 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7610 pointers to constants.
7611 (font_parse_fcname): Remove unused vars.
7612 (font_delete_unmatched): Now static.
7613 (font_get_spec): Remove; unused.
7614 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7615 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7616 Rename or move locals to avoid shadowing.
7618 * fns.c (require_nesting_list, require_unwind): Now static.
7619 (Ffillarray): Rename locals to avoid shadowing.
7621 * floatfns.c (domain_error2): Define only if needed.
7622 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7624 * alloc.c (mark_backtrace): Move decl from here ...
7625 * lisp.h: ... to here, so that it can be checked.
7627 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7628 (Fdefvar): Rewrite so as not to use empty "else".
7629 (lisp_indirect_variable): Name an expression,
7630 to avoid gcc -Wbad-function-cast warning.
7631 (Fdefvar): Rename locals to avoid shadowing.
7633 * callint.c (quotify_arg, quotify_args): Now static.
7634 (Fcall_interactively): Rename locals to avoid shadowing.
7635 Use const pointer when appropriate.
7637 * lisp.h (get_system_name, get_operating_system_release):
7638 Move decls here, to check interfaces.
7639 * process.c (get_operating_system_release): Move decl to lisp.h.
7640 * xrdb.c (get_system_name): Likewise.
7641 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7642 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7643 some of which prompt warnings from gcc -Wbad-function-cast.
7644 (Fformat_time_string, Fencode_time, Finsert_char):
7645 (Ftranslate_region_internal, Fformat):
7646 Rename or remove local vars to avoid shadowing.
7647 (Ftranslate_region_internal): Mark var as initialized.
7649 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7652 * lisp.h (eassert): Check that the argument compiles, even if
7653 ENABLE_CHECKING is not defined.
7655 * data.c (Findirect_variable): Name an expression, to avoid
7656 gcc -Wbad-function-cast warning.
7657 (default_value, arithcompare, arith_driver, arith_error): Now static.
7658 (store_symval_forwarding): Rename local to avoid shadowing.
7659 (Fmake_variable_buffer_local, Fmake_local_variable):
7660 Mark variables as initialized.
7661 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7663 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7664 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7665 Rename locals to avoid shadowing.
7666 (mark_stack): Move local variables into the #ifdef region where
7668 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7669 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7671 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7672 (GC_STRING_CHARS): Remove; not used.
7673 (Fmemory_limit): Cast sbrk's returned value to char *.
7675 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7676 avoids undefined behavior in theory.
7678 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7680 Use functions, not macros, for up- and down-casing (Bug#8254).
7681 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7682 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7683 to use the following functions instead of these macros.
7684 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7685 EMACS_INT, since callers assume the returned value fits in int.
7686 (upcase1): Likewise, for UPCASE_TABLE.
7687 (uppercasep, lowercasep, upcase): New static inline functions.
7688 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7689 the race-condition problem in the old DOWNCASE.
7691 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7692 Rename locals to avoid shadowing.
7693 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7694 (regex_compile, re_search_2, re_match_2_internal):
7695 Remove unused local vars.
7696 (FREE_VAR): Rewrite so as not to use empty "else",
7697 which gcc can warn about.
7698 (regex_compile, re_match_2_internal): Mark locals as initialized.
7699 (RETALLOC_IF): Define only if needed.
7700 (WORDCHAR_P): Likewise. This one is never needed, but is used
7701 only in a comment talking about a compiler bug, so put inside
7702 the #if 0 of that comment.
7703 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7704 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7707 * search.c (boyer_moore): Rename locals to avoid shadowing.
7708 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7709 (PREV_CHAR_BOUNDARY): Likewise.
7711 * search.c (simple_search): Remove unused var.
7713 * dired.c (compile_pattern): Move decl from here ...
7714 * lisp.h: ... to here, so that it can be checked.
7715 (struct re_registers): New forward decl.
7717 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7719 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7721 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7722 Rename locals to avoid shadowing.
7723 (Fvertical_motion): Mark locals as initialized.
7725 * casefiddle.c (casify_object, casify_region): Now static.
7726 (casify_region): Mark local as initialized.
7728 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7730 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7731 New macros, so that the caller can use some names other than
7732 gcpro1, gcpro2, etc.
7733 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7735 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7736 argument, for consistency with GCPRO2_VAR, etc: it is now the
7737 prefix of the variable, not the variable itself. All uses
7739 * dired.c (directory_files_internal, file_name_completion):
7740 Rename locals to avoid shadowing.
7742 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7743 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7744 dired.c's scmp function, had undefined behavior.
7745 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7746 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7747 * buffer.h: ... to here, because these macros use current_buffer,
7748 and the new implementation with inline functions needs to have
7749 current_buffer in scope now, rather than later when the macros
7751 (downcase, upcase1): New static inline functions.
7752 (DOWNCASE, UPCASE1): Reimplement using these functions.
7753 This avoids undefined behavior in expressions like
7754 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7755 from race conditions in accessing the global variables
7756 case_temp1 and case_temp2.
7757 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7758 * lisp.h (case_temp1, case_temp2): Remove their decls.
7759 * character.h (ASCII_CHAR_P): Move from here ...
7760 * lisp.h: ... to here, so that the inline functions mentioned
7763 * dired.c (directory_files_internal_unwind): Now static.
7765 * fileio.c (file_name_as_directory, directory_file_name):
7766 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7768 (file_name_as_directory): Use const pointers when appropriate.
7769 (Fexpand_file_name): Likewise. In particular, newdir might
7770 point at constant storage, so make it a const pointer.
7771 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7772 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7774 (Fset_file_times, Finsert_file_contents, auto_save_error):
7775 Rename locals to avoid shadowing.
7777 * minibuf.c (choose_minibuf_frame_1): Now static.
7778 (Ftry_completion, Fall_completions): Rename or remove locals
7781 * marker.c (bytepos_to_charpos): Remove; unused.
7783 * lisp.h (verify_bytepos, count_markers): New decls,
7784 so that gcc does not warn that these functions aren't declared.
7786 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7787 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7788 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7789 (copy_text): Remove unused local var.
7791 * filelock.c (within_one_second): Now static.
7792 (lock_file_1): Rename local to avoid shadowing.
7794 * buffer.c (fix_overlays_before): Mark locals as initialized.
7795 (fix_start_end_in_overlays): Likewise. This function should be
7796 simplified by using pointers-to-pointers, but that's a different
7798 (switch_to_buffer_1): Now static.
7799 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7800 (report_overlay_modification): Rename locals to avoid shadowing.
7802 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7803 Fix pointer signedness issue.
7804 (sys_subshell): Mark local as volatile if checking for lint,
7805 to suppress a gcc -Wclobbered warning that does not seem to be right.
7806 (MAXPATHLEN): Define only if needed.
7808 * process.c (serial_open, serial_configure): Move decls from here ...
7809 * systty.h: ... to here, so that they can be checked.
7811 * fns.c (get_random, seed_random): Move extern decls from here ...
7812 * lisp.h: ... to here, so that they can be checked.
7814 * sysdep.c (reset_io): Now static.
7815 (wait_for_termination_signal): Remove; unused.
7817 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7818 (copy_keymap_item, append_key, push_text_char_description):
7820 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7821 (DENSE_TABLE_SIZE): Remove; unused.
7822 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7823 (describe_map_tree):
7824 Rename locals to avoid shadowing.
7826 * keyboard.c: Declare functions static if they are not used elsewhere.
7827 (echo_char, echo_dash, cmd_error, top_level_2):
7828 (poll_for_input, handle_async_input): Now static.
7829 (read_char, kbd_buffer_get_event, make_lispy_position):
7830 (make_lispy_event, make_lispy_movement, apply_modifiers):
7831 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7832 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7833 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7834 (read_key_sequence, read_char): Mark locals as initialized.
7835 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7837 * keyboard.h (make_ctrl_char): New decl.
7838 (mark_kboards): Move decl here ...
7839 * alloc.c (mark_kboards): ... from here.
7841 * lisp.h (force_auto_save_soon): New decl.
7843 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7844 (DEFINE_DUMMY_FUNCTION): New macro.
7845 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7847 (main): Add casts to avoid warnings
7848 if GCC considers string literals to be constants.
7850 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7852 * dbusbind.c: Pointer signedness fixes.
7853 (xd_signature, xd_append_arg, xd_initialize):
7854 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7855 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7856 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7857 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7859 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7860 if GCC considers string literals to be constants.
7861 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7863 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7865 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7866 (print_preprocess, print_object): New macro to fix last change.
7868 * print.c (print_preprocess): Don't forget font objects.
7870 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7872 * emacs.c (USAGE3): Doc fixes.
7874 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7876 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7879 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7881 * lisp.h (VWindow_system, Qfile_name_history):
7882 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7883 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7884 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7886 * w32select.c: Don't #include "keyboard.h".
7887 (run_protected): Add extern declaration for waiting_for_input.
7889 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7890 * w32console.c (detect_input_pending, read_input_pending)
7891 (encode_terminal_code):
7892 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7893 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7894 (w32_system_caret_y, Qfile_name_history):
7895 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7896 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7897 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7898 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7899 * w32proc.c (Qlocal, report_file_error):
7900 * w32term.c (Vwindow_system, updating_frame):
7901 * w32uniscribe.c (initialized, uniscribe_font_driver):
7902 Remove unneeded extern declarations.
7904 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7906 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7908 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7910 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7911 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7912 These macros can no longer be used for assignment.
7914 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7915 Assign struct members directly, instead of using BUF_BEGV etc.
7916 (record_buffer_markers, fetch_buffer_markers): New functions for
7917 recording and fetching special buffer markers.
7918 (set_buffer_internal_1, set_buffer_temp): Use them.
7920 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7922 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7924 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7925 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7927 * xdisp.c (hscroll_window_tree):
7928 (reconsider_clip_changes): Use PT instead of BUF_PT.
7930 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7932 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7933 $(EMACS_ROOT)/lib/intprops.h.
7935 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7937 Fix more problems found by GCC 4.5.2's static checks.
7939 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7940 to unsigned char * to avoid compiler diagnostic.
7941 (xg_free_frame_widgets): Make it clear that a local variable is
7942 needed only if USE_GTK_TOOLTIP.
7943 (gdk_window_get_screen): Make it clear that this macro is needed
7944 only if USE_GTK_TOOLTIP.
7945 (int_gtk_range_get_value): New function, which avoids a diagnostic
7946 from gcc -Wbad-function-cast.
7947 (xg_set_toolkit_scroll_bar_thumb): Use it.
7948 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7949 diagnostic from gcc -Wbad-function-cast.
7950 (get_utf8_string, xg_get_file_with_chooser):
7951 Rename locals to avoid shadowing.
7952 (create_dialog): Move locals to avoid shadowing.
7954 * xgselect.c (xg_select): Remove unused var.
7956 * image.c (four_corners_best): Mark locals as initialized.
7957 (gif_load): Initialize transparent_p to zero (Bug#8238).
7958 Mark another local as initialized.
7959 (my_png_error, my_error_exit): Mark with NO_RETURN.
7961 * image.c (clear_image_cache): Now static.
7962 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7963 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7964 (x_edge_detection): Remove unnecessary cast that
7965 gcc -Wbad-function-cast diagnoses.
7966 (gif_load): Fix pointer signedness.
7967 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7968 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7970 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7972 Improve quality of tests for time stamp overflow.
7973 For example, without this patch (encode-time 0 0 0 1 1
7974 1152921504606846976) returns the obviously-bogus value (-948597
7975 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7976 reports time overflow. See
7977 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7978 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7979 * editfns.c: Include limits.h and intprops.h.
7980 (TIME_T_MIN, TIME_T_MAX): New macros.
7981 (time_overflow): Move earlier, to before first use.
7982 (hi_time, lo_time): New functions, for an accurate test for
7984 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7985 (Fget_internal_run_time): Don't assume time_t fits in int.
7986 (make_time): Use list2 instead of Fcons twice.
7987 (Fdecode_time): More accurate test for out-of-range times.
7988 (check_tm_member): New function.
7989 (Fencode_time): Use it, to test for out-of-range times.
7990 (lisp_time_argument): Don't rely on undefined left-shift and
7991 right-shift behavior when checking for time stamp overflow.
7993 * editfns.c (time_overflow): New function, refactoring common code.
7994 (Fformat_time_string, Fdecode_time, Fencode_time):
7995 (Fcurrent_time_string): Use it.
7997 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7998 * dired.c (make_time): Move to ...
7999 * editfns.c (make_time): ... here.
8000 * systime.h: Note the move.
8002 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8004 * fringe.c (update_window_fringes): Remove unused variables.
8006 * unexmacosx.c (copy_data_segment): Also copy __got section.
8009 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8011 * termcap.c [MSDOS]: Include "msdos.h".
8012 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8013 Constify `char *' arguments and their references according to
8014 prototypes in tparam.h.
8016 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8018 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8019 Adapt all references accordingly.
8021 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8023 2011-03-11 Tom Tromey <tromey@redhat.com>
8025 * buffer.c (syms_of_buffer): Remove obsolete comment.
8027 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8029 * termhooks.h (encode_terminal_code): Declare prototype.
8031 * msdos.c (encode_terminal_code): Don't declare prototype.
8033 * term.c (encode_terminal_code): Now external again, used by
8034 w32console.c and msdos.c.
8036 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8037 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8039 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8041 Fix some minor problems found by GCC 4.5.2's static checks.
8043 * fringe.c (update_window_fringes): Mark locals as initialized
8045 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8047 * alloc.c (mark_fringe_data): Move decl from here ...
8048 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8049 to check its interface.
8050 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8052 * fontset.c (free_realized_fontset): Now static.
8053 (Fset_fontset_font): Rename local to avoid shadowing.
8054 (fontset_font): Mark local as initialized.
8055 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8057 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8059 * xselect.c (x_disown_buffer_selections): Remove; not used.
8060 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8061 (x_own_selection, Fx_disown_selection_internal): Rename locals
8063 (x_handle_dnd_message): Remove local to avoid shadowing.
8065 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8066 so that the caller can use some name other than gcpro1.
8067 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8068 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8069 (Fx_backspace_delete_keys_p):
8070 Use them to avoid shadowing, and rename vars to avoid shadowing.
8071 (x_decode_color, x_set_name, x_window): Now static.
8072 (Fx_create_frame): Add braces to silence GCC warning.
8073 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8074 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8075 Remove unused locals.
8076 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8077 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8078 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8081 * xterm.h (x_mouse_leave): New decl.
8083 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8084 Remove unused functions.
8085 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8086 (x_calc_absolute_position): Now static.
8087 (XTread_socket): Don't define label "out" unless it's used.
8088 Don't declare local "event" unless it's used.
8089 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8090 unless they are used.
8091 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8092 (x_fatal_error_signal): Remove; not used.
8093 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8094 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8095 (x_error_catcher, x_connection_closed, x_error_handler):
8096 (x_error_quitter, xembed_send_message, x_iconify_frame):
8097 (my_log_handler): Rename locals to avoid shadowing.
8098 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8099 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8101 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8102 Rename or move locals to avoid shadowing.
8103 (tty_defined_color, merge_face_heights): Now static.
8104 (free_realized_faces_for_fontset): Remove; not used.
8105 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8106 does not deduce is never used uninitialized.
8107 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8108 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8110 * terminal.c (store_terminal_param): Now static.
8112 * xmenu.c (menu_highlight_callback): Now static.
8113 (set_frame_menubar): Remove unused local.
8114 (xmenu_show): Rename parameter to avoid shadowing.
8115 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8116 since they might point to immutable storage.
8117 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8118 since it's unused otherwise.
8120 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8121 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8122 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8123 avoids a gcc -Wuninitialized diagnostic.
8124 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8125 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8126 does not deduce are never used uninitialized.
8128 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8130 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8131 * window.c (window_loop, size_window):
8132 (run_window_configuration_change_hook, enlarge_window): Likewise.
8134 * window.c (display_buffer): Now static.
8135 (size_window): Mark variables that gcc -Wuninitialized
8136 does not deduce are never used uninitialized.
8137 * window.h (check_all_windows): New decl, to forestall
8138 gcc -Wmissing-prototypes diagnostic.
8139 * dispextern.h (bidi_dump_cached_states): Likewise.
8141 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8143 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8145 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8146 and to avoid gcc -Wuninitialized warning.
8147 (load_charset_map): Mark variables that gcc -Wuninitialized
8148 does not deduce are never used uninitialized.
8149 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8151 * coding.c (coding_set_source, coding_set_destination):
8152 Use "else { /* comment */ }" rather than "else /* comment */;"
8153 for clarity, and to avoid gcc -Wempty-body warning.
8154 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8155 a block, when the outer 'i' will do.
8156 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8157 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8158 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8159 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8160 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8161 Rename locals to avoid shadowing.
8162 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8163 * coding.c (emacs_mule_char, encode_invocation_designation):
8164 Now static, since they're not used elsewhere.
8165 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8166 (decode_coding_object, encode_coding_object, detect_coding_system):
8167 (decode_coding_emacs_mule): Mark variables that gcc
8168 -Wuninitialized does not deduce are never used uninitialized.
8169 (detect_coding_iso_2022): Initialize a local variable that might
8170 be used uninitialized. Leave a FIXME because it's not clear that
8171 this initialization is needed. (Bug#8211)
8172 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8173 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8174 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8175 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8176 Remove unused macros.
8178 * category.c (hash_get_category_set): Remove unused local var.
8179 (copy_category_table): Now static, since it's not used elsewhere.
8180 * character.c (string_count_byte8): Likewise.
8182 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8183 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8185 * chartab.c (copy_sub_char_table): Now static, since it's not used
8187 (sub_char_table_ref_and_range, char_table_ref_and_range):
8188 Rename locals to avoid shadowing.
8189 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8191 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8192 (BIDI_BOB): Remove unused macro.
8194 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8195 deduce are never used uninitialized.
8196 * term.c (encode_terminal_code): Likewise.
8198 * term.c (encode_terminal_code): Now static. Remove unused local.
8200 * tparam.h: New file.
8201 * term.c, tparam.h: Include it.
8202 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8203 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8204 Move these decls to tparam.h, and make them agree with what
8205 is actually in tparam.c. The previous trick of using incompatible
8206 decls in different modules does not conform to the C standard.
8207 All callers of tparam changed to use tparam's actual API.
8208 * tparam.c (tparam1, tparam, tgoto):
8209 Use const pointers where appropriate.
8211 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8212 * cm.h (struct cm): Likewise.
8213 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8214 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8215 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8216 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8217 (turn_on_face, init_tty): Likewise.
8218 * termchar.h (struct tty_display_info): Likewise.
8220 * term.c (term_mouse_position): Rename local to avoid shadowing.
8222 * alloc.c (mark_ttys): Move decl from here ...
8223 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8225 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8227 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8229 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8231 * search.c (compile_pattern_1): Remove argument regp, unused since
8232 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8233 (compile_pattern): Don't pass it.
8235 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8237 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8238 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8240 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8242 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8244 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8245 gdk_window_get_screen, gdk_window_get_geometry,
8246 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8247 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8248 (xg_get_pixbuf_from_pixmap): New function.
8249 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8250 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8251 Call xg_get_pixbuf_from_pixmap instead of
8252 gdk_pixbuf_get_from_drawable.
8253 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8254 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8255 (xg_check_special_colors): Use GtkStyleContext and its functions
8257 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8258 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8259 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8260 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8261 Call gtk_widget_get_preferred_size.
8262 (xg_frame_resized): gdk_window_get_geometry only takes 5
8264 (xg_win_to_widget, xg_event_is_for_menubar):
8265 Call gdk_x11_window_lookup_for_display.
8266 (xg_set_widget_bg): New function.
8267 (delete_cb): New function.
8268 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8269 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8270 (xg_set_background_color): Call xg_set_widget_bg.
8271 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8272 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8273 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8274 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8276 (update_frame_tool_bar): Call gtk_widget_hide.
8277 (xg_initialize): Use GDK_KEY_g.
8279 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8281 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8283 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8284 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8285 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8287 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8289 * w32xfns.c (select_palette): Check success of RealizePalette against
8290 GDI_ERROR, not zero.
8292 See ChangeLog.11 for earlier changes.
8298 Copyright (C) 2011 Free Software Foundation, Inc.
8300 This file is part of GNU Emacs.
8302 GNU Emacs is free software: you can redistribute it and/or modify
8303 it under the terms of the GNU General Public License as published by
8304 the Free Software Foundation, either version 3 of the License, or
8305 (at your option) any later version.
8307 GNU Emacs is distributed in the hope that it will be useful,
8308 but WITHOUT ANY WARRANTY; without even the implied warranty of
8309 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8310 GNU General Public License for more details.
8312 You should have received a copy of the GNU General Public License
8313 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.