1 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3 sprintf-related integer and memory overflow issues (Bug#9412).
5 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6 (esprintf, exprintf, evxprintf): New functions.
7 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
8 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
9 (modify_event_symbol): Do not assume that the length of
10 name_alist_or_stem is safe to alloca and fits in int.
11 (Fexecute_extended_command): Likewise for function name and binding.
12 (Frecursion_depth): Wrap around reliably on integer overflow.
13 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
14 since some callers pass EMACS_INT values.
15 (Fsingle_key_description): Don't crash if symbol name contains more
16 than MAX_ALLOCA bytes.
17 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
18 (get_minibuffer): Arg is now EMACS_INT, not int.
19 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
20 (esprintf, exprintf, evxprintf): New decls.
21 * window.h (command_loop_level, minibuf_level): Reflect API changes.
23 * dbusbind.c (signature_cat): New function.
24 (xd_signature, Fdbus_register_signal):
25 Do not overrun buffer; instead, report string overflow.
27 * dispnew.c (add_window_display_history): Don't overrun buffer.
28 Truncate instead; this is OK since it's just a log.
30 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
31 even if the time zone offset is outlandishly large.
32 Don't mishandle offset == INT_MIN.
34 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
35 when creating daemon; the previous buffer-overflow check was incorrect.
37 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
38 which has the guts of the old verror function.
40 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
41 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
43 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
44 (font_unparse_xlfd): Don't blindly alloca long strings.
45 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
46 fits in int, when using sprintf. Use single snprintf to count
47 length of string rather than counting it via multiple sprintfs;
48 that's simpler and more reliable.
49 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
50 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
51 sprintf, in case result does not fit in int.
53 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
54 (fontset_from_font): Print it.
56 * frame.c (tty_frame_count): Now printmax_t, not int.
57 (make_terminal_frame, set_term_frame_name): Print it.
58 (x_report_frame_params): In X, window IDs are unsigned long,
59 not signed long, so print them as unsigned.
60 (validate_x_resource_name): Check for implausibly long names,
61 and don't assume name length fits in 'int'.
62 (x_get_resource_string): Don't blindly alloca invocation name;
63 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
66 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
67 (xg_check_special_colors, xg_set_geometry):
68 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
70 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
71 Use esprintf, not sprintf, in case result does not fit in int.
73 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
74 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
75 it as a large positive number.
76 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
77 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
79 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
80 in case result does not fit in int.
82 * print.c (float_to_string): Detect width overflow more reliably.
83 (print_object): Make sprintf buffer a bit bigger, to avoid potential
84 buffer overrun. Don't assume list length fits in 'int'. Treat
85 print length of 0 as 0, not as infinity; to be consistent with other
86 uses of print length in this function. Don't overflow print length
87 index. Don't assume hash table size fits in 'long', or that
88 vectorlike size fits in 'unsigned long'.
90 * process.c (make_process): Use printmax_t, not int, to format
93 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
95 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
96 to avoid potential buffer overrun.
98 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
99 if X resource line is longer than 512 bytes.
101 * xfns.c (x_window): Make sprintf buffer a bit bigger
102 to avoid potential buffer overrun.
104 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
106 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
108 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
110 Integer overflow fixes for scrolling, etc.
111 Without these, Emacs silently mishandles large integers sometimes.
112 For example, "C-u 4294967297 M-x recenter" was treated as if
113 it were "C-u 1 M-x recenter" on a typical 64-bit host.
115 * xdisp.c (try_window_id): Check Emacs fixnum range before
118 * window.c (window_scroll_line_based, Frecenter):
119 Check that an Emacs fixnum is in range before assigning it to 'int'.
120 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
121 values converted from Emacs fixnums.
122 (Frecenter): Don't wrap around a line count if it is out of 'int'
123 range; instead, treat it as an extreme value.
124 (Fset_window_configuration, compare_window_configurations):
125 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
127 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
128 that can exceed INT_MAX. Check that EMACS_INT value is in range
129 before assigning it to the (possibly-narrower) index.
130 (match_limit): Don't assume that a fixnum can fit in 'int'.
132 * print.c (print_object): Use ptrdiff_t, not int, for index that can
135 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
136 (Fvertical_motion): Don't wrap around LINES values that don't fit
137 in 'int'. Instead, treat them as extreme values. This is good
138 enough for windows, which can't have more than INT_MAX lines anyway.
140 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
142 * Require libxml/parser.h to avoid compilation warning.
144 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
146 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
147 since this reportedly can destroy thread storage.
149 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
151 * syntax.c (find_defun_start): Update all cache variables if
152 exiting early (Bug#9401).
154 2011-08-30 Eli Zaretskii <eliz@gnu.org>
156 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
158 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
159 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
160 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
162 * term.c (tty_append_glyph): New function.
163 (produce_stretch_glyph): Static function and its prototype deleted.
165 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
168 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
170 * image.c (parse_image_spec): Check for nonnegative, not for positive,
171 when checking :margin (Bug#9390).
172 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
173 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
174 so that the name doesn't mislead. All uses changed.
176 2011-08-28 Johan Bockgård <bojohan@gnu.org>
178 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
181 2011-08-27 Eli Zaretskii <eliz@gnu.org>
183 * xdisp.c (move_it_to): Don't bail out early when reaching
184 position beyond to_charpos, if we are scanning backwards.
185 (move_it_vertically_backward): When DY == 0, make sure we get to
186 the first character in the line after the newline.
188 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
190 * ccl.c: Improve and simplify overflow checking (Bug#9196).
191 (ccl_driver): Do not generate an out-of-range pointer.
192 (Fccl_execute_on_string): Remove unnecessary check for
193 integer overflow, noted by Stefan Monnier in
194 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
195 Remove a FIXME that didn't need fixing.
196 Simplify the newly-introduced buffer reallocation code.
198 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
200 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
202 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
204 Integer and memory overflow issues (Bug#9196).
206 * doc.c (get_doc_string): Rework so that
207 get_doc_string_buffer_size is the actual buffer size, rather than
208 being 1 less than the actual buffer size; this makes xpalloc more
211 * image.c (x_allocate_bitmap_record, cache_image):
212 * xselect.c (Fx_register_dnd_atom):
213 Simplify previous changes by using xpalloc.
215 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
216 since either will do and ptrdiff_t is convenient with xpalloc.
218 * charset.c (charset_table_size)
219 (struct charset_sort_data.priority): Now ptrdiff_t.
220 (charset_compare): Don't overflow if priorities differ greatly.
221 (Fsort_charsets): Don't assume list length fits in int.
222 Check for size-calculation overflow when allocating sort data.
223 (syms_of_charset): Allocate an initial charset table that is
224 just under 64 KiB, to avoid problems with glibc malloc and mmap.
226 * cmds.c (internal_self_insert): Check for size-calculation overflow.
228 * composite.h (struct composition.glyph_len): Now int, not unsigned.
229 The actual value is always <= INT_MAX, and leaving it unsigned made
230 overflow checking harder.
232 * dispextern.h (struct glyph_matrix.rows_allocated)
233 (struct face_cache.size): Now ptrdiff_t, for convenience in use
234 with xpalloc. The values are still always <= INT_MAX.
236 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
238 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
239 (SAFE_NALLOCA): New macro.
241 * region-cache.c (struct boundary.pos, find_cache_boundary)
242 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
243 (set_cache_region, invalidate_region_cache)
244 (revalidate_region_cache, know_region_cache, region_cache_forward)
245 (region_cache_backward, pp_cache):
246 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
247 so that ptrdiff_t * can be passed to xpalloc.
248 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
249 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
250 (pp_cache): Don't assume cache_len fits in int.
251 * region-cache.h: Adjust extern decls to match.
253 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
254 EMACS_INT, since either will do, for xpalloc.
256 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
257 (xnmalloc, xnrealloc, xpalloc): New functions.
259 * bidi.c (bidi_shelve_header_size): New constant.
260 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
261 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
263 * bidi.c (bidi_cache_shrink):
264 * buffer.c (overlays_at, overlays_in, record_overlay_string)
266 Don't update size of array until after memory allocation succeeds,
267 because xmalloc/xrealloc may not return.
268 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
269 now that we have proper integer overflow checking.
270 (record_overlay_string, overlay_strings): Catch overflows when
271 calculating size of overlay_str_buf.
273 * callproc.c (Fcall_process): Check for size overflow when
274 calculating size of args2.
275 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
276 Normally we prefer signed values, but sticking with ptrdiff_t would
277 require adding more-complicated checks.
279 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
280 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
281 Redo buffer-overflow calculations to avoid integer overflow.
282 Add a FIXME comment where memory seems to be over-allocated.
284 * character.c (Fstring): Check for size-calculation overflow.
286 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
287 unnecessary integer overflow. Check for size overflow.
288 (encode_coding_object): Don't update size until xmalloc succeeds.
290 * composite.c (get_composition_id): Check for overflow in glyph
293 Integer and memory overflow fixes for display code.
294 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
295 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
296 (scrolling_window): Check for overflow in size calculations.
297 (line_draw_cost, realloc_glyph_pool, add_row_entry):
298 Don't assume glyph table len fits in int.
299 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
300 (row_table_size): Now ptrdiff_t, not int.
301 (scrolling_window): Avoid overflow in size calculations.
302 Don't update size until allocation succeeds.
303 * fns.c (concat): Check for overflow in size calculations.
304 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
305 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
306 (NEXT_ALMOST_PRIME_LIMIT): New constant.
308 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
309 (get_doc_string): Check for size calculation overflow.
310 Don't update size until allocation succeeds.
311 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
312 EMACS_INT, where ptrdiff_t will do.
313 (Fsubstitute_command_keys): Check for string overflow.
315 * editfns.c (set_time_zone_rule): Don't assume environment length
317 (message_length): Now ptrdiff_t, not int.
318 (Fmessage_box): Don't update size until allocation succeeds.
319 Don't assume message length fits in int.
320 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
322 * emacs.c (main): Do not reallocate argv, since there is a null at
323 the end that can be overwritten, and this way there's no need to
324 worry about size-calculation overflow.
325 (sort_args): Check for size-calculation overflow.
327 * eval.c (init_eval_once, grow_specpdl): Don't update size until
329 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
331 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
332 (x_set_scroll_bar_width, x_figure_window_size):
333 Check for integer overflow.
334 (x_set_alpha): Do not assume XINT fits in int.
336 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
337 This is for the members text_lines, text_cols, total_lines, total_cols,
338 where the system imposes an 'int' limit.
340 * fringe.c (Fdefine_fringe_bitmap):
341 Don't update size until alloc works.
343 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
344 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
346 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
347 Check for size-calculation overflow.
348 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
349 do, as we prefer signed integers.
350 (id_to_widget.max_size, id_to_widget.used)
351 (xg_store_widget_in_map, xg_remove_widget_from_map)
352 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
353 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
354 Use and return ptrdiff_t, not int.
355 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
356 * gtkutil.h: Change prototypes to match the above.
358 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
359 are duplicate now that they've been promoted to lisp.h.
360 (x_allocate_bitmap_record, x_alloc_image_color)
361 (make_image_cache, cache_image, xpm_load):
362 Don't update size until alloc is done.
363 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
365 Check for size calculation overflow.
366 (ct_colors_allocated_max): New constant.
367 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
370 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
371 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
372 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
373 Use ptrdiff_t, not int, to count maps.
374 (read_char_minibuf_menu_prompt): Check for overflow in size
375 calculations. Don't update size until allocation succeeds. Redo
376 calculations to avoid overflow.
377 * keyboard.h: Change prototypes to match the above.
379 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
381 (current_minor_maps): Check for size calculation overflow.
382 * keymap.h: Change prototypes to match the above.
384 * lread.c (read1, init_obarray): Don't update size until alloc done.
386 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
387 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
389 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
390 Now ptrdiff_t, not int.
391 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
392 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
394 * process.c (Fnetwork_interface_list): Check for overflow
397 * region-cache.c (move_cache_gap): Check for size calculation overflow.
399 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
400 overflow. Don't bother calling xmalloc when xrealloc will do.
402 * search.c (Freplace_match): Check for size calculation overflow.
403 (Fset_match_data): Don't assume list lengths fit in 'int'.
405 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
406 for command line length. Do not attempt to address one before the
407 beginning of an array, as that's not portable.
409 * term.c (max_frame_lines): Remove; unused.
410 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
412 (encode_terminal_code, calculate_costs): Check for size
413 calculation overflow.
414 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
415 table lengths and related sizes. Don't update size until alloc
416 done. Redo calculations to avoid overflow.
417 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
419 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
420 subtracting pointers.
421 (gobble_line): Check for overflow more carefully. Don't update size
424 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
425 Don't update size until alloc done.
426 Redo size calculations to avoid overflow.
427 Check for size calculation overflow.
428 (main) [DEBUG]: Fix typo in invoking tparam1.
430 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
431 Use ptrdiff_t, not int, for sizes.
432 (store_mode_line_noprop_char): Don't update size until alloc done.
434 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
435 Use ptrdiff_t, not int, for sizes.
436 (Finternal_make_lisp_face, cache_face):
437 Check for size calculation overflow.
438 (cache_face): Treat size calculation overflows as if they were
439 memory exhaustion (the usual treatment), rather than aborting.
441 * xfns.c (x_encode_text, x_set_name_internal)
442 (Fx_change_window_property): Use ptrdiff_t, not int, to count
443 sizes, since they can exceed INT_MAX in size. Check for size
444 calculation overflow.
446 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
447 (xg_select): Check for size calculation overflow.
448 Don't update size until alloc done.
450 * xrdb.c (get_environ_db): Don't assume path length fits in int,
451 as sprintf is limited to int lengths.
453 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
454 (X_LONG_MIN): New macros.
455 Use them to make the following changes clearer.
456 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
457 This change doesn't affect the value now, but it may help remind
458 future maintainers not to raise the value too much later.
459 (SELECTION_QUANTUM): Remove, replacing with ...
460 (selection_quantum): ... new function, which avoids overflow.
462 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
463 assumption that selection length fits in 'int'.
464 (x_reply_selection_request, x_handle_selection_request)
465 (x_get_window_property, receive_incremental_selection)
466 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
467 (lisp_data_to_selection_data, clean_local_selection_data):
468 Use ptrdiff_t, not int, to record length of selection.
469 (x_reply_selection_request, x_get_window_property)
470 (receive_incremental_selection, x_property_data_to_lisp):
471 Redo calculations to avoid overflow.
472 (x_reply_selection_request): When sending hint, ceiling it at
473 X_LONG_MAX rather than relying on wraparound overflow to send
475 (x_get_window_property, receive_incremental_selection)
476 (lisp_data_to_selection_data, x_property_data_to_lisp):
477 Check for size-calculation overflow.
478 (x_get_window_property, receive_incremental_selection)
479 (lisp_data_to_selection_data, Fx_register_dnd_atom):
480 Don't store size until memory allocation succeeds.
481 (x_get_window_property): Plug memory leak on memory exhaustion.
482 Don't double-block input; malloc is safe here. Don't assume 2**34
483 - 4 fits in unsigned long. Add an xassert to check
484 XGetWindowProperty overflow. Be more careful about overflow
485 calculations, and distinguish size from memory overflow better.
486 (receive_incremental_selection): When tracing, don't assume
487 unsigned int is less than INT_MAX.
488 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
489 harmful) conversions of unsigned short to int.
490 (lisp_data_to_selection_data): Don't assume that integers
491 in the range -65535 through -1 fit in an X unsigned short.
492 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
493 result parameters unless successful. Rely on cons_to_unsigned
494 to report problems with elements; the old code wasn't right anyway.
495 (x_check_property_data): Check for int overflow; we cannot use
496 a wider type due to X limits.
497 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
499 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
501 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
502 (x_term_init): Check for size calculation overflow.
503 (x_color_cells): Don't store size until memory allocation succeeds.
504 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
505 Don't assume alloca size is less than MAX_ALLOCA.
506 (x_term_init): Don't assume length fits in int (sprintf is limited
509 Use ptrdiff_t for composition IDs.
510 * character.c (lisp_string_width):
511 * composite.c (composition_table_size, n_compositions)
512 (get_composition_id, composition_gstring_from_id):
513 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
514 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
515 * window.c (Frecenter):
516 Use ptrdiff_t, not int, for composition IDs.
517 * composite.c (get_composition_id): Check for integer overflow.
518 * composite.h: Adjust prototypes to match the above changes.
520 Use ptrdiff_t for hash table indexes.
521 * category.c (hash_get_category_set):
522 * ccl.c (ccl_driver):
523 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
524 * coding.c (coding_system_charset_list, detect_coding_system):
525 * coding.h (struct coding_system.id):
526 * composite.c (get_composition_id, gstring_lookup_cache):
527 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
528 * image.c (xpm_get_color_table_h):
529 * lisp.h (hash_lookup, hash_put):
530 * minibuf.c (Ftest_completion):
531 Use ptrdiff_t for hash table indexes, not int (which is too
532 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
533 32-bit --with-wide-int hosts).
535 * charset.c (Fdefine_charset_internal): Check for integer overflow.
536 Add a FIXME comment about memory leaks.
537 (syms_of_charset): Don't assume xmalloc returns.
539 Don't assume that stated character widths fit in int.
540 * character.c (Fchar_width, c_string_width, lisp_string_width):
541 * character.h (CHAR_WIDTH):
542 * indent.c (MULTIBYTE_BYTES_WIDTH):
543 Use sanitize_char_width to avoid undefined and/or bad behavior
544 with outlandish widths.
545 * character.h (sanitize_tab_width): Renamed from sanitize_width,
546 now that we have two such functions. All uses changed.
547 (sanitize_char_width): New inline function.
549 Don't assume that tab-width fits in int.
550 * character.h (sanitize_width): New inline function.
551 (SANE_TAB_WIDTH): New macro.
552 (ASCII_CHAR_WIDTH): Use it.
553 * indent.c (sane_tab_width): Remove. All uses replaced by
554 SANE_TAB_WIDTH (current_buffer).
555 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
557 * fileio.c: Integer overflow issues with file modes.
558 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
560 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
561 Remove unreachable code.
562 (read_hex, load_charset_map_from_file): Check for integer overflow.
564 * xterm.c: don't go over XClientMessageEvent limit
565 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
566 (x_send_scroll_bar_event): Likewise. Check that the size does not
567 exceed limits imposed by XClientMessageEvent, as well as the usual
568 ptrdiff_t and size_t limits.
570 * keyboard.c: Overflow, signedness and related fixes.
571 (make_lispy_movement): Use same integer type in forward decl
572 that is used in the definition.
573 (read_key_sequence, keyremap_step):
574 Change bufsize argument back to int, undoing my 2011-03-30 change.
575 We prefer signed types, and int is wide enough here.
576 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
577 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
578 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
579 length, not size_t. Use ptrdiff_t for index, not int.
580 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
581 possibility of integer overflow.
583 Overflow, signedness and related fixes for images.
585 * dispextern.h (struct it.stack[0].u.image.image_id)
586 (struct_it.image_id, struct image.id, struct image_cache.size)
587 (struct image_cache.used, struct image_cache.ref_count):
588 * gtkutil.c (update_frame_tool_bar):
589 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
590 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
591 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
592 * nsmenu.m (update_frame_tool_bar):
593 * xdisp.c (calc_pixel_width_or_height):
594 * xfns.c (image_cache_refcount):
595 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
596 on typical 64-bit hosts.
598 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
599 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
600 Omit unnecessary casts to int.
601 (parse_image_spec): Check that integers fall into 'int' range
602 when the callers expect that.
603 (image_ascent): Redo ascent calculation to avoid int overflow.
604 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
605 (lookup_image): Remove unnecessary tests.
606 (xbm_image_p): Locals are now of int, not EMACS_INT,
607 since parse_image_check makes sure they fit into int.
608 (png_load, gif_load, svg_load_image):
609 Prefer int to unsigned where either will do.
610 (tiff_handler): New function, combining the cores of the
611 old tiff_error_handler and tiff_warning_handler. This
612 function is rewritten to use vsnprintf and thereby avoid
613 stack buffer overflows. It uses only the features of vsnprintf
614 that are common to both POSIX and native Microsoft.
615 (tiff_error_handler, tiff_warning_handler): Use it.
616 (tiff_load, gif_load, imagemagick_load_image):
617 Don't assume :index value fits in 'int'.
618 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
619 (imagemagick_load_image): Check that crop parameters fit into
620 the integer types that MagickCropImage accepts. Don't assume
621 Vimagemagick_render_type has a nonnegative value. Don't assume
622 size_t fits in 'long'.
623 (gs_load): Use printmax_t to print the widest integers possible.
624 Check for integer overflow when computing image height and width.
626 2011-08-26 Eli Zaretskii <eliz@gnu.org>
628 * xdisp.c (redisplay_window): Don't force window start if point
629 will be invisible in the resulting window. (Bug#9324)
631 2011-08-25 Eli Zaretskii <eliz@gnu.org>
633 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
634 the display spec is of the form `(space ...)'.
635 (handle_display_spec): Return the value returned by
636 handle_single_display_spec, not just 1 or zero.
637 (handle_single_display_spec): If the display spec is of the form
638 `(space ...)', and specifies display in the text area, return 2
640 (try_cursor_movement): Check for the need to scroll more
641 accurately, and prefer exact match for point under bidi. Don't
642 advance `row' beyond the last row of the window.
644 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
645 into disp_prop; all users changed.
647 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
648 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
649 for the text covered by the display property.
651 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
653 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
654 Change return value to nil.
655 (Frecord_buffer): Delete unused function.
657 2011-08-24 Eli Zaretskii <eliz@gnu.org>
659 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
660 buffers, return left-to-right.
661 (set_cursor_from_row): Consider candidate row a win if its glyph
662 represents a newline and point is on that newline. Fixes cursor
663 positioning on the newline at EOL of R2L text within L2R
664 paragraph, and vice versa.
665 (try_cursor_movement): Check continued rows, in addition to
666 continuation rows. Fixes unwarranted scroll when point enters a
667 continued line of R2L text within an L2R paragraph, or vice versa.
668 (cursor_row_p): Consider the case of point being equal to
669 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
670 from the end of a short line to the beginning of a continued line
671 of R2L text within L2R paragraph.
672 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
675 * bidi.c (bidi_check_type): Use xassert.
676 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
679 2011-08-23 Eli Zaretskii <eliz@gnu.org>
681 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
684 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
686 * nsfont.m (ns_otf_to_script): Fix typo.
688 2011-08-22 Kenichi Handa <handa@m17n.org>
690 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
691 extra slot even if the purpose is char-code-property-table.
693 2011-08-23 Eli Zaretskii <eliz@gnu.org>
695 * xdisp.c (redisplay_window): When computing centering_position,
696 account for the height of the header line. (Bug#8874)
698 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
699 instead of CHAR_TO_BYTE. Fixes a crash when a completion
700 candidate is selected by the mouse, and that candidate has a
701 composed character under the mouse.
703 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
704 coordinates reported by pos-visible-in-window-p for a composed
705 character in column zero.
707 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
709 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
711 2011-08-22 Eli Zaretskii <eliz@gnu.org>
713 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
714 consider it a hit if to_charpos is anywhere in the range of the
715 composed buffer positions.
717 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
719 * image.c (gif_load): Don't assume that each subimage has the same
720 dimensions as the base image. Handle disposal method that is
721 "undefined" by the gif spec (Bug#9335).
723 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
725 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
726 (Fcondition_case): Document `debug' symbol in error handler.
728 2011-08-19 Eli Zaretskii <eliz@gnu.org>
730 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
731 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
732 from an Org mode buffer to a Speedbar frame.
734 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
735 a composition, take its buffer position from IT->cmp_it.charpos.
736 Fixes cursor positioning at the beginning of a line that begins
737 with a composed character.
739 2011-08-18 Eli Zaretskii <eliz@gnu.org>
741 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
742 character bidirectional type, use STRONG_L instead. Fixes crashes
743 in a buffer produced by `describe-categories'.
745 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
746 members before the level stack, so they would be saved and
747 restored when copying iterator state. Fixes incorrect reordering
748 around TABs covered by display properties.
750 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
752 * process.c (Fnetwork_interface_list): Correctly determine buffer
755 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
757 * eval.c (internal_condition_case, internal_condition_case_1)
758 (internal_condition_case_2, internal_condition_case_n):
759 Remove unnecessary aborts (Bug#9081).
761 2011-08-17 Eli Zaretskii <eliz@gnu.org>
763 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
764 has no `load' handler, try opening the file locally. (Bug#9311)
766 2011-08-16 Ken Brown <kbrown@cornell.edu>
768 * gmalloc.c: Expand comment.
770 2011-08-16 Eli Zaretskii <eliz@gnu.org>
772 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
773 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
775 2011-08-16 Ken Brown <kbrown@cornell.edu>
777 Fix memory allocation problems in Cygwin build (Bug#9273).
779 * unexcw.c ( __malloc_initialized): Declare external variable.
780 (fixup_executable): Force the dumped emacs to reinitialize malloc.
782 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
784 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
786 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
788 [CYGWIN] (special_realloc): New function.
789 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
790 requests to realloc storage in the static heap.
792 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
794 * bidi.c (bidi_initialize): Remove unused local.
796 2011-08-15 Eli Zaretskii <eliz@gnu.org>
798 * biditype.h: File removed.
800 * bidimirror.h: File removed.
802 * deps.mk (bidi.o): Remove biditype.h and
805 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
808 * dispextern.h: Fix a typo in the comment to bidi_type_t.
810 * chartab.c: Improve commentary for the uniprop_table API.
812 * bidi.c (bidi_paragraph_init): Support zero value of
813 bidi_ignore_explicit_marks_for_paragraph_level.
814 (bidi_initialize): Use uniprop_table instead of including
815 biditype.h and bidimirror.h.
817 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
818 coordinates of the iterator when restoring from ppos_it.
821 2011-08-14 Kenichi Handa <handa@m17n.org>
823 * process.c (create_process): Call setup_process_coding_systems
824 after the pid of the process is set to -1 (Bug#8162).
826 2011-08-14 Eli Zaretskii <eliz@gnu.org>
828 * xdisp.c (move_it_in_display_line_to): Don't invoke
829 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
830 ppos_it. Fixes vertical cursor motion when line beginning is
831 covered by an image. (Bug#9296)
833 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
835 * nsterm.h (ns_run_ascript): Declare.
836 (NSAPP_DATA2_RUNASSCRIPT): Define.
838 * nsfns.m (as_script, as_result, as_status): New static variables.
839 (ns_run_ascript): New function.
840 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
841 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
842 the event loop. Get status from as_status (Bug#7276).
844 * nsterm.m (sendEvent): If event is NSApplicationDefined and
845 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
846 the event loop (Bug#7276).
848 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
850 * gnutls.c (QCgnutls_bootprop_priority)
851 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
852 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
853 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
854 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
855 (QCgnutls_bootprop_verify_hostname_error)
856 (QCgnutls_bootprop_callbacks_verify): Rename from
857 Qgnutls_bootprop_..., all uses changed.
859 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
862 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
864 * xfaces.c (Qframe_set_background_mode): Now static.
865 * dispextern.h (Qframe_set_background_mode): Remove decl.
867 * process.c (Fnetwork_interface_info): Declare local only if needed.
869 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
871 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
872 (Fnetwork_interface_list): Allocate in increments of bytes instead
873 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
874 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
876 (struct ifflag_def): notrailers is smart on OSX.
877 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
878 Get hardware address with getifaddrs if available.
880 2011-08-12 Eli Zaretskii <eliz@gnu.org>
882 * xdisp.c (iterate_out_of_display_property): xassert that
883 IT->position is set to within IT->object's boundaries. Break from
884 the loop as soon as EOB is reached; avoids infloops in redisplay
885 when IT->position is set up wrongly due to some bug.
886 Set IT->current to match the bidi iterator unconditionally.
887 (push_display_prop): Allow GET_FROM_STRING as IT->method on
888 entry. Force push_it to save on the stack the current
889 buffer/string position, to be restored by pop_it. Fix flags in
890 the iterator structure wrt the object coming from a display
891 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
892 properties. (Bug#9284)
894 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
896 * fontset.c (fontset_get_font_group): Add proper type checks.
899 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
901 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
902 and LC_VERSION_MIN_MACOSX.
903 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
904 (dump_it) [LC_FUNCTION_STARTS]: Use it.
906 2011-08-08 Eli Zaretskii <eliz@gnu.org>
908 * xdisp.c (forward_to_next_line_start): Allow to use the
909 no-display-properties-and-no-overlays under bidi display.
910 Set disp_pos in the bidi iterator to avoid searches for display
911 properties and overlays.
913 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
915 * editfns.c (Fset_time_zone_rule): Document relationship with the
918 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
919 the font entity extracted from the cache (Bug#8109).
921 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
923 * composite.c (autocmp_chars): Don't reset point. That is done by
924 restore_point_unwind (Bug#5984).
926 2011-08-07 Juri Linkov <juri@jurta.org>
928 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
929 to show the arg `TIME' instead of `TIMEVAL'.
931 2011-08-06 Eli Zaretskii <eliz@gnu.org>
933 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
934 display property strides EOL and includes a newline, as in
935 longlines-mode. (Bug#9254)
936 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
937 word-wrap under bidirectional display. (Bug#9224)
939 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
940 is non-zero, even if the data buffer is NULL. Fixes a crash in
941 vertical-motion with longlines-mode. (Bug#9254)
943 2011-08-05 Eli Zaretskii <eliz@gnu.org>
945 * bidi.c <bidi_cache_total_alloc>: Now static.
946 (bidi_initialize): Initialize bidi_cache_total_alloc.
948 * xdisp.c (display_line): Release buffer allocated for shelved bidi
951 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
952 amount allocated this far in `bidi_cache_total_alloc'.
953 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
954 non-zero, only free the data buffer without restoring the cache
955 contents. All callers changed.
957 * dispextern.h (bidi_unshelve_cache): Update prototype.
959 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
960 (move_it_in_display_line, move_it_to)
961 (move_it_vertically_backward, move_it_by_lines): Replace the call
962 to xfree to an equivalent call to bidi_unshelve_cache.
963 (move_it_in_display_line_to): Fix logic of returning
964 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
966 2011-08-05 Eli Zaretskii <eliz@gnu.org>
968 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
969 came from a string character with a `cursor' property. (Bug#9229)
971 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
973 * Makefile.in (LIB_PTHREAD): New variable.
974 (LIBES): Add LIB_PTHREAD (Bug#9216).
976 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
977 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
979 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
981 * regex.c (re_iswctype): Remove some redundant boolean
984 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
986 * xterm.c (x_find_topmost_parent): New function.
987 (x_set_frame_alpha): Find topmost parent window with
988 x_find_topmost_parent and set the property there also (bug#9181).
989 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
991 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
993 * callproc.c (Fcall_process): Avoid vfork clobbering
994 the local vars buffer, coding_systems, current_dir.
996 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
998 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1000 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1002 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1003 so that it is not optimized away.
1005 * xdisp.c (compute_display_string_pos): Remove unused local.
1007 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1009 Fix slow cursor motion and scrolling in large buffers with
1010 selective display, like Org Mode buffers. (Bug#9218)
1012 * dispextern.h (struct bidi_it): New member disp_prop_p.
1014 * xdisp.c: Remove one-slot cache of display string positions.
1015 (compute_display_string_pos): Accept an additional argument
1016 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1017 for a display string or property. If found, set DISP_PROP_P
1020 * bidi.c (bidi_fetch_char): Accept an additional argument
1021 DISP_PROP_P, and pass it to compute_display_string_pos.
1022 Only handle text covered by a display string if DISP_PROP_P is returned
1023 non-zero. All callers of bidi_fetch_char changed.
1025 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1027 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1029 2010-12-03 Don March <don@ohspite.net>
1031 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1032 last character M-[char] is translated to ESC [char] (bug#7541).
1034 2011-08-02 Kenichi Handa <handa@m17n.org>
1036 * lisp.h (uniprop_table): Extern it.
1038 * chartab.c (uniprop_table): Make it non-static.
1040 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1042 * xdisp.c (forward_to_next_line_start): Accept additional argument
1043 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1045 (reseat_at_next_visible_line_start): Use the bidi iterator state
1046 returned by forward_to_next_line_start to restore the state of
1047 it->bidi_it after backing up to previous newline. (Bug#9212)
1049 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1051 * regex.c (re_comp): Protoize.
1052 (re_exec): Fix return type.
1053 (regexec): Fix type of `ret'. (Bug#9203)
1055 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
1057 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1058 This is needed if max-image-size is a floating-point number.
1060 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1062 * print.c (print_object): Print empty symbol as ##.
1064 * lread.c (read1): Read ## as empty symbol.
1066 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1068 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1069 setting frame foreground color (Bug#9175).
1070 (x_set_background_color): Likewise.
1072 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1073 contents (Bug#9176).
1074 (EmacsTooltip -init): Remove bezels and add shadows to
1077 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1078 or scroll bar (Bug#8470).
1080 * nsfont.m (nsfont_open): Remove assignment to voffset and
1081 unnecessary vars hshink, expand, hd, full_height, min_height.
1082 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1084 * nsterm.h (nsfont_info): Remove voffset field.
1086 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1088 Implement strike-through and overline on NextStep (Bug#8863).
1090 * nsfont.m (nsfont_open): Use underline position provided by font,
1091 instead of hard-coded value of 2.
1092 (nsfont_draw): Call ns_draw_text_decoration instead.
1094 * nsterm.h: Add declaration for ns_draw_text_decoration.
1096 * nsterm.m (ns_draw_text_decoration): New function for drawing
1097 underline, overline, and strike-through.
1098 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1099 ns_draw_text_decoration. Change treatment of cursor drawing to
1100 accomodate underlining, etc.
1102 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1104 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1107 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1109 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1110 Without this fix, if a signal arrives just after memory fills up,
1111 'malloc' might be invoked reentrantly.
1113 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1114 In other words, assume that every image size is allowed, on non-X
1115 hosts. This assumption is probably wrong, but it lets Emacs compile.
1117 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1119 * regex.c (re_iswctype): Convert return values to boolean.
1121 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1123 * xdisp.c (compute_display_string_pos): Don't use cached display
1124 string position if the buffer had its restriction changed.
1127 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1129 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1131 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1133 Integer signedness and overflow and related fixes. (Bug#9079)
1135 * bidi.c: Integer size and overflow fixes.
1136 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1137 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1138 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1139 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1140 (bidi_find_other_level_edge):
1141 Use ptrdiff_t instead of EMACS_INT where either will do.
1142 This works better on 32-bit hosts configured --with-wide-int.
1143 (bidi_cache_ensure_space): Check for size-calculation overflow.
1144 Use % rather than repeated addition, for better worst-case speed.
1145 Don't set bidi_cache_size until after xrealloc returns, because it
1147 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1148 (bidi_cache_ensure_space): Also check that the bidi cache size
1149 does not exceed that of the largest Lisp string or buffer. See Eli
1150 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1152 * alloc.c (__malloc_size_t): Remove.
1153 All uses replaced by size_t. See Andreas Schwab's note
1154 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1156 * image.c: Improve checking for integer overflow.
1157 (check_image_size): Assume that f is nonnull, since
1158 it is always nonnull in practice. This is one less thing to
1159 worry about when checking for integer overflow later.
1160 (x_check_image_size): New function, which checks for integer
1161 overflow issues inside X.
1162 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1163 This removes the need for a memory_full check.
1164 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1165 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1166 (xbm_read_bitmap_data): Change locals back to 'int', since
1167 their values must fit in 'int'.
1168 (xpm_load_image, png_load, tiff_load):
1169 Invoke x_create_x_image_and_pixmap earlier,
1170 to avoid much needless work if the image is too large.
1171 (tiff_load): Treat overly large images as if
1172 x_create_x_image_and_pixmap failed, not as malloc failures.
1173 (gs_load): Use x_check_image_size.
1175 * gtkutil.c: Omit integer casts.
1176 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1177 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1179 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1181 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1182 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1183 would wrongly return t on a 64-bit host.
1185 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1186 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1187 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1188 and therefore cause GCC to emit a bogus diagnostic in some cases.
1190 * image.c: Integer signedness and overflow and related fixes.
1191 This is not an exhaustive set of fixes, but it's time to
1192 record what I've got.
1193 (lookup_pixel_color, check_image_size): Remove redundant decls.
1194 (check_image_size): Don't assume that arbitrary EMACS_INT values
1195 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1196 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1197 (tiff_load, imagemagick_load_image):
1198 Check for overflow in size calculations.
1199 (x_create_x_image_and_pixmap): Remove unnecessary test for
1200 xmalloc returning NULL; that can't happen.
1201 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1202 (xpm_color_bucket): Use better integer hashing function.
1203 (xpm_cache_color): Don't possibly over-allocate memory.
1204 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1205 (gif_memory_source):
1206 Use ptrdiff_t, not int or size_t, to record sizes.
1207 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1208 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1209 either works, as we prefer signed integers.
1210 (tiff_read_from_memory, tiff_write_from_memory):
1211 Return tsize_t, not size_t, since that's what the TIFF API wants.
1212 (tiff_read_from_memory): Don't fail simply because the read would
1213 go past EOF; instead, return a short read.
1214 (tiff_load): Omit no-longer-needed casts.
1215 (Fimagemagick_types): Don't assume size fits into 'int'.
1217 Improve hashing quality when configured --with-wide-int.
1218 * fns.c (hash_string): New function, taken from sxhash_string.
1219 Do not discard information about ASCII character case; this
1220 discarding is no longer needed.
1221 (sxhash-string): Use it. Change sig to match it. Caller changed.
1222 * lisp.h: Declare it.
1223 * lread.c (hash_string): Remove, since we now use fns.c's version.
1224 The fns.c version returns a wider integer if --with-wide-int is
1225 specified, so this should help the quality of the hashing a bit.
1227 * emacs.c: Integer overflow minor fix.
1228 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1229 Define only if GNU_LINUX.
1230 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1232 * dispnew.c: Integer signedness and overflow fixes.
1233 Remove unnecessary forward decls, that were a maintenance hassle.
1234 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1236 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1237 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1238 (prepare_desired_row, line_draw_cost):
1239 Use int, not unsigned, where either works.
1240 (save_current_matrix, restore_current_matrix):
1241 Use ptrdiff_t, not size_t, where either works.
1242 (init_display): Check for overflow more accurately, and without
1243 relying on undefined behavior.
1245 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1246 Remove, replacing with the new symbols in lisp.h. All uses changed.
1247 * fileio.c (make_temp_name):
1248 * filelock.c (lock_file_1, lock_file):
1249 * xdisp.c (message_dolog):
1250 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1251 Use pMd etc. instead.
1252 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1253 replacing the pWIDE etc. symbols removed from editfns.c.
1255 * keyboard.h (num_input_events): Now uintmax_t.
1256 This is (very slightly) less likely to mess up due to wraparound.
1259 * buffer.c: Integer signedness fixes.
1260 (alloc_buffer_text, enlarge_buffer_text):
1261 Use ptrdiff_t rather than size_t when either will do, as we prefer
1264 * alloc.c: Integer signedness and overflow fixes.
1265 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1266 (__malloc_size_t): Default to size_t, not to int.
1267 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1268 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1269 Prefer ptrdiff_t to size_t when either would do, as we prefer
1271 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1272 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1273 Now const. Initialize with values that are in range even if char
1275 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1276 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1277 These functions do the right thing with sizes > 2**32.
1278 (check_depth): Now ptrdiff_t, not int.
1279 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1280 Adjust to new way of storing sizes. Check for size overflow bugs
1282 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1283 slightly wrong anyway, as it missed one instance of
1284 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1285 (refill_memory_reserve): Omit needless cast to size_t.
1286 (mark_object_loop_halt): Mark as externally visible.
1288 * xselect.c: Integer signedness and overflow fixes.
1289 (Fx_register_dnd_atom, x_handle_dnd_message):
1290 Use ptrdiff_t, not size_t, since we prefer signed.
1291 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1292 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1293 x_dnd_atoms_size and x_dnd_atoms_length.
1295 * doprnt.c: Prefer signed to unsigned when either works.
1297 * doprnt.c (doprnt):
1299 * xdisp.c (vmessage):
1300 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1301 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1302 prefer signed arithmetic to avoid comparison confusion.
1303 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1304 but is a bit tricky.
1306 Assume freestanding C89 headers, string.h, stdlib.h.
1307 * data.c, doprnt.c, floatfns.c, print.c:
1308 Include float.h unconditionally.
1309 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1310 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1311 * regex.c: Likewise for stddef.h, string.h.
1312 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1313 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1314 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1315 (STDC_HEADERS): Remove obsolete defines.
1316 * sysdep.c: Include limits.h unconditionally.
1318 Assume support for memcmp, memcpy, memmove, memset.
1319 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1320 * regex.c (memcmp, memcpy):
1321 Remove; we assume C89 now.
1323 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1324 (__malloc_safe_bcopy): Remove; no longer needed.
1326 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1327 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1328 well either way, and we prefer signed to unsigned.
1330 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1332 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1333 closes the connection while we're reading (bug#9182).
1335 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1337 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1338 are specified (Bug#9168).
1340 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1342 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1343 Found by GCC static checking and --with-wide-int on a 32-bit host.
1345 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1347 * xdisp.c (compute_display_string_pos): Fix logic of caching
1348 previous display string position. Initialize cached_prev_pos to
1349 -1. Fixes slow-down at the beginning of a buffer.
1351 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1353 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1354 for attrs[LFACE_FONTSET_INDEX].
1356 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1358 * xml.c (parse_region): Remove unused local
1359 that was recently introduced.
1361 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1363 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1364 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1366 * xdisp.c (move_it_in_display_line_to): Record the best matching
1367 position for TO_CHARPOS while scanning the line, and restore it on
1368 exit if none of the characters scanned was an exact match.
1369 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1370 when exact match is impossible due to invisible text, and the
1371 lines are truncated.
1373 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1375 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1378 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1380 Fix a significant slow-down of cursor motion with C-n, C-p,
1381 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1382 auto-repeat under bidi redisplay in fontified buffers.
1383 * xdisp.c (compute_stop_pos_backwards): New function.
1384 (next_element_from_buffer): Call compute_stop_pos_backwards to
1385 find a suitable prev_stop when we find ourselves before
1387 (reseat): Don't look for prev_stop, as that could mean a very long
1389 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1390 <cached_disp_overlay_modiff>: Cache for last found display string
1392 (compute_display_string_pos): Return the cached position if asked
1393 about the same buffer in the same area of character positions, and
1394 the buffer wasn't changed since the time the display string
1395 position was cached.
1397 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1399 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1400 is an integer, which is important for empty lines. (Bug#9149)
1402 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1404 * frame.c (Fmodify_frame_parameters): In tty case, update the
1405 default face if necessary (Bug#4238).
1407 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1409 * editfns.c (Fstring_to_char): No need to explain what a character
1410 is in the docstring (Bug#6576).
1412 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1414 * xml.c (parse_region): Make sure we always return a tree.
1416 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1418 * xml.c (parse_region): If a document contains only comments,
1421 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1423 * xml.c (make_dom): Return comments, too.
1425 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1428 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1429 and the surrounding thread.
1430 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1431 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1432 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1434 * s/openbsd.h (BROKEN_SIGIO): Define.
1435 * unexelf.c (unexec) [__OpenBSD__]:
1436 Don't update the .mdebug section of the Alpha COFF symbol table.
1438 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1440 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1443 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1445 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1446 This fixes some race conditions on the permissions of any newly
1449 * alloc.c (valid_pointer_p): Use pipe, not open.
1450 This fixes some permissions issues when debugging.
1452 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1453 If fchown fails to set both uid and gid, try to set just gid,
1454 as that is sometimes allowed. Adjust the file's mode to eliminate
1455 setuid or setgid bits that are inappropriate if fchown fails.
1457 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1459 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1460 to compare Lisp_Objects.
1461 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1462 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1463 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1465 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1467 * lread.c (read_integer): Unread even EOF character.
1468 (read1): Likewise. Properly record start position of symbol.
1470 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1471 symbol character follows.
1473 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1475 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1476 This works around a problem with the previous change to Fcopy_file.
1477 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1478 and without this change, GCC might complain about discarding
1479 fchown's return value.
1481 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1483 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1485 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1487 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1489 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1491 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1492 it's used from the C level.
1494 * process.c: Use the same condition for POLL_FOR_INPUT in both
1495 keyboard.c and process.c (bug#1858).
1497 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1499 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1500 (Fgnutls_boot): Use it.
1502 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1504 * doc.c (Fsubstitute_command_keys): Revert last change.
1506 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1508 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1509 quotes the next character, and doesn't affect other longer
1510 sequences (bug#8935).
1512 * lread.c (syms_of_lread): Clarify that is isn't only
1513 `eval-buffer' and `eval-defun' that's affected by
1514 `lexical-binding' (bug#8460).
1516 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1518 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1519 bidi redisplay when a line includes both an image and is
1522 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1524 Fix minor problems found by static checking.
1525 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1526 (elsz): Now a signed constant, not a size_t var. We prefer signed
1527 types to unsigned, to avoid integer comparison confusion. Without
1528 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1529 "cannot optimize loop, the loop counter may overflow", a symptom
1531 * indent.c (Fvertical_motion): Mark locals as initialized.
1532 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1534 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1536 * search.c (Fre_search_backward): Mention `case-fold-search' in
1537 all the re_search_* functions (bug#8138).
1539 * keyboard.c (Fopen_dribble_file): Document when the file is
1542 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1544 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1547 Support bidi reordering of display and overlay strings.
1548 * xdisp.c (compute_display_string_pos)
1549 (compute_display_string_end): Accept additional argument STRING.
1550 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1551 (reseat_to_string): Initialize bidi_it->string.s and
1552 bidi_it->string.schars.
1553 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1554 NULL (avoids a crash in bidi_paragraph_init).
1555 Initialize itb.string.lstring.
1556 (init_iterator): Call bidi_init_it only of a valid
1557 buffer position was specified. Initialize paragraph_embedding to
1559 (reseat_to_string): Initialize the bidi iterator.
1560 (display_string): If we need to ignore text properties of
1561 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1562 original value of -1 will not work with bidi.)
1563 (compute_display_string_pos): First arg is now struct
1564 `text_pos *'; all callers changed. Support display properties on
1566 (compute_display_string_end): Support display properties on Lisp
1568 (init_iterator, reseat_1, reseat_to_string): Initialize the
1569 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1570 when iterating on a string not from display properties).
1571 (compute_display_string_pos, compute_display_string_end):
1572 Fix calculation of the object to scan. Fixes an error when using
1574 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1575 base_level_stop; instead, set base_level_stop to BEGV.
1576 Fixes crashes in vertical-motion.
1577 (next_element_from_buffer): Improve commentary for when
1578 the iterator is before prev_stop.
1579 (init_iterator): Initialize bidi_p from the default value of
1580 bidi-display-reordering, not from buffer-local value. Use the
1581 buffer-local value only if initializing for buffer iteration.
1582 (handle_invisible_prop): Support invisible properties on strings
1583 that are being bidi-reordered.
1584 (set_iterator_to_next): Support bidi reordering of C strings and
1586 (next_element_from_string): Support bidi reordering of Lisp
1588 (handle_stop_backwards): Support Lisp strings as well.
1589 (display_string): Support display of R2L glyph rows.
1590 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1591 (init_iterator): Don't initialize it->bidi_p for strings
1593 (reseat_to_string): Initialize it->bidi_p for strings here.
1594 (next_element_from_string, next_element_from_c_string)
1595 (next_element_from_buffer): Add xassert's for correspondence
1596 between IT's object being iterated and it->bidi_it.string
1598 (face_before_or_after_it_pos): Support bidi iteration.
1599 (next_element_from_c_string): Handle the case of the first string
1600 character that is not the first one in the visual order.
1601 (get_visually_first_element): New function, refactored from common
1602 parts of next_element_from_buffer, next_element_from_string, and
1603 next_element_from_c_string.
1604 (tool_bar_lines_needed, redisplay_tool_bar)
1605 (display_menu_bar): Force left-to-right direction. Add a FIXME
1606 comment for making that be controlled by a user option.
1607 (push_it, pop_it): Save and restore the state of the
1608 bidi iterator. Save and restore the bidi_p flag.
1609 (pop_it): Iterate out of display property for string iteration as
1611 (iterate_out_of_display_property): Support iteration over strings.
1612 (handle_single_display_spec): Set up it->bidi_it for iteration
1613 over a display string, and call bidi_init_it.
1614 (handle_single_display_spec, next_overlay_string)
1615 (get_overlay_strings_1, push_display_prop): Set up the bidi
1616 iterator for displaying display or overlay strings.
1617 (forward_to_next_line_start): Don't use the shortcut if
1619 (back_to_previous_visible_line_start): If handle_display_prop
1620 pushed the iterator stack, restore the internal state of the bidi
1621 iterator by calling bidi_pop_it same number of times.
1622 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1623 and we are bidi-iterating, don't decrement the iterator position;
1624 instead, set the first_elt flag in the bidi iterator, to produce
1626 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1627 (push_display_prop): xassert that we are iterating a buffer.
1628 (push_it, pop_it): Save and restore paragraph_embedding member.
1629 (handle_single_display_spec, next_overlay_string)
1630 (get_overlay_strings_1, reseat_1, reseat_to_string)
1631 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1632 correctly. Don't assume unibyte strings are not bidi-reordered.
1633 (compute_display_string_pos)
1634 (compute_display_string_end): Fix handling the case of C string.
1635 (push_it, pop_it): Save and restore from_disp_prop_p.
1636 (handle_single_display_spec, push_display_prop): Set the
1637 from_disp_prop_p flag.
1638 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1639 (pop_it): Call iterate_out_of_display_property only if we are
1640 popping after iteration over a string that came from a display
1641 property. Fix a typo in popping stretch info. Add an assertion
1642 for verifying that the iterator position is in sync with the bidi
1644 (handle_single_display_spec, get_overlay_strings_1)
1645 (push_display_prop): Fix initialization of paragraph direction for
1646 string when that of the parent object is not yet determined.
1647 (reseat_1): Call bidi_init_it to resync the bidi
1648 iterator with IT's position. (Bug#7616)
1649 (find_row_edges): If ROW->start.pos gives position
1650 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1651 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1652 Reset the from_disp_prop_p flag.
1653 (SAVE_IT, RESTORE_IT): New macros.
1654 (pos_visible_p, face_before_or_after_it_pos)
1655 (back_to_previous_visible_line_start)
1656 (move_it_in_display_line_to, move_it_in_display_line)
1657 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1658 (try_scrolling, redisplay_window, display_line): Use them when
1659 saving a temporary copy of the iterator and restoring it back.
1660 (back_to_previous_visible_line_start, reseat_1)
1661 (init_iterator): Empty the bidi cache "stack".
1662 (move_it_in_display_line_to): If iterator ended up at
1663 EOL, but we never saw any buffer positions smaller than
1664 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1665 motion in bidi-reordered lines.
1666 (move_it_in_display_line_to): Record prev_method and prev_pos
1667 immediately before the call to set_iterator_to_next. Fixes cursor
1668 motion in bidi-reordered lines with stretch glyphs and strings
1669 displayed in margins. (Bug#8133) (Bug#8867)
1670 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1672 (pos_visible_p): Support positions in bidi-reordered lines.
1673 Save and restore bidi cache.
1675 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1676 (bidi_paragraph_info): Delete unused struct.
1677 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1678 (bidi_cache_start): New variable.
1679 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1681 (bidi_cache_fetch_state, bidi_cache_search)
1682 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1683 (bidi_cache_find, bidi_peek_at_next_level)
1684 (bidi_level_of_next_char, bidi_find_other_level_edge)
1685 (bidi_move_to_visually_next): Compare cache index with
1686 bidi_cache_start rather than with zero.
1687 (bidi_fetch_char): Accept new argument STRING; all callers
1688 changed. Support iteration over a string. Support strings with
1689 display properties. Support unibyte strings. Fix the type of
1690 `len' according to what STRING_CHAR_AND_LENGTH expects.
1691 (bidi_paragraph_init, bidi_resolve_explicit_1)
1692 (bidi_resolve_explicit, bidi_resolve_weak)
1693 (bidi_level_of_next_char, bidi_move_to_visually_next):
1694 Support iteration over a string.
1695 (bidi_set_sor_type, bidi_resolve_explicit_1)
1696 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1697 can now be zero (for strings); special values 0 and -1 were
1698 changed to -1 and -2, respectively.
1699 (bidi_char_at_pos): New function.
1700 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1701 Call it instead of FETCH_MULTIBYTE_CHAR.
1702 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1703 initialized to valid values.
1704 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1706 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1707 the test for valid cached positions. Fix the logic for looking up
1708 the sentinel state in the cache. GCPRO the Lisp string we are
1710 (bidi_push_it, bidi_pop_it): New functions.
1711 (bidi_initialize): Initialize the bidi cache start stack pointer.
1712 (bidi_cache_ensure_space): New function, refactored from part of
1713 bidi_cache_iterator_state. Don't assume the required size is just
1714 one BIDI_CACHE_CHUNK away.
1715 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1716 (bidi_count_bytes, bidi_char_at_pos): New functions.
1717 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1718 always valid if bidi_cache_idx is valid.
1719 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1720 is valid if it's going to be used.
1721 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1722 (bidi_cache_fetch_state, bidi_cache_search)
1723 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1724 (bidi_cache_iterator_state, bidi_cache_find)
1725 (bidi_find_other_level_edge, bidi_cache_start_stack):
1726 All variables related to cache indices are now EMACS_INT.
1728 * dispextern.h (struct bidi_string_data): New structure.
1729 (struct bidi_it): New member `string'. Make flag members be 1-bit
1730 fields, and put them last in the struct.
1731 (compute_display_string_pos, compute_display_string_end):
1733 (bidi_push_it, bidi_pop_it): Add prototypes.
1734 (struct iterator_stack_entry): New members bidi_p,
1735 paragraph_embedding, and from_disp_prop_p.
1736 (struct it): Member bidi_p is now a bit field 1 bit wide.
1737 (bidi_shelve_cache, bidi_unshelve_cache):
1740 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1741 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1742 and vector-like objects.
1744 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1745 cache around display iteration.
1747 * window.c (Fwindow_end, window_scroll_pixel_based)
1748 (displayed_window_lines, Frecenter): Save and restore the bidi
1749 cache around display iteration.
1751 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1753 * editfns.c (Fdelete_region): Clarify the use of the named
1754 parameters (bug#6788).
1756 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1758 * indent.c (Fvertical_motion): Set and restore w->pointm when
1759 saving and restoring the window's buffer (Bug#9006).
1761 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1763 * editfns.c (Fstring_to_char): Clarify just what is returned
1764 (bug#6576). Text by Eli Zaretskii.
1766 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1768 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1770 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1772 * buffer.c (mmap_find): Fix a typo.
1774 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1776 Fix execution of x selection hooks.
1777 * xselect.c (Qx_lost_selection_functions)
1778 (Qx_sent_selection_functions): New vars.
1779 (syms_of_xselect): DEFSYM them.
1780 (x_handle_selection_request): Pass Qx_sent_selection_functions
1781 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1782 (x_handle_selection_clear,x_clear_frame_selections):
1783 Pass Qx_lost_selection_functions rather than
1784 Vx_lost_selection_functions to Frun_hook_with_args.
1786 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1788 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1789 The old code sometimes used this field without initializing it.
1791 * alloc.c (gc_sweep): Don't read past end of array.
1792 In theory, the old code could also have corrupted Emacs internals,
1793 though it'd be very unlikely.
1795 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1797 * character.c (Fcharacterp): Don't advertise optional ignored
1798 argument. (Bug#4026)
1800 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1802 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1805 * window.c (Fset_window_start): Doc fix (bug#4199).
1806 (Fset_window_hscroll): Ditto.
1808 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1810 Fix minor new problems caught by GCC 4.6.1.
1811 * term.c (init_tty): Remove unused local.
1812 * xsettings.c (store_monospaced_changed): Define this function only
1813 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1816 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1818 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1820 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1822 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1823 are the mini-buffer and the echo area (bug#3320).
1825 * term.c (init_tty): Remove support for supdup, c10 and perq
1826 terminals, which are no longer supported (bug#1482).
1828 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1830 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1832 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1834 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1835 for non-popups (Bug#3642).
1837 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1839 * alloc.c (reset_malloc_hooks): Protoize.
1840 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1841 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1842 * cm.c (losecursor): Likewise.
1843 * data.c (fmod): Likewise.
1844 * dispnew.c (swap_glyphs_in_rows): Likewise.
1845 * emacs.c (memory_warning_signal): Likewise.
1846 * floatfns.c (float_error): Likewise.
1847 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1848 (otf_open, font_otf_capability, generate_otf_features)
1849 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1851 * image.c (pbm_read_file): Likewise.
1852 * indent.c (string_display_width): Likewise.
1853 * intervals.c (check_for_interval, search_for_interval)
1854 (inc_interval_count, count_intervals, root_interval)
1855 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1856 * lread.c (defalias): Likewise.
1857 * ralloc.c (r_alloc_check): Likewise.
1858 * regex.c (set_image_of_range_1, set_image_of_range)
1859 (regex_grow_registers): Likewise.
1860 * sysdep.c (strerror): Likewise.
1861 * termcap.c (valid_filename_p, tprint, main): Likewise.
1862 * tparam.c (main): Likewise.
1863 * unexhp9k800.c (run_time_remap, save_data_space)
1864 (update_file_ptrs, read_header, write_header, calculate_checksum)
1865 (copy_file, copy_rest, display_header): Likewise.
1866 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1868 * xdisp.c (check_it): Likewise.
1869 * xfaces.c (register_color, unregister_color, unregister_colors):
1871 * xfns.c (print_fontset_result): Likewise.
1872 * xrdb.c (member, fatal, main): Likewise.
1874 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1876 Fix minor problems found by static checking (Bug#9031).
1877 * chartab.c (char_table_set_range, map_sub_char_table):
1878 Remove unused locals.
1879 (uniprop_table): Now static.
1880 * composite.c (_work_char): Remove unused static var.
1882 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1884 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1886 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1888 * gtkutil.c (qttip_cb): Remove code without function.
1890 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1892 * w32.c (pthread_sigmask): New stub.
1894 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1896 Use pthread_sigmask, not sigprocmask (Bug#9010).
1897 sigprocmask is portable only for single-threaded applications, and
1898 Emacs can be multi-threaded when it uses GTK.
1899 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1901 * callproc.c (Fcall_process):
1902 * process.c (create_process):
1903 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1904 Use pthread_sigmask, not sigprocmask.
1906 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1908 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1909 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1912 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1914 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1915 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1916 (xg_hide_tooltip): Fix comment.
1918 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1919 in registerServicesMenuSendTypes.
1920 (validRequestorForSendType): Don't check ns_return_types.
1922 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1925 2011-07-08 Jason Rumney <jasonr@gnu.org>
1927 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1928 frame struct members of non-existent frames (Bug#6284).
1930 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1932 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1933 variable firstTime not needed on OSX >= 10.6.
1934 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1935 >= 10.5. Use setKnobProportion, setDoubleValue.
1937 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1938 (MAC_OS_X_VERSION_10_5): Define if not defined.
1939 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1940 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1941 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1943 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1944 cString and lossyCString on OSX >= 10.4
1946 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1947 sizeToFit on OSX >= 10.2.
1949 * nsimage.m (allocInitFromFile): Don't use deprecated method
1950 bestRepresentationForDevice on OSX >= 10.6.
1952 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1955 * emacs.c: Declare unexec_init_emacs_zone.
1957 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1959 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1961 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1962 on svcsMenu (Bug#8842).
1964 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1966 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1968 * nsterm.m (QUTF8_STRING): Declare.
1969 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1970 (validRequestorForSendType): Return type is (id).
1971 Change indexOfObjectIdenticalTo to indexOfObject.
1972 Check if we have local selection before returning self (Bug#8842).
1973 (writeSelectionToPasteboard): Put local selection into paste board
1974 if we have a local selection (Bug#8842).
1975 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1977 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1978 (ns_get_local_selection): Declare.
1980 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1982 * keymap.c (describe_map_tree): Don't insert a double newline at
1983 the end of the buffer (bug#1169) and return whether we inserted
1986 * callint.c (Fcall_interactively): Change "reading args" to
1987 "providing args" to try to clarify what it does (bug#1010).
1989 2011-07-07 Kenichi Handa <handa@m17n.org>
1991 * composite.c (composition_compute_stop_pos): Ignore a static
1992 composition starting before CHARPOS (Bug#8915).
1994 * xdisp.c (handle_composition_prop): Likewise.
1996 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1998 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2001 2011-07-07 Kenichi Handa <handa@m17n.org>
2003 * character.h (unicode_category_t): New enum type.
2005 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2006 (Qchar_code_property_table): New variable.
2007 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2008 (UNIPROP_COMPRESSED_FORM_P): New macros.
2009 (char_table_ascii): Uncompress the compressed values.
2010 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2011 Uncompress the compressed values.
2012 (sub_char_table_ref_and_range): Likewise.
2013 (char_table_ref_and_range): Uncompress the compressed values.
2014 (sub_char_table_set): New arg is_uniprop. Callers changed.
2015 Uncompress the compressed values.
2016 (sub_char_table_set_range): Args changed. Callers changed.
2017 (char_table_set_range): Adjuted for the above change.
2018 (map_sub_char_table): Delete args default_val and parent. Add arg
2019 top. Give decoded values to a Lisp function.
2020 (map_char_table): Adjust for the above change. Give decoded
2021 values to a Lisp function. Gcpro more variables.
2022 (uniprop_table_uncompress)
2023 (uniprop_decode_value_run_length): New functions.
2024 (uniprop_decoder, uniprop_decoder_count): New variables.
2025 (uniprop_get_decoder, uniprop_encode_value_character)
2026 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2028 (uniprop_encoder, uniprop_encoder_count): New variables.
2029 (uniprop_get_encoder, uniprop_table)
2030 (Funicode_property_table_internal, Fget_unicode_property_internal)
2031 (Fput_unicode_property_internal): New functions.
2032 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2033 Sunicode_property_table_internal, Sget_unicode_property_internal,
2034 and Sput_unicode_property_internal. Defvar_lisp
2035 char-code-property-alist.
2037 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2038 Vunicode_category_table.
2040 * font.c (font_range): Adjust for the change of
2041 Vunicode_category_table.
2043 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2045 * m/iris4d.h: Remove file, move contents ...
2046 * s/irix6-5.h: ... here.
2048 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2050 Remove unportable assumption about struct layout (Bug#8884).
2051 * alloc.c (mark_buffer):
2052 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2053 (clone_per_buffer_values): Don't assume that
2054 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2055 This isn't true in general, and it's particularly not true
2056 if Emacs is configured with --with-wide-int.
2057 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2058 New macros, used in the buffer.c change.
2060 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2062 * xsettings.c: Use both GConf and GSettings if both are available.
2063 (store_config_changed_event): Add comment.
2064 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2065 (store_tool_bar_style_changed): New functions.
2066 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2067 (struct xsettings): Move font inside HAVE_XFT.
2068 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2069 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2070 Move inside HAVE_XFT.
2071 (something_changed_gsettingsCB): Rename from something_changedCB.
2072 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2074 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2075 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2076 (something_changed_gconfCB): Rename from something_changedCB.
2077 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2078 (parse_settings): Move check for font inside HAVE_XFT.
2079 (read_settings, apply_xft_settings): Add comment.
2080 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2081 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2082 call store_font_name_changed.
2083 (xft_settings_event): Add comment.
2084 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2085 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2086 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2087 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2088 (xsettings_initialize): Call init_gsettings last.
2089 (xsettings_get_system_font, xsettings_get_system_normal_font):
2092 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2094 Random fixes. E.g., (random) never returned negative values.
2095 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2096 subseconds part to the entropy, as that's a bit more random.
2097 Prefer signed to unsigned, since the signedness doesn't matter and
2098 in general we prefer signed. When given a limit, use a
2099 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2100 latter isn't right if USE_2_TAGS_FOR_INTS.
2101 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2102 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2104 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2106 * textprop.c (text_property_stickiness):
2107 Obey Vtext_property_default_nonsticky.
2108 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2109 * w32fns.c (syms_of_w32fns):
2110 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2112 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2114 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2115 This is more efficient than Ffile_directory_p and avoids a minor race.
2117 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2119 * buffer.c (Foverlay_put): Say what the return value is
2122 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2123 is a directory before asking whether to use the file name
2125 (barf_or_query_if_file_exists): Make the "File is a directory"
2126 error be more correct.
2128 * fns.c (Frequire): Remove the mention of the .gz files, since
2129 that's installation-specific, but keep the mention of
2130 `get-load-suffixes'.
2132 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2134 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2135 Report string overflow if the output is too long.
2137 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2139 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2140 (syms_of_gnutls): Remove duplicate DEFSYM for
2141 Qgnutls_bootprop_verify_hostname_error, an error for
2142 Qgnutls_bootprop_verify_error (which is no longer used).
2144 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2145 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2146 Also (re)move comments that are misplaced or no longer relevant.
2148 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2150 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2152 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2154 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2155 and background color parameters if they have been changed.
2157 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2159 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2161 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2163 * xsettings.c (SYSTEM_FONT): Define only when used.
2164 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2166 * keymap.c (access_keymap_1): Now static.
2168 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2170 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2171 leave any prefix arg for the up event (Bug#1586).
2173 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2175 * lread.c (syms_of_lread): Mention single symbols defined by
2176 `defvar' or `defconst' (bug#7154).
2178 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2179 (Frequire): Mention get-load-suffixes.
2181 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2183 * window.h (window): Remove clone_number slot.
2184 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2186 (make_parent_window, make_window, saved_window)
2187 (Fset_window_configuration, save_window_save): Don't deal with
2189 * buffer.c (Qclone_number): Remove declaration.
2190 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2192 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2194 Add multiple inheritance to keymaps.
2195 * keymap.c (Fmake_composed_keymap): New function.
2196 (Fset_keymap_parent): Simplify.
2197 (fix_submap_inheritance): Remove.
2198 (access_keymap_1): New function extracted from access_keymap to handle
2199 embedded parents and handle lists of maps.
2200 (access_keymap): Use it.
2201 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2202 (Fcopy_keymap): Handle embedded parents.
2203 (Fcommand_remapping, define_as_prefix): Simplify.
2204 (Fkey_binding): Simplify.
2205 (syms_of_keymap): Move minibuffer-local-completion-map,
2206 minibuffer-local-filename-completion-map,
2207 minibuffer-local-must-match-map, and
2208 minibuffer-local-filename-must-match-map to Elisp.
2209 (syms_of_keymap): Defsubr make-composed-keymap.
2210 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2211 (parse_menu_item): Trivial simplification.
2213 2011-07-01 Glenn Morris <rgm@gnu.org>
2215 * Makefile.in (SETTINGS_LIBS): Fix typo.
2217 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2219 * coding.c (Fencode_coding_string): Record the last coding system
2220 used, as the function doc string says (bug#8738).
2222 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2224 * xsettings.c (store_monospaced_changed): Take new font as arg and
2225 check for change against current_mono_font.
2226 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2227 (emacs_settings_constructor, emacs_settings_get_property)
2228 (emacs_settings_set_property, emacs_settings_class_init)
2229 (emacs_settings_init, gsettings_obj): Remove.
2230 (something_changedCB): New function for HAVE_GSETTINGS.
2231 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2232 with value as argument.
2233 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2234 g_settings_new (Bug#8967). Do not create gsettings_obj.
2235 Remove calls to g_settings_bind. Connect something_changedCB to
2238 * xgselect.c: Add defined (HAVE_GSETTINGS).
2239 (xgselect_initialize): Ditto.
2241 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2242 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2245 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2247 * eval.c (struct backtrace): Simplify and port the data structure.
2248 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2249 signed bit field, as this assumption is not portable and it makes
2250 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2251 "char debug_on_exit : 1" as this is not portable either; instead,
2252 use the portable "unsigned int debug_on_exit : 1". Remove unused
2253 member evalargs. Remove obsolete comments about cc bombing out.
2255 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2257 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2258 Let HAVE_GSETTINGS override HAVE_GCONF.
2259 (store_monospaced_changed): New function.
2260 (EMACS_SETTINGS): A new type derived from GObject to handle
2261 GSettings notifications.
2262 (emacs_settings_constructor, emacs_settings_get_property)
2263 (emacs_settings_set_property, emacs_settings_class_init):
2265 (gsettings_client, gsettings_obj): New variables.
2266 (GSETTINGS_SCHEMA): New define.
2267 (something_changedCB): Call store_monospaced_changed.
2268 (init_gsettings): New function.
2269 (xsettings_initialize): Call init_gsettings.
2270 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2273 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2276 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2278 * window.c (resize_root_window, grow_mini_window)
2279 (shrink_mini_window): Rename Qresize_root_window to
2280 Qwindow_resize_root_window and Qresize_root_window_vertically to
2281 Qwindow_resize_root_window_vertically.
2283 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2285 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2287 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2289 * makefile.w32-in: Redesign dependencies so they reflect more
2290 clearly which files are directly included by each source file,
2291 and not through other includes.
2293 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2295 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2296 (sort_overlays, overlay_strings): When an overlay's clone number
2297 matches the window's clone number process the overlay even if
2298 the overlay's window property doesn't match the current window.
2300 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2301 (Fwindow_hchild): Rename to Fwindow_left_child.
2302 (Fwindow_next): Rename to Fwindow_next_sibling.
2303 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2304 (resize_window_check): Rename to window_resize_check.
2305 (resize_window_apply): Rename to window_resize_apply.
2306 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2307 (Fdelete_other_windows_internal, resize_frame_windows)
2308 (Fsplit_window_internal, Fdelete_window_internal)
2309 (grow_mini_window, shrink_mini_window)
2310 (Fresize_mini_window_internal): Fix callers accordingly.
2312 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2314 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2315 (emacs_fixed_set_min_size): Remove.
2316 (emacs_fixed_new): Take frame as argument.
2318 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2319 (_EmacsFixedPrivate): Remove minwidth/height.
2320 Add struct frame *f.
2321 (emacs_fixed_init): Initialize priv->f.
2322 (get_parent_class, emacs_fixed_set_min_size): Remove.
2323 (emacs_fixed_new): Set priv->f to argument.
2324 (emacs_fixed_get_preferred_width)
2325 (emacs_fixed_get_preferred_height): Use min_width/height from
2326 frames size_hint to set minimum and natural (Bug#8919).
2327 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2328 and use min_width/height from frames size_hint to set
2329 min_width/height (Bug#8919).
2331 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2332 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2335 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2337 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2338 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2341 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2343 * process.c (wait_reading_process_output): Bypass select if
2344 waiting for a cell while ignoring keyboard input, and input is
2345 pending. Suggested by Jan Djärv (Bug#8869).
2347 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2349 Use gnulib's dup2 module instead of rolling our own.
2350 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2352 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2354 * dispnew.c (scrolling_window): Before scrolling, turn off a
2355 mouse-highlight in the window being scrolled.
2357 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2359 Move DEFSYM to lisp.h and use everywhere.
2361 * character.h (DEFSYM): Move declaration...
2362 * lisp.h (DEFSYM): ...here.
2368 * w32select.c: Don't include character.h.
2370 * alloc.c (syms_of_alloc):
2371 * buffer.c (syms_of_buffer):
2372 * bytecode.c (syms_of_bytecode):
2373 * callint.c (syms_of_callint):
2374 * casefiddle.c (syms_of_casefiddle):
2375 * casetab.c (init_casetab_once):
2376 * category.c (init_category_once, syms_of_category):
2377 * ccl.c (syms_of_ccl):
2378 * cmds.c (syms_of_cmds):
2379 * composite.c (syms_of_composite):
2380 * dbusbind.c (syms_of_dbusbind):
2381 * dired.c (syms_of_dired):
2382 * dispnew.c (syms_of_display):
2383 * doc.c (syms_of_doc):
2384 * editfns.c (syms_of_editfns):
2385 * emacs.c (syms_of_emacs):
2386 * eval.c (syms_of_eval):
2387 * fileio.c (syms_of_fileio):
2388 * fns.c (syms_of_fns):
2389 * frame.c (syms_of_frame):
2390 * fringe.c (syms_of_fringe):
2391 * insdel.c (syms_of_insdel):
2392 * keymap.c (syms_of_keymap):
2393 * lread.c (init_obarray, syms_of_lread):
2394 * macros.c (syms_of_macros):
2395 * msdos.c (syms_of_msdos):
2396 * print.c (syms_of_print):
2397 * process.c (syms_of_process):
2398 * search.c (syms_of_search):
2399 * sound.c (syms_of_sound):
2400 * syntax.c (init_syntax_once, syms_of_syntax):
2401 * terminal.c (syms_of_terminal):
2402 * textprop.c (syms_of_textprop):
2403 * undo.c (syms_of_undo):
2404 * w32.c (globals_of_w32):
2405 * window.c (syms_of_window):
2406 * xdisp.c (syms_of_xdisp):
2407 * xfaces.c (syms_of_xfaces):
2408 * xfns.c (syms_of_xfns):
2409 * xmenu.c (syms_of_xmenu):
2410 * xsettings.c (syms_of_xsettings):
2411 * xterm.c (syms_of_xterm): Use DEFSYM.
2413 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2415 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2417 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2419 Integer and buffer overflow fixes (Bug#8873).
2421 * print.c (printchar, strout): Check for string overflow.
2422 (PRINTPREPARE, printchar, strout):
2423 Don't set size unless allocation succeeds.
2425 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2426 for sizes. Check for string overflow more accurately.
2427 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2429 * macros.c: Integer and buffer overflow fixes.
2430 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2431 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2432 Use ptrdiff_t, not int, for sizes.
2433 Don't increment bufsize until after realloc succeeds.
2434 Check for size-calculation overflow.
2435 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2437 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2439 * lread.c: Integer overflow fixes.
2440 (read_integer): Radix is now EMACS_INT, not int,
2441 to improve quality of diagnostics for out-of-range radices.
2442 Calculate buffer size correctly for out-of-range radices.
2443 (read1): Check for integer overflow in radices, and in
2444 read-circle numbers.
2445 (read_escape): Avoid int overflow.
2446 (Fload, openp, read_buffer_size, read1)
2447 (substitute_object_recurse, read_vector, read_list, map_obarray):
2448 Use ptrdiff_t, not int, for sizes.
2449 (read1): Use EMACS_INT, not int, for sizes.
2450 Check for size overflow.
2452 * image.c (cache_image): Check for size arithmetic overflow.
2454 * lread.c: Integer overflow issues.
2455 (saved_doc_string_size, saved_doc_string_length)
2456 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2457 Now ptrdiff_t, not int.
2458 (read1): Don't assume doc string length fits in int. Check for
2459 out-of-range doc string lengths.
2460 (read_list): Don't assume file position fits in int.
2461 (read_escape): Check for hex character overflow.
2463 2011-06-22 Leo Liu <sdl.web@gmail.com>
2465 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2466 Move to minibuffer.el.
2468 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2470 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2471 The following patches are for when GLYPH_DEBUG && !XASSERT.
2472 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2473 * dispnew.c (flush_stdout):
2474 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2475 Mark as externally visible.
2476 * dispnew.c (check_window_matrix_pointers): Now static.
2477 * dispnew.c (window_to_frame_vpos):
2478 * xfns.c (unwind_create_frame):
2479 * xterm.c (x_check_font): Remove unused local.
2480 * scroll.c (CHECK_BOUNDS):
2481 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2482 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2483 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2484 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2485 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2487 (debug_method_add): Use va_list and vsprintf rather than relying
2488 on undefined behavior with wrong number of arguments.
2489 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2490 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2491 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2492 since we're not interested in debugging glyphs with old libraries.
2493 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2494 GCC 4.6.0's static checking.
2496 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2498 Integer overflow and signedness fixes (Bug#8873).
2499 A few related buffer overrun fixes, too.
2501 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2503 * dispextern.h (struct face.stipple):
2504 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2505 (x_bitmap_mask, x_allocate_bitmap_record)
2506 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2507 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2508 (x_create_bitmap_from_xpm_data):
2509 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2510 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2512 * xfaces.c (load_pixmap):
2513 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2514 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2515 (.bitmaps_last, struct x_output.icon_bitmap):
2516 Use ptrdiff_t, not int, for bitmap indexes.
2517 (x_allocate_bitmap_record): Check for size overflow.
2518 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2520 Use ptrdiff_t, not int, for overlay counts.
2521 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2522 * editfns.c (overlays_around, get_pos_property):
2523 * textprop.c (get_char_property_and_overlay):
2524 * xdisp.c (next_overlay_change, note_mouse_highlight):
2525 * xfaces.c (face_at_buffer_position):
2526 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2527 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2528 (Fnext_overlay_change, Fprevious_overlay_change)
2529 (mouse_face_overlay_overlaps, Foverlays_in):
2530 Use ptrdiff_t, not int, for sizes.
2531 (overlays_at, overlays_in): Check for size-calculation overflow.
2533 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2535 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2536 (x_session_initialize): Do not assume string length fits in int.
2538 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2539 This is unlikely, but can occur if DPI is outlandish.
2541 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2542 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2544 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2545 * xrdb.c (magic_file_p, search_magic_path):
2546 Omit last arg SUFFIX; it was always 0. All callers changed.
2547 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2549 * xfont.c (xfont_match): Avoid need for strlen.
2551 * xfns.c: Don't assume strlen fits in int.
2552 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2554 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2555 not unsigned long, as we prefer signed integers. All callers changed.
2556 Detect integer overflow in repeat count.
2557 (message_dolog): Don't assume print length fits in 39 bytes.
2558 (display_mode_element): Don't assume strlen fits in int.
2560 * termcap.c: Don't assume sizes fit in int and never overflow.
2561 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2562 (gobble_line): Check for size-calculation overflow.
2564 * minibuf.c (Fread_buffer):
2565 * lread.c (intern, intern_c_string):
2566 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2567 Don't assume string length fits in int.
2569 * keyboard.c (parse_tool_bar_item):
2570 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2572 * font.c: Don't assume string length fits in int.
2573 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2574 Use ptrdiff_t, not int.
2575 (font_intern_prop): Don't assume string length fits in int.
2576 Don't assume integer property fits in fixnum.
2577 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2579 * filelock.c: Fix some buffer overrun and integer overflow issues.
2580 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2581 Reformulate so as not to need the command string.
2582 Invoke gzip -cd rather than gunzip, as it's more portable.
2583 (lock_info_type, lock_file_1, lock_file):
2584 Don't assume pid_t and time_t fit in unsigned long.
2585 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2586 (current_lock_owner): Prefer signed type for sizes.
2587 Use memcpy, not strncpy, where memcpy is what is really wanted.
2588 Don't assume (via atoi) that time_t and pid_t fit in int.
2589 Check for time_t and/or pid_t out of range, e.g., via a network share.
2590 Don't alloca where an auto var works fine.
2592 * fileio.c: Fix some integer overflow issues.
2593 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2594 Don't assume string length fits in int.
2595 (directory_file_name): Don't assume string length fits in long.
2596 (make_temp_name): Don't assume pid fits in int, or that its print
2597 length is less than 20.
2599 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2601 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2603 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2605 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2606 We prefer signed integers, even for size calculations.
2608 * emacs.c: Don't assume string length fits in 'int'.
2609 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2610 (main): Don't invoke strlen when not needed.
2612 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2613 (XD_DEBUG_MESSAGE): Don't waste a byte.
2615 * callproc.c (getenv_internal_1, getenv_internal)
2617 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2619 * lread.c (invalid_syntax): Omit length argument.
2620 All uses changed. This doesn't fix a bug, but it simplifies the
2621 code away from its former Hollerith-constant appearance, and it's
2622 one less 'int' to worry about when looking at integer-overflow issues.
2623 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2625 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2626 This didn't break anything, but it didn't help either.
2627 It's confusing to put a bogus integer in a place where the actual
2628 value does not matter.
2629 (LIST_END_P): Remove unused macro and its bogus comment.
2630 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2632 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2633 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2635 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2636 We prefer signed types, and the value cannot exceed the EMACS_INT
2637 range anyway (because otherwise the length would not be representable).
2638 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2639 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2640 This avoids a GCC warning when WIDE_EMACS_INT.
2642 * indent.c (sane_tab_width): New function.
2643 (current_column, scan_for_column, Findent_to, position_indentation)
2644 (compute_motion): Use it. This is just for clarity.
2645 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2647 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2649 * lisp.h (lint_assume): New macro.
2650 * composite.c (composition_gstring_put_cache):
2651 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2653 * editfns.c, insdel.c:
2654 Omit unnecessary forward decls, to simplify future changes.
2656 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2658 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2660 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2661 Use much-faster test for byte-length change.
2662 Don't assume string byte-length fits in 'int'.
2663 Check that character arg fits in 'int'.
2664 (mapcar1): Declare byte as byte, for clarity.
2666 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2668 * fns.c (concat): Catch string overflow earlier.
2669 Do not rely on integer wraparound.
2671 * dispextern.h (struct it.overlay_strings_charpos)
2672 (struct it.selective): Now EMACS_INT, not int.
2673 * xdisp.c (forward_to_next_line_start)
2674 (back_to_previous_visible_line_start)
2675 (reseat_at_next_visible_line_start, next_element_from_buffer):
2676 Don't arbitrarily truncate the value of 'selective' to int.
2678 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2680 * composite.c: Don't truncate sizes to 'int'.
2681 (composition_gstring_p, composition_reseat_it)
2682 (composition_adjust_point): Use EMACS_INT, not int.
2683 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2684 not EMACS_UINT, for indexes.
2686 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2688 * buffer.c: Include <verify.h>.
2689 (struct sortvec.priority, struct sortstr.priority):
2690 Now EMACS_INT, not int.
2691 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2692 (struct sortstr.size, record_overlay_string)
2693 (struct sortstrlist.size, struct sortlist.used):
2694 Don't truncate size to int.
2695 (record_overlay_string): Check for size-calculation overflow.
2696 (init_buffer_once): Check at compile-time, not run-time.
2698 2011-06-22 Jim Meyering <meyering@redhat.com>
2700 Don't leak an XBM-image-sized buffer
2701 * image.c (xbm_load): Free the image buffer after using it.
2703 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2706 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2707 that Sun C diagnosed.
2708 * fns.c (secure_hash): Fix pointer signedness issue.
2709 * intervals.c (static_offset_intervals): New function.
2710 (offset_intervals): Use it.
2712 2011-06-21 Leo Liu <sdl.web@gmail.com>
2715 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2718 * fns.c (secure_hash): Rename from crypto_hash_function and change
2719 the first arg to accept symbols.
2720 (Fsecure_hash): New primitive.
2721 (syms_of_fns): New symbols.
2723 2011-06-20 Deniz Dogan <deniz@dogan.se>
2725 * process.c (Fset_process_buffer): Clarify return value in
2728 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2730 * dispnew.c (add_window_display_history): Use BVAR.
2732 * xdisp.c (debug_method_add): Use BVAR.
2733 (check_window_end, dump_glyph_matrix, dump_glyph)
2734 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2736 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2739 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2740 check till after the cache is created in init_frame_faces.
2742 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2744 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2746 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2748 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2749 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2750 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2752 Improve buffer-overflow checking (Bug#8873).
2753 * fileio.c (Finsert_file_contents):
2754 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2755 Remove the old (too-loose) buffer overflow checks.
2756 They weren't needed, since make_gap checks for buffer overflow.
2757 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2758 The old code merely checked for Emacs fixnum overflow, and relied
2759 on undefined (wraparound) behavior. The new code avoids undefined
2760 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2762 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2763 Tune. Don't use wider integers than needed. Don't use alloca.
2764 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2766 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2768 * insdel.c, lisp.h (buffer_overflow): New function.
2769 (insert_from_buffer_1, replace_range, replace_range_2):
2770 * insdel.c (make_gap_larger):
2771 * editfns.c (Finsert_char):
2772 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2774 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2776 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2778 Integer overflow and signedness fixes (Bug#8873).
2780 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2781 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2783 * fileio.c: Don't assume EMACS_INT fits in off_t.
2784 (emacs_lseek): New static function.
2785 (Finsert_file_contents, Fwrite_region): Use it.
2786 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2788 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2790 * fns.c: Don't overflow int when computing a list length.
2791 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2792 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2793 truncation on 64-bit hosts. Check for QUIT every
2794 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2795 faster and is responsive enough.
2796 (Flength): Report an error instead of overflowing an integer.
2797 (Fsafe_length): Return a float if the value is not representable
2798 as a fixnum. This shouldn't happen except in contrived situations.
2799 (Fnthcdr, Fsort): Don't assume list length fits in int.
2800 (Fcopy_sequence): Don't assume vector length fits in int.
2802 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2803 (header_size, word_size): New constants.
2804 (allocate_vectorlike): Don't check size overflow here.
2805 (allocate_vector): Check it here instead, since this is the only
2806 caller of allocate_vectorlike that could cause overflow.
2807 Check that the new vector's length is representable as a fixnum.
2809 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2810 The previous code was bogus. For example, next_almost_prime (32)
2811 returned 39, which is undesirable as it is a multiple of 3; and
2812 next_almost_prime (24) returned 25, which is a multiple of 5 so
2813 why was the code bothering to check for multiples of 7?
2815 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2817 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2819 Variadic C functions now count arguments with ptrdiff_t.
2820 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2821 Back then I didn't know that the Emacs coding style prefers signed int.
2822 Also, in the meantime I found a few more instances where arguments
2823 were being counted with int, which may truncate counts on 64-bit
2824 machines, or EMACS_INT, which may be unnecessarily wide.
2825 * lisp.h (struct Lisp_Subr.function.aMANY)
2826 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2827 Arg counts are now ptrdiff_t, not size_t.
2828 All variadic functions and their callers changed accordingly.
2829 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2830 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2831 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2832 * callint.c (Fcall_interactively): Check arg count for overflow,
2833 to avoid potential buffer overrun. Use signed char, not 'int',
2834 for 'varies' array, so that we needn't bother to check its size
2835 calculation for overflow.
2836 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2837 * eval.c (apply_lambda):
2838 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2839 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2840 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2842 * callint.c (Fcall_interactively): Don't use index var as event count.
2844 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2845 * mem-limits.h (SIZE): Remove; no longer used.
2847 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2849 Remove unnecessary casts.
2850 * xterm.c (x_term_init):
2851 * xfns.c (x_set_border_pixel):
2852 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2853 These aren't needed now that we assume ANSI C.
2855 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2856 It's more likely to cause problems (due to unsigned overflow)
2859 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2861 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2863 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2865 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2867 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2869 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2871 GLYPH_CODE_FACE returns EMACS_INT, not int.
2872 * dispextern.h (merge_faces):
2873 * xfaces.c (merge_faces):
2874 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2875 Don't assume EMACS_INT fits in int.
2877 * character.h (CHAR_VALID_P): Remove unused parameter.
2878 * fontset.c, lisp.h, xdisp.c: All uses changed.
2880 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2882 * fns.c (concat): Minor tuning based on overflow analysis.
2883 This doesn't fix any bugs. Use int to hold character, instead
2884 of constantly refetching from Emacs object. Use XFASTINT, not
2885 XINT, for value known to be a character. Don't bother comparing
2886 a single byte to 0400, as it's always less.
2888 * floatfns.c (Fexpt):
2889 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2891 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2894 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2896 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2897 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2898 incorrectly succeed when S was a string, because 4294967386 was
2899 truncated before it was used.
2901 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2902 Otherwise, an out-of-range integer could cause undefined behavior
2905 * composite.c: Use int, not EMACS_INT, for characters.
2906 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2907 EMACS_INT, for values that are known to be in character range.
2908 This doesn't fix any bugs but is the usual style inside Emacs and
2909 may generate better code on 32-bit machines.
2911 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2912 This is for reasons similar to the recent CHAR_STRING fix.
2913 * charset.c (Fencode_char): Check that character arg is actually
2914 a character. Pass an int to ENCODE_CHAR.
2915 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2916 wider than 'int', as a compile-time check to prevent future regressions
2919 * character.c (char_string): Remove unnecessary casts.
2921 Make sure a 64-bit char is never passed to CHAR_STRING.
2922 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2923 by silently ignoring the top 32 bits, allowing some values
2924 that were far too large to be valid characters.
2925 * character.h: Include <verify.h>.
2926 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2927 arguments are no wider than unsigned, as a compile-time check
2928 to prevent future regressions in this area.
2930 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2931 (Fsubst_char_in_region):
2933 * xdisp.c (decode_mode_spec_coding):
2934 Adjust to CHAR_STRING's new requirement.
2935 * editfns.c (Finsert_char, Fsubst_char_in_region):
2936 * fns.c (concat): Check that character args are actually
2937 characters. Without this test, these functions did the wrong
2938 thing with wildly out-of-range values on 64-bit hosts.
2940 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2941 These casts should not be needed on 32-bit hosts, either.
2942 * keyboard.c (read_char):
2943 * lread.c (Fload): Remove casts to unsigned.
2945 * lisp.h (UNSIGNED_CMP): New macro.
2946 This fixes comparison bugs on 64-bit hosts.
2947 (ASCII_CHAR_P): Use it.
2948 * casefiddle.c (casify_object):
2949 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2950 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2951 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2952 * dispextern.h (FACE_FROM_ID):
2953 * keyboard.c (read_char): Use UNSIGNED_CMP.
2955 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2956 not to EMACS_INT, to avoid GCC warning.
2958 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2960 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2961 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2962 isn't needed on 32-bit machines.
2964 * buffer.c (Fgenerate_new_buffer_name):
2965 Use EMACS_INT for count, not int.
2966 (advance_to_char_boundary): Return EMACS_INT, not int.
2968 * data.c (Qcompiled_function): Now static.
2970 * window.c (window_body_lines): Now static.
2972 * image.c (gif_load): Rename local to avoid shadowing.
2974 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2975 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2976 * alloc.c (make_save_value): Integer argument is now of type
2978 (mark_object): Use ptrdiff_t, not int.
2979 * lisp.h (pD): New macro.
2980 * print.c (print_object): Use it.
2982 * alloc.c: Use EMACS_INT, not int, to count objects.
2983 (total_conses, total_markers, total_symbols, total_vector_size)
2984 (total_free_conses, total_free_markers, total_free_symbols)
2985 (total_free_floats, total_floats, total_free_intervals)
2986 (total_intervals, total_strings, total_free_strings):
2987 Now EMACS_INT, not int. All uses changed.
2988 (Fgarbage_collect): Compute overall total using a double, so that
2989 integer overflow is less likely to be a problem. Check for overflow
2990 when converting back to an integer.
2991 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2992 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2993 These were 'int' variables that could overflow on 64-bit hosts;
2994 they were never used, so remove them instead of repairing them.
2995 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2996 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2997 Previously, this ceilinged at INT_MAX, but that doesn't work on
2999 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3001 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3002 (allocate_vectorlike): Check for ptrdiff_t overflow.
3003 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3004 when a (possibly-narrower) signed value would do just as well.
3005 We prefer using signed arithmetic, to avoid comparison confusion.
3007 * alloc.c: Catch some string size overflows that we were missing.
3008 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3009 for convenience in STRING_BYTES_MAX.
3010 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3011 The definition here is exact; the one in lisp.h was approximate.
3012 (allocate_string_data): Check for string overflow. This catches
3013 some instances we weren't catching before. Also, it catches
3014 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3015 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3016 and ptrdiff_t and EMACS_INT are both 64 bits.
3018 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3019 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3020 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3022 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3024 * alloc.c (Fmake_string): Check for out-of-range init.
3026 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3028 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3030 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3032 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3033 xg_get_default_scrollbar_width.
3035 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3036 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3037 (style_changed_cb): Call update_theme_scrollbar_width and call
3038 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3039 all frames (Bug#8505).
3040 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3041 Call gtk_window_set_resizable if HAVE_GTK3.
3042 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3043 and height if HAVE_GTK3 (Bug#8505).
3044 (scroll_bar_width_for_theme): New variable.
3045 (update_theme_scrollbar_width): New function.
3046 (xg_get_default_scrollbar_width): Move code to
3047 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3048 (xg_initialize): Call update_theme_scrollbar_width.
3050 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3052 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3054 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3056 * frame.c (make_frame): Call other_buffer_safely instead of
3059 * window.c (temp_output_buffer_show): Call display_buffer with
3060 second argument Vtemp_buffer_show_specifiers and reset latter
3061 immediately after the call.
3062 (Vtemp_buffer_show_specifiers): New variable.
3063 (auto_window_vscroll_p, next_screen_context_lines)
3064 (Vscroll_preserve_screen_position): Remove leading asterisks from
3067 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3069 Fix minor problems found by GCC 4.6.0 static checking.
3070 * buffer.c (Qclone_number): Remove for now, as it's unused.
3071 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3072 (record_buffer): Remove unused local.
3073 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3074 (set_frame_buffer_list): Remove; unused.
3075 * frame.h (other_visible_frames): Remove decl.
3076 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3077 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3078 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3080 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3081 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3082 Define only if HAVE_GPM.
3083 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3084 (update_hints_inhibit): Remove; never set. All uses removed.
3085 * widgetprv.h (emacsFrameClassRec): Remove decl.
3086 * window.c (delete_deletable_window): Now returns void, since it
3087 wasn't returning anything.
3088 (compare_window_configurations): Remove unused locals.
3089 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3090 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3091 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3092 the same widths as pointers. This follows up on the 2011-05-06 patch.
3093 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3094 * xterm.h: Likewise.
3095 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3097 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3099 * makefile.w32-in: Update dependencies.
3100 (LISP_H): Add lib/intprops.h.
3102 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3104 * image.c (gif_load): Add animation frame delay to the metadata.
3105 (syms_of_image): Use DEFSYM. New symbol `delay'.
3107 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3109 * window.c (delete_deletable_window): Re-add.
3110 (Fset_window_configuration): Rewrite to handle dead buffers and
3111 consequently deletable windows.
3112 (window_tree, Fwindow_tree): Remove. Supply functionality in
3114 (compare_window_configurations): Simplify code.
3116 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3118 * image.c (imagemagick_load_image): Fix type mismatch.
3119 (Fimagemagick_types): Likewise.
3121 * window.h (replace_buffer_in_windows): Declare.
3123 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3125 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3126 Qclone_number. Remove external declaration of Qdelete_window.
3127 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3129 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3130 Run Qbuffer_list_update_hook if allowed.
3131 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3132 buffer list implementation.
3133 (other_buffer_safely): New function.
3134 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3135 calls to replace_buffer_in_windows and
3136 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3138 (record_buffer): Inhibit quitting and rewrite using quittable
3139 functions. Run Qbuffer_list_update_hook if allowed.
3140 (Frecord_buffer, Funrecord_buffer): New functions.
3141 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3142 Move switch-to-buffer to window.el.
3143 (bury-buffer): Move to window.el.
3144 (Vbuffer_list_update_hook): New variable.
3146 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3149 * window.h (resize_frame_windows): Move up in code.
3150 (Fwindow_frame): Remove EXFUN.
3151 (replace_buffer_in_all_windows): Remove prototype.
3152 (replace_buffer_in_windows_safely): Add prototype.
3154 * window.c: Declare Qdelete_window static again. Move down
3155 declaration of select_count.
3156 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3157 (Fother_window): Move to window.el.
3158 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3159 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3160 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3162 (replace_buffer_in_windows): Implement by calling
3163 Qreplace_buffer_in_windows.
3164 (replace_buffer_in_all_windows): Remove with some functionality
3165 moved into replace_buffer_in_windows_safely.
3166 (replace_buffer_in_windows_safely): New function.
3167 (select_window_norecord, select_frame_norecord): Move in front
3168 of run_window_configuration_change_hook. Remove now obsolete
3170 (Fset_window_buffer): Rewrite doc-string.
3171 Call Qrecord_window_buffer.
3172 (keys_of_window): Move binding for other-window to window.el.
3174 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3176 * dispextern.h (struct image): Replace data member, whose int_val
3177 and ptr_val fields were not used by anything, with a single
3180 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3181 (gif_clear_image, gif_load, imagemagick_load_image)
3182 (gs_clear_image, gs_load): Callers changed.
3184 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3186 * buffer.h: Include <time.h>, for time_t.
3187 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3189 Fix minor problems found by static checking.
3191 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3193 Make identifiers static if they are not used in other modules.
3194 * data.c (Qcompiled_function, Qframe, Qvector):
3195 * image.c (QimageMagick, Qsvg):
3196 * minibuf.c (Qmetadata):
3197 * window.c (resize_window_check, resize_root_window): Now static.
3198 * window.h (resize_window_check, resize_root_window): Remove decls.
3200 * window.c (window_deletion_count, delete_deletable_window):
3202 (window_body_lines): Now static.
3203 (Fdelete_other_windows_internal): Mark vars as initialized.
3204 Make sure 'resize_failed' is initialized.
3205 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3206 (resize_window_apply): Remove unused local.
3207 * window.h (delete_deletable_window): Remove decl.
3209 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3210 (imagemagick_load_image): Fix pointer signedness problem by changing
3211 last arg from unsigned char * to char *. All uses changed.
3212 Also, fix a local for similar reasons.
3213 Remove unused locals. Remove locals to avoid shadowing.
3214 (fn_rsvg_handle_free): Remove; unused.
3215 (svg_load, svg_load_image): Fix pointer signedness problem.
3216 (imagemagick_load_image): Don't use garbage pointer image_wand.
3218 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3220 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3222 * image.c (gif_load): Fix omitted cast error introduced by
3225 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3227 * window.h (resize_proportionally, orig_total_lines)
3228 (orig_top_line): Remove from window structure.
3229 (set_window_height, set_window_width, change_window_heights)
3230 (Fdelete_window): Remove prototypes.
3231 (resize_frame_windows): Remove duplicate declaration.
3233 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3235 * window.h (resize_frame_windows, resize_window_check)
3236 (delete_deletable_window, resize_root_window)
3237 (resize_frame_windows): Declare prototypes.
3239 * window.c (resize_window_apply): Make definition be "static" to
3240 match the prototype.
3242 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3244 * window.c: Remove declarations of Qwindow_size_fixed,
3245 window_min_size_1, window_min_size_2, window_min_size,
3246 size_window, window_fixed_size_p, enlarge_window, delete_window.
3247 Remove static from declaration of Qdelete_window, it's
3248 temporarily needed by Fbury_buffer.
3249 (replace_window): Don't assign orig_top_line and
3251 (Fdelete_window, delete_window): Remove. Window deletion is
3252 handled by window.el.
3253 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3254 Replace Fdelete_window calls with calls to Qdelete_window.
3255 (Fdelete_other_windows): Remove. Deleting other windows is
3256 handled by window.el.
3257 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3258 handled in window.el.
3259 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3260 Window minimum sizes are handled in window.el.
3261 (shrink_windows, size_window, set_window_height)
3262 (set_window_width, change_window_heights, window_height)
3263 (window_width, CURBEG, CURSIZE, enlarge_window)
3264 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3265 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3266 handled in window.el.
3267 (make_dummy_parent): Rename to make_parent_window and give it a
3268 second argument horflag.
3269 (make_window): Don't set resize_proportionally any more.
3270 (Fsplit_window): Remove. Windows are split in window.el.
3271 (save_restore_action, save_restore_orig_size)
3272 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3273 Resize mini windows in window.el.
3274 (grow_mini_window, shrink_mini_window): Implement by calling
3275 Qresize_root_window_vertically, resize_window_check and
3276 resize_window_apply.
3277 (saved_window, Fset_window_configuration, save_window_save):
3278 Do not handle orig_top_line, orig_total_lines, and
3279 resize_proportionally.
3280 (window_min_height, window_min_width): Move to window.el.
3281 (keys_of_window): Move bindings for delete-other-windows,
3282 split-window, delete-window and enlarge-window to window.el.
3284 * buffer.c: Temporarily extern Qdelete_window.
3285 (Fbury_buffer): Temporarily call Qdelete_window instead of
3286 Fdelete_window (Fbury_buffer will move to window.el soon).
3288 * frame.c (set_menu_bar_lines_1): Remove code handling
3289 orig_top_line and orig_total_lines.
3291 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3292 set_window_height but set heights directly.
3293 (change_frame_size_1): Use resize_frame_windows.
3295 * xdisp.c (init_xdisp): Don't use set_window_height but set
3298 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3299 Use resize_frame_windows instead of change_window_heights and run
3300 run_window_configuration_change_hook.
3302 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3303 instead of change_window_heights and run
3304 run_window_configuration_change_hook.
3306 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3308 * window.c (replace_window): Rename second argument REPLACEMENT to
3309 NEW. New third argument SETFLAG. Rewrite.
3310 (delete_window, make_dummy_parent): Call replace_window with
3312 (window_list_1): Move down in code.
3313 (run_window_configuration_change_hook): Move set_buffer part
3314 before select_frame_norecord part in order to unwind correctly.
3315 Rename count1 to count.
3316 (recombine_windows, delete_deletable_window, resize_root_window)
3317 (Fdelete_other_windows_internal)
3318 (Frun_window_configuration_change_hook, make_parent_window)
3319 (resize_window_check, resize_window_apply, Fresize_window_apply)
3320 (resize_frame_windows, Fsplit_window_internal)
3321 (Fdelete_window_internal, Fresize_mini_window_internal):
3323 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3325 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3327 * window.h (window): Add some new members to window structure -
3328 normal_lines, normal_cols, new_total, new_normal, clone_number,
3329 splits, nest, prev_buffers, next_buffers.
3330 (WINDOW_TOTAL_SIZE): Move here from window.c.
3331 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3333 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3335 (make_dummy_parent): Set new members of windows structure.
3336 (make_window): Move down in code. Handle new members of window
3338 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3339 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3340 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3341 (Fset_window_prev_buffers, Fwindow_next_buffers)
3342 (Fset_window_next_buffers, Fset_window_clone_number):
3344 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3345 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3347 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3348 Argument WINDOW can be now internal window too.
3349 (Fwindow_use_time): Move up in code.
3350 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3352 (Fset_window_configuration, saved_window)
3353 (Fcurrent_window_configuration, save_window_save): Handle new
3354 members of window structure.
3355 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3356 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3357 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3358 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3359 Qget_mru_window, Qresize_root_window,
3360 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3361 Qauto_buffer_name; staticpro them.
3363 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3365 * window.c (Fwindow_total_size, Fwindow_left_column)
3366 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3367 (Fwindow_list_1): New functions.
3368 (window_box_text_cols): Replace with window_body_cols.
3369 (Fwindow_width, Fscroll_left, Fscroll_right):
3370 Use window_body_cols instead of window_box_text_cols.
3371 (delete_window, Fset_window_configuration):
3372 Call delete_all_subwindows with window as argument.
3373 (delete_all_subwindows): Take a window as argument and not a
3375 (window_loop): Remove handling of GET_LRU_WINDOW and
3377 (Fget_lru_window, Fget_largest_window): Move to window.el.
3379 * window.h: Extern window_body_cols instead of
3380 window_box_text_cols. delete_all_subwindows now takes a
3381 Lisp_Object as argument.
3383 * indent.c (compute_motion, Fcompute_motion):
3384 Use window_body_cols instead of window_box_text_cols.
3386 * frame.c (delete_frame): Call delete_all_subwindows with root
3389 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3391 * fns.c (Fputhash): Document return value.
3393 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3395 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3397 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3399 Cons<->int and similar integer overflow fixes (Bug#8794).
3401 Check for overflow when converting integer to cons and back.
3402 * charset.c (Fdefine_charset_internal, Fdecode_char):
3403 Use cons_to_unsigned to catch overflow.
3404 (Fencode_char): Use INTEGER_TO_CONS.
3405 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3406 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3407 * data.c (long_to_cons, cons_to_long): Remove.
3408 (cons_to_unsigned, cons_to_signed): New functions.
3409 These signal an error for invalid or out-of-range values.
3410 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3411 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3412 * font.c (Ffont_variation_glyphs):
3413 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3414 * lisp.h: Include <intprops.h>.
3415 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3416 (cons_to_signed, cons_to_unsigned): New decls.
3417 (long_to_cons, cons_to_long): Remove decls.
3418 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3419 (Fprimitive_undo): Use CONS_TO_INTEGER.
3420 * xfns.c (Fx_window_property): Likewise.
3421 * xselect.c: Include <limits.h>.
3422 (x_own_selection, selection_data_to_lisp_data):
3423 Use INTEGER_TO_CONS.
3424 (x_handle_selection_request, x_handle_selection_clear)
3425 (x_get_foreign_selection, Fx_disown_selection_internal)
3426 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3427 (lisp_data_to_selection_data): Use cons_to_unsigned.
3428 (x_fill_property_data): Use cons_to_signed.
3429 Report values out of range.
3431 Check for buffer and string overflow more precisely.
3432 * buffer.h (BUF_BYTES_MAX): New macro.
3433 * lisp.h (STRING_BYTES_MAX): New macro.
3434 * alloc.c (Fmake_string):
3435 * character.c (string_escape_byte8):
3436 * coding.c (coding_alloc_by_realloc):
3437 * doprnt.c (doprnt):
3438 * editfns.c (Fformat):
3440 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3441 since they may not be the same number.
3442 * editfns.c (Finsert_char):
3443 * fileio.c (Finsert_file_contents):
3444 Likewise for BUF_BYTES_MAX.
3446 * image.c: Use ptrdiff_t, not int, for sizes.
3447 (slurp_file): Switch from int to ptrdiff_t.
3449 (slurp_file): Check that file size fits in both size_t (for
3450 malloc) and ptrdiff_t (for sanity and safety).
3452 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3453 if b->modtime has its maximal value.
3455 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3457 Don't assume time_t can fit into int.
3458 * buffer.h (struct buffer.modtime): Now time_t, not int.
3459 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3460 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3462 Minor fixes for signed vs unsigned integers.
3463 * character.h (MAYBE_UNIFY_CHAR):
3464 * charset.c (maybe_unify_char):
3465 * keyboard.c (read_char, reorder_modifiers):
3466 XINT -> XFASTINT, since the integer must be nonnegative.
3467 * ftfont.c (ftfont_spec_pattern):
3468 * keymap.c (access_keymap, silly_event_symbol_error):
3469 XUINT -> XFASTINT, since the integer must be nonnegative.
3470 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3471 since it makes no difference and we prefer signed.
3472 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3473 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3476 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3478 * window.h (Fwindow_frame): Declare.
3480 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3482 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3483 (SPARE_MEMORY): Always define.
3484 (LARGE_REQUEST): Remove.
3485 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3487 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3489 * lisp.h: Move EXFUNS for Fframe_root_window,
3490 Fframe_first_window and Fset_frame_selected_window to window.h.
3492 * window.h: Move EXFUNS for Fframe_root_window,
3493 Fframe_first_window and Fset_frame_selected_window here from
3496 * frame.c (Fwindow_frame, Fframe_first_window)
3497 (Fframe_root_window, Fframe_selected_window)
3498 (Fset_frame_selected_window): Move to window.c.
3499 (Factive_minibuffer_window): Move to minibuf.c.
3500 (Fother_visible_frames_p): New function.
3502 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3504 * window.c (decode_window, decode_any_window): Move up in code.
3505 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3506 (inhibit_frame_unsplittable): Remove unused variable.
3507 (Fwindow_buffer): Move up and rewrite doc-string.
3508 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3509 (Fwindow_prev): New functions.
3510 (Fwindow_frame): Move here from frame.c. Accept any window as
3512 (Fframe_root_window, Fframe_first_window)
3513 (Fframe_selected_window): Move here from frame.c. Accept frame
3514 or arbitrary window as argument. Update doc-strings.
3515 (Fminibuffer_window): Move up in code.
3516 (Fwindow_minibuffer_p): Move up in code and simplify.
3517 (Fset_frame_selected_window): Move here from frame.c.
3519 (Fselected_window, select_window, Fselect_window): Move up in
3520 code. Minor doc-string fixes.
3522 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3524 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3525 Do not assume that spare memory exists; that assumption is valid
3526 only if SYSTEM_MALLOC.
3527 (LARGE_REQUEST): New macro, so that the issue of large requests
3528 is separated from the issue of spare memory.
3530 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3532 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3535 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3537 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3540 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3542 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3544 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3546 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3547 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3549 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3551 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3553 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3555 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3556 (x_clipboard_manager_save): Add return value.
3557 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3559 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3560 Obey Vx_select_enable_clipboard_manager. Catch errors in
3561 x_clipboard_manager_save (Bug#8779).
3562 (Vx_select_enable_clipboard_manager): New variable.
3563 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3565 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3567 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3569 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3571 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3572 in the current matrix if keep_current_p is non-zero.
3574 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3576 * bidi.c (bidi_level_of_next_char): Fix last change.
3578 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3580 Support bidi reordering of text covered by display properties.
3582 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3583 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3584 (bidi_cache_search, bidi_cache_iterator_state)
3585 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3586 (bidi_level_of_next_char, bidi_move_to_visually_next):
3587 Support character positions inside a run of characters covered by a
3589 (bidi_paragraph_init, bidi_resolve_explicit_1)
3590 (bidi_level_of_next_char): Call bidi_fetch_char and
3591 bidi_fetch_char_advance instead of FETCH_CHAR and
3593 (bidi_init_it): Initialize new members.
3594 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3596 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3597 instead of using explicit *_CHAR codes.
3598 (bidi_resolve_explicit, bidi_resolve_weak):
3599 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3600 bidirectional text is supported only in multibyte buffers.
3601 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3602 it to initialize the frame_window_p member of struct bidi_it.
3603 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3604 (bidi_resolve_explicit, bidi_resolve_weak)
3605 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3606 bidi_it->nchars is non-positive.
3607 (bidi_level_of_next_char): Don't try to lookup the cache for the
3608 next/previous character if nothing is cached there yet, or if we
3609 were just reseat()'ed to a new position.
3611 * xdisp.c (set_cursor_from_row): Set start and stop points
3612 according to the row's direction when priming the loop that looks
3613 for the glyph on which to display cursor.
3614 (single_display_spec_intangible_p): Function deleted.
3615 (display_prop_intangible_p): Reimplement to call
3616 handle_display_spec instead of single_display_spec_intangible_p.
3617 Accept 3 additional arguments needed by handle_display_spec.
3618 This fixes incorrect cursor motion across display property with complex
3619 values: lists, `(when COND...)' forms, etc.
3620 (single_display_spec_string_p): Support property values that are
3621 lists with the argument STRING its top-level element.
3622 (display_prop_string_p): Fix the condition for processing a
3623 property that is a list to be consistent with handle_display_spec.
3624 (handle_display_spec): New function, refactored from the
3625 last portion of handle_display_prop.
3626 (compute_display_string_pos): Accept additional argument
3627 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3628 value of a `display' property is a "replacing spec".
3629 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3630 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3631 the display property, but just return a value indicating whether
3632 the display property will replace the characters it covers.
3633 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3634 frame_window_p members of struct bidi_it.
3635 (compute_display_string_pos, compute_display_string_end):
3637 (push_it): Accept second argument POSITION, where pop_it should
3638 jump to continue iteration.
3639 (reseat_1): Initialize bidi_it.disp_pos.
3641 * keyboard.c (adjust_point_for_property): Adjust the call to
3642 display_prop_intangible_p to its new signature.
3644 * dispextern.h (struct bidi_it): New member frame_window_p.
3645 (bidi_init_it): Update prototypes.
3646 (display_prop_intangible_p): Update prototype.
3647 (compute_display_string_pos, compute_display_string_end):
3649 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3652 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3654 Malloc failure behavior now depends on size of allocation.
3655 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3656 * lisp.h: Change signatures accordingly.
3657 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3658 All callers changed. (Bug#8762)
3660 * gnutls.c: Use Emacs's memory allocators.
3661 Without this change, the gnutls library would invoke malloc etc.
3662 directly, which causes problems on non-SYNC_INPUT hosts, and which
3663 runs afoul of improving memory_full behavior. (Bug#8761)
3664 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3665 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3666 xfree instead of the default malloc, realloc, free.
3667 (Fgnutls_boot): No need to check for memory allocation failure,
3668 since xmalloc does that for us.
3670 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3671 * category.c (hash_get_category_set):
3672 * ccl.c (ccl_driver):
3673 * charset.c (Fdefine_charset_internal):
3674 * charset.h (struct charset.hash_index):
3675 * composite.c (get_composition_id, gstring_lookup_cache)
3676 (composition_gstring_put_cache):
3677 * composite.h (struct composition.hash_index):
3678 * dispextern.h (struct image.hash):
3679 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3680 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3681 (hashfn_equal, hashfn_user_defined, make_hash_table)
3682 (maybe_resize_hash_table, hash_lookup, hash_put)
3683 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3684 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3685 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3686 * image.c (make_image, search_image_cache, lookup_image)
3687 (xpm_put_color_table_h):
3688 * lisp.h (struct Lisp_Hash_Table):
3689 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3690 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3691 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3692 * alloc.c (allocate_vectorlike):
3693 Check for overflow in vector size calculations.
3694 * ccl.c (ccl_driver):
3695 Check for overflow when converting EMACS_INT to int.
3696 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3697 need to be updated by these changes.
3698 * fns.c (make_hash_table, maybe_resize_hash_table):
3699 Check for integer overflow with large hash tables.
3700 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3701 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3702 (SXHASH_REDUCE): New macro.
3703 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3704 Use it instead of discarding useful hash info with large hash values.
3705 (sxhash_float): New function.
3706 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3707 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3708 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3709 Rewrite to use FIXNUM_BITS, as this simplifies things.
3710 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3711 Adjust signatures to match updated version of code.
3712 (consing_since_gc): Now EMACS_INT, since a single hash table can
3713 use more than INT_MAX bytes.
3715 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3717 Make it possible to build with GCC-4.6+ -O2 -flto.
3719 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3721 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3723 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3724 Call minibuffer-inactive-mode.
3726 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3728 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3729 Update dependencies.
3731 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3733 * data.c (init_data): Remove code for UTS, this system is not
3736 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3738 Don't force ./temacs to start in terminal mode.
3740 * frame.c (make_initial_frame): Initialize faces in all cases, not
3741 only when CANNOT_DUMP is defined.
3742 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3744 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3746 * dispnew.c (add_window_display_history): Use const for the string
3747 pointer. Remove declaration, not needed.
3749 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3751 Use 'inline', not 'INLINE'.
3752 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3753 * alloc.c, fontset.c (INLINE): Remove.
3754 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3755 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3756 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3757 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3758 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3760 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3762 Make it possible to run ./temacs.
3764 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3765 syms_of_callproc does the same thing. Remove test for
3766 "initialized", do it in the caller.
3767 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3769 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3771 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3772 (read_minibuf): Use get_minibuffer.
3773 (syms_of_minibuf): Use DEFSYM.
3774 (Qmetadata): New var.
3775 * data.c (Qbuffer): Don't make it static.
3776 (syms_of_data): Use DEFSYM.
3778 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3780 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3781 (CCL_CODE_MIN): New macro.
3783 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3785 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3787 * eval.c (Qdebug): Now static.
3788 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3789 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3790 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3792 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3794 * image.c: Various fixes to ImageMagick code comments.
3795 (Fimagemagick_types): Doc fix.
3797 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3799 Minor fixes prompted by GCC 4.6.0 warnings.
3801 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3803 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3804 (x_clipboard_manager_save_all): Move extern decl to ...
3805 * xterm.h: ... here, so that it can be checked for consistency.
3807 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3809 * xselect.c (x_clipboard_manager_save_frame)
3810 (x_clipboard_manager_save_all): New functions.
3811 (Fx_clipboard_manager_save): Lisp function deleted.
3813 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3814 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3816 * xterm.h: Update prototype.
3818 2011-05-28 William Xu <william.xwl@gmail.com>
3820 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3823 2011-05-28 Jim Meyering <meyering@redhat.com>
3825 Avoid a sign-extension bug in crypto_hash_function.
3826 * fns.c (to_uchar): Define.
3827 (crypto_hash_function): Use it to convert some newly-signed
3828 variables to unsigned, to avoid sign-extension bugs. For example,
3829 without this change, (md5 "truc") would evaluate to
3830 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3831 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3832 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3834 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3836 Integer overflow fixes.
3838 * dbusbind.c: Serial number integer overflow fixes.
3839 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3840 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3841 to hold a serial number that is too large for a fixnum.
3842 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3843 Check for serial numbers out of range. Decode any serial number
3844 that was so large that it became a float. (Bug#8722)
3846 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3847 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3848 Use XFASTINT rather than XUINT when numbers are nonnegative.
3849 (xd_append_arg, Fdbus_method_return_internal):
3850 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3851 arguments, check that Lisp number is nonnegative, rather than
3852 silently wrapping negative numbers around. (Bug#8722)
3853 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3856 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3858 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3860 ccl: add integer overflow checks
3861 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3862 (IN_INT_RANGE): New macros.
3863 (ccl_driver): Use them to check for integer overflow when
3864 decoding a CCL program. Many of the new checks are whether XINT (x)
3865 fits in int; it doesn't always, on 64-bit hosts. The new version
3866 doesn't catch all possible integer overflows, but it's an
3867 improvement. (Bug#8719)
3869 * alloc.c (make_event_array): Use XINT, not XUINT.
3870 There's no need for unsigned here.
3872 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3873 This follows up to the 2011-05-06 change that substituted uintptr_t
3874 for EMACS_INT. This case wasn't caught back then.
3876 Rework Fformat to avoid integer overflow issues.
3877 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3878 now (part of C89). Include <verify.h>.
3879 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3880 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3881 (Fformat): Avoid the prepass trying to compute sizes; it was only
3882 approximate and thus did not catch overflow reliably. Instead, walk
3883 through the format just once, formatting and computing sizes as we go,
3884 checking for integer overflow at every step, and allocating a larger
3885 buffer as needed. Keep track separately whether the format is
3886 multibyte. Keep only the most-recently calculated precision, rather
3887 than them all. Record whether each argument has been converted to
3888 string. Use EMACS_INT, not int, for byte and char and arg counts.
3889 Support field widths and precisions larger than INT_MAX. Avoid
3890 sprintf's undefined behavior with conversion specifications such as %#d
3891 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3892 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3893 formatting out-of-range floating point numbers with int
3896 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3898 * data.c: Avoid integer truncation in expressions involving floats.
3899 * data.c: Include <intprops.h>.
3900 (arith_driver): When there's an integer overflow in an expression
3901 involving floating point, convert the integers to floating point
3902 so that the resulting value does not suffer from catastrophic
3903 integer truncation. For example, on a 64-bit host (* 4
3904 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3905 Do not rely on undefined behavior after integer overflow.
3907 merge count_size_as_multibyte, parse_str_to_multibyte
3908 * character.c, character.h (count_size_as_multibyte):
3909 Rename from parse_str_to_multibyte; all uses changed.
3910 Check for integer overflow.
3911 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3912 since it's now a duplicate of the other. This is more of
3913 a character than a buffer op, so better that it's in character.c.
3914 * fns.c, print.c: Adjust to above changes.
3916 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3918 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3920 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3922 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3923 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3924 (x_clipboard_manager_save): Now static.
3925 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3927 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3928 (crypto_hash_function): Now static.
3929 Fix pointer signedness problems. Avoid unnecessary initializations.
3931 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3933 * termhooks.h (Vselection_alist): Make it terminal-local.
3935 * terminal.c (create_terminal): Initialize it.
3937 * xselect.c: Support for clipboard managers.
3938 (Vselection_alist): Move to termhooks.h as terminal-local var.
3939 (LOCAL_SELECTION): New macro.
3940 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3941 (symbol_to_x_atom): Remove gratuitous arg.
3942 (x_handle_selection_request, lisp_data_to_selection_data)
3943 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3944 (x_own_selection, x_get_local_selection, x_convert_selection):
3945 New arg, specifying work frame. Use terminal-local Vselection_alist.
3946 (some_frame_on_display): Delete unused function.
3947 (Fx_own_selection_internal, Fx_get_selection_internal)
3948 (Fx_disown_selection_internal, Fx_selection_owner_p)
3949 (Fx_selection_exists_p): New optional frame arg.
3950 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3951 (x_handle_selection_clear): Don't treat other terminals with the
3952 same keyboard specially. Use the terminal-local Vselection_alist.
3953 (x_clear_frame_selections): Use Frun_hook_with_args.
3955 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3957 * xterm.h: Add support for those atoms.
3959 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3961 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3962 (converted_selections, conversion_fail_tag): New global variables.
3963 (x_selection_request_lisp_error): Free the above.
3964 (x_get_local_selection): Remove unnecessary code.
3965 (x_reply_selection_request): Args changed; handle arbitrary array
3966 of converted selections stored in converted_selections.
3967 Separate the XChangeProperty and SelectionNotify steps.
3968 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3969 (x_convert_selection): New function.
3970 (x_handle_selection_event): Simplify.
3971 (x_get_foreign_selection): Don't ignore incoming requests while
3972 waiting for an answer; this will fail when we implement
3973 SAVE_TARGETS, and seems unnecessary anyway.
3974 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3975 (Vx_sent_selection_functions): Doc fix.
3977 2011-05-26 Leo Liu <sdl.web@gmail.com>
3979 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3981 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3983 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3985 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3986 for fringe update if it has periodic bitmap.
3987 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3988 and fringe_bitmap_periodic_p.
3990 * fringe.c (get_fringe_bitmap_data): New function.
3991 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3992 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3993 row. Mark glyph row for fringe update if periodicity changed.
3995 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3996 for fringe update unless it has periodic bitmap.
3998 2011-05-25 Kenichi Handa <handa@m17n.org>
4000 * xdisp.c (get_next_display_element): Set correct it->face_id for
4001 a static composition.
4003 2011-05-24 Leo Liu <sdl.web@gmail.com>
4006 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4008 * fns.c (crypto_hash_function, Fsha1): New function.
4009 (Fmd5): Use crypto_hash_function.
4010 (syms_of_fns): Add Ssha1.
4012 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4014 * gnutls.c: Remove unused macros.
4015 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4016 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4017 Remove macros that are defined and never used.
4018 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4020 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4022 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4023 (Fx_get_selection_internal): Minor cleanup.
4024 (Fx_own_selection_internal): Rename arguments for consistency with
4027 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4029 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4031 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4033 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4035 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4037 * dispnew.c (scrolling_window): Don't exclude the case that the
4038 last enabled row in the desired matrix touches the bottom boundary.
4040 2011-05-21 Glenn Morris <rgm@gnu.org>
4042 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4043 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4044 and add some more files.
4046 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4048 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4049 report_file_error introduced by the change from 2011-05-07.
4051 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4053 * systime.h (Time): Define only if emacs is defined.
4054 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4055 where the include path doesn't have X11/X.h by default. See
4056 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4058 2011-05-20 Kenichi Handa <handa@m17n.org>
4060 * composite.c (find_automatic_composition): Fix previous change.
4062 2011-05-20 Glenn Morris <rgm@gnu.org>
4064 * lisp.mk: New file, split from Makefile.in.
4065 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4066 (shortlisp): Remove.
4067 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4069 2011-05-19 Glenn Morris <rgm@gnu.org>
4071 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4072 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4073 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4074 (lisp): Set the order to that of loadup.el.
4075 (shortlisp): Make it a copy of $lisp.
4076 (SOME_MACHINE_LISP): Remove.
4077 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4078 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4080 2011-05-18 Kenichi Handa <handa@m17n.org>
4082 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4083 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4084 (find_automatic_composition): Mostly rewrite for efficiency.
4086 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4088 * makefile.w32-in: Update dependencies.
4090 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4092 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4093 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4095 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4097 Fix some integer overflow issues, such as string length overflow.
4099 * insdel.c (count_size_as_multibyte): Check for string overflow.
4101 * character.c (lisp_string_width): Check for string overflow.
4102 Use EMACS_INT, not int, for string indexes and lengths; in
4103 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4104 the resulting string length overflows an EMACS_INT; instead,
4105 report a string overflow if no precision given. When checking for
4106 precision exhaustion, use a check that cannot possibly have
4107 integer overflow. (Bug#8675)
4108 * character.h (lisp_string_width): Adjust to new signature.
4110 * alloc.c (string_overflow): New function.
4111 (Fmake_string): Use it. This doesn't change behavior, but saves
4112 a few bytes and will simplify future changes.
4113 * character.c (string_escape_byte8): Likewise.
4114 * lisp.h (string_overflow): New decl.
4116 Fixups, following up to the user-interface timestamp change.
4117 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4118 for UI timestamps, instead of unsigned long.
4119 * msdos.c (mouse_get_pos): Likewise.
4120 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4121 * w32gui.h (Time): Define by including "systime.h" rather than by
4122 declaring it ourselves. (Bug#8664)
4124 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4125 * image.c (clear_image_cache): Likewise.
4127 * term.c (term_mouse_position): Don't assume time_t wraparound.
4129 Be more systematic about user-interface timestamps.
4130 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4131 and sometimes 'EMACS_UINT', to represent these timestamps.
4132 This change causes it to use 'Time' uniformly, as that's what X uses.
4133 This makes the code easier to follow, and makes it easier to catch
4134 integer overflow bugs such as Bug#8664.
4135 * frame.c (Fmouse_position, Fmouse_pixel_position):
4136 Use Time, not unsigned long, for user-interface timestamps.
4137 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4138 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4139 * keyboard.h (last_event_timestamp): Likewise.
4140 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4141 * menu.h (xmenu_show): Likewise.
4142 * term.c (term_mouse_position): Likewise.
4143 * termhooks.h (struct input_event.timestamp): Likewise.
4144 (struct terminal.mouse_position_hook): Likewise.
4145 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4146 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4147 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4148 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4150 * menu.h, termhooks.h: Include "systime.h", for Time.
4152 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4153 Don't assume that the difference between two unsigned long values
4154 can fit into an integer. At this point, we know button_down_time
4155 <= event->timestamp, so the difference must be nonnegative, so
4156 there's no need to cast the result if double-click-time is
4157 nonnegative, as it should be; check that it's nonnegative, just in
4158 case. This bug is triggered when events are more than 2**31 ms
4159 apart (about 25 days). (Bug#8664)
4161 * xselect.c (last_event_timestamp): Remove duplicate decl.
4162 (x_own_selection): Remove needless cast to unsigned long.
4164 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4165 that always fit in int. Use a sentinel instead of a counter, to
4166 avoid a temp and to allay GCC's concerns about possible int overflow.
4167 * frame.h (struct frame): Use int for menu_bar_items_used
4168 instead of EMACS_INT, since it always fits in int.
4170 * menu.c (grow_menu_items): Check for int overflow.
4172 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4174 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4175 Before, the code was not consistent. These values cannot exceed
4176 2**31 - 1 so there's no need to make them unsigned.
4177 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4178 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4179 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4181 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4183 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4184 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4185 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4186 presumably because the widths might not match.
4188 * window.c (size_window): Avoid needless test at loop start.
4190 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4192 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4194 2011-05-12 Drew Adams <drew.adams@oracle.com>
4196 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4198 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4200 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4201 `width' to `bar_area_x' and `bar_area_width', respectively.
4202 (x_scroll_run): Take account of fringe background extension.
4204 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4205 Rename local vars `left' and `width' to `bar_area_x' and
4206 `bar_area_width', respectively.
4207 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4208 background extension.
4210 2011-05-10 Jim Meyering <meyering@redhat.com>
4212 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4214 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4216 * image.c (Finit_image_library): Return t for built-in image types,
4217 like pbm and xbm. (Bug#8640)
4219 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4221 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4223 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4225 * w32console.c (Fset_screen_color): Doc fix.
4226 (Fget_screen_color): New function.
4227 (syms_of_ntterm): Defsubr it.
4229 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4230 unlink the temporary file if Fcall_process didn't create it in the
4232 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4233 child process will be redirected to a file specified with `:file'.
4234 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4235 cue to call_process_cleanup not to close that handle.
4237 2011-05-07 Ben Key <bkey76@gmail.com>
4239 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4240 one of two shell specific rules, either bootstrap-temacs-CMD or
4241 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4242 to the previous implementation of the bootstrap-temacs rule.
4243 The bootstrap-temacs-CMD rule is similar to the previous
4244 implementation of the bootstrap-temacs rule except that it
4245 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4248 These changes, along with some changes to nt/configure.bat,
4249 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4250 earlier fix to add support for --cflags and --ldflags options
4251 that include quotes so that it works whether make uses cmd or
4254 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4256 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4257 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4259 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4260 a string. Handle both cases.
4261 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4262 (Fdbus_register_method): Use Qinvalid_function.
4264 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4266 * makefile.w32-in: Update dependencies.
4267 (LISP_H): Add inttypes.h and stdin.h.
4268 (PROCESS_H): Add unistd.h.
4270 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4272 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4273 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4275 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4277 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4279 * term.c (vfatal): Remove stray call to va_end.
4280 It's not needed and the C Standard doesn't allow it here anyway.
4282 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4283 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4285 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4288 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4290 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4292 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4294 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4296 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4298 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4299 * charset.c (Fdefine_charset_internal): Don't initialize
4300 charset.code_space[15]. The value was garbage, on hosts with
4301 32-bit int (Bug#8600).
4303 * lread.c (read_integer): Be more consistent with string-to-number.
4304 Use string_to_number to do the actual conversion; this avoids
4305 rounding errors and fixes some other screwups. Without this fix,
4306 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4307 (digit_to_number): Move earlier, for benefit of read_integer.
4308 Return -1 if the digit is out of range for the base, -2 if it is
4309 not a digit in any supported base. (Bug#8602)
4311 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4313 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4314 to match comment at start of function. This also removes a
4315 GCC warning about overflow in a 32+64-bit port.
4317 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4319 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4320 Reported by Stefan Monnier in
4321 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4322 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4323 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4325 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4326 (EMACS_UINTPTR): Likewise, with uintptr_t.
4328 * lisp.h: Prefer 64-bit EMACS_INT if available.
4329 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4330 on 32-bit hosts that have 64-bit int, so that they can access
4332 However, temporarily disable this change unless the temporary
4333 symbol WIDE_EMACS_INT is defined.
4335 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4337 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4338 This removes an assumption that EMACS_INT and long are the same
4339 width as pointers. The assumption is true for Emacs porting targets
4340 now, but we want to make other targets possible.
4341 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4342 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4343 In the rest of the code, change types of integers that hold casted
4344 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4345 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4346 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4347 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4348 No need to cast type when ORing.
4349 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4350 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4351 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4352 assume EMACS_INT is the same width as char *.
4353 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4354 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4355 Remove no-longer-needed casts.
4356 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4357 (xg_tool_bar_help_callback, xg_make_tool_item):
4358 Use EMACS_INTPTR to hold an integer
4359 that will be cast to void *; this can avoid a GCC warning
4360 if EMACS_INT is not the same width as void *.
4361 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4362 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4363 (current_message_1, set_message_1):
4364 Use a local to convert to proper width without a cast.
4365 * xmenu.c (dialog_selection_callback): Likewise.
4367 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4368 Also, don't assume VALBITS / RAND_BITS is less than 5,
4369 and don't rely on undefined behavior when shifting a 1 left into
4371 * lisp.h (get_random): Change signature to match.
4373 * lread.c (hash_string): Use size_t, not int, for hash computation.
4374 Normally we prefer signed values; but hashing is special, because
4375 it's better to use unsigned division on hash table sizes so that
4376 the remainder is nonnegative. Also, size_t is the natural width
4377 for hashing into memory. The previous code used 'int', which doesn't
4378 retain enough info to hash well into very large tables.
4379 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4381 * dbusbind.c: Don't possibly lose pointer info when converting.
4382 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4383 Use XPNTR rather than XHASH, so that the high-order bits of
4384 the pointer aren't lost when converting through void *.
4386 * eval.c (Fautoload): Don't double-shift a pointer.
4388 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4390 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4392 * gnutls.c (DEF_GNUTLS_FN):
4393 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4395 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4397 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4400 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4402 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4403 New version that can reserve upto 2GB of heap space.
4405 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4407 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4409 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4411 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4412 `gnutls_certificate_set_x509_key_file'.
4414 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4416 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4417 Update dependencies.
4419 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4421 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4422 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4423 Remove unused parameter `fildes'.
4424 * process.c (read_process_output, send_process): Don't pass it.
4426 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4428 Fix previous change: the library cache is defined in w32.c.
4429 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4430 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4432 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4434 Implement dynamic loading of GnuTLS on Windows.
4436 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4437 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4438 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4441 * gnutls.c (Qgnutls_dll): Define.
4442 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4443 (gnutls_*): Declare function pointers.
4444 (init_gnutls_functions): New function to initialize function pointers.
4445 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4446 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4447 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4448 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4449 (emacs_gnutls_write, emacs_gnutls_read)
4450 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4451 (Fgnutls_available_p): New function.
4452 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4453 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4454 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4456 * image.c: Include w32.h.
4457 (Vimage_type_cache): Delete.
4458 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4459 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4460 (w32_delayed_load): Move to w32.c.
4462 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4464 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4465 (w32_delayed_load): Move from image.c. When loading a library, record
4466 its filename in the :loaded-from property of the library id.
4467 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4468 Initialize and staticpro them.
4469 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4471 * process.c: Include lisp.h before w32.h, not after.
4472 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4473 instead of gnutls_record_check_pending.
4475 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4477 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4479 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4480 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4483 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4485 * xterm.c (x_set_frame_alpha): Do not set property on anything
4486 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4488 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4490 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4492 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4494 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4495 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4496 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4497 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4498 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4499 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4500 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4501 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4502 (Qgnutls_bootprop_callbacks_verify): Make static.
4504 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4506 * callproc.c: Indentation fixup.
4508 * sysdep.c (wait_for_termination_1): Make static.
4509 (wait_for_termination, interruptible_wait_for_termination):
4510 Move after wait_for_termination_1.
4512 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4514 * sysdep.c (interruptible_wait_for_termination): New function
4515 which is like wait_for_termination, but allows keyboard
4518 * callproc.c (Fcall_process): Add (:file "file") as an option for
4520 (Fcall_process_region): Ditto.
4522 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4524 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4525 rather than `XVECTOR (FOO)->size'.
4527 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4528 inttypes.h, as a gnulib replacement is used if it not available in
4531 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4533 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4534 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4535 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4537 * coding.c (coding_alloc_by_realloc): Error out if destination
4538 will grow beyond MOST_POSITIVE_FIXNUM.
4539 (decode_coding_emacs_mule): Abort if there isn't enough place in
4540 charbuf for the composition carryover bytes. Reserve an extra
4541 space for up to 2 characters produced in a loop.
4542 (decode_coding_iso_2022): Abort if there isn't enough place in
4543 charbuf for the composition carryover bytes.
4545 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4547 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4548 aborting when %lld or %lll format is passed.
4549 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4550 %llo or %llx format is passed. (Bug#8545)
4552 * window.c (window_scroll_line_based): Use a marker instead of
4553 simple variables to record original value of point. (Bug#7952)
4555 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4556 produced by %s or %c overflows available buffer space. (Bug#8545)
4558 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4560 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4561 (SIZE_MAX): Move defn after all includes, as they might #define it.
4563 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4565 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4567 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4569 * keyboard.c (Qdelayed_warnings_hook): Define.
4570 (command_loop_1): Run `delayed-warnings-hook'
4571 if Vdelayed_warnings_list is non-nil.
4572 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4573 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4575 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4577 * doprnt.c (doprnt): Don't return value smaller than the buffer
4578 size if the message was truncated. (Bug#8545).
4580 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4582 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4583 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4585 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4587 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4589 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4591 * makefile.w32-in: Update dependencies.
4593 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4595 Improve `doprnt' and its usage. (Bug#8545)
4596 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4597 `format_end'. Remove support for %l as a conversion specifier.
4598 Don't use xrealloc. Improve diagnostics when the %l size modifier
4599 is used. Update the commentary.
4601 * eval.c (verror): Simplify calculation of size_t.
4603 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4606 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4608 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4611 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4613 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4614 This makes this file independent of the recent pseudovector change.
4616 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4618 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4620 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4621 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4622 Remove unused local.
4623 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4625 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4626 GCC 4.6.0 optimizes based on type-based alias analysis.
4627 For example, if b is of type struct buffer * and v of type struct
4628 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4629 != &v->size, and therefore "v->size = 1; b->size = 2; return
4630 v->size;" must therefore return 1. This assumption is incorrect
4631 for Emacs, since it type-puns struct Lisp_Vector * with many other
4632 types. To fix this problem, this patch adds a new type struct
4633 vectorlike_header that documents the constraints on layout of vectors
4634 and pseudovectors, and helps optimizing compilers not get fooled
4635 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4636 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4637 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4639 (XSETPVECTYPE): Rewrite in terms of new macro.
4640 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4641 This is a bit clearer, and further avoids the possibility of
4642 undesirable aliasing.
4643 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4644 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4645 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4646 since Lisp_Subr is a special case (no "next" field).
4647 (ASIZE): Now uses header.size rather than size.
4648 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4649 to avoid the hassle of writing XVECTOR (foo)->header.size.
4650 (struct vectorlike_header): New type.
4651 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4652 object, to help avoid aliasing.
4653 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4654 (SUBRP): Likewise, since Lisp_Subr is a special case.
4655 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4656 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4657 (struct Lisp_Hash_Table): Combine first two members into a single
4658 struct vectorlike_header member. All uses of "size" and "next" members
4659 changed to be "header.size" and "header.next".
4660 * buffer.h (struct buffer): Likewise.
4661 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4662 * frame.h (struct frame): Likewise.
4663 * process.h (struct Lisp_Process): Likewise.
4664 * termhooks.h (struct terminal): Likewise.
4665 * window.c (struct save_window_data, struct saved_window): Likewise.
4666 * window.h (struct window): Likewise.
4667 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4668 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4669 * buffer.c (init_buffer_once): Likewise.
4670 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4672 * process.c (Fformat_network_address): Use local var for size,
4675 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4677 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4678 * data.c (atof): Remove decl; no longer used or needed.
4679 (digit_to_number): Move to lread.c.
4680 (Fstring_to_number): Use new string_to_number function, to be
4681 consistent with how the Lisp reader treats infinities and NaNs.
4682 Do not assume that floating-point numbers represent EMACS_INT
4683 without losing information; this is not true on most 64-bit hosts.
4684 Avoid double-rounding errors, by insisting on integers when
4685 parsing non-base-10 numbers, as the documentation specifies.
4686 * lisp.h (string_to_number): New decl, replacing ...
4687 (isfloat_string): Remove.
4688 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4689 (read1): Do not accept +. and -. as integers; this
4690 appears to have been a coding error. Similarly, do not accept
4691 strings like +-1e0 as floating point numbers. Do not report
4692 overflow for integer overflows unless the base is not 10 which
4693 means we have no simple and reliable way to continue.
4694 Break out the floating-point parsing into a new
4695 function string_to_number, so that Fstring_to_number parses
4696 floating point numbers consistently with the Lisp reader.
4697 (digit_to_number): Move here from data.c. Make it static inline.
4698 (E_CHAR, EXP_INT): Remove, replacing with ...
4699 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4700 (string_to_number): New function, replacing isfloat_string.
4701 This function checks for valid syntax and produces the resulting
4702 Lisp float number too. Rework it so that string-to-number
4703 no longer mishandles examples like "1.0e+". Use strtoumax,
4704 so that overflow for non-base-10 numbers is reported only when
4705 there's no portable and simple way to convert to floating point.
4707 * textprop.c (set_text_properties_1): Rewrite for clarity,
4708 and to avoid GCC warning about integer overflow.
4710 * intervals.h (struct interval): Use EMACS_INT for members
4711 where EMACS_UINT might cause problems. See
4712 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4713 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4714 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4716 (offset_intervals): Tell GCC not to worry about length overflow
4717 when negating a negative length.
4719 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4720 (overrun_check_free): Likewise.
4722 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4723 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4726 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4727 (gnutls_make_error): Rename local to avoid shadowing.
4728 (gnutls_emacs_global_deinit): ifdef out; not used.
4729 (Fgnutls_boot): Use const for pointer to readonly storage.
4730 Comment out unused local. Fix pointer signedness problems.
4732 * lread.c (openp): Don't stuff size_t into an 'int'.
4733 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4734 about possible signed overflow.
4736 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4737 (GDK_KEY_g): Don't define if already defined.
4738 (xg_prepare_tooltip): Avoid pointer signedness problem.
4739 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4741 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4742 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4744 * xfns.c (Fx_window_property): Simplify a bit,
4745 to make a bit faster and to avoid GCC 4.6.0 warning.
4746 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4748 * fns.c (internal_equal): Don't assume size_t fits in int.
4750 * alloc.c (compact_small_strings): Tighten assertion a little.
4752 Replace pEd with more-general pI, and fix some printf arg casts.
4753 * lisp.h (pI): New macro, generalizing old pEd macro to other
4754 conversion specifiers. For example, use "...%"pI"d..." rather
4755 than "...%"pEd"...".
4756 (pEd): Remove. All uses replaced with similar uses of pI.
4757 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4758 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4759 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4760 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4761 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4762 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4763 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4765 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4766 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4767 * print.c (safe_debug_print, print_object): Likewise.
4768 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4770 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4771 avoiding the 0 flag, which is not portable.
4772 * process.c (Fmake_network_process): Use pI to avoid cast.
4773 * region-cache.c (pp_cache): Likewise.
4774 * xdisp.c (decode_mode_spec): Likewise.
4775 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4776 behavior on 64-bit hosts with printf arg.
4777 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4778 (x_stop_queuing_selection_requests): Likewise.
4779 (x_get_window_property): Don't truncate byte count to an 'int'
4782 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4783 here, since it parses constructs like leading '-' and spaces,
4784 which are not wanted; and it overflows with large numbers.
4785 Instead, simply match F[0-9]+, which is what is wanted anyway.
4787 * alloc.c: Remove unportable assumptions about struct layout.
4788 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4789 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4790 (allocate_vectorlike, make_pure_vector): Use the new macros,
4791 plus offsetof, to remove unportable assumptions about struct layout.
4792 These assumptions hold on all porting targets that I know of, but
4793 they are not guaranteed, they're easy to remove, and removing them
4794 makes further changes easier.
4796 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4797 This doesn't fix a bug but makes the code clearer.
4798 (string_overrun_cookie): Now const. Use initializers that
4799 don't formally overflow signed char, to avoid warnings.
4800 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4801 can cause Emacs to crash when string overrun checking is enabled.
4802 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4803 multiple of sizeof (EMACS_INT); it need not be, if
4804 alignof(EMACS_INT) < sizeof (EMACS_INT).
4805 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4807 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4809 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4811 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4813 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4814 supposed to be handshaking. (Bug#8556)
4815 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4817 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4819 * lisp.h (Qdebug): List symbol.
4820 * eval.c (Qdebug): Restore global linkage.
4821 * keyboard.c (debug-on-event): New variable.
4822 (handle_user_signal): Break into debugger when debug-on-event
4823 matches the current signal symbol.
4825 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4827 * alloc.c (check_sblock, check_string_bytes)
4828 (check_string_free_list): Convert to standard C.
4830 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4832 * w32.c (emacs_gnutls_push): Fix typo.
4834 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4836 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4837 "cast to pointer from integer of different size".
4839 Improve doprnt and its use in verror. (Bug#8545)
4840 * doprnt.c (doprnt): Document the set of format control sequences
4841 supported by the function. Use SAFE_ALLOCA instead of always
4844 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4845 is one byte too soon. Don't use xrealloc; instead xfree and
4848 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4850 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4853 * gnutls.c: Renamed global_initialized to
4854 gnutls_global_initialized. Added internals for the
4855 :verify-hostname-error, :verify-error, and :verify-flags
4856 parameters of `gnutls-boot' and documented those parameters in the
4857 docstring. Start callback support.
4858 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4859 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4860 on error. Return error code.
4861 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4862 (emacs_gnutls_read): Likewise.
4863 (Fgnutls_boot): Return handshake error code.
4864 (emacs_gnutls_handle_error): New function.
4865 (wsaerror_to_errno): Likewise.
4867 * w32.h (emacs_gnutls_pull): Add prototype.
4868 (emacs_gnutls_push): Likewise.
4870 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4871 (emacs_gnutls_push): Likewise.
4873 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4875 * process.c (wait_reading_process_output): Check if GnuTLS
4876 buffered some data internally if no FDs are set for TLS
4879 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4880 (LIBS): Link to USER_LIBS.
4881 ($(BLD)/gnutls.$(0)): New target.
4883 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4885 * xdisp.c (handle_single_display_spec): Rename the
4886 display_replaced_before_p argument into display_replaced_p, to
4887 make it consistent with the commentary. Fix typos in the
4890 * textprop.c (syms_of_textprop): Remove dead code.
4891 (copy_text_properties): Delete obsolete commentary about an
4892 interface that was deleted long ago. Fix typos in the description
4895 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4896 to changes in oldXMenu/XMenu.h from 2011-04-16.
4897 <menu_help_message, prev_menu_help_message>: Constify.
4898 (IT_menu_make_room): menu->help_text is now `const char **';
4901 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4902 to changes in oldXMenu/XMenu.h from 2011-04-16.
4903 (struct XMenu): Declare `help_text' `const char **'.
4905 * xfaces.c <Qunspecified>: Make extern again.
4907 * syntax.c: Include sys/types.h before including regex.h, as
4910 * doc.c (get_doc_string): Improve the format passed to `error'.
4912 * doprnt.c (doprnt): Improve commentary.
4914 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4916 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4919 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4920 changes in globals.h immediately force recompilation.
4921 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4922 $(CURDIR)/s/ms-w32.h.
4923 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4925 * character.c (Fchar_direction): Function deleted.
4926 (syms_of_character): Don't defsubr it.
4927 <char-direction-table>: Deleted.
4929 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4931 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4932 * doprnt.c: Include limits.h.
4933 (SIZE_MAX): New macro.
4934 (doprnt): Return a size_t value. 2nd arg is now size_t.
4935 Many local variables are now size_t instead of int or unsigned.
4936 Improve overflow protection. Support `l' modifier for integer
4937 conversions. Support %l conversion. Don't assume an EMACS_INT
4938 argument for integer conversions and for %c.
4940 * lisp.h (doprnt): Restore prototype.
4942 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4945 * Makefile.in (base_obj): Add back doprnt.o.
4947 * deps.mk (doprnt.o): Add back prerequisites.
4948 (callint.o): Depend on character.h.
4950 * eval.c (internal_lisp_condition_case): Include the handler
4951 representation in the error message.
4952 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4953 when breaking from the loop.
4955 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4957 * callint.c (Fcall_interactively): When displaying error message
4958 about invalid control letter, pass the character's codepoint, not
4959 a pointer to its multibyte form. Improve display of the character
4960 in octal and display also its hex code.
4962 * character.c (char_string): Use %x to display the (unsigned)
4963 codepoint of an invalid character, to avoid displaying a bogus
4966 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4967 `error', not SYMBOL_NAME itself.
4969 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4970 character arguments to `error'.
4972 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4973 to `error' in error message about FINAL_CHAR argument. Make sure
4974 FINAL_CHAR is a character, and use %c when it is passed as
4975 argument to `error'.
4977 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4979 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4981 * w32.c: Include <time.h>.
4982 (sys_localtime): New function.
4984 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4986 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4988 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4990 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4992 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4995 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4997 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4998 gl_state.e_property when gl_state.object is Qt.
5000 * insdel.c (make_gap_larger): Remove limitation of buffer size
5003 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5005 * xdisp.c (lookup_glyphless_char_display)
5006 (produce_glyphless_glyph): Handle cons cell entry in
5007 glyphless-char-display.
5008 (Vglyphless_char_display): Document it.
5010 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5011 glyphless-char-display.
5013 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5015 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5017 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5019 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5020 definition for no-X builds.
5022 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5024 Static checks with GCC 4.6.0 and non-default toolkits.
5026 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5028 * process.c (keyboard_bit_set): Define only if SIGIO.
5029 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5030 (send_process): Repair possible setjmp clobbering.
5032 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5034 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5036 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5038 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5039 Define only if needed.
5041 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5042 by pacifying GCC about it. Maybe it's time to retire it?
5043 * xfaces.c (USG, __TIMEVAL__): Likewise.
5045 * dispextern.h (struct redisplay_interface): Rename param
5047 * termhooks.h (struct terminal): Likewise.
5048 * xterm.c (xembed_send_message): Likewise.
5050 * insdel.c (make_gap_smaller): Define only if
5051 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5053 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5056 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5057 so that we aren't warned about unused symbols.
5059 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5061 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5063 * xfns.c (x_real_positions): Mark locals as initialized.
5065 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5067 * xterm.c: Fix problems found by static analysis with other toolkits.
5068 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5069 (x_dispatch_event): Declare static if USE_GTK, and
5070 define if USE_GTK || USE_X_TOOLKIT.
5071 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5072 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5073 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5074 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5076 * xmenu.c (menu_help_callback): Pointer type fixes.
5077 Use const pointers when pointing at readonly data. Avoid pointer
5079 (FALSE): Remove unused macro.
5080 (update_frame_menubar): Remove unused decl.
5082 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5084 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5085 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5086 (single_menu_item): Rename local to avoid shadowing.
5088 * keyboard.c (make_lispy_event): Remove unused local var.
5090 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5091 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5093 * bitmaps: Change bitmaps from unsigned char back to the X11
5094 compatible char. Avoid the old compiler warnings about
5095 out-of-range initializers by using, for example, '\xab' rather
5098 * xgselect.c (xgselect_initialize): Check vs interface
5099 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5101 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5103 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5104 to read-only memory.
5106 * fns.c (vector): Remove; this old hack is no longer needed.
5108 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5110 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5112 * xrdb.c (x_load_resources): Omit unused local.
5114 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5115 (x_window): Rename locals to avoid shadowing.
5116 (USG): Use the kludged USG macro, to pacify gcc.
5118 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5119 (x_term_init): Remove local to avoid shadowing.
5121 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5123 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5124 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5126 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5128 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5130 Fix regex.c, syntax.c and friends for buffers > 2GB.
5131 * syntax.h (struct gl_state_s): Declare character position members
5134 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5136 * textprop.c (verify_interval_modification, interval_of):
5137 Declare arguments EMACS_INT.
5139 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5142 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5144 * indent.c (Fvertical_motion): Local variable it_start is now
5147 * regex.c (re_match, re_match_2, re_match_2_internal)
5148 (bcmp_translate, regcomp, regexec, print_double_string)
5149 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5150 (re_compile_pattern, re_exec): Declare arguments and local
5151 variables `size_t' and `ssize_t' and return values `regoff_t', as
5153 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5154 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5155 <compile_stack_type>: `size' and `avail' are now `size_t'.
5157 * regex.h <regoff_t>: Use ssize_t, not int.
5158 (re_search, re_search_2, re_match, re_match_2): Arguments that
5159 specify buffer/string position and length are now ssize_t and
5160 size_t. Return type is regoff_t.
5162 2011-04-16 Ben Key <bkey76@gmail.com>
5164 * nsfont.m: Fixed bugs in ns_get_family and
5165 ns_descriptor_to_entity that were caused by using free to
5166 deallocate memory blocks that were allocated by xmalloc (via
5167 xstrdup). This caused Emacs to crash when compiled with
5168 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5169 --enable-checking=xmallocoverrun). xfree is now used to
5170 deallocate these memory blocks.
5172 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5174 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5176 emacs_write: Accept and return EMACS_INT for sizes.
5177 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5179 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5180 Accept and return EMACS_INT.
5181 (emacs_gnutls_write): Return the number of bytes written on
5183 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5184 (emacs_read, emacs_write): Remove check for negative size, as the
5185 Emacs source code has been audited now.
5186 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5187 (emacs_read, emacs_write): Use it.
5188 * process.c (send_process): Adjust to the new signatures of
5189 emacs_write and emacs_gnutls_write. Do not attempt to store
5190 a byte offset into an 'int'; it might overflow.
5191 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5193 * sound.c: Don't assume sizes fit in 'int'.
5194 (struct sound_device.period_size, alsa_period_size):
5195 Return EMACS_INT, not int.
5196 (struct sound_device.write, vox_write, alsa_write):
5197 Accept EMACS_INT, not int.
5198 (wav_play, au_play): Use EMACS_INT to store sizes and to
5199 record read return values.
5201 2011-04-15 Ben Key <bkey76@gmail.com>
5203 * keyboard.c (Qundefined): Don't declare static since it is used
5205 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5206 static since they are used in nsfont.m.
5208 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5210 * process.c (Qprocessp): Don't declare static.
5211 * lisp.h (Qprocessp): Declare again.
5213 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5215 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5217 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5219 Improve C-level modularity by making more things 'static'.
5221 Don't publish debugger-only interfaces to other modules.
5222 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5223 (verify_bytepos, count_markers): Move decls to the only modules
5225 * region-cache.h (pp_cache): Likewise.
5226 * window.h (check_all_windows): Likewise.
5227 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5229 * sysdep.c (croak): Now static, if
5230 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5231 * syssignal.h (croak): Declare only if not static.
5233 * alloc.c (refill_memory_reserve): Now static if
5234 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5235 * lisp.h (refill_memory_reserve): Declare only if not static.
5237 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5238 Define only if USE_LUCID.
5240 * xrdb.c (x_customization_string, x_rm_string): Now static.
5242 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5243 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5245 * xdisp.c (draw_row_with_mouse_face): Now static.
5246 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5248 * window.h (check_all_windows): Mark externally visible.
5250 * window.c (window_deletion_count): Now static.
5252 * undo.c: Make symbols static if they're not exported.
5253 (last_undo_buffer, last_boundary_position, pending_boundary):
5256 * textprop.c (interval_insert_behind_hooks): Now static.
5257 (interval_insert_in_front_hooks): Likewise.
5259 * term.c: Make symbols static if they're not exported.
5260 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5261 (max_frame_lines, tty_set_terminal_modes):
5262 (tty_reset_terminal_modes, tty_turn_off_highlight):
5263 (get_tty_terminal): Now static.
5264 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5265 * termhooks.h (term_mouse_moveto): Do not declare if
5267 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5268 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5270 * sysdep.c: Make symbols static if they're not exported.
5271 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5273 (sigprocmask_set, full_mask): Remove; unused.
5274 (wait_debugging): Mark as visible.
5275 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5276 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5278 * syntax.c (syntax_temp): Define only if !__GNUC__.
5280 * sound.c (current_sound_device, current_sound): Now static.
5282 * search.c (searchbufs, searchbuf_head): Now static.
5284 * scroll.c (scroll_cost): Remove; unused.
5285 * dispextern.h (scroll_cost): Remove decl.
5287 * region-cache.h (pp_cache): Mark as externally visible.
5289 * process.c: Make symbols static if they're not exported.
5290 (process_tick, update_tick, create_process, chan_process):
5291 (Vprocess_alist, proc_buffered_char, datagram_access):
5292 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5293 (deactivate_process): Mark defn as static, as well as decl.
5294 * lisp.h (create_process): Remove decl.
5295 * process.h (chan_process, Vprocess_alist): Remove decls.
5297 * print.c: Make symbols static if they're not exported.
5298 (print_depth, new_backquote_output, being_printed, print_buffer):
5299 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5300 (print_interval, print_number_index, initial_stderr_stream):
5302 * lisp.h (Fprinc): Remove decl.
5303 (debug_output_compilation_hack): Mark as externally visible.
5305 * sysdep.c (croak): Move decl from here to syssignal.h.
5306 * syssignal.h (croak): Put it here, so the API can be checked when
5307 'croak' is called from dissociate_if_controlling_tty.
5309 * minibuf.c: Make symbols static if they're not exported.
5310 (minibuf_save_list, choose_minibuf_frame): Now static.
5311 * lisp.h (choose_minibuf_frame): Remove decl.
5313 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5315 * lread.c: Make symbols static if they're not exported.
5316 (read_objects, initial_obarray, oblookup_last_bucket_number):
5318 (make_symbol): Remove; unused.
5319 * lisp.h (initial_obarray, make_symbol): Remove decls.
5321 * keyboard.c: Make symbols static if they're not exported.
5322 (single_kboard, recent_keys_index, total_keys, recent_keys):
5323 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5324 (this_single_command_key_start, echoing, last_auto_save):
5325 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5326 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5327 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5328 (Vlispy_mouse_stem, double_click_count):
5330 (force_auto_save_soon): Define only if SIGDANGER.
5331 (ignore_mouse_drag_p): Now static if
5332 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5333 (print_help): Remove; unused.
5334 (stop_character, last_timer_event): Mark as externally visible.
5335 * keyboard.h (ignore_mouse_drag_p): Declare only if
5336 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5337 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5338 * lisp.h (echoing): Remove decl.
5339 (force_auto_save_soon): Declare only if SIGDANGER.
5340 * xdisp.c (redisplay_window): Simplify code, to make it more
5341 obvious that ignore_mouse_drag_p is not accessed if !defined
5342 USE_GTK && !defined HAVE_NS.
5344 * intervals.c: Make symbols static if they're not exported.
5345 (merge_properties_sticky, merge_interval_right, delete_interval):
5347 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5349 * insdel.c: Make symbols static if they're not exported.
5350 However, leave prepare_to_modify_buffer alone. It's never
5351 called from outside this function, but that appears to be a bug.
5352 (combine_after_change_list, combine_after_change_buffer):
5353 (adjust_after_replace, signal_before_change): Now static.
5354 (adjust_after_replace_noundo): Remove; unused.
5355 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5356 (signal_before_change): Remove decls.
5358 * indent.c (val_compute_motion, val_vmotion): Now static.
5360 * image.c: Make symbols static if they're not exported.
5361 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5363 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5364 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5366 * fringe.c (standard_bitmaps): Now static.
5367 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5369 * frame.c: Make symbols static if they're not exported.
5370 (x_report_frame_params, make_terminal_frame): Now static.
5371 (get_frame_param): Now static, unless HAVE_NS.
5372 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5373 (x_get_resource_string): Remove; not used.
5374 * frame.h (make_terminal_frame, x_report_frame_params):
5375 (x_get_resource_string); Remove decls.
5376 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5377 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5379 * font.c, fontset.c: Make symbols static if they're not exported.
5380 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5381 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5382 * font.c (font_close_object): Now static.
5383 * font.h (font_close_object): Remove.
5384 * fontset.c (FONTSET_OBJLIST): Remove.
5385 (free_realized_fontset) #if-0 the body, which does nothing.
5386 (face_suitable_for_char_p): #if-0, as it's never called.
5387 * fontset.h (face_suitable_for_char_p): Remove decl.
5388 * xfaces.c (face_at_string_position):
5389 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5390 since 0 is always ASCII.
5392 * fns.c (weak_hash_tables): Now static.
5394 * fileio.c: Make symbols static if they're not exported.
5395 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5396 (Vwrite_region_annotation_buffers): Now static.
5398 * eval.c: Make symbols static if they're not exported.
5399 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5400 * lisp.h (backtrace_list): Remove decl.
5402 * emacs.c: Make symbols static if they're not exported.
5403 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5404 (fatal_error_code, fatal_error_signal_hook, standard_args):
5406 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5407 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5408 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5409 * lisp.h (fatal_error_signal_hook): Remove decl.
5410 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5412 * editfns.c: Move a (normally-unused) function to its only use.
5413 * editfns.c, lisp.h (get_operating_system_release): Remove.
5414 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5415 worth the hassle of breaking this out.
5417 * xterm.c: Make symbols static if they're not exported.
5418 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5419 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5420 (x_destroy_window, x_delete_display):
5422 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5423 (x_mouse_leave): Remove; unused.
5424 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5425 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5426 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5428 (x_mouse_leave): Declare only if WINDOWSNT.
5429 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5430 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5433 * ftxfont.c: Make symbols static if they're not exported.
5434 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5436 * font.h (ftxfont_driver): Likewise.
5438 * xfns.c: Make symbols static if they're not exported.
5439 (x_last_font_name, x_display_info_for_name):
5440 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5441 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5442 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5443 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5444 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5445 (last_show_tip_args): Now static.
5446 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5447 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5448 (x_screen_planes): Remove; unused.
5449 * dispextern.h (x_screen_planes): Remove decl.
5451 * dispnew.c: Make symbols static if they're not exported.
5452 * dispextern.h (redraw_garbaged_frames, scrolling):
5453 (increment_row_positions): Remove.
5454 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5455 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5457 (redraw_garbaged_frames): Remove; unused.
5459 * xfaces.c: Make symbols static if they're not exported.
5460 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5462 * xterm.h (defined_color): Remove decls.
5463 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5464 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5465 (menu_face_changed_default, defined_color, free_realized_face):
5466 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5467 (ascii_face_of_lisp_face): Remove; unused.
5469 * xdisp.c: Make symbols static if they're not exported.
5470 * dispextern.h (scratch_glyph_row, window_box_edges):
5471 (glyph_to_pixel_coords, set_cursor_from_row):
5472 (get_next_display_element, set_iterator_to_next):
5473 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5474 (show_mouse_face): Remove decls
5475 * frame.h (message_buf_print): Likewise.
5476 * lisp.h (pop_message, set_message, check_point_in_composition):
5478 * xterm.h (set_vertical_scroll_bar): Likewise.
5479 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5480 (message_buf_print, scratch_glyph_row, displayed_buffer):
5481 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5482 (get_next_display_element, show_mouse_face, window_box_edges):
5483 (frame_to_window_pixel_xy, check_point_in_composition):
5484 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5485 (glyph_to_pixel_coords): Remove; unused.
5487 * dired.c (file_name_completion): Now static.
5489 * dbusbind.c (xd_in_read_queued_messages): Now static.
5491 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5492 * data.c (circular_list_error): Remove.
5494 * commands.h (last_point_position, last_point_position_buffer):
5495 (last_point_position_window): Remove decls.
5496 * keyboard.c: Make these variables static.
5498 * coding.h (coding, code_convert_region, encode_coding_gap):
5500 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5501 (iso_code_class, detect_coding, code_convert_region): Now static.
5502 (encode_coding_gap): Remove; unused.
5504 * chartab.c (chartab_chars, chartab_bits): Now static.
5506 * charset.h (charset_iso_8859_1): Remove decl.
5507 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5510 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5511 * ccl.c (Vccl_program_table): Now static.
5512 (check_ccl_update): Remove; unused.
5514 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5515 * category.h: ... from here.
5516 * category.c (check_category_table, set_category_set): Now static.
5518 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5519 * lisp.h: Remove these decls.
5521 * buffer.c (buffer_count): Remove unused var.
5523 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5524 so that it's not optimized away.
5525 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5526 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5527 exported only to the debugger.
5529 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5530 * atimer.h (run_all_atimers): Remove; not exported.
5532 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5533 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5534 was inaccessible from Lisp.
5535 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5536 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5538 alloc.c: Import and export fewer symbols, and remove unused items.
5539 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5541 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5542 it's not optimized away by whole-program optimization.
5543 (message_enable_multibyte, free_misc): Remove.
5544 (catchlist, handlerlist, mark_backtrace):
5545 Declare only if BYTE_MARK_STACK.
5546 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5547 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5548 (message_enable_multibyte): Remove decl.
5549 (free_misc, interval_free_list, float_block, float_block_index):
5550 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5551 (cons_free_list, last_marked_index):
5553 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5554 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5555 (mark_backtrace): Define only if BYTE_MARK_STACK.
5556 * xdisp.c (message_enable_multibyte): Now static.
5558 Declare Lisp_Object Q* variables to be 'static' if not exported.
5559 This makes it easier for human readers (and static analyzers)
5560 to see whether these variables are used from other modules.
5561 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5562 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5563 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5564 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5565 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5566 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5567 * xmenu.c, xselect.c:
5568 Declare Q* vars static if they are not used in other modules.
5569 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5570 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5571 Remove decls of unexported vars.
5572 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5574 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5576 Make Emacs functions such as Fatom 'static' by default.
5577 This makes it easier for human readers (and static analyzers)
5578 to see whether these functions can be called from other modules.
5579 DEFUN now defines a static function. To make the function external
5580 so that it can be used in other C modules, use the new macro DEFUE.
5581 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5582 (Finit_image_library):
5583 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5584 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5585 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5586 Remove decls, since these functions are now static.
5587 (Funintern, Fget_internal_run_time): New decls, since these functions
5588 were already external.
5590 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5591 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5592 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5593 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5594 * keyboard.c, keymap.c, lread.c:
5595 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5596 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5597 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5598 Mark functions with DEFUE instead of DEFUN,
5599 if they are used in other modules.
5600 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5601 decls for now-static functions.
5602 * buffer.h (Fdelete_overlay): Remove decl.
5603 * callproc.c (Fgetenv_internal): Mark as internal.
5604 * composite.c (Fremove_list_of_text_properties): Remove decl.
5605 (Fcomposition_get_gstring): New forward static decl.
5606 * composite.h (Fcomposite_get_gstring): Remove decl.
5607 * dired.c (Ffile_attributes): New forward static decl.
5608 * doc.c (Fdocumntation_property): New forward static decl.
5609 * eval.c (Ffetch_bytecode): New forward static decl.
5610 (Funintern): Remove extern decl; now in .h file where it belongs.
5611 * fileio.c (Fmake_symbolic_link): New forward static decl.
5612 * image.c (Finit_image_library): New forward static decl.
5613 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5614 * intervals.h (Fprevious_property_change):
5615 (Fremove_list_of_text_properties): Remove decls.
5616 * keyboard.c (Fthis_command_keys): Remove decl.
5617 (Fcommand_execute): New forward static decl.
5618 * keymap.c (Flookup_key): New forward static decl.
5619 (Fcopy_keymap): Now static.
5620 * keymap.h (Flookup_key): Remove decl.
5621 * process.c (Fget_process): New forward static decl.
5622 (Fprocess_datagram_address): Mark as internal.
5623 * syntax.c (Fsyntax_table_p): New forward static decl.
5624 (skip_chars): Remove duplicate decl.
5625 * textprop.c (Fprevious_property_change): New forward static decl.
5626 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5628 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5629 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5631 * editfns.c (Fformat): Remove unreachable code.
5633 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5635 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5638 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5640 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5641 when at ZV. (Bug#8487)
5643 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5645 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5647 * keyboard.c (parse_tool_bar_item): Likewise.
5648 * sound.c (sound_cleanup, alsa_close): Likewise.
5649 * termcap.c (tgetent): Likewise.
5650 * xfns.c (x_default_font_parameter): Likewise.
5651 * xsettings.c (read_and_apply_settings): Likewise.
5653 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5654 (overrun_check_free): Protoize.
5656 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5658 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5659 since callers should never pass a negative size.
5660 Change the signature to match that of plain 'read' and 'write'; see
5661 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5662 * lisp.h: Update prototypes of emacs_write and emacs_read.
5664 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5666 * xdisp.c (redisplay_window): Don't try to determine the character
5667 position of the scroll margin if the window start point w->startp
5668 is outside the buffer's accessible region. (Bug#8468)
5670 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5672 Fix write-region and its subroutines for buffers > 2GB.
5673 * fileio.c (a_write, e_write): Modify declaration of arguments and
5674 local variables to support buffers larger than 2GB.
5675 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5677 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5678 argument, local variables, and return value.
5680 * lisp.h: Update prototypes of emacs_write and emacs_read.
5682 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5684 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5686 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5688 Fix more problems found by GCC 4.6.0's static checks.
5690 * xdisp.c (vmessage): Use a better test for character truncation.
5692 * charset.c (load_charset_map): <, not <=, for optimization,
5693 and to avoid potential problems with integer overflow.
5694 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5695 * casetab.c (set_identity, shuffle): Likewise.
5696 * editfns.c (Fformat): Likewise.
5697 * syntax.c (skip_chars): Likewise.
5699 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5700 This also lets GCC 4.6.0 generate slightly better loop code.
5702 * callint.c (Fcall_interactively): <, not <=, for optimization.
5703 (Fcall_interactively): Count the number of arguments produced,
5704 not the number of arguments given. This is simpler and lets GCC
5705 4.6.0 generate slightly better code.
5707 * ftfont.c: Distingish more carefully between FcChar8 and char.
5708 The previous code passed unsigned char * to a functions like
5709 strlen and xstrcasecmp that expect char *, which does not
5710 conform to the C standard.
5711 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5712 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5713 char * when the C standard requires it.
5715 * keyboard.c (read_char): Remove unused var.
5717 * eval.c: Port to Windows vsnprintf (Bug#8435).
5719 (SIZE_MAX): Define if the headers do not.
5720 (verror): Do not give up if vsnprintf returns a negative count.
5721 Instead, grow the buffer. This ports to Windows vsnprintf, which
5722 does not conform to C99. Problem reported by Eli Zaretskii.
5723 Also, simplify the allocation scheme, by avoiding the need for
5724 calling realloc, and removing the ALLOCATED variable.
5726 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5728 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5729 But keep the doprint source code for now, as we might revamp it
5730 and use it again (Bug#8435).
5731 * lisp.h (doprnt): Remove.
5732 * Makefile.in (base_obj): Remove doprnt.o.
5733 * deps.mk (doprnt.o): Remove.
5735 error: Print 32- and 64-bit integers portably (Bug#8435).
5736 Without this change, on typical 64-bit hosts error ("...%d...", N)
5737 was used to print both 32- and 64-bit integers N, which relied on
5739 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5741 * lisp.h (error, verror): Mark as printf-like functions.
5742 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5743 Report overflow in size calculations when allocating printf buffer.
5744 Do not truncate output string at its first null byte.
5745 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5746 Truncate the output at a character boundary, since vsnprintf does not
5748 * charset.c (check_iso_charset_parameter): Convert internal
5749 character to string before calling 'error', since %c now has the
5751 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5752 overflow when computing char to be passed to 'error'. Do not
5753 pass Lisp_Object to 'error'; pass the integer instead.
5754 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5755 formatted with plain %d.
5757 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5759 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5761 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5763 * xterm.c (x_catch_errors): Remove duplicate declaration.
5765 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5767 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5769 2011-04-10 Jim Meyering <meyering@redhat.com>
5771 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5772 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5773 return ssize_t not "int", and use size_t as the buffer length.
5774 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5775 * gnutls.h: Update declarations.
5776 * process.c (read_process_output): Use ssize_t, to match.
5777 (send_process): Likewise.
5779 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5781 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5783 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5785 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5786 Use unsigned char, to match FcChar8 type definition.
5788 * xterm.c (handle_one_xevent):
5789 * xmenu.c (create_and_show_popup_menu):
5790 * xselect.c (x_decline_selection_request)
5791 (x_reply_selection_request): Avoid type-punned deref of X events.
5793 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5795 Fix some uses of `int' instead of EMACS_INT.
5796 * search.c (string_match_1, fast_string_match)
5797 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5798 (scan_buffer, find_next_newline_no_quit)
5799 (find_before_next_newline, search_command, Freplace_match)
5800 (Fmatch_data): Make some `int' variables be EMACS_INT.
5802 * xdisp.c (display_count_lines): 3rd argument and return value now
5803 EMACS_INT. All callers changed.
5804 (pint2hrstr): Last argument is now EMACS_INT.
5806 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5807 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5808 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5809 (decode_coding_utf_16, decode_coding_emacs_mule)
5810 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5811 (decode_coding_ccl, decode_coding_charset)
5812 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5813 (decode_coding_iso_2022, decode_coding_emacs_mule)
5814 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5815 <char_offset, last_offset>: Declare EMACS_INT.
5816 (encode_coding_utf_8, encode_coding_utf_16)
5817 (encode_coding_emacs_mule, encode_invocation_designation)
5818 (encode_designation_at_bol, encode_coding_iso_2022)
5819 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5820 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5822 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5823 (encode_invocation_designation): Last argument P_NCHARS is now
5825 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5826 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5828 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5831 * ccl.c (Fccl_execute_on_string): Declare some variables
5834 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5836 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5838 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5840 * process.c (Fformat_network_address): Doc fix.
5842 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5844 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5846 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5848 * keyboard.c (read_char): Call Lisp function help-form-show,
5849 instead of using internal_with_output_to_temp_buffer.
5850 (Qhelp_form_show): New var.
5851 (syms_of_keyboard): Use DEFSYM macro.
5853 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5855 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5857 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5859 * process.c (Flist_processes): Remove to Lisp.
5860 (list_processes_1): Delete.
5862 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5864 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5866 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5868 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5870 Fix more problems found by GCC 4.6.0's static checks.
5872 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5874 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5876 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5878 * xdisp.c (vmessage): Mark as a printf-like function.
5880 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5882 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5884 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5885 printf-like functions.
5886 (tiff_load): Add casts to remove these marks before passing them
5887 to system-supplied API.
5889 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5891 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5892 This avoids several warnings with gcc -Wstrict-overflow.
5893 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5894 directly, rather than having caller test rule sign. This avoids
5895 some unnecessary tests.
5896 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5897 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5898 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5900 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5901 (xfont_open): Avoid unnecessary tests.
5903 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5905 * composite.h, composite.c (composition_gstring_put_cache):
5906 Use EMACS_INT, not int, for length.
5908 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5909 breaking out part of COMPOSITION_DECODE_RULE.
5910 (COMPOSITION_DECODE_RULE): Use it.
5911 * composite.c (get_composition_id): Remove unused local vars,
5912 by using the new macro.
5914 * textprop.c (set_text_properties_1): Change while to do-while,
5915 since the condition is always true at first.
5917 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5918 (interval_deletion_adjustment): Return unsigned value.
5921 * process.c (list_processes_1, create_pty, read_process_output):
5922 (exec_sentinel): Remove vars that were set but not used.
5923 (create_pty): Remove unnecessary "volatile"s.
5924 (Fnetwork_interface_info): Avoid possibility of int overflow.
5925 (read_process_output): Do adaptive read buffering even if carryover.
5926 (read_process_output): Simplify nbytes computation if buffered.
5928 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5930 * syntax.c (scan_words): Remove var that was set but not used.
5931 (update_syntax_table): Use unsigned instead of int.
5933 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5934 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5935 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5937 * print.c (print_error_message): Avoid int overflow.
5939 * font.c (font_list_entities): Redo for clarity,
5940 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5942 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5943 (font_score): Avoid potential overflow in diff calculation.
5945 * fns.c (substring_both): Remove var that is set but not used.
5946 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5948 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5950 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5951 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5952 can always succeed if overflow has undefined behavior.
5954 * search.c (boyer_moore, wordify): Remove vars set but not used.
5955 (wordify): Omit three unnecessary tests.
5957 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5958 All callers changed. This avoids the need for an unused var.
5960 * casefiddle.c (casify_region): Remove var that is set but not used.
5962 * dired.c (file_name_completion): Remove var that is set but not used.
5964 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5966 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5967 (Finsert_file_contents): Remove unnecessary code checking fd.
5969 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5970 Check for integer overflow on size calculations.
5972 * buffer.c (Fprevious_overlay_change): Remove var that is set
5975 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5976 Remove vars that are set but not used.
5977 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5978 (timer_check_2): Mark vars as initialized.
5980 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5982 * image.c (lookup_image): Remove var that is set but not used.
5983 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5985 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5986 that are set but not used.
5988 * xfns.c (make_invisible_cursor): Don't return garbage
5989 if XCreateBitmapFromData fails (Bug#8410).
5991 * xselect.c (x_get_local_selection, x_handle_property_notify):
5992 Remove vars that are set but not used.
5994 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5995 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5997 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5998 Remove var that is set but not used.
5999 (scroll_bar_windows_size): Now size_t, not int.
6000 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6003 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6004 (map_tty_color) [!defined MSDOS]: Likewise.
6006 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6008 * coding.c: Remove vars that are set but not used.
6009 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6010 All callers changed.
6011 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6012 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6013 (decode_coding_charset): Remove vars that are set but not used.
6015 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6016 that is set but not used.
6018 * print.c (print_object): Remove var that is set but not used.
6020 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6021 The gnulib version avoids calling malloc in the usual case,
6022 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6023 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6024 * filelock.c (current_lock_owner): Likewise.
6025 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6026 * sysdep.c: Include allocator.h, careadlinkat.h.
6027 (emacs_no_realloc_allocator): New static constant.
6028 (emacs_readlink): New function.
6029 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6030 ../lib/careadlinkat.h.
6032 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6034 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6035 first non-nil return value).
6037 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6039 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6040 if not defined (Bug#8403).
6042 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6044 * xdisp.c (display_count_lines): Remove parameter `start',
6045 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6046 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6047 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6048 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6049 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6050 and thereabouts. All callers changed.
6051 (get_per_char_metric): Remove parameter `f', unused since
6052 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6054 2011-04-02 Jim Meyering <meyering@redhat.com>
6056 do not dereference NULL upon failed strdup
6057 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6058 (ns_get_family): Likewise.
6060 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6062 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6064 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6066 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6069 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6071 Add lexical binding.
6073 * window.c (Ftemp_output_buffer_show): New fun.
6074 (Fsave_window_excursion):
6075 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6077 * lread.c (lisp_file_lexically_bound_p): New function.
6078 (Fload): Bind Qlexical_binding.
6079 (readevalloop): Remove `evalfun' arg.
6080 Bind Qinternal_interpreter_environment.
6081 (Feval_buffer): Bind Qlexical_binding.
6082 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6084 (syms_of_lread): Declare `lexical-binding'.
6086 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6088 * keyboard.c (eval_dyn): New fun.
6089 (menu_item_eval_property): Use it.
6091 * image.c (parse_image_spec): Use Ffunctionp.
6093 * fns.c (concat, mapcar1): Accept byte-code-functions.
6095 * eval.c (Fsetq): Handle lexical vars.
6096 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6097 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6098 (FletX, Flet): Obey lexical binding.
6099 (Fcommandp): Handle closures.
6100 (Feval): New `lexical' arg.
6101 (eval_sub): New function extracted from Feval. Use it almost
6102 everywhere where Feval was used. Look up vars in lexical env.
6104 (Ffunctionp): Move from subr.el.
6105 (Ffuncall): Handle closures.
6106 (apply_lambda): Remove `eval_flags'.
6107 (funcall_lambda): Handle closures and new byte-code-functions.
6108 (Fspecial_variable_p): New function.
6109 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6110 but without exporting it to Lisp.
6112 * doc.c (Fdocumentation, store_function_docstring):
6113 * data.c (Finteractive_form): Handle closures.
6115 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6118 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6120 (exec_byte_code): New function extracted from Fbyte_code to handle new
6121 calling convention for byte-code-functions. Add new byte-codes.
6123 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6125 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6127 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6129 * xdisp.c (redisplay_internal): Fix prototype.
6131 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6133 * xdisp.c (SCROLL_LIMIT): New macro.
6134 (try_scrolling): Use it when setting scroll_limit.
6135 Limit scrolling to 100 screen lines.
6136 (redisplay_window): Even when falling back on "recentering",
6137 position point in the window according to scroll-conservatively,
6138 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6140 (try_scrolling): When point is above the window, allow searching
6141 as far as scroll_max, or one screenful, to compute vertical
6142 distance from PT to the scroll margin position. This prevents
6143 try_scrolling from unnecessarily failing when
6144 scroll-conservatively is set to a value slightly larger than the
6145 window height. Clean up the case of PT below the margin at bottom
6146 of window: scroll_max can no longer be INT_MAX. When aggressive
6147 scrolling is in use, don't let point enter the opposite scroll
6148 margin as result of the scroll.
6149 (syms_of_xdisp) <scroll-conservatively>: Document the
6150 threshold of 100 lines for never-recentering scrolling.
6152 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6154 * dispextern.h (move_it_by_lines):
6155 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6156 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6157 (message_log_check_duplicate): Remove parameters `prev_bol' and
6158 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6159 (redisplay_internal): Remove parameter `preserve_echo_area',
6160 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6162 * indent.c (Fvertical_motion):
6163 * window.c (window_scroll_pixel_based, Frecenter):
6164 Don't pass `need_y_p' to `move_it_by_lines'.
6166 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6168 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6169 steal a few bits to be more compact.
6170 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6171 Remove unneeded casts.
6173 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6175 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6177 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6178 binding" message (bug#7967).
6180 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6182 Fix more problems found by GCC 4.6.0's static checks.
6184 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6185 Remove unused local var.
6187 * editfns.c (Fmessage_box): Remove unused local var.
6189 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6190 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6191 Omit unused local vars.
6192 * window.c (shrink_windows): Omit unused local var.
6193 * menu.c (digest_single_submenu): Omit unused local var.
6194 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6195 Omit unused local var.
6197 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6198 Don't assume string length fits in int.
6199 (keyremap_step, read_key_sequence): Use size_t for sizes.
6200 (read_key_sequence): Don't check last_real_key_start redundantly.
6202 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6203 instead of alloca (Bug#8344).
6205 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6206 (Fbacktrace_frame): Don't assume nframes fits in int.
6208 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6210 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6213 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6215 * cm.c (calccost): Turn while-do into do-while, for clarity.
6217 * keyboard.c (syms_of_keyboard): Use the same style as later
6218 in this function when indexing through an array. This also
6219 works around GCC bug 48267.
6221 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6223 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6225 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6226 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6228 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6229 This avoids undefined behavior on integer overflow, and is a bit
6230 more convenient anyway since it is compared to a size_t variable.
6232 Variadic C functions now count arguments with size_t, not int.
6233 This avoids an unnecessary limitation on 64-bit machines, which
6234 caused (substring ...) to crash on large vectors (Bug#8344).
6235 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6236 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6237 All variadic functions and their callers changed accordingly.
6238 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6239 * data.c (arith_driver, float_arith_driver): Likewise.
6240 * editfns.c (general_insert_function): Likewise.
6241 * eval.c (struct backtrace.nargs, interactive_p)
6242 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6243 (funcall_lambda, mark_backtrace): Likewise.
6244 * fns.c (concat): Likewise.
6245 * frame.c (x_set_frame_parameters): Likewise.
6246 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6247 0 if not found, not -1. All callers changed.
6249 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6250 (stack_copy_size): Now size_t, not int.
6251 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6253 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6255 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6256 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6257 All callers changed.
6259 * lisp.h (multibyte_char_to_unibyte):
6260 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6261 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6262 * character.h (CHAR_TO_BYTE8):
6263 * cmds.c (internal_self_insert):
6264 * editfns.c (general_insert_function):
6265 * keymap.c (push_key_description):
6266 * search.c (Freplace_match):
6267 * xdisp.c (message_dolog, set_message_1): All callers changed.
6269 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6271 * keyboard.c (safe_run_hook_funcall): New function.
6272 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6273 don't set the hook to nil, but remove the offending function instead.
6274 (Qcommand_hook_internal): Remove, unused.
6275 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6276 Vcommand_hook_internal.
6278 * eval.c (enum run_hooks_condition): Remove.
6279 (funcall_nil, funcall_not): New functions.
6280 (run_hook_with_args): Call each function through a `funcall' argument.
6281 Remove `cond' argument, now redundant.
6282 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6283 (Frun_hook_with_args_until_failure): Adjust accordingly.
6284 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6286 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6288 * dispextern.h (string_buffer_position): Remove declaration.
6290 * print.c (strout): Remove parameter `multibyte', unused since
6291 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6293 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6294 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6295 All callers changed.
6297 * w32.c (_wsa_errlist): Use braces for struct initializers.
6299 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6300 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6301 All callers changed.
6302 (string_buffer_position): Likewise. Also, make static (it's never
6303 used outside xdisp.c).
6304 (cursor_row_p): Remove parameter `w', unused since
6305 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6306 (decode_mode_spec): Remove parameter `precision', introduced during
6307 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6308 All callers changed.
6310 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6312 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6314 2011-03-27 Anders Lindgren <andlind@gmail.com>
6316 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6317 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6318 (ns_update_auto_hide_menu_bar): New functions.
6319 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6320 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6321 ns_constrain_all_frames.
6322 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6323 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6325 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6327 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6329 2011-03-27 Glenn Morris <rgm@gnu.org>
6331 * syssignal.h: Replace RETSIGTYPE with void.
6332 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6333 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6334 Replace SIGTYPE with void everywhere.
6335 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6336 * s/template.h (SIGTYPE): Remove commented out definition.
6338 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6340 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6341 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6343 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6345 * w32.c (read_unc_volume): Use parameter `henum', instead of
6346 global variable `wget_enum_handle'.
6348 * keymap.c (describe_vector): Remove parameters `indices' and
6349 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6350 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6352 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6354 * keyboard.c (timer_check): Remove parameter `do_it_now',
6355 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6356 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6357 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6359 * keyboard.c (read_char):
6360 * w32menu.c (w32_menu_display_help):
6361 * xmenu.c (show_help_event, menu_help_callback):
6362 Adjust calls to `show_help_echo'.
6364 * gtkutil.c (xg_maybe_add_timer):
6365 * keyboard.c (readable_events):
6366 * process.c (wait_reading_process_output):
6367 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6369 * insdel.c (adjust_markers_gap_motion):
6370 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6371 (gap_left, gap_right): Don't call it.
6373 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6375 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6376 incurred during fontification.
6378 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6380 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6381 (DEFVAR_PER_BUFFER): Don't pass it.
6383 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6384 (scrolling_window): Don't pass it.
6386 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6388 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6390 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6392 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6393 of variables specific to SELinux and computation of `encoded_absname'.
6395 * image.c (XPutPixel): Remove unused variable `height'.
6397 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6399 * unexw32.c (get_section_info): Remove unused variable `section'.
6401 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6402 (system_process_attributes): Remove unused variable `sess'.
6403 (sys_read): Remove unused variable `err'.
6405 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6406 (w32_wnd_proc): Remove unused variable `isdead'.
6407 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6408 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6409 (x_create_tip_frame): Remove unused variable `tem'.
6411 * w32inevt.c (w32_console_read_socket):
6412 Remove unused variable `no_events'.
6414 * w32term.c (x_draw_composite_glyph_string_foreground):
6415 Remove unused variable `width'.
6417 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6419 * w32term.c (x_set_glyph_string_clipping):
6420 Don't pass uninitialized region to CombineRgn.
6422 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6424 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6425 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6426 (Fx_close_connection): Remove unused variable `i'.
6428 * w32font.c (w32font_draw): Return number of glyphs.
6429 (w32font_open_internal): Remove unused variable `i'.
6430 (w32font_driver): Add missing initializer.
6432 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6433 (fill_in_menu): Remove unused variable `items_added'.
6435 * w32term.c (last_mouse_press_frame): Remove static global variable.
6436 (w32_clip_to_row): Remove unused variable `f'.
6437 (x_delete_terminal): Remove unused variable `i'.
6439 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6440 (NOTHING): Remove unused static global variable.
6441 (uniscribe_check_otf): Remove unused variable `table'.
6442 (uniscribe_font_driver): Add missing initializers.
6444 2011-03-23 Julien Danjou <julien@danjou.info>
6446 * term.c (Fsuspend_tty, Fresume_tty):
6447 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6448 * window.c (temp_output_buffer_show):
6449 * insdel.c (signal_before_change):
6450 * frame.c (Fhandle_switch_frame):
6451 * fileio.c (Fdo_auto_save):
6452 * emacs.c (Fkill_emacs):
6453 * editfns.c (save_excursion_restore):
6454 * cmds.c (internal_self_insert):
6455 * callint.c (Fcall_interactively):
6456 * buffer.c (Fkill_all_local_variables):
6457 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6459 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6460 unconditionnaly since it does the check itself.
6462 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6464 Fix more problems found by GCC 4.5.2's static checks.
6466 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6467 the first time through the loop, since we know p0 < p1 then.
6468 This also avoids a gcc -Wstrict-overflow warning.
6470 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6471 leading to a memory leak, possible in functions like
6472 load_charset_map_from_file that can allocate an unbounded number
6473 of objects (Bug#8318).
6475 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6476 that could (at least in theory) be that large.
6478 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6479 This is less likely to overflow, and avoids undefined behavior if
6480 overflow does occur. All callers changed. Use strtoul to scan
6481 for the unsigned long integer.
6482 (pint2hrstr): Simplify and tune code slightly.
6483 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6485 * scroll.c (do_scrolling): Work around GCC bug 48228.
6486 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6488 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6489 This also avoids a warning with gcc -Wstrict-overflow.
6490 (validate_x_resource_name): Simplify count usage.
6491 This also avoids a warning with gcc -Wstrict-overflow.
6493 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6496 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6498 * process.c (Fmake_network_process): Use socklen_t, not int,
6499 where POSIX says socklen_t is required in portable programs.
6500 This fixes a porting bug on hosts like 64-bit HP-UX, where
6501 socklen_t is wider than int (Bug#8277).
6502 (Fmake_network_process, server_accept_connection):
6503 (wait_reading_process_output, read_process_output):
6506 * process.c: Rename or move locals to avoid shadowing.
6507 (list_processes_1, Fmake_network_process):
6508 (read_process_output_error_handler, exec_sentinel_error_handler):
6509 Rename or move locals.
6510 (Fmake_network_process): Define label "retry_connect" only if needed.
6511 (Fnetwork_interface_info): Fix pointer signedness.
6512 (process_send_signal): Add cast to avoid pointer signedness problem.
6513 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6514 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6516 Make tparam.h and terminfo.c consistent.
6517 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6518 Include tparam.h instead, since it declares them.
6519 * cm.h (PC): Remove extern decl; tparam.h now does this.
6520 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6521 * terminfo.c: Include tparam.h, to check interfaces.
6522 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6523 (tparam): Adjust signature to match interface in tparam.h;
6524 this removes some undefined behavior. Check that outstring and len
6525 are zero, which they always are with Emacs.
6526 * tparam.h (PC, BC, UP): New extern decls.
6528 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6529 (xftfont_open): Rename locals to avoid shadowing.
6531 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6532 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6533 (OTF_TAG_SYM): Omit macro if not needed.
6534 (ftfont_list): Remove unused local.
6535 (get_adstyle_property, ftfont_pattern_entity):
6536 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6537 Rename locals to avoid shadowing.
6539 * xfont.c (xfont_list_family): Mark var as initialized.
6541 * xml.c (make_dom): Now static.
6543 * composite.c (composition_compute_stop_pos): Rename local to
6545 (composition_reseat_it): Remove unused locals.
6546 (find_automatic_composition, composition_adjust_point): Likewise.
6547 (composition_update_it): Mark var as initialized.
6548 (find_automatic_composition): Mark vars as initialized,
6549 with a FIXME (Bug#8290).
6551 character.h: Rename locals to avoid shadowing.
6552 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6553 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6554 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6555 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6558 * textprop.c (property_change_between_p): Remove; unused.
6560 * intervals.c (interval_start_pos): Now static.
6562 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6564 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6565 Rename locals to avoid shadowing.
6567 * sound.c (wav_play, au_play, Fplay_sound_internal):
6568 Fix pointer signedness.
6569 (alsa_choose_format): Remove unused local var.
6570 (wav_play): Initialize a variable to 0, to prevent undefined
6571 behavior (Bug#8278).
6573 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6575 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6577 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6578 clobbering (Bug#8298).
6579 * sysdep.c (sys_subshell): Likewise.
6580 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6582 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6583 This should get cleaned up, so that child_setup has the
6584 same signature on all platforms.
6586 * callproc.c (call_process_cleanup): Now static.
6587 (relocate_fd): Rename locals to avoid shadowing.
6589 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6591 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6592 not to be necessary, and produces flickering.
6594 2011-03-20 Glenn Morris <rgm@gnu.org>
6596 * config.in: Remove file.
6598 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6600 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6601 are now in src/globals.h.
6602 (syms_of_minibuf): Remove spurious & from previous change.
6604 2011-03-20 Leo <sdl.web@gmail.com>
6606 * minibuf.c (completing-read-function): New variable.
6607 (completing-read-default): Rename from completing-read.
6608 (completing-read): Call completing-read-function.
6610 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6612 * xfaces.c (Fx_load_color_file):
6613 Read color file from absolute filename (bug#8250).
6615 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6617 * makefile.w32-in: Update dependencies.
6619 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6621 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6623 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6625 Fix more problems found by GCC 4.5.2's static checks.
6627 * process.c (make_serial_process_unwind, send_process_trap):
6628 (sigchld_handler): Now static.
6630 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6631 That way, the code declares only the vars that it needs.
6632 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6633 * s/cygwin.h (PTY_ITERATION): Likewise.
6634 * s/darwin.h (PTY_ITERATION): Likewise.
6635 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6637 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6638 * process.c (allocate_pty): Don't declare stb unless it's needed.
6640 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6641 (CONSTANTLIM): Remove; unused.
6642 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6643 Define only if needed.
6645 * unexelf.c (unexec): Name an expression,
6646 to avoid gcc -Wbad-function-cast warning.
6647 Use a different way to cause a compilation error if anyone uses
6648 n rather than nn, a way that does not involve shadowing.
6649 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6651 * deps.mk (unexalpha.o): Remove; unused.
6653 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6654 * unexec.h: New file.
6655 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6656 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6658 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6659 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6660 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6661 Change as necessary to match prototype in unexec.h.
6663 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6665 (back_comment, skip_chars): Mark vars as initialized.
6667 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6668 Rename locals to avoid shadowing.
6670 * lread.c (read1): Rewrite so as not to use empty "else".
6671 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6673 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6675 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6676 warning when compiling print.c.
6678 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6679 instead of using an uninitialized var.
6680 (font_sort_entities): Mark var as initialized.
6682 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6684 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6685 pointers to constants.
6686 (font_parse_fcname): Remove unused vars.
6687 (font_delete_unmatched): Now static.
6688 (font_get_spec): Remove; unused.
6689 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6690 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6691 Rename or move locals to avoid shadowing.
6693 * fns.c (require_nesting_list, require_unwind): Now static.
6694 (Ffillarray): Rename locals to avoid shadowing.
6696 * floatfns.c (domain_error2): Define only if needed.
6697 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6699 * alloc.c (mark_backtrace): Move decl from here ...
6700 * lisp.h: ... to here, so that it can be checked.
6702 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6703 (Fdefvar): Rewrite so as not to use empty "else".
6704 (lisp_indirect_variable): Name an expression,
6705 to avoid gcc -Wbad-function-cast warning.
6706 (Fdefvar): Rename locals to avoid shadowing.
6708 * callint.c (quotify_arg, quotify_args): Now static.
6709 (Fcall_interactively): Rename locals to avoid shadowing.
6710 Use const pointer when appropriate.
6712 * lisp.h (get_system_name, get_operating_system_release):
6713 Move decls here, to check interfaces.
6714 * process.c (get_operating_system_release): Move decl to lisp.h.
6715 * xrdb.c (get_system_name): Likewise.
6716 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6717 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6718 some of which prompt warnings from gcc -Wbad-function-cast.
6719 (Fformat_time_string, Fencode_time, Finsert_char):
6720 (Ftranslate_region_internal, Fformat):
6721 Rename or remove local vars to avoid shadowing.
6722 (Ftranslate_region_internal): Mark var as initialized.
6724 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6727 * lisp.h (eassert): Check that the argument compiles, even if
6728 ENABLE_CHECKING is not defined.
6730 * data.c (Findirect_variable): Name an expression, to avoid
6731 gcc -Wbad-function-cast warning.
6732 (default_value, arithcompare, arith_driver, arith_error): Now static.
6733 (store_symval_forwarding): Rename local to avoid shadowing.
6734 (Fmake_variable_buffer_local, Fmake_local_variable):
6735 Mark variables as initialized.
6736 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6738 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6739 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6740 Rename locals to avoid shadowing.
6741 (mark_stack): Move local variables into the #ifdef region where
6743 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6744 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6746 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6747 (GC_STRING_CHARS): Remove; not used.
6748 (Fmemory_limit): Cast sbrk's returned value to char *.
6750 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6751 avoids undefined behavior in theory.
6753 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6755 Use functions, not macros, for up- and down-casing (Bug#8254).
6756 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6757 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6758 to use the following functions instead of these macros.
6759 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6760 EMACS_INT, since callers assume the returned value fits in int.
6761 (upcase1): Likewise, for UPCASE_TABLE.
6762 (uppercasep, lowercasep, upcase): New static inline functions.
6763 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6764 the race-condition problem in the old DOWNCASE.
6766 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6767 Rename locals to avoid shadowing.
6768 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6769 (regex_compile, re_search_2, re_match_2_internal):
6770 Remove unused local vars.
6771 (FREE_VAR): Rewrite so as not to use empty "else",
6772 which gcc can warn about.
6773 (regex_compile, re_match_2_internal): Mark locals as initialized.
6774 (RETALLOC_IF): Define only if needed.
6775 (WORDCHAR_P): Likewise. This one is never needed, but is used
6776 only in a comment talking about a compiler bug, so put inside
6777 the #if 0 of that comment.
6778 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6779 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6782 * search.c (boyer_moore): Rename locals to avoid shadowing.
6783 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6784 (PREV_CHAR_BOUNDARY): Likewise.
6786 * search.c (simple_search): Remove unused var.
6788 * dired.c (compile_pattern): Move decl from here ...
6789 * lisp.h: ... to here, so that it can be checked.
6790 (struct re_registers): New forward decl.
6792 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6794 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6796 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6797 Rename locals to avoid shadowing.
6798 (Fvertical_motion): Mark locals as initialized.
6800 * casefiddle.c (casify_object, casify_region): Now static.
6801 (casify_region): Mark local as initialized.
6803 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6805 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6806 New macros, so that the caller can use some names other than
6807 gcpro1, gcpro2, etc.
6808 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6810 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6811 argument, for consistency with GCPRO2_VAR, etc: it is now the
6812 prefix of the variable, not the variable itself. All uses
6814 * dired.c (directory_files_internal, file_name_completion):
6815 Rename locals to avoid shadowing.
6817 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6818 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6819 dired.c's scmp function, had undefined behavior.
6820 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6821 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6822 * buffer.h: ... to here, because these macros use current_buffer,
6823 and the new implementation with inline functions needs to have
6824 current_buffer in scope now, rather than later when the macros
6826 (downcase, upcase1): New static inline functions.
6827 (DOWNCASE, UPCASE1): Reimplement using these functions.
6828 This avoids undefined behavior in expressions like
6829 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6830 from race conditions in accessing the global variables
6831 case_temp1 and case_temp2.
6832 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6833 * lisp.h (case_temp1, case_temp2): Remove their decls.
6834 * character.h (ASCII_CHAR_P): Move from here ...
6835 * lisp.h: ... to here, so that the inline functions mentioned
6838 * dired.c (directory_files_internal_unwind): Now static.
6840 * fileio.c (file_name_as_directory, directory_file_name):
6841 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6843 (file_name_as_directory): Use const pointers when appropriate.
6844 (Fexpand_file_name): Likewise. In particular, newdir might
6845 point at constant storage, so make it a const pointer.
6846 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6847 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6849 (Fset_file_times, Finsert_file_contents, auto_save_error):
6850 Rename locals to avoid shadowing.
6852 * minibuf.c (choose_minibuf_frame_1): Now static.
6853 (Ftry_completion, Fall_completions): Rename or remove locals
6856 * marker.c (bytepos_to_charpos): Remove; unused.
6858 * lisp.h (verify_bytepos, count_markers): New decls,
6859 so that gcc does not warn that these functions aren't declared.
6861 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6862 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6863 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6864 (copy_text): Remove unused local var.
6866 * filelock.c (within_one_second): Now static.
6867 (lock_file_1): Rename local to avoid shadowing.
6869 * buffer.c (fix_overlays_before): Mark locals as initialized.
6870 (fix_start_end_in_overlays): Likewise. This function should be
6871 simplified by using pointers-to-pointers, but that's a different
6873 (switch_to_buffer_1): Now static.
6874 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6875 (report_overlay_modification): Rename locals to avoid shadowing.
6877 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6878 Fix pointer signedness issue.
6879 (sys_subshell): Mark local as volatile if checking for lint,
6880 to suppress a gcc -Wclobbered warning that does not seem to be right.
6881 (MAXPATHLEN): Define only if needed.
6883 * process.c (serial_open, serial_configure): Move decls from here ...
6884 * systty.h: ... to here, so that they can be checked.
6886 * fns.c (get_random, seed_random): Move extern decls from here ...
6887 * lisp.h: ... to here, so that they can be checked.
6889 * sysdep.c (reset_io): Now static.
6890 (wait_for_termination_signal): Remove; unused.
6892 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6893 (copy_keymap_item, append_key, push_text_char_description):
6895 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6896 (DENSE_TABLE_SIZE): Remove; unused.
6897 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6898 (describe_map_tree):
6899 Rename locals to avoid shadowing.
6901 * keyboard.c: Declare functions static if they are not used elsewhere.
6902 (echo_char, echo_dash, cmd_error, top_level_2):
6903 (poll_for_input, handle_async_input): Now static.
6904 (read_char, kbd_buffer_get_event, make_lispy_position):
6905 (make_lispy_event, make_lispy_movement, apply_modifiers):
6906 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6907 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6908 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6909 (read_key_sequence, read_char): Mark locals as initialized.
6910 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6912 * keyboard.h (make_ctrl_char): New decl.
6913 (mark_kboards): Move decl here ...
6914 * alloc.c (mark_kboards): ... from here.
6916 * lisp.h (force_auto_save_soon): New decl.
6918 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6919 (DEFINE_DUMMY_FUNCTION): New macro.
6920 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6922 (main): Add casts to avoid warnings
6923 if GCC considers string literals to be constants.
6925 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6927 * dbusbind.c: Pointer signedness fixes.
6928 (xd_signature, xd_append_arg, xd_initialize):
6929 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6930 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6931 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6932 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6934 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6935 if GCC considers string literals to be constants.
6936 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6938 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6940 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6941 (print_preprocess, print_object): New macro to fix last change.
6943 * print.c (print_preprocess): Don't forget font objects.
6945 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6947 * emacs.c (USAGE3): Doc fixes.
6949 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6951 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6954 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6956 * lisp.h (VWindow_system, Qfile_name_history):
6957 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6958 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6959 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6961 * w32select.c: Don't #include "keyboard.h".
6962 (run_protected): Add extern declaration for waiting_for_input.
6964 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6965 * w32console.c (detect_input_pending, read_input_pending)
6966 (encode_terminal_code):
6967 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6968 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6969 (w32_system_caret_y, Qfile_name_history):
6970 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6971 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6972 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6973 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6974 * w32proc.c (Qlocal, report_file_error):
6975 * w32term.c (Vwindow_system, updating_frame):
6976 * w32uniscribe.c (initialized, uniscribe_font_driver):
6977 Remove unneeded extern declarations.
6979 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6981 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6983 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6985 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6986 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6987 These macros can no longer be used for assignment.
6989 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6990 Assign struct members directly, instead of using BUF_BEGV etc.
6991 (record_buffer_markers, fetch_buffer_markers): New functions for
6992 recording and fetching special buffer markers.
6993 (set_buffer_internal_1, set_buffer_temp): Use them.
6995 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6997 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6999 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7000 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7002 * xdisp.c (hscroll_window_tree):
7003 (reconsider_clip_changes): Use PT instead of BUF_PT.
7005 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7007 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7008 $(EMACS_ROOT)/lib/intprops.h.
7010 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7012 Fix more problems found by GCC 4.5.2's static checks.
7014 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7015 to unsigned char * to avoid compiler diagnostic.
7016 (xg_free_frame_widgets): Make it clear that a local variable is
7017 needed only if USE_GTK_TOOLTIP.
7018 (gdk_window_get_screen): Make it clear that this macro is needed
7019 only if USE_GTK_TOOLTIP.
7020 (int_gtk_range_get_value): New function, which avoids a diagnostic
7021 from gcc -Wbad-function-cast.
7022 (xg_set_toolkit_scroll_bar_thumb): Use it.
7023 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7024 diagnostic from gcc -Wbad-function-cast.
7025 (get_utf8_string, xg_get_file_with_chooser):
7026 Rename locals to avoid shadowing.
7027 (create_dialog): Move locals to avoid shadowing.
7029 * xgselect.c (xg_select): Remove unused var.
7031 * image.c (four_corners_best): Mark locals as initialized.
7032 (gif_load): Initialize transparent_p to zero (Bug#8238).
7033 Mark another local as initialized.
7034 (my_png_error, my_error_exit): Mark with NO_RETURN.
7036 * image.c (clear_image_cache): Now static.
7037 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7038 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7039 (x_edge_detection): Remove unnecessary cast that
7040 gcc -Wbad-function-cast diagnoses.
7041 (gif_load): Fix pointer signedness.
7042 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7043 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7045 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7047 Improve quality of tests for time stamp overflow.
7048 For example, without this patch (encode-time 0 0 0 1 1
7049 1152921504606846976) returns the obviously-bogus value (-948597
7050 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7051 reports time overflow. See
7052 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7053 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7054 * editfns.c: Include limits.h and intprops.h.
7055 (TIME_T_MIN, TIME_T_MAX): New macros.
7056 (time_overflow): Move earlier, to before first use.
7057 (hi_time, lo_time): New functions, for an accurate test for
7059 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7060 (Fget_internal_run_time): Don't assume time_t fits in int.
7061 (make_time): Use list2 instead of Fcons twice.
7062 (Fdecode_time): More accurate test for out-of-range times.
7063 (check_tm_member): New function.
7064 (Fencode_time): Use it, to test for out-of-range times.
7065 (lisp_time_argument): Don't rely on undefined left-shift and
7066 right-shift behavior when checking for time stamp overflow.
7068 * editfns.c (time_overflow): New function, refactoring common code.
7069 (Fformat_time_string, Fdecode_time, Fencode_time):
7070 (Fcurrent_time_string): Use it.
7072 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7073 * dired.c (make_time): Move to ...
7074 * editfns.c (make_time): ... here.
7075 * systime.h: Note the move.
7077 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7079 * fringe.c (update_window_fringes): Remove unused variables.
7081 * unexmacosx.c (copy_data_segment): Also copy __got section.
7084 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7086 * termcap.c [MSDOS]: Include "msdos.h".
7087 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7088 Constify `char *' arguments and their references according to
7089 prototypes in tparam.h.
7091 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7093 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7094 Adapt all references accordingly.
7096 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7098 2011-03-11 Tom Tromey <tromey@redhat.com>
7100 * buffer.c (syms_of_buffer): Remove obsolete comment.
7102 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7104 * termhooks.h (encode_terminal_code): Declare prototype.
7106 * msdos.c (encode_terminal_code): Don't declare prototype.
7108 * term.c (encode_terminal_code): Now external again, used by
7109 w32console.c and msdos.c.
7111 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7112 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7114 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7116 Fix some minor problems found by GCC 4.5.2's static checks.
7118 * fringe.c (update_window_fringes): Mark locals as initialized
7120 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7122 * alloc.c (mark_fringe_data): Move decl from here ...
7123 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7124 to check its interface.
7125 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7127 * fontset.c (free_realized_fontset): Now static.
7128 (Fset_fontset_font): Rename local to avoid shadowing.
7129 (fontset_font): Mark local as initialized.
7130 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7132 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7134 * xselect.c (x_disown_buffer_selections): Remove; not used.
7135 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7136 (x_own_selection, Fx_disown_selection_internal): Rename locals
7138 (x_handle_dnd_message): Remove local to avoid shadowing.
7140 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7141 so that the caller can use some name other than gcpro1.
7142 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7143 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7144 (Fx_backspace_delete_keys_p):
7145 Use them to avoid shadowing, and rename vars to avoid shadowing.
7146 (x_decode_color, x_set_name, x_window): Now static.
7147 (Fx_create_frame): Add braces to silence GCC warning.
7148 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7149 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7150 Remove unused locals.
7151 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7152 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7153 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7156 * xterm.h (x_mouse_leave): New decl.
7158 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7159 Remove unused functions.
7160 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7161 (x_calc_absolute_position): Now static.
7162 (XTread_socket): Don't define label "out" unless it's used.
7163 Don't declare local "event" unless it's used.
7164 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7165 unless they are used.
7166 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7167 (x_fatal_error_signal): Remove; not used.
7168 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7169 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7170 (x_error_catcher, x_connection_closed, x_error_handler):
7171 (x_error_quitter, xembed_send_message, x_iconify_frame):
7172 (my_log_handler): Rename locals to avoid shadowing.
7173 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7174 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7176 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7177 Rename or move locals to avoid shadowing.
7178 (tty_defined_color, merge_face_heights): Now static.
7179 (free_realized_faces_for_fontset): Remove; not used.
7180 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7181 does not deduce is never used uninitialized.
7182 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7183 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7185 * terminal.c (store_terminal_param): Now static.
7187 * xmenu.c (menu_highlight_callback): Now static.
7188 (set_frame_menubar): Remove unused local.
7189 (xmenu_show): Rename parameter to avoid shadowing.
7190 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7191 since they might point to immutable storage.
7192 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7193 since it's unused otherwise.
7195 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7196 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7197 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7198 avoids a gcc -Wuninitialized diagnostic.
7199 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7200 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7201 does not deduce are never used uninitialized.
7203 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7205 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7206 * window.c (window_loop, size_window):
7207 (run_window_configuration_change_hook, enlarge_window): Likewise.
7209 * window.c (display_buffer): Now static.
7210 (size_window): Mark variables that gcc -Wuninitialized
7211 does not deduce are never used uninitialized.
7212 * window.h (check_all_windows): New decl, to forestall
7213 gcc -Wmissing-prototypes diagnostic.
7214 * dispextern.h (bidi_dump_cached_states): Likewise.
7216 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7218 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7220 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7221 and to avoid gcc -Wuninitialized warning.
7222 (load_charset_map): Mark variables that gcc -Wuninitialized
7223 does not deduce are never used uninitialized.
7224 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7226 * coding.c (coding_set_source, coding_set_destination):
7227 Use "else { /* comment */ }" rather than "else /* comment */;"
7228 for clarity, and to avoid gcc -Wempty-body warning.
7229 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7230 a block, when the outer 'i' will do.
7231 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7232 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7233 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7234 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7235 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7236 Rename locals to avoid shadowing.
7237 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7238 * coding.c (emacs_mule_char, encode_invocation_designation):
7239 Now static, since they're not used elsewhere.
7240 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7241 (decode_coding_object, encode_coding_object, detect_coding_system):
7242 (decode_coding_emacs_mule): Mark variables that gcc
7243 -Wuninitialized does not deduce are never used uninitialized.
7244 (detect_coding_iso_2022): Initialize a local variable that might
7245 be used uninitialized. Leave a FIXME because it's not clear that
7246 this initialization is needed. (Bug#8211)
7247 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7248 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7249 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7250 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7251 Remove unused macros.
7253 * category.c (hash_get_category_set): Remove unused local var.
7254 (copy_category_table): Now static, since it's not used elsewhere.
7255 * character.c (string_count_byte8): Likewise.
7257 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7258 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7260 * chartab.c (copy_sub_char_table): Now static, since it's not used
7262 (sub_char_table_ref_and_range, char_table_ref_and_range):
7263 Rename locals to avoid shadowing.
7264 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7266 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7267 (BIDI_BOB): Remove unused macro.
7269 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7270 deduce are never used uninitialized.
7271 * term.c (encode_terminal_code): Likewise.
7273 * term.c (encode_terminal_code): Now static. Remove unused local.
7275 * tparam.h: New file.
7276 * term.c, tparam.h: Include it.
7277 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7278 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7279 Move these decls to tparam.h, and make them agree with what
7280 is actually in tparam.c. The previous trick of using incompatible
7281 decls in different modules does not conform to the C standard.
7282 All callers of tparam changed to use tparam's actual API.
7283 * tparam.c (tparam1, tparam, tgoto):
7284 Use const pointers where appropriate.
7286 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7287 * cm.h (struct cm): Likewise.
7288 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7289 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7290 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7291 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7292 (turn_on_face, init_tty): Likewise.
7293 * termchar.h (struct tty_display_info): Likewise.
7295 * term.c (term_mouse_position): Rename local to avoid shadowing.
7297 * alloc.c (mark_ttys): Move decl from here ...
7298 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7300 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7302 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7304 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7306 * search.c (compile_pattern_1): Remove argument regp, unused since
7307 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7308 (compile_pattern): Don't pass it.
7310 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7312 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7313 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7315 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7317 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7319 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7320 gdk_window_get_screen, gdk_window_get_geometry,
7321 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7322 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7323 (xg_get_pixbuf_from_pixmap): New function.
7324 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7325 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7326 Call xg_get_pixbuf_from_pixmap instead of
7327 gdk_pixbuf_get_from_drawable.
7328 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7329 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7330 (xg_check_special_colors): Use GtkStyleContext and its functions
7332 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7333 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7334 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7335 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7336 Call gtk_widget_get_preferred_size.
7337 (xg_frame_resized): gdk_window_get_geometry only takes 5
7339 (xg_win_to_widget, xg_event_is_for_menubar):
7340 Call gdk_x11_window_lookup_for_display.
7341 (xg_set_widget_bg): New function.
7342 (delete_cb): New function.
7343 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7344 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7345 (xg_set_background_color): Call xg_set_widget_bg.
7346 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7347 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7348 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7349 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7351 (update_frame_tool_bar): Call gtk_widget_hide.
7352 (xg_initialize): Use GDK_KEY_g.
7354 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7356 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7358 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7359 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7360 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7362 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7364 * w32xfns.c (select_palette): Check success of RealizePalette against
7365 GDI_ERROR, not zero.
7367 See ChangeLog.11 for earlier changes.
7373 Copyright (C) 2011 Free Software Foundation, Inc.
7375 This file is part of GNU Emacs.
7377 GNU Emacs is free software: you can redistribute it and/or modify
7378 it under the terms of the GNU General Public License as published by
7379 the Free Software Foundation, either version 3 of the License, or
7380 (at your option) any later version.
7382 GNU Emacs is distributed in the hope that it will be useful,
7383 but WITHOUT ANY WARRANTY; without even the implied warranty of
7384 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7385 GNU General Public License for more details.
7387 You should have received a copy of the GNU General Public License
7388 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.