GLYPH_DEBUG fixes
[bpt/emacs.git] / src / ChangeLog
1 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2
3 GLYPH_DEBUG fixes
4 The following patches are for when GLYPH_DEBUG && !XASSERT.
5 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6 * dispnew.c (flush_stdout):
7 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8 Mark as externally visible.
9 * dispnew.c (check_window_matrix_pointers): Now static.
10 * dispnew.c (window_to_frame_vpos):
11 * xfns.c (unwind_create_frame):
12 * xterm.c (x_check_font): Remove unused local.
13 * scroll.c (CHECK_BOUNDS):
14 * xfaces.c (cache_fache): Rename local to avoid shadowing.
15 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
16 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
17 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
18 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
19 Now static.
20 (debug_method_add): Use va_list and vsprintf rather than relying
21 on undefined behavior with wrong number of arguments.
22 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
23 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
24 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
25 since we're not interested in debugging glyphs with old libraries.
26 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
27 GCC 4.6.0's static checking.
28
29 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
30
31 Integer overflow and signedness fixes (Bug#8873).
32 A few related buffer overrun fixes, too.
33
34 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
35
36 * dispextern.h (struct face.stipple):
37 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
38 (x_bitmap_mask, x_allocate_bitmap_record)
39 (x_create_bitmap_from_data, x_create_bitmap_from_file)
40 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
41 (x_create_bitmap_from_xpm_data):
42 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
43 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
44 (.bitmaps_last):
45 * xfaces.c (load_pixmap):
46 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
47 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
48 (.bitmaps_last, struct x_output.icon_bitmap):
49 Use ptrdiff_t, not int, for bitmap indexes.
50 (x_allocate_bitmap_record): Check for size overflow.
51 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
52
53 Use ptrdiff_t, not int, for overlay counts.
54 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
55 * editfns.c (overlays_around, get_pos_property):
56 * textprop.c (get_char_property_and_overlay):
57 * xdisp.c (next_overlay_change, note_mouse_highlight):
58 * xfaces.c (face_at_buffer_position):
59 * buffer.c (OVERLAY_COUNT_MAX): New macro.
60 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
61 (Fnext_overlay_change, Fprevious_overlay_change)
62 (mouse_face_overlay_overlaps, Foverlays_in):
63 Use ptrdiff_t, not int, for sizes.
64 (overlays_at, overlays_in): Check for size-calculation overflow.
65
66 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
67
68 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
69 (x_session_initialize): Do not assume string length fits in int.
70
71 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
72 This is unlikely, but can occur if DPI is outlandish.
73
74 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
75 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
76
77 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
78 * xrdb.c (magic_file_p, search_magic_path):
79 Omit last arg SUFFIX; it was always 0. All callers changed.
80 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
81
82 * xfont.c (xfont_match): Avoid need for strlen.
83
84 * xfns.c: Don't assume strlen fits in int.
85 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
86
87 * xdisp.c (message_log_check_duplicate): Return intmax_t,
88 not unsigned long, as we prefer signed integers. All callers changed.
89 Detect integer overflow in repeat count.
90 (message_dolog): Don't assume print length fits in 39 bytes.
91 (display_mode_element): Don't assume strlen fits in int.
92
93 * termcap.c: Don't assume sizes fit in int and never overflow.
94 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
95 (gobble_line): Check for size-calculation overflow.
96
97 * minibuf.c (Fread_buffer):
98 * lread.c (intern, intern_c_string):
99 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
100 Don't assume string length fits in int.
101
102 * keyboard.c (parse_tool_bar_item):
103 * gtkutil.c (style_changed_cb): Avoid need for strlen.
104
105 * font.c: Don't assume string length fits in int.
106 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
107 Use ptrdiff_t, not int.
108 (font_intern_prop): Don't assume string length fits in int.
109 Don't assume integer property fits in fixnum.
110 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
111
112 * filelock.c: Fix some buffer overrun and integer overflow issues.
113 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
114 Reformulate so as not to need the command string.
115 Invoke gzip -cd rather than gunzip, as it's more portable.
116 (lock_info_type, lock_file_1, lock_file):
117 Don't assume pid_t and time_t fit in unsigned long.
118 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
119 (current_lock_owner): Prefer signed type for sizes.
120 Use memcpy, not strncpy, where memcpy is what is really wanted.
121 Don't assume (via atoi) that time_t and pid_t fit in int.
122 Check for time_t and/or pid_t out of range, e.g., via a network share.
123 Don't alloca where an auto var works fine.
124
125 * fileio.c: Fix some integer overflow issues.
126 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
127 Don't assume string length fits in int.
128 (directory_file_name): Don't assume string length fits in long.
129 (make_temp_name): Don't assume pid fits in int, or that its print
130 length is less than 20.
131
132 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
133
134 * coding.c (make_subsidiaries): Don't assume string length fits in int.
135
136 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
137
138 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
139 We prefer signed integers, even for size calculations.
140
141 * emacs.c: Don't assume string length fits in 'int'.
142 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
143 (main): Don't invoke strlen when not needed.
144
145 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
146 (XD_DEBUG_MESSAGE): Don't waste a byte.
147
148 * callproc.c (getenv_internal_1, getenv_internal)
149 (Fgetenv_internal):
150 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
151
152 * lread.c (invalid_syntax): Omit length argument.
153 All uses changed. This doesn't fix a bug, but it simplifies the
154 code away from its former Hollerith-constant appearance, and it's
155 one less 'int' to worry about when looking at integer-overflow issues.
156 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
157
158 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
159 This didn't break anything, but it didn't help either.
160 It's confusing to put a bogus integer in a place where the actual
161 value does not matter.
162 (LIST_END_P): Remove unused macro and its bogus comment.
163 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
164
165 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
166 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
167 implementation.
168 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
169 We prefer signed types, and the value cannot exceed the EMACS_INT
170 range anyway (because otherwise the length would not be representable).
171 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
172 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
173 This avoids a GCC warning when WIDE_EMACS_INT.
174
175 * indent.c (sane_tab_width): New function.
176 (current_column, scan_for_column, Findent_to, position_indentation)
177 (compute_motion): Use it. This is just for clarity.
178 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
179
180 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
181
182 * lisp.h (lint_assume): New macro.
183 * composite.c (composition_gstring_put_cache):
184 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
185
186 * editfns.c, insdel.c:
187 Omit unnecessary forward decls, to simplify future changes.
188
189 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
190
191 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
192
193 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
194 Use much-faster test for byte-length change.
195 Don't assume string byte-length fits in 'int'.
196 Check that character arg fits in 'int'.
197 (mapcar1): Declare byte as byte, for clarity.
198
199 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
200
201 * fns.c (concat): Catch string overflow earlier.
202 Do not rely on integer wraparound.
203
204 * dispextern.h (struct it.overlay_strings_charpos)
205 (struct it.selective): Now EMACS_INT, not int.
206 * xdisp.c (forward_to_next_line_start)
207 (back_to_previous_visible_line_start)
208 (reseat_at_next_visible_line_start, next_element_from_buffer):
209 Don't arbitrarily truncate the value of 'selective' to int.
210
211 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
212
213 * composite.c: Don't truncate sizes to 'int'.
214 (composition_gstring_p, composition_reseat_it)
215 (composition_adjust_point): Use EMACS_INT, not int.
216 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
217 not EMACS_UINT, for indexes.
218
219 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
220
221 * buffer.c: Include <verify.h>.
222 (struct sortvec.priority, struct sortstr.priority):
223 Now EMACS_INT, not int.
224 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
225 (struct sortstr.size, record_overlay_string)
226 (struct sortstrlist.size, struct sortlist.used):
227 Don't truncate size to int.
228 (record_overlay_string): Check for size-calculation overflow.
229 (init_buffer_once): Check at compile-time, not run-time.
230
231 2011-06-22 Jim Meyering <meyering@redhat.com>
232
233 don't leak an XBM-image-sized buffer
234 * image.c (xbm_load): Free the image buffer after using it.
235
236 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
237
238 Port to Sun C.
239 * composite.c (find_automatic_composition): Omit needless 'return 0;'
240 that Sun C diagnosed.
241 * fns.c (secure_hash): Fix pointer signedness issue.
242 * intervals.c (static_offset_intervals): New function.
243 (offset_intervals): Use it.
244
245 2011-06-21 Leo Liu <sdl.web@gmail.com>
246
247 * deps.mk (fns.o):
248 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
249 sha512.h.
250
251 * fns.c (secure_hash): Rename from crypto_hash_function and change
252 the first arg to accept symbols.
253 (Fsecure_hash): New primtive.
254 (syms_of_fns): New symbols.
255
256 2011-06-20 Deniz Dogan <deniz@dogan.se>
257
258 * process.c (Fset_process_buffer): Clarify return value in
259 docstring.
260
261 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
262
263 * dispnew.c (add_window_display_history): Use BVAR.
264
265 * xdisp.c (debug_method_add): Use BVAR.
266 (check_window_end, dump_glyph_matrix, dump_glyph)
267 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
268
269 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
270 Likewise.
271
272 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
273 check till after the cache is created in init_frame_faces.
274
275 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
276
277 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
278
279 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
280
281 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
282 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
283 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
284
285 Improve buffer-overflow checking (Bug#8873).
286 * fileio.c (Finsert_file_contents):
287 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
288 Remove the old (too-loose) buffer overflow checks.
289 They weren't needed, since make_gap checks for buffer overflow.
290 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
291 The old code merely checked for Emacs fixnum overflow, and relied
292 on undefined (wraparound) behavior. The new code avoids undefined
293 behavior, and also checks for ptrdiff_t and/or size_t overflow.
294
295 * editfns.c (Finsert_char): Don't dump core with very negative counts.
296 Tune. Don't use wider integers than needed. Don't use alloca.
297 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
298
299 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
300
301 * insdel.c, lisp.h (buffer_overflow): New function.
302 (insert_from_buffer_1, replace_range, replace_range_2):
303 * insdel.c (make_gap_larger):
304 * editfns.c (Finsert_char):
305 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
306
307 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
308
309 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
310
311 Integer overflow and signedness fixes (Bug#8873).
312
313 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
314 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
315
316 * fileio.c: Don't assume EMACS_INT fits in off_t.
317 (emacs_lseek): New static function.
318 (Finsert_file_contents, Fwrite_region): Use it.
319 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
320
321 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
322
323 * fns.c: Don't overflow int when computing a list length.
324 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
325 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
326 truncation on 64-bit hosts. Check for QUIT every
327 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
328 faster and is responsive enough.
329 (Flength): Report an error instead of overflowing an integer.
330 (Fsafe_length): Return a float if the value is not representable
331 as a fixnum. This shouldn't happen except in contrived situations.
332 (Fnthcdr, Fsort): Don't assume list length fits in int.
333 (Fcopy_sequence): Don't assume vector length fits in int.
334
335 * alloc.c: Check that resized vectors' lengths fit in fixnums.
336 (header_size, word_size): New constants.
337 (allocate_vectorlike): Don't check size overflow here.
338 (allocate_vector): Check it here instead, since this is the only
339 caller of allocate_vectorlike that could cause overflow.
340 Check that the new vector's length is representable as a fixnum.
341
342 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
343 The previous code was bogus. For example, next_almost_prime (32)
344 returned 39, which is undesirable as it is a multiple of 3; and
345 next_almost_prime (24) returned 25, which is a multiple of 5 so
346 why was the code bothering to check for multiples of 7?
347
348 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
349
350 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
351
352 Variadic C functions now count arguments with ptrdiff_t.
353 This partly undoes my 2011-03-30 change, which replaced int with size_t.
354 Back then I didn't know that the Emacs coding style prefers signed int.
355 Also, in the meantime I found a few more instances where arguments
356 were being counted with int, which may truncate counts on 64-bit
357 machines, or EMACS_INT, which may be unnecessarily wide.
358 * lisp.h (struct Lisp_Subr.function.aMANY)
359 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
360 Arg counts are now ptrdiff_t, not size_t.
361 All variadic functions and their callers changed accordingly.
362 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
363 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
364 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
365 * callint.c (Fcall_interactively): Check arg count for overflow,
366 to avoid potential buffer overrun. Use signed char, not 'int',
367 for 'varies' array, so that we needn't bother to check its size
368 calculation for overflow.
369 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
370 * eval.c (apply_lambda):
371 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
372 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
373 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
374
375 * callint.c (Fcall_interactively): Don't use index var as event count.
376
377 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
378 * mem-limits.h (SIZE): Remove; no longer used.
379
380 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
381
382 Remove unnecessary casts.
383 * xterm.c (x_term_init):
384 * xfns.c (x_set_border_pixel):
385 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
386 These aren't needed now that we assume ANSI C.
387
388 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
389 It's more likely to cause problems (due to unsigned overflow)
390 than to cure them.
391
392 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
393
394 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
395
396 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
397
398 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
399
400 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
401
402 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
403
404 GLYPH_CODE_FACE returns EMACS_INT, not int.
405 * dispextern.h (merge_faces):
406 * xfaces.c (merge_faces):
407 * xdisp.c (get_next_display_element, next_element_from_display_vector):
408 Don't assume EMACS_INT fits in int.
409
410 * character.h (CHAR_VALID_P): Remove unused parameter.
411 * fontset.c, lisp.h, xdisp.c: All uses changed.
412
413 * editfns.c (Ftranslate_region_internal): Omit redundant test.
414
415 * fns.c (concat): Minor tuning based on overflow analysis.
416 This doesn't fix any bugs. Use int to hold character, instead
417 of constantly refetching from Emacs object. Use XFASTINT, not
418 XINT, for value known to be a character. Don't bother comparing
419 a single byte to 0400, as it's always less.
420
421 * floatfns.c (Fexpt):
422 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
423
424 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
425 for characters.
426
427 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
428
429 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
430 Without this fix, on a 64-bit host (aset S 0 4294967386) would
431 incorrectly succeed when S was a string, because 4294967386 was
432 truncated before it was used.
433
434 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
435 Otherwise, an out-of-range integer could cause undefined behavior
436 on a 64-bit host.
437
438 * composite.c: Use int, not EMACS_INT, for characters.
439 (fill_gstring_body, composition_compute_stop_pos): Use int, not
440 EMACS_INT, for values that are known to be in character range.
441 This doesn't fix any bugs but is the usual style inside Emacs and
442 may generate better code on 32-bit machines.
443
444 Make sure a 64-bit char is never passed to ENCODE_CHAR.
445 This is for reasons similar to the recent CHAR_STRING fix.
446 * charset.c (Fencode_char): Check that character arg is actually
447 a character. Pass an int to ENCODE_CHAR.
448 * charset.h (ENCODE_CHAR): Verify that the character argument is no
449 wider than 'int', as a compile-time check to prevent future regressions
450 in this area.
451
452 * character.c (char_string): Remove unnecessary casts.
453
454 Make sure a 64-bit char is never passed to CHAR_STRING.
455 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
456 by silently ignoring the top 32 bits, allowing some values
457 that were far too large to be valid characters.
458 * character.h: Include <verify.h>.
459 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
460 arguments are no wider than unsigned, as a compile-time check
461 to prevent future regressions in this area.
462 * data.c (Faset):
463 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
464 (Fsubst_char_in_region):
465 * fns.c (concat):
466 * xdisp.c (decode_mode_spec_coding):
467 Adjust to CHAR_STRING's new requirement.
468 * editfns.c (Finsert_char, Fsubst_char_in_region):
469 * fns.c (concat): Check that character args are actually
470 characters. Without this test, these functions did the wrong
471 thing with wildly out-of-range values on 64-bit hosts.
472
473 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
474 These casts should not be needed on 32-bit hosts, either.
475 * keyboard.c (read_char):
476 * lread.c (Fload): Remove casts to unsigned.
477
478 * lisp.h (UNSIGNED_CMP): New macro.
479 This fixes comparison bugs on 64-bit hosts.
480 (ASCII_CHAR_P): Use it.
481 * casefiddle.c (casify_object):
482 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
483 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
484 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
485 * dispextern.h (FACE_FROM_ID):
486 * keyboard.c (read_char): Use UNSIGNED_CMP.
487
488 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
489 not to EMACS_INT, to avoid GCC warning.
490
491 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
492
493 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
494 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
495 isn't needed on 32-bit machines.
496
497 * buffer.c (Fgenerate_new_buffer_name):
498 Use EMACS_INT for count, not int.
499 (advance_to_char_boundary): Return EMACS_INT, not int.
500
501 * data.c (Qcompiled_function): Now static.
502
503 * window.c (window_body_lines): Now static.
504
505 * image.c (gif_load): Rename local to avoid shadowing.
506
507 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
508 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
509 * alloc.c (make_save_value): Integer argument is now of type
510 ptrdiff_t, not int.
511 (mark_object): Use ptrdiff_t, not int.
512 * lisp.h (pD): New macro.
513 * print.c (print_object): Use it.
514
515 * alloc.c: Use EMACS_INT, not int, to count objects.
516 (total_conses, total_markers, total_symbols, total_vector_size)
517 (total_free_conses, total_free_markers, total_free_symbols)
518 (total_free_floats, total_floats, total_free_intervals)
519 (total_intervals, total_strings, total_free_strings):
520 Now EMACS_INT, not int. All uses changed.
521 (Fgarbage_collect): Compute overall total using a double, so that
522 integer overflow is less likely to be a problem. Check for overflow
523 when converting back to an integer.
524 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
525 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
526 These were 'int' variables that could overflow on 64-bit hosts;
527 they were never used, so remove them instead of repairing them.
528 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
529 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
530 Previously, this ceilinged at INT_MAX, but that doesn't work on
531 64-bit machines.
532 (allocate_pseudovector): Don't use EMACS_INT when int would do.
533
534 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
535 (allocate_vectorlike): Check for ptrdiff_t overflow.
536 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
537 when a (possibly-narrower) signed value would do just as well.
538 We prefer using signed arithmetic, to avoid comparison confusion.
539
540 * alloc.c: Catch some string size overflows that we were missing.
541 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
542 for convenience in STRING_BYTES_MAX.
543 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
544 The definition here is exact; the one in lisp.h was approximate.
545 (allocate_string_data): Check for string overflow. This catches
546 some instances we weren't catching before. Also, it catches
547 size_t overflow on (unusual) hosts where SIZE_MAX <= min
548 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
549 and ptrdiff_t and EMACS_INT are both 64 bits.
550
551 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
552 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
553 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
554
555 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
556
557 * alloc.c (Fmake_string): Check for out-of-range init.
558
559 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
560
561 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
562
563 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
564
565 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
566 xg_get_default_scrollbar_width.
567
568 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
569 (int_gtk_range_get_value): Move to the scroll bar part of the file.
570 (style_changed_cb): Call update_theme_scrollbar_width and call
571 x_set_scroll_bar_default_width and xg_frame_set_char_size for
572 all frames (Bug#8505).
573 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
574 Call gtk_window_set_resizable if HAVE_GTK3.
575 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
576 and height if HAVE_GTK3 (Bug#8505).
577 (scroll_bar_width_for_theme): New variable.
578 (update_theme_scrollbar_width): New function.
579 (xg_get_default_scrollbar_width): Move code to
580 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
581 (xg_initialize): Call update_theme_scrollbar_width.
582
583 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
584
585 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
586
587 2011-06-12 Martin Rudalics <rudalics@gmx.at>
588
589 * frame.c (make_frame): Call other_buffer_safely instead of
590 other_buffer.
591
592 * window.c (temp_output_buffer_show): Call display_buffer with
593 second argument Vtemp_buffer_show_specifiers and reset latter
594 immediately after the call.
595 (Vtemp_buffer_show_specifiers): New variable.
596 (auto_window_vscroll_p, next_screen_context_lines)
597 (Vscroll_preserve_screen_position): Remove leading asterisks from
598 doc-strings.
599
600 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
601
602 Fix minor problems found by GCC 4.6.0 static checking.
603 * buffer.c (Qclone_number): Remove for now, as it's unused.
604 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
605 (record_buffer): Remove unused local.
606 * frame.c (other_visible_frames, frame_buffer_list): Now static.
607 (set_frame_buffer_list): Remove; unused.
608 * frame.h (other_visible_frames): Remove decl.
609 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
610 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
611 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
612 if HAVE_GPM.
613 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
614 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
615 Define only if HAVE_GPM.
616 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
617 (update_hints_inhibit): Remove; never set. All uses removed.
618 * widgetprv.h (emacsFrameClassRec): Remove decl.
619 * window.c (delete_deletable_window): Now returns void, since it
620 wasn't returning anything.
621 (compare_window_configurations): Remove unused locals.
622 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
623 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
624 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
625 the same widths as pointers. This follows up on the 2011-05-06 patch.
626 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
627 * xterm.h: Likewise.
628 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
629
630 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
631
632 * makefile.w32-in: Update dependencies.
633 (LISP_H): Add lib/intprops.h.
634
635 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
636
637 * image.c (gif_load): Add animation frame delay to the metadata.
638 (syms_of_image): Use DEFSYM. New symbol `delay'.
639
640 2011-06-11 Martin Rudalics <rudalics@gmx.at>
641
642 * window.c (delete_deletable_window): Re-add.
643 (Fset_window_configuration): Rewrite to handle dead buffers and
644 consequently deletable windows.
645 (window_tree, Fwindow_tree): Remove. Supply functionality in
646 window.el.
647 (compare_window_configurations): Simplify code.
648
649 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
650
651 * image.c (imagemagick_load_image): Fix type mismatch.
652 (Fimagemagick_types): Likewise.
653
654 * window.h (replace_buffer_in_windows): Declare.
655
656 2011-06-11 Martin Rudalics <rudalics@gmx.at>
657
658 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
659 Qclone_number. Remove external declaration of Qdelete_window.
660 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
661 code.
662 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
663 Qbuffer_list_update_hook if allowed.
664 (Fother_buffer): Rewrite doc-string. Major rewrite for new
665 buffer list implementation.
666 (other_buffer_safely): New function.
667 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
668 calls to replace_buffer_in_windows and
669 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
670 if allowed.
671 (record_buffer): Inhibit quitting and rewrite using quittable
672 functions. Run Qbuffer_list_update_hook if allowed.
673 (Frecord_buffer, Funrecord_buffer): New functions.
674 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
675 switch-to-buffer to window.el.
676 (bury-buffer): Move to window.el.
677 (Vbuffer_list_update_hook): New variable.
678
679 * lisp.h (other_buffer_safely): Add prototype in buffer.c
680 section.
681
682 * window.h (resize_frame_windows): Move up in code.
683 (Fwindow_frame): Remove EXFUN.
684 (replace_buffer_in_all_windows): Remove prototype.
685 (replace_buffer_in_windows_safely): Add prototype.
686
687 * window.c: Declare Qdelete_window static again. Move down
688 declaration of select_count.
689 (Fnext_window, Fprevious_window): Rewrite doc-strings.
690 (Fother_window): Move to window.el.
691 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
692 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
693 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
694 window.el.
695 (replace_buffer_in_windows): Implement by calling
696 Qreplace_buffer_in_windows.
697 (replace_buffer_in_all_windows): Remove with some functionality
698 moved into replace_buffer_in_windows_safely.
699 (replace_buffer_in_windows_safely): New function.
700 (select_window_norecord, select_frame_norecord): Move in front
701 of run_window_configuration_change_hook. Remove now obsolete
702 declarations.
703 (Fset_window_buffer): Rewrite doc-string. Call
704 Qrecord_window_buffer.
705 (keys_of_window): Move binding for other-window to window.el.
706
707 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
708
709 * dispextern.h (struct image): Replace data member, whose int_val
710 and ptr_val fields were not used by anything, with a single
711 lisp_val object.
712
713 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
714 (gif_clear_image, gif_load, imagemagick_load_image)
715 (gs_clear_image, gs_load): Callers changed.
716
717 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
718
719 * buffer.h: Include <time.h>, for time_t.
720 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
721
722 Fix minor problems found by static checking.
723
724 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
725
726 Make identifiers static if they are not used in other modules.
727 * data.c (Qcompiled_function, Qframe, Qvector):
728 * image.c (QimageMagick, Qsvg):
729 * minibuf.c (Qmetadata):
730 * window.c (resize_window_check, resize_root_window): Now static.
731 * window.h (resize_window_check, resize_root_window): Remove decls.
732
733 * window.c (window_deletion_count, delete_deletable_window):
734 Remove; unused.
735 (window_body_lines): Now static.
736 (Fdelete_other_windows_internal): Mark vars as initialized.
737 Make sure 'resize_failed' is initialized.
738 (run_window_configuration_change_hook): Rename local to avoid shadowing.
739 (resize_window_apply): Remove unused local.
740 * window.h (delete_deletable_window): Remove decl.
741
742 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
743 (imagemagick_load_image): Fix pointer signedness problem by changing
744 last arg from unsigned char * to char *. All uses changed.
745 Also, fix a local for similar reasons.
746 Remove unused locals. Remove locals to avoid shadowing.
747 (fn_rsvg_handle_free): Remove; unused.
748 (svg_load, svg_load_image): Fix pointer signedness problem.
749 (imagemagick_load_image): Don't use garbage pointer image_wand.
750
751 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
752
753 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
754
755 * image.c (gif_load): Fix omitted cast error introduced by
756 2011-06-06 change.
757
758 2011-06-10 Martin Rudalics <rudalics@gmx.at>
759
760 * window.h (resize_proportionally, orig_total_lines)
761 (orig_top_line): Remove from window structure.
762 (set_window_height, set_window_width, change_window_heights)
763 (Fdelete_window): Remove prototypes.
764 (resize_frame_windows): Remove duplicate declaration.
765
766 2011-06-10 Eli Zaretskii <eliz@gnu.org>
767
768 * window.h (resize_frame_windows, resize_window_check)
769 (delete_deletable_window, resize_root_window)
770 (resize_frame_windows): Declare prototypes.
771
772 * window.c (resize_window_apply): Make definition be "static" to
773 match the prototype.
774
775 2011-06-10 Martin Rudalics <rudalics@gmx.at>
776
777 * window.c: Remove declarations of Qwindow_size_fixed,
778 window_min_size_1, window_min_size_2, window_min_size,
779 size_window, window_fixed_size_p, enlarge_window, delete_window.
780 Remove static from declaration of Qdelete_window, it's
781 temporarily needed by Fbury_buffer.
782 (replace_window): Don't assign orig_top_line and
783 orig_total_lines.
784 (Fdelete_window, delete_window): Remove. Window deletion is
785 handled by window.el.
786 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
787 Fdelete_window calls with calls to Qdelete_window.
788 (Fdelete_other_windows): Remove. Deleting other windows is
789 handled by window.el.
790 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
791 handled in window.el.
792 (window_min_size_2, window_min_size_1, window_min_size): Remove.
793 Window minimum sizes are handled in window.el.
794 (shrink_windows, size_window, set_window_height)
795 (set_window_width, change_window_heights, window_height)
796 (window_width, CURBEG, CURSIZE, enlarge_window)
797 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
798 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
799 handled in window.el.
800 (make_dummy_parent): Rename to make_parent_window and give it a
801 second argument horflag.
802 (make_window): Don't set resize_proportionally any more.
803 (Fsplit_window): Remove. Windows are split in window.el.
804 (save_restore_action, save_restore_orig_size)
805 (shrink_window_lowest_first, save_restore_orig_size): Remove.
806 Resize mini windows in window.el.
807 (grow_mini_window, shrink_mini_window): Implement by calling
808 Qresize_root_window_vertically, resize_window_check and
809 resize_window_apply.
810 (saved_window, Fset_window_configuration, save_window_save): Do
811 not handle orig_top_line, orig_total_lines, and
812 resize_proportionally.
813 (window_min_height, window_min_width): Move to window.el.
814 (keys_of_window): Move bindings for delete-other-windows,
815 split-window, delete-window and enlarge-window to window.el.
816
817 * buffer.c: Temporarily extern Qdelete_window.
818 (Fbury_buffer): Temporarily call Qdelete_window instead of
819 Fdelete_window (Fbury_buffer will move to window.el soon).
820
821 * frame.c (set_menu_bar_lines_1): Remove code handling
822 orig_top_line and orig_total_lines.
823
824 * dispnew.c (adjust_frame_glyphs_initially): Don't use
825 set_window_height but set heights directly.
826 (change_frame_size_1): Use resize_frame_windows.
827
828 * xdisp.c (init_xdisp): Don't use set_window_height but set
829 heights directly.
830
831 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
832 resize_frame_windows instead of change_window_heights and run
833 run_window_configuration_change_hook.
834
835 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
836 instead of change_window_heights and run
837 run_window_configuration_change_hook.
838
839 2011-06-09 Martin Rudalics <rudalics@gmx.at>
840
841 * window.c (replace_window): Rename second argument REPLACEMENT to
842 NEW. New third argument SETFLAG. Rewrite.
843 (delete_window, make_dummy_parent): Call replace_window with
844 third argument 1.
845 (window_list_1): Move down in code.
846 (run_window_configuration_change_hook): Move set_buffer part
847 before select_frame_norecord part in order to unwind correctly.
848 Rename count1 to count.
849 (recombine_windows, delete_deletable_window, resize_root_window)
850 (Fdelete_other_windows_internal)
851 (Frun_window_configuration_change_hook, make_parent_window)
852 (resize_window_check, resize_window_apply, Fresize_window_apply)
853 (resize_frame_windows, Fsplit_window_internal)
854 (Fdelete_window_internal, Fresize_mini_window_internal): New
855 functions.
856 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
857
858 2011-06-08 Martin Rudalics <rudalics@gmx.at>
859
860 * window.h (window): Add some new members to window structure -
861 normal_lines, normal_cols, new_total, new_normal, clone_number,
862 splits, nest, prev_buffers, next_buffers.
863 (WINDOW_TOTAL_SIZE): Move here from window.c.
864 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
865
866 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
867 Remove.
868 (make_dummy_parent): Set new members of windows structure.
869 (make_window): Move down in code. Handle new members of window
870 structure.
871 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
872 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
873 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
874 (Fset_window_prev_buffers, Fwindow_next_buffers)
875 (Fset_window_next_buffers, Fset_window_clone_number): New
876 functions.
877 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
878 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
879 Doc-string fixes.
880 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
881 Argument WINDOW can be now internal window too.
882 (Fwindow_use_time): Move up in code.
883 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
884 Rewrite doc-string.
885 (Fset_window_configuration, saved_window)
886 (Fcurrent_window_configuration, save_window_save): Handle new
887 members of window structure.
888 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
889 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
890 (syms_of_window): New Lisp objects Qrecord_window_buffer,
891 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
892 Qget_mru_window, Qresize_root_window,
893 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
894 Qauto_buffer_name; staticpro them.
895
896 2011-06-07 Martin Rudalics <rudalics@gmx.at>
897
898 * window.c (Fwindow_total_size, Fwindow_left_column)
899 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
900 (Fwindow_list_1): New functions.
901 (window_box_text_cols): Replace with window_body_cols.
902 (Fwindow_width, Fscroll_left, Fscroll_right): Use
903 window_body_cols instead of window_box_text_cols.
904 (delete_window, Fset_window_configuration): Call
905 delete_all_subwindows with window as argument.
906 (delete_all_subwindows): Take a window as argument and not a
907 structure. Rewrite.
908 (window_loop): Remove handling of GET_LRU_WINDOW and
909 GET_LARGEST_WINDOW.
910 (Fget_lru_window, Fget_largest_window): Move to window.el.
911
912 * window.h: Extern window_body_cols instead of
913 window_box_text_cols. delete_all_subwindows now takes a
914 Lisp_Object as argument.
915
916 * indent.c (compute_motion, Fcompute_motion): Use
917 window_body_cols instead of window_box_text_cols.
918
919 * frame.c (delete_frame): Call delete_all_subwindows with root
920 window as argument.
921
922 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
923
924 * fns.c (Fputhash): Document return value.
925
926 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
927
928 * image.c (gif_load): Implement gif89a spec "no disposal" method.
929
930 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
931
932 Cons<->int and similar integer overflow fixes (Bug#8794).
933
934 Check for overflow when converting integer to cons and back.
935 * charset.c (Fdefine_charset_internal, Fdecode_char):
936 Use cons_to_unsigned to catch overflow.
937 (Fencode_char): Use INTEGER_TO_CONS.
938 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
939 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
940 * data.c (long_to_cons, cons_to_long): Remove.
941 (cons_to_unsigned, cons_to_signed): New functions.
942 These signal an error for invalid or out-of-range values.
943 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
944 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
945 * font.c (Ffont_variation_glyphs):
946 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
947 * lisp.h: Include <intprops.h>.
948 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
949 (cons_to_signed, cons_to_unsigned): New decls.
950 (long_to_cons, cons_to_long): Remove decls.
951 * undo.c (record_first_change): Use INTEGER_TO_CONS.
952 (Fprimitive_undo): Use CONS_TO_INTEGER.
953 * xfns.c (Fx_window_property): Likewise.
954 * xselect.c: Include <limits.h>.
955 (x_own_selection, selection_data_to_lisp_data):
956 Use INTEGER_TO_CONS.
957 (x_handle_selection_request, x_handle_selection_clear)
958 (x_get_foreign_selection, Fx_disown_selection_internal)
959 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
960 (lisp_data_to_selection_data): Use cons_to_unsigned.
961 (x_fill_property_data): Use cons_to_signed.
962 Report values out of range.
963
964 Check for buffer and string overflow more precisely.
965 * buffer.h (BUF_BYTES_MAX): New macro.
966 * lisp.h (STRING_BYTES_MAX): New macro.
967 * alloc.c (Fmake_string):
968 * character.c (string_escape_byte8):
969 * coding.c (coding_alloc_by_realloc):
970 * doprnt.c (doprnt):
971 * editfns.c (Fformat):
972 * eval.c (verror):
973 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
974 since they may not be the same number.
975 * editfns.c (Finsert_char):
976 * fileio.c (Finsert_file_contents):
977 Likewise for BUF_BYTES_MAX.
978
979 * image.c: Use ptrdiff_t, not int, for sizes.
980 (slurp_file): Switch from int to ptrdiff_t.
981 All uses changed.
982 (slurp_file): Check that file size fits in both size_t (for
983 malloc) and ptrdiff_t (for sanity and safety).
984
985 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
986 if b->modtime has its maximal value.
987
988 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
989
990 Don't assume time_t can fit into int.
991 * buffer.h (struct buffer.modtime): Now time_t, not int.
992 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
993 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
994
995 Minor fixes for signed vs unsigned integers.
996 * character.h (MAYBE_UNIFY_CHAR):
997 * charset.c (maybe_unify_char):
998 * keyboard.c (read_char, reorder_modifiers):
999 XINT -> XFASTINT, since the integer must be nonnegative.
1000 * ftfont.c (ftfont_spec_pattern):
1001 * keymap.c (access_keymap, silly_event_symbol_error):
1002 XUINT -> XFASTINT, since the integer must be nonnegative.
1003 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1004 since it makes no difference and we prefer signed.
1005 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1006 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1007 nonnegative.
1008
1009 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1010
1011 * window.h (Fwindow_frame): Declare.
1012
1013 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1014
1015 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1016 (SPARE_MEMORY): Always define.
1017 (LARGE_REQUEST): Remove.
1018 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1019
1020 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1021
1022 * lisp.h: Move EXFUNS for Fframe_root_window,
1023 Fframe_first_window and Fset_frame_selected_window to window.h.
1024
1025 * window.h: Move EXFUNS for Fframe_root_window,
1026 Fframe_first_window and Fset_frame_selected_window here from
1027 lisp.h.
1028
1029 * frame.c (Fwindow_frame, Fframe_first_window)
1030 (Fframe_root_window, Fframe_selected_window)
1031 (Fset_frame_selected_window): Move to window.c.
1032 (Factive_minibuffer_window): Move to minibuf.c.
1033 (Fother_visible_frames_p): New function.
1034
1035 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1036
1037 * window.c (decode_window, decode_any_window): Move up in code.
1038 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1039 (inhibit_frame_unsplittable): Remove unused variable.
1040 (Fwindow_buffer): Move up and rewrite doc-string.
1041 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1042 (Fwindow_prev): New functions.
1043 (Fwindow_frame): Move here from frame.c. Accept any window as
1044 argument.
1045 (Fframe_root_window, Fframe_first_window)
1046 (Fframe_selected_window): Move here from frame.c. Accept frame
1047 or arbitrary window as argument. Update doc-strings.
1048 (Fminibuffer_window): Move up in code.
1049 (Fwindow_minibuffer_p): Move up in code and simplify.
1050 (Fset_frame_selected_window): Move here from frame.c.
1051 Marginal rewrite.
1052 (Fselected_window, select_window, Fselect_window): Move up in
1053 code. Minor doc-string fixes.
1054
1055 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1056
1057 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1058 Do not assume that spare memory exists; that assumption is valid
1059 only if SYSTEM_MALLOC.
1060 (LARGE_REQUEST): New macro, so that the issue of large requests
1061 is separated from the issue of spare memory.
1062
1063 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1064
1065 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1066 format. (Bug#8806)
1067
1068 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1069
1070 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1071 before statements.
1072
1073 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1074
1075 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1076
1077 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1078
1079 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1080 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1081
1082 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1083
1084 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1085
1086 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1087
1088 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1089 (x_clipboard_manager_save): Add return value.
1090 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1091 New error handlers.
1092 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1093 Obey Vx_select_enable_clipboard_manager. Catch errors in
1094 x_clipboard_manager_save (Bug#8779).
1095 (Vx_select_enable_clipboard_manager): New variable.
1096 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1097
1098 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1099
1100 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1101
1102 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1103
1104 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1105 in the current matrix if keep_current_p is non-zero.
1106
1107 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1108
1109 * bidi.c (bidi_level_of_next_char): Fix last change.
1110
1111 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1112
1113 Support bidi reordering of text covered by display properties.
1114
1115 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1116 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1117 (bidi_cache_search, bidi_cache_iterator_state)
1118 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1119 (bidi_level_of_next_char, bidi_move_to_visually_next):
1120 Support character positions inside a run of characters covered by a
1121 display string.
1122 (bidi_paragraph_init, bidi_resolve_explicit_1)
1123 (bidi_level_of_next_char): Call bidi_fetch_char and
1124 bidi_fetch_char_advance instead of FETCH_CHAR and
1125 FETCH_CHAR_ADVANCE.
1126 (bidi_init_it): Initialize new members.
1127 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1128 definitions.
1129 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1130 instead of using explicit *_CHAR codes.
1131 (bidi_resolve_explicit, bidi_resolve_weak):
1132 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1133 bidirectional text is supported only in multibyte buffers.
1134 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1135 it to initialize the frame_window_p member of struct bidi_it.
1136 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1137 (bidi_resolve_explicit, bidi_resolve_weak)
1138 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1139 bidi_it->nchars is non-positive.
1140 (bidi_level_of_next_char): Don't try to lookup the cache for the
1141 next/previous character if nothing is cached there yet, or if we
1142 were just reseat()'ed to a new position.
1143
1144 * xdisp.c (set_cursor_from_row): Set start and stop points
1145 according to the row's direction when priming the loop that looks
1146 for the glyph on which to display cursor.
1147 (single_display_spec_intangible_p): Function deleted.
1148 (display_prop_intangible_p): Reimplement to call
1149 handle_display_spec instead of single_display_spec_intangible_p.
1150 Accept 3 additional arguments needed by handle_display_spec.
1151 This fixes incorrect cursor motion across display property with complex
1152 values: lists, `(when COND...)' forms, etc.
1153 (single_display_spec_string_p): Support property values that are
1154 lists with the argument STRING its top-level element.
1155 (display_prop_string_p): Fix the condition for processing a
1156 property that is a list to be consistent with handle_display_spec.
1157 (handle_display_spec): New function, refactored from the
1158 last portion of handle_display_prop.
1159 (compute_display_string_pos): Accept additional argument
1160 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1161 value of a `display' property is a "replacing spec".
1162 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1163 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1164 the display property, but just return a value indicating whether
1165 the display property will replace the characters it covers.
1166 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1167 frame_window_p members of struct bidi_it.
1168 (compute_display_string_pos, compute_display_string_end):
1169 New functions.
1170 (push_it): Accept second argument POSITION, where pop_it should
1171 jump to continue iteration.
1172 (reseat_1): Initialize bidi_it.disp_pos.
1173
1174 * keyboard.c (adjust_point_for_property): Adjust the call to
1175 display_prop_intangible_p to its new signature.
1176
1177 * dispextern.h (struct bidi_it): New member frame_window_p.
1178 (bidi_init_it): Update prototypes.
1179 (display_prop_intangible_p): Update prototype.
1180 (compute_display_string_pos, compute_display_string_end):
1181 Declare prototypes.
1182 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1183 EMACS_INT.
1184
1185 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1186
1187 Malloc failure behavior now depends on size of allocation.
1188 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1189 * lisp.h: Change signatures accordingly.
1190 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1191 All callers changed. (Bug#8762)
1192
1193 * gnutls.c: Use Emacs's memory allocators.
1194 Without this change, the gnutls library would invoke malloc etc.
1195 directly, which causes problems on non-SYNC_INPUT hosts, and which
1196 runs afoul of improving memory_full behavior. (Bug#8761)
1197 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1198 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1199 xfree instead of the default malloc, realloc, free.
1200 (Fgnutls_boot): No need to check for memory allocation failure,
1201 since xmalloc does that for us.
1202
1203 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1204 * category.c (hash_get_category_set):
1205 * ccl.c (ccl_driver):
1206 * charset.c (Fdefine_charset_internal):
1207 * charset.h (struct charset.hash_index):
1208 * composite.c (get_composition_id, gstring_lookup_cache)
1209 (composition_gstring_put_cache):
1210 * composite.h (struct composition.hash_index):
1211 * dispextern.h (struct image.hash):
1212 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1213 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1214 (hashfn_equal, hashfn_user_defined, make_hash_table)
1215 (maybe_resize_hash_table, hash_lookup, hash_put)
1216 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1217 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1218 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1219 * image.c (make_image, search_image_cache, lookup_image)
1220 (xpm_put_color_table_h):
1221 * lisp.h (struct Lisp_Hash_Table):
1222 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1223 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1224 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1225 * alloc.c (allocate_vectorlike):
1226 Check for overflow in vector size calculations.
1227 * ccl.c (ccl_driver):
1228 Check for overflow when converting EMACS_INT to int.
1229 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1230 need to be updated by these changes.
1231 * fns.c (make_hash_table, maybe_resize_hash_table):
1232 Check for integer overflow with large hash tables.
1233 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1234 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1235 (SXHASH_REDUCE): New macro.
1236 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1237 Use it instead of discarding useful hash info with large hash values.
1238 (sxhash_float): New function.
1239 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1240 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1241 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1242 Rewrite to use FIXNUM_BITS, as this simplifies things.
1243 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1244 Adjust signatures to match updated version of code.
1245 (consing_since_gc): Now EMACS_INT, since a single hash table can
1246 use more than INT_MAX bytes.
1247
1248 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1249
1250 Make it possible to build with GCC-4.6+ -O2 -flto.
1251
1252 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1253
1254 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1255
1256 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1257 Call minibuffer-inactive-mode.
1258
1259 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1260
1261 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1262 Update dependencies.
1263
1264 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1265
1266 * data.c (init_data): Remove code for UTS, this system is not
1267 supported anymore.
1268
1269 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1270
1271 Don't force ./temacs to start in terminal mode.
1272
1273 * frame.c (make_initial_frame): Initialize faces in all cases, not
1274 only when CANNOT_DUMP is defined.
1275 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1276
1277 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1278
1279 * dispnew.c (add_window_display_history): Use const for the string
1280 pointer. Remove declaration, not needed.
1281
1282 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1283
1284 Use 'inline', not 'INLINE'.
1285 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1286 * alloc.c, fontset.c (INLINE): Remove.
1287 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1288 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1289 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1290 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1291 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1292
1293 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1294
1295 Make it possible to run ./temacs.
1296
1297 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1298 syms_of_callproc does the same thing. Remove test for
1299 "initialized", do it in the caller.
1300 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1301
1302 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1303
1304 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1305 (read_minibuf): Use get_minibuffer.
1306 (syms_of_minibuf): Use DEFSYM.
1307 (Qmetadata): New var.
1308 * data.c (Qbuffer): Don't make it static.
1309 (syms_of_data): Use DEFSYM.
1310
1311 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1312
1313 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1314 (CCL_CODE_MIN): New macro.
1315
1316 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1317
1318 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1319
1320 * eval.c (Qdebug): Now static.
1321 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1322 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1323 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1324
1325 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1326
1327 * image.c: Various fixes to ImageMagick code comments.
1328 (Fimagemagick_types): Doc fix.
1329
1330 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1331
1332 Minor fixes prompted by GCC 4.6.0 warnings.
1333
1334 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1335
1336 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1337 (x_clipboard_manager_save_all): Move extern decl to ...
1338 * xterm.h: ... here, so that it can be checked for consistency.
1339
1340 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1341
1342 * xselect.c (x_clipboard_manager_save_frame)
1343 (x_clipboard_manager_save_all): New functions.
1344 (Fx_clipboard_manager_save): Lisp function deleted.
1345
1346 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1347 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1348
1349 * xterm.h: Update prototype.
1350
1351 2011-05-28 William Xu <william.xwl@gmail.com>
1352
1353 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1354 exiting (Bug#8239).
1355
1356 2011-05-28 Jim Meyering <meyering@redhat.com>
1357
1358 Avoid a sign-extension bug in crypto_hash_function.
1359 * fns.c (to_uchar): Define.
1360 (crypto_hash_function): Use it to convert some newly-signed
1361 variables to unsigned, to avoid sign-extension bugs. For example,
1362 without this change, (md5 "truc") would evaluate to
1363 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1364 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1365 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1366
1367 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1368
1369 Integer overflow fixes.
1370
1371 * dbusbind.c: Serial number integer overflow fixes.
1372 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1373 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1374 to hold a serial number that is too large for a fixnum.
1375 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1376 Check for serial numbers out of range. Decode any serial number
1377 that was so large that it became a float. (Bug#8722)
1378
1379 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1380 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1381 Use XFASTINT rather than XUINT when numbers are nonnegative.
1382 (xd_append_arg, Fdbus_method_return_internal):
1383 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1384 arguments, check that Lisp number is nonnegative, rather than
1385 silently wrapping negative numbers around. (Bug#8722)
1386 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1387 (Bug#8722)
1388
1389 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1390
1391 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1392
1393 ccl: add integer overflow checks
1394 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1395 (IN_INT_RANGE): New macros.
1396 (ccl_driver): Use them to check for integer overflow when
1397 decoding a CCL program. Many of the new checks are whether XINT (x)
1398 fits in int; it doesn't always, on 64-bit hosts. The new version
1399 doesn't catch all possible integer overflows, but it's an
1400 improvement. (Bug#8719)
1401
1402 * alloc.c (make_event_array): Use XINT, not XUINT.
1403 There's no need for unsigned here.
1404
1405 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1406 This follows up to the 2011-05-06 change that substituted uintptr_t
1407 for EMACS_INT. This case wasn't caught back then.
1408
1409 Rework Fformat to avoid integer overflow issues.
1410 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1411 now (part of C89). Include <verify.h>.
1412 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1413 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1414 (Fformat): Avoid the prepass trying to compute sizes; it was only
1415 approximate and thus did not catch overflow reliably. Instead, walk
1416 through the format just once, formatting and computing sizes as we go,
1417 checking for integer overflow at every step, and allocating a larger
1418 buffer as needed. Keep track separately whether the format is
1419 multibyte. Keep only the most-recently calculated precision, rather
1420 than them all. Record whether each argument has been converted to
1421 string. Use EMACS_INT, not int, for byte and char and arg counts.
1422 Support field widths and precisions larger than INT_MAX. Avoid
1423 sprintf's undefined behavior with conversion specifications such as %#d
1424 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1425 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1426 formatting out-of-range floating point numbers with int
1427 formats. (Bug#8668)
1428
1429 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1430
1431 * data.c: Avoid integer truncation in expressions involving floats.
1432 * data.c: Include <intprops.h>.
1433 (arith_driver): When there's an integer overflow in an expression
1434 involving floating point, convert the integers to floating point
1435 so that the resulting value does not suffer from catastrophic
1436 integer truncation. For example, on a 64-bit host (* 4
1437 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1438 Do not rely on undefined behavior after integer overflow.
1439
1440 merge count_size_as_multibyte, parse_str_to_multibyte
1441 * character.c, character.h (count_size_as_multibyte):
1442 Rename from parse_str_to_multibyte; all uses changed.
1443 Check for integer overflow.
1444 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1445 since it's now a duplicate of the other. This is more of
1446 a character than a buffer op, so better that it's in character.c.
1447 * fns.c, print.c: Adjust to above changes.
1448
1449 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1450
1451 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1452
1453 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1454
1455 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1456 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1457 (x_clipboard_manager_save): Now static.
1458 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1459
1460 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1461 (crypto_hash_function): Now static.
1462 Fix pointer signedness problems. Avoid unnecessary initializations.
1463
1464 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1465
1466 * termhooks.h (Vselection_alist): Make it terminal-local.
1467
1468 * terminal.c (create_terminal): Initialize it.
1469
1470 * xselect.c: Support for clipboard managers.
1471 (Vselection_alist): Move to termhooks.h as terminal-local var.
1472 (LOCAL_SELECTION): New macro.
1473 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1474 (symbol_to_x_atom): Remove gratuitous arg.
1475 (x_handle_selection_request, lisp_data_to_selection_data)
1476 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1477 (x_own_selection, x_get_local_selection, x_convert_selection):
1478 New arg, specifying work frame. Use terminal-local Vselection_alist.
1479 (some_frame_on_display): Delete unused function.
1480 (Fx_own_selection_internal, Fx_get_selection_internal)
1481 (Fx_disown_selection_internal, Fx_selection_owner_p)
1482 (Fx_selection_exists_p): New optional frame arg.
1483 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1484 (x_handle_selection_clear): Don't treat other terminals with the
1485 same keyboard specially. Use the terminal-local Vselection_alist.
1486 (x_clear_frame_selections): Use Frun_hook_with_args.
1487
1488 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1489
1490 * xterm.h: Add support for those atoms.
1491
1492 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1493
1494 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1495 (converted_selections, conversion_fail_tag): New global variables.
1496 (x_selection_request_lisp_error): Free the above.
1497 (x_get_local_selection): Remove unnecessary code.
1498 (x_reply_selection_request): Args changed; handle arbitrary array
1499 of converted selections stored in converted_selections.
1500 Separate the XChangeProperty and SelectionNotify steps.
1501 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1502 (x_convert_selection): New function.
1503 (x_handle_selection_event): Simplify.
1504 (x_get_foreign_selection): Don't ignore incoming requests while
1505 waiting for an answer; this will fail when we implement
1506 SAVE_TARGETS, and seems unnecessary anyway.
1507 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1508 (Vx_sent_selection_functions): Doc fix.
1509
1510 2011-05-26 Leo Liu <sdl.web@gmail.com>
1511
1512 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1513
1514 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1515
1516 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1517
1518 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1519 for fringe update if it has periodic bitmap.
1520 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1521 and fringe_bitmap_periodic_p.
1522
1523 * fringe.c (get_fringe_bitmap_data): New function.
1524 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1525 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1526 row. Mark glyph row for fringe update if periodicity changed.
1527
1528 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1529 for fringe update unless it has periodic bitmap.
1530
1531 2011-05-25 Kenichi Handa <handa@m17n.org>
1532
1533 * xdisp.c (get_next_display_element): Set correct it->face_id for
1534 a static composition.
1535
1536 2011-05-24 Leo Liu <sdl.web@gmail.com>
1537
1538 * deps.mk (fns.o):
1539 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1540
1541 * fns.c (crypto_hash_function, Fsha1): New function.
1542 (Fmd5): Use crypto_hash_function.
1543 (syms_of_fns): Add Ssha1.
1544
1545 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1546
1547 * gnutls.c: Remove unused macros.
1548 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1549 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1550 Remove macros that are defined and never used.
1551 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1552
1553 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1554
1555 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1556 (Fx_get_selection_internal): Minor cleanup.
1557 (Fx_own_selection_internal): Rename arguments for consistency with
1558 select.el.
1559
1560 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1561
1562 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1563
1564 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1565
1566 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1567
1568 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1569
1570 * dispnew.c (scrolling_window): Don't exclude the case that the
1571 last enabled row in the desired matrix touches the bottom boundary.
1572
1573 2011-05-21 Glenn Morris <rgm@gnu.org>
1574
1575 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1576 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1577 and add some more files.
1578
1579 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1580
1581 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1582 report_file_error introduced by the change from 2011-05-07.
1583
1584 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1585
1586 * systime.h (Time): Define only if emacs is defined.
1587 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1588 where the include path doesn't have X11/X.h by default. See
1589 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1590
1591 2011-05-20 Kenichi Handa <handa@m17n.org>
1592
1593 * composite.c (find_automatic_composition): Fix previous change.
1594
1595 2011-05-20 Glenn Morris <rgm@gnu.org>
1596
1597 * lisp.mk: New file, split from Makefile.in.
1598 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1599 (shortlisp): Remove.
1600 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1601
1602 2011-05-19 Glenn Morris <rgm@gnu.org>
1603
1604 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1605 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1606 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1607 (lisp): Set the order to that of loadup.el.
1608 (shortlisp): Make it a copy of $lisp.
1609 (SOME_MACHINE_LISP): Remove.
1610 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1611 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1612
1613 2011-05-18 Kenichi Handa <handa@m17n.org>
1614
1615 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1616 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1617 (find_automatic_composition): Mostly rewrite for efficiency.
1618
1619 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1620
1621 * makefile.w32-in: Update dependencies.
1622
1623 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1624
1625 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1626 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1627
1628 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1629
1630 Fix some integer overflow issues, such as string length overflow.
1631
1632 * insdel.c (count_size_as_multibyte): Check for string overflow.
1633
1634 * character.c (lisp_string_width): Check for string overflow.
1635 Use EMACS_INT, not int, for string indexes and lengths; in
1636 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1637 the resulting string length overflows an EMACS_INT; instead,
1638 report a string overflow if no precision given. When checking for
1639 precision exhaustion, use a check that cannot possibly have
1640 integer overflow. (Bug#8675)
1641 * character.h (lisp_string_width): Adjust to new signature.
1642
1643 * alloc.c (string_overflow): New function.
1644 (Fmake_string): Use it. This doesn't change behavior, but saves
1645 a few bytes and will simplify future changes.
1646 * character.c (string_escape_byte8): Likewise.
1647 * lisp.h (string_overflow): New decl.
1648
1649 Fixups, following up to the user-interface timestamp change.
1650 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1651 for UI timestamps, instead of unsigned long.
1652 * msdos.c (mouse_get_pos): Likewise.
1653 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1654 * w32gui.h (Time): Define by including "systime.h" rather than by
1655 declaring it ourselves. (Bug#8664)
1656
1657 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1658 * image.c (clear_image_cache): Likewise.
1659
1660 * term.c (term_mouse_position): Don't assume time_t wraparound.
1661
1662 Be more systematic about user-interface timestamps.
1663 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1664 and sometimes 'EMACS_UINT', to represent these timestamps.
1665 This change causes it to use 'Time' uniformly, as that's what X uses.
1666 This makes the code easier to follow, and makes it easier to catch
1667 integer overflow bugs such as Bug#8664.
1668 * frame.c (Fmouse_position, Fmouse_pixel_position):
1669 Use Time, not unsigned long, for user-interface timestamps.
1670 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1671 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1672 * keyboard.h (last_event_timestamp): Likewise.
1673 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1674 * menu.h (xmenu_show): Likewise.
1675 * term.c (term_mouse_position): Likewise.
1676 * termhooks.h (struct input_event.timestamp): Likewise.
1677 (struct terminal.mouse_position_hook): Likewise.
1678 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1679 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1680 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1681 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1682 what it was before.
1683 * menu.h, termhooks.h: Include "systime.h", for Time.
1684
1685 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1686 Don't assume that the difference between two unsigned long values
1687 can fit into an integer. At this point, we know button_down_time
1688 <= event->timestamp, so the difference must be nonnegative, so
1689 there's no need to cast the result if double-click-time is
1690 nonnegative, as it should be; check that it's nonnegative, just in
1691 case. This bug is triggered when events are more than 2**31 ms
1692 apart (about 25 days). (Bug#8664)
1693
1694 * xselect.c (last_event_timestamp): Remove duplicate decl.
1695 (x_own_selection): Remove needless cast to unsigned long.
1696
1697 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1698 that always fit in int. Use a sentinel instead of a counter, to
1699 avoid a temp and to allay GCC's concerns about possible int overflow.
1700 * frame.h (struct frame): Use int for menu_bar_items_used
1701 instead of EMACS_INT, since it always fits in int.
1702
1703 * menu.c (grow_menu_items): Check for int overflow.
1704
1705 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1706
1707 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1708 Before, the code was not consistent. These values cannot exceed
1709 2**31 - 1 so there's no need to make them unsigned.
1710 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1711 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1712 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1713 as modifiers.
1714 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1715
1716 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1717 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1718 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1719 presumably because the widths might not match.
1720
1721 * window.c (size_window): Avoid needless test at loop start.
1722
1723 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1724
1725 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1726
1727 2011-05-12 Drew Adams <drew.adams@oracle.com>
1728
1729 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1730
1731 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1732
1733 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1734 `width' to `bar_area_x' and `bar_area_width', respectively.
1735 (x_scroll_run): Take account of fringe background extension.
1736
1737 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1738 Rename local vars `left' and `width' to `bar_area_x' and
1739 `bar_area_width', respectively.
1740 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1741 background extension.
1742
1743 2011-05-10 Jim Meyering <meyering@redhat.com>
1744
1745 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1746
1747 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1748
1749 * image.c (Finit_image_library): Return t for built-in image types,
1750 like pbm and xbm. (Bug#8640)
1751
1752 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1753
1754 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1755
1756 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1757
1758 * w32console.c (Fset_screen_color): Doc fix.
1759 (Fget_screen_color): New function.
1760 (syms_of_ntterm): Defsubr it.
1761
1762 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1763 unlink the temporary file if Fcall_process didn't create it in the
1764 first place.
1765 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1766 child process will be redirected to a file specified with `:file'.
1767 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1768 cue to call_process_cleanup not to close that handle.
1769
1770 2011-05-07 Ben Key <bkey76@gmail.com>
1771
1772 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1773 one of two shell specific rules, either bootstrap-temacs-CMD or
1774 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1775 to the previous implementation of the bootstrap-temacs rule.
1776 The bootstrap-temacs-CMD rule is similar to the previous
1777 implementation of the bootstrap-temacs rule except that it
1778 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1779 variable.
1780
1781 These changes, along with some changes to nt/configure.bat,
1782 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1783 earlier fix to add support for --cflags and --ldflags options
1784 that include quotes so that it works whether make uses cmd or
1785 sh as the shell.
1786
1787 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1788
1789 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1790 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1791 is a constant.
1792 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1793 a string. Handle both cases.
1794 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1795 (Fdbus_register_method): Use Qinvalid_function.
1796
1797 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1798
1799 * makefile.w32-in: Update dependencies.
1800 (LISP_H): Add inttypes.h and stdin.h.
1801 (PROCESS_H): Add unistd.h.
1802
1803 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1804
1805 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1806 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1807
1808 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1809
1810 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1811
1812 * term.c (vfatal): Remove stray call to va_end.
1813 It's not needed and the C Standard doesn't allow it here anyway.
1814
1815 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1816 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1817
1818 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1819 bytes.
1820
1821 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1822
1823 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1824
1825 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1826
1827 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1828
1829 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1830
1831 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1832 * charset.c (Fdefine_charset_internal): Don't initialize
1833 charset.code_space[15]. The value was garbage, on hosts with
1834 32-bit int (Bug#8600).
1835
1836 * lread.c (read_integer): Be more consistent with string-to-number.
1837 Use string_to_number to do the actual conversion; this avoids
1838 rounding errors and fixes some other screwups. Without this fix,
1839 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1840 (digit_to_number): Move earlier, for benefit of read_integer.
1841 Return -1 if the digit is out of range for the base, -2 if it is
1842 not a digit in any supported base. (Bug#8602)
1843
1844 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1845
1846 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1847 to match comment at start of function. This also removes a
1848 GCC warning about overflow in a 32+64-bit port.
1849
1850 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1851
1852 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1853 Reported by Stefan Monnier in
1854 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1855 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1856 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1857
1858 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1859 (EMACS_UINTPTR): Likewise, with uintptr_t.
1860
1861 * lisp.h: Prefer 64-bit EMACS_INT if available.
1862 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1863 on 32-bit hosts that have 64-bit int, so that they can access
1864 large files.
1865 However, temporarily disable this change unless the temporary
1866 symbol WIDE_EMACS_INT is defined.
1867
1868 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1869
1870 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1871 This removes an assumption that EMACS_INT and long are the same
1872 width as pointers. The assumption is true for Emacs porting targets
1873 now, but we want to make other targets possible.
1874 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1875 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1876 In the rest of the code, change types of integers that hold casted
1877 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1878 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1879 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1880 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1881 No need to cast type when ORing.
1882 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1883 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1884 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1885 assume EMACS_INT is the same width as char *.
1886 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1887 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1888 Remove no-longer-needed casts.
1889 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1890 (xg_tool_bar_help_callback, xg_make_tool_item):
1891 Use EMACS_INTPTR to hold an integer
1892 that will be cast to void *; this can avoid a GCC warning
1893 if EMACS_INT is not the same width as void *.
1894 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1895 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1896 (current_message_1, set_message_1):
1897 Use a local to convert to proper width without a cast.
1898 * xmenu.c (dialog_selection_callback): Likewise.
1899
1900 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1901 Also, don't assume VALBITS / RAND_BITS is less than 5,
1902 and don't rely on undefined behavior when shifting a 1 left into
1903 the sign bit.
1904 * lisp.h (get_random): Change signature to match.
1905
1906 * lread.c (hash_string): Use size_t, not int, for hash computation.
1907 Normally we prefer signed values; but hashing is special, because
1908 it's better to use unsigned division on hash table sizes so that
1909 the remainder is nonnegative. Also, size_t is the natural width
1910 for hashing into memory. The previous code used 'int', which doesn't
1911 retain enough info to hash well into very large tables.
1912 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1913
1914 * dbusbind.c: Don't possibly lose pointer info when converting.
1915 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1916 Use XPNTR rather than XHASH, so that the high-order bits of
1917 the pointer aren't lost when converting through void *.
1918
1919 * eval.c (Fautoload): Don't double-shift a pointer.
1920
1921 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1922
1923 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1924
1925 * gnutls.c (DEF_GNUTLS_FN):
1926 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1927
1928 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1929
1930 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1931 marker. (Bug#8610)
1932
1933 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1934
1935 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1936 New version that can reserve upto 2GB of heap space.
1937
1938 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1939
1940 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1941
1942 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1943
1944 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1945 `gnutls_certificate_set_x509_key_file'.
1946
1947 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1948
1949 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1950 Update dependencies.
1951
1952 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1953
1954 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1955 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1956 Remove unused parameter `fildes'.
1957 * process.c (read_process_output, send_process): Don't pass it.
1958
1959 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1960
1961 Fix previous change: the library cache is defined in w32.c.
1962 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1963 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1964
1965 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1966
1967 Implement dynamic loading of GnuTLS on Windows.
1968
1969 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1970 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1971 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1972 Declare.
1973
1974 * gnutls.c (Qgnutls_dll): Define.
1975 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1976 (gnutls_*): Declare function pointers.
1977 (init_gnutls_functions): New function to initialize function pointers.
1978 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1979 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1980 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1981 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1982 (emacs_gnutls_write, emacs_gnutls_read)
1983 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1984 (Fgnutls_available_p): New function.
1985 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1986 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1987 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1988
1989 * image.c: Include w32.h.
1990 (Vimage_type_cache): Delete.
1991 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1992 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1993 (w32_delayed_load): Move to w32.c.
1994
1995 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1996
1997 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1998 (w32_delayed_load): Move from image.c. When loading a library, record
1999 its filename in the :loaded-from property of the library id.
2000 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2001 Initialize and staticpro them.
2002 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2003
2004 * process.c: Include lisp.h before w32.h, not after.
2005 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2006 instead of gnutls_record_check_pending.
2007
2008 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2009
2010 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2011
2012 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2013 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2014 as passed in.
2015
2016 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2017
2018 * xterm.c (x_set_frame_alpha): Do not set property on anything
2019 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2020
2021 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2022
2023 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2024
2025 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2026
2027 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2028 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2029 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2030 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2031 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2032 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2033 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2034 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2035 (Qgnutls_bootprop_callbacks_verify): Make static.
2036
2037 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2038
2039 * callproc.c: Indentation fixup.
2040
2041 * sysdep.c (wait_for_termination_1): Make static.
2042 (wait_for_termination, interruptible_wait_for_termination):
2043 Move after wait_for_termination_1.
2044
2045 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2046
2047 * sysdep.c (interruptible_wait_for_termination): New function
2048 which is like wait_for_termination, but allows keyboard
2049 interruptions.
2050
2051 * callproc.c (Fcall_process): Add (:file "file") as an option for
2052 the STDOUT buffer.
2053 (Fcall_process_region): Ditto.
2054
2055 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2056
2057 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2058 rather than `XVECTOR (FOO)->size'.
2059
2060 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2061 inttypes.h, as a gnulib replacement is used if it not available in
2062 system headers.
2063
2064 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2065
2066 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2067 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2068 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2069
2070 * coding.c (coding_alloc_by_realloc): Error out if destination
2071 will grow beyond MOST_POSITIVE_FIXNUM.
2072 (decode_coding_emacs_mule): Abort if there isn't enough place in
2073 charbuf for the composition carryover bytes. Reserve an extra
2074 space for up to 2 characters produced in a loop.
2075 (decode_coding_iso_2022): Abort if there isn't enough place in
2076 charbuf for the composition carryover bytes.
2077
2078 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2079
2080 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2081 aborting when %lld or %lll format is passed.
2082 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2083 %llo or %llx format is passed. (Bug#8545)
2084
2085 * window.c (window_scroll_line_based): Use a marker instead of
2086 simple variables to record original value of point. (Bug#7952)
2087
2088 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2089 produced by %s or %c overflows available buffer space. (Bug#8545)
2090
2091 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2092
2093 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2094 (SIZE_MAX): Move defn after all includes, as they might #define it.
2095
2096 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2097
2098 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2099
2100 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2101
2102 * keyboard.c (Qdelayed_warnings_hook): Define.
2103 (command_loop_1): Run `delayed-warnings-hook'
2104 if Vdelayed_warnings_list is non-nil.
2105 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2106 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2107
2108 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2109
2110 * doprnt.c (doprnt): Don't return value smaller than the buffer
2111 size if the message was truncated. (Bug#8545).
2112
2113 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2114
2115 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2116 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2117
2118 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2119
2120 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2121
2122 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2123
2124 * makefile.w32-in: Update dependencies.
2125
2126 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2127
2128 Improve `doprnt' and its usage. (Bug#8545)
2129 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2130 `format_end'. Remove support for %l as a conversion specifier.
2131 Don't use xrealloc. Improve diagnostics when the %l size modifier
2132 is used. Update the commentary.
2133
2134 * eval.c (verror): Simplify calculation of size_t.
2135
2136 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2137 messages.
2138
2139 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2140
2141 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2142 change.
2143
2144 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2145
2146 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2147 This makes this file independent of the recent pseudovector change.
2148
2149 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2150
2151 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2152
2153 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2154 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2155 Remove unused local.
2156 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2157
2158 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2159 GCC 4.6.0 optimizes based on type-based alias analysis.
2160 For example, if b is of type struct buffer * and v of type struct
2161 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2162 != &v->size, and therefore "v->size = 1; b->size = 2; return
2163 v->size;" must therefore return 1. This assumption is incorrect
2164 for Emacs, since it type-puns struct Lisp_Vector * with many other
2165 types. To fix this problem, this patch adds a new type struct
2166 vectorlike_header that documents the constraints on layout of vectors
2167 and pseudovectors, and helps optimizing compilers not get fooled
2168 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2169 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2170 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2171 the size member.
2172 (XSETPVECTYPE): Rewrite in terms of new macro.
2173 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2174 This is a bit clearer, and further avoids the possibility of
2175 undesirable aliasing.
2176 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2177 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2178 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2179 since Lisp_Subr is a special case (no "next" field).
2180 (ASIZE): Now uses header.size rather than size.
2181 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2182 to avoid the hassle of writing XVECTOR (foo)->header.size.
2183 (struct vectorlike_header): New type.
2184 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2185 object, to help avoid aliasing.
2186 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2187 (SUBRP): Likewise, since Lisp_Subr is a special case.
2188 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2189 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2190 (struct Lisp_Hash_Table): Combine first two members into a single
2191 struct vectorlike_header member. All uses of "size" and "next" members
2192 changed to be "header.size" and "header.next".
2193 * buffer.h (struct buffer): Likewise.
2194 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2195 * frame.h (struct frame): Likewise.
2196 * process.h (struct Lisp_Process): Likewise.
2197 * termhooks.h (struct terminal): Likewise.
2198 * window.c (struct save_window_data, struct saved_window): Likewise.
2199 * window.h (struct window): Likewise.
2200 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2201 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2202 * buffer.c (init_buffer_once): Likewise.
2203 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2204 special case.
2205 * process.c (Fformat_network_address): Use local var for size,
2206 for brevity.
2207
2208 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2209
2210 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2211 * data.c (atof): Remove decl; no longer used or needed.
2212 (digit_to_number): Move to lread.c.
2213 (Fstring_to_number): Use new string_to_number function, to be
2214 consistent with how the Lisp reader treats infinities and NaNs.
2215 Do not assume that floating-point numbers represent EMACS_INT
2216 without losing information; this is not true on most 64-bit hosts.
2217 Avoid double-rounding errors, by insisting on integers when
2218 parsing non-base-10 numbers, as the documentation specifies.
2219 * lisp.h (string_to_number): New decl, replacing ...
2220 (isfloat_string): Remove.
2221 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2222 (read1): Do not accept +. and -. as integers; this
2223 appears to have been a coding error. Similarly, do not accept
2224 strings like +-1e0 as floating point numbers. Do not report
2225 overflow for integer overflows unless the base is not 10 which
2226 means we have no simple and reliable way to continue.
2227 Break out the floating-point parsing into a new
2228 function string_to_number, so that Fstring_to_number parses
2229 floating point numbers consistently with the Lisp reader.
2230 (digit_to_number): Move here from data.c. Make it static inline.
2231 (E_CHAR, EXP_INT): Remove, replacing with ...
2232 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2233 (string_to_number): New function, replacing isfloat_string.
2234 This function checks for valid syntax and produces the resulting
2235 Lisp float number too. Rework it so that string-to-number
2236 no longer mishandles examples like "1.0e+". Use strtoumax,
2237 so that overflow for non-base-10 numbers is reported only when
2238 there's no portable and simple way to convert to floating point.
2239
2240 * textprop.c (set_text_properties_1): Rewrite for clarity,
2241 and to avoid GCC warning about integer overflow.
2242
2243 * intervals.h (struct interval): Use EMACS_INT for members
2244 where EMACS_UINT might cause problems. See
2245 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2246 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2247 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2248 All uses changed.
2249 (offset_intervals): Tell GCC not to worry about length overflow
2250 when negating a negative length.
2251
2252 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2253 (overrun_check_free): Likewise.
2254
2255 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2256 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2257 word size.
2258
2259 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2260 (gnutls_make_error): Rename local to avoid shadowing.
2261 (gnutls_emacs_global_deinit): ifdef out; not used.
2262 (Fgnutls_boot): Use const for pointer to readonly storage.
2263 Comment out unused local. Fix pointer signedness problems.
2264
2265 * lread.c (openp): Don't stuff size_t into an 'int'.
2266 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2267 about possible signed overflow.
2268
2269 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2270 (GDK_KEY_g): Don't define if already defined.
2271 (xg_prepare_tooltip): Avoid pointer signedness problem.
2272 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2273
2274 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2275 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2276
2277 * xfns.c (Fx_window_property): Simplify a bit,
2278 to make a bit faster and to avoid GCC 4.6.0 warning.
2279 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2280
2281 * fns.c (internal_equal): Don't assume size_t fits in int.
2282
2283 * alloc.c (compact_small_strings): Tighten assertion a little.
2284
2285 Replace pEd with more-general pI, and fix some printf arg casts.
2286 * lisp.h (pI): New macro, generalizing old pEd macro to other
2287 conversion specifiers. For example, use "...%"pI"d..." rather
2288 than "...%"pEd"...".
2289 (pEd): Remove. All uses replaced with similar uses of pI.
2290 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2291 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2292 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2293 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2294 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2295 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2296 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2297 64-bit hosts.
2298 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2299 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2300 * print.c (safe_debug_print, print_object): Likewise.
2301 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2302 to int.
2303 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2304 avoiding the 0 flag, which is not portable.
2305 * process.c (Fmake_network_process): Use pI to avoid cast.
2306 * region-cache.c (pp_cache): Likewise.
2307 * xdisp.c (decode_mode_spec): Likewise.
2308 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2309 behavior on 64-bit hosts with printf arg.
2310 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2311 (x_stop_queuing_selection_requests): Likewise.
2312 (x_get_window_property): Don't truncate byte count to an 'int'
2313 when tracing.
2314
2315 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2316 here, since it parses constructs like leading '-' and spaces,
2317 which are not wanted; and it overflows with large numbers.
2318 Instead, simply match F[0-9]+, which is what is wanted anyway.
2319
2320 * alloc.c: Remove unportable assumptions about struct layout.
2321 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2322 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2323 (allocate_vectorlike, make_pure_vector): Use the new macros,
2324 plus offsetof, to remove unportable assumptions about struct layout.
2325 These assumptions hold on all porting targets that I know of, but
2326 they are not guaranteed, they're easy to remove, and removing them
2327 makes further changes easier.
2328
2329 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2330 This doesn't fix a bug but makes the code clearer.
2331 (string_overrun_cookie): Now const. Use initializers that
2332 don't formally overflow signed char, to avoid warnings.
2333 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2334 can cause Emacs to crash when string overrun checking is enabled.
2335 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2336 multiple of sizeof (EMACS_INT); it need not be, if
2337 alignof(EMACS_INT) < sizeof (EMACS_INT).
2338 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2339
2340 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2341
2342 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2343
2344 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2345
2346 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2347 supposed to be handshaking. (Bug#8556)
2348 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2349
2350 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2351
2352 * lisp.h (Qdebug): List symbol.
2353 * eval.c (Qdebug): Restore global linkage.
2354 * keyboard.c (debug-on-event): New variable.
2355 (handle_user_signal): Break into debugger when debug-on-event
2356 matches the current signal symbol.
2357
2358 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2359
2360 * alloc.c (check_sblock, check_string_bytes)
2361 (check_string_free_list): Convert to standard C.
2362
2363 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2364
2365 * w32.c (emacs_gnutls_push): Fix typo.
2366
2367 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2368
2369 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2370 "cast to pointer from integer of different size".
2371
2372 Improve doprnt and its use in verror. (Bug#8545)
2373 * doprnt.c (doprnt): Document the set of format control sequences
2374 supported by the function. Use SAFE_ALLOCA instead of always
2375 using `alloca'.
2376
2377 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2378 is one byte too soon. Don't use xrealloc; instead xfree and
2379 xmalloc anew.
2380
2381 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2382
2383 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2384 callbacks stage.
2385
2386 * gnutls.c: Renamed global_initialized to
2387 gnutls_global_initialized. Added internals for the
2388 :verify-hostname-error, :verify-error, and :verify-flags
2389 parameters of `gnutls-boot' and documented those parameters in the
2390 docstring. Start callback support.
2391 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2392 unless a fatal error occured. Call gnutls_alert_send_appropriate
2393 on error. Return error code.
2394 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2395 (emacs_gnutls_read): Likewise.
2396 (Fgnutls_boot): Return handshake error code.
2397 (emacs_gnutls_handle_error): New function.
2398 (wsaerror_to_errno): Likewise.
2399
2400 * w32.h (emacs_gnutls_pull): Add prototype.
2401 (emacs_gnutls_push): Likewise.
2402
2403 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2404 (emacs_gnutls_push): Likewise.
2405
2406 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2407
2408 * process.c (wait_reading_process_output): Check if GnuTLS
2409 buffered some data internally if no FDs are set for TLS
2410 connections.
2411
2412 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2413 (LIBS): Link to USER_LIBS.
2414 ($(BLD)/gnutls.$(0)): New target.
2415
2416 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2417
2418 * xdisp.c (handle_single_display_spec): Rename the
2419 display_replaced_before_p argument into display_replaced_p, to
2420 make it consistent with the commentary. Fix typos in the
2421 commentary.
2422
2423 * textprop.c (syms_of_textprop): Remove dead code.
2424 (copy_text_properties): Delete obsolete commentary about an
2425 interface that was deleted long ago. Fix typos in the description
2426 of arguments.
2427
2428 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2429 to changes in oldXMenu/XMenu.h from 2011-04-16.
2430 <menu_help_message, prev_menu_help_message>: Constify.
2431 (IT_menu_make_room): menu->help_text is now `const char **';
2432 adjust.
2433
2434 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2435 to changes in oldXMenu/XMenu.h from 2011-04-16.
2436 (struct XMenu): Declare `help_text' `const char **'.
2437
2438 * xfaces.c <Qunspecified>: Make extern again.
2439
2440 * syntax.c: Include sys/types.h before including regex.h, as
2441 required by Posix.
2442
2443 * doc.c (get_doc_string): Improve the format passed to `error'.
2444
2445 * doprnt.c (doprnt): Improve commentary.
2446
2447 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2448
2449 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2450 them with etags.
2451
2452 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2453 changes in globals.h immediately force recompilation.
2454 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2455 $(CURDIR)/s/ms-w32.h.
2456 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2457
2458 * character.c (Fchar_direction): Function deleted.
2459 (syms_of_character): Don't defsubr it.
2460 <char-direction-table>: Deleted.
2461
2462 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2463
2464 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2465 * doprnt.c: Include limits.h.
2466 (SIZE_MAX): New macro.
2467 (doprnt): Return a size_t value. 2nd arg is now size_t.
2468 Many local variables are now size_t instead of int or unsigned.
2469 Improve overflow protection. Support `l' modifier for integer
2470 conversions. Support %l conversion. Don't assume an EMACS_INT
2471 argument for integer conversions and for %c.
2472
2473 * lisp.h (doprnt): Restore prototype.
2474
2475 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2476 $(SRC)/character.h.
2477
2478 * Makefile.in (base_obj): Add back doprnt.o.
2479
2480 * deps.mk (doprnt.o): Add back prerequisites.
2481 (callint.o): Depend on character.h.
2482
2483 * eval.c (internal_lisp_condition_case): Include the handler
2484 representation in the error message.
2485 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2486 when breaking from the loop.
2487
2488 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2489
2490 * callint.c (Fcall_interactively): When displaying error message
2491 about invalid control letter, pass the character's codepoint, not
2492 a pointer to its multibyte form. Improve display of the character
2493 in octal and display also its hex code.
2494
2495 * character.c (char_string): Use %x to display the (unsigned)
2496 codepoint of an invalid character, to avoid displaying a bogus
2497 negative value.
2498
2499 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2500 `error', not SYMBOL_NAME itself.
2501
2502 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2503 character arguments to `error'.
2504
2505 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2506 to `error' in error message about FINAL_CHAR argument. Make sure
2507 FINAL_CHAR is a character, and use %c when it is passed as
2508 argument to `error'.
2509
2510 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2511
2512 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2513
2514 * w32.c: Include <time.h>.
2515 (sys_localtime): New function.
2516
2517 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2518
2519 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2520
2521 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2522
2523 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2524
2525 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2526 zombies (Bug#8467).
2527
2528 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2529
2530 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2531 gl_state.e_property when gl_state.object is Qt.
2532
2533 * insdel.c (make_gap_larger): Remove limitation of buffer size
2534 to <= INT_MAX.
2535
2536 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2537
2538 * xdisp.c (lookup_glyphless_char_display)
2539 (produce_glyphless_glyph): Handle cons cell entry in
2540 glyphless-char-display.
2541 (Vglyphless_char_display): Document it.
2542
2543 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2544 glyphless-char-display.
2545
2546 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2547
2548 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2549
2550 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2551
2552 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2553 definition for no-X builds.
2554
2555 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2556
2557 Static checks with GCC 4.6.0 and non-default toolkits.
2558
2559 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2560
2561 * process.c (keyboard_bit_set): Define only if SIGIO.
2562 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2563 (send_process): Repair possible setjmp clobbering.
2564
2565 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2566
2567 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2568
2569 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2570
2571 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2572 Define only if needed.
2573
2574 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2575 by pacifying GCC about it. Maybe it's time to retire it?
2576 * xfaces.c (USG, __TIMEVAL__): Likewise.
2577
2578 * dispextern.h (struct redisplay_interface): Rename param
2579 to avoid shadowing.
2580 * termhooks.h (struct terminal): Likewise.
2581 * xterm.c (xembed_send_message): Likewise.
2582
2583 * insdel.c (make_gap_smaller): Define only if
2584 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2585
2586 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2587 it.
2588
2589 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2590 so that we aren't warned about unused symbols.
2591
2592 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2593
2594 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2595
2596 * xfns.c (x_real_positions): Mark locals as initialized.
2597
2598 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2599
2600 * xterm.c: Fix problems found by static analysis with other toolkits.
2601 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2602 (x_dispatch_event): Declare static if USE_GTK, and
2603 define if USE_GTK || USE_X_TOOLKIT.
2604 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2605 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2606 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2607 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2608
2609 * xmenu.c (menu_help_callback): Pointer type fixes.
2610 Use const pointers when pointing at readonly data. Avoid pointer
2611 signedness clashes.
2612 (FALSE): Remove unused macro.
2613 (update_frame_menubar): Remove unused decl.
2614
2615 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2616
2617 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2618 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2619 (single_menu_item): Rename local to avoid shadowing.
2620
2621 * keyboard.c (make_lispy_event): Remove unused local var.
2622
2623 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2624 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2625
2626 * bitmaps: Change bitmaps from unsigned char back to the X11
2627 compatible char. Avoid the old compiler warnings about
2628 out-of-range initializers by using, for example, '\xab' rather
2629 than 0xab.
2630
2631 * xgselect.c (xgselect_initialize): Check vs interface
2632 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2633
2634 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2635
2636 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2637 to read-only memory.
2638
2639 * fns.c (vector): Remove; this old hack is no longer needed.
2640
2641 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2642 Remove unused var.
2643 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2644
2645 * xrdb.c (x_load_resources): Omit unused local.
2646
2647 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2648 (x_window): Rename locals to avoid shadowing.
2649 (USG): Use the kludged USG macro, to pacify gcc.
2650
2651 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2652 (x_term_init): Remove local to avoid shadowing.
2653
2654 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2655
2656 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2657 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2658
2659 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2660
2661 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2662
2663 Fix regex.c, syntax.c and friends for buffers > 2GB.
2664 * syntax.h (struct gl_state_s): Declare character position members
2665 EMACS_INT.
2666
2667 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2668
2669 * textprop.c (verify_interval_modification, interval_of):
2670 Declare arguments EMACS_INT.
2671
2672 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2673 EMACS_INT.
2674
2675 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2676
2677 * indent.c (Fvertical_motion): Local variable it_start is now
2678 EMACS_INT.
2679
2680 * regex.c (re_match, re_match_2, re_match_2_internal)
2681 (bcmp_translate, regcomp, regexec, print_double_string)
2682 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2683 (re_compile_pattern, re_exec): Declare arguments and local
2684 variables `size_t' and `ssize_t' and return values `regoff_t', as
2685 appropriate.
2686 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2687 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2688 <compile_stack_type>: `size' and `avail' are now `size_t'.
2689
2690 * regex.h <regoff_t>: Use ssize_t, not int.
2691 (re_search, re_search_2, re_match, re_match_2): Arguments that
2692 specify buffer/string position and length are now ssize_t and
2693 size_t. Return type is regoff_t.
2694
2695 2011-04-16 Ben Key <bkey76@gmail.com>
2696
2697 * nsfont.m: Fixed bugs in ns_get_family and
2698 ns_descriptor_to_entity that were caused by using free to
2699 deallocate memory blocks that were allocated by xmalloc (via
2700 xstrdup). This caused Emacs to crash when compiled with
2701 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2702 --enable-checking=xmallocoverrun). xfree is now used to
2703 deallocate these memory blocks.
2704
2705 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2706
2707 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2708
2709 emacs_write: Accept and return EMACS_INT for sizes.
2710 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2711 et seq.
2712 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2713 Accept and return EMACS_INT.
2714 (emacs_gnutls_write): Return the number of bytes written on
2715 partial writes.
2716 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2717 (emacs_read, emacs_write): Remove check for negative size, as the
2718 Emacs source code has been audited now.
2719 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2720 (emacs_read, emacs_write): Use it.
2721 * process.c (send_process): Adjust to the new signatures of
2722 emacs_write and emacs_gnutls_write. Do not attempt to store
2723 a byte offset into an 'int'; it might overflow.
2724 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2725
2726 * sound.c: Don't assume sizes fit in 'int'.
2727 (struct sound_device.period_size, alsa_period_size):
2728 Return EMACS_INT, not int.
2729 (struct sound_device.write, vox_write, alsa_write):
2730 Accept EMACS_INT, not int.
2731 (wav_play, au_play): Use EMACS_INT to store sizes and to
2732 record read return values.
2733
2734 2011-04-15 Ben Key <bkey76@gmail.com>
2735
2736 * keyboard.c (Qundefined): Don't declare static since it is used
2737 in nsfns.m.
2738 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2739 static since they are used in nsfont.m.
2740
2741 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2742
2743 * process.c (Qprocessp): Don't declare static.
2744 * lisp.h (Qprocessp): Declare again.
2745
2746 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2747
2748 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2749
2750 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2751
2752 Improve C-level modularity by making more things 'static'.
2753
2754 Don't publish debugger-only interfaces to other modules.
2755 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2756 (verify_bytepos, count_markers): Move decls to the only modules
2757 that need them.
2758 * region-cache.h (pp_cache): Likewise.
2759 * window.h (check_all_windows): Likewise.
2760 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2761
2762 * sysdep.c (croak): Now static, if
2763 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2764 * syssignal.h (croak): Declare only if not static.
2765
2766 * alloc.c (refill_memory_reserve): Now static if
2767 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2768 * lisp.h (refill_memory_reserve): Declare only if not static.
2769
2770 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2771 Define only if USE_LUCID.
2772
2773 * xrdb.c (x_customization_string, x_rm_string): Now static.
2774
2775 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2776 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2777
2778 * xdisp.c (draw_row_with_mouse_face): Now static.
2779 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2780
2781 * window.h (check_all_windows): Mark externally visible.
2782
2783 * window.c (window_deletion_count): Now static.
2784
2785 * undo.c: Make symbols static if they're not exported.
2786 (last_undo_buffer, last_boundary_position, pending_boundary):
2787 Now static.
2788
2789 * textprop.c (interval_insert_behind_hooks): Now static.
2790 (interval_insert_in_front_hooks): Likewise.
2791
2792 * term.c: Make symbols static if they're not exported.
2793 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2794 (max_frame_lines, tty_set_terminal_modes):
2795 (tty_reset_terminal_modes, tty_turn_off_highlight):
2796 (get_tty_terminal): Now static.
2797 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2798 * termhooks.h (term_mouse_moveto): Do not declare if
2799 HAVE_WINDOW_SYSTEM.
2800 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2801 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2802
2803 * sysdep.c: Make symbols static if they're not exported.
2804 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2805 Now static.
2806 (sigprocmask_set, full_mask): Remove; unused.
2807 (wait_debugging): Mark as visible.
2808 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2809 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2810
2811 * syntax.c (syntax_temp): Define only if !__GNUC__.
2812
2813 * sound.c (current_sound_device, current_sound): Now static.
2814
2815 * search.c (searchbufs, searchbuf_head): Now static.
2816
2817 * scroll.c (scroll_cost): Remove; unused.
2818 * dispextern.h (scroll_cost): Remove decl.
2819
2820 * region-cache.h (pp_cache): Mark as externally visible.
2821
2822 * process.c: Make symbols static if they're not exported.
2823 (process_tick, update_tick, create_process, chan_process):
2824 (Vprocess_alist, proc_buffered_char, datagram_access):
2825 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2826 (deactivate_process): Mark defn as static, as well as decl.
2827 * lisp.h (create_process): Remove decl.
2828 * process.h (chan_process, Vprocess_alist): Remove decls.
2829
2830 * print.c: Make symbols static if they're not exported.
2831 (print_depth, new_backquote_output, being_printed, print_buffer):
2832 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2833 (print_interval, print_number_index, initial_stderr_stream):
2834 Now static.
2835 * lisp.h (Fprinc): Remove decl.
2836 (debug_output_compilation_hack): Mark as externally visible.
2837
2838 * sysdep.c (croak): Move decl from here to syssignal.h.
2839 * syssignal.h (croak): Put it here, so the API can be checked when
2840 'croak' is called from dissociate_if_controlling_tty.
2841
2842 * minibuf.c: Make symbols static if they're not exported.
2843 (minibuf_save_list, choose_minibuf_frame): Now static.
2844 * lisp.h (choose_minibuf_frame): Remove decl.
2845
2846 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2847
2848 * lread.c: Make symbols static if they're not exported.
2849 (read_objects, initial_obarray, oblookup_last_bucket_number):
2850 Now static.
2851 (make_symbol): Remove; unused.
2852 * lisp.h (initial_obarray, make_symbol): Remove decls.
2853
2854 * keyboard.c: Make symbols static if they're not exported.
2855 (single_kboard, recent_keys_index, total_keys, recent_keys):
2856 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2857 (this_single_command_key_start, echoing, last_auto_save):
2858 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2859 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2860 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2861 (Vlispy_mouse_stem, double_click_count):
2862 Now static.
2863 (force_auto_save_soon): Define only if SIGDANGER.
2864 (ignore_mouse_drag_p): Now static if
2865 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2866 (print_help): Remove; unused.
2867 (stop_character, last_timer_event): Mark as externally visible.
2868 * keyboard.h (ignore_mouse_drag_p): Declare only if
2869 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2870 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2871 * lisp.h (echoing): Remove decl.
2872 (force_auto_save_soon): Declare only if SIGDANGER.
2873 * xdisp.c (redisplay_window): Simplify code, to make it more
2874 obvious that ignore_mouse_drag_p is not accessed if !defined
2875 USE_GTK && !defined HAVE_NS.
2876
2877 * intervals.c: Make symbols static if they're not exported.
2878 (merge_properties_sticky, merge_interval_right, delete_interval):
2879 Now static.
2880 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2881
2882 * insdel.c: Make symbols static if they're not exported.
2883 However, leave prepare_to_modify_buffer alone. It's never
2884 called from outside this function, but that appears to be a bug.
2885 (combine_after_change_list, combine_after_change_buffer):
2886 (adjust_after_replace, signal_before_change): Now static.
2887 (adjust_after_replace_noundo): Remove; unused.
2888 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2889 (signal_before_change): Remove decls.
2890
2891 * indent.c (val_compute_motion, val_vmotion): Now static.
2892
2893 * image.c: Make symbols static if they're not exported.
2894 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2895 if USE_GTK.
2896 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2897 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2898
2899 * fringe.c (standard_bitmaps): Now static.
2900 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2901
2902 * frame.c: Make symbols static if they're not exported.
2903 (x_report_frame_params, make_terminal_frame): Now static.
2904 (get_frame_param): Now static, unless HAVE_NS.
2905 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2906 (x_get_resource_string): Remove; not used.
2907 * frame.h (make_terminal_frame, x_report_frame_params):
2908 (x_get_resource_string); Remove decls.
2909 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2910 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2911
2912 * font.c, fontset.c: Make symbols static if they're not exported.
2913 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2914 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2915 * font.c (font_close_object): Now static.
2916 * font.h (font_close_object): Remove.
2917 * fontset.c (FONTSET_OBJLIST): Remove.
2918 (free_realized_fontset) #if-0 the body, which does nothing.
2919 (face_suitable_for_char_p): #if-0, as it's never called.
2920 * fontset.h (face_suitable_for_char_p): Remove decl.
2921 * xfaces.c (face_at_string_position):
2922 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2923 since 0 is always ASCII.
2924
2925 * fns.c (weak_hash_tables): Now static.
2926
2927 * fileio.c: Make symbols static if they're not exported.
2928 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2929 (Vwrite_region_annotation_buffers): Now static.
2930
2931 * eval.c: Make symbols static if they're not exported.
2932 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2933 * lisp.h (backtrace_list): Remove decl.
2934
2935 * emacs.c: Make symbols static if they're not exported.
2936 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2937 (fatal_error_code, fatal_error_signal_hook, standard_args):
2938 Now static.
2939 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2940 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2941 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2942 * lisp.h (fatal_error_signal_hook): Remove decl.
2943 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2944
2945 * editfns.c: Move a (normally-unused) function to its only use.
2946 * editfns.c, lisp.h (get_operating_system_release): Remove.
2947 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2948 worth the hassle of breaking this out.
2949
2950 * xterm.c: Make symbols static if they're not exported.
2951 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2952 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2953 (x_destroy_window, x_delete_display):
2954 Now static.
2955 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2956 (x_mouse_leave): Remove; unused.
2957 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2958 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2959 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2960 Remove decls.
2961 (x_mouse_leave): Declare only if WINDOWSNT.
2962 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2963 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2964 USE_X_TOOLKIT.
2965
2966 * ftxfont.c: Make symbols static if they're not exported.
2967 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2968 HAVE_FREETYPE.
2969 * font.h (ftxfont_driver): Likewise.
2970
2971 * xfns.c: Make symbols static if they're not exported.
2972 (x_last_font_name, x_display_info_for_name):
2973 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2974 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2975 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2976 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2977 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2978 (last_show_tip_args): Now static.
2979 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2980 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2981 (x_screen_planes): Remove; unused.
2982 * dispextern.h (x_screen_planes): Remove decl.
2983
2984 * dispnew.c: Make symbols static if they're not exported.
2985 * dispextern.h (redraw_garbaged_frames, scrolling):
2986 (increment_row_positions): Remove.
2987 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2988 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2989 Now static.
2990 (redraw_garbaged_frames): Remove; unused.
2991
2992 * xfaces.c: Make symbols static if they're not exported.
2993 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2994 Remove decls.
2995 * xterm.h (defined_color): Remove decls.
2996 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2997 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2998 (menu_face_changed_default, defined_color, free_realized_face):
2999 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3000 (ascii_face_of_lisp_face): Remove; unused.
3001
3002 * xdisp.c: Make symbols static if they're not exported.
3003 * dispextern.h (scratch_glyph_row, window_box_edges):
3004 (glyph_to_pixel_coords, set_cursor_from_row):
3005 (get_next_display_element, set_iterator_to_next):
3006 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3007 (show_mouse_face): Remove decls
3008 * frame.h (message_buf_print): Likewise.
3009 * lisp.h (pop_message, set_message, check_point_in_composition):
3010 Likewise.
3011 * xterm.h (set_vertical_scroll_bar): Likewise.
3012 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3013 (message_buf_print, scratch_glyph_row, displayed_buffer):
3014 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3015 (get_next_display_element, show_mouse_face, window_box_edges):
3016 (frame_to_window_pixel_xy, check_point_in_composition):
3017 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3018 (glyph_to_pixel_coords): Remove; unused.
3019
3020 * dired.c (file_name_completion): Now static.
3021
3022 * dbusbind.c (xd_in_read_queued_messages): Now static.
3023
3024 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3025 * data.c (circular_list_error): Remove.
3026
3027 * commands.h (last_point_position, last_point_position_buffer):
3028 (last_point_position_window): Remove decls.
3029 * keyboard.c: Make these variables static.
3030
3031 * coding.h (coding, code_convert_region, encode_coding_gap):
3032 Remove decls.
3033 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3034 (iso_code_class, detect_coding, code_convert_region): Now static.
3035 (encode_coding_gap): Remove; unused.
3036
3037 * chartab.c (chartab_chars, chartab_bits): Now static.
3038
3039 * charset.h (charset_iso_8859_1): Remove decl.
3040 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3041 Now static.
3042
3043 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3044 * ccl.c (Vccl_program_table): Now static.
3045 (check_ccl_update): Remove; unused.
3046
3047 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3048 * category.h: ... from here.
3049 * category.c (check_category_table, set_category_set): Now static.
3050
3051 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3052 * lisp.h: Remove these decls.
3053
3054 * buffer.c (buffer_count): Remove unused var.
3055
3056 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3057 so that it's not optimized away.
3058 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3059 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3060 exported only to the debugger.
3061
3062 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3063 * atimer.h (run_all_atimers): Remove; not exported.
3064
3065 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3066 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3067 was inaccessible from Lisp.
3068 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3069 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3070
3071 alloc.c: Import and export fewer symbols, and remove unused items.
3072 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3073 is defined.
3074 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3075 it's not optimized away by whole-program optimization.
3076 (message_enable_multibyte, free_misc): Remove.
3077 (catchlist, handlerlist, mark_backtrace):
3078 Declare only if BYTE_MARK_STACK.
3079 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3080 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3081 (message_enable_multibyte): Remove decl.
3082 (free_misc, interval_free_list, float_block, float_block_index):
3083 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3084 (cons_free_list, last_marked_index):
3085 Now static.
3086 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3087 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3088 (mark_backtrace): Define only if BYTE_MARK_STACK.
3089 * xdisp.c (message_enable_multibyte): Now static.
3090
3091 Declare Lisp_Object Q* variables to be 'static' if not exported.
3092 This makes it easier for human readers (and static analyzers)
3093 to see whether these variables are used from other modules.
3094 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3095 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3096 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3097 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3098 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3099 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3100 * xmenu.c, xselect.c:
3101 Declare Q* vars static if they are not used in other modules.
3102 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3103 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3104 Remove decls of unexported vars.
3105 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3106
3107 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3108
3109 Make Emacs functions such as Fatom 'static' by default.
3110 This makes it easier for human readers (and static analyzers)
3111 to see whether these functions can be called from other modules.
3112 DEFUN now defines a static function. To make the function external
3113 so that it can be used in other C modules, use the new macro DEFUE.
3114 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3115 (Finit_image_library):
3116 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3117 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3118 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3119 Remove decls, since these functions are now static.
3120 (Funintern, Fget_internal_run_time): New decls, since these functions
3121 were already external.
3122
3123 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3124 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3125 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3126 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3127 * keyboard.c, keymap.c, lread.c:
3128 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3129 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3130 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3131 Mark functions with DEFUE instead of DEFUN,
3132 if they are used in other modules.
3133 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3134 decls for now-static functions.
3135 * buffer.h (Fdelete_overlay): Remove decl.
3136 * callproc.c (Fgetenv_internal): Mark as internal.
3137 * composite.c (Fremove_list_of_text_properties): Remove decl.
3138 (Fcomposition_get_gstring): New forward static decl.
3139 * composite.h (Fcomposite_get_gstring): Remove decl.
3140 * dired.c (Ffile_attributes): New forward static decl.
3141 * doc.c (Fdocumntation_property): New forward static decl.
3142 * eval.c (Ffetch_bytecode): New forward static decl.
3143 (Funintern): Remove extern decl; now in .h file where it belongs.
3144 * fileio.c (Fmake_symbolic_link): New forward static decl.
3145 * image.c (Finit_image_library): New forward static decl.
3146 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3147 * intervals.h (Fprevious_property_change):
3148 (Fremove_list_of_text_properties): Remove decls.
3149 * keyboard.c (Fthis_command_keys): Remove decl.
3150 (Fcommand_execute): New forward static decl.
3151 * keymap.c (Flookup_key): New forward static decl.
3152 (Fcopy_keymap): Now static.
3153 * keymap.h (Flookup_key): Remove decl.
3154 * process.c (Fget_process): New forward static decl.
3155 (Fprocess_datagram_address): Mark as internal.
3156 * syntax.c (Fsyntax_table_p): New forward static decl.
3157 (skip_chars): Remove duplicate decl.
3158 * textprop.c (Fprevious_property_change): New forward static decl.
3159 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3160 Now internal.
3161 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3162 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3163
3164 * editfns.c (Fformat): Remove unreachable code.
3165
3166 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3167
3168 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3169 change. (Bug#8496)
3170
3171 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3172
3173 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3174 when at ZV. (Bug#8487)
3175
3176 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3177
3178 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3179 (Bug#8437)
3180 * keyboard.c (parse_tool_bar_item): Likewise.
3181 * sound.c (sound_cleanup, alsa_close): Likewise.
3182 * termcap.c (tgetent): Likewise.
3183 * xfns.c (x_default_font_parameter): Likewise.
3184 * xsettings.c (read_and_apply_settings): Likewise.
3185
3186 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3187 (overrun_check_free): Protoize.
3188
3189 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3190
3191 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3192 since callers should never pass a negative size.
3193 Change the signature to match that of plain 'read' and 'write'; see
3194 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3195 * lisp.h: Update prototypes of emacs_write and emacs_read.
3196
3197 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3198
3199 * xdisp.c (redisplay_window): Don't try to determine the character
3200 position of the scroll margin if the window start point w->startp
3201 is outside the buffer's accessible region. (Bug#8468)
3202
3203 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3204
3205 Fix write-region and its subroutines for buffers > 2GB.
3206 * fileio.c (a_write, e_write): Modify declaration of arguments and
3207 local variables to support buffers larger than 2GB.
3208 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3209
3210 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3211 argument, local variables, and return value.
3212
3213 * lisp.h: Update prototypes of emacs_write and emacs_read.
3214
3215 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3216
3217 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3218
3219 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3220
3221 Fix more problems found by GCC 4.6.0's static checks.
3222
3223 * xdisp.c (vmessage): Use a better test for character truncation.
3224
3225 * charset.c (load_charset_map): <, not <=, for optimization,
3226 and to avoid potential problems with integer overflow.
3227 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3228 * casetab.c (set_identity, shuffle): Likewise.
3229 * editfns.c (Fformat): Likewise.
3230 * syntax.c (skip_chars): Likewise.
3231
3232 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3233 This also lets GCC 4.6.0 generate slightly better loop code.
3234
3235 * callint.c (Fcall_interactively): <, not <=, for optimization.
3236 (Fcall_interactively): Count the number of arguments produced,
3237 not the number of arguments given. This is simpler and lets GCC
3238 4.6.0 generate slightly better code.
3239
3240 * ftfont.c: Distingish more carefully between FcChar8 and char.
3241 The previous code passed unsigned char * to a functions like
3242 strlen and xstrcasecmp that expect char *, which does not
3243 conform to the C standard.
3244 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3245 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3246 char * when the C standard requires it.
3247
3248 * keyboard.c (read_char): Remove unused var.
3249
3250 * eval.c: Port to Windows vsnprintf (Bug#8435).
3251 Include <limits.h>.
3252 (SIZE_MAX): Define if the headers do not.
3253 (verror): Do not give up if vsnprintf returns a negative count.
3254 Instead, grow the buffer. This ports to Windows vsnprintf, which
3255 does not conform to C99. Problem reported by Eli Zaretskii.
3256 Also, simplify the allocation scheme, by avoiding the need for
3257 calling realloc, and removing the ALLOCATED variable.
3258
3259 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3260
3261 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3262 But keep the doprint source code for now, as we might revamp it
3263 and use it again (Bug#8435).
3264 * lisp.h (doprnt): Remove.
3265 * Makefile.in (base_obj): Remove doprnt.o.
3266 * deps.mk (doprnt.o): Remove.
3267
3268 error: Print 32- and 64-bit integers portably (Bug#8435).
3269 Without this change, on typical 64-bit hosts error ("...%d...", N)
3270 was used to print both 32- and 64-bit integers N, which relied on
3271 undefined behavior.
3272 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3273 New macro.
3274 * lisp.h (error, verror): Mark as printf-like functions.
3275 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3276 Report overflow in size calculations when allocating printf buffer.
3277 Do not truncate output string at its first null byte.
3278 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3279 Truncate the output at a character boundary, since vsnprintf does not
3280 do that.
3281 * charset.c (check_iso_charset_parameter): Convert internal
3282 character to string before calling 'error', since %c now has the
3283 printf meaning.
3284 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3285 overflow when computing char to be passed to 'error'. Do not
3286 pass Lisp_Object to 'error'; pass the integer instead.
3287 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3288 formatted with plain %d.
3289
3290 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3291
3292 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3293
3294 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3295
3296 * xterm.c (x_catch_errors): Remove duplicate declaration.
3297
3298 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3299
3300 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3301
3302 2011-04-10 Jim Meyering <meyering@redhat.com>
3303
3304 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3305 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3306 return ssize_t not "int", and use size_t as the buffer length.
3307 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3308 * gnutls.h: Update declarations.
3309 * process.c (read_process_output): Use ssize_t, to match.
3310 (send_process): Likewise.
3311
3312 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3313
3314 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3315
3316 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3317
3318 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3319 Use unsigned char, to match FcChar8 type definition.
3320
3321 * xterm.c (handle_one_xevent):
3322 * xmenu.c (create_and_show_popup_menu):
3323 * xselect.c (x_decline_selection_request)
3324 (x_reply_selection_request): Avoid type-punned deref of X events.
3325
3326 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3327
3328 Fix some uses of `int' instead of EMACS_INT.
3329 * search.c (string_match_1, fast_string_match)
3330 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3331 (scan_buffer, find_next_newline_no_quit)
3332 (find_before_next_newline, search_command, Freplace_match)
3333 (Fmatch_data): Make some `int' variables be EMACS_INT.
3334
3335 * xdisp.c (display_count_lines): 3rd argument and return value now
3336 EMACS_INT. All callers changed.
3337 (pint2hrstr): Last argument is now EMACS_INT.
3338
3339 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3340 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3341 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3342 (decode_coding_utf_16, decode_coding_emacs_mule)
3343 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3344 (decode_coding_ccl, decode_coding_charset)
3345 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3346 (decode_coding_iso_2022, decode_coding_emacs_mule)
3347 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3348 <char_offset, last_offset>: Declare EMACS_INT.
3349 (encode_coding_utf_8, encode_coding_utf_16)
3350 (encode_coding_emacs_mule, encode_invocation_designation)
3351 (encode_designation_at_bol, encode_coding_iso_2022)
3352 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3353 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3354 Declare EMACS_INT.
3355 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3356 (encode_invocation_designation): Last argument P_NCHARS is now
3357 EMACS_INT.
3358 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3359 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3360
3361 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3362 All users changed.
3363
3364 * ccl.c (Fccl_execute_on_string): Declare some variables
3365 EMACS_INT.
3366
3367 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3368
3369 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3370
3371 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3372
3373 * process.c (Fformat_network_address): Doc fix.
3374
3375 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3376
3377 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3378
3379 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3380
3381 * keyboard.c (read_char): Call Lisp function help-form-show,
3382 instead of using internal_with_output_to_temp_buffer.
3383 (Qhelp_form_show): New var.
3384 (syms_of_keyboard): Use DEFSYM macro.
3385
3386 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3387
3388 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3389
3390 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3391
3392 * process.c (Flist_processes): Remove to Lisp.
3393 (list_processes_1): Delete.
3394
3395 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3396
3397 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3398
3399 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3400
3401 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3402
3403 Fix more problems found by GCC 4.6.0's static checks.
3404
3405 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3406
3407 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3408
3409 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3410
3411 * xdisp.c (vmessage): Mark as a printf-like function.
3412
3413 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3414
3415 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3416
3417 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3418 printf-like functions.
3419 (tiff_load): Add casts to remove these marks before passing them
3420 to system-supplied API.
3421
3422 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3423
3424 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3425 This avoids several warnings with gcc -Wstrict-overflow.
3426 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3427 directly, rather than having caller test rule sign. This avoids
3428 some unnecessary tests.
3429 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3430 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3431 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3432
3433 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3434 (xfont_open): Avoid unnecessary tests.
3435
3436 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3437
3438 * composite.h, composite.c (composition_gstring_put_cache):
3439 Use EMACS_INT, not int, for length.
3440
3441 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3442 breaking out part of COMPOSITION_DECODE_RULE.
3443 (COMPOSITION_DECODE_RULE): Use it.
3444 * composite.c (get_composition_id): Remove unused local vars,
3445 by using the new macro.
3446
3447 * textprop.c (set_text_properties_1): Change while to do-while,
3448 since the condition is always true at first.
3449
3450 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3451 (interval_deletion_adjustment): Return unsigned value.
3452 All uses changed.
3453
3454 * process.c (list_processes_1, create_pty, read_process_output):
3455 (exec_sentinel): Remove vars that were set but not used.
3456 (create_pty): Remove unnecessary "volatile"s.
3457 (Fnetwork_interface_info): Avoid possibility of int overflow.
3458 (read_process_output): Do adaptive read buffering even if carryover.
3459 (read_process_output): Simplify nbytes computation if buffered.
3460
3461 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3462
3463 * syntax.c (scan_words): Remove var that was set but not used.
3464 (update_syntax_table): Use unsigned instead of int.
3465
3466 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3467 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3468 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3469
3470 * print.c (print_error_message): Avoid int overflow.
3471
3472 * font.c (font_list_entities): Redo for clarity,
3473 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3474
3475 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3476 (font_score): Avoid potential overflow in diff calculation.
3477
3478 * fns.c (substring_both): Remove var that is set but not used.
3479 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3480
3481 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3482
3483 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3484 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3485 can always succeed if overflow has undefined behavior.
3486
3487 * search.c (boyer_moore, wordify): Remove vars set but not used.
3488 (wordify): Omit three unnecessary tests.
3489
3490 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3491 All callers changed. This avoids the need for an unused var.
3492
3493 * casefiddle.c (casify_region): Remove var that is set but not used.
3494
3495 * dired.c (file_name_completion): Remove var that is set but not used.
3496
3497 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3498
3499 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3500 (Finsert_file_contents): Remove unnecessary code checking fd.
3501
3502 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3503 Check for integer overflow on size calculations.
3504
3505 * buffer.c (Fprevious_overlay_change): Remove var that is set
3506 but not used.
3507
3508 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3509 Remove vars that are set but not used.
3510 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3511 (timer_check_2): Mark vars as initialized.
3512
3513 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3514
3515 * image.c (lookup_image): Remove var that is set but not used.
3516 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3517
3518 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3519 that are set but not used.
3520
3521 * xfns.c (make_invisible_cursor): Don't return garbage
3522 if XCreateBitmapFromData fails (Bug#8410).
3523
3524 * xselect.c (x_get_local_selection, x_handle_property_notify):
3525 Remove vars that are set but not used.
3526
3527 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3528 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3529
3530 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3531 Remove var that is set but not used.
3532 (scroll_bar_windows_size): Now size_t, not int.
3533 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3534 Check for overflow.
3535
3536 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3537 (map_tty_color) [!defined MSDOS]: Likewise.
3538
3539 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3540
3541 * coding.c: Remove vars that are set but not used.
3542 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3543 All callers changed.
3544 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3545 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3546 (decode_coding_charset): Remove vars that are set but not used.
3547
3548 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3549 that is set but not used.
3550
3551 * print.c (print_object): Remove var that is set but not used.
3552
3553 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3554 The gnulib version avoids calling malloc in the usual case,
3555 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3556 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3557 * filelock.c (current_lock_owner): Likewise.
3558 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3559 * sysdep.c: Include allocator.h, careadlinkat.h.
3560 (emacs_no_realloc_allocator): New static constant.
3561 (emacs_readlink): New function.
3562 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3563 ../lib/careadlinkat.h.
3564
3565 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3566
3567 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3568 first non-nil return value).
3569
3570 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3571
3572 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3573 if not defined (Bug#8403).
3574
3575 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3576
3577 * xdisp.c (display_count_lines): Remove parameter `start',
3578 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3579 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3580 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3581 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3582 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3583 and thereabouts. All callers changed.
3584 (get_per_char_metric): Remove parameter `f', unused since
3585 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3586
3587 2011-04-02 Jim Meyering <meyering@redhat.com>
3588
3589 do not dereference NULL upon failed strdup
3590 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3591 (ns_get_family): Likewise.
3592
3593 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3594
3595 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3596
3597 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3598
3599 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3600 later (Bug#8403).
3601
3602 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3603
3604 Add lexical binding.
3605
3606 * window.c (Ftemp_output_buffer_show): New fun.
3607 (Fsave_window_excursion):
3608 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3609
3610 * lread.c (lisp_file_lexically_bound_p): New function.
3611 (Fload): Bind Qlexical_binding.
3612 (readevalloop): Remove `evalfun' arg.
3613 Bind Qinternal_interpreter_environment.
3614 (Feval_buffer): Bind Qlexical_binding.
3615 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3616 Mark as dynamic.
3617 (syms_of_lread): Declare `lexical-binding'.
3618
3619 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3620
3621 * keyboard.c (eval_dyn): New fun.
3622 (menu_item_eval_property): Use it.
3623
3624 * image.c (parse_image_spec): Use Ffunctionp.
3625
3626 * fns.c (concat, mapcar1): Accept byte-code-functions.
3627
3628 * eval.c (Fsetq): Handle lexical vars.
3629 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3630 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3631 (FletX, Flet): Obey lexical binding.
3632 (Fcommandp): Handle closures.
3633 (Feval): New `lexical' arg.
3634 (eval_sub): New function extracted from Feval. Use it almost
3635 everywhere where Feval was used. Look up vars in lexical env.
3636 Handle closures.
3637 (Ffunctionp): Move from subr.el.
3638 (Ffuncall): Handle closures.
3639 (apply_lambda): Remove `eval_flags'.
3640 (funcall_lambda): Handle closures and new byte-code-functions.
3641 (Fspecial_variable_p): New function.
3642 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3643 but without exporting it to Lisp.
3644
3645 * doc.c (Fdocumentation, store_function_docstring):
3646 * data.c (Finteractive_form): Handle closures.
3647
3648 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3649 interactive spec.
3650
3651 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3652 New byte-codes.
3653 (exec_byte_code): New function extracted from Fbyte_code to handle new
3654 calling convention for byte-code-functions. Add new byte-codes.
3655
3656 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3657
3658 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3659
3660 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3661
3662 * xdisp.c (redisplay_internal): Fix prototype.
3663
3664 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3665
3666 * xdisp.c (SCROLL_LIMIT): New macro.
3667 (try_scrolling): Use it when setting scroll_limit.
3668 Limit scrolling to 100 screen lines.
3669 (redisplay_window): Even when falling back on "recentering",
3670 position point in the window according to scroll-conservatively,
3671 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3672
3673 (try_scrolling): When point is above the window, allow searching
3674 as far as scroll_max, or one screenful, to compute vertical
3675 distance from PT to the scroll margin position. This prevents
3676 try_scrolling from unnecessarily failing when
3677 scroll-conservatively is set to a value slightly larger than the
3678 window height. Clean up the case of PT below the margin at bottom
3679 of window: scroll_max can no longer be INT_MAX. When aggressive
3680 scrolling is in use, don't let point enter the opposite scroll
3681 margin as result of the scroll.
3682 (syms_of_xdisp) <scroll-conservatively>: Document the
3683 threshold of 100 lines for never-recentering scrolling.
3684
3685 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3686
3687 * dispextern.h (move_it_by_lines):
3688 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3689 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3690 (message_log_check_duplicate): Remove parameters `prev_bol' and
3691 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3692 (redisplay_internal): Remove parameter `preserve_echo_area',
3693 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3694
3695 * indent.c (Fvertical_motion):
3696 * window.c (window_scroll_pixel_based, Frecenter):
3697 Don't pass `need_y_p' to `move_it_by_lines'.
3698
3699 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3700
3701 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3702 steal a few bits to be more compact.
3703 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3704 Remove unneeded casts.
3705
3706 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3707
3708 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3709
3710 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3711 binding" message (bug#7967).
3712
3713 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3714
3715 Fix more problems found by GCC 4.6.0's static checks.
3716
3717 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3718 Remove unused local var.
3719
3720 * editfns.c (Fmessage_box): Remove unused local var.
3721
3722 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3723 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3724 Omit unused local vars.
3725 * window.c (shrink_windows): Omit unused local var.
3726 * menu.c (digest_single_submenu): Omit unused local var.
3727 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3728 Omit unused local var.
3729
3730 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3731 Don't assume string length fits in int.
3732 (keyremap_step, read_key_sequence): Use size_t for sizes.
3733 (read_key_sequence): Don't check last_real_key_start redundantly.
3734
3735 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3736 instead of alloca (Bug#8344).
3737
3738 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3739 (Fbacktrace_frame): Don't assume nframes fits in int.
3740
3741 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3742
3743 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3744 concerns.
3745
3746 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3747
3748 * cm.c (calccost): Turn while-do into do-while, for clarity.
3749
3750 * keyboard.c (syms_of_keyboard): Use the same style as later
3751 in this function when indexing through an array. This also
3752 works around GCC bug 48267.
3753
3754 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3755
3756 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3757
3758 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3759 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3760
3761 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3762 This avoids undefined behavior on integer overflow, and is a bit
3763 more convenient anyway since it is compared to a size_t variable.
3764
3765 Variadic C functions now count arguments with size_t, not int.
3766 This avoids an unnecessary limitation on 64-bit machines, which
3767 caused (substring ...) to crash on large vectors (Bug#8344).
3768 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3769 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3770 All variadic functions and their callers changed accordingly.
3771 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3772 * data.c (arith_driver, float_arith_driver): Likewise.
3773 * editfns.c (general_insert_function): Likewise.
3774 * eval.c (struct backtrace.nargs, interactive_p)
3775 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3776 (funcall_lambda, mark_backtrace): Likewise.
3777 * fns.c (concat): Likewise.
3778 * frame.c (x_set_frame_parameters): Likewise.
3779 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3780 0 if not found, not -1. All callers changed.
3781
3782 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3783 (stack_copy_size): Now size_t, not int.
3784 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3785
3786 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3787
3788 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3789 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3790 All callers changed.
3791
3792 * lisp.h (multibyte_char_to_unibyte):
3793 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3794 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3795 * character.h (CHAR_TO_BYTE8):
3796 * cmds.c (internal_self_insert):
3797 * editfns.c (general_insert_function):
3798 * keymap.c (push_key_description):
3799 * search.c (Freplace_match):
3800 * xdisp.c (message_dolog, set_message_1): All callers changed.
3801
3802 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3803
3804 * keyboard.c (safe_run_hook_funcall): New function.
3805 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3806 don't set the hook to nil, but remove the offending function instead.
3807 (Qcommand_hook_internal): Remove, unused.
3808 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3809 Vcommand_hook_internal.
3810
3811 * eval.c (enum run_hooks_condition): Remove.
3812 (funcall_nil, funcall_not): New functions.
3813 (run_hook_with_args): Call each function through a `funcall' argument.
3814 Remove `cond' argument, now redundant.
3815 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3816 (Frun_hook_with_args_until_failure): Adjust accordingly.
3817 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3818
3819 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3820
3821 * dispextern.h (string_buffer_position): Remove declaration.
3822
3823 * print.c (strout): Remove parameter `multibyte', unused since
3824 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3825
3826 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3827 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3828 All callers changed.
3829
3830 * w32.c (_wsa_errlist): Use braces for struct initializers.
3831
3832 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3833 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3834 All callers changed.
3835 (string_buffer_position): Likewise. Also, make static (it's never
3836 used outside xdisp.c).
3837 (cursor_row_p): Remove parameter `w', unused since
3838 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3839 (decode_mode_spec): Remove parameter `precision', introduced during
3840 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3841 All callers changed.
3842
3843 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3844
3845 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3846
3847 2011-03-27 Anders Lindgren <andlind@gmail.com>
3848
3849 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3850 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3851 (ns_update_auto_hide_menu_bar): New functions.
3852 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3853 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3854 ns_constrain_all_frames.
3855 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3856 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3857
3858 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3859
3860 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3861
3862 2011-03-27 Glenn Morris <rgm@gnu.org>
3863
3864 * syssignal.h: Replace RETSIGTYPE with void.
3865 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3866 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3867 Replace SIGTYPE with void everywhere.
3868 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3869 * s/template.h (SIGTYPE): Remove commented out definition.
3870
3871 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3872
3873 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3874 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3875
3876 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3877
3878 * w32.c (read_unc_volume): Use parameter `henum', instead of
3879 global variable `wget_enum_handle'.
3880
3881 * keymap.c (describe_vector): Remove parameters `indices' and
3882 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3883 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3884
3885 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3886
3887 * keyboard.c (timer_check): Remove parameter `do_it_now',
3888 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3889 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3890 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3891
3892 * keyboard.c (read_char):
3893 * w32menu.c (w32_menu_display_help):
3894 * xmenu.c (show_help_event, menu_help_callback):
3895 Adjust calls to `show_help_echo'.
3896
3897 * gtkutil.c (xg_maybe_add_timer):
3898 * keyboard.c (readable_events):
3899 * process.c (wait_reading_process_output):
3900 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3901
3902 * insdel.c (adjust_markers_gap_motion):
3903 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3904 (gap_left, gap_right): Don't call it.
3905
3906 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3907
3908 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3909 incurred during fontification.
3910
3911 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3912
3913 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3914 (DEFVAR_PER_BUFFER): Don't pass it.
3915
3916 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3917 (scrolling_window): Don't pass it.
3918
3919 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3920
3921 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3922
3923 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3924 and `suffix'.
3925 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3926 of variables specific to SELinux and computation of `encoded_absname'.
3927
3928 * image.c (XPutPixel): Remove unused variable `height'.
3929
3930 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3931
3932 * unexw32.c (get_section_info): Remove unused variable `section'.
3933
3934 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3935 (system_process_attributes): Remove unused variable `sess'.
3936 (sys_read): Remove unused variable `err'.
3937
3938 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3939 (w32_wnd_proc): Remove unused variable `isdead'.
3940 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3941 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3942 (x_create_tip_frame): Remove unused variable `tem'.
3943
3944 * w32inevt.c (w32_console_read_socket):
3945 Remove unused variable `no_events'.
3946
3947 * w32term.c (x_draw_composite_glyph_string_foreground):
3948 Remove unused variable `width'.
3949
3950 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3951
3952 * w32term.c (x_set_glyph_string_clipping):
3953 Don't pass uninitialized region to CombineRgn.
3954
3955 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3956
3957 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3958 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3959 (Fx_close_connection): Remove unused variable `i'.
3960
3961 * w32font.c (w32font_draw): Return number of glyphs.
3962 (w32font_open_internal): Remove unused variable `i'.
3963 (w32font_driver): Add missing initializer.
3964
3965 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3966 (fill_in_menu): Remove unused variable `items_added'.
3967
3968 * w32term.c (last_mouse_press_frame): Remove static global variable.
3969 (w32_clip_to_row): Remove unused variable `f'.
3970 (x_delete_terminal): Remove unused variable `i'.
3971
3972 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3973 (NOTHING): Remove unused static global variable.
3974 (uniscribe_check_otf): Remove unused variable `table'.
3975 (uniscribe_font_driver): Add missing initializers.
3976
3977 2011-03-23 Julien Danjou <julien@danjou.info>
3978
3979 * term.c (Fsuspend_tty, Fresume_tty):
3980 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3981 * window.c (temp_output_buffer_show):
3982 * insdel.c (signal_before_change):
3983 * frame.c (Fhandle_switch_frame):
3984 * fileio.c (Fdo_auto_save):
3985 * emacs.c (Fkill_emacs):
3986 * editfns.c (save_excursion_restore):
3987 * cmds.c (internal_self_insert):
3988 * callint.c (Fcall_interactively):
3989 * buffer.c (Fkill_all_local_variables):
3990 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3991 Use Frun_hooks.
3992 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3993 unconditionnaly since it does the check itself.
3994
3995 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3996
3997 Fix more problems found by GCC 4.5.2's static checks.
3998
3999 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4000 the first time through the loop, since we know p0 < p1 then.
4001 This also avoids a gcc -Wstrict-overflow warning.
4002
4003 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4004 leading to a memory leak, possible in functions like
4005 load_charset_map_from_file that can allocate an unbounded number
4006 of objects (Bug#8318).
4007
4008 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4009 that could (at least in theory) be that large.
4010
4011 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4012 This is less likely to overflow, and avoids undefined behavior if
4013 overflow does occur. All callers changed. Use strtoul to scan
4014 for the unsigned long integer.
4015 (pint2hrstr): Simplify and tune code slightly.
4016 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4017
4018 * scroll.c (do_scrolling): Work around GCC bug 48228.
4019 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4020
4021 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4022 This also avoids a warning with gcc -Wstrict-overflow.
4023 (validate_x_resource_name): Simplify count usage.
4024 This also avoids a warning with gcc -Wstrict-overflow.
4025
4026 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4027 fail (Bug#8306).
4028
4029 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4030
4031 * process.c (Fmake_network_process): Use socklen_t, not int,
4032 where POSIX says socklen_t is required in portable programs.
4033 This fixes a porting bug on hosts like 64-bit HP-UX, where
4034 socklen_t is wider than int (Bug#8277).
4035 (Fmake_network_process, server_accept_connection):
4036 (wait_reading_process_output, read_process_output):
4037 Likewise.
4038
4039 * process.c: Rename or move locals to avoid shadowing.
4040 (list_processes_1, Fmake_network_process):
4041 (read_process_output_error_handler, exec_sentinel_error_handler):
4042 Rename or move locals.
4043 (Fmake_network_process): Define label "retry_connect" only if needed.
4044 (Fnetwork_interface_info): Fix pointer signedness.
4045 (process_send_signal): Add cast to avoid pointer signedness problem.
4046 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4047 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4048
4049 Make tparam.h and terminfo.c consistent.
4050 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4051 Include tparam.h instead, since it declares them.
4052 * cm.h (PC): Remove extern decl; tparam.h now does this.
4053 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4054 * terminfo.c: Include tparam.h, to check interfaces.
4055 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4056 (tparam): Adjust signature to match interface in tparam.h;
4057 this removes some undefined behavior. Check that outstring and len
4058 are zero, which they always are with Emacs.
4059 * tparam.h (PC, BC, UP): New extern decls.
4060
4061 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4062 (xftfont_open): Rename locals to avoid shadowing.
4063
4064 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4065 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4066 (OTF_TAG_SYM): Omit macro if not needed.
4067 (ftfont_list): Remove unused local.
4068 (get_adstyle_property, ftfont_pattern_entity):
4069 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4070 Rename locals to avoid shadowing.
4071
4072 * xfont.c (xfont_list_family): Mark var as initialized.
4073
4074 * xml.c (make_dom): Now static.
4075
4076 * composite.c (composition_compute_stop_pos): Rename local to
4077 avoid shadowing.
4078 (composition_reseat_it): Remove unused locals.
4079 (find_automatic_composition, composition_adjust_point): Likewise.
4080 (composition_update_it): Mark var as initialized.
4081 (find_automatic_composition): Mark vars as initialized,
4082 with a FIXME (Bug#8290).
4083
4084 character.h: Rename locals to avoid shadowing.
4085 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4086 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4087 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4088 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4089 to avoid shadowing.
4090
4091 * textprop.c (property_change_between_p): Remove; unused.
4092
4093 * intervals.c (interval_start_pos): Now static.
4094
4095 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4096
4097 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4098 Rename locals to avoid shadowing.
4099
4100 * sound.c (wav_play, au_play, Fplay_sound_internal):
4101 Fix pointer signedness.
4102 (alsa_choose_format): Remove unused local var.
4103 (wav_play): Initialize a variable to 0, to prevent undefined
4104 behavior (Bug#8278).
4105
4106 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4107
4108 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4109
4110 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4111 clobbering (Bug#8298).
4112 * sysdep.c (sys_subshell): Likewise.
4113 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4114
4115 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4116 This should get cleaned up, so that child_setup has the
4117 same signature on all platforms.
4118
4119 * callproc.c (call_process_cleanup): Now static.
4120 (relocate_fd): Rename locals to avoid shadowing.
4121
4122 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4123
4124 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4125 not to be necessary, and produces flickering.
4126
4127 2011-03-20 Glenn Morris <rgm@gnu.org>
4128
4129 * config.in: Remove file.
4130
4131 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4132
4133 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4134 are now in src/globals.h.
4135 (syms_of_minibuf): Remove spurious & from previous change.
4136
4137 2011-03-20 Leo <sdl.web@gmail.com>
4138
4139 * minibuf.c (completing-read-function): New variable.
4140 (completing-read-default): Rename from completing-read.
4141 (completing-read): Call completing-read-function.
4142
4143 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4144
4145 * xfaces.c (Fx_load_color_file):
4146 Read color file from absolute filename (bug#8250).
4147
4148 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4149
4150 * makefile.w32-in: Update dependencies.
4151
4152 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4153
4154 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4155
4156 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4157
4158 Fix more problems found by GCC 4.5.2's static checks.
4159
4160 * process.c (make_serial_process_unwind, send_process_trap):
4161 (sigchld_handler): Now static.
4162
4163 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4164 That way, the code declares only the vars that it needs.
4165 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4166 * s/cygwin.h (PTY_ITERATION): Likewise.
4167 * s/darwin.h (PTY_ITERATION): Likewise.
4168 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4169
4170 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4171 * process.c (allocate_pty): Don't declare stb unless it's needed.
4172
4173 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4174 (CONSTANTLIM): Remove; unused.
4175 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4176 Define only if needed.
4177
4178 * unexelf.c (unexec): Name an expression,
4179 to avoid gcc -Wbad-function-cast warning.
4180 Use a different way to cause a compilation error if anyone uses
4181 n rather than nn, a way that does not involve shadowing.
4182 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4183
4184 * deps.mk (unexalpha.o): Remove; unused.
4185
4186 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4187 * unexec.h: New file.
4188 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4189 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4190 Depend on unexec.h.
4191 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4192 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4193 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4194 Change as necessary to match prototype in unexec.h.
4195
4196 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4197 shadowing.
4198 (back_comment, skip_chars): Mark vars as initialized.
4199
4200 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4201 Rename locals to avoid shadowing.
4202
4203 * lread.c (read1): Rewrite so as not to use empty "else".
4204 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4205
4206 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4207
4208 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4209 warning when compiling print.c.
4210
4211 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4212 instead of using an uninitialized var.
4213 (font_sort_entities): Mark var as initialized.
4214
4215 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4216
4217 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4218 pointers to constants.
4219 (font_parse_fcname): Remove unused vars.
4220 (font_delete_unmatched): Now static.
4221 (font_get_spec): Remove; unused.
4222 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4223 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4224 Rename or move locals to avoid shadowing.
4225
4226 * fns.c (require_nesting_list, require_unwind): Now static.
4227 (Ffillarray): Rename locals to avoid shadowing.
4228
4229 * floatfns.c (domain_error2): Define only if needed.
4230 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4231
4232 * alloc.c (mark_backtrace): Move decl from here ...
4233 * lisp.h: ... to here, so that it can be checked.
4234
4235 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4236 (Fdefvar): Rewrite so as not to use empty "else".
4237 (lisp_indirect_variable): Name an expression,
4238 to avoid gcc -Wbad-function-cast warning.
4239 (Fdefvar): Rename locals to avoid shadowing.
4240
4241 * callint.c (quotify_arg, quotify_args): Now static.
4242 (Fcall_interactively): Rename locals to avoid shadowing.
4243 Use const pointer when appropriate.
4244
4245 * lisp.h (get_system_name, get_operating_system_release):
4246 Move decls here, to check interfaces.
4247 * process.c (get_operating_system_release): Move decl to lisp.h.
4248 * xrdb.c (get_system_name): Likewise.
4249 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4250 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4251 some of which prompt warnings from gcc -Wbad-function-cast.
4252 (Fformat_time_string, Fencode_time, Finsert_char):
4253 (Ftranslate_region_internal, Fformat):
4254 Rename or remove local vars to avoid shadowing.
4255 (Ftranslate_region_internal): Mark var as initialized.
4256
4257 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4258 avoid shadowing.
4259
4260 * lisp.h (eassert): Check that the argument compiles, even if
4261 ENABLE_CHECKING is not defined.
4262
4263 * data.c (Findirect_variable): Name an expression, to avoid
4264 gcc -Wbad-function-cast warning.
4265 (default_value, arithcompare, arith_driver, arith_error): Now static.
4266 (store_symval_forwarding): Rename local to avoid shadowing.
4267 (Fmake_variable_buffer_local, Fmake_local_variable):
4268 Mark variables as initialized.
4269 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4270
4271 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4272 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4273 Rename locals to avoid shadowing.
4274 (mark_stack): Move local variables into the #ifdef region where
4275 they're used.
4276 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4277 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4278 needed otherwise.
4279 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4280 (GC_STRING_CHARS): Remove; not used.
4281 (Fmemory_limit): Cast sbrk's returned value to char *.
4282
4283 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4284 avoids undefined behavior in theory.
4285
4286 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4287
4288 Use functions, not macros, for up- and down-casing (Bug#8254).
4289 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4290 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4291 to use the following functions instead of these macros.
4292 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4293 EMACS_INT, since callers assume the returned value fits in int.
4294 (upcase1): Likewise, for UPCASE_TABLE.
4295 (uppercasep, lowercasep, upcase): New static inline functions.
4296 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4297 the race-condition problem in the old DOWNCASE.
4298
4299 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4300 Rename locals to avoid shadowing.
4301 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4302 (regex_compile, re_search_2, re_match_2_internal):
4303 Remove unused local vars.
4304 (FREE_VAR): Rewrite so as not to use empty "else",
4305 which gcc can warn about.
4306 (regex_compile, re_match_2_internal): Mark locals as initialized.
4307 (RETALLOC_IF): Define only if needed.
4308 (WORDCHAR_P): Likewise. This one is never needed, but is used
4309 only in a comment talking about a compiler bug, so put inside
4310 the #if 0 of that comment.
4311 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4312 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4313 Remove; unused.
4314
4315 * search.c (boyer_moore): Rename locals to avoid shadowing.
4316 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4317 (PREV_CHAR_BOUNDARY): Likewise.
4318
4319 * search.c (simple_search): Remove unused var.
4320
4321 * dired.c (compile_pattern): Move decl from here ...
4322 * lisp.h: ... to here, so that it can be checked.
4323 (struct re_registers): New forward decl.
4324
4325 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4326
4327 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4328 All uses changed.
4329 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4330 Rename locals to avoid shadowing.
4331 (Fvertical_motion): Mark locals as initialized.
4332
4333 * casefiddle.c (casify_object, casify_region): Now static.
4334 (casify_region): Mark local as initialized.
4335
4336 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4337
4338 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4339 New macros, so that the caller can use some names other than
4340 gcpro1, gcpro2, etc.
4341 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4342 of the new macros.
4343 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4344 argument, for consistency with GCPRO2_VAR, etc: it is now the
4345 prefix of the variable, not the variable itself. All uses
4346 changed.
4347 * dired.c (directory_files_internal, file_name_completion):
4348 Rename locals to avoid shadowing.
4349
4350 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4351 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4352 dired.c's scmp function, had undefined behavior.
4353 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4354 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4355 * buffer.h: ... to here, because these macros use current_buffer,
4356 and the new implementation with inline functions needs to have
4357 current_buffer in scope now, rather than later when the macros
4358 are used.
4359 (downcase, upcase1): New static inline functions.
4360 (DOWNCASE, UPCASE1): Reimplement using these functions.
4361 This avoids undefined behavior in expressions like
4362 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4363 from race conditions in accessing the global variables
4364 case_temp1 and case_temp2.
4365 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4366 * lisp.h (case_temp1, case_temp2): Remove their decls.
4367 * character.h (ASCII_CHAR_P): Move from here ...
4368 * lisp.h: ... to here, so that the inline functions mentioned
4369 above can use them.
4370
4371 * dired.c (directory_files_internal_unwind): Now static.
4372
4373 * fileio.c (file_name_as_directory, directory_file_name):
4374 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4375 Now static.
4376 (file_name_as_directory): Use const pointers when appropriate.
4377 (Fexpand_file_name): Likewise. In particular, newdir might
4378 point at constant storage, so make it a const pointer.
4379 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4380 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4381 signedness issues.
4382 (Fset_file_times, Finsert_file_contents, auto_save_error):
4383 Rename locals to avoid shadowing.
4384
4385 * minibuf.c (choose_minibuf_frame_1): Now static.
4386 (Ftry_completion, Fall_completions): Rename or remove locals
4387 to avoid shadowing.
4388
4389 * marker.c (bytepos_to_charpos): Remove; unused.
4390
4391 * lisp.h (verify_bytepos, count_markers): New decls,
4392 so that gcc does not warn that these functions aren't declared.
4393
4394 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4395 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4396 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4397 (copy_text): Remove unused local var.
4398
4399 * filelock.c (within_one_second): Now static.
4400 (lock_file_1): Rename local to avoid shadowing.
4401
4402 * buffer.c (fix_overlays_before): Mark locals as initialized.
4403 (fix_start_end_in_overlays): Likewise. This function should be
4404 simplified by using pointers-to-pointers, but that's a different
4405 matter.
4406 (switch_to_buffer_1): Now static.
4407 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4408 (report_overlay_modification): Rename locals to avoid shadowing.
4409
4410 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4411 Fix pointer signedness issue.
4412 (sys_subshell): Mark local as volatile if checking for lint,
4413 to suppress a gcc -Wclobbered warning that does not seem to be right.
4414 (MAXPATHLEN): Define only if needed.
4415
4416 * process.c (serial_open, serial_configure): Move decls from here ...
4417 * systty.h: ... to here, so that they can be checked.
4418
4419 * fns.c (get_random, seed_random): Move extern decls from here ...
4420 * lisp.h: ... to here, so that they can be checked.
4421
4422 * sysdep.c (reset_io): Now static.
4423 (wait_for_termination_signal): Remove; unused.
4424
4425 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4426 (copy_keymap_item, append_key, push_text_char_description):
4427 Now static.
4428 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4429 (DENSE_TABLE_SIZE): Remove; unused.
4430 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4431 (describe_map_tree):
4432 Rename locals to avoid shadowing.
4433
4434 * keyboard.c: Declare functions static if they are not used elsewhere.
4435 (echo_char, echo_dash, cmd_error, top_level_2):
4436 (poll_for_input, handle_async_input): Now static.
4437 (read_char, kbd_buffer_get_event, make_lispy_position):
4438 (make_lispy_event, make_lispy_movement, apply_modifiers):
4439 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4440 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4441 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4442 (read_key_sequence, read_char): Mark locals as initialized.
4443 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4444
4445 * keyboard.h (make_ctrl_char): New decl.
4446 (mark_kboards): Move decl here ...
4447 * alloc.c (mark_kboards): ... from here.
4448
4449 * lisp.h (force_auto_save_soon): New decl.
4450
4451 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4452 (DEFINE_DUMMY_FUNCTION): New macro.
4453 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4454 Use it.
4455 (main): Add casts to avoid warnings
4456 if GCC considers string literals to be constants.
4457
4458 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4459
4460 * dbusbind.c: Pointer signedness fixes.
4461 (xd_signature, xd_append_arg, xd_initialize):
4462 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4463 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4464 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4465 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4466
4467 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4468 if GCC considers string literals to be constants.
4469 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4470
4471 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4472
4473 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4474 (print_preprocess, print_object): New macro to fix last change.
4475
4476 * print.c (print_preprocess): Don't forget font objects.
4477
4478 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4479
4480 * emacs.c (USAGE3): Doc fixes.
4481
4482 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4483
4484 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4485 structure.
4486
4487 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4488
4489 * lisp.h (VWindow_system, Qfile_name_history):
4490 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4491 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4492 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4493
4494 * w32select.c: Don't #include "keyboard.h".
4495 (run_protected): Add extern declaration for waiting_for_input.
4496
4497 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4498 * w32console.c (detect_input_pending, read_input_pending)
4499 (encode_terminal_code):
4500 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4501 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4502 (w32_system_caret_y, Qfile_name_history):
4503 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4504 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4505 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4506 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4507 * w32proc.c (Qlocal, report_file_error):
4508 * w32term.c (Vwindow_system, updating_frame):
4509 * w32uniscribe.c (initialized, uniscribe_font_driver):
4510 Remove unneeded extern declarations.
4511
4512 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4513
4514 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4515
4516 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4517
4518 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4519 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4520 These macros can no longer be used for assignment.
4521
4522 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4523 Assign struct members directly, instead of using BUF_BEGV etc.
4524 (record_buffer_markers, fetch_buffer_markers): New functions for
4525 recording and fetching special buffer markers.
4526 (set_buffer_internal_1, set_buffer_temp): Use them.
4527
4528 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4529
4530 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4531
4532 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4533 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4534
4535 * xdisp.c (hscroll_window_tree):
4536 (reconsider_clip_changes): Use PT instead of BUF_PT.
4537
4538 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4539
4540 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4541 $(EMACS_ROOT)/lib/intprops.h.
4542
4543 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4544
4545 Fix more problems found by GCC 4.5.2's static checks.
4546
4547 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4548 to unsigned char * to avoid compiler diagnostic.
4549 (xg_free_frame_widgets): Make it clear that a local variable is
4550 needed only if USE_GTK_TOOLTIP.
4551 (gdk_window_get_screen): Make it clear that this macro is needed
4552 only if USE_GTK_TOOLTIP.
4553 (int_gtk_range_get_value): New function, which avoids a diagnostic
4554 from gcc -Wbad-function-cast.
4555 (xg_set_toolkit_scroll_bar_thumb): Use it.
4556 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4557 diagnostic from gcc -Wbad-function-cast.
4558 (get_utf8_string, xg_get_file_with_chooser):
4559 Rename locals to avoid shadowing.
4560 (create_dialog): Move locals to avoid shadowing.
4561
4562 * xgselect.c (xg_select): Remove unused var.
4563
4564 * image.c (four_corners_best): Mark locals as initialized.
4565 (gif_load): Initialize transparent_p to zero (Bug#8238).
4566 Mark another local as initialized.
4567 (my_png_error, my_error_exit): Mark with NO_RETURN.
4568
4569 * image.c (clear_image_cache): Now static.
4570 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4571 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4572 (x_edge_detection): Remove unnecessary cast that
4573 gcc -Wbad-function-cast diagnoses.
4574 (gif_load): Fix pointer signedness.
4575 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4576 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4577
4578 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4579
4580 Improve quality of tests for time stamp overflow.
4581 For example, without this patch (encode-time 0 0 0 1 1
4582 1152921504606846976) returns the obviously-bogus value (-948597
4583 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4584 reports time overflow. See
4585 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4586 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4587 * editfns.c: Include limits.h and intprops.h.
4588 (TIME_T_MIN, TIME_T_MAX): New macros.
4589 (time_overflow): Move earlier, to before first use.
4590 (hi_time, lo_time): New functions, for an accurate test for
4591 out-of-range times.
4592 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4593 (Fget_internal_run_time): Don't assume time_t fits in int.
4594 (make_time): Use list2 instead of Fcons twice.
4595 (Fdecode_time): More accurate test for out-of-range times.
4596 (check_tm_member): New function.
4597 (Fencode_time): Use it, to test for out-of-range times.
4598 (lisp_time_argument): Don't rely on undefined left-shift and
4599 right-shift behavior when checking for time stamp overflow.
4600
4601 * editfns.c (time_overflow): New function, refactoring common code.
4602 (Fformat_time_string, Fdecode_time, Fencode_time):
4603 (Fcurrent_time_string): Use it.
4604
4605 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4606 * dired.c (make_time): Move to ...
4607 * editfns.c (make_time): ... here.
4608 * systime.h: Note the move.
4609
4610 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4611
4612 * fringe.c (update_window_fringes): Remove unused variables.
4613
4614 * unexmacosx.c (copy_data_segment): Also copy __got section.
4615 (Bug#8223)
4616
4617 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4618
4619 * termcap.c [MSDOS]: Include "msdos.h".
4620 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4621 Constify `char *' arguments and their references according to
4622 prototypes in tparam.h.
4623
4624 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4625
4626 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4627 Adapt all references accordingly.
4628
4629 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4630
4631 2011-03-11 Tom Tromey <tromey@redhat.com>
4632
4633 * buffer.c (syms_of_buffer): Remove obsolete comment.
4634
4635 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4636
4637 * termhooks.h (encode_terminal_code): Declare prototype.
4638
4639 * msdos.c (encode_terminal_code): Don't declare prototype.
4640
4641 * term.c (encode_terminal_code): Now external again, used by
4642 w32console.c and msdos.c.
4643
4644 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4645 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4646
4647 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4648
4649 Fix some minor problems found by GCC 4.5.2's static checks.
4650
4651 * fringe.c (update_window_fringes): Mark locals as initialized
4652 (Bug#8227).
4653 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4654
4655 * alloc.c (mark_fringe_data): Move decl from here ...
4656 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4657 to check its interface.
4658 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4659
4660 * fontset.c (free_realized_fontset): Now static.
4661 (Fset_fontset_font): Rename local to avoid shadowing.
4662 (fontset_font): Mark local as initialized.
4663 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4664
4665 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4666
4667 * xselect.c (x_disown_buffer_selections): Remove; not used.
4668 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4669 (x_own_selection, Fx_disown_selection_internal): Rename locals
4670 to avoid shadowing.
4671 (x_handle_dnd_message): Remove local to avoid shadowing.
4672
4673 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4674 so that the caller can use some name other than gcpro1.
4675 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4676 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4677 (Fx_backspace_delete_keys_p):
4678 Use them to avoid shadowing, and rename vars to avoid shadowing.
4679 (x_decode_color, x_set_name, x_window): Now static.
4680 (Fx_create_frame): Add braces to silence GCC warning.
4681 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4682 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4683 Remove unused locals.
4684 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4685 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4686 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4687 macros.
4688
4689 * xterm.h (x_mouse_leave): New decl.
4690
4691 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4692 Remove unused functions.
4693 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4694 (x_calc_absolute_position): Now static.
4695 (XTread_socket): Don't define label "out" unless it's used.
4696 Don't declare local "event" unless it's used.
4697 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4698 unless they are used.
4699 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4700 (x_fatal_error_signal): Remove; not used.
4701 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4702 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4703 (x_error_catcher, x_connection_closed, x_error_handler):
4704 (x_error_quitter, xembed_send_message, x_iconify_frame):
4705 (my_log_handler): Rename locals to avoid shadowing.
4706 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4707 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4708
4709 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4710 Rename or move locals to avoid shadowing.
4711 (tty_defined_color, merge_face_heights): Now static.
4712 (free_realized_faces_for_fontset): Remove; not used.
4713 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4714 does not deduce is never used uninitialized.
4715 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4716 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4717
4718 * terminal.c (store_terminal_param): Now static.
4719
4720 * xmenu.c (menu_highlight_callback): Now static.
4721 (set_frame_menubar): Remove unused local.
4722 (xmenu_show): Rename parameter to avoid shadowing.
4723 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4724 since they might point to immutable storage.
4725 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4726 since it's unused otherwise.
4727
4728 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4729 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4730 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4731 avoids a gcc -Wuninitialized diagnostic.
4732 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4733 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4734 does not deduce are never used uninitialized.
4735
4736 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4737
4738 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4739 * window.c (window_loop, size_window):
4740 (run_window_configuration_change_hook, enlarge_window): Likewise.
4741
4742 * window.c (display_buffer): Now static.
4743 (size_window): Mark variables that gcc -Wuninitialized
4744 does not deduce are never used uninitialized.
4745 * window.h (check_all_windows): New decl, to forestall
4746 gcc -Wmissing-prototypes diagnostic.
4747 * dispextern.h (bidi_dump_cached_states): Likewise.
4748
4749 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4750 shadowing.
4751 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4752 Include <limits.h>.
4753 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4754 and to avoid gcc -Wuninitialized warning.
4755 (load_charset_map): Mark variables that gcc -Wuninitialized
4756 does not deduce are never used uninitialized.
4757 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4758
4759 * coding.c (coding_set_source, coding_set_destination):
4760 Use "else { /* comment */ }" rather than "else /* comment */;"
4761 for clarity, and to avoid gcc -Wempty-body warning.
4762 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4763 a block, when the outer 'i' will do.
4764 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4765 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4766 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4767 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4768 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4769 Rename locals to avoid shadowing.
4770 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4771 * coding.c (emacs_mule_char, encode_invocation_designation):
4772 Now static, since they're not used elsewhere.
4773 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4774 (decode_coding_object, encode_coding_object, detect_coding_system):
4775 (decode_coding_emacs_mule): Mark variables that gcc
4776 -Wuninitialized does not deduce are never used uninitialized.
4777 (detect_coding_iso_2022): Initialize a local variable that might
4778 be used uninitialized. Leave a FIXME because it's not clear that
4779 this initialization is needed. (Bug#8211)
4780 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4781 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4782 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4783 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4784 Remove unused macros.
4785
4786 * category.c (hash_get_category_set): Remove unused local var.
4787 (copy_category_table): Now static, since it's not used elsewhere.
4788 * character.c (string_count_byte8): Likewise.
4789
4790 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4791 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4792
4793 * chartab.c (copy_sub_char_table): Now static, since it's not used
4794 elsewhere.
4795 (sub_char_table_ref_and_range, char_table_ref_and_range):
4796 Rename locals to avoid shadowing.
4797 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4798
4799 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4800 (BIDI_BOB): Remove unused macro.
4801
4802 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4803 deduce are never used uninitialized.
4804 * term.c (encode_terminal_code): Likewise.
4805
4806 * term.c (encode_terminal_code): Now static. Remove unused local.
4807
4808 * tparam.h: New file.
4809 * term.c, tparam.h: Include it.
4810 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4811 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4812 Move these decls to tparam.h, and make them agree with what
4813 is actually in tparam.c. The previous trick of using incompatible
4814 decls in different modules does not conform to the C standard.
4815 All callers of tparam changed to use tparam's actual API.
4816 * tparam.c (tparam1, tparam, tgoto):
4817 Use const pointers where appropriate.
4818
4819 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4820 * cm.h (struct cm): Likewise.
4821 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4822 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4823 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4824 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4825 (turn_on_face, init_tty): Likewise.
4826 * termchar.h (struct tty_display_info): Likewise.
4827
4828 * term.c (term_mouse_position): Rename local to avoid shadowing.
4829
4830 * alloc.c (mark_ttys): Move decl from here ...
4831 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4832
4833 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4834
4835 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4836
4837 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4838
4839 * search.c (compile_pattern_1): Remove argument regp, unused since
4840 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4841 (compile_pattern): Don't pass it.
4842
4843 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4844
4845 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4846 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4847 for ! HAVE_GTK3.
4848 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4849
4850 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4851
4852 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4853 gdk_window_get_screen, gdk_window_get_geometry,
4854 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4855 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4856 (xg_get_pixbuf_from_pixmap): New function.
4857 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4858 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4859 Call xg_get_pixbuf_from_pixmap instead of
4860 gdk_pixbuf_get_from_drawable.
4861 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4862 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4863 (xg_check_special_colors): Use GtkStyleContext and its functions
4864 for HAVE_GTK3.
4865 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4866 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4867 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4868 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4869 Call gtk_widget_get_preferred_size.
4870 (xg_frame_resized): gdk_window_get_geometry only takes 5
4871 parameters.
4872 (xg_win_to_widget, xg_event_is_for_menubar):
4873 Call gdk_x11_window_lookup_for_display.
4874 (xg_set_widget_bg): New function.
4875 (delete_cb): New function.
4876 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4877 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4878 (xg_set_background_color): Call xg_set_widget_bg.
4879 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4880 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4881 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4882 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4883 if ! HAVE_GTK3.
4884 (update_frame_tool_bar): Call gtk_widget_hide.
4885 (xg_initialize): Use GDK_KEY_g.
4886
4887 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4888 if ! HAVE_GTK3
4889 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4890
4891 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4892 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4893 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4894
4895 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4896
4897 * w32xfns.c (select_palette): Check success of RealizePalette against
4898 GDI_ERROR, not zero.
4899
4900 See ChangeLog.11 for earlier changes.
4901
4902 ;; Local Variables:
4903 ;; coding: utf-8
4904 ;; End:
4905
4906 Copyright (C) 2011 Free Software Foundation, Inc.
4907
4908 This file is part of GNU Emacs.
4909
4910 GNU Emacs is free software: you can redistribute it and/or modify
4911 it under the terms of the GNU General Public License as published by
4912 the Free Software Foundation, either version 3 of the License, or
4913 (at your option) any later version.
4914
4915 GNU Emacs is distributed in the hope that it will be useful,
4916 but WITHOUT ANY WARRANTY; without even the implied warranty of
4917 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4918 GNU General Public License for more details.
4919
4920 You should have received a copy of the GNU General Public License
4921 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.