Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-09 Paul Eggert <eggert@cs.ucla.edu>
2
3 * image.c: Integer signedness and overflow and related fixes.
4 This is not an exhaustive set of fixes, but it's time to
5 record what I've got.
6 (lookup_pixel_color, check_image_size): Remove redundant decls.
7 (check_image_size): Don't assume that arbitrary EMACS_INT values
8 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
10 (tiff_load, imagemagick_load_image):
11 Check for overflow in size calculations.
12 (x_create_x_image_and_pixmap): Remove unnecessary test for
13 xmalloc returning NULL; that can't happen.
14 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
15 (xpm_color_bucket): Use better integer hashing function.
16 (xpm_cache_color): Don't possibly over-allocate memory.
17 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
18 (gif_memory_source):
19 Use ptrdiff_t, not int or size_t, to record sizes.
20 (png_load): Don't assume values greater than 2**31 fit in 'int'.
21 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
22 either works, as we prefer signed integers.
23 (tiff_read_from_memory, tiff_write_from_memory):
24 Return tsize_t, not size_t, since that's what the TIFF API wants.
25 (tiff_read_from_memory): Don't fail simply because the read would
26 go past EOF; instead, return a short read.
27 (tiff_load): Omit no-longer-needed casts.
28 (Fimagemagick_types): Don't assume size fits into 'int'.
29
30 Improve hashing quality when configured --with-wide-int.
31 * fns.c (hash_string): New function, taken from sxhash_string.
32 Do not discard information about ASCII character case; this
33 discarding is no longer needed.
34 (sxhash-string): Use it. Change sig to match it. Caller changed.
35 * lisp.h: Declare it.
36 * lread.c (hash_string): Remove, since we now use fns.c's version.
37 The fns.c version returns a wider integer if --with-wide-int is
38 specified, so this should help the quality of the hashing a bit.
39
40 * emacs.c: Integer overflow minor fix.
41 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
42 Define only if GNU_LINUX.
43 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
44
45 * dispnew.c: Integer signedness and overflow fixes.
46 Remove unnecessary forward decls, that were a maintenance hassle.
47 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
48 All uses changed.
49 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
50 (scrolling_window): Use ptrdiff_t, not int, for byte count.
51 (prepare_desired_row, line_draw_cost):
52 Use int, not unsigned, where either works.
53 (save_current_matrix, restore_current_matrix):
54 Use ptrdiff_t, not size_t, where either works.
55 (init_display): Check for overflow more accurately, and without
56 relying on undefined behavior.
57
58 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
59 Remove, replacing with the new symbols in lisp.h. All uses changed.
60 * fileio.c (make_temp_name):
61 * filelock.c (lock_file_1, lock_file):
62 * xdisp.c (message_dolog):
63 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
64 Use pMd etc. instead.
65 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
66 replacing the pWIDE etc. symbols removed from editfns.c.
67
68 * keyboard.h (num_input_events): Now uintmax_t.
69 This is (very slightly) less likely to mess up due to wraparound.
70 All uses changed.
71
72 * buffer.c: Integer signedness fixes.
73 (alloc_buffer_text, enlarge_buffer_text):
74 Use ptrdiff_t rather than size_t when either will do, as we prefer
75 signed integers.
76
77 * bidi.c: Integer signedness and overflow fixes.
78 (bidi_cache_idx, bidi_cache_last_idx, bidi_cache_fetch_state)
79 (bidi_cache_search, bidi_cache_find_level_change)
80 (bidi_cache_iterator_state, bidi_cache_find, bidi_find_other_level_edge)
81 (bidi_dump_cached_states):
82 Don't arbitrarily limit cache indexes to int; use ptrdiff_t instead.
83 (bidi_cache_size): Use ptrdiff_t rather than size_t, as we prefer
84 signed integers.
85 (elsz): Make it a (signed) constant.
86 (bidi_cache_iterator_state): Check for size-calculation overflow.
87
88 * alloc.c: Integer signedness and overflow fixes.
89 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
90 (__malloc_size_t): Default to size_t, not to int.
91 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
92 (Fgarbage_collect, mark_object_loop_halt, mark_object):
93 Prefer ptrdiff_t to size_t when either would do, as we prefer
94 signed integers.
95 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
96 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
97 Now const. Initialize with values that are in range even if char
98 is signed.
99 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
100 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
101 These functions do the right thing with sizes > 2**32.
102 (check_depth): Now ptrdiff_t, not int.
103 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
104 Adjust to new way of storing sizes. Check for size overflow bugs
105 in rest of code.
106 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
107 slightly wrong anyway, as it missed one instance of
108 XMALLOC_OVERRUN_CHECK_OVERHEAD.
109 (refill_memory_reserve): Omit needless cast to size_t.
110 (mark_object_loop_halt): Mark as externally visible.
111
112 * xselect.c: Integer signedness and overflow fixes.
113 (Fx_register_dnd_atom, x_handle_dnd_message):
114 Use ptrdiff_t, not size_t, since we prefer signed.
115 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
116 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
117 x_dnd_atoms_size and x_dnd_atoms_length.
118
119 * doprnt.c: Prefer signed to unsigned when either works.
120 * eval.c (verror):
121 * doprnt.c (doprnt):
122 * lisp.h (doprnt):
123 * xdisp.c (vmessage):
124 Use ptrdiff_t, not size_t, when using or implementing doprnt,
125 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
126 prefer signed arithmetic to avoid comparison confusion.
127 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
128 but is a bit tricky.
129
130 Assume freestanding C89 headers, string.h, stdlib.h.
131 * data.c, doprnt.c, floatfns.c, print.c:
132 Include float.h unconditionally.
133 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
134 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
135 * regex.c: Likewise for stddef.h, string.h.
136 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
137 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
138 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
139 (STDC_HEADERS): Remove obsolete defines.
140 * sysdep.c: Include limits.h unconditionally.
141
142 Assume support for memcmp, memcpy, memmove, memset.
143 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
144 * regex.c (memcmp, memcpy):
145 Remove; we assume C89 now.
146
147 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
148 (__malloc_safe_bcopy): Remove; no longer needed.
149
150 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
151 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
152 well either way, and we prefer signed to unsigned.
153
154 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
155
156 Use pthread_sigmask, not sigprocmask (Bug#9010).
157 sigprocmask is portable only for single-threaded applications, and
158 Emacs can be multi-threaded when it uses GTK.
159 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
160 (LIBES): Use it.
161 * callproc.c (Fcall_process):
162 * process.c (create_process):
163 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
164 Use pthread_sigmask, not sigprocmask.
165
166 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
167
168 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
169 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
170 wrong (Bug#8591).
171
172 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
173
174 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
175 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
176 (xg_hide_tooltip): Fix comment.
177
178 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
179 in registerServicesMenuSendTypes.
180 (validRequestorForSendType): Don't check ns_return_types.
181
182 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
183 ns_return_type.
184
185 2011-07-08 Jason Rumney <jasonr@gnu.org>
186
187 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
188 frame struct members of non-existent frames (Bug#6284).
189
190 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
191
192 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
193 variable firstTime not needed on OSX >= 10.6.
194 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
195 >= 10.5. Use setKnobProportion, setDoubleValue.
196
197 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
198 (MAC_OS_X_VERSION_10_5): Define if not defined.
199 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
200 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
201 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
202
203 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
204 cString and lossyCString on OSX >= 10.4
205
206 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
207 sizeToFit on OSX >= 10.2.
208
209 * nsimage.m (allocInitFromFile): Don't use deprecated method
210 bestRepresentationForDevice on OSX >= 10.6.
211
212 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
213 to avoid warning.
214
215 * emacs.c: Declare unexec_init_emacs_zone.
216
217 * nsgui.h: Fix compiler warning about gnulib redefining verify.
218
219 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
220
221 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
222 on svcsMenu (Bug#8842).
223
224 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
225 ns_return_types.
226 (Fns_list_services): Just return Qnil on 10.6, code not working there.
227
228 * nsterm.m (QUTF8_STRING): Declare.
229 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
230 (validRequestorForSendType): Return type is (id).
231 Change indexOfObjectIdenticalTo to indexOfObject.
232 Check if we have local selection before returning self (Bug#8842).
233 (writeSelectionToPasteboard): Put local selection into paste board
234 if we have a local selection (Bug#8842).
235 (syms_of_nsterm): DEFSYM QUTF8_STRING.
236
237 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
238 (ns_get_local_selection): Declare.
239
240 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
241
242 * keymap.c (describe_map_tree): Don't insert a double newline at
243 the end of the buffer (bug#1169) and return whether we inserted
244 something.
245
246 * callint.c (Fcall_interactively): Change "reading args" to
247 "providing args" to try to clarify what it does (bug#1010).
248
249 2011-07-07 Kenichi Handa <handa@m17n.org>
250
251 * composite.c (composition_compute_stop_pos): Ignore a static
252 composition starting before CHARPOS (Bug#8915).
253
254 * xdisp.c (handle_composition_prop): Likewise.
255
256 2011-07-07 Eli Zaretskii <eliz@gnu.org>
257
258 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
259 (Bug#9015)
260
261 2011-07-07 Kenichi Handa <handa@m17n.org>
262
263 * character.h (unicode_category_t): New enum type.
264
265 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
266 (Qchar_code_property_table): New variable.
267 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
268 (UNIPROP_COMPRESSED_FORM_P): New macros.
269 (char_table_ascii): Uncompress the compressed values.
270 (sub_char_table_ref): New arg is_uniprop. Callers changed.
271 Uncompress the compressed values.
272 (sub_char_table_ref_and_range): Likewise.
273 (char_table_ref_and_range): Uncompress the compressed values.
274 (sub_char_table_set): New arg is_uniprop. Callers changed.
275 Uncompress the compressed values.
276 (sub_char_table_set_range): Args changed. Callers changed.
277 (char_table_set_range): Adjuted for the above change.
278 (map_sub_char_table): Delete args default_val and parent. Add arg
279 top. Give decoded values to a Lisp function.
280 (map_char_table): Adjusted for the above change. Give decoded
281 values to a Lisp function. Gcpro more variables.
282 (uniprop_table_uncompress)
283 (uniprop_decode_value_run_length): New functions.
284 (uniprop_decoder, uniprop_decoder_count): New variables.
285 (uniprop_get_decoder, uniprop_encode_value_character)
286 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
287 New functions.
288 (uniprop_encoder, uniprop_encoder_count): New variables.
289 (uniprop_get_encoder, uniprop_table)
290 (Funicode_property_table_internal, Fget_unicode_property_internal)
291 (Fput_unicode_property_internal): New functions.
292 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
293 Sunicode_property_table_internal, Sget_unicode_property_internal,
294 and Sput_unicode_property_internal. Defvar_lisp
295 char-code-property-alist.
296
297 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
298 Vunicode_category_table.
299
300 * font.c (font_range): Adjusted for the change of
301 Vunicode_category_table.
302
303 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
304
305 * m/iris4d.h: Remove file, move contents ...
306 * s/irix6-5.h: ... here.
307
308 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
309
310 Remove unportable assumption about struct layout (Bug#8884).
311 * alloc.c (mark_buffer):
312 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
313 (clone_per_buffer_values): Don't assume that
314 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
315 This isn't true in general, and it's particularly not true
316 if Emacs is configured with --with-wide-int.
317 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
318 New macros, used in the buffer.c change.
319
320 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
321
322 * xsettings.c: Use both GConf and GSettings if both are available.
323 (store_config_changed_event): Add comment.
324 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
325 (store_tool_bar_style_changed): New functions.
326 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
327 (struct xsettings): Move font inside HAVE_XFT.
328 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
329 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
330 Move inside HAVE_XFT.
331 (something_changed_gsettingsCB): Renamed from something_changedCB.
332 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
333 also.
334 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
335 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
336 (something_changed_gconfCB): Renamed from something_changedCB.
337 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
338 (parse_settings): Move check for font inside HAVE_XFT.
339 (read_settings, apply_xft_settings): Add comment.
340 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
341 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
342 call store_font_name_changed.
343 (xft_settings_event): Add comment.
344 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
345 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
346 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
347 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
348 (xsettings_initialize): Call init_gsettings last.
349 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
350 comment.
351
352 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
353
354 Random fixes. E.g., (random) never returned negative values.
355 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
356 subseconds part to the entropy, as that's a bit more random.
357 Prefer signed to unsigned, since the signedness doesn't matter and
358 in general we prefer signed. When given a limit, use a
359 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
360 latter isn't right if USE_2_TAGS_FOR_INTS.
361 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
362 not 0..VALMASK. Don't discard "excess" bits that random () returns.
363
364 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
365
366 * textprop.c (text_property_stickiness):
367 Obey Vtext_property_default_nonsticky.
368 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
369 * w32fns.c (syms_of_w32fns):
370 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
371
372 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
373
374 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
375 This is more efficient than Ffile_directory_p and avoids a minor race.
376
377 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
378
379 * buffer.c (Foverlay_put): Say what the return value is
380 (bug#7835).
381
382 * fileio.c (barf_or_query_if_file_exists): Check first if the file
383 is a directory before asking whether to use the file name
384 (bug#7564).
385 (barf_or_query_if_file_exists): Make the "File is a directory"
386 error be more correct.
387
388 * fns.c (Frequire): Remove the mention of the .gz files, since
389 that's installation-specific, but keep the mention of
390 `get-load-suffixes'.
391
392 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
393
394 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
395 Report string overflow if the output is too long.
396
397 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
398
399 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
400 (syms_of_gnutls): Remove duplicate DEFSYM for
401 Qgnutls_bootprop_verify_hostname_error, an error for
402 Qgnutls_bootprop_verify_error (which is no longer used).
403
404 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
405 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
406 Also (re)move comments that are misplaced or no longer relevant.
407
408 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
409
410 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
411
412 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
413
414 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
415 and background color parameters if they have been changed.
416
417 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
418
419 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
420
421 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
422
423 * xsettings.c (SYSTEM_FONT): Define only when used.
424 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
425
426 * keymap.c (access_keymap_1): Now static.
427
428 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
429
430 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
431 leave any prefix arg for the up event (Bug#1586).
432
433 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
434
435 * lread.c (syms_of_lread): Mention single symbols defined by
436 `defvar' or `defconst' (bug#7154).
437
438 * fns.c (Frequire): Mention .el.gz files (bug#7314).
439 (Frequire): Mention get-load-suffixes.
440
441 2011-07-02 Martin Rudalics <rudalics@gmx.at>
442
443 * window.h (window): Remove clone_number slot.
444 * window.c (Fwindow_clone_number, Fset_window_clone_number):
445 Remove.
446 (make_parent_window, make_window, saved_window)
447 (Fset_window_configuration, save_window_save): Don't deal with
448 clone numbers.
449 * buffer.c (Qclone_number): Remove declaration.
450 (sort_overlays, overlay_strings): Don't deal with clone numbers.
451
452 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
453
454 Add multiple inheritance to keymaps.
455 * keymap.c (Fmake_composed_keymap): New function.
456 (Fset_keymap_parent): Simplify.
457 (fix_submap_inheritance): Remove.
458 (access_keymap_1): New function extracted from access_keymap to handle
459 embedded parents and handle lists of maps.
460 (access_keymap): Use it.
461 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
462 (Fcopy_keymap): Handle embedded parents.
463 (Fcommand_remapping, define_as_prefix): Simplify.
464 (Fkey_binding): Simplify.
465 (syms_of_keymap): Move minibuffer-local-completion-map,
466 minibuffer-local-filename-completion-map,
467 minibuffer-local-must-match-map, and
468 minibuffer-local-filename-must-match-map to Elisp.
469 (syms_of_keymap): Defsubr make-composed-keymap.
470 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
471 (parse_menu_item): Trivial simplification.
472
473 2011-07-01 Glenn Morris <rgm@gnu.org>
474
475 * Makefile.in (SETTINGS_LIBS): Fix typo.
476
477 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
478
479 * coding.c (Fencode_coding_string): Record the last coding system
480 used, as the function doc string says (bug#8738).
481
482 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
483
484 * xsettings.c (store_monospaced_changed): Take new font as arg and
485 check for change against current_mono_font.
486 (EMACS_TYPE_SETTINGS): Remove this and related defines.
487 (emacs_settings_constructor, emacs_settings_get_property)
488 (emacs_settings_set_property, emacs_settings_class_init)
489 (emacs_settings_init, gsettings_obj): Remove.
490 (something_changedCB): New function for HAVE_GSETTINGS.
491 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
492 with value as argument.
493 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
494 g_settings_new (Bug#8967). Do not create gsettings_obj.
495 Remove calls to g_settings_bind. Connect something_changedCB to
496 "changed".
497
498 * xgselect.c: Add defined (HAVE_GSETTINGS).
499 (xgselect_initialize): Ditto.
500
501 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
502 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
503 xg_select.
504
505 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
506
507 * eval.c (struct backtrace): Simplify and port the data structure.
508 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
509 signed bit field, as this assumption is not portable and it makes
510 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
511 "char debug_on_exit : 1" as this is not portable either; instead,
512 use the portable "unsigned int debug_on_exit : 1". Remove unused
513 member evalargs. Remove obsolete comments about cc bombing out.
514
515 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
516
517 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
518 Let HAVE_GSETTINGS override HAVE_GCONF.
519 (store_monospaced_changed): New function.
520 (EMACS_SETTINGS): A new type derived from GObject to handle
521 GSettings notifications.
522 (emacs_settings_constructor, emacs_settings_get_property)
523 (emacs_settings_set_property, emacs_settings_class_init):
524 New functions.
525 (gsettings_client, gsettings_obj): New variables.
526 (GSETTINGS_SCHEMA): New define.
527 (something_changedCB): Call store_monospaced_changed.
528 (init_gsettings): New function.
529 (xsettings_initialize): Call init_gsettings.
530 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
531 to NULL.
532
533 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
534 GCONF_CFLAGS/LIBS.
535
536 2011-06-29 Martin Rudalics <rudalics@gmx.at>
537
538 * window.c (resize_root_window, grow_mini_window)
539 (shrink_mini_window): Rename Qresize_root_window to
540 Qwindow_resize_root_window and Qresize_root_window_vertically to
541 Qwindow_resize_root_window_vertically.
542
543 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
544
545 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
546
547 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
548
549 * makefile.w32-in: Redesign dependencies so they reflect more
550 clearly which files are directly included by each source file,
551 and not through other includes.
552
553 2011-06-27 Martin Rudalics <rudalics@gmx.at>
554
555 * buffer.c (Qclone_number): Declare static and DEFSYM it.
556 (sort_overlays, overlay_strings): When an overlay's clone number
557 matches the window's clone number process the overlay even if
558 the overlay's window property doesn't match the current window.
559
560 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
561 (Fwindow_hchild): Rename to Fwindow_left_child.
562 (Fwindow_next): Rename to Fwindow_next_sibling.
563 (Fwindow_prev): Rename to Fwindow_prev_sibling.
564 (resize_window_check): Rename to window_resize_check.
565 (resize_window_apply): Rename to window_resize_apply.
566 (Fresize_window_apply): Rename to Fwindow_resize_apply.
567 (Fdelete_other_windows_internal, resize_frame_windows)
568 (Fsplit_window_internal, Fdelete_window_internal)
569 (grow_mini_window, shrink_mini_window)
570 (Fresize_mini_window_internal): Fix callers accordingly.
571
572 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
573
574 * emacsgtkfixed.h: State that this is only used with Gtk+3.
575 (emacs_fixed_set_min_size): Remove.
576 (emacs_fixed_new): Take frame as argument.
577
578 * emacsgtkfixed.c: State that this is only used with Gtk+3.
579 (_EmacsFixedPrivate): Remove minwidth/height.
580 Add struct frame *f.
581 (emacs_fixed_init): Initialize priv->f.
582 (get_parent_class, emacs_fixed_set_min_size): Remove.
583 (emacs_fixed_new): Set priv->f to argument.
584 (emacs_fixed_get_preferred_width)
585 (emacs_fixed_get_preferred_height): Use min_width/height from
586 frames size_hint to set minimum and natural (Bug#8919).
587 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
588 and use min_width/height from frames size_hint to set
589 min_width/height (Bug#8919).
590
591 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
592 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
593 Fix indentation.
594
595 2011-06-26 Eli Zaretskii <eliz@gnu.org>
596
597 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
598 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
599 called at ZV.
600
601 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
602
603 * process.c (wait_reading_process_output): Bypass select if
604 waiting for a cell while ignoring keyboard input, and input is
605 pending. Suggested by Jan Djärv (Bug#8869).
606
607 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
608
609 Use gnulib's dup2 module instead of rolling our own.
610 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
611
612 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
613
614 * dispnew.c (scrolling_window): Before scrolling, turn off a
615 mouse-highlight in the window being scrolled.
616
617 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
618
619 Move DEFSYM to lisp.h and use everywhere.
620
621 * character.h (DEFSYM): Move declaration...
622 * lisp.h (DEFSYM): ...here.
623
624 * gnutls.c:
625 * minibuf.c:
626 * w32menu.c:
627 * w32proc.c:
628 * w32select.c: Don't include character.h.
629
630 * alloc.c (syms_of_alloc):
631 * buffer.c (syms_of_buffer):
632 * bytecode.c (syms_of_bytecode):
633 * callint.c (syms_of_callint):
634 * casefiddle.c (syms_of_casefiddle):
635 * casetab.c (init_casetab_once):
636 * category.c (init_category_once, syms_of_category):
637 * ccl.c (syms_of_ccl):
638 * cmds.c (syms_of_cmds):
639 * composite.c (syms_of_composite):
640 * dbusbind.c (syms_of_dbusbind):
641 * dired.c (syms_of_dired):
642 * dispnew.c (syms_of_display):
643 * doc.c (syms_of_doc):
644 * editfns.c (syms_of_editfns):
645 * emacs.c (syms_of_emacs):
646 * eval.c (syms_of_eval):
647 * fileio.c (syms_of_fileio):
648 * fns.c (syms_of_fns):
649 * frame.c (syms_of_frame):
650 * fringe.c (syms_of_fringe):
651 * insdel.c (syms_of_insdel):
652 * keymap.c (syms_of_keymap):
653 * lread.c (init_obarray, syms_of_lread):
654 * macros.c (syms_of_macros):
655 * msdos.c (syms_of_msdos):
656 * print.c (syms_of_print):
657 * process.c (syms_of_process):
658 * search.c (syms_of_search):
659 * sound.c (syms_of_sound):
660 * syntax.c (init_syntax_once, syms_of_syntax):
661 * terminal.c (syms_of_terminal):
662 * textprop.c (syms_of_textprop):
663 * undo.c (syms_of_undo):
664 * w32.c (globals_of_w32):
665 * window.c (syms_of_window):
666 * xdisp.c (syms_of_xdisp):
667 * xfaces.c (syms_of_xfaces):
668 * xfns.c (syms_of_xfns):
669 * xmenu.c (syms_of_xmenu):
670 * xsettings.c (syms_of_xsettings):
671 * xterm.c (syms_of_xterm): Use DEFSYM.
672
673 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
674
675 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
676
677 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
678
679 Integer and buffer overflow fixes (Bug#8873).
680
681 * print.c (printchar, strout): Check for string overflow.
682 (PRINTPREPARE, printchar, strout):
683 Don't set size unless allocation succeeds.
684
685 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
686 for sizes. Check for string overflow more accurately.
687 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
688
689 * macros.c: Integer and buffer overflow fixes.
690 * keyboard.h (struct keyboard.kbd_macro_bufsize):
691 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
692 Use ptrdiff_t, not int, for sizes.
693 Don't increment bufsize until after realloc succeeds.
694 Check for size-calculation overflow.
695 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
696
697 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
698
699 * lread.c: Integer overflow fixes.
700 (read_integer): Radix is now EMACS_INT, not int,
701 to improve quality of diagnostics for out-of-range radices.
702 Calculate buffer size correctly for out-of-range radices.
703 (read1): Check for integer overflow in radices, and in
704 read-circle numbers.
705 (read_escape): Avoid int overflow.
706 (Fload, openp, read_buffer_size, read1)
707 (substitute_object_recurse, read_vector, read_list, map_obarray):
708 Use ptrdiff_t, not int, for sizes.
709 (read1): Use EMACS_INT, not int, for sizes.
710 Check for size overflow.
711
712 * image.c (cache_image): Check for size arithmetic overflow.
713
714 * lread.c: Integer overflow issues.
715 (saved_doc_string_size, saved_doc_string_length)
716 (prev_saved_doc_string_size, prev_saved_doc_string_length):
717 Now ptrdiff_t, not int.
718 (read1): Don't assume doc string length fits in int. Check for
719 out-of-range doc string lengths.
720 (read_list): Don't assume file position fits in int.
721 (read_escape): Check for hex character overflow.
722
723 2011-06-22 Leo Liu <sdl.web@gmail.com>
724
725 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
726 Move to minibuffer.el.
727
728 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
729
730 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
731 The following patches are for when GLYPH_DEBUG && !XASSERT.
732 * dispextern.h (trace_redisplay_p, dump_glyph_string):
733 * dispnew.c (flush_stdout):
734 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
735 Mark as externally visible.
736 * dispnew.c (check_window_matrix_pointers): Now static.
737 * dispnew.c (window_to_frame_vpos):
738 * xfns.c (unwind_create_frame):
739 * xterm.c (x_check_font): Remove unused local.
740 * scroll.c (CHECK_BOUNDS):
741 * xfaces.c (cache_fache): Rename local to avoid shadowing.
742 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
743 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
744 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
745 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
746 Now static.
747 (debug_method_add): Use va_list and vsprintf rather than relying
748 on undefined behavior with wrong number of arguments.
749 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
750 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
751 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
752 since we're not interested in debugging glyphs with old libraries.
753 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
754 GCC 4.6.0's static checking.
755
756 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
757
758 Integer overflow and signedness fixes (Bug#8873).
759 A few related buffer overrun fixes, too.
760
761 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
762
763 * dispextern.h (struct face.stipple):
764 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
765 (x_bitmap_mask, x_allocate_bitmap_record)
766 (x_create_bitmap_from_data, x_create_bitmap_from_file)
767 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
768 (x_create_bitmap_from_xpm_data):
769 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
770 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
771 (.bitmaps_last):
772 * xfaces.c (load_pixmap):
773 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
774 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
775 (.bitmaps_last, struct x_output.icon_bitmap):
776 Use ptrdiff_t, not int, for bitmap indexes.
777 (x_allocate_bitmap_record): Check for size overflow.
778 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
779
780 Use ptrdiff_t, not int, for overlay counts.
781 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
782 * editfns.c (overlays_around, get_pos_property):
783 * textprop.c (get_char_property_and_overlay):
784 * xdisp.c (next_overlay_change, note_mouse_highlight):
785 * xfaces.c (face_at_buffer_position):
786 * buffer.c (OVERLAY_COUNT_MAX): New macro.
787 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
788 (Fnext_overlay_change, Fprevious_overlay_change)
789 (mouse_face_overlay_overlaps, Foverlays_in):
790 Use ptrdiff_t, not int, for sizes.
791 (overlays_at, overlays_in): Check for size-calculation overflow.
792
793 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
794
795 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
796 (x_session_initialize): Do not assume string length fits in int.
797
798 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
799 This is unlikely, but can occur if DPI is outlandish.
800
801 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
802 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
803
804 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
805 * xrdb.c (magic_file_p, search_magic_path):
806 Omit last arg SUFFIX; it was always 0. All callers changed.
807 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
808
809 * xfont.c (xfont_match): Avoid need for strlen.
810
811 * xfns.c: Don't assume strlen fits in int.
812 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
813
814 * xdisp.c (message_log_check_duplicate): Return intmax_t,
815 not unsigned long, as we prefer signed integers. All callers changed.
816 Detect integer overflow in repeat count.
817 (message_dolog): Don't assume print length fits in 39 bytes.
818 (display_mode_element): Don't assume strlen fits in int.
819
820 * termcap.c: Don't assume sizes fit in int and never overflow.
821 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
822 (gobble_line): Check for size-calculation overflow.
823
824 * minibuf.c (Fread_buffer):
825 * lread.c (intern, intern_c_string):
826 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
827 Don't assume string length fits in int.
828
829 * keyboard.c (parse_tool_bar_item):
830 * gtkutil.c (style_changed_cb): Avoid need for strlen.
831
832 * font.c: Don't assume string length fits in int.
833 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
834 Use ptrdiff_t, not int.
835 (font_intern_prop): Don't assume string length fits in int.
836 Don't assume integer property fits in fixnum.
837 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
838
839 * filelock.c: Fix some buffer overrun and integer overflow issues.
840 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
841 Reformulate so as not to need the command string.
842 Invoke gzip -cd rather than gunzip, as it's more portable.
843 (lock_info_type, lock_file_1, lock_file):
844 Don't assume pid_t and time_t fit in unsigned long.
845 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
846 (current_lock_owner): Prefer signed type for sizes.
847 Use memcpy, not strncpy, where memcpy is what is really wanted.
848 Don't assume (via atoi) that time_t and pid_t fit in int.
849 Check for time_t and/or pid_t out of range, e.g., via a network share.
850 Don't alloca where an auto var works fine.
851
852 * fileio.c: Fix some integer overflow issues.
853 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
854 Don't assume string length fits in int.
855 (directory_file_name): Don't assume string length fits in long.
856 (make_temp_name): Don't assume pid fits in int, or that its print
857 length is less than 20.
858
859 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
860
861 * coding.c (make_subsidiaries): Don't assume string length fits in int.
862
863 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
864
865 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
866 We prefer signed integers, even for size calculations.
867
868 * emacs.c: Don't assume string length fits in 'int'.
869 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
870 (main): Don't invoke strlen when not needed.
871
872 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
873 (XD_DEBUG_MESSAGE): Don't waste a byte.
874
875 * callproc.c (getenv_internal_1, getenv_internal)
876 (Fgetenv_internal):
877 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
878
879 * lread.c (invalid_syntax): Omit length argument.
880 All uses changed. This doesn't fix a bug, but it simplifies the
881 code away from its former Hollerith-constant appearance, and it's
882 one less 'int' to worry about when looking at integer-overflow issues.
883 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
884
885 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
886 This didn't break anything, but it didn't help either.
887 It's confusing to put a bogus integer in a place where the actual
888 value does not matter.
889 (LIST_END_P): Remove unused macro and its bogus comment.
890 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
891
892 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
893 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
894 implementation.
895 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
896 We prefer signed types, and the value cannot exceed the EMACS_INT
897 range anyway (because otherwise the length would not be representable).
898 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
899 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
900 This avoids a GCC warning when WIDE_EMACS_INT.
901
902 * indent.c (sane_tab_width): New function.
903 (current_column, scan_for_column, Findent_to, position_indentation)
904 (compute_motion): Use it. This is just for clarity.
905 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
906
907 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
908
909 * lisp.h (lint_assume): New macro.
910 * composite.c (composition_gstring_put_cache):
911 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
912
913 * editfns.c, insdel.c:
914 Omit unnecessary forward decls, to simplify future changes.
915
916 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
917
918 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
919
920 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
921 Use much-faster test for byte-length change.
922 Don't assume string byte-length fits in 'int'.
923 Check that character arg fits in 'int'.
924 (mapcar1): Declare byte as byte, for clarity.
925
926 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
927
928 * fns.c (concat): Catch string overflow earlier.
929 Do not rely on integer wraparound.
930
931 * dispextern.h (struct it.overlay_strings_charpos)
932 (struct it.selective): Now EMACS_INT, not int.
933 * xdisp.c (forward_to_next_line_start)
934 (back_to_previous_visible_line_start)
935 (reseat_at_next_visible_line_start, next_element_from_buffer):
936 Don't arbitrarily truncate the value of 'selective' to int.
937
938 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
939
940 * composite.c: Don't truncate sizes to 'int'.
941 (composition_gstring_p, composition_reseat_it)
942 (composition_adjust_point): Use EMACS_INT, not int.
943 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
944 not EMACS_UINT, for indexes.
945
946 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
947
948 * buffer.c: Include <verify.h>.
949 (struct sortvec.priority, struct sortstr.priority):
950 Now EMACS_INT, not int.
951 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
952 (struct sortstr.size, record_overlay_string)
953 (struct sortstrlist.size, struct sortlist.used):
954 Don't truncate size to int.
955 (record_overlay_string): Check for size-calculation overflow.
956 (init_buffer_once): Check at compile-time, not run-time.
957
958 2011-06-22 Jim Meyering <meyering@redhat.com>
959
960 Don't leak an XBM-image-sized buffer
961 * image.c (xbm_load): Free the image buffer after using it.
962
963 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
964
965 Port to Sun C.
966 * composite.c (find_automatic_composition): Omit needless 'return 0;'
967 that Sun C diagnosed.
968 * fns.c (secure_hash): Fix pointer signedness issue.
969 * intervals.c (static_offset_intervals): New function.
970 (offset_intervals): Use it.
971
972 2011-06-21 Leo Liu <sdl.web@gmail.com>
973
974 * deps.mk (fns.o):
975 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
976 sha512.h.
977
978 * fns.c (secure_hash): Rename from crypto_hash_function and change
979 the first arg to accept symbols.
980 (Fsecure_hash): New primitive.
981 (syms_of_fns): New symbols.
982
983 2011-06-20 Deniz Dogan <deniz@dogan.se>
984
985 * process.c (Fset_process_buffer): Clarify return value in
986 docstring.
987
988 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
989
990 * dispnew.c (add_window_display_history): Use BVAR.
991
992 * xdisp.c (debug_method_add): Use BVAR.
993 (check_window_end, dump_glyph_matrix, dump_glyph)
994 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
995
996 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
997 Likewise.
998
999 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1000 check till after the cache is created in init_frame_faces.
1001
1002 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1003
1004 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1005
1006 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1007
1008 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1009 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1010 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1011
1012 Improve buffer-overflow checking (Bug#8873).
1013 * fileio.c (Finsert_file_contents):
1014 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1015 Remove the old (too-loose) buffer overflow checks.
1016 They weren't needed, since make_gap checks for buffer overflow.
1017 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1018 The old code merely checked for Emacs fixnum overflow, and relied
1019 on undefined (wraparound) behavior. The new code avoids undefined
1020 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1021
1022 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1023 Tune. Don't use wider integers than needed. Don't use alloca.
1024 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1025
1026 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1027
1028 * insdel.c, lisp.h (buffer_overflow): New function.
1029 (insert_from_buffer_1, replace_range, replace_range_2):
1030 * insdel.c (make_gap_larger):
1031 * editfns.c (Finsert_char):
1032 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1033
1034 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1035
1036 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1037
1038 Integer overflow and signedness fixes (Bug#8873).
1039
1040 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1041 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1042
1043 * fileio.c: Don't assume EMACS_INT fits in off_t.
1044 (emacs_lseek): New static function.
1045 (Finsert_file_contents, Fwrite_region): Use it.
1046 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1047
1048 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1049
1050 * fns.c: Don't overflow int when computing a list length.
1051 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1052 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1053 truncation on 64-bit hosts. Check for QUIT every
1054 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1055 faster and is responsive enough.
1056 (Flength): Report an error instead of overflowing an integer.
1057 (Fsafe_length): Return a float if the value is not representable
1058 as a fixnum. This shouldn't happen except in contrived situations.
1059 (Fnthcdr, Fsort): Don't assume list length fits in int.
1060 (Fcopy_sequence): Don't assume vector length fits in int.
1061
1062 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1063 (header_size, word_size): New constants.
1064 (allocate_vectorlike): Don't check size overflow here.
1065 (allocate_vector): Check it here instead, since this is the only
1066 caller of allocate_vectorlike that could cause overflow.
1067 Check that the new vector's length is representable as a fixnum.
1068
1069 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1070 The previous code was bogus. For example, next_almost_prime (32)
1071 returned 39, which is undesirable as it is a multiple of 3; and
1072 next_almost_prime (24) returned 25, which is a multiple of 5 so
1073 why was the code bothering to check for multiples of 7?
1074
1075 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1076
1077 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1078
1079 Variadic C functions now count arguments with ptrdiff_t.
1080 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1081 Back then I didn't know that the Emacs coding style prefers signed int.
1082 Also, in the meantime I found a few more instances where arguments
1083 were being counted with int, which may truncate counts on 64-bit
1084 machines, or EMACS_INT, which may be unnecessarily wide.
1085 * lisp.h (struct Lisp_Subr.function.aMANY)
1086 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1087 Arg counts are now ptrdiff_t, not size_t.
1088 All variadic functions and their callers changed accordingly.
1089 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1090 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1091 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1092 * callint.c (Fcall_interactively): Check arg count for overflow,
1093 to avoid potential buffer overrun. Use signed char, not 'int',
1094 for 'varies' array, so that we needn't bother to check its size
1095 calculation for overflow.
1096 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1097 * eval.c (apply_lambda):
1098 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1099 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1100 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1101
1102 * callint.c (Fcall_interactively): Don't use index var as event count.
1103
1104 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1105 * mem-limits.h (SIZE): Remove; no longer used.
1106
1107 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1108
1109 Remove unnecessary casts.
1110 * xterm.c (x_term_init):
1111 * xfns.c (x_set_border_pixel):
1112 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1113 These aren't needed now that we assume ANSI C.
1114
1115 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1116 It's more likely to cause problems (due to unsigned overflow)
1117 than to cure them.
1118
1119 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1120
1121 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1122
1123 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1124
1125 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1126
1127 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1128
1129 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1130
1131 GLYPH_CODE_FACE returns EMACS_INT, not int.
1132 * dispextern.h (merge_faces):
1133 * xfaces.c (merge_faces):
1134 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1135 Don't assume EMACS_INT fits in int.
1136
1137 * character.h (CHAR_VALID_P): Remove unused parameter.
1138 * fontset.c, lisp.h, xdisp.c: All uses changed.
1139
1140 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1141
1142 * fns.c (concat): Minor tuning based on overflow analysis.
1143 This doesn't fix any bugs. Use int to hold character, instead
1144 of constantly refetching from Emacs object. Use XFASTINT, not
1145 XINT, for value known to be a character. Don't bother comparing
1146 a single byte to 0400, as it's always less.
1147
1148 * floatfns.c (Fexpt):
1149 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1150
1151 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1152 for characters.
1153
1154 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1155
1156 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1157 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1158 incorrectly succeed when S was a string, because 4294967386 was
1159 truncated before it was used.
1160
1161 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1162 Otherwise, an out-of-range integer could cause undefined behavior
1163 on a 64-bit host.
1164
1165 * composite.c: Use int, not EMACS_INT, for characters.
1166 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1167 EMACS_INT, for values that are known to be in character range.
1168 This doesn't fix any bugs but is the usual style inside Emacs and
1169 may generate better code on 32-bit machines.
1170
1171 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1172 This is for reasons similar to the recent CHAR_STRING fix.
1173 * charset.c (Fencode_char): Check that character arg is actually
1174 a character. Pass an int to ENCODE_CHAR.
1175 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1176 wider than 'int', as a compile-time check to prevent future regressions
1177 in this area.
1178
1179 * character.c (char_string): Remove unnecessary casts.
1180
1181 Make sure a 64-bit char is never passed to CHAR_STRING.
1182 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1183 by silently ignoring the top 32 bits, allowing some values
1184 that were far too large to be valid characters.
1185 * character.h: Include <verify.h>.
1186 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1187 arguments are no wider than unsigned, as a compile-time check
1188 to prevent future regressions in this area.
1189 * data.c (Faset):
1190 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1191 (Fsubst_char_in_region):
1192 * fns.c (concat):
1193 * xdisp.c (decode_mode_spec_coding):
1194 Adjust to CHAR_STRING's new requirement.
1195 * editfns.c (Finsert_char, Fsubst_char_in_region):
1196 * fns.c (concat): Check that character args are actually
1197 characters. Without this test, these functions did the wrong
1198 thing with wildly out-of-range values on 64-bit hosts.
1199
1200 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1201 These casts should not be needed on 32-bit hosts, either.
1202 * keyboard.c (read_char):
1203 * lread.c (Fload): Remove casts to unsigned.
1204
1205 * lisp.h (UNSIGNED_CMP): New macro.
1206 This fixes comparison bugs on 64-bit hosts.
1207 (ASCII_CHAR_P): Use it.
1208 * casefiddle.c (casify_object):
1209 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1210 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1211 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1212 * dispextern.h (FACE_FROM_ID):
1213 * keyboard.c (read_char): Use UNSIGNED_CMP.
1214
1215 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1216 not to EMACS_INT, to avoid GCC warning.
1217
1218 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1219
1220 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1221 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1222 isn't needed on 32-bit machines.
1223
1224 * buffer.c (Fgenerate_new_buffer_name):
1225 Use EMACS_INT for count, not int.
1226 (advance_to_char_boundary): Return EMACS_INT, not int.
1227
1228 * data.c (Qcompiled_function): Now static.
1229
1230 * window.c (window_body_lines): Now static.
1231
1232 * image.c (gif_load): Rename local to avoid shadowing.
1233
1234 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1235 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1236 * alloc.c (make_save_value): Integer argument is now of type
1237 ptrdiff_t, not int.
1238 (mark_object): Use ptrdiff_t, not int.
1239 * lisp.h (pD): New macro.
1240 * print.c (print_object): Use it.
1241
1242 * alloc.c: Use EMACS_INT, not int, to count objects.
1243 (total_conses, total_markers, total_symbols, total_vector_size)
1244 (total_free_conses, total_free_markers, total_free_symbols)
1245 (total_free_floats, total_floats, total_free_intervals)
1246 (total_intervals, total_strings, total_free_strings):
1247 Now EMACS_INT, not int. All uses changed.
1248 (Fgarbage_collect): Compute overall total using a double, so that
1249 integer overflow is less likely to be a problem. Check for overflow
1250 when converting back to an integer.
1251 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1252 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1253 These were 'int' variables that could overflow on 64-bit hosts;
1254 they were never used, so remove them instead of repairing them.
1255 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1256 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1257 Previously, this ceilinged at INT_MAX, but that doesn't work on
1258 64-bit machines.
1259 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1260
1261 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1262 (allocate_vectorlike): Check for ptrdiff_t overflow.
1263 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1264 when a (possibly-narrower) signed value would do just as well.
1265 We prefer using signed arithmetic, to avoid comparison confusion.
1266
1267 * alloc.c: Catch some string size overflows that we were missing.
1268 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1269 for convenience in STRING_BYTES_MAX.
1270 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1271 The definition here is exact; the one in lisp.h was approximate.
1272 (allocate_string_data): Check for string overflow. This catches
1273 some instances we weren't catching before. Also, it catches
1274 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1275 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1276 and ptrdiff_t and EMACS_INT are both 64 bits.
1277
1278 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1279 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1280 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1281
1282 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1283
1284 * alloc.c (Fmake_string): Check for out-of-range init.
1285
1286 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1287
1288 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1289
1290 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1291
1292 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1293 xg_get_default_scrollbar_width.
1294
1295 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1296 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1297 (style_changed_cb): Call update_theme_scrollbar_width and call
1298 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1299 all frames (Bug#8505).
1300 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1301 Call gtk_window_set_resizable if HAVE_GTK3.
1302 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1303 and height if HAVE_GTK3 (Bug#8505).
1304 (scroll_bar_width_for_theme): New variable.
1305 (update_theme_scrollbar_width): New function.
1306 (xg_get_default_scrollbar_width): Move code to
1307 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1308 (xg_initialize): Call update_theme_scrollbar_width.
1309
1310 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1311
1312 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1313
1314 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1315
1316 * frame.c (make_frame): Call other_buffer_safely instead of
1317 other_buffer.
1318
1319 * window.c (temp_output_buffer_show): Call display_buffer with
1320 second argument Vtemp_buffer_show_specifiers and reset latter
1321 immediately after the call.
1322 (Vtemp_buffer_show_specifiers): New variable.
1323 (auto_window_vscroll_p, next_screen_context_lines)
1324 (Vscroll_preserve_screen_position): Remove leading asterisks from
1325 doc-strings.
1326
1327 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1328
1329 Fix minor problems found by GCC 4.6.0 static checking.
1330 * buffer.c (Qclone_number): Remove for now, as it's unused.
1331 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1332 (record_buffer): Remove unused local.
1333 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1334 (set_frame_buffer_list): Remove; unused.
1335 * frame.h (other_visible_frames): Remove decl.
1336 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1337 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1338 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1339 if HAVE_GPM.
1340 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1341 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1342 Define only if HAVE_GPM.
1343 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1344 (update_hints_inhibit): Remove; never set. All uses removed.
1345 * widgetprv.h (emacsFrameClassRec): Remove decl.
1346 * window.c (delete_deletable_window): Now returns void, since it
1347 wasn't returning anything.
1348 (compare_window_configurations): Remove unused locals.
1349 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1350 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1351 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1352 the same widths as pointers. This follows up on the 2011-05-06 patch.
1353 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1354 * xterm.h: Likewise.
1355 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1356
1357 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1358
1359 * makefile.w32-in: Update dependencies.
1360 (LISP_H): Add lib/intprops.h.
1361
1362 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1363
1364 * image.c (gif_load): Add animation frame delay to the metadata.
1365 (syms_of_image): Use DEFSYM. New symbol `delay'.
1366
1367 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1368
1369 * window.c (delete_deletable_window): Re-add.
1370 (Fset_window_configuration): Rewrite to handle dead buffers and
1371 consequently deletable windows.
1372 (window_tree, Fwindow_tree): Remove. Supply functionality in
1373 window.el.
1374 (compare_window_configurations): Simplify code.
1375
1376 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1377
1378 * image.c (imagemagick_load_image): Fix type mismatch.
1379 (Fimagemagick_types): Likewise.
1380
1381 * window.h (replace_buffer_in_windows): Declare.
1382
1383 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1384
1385 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1386 Qclone_number. Remove external declaration of Qdelete_window.
1387 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1388 code.
1389 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1390 Qbuffer_list_update_hook if allowed.
1391 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1392 buffer list implementation.
1393 (other_buffer_safely): New function.
1394 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1395 calls to replace_buffer_in_windows and
1396 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1397 if allowed.
1398 (record_buffer): Inhibit quitting and rewrite using quittable
1399 functions. Run Qbuffer_list_update_hook if allowed.
1400 (Frecord_buffer, Funrecord_buffer): New functions.
1401 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1402 switch-to-buffer to window.el.
1403 (bury-buffer): Move to window.el.
1404 (Vbuffer_list_update_hook): New variable.
1405
1406 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1407 section.
1408
1409 * window.h (resize_frame_windows): Move up in code.
1410 (Fwindow_frame): Remove EXFUN.
1411 (replace_buffer_in_all_windows): Remove prototype.
1412 (replace_buffer_in_windows_safely): Add prototype.
1413
1414 * window.c: Declare Qdelete_window static again. Move down
1415 declaration of select_count.
1416 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1417 (Fother_window): Move to window.el.
1418 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1419 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1420 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1421 window.el.
1422 (replace_buffer_in_windows): Implement by calling
1423 Qreplace_buffer_in_windows.
1424 (replace_buffer_in_all_windows): Remove with some functionality
1425 moved into replace_buffer_in_windows_safely.
1426 (replace_buffer_in_windows_safely): New function.
1427 (select_window_norecord, select_frame_norecord): Move in front
1428 of run_window_configuration_change_hook. Remove now obsolete
1429 declarations.
1430 (Fset_window_buffer): Rewrite doc-string. Call
1431 Qrecord_window_buffer.
1432 (keys_of_window): Move binding for other-window to window.el.
1433
1434 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1435
1436 * dispextern.h (struct image): Replace data member, whose int_val
1437 and ptr_val fields were not used by anything, with a single
1438 lisp_val object.
1439
1440 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1441 (gif_clear_image, gif_load, imagemagick_load_image)
1442 (gs_clear_image, gs_load): Callers changed.
1443
1444 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1445
1446 * buffer.h: Include <time.h>, for time_t.
1447 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1448
1449 Fix minor problems found by static checking.
1450
1451 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1452
1453 Make identifiers static if they are not used in other modules.
1454 * data.c (Qcompiled_function, Qframe, Qvector):
1455 * image.c (QimageMagick, Qsvg):
1456 * minibuf.c (Qmetadata):
1457 * window.c (resize_window_check, resize_root_window): Now static.
1458 * window.h (resize_window_check, resize_root_window): Remove decls.
1459
1460 * window.c (window_deletion_count, delete_deletable_window):
1461 Remove; unused.
1462 (window_body_lines): Now static.
1463 (Fdelete_other_windows_internal): Mark vars as initialized.
1464 Make sure 'resize_failed' is initialized.
1465 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1466 (resize_window_apply): Remove unused local.
1467 * window.h (delete_deletable_window): Remove decl.
1468
1469 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1470 (imagemagick_load_image): Fix pointer signedness problem by changing
1471 last arg from unsigned char * to char *. All uses changed.
1472 Also, fix a local for similar reasons.
1473 Remove unused locals. Remove locals to avoid shadowing.
1474 (fn_rsvg_handle_free): Remove; unused.
1475 (svg_load, svg_load_image): Fix pointer signedness problem.
1476 (imagemagick_load_image): Don't use garbage pointer image_wand.
1477
1478 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1479
1480 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1481
1482 * image.c (gif_load): Fix omitted cast error introduced by
1483 2011-06-06 change.
1484
1485 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1486
1487 * window.h (resize_proportionally, orig_total_lines)
1488 (orig_top_line): Remove from window structure.
1489 (set_window_height, set_window_width, change_window_heights)
1490 (Fdelete_window): Remove prototypes.
1491 (resize_frame_windows): Remove duplicate declaration.
1492
1493 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1494
1495 * window.h (resize_frame_windows, resize_window_check)
1496 (delete_deletable_window, resize_root_window)
1497 (resize_frame_windows): Declare prototypes.
1498
1499 * window.c (resize_window_apply): Make definition be "static" to
1500 match the prototype.
1501
1502 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1503
1504 * window.c: Remove declarations of Qwindow_size_fixed,
1505 window_min_size_1, window_min_size_2, window_min_size,
1506 size_window, window_fixed_size_p, enlarge_window, delete_window.
1507 Remove static from declaration of Qdelete_window, it's
1508 temporarily needed by Fbury_buffer.
1509 (replace_window): Don't assign orig_top_line and
1510 orig_total_lines.
1511 (Fdelete_window, delete_window): Remove. Window deletion is
1512 handled by window.el.
1513 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1514 Fdelete_window calls with calls to Qdelete_window.
1515 (Fdelete_other_windows): Remove. Deleting other windows is
1516 handled by window.el.
1517 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1518 handled in window.el.
1519 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1520 Window minimum sizes are handled in window.el.
1521 (shrink_windows, size_window, set_window_height)
1522 (set_window_width, change_window_heights, window_height)
1523 (window_width, CURBEG, CURSIZE, enlarge_window)
1524 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1525 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1526 handled in window.el.
1527 (make_dummy_parent): Rename to make_parent_window and give it a
1528 second argument horflag.
1529 (make_window): Don't set resize_proportionally any more.
1530 (Fsplit_window): Remove. Windows are split in window.el.
1531 (save_restore_action, save_restore_orig_size)
1532 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1533 Resize mini windows in window.el.
1534 (grow_mini_window, shrink_mini_window): Implement by calling
1535 Qresize_root_window_vertically, resize_window_check and
1536 resize_window_apply.
1537 (saved_window, Fset_window_configuration, save_window_save): Do
1538 not handle orig_top_line, orig_total_lines, and
1539 resize_proportionally.
1540 (window_min_height, window_min_width): Move to window.el.
1541 (keys_of_window): Move bindings for delete-other-windows,
1542 split-window, delete-window and enlarge-window to window.el.
1543
1544 * buffer.c: Temporarily extern Qdelete_window.
1545 (Fbury_buffer): Temporarily call Qdelete_window instead of
1546 Fdelete_window (Fbury_buffer will move to window.el soon).
1547
1548 * frame.c (set_menu_bar_lines_1): Remove code handling
1549 orig_top_line and orig_total_lines.
1550
1551 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1552 set_window_height but set heights directly.
1553 (change_frame_size_1): Use resize_frame_windows.
1554
1555 * xdisp.c (init_xdisp): Don't use set_window_height but set
1556 heights directly.
1557
1558 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1559 resize_frame_windows instead of change_window_heights and run
1560 run_window_configuration_change_hook.
1561
1562 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1563 instead of change_window_heights and run
1564 run_window_configuration_change_hook.
1565
1566 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1567
1568 * window.c (replace_window): Rename second argument REPLACEMENT to
1569 NEW. New third argument SETFLAG. Rewrite.
1570 (delete_window, make_dummy_parent): Call replace_window with
1571 third argument 1.
1572 (window_list_1): Move down in code.
1573 (run_window_configuration_change_hook): Move set_buffer part
1574 before select_frame_norecord part in order to unwind correctly.
1575 Rename count1 to count.
1576 (recombine_windows, delete_deletable_window, resize_root_window)
1577 (Fdelete_other_windows_internal)
1578 (Frun_window_configuration_change_hook, make_parent_window)
1579 (resize_window_check, resize_window_apply, Fresize_window_apply)
1580 (resize_frame_windows, Fsplit_window_internal)
1581 (Fdelete_window_internal, Fresize_mini_window_internal): New
1582 functions.
1583 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1584
1585 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1586
1587 * window.h (window): Add some new members to window structure -
1588 normal_lines, normal_cols, new_total, new_normal, clone_number,
1589 splits, nest, prev_buffers, next_buffers.
1590 (WINDOW_TOTAL_SIZE): Move here from window.c.
1591 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1592
1593 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1594 Remove.
1595 (make_dummy_parent): Set new members of windows structure.
1596 (make_window): Move down in code. Handle new members of window
1597 structure.
1598 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1599 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1600 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1601 (Fset_window_prev_buffers, Fwindow_next_buffers)
1602 (Fset_window_next_buffers, Fset_window_clone_number): New
1603 functions.
1604 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1605 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1606 Doc-string fixes.
1607 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1608 Argument WINDOW can be now internal window too.
1609 (Fwindow_use_time): Move up in code.
1610 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1611 Rewrite doc-string.
1612 (Fset_window_configuration, saved_window)
1613 (Fcurrent_window_configuration, save_window_save): Handle new
1614 members of window structure.
1615 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1616 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1617 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1618 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1619 Qget_mru_window, Qresize_root_window,
1620 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1621 Qauto_buffer_name; staticpro them.
1622
1623 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1624
1625 * window.c (Fwindow_total_size, Fwindow_left_column)
1626 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1627 (Fwindow_list_1): New functions.
1628 (window_box_text_cols): Replace with window_body_cols.
1629 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1630 window_body_cols instead of window_box_text_cols.
1631 (delete_window, Fset_window_configuration): Call
1632 delete_all_subwindows with window as argument.
1633 (delete_all_subwindows): Take a window as argument and not a
1634 structure. Rewrite.
1635 (window_loop): Remove handling of GET_LRU_WINDOW and
1636 GET_LARGEST_WINDOW.
1637 (Fget_lru_window, Fget_largest_window): Move to window.el.
1638
1639 * window.h: Extern window_body_cols instead of
1640 window_box_text_cols. delete_all_subwindows now takes a
1641 Lisp_Object as argument.
1642
1643 * indent.c (compute_motion, Fcompute_motion): Use
1644 window_body_cols instead of window_box_text_cols.
1645
1646 * frame.c (delete_frame): Call delete_all_subwindows with root
1647 window as argument.
1648
1649 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1650
1651 * fns.c (Fputhash): Document return value.
1652
1653 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1654
1655 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1656
1657 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1658
1659 Cons<->int and similar integer overflow fixes (Bug#8794).
1660
1661 Check for overflow when converting integer to cons and back.
1662 * charset.c (Fdefine_charset_internal, Fdecode_char):
1663 Use cons_to_unsigned to catch overflow.
1664 (Fencode_char): Use INTEGER_TO_CONS.
1665 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1666 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1667 * data.c (long_to_cons, cons_to_long): Remove.
1668 (cons_to_unsigned, cons_to_signed): New functions.
1669 These signal an error for invalid or out-of-range values.
1670 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1671 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1672 * font.c (Ffont_variation_glyphs):
1673 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1674 * lisp.h: Include <intprops.h>.
1675 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1676 (cons_to_signed, cons_to_unsigned): New decls.
1677 (long_to_cons, cons_to_long): Remove decls.
1678 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1679 (Fprimitive_undo): Use CONS_TO_INTEGER.
1680 * xfns.c (Fx_window_property): Likewise.
1681 * xselect.c: Include <limits.h>.
1682 (x_own_selection, selection_data_to_lisp_data):
1683 Use INTEGER_TO_CONS.
1684 (x_handle_selection_request, x_handle_selection_clear)
1685 (x_get_foreign_selection, Fx_disown_selection_internal)
1686 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1687 (lisp_data_to_selection_data): Use cons_to_unsigned.
1688 (x_fill_property_data): Use cons_to_signed.
1689 Report values out of range.
1690
1691 Check for buffer and string overflow more precisely.
1692 * buffer.h (BUF_BYTES_MAX): New macro.
1693 * lisp.h (STRING_BYTES_MAX): New macro.
1694 * alloc.c (Fmake_string):
1695 * character.c (string_escape_byte8):
1696 * coding.c (coding_alloc_by_realloc):
1697 * doprnt.c (doprnt):
1698 * editfns.c (Fformat):
1699 * eval.c (verror):
1700 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1701 since they may not be the same number.
1702 * editfns.c (Finsert_char):
1703 * fileio.c (Finsert_file_contents):
1704 Likewise for BUF_BYTES_MAX.
1705
1706 * image.c: Use ptrdiff_t, not int, for sizes.
1707 (slurp_file): Switch from int to ptrdiff_t.
1708 All uses changed.
1709 (slurp_file): Check that file size fits in both size_t (for
1710 malloc) and ptrdiff_t (for sanity and safety).
1711
1712 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1713 if b->modtime has its maximal value.
1714
1715 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1716
1717 Don't assume time_t can fit into int.
1718 * buffer.h (struct buffer.modtime): Now time_t, not int.
1719 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1720 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1721
1722 Minor fixes for signed vs unsigned integers.
1723 * character.h (MAYBE_UNIFY_CHAR):
1724 * charset.c (maybe_unify_char):
1725 * keyboard.c (read_char, reorder_modifiers):
1726 XINT -> XFASTINT, since the integer must be nonnegative.
1727 * ftfont.c (ftfont_spec_pattern):
1728 * keymap.c (access_keymap, silly_event_symbol_error):
1729 XUINT -> XFASTINT, since the integer must be nonnegative.
1730 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1731 since it makes no difference and we prefer signed.
1732 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1733 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1734 nonnegative.
1735
1736 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1737
1738 * window.h (Fwindow_frame): Declare.
1739
1740 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1741
1742 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1743 (SPARE_MEMORY): Always define.
1744 (LARGE_REQUEST): Remove.
1745 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1746
1747 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1748
1749 * lisp.h: Move EXFUNS for Fframe_root_window,
1750 Fframe_first_window and Fset_frame_selected_window to window.h.
1751
1752 * window.h: Move EXFUNS for Fframe_root_window,
1753 Fframe_first_window and Fset_frame_selected_window here from
1754 lisp.h.
1755
1756 * frame.c (Fwindow_frame, Fframe_first_window)
1757 (Fframe_root_window, Fframe_selected_window)
1758 (Fset_frame_selected_window): Move to window.c.
1759 (Factive_minibuffer_window): Move to minibuf.c.
1760 (Fother_visible_frames_p): New function.
1761
1762 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1763
1764 * window.c (decode_window, decode_any_window): Move up in code.
1765 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1766 (inhibit_frame_unsplittable): Remove unused variable.
1767 (Fwindow_buffer): Move up and rewrite doc-string.
1768 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1769 (Fwindow_prev): New functions.
1770 (Fwindow_frame): Move here from frame.c. Accept any window as
1771 argument.
1772 (Fframe_root_window, Fframe_first_window)
1773 (Fframe_selected_window): Move here from frame.c. Accept frame
1774 or arbitrary window as argument. Update doc-strings.
1775 (Fminibuffer_window): Move up in code.
1776 (Fwindow_minibuffer_p): Move up in code and simplify.
1777 (Fset_frame_selected_window): Move here from frame.c.
1778 Marginal rewrite.
1779 (Fselected_window, select_window, Fselect_window): Move up in
1780 code. Minor doc-string fixes.
1781
1782 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1783
1784 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1785 Do not assume that spare memory exists; that assumption is valid
1786 only if SYSTEM_MALLOC.
1787 (LARGE_REQUEST): New macro, so that the issue of large requests
1788 is separated from the issue of spare memory.
1789
1790 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1791
1792 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1793 format. (Bug#8806)
1794
1795 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1796
1797 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1798 before statements.
1799
1800 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1801
1802 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1803
1804 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1805
1806 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1807 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1808
1809 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1810
1811 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1812
1813 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1814
1815 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1816 (x_clipboard_manager_save): Add return value.
1817 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1818 New error handlers.
1819 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1820 Obey Vx_select_enable_clipboard_manager. Catch errors in
1821 x_clipboard_manager_save (Bug#8779).
1822 (Vx_select_enable_clipboard_manager): New variable.
1823 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1824
1825 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1826
1827 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1828
1829 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1830
1831 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1832 in the current matrix if keep_current_p is non-zero.
1833
1834 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1835
1836 * bidi.c (bidi_level_of_next_char): Fix last change.
1837
1838 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1839
1840 Support bidi reordering of text covered by display properties.
1841
1842 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1843 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1844 (bidi_cache_search, bidi_cache_iterator_state)
1845 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1846 (bidi_level_of_next_char, bidi_move_to_visually_next):
1847 Support character positions inside a run of characters covered by a
1848 display string.
1849 (bidi_paragraph_init, bidi_resolve_explicit_1)
1850 (bidi_level_of_next_char): Call bidi_fetch_char and
1851 bidi_fetch_char_advance instead of FETCH_CHAR and
1852 FETCH_CHAR_ADVANCE.
1853 (bidi_init_it): Initialize new members.
1854 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1855 definitions.
1856 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1857 instead of using explicit *_CHAR codes.
1858 (bidi_resolve_explicit, bidi_resolve_weak):
1859 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1860 bidirectional text is supported only in multibyte buffers.
1861 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1862 it to initialize the frame_window_p member of struct bidi_it.
1863 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1864 (bidi_resolve_explicit, bidi_resolve_weak)
1865 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1866 bidi_it->nchars is non-positive.
1867 (bidi_level_of_next_char): Don't try to lookup the cache for the
1868 next/previous character if nothing is cached there yet, or if we
1869 were just reseat()'ed to a new position.
1870
1871 * xdisp.c (set_cursor_from_row): Set start and stop points
1872 according to the row's direction when priming the loop that looks
1873 for the glyph on which to display cursor.
1874 (single_display_spec_intangible_p): Function deleted.
1875 (display_prop_intangible_p): Reimplement to call
1876 handle_display_spec instead of single_display_spec_intangible_p.
1877 Accept 3 additional arguments needed by handle_display_spec.
1878 This fixes incorrect cursor motion across display property with complex
1879 values: lists, `(when COND...)' forms, etc.
1880 (single_display_spec_string_p): Support property values that are
1881 lists with the argument STRING its top-level element.
1882 (display_prop_string_p): Fix the condition for processing a
1883 property that is a list to be consistent with handle_display_spec.
1884 (handle_display_spec): New function, refactored from the
1885 last portion of handle_display_prop.
1886 (compute_display_string_pos): Accept additional argument
1887 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1888 value of a `display' property is a "replacing spec".
1889 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1890 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1891 the display property, but just return a value indicating whether
1892 the display property will replace the characters it covers.
1893 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1894 frame_window_p members of struct bidi_it.
1895 (compute_display_string_pos, compute_display_string_end):
1896 New functions.
1897 (push_it): Accept second argument POSITION, where pop_it should
1898 jump to continue iteration.
1899 (reseat_1): Initialize bidi_it.disp_pos.
1900
1901 * keyboard.c (adjust_point_for_property): Adjust the call to
1902 display_prop_intangible_p to its new signature.
1903
1904 * dispextern.h (struct bidi_it): New member frame_window_p.
1905 (bidi_init_it): Update prototypes.
1906 (display_prop_intangible_p): Update prototype.
1907 (compute_display_string_pos, compute_display_string_end):
1908 Declare prototypes.
1909 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1910 EMACS_INT.
1911
1912 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1913
1914 Malloc failure behavior now depends on size of allocation.
1915 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1916 * lisp.h: Change signatures accordingly.
1917 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1918 All callers changed. (Bug#8762)
1919
1920 * gnutls.c: Use Emacs's memory allocators.
1921 Without this change, the gnutls library would invoke malloc etc.
1922 directly, which causes problems on non-SYNC_INPUT hosts, and which
1923 runs afoul of improving memory_full behavior. (Bug#8761)
1924 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1925 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1926 xfree instead of the default malloc, realloc, free.
1927 (Fgnutls_boot): No need to check for memory allocation failure,
1928 since xmalloc does that for us.
1929
1930 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1931 * category.c (hash_get_category_set):
1932 * ccl.c (ccl_driver):
1933 * charset.c (Fdefine_charset_internal):
1934 * charset.h (struct charset.hash_index):
1935 * composite.c (get_composition_id, gstring_lookup_cache)
1936 (composition_gstring_put_cache):
1937 * composite.h (struct composition.hash_index):
1938 * dispextern.h (struct image.hash):
1939 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1940 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1941 (hashfn_equal, hashfn_user_defined, make_hash_table)
1942 (maybe_resize_hash_table, hash_lookup, hash_put)
1943 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1944 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1945 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1946 * image.c (make_image, search_image_cache, lookup_image)
1947 (xpm_put_color_table_h):
1948 * lisp.h (struct Lisp_Hash_Table):
1949 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1950 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1951 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1952 * alloc.c (allocate_vectorlike):
1953 Check for overflow in vector size calculations.
1954 * ccl.c (ccl_driver):
1955 Check for overflow when converting EMACS_INT to int.
1956 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1957 need to be updated by these changes.
1958 * fns.c (make_hash_table, maybe_resize_hash_table):
1959 Check for integer overflow with large hash tables.
1960 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1961 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1962 (SXHASH_REDUCE): New macro.
1963 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1964 Use it instead of discarding useful hash info with large hash values.
1965 (sxhash_float): New function.
1966 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1967 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1968 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1969 Rewrite to use FIXNUM_BITS, as this simplifies things.
1970 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1971 Adjust signatures to match updated version of code.
1972 (consing_since_gc): Now EMACS_INT, since a single hash table can
1973 use more than INT_MAX bytes.
1974
1975 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1976
1977 Make it possible to build with GCC-4.6+ -O2 -flto.
1978
1979 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1980
1981 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1982
1983 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1984 Call minibuffer-inactive-mode.
1985
1986 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1987
1988 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1989 Update dependencies.
1990
1991 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1992
1993 * data.c (init_data): Remove code for UTS, this system is not
1994 supported anymore.
1995
1996 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1997
1998 Don't force ./temacs to start in terminal mode.
1999
2000 * frame.c (make_initial_frame): Initialize faces in all cases, not
2001 only when CANNOT_DUMP is defined.
2002 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2003
2004 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2005
2006 * dispnew.c (add_window_display_history): Use const for the string
2007 pointer. Remove declaration, not needed.
2008
2009 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2010
2011 Use 'inline', not 'INLINE'.
2012 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2013 * alloc.c, fontset.c (INLINE): Remove.
2014 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2015 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2016 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2017 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2018 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2019
2020 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2021
2022 Make it possible to run ./temacs.
2023
2024 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2025 syms_of_callproc does the same thing. Remove test for
2026 "initialized", do it in the caller.
2027 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2028
2029 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2030
2031 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2032 (read_minibuf): Use get_minibuffer.
2033 (syms_of_minibuf): Use DEFSYM.
2034 (Qmetadata): New var.
2035 * data.c (Qbuffer): Don't make it static.
2036 (syms_of_data): Use DEFSYM.
2037
2038 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2039
2040 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2041 (CCL_CODE_MIN): New macro.
2042
2043 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2044
2045 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2046
2047 * eval.c (Qdebug): Now static.
2048 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2049 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2050 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2051
2052 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2053
2054 * image.c: Various fixes to ImageMagick code comments.
2055 (Fimagemagick_types): Doc fix.
2056
2057 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2058
2059 Minor fixes prompted by GCC 4.6.0 warnings.
2060
2061 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2062
2063 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2064 (x_clipboard_manager_save_all): Move extern decl to ...
2065 * xterm.h: ... here, so that it can be checked for consistency.
2066
2067 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2068
2069 * xselect.c (x_clipboard_manager_save_frame)
2070 (x_clipboard_manager_save_all): New functions.
2071 (Fx_clipboard_manager_save): Lisp function deleted.
2072
2073 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2074 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2075
2076 * xterm.h: Update prototype.
2077
2078 2011-05-28 William Xu <william.xwl@gmail.com>
2079
2080 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2081 exiting (Bug#8239).
2082
2083 2011-05-28 Jim Meyering <meyering@redhat.com>
2084
2085 Avoid a sign-extension bug in crypto_hash_function.
2086 * fns.c (to_uchar): Define.
2087 (crypto_hash_function): Use it to convert some newly-signed
2088 variables to unsigned, to avoid sign-extension bugs. For example,
2089 without this change, (md5 "truc") would evaluate to
2090 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2091 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2092 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2093
2094 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2095
2096 Integer overflow fixes.
2097
2098 * dbusbind.c: Serial number integer overflow fixes.
2099 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2100 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2101 to hold a serial number that is too large for a fixnum.
2102 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2103 Check for serial numbers out of range. Decode any serial number
2104 that was so large that it became a float. (Bug#8722)
2105
2106 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2107 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2108 Use XFASTINT rather than XUINT when numbers are nonnegative.
2109 (xd_append_arg, Fdbus_method_return_internal):
2110 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2111 arguments, check that Lisp number is nonnegative, rather than
2112 silently wrapping negative numbers around. (Bug#8722)
2113 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2114 (Bug#8722)
2115
2116 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2117
2118 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2119
2120 ccl: add integer overflow checks
2121 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2122 (IN_INT_RANGE): New macros.
2123 (ccl_driver): Use them to check for integer overflow when
2124 decoding a CCL program. Many of the new checks are whether XINT (x)
2125 fits in int; it doesn't always, on 64-bit hosts. The new version
2126 doesn't catch all possible integer overflows, but it's an
2127 improvement. (Bug#8719)
2128
2129 * alloc.c (make_event_array): Use XINT, not XUINT.
2130 There's no need for unsigned here.
2131
2132 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2133 This follows up to the 2011-05-06 change that substituted uintptr_t
2134 for EMACS_INT. This case wasn't caught back then.
2135
2136 Rework Fformat to avoid integer overflow issues.
2137 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2138 now (part of C89). Include <verify.h>.
2139 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2140 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2141 (Fformat): Avoid the prepass trying to compute sizes; it was only
2142 approximate and thus did not catch overflow reliably. Instead, walk
2143 through the format just once, formatting and computing sizes as we go,
2144 checking for integer overflow at every step, and allocating a larger
2145 buffer as needed. Keep track separately whether the format is
2146 multibyte. Keep only the most-recently calculated precision, rather
2147 than them all. Record whether each argument has been converted to
2148 string. Use EMACS_INT, not int, for byte and char and arg counts.
2149 Support field widths and precisions larger than INT_MAX. Avoid
2150 sprintf's undefined behavior with conversion specifications such as %#d
2151 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2152 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2153 formatting out-of-range floating point numbers with int
2154 formats. (Bug#8668)
2155
2156 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2157
2158 * data.c: Avoid integer truncation in expressions involving floats.
2159 * data.c: Include <intprops.h>.
2160 (arith_driver): When there's an integer overflow in an expression
2161 involving floating point, convert the integers to floating point
2162 so that the resulting value does not suffer from catastrophic
2163 integer truncation. For example, on a 64-bit host (* 4
2164 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2165 Do not rely on undefined behavior after integer overflow.
2166
2167 merge count_size_as_multibyte, parse_str_to_multibyte
2168 * character.c, character.h (count_size_as_multibyte):
2169 Rename from parse_str_to_multibyte; all uses changed.
2170 Check for integer overflow.
2171 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2172 since it's now a duplicate of the other. This is more of
2173 a character than a buffer op, so better that it's in character.c.
2174 * fns.c, print.c: Adjust to above changes.
2175
2176 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2177
2178 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2179
2180 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2181
2182 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2183 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2184 (x_clipboard_manager_save): Now static.
2185 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2186
2187 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2188 (crypto_hash_function): Now static.
2189 Fix pointer signedness problems. Avoid unnecessary initializations.
2190
2191 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2192
2193 * termhooks.h (Vselection_alist): Make it terminal-local.
2194
2195 * terminal.c (create_terminal): Initialize it.
2196
2197 * xselect.c: Support for clipboard managers.
2198 (Vselection_alist): Move to termhooks.h as terminal-local var.
2199 (LOCAL_SELECTION): New macro.
2200 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2201 (symbol_to_x_atom): Remove gratuitous arg.
2202 (x_handle_selection_request, lisp_data_to_selection_data)
2203 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2204 (x_own_selection, x_get_local_selection, x_convert_selection):
2205 New arg, specifying work frame. Use terminal-local Vselection_alist.
2206 (some_frame_on_display): Delete unused function.
2207 (Fx_own_selection_internal, Fx_get_selection_internal)
2208 (Fx_disown_selection_internal, Fx_selection_owner_p)
2209 (Fx_selection_exists_p): New optional frame arg.
2210 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2211 (x_handle_selection_clear): Don't treat other terminals with the
2212 same keyboard specially. Use the terminal-local Vselection_alist.
2213 (x_clear_frame_selections): Use Frun_hook_with_args.
2214
2215 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2216
2217 * xterm.h: Add support for those atoms.
2218
2219 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2220
2221 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2222 (converted_selections, conversion_fail_tag): New global variables.
2223 (x_selection_request_lisp_error): Free the above.
2224 (x_get_local_selection): Remove unnecessary code.
2225 (x_reply_selection_request): Args changed; handle arbitrary array
2226 of converted selections stored in converted_selections.
2227 Separate the XChangeProperty and SelectionNotify steps.
2228 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2229 (x_convert_selection): New function.
2230 (x_handle_selection_event): Simplify.
2231 (x_get_foreign_selection): Don't ignore incoming requests while
2232 waiting for an answer; this will fail when we implement
2233 SAVE_TARGETS, and seems unnecessary anyway.
2234 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2235 (Vx_sent_selection_functions): Doc fix.
2236
2237 2011-05-26 Leo Liu <sdl.web@gmail.com>
2238
2239 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2240
2241 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2242
2243 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2244
2245 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2246 for fringe update if it has periodic bitmap.
2247 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2248 and fringe_bitmap_periodic_p.
2249
2250 * fringe.c (get_fringe_bitmap_data): New function.
2251 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2252 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2253 row. Mark glyph row for fringe update if periodicity changed.
2254
2255 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2256 for fringe update unless it has periodic bitmap.
2257
2258 2011-05-25 Kenichi Handa <handa@m17n.org>
2259
2260 * xdisp.c (get_next_display_element): Set correct it->face_id for
2261 a static composition.
2262
2263 2011-05-24 Leo Liu <sdl.web@gmail.com>
2264
2265 * deps.mk (fns.o):
2266 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2267
2268 * fns.c (crypto_hash_function, Fsha1): New function.
2269 (Fmd5): Use crypto_hash_function.
2270 (syms_of_fns): Add Ssha1.
2271
2272 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2273
2274 * gnutls.c: Remove unused macros.
2275 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2276 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2277 Remove macros that are defined and never used.
2278 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2279
2280 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2281
2282 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2283 (Fx_get_selection_internal): Minor cleanup.
2284 (Fx_own_selection_internal): Rename arguments for consistency with
2285 select.el.
2286
2287 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2288
2289 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2290
2291 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2292
2293 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2294
2295 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2296
2297 * dispnew.c (scrolling_window): Don't exclude the case that the
2298 last enabled row in the desired matrix touches the bottom boundary.
2299
2300 2011-05-21 Glenn Morris <rgm@gnu.org>
2301
2302 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2303 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2304 and add some more files.
2305
2306 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2307
2308 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2309 report_file_error introduced by the change from 2011-05-07.
2310
2311 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2312
2313 * systime.h (Time): Define only if emacs is defined.
2314 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2315 where the include path doesn't have X11/X.h by default. See
2316 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2317
2318 2011-05-20 Kenichi Handa <handa@m17n.org>
2319
2320 * composite.c (find_automatic_composition): Fix previous change.
2321
2322 2011-05-20 Glenn Morris <rgm@gnu.org>
2323
2324 * lisp.mk: New file, split from Makefile.in.
2325 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2326 (shortlisp): Remove.
2327 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2328
2329 2011-05-19 Glenn Morris <rgm@gnu.org>
2330
2331 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2332 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2333 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2334 (lisp): Set the order to that of loadup.el.
2335 (shortlisp): Make it a copy of $lisp.
2336 (SOME_MACHINE_LISP): Remove.
2337 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2338 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2339
2340 2011-05-18 Kenichi Handa <handa@m17n.org>
2341
2342 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2343 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2344 (find_automatic_composition): Mostly rewrite for efficiency.
2345
2346 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2347
2348 * makefile.w32-in: Update dependencies.
2349
2350 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2351
2352 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2353 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2354
2355 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2356
2357 Fix some integer overflow issues, such as string length overflow.
2358
2359 * insdel.c (count_size_as_multibyte): Check for string overflow.
2360
2361 * character.c (lisp_string_width): Check for string overflow.
2362 Use EMACS_INT, not int, for string indexes and lengths; in
2363 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2364 the resulting string length overflows an EMACS_INT; instead,
2365 report a string overflow if no precision given. When checking for
2366 precision exhaustion, use a check that cannot possibly have
2367 integer overflow. (Bug#8675)
2368 * character.h (lisp_string_width): Adjust to new signature.
2369
2370 * alloc.c (string_overflow): New function.
2371 (Fmake_string): Use it. This doesn't change behavior, but saves
2372 a few bytes and will simplify future changes.
2373 * character.c (string_escape_byte8): Likewise.
2374 * lisp.h (string_overflow): New decl.
2375
2376 Fixups, following up to the user-interface timestamp change.
2377 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2378 for UI timestamps, instead of unsigned long.
2379 * msdos.c (mouse_get_pos): Likewise.
2380 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2381 * w32gui.h (Time): Define by including "systime.h" rather than by
2382 declaring it ourselves. (Bug#8664)
2383
2384 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2385 * image.c (clear_image_cache): Likewise.
2386
2387 * term.c (term_mouse_position): Don't assume time_t wraparound.
2388
2389 Be more systematic about user-interface timestamps.
2390 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2391 and sometimes 'EMACS_UINT', to represent these timestamps.
2392 This change causes it to use 'Time' uniformly, as that's what X uses.
2393 This makes the code easier to follow, and makes it easier to catch
2394 integer overflow bugs such as Bug#8664.
2395 * frame.c (Fmouse_position, Fmouse_pixel_position):
2396 Use Time, not unsigned long, for user-interface timestamps.
2397 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2398 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2399 * keyboard.h (last_event_timestamp): Likewise.
2400 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2401 * menu.h (xmenu_show): Likewise.
2402 * term.c (term_mouse_position): Likewise.
2403 * termhooks.h (struct input_event.timestamp): Likewise.
2404 (struct terminal.mouse_position_hook): Likewise.
2405 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2406 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2407 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2408 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2409 what it was before.
2410 * menu.h, termhooks.h: Include "systime.h", for Time.
2411
2412 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2413 Don't assume that the difference between two unsigned long values
2414 can fit into an integer. At this point, we know button_down_time
2415 <= event->timestamp, so the difference must be nonnegative, so
2416 there's no need to cast the result if double-click-time is
2417 nonnegative, as it should be; check that it's nonnegative, just in
2418 case. This bug is triggered when events are more than 2**31 ms
2419 apart (about 25 days). (Bug#8664)
2420
2421 * xselect.c (last_event_timestamp): Remove duplicate decl.
2422 (x_own_selection): Remove needless cast to unsigned long.
2423
2424 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2425 that always fit in int. Use a sentinel instead of a counter, to
2426 avoid a temp and to allay GCC's concerns about possible int overflow.
2427 * frame.h (struct frame): Use int for menu_bar_items_used
2428 instead of EMACS_INT, since it always fits in int.
2429
2430 * menu.c (grow_menu_items): Check for int overflow.
2431
2432 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2433
2434 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2435 Before, the code was not consistent. These values cannot exceed
2436 2**31 - 1 so there's no need to make them unsigned.
2437 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2438 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2439 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2440 as modifiers.
2441 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2442
2443 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2444 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2445 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2446 presumably because the widths might not match.
2447
2448 * window.c (size_window): Avoid needless test at loop start.
2449
2450 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2451
2452 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2453
2454 2011-05-12 Drew Adams <drew.adams@oracle.com>
2455
2456 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2457
2458 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2459
2460 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2461 `width' to `bar_area_x' and `bar_area_width', respectively.
2462 (x_scroll_run): Take account of fringe background extension.
2463
2464 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2465 Rename local vars `left' and `width' to `bar_area_x' and
2466 `bar_area_width', respectively.
2467 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2468 background extension.
2469
2470 2011-05-10 Jim Meyering <meyering@redhat.com>
2471
2472 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2473
2474 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2475
2476 * image.c (Finit_image_library): Return t for built-in image types,
2477 like pbm and xbm. (Bug#8640)
2478
2479 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2480
2481 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2482
2483 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2484
2485 * w32console.c (Fset_screen_color): Doc fix.
2486 (Fget_screen_color): New function.
2487 (syms_of_ntterm): Defsubr it.
2488
2489 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2490 unlink the temporary file if Fcall_process didn't create it in the
2491 first place.
2492 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2493 child process will be redirected to a file specified with `:file'.
2494 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2495 cue to call_process_cleanup not to close that handle.
2496
2497 2011-05-07 Ben Key <bkey76@gmail.com>
2498
2499 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2500 one of two shell specific rules, either bootstrap-temacs-CMD or
2501 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2502 to the previous implementation of the bootstrap-temacs rule.
2503 The bootstrap-temacs-CMD rule is similar to the previous
2504 implementation of the bootstrap-temacs rule except that it
2505 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2506 variable.
2507
2508 These changes, along with some changes to nt/configure.bat,
2509 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2510 earlier fix to add support for --cflags and --ldflags options
2511 that include quotes so that it works whether make uses cmd or
2512 sh as the shell.
2513
2514 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2515
2516 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2517 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2518 is a constant.
2519 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2520 a string. Handle both cases.
2521 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2522 (Fdbus_register_method): Use Qinvalid_function.
2523
2524 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2525
2526 * makefile.w32-in: Update dependencies.
2527 (LISP_H): Add inttypes.h and stdin.h.
2528 (PROCESS_H): Add unistd.h.
2529
2530 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2531
2532 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2533 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2534
2535 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2536
2537 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2538
2539 * term.c (vfatal): Remove stray call to va_end.
2540 It's not needed and the C Standard doesn't allow it here anyway.
2541
2542 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2543 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2544
2545 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2546 bytes.
2547
2548 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2549
2550 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2551
2552 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2553
2554 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2555
2556 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2557
2558 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2559 * charset.c (Fdefine_charset_internal): Don't initialize
2560 charset.code_space[15]. The value was garbage, on hosts with
2561 32-bit int (Bug#8600).
2562
2563 * lread.c (read_integer): Be more consistent with string-to-number.
2564 Use string_to_number to do the actual conversion; this avoids
2565 rounding errors and fixes some other screwups. Without this fix,
2566 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2567 (digit_to_number): Move earlier, for benefit of read_integer.
2568 Return -1 if the digit is out of range for the base, -2 if it is
2569 not a digit in any supported base. (Bug#8602)
2570
2571 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2572
2573 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2574 to match comment at start of function. This also removes a
2575 GCC warning about overflow in a 32+64-bit port.
2576
2577 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2578
2579 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2580 Reported by Stefan Monnier in
2581 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2582 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2583 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2584
2585 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2586 (EMACS_UINTPTR): Likewise, with uintptr_t.
2587
2588 * lisp.h: Prefer 64-bit EMACS_INT if available.
2589 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2590 on 32-bit hosts that have 64-bit int, so that they can access
2591 large files.
2592 However, temporarily disable this change unless the temporary
2593 symbol WIDE_EMACS_INT is defined.
2594
2595 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2596
2597 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2598 This removes an assumption that EMACS_INT and long are the same
2599 width as pointers. The assumption is true for Emacs porting targets
2600 now, but we want to make other targets possible.
2601 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2602 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2603 In the rest of the code, change types of integers that hold casted
2604 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2605 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2606 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2607 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2608 No need to cast type when ORing.
2609 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2610 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2611 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2612 assume EMACS_INT is the same width as char *.
2613 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2614 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2615 Remove no-longer-needed casts.
2616 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2617 (xg_tool_bar_help_callback, xg_make_tool_item):
2618 Use EMACS_INTPTR to hold an integer
2619 that will be cast to void *; this can avoid a GCC warning
2620 if EMACS_INT is not the same width as void *.
2621 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2622 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2623 (current_message_1, set_message_1):
2624 Use a local to convert to proper width without a cast.
2625 * xmenu.c (dialog_selection_callback): Likewise.
2626
2627 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2628 Also, don't assume VALBITS / RAND_BITS is less than 5,
2629 and don't rely on undefined behavior when shifting a 1 left into
2630 the sign bit.
2631 * lisp.h (get_random): Change signature to match.
2632
2633 * lread.c (hash_string): Use size_t, not int, for hash computation.
2634 Normally we prefer signed values; but hashing is special, because
2635 it's better to use unsigned division on hash table sizes so that
2636 the remainder is nonnegative. Also, size_t is the natural width
2637 for hashing into memory. The previous code used 'int', which doesn't
2638 retain enough info to hash well into very large tables.
2639 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2640
2641 * dbusbind.c: Don't possibly lose pointer info when converting.
2642 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2643 Use XPNTR rather than XHASH, so that the high-order bits of
2644 the pointer aren't lost when converting through void *.
2645
2646 * eval.c (Fautoload): Don't double-shift a pointer.
2647
2648 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2649
2650 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2651
2652 * gnutls.c (DEF_GNUTLS_FN):
2653 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2654
2655 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2656
2657 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2658 marker. (Bug#8610)
2659
2660 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2661
2662 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2663 New version that can reserve upto 2GB of heap space.
2664
2665 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2666
2667 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2668
2669 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2670
2671 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2672 `gnutls_certificate_set_x509_key_file'.
2673
2674 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2675
2676 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2677 Update dependencies.
2678
2679 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2680
2681 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2682 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2683 Remove unused parameter `fildes'.
2684 * process.c (read_process_output, send_process): Don't pass it.
2685
2686 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2687
2688 Fix previous change: the library cache is defined in w32.c.
2689 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2690 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2691
2692 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2693
2694 Implement dynamic loading of GnuTLS on Windows.
2695
2696 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2697 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2698 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2699 Declare.
2700
2701 * gnutls.c (Qgnutls_dll): Define.
2702 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2703 (gnutls_*): Declare function pointers.
2704 (init_gnutls_functions): New function to initialize function pointers.
2705 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2706 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2707 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2708 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2709 (emacs_gnutls_write, emacs_gnutls_read)
2710 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2711 (Fgnutls_available_p): New function.
2712 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2713 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2714 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2715
2716 * image.c: Include w32.h.
2717 (Vimage_type_cache): Delete.
2718 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2719 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2720 (w32_delayed_load): Move to w32.c.
2721
2722 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2723
2724 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2725 (w32_delayed_load): Move from image.c. When loading a library, record
2726 its filename in the :loaded-from property of the library id.
2727 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2728 Initialize and staticpro them.
2729 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2730
2731 * process.c: Include lisp.h before w32.h, not after.
2732 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2733 instead of gnutls_record_check_pending.
2734
2735 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2736
2737 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2738
2739 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2740 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2741 as passed in.
2742
2743 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2744
2745 * xterm.c (x_set_frame_alpha): Do not set property on anything
2746 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2747
2748 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2749
2750 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2751
2752 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2753
2754 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2755 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2756 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2757 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2758 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2759 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2760 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2761 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2762 (Qgnutls_bootprop_callbacks_verify): Make static.
2763
2764 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2765
2766 * callproc.c: Indentation fixup.
2767
2768 * sysdep.c (wait_for_termination_1): Make static.
2769 (wait_for_termination, interruptible_wait_for_termination):
2770 Move after wait_for_termination_1.
2771
2772 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2773
2774 * sysdep.c (interruptible_wait_for_termination): New function
2775 which is like wait_for_termination, but allows keyboard
2776 interruptions.
2777
2778 * callproc.c (Fcall_process): Add (:file "file") as an option for
2779 the STDOUT buffer.
2780 (Fcall_process_region): Ditto.
2781
2782 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2783
2784 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2785 rather than `XVECTOR (FOO)->size'.
2786
2787 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2788 inttypes.h, as a gnulib replacement is used if it not available in
2789 system headers.
2790
2791 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2792
2793 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2794 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2795 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2796
2797 * coding.c (coding_alloc_by_realloc): Error out if destination
2798 will grow beyond MOST_POSITIVE_FIXNUM.
2799 (decode_coding_emacs_mule): Abort if there isn't enough place in
2800 charbuf for the composition carryover bytes. Reserve an extra
2801 space for up to 2 characters produced in a loop.
2802 (decode_coding_iso_2022): Abort if there isn't enough place in
2803 charbuf for the composition carryover bytes.
2804
2805 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2806
2807 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2808 aborting when %lld or %lll format is passed.
2809 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2810 %llo or %llx format is passed. (Bug#8545)
2811
2812 * window.c (window_scroll_line_based): Use a marker instead of
2813 simple variables to record original value of point. (Bug#7952)
2814
2815 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2816 produced by %s or %c overflows available buffer space. (Bug#8545)
2817
2818 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2819
2820 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2821 (SIZE_MAX): Move defn after all includes, as they might #define it.
2822
2823 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2824
2825 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2826
2827 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2828
2829 * keyboard.c (Qdelayed_warnings_hook): Define.
2830 (command_loop_1): Run `delayed-warnings-hook'
2831 if Vdelayed_warnings_list is non-nil.
2832 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2833 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2834
2835 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2836
2837 * doprnt.c (doprnt): Don't return value smaller than the buffer
2838 size if the message was truncated. (Bug#8545).
2839
2840 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2841
2842 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2843 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2844
2845 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2846
2847 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2848
2849 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2850
2851 * makefile.w32-in: Update dependencies.
2852
2853 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2854
2855 Improve `doprnt' and its usage. (Bug#8545)
2856 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2857 `format_end'. Remove support for %l as a conversion specifier.
2858 Don't use xrealloc. Improve diagnostics when the %l size modifier
2859 is used. Update the commentary.
2860
2861 * eval.c (verror): Simplify calculation of size_t.
2862
2863 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2864 messages.
2865
2866 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2867
2868 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2869 change.
2870
2871 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2872
2873 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2874 This makes this file independent of the recent pseudovector change.
2875
2876 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2877
2878 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2879
2880 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2881 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2882 Remove unused local.
2883 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2884
2885 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2886 GCC 4.6.0 optimizes based on type-based alias analysis.
2887 For example, if b is of type struct buffer * and v of type struct
2888 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2889 != &v->size, and therefore "v->size = 1; b->size = 2; return
2890 v->size;" must therefore return 1. This assumption is incorrect
2891 for Emacs, since it type-puns struct Lisp_Vector * with many other
2892 types. To fix this problem, this patch adds a new type struct
2893 vectorlike_header that documents the constraints on layout of vectors
2894 and pseudovectors, and helps optimizing compilers not get fooled
2895 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2896 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2897 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2898 the size member.
2899 (XSETPVECTYPE): Rewrite in terms of new macro.
2900 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2901 This is a bit clearer, and further avoids the possibility of
2902 undesirable aliasing.
2903 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2904 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2905 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2906 since Lisp_Subr is a special case (no "next" field).
2907 (ASIZE): Now uses header.size rather than size.
2908 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2909 to avoid the hassle of writing XVECTOR (foo)->header.size.
2910 (struct vectorlike_header): New type.
2911 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2912 object, to help avoid aliasing.
2913 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2914 (SUBRP): Likewise, since Lisp_Subr is a special case.
2915 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2916 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2917 (struct Lisp_Hash_Table): Combine first two members into a single
2918 struct vectorlike_header member. All uses of "size" and "next" members
2919 changed to be "header.size" and "header.next".
2920 * buffer.h (struct buffer): Likewise.
2921 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2922 * frame.h (struct frame): Likewise.
2923 * process.h (struct Lisp_Process): Likewise.
2924 * termhooks.h (struct terminal): Likewise.
2925 * window.c (struct save_window_data, struct saved_window): Likewise.
2926 * window.h (struct window): Likewise.
2927 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2928 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2929 * buffer.c (init_buffer_once): Likewise.
2930 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2931 special case.
2932 * process.c (Fformat_network_address): Use local var for size,
2933 for brevity.
2934
2935 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2936
2937 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2938 * data.c (atof): Remove decl; no longer used or needed.
2939 (digit_to_number): Move to lread.c.
2940 (Fstring_to_number): Use new string_to_number function, to be
2941 consistent with how the Lisp reader treats infinities and NaNs.
2942 Do not assume that floating-point numbers represent EMACS_INT
2943 without losing information; this is not true on most 64-bit hosts.
2944 Avoid double-rounding errors, by insisting on integers when
2945 parsing non-base-10 numbers, as the documentation specifies.
2946 * lisp.h (string_to_number): New decl, replacing ...
2947 (isfloat_string): Remove.
2948 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2949 (read1): Do not accept +. and -. as integers; this
2950 appears to have been a coding error. Similarly, do not accept
2951 strings like +-1e0 as floating point numbers. Do not report
2952 overflow for integer overflows unless the base is not 10 which
2953 means we have no simple and reliable way to continue.
2954 Break out the floating-point parsing into a new
2955 function string_to_number, so that Fstring_to_number parses
2956 floating point numbers consistently with the Lisp reader.
2957 (digit_to_number): Move here from data.c. Make it static inline.
2958 (E_CHAR, EXP_INT): Remove, replacing with ...
2959 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2960 (string_to_number): New function, replacing isfloat_string.
2961 This function checks for valid syntax and produces the resulting
2962 Lisp float number too. Rework it so that string-to-number
2963 no longer mishandles examples like "1.0e+". Use strtoumax,
2964 so that overflow for non-base-10 numbers is reported only when
2965 there's no portable and simple way to convert to floating point.
2966
2967 * textprop.c (set_text_properties_1): Rewrite for clarity,
2968 and to avoid GCC warning about integer overflow.
2969
2970 * intervals.h (struct interval): Use EMACS_INT for members
2971 where EMACS_UINT might cause problems. See
2972 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2973 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2974 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2975 All uses changed.
2976 (offset_intervals): Tell GCC not to worry about length overflow
2977 when negating a negative length.
2978
2979 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2980 (overrun_check_free): Likewise.
2981
2982 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2983 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2984 word size.
2985
2986 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2987 (gnutls_make_error): Rename local to avoid shadowing.
2988 (gnutls_emacs_global_deinit): ifdef out; not used.
2989 (Fgnutls_boot): Use const for pointer to readonly storage.
2990 Comment out unused local. Fix pointer signedness problems.
2991
2992 * lread.c (openp): Don't stuff size_t into an 'int'.
2993 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2994 about possible signed overflow.
2995
2996 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2997 (GDK_KEY_g): Don't define if already defined.
2998 (xg_prepare_tooltip): Avoid pointer signedness problem.
2999 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3000
3001 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3002 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3003
3004 * xfns.c (Fx_window_property): Simplify a bit,
3005 to make a bit faster and to avoid GCC 4.6.0 warning.
3006 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3007
3008 * fns.c (internal_equal): Don't assume size_t fits in int.
3009
3010 * alloc.c (compact_small_strings): Tighten assertion a little.
3011
3012 Replace pEd with more-general pI, and fix some printf arg casts.
3013 * lisp.h (pI): New macro, generalizing old pEd macro to other
3014 conversion specifiers. For example, use "...%"pI"d..." rather
3015 than "...%"pEd"...".
3016 (pEd): Remove. All uses replaced with similar uses of pI.
3017 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3018 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3019 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3020 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3021 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3022 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3023 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3024 64-bit hosts.
3025 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3026 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3027 * print.c (safe_debug_print, print_object): Likewise.
3028 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3029 to int.
3030 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3031 avoiding the 0 flag, which is not portable.
3032 * process.c (Fmake_network_process): Use pI to avoid cast.
3033 * region-cache.c (pp_cache): Likewise.
3034 * xdisp.c (decode_mode_spec): Likewise.
3035 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3036 behavior on 64-bit hosts with printf arg.
3037 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3038 (x_stop_queuing_selection_requests): Likewise.
3039 (x_get_window_property): Don't truncate byte count to an 'int'
3040 when tracing.
3041
3042 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3043 here, since it parses constructs like leading '-' and spaces,
3044 which are not wanted; and it overflows with large numbers.
3045 Instead, simply match F[0-9]+, which is what is wanted anyway.
3046
3047 * alloc.c: Remove unportable assumptions about struct layout.
3048 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3049 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3050 (allocate_vectorlike, make_pure_vector): Use the new macros,
3051 plus offsetof, to remove unportable assumptions about struct layout.
3052 These assumptions hold on all porting targets that I know of, but
3053 they are not guaranteed, they're easy to remove, and removing them
3054 makes further changes easier.
3055
3056 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3057 This doesn't fix a bug but makes the code clearer.
3058 (string_overrun_cookie): Now const. Use initializers that
3059 don't formally overflow signed char, to avoid warnings.
3060 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3061 can cause Emacs to crash when string overrun checking is enabled.
3062 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3063 multiple of sizeof (EMACS_INT); it need not be, if
3064 alignof(EMACS_INT) < sizeof (EMACS_INT).
3065 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3066
3067 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3068
3069 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3070
3071 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3072
3073 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3074 supposed to be handshaking. (Bug#8556)
3075 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3076
3077 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3078
3079 * lisp.h (Qdebug): List symbol.
3080 * eval.c (Qdebug): Restore global linkage.
3081 * keyboard.c (debug-on-event): New variable.
3082 (handle_user_signal): Break into debugger when debug-on-event
3083 matches the current signal symbol.
3084
3085 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3086
3087 * alloc.c (check_sblock, check_string_bytes)
3088 (check_string_free_list): Convert to standard C.
3089
3090 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3091
3092 * w32.c (emacs_gnutls_push): Fix typo.
3093
3094 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3095
3096 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3097 "cast to pointer from integer of different size".
3098
3099 Improve doprnt and its use in verror. (Bug#8545)
3100 * doprnt.c (doprnt): Document the set of format control sequences
3101 supported by the function. Use SAFE_ALLOCA instead of always
3102 using `alloca'.
3103
3104 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3105 is one byte too soon. Don't use xrealloc; instead xfree and
3106 xmalloc anew.
3107
3108 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3109
3110 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3111 callbacks stage.
3112
3113 * gnutls.c: Renamed global_initialized to
3114 gnutls_global_initialized. Added internals for the
3115 :verify-hostname-error, :verify-error, and :verify-flags
3116 parameters of `gnutls-boot' and documented those parameters in the
3117 docstring. Start callback support.
3118 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3119 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3120 on error. Return error code.
3121 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3122 (emacs_gnutls_read): Likewise.
3123 (Fgnutls_boot): Return handshake error code.
3124 (emacs_gnutls_handle_error): New function.
3125 (wsaerror_to_errno): Likewise.
3126
3127 * w32.h (emacs_gnutls_pull): Add prototype.
3128 (emacs_gnutls_push): Likewise.
3129
3130 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3131 (emacs_gnutls_push): Likewise.
3132
3133 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3134
3135 * process.c (wait_reading_process_output): Check if GnuTLS
3136 buffered some data internally if no FDs are set for TLS
3137 connections.
3138
3139 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3140 (LIBS): Link to USER_LIBS.
3141 ($(BLD)/gnutls.$(0)): New target.
3142
3143 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3144
3145 * xdisp.c (handle_single_display_spec): Rename the
3146 display_replaced_before_p argument into display_replaced_p, to
3147 make it consistent with the commentary. Fix typos in the
3148 commentary.
3149
3150 * textprop.c (syms_of_textprop): Remove dead code.
3151 (copy_text_properties): Delete obsolete commentary about an
3152 interface that was deleted long ago. Fix typos in the description
3153 of arguments.
3154
3155 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3156 to changes in oldXMenu/XMenu.h from 2011-04-16.
3157 <menu_help_message, prev_menu_help_message>: Constify.
3158 (IT_menu_make_room): menu->help_text is now `const char **';
3159 adjust.
3160
3161 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3162 to changes in oldXMenu/XMenu.h from 2011-04-16.
3163 (struct XMenu): Declare `help_text' `const char **'.
3164
3165 * xfaces.c <Qunspecified>: Make extern again.
3166
3167 * syntax.c: Include sys/types.h before including regex.h, as
3168 required by Posix.
3169
3170 * doc.c (get_doc_string): Improve the format passed to `error'.
3171
3172 * doprnt.c (doprnt): Improve commentary.
3173
3174 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3175
3176 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3177 them with etags.
3178
3179 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3180 changes in globals.h immediately force recompilation.
3181 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3182 $(CURDIR)/s/ms-w32.h.
3183 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3184
3185 * character.c (Fchar_direction): Function deleted.
3186 (syms_of_character): Don't defsubr it.
3187 <char-direction-table>: Deleted.
3188
3189 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3190
3191 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3192 * doprnt.c: Include limits.h.
3193 (SIZE_MAX): New macro.
3194 (doprnt): Return a size_t value. 2nd arg is now size_t.
3195 Many local variables are now size_t instead of int or unsigned.
3196 Improve overflow protection. Support `l' modifier for integer
3197 conversions. Support %l conversion. Don't assume an EMACS_INT
3198 argument for integer conversions and for %c.
3199
3200 * lisp.h (doprnt): Restore prototype.
3201
3202 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3203 $(SRC)/character.h.
3204
3205 * Makefile.in (base_obj): Add back doprnt.o.
3206
3207 * deps.mk (doprnt.o): Add back prerequisites.
3208 (callint.o): Depend on character.h.
3209
3210 * eval.c (internal_lisp_condition_case): Include the handler
3211 representation in the error message.
3212 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3213 when breaking from the loop.
3214
3215 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3216
3217 * callint.c (Fcall_interactively): When displaying error message
3218 about invalid control letter, pass the character's codepoint, not
3219 a pointer to its multibyte form. Improve display of the character
3220 in octal and display also its hex code.
3221
3222 * character.c (char_string): Use %x to display the (unsigned)
3223 codepoint of an invalid character, to avoid displaying a bogus
3224 negative value.
3225
3226 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3227 `error', not SYMBOL_NAME itself.
3228
3229 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3230 character arguments to `error'.
3231
3232 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3233 to `error' in error message about FINAL_CHAR argument. Make sure
3234 FINAL_CHAR is a character, and use %c when it is passed as
3235 argument to `error'.
3236
3237 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3238
3239 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3240
3241 * w32.c: Include <time.h>.
3242 (sys_localtime): New function.
3243
3244 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3245
3246 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3247
3248 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3249
3250 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3251
3252 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3253 zombies (Bug#8467).
3254
3255 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3256
3257 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3258 gl_state.e_property when gl_state.object is Qt.
3259
3260 * insdel.c (make_gap_larger): Remove limitation of buffer size
3261 to <= INT_MAX.
3262
3263 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3264
3265 * xdisp.c (lookup_glyphless_char_display)
3266 (produce_glyphless_glyph): Handle cons cell entry in
3267 glyphless-char-display.
3268 (Vglyphless_char_display): Document it.
3269
3270 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3271 glyphless-char-display.
3272
3273 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3274
3275 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3276
3277 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3278
3279 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3280 definition for no-X builds.
3281
3282 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3283
3284 Static checks with GCC 4.6.0 and non-default toolkits.
3285
3286 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3287
3288 * process.c (keyboard_bit_set): Define only if SIGIO.
3289 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3290 (send_process): Repair possible setjmp clobbering.
3291
3292 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3293
3294 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3295
3296 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3297
3298 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3299 Define only if needed.
3300
3301 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3302 by pacifying GCC about it. Maybe it's time to retire it?
3303 * xfaces.c (USG, __TIMEVAL__): Likewise.
3304
3305 * dispextern.h (struct redisplay_interface): Rename param
3306 to avoid shadowing.
3307 * termhooks.h (struct terminal): Likewise.
3308 * xterm.c (xembed_send_message): Likewise.
3309
3310 * insdel.c (make_gap_smaller): Define only if
3311 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3312
3313 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3314 it.
3315
3316 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3317 so that we aren't warned about unused symbols.
3318
3319 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3320
3321 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3322
3323 * xfns.c (x_real_positions): Mark locals as initialized.
3324
3325 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3326
3327 * xterm.c: Fix problems found by static analysis with other toolkits.
3328 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3329 (x_dispatch_event): Declare static if USE_GTK, and
3330 define if USE_GTK || USE_X_TOOLKIT.
3331 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3332 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3333 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3334 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3335
3336 * xmenu.c (menu_help_callback): Pointer type fixes.
3337 Use const pointers when pointing at readonly data. Avoid pointer
3338 signedness clashes.
3339 (FALSE): Remove unused macro.
3340 (update_frame_menubar): Remove unused decl.
3341
3342 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3343
3344 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3345 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3346 (single_menu_item): Rename local to avoid shadowing.
3347
3348 * keyboard.c (make_lispy_event): Remove unused local var.
3349
3350 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3351 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3352
3353 * bitmaps: Change bitmaps from unsigned char back to the X11
3354 compatible char. Avoid the old compiler warnings about
3355 out-of-range initializers by using, for example, '\xab' rather
3356 than 0xab.
3357
3358 * xgselect.c (xgselect_initialize): Check vs interface
3359 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3360
3361 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3362
3363 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3364 to read-only memory.
3365
3366 * fns.c (vector): Remove; this old hack is no longer needed.
3367
3368 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3369 Remove unused var.
3370 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3371
3372 * xrdb.c (x_load_resources): Omit unused local.
3373
3374 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3375 (x_window): Rename locals to avoid shadowing.
3376 (USG): Use the kludged USG macro, to pacify gcc.
3377
3378 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3379 (x_term_init): Remove local to avoid shadowing.
3380
3381 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3382
3383 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3384 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3385
3386 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3387
3388 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3389
3390 Fix regex.c, syntax.c and friends for buffers > 2GB.
3391 * syntax.h (struct gl_state_s): Declare character position members
3392 EMACS_INT.
3393
3394 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3395
3396 * textprop.c (verify_interval_modification, interval_of):
3397 Declare arguments EMACS_INT.
3398
3399 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3400 EMACS_INT.
3401
3402 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3403
3404 * indent.c (Fvertical_motion): Local variable it_start is now
3405 EMACS_INT.
3406
3407 * regex.c (re_match, re_match_2, re_match_2_internal)
3408 (bcmp_translate, regcomp, regexec, print_double_string)
3409 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3410 (re_compile_pattern, re_exec): Declare arguments and local
3411 variables `size_t' and `ssize_t' and return values `regoff_t', as
3412 appropriate.
3413 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3414 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3415 <compile_stack_type>: `size' and `avail' are now `size_t'.
3416
3417 * regex.h <regoff_t>: Use ssize_t, not int.
3418 (re_search, re_search_2, re_match, re_match_2): Arguments that
3419 specify buffer/string position and length are now ssize_t and
3420 size_t. Return type is regoff_t.
3421
3422 2011-04-16 Ben Key <bkey76@gmail.com>
3423
3424 * nsfont.m: Fixed bugs in ns_get_family and
3425 ns_descriptor_to_entity that were caused by using free to
3426 deallocate memory blocks that were allocated by xmalloc (via
3427 xstrdup). This caused Emacs to crash when compiled with
3428 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3429 --enable-checking=xmallocoverrun). xfree is now used to
3430 deallocate these memory blocks.
3431
3432 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3433
3434 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3435
3436 emacs_write: Accept and return EMACS_INT for sizes.
3437 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3438 et seq.
3439 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3440 Accept and return EMACS_INT.
3441 (emacs_gnutls_write): Return the number of bytes written on
3442 partial writes.
3443 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3444 (emacs_read, emacs_write): Remove check for negative size, as the
3445 Emacs source code has been audited now.
3446 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3447 (emacs_read, emacs_write): Use it.
3448 * process.c (send_process): Adjust to the new signatures of
3449 emacs_write and emacs_gnutls_write. Do not attempt to store
3450 a byte offset into an 'int'; it might overflow.
3451 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3452
3453 * sound.c: Don't assume sizes fit in 'int'.
3454 (struct sound_device.period_size, alsa_period_size):
3455 Return EMACS_INT, not int.
3456 (struct sound_device.write, vox_write, alsa_write):
3457 Accept EMACS_INT, not int.
3458 (wav_play, au_play): Use EMACS_INT to store sizes and to
3459 record read return values.
3460
3461 2011-04-15 Ben Key <bkey76@gmail.com>
3462
3463 * keyboard.c (Qundefined): Don't declare static since it is used
3464 in nsfns.m.
3465 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3466 static since they are used in nsfont.m.
3467
3468 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3469
3470 * process.c (Qprocessp): Don't declare static.
3471 * lisp.h (Qprocessp): Declare again.
3472
3473 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3474
3475 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3476
3477 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3478
3479 Improve C-level modularity by making more things 'static'.
3480
3481 Don't publish debugger-only interfaces to other modules.
3482 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3483 (verify_bytepos, count_markers): Move decls to the only modules
3484 that need them.
3485 * region-cache.h (pp_cache): Likewise.
3486 * window.h (check_all_windows): Likewise.
3487 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3488
3489 * sysdep.c (croak): Now static, if
3490 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3491 * syssignal.h (croak): Declare only if not static.
3492
3493 * alloc.c (refill_memory_reserve): Now static if
3494 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3495 * lisp.h (refill_memory_reserve): Declare only if not static.
3496
3497 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3498 Define only if USE_LUCID.
3499
3500 * xrdb.c (x_customization_string, x_rm_string): Now static.
3501
3502 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3503 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3504
3505 * xdisp.c (draw_row_with_mouse_face): Now static.
3506 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3507
3508 * window.h (check_all_windows): Mark externally visible.
3509
3510 * window.c (window_deletion_count): Now static.
3511
3512 * undo.c: Make symbols static if they're not exported.
3513 (last_undo_buffer, last_boundary_position, pending_boundary):
3514 Now static.
3515
3516 * textprop.c (interval_insert_behind_hooks): Now static.
3517 (interval_insert_in_front_hooks): Likewise.
3518
3519 * term.c: Make symbols static if they're not exported.
3520 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3521 (max_frame_lines, tty_set_terminal_modes):
3522 (tty_reset_terminal_modes, tty_turn_off_highlight):
3523 (get_tty_terminal): Now static.
3524 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3525 * termhooks.h (term_mouse_moveto): Do not declare if
3526 HAVE_WINDOW_SYSTEM.
3527 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3528 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3529
3530 * sysdep.c: Make symbols static if they're not exported.
3531 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3532 Now static.
3533 (sigprocmask_set, full_mask): Remove; unused.
3534 (wait_debugging): Mark as visible.
3535 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3536 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3537
3538 * syntax.c (syntax_temp): Define only if !__GNUC__.
3539
3540 * sound.c (current_sound_device, current_sound): Now static.
3541
3542 * search.c (searchbufs, searchbuf_head): Now static.
3543
3544 * scroll.c (scroll_cost): Remove; unused.
3545 * dispextern.h (scroll_cost): Remove decl.
3546
3547 * region-cache.h (pp_cache): Mark as externally visible.
3548
3549 * process.c: Make symbols static if they're not exported.
3550 (process_tick, update_tick, create_process, chan_process):
3551 (Vprocess_alist, proc_buffered_char, datagram_access):
3552 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3553 (deactivate_process): Mark defn as static, as well as decl.
3554 * lisp.h (create_process): Remove decl.
3555 * process.h (chan_process, Vprocess_alist): Remove decls.
3556
3557 * print.c: Make symbols static if they're not exported.
3558 (print_depth, new_backquote_output, being_printed, print_buffer):
3559 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3560 (print_interval, print_number_index, initial_stderr_stream):
3561 Now static.
3562 * lisp.h (Fprinc): Remove decl.
3563 (debug_output_compilation_hack): Mark as externally visible.
3564
3565 * sysdep.c (croak): Move decl from here to syssignal.h.
3566 * syssignal.h (croak): Put it here, so the API can be checked when
3567 'croak' is called from dissociate_if_controlling_tty.
3568
3569 * minibuf.c: Make symbols static if they're not exported.
3570 (minibuf_save_list, choose_minibuf_frame): Now static.
3571 * lisp.h (choose_minibuf_frame): Remove decl.
3572
3573 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3574
3575 * lread.c: Make symbols static if they're not exported.
3576 (read_objects, initial_obarray, oblookup_last_bucket_number):
3577 Now static.
3578 (make_symbol): Remove; unused.
3579 * lisp.h (initial_obarray, make_symbol): Remove decls.
3580
3581 * keyboard.c: Make symbols static if they're not exported.
3582 (single_kboard, recent_keys_index, total_keys, recent_keys):
3583 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3584 (this_single_command_key_start, echoing, last_auto_save):
3585 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3586 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3587 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3588 (Vlispy_mouse_stem, double_click_count):
3589 Now static.
3590 (force_auto_save_soon): Define only if SIGDANGER.
3591 (ignore_mouse_drag_p): Now static if
3592 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3593 (print_help): Remove; unused.
3594 (stop_character, last_timer_event): Mark as externally visible.
3595 * keyboard.h (ignore_mouse_drag_p): Declare only if
3596 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3597 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3598 * lisp.h (echoing): Remove decl.
3599 (force_auto_save_soon): Declare only if SIGDANGER.
3600 * xdisp.c (redisplay_window): Simplify code, to make it more
3601 obvious that ignore_mouse_drag_p is not accessed if !defined
3602 USE_GTK && !defined HAVE_NS.
3603
3604 * intervals.c: Make symbols static if they're not exported.
3605 (merge_properties_sticky, merge_interval_right, delete_interval):
3606 Now static.
3607 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3608
3609 * insdel.c: Make symbols static if they're not exported.
3610 However, leave prepare_to_modify_buffer alone. It's never
3611 called from outside this function, but that appears to be a bug.
3612 (combine_after_change_list, combine_after_change_buffer):
3613 (adjust_after_replace, signal_before_change): Now static.
3614 (adjust_after_replace_noundo): Remove; unused.
3615 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3616 (signal_before_change): Remove decls.
3617
3618 * indent.c (val_compute_motion, val_vmotion): Now static.
3619
3620 * image.c: Make symbols static if they're not exported.
3621 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3622 if USE_GTK.
3623 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3624 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3625
3626 * fringe.c (standard_bitmaps): Now static.
3627 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3628
3629 * frame.c: Make symbols static if they're not exported.
3630 (x_report_frame_params, make_terminal_frame): Now static.
3631 (get_frame_param): Now static, unless HAVE_NS.
3632 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3633 (x_get_resource_string): Remove; not used.
3634 * frame.h (make_terminal_frame, x_report_frame_params):
3635 (x_get_resource_string); Remove decls.
3636 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3637 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3638
3639 * font.c, fontset.c: Make symbols static if they're not exported.
3640 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3641 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3642 * font.c (font_close_object): Now static.
3643 * font.h (font_close_object): Remove.
3644 * fontset.c (FONTSET_OBJLIST): Remove.
3645 (free_realized_fontset) #if-0 the body, which does nothing.
3646 (face_suitable_for_char_p): #if-0, as it's never called.
3647 * fontset.h (face_suitable_for_char_p): Remove decl.
3648 * xfaces.c (face_at_string_position):
3649 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3650 since 0 is always ASCII.
3651
3652 * fns.c (weak_hash_tables): Now static.
3653
3654 * fileio.c: Make symbols static if they're not exported.
3655 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3656 (Vwrite_region_annotation_buffers): Now static.
3657
3658 * eval.c: Make symbols static if they're not exported.
3659 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3660 * lisp.h (backtrace_list): Remove decl.
3661
3662 * emacs.c: Make symbols static if they're not exported.
3663 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3664 (fatal_error_code, fatal_error_signal_hook, standard_args):
3665 Now static.
3666 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3667 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3668 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3669 * lisp.h (fatal_error_signal_hook): Remove decl.
3670 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3671
3672 * editfns.c: Move a (normally-unused) function to its only use.
3673 * editfns.c, lisp.h (get_operating_system_release): Remove.
3674 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3675 worth the hassle of breaking this out.
3676
3677 * xterm.c: Make symbols static if they're not exported.
3678 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3679 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3680 (x_destroy_window, x_delete_display):
3681 Now static.
3682 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3683 (x_mouse_leave): Remove; unused.
3684 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3685 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3686 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3687 Remove decls.
3688 (x_mouse_leave): Declare only if WINDOWSNT.
3689 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3690 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3691 USE_X_TOOLKIT.
3692
3693 * ftxfont.c: Make symbols static if they're not exported.
3694 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3695 HAVE_FREETYPE.
3696 * font.h (ftxfont_driver): Likewise.
3697
3698 * xfns.c: Make symbols static if they're not exported.
3699 (x_last_font_name, x_display_info_for_name):
3700 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3701 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3702 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3703 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3704 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3705 (last_show_tip_args): Now static.
3706 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3707 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3708 (x_screen_planes): Remove; unused.
3709 * dispextern.h (x_screen_planes): Remove decl.
3710
3711 * dispnew.c: Make symbols static if they're not exported.
3712 * dispextern.h (redraw_garbaged_frames, scrolling):
3713 (increment_row_positions): Remove.
3714 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3715 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3716 Now static.
3717 (redraw_garbaged_frames): Remove; unused.
3718
3719 * xfaces.c: Make symbols static if they're not exported.
3720 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3721 Remove decls.
3722 * xterm.h (defined_color): Remove decls.
3723 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3724 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3725 (menu_face_changed_default, defined_color, free_realized_face):
3726 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3727 (ascii_face_of_lisp_face): Remove; unused.
3728
3729 * xdisp.c: Make symbols static if they're not exported.
3730 * dispextern.h (scratch_glyph_row, window_box_edges):
3731 (glyph_to_pixel_coords, set_cursor_from_row):
3732 (get_next_display_element, set_iterator_to_next):
3733 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3734 (show_mouse_face): Remove decls
3735 * frame.h (message_buf_print): Likewise.
3736 * lisp.h (pop_message, set_message, check_point_in_composition):
3737 Likewise.
3738 * xterm.h (set_vertical_scroll_bar): Likewise.
3739 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3740 (message_buf_print, scratch_glyph_row, displayed_buffer):
3741 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3742 (get_next_display_element, show_mouse_face, window_box_edges):
3743 (frame_to_window_pixel_xy, check_point_in_composition):
3744 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3745 (glyph_to_pixel_coords): Remove; unused.
3746
3747 * dired.c (file_name_completion): Now static.
3748
3749 * dbusbind.c (xd_in_read_queued_messages): Now static.
3750
3751 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3752 * data.c (circular_list_error): Remove.
3753
3754 * commands.h (last_point_position, last_point_position_buffer):
3755 (last_point_position_window): Remove decls.
3756 * keyboard.c: Make these variables static.
3757
3758 * coding.h (coding, code_convert_region, encode_coding_gap):
3759 Remove decls.
3760 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3761 (iso_code_class, detect_coding, code_convert_region): Now static.
3762 (encode_coding_gap): Remove; unused.
3763
3764 * chartab.c (chartab_chars, chartab_bits): Now static.
3765
3766 * charset.h (charset_iso_8859_1): Remove decl.
3767 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3768 Now static.
3769
3770 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3771 * ccl.c (Vccl_program_table): Now static.
3772 (check_ccl_update): Remove; unused.
3773
3774 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3775 * category.h: ... from here.
3776 * category.c (check_category_table, set_category_set): Now static.
3777
3778 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3779 * lisp.h: Remove these decls.
3780
3781 * buffer.c (buffer_count): Remove unused var.
3782
3783 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3784 so that it's not optimized away.
3785 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3786 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3787 exported only to the debugger.
3788
3789 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3790 * atimer.h (run_all_atimers): Remove; not exported.
3791
3792 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3793 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3794 was inaccessible from Lisp.
3795 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3796 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3797
3798 alloc.c: Import and export fewer symbols, and remove unused items.
3799 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3800 is defined.
3801 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3802 it's not optimized away by whole-program optimization.
3803 (message_enable_multibyte, free_misc): Remove.
3804 (catchlist, handlerlist, mark_backtrace):
3805 Declare only if BYTE_MARK_STACK.
3806 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3807 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3808 (message_enable_multibyte): Remove decl.
3809 (free_misc, interval_free_list, float_block, float_block_index):
3810 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3811 (cons_free_list, last_marked_index):
3812 Now static.
3813 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3814 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3815 (mark_backtrace): Define only if BYTE_MARK_STACK.
3816 * xdisp.c (message_enable_multibyte): Now static.
3817
3818 Declare Lisp_Object Q* variables to be 'static' if not exported.
3819 This makes it easier for human readers (and static analyzers)
3820 to see whether these variables are used from other modules.
3821 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3822 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3823 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3824 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3825 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3826 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3827 * xmenu.c, xselect.c:
3828 Declare Q* vars static if they are not used in other modules.
3829 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3830 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3831 Remove decls of unexported vars.
3832 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3833
3834 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3835
3836 Make Emacs functions such as Fatom 'static' by default.
3837 This makes it easier for human readers (and static analyzers)
3838 to see whether these functions can be called from other modules.
3839 DEFUN now defines a static function. To make the function external
3840 so that it can be used in other C modules, use the new macro DEFUE.
3841 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3842 (Finit_image_library):
3843 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3844 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3845 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3846 Remove decls, since these functions are now static.
3847 (Funintern, Fget_internal_run_time): New decls, since these functions
3848 were already external.
3849
3850 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3851 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3852 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3853 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3854 * keyboard.c, keymap.c, lread.c:
3855 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3856 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3857 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3858 Mark functions with DEFUE instead of DEFUN,
3859 if they are used in other modules.
3860 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3861 decls for now-static functions.
3862 * buffer.h (Fdelete_overlay): Remove decl.
3863 * callproc.c (Fgetenv_internal): Mark as internal.
3864 * composite.c (Fremove_list_of_text_properties): Remove decl.
3865 (Fcomposition_get_gstring): New forward static decl.
3866 * composite.h (Fcomposite_get_gstring): Remove decl.
3867 * dired.c (Ffile_attributes): New forward static decl.
3868 * doc.c (Fdocumntation_property): New forward static decl.
3869 * eval.c (Ffetch_bytecode): New forward static decl.
3870 (Funintern): Remove extern decl; now in .h file where it belongs.
3871 * fileio.c (Fmake_symbolic_link): New forward static decl.
3872 * image.c (Finit_image_library): New forward static decl.
3873 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3874 * intervals.h (Fprevious_property_change):
3875 (Fremove_list_of_text_properties): Remove decls.
3876 * keyboard.c (Fthis_command_keys): Remove decl.
3877 (Fcommand_execute): New forward static decl.
3878 * keymap.c (Flookup_key): New forward static decl.
3879 (Fcopy_keymap): Now static.
3880 * keymap.h (Flookup_key): Remove decl.
3881 * process.c (Fget_process): New forward static decl.
3882 (Fprocess_datagram_address): Mark as internal.
3883 * syntax.c (Fsyntax_table_p): New forward static decl.
3884 (skip_chars): Remove duplicate decl.
3885 * textprop.c (Fprevious_property_change): New forward static decl.
3886 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3887 Now internal.
3888 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3889 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3890
3891 * editfns.c (Fformat): Remove unreachable code.
3892
3893 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3894
3895 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3896 change. (Bug#8496)
3897
3898 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3899
3900 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3901 when at ZV. (Bug#8487)
3902
3903 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3904
3905 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3906 (Bug#8437)
3907 * keyboard.c (parse_tool_bar_item): Likewise.
3908 * sound.c (sound_cleanup, alsa_close): Likewise.
3909 * termcap.c (tgetent): Likewise.
3910 * xfns.c (x_default_font_parameter): Likewise.
3911 * xsettings.c (read_and_apply_settings): Likewise.
3912
3913 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3914 (overrun_check_free): Protoize.
3915
3916 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3917
3918 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3919 since callers should never pass a negative size.
3920 Change the signature to match that of plain 'read' and 'write'; see
3921 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3922 * lisp.h: Update prototypes of emacs_write and emacs_read.
3923
3924 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3925
3926 * xdisp.c (redisplay_window): Don't try to determine the character
3927 position of the scroll margin if the window start point w->startp
3928 is outside the buffer's accessible region. (Bug#8468)
3929
3930 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3931
3932 Fix write-region and its subroutines for buffers > 2GB.
3933 * fileio.c (a_write, e_write): Modify declaration of arguments and
3934 local variables to support buffers larger than 2GB.
3935 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3936
3937 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3938 argument, local variables, and return value.
3939
3940 * lisp.h: Update prototypes of emacs_write and emacs_read.
3941
3942 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3943
3944 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3945
3946 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3947
3948 Fix more problems found by GCC 4.6.0's static checks.
3949
3950 * xdisp.c (vmessage): Use a better test for character truncation.
3951
3952 * charset.c (load_charset_map): <, not <=, for optimization,
3953 and to avoid potential problems with integer overflow.
3954 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3955 * casetab.c (set_identity, shuffle): Likewise.
3956 * editfns.c (Fformat): Likewise.
3957 * syntax.c (skip_chars): Likewise.
3958
3959 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3960 This also lets GCC 4.6.0 generate slightly better loop code.
3961
3962 * callint.c (Fcall_interactively): <, not <=, for optimization.
3963 (Fcall_interactively): Count the number of arguments produced,
3964 not the number of arguments given. This is simpler and lets GCC
3965 4.6.0 generate slightly better code.
3966
3967 * ftfont.c: Distingish more carefully between FcChar8 and char.
3968 The previous code passed unsigned char * to a functions like
3969 strlen and xstrcasecmp that expect char *, which does not
3970 conform to the C standard.
3971 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3972 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3973 char * when the C standard requires it.
3974
3975 * keyboard.c (read_char): Remove unused var.
3976
3977 * eval.c: Port to Windows vsnprintf (Bug#8435).
3978 Include <limits.h>.
3979 (SIZE_MAX): Define if the headers do not.
3980 (verror): Do not give up if vsnprintf returns a negative count.
3981 Instead, grow the buffer. This ports to Windows vsnprintf, which
3982 does not conform to C99. Problem reported by Eli Zaretskii.
3983 Also, simplify the allocation scheme, by avoiding the need for
3984 calling realloc, and removing the ALLOCATED variable.
3985
3986 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3987
3988 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3989 But keep the doprint source code for now, as we might revamp it
3990 and use it again (Bug#8435).
3991 * lisp.h (doprnt): Remove.
3992 * Makefile.in (base_obj): Remove doprnt.o.
3993 * deps.mk (doprnt.o): Remove.
3994
3995 error: Print 32- and 64-bit integers portably (Bug#8435).
3996 Without this change, on typical 64-bit hosts error ("...%d...", N)
3997 was used to print both 32- and 64-bit integers N, which relied on
3998 undefined behavior.
3999 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4000 New macro.
4001 * lisp.h (error, verror): Mark as printf-like functions.
4002 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4003 Report overflow in size calculations when allocating printf buffer.
4004 Do not truncate output string at its first null byte.
4005 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4006 Truncate the output at a character boundary, since vsnprintf does not
4007 do that.
4008 * charset.c (check_iso_charset_parameter): Convert internal
4009 character to string before calling 'error', since %c now has the
4010 printf meaning.
4011 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4012 overflow when computing char to be passed to 'error'. Do not
4013 pass Lisp_Object to 'error'; pass the integer instead.
4014 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4015 formatted with plain %d.
4016
4017 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4018
4019 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4020
4021 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4022
4023 * xterm.c (x_catch_errors): Remove duplicate declaration.
4024
4025 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4026
4027 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4028
4029 2011-04-10 Jim Meyering <meyering@redhat.com>
4030
4031 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4032 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4033 return ssize_t not "int", and use size_t as the buffer length.
4034 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4035 * gnutls.h: Update declarations.
4036 * process.c (read_process_output): Use ssize_t, to match.
4037 (send_process): Likewise.
4038
4039 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4040
4041 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4042
4043 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4044
4045 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4046 Use unsigned char, to match FcChar8 type definition.
4047
4048 * xterm.c (handle_one_xevent):
4049 * xmenu.c (create_and_show_popup_menu):
4050 * xselect.c (x_decline_selection_request)
4051 (x_reply_selection_request): Avoid type-punned deref of X events.
4052
4053 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4054
4055 Fix some uses of `int' instead of EMACS_INT.
4056 * search.c (string_match_1, fast_string_match)
4057 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4058 (scan_buffer, find_next_newline_no_quit)
4059 (find_before_next_newline, search_command, Freplace_match)
4060 (Fmatch_data): Make some `int' variables be EMACS_INT.
4061
4062 * xdisp.c (display_count_lines): 3rd argument and return value now
4063 EMACS_INT. All callers changed.
4064 (pint2hrstr): Last argument is now EMACS_INT.
4065
4066 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4067 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4068 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4069 (decode_coding_utf_16, decode_coding_emacs_mule)
4070 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4071 (decode_coding_ccl, decode_coding_charset)
4072 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4073 (decode_coding_iso_2022, decode_coding_emacs_mule)
4074 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4075 <char_offset, last_offset>: Declare EMACS_INT.
4076 (encode_coding_utf_8, encode_coding_utf_16)
4077 (encode_coding_emacs_mule, encode_invocation_designation)
4078 (encode_designation_at_bol, encode_coding_iso_2022)
4079 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4080 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4081 Declare EMACS_INT.
4082 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4083 (encode_invocation_designation): Last argument P_NCHARS is now
4084 EMACS_INT.
4085 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4086 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4087
4088 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4089 All users changed.
4090
4091 * ccl.c (Fccl_execute_on_string): Declare some variables
4092 EMACS_INT.
4093
4094 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4095
4096 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4097
4098 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4099
4100 * process.c (Fformat_network_address): Doc fix.
4101
4102 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4103
4104 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4105
4106 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4107
4108 * keyboard.c (read_char): Call Lisp function help-form-show,
4109 instead of using internal_with_output_to_temp_buffer.
4110 (Qhelp_form_show): New var.
4111 (syms_of_keyboard): Use DEFSYM macro.
4112
4113 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4114
4115 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4116
4117 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4118
4119 * process.c (Flist_processes): Remove to Lisp.
4120 (list_processes_1): Delete.
4121
4122 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4123
4124 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4125
4126 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4127
4128 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4129
4130 Fix more problems found by GCC 4.6.0's static checks.
4131
4132 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4133
4134 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4135
4136 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4137
4138 * xdisp.c (vmessage): Mark as a printf-like function.
4139
4140 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4141
4142 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4143
4144 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4145 printf-like functions.
4146 (tiff_load): Add casts to remove these marks before passing them
4147 to system-supplied API.
4148
4149 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4150
4151 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4152 This avoids several warnings with gcc -Wstrict-overflow.
4153 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4154 directly, rather than having caller test rule sign. This avoids
4155 some unnecessary tests.
4156 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4157 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4158 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4159
4160 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4161 (xfont_open): Avoid unnecessary tests.
4162
4163 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4164
4165 * composite.h, composite.c (composition_gstring_put_cache):
4166 Use EMACS_INT, not int, for length.
4167
4168 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4169 breaking out part of COMPOSITION_DECODE_RULE.
4170 (COMPOSITION_DECODE_RULE): Use it.
4171 * composite.c (get_composition_id): Remove unused local vars,
4172 by using the new macro.
4173
4174 * textprop.c (set_text_properties_1): Change while to do-while,
4175 since the condition is always true at first.
4176
4177 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4178 (interval_deletion_adjustment): Return unsigned value.
4179 All uses changed.
4180
4181 * process.c (list_processes_1, create_pty, read_process_output):
4182 (exec_sentinel): Remove vars that were set but not used.
4183 (create_pty): Remove unnecessary "volatile"s.
4184 (Fnetwork_interface_info): Avoid possibility of int overflow.
4185 (read_process_output): Do adaptive read buffering even if carryover.
4186 (read_process_output): Simplify nbytes computation if buffered.
4187
4188 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4189
4190 * syntax.c (scan_words): Remove var that was set but not used.
4191 (update_syntax_table): Use unsigned instead of int.
4192
4193 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4194 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4195 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4196
4197 * print.c (print_error_message): Avoid int overflow.
4198
4199 * font.c (font_list_entities): Redo for clarity,
4200 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4201
4202 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4203 (font_score): Avoid potential overflow in diff calculation.
4204
4205 * fns.c (substring_both): Remove var that is set but not used.
4206 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4207
4208 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4209
4210 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4211 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4212 can always succeed if overflow has undefined behavior.
4213
4214 * search.c (boyer_moore, wordify): Remove vars set but not used.
4215 (wordify): Omit three unnecessary tests.
4216
4217 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4218 All callers changed. This avoids the need for an unused var.
4219
4220 * casefiddle.c (casify_region): Remove var that is set but not used.
4221
4222 * dired.c (file_name_completion): Remove var that is set but not used.
4223
4224 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4225
4226 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4227 (Finsert_file_contents): Remove unnecessary code checking fd.
4228
4229 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4230 Check for integer overflow on size calculations.
4231
4232 * buffer.c (Fprevious_overlay_change): Remove var that is set
4233 but not used.
4234
4235 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4236 Remove vars that are set but not used.
4237 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4238 (timer_check_2): Mark vars as initialized.
4239
4240 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4241
4242 * image.c (lookup_image): Remove var that is set but not used.
4243 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4244
4245 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4246 that are set but not used.
4247
4248 * xfns.c (make_invisible_cursor): Don't return garbage
4249 if XCreateBitmapFromData fails (Bug#8410).
4250
4251 * xselect.c (x_get_local_selection, x_handle_property_notify):
4252 Remove vars that are set but not used.
4253
4254 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4255 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4256
4257 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4258 Remove var that is set but not used.
4259 (scroll_bar_windows_size): Now size_t, not int.
4260 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4261 Check for overflow.
4262
4263 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4264 (map_tty_color) [!defined MSDOS]: Likewise.
4265
4266 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4267
4268 * coding.c: Remove vars that are set but not used.
4269 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4270 All callers changed.
4271 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4272 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4273 (decode_coding_charset): Remove vars that are set but not used.
4274
4275 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4276 that is set but not used.
4277
4278 * print.c (print_object): Remove var that is set but not used.
4279
4280 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4281 The gnulib version avoids calling malloc in the usual case,
4282 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4283 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4284 * filelock.c (current_lock_owner): Likewise.
4285 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4286 * sysdep.c: Include allocator.h, careadlinkat.h.
4287 (emacs_no_realloc_allocator): New static constant.
4288 (emacs_readlink): New function.
4289 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4290 ../lib/careadlinkat.h.
4291
4292 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4293
4294 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4295 first non-nil return value).
4296
4297 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4298
4299 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4300 if not defined (Bug#8403).
4301
4302 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4303
4304 * xdisp.c (display_count_lines): Remove parameter `start',
4305 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4306 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4307 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4308 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4309 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4310 and thereabouts. All callers changed.
4311 (get_per_char_metric): Remove parameter `f', unused since
4312 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4313
4314 2011-04-02 Jim Meyering <meyering@redhat.com>
4315
4316 do not dereference NULL upon failed strdup
4317 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4318 (ns_get_family): Likewise.
4319
4320 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4321
4322 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4323
4324 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4325
4326 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4327 later (Bug#8403).
4328
4329 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4330
4331 Add lexical binding.
4332
4333 * window.c (Ftemp_output_buffer_show): New fun.
4334 (Fsave_window_excursion):
4335 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4336
4337 * lread.c (lisp_file_lexically_bound_p): New function.
4338 (Fload): Bind Qlexical_binding.
4339 (readevalloop): Remove `evalfun' arg.
4340 Bind Qinternal_interpreter_environment.
4341 (Feval_buffer): Bind Qlexical_binding.
4342 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4343 Mark as dynamic.
4344 (syms_of_lread): Declare `lexical-binding'.
4345
4346 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4347
4348 * keyboard.c (eval_dyn): New fun.
4349 (menu_item_eval_property): Use it.
4350
4351 * image.c (parse_image_spec): Use Ffunctionp.
4352
4353 * fns.c (concat, mapcar1): Accept byte-code-functions.
4354
4355 * eval.c (Fsetq): Handle lexical vars.
4356 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4357 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4358 (FletX, Flet): Obey lexical binding.
4359 (Fcommandp): Handle closures.
4360 (Feval): New `lexical' arg.
4361 (eval_sub): New function extracted from Feval. Use it almost
4362 everywhere where Feval was used. Look up vars in lexical env.
4363 Handle closures.
4364 (Ffunctionp): Move from subr.el.
4365 (Ffuncall): Handle closures.
4366 (apply_lambda): Remove `eval_flags'.
4367 (funcall_lambda): Handle closures and new byte-code-functions.
4368 (Fspecial_variable_p): New function.
4369 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4370 but without exporting it to Lisp.
4371
4372 * doc.c (Fdocumentation, store_function_docstring):
4373 * data.c (Finteractive_form): Handle closures.
4374
4375 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4376 interactive spec.
4377
4378 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4379 New byte-codes.
4380 (exec_byte_code): New function extracted from Fbyte_code to handle new
4381 calling convention for byte-code-functions. Add new byte-codes.
4382
4383 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4384
4385 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4386
4387 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4388
4389 * xdisp.c (redisplay_internal): Fix prototype.
4390
4391 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4392
4393 * xdisp.c (SCROLL_LIMIT): New macro.
4394 (try_scrolling): Use it when setting scroll_limit.
4395 Limit scrolling to 100 screen lines.
4396 (redisplay_window): Even when falling back on "recentering",
4397 position point in the window according to scroll-conservatively,
4398 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4399
4400 (try_scrolling): When point is above the window, allow searching
4401 as far as scroll_max, or one screenful, to compute vertical
4402 distance from PT to the scroll margin position. This prevents
4403 try_scrolling from unnecessarily failing when
4404 scroll-conservatively is set to a value slightly larger than the
4405 window height. Clean up the case of PT below the margin at bottom
4406 of window: scroll_max can no longer be INT_MAX. When aggressive
4407 scrolling is in use, don't let point enter the opposite scroll
4408 margin as result of the scroll.
4409 (syms_of_xdisp) <scroll-conservatively>: Document the
4410 threshold of 100 lines for never-recentering scrolling.
4411
4412 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4413
4414 * dispextern.h (move_it_by_lines):
4415 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4416 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4417 (message_log_check_duplicate): Remove parameters `prev_bol' and
4418 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4419 (redisplay_internal): Remove parameter `preserve_echo_area',
4420 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4421
4422 * indent.c (Fvertical_motion):
4423 * window.c (window_scroll_pixel_based, Frecenter):
4424 Don't pass `need_y_p' to `move_it_by_lines'.
4425
4426 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4427
4428 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4429 steal a few bits to be more compact.
4430 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4431 Remove unneeded casts.
4432
4433 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4434
4435 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4436
4437 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4438 binding" message (bug#7967).
4439
4440 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4441
4442 Fix more problems found by GCC 4.6.0's static checks.
4443
4444 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4445 Remove unused local var.
4446
4447 * editfns.c (Fmessage_box): Remove unused local var.
4448
4449 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4450 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4451 Omit unused local vars.
4452 * window.c (shrink_windows): Omit unused local var.
4453 * menu.c (digest_single_submenu): Omit unused local var.
4454 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4455 Omit unused local var.
4456
4457 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4458 Don't assume string length fits in int.
4459 (keyremap_step, read_key_sequence): Use size_t for sizes.
4460 (read_key_sequence): Don't check last_real_key_start redundantly.
4461
4462 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4463 instead of alloca (Bug#8344).
4464
4465 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4466 (Fbacktrace_frame): Don't assume nframes fits in int.
4467
4468 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4469
4470 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4471 concerns.
4472
4473 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4474
4475 * cm.c (calccost): Turn while-do into do-while, for clarity.
4476
4477 * keyboard.c (syms_of_keyboard): Use the same style as later
4478 in this function when indexing through an array. This also
4479 works around GCC bug 48267.
4480
4481 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4482
4483 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4484
4485 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4486 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4487
4488 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4489 This avoids undefined behavior on integer overflow, and is a bit
4490 more convenient anyway since it is compared to a size_t variable.
4491
4492 Variadic C functions now count arguments with size_t, not int.
4493 This avoids an unnecessary limitation on 64-bit machines, which
4494 caused (substring ...) to crash on large vectors (Bug#8344).
4495 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4496 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4497 All variadic functions and their callers changed accordingly.
4498 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4499 * data.c (arith_driver, float_arith_driver): Likewise.
4500 * editfns.c (general_insert_function): Likewise.
4501 * eval.c (struct backtrace.nargs, interactive_p)
4502 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4503 (funcall_lambda, mark_backtrace): Likewise.
4504 * fns.c (concat): Likewise.
4505 * frame.c (x_set_frame_parameters): Likewise.
4506 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4507 0 if not found, not -1. All callers changed.
4508
4509 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4510 (stack_copy_size): Now size_t, not int.
4511 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4512
4513 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4514
4515 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4516 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4517 All callers changed.
4518
4519 * lisp.h (multibyte_char_to_unibyte):
4520 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4521 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4522 * character.h (CHAR_TO_BYTE8):
4523 * cmds.c (internal_self_insert):
4524 * editfns.c (general_insert_function):
4525 * keymap.c (push_key_description):
4526 * search.c (Freplace_match):
4527 * xdisp.c (message_dolog, set_message_1): All callers changed.
4528
4529 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4530
4531 * keyboard.c (safe_run_hook_funcall): New function.
4532 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4533 don't set the hook to nil, but remove the offending function instead.
4534 (Qcommand_hook_internal): Remove, unused.
4535 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4536 Vcommand_hook_internal.
4537
4538 * eval.c (enum run_hooks_condition): Remove.
4539 (funcall_nil, funcall_not): New functions.
4540 (run_hook_with_args): Call each function through a `funcall' argument.
4541 Remove `cond' argument, now redundant.
4542 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4543 (Frun_hook_with_args_until_failure): Adjust accordingly.
4544 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4545
4546 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4547
4548 * dispextern.h (string_buffer_position): Remove declaration.
4549
4550 * print.c (strout): Remove parameter `multibyte', unused since
4551 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4552
4553 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4554 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4555 All callers changed.
4556
4557 * w32.c (_wsa_errlist): Use braces for struct initializers.
4558
4559 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4560 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4561 All callers changed.
4562 (string_buffer_position): Likewise. Also, make static (it's never
4563 used outside xdisp.c).
4564 (cursor_row_p): Remove parameter `w', unused since
4565 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4566 (decode_mode_spec): Remove parameter `precision', introduced during
4567 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4568 All callers changed.
4569
4570 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4571
4572 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4573
4574 2011-03-27 Anders Lindgren <andlind@gmail.com>
4575
4576 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4577 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4578 (ns_update_auto_hide_menu_bar): New functions.
4579 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4580 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4581 ns_constrain_all_frames.
4582 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4583 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4584
4585 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4586
4587 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4588
4589 2011-03-27 Glenn Morris <rgm@gnu.org>
4590
4591 * syssignal.h: Replace RETSIGTYPE with void.
4592 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4593 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4594 Replace SIGTYPE with void everywhere.
4595 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4596 * s/template.h (SIGTYPE): Remove commented out definition.
4597
4598 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4599
4600 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4601 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4602
4603 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4604
4605 * w32.c (read_unc_volume): Use parameter `henum', instead of
4606 global variable `wget_enum_handle'.
4607
4608 * keymap.c (describe_vector): Remove parameters `indices' and
4609 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4610 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4611
4612 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4613
4614 * keyboard.c (timer_check): Remove parameter `do_it_now',
4615 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4616 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4617 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4618
4619 * keyboard.c (read_char):
4620 * w32menu.c (w32_menu_display_help):
4621 * xmenu.c (show_help_event, menu_help_callback):
4622 Adjust calls to `show_help_echo'.
4623
4624 * gtkutil.c (xg_maybe_add_timer):
4625 * keyboard.c (readable_events):
4626 * process.c (wait_reading_process_output):
4627 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4628
4629 * insdel.c (adjust_markers_gap_motion):
4630 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4631 (gap_left, gap_right): Don't call it.
4632
4633 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4634
4635 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4636 incurred during fontification.
4637
4638 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4639
4640 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4641 (DEFVAR_PER_BUFFER): Don't pass it.
4642
4643 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4644 (scrolling_window): Don't pass it.
4645
4646 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4647
4648 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4649
4650 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4651 and `suffix'.
4652 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4653 of variables specific to SELinux and computation of `encoded_absname'.
4654
4655 * image.c (XPutPixel): Remove unused variable `height'.
4656
4657 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4658
4659 * unexw32.c (get_section_info): Remove unused variable `section'.
4660
4661 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4662 (system_process_attributes): Remove unused variable `sess'.
4663 (sys_read): Remove unused variable `err'.
4664
4665 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4666 (w32_wnd_proc): Remove unused variable `isdead'.
4667 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4668 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4669 (x_create_tip_frame): Remove unused variable `tem'.
4670
4671 * w32inevt.c (w32_console_read_socket):
4672 Remove unused variable `no_events'.
4673
4674 * w32term.c (x_draw_composite_glyph_string_foreground):
4675 Remove unused variable `width'.
4676
4677 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4678
4679 * w32term.c (x_set_glyph_string_clipping):
4680 Don't pass uninitialized region to CombineRgn.
4681
4682 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4683
4684 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4685 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4686 (Fx_close_connection): Remove unused variable `i'.
4687
4688 * w32font.c (w32font_draw): Return number of glyphs.
4689 (w32font_open_internal): Remove unused variable `i'.
4690 (w32font_driver): Add missing initializer.
4691
4692 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4693 (fill_in_menu): Remove unused variable `items_added'.
4694
4695 * w32term.c (last_mouse_press_frame): Remove static global variable.
4696 (w32_clip_to_row): Remove unused variable `f'.
4697 (x_delete_terminal): Remove unused variable `i'.
4698
4699 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4700 (NOTHING): Remove unused static global variable.
4701 (uniscribe_check_otf): Remove unused variable `table'.
4702 (uniscribe_font_driver): Add missing initializers.
4703
4704 2011-03-23 Julien Danjou <julien@danjou.info>
4705
4706 * term.c (Fsuspend_tty, Fresume_tty):
4707 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4708 * window.c (temp_output_buffer_show):
4709 * insdel.c (signal_before_change):
4710 * frame.c (Fhandle_switch_frame):
4711 * fileio.c (Fdo_auto_save):
4712 * emacs.c (Fkill_emacs):
4713 * editfns.c (save_excursion_restore):
4714 * cmds.c (internal_self_insert):
4715 * callint.c (Fcall_interactively):
4716 * buffer.c (Fkill_all_local_variables):
4717 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4718 Use Frun_hooks.
4719 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4720 unconditionnaly since it does the check itself.
4721
4722 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4723
4724 Fix more problems found by GCC 4.5.2's static checks.
4725
4726 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4727 the first time through the loop, since we know p0 < p1 then.
4728 This also avoids a gcc -Wstrict-overflow warning.
4729
4730 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4731 leading to a memory leak, possible in functions like
4732 load_charset_map_from_file that can allocate an unbounded number
4733 of objects (Bug#8318).
4734
4735 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4736 that could (at least in theory) be that large.
4737
4738 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4739 This is less likely to overflow, and avoids undefined behavior if
4740 overflow does occur. All callers changed. Use strtoul to scan
4741 for the unsigned long integer.
4742 (pint2hrstr): Simplify and tune code slightly.
4743 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4744
4745 * scroll.c (do_scrolling): Work around GCC bug 48228.
4746 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4747
4748 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4749 This also avoids a warning with gcc -Wstrict-overflow.
4750 (validate_x_resource_name): Simplify count usage.
4751 This also avoids a warning with gcc -Wstrict-overflow.
4752
4753 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4754 fail (Bug#8306).
4755
4756 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4757
4758 * process.c (Fmake_network_process): Use socklen_t, not int,
4759 where POSIX says socklen_t is required in portable programs.
4760 This fixes a porting bug on hosts like 64-bit HP-UX, where
4761 socklen_t is wider than int (Bug#8277).
4762 (Fmake_network_process, server_accept_connection):
4763 (wait_reading_process_output, read_process_output):
4764 Likewise.
4765
4766 * process.c: Rename or move locals to avoid shadowing.
4767 (list_processes_1, Fmake_network_process):
4768 (read_process_output_error_handler, exec_sentinel_error_handler):
4769 Rename or move locals.
4770 (Fmake_network_process): Define label "retry_connect" only if needed.
4771 (Fnetwork_interface_info): Fix pointer signedness.
4772 (process_send_signal): Add cast to avoid pointer signedness problem.
4773 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4774 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4775
4776 Make tparam.h and terminfo.c consistent.
4777 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4778 Include tparam.h instead, since it declares them.
4779 * cm.h (PC): Remove extern decl; tparam.h now does this.
4780 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4781 * terminfo.c: Include tparam.h, to check interfaces.
4782 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4783 (tparam): Adjust signature to match interface in tparam.h;
4784 this removes some undefined behavior. Check that outstring and len
4785 are zero, which they always are with Emacs.
4786 * tparam.h (PC, BC, UP): New extern decls.
4787
4788 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4789 (xftfont_open): Rename locals to avoid shadowing.
4790
4791 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4792 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4793 (OTF_TAG_SYM): Omit macro if not needed.
4794 (ftfont_list): Remove unused local.
4795 (get_adstyle_property, ftfont_pattern_entity):
4796 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4797 Rename locals to avoid shadowing.
4798
4799 * xfont.c (xfont_list_family): Mark var as initialized.
4800
4801 * xml.c (make_dom): Now static.
4802
4803 * composite.c (composition_compute_stop_pos): Rename local to
4804 avoid shadowing.
4805 (composition_reseat_it): Remove unused locals.
4806 (find_automatic_composition, composition_adjust_point): Likewise.
4807 (composition_update_it): Mark var as initialized.
4808 (find_automatic_composition): Mark vars as initialized,
4809 with a FIXME (Bug#8290).
4810
4811 character.h: Rename locals to avoid shadowing.
4812 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4813 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4814 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4815 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4816 to avoid shadowing.
4817
4818 * textprop.c (property_change_between_p): Remove; unused.
4819
4820 * intervals.c (interval_start_pos): Now static.
4821
4822 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4823
4824 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4825 Rename locals to avoid shadowing.
4826
4827 * sound.c (wav_play, au_play, Fplay_sound_internal):
4828 Fix pointer signedness.
4829 (alsa_choose_format): Remove unused local var.
4830 (wav_play): Initialize a variable to 0, to prevent undefined
4831 behavior (Bug#8278).
4832
4833 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4834
4835 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4836
4837 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4838 clobbering (Bug#8298).
4839 * sysdep.c (sys_subshell): Likewise.
4840 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4841
4842 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4843 This should get cleaned up, so that child_setup has the
4844 same signature on all platforms.
4845
4846 * callproc.c (call_process_cleanup): Now static.
4847 (relocate_fd): Rename locals to avoid shadowing.
4848
4849 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4850
4851 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4852 not to be necessary, and produces flickering.
4853
4854 2011-03-20 Glenn Morris <rgm@gnu.org>
4855
4856 * config.in: Remove file.
4857
4858 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4859
4860 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4861 are now in src/globals.h.
4862 (syms_of_minibuf): Remove spurious & from previous change.
4863
4864 2011-03-20 Leo <sdl.web@gmail.com>
4865
4866 * minibuf.c (completing-read-function): New variable.
4867 (completing-read-default): Rename from completing-read.
4868 (completing-read): Call completing-read-function.
4869
4870 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4871
4872 * xfaces.c (Fx_load_color_file):
4873 Read color file from absolute filename (bug#8250).
4874
4875 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4876
4877 * makefile.w32-in: Update dependencies.
4878
4879 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4880
4881 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4882
4883 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4884
4885 Fix more problems found by GCC 4.5.2's static checks.
4886
4887 * process.c (make_serial_process_unwind, send_process_trap):
4888 (sigchld_handler): Now static.
4889
4890 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4891 That way, the code declares only the vars that it needs.
4892 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4893 * s/cygwin.h (PTY_ITERATION): Likewise.
4894 * s/darwin.h (PTY_ITERATION): Likewise.
4895 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4896
4897 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4898 * process.c (allocate_pty): Don't declare stb unless it's needed.
4899
4900 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4901 (CONSTANTLIM): Remove; unused.
4902 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4903 Define only if needed.
4904
4905 * unexelf.c (unexec): Name an expression,
4906 to avoid gcc -Wbad-function-cast warning.
4907 Use a different way to cause a compilation error if anyone uses
4908 n rather than nn, a way that does not involve shadowing.
4909 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4910
4911 * deps.mk (unexalpha.o): Remove; unused.
4912
4913 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4914 * unexec.h: New file.
4915 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4916 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4917 Depend on unexec.h.
4918 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4919 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4920 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4921 Change as necessary to match prototype in unexec.h.
4922
4923 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4924 shadowing.
4925 (back_comment, skip_chars): Mark vars as initialized.
4926
4927 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4928 Rename locals to avoid shadowing.
4929
4930 * lread.c (read1): Rewrite so as not to use empty "else".
4931 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4932
4933 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4934
4935 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4936 warning when compiling print.c.
4937
4938 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4939 instead of using an uninitialized var.
4940 (font_sort_entities): Mark var as initialized.
4941
4942 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4943
4944 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4945 pointers to constants.
4946 (font_parse_fcname): Remove unused vars.
4947 (font_delete_unmatched): Now static.
4948 (font_get_spec): Remove; unused.
4949 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4950 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4951 Rename or move locals to avoid shadowing.
4952
4953 * fns.c (require_nesting_list, require_unwind): Now static.
4954 (Ffillarray): Rename locals to avoid shadowing.
4955
4956 * floatfns.c (domain_error2): Define only if needed.
4957 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4958
4959 * alloc.c (mark_backtrace): Move decl from here ...
4960 * lisp.h: ... to here, so that it can be checked.
4961
4962 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4963 (Fdefvar): Rewrite so as not to use empty "else".
4964 (lisp_indirect_variable): Name an expression,
4965 to avoid gcc -Wbad-function-cast warning.
4966 (Fdefvar): Rename locals to avoid shadowing.
4967
4968 * callint.c (quotify_arg, quotify_args): Now static.
4969 (Fcall_interactively): Rename locals to avoid shadowing.
4970 Use const pointer when appropriate.
4971
4972 * lisp.h (get_system_name, get_operating_system_release):
4973 Move decls here, to check interfaces.
4974 * process.c (get_operating_system_release): Move decl to lisp.h.
4975 * xrdb.c (get_system_name): Likewise.
4976 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4977 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4978 some of which prompt warnings from gcc -Wbad-function-cast.
4979 (Fformat_time_string, Fencode_time, Finsert_char):
4980 (Ftranslate_region_internal, Fformat):
4981 Rename or remove local vars to avoid shadowing.
4982 (Ftranslate_region_internal): Mark var as initialized.
4983
4984 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4985 avoid shadowing.
4986
4987 * lisp.h (eassert): Check that the argument compiles, even if
4988 ENABLE_CHECKING is not defined.
4989
4990 * data.c (Findirect_variable): Name an expression, to avoid
4991 gcc -Wbad-function-cast warning.
4992 (default_value, arithcompare, arith_driver, arith_error): Now static.
4993 (store_symval_forwarding): Rename local to avoid shadowing.
4994 (Fmake_variable_buffer_local, Fmake_local_variable):
4995 Mark variables as initialized.
4996 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4997
4998 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4999 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5000 Rename locals to avoid shadowing.
5001 (mark_stack): Move local variables into the #ifdef region where
5002 they're used.
5003 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5004 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5005 needed otherwise.
5006 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5007 (GC_STRING_CHARS): Remove; not used.
5008 (Fmemory_limit): Cast sbrk's returned value to char *.
5009
5010 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5011 avoids undefined behavior in theory.
5012
5013 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5014
5015 Use functions, not macros, for up- and down-casing (Bug#8254).
5016 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5017 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5018 to use the following functions instead of these macros.
5019 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5020 EMACS_INT, since callers assume the returned value fits in int.
5021 (upcase1): Likewise, for UPCASE_TABLE.
5022 (uppercasep, lowercasep, upcase): New static inline functions.
5023 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5024 the race-condition problem in the old DOWNCASE.
5025
5026 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5027 Rename locals to avoid shadowing.
5028 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5029 (regex_compile, re_search_2, re_match_2_internal):
5030 Remove unused local vars.
5031 (FREE_VAR): Rewrite so as not to use empty "else",
5032 which gcc can warn about.
5033 (regex_compile, re_match_2_internal): Mark locals as initialized.
5034 (RETALLOC_IF): Define only if needed.
5035 (WORDCHAR_P): Likewise. This one is never needed, but is used
5036 only in a comment talking about a compiler bug, so put inside
5037 the #if 0 of that comment.
5038 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5039 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5040 Remove; unused.
5041
5042 * search.c (boyer_moore): Rename locals to avoid shadowing.
5043 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5044 (PREV_CHAR_BOUNDARY): Likewise.
5045
5046 * search.c (simple_search): Remove unused var.
5047
5048 * dired.c (compile_pattern): Move decl from here ...
5049 * lisp.h: ... to here, so that it can be checked.
5050 (struct re_registers): New forward decl.
5051
5052 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5053
5054 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5055 All uses changed.
5056 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5057 Rename locals to avoid shadowing.
5058 (Fvertical_motion): Mark locals as initialized.
5059
5060 * casefiddle.c (casify_object, casify_region): Now static.
5061 (casify_region): Mark local as initialized.
5062
5063 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5064
5065 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5066 New macros, so that the caller can use some names other than
5067 gcpro1, gcpro2, etc.
5068 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5069 of the new macros.
5070 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5071 argument, for consistency with GCPRO2_VAR, etc: it is now the
5072 prefix of the variable, not the variable itself. All uses
5073 changed.
5074 * dired.c (directory_files_internal, file_name_completion):
5075 Rename locals to avoid shadowing.
5076
5077 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5078 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5079 dired.c's scmp function, had undefined behavior.
5080 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5081 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5082 * buffer.h: ... to here, because these macros use current_buffer,
5083 and the new implementation with inline functions needs to have
5084 current_buffer in scope now, rather than later when the macros
5085 are used.
5086 (downcase, upcase1): New static inline functions.
5087 (DOWNCASE, UPCASE1): Reimplement using these functions.
5088 This avoids undefined behavior in expressions like
5089 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5090 from race conditions in accessing the global variables
5091 case_temp1 and case_temp2.
5092 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5093 * lisp.h (case_temp1, case_temp2): Remove their decls.
5094 * character.h (ASCII_CHAR_P): Move from here ...
5095 * lisp.h: ... to here, so that the inline functions mentioned
5096 above can use them.
5097
5098 * dired.c (directory_files_internal_unwind): Now static.
5099
5100 * fileio.c (file_name_as_directory, directory_file_name):
5101 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5102 Now static.
5103 (file_name_as_directory): Use const pointers when appropriate.
5104 (Fexpand_file_name): Likewise. In particular, newdir might
5105 point at constant storage, so make it a const pointer.
5106 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5107 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5108 signedness issues.
5109 (Fset_file_times, Finsert_file_contents, auto_save_error):
5110 Rename locals to avoid shadowing.
5111
5112 * minibuf.c (choose_minibuf_frame_1): Now static.
5113 (Ftry_completion, Fall_completions): Rename or remove locals
5114 to avoid shadowing.
5115
5116 * marker.c (bytepos_to_charpos): Remove; unused.
5117
5118 * lisp.h (verify_bytepos, count_markers): New decls,
5119 so that gcc does not warn that these functions aren't declared.
5120
5121 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5122 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5123 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5124 (copy_text): Remove unused local var.
5125
5126 * filelock.c (within_one_second): Now static.
5127 (lock_file_1): Rename local to avoid shadowing.
5128
5129 * buffer.c (fix_overlays_before): Mark locals as initialized.
5130 (fix_start_end_in_overlays): Likewise. This function should be
5131 simplified by using pointers-to-pointers, but that's a different
5132 matter.
5133 (switch_to_buffer_1): Now static.
5134 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5135 (report_overlay_modification): Rename locals to avoid shadowing.
5136
5137 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5138 Fix pointer signedness issue.
5139 (sys_subshell): Mark local as volatile if checking for lint,
5140 to suppress a gcc -Wclobbered warning that does not seem to be right.
5141 (MAXPATHLEN): Define only if needed.
5142
5143 * process.c (serial_open, serial_configure): Move decls from here ...
5144 * systty.h: ... to here, so that they can be checked.
5145
5146 * fns.c (get_random, seed_random): Move extern decls from here ...
5147 * lisp.h: ... to here, so that they can be checked.
5148
5149 * sysdep.c (reset_io): Now static.
5150 (wait_for_termination_signal): Remove; unused.
5151
5152 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5153 (copy_keymap_item, append_key, push_text_char_description):
5154 Now static.
5155 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5156 (DENSE_TABLE_SIZE): Remove; unused.
5157 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5158 (describe_map_tree):
5159 Rename locals to avoid shadowing.
5160
5161 * keyboard.c: Declare functions static if they are not used elsewhere.
5162 (echo_char, echo_dash, cmd_error, top_level_2):
5163 (poll_for_input, handle_async_input): Now static.
5164 (read_char, kbd_buffer_get_event, make_lispy_position):
5165 (make_lispy_event, make_lispy_movement, apply_modifiers):
5166 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5167 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5168 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5169 (read_key_sequence, read_char): Mark locals as initialized.
5170 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5171
5172 * keyboard.h (make_ctrl_char): New decl.
5173 (mark_kboards): Move decl here ...
5174 * alloc.c (mark_kboards): ... from here.
5175
5176 * lisp.h (force_auto_save_soon): New decl.
5177
5178 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5179 (DEFINE_DUMMY_FUNCTION): New macro.
5180 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5181 Use it.
5182 (main): Add casts to avoid warnings
5183 if GCC considers string literals to be constants.
5184
5185 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5186
5187 * dbusbind.c: Pointer signedness fixes.
5188 (xd_signature, xd_append_arg, xd_initialize):
5189 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5190 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5191 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5192 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5193
5194 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5195 if GCC considers string literals to be constants.
5196 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5197
5198 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5199
5200 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5201 (print_preprocess, print_object): New macro to fix last change.
5202
5203 * print.c (print_preprocess): Don't forget font objects.
5204
5205 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5206
5207 * emacs.c (USAGE3): Doc fixes.
5208
5209 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5210
5211 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5212 structure.
5213
5214 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5215
5216 * lisp.h (VWindow_system, Qfile_name_history):
5217 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5218 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5219 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5220
5221 * w32select.c: Don't #include "keyboard.h".
5222 (run_protected): Add extern declaration for waiting_for_input.
5223
5224 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5225 * w32console.c (detect_input_pending, read_input_pending)
5226 (encode_terminal_code):
5227 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5228 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5229 (w32_system_caret_y, Qfile_name_history):
5230 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5231 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5232 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5233 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5234 * w32proc.c (Qlocal, report_file_error):
5235 * w32term.c (Vwindow_system, updating_frame):
5236 * w32uniscribe.c (initialized, uniscribe_font_driver):
5237 Remove unneeded extern declarations.
5238
5239 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5240
5241 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5242
5243 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5244
5245 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5246 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5247 These macros can no longer be used for assignment.
5248
5249 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5250 Assign struct members directly, instead of using BUF_BEGV etc.
5251 (record_buffer_markers, fetch_buffer_markers): New functions for
5252 recording and fetching special buffer markers.
5253 (set_buffer_internal_1, set_buffer_temp): Use them.
5254
5255 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5256
5257 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5258
5259 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5260 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5261
5262 * xdisp.c (hscroll_window_tree):
5263 (reconsider_clip_changes): Use PT instead of BUF_PT.
5264
5265 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5266
5267 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5268 $(EMACS_ROOT)/lib/intprops.h.
5269
5270 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5271
5272 Fix more problems found by GCC 4.5.2's static checks.
5273
5274 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5275 to unsigned char * to avoid compiler diagnostic.
5276 (xg_free_frame_widgets): Make it clear that a local variable is
5277 needed only if USE_GTK_TOOLTIP.
5278 (gdk_window_get_screen): Make it clear that this macro is needed
5279 only if USE_GTK_TOOLTIP.
5280 (int_gtk_range_get_value): New function, which avoids a diagnostic
5281 from gcc -Wbad-function-cast.
5282 (xg_set_toolkit_scroll_bar_thumb): Use it.
5283 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5284 diagnostic from gcc -Wbad-function-cast.
5285 (get_utf8_string, xg_get_file_with_chooser):
5286 Rename locals to avoid shadowing.
5287 (create_dialog): Move locals to avoid shadowing.
5288
5289 * xgselect.c (xg_select): Remove unused var.
5290
5291 * image.c (four_corners_best): Mark locals as initialized.
5292 (gif_load): Initialize transparent_p to zero (Bug#8238).
5293 Mark another local as initialized.
5294 (my_png_error, my_error_exit): Mark with NO_RETURN.
5295
5296 * image.c (clear_image_cache): Now static.
5297 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5298 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5299 (x_edge_detection): Remove unnecessary cast that
5300 gcc -Wbad-function-cast diagnoses.
5301 (gif_load): Fix pointer signedness.
5302 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5303 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5304
5305 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5306
5307 Improve quality of tests for time stamp overflow.
5308 For example, without this patch (encode-time 0 0 0 1 1
5309 1152921504606846976) returns the obviously-bogus value (-948597
5310 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5311 reports time overflow. See
5312 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5313 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5314 * editfns.c: Include limits.h and intprops.h.
5315 (TIME_T_MIN, TIME_T_MAX): New macros.
5316 (time_overflow): Move earlier, to before first use.
5317 (hi_time, lo_time): New functions, for an accurate test for
5318 out-of-range times.
5319 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5320 (Fget_internal_run_time): Don't assume time_t fits in int.
5321 (make_time): Use list2 instead of Fcons twice.
5322 (Fdecode_time): More accurate test for out-of-range times.
5323 (check_tm_member): New function.
5324 (Fencode_time): Use it, to test for out-of-range times.
5325 (lisp_time_argument): Don't rely on undefined left-shift and
5326 right-shift behavior when checking for time stamp overflow.
5327
5328 * editfns.c (time_overflow): New function, refactoring common code.
5329 (Fformat_time_string, Fdecode_time, Fencode_time):
5330 (Fcurrent_time_string): Use it.
5331
5332 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5333 * dired.c (make_time): Move to ...
5334 * editfns.c (make_time): ... here.
5335 * systime.h: Note the move.
5336
5337 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5338
5339 * fringe.c (update_window_fringes): Remove unused variables.
5340
5341 * unexmacosx.c (copy_data_segment): Also copy __got section.
5342 (Bug#8223)
5343
5344 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5345
5346 * termcap.c [MSDOS]: Include "msdos.h".
5347 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5348 Constify `char *' arguments and their references according to
5349 prototypes in tparam.h.
5350
5351 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5352
5353 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5354 Adapt all references accordingly.
5355
5356 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5357
5358 2011-03-11 Tom Tromey <tromey@redhat.com>
5359
5360 * buffer.c (syms_of_buffer): Remove obsolete comment.
5361
5362 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5363
5364 * termhooks.h (encode_terminal_code): Declare prototype.
5365
5366 * msdos.c (encode_terminal_code): Don't declare prototype.
5367
5368 * term.c (encode_terminal_code): Now external again, used by
5369 w32console.c and msdos.c.
5370
5371 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5372 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5373
5374 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5375
5376 Fix some minor problems found by GCC 4.5.2's static checks.
5377
5378 * fringe.c (update_window_fringes): Mark locals as initialized
5379 (Bug#8227).
5380 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5381
5382 * alloc.c (mark_fringe_data): Move decl from here ...
5383 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5384 to check its interface.
5385 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5386
5387 * fontset.c (free_realized_fontset): Now static.
5388 (Fset_fontset_font): Rename local to avoid shadowing.
5389 (fontset_font): Mark local as initialized.
5390 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5391
5392 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5393
5394 * xselect.c (x_disown_buffer_selections): Remove; not used.
5395 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5396 (x_own_selection, Fx_disown_selection_internal): Rename locals
5397 to avoid shadowing.
5398 (x_handle_dnd_message): Remove local to avoid shadowing.
5399
5400 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5401 so that the caller can use some name other than gcpro1.
5402 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5403 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5404 (Fx_backspace_delete_keys_p):
5405 Use them to avoid shadowing, and rename vars to avoid shadowing.
5406 (x_decode_color, x_set_name, x_window): Now static.
5407 (Fx_create_frame): Add braces to silence GCC warning.
5408 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5409 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5410 Remove unused locals.
5411 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5412 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5413 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5414 macros.
5415
5416 * xterm.h (x_mouse_leave): New decl.
5417
5418 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5419 Remove unused functions.
5420 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5421 (x_calc_absolute_position): Now static.
5422 (XTread_socket): Don't define label "out" unless it's used.
5423 Don't declare local "event" unless it's used.
5424 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5425 unless they are used.
5426 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5427 (x_fatal_error_signal): Remove; not used.
5428 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5429 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5430 (x_error_catcher, x_connection_closed, x_error_handler):
5431 (x_error_quitter, xembed_send_message, x_iconify_frame):
5432 (my_log_handler): Rename locals to avoid shadowing.
5433 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5434 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5435
5436 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5437 Rename or move locals to avoid shadowing.
5438 (tty_defined_color, merge_face_heights): Now static.
5439 (free_realized_faces_for_fontset): Remove; not used.
5440 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5441 does not deduce is never used uninitialized.
5442 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5443 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5444
5445 * terminal.c (store_terminal_param): Now static.
5446
5447 * xmenu.c (menu_highlight_callback): Now static.
5448 (set_frame_menubar): Remove unused local.
5449 (xmenu_show): Rename parameter to avoid shadowing.
5450 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5451 since they might point to immutable storage.
5452 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5453 since it's unused otherwise.
5454
5455 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5456 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5457 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5458 avoids a gcc -Wuninitialized diagnostic.
5459 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5460 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5461 does not deduce are never used uninitialized.
5462
5463 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5464
5465 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5466 * window.c (window_loop, size_window):
5467 (run_window_configuration_change_hook, enlarge_window): Likewise.
5468
5469 * window.c (display_buffer): Now static.
5470 (size_window): Mark variables that gcc -Wuninitialized
5471 does not deduce are never used uninitialized.
5472 * window.h (check_all_windows): New decl, to forestall
5473 gcc -Wmissing-prototypes diagnostic.
5474 * dispextern.h (bidi_dump_cached_states): Likewise.
5475
5476 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5477 shadowing.
5478 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5479 Include <limits.h>.
5480 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5481 and to avoid gcc -Wuninitialized warning.
5482 (load_charset_map): Mark variables that gcc -Wuninitialized
5483 does not deduce are never used uninitialized.
5484 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5485
5486 * coding.c (coding_set_source, coding_set_destination):
5487 Use "else { /* comment */ }" rather than "else /* comment */;"
5488 for clarity, and to avoid gcc -Wempty-body warning.
5489 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5490 a block, when the outer 'i' will do.
5491 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5492 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5493 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5494 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5495 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5496 Rename locals to avoid shadowing.
5497 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5498 * coding.c (emacs_mule_char, encode_invocation_designation):
5499 Now static, since they're not used elsewhere.
5500 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5501 (decode_coding_object, encode_coding_object, detect_coding_system):
5502 (decode_coding_emacs_mule): Mark variables that gcc
5503 -Wuninitialized does not deduce are never used uninitialized.
5504 (detect_coding_iso_2022): Initialize a local variable that might
5505 be used uninitialized. Leave a FIXME because it's not clear that
5506 this initialization is needed. (Bug#8211)
5507 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5508 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5509 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5510 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5511 Remove unused macros.
5512
5513 * category.c (hash_get_category_set): Remove unused local var.
5514 (copy_category_table): Now static, since it's not used elsewhere.
5515 * character.c (string_count_byte8): Likewise.
5516
5517 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5518 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5519
5520 * chartab.c (copy_sub_char_table): Now static, since it's not used
5521 elsewhere.
5522 (sub_char_table_ref_and_range, char_table_ref_and_range):
5523 Rename locals to avoid shadowing.
5524 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5525
5526 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5527 (BIDI_BOB): Remove unused macro.
5528
5529 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5530 deduce are never used uninitialized.
5531 * term.c (encode_terminal_code): Likewise.
5532
5533 * term.c (encode_terminal_code): Now static. Remove unused local.
5534
5535 * tparam.h: New file.
5536 * term.c, tparam.h: Include it.
5537 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5538 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5539 Move these decls to tparam.h, and make them agree with what
5540 is actually in tparam.c. The previous trick of using incompatible
5541 decls in different modules does not conform to the C standard.
5542 All callers of tparam changed to use tparam's actual API.
5543 * tparam.c (tparam1, tparam, tgoto):
5544 Use const pointers where appropriate.
5545
5546 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5547 * cm.h (struct cm): Likewise.
5548 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5549 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5550 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5551 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5552 (turn_on_face, init_tty): Likewise.
5553 * termchar.h (struct tty_display_info): Likewise.
5554
5555 * term.c (term_mouse_position): Rename local to avoid shadowing.
5556
5557 * alloc.c (mark_ttys): Move decl from here ...
5558 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5559
5560 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5561
5562 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5563
5564 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5565
5566 * search.c (compile_pattern_1): Remove argument regp, unused since
5567 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5568 (compile_pattern): Don't pass it.
5569
5570 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5571
5572 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5573 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5574 for ! HAVE_GTK3.
5575 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5576
5577 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5578
5579 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5580 gdk_window_get_screen, gdk_window_get_geometry,
5581 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5582 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5583 (xg_get_pixbuf_from_pixmap): New function.
5584 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5585 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5586 Call xg_get_pixbuf_from_pixmap instead of
5587 gdk_pixbuf_get_from_drawable.
5588 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5589 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5590 (xg_check_special_colors): Use GtkStyleContext and its functions
5591 for HAVE_GTK3.
5592 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5593 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5594 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5595 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5596 Call gtk_widget_get_preferred_size.
5597 (xg_frame_resized): gdk_window_get_geometry only takes 5
5598 parameters.
5599 (xg_win_to_widget, xg_event_is_for_menubar):
5600 Call gdk_x11_window_lookup_for_display.
5601 (xg_set_widget_bg): New function.
5602 (delete_cb): New function.
5603 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5604 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5605 (xg_set_background_color): Call xg_set_widget_bg.
5606 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5607 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5608 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5609 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5610 if ! HAVE_GTK3.
5611 (update_frame_tool_bar): Call gtk_widget_hide.
5612 (xg_initialize): Use GDK_KEY_g.
5613
5614 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5615 if ! HAVE_GTK3
5616 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5617
5618 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5619 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5620 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5621
5622 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5623
5624 * w32xfns.c (select_palette): Check success of RealizePalette against
5625 GDI_ERROR, not zero.
5626
5627 See ChangeLog.11 for earlier changes.
5628
5629 ;; Local Variables:
5630 ;; coding: utf-8
5631 ;; End:
5632
5633 Copyright (C) 2011 Free Software Foundation, Inc.
5634
5635 This file is part of GNU Emacs.
5636
5637 GNU Emacs is free software: you can redistribute it and/or modify
5638 it under the terms of the GNU General Public License as published by
5639 the Free Software Foundation, either version 3 of the License, or
5640 (at your option) any later version.
5641
5642 GNU Emacs is distributed in the hope that it will be useful,
5643 but WITHOUT ANY WARRANTY; without even the implied warranty of
5644 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5645 GNU General Public License for more details.
5646
5647 You should have received a copy of the GNU General Public License
5648 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.