1 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3 Fix race conditions involving setenv, gmtime, localtime, asctime.
4 Without this fix, interrupts could mess up code that uses these
5 nonreentrant functions, since setting TZ invalidates existing
6 tm_zone or tzname values, and since most of these functions return
7 pointers to static storage.
8 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
9 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
10 Grow the critical sections to include not just invoking
11 localtime/gmtime, but also accessing these functions' results
12 including their tm_zone values if any, and any related TZ setting.
13 (format_time_string): Last arg is now struct tm *, not struct tm **,
14 so that the struct tm is saved in the critical section. All
15 callers changed. Simplify allocation of initial buffer, partly
16 motivated by the fact that memory allocation needs to be outside
19 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
21 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
24 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
25 Remove duplicated buffer name initialization.
27 2012-05-02 Jim Meyering <jim@meyering.net>
29 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
31 * xfns.c (x_window): Use xstrdup (Bug#11375).
33 2012-05-02 Eli Zaretskii <eliz@gnu.org>
35 * xdisp.c (pos_visible_p): If already at a newline from the
36 display string before the 'while' loop, don't walk back the glyphs
37 from it3.glyph_row. Solves assertion violation when the display
38 string begins with a newline (egg.el). (Bug#11367)
40 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
42 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
45 2012-05-01 Glenn Morris <rgm@gnu.org>
47 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
48 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
49 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
50 All were removed before 23.1.
52 * dispnew.c: Remove HAVE_LIBNCURSES test;
53 it is always true on relevant platforms.
55 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
56 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
58 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
60 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
62 * .gdbinit (xpr): Remove checks for no longer existing misc types.
63 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
66 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
68 Do not avoid creating empty evaporating overlays (Bug#9642).
69 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
70 That is, do not delete an evaporating overlay if it becomes
71 empty after its bounds are adjusted to fit within its buffer.
72 This fix caused other problems, and I'm reverting it until we get
73 to the bottom of them.
75 2012-04-27 Chong Yidong <cyd@gnu.org>
77 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
79 2012-04-27 Eli Zaretskii <eliz@gnu.org>
81 * xdisp.c (pos_visible_p): If the window start position is beyond
82 ZV, start the display from buffer beginning. Prevents assertion
83 violation in init_iterator when the minibuffer window is scrolled
86 * window.c (window_scroll_pixel_based): Likewise.
88 2012-04-27 Chong Yidong <cyd@gnu.org>
90 * keymap.c (where_is_internal): Doc fix (Bug#10872).
92 2012-04-27 Glenn Morris <rgm@gnu.org>
94 * fileio.c (Fcopy_file, Fset_file_selinux_context):
95 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
97 2012-04-27 Eli Zaretskii <eliz@gnu.org>
99 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
100 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
102 2012-04-26 Eli Zaretskii <eliz@gnu.org>
104 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
105 display element, check also the underlying string or buffer
106 character. (Bug#11341)
108 * w32menu.c: Include w32heap.h.
109 (add_menu_item): If the call to AppendMenuW (via
110 unicode_append_menu) fails, disable Unicode menus only if we are
111 running on Windows 9X/Me.
113 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
115 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
116 (xgetint): Add missing shift for LSB tags.
118 2012-04-24 Martin Rudalics <rudalics@gmx.at>
120 * keyboard.c (read_char): Don't wipe echo area for select window
121 events: These might get delayed via `mouse-autoselect-window'
124 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
126 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
127 manipulation of :loaded-from data.
129 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
131 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
132 now a cons (bug#11311).
134 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
136 Do not create empty overlays with the evaporate property (Bug#9642).
137 * buffer.c (Fmove_overlay): Delete an evaporating overlay
138 if it becomes empty after its bounds are adjusted to fit within
139 its buffer. Without this fix, in a nonempty buffer (let ((o
140 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
141 yields an empty overlay that has the evaporate property, which is
142 not supposed to happen.
144 Fix minor GTK3 problems found by static checking.
145 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
146 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
147 (struct _EmacsFixedClass, emacs_fixed_get_type):
148 Move decls here from emacsgtkfixed.h, since they needn't be public.
149 (emacs_fixed_get_type): Now static.
150 (emacs_fixed_class_init): Omit unused local.
151 (emacs_fixed_child_type): Remove; unused.
152 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
153 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
154 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
155 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
156 (EMACS_FIXED_GET_CLASS): Remove; unused.
157 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
159 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
160 Problem reported by Juanma Barranquero for Windows -Wunused-function.
162 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
164 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
165 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
166 (__malloc_size_t, __malloc_ptrdiff_t):
167 Remove. All uses removed, replaced by the definiens if needed,
168 since we can assume C89 or better now.
169 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
170 (protect_malloc_state, align, get_contiguous_space)
171 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
172 (malloc_atfork_handler_child, malloc_enable_thread)
173 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
174 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
175 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
176 (special_realloc, _realloc_internal_nolock, _realloc_internal)
177 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
178 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
179 Define using prototypes, not old style.
180 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
181 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
182 (align): Don't assume that signed integer overflow wraps around.
183 Omit unused local var.
184 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
185 (_free_internal_nolock, memalign, mallochook, reallochook):
186 Omit no-longer-needed casts.
187 (valloc): Use getpagesize, not __getpagesize.
188 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
189 (struct hdr): The 'magic' member is now size_t, not unsigned long.
191 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
193 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
195 Move functions from C to Lisp. Make non-blocking method calls
196 the default. Implement further D-Bus standard interfaces.
198 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
199 (QCdbus_request_name_allow_replacement)
200 (QCdbus_request_name_replace_existing)
201 (QCdbus_request_name_do_not_queue)
202 (QCdbus_request_name_reply_primary_owner)
203 (QCdbus_request_name_reply_in_queue)
204 (QCdbus_request_name_reply_exists)
205 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
206 (QCdbus_registered_serial, QCdbus_registered_method)
207 (QCdbus_registered_signal): New Lisp objects.
208 (XD_DEBUG_MESSAGE): Use sizeof.
209 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
210 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
211 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
212 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
213 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
214 (xd_signature, xd_append_arg): Allow float for integer types.
215 (xd_get_connection_references): New function.
216 (xd_get_connection_address): Rename from xd_initialize.
217 Return cached address.
218 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
219 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
221 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
222 Return number of recounts.
223 (Fdbus_get_unique_name): Make stronger parameter check.
224 (Fdbus_message_internal): New defun.
225 (Fdbus_call_method, Fdbus_call_method_asynchronously)
226 (Fdbus_method_return_internal, Fdbus_method_error_internal)
227 (Fdbus_send_signal, Fdbus_register_service)
228 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
229 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
230 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
231 (Vdbus_compiled_version, Vdbus_runtime_version)
232 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
233 (Vdbus_message_type_method_return, Vdbus_message_type_error)
234 (Vdbus_message_type_signal): New defvars.
235 (Vdbus_registered_buses, Vdbus_registered_objects_table):
238 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
240 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
241 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
242 Do not assume ptrdiff_t is the same width as 'int'.
244 * alloc.c: Handle unusual debugging option combinations.
245 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
246 since the two debugging options are incompatible.
247 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
249 (mem_init, mem_insert, mem_insert_fixup):
250 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
251 (NEED_MEM_INSERT): Remove; no longer needed.
253 2012-04-22 Leo Liu <sdl.web@gmail.com>
255 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
257 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
259 * sysdep.c [__FreeBSD__]: Minor cleanups.
260 (list_system_processes, system_process_attributes) [__FreeBSD__]:
261 Use Emacs indenting style more consistently. Avoid some casts.
262 Use 'double' consistently rather than mixing 'float' and 'double'.
264 2012-04-21 Eduard Wiebe <usenet@pusto.de>
266 * sysdep.c (list_system_processes, system_process_attributes):
267 Add implementation for FreeBSD (Bug#5243).
269 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
271 * lisp.mk (lisp): Update.
273 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
275 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
276 It is never used otherwise.
278 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
280 * print.c (print_preprocess): Only check print_depth if print-circle
282 (print_object): Check for cycles even when print-circle is nil and
283 print-gensym is t, but only check print_depth if print-circle is nil.
285 2012-04-20 Chong Yidong <cyd@gnu.org>
287 * process.c (wait_reading_process_output): If EIO occurs on a pty,
288 set the status to "failed" and ensure that sentinel is run.
290 2012-04-20 Glenn Morris <rgm@gnu.org>
292 * process.c (Fset_process_inherit_coding_system_flag)
293 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
294 (Fmake_network_process, Fmake_serial_process): Doc fix.
296 2012-04-20 Eli Zaretskii <eliz@gnu.org>
298 * xdisp.c (string_buffer_position_lim): Limit starting position to
300 (set_cursor_from_row): If called for a mode-line or header-line
301 row, return zero immediately.
302 (try_cursor_movement): If inside continuation line, don't back up
303 farther than the first row after the header line, if any.
304 Don't consider the header-line row as "partially visible", even if
305 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
307 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
309 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
312 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
313 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
315 configure: new option --enable-gcc-warnings (Bug#11207)
316 * Makefile.in (C_WARNINGS_SWITCH): Remove.
317 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
318 (ALL_CFLAGS): Use new macros rather than old.
319 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
320 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
321 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
322 -Wunused-result, -Wunused-variable. This should go away once
323 the Emacs and Gnulib regex code is merged.
324 (xmalloc, xrealloc): Now static.
326 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
328 * dired.c (Fsystem_groups): Remove unused local.
330 2012-04-17 Glenn Morris <rgm@gnu.org>
332 * dired.c (Fsystem_users): Doc fix.
334 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
336 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
337 (syms_of_dired): Add them.
339 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
341 Fix minor alloc.c problems found by static checking.
342 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
343 New extern decls, to avoid calling undeclared functions.
344 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
345 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
346 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
347 (NEED_MEM_INSERT): New macro.
348 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
349 Remove one incorrect comment and fix another.
351 Fix minor ralloc.c problems found by static checking.
352 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
353 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
354 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
355 (r_alloc_sbrk): Now static.
357 Improve ralloc.c interface checking.
358 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
359 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
360 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
361 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
362 [REL_ALLOC]: ... to here, to check interface.
363 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
364 Remove decls. This fixes an "It stinks!".
366 * alloc.c (which_symbols): Fix alignment issue / type clash.
368 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
370 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
371 (struct Lisp_Misc_Any): Likewise.
372 (struct Lisp_Free): Likewise.
373 * alloc.c (union aligned_Lisp_Symbol): Define.
374 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
375 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
376 (union aligned_Lisp_Misc): Define.
377 (MARKER_BLOCK_SIZE, struct marker_block): Use union
378 aligned_Lisp_Misc instead of union Lisp_Misc.
379 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
381 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
383 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
384 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
385 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
386 * s/netbsd.h, s/sol2-6.h:
387 Remove definition of GC_MARK_STACK, since the default now works.
388 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
389 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
390 no longer the default.
391 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
393 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
395 * lread.c (lisp_file_lexically_bound_p):
396 Fix hang at ";-*-\n" (bug#11238).
398 2012-04-14 Eli Zaretskii <eliz@gnu.org>
400 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
401 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
403 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
405 * nsterm.m (constrainFrameRect): Always constrain when there is only
406 one screen (Bug#10962).
408 2012-04-13 Ken Brown <kbrown@cornell.edu>
410 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
412 2012-04-13 Reuben Thomas <rrt@sc3d.org>
414 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
416 2012-04-11 Daniel Colascione <dancol@dancol.org>
418 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
419 against is gone. It's better to use vfork now so that when Cygwin
420 gains a new, working vfork, we use it automatically (bug#10398).
422 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
424 * window.c (save_window_save): Obey window-point-insertion-type.
426 2012-04-11 Glenn Morris <rgm@gnu.org>
428 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
430 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
432 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
434 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
436 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
437 (force_quit_count): New var.
438 (handle_interrupt): Use it.
440 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
442 * w32.c (w32_delayed_load): Record the full path of the library
443 being loaded (bug#10424).
445 2012-04-09 Glenn Morris <rgm@gnu.org>
447 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
448 not just in the obarray, before snarfing them. (Bug#11036)
450 * Makefile.in ($(leimdir)/leim-list.el):
451 Pass EMACS rather than BUILT_EMACS.
453 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
455 * process.c (make_process):
456 * process.h: Add integer `gnutls_handshakes_tried' member to
459 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
460 Add convenience `GNUTLS_LOG2i' macro.
462 * gnutls.c (gnutls_log_function2i): Convenience log function.
463 (emacs_gnutls_read): Use new log functions,
464 `gnutls_handshakes_tried' process member, and
465 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
466 attempts per process (connection).
468 2012-04-09 Chong Yidong <cyd@gnu.org>
470 * eval.c (Fuser_variable_p, user_variable_p_eh)
471 (lisp_indirect_variable): Functions deleted.
472 (Fdefvar): Caller changed.
474 * callint.c (Finteractive, Fcall_interactively):
475 * minibuf.c (Fread_variable): Callers changed.
477 2012-04-09 Eli Zaretskii <eliz@gnu.org>
479 * xdisp.c (set_cursor_from_row): If the display string appears in
480 the buffer at position that is closer to point than the position
481 after the display string, display the cursor on the first glyph of
482 the display string. Fixes cursor display when a 'display' text
483 property immediately follows invisible text. (Bug#11094)
485 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
487 composite.c: use 'double' consistently
488 * composite.c (get_composition_id): Use 'double' consistently
489 instead of converting 'float' to 'double' and vice versa; this is
490 easier to understand and avoids a GCC warning.
492 2012-04-09 Glenn Morris <rgm@gnu.org>
494 * Makefile.in: Generate leim-list with bootstrap-emacs, in
495 preparation for dumping it with emacs. (Bug#4789)
496 (leimdir): New variable.
497 ($(leimdir)/leim-list.el): New rule.
498 (emacs$(EXEEXT)): Depend on leim-list.el.
500 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
501 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
502 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
504 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
506 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
509 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
511 * xml.c (init_libxml2_functions) [WINDOWSNT]:
512 Remove unused local variable.
514 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
516 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
517 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
518 (mark_memory): Mark Lisp_Objects only if pointers might hide in
519 objects, as mark_maybe_pointer will catch them otherwise.
520 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
521 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
523 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
525 Fix typo that broke non-Windows builds.
526 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
528 2012-04-07 Eli Zaretskii <eliz@gnu.org>
530 Support building on MS-Windows with libxml2.
532 * makefile.w32-in (OBJ2): Add xml.$(O).
533 (GLOBAL_SOURCES): Add xml.c.
534 ($(BLD)/xml.$(O)): New dependency list.
536 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
537 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
538 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
539 [!WINDOWSNT]: New macros.
540 (init_libxml2_functions, libxml2_loaded_p): New functions.
541 (parse_region): Call fn_xmlCheckVersion instead of using the macro
542 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
543 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
544 Calls xmlCleanupParser only if libxml2 was loaded (or statically
546 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
547 Call init_libxml2_functions before calling libxml2 functions.
548 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
550 * emacs.c: Don't include libxml/parser.h.
551 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
552 xmlCleanupParser directly.
554 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
556 2012-04-07 Eli Zaretskii <eliz@gnu.org>
558 * indent.c (Fvertical_motion): If there is a display string at
559 point, use it.vpos to compute how many lines to backtrack after
560 move_it_to point. (Bug#11133)
562 2012-04-06 Eli Zaretskii <eliz@gnu.org>
564 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
565 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
566 about subtle differences between FETCH_CHAR* and STRING_CHAR*
567 macros related to unification of CJK characters. For the details,
568 see the discussion following the message here:
569 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
571 2012-04-04 Chong Yidong <cyd@gnu.org>
573 * keyboard.c (Vdelayed_warnings_list): Doc fix.
575 2012-04-01 Eli Zaretskii <eliz@gnu.org>
577 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
578 instead of alloca. (Bug#11138)
580 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
582 * w32menu.c (is_simple_dialog): Properly check lisp types.
585 2012-03-31 Eli Zaretskii <eliz@gnu.org>
587 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
588 position we get to after a call to move_it_to fails the
589 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
590 only if we wind up in a string from display property. (Bug#11063)
592 * window.c (Fdelete_other_windows_internal): Invalidate the row
593 and column information about mouse highlight, so that redisplay
594 restores it after reallocating the glyph matrices. (Bug#7464)
596 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
597 string comes from a `display' text property, use the buffer
598 position of that property as if we actually saw that position in
600 (move_it_by_lines): Remove the assertion that
601 "it->current_x == 0 && it->hpos == 0" which can be legitimately
602 violated when there's a before-string at the beginning of a line.
605 2012-03-30 Eli Zaretskii <eliz@gnu.org>
607 * xdisp.c (append_space_for_newline): If the default face was
608 remapped, use the remapped face for the appended newline.
609 (extend_face_to_end_of_line): Use the remapped default face for
610 extending the face to the end of the line.
611 (display_line): Call extend_face_to_end_of_line when the default
612 face was remapped. (Bug#11068)
614 2012-03-29 Eli Zaretskii <eliz@gnu.org>
616 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
618 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
620 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
622 2012-03-27 Glenn Morris <rgm@gnu.org>
624 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
627 2012-03-26 Kenichi Handa <handa@m17n.org>
629 * dispextern.h (struct glyph): Fix previous change. Change the
630 bit length of glyphless.ch to 25 (Bug#11082).
632 2012-03-26 Chong Yidong <cyd@gnu.org>
634 * keyboard.c (Vselection_inhibit_update_commands): New variable.
635 (command_loop_1): Use it; inhibit selection update for
636 handle-select-window too (Bug#8996).
638 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
640 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
642 2012-03-25 Kenichi Handa <handa@m17n.org>
644 * dispextern.h (struct glyph): Change the bit length of
645 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
647 2012-03-24 Eli Zaretskii <eliz@gnu.org>
649 * s/ms-w32.h (tzname): Include time.h before redirecting to
650 _tzname. Fixes the MSVC build. (Bug#9960)
652 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
654 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
657 * xterm.c (XTread_socket): Only modify handling_signal if
658 !SYNC_INPUT. (Bug#11080)
660 2012-03-23 Eli Zaretskii <eliz@gnu.org>
662 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
663 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
664 when fetching a multibyte character consumes more bytes than
665 CHAR_BYTES returns, due to unification of CJK characters in
666 string_char. (Bug#11073)
668 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
670 * process.c (wait_reading_process_output): Handle pty disconnect
671 by refraining from sending oneself a SIGCHLD (bug#10933).
673 2012-03-22 Chong Yidong <cyd@gnu.org>
675 * dispextern.h (struct it): New member string_from_prefix_prop_p.
677 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
678 Mark string as coming from a prefix property.
679 (handle_face_prop): Use default face for prefix strings (Bug#4281).
680 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
682 2012-03-21 Chong Yidong <cyd@gnu.org>
684 * xfaces.c (Vface_remapping_alist): Doc fix.
686 2012-03-20 Eli Zaretskii <eliz@gnu.org>
688 * w32proc.c (Fw32_set_console_codepage)
689 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
692 2012-03-20 Chong Yidong <cyd@gnu.org>
694 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
695 to reflect default non-nil value of redisplay-dont-pause.
697 2012-03-19 Kenichi Handa <handa@m17n.org>
699 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
700 it fit in a valid range (Bug#11003).
702 2012-03-18 Eli Zaretskii <eliz@gnu.org>
704 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
705 that is not from display property, accept the row as a "cursor
706 row" if one of the string's character has a non-nil `cursor'
707 property. Fixes cursor positioning when there are newlines in
708 overlay strings, e.g. in icomplete.el. (Bug#11035)
710 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
712 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
714 2012-03-12 Chong Yidong <cyd@gnu.org>
716 * eval.c (inhibit_lisp_code): Rename from
717 inhibit_window_configuration_change_hook; move from window.c.
719 * xfns.c (unwind_create_frame_1, Fx_create_frame):
720 * window.c (run_window_configuration_change_hook)
721 (syms_of_window): Callers changed.
723 2012-03-11 Chong Yidong <cyd@gnu.org>
725 * keymap.c (Fkey_description): Doc fix (Bug#9700).
727 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
729 2012-03-10 Chong Yidong <cyd@gnu.org>
731 * frame.c (other_visible_frames): Don't assume the selected frame
732 is visible (Bug#10955).
734 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
736 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
738 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
740 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
741 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
744 2012-03-03 Glenn Morris <rgm@gnu.org>
746 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
748 2012-03-02 Eli Zaretskii <eliz@gnu.org>
750 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
751 position past the first glyph_row that ends at ZV. (Bug#10902)
752 (redisplay_window, next_element_from_string): Fix typos in
754 (redisplay_window): Pass to move_it_vertically the margin in
755 pixels, not in screen lines.
757 2012-03-02 Glenn Morris <rgm@gnu.org>
759 * buffer.c (buffer-list-update-hook): Doc fix.
761 2012-02-29 Eli Zaretskii <eliz@gnu.org>
763 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
764 push_it before setting up the iterator for the first overlay
765 string, even if we have an empty string loaded.
766 (next_overlay_string): If there's an empty string on the iterator
767 stack, pop the stack. (Bug#10903)
769 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
771 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
772 Suggested by Stefan Monnier in
773 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
774 * alloc.c (widen_to_Lisp_Object): New static function.
775 (mark_memory): Also mark Lisp_Objects by fetching pointer words
776 and widening them to Lisp_Objects. This would work even if
777 USE_LSB_TAG is defined and wide integers are used, which might
778 happen in a future version of Emacs.
780 2012-02-25 Chong Yidong <cyd@gnu.org>
782 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
785 * xselect.c (Fx_selection_exists_p): Doc fix.
786 (x_clipboard_manager_save_all): Print an informative message
787 before saving to clipboard manager.
789 2012-02-24 Chong Yidong <cyd@gnu.org>
791 * keyboard.c (process_special_events): Handle all X selection
792 requests in kbd_buffer, not just the next one (Bug#8869).
794 2012-02-23 Chong Yidong <cyd@gnu.org>
796 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
797 call when setting menu-bar-lines and tool-bar-lines parameters.
798 (unwind_create_frame_1): New helper function.
800 * window.c (inhibit_window_configuration_change_hook): New var.
801 (run_window_configuration_change_hook): Obey it.
802 (syms_of_window): Initialize it.
804 2012-02-22 Chong Yidong <cyd@gnu.org>
806 * xterm.c (x_draw_image_relief): Add missing type check for
807 Vtool_bar_button_margin (Bug#10743).
809 2012-02-21 Chong Yidong <cyd@gnu.org>
811 * fileio.c (Vfile_name_handler_alist): Doc fix.
813 * buffer.c (Fget_file_buffer): Protect against invalid file
814 handler return value.
816 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
818 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
819 when computing $valmask.
821 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
822 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
823 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
824 It's useless in that case, and it can cause problems on hosts
825 that allocate halves of EMACS_INT values separately.
826 Reported by Dan Horák. Diagnosed by Andreas Schwab in
827 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
828 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
829 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
830 it avoids undefined behavior on hosts where shifting right by more
831 than the word width has undefined behavior.
833 2012-02-19 Chong Yidong <cyd@gnu.org>
835 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
836 (Funhandled_file_name_directory, Ffile_name_as_directory)
837 (Fdirectory_file_name, Fexpand_file_name)
838 (Fsubstitute_in_file_name): Protect against invalid file handler
839 return values (Bug#10845).
841 2012-02-18 Eli Zaretskii <eliz@gnu.org>
843 * .gdbinit (pitx): Fix incorrect references to fields of the
846 2012-02-17 Chong Yidong <cyd@gnu.org>
848 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
850 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
852 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
853 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
855 2012-02-15 Chong Yidong <cyd@gnu.org>
857 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
858 marked as special. Also, starting docstrings with * is obsolete.
860 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
862 * gnutls.c (emacs_gnutls_write): Fix last change.
864 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
866 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
869 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
871 * keymap.c (Fsingle_key_description): Handle char ranges.
873 2012-02-12 Chong Yidong <cyd@gnu.org>
875 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
876 as that creates a dangerous corner case.
878 * window.c (Fdelete_window_internal): Invalidate the mouse
879 highlight (Bug#9904).
881 2012-02-12 Glenn Morris <rgm@gnu.org>
883 * xselect.c (Fx_own_selection_internal)
884 (Fx_get_selection_internal, Fx_disown_selection_internal)
885 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
886 * nsselect.m (Fx_own_selection_internal)
887 (Fx_disown_selection_internal, Fx_selection_exists_p)
888 (Fx_selection_owner_p, Fx_get_selection_internal):
889 Sync docs and argument specs with the xselect.c versions.
891 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
893 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
895 2012-02-11 Eli Zaretskii <eliz@gnu.org>
897 * w32select.c (Fx_selection_exists_p): Sync doc string and
898 argument list with xselect.c. (Bug#10783)
900 * w16select.c (Fx_selection_exists_p): Sync doc string and
901 argument list with xselect.c. (Bug#10783)
903 2012-02-10 Glenn Morris <rgm@gnu.org>
905 * fns.c (Fsecure_hash): Doc fix.
907 2012-02-09 Kenichi Handa <handa@m17n.org>
909 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
911 2012-02-07 Chong Yidong <cyd@gnu.org>
913 * buffer.c (Fbuffer_local_variables)
914 (buffer_lisp_local_variables): Handle unbound vars correctly;
915 don't let Qunbound leak into Lisp.
917 2012-02-07 Glenn Morris <rgm@gnu.org>
919 * image.c (Fimagemagick_types): Doc fix.
921 * image.c (imagemagick-render-type): Change it from a lisp object
922 to an integer. Move the doc here from the lisp manual.
923 Treat all values not equal to 0 the same.
925 2012-02-06 Chong Yidong <cyd@gnu.org>
927 * doc.c (store_function_docstring): Avoid applying docstring of
928 alias to base function (Bug#2603).
930 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
932 * .gdbinit (pp1, pv1): Remove redundant defines.
935 2012-02-04 Chong Yidong <cyd@gnu.org>
937 * nsterm.m: Declare a global (Bug#10694).
939 2012-02-04 Eli Zaretskii <eliz@gnu.org>
941 * w32.c (get_emacs_configuration_options):
942 Include --enable-checking, if specified, in the return value.
944 2012-02-04 Martin Rudalics <rudalics@gmx.at>
946 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
947 after rounding frame sizes. (Bug#9723)
949 2012-02-04 Eli Zaretskii <eliz@gnu.org>
951 * keyboard.c (adjust_point_for_property): Don't position point
952 before BEGV. (Bug#10696)
954 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
956 Handle overflow when computing char display width (Bug#9496).
957 * character.c (char_width): Return EMACS_INT, not int.
958 (char_width, c_string_width): Check for overflow when
959 computing the width; this is possible now that individual
960 characters can have unbounded width. Problem introduced
961 by merge from Emacs 23 on 2012-01-19.
963 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
965 * dbusbind.c (Fdbus_register_method): Mention the return value
966 :ignore in the docstring.
968 2012-02-02 Glenn Morris <rgm@gnu.org>
970 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
972 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
973 Unconditionally set to t. (Bug#10673)
974 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
975 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
976 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
978 2012-02-02 Kenichi Handa <handa@m17n.org>
980 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
981 0, do not call append_composite_glyph.
983 2012-02-02 Kenichi Handa <handa@m17n.org>
985 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
987 (x_produce_glyphs): If the component of a composition is a null
988 string, set it->pixel_width to 1 to avoid zero-width glyph.
990 2012-02-01 Eli Zaretskii <eliz@gnu.org>
992 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
993 first 2 arguments are identical. This makes inserting large
994 output from a subprocess an order of magnitude faster on
995 MS-Windows, where all sbrk'ed memory is always contiguous.
997 2012-01-31 Glenn Morris <rgm@gnu.org>
999 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1000 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1001 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1003 2012-01-29 Glenn Morris <rgm@gnu.org>
1005 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1007 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1009 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1011 2012-01-28 Chong Yidong <cyd@gnu.org>
1013 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1015 2012-01-26 Chong Yidong <cyd@gnu.org>
1017 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1019 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1020 repeat counts (Bug#10507).
1022 2012-01-26 Glenn Morris <rgm@gnu.org>
1024 * lread.c (syms_of_lread): Doc fix.
1026 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1028 * coding.c (encode_designation_at_bol): Change return value to
1031 2012-01-25 Chong Yidong <cyd@gnu.org>
1033 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1035 2012-01-21 Chong Yidong <cyd@gnu.org>
1037 * floatfns.c (Fcopysign): Make the second argument non-optional,
1038 since nil is not allowed anyway.
1040 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1042 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1043 (send_process): Likewise.
1045 2012-01-19 Martin Rudalics <rudalics@gmx.at>
1047 * window.c (save_window_save, Fcurrent_window_configuration)
1048 (Vwindow_persistent_parameters): Do not use Qstate.
1049 Rewrite doc-strings.
1051 2012-01-19 Kenichi Handa <handa@m17n.org>
1053 * character.c (char_width): New function.
1054 (Fchar_width, c_string_width, lisp_string_width):
1055 Use char_width (Bug#9496).
1057 2012-01-16 Martin Rudalics <rudalics@gmx.at>
1059 * window.c (Vwindow_persistent_parameters): New variable.
1060 (Fset_window_configuration, save_window_save): Handle persistent
1063 2012-01-14 Eli Zaretskii <eliz@gnu.org>
1065 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1066 thrashing the stack of the thread. (Bug#9087)
1068 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1070 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1072 2012-01-11 Eli Zaretskii <eliz@gnu.org>
1074 * xdisp.c (rows_from_pos_range): Handle the case where the
1075 highlight ends on a newline. (Bug#10464)
1076 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1077 he end column for display of highlight that ends on a newline
1080 2012-01-11 Glenn Morris <rgm@gnu.org>
1082 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1083 from load-path also when installation-directory is nil. (Bug#10208)
1085 2012-01-10 Glenn Morris <rgm@gnu.org>
1087 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1089 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1090 Update template values to be closer to their typical values these days.
1092 2012-01-09 Eli Zaretskii <eliz@gnu.org>
1094 * xdisp.c (rows_from_pos_range): Accept additional argument
1095 DISP_STRING, and accept any glyph in a row whose object is that
1096 string as eligible for mouse highlight. Fixes mouse highlight of
1097 display strings from overlays. (Bug#10464)
1099 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
1101 emacs: fix an auto-save permissions race condition (Bug#10400)
1102 * fileio.c (auto_saving_dir_umask): New static var.
1103 (Fmake_directory_internal): Use it.
1104 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1105 creating the directory. The old code temporarily assigns
1106 too-generous permissions to the directory.
1107 (do_auto_save_eh): Clear it.
1108 (Fdo_auto_save): Catch all errors, not just file errors, so
1109 that the var is always cleared.
1111 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1113 * search.c (scan_buffer): Pass character positions to
1114 know_region_cache, not byte positions. (Bug#6540)
1116 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1118 * w32.c (sys_rename): Report EXDEV when rename of a directory
1119 fails because the target is on another logical disk. (Bug#10284)
1121 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1123 * xterm.c (x_embed_request_focus): New function.
1125 * xterm.h: Add prototype.
1127 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1129 2012-01-05 Glenn Morris <rgm@gnu.org>
1131 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1133 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1135 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1136 Load gnutls_transport_set_lowat only if GnuTLS version is below
1138 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1139 GnuTLS versions below 2.11.1.
1141 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1143 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1144 to the doc string advising against its use for altering the way
1145 windows are scrolled.
1147 2011-12-28 Kenichi Handa <handa@m17n.org>
1149 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1150 coding-system ASCII compatible only when it does not produce BOM
1151 on encoding (Bug#10383).
1153 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1155 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1157 (create_and_show_popup_menu): Always use menu_position_func for
1160 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1162 * callint.c (Fcall_interactively): Don't truncate prompt string.
1164 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1166 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1167 property that ends at ZV, so that the bidi iteration could be
1168 resumed from there (after widening). (Bug#10360)
1170 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1172 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1174 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1176 * nsterm.m (x_free_frame_resources):
1177 Release f->output_data.ns->miniimage.
1178 (ns_index_color): Fix indentation. Do not retain
1179 color_table->colors[i].
1181 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1184 * nsfns.m (x_set_background_color): Assign return value from
1185 ns_index_color to face-background instead of NSColor*.
1186 (ns_implicitly_set_icon_type): Fix indentation.
1187 Change assignment in for loop to comparison.
1189 * emacs.c (ns_pool): New variable.
1190 (main): Assign ns_pool.
1191 (Fkill_emacs): Call ns_release_autorelease_pool.
1193 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1194 autorelease fdesc, release fdAttrs and tdict.
1195 (ns_get_covering_families): Release charset.
1196 (ns_findfonts): Release NSFontDescriptor created with new.
1197 (ns_uni_to_glyphs): Fix indentation.
1198 (setString): Release attrStr before assigning new value.
1200 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1202 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1204 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1205 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1207 2011-12-18 David Reitter <reitter@cmu.edu>
1209 * nsterm.m (ns_term_init): Subscribe for notifications
1210 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1211 to method trackingNotification in EmacsMenu.
1213 * nsmenu.m (trackingMenu): New variable.
1214 (trackingNotification): New method (from Aquamacs).
1215 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1216 from Aquamacs (Bug#7030).
1218 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1220 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1221 (symbol_to_nsstring): Fix indentation.
1222 (ns_symbol_to_pb): New function.
1223 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1224 (Fns_rotate_cut_buffers_internal): Remove.
1225 (Fns_store_selection_internal): Rename from
1226 Fns_store_cut_buffer_internal.
1227 (ns_get_foreign_selection, Fx_own_selection_internal)
1228 (Fx_disown_selection_internal, Fx_selection_exists_p)
1229 (Fns_get_selection_internal, Fns_store_selection_internal):
1230 Use ns_symbol_to_pb and check if return value is nil.
1231 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1232 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1233 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1234 renamed to Sns_store_selection_internal.
1235 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1236 and remove this function.
1237 (ns_handle_selection_clear): Remove, never used.
1238 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1241 2011-12-17 Ken Brown <kbrown@cornell.edu>
1243 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1244 GID is unknown (Bug#10257).
1246 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1248 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1249 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1250 which caused a build failure on GNU/Linux IA-64. This problem was
1251 introduced by my 2011-10-07 patch.
1253 2011-12-15 Juri Linkov <juri@jurta.org>
1255 * image.c (imagemagick_error): New function. (Bug#10112)
1256 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1257 Use `imagemagick_error' where ImageMagick functions return
1259 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1262 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1264 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1265 fill background (Bug#8992).
1267 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1269 * window.c (Vwindow_combination_resize)
1270 (Vwindow_combination_limit): Use t instead of non-nil in
1272 (Vrecenter_redisplay): Add first sentence of doc-string on
1274 (Frecenter): Fix doc-string typo.
1276 2011-12-11 Kenichi Handa <handa@m17n.org>
1278 * coding.c (Funencodable_char_position): Pay attention to the
1279 buffer text relocation (Bug#9389).
1281 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1283 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1284 gtk_init (Bug#10100).
1286 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1288 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1289 IT->string is nil. (Bug#10263)
1291 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1293 * nsterm.h (x_free_frame_resources): Declare.
1295 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1296 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1298 * nsterm.h (ns_get_defaults_value): Declare.
1300 * nsterm.m (ns_default): Call ns_get_defaults_value.
1302 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1304 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1307 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1309 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1310 that where the value of an _OBJC_* symbol points to is in the .bss
1311 section (Bug#10240).
1313 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1315 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1316 after the loop to call ccl_driver at least once (Bug#8619).
1318 2011-12-08 Kenichi Handa <handa@m17n.org>
1320 * ftfont.c (get_adstyle_property): Fix previous change
1323 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1325 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1326 dirs from the default value of EMACSLOADPATH (bug#10208).
1328 2011-12-07 Glenn Morris <rgm@gnu.org>
1330 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1331 installation and source directories as well. (Bug#10208)
1333 2011-12-06 Chong Yidong <cyd@gnu.org>
1335 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1337 2011-12-06 Glenn Morris <rgm@gnu.org>
1339 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1340 as an error, not just -1. (Bug#10217)
1342 2011-12-05 Chong Yidong <cyd@gnu.org>
1344 * keyboard.c (process_special_events): New function.
1345 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1347 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1349 * coding.c (encode_designation_at_bol): Don't use uninitialized
1350 local variable (Bug#9318).
1352 2011-12-05 Kenichi Handa <handa@m17n.org>
1354 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1355 return Qnil (Bug#8046, Bug#10193).
1357 2011-12-05 Kenichi Handa <handa@m17n.org>
1359 * coding.c (encode_designation_at_bol): New args charbuf_end and
1360 dst. Return the number of produced bytes. Callers changed.
1361 (coding_set_source): Return how many bytes coding->source was
1363 (coding_set_destination): Return how many bytes
1364 coding->destination was relocated.
1365 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1366 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1368 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1370 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1371 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1374 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1376 The following changes are to fix Bug#9318.
1378 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1379 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1380 (encode_coding_iso_2022, encode_coding_sjis)
1381 (encode_coding_big5, encode_coding_charset): Use the above macros.
1383 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1385 * lisp.h (process_quit_flag): Fix external declaration.
1387 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1389 Don't macro-inline non-performance-critical code.
1390 * eval.c (process_quit_flag): New function.
1391 * lisp.h (QUIT): Use it.
1393 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1395 * nsfns.m (get_geometry_from_preferences): New function.
1396 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1398 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1400 * emacs.c (Qkill_emacs): Define.
1401 (syms_of_emacs): Initialize it.
1402 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1403 Qquit_flag to `kill-emacs' instead.
1404 (quit_throw_to_read_char): Add parameter `from_signal'.
1405 All callers changed. Call Fkill_emacs if requested and safe.
1406 * lisp.h (QUIT): Call Fkill_emacs if requested.
1408 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1410 * widget.c (update_wm_hints): Return if wmshell is null.
1411 (widget_update_wm_size_hints): New function.
1413 * widget.h (widget_update_wm_size_hints): Declare.
1415 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1416 widget_update_wm_size_hints (Bug#10104).
1418 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1420 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1421 before a newline, prepare the bidi iterator for consuming the
1422 newline, and keep the current paragraph direction. (Bug#10183)
1423 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1425 2011-12-02 Juri Linkov <juri@jurta.org>
1427 * search.c (Fword_search_regexp): New Lisp function created from
1428 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1429 (Fword_search_backward, Fword_search_forward)
1430 (Fword_search_backward_lax, Fword_search_forward_lax):
1431 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1432 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1434 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1436 * fileio.c (Finsert_file_contents): Move after-change-function call
1437 to before the "handled:" label, since all "goto handled" appear in
1438 cases where the *-change-functions have already been properly called
1441 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1443 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1444 waiting for input. (Bug#10169)
1446 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1448 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1449 verifies glyph row's hash code--we have just reallocated the
1450 glyphs, so their contents can be complete garbage. (Bug#10164)
1452 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1454 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1456 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1458 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1459 attributes are tested _before_ calling verify_row_hash, to protect
1460 against GCC re-ordering of the tests. (Bug#10164)
1462 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1464 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1466 * xterm.c (handle_one_xevent): Only set async_visible and friends
1467 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1468 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1469 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1471 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1473 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1474 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1475 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1476 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1477 All uses changed to use GCPRO1 etc.
1478 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1479 Revert to old implementation (i.e., before 2011-03-11).
1481 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1483 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1484 of scroll runs so as to avoid assigning disabled bogus rows and
1485 unnecessary graphics copy operations.
1487 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1489 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1490 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1491 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1492 (malloc, free, realloc, calloc): Redirect to e_* only when
1495 * lisp.h (GCTYPEBITS): Move before first use.
1496 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1497 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1498 this macro definition.
1500 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1503 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1505 * gtkutil.c (xg_create_frame_widgets):
1506 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1507 present with Gtk+ 2.0.
1509 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1511 * fileio.c (Finsert_file_contents): Undo previous change; see
1512 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1514 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1516 Rename locals to avoid shadowing.
1517 * fileio.c (Finsert_file_contents):
1518 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1519 * process.c (wait_reading_process_output):
1520 Rename inner 'proc' to 'p' to avoid shadowing.
1521 Indent for consistency with usual Emacs style.
1523 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1525 * xdisp.c (redisplay_window): If cursor row is not fully visible
1526 after recentering, and scroll-conservatively is set to a large
1527 number, scroll window by a few more lines to make the cursor fully
1528 visible and out of scroll-margin. (Bug#10105)
1529 (start_display): Don't move to the next line if the display should
1530 start at a newline that is part of a display vector or an overlay
1533 2011-11-24 Juri Linkov <juri@jurta.org>
1535 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1536 after the `MagickPingImage' call. (Bug#10112)
1538 2011-11-23 Chong Yidong <cyd@gnu.org>
1540 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1542 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1544 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1545 making another buffer current. (Bug#10114)
1547 2011-11-23 Glenn Morris <rgm@gnu.org>
1549 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1551 2011-11-23 Chong Yidong <cyd@gnu.org>
1553 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1554 using it (Bug#5984).
1556 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1558 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1559 and header-lines, as they don't have one computed for them.
1562 * .gdbinit (prow): Make displayed values more self-explaining.
1563 Add row's hash code.
1565 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1567 * process.c (wait_reading_process_output): Fix asynchrounous
1568 GnuTLS socket handling on some versions of the GnuTLS library.
1569 (wait_reading_process_output): Add comment and URL.
1571 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1573 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1575 2011-11-21 Chong Yidong <cyd@gnu.org>
1577 * window.c (Fnext_window, Fprevious_window): Doc fix.
1579 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1581 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1583 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1585 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1587 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1589 * window.c (Fset_window_combination_limit): Rename argument
1591 (Vwindow_combination_limit): Remove "status" from doc-string.
1593 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1595 * m/ibms390.h: Remove.
1596 * m/ibms390x.h: Don't include "ibms390.h".
1598 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1600 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1601 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1603 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1605 * casetab.c (Fset_case_table):
1606 * charset.c (Fcharset_after): Fix typos.
1608 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1610 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1611 Otherwise, valgrind does not work on some platforms.
1612 Problem reported by Andreas Schwab in
1613 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1614 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1615 is set, removing the need for VIRT_ADDRESS_VARIES.
1616 (PURE_P): Use a more-efficient implementation that needs just one
1617 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1618 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1619 to 4 (xorl, subq, cmpq, setbe).
1620 * alloc.c (pure): Always extern now, since that's the
1621 VIRT_ADDR_VARIES behavior.
1622 (PURE_POINTER_P): Use a single comparison, not two, for
1623 consistency with the new puresize.h.
1624 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1625 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1626 Remove VIRT_ADDR_VARIES no longer needed.
1628 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1630 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1631 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1632 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1633 behave as if the cursor position were at the window margin.
1635 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1636 and the cursor position is out of bounds, behave as if the cursor
1637 position were at the window margin. (Bug#10075)
1639 2011-11-18 Chong Yidong <cyd@gnu.org>
1641 * window.c (Fwindow_combination_limit): Make first argument
1642 non-optional, since it is meaningless for live windows like the
1645 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1647 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1649 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1651 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1652 (graft_intervals_into_buffer): Simplify.
1654 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1656 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1657 hash values of the two rows.
1658 (copy_row_except_pointers): Preserve the used[] arrays and the
1659 hash values of the two rows. (Bug#10035)
1660 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1662 * xdisp.c (row_hash): New function, body extracted from
1663 compute_line_metrics.
1664 (compute_line_metrics): Call row_hash, instead of computing the
1667 * dispnew.c (verify_row_hash): Call row_hash for computing the
1668 hash code of a row, instead of duplicating code from xdisp.c.
1670 * dispextern.h (row_hash): Add prototype.
1672 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1674 * frame.c (delete_frame): Don't delete the terminal when the last
1675 X frame is closed if emacs is built with GTK toolkit.
1677 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1679 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1681 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1683 * window.c (Vwindow_splits): Rename to
1684 Vwindow_combination_resize. Suggested by Juri Linkov.
1685 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1688 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1690 * nsfns.m (Fns_font_name):
1691 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1693 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1695 * window.h (window): Rename slot "nest" to "combination_limit".
1696 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1697 (Fset_window_nest): Rename to Fset_window_combination_limit.
1698 (Vwindow_nest): Rename to Vwindow_combination_limit.
1699 (recombine_windows, make_parent_window, make_window)
1700 (Fsplit_window_internal, saved_window)
1701 (Fset_window_configuration, save_window_save): Rename all
1702 occurrences of window_nest to window_combination_limit.
1704 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1706 * image.c (imagemagick_load_image): Fix typo.
1708 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1710 * xdisp.c (display_line): Move the call to
1711 highlight_trailing_whitespace before the call to
1712 compute_line_metrics, since the latter needs to see the final
1713 faces of all the glyphs to compute ROW's hash value.
1714 Fixes assertion violations in row_equal_p. (Bug#10035)
1716 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1718 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1719 just return (bug#10044).
1721 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1723 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1724 with user-defined heap size. Bump the default size of the temacs
1725 heap to 27MB, to avoid memory warning when running temacs.
1726 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1728 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1729 current_matrix and desired_matrix. (Bug#9990)
1730 (verify_row_hash) [XASSERTS]: New function.
1731 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1732 that the hash value of glyph rows is correct.
1734 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1736 * window.h (window): Remove splits slot.
1737 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1738 (Fdelete_other_windows_internal, make_parent_window)
1739 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1740 (Fset_window_configuration, save_window_save): Don't deal with
1741 split status of windows.
1742 (saved_window): Remove splits slot.
1743 (Vwindow_splits): Rewrite doc-string.
1745 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1747 * xfns.c (unwind_create_frame):
1748 * nsfns.m (unwind_create_frame):
1749 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1750 Vframe_list (Bug#9999).
1752 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1754 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1756 2011-11-11 Kenichi Handa <handa@m17n.org>
1758 * callproc.c (Fcall_process): Set the member dst_multibyte of
1761 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1763 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1764 avoid a crash (bug#9496).
1766 2011-11-09 Chong Yidong <cyd@gnu.org>
1768 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1769 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1771 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1773 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1775 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1777 Avoid some portability problems by eschewing 'extern inline' functions.
1778 The trivial performance wins aren't worth the portability hassles; see
1779 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1781 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1782 (window_box_width, window_box_left, window_box_left_offset)
1783 (window_box_right, window_box_right_offset): Undo previous change,
1784 by removing the "extern"s.
1785 * intervals.c (adjust_intervals_for_insertion)
1786 (adjust_intervals_for_deletion): Undo previous change,
1787 making these static again.
1788 (offset_intervals, temp_set_point_both, temp_set_point)
1789 (copy_intervals_to_string): No longer inline.
1790 * xdisp.c (window_text_bottom_y, window_box_width)
1791 (window_box_height, window_box_left_offset)
1792 (window_box_right_offset, window_box_left, window_box_right)
1793 (window_box): No longer inline.
1795 2011-11-08 Chong Yidong <cyd@gnu.org>
1797 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1798 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1799 Signal an error if not a live window.
1800 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1801 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1803 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1805 * lisp.h (syms_of_abbrev): Remove declaration.
1806 Reported by CHENG Gao <chenggao@royau.me>.
1808 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1810 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1811 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1812 of temacs in GUI mode.
1814 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1816 * window.h: Declare delete_all_child_windows instead of
1817 delete_all_subwindows.
1818 * window.c (Fwindow_nest, Fset_window_nest)
1819 (Fset_window_new_total, Fset_window_new_normal)
1820 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1821 (delete_all_subwindows): Rename to delete_all_child_windows.
1822 (Fdelete_other_windows_internal, Fset_window_configuration):
1823 Call delete_all_child_windows instead of delete_all_subwindows.
1824 * frame.c (delete_frame): Call delete_all_child_windows instead
1825 of delete_all_subwindows.
1827 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1829 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1830 This is also needed for porting to any host where GC_MARK_STACK is
1831 not GC_MAKE_GCPROS_NOOPS.
1832 (which_symbols): Use it.
1834 2011-11-07 Kenichi Handa <handa@m17n.org>
1836 * coding.c (coding_set_destination): Check coding->src_pos only
1837 when coding->src_object is a buffer (bug#9910).
1839 * process.c (send_process): Set the member src_multibyte of coding
1840 to 0 (bug#9911) when sending a unibyte text.
1842 * callproc.c (Fcall_process): Set the member src_multibyte of
1843 process_coding to 0 (bug#9912).
1845 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1847 * xmenu.c (cleanup_widget_value_tree): New function.
1848 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1849 calling free_menubar_widget_value_tree directly (Bug#9830).
1851 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1853 Fix some portability problems with 'inline'.
1854 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1855 (window_box_width, window_box_left, window_box_left_offset)
1856 (window_box_right, window_box_right_offset): Declare extern.
1857 Otherwise, these inline functions do not conform to C99 and
1858 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1859 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1860 * intervals.c (adjust_intervals_for_insertion)
1861 (adjust_intervals_for_deletion): Now extern, because otherwise the
1862 extern inline functions 'offset_intervals' couldn't refer to it.
1863 (static_offset_intervals): Remove.
1864 (offset_intervals): Rewrite using the old contents of
1865 static_offset_intervals. The old version didn't conform to C99
1866 because an extern inline function contained a reference to an
1867 identifier with static linkage.
1869 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1871 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1874 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1876 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1877 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1878 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1879 return Qleft_to_right.
1881 2011-11-06 Chong Yidong <cyd@gnu.org>
1883 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1884 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1885 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1886 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1887 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1888 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1889 (Fwindow_vscroll): Doc fix.
1890 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1891 argument, since it makes no sense to pass a live window and for
1892 consistency with window-child.
1894 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1896 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1899 2011-11-05 Jason Rumney <jasonr@gnu.org>
1901 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1902 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1904 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1905 bitwise arithmetic preventing use of unicode-sip and non-truetype
1908 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1910 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1913 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1914 initialization code to keep similarity to xfns.c after changes
1917 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1919 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1920 (unwind_create_frame): New function (Bug#9943).
1921 (Fx_create_frame): Restructure code to be more similar to the one in
1922 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1923 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1924 Move terminal->reference_count++ just before making the frame official
1927 * nsterm.m (x_free_frame_resources): New function.
1928 (x_destroy_window): Move code to x_free_frame_resources.
1930 * xfns.c (unwind_create_frame): Fix comment.
1931 (Fx_create_frame, x_create_tip_frame):
1932 Move terminal->reference_count++ just before making the frame
1933 official. Move initialization of image_cache_refcount and
1934 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1936 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1938 Support MSVC build with newer versions of Visual Studio.
1939 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1940 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1943 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1944 which are not supported by MSVC.
1945 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1946 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1948 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1950 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1952 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1954 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1956 Support MSVC build with newer versions of Visual Studio.
1957 * w32.c: Don't include w32api.h for MSVC.
1958 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1960 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1961 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1962 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1963 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1965 (alloca) [_MSC_VER]: Define to _alloca.
1967 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1969 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1971 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1973 * xdisp.c (note_mouse_highlight): If either of
1974 previous/next-single-property-change returns nil, treat that as
1975 the beginning or the end of the buffer. (Bug#9955)
1977 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1979 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1980 label is not null (Bug#9951).
1981 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1984 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1986 * window.c (Fwindow_body_size): Mention in the doc string that the
1987 return value is in frame's canonical units. (Bug#9949)
1989 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1991 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1993 * w32fns.c (unwind_create_frame): If needed, free the glyph
1994 matrices of the partially constructed frame. (Bug#9943)
1995 * xfns.c (unwind_create_frame): Likewise.
1997 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1999 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2000 Don't stop backward scan on the continuation glyph, even though
2001 its CHARPOS is positive.
2002 (mouse_face_from_buffer_pos, note_mouse_highlight):
2003 Rename cover_string to disp_string.
2005 2011-11-01 Martin Rudalics <rudalics@gmx.at>
2007 * window.c (temp_output_buffer_show): Don't use
2008 Vtemp_buffer_show_specifiers.
2009 (Vtemp_buffer_show_specifiers): Remove unused variable.
2011 2011-10-30 Eli Zaretskii <eliz@gnu.org>
2013 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2014 past the beginning of the current glyph matrix.
2016 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
2018 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2019 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2020 HAVE_GTK3 (Bug#9869).
2022 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2023 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2025 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2027 * xterm.c: Declare x_handle_net_wm_state to return int.
2028 (handle_one_xevent): Check if we are iconified but don't have
2029 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2030 (get_current_wm_state): Return non-zero if not hidden,
2031 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2032 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2033 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2034 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2036 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2038 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2039 so that this new function doesn't get optimized away by a
2040 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2042 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2044 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2046 2011-10-29 Eli Zaretskii <eliz@gnu.org>
2048 Fix the `xbytecode' command.
2049 * .gdbinit (xprintbytestr): New command.
2050 (xwhichsymbols): Rename from `which'; all callers changed.
2051 (xbytecode): Print the byte-code string as well.
2053 2011-10-29 Kim Storm <storm@cua.dk>
2055 * alloc.c (which_symbols): New function.
2057 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2059 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2062 2011-10-29 Glenn Morris <rgm@gnu.org>
2064 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2065 Not clear what it was for, and it causes various bugs. (Bug#9839)
2067 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2069 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2070 possible random value that matches one of those tested as
2071 condition to clear the mouse face.
2073 2011-10-28 Chong Yidong <cyd@gnu.org>
2075 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2077 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2079 * window.c (make_window): Initialize phys_cursor_on_p.
2081 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2083 * lisp.h (struct Lisp_Symbol): Update comments.
2085 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
2087 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2089 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2091 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2092 <oslsachem@gmail.com> for helping to debug this.
2094 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2095 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2096 (g_b_init_get_glyph_outline_w): New static variables.
2097 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2098 (GetGlyphOutlineW_Proc): New typedefs.
2099 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
2100 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2102 (w32font_open_internal, compute_metrics):
2103 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2104 instead of calling the "wide" APIs directly.
2106 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2108 * w32.h (syms_of_w32font): Add prototype.
2110 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2112 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2113 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2114 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2115 (Fmove_to_window_line): Doc fix.
2117 2011-10-27 Chong Yidong <cyd@gnu.org>
2119 * process.c (make_process): Set gnutls_state to NULL.
2121 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2122 non-NULL, regardless of GNUTLS_INITSTAGE.
2123 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2124 an error. Set process slots as soon as we allocate them.
2126 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2128 2011-10-27 Chong Yidong <cyd@gnu.org>
2130 * gnutls.c (emacs_gnutls_deinit): New function.
2131 Deallocate credentials structures as well as calling gnutls_deinit.
2132 (Fgnutls_deinit, Fgnutls_boot): Use it.
2134 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2135 (deactivate_process): Call emacs_gnutls_deinit.
2137 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2139 * image.c (x_create_x_image_and_pixmap):
2140 * w32.c (sys_rename, w32_delayed_load):
2141 * w32font.c (fill_in_logfont):
2142 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2144 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2146 * w32fns.c (w32_default_color_map): New function,
2147 extracted from Fw32_default_color_map.
2148 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2150 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2152 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2154 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2156 * keyboard.c (test_undefined): New function (bug#9751).
2157 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2159 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2161 * sysdep.c (init_sys_modes): Fix the check for the controlling
2162 terminal (Bug#6649).
2164 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2166 * dispextern.h (struct bidi_it): New member next_en_type.
2168 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2169 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2170 current character, check also for next_en_type being WEAK_EN.
2171 (bidi_resolve_weak): Don't enter the expensive loop if the current
2172 position is before next_en_pos. Record the bidi type of the first
2173 non-ET, non-BN character we find, in addition to its position.
2174 (bidi_level_of_next_char): Invalidate next_en_type when
2175 next_en_pos is over-stepped.
2177 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2179 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2180 * editfns.c: Rewrite current-time-zone so that it invokes
2181 the equivalent of (format-time-string "%Z") to get the time zone name.
2182 This fixes a bug when the time zone name contains characters that
2183 need converting from the system time locale to Emacs internal format.
2184 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2185 that patch fixed format-time-string to do the conversion, but
2186 I forgot to fix current-time-zone.
2187 (format_time_string): New function, containing most of
2188 what Fformat_time_string used to contain.
2189 (Fformat_time_string): Rewrite in terms of format_time_string.
2190 This doesn't change this function's behavior.
2191 (current-time-zone): Rewrite to use format_time_string.
2192 This fixes the bug reported by Michael Schierl in
2193 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2194 Jason Rumney's 2007-06-07 change worked around this bug, but
2196 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2198 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2200 * xdisp.c (start_display): If the character at POS is displayed
2201 via a display vector, reset IT->current.dpvec_index to zero.
2202 (try_window_reusing_current_matrix): If a line ends in a display
2203 vector or the next line starts in a display vector, continue
2204 redrawing the window even though the character position of
2205 start_row was reached.
2208 2011-10-18 Chong Yidong <cyd@gnu.org>
2210 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2211 with nobreak-char-display too.
2213 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2215 Fix part 3 of bug#9771.
2216 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2217 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2218 non-neutral characters if the current character is a paragraph
2219 separator (a.k.a. Newline). This avoids running the same
2220 expensive loop twice, once when we consume the preceding newline
2221 and the other time when the line actually needs to be displayed.
2222 Avoid the loop when we see neutrals on the base embedding level
2223 following a character whose directionality is the same as the
2224 paragraph's. This avoids running the expensive loop when a line
2225 ends in a long sequence of neutrals, like control characters.
2226 Add assertion against STRONG_AL type. Slightly rearrange code
2227 that determines the type of a neutral given the first non-neutral
2229 (bidi_level_of_next_char): Set next_en_pos to zero when
2230 invalidating its info.
2232 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2234 * xdisp.c (push_display_prop): Determine whether to record string
2235 or buffer position by IT->string, not by IT->method. Allow
2236 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2237 (move_it_vertically_backward): Don't look for character position
2238 immediately after the newline when in a continuation line.
2241 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2243 * window.c (coordinates_in_window): Rewrite and delabelize
2244 vertical border check. (Bug#5357) (Bug#9618)
2246 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2248 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2249 errors in XSetWindowBorder (bug#9310).
2251 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2253 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2254 avoid crash when xmalloc overrun checking is enabled.
2256 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2258 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2259 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2260 cursor motion with <left> and <right> arrow keys.
2262 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2263 some callers set that themselves.
2265 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2267 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2268 display string and the previous row comes from the same string and
2269 is empty. (Bug#9739) (Bug#9738)
2271 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2273 * doc.c (get_doc_string): Encode file name (bug#9735).
2275 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2277 * bidi.c (bidi_level_of_next_char):
2278 * xdisp.c (get_visually_first_element): Remove old incorrect
2279 comments regarding the Unicode Line Separator character.
2281 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2283 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2285 * alloc.c (Fgc_status): Do not access beyond zombies array
2286 boundary if nzombies > MAX_ZOMBIES.
2287 * alloc.c (dump_zombies): Add missing format specifier.
2289 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2291 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2292 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2294 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2295 Some packages use them to denote characters with modifiers.
2297 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2299 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2300 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2301 matching a pp-number. Rename parameter var to var1.
2303 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2305 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2307 2011-10-08 Glenn Morris <rgm@gnu.org>
2309 * callint.c (Fcall_interactively): Give a more explicit error for the
2310 'c' case with a non-character input. (Bug#8479)
2312 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2314 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2316 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2317 lines that are hscrolled on the left.
2319 * dispnew.c (buffer_posn_from_coords): Account for a possible
2320 presence of header-line. (Bug#4426)
2322 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2324 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2325 Don't advertise functionality which we discourage or doesn't work.
2327 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2329 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2330 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2331 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2332 this makes Emacs dump core during garbage collection on rare
2333 occasions. sizeof is obviously inferior to offsetof here, so
2334 stick with offsetof.
2335 (GC_POINTER_ALIGNMENT): New macro.
2336 (mark_memory): Omit 3rd (offset) arg; caller changed.
2337 Don't assume EMACS_INT alignment is the same as pointer alignment.
2339 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2341 * keyboard.c (read_key_sequence_remapped): New var.
2342 (read_key_sequence): Compute remapping in the right buffer.
2343 (command_loop_1): Use read_key_sequence's remapping directly.
2345 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2347 * dired.c (file_name_completion): Don't expand file name.
2348 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2349 before checking file name handler.
2351 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2352 they've been requested explicitly (bug#9591).
2354 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2356 * keymap.c (Fsingle_key_description): Use make_specified_string
2357 instead of build_string to build string from push_key_description.
2360 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2362 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2363 This fixes a Y2038 bug on 64-bit hosts.
2364 * buffer.c (reset_buffer):
2365 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2366 (Fclear_buffer_auto_save_failure):
2367 Use 0, not -1, to represent an unset failure time, since time_t
2368 might not be signed.
2370 Remove dependency on glibc malloc internals.
2371 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2372 Move back here from lisp.h, but with their new implementations.
2373 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2374 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2375 * charset.c (charset_table_init): New static var.
2376 (syms_of_charset): Use it instead of xmalloc. This removes a
2377 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2378 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2379 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2380 Move back to alloc.c.
2381 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2382 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2384 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2386 * nsterm.m (windowDidResize): Call x_set_window_size only when
2387 ns_in_resize is true. Otherwise set pixelwidth/height and
2388 call change_frame_size (Bug#9628).
2390 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2392 Port --enable-checking=all to Fedora 14 x86-64.
2393 * charset.c (syms_of_charset): Also account for glibc malloc's
2394 internal overhead when calculating the initial malloc maximum.
2396 Port --enable-checking=all to Fedora 14 x86.
2397 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2399 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2400 (overrun_check_realloc, overrun_check_free):
2401 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2402 That way, xmalloc returns a properly-aligned pointer even if
2403 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2404 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2405 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2406 into account when calculating the initial malloc maximum.
2407 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2408 Move here from alloc.c, so that charset.c can use it too.
2409 Properly align; the old code wasn't right for common 32-bit hosts
2410 when configured with --enable-checking=all.
2411 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2412 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2414 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2416 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2419 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2421 * xdisp.c (compute_display_string_end): If there's no display
2422 string at CHARPOS, return -1.
2424 * bidi.c (bidi_fetch_char): When compute_display_string_end
2425 returns a negative value, treat the character as a normal
2426 character not covered by a display string. (Bug#9624)
2428 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2430 * lread.c (Fread_from_string): Fix typo in docstring.
2432 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2434 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2435 newline, reseat the iterator instead of bidi-iterating there one
2436 character at a time. (Bug#9610)
2437 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2438 TO_CHARPOS if the bidi iterator is at base embedding level.
2440 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2442 * lread.c (readevalloop): Use correct code for NBSP.
2443 (read1): Likewise. (Bug#9608)
2445 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2447 * dbusbind.c (Fdbus_register_signal): When service is not
2448 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2450 2011-09-25 Glenn Morris <rgm@gnu.org>
2452 * buffer.c (truncate-lines): Doc fix.
2454 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2456 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2457 (Fset_window_next_buffers): Doc fix.
2459 2011-09-24 Glenn Morris <rgm@gnu.org>
2461 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2463 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2465 Fix minor problems found by static checking.
2466 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2467 * indent.c (Fvertical_motion): Fix == vs = typo.
2469 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2471 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2472 Default value is now t. Doc fix.
2474 * indent.c (Fvertical_motion): Compute and apply the overshoot
2475 logic when moving up, not only when moving down. Fix the
2476 confusing name and values of the it_overshoot_expected variable;
2477 logic changes accordingly. (Bug#9254) (Bug#9549)
2479 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2480 CHARPOS is covered by a display string which includes newlines.
2481 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2482 is covered by a display string with embedded newlines.
2484 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2486 * dbusbind.c (Fdbus_register_signal): Add match rule to
2487 Vdbus_registered_objects_table. (Bug#9581)
2488 (Fdbus_register_method, Vdbus_registered_objects_table):
2491 2011-09-24 Jim Meyering <meyering@redhat.com>
2493 do not ignore write error for any output size
2494 The previous change was incomplete.
2495 While it makes emacs --batch detect the vast majority of stdout
2496 write failures, errors were still ignored whenever the output size is
2497 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2498 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2499 && echo FAIL: ignored write error
2500 FAIL: ignored write error
2501 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2502 && echo FAIL: ignored write error
2503 FAIL: ignored write error
2504 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2506 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2508 * emacs.c (Fkill_emacs): In noninteractive mode exit
2509 non-successfully if a write error occurred on stdout. (Bug#9574)
2511 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2513 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2516 * dispextern.h (struct it): Update the comment documenting what
2519 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2521 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2522 a display string, extend search for cursor position to end of row.
2523 (find_row_edges): If the row ends in a newline from a display
2524 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2525 Handle the case of a display string with multiple newlines.
2526 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2527 non-empty line. Fixes confusing cursor motion with arrow keys at
2528 the beginning of a line that starts with whitespace.
2530 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2532 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2535 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2537 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2540 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2542 * xdisp.c (display_line): Record maximum and minimum buffer
2543 positions even if no glyphs were produced (e.g., by a zero-width
2544 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2545 buffer positions that will be removed from the glyph row because
2547 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2548 column is beyond frame width: don't subtract 1 "pixel" when
2549 computing width of the stretch.
2550 (reseat_at_next_visible_line_start): Undo the change made on
2551 2011-09-17 that saved paragraph information and restored it after
2552 the call to `reseat'. (Bug#9545)
2554 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2556 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2557 and turn window cursor on if cleared (Bug#9415).
2559 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2561 * search.c (boyer_moore): Take unibyte characters from pattern
2562 literally. (Bug#9458)
2564 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2566 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2568 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2570 Fix minor problem found by static checking.
2571 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2572 initialized, to pacify gcc -Wuninitialized.
2574 * fileio.c: Report proper errno when syscall falls.
2575 (Finsert_file_contents): Save and restore errno,
2576 so that report_file_error outputs the correct diagnostic.
2577 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2579 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2581 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2583 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2585 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2586 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2588 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2590 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2591 about the current paragraph and restore it after the call to reseat.
2593 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2594 (bidi_find_paragraph_start): Search back for paragraph beginning
2595 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2596 (bidi_move_to_visually_next): Only trigger paragraph-related
2597 computations when the last character is a newline or at EOB, not
2598 just any NEUTRAL_B. (Bug#9470)
2600 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2601 truncated lines if point is covered by a display string. (Bug#9524)
2603 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2605 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2606 (cons_to_x_long): New function.
2607 (lisp_data_to_selection_data): Use it. Correct the test for
2608 short-versus-long data; it was negated. Break out of vector
2609 loop, for efficiency, when a long datum is discovered.
2611 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2613 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2615 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2617 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2618 GCC PR/17406) by declaring this function with external scope.
2620 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2622 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2623 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2625 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2627 * editfns.c (Fformat): Correctly handle text properties on "%%".
2629 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2631 * xterm.c (x_draw_composite_glyph_string_foreground):
2632 * w32term.c (x_draw_composite_glyph_string_foreground):
2633 * term.c (encode_terminal_code):
2634 * composite.c (composition_update_it, get_composition_id):
2635 * xdisp.c (get_next_display_element)
2636 (fill_composite_glyph_string): Add comments about special meaning
2637 of TAB characters in a composition.
2639 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2641 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2642 This occurs when processing a multibyte format.
2643 Problem reported by Wolfgang Jenker.
2645 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2647 * xdisp.c (try_cursor_movement): Only check for exact match if
2648 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2650 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2652 Remove unused external symbols.
2653 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2654 * xdisp.c (calc_pixel_width_or_height): Now static.
2655 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2656 * indent.c (check_display_width):
2657 * w32term.c: Fix comment to match code.
2658 * xterm.c, xterm.h (x_catching_errors): Remove.
2660 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2662 * xselect.c: Use signed conversions more consistently (Bug#9498).
2663 (selection_data_to_lisp_data): Assume incoming selection data are
2664 signed integers, not unsigned. This is to be consistent with
2665 outgoing selection data, which was modified to use signed integers
2666 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2667 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2668 expects long, not unsigned long.
2670 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2672 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2673 computation of loop end. Reported by Johan Bockgård
2676 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2678 * frame.c (Fother_visible_frames_p): Function deleted.
2680 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2682 * indent.c (compute_motion): Process display vector front to back
2683 rather than the other way around. (Bug#2496)
2685 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2687 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2689 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2691 * minibuf.c (Fread_from_minibuffer): Doc fix.
2693 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2695 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2696 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2698 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2700 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2701 value for non-existent files.
2703 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2705 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2706 set its "size" to -1. This will set the modtime_size field of
2707 the corresponding buffer to -1, which is what
2708 verify-visited-file-modtime expects for files that do not exist.
2711 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2713 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2715 * lisp.h: ... from here. push_key_description is no longer
2716 defined in keyboard.c, so its declaration should not be in
2717 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2718 logically belongs with push_key_description.
2720 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2722 * buffer.h: Include <sys/types.h> instead of <time.h>.
2723 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2724 Problem reported by Herbert J. Skuhra.
2726 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2728 * xml.c (parse_region): Make the parsing work for
2729 non-comment-starting XML files again (bug#9144).
2731 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2733 * image.c (gif_load): Fix calculation of bottom and right corner.
2736 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2738 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2739 redisplay in small windows.
2741 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2743 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2745 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2747 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2748 Operate on live windows only.
2750 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2752 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2754 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2756 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2757 only under bidi iteration.
2759 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2761 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2763 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2765 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2766 Without this fix, the command to link temacs failed due to an
2767 undefined symbol __builtin_isnan. This is because
2768 /usr/include/iso/math_c99.h #defines isnan(x) to
2769 __builtin_isnan(x), but the bundled gcc, which identifies itself
2770 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2772 * floatfns.c (isnan): #undef, and then #define to a clone of
2774 (Fisnan): Always define, since it's always available now.
2775 (syms_of_floatfns): Always define isnan at the Lisp level.
2777 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2779 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2781 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2783 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2784 The previous code assumed that file offsets (off_t values) fit in
2785 EMACS_INT variables, which is not true on typical 32-bit hosts.
2786 The code messed up by falsely reporting buffer overflow in cases
2787 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2788 when "big" contains more than 2**29 bytes, even though this
2789 inserts just one byte and does not overflow the buffer.
2790 (Finsert_file_contents): Store file offsets as off_t
2791 values, not as EMACS_INT values. Check for overflow when
2792 converting between EMACS_INT and off_t. When checking for
2793 buffer overflow or for overlap, take the offsets into account.
2794 Don't use EMACS_INT for small values where int suffices.
2795 When checking for overlap, fix a typo: ZV was used where
2796 ZV_BYTE was intended.
2797 (Fwrite_region): Don't assume off_t fits into 'long'.
2798 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2800 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2802 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2804 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2806 sprintf-related integer and memory overflow issues (Bug#9412).
2808 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2809 (esprintf, exprintf, evxprintf): New functions.
2810 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2811 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2812 (modify_event_symbol): Do not assume that the length of
2813 name_alist_or_stem is safe to alloca and fits in int.
2814 (Fexecute_extended_command): Likewise for function name and binding.
2815 (Frecursion_depth): Wrap around reliably on integer overflow.
2816 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2817 since some callers pass EMACS_INT values.
2818 (Fsingle_key_description): Don't crash if symbol name contains more
2819 than MAX_ALLOCA bytes.
2820 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2821 (get_minibuffer): Arg is now EMACS_INT, not int.
2822 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2823 (esprintf, exprintf, evxprintf): New decls.
2824 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2826 * dbusbind.c (signature_cat): New function.
2827 (xd_signature, Fdbus_register_signal):
2828 Do not overrun buffer; instead, report string overflow.
2830 * dispnew.c (add_window_display_history): Don't overrun buffer.
2831 Truncate instead; this is OK since it's just a log.
2833 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2834 even if the time zone offset is outlandishly large.
2835 Don't mishandle offset == INT_MIN.
2837 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2838 when creating daemon; the previous buffer-overflow check was incorrect.
2840 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2841 which has the guts of the old verror function.
2843 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2844 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2846 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2847 (font_unparse_xlfd): Don't blindly alloca long strings.
2848 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2849 fits in int, when using sprintf. Use single snprintf to count
2850 length of string rather than counting it via multiple sprintfs;
2851 that's simpler and more reliable.
2852 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2853 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2854 sprintf, in case result does not fit in int.
2856 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2857 (fontset_from_font): Print it.
2859 * frame.c (tty_frame_count): Now printmax_t, not int.
2860 (make_terminal_frame, set_term_frame_name): Print it.
2861 (x_report_frame_params): In X, window IDs are unsigned long,
2862 not signed long, so print them as unsigned.
2863 (validate_x_resource_name): Check for implausibly long names,
2864 and don't assume name length fits in 'int'.
2865 (x_get_resource_string): Don't blindly alloca invocation name;
2866 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2869 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2870 (xg_check_special_colors, xg_set_geometry):
2871 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2873 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2874 Use esprintf, not sprintf, in case result does not fit in int.
2876 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2877 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2878 it as a large positive number.
2879 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2880 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2882 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2883 in case result does not fit in int.
2885 * print.c (float_to_string): Detect width overflow more reliably.
2886 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2887 buffer overrun. Don't assume list length fits in 'int'. Treat
2888 print length of 0 as 0, not as infinity; to be consistent with other
2889 uses of print length in this function. Don't overflow print length
2890 index. Don't assume hash table size fits in 'long', or that
2891 vectorlike size fits in 'unsigned long'.
2893 * process.c (make_process): Use printmax_t, not int, to format
2894 process-name gensyms.
2896 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2898 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2899 to avoid potential buffer overrun.
2901 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2902 if X resource line is longer than 512 bytes.
2904 * xfns.c (x_window): Make sprintf buffer a bit bigger
2905 to avoid potential buffer overrun.
2907 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2909 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2911 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2913 Integer overflow fixes for scrolling, etc.
2914 Without these, Emacs silently mishandles large integers sometimes.
2915 For example, "C-u 4294967297 M-x recenter" was treated as if
2916 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2918 * xdisp.c (try_window_id): Check Emacs fixnum range before
2919 converting to 'int'.
2921 * window.c (window_scroll_line_based, Frecenter):
2922 Check that an Emacs fixnum is in range before assigning it to 'int'.
2923 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2924 values converted from Emacs fixnums.
2925 (Frecenter): Don't wrap around a line count if it is out of 'int'
2926 range; instead, treat it as an extreme value.
2927 (Fset_window_configuration, compare_window_configurations):
2928 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2930 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2931 that can exceed INT_MAX. Check that EMACS_INT value is in range
2932 before assigning it to the (possibly-narrower) index.
2933 (match_limit): Don't assume that a fixnum can fit in 'int'.
2935 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2938 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2939 (Fvertical_motion): Don't wrap around LINES values that don't fit
2940 in 'int'. Instead, treat them as extreme values. This is good
2941 enough for windows, which can't have more than INT_MAX lines anyway.
2943 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2945 * Require libxml/parser.h to avoid compilation warning.
2947 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2949 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2950 since this reportedly can destroy thread storage.
2952 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2954 * syntax.c (find_defun_start): Update all cache variables if
2955 exiting early (Bug#9401).
2957 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2959 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2961 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2962 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2963 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2965 * term.c (tty_append_glyph): New function.
2966 (produce_stretch_glyph): Static function and its prototype deleted.
2968 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2971 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2973 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2974 when checking :margin (Bug#9390).
2975 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2976 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2977 so that the name doesn't mislead. All uses changed.
2979 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2981 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2984 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2986 * xdisp.c (move_it_to): Don't bail out early when reaching
2987 position beyond to_charpos, if we are scanning backwards.
2988 (move_it_vertically_backward): When DY == 0, make sure we get to
2989 the first character in the line after the newline.
2991 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2993 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2994 (ccl_driver): Do not generate an out-of-range pointer.
2995 (Fccl_execute_on_string): Remove unnecessary check for
2996 integer overflow, noted by Stefan Monnier in
2997 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2998 Remove a FIXME that didn't need fixing.
2999 Simplify the newly-introduced buffer reallocation code.
3001 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
3003 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3005 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
3007 Integer and memory overflow issues (Bug#9196).
3009 * doc.c (get_doc_string): Rework so that
3010 get_doc_string_buffer_size is the actual buffer size, rather than
3011 being 1 less than the actual buffer size; this makes xpalloc more
3014 * image.c (x_allocate_bitmap_record, cache_image):
3015 * xselect.c (Fx_register_dnd_atom):
3016 Simplify previous changes by using xpalloc.
3018 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3019 since either will do and ptrdiff_t is convenient with xpalloc.
3021 * charset.c (charset_table_size)
3022 (struct charset_sort_data.priority): Now ptrdiff_t.
3023 (charset_compare): Don't overflow if priorities differ greatly.
3024 (Fsort_charsets): Don't assume list length fits in int.
3025 Check for size-calculation overflow when allocating sort data.
3026 (syms_of_charset): Allocate an initial charset table that is
3027 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3029 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3031 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3032 The actual value is always <= INT_MAX, and leaving it unsigned made
3033 overflow checking harder.
3035 * dispextern.h (struct glyph_matrix.rows_allocated)
3036 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3037 with xpalloc. The values are still always <= INT_MAX.
3039 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3041 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3042 (SAFE_NALLOCA): New macro.
3044 * region-cache.c (struct boundary.pos, find_cache_boundary)
3045 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3046 (set_cache_region, invalidate_region_cache)
3047 (revalidate_region_cache, know_region_cache, region_cache_forward)
3048 (region_cache_backward, pp_cache):
3049 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3050 so that ptrdiff_t * can be passed to xpalloc.
3051 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3052 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3053 (pp_cache): Don't assume cache_len fits in int.
3054 * region-cache.h: Adjust extern decls to match.
3056 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3057 EMACS_INT, since either will do, for xpalloc.
3059 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3060 (xnmalloc, xnrealloc, xpalloc): New functions.
3062 * bidi.c (bidi_shelve_header_size): New constant.
3063 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3064 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3066 * bidi.c (bidi_cache_shrink):
3067 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3069 Don't update size of array until after memory allocation succeeds,
3070 because xmalloc/xrealloc may not return.
3071 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3072 now that we have proper integer overflow checking.
3073 (record_overlay_string, overlay_strings): Catch overflows when
3074 calculating size of overlay_str_buf.
3076 * callproc.c (Fcall_process): Check for size overflow when
3077 calculating size of args2.
3078 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3079 Normally we prefer signed values, but sticking with ptrdiff_t would
3080 require adding more-complicated checks.
3082 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3083 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3084 Redo buffer-overflow calculations to avoid integer overflow.
3085 Add a FIXME comment where memory seems to be over-allocated.
3087 * character.c (Fstring): Check for size-calculation overflow.
3089 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3090 unnecessary integer overflow. Check for size overflow.
3091 (encode_coding_object): Don't update size until xmalloc succeeds.
3093 * composite.c (get_composition_id): Check for overflow in glyph
3094 length calculations.
3096 Integer and memory overflow fixes for display code.
3097 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3098 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3099 (scrolling_window): Check for overflow in size calculations.
3100 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3101 Don't assume glyph table len fits in int.
3102 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3103 (row_table_size): Now ptrdiff_t, not int.
3104 (scrolling_window): Avoid overflow in size calculations.
3105 Don't update size until allocation succeeds.
3106 * fns.c (concat): Check for overflow in size calculations.
3107 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3108 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3109 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3111 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3112 (get_doc_string): Check for size calculation overflow.
3113 Don't update size until allocation succeeds.
3114 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3115 EMACS_INT, where ptrdiff_t will do.
3116 (Fsubstitute_command_keys): Check for string overflow.
3118 * editfns.c (set_time_zone_rule): Don't assume environment length
3120 (message_length): Now ptrdiff_t, not int.
3121 (Fmessage_box): Don't update size until allocation succeeds.
3122 Don't assume message length fits in int.
3123 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3125 * emacs.c (main): Do not reallocate argv, since there is a null at
3126 the end that can be overwritten, and this way there's no need to
3127 worry about size-calculation overflow.
3128 (sort_args): Check for size-calculation overflow.
3130 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3132 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3134 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3135 (x_set_scroll_bar_width, x_figure_window_size):
3136 Check for integer overflow.
3137 (x_set_alpha): Do not assume XINT fits in int.
3139 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3140 This is for the members text_lines, text_cols, total_lines, total_cols,
3141 where the system imposes an 'int' limit.
3143 * fringe.c (Fdefine_fringe_bitmap):
3144 Don't update size until alloc works.
3146 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3147 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3149 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3150 Check for size-calculation overflow.
3151 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3152 do, as we prefer signed integers.
3153 (id_to_widget.max_size, id_to_widget.used)
3154 (xg_store_widget_in_map, xg_remove_widget_from_map)
3155 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3156 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3157 Use and return ptrdiff_t, not int.
3158 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3159 * gtkutil.h: Change prototypes to match the above.
3161 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3162 are duplicate now that they've been promoted to lisp.h.
3163 (x_allocate_bitmap_record, x_alloc_image_color)
3164 (make_image_cache, cache_image, xpm_load):
3165 Don't update size until alloc is done.
3166 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3168 Check for size calculation overflow.
3169 (ct_colors_allocated_max): New constant.
3170 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3173 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3174 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3175 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3176 Use ptrdiff_t, not int, to count maps.
3177 (read_char_minibuf_menu_prompt): Check for overflow in size
3178 calculations. Don't update size until allocation succeeds.
3179 Redo calculations to avoid overflow.
3180 * keyboard.h: Change prototypes to match the above.
3182 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3184 (current_minor_maps): Check for size calculation overflow.
3185 * keymap.h: Change prototypes to match the above.
3187 * lread.c (read1, init_obarray): Don't update size until alloc done.
3189 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3190 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3192 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3193 Now ptrdiff_t, not int.
3194 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3195 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3197 * process.c (Fnetwork_interface_list): Check for overflow
3198 in size calculation.
3200 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3202 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3203 overflow. Don't bother calling xmalloc when xrealloc will do.
3205 * search.c (Freplace_match): Check for size calculation overflow.
3206 (Fset_match_data): Don't assume list lengths fit in 'int'.
3208 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3209 for command line length. Do not attempt to address one before the
3210 beginning of an array, as that's not portable.
3212 * term.c (max_frame_lines): Remove; unused.
3213 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3215 (encode_terminal_code, calculate_costs): Check for size
3216 calculation overflow.
3217 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3218 table lengths and related sizes. Don't update size until alloc
3219 done. Redo calculations to avoid overflow.
3220 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3222 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3223 subtracting pointers.
3224 (gobble_line): Check for overflow more carefully. Don't update size
3227 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3228 Don't update size until alloc done.
3229 Redo size calculations to avoid overflow.
3230 Check for size calculation overflow.
3231 (main) [DEBUG]: Fix typo in invoking tparam1.
3233 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3234 Use ptrdiff_t, not int, for sizes.
3235 (store_mode_line_noprop_char): Don't update size until alloc done.
3237 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3238 Use ptrdiff_t, not int, for sizes.
3239 (Finternal_make_lisp_face, cache_face):
3240 Check for size calculation overflow.
3241 (cache_face): Treat size calculation overflows as if they were
3242 memory exhaustion (the usual treatment), rather than aborting.
3244 * xfns.c (x_encode_text, x_set_name_internal)
3245 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3246 sizes, since they can exceed INT_MAX in size. Check for size
3247 calculation overflow.
3249 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3250 (xg_select): Check for size calculation overflow.
3251 Don't update size until alloc done.
3253 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3254 as sprintf is limited to int lengths.
3256 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3257 (X_LONG_MIN): New macros.
3258 Use them to make the following changes clearer.
3259 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3260 This change doesn't affect the value now, but it may help remind
3261 future maintainers not to raise the value too much later.
3262 (SELECTION_QUANTUM): Remove, replacing with ...
3263 (selection_quantum): ... new function, which avoids overflow.
3265 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3266 assumption that selection length fits in 'int'.
3267 (x_reply_selection_request, x_handle_selection_request)
3268 (x_get_window_property, receive_incremental_selection)
3269 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3270 (lisp_data_to_selection_data, clean_local_selection_data):
3271 Use ptrdiff_t, not int, to record length of selection.
3272 (x_reply_selection_request, x_get_window_property)
3273 (receive_incremental_selection, x_property_data_to_lisp):
3274 Redo calculations to avoid overflow.
3275 (x_reply_selection_request): When sending hint, ceiling it at
3276 X_LONG_MAX rather than relying on wraparound overflow to send
3278 (x_get_window_property, receive_incremental_selection)
3279 (lisp_data_to_selection_data, x_property_data_to_lisp):
3280 Check for size-calculation overflow.
3281 (x_get_window_property, receive_incremental_selection)
3282 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3283 Don't store size until memory allocation succeeds.
3284 (x_get_window_property): Plug memory leak on memory exhaustion.
3285 Don't double-block input; malloc is safe here. Don't assume 2**34
3286 - 4 fits in unsigned long. Add an xassert to check
3287 XGetWindowProperty overflow. Be more careful about overflow
3288 calculations, and distinguish size from memory overflow better.
3289 (receive_incremental_selection): When tracing, don't assume
3290 unsigned int is less than INT_MAX.
3291 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3292 harmful) conversions of unsigned short to int.
3293 (lisp_data_to_selection_data): Don't assume that integers
3294 in the range -65535 through -1 fit in an X unsigned short.
3295 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3296 result parameters unless successful. Rely on cons_to_unsigned
3297 to report problems with elements; the old code wasn't right anyway.
3298 (x_check_property_data): Check for int overflow; we cannot use
3299 a wider type due to X limits.
3300 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3302 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3304 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3305 (x_term_init): Check for size calculation overflow.
3306 (x_color_cells): Don't store size until memory allocation succeeds.
3307 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3308 Don't assume alloca size is less than MAX_ALLOCA.
3309 (x_term_init): Don't assume length fits in int (sprintf is limited
3312 Use ptrdiff_t for composition IDs.
3313 * character.c (lisp_string_width):
3314 * composite.c (composition_table_size, n_compositions)
3315 (get_composition_id, composition_gstring_from_id):
3316 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3317 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3318 * window.c (Frecenter):
3319 Use ptrdiff_t, not int, for composition IDs.
3320 * composite.c (get_composition_id): Check for integer overflow.
3321 * composite.h: Adjust prototypes to match the above changes.
3323 Use ptrdiff_t for hash table indexes.
3324 * category.c (hash_get_category_set):
3325 * ccl.c (ccl_driver):
3326 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3327 * coding.c (coding_system_charset_list, detect_coding_system):
3328 * coding.h (struct coding_system.id):
3329 * composite.c (get_composition_id, gstring_lookup_cache):
3330 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3331 * image.c (xpm_get_color_table_h):
3332 * lisp.h (hash_lookup, hash_put):
3333 * minibuf.c (Ftest_completion):
3334 Use ptrdiff_t for hash table indexes, not int (which is too
3335 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3336 32-bit --with-wide-int hosts).
3338 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3339 Add a FIXME comment about memory leaks.
3340 (syms_of_charset): Don't assume xmalloc returns.
3342 Don't assume that stated character widths fit in int.
3343 * character.c (Fchar_width, c_string_width, lisp_string_width):
3344 * character.h (CHAR_WIDTH):
3345 * indent.c (MULTIBYTE_BYTES_WIDTH):
3346 Use sanitize_char_width to avoid undefined and/or bad behavior
3347 with outlandish widths.
3348 * character.h (sanitize_tab_width): Rename from sanitize_width,
3349 now that we have two such functions. All uses changed.
3350 (sanitize_char_width): New inline function.
3352 Don't assume that tab-width fits in int.
3353 * character.h (sanitize_width): New inline function.
3354 (SANE_TAB_WIDTH): New macro.
3355 (ASCII_CHAR_WIDTH): Use it.
3356 * indent.c (sane_tab_width): Remove. All uses replaced by
3357 SANE_TAB_WIDTH (current_buffer).
3358 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3360 * fileio.c: Integer overflow issues with file modes.
3361 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3363 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3364 Remove unreachable code.
3365 (read_hex, load_charset_map_from_file): Check for integer overflow.
3367 * xterm.c: Don't go over XClientMessageEvent limit.
3368 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3369 (x_send_scroll_bar_event): Likewise. Check that the size does not
3370 exceed limits imposed by XClientMessageEvent, as well as the usual
3371 ptrdiff_t and size_t limits.
3373 * keyboard.c: Overflow, signedness and related fixes.
3374 (make_lispy_movement): Use same integer type in forward decl
3375 that is used in the definition.
3376 (read_key_sequence, keyremap_step):
3377 Change bufsize argument back to int, undoing my 2011-03-30 change.
3378 We prefer signed types, and int is wide enough here.
3379 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3380 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3381 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3382 length, not size_t. Use ptrdiff_t for index, not int.
3383 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3384 possibility of integer overflow.
3386 Overflow, signedness and related fixes for images.
3388 * dispextern.h (struct it.stack[0].u.image.image_id)
3389 (struct_it.image_id, struct image.id, struct image_cache.size)
3390 (struct image_cache.used, struct image_cache.ref_count):
3391 * gtkutil.c (update_frame_tool_bar):
3392 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3393 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3394 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3395 * nsmenu.m (update_frame_tool_bar):
3396 * xdisp.c (calc_pixel_width_or_height):
3397 * xfns.c (image_cache_refcount):
3398 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3399 on typical 64-bit hosts.
3401 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3402 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3403 Omit unnecessary casts to int.
3404 (parse_image_spec): Check that integers fall into 'int' range
3405 when the callers expect that.
3406 (image_ascent): Redo ascent calculation to avoid int overflow.
3407 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3408 (lookup_image): Remove unnecessary tests.
3409 (xbm_image_p): Locals are now of int, not EMACS_INT,
3410 since parse_image_check makes sure they fit into int.
3411 (png_load, gif_load, svg_load_image):
3412 Prefer int to unsigned where either will do.
3413 (tiff_handler): New function, combining the cores of the
3414 old tiff_error_handler and tiff_warning_handler.
3415 This function is rewritten to use vsnprintf and thereby avoid
3416 stack buffer overflows. It uses only the features of vsnprintf
3417 that are common to both POSIX and native Microsoft.
3418 (tiff_error_handler, tiff_warning_handler): Use it.
3419 (tiff_load, gif_load, imagemagick_load_image):
3420 Don't assume :index value fits in 'int'.
3421 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3422 (imagemagick_load_image): Check that crop parameters fit into
3423 the integer types that MagickCropImage accepts. Don't assume
3424 Vimagemagick_render_type has a nonnegative value. Don't assume
3425 size_t fits in 'long'.
3426 (gs_load): Use printmax_t to print the widest integers possible.
3427 Check for integer overflow when computing image height and width.
3429 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3431 * xdisp.c (redisplay_window): Don't force window start if point
3432 will be invisible in the resulting window. (Bug#9324)
3434 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3436 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3437 the display spec is of the form `(space ...)'.
3438 (handle_display_spec): Return the value returned by
3439 handle_single_display_spec, not just 1 or zero.
3440 (handle_single_display_spec): If the display spec is of the form
3441 `(space ...)', and specifies display in the text area, return 2
3443 (try_cursor_movement): Check for the need to scroll more
3444 accurately, and prefer exact match for point under bidi.
3445 Don't advance `row' beyond the last row of the window.
3447 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3448 into disp_prop; all users changed.
3450 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3451 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3452 for the text covered by the display property.
3454 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3456 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3457 Change return value to nil.
3458 (Frecord_buffer): Delete unused function.
3460 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3462 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3463 buffers, return left-to-right.
3464 (set_cursor_from_row): Consider candidate row a win if its glyph
3465 represents a newline and point is on that newline. Fixes cursor
3466 positioning on the newline at EOL of R2L text within L2R
3467 paragraph, and vice versa.
3468 (try_cursor_movement): Check continued rows, in addition to
3469 continuation rows. Fixes unwarranted scroll when point enters a
3470 continued line of R2L text within an L2R paragraph, or vice versa.
3471 (cursor_row_p): Consider the case of point being equal to
3472 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3473 from the end of a short line to the beginning of a continued line
3474 of R2L text within L2R paragraph.
3475 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3476 composed characters.
3478 * bidi.c (bidi_check_type): Use xassert.
3479 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3482 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3484 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3487 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3489 * nsfont.m (ns_otf_to_script): Fix typo.
3491 2011-08-22 Kenichi Handa <handa@m17n.org>
3493 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3494 extra slot even if the purpose is char-code-property-table.
3496 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3498 * xdisp.c (redisplay_window): When computing centering_position,
3499 account for the height of the header line. (Bug#8874)
3501 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3502 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3503 candidate is selected by the mouse, and that candidate has a
3504 composed character under the mouse.
3506 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3507 coordinates reported by pos-visible-in-window-p for a composed
3508 character in column zero.
3510 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3512 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3514 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3516 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3517 consider it a hit if to_charpos is anywhere in the range of the
3518 composed buffer positions.
3520 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3522 * image.c (gif_load): Don't assume that each subimage has the same
3523 dimensions as the base image. Handle disposal method that is
3524 "undefined" by the gif spec (Bug#9335).
3526 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3528 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3529 (Fcondition_case): Document `debug' symbol in error handler.
3531 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3533 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3534 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3535 from an Org mode buffer to a Speedbar frame.
3537 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3538 a composition, take its buffer position from IT->cmp_it.charpos.
3539 Fixes cursor positioning at the beginning of a line that begins
3540 with a composed character.
3542 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3544 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3545 character bidirectional type, use STRONG_L instead. Fixes crashes
3546 in a buffer produced by `describe-categories'.
3548 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3549 members before the level stack, so they would be saved and
3550 restored when copying iterator state. Fixes incorrect reordering
3551 around TABs covered by display properties.
3553 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3555 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3557 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3559 * eval.c (internal_condition_case, internal_condition_case_1)
3560 (internal_condition_case_2, internal_condition_case_n):
3561 Remove unnecessary aborts (Bug#9081).
3563 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3565 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3566 has no `load' handler, try opening the file locally. (Bug#9311)
3568 2011-08-16 Ken Brown <kbrown@cornell.edu>
3570 * gmalloc.c: Expand comment.
3572 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3574 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3575 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3577 2011-08-16 Ken Brown <kbrown@cornell.edu>
3579 Fix memory allocation problems in Cygwin build (Bug#9273).
3581 * unexcw.c ( __malloc_initialized): Declare external variable.
3582 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3584 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3586 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3588 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3590 [CYGWIN] (special_realloc): New function.
3591 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3592 requests to realloc storage in the static heap.
3594 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3596 * bidi.c (bidi_initialize): Remove unused local.
3598 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3601 * biditype.h: Remove file.
3602 * makefile.w32-in ($(BLD)/bidi.$(O)):
3603 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3605 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3607 * chartab.c: Improve commentary for the uniprop_table API.
3609 * bidi.c (bidi_paragraph_init): Support zero value of
3610 bidi_ignore_explicit_marks_for_paragraph_level.
3611 (bidi_initialize): Use uniprop_table instead of including
3612 biditype.h and bidimirror.h.
3614 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3615 coordinates of the iterator when restoring from ppos_it.
3618 2011-08-14 Kenichi Handa <handa@m17n.org>
3620 * process.c (create_process): Call setup_process_coding_systems
3621 after the pid of the process is set to -1 (Bug#8162).
3623 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3625 * xdisp.c (move_it_in_display_line_to): Don't invoke
3626 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3627 ppos_it. Fixes vertical cursor motion when line beginning is
3628 covered by an image. (Bug#9296)
3630 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3632 * nsterm.h (ns_run_ascript): Declare.
3633 (NSAPP_DATA2_RUNASSCRIPT): Define.
3635 * nsfns.m (as_script, as_result, as_status): New static variables.
3636 (ns_run_ascript): New function.
3637 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3638 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3639 the event loop. Get status from as_status (Bug#7276).
3641 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3642 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3643 the event loop (Bug#7276).
3645 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3647 * gnutls.c (QCgnutls_bootprop_priority)
3648 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3649 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3650 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3651 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3652 (QCgnutls_bootprop_verify_hostname_error)
3653 (QCgnutls_bootprop_callbacks_verify): Rename from
3654 Qgnutls_bootprop_..., all uses changed.
3656 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3659 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3661 * xfaces.c (Qframe_set_background_mode): Now static.
3662 * dispextern.h (Qframe_set_background_mode): Remove decl.
3664 * process.c (Fnetwork_interface_info): Declare local only if needed.
3666 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3668 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3669 (Fnetwork_interface_list): Allocate in increments of bytes instead
3670 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3671 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3673 (struct ifflag_def): notrailers is smart on OSX.
3674 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3675 Get hardware address with getifaddrs if available.
3677 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3679 * xdisp.c (iterate_out_of_display_property): xassert that
3680 IT->position is set to within IT->object's boundaries. Break from
3681 the loop as soon as EOB is reached; avoids infloops in redisplay
3682 when IT->position is set up wrongly due to some bug.
3683 Set IT->current to match the bidi iterator unconditionally.
3684 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3685 entry. Force push_it to save on the stack the current
3686 buffer/string position, to be restored by pop_it. Fix flags in
3687 the iterator structure wrt the object coming from a display
3688 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3689 properties. (Bug#9284)
3691 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3693 * fontset.c (fontset_get_font_group): Add proper type checks.
3696 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3698 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3699 and LC_VERSION_MIN_MACOSX.
3700 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3701 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3703 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3705 * xdisp.c (forward_to_next_line_start): Allow to use the
3706 no-display-properties-and-no-overlays under bidi display.
3707 Set disp_pos in the bidi iterator to avoid searches for display
3708 properties and overlays.
3710 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3712 * editfns.c (Fset_time_zone_rule): Document relationship with the
3715 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3716 the font entity extracted from the cache (Bug#8109).
3718 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3720 * composite.c (autocmp_chars): Don't reset point. That is done by
3721 restore_point_unwind (Bug#5984).
3723 2011-08-07 Juri Linkov <juri@jurta.org>
3725 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3726 to show the arg `TIME' instead of `TIMEVAL'.
3728 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3730 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3731 display property strides EOL and includes a newline, as in
3732 longlines-mode. (Bug#9254)
3733 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3734 word-wrap under bidirectional display. (Bug#9224)
3736 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3737 is non-zero, even if the data buffer is NULL. Fixes a crash in
3738 vertical-motion with longlines-mode. (Bug#9254)
3740 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3742 * bidi.c <bidi_cache_total_alloc>: Now static.
3743 (bidi_initialize): Initialize bidi_cache_total_alloc.
3745 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3748 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3749 amount allocated this far in `bidi_cache_total_alloc'.
3750 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3751 non-zero, only free the data buffer without restoring the cache
3752 contents. All callers changed.
3754 * dispextern.h (bidi_unshelve_cache): Update prototype.
3756 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3757 (move_it_in_display_line, move_it_to)
3758 (move_it_vertically_backward, move_it_by_lines): Replace the call
3759 to xfree to an equivalent call to bidi_unshelve_cache.
3760 (move_it_in_display_line_to): Fix logic of returning
3761 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3763 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3765 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3766 came from a string character with a `cursor' property. (Bug#9229)
3768 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3770 * Makefile.in (LIB_PTHREAD): New variable.
3771 (LIBES): Add LIB_PTHREAD (Bug#9216).
3773 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3774 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3776 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3778 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3780 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3782 * xterm.c (x_find_topmost_parent): New function.
3783 (x_set_frame_alpha): Find topmost parent window with
3784 x_find_topmost_parent and set the property there also (bug#9181).
3785 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3787 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3789 * callproc.c (Fcall_process): Avoid vfork clobbering
3790 the local vars buffer, coding_systems, current_dir.
3792 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3794 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3796 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3798 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3799 so that it is not optimized away.
3801 * xdisp.c (compute_display_string_pos): Remove unused local.
3803 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3805 Fix slow cursor motion and scrolling in large buffers with
3806 selective display, like Org Mode buffers. (Bug#9218)
3808 * dispextern.h (struct bidi_it): New member disp_prop_p.
3810 * xdisp.c: Remove one-slot cache of display string positions.
3811 (compute_display_string_pos): Accept an additional argument
3812 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3813 for a display string or property. If found, set DISP_PROP_P
3816 * bidi.c (bidi_fetch_char): Accept an additional argument
3817 DISP_PROP_P, and pass it to compute_display_string_pos.
3818 Only handle text covered by a display string if DISP_PROP_P is returned
3819 non-zero. All callers of bidi_fetch_char changed.
3821 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3823 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3825 2010-12-03 Don March <don@ohspite.net>
3827 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3828 last character M-[char] is translated to ESC [char] (bug#7541).
3830 2011-08-02 Kenichi Handa <handa@m17n.org>
3832 * lisp.h (uniprop_table): Extern it.
3834 * chartab.c (uniprop_table): Make it non-static.
3836 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3838 * xdisp.c (forward_to_next_line_start): Accept additional argument
3839 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3841 (reseat_at_next_visible_line_start): Use the bidi iterator state
3842 returned by forward_to_next_line_start to restore the state of
3843 it->bidi_it after backing up to previous newline. (Bug#9212)
3845 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3847 * regex.c (re_comp): Protoize.
3848 (re_exec): Fix return type.
3849 (regexec): Fix type of `ret'. (Bug#9203)
3851 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3853 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3854 This is needed if max-image-size is a floating-point number.
3856 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3858 * print.c (print_object): Print empty symbol as ##.
3860 * lread.c (read1): Read ## as empty symbol.
3862 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3864 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3865 setting frame foreground color (Bug#9175).
3866 (x_set_background_color): Likewise.
3868 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3869 contents (Bug#9176).
3870 (EmacsTooltip -init): Remove bezels and add shadows to
3873 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3874 or scroll bar (Bug#8470).
3876 * nsfont.m (nsfont_open): Remove assignment to voffset and
3877 unnecessary vars hshink, expand, hd, full_height, min_height.
3878 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3880 * nsterm.h (nsfont_info): Remove voffset field.
3882 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3884 Implement strike-through and overline on NextStep (Bug#8863).
3886 * nsfont.m (nsfont_open): Use underline position provided by font,
3887 instead of hard-coded value of 2.
3888 (nsfont_draw): Call ns_draw_text_decoration instead.
3890 * nsterm.h: Add declaration for ns_draw_text_decoration.
3892 * nsterm.m (ns_draw_text_decoration): New function for drawing
3893 underline, overline, and strike-through.
3894 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3895 ns_draw_text_decoration. Change treatment of cursor drawing to
3896 accommodate underlining, etc.
3898 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3900 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3903 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3905 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3906 Without this fix, if a signal arrives just after memory fills up,
3907 'malloc' might be invoked reentrantly.
3909 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3910 In other words, assume that every image size is allowed, on non-X
3911 hosts. This assumption is probably wrong, but it lets Emacs compile.
3913 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3915 * regex.c (re_iswctype): Convert return values to boolean.
3917 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3919 * xdisp.c (compute_display_string_pos): Don't use cached display
3920 string position if the buffer had its restriction changed.
3923 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3925 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3927 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3929 Integer signedness and overflow and related fixes. (Bug#9079)
3931 * bidi.c: Integer size and overflow fixes.
3932 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3933 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3934 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3935 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3936 (bidi_find_other_level_edge):
3937 Use ptrdiff_t instead of EMACS_INT where either will do.
3938 This works better on 32-bit hosts configured --with-wide-int.
3939 (bidi_cache_ensure_space): Check for size-calculation overflow.
3940 Use % rather than repeated addition, for better worst-case speed.
3941 Don't set bidi_cache_size until after xrealloc returns, because it
3943 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3944 (bidi_cache_ensure_space): Also check that the bidi cache size
3945 does not exceed that of the largest Lisp string or buffer. See Eli
3946 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3948 * alloc.c (__malloc_size_t): Remove.
3949 All uses replaced by size_t. See Andreas Schwab's note
3950 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3952 * image.c: Improve checking for integer overflow.
3953 (check_image_size): Assume that f is nonnull, since
3954 it is always nonnull in practice. This is one less thing to
3955 worry about when checking for integer overflow later.
3956 (x_check_image_size): New function, which checks for integer
3957 overflow issues inside X.
3958 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3959 This removes the need for a memory_full check.
3960 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3961 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3962 (xbm_read_bitmap_data): Change locals back to 'int', since
3963 their values must fit in 'int'.
3964 (xpm_load_image, png_load, tiff_load):
3965 Invoke x_create_x_image_and_pixmap earlier,
3966 to avoid much needless work if the image is too large.
3967 (tiff_load): Treat overly large images as if
3968 x_create_x_image_and_pixmap failed, not as malloc failures.
3969 (gs_load): Use x_check_image_size.
3971 * gtkutil.c: Omit integer casts.
3972 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3973 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3975 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3977 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3978 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3979 would wrongly return t on a 64-bit host.
3981 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3982 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3983 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3984 and therefore cause GCC to emit a bogus diagnostic in some cases.
3986 * image.c: Integer signedness and overflow and related fixes.
3987 This is not an exhaustive set of fixes, but it's time to
3988 record what I've got.
3989 (lookup_pixel_color, check_image_size): Remove redundant decls.
3990 (check_image_size): Don't assume that arbitrary EMACS_INT values
3991 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3992 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3993 (tiff_load, imagemagick_load_image):
3994 Check for overflow in size calculations.
3995 (x_create_x_image_and_pixmap): Remove unnecessary test for
3996 xmalloc returning NULL; that can't happen.
3997 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3998 (xpm_color_bucket): Use better integer hashing function.
3999 (xpm_cache_color): Don't possibly over-allocate memory.
4000 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4001 (gif_memory_source):
4002 Use ptrdiff_t, not int or size_t, to record sizes.
4003 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4004 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4005 either works, as we prefer signed integers.
4006 (tiff_read_from_memory, tiff_write_from_memory):
4007 Return tsize_t, not size_t, since that's what the TIFF API wants.
4008 (tiff_read_from_memory): Don't fail simply because the read would
4009 go past EOF; instead, return a short read.
4010 (tiff_load): Omit no-longer-needed casts.
4011 (Fimagemagick_types): Don't assume size fits into 'int'.
4013 Improve hashing quality when configured --with-wide-int.
4014 * fns.c (hash_string): New function, taken from sxhash_string.
4015 Do not discard information about ASCII character case; this
4016 discarding is no longer needed.
4017 (sxhash-string): Use it. Change sig to match it. Caller changed.
4018 * lisp.h: Declare it.
4019 * lread.c (hash_string): Remove, since we now use fns.c's version.
4020 The fns.c version returns a wider integer if --with-wide-int is
4021 specified, so this should help the quality of the hashing a bit.
4023 * emacs.c: Integer overflow minor fix.
4024 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4025 Define only if GNU_LINUX.
4026 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4028 * dispnew.c: Integer signedness and overflow fixes.
4029 Remove unnecessary forward decls, that were a maintenance hassle.
4030 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4032 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4033 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4034 (prepare_desired_row, line_draw_cost):
4035 Use int, not unsigned, where either works.
4036 (save_current_matrix, restore_current_matrix):
4037 Use ptrdiff_t, not size_t, where either works.
4038 (init_display): Check for overflow more accurately, and without
4039 relying on undefined behavior.
4041 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4042 Remove, replacing with the new symbols in lisp.h. All uses changed.
4043 * fileio.c (make_temp_name):
4044 * filelock.c (lock_file_1, lock_file):
4045 * xdisp.c (message_dolog):
4046 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4047 Use pMd etc. instead.
4048 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4049 replacing the pWIDE etc. symbols removed from editfns.c.
4051 * keyboard.h (num_input_events): Now uintmax_t.
4052 This is (very slightly) less likely to mess up due to wraparound.
4055 * buffer.c: Integer signedness fixes.
4056 (alloc_buffer_text, enlarge_buffer_text):
4057 Use ptrdiff_t rather than size_t when either will do, as we prefer
4060 * alloc.c: Integer signedness and overflow fixes.
4061 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4062 (__malloc_size_t): Default to size_t, not to int.
4063 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4064 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4065 Prefer ptrdiff_t to size_t when either would do, as we prefer
4067 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4068 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4069 Now const. Initialize with values that are in range even if char
4071 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4072 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4073 These functions do the right thing with sizes > 2**32.
4074 (check_depth): Now ptrdiff_t, not int.
4075 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4076 Adjust to new way of storing sizes. Check for size overflow bugs
4078 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4079 slightly wrong anyway, as it missed one instance of
4080 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4081 (refill_memory_reserve): Omit needless cast to size_t.
4082 (mark_object_loop_halt): Mark as externally visible.
4084 * xselect.c: Integer signedness and overflow fixes.
4085 (Fx_register_dnd_atom, x_handle_dnd_message):
4086 Use ptrdiff_t, not size_t, since we prefer signed.
4087 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4088 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4089 x_dnd_atoms_size and x_dnd_atoms_length.
4091 * doprnt.c: Prefer signed to unsigned when either works.
4093 * doprnt.c (doprnt):
4095 * xdisp.c (vmessage):
4096 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4097 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4098 prefer signed arithmetic to avoid comparison confusion.
4099 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4100 but is a bit tricky.
4102 Assume freestanding C89 headers, string.h, stdlib.h.
4103 * data.c, doprnt.c, floatfns.c, print.c:
4104 Include float.h unconditionally.
4105 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4106 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4107 * regex.c: Likewise for stddef.h, string.h.
4108 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4109 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4110 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4111 (STDC_HEADERS): Remove obsolete defines.
4112 * sysdep.c: Include limits.h unconditionally.
4114 Assume support for memcmp, memcpy, memmove, memset.
4115 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4116 * regex.c (memcmp, memcpy):
4117 Remove; we assume C89 now.
4119 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4120 (__malloc_safe_bcopy): Remove; no longer needed.
4122 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4123 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4124 well either way, and we prefer signed to unsigned.
4126 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4128 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4129 closes the connection while we're reading (bug#9182).
4131 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4133 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4134 are specified (Bug#9168).
4136 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4138 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4139 Found by GCC static checking and --with-wide-int on a 32-bit host.
4141 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4143 * xdisp.c (compute_display_string_pos): Fix logic of caching
4144 previous display string position. Initialize cached_prev_pos to
4145 -1. Fixes slow-down at the beginning of a buffer.
4147 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4149 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4150 for attrs[LFACE_FONTSET_INDEX].
4152 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4154 * xml.c (parse_region): Remove unused local
4155 that was recently introduced.
4157 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4159 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4160 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4162 * xdisp.c (move_it_in_display_line_to): Record the best matching
4163 position for TO_CHARPOS while scanning the line, and restore it on
4164 exit if none of the characters scanned was an exact match.
4165 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4166 when exact match is impossible due to invisible text, and the
4167 lines are truncated.
4169 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4171 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4174 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4176 Fix a significant slow-down of cursor motion with C-n, C-p,
4177 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4178 auto-repeat under bidi redisplay in fontified buffers.
4179 * xdisp.c (compute_stop_pos_backwards): New function.
4180 (next_element_from_buffer): Call compute_stop_pos_backwards to
4181 find a suitable prev_stop when we find ourselves before
4183 (reseat): Don't look for prev_stop, as that could mean a very long
4185 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4186 <cached_disp_overlay_modiff>: Cache for last found display string
4188 (compute_display_string_pos): Return the cached position if asked
4189 about the same buffer in the same area of character positions, and
4190 the buffer wasn't changed since the time the display string
4191 position was cached.
4193 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4195 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4196 is an integer, which is important for empty lines. (Bug#9149)
4198 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4200 * frame.c (Fmodify_frame_parameters): In tty case, update the
4201 default face if necessary (Bug#4238).
4203 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4205 * editfns.c (Fstring_to_char): No need to explain what a character
4206 is in the docstring (Bug#6576).
4208 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4210 * xml.c (parse_region): Make sure we always return a tree.
4212 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4214 * xml.c (parse_region): If a document contains only comments,
4217 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4219 * xml.c (make_dom): Return comments, too.
4221 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4224 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4225 and the surrounding thread.
4226 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4227 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4228 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4230 * s/openbsd.h (BROKEN_SIGIO): Define.
4231 * unexelf.c (unexec) [__OpenBSD__]:
4232 Don't update the .mdebug section of the Alpha COFF symbol table.
4234 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4236 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4239 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4241 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4242 This fixes some race conditions on the permissions of any newly
4245 * alloc.c (valid_pointer_p): Use pipe, not open.
4246 This fixes some permissions issues when debugging.
4248 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4249 If fchown fails to set both uid and gid, try to set just gid,
4250 as that is sometimes allowed. Adjust the file's mode to eliminate
4251 setuid or setgid bits that are inappropriate if fchown fails.
4253 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4255 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4256 to compare Lisp_Objects.
4257 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4258 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4259 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4261 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4263 * lread.c (read_integer): Unread even EOF character.
4264 (read1): Likewise. Properly record start position of symbol.
4266 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4267 symbol character follows.
4269 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4271 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4272 This works around a problem with the previous change to Fcopy_file.
4273 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4274 and without this change, GCC might complain about discarding
4275 fchown's return value.
4277 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4279 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4281 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4283 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4285 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4287 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4288 it's used from the C level.
4290 * process.c: Use the same condition for POLL_FOR_INPUT in both
4291 keyboard.c and process.c (bug#1858).
4293 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4295 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4296 (Fgnutls_boot): Use it.
4298 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4300 * doc.c (Fsubstitute_command_keys): Revert last change.
4302 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4304 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4305 quotes the next character, and doesn't affect other longer
4306 sequences (bug#8935).
4308 * lread.c (syms_of_lread): Clarify that is isn't only
4309 `eval-buffer' and `eval-defun' that's affected by
4310 `lexical-binding' (bug#8460).
4312 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4314 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4315 bidi redisplay when a line includes both an image and is truncated.
4317 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4319 Fix minor problems found by static checking.
4320 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4321 (elsz): Now a signed constant, not a size_t var. We prefer signed
4322 types to unsigned, to avoid integer comparison confusion. Without
4323 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4324 "cannot optimize loop, the loop counter may overflow", a symptom
4326 * indent.c (Fvertical_motion): Mark locals as initialized.
4327 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4329 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4331 * search.c (Fre_search_backward): Mention `case-fold-search' in
4332 all the re_search_* functions (bug#8138).
4334 * keyboard.c (Fopen_dribble_file): Document when the file is
4337 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4339 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4342 Support bidi reordering of display and overlay strings.
4343 * xdisp.c (compute_display_string_pos)
4344 (compute_display_string_end): Accept additional argument STRING.
4345 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4346 (reseat_to_string): Initialize bidi_it->string.s and
4347 bidi_it->string.schars.
4348 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4349 NULL (avoids a crash in bidi_paragraph_init).
4350 Initialize itb.string.lstring.
4351 (init_iterator): Call bidi_init_it only of a valid
4352 buffer position was specified. Initialize paragraph_embedding to
4354 (reseat_to_string): Initialize the bidi iterator.
4355 (display_string): If we need to ignore text properties of
4356 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4357 original value of -1 will not work with bidi.)
4358 (compute_display_string_pos): First arg is now struct
4359 `text_pos *'; all callers changed. Support display properties on
4361 (compute_display_string_end): Support display properties on Lisp
4363 (init_iterator, reseat_1, reseat_to_string): Initialize the
4364 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4365 when iterating on a string not from display properties).
4366 (compute_display_string_pos, compute_display_string_end):
4367 Fix calculation of the object to scan. Fixes an error when using
4369 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4370 base_level_stop; instead, set base_level_stop to BEGV.
4371 Fixes crashes in vertical-motion.
4372 (next_element_from_buffer): Improve commentary for when
4373 the iterator is before prev_stop.
4374 (init_iterator): Initialize bidi_p from the default value of
4375 bidi-display-reordering, not from buffer-local value. Use the
4376 buffer-local value only if initializing for buffer iteration.
4377 (handle_invisible_prop): Support invisible properties on strings
4378 that are being bidi-reordered.
4379 (set_iterator_to_next): Support bidi reordering of C strings and
4381 (next_element_from_string): Support bidi reordering of Lisp
4383 (handle_stop_backwards): Support Lisp strings as well.
4384 (display_string): Support display of R2L glyph rows.
4385 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4386 (init_iterator): Don't initialize it->bidi_p for strings
4388 (reseat_to_string): Initialize it->bidi_p for strings here.
4389 (next_element_from_string, next_element_from_c_string)
4390 (next_element_from_buffer): Add xassert's for correspondence
4391 between IT's object being iterated and it->bidi_it.string
4393 (face_before_or_after_it_pos): Support bidi iteration.
4394 (next_element_from_c_string): Handle the case of the first string
4395 character that is not the first one in the visual order.
4396 (get_visually_first_element): New function, refactored from common
4397 parts of next_element_from_buffer, next_element_from_string, and
4398 next_element_from_c_string.
4399 (tool_bar_lines_needed, redisplay_tool_bar)
4400 (display_menu_bar): Force left-to-right direction. Add a FIXME
4401 comment for making that be controlled by a user option.
4402 (push_it, pop_it): Save and restore the state of the
4403 bidi iterator. Save and restore the bidi_p flag.
4404 (pop_it): Iterate out of display property for string iteration as
4406 (iterate_out_of_display_property): Support iteration over strings.
4407 (handle_single_display_spec): Set up it->bidi_it for iteration
4408 over a display string, and call bidi_init_it.
4409 (handle_single_display_spec, next_overlay_string)
4410 (get_overlay_strings_1, push_display_prop): Set up the bidi
4411 iterator for displaying display or overlay strings.
4412 (forward_to_next_line_start): Don't use the shortcut if
4414 (back_to_previous_visible_line_start): If handle_display_prop
4415 pushed the iterator stack, restore the internal state of the bidi
4416 iterator by calling bidi_pop_it same number of times.
4417 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4418 and we are bidi-iterating, don't decrement the iterator position;
4419 instead, set the first_elt flag in the bidi iterator, to produce
4421 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4422 (push_display_prop): xassert that we are iterating a buffer.
4423 (push_it, pop_it): Save and restore paragraph_embedding member.
4424 (handle_single_display_spec, next_overlay_string)
4425 (get_overlay_strings_1, reseat_1, reseat_to_string)
4426 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4427 correctly. Don't assume unibyte strings are not bidi-reordered.
4428 (compute_display_string_pos)
4429 (compute_display_string_end): Fix handling the case of C string.
4430 (push_it, pop_it): Save and restore from_disp_prop_p.
4431 (handle_single_display_spec, push_display_prop): Set the
4432 from_disp_prop_p flag.
4433 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4434 (pop_it): Call iterate_out_of_display_property only if we are
4435 popping after iteration over a string that came from a display
4436 property. Fix a typo in popping stretch info. Add an assertion
4437 for verifying that the iterator position is in sync with the bidi
4439 (handle_single_display_spec, get_overlay_strings_1)
4440 (push_display_prop): Fix initialization of paragraph direction for
4441 string when that of the parent object is not yet determined.
4442 (reseat_1): Call bidi_init_it to resync the bidi
4443 iterator with IT's position. (Bug#7616)
4444 (find_row_edges): If ROW->start.pos gives position
4445 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4446 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4447 Reset the from_disp_prop_p flag.
4448 (SAVE_IT, RESTORE_IT): New macros.
4449 (pos_visible_p, face_before_or_after_it_pos)
4450 (back_to_previous_visible_line_start)
4451 (move_it_in_display_line_to, move_it_in_display_line)
4452 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4453 (try_scrolling, redisplay_window, display_line): Use them when
4454 saving a temporary copy of the iterator and restoring it back.
4455 (back_to_previous_visible_line_start, reseat_1)
4456 (init_iterator): Empty the bidi cache "stack".
4457 (move_it_in_display_line_to): If iterator ended up at
4458 EOL, but we never saw any buffer positions smaller than
4459 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4460 motion in bidi-reordered lines.
4461 (move_it_in_display_line_to): Record prev_method and prev_pos
4462 immediately before the call to set_iterator_to_next. Fixes cursor
4463 motion in bidi-reordered lines with stretch glyphs and strings
4464 displayed in margins. (Bug#8133) (Bug#8867)
4465 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4467 (pos_visible_p): Support positions in bidi-reordered lines.
4468 Save and restore bidi cache.
4470 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4471 (bidi_paragraph_info): Delete unused struct.
4472 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4473 (bidi_cache_start): New variable.
4474 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4476 (bidi_cache_fetch_state, bidi_cache_search)
4477 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4478 (bidi_cache_find, bidi_peek_at_next_level)
4479 (bidi_level_of_next_char, bidi_find_other_level_edge)
4480 (bidi_move_to_visually_next): Compare cache index with
4481 bidi_cache_start rather than with zero.
4482 (bidi_fetch_char): Accept new argument STRING; all callers
4483 changed. Support iteration over a string. Support strings with
4484 display properties. Support unibyte strings. Fix the type of
4485 `len' according to what STRING_CHAR_AND_LENGTH expects.
4486 (bidi_paragraph_init, bidi_resolve_explicit_1)
4487 (bidi_resolve_explicit, bidi_resolve_weak)
4488 (bidi_level_of_next_char, bidi_move_to_visually_next):
4489 Support iteration over a string.
4490 (bidi_set_sor_type, bidi_resolve_explicit_1)
4491 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4492 can now be zero (for strings); special values 0 and -1 were
4493 changed to -1 and -2, respectively.
4494 (bidi_char_at_pos): New function.
4495 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4496 Call it instead of FETCH_MULTIBYTE_CHAR.
4497 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4498 initialized to valid values.
4499 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4501 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4502 the test for valid cached positions. Fix the logic for looking up
4503 the sentinel state in the cache. GCPRO the Lisp string we are
4505 (bidi_push_it, bidi_pop_it): New functions.
4506 (bidi_initialize): Initialize the bidi cache start stack pointer.
4507 (bidi_cache_ensure_space): New function, refactored from part of
4508 bidi_cache_iterator_state. Don't assume the required size is just
4509 one BIDI_CACHE_CHUNK away.
4510 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4511 (bidi_count_bytes, bidi_char_at_pos): New functions.
4512 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4513 always valid if bidi_cache_idx is valid.
4514 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4515 is valid if it's going to be used.
4516 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4517 (bidi_cache_fetch_state, bidi_cache_search)
4518 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4519 (bidi_cache_iterator_state, bidi_cache_find)
4520 (bidi_find_other_level_edge, bidi_cache_start_stack):
4521 All variables related to cache indices are now EMACS_INT.
4523 * dispextern.h (struct bidi_string_data): New structure.
4524 (struct bidi_it): New member `string'. Make flag members be 1-bit
4525 fields, and put them last in the struct.
4526 (compute_display_string_pos, compute_display_string_end):
4528 (bidi_push_it, bidi_pop_it): Add prototypes.
4529 (struct iterator_stack_entry): New members bidi_p,
4530 paragraph_embedding, and from_disp_prop_p.
4531 (struct it): Member bidi_p is now a bit field 1 bit wide.
4532 (bidi_shelve_cache, bidi_unshelve_cache):
4535 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4536 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4537 and vector-like objects.
4539 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4540 cache around display iteration.
4542 * window.c (Fwindow_end, window_scroll_pixel_based)
4543 (displayed_window_lines, Frecenter): Save and restore the bidi
4544 cache around display iteration.
4546 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4548 * editfns.c (Fdelete_region): Clarify the use of the named
4549 parameters (bug#6788).
4551 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4553 * indent.c (Fvertical_motion): Set and restore w->pointm when
4554 saving and restoring the window's buffer (Bug#9006).
4556 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4558 * editfns.c (Fstring_to_char): Clarify just what is returned
4559 (bug#6576). Text by Eli Zaretskii.
4561 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4563 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4565 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4567 * buffer.c (mmap_find): Fix a typo.
4569 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4571 Fix execution of x selection hooks.
4572 * xselect.c (Qx_lost_selection_functions)
4573 (Qx_sent_selection_functions): New vars.
4574 (syms_of_xselect): DEFSYM them.
4575 (x_handle_selection_request): Pass Qx_sent_selection_functions
4576 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4577 (x_handle_selection_clear,x_clear_frame_selections):
4578 Pass Qx_lost_selection_functions rather than
4579 Vx_lost_selection_functions to Frun_hook_with_args.
4581 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4583 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4584 The old code sometimes used this field without initializing it.
4586 * alloc.c (gc_sweep): Don't read past end of array.
4587 In theory, the old code could also have corrupted Emacs internals,
4588 though it'd be very unlikely.
4590 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4592 * character.c (Fcharacterp): Don't advertise optional ignored
4593 argument. (Bug#4026)
4595 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4597 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4600 * window.c (Fset_window_start): Doc fix (bug#4199).
4601 (Fset_window_hscroll): Ditto.
4603 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4605 Fix minor new problems caught by GCC 4.6.1.
4606 * term.c (init_tty): Remove unused local.
4607 * xsettings.c (store_monospaced_changed): Define this function only
4608 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4611 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4613 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4615 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4617 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4618 are the mini-buffer and the echo area (bug#3320).
4620 * term.c (init_tty): Remove support for supdup, c10 and perq
4621 terminals, which are no longer supported (bug#1482).
4623 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4625 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4627 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4629 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4630 for non-popups (Bug#3642).
4632 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4634 * alloc.c (reset_malloc_hooks): Protoize.
4635 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4636 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4637 * cm.c (losecursor): Likewise.
4638 * data.c (fmod): Likewise.
4639 * dispnew.c (swap_glyphs_in_rows): Likewise.
4640 * emacs.c (memory_warning_signal): Likewise.
4641 * floatfns.c (float_error): Likewise.
4642 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4643 (otf_open, font_otf_capability, generate_otf_features)
4644 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4646 * image.c (pbm_read_file): Likewise.
4647 * indent.c (string_display_width): Likewise.
4648 * intervals.c (check_for_interval, search_for_interval)
4649 (inc_interval_count, count_intervals, root_interval)
4650 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4651 * lread.c (defalias): Likewise.
4652 * ralloc.c (r_alloc_check): Likewise.
4653 * regex.c (set_image_of_range_1, set_image_of_range)
4654 (regex_grow_registers): Likewise.
4655 * sysdep.c (strerror): Likewise.
4656 * termcap.c (valid_filename_p, tprint, main): Likewise.
4657 * tparam.c (main): Likewise.
4658 * unexhp9k800.c (run_time_remap, save_data_space)
4659 (update_file_ptrs, read_header, write_header, calculate_checksum)
4660 (copy_file, copy_rest, display_header): Likewise.
4661 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4663 * xdisp.c (check_it): Likewise.
4664 * xfaces.c (register_color, unregister_color, unregister_colors):
4666 * xfns.c (print_fontset_result): Likewise.
4667 * xrdb.c (member, fatal, main): Likewise.
4669 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4671 Fix minor problems found by static checking (Bug#9031).
4672 * chartab.c (char_table_set_range, map_sub_char_table):
4673 Remove unused locals.
4674 (uniprop_table): Now static.
4675 * composite.c (_work_char): Remove unused static var.
4677 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4679 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4681 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4683 * gtkutil.c (qttip_cb): Remove code without function.
4685 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4687 * w32.c (pthread_sigmask): New stub.
4689 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4691 Use pthread_sigmask, not sigprocmask (Bug#9010).
4692 sigprocmask is portable only for single-threaded applications, and
4693 Emacs can be multi-threaded when it uses GTK.
4694 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4696 * callproc.c (Fcall_process):
4697 * process.c (create_process):
4698 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4699 Use pthread_sigmask, not sigprocmask.
4701 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4703 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4704 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4707 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4709 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4710 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4711 (xg_hide_tooltip): Fix comment.
4713 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4714 in registerServicesMenuSendTypes.
4715 (validRequestorForSendType): Don't check ns_return_types.
4717 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4720 2011-07-08 Jason Rumney <jasonr@gnu.org>
4722 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4723 SH_SHOW for hidden windows (Bug#5482).
4725 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4726 frame struct members of non-existent frames (Bug#6284).
4728 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4730 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4731 variable firstTime not needed on OSX >= 10.6.
4732 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4733 >= 10.5. Use setKnobProportion, setDoubleValue.
4735 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4736 (MAC_OS_X_VERSION_10_5): Define if not defined.
4737 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4738 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4739 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4741 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4742 cString and lossyCString on OSX >= 10.4
4744 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4745 sizeToFit on OSX >= 10.2.
4747 * nsimage.m (allocInitFromFile): Don't use deprecated method
4748 bestRepresentationForDevice on OSX >= 10.6.
4750 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4753 * emacs.c: Declare unexec_init_emacs_zone.
4755 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4757 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4759 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4760 on svcsMenu (Bug#8842).
4762 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4764 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4766 * nsterm.m (QUTF8_STRING): Declare.
4767 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4768 (validRequestorForSendType): Return type is (id).
4769 Change indexOfObjectIdenticalTo to indexOfObject.
4770 Check if we have local selection before returning self (Bug#8842).
4771 (writeSelectionToPasteboard): Put local selection into paste board
4772 if we have a local selection (Bug#8842).
4773 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4775 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4776 (ns_get_local_selection): Declare.
4778 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4780 * keymap.c (describe_map_tree): Don't insert a double newline at
4781 the end of the buffer (bug#1169) and return whether we inserted
4784 * callint.c (Fcall_interactively): Change "reading args" to
4785 "providing args" to try to clarify what it does (bug#1010).
4787 2011-07-07 Kenichi Handa <handa@m17n.org>
4789 * composite.c (composition_compute_stop_pos): Ignore a static
4790 composition starting before CHARPOS (Bug#8915).
4792 * xdisp.c (handle_composition_prop): Likewise.
4794 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4796 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4799 2011-07-07 Kenichi Handa <handa@m17n.org>
4801 * character.h (unicode_category_t): New enum type.
4803 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4804 (Qchar_code_property_table): New variable.
4805 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4806 (UNIPROP_COMPRESSED_FORM_P): New macros.
4807 (char_table_ascii): Uncompress the compressed values.
4808 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4809 Uncompress the compressed values.
4810 (sub_char_table_ref_and_range): Likewise.
4811 (char_table_ref_and_range): Uncompress the compressed values.
4812 (sub_char_table_set): New arg is_uniprop. Callers changed.
4813 Uncompress the compressed values.
4814 (sub_char_table_set_range): Args changed. Callers changed.
4815 (char_table_set_range): Adjuted for the above change.
4816 (map_sub_char_table): Delete args default_val and parent. Add arg
4817 top. Give decoded values to a Lisp function.
4818 (map_char_table): Adjust for the above change. Give decoded
4819 values to a Lisp function. Gcpro more variables.
4820 (uniprop_table_uncompress)
4821 (uniprop_decode_value_run_length): New functions.
4822 (uniprop_decoder, uniprop_decoder_count): New variables.
4823 (uniprop_get_decoder, uniprop_encode_value_character)
4824 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4826 (uniprop_encoder, uniprop_encoder_count): New variables.
4827 (uniprop_get_encoder, uniprop_table)
4828 (Funicode_property_table_internal, Fget_unicode_property_internal)
4829 (Fput_unicode_property_internal): New functions.
4830 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4831 Sunicode_property_table_internal, Sget_unicode_property_internal,
4832 and Sput_unicode_property_internal. Defvar_lisp
4833 char-code-property-alist.
4835 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4836 Vunicode_category_table.
4838 * font.c (font_range): Adjust for the change of
4839 Vunicode_category_table.
4841 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4843 * m/iris4d.h: Remove file, move contents ...
4844 * s/irix6-5.h: ... here.
4846 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4848 Remove unportable assumption about struct layout (Bug#8884).
4849 * alloc.c (mark_buffer):
4850 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4851 (clone_per_buffer_values): Don't assume that
4852 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4853 This isn't true in general, and it's particularly not true
4854 if Emacs is configured with --with-wide-int.
4855 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4856 New macros, used in the buffer.c change.
4858 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4860 * xsettings.c: Use both GConf and GSettings if both are available.
4861 (store_config_changed_event): Add comment.
4862 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4863 (store_tool_bar_style_changed): New functions.
4864 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4865 (struct xsettings): Move font inside HAVE_XFT.
4866 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4867 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4868 Move inside HAVE_XFT.
4869 (something_changed_gsettingsCB): Rename from something_changedCB.
4870 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4872 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4873 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4874 (something_changed_gconfCB): Rename from something_changedCB.
4875 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4876 (parse_settings): Move check for font inside HAVE_XFT.
4877 (read_settings, apply_xft_settings): Add comment.
4878 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4879 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4880 call store_font_name_changed.
4881 (xft_settings_event): Add comment.
4882 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4883 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4884 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4885 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4886 (xsettings_initialize): Call init_gsettings last.
4887 (xsettings_get_system_font, xsettings_get_system_normal_font):
4890 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4892 Random fixes. E.g., (random) never returned negative values.
4893 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4894 subseconds part to the entropy, as that's a bit more random.
4895 Prefer signed to unsigned, since the signedness doesn't matter and
4896 in general we prefer signed. When given a limit, use a
4897 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4898 latter isn't right if USE_2_TAGS_FOR_INTS.
4899 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4900 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4902 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4904 * textprop.c (text_property_stickiness):
4905 Obey Vtext_property_default_nonsticky.
4906 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4907 * w32fns.c (syms_of_w32fns):
4908 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4910 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4912 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4913 This is more efficient than Ffile_directory_p and avoids a minor race.
4915 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4917 * buffer.c (Foverlay_put): Say what the return value is
4920 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4921 is a directory before asking whether to use the file name
4923 (barf_or_query_if_file_exists): Make the "File is a directory"
4924 error be more correct.
4926 * fns.c (Frequire): Remove the mention of the .gz files, since
4927 that's installation-specific, but keep the mention of
4928 `get-load-suffixes'.
4930 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4932 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4933 Report string overflow if the output is too long.
4935 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4937 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4938 (syms_of_gnutls): Remove duplicate DEFSYM for
4939 Qgnutls_bootprop_verify_hostname_error, an error for
4940 Qgnutls_bootprop_verify_error (which is no longer used).
4942 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4943 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4944 Also (re)move comments that are misplaced or no longer relevant.
4946 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4948 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4950 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4952 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4953 and background color parameters if they have been changed.
4955 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4957 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4959 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4961 * xsettings.c (SYSTEM_FONT): Define only when used.
4962 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4964 * keymap.c (access_keymap_1): Now static.
4966 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4968 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4969 leave any prefix arg for the up event (Bug#1586).
4971 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4973 * lread.c (syms_of_lread): Mention single symbols defined by
4974 `defvar' or `defconst' (bug#7154).
4976 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4977 (Frequire): Mention get-load-suffixes.
4979 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4981 * window.h (window): Remove clone_number slot.
4982 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4984 (make_parent_window, make_window, saved_window)
4985 (Fset_window_configuration, save_window_save): Don't deal with
4987 * buffer.c (Qclone_number): Remove declaration.
4988 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4990 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4992 Add multiple inheritance to keymaps.
4993 * keymap.c (Fmake_composed_keymap): New function.
4994 (Fset_keymap_parent): Simplify.
4995 (fix_submap_inheritance): Remove.
4996 (access_keymap_1): New function extracted from access_keymap to handle
4997 embedded parents and handle lists of maps.
4998 (access_keymap): Use it.
4999 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5000 (Fcopy_keymap): Handle embedded parents.
5001 (Fcommand_remapping, define_as_prefix): Simplify.
5002 (Fkey_binding): Simplify.
5003 (syms_of_keymap): Move minibuffer-local-completion-map,
5004 minibuffer-local-filename-completion-map,
5005 minibuffer-local-must-match-map, and
5006 minibuffer-local-filename-must-match-map to Elisp.
5007 (syms_of_keymap): Defsubr make-composed-keymap.
5008 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5009 (parse_menu_item): Trivial simplification.
5011 2011-07-01 Glenn Morris <rgm@gnu.org>
5013 * Makefile.in (SETTINGS_LIBS): Fix typo.
5015 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5017 * coding.c (Fencode_coding_string): Record the last coding system
5018 used, as the function doc string says (bug#8738).
5020 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5022 * xsettings.c (store_monospaced_changed): Take new font as arg and
5023 check for change against current_mono_font.
5024 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5025 (emacs_settings_constructor, emacs_settings_get_property)
5026 (emacs_settings_set_property, emacs_settings_class_init)
5027 (emacs_settings_init, gsettings_obj): Remove.
5028 (something_changedCB): New function for HAVE_GSETTINGS.
5029 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5030 with value as argument.
5031 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5032 g_settings_new (Bug#8967). Do not create gsettings_obj.
5033 Remove calls to g_settings_bind. Connect something_changedCB to
5036 * xgselect.c: Add defined (HAVE_GSETTINGS).
5037 (xgselect_initialize): Ditto.
5039 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5040 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5043 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5045 * eval.c (struct backtrace): Simplify and port the data structure.
5046 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5047 signed bit field, as this assumption is not portable and it makes
5048 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5049 "char debug_on_exit : 1" as this is not portable either; instead,
5050 use the portable "unsigned int debug_on_exit : 1". Remove unused
5051 member evalargs. Remove obsolete comments about cc bombing out.
5053 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5055 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
5056 Let HAVE_GSETTINGS override HAVE_GCONF.
5057 (store_monospaced_changed): New function.
5058 (EMACS_SETTINGS): A new type derived from GObject to handle
5059 GSettings notifications.
5060 (emacs_settings_constructor, emacs_settings_get_property)
5061 (emacs_settings_set_property, emacs_settings_class_init):
5063 (gsettings_client, gsettings_obj): New variables.
5064 (GSETTINGS_SCHEMA): New define.
5065 (something_changedCB): Call store_monospaced_changed.
5066 (init_gsettings): New function.
5067 (xsettings_initialize): Call init_gsettings.
5068 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5071 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
5074 2011-06-29 Martin Rudalics <rudalics@gmx.at>
5076 * window.c (resize_root_window, grow_mini_window)
5077 (shrink_mini_window): Rename Qresize_root_window to
5078 Qwindow_resize_root_window and Qresize_root_window_vertically to
5079 Qwindow_resize_root_window_vertically.
5081 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5083 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5085 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
5087 * makefile.w32-in: Redesign dependencies so they reflect more
5088 clearly which files are directly included by each source file,
5089 and not through other includes.
5091 2011-06-27 Martin Rudalics <rudalics@gmx.at>
5093 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5094 (sort_overlays, overlay_strings): When an overlay's clone number
5095 matches the window's clone number process the overlay even if
5096 the overlay's window property doesn't match the current window.
5098 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5099 (Fwindow_hchild): Rename to Fwindow_left_child.
5100 (Fwindow_next): Rename to Fwindow_next_sibling.
5101 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5102 (resize_window_check): Rename to window_resize_check.
5103 (resize_window_apply): Rename to window_resize_apply.
5104 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5105 (Fdelete_other_windows_internal, resize_frame_windows)
5106 (Fsplit_window_internal, Fdelete_window_internal)
5107 (grow_mini_window, shrink_mini_window)
5108 (Fresize_mini_window_internal): Fix callers accordingly.
5110 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5112 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5113 (emacs_fixed_set_min_size): Remove.
5114 (emacs_fixed_new): Take frame as argument.
5116 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5117 (_EmacsFixedPrivate): Remove minwidth/height.
5118 Add struct frame *f.
5119 (emacs_fixed_init): Initialize priv->f.
5120 (get_parent_class, emacs_fixed_set_min_size): Remove.
5121 (emacs_fixed_new): Set priv->f to argument.
5122 (emacs_fixed_get_preferred_width)
5123 (emacs_fixed_get_preferred_height): Use min_width/height from
5124 frames size_hint to set minimum and natural (Bug#8919).
5125 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5126 and use min_width/height from frames size_hint to set
5127 min_width/height (Bug#8919).
5129 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5130 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5133 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5135 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5136 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5139 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5141 * process.c (wait_reading_process_output): Bypass select if
5142 waiting for a cell while ignoring keyboard input, and input is
5143 pending. Suggested by Jan Djärv (Bug#8869).
5145 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5147 Use gnulib's dup2 module instead of rolling our own.
5148 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5150 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5152 * dispnew.c (scrolling_window): Before scrolling, turn off a
5153 mouse-highlight in the window being scrolled.
5155 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5157 Move DEFSYM to lisp.h and use everywhere.
5159 * character.h (DEFSYM): Move declaration...
5160 * lisp.h (DEFSYM): ...here.
5166 * w32select.c: Don't include character.h.
5168 * alloc.c (syms_of_alloc):
5169 * buffer.c (syms_of_buffer):
5170 * bytecode.c (syms_of_bytecode):
5171 * callint.c (syms_of_callint):
5172 * casefiddle.c (syms_of_casefiddle):
5173 * casetab.c (init_casetab_once):
5174 * category.c (init_category_once, syms_of_category):
5175 * ccl.c (syms_of_ccl):
5176 * cmds.c (syms_of_cmds):
5177 * composite.c (syms_of_composite):
5178 * dbusbind.c (syms_of_dbusbind):
5179 * dired.c (syms_of_dired):
5180 * dispnew.c (syms_of_display):
5181 * doc.c (syms_of_doc):
5182 * editfns.c (syms_of_editfns):
5183 * emacs.c (syms_of_emacs):
5184 * eval.c (syms_of_eval):
5185 * fileio.c (syms_of_fileio):
5186 * fns.c (syms_of_fns):
5187 * frame.c (syms_of_frame):
5188 * fringe.c (syms_of_fringe):
5189 * insdel.c (syms_of_insdel):
5190 * keymap.c (syms_of_keymap):
5191 * lread.c (init_obarray, syms_of_lread):
5192 * macros.c (syms_of_macros):
5193 * msdos.c (syms_of_msdos):
5194 * print.c (syms_of_print):
5195 * process.c (syms_of_process):
5196 * search.c (syms_of_search):
5197 * sound.c (syms_of_sound):
5198 * syntax.c (init_syntax_once, syms_of_syntax):
5199 * terminal.c (syms_of_terminal):
5200 * textprop.c (syms_of_textprop):
5201 * undo.c (syms_of_undo):
5202 * w32.c (globals_of_w32):
5203 * window.c (syms_of_window):
5204 * xdisp.c (syms_of_xdisp):
5205 * xfaces.c (syms_of_xfaces):
5206 * xfns.c (syms_of_xfns):
5207 * xmenu.c (syms_of_xmenu):
5208 * xsettings.c (syms_of_xsettings):
5209 * xterm.c (syms_of_xterm): Use DEFSYM.
5211 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5213 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5215 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5217 Integer and buffer overflow fixes (Bug#8873).
5219 * print.c (printchar, strout): Check for string overflow.
5220 (PRINTPREPARE, printchar, strout):
5221 Don't set size unless allocation succeeds.
5223 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5224 for sizes. Check for string overflow more accurately.
5225 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5227 * macros.c: Integer and buffer overflow fixes.
5228 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5229 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5230 Use ptrdiff_t, not int, for sizes.
5231 Don't increment bufsize until after realloc succeeds.
5232 Check for size-calculation overflow.
5233 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5235 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5237 * lread.c: Integer overflow fixes.
5238 (read_integer): Radix is now EMACS_INT, not int,
5239 to improve quality of diagnostics for out-of-range radices.
5240 Calculate buffer size correctly for out-of-range radices.
5241 (read1): Check for integer overflow in radices, and in
5242 read-circle numbers.
5243 (read_escape): Avoid int overflow.
5244 (Fload, openp, read_buffer_size, read1)
5245 (substitute_object_recurse, read_vector, read_list, map_obarray):
5246 Use ptrdiff_t, not int, for sizes.
5247 (read1): Use EMACS_INT, not int, for sizes.
5248 Check for size overflow.
5250 * image.c (cache_image): Check for size arithmetic overflow.
5252 * lread.c: Integer overflow issues.
5253 (saved_doc_string_size, saved_doc_string_length)
5254 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5255 Now ptrdiff_t, not int.
5256 (read1): Don't assume doc string length fits in int. Check for
5257 out-of-range doc string lengths.
5258 (read_list): Don't assume file position fits in int.
5259 (read_escape): Check for hex character overflow.
5261 2011-06-22 Leo Liu <sdl.web@gmail.com>
5263 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5264 Move to minibuffer.el.
5266 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5268 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5269 The following patches are for when GLYPH_DEBUG && !XASSERT.
5270 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5271 * dispnew.c (flush_stdout):
5272 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5273 Mark as externally visible.
5274 * dispnew.c (check_window_matrix_pointers): Now static.
5275 * dispnew.c (window_to_frame_vpos):
5276 * xfns.c (unwind_create_frame):
5277 * xterm.c (x_check_font): Remove unused local.
5278 * scroll.c (CHECK_BOUNDS):
5279 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5280 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5281 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5282 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5283 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5285 (debug_method_add): Use va_list and vsprintf rather than relying
5286 on undefined behavior with wrong number of arguments.
5287 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5288 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5289 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5290 since we're not interested in debugging glyphs with old libraries.
5291 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5292 GCC 4.6.0's static checking.
5294 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5296 Integer overflow and signedness fixes (Bug#8873).
5297 A few related buffer overrun fixes, too.
5299 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5301 * dispextern.h (struct face.stipple):
5302 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5303 (x_bitmap_mask, x_allocate_bitmap_record)
5304 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5305 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5306 (x_create_bitmap_from_xpm_data):
5307 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5308 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5310 * xfaces.c (load_pixmap):
5311 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5312 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5313 (.bitmaps_last, struct x_output.icon_bitmap):
5314 Use ptrdiff_t, not int, for bitmap indexes.
5315 (x_allocate_bitmap_record): Check for size overflow.
5316 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5318 Use ptrdiff_t, not int, for overlay counts.
5319 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5320 * editfns.c (overlays_around, get_pos_property):
5321 * textprop.c (get_char_property_and_overlay):
5322 * xdisp.c (next_overlay_change, note_mouse_highlight):
5323 * xfaces.c (face_at_buffer_position):
5324 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5325 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5326 (Fnext_overlay_change, Fprevious_overlay_change)
5327 (mouse_face_overlay_overlaps, Foverlays_in):
5328 Use ptrdiff_t, not int, for sizes.
5329 (overlays_at, overlays_in): Check for size-calculation overflow.
5331 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5333 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5334 (x_session_initialize): Do not assume string length fits in int.
5336 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5337 This is unlikely, but can occur if DPI is outlandish.
5339 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5340 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5342 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5343 * xrdb.c (magic_file_p, search_magic_path):
5344 Omit last arg SUFFIX; it was always 0. All callers changed.
5345 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5347 * xfont.c (xfont_match): Avoid need for strlen.
5349 * xfns.c: Don't assume strlen fits in int.
5350 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5352 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5353 not unsigned long, as we prefer signed integers. All callers changed.
5354 Detect integer overflow in repeat count.
5355 (message_dolog): Don't assume print length fits in 39 bytes.
5356 (display_mode_element): Don't assume strlen fits in int.
5358 * termcap.c: Don't assume sizes fit in int and never overflow.
5359 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5360 (gobble_line): Check for size-calculation overflow.
5362 * minibuf.c (Fread_buffer):
5363 * lread.c (intern, intern_c_string):
5364 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5365 Don't assume string length fits in int.
5367 * keyboard.c (parse_tool_bar_item):
5368 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5370 * font.c: Don't assume string length fits in int.
5371 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5372 Use ptrdiff_t, not int.
5373 (font_intern_prop): Don't assume string length fits in int.
5374 Don't assume integer property fits in fixnum.
5375 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5377 * filelock.c: Fix some buffer overrun and integer overflow issues.
5378 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5379 Reformulate so as not to need the command string.
5380 Invoke gzip -cd rather than gunzip, as it's more portable.
5381 (lock_info_type, lock_file_1, lock_file):
5382 Don't assume pid_t and time_t fit in unsigned long.
5383 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5384 (current_lock_owner): Prefer signed type for sizes.
5385 Use memcpy, not strncpy, where memcpy is what is really wanted.
5386 Don't assume (via atoi) that time_t and pid_t fit in int.
5387 Check for time_t and/or pid_t out of range, e.g., via a network share.
5388 Don't alloca where an auto var works fine.
5390 * fileio.c: Fix some integer overflow issues.
5391 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5392 Don't assume string length fits in int.
5393 (directory_file_name): Don't assume string length fits in long.
5394 (make_temp_name): Don't assume pid fits in int, or that its print
5395 length is less than 20.
5397 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5399 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5401 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5403 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5404 We prefer signed integers, even for size calculations.
5406 * emacs.c: Don't assume string length fits in 'int'.
5407 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5408 (main): Don't invoke strlen when not needed.
5410 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5411 (XD_DEBUG_MESSAGE): Don't waste a byte.
5413 * callproc.c (getenv_internal_1, getenv_internal)
5415 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5417 * lread.c (invalid_syntax): Omit length argument.
5418 All uses changed. This doesn't fix a bug, but it simplifies the
5419 code away from its former Hollerith-constant appearance, and it's
5420 one less 'int' to worry about when looking at integer-overflow issues.
5421 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5423 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5424 This didn't break anything, but it didn't help either.
5425 It's confusing to put a bogus integer in a place where the actual
5426 value does not matter.
5427 (LIST_END_P): Remove unused macro and its bogus comment.
5428 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5430 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5431 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5433 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5434 We prefer signed types, and the value cannot exceed the EMACS_INT
5435 range anyway (because otherwise the length would not be representable).
5436 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5437 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5438 This avoids a GCC warning when WIDE_EMACS_INT.
5440 * indent.c (sane_tab_width): New function.
5441 (current_column, scan_for_column, Findent_to, position_indentation)
5442 (compute_motion): Use it. This is just for clarity.
5443 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5445 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5447 * lisp.h (lint_assume): New macro.
5448 * composite.c (composition_gstring_put_cache):
5449 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5451 * editfns.c, insdel.c:
5452 Omit unnecessary forward decls, to simplify future changes.
5454 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5456 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5458 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5459 Use much-faster test for byte-length change.
5460 Don't assume string byte-length fits in 'int'.
5461 Check that character arg fits in 'int'.
5462 (mapcar1): Declare byte as byte, for clarity.
5464 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5466 * fns.c (concat): Catch string overflow earlier.
5467 Do not rely on integer wraparound.
5469 * dispextern.h (struct it.overlay_strings_charpos)
5470 (struct it.selective): Now EMACS_INT, not int.
5471 * xdisp.c (forward_to_next_line_start)
5472 (back_to_previous_visible_line_start)
5473 (reseat_at_next_visible_line_start, next_element_from_buffer):
5474 Don't arbitrarily truncate the value of 'selective' to int.
5476 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5478 * composite.c: Don't truncate sizes to 'int'.
5479 (composition_gstring_p, composition_reseat_it)
5480 (composition_adjust_point): Use EMACS_INT, not int.
5481 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5482 not EMACS_UINT, for indexes.
5484 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5486 * buffer.c: Include <verify.h>.
5487 (struct sortvec.priority, struct sortstr.priority):
5488 Now EMACS_INT, not int.
5489 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5490 (struct sortstr.size, record_overlay_string)
5491 (struct sortstrlist.size, struct sortlist.used):
5492 Don't truncate size to int.
5493 (record_overlay_string): Check for size-calculation overflow.
5494 (init_buffer_once): Check at compile-time, not run-time.
5496 2011-06-22 Jim Meyering <meyering@redhat.com>
5498 Don't leak an XBM-image-sized buffer
5499 * image.c (xbm_load): Free the image buffer after using it.
5501 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5504 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5505 that Sun C diagnosed.
5506 * fns.c (secure_hash): Fix pointer signedness issue.
5507 * intervals.c (static_offset_intervals): New function.
5508 (offset_intervals): Use it.
5510 2011-06-21 Leo Liu <sdl.web@gmail.com>
5513 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5516 * fns.c (secure_hash): Rename from crypto_hash_function and change
5517 the first arg to accept symbols.
5518 (Fsecure_hash): New primitive.
5519 (syms_of_fns): New symbols.
5521 2011-06-20 Deniz Dogan <deniz@dogan.se>
5523 * process.c (Fset_process_buffer): Clarify return value in
5526 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5528 * dispnew.c (add_window_display_history): Use BVAR.
5530 * xdisp.c (debug_method_add): Use BVAR.
5531 (check_window_end, dump_glyph_matrix, dump_glyph)
5532 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5534 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5537 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5538 check till after the cache is created in init_frame_faces.
5540 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5542 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5544 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5546 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5547 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5548 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5550 Improve buffer-overflow checking (Bug#8873).
5551 * fileio.c (Finsert_file_contents):
5552 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5553 Remove the old (too-loose) buffer overflow checks.
5554 They weren't needed, since make_gap checks for buffer overflow.
5555 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5556 The old code merely checked for Emacs fixnum overflow, and relied
5557 on undefined (wraparound) behavior. The new code avoids undefined
5558 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5560 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5561 Tune. Don't use wider integers than needed. Don't use alloca.
5562 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5564 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5566 * insdel.c, lisp.h (buffer_overflow): New function.
5567 (insert_from_buffer_1, replace_range, replace_range_2):
5568 * insdel.c (make_gap_larger):
5569 * editfns.c (Finsert_char):
5570 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5572 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5574 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5576 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5578 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5579 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5581 * fileio.c: Don't assume EMACS_INT fits in off_t.
5582 (emacs_lseek): New static function.
5583 (Finsert_file_contents, Fwrite_region): Use it.
5584 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5586 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5588 * fns.c: Don't overflow int when computing a list length.
5589 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5590 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5591 truncation on 64-bit hosts. Check for QUIT every
5592 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5593 faster and is responsive enough.
5594 (Flength): Report an error instead of overflowing an integer.
5595 (Fsafe_length): Return a float if the value is not representable
5596 as a fixnum. This shouldn't happen except in contrived situations.
5597 (Fnthcdr, Fsort): Don't assume list length fits in int.
5598 (Fcopy_sequence): Don't assume vector length fits in int.
5600 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5601 (header_size, word_size): New constants.
5602 (allocate_vectorlike): Don't check size overflow here.
5603 (allocate_vector): Check it here instead, since this is the only
5604 caller of allocate_vectorlike that could cause overflow.
5605 Check that the new vector's length is representable as a fixnum.
5607 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5608 The previous code was bogus. For example, next_almost_prime (32)
5609 returned 39, which is undesirable as it is a multiple of 3; and
5610 next_almost_prime (24) returned 25, which is a multiple of 5 so
5611 why was the code bothering to check for multiples of 7?
5613 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5615 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5617 Variadic C functions now count arguments with ptrdiff_t.
5618 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5619 Back then I didn't know that the Emacs coding style prefers signed int.
5620 Also, in the meantime I found a few more instances where arguments
5621 were being counted with int, which may truncate counts on 64-bit
5622 machines, or EMACS_INT, which may be unnecessarily wide.
5623 * lisp.h (struct Lisp_Subr.function.aMANY)
5624 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5625 Arg counts are now ptrdiff_t, not size_t.
5626 All variadic functions and their callers changed accordingly.
5627 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5628 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5629 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5630 * callint.c (Fcall_interactively): Check arg count for overflow,
5631 to avoid potential buffer overrun. Use signed char, not 'int',
5632 for 'varies' array, so that we needn't bother to check its size
5633 calculation for overflow.
5634 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5635 * eval.c (apply_lambda):
5636 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5637 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5638 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5640 * callint.c (Fcall_interactively): Don't use index var as event count.
5642 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5643 * mem-limits.h (SIZE): Remove; no longer used.
5645 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5647 Remove unnecessary casts.
5648 * xterm.c (x_term_init):
5649 * xfns.c (x_set_border_pixel):
5650 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5651 These aren't needed now that we assume ANSI C.
5653 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5654 It's more likely to cause problems (due to unsigned overflow)
5657 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5659 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5661 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5663 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5665 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5667 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5669 GLYPH_CODE_FACE returns EMACS_INT, not int.
5670 * dispextern.h (merge_faces):
5671 * xfaces.c (merge_faces):
5672 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5673 Don't assume EMACS_INT fits in int.
5675 * character.h (CHAR_VALID_P): Remove unused parameter.
5676 * fontset.c, lisp.h, xdisp.c: All uses changed.
5678 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5680 * fns.c (concat): Minor tuning based on overflow analysis.
5681 This doesn't fix any bugs. Use int to hold character, instead
5682 of constantly refetching from Emacs object. Use XFASTINT, not
5683 XINT, for value known to be a character. Don't bother comparing
5684 a single byte to 0400, as it's always less.
5686 * floatfns.c (Fexpt):
5687 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5689 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5692 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5694 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5695 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5696 incorrectly succeed when S was a string, because 4294967386 was
5697 truncated before it was used.
5699 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5700 Otherwise, an out-of-range integer could cause undefined behavior
5703 * composite.c: Use int, not EMACS_INT, for characters.
5704 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5705 EMACS_INT, for values that are known to be in character range.
5706 This doesn't fix any bugs but is the usual style inside Emacs and
5707 may generate better code on 32-bit machines.
5709 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5710 This is for reasons similar to the recent CHAR_STRING fix.
5711 * charset.c (Fencode_char): Check that character arg is actually
5712 a character. Pass an int to ENCODE_CHAR.
5713 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5714 wider than 'int', as a compile-time check to prevent future regressions
5717 * character.c (char_string): Remove unnecessary casts.
5719 Make sure a 64-bit char is never passed to CHAR_STRING.
5720 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5721 by silently ignoring the top 32 bits, allowing some values
5722 that were far too large to be valid characters.
5723 * character.h: Include <verify.h>.
5724 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5725 arguments are no wider than unsigned, as a compile-time check
5726 to prevent future regressions in this area.
5728 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5729 (Fsubst_char_in_region):
5731 * xdisp.c (decode_mode_spec_coding):
5732 Adjust to CHAR_STRING's new requirement.
5733 * editfns.c (Finsert_char, Fsubst_char_in_region):
5734 * fns.c (concat): Check that character args are actually
5735 characters. Without this test, these functions did the wrong
5736 thing with wildly out-of-range values on 64-bit hosts.
5738 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5739 These casts should not be needed on 32-bit hosts, either.
5740 * keyboard.c (read_char):
5741 * lread.c (Fload): Remove casts to unsigned.
5743 * lisp.h (UNSIGNED_CMP): New macro.
5744 This fixes comparison bugs on 64-bit hosts.
5745 (ASCII_CHAR_P): Use it.
5746 * casefiddle.c (casify_object):
5747 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5748 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5749 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5750 * dispextern.h (FACE_FROM_ID):
5751 * keyboard.c (read_char): Use UNSIGNED_CMP.
5753 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5754 not to EMACS_INT, to avoid GCC warning.
5756 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5758 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5759 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5760 isn't needed on 32-bit machines.
5762 * buffer.c (Fgenerate_new_buffer_name):
5763 Use EMACS_INT for count, not int.
5764 (advance_to_char_boundary): Return EMACS_INT, not int.
5766 * data.c (Qcompiled_function): Now static.
5768 * window.c (window_body_lines): Now static.
5770 * image.c (gif_load): Rename local to avoid shadowing.
5772 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5773 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5774 * alloc.c (make_save_value): Integer argument is now of type
5776 (mark_object): Use ptrdiff_t, not int.
5777 * lisp.h (pD): New macro.
5778 * print.c (print_object): Use it.
5780 * alloc.c: Use EMACS_INT, not int, to count objects.
5781 (total_conses, total_markers, total_symbols, total_vector_size)
5782 (total_free_conses, total_free_markers, total_free_symbols)
5783 (total_free_floats, total_floats, total_free_intervals)
5784 (total_intervals, total_strings, total_free_strings):
5785 Now EMACS_INT, not int. All uses changed.
5786 (Fgarbage_collect): Compute overall total using a double, so that
5787 integer overflow is less likely to be a problem. Check for overflow
5788 when converting back to an integer.
5789 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5790 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5791 These were 'int' variables that could overflow on 64-bit hosts;
5792 they were never used, so remove them instead of repairing them.
5793 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5794 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5795 Previously, this ceilinged at INT_MAX, but that doesn't work on
5797 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5799 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5800 (allocate_vectorlike): Check for ptrdiff_t overflow.
5801 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5802 when a (possibly-narrower) signed value would do just as well.
5803 We prefer using signed arithmetic, to avoid comparison confusion.
5805 * alloc.c: Catch some string size overflows that we were missing.
5806 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5807 for convenience in STRING_BYTES_MAX.
5808 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5809 The definition here is exact; the one in lisp.h was approximate.
5810 (allocate_string_data): Check for string overflow. This catches
5811 some instances we weren't catching before. Also, it catches
5812 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5813 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5814 and ptrdiff_t and EMACS_INT are both 64 bits.
5816 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5817 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5818 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5820 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5822 * alloc.c (Fmake_string): Check for out-of-range init.
5824 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5826 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5828 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5830 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5831 xg_get_default_scrollbar_width.
5833 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5834 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5835 (style_changed_cb): Call update_theme_scrollbar_width and call
5836 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5837 all frames (Bug#8505).
5838 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5839 Call gtk_window_set_resizable if HAVE_GTK3.
5840 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5841 and height if HAVE_GTK3 (Bug#8505).
5842 (scroll_bar_width_for_theme): New variable.
5843 (update_theme_scrollbar_width): New function.
5844 (xg_get_default_scrollbar_width): Move code to
5845 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5846 (xg_initialize): Call update_theme_scrollbar_width.
5848 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5850 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5852 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5854 * frame.c (make_frame): Call other_buffer_safely instead of
5857 * window.c (temp_output_buffer_show): Call display_buffer with
5858 second argument Vtemp_buffer_show_specifiers and reset latter
5859 immediately after the call.
5860 (Vtemp_buffer_show_specifiers): New variable.
5861 (auto_window_vscroll_p, next_screen_context_lines)
5862 (Vscroll_preserve_screen_position): Remove leading asterisks from
5865 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5867 Fix minor problems found by GCC 4.6.0 static checking.
5868 * buffer.c (Qclone_number): Remove for now, as it's unused.
5869 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5870 (record_buffer): Remove unused local.
5871 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5872 (set_frame_buffer_list): Remove; unused.
5873 * frame.h (other_visible_frames): Remove decl.
5874 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5875 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5876 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5878 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5879 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5880 Define only if HAVE_GPM.
5881 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5882 (update_hints_inhibit): Remove; never set. All uses removed.
5883 * widgetprv.h (emacsFrameClassRec): Remove decl.
5884 * window.c (delete_deletable_window): Now returns void, since it
5885 wasn't returning anything.
5886 (compare_window_configurations): Remove unused locals.
5887 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5888 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5889 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5890 the same widths as pointers. This follows up on the 2011-05-06 patch.
5891 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5892 * xterm.h: Likewise.
5893 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5895 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5897 * makefile.w32-in: Update dependencies.
5898 (LISP_H): Add lib/intprops.h.
5900 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5902 * image.c (gif_load): Add animation frame delay to the metadata.
5903 (syms_of_image): Use DEFSYM. New symbol `delay'.
5905 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5907 * window.c (delete_deletable_window): Re-add.
5908 (Fset_window_configuration): Rewrite to handle dead buffers and
5909 consequently deletable windows.
5910 (window_tree, Fwindow_tree): Remove. Supply functionality in
5912 (compare_window_configurations): Simplify code.
5914 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5916 * image.c (imagemagick_load_image): Fix type mismatch.
5917 (Fimagemagick_types): Likewise.
5919 * window.h (replace_buffer_in_windows): Declare.
5921 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5923 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5924 Qclone_number. Remove external declaration of Qdelete_window.
5925 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5927 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5928 Run Qbuffer_list_update_hook if allowed.
5929 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5930 buffer list implementation.
5931 (other_buffer_safely): New function.
5932 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5933 calls to replace_buffer_in_windows and
5934 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5936 (record_buffer): Inhibit quitting and rewrite using quittable
5937 functions. Run Qbuffer_list_update_hook if allowed.
5938 (Frecord_buffer, Funrecord_buffer): New functions.
5939 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5940 Move switch-to-buffer to window.el.
5941 (bury-buffer): Move to window.el.
5942 (Vbuffer_list_update_hook): New variable.
5944 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5947 * window.h (resize_frame_windows): Move up in code.
5948 (Fwindow_frame): Remove EXFUN.
5949 (replace_buffer_in_all_windows): Remove prototype.
5950 (replace_buffer_in_windows_safely): Add prototype.
5952 * window.c: Declare Qdelete_window static again. Move down
5953 declaration of select_count.
5954 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5955 (Fother_window): Move to window.el.
5956 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5957 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5958 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5960 (replace_buffer_in_windows): Implement by calling
5961 Qreplace_buffer_in_windows.
5962 (replace_buffer_in_all_windows): Remove with some functionality
5963 moved into replace_buffer_in_windows_safely.
5964 (replace_buffer_in_windows_safely): New function.
5965 (select_window_norecord, select_frame_norecord): Move in front
5966 of run_window_configuration_change_hook. Remove now obsolete
5968 (Fset_window_buffer): Rewrite doc-string.
5969 Call Qrecord_window_buffer.
5970 (keys_of_window): Move binding for other-window to window.el.
5972 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5974 * dispextern.h (struct image): Replace data member, whose int_val
5975 and ptr_val fields were not used by anything, with a single
5978 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5979 (gif_clear_image, gif_load, imagemagick_load_image)
5980 (gs_clear_image, gs_load): Callers changed.
5982 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5984 * buffer.h: Include <time.h>, for time_t.
5985 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5987 Fix minor problems found by static checking.
5989 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5991 Make identifiers static if they are not used in other modules.
5992 * data.c (Qcompiled_function, Qframe, Qvector):
5993 * image.c (QimageMagick, Qsvg):
5994 * minibuf.c (Qmetadata):
5995 * window.c (resize_window_check, resize_root_window): Now static.
5996 * window.h (resize_window_check, resize_root_window): Remove decls.
5998 * window.c (window_deletion_count, delete_deletable_window):
6000 (window_body_lines): Now static.
6001 (Fdelete_other_windows_internal): Mark vars as initialized.
6002 Make sure 'resize_failed' is initialized.
6003 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6004 (resize_window_apply): Remove unused local.
6005 * window.h (delete_deletable_window): Remove decl.
6007 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
6008 (imagemagick_load_image): Fix pointer signedness problem by changing
6009 last arg from unsigned char * to char *. All uses changed.
6010 Also, fix a local for similar reasons.
6011 Remove unused locals. Remove locals to avoid shadowing.
6012 (fn_rsvg_handle_free): Remove; unused.
6013 (svg_load, svg_load_image): Fix pointer signedness problem.
6014 (imagemagick_load_image): Don't use garbage pointer image_wand.
6016 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6018 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
6020 * image.c (gif_load): Fix omitted cast error introduced by
6023 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6025 * window.h (resize_proportionally, orig_total_lines)
6026 (orig_top_line): Remove from window structure.
6027 (set_window_height, set_window_width, change_window_heights)
6028 (Fdelete_window): Remove prototypes.
6029 (resize_frame_windows): Remove duplicate declaration.
6031 2011-06-10 Eli Zaretskii <eliz@gnu.org>
6033 * window.h (resize_frame_windows, resize_window_check)
6034 (delete_deletable_window, resize_root_window)
6035 (resize_frame_windows): Declare prototypes.
6037 * window.c (resize_window_apply): Make definition be "static" to
6038 match the prototype.
6040 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6042 * window.c: Remove declarations of Qwindow_size_fixed,
6043 window_min_size_1, window_min_size_2, window_min_size,
6044 size_window, window_fixed_size_p, enlarge_window, delete_window.
6045 Remove static from declaration of Qdelete_window, it's
6046 temporarily needed by Fbury_buffer.
6047 (replace_window): Don't assign orig_top_line and
6049 (Fdelete_window, delete_window): Remove. Window deletion is
6050 handled by window.el.
6051 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6052 Replace Fdelete_window calls with calls to Qdelete_window.
6053 (Fdelete_other_windows): Remove. Deleting other windows is
6054 handled by window.el.
6055 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6056 handled in window.el.
6057 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6058 Window minimum sizes are handled in window.el.
6059 (shrink_windows, size_window, set_window_height)
6060 (set_window_width, change_window_heights, window_height)
6061 (window_width, CURBEG, CURSIZE, enlarge_window)
6062 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6063 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6064 handled in window.el.
6065 (make_dummy_parent): Rename to make_parent_window and give it a
6066 second argument horflag.
6067 (make_window): Don't set resize_proportionally any more.
6068 (Fsplit_window): Remove. Windows are split in window.el.
6069 (save_restore_action, save_restore_orig_size)
6070 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6071 Resize mini windows in window.el.
6072 (grow_mini_window, shrink_mini_window): Implement by calling
6073 Qresize_root_window_vertically, resize_window_check and
6074 resize_window_apply.
6075 (saved_window, Fset_window_configuration, save_window_save):
6076 Do not handle orig_top_line, orig_total_lines, and
6077 resize_proportionally.
6078 (window_min_height, window_min_width): Move to window.el.
6079 (keys_of_window): Move bindings for delete-other-windows,
6080 split-window, delete-window and enlarge-window to window.el.
6082 * buffer.c: Temporarily extern Qdelete_window.
6083 (Fbury_buffer): Temporarily call Qdelete_window instead of
6084 Fdelete_window (Fbury_buffer will move to window.el soon).
6086 * frame.c (set_menu_bar_lines_1): Remove code handling
6087 orig_top_line and orig_total_lines.
6089 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6090 set_window_height but set heights directly.
6091 (change_frame_size_1): Use resize_frame_windows.
6093 * xdisp.c (init_xdisp): Don't use set_window_height but set
6096 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6097 Use resize_frame_windows instead of change_window_heights and run
6098 run_window_configuration_change_hook.
6100 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6101 instead of change_window_heights and run
6102 run_window_configuration_change_hook.
6104 2011-06-09 Martin Rudalics <rudalics@gmx.at>
6106 * window.c (replace_window): Rename second argument REPLACEMENT to
6107 NEW. New third argument SETFLAG. Rewrite.
6108 (delete_window, make_dummy_parent): Call replace_window with
6110 (window_list_1): Move down in code.
6111 (run_window_configuration_change_hook): Move set_buffer part
6112 before select_frame_norecord part in order to unwind correctly.
6113 Rename count1 to count.
6114 (recombine_windows, delete_deletable_window, resize_root_window)
6115 (Fdelete_other_windows_internal)
6116 (Frun_window_configuration_change_hook, make_parent_window)
6117 (resize_window_check, resize_window_apply, Fresize_window_apply)
6118 (resize_frame_windows, Fsplit_window_internal)
6119 (Fdelete_window_internal, Fresize_mini_window_internal):
6121 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6123 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6125 * window.h (window): Add some new members to window structure -
6126 normal_lines, normal_cols, new_total, new_normal, clone_number,
6127 splits, nest, prev_buffers, next_buffers.
6128 (WINDOW_TOTAL_SIZE): Move here from window.c.
6129 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6131 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6133 (make_dummy_parent): Set new members of windows structure.
6134 (make_window): Move down in code. Handle new members of window
6136 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6137 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6138 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6139 (Fset_window_prev_buffers, Fwindow_next_buffers)
6140 (Fset_window_next_buffers, Fset_window_clone_number):
6142 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6143 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6145 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6146 Argument WINDOW can be now internal window too.
6147 (Fwindow_use_time): Move up in code.
6148 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6150 (Fset_window_configuration, saved_window)
6151 (Fcurrent_window_configuration, save_window_save): Handle new
6152 members of window structure.
6153 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6154 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6155 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6156 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6157 Qget_mru_window, Qresize_root_window,
6158 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6159 Qauto_buffer_name; staticpro them.
6161 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6163 * window.c (Fwindow_total_size, Fwindow_left_column)
6164 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6165 (Fwindow_list_1): New functions.
6166 (window_box_text_cols): Replace with window_body_cols.
6167 (Fwindow_width, Fscroll_left, Fscroll_right):
6168 Use window_body_cols instead of window_box_text_cols.
6169 (delete_window, Fset_window_configuration):
6170 Call delete_all_subwindows with window as argument.
6171 (delete_all_subwindows): Take a window as argument and not a
6173 (window_loop): Remove handling of GET_LRU_WINDOW and
6175 (Fget_lru_window, Fget_largest_window): Move to window.el.
6177 * window.h: Extern window_body_cols instead of
6178 window_box_text_cols. delete_all_subwindows now takes a
6179 Lisp_Object as argument.
6181 * indent.c (compute_motion, Fcompute_motion):
6182 Use window_body_cols instead of window_box_text_cols.
6184 * frame.c (delete_frame): Call delete_all_subwindows with root
6187 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6189 * fns.c (Fputhash): Document return value.
6191 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6193 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6195 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6197 Cons<->int and similar integer overflow fixes (Bug#8794).
6199 Check for overflow when converting integer to cons and back.
6200 * charset.c (Fdefine_charset_internal, Fdecode_char):
6201 Use cons_to_unsigned to catch overflow.
6202 (Fencode_char): Use INTEGER_TO_CONS.
6203 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6204 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6205 * data.c (long_to_cons, cons_to_long): Remove.
6206 (cons_to_unsigned, cons_to_signed): New functions.
6207 These signal an error for invalid or out-of-range values.
6208 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6209 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6210 * font.c (Ffont_variation_glyphs):
6211 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6212 * lisp.h: Include <intprops.h>.
6213 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6214 (cons_to_signed, cons_to_unsigned): New decls.
6215 (long_to_cons, cons_to_long): Remove decls.
6216 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6217 (Fprimitive_undo): Use CONS_TO_INTEGER.
6218 * xfns.c (Fx_window_property): Likewise.
6219 * xselect.c: Include <limits.h>.
6220 (x_own_selection, selection_data_to_lisp_data):
6221 Use INTEGER_TO_CONS.
6222 (x_handle_selection_request, x_handle_selection_clear)
6223 (x_get_foreign_selection, Fx_disown_selection_internal)
6224 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6225 (lisp_data_to_selection_data): Use cons_to_unsigned.
6226 (x_fill_property_data): Use cons_to_signed.
6227 Report values out of range.
6229 Check for buffer and string overflow more precisely.
6230 * buffer.h (BUF_BYTES_MAX): New macro.
6231 * lisp.h (STRING_BYTES_MAX): New macro.
6232 * alloc.c (Fmake_string):
6233 * character.c (string_escape_byte8):
6234 * coding.c (coding_alloc_by_realloc):
6235 * doprnt.c (doprnt):
6236 * editfns.c (Fformat):
6238 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6239 since they may not be the same number.
6240 * editfns.c (Finsert_char):
6241 * fileio.c (Finsert_file_contents):
6242 Likewise for BUF_BYTES_MAX.
6244 * image.c: Use ptrdiff_t, not int, for sizes.
6245 (slurp_file): Switch from int to ptrdiff_t.
6247 (slurp_file): Check that file size fits in both size_t (for
6248 malloc) and ptrdiff_t (for sanity and safety).
6250 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6251 if b->modtime has its maximal value.
6253 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6255 Don't assume time_t can fit into int.
6256 * buffer.h (struct buffer.modtime): Now time_t, not int.
6257 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6258 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6260 Minor fixes for signed vs unsigned integers.
6261 * character.h (MAYBE_UNIFY_CHAR):
6262 * charset.c (maybe_unify_char):
6263 * keyboard.c (read_char, reorder_modifiers):
6264 XINT -> XFASTINT, since the integer must be nonnegative.
6265 * ftfont.c (ftfont_spec_pattern):
6266 * keymap.c (access_keymap, silly_event_symbol_error):
6267 XUINT -> XFASTINT, since the integer must be nonnegative.
6268 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6269 since it makes no difference and we prefer signed.
6270 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6271 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6274 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6276 * window.h (Fwindow_frame): Declare.
6278 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6280 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6281 (SPARE_MEMORY): Always define.
6282 (LARGE_REQUEST): Remove.
6283 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6285 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6287 * lisp.h: Move EXFUNS for Fframe_root_window,
6288 Fframe_first_window and Fset_frame_selected_window to window.h.
6290 * window.h: Move EXFUNS for Fframe_root_window,
6291 Fframe_first_window and Fset_frame_selected_window here from
6294 * frame.c (Fwindow_frame, Fframe_first_window)
6295 (Fframe_root_window, Fframe_selected_window)
6296 (Fset_frame_selected_window): Move to window.c.
6297 (Factive_minibuffer_window): Move to minibuf.c.
6298 (Fother_visible_frames_p): New function.
6300 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6302 * window.c (decode_window, decode_any_window): Move up in code.
6303 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6304 (inhibit_frame_unsplittable): Remove unused variable.
6305 (Fwindow_buffer): Move up and rewrite doc-string.
6306 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6307 (Fwindow_prev): New functions.
6308 (Fwindow_frame): Move here from frame.c. Accept any window as
6310 (Fframe_root_window, Fframe_first_window)
6311 (Fframe_selected_window): Move here from frame.c. Accept frame
6312 or arbitrary window as argument. Update doc-strings.
6313 (Fminibuffer_window): Move up in code.
6314 (Fwindow_minibuffer_p): Move up in code and simplify.
6315 (Fset_frame_selected_window): Move here from frame.c.
6317 (Fselected_window, select_window, Fselect_window): Move up in
6318 code. Minor doc-string fixes.
6320 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6322 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6323 Do not assume that spare memory exists; that assumption is valid
6324 only if SYSTEM_MALLOC.
6325 (LARGE_REQUEST): New macro, so that the issue of large requests
6326 is separated from the issue of spare memory.
6328 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6330 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6333 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6335 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6338 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6340 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6342 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6344 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6345 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6347 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6349 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6351 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6353 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6354 (x_clipboard_manager_save): Add return value.
6355 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6357 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6358 Obey Vx_select_enable_clipboard_manager. Catch errors in
6359 x_clipboard_manager_save (Bug#8779).
6360 (Vx_select_enable_clipboard_manager): New variable.
6361 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6363 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6365 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6367 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6369 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6370 in the current matrix if keep_current_p is non-zero.
6372 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6374 * bidi.c (bidi_level_of_next_char): Fix last change.
6376 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6378 Support bidi reordering of text covered by display properties.
6380 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6381 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6382 (bidi_cache_search, bidi_cache_iterator_state)
6383 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6384 (bidi_level_of_next_char, bidi_move_to_visually_next):
6385 Support character positions inside a run of characters covered by a
6387 (bidi_paragraph_init, bidi_resolve_explicit_1)
6388 (bidi_level_of_next_char): Call bidi_fetch_char and
6389 bidi_fetch_char_advance instead of FETCH_CHAR and
6391 (bidi_init_it): Initialize new members.
6392 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6394 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6395 instead of using explicit *_CHAR codes.
6396 (bidi_resolve_explicit, bidi_resolve_weak):
6397 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6398 bidirectional text is supported only in multibyte buffers.
6399 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6400 it to initialize the frame_window_p member of struct bidi_it.
6401 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6402 (bidi_resolve_explicit, bidi_resolve_weak)
6403 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6404 bidi_it->nchars is non-positive.
6405 (bidi_level_of_next_char): Don't try to lookup the cache for the
6406 next/previous character if nothing is cached there yet, or if we
6407 were just reseat()'ed to a new position.
6409 * xdisp.c (set_cursor_from_row): Set start and stop points
6410 according to the row's direction when priming the loop that looks
6411 for the glyph on which to display cursor.
6412 (single_display_spec_intangible_p): Function deleted.
6413 (display_prop_intangible_p): Reimplement to call
6414 handle_display_spec instead of single_display_spec_intangible_p.
6415 Accept 3 additional arguments needed by handle_display_spec.
6416 This fixes incorrect cursor motion across display property with complex
6417 values: lists, `(when COND...)' forms, etc.
6418 (single_display_spec_string_p): Support property values that are
6419 lists with the argument STRING its top-level element.
6420 (display_prop_string_p): Fix the condition for processing a
6421 property that is a list to be consistent with handle_display_spec.
6422 (handle_display_spec): New function, refactored from the
6423 last portion of handle_display_prop.
6424 (compute_display_string_pos): Accept additional argument
6425 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6426 value of a `display' property is a "replacing spec".
6427 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6428 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6429 the display property, but just return a value indicating whether
6430 the display property will replace the characters it covers.
6431 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6432 frame_window_p members of struct bidi_it.
6433 (compute_display_string_pos, compute_display_string_end):
6435 (push_it): Accept second argument POSITION, where pop_it should
6436 jump to continue iteration.
6437 (reseat_1): Initialize bidi_it.disp_pos.
6439 * keyboard.c (adjust_point_for_property): Adjust the call to
6440 display_prop_intangible_p to its new signature.
6442 * dispextern.h (struct bidi_it): New member frame_window_p.
6443 (bidi_init_it): Update prototypes.
6444 (display_prop_intangible_p): Update prototype.
6445 (compute_display_string_pos, compute_display_string_end):
6447 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6450 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6452 Malloc failure behavior now depends on size of allocation.
6453 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6454 * lisp.h: Change signatures accordingly.
6455 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6456 All callers changed. (Bug#8762)
6458 * gnutls.c: Use Emacs's memory allocators.
6459 Without this change, the gnutls library would invoke malloc etc.
6460 directly, which causes problems on non-SYNC_INPUT hosts, and which
6461 runs afoul of improving memory_full behavior. (Bug#8761)
6462 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6463 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6464 xfree instead of the default malloc, realloc, free.
6465 (Fgnutls_boot): No need to check for memory allocation failure,
6466 since xmalloc does that for us.
6468 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6469 * category.c (hash_get_category_set):
6470 * ccl.c (ccl_driver):
6471 * charset.c (Fdefine_charset_internal):
6472 * charset.h (struct charset.hash_index):
6473 * composite.c (get_composition_id, gstring_lookup_cache)
6474 (composition_gstring_put_cache):
6475 * composite.h (struct composition.hash_index):
6476 * dispextern.h (struct image.hash):
6477 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6478 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6479 (hashfn_equal, hashfn_user_defined, make_hash_table)
6480 (maybe_resize_hash_table, hash_lookup, hash_put)
6481 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6482 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6483 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6484 * image.c (make_image, search_image_cache, lookup_image)
6485 (xpm_put_color_table_h):
6486 * lisp.h (struct Lisp_Hash_Table):
6487 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6488 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6489 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6490 * alloc.c (allocate_vectorlike):
6491 Check for overflow in vector size calculations.
6492 * ccl.c (ccl_driver):
6493 Check for overflow when converting EMACS_INT to int.
6494 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6495 need to be updated by these changes.
6496 * fns.c (make_hash_table, maybe_resize_hash_table):
6497 Check for integer overflow with large hash tables.
6498 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6499 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6500 (SXHASH_REDUCE): New macro.
6501 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6502 Use it instead of discarding useful hash info with large hash values.
6503 (sxhash_float): New function.
6504 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6505 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6506 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6507 Rewrite to use FIXNUM_BITS, as this simplifies things.
6508 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6509 Adjust signatures to match updated version of code.
6510 (consing_since_gc): Now EMACS_INT, since a single hash table can
6511 use more than INT_MAX bytes.
6513 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6515 Make it possible to build with GCC-4.6+ -O2 -flto.
6517 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6519 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6521 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6522 Call minibuffer-inactive-mode.
6524 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6526 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6527 Update dependencies.
6529 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6531 * data.c (init_data): Remove code for UTS, this system is not
6534 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6536 Don't force ./temacs to start in terminal mode.
6538 * frame.c (make_initial_frame): Initialize faces in all cases, not
6539 only when CANNOT_DUMP is defined.
6540 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6542 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6544 * dispnew.c (add_window_display_history): Use const for the string
6545 pointer. Remove declaration, not needed.
6547 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6549 Use 'inline', not 'INLINE'.
6550 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6551 * alloc.c, fontset.c (INLINE): Remove.
6552 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6553 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6554 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6555 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6556 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6558 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6560 Make it possible to run ./temacs.
6562 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6563 syms_of_callproc does the same thing. Remove test for
6564 "initialized", do it in the caller.
6565 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6567 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6569 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6570 (read_minibuf): Use get_minibuffer.
6571 (syms_of_minibuf): Use DEFSYM.
6572 (Qmetadata): New var.
6573 * data.c (Qbuffer): Don't make it static.
6574 (syms_of_data): Use DEFSYM.
6576 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6578 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6579 (CCL_CODE_MIN): New macro.
6581 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6583 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6585 * eval.c (Qdebug): Now static.
6586 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6587 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6588 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6590 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6592 * image.c: Various fixes to ImageMagick code comments.
6593 (Fimagemagick_types): Doc fix.
6595 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6597 Minor fixes prompted by GCC 4.6.0 warnings.
6599 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6601 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6602 (x_clipboard_manager_save_all): Move extern decl to ...
6603 * xterm.h: ... here, so that it can be checked for consistency.
6605 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6607 * xselect.c (x_clipboard_manager_save_frame)
6608 (x_clipboard_manager_save_all): New functions.
6609 (Fx_clipboard_manager_save): Lisp function deleted.
6611 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6612 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6614 * xterm.h: Update prototype.
6616 2011-05-28 William Xu <william.xwl@gmail.com>
6618 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6621 2011-05-28 Jim Meyering <meyering@redhat.com>
6623 Avoid a sign-extension bug in crypto_hash_function.
6624 * fns.c (to_uchar): Define.
6625 (crypto_hash_function): Use it to convert some newly-signed
6626 variables to unsigned, to avoid sign-extension bugs. For example,
6627 without this change, (md5 "truc") would evaluate to
6628 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6629 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6630 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6632 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6634 Integer overflow fixes.
6636 * dbusbind.c: Serial number integer overflow fixes.
6637 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6638 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6639 to hold a serial number that is too large for a fixnum.
6640 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6641 Check for serial numbers out of range. Decode any serial number
6642 that was so large that it became a float. (Bug#8722)
6644 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6645 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6646 Use XFASTINT rather than XUINT when numbers are nonnegative.
6647 (xd_append_arg, Fdbus_method_return_internal):
6648 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6649 arguments, check that Lisp number is nonnegative, rather than
6650 silently wrapping negative numbers around. (Bug#8722)
6651 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6654 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6656 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6658 ccl: Add integer overflow checks.
6659 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6660 (IN_INT_RANGE): New macros.
6661 (ccl_driver): Use them to check for integer overflow when
6662 decoding a CCL program. Many of the new checks are whether XINT (x)
6663 fits in int; it doesn't always, on 64-bit hosts. The new version
6664 doesn't catch all possible integer overflows, but it's an
6665 improvement. (Bug#8719)
6667 * alloc.c (make_event_array): Use XINT, not XUINT.
6668 There's no need for unsigned here.
6670 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6671 This follows up to the 2011-05-06 change that substituted uintptr_t
6672 for EMACS_INT. This case wasn't caught back then.
6674 Rework Fformat to avoid integer overflow issues.
6675 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6676 now (part of C89). Include <verify.h>.
6677 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6678 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6679 (Fformat): Avoid the prepass trying to compute sizes; it was only
6680 approximate and thus did not catch overflow reliably. Instead, walk
6681 through the format just once, formatting and computing sizes as we go,
6682 checking for integer overflow at every step, and allocating a larger
6683 buffer as needed. Keep track separately whether the format is
6684 multibyte. Keep only the most-recently calculated precision, rather
6685 than them all. Record whether each argument has been converted to
6686 string. Use EMACS_INT, not int, for byte and char and arg counts.
6687 Support field widths and precisions larger than INT_MAX. Avoid
6688 sprintf's undefined behavior with conversion specifications such as %#d
6689 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6690 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6691 formatting out-of-range floating point numbers with int
6694 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6696 * data.c: Avoid integer truncation in expressions involving floats.
6697 * data.c: Include <intprops.h>.
6698 (arith_driver): When there's an integer overflow in an expression
6699 involving floating point, convert the integers to floating point
6700 so that the resulting value does not suffer from catastrophic
6701 integer truncation. For example, on a 64-bit host (* 4
6702 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6703 Do not rely on undefined behavior after integer overflow.
6705 merge count_size_as_multibyte, parse_str_to_multibyte
6706 * character.c, character.h (count_size_as_multibyte):
6707 Rename from parse_str_to_multibyte; all uses changed.
6708 Check for integer overflow.
6709 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6710 since it's now a duplicate of the other. This is more of
6711 a character than a buffer op, so better that it's in character.c.
6712 * fns.c, print.c: Adjust to above changes.
6714 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6716 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6718 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6720 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6721 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6722 (x_clipboard_manager_save): Now static.
6723 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6725 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6726 (crypto_hash_function): Now static.
6727 Fix pointer signedness problems. Avoid unnecessary initializations.
6729 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6731 * termhooks.h (Vselection_alist): Make it terminal-local.
6733 * terminal.c (create_terminal): Initialize it.
6735 * xselect.c: Support for clipboard managers.
6736 (Vselection_alist): Move to termhooks.h as terminal-local var.
6737 (LOCAL_SELECTION): New macro.
6738 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6739 (symbol_to_x_atom): Remove gratuitous arg.
6740 (x_handle_selection_request, lisp_data_to_selection_data)
6741 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6742 (x_own_selection, x_get_local_selection, x_convert_selection):
6743 New arg, specifying work frame. Use terminal-local Vselection_alist.
6744 (some_frame_on_display): Delete unused function.
6745 (Fx_own_selection_internal, Fx_get_selection_internal)
6746 (Fx_disown_selection_internal, Fx_selection_owner_p)
6747 (Fx_selection_exists_p): New optional frame arg.
6748 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6749 (x_handle_selection_clear): Don't treat other terminals with the
6750 same keyboard specially. Use the terminal-local Vselection_alist.
6751 (x_clear_frame_selections): Use Frun_hook_with_args.
6753 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6755 * xterm.h: Add support for those atoms.
6757 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6759 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6760 (converted_selections, conversion_fail_tag): New global variables.
6761 (x_selection_request_lisp_error): Free the above.
6762 (x_get_local_selection): Remove unnecessary code.
6763 (x_reply_selection_request): Args changed; handle arbitrary array
6764 of converted selections stored in converted_selections.
6765 Separate the XChangeProperty and SelectionNotify steps.
6766 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6767 (x_convert_selection): New function.
6768 (x_handle_selection_event): Simplify.
6769 (x_get_foreign_selection): Don't ignore incoming requests while
6770 waiting for an answer; this will fail when we implement
6771 SAVE_TARGETS, and seems unnecessary anyway.
6772 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6773 (Vx_sent_selection_functions): Doc fix.
6775 2011-05-26 Leo Liu <sdl.web@gmail.com>
6777 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6779 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6781 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6783 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6784 for fringe update if it has periodic bitmap.
6785 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6786 and fringe_bitmap_periodic_p.
6788 * fringe.c (get_fringe_bitmap_data): New function.
6789 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6790 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6791 row. Mark glyph row for fringe update if periodicity changed.
6793 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6794 for fringe update unless it has periodic bitmap.
6796 2011-05-25 Kenichi Handa <handa@m17n.org>
6798 * xdisp.c (get_next_display_element): Set correct it->face_id for
6799 a static composition.
6801 2011-05-24 Leo Liu <sdl.web@gmail.com>
6804 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6806 * fns.c (crypto_hash_function, Fsha1): New function.
6807 (Fmd5): Use crypto_hash_function.
6808 (syms_of_fns): Add Ssha1.
6810 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6812 * gnutls.c: Remove unused macros.
6813 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6814 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6815 Remove macros that are defined and never used.
6816 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6818 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6820 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6821 (Fx_get_selection_internal): Minor cleanup.
6822 (Fx_own_selection_internal): Rename arguments for consistency with
6825 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6827 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6829 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6831 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6833 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6835 * dispnew.c (scrolling_window): Don't exclude the case that the
6836 last enabled row in the desired matrix touches the bottom boundary.
6838 2011-05-21 Glenn Morris <rgm@gnu.org>
6840 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6841 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6842 and add some more files.
6844 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6846 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6847 report_file_error introduced by the change from 2011-05-07.
6849 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6851 * systime.h (Time): Define only if emacs is defined.
6852 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6853 where the include path doesn't have X11/X.h by default. See
6854 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6856 2011-05-20 Kenichi Handa <handa@m17n.org>
6858 * composite.c (find_automatic_composition): Fix previous change.
6860 2011-05-20 Glenn Morris <rgm@gnu.org>
6862 * lisp.mk: New file, split from Makefile.in.
6863 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6864 (shortlisp): Remove.
6865 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6867 2011-05-19 Glenn Morris <rgm@gnu.org>
6869 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6870 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6871 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6872 (lisp): Set the order to that of loadup.el.
6873 (shortlisp): Make it a copy of $lisp.
6874 (SOME_MACHINE_LISP): Remove.
6875 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6876 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6878 2011-05-18 Kenichi Handa <handa@m17n.org>
6880 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6881 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6882 (find_automatic_composition): Mostly rewrite for efficiency.
6884 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6886 * makefile.w32-in: Update dependencies.
6888 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6890 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6891 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6893 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6895 Fix some integer overflow issues, such as string length overflow.
6897 * insdel.c (count_size_as_multibyte): Check for string overflow.
6899 * character.c (lisp_string_width): Check for string overflow.
6900 Use EMACS_INT, not int, for string indexes and lengths; in
6901 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6902 the resulting string length overflows an EMACS_INT; instead,
6903 report a string overflow if no precision given. When checking for
6904 precision exhaustion, use a check that cannot possibly have
6905 integer overflow. (Bug#8675)
6906 * character.h (lisp_string_width): Adjust to new signature.
6908 * alloc.c (string_overflow): New function.
6909 (Fmake_string): Use it. This doesn't change behavior, but saves
6910 a few bytes and will simplify future changes.
6911 * character.c (string_escape_byte8): Likewise.
6912 * lisp.h (string_overflow): New decl.
6914 Fixups, following up to the user-interface timestamp change.
6915 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6916 for UI timestamps, instead of unsigned long.
6917 * msdos.c (mouse_get_pos): Likewise.
6918 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6919 * w32gui.h (Time): Define by including "systime.h" rather than by
6920 declaring it ourselves. (Bug#8664)
6922 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6923 * image.c (clear_image_cache): Likewise.
6925 * term.c (term_mouse_position): Don't assume time_t wraparound.
6927 Be more systematic about user-interface timestamps.
6928 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6929 and sometimes 'EMACS_UINT', to represent these timestamps.
6930 This change causes it to use 'Time' uniformly, as that's what X uses.
6931 This makes the code easier to follow, and makes it easier to catch
6932 integer overflow bugs such as Bug#8664.
6933 * frame.c (Fmouse_position, Fmouse_pixel_position):
6934 Use Time, not unsigned long, for user-interface timestamps.
6935 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6936 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6937 * keyboard.h (last_event_timestamp): Likewise.
6938 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6939 * menu.h (xmenu_show): Likewise.
6940 * term.c (term_mouse_position): Likewise.
6941 * termhooks.h (struct input_event.timestamp): Likewise.
6942 (struct terminal.mouse_position_hook): Likewise.
6943 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6944 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6945 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6946 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6948 * menu.h, termhooks.h: Include "systime.h", for Time.
6950 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6951 Don't assume that the difference between two unsigned long values
6952 can fit into an integer. At this point, we know button_down_time
6953 <= event->timestamp, so the difference must be nonnegative, so
6954 there's no need to cast the result if double-click-time is
6955 nonnegative, as it should be; check that it's nonnegative, just in
6956 case. This bug is triggered when events are more than 2**31 ms
6957 apart (about 25 days). (Bug#8664)
6959 * xselect.c (last_event_timestamp): Remove duplicate decl.
6960 (x_own_selection): Remove needless cast to unsigned long.
6962 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6963 that always fit in int. Use a sentinel instead of a counter, to
6964 avoid a temp and to allay GCC's concerns about possible int overflow.
6965 * frame.h (struct frame): Use int for menu_bar_items_used
6966 instead of EMACS_INT, since it always fits in int.
6968 * menu.c (grow_menu_items): Check for int overflow.
6970 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6972 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6973 Before, the code was not consistent. These values cannot exceed
6974 2**31 - 1 so there's no need to make them unsigned.
6975 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6976 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6977 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6979 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6981 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6982 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6983 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6984 presumably because the widths might not match.
6986 * window.c (size_window): Avoid needless test at loop start.
6988 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6990 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6992 2011-05-12 Drew Adams <drew.adams@oracle.com>
6994 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6996 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6998 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6999 `width' to `bar_area_x' and `bar_area_width', respectively.
7000 (x_scroll_run): Take account of fringe background extension.
7002 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7003 Rename local vars `left' and `width' to `bar_area_x' and
7004 `bar_area_width', respectively.
7005 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7006 background extension.
7008 2011-05-10 Jim Meyering <meyering@redhat.com>
7010 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7012 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
7014 * image.c (Finit_image_library): Return t for built-in image types,
7015 like pbm and xbm. (Bug#8640)
7017 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7019 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7021 2011-05-07 Eli Zaretskii <eliz@gnu.org>
7023 * w32console.c (Fset_screen_color): Doc fix.
7024 (Fget_screen_color): New function.
7025 (syms_of_ntterm): Defsubr it.
7027 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7028 unlink the temporary file if Fcall_process didn't create it in the
7030 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7031 child process will be redirected to a file specified with `:file'.
7032 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7033 cue to call_process_cleanup not to close that handle.
7035 2011-05-07 Ben Key <bkey76@gmail.com>
7037 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7038 one of two shell specific rules, either bootstrap-temacs-CMD or
7039 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7040 to the previous implementation of the bootstrap-temacs rule.
7041 The bootstrap-temacs-CMD rule is similar to the previous
7042 implementation of the bootstrap-temacs rule except that it
7043 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7046 These changes, along with some changes to nt/configure.bat,
7047 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7048 earlier fix to add support for --cflags and --ldflags options
7049 that include quotes so that it works whether make uses cmd or
7052 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
7054 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7055 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7057 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7058 a string. Handle both cases.
7059 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7060 (Fdbus_register_method): Use Qinvalid_function.
7062 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7064 * makefile.w32-in: Update dependencies.
7065 (LISP_H): Add inttypes.h and stdin.h.
7066 (PROCESS_H): Add unistd.h.
7068 2011-05-06 Eli Zaretskii <eliz@gnu.org>
7070 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7071 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7073 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
7075 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7077 * term.c (vfatal): Remove stray call to va_end.
7078 It's not needed and the C Standard doesn't allow it here anyway.
7080 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7081 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7083 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7086 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7088 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7090 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7092 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7094 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7096 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7097 * charset.c (Fdefine_charset_internal): Don't initialize
7098 charset.code_space[15]. The value was garbage, on hosts with
7099 32-bit int (Bug#8600).
7101 * lread.c (read_integer): Be more consistent with string-to-number.
7102 Use string_to_number to do the actual conversion; this avoids
7103 rounding errors and fixes some other screwups. Without this fix,
7104 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7105 (digit_to_number): Move earlier, for benefit of read_integer.
7106 Return -1 if the digit is out of range for the base, -2 if it is
7107 not a digit in any supported base. (Bug#8602)
7109 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7111 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7112 to match comment at start of function. This also removes a
7113 GCC warning about overflow in a 32+64-bit port.
7115 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7117 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7118 Reported by Stefan Monnier in
7119 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7120 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7121 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7123 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7124 (EMACS_UINTPTR): Likewise, with uintptr_t.
7126 * lisp.h: Prefer 64-bit EMACS_INT if available.
7127 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7128 on 32-bit hosts that have 64-bit int, so that they can access
7130 However, temporarily disable this change unless the temporary
7131 symbol WIDE_EMACS_INT is defined.
7133 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7135 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7136 This removes an assumption that EMACS_INT and long are the same
7137 width as pointers. The assumption is true for Emacs porting targets
7138 now, but we want to make other targets possible.
7139 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7140 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7141 In the rest of the code, change types of integers that hold casted
7142 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7143 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7144 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7145 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7146 No need to cast type when ORing.
7147 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7148 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7149 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7150 assume EMACS_INT is the same width as char *.
7151 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7152 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7153 Remove no-longer-needed casts.
7154 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7155 (xg_tool_bar_help_callback, xg_make_tool_item):
7156 Use EMACS_INTPTR to hold an integer
7157 that will be cast to void *; this can avoid a GCC warning
7158 if EMACS_INT is not the same width as void *.
7159 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7160 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7161 (current_message_1, set_message_1):
7162 Use a local to convert to proper width without a cast.
7163 * xmenu.c (dialog_selection_callback): Likewise.
7165 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7166 Also, don't assume VALBITS / RAND_BITS is less than 5,
7167 and don't rely on undefined behavior when shifting a 1 left into
7169 * lisp.h (get_random): Change signature to match.
7171 * lread.c (hash_string): Use size_t, not int, for hash computation.
7172 Normally we prefer signed values; but hashing is special, because
7173 it's better to use unsigned division on hash table sizes so that
7174 the remainder is nonnegative. Also, size_t is the natural width
7175 for hashing into memory. The previous code used 'int', which doesn't
7176 retain enough info to hash well into very large tables.
7177 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7179 * dbusbind.c: Don't possibly lose pointer info when converting.
7180 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7181 Use XPNTR rather than XHASH, so that the high-order bits of
7182 the pointer aren't lost when converting through void *.
7184 * eval.c (Fautoload): Don't double-shift a pointer.
7186 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7188 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7190 * gnutls.c (DEF_GNUTLS_FN):
7191 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7193 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7195 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7198 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7200 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7201 New version that can reserve upto 2GB of heap space.
7203 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7205 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7207 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7209 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7210 `gnutls_certificate_set_x509_key_file'.
7212 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7214 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7215 Update dependencies.
7217 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7219 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7220 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7221 Remove unused parameter `fildes'.
7222 * process.c (read_process_output, send_process): Don't pass it.
7224 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7226 Fix previous change: the library cache is defined in w32.c.
7227 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7228 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7230 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7232 Implement dynamic loading of GnuTLS on Windows.
7234 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7235 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7236 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7239 * gnutls.c (Qgnutls_dll): Define.
7240 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7241 (gnutls_*): Declare function pointers.
7242 (init_gnutls_functions): New function to initialize function pointers.
7243 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7244 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7245 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7246 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7247 (emacs_gnutls_write, emacs_gnutls_read)
7248 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7249 (Fgnutls_available_p): New function.
7250 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7251 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7252 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7254 * image.c: Include w32.h.
7255 (Vimage_type_cache): Delete.
7256 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7257 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7258 (w32_delayed_load): Move to w32.c.
7260 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7262 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7263 (w32_delayed_load): Move from image.c. When loading a library, record
7264 its filename in the :loaded-from property of the library id.
7265 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7266 Initialize and staticpro them.
7267 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7269 * process.c: Include lisp.h before w32.h, not after.
7270 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7271 instead of gnutls_record_check_pending.
7273 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7275 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7277 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7278 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7281 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7283 * xterm.c (x_set_frame_alpha): Do not set property on anything
7284 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7286 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7288 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7290 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7292 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7293 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7294 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7295 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7296 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7297 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7298 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7299 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7300 (Qgnutls_bootprop_callbacks_verify): Make static.
7302 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7304 * callproc.c: Indentation fixup.
7306 * sysdep.c (wait_for_termination_1): Make static.
7307 (wait_for_termination, interruptible_wait_for_termination):
7308 Move after wait_for_termination_1.
7310 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7312 * sysdep.c (interruptible_wait_for_termination): New function
7313 which is like wait_for_termination, but allows keyboard
7316 * callproc.c (Fcall_process): Add (:file "file") as an option for
7318 (Fcall_process_region): Ditto.
7320 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7322 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7323 rather than `XVECTOR (FOO)->size'.
7325 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7326 inttypes.h, as a gnulib replacement is used if it not available in
7329 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7331 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7332 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7333 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7335 * coding.c (coding_alloc_by_realloc): Error out if destination
7336 will grow beyond MOST_POSITIVE_FIXNUM.
7337 (decode_coding_emacs_mule): Abort if there isn't enough place in
7338 charbuf for the composition carryover bytes. Reserve an extra
7339 space for up to 2 characters produced in a loop.
7340 (decode_coding_iso_2022): Abort if there isn't enough place in
7341 charbuf for the composition carryover bytes.
7343 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7345 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7346 aborting when %lld or %lll format is passed.
7347 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7348 %llo or %llx format is passed. (Bug#8545)
7350 * window.c (window_scroll_line_based): Use a marker instead of
7351 simple variables to record original value of point. (Bug#7952)
7353 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7354 produced by %s or %c overflows available buffer space. (Bug#8545)
7356 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7358 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7359 (SIZE_MAX): Move defn after all includes, as they might #define it.
7361 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7363 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7365 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7367 * keyboard.c (Qdelayed_warnings_hook): Define.
7368 (command_loop_1): Run `delayed-warnings-hook'
7369 if Vdelayed_warnings_list is non-nil.
7370 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7371 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7373 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7375 * doprnt.c (doprnt): Don't return value smaller than the buffer
7376 size if the message was truncated. (Bug#8545).
7378 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7380 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7381 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7383 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7385 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7387 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7389 * makefile.w32-in: Update dependencies.
7391 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7393 Improve `doprnt' and its usage. (Bug#8545)
7394 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7395 `format_end'. Remove support for %l as a conversion specifier.
7396 Don't use xrealloc. Improve diagnostics when the %l size modifier
7397 is used. Update the commentary.
7399 * eval.c (verror): Simplify calculation of size_t.
7401 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7404 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7406 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7409 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7411 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7412 This makes this file independent of the recent pseudovector change.
7414 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7416 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7418 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7419 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7420 Remove unused local.
7421 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7423 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7424 GCC 4.6.0 optimizes based on type-based alias analysis.
7425 For example, if b is of type struct buffer * and v of type struct
7426 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7427 != &v->size, and therefore "v->size = 1; b->size = 2; return
7428 v->size;" must therefore return 1. This assumption is incorrect
7429 for Emacs, since it type-puns struct Lisp_Vector * with many other
7430 types. To fix this problem, this patch adds a new type struct
7431 vectorlike_header that documents the constraints on layout of vectors
7432 and pseudovectors, and helps optimizing compilers not get fooled
7433 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7434 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7435 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7437 (XSETPVECTYPE): Rewrite in terms of new macro.
7438 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7439 This is a bit clearer, and further avoids the possibility of
7440 undesirable aliasing.
7441 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7442 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7443 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7444 since Lisp_Subr is a special case (no "next" field).
7445 (ASIZE): Now uses header.size rather than size.
7446 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7447 to avoid the hassle of writing XVECTOR (foo)->header.size.
7448 (struct vectorlike_header): New type.
7449 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7450 object, to help avoid aliasing.
7451 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7452 (SUBRP): Likewise, since Lisp_Subr is a special case.
7453 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7454 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7455 (struct Lisp_Hash_Table): Combine first two members into a single
7456 struct vectorlike_header member. All uses of "size" and "next" members
7457 changed to be "header.size" and "header.next".
7458 * buffer.h (struct buffer): Likewise.
7459 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7460 * frame.h (struct frame): Likewise.
7461 * process.h (struct Lisp_Process): Likewise.
7462 * termhooks.h (struct terminal): Likewise.
7463 * window.c (struct save_window_data, struct saved_window): Likewise.
7464 * window.h (struct window): Likewise.
7465 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7466 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7467 * buffer.c (init_buffer_once): Likewise.
7468 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7470 * process.c (Fformat_network_address): Use local var for size,
7473 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7475 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7476 * data.c (atof): Remove decl; no longer used or needed.
7477 (digit_to_number): Move to lread.c.
7478 (Fstring_to_number): Use new string_to_number function, to be
7479 consistent with how the Lisp reader treats infinities and NaNs.
7480 Do not assume that floating-point numbers represent EMACS_INT
7481 without losing information; this is not true on most 64-bit hosts.
7482 Avoid double-rounding errors, by insisting on integers when
7483 parsing non-base-10 numbers, as the documentation specifies.
7484 * lisp.h (string_to_number): New decl, replacing ...
7485 (isfloat_string): Remove.
7486 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7487 (read1): Do not accept +. and -. as integers; this
7488 appears to have been a coding error. Similarly, do not accept
7489 strings like +-1e0 as floating point numbers. Do not report
7490 overflow for integer overflows unless the base is not 10 which
7491 means we have no simple and reliable way to continue.
7492 Break out the floating-point parsing into a new
7493 function string_to_number, so that Fstring_to_number parses
7494 floating point numbers consistently with the Lisp reader.
7495 (digit_to_number): Move here from data.c. Make it static inline.
7496 (E_CHAR, EXP_INT): Remove, replacing with ...
7497 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7498 (string_to_number): New function, replacing isfloat_string.
7499 This function checks for valid syntax and produces the resulting
7500 Lisp float number too. Rework it so that string-to-number
7501 no longer mishandles examples like "1.0e+". Use strtoumax,
7502 so that overflow for non-base-10 numbers is reported only when
7503 there's no portable and simple way to convert to floating point.
7505 * textprop.c (set_text_properties_1): Rewrite for clarity,
7506 and to avoid GCC warning about integer overflow.
7508 * intervals.h (struct interval): Use EMACS_INT for members
7509 where EMACS_UINT might cause problems. See
7510 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7511 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7512 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7514 (offset_intervals): Tell GCC not to worry about length overflow
7515 when negating a negative length.
7517 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7518 (overrun_check_free): Likewise.
7520 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7521 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7524 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7525 (gnutls_make_error): Rename local to avoid shadowing.
7526 (gnutls_emacs_global_deinit): ifdef out; not used.
7527 (Fgnutls_boot): Use const for pointer to readonly storage.
7528 Comment out unused local. Fix pointer signedness problems.
7530 * lread.c (openp): Don't stuff size_t into an 'int'.
7531 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7532 about possible signed overflow.
7534 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7535 (GDK_KEY_g): Don't define if already defined.
7536 (xg_prepare_tooltip): Avoid pointer signedness problem.
7537 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7539 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7540 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7542 * xfns.c (Fx_window_property): Simplify a bit,
7543 to make a bit faster and to avoid GCC 4.6.0 warning.
7544 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7546 * fns.c (internal_equal): Don't assume size_t fits in int.
7548 * alloc.c (compact_small_strings): Tighten assertion a little.
7550 Replace pEd with more-general pI, and fix some printf arg casts.
7551 * lisp.h (pI): New macro, generalizing old pEd macro to other
7552 conversion specifiers. For example, use "...%"pI"d..." rather
7553 than "...%"pEd"...".
7554 (pEd): Remove. All uses replaced with similar uses of pI.
7555 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7556 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7557 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7558 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7559 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7560 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7561 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7563 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7564 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7565 * print.c (safe_debug_print, print_object): Likewise.
7566 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7568 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7569 avoiding the 0 flag, which is not portable.
7570 * process.c (Fmake_network_process): Use pI to avoid cast.
7571 * region-cache.c (pp_cache): Likewise.
7572 * xdisp.c (decode_mode_spec): Likewise.
7573 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7574 behavior on 64-bit hosts with printf arg.
7575 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7576 (x_stop_queuing_selection_requests): Likewise.
7577 (x_get_window_property): Don't truncate byte count to an 'int'
7580 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7581 here, since it parses constructs like leading '-' and spaces,
7582 which are not wanted; and it overflows with large numbers.
7583 Instead, simply match F[0-9]+, which is what is wanted anyway.
7585 * alloc.c: Remove unportable assumptions about struct layout.
7586 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7587 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7588 (allocate_vectorlike, make_pure_vector): Use the new macros,
7589 plus offsetof, to remove unportable assumptions about struct layout.
7590 These assumptions hold on all porting targets that I know of, but
7591 they are not guaranteed, they're easy to remove, and removing them
7592 makes further changes easier.
7594 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7595 This doesn't fix a bug but makes the code clearer.
7596 (string_overrun_cookie): Now const. Use initializers that
7597 don't formally overflow signed char, to avoid warnings.
7598 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7599 can cause Emacs to crash when string overrun checking is enabled.
7600 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7601 multiple of sizeof (EMACS_INT); it need not be, if
7602 alignof(EMACS_INT) < sizeof (EMACS_INT).
7603 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7605 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7607 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7609 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7611 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7612 supposed to be handshaking. (Bug#8556)
7613 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7615 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7617 * lisp.h (Qdebug): List symbol.
7618 * eval.c (Qdebug): Restore global linkage.
7619 * keyboard.c (debug-on-event): New variable.
7620 (handle_user_signal): Break into debugger when debug-on-event
7621 matches the current signal symbol.
7623 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7625 * alloc.c (check_sblock, check_string_bytes)
7626 (check_string_free_list): Convert to standard C.
7628 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7630 * w32.c (emacs_gnutls_push): Fix typo.
7632 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7634 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7635 "cast to pointer from integer of different size".
7637 Improve doprnt and its use in verror. (Bug#8545)
7638 * doprnt.c (doprnt): Document the set of format control sequences
7639 supported by the function. Use SAFE_ALLOCA instead of always
7642 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7643 is one byte too soon. Don't use xrealloc; instead xfree and
7646 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7648 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7651 * gnutls.c: Renamed global_initialized to
7652 gnutls_global_initialized. Added internals for the
7653 :verify-hostname-error, :verify-error, and :verify-flags
7654 parameters of `gnutls-boot' and documented those parameters in the
7655 docstring. Start callback support.
7656 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7657 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7658 on error. Return error code.
7659 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7660 (emacs_gnutls_read): Likewise.
7661 (Fgnutls_boot): Return handshake error code.
7662 (emacs_gnutls_handle_error): New function.
7663 (wsaerror_to_errno): Likewise.
7665 * w32.h (emacs_gnutls_pull): Add prototype.
7666 (emacs_gnutls_push): Likewise.
7668 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7669 (emacs_gnutls_push): Likewise.
7671 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7673 * process.c (wait_reading_process_output): Check if GnuTLS
7674 buffered some data internally if no FDs are set for TLS
7677 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7678 (LIBS): Link to USER_LIBS.
7679 ($(BLD)/gnutls.$(0)): New target.
7681 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7683 * xdisp.c (handle_single_display_spec): Rename the
7684 display_replaced_before_p argument into display_replaced_p, to
7685 make it consistent with the commentary. Fix typos in the
7688 * textprop.c (syms_of_textprop): Remove dead code.
7689 (copy_text_properties): Delete obsolete commentary about an
7690 interface that was deleted long ago. Fix typos in the description
7693 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7694 to changes in oldXMenu/XMenu.h from 2011-04-16.
7695 <menu_help_message, prev_menu_help_message>: Constify.
7696 (IT_menu_make_room): menu->help_text is now `const char **';
7699 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7700 to changes in oldXMenu/XMenu.h from 2011-04-16.
7701 (struct XMenu): Declare `help_text' `const char **'.
7703 * xfaces.c <Qunspecified>: Make extern again.
7705 * syntax.c: Include sys/types.h before including regex.h, as
7708 * doc.c (get_doc_string): Improve the format passed to `error'.
7710 * doprnt.c (doprnt): Improve commentary.
7712 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7714 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7717 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7718 changes in globals.h immediately force recompilation.
7719 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7720 $(CURDIR)/s/ms-w32.h.
7721 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7723 * character.c (Fchar_direction): Function deleted.
7724 (syms_of_character): Don't defsubr it.
7725 <char-direction-table>: Deleted.
7727 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7729 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7730 * doprnt.c: Include limits.h.
7731 (SIZE_MAX): New macro.
7732 (doprnt): Return a size_t value. 2nd arg is now size_t.
7733 Many local variables are now size_t instead of int or unsigned.
7734 Improve overflow protection. Support `l' modifier for integer
7735 conversions. Support %l conversion. Don't assume an EMACS_INT
7736 argument for integer conversions and for %c.
7738 * lisp.h (doprnt): Restore prototype.
7740 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7743 * Makefile.in (base_obj): Add back doprnt.o.
7745 * deps.mk (doprnt.o): Add back prerequisites.
7746 (callint.o): Depend on character.h.
7748 * eval.c (internal_lisp_condition_case): Include the handler
7749 representation in the error message.
7750 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7751 when breaking from the loop.
7753 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7755 * callint.c (Fcall_interactively): When displaying error message
7756 about invalid control letter, pass the character's codepoint, not
7757 a pointer to its multibyte form. Improve display of the character
7758 in octal and display also its hex code.
7760 * character.c (char_string): Use %x to display the (unsigned)
7761 codepoint of an invalid character, to avoid displaying a bogus
7764 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7765 `error', not SYMBOL_NAME itself.
7767 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7768 character arguments to `error'.
7770 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7771 to `error' in error message about FINAL_CHAR argument. Make sure
7772 FINAL_CHAR is a character, and use %c when it is passed as
7773 argument to `error'.
7775 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7777 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7779 * w32.c: Include <time.h>.
7780 (sys_localtime): New function.
7782 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7784 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7786 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7788 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7790 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7793 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7795 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7796 gl_state.e_property when gl_state.object is Qt.
7798 * insdel.c (make_gap_larger): Remove limitation of buffer size
7801 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7803 * xdisp.c (lookup_glyphless_char_display)
7804 (produce_glyphless_glyph): Handle cons cell entry in
7805 glyphless-char-display.
7806 (Vglyphless_char_display): Document it.
7808 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7809 glyphless-char-display.
7811 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7813 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7815 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7817 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7818 definition for no-X builds.
7820 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7822 Static checks with GCC 4.6.0 and non-default toolkits.
7824 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7826 * process.c (keyboard_bit_set): Define only if SIGIO.
7827 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7828 (send_process): Repair possible setjmp clobbering.
7830 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7832 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7834 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7836 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7837 Define only if needed.
7839 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7840 by pacifying GCC about it. Maybe it's time to retire it?
7841 * xfaces.c (USG, __TIMEVAL__): Likewise.
7843 * dispextern.h (struct redisplay_interface): Rename param
7845 * termhooks.h (struct terminal): Likewise.
7846 * xterm.c (xembed_send_message): Likewise.
7848 * insdel.c (make_gap_smaller): Define only if
7849 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7851 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7854 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7855 so that we aren't warned about unused symbols.
7857 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7859 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7861 * xfns.c (x_real_positions): Mark locals as initialized.
7863 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7865 * xterm.c: Fix problems found by static analysis with other toolkits.
7866 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7867 (x_dispatch_event): Declare static if USE_GTK, and
7868 define if USE_GTK || USE_X_TOOLKIT.
7869 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7870 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7871 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7872 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7874 * xmenu.c (menu_help_callback): Pointer type fixes.
7875 Use const pointers when pointing at readonly data. Avoid pointer
7877 (FALSE): Remove unused macro.
7878 (update_frame_menubar): Remove unused decl.
7880 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7882 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7883 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7884 (single_menu_item): Rename local to avoid shadowing.
7886 * keyboard.c (make_lispy_event): Remove unused local var.
7888 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7889 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7891 * bitmaps: Change bitmaps from unsigned char back to the X11
7892 compatible char. Avoid the old compiler warnings about
7893 out-of-range initializers by using, for example, '\xab' rather
7896 * xgselect.c (xgselect_initialize): Check vs interface
7897 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7899 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7901 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7902 to read-only memory.
7904 * fns.c (vector): Remove; this old hack is no longer needed.
7906 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7908 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7910 * xrdb.c (x_load_resources): Omit unused local.
7912 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7913 (x_window): Rename locals to avoid shadowing.
7914 (USG): Use the kludged USG macro, to pacify gcc.
7916 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7917 (x_term_init): Remove local to avoid shadowing.
7919 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7921 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7922 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7924 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7926 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7928 Fix regex.c, syntax.c and friends for buffers > 2GB.
7929 * syntax.h (struct gl_state_s): Declare character position members
7932 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7934 * textprop.c (verify_interval_modification, interval_of):
7935 Declare arguments EMACS_INT.
7937 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7940 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7942 * indent.c (Fvertical_motion): Local variable it_start is now
7945 * regex.c (re_match, re_match_2, re_match_2_internal)
7946 (bcmp_translate, regcomp, regexec, print_double_string)
7947 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7948 (re_compile_pattern, re_exec): Declare arguments and local
7949 variables `size_t' and `ssize_t' and return values `regoff_t', as
7951 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7952 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7953 <compile_stack_type>: `size' and `avail' are now `size_t'.
7955 * regex.h <regoff_t>: Use ssize_t, not int.
7956 (re_search, re_search_2, re_match, re_match_2): Arguments that
7957 specify buffer/string position and length are now ssize_t and
7958 size_t. Return type is regoff_t.
7960 2011-04-16 Ben Key <bkey76@gmail.com>
7962 * nsfont.m: Fixed bugs in ns_get_family and
7963 ns_descriptor_to_entity that were caused by using free to
7964 deallocate memory blocks that were allocated by xmalloc (via
7965 xstrdup). This caused Emacs to crash when compiled with
7966 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7967 --enable-checking=xmallocoverrun). xfree is now used to
7968 deallocate these memory blocks.
7970 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7972 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7974 emacs_write: Accept and return EMACS_INT for sizes.
7975 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7977 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7978 Accept and return EMACS_INT.
7979 (emacs_gnutls_write): Return the number of bytes written on
7981 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7982 (emacs_read, emacs_write): Remove check for negative size, as the
7983 Emacs source code has been audited now.
7984 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7985 (emacs_read, emacs_write): Use it.
7986 * process.c (send_process): Adjust to the new signatures of
7987 emacs_write and emacs_gnutls_write. Do not attempt to store
7988 a byte offset into an 'int'; it might overflow.
7989 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7991 * sound.c: Don't assume sizes fit in 'int'.
7992 (struct sound_device.period_size, alsa_period_size):
7993 Return EMACS_INT, not int.
7994 (struct sound_device.write, vox_write, alsa_write):
7995 Accept EMACS_INT, not int.
7996 (wav_play, au_play): Use EMACS_INT to store sizes and to
7997 record read return values.
7999 2011-04-15 Ben Key <bkey76@gmail.com>
8001 * keyboard.c (Qundefined): Don't declare static since it is used
8003 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8004 static since they are used in nsfont.m.
8006 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8008 * process.c (Qprocessp): Don't declare static.
8009 * lisp.h (Qprocessp): Declare again.
8011 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
8013 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8015 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8017 Improve C-level modularity by making more things 'static'.
8019 Don't publish debugger-only interfaces to other modules.
8020 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8021 (verify_bytepos, count_markers): Move decls to the only modules
8023 * region-cache.h (pp_cache): Likewise.
8024 * window.h (check_all_windows): Likewise.
8025 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8027 * sysdep.c (croak): Now static, if
8028 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8029 * syssignal.h (croak): Declare only if not static.
8031 * alloc.c (refill_memory_reserve): Now static if
8032 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8033 * lisp.h (refill_memory_reserve): Declare only if not static.
8035 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8036 Define only if USE_LUCID.
8038 * xrdb.c (x_customization_string, x_rm_string): Now static.
8040 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8041 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8043 * xdisp.c (draw_row_with_mouse_face): Now static.
8044 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8046 * window.h (check_all_windows): Mark externally visible.
8048 * window.c (window_deletion_count): Now static.
8050 * undo.c: Make symbols static if they're not exported.
8051 (last_undo_buffer, last_boundary_position, pending_boundary):
8054 * textprop.c (interval_insert_behind_hooks): Now static.
8055 (interval_insert_in_front_hooks): Likewise.
8057 * term.c: Make symbols static if they're not exported.
8058 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8059 (max_frame_lines, tty_set_terminal_modes):
8060 (tty_reset_terminal_modes, tty_turn_off_highlight):
8061 (get_tty_terminal): Now static.
8062 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8063 * termhooks.h (term_mouse_moveto): Do not declare if
8065 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8066 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8068 * sysdep.c: Make symbols static if they're not exported.
8069 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8071 (sigprocmask_set, full_mask): Remove; unused.
8072 (wait_debugging): Mark as visible.
8073 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8074 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8076 * syntax.c (syntax_temp): Define only if !__GNUC__.
8078 * sound.c (current_sound_device, current_sound): Now static.
8080 * search.c (searchbufs, searchbuf_head): Now static.
8082 * scroll.c (scroll_cost): Remove; unused.
8083 * dispextern.h (scroll_cost): Remove decl.
8085 * region-cache.h (pp_cache): Mark as externally visible.
8087 * process.c: Make symbols static if they're not exported.
8088 (process_tick, update_tick, create_process, chan_process):
8089 (Vprocess_alist, proc_buffered_char, datagram_access):
8090 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8091 (deactivate_process): Mark defn as static, as well as decl.
8092 * lisp.h (create_process): Remove decl.
8093 * process.h (chan_process, Vprocess_alist): Remove decls.
8095 * print.c: Make symbols static if they're not exported.
8096 (print_depth, new_backquote_output, being_printed, print_buffer):
8097 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8098 (print_interval, print_number_index, initial_stderr_stream):
8100 * lisp.h (Fprinc): Remove decl.
8101 (debug_output_compilation_hack): Mark as externally visible.
8103 * sysdep.c (croak): Move decl from here to syssignal.h.
8104 * syssignal.h (croak): Put it here, so the API can be checked when
8105 'croak' is called from dissociate_if_controlling_tty.
8107 * minibuf.c: Make symbols static if they're not exported.
8108 (minibuf_save_list, choose_minibuf_frame): Now static.
8109 * lisp.h (choose_minibuf_frame): Remove decl.
8111 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8113 * lread.c: Make symbols static if they're not exported.
8114 (read_objects, initial_obarray, oblookup_last_bucket_number):
8116 (make_symbol): Remove; unused.
8117 * lisp.h (initial_obarray, make_symbol): Remove decls.
8119 * keyboard.c: Make symbols static if they're not exported.
8120 (single_kboard, recent_keys_index, total_keys, recent_keys):
8121 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8122 (this_single_command_key_start, echoing, last_auto_save):
8123 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8124 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8125 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8126 (Vlispy_mouse_stem, double_click_count):
8128 (force_auto_save_soon): Define only if SIGDANGER.
8129 (ignore_mouse_drag_p): Now static if
8130 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8131 (print_help): Remove; unused.
8132 (stop_character, last_timer_event): Mark as externally visible.
8133 * keyboard.h (ignore_mouse_drag_p): Declare only if
8134 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8135 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8136 * lisp.h (echoing): Remove decl.
8137 (force_auto_save_soon): Declare only if SIGDANGER.
8138 * xdisp.c (redisplay_window): Simplify code, to make it more
8139 obvious that ignore_mouse_drag_p is not accessed if !defined
8140 USE_GTK && !defined HAVE_NS.
8142 * intervals.c: Make symbols static if they're not exported.
8143 (merge_properties_sticky, merge_interval_right, delete_interval):
8145 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8147 * insdel.c: Make symbols static if they're not exported.
8148 However, leave prepare_to_modify_buffer alone. It's never
8149 called from outside this function, but that appears to be a bug.
8150 (combine_after_change_list, combine_after_change_buffer):
8151 (adjust_after_replace, signal_before_change): Now static.
8152 (adjust_after_replace_noundo): Remove; unused.
8153 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8154 (signal_before_change): Remove decls.
8156 * indent.c (val_compute_motion, val_vmotion): Now static.
8158 * image.c: Make symbols static if they're not exported.
8159 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8161 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8162 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8164 * fringe.c (standard_bitmaps): Now static.
8165 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8167 * frame.c: Make symbols static if they're not exported.
8168 (x_report_frame_params, make_terminal_frame): Now static.
8169 (get_frame_param): Now static, unless HAVE_NS.
8170 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8171 (x_get_resource_string): Remove; not used.
8172 * frame.h (make_terminal_frame, x_report_frame_params):
8173 (x_get_resource_string); Remove decls.
8174 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8175 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8177 * font.c, fontset.c: Make symbols static if they're not exported.
8178 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8179 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8180 * font.c (font_close_object): Now static.
8181 * font.h (font_close_object): Remove.
8182 * fontset.c (FONTSET_OBJLIST): Remove.
8183 (free_realized_fontset) #if-0 the body, which does nothing.
8184 (face_suitable_for_char_p): #if-0, as it's never called.
8185 * fontset.h (face_suitable_for_char_p): Remove decl.
8186 * xfaces.c (face_at_string_position):
8187 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8188 since 0 is always ASCII.
8190 * fns.c (weak_hash_tables): Now static.
8192 * fileio.c: Make symbols static if they're not exported.
8193 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8194 (Vwrite_region_annotation_buffers): Now static.
8196 * eval.c: Make symbols static if they're not exported.
8197 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8198 * lisp.h (backtrace_list): Remove decl.
8200 * emacs.c: Make symbols static if they're not exported.
8201 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8202 (fatal_error_code, fatal_error_signal_hook, standard_args):
8204 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8205 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8206 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8207 * lisp.h (fatal_error_signal_hook): Remove decl.
8208 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8210 * editfns.c: Move a (normally-unused) function to its only use.
8211 * editfns.c, lisp.h (get_operating_system_release): Remove.
8212 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8213 worth the hassle of breaking this out.
8215 * xterm.c: Make symbols static if they're not exported.
8216 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8217 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8218 (x_destroy_window, x_delete_display):
8220 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8221 (x_mouse_leave): Remove; unused.
8222 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8223 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8224 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8226 (x_mouse_leave): Declare only if WINDOWSNT.
8227 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8228 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8231 * ftxfont.c: Make symbols static if they're not exported.
8232 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8234 * font.h (ftxfont_driver): Likewise.
8236 * xfns.c: Make symbols static if they're not exported.
8237 (x_last_font_name, x_display_info_for_name):
8238 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8239 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8240 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8241 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8242 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8243 (last_show_tip_args): Now static.
8244 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8245 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8246 (x_screen_planes): Remove; unused.
8247 * dispextern.h (x_screen_planes): Remove decl.
8249 * dispnew.c: Make symbols static if they're not exported.
8250 * dispextern.h (redraw_garbaged_frames, scrolling):
8251 (increment_row_positions): Remove.
8252 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8253 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8255 (redraw_garbaged_frames): Remove; unused.
8257 * xfaces.c: Make symbols static if they're not exported.
8258 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8260 * xterm.h (defined_color): Remove decls.
8261 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8262 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8263 (menu_face_changed_default, defined_color, free_realized_face):
8264 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8265 (ascii_face_of_lisp_face): Remove; unused.
8267 * xdisp.c: Make symbols static if they're not exported.
8268 * dispextern.h (scratch_glyph_row, window_box_edges):
8269 (glyph_to_pixel_coords, set_cursor_from_row):
8270 (get_next_display_element, set_iterator_to_next):
8271 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8272 (show_mouse_face): Remove decls
8273 * frame.h (message_buf_print): Likewise.
8274 * lisp.h (pop_message, set_message, check_point_in_composition):
8276 * xterm.h (set_vertical_scroll_bar): Likewise.
8277 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8278 (message_buf_print, scratch_glyph_row, displayed_buffer):
8279 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8280 (get_next_display_element, show_mouse_face, window_box_edges):
8281 (frame_to_window_pixel_xy, check_point_in_composition):
8282 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8283 (glyph_to_pixel_coords): Remove; unused.
8285 * dired.c (file_name_completion): Now static.
8287 * dbusbind.c (xd_in_read_queued_messages): Now static.
8289 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8290 * data.c (circular_list_error): Remove.
8292 * commands.h (last_point_position, last_point_position_buffer):
8293 (last_point_position_window): Remove decls.
8294 * keyboard.c: Make these variables static.
8296 * coding.h (coding, code_convert_region, encode_coding_gap):
8298 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8299 (iso_code_class, detect_coding, code_convert_region): Now static.
8300 (encode_coding_gap): Remove; unused.
8302 * chartab.c (chartab_chars, chartab_bits): Now static.
8304 * charset.h (charset_iso_8859_1): Remove decl.
8305 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8308 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8309 * ccl.c (Vccl_program_table): Now static.
8310 (check_ccl_update): Remove; unused.
8312 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8313 * category.h: ... from here.
8314 * category.c (check_category_table, set_category_set): Now static.
8316 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8317 * lisp.h: Remove these decls.
8319 * buffer.c (buffer_count): Remove unused var.
8321 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8322 so that it's not optimized away.
8323 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8324 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8325 exported only to the debugger.
8327 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8328 * atimer.h (run_all_atimers): Remove; not exported.
8330 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8331 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8332 was inaccessible from Lisp.
8333 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8334 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8336 alloc.c: Import and export fewer symbols, and remove unused items.
8337 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8339 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8340 it's not optimized away by whole-program optimization.
8341 (message_enable_multibyte, free_misc): Remove.
8342 (catchlist, handlerlist, mark_backtrace):
8343 Declare only if BYTE_MARK_STACK.
8344 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8345 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8346 (message_enable_multibyte): Remove decl.
8347 (free_misc, interval_free_list, float_block, float_block_index):
8348 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8349 (cons_free_list, last_marked_index):
8351 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8352 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8353 (mark_backtrace): Define only if BYTE_MARK_STACK.
8354 * xdisp.c (message_enable_multibyte): Now static.
8356 Declare Lisp_Object Q* variables to be 'static' if not exported.
8357 This makes it easier for human readers (and static analyzers)
8358 to see whether these variables are used from other modules.
8359 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8360 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8361 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8362 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8363 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8364 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8365 * xmenu.c, xselect.c:
8366 Declare Q* vars static if they are not used in other modules.
8367 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8368 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8369 Remove decls of unexported vars.
8370 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8372 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8374 Make Emacs functions such as Fatom 'static' by default.
8375 This makes it easier for human readers (and static analyzers)
8376 to see whether these functions can be called from other modules.
8377 DEFUN now defines a static function. To make the function external
8378 so that it can be used in other C modules, use the new macro DEFUE.
8379 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8380 (Finit_image_library):
8381 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8382 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8383 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8384 Remove decls, since these functions are now static.
8385 (Funintern, Fget_internal_run_time): New decls, since these functions
8386 were already external.
8388 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8389 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8390 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8391 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8392 * keyboard.c, keymap.c, lread.c:
8393 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8394 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8395 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8396 Mark functions with DEFUE instead of DEFUN,
8397 if they are used in other modules.
8398 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8399 decls for now-static functions.
8400 * buffer.h (Fdelete_overlay): Remove decl.
8401 * callproc.c (Fgetenv_internal): Mark as internal.
8402 * composite.c (Fremove_list_of_text_properties): Remove decl.
8403 (Fcomposition_get_gstring): New forward static decl.
8404 * composite.h (Fcomposite_get_gstring): Remove decl.
8405 * dired.c (Ffile_attributes): New forward static decl.
8406 * doc.c (Fdocumntation_property): New forward static decl.
8407 * eval.c (Ffetch_bytecode): New forward static decl.
8408 (Funintern): Remove extern decl; now in .h file where it belongs.
8409 * fileio.c (Fmake_symbolic_link): New forward static decl.
8410 * image.c (Finit_image_library): New forward static decl.
8411 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8412 * intervals.h (Fprevious_property_change):
8413 (Fremove_list_of_text_properties): Remove decls.
8414 * keyboard.c (Fthis_command_keys): Remove decl.
8415 (Fcommand_execute): New forward static decl.
8416 * keymap.c (Flookup_key): New forward static decl.
8417 (Fcopy_keymap): Now static.
8418 * keymap.h (Flookup_key): Remove decl.
8419 * process.c (Fget_process): New forward static decl.
8420 (Fprocess_datagram_address): Mark as internal.
8421 * syntax.c (Fsyntax_table_p): New forward static decl.
8422 (skip_chars): Remove duplicate decl.
8423 * textprop.c (Fprevious_property_change): New forward static decl.
8424 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8426 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8427 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8429 * editfns.c (Fformat): Remove unreachable code.
8431 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8433 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8436 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8438 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8439 when at ZV. (Bug#8487)
8441 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8443 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8445 * keyboard.c (parse_tool_bar_item): Likewise.
8446 * sound.c (sound_cleanup, alsa_close): Likewise.
8447 * termcap.c (tgetent): Likewise.
8448 * xfns.c (x_default_font_parameter): Likewise.
8449 * xsettings.c (read_and_apply_settings): Likewise.
8451 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8452 (overrun_check_free): Protoize.
8454 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8456 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8457 since callers should never pass a negative size.
8458 Change the signature to match that of plain 'read' and 'write'; see
8459 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8460 * lisp.h: Update prototypes of emacs_write and emacs_read.
8462 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8464 * xdisp.c (redisplay_window): Don't try to determine the character
8465 position of the scroll margin if the window start point w->startp
8466 is outside the buffer's accessible region. (Bug#8468)
8468 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8470 Fix write-region and its subroutines for buffers > 2GB.
8471 * fileio.c (a_write, e_write): Modify declaration of arguments and
8472 local variables to support buffers larger than 2GB.
8473 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8475 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8476 argument, local variables, and return value.
8478 * lisp.h: Update prototypes of emacs_write and emacs_read.
8480 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8482 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8484 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8486 Fix more problems found by GCC 4.6.0's static checks.
8488 * xdisp.c (vmessage): Use a better test for character truncation.
8490 * charset.c (load_charset_map): <, not <=, for optimization,
8491 and to avoid potential problems with integer overflow.
8492 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8493 * casetab.c (set_identity, shuffle): Likewise.
8494 * editfns.c (Fformat): Likewise.
8495 * syntax.c (skip_chars): Likewise.
8497 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8498 This also lets GCC 4.6.0 generate slightly better loop code.
8500 * callint.c (Fcall_interactively): <, not <=, for optimization.
8501 (Fcall_interactively): Count the number of arguments produced,
8502 not the number of arguments given. This is simpler and lets GCC
8503 4.6.0 generate slightly better code.
8505 * ftfont.c: Distingish more carefully between FcChar8 and char.
8506 The previous code passed unsigned char * to a functions like
8507 strlen and xstrcasecmp that expect char *, which does not
8508 conform to the C standard.
8509 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8510 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8511 char * when the C standard requires it.
8513 * keyboard.c (read_char): Remove unused var.
8515 * eval.c: Port to Windows vsnprintf (Bug#8435).
8517 (SIZE_MAX): Define if the headers do not.
8518 (verror): Do not give up if vsnprintf returns a negative count.
8519 Instead, grow the buffer. This ports to Windows vsnprintf, which
8520 does not conform to C99. Problem reported by Eli Zaretskii.
8521 Also, simplify the allocation scheme, by avoiding the need for
8522 calling realloc, and removing the ALLOCATED variable.
8524 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8526 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8527 But keep the doprint source code for now, as we might revamp it
8528 and use it again (Bug#8435).
8529 * lisp.h (doprnt): Remove.
8530 * Makefile.in (base_obj): Remove doprnt.o.
8531 * deps.mk (doprnt.o): Remove.
8533 error: Print 32- and 64-bit integers portably (Bug#8435).
8534 Without this change, on typical 64-bit hosts error ("...%d...", N)
8535 was used to print both 32- and 64-bit integers N, which relied on
8537 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8538 * lisp.h (error, verror): Mark as printf-like functions.
8539 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8540 Report overflow in size calculations when allocating printf buffer.
8541 Do not truncate output string at its first null byte.
8542 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8543 Truncate the output at a character boundary, since vsnprintf does not
8545 * charset.c (check_iso_charset_parameter): Convert internal
8546 character to string before calling 'error', since %c now has the
8548 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8549 overflow when computing char to be passed to 'error'. Do not
8550 pass Lisp_Object to 'error'; pass the integer instead.
8551 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8552 formatted with plain %d.
8554 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8556 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8558 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8560 * xterm.c (x_catch_errors): Remove duplicate declaration.
8562 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8564 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8566 2011-04-10 Jim Meyering <meyering@redhat.com>
8568 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8569 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8570 return ssize_t not "int", and use size_t as the buffer length.
8571 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8572 * gnutls.h: Update declarations.
8573 * process.c (read_process_output): Use ssize_t, to match.
8574 (send_process): Likewise.
8576 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8578 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8580 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8582 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8583 Use unsigned char, to match FcChar8 type definition.
8585 * xterm.c (handle_one_xevent):
8586 * xmenu.c (create_and_show_popup_menu):
8587 * xselect.c (x_decline_selection_request)
8588 (x_reply_selection_request): Avoid type-punned deref of X events.
8590 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8592 Fix some uses of `int' instead of EMACS_INT.
8593 * search.c (string_match_1, fast_string_match)
8594 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8595 (scan_buffer, find_next_newline_no_quit)
8596 (find_before_next_newline, search_command, Freplace_match)
8597 (Fmatch_data): Make some `int' variables be EMACS_INT.
8599 * xdisp.c (display_count_lines): 3rd argument and return value now
8600 EMACS_INT. All callers changed.
8601 (pint2hrstr): Last argument is now EMACS_INT.
8603 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8604 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8605 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8606 (decode_coding_utf_16, decode_coding_emacs_mule)
8607 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8608 (decode_coding_ccl, decode_coding_charset)
8609 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8610 (decode_coding_iso_2022, decode_coding_emacs_mule)
8611 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8612 <char_offset, last_offset>: Declare EMACS_INT.
8613 (encode_coding_utf_8, encode_coding_utf_16)
8614 (encode_coding_emacs_mule, encode_invocation_designation)
8615 (encode_designation_at_bol, encode_coding_iso_2022)
8616 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8617 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8619 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8620 (encode_invocation_designation): Last argument P_NCHARS is now
8622 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8623 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8625 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8628 * ccl.c (Fccl_execute_on_string): Declare some variables
8631 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8633 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8635 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8637 * process.c (Fformat_network_address): Doc fix.
8639 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8641 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8643 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8645 * keyboard.c (read_char): Call Lisp function help-form-show,
8646 instead of using internal_with_output_to_temp_buffer.
8647 (Qhelp_form_show): New var.
8648 (syms_of_keyboard): Use DEFSYM macro.
8650 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8652 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8654 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8656 * process.c (Flist_processes): Remove to Lisp.
8657 (list_processes_1): Delete.
8659 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8661 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8663 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8665 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8667 Fix more problems found by GCC 4.6.0's static checks.
8669 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8671 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8673 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8675 * xdisp.c (vmessage): Mark as a printf-like function.
8677 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8679 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8681 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8682 printf-like functions.
8683 (tiff_load): Add casts to remove these marks before passing them
8684 to system-supplied API.
8686 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8688 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8689 This avoids several warnings with gcc -Wstrict-overflow.
8690 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8691 directly, rather than having caller test rule sign. This avoids
8692 some unnecessary tests.
8693 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8694 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8695 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8697 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8698 (xfont_open): Avoid unnecessary tests.
8700 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8702 * composite.h, composite.c (composition_gstring_put_cache):
8703 Use EMACS_INT, not int, for length.
8705 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8706 breaking out part of COMPOSITION_DECODE_RULE.
8707 (COMPOSITION_DECODE_RULE): Use it.
8708 * composite.c (get_composition_id): Remove unused local vars,
8709 by using the new macro.
8711 * textprop.c (set_text_properties_1): Change while to do-while,
8712 since the condition is always true at first.
8714 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8715 (interval_deletion_adjustment): Return unsigned value.
8718 * process.c (list_processes_1, create_pty, read_process_output):
8719 (exec_sentinel): Remove vars that were set but not used.
8720 (create_pty): Remove unnecessary "volatile"s.
8721 (Fnetwork_interface_info): Avoid possibility of int overflow.
8722 (read_process_output): Do adaptive read buffering even if carryover.
8723 (read_process_output): Simplify nbytes computation if buffered.
8725 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8727 * syntax.c (scan_words): Remove var that was set but not used.
8728 (update_syntax_table): Use unsigned instead of int.
8730 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8731 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8732 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8734 * print.c (print_error_message): Avoid int overflow.
8736 * font.c (font_list_entities): Redo for clarity,
8737 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8739 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8740 (font_score): Avoid potential overflow in diff calculation.
8742 * fns.c (substring_both): Remove var that is set but not used.
8743 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8745 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8747 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8748 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8749 can always succeed if overflow has undefined behavior.
8751 * search.c (boyer_moore, wordify): Remove vars set but not used.
8752 (wordify): Omit three unnecessary tests.
8754 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8755 All callers changed. This avoids the need for an unused var.
8757 * casefiddle.c (casify_region): Remove var that is set but not used.
8759 * dired.c (file_name_completion): Remove var that is set but not used.
8761 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8763 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8764 (Finsert_file_contents): Remove unnecessary code checking fd.
8766 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8767 Check for integer overflow on size calculations.
8769 * buffer.c (Fprevious_overlay_change): Remove var that is set
8772 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8773 Remove vars that are set but not used.
8774 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8775 (timer_check_2): Mark vars as initialized.
8777 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8779 * image.c (lookup_image): Remove var that is set but not used.
8780 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8782 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8783 that are set but not used.
8785 * xfns.c (make_invisible_cursor): Don't return garbage
8786 if XCreateBitmapFromData fails (Bug#8410).
8788 * xselect.c (x_get_local_selection, x_handle_property_notify):
8789 Remove vars that are set but not used.
8791 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8792 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8794 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8795 Remove var that is set but not used.
8796 (scroll_bar_windows_size): Now size_t, not int.
8797 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8800 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8801 (map_tty_color) [!defined MSDOS]: Likewise.
8803 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8805 * coding.c: Remove vars that are set but not used.
8806 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8807 All callers changed.
8808 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8809 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8810 (decode_coding_charset): Remove vars that are set but not used.
8812 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8813 that is set but not used.
8815 * print.c (print_object): Remove var that is set but not used.
8817 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8818 The gnulib version avoids calling malloc in the usual case,
8819 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8820 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8821 * filelock.c (current_lock_owner): Likewise.
8822 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8823 * sysdep.c: Include allocator.h, careadlinkat.h.
8824 (emacs_no_realloc_allocator): New static constant.
8825 (emacs_readlink): New function.
8826 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8827 ../lib/careadlinkat.h.
8829 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8831 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8832 first non-nil return value).
8834 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8836 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8837 if not defined (Bug#8403).
8839 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8841 * xdisp.c (display_count_lines): Remove parameter `start',
8842 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8843 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8844 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8845 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8846 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8847 and thereabouts. All callers changed.
8848 (get_per_char_metric): Remove parameter `f', unused since
8849 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8851 2011-04-02 Jim Meyering <meyering@redhat.com>
8853 do not dereference NULL upon failed strdup
8854 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8855 (ns_get_family): Likewise.
8857 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8859 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8861 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8863 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8866 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8868 Add lexical binding.
8870 * window.c (Ftemp_output_buffer_show): New fun.
8871 (Fsave_window_excursion):
8872 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8874 * lread.c (lisp_file_lexically_bound_p): New function.
8875 (Fload): Bind Qlexical_binding.
8876 (readevalloop): Remove `evalfun' arg.
8877 Bind Qinternal_interpreter_environment.
8878 (Feval_buffer): Bind Qlexical_binding.
8879 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8881 (syms_of_lread): Declare `lexical-binding'.
8883 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8885 * keyboard.c (eval_dyn): New fun.
8886 (menu_item_eval_property): Use it.
8888 * image.c (parse_image_spec): Use Ffunctionp.
8890 * fns.c (concat, mapcar1): Accept byte-code-functions.
8892 * eval.c (Fsetq): Handle lexical vars.
8893 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8894 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8895 (FletX, Flet): Obey lexical binding.
8896 (Fcommandp): Handle closures.
8897 (Feval): New `lexical' arg.
8898 (eval_sub): New function extracted from Feval. Use it almost
8899 everywhere where Feval was used. Look up vars in lexical env.
8901 (Ffunctionp): Move from subr.el.
8902 (Ffuncall): Handle closures.
8903 (apply_lambda): Remove `eval_flags'.
8904 (funcall_lambda): Handle closures and new byte-code-functions.
8905 (Fspecial_variable_p): New function.
8906 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8907 but without exporting it to Lisp.
8909 * doc.c (Fdocumentation, store_function_docstring):
8910 * data.c (Finteractive_form): Handle closures.
8912 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8915 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8917 (exec_byte_code): New function extracted from Fbyte_code to handle new
8918 calling convention for byte-code-functions. Add new byte-codes.
8920 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8922 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8924 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8926 * xdisp.c (redisplay_internal): Fix prototype.
8928 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8930 * xdisp.c (SCROLL_LIMIT): New macro.
8931 (try_scrolling): Use it when setting scroll_limit.
8932 Limit scrolling to 100 screen lines.
8933 (redisplay_window): Even when falling back on "recentering",
8934 position point in the window according to scroll-conservatively,
8935 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8937 (try_scrolling): When point is above the window, allow searching
8938 as far as scroll_max, or one screenful, to compute vertical
8939 distance from PT to the scroll margin position. This prevents
8940 try_scrolling from unnecessarily failing when
8941 scroll-conservatively is set to a value slightly larger than the
8942 window height. Clean up the case of PT below the margin at bottom
8943 of window: scroll_max can no longer be INT_MAX. When aggressive
8944 scrolling is in use, don't let point enter the opposite scroll
8945 margin as result of the scroll.
8946 (syms_of_xdisp) <scroll-conservatively>: Document the
8947 threshold of 100 lines for never-recentering scrolling.
8949 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8951 * dispextern.h (move_it_by_lines):
8952 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8953 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8954 (message_log_check_duplicate): Remove parameters `prev_bol' and
8955 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8956 (redisplay_internal): Remove parameter `preserve_echo_area',
8957 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8959 * indent.c (Fvertical_motion):
8960 * window.c (window_scroll_pixel_based, Frecenter):
8961 Don't pass `need_y_p' to `move_it_by_lines'.
8963 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8965 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8966 steal a few bits to be more compact.
8967 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8968 Remove unneeded casts.
8970 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8972 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8974 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8975 binding" message (bug#7967).
8977 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8979 Fix more problems found by GCC 4.6.0's static checks.
8981 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8982 Remove unused local var.
8984 * editfns.c (Fmessage_box): Remove unused local var.
8986 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8987 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8988 Omit unused local vars.
8989 * window.c (shrink_windows): Omit unused local var.
8990 * menu.c (digest_single_submenu): Omit unused local var.
8991 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8992 Omit unused local var.
8994 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8995 Don't assume string length fits in int.
8996 (keyremap_step, read_key_sequence): Use size_t for sizes.
8997 (read_key_sequence): Don't check last_real_key_start redundantly.
8999 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9000 instead of alloca (Bug#8344).
9002 * eval.c (Fbacktrace): Don't assume nargs fits in int.
9003 (Fbacktrace_frame): Don't assume nframes fits in int.
9005 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9007 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9010 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9012 * cm.c (calccost): Turn while-do into do-while, for clarity.
9014 * keyboard.c (syms_of_keyboard): Use the same style as later
9015 in this function when indexing through an array. This also
9016 works around GCC bug 48267.
9018 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9020 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9022 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9023 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9025 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9026 This avoids undefined behavior on integer overflow, and is a bit
9027 more convenient anyway since it is compared to a size_t variable.
9029 Variadic C functions now count arguments with size_t, not int.
9030 This avoids an unnecessary limitation on 64-bit machines, which
9031 caused (substring ...) to crash on large vectors (Bug#8344).
9032 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9033 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
9034 All variadic functions and their callers changed accordingly.
9035 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9036 * data.c (arith_driver, float_arith_driver): Likewise.
9037 * editfns.c (general_insert_function): Likewise.
9038 * eval.c (struct backtrace.nargs, interactive_p)
9039 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9040 (funcall_lambda, mark_backtrace): Likewise.
9041 * fns.c (concat): Likewise.
9042 * frame.c (x_set_frame_parameters): Likewise.
9043 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9044 0 if not found, not -1. All callers changed.
9046 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9047 (stack_copy_size): Now size_t, not int.
9048 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9050 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9052 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9053 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9054 All callers changed.
9056 * lisp.h (multibyte_char_to_unibyte):
9057 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9058 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9059 * character.h (CHAR_TO_BYTE8):
9060 * cmds.c (internal_self_insert):
9061 * editfns.c (general_insert_function):
9062 * keymap.c (push_key_description):
9063 * search.c (Freplace_match):
9064 * xdisp.c (message_dolog, set_message_1): All callers changed.
9066 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9068 * keyboard.c (safe_run_hook_funcall): New function.
9069 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9070 don't set the hook to nil, but remove the offending function instead.
9071 (Qcommand_hook_internal): Remove, unused.
9072 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9073 Vcommand_hook_internal.
9075 * eval.c (enum run_hooks_condition): Remove.
9076 (funcall_nil, funcall_not): New functions.
9077 (run_hook_with_args): Call each function through a `funcall' argument.
9078 Remove `cond' argument, now redundant.
9079 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9080 (Frun_hook_with_args_until_failure): Adjust accordingly.
9081 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9083 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9085 * dispextern.h (string_buffer_position): Remove declaration.
9087 * print.c (strout): Remove parameter `multibyte', unused since
9088 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9090 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9091 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9092 All callers changed.
9094 * w32.c (_wsa_errlist): Use braces for struct initializers.
9096 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9097 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9098 All callers changed.
9099 (string_buffer_position): Likewise. Also, make static (it's never
9100 used outside xdisp.c).
9101 (cursor_row_p): Remove parameter `w', unused since
9102 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9103 (decode_mode_spec): Remove parameter `precision', introduced during
9104 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9105 All callers changed.
9107 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9109 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9111 2011-03-27 Anders Lindgren <andlind@gmail.com>
9113 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9114 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9115 (ns_update_auto_hide_menu_bar): New functions.
9116 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9117 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9118 ns_constrain_all_frames.
9119 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9120 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9122 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9124 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9126 2011-03-27 Glenn Morris <rgm@gnu.org>
9128 * syssignal.h: Replace RETSIGTYPE with void.
9129 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9130 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9131 Replace SIGTYPE with void everywhere.
9132 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9133 * s/template.h (SIGTYPE): Remove commented out definition.
9135 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9137 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9138 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9140 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9142 * w32.c (read_unc_volume): Use parameter `henum', instead of
9143 global variable `wget_enum_handle'.
9145 * keymap.c (describe_vector): Remove parameters `indices' and
9146 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9147 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9149 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9151 * keyboard.c (timer_check): Remove parameter `do_it_now',
9152 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9153 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9154 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9156 * keyboard.c (read_char):
9157 * w32menu.c (w32_menu_display_help):
9158 * xmenu.c (show_help_event, menu_help_callback):
9159 Adjust calls to `show_help_echo'.
9161 * gtkutil.c (xg_maybe_add_timer):
9162 * keyboard.c (readable_events):
9163 * process.c (wait_reading_process_output):
9164 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9166 * insdel.c (adjust_markers_gap_motion):
9167 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9168 (gap_left, gap_right): Don't call it.
9170 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9172 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9173 incurred during fontification.
9175 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9177 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9178 (DEFVAR_PER_BUFFER): Don't pass it.
9180 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9181 (scrolling_window): Don't pass it.
9183 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9185 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9187 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9189 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9190 of variables specific to SELinux and computation of `encoded_absname'.
9192 * image.c (XPutPixel): Remove unused variable `height'.
9194 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9196 * unexw32.c (get_section_info): Remove unused variable `section'.
9198 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9199 (system_process_attributes): Remove unused variable `sess'.
9200 (sys_read): Remove unused variable `err'.
9202 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9203 (w32_wnd_proc): Remove unused variable `isdead'.
9204 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9205 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9206 (x_create_tip_frame): Remove unused variable `tem'.
9208 * w32inevt.c (w32_console_read_socket):
9209 Remove unused variable `no_events'.
9211 * w32term.c (x_draw_composite_glyph_string_foreground):
9212 Remove unused variable `width'.
9214 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9216 * w32term.c (x_set_glyph_string_clipping):
9217 Don't pass uninitialized region to CombineRgn.
9219 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9221 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9222 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9223 (Fx_close_connection): Remove unused variable `i'.
9225 * w32font.c (w32font_draw): Return number of glyphs.
9226 (w32font_open_internal): Remove unused variable `i'.
9227 (w32font_driver): Add missing initializer.
9229 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9230 (fill_in_menu): Remove unused variable `items_added'.
9232 * w32term.c (last_mouse_press_frame): Remove static global variable.
9233 (w32_clip_to_row): Remove unused variable `f'.
9234 (x_delete_terminal): Remove unused variable `i'.
9236 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9237 (NOTHING): Remove unused static global variable.
9238 (uniscribe_check_otf): Remove unused variable `table'.
9239 (uniscribe_font_driver): Add missing initializers.
9241 2011-03-23 Julien Danjou <julien@danjou.info>
9243 * term.c (Fsuspend_tty, Fresume_tty):
9244 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9245 * window.c (temp_output_buffer_show):
9246 * insdel.c (signal_before_change):
9247 * frame.c (Fhandle_switch_frame):
9248 * fileio.c (Fdo_auto_save):
9249 * emacs.c (Fkill_emacs):
9250 * editfns.c (save_excursion_restore):
9251 * cmds.c (internal_self_insert):
9252 * callint.c (Fcall_interactively):
9253 * buffer.c (Fkill_all_local_variables):
9254 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9256 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9257 unconditionally since it does the check itself.
9259 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9261 Fix more problems found by GCC 4.5.2's static checks.
9263 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9264 the first time through the loop, since we know p0 < p1 then.
9265 This also avoids a gcc -Wstrict-overflow warning.
9267 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9268 leading to a memory leak, possible in functions like
9269 load_charset_map_from_file that can allocate an unbounded number
9270 of objects (Bug#8318).
9272 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9273 that could (at least in theory) be that large.
9275 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9276 This is less likely to overflow, and avoids undefined behavior if
9277 overflow does occur. All callers changed. Use strtoul to scan
9278 for the unsigned long integer.
9279 (pint2hrstr): Simplify and tune code slightly.
9280 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9282 * scroll.c (do_scrolling): Work around GCC bug 48228.
9283 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9285 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9286 This also avoids a warning with gcc -Wstrict-overflow.
9287 (validate_x_resource_name): Simplify count usage.
9288 This also avoids a warning with gcc -Wstrict-overflow.
9290 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9293 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9295 * process.c (Fmake_network_process): Use socklen_t, not int,
9296 where POSIX says socklen_t is required in portable programs.
9297 This fixes a porting bug on hosts like 64-bit HP-UX, where
9298 socklen_t is wider than int (Bug#8277).
9299 (Fmake_network_process, server_accept_connection):
9300 (wait_reading_process_output, read_process_output):
9303 * process.c: Rename or move locals to avoid shadowing.
9304 (list_processes_1, Fmake_network_process):
9305 (read_process_output_error_handler, exec_sentinel_error_handler):
9306 Rename or move locals.
9307 (Fmake_network_process): Define label "retry_connect" only if needed.
9308 (Fnetwork_interface_info): Fix pointer signedness.
9309 (process_send_signal): Add cast to avoid pointer signedness problem.
9310 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9311 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9313 Make tparam.h and terminfo.c consistent.
9314 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9315 Include tparam.h instead, since it declares them.
9316 * cm.h (PC): Remove extern decl; tparam.h now does this.
9317 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9318 * terminfo.c: Include tparam.h, to check interfaces.
9319 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9320 (tparam): Adjust signature to match interface in tparam.h;
9321 this removes some undefined behavior. Check that outstring and len
9322 are zero, which they always are with Emacs.
9323 * tparam.h (PC, BC, UP): New extern decls.
9325 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9326 (xftfont_open): Rename locals to avoid shadowing.
9328 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9329 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9330 (OTF_TAG_SYM): Omit macro if not needed.
9331 (ftfont_list): Remove unused local.
9332 (get_adstyle_property, ftfont_pattern_entity):
9333 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9334 Rename locals to avoid shadowing.
9336 * xfont.c (xfont_list_family): Mark var as initialized.
9338 * xml.c (make_dom): Now static.
9340 * composite.c (composition_compute_stop_pos): Rename local to
9342 (composition_reseat_it): Remove unused locals.
9343 (find_automatic_composition, composition_adjust_point): Likewise.
9344 (composition_update_it): Mark var as initialized.
9345 (find_automatic_composition): Mark vars as initialized,
9346 with a FIXME (Bug#8290).
9348 character.h: Rename locals to avoid shadowing.
9349 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9350 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9351 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9352 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9355 * textprop.c (property_change_between_p): Remove; unused.
9357 * intervals.c (interval_start_pos): Now static.
9359 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9361 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9362 Rename locals to avoid shadowing.
9364 * sound.c (wav_play, au_play, Fplay_sound_internal):
9365 Fix pointer signedness.
9366 (alsa_choose_format): Remove unused local var.
9367 (wav_play): Initialize a variable to 0, to prevent undefined
9368 behavior (Bug#8278).
9370 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9372 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9374 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9375 clobbering (Bug#8298).
9376 * sysdep.c (sys_subshell): Likewise.
9377 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9379 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9380 This should get cleaned up, so that child_setup has the
9381 same signature on all platforms.
9383 * callproc.c (call_process_cleanup): Now static.
9384 (relocate_fd): Rename locals to avoid shadowing.
9386 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9388 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9389 not to be necessary, and produces flickering.
9391 2011-03-20 Glenn Morris <rgm@gnu.org>
9393 * config.in: Remove file.
9395 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9397 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9398 are now in src/globals.h.
9399 (syms_of_minibuf): Remove spurious & from previous change.
9401 2011-03-20 Leo Liu <sdl.web@gmail.com>
9403 * minibuf.c (completing-read-function): New variable.
9404 (completing-read-default): Rename from completing-read.
9405 (completing-read): Call completing-read-function.
9407 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9409 * xfaces.c (Fx_load_color_file):
9410 Read color file from absolute filename (bug#8250).
9412 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9414 * makefile.w32-in: Update dependencies.
9416 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9418 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9420 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9422 Fix more problems found by GCC 4.5.2's static checks.
9424 * process.c (make_serial_process_unwind, send_process_trap):
9425 (sigchld_handler): Now static.
9427 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9428 That way, the code declares only the vars that it needs.
9429 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9430 * s/cygwin.h (PTY_ITERATION): Likewise.
9431 * s/darwin.h (PTY_ITERATION): Likewise.
9432 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9434 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9435 * process.c (allocate_pty): Don't declare stb unless it's needed.
9437 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9438 (CONSTANTLIM): Remove; unused.
9439 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9440 Define only if needed.
9442 * unexelf.c (unexec): Name an expression,
9443 to avoid gcc -Wbad-function-cast warning.
9444 Use a different way to cause a compilation error if anyone uses
9445 n rather than nn, a way that does not involve shadowing.
9446 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9448 * deps.mk (unexalpha.o): Remove; unused.
9450 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9451 * unexec.h: New file.
9452 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9453 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9455 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9456 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9457 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9458 Change as necessary to match prototype in unexec.h.
9460 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9462 (back_comment, skip_chars): Mark vars as initialized.
9464 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9465 Rename locals to avoid shadowing.
9467 * lread.c (read1): Rewrite so as not to use empty "else".
9468 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9470 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9472 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9473 warning when compiling print.c.
9475 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9476 instead of using an uninitialized var.
9477 (font_sort_entities): Mark var as initialized.
9479 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9481 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9482 pointers to constants.
9483 (font_parse_fcname): Remove unused vars.
9484 (font_delete_unmatched): Now static.
9485 (font_get_spec): Remove; unused.
9486 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9487 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9488 Rename or move locals to avoid shadowing.
9490 * fns.c (require_nesting_list, require_unwind): Now static.
9491 (Ffillarray): Rename locals to avoid shadowing.
9493 * floatfns.c (domain_error2): Define only if needed.
9494 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9496 * alloc.c (mark_backtrace): Move decl from here ...
9497 * lisp.h: ... to here, so that it can be checked.
9499 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9500 (Fdefvar): Rewrite so as not to use empty "else".
9501 (lisp_indirect_variable): Name an expression,
9502 to avoid gcc -Wbad-function-cast warning.
9503 (Fdefvar): Rename locals to avoid shadowing.
9505 * callint.c (quotify_arg, quotify_args): Now static.
9506 (Fcall_interactively): Rename locals to avoid shadowing.
9507 Use const pointer when appropriate.
9509 * lisp.h (get_system_name, get_operating_system_release):
9510 Move decls here, to check interfaces.
9511 * process.c (get_operating_system_release): Move decl to lisp.h.
9512 * xrdb.c (get_system_name): Likewise.
9513 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9514 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9515 some of which prompt warnings from gcc -Wbad-function-cast.
9516 (Fformat_time_string, Fencode_time, Finsert_char):
9517 (Ftranslate_region_internal, Fformat):
9518 Rename or remove local vars to avoid shadowing.
9519 (Ftranslate_region_internal): Mark var as initialized.
9521 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9524 * lisp.h (eassert): Check that the argument compiles, even if
9525 ENABLE_CHECKING is not defined.
9527 * data.c (Findirect_variable): Name an expression, to avoid
9528 gcc -Wbad-function-cast warning.
9529 (default_value, arithcompare, arith_driver, arith_error): Now static.
9530 (store_symval_forwarding): Rename local to avoid shadowing.
9531 (Fmake_variable_buffer_local, Fmake_local_variable):
9532 Mark variables as initialized.
9533 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9535 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9536 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9537 Rename locals to avoid shadowing.
9538 (mark_stack): Move local variables into the #ifdef region where
9540 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9541 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9543 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9544 (GC_STRING_CHARS): Remove; not used.
9545 (Fmemory_limit): Cast sbrk's returned value to char *.
9547 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9548 avoids undefined behavior in theory.
9550 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9552 Use functions, not macros, for up- and down-casing (Bug#8254).
9553 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9554 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9555 to use the following functions instead of these macros.
9556 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9557 EMACS_INT, since callers assume the returned value fits in int.
9558 (upcase1): Likewise, for UPCASE_TABLE.
9559 (uppercasep, lowercasep, upcase): New static inline functions.
9560 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9561 the race-condition problem in the old DOWNCASE.
9563 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9564 Rename locals to avoid shadowing.
9565 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9566 (regex_compile, re_search_2, re_match_2_internal):
9567 Remove unused local vars.
9568 (FREE_VAR): Rewrite so as not to use empty "else",
9569 which gcc can warn about.
9570 (regex_compile, re_match_2_internal): Mark locals as initialized.
9571 (RETALLOC_IF): Define only if needed.
9572 (WORDCHAR_P): Likewise. This one is never needed, but is used
9573 only in a comment talking about a compiler bug, so put inside
9574 the #if 0 of that comment.
9575 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9576 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9579 * search.c (boyer_moore): Rename locals to avoid shadowing.
9580 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9581 (PREV_CHAR_BOUNDARY): Likewise.
9583 * search.c (simple_search): Remove unused var.
9585 * dired.c (compile_pattern): Move decl from here ...
9586 * lisp.h: ... to here, so that it can be checked.
9587 (struct re_registers): New forward decl.
9589 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9591 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9593 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9594 Rename locals to avoid shadowing.
9595 (Fvertical_motion): Mark locals as initialized.
9597 * casefiddle.c (casify_object, casify_region): Now static.
9598 (casify_region): Mark local as initialized.
9600 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9602 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9603 New macros, so that the caller can use some names other than
9604 gcpro1, gcpro2, etc.
9605 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9607 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9608 argument, for consistency with GCPRO2_VAR, etc: it is now the
9609 prefix of the variable, not the variable itself. All uses
9611 * dired.c (directory_files_internal, file_name_completion):
9612 Rename locals to avoid shadowing.
9614 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9615 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9616 dired.c's scmp function, had undefined behavior.
9617 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9618 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9619 * buffer.h: ... to here, because these macros use current_buffer,
9620 and the new implementation with inline functions needs to have
9621 current_buffer in scope now, rather than later when the macros
9623 (downcase, upcase1): New static inline functions.
9624 (DOWNCASE, UPCASE1): Reimplement using these functions.
9625 This avoids undefined behavior in expressions like
9626 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9627 from race conditions in accessing the global variables
9628 case_temp1 and case_temp2.
9629 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9630 * lisp.h (case_temp1, case_temp2): Remove their decls.
9631 * character.h (ASCII_CHAR_P): Move from here ...
9632 * lisp.h: ... to here, so that the inline functions mentioned
9635 * dired.c (directory_files_internal_unwind): Now static.
9637 * fileio.c (file_name_as_directory, directory_file_name):
9638 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9640 (file_name_as_directory): Use const pointers when appropriate.
9641 (Fexpand_file_name): Likewise. In particular, newdir might
9642 point at constant storage, so make it a const pointer.
9643 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9644 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9646 (Fset_file_times, Finsert_file_contents, auto_save_error):
9647 Rename locals to avoid shadowing.
9649 * minibuf.c (choose_minibuf_frame_1): Now static.
9650 (Ftry_completion, Fall_completions): Rename or remove locals
9653 * marker.c (bytepos_to_charpos): Remove; unused.
9655 * lisp.h (verify_bytepos, count_markers): New decls,
9656 so that gcc does not warn that these functions aren't declared.
9658 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9659 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9660 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9661 (copy_text): Remove unused local var.
9663 * filelock.c (within_one_second): Now static.
9664 (lock_file_1): Rename local to avoid shadowing.
9666 * buffer.c (fix_overlays_before): Mark locals as initialized.
9667 (fix_start_end_in_overlays): Likewise. This function should be
9668 simplified by using pointers-to-pointers, but that's a different
9670 (switch_to_buffer_1): Now static.
9671 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9672 (report_overlay_modification): Rename locals to avoid shadowing.
9674 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9675 Fix pointer signedness issue.
9676 (sys_subshell): Mark local as volatile if checking for lint,
9677 to suppress a gcc -Wclobbered warning that does not seem to be right.
9678 (MAXPATHLEN): Define only if needed.
9680 * process.c (serial_open, serial_configure): Move decls from here ...
9681 * systty.h: ... to here, so that they can be checked.
9683 * fns.c (get_random, seed_random): Move extern decls from here ...
9684 * lisp.h: ... to here, so that they can be checked.
9686 * sysdep.c (reset_io): Now static.
9687 (wait_for_termination_signal): Remove; unused.
9689 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9690 (copy_keymap_item, append_key, push_text_char_description):
9692 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9693 (DENSE_TABLE_SIZE): Remove; unused.
9694 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9695 (describe_map_tree):
9696 Rename locals to avoid shadowing.
9698 * keyboard.c: Declare functions static if they are not used elsewhere.
9699 (echo_char, echo_dash, cmd_error, top_level_2):
9700 (poll_for_input, handle_async_input): Now static.
9701 (read_char, kbd_buffer_get_event, make_lispy_position):
9702 (make_lispy_event, make_lispy_movement, apply_modifiers):
9703 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9704 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9705 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9706 (read_key_sequence, read_char): Mark locals as initialized.
9707 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9709 * keyboard.h (make_ctrl_char): New decl.
9710 (mark_kboards): Move decl here ...
9711 * alloc.c (mark_kboards): ... from here.
9713 * lisp.h (force_auto_save_soon): New decl.
9715 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9716 (DEFINE_DUMMY_FUNCTION): New macro.
9717 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9719 (main): Add casts to avoid warnings
9720 if GCC considers string literals to be constants.
9722 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9724 * dbusbind.c: Pointer signedness fixes.
9725 (xd_signature, xd_append_arg, xd_initialize):
9726 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9727 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9728 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9729 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9731 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9732 if GCC considers string literals to be constants.
9733 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9735 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9737 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9738 (print_preprocess, print_object): New macro to fix last change.
9740 * print.c (print_preprocess): Don't forget font objects.
9742 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9744 * emacs.c (USAGE3): Doc fixes.
9746 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9748 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9751 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9753 * lisp.h (VWindow_system, Qfile_name_history):
9754 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9755 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9756 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9758 * w32select.c: Don't #include "keyboard.h".
9759 (run_protected): Add extern declaration for waiting_for_input.
9761 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9762 * w32console.c (detect_input_pending, read_input_pending)
9763 (encode_terminal_code):
9764 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9765 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9766 (w32_system_caret_y, Qfile_name_history):
9767 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9768 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9769 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9770 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9771 * w32proc.c (Qlocal, report_file_error):
9772 * w32term.c (Vwindow_system, updating_frame):
9773 * w32uniscribe.c (initialized, uniscribe_font_driver):
9774 Remove unneeded extern declarations.
9776 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9778 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9780 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9782 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9783 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9784 These macros can no longer be used for assignment.
9786 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9787 Assign struct members directly, instead of using BUF_BEGV etc.
9788 (record_buffer_markers, fetch_buffer_markers): New functions for
9789 recording and fetching special buffer markers.
9790 (set_buffer_internal_1, set_buffer_temp): Use them.
9792 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9794 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9796 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9797 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9799 * xdisp.c (hscroll_window_tree):
9800 (reconsider_clip_changes): Use PT instead of BUF_PT.
9802 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9804 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9805 $(EMACS_ROOT)/lib/intprops.h.
9807 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9809 Fix more problems found by GCC 4.5.2's static checks.
9811 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9812 to unsigned char * to avoid compiler diagnostic.
9813 (xg_free_frame_widgets): Make it clear that a local variable is
9814 needed only if USE_GTK_TOOLTIP.
9815 (gdk_window_get_screen): Make it clear that this macro is needed
9816 only if USE_GTK_TOOLTIP.
9817 (int_gtk_range_get_value): New function, which avoids a diagnostic
9818 from gcc -Wbad-function-cast.
9819 (xg_set_toolkit_scroll_bar_thumb): Use it.
9820 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9821 diagnostic from gcc -Wbad-function-cast.
9822 (get_utf8_string, xg_get_file_with_chooser):
9823 Rename locals to avoid shadowing.
9824 (create_dialog): Move locals to avoid shadowing.
9826 * xgselect.c (xg_select): Remove unused var.
9828 * image.c (four_corners_best): Mark locals as initialized.
9829 (gif_load): Initialize transparent_p to zero (Bug#8238).
9830 Mark another local as initialized.
9831 (my_png_error, my_error_exit): Mark with NO_RETURN.
9833 * image.c (clear_image_cache): Now static.
9834 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9835 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9836 (x_edge_detection): Remove unnecessary cast that
9837 gcc -Wbad-function-cast diagnoses.
9838 (gif_load): Fix pointer signedness.
9839 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9840 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9842 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9844 Improve quality of tests for time stamp overflow.
9845 For example, without this patch (encode-time 0 0 0 1 1
9846 1152921504606846976) returns the obviously-bogus value (-948597
9847 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9848 reports time overflow. See
9849 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9850 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9851 * editfns.c: Include limits.h and intprops.h.
9852 (TIME_T_MIN, TIME_T_MAX): New macros.
9853 (time_overflow): Move earlier, to before first use.
9854 (hi_time, lo_time): New functions, for an accurate test for
9856 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9857 (Fget_internal_run_time): Don't assume time_t fits in int.
9858 (make_time): Use list2 instead of Fcons twice.
9859 (Fdecode_time): More accurate test for out-of-range times.
9860 (check_tm_member): New function.
9861 (Fencode_time): Use it, to test for out-of-range times.
9862 (lisp_time_argument): Don't rely on undefined left-shift and
9863 right-shift behavior when checking for time stamp overflow.
9865 * editfns.c (time_overflow): New function, refactoring common code.
9866 (Fformat_time_string, Fdecode_time, Fencode_time):
9867 (Fcurrent_time_string): Use it.
9869 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9870 * dired.c (make_time): Move to ...
9871 * editfns.c (make_time): ... here.
9872 * systime.h: Note the move.
9874 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9876 * fringe.c (update_window_fringes): Remove unused variables.
9878 * unexmacosx.c (copy_data_segment): Also copy __got section.
9881 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9883 * termcap.c [MSDOS]: Include "msdos.h".
9884 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9885 Constify `char *' arguments and their references according to
9886 prototypes in tparam.h.
9888 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9890 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9891 Adapt all references accordingly.
9893 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9895 2011-03-11 Tom Tromey <tromey@redhat.com>
9897 * buffer.c (syms_of_buffer): Remove obsolete comment.
9899 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9901 * termhooks.h (encode_terminal_code): Declare prototype.
9903 * msdos.c (encode_terminal_code): Don't declare prototype.
9905 * term.c (encode_terminal_code): Now external again, used by
9906 w32console.c and msdos.c.
9908 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9909 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9911 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9913 Fix some minor problems found by GCC 4.5.2's static checks.
9915 * fringe.c (update_window_fringes): Mark locals as initialized
9917 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9919 * alloc.c (mark_fringe_data): Move decl from here ...
9920 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9921 to check its interface.
9922 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9924 * fontset.c (free_realized_fontset): Now static.
9925 (Fset_fontset_font): Rename local to avoid shadowing.
9926 (fontset_font): Mark local as initialized.
9927 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9929 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9931 * xselect.c (x_disown_buffer_selections): Remove; not used.
9932 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9933 (x_own_selection, Fx_disown_selection_internal): Rename locals
9935 (x_handle_dnd_message): Remove local to avoid shadowing.
9937 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9938 so that the caller can use some name other than gcpro1.
9939 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9940 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9941 (Fx_backspace_delete_keys_p):
9942 Use them to avoid shadowing, and rename vars to avoid shadowing.
9943 (x_decode_color, x_set_name, x_window): Now static.
9944 (Fx_create_frame): Add braces to silence GCC warning.
9945 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9946 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9947 Remove unused locals.
9948 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9949 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9950 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9953 * xterm.h (x_mouse_leave): New decl.
9955 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9956 Remove unused functions.
9957 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9958 (x_calc_absolute_position): Now static.
9959 (XTread_socket): Don't define label "out" unless it's used.
9960 Don't declare local "event" unless it's used.
9961 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9962 unless they are used.
9963 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9964 (x_fatal_error_signal): Remove; not used.
9965 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9966 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9967 (x_error_catcher, x_connection_closed, x_error_handler):
9968 (x_error_quitter, xembed_send_message, x_iconify_frame):
9969 (my_log_handler): Rename locals to avoid shadowing.
9970 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9971 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9973 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9974 Rename or move locals to avoid shadowing.
9975 (tty_defined_color, merge_face_heights): Now static.
9976 (free_realized_faces_for_fontset): Remove; not used.
9977 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9978 does not deduce is never used uninitialized.
9979 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9980 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9982 * terminal.c (store_terminal_param): Now static.
9984 * xmenu.c (menu_highlight_callback): Now static.
9985 (set_frame_menubar): Remove unused local.
9986 (xmenu_show): Rename parameter to avoid shadowing.
9987 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9988 since they might point to immutable storage.
9989 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9990 since it's unused otherwise.
9992 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9993 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9994 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9995 avoids a gcc -Wuninitialized diagnostic.
9996 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9997 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9998 does not deduce are never used uninitialized.
10000 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10002 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
10003 * window.c (window_loop, size_window):
10004 (run_window_configuration_change_hook, enlarge_window): Likewise.
10006 * window.c (display_buffer): Now static.
10007 (size_window): Mark variables that gcc -Wuninitialized
10008 does not deduce are never used uninitialized.
10009 * window.h (check_all_windows): New decl, to forestall
10010 gcc -Wmissing-prototypes diagnostic.
10011 * dispextern.h (bidi_dump_cached_states): Likewise.
10013 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10015 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
10016 Include <limits.h>.
10017 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10018 and to avoid gcc -Wuninitialized warning.
10019 (load_charset_map): Mark variables that gcc -Wuninitialized
10020 does not deduce are never used uninitialized.
10021 (load_charset): Abort instead of using uninitialized var (Bug#8229).
10023 * coding.c (coding_set_source, coding_set_destination):
10024 Use "else { /* comment */ }" rather than "else /* comment */;"
10025 for clarity, and to avoid gcc -Wempty-body warning.
10026 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10027 a block, when the outer 'i' will do.
10028 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10029 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10030 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10031 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10032 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10033 Rename locals to avoid shadowing.
10034 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
10035 * coding.c (emacs_mule_char, encode_invocation_designation):
10036 Now static, since they're not used elsewhere.
10037 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
10038 (decode_coding_object, encode_coding_object, detect_coding_system):
10039 (decode_coding_emacs_mule): Mark variables that gcc
10040 -Wuninitialized does not deduce are never used uninitialized.
10041 (detect_coding_iso_2022): Initialize a local variable that might
10042 be used uninitialized. Leave a FIXME because it's not clear that
10043 this initialization is needed. (Bug#8211)
10044 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10045 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10046 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10047 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10048 Remove unused macros.
10050 * category.c (hash_get_category_set): Remove unused local var.
10051 (copy_category_table): Now static, since it's not used elsewhere.
10052 * character.c (string_count_byte8): Likewise.
10054 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10055 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10057 * chartab.c (copy_sub_char_table): Now static, since it's not used
10059 (sub_char_table_ref_and_range, char_table_ref_and_range):
10060 Rename locals to avoid shadowing.
10061 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
10063 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
10064 (BIDI_BOB): Remove unused macro.
10066 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10067 deduce are never used uninitialized.
10068 * term.c (encode_terminal_code): Likewise.
10070 * term.c (encode_terminal_code): Now static. Remove unused local.
10072 * tparam.h: New file.
10073 * term.c, tparam.h: Include it.
10074 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10075 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10076 Move these decls to tparam.h, and make them agree with what
10077 is actually in tparam.c. The previous trick of using incompatible
10078 decls in different modules does not conform to the C standard.
10079 All callers of tparam changed to use tparam's actual API.
10080 * tparam.c (tparam1, tparam, tgoto):
10081 Use const pointers where appropriate.
10083 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10084 * cm.h (struct cm): Likewise.
10085 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10086 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10087 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10088 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10089 (turn_on_face, init_tty): Likewise.
10090 * termchar.h (struct tty_display_info): Likewise.
10092 * term.c (term_mouse_position): Rename local to avoid shadowing.
10094 * alloc.c (mark_ttys): Move decl from here ...
10095 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10097 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10099 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10101 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
10103 * search.c (compile_pattern_1): Remove argument regp, unused since
10104 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10105 (compile_pattern): Don't pass it.
10107 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10109 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10110 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10112 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10114 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10116 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10117 gdk_window_get_screen, gdk_window_get_geometry,
10118 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10119 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10120 (xg_get_pixbuf_from_pixmap): New function.
10121 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10122 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10123 Call xg_get_pixbuf_from_pixmap instead of
10124 gdk_pixbuf_get_from_drawable.
10125 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10126 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10127 (xg_check_special_colors): Use GtkStyleContext and its functions
10129 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10130 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10131 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10132 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10133 Call gtk_widget_get_preferred_size.
10134 (xg_frame_resized): gdk_window_get_geometry only takes 5
10136 (xg_win_to_widget, xg_event_is_for_menubar):
10137 Call gdk_x11_window_lookup_for_display.
10138 (xg_set_widget_bg): New function.
10139 (delete_cb): New function.
10140 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10141 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10142 (xg_set_background_color): Call xg_set_widget_bg.
10143 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10144 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10145 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10146 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10148 (update_frame_tool_bar): Call gtk_widget_hide.
10149 (xg_initialize): Use GDK_KEY_g.
10151 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10153 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10155 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10156 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10157 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10159 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10161 * w32xfns.c (select_palette): Check success of RealizePalette against
10162 GDI_ERROR, not zero.
10164 See ChangeLog.11 for earlier changes.
10166 ;; Local Variables:
10170 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10172 This file is part of GNU Emacs.
10174 GNU Emacs is free software: you can redistribute it and/or modify
10175 it under the terms of the GNU General Public License as published by
10176 the Free Software Foundation, either version 3 of the License, or
10177 (at your option) any later version.
10179 GNU Emacs is distributed in the hope that it will be useful,
10180 but WITHOUT ANY WARRANTY; without even the implied warranty of
10181 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10182 GNU General Public License for more details.
10184 You should have received a copy of the GNU General Public License
10185 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.