Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
1 2011-10-13 Paul Eggert <eggert@cs.ucla.edu>
2
3 Fix integer width and related bugs.
4 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
5 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
6 (string_bytes, check_sblock, allocate_string_data):
7 (compact_small_strings, Fmake_bool_vector, make_string)
8 (make_unibyte_string, make_multibyte_string)
9 (make_string_from_bytes, make_specified_string)
10 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
11 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
12 (mark_vectorlike):
13 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
14 (allocate_pseudovector):
15 Use int, not EMACS_INT, where int is wide enough.
16 (inhibit_garbage_collection, Fgarbage_collect):
17 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
18 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
19 int might not be wide enough.
20 (bidi_cache_search, bidi_cache_find, bidi_init_it)
21 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
22 (bidi_at_paragraph_end, bidi_find_paragraph_start)
23 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
24 (bidi_level_of_next_char, bidi_move_to_visually_next):
25 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
26 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
27 (Fkill_buffer, Fset_buffer_major_mode)
28 (advance_to_char_boundary, Fbuffer_swap_text)
29 (Fset_buffer_multibyte, overlays_at, overlays_in)
30 (overlay_touches_p, struct sortvec, record_overlay_string)
31 (overlay_strings, recenter_overlay_lists)
32 (adjust_overlays_for_insert, adjust_overlays_for_delete)
33 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
34 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
35 (Foverlay_recenter, last_overlay_modification_hooks_used)
36 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
37 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
38 (validate_region): Omit unnecessary test for b <= e,
39 since that's guaranteed by the previous test.
40 (adjust_overlays_for_delete): Avoid pos + length overflow.
41 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
42 (report_overlay_modification):
43 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
44 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
45 Omit pointer cast, which isn't needed anyway, and doesn't work
46 after the EMACS_INT -> ptrdiff_t change.
47 (Fmove_overlay): Delete an evaporating overlay
48 if it becomes empty after its bounds are adjusted to fit within
49 its buffer. Without this fix, in a nonempty buffer (let ((o
50 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
51 yields an empty overlay that has the evaporate property, which is
52 not supposed to happen. (Bug#9642)
53 * buffer.h: Adjust decls to match defn changes elsewhere.
54 (struct buffer_text, struct buffer):
55 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
56 Use EMACS_INT, not int, where int might not be wide enough.
57 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
58 not int, to avoid needless 32-bit limit on 64-bit hosts.
59 (exec_byte_code): Use tighter memory-full test, one that checks
60 for alloca overflow. Don't compute the address of the object just
61 before an array, as that's not portable. Use EMACS_INT, not
62 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
63 * callint.c (Fcall_interactively):
64 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
65 * callproc.c (call_process_kill, Fcall_process):
66 Don't assume pid_t fits into an Emacs fixnum.
67 (call_process_cleanup, Fcall_process, child_setup):
68 Don't assume pid_t fits into int.
69 (call_process_cleanup, Fcall_process, delete_temp_file)
70 (Fcall_process_region):
71 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
72 (Fcall_process): Simplify handling of volatile integers.
73 Use int, not EMACS_INT, where int will do.
74 * casefiddle.c (casify_object, casify_region, operate_on_word)
75 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
76 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
77 (casify_object): Avoid integer overflow when overallocating buffer.
78 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
79 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
80 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
81 * category.h (CATEGORYP): Don't assume arg is nonnegative.
82 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
83 integers are now checked earlier. All uses replaced with XINT.
84 (ccl_driver):
85 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
86 For CCL_MapSingle, check that content and value are in int range.
87 (ccl_driver, Fregister_code_conversion_map):
88 Check that Vcode_version_map_vector is a vector.
89 (resolve_symbol_ccl_program): Check that vector header is in range.
90 Always copy the vector, so that we can check its contents reliably
91 now rather than having to recheck each instruction as it's being
92 executed. Check that vector words fit in 'int'.
93 (ccl_get_compiled_code, Fregister_ccl_program)
94 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
95 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
96 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
97 contents are in range.
98 (Fccl_execute_on_string): Check that status is in range.
99 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
100 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
101 Accept and return EMACS_INT, not int, because callers can pass values
102 out of 'int' range.
103 (c_string_width, strwidth, lisp_string_width, chars_in_text)
104 (multibyte_chars_in_text, parse_str_as_multibyte)
105 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
106 (str_as_unibyte, str_to_unibyte, string_count_byte8)
107 (string_escape_byte8, Fget_byte):
108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
109 (Funibyte_string): Use CHECK_CHARACTER, not CHECK_NATNUM, to
110 avoid mishandling large integers.
111 * character.h: Adjust decls to match defn changes elsewhere.
112 * charset.c (load_charset_map_from_file, find_charsets_in_text)
113 (Ffind_charset_region):
114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
115 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
116 (load_charset_map_from_vector, Fdefine_charset_internal):
117 Don't assume fixnum fits in int.
118 (load_charset_map_from_vector, Fmap_charset_chars):
119 Remove now-unnecessary CHECK_NATNUMs.
120 (Fdefine_charset_internal): Check ranges here, more carefully.
121 Don't rely on undefined behavior with signed left shift overflow.
122 Don't assume unsigned int fits into fixnum, or that fixnum fits
123 into unsigned int. Don't require max_code to be a valid fixnum;
124 that's not true for gb10830 4-byte on a 32-bit host. Allow
125 invalid_code to be a cons, for the same reason. Require code_offset
126 to be a character. Avoid int overflow if max_char is close
127 to INT_MAX.
128 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
129 this is intended anyway and avoids some undefined behavior.
130 (load_charset_map): Pass unsigned, not int, as 2nd arg of
131 INDEX_TO_CODE_POINT, as that's what it expects.
132 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
133 * charset.h (DECODE_CHAR): Return int, not unsigned;
134 this is what was intended anyway, and it avoids undefined behavior.
135 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
136 integer-overflow issues.
137 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
138 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
139 where the argument is EMACS_INT, and this behavior is not intended.
140 * chartab.c (Fmake_char_table, Fset_char_table_range)
141 (uniprop_get_decoder, uniprop_get_encoder):
142 Don't assume fixnum fits in int.
143 * cmds.c (move_point): New function, that does the gist of
144 Fforward_char and Fbackward_char, but does so while checking
145 for integer overflow more accurately.
146 (Fforward_char, Fbackward_char): Use it.
147 (Fforward_line, Fend_of_line, internal_self_insert)
148 (internal_self_insert):
149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
150 Fix a FIXME, by checking for integer overflow when calculating
151 target_clm and actual_clm.
152 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
153 (ASSURE_DESTINATION, coding_alloc_by_realloc)
154 (coding_alloc_by_making_gap, alloc_destination)
155 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
156 (encode_coding_utf_16, detect_coding_emacs_mule)
157 (decode_coding_emacs_mule, encode_coding_emacs_mule)
158 (detect_coding_iso_2022, decode_coding_iso_2022)
159 (encode_invocation_designation, encode_designation_at_bol)
160 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
161 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
162 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
163 (encode_coding_ccl, encode_coding_raw_text)
164 (detect_coding_charset, decode_coding_charset)
165 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
166 (produce_composition, produce_charset, produce_annotation)
167 (decode_coding, handle_composition_annotation)
168 (handle_charset_annotation, consume_chars, decode_coding_gap)
169 (decode_coding_object, encode_coding_object, detect_coding_system)
170 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
171 (code_convert_region, code_convert_string)
172 (Fdefine_coding_system_internal):
173 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
174 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
175 (Fdefine_coding_system_internal):
176 Don't assume fixnums fit in int.
177 (decode_coding_gap, decode_coding_object, encode_coding_object)
178 (Fread_coding_system, Fdetect_coding_region)
179 (Funencodable_char_position, Fcheck_coding_systems_region)
180 (get_translation, handle_composition_annotation, consume_chars):
181 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
182 (consume_chars): Rewrite to not calculate an address outside buffer.
183 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
184 Don't access memory outside of the args array.
185 (Fdefine_coding_system_internal): Check for charset-id overflow.
186 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
187 result of ENCODE_CHAR.
188 * coding.h: Adjust decls to match defn changes elsewhere.
189 (struct coding_system):
190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
191 * composite.c (get_composition_id, find_composition)
192 (run_composition_function, update_compositions)
193 (compose_text, composition_gstring_put_cache)
194 (composition_gstring_p, composition_gstring_width)
195 (fill_gstring_header, fill_gstring_body, autocmp_chars)
196 (composition_compute_stop_pos, composition_reseat_it)
197 (composition_update_it, struct position_record)
198 (find_automatic_composition, composition_adjust_point)
199 (Fcomposition_get_gstring, Ffind_composition_internal):
200 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
201 (update_compositions):
202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
203 * composite.h: Adjust decls to match defn changes elsewhere.
204 (struct composition):
205 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
206 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
207 Do not attempt to compute the address of the object just before a
208 buffer; this is not portable.
209 (Faref, Faset):
210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
211 (Faset): Use int, not EMACS_INT, where int is wide enough.
212 (Fstring_to_number): Don't assume fixnums fit in int.
213 (Frem): Don't assume arg is nonnegative.
214 * dbusbind.c (xd_append_arg): Check for integers out of range.
215 (Fdbus_call_method): Don't overflow the timeout int.
216 * dired.c (directory_files_internal, file_name_completion, scmp)
217 (file_name_completion_stat):
218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
219 (file_name_completion): Don't overflow matchcount.
220 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
221 * dispextern.h: Adjust decls to match defn changes elsewhere.
222 (struct text_pos, struct glyph, struct bidi_saved_info)
223 (struct bidi_string_data, struct bidi_it, struct composition_it)
224 (struct it):
225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
226 (struct display_pos, struct composition_it, struct it):
227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
228 * dispnew.c (increment_matrix_positions)
229 (increment_row_positions, mode_line_string)
230 (marginal_area_string):
231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
232 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
234 (duration_to_sec_usec): New function, to check for overflow better.
235 (Fsleep_for, sit_for): Use it.
236 * doc.c (get_doc_string, store_function_docstring):
237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
238 (get_doc_string, Fsnarf_documentation):
239 Use int, not EMACS_INT, where int is wide enough.
240 (get_doc_string):
241 Use SAFE_ALLOCA, not alloca.
242 Check for overflow when converting EMACS_INT to off_t.
243 * doprnt.c (doprnt):
244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
245 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
246 Don't assume uid_t fits into fixnum.
247 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
248 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
249 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
250 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
251 (general_insert_function)
252 (Finsert_char, make_buffer_string, make_buffer_string_both)
253 (update_buffer_properties, Fbuffer_substring)
254 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
255 (Fsubst_char_in_region, check_translation)
256 (Ftranslate_region_internal, save_restriction_restore, Fformat)
257 (transpose_markers, Ftranspose_regions):
258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
259 (clip_to_bounds): Move to lisp.h as an inline function).
260 (Fconstrain_to_field): Don't assume integers are nonnegative.
261 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
262 (Fsubst_char_in_region, Fsave_restriction):
263 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
264 (Femacs_pid): Don't assume pid_t fits into fixnum.
265 (lo_time): Use int, not EMACS_INT, when int suffices.
266 (lisp_time_argument): Check for usec out of range.
267 (Fencode_time): Don't assume fixnum fits in int.
268 (Fuser_login_name, Fuser_full_name): Signal an error
269 if a uid argument is out of range, rather than relying on
270 undefined behavior.
271 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
272 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
273 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
274 (init_cmdargs, Fdump_emacs):
275 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
276 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
277 the bottom (typically) 32 bits of the fixnum.
278 * eval.c (specpdl_size, call_debugger):
279 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
280 (when_entered_debugger, Fbacktrace_debug):
281 Don't assume fixnum can fit in int.
282 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
283 the object just before a buffer; this is not portable.
284 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
285 (grow_specpdl, unbind_to):
286 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
287 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
288 (grow_specpdl): Simplify allocation by using xpalloc.
289 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
290 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
291 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
292 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
293 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
294 (a_write, e_write):
295 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
296 (Fcopy_file, non_regular_nbytes, read_non_regular)
297 (Finsert_file_contents):
298 Use int, not EMACS_INT, where int is wide enough.
299 (READ_BUF_SIZE): Verify that it fits in int.
300 (Finsert_file_contents): Check that counts are in proper range,
301 rather than assuming fixnums fit into ptrdiff_t etc.
302 Don't assume fixnums fit into int.
303 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
304 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
305 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
306 (string_char_to_byte, string_byte_to_char)
307 (string_make_multibyte, string_to_multibyte)
308 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
309 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
310 (substring_both, Fdelete, internal_equal, Ffillarray)
311 (Fclear_string, mapcar1)
312 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
313 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
314 (larger_vector, make_hash_table, maybe_resize_hash_table)
315 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
316 (Fmaphash, secure_hash):
317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
318 (concat): Check for string index and length overflow.
319 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
320 (Frequire):
321 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
322 (larger_vector): New API (vec, incr_min, size_max) replaces old
323 one (vec, new_size, init). This catches size overflow.
324 INIT was removed because it was always Qnil.
325 All callers changed.
326 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
327 the upper bound on a hash table index size.
328 (make_hash_table, maybe_resize_hash_table): Use it.
329 (secure_hash): Computer start_byte and end_byte only after
330 they're known to be in ptrdiff_t range.
331 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
332 (Ffont_get_glyphs, Ffont_at):
333 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
334 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
335 (Flist_fonts, Fopen_font):
336 Don't assume fixnum can fit in int.
337 (check_gstring): Don't assume index can fit in int.
338 (font_match_p): Check that fixnum is a character, not a nonnegative
339 fixnum, since the later code needs to stuff it into an int.
340 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
341 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
342 conversion overflow issues.
343 (Fopen_font): Check for integer out of range.
344 (Ffont_get_glyphs): Don't assume index can fit in int.
345 * font.h: Adjust decls to match defn changes elsewhere.
346 * fontset.c (reorder_font_vector): Redo score calculation to avoid
347 integer overflow.
348 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
349 printmax_t, where ptrdiff_t is wide enough.
350 (Finternal_char_font):
351 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
352 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
353 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
354 (Fset_frame_position, x_set_frame_parameters)
355 (x_set_line_spacing, x_set_border_width)
356 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
357 Check that fixnums are in proper range for system types.
358 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
360 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
361 Use SAFE_ALLOCA_LISP, not alloca.
362 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
363 intptr_t is wide enough.
364 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
365 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
366 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
367 Check for fixnum out of range.
368 * ftfont.c (ftfont_list): Don't assume index fits in int.
369 Check that fixnums are in proper range for system types.
370 (ftfont_shape_by_flt):
371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
372 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
374 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
375 Check that fixnums are in proper range for system types.
376 * gnutls.h: Adjust decls to match defn changes elsewhere.
377 * gtkutil.c (xg_dialog_run):
378 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
379 (update_frame_tool_bar):
380 Check that fixnums are in proper range for system types.
381 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
382 (lookup_image): Check that fixnums are in range for system types.
383 * indent.c (last_known_column, last_known_column_point):
384 (current_column_bol_cache):
385 (skip_invisible, current_column, check_display_width):
386 (check_display_width, scan_for_column, current_column_1)
387 (Findent_to, Fcurrent_indentation, position_indentation)
388 (indented_beyond_p, Fmove_to_column, compute_motion):
389 (Fcompute_motion, Fvertical_motion):
390 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
391 (last_known_column_modified): Use EMACS_INT, not int.
392 (check_display_width):
393 (Fcompute_motion):
394 Check that fixnums and floats are in proper range for system types.
395 (compute_motion): Don't assume index or fixnum fits in int.
396 (compute_motion, Fcompute_motion):
397 Use int, not EMACS_INT, when it is wide enough.
398 (vmotion): Omit local var start_hpos that is always 0; that way
399 we don't need to worry about overflow in expressions involving it.
400 * indent.h: Adjust decls to match defn changes elsewhere.
401 (struct position):
402 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
403 Use int, not EMACS_INT, where int is wide enough.
404 Remove unused members ovstring_chars_done and tab_offset;
405 all uses removed.
406 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
407 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
408 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
409 (make_gap, copy_text, insert, insert_and_inherit)
410 (insert_before_markers, insert_before_markers_and_inherit)
411 (insert_1, count_combining_before, count_combining_after)
412 (insert_1_both, insert_from_string)
413 (insert_from_string_before_markers, insert_from_string_1)
414 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
415 (adjust_after_replace, adjust_after_insert, replace_range)
416 (replace_range_2, del_range, del_range_1, del_range_byte)
417 (del_range_both, del_range_2, modify_region)
418 (prepare_to_modify_buffer, signal_before_change)
419 (signal_after_change, Fcombine_after_change_execute):
420 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
421 * intervals.c (traverse_intervals, rotate_right, rotate_left)
422 (balance_an_interval, split_interval_right, split_interval_left)
423 (find_interval, next_interval, update_interval)
424 (adjust_intervals_for_insertion, delete_node, delete_interval)
425 (interval_deletion_adjustment, adjust_intervals_for_deletion)
426 (static_offset_intervals, offset_intervals)
427 (merge_interval_right, merge_interval_left, make_new_interval)
428 (graft_intervals_into_buffer, temp_set_point_both)
429 (temp_set_point, set_point, adjust_for_invis_intang)
430 (set_point_both, move_if_not_intangible, get_property_and_range)
431 (get_local_map, copy_intervals, copy_intervals_to_string)
432 (compare_string_intervals, set_intervals_multibyte_1):
433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
434 * intervals.h: Adjust decls to match defn changes elsewhere.
435 (struct interval):
436 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
437 * keyboard.c (this_command_key_count, this_single_command_key_start)
438 (before_command_key_count, before_command_echo_length, echo_now)
439 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
440 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
441 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
442 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
443 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
444 (last_non_minibuf_size, last_point_position, echo_truncate)
445 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
446 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
447 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
448 (stuff_buffered_input):
449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
450 (last_auto_save, command_loop_1, read_char):
451 Use EMACS_INT, not int, to avoid integer overflow.
452 (record_char): Avoid overflow in total_keys computation.
453 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
454 * keyboard.h: Adjust decls to match defn changes elsewhere.
455 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
456 (Fkey_description, Fdescribe_vector, Flookup_key):
457 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
458 (click_position): New function, to check that positions are in range.
459 (Fcurrent_active_maps):
460 (describe_command):
461 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
462 (Faccessible_keymaps, Fkey_description):
463 (preferred_sequence_p):
464 Don't assume fixnum can fit into int.
465 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
466 Check for integer overflow in size calculations.
467 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
468 avoid mishandling large integers.
469 * lisp.h: Adjust decls to match defn changes elsewhere.
470 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
471 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
472 (struct Lisp_Marker):
473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
474 (clip_to_bounds): Now an inline function, moved here from editfns.c.
475 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
476 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
477 All callers changed.
478 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
479 Assume the arg has valid form, since it always does.
480 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
481 unsigned integer system type.
482 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
483 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
484 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
485 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
486 (duration_to_sec_usec): New decl.
487 * lread.c (read_from_string_index, read_from_string_index_byte)
488 (read_from_string_limit, readchar, unreadchar, openp)
489 (read_internal_start, read1, oblookup):
490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
491 (Fload, readevalloop, Feval_buffer, Feval_region):
492 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
493 (openp): Check for out-of-range argument to 'access'.
494 (read1): Use int, not EMACS_INT, where int is wide enough.
495 Don't assume fixnum fits into int.
496 (read_filtered_event): Use duration_to_sec_usec
497 to do proper overflow checking on durations.
498 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
499 in size calculation.
500 (Fexecute_kbd_macro):
501 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
502 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
503 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
504 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
505 (set_marker_both, set_marker_restricted_both, marker_position)
506 (marker_byte_position, Fbuffer_has_markers_at):
507 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
508 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
509 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
510 It now merely ensures that the menu is large enough, without
511 necessarily growing it, as this avoids some integer overflow issues.
512 All callers changed.
513 (keymap_panes, parse_single_submenu, Fx_popup_menu):
514 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
515 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
516 Use SAFE_ALLOCA_LISP, not alloca.
517 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
518 to EMACS_INT. Check that fixnums are in proper range for system types.
519 * minibuf.c (minibuf_prompt_width, string_to_object)
520 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
521 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
522 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
523 (get_minibuffer, read_minibuf_unwind):
524 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
525 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
526 this simplifies overflow checking. All callers changed.
527 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
528 (Ftest_completion):
529 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
530 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
531 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
532 Check that fixnums are in proper range for system types.
533 (Fx_create_frame, Fx_show_tip):
534 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
535 * nsfont.m (ns_findfonts, nsfont_list_family):
536 Don't assume fixnum fits in long.
537 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
538 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
539 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
540 wide enough.
541 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
542 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
543 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
544 (PRINTDECLARE, PRINTPREPARE):
545 (strout, print_string):
546 (print, print_preprocess, print_check_string_charset_prop)
547 (print_object):
548 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
549 (PRINTDECLARE):
550 (temp_output_buffer_setup, Fprin1_to_string, print_object):
551 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
552 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
553 (PRINTFINISH): Use SAFE_ALLOCA, not alloca.
554 (printchar, strout): Use xpalloc to catch size calculation overflow.
555 (Fexternal_debugging_output): Use CHECK_CHARACTER, not CHECK_NUMBER,
556 to avoid mishandling large integers.
557 (print_error_message): Use SAFE_ALLOCA, not alloca.
558 (print_object): Use int, not EMACS_INT, where int is wide enough.
559 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
560 (Fset_process_window_size, Fformat_network_address)
561 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
562 (sigchld_handler):
563 Check that fixnums are in proper range for system types.
564 (Fsignal_process): Simplify by avoiding a goto.
565 Check for process-ids out of pid_t range rather than relying on
566 undefined behavior.
567 (Fformat_network_address, read_process_output, send_process)
568 (Fprocess_send_region, status_notify):
569 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
570 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
571 (wait_reading_process_output, read_process_output, exec_sentinel):
572 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
573 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
574 (Faccept_process_output): Use duration_to_sec_usec to do proper
575 overflow checking on durations.
576 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
577 configured --with-wide-int.
578 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
579 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
580 * search.c (looking_at_1, string_match_1):
581 (fast_string_match, fast_c_string_match_ignore_case)
582 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
583 (scan_newline, find_before_next_newline, search_command)
584 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
585 (set_search_regs, wordify):
586 (Freplace_match):
587 (Fmatch_data):
588 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
589 (string_match_1, search_buffer, set_search_regs):
590 (Fmatch_data):
591 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
592 (wordify): Check for overflow in size calculation.
593 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
594 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
595 Check that fixnums are in proper range for system types.
596 * sound.c (struct sound_device)
597 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
598 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
599 (Fplay_sound_internal):
600 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
601 * syntax.c (ST_COMMENT_STYLE, ST_STRING_STYLE):
602 In definitions, make it clearer that these values must be out of range
603 for the respective integer ranges. This fixes a bug with
604 ST_STRING_STYLE and non-ASCII characters.
605 (struct lisp_parse_state, find_start_modiff)
606 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
607 (Fparse_partial_sexp):
608 Don't assume fixnums can fit in int.
609 (struct lisp_parse_state, find_start_pos, find_start_value)
610 (find_start_value_byte, find_start_begv)
611 (update_syntax_table, char_quoted, dec_bytepos)
612 (find_defun_start, prev_char_comend_first, back_comment):
613 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
614 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
615 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
616 (Finternal_describe_syntax_value): Check that match_lisp is a
617 character, not an integer, since the code stuffs it into int.
618 (scan_words, scan_sexps_forward):
619 Check that fixnums are in proper range for system types.
620 (Fforward_word):
621 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
622 (scan_sexps_forward):
623 Use CHARACTERP, not INTEGERP, since the value must fit into int.
624 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
625 * syntax.h: Adjust decls to match defn changes elsewhere.
626 (struct gl_state_s):
627 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
628 * sysdep.c (wait_for_termination_1, wait_for_termination)
629 (interruptible_wait_for_termination, mkdir):
630 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
631 (emacs_read, emacs_write):
632 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
633 (system_process_attributes): Don't assume uid_t, gid_t, and
634 double all fit in int or even EMACS_INT.
635 * term.c (set_tty_color_mode):
636 Check that fixnums are in proper range for system types.
637 * termhooks.h (struct input_event):
638 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
639 * textprop.c (validate_interval_range, interval_of)
640 (Fadd_text_properties, set_text_properties_1)
641 (Fremove_text_properties, Fremove_list_of_text_properties)
642 (Ftext_property_any, Ftext_property_not_all)
643 (copy_text_properties, text_property_list, extend_property_ranges)
644 (verify_interval_modification):
645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
646 (Fnext_single_char_property_change)
647 (Fprevious_single_char_property_change):
648 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
649 (copy_text_properties):
650 Check for integer overflow in index calculation.
651 * undo.c (last_boundary_position, record_point, record_insert)
652 (record_delete, record_marker_adjustment, record_change)
653 (record_property_change):
654 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
655 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
656 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
657 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
658 (Fx_hide_tip, Fx_file_dialog):
659 * w32menu.c (set_frame_menubar):
660 Use ptrdiff_t, not int, for consistency with rest of code.
661 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
662 (select_window, Fdelete_other_windows_internal)
663 (window_scroll_pixel_based, window_scroll_line_based)
664 (Frecenter, Fset_window_configuration):
665 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
666 (Fset_window_hscroll, run_window_configuration_change_hook)
667 (set_window_buffer, temp_output_buffer_show, scroll_command)
668 (Fscroll_other_window, Frecenter):
669 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
670 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
671 Don't assume fixnum fits in int.
672 (Fset_window_scroll_bars):
673 Check that fixnums are in proper range for system types.
674 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
675 (string_pos, c_string_pos, number_of_chars, init_iterator)
676 (in_ellipses_for_invisible_text_p, init_from_display_pos)
677 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
678 (compute_display_string_end, handle_face_prop)
679 (face_before_or_after_it_pos, handle_invisible_prop)
680 (handle_display_prop, handle_display_spec, handle_single_display_spec)
681 (display_prop_intangible_p, string_buffer_position_lim)
682 (string_buffer_position, handle_composition_prop, load_overlay_strings)
683 (get_overlay_strings_1, get_overlay_strings)
684 (iterate_out_of_display_property, forward_to_next_line_start)
685 (back_to_previous_visible_line_start, reseat, reseat_to_string)
686 (get_next_display_element, set_iterator_to_next)
687 (get_visually_first_element, compute_stop_pos_backwards)
688 (handle_stop_backwards, next_element_from_buffer)
689 (move_it_in_display_line_to, move_it_in_display_line)
690 (move_it_to, move_it_vertically_backward, move_it_by_lines)
691 (add_to_log, message_dolog, message_log_check_duplicate)
692 (message2, message2_nolog, message3, message3_nolog
693 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
694 (current_message_1, truncate_echo_area, truncate_message_1)
695 (set_message, set_message_1, store_mode_line_noprop)
696 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
697 (text_outside_line_unchanged_p, check_point_in_composition)
698 (reconsider_clip_changes)
699 (redisplay_internal, set_cursor_from_row, try_scrolling)
700 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
701 (redisplay_window, find_last_unchanged_at_beg_row)
702 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
703 (trailing_whitespace_p, find_row_edges, display_line)
704 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
705 (display_mode_element, store_mode_line_string)
706 (pint2str, pint2hrstr, decode_mode_spec)
707 (display_count_lines, display_string, draw_glyphs)
708 (x_produce_glyphs, x_insert_glyphs)
709 (rows_from_pos_range, mouse_face_from_buffer_pos)
710 (fast_find_string_pos, mouse_face_from_string_pos)
711 (note_mode_line_or_margin_highlight, note_mouse_highlight):
712 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
713 (safe_call, init_from_display_pos, handle_fontified_prop)
714 (handle_single_display_spec, load_overlay_strings)
715 (with_echo_area_buffer, setup_echo_area_for_printing)
716 (display_echo_area, echo_area_display)
717 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
718 (update_tool_bar, hscroll_window_tree, redisplay_internal)
719 (redisplay_window, dump_glyph_row, display_mode_line)
720 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
721 (handle_display_spec, display_prop_string_p):
722 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
723 (handle_single_display_spec, build_desired_tool_bar_string)
724 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
725 (get_specified_cursor_type):
726 Check that fixnums are in proper range for system types.
727 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
728 (Flookup_image_map):
729 Don't assume fixnums fit in int.
730 (compare_overlay_entries):
731 Avoid mishandling comparisons due to subtraction overflow.
732 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
733 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
734 (handle_tool_bar_click):
735 Use int, not unsigned, since we prefer signed and the signedness
736 doesn't matter here.
737 (get_next_display_element, next_element_from_display_vector):
738 Use int, not EMACS_INT, when int is wide enough.
739 (start_hourglass): Use duration_to_sec_usec to do proper
740 overflow checking on durations.
741 * xfaces.c (Fbitmap_spec_p):
742 Check that fixnums are in proper range for system types.
743 (compare_fonts_by_sort_order):
744 Avoid mishandling comparisons due to subtraction overflow.
745 (Fx_family_fonts, realize_basic_faces):
746 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
747 (Fx_family_fonts):
748 Don't assume fixnum fits in int.
749 Use SAFE_ALLOCA_LISP, not alloca.
750 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
751 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
752 (face_at_buffer_position, face_for_overlay_string)
753 (face_at_string_position):
754 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
755 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
756 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
757 (Fx_show_tip):
758 Check that fixnums are in proper range for system types.
759 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
760 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
761 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
762 (Fx_change_window_property): Don't assume fixnums fit in int.
763 * xfont.c (xfont_chars_supported):
764 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
765 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
766 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
767 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
768 * xml.c (parse_region):
769 * xrdb.c (magic_file_p):
770 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
771 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
772 (x_get_local_selection, x_reply_selection_request)
773 (x_handle_selection_request, wait_for_property_change):
774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
775 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
776 short is wide enough.
777 (x_send_client_event): Don't assume fixnum fits in int.
778 * xterm.c (x_x_to_emacs_modifiers):
779 Don't assume EMACS_INT overflows nicely into int.
780 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
781 may come from Lisp.
782 (handle_one_xevent): NATNUMP can eval its arg twice.
783 (x_connection_closed):
784 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
785 * xterm.h: Adjust decls to match defn changes elsewhere.
786 (struct scroll_bar): Use struct vectorlike_header
787 rather than rolling our own approximation.
788 (SCROLL_BAR_VEC_SIZE): Remove; not used.
789
790 2011-10-12 Eli Zaretskii <eliz@gnu.org>
791
792 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
793 display string and the previous row comes from the same string and
794 is empty. (Bug#9739) (Bug#9738)
795
796 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
797
798 * doc.c (get_doc_string): Encode file name (bug#9735).
799
800 2011-10-12 Eli Zaretskii <eliz@gnu.org>
801
802 * bidi.c (bidi_level_of_next_char):
803 * xdisp.c (get_visually_first_element): Remove old incorrect
804 comments regarding the Unicode Line Separator character.
805
806 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
807
808 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
809
810 * alloc.c (Fgc_status): Do not access beyond zombies array
811 boundary if nzombies > MAX_ZOMBIES.
812 * alloc.c (dump_zombies): Add missing format specifier.
813
814 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
815
816 * xdisp.c (set_cursor_from_row): Simplify conditionals,
817 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
818
819 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
820 Some packages use them to denote characters with modifiers.
821
822 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
823
824 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
825 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
826 matching a pp-number. Rename parameter var to var1.
827
828 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
829
830 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
831
832 2011-10-08 Glenn Morris <rgm@gnu.org>
833
834 * callint.c (Fcall_interactively): Give a more explicit error for the
835 'c' case with a non-character input. (Bug#8479)
836
837 2011-10-08 Eli Zaretskii <eliz@gnu.org>
838
839 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
840 lines.
841 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
842 lines that are hscrolled on the left.
843
844 * dispnew.c (buffer_posn_from_coords): Account for a possible
845 presence of header-line. (Bug#4426)
846
847 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
848
849 * buffer.c (syms_of_buffer) <enable-multibyte-characters>: Don't
850 advertise functionality which we discourage or doesn't work.
851
852 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
853
854 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
855 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
856 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
857 this makes Emacs dump core during garbage collection on rare
858 occasions. sizeof is obviously inferior to offsetof here, so
859 stick with offsetof.
860 (GC_POINTER_ALIGNMENT): New macro.
861 (mark_memory): Omit 3rd (offset) arg; caller changed.
862 Don't assume EMACS_INT alignment is the same as pointer alignment.
863
864 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
865
866 * keyboard.c (read_key_sequence_remapped): New var.
867 (read_key_sequence): Compute remapping in the right buffer.
868 (command_loop_1): Use read_key_sequence's remapping directly.
869
870 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
871
872 * dired.c (file_name_completion): Don't expand file name.
873 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
874 before checking file name handler.
875
876 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
877 they've been requested explicitly (bug#9591).
878
879 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
880
881 * keymap.c (Fsingle_key_description): Use make_specified_string
882 instead of build_string to build string from push_key_description.
883 (Bug#5193)
884
885 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
886
887 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
888 This fixes a Y2038 bug on 64-bit hosts.
889 * buffer.c (reset_buffer):
890 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
891 (Fclear_buffer_auto_save_failure):
892 Use 0, not -1, to represent an unset failure time, since time_t
893 might not be signed.
894
895 Remove dependency on glibc malloc internals.
896 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
897 Move back here from lisp.h, but with their new implementations.
898 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
899 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
900 * charset.c (charset_table_init): New static var.
901 (syms_of_charset): Use it instead of xmalloc. This removes a
902 dependency on glibc malloc internals. See Eli Zaretskii's comment in
903 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
904 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
905 Move back to alloc.c.
906 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
907 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
908
909 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
910
911 * nsterm.m (windowDidResize): Call x_set_window_size only when
912 ns_in_resize is true. Otherwise set pixelwidth/height and
913 call change_frame_size (Bug#9628).
914
915 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
916
917 Port --enable-checking=all to Fedora 14 x86-64.
918 * charset.c (syms_of_charset): Also account for glibc malloc's
919 internal overhead when calculating the initial malloc maximum.
920
921 Port --enable-checking=all to Fedora 14 x86.
922 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
923 Move to lisp.h.
924 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
925 (overrun_check_realloc, overrun_check_free):
926 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
927 That way, xmalloc returns a properly-aligned pointer even if
928 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
929 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
930 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
931 into account when calculating the initial malloc maximum.
932 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
933 Move here from alloc.c, so that charset.c can use it too.
934 Properly align; the old code wasn't right for common 32-bit hosts
935 when configured with --enable-checking=all.
936 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
937 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
938
939 2011-09-29 Eli Zaretskii <eliz@gnu.org>
940
941 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
942 use EDOM.
943
944 2011-09-28 Eli Zaretskii <eliz@gnu.org>
945
946 * xdisp.c (compute_display_string_end): If there's no display
947 string at CHARPOS, return -1.
948
949 * bidi.c (bidi_fetch_char): When compute_display_string_end
950 returns a negative value, treat the character as a normal
951 character not covered by a display string. (Bug#9624)
952
953 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
954
955 * lread.c (Fread_from_string): Fix typo in docstring.
956
957 2011-09-27 Eli Zaretskii <eliz@gnu.org>
958
959 * xdisp.c (handle_invisible_prop): If invisible text ends on a
960 newline, reseat the iterator instead of bidi-iterating there one
961 character at a time. (Bug#9610)
962 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
963 TO_CHARPOS if the bidi iterator is at base embedding level.
964
965 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
966
967 * lread.c (readevalloop): Use correct code for NBSP.
968 (read1): Likewise. (Bug#9608)
969
970 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
971
972 * dbusbind.c (Fdbus_register_signal): When service is not
973 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
974
975 2011-09-25 Glenn Morris <rgm@gnu.org>
976
977 * buffer.c (truncate-lines): Doc fix.
978
979 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
980
981 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
982 (Fset_window_next_buffers): Doc fix.
983
984 2011-09-24 Glenn Morris <rgm@gnu.org>
985
986 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
987
988 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
989
990 Fix minor problems found by static checking.
991 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
992 * indent.c (Fvertical_motion): Fix == vs = typo.
993
994 2011-09-24 Eli Zaretskii <eliz@gnu.org>
995
996 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
997 Default value is now t. Doc fix.
998
999 * indent.c (Fvertical_motion): Compute and apply the overshoot
1000 logic when moving up, not only when moving down. Fix the
1001 confusing name and values of the it_overshoot_expected variable;
1002 logic changes accordingly. (Bug#9254) (Bug#9549)
1003
1004 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1005 CHARPOS is covered by a display string which includes newlines.
1006 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1007 is covered by a display string with embedded newlines.
1008
1009 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1010
1011 * dbusbind.c (Fdbus_register_signal): Add match rule to
1012 Vdbus_registered_objects_table. (Bug#9581)
1013 (Fdbus_register_method, Vdbus_registered_objects_table):
1014 Fix docstring.
1015
1016 2011-09-24 Jim Meyering <meyering@redhat.com>
1017
1018 do not ignore write error for any output size
1019 The previous change was incomplete.
1020 While it makes emacs --batch detect the vast majority of stdout
1021 write failures, errors were still ignored whenever the output size is
1022 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1023 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1024 && echo FAIL: ignored write error
1025 FAIL: ignored write error
1026 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1027 && echo FAIL: ignored write error
1028 FAIL: ignored write error
1029 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1030
1031 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1032
1033 * emacs.c (Fkill_emacs): In noninteractive mode exit
1034 non-successfully if a write error occurred on stdout. (Bug#9574)
1035
1036 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1037
1038 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1039 the xassert test.
1040
1041 * dispextern.h (struct it): Update the comment documenting what
1042 can it->OBJECT be.
1043
1044 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1045
1046 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1047 a display string, extend search for cursor position to end of row.
1048 (find_row_edges): If the row ends in a newline from a display
1049 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1050 Handle the case of a display string with multiple newlines.
1051 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1052 non-empty line. Fixes confusing cursor motion with arrow keys at
1053 the beginning of a line that starts with whitespace.
1054
1055 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1056
1057 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1058 (bug#9493).
1059
1060 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1061
1062 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1063 boolean (Bug#9154).
1064
1065 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1066
1067 * xdisp.c (display_line): Record maximum and minimum buffer
1068 positions even if no glyphs were produced (e.g., by a zero-width
1069 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1070 buffer positions that will be removed from the glyph row because
1071 they don't fit.
1072 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1073 column is beyond frame width: don't subtract 1 "pixel" when
1074 computing width of the stretch.
1075 (reseat_at_next_visible_line_start): Undo the change made on
1076 2011-09-17 that saved paragraph information and restored it after
1077 the call to `reseat'. (Bug#9545)
1078
1079 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1080
1081 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1082 and turn window cursor on if cleared (Bug#9415).
1083
1084 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1085
1086 * search.c (boyer_moore): Take unibyte characters from pattern
1087 literally. (Bug#9458)
1088
1089 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1090
1091 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1092
1093 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1094
1095 Fix minor problem found by static checking.
1096 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1097 initialized, to pacify gcc -Wuninitialized.
1098
1099 * fileio.c: Report proper errno when syscall falls.
1100 (Finsert_file_contents): Save and restore errno,
1101 so that report_file_error outputs the correct diagnostic.
1102 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1103
1104 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1105
1106 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1107
1108 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1109
1110 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1111 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1112
1113 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1114
1115 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1116 about the current paragraph and restore it after the call to
1117 reseat.
1118
1119 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1120 (bidi_find_paragraph_start): Search back for paragraph beginning
1121 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1122 (bidi_move_to_visually_next): Only trigger paragraph-related
1123 computations when the last character is a newline or at EOB, not
1124 just any NEUTRAL_B. (Bug#9470)
1125
1126 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1127 truncated lines if point is covered by a display string. (Bug#9524)
1128
1129 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1130
1131 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1132 (cons_to_x_long): New function.
1133 (lisp_data_to_selection_data): Use it. Correct the test for
1134 short-versus-long data; it was negated. Break out of vector
1135 loop, for efficiency, when a long datum is discovered.
1136
1137 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1138
1139 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1140
1141 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1142
1143 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1144 GCC PR/17406) by declaring this function with external scope.
1145
1146 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1147
1148 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1149 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1150
1151 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1152
1153 * editfns.c (Fformat): Correctly handle text properties on "%%".
1154
1155 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1156
1157 * xterm.c (x_draw_composite_glyph_string_foreground):
1158 * w32term.c (x_draw_composite_glyph_string_foreground):
1159 * term.c (encode_terminal_code):
1160 * composite.c (composition_update_it, get_composition_id):
1161 * xdisp.c (get_next_display_element)
1162 (fill_composite_glyph_string): Add comments about special meaning
1163 of TAB characters in a composition.
1164
1165 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1166
1167 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1168 This occurs when processing a multibyte format.
1169 Problem reported by Wolfgang Jenker.
1170
1171 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1172
1173 * xdisp.c (try_cursor_movement): Only check for exact match if
1174 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1175
1176 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1177
1178 Remove unused external symbols.
1179 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1180 * xdisp.c (calc_pixel_width_or_height): Now static.
1181 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1182 * indent.c (check_display_width):
1183 * w32term.c: Fix comment to match code.
1184 * xterm.c, xterm.h (x_catching_errors): Remove.
1185
1186 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1187
1188 * xselect.c: Use signed conversions more consistently (Bug#9498).
1189 (selection_data_to_lisp_data): Assume incoming selection data are
1190 signed integers, not unsigned. This is to be consistent with
1191 outgoing selection data, which was modified to use signed integers
1192 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1193 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1194 expects long, not unsigned long.
1195
1196 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1197
1198 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1199 computation of loop end. Reported by Johan Bockgård
1200 <bojohan@gnu.org>.
1201
1202 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1203
1204 * frame.c (Fother_visible_frames_p): Function deleted.
1205
1206 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1207
1208 * indent.c (compute_motion): Process display vector front to back
1209 rather than the other way around. (Bug#2496)
1210
1211 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1212
1213 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1214
1215 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1216
1217 * minibuf.c (Fread_from_minibuffer): Doc fix.
1218
1219 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1220
1221 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1222 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1223
1224 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1225
1226 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1227 value for non-existent files.
1228
1229 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1230
1231 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1232 set its "size" to -1. This will set the modtime_size field of
1233 the corresponding buffer to -1, which is what
1234 verify-visited-file-modtime expects for files that do not exist.
1235 (Bug#9139)
1236
1237 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1238
1239 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1240 here ...
1241 * lisp.h: ... from here. push_key_description is no longer
1242 defined in keyboard.c, so its declaration should not be in
1243 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1244 logically belongs with push_key_description.
1245
1246 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1247
1248 * buffer.h: Include <sys/types.h> instead of <time.h>.
1249 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1250 Problem reported by Herbert J. Skuhra.
1251
1252 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1253
1254 * xml.c (parse_region): Make the parsing work for
1255 non-comment-starting XML files again (bug#9144).
1256
1257 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1258
1259 * image.c (gif_load): Fix calculation of bottom and right corner.
1260 (Bug#9468)
1261
1262 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1263
1264 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1265 redisplay in small windows.
1266
1267 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1268
1269 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1270
1271 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1272
1273 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1274 Operate on live windows only.
1275
1276 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1277
1278 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1279
1280 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1281
1282 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1283 only under bidi iteration.
1284
1285 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1286
1287 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1288
1289 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1290
1291 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1292 Without this fix, the command to link temacs failed due to an
1293 undefined symbol __builtin_isnan. This is because
1294 /usr/include/iso/math_c99.h #defines isnan(x) to
1295 __builtin_isnan(x), but the bundled gcc, which identifies itself
1296 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1297 a __builtin_isnan.
1298 * floatfns.c (isnan): #undef, and then #define to a clone of
1299 what's in data.c.
1300 (Fisnan): Always define, since it's always available now.
1301 (syms_of_floatfns): Always define isnan at the Lisp level.
1302
1303 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1304
1305 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1306
1307 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1308
1309 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1310 The previous code assumed that file offsets (off_t values) fit in
1311 EMACS_INT variables, which is not true on typical 32-bit hosts.
1312 The code messed up by falsely reporting buffer overflow in cases
1313 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1314 when "big" contains more than 2**29 bytes, even though this
1315 inserts just one byte and does not overflow the buffer.
1316 (Finsert_file_contents): Store file offsets as off_t
1317 values, not as EMACS_INT values. Check for overflow when
1318 converting between EMACS_INT and off_t. When checking for
1319 buffer overflow or for overlap, take the offsets into account.
1320 Don't use EMACS_INT for small values where int suffices.
1321 When checking for overlap, fix a typo: ZV was used where
1322 ZV_BYTE was intended.
1323 (Fwrite_region): Don't assume off_t fits into 'long'.
1324 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1325
1326 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1327
1328 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1329
1330 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1331
1332 sprintf-related integer and memory overflow issues (Bug#9412).
1333
1334 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1335 (esprintf, exprintf, evxprintf): New functions.
1336 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1337 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
1338 (modify_event_symbol): Do not assume that the length of
1339 name_alist_or_stem is safe to alloca and fits in int.
1340 (Fexecute_extended_command): Likewise for function name and binding.
1341 (Frecursion_depth): Wrap around reliably on integer overflow.
1342 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1343 since some callers pass EMACS_INT values.
1344 (Fsingle_key_description): Don't crash if symbol name contains more
1345 than MAX_ALLOCA bytes.
1346 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1347 (get_minibuffer): Arg is now EMACS_INT, not int.
1348 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1349 (esprintf, exprintf, evxprintf): New decls.
1350 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1351
1352 * dbusbind.c (signature_cat): New function.
1353 (xd_signature, Fdbus_register_signal):
1354 Do not overrun buffer; instead, report string overflow.
1355
1356 * dispnew.c (add_window_display_history): Don't overrun buffer.
1357 Truncate instead; this is OK since it's just a log.
1358
1359 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1360 even if the time zone offset is outlandishly large.
1361 Don't mishandle offset == INT_MIN.
1362
1363 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1364 when creating daemon; the previous buffer-overflow check was incorrect.
1365
1366 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1367 which has the guts of the old verror function.
1368
1369 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1370 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1371
1372 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1373 (font_unparse_xlfd): Don't blindly alloca long strings.
1374 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1375 fits in int, when using sprintf. Use single snprintf to count
1376 length of string rather than counting it via multiple sprintfs;
1377 that's simpler and more reliable.
1378 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1379 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1380 sprintf, in case result does not fit in int.
1381
1382 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1383 (fontset_from_font): Print it.
1384
1385 * frame.c (tty_frame_count): Now printmax_t, not int.
1386 (make_terminal_frame, set_term_frame_name): Print it.
1387 (x_report_frame_params): In X, window IDs are unsigned long,
1388 not signed long, so print them as unsigned.
1389 (validate_x_resource_name): Check for implausibly long names,
1390 and don't assume name length fits in 'int'.
1391 (x_get_resource_string): Don't blindly alloca invocation name;
1392 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1393 not fit in int.
1394
1395 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1396 (xg_check_special_colors, xg_set_geometry):
1397 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1398
1399 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1400 Use esprintf, not sprintf, in case result does not fit in int.
1401
1402 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1403 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1404 it as a large positive number.
1405 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1406 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1407
1408 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1409 in case result does not fit in int.
1410
1411 * print.c (float_to_string): Detect width overflow more reliably.
1412 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1413 buffer overrun. Don't assume list length fits in 'int'. Treat
1414 print length of 0 as 0, not as infinity; to be consistent with other
1415 uses of print length in this function. Don't overflow print length
1416 index. Don't assume hash table size fits in 'long', or that
1417 vectorlike size fits in 'unsigned long'.
1418
1419 * process.c (make_process): Use printmax_t, not int, to format
1420 process-name gensyms.
1421
1422 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1423
1424 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1425 to avoid potential buffer overrun.
1426
1427 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1428 if X resource line is longer than 512 bytes.
1429
1430 * xfns.c (x_window): Make sprintf buffer a bit bigger
1431 to avoid potential buffer overrun.
1432
1433 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1434
1435 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1436
1437 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1438
1439 Integer overflow fixes for scrolling, etc.
1440 Without these, Emacs silently mishandles large integers sometimes.
1441 For example, "C-u 4294967297 M-x recenter" was treated as if
1442 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1443
1444 * xdisp.c (try_window_id): Check Emacs fixnum range before
1445 converting to 'int'.
1446
1447 * window.c (window_scroll_line_based, Frecenter):
1448 Check that an Emacs fixnum is in range before assigning it to 'int'.
1449 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1450 values converted from Emacs fixnums.
1451 (Frecenter): Don't wrap around a line count if it is out of 'int'
1452 range; instead, treat it as an extreme value.
1453 (Fset_window_configuration, compare_window_configurations):
1454 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1455
1456 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1457 that can exceed INT_MAX. Check that EMACS_INT value is in range
1458 before assigning it to the (possibly-narrower) index.
1459 (match_limit): Don't assume that a fixnum can fit in 'int'.
1460
1461 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1462 exceed INT_MAX.
1463
1464 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1465 (Fvertical_motion): Don't wrap around LINES values that don't fit
1466 in 'int'. Instead, treat them as extreme values. This is good
1467 enough for windows, which can't have more than INT_MAX lines anyway.
1468
1469 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1470
1471 * Require libxml/parser.h to avoid compilation warning.
1472
1473 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1474
1475 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1476 since this reportedly can destroy thread storage.
1477
1478 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1479
1480 * syntax.c (find_defun_start): Update all cache variables if
1481 exiting early (Bug#9401).
1482
1483 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1484
1485 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1486
1487 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1488 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1489 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1490
1491 * term.c (tty_append_glyph): New function.
1492 (produce_stretch_glyph): Static function and its prototype deleted.
1493
1494 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1495 Add prototypes.
1496
1497 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1498
1499 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1500 when checking :margin (Bug#9390).
1501 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1502 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1503 so that the name doesn't mislead. All uses changed.
1504
1505 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1506
1507 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1508 set_tty_hooks.
1509
1510 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1511
1512 * xdisp.c (move_it_to): Don't bail out early when reaching
1513 position beyond to_charpos, if we are scanning backwards.
1514 (move_it_vertically_backward): When DY == 0, make sure we get to
1515 the first character in the line after the newline.
1516
1517 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1518
1519 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1520 (ccl_driver): Do not generate an out-of-range pointer.
1521 (Fccl_execute_on_string): Remove unnecessary check for
1522 integer overflow, noted by Stefan Monnier in
1523 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1524 Remove a FIXME that didn't need fixing.
1525 Simplify the newly-introduced buffer reallocation code.
1526
1527 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1528
1529 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1530
1531 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1532
1533 Integer and memory overflow issues (Bug#9196).
1534
1535 * doc.c (get_doc_string): Rework so that
1536 get_doc_string_buffer_size is the actual buffer size, rather than
1537 being 1 less than the actual buffer size; this makes xpalloc more
1538 convenient.
1539
1540 * image.c (x_allocate_bitmap_record, cache_image):
1541 * xselect.c (Fx_register_dnd_atom):
1542 Simplify previous changes by using xpalloc.
1543
1544 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1545 since either will do and ptrdiff_t is convenient with xpalloc.
1546
1547 * charset.c (charset_table_size)
1548 (struct charset_sort_data.priority): Now ptrdiff_t.
1549 (charset_compare): Don't overflow if priorities differ greatly.
1550 (Fsort_charsets): Don't assume list length fits in int.
1551 Check for size-calculation overflow when allocating sort data.
1552 (syms_of_charset): Allocate an initial charset table that is
1553 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1554
1555 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1556
1557 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1558 The actual value is always <= INT_MAX, and leaving it unsigned made
1559 overflow checking harder.
1560
1561 * dispextern.h (struct glyph_matrix.rows_allocated)
1562 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1563 with xpalloc. The values are still always <= INT_MAX.
1564
1565 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1566
1567 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1568 (SAFE_NALLOCA): New macro.
1569
1570 * region-cache.c (struct boundary.pos, find_cache_boundary)
1571 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1572 (set_cache_region, invalidate_region_cache)
1573 (revalidate_region_cache, know_region_cache, region_cache_forward)
1574 (region_cache_backward, pp_cache):
1575 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1576 so that ptrdiff_t * can be passed to xpalloc.
1577 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1578 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1579 (pp_cache): Don't assume cache_len fits in int.
1580 * region-cache.h: Adjust extern decls to match.
1581
1582 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1583 EMACS_INT, since either will do, for xpalloc.
1584
1585 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1586 (xnmalloc, xnrealloc, xpalloc): New functions.
1587
1588 * bidi.c (bidi_shelve_header_size): New constant.
1589 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1590 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1591
1592 * bidi.c (bidi_cache_shrink):
1593 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1594 (overlay_strings):
1595 Don't update size of array until after memory allocation succeeds,
1596 because xmalloc/xrealloc may not return.
1597 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1598 now that we have proper integer overflow checking.
1599 (record_overlay_string, overlay_strings): Catch overflows when
1600 calculating size of overlay_str_buf.
1601
1602 * callproc.c (Fcall_process): Check for size overflow when
1603 calculating size of args2.
1604 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1605 Normally we prefer signed values, but sticking with ptrdiff_t would
1606 require adding more-complicated checks.
1607
1608 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1609 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1610 Redo buffer-overflow calculations to avoid integer overflow.
1611 Add a FIXME comment where memory seems to be over-allocated.
1612
1613 * character.c (Fstring): Check for size-calculation overflow.
1614
1615 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1616 unnecessary integer overflow. Check for size overflow.
1617 (encode_coding_object): Don't update size until xmalloc succeeds.
1618
1619 * composite.c (get_composition_id): Check for overflow in glyph
1620 length calculations.
1621
1622 Integer and memory overflow fixes for display code.
1623 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1624 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1625 (scrolling_window): Check for overflow in size calculations.
1626 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1627 Don't assume glyph table len fits in int.
1628 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1629 (row_table_size): Now ptrdiff_t, not int.
1630 (scrolling_window): Avoid overflow in size calculations.
1631 Don't update size until allocation succeeds.
1632 * fns.c (concat): Check for overflow in size calculations.
1633 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1634 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1635 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1636
1637 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1638 (get_doc_string): Check for size calculation overflow.
1639 Don't update size until allocation succeeds.
1640 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1641 EMACS_INT, where ptrdiff_t will do.
1642 (Fsubstitute_command_keys): Check for string overflow.
1643
1644 * editfns.c (set_time_zone_rule): Don't assume environment length
1645 fits in int.
1646 (message_length): Now ptrdiff_t, not int.
1647 (Fmessage_box): Don't update size until allocation succeeds.
1648 Don't assume message length fits in int.
1649 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1650
1651 * emacs.c (main): Do not reallocate argv, since there is a null at
1652 the end that can be overwritten, and this way there's no need to
1653 worry about size-calculation overflow.
1654 (sort_args): Check for size-calculation overflow.
1655
1656 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1657 alloc succeeds.
1658 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1659
1660 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1661 (x_set_scroll_bar_width, x_figure_window_size):
1662 Check for integer overflow.
1663 (x_set_alpha): Do not assume XINT fits in int.
1664
1665 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1666 This is for the members text_lines, text_cols, total_lines, total_cols,
1667 where the system imposes an 'int' limit.
1668
1669 * fringe.c (Fdefine_fringe_bitmap):
1670 Don't update size until alloc works.
1671
1672 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1673 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1674
1675 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1676 Check for size-calculation overflow.
1677 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1678 do, as we prefer signed integers.
1679 (id_to_widget.max_size, id_to_widget.used)
1680 (xg_store_widget_in_map, xg_remove_widget_from_map)
1681 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1682 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1683 Use and return ptrdiff_t, not int.
1684 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1685 * gtkutil.h: Change prototypes to match the above.
1686
1687 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1688 are duplicate now that they've been promoted to lisp.h.
1689 (x_allocate_bitmap_record, x_alloc_image_color)
1690 (make_image_cache, cache_image, xpm_load):
1691 Don't update size until alloc is done.
1692 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1693 (x_detect_edges):
1694 Check for size calculation overflow.
1695 (ct_colors_allocated_max): New constant.
1696 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1697 overflow.
1698
1699 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1700 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1701 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1702 Use ptrdiff_t, not int, to count maps.
1703 (read_char_minibuf_menu_prompt): Check for overflow in size
1704 calculations. Don't update size until allocation succeeds.
1705 Redo calculations to avoid overflow.
1706 * keyboard.h: Change prototypes to match the above.
1707
1708 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1709 to count maps.
1710 (current_minor_maps): Check for size calculation overflow.
1711 * keymap.h: Change prototypes to match the above.
1712
1713 * lread.c (read1, init_obarray): Don't update size until alloc done.
1714
1715 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1716 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1717
1718 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1719 Now ptrdiff_t, not int.
1720 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1721 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1722
1723 * process.c (Fnetwork_interface_list): Check for overflow
1724 in size calculation.
1725
1726 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1727
1728 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1729 overflow. Don't bother calling xmalloc when xrealloc will do.
1730
1731 * search.c (Freplace_match): Check for size calculation overflow.
1732 (Fset_match_data): Don't assume list lengths fit in 'int'.
1733
1734 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1735 for command line length. Do not attempt to address one before the
1736 beginning of an array, as that's not portable.
1737
1738 * term.c (max_frame_lines): Remove; unused.
1739 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1740 not int.
1741 (encode_terminal_code, calculate_costs): Check for size
1742 calculation overflow.
1743 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1744 table lengths and related sizes. Don't update size until alloc
1745 done. Redo calculations to avoid overflow.
1746 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1747
1748 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1749 subtracting pointers.
1750 (gobble_line): Check for overflow more carefully. Don't update size
1751 until alloc done.
1752
1753 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1754 Don't update size until alloc done.
1755 Redo size calculations to avoid overflow.
1756 Check for size calculation overflow.
1757 (main) [DEBUG]: Fix typo in invoking tparam1.
1758
1759 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1760 Use ptrdiff_t, not int, for sizes.
1761 (store_mode_line_noprop_char): Don't update size until alloc done.
1762
1763 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1764 Use ptrdiff_t, not int, for sizes.
1765 (Finternal_make_lisp_face, cache_face):
1766 Check for size calculation overflow.
1767 (cache_face): Treat size calculation overflows as if they were
1768 memory exhaustion (the usual treatment), rather than aborting.
1769
1770 * xfns.c (x_encode_text, x_set_name_internal)
1771 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1772 sizes, since they can exceed INT_MAX in size. Check for size
1773 calculation overflow.
1774
1775 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1776 (xg_select): Check for size calculation overflow.
1777 Don't update size until alloc done.
1778
1779 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1780 as sprintf is limited to int lengths.
1781
1782 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1783 (X_LONG_MIN): New macros.
1784 Use them to make the following changes clearer.
1785 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1786 This change doesn't affect the value now, but it may help remind
1787 future maintainers not to raise the value too much later.
1788 (SELECTION_QUANTUM): Remove, replacing with ...
1789 (selection_quantum): ... new function, which avoids overflow.
1790 All uses changed.
1791 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1792 assumption that selection length fits in 'int'.
1793 (x_reply_selection_request, x_handle_selection_request)
1794 (x_get_window_property, receive_incremental_selection)
1795 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1796 (lisp_data_to_selection_data, clean_local_selection_data):
1797 Use ptrdiff_t, not int, to record length of selection.
1798 (x_reply_selection_request, x_get_window_property)
1799 (receive_incremental_selection, x_property_data_to_lisp):
1800 Redo calculations to avoid overflow.
1801 (x_reply_selection_request): When sending hint, ceiling it at
1802 X_LONG_MAX rather than relying on wraparound overflow to send
1803 something.
1804 (x_get_window_property, receive_incremental_selection)
1805 (lisp_data_to_selection_data, x_property_data_to_lisp):
1806 Check for size-calculation overflow.
1807 (x_get_window_property, receive_incremental_selection)
1808 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1809 Don't store size until memory allocation succeeds.
1810 (x_get_window_property): Plug memory leak on memory exhaustion.
1811 Don't double-block input; malloc is safe here. Don't assume 2**34
1812 - 4 fits in unsigned long. Add an xassert to check
1813 XGetWindowProperty overflow. Be more careful about overflow
1814 calculations, and distinguish size from memory overflow better.
1815 (receive_incremental_selection): When tracing, don't assume
1816 unsigned int is less than INT_MAX.
1817 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1818 harmful) conversions of unsigned short to int.
1819 (lisp_data_to_selection_data): Don't assume that integers
1820 in the range -65535 through -1 fit in an X unsigned short.
1821 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1822 result parameters unless successful. Rely on cons_to_unsigned
1823 to report problems with elements; the old code wasn't right anyway.
1824 (x_check_property_data): Check for int overflow; we cannot use
1825 a wider type due to X limits.
1826 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1827
1828 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1829
1830 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1831 (x_term_init): Check for size calculation overflow.
1832 (x_color_cells): Don't store size until memory allocation succeeds.
1833 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1834 Don't assume alloca size is less than MAX_ALLOCA.
1835 (x_term_init): Don't assume length fits in int (sprintf is limited
1836 to int size).
1837
1838 Use ptrdiff_t for composition IDs.
1839 * character.c (lisp_string_width):
1840 * composite.c (composition_table_size, n_compositions)
1841 (get_composition_id, composition_gstring_from_id):
1842 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1843 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1844 * window.c (Frecenter):
1845 Use ptrdiff_t, not int, for composition IDs.
1846 * composite.c (get_composition_id): Check for integer overflow.
1847 * composite.h: Adjust prototypes to match the above changes.
1848
1849 Use ptrdiff_t for hash table indexes.
1850 * category.c (hash_get_category_set):
1851 * ccl.c (ccl_driver):
1852 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1853 * coding.c (coding_system_charset_list, detect_coding_system):
1854 * coding.h (struct coding_system.id):
1855 * composite.c (get_composition_id, gstring_lookup_cache):
1856 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1857 * image.c (xpm_get_color_table_h):
1858 * lisp.h (hash_lookup, hash_put):
1859 * minibuf.c (Ftest_completion):
1860 Use ptrdiff_t for hash table indexes, not int (which is too
1861 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1862 32-bit --with-wide-int hosts).
1863
1864 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1865 Add a FIXME comment about memory leaks.
1866 (syms_of_charset): Don't assume xmalloc returns.
1867
1868 Don't assume that stated character widths fit in int.
1869 * character.c (Fchar_width, c_string_width, lisp_string_width):
1870 * character.h (CHAR_WIDTH):
1871 * indent.c (MULTIBYTE_BYTES_WIDTH):
1872 Use sanitize_char_width to avoid undefined and/or bad behavior
1873 with outlandish widths.
1874 * character.h (sanitize_tab_width): Rename from sanitize_width,
1875 now that we have two such functions. All uses changed.
1876 (sanitize_char_width): New inline function.
1877
1878 Don't assume that tab-width fits in int.
1879 * character.h (sanitize_width): New inline function.
1880 (SANE_TAB_WIDTH): New macro.
1881 (ASCII_CHAR_WIDTH): Use it.
1882 * indent.c (sane_tab_width): Remove. All uses replaced by
1883 SANE_TAB_WIDTH (current_buffer).
1884 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1885
1886 * fileio.c: Integer overflow issues with file modes.
1887 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1888
1889 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1890 Remove unreachable code.
1891 (read_hex, load_charset_map_from_file): Check for integer overflow.
1892
1893 * xterm.c: don't go over XClientMessageEvent limit
1894 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1895 (x_send_scroll_bar_event): Likewise. Check that the size does not
1896 exceed limits imposed by XClientMessageEvent, as well as the usual
1897 ptrdiff_t and size_t limits.
1898
1899 * keyboard.c: Overflow, signedness and related fixes.
1900 (make_lispy_movement): Use same integer type in forward decl
1901 that is used in the definition.
1902 (read_key_sequence, keyremap_step):
1903 Change bufsize argument back to int, undoing my 2011-03-30 change.
1904 We prefer signed types, and int is wide enough here.
1905 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1906 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1907 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1908 length, not size_t. Use ptrdiff_t for index, not int.
1909 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1910 possibility of integer overflow.
1911
1912 Overflow, signedness and related fixes for images.
1913
1914 * dispextern.h (struct it.stack[0].u.image.image_id)
1915 (struct_it.image_id, struct image.id, struct image_cache.size)
1916 (struct image_cache.used, struct image_cache.ref_count):
1917 * gtkutil.c (update_frame_tool_bar):
1918 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1919 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1920 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1921 * nsmenu.m (update_frame_tool_bar):
1922 * xdisp.c (calc_pixel_width_or_height):
1923 * xfns.c (image_cache_refcount):
1924 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1925 on typical 64-bit hosts.
1926
1927 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1928 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1929 Omit unnecessary casts to int.
1930 (parse_image_spec): Check that integers fall into 'int' range
1931 when the callers expect that.
1932 (image_ascent): Redo ascent calculation to avoid int overflow.
1933 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1934 (lookup_image): Remove unnecessary tests.
1935 (xbm_image_p): Locals are now of int, not EMACS_INT,
1936 since parse_image_check makes sure they fit into int.
1937 (png_load, gif_load, svg_load_image):
1938 Prefer int to unsigned where either will do.
1939 (tiff_handler): New function, combining the cores of the
1940 old tiff_error_handler and tiff_warning_handler.
1941 This function is rewritten to use vsnprintf and thereby avoid
1942 stack buffer overflows. It uses only the features of vsnprintf
1943 that are common to both POSIX and native Microsoft.
1944 (tiff_error_handler, tiff_warning_handler): Use it.
1945 (tiff_load, gif_load, imagemagick_load_image):
1946 Don't assume :index value fits in 'int'.
1947 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1948 (imagemagick_load_image): Check that crop parameters fit into
1949 the integer types that MagickCropImage accepts. Don't assume
1950 Vimagemagick_render_type has a nonnegative value. Don't assume
1951 size_t fits in 'long'.
1952 (gs_load): Use printmax_t to print the widest integers possible.
1953 Check for integer overflow when computing image height and width.
1954
1955 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1956
1957 * xdisp.c (redisplay_window): Don't force window start if point
1958 will be invisible in the resulting window. (Bug#9324)
1959
1960 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1961
1962 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1963 the display spec is of the form `(space ...)'.
1964 (handle_display_spec): Return the value returned by
1965 handle_single_display_spec, not just 1 or zero.
1966 (handle_single_display_spec): If the display spec is of the form
1967 `(space ...)', and specifies display in the text area, return 2
1968 rather than 1.
1969 (try_cursor_movement): Check for the need to scroll more
1970 accurately, and prefer exact match for point under bidi.
1971 Don't advance `row' beyond the last row of the window.
1972
1973 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1974 into disp_prop; all users changed.
1975
1976 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1977 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1978 for the text covered by the display property.
1979
1980 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1981
1982 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1983 Change return value to nil.
1984 (Frecord_buffer): Delete unused function.
1985
1986 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1987
1988 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1989 buffers, return left-to-right.
1990 (set_cursor_from_row): Consider candidate row a win if its glyph
1991 represents a newline and point is on that newline. Fixes cursor
1992 positioning on the newline at EOL of R2L text within L2R
1993 paragraph, and vice versa.
1994 (try_cursor_movement): Check continued rows, in addition to
1995 continuation rows. Fixes unwarranted scroll when point enters a
1996 continued line of R2L text within an L2R paragraph, or vice versa.
1997 (cursor_row_p): Consider the case of point being equal to
1998 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1999 from the end of a short line to the beginning of a continued line
2000 of R2L text within L2R paragraph.
2001 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2002 composed characters.
2003
2004 * bidi.c (bidi_check_type): Use xassert.
2005 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2006 members.
2007
2008 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2009
2010 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2011 a character.
2012
2013 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2014
2015 * nsfont.m (ns_otf_to_script): Fix typo.
2016
2017 2011-08-22 Kenichi Handa <handa@m17n.org>
2018
2019 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2020 extra slot even if the purpose is char-code-property-table.
2021
2022 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2023
2024 * xdisp.c (redisplay_window): When computing centering_position,
2025 account for the height of the header line. (Bug#8874)
2026
2027 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2028 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2029 candidate is selected by the mouse, and that candidate has a
2030 composed character under the mouse.
2031
2032 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2033 coordinates reported by pos-visible-in-window-p for a composed
2034 character in column zero.
2035
2036 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2037
2038 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2039
2040 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2041
2042 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2043 consider it a hit if to_charpos is anywhere in the range of the
2044 composed buffer positions.
2045
2046 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2047
2048 * image.c (gif_load): Don't assume that each subimage has the same
2049 dimensions as the base image. Handle disposal method that is
2050 "undefined" by the gif spec (Bug#9335).
2051
2052 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2053
2054 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2055 (Fcondition_case): Document `debug' symbol in error handler.
2056
2057 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2058
2059 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2060 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2061 from an Org mode buffer to a Speedbar frame.
2062
2063 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2064 a composition, take its buffer position from IT->cmp_it.charpos.
2065 Fixes cursor positioning at the beginning of a line that begins
2066 with a composed character.
2067
2068 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2069
2070 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2071 character bidirectional type, use STRONG_L instead. Fixes crashes
2072 in a buffer produced by `describe-categories'.
2073
2074 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2075 members before the level stack, so they would be saved and
2076 restored when copying iterator state. Fixes incorrect reordering
2077 around TABs covered by display properties.
2078
2079 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2080
2081 * process.c (Fnetwork_interface_list): Correctly determine buffer
2082 size.
2083
2084 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2085
2086 * eval.c (internal_condition_case, internal_condition_case_1)
2087 (internal_condition_case_2, internal_condition_case_n):
2088 Remove unnecessary aborts (Bug#9081).
2089
2090 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2091
2092 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2093 has no `load' handler, try opening the file locally. (Bug#9311)
2094
2095 2011-08-16 Ken Brown <kbrown@cornell.edu>
2096
2097 * gmalloc.c: Expand comment.
2098
2099 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2100
2101 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2102 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2103
2104 2011-08-16 Ken Brown <kbrown@cornell.edu>
2105
2106 Fix memory allocation problems in Cygwin build (Bug#9273).
2107
2108 * unexcw.c ( __malloc_initialized): Declare external variable.
2109 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2110
2111 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2112 New variables.
2113 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2114 dumped emacs.
2115 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2116 in the static heap.
2117 [CYGWIN] (special_realloc): New function.
2118 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2119 requests to realloc storage in the static heap.
2120
2121 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2122
2123 * bidi.c (bidi_initialize): Remove unused local.
2124
2125 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2126
2127 * biditype.h: File removed.
2128
2129 * bidimirror.h: File removed.
2130
2131 * deps.mk (bidi.o): Remove biditype.h and
2132 bidimirror.h.
2133
2134 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
2135 bidimirror.h.
2136
2137 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2138
2139 * chartab.c: Improve commentary for the uniprop_table API.
2140
2141 * bidi.c (bidi_paragraph_init): Support zero value of
2142 bidi_ignore_explicit_marks_for_paragraph_level.
2143 (bidi_initialize): Use uniprop_table instead of including
2144 biditype.h and bidimirror.h.
2145
2146 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2147 coordinates of the iterator when restoring from ppos_it.
2148 (Bug#9296)
2149
2150 2011-08-14 Kenichi Handa <handa@m17n.org>
2151
2152 * process.c (create_process): Call setup_process_coding_systems
2153 after the pid of the process is set to -1 (Bug#8162).
2154
2155 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2156
2157 * xdisp.c (move_it_in_display_line_to): Don't invoke
2158 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2159 ppos_it. Fixes vertical cursor motion when line beginning is
2160 covered by an image. (Bug#9296)
2161
2162 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2163
2164 * nsterm.h (ns_run_ascript): Declare.
2165 (NSAPP_DATA2_RUNASSCRIPT): Define.
2166
2167 * nsfns.m (as_script, as_result, as_status): New static variables.
2168 (ns_run_ascript): New function.
2169 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2170 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2171 the event loop. Get status from as_status (Bug#7276).
2172
2173 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2174 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2175 the event loop (Bug#7276).
2176
2177 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2178
2179 * gnutls.c (QCgnutls_bootprop_priority)
2180 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2181 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2182 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2183 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2184 (QCgnutls_bootprop_verify_hostname_error)
2185 (QCgnutls_bootprop_callbacks_verify): Rename from
2186 Qgnutls_bootprop_..., all uses changed.
2187
2188 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2189 uses changed.
2190
2191 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2192
2193 * xfaces.c (Qframe_set_background_mode): Now static.
2194 * dispextern.h (Qframe_set_background_mode): Remove decl.
2195
2196 * process.c (Fnetwork_interface_info): Declare local only if needed.
2197
2198 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2199
2200 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2201 (Fnetwork_interface_list): Allocate in increments of bytes instead
2202 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2203 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2204 sockaddr.
2205 (struct ifflag_def): notrailers is smart on OSX.
2206 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2207 Get hardware address with getifaddrs if available.
2208
2209 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2210
2211 * xdisp.c (iterate_out_of_display_property): xassert that
2212 IT->position is set to within IT->object's boundaries. Break from
2213 the loop as soon as EOB is reached; avoids infloops in redisplay
2214 when IT->position is set up wrongly due to some bug.
2215 Set IT->current to match the bidi iterator unconditionally.
2216 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2217 entry. Force push_it to save on the stack the current
2218 buffer/string position, to be restored by pop_it. Fix flags in
2219 the iterator structure wrt the object coming from a display
2220 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2221 properties. (Bug#9284)
2222
2223 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2224
2225 * fontset.c (fontset_get_font_group): Add proper type checks.
2226 (Bug#9172)
2227
2228 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2229
2230 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2231 and LC_VERSION_MIN_MACOSX.
2232 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2233 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2234
2235 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2236
2237 * xdisp.c (forward_to_next_line_start): Allow to use the
2238 no-display-properties-and-no-overlays under bidi display.
2239 Set disp_pos in the bidi iterator to avoid searches for display
2240 properties and overlays.
2241
2242 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2243
2244 * editfns.c (Fset_time_zone_rule): Document relationship with the
2245 setenv function.
2246
2247 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2248 the font entity extracted from the cache (Bug#8109).
2249
2250 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2251
2252 * composite.c (autocmp_chars): Don't reset point. That is done by
2253 restore_point_unwind (Bug#5984).
2254
2255 2011-08-07 Juri Linkov <juri@jurta.org>
2256
2257 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2258 to show the arg `TIME' instead of `TIMEVAL'.
2259
2260 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2261
2262 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2263 display property strides EOL and includes a newline, as in
2264 longlines-mode. (Bug#9254)
2265 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2266 word-wrap under bidirectional display. (Bug#9224)
2267
2268 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2269 is non-zero, even if the data buffer is NULL. Fixes a crash in
2270 vertical-motion with longlines-mode. (Bug#9254)
2271
2272 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2273
2274 * bidi.c <bidi_cache_total_alloc>: Now static.
2275 (bidi_initialize): Initialize bidi_cache_total_alloc.
2276
2277 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2278 cache. (Bug#9221)
2279
2280 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2281 amount allocated this far in `bidi_cache_total_alloc'.
2282 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2283 non-zero, only free the data buffer without restoring the cache
2284 contents. All callers changed.
2285
2286 * dispextern.h (bidi_unshelve_cache): Update prototype.
2287
2288 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2289 (move_it_in_display_line, move_it_to)
2290 (move_it_vertically_backward, move_it_by_lines): Replace the call
2291 to xfree to an equivalent call to bidi_unshelve_cache.
2292 (move_it_in_display_line_to): Fix logic of returning
2293 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2294
2295 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2296
2297 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2298 came from a string character with a `cursor' property. (Bug#9229)
2299
2300 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2301
2302 * Makefile.in (LIB_PTHREAD): New variable.
2303 (LIBES): Add LIB_PTHREAD (Bug#9216).
2304
2305 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2306 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2307
2308 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2309
2310 * regex.c (re_iswctype): Remove some redundant boolean
2311 conversions.
2312
2313 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2314
2315 * xterm.c (x_find_topmost_parent): New function.
2316 (x_set_frame_alpha): Find topmost parent window with
2317 x_find_topmost_parent and set the property there also (bug#9181).
2318 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2319
2320 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2321
2322 * callproc.c (Fcall_process): Avoid vfork clobbering
2323 the local vars buffer, coding_systems, current_dir.
2324
2325 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2326
2327 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2328
2329 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2330
2331 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2332 so that it is not optimized away.
2333
2334 * xdisp.c (compute_display_string_pos): Remove unused local.
2335
2336 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2337
2338 Fix slow cursor motion and scrolling in large buffers with
2339 selective display, like Org Mode buffers. (Bug#9218)
2340
2341 * dispextern.h (struct bidi_it): New member disp_prop_p.
2342
2343 * xdisp.c: Remove one-slot cache of display string positions.
2344 (compute_display_string_pos): Accept an additional argument
2345 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2346 for a display string or property. If found, set DISP_PROP_P
2347 non-zero.
2348
2349 * bidi.c (bidi_fetch_char): Accept an additional argument
2350 DISP_PROP_P, and pass it to compute_display_string_pos.
2351 Only handle text covered by a display string if DISP_PROP_P is returned
2352 non-zero. All callers of bidi_fetch_char changed.
2353
2354 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2355
2356 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2357
2358 2010-12-03 Don March <don@ohspite.net>
2359
2360 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2361 last character M-[char] is translated to ESC [char] (bug#7541).
2362
2363 2011-08-02 Kenichi Handa <handa@m17n.org>
2364
2365 * lisp.h (uniprop_table): Extern it.
2366
2367 * chartab.c (uniprop_table): Make it non-static.
2368
2369 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2370
2371 * xdisp.c (forward_to_next_line_start): Accept additional argument
2372 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2373 on the newline.
2374 (reseat_at_next_visible_line_start): Use the bidi iterator state
2375 returned by forward_to_next_line_start to restore the state of
2376 it->bidi_it after backing up to previous newline. (Bug#9212)
2377
2378 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2379
2380 * regex.c (re_comp): Protoize.
2381 (re_exec): Fix return type.
2382 (regexec): Fix type of `ret'. (Bug#9203)
2383
2384 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2385
2386 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2387 This is needed if max-image-size is a floating-point number.
2388
2389 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2390
2391 * print.c (print_object): Print empty symbol as ##.
2392
2393 * lread.c (read1): Read ## as empty symbol.
2394
2395 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2396
2397 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2398 setting frame foreground color (Bug#9175).
2399 (x_set_background_color): Likewise.
2400
2401 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2402 contents (Bug#9176).
2403 (EmacsTooltip -init): Remove bezels and add shadows to
2404 tooltip windows.
2405
2406 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2407 or scroll bar (Bug#8470).
2408
2409 * nsfont.m (nsfont_open): Remove assignment to voffset and
2410 unnecessary vars hshink, expand, hd, full_height, min_height.
2411 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2412
2413 * nsterm.h (nsfont_info): Remove voffset field.
2414
2415 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2416
2417 Implement strike-through and overline on NextStep (Bug#8863).
2418
2419 * nsfont.m (nsfont_open): Use underline position provided by font,
2420 instead of hard-coded value of 2.
2421 (nsfont_draw): Call ns_draw_text_decoration instead.
2422
2423 * nsterm.h: Add declaration for ns_draw_text_decoration.
2424
2425 * nsterm.m (ns_draw_text_decoration): New function for drawing
2426 underline, overline, and strike-through.
2427 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2428 ns_draw_text_decoration. Change treatment of cursor drawing to
2429 accommodate underlining, etc.
2430
2431 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2432
2433 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2434 default.
2435
2436 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2437
2438 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2439 Without this fix, if a signal arrives just after memory fills up,
2440 'malloc' might be invoked reentrantly.
2441
2442 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2443 In other words, assume that every image size is allowed, on non-X
2444 hosts. This assumption is probably wrong, but it lets Emacs compile.
2445
2446 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2447
2448 * regex.c (re_iswctype): Convert return values to boolean.
2449
2450 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2451
2452 * xdisp.c (compute_display_string_pos): Don't use cached display
2453 string position if the buffer had its restriction changed.
2454 (Bug#9184)
2455
2456 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2457
2458 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2459
2460 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2461
2462 Integer signedness and overflow and related fixes. (Bug#9079)
2463
2464 * bidi.c: Integer size and overflow fixes.
2465 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2466 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2467 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2468 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2469 (bidi_find_other_level_edge):
2470 Use ptrdiff_t instead of EMACS_INT where either will do.
2471 This works better on 32-bit hosts configured --with-wide-int.
2472 (bidi_cache_ensure_space): Check for size-calculation overflow.
2473 Use % rather than repeated addition, for better worst-case speed.
2474 Don't set bidi_cache_size until after xrealloc returns, because it
2475 might not return.
2476 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2477 (bidi_cache_ensure_space): Also check that the bidi cache size
2478 does not exceed that of the largest Lisp string or buffer. See Eli
2479 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2480
2481 * alloc.c (__malloc_size_t): Remove.
2482 All uses replaced by size_t. See Andreas Schwab's note
2483 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2484
2485 * image.c: Improve checking for integer overflow.
2486 (check_image_size): Assume that f is nonnull, since
2487 it is always nonnull in practice. This is one less thing to
2488 worry about when checking for integer overflow later.
2489 (x_check_image_size): New function, which checks for integer
2490 overflow issues inside X.
2491 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2492 This removes the need for a memory_full check.
2493 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2494 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2495 (xbm_read_bitmap_data): Change locals back to 'int', since
2496 their values must fit in 'int'.
2497 (xpm_load_image, png_load, tiff_load):
2498 Invoke x_create_x_image_and_pixmap earlier,
2499 to avoid much needless work if the image is too large.
2500 (tiff_load): Treat overly large images as if
2501 x_create_x_image_and_pixmap failed, not as malloc failures.
2502 (gs_load): Use x_check_image_size.
2503
2504 * gtkutil.c: Omit integer casts.
2505 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2506 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2507
2508 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2509
2510 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2511 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2512 would wrongly return t on a 64-bit host.
2513
2514 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2515 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2516 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2517 and therefore cause GCC to emit a bogus diagnostic in some cases.
2518
2519 * image.c: Integer signedness and overflow and related fixes.
2520 This is not an exhaustive set of fixes, but it's time to
2521 record what I've got.
2522 (lookup_pixel_color, check_image_size): Remove redundant decls.
2523 (check_image_size): Don't assume that arbitrary EMACS_INT values
2524 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2525 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2526 (tiff_load, imagemagick_load_image):
2527 Check for overflow in size calculations.
2528 (x_create_x_image_and_pixmap): Remove unnecessary test for
2529 xmalloc returning NULL; that can't happen.
2530 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2531 (xpm_color_bucket): Use better integer hashing function.
2532 (xpm_cache_color): Don't possibly over-allocate memory.
2533 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2534 (gif_memory_source):
2535 Use ptrdiff_t, not int or size_t, to record sizes.
2536 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2537 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2538 either works, as we prefer signed integers.
2539 (tiff_read_from_memory, tiff_write_from_memory):
2540 Return tsize_t, not size_t, since that's what the TIFF API wants.
2541 (tiff_read_from_memory): Don't fail simply because the read would
2542 go past EOF; instead, return a short read.
2543 (tiff_load): Omit no-longer-needed casts.
2544 (Fimagemagick_types): Don't assume size fits into 'int'.
2545
2546 Improve hashing quality when configured --with-wide-int.
2547 * fns.c (hash_string): New function, taken from sxhash_string.
2548 Do not discard information about ASCII character case; this
2549 discarding is no longer needed.
2550 (sxhash-string): Use it. Change sig to match it. Caller changed.
2551 * lisp.h: Declare it.
2552 * lread.c (hash_string): Remove, since we now use fns.c's version.
2553 The fns.c version returns a wider integer if --with-wide-int is
2554 specified, so this should help the quality of the hashing a bit.
2555
2556 * emacs.c: Integer overflow minor fix.
2557 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2558 Define only if GNU_LINUX.
2559 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2560
2561 * dispnew.c: Integer signedness and overflow fixes.
2562 Remove unnecessary forward decls, that were a maintenance hassle.
2563 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2564 All uses changed.
2565 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2566 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2567 (prepare_desired_row, line_draw_cost):
2568 Use int, not unsigned, where either works.
2569 (save_current_matrix, restore_current_matrix):
2570 Use ptrdiff_t, not size_t, where either works.
2571 (init_display): Check for overflow more accurately, and without
2572 relying on undefined behavior.
2573
2574 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2575 Remove, replacing with the new symbols in lisp.h. All uses changed.
2576 * fileio.c (make_temp_name):
2577 * filelock.c (lock_file_1, lock_file):
2578 * xdisp.c (message_dolog):
2579 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2580 Use pMd etc. instead.
2581 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2582 replacing the pWIDE etc. symbols removed from editfns.c.
2583
2584 * keyboard.h (num_input_events): Now uintmax_t.
2585 This is (very slightly) less likely to mess up due to wraparound.
2586 All uses changed.
2587
2588 * buffer.c: Integer signedness fixes.
2589 (alloc_buffer_text, enlarge_buffer_text):
2590 Use ptrdiff_t rather than size_t when either will do, as we prefer
2591 signed integers.
2592
2593 * alloc.c: Integer signedness and overflow fixes.
2594 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2595 (__malloc_size_t): Default to size_t, not to int.
2596 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2597 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2598 Prefer ptrdiff_t to size_t when either would do, as we prefer
2599 signed integers.
2600 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2601 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2602 Now const. Initialize with values that are in range even if char
2603 is signed.
2604 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2605 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2606 These functions do the right thing with sizes > 2**32.
2607 (check_depth): Now ptrdiff_t, not int.
2608 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2609 Adjust to new way of storing sizes. Check for size overflow bugs
2610 in rest of code.
2611 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2612 slightly wrong anyway, as it missed one instance of
2613 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2614 (refill_memory_reserve): Omit needless cast to size_t.
2615 (mark_object_loop_halt): Mark as externally visible.
2616
2617 * xselect.c: Integer signedness and overflow fixes.
2618 (Fx_register_dnd_atom, x_handle_dnd_message):
2619 Use ptrdiff_t, not size_t, since we prefer signed.
2620 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2621 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2622 x_dnd_atoms_size and x_dnd_atoms_length.
2623
2624 * doprnt.c: Prefer signed to unsigned when either works.
2625 * eval.c (verror):
2626 * doprnt.c (doprnt):
2627 * lisp.h (doprnt):
2628 * xdisp.c (vmessage):
2629 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2630 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2631 prefer signed arithmetic to avoid comparison confusion.
2632 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2633 but is a bit tricky.
2634
2635 Assume freestanding C89 headers, string.h, stdlib.h.
2636 * data.c, doprnt.c, floatfns.c, print.c:
2637 Include float.h unconditionally.
2638 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2639 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2640 * regex.c: Likewise for stddef.h, string.h.
2641 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2642 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2643 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2644 (STDC_HEADERS): Remove obsolete defines.
2645 * sysdep.c: Include limits.h unconditionally.
2646
2647 Assume support for memcmp, memcpy, memmove, memset.
2648 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2649 * regex.c (memcmp, memcpy):
2650 Remove; we assume C89 now.
2651
2652 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2653 (__malloc_safe_bcopy): Remove; no longer needed.
2654
2655 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2656 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2657 well either way, and we prefer signed to unsigned.
2658
2659 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2660
2661 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2662 closes the connection while we're reading (bug#9182).
2663
2664 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2665
2666 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2667 are specified (Bug#9168).
2668
2669 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2670
2671 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2672 Found by GCC static checking and --with-wide-int on a 32-bit host.
2673
2674 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2675
2676 * xdisp.c (compute_display_string_pos): Fix logic of caching
2677 previous display string position. Initialize cached_prev_pos to
2678 -1. Fixes slow-down at the beginning of a buffer.
2679
2680 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2681
2682 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2683 for attrs[LFACE_FONTSET_INDEX].
2684
2685 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2686
2687 * xml.c (parse_region): Remove unused local
2688 that was recently introduced.
2689
2690 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2691
2692 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2693 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2694
2695 * xdisp.c (move_it_in_display_line_to): Record the best matching
2696 position for TO_CHARPOS while scanning the line, and restore it on
2697 exit if none of the characters scanned was an exact match.
2698 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2699 when exact match is impossible due to invisible text, and the
2700 lines are truncated.
2701
2702 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2703
2704 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2705 for OSX >= 10.7.
2706
2707 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2708
2709 Fix a significant slow-down of cursor motion with C-n, C-p,
2710 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2711 auto-repeat under bidi redisplay in fontified buffers.
2712 * xdisp.c (compute_stop_pos_backwards): New function.
2713 (next_element_from_buffer): Call compute_stop_pos_backwards to
2714 find a suitable prev_stop when we find ourselves before
2715 base_level_stop.
2716 (reseat): Don't look for prev_stop, as that could mean a very long
2717 run.
2718 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2719 <cached_disp_overlay_modiff>: Cache for last found display string
2720 position.
2721 (compute_display_string_pos): Return the cached position if asked
2722 about the same buffer in the same area of character positions, and
2723 the buffer wasn't changed since the time the display string
2724 position was cached.
2725
2726 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2727
2728 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2729 is an integer, which is important for empty lines. (Bug#9149)
2730
2731 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2732
2733 * frame.c (Fmodify_frame_parameters): In tty case, update the
2734 default face if necessary (Bug#4238).
2735
2736 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2737
2738 * editfns.c (Fstring_to_char): No need to explain what a character
2739 is in the docstring (Bug#6576).
2740
2741 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2742
2743 * xml.c (parse_region): Make sure we always return a tree.
2744
2745 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2746
2747 * xml.c (parse_region): If a document contains only comments,
2748 return that, too.
2749
2750 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2751
2752 * xml.c (make_dom): Return comments, too.
2753
2754 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2755
2756 Port to OpenBSD.
2757 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2758 and the surrounding thread.
2759 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2760 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2761 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2762 timer goes off.
2763 * s/openbsd.h (BROKEN_SIGIO): Define.
2764 * unexelf.c (unexec) [__OpenBSD__]:
2765 Don't update the .mdebug section of the Alpha COFF symbol table.
2766
2767 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2768
2769 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2770 (bug#8460).
2771
2772 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2773
2774 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2775 This fixes some race conditions on the permissions of any newly
2776 created file.
2777
2778 * alloc.c (valid_pointer_p): Use pipe, not open.
2779 This fixes some permissions issues when debugging.
2780
2781 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2782 If fchown fails to set both uid and gid, try to set just gid,
2783 as that is sometimes allowed. Adjust the file's mode to eliminate
2784 setuid or setgid bits that are inappropriate if fchown fails.
2785
2786 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2787
2788 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2789 to compare Lisp_Objects.
2790 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2791 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2792 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2793
2794 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2795
2796 * lread.c (read_integer): Unread even EOF character.
2797 (read1): Likewise. Properly record start position of symbol.
2798
2799 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2800 symbol character follows.
2801
2802 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2803
2804 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2805 This works around a problem with the previous change to Fcopy_file.
2806 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2807 and without this change, GCC might complain about discarding
2808 fchown's return value.
2809
2810 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2811
2812 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2813
2814 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2815
2816 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2817
2818 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2819
2820 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2821 it's used from the C level.
2822
2823 * process.c: Use the same condition for POLL_FOR_INPUT in both
2824 keyboard.c and process.c (bug#1858).
2825
2826 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2827
2828 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2829 (Fgnutls_boot): Use it.
2830
2831 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2832
2833 * doc.c (Fsubstitute_command_keys): Revert last change.
2834
2835 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2836
2837 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2838 quotes the next character, and doesn't affect other longer
2839 sequences (bug#8935).
2840
2841 * lread.c (syms_of_lread): Clarify that is isn't only
2842 `eval-buffer' and `eval-defun' that's affected by
2843 `lexical-binding' (bug#8460).
2844
2845 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2846
2847 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2848 bidi redisplay when a line includes both an image and is
2849 truncated.
2850
2851 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2852
2853 Fix minor problems found by static checking.
2854 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2855 (elsz): Now a signed constant, not a size_t var. We prefer signed
2856 types to unsigned, to avoid integer comparison confusion. Without
2857 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2858 "cannot optimize loop, the loop counter may overflow", a symptom
2859 of the confusion.
2860 * indent.c (Fvertical_motion): Mark locals as initialized.
2861 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2862
2863 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2864
2865 * search.c (Fre_search_backward): Mention `case-fold-search' in
2866 all the re_search_* functions (bug#8138).
2867
2868 * keyboard.c (Fopen_dribble_file): Document when the file is
2869 closed (bug#8056).
2870
2871 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2872
2873 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2874 bidi_cache_idx.
2875
2876 Support bidi reordering of display and overlay strings.
2877 * xdisp.c (compute_display_string_pos)
2878 (compute_display_string_end): Accept additional argument STRING.
2879 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2880 (reseat_to_string): Initialize bidi_it->string.s and
2881 bidi_it->string.schars.
2882 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2883 NULL (avoids a crash in bidi_paragraph_init).
2884 Initialize itb.string.lstring.
2885 (init_iterator): Call bidi_init_it only of a valid
2886 buffer position was specified. Initialize paragraph_embedding to
2887 L2R.
2888 (reseat_to_string): Initialize the bidi iterator.
2889 (display_string): If we need to ignore text properties of
2890 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2891 original value of -1 will not work with bidi.)
2892 (compute_display_string_pos): First arg is now struct
2893 `text_pos *'; all callers changed. Support display properties on
2894 Lisp strings.
2895 (compute_display_string_end): Support display properties on Lisp
2896 strings.
2897 (init_iterator, reseat_1, reseat_to_string): Initialize the
2898 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2899 when iterating on a string not from display properties).
2900 (compute_display_string_pos, compute_display_string_end):
2901 Fix calculation of the object to scan. Fixes an error when using
2902 arrow keys.
2903 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2904 base_level_stop; instead, set base_level_stop to BEGV.
2905 Fixes crashes in vertical-motion.
2906 (next_element_from_buffer): Improve commentary for when
2907 the iterator is before prev_stop.
2908 (init_iterator): Initialize bidi_p from the default value of
2909 bidi-display-reordering, not from buffer-local value. Use the
2910 buffer-local value only if initializing for buffer iteration.
2911 (handle_invisible_prop): Support invisible properties on strings
2912 that are being bidi-reordered.
2913 (set_iterator_to_next): Support bidi reordering of C strings and
2914 Lisp strings.
2915 (next_element_from_string): Support bidi reordering of Lisp
2916 strings.
2917 (handle_stop_backwards): Support Lisp strings as well.
2918 (display_string): Support display of R2L glyph rows.
2919 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2920 (init_iterator): Don't initialize it->bidi_p for strings
2921 here.
2922 (reseat_to_string): Initialize it->bidi_p for strings here.
2923 (next_element_from_string, next_element_from_c_string)
2924 (next_element_from_buffer): Add xassert's for correspondence
2925 between IT's object being iterated and it->bidi_it.string
2926 structure.
2927 (face_before_or_after_it_pos): Support bidi iteration.
2928 (next_element_from_c_string): Handle the case of the first string
2929 character that is not the first one in the visual order.
2930 (get_visually_first_element): New function, refactored from common
2931 parts of next_element_from_buffer, next_element_from_string, and
2932 next_element_from_c_string.
2933 (tool_bar_lines_needed, redisplay_tool_bar)
2934 (display_menu_bar): Force left-to-right direction. Add a FIXME
2935 comment for making that be controlled by a user option.
2936 (push_it, pop_it): Save and restore the state of the
2937 bidi iterator. Save and restore the bidi_p flag.
2938 (pop_it): Iterate out of display property for string iteration as
2939 well.
2940 (iterate_out_of_display_property): Support iteration over strings.
2941 (handle_single_display_spec): Set up it->bidi_it for iteration
2942 over a display string, and call bidi_init_it.
2943 (handle_single_display_spec, next_overlay_string)
2944 (get_overlay_strings_1, push_display_prop): Set up the bidi
2945 iterator for displaying display or overlay strings.
2946 (forward_to_next_line_start): Don't use the shortcut if
2947 bidi-iterating.
2948 (back_to_previous_visible_line_start): If handle_display_prop
2949 pushed the iterator stack, restore the internal state of the bidi
2950 iterator by calling bidi_pop_it same number of times.
2951 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2952 and we are bidi-iterating, don't decrement the iterator position;
2953 instead, set the first_elt flag in the bidi iterator, to produce
2954 the same effect.
2955 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2956 (push_display_prop): xassert that we are iterating a buffer.
2957 (push_it, pop_it): Save and restore paragraph_embedding member.
2958 (handle_single_display_spec, next_overlay_string)
2959 (get_overlay_strings_1, reseat_1, reseat_to_string)
2960 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2961 correctly. Don't assume unibyte strings are not bidi-reordered.
2962 (compute_display_string_pos)
2963 (compute_display_string_end): Fix handling the case of C string.
2964 (push_it, pop_it): Save and restore from_disp_prop_p.
2965 (handle_single_display_spec, push_display_prop): Set the
2966 from_disp_prop_p flag.
2967 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2968 (pop_it): Call iterate_out_of_display_property only if we are
2969 popping after iteration over a string that came from a display
2970 property. Fix a typo in popping stretch info. Add an assertion
2971 for verifying that the iterator position is in sync with the bidi
2972 iterator.
2973 (handle_single_display_spec, get_overlay_strings_1)
2974 (push_display_prop): Fix initialization of paragraph direction for
2975 string when that of the parent object is not yet determined.
2976 (reseat_1): Call bidi_init_it to resync the bidi
2977 iterator with IT's position. (Bug#7616)
2978 (find_row_edges): If ROW->start.pos gives position
2979 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2980 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2981 Reset the from_disp_prop_p flag.
2982 (SAVE_IT, RESTORE_IT): New macros.
2983 (pos_visible_p, face_before_or_after_it_pos)
2984 (back_to_previous_visible_line_start)
2985 (move_it_in_display_line_to, move_it_in_display_line)
2986 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2987 (try_scrolling, redisplay_window, display_line): Use them when
2988 saving a temporary copy of the iterator and restoring it back.
2989 (back_to_previous_visible_line_start, reseat_1)
2990 (init_iterator): Empty the bidi cache "stack".
2991 (move_it_in_display_line_to): If iterator ended up at
2992 EOL, but we never saw any buffer positions smaller than
2993 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2994 motion in bidi-reordered lines.
2995 (move_it_in_display_line_to): Record prev_method and prev_pos
2996 immediately before the call to set_iterator_to_next. Fixes cursor
2997 motion in bidi-reordered lines with stretch glyphs and strings
2998 displayed in margins. (Bug#8133) (Bug#8867)
2999 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3000 TO_CHARPOS.
3001 (pos_visible_p): Support positions in bidi-reordered lines.
3002 Save and restore bidi cache.
3003
3004 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3005 (bidi_paragraph_info): Delete unused struct.
3006 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3007 (bidi_cache_start): New variable.
3008 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3009 to zero.
3010 (bidi_cache_fetch_state, bidi_cache_search)
3011 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3012 (bidi_cache_find, bidi_peek_at_next_level)
3013 (bidi_level_of_next_char, bidi_find_other_level_edge)
3014 (bidi_move_to_visually_next): Compare cache index with
3015 bidi_cache_start rather than with zero.
3016 (bidi_fetch_char): Accept new argument STRING; all callers
3017 changed. Support iteration over a string. Support strings with
3018 display properties. Support unibyte strings. Fix the type of
3019 `len' according to what STRING_CHAR_AND_LENGTH expects.
3020 (bidi_paragraph_init, bidi_resolve_explicit_1)
3021 (bidi_resolve_explicit, bidi_resolve_weak)
3022 (bidi_level_of_next_char, bidi_move_to_visually_next):
3023 Support iteration over a string.
3024 (bidi_set_sor_type, bidi_resolve_explicit_1)
3025 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3026 can now be zero (for strings); special values 0 and -1 were
3027 changed to -1 and -2, respectively.
3028 (bidi_char_at_pos): New function.
3029 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3030 Call it instead of FETCH_MULTIBYTE_CHAR.
3031 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3032 initialized to valid values.
3033 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3034 values.
3035 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3036 the test for valid cached positions. Fix the logic for looking up
3037 the sentinel state in the cache. GCPRO the Lisp string we are
3038 iterating.
3039 (bidi_push_it, bidi_pop_it): New functions.
3040 (bidi_initialize): Initialize the bidi cache start stack pointer.
3041 (bidi_cache_ensure_space): New function, refactored from part of
3042 bidi_cache_iterator_state. Don't assume the required size is just
3043 one BIDI_CACHE_CHUNK away.
3044 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3045 (bidi_count_bytes, bidi_char_at_pos): New functions.
3046 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3047 always valid if bidi_cache_idx is valid.
3048 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3049 is valid if it's going to be used.
3050 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3051 (bidi_cache_fetch_state, bidi_cache_search)
3052 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3053 (bidi_cache_iterator_state, bidi_cache_find)
3054 (bidi_find_other_level_edge, bidi_cache_start_stack):
3055 All variables related to cache indices are now EMACS_INT.
3056
3057 * dispextern.h (struct bidi_string_data): New structure.
3058 (struct bidi_it): New member `string'. Make flag members be 1-bit
3059 fields, and put them last in the struct.
3060 (compute_display_string_pos, compute_display_string_end):
3061 Update prototypes.
3062 (bidi_push_it, bidi_pop_it): Add prototypes.
3063 (struct iterator_stack_entry): New members bidi_p,
3064 paragraph_embedding, and from_disp_prop_p.
3065 (struct it): Member bidi_p is now a bit field 1 bit wide.
3066 (bidi_shelve_cache, bidi_unshelve_cache):
3067 Declare prototypes.
3068
3069 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3070 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3071 and vector-like objects.
3072
3073 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3074 cache around display iteration.
3075
3076 * window.c (Fwindow_end, window_scroll_pixel_based)
3077 (displayed_window_lines, Frecenter): Save and restore the bidi
3078 cache around display iteration.
3079
3080 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3081
3082 * editfns.c (Fdelete_region): Clarify the use of the named
3083 parameters (bug#6788).
3084
3085 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3086
3087 * indent.c (Fvertical_motion): Set and restore w->pointm when
3088 saving and restoring the window's buffer (Bug#9006).
3089
3090 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3091
3092 * editfns.c (Fstring_to_char): Clarify just what is returned
3093 (bug#6576). Text by Eli Zaretskii.
3094
3095 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3096
3097 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3098
3099 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3100
3101 * buffer.c (mmap_find): Fix a typo.
3102
3103 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3104
3105 Fix execution of x selection hooks.
3106 * xselect.c (Qx_lost_selection_functions)
3107 (Qx_sent_selection_functions): New vars.
3108 (syms_of_xselect): DEFSYM them.
3109 (x_handle_selection_request): Pass Qx_sent_selection_functions
3110 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3111 (x_handle_selection_clear,x_clear_frame_selections):
3112 Pass Qx_lost_selection_functions rather than
3113 Vx_lost_selection_functions to Frun_hook_with_args.
3114
3115 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3116
3117 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3118 The old code sometimes used this field without initializing it.
3119
3120 * alloc.c (gc_sweep): Don't read past end of array.
3121 In theory, the old code could also have corrupted Emacs internals,
3122 though it'd be very unlikely.
3123
3124 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3125
3126 * character.c (Fcharacterp): Don't advertise optional ignored
3127 argument. (Bug#4026)
3128
3129 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3130
3131 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3132 key" (bug#4257).
3133
3134 * window.c (Fset_window_start): Doc fix (bug#4199).
3135 (Fset_window_hscroll): Ditto.
3136
3137 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3138
3139 Fix minor new problems caught by GCC 4.6.1.
3140 * term.c (init_tty): Remove unused local.
3141 * xsettings.c (store_monospaced_changed): Define this function only
3142 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3143 not used otherwise.
3144
3145 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3146
3147 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3148
3149 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3150
3151 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3152 are the mini-buffer and the echo area (bug#3320).
3153
3154 * term.c (init_tty): Remove support for supdup, c10 and perq
3155 terminals, which are no longer supported (bug#1482).
3156
3157 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3158
3159 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3160
3161 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3162
3163 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3164 for non-popups (Bug#3642).
3165
3166 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3167
3168 * alloc.c (reset_malloc_hooks): Protoize.
3169 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3170 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3171 * cm.c (losecursor): Likewise.
3172 * data.c (fmod): Likewise.
3173 * dispnew.c (swap_glyphs_in_rows): Likewise.
3174 * emacs.c (memory_warning_signal): Likewise.
3175 * floatfns.c (float_error): Likewise.
3176 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3177 (otf_open, font_otf_capability, generate_otf_features)
3178 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3179 Likewise.
3180 * image.c (pbm_read_file): Likewise.
3181 * indent.c (string_display_width): Likewise.
3182 * intervals.c (check_for_interval, search_for_interval)
3183 (inc_interval_count, count_intervals, root_interval)
3184 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3185 * lread.c (defalias): Likewise.
3186 * ralloc.c (r_alloc_check): Likewise.
3187 * regex.c (set_image_of_range_1, set_image_of_range)
3188 (regex_grow_registers): Likewise.
3189 * sysdep.c (strerror): Likewise.
3190 * termcap.c (valid_filename_p, tprint, main): Likewise.
3191 * tparam.c (main): Likewise.
3192 * unexhp9k800.c (run_time_remap, save_data_space)
3193 (update_file_ptrs, read_header, write_header, calculate_checksum)
3194 (copy_file, copy_rest, display_header): Likewise.
3195 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3196 Likewise.
3197 * xdisp.c (check_it): Likewise.
3198 * xfaces.c (register_color, unregister_color, unregister_colors):
3199 Likewise.
3200 * xfns.c (print_fontset_result): Likewise.
3201 * xrdb.c (member, fatal, main): Likewise.
3202
3203 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3204
3205 Fix minor problems found by static checking (Bug#9031).
3206 * chartab.c (char_table_set_range, map_sub_char_table):
3207 Remove unused locals.
3208 (uniprop_table): Now static.
3209 * composite.c (_work_char): Remove unused static var.
3210
3211 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3212
3213 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3214
3215 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3216
3217 * gtkutil.c (qttip_cb): Remove code without function.
3218
3219 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3220
3221 * w32.c (pthread_sigmask): New stub.
3222
3223 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3224
3225 Use pthread_sigmask, not sigprocmask (Bug#9010).
3226 sigprocmask is portable only for single-threaded applications, and
3227 Emacs can be multi-threaded when it uses GTK.
3228 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3229 (LIBES): Use it.
3230 * callproc.c (Fcall_process):
3231 * process.c (create_process):
3232 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3233 Use pthread_sigmask, not sigprocmask.
3234
3235 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3236
3237 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3238 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3239 wrong (Bug#8591).
3240
3241 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3242
3243 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3244 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3245 (xg_hide_tooltip): Fix comment.
3246
3247 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3248 in registerServicesMenuSendTypes.
3249 (validRequestorForSendType): Don't check ns_return_types.
3250
3251 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3252 ns_return_type.
3253
3254 2011-07-08 Jason Rumney <jasonr@gnu.org>
3255
3256 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3257 frame struct members of non-existent frames (Bug#6284).
3258
3259 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3260
3261 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3262 variable firstTime not needed on OSX >= 10.6.
3263 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3264 >= 10.5. Use setKnobProportion, setDoubleValue.
3265
3266 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3267 (MAC_OS_X_VERSION_10_5): Define if not defined.
3268 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3269 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3270 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3271
3272 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3273 cString and lossyCString on OSX >= 10.4
3274
3275 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
3276 sizeToFit on OSX >= 10.2.
3277
3278 * nsimage.m (allocInitFromFile): Don't use deprecated method
3279 bestRepresentationForDevice on OSX >= 10.6.
3280
3281 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3282 to avoid warning.
3283
3284 * emacs.c: Declare unexec_init_emacs_zone.
3285
3286 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3287
3288 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3289
3290 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3291 on svcsMenu (Bug#8842).
3292
3293 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3294 ns_return_types.
3295 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3296
3297 * nsterm.m (QUTF8_STRING): Declare.
3298 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3299 (validRequestorForSendType): Return type is (id).
3300 Change indexOfObjectIdenticalTo to indexOfObject.
3301 Check if we have local selection before returning self (Bug#8842).
3302 (writeSelectionToPasteboard): Put local selection into paste board
3303 if we have a local selection (Bug#8842).
3304 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3305
3306 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3307 (ns_get_local_selection): Declare.
3308
3309 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3310
3311 * keymap.c (describe_map_tree): Don't insert a double newline at
3312 the end of the buffer (bug#1169) and return whether we inserted
3313 something.
3314
3315 * callint.c (Fcall_interactively): Change "reading args" to
3316 "providing args" to try to clarify what it does (bug#1010).
3317
3318 2011-07-07 Kenichi Handa <handa@m17n.org>
3319
3320 * composite.c (composition_compute_stop_pos): Ignore a static
3321 composition starting before CHARPOS (Bug#8915).
3322
3323 * xdisp.c (handle_composition_prop): Likewise.
3324
3325 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3326
3327 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3328 (Bug#9015)
3329
3330 2011-07-07 Kenichi Handa <handa@m17n.org>
3331
3332 * character.h (unicode_category_t): New enum type.
3333
3334 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3335 (Qchar_code_property_table): New variable.
3336 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3337 (UNIPROP_COMPRESSED_FORM_P): New macros.
3338 (char_table_ascii): Uncompress the compressed values.
3339 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3340 Uncompress the compressed values.
3341 (sub_char_table_ref_and_range): Likewise.
3342 (char_table_ref_and_range): Uncompress the compressed values.
3343 (sub_char_table_set): New arg is_uniprop. Callers changed.
3344 Uncompress the compressed values.
3345 (sub_char_table_set_range): Args changed. Callers changed.
3346 (char_table_set_range): Adjuted for the above change.
3347 (map_sub_char_table): Delete args default_val and parent. Add arg
3348 top. Give decoded values to a Lisp function.
3349 (map_char_table): Adjust for the above change. Give decoded
3350 values to a Lisp function. Gcpro more variables.
3351 (uniprop_table_uncompress)
3352 (uniprop_decode_value_run_length): New functions.
3353 (uniprop_decoder, uniprop_decoder_count): New variables.
3354 (uniprop_get_decoder, uniprop_encode_value_character)
3355 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3356 New functions.
3357 (uniprop_encoder, uniprop_encoder_count): New variables.
3358 (uniprop_get_encoder, uniprop_table)
3359 (Funicode_property_table_internal, Fget_unicode_property_internal)
3360 (Fput_unicode_property_internal): New functions.
3361 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3362 Sunicode_property_table_internal, Sget_unicode_property_internal,
3363 and Sput_unicode_property_internal. Defvar_lisp
3364 char-code-property-alist.
3365
3366 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3367 Vunicode_category_table.
3368
3369 * font.c (font_range): Adjust for the change of
3370 Vunicode_category_table.
3371
3372 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3373
3374 * m/iris4d.h: Remove file, move contents ...
3375 * s/irix6-5.h: ... here.
3376
3377 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3378
3379 Remove unportable assumption about struct layout (Bug#8884).
3380 * alloc.c (mark_buffer):
3381 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3382 (clone_per_buffer_values): Don't assume that
3383 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3384 This isn't true in general, and it's particularly not true
3385 if Emacs is configured with --with-wide-int.
3386 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3387 New macros, used in the buffer.c change.
3388
3389 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3390
3391 * xsettings.c: Use both GConf and GSettings if both are available.
3392 (store_config_changed_event): Add comment.
3393 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3394 (store_tool_bar_style_changed): New functions.
3395 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3396 (struct xsettings): Move font inside HAVE_XFT.
3397 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3398 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3399 Move inside HAVE_XFT.
3400 (something_changed_gsettingsCB): Rename from something_changedCB.
3401 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3402 also.
3403 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3404 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3405 (something_changed_gconfCB): Rename from something_changedCB.
3406 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3407 (parse_settings): Move check for font inside HAVE_XFT.
3408 (read_settings, apply_xft_settings): Add comment.
3409 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3410 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3411 call store_font_name_changed.
3412 (xft_settings_event): Add comment.
3413 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3414 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3415 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3416 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3417 (xsettings_initialize): Call init_gsettings last.
3418 (xsettings_get_system_font, xsettings_get_system_normal_font):
3419 Add comment.
3420
3421 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3422
3423 Random fixes. E.g., (random) never returned negative values.
3424 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3425 subseconds part to the entropy, as that's a bit more random.
3426 Prefer signed to unsigned, since the signedness doesn't matter and
3427 in general we prefer signed. When given a limit, use a
3428 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3429 latter isn't right if USE_2_TAGS_FOR_INTS.
3430 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3431 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3432
3433 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3434
3435 * textprop.c (text_property_stickiness):
3436 Obey Vtext_property_default_nonsticky.
3437 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3438 * w32fns.c (syms_of_w32fns):
3439 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3440
3441 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3442
3443 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3444 This is more efficient than Ffile_directory_p and avoids a minor race.
3445
3446 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3447
3448 * buffer.c (Foverlay_put): Say what the return value is
3449 (bug#7835).
3450
3451 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3452 is a directory before asking whether to use the file name
3453 (bug#7564).
3454 (barf_or_query_if_file_exists): Make the "File is a directory"
3455 error be more correct.
3456
3457 * fns.c (Frequire): Remove the mention of the .gz files, since
3458 that's installation-specific, but keep the mention of
3459 `get-load-suffixes'.
3460
3461 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3462
3463 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3464 Report string overflow if the output is too long.
3465
3466 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3467
3468 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3469 (syms_of_gnutls): Remove duplicate DEFSYM for
3470 Qgnutls_bootprop_verify_hostname_error, an error for
3471 Qgnutls_bootprop_verify_error (which is no longer used).
3472
3473 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3474 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3475 Also (re)move comments that are misplaced or no longer relevant.
3476
3477 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3478
3479 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3480
3481 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3482
3483 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3484 and background color parameters if they have been changed.
3485
3486 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3487
3488 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3489
3490 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3491
3492 * xsettings.c (SYSTEM_FONT): Define only when used.
3493 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3494
3495 * keymap.c (access_keymap_1): Now static.
3496
3497 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3498
3499 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3500 leave any prefix arg for the up event (Bug#1586).
3501
3502 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3503
3504 * lread.c (syms_of_lread): Mention single symbols defined by
3505 `defvar' or `defconst' (bug#7154).
3506
3507 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3508 (Frequire): Mention get-load-suffixes.
3509
3510 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3511
3512 * window.h (window): Remove clone_number slot.
3513 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3514 Remove.
3515 (make_parent_window, make_window, saved_window)
3516 (Fset_window_configuration, save_window_save): Don't deal with
3517 clone numbers.
3518 * buffer.c (Qclone_number): Remove declaration.
3519 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3520
3521 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3522
3523 Add multiple inheritance to keymaps.
3524 * keymap.c (Fmake_composed_keymap): New function.
3525 (Fset_keymap_parent): Simplify.
3526 (fix_submap_inheritance): Remove.
3527 (access_keymap_1): New function extracted from access_keymap to handle
3528 embedded parents and handle lists of maps.
3529 (access_keymap): Use it.
3530 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3531 (Fcopy_keymap): Handle embedded parents.
3532 (Fcommand_remapping, define_as_prefix): Simplify.
3533 (Fkey_binding): Simplify.
3534 (syms_of_keymap): Move minibuffer-local-completion-map,
3535 minibuffer-local-filename-completion-map,
3536 minibuffer-local-must-match-map, and
3537 minibuffer-local-filename-must-match-map to Elisp.
3538 (syms_of_keymap): Defsubr make-composed-keymap.
3539 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3540 (parse_menu_item): Trivial simplification.
3541
3542 2011-07-01 Glenn Morris <rgm@gnu.org>
3543
3544 * Makefile.in (SETTINGS_LIBS): Fix typo.
3545
3546 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3547
3548 * coding.c (Fencode_coding_string): Record the last coding system
3549 used, as the function doc string says (bug#8738).
3550
3551 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3552
3553 * xsettings.c (store_monospaced_changed): Take new font as arg and
3554 check for change against current_mono_font.
3555 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3556 (emacs_settings_constructor, emacs_settings_get_property)
3557 (emacs_settings_set_property, emacs_settings_class_init)
3558 (emacs_settings_init, gsettings_obj): Remove.
3559 (something_changedCB): New function for HAVE_GSETTINGS.
3560 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3561 with value as argument.
3562 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3563 g_settings_new (Bug#8967). Do not create gsettings_obj.
3564 Remove calls to g_settings_bind. Connect something_changedCB to
3565 "changed".
3566
3567 * xgselect.c: Add defined (HAVE_GSETTINGS).
3568 (xgselect_initialize): Ditto.
3569
3570 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3571 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3572 xg_select.
3573
3574 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3575
3576 * eval.c (struct backtrace): Simplify and port the data structure.
3577 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3578 signed bit field, as this assumption is not portable and it makes
3579 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3580 "char debug_on_exit : 1" as this is not portable either; instead,
3581 use the portable "unsigned int debug_on_exit : 1". Remove unused
3582 member evalargs. Remove obsolete comments about cc bombing out.
3583
3584 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3585
3586 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3587 Let HAVE_GSETTINGS override HAVE_GCONF.
3588 (store_monospaced_changed): New function.
3589 (EMACS_SETTINGS): A new type derived from GObject to handle
3590 GSettings notifications.
3591 (emacs_settings_constructor, emacs_settings_get_property)
3592 (emacs_settings_set_property, emacs_settings_class_init):
3593 New functions.
3594 (gsettings_client, gsettings_obj): New variables.
3595 (GSETTINGS_SCHEMA): New define.
3596 (something_changedCB): Call store_monospaced_changed.
3597 (init_gsettings): New function.
3598 (xsettings_initialize): Call init_gsettings.
3599 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3600 to NULL.
3601
3602 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3603 GCONF_CFLAGS/LIBS.
3604
3605 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3606
3607 * window.c (resize_root_window, grow_mini_window)
3608 (shrink_mini_window): Rename Qresize_root_window to
3609 Qwindow_resize_root_window and Qresize_root_window_vertically to
3610 Qwindow_resize_root_window_vertically.
3611
3612 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3613
3614 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3615
3616 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3617
3618 * makefile.w32-in: Redesign dependencies so they reflect more
3619 clearly which files are directly included by each source file,
3620 and not through other includes.
3621
3622 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3623
3624 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3625 (sort_overlays, overlay_strings): When an overlay's clone number
3626 matches the window's clone number process the overlay even if
3627 the overlay's window property doesn't match the current window.
3628
3629 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3630 (Fwindow_hchild): Rename to Fwindow_left_child.
3631 (Fwindow_next): Rename to Fwindow_next_sibling.
3632 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3633 (resize_window_check): Rename to window_resize_check.
3634 (resize_window_apply): Rename to window_resize_apply.
3635 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3636 (Fdelete_other_windows_internal, resize_frame_windows)
3637 (Fsplit_window_internal, Fdelete_window_internal)
3638 (grow_mini_window, shrink_mini_window)
3639 (Fresize_mini_window_internal): Fix callers accordingly.
3640
3641 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3642
3643 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3644 (emacs_fixed_set_min_size): Remove.
3645 (emacs_fixed_new): Take frame as argument.
3646
3647 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3648 (_EmacsFixedPrivate): Remove minwidth/height.
3649 Add struct frame *f.
3650 (emacs_fixed_init): Initialize priv->f.
3651 (get_parent_class, emacs_fixed_set_min_size): Remove.
3652 (emacs_fixed_new): Set priv->f to argument.
3653 (emacs_fixed_get_preferred_width)
3654 (emacs_fixed_get_preferred_height): Use min_width/height from
3655 frames size_hint to set minimum and natural (Bug#8919).
3656 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3657 and use min_width/height from frames size_hint to set
3658 min_width/height (Bug#8919).
3659
3660 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3661 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3662 Fix indentation.
3663
3664 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3665
3666 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3667 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3668 called at ZV.
3669
3670 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3671
3672 * process.c (wait_reading_process_output): Bypass select if
3673 waiting for a cell while ignoring keyboard input, and input is
3674 pending. Suggested by Jan Djärv (Bug#8869).
3675
3676 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3677
3678 Use gnulib's dup2 module instead of rolling our own.
3679 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3680
3681 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3682
3683 * dispnew.c (scrolling_window): Before scrolling, turn off a
3684 mouse-highlight in the window being scrolled.
3685
3686 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3687
3688 Move DEFSYM to lisp.h and use everywhere.
3689
3690 * character.h (DEFSYM): Move declaration...
3691 * lisp.h (DEFSYM): ...here.
3692
3693 * gnutls.c:
3694 * minibuf.c:
3695 * w32menu.c:
3696 * w32proc.c:
3697 * w32select.c: Don't include character.h.
3698
3699 * alloc.c (syms_of_alloc):
3700 * buffer.c (syms_of_buffer):
3701 * bytecode.c (syms_of_bytecode):
3702 * callint.c (syms_of_callint):
3703 * casefiddle.c (syms_of_casefiddle):
3704 * casetab.c (init_casetab_once):
3705 * category.c (init_category_once, syms_of_category):
3706 * ccl.c (syms_of_ccl):
3707 * cmds.c (syms_of_cmds):
3708 * composite.c (syms_of_composite):
3709 * dbusbind.c (syms_of_dbusbind):
3710 * dired.c (syms_of_dired):
3711 * dispnew.c (syms_of_display):
3712 * doc.c (syms_of_doc):
3713 * editfns.c (syms_of_editfns):
3714 * emacs.c (syms_of_emacs):
3715 * eval.c (syms_of_eval):
3716 * fileio.c (syms_of_fileio):
3717 * fns.c (syms_of_fns):
3718 * frame.c (syms_of_frame):
3719 * fringe.c (syms_of_fringe):
3720 * insdel.c (syms_of_insdel):
3721 * keymap.c (syms_of_keymap):
3722 * lread.c (init_obarray, syms_of_lread):
3723 * macros.c (syms_of_macros):
3724 * msdos.c (syms_of_msdos):
3725 * print.c (syms_of_print):
3726 * process.c (syms_of_process):
3727 * search.c (syms_of_search):
3728 * sound.c (syms_of_sound):
3729 * syntax.c (init_syntax_once, syms_of_syntax):
3730 * terminal.c (syms_of_terminal):
3731 * textprop.c (syms_of_textprop):
3732 * undo.c (syms_of_undo):
3733 * w32.c (globals_of_w32):
3734 * window.c (syms_of_window):
3735 * xdisp.c (syms_of_xdisp):
3736 * xfaces.c (syms_of_xfaces):
3737 * xfns.c (syms_of_xfns):
3738 * xmenu.c (syms_of_xmenu):
3739 * xsettings.c (syms_of_xsettings):
3740 * xterm.c (syms_of_xterm): Use DEFSYM.
3741
3742 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3743
3744 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3745
3746 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3747
3748 Integer and buffer overflow fixes (Bug#8873).
3749
3750 * print.c (printchar, strout): Check for string overflow.
3751 (PRINTPREPARE, printchar, strout):
3752 Don't set size unless allocation succeeds.
3753
3754 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3755 for sizes. Check for string overflow more accurately.
3756 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3757
3758 * macros.c: Integer and buffer overflow fixes.
3759 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3760 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3761 Use ptrdiff_t, not int, for sizes.
3762 Don't increment bufsize until after realloc succeeds.
3763 Check for size-calculation overflow.
3764 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3765
3766 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3767
3768 * lread.c: Integer overflow fixes.
3769 (read_integer): Radix is now EMACS_INT, not int,
3770 to improve quality of diagnostics for out-of-range radices.
3771 Calculate buffer size correctly for out-of-range radices.
3772 (read1): Check for integer overflow in radices, and in
3773 read-circle numbers.
3774 (read_escape): Avoid int overflow.
3775 (Fload, openp, read_buffer_size, read1)
3776 (substitute_object_recurse, read_vector, read_list, map_obarray):
3777 Use ptrdiff_t, not int, for sizes.
3778 (read1): Use EMACS_INT, not int, for sizes.
3779 Check for size overflow.
3780
3781 * image.c (cache_image): Check for size arithmetic overflow.
3782
3783 * lread.c: Integer overflow issues.
3784 (saved_doc_string_size, saved_doc_string_length)
3785 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3786 Now ptrdiff_t, not int.
3787 (read1): Don't assume doc string length fits in int. Check for
3788 out-of-range doc string lengths.
3789 (read_list): Don't assume file position fits in int.
3790 (read_escape): Check for hex character overflow.
3791
3792 2011-06-22 Leo Liu <sdl.web@gmail.com>
3793
3794 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3795 Move to minibuffer.el.
3796
3797 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3798
3799 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3800 The following patches are for when GLYPH_DEBUG && !XASSERT.
3801 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3802 * dispnew.c (flush_stdout):
3803 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3804 Mark as externally visible.
3805 * dispnew.c (check_window_matrix_pointers): Now static.
3806 * dispnew.c (window_to_frame_vpos):
3807 * xfns.c (unwind_create_frame):
3808 * xterm.c (x_check_font): Remove unused local.
3809 * scroll.c (CHECK_BOUNDS):
3810 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3811 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3812 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3813 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3814 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3815 Now static.
3816 (debug_method_add): Use va_list and vsprintf rather than relying
3817 on undefined behavior with wrong number of arguments.
3818 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3819 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3820 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3821 since we're not interested in debugging glyphs with old libraries.
3822 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3823 GCC 4.6.0's static checking.
3824
3825 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3826
3827 Integer overflow and signedness fixes (Bug#8873).
3828 A few related buffer overrun fixes, too.
3829
3830 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3831
3832 * dispextern.h (struct face.stipple):
3833 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3834 (x_bitmap_mask, x_allocate_bitmap_record)
3835 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3836 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3837 (x_create_bitmap_from_xpm_data):
3838 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3839 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3840 (.bitmaps_last):
3841 * xfaces.c (load_pixmap):
3842 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3843 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3844 (.bitmaps_last, struct x_output.icon_bitmap):
3845 Use ptrdiff_t, not int, for bitmap indexes.
3846 (x_allocate_bitmap_record): Check for size overflow.
3847 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3848
3849 Use ptrdiff_t, not int, for overlay counts.
3850 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3851 * editfns.c (overlays_around, get_pos_property):
3852 * textprop.c (get_char_property_and_overlay):
3853 * xdisp.c (next_overlay_change, note_mouse_highlight):
3854 * xfaces.c (face_at_buffer_position):
3855 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3856 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3857 (Fnext_overlay_change, Fprevious_overlay_change)
3858 (mouse_face_overlay_overlaps, Foverlays_in):
3859 Use ptrdiff_t, not int, for sizes.
3860 (overlays_at, overlays_in): Check for size-calculation overflow.
3861
3862 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3863
3864 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3865 (x_session_initialize): Do not assume string length fits in int.
3866
3867 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3868 This is unlikely, but can occur if DPI is outlandish.
3869
3870 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3871 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3872
3873 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3874 * xrdb.c (magic_file_p, search_magic_path):
3875 Omit last arg SUFFIX; it was always 0. All callers changed.
3876 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3877
3878 * xfont.c (xfont_match): Avoid need for strlen.
3879
3880 * xfns.c: Don't assume strlen fits in int.
3881 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3882
3883 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3884 not unsigned long, as we prefer signed integers. All callers changed.
3885 Detect integer overflow in repeat count.
3886 (message_dolog): Don't assume print length fits in 39 bytes.
3887 (display_mode_element): Don't assume strlen fits in int.
3888
3889 * termcap.c: Don't assume sizes fit in int and never overflow.
3890 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3891 (gobble_line): Check for size-calculation overflow.
3892
3893 * minibuf.c (Fread_buffer):
3894 * lread.c (intern, intern_c_string):
3895 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3896 Don't assume string length fits in int.
3897
3898 * keyboard.c (parse_tool_bar_item):
3899 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3900
3901 * font.c: Don't assume string length fits in int.
3902 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3903 Use ptrdiff_t, not int.
3904 (font_intern_prop): Don't assume string length fits in int.
3905 Don't assume integer property fits in fixnum.
3906 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3907
3908 * filelock.c: Fix some buffer overrun and integer overflow issues.
3909 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3910 Reformulate so as not to need the command string.
3911 Invoke gzip -cd rather than gunzip, as it's more portable.
3912 (lock_info_type, lock_file_1, lock_file):
3913 Don't assume pid_t and time_t fit in unsigned long.
3914 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3915 (current_lock_owner): Prefer signed type for sizes.
3916 Use memcpy, not strncpy, where memcpy is what is really wanted.
3917 Don't assume (via atoi) that time_t and pid_t fit in int.
3918 Check for time_t and/or pid_t out of range, e.g., via a network share.
3919 Don't alloca where an auto var works fine.
3920
3921 * fileio.c: Fix some integer overflow issues.
3922 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3923 Don't assume string length fits in int.
3924 (directory_file_name): Don't assume string length fits in long.
3925 (make_temp_name): Don't assume pid fits in int, or that its print
3926 length is less than 20.
3927
3928 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3929
3930 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3931
3932 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3933
3934 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3935 We prefer signed integers, even for size calculations.
3936
3937 * emacs.c: Don't assume string length fits in 'int'.
3938 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3939 (main): Don't invoke strlen when not needed.
3940
3941 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3942 (XD_DEBUG_MESSAGE): Don't waste a byte.
3943
3944 * callproc.c (getenv_internal_1, getenv_internal)
3945 (Fgetenv_internal):
3946 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3947
3948 * lread.c (invalid_syntax): Omit length argument.
3949 All uses changed. This doesn't fix a bug, but it simplifies the
3950 code away from its former Hollerith-constant appearance, and it's
3951 one less 'int' to worry about when looking at integer-overflow issues.
3952 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3953
3954 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3955 This didn't break anything, but it didn't help either.
3956 It's confusing to put a bogus integer in a place where the actual
3957 value does not matter.
3958 (LIST_END_P): Remove unused macro and its bogus comment.
3959 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3960
3961 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3962 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3963 implementation.
3964 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3965 We prefer signed types, and the value cannot exceed the EMACS_INT
3966 range anyway (because otherwise the length would not be representable).
3967 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3968 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3969 This avoids a GCC warning when WIDE_EMACS_INT.
3970
3971 * indent.c (sane_tab_width): New function.
3972 (current_column, scan_for_column, Findent_to, position_indentation)
3973 (compute_motion): Use it. This is just for clarity.
3974 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3975
3976 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3977
3978 * lisp.h (lint_assume): New macro.
3979 * composite.c (composition_gstring_put_cache):
3980 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3981
3982 * editfns.c, insdel.c:
3983 Omit unnecessary forward decls, to simplify future changes.
3984
3985 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3986
3987 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3988
3989 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3990 Use much-faster test for byte-length change.
3991 Don't assume string byte-length fits in 'int'.
3992 Check that character arg fits in 'int'.
3993 (mapcar1): Declare byte as byte, for clarity.
3994
3995 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3996
3997 * fns.c (concat): Catch string overflow earlier.
3998 Do not rely on integer wraparound.
3999
4000 * dispextern.h (struct it.overlay_strings_charpos)
4001 (struct it.selective): Now EMACS_INT, not int.
4002 * xdisp.c (forward_to_next_line_start)
4003 (back_to_previous_visible_line_start)
4004 (reseat_at_next_visible_line_start, next_element_from_buffer):
4005 Don't arbitrarily truncate the value of 'selective' to int.
4006
4007 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4008
4009 * composite.c: Don't truncate sizes to 'int'.
4010 (composition_gstring_p, composition_reseat_it)
4011 (composition_adjust_point): Use EMACS_INT, not int.
4012 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4013 not EMACS_UINT, for indexes.
4014
4015 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4016
4017 * buffer.c: Include <verify.h>.
4018 (struct sortvec.priority, struct sortstr.priority):
4019 Now EMACS_INT, not int.
4020 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4021 (struct sortstr.size, record_overlay_string)
4022 (struct sortstrlist.size, struct sortlist.used):
4023 Don't truncate size to int.
4024 (record_overlay_string): Check for size-calculation overflow.
4025 (init_buffer_once): Check at compile-time, not run-time.
4026
4027 2011-06-22 Jim Meyering <meyering@redhat.com>
4028
4029 Don't leak an XBM-image-sized buffer
4030 * image.c (xbm_load): Free the image buffer after using it.
4031
4032 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4033
4034 Port to Sun C.
4035 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4036 that Sun C diagnosed.
4037 * fns.c (secure_hash): Fix pointer signedness issue.
4038 * intervals.c (static_offset_intervals): New function.
4039 (offset_intervals): Use it.
4040
4041 2011-06-21 Leo Liu <sdl.web@gmail.com>
4042
4043 * deps.mk (fns.o):
4044 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4045 sha512.h.
4046
4047 * fns.c (secure_hash): Rename from crypto_hash_function and change
4048 the first arg to accept symbols.
4049 (Fsecure_hash): New primitive.
4050 (syms_of_fns): New symbols.
4051
4052 2011-06-20 Deniz Dogan <deniz@dogan.se>
4053
4054 * process.c (Fset_process_buffer): Clarify return value in
4055 docstring.
4056
4057 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4058
4059 * dispnew.c (add_window_display_history): Use BVAR.
4060
4061 * xdisp.c (debug_method_add): Use BVAR.
4062 (check_window_end, dump_glyph_matrix, dump_glyph)
4063 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4064
4065 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4066 Likewise.
4067
4068 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4069 check till after the cache is created in init_frame_faces.
4070
4071 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4072
4073 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4074
4075 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4076
4077 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4078 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4079 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4080
4081 Improve buffer-overflow checking (Bug#8873).
4082 * fileio.c (Finsert_file_contents):
4083 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4084 Remove the old (too-loose) buffer overflow checks.
4085 They weren't needed, since make_gap checks for buffer overflow.
4086 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4087 The old code merely checked for Emacs fixnum overflow, and relied
4088 on undefined (wraparound) behavior. The new code avoids undefined
4089 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4090
4091 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4092 Tune. Don't use wider integers than needed. Don't use alloca.
4093 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4094
4095 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4096
4097 * insdel.c, lisp.h (buffer_overflow): New function.
4098 (insert_from_buffer_1, replace_range, replace_range_2):
4099 * insdel.c (make_gap_larger):
4100 * editfns.c (Finsert_char):
4101 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4102
4103 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4104
4105 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4106
4107 Integer overflow and signedness fixes (Bug#8873).
4108
4109 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4110 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4111
4112 * fileio.c: Don't assume EMACS_INT fits in off_t.
4113 (emacs_lseek): New static function.
4114 (Finsert_file_contents, Fwrite_region): Use it.
4115 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4116
4117 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4118
4119 * fns.c: Don't overflow int when computing a list length.
4120 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4121 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4122 truncation on 64-bit hosts. Check for QUIT every
4123 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4124 faster and is responsive enough.
4125 (Flength): Report an error instead of overflowing an integer.
4126 (Fsafe_length): Return a float if the value is not representable
4127 as a fixnum. This shouldn't happen except in contrived situations.
4128 (Fnthcdr, Fsort): Don't assume list length fits in int.
4129 (Fcopy_sequence): Don't assume vector length fits in int.
4130
4131 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4132 (header_size, word_size): New constants.
4133 (allocate_vectorlike): Don't check size overflow here.
4134 (allocate_vector): Check it here instead, since this is the only
4135 caller of allocate_vectorlike that could cause overflow.
4136 Check that the new vector's length is representable as a fixnum.
4137
4138 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4139 The previous code was bogus. For example, next_almost_prime (32)
4140 returned 39, which is undesirable as it is a multiple of 3; and
4141 next_almost_prime (24) returned 25, which is a multiple of 5 so
4142 why was the code bothering to check for multiples of 7?
4143
4144 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4145
4146 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4147
4148 Variadic C functions now count arguments with ptrdiff_t.
4149 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4150 Back then I didn't know that the Emacs coding style prefers signed int.
4151 Also, in the meantime I found a few more instances where arguments
4152 were being counted with int, which may truncate counts on 64-bit
4153 machines, or EMACS_INT, which may be unnecessarily wide.
4154 * lisp.h (struct Lisp_Subr.function.aMANY)
4155 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4156 Arg counts are now ptrdiff_t, not size_t.
4157 All variadic functions and their callers changed accordingly.
4158 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4159 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4160 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4161 * callint.c (Fcall_interactively): Check arg count for overflow,
4162 to avoid potential buffer overrun. Use signed char, not 'int',
4163 for 'varies' array, so that we needn't bother to check its size
4164 calculation for overflow.
4165 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4166 * eval.c (apply_lambda):
4167 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4168 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4169 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4170
4171 * callint.c (Fcall_interactively): Don't use index var as event count.
4172
4173 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4174 * mem-limits.h (SIZE): Remove; no longer used.
4175
4176 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4177
4178 Remove unnecessary casts.
4179 * xterm.c (x_term_init):
4180 * xfns.c (x_set_border_pixel):
4181 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4182 These aren't needed now that we assume ANSI C.
4183
4184 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4185 It's more likely to cause problems (due to unsigned overflow)
4186 than to cure them.
4187
4188 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4189
4190 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4191
4192 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4193
4194 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4195
4196 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4197
4198 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4199
4200 GLYPH_CODE_FACE returns EMACS_INT, not int.
4201 * dispextern.h (merge_faces):
4202 * xfaces.c (merge_faces):
4203 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4204 Don't assume EMACS_INT fits in int.
4205
4206 * character.h (CHAR_VALID_P): Remove unused parameter.
4207 * fontset.c, lisp.h, xdisp.c: All uses changed.
4208
4209 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4210
4211 * fns.c (concat): Minor tuning based on overflow analysis.
4212 This doesn't fix any bugs. Use int to hold character, instead
4213 of constantly refetching from Emacs object. Use XFASTINT, not
4214 XINT, for value known to be a character. Don't bother comparing
4215 a single byte to 0400, as it's always less.
4216
4217 * floatfns.c (Fexpt):
4218 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4219
4220 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4221 for characters.
4222
4223 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4224
4225 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4226 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4227 incorrectly succeed when S was a string, because 4294967386 was
4228 truncated before it was used.
4229
4230 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4231 Otherwise, an out-of-range integer could cause undefined behavior
4232 on a 64-bit host.
4233
4234 * composite.c: Use int, not EMACS_INT, for characters.
4235 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4236 EMACS_INT, for values that are known to be in character range.
4237 This doesn't fix any bugs but is the usual style inside Emacs and
4238 may generate better code on 32-bit machines.
4239
4240 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4241 This is for reasons similar to the recent CHAR_STRING fix.
4242 * charset.c (Fencode_char): Check that character arg is actually
4243 a character. Pass an int to ENCODE_CHAR.
4244 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4245 wider than 'int', as a compile-time check to prevent future regressions
4246 in this area.
4247
4248 * character.c (char_string): Remove unnecessary casts.
4249
4250 Make sure a 64-bit char is never passed to CHAR_STRING.
4251 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4252 by silently ignoring the top 32 bits, allowing some values
4253 that were far too large to be valid characters.
4254 * character.h: Include <verify.h>.
4255 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4256 arguments are no wider than unsigned, as a compile-time check
4257 to prevent future regressions in this area.
4258 * data.c (Faset):
4259 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4260 (Fsubst_char_in_region):
4261 * fns.c (concat):
4262 * xdisp.c (decode_mode_spec_coding):
4263 Adjust to CHAR_STRING's new requirement.
4264 * editfns.c (Finsert_char, Fsubst_char_in_region):
4265 * fns.c (concat): Check that character args are actually
4266 characters. Without this test, these functions did the wrong
4267 thing with wildly out-of-range values on 64-bit hosts.
4268
4269 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4270 These casts should not be needed on 32-bit hosts, either.
4271 * keyboard.c (read_char):
4272 * lread.c (Fload): Remove casts to unsigned.
4273
4274 * lisp.h (UNSIGNED_CMP): New macro.
4275 This fixes comparison bugs on 64-bit hosts.
4276 (ASCII_CHAR_P): Use it.
4277 * casefiddle.c (casify_object):
4278 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4279 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4280 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4281 * dispextern.h (FACE_FROM_ID):
4282 * keyboard.c (read_char): Use UNSIGNED_CMP.
4283
4284 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4285 not to EMACS_INT, to avoid GCC warning.
4286
4287 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4288
4289 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4290 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4291 isn't needed on 32-bit machines.
4292
4293 * buffer.c (Fgenerate_new_buffer_name):
4294 Use EMACS_INT for count, not int.
4295 (advance_to_char_boundary): Return EMACS_INT, not int.
4296
4297 * data.c (Qcompiled_function): Now static.
4298
4299 * window.c (window_body_lines): Now static.
4300
4301 * image.c (gif_load): Rename local to avoid shadowing.
4302
4303 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4304 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4305 * alloc.c (make_save_value): Integer argument is now of type
4306 ptrdiff_t, not int.
4307 (mark_object): Use ptrdiff_t, not int.
4308 * lisp.h (pD): New macro.
4309 * print.c (print_object): Use it.
4310
4311 * alloc.c: Use EMACS_INT, not int, to count objects.
4312 (total_conses, total_markers, total_symbols, total_vector_size)
4313 (total_free_conses, total_free_markers, total_free_symbols)
4314 (total_free_floats, total_floats, total_free_intervals)
4315 (total_intervals, total_strings, total_free_strings):
4316 Now EMACS_INT, not int. All uses changed.
4317 (Fgarbage_collect): Compute overall total using a double, so that
4318 integer overflow is less likely to be a problem. Check for overflow
4319 when converting back to an integer.
4320 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4321 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4322 These were 'int' variables that could overflow on 64-bit hosts;
4323 they were never used, so remove them instead of repairing them.
4324 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4325 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4326 Previously, this ceilinged at INT_MAX, but that doesn't work on
4327 64-bit machines.
4328 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4329
4330 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4331 (allocate_vectorlike): Check for ptrdiff_t overflow.
4332 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4333 when a (possibly-narrower) signed value would do just as well.
4334 We prefer using signed arithmetic, to avoid comparison confusion.
4335
4336 * alloc.c: Catch some string size overflows that we were missing.
4337 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4338 for convenience in STRING_BYTES_MAX.
4339 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4340 The definition here is exact; the one in lisp.h was approximate.
4341 (allocate_string_data): Check for string overflow. This catches
4342 some instances we weren't catching before. Also, it catches
4343 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4344 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4345 and ptrdiff_t and EMACS_INT are both 64 bits.
4346
4347 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4348 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4349 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4350
4351 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4352
4353 * alloc.c (Fmake_string): Check for out-of-range init.
4354
4355 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4356
4357 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4358
4359 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4360
4361 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4362 xg_get_default_scrollbar_width.
4363
4364 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4365 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4366 (style_changed_cb): Call update_theme_scrollbar_width and call
4367 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4368 all frames (Bug#8505).
4369 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4370 Call gtk_window_set_resizable if HAVE_GTK3.
4371 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4372 and height if HAVE_GTK3 (Bug#8505).
4373 (scroll_bar_width_for_theme): New variable.
4374 (update_theme_scrollbar_width): New function.
4375 (xg_get_default_scrollbar_width): Move code to
4376 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4377 (xg_initialize): Call update_theme_scrollbar_width.
4378
4379 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4380
4381 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4382
4383 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4384
4385 * frame.c (make_frame): Call other_buffer_safely instead of
4386 other_buffer.
4387
4388 * window.c (temp_output_buffer_show): Call display_buffer with
4389 second argument Vtemp_buffer_show_specifiers and reset latter
4390 immediately after the call.
4391 (Vtemp_buffer_show_specifiers): New variable.
4392 (auto_window_vscroll_p, next_screen_context_lines)
4393 (Vscroll_preserve_screen_position): Remove leading asterisks from
4394 doc-strings.
4395
4396 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4397
4398 Fix minor problems found by GCC 4.6.0 static checking.
4399 * buffer.c (Qclone_number): Remove for now, as it's unused.
4400 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4401 (record_buffer): Remove unused local.
4402 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4403 (set_frame_buffer_list): Remove; unused.
4404 * frame.h (other_visible_frames): Remove decl.
4405 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4406 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4407 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4408 if HAVE_GPM.
4409 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4410 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4411 Define only if HAVE_GPM.
4412 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4413 (update_hints_inhibit): Remove; never set. All uses removed.
4414 * widgetprv.h (emacsFrameClassRec): Remove decl.
4415 * window.c (delete_deletable_window): Now returns void, since it
4416 wasn't returning anything.
4417 (compare_window_configurations): Remove unused locals.
4418 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4419 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4420 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4421 the same widths as pointers. This follows up on the 2011-05-06 patch.
4422 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4423 * xterm.h: Likewise.
4424 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4425
4426 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4427
4428 * makefile.w32-in: Update dependencies.
4429 (LISP_H): Add lib/intprops.h.
4430
4431 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4432
4433 * image.c (gif_load): Add animation frame delay to the metadata.
4434 (syms_of_image): Use DEFSYM. New symbol `delay'.
4435
4436 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4437
4438 * window.c (delete_deletable_window): Re-add.
4439 (Fset_window_configuration): Rewrite to handle dead buffers and
4440 consequently deletable windows.
4441 (window_tree, Fwindow_tree): Remove. Supply functionality in
4442 window.el.
4443 (compare_window_configurations): Simplify code.
4444
4445 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4446
4447 * image.c (imagemagick_load_image): Fix type mismatch.
4448 (Fimagemagick_types): Likewise.
4449
4450 * window.h (replace_buffer_in_windows): Declare.
4451
4452 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4453
4454 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4455 Qclone_number. Remove external declaration of Qdelete_window.
4456 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4457 code.
4458 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4459 Run Qbuffer_list_update_hook if allowed.
4460 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4461 buffer list implementation.
4462 (other_buffer_safely): New function.
4463 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4464 calls to replace_buffer_in_windows and
4465 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4466 if allowed.
4467 (record_buffer): Inhibit quitting and rewrite using quittable
4468 functions. Run Qbuffer_list_update_hook if allowed.
4469 (Frecord_buffer, Funrecord_buffer): New functions.
4470 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4471 Move switch-to-buffer to window.el.
4472 (bury-buffer): Move to window.el.
4473 (Vbuffer_list_update_hook): New variable.
4474
4475 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4476 section.
4477
4478 * window.h (resize_frame_windows): Move up in code.
4479 (Fwindow_frame): Remove EXFUN.
4480 (replace_buffer_in_all_windows): Remove prototype.
4481 (replace_buffer_in_windows_safely): Add prototype.
4482
4483 * window.c: Declare Qdelete_window static again. Move down
4484 declaration of select_count.
4485 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4486 (Fother_window): Move to window.el.
4487 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4488 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4489 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4490 window.el.
4491 (replace_buffer_in_windows): Implement by calling
4492 Qreplace_buffer_in_windows.
4493 (replace_buffer_in_all_windows): Remove with some functionality
4494 moved into replace_buffer_in_windows_safely.
4495 (replace_buffer_in_windows_safely): New function.
4496 (select_window_norecord, select_frame_norecord): Move in front
4497 of run_window_configuration_change_hook. Remove now obsolete
4498 declarations.
4499 (Fset_window_buffer): Rewrite doc-string.
4500 Call Qrecord_window_buffer.
4501 (keys_of_window): Move binding for other-window to window.el.
4502
4503 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4504
4505 * dispextern.h (struct image): Replace data member, whose int_val
4506 and ptr_val fields were not used by anything, with a single
4507 lisp_val object.
4508
4509 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4510 (gif_clear_image, gif_load, imagemagick_load_image)
4511 (gs_clear_image, gs_load): Callers changed.
4512
4513 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4514
4515 * buffer.h: Include <time.h>, for time_t.
4516 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4517
4518 Fix minor problems found by static checking.
4519
4520 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4521
4522 Make identifiers static if they are not used in other modules.
4523 * data.c (Qcompiled_function, Qframe, Qvector):
4524 * image.c (QimageMagick, Qsvg):
4525 * minibuf.c (Qmetadata):
4526 * window.c (resize_window_check, resize_root_window): Now static.
4527 * window.h (resize_window_check, resize_root_window): Remove decls.
4528
4529 * window.c (window_deletion_count, delete_deletable_window):
4530 Remove; unused.
4531 (window_body_lines): Now static.
4532 (Fdelete_other_windows_internal): Mark vars as initialized.
4533 Make sure 'resize_failed' is initialized.
4534 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4535 (resize_window_apply): Remove unused local.
4536 * window.h (delete_deletable_window): Remove decl.
4537
4538 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4539 (imagemagick_load_image): Fix pointer signedness problem by changing
4540 last arg from unsigned char * to char *. All uses changed.
4541 Also, fix a local for similar reasons.
4542 Remove unused locals. Remove locals to avoid shadowing.
4543 (fn_rsvg_handle_free): Remove; unused.
4544 (svg_load, svg_load_image): Fix pointer signedness problem.
4545 (imagemagick_load_image): Don't use garbage pointer image_wand.
4546
4547 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4548
4549 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4550
4551 * image.c (gif_load): Fix omitted cast error introduced by
4552 2011-06-06 change.
4553
4554 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4555
4556 * window.h (resize_proportionally, orig_total_lines)
4557 (orig_top_line): Remove from window structure.
4558 (set_window_height, set_window_width, change_window_heights)
4559 (Fdelete_window): Remove prototypes.
4560 (resize_frame_windows): Remove duplicate declaration.
4561
4562 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4563
4564 * window.h (resize_frame_windows, resize_window_check)
4565 (delete_deletable_window, resize_root_window)
4566 (resize_frame_windows): Declare prototypes.
4567
4568 * window.c (resize_window_apply): Make definition be "static" to
4569 match the prototype.
4570
4571 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4572
4573 * window.c: Remove declarations of Qwindow_size_fixed,
4574 window_min_size_1, window_min_size_2, window_min_size,
4575 size_window, window_fixed_size_p, enlarge_window, delete_window.
4576 Remove static from declaration of Qdelete_window, it's
4577 temporarily needed by Fbury_buffer.
4578 (replace_window): Don't assign orig_top_line and
4579 orig_total_lines.
4580 (Fdelete_window, delete_window): Remove. Window deletion is
4581 handled by window.el.
4582 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4583 Replace Fdelete_window calls with calls to Qdelete_window.
4584 (Fdelete_other_windows): Remove. Deleting other windows is
4585 handled by window.el.
4586 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4587 handled in window.el.
4588 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4589 Window minimum sizes are handled in window.el.
4590 (shrink_windows, size_window, set_window_height)
4591 (set_window_width, change_window_heights, window_height)
4592 (window_width, CURBEG, CURSIZE, enlarge_window)
4593 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4594 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4595 handled in window.el.
4596 (make_dummy_parent): Rename to make_parent_window and give it a
4597 second argument horflag.
4598 (make_window): Don't set resize_proportionally any more.
4599 (Fsplit_window): Remove. Windows are split in window.el.
4600 (save_restore_action, save_restore_orig_size)
4601 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4602 Resize mini windows in window.el.
4603 (grow_mini_window, shrink_mini_window): Implement by calling
4604 Qresize_root_window_vertically, resize_window_check and
4605 resize_window_apply.
4606 (saved_window, Fset_window_configuration, save_window_save):
4607 Do not handle orig_top_line, orig_total_lines, and
4608 resize_proportionally.
4609 (window_min_height, window_min_width): Move to window.el.
4610 (keys_of_window): Move bindings for delete-other-windows,
4611 split-window, delete-window and enlarge-window to window.el.
4612
4613 * buffer.c: Temporarily extern Qdelete_window.
4614 (Fbury_buffer): Temporarily call Qdelete_window instead of
4615 Fdelete_window (Fbury_buffer will move to window.el soon).
4616
4617 * frame.c (set_menu_bar_lines_1): Remove code handling
4618 orig_top_line and orig_total_lines.
4619
4620 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4621 set_window_height but set heights directly.
4622 (change_frame_size_1): Use resize_frame_windows.
4623
4624 * xdisp.c (init_xdisp): Don't use set_window_height but set
4625 heights directly.
4626
4627 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4628 Use resize_frame_windows instead of change_window_heights and run
4629 run_window_configuration_change_hook.
4630
4631 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4632 instead of change_window_heights and run
4633 run_window_configuration_change_hook.
4634
4635 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4636
4637 * window.c (replace_window): Rename second argument REPLACEMENT to
4638 NEW. New third argument SETFLAG. Rewrite.
4639 (delete_window, make_dummy_parent): Call replace_window with
4640 third argument 1.
4641 (window_list_1): Move down in code.
4642 (run_window_configuration_change_hook): Move set_buffer part
4643 before select_frame_norecord part in order to unwind correctly.
4644 Rename count1 to count.
4645 (recombine_windows, delete_deletable_window, resize_root_window)
4646 (Fdelete_other_windows_internal)
4647 (Frun_window_configuration_change_hook, make_parent_window)
4648 (resize_window_check, resize_window_apply, Fresize_window_apply)
4649 (resize_frame_windows, Fsplit_window_internal)
4650 (Fdelete_window_internal, Fresize_mini_window_internal):
4651 New functions.
4652 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4653
4654 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4655
4656 * window.h (window): Add some new members to window structure -
4657 normal_lines, normal_cols, new_total, new_normal, clone_number,
4658 splits, nest, prev_buffers, next_buffers.
4659 (WINDOW_TOTAL_SIZE): Move here from window.c.
4660 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4661
4662 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4663 Remove.
4664 (make_dummy_parent): Set new members of windows structure.
4665 (make_window): Move down in code. Handle new members of window
4666 structure.
4667 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4668 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4669 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4670 (Fset_window_prev_buffers, Fwindow_next_buffers)
4671 (Fset_window_next_buffers, Fset_window_clone_number):
4672 New functions.
4673 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4674 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4675 Doc-string fixes.
4676 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4677 Argument WINDOW can be now internal window too.
4678 (Fwindow_use_time): Move up in code.
4679 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4680 Rewrite doc-string.
4681 (Fset_window_configuration, saved_window)
4682 (Fcurrent_window_configuration, save_window_save): Handle new
4683 members of window structure.
4684 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4685 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4686 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4687 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4688 Qget_mru_window, Qresize_root_window,
4689 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4690 Qauto_buffer_name; staticpro them.
4691
4692 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4693
4694 * window.c (Fwindow_total_size, Fwindow_left_column)
4695 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4696 (Fwindow_list_1): New functions.
4697 (window_box_text_cols): Replace with window_body_cols.
4698 (Fwindow_width, Fscroll_left, Fscroll_right):
4699 Use window_body_cols instead of window_box_text_cols.
4700 (delete_window, Fset_window_configuration):
4701 Call delete_all_subwindows with window as argument.
4702 (delete_all_subwindows): Take a window as argument and not a
4703 structure. Rewrite.
4704 (window_loop): Remove handling of GET_LRU_WINDOW and
4705 GET_LARGEST_WINDOW.
4706 (Fget_lru_window, Fget_largest_window): Move to window.el.
4707
4708 * window.h: Extern window_body_cols instead of
4709 window_box_text_cols. delete_all_subwindows now takes a
4710 Lisp_Object as argument.
4711
4712 * indent.c (compute_motion, Fcompute_motion):
4713 Use window_body_cols instead of window_box_text_cols.
4714
4715 * frame.c (delete_frame): Call delete_all_subwindows with root
4716 window as argument.
4717
4718 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4719
4720 * fns.c (Fputhash): Document return value.
4721
4722 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4723
4724 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4725
4726 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4727
4728 Cons<->int and similar integer overflow fixes (Bug#8794).
4729
4730 Check for overflow when converting integer to cons and back.
4731 * charset.c (Fdefine_charset_internal, Fdecode_char):
4732 Use cons_to_unsigned to catch overflow.
4733 (Fencode_char): Use INTEGER_TO_CONS.
4734 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4735 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4736 * data.c (long_to_cons, cons_to_long): Remove.
4737 (cons_to_unsigned, cons_to_signed): New functions.
4738 These signal an error for invalid or out-of-range values.
4739 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4740 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4741 * font.c (Ffont_variation_glyphs):
4742 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4743 * lisp.h: Include <intprops.h>.
4744 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4745 (cons_to_signed, cons_to_unsigned): New decls.
4746 (long_to_cons, cons_to_long): Remove decls.
4747 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4748 (Fprimitive_undo): Use CONS_TO_INTEGER.
4749 * xfns.c (Fx_window_property): Likewise.
4750 * xselect.c: Include <limits.h>.
4751 (x_own_selection, selection_data_to_lisp_data):
4752 Use INTEGER_TO_CONS.
4753 (x_handle_selection_request, x_handle_selection_clear)
4754 (x_get_foreign_selection, Fx_disown_selection_internal)
4755 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4756 (lisp_data_to_selection_data): Use cons_to_unsigned.
4757 (x_fill_property_data): Use cons_to_signed.
4758 Report values out of range.
4759
4760 Check for buffer and string overflow more precisely.
4761 * buffer.h (BUF_BYTES_MAX): New macro.
4762 * lisp.h (STRING_BYTES_MAX): New macro.
4763 * alloc.c (Fmake_string):
4764 * character.c (string_escape_byte8):
4765 * coding.c (coding_alloc_by_realloc):
4766 * doprnt.c (doprnt):
4767 * editfns.c (Fformat):
4768 * eval.c (verror):
4769 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4770 since they may not be the same number.
4771 * editfns.c (Finsert_char):
4772 * fileio.c (Finsert_file_contents):
4773 Likewise for BUF_BYTES_MAX.
4774
4775 * image.c: Use ptrdiff_t, not int, for sizes.
4776 (slurp_file): Switch from int to ptrdiff_t.
4777 All uses changed.
4778 (slurp_file): Check that file size fits in both size_t (for
4779 malloc) and ptrdiff_t (for sanity and safety).
4780
4781 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4782 if b->modtime has its maximal value.
4783
4784 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4785
4786 Don't assume time_t can fit into int.
4787 * buffer.h (struct buffer.modtime): Now time_t, not int.
4788 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4789 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4790
4791 Minor fixes for signed vs unsigned integers.
4792 * character.h (MAYBE_UNIFY_CHAR):
4793 * charset.c (maybe_unify_char):
4794 * keyboard.c (read_char, reorder_modifiers):
4795 XINT -> XFASTINT, since the integer must be nonnegative.
4796 * ftfont.c (ftfont_spec_pattern):
4797 * keymap.c (access_keymap, silly_event_symbol_error):
4798 XUINT -> XFASTINT, since the integer must be nonnegative.
4799 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4800 since it makes no difference and we prefer signed.
4801 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4802 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4803 nonnegative.
4804
4805 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4806
4807 * window.h (Fwindow_frame): Declare.
4808
4809 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4810
4811 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4812 (SPARE_MEMORY): Always define.
4813 (LARGE_REQUEST): Remove.
4814 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4815
4816 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4817
4818 * lisp.h: Move EXFUNS for Fframe_root_window,
4819 Fframe_first_window and Fset_frame_selected_window to window.h.
4820
4821 * window.h: Move EXFUNS for Fframe_root_window,
4822 Fframe_first_window and Fset_frame_selected_window here from
4823 lisp.h.
4824
4825 * frame.c (Fwindow_frame, Fframe_first_window)
4826 (Fframe_root_window, Fframe_selected_window)
4827 (Fset_frame_selected_window): Move to window.c.
4828 (Factive_minibuffer_window): Move to minibuf.c.
4829 (Fother_visible_frames_p): New function.
4830
4831 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4832
4833 * window.c (decode_window, decode_any_window): Move up in code.
4834 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4835 (inhibit_frame_unsplittable): Remove unused variable.
4836 (Fwindow_buffer): Move up and rewrite doc-string.
4837 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4838 (Fwindow_prev): New functions.
4839 (Fwindow_frame): Move here from frame.c. Accept any window as
4840 argument.
4841 (Fframe_root_window, Fframe_first_window)
4842 (Fframe_selected_window): Move here from frame.c. Accept frame
4843 or arbitrary window as argument. Update doc-strings.
4844 (Fminibuffer_window): Move up in code.
4845 (Fwindow_minibuffer_p): Move up in code and simplify.
4846 (Fset_frame_selected_window): Move here from frame.c.
4847 Marginal rewrite.
4848 (Fselected_window, select_window, Fselect_window): Move up in
4849 code. Minor doc-string fixes.
4850
4851 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4852
4853 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4854 Do not assume that spare memory exists; that assumption is valid
4855 only if SYSTEM_MALLOC.
4856 (LARGE_REQUEST): New macro, so that the issue of large requests
4857 is separated from the issue of spare memory.
4858
4859 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4860
4861 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4862 format. (Bug#8806)
4863
4864 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4865
4866 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4867 before statements.
4868
4869 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4870
4871 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4872
4873 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4874
4875 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4876 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4877
4878 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4879
4880 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4881
4882 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4883
4884 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4885 (x_clipboard_manager_save): Add return value.
4886 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4887 New error handlers.
4888 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4889 Obey Vx_select_enable_clipboard_manager. Catch errors in
4890 x_clipboard_manager_save (Bug#8779).
4891 (Vx_select_enable_clipboard_manager): New variable.
4892 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4893
4894 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4895
4896 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4897
4898 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4899
4900 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4901 in the current matrix if keep_current_p is non-zero.
4902
4903 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4904
4905 * bidi.c (bidi_level_of_next_char): Fix last change.
4906
4907 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4908
4909 Support bidi reordering of text covered by display properties.
4910
4911 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4912 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4913 (bidi_cache_search, bidi_cache_iterator_state)
4914 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4915 (bidi_level_of_next_char, bidi_move_to_visually_next):
4916 Support character positions inside a run of characters covered by a
4917 display string.
4918 (bidi_paragraph_init, bidi_resolve_explicit_1)
4919 (bidi_level_of_next_char): Call bidi_fetch_char and
4920 bidi_fetch_char_advance instead of FETCH_CHAR and
4921 FETCH_CHAR_ADVANCE.
4922 (bidi_init_it): Initialize new members.
4923 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4924 definitions.
4925 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4926 instead of using explicit *_CHAR codes.
4927 (bidi_resolve_explicit, bidi_resolve_weak):
4928 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4929 bidirectional text is supported only in multibyte buffers.
4930 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4931 it to initialize the frame_window_p member of struct bidi_it.
4932 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4933 (bidi_resolve_explicit, bidi_resolve_weak)
4934 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4935 bidi_it->nchars is non-positive.
4936 (bidi_level_of_next_char): Don't try to lookup the cache for the
4937 next/previous character if nothing is cached there yet, or if we
4938 were just reseat()'ed to a new position.
4939
4940 * xdisp.c (set_cursor_from_row): Set start and stop points
4941 according to the row's direction when priming the loop that looks
4942 for the glyph on which to display cursor.
4943 (single_display_spec_intangible_p): Function deleted.
4944 (display_prop_intangible_p): Reimplement to call
4945 handle_display_spec instead of single_display_spec_intangible_p.
4946 Accept 3 additional arguments needed by handle_display_spec.
4947 This fixes incorrect cursor motion across display property with complex
4948 values: lists, `(when COND...)' forms, etc.
4949 (single_display_spec_string_p): Support property values that are
4950 lists with the argument STRING its top-level element.
4951 (display_prop_string_p): Fix the condition for processing a
4952 property that is a list to be consistent with handle_display_spec.
4953 (handle_display_spec): New function, refactored from the
4954 last portion of handle_display_prop.
4955 (compute_display_string_pos): Accept additional argument
4956 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4957 value of a `display' property is a "replacing spec".
4958 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4959 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4960 the display property, but just return a value indicating whether
4961 the display property will replace the characters it covers.
4962 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4963 frame_window_p members of struct bidi_it.
4964 (compute_display_string_pos, compute_display_string_end):
4965 New functions.
4966 (push_it): Accept second argument POSITION, where pop_it should
4967 jump to continue iteration.
4968 (reseat_1): Initialize bidi_it.disp_pos.
4969
4970 * keyboard.c (adjust_point_for_property): Adjust the call to
4971 display_prop_intangible_p to its new signature.
4972
4973 * dispextern.h (struct bidi_it): New member frame_window_p.
4974 (bidi_init_it): Update prototypes.
4975 (display_prop_intangible_p): Update prototype.
4976 (compute_display_string_pos, compute_display_string_end):
4977 Declare prototypes.
4978 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4979 EMACS_INT.
4980
4981 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4982
4983 Malloc failure behavior now depends on size of allocation.
4984 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4985 * lisp.h: Change signatures accordingly.
4986 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4987 All callers changed. (Bug#8762)
4988
4989 * gnutls.c: Use Emacs's memory allocators.
4990 Without this change, the gnutls library would invoke malloc etc.
4991 directly, which causes problems on non-SYNC_INPUT hosts, and which
4992 runs afoul of improving memory_full behavior. (Bug#8761)
4993 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4994 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4995 xfree instead of the default malloc, realloc, free.
4996 (Fgnutls_boot): No need to check for memory allocation failure,
4997 since xmalloc does that for us.
4998
4999 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5000 * category.c (hash_get_category_set):
5001 * ccl.c (ccl_driver):
5002 * charset.c (Fdefine_charset_internal):
5003 * charset.h (struct charset.hash_index):
5004 * composite.c (get_composition_id, gstring_lookup_cache)
5005 (composition_gstring_put_cache):
5006 * composite.h (struct composition.hash_index):
5007 * dispextern.h (struct image.hash):
5008 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5009 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5010 (hashfn_equal, hashfn_user_defined, make_hash_table)
5011 (maybe_resize_hash_table, hash_lookup, hash_put)
5012 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5013 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5014 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5015 * image.c (make_image, search_image_cache, lookup_image)
5016 (xpm_put_color_table_h):
5017 * lisp.h (struct Lisp_Hash_Table):
5018 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5019 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5020 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5021 * alloc.c (allocate_vectorlike):
5022 Check for overflow in vector size calculations.
5023 * ccl.c (ccl_driver):
5024 Check for overflow when converting EMACS_INT to int.
5025 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5026 need to be updated by these changes.
5027 * fns.c (make_hash_table, maybe_resize_hash_table):
5028 Check for integer overflow with large hash tables.
5029 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5030 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5031 (SXHASH_REDUCE): New macro.
5032 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5033 Use it instead of discarding useful hash info with large hash values.
5034 (sxhash_float): New function.
5035 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5036 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5037 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5038 Rewrite to use FIXNUM_BITS, as this simplifies things.
5039 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5040 Adjust signatures to match updated version of code.
5041 (consing_since_gc): Now EMACS_INT, since a single hash table can
5042 use more than INT_MAX bytes.
5043
5044 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5045
5046 Make it possible to build with GCC-4.6+ -O2 -flto.
5047
5048 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5049
5050 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5051
5052 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5053 Call minibuffer-inactive-mode.
5054
5055 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5056
5057 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5058 Update dependencies.
5059
5060 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5061
5062 * data.c (init_data): Remove code for UTS, this system is not
5063 supported anymore.
5064
5065 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5066
5067 Don't force ./temacs to start in terminal mode.
5068
5069 * frame.c (make_initial_frame): Initialize faces in all cases, not
5070 only when CANNOT_DUMP is defined.
5071 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5072
5073 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5074
5075 * dispnew.c (add_window_display_history): Use const for the string
5076 pointer. Remove declaration, not needed.
5077
5078 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5079
5080 Use 'inline', not 'INLINE'.
5081 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5082 * alloc.c, fontset.c (INLINE): Remove.
5083 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5084 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5085 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5086 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5087 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5088
5089 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5090
5091 Make it possible to run ./temacs.
5092
5093 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5094 syms_of_callproc does the same thing. Remove test for
5095 "initialized", do it in the caller.
5096 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5097
5098 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5099
5100 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5101 (read_minibuf): Use get_minibuffer.
5102 (syms_of_minibuf): Use DEFSYM.
5103 (Qmetadata): New var.
5104 * data.c (Qbuffer): Don't make it static.
5105 (syms_of_data): Use DEFSYM.
5106
5107 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5108
5109 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5110 (CCL_CODE_MIN): New macro.
5111
5112 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5113
5114 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5115
5116 * eval.c (Qdebug): Now static.
5117 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5118 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5119 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5120
5121 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5122
5123 * image.c: Various fixes to ImageMagick code comments.
5124 (Fimagemagick_types): Doc fix.
5125
5126 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5127
5128 Minor fixes prompted by GCC 4.6.0 warnings.
5129
5130 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5131
5132 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5133 (x_clipboard_manager_save_all): Move extern decl to ...
5134 * xterm.h: ... here, so that it can be checked for consistency.
5135
5136 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5137
5138 * xselect.c (x_clipboard_manager_save_frame)
5139 (x_clipboard_manager_save_all): New functions.
5140 (Fx_clipboard_manager_save): Lisp function deleted.
5141
5142 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5143 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5144
5145 * xterm.h: Update prototype.
5146
5147 2011-05-28 William Xu <william.xwl@gmail.com>
5148
5149 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5150 exiting (Bug#8239).
5151
5152 2011-05-28 Jim Meyering <meyering@redhat.com>
5153
5154 Avoid a sign-extension bug in crypto_hash_function.
5155 * fns.c (to_uchar): Define.
5156 (crypto_hash_function): Use it to convert some newly-signed
5157 variables to unsigned, to avoid sign-extension bugs. For example,
5158 without this change, (md5 "truc") would evaluate to
5159 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5160 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5161 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5162
5163 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5164
5165 Integer overflow fixes.
5166
5167 * dbusbind.c: Serial number integer overflow fixes.
5168 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5169 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5170 to hold a serial number that is too large for a fixnum.
5171 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5172 Check for serial numbers out of range. Decode any serial number
5173 that was so large that it became a float. (Bug#8722)
5174
5175 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5176 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5177 Use XFASTINT rather than XUINT when numbers are nonnegative.
5178 (xd_append_arg, Fdbus_method_return_internal):
5179 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5180 arguments, check that Lisp number is nonnegative, rather than
5181 silently wrapping negative numbers around. (Bug#8722)
5182 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5183 (Bug#8722)
5184
5185 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5186
5187 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5188
5189 ccl: add integer overflow checks
5190 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5191 (IN_INT_RANGE): New macros.
5192 (ccl_driver): Use them to check for integer overflow when
5193 decoding a CCL program. Many of the new checks are whether XINT (x)
5194 fits in int; it doesn't always, on 64-bit hosts. The new version
5195 doesn't catch all possible integer overflows, but it's an
5196 improvement. (Bug#8719)
5197
5198 * alloc.c (make_event_array): Use XINT, not XUINT.
5199 There's no need for unsigned here.
5200
5201 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5202 This follows up to the 2011-05-06 change that substituted uintptr_t
5203 for EMACS_INT. This case wasn't caught back then.
5204
5205 Rework Fformat to avoid integer overflow issues.
5206 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5207 now (part of C89). Include <verify.h>.
5208 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5209 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5210 (Fformat): Avoid the prepass trying to compute sizes; it was only
5211 approximate and thus did not catch overflow reliably. Instead, walk
5212 through the format just once, formatting and computing sizes as we go,
5213 checking for integer overflow at every step, and allocating a larger
5214 buffer as needed. Keep track separately whether the format is
5215 multibyte. Keep only the most-recently calculated precision, rather
5216 than them all. Record whether each argument has been converted to
5217 string. Use EMACS_INT, not int, for byte and char and arg counts.
5218 Support field widths and precisions larger than INT_MAX. Avoid
5219 sprintf's undefined behavior with conversion specifications such as %#d
5220 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5221 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5222 formatting out-of-range floating point numbers with int
5223 formats. (Bug#8668)
5224
5225 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5226
5227 * data.c: Avoid integer truncation in expressions involving floats.
5228 * data.c: Include <intprops.h>.
5229 (arith_driver): When there's an integer overflow in an expression
5230 involving floating point, convert the integers to floating point
5231 so that the resulting value does not suffer from catastrophic
5232 integer truncation. For example, on a 64-bit host (* 4
5233 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5234 Do not rely on undefined behavior after integer overflow.
5235
5236 merge count_size_as_multibyte, parse_str_to_multibyte
5237 * character.c, character.h (count_size_as_multibyte):
5238 Rename from parse_str_to_multibyte; all uses changed.
5239 Check for integer overflow.
5240 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5241 since it's now a duplicate of the other. This is more of
5242 a character than a buffer op, so better that it's in character.c.
5243 * fns.c, print.c: Adjust to above changes.
5244
5245 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5246
5247 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5248
5249 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5250
5251 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5252 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5253 (x_clipboard_manager_save): Now static.
5254 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5255
5256 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5257 (crypto_hash_function): Now static.
5258 Fix pointer signedness problems. Avoid unnecessary initializations.
5259
5260 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5261
5262 * termhooks.h (Vselection_alist): Make it terminal-local.
5263
5264 * terminal.c (create_terminal): Initialize it.
5265
5266 * xselect.c: Support for clipboard managers.
5267 (Vselection_alist): Move to termhooks.h as terminal-local var.
5268 (LOCAL_SELECTION): New macro.
5269 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5270 (symbol_to_x_atom): Remove gratuitous arg.
5271 (x_handle_selection_request, lisp_data_to_selection_data)
5272 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5273 (x_own_selection, x_get_local_selection, x_convert_selection):
5274 New arg, specifying work frame. Use terminal-local Vselection_alist.
5275 (some_frame_on_display): Delete unused function.
5276 (Fx_own_selection_internal, Fx_get_selection_internal)
5277 (Fx_disown_selection_internal, Fx_selection_owner_p)
5278 (Fx_selection_exists_p): New optional frame arg.
5279 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5280 (x_handle_selection_clear): Don't treat other terminals with the
5281 same keyboard specially. Use the terminal-local Vselection_alist.
5282 (x_clear_frame_selections): Use Frun_hook_with_args.
5283
5284 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5285
5286 * xterm.h: Add support for those atoms.
5287
5288 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5289
5290 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5291 (converted_selections, conversion_fail_tag): New global variables.
5292 (x_selection_request_lisp_error): Free the above.
5293 (x_get_local_selection): Remove unnecessary code.
5294 (x_reply_selection_request): Args changed; handle arbitrary array
5295 of converted selections stored in converted_selections.
5296 Separate the XChangeProperty and SelectionNotify steps.
5297 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5298 (x_convert_selection): New function.
5299 (x_handle_selection_event): Simplify.
5300 (x_get_foreign_selection): Don't ignore incoming requests while
5301 waiting for an answer; this will fail when we implement
5302 SAVE_TARGETS, and seems unnecessary anyway.
5303 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5304 (Vx_sent_selection_functions): Doc fix.
5305
5306 2011-05-26 Leo Liu <sdl.web@gmail.com>
5307
5308 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5309
5310 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5311
5312 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5313
5314 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5315 for fringe update if it has periodic bitmap.
5316 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5317 and fringe_bitmap_periodic_p.
5318
5319 * fringe.c (get_fringe_bitmap_data): New function.
5320 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5321 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5322 row. Mark glyph row for fringe update if periodicity changed.
5323
5324 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5325 for fringe update unless it has periodic bitmap.
5326
5327 2011-05-25 Kenichi Handa <handa@m17n.org>
5328
5329 * xdisp.c (get_next_display_element): Set correct it->face_id for
5330 a static composition.
5331
5332 2011-05-24 Leo Liu <sdl.web@gmail.com>
5333
5334 * deps.mk (fns.o):
5335 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5336
5337 * fns.c (crypto_hash_function, Fsha1): New function.
5338 (Fmd5): Use crypto_hash_function.
5339 (syms_of_fns): Add Ssha1.
5340
5341 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5342
5343 * gnutls.c: Remove unused macros.
5344 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5345 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5346 Remove macros that are defined and never used.
5347 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5348
5349 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5350
5351 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5352 (Fx_get_selection_internal): Minor cleanup.
5353 (Fx_own_selection_internal): Rename arguments for consistency with
5354 select.el.
5355
5356 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5357
5358 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5359
5360 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5361
5362 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5363
5364 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5365
5366 * dispnew.c (scrolling_window): Don't exclude the case that the
5367 last enabled row in the desired matrix touches the bottom boundary.
5368
5369 2011-05-21 Glenn Morris <rgm@gnu.org>
5370
5371 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5372 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5373 and add some more files.
5374
5375 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5376
5377 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5378 report_file_error introduced by the change from 2011-05-07.
5379
5380 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5381
5382 * systime.h (Time): Define only if emacs is defined.
5383 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5384 where the include path doesn't have X11/X.h by default. See
5385 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5386
5387 2011-05-20 Kenichi Handa <handa@m17n.org>
5388
5389 * composite.c (find_automatic_composition): Fix previous change.
5390
5391 2011-05-20 Glenn Morris <rgm@gnu.org>
5392
5393 * lisp.mk: New file, split from Makefile.in.
5394 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5395 (shortlisp): Remove.
5396 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5397
5398 2011-05-19 Glenn Morris <rgm@gnu.org>
5399
5400 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5401 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5402 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5403 (lisp): Set the order to that of loadup.el.
5404 (shortlisp): Make it a copy of $lisp.
5405 (SOME_MACHINE_LISP): Remove.
5406 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5407 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5408
5409 2011-05-18 Kenichi Handa <handa@m17n.org>
5410
5411 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5412 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5413 (find_automatic_composition): Mostly rewrite for efficiency.
5414
5415 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5416
5417 * makefile.w32-in: Update dependencies.
5418
5419 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5420
5421 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5422 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5423
5424 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5425
5426 Fix some integer overflow issues, such as string length overflow.
5427
5428 * insdel.c (count_size_as_multibyte): Check for string overflow.
5429
5430 * character.c (lisp_string_width): Check for string overflow.
5431 Use EMACS_INT, not int, for string indexes and lengths; in
5432 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5433 the resulting string length overflows an EMACS_INT; instead,
5434 report a string overflow if no precision given. When checking for
5435 precision exhaustion, use a check that cannot possibly have
5436 integer overflow. (Bug#8675)
5437 * character.h (lisp_string_width): Adjust to new signature.
5438
5439 * alloc.c (string_overflow): New function.
5440 (Fmake_string): Use it. This doesn't change behavior, but saves
5441 a few bytes and will simplify future changes.
5442 * character.c (string_escape_byte8): Likewise.
5443 * lisp.h (string_overflow): New decl.
5444
5445 Fixups, following up to the user-interface timestamp change.
5446 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5447 for UI timestamps, instead of unsigned long.
5448 * msdos.c (mouse_get_pos): Likewise.
5449 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5450 * w32gui.h (Time): Define by including "systime.h" rather than by
5451 declaring it ourselves. (Bug#8664)
5452
5453 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5454 * image.c (clear_image_cache): Likewise.
5455
5456 * term.c (term_mouse_position): Don't assume time_t wraparound.
5457
5458 Be more systematic about user-interface timestamps.
5459 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5460 and sometimes 'EMACS_UINT', to represent these timestamps.
5461 This change causes it to use 'Time' uniformly, as that's what X uses.
5462 This makes the code easier to follow, and makes it easier to catch
5463 integer overflow bugs such as Bug#8664.
5464 * frame.c (Fmouse_position, Fmouse_pixel_position):
5465 Use Time, not unsigned long, for user-interface timestamps.
5466 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5467 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5468 * keyboard.h (last_event_timestamp): Likewise.
5469 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5470 * menu.h (xmenu_show): Likewise.
5471 * term.c (term_mouse_position): Likewise.
5472 * termhooks.h (struct input_event.timestamp): Likewise.
5473 (struct terminal.mouse_position_hook): Likewise.
5474 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5475 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5476 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5477 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5478 what it was before.
5479 * menu.h, termhooks.h: Include "systime.h", for Time.
5480
5481 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5482 Don't assume that the difference between two unsigned long values
5483 can fit into an integer. At this point, we know button_down_time
5484 <= event->timestamp, so the difference must be nonnegative, so
5485 there's no need to cast the result if double-click-time is
5486 nonnegative, as it should be; check that it's nonnegative, just in
5487 case. This bug is triggered when events are more than 2**31 ms
5488 apart (about 25 days). (Bug#8664)
5489
5490 * xselect.c (last_event_timestamp): Remove duplicate decl.
5491 (x_own_selection): Remove needless cast to unsigned long.
5492
5493 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5494 that always fit in int. Use a sentinel instead of a counter, to
5495 avoid a temp and to allay GCC's concerns about possible int overflow.
5496 * frame.h (struct frame): Use int for menu_bar_items_used
5497 instead of EMACS_INT, since it always fits in int.
5498
5499 * menu.c (grow_menu_items): Check for int overflow.
5500
5501 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5502
5503 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5504 Before, the code was not consistent. These values cannot exceed
5505 2**31 - 1 so there's no need to make them unsigned.
5506 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5507 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5508 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5509 as modifiers.
5510 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5511
5512 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5513 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5514 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5515 presumably because the widths might not match.
5516
5517 * window.c (size_window): Avoid needless test at loop start.
5518
5519 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5520
5521 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5522
5523 2011-05-12 Drew Adams <drew.adams@oracle.com>
5524
5525 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5526
5527 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5528
5529 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5530 `width' to `bar_area_x' and `bar_area_width', respectively.
5531 (x_scroll_run): Take account of fringe background extension.
5532
5533 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5534 Rename local vars `left' and `width' to `bar_area_x' and
5535 `bar_area_width', respectively.
5536 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5537 background extension.
5538
5539 2011-05-10 Jim Meyering <meyering@redhat.com>
5540
5541 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5542
5543 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5544
5545 * image.c (Finit_image_library): Return t for built-in image types,
5546 like pbm and xbm. (Bug#8640)
5547
5548 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5549
5550 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5551
5552 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5553
5554 * w32console.c (Fset_screen_color): Doc fix.
5555 (Fget_screen_color): New function.
5556 (syms_of_ntterm): Defsubr it.
5557
5558 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5559 unlink the temporary file if Fcall_process didn't create it in the
5560 first place.
5561 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5562 child process will be redirected to a file specified with `:file'.
5563 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5564 cue to call_process_cleanup not to close that handle.
5565
5566 2011-05-07 Ben Key <bkey76@gmail.com>
5567
5568 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5569 one of two shell specific rules, either bootstrap-temacs-CMD or
5570 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5571 to the previous implementation of the bootstrap-temacs rule.
5572 The bootstrap-temacs-CMD rule is similar to the previous
5573 implementation of the bootstrap-temacs rule except that it
5574 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5575 variable.
5576
5577 These changes, along with some changes to nt/configure.bat,
5578 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5579 earlier fix to add support for --cflags and --ldflags options
5580 that include quotes so that it works whether make uses cmd or
5581 sh as the shell.
5582
5583 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5584
5585 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5586 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5587 is a constant.
5588 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5589 a string. Handle both cases.
5590 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5591 (Fdbus_register_method): Use Qinvalid_function.
5592
5593 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5594
5595 * makefile.w32-in: Update dependencies.
5596 (LISP_H): Add inttypes.h and stdin.h.
5597 (PROCESS_H): Add unistd.h.
5598
5599 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5600
5601 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5602 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5603
5604 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5605
5606 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5607
5608 * term.c (vfatal): Remove stray call to va_end.
5609 It's not needed and the C Standard doesn't allow it here anyway.
5610
5611 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5612 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5613
5614 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5615 bytes.
5616
5617 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5618
5619 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5620
5621 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5622
5623 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5624
5625 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5626
5627 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5628 * charset.c (Fdefine_charset_internal): Don't initialize
5629 charset.code_space[15]. The value was garbage, on hosts with
5630 32-bit int (Bug#8600).
5631
5632 * lread.c (read_integer): Be more consistent with string-to-number.
5633 Use string_to_number to do the actual conversion; this avoids
5634 rounding errors and fixes some other screwups. Without this fix,
5635 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5636 (digit_to_number): Move earlier, for benefit of read_integer.
5637 Return -1 if the digit is out of range for the base, -2 if it is
5638 not a digit in any supported base. (Bug#8602)
5639
5640 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5641
5642 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5643 to match comment at start of function. This also removes a
5644 GCC warning about overflow in a 32+64-bit port.
5645
5646 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5647
5648 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5649 Reported by Stefan Monnier in
5650 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5651 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5652 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5653
5654 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5655 (EMACS_UINTPTR): Likewise, with uintptr_t.
5656
5657 * lisp.h: Prefer 64-bit EMACS_INT if available.
5658 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5659 on 32-bit hosts that have 64-bit int, so that they can access
5660 large files.
5661 However, temporarily disable this change unless the temporary
5662 symbol WIDE_EMACS_INT is defined.
5663
5664 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5665
5666 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5667 This removes an assumption that EMACS_INT and long are the same
5668 width as pointers. The assumption is true for Emacs porting targets
5669 now, but we want to make other targets possible.
5670 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5671 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5672 In the rest of the code, change types of integers that hold casted
5673 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5674 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5675 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5676 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5677 No need to cast type when ORing.
5678 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5679 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5680 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5681 assume EMACS_INT is the same width as char *.
5682 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5683 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5684 Remove no-longer-needed casts.
5685 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5686 (xg_tool_bar_help_callback, xg_make_tool_item):
5687 Use EMACS_INTPTR to hold an integer
5688 that will be cast to void *; this can avoid a GCC warning
5689 if EMACS_INT is not the same width as void *.
5690 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5691 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5692 (current_message_1, set_message_1):
5693 Use a local to convert to proper width without a cast.
5694 * xmenu.c (dialog_selection_callback): Likewise.
5695
5696 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5697 Also, don't assume VALBITS / RAND_BITS is less than 5,
5698 and don't rely on undefined behavior when shifting a 1 left into
5699 the sign bit.
5700 * lisp.h (get_random): Change signature to match.
5701
5702 * lread.c (hash_string): Use size_t, not int, for hash computation.
5703 Normally we prefer signed values; but hashing is special, because
5704 it's better to use unsigned division on hash table sizes so that
5705 the remainder is nonnegative. Also, size_t is the natural width
5706 for hashing into memory. The previous code used 'int', which doesn't
5707 retain enough info to hash well into very large tables.
5708 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5709
5710 * dbusbind.c: Don't possibly lose pointer info when converting.
5711 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5712 Use XPNTR rather than XHASH, so that the high-order bits of
5713 the pointer aren't lost when converting through void *.
5714
5715 * eval.c (Fautoload): Don't double-shift a pointer.
5716
5717 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5718
5719 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5720
5721 * gnutls.c (DEF_GNUTLS_FN):
5722 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5723
5724 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5725
5726 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5727 marker. (Bug#8610)
5728
5729 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5730
5731 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5732 New version that can reserve upto 2GB of heap space.
5733
5734 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5735
5736 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5737
5738 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5739
5740 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5741 `gnutls_certificate_set_x509_key_file'.
5742
5743 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5744
5745 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5746 Update dependencies.
5747
5748 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5749
5750 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5751 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5752 Remove unused parameter `fildes'.
5753 * process.c (read_process_output, send_process): Don't pass it.
5754
5755 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5756
5757 Fix previous change: the library cache is defined in w32.c.
5758 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5759 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5760
5761 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5762
5763 Implement dynamic loading of GnuTLS on Windows.
5764
5765 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5766 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5767 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5768 Declare.
5769
5770 * gnutls.c (Qgnutls_dll): Define.
5771 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5772 (gnutls_*): Declare function pointers.
5773 (init_gnutls_functions): New function to initialize function pointers.
5774 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5775 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5776 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5777 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5778 (emacs_gnutls_write, emacs_gnutls_read)
5779 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5780 (Fgnutls_available_p): New function.
5781 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5782 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5783 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5784
5785 * image.c: Include w32.h.
5786 (Vimage_type_cache): Delete.
5787 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5788 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5789 (w32_delayed_load): Move to w32.c.
5790
5791 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5792
5793 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5794 (w32_delayed_load): Move from image.c. When loading a library, record
5795 its filename in the :loaded-from property of the library id.
5796 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5797 Initialize and staticpro them.
5798 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5799
5800 * process.c: Include lisp.h before w32.h, not after.
5801 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5802 instead of gnutls_record_check_pending.
5803
5804 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5805
5806 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5807
5808 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5809 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5810 as passed in.
5811
5812 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5813
5814 * xterm.c (x_set_frame_alpha): Do not set property on anything
5815 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5816
5817 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5818
5819 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5820
5821 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5822
5823 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5824 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5825 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5826 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5827 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5828 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5829 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5830 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5831 (Qgnutls_bootprop_callbacks_verify): Make static.
5832
5833 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5834
5835 * callproc.c: Indentation fixup.
5836
5837 * sysdep.c (wait_for_termination_1): Make static.
5838 (wait_for_termination, interruptible_wait_for_termination):
5839 Move after wait_for_termination_1.
5840
5841 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5842
5843 * sysdep.c (interruptible_wait_for_termination): New function
5844 which is like wait_for_termination, but allows keyboard
5845 interruptions.
5846
5847 * callproc.c (Fcall_process): Add (:file "file") as an option for
5848 the STDOUT buffer.
5849 (Fcall_process_region): Ditto.
5850
5851 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5852
5853 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5854 rather than `XVECTOR (FOO)->size'.
5855
5856 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5857 inttypes.h, as a gnulib replacement is used if it not available in
5858 system headers.
5859
5860 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5861
5862 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5863 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5864 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5865
5866 * coding.c (coding_alloc_by_realloc): Error out if destination
5867 will grow beyond MOST_POSITIVE_FIXNUM.
5868 (decode_coding_emacs_mule): Abort if there isn't enough place in
5869 charbuf for the composition carryover bytes. Reserve an extra
5870 space for up to 2 characters produced in a loop.
5871 (decode_coding_iso_2022): Abort if there isn't enough place in
5872 charbuf for the composition carryover bytes.
5873
5874 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5875
5876 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5877 aborting when %lld or %lll format is passed.
5878 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5879 %llo or %llx format is passed. (Bug#8545)
5880
5881 * window.c (window_scroll_line_based): Use a marker instead of
5882 simple variables to record original value of point. (Bug#7952)
5883
5884 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5885 produced by %s or %c overflows available buffer space. (Bug#8545)
5886
5887 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5888
5889 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5890 (SIZE_MAX): Move defn after all includes, as they might #define it.
5891
5892 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5893
5894 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5895
5896 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5897
5898 * keyboard.c (Qdelayed_warnings_hook): Define.
5899 (command_loop_1): Run `delayed-warnings-hook'
5900 if Vdelayed_warnings_list is non-nil.
5901 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5902 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5903
5904 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5905
5906 * doprnt.c (doprnt): Don't return value smaller than the buffer
5907 size if the message was truncated. (Bug#8545).
5908
5909 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5910
5911 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5912 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5913
5914 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5915
5916 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5917
5918 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5919
5920 * makefile.w32-in: Update dependencies.
5921
5922 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5923
5924 Improve `doprnt' and its usage. (Bug#8545)
5925 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5926 `format_end'. Remove support for %l as a conversion specifier.
5927 Don't use xrealloc. Improve diagnostics when the %l size modifier
5928 is used. Update the commentary.
5929
5930 * eval.c (verror): Simplify calculation of size_t.
5931
5932 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5933 messages.
5934
5935 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5936
5937 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5938 change.
5939
5940 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5941
5942 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5943 This makes this file independent of the recent pseudovector change.
5944
5945 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5946
5947 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5948
5949 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5950 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5951 Remove unused local.
5952 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5953
5954 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5955 GCC 4.6.0 optimizes based on type-based alias analysis.
5956 For example, if b is of type struct buffer * and v of type struct
5957 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5958 != &v->size, and therefore "v->size = 1; b->size = 2; return
5959 v->size;" must therefore return 1. This assumption is incorrect
5960 for Emacs, since it type-puns struct Lisp_Vector * with many other
5961 types. To fix this problem, this patch adds a new type struct
5962 vectorlike_header that documents the constraints on layout of vectors
5963 and pseudovectors, and helps optimizing compilers not get fooled
5964 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5965 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5966 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5967 the size member.
5968 (XSETPVECTYPE): Rewrite in terms of new macro.
5969 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5970 This is a bit clearer, and further avoids the possibility of
5971 undesirable aliasing.
5972 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5973 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5974 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5975 since Lisp_Subr is a special case (no "next" field).
5976 (ASIZE): Now uses header.size rather than size.
5977 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5978 to avoid the hassle of writing XVECTOR (foo)->header.size.
5979 (struct vectorlike_header): New type.
5980 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5981 object, to help avoid aliasing.
5982 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5983 (SUBRP): Likewise, since Lisp_Subr is a special case.
5984 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5985 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5986 (struct Lisp_Hash_Table): Combine first two members into a single
5987 struct vectorlike_header member. All uses of "size" and "next" members
5988 changed to be "header.size" and "header.next".
5989 * buffer.h (struct buffer): Likewise.
5990 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5991 * frame.h (struct frame): Likewise.
5992 * process.h (struct Lisp_Process): Likewise.
5993 * termhooks.h (struct terminal): Likewise.
5994 * window.c (struct save_window_data, struct saved_window): Likewise.
5995 * window.h (struct window): Likewise.
5996 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5997 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5998 * buffer.c (init_buffer_once): Likewise.
5999 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6000 special case.
6001 * process.c (Fformat_network_address): Use local var for size,
6002 for brevity.
6003
6004 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6005
6006 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6007 * data.c (atof): Remove decl; no longer used or needed.
6008 (digit_to_number): Move to lread.c.
6009 (Fstring_to_number): Use new string_to_number function, to be
6010 consistent with how the Lisp reader treats infinities and NaNs.
6011 Do not assume that floating-point numbers represent EMACS_INT
6012 without losing information; this is not true on most 64-bit hosts.
6013 Avoid double-rounding errors, by insisting on integers when
6014 parsing non-base-10 numbers, as the documentation specifies.
6015 * lisp.h (string_to_number): New decl, replacing ...
6016 (isfloat_string): Remove.
6017 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6018 (read1): Do not accept +. and -. as integers; this
6019 appears to have been a coding error. Similarly, do not accept
6020 strings like +-1e0 as floating point numbers. Do not report
6021 overflow for integer overflows unless the base is not 10 which
6022 means we have no simple and reliable way to continue.
6023 Break out the floating-point parsing into a new
6024 function string_to_number, so that Fstring_to_number parses
6025 floating point numbers consistently with the Lisp reader.
6026 (digit_to_number): Move here from data.c. Make it static inline.
6027 (E_CHAR, EXP_INT): Remove, replacing with ...
6028 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6029 (string_to_number): New function, replacing isfloat_string.
6030 This function checks for valid syntax and produces the resulting
6031 Lisp float number too. Rework it so that string-to-number
6032 no longer mishandles examples like "1.0e+". Use strtoumax,
6033 so that overflow for non-base-10 numbers is reported only when
6034 there's no portable and simple way to convert to floating point.
6035
6036 * textprop.c (set_text_properties_1): Rewrite for clarity,
6037 and to avoid GCC warning about integer overflow.
6038
6039 * intervals.h (struct interval): Use EMACS_INT for members
6040 where EMACS_UINT might cause problems. See
6041 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6042 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6043 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6044 All uses changed.
6045 (offset_intervals): Tell GCC not to worry about length overflow
6046 when negating a negative length.
6047
6048 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6049 (overrun_check_free): Likewise.
6050
6051 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6052 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6053 word size.
6054
6055 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6056 (gnutls_make_error): Rename local to avoid shadowing.
6057 (gnutls_emacs_global_deinit): ifdef out; not used.
6058 (Fgnutls_boot): Use const for pointer to readonly storage.
6059 Comment out unused local. Fix pointer signedness problems.
6060
6061 * lread.c (openp): Don't stuff size_t into an 'int'.
6062 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6063 about possible signed overflow.
6064
6065 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6066 (GDK_KEY_g): Don't define if already defined.
6067 (xg_prepare_tooltip): Avoid pointer signedness problem.
6068 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6069
6070 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6071 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6072
6073 * xfns.c (Fx_window_property): Simplify a bit,
6074 to make a bit faster and to avoid GCC 4.6.0 warning.
6075 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6076
6077 * fns.c (internal_equal): Don't assume size_t fits in int.
6078
6079 * alloc.c (compact_small_strings): Tighten assertion a little.
6080
6081 Replace pEd with more-general pI, and fix some printf arg casts.
6082 * lisp.h (pI): New macro, generalizing old pEd macro to other
6083 conversion specifiers. For example, use "...%"pI"d..." rather
6084 than "...%"pEd"...".
6085 (pEd): Remove. All uses replaced with similar uses of pI.
6086 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6087 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6088 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6089 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6090 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6091 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6092 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6093 64-bit hosts.
6094 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6095 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6096 * print.c (safe_debug_print, print_object): Likewise.
6097 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6098 to int.
6099 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6100 avoiding the 0 flag, which is not portable.
6101 * process.c (Fmake_network_process): Use pI to avoid cast.
6102 * region-cache.c (pp_cache): Likewise.
6103 * xdisp.c (decode_mode_spec): Likewise.
6104 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6105 behavior on 64-bit hosts with printf arg.
6106 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6107 (x_stop_queuing_selection_requests): Likewise.
6108 (x_get_window_property): Don't truncate byte count to an 'int'
6109 when tracing.
6110
6111 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6112 here, since it parses constructs like leading '-' and spaces,
6113 which are not wanted; and it overflows with large numbers.
6114 Instead, simply match F[0-9]+, which is what is wanted anyway.
6115
6116 * alloc.c: Remove unportable assumptions about struct layout.
6117 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6118 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6119 (allocate_vectorlike, make_pure_vector): Use the new macros,
6120 plus offsetof, to remove unportable assumptions about struct layout.
6121 These assumptions hold on all porting targets that I know of, but
6122 they are not guaranteed, they're easy to remove, and removing them
6123 makes further changes easier.
6124
6125 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6126 This doesn't fix a bug but makes the code clearer.
6127 (string_overrun_cookie): Now const. Use initializers that
6128 don't formally overflow signed char, to avoid warnings.
6129 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6130 can cause Emacs to crash when string overrun checking is enabled.
6131 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6132 multiple of sizeof (EMACS_INT); it need not be, if
6133 alignof(EMACS_INT) < sizeof (EMACS_INT).
6134 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6135
6136 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6137
6138 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6139
6140 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6141
6142 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6143 supposed to be handshaking. (Bug#8556)
6144 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6145
6146 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6147
6148 * lisp.h (Qdebug): List symbol.
6149 * eval.c (Qdebug): Restore global linkage.
6150 * keyboard.c (debug-on-event): New variable.
6151 (handle_user_signal): Break into debugger when debug-on-event
6152 matches the current signal symbol.
6153
6154 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6155
6156 * alloc.c (check_sblock, check_string_bytes)
6157 (check_string_free_list): Convert to standard C.
6158
6159 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6160
6161 * w32.c (emacs_gnutls_push): Fix typo.
6162
6163 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6164
6165 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6166 "cast to pointer from integer of different size".
6167
6168 Improve doprnt and its use in verror. (Bug#8545)
6169 * doprnt.c (doprnt): Document the set of format control sequences
6170 supported by the function. Use SAFE_ALLOCA instead of always
6171 using `alloca'.
6172
6173 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6174 is one byte too soon. Don't use xrealloc; instead xfree and
6175 xmalloc anew.
6176
6177 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6178
6179 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6180 callbacks stage.
6181
6182 * gnutls.c: Renamed global_initialized to
6183 gnutls_global_initialized. Added internals for the
6184 :verify-hostname-error, :verify-error, and :verify-flags
6185 parameters of `gnutls-boot' and documented those parameters in the
6186 docstring. Start callback support.
6187 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6188 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6189 on error. Return error code.
6190 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6191 (emacs_gnutls_read): Likewise.
6192 (Fgnutls_boot): Return handshake error code.
6193 (emacs_gnutls_handle_error): New function.
6194 (wsaerror_to_errno): Likewise.
6195
6196 * w32.h (emacs_gnutls_pull): Add prototype.
6197 (emacs_gnutls_push): Likewise.
6198
6199 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6200 (emacs_gnutls_push): Likewise.
6201
6202 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6203
6204 * process.c (wait_reading_process_output): Check if GnuTLS
6205 buffered some data internally if no FDs are set for TLS
6206 connections.
6207
6208 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6209 (LIBS): Link to USER_LIBS.
6210 ($(BLD)/gnutls.$(0)): New target.
6211
6212 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6213
6214 * xdisp.c (handle_single_display_spec): Rename the
6215 display_replaced_before_p argument into display_replaced_p, to
6216 make it consistent with the commentary. Fix typos in the
6217 commentary.
6218
6219 * textprop.c (syms_of_textprop): Remove dead code.
6220 (copy_text_properties): Delete obsolete commentary about an
6221 interface that was deleted long ago. Fix typos in the description
6222 of arguments.
6223
6224 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6225 to changes in oldXMenu/XMenu.h from 2011-04-16.
6226 <menu_help_message, prev_menu_help_message>: Constify.
6227 (IT_menu_make_room): menu->help_text is now `const char **';
6228 adjust.
6229
6230 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6231 to changes in oldXMenu/XMenu.h from 2011-04-16.
6232 (struct XMenu): Declare `help_text' `const char **'.
6233
6234 * xfaces.c <Qunspecified>: Make extern again.
6235
6236 * syntax.c: Include sys/types.h before including regex.h, as
6237 required by Posix.
6238
6239 * doc.c (get_doc_string): Improve the format passed to `error'.
6240
6241 * doprnt.c (doprnt): Improve commentary.
6242
6243 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6244
6245 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6246 them with etags.
6247
6248 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6249 changes in globals.h immediately force recompilation.
6250 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6251 $(CURDIR)/s/ms-w32.h.
6252 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6253
6254 * character.c (Fchar_direction): Function deleted.
6255 (syms_of_character): Don't defsubr it.
6256 <char-direction-table>: Deleted.
6257
6258 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6259
6260 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6261 * doprnt.c: Include limits.h.
6262 (SIZE_MAX): New macro.
6263 (doprnt): Return a size_t value. 2nd arg is now size_t.
6264 Many local variables are now size_t instead of int or unsigned.
6265 Improve overflow protection. Support `l' modifier for integer
6266 conversions. Support %l conversion. Don't assume an EMACS_INT
6267 argument for integer conversions and for %c.
6268
6269 * lisp.h (doprnt): Restore prototype.
6270
6271 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6272 $(SRC)/character.h.
6273
6274 * Makefile.in (base_obj): Add back doprnt.o.
6275
6276 * deps.mk (doprnt.o): Add back prerequisites.
6277 (callint.o): Depend on character.h.
6278
6279 * eval.c (internal_lisp_condition_case): Include the handler
6280 representation in the error message.
6281 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6282 when breaking from the loop.
6283
6284 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6285
6286 * callint.c (Fcall_interactively): When displaying error message
6287 about invalid control letter, pass the character's codepoint, not
6288 a pointer to its multibyte form. Improve display of the character
6289 in octal and display also its hex code.
6290
6291 * character.c (char_string): Use %x to display the (unsigned)
6292 codepoint of an invalid character, to avoid displaying a bogus
6293 negative value.
6294
6295 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6296 `error', not SYMBOL_NAME itself.
6297
6298 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6299 character arguments to `error'.
6300
6301 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6302 to `error' in error message about FINAL_CHAR argument. Make sure
6303 FINAL_CHAR is a character, and use %c when it is passed as
6304 argument to `error'.
6305
6306 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6307
6308 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6309
6310 * w32.c: Include <time.h>.
6311 (sys_localtime): New function.
6312
6313 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6314
6315 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6316
6317 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6318
6319 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6320
6321 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6322 zombies (Bug#8467).
6323
6324 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6325
6326 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6327 gl_state.e_property when gl_state.object is Qt.
6328
6329 * insdel.c (make_gap_larger): Remove limitation of buffer size
6330 to <= INT_MAX.
6331
6332 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6333
6334 * xdisp.c (lookup_glyphless_char_display)
6335 (produce_glyphless_glyph): Handle cons cell entry in
6336 glyphless-char-display.
6337 (Vglyphless_char_display): Document it.
6338
6339 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6340 glyphless-char-display.
6341
6342 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6343
6344 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6345
6346 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6347
6348 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6349 definition for no-X builds.
6350
6351 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6352
6353 Static checks with GCC 4.6.0 and non-default toolkits.
6354
6355 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6356
6357 * process.c (keyboard_bit_set): Define only if SIGIO.
6358 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6359 (send_process): Repair possible setjmp clobbering.
6360
6361 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6362
6363 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6364
6365 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6366
6367 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6368 Define only if needed.
6369
6370 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6371 by pacifying GCC about it. Maybe it's time to retire it?
6372 * xfaces.c (USG, __TIMEVAL__): Likewise.
6373
6374 * dispextern.h (struct redisplay_interface): Rename param
6375 to avoid shadowing.
6376 * termhooks.h (struct terminal): Likewise.
6377 * xterm.c (xembed_send_message): Likewise.
6378
6379 * insdel.c (make_gap_smaller): Define only if
6380 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6381
6382 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6383 it.
6384
6385 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6386 so that we aren't warned about unused symbols.
6387
6388 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6389
6390 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6391
6392 * xfns.c (x_real_positions): Mark locals as initialized.
6393
6394 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6395
6396 * xterm.c: Fix problems found by static analysis with other toolkits.
6397 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6398 (x_dispatch_event): Declare static if USE_GTK, and
6399 define if USE_GTK || USE_X_TOOLKIT.
6400 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6401 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6402 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6403 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6404
6405 * xmenu.c (menu_help_callback): Pointer type fixes.
6406 Use const pointers when pointing at readonly data. Avoid pointer
6407 signedness clashes.
6408 (FALSE): Remove unused macro.
6409 (update_frame_menubar): Remove unused decl.
6410
6411 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6412
6413 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6414 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6415 (single_menu_item): Rename local to avoid shadowing.
6416
6417 * keyboard.c (make_lispy_event): Remove unused local var.
6418
6419 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6420 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6421
6422 * bitmaps: Change bitmaps from unsigned char back to the X11
6423 compatible char. Avoid the old compiler warnings about
6424 out-of-range initializers by using, for example, '\xab' rather
6425 than 0xab.
6426
6427 * xgselect.c (xgselect_initialize): Check vs interface
6428 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6429
6430 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6431
6432 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6433 to read-only memory.
6434
6435 * fns.c (vector): Remove; this old hack is no longer needed.
6436
6437 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6438 Remove unused var.
6439 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6440
6441 * xrdb.c (x_load_resources): Omit unused local.
6442
6443 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6444 (x_window): Rename locals to avoid shadowing.
6445 (USG): Use the kludged USG macro, to pacify gcc.
6446
6447 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6448 (x_term_init): Remove local to avoid shadowing.
6449
6450 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6451
6452 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6453 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6454
6455 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6456
6457 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6458
6459 Fix regex.c, syntax.c and friends for buffers > 2GB.
6460 * syntax.h (struct gl_state_s): Declare character position members
6461 EMACS_INT.
6462
6463 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6464
6465 * textprop.c (verify_interval_modification, interval_of):
6466 Declare arguments EMACS_INT.
6467
6468 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6469 EMACS_INT.
6470
6471 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6472
6473 * indent.c (Fvertical_motion): Local variable it_start is now
6474 EMACS_INT.
6475
6476 * regex.c (re_match, re_match_2, re_match_2_internal)
6477 (bcmp_translate, regcomp, regexec, print_double_string)
6478 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6479 (re_compile_pattern, re_exec): Declare arguments and local
6480 variables `size_t' and `ssize_t' and return values `regoff_t', as
6481 appropriate.
6482 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6483 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6484 <compile_stack_type>: `size' and `avail' are now `size_t'.
6485
6486 * regex.h <regoff_t>: Use ssize_t, not int.
6487 (re_search, re_search_2, re_match, re_match_2): Arguments that
6488 specify buffer/string position and length are now ssize_t and
6489 size_t. Return type is regoff_t.
6490
6491 2011-04-16 Ben Key <bkey76@gmail.com>
6492
6493 * nsfont.m: Fixed bugs in ns_get_family and
6494 ns_descriptor_to_entity that were caused by using free to
6495 deallocate memory blocks that were allocated by xmalloc (via
6496 xstrdup). This caused Emacs to crash when compiled with
6497 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6498 --enable-checking=xmallocoverrun). xfree is now used to
6499 deallocate these memory blocks.
6500
6501 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6502
6503 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6504
6505 emacs_write: Accept and return EMACS_INT for sizes.
6506 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6507 et seq.
6508 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6509 Accept and return EMACS_INT.
6510 (emacs_gnutls_write): Return the number of bytes written on
6511 partial writes.
6512 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6513 (emacs_read, emacs_write): Remove check for negative size, as the
6514 Emacs source code has been audited now.
6515 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6516 (emacs_read, emacs_write): Use it.
6517 * process.c (send_process): Adjust to the new signatures of
6518 emacs_write and emacs_gnutls_write. Do not attempt to store
6519 a byte offset into an 'int'; it might overflow.
6520 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6521
6522 * sound.c: Don't assume sizes fit in 'int'.
6523 (struct sound_device.period_size, alsa_period_size):
6524 Return EMACS_INT, not int.
6525 (struct sound_device.write, vox_write, alsa_write):
6526 Accept EMACS_INT, not int.
6527 (wav_play, au_play): Use EMACS_INT to store sizes and to
6528 record read return values.
6529
6530 2011-04-15 Ben Key <bkey76@gmail.com>
6531
6532 * keyboard.c (Qundefined): Don't declare static since it is used
6533 in nsfns.m.
6534 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6535 static since they are used in nsfont.m.
6536
6537 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6538
6539 * process.c (Qprocessp): Don't declare static.
6540 * lisp.h (Qprocessp): Declare again.
6541
6542 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6543
6544 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6545
6546 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6547
6548 Improve C-level modularity by making more things 'static'.
6549
6550 Don't publish debugger-only interfaces to other modules.
6551 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6552 (verify_bytepos, count_markers): Move decls to the only modules
6553 that need them.
6554 * region-cache.h (pp_cache): Likewise.
6555 * window.h (check_all_windows): Likewise.
6556 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6557
6558 * sysdep.c (croak): Now static, if
6559 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6560 * syssignal.h (croak): Declare only if not static.
6561
6562 * alloc.c (refill_memory_reserve): Now static if
6563 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6564 * lisp.h (refill_memory_reserve): Declare only if not static.
6565
6566 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6567 Define only if USE_LUCID.
6568
6569 * xrdb.c (x_customization_string, x_rm_string): Now static.
6570
6571 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6572 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6573
6574 * xdisp.c (draw_row_with_mouse_face): Now static.
6575 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6576
6577 * window.h (check_all_windows): Mark externally visible.
6578
6579 * window.c (window_deletion_count): Now static.
6580
6581 * undo.c: Make symbols static if they're not exported.
6582 (last_undo_buffer, last_boundary_position, pending_boundary):
6583 Now static.
6584
6585 * textprop.c (interval_insert_behind_hooks): Now static.
6586 (interval_insert_in_front_hooks): Likewise.
6587
6588 * term.c: Make symbols static if they're not exported.
6589 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6590 (max_frame_lines, tty_set_terminal_modes):
6591 (tty_reset_terminal_modes, tty_turn_off_highlight):
6592 (get_tty_terminal): Now static.
6593 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6594 * termhooks.h (term_mouse_moveto): Do not declare if
6595 HAVE_WINDOW_SYSTEM.
6596 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6597 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6598
6599 * sysdep.c: Make symbols static if they're not exported.
6600 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6601 Now static.
6602 (sigprocmask_set, full_mask): Remove; unused.
6603 (wait_debugging): Mark as visible.
6604 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6605 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6606
6607 * syntax.c (syntax_temp): Define only if !__GNUC__.
6608
6609 * sound.c (current_sound_device, current_sound): Now static.
6610
6611 * search.c (searchbufs, searchbuf_head): Now static.
6612
6613 * scroll.c (scroll_cost): Remove; unused.
6614 * dispextern.h (scroll_cost): Remove decl.
6615
6616 * region-cache.h (pp_cache): Mark as externally visible.
6617
6618 * process.c: Make symbols static if they're not exported.
6619 (process_tick, update_tick, create_process, chan_process):
6620 (Vprocess_alist, proc_buffered_char, datagram_access):
6621 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6622 (deactivate_process): Mark defn as static, as well as decl.
6623 * lisp.h (create_process): Remove decl.
6624 * process.h (chan_process, Vprocess_alist): Remove decls.
6625
6626 * print.c: Make symbols static if they're not exported.
6627 (print_depth, new_backquote_output, being_printed, print_buffer):
6628 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6629 (print_interval, print_number_index, initial_stderr_stream):
6630 Now static.
6631 * lisp.h (Fprinc): Remove decl.
6632 (debug_output_compilation_hack): Mark as externally visible.
6633
6634 * sysdep.c (croak): Move decl from here to syssignal.h.
6635 * syssignal.h (croak): Put it here, so the API can be checked when
6636 'croak' is called from dissociate_if_controlling_tty.
6637
6638 * minibuf.c: Make symbols static if they're not exported.
6639 (minibuf_save_list, choose_minibuf_frame): Now static.
6640 * lisp.h (choose_minibuf_frame): Remove decl.
6641
6642 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6643
6644 * lread.c: Make symbols static if they're not exported.
6645 (read_objects, initial_obarray, oblookup_last_bucket_number):
6646 Now static.
6647 (make_symbol): Remove; unused.
6648 * lisp.h (initial_obarray, make_symbol): Remove decls.
6649
6650 * keyboard.c: Make symbols static if they're not exported.
6651 (single_kboard, recent_keys_index, total_keys, recent_keys):
6652 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6653 (this_single_command_key_start, echoing, last_auto_save):
6654 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6655 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6656 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6657 (Vlispy_mouse_stem, double_click_count):
6658 Now static.
6659 (force_auto_save_soon): Define only if SIGDANGER.
6660 (ignore_mouse_drag_p): Now static if
6661 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6662 (print_help): Remove; unused.
6663 (stop_character, last_timer_event): Mark as externally visible.
6664 * keyboard.h (ignore_mouse_drag_p): Declare only if
6665 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6666 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6667 * lisp.h (echoing): Remove decl.
6668 (force_auto_save_soon): Declare only if SIGDANGER.
6669 * xdisp.c (redisplay_window): Simplify code, to make it more
6670 obvious that ignore_mouse_drag_p is not accessed if !defined
6671 USE_GTK && !defined HAVE_NS.
6672
6673 * intervals.c: Make symbols static if they're not exported.
6674 (merge_properties_sticky, merge_interval_right, delete_interval):
6675 Now static.
6676 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6677
6678 * insdel.c: Make symbols static if they're not exported.
6679 However, leave prepare_to_modify_buffer alone. It's never
6680 called from outside this function, but that appears to be a bug.
6681 (combine_after_change_list, combine_after_change_buffer):
6682 (adjust_after_replace, signal_before_change): Now static.
6683 (adjust_after_replace_noundo): Remove; unused.
6684 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6685 (signal_before_change): Remove decls.
6686
6687 * indent.c (val_compute_motion, val_vmotion): Now static.
6688
6689 * image.c: Make symbols static if they're not exported.
6690 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6691 if USE_GTK.
6692 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6693 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6694
6695 * fringe.c (standard_bitmaps): Now static.
6696 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6697
6698 * frame.c: Make symbols static if they're not exported.
6699 (x_report_frame_params, make_terminal_frame): Now static.
6700 (get_frame_param): Now static, unless HAVE_NS.
6701 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6702 (x_get_resource_string): Remove; not used.
6703 * frame.h (make_terminal_frame, x_report_frame_params):
6704 (x_get_resource_string); Remove decls.
6705 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6706 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6707
6708 * font.c, fontset.c: Make symbols static if they're not exported.
6709 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6710 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6711 * font.c (font_close_object): Now static.
6712 * font.h (font_close_object): Remove.
6713 * fontset.c (FONTSET_OBJLIST): Remove.
6714 (free_realized_fontset) #if-0 the body, which does nothing.
6715 (face_suitable_for_char_p): #if-0, as it's never called.
6716 * fontset.h (face_suitable_for_char_p): Remove decl.
6717 * xfaces.c (face_at_string_position):
6718 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6719 since 0 is always ASCII.
6720
6721 * fns.c (weak_hash_tables): Now static.
6722
6723 * fileio.c: Make symbols static if they're not exported.
6724 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6725 (Vwrite_region_annotation_buffers): Now static.
6726
6727 * eval.c: Make symbols static if they're not exported.
6728 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6729 * lisp.h (backtrace_list): Remove decl.
6730
6731 * emacs.c: Make symbols static if they're not exported.
6732 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6733 (fatal_error_code, fatal_error_signal_hook, standard_args):
6734 Now static.
6735 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6736 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6737 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6738 * lisp.h (fatal_error_signal_hook): Remove decl.
6739 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6740
6741 * editfns.c: Move a (normally-unused) function to its only use.
6742 * editfns.c, lisp.h (get_operating_system_release): Remove.
6743 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6744 worth the hassle of breaking this out.
6745
6746 * xterm.c: Make symbols static if they're not exported.
6747 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6748 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6749 (x_destroy_window, x_delete_display):
6750 Now static.
6751 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6752 (x_mouse_leave): Remove; unused.
6753 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6754 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6755 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6756 Remove decls.
6757 (x_mouse_leave): Declare only if WINDOWSNT.
6758 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6759 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6760 USE_X_TOOLKIT.
6761
6762 * ftxfont.c: Make symbols static if they're not exported.
6763 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6764 HAVE_FREETYPE.
6765 * font.h (ftxfont_driver): Likewise.
6766
6767 * xfns.c: Make symbols static if they're not exported.
6768 (x_last_font_name, x_display_info_for_name):
6769 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6770 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6771 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6772 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6773 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6774 (last_show_tip_args): Now static.
6775 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6776 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6777 (x_screen_planes): Remove; unused.
6778 * dispextern.h (x_screen_planes): Remove decl.
6779
6780 * dispnew.c: Make symbols static if they're not exported.
6781 * dispextern.h (redraw_garbaged_frames, scrolling):
6782 (increment_row_positions): Remove.
6783 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6784 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6785 Now static.
6786 (redraw_garbaged_frames): Remove; unused.
6787
6788 * xfaces.c: Make symbols static if they're not exported.
6789 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6790 Remove decls.
6791 * xterm.h (defined_color): Remove decls.
6792 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6793 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6794 (menu_face_changed_default, defined_color, free_realized_face):
6795 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6796 (ascii_face_of_lisp_face): Remove; unused.
6797
6798 * xdisp.c: Make symbols static if they're not exported.
6799 * dispextern.h (scratch_glyph_row, window_box_edges):
6800 (glyph_to_pixel_coords, set_cursor_from_row):
6801 (get_next_display_element, set_iterator_to_next):
6802 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6803 (show_mouse_face): Remove decls
6804 * frame.h (message_buf_print): Likewise.
6805 * lisp.h (pop_message, set_message, check_point_in_composition):
6806 Likewise.
6807 * xterm.h (set_vertical_scroll_bar): Likewise.
6808 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6809 (message_buf_print, scratch_glyph_row, displayed_buffer):
6810 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6811 (get_next_display_element, show_mouse_face, window_box_edges):
6812 (frame_to_window_pixel_xy, check_point_in_composition):
6813 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6814 (glyph_to_pixel_coords): Remove; unused.
6815
6816 * dired.c (file_name_completion): Now static.
6817
6818 * dbusbind.c (xd_in_read_queued_messages): Now static.
6819
6820 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6821 * data.c (circular_list_error): Remove.
6822
6823 * commands.h (last_point_position, last_point_position_buffer):
6824 (last_point_position_window): Remove decls.
6825 * keyboard.c: Make these variables static.
6826
6827 * coding.h (coding, code_convert_region, encode_coding_gap):
6828 Remove decls.
6829 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6830 (iso_code_class, detect_coding, code_convert_region): Now static.
6831 (encode_coding_gap): Remove; unused.
6832
6833 * chartab.c (chartab_chars, chartab_bits): Now static.
6834
6835 * charset.h (charset_iso_8859_1): Remove decl.
6836 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6837 Now static.
6838
6839 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6840 * ccl.c (Vccl_program_table): Now static.
6841 (check_ccl_update): Remove; unused.
6842
6843 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6844 * category.h: ... from here.
6845 * category.c (check_category_table, set_category_set): Now static.
6846
6847 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6848 * lisp.h: Remove these decls.
6849
6850 * buffer.c (buffer_count): Remove unused var.
6851
6852 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6853 so that it's not optimized away.
6854 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6855 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6856 exported only to the debugger.
6857
6858 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6859 * atimer.h (run_all_atimers): Remove; not exported.
6860
6861 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6862 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6863 was inaccessible from Lisp.
6864 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6865 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6866
6867 alloc.c: Import and export fewer symbols, and remove unused items.
6868 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6869 is defined.
6870 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6871 it's not optimized away by whole-program optimization.
6872 (message_enable_multibyte, free_misc): Remove.
6873 (catchlist, handlerlist, mark_backtrace):
6874 Declare only if BYTE_MARK_STACK.
6875 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6876 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6877 (message_enable_multibyte): Remove decl.
6878 (free_misc, interval_free_list, float_block, float_block_index):
6879 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6880 (cons_free_list, last_marked_index):
6881 Now static.
6882 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6883 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6884 (mark_backtrace): Define only if BYTE_MARK_STACK.
6885 * xdisp.c (message_enable_multibyte): Now static.
6886
6887 Declare Lisp_Object Q* variables to be 'static' if not exported.
6888 This makes it easier for human readers (and static analyzers)
6889 to see whether these variables are used from other modules.
6890 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6891 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6892 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6893 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6894 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6895 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6896 * xmenu.c, xselect.c:
6897 Declare Q* vars static if they are not used in other modules.
6898 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6899 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6900 Remove decls of unexported vars.
6901 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6902
6903 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6904
6905 Make Emacs functions such as Fatom 'static' by default.
6906 This makes it easier for human readers (and static analyzers)
6907 to see whether these functions can be called from other modules.
6908 DEFUN now defines a static function. To make the function external
6909 so that it can be used in other C modules, use the new macro DEFUE.
6910 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6911 (Finit_image_library):
6912 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6913 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6914 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6915 Remove decls, since these functions are now static.
6916 (Funintern, Fget_internal_run_time): New decls, since these functions
6917 were already external.
6918
6919 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6920 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6921 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6922 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6923 * keyboard.c, keymap.c, lread.c:
6924 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6925 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6926 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6927 Mark functions with DEFUE instead of DEFUN,
6928 if they are used in other modules.
6929 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6930 decls for now-static functions.
6931 * buffer.h (Fdelete_overlay): Remove decl.
6932 * callproc.c (Fgetenv_internal): Mark as internal.
6933 * composite.c (Fremove_list_of_text_properties): Remove decl.
6934 (Fcomposition_get_gstring): New forward static decl.
6935 * composite.h (Fcomposite_get_gstring): Remove decl.
6936 * dired.c (Ffile_attributes): New forward static decl.
6937 * doc.c (Fdocumntation_property): New forward static decl.
6938 * eval.c (Ffetch_bytecode): New forward static decl.
6939 (Funintern): Remove extern decl; now in .h file where it belongs.
6940 * fileio.c (Fmake_symbolic_link): New forward static decl.
6941 * image.c (Finit_image_library): New forward static decl.
6942 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6943 * intervals.h (Fprevious_property_change):
6944 (Fremove_list_of_text_properties): Remove decls.
6945 * keyboard.c (Fthis_command_keys): Remove decl.
6946 (Fcommand_execute): New forward static decl.
6947 * keymap.c (Flookup_key): New forward static decl.
6948 (Fcopy_keymap): Now static.
6949 * keymap.h (Flookup_key): Remove decl.
6950 * process.c (Fget_process): New forward static decl.
6951 (Fprocess_datagram_address): Mark as internal.
6952 * syntax.c (Fsyntax_table_p): New forward static decl.
6953 (skip_chars): Remove duplicate decl.
6954 * textprop.c (Fprevious_property_change): New forward static decl.
6955 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6956 Now internal.
6957 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6958 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6959
6960 * editfns.c (Fformat): Remove unreachable code.
6961
6962 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6963
6964 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6965 change. (Bug#8496)
6966
6967 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6968
6969 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6970 when at ZV. (Bug#8487)
6971
6972 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6973
6974 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6975 (Bug#8437)
6976 * keyboard.c (parse_tool_bar_item): Likewise.
6977 * sound.c (sound_cleanup, alsa_close): Likewise.
6978 * termcap.c (tgetent): Likewise.
6979 * xfns.c (x_default_font_parameter): Likewise.
6980 * xsettings.c (read_and_apply_settings): Likewise.
6981
6982 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6983 (overrun_check_free): Protoize.
6984
6985 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6986
6987 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6988 since callers should never pass a negative size.
6989 Change the signature to match that of plain 'read' and 'write'; see
6990 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6991 * lisp.h: Update prototypes of emacs_write and emacs_read.
6992
6993 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6994
6995 * xdisp.c (redisplay_window): Don't try to determine the character
6996 position of the scroll margin if the window start point w->startp
6997 is outside the buffer's accessible region. (Bug#8468)
6998
6999 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7000
7001 Fix write-region and its subroutines for buffers > 2GB.
7002 * fileio.c (a_write, e_write): Modify declaration of arguments and
7003 local variables to support buffers larger than 2GB.
7004 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7005
7006 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7007 argument, local variables, and return value.
7008
7009 * lisp.h: Update prototypes of emacs_write and emacs_read.
7010
7011 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7012
7013 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7014
7015 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7016
7017 Fix more problems found by GCC 4.6.0's static checks.
7018
7019 * xdisp.c (vmessage): Use a better test for character truncation.
7020
7021 * charset.c (load_charset_map): <, not <=, for optimization,
7022 and to avoid potential problems with integer overflow.
7023 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7024 * casetab.c (set_identity, shuffle): Likewise.
7025 * editfns.c (Fformat): Likewise.
7026 * syntax.c (skip_chars): Likewise.
7027
7028 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7029 This also lets GCC 4.6.0 generate slightly better loop code.
7030
7031 * callint.c (Fcall_interactively): <, not <=, for optimization.
7032 (Fcall_interactively): Count the number of arguments produced,
7033 not the number of arguments given. This is simpler and lets GCC
7034 4.6.0 generate slightly better code.
7035
7036 * ftfont.c: Distingish more carefully between FcChar8 and char.
7037 The previous code passed unsigned char * to a functions like
7038 strlen and xstrcasecmp that expect char *, which does not
7039 conform to the C standard.
7040 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7041 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7042 char * when the C standard requires it.
7043
7044 * keyboard.c (read_char): Remove unused var.
7045
7046 * eval.c: Port to Windows vsnprintf (Bug#8435).
7047 Include <limits.h>.
7048 (SIZE_MAX): Define if the headers do not.
7049 (verror): Do not give up if vsnprintf returns a negative count.
7050 Instead, grow the buffer. This ports to Windows vsnprintf, which
7051 does not conform to C99. Problem reported by Eli Zaretskii.
7052 Also, simplify the allocation scheme, by avoiding the need for
7053 calling realloc, and removing the ALLOCATED variable.
7054
7055 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7056
7057 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7058 But keep the doprint source code for now, as we might revamp it
7059 and use it again (Bug#8435).
7060 * lisp.h (doprnt): Remove.
7061 * Makefile.in (base_obj): Remove doprnt.o.
7062 * deps.mk (doprnt.o): Remove.
7063
7064 error: Print 32- and 64-bit integers portably (Bug#8435).
7065 Without this change, on typical 64-bit hosts error ("...%d...", N)
7066 was used to print both 32- and 64-bit integers N, which relied on
7067 undefined behavior.
7068 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7069 New macro.
7070 * lisp.h (error, verror): Mark as printf-like functions.
7071 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7072 Report overflow in size calculations when allocating printf buffer.
7073 Do not truncate output string at its first null byte.
7074 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7075 Truncate the output at a character boundary, since vsnprintf does not
7076 do that.
7077 * charset.c (check_iso_charset_parameter): Convert internal
7078 character to string before calling 'error', since %c now has the
7079 printf meaning.
7080 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7081 overflow when computing char to be passed to 'error'. Do not
7082 pass Lisp_Object to 'error'; pass the integer instead.
7083 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7084 formatted with plain %d.
7085
7086 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7087
7088 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7089
7090 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7091
7092 * xterm.c (x_catch_errors): Remove duplicate declaration.
7093
7094 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7095
7096 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7097
7098 2011-04-10 Jim Meyering <meyering@redhat.com>
7099
7100 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7101 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7102 return ssize_t not "int", and use size_t as the buffer length.
7103 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7104 * gnutls.h: Update declarations.
7105 * process.c (read_process_output): Use ssize_t, to match.
7106 (send_process): Likewise.
7107
7108 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7109
7110 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7111
7112 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7113
7114 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7115 Use unsigned char, to match FcChar8 type definition.
7116
7117 * xterm.c (handle_one_xevent):
7118 * xmenu.c (create_and_show_popup_menu):
7119 * xselect.c (x_decline_selection_request)
7120 (x_reply_selection_request): Avoid type-punned deref of X events.
7121
7122 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7123
7124 Fix some uses of `int' instead of EMACS_INT.
7125 * search.c (string_match_1, fast_string_match)
7126 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7127 (scan_buffer, find_next_newline_no_quit)
7128 (find_before_next_newline, search_command, Freplace_match)
7129 (Fmatch_data): Make some `int' variables be EMACS_INT.
7130
7131 * xdisp.c (display_count_lines): 3rd argument and return value now
7132 EMACS_INT. All callers changed.
7133 (pint2hrstr): Last argument is now EMACS_INT.
7134
7135 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7136 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7137 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7138 (decode_coding_utf_16, decode_coding_emacs_mule)
7139 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7140 (decode_coding_ccl, decode_coding_charset)
7141 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7142 (decode_coding_iso_2022, decode_coding_emacs_mule)
7143 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7144 <char_offset, last_offset>: Declare EMACS_INT.
7145 (encode_coding_utf_8, encode_coding_utf_16)
7146 (encode_coding_emacs_mule, encode_invocation_designation)
7147 (encode_designation_at_bol, encode_coding_iso_2022)
7148 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7149 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7150 Declare EMACS_INT.
7151 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7152 (encode_invocation_designation): Last argument P_NCHARS is now
7153 EMACS_INT.
7154 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7155 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7156
7157 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7158 All users changed.
7159
7160 * ccl.c (Fccl_execute_on_string): Declare some variables
7161 EMACS_INT.
7162
7163 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7164
7165 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7166
7167 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7168
7169 * process.c (Fformat_network_address): Doc fix.
7170
7171 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7172
7173 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
7174
7175 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7176
7177 * keyboard.c (read_char): Call Lisp function help-form-show,
7178 instead of using internal_with_output_to_temp_buffer.
7179 (Qhelp_form_show): New var.
7180 (syms_of_keyboard): Use DEFSYM macro.
7181
7182 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7183
7184 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7185
7186 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7187
7188 * process.c (Flist_processes): Remove to Lisp.
7189 (list_processes_1): Delete.
7190
7191 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7192
7193 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7194
7195 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7196
7197 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7198
7199 Fix more problems found by GCC 4.6.0's static checks.
7200
7201 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7202
7203 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7204
7205 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7206
7207 * xdisp.c (vmessage): Mark as a printf-like function.
7208
7209 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7210
7211 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7212
7213 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7214 printf-like functions.
7215 (tiff_load): Add casts to remove these marks before passing them
7216 to system-supplied API.
7217
7218 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7219
7220 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7221 This avoids several warnings with gcc -Wstrict-overflow.
7222 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7223 directly, rather than having caller test rule sign. This avoids
7224 some unnecessary tests.
7225 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7226 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7227 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7228
7229 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7230 (xfont_open): Avoid unnecessary tests.
7231
7232 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7233
7234 * composite.h, composite.c (composition_gstring_put_cache):
7235 Use EMACS_INT, not int, for length.
7236
7237 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7238 breaking out part of COMPOSITION_DECODE_RULE.
7239 (COMPOSITION_DECODE_RULE): Use it.
7240 * composite.c (get_composition_id): Remove unused local vars,
7241 by using the new macro.
7242
7243 * textprop.c (set_text_properties_1): Change while to do-while,
7244 since the condition is always true at first.
7245
7246 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7247 (interval_deletion_adjustment): Return unsigned value.
7248 All uses changed.
7249
7250 * process.c (list_processes_1, create_pty, read_process_output):
7251 (exec_sentinel): Remove vars that were set but not used.
7252 (create_pty): Remove unnecessary "volatile"s.
7253 (Fnetwork_interface_info): Avoid possibility of int overflow.
7254 (read_process_output): Do adaptive read buffering even if carryover.
7255 (read_process_output): Simplify nbytes computation if buffered.
7256
7257 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7258
7259 * syntax.c (scan_words): Remove var that was set but not used.
7260 (update_syntax_table): Use unsigned instead of int.
7261
7262 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7263 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7264 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7265
7266 * print.c (print_error_message): Avoid int overflow.
7267
7268 * font.c (font_list_entities): Redo for clarity,
7269 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7270
7271 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7272 (font_score): Avoid potential overflow in diff calculation.
7273
7274 * fns.c (substring_both): Remove var that is set but not used.
7275 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7276
7277 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7278
7279 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7280 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7281 can always succeed if overflow has undefined behavior.
7282
7283 * search.c (boyer_moore, wordify): Remove vars set but not used.
7284 (wordify): Omit three unnecessary tests.
7285
7286 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7287 All callers changed. This avoids the need for an unused var.
7288
7289 * casefiddle.c (casify_region): Remove var that is set but not used.
7290
7291 * dired.c (file_name_completion): Remove var that is set but not used.
7292
7293 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7294
7295 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7296 (Finsert_file_contents): Remove unnecessary code checking fd.
7297
7298 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7299 Check for integer overflow on size calculations.
7300
7301 * buffer.c (Fprevious_overlay_change): Remove var that is set
7302 but not used.
7303
7304 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7305 Remove vars that are set but not used.
7306 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7307 (timer_check_2): Mark vars as initialized.
7308
7309 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7310
7311 * image.c (lookup_image): Remove var that is set but not used.
7312 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7313
7314 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7315 that are set but not used.
7316
7317 * xfns.c (make_invisible_cursor): Don't return garbage
7318 if XCreateBitmapFromData fails (Bug#8410).
7319
7320 * xselect.c (x_get_local_selection, x_handle_property_notify):
7321 Remove vars that are set but not used.
7322
7323 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7324 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7325
7326 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7327 Remove var that is set but not used.
7328 (scroll_bar_windows_size): Now size_t, not int.
7329 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7330 Check for overflow.
7331
7332 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7333 (map_tty_color) [!defined MSDOS]: Likewise.
7334
7335 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7336
7337 * coding.c: Remove vars that are set but not used.
7338 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7339 All callers changed.
7340 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7341 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7342 (decode_coding_charset): Remove vars that are set but not used.
7343
7344 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7345 that is set but not used.
7346
7347 * print.c (print_object): Remove var that is set but not used.
7348
7349 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7350 The gnulib version avoids calling malloc in the usual case,
7351 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7352 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7353 * filelock.c (current_lock_owner): Likewise.
7354 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7355 * sysdep.c: Include allocator.h, careadlinkat.h.
7356 (emacs_no_realloc_allocator): New static constant.
7357 (emacs_readlink): New function.
7358 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7359 ../lib/careadlinkat.h.
7360
7361 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7362
7363 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7364 first non-nil return value).
7365
7366 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7367
7368 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7369 if not defined (Bug#8403).
7370
7371 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7372
7373 * xdisp.c (display_count_lines): Remove parameter `start',
7374 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7375 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7376 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7377 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7378 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7379 and thereabouts. All callers changed.
7380 (get_per_char_metric): Remove parameter `f', unused since
7381 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7382
7383 2011-04-02 Jim Meyering <meyering@redhat.com>
7384
7385 do not dereference NULL upon failed strdup
7386 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7387 (ns_get_family): Likewise.
7388
7389 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7390
7391 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7392
7393 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7394
7395 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7396 later (Bug#8403).
7397
7398 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7399
7400 Add lexical binding.
7401
7402 * window.c (Ftemp_output_buffer_show): New fun.
7403 (Fsave_window_excursion):
7404 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7405
7406 * lread.c (lisp_file_lexically_bound_p): New function.
7407 (Fload): Bind Qlexical_binding.
7408 (readevalloop): Remove `evalfun' arg.
7409 Bind Qinternal_interpreter_environment.
7410 (Feval_buffer): Bind Qlexical_binding.
7411 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7412 Mark as dynamic.
7413 (syms_of_lread): Declare `lexical-binding'.
7414
7415 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7416
7417 * keyboard.c (eval_dyn): New fun.
7418 (menu_item_eval_property): Use it.
7419
7420 * image.c (parse_image_spec): Use Ffunctionp.
7421
7422 * fns.c (concat, mapcar1): Accept byte-code-functions.
7423
7424 * eval.c (Fsetq): Handle lexical vars.
7425 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7426 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7427 (FletX, Flet): Obey lexical binding.
7428 (Fcommandp): Handle closures.
7429 (Feval): New `lexical' arg.
7430 (eval_sub): New function extracted from Feval. Use it almost
7431 everywhere where Feval was used. Look up vars in lexical env.
7432 Handle closures.
7433 (Ffunctionp): Move from subr.el.
7434 (Ffuncall): Handle closures.
7435 (apply_lambda): Remove `eval_flags'.
7436 (funcall_lambda): Handle closures and new byte-code-functions.
7437 (Fspecial_variable_p): New function.
7438 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7439 but without exporting it to Lisp.
7440
7441 * doc.c (Fdocumentation, store_function_docstring):
7442 * data.c (Finteractive_form): Handle closures.
7443
7444 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7445 interactive spec.
7446
7447 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7448 New byte-codes.
7449 (exec_byte_code): New function extracted from Fbyte_code to handle new
7450 calling convention for byte-code-functions. Add new byte-codes.
7451
7452 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7453
7454 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7455
7456 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7457
7458 * xdisp.c (redisplay_internal): Fix prototype.
7459
7460 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7461
7462 * xdisp.c (SCROLL_LIMIT): New macro.
7463 (try_scrolling): Use it when setting scroll_limit.
7464 Limit scrolling to 100 screen lines.
7465 (redisplay_window): Even when falling back on "recentering",
7466 position point in the window according to scroll-conservatively,
7467 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7468
7469 (try_scrolling): When point is above the window, allow searching
7470 as far as scroll_max, or one screenful, to compute vertical
7471 distance from PT to the scroll margin position. This prevents
7472 try_scrolling from unnecessarily failing when
7473 scroll-conservatively is set to a value slightly larger than the
7474 window height. Clean up the case of PT below the margin at bottom
7475 of window: scroll_max can no longer be INT_MAX. When aggressive
7476 scrolling is in use, don't let point enter the opposite scroll
7477 margin as result of the scroll.
7478 (syms_of_xdisp) <scroll-conservatively>: Document the
7479 threshold of 100 lines for never-recentering scrolling.
7480
7481 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7482
7483 * dispextern.h (move_it_by_lines):
7484 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7485 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7486 (message_log_check_duplicate): Remove parameters `prev_bol' and
7487 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7488 (redisplay_internal): Remove parameter `preserve_echo_area',
7489 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7490
7491 * indent.c (Fvertical_motion):
7492 * window.c (window_scroll_pixel_based, Frecenter):
7493 Don't pass `need_y_p' to `move_it_by_lines'.
7494
7495 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7496
7497 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7498 steal a few bits to be more compact.
7499 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7500 Remove unneeded casts.
7501
7502 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7503
7504 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7505
7506 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7507 binding" message (bug#7967).
7508
7509 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7510
7511 Fix more problems found by GCC 4.6.0's static checks.
7512
7513 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7514 Remove unused local var.
7515
7516 * editfns.c (Fmessage_box): Remove unused local var.
7517
7518 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7519 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7520 Omit unused local vars.
7521 * window.c (shrink_windows): Omit unused local var.
7522 * menu.c (digest_single_submenu): Omit unused local var.
7523 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7524 Omit unused local var.
7525
7526 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7527 Don't assume string length fits in int.
7528 (keyremap_step, read_key_sequence): Use size_t for sizes.
7529 (read_key_sequence): Don't check last_real_key_start redundantly.
7530
7531 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7532 instead of alloca (Bug#8344).
7533
7534 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7535 (Fbacktrace_frame): Don't assume nframes fits in int.
7536
7537 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7538
7539 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7540 concerns.
7541
7542 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7543
7544 * cm.c (calccost): Turn while-do into do-while, for clarity.
7545
7546 * keyboard.c (syms_of_keyboard): Use the same style as later
7547 in this function when indexing through an array. This also
7548 works around GCC bug 48267.
7549
7550 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7551
7552 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7553
7554 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7555 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7556
7557 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7558 This avoids undefined behavior on integer overflow, and is a bit
7559 more convenient anyway since it is compared to a size_t variable.
7560
7561 Variadic C functions now count arguments with size_t, not int.
7562 This avoids an unnecessary limitation on 64-bit machines, which
7563 caused (substring ...) to crash on large vectors (Bug#8344).
7564 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7565 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7566 All variadic functions and their callers changed accordingly.
7567 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7568 * data.c (arith_driver, float_arith_driver): Likewise.
7569 * editfns.c (general_insert_function): Likewise.
7570 * eval.c (struct backtrace.nargs, interactive_p)
7571 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7572 (funcall_lambda, mark_backtrace): Likewise.
7573 * fns.c (concat): Likewise.
7574 * frame.c (x_set_frame_parameters): Likewise.
7575 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7576 0 if not found, not -1. All callers changed.
7577
7578 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7579 (stack_copy_size): Now size_t, not int.
7580 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7581
7582 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7583
7584 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7585 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7586 All callers changed.
7587
7588 * lisp.h (multibyte_char_to_unibyte):
7589 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7590 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7591 * character.h (CHAR_TO_BYTE8):
7592 * cmds.c (internal_self_insert):
7593 * editfns.c (general_insert_function):
7594 * keymap.c (push_key_description):
7595 * search.c (Freplace_match):
7596 * xdisp.c (message_dolog, set_message_1): All callers changed.
7597
7598 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7599
7600 * keyboard.c (safe_run_hook_funcall): New function.
7601 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7602 don't set the hook to nil, but remove the offending function instead.
7603 (Qcommand_hook_internal): Remove, unused.
7604 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7605 Vcommand_hook_internal.
7606
7607 * eval.c (enum run_hooks_condition): Remove.
7608 (funcall_nil, funcall_not): New functions.
7609 (run_hook_with_args): Call each function through a `funcall' argument.
7610 Remove `cond' argument, now redundant.
7611 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7612 (Frun_hook_with_args_until_failure): Adjust accordingly.
7613 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7614
7615 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7616
7617 * dispextern.h (string_buffer_position): Remove declaration.
7618
7619 * print.c (strout): Remove parameter `multibyte', unused since
7620 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7621
7622 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7623 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7624 All callers changed.
7625
7626 * w32.c (_wsa_errlist): Use braces for struct initializers.
7627
7628 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7629 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7630 All callers changed.
7631 (string_buffer_position): Likewise. Also, make static (it's never
7632 used outside xdisp.c).
7633 (cursor_row_p): Remove parameter `w', unused since
7634 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7635 (decode_mode_spec): Remove parameter `precision', introduced during
7636 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7637 All callers changed.
7638
7639 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7640
7641 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7642
7643 2011-03-27 Anders Lindgren <andlind@gmail.com>
7644
7645 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7646 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7647 (ns_update_auto_hide_menu_bar): New functions.
7648 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7649 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7650 ns_constrain_all_frames.
7651 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7652 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7653
7654 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7655
7656 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7657
7658 2011-03-27 Glenn Morris <rgm@gnu.org>
7659
7660 * syssignal.h: Replace RETSIGTYPE with void.
7661 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7662 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7663 Replace SIGTYPE with void everywhere.
7664 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7665 * s/template.h (SIGTYPE): Remove commented out definition.
7666
7667 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7668
7669 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7670 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7671
7672 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7673
7674 * w32.c (read_unc_volume): Use parameter `henum', instead of
7675 global variable `wget_enum_handle'.
7676
7677 * keymap.c (describe_vector): Remove parameters `indices' and
7678 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7679 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7680
7681 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7682
7683 * keyboard.c (timer_check): Remove parameter `do_it_now',
7684 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7685 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7686 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7687
7688 * keyboard.c (read_char):
7689 * w32menu.c (w32_menu_display_help):
7690 * xmenu.c (show_help_event, menu_help_callback):
7691 Adjust calls to `show_help_echo'.
7692
7693 * gtkutil.c (xg_maybe_add_timer):
7694 * keyboard.c (readable_events):
7695 * process.c (wait_reading_process_output):
7696 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7697
7698 * insdel.c (adjust_markers_gap_motion):
7699 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7700 (gap_left, gap_right): Don't call it.
7701
7702 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7703
7704 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7705 incurred during fontification.
7706
7707 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7708
7709 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7710 (DEFVAR_PER_BUFFER): Don't pass it.
7711
7712 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7713 (scrolling_window): Don't pass it.
7714
7715 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7716
7717 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7718
7719 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7720 and `suffix'.
7721 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7722 of variables specific to SELinux and computation of `encoded_absname'.
7723
7724 * image.c (XPutPixel): Remove unused variable `height'.
7725
7726 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7727
7728 * unexw32.c (get_section_info): Remove unused variable `section'.
7729
7730 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7731 (system_process_attributes): Remove unused variable `sess'.
7732 (sys_read): Remove unused variable `err'.
7733
7734 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7735 (w32_wnd_proc): Remove unused variable `isdead'.
7736 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7737 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7738 (x_create_tip_frame): Remove unused variable `tem'.
7739
7740 * w32inevt.c (w32_console_read_socket):
7741 Remove unused variable `no_events'.
7742
7743 * w32term.c (x_draw_composite_glyph_string_foreground):
7744 Remove unused variable `width'.
7745
7746 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7747
7748 * w32term.c (x_set_glyph_string_clipping):
7749 Don't pass uninitialized region to CombineRgn.
7750
7751 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7752
7753 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7754 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7755 (Fx_close_connection): Remove unused variable `i'.
7756
7757 * w32font.c (w32font_draw): Return number of glyphs.
7758 (w32font_open_internal): Remove unused variable `i'.
7759 (w32font_driver): Add missing initializer.
7760
7761 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7762 (fill_in_menu): Remove unused variable `items_added'.
7763
7764 * w32term.c (last_mouse_press_frame): Remove static global variable.
7765 (w32_clip_to_row): Remove unused variable `f'.
7766 (x_delete_terminal): Remove unused variable `i'.
7767
7768 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7769 (NOTHING): Remove unused static global variable.
7770 (uniscribe_check_otf): Remove unused variable `table'.
7771 (uniscribe_font_driver): Add missing initializers.
7772
7773 2011-03-23 Julien Danjou <julien@danjou.info>
7774
7775 * term.c (Fsuspend_tty, Fresume_tty):
7776 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7777 * window.c (temp_output_buffer_show):
7778 * insdel.c (signal_before_change):
7779 * frame.c (Fhandle_switch_frame):
7780 * fileio.c (Fdo_auto_save):
7781 * emacs.c (Fkill_emacs):
7782 * editfns.c (save_excursion_restore):
7783 * cmds.c (internal_self_insert):
7784 * callint.c (Fcall_interactively):
7785 * buffer.c (Fkill_all_local_variables):
7786 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7787 Use Frun_hooks.
7788 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7789 unconditionnaly since it does the check itself.
7790
7791 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7792
7793 Fix more problems found by GCC 4.5.2's static checks.
7794
7795 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7796 the first time through the loop, since we know p0 < p1 then.
7797 This also avoids a gcc -Wstrict-overflow warning.
7798
7799 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7800 leading to a memory leak, possible in functions like
7801 load_charset_map_from_file that can allocate an unbounded number
7802 of objects (Bug#8318).
7803
7804 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7805 that could (at least in theory) be that large.
7806
7807 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7808 This is less likely to overflow, and avoids undefined behavior if
7809 overflow does occur. All callers changed. Use strtoul to scan
7810 for the unsigned long integer.
7811 (pint2hrstr): Simplify and tune code slightly.
7812 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7813
7814 * scroll.c (do_scrolling): Work around GCC bug 48228.
7815 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7816
7817 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7818 This also avoids a warning with gcc -Wstrict-overflow.
7819 (validate_x_resource_name): Simplify count usage.
7820 This also avoids a warning with gcc -Wstrict-overflow.
7821
7822 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7823 fail (Bug#8306).
7824
7825 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7826
7827 * process.c (Fmake_network_process): Use socklen_t, not int,
7828 where POSIX says socklen_t is required in portable programs.
7829 This fixes a porting bug on hosts like 64-bit HP-UX, where
7830 socklen_t is wider than int (Bug#8277).
7831 (Fmake_network_process, server_accept_connection):
7832 (wait_reading_process_output, read_process_output):
7833 Likewise.
7834
7835 * process.c: Rename or move locals to avoid shadowing.
7836 (list_processes_1, Fmake_network_process):
7837 (read_process_output_error_handler, exec_sentinel_error_handler):
7838 Rename or move locals.
7839 (Fmake_network_process): Define label "retry_connect" only if needed.
7840 (Fnetwork_interface_info): Fix pointer signedness.
7841 (process_send_signal): Add cast to avoid pointer signedness problem.
7842 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7843 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7844
7845 Make tparam.h and terminfo.c consistent.
7846 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7847 Include tparam.h instead, since it declares them.
7848 * cm.h (PC): Remove extern decl; tparam.h now does this.
7849 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7850 * terminfo.c: Include tparam.h, to check interfaces.
7851 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7852 (tparam): Adjust signature to match interface in tparam.h;
7853 this removes some undefined behavior. Check that outstring and len
7854 are zero, which they always are with Emacs.
7855 * tparam.h (PC, BC, UP): New extern decls.
7856
7857 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7858 (xftfont_open): Rename locals to avoid shadowing.
7859
7860 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7861 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7862 (OTF_TAG_SYM): Omit macro if not needed.
7863 (ftfont_list): Remove unused local.
7864 (get_adstyle_property, ftfont_pattern_entity):
7865 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7866 Rename locals to avoid shadowing.
7867
7868 * xfont.c (xfont_list_family): Mark var as initialized.
7869
7870 * xml.c (make_dom): Now static.
7871
7872 * composite.c (composition_compute_stop_pos): Rename local to
7873 avoid shadowing.
7874 (composition_reseat_it): Remove unused locals.
7875 (find_automatic_composition, composition_adjust_point): Likewise.
7876 (composition_update_it): Mark var as initialized.
7877 (find_automatic_composition): Mark vars as initialized,
7878 with a FIXME (Bug#8290).
7879
7880 character.h: Rename locals to avoid shadowing.
7881 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7882 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7883 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7884 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7885 to avoid shadowing.
7886
7887 * textprop.c (property_change_between_p): Remove; unused.
7888
7889 * intervals.c (interval_start_pos): Now static.
7890
7891 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7892
7893 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7894 Rename locals to avoid shadowing.
7895
7896 * sound.c (wav_play, au_play, Fplay_sound_internal):
7897 Fix pointer signedness.
7898 (alsa_choose_format): Remove unused local var.
7899 (wav_play): Initialize a variable to 0, to prevent undefined
7900 behavior (Bug#8278).
7901
7902 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7903
7904 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7905
7906 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7907 clobbering (Bug#8298).
7908 * sysdep.c (sys_subshell): Likewise.
7909 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7910
7911 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7912 This should get cleaned up, so that child_setup has the
7913 same signature on all platforms.
7914
7915 * callproc.c (call_process_cleanup): Now static.
7916 (relocate_fd): Rename locals to avoid shadowing.
7917
7918 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7919
7920 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7921 not to be necessary, and produces flickering.
7922
7923 2011-03-20 Glenn Morris <rgm@gnu.org>
7924
7925 * config.in: Remove file.
7926
7927 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7928
7929 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7930 are now in src/globals.h.
7931 (syms_of_minibuf): Remove spurious & from previous change.
7932
7933 2011-03-20 Leo <sdl.web@gmail.com>
7934
7935 * minibuf.c (completing-read-function): New variable.
7936 (completing-read-default): Rename from completing-read.
7937 (completing-read): Call completing-read-function.
7938
7939 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7940
7941 * xfaces.c (Fx_load_color_file):
7942 Read color file from absolute filename (bug#8250).
7943
7944 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7945
7946 * makefile.w32-in: Update dependencies.
7947
7948 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7949
7950 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7951
7952 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7953
7954 Fix more problems found by GCC 4.5.2's static checks.
7955
7956 * process.c (make_serial_process_unwind, send_process_trap):
7957 (sigchld_handler): Now static.
7958
7959 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7960 That way, the code declares only the vars that it needs.
7961 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7962 * s/cygwin.h (PTY_ITERATION): Likewise.
7963 * s/darwin.h (PTY_ITERATION): Likewise.
7964 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7965
7966 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7967 * process.c (allocate_pty): Don't declare stb unless it's needed.
7968
7969 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7970 (CONSTANTLIM): Remove; unused.
7971 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7972 Define only if needed.
7973
7974 * unexelf.c (unexec): Name an expression,
7975 to avoid gcc -Wbad-function-cast warning.
7976 Use a different way to cause a compilation error if anyone uses
7977 n rather than nn, a way that does not involve shadowing.
7978 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7979
7980 * deps.mk (unexalpha.o): Remove; unused.
7981
7982 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7983 * unexec.h: New file.
7984 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7985 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7986 Depend on unexec.h.
7987 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7988 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7989 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7990 Change as necessary to match prototype in unexec.h.
7991
7992 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7993 shadowing.
7994 (back_comment, skip_chars): Mark vars as initialized.
7995
7996 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7997 Rename locals to avoid shadowing.
7998
7999 * lread.c (read1): Rewrite so as not to use empty "else".
8000 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8001
8002 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8003
8004 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8005 warning when compiling print.c.
8006
8007 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8008 instead of using an uninitialized var.
8009 (font_sort_entities): Mark var as initialized.
8010
8011 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8012
8013 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8014 pointers to constants.
8015 (font_parse_fcname): Remove unused vars.
8016 (font_delete_unmatched): Now static.
8017 (font_get_spec): Remove; unused.
8018 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8019 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8020 Rename or move locals to avoid shadowing.
8021
8022 * fns.c (require_nesting_list, require_unwind): Now static.
8023 (Ffillarray): Rename locals to avoid shadowing.
8024
8025 * floatfns.c (domain_error2): Define only if needed.
8026 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8027
8028 * alloc.c (mark_backtrace): Move decl from here ...
8029 * lisp.h: ... to here, so that it can be checked.
8030
8031 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8032 (Fdefvar): Rewrite so as not to use empty "else".
8033 (lisp_indirect_variable): Name an expression,
8034 to avoid gcc -Wbad-function-cast warning.
8035 (Fdefvar): Rename locals to avoid shadowing.
8036
8037 * callint.c (quotify_arg, quotify_args): Now static.
8038 (Fcall_interactively): Rename locals to avoid shadowing.
8039 Use const pointer when appropriate.
8040
8041 * lisp.h (get_system_name, get_operating_system_release):
8042 Move decls here, to check interfaces.
8043 * process.c (get_operating_system_release): Move decl to lisp.h.
8044 * xrdb.c (get_system_name): Likewise.
8045 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8046 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8047 some of which prompt warnings from gcc -Wbad-function-cast.
8048 (Fformat_time_string, Fencode_time, Finsert_char):
8049 (Ftranslate_region_internal, Fformat):
8050 Rename or remove local vars to avoid shadowing.
8051 (Ftranslate_region_internal): Mark var as initialized.
8052
8053 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8054 avoid shadowing.
8055
8056 * lisp.h (eassert): Check that the argument compiles, even if
8057 ENABLE_CHECKING is not defined.
8058
8059 * data.c (Findirect_variable): Name an expression, to avoid
8060 gcc -Wbad-function-cast warning.
8061 (default_value, arithcompare, arith_driver, arith_error): Now static.
8062 (store_symval_forwarding): Rename local to avoid shadowing.
8063 (Fmake_variable_buffer_local, Fmake_local_variable):
8064 Mark variables as initialized.
8065 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8066
8067 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8068 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8069 Rename locals to avoid shadowing.
8070 (mark_stack): Move local variables into the #ifdef region where
8071 they're used.
8072 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8073 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8074 needed otherwise.
8075 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8076 (GC_STRING_CHARS): Remove; not used.
8077 (Fmemory_limit): Cast sbrk's returned value to char *.
8078
8079 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8080 avoids undefined behavior in theory.
8081
8082 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8083
8084 Use functions, not macros, for up- and down-casing (Bug#8254).
8085 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8086 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8087 to use the following functions instead of these macros.
8088 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8089 EMACS_INT, since callers assume the returned value fits in int.
8090 (upcase1): Likewise, for UPCASE_TABLE.
8091 (uppercasep, lowercasep, upcase): New static inline functions.
8092 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8093 the race-condition problem in the old DOWNCASE.
8094
8095 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8096 Rename locals to avoid shadowing.
8097 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8098 (regex_compile, re_search_2, re_match_2_internal):
8099 Remove unused local vars.
8100 (FREE_VAR): Rewrite so as not to use empty "else",
8101 which gcc can warn about.
8102 (regex_compile, re_match_2_internal): Mark locals as initialized.
8103 (RETALLOC_IF): Define only if needed.
8104 (WORDCHAR_P): Likewise. This one is never needed, but is used
8105 only in a comment talking about a compiler bug, so put inside
8106 the #if 0 of that comment.
8107 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8108 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8109 Remove; unused.
8110
8111 * search.c (boyer_moore): Rename locals to avoid shadowing.
8112 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8113 (PREV_CHAR_BOUNDARY): Likewise.
8114
8115 * search.c (simple_search): Remove unused var.
8116
8117 * dired.c (compile_pattern): Move decl from here ...
8118 * lisp.h: ... to here, so that it can be checked.
8119 (struct re_registers): New forward decl.
8120
8121 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8122
8123 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8124 All uses changed.
8125 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8126 Rename locals to avoid shadowing.
8127 (Fvertical_motion): Mark locals as initialized.
8128
8129 * casefiddle.c (casify_object, casify_region): Now static.
8130 (casify_region): Mark local as initialized.
8131
8132 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8133
8134 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8135 New macros, so that the caller can use some names other than
8136 gcpro1, gcpro2, etc.
8137 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8138 of the new macros.
8139 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8140 argument, for consistency with GCPRO2_VAR, etc: it is now the
8141 prefix of the variable, not the variable itself. All uses
8142 changed.
8143 * dired.c (directory_files_internal, file_name_completion):
8144 Rename locals to avoid shadowing.
8145
8146 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8147 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8148 dired.c's scmp function, had undefined behavior.
8149 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8150 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8151 * buffer.h: ... to here, because these macros use current_buffer,
8152 and the new implementation with inline functions needs to have
8153 current_buffer in scope now, rather than later when the macros
8154 are used.
8155 (downcase, upcase1): New static inline functions.
8156 (DOWNCASE, UPCASE1): Reimplement using these functions.
8157 This avoids undefined behavior in expressions like
8158 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8159 from race conditions in accessing the global variables
8160 case_temp1 and case_temp2.
8161 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8162 * lisp.h (case_temp1, case_temp2): Remove their decls.
8163 * character.h (ASCII_CHAR_P): Move from here ...
8164 * lisp.h: ... to here, so that the inline functions mentioned
8165 above can use them.
8166
8167 * dired.c (directory_files_internal_unwind): Now static.
8168
8169 * fileio.c (file_name_as_directory, directory_file_name):
8170 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8171 Now static.
8172 (file_name_as_directory): Use const pointers when appropriate.
8173 (Fexpand_file_name): Likewise. In particular, newdir might
8174 point at constant storage, so make it a const pointer.
8175 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8176 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8177 signedness issues.
8178 (Fset_file_times, Finsert_file_contents, auto_save_error):
8179 Rename locals to avoid shadowing.
8180
8181 * minibuf.c (choose_minibuf_frame_1): Now static.
8182 (Ftry_completion, Fall_completions): Rename or remove locals
8183 to avoid shadowing.
8184
8185 * marker.c (bytepos_to_charpos): Remove; unused.
8186
8187 * lisp.h (verify_bytepos, count_markers): New decls,
8188 so that gcc does not warn that these functions aren't declared.
8189
8190 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8191 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8192 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8193 (copy_text): Remove unused local var.
8194
8195 * filelock.c (within_one_second): Now static.
8196 (lock_file_1): Rename local to avoid shadowing.
8197
8198 * buffer.c (fix_overlays_before): Mark locals as initialized.
8199 (fix_start_end_in_overlays): Likewise. This function should be
8200 simplified by using pointers-to-pointers, but that's a different
8201 matter.
8202 (switch_to_buffer_1): Now static.
8203 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8204 (report_overlay_modification): Rename locals to avoid shadowing.
8205
8206 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8207 Fix pointer signedness issue.
8208 (sys_subshell): Mark local as volatile if checking for lint,
8209 to suppress a gcc -Wclobbered warning that does not seem to be right.
8210 (MAXPATHLEN): Define only if needed.
8211
8212 * process.c (serial_open, serial_configure): Move decls from here ...
8213 * systty.h: ... to here, so that they can be checked.
8214
8215 * fns.c (get_random, seed_random): Move extern decls from here ...
8216 * lisp.h: ... to here, so that they can be checked.
8217
8218 * sysdep.c (reset_io): Now static.
8219 (wait_for_termination_signal): Remove; unused.
8220
8221 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8222 (copy_keymap_item, append_key, push_text_char_description):
8223 Now static.
8224 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8225 (DENSE_TABLE_SIZE): Remove; unused.
8226 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8227 (describe_map_tree):
8228 Rename locals to avoid shadowing.
8229
8230 * keyboard.c: Declare functions static if they are not used elsewhere.
8231 (echo_char, echo_dash, cmd_error, top_level_2):
8232 (poll_for_input, handle_async_input): Now static.
8233 (read_char, kbd_buffer_get_event, make_lispy_position):
8234 (make_lispy_event, make_lispy_movement, apply_modifiers):
8235 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8236 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8237 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8238 (read_key_sequence, read_char): Mark locals as initialized.
8239 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8240
8241 * keyboard.h (make_ctrl_char): New decl.
8242 (mark_kboards): Move decl here ...
8243 * alloc.c (mark_kboards): ... from here.
8244
8245 * lisp.h (force_auto_save_soon): New decl.
8246
8247 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8248 (DEFINE_DUMMY_FUNCTION): New macro.
8249 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8250 Use it.
8251 (main): Add casts to avoid warnings
8252 if GCC considers string literals to be constants.
8253
8254 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8255
8256 * dbusbind.c: Pointer signedness fixes.
8257 (xd_signature, xd_append_arg, xd_initialize):
8258 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8259 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8260 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8261 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8262
8263 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8264 if GCC considers string literals to be constants.
8265 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8266
8267 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8268
8269 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8270 (print_preprocess, print_object): New macro to fix last change.
8271
8272 * print.c (print_preprocess): Don't forget font objects.
8273
8274 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8275
8276 * emacs.c (USAGE3): Doc fixes.
8277
8278 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8279
8280 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8281 structure.
8282
8283 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8284
8285 * lisp.h (VWindow_system, Qfile_name_history):
8286 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8287 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8288 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8289
8290 * w32select.c: Don't #include "keyboard.h".
8291 (run_protected): Add extern declaration for waiting_for_input.
8292
8293 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8294 * w32console.c (detect_input_pending, read_input_pending)
8295 (encode_terminal_code):
8296 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8297 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8298 (w32_system_caret_y, Qfile_name_history):
8299 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8300 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8301 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8302 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8303 * w32proc.c (Qlocal, report_file_error):
8304 * w32term.c (Vwindow_system, updating_frame):
8305 * w32uniscribe.c (initialized, uniscribe_font_driver):
8306 Remove unneeded extern declarations.
8307
8308 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8309
8310 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8311
8312 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8313
8314 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8315 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8316 These macros can no longer be used for assignment.
8317
8318 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8319 Assign struct members directly, instead of using BUF_BEGV etc.
8320 (record_buffer_markers, fetch_buffer_markers): New functions for
8321 recording and fetching special buffer markers.
8322 (set_buffer_internal_1, set_buffer_temp): Use them.
8323
8324 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8325
8326 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8327
8328 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8329 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8330
8331 * xdisp.c (hscroll_window_tree):
8332 (reconsider_clip_changes): Use PT instead of BUF_PT.
8333
8334 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8335
8336 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8337 $(EMACS_ROOT)/lib/intprops.h.
8338
8339 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8340
8341 Fix more problems found by GCC 4.5.2's static checks.
8342
8343 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8344 to unsigned char * to avoid compiler diagnostic.
8345 (xg_free_frame_widgets): Make it clear that a local variable is
8346 needed only if USE_GTK_TOOLTIP.
8347 (gdk_window_get_screen): Make it clear that this macro is needed
8348 only if USE_GTK_TOOLTIP.
8349 (int_gtk_range_get_value): New function, which avoids a diagnostic
8350 from gcc -Wbad-function-cast.
8351 (xg_set_toolkit_scroll_bar_thumb): Use it.
8352 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8353 diagnostic from gcc -Wbad-function-cast.
8354 (get_utf8_string, xg_get_file_with_chooser):
8355 Rename locals to avoid shadowing.
8356 (create_dialog): Move locals to avoid shadowing.
8357
8358 * xgselect.c (xg_select): Remove unused var.
8359
8360 * image.c (four_corners_best): Mark locals as initialized.
8361 (gif_load): Initialize transparent_p to zero (Bug#8238).
8362 Mark another local as initialized.
8363 (my_png_error, my_error_exit): Mark with NO_RETURN.
8364
8365 * image.c (clear_image_cache): Now static.
8366 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8367 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8368 (x_edge_detection): Remove unnecessary cast that
8369 gcc -Wbad-function-cast diagnoses.
8370 (gif_load): Fix pointer signedness.
8371 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8372 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8373
8374 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8375
8376 Improve quality of tests for time stamp overflow.
8377 For example, without this patch (encode-time 0 0 0 1 1
8378 1152921504606846976) returns the obviously-bogus value (-948597
8379 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8380 reports time overflow. See
8381 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8382 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8383 * editfns.c: Include limits.h and intprops.h.
8384 (TIME_T_MIN, TIME_T_MAX): New macros.
8385 (time_overflow): Move earlier, to before first use.
8386 (hi_time, lo_time): New functions, for an accurate test for
8387 out-of-range times.
8388 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8389 (Fget_internal_run_time): Don't assume time_t fits in int.
8390 (make_time): Use list2 instead of Fcons twice.
8391 (Fdecode_time): More accurate test for out-of-range times.
8392 (check_tm_member): New function.
8393 (Fencode_time): Use it, to test for out-of-range times.
8394 (lisp_time_argument): Don't rely on undefined left-shift and
8395 right-shift behavior when checking for time stamp overflow.
8396
8397 * editfns.c (time_overflow): New function, refactoring common code.
8398 (Fformat_time_string, Fdecode_time, Fencode_time):
8399 (Fcurrent_time_string): Use it.
8400
8401 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8402 * dired.c (make_time): Move to ...
8403 * editfns.c (make_time): ... here.
8404 * systime.h: Note the move.
8405
8406 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8407
8408 * fringe.c (update_window_fringes): Remove unused variables.
8409
8410 * unexmacosx.c (copy_data_segment): Also copy __got section.
8411 (Bug#8223)
8412
8413 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8414
8415 * termcap.c [MSDOS]: Include "msdos.h".
8416 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8417 Constify `char *' arguments and their references according to
8418 prototypes in tparam.h.
8419
8420 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8421
8422 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8423 Adapt all references accordingly.
8424
8425 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8426
8427 2011-03-11 Tom Tromey <tromey@redhat.com>
8428
8429 * buffer.c (syms_of_buffer): Remove obsolete comment.
8430
8431 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8432
8433 * termhooks.h (encode_terminal_code): Declare prototype.
8434
8435 * msdos.c (encode_terminal_code): Don't declare prototype.
8436
8437 * term.c (encode_terminal_code): Now external again, used by
8438 w32console.c and msdos.c.
8439
8440 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8441 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8442
8443 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8444
8445 Fix some minor problems found by GCC 4.5.2's static checks.
8446
8447 * fringe.c (update_window_fringes): Mark locals as initialized
8448 (Bug#8227).
8449 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8450
8451 * alloc.c (mark_fringe_data): Move decl from here ...
8452 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8453 to check its interface.
8454 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8455
8456 * fontset.c (free_realized_fontset): Now static.
8457 (Fset_fontset_font): Rename local to avoid shadowing.
8458 (fontset_font): Mark local as initialized.
8459 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8460
8461 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8462
8463 * xselect.c (x_disown_buffer_selections): Remove; not used.
8464 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8465 (x_own_selection, Fx_disown_selection_internal): Rename locals
8466 to avoid shadowing.
8467 (x_handle_dnd_message): Remove local to avoid shadowing.
8468
8469 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8470 so that the caller can use some name other than gcpro1.
8471 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8472 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8473 (Fx_backspace_delete_keys_p):
8474 Use them to avoid shadowing, and rename vars to avoid shadowing.
8475 (x_decode_color, x_set_name, x_window): Now static.
8476 (Fx_create_frame): Add braces to silence GCC warning.
8477 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8478 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8479 Remove unused locals.
8480 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8481 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8482 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8483 macros.
8484
8485 * xterm.h (x_mouse_leave): New decl.
8486
8487 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8488 Remove unused functions.
8489 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8490 (x_calc_absolute_position): Now static.
8491 (XTread_socket): Don't define label "out" unless it's used.
8492 Don't declare local "event" unless it's used.
8493 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8494 unless they are used.
8495 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8496 (x_fatal_error_signal): Remove; not used.
8497 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8498 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8499 (x_error_catcher, x_connection_closed, x_error_handler):
8500 (x_error_quitter, xembed_send_message, x_iconify_frame):
8501 (my_log_handler): Rename locals to avoid shadowing.
8502 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8503 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8504
8505 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8506 Rename or move locals to avoid shadowing.
8507 (tty_defined_color, merge_face_heights): Now static.
8508 (free_realized_faces_for_fontset): Remove; not used.
8509 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8510 does not deduce is never used uninitialized.
8511 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8512 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8513
8514 * terminal.c (store_terminal_param): Now static.
8515
8516 * xmenu.c (menu_highlight_callback): Now static.
8517 (set_frame_menubar): Remove unused local.
8518 (xmenu_show): Rename parameter to avoid shadowing.
8519 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8520 since they might point to immutable storage.
8521 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8522 since it's unused otherwise.
8523
8524 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8525 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8526 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8527 avoids a gcc -Wuninitialized diagnostic.
8528 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8529 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8530 does not deduce are never used uninitialized.
8531
8532 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8533
8534 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8535 * window.c (window_loop, size_window):
8536 (run_window_configuration_change_hook, enlarge_window): Likewise.
8537
8538 * window.c (display_buffer): Now static.
8539 (size_window): Mark variables that gcc -Wuninitialized
8540 does not deduce are never used uninitialized.
8541 * window.h (check_all_windows): New decl, to forestall
8542 gcc -Wmissing-prototypes diagnostic.
8543 * dispextern.h (bidi_dump_cached_states): Likewise.
8544
8545 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8546 shadowing.
8547 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8548 Include <limits.h>.
8549 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8550 and to avoid gcc -Wuninitialized warning.
8551 (load_charset_map): Mark variables that gcc -Wuninitialized
8552 does not deduce are never used uninitialized.
8553 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8554
8555 * coding.c (coding_set_source, coding_set_destination):
8556 Use "else { /* comment */ }" rather than "else /* comment */;"
8557 for clarity, and to avoid gcc -Wempty-body warning.
8558 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8559 a block, when the outer 'i' will do.
8560 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8561 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8562 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8563 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8564 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8565 Rename locals to avoid shadowing.
8566 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8567 * coding.c (emacs_mule_char, encode_invocation_designation):
8568 Now static, since they're not used elsewhere.
8569 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8570 (decode_coding_object, encode_coding_object, detect_coding_system):
8571 (decode_coding_emacs_mule): Mark variables that gcc
8572 -Wuninitialized does not deduce are never used uninitialized.
8573 (detect_coding_iso_2022): Initialize a local variable that might
8574 be used uninitialized. Leave a FIXME because it's not clear that
8575 this initialization is needed. (Bug#8211)
8576 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8577 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8578 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8579 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8580 Remove unused macros.
8581
8582 * category.c (hash_get_category_set): Remove unused local var.
8583 (copy_category_table): Now static, since it's not used elsewhere.
8584 * character.c (string_count_byte8): Likewise.
8585
8586 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8587 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8588
8589 * chartab.c (copy_sub_char_table): Now static, since it's not used
8590 elsewhere.
8591 (sub_char_table_ref_and_range, char_table_ref_and_range):
8592 Rename locals to avoid shadowing.
8593 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8594
8595 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8596 (BIDI_BOB): Remove unused macro.
8597
8598 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8599 deduce are never used uninitialized.
8600 * term.c (encode_terminal_code): Likewise.
8601
8602 * term.c (encode_terminal_code): Now static. Remove unused local.
8603
8604 * tparam.h: New file.
8605 * term.c, tparam.h: Include it.
8606 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8607 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8608 Move these decls to tparam.h, and make them agree with what
8609 is actually in tparam.c. The previous trick of using incompatible
8610 decls in different modules does not conform to the C standard.
8611 All callers of tparam changed to use tparam's actual API.
8612 * tparam.c (tparam1, tparam, tgoto):
8613 Use const pointers where appropriate.
8614
8615 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8616 * cm.h (struct cm): Likewise.
8617 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8618 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8619 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8620 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8621 (turn_on_face, init_tty): Likewise.
8622 * termchar.h (struct tty_display_info): Likewise.
8623
8624 * term.c (term_mouse_position): Rename local to avoid shadowing.
8625
8626 * alloc.c (mark_ttys): Move decl from here ...
8627 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8628
8629 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8630
8631 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8632
8633 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8634
8635 * search.c (compile_pattern_1): Remove argument regp, unused since
8636 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8637 (compile_pattern): Don't pass it.
8638
8639 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8640
8641 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8642 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8643 for ! HAVE_GTK3.
8644 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8645
8646 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8647
8648 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8649 gdk_window_get_screen, gdk_window_get_geometry,
8650 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8651 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8652 (xg_get_pixbuf_from_pixmap): New function.
8653 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8654 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8655 Call xg_get_pixbuf_from_pixmap instead of
8656 gdk_pixbuf_get_from_drawable.
8657 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8658 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8659 (xg_check_special_colors): Use GtkStyleContext and its functions
8660 for HAVE_GTK3.
8661 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8662 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8663 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8664 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8665 Call gtk_widget_get_preferred_size.
8666 (xg_frame_resized): gdk_window_get_geometry only takes 5
8667 parameters.
8668 (xg_win_to_widget, xg_event_is_for_menubar):
8669 Call gdk_x11_window_lookup_for_display.
8670 (xg_set_widget_bg): New function.
8671 (delete_cb): New function.
8672 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8673 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8674 (xg_set_background_color): Call xg_set_widget_bg.
8675 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8676 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8677 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8678 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8679 if ! HAVE_GTK3.
8680 (update_frame_tool_bar): Call gtk_widget_hide.
8681 (xg_initialize): Use GDK_KEY_g.
8682
8683 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8684 if ! HAVE_GTK3
8685 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8686
8687 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8688 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8689 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8690
8691 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8692
8693 * w32xfns.c (select_palette): Check success of RealizePalette against
8694 GDI_ERROR, not zero.
8695
8696 See ChangeLog.11 for earlier changes.
8697
8698 ;; Local Variables:
8699 ;; coding: utf-8
8700 ;; End:
8701
8702 Copyright (C) 2011 Free Software Foundation, Inc.
8703
8704 This file is part of GNU Emacs.
8705
8706 GNU Emacs is free software: you can redistribute it and/or modify
8707 it under the terms of the GNU General Public License as published by
8708 the Free Software Foundation, either version 3 of the License, or
8709 (at your option) any later version.
8710
8711 GNU Emacs is distributed in the hope that it will be useful,
8712 but WITHOUT ANY WARRANTY; without even the implied warranty of
8713 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8714 GNU General Public License for more details.
8715
8716 You should have received a copy of the GNU General Public License
8717 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.