1 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3 * xfont.c (xfont_match): Avoid need for strlen.
5 * xfns.c: Don't assume strlen fits in int.
6 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9 not unsigned long, as we prefer signed integers. All callers changed.
10 Detect integer overflow in repeat count.
11 (message_dolog): Don't assume print length fits in 39 bytes.
12 (display_mode_element): Don't assume strlen fits in int.
14 * termcap.c: Don't assume sizes fit in int and never overflow.
15 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
16 (gobble_line): Check for size-calculation overflow.
18 * minibuf.c (Fread_buffer):
19 * lread.c (intern, intern_c_string):
20 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
21 Don't assume string length fits in int.
23 * keyboard.c (parse_tool_bar_item):
24 * gtkutil.c (style_changed_cb): Avoid need for strlen.
26 * font.c: Don't assume string length fits in int.
27 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
28 Use ptrdiff_t, not int.
29 (font_intern_prop): Don't assume string length fits in int.
30 Don't assume integer property fits in fixnum.
31 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
33 * filelock.c: Fix some buffer overrun and integer overflow issues.
34 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
35 Reformulate so as not to need the command string.
36 Invoke gzip -cd rather than gunzip, as it's more portable.
37 (lock_info_type, lock_file_1, lock_file):
38 Don't assume pid_t and time_t fit in unsigned long.
39 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
40 (current_lock_owner): Prefer signed type for sizes.
41 Use memcpy, not strncpy, where memcpy is what is really wanted.
42 Don't assume (via atoi) that time_t and pid_t fit in int.
43 Check for time_t and/or pid_t out of range, e.g., via a network share.
44 Don't alloca where an auto var works fine.
46 * fileio.c: Fix some integer overflow issues.
47 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
48 Don't assume string length fits in int.
49 (directory_file_name): Don't assume string length fits in long.
50 (make_temp_name): Don't assume pid fits in int, or that its print
51 length is less than 20.
53 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
55 * coding.c (make_subsidiaries): Don't assume string length fits in int.
57 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
59 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
60 We prefer signed integers, even for size calculations.
62 * emacs.c: Don't assume string length fits in 'int'.
63 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
64 (main): Don't invoke strlen when not needed.
66 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
67 (XD_DEBUG_MESSAGE): Don't waste a byte.
69 * callproc.c (getenv_internal_1, getenv_internal)
71 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
73 * lread.c (invalid_syntax): Omit length argument.
74 All uses changed. This doesn't fix a bug, but it simplifies the
75 code away from its former Hollerith-constant appearance, and it's
76 one less 'int' to worry about when looking at integer-overflow issues.
77 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
79 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
80 This didn't break anything, but it didn't help either.
81 It's confusing to put a bogus integer in a place where the actual
82 value does not matter.
83 (LIST_END_P): Remove unused macro and its bogus comment.
84 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
86 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
87 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
89 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
90 We prefer signed types, and the value cannot exceed the EMACS_INT
91 range anyway (because otherwise the length would not be representable).
92 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
93 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
94 This avoids a GCC warning when WIDE_EMACS_INT.
96 * indent.c (sane_tab_width): New function.
97 (current_column, scan_for_column, Findent_to, position_indentation)
98 (compute_motion): Use it. This is just for clarity.
99 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
101 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
103 * lisp.h (lint_assume): New macro.
104 * composite.c (composition_gstring_put_cache):
105 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
107 * editfns.c, insdel.c:
108 Omit unnecessary forward decls, to simplify future changes.
110 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
112 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
114 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
115 Use much-faster test for byte-length change.
116 Don't assume string byte-length fits in 'int'.
117 Check that character arg fits in 'int'.
118 (mapcar1): Declare byte as byte, for clarity.
120 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
122 * fns.c (concat): Catch string overflow earlier.
123 Do not rely on integer wraparound.
125 * dispextern.h (struct it.overlay_strings_charpos)
126 (struct it.selective): Now EMACS_INT, not int.
127 * xdisp.c (forward_to_next_line_start)
128 (back_to_previous_visible_line_start)
129 (reseat_at_next_visible_line_start, next_element_from_buffer):
130 Don't arbitrarily truncate the value of 'selective' to int.
132 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
134 * composite.c: Don't truncate sizes to 'int'.
135 (composition_gstring_p, composition_reseat_it)
136 (composition_adjust_point): Use EMACS_INT, not int.
137 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
138 not EMACS_UINT, for indexes.
140 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
142 * buffer.c: Include <verify.h>.
143 (struct sortvec.priority, struct sortstr.priority):
144 Now EMACS_INT, not int.
145 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
146 (struct sortstr.size, record_overlay_string)
147 (struct sortstrlist.size, struct sortlist.used):
148 Don't truncate size to int.
149 (record_overlay_string): Check for size-calculation overflow.
150 (init_buffer_once): Check at compile-time, not run-time.
152 2011-06-20 Deniz Dogan <deniz@dogan.se>
154 * process.c (Fset_process_buffer): Clarify return value in
157 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
159 * dispnew.c (add_window_display_history): Use BVAR.
161 * xdisp.c (debug_method_add): Use BVAR.
162 (check_window_end, dump_glyph_matrix, dump_glyph)
163 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
165 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
168 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
169 check till after the cache is created in init_frame_faces.
171 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
173 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
175 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
177 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
178 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
179 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
181 Improve buffer-overflow checking (Bug#8873).
182 * fileio.c (Finsert_file_contents):
183 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
184 Remove the old (too-loose) buffer overflow checks.
185 They weren't needed, since make_gap checks for buffer overflow.
186 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
187 The old code merely checked for Emacs fixnum overflow, and relied
188 on undefined (wraparound) behavior. The new code avoids undefined
189 behavior, and also checks for ptrdiff_t and/or size_t overflow.
191 * editfns.c (Finsert_char): Don't dump core with very negative counts.
192 Tune. Don't use wider integers than needed. Don't use alloca.
193 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
195 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
197 * insdel.c, lisp.h (buffer_overflow): New function.
198 (insert_from_buffer_1, replace_range, replace_range_2):
199 * insdel.c (make_gap_larger):
200 * editfns.c (Finsert_char):
201 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
203 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
205 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
207 Integer overflow and signedness fixes (Bug#8873).
209 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
210 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
212 * fileio.c: Don't assume EMACS_INT fits in off_t.
213 (emacs_lseek): New static function.
214 (Finsert_file_contents, Fwrite_region): Use it.
215 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
217 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
219 * fns.c: Don't overflow int when computing a list length.
220 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
221 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
222 truncation on 64-bit hosts. Check for QUIT every
223 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
224 faster and is responsive enough.
225 (Flength): Report an error instead of overflowing an integer.
226 (Fsafe_length): Return a float if the value is not representable
227 as a fixnum. This shouldn't happen except in contrived situations.
228 (Fnthcdr, Fsort): Don't assume list length fits in int.
229 (Fcopy_sequence): Don't assume vector length fits in int.
231 * alloc.c: Check that resized vectors' lengths fit in fixnums.
232 (header_size, word_size): New constants.
233 (allocate_vectorlike): Don't check size overflow here.
234 (allocate_vector): Check it here instead, since this is the only
235 caller of allocate_vectorlike that could cause overflow.
236 Check that the new vector's length is representable as a fixnum.
238 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
239 The previous code was bogus. For example, next_almost_prime (32)
240 returned 39, which is undesirable as it is a multiple of 3; and
241 next_almost_prime (24) returned 25, which is a multiple of 5 so
242 why was the code bothering to check for multiples of 7?
244 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
246 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
248 Variadic C functions now count arguments with ptrdiff_t.
249 This partly undoes my 2011-03-30 change, which replaced int with size_t.
250 Back then I didn't know that the Emacs coding style prefers signed int.
251 Also, in the meantime I found a few more instances where arguments
252 were being counted with int, which may truncate counts on 64-bit
253 machines, or EMACS_INT, which may be unnecessarily wide.
254 * lisp.h (struct Lisp_Subr.function.aMANY)
255 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
256 Arg counts are now ptrdiff_t, not size_t.
257 All variadic functions and their callers changed accordingly.
258 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
259 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
260 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
261 * callint.c (Fcall_interactively): Check arg count for overflow,
262 to avoid potential buffer overrun. Use signed char, not 'int',
263 for 'varies' array, so that we needn't bother to check its size
264 calculation for overflow.
265 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
266 * eval.c (apply_lambda):
267 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
268 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
269 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
271 * callint.c (Fcall_interactively): Don't use index var as event count.
273 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
274 * mem-limits.h (SIZE): Remove; no longer used.
276 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
278 Remove unnecessary casts.
279 * xterm.c (x_term_init):
280 * xfns.c (x_set_border_pixel):
281 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
282 These aren't needed now that we assume ANSI C.
284 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
285 It's more likely to cause problems (due to unsigned overflow)
288 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
290 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
292 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
294 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
296 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
298 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
300 GLYPH_CODE_FACE returns EMACS_INT, not int.
301 * dispextern.h (merge_faces):
302 * xfaces.c (merge_faces):
303 * xdisp.c (get_next_display_element, next_element_from_display_vector):
304 Don't assume EMACS_INT fits in int.
306 * character.h (CHAR_VALID_P): Remove unused parameter.
307 * fontset.c, lisp.h, xdisp.c: All uses changed.
309 * editfns.c (Ftranslate_region_internal): Omit redundant test.
311 * fns.c (concat): Minor tuning based on overflow analysis.
312 This doesn't fix any bugs. Use int to hold character, instead
313 of constantly refetching from Emacs object. Use XFASTINT, not
314 XINT, for value known to be a character. Don't bother comparing
315 a single byte to 0400, as it's always less.
317 * floatfns.c (Fexpt):
318 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
320 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
323 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
325 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
326 Without this fix, on a 64-bit host (aset S 0 4294967386) would
327 incorrectly succeed when S was a string, because 4294967386 was
328 truncated before it was used.
330 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
331 Otherwise, an out-of-range integer could cause undefined behavior
334 * composite.c: Use int, not EMACS_INT, for characters.
335 (fill_gstring_body, composition_compute_stop_pos): Use int, not
336 EMACS_INT, for values that are known to be in character range.
337 This doesn't fix any bugs but is the usual style inside Emacs and
338 may generate better code on 32-bit machines.
340 Make sure a 64-bit char is never passed to ENCODE_CHAR.
341 This is for reasons similar to the recent CHAR_STRING fix.
342 * charset.c (Fencode_char): Check that character arg is actually
343 a character. Pass an int to ENCODE_CHAR.
344 * charset.h (ENCODE_CHAR): Verify that the character argument is no
345 wider than 'int', as a compile-time check to prevent future regressions
348 * character.c (char_string): Remove unnecessary casts.
350 Make sure a 64-bit char is never passed to CHAR_STRING.
351 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
352 by silently ignoring the top 32 bits, allowing some values
353 that were far too large to be valid characters.
354 * character.h: Include <verify.h>.
355 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
356 arguments are no wider than unsigned, as a compile-time check
357 to prevent future regressions in this area.
359 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
360 (Fsubst_char_in_region):
362 * xdisp.c (decode_mode_spec_coding):
363 Adjust to CHAR_STRING's new requirement.
364 * editfns.c (Finsert_char, Fsubst_char_in_region):
365 * fns.c (concat): Check that character args are actually
366 characters. Without this test, these functions did the wrong
367 thing with wildly out-of-range values on 64-bit hosts.
369 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
370 These casts should not be needed on 32-bit hosts, either.
371 * keyboard.c (read_char):
372 * lread.c (Fload): Remove casts to unsigned.
374 * lisp.h (UNSIGNED_CMP): New macro.
375 This fixes comparison bugs on 64-bit hosts.
376 (ASCII_CHAR_P): Use it.
377 * casefiddle.c (casify_object):
378 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
379 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
380 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
381 * dispextern.h (FACE_FROM_ID):
382 * keyboard.c (read_char): Use UNSIGNED_CMP.
384 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
385 not to EMACS_INT, to avoid GCC warning.
387 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
389 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
390 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
391 isn't needed on 32-bit machines.
393 * buffer.c (Fgenerate_new_buffer_name):
394 Use EMACS_INT for count, not int.
395 (advance_to_char_boundary): Return EMACS_INT, not int.
397 * data.c (Qcompiled_function): Now static.
399 * window.c (window_body_lines): Now static.
401 * image.c (gif_load): Rename local to avoid shadowing.
403 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
404 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
405 * alloc.c (make_save_value): Integer argument is now of type
407 (mark_object): Use ptrdiff_t, not int.
408 * lisp.h (pD): New macro.
409 * print.c (print_object): Use it.
411 * alloc.c: Use EMACS_INT, not int, to count objects.
412 (total_conses, total_markers, total_symbols, total_vector_size)
413 (total_free_conses, total_free_markers, total_free_symbols)
414 (total_free_floats, total_floats, total_free_intervals)
415 (total_intervals, total_strings, total_free_strings):
416 Now EMACS_INT, not int. All uses changed.
417 (Fgarbage_collect): Compute overall total using a double, so that
418 integer overflow is less likely to be a problem. Check for overflow
419 when converting back to an integer.
420 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
421 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
422 These were 'int' variables that could overflow on 64-bit hosts;
423 they were never used, so remove them instead of repairing them.
424 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
425 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
426 Previously, this ceilinged at INT_MAX, but that doesn't work on
428 (allocate_pseudovector): Don't use EMACS_INT when int would do.
430 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
431 (allocate_vectorlike): Check for ptrdiff_t overflow.
432 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
433 when a (possibly-narrower) signed value would do just as well.
434 We prefer using signed arithmetic, to avoid comparison confusion.
436 * alloc.c: Catch some string size overflows that we were missing.
437 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
438 for convenience in STRING_BYTES_MAX.
439 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
440 The definition here is exact; the one in lisp.h was approximate.
441 (allocate_string_data): Check for string overflow. This catches
442 some instances we weren't catching before. Also, it catches
443 size_t overflow on (unusual) hosts where SIZE_MAX <= min
444 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
445 and ptrdiff_t and EMACS_INT are both 64 bits.
447 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
448 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
449 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
451 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
453 * alloc.c (Fmake_string): Check for out-of-range init.
455 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
457 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
459 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
461 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
462 xg_get_default_scrollbar_width.
464 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
465 (int_gtk_range_get_value): Move to the scroll bar part of the file.
466 (style_changed_cb): Call update_theme_scrollbar_width and call
467 x_set_scroll_bar_default_width and xg_frame_set_char_size for
468 all frames (Bug#8505).
469 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
470 Call gtk_window_set_resizable if HAVE_GTK3.
471 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
472 and height if HAVE_GTK3 (Bug#8505).
473 (scroll_bar_width_for_theme): New variable.
474 (update_theme_scrollbar_width): New function.
475 (xg_get_default_scrollbar_width): Move code to
476 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
477 (xg_initialize): Call update_theme_scrollbar_width.
479 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
481 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
483 2011-06-12 Martin Rudalics <rudalics@gmx.at>
485 * frame.c (make_frame): Call other_buffer_safely instead of
488 * window.c (temp_output_buffer_show): Call display_buffer with
489 second argument Vtemp_buffer_show_specifiers and reset latter
490 immediately after the call.
491 (Vtemp_buffer_show_specifiers): New variable.
492 (auto_window_vscroll_p, next_screen_context_lines)
493 (Vscroll_preserve_screen_position): Remove leading asterisks from
496 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
498 Fix minor problems found by GCC 4.6.0 static checking.
499 * buffer.c (Qclone_number): Remove for now, as it's unused.
500 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
501 (record_buffer): Remove unused local.
502 * frame.c (other_visible_frames, frame_buffer_list): Now static.
503 (set_frame_buffer_list): Remove; unused.
504 * frame.h (other_visible_frames): Remove decl.
505 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
506 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
507 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
509 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
510 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
511 Define only if HAVE_GPM.
512 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
513 (update_hints_inhibit): Remove; never set. All uses removed.
514 * widgetprv.h (emacsFrameClassRec): Remove decl.
515 * window.c (delete_deletable_window): Now returns void, since it
516 wasn't returning anything.
517 (compare_window_configurations): Remove unused locals.
518 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
519 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
520 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
521 the same widths as pointers. This follows up on the 2011-05-06 patch.
522 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
524 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
526 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
528 * makefile.w32-in: Update dependencies.
529 (LISP_H): Add lib/intprops.h.
531 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
533 * image.c (gif_load): Add animation frame delay to the metadata.
534 (syms_of_image): Use DEFSYM. New symbol `delay'.
536 2011-06-11 Martin Rudalics <rudalics@gmx.at>
538 * window.c (delete_deletable_window): Re-add.
539 (Fset_window_configuration): Rewrite to handle dead buffers and
540 consequently deletable windows.
541 (window_tree, Fwindow_tree): Remove. Supply functionality in
543 (compare_window_configurations): Simplify code.
545 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
547 * image.c (imagemagick_load_image): Fix type mismatch.
548 (Fimagemagick_types): Likewise.
550 * window.h (replace_buffer_in_windows): Declare.
552 2011-06-11 Martin Rudalics <rudalics@gmx.at>
554 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
555 Qclone_number. Remove external declaration of Qdelete_window.
556 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
558 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
559 Qbuffer_list_update_hook if allowed.
560 (Fother_buffer): Rewrite doc-string. Major rewrite for new
561 buffer list implementation.
562 (other_buffer_safely): New function.
563 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
564 calls to replace_buffer_in_windows and
565 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
567 (record_buffer): Inhibit quitting and rewrite using quittable
568 functions. Run Qbuffer_list_update_hook if allowed.
569 (Frecord_buffer, Funrecord_buffer): New functions.
570 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
571 switch-to-buffer to window.el.
572 (bury-buffer): Move to window.el.
573 (Vbuffer_list_update_hook): New variable.
575 * lisp.h (other_buffer_safely): Add prototype in buffer.c
578 * window.h (resize_frame_windows): Move up in code.
579 (Fwindow_frame): Remove EXFUN.
580 (replace_buffer_in_all_windows): Remove prototype.
581 (replace_buffer_in_windows_safely): Add prototype.
583 * window.c: Declare Qdelete_window static again. Move down
584 declaration of select_count.
585 (Fnext_window, Fprevious_window): Rewrite doc-strings.
586 (Fother_window): Move to window.el.
587 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
588 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
589 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
591 (replace_buffer_in_windows): Implement by calling
592 Qreplace_buffer_in_windows.
593 (replace_buffer_in_all_windows): Remove with some functionality
594 moved into replace_buffer_in_windows_safely.
595 (replace_buffer_in_windows_safely): New function.
596 (select_window_norecord, select_frame_norecord): Move in front
597 of run_window_configuration_change_hook. Remove now obsolete
599 (Fset_window_buffer): Rewrite doc-string. Call
600 Qrecord_window_buffer.
601 (keys_of_window): Move binding for other-window to window.el.
603 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
605 * dispextern.h (struct image): Replace data member, whose int_val
606 and ptr_val fields were not used by anything, with a single
609 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
610 (gif_clear_image, gif_load, imagemagick_load_image)
611 (gs_clear_image, gs_load): Callers changed.
613 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
615 * buffer.h: Include <time.h>, for time_t.
616 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
618 Fix minor problems found by static checking.
620 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
622 Make identifiers static if they are not used in other modules.
623 * data.c (Qcompiled_function, Qframe, Qvector):
624 * image.c (QimageMagick, Qsvg):
625 * minibuf.c (Qmetadata):
626 * window.c (resize_window_check, resize_root_window): Now static.
627 * window.h (resize_window_check, resize_root_window): Remove decls.
629 * window.c (window_deletion_count, delete_deletable_window):
631 (window_body_lines): Now static.
632 (Fdelete_other_windows_internal): Mark vars as initialized.
633 Make sure 'resize_failed' is initialized.
634 (run_window_configuration_change_hook): Rename local to avoid shadowing.
635 (resize_window_apply): Remove unused local.
636 * window.h (delete_deletable_window): Remove decl.
638 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
639 (imagemagick_load_image): Fix pointer signedness problem by changing
640 last arg from unsigned char * to char *. All uses changed.
641 Also, fix a local for similar reasons.
642 Remove unused locals. Remove locals to avoid shadowing.
643 (fn_rsvg_handle_free): Remove; unused.
644 (svg_load, svg_load_image): Fix pointer signedness problem.
645 (imagemagick_load_image): Don't use garbage pointer image_wand.
647 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
649 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
651 * image.c (gif_load): Fix omitted cast error introduced by
654 2011-06-10 Martin Rudalics <rudalics@gmx.at>
656 * window.h (resize_proportionally, orig_total_lines)
657 (orig_top_line): Remove from window structure.
658 (set_window_height, set_window_width, change_window_heights)
659 (Fdelete_window): Remove prototypes.
660 (resize_frame_windows): Remove duplicate declaration.
662 2011-06-10 Eli Zaretskii <eliz@gnu.org>
664 * window.h (resize_frame_windows, resize_window_check)
665 (delete_deletable_window, resize_root_window)
666 (resize_frame_windows): Declare prototypes.
668 * window.c (resize_window_apply): Make definition be "static" to
671 2011-06-10 Martin Rudalics <rudalics@gmx.at>
673 * window.c: Remove declarations of Qwindow_size_fixed,
674 window_min_size_1, window_min_size_2, window_min_size,
675 size_window, window_fixed_size_p, enlarge_window, delete_window.
676 Remove static from declaration of Qdelete_window, it's
677 temporarily needed by Fbury_buffer.
678 (replace_window): Don't assign orig_top_line and
680 (Fdelete_window, delete_window): Remove. Window deletion is
681 handled by window.el.
682 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
683 Fdelete_window calls with calls to Qdelete_window.
684 (Fdelete_other_windows): Remove. Deleting other windows is
685 handled by window.el.
686 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
687 handled in window.el.
688 (window_min_size_2, window_min_size_1, window_min_size): Remove.
689 Window minimum sizes are handled in window.el.
690 (shrink_windows, size_window, set_window_height)
691 (set_window_width, change_window_heights, window_height)
692 (window_width, CURBEG, CURSIZE, enlarge_window)
693 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
694 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
695 handled in window.el.
696 (make_dummy_parent): Rename to make_parent_window and give it a
697 second argument horflag.
698 (make_window): Don't set resize_proportionally any more.
699 (Fsplit_window): Remove. Windows are split in window.el.
700 (save_restore_action, save_restore_orig_size)
701 (shrink_window_lowest_first, save_restore_orig_size): Remove.
702 Resize mini windows in window.el.
703 (grow_mini_window, shrink_mini_window): Implement by calling
704 Qresize_root_window_vertically, resize_window_check and
706 (saved_window, Fset_window_configuration, save_window_save): Do
707 not handle orig_top_line, orig_total_lines, and
708 resize_proportionally.
709 (window_min_height, window_min_width): Move to window.el.
710 (keys_of_window): Move bindings for delete-other-windows,
711 split-window, delete-window and enlarge-window to window.el.
713 * buffer.c: Temporarily extern Qdelete_window.
714 (Fbury_buffer): Temporarily call Qdelete_window instead of
715 Fdelete_window (Fbury_buffer will move to window.el soon).
717 * frame.c (set_menu_bar_lines_1): Remove code handling
718 orig_top_line and orig_total_lines.
720 * dispnew.c (adjust_frame_glyphs_initially): Don't use
721 set_window_height but set heights directly.
722 (change_frame_size_1): Use resize_frame_windows.
724 * xdisp.c (init_xdisp): Don't use set_window_height but set
727 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
728 resize_frame_windows instead of change_window_heights and run
729 run_window_configuration_change_hook.
731 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
732 instead of change_window_heights and run
733 run_window_configuration_change_hook.
735 2011-06-09 Martin Rudalics <rudalics@gmx.at>
737 * window.c (replace_window): Rename second argument REPLACEMENT to
738 NEW. New third argument SETFLAG. Rewrite.
739 (delete_window, make_dummy_parent): Call replace_window with
741 (window_list_1): Move down in code.
742 (run_window_configuration_change_hook): Move set_buffer part
743 before select_frame_norecord part in order to unwind correctly.
744 Rename count1 to count.
745 (recombine_windows, delete_deletable_window, resize_root_window)
746 (Fdelete_other_windows_internal)
747 (Frun_window_configuration_change_hook, make_parent_window)
748 (resize_window_check, resize_window_apply, Fresize_window_apply)
749 (resize_frame_windows, Fsplit_window_internal)
750 (Fdelete_window_internal, Fresize_mini_window_internal): New
752 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
754 2011-06-08 Martin Rudalics <rudalics@gmx.at>
756 * window.h (window): Add some new members to window structure -
757 normal_lines, normal_cols, new_total, new_normal, clone_number,
758 splits, nest, prev_buffers, next_buffers.
759 (WINDOW_TOTAL_SIZE): Move here from window.c.
760 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
762 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
764 (make_dummy_parent): Set new members of windows structure.
765 (make_window): Move down in code. Handle new members of window
767 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
768 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
769 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
770 (Fset_window_prev_buffers, Fwindow_next_buffers)
771 (Fset_window_next_buffers, Fset_window_clone_number): New
773 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
774 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
776 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
777 Argument WINDOW can be now internal window too.
778 (Fwindow_use_time): Move up in code.
779 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
781 (Fset_window_configuration, saved_window)
782 (Fcurrent_window_configuration, save_window_save): Handle new
783 members of window structure.
784 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
785 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
786 (syms_of_window): New Lisp objects Qrecord_window_buffer,
787 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
788 Qget_mru_window, Qresize_root_window,
789 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
790 Qauto_buffer_name; staticpro them.
792 2011-06-07 Martin Rudalics <rudalics@gmx.at>
794 * window.c (Fwindow_total_size, Fwindow_left_column)
795 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
796 (Fwindow_list_1): New functions.
797 (window_box_text_cols): Replace with window_body_cols.
798 (Fwindow_width, Fscroll_left, Fscroll_right): Use
799 window_body_cols instead of window_box_text_cols.
800 (delete_window, Fset_window_configuration): Call
801 delete_all_subwindows with window as argument.
802 (delete_all_subwindows): Take a window as argument and not a
804 (window_loop): Remove handling of GET_LRU_WINDOW and
806 (Fget_lru_window, Fget_largest_window): Move to window.el.
808 * window.h: Extern window_body_cols instead of
809 window_box_text_cols. delete_all_subwindows now takes a
810 Lisp_Object as argument.
812 * indent.c (compute_motion, Fcompute_motion): Use
813 window_body_cols instead of window_box_text_cols.
815 * frame.c (delete_frame): Call delete_all_subwindows with root
818 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
820 * fns.c (Fputhash): Document return value.
822 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
824 * image.c (gif_load): Implement gif89a spec "no disposal" method.
826 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
828 Cons<->int and similar integer overflow fixes (Bug#8794).
830 Check for overflow when converting integer to cons and back.
831 * charset.c (Fdefine_charset_internal, Fdecode_char):
832 Use cons_to_unsigned to catch overflow.
833 (Fencode_char): Use INTEGER_TO_CONS.
834 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
835 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
836 * data.c (long_to_cons, cons_to_long): Remove.
837 (cons_to_unsigned, cons_to_signed): New functions.
838 These signal an error for invalid or out-of-range values.
839 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
840 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
841 * font.c (Ffont_variation_glyphs):
842 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
843 * lisp.h: Include <intprops.h>.
844 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
845 (cons_to_signed, cons_to_unsigned): New decls.
846 (long_to_cons, cons_to_long): Remove decls.
847 * undo.c (record_first_change): Use INTEGER_TO_CONS.
848 (Fprimitive_undo): Use CONS_TO_INTEGER.
849 * xfns.c (Fx_window_property): Likewise.
850 * xselect.c: Include <limits.h>.
851 (x_own_selection, selection_data_to_lisp_data):
853 (x_handle_selection_request, x_handle_selection_clear)
854 (x_get_foreign_selection, Fx_disown_selection_internal)
855 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
856 (lisp_data_to_selection_data): Use cons_to_unsigned.
857 (x_fill_property_data): Use cons_to_signed.
858 Report values out of range.
860 Check for buffer and string overflow more precisely.
861 * buffer.h (BUF_BYTES_MAX): New macro.
862 * lisp.h (STRING_BYTES_MAX): New macro.
863 * alloc.c (Fmake_string):
864 * character.c (string_escape_byte8):
865 * coding.c (coding_alloc_by_realloc):
867 * editfns.c (Fformat):
869 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
870 since they may not be the same number.
871 * editfns.c (Finsert_char):
872 * fileio.c (Finsert_file_contents):
873 Likewise for BUF_BYTES_MAX.
875 * image.c: Use ptrdiff_t, not int, for sizes.
876 (slurp_file): Switch from int to ptrdiff_t.
878 (slurp_file): Check that file size fits in both size_t (for
879 malloc) and ptrdiff_t (for sanity and safety).
881 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
882 if b->modtime has its maximal value.
884 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
886 Don't assume time_t can fit into int.
887 * buffer.h (struct buffer.modtime): Now time_t, not int.
888 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
889 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
891 Minor fixes for signed vs unsigned integers.
892 * character.h (MAYBE_UNIFY_CHAR):
893 * charset.c (maybe_unify_char):
894 * keyboard.c (read_char, reorder_modifiers):
895 XINT -> XFASTINT, since the integer must be nonnegative.
896 * ftfont.c (ftfont_spec_pattern):
897 * keymap.c (access_keymap, silly_event_symbol_error):
898 XUINT -> XFASTINT, since the integer must be nonnegative.
899 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
900 since it makes no difference and we prefer signed.
901 * keyboard.c (record_char): Use XUINT when all the neighbors do.
902 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
905 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
907 * window.h (Fwindow_frame): Declare.
909 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
911 * alloc.c: Simplify handling of large-request failures (Bug#8800).
912 (SPARE_MEMORY): Always define.
913 (LARGE_REQUEST): Remove.
914 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
916 2011-06-06 Martin Rudalics <rudalics@gmx.at>
918 * lisp.h: Move EXFUNS for Fframe_root_window,
919 Fframe_first_window and Fset_frame_selected_window to window.h.
921 * window.h: Move EXFUNS for Fframe_root_window,
922 Fframe_first_window and Fset_frame_selected_window here from
925 * frame.c (Fwindow_frame, Fframe_first_window)
926 (Fframe_root_window, Fframe_selected_window)
927 (Fset_frame_selected_window): Move to window.c.
928 (Factive_minibuffer_window): Move to minibuf.c.
929 (Fother_visible_frames_p): New function.
931 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
933 * window.c (decode_window, decode_any_window): Move up in code.
934 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
935 (inhibit_frame_unsplittable): Remove unused variable.
936 (Fwindow_buffer): Move up and rewrite doc-string.
937 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
938 (Fwindow_prev): New functions.
939 (Fwindow_frame): Move here from frame.c. Accept any window as
941 (Fframe_root_window, Fframe_first_window)
942 (Fframe_selected_window): Move here from frame.c. Accept frame
943 or arbitrary window as argument. Update doc-strings.
944 (Fminibuffer_window): Move up in code.
945 (Fwindow_minibuffer_p): Move up in code and simplify.
946 (Fset_frame_selected_window): Move here from frame.c.
948 (Fselected_window, select_window, Fselect_window): Move up in
949 code. Minor doc-string fixes.
951 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
953 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
954 Do not assume that spare memory exists; that assumption is valid
955 only if SYSTEM_MALLOC.
956 (LARGE_REQUEST): New macro, so that the issue of large requests
957 is separated from the issue of spare memory.
959 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
961 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
964 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
966 * xfns.c (x_set_scroll_bar_default_width): Move declarations
969 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
971 * gtkutil.c (xg_get_default_scrollbar_width): New function.
973 * gtkutil.h: Declare xg_get_default_scrollbar_width.
975 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
976 min width by calling x_set_scroll_bar_default_width (Bug#8505).
978 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
980 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
982 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
984 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
985 (x_clipboard_manager_save): Add return value.
986 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
988 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
989 Obey Vx_select_enable_clipboard_manager. Catch errors in
990 x_clipboard_manager_save (Bug#8779).
991 (Vx_select_enable_clipboard_manager): New variable.
992 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
994 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
996 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
998 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1000 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1001 in the current matrix if keep_current_p is non-zero.
1003 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1005 * bidi.c (bidi_level_of_next_char): Fix last change.
1007 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1009 Support bidi reordering of text covered by display properties.
1011 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1012 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1013 (bidi_cache_search, bidi_cache_iterator_state)
1014 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1015 (bidi_level_of_next_char, bidi_move_to_visually_next):
1016 Support character positions inside a run of characters covered by a
1018 (bidi_paragraph_init, bidi_resolve_explicit_1)
1019 (bidi_level_of_next_char): Call bidi_fetch_char and
1020 bidi_fetch_char_advance instead of FETCH_CHAR and
1022 (bidi_init_it): Initialize new members.
1023 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1025 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1026 instead of using explicit *_CHAR codes.
1027 (bidi_resolve_explicit, bidi_resolve_weak):
1028 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1029 bidirectional text is supported only in multibyte buffers.
1030 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1031 it to initialize the frame_window_p member of struct bidi_it.
1032 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1033 (bidi_resolve_explicit, bidi_resolve_weak)
1034 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1035 bidi_it->nchars is non-positive.
1036 (bidi_level_of_next_char): Don't try to lookup the cache for the
1037 next/previous character if nothing is cached there yet, or if we
1038 were just reseat()'ed to a new position.
1040 * xdisp.c (set_cursor_from_row): Set start and stop points
1041 according to the row's direction when priming the loop that looks
1042 for the glyph on which to display cursor.
1043 (single_display_spec_intangible_p): Function deleted.
1044 (display_prop_intangible_p): Reimplement to call
1045 handle_display_spec instead of single_display_spec_intangible_p.
1046 Accept 3 additional arguments needed by handle_display_spec.
1047 This fixes incorrect cursor motion across display property with complex
1048 values: lists, `(when COND...)' forms, etc.
1049 (single_display_spec_string_p): Support property values that are
1050 lists with the argument STRING its top-level element.
1051 (display_prop_string_p): Fix the condition for processing a
1052 property that is a list to be consistent with handle_display_spec.
1053 (handle_display_spec): New function, refactored from the
1054 last portion of handle_display_prop.
1055 (compute_display_string_pos): Accept additional argument
1056 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1057 value of a `display' property is a "replacing spec".
1058 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1059 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1060 the display property, but just return a value indicating whether
1061 the display property will replace the characters it covers.
1062 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1063 frame_window_p members of struct bidi_it.
1064 (compute_display_string_pos, compute_display_string_end):
1066 (push_it): Accept second argument POSITION, where pop_it should
1067 jump to continue iteration.
1068 (reseat_1): Initialize bidi_it.disp_pos.
1070 * keyboard.c (adjust_point_for_property): Adjust the call to
1071 display_prop_intangible_p to its new signature.
1073 * dispextern.h (struct bidi_it): New member frame_window_p.
1074 (bidi_init_it): Update prototypes.
1075 (display_prop_intangible_p): Update prototype.
1076 (compute_display_string_pos, compute_display_string_end):
1078 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1081 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1083 Malloc failure behavior now depends on size of allocation.
1084 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1085 * lisp.h: Change signatures accordingly.
1086 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1087 All callers changed. (Bug#8762)
1089 * gnutls.c: Use Emacs's memory allocators.
1090 Without this change, the gnutls library would invoke malloc etc.
1091 directly, which causes problems on non-SYNC_INPUT hosts, and which
1092 runs afoul of improving memory_full behavior. (Bug#8761)
1093 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1094 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1095 xfree instead of the default malloc, realloc, free.
1096 (Fgnutls_boot): No need to check for memory allocation failure,
1097 since xmalloc does that for us.
1099 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1100 * category.c (hash_get_category_set):
1101 * ccl.c (ccl_driver):
1102 * charset.c (Fdefine_charset_internal):
1103 * charset.h (struct charset.hash_index):
1104 * composite.c (get_composition_id, gstring_lookup_cache)
1105 (composition_gstring_put_cache):
1106 * composite.h (struct composition.hash_index):
1107 * dispextern.h (struct image.hash):
1108 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1109 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1110 (hashfn_equal, hashfn_user_defined, make_hash_table)
1111 (maybe_resize_hash_table, hash_lookup, hash_put)
1112 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1113 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1114 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1115 * image.c (make_image, search_image_cache, lookup_image)
1116 (xpm_put_color_table_h):
1117 * lisp.h (struct Lisp_Hash_Table):
1118 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1119 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1120 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1121 * alloc.c (allocate_vectorlike):
1122 Check for overflow in vector size calculations.
1123 * ccl.c (ccl_driver):
1124 Check for overflow when converting EMACS_INT to int.
1125 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1126 need to be updated by these changes.
1127 * fns.c (make_hash_table, maybe_resize_hash_table):
1128 Check for integer overflow with large hash tables.
1129 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1130 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1131 (SXHASH_REDUCE): New macro.
1132 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1133 Use it instead of discarding useful hash info with large hash values.
1134 (sxhash_float): New function.
1135 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1136 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1137 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1138 Rewrite to use FIXNUM_BITS, as this simplifies things.
1139 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1140 Adjust signatures to match updated version of code.
1141 (consing_since_gc): Now EMACS_INT, since a single hash table can
1142 use more than INT_MAX bytes.
1144 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1146 Make it possible to build with GCC-4.6+ -O2 -flto.
1148 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1150 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1152 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1153 Call minibuffer-inactive-mode.
1155 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1157 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1158 Update dependencies.
1160 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1162 * data.c (init_data): Remove code for UTS, this system is not
1165 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1167 Don't force ./temacs to start in terminal mode.
1169 * frame.c (make_initial_frame): Initialize faces in all cases, not
1170 only when CANNOT_DUMP is defined.
1171 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1173 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1175 * dispnew.c (add_window_display_history): Use const for the string
1176 pointer. Remove declaration, not needed.
1178 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1180 Use 'inline', not 'INLINE'.
1181 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1182 * alloc.c, fontset.c (INLINE): Remove.
1183 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1184 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1185 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1186 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1187 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1189 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1191 Make it possible to run ./temacs.
1193 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1194 syms_of_callproc does the same thing. Remove test for
1195 "initialized", do it in the caller.
1196 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1198 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1200 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1201 (read_minibuf): Use get_minibuffer.
1202 (syms_of_minibuf): Use DEFSYM.
1203 (Qmetadata): New var.
1204 * data.c (Qbuffer): Don't make it static.
1205 (syms_of_data): Use DEFSYM.
1207 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1209 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1210 (CCL_CODE_MIN): New macro.
1212 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1214 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1216 * eval.c (Qdebug): Now static.
1217 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1218 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1219 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1221 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1223 * image.c: Various fixes to ImageMagick code comments.
1224 (Fimagemagick_types): Doc fix.
1226 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1228 Minor fixes prompted by GCC 4.6.0 warnings.
1230 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1232 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1233 (x_clipboard_manager_save_all): Move extern decl to ...
1234 * xterm.h: ... here, so that it can be checked for consistency.
1236 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1238 * xselect.c (x_clipboard_manager_save_frame)
1239 (x_clipboard_manager_save_all): New functions.
1240 (Fx_clipboard_manager_save): Lisp function deleted.
1242 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1243 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1245 * xterm.h: Update prototype.
1247 2011-05-28 William Xu <william.xwl@gmail.com>
1249 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1252 2011-05-28 Jim Meyering <meyering@redhat.com>
1254 Avoid a sign-extension bug in crypto_hash_function.
1255 * fns.c (to_uchar): Define.
1256 (crypto_hash_function): Use it to convert some newly-signed
1257 variables to unsigned, to avoid sign-extension bugs. For example,
1258 without this change, (md5 "truc") would evaluate to
1259 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1260 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1261 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1263 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1265 Integer overflow fixes.
1267 * dbusbind.c: Serial number integer overflow fixes.
1268 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1269 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1270 to hold a serial number that is too large for a fixnum.
1271 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1272 Check for serial numbers out of range. Decode any serial number
1273 that was so large that it became a float. (Bug#8722)
1275 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1276 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1277 Use XFASTINT rather than XUINT when numbers are nonnegative.
1278 (xd_append_arg, Fdbus_method_return_internal):
1279 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1280 arguments, check that Lisp number is nonnegative, rather than
1281 silently wrapping negative numbers around. (Bug#8722)
1282 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1285 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1287 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1289 ccl: add integer overflow checks
1290 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1291 (IN_INT_RANGE): New macros.
1292 (ccl_driver): Use them to check for integer overflow when
1293 decoding a CCL program. Many of the new checks are whether XINT (x)
1294 fits in int; it doesn't always, on 64-bit hosts. The new version
1295 doesn't catch all possible integer overflows, but it's an
1296 improvement. (Bug#8719)
1298 * alloc.c (make_event_array): Use XINT, not XUINT.
1299 There's no need for unsigned here.
1301 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1302 This follows up to the 2011-05-06 change that substituted uintptr_t
1303 for EMACS_INT. This case wasn't caught back then.
1305 Rework Fformat to avoid integer overflow issues.
1306 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1307 now (part of C89). Include <verify.h>.
1308 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1309 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1310 (Fformat): Avoid the prepass trying to compute sizes; it was only
1311 approximate and thus did not catch overflow reliably. Instead, walk
1312 through the format just once, formatting and computing sizes as we go,
1313 checking for integer overflow at every step, and allocating a larger
1314 buffer as needed. Keep track separately whether the format is
1315 multibyte. Keep only the most-recently calculated precision, rather
1316 than them all. Record whether each argument has been converted to
1317 string. Use EMACS_INT, not int, for byte and char and arg counts.
1318 Support field widths and precisions larger than INT_MAX. Avoid
1319 sprintf's undefined behavior with conversion specifications such as %#d
1320 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1321 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1322 formatting out-of-range floating point numbers with int
1325 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1327 * data.c: Avoid integer truncation in expressions involving floats.
1328 * data.c: Include <intprops.h>.
1329 (arith_driver): When there's an integer overflow in an expression
1330 involving floating point, convert the integers to floating point
1331 so that the resulting value does not suffer from catastrophic
1332 integer truncation. For example, on a 64-bit host (* 4
1333 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1334 Do not rely on undefined behavior after integer overflow.
1336 merge count_size_as_multibyte, parse_str_to_multibyte
1337 * character.c, character.h (count_size_as_multibyte):
1338 Rename from parse_str_to_multibyte; all uses changed.
1339 Check for integer overflow.
1340 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1341 since it's now a duplicate of the other. This is more of
1342 a character than a buffer op, so better that it's in character.c.
1343 * fns.c, print.c: Adjust to above changes.
1345 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1347 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1349 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1351 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1352 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1353 (x_clipboard_manager_save): Now static.
1354 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1356 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1357 (crypto_hash_function): Now static.
1358 Fix pointer signedness problems. Avoid unnecessary initializations.
1360 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1362 * termhooks.h (Vselection_alist): Make it terminal-local.
1364 * terminal.c (create_terminal): Initialize it.
1366 * xselect.c: Support for clipboard managers.
1367 (Vselection_alist): Move to termhooks.h as terminal-local var.
1368 (LOCAL_SELECTION): New macro.
1369 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1370 (symbol_to_x_atom): Remove gratuitous arg.
1371 (x_handle_selection_request, lisp_data_to_selection_data)
1372 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1373 (x_own_selection, x_get_local_selection, x_convert_selection):
1374 New arg, specifying work frame. Use terminal-local Vselection_alist.
1375 (some_frame_on_display): Delete unused function.
1376 (Fx_own_selection_internal, Fx_get_selection_internal)
1377 (Fx_disown_selection_internal, Fx_selection_owner_p)
1378 (Fx_selection_exists_p): New optional frame arg.
1379 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1380 (x_handle_selection_clear): Don't treat other terminals with the
1381 same keyboard specially. Use the terminal-local Vselection_alist.
1382 (x_clear_frame_selections): Use Frun_hook_with_args.
1384 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1386 * xterm.h: Add support for those atoms.
1388 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1390 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1391 (converted_selections, conversion_fail_tag): New global variables.
1392 (x_selection_request_lisp_error): Free the above.
1393 (x_get_local_selection): Remove unnecessary code.
1394 (x_reply_selection_request): Args changed; handle arbitrary array
1395 of converted selections stored in converted_selections.
1396 Separate the XChangeProperty and SelectionNotify steps.
1397 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1398 (x_convert_selection): New function.
1399 (x_handle_selection_event): Simplify.
1400 (x_get_foreign_selection): Don't ignore incoming requests while
1401 waiting for an answer; this will fail when we implement
1402 SAVE_TARGETS, and seems unnecessary anyway.
1403 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1404 (Vx_sent_selection_functions): Doc fix.
1406 2011-05-26 Leo Liu <sdl.web@gmail.com>
1408 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1410 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1412 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1414 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1415 for fringe update if it has periodic bitmap.
1416 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1417 and fringe_bitmap_periodic_p.
1419 * fringe.c (get_fringe_bitmap_data): New function.
1420 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1421 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1422 row. Mark glyph row for fringe update if periodicity changed.
1424 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1425 for fringe update unless it has periodic bitmap.
1427 2011-05-25 Kenichi Handa <handa@m17n.org>
1429 * xdisp.c (get_next_display_element): Set correct it->face_id for
1430 a static composition.
1432 2011-05-24 Leo Liu <sdl.web@gmail.com>
1435 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1437 * fns.c (crypto_hash_function, Fsha1): New function.
1438 (Fmd5): Use crypto_hash_function.
1439 (syms_of_fns): Add Ssha1.
1441 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1443 * gnutls.c: Remove unused macros.
1444 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1445 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1446 Remove macros that are defined and never used.
1447 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1449 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1451 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1452 (Fx_get_selection_internal): Minor cleanup.
1453 (Fx_own_selection_internal): Rename arguments for consistency with
1456 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1458 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1460 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1462 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1464 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1466 * dispnew.c (scrolling_window): Don't exclude the case that the
1467 last enabled row in the desired matrix touches the bottom boundary.
1469 2011-05-21 Glenn Morris <rgm@gnu.org>
1471 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1472 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1473 and add some more files.
1475 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1477 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1478 report_file_error introduced by the change from 2011-05-07.
1480 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1482 * systime.h (Time): Define only if emacs is defined.
1483 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1484 where the include path doesn't have X11/X.h by default. See
1485 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1487 2011-05-20 Kenichi Handa <handa@m17n.org>
1489 * composite.c (find_automatic_composition): Fix previous change.
1491 2011-05-20 Glenn Morris <rgm@gnu.org>
1493 * lisp.mk: New file, split from Makefile.in.
1494 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1495 (shortlisp): Remove.
1496 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1498 2011-05-19 Glenn Morris <rgm@gnu.org>
1500 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1501 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1502 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1503 (lisp): Set the order to that of loadup.el.
1504 (shortlisp): Make it a copy of $lisp.
1505 (SOME_MACHINE_LISP): Remove.
1506 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1507 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1509 2011-05-18 Kenichi Handa <handa@m17n.org>
1511 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1512 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1513 (find_automatic_composition): Mostly rewrite for efficiency.
1515 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1517 * makefile.w32-in: Update dependencies.
1519 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1521 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1522 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1524 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1526 Fix some integer overflow issues, such as string length overflow.
1528 * insdel.c (count_size_as_multibyte): Check for string overflow.
1530 * character.c (lisp_string_width): Check for string overflow.
1531 Use EMACS_INT, not int, for string indexes and lengths; in
1532 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1533 the resulting string length overflows an EMACS_INT; instead,
1534 report a string overflow if no precision given. When checking for
1535 precision exhaustion, use a check that cannot possibly have
1536 integer overflow. (Bug#8675)
1537 * character.h (lisp_string_width): Adjust to new signature.
1539 * alloc.c (string_overflow): New function.
1540 (Fmake_string): Use it. This doesn't change behavior, but saves
1541 a few bytes and will simplify future changes.
1542 * character.c (string_escape_byte8): Likewise.
1543 * lisp.h (string_overflow): New decl.
1545 Fixups, following up to the user-interface timestamp change.
1546 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1547 for UI timestamps, instead of unsigned long.
1548 * msdos.c (mouse_get_pos): Likewise.
1549 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1550 * w32gui.h (Time): Define by including "systime.h" rather than by
1551 declaring it ourselves. (Bug#8664)
1553 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1554 * image.c (clear_image_cache): Likewise.
1556 * term.c (term_mouse_position): Don't assume time_t wraparound.
1558 Be more systematic about user-interface timestamps.
1559 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1560 and sometimes 'EMACS_UINT', to represent these timestamps.
1561 This change causes it to use 'Time' uniformly, as that's what X uses.
1562 This makes the code easier to follow, and makes it easier to catch
1563 integer overflow bugs such as Bug#8664.
1564 * frame.c (Fmouse_position, Fmouse_pixel_position):
1565 Use Time, not unsigned long, for user-interface timestamps.
1566 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1567 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1568 * keyboard.h (last_event_timestamp): Likewise.
1569 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1570 * menu.h (xmenu_show): Likewise.
1571 * term.c (term_mouse_position): Likewise.
1572 * termhooks.h (struct input_event.timestamp): Likewise.
1573 (struct terminal.mouse_position_hook): Likewise.
1574 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1575 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1576 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1577 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1579 * menu.h, termhooks.h: Include "systime.h", for Time.
1581 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1582 Don't assume that the difference between two unsigned long values
1583 can fit into an integer. At this point, we know button_down_time
1584 <= event->timestamp, so the difference must be nonnegative, so
1585 there's no need to cast the result if double-click-time is
1586 nonnegative, as it should be; check that it's nonnegative, just in
1587 case. This bug is triggered when events are more than 2**31 ms
1588 apart (about 25 days). (Bug#8664)
1590 * xselect.c (last_event_timestamp): Remove duplicate decl.
1591 (x_own_selection): Remove needless cast to unsigned long.
1593 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1594 that always fit in int. Use a sentinel instead of a counter, to
1595 avoid a temp and to allay GCC's concerns about possible int overflow.
1596 * frame.h (struct frame): Use int for menu_bar_items_used
1597 instead of EMACS_INT, since it always fits in int.
1599 * menu.c (grow_menu_items): Check for int overflow.
1601 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1603 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1604 Before, the code was not consistent. These values cannot exceed
1605 2**31 - 1 so there's no need to make them unsigned.
1606 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1607 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1608 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1610 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1612 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1613 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1614 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1615 presumably because the widths might not match.
1617 * window.c (size_window): Avoid needless test at loop start.
1619 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1621 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1623 2011-05-12 Drew Adams <drew.adams@oracle.com>
1625 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1627 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1629 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1630 `width' to `bar_area_x' and `bar_area_width', respectively.
1631 (x_scroll_run): Take account of fringe background extension.
1633 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1634 Rename local vars `left' and `width' to `bar_area_x' and
1635 `bar_area_width', respectively.
1636 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1637 background extension.
1639 2011-05-10 Jim Meyering <meyering@redhat.com>
1641 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1643 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1645 * image.c (Finit_image_library): Return t for built-in image types,
1646 like pbm and xbm. (Bug#8640)
1648 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1650 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1652 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1654 * w32console.c (Fset_screen_color): Doc fix.
1655 (Fget_screen_color): New function.
1656 (syms_of_ntterm): Defsubr it.
1658 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1659 unlink the temporary file if Fcall_process didn't create it in the
1661 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1662 child process will be redirected to a file specified with `:file'.
1663 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1664 cue to call_process_cleanup not to close that handle.
1666 2011-05-07 Ben Key <bkey76@gmail.com>
1668 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1669 one of two shell specific rules, either bootstrap-temacs-CMD or
1670 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1671 to the previous implementation of the bootstrap-temacs rule.
1672 The bootstrap-temacs-CMD rule is similar to the previous
1673 implementation of the bootstrap-temacs rule except that it
1674 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1677 These changes, along with some changes to nt/configure.bat,
1678 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1679 earlier fix to add support for --cflags and --ldflags options
1680 that include quotes so that it works whether make uses cmd or
1683 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1685 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1686 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1688 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1689 a string. Handle both cases.
1690 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1691 (Fdbus_register_method): Use Qinvalid_function.
1693 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1695 * makefile.w32-in: Update dependencies.
1696 (LISP_H): Add inttypes.h and stdin.h.
1697 (PROCESS_H): Add unistd.h.
1699 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1701 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1702 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1704 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1706 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1708 * term.c (vfatal): Remove stray call to va_end.
1709 It's not needed and the C Standard doesn't allow it here anyway.
1711 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1712 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1714 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1717 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1719 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1721 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1723 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1725 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1727 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1728 * charset.c (Fdefine_charset_internal): Don't initialize
1729 charset.code_space[15]. The value was garbage, on hosts with
1730 32-bit int (Bug#8600).
1732 * lread.c (read_integer): Be more consistent with string-to-number.
1733 Use string_to_number to do the actual conversion; this avoids
1734 rounding errors and fixes some other screwups. Without this fix,
1735 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1736 (digit_to_number): Move earlier, for benefit of read_integer.
1737 Return -1 if the digit is out of range for the base, -2 if it is
1738 not a digit in any supported base. (Bug#8602)
1740 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1742 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1743 to match comment at start of function. This also removes a
1744 GCC warning about overflow in a 32+64-bit port.
1746 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1748 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1749 Reported by Stefan Monnier in
1750 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1751 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1752 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1754 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1755 (EMACS_UINTPTR): Likewise, with uintptr_t.
1757 * lisp.h: Prefer 64-bit EMACS_INT if available.
1758 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1759 on 32-bit hosts that have 64-bit int, so that they can access
1761 However, temporarily disable this change unless the temporary
1762 symbol WIDE_EMACS_INT is defined.
1764 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1766 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1767 This removes an assumption that EMACS_INT and long are the same
1768 width as pointers. The assumption is true for Emacs porting targets
1769 now, but we want to make other targets possible.
1770 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1771 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1772 In the rest of the code, change types of integers that hold casted
1773 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1774 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1775 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1776 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1777 No need to cast type when ORing.
1778 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1779 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1780 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1781 assume EMACS_INT is the same width as char *.
1782 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1783 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1784 Remove no-longer-needed casts.
1785 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1786 (xg_tool_bar_help_callback, xg_make_tool_item):
1787 Use EMACS_INTPTR to hold an integer
1788 that will be cast to void *; this can avoid a GCC warning
1789 if EMACS_INT is not the same width as void *.
1790 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1791 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1792 (current_message_1, set_message_1):
1793 Use a local to convert to proper width without a cast.
1794 * xmenu.c (dialog_selection_callback): Likewise.
1796 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1797 Also, don't assume VALBITS / RAND_BITS is less than 5,
1798 and don't rely on undefined behavior when shifting a 1 left into
1800 * lisp.h (get_random): Change signature to match.
1802 * lread.c (hash_string): Use size_t, not int, for hash computation.
1803 Normally we prefer signed values; but hashing is special, because
1804 it's better to use unsigned division on hash table sizes so that
1805 the remainder is nonnegative. Also, size_t is the natural width
1806 for hashing into memory. The previous code used 'int', which doesn't
1807 retain enough info to hash well into very large tables.
1808 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1810 * dbusbind.c: Don't possibly lose pointer info when converting.
1811 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1812 Use XPNTR rather than XHASH, so that the high-order bits of
1813 the pointer aren't lost when converting through void *.
1815 * eval.c (Fautoload): Don't double-shift a pointer.
1817 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1819 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1821 * gnutls.c (DEF_GNUTLS_FN):
1822 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1824 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1826 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1829 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1831 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1832 New version that can reserve upto 2GB of heap space.
1834 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1836 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1838 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1840 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1841 `gnutls_certificate_set_x509_key_file'.
1843 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1845 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1846 Update dependencies.
1848 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1850 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1851 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1852 Remove unused parameter `fildes'.
1853 * process.c (read_process_output, send_process): Don't pass it.
1855 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1857 Fix previous change: the library cache is defined in w32.c.
1858 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1859 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1861 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1863 Implement dynamic loading of GnuTLS on Windows.
1865 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1866 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1867 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1870 * gnutls.c (Qgnutls_dll): Define.
1871 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1872 (gnutls_*): Declare function pointers.
1873 (init_gnutls_functions): New function to initialize function pointers.
1874 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1875 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1876 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1877 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1878 (emacs_gnutls_write, emacs_gnutls_read)
1879 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1880 (Fgnutls_available_p): New function.
1881 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1882 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1883 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1885 * image.c: Include w32.h.
1886 (Vimage_type_cache): Delete.
1887 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1888 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1889 (w32_delayed_load): Move to w32.c.
1891 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1893 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1894 (w32_delayed_load): Move from image.c. When loading a library, record
1895 its filename in the :loaded-from property of the library id.
1896 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1897 Initialize and staticpro them.
1898 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1900 * process.c: Include lisp.h before w32.h, not after.
1901 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1902 instead of gnutls_record_check_pending.
1904 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1906 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1908 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1909 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1912 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1914 * xterm.c (x_set_frame_alpha): Do not set property on anything
1915 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1917 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1919 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1921 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1923 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1924 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1925 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1926 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1927 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1928 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1929 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1930 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1931 (Qgnutls_bootprop_callbacks_verify): Make static.
1933 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1935 * callproc.c: Indentation fixup.
1937 * sysdep.c (wait_for_termination_1): Make static.
1938 (wait_for_termination, interruptible_wait_for_termination):
1939 Move after wait_for_termination_1.
1941 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1943 * sysdep.c (interruptible_wait_for_termination): New function
1944 which is like wait_for_termination, but allows keyboard
1947 * callproc.c (Fcall_process): Add (:file "file") as an option for
1949 (Fcall_process_region): Ditto.
1951 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1953 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1954 rather than `XVECTOR (FOO)->size'.
1956 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1957 inttypes.h, as a gnulib replacement is used if it not available in
1960 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1962 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1963 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1964 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1966 * coding.c (coding_alloc_by_realloc): Error out if destination
1967 will grow beyond MOST_POSITIVE_FIXNUM.
1968 (decode_coding_emacs_mule): Abort if there isn't enough place in
1969 charbuf for the composition carryover bytes. Reserve an extra
1970 space for up to 2 characters produced in a loop.
1971 (decode_coding_iso_2022): Abort if there isn't enough place in
1972 charbuf for the composition carryover bytes.
1974 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1976 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1977 aborting when %lld or %lll format is passed.
1978 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1979 %llo or %llx format is passed. (Bug#8545)
1981 * window.c (window_scroll_line_based): Use a marker instead of
1982 simple variables to record original value of point. (Bug#7952)
1984 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1985 produced by %s or %c overflows available buffer space. (Bug#8545)
1987 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1989 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1990 (SIZE_MAX): Move defn after all includes, as they might #define it.
1992 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1994 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1996 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1998 * keyboard.c (Qdelayed_warnings_hook): Define.
1999 (command_loop_1): Run `delayed-warnings-hook'
2000 if Vdelayed_warnings_list is non-nil.
2001 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2002 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2004 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2006 * doprnt.c (doprnt): Don't return value smaller than the buffer
2007 size if the message was truncated. (Bug#8545).
2009 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2011 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2012 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2014 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2016 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2018 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2020 * makefile.w32-in: Update dependencies.
2022 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2024 Improve `doprnt' and its usage. (Bug#8545)
2025 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2026 `format_end'. Remove support for %l as a conversion specifier.
2027 Don't use xrealloc. Improve diagnostics when the %l size modifier
2028 is used. Update the commentary.
2030 * eval.c (verror): Simplify calculation of size_t.
2032 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2035 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2037 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2040 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2042 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2043 This makes this file independent of the recent pseudovector change.
2045 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2047 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2049 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2050 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2051 Remove unused local.
2052 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2054 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2055 GCC 4.6.0 optimizes based on type-based alias analysis.
2056 For example, if b is of type struct buffer * and v of type struct
2057 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2058 != &v->size, and therefore "v->size = 1; b->size = 2; return
2059 v->size;" must therefore return 1. This assumption is incorrect
2060 for Emacs, since it type-puns struct Lisp_Vector * with many other
2061 types. To fix this problem, this patch adds a new type struct
2062 vectorlike_header that documents the constraints on layout of vectors
2063 and pseudovectors, and helps optimizing compilers not get fooled
2064 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2065 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2066 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2068 (XSETPVECTYPE): Rewrite in terms of new macro.
2069 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2070 This is a bit clearer, and further avoids the possibility of
2071 undesirable aliasing.
2072 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2073 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2074 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2075 since Lisp_Subr is a special case (no "next" field).
2076 (ASIZE): Now uses header.size rather than size.
2077 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2078 to avoid the hassle of writing XVECTOR (foo)->header.size.
2079 (struct vectorlike_header): New type.
2080 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2081 object, to help avoid aliasing.
2082 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2083 (SUBRP): Likewise, since Lisp_Subr is a special case.
2084 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2085 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2086 (struct Lisp_Hash_Table): Combine first two members into a single
2087 struct vectorlike_header member. All uses of "size" and "next" members
2088 changed to be "header.size" and "header.next".
2089 * buffer.h (struct buffer): Likewise.
2090 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2091 * frame.h (struct frame): Likewise.
2092 * process.h (struct Lisp_Process): Likewise.
2093 * termhooks.h (struct terminal): Likewise.
2094 * window.c (struct save_window_data, struct saved_window): Likewise.
2095 * window.h (struct window): Likewise.
2096 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2097 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2098 * buffer.c (init_buffer_once): Likewise.
2099 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2101 * process.c (Fformat_network_address): Use local var for size,
2104 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2106 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2107 * data.c (atof): Remove decl; no longer used or needed.
2108 (digit_to_number): Move to lread.c.
2109 (Fstring_to_number): Use new string_to_number function, to be
2110 consistent with how the Lisp reader treats infinities and NaNs.
2111 Do not assume that floating-point numbers represent EMACS_INT
2112 without losing information; this is not true on most 64-bit hosts.
2113 Avoid double-rounding errors, by insisting on integers when
2114 parsing non-base-10 numbers, as the documentation specifies.
2115 * lisp.h (string_to_number): New decl, replacing ...
2116 (isfloat_string): Remove.
2117 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2118 (read1): Do not accept +. and -. as integers; this
2119 appears to have been a coding error. Similarly, do not accept
2120 strings like +-1e0 as floating point numbers. Do not report
2121 overflow for integer overflows unless the base is not 10 which
2122 means we have no simple and reliable way to continue.
2123 Break out the floating-point parsing into a new
2124 function string_to_number, so that Fstring_to_number parses
2125 floating point numbers consistently with the Lisp reader.
2126 (digit_to_number): Move here from data.c. Make it static inline.
2127 (E_CHAR, EXP_INT): Remove, replacing with ...
2128 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2129 (string_to_number): New function, replacing isfloat_string.
2130 This function checks for valid syntax and produces the resulting
2131 Lisp float number too. Rework it so that string-to-number
2132 no longer mishandles examples like "1.0e+". Use strtoumax,
2133 so that overflow for non-base-10 numbers is reported only when
2134 there's no portable and simple way to convert to floating point.
2136 * textprop.c (set_text_properties_1): Rewrite for clarity,
2137 and to avoid GCC warning about integer overflow.
2139 * intervals.h (struct interval): Use EMACS_INT for members
2140 where EMACS_UINT might cause problems. See
2141 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2142 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2143 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2145 (offset_intervals): Tell GCC not to worry about length overflow
2146 when negating a negative length.
2148 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2149 (overrun_check_free): Likewise.
2151 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2152 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2155 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2156 (gnutls_make_error): Rename local to avoid shadowing.
2157 (gnutls_emacs_global_deinit): ifdef out; not used.
2158 (Fgnutls_boot): Use const for pointer to readonly storage.
2159 Comment out unused local. Fix pointer signedness problems.
2161 * lread.c (openp): Don't stuff size_t into an 'int'.
2162 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2163 about possible signed overflow.
2165 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2166 (GDK_KEY_g): Don't define if already defined.
2167 (xg_prepare_tooltip): Avoid pointer signedness problem.
2168 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2170 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2171 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2173 * xfns.c (Fx_window_property): Simplify a bit,
2174 to make a bit faster and to avoid GCC 4.6.0 warning.
2175 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2177 * fns.c (internal_equal): Don't assume size_t fits in int.
2179 * alloc.c (compact_small_strings): Tighten assertion a little.
2181 Replace pEd with more-general pI, and fix some printf arg casts.
2182 * lisp.h (pI): New macro, generalizing old pEd macro to other
2183 conversion specifiers. For example, use "...%"pI"d..." rather
2184 than "...%"pEd"...".
2185 (pEd): Remove. All uses replaced with similar uses of pI.
2186 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2187 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2188 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2189 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2190 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2191 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2192 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2194 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2195 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2196 * print.c (safe_debug_print, print_object): Likewise.
2197 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2199 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2200 avoiding the 0 flag, which is not portable.
2201 * process.c (Fmake_network_process): Use pI to avoid cast.
2202 * region-cache.c (pp_cache): Likewise.
2203 * xdisp.c (decode_mode_spec): Likewise.
2204 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2205 behavior on 64-bit hosts with printf arg.
2206 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2207 (x_stop_queuing_selection_requests): Likewise.
2208 (x_get_window_property): Don't truncate byte count to an 'int'
2211 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2212 here, since it parses constructs like leading '-' and spaces,
2213 which are not wanted; and it overflows with large numbers.
2214 Instead, simply match F[0-9]+, which is what is wanted anyway.
2216 * alloc.c: Remove unportable assumptions about struct layout.
2217 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2218 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2219 (allocate_vectorlike, make_pure_vector): Use the new macros,
2220 plus offsetof, to remove unportable assumptions about struct layout.
2221 These assumptions hold on all porting targets that I know of, but
2222 they are not guaranteed, they're easy to remove, and removing them
2223 makes further changes easier.
2225 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2226 This doesn't fix a bug but makes the code clearer.
2227 (string_overrun_cookie): Now const. Use initializers that
2228 don't formally overflow signed char, to avoid warnings.
2229 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2230 can cause Emacs to crash when string overrun checking is enabled.
2231 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2232 multiple of sizeof (EMACS_INT); it need not be, if
2233 alignof(EMACS_INT) < sizeof (EMACS_INT).
2234 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2236 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2238 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2240 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2242 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2243 supposed to be handshaking. (Bug#8556)
2244 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2246 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2248 * lisp.h (Qdebug): List symbol.
2249 * eval.c (Qdebug): Restore global linkage.
2250 * keyboard.c (debug-on-event): New variable.
2251 (handle_user_signal): Break into debugger when debug-on-event
2252 matches the current signal symbol.
2254 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2256 * alloc.c (check_sblock, check_string_bytes)
2257 (check_string_free_list): Convert to standard C.
2259 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2261 * w32.c (emacs_gnutls_push): Fix typo.
2263 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2265 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2266 "cast to pointer from integer of different size".
2268 Improve doprnt and its use in verror. (Bug#8545)
2269 * doprnt.c (doprnt): Document the set of format control sequences
2270 supported by the function. Use SAFE_ALLOCA instead of always
2273 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2274 is one byte too soon. Don't use xrealloc; instead xfree and
2277 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2279 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2282 * gnutls.c: Renamed global_initialized to
2283 gnutls_global_initialized. Added internals for the
2284 :verify-hostname-error, :verify-error, and :verify-flags
2285 parameters of `gnutls-boot' and documented those parameters in the
2286 docstring. Start callback support.
2287 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2288 unless a fatal error occured. Call gnutls_alert_send_appropriate
2289 on error. Return error code.
2290 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2291 (emacs_gnutls_read): Likewise.
2292 (Fgnutls_boot): Return handshake error code.
2293 (emacs_gnutls_handle_error): New function.
2294 (wsaerror_to_errno): Likewise.
2296 * w32.h (emacs_gnutls_pull): Add prototype.
2297 (emacs_gnutls_push): Likewise.
2299 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2300 (emacs_gnutls_push): Likewise.
2302 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2304 * process.c (wait_reading_process_output): Check if GnuTLS
2305 buffered some data internally if no FDs are set for TLS
2308 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2309 (LIBS): Link to USER_LIBS.
2310 ($(BLD)/gnutls.$(0)): New target.
2312 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2314 * xdisp.c (handle_single_display_spec): Rename the
2315 display_replaced_before_p argument into display_replaced_p, to
2316 make it consistent with the commentary. Fix typos in the
2319 * textprop.c (syms_of_textprop): Remove dead code.
2320 (copy_text_properties): Delete obsolete commentary about an
2321 interface that was deleted long ago. Fix typos in the description
2324 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2325 to changes in oldXMenu/XMenu.h from 2011-04-16.
2326 <menu_help_message, prev_menu_help_message>: Constify.
2327 (IT_menu_make_room): menu->help_text is now `const char **';
2330 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2331 to changes in oldXMenu/XMenu.h from 2011-04-16.
2332 (struct XMenu): Declare `help_text' `const char **'.
2334 * xfaces.c <Qunspecified>: Make extern again.
2336 * syntax.c: Include sys/types.h before including regex.h, as
2339 * doc.c (get_doc_string): Improve the format passed to `error'.
2341 * doprnt.c (doprnt): Improve commentary.
2343 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2345 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2348 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2349 changes in globals.h immediately force recompilation.
2350 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2351 $(CURDIR)/s/ms-w32.h.
2352 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2354 * character.c (Fchar_direction): Function deleted.
2355 (syms_of_character): Don't defsubr it.
2356 <char-direction-table>: Deleted.
2358 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2360 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2361 * doprnt.c: Include limits.h.
2362 (SIZE_MAX): New macro.
2363 (doprnt): Return a size_t value. 2nd arg is now size_t.
2364 Many local variables are now size_t instead of int or unsigned.
2365 Improve overflow protection. Support `l' modifier for integer
2366 conversions. Support %l conversion. Don't assume an EMACS_INT
2367 argument for integer conversions and for %c.
2369 * lisp.h (doprnt): Restore prototype.
2371 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2374 * Makefile.in (base_obj): Add back doprnt.o.
2376 * deps.mk (doprnt.o): Add back prerequisites.
2377 (callint.o): Depend on character.h.
2379 * eval.c (internal_lisp_condition_case): Include the handler
2380 representation in the error message.
2381 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2382 when breaking from the loop.
2384 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2386 * callint.c (Fcall_interactively): When displaying error message
2387 about invalid control letter, pass the character's codepoint, not
2388 a pointer to its multibyte form. Improve display of the character
2389 in octal and display also its hex code.
2391 * character.c (char_string): Use %x to display the (unsigned)
2392 codepoint of an invalid character, to avoid displaying a bogus
2395 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2396 `error', not SYMBOL_NAME itself.
2398 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2399 character arguments to `error'.
2401 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2402 to `error' in error message about FINAL_CHAR argument. Make sure
2403 FINAL_CHAR is a character, and use %c when it is passed as
2404 argument to `error'.
2406 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2408 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2410 * w32.c: Include <time.h>.
2411 (sys_localtime): New function.
2413 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2415 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2417 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2419 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2421 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2424 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2426 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2427 gl_state.e_property when gl_state.object is Qt.
2429 * insdel.c (make_gap_larger): Remove limitation of buffer size
2432 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2434 * xdisp.c (lookup_glyphless_char_display)
2435 (produce_glyphless_glyph): Handle cons cell entry in
2436 glyphless-char-display.
2437 (Vglyphless_char_display): Document it.
2439 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2440 glyphless-char-display.
2442 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2444 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2446 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2448 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2449 definition for no-X builds.
2451 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2453 Static checks with GCC 4.6.0 and non-default toolkits.
2455 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2457 * process.c (keyboard_bit_set): Define only if SIGIO.
2458 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2459 (send_process): Repair possible setjmp clobbering.
2461 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2463 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2465 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2467 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2468 Define only if needed.
2470 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2471 by pacifying GCC about it. Maybe it's time to retire it?
2472 * xfaces.c (USG, __TIMEVAL__): Likewise.
2474 * dispextern.h (struct redisplay_interface): Rename param
2476 * termhooks.h (struct terminal): Likewise.
2477 * xterm.c (xembed_send_message): Likewise.
2479 * insdel.c (make_gap_smaller): Define only if
2480 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2482 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2485 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2486 so that we aren't warned about unused symbols.
2488 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2490 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2492 * xfns.c (x_real_positions): Mark locals as initialized.
2494 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2496 * xterm.c: Fix problems found by static analysis with other toolkits.
2497 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2498 (x_dispatch_event): Declare static if USE_GTK, and
2499 define if USE_GTK || USE_X_TOOLKIT.
2500 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2501 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2502 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2503 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2505 * xmenu.c (menu_help_callback): Pointer type fixes.
2506 Use const pointers when pointing at readonly data. Avoid pointer
2508 (FALSE): Remove unused macro.
2509 (update_frame_menubar): Remove unused decl.
2511 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2513 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2514 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2515 (single_menu_item): Rename local to avoid shadowing.
2517 * keyboard.c (make_lispy_event): Remove unused local var.
2519 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2520 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2522 * bitmaps: Change bitmaps from unsigned char back to the X11
2523 compatible char. Avoid the old compiler warnings about
2524 out-of-range initializers by using, for example, '\xab' rather
2527 * xgselect.c (xgselect_initialize): Check vs interface
2528 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2530 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2532 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2533 to read-only memory.
2535 * fns.c (vector): Remove; this old hack is no longer needed.
2537 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2539 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2541 * xrdb.c (x_load_resources): Omit unused local.
2543 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2544 (x_window): Rename locals to avoid shadowing.
2545 (USG): Use the kludged USG macro, to pacify gcc.
2547 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2548 (x_term_init): Remove local to avoid shadowing.
2550 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2552 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2553 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2555 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2557 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2559 Fix regex.c, syntax.c and friends for buffers > 2GB.
2560 * syntax.h (struct gl_state_s): Declare character position members
2563 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2565 * textprop.c (verify_interval_modification, interval_of):
2566 Declare arguments EMACS_INT.
2568 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2571 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2573 * indent.c (Fvertical_motion): Local variable it_start is now
2576 * regex.c (re_match, re_match_2, re_match_2_internal)
2577 (bcmp_translate, regcomp, regexec, print_double_string)
2578 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2579 (re_compile_pattern, re_exec): Declare arguments and local
2580 variables `size_t' and `ssize_t' and return values `regoff_t', as
2582 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2583 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2584 <compile_stack_type>: `size' and `avail' are now `size_t'.
2586 * regex.h <regoff_t>: Use ssize_t, not int.
2587 (re_search, re_search_2, re_match, re_match_2): Arguments that
2588 specify buffer/string position and length are now ssize_t and
2589 size_t. Return type is regoff_t.
2591 2011-04-16 Ben Key <bkey76@gmail.com>
2593 * nsfont.m: Fixed bugs in ns_get_family and
2594 ns_descriptor_to_entity that were caused by using free to
2595 deallocate memory blocks that were allocated by xmalloc (via
2596 xstrdup). This caused Emacs to crash when compiled with
2597 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2598 --enable-checking=xmallocoverrun). xfree is now used to
2599 deallocate these memory blocks.
2601 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2603 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2605 emacs_write: Accept and return EMACS_INT for sizes.
2606 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2608 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2609 Accept and return EMACS_INT.
2610 (emacs_gnutls_write): Return the number of bytes written on
2612 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2613 (emacs_read, emacs_write): Remove check for negative size, as the
2614 Emacs source code has been audited now.
2615 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2616 (emacs_read, emacs_write): Use it.
2617 * process.c (send_process): Adjust to the new signatures of
2618 emacs_write and emacs_gnutls_write. Do not attempt to store
2619 a byte offset into an 'int'; it might overflow.
2620 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2622 * sound.c: Don't assume sizes fit in 'int'.
2623 (struct sound_device.period_size, alsa_period_size):
2624 Return EMACS_INT, not int.
2625 (struct sound_device.write, vox_write, alsa_write):
2626 Accept EMACS_INT, not int.
2627 (wav_play, au_play): Use EMACS_INT to store sizes and to
2628 record read return values.
2630 2011-04-15 Ben Key <bkey76@gmail.com>
2632 * keyboard.c (Qundefined): Don't declare static since it is used
2634 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2635 static since they are used in nsfont.m.
2637 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2639 * process.c (Qprocessp): Don't declare static.
2640 * lisp.h (Qprocessp): Declare again.
2642 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2644 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2646 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2648 Improve C-level modularity by making more things 'static'.
2650 Don't publish debugger-only interfaces to other modules.
2651 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2652 (verify_bytepos, count_markers): Move decls to the only modules
2654 * region-cache.h (pp_cache): Likewise.
2655 * window.h (check_all_windows): Likewise.
2656 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2658 * sysdep.c (croak): Now static, if
2659 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2660 * syssignal.h (croak): Declare only if not static.
2662 * alloc.c (refill_memory_reserve): Now static if
2663 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2664 * lisp.h (refill_memory_reserve): Declare only if not static.
2666 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2667 Define only if USE_LUCID.
2669 * xrdb.c (x_customization_string, x_rm_string): Now static.
2671 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2672 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2674 * xdisp.c (draw_row_with_mouse_face): Now static.
2675 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2677 * window.h (check_all_windows): Mark externally visible.
2679 * window.c (window_deletion_count): Now static.
2681 * undo.c: Make symbols static if they're not exported.
2682 (last_undo_buffer, last_boundary_position, pending_boundary):
2685 * textprop.c (interval_insert_behind_hooks): Now static.
2686 (interval_insert_in_front_hooks): Likewise.
2688 * term.c: Make symbols static if they're not exported.
2689 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2690 (max_frame_lines, tty_set_terminal_modes):
2691 (tty_reset_terminal_modes, tty_turn_off_highlight):
2692 (get_tty_terminal): Now static.
2693 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2694 * termhooks.h (term_mouse_moveto): Do not declare if
2696 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2697 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2699 * sysdep.c: Make symbols static if they're not exported.
2700 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2702 (sigprocmask_set, full_mask): Remove; unused.
2703 (wait_debugging): Mark as visible.
2704 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2705 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2707 * syntax.c (syntax_temp): Define only if !__GNUC__.
2709 * sound.c (current_sound_device, current_sound): Now static.
2711 * search.c (searchbufs, searchbuf_head): Now static.
2713 * scroll.c (scroll_cost): Remove; unused.
2714 * dispextern.h (scroll_cost): Remove decl.
2716 * region-cache.h (pp_cache): Mark as externally visible.
2718 * process.c: Make symbols static if they're not exported.
2719 (process_tick, update_tick, create_process, chan_process):
2720 (Vprocess_alist, proc_buffered_char, datagram_access):
2721 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2722 (deactivate_process): Mark defn as static, as well as decl.
2723 * lisp.h (create_process): Remove decl.
2724 * process.h (chan_process, Vprocess_alist): Remove decls.
2726 * print.c: Make symbols static if they're not exported.
2727 (print_depth, new_backquote_output, being_printed, print_buffer):
2728 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2729 (print_interval, print_number_index, initial_stderr_stream):
2731 * lisp.h (Fprinc): Remove decl.
2732 (debug_output_compilation_hack): Mark as externally visible.
2734 * sysdep.c (croak): Move decl from here to syssignal.h.
2735 * syssignal.h (croak): Put it here, so the API can be checked when
2736 'croak' is called from dissociate_if_controlling_tty.
2738 * minibuf.c: Make symbols static if they're not exported.
2739 (minibuf_save_list, choose_minibuf_frame): Now static.
2740 * lisp.h (choose_minibuf_frame): Remove decl.
2742 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2744 * lread.c: Make symbols static if they're not exported.
2745 (read_objects, initial_obarray, oblookup_last_bucket_number):
2747 (make_symbol): Remove; unused.
2748 * lisp.h (initial_obarray, make_symbol): Remove decls.
2750 * keyboard.c: Make symbols static if they're not exported.
2751 (single_kboard, recent_keys_index, total_keys, recent_keys):
2752 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2753 (this_single_command_key_start, echoing, last_auto_save):
2754 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2755 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2756 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2757 (Vlispy_mouse_stem, double_click_count):
2759 (force_auto_save_soon): Define only if SIGDANGER.
2760 (ignore_mouse_drag_p): Now static if
2761 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2762 (print_help): Remove; unused.
2763 (stop_character, last_timer_event): Mark as externally visible.
2764 * keyboard.h (ignore_mouse_drag_p): Declare only if
2765 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2766 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2767 * lisp.h (echoing): Remove decl.
2768 (force_auto_save_soon): Declare only if SIGDANGER.
2769 * xdisp.c (redisplay_window): Simplify code, to make it more
2770 obvious that ignore_mouse_drag_p is not accessed if !defined
2771 USE_GTK && !defined HAVE_NS.
2773 * intervals.c: Make symbols static if they're not exported.
2774 (merge_properties_sticky, merge_interval_right, delete_interval):
2776 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2778 * insdel.c: Make symbols static if they're not exported.
2779 However, leave prepare_to_modify_buffer alone. It's never
2780 called from outside this function, but that appears to be a bug.
2781 (combine_after_change_list, combine_after_change_buffer):
2782 (adjust_after_replace, signal_before_change): Now static.
2783 (adjust_after_replace_noundo): Remove; unused.
2784 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2785 (signal_before_change): Remove decls.
2787 * indent.c (val_compute_motion, val_vmotion): Now static.
2789 * image.c: Make symbols static if they're not exported.
2790 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2792 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2793 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2795 * fringe.c (standard_bitmaps): Now static.
2796 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2798 * frame.c: Make symbols static if they're not exported.
2799 (x_report_frame_params, make_terminal_frame): Now static.
2800 (get_frame_param): Now static, unless HAVE_NS.
2801 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2802 (x_get_resource_string): Remove; not used.
2803 * frame.h (make_terminal_frame, x_report_frame_params):
2804 (x_get_resource_string); Remove decls.
2805 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2806 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2808 * font.c, fontset.c: Make symbols static if they're not exported.
2809 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2810 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2811 * font.c (font_close_object): Now static.
2812 * font.h (font_close_object): Remove.
2813 * fontset.c (FONTSET_OBJLIST): Remove.
2814 (free_realized_fontset) #if-0 the body, which does nothing.
2815 (face_suitable_for_char_p): #if-0, as it's never called.
2816 * fontset.h (face_suitable_for_char_p): Remove decl.
2817 * xfaces.c (face_at_string_position):
2818 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2819 since 0 is always ASCII.
2821 * fns.c (weak_hash_tables): Now static.
2823 * fileio.c: Make symbols static if they're not exported.
2824 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2825 (Vwrite_region_annotation_buffers): Now static.
2827 * eval.c: Make symbols static if they're not exported.
2828 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2829 * lisp.h (backtrace_list): Remove decl.
2831 * emacs.c: Make symbols static if they're not exported.
2832 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2833 (fatal_error_code, fatal_error_signal_hook, standard_args):
2835 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2836 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2837 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2838 * lisp.h (fatal_error_signal_hook): Remove decl.
2839 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2841 * editfns.c: Move a (normally-unused) function to its only use.
2842 * editfns.c, lisp.h (get_operating_system_release): Remove.
2843 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2844 worth the hassle of breaking this out.
2846 * xterm.c: Make symbols static if they're not exported.
2847 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2848 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2849 (x_destroy_window, x_delete_display):
2851 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2852 (x_mouse_leave): Remove; unused.
2853 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2854 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2855 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2857 (x_mouse_leave): Declare only if WINDOWSNT.
2858 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2859 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2862 * ftxfont.c: Make symbols static if they're not exported.
2863 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2865 * font.h (ftxfont_driver): Likewise.
2867 * xfns.c: Make symbols static if they're not exported.
2868 (x_last_font_name, x_display_info_for_name):
2869 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2870 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2871 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2872 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2873 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2874 (last_show_tip_args): Now static.
2875 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2876 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2877 (x_screen_planes): Remove; unused.
2878 * dispextern.h (x_screen_planes): Remove decl.
2880 * dispnew.c: Make symbols static if they're not exported.
2881 * dispextern.h (redraw_garbaged_frames, scrolling):
2882 (increment_row_positions): Remove.
2883 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2884 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2886 (redraw_garbaged_frames): Remove; unused.
2888 * xfaces.c: Make symbols static if they're not exported.
2889 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2891 * xterm.h (defined_color): Remove decls.
2892 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2893 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2894 (menu_face_changed_default, defined_color, free_realized_face):
2895 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2896 (ascii_face_of_lisp_face): Remove; unused.
2898 * xdisp.c: Make symbols static if they're not exported.
2899 * dispextern.h (scratch_glyph_row, window_box_edges):
2900 (glyph_to_pixel_coords, set_cursor_from_row):
2901 (get_next_display_element, set_iterator_to_next):
2902 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2903 (show_mouse_face): Remove decls
2904 * frame.h (message_buf_print): Likewise.
2905 * lisp.h (pop_message, set_message, check_point_in_composition):
2907 * xterm.h (set_vertical_scroll_bar): Likewise.
2908 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2909 (message_buf_print, scratch_glyph_row, displayed_buffer):
2910 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2911 (get_next_display_element, show_mouse_face, window_box_edges):
2912 (frame_to_window_pixel_xy, check_point_in_composition):
2913 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2914 (glyph_to_pixel_coords): Remove; unused.
2916 * dired.c (file_name_completion): Now static.
2918 * dbusbind.c (xd_in_read_queued_messages): Now static.
2920 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2921 * data.c (circular_list_error): Remove.
2923 * commands.h (last_point_position, last_point_position_buffer):
2924 (last_point_position_window): Remove decls.
2925 * keyboard.c: Make these variables static.
2927 * coding.h (coding, code_convert_region, encode_coding_gap):
2929 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2930 (iso_code_class, detect_coding, code_convert_region): Now static.
2931 (encode_coding_gap): Remove; unused.
2933 * chartab.c (chartab_chars, chartab_bits): Now static.
2935 * charset.h (charset_iso_8859_1): Remove decl.
2936 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2939 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2940 * ccl.c (Vccl_program_table): Now static.
2941 (check_ccl_update): Remove; unused.
2943 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2944 * category.h: ... from here.
2945 * category.c (check_category_table, set_category_set): Now static.
2947 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2948 * lisp.h: Remove these decls.
2950 * buffer.c (buffer_count): Remove unused var.
2952 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2953 so that it's not optimized away.
2954 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2955 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2956 exported only to the debugger.
2958 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2959 * atimer.h (run_all_atimers): Remove; not exported.
2961 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2962 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2963 was inaccessible from Lisp.
2964 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2965 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2967 alloc.c: Import and export fewer symbols, and remove unused items.
2968 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2970 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2971 it's not optimized away by whole-program optimization.
2972 (message_enable_multibyte, free_misc): Remove.
2973 (catchlist, handlerlist, mark_backtrace):
2974 Declare only if BYTE_MARK_STACK.
2975 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2976 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2977 (message_enable_multibyte): Remove decl.
2978 (free_misc, interval_free_list, float_block, float_block_index):
2979 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2980 (cons_free_list, last_marked_index):
2982 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2983 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2984 (mark_backtrace): Define only if BYTE_MARK_STACK.
2985 * xdisp.c (message_enable_multibyte): Now static.
2987 Declare Lisp_Object Q* variables to be 'static' if not exported.
2988 This makes it easier for human readers (and static analyzers)
2989 to see whether these variables are used from other modules.
2990 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2991 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2992 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2993 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2994 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2995 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2996 * xmenu.c, xselect.c:
2997 Declare Q* vars static if they are not used in other modules.
2998 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2999 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3000 Remove decls of unexported vars.
3001 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3003 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3005 Make Emacs functions such as Fatom 'static' by default.
3006 This makes it easier for human readers (and static analyzers)
3007 to see whether these functions can be called from other modules.
3008 DEFUN now defines a static function. To make the function external
3009 so that it can be used in other C modules, use the new macro DEFUE.
3010 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3011 (Finit_image_library):
3012 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3013 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3014 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3015 Remove decls, since these functions are now static.
3016 (Funintern, Fget_internal_run_time): New decls, since these functions
3017 were already external.
3019 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3020 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3021 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3022 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3023 * keyboard.c, keymap.c, lread.c:
3024 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3025 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3026 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3027 Mark functions with DEFUE instead of DEFUN,
3028 if they are used in other modules.
3029 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3030 decls for now-static functions.
3031 * buffer.h (Fdelete_overlay): Remove decl.
3032 * callproc.c (Fgetenv_internal): Mark as internal.
3033 * composite.c (Fremove_list_of_text_properties): Remove decl.
3034 (Fcomposition_get_gstring): New forward static decl.
3035 * composite.h (Fcomposite_get_gstring): Remove decl.
3036 * dired.c (Ffile_attributes): New forward static decl.
3037 * doc.c (Fdocumntation_property): New forward static decl.
3038 * eval.c (Ffetch_bytecode): New forward static decl.
3039 (Funintern): Remove extern decl; now in .h file where it belongs.
3040 * fileio.c (Fmake_symbolic_link): New forward static decl.
3041 * image.c (Finit_image_library): New forward static decl.
3042 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3043 * intervals.h (Fprevious_property_change):
3044 (Fremove_list_of_text_properties): Remove decls.
3045 * keyboard.c (Fthis_command_keys): Remove decl.
3046 (Fcommand_execute): New forward static decl.
3047 * keymap.c (Flookup_key): New forward static decl.
3048 (Fcopy_keymap): Now static.
3049 * keymap.h (Flookup_key): Remove decl.
3050 * process.c (Fget_process): New forward static decl.
3051 (Fprocess_datagram_address): Mark as internal.
3052 * syntax.c (Fsyntax_table_p): New forward static decl.
3053 (skip_chars): Remove duplicate decl.
3054 * textprop.c (Fprevious_property_change): New forward static decl.
3055 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3057 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3058 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3060 * editfns.c (Fformat): Remove unreachable code.
3062 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3064 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3067 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3069 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3070 when at ZV. (Bug#8487)
3072 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3074 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3076 * keyboard.c (parse_tool_bar_item): Likewise.
3077 * sound.c (sound_cleanup, alsa_close): Likewise.
3078 * termcap.c (tgetent): Likewise.
3079 * xfns.c (x_default_font_parameter): Likewise.
3080 * xsettings.c (read_and_apply_settings): Likewise.
3082 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3083 (overrun_check_free): Protoize.
3085 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3087 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3088 since callers should never pass a negative size.
3089 Change the signature to match that of plain 'read' and 'write'; see
3090 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3091 * lisp.h: Update prototypes of emacs_write and emacs_read.
3093 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3095 * xdisp.c (redisplay_window): Don't try to determine the character
3096 position of the scroll margin if the window start point w->startp
3097 is outside the buffer's accessible region. (Bug#8468)
3099 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3101 Fix write-region and its subroutines for buffers > 2GB.
3102 * fileio.c (a_write, e_write): Modify declaration of arguments and
3103 local variables to support buffers larger than 2GB.
3104 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3106 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3107 argument, local variables, and return value.
3109 * lisp.h: Update prototypes of emacs_write and emacs_read.
3111 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3113 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3115 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3117 Fix more problems found by GCC 4.6.0's static checks.
3119 * xdisp.c (vmessage): Use a better test for character truncation.
3121 * charset.c (load_charset_map): <, not <=, for optimization,
3122 and to avoid potential problems with integer overflow.
3123 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3124 * casetab.c (set_identity, shuffle): Likewise.
3125 * editfns.c (Fformat): Likewise.
3126 * syntax.c (skip_chars): Likewise.
3128 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3129 This also lets GCC 4.6.0 generate slightly better loop code.
3131 * callint.c (Fcall_interactively): <, not <=, for optimization.
3132 (Fcall_interactively): Count the number of arguments produced,
3133 not the number of arguments given. This is simpler and lets GCC
3134 4.6.0 generate slightly better code.
3136 * ftfont.c: Distingish more carefully between FcChar8 and char.
3137 The previous code passed unsigned char * to a functions like
3138 strlen and xstrcasecmp that expect char *, which does not
3139 conform to the C standard.
3140 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3141 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3142 char * when the C standard requires it.
3144 * keyboard.c (read_char): Remove unused var.
3146 * eval.c: Port to Windows vsnprintf (Bug#8435).
3148 (SIZE_MAX): Define if the headers do not.
3149 (verror): Do not give up if vsnprintf returns a negative count.
3150 Instead, grow the buffer. This ports to Windows vsnprintf, which
3151 does not conform to C99. Problem reported by Eli Zaretskii.
3152 Also, simplify the allocation scheme, by avoiding the need for
3153 calling realloc, and removing the ALLOCATED variable.
3155 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3157 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3158 But keep the doprint source code for now, as we might revamp it
3159 and use it again (Bug#8435).
3160 * lisp.h (doprnt): Remove.
3161 * Makefile.in (base_obj): Remove doprnt.o.
3162 * deps.mk (doprnt.o): Remove.
3164 error: Print 32- and 64-bit integers portably (Bug#8435).
3165 Without this change, on typical 64-bit hosts error ("...%d...", N)
3166 was used to print both 32- and 64-bit integers N, which relied on
3168 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3170 * lisp.h (error, verror): Mark as printf-like functions.
3171 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3172 Report overflow in size calculations when allocating printf buffer.
3173 Do not truncate output string at its first null byte.
3174 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3175 Truncate the output at a character boundary, since vsnprintf does not
3177 * charset.c (check_iso_charset_parameter): Convert internal
3178 character to string before calling 'error', since %c now has the
3180 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3181 overflow when computing char to be passed to 'error'. Do not
3182 pass Lisp_Object to 'error'; pass the integer instead.
3183 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3184 formatted with plain %d.
3186 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3188 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3190 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3192 * xterm.c (x_catch_errors): Remove duplicate declaration.
3194 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3196 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3198 2011-04-10 Jim Meyering <meyering@redhat.com>
3200 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3201 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3202 return ssize_t not "int", and use size_t as the buffer length.
3203 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3204 * gnutls.h: Update declarations.
3205 * process.c (read_process_output): Use ssize_t, to match.
3206 (send_process): Likewise.
3208 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3210 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3212 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3214 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3215 Use unsigned char, to match FcChar8 type definition.
3217 * xterm.c (handle_one_xevent):
3218 * xmenu.c (create_and_show_popup_menu):
3219 * xselect.c (x_decline_selection_request)
3220 (x_reply_selection_request): Avoid type-punned deref of X events.
3222 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3224 Fix some uses of `int' instead of EMACS_INT.
3225 * search.c (string_match_1, fast_string_match)
3226 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3227 (scan_buffer, find_next_newline_no_quit)
3228 (find_before_next_newline, search_command, Freplace_match)
3229 (Fmatch_data): Make some `int' variables be EMACS_INT.
3231 * xdisp.c (display_count_lines): 3rd argument and return value now
3232 EMACS_INT. All callers changed.
3233 (pint2hrstr): Last argument is now EMACS_INT.
3235 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3236 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3237 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3238 (decode_coding_utf_16, decode_coding_emacs_mule)
3239 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3240 (decode_coding_ccl, decode_coding_charset)
3241 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3242 (decode_coding_iso_2022, decode_coding_emacs_mule)
3243 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3244 <char_offset, last_offset>: Declare EMACS_INT.
3245 (encode_coding_utf_8, encode_coding_utf_16)
3246 (encode_coding_emacs_mule, encode_invocation_designation)
3247 (encode_designation_at_bol, encode_coding_iso_2022)
3248 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3249 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3251 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3252 (encode_invocation_designation): Last argument P_NCHARS is now
3254 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3255 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3257 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3260 * ccl.c (Fccl_execute_on_string): Declare some variables
3263 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3265 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3267 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3269 * process.c (Fformat_network_address): Doc fix.
3271 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3273 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3275 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3277 * keyboard.c (read_char): Call Lisp function help-form-show,
3278 instead of using internal_with_output_to_temp_buffer.
3279 (Qhelp_form_show): New var.
3280 (syms_of_keyboard): Use DEFSYM macro.
3282 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3284 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3286 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3288 * process.c (Flist_processes): Remove to Lisp.
3289 (list_processes_1): Delete.
3291 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3293 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3295 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3297 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3299 Fix more problems found by GCC 4.6.0's static checks.
3301 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3303 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3305 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3307 * xdisp.c (vmessage): Mark as a printf-like function.
3309 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3311 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3313 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3314 printf-like functions.
3315 (tiff_load): Add casts to remove these marks before passing them
3316 to system-supplied API.
3318 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3320 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3321 This avoids several warnings with gcc -Wstrict-overflow.
3322 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3323 directly, rather than having caller test rule sign. This avoids
3324 some unnecessary tests.
3325 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3326 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3327 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3329 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3330 (xfont_open): Avoid unnecessary tests.
3332 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3334 * composite.h, composite.c (composition_gstring_put_cache):
3335 Use EMACS_INT, not int, for length.
3337 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3338 breaking out part of COMPOSITION_DECODE_RULE.
3339 (COMPOSITION_DECODE_RULE): Use it.
3340 * composite.c (get_composition_id): Remove unused local vars,
3341 by using the new macro.
3343 * textprop.c (set_text_properties_1): Change while to do-while,
3344 since the condition is always true at first.
3346 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3347 (interval_deletion_adjustment): Return unsigned value.
3350 * process.c (list_processes_1, create_pty, read_process_output):
3351 (exec_sentinel): Remove vars that were set but not used.
3352 (create_pty): Remove unnecessary "volatile"s.
3353 (Fnetwork_interface_info): Avoid possibility of int overflow.
3354 (read_process_output): Do adaptive read buffering even if carryover.
3355 (read_process_output): Simplify nbytes computation if buffered.
3357 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3359 * syntax.c (scan_words): Remove var that was set but not used.
3360 (update_syntax_table): Use unsigned instead of int.
3362 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3363 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3364 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3366 * print.c (print_error_message): Avoid int overflow.
3368 * font.c (font_list_entities): Redo for clarity,
3369 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3371 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3372 (font_score): Avoid potential overflow in diff calculation.
3374 * fns.c (substring_both): Remove var that is set but not used.
3375 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3377 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3379 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3380 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3381 can always succeed if overflow has undefined behavior.
3383 * search.c (boyer_moore, wordify): Remove vars set but not used.
3384 (wordify): Omit three unnecessary tests.
3386 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3387 All callers changed. This avoids the need for an unused var.
3389 * casefiddle.c (casify_region): Remove var that is set but not used.
3391 * dired.c (file_name_completion): Remove var that is set but not used.
3393 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3395 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3396 (Finsert_file_contents): Remove unnecessary code checking fd.
3398 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3399 Check for integer overflow on size calculations.
3401 * buffer.c (Fprevious_overlay_change): Remove var that is set
3404 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3405 Remove vars that are set but not used.
3406 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3407 (timer_check_2): Mark vars as initialized.
3409 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3411 * image.c (lookup_image): Remove var that is set but not used.
3412 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3414 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3415 that are set but not used.
3417 * xfns.c (make_invisible_cursor): Don't return garbage
3418 if XCreateBitmapFromData fails (Bug#8410).
3420 * xselect.c (x_get_local_selection, x_handle_property_notify):
3421 Remove vars that are set but not used.
3423 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3424 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3426 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3427 Remove var that is set but not used.
3428 (scroll_bar_windows_size): Now size_t, not int.
3429 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3432 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3433 (map_tty_color) [!defined MSDOS]: Likewise.
3435 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3437 * coding.c: Remove vars that are set but not used.
3438 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3439 All callers changed.
3440 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3441 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3442 (decode_coding_charset): Remove vars that are set but not used.
3444 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3445 that is set but not used.
3447 * print.c (print_object): Remove var that is set but not used.
3449 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3450 The gnulib version avoids calling malloc in the usual case,
3451 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3452 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3453 * filelock.c (current_lock_owner): Likewise.
3454 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3455 * sysdep.c: Include allocator.h, careadlinkat.h.
3456 (emacs_no_realloc_allocator): New static constant.
3457 (emacs_readlink): New function.
3458 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3459 ../lib/careadlinkat.h.
3461 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3463 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3464 first non-nil return value).
3466 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3468 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3469 if not defined (Bug#8403).
3471 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3473 * xdisp.c (display_count_lines): Remove parameter `start',
3474 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3475 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3476 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3477 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3478 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3479 and thereabouts. All callers changed.
3480 (get_per_char_metric): Remove parameter `f', unused since
3481 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3483 2011-04-02 Jim Meyering <meyering@redhat.com>
3485 do not dereference NULL upon failed strdup
3486 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3487 (ns_get_family): Likewise.
3489 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3491 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3493 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3495 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3498 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3500 Add lexical binding.
3502 * window.c (Ftemp_output_buffer_show): New fun.
3503 (Fsave_window_excursion):
3504 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3506 * lread.c (lisp_file_lexically_bound_p): New function.
3507 (Fload): Bind Qlexical_binding.
3508 (readevalloop): Remove `evalfun' arg.
3509 Bind Qinternal_interpreter_environment.
3510 (Feval_buffer): Bind Qlexical_binding.
3511 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3513 (syms_of_lread): Declare `lexical-binding'.
3515 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3517 * keyboard.c (eval_dyn): New fun.
3518 (menu_item_eval_property): Use it.
3520 * image.c (parse_image_spec): Use Ffunctionp.
3522 * fns.c (concat, mapcar1): Accept byte-code-functions.
3524 * eval.c (Fsetq): Handle lexical vars.
3525 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3526 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3527 (FletX, Flet): Obey lexical binding.
3528 (Fcommandp): Handle closures.
3529 (Feval): New `lexical' arg.
3530 (eval_sub): New function extracted from Feval. Use it almost
3531 everywhere where Feval was used. Look up vars in lexical env.
3533 (Ffunctionp): Move from subr.el.
3534 (Ffuncall): Handle closures.
3535 (apply_lambda): Remove `eval_flags'.
3536 (funcall_lambda): Handle closures and new byte-code-functions.
3537 (Fspecial_variable_p): New function.
3538 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3539 but without exporting it to Lisp.
3541 * doc.c (Fdocumentation, store_function_docstring):
3542 * data.c (Finteractive_form): Handle closures.
3544 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3547 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3549 (exec_byte_code): New function extracted from Fbyte_code to handle new
3550 calling convention for byte-code-functions. Add new byte-codes.
3552 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3554 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3556 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3558 * xdisp.c (redisplay_internal): Fix prototype.
3560 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3562 * xdisp.c (SCROLL_LIMIT): New macro.
3563 (try_scrolling): Use it when setting scroll_limit.
3564 Limit scrolling to 100 screen lines.
3565 (redisplay_window): Even when falling back on "recentering",
3566 position point in the window according to scroll-conservatively,
3567 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3569 (try_scrolling): When point is above the window, allow searching
3570 as far as scroll_max, or one screenful, to compute vertical
3571 distance from PT to the scroll margin position. This prevents
3572 try_scrolling from unnecessarily failing when
3573 scroll-conservatively is set to a value slightly larger than the
3574 window height. Clean up the case of PT below the margin at bottom
3575 of window: scroll_max can no longer be INT_MAX. When aggressive
3576 scrolling is in use, don't let point enter the opposite scroll
3577 margin as result of the scroll.
3578 (syms_of_xdisp) <scroll-conservatively>: Document the
3579 threshold of 100 lines for never-recentering scrolling.
3581 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3583 * dispextern.h (move_it_by_lines):
3584 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3585 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3586 (message_log_check_duplicate): Remove parameters `prev_bol' and
3587 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3588 (redisplay_internal): Remove parameter `preserve_echo_area',
3589 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3591 * indent.c (Fvertical_motion):
3592 * window.c (window_scroll_pixel_based, Frecenter):
3593 Don't pass `need_y_p' to `move_it_by_lines'.
3595 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3597 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3598 steal a few bits to be more compact.
3599 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3600 Remove unneeded casts.
3602 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3604 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3606 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3607 binding" message (bug#7967).
3609 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3611 Fix more problems found by GCC 4.6.0's static checks.
3613 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3614 Remove unused local var.
3616 * editfns.c (Fmessage_box): Remove unused local var.
3618 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3619 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3620 Omit unused local vars.
3621 * window.c (shrink_windows): Omit unused local var.
3622 * menu.c (digest_single_submenu): Omit unused local var.
3623 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3624 Omit unused local var.
3626 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3627 Don't assume string length fits in int.
3628 (keyremap_step, read_key_sequence): Use size_t for sizes.
3629 (read_key_sequence): Don't check last_real_key_start redundantly.
3631 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3632 instead of alloca (Bug#8344).
3634 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3635 (Fbacktrace_frame): Don't assume nframes fits in int.
3637 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3639 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3642 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3644 * cm.c (calccost): Turn while-do into do-while, for clarity.
3646 * keyboard.c (syms_of_keyboard): Use the same style as later
3647 in this function when indexing through an array. This also
3648 works around GCC bug 48267.
3650 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3652 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3654 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3655 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3657 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3658 This avoids undefined behavior on integer overflow, and is a bit
3659 more convenient anyway since it is compared to a size_t variable.
3661 Variadic C functions now count arguments with size_t, not int.
3662 This avoids an unnecessary limitation on 64-bit machines, which
3663 caused (substring ...) to crash on large vectors (Bug#8344).
3664 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3665 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3666 All variadic functions and their callers changed accordingly.
3667 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3668 * data.c (arith_driver, float_arith_driver): Likewise.
3669 * editfns.c (general_insert_function): Likewise.
3670 * eval.c (struct backtrace.nargs, interactive_p)
3671 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3672 (funcall_lambda, mark_backtrace): Likewise.
3673 * fns.c (concat): Likewise.
3674 * frame.c (x_set_frame_parameters): Likewise.
3675 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3676 0 if not found, not -1. All callers changed.
3678 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3679 (stack_copy_size): Now size_t, not int.
3680 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3682 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3684 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3685 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3686 All callers changed.
3688 * lisp.h (multibyte_char_to_unibyte):
3689 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3690 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3691 * character.h (CHAR_TO_BYTE8):
3692 * cmds.c (internal_self_insert):
3693 * editfns.c (general_insert_function):
3694 * keymap.c (push_key_description):
3695 * search.c (Freplace_match):
3696 * xdisp.c (message_dolog, set_message_1): All callers changed.
3698 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3700 * keyboard.c (safe_run_hook_funcall): New function.
3701 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3702 don't set the hook to nil, but remove the offending function instead.
3703 (Qcommand_hook_internal): Remove, unused.
3704 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3705 Vcommand_hook_internal.
3707 * eval.c (enum run_hooks_condition): Remove.
3708 (funcall_nil, funcall_not): New functions.
3709 (run_hook_with_args): Call each function through a `funcall' argument.
3710 Remove `cond' argument, now redundant.
3711 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3712 (Frun_hook_with_args_until_failure): Adjust accordingly.
3713 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3715 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3717 * dispextern.h (string_buffer_position): Remove declaration.
3719 * print.c (strout): Remove parameter `multibyte', unused since
3720 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3722 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3723 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3724 All callers changed.
3726 * w32.c (_wsa_errlist): Use braces for struct initializers.
3728 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3729 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3730 All callers changed.
3731 (string_buffer_position): Likewise. Also, make static (it's never
3732 used outside xdisp.c).
3733 (cursor_row_p): Remove parameter `w', unused since
3734 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3735 (decode_mode_spec): Remove parameter `precision', introduced during
3736 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3737 All callers changed.
3739 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3741 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3743 2011-03-27 Anders Lindgren <andlind@gmail.com>
3745 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3746 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3747 (ns_update_auto_hide_menu_bar): New functions.
3748 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3749 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3750 ns_constrain_all_frames.
3751 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3752 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3754 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3756 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3758 2011-03-27 Glenn Morris <rgm@gnu.org>
3760 * syssignal.h: Replace RETSIGTYPE with void.
3761 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3762 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3763 Replace SIGTYPE with void everywhere.
3764 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3765 * s/template.h (SIGTYPE): Remove commented out definition.
3767 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3769 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3770 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3772 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3774 * w32.c (read_unc_volume): Use parameter `henum', instead of
3775 global variable `wget_enum_handle'.
3777 * keymap.c (describe_vector): Remove parameters `indices' and
3778 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3779 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3781 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3783 * keyboard.c (timer_check): Remove parameter `do_it_now',
3784 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3785 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3786 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3788 * keyboard.c (read_char):
3789 * w32menu.c (w32_menu_display_help):
3790 * xmenu.c (show_help_event, menu_help_callback):
3791 Adjust calls to `show_help_echo'.
3793 * gtkutil.c (xg_maybe_add_timer):
3794 * keyboard.c (readable_events):
3795 * process.c (wait_reading_process_output):
3796 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3798 * insdel.c (adjust_markers_gap_motion):
3799 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3800 (gap_left, gap_right): Don't call it.
3802 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3804 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3805 incurred during fontification.
3807 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3809 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3810 (DEFVAR_PER_BUFFER): Don't pass it.
3812 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3813 (scrolling_window): Don't pass it.
3815 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3817 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3819 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3821 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3822 of variables specific to SELinux and computation of `encoded_absname'.
3824 * image.c (XPutPixel): Remove unused variable `height'.
3826 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3828 * unexw32.c (get_section_info): Remove unused variable `section'.
3830 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3831 (system_process_attributes): Remove unused variable `sess'.
3832 (sys_read): Remove unused variable `err'.
3834 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3835 (w32_wnd_proc): Remove unused variable `isdead'.
3836 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3837 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3838 (x_create_tip_frame): Remove unused variable `tem'.
3840 * w32inevt.c (w32_console_read_socket):
3841 Remove unused variable `no_events'.
3843 * w32term.c (x_draw_composite_glyph_string_foreground):
3844 Remove unused variable `width'.
3846 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3848 * w32term.c (x_set_glyph_string_clipping):
3849 Don't pass uninitialized region to CombineRgn.
3851 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3853 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3854 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3855 (Fx_close_connection): Remove unused variable `i'.
3857 * w32font.c (w32font_draw): Return number of glyphs.
3858 (w32font_open_internal): Remove unused variable `i'.
3859 (w32font_driver): Add missing initializer.
3861 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3862 (fill_in_menu): Remove unused variable `items_added'.
3864 * w32term.c (last_mouse_press_frame): Remove static global variable.
3865 (w32_clip_to_row): Remove unused variable `f'.
3866 (x_delete_terminal): Remove unused variable `i'.
3868 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3869 (NOTHING): Remove unused static global variable.
3870 (uniscribe_check_otf): Remove unused variable `table'.
3871 (uniscribe_font_driver): Add missing initializers.
3873 2011-03-23 Julien Danjou <julien@danjou.info>
3875 * term.c (Fsuspend_tty, Fresume_tty):
3876 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3877 * window.c (temp_output_buffer_show):
3878 * insdel.c (signal_before_change):
3879 * frame.c (Fhandle_switch_frame):
3880 * fileio.c (Fdo_auto_save):
3881 * emacs.c (Fkill_emacs):
3882 * editfns.c (save_excursion_restore):
3883 * cmds.c (internal_self_insert):
3884 * callint.c (Fcall_interactively):
3885 * buffer.c (Fkill_all_local_variables):
3886 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3888 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3889 unconditionnaly since it does the check itself.
3891 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3893 Fix more problems found by GCC 4.5.2's static checks.
3895 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3896 the first time through the loop, since we know p0 < p1 then.
3897 This also avoids a gcc -Wstrict-overflow warning.
3899 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3900 leading to a memory leak, possible in functions like
3901 load_charset_map_from_file that can allocate an unbounded number
3902 of objects (Bug#8318).
3904 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3905 that could (at least in theory) be that large.
3907 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3908 This is less likely to overflow, and avoids undefined behavior if
3909 overflow does occur. All callers changed. Use strtoul to scan
3910 for the unsigned long integer.
3911 (pint2hrstr): Simplify and tune code slightly.
3912 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3914 * scroll.c (do_scrolling): Work around GCC bug 48228.
3915 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3917 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3918 This also avoids a warning with gcc -Wstrict-overflow.
3919 (validate_x_resource_name): Simplify count usage.
3920 This also avoids a warning with gcc -Wstrict-overflow.
3922 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3925 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3927 * process.c (Fmake_network_process): Use socklen_t, not int,
3928 where POSIX says socklen_t is required in portable programs.
3929 This fixes a porting bug on hosts like 64-bit HP-UX, where
3930 socklen_t is wider than int (Bug#8277).
3931 (Fmake_network_process, server_accept_connection):
3932 (wait_reading_process_output, read_process_output):
3935 * process.c: Rename or move locals to avoid shadowing.
3936 (list_processes_1, Fmake_network_process):
3937 (read_process_output_error_handler, exec_sentinel_error_handler):
3938 Rename or move locals.
3939 (Fmake_network_process): Define label "retry_connect" only if needed.
3940 (Fnetwork_interface_info): Fix pointer signedness.
3941 (process_send_signal): Add cast to avoid pointer signedness problem.
3942 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3943 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3945 Make tparam.h and terminfo.c consistent.
3946 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3947 Include tparam.h instead, since it declares them.
3948 * cm.h (PC): Remove extern decl; tparam.h now does this.
3949 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3950 * terminfo.c: Include tparam.h, to check interfaces.
3951 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3952 (tparam): Adjust signature to match interface in tparam.h;
3953 this removes some undefined behavior. Check that outstring and len
3954 are zero, which they always are with Emacs.
3955 * tparam.h (PC, BC, UP): New extern decls.
3957 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3958 (xftfont_open): Rename locals to avoid shadowing.
3960 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3961 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3962 (OTF_TAG_SYM): Omit macro if not needed.
3963 (ftfont_list): Remove unused local.
3964 (get_adstyle_property, ftfont_pattern_entity):
3965 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3966 Rename locals to avoid shadowing.
3968 * xfont.c (xfont_list_family): Mark var as initialized.
3970 * xml.c (make_dom): Now static.
3972 * composite.c (composition_compute_stop_pos): Rename local to
3974 (composition_reseat_it): Remove unused locals.
3975 (find_automatic_composition, composition_adjust_point): Likewise.
3976 (composition_update_it): Mark var as initialized.
3977 (find_automatic_composition): Mark vars as initialized,
3978 with a FIXME (Bug#8290).
3980 character.h: Rename locals to avoid shadowing.
3981 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3982 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3983 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3984 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3987 * textprop.c (property_change_between_p): Remove; unused.
3989 * intervals.c (interval_start_pos): Now static.
3991 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3993 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3994 Rename locals to avoid shadowing.
3996 * sound.c (wav_play, au_play, Fplay_sound_internal):
3997 Fix pointer signedness.
3998 (alsa_choose_format): Remove unused local var.
3999 (wav_play): Initialize a variable to 0, to prevent undefined
4000 behavior (Bug#8278).
4002 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4004 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4006 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4007 clobbering (Bug#8298).
4008 * sysdep.c (sys_subshell): Likewise.
4009 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4011 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4012 This should get cleaned up, so that child_setup has the
4013 same signature on all platforms.
4015 * callproc.c (call_process_cleanup): Now static.
4016 (relocate_fd): Rename locals to avoid shadowing.
4018 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4020 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4021 not to be necessary, and produces flickering.
4023 2011-03-20 Glenn Morris <rgm@gnu.org>
4025 * config.in: Remove file.
4027 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4029 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4030 are now in src/globals.h.
4031 (syms_of_minibuf): Remove spurious & from previous change.
4033 2011-03-20 Leo <sdl.web@gmail.com>
4035 * minibuf.c (completing-read-function): New variable.
4036 (completing-read-default): Rename from completing-read.
4037 (completing-read): Call completing-read-function.
4039 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4041 * xfaces.c (Fx_load_color_file):
4042 Read color file from absolute filename (bug#8250).
4044 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4046 * makefile.w32-in: Update dependencies.
4048 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4050 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4052 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4054 Fix more problems found by GCC 4.5.2's static checks.
4056 * process.c (make_serial_process_unwind, send_process_trap):
4057 (sigchld_handler): Now static.
4059 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4060 That way, the code declares only the vars that it needs.
4061 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4062 * s/cygwin.h (PTY_ITERATION): Likewise.
4063 * s/darwin.h (PTY_ITERATION): Likewise.
4064 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4066 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4067 * process.c (allocate_pty): Don't declare stb unless it's needed.
4069 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4070 (CONSTANTLIM): Remove; unused.
4071 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4072 Define only if needed.
4074 * unexelf.c (unexec): Name an expression,
4075 to avoid gcc -Wbad-function-cast warning.
4076 Use a different way to cause a compilation error if anyone uses
4077 n rather than nn, a way that does not involve shadowing.
4078 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4080 * deps.mk (unexalpha.o): Remove; unused.
4082 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4083 * unexec.h: New file.
4084 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4085 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4087 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4088 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4089 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4090 Change as necessary to match prototype in unexec.h.
4092 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4094 (back_comment, skip_chars): Mark vars as initialized.
4096 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4097 Rename locals to avoid shadowing.
4099 * lread.c (read1): Rewrite so as not to use empty "else".
4100 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4102 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4104 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4105 warning when compiling print.c.
4107 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4108 instead of using an uninitialized var.
4109 (font_sort_entities): Mark var as initialized.
4111 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4113 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4114 pointers to constants.
4115 (font_parse_fcname): Remove unused vars.
4116 (font_delete_unmatched): Now static.
4117 (font_get_spec): Remove; unused.
4118 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4119 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4120 Rename or move locals to avoid shadowing.
4122 * fns.c (require_nesting_list, require_unwind): Now static.
4123 (Ffillarray): Rename locals to avoid shadowing.
4125 * floatfns.c (domain_error2): Define only if needed.
4126 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4128 * alloc.c (mark_backtrace): Move decl from here ...
4129 * lisp.h: ... to here, so that it can be checked.
4131 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4132 (Fdefvar): Rewrite so as not to use empty "else".
4133 (lisp_indirect_variable): Name an expression,
4134 to avoid gcc -Wbad-function-cast warning.
4135 (Fdefvar): Rename locals to avoid shadowing.
4137 * callint.c (quotify_arg, quotify_args): Now static.
4138 (Fcall_interactively): Rename locals to avoid shadowing.
4139 Use const pointer when appropriate.
4141 * lisp.h (get_system_name, get_operating_system_release):
4142 Move decls here, to check interfaces.
4143 * process.c (get_operating_system_release): Move decl to lisp.h.
4144 * xrdb.c (get_system_name): Likewise.
4145 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4146 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4147 some of which prompt warnings from gcc -Wbad-function-cast.
4148 (Fformat_time_string, Fencode_time, Finsert_char):
4149 (Ftranslate_region_internal, Fformat):
4150 Rename or remove local vars to avoid shadowing.
4151 (Ftranslate_region_internal): Mark var as initialized.
4153 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4156 * lisp.h (eassert): Check that the argument compiles, even if
4157 ENABLE_CHECKING is not defined.
4159 * data.c (Findirect_variable): Name an expression, to avoid
4160 gcc -Wbad-function-cast warning.
4161 (default_value, arithcompare, arith_driver, arith_error): Now static.
4162 (store_symval_forwarding): Rename local to avoid shadowing.
4163 (Fmake_variable_buffer_local, Fmake_local_variable):
4164 Mark variables as initialized.
4165 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4167 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4168 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4169 Rename locals to avoid shadowing.
4170 (mark_stack): Move local variables into the #ifdef region where
4172 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4173 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4175 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4176 (GC_STRING_CHARS): Remove; not used.
4177 (Fmemory_limit): Cast sbrk's returned value to char *.
4179 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4180 avoids undefined behavior in theory.
4182 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4184 Use functions, not macros, for up- and down-casing (Bug#8254).
4185 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4186 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4187 to use the following functions instead of these macros.
4188 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4189 EMACS_INT, since callers assume the returned value fits in int.
4190 (upcase1): Likewise, for UPCASE_TABLE.
4191 (uppercasep, lowercasep, upcase): New static inline functions.
4192 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4193 the race-condition problem in the old DOWNCASE.
4195 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4196 Rename locals to avoid shadowing.
4197 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4198 (regex_compile, re_search_2, re_match_2_internal):
4199 Remove unused local vars.
4200 (FREE_VAR): Rewrite so as not to use empty "else",
4201 which gcc can warn about.
4202 (regex_compile, re_match_2_internal): Mark locals as initialized.
4203 (RETALLOC_IF): Define only if needed.
4204 (WORDCHAR_P): Likewise. This one is never needed, but is used
4205 only in a comment talking about a compiler bug, so put inside
4206 the #if 0 of that comment.
4207 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4208 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4211 * search.c (boyer_moore): Rename locals to avoid shadowing.
4212 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4213 (PREV_CHAR_BOUNDARY): Likewise.
4215 * search.c (simple_search): Remove unused var.
4217 * dired.c (compile_pattern): Move decl from here ...
4218 * lisp.h: ... to here, so that it can be checked.
4219 (struct re_registers): New forward decl.
4221 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4223 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4225 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4226 Rename locals to avoid shadowing.
4227 (Fvertical_motion): Mark locals as initialized.
4229 * casefiddle.c (casify_object, casify_region): Now static.
4230 (casify_region): Mark local as initialized.
4232 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4234 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4235 New macros, so that the caller can use some names other than
4236 gcpro1, gcpro2, etc.
4237 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4239 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4240 argument, for consistency with GCPRO2_VAR, etc: it is now the
4241 prefix of the variable, not the variable itself. All uses
4243 * dired.c (directory_files_internal, file_name_completion):
4244 Rename locals to avoid shadowing.
4246 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4247 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4248 dired.c's scmp function, had undefined behavior.
4249 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4250 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4251 * buffer.h: ... to here, because these macros use current_buffer,
4252 and the new implementation with inline functions needs to have
4253 current_buffer in scope now, rather than later when the macros
4255 (downcase, upcase1): New static inline functions.
4256 (DOWNCASE, UPCASE1): Reimplement using these functions.
4257 This avoids undefined behavior in expressions like
4258 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4259 from race conditions in accessing the global variables
4260 case_temp1 and case_temp2.
4261 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4262 * lisp.h (case_temp1, case_temp2): Remove their decls.
4263 * character.h (ASCII_CHAR_P): Move from here ...
4264 * lisp.h: ... to here, so that the inline functions mentioned
4267 * dired.c (directory_files_internal_unwind): Now static.
4269 * fileio.c (file_name_as_directory, directory_file_name):
4270 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4272 (file_name_as_directory): Use const pointers when appropriate.
4273 (Fexpand_file_name): Likewise. In particular, newdir might
4274 point at constant storage, so make it a const pointer.
4275 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4276 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4278 (Fset_file_times, Finsert_file_contents, auto_save_error):
4279 Rename locals to avoid shadowing.
4281 * minibuf.c (choose_minibuf_frame_1): Now static.
4282 (Ftry_completion, Fall_completions): Rename or remove locals
4285 * marker.c (bytepos_to_charpos): Remove; unused.
4287 * lisp.h (verify_bytepos, count_markers): New decls,
4288 so that gcc does not warn that these functions aren't declared.
4290 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4291 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4292 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4293 (copy_text): Remove unused local var.
4295 * filelock.c (within_one_second): Now static.
4296 (lock_file_1): Rename local to avoid shadowing.
4298 * buffer.c (fix_overlays_before): Mark locals as initialized.
4299 (fix_start_end_in_overlays): Likewise. This function should be
4300 simplified by using pointers-to-pointers, but that's a different
4302 (switch_to_buffer_1): Now static.
4303 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4304 (report_overlay_modification): Rename locals to avoid shadowing.
4306 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4307 Fix pointer signedness issue.
4308 (sys_subshell): Mark local as volatile if checking for lint,
4309 to suppress a gcc -Wclobbered warning that does not seem to be right.
4310 (MAXPATHLEN): Define only if needed.
4312 * process.c (serial_open, serial_configure): Move decls from here ...
4313 * systty.h: ... to here, so that they can be checked.
4315 * fns.c (get_random, seed_random): Move extern decls from here ...
4316 * lisp.h: ... to here, so that they can be checked.
4318 * sysdep.c (reset_io): Now static.
4319 (wait_for_termination_signal): Remove; unused.
4321 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4322 (copy_keymap_item, append_key, push_text_char_description):
4324 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4325 (DENSE_TABLE_SIZE): Remove; unused.
4326 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4327 (describe_map_tree):
4328 Rename locals to avoid shadowing.
4330 * keyboard.c: Declare functions static if they are not used elsewhere.
4331 (echo_char, echo_dash, cmd_error, top_level_2):
4332 (poll_for_input, handle_async_input): Now static.
4333 (read_char, kbd_buffer_get_event, make_lispy_position):
4334 (make_lispy_event, make_lispy_movement, apply_modifiers):
4335 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4336 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4337 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4338 (read_key_sequence, read_char): Mark locals as initialized.
4339 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4341 * keyboard.h (make_ctrl_char): New decl.
4342 (mark_kboards): Move decl here ...
4343 * alloc.c (mark_kboards): ... from here.
4345 * lisp.h (force_auto_save_soon): New decl.
4347 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4348 (DEFINE_DUMMY_FUNCTION): New macro.
4349 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4351 (main): Add casts to avoid warnings
4352 if GCC considers string literals to be constants.
4354 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4356 * dbusbind.c: Pointer signedness fixes.
4357 (xd_signature, xd_append_arg, xd_initialize):
4358 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4359 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4360 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4361 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4363 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4364 if GCC considers string literals to be constants.
4365 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4367 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4369 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4370 (print_preprocess, print_object): New macro to fix last change.
4372 * print.c (print_preprocess): Don't forget font objects.
4374 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4376 * emacs.c (USAGE3): Doc fixes.
4378 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4380 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4383 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4385 * lisp.h (VWindow_system, Qfile_name_history):
4386 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4387 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4388 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4390 * w32select.c: Don't #include "keyboard.h".
4391 (run_protected): Add extern declaration for waiting_for_input.
4393 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4394 * w32console.c (detect_input_pending, read_input_pending)
4395 (encode_terminal_code):
4396 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4397 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4398 (w32_system_caret_y, Qfile_name_history):
4399 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4400 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4401 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4402 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4403 * w32proc.c (Qlocal, report_file_error):
4404 * w32term.c (Vwindow_system, updating_frame):
4405 * w32uniscribe.c (initialized, uniscribe_font_driver):
4406 Remove unneeded extern declarations.
4408 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4410 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4412 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4414 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4415 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4416 These macros can no longer be used for assignment.
4418 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4419 Assign struct members directly, instead of using BUF_BEGV etc.
4420 (record_buffer_markers, fetch_buffer_markers): New functions for
4421 recording and fetching special buffer markers.
4422 (set_buffer_internal_1, set_buffer_temp): Use them.
4424 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4426 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4428 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4429 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4431 * xdisp.c (hscroll_window_tree):
4432 (reconsider_clip_changes): Use PT instead of BUF_PT.
4434 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4436 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4437 $(EMACS_ROOT)/lib/intprops.h.
4439 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4441 Fix more problems found by GCC 4.5.2's static checks.
4443 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4444 to unsigned char * to avoid compiler diagnostic.
4445 (xg_free_frame_widgets): Make it clear that a local variable is
4446 needed only if USE_GTK_TOOLTIP.
4447 (gdk_window_get_screen): Make it clear that this macro is needed
4448 only if USE_GTK_TOOLTIP.
4449 (int_gtk_range_get_value): New function, which avoids a diagnostic
4450 from gcc -Wbad-function-cast.
4451 (xg_set_toolkit_scroll_bar_thumb): Use it.
4452 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4453 diagnostic from gcc -Wbad-function-cast.
4454 (get_utf8_string, xg_get_file_with_chooser):
4455 Rename locals to avoid shadowing.
4456 (create_dialog): Move locals to avoid shadowing.
4458 * xgselect.c (xg_select): Remove unused var.
4460 * image.c (four_corners_best): Mark locals as initialized.
4461 (gif_load): Initialize transparent_p to zero (Bug#8238).
4462 Mark another local as initialized.
4463 (my_png_error, my_error_exit): Mark with NO_RETURN.
4465 * image.c (clear_image_cache): Now static.
4466 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4467 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4468 (x_edge_detection): Remove unnecessary cast that
4469 gcc -Wbad-function-cast diagnoses.
4470 (gif_load): Fix pointer signedness.
4471 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4472 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4474 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4476 Improve quality of tests for time stamp overflow.
4477 For example, without this patch (encode-time 0 0 0 1 1
4478 1152921504606846976) returns the obviously-bogus value (-948597
4479 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4480 reports time overflow. See
4481 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4482 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4483 * editfns.c: Include limits.h and intprops.h.
4484 (TIME_T_MIN, TIME_T_MAX): New macros.
4485 (time_overflow): Move earlier, to before first use.
4486 (hi_time, lo_time): New functions, for an accurate test for
4488 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4489 (Fget_internal_run_time): Don't assume time_t fits in int.
4490 (make_time): Use list2 instead of Fcons twice.
4491 (Fdecode_time): More accurate test for out-of-range times.
4492 (check_tm_member): New function.
4493 (Fencode_time): Use it, to test for out-of-range times.
4494 (lisp_time_argument): Don't rely on undefined left-shift and
4495 right-shift behavior when checking for time stamp overflow.
4497 * editfns.c (time_overflow): New function, refactoring common code.
4498 (Fformat_time_string, Fdecode_time, Fencode_time):
4499 (Fcurrent_time_string): Use it.
4501 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4502 * dired.c (make_time): Move to ...
4503 * editfns.c (make_time): ... here.
4504 * systime.h: Note the move.
4506 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4508 * fringe.c (update_window_fringes): Remove unused variables.
4510 * unexmacosx.c (copy_data_segment): Also copy __got section.
4513 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4515 * termcap.c [MSDOS]: Include "msdos.h".
4516 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4517 Constify `char *' arguments and their references according to
4518 prototypes in tparam.h.
4520 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4522 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4523 Adapt all references accordingly.
4525 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4527 2011-03-11 Tom Tromey <tromey@redhat.com>
4529 * buffer.c (syms_of_buffer): Remove obsolete comment.
4531 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4533 * termhooks.h (encode_terminal_code): Declare prototype.
4535 * msdos.c (encode_terminal_code): Don't declare prototype.
4537 * term.c (encode_terminal_code): Now external again, used by
4538 w32console.c and msdos.c.
4540 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4541 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4543 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4545 Fix some minor problems found by GCC 4.5.2's static checks.
4547 * fringe.c (update_window_fringes): Mark locals as initialized
4549 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4551 * alloc.c (mark_fringe_data): Move decl from here ...
4552 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4553 to check its interface.
4554 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4556 * fontset.c (free_realized_fontset): Now static.
4557 (Fset_fontset_font): Rename local to avoid shadowing.
4558 (fontset_font): Mark local as initialized.
4559 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4561 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4563 * xselect.c (x_disown_buffer_selections): Remove; not used.
4564 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4565 (x_own_selection, Fx_disown_selection_internal): Rename locals
4567 (x_handle_dnd_message): Remove local to avoid shadowing.
4569 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4570 so that the caller can use some name other than gcpro1.
4571 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4572 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4573 (Fx_backspace_delete_keys_p):
4574 Use them to avoid shadowing, and rename vars to avoid shadowing.
4575 (x_decode_color, x_set_name, x_window): Now static.
4576 (Fx_create_frame): Add braces to silence GCC warning.
4577 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4578 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4579 Remove unused locals.
4580 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4581 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4582 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4585 * xterm.h (x_mouse_leave): New decl.
4587 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4588 Remove unused functions.
4589 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4590 (x_calc_absolute_position): Now static.
4591 (XTread_socket): Don't define label "out" unless it's used.
4592 Don't declare local "event" unless it's used.
4593 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4594 unless they are used.
4595 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4596 (x_fatal_error_signal): Remove; not used.
4597 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4598 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4599 (x_error_catcher, x_connection_closed, x_error_handler):
4600 (x_error_quitter, xembed_send_message, x_iconify_frame):
4601 (my_log_handler): Rename locals to avoid shadowing.
4602 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4603 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4605 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4606 Rename or move locals to avoid shadowing.
4607 (tty_defined_color, merge_face_heights): Now static.
4608 (free_realized_faces_for_fontset): Remove; not used.
4609 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4610 does not deduce is never used uninitialized.
4611 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4612 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4614 * terminal.c (store_terminal_param): Now static.
4616 * xmenu.c (menu_highlight_callback): Now static.
4617 (set_frame_menubar): Remove unused local.
4618 (xmenu_show): Rename parameter to avoid shadowing.
4619 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4620 since they might point to immutable storage.
4621 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4622 since it's unused otherwise.
4624 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4625 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4626 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4627 avoids a gcc -Wuninitialized diagnostic.
4628 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4629 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4630 does not deduce are never used uninitialized.
4632 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4634 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4635 * window.c (window_loop, size_window):
4636 (run_window_configuration_change_hook, enlarge_window): Likewise.
4638 * window.c (display_buffer): Now static.
4639 (size_window): Mark variables that gcc -Wuninitialized
4640 does not deduce are never used uninitialized.
4641 * window.h (check_all_windows): New decl, to forestall
4642 gcc -Wmissing-prototypes diagnostic.
4643 * dispextern.h (bidi_dump_cached_states): Likewise.
4645 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4647 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4649 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4650 and to avoid gcc -Wuninitialized warning.
4651 (load_charset_map): Mark variables that gcc -Wuninitialized
4652 does not deduce are never used uninitialized.
4653 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4655 * coding.c (coding_set_source, coding_set_destination):
4656 Use "else { /* comment */ }" rather than "else /* comment */;"
4657 for clarity, and to avoid gcc -Wempty-body warning.
4658 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4659 a block, when the outer 'i' will do.
4660 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4661 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4662 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4663 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4664 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4665 Rename locals to avoid shadowing.
4666 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4667 * coding.c (emacs_mule_char, encode_invocation_designation):
4668 Now static, since they're not used elsewhere.
4669 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4670 (decode_coding_object, encode_coding_object, detect_coding_system):
4671 (decode_coding_emacs_mule): Mark variables that gcc
4672 -Wuninitialized does not deduce are never used uninitialized.
4673 (detect_coding_iso_2022): Initialize a local variable that might
4674 be used uninitialized. Leave a FIXME because it's not clear that
4675 this initialization is needed. (Bug#8211)
4676 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4677 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4678 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4679 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4680 Remove unused macros.
4682 * category.c (hash_get_category_set): Remove unused local var.
4683 (copy_category_table): Now static, since it's not used elsewhere.
4684 * character.c (string_count_byte8): Likewise.
4686 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4687 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4689 * chartab.c (copy_sub_char_table): Now static, since it's not used
4691 (sub_char_table_ref_and_range, char_table_ref_and_range):
4692 Rename locals to avoid shadowing.
4693 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4695 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4696 (BIDI_BOB): Remove unused macro.
4698 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4699 deduce are never used uninitialized.
4700 * term.c (encode_terminal_code): Likewise.
4702 * term.c (encode_terminal_code): Now static. Remove unused local.
4704 * tparam.h: New file.
4705 * term.c, tparam.h: Include it.
4706 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4707 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4708 Move these decls to tparam.h, and make them agree with what
4709 is actually in tparam.c. The previous trick of using incompatible
4710 decls in different modules does not conform to the C standard.
4711 All callers of tparam changed to use tparam's actual API.
4712 * tparam.c (tparam1, tparam, tgoto):
4713 Use const pointers where appropriate.
4715 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4716 * cm.h (struct cm): Likewise.
4717 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4718 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4719 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4720 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4721 (turn_on_face, init_tty): Likewise.
4722 * termchar.h (struct tty_display_info): Likewise.
4724 * term.c (term_mouse_position): Rename local to avoid shadowing.
4726 * alloc.c (mark_ttys): Move decl from here ...
4727 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4729 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4731 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4733 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4735 * search.c (compile_pattern_1): Remove argument regp, unused since
4736 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4737 (compile_pattern): Don't pass it.
4739 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4741 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4742 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4744 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4746 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4748 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4749 gdk_window_get_screen, gdk_window_get_geometry,
4750 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4751 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4752 (xg_get_pixbuf_from_pixmap): New function.
4753 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4754 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4755 Call xg_get_pixbuf_from_pixmap instead of
4756 gdk_pixbuf_get_from_drawable.
4757 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4758 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4759 (xg_check_special_colors): Use GtkStyleContext and its functions
4761 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4762 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4763 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4764 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4765 Call gtk_widget_get_preferred_size.
4766 (xg_frame_resized): gdk_window_get_geometry only takes 5
4768 (xg_win_to_widget, xg_event_is_for_menubar):
4769 Call gdk_x11_window_lookup_for_display.
4770 (xg_set_widget_bg): New function.
4771 (delete_cb): New function.
4772 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4773 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4774 (xg_set_background_color): Call xg_set_widget_bg.
4775 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4776 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4777 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4778 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4780 (update_frame_tool_bar): Call gtk_widget_hide.
4781 (xg_initialize): Use GDK_KEY_g.
4783 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4785 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4787 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4788 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4789 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4791 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4793 * w32xfns.c (select_palette): Check success of RealizePalette against
4794 GDI_ERROR, not zero.
4796 See ChangeLog.11 for earlier changes.
4802 Copyright (C) 2011 Free Software Foundation, Inc.
4804 This file is part of GNU Emacs.
4806 GNU Emacs is free software: you can redistribute it and/or modify
4807 it under the terms of the GNU General Public License as published by
4808 the Free Software Foundation, either version 3 of the License, or
4809 (at your option) any later version.
4811 GNU Emacs is distributed in the hope that it will be useful,
4812 but WITHOUT ANY WARRANTY; without even the implied warranty of
4813 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4814 GNU General Public License for more details.
4816 You should have received a copy of the GNU General Public License
4817 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.