1 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3 * xterm.c (XTread_socket): Only modify handling_signal if
4 !SYNC_INPUT. (Bug#11080)
6 2012-03-23 Eli Zaretskii <eliz@gnu.org>
8 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
9 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
10 when fetching a multibyte character consumes more bytes than
11 CHAR_BYTES returns, due to unification of CJK characters in
12 string_char. (Bug#11073)
14 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
16 * process.c (wait_reading_process_output): Handle pty disconnect
17 by refraining from sending oneself a SIGCHLD (bug#10933).
19 2012-03-22 Chong Yidong <cyd@gnu.org>
21 * dispextern.h (struct it): New member string_from_prefix_prop_p.
23 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
24 Mark string as coming from a prefix property.
25 (handle_face_prop): Use default face for prefix strings (Bug#4281).
26 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
28 2012-03-21 Chong Yidong <cyd@gnu.org>
30 * xfaces.c (Vface_remapping_alist): Doc fix.
32 2012-03-20 Eli Zaretskii <eliz@gnu.org>
34 * w32proc.c (Fw32_set_console_codepage)
35 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
38 2012-03-20 Chong Yidong <cyd@gnu.org>
40 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
41 to reflect default non-nil value of redisplay-dont-pause.
43 2012-03-19 Kenichi Handa <handa@m17n.org>
45 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
46 it fit in a valid range (Bug#11003).
48 2012-03-18 Eli Zaretskii <eliz@gnu.org>
50 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
51 that is not from display property, accept the row as a "cursor
52 row" if one of the string's character has a non-nil `cursor'
53 property. Fixes cursor positioning when there are newlines in
54 overlay strings, e.g. in icomplete.el. (Bug#11035)
56 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
58 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
60 2012-03-12 Chong Yidong <cyd@gnu.org>
62 * eval.c (inhibit_lisp_code): Rename from
63 inhibit_window_configuration_change_hook; move from window.c.
65 * xfns.c (unwind_create_frame_1, Fx_create_frame):
66 * window.c (run_window_configuration_change_hook)
67 (syms_of_window): Callers changed.
69 2012-03-11 Chong Yidong <cyd@gnu.org>
71 * keymap.c (Fkey_description): Doc fix (Bug#9700).
73 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
75 2012-03-10 Chong Yidong <cyd@gnu.org>
77 * frame.c (other_visible_frames): Don't assume the selected frame
78 is visible (Bug#10955).
80 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
82 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
84 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
86 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
87 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
90 2012-03-03 Glenn Morris <rgm@gnu.org>
92 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
94 2012-03-02 Eli Zaretskii <eliz@gnu.org>
96 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
97 position past the first glyph_row that ends at ZV. (Bug#10902)
98 (redisplay_window, next_element_from_string): Fix typos in
100 (redisplay_window): Pass to move_it_vertically the margin in
101 pixels, not in screen lines.
103 2012-03-02 Glenn Morris <rgm@gnu.org>
105 * buffer.c (buffer-list-update-hook): Doc fix.
107 2012-02-29 Eli Zaretskii <eliz@gnu.org>
109 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
110 push_it before setting up the iterator for the first overlay
111 string, even if we have an empty string loaded.
112 (next_overlay_string): If there's an empty string on the iterator
113 stack, pop the stack. (Bug#10903)
115 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
117 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
118 Suggested by Stefan Monnier in
119 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
120 * alloc.c (widen_to_Lisp_Object): New static function.
121 (mark_memory): Also mark Lisp_Objects by fetching pointer words
122 and widening them to Lisp_Objects. This would work even if
123 USE_LSB_TAG is defined and wide integers are used, which might
124 happen in a future version of Emacs.
126 2012-02-25 Chong Yidong <cyd@gnu.org>
128 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
131 * xselect.c (Fx_selection_exists_p): Doc fix.
132 (x_clipboard_manager_save_all): Print an informative message
133 before saving to clipboard manager.
135 2012-02-24 Chong Yidong <cyd@gnu.org>
137 * keyboard.c (process_special_events): Handle all X selection
138 requests in kbd_buffer, not just the next one (Bug#8869).
140 2012-02-23 Chong Yidong <cyd@gnu.org>
142 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
143 call when setting menu-bar-lines and tool-bar-lines parameters.
144 (unwind_create_frame_1): New helper function.
146 * window.c (inhibit_window_configuration_change_hook): New var.
147 (run_window_configuration_change_hook): Obey it.
148 (syms_of_window): Initialize it.
150 2012-02-22 Chong Yidong <cyd@gnu.org>
152 * xterm.c (x_draw_image_relief): Add missing type check for
153 Vtool_bar_button_margin (Bug#10743).
155 2012-02-21 Chong Yidong <cyd@gnu.org>
157 * fileio.c (Vfile_name_handler_alist): Doc fix.
159 * buffer.c (Fget_file_buffer): Protect against invalid file
160 handler return value.
162 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
164 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
165 when computing $valmask.
167 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
168 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
169 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
170 It's useless in that case, and it can cause problems on hosts
171 that allocate halves of EMACS_INT values separately.
172 Reported by Dan Horák. Diagnosed by Andreas Schwab in
173 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
174 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
175 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
176 it avoids undefined behavior on hosts where shifting right by more
177 than the word width has undefined behavior.
179 2012-02-19 Chong Yidong <cyd@gnu.org>
181 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
182 (Funhandled_file_name_directory, Ffile_name_as_directory)
183 (Fdirectory_file_name, Fexpand_file_name)
184 (Fsubstitute_in_file_name): Protect against invalid file handler
185 return values (Bug#10845).
187 2012-02-18 Eli Zaretskii <eliz@gnu.org>
189 * .gdbinit (pitx): Fix incorrect references to fields of the
192 2012-02-17 Chong Yidong <cyd@gnu.org>
194 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
196 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
198 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
199 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
201 2012-02-15 Chong Yidong <cyd@gnu.org>
203 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
204 marked as special. Also, starting docstrings with * is obsolete.
206 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
208 * gnutls.c (emacs_gnutls_write): Fix last change.
210 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
212 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
215 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
217 * keymap.c (Fsingle_key_description): Handle char ranges.
219 2012-02-12 Chong Yidong <cyd@gnu.org>
221 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
222 as that creates a dangerous corner case.
224 * window.c (Fdelete_window_internal): Invalidate the mouse
225 highlight (Bug#9904).
227 2012-02-12 Glenn Morris <rgm@gnu.org>
229 * xselect.c (Fx_own_selection_internal)
230 (Fx_get_selection_internal, Fx_disown_selection_internal)
231 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
232 * nsselect.m (Fx_own_selection_internal)
233 (Fx_disown_selection_internal, Fx_selection_exists_p)
234 (Fx_selection_owner_p, Fx_get_selection_internal):
235 Sync docs and argument specs with the xselect.c versions.
237 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
239 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
241 2012-02-11 Eli Zaretskii <eliz@gnu.org>
243 * w32select.c (Fx_selection_exists_p): Sync doc string and
244 argument list with xselect.c. (Bug#10783)
246 * w16select.c (Fx_selection_exists_p): Sync doc string and
247 argument list with xselect.c. (Bug#10783)
249 2012-02-10 Glenn Morris <rgm@gnu.org>
251 * fns.c (Fsecure_hash): Doc fix.
253 2012-02-09 Kenichi Handa <handa@m17n.org>
255 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
257 2012-02-07 Chong Yidong <cyd@gnu.org>
259 * buffer.c (Fbuffer_local_variables)
260 (buffer_lisp_local_variables): Handle unbound vars correctly;
261 don't let Qunbound leak into Lisp.
263 2012-02-07 Glenn Morris <rgm@gnu.org>
265 * image.c (Fimagemagick_types): Doc fix.
267 * image.c (imagemagick-render-type): Change it from a lisp object
268 to an integer. Move the doc here from the lisp manual.
269 Treat all values not equal to 0 the same.
271 2012-02-06 Chong Yidong <cyd@gnu.org>
273 * doc.c (store_function_docstring): Avoid applying docstring of
274 alias to base function (Bug#2603).
276 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
278 * .gdbinit (pp1, pv1): Remove redundant defines.
281 2012-02-04 Chong Yidong <cyd@gnu.org>
283 * nsterm.m: Declare a global (Bug#10694).
285 2012-02-04 Eli Zaretskii <eliz@gnu.org>
287 * w32.c (get_emacs_configuration_options):
288 Include --enable-checking, if specified, in the return value.
290 2012-02-04 Martin Rudalics <rudalics@gmx.at>
292 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
293 after rounding frame sizes. (Bug#9723)
295 2012-02-04 Eli Zaretskii <eliz@gnu.org>
297 * keyboard.c (adjust_point_for_property): Don't position point
298 before BEGV. (Bug#10696)
300 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
302 Handle overflow when computing char display width (Bug#9496).
303 * character.c (char_width): Return EMACS_INT, not int.
304 (char_width, c_string_width): Check for overflow when
305 computing the width; this is possible now that individual
306 characters can have unbounded width. Problem introduced
307 by merge from Emacs 23 on 2012-01-19.
309 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
311 * dbusbind.c (Fdbus_register_method): Mention the return value
312 :ignore in the docstring.
314 2012-02-02 Glenn Morris <rgm@gnu.org>
316 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
318 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
319 Unconditionally set to t. (Bug#10673)
320 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
321 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
322 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
324 2012-02-02 Kenichi Handa <handa@m17n.org>
326 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
327 0, do not call append_composite_glyph.
329 2012-02-02 Kenichi Handa <handa@m17n.org>
331 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
333 (x_produce_glyphs): If the component of a composition is a null
334 string, set it->pixel_width to 1 to avoid zero-width glyph.
336 2012-02-01 Eli Zaretskii <eliz@gnu.org>
338 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
339 first 2 arguments are identical. This makes inserting large
340 output from a subprocess an order of magnitude faster on
341 MS-Windows, where all sbrk'ed memory is always contiguous.
343 2012-01-31 Glenn Morris <rgm@gnu.org>
345 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
346 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
347 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
349 2012-01-29 Glenn Morris <rgm@gnu.org>
351 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
353 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
355 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
357 2012-01-28 Chong Yidong <cyd@gnu.org>
359 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
361 2012-01-26 Chong Yidong <cyd@gnu.org>
363 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
365 * search.c (Fsearch_forward, Fsearch_backward): Document negative
366 repeat counts (Bug#10507).
368 2012-01-26 Glenn Morris <rgm@gnu.org>
370 * lread.c (syms_of_lread): Doc fix.
372 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
374 * coding.c (encode_designation_at_bol): Change return value to
377 2012-01-25 Chong Yidong <cyd@gnu.org>
379 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
381 2012-01-21 Chong Yidong <cyd@gnu.org>
383 * floatfns.c (Fcopysign): Make the second argument non-optional,
384 since nil is not allowed anyway.
386 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
388 * process.c (read_process_output): Use p instead of XPROCESS (proc).
389 (send_process): Likewise.
391 2012-01-19 Martin Rudalics <rudalics@gmx.at>
393 * window.c (save_window_save, Fcurrent_window_configuration)
394 (Vwindow_persistent_parameters): Do not use Qstate.
397 2012-01-19 Kenichi Handa <handa@m17n.org>
399 * character.c (char_width): New function.
400 (Fchar_width, c_string_width, lisp_string_width):
401 Use char_width (Bug#9496).
403 2012-01-16 Martin Rudalics <rudalics@gmx.at>
405 * window.c (Vwindow_persistent_parameters): New variable.
406 (Fset_window_configuration, save_window_save): Handle persistent
409 2012-01-14 Eli Zaretskii <eliz@gnu.org>
411 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
412 thrashing the stack of the thread. (Bug#9087)
414 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
416 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
418 2012-01-11 Eli Zaretskii <eliz@gnu.org>
420 * xdisp.c (rows_from_pos_range): Handle the case where the
421 highlight ends on a newline. (Bug#10464)
422 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
423 he end column for display of highlight that ends on a newline
426 2012-01-11 Glenn Morris <rgm@gnu.org>
428 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
429 from load-path also when installation-directory is nil. (Bug#10208)
431 2012-01-10 Glenn Morris <rgm@gnu.org>
433 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
435 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
436 Update template values to be closer to their typical values these days.
438 2012-01-09 Eli Zaretskii <eliz@gnu.org>
440 * xdisp.c (rows_from_pos_range): Accept additional argument
441 DISP_STRING, and accept any glyph in a row whose object is that
442 string as eligible for mouse highlight. Fixes mouse highlight of
443 display strings from overlays. (Bug#10464)
445 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
447 emacs: fix an auto-save permissions race condition (Bug#10400)
448 * fileio.c (auto_saving_dir_umask): New static var.
449 (Fmake_directory_internal): Use it.
450 (do_auto_save_make_dir): Set it, instead of invoking chmod after
451 creating the directory. The old code temporarily assigns
452 too-generous permissions to the directory.
453 (do_auto_save_eh): Clear it.
454 (Fdo_auto_save): Catch all errors, not just file errors, so
455 that the var is always cleared.
457 2012-01-07 Eli Zaretskii <eliz@gnu.org>
459 * search.c (scan_buffer): Pass character positions to
460 know_region_cache, not byte positions. (Bug#6540)
462 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
464 * w32.c (sys_rename): Report EXDEV when rename of a directory
465 fails because the target is on another logical disk. (Bug#10284)
467 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
469 * xterm.c (x_embed_request_focus): New function.
471 * xterm.h: Add prototype.
473 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
475 2012-01-05 Glenn Morris <rgm@gnu.org>
477 * emacs.c (emacs_copyright): Update short copyright year to 2012.
479 2012-01-01 Eli Zaretskii <eliz@gnu.org>
481 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
482 Load gnutls_transport_set_lowat only if GnuTLS version is below
484 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
485 GnuTLS versions below 2.11.1.
487 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
489 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
490 to the doc string advising against its use for altering the way
491 windows are scrolled.
493 2011-12-28 Kenichi Handa <handa@m17n.org>
495 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
496 coding-system ASCII compatible only when it does not produce BOM
497 on encoding (Bug#10383).
499 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
501 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
503 (create_and_show_popup_menu): Always use menu_position_func for
506 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
508 * callint.c (Fcall_interactively): Don't truncate prompt string.
510 2011-12-23 Eli Zaretskii <eliz@gnu.org>
512 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
513 property that ends at ZV, so that the bidi iteration could be
514 resumed from there (after widening). (Bug#10360)
516 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
518 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
520 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
522 * nsterm.m (x_free_frame_resources):
523 Release f->output_data.ns->miniimage.
524 (ns_index_color): Fix indentation. Do not retain
525 color_table->colors[i].
527 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
530 * nsfns.m (x_set_background_color): Assign return value from
531 ns_index_color to face-background instead of NSColor*.
532 (ns_implicitly_set_icon_type): Fix indentation.
533 Change assignment in for loop to comparison.
535 * emacs.c (ns_pool): New variable.
536 (main): Assign ns_pool.
537 (Fkill_emacs): Call ns_release_autorelease_pool.
539 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
540 autorelease fdesc, release fdAttrs and tdict.
541 (ns_get_covering_families): Release charset.
542 (ns_findfonts): Release NSFontDescriptor created with new.
543 (ns_uni_to_glyphs): Fix indentation.
544 (setString): Release attrStr before assigning new value.
546 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
548 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
550 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
551 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
553 2011-12-18 David Reitter <reitter@cmu.edu>
555 * nsterm.m (ns_term_init): Subscribe for notifications
556 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
557 to method trackingNotification in EmacsMenu.
559 * nsmenu.m (trackingMenu): New variable.
560 (trackingNotification): New method (from Aquamacs).
561 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
562 from Aquamacs (Bug#7030).
564 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
566 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
567 (symbol_to_nsstring): Fix indentation.
568 (ns_symbol_to_pb): New function.
569 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
570 (Fns_rotate_cut_buffers_internal): Remove.
571 (Fns_store_selection_internal): Rename from
572 Fns_store_cut_buffer_internal.
573 (ns_get_foreign_selection, Fx_own_selection_internal)
574 (Fx_disown_selection_internal, Fx_selection_exists_p)
575 (Fns_get_selection_internal, Fns_store_selection_internal):
576 Use ns_symbol_to_pb and check if return value is nil.
577 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
578 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
579 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
580 renamed to Sns_store_selection_internal.
581 (ns_handle_selection_request): Move code to Fx_own_selection_internal
582 and remove this function.
583 (ns_handle_selection_clear): Remove, never used.
584 (Fx_own_selection_internal): Move code from ns_handle_selection_request
587 2011-12-17 Ken Brown <kbrown@cornell.edu>
589 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
590 GID is unknown (Bug#10257).
592 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
594 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
595 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
596 which caused a build failure on GNU/Linux IA-64. This problem was
597 introduced by my 2011-10-07 patch.
599 2011-12-15 Juri Linkov <juri@jurta.org>
601 * image.c (imagemagick_error): New function. (Bug#10112)
602 (imagemagick_load_image): Comment out `MagickSetResolution' call.
603 Use `imagemagick_error' where ImageMagick functions return
605 (Fimagemagick_types): Add `Fnreverse' to return the list in the
608 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
610 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
611 fill background (Bug#8992).
613 2011-12-13 Martin Rudalics <rudalics@gmx.at>
615 * window.c (Vwindow_combination_resize)
616 (Vwindow_combination_limit): Use t instead of non-nil in
618 (Vrecenter_redisplay): Add first sentence of doc-string on
620 (Frecenter): Fix doc-string typo.
622 2011-12-11 Kenichi Handa <handa@m17n.org>
624 * coding.c (Funencodable_char_position): Pay attention to the
625 buffer text relocation (Bug#9389).
627 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
629 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
630 gtk_init (Bug#10100).
632 2011-12-10 Eli Zaretskii <eliz@gnu.org>
634 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
635 IT->string is nil. (Bug#10263)
637 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
639 * nsterm.h (x_free_frame_resources): Declare.
641 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
642 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
644 * nsterm.h (ns_get_defaults_value): Declare.
646 * nsterm.m (ns_default): Call ns_get_defaults_value.
648 2011-12-09 Eli Zaretskii <eliz@gnu.org>
650 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
653 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
655 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
656 that where the value of an _OBJC_* symbol points to is in the .bss
659 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
661 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
662 after the loop to call ccl_driver at least once (Bug#8619).
664 2011-12-08 Kenichi Handa <handa@m17n.org>
666 * ftfont.c (get_adstyle_property): Fix previous change
669 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
671 * w32.c (init_environment): If no_site_lisp, remove site-lisp
672 dirs from the default value of EMACSLOADPATH (bug#10208).
674 2011-12-07 Glenn Morris <rgm@gnu.org>
676 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
677 installation and source directories as well. (Bug#10208)
679 2011-12-06 Chong Yidong <cyd@gnu.org>
681 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
683 2011-12-06 Glenn Morris <rgm@gnu.org>
685 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
686 as an error, not just -1. (Bug#10217)
688 2011-12-05 Chong Yidong <cyd@gnu.org>
690 * keyboard.c (process_special_events): New function.
691 (swallow_events, Finput_pending_p): Use it (Bug#10195).
693 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
695 * coding.c (encode_designation_at_bol): Don't use uninitialized
696 local variable (Bug#9318).
698 2011-12-05 Kenichi Handa <handa@m17n.org>
700 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
701 return Qnil (Bug#8046, Bug#10193).
703 2011-12-05 Kenichi Handa <handa@m17n.org>
705 * coding.c (encode_designation_at_bol): New args charbuf_end and
706 dst. Return the number of produced bytes. Callers changed.
707 (coding_set_source): Return how many bytes coding->source was
709 (coding_set_destination): Return how many bytes
710 coding->destination was relocated.
711 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
712 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
714 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
716 * coding.c (CODING_CHAR_CHARSET_P): New macro.
717 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
720 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
722 The following changes are to fix Bug#9318.
724 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
725 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
726 (encode_coding_iso_2022, encode_coding_sjis)
727 (encode_coding_big5, encode_coding_charset): Use the above macros.
729 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
731 * lisp.h (process_quit_flag): Fix external declaration.
733 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
735 Don't macro-inline non-performance-critical code.
736 * eval.c (process_quit_flag): New function.
737 * lisp.h (QUIT): Use it.
739 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
741 * nsfns.m (get_geometry_from_preferences): New function.
742 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
744 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
746 * emacs.c (Qkill_emacs): Define.
747 (syms_of_emacs): Initialize it.
748 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
749 Qquit_flag to `kill-emacs' instead.
750 (quit_throw_to_read_char): Add parameter `from_signal'.
751 All callers changed. Call Fkill_emacs if requested and safe.
752 * lisp.h (QUIT): Call Fkill_emacs if requested.
754 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
756 * widget.c (update_wm_hints): Return if wmshell is null.
757 (widget_update_wm_size_hints): New function.
759 * widget.h (widget_update_wm_size_hints): Declare.
761 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
762 widget_update_wm_size_hints (Bug#10104).
764 2011-12-03 Eli Zaretskii <eliz@gnu.org>
766 * xdisp.c (handle_invisible_prop): If the invisible text ends just
767 before a newline, prepare the bidi iterator for consuming the
768 newline, and keep the current paragraph direction. (Bug#10183)
769 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
771 2011-12-02 Juri Linkov <juri@jurta.org>
773 * search.c (Fword_search_regexp): New Lisp function created from
774 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
775 (Fword_search_backward, Fword_search_forward)
776 (Fword_search_backward_lax, Fword_search_forward_lax):
777 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
778 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
780 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
782 * fileio.c (Finsert_file_contents): Move after-change-function call
783 to before the "handled:" label, since all "goto handled" appear in
784 cases where the *-change-functions have already been properly called
787 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
789 * keyboard.c (interrupt_signal): Don't call kill-emacs when
790 waiting for input. (Bug#10169)
792 2011-11-30 Eli Zaretskii <eliz@gnu.org>
794 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
795 verifies glyph row's hash code--we have just reallocated the
796 glyphs, so their contents can be complete garbage. (Bug#10164)
798 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
800 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
802 2011-11-30 Eli Zaretskii <eliz@gnu.org>
804 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
805 attributes are tested _before_ calling verify_row_hash, to protect
806 against GCC re-ordering of the tests. (Bug#10164)
808 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
810 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
812 * xterm.c (handle_one_xevent): Only set async_visible and friends
813 if net_wm_state_hidden_seen is non-zero (Bug#10002)
814 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
815 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
817 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
819 Remove GCPRO-related macros that exist only to avoid shadowing locals.
820 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
821 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
822 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
823 All uses changed to use GCPRO1 etc.
824 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
825 Revert to old implementation (i.e., before 2011-03-11).
827 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
829 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
830 of scroll runs so as to avoid assigning disabled bogus rows and
831 unnecessary graphics copy operations.
833 2011-11-27 Eli Zaretskii <eliz@gnu.org>
835 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
836 (snprintf) [_MSC_VER]: Redirect to _snprintf.
837 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
838 (malloc, free, realloc, calloc): Redirect to e_* only when
841 * lisp.h (GCTYPEBITS): Move before first use.
842 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
843 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
844 this macro definition.
846 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
849 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
851 * gtkutil.c (xg_create_frame_widgets):
852 Call gtk_window_set_has_resize_grip (FALSE) if that function is
853 present with Gtk+ 2.0.
855 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
857 * fileio.c (Finsert_file_contents): Undo previous change; see
858 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
860 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
862 Rename locals to avoid shadowing.
863 * fileio.c (Finsert_file_contents):
864 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
865 * process.c (wait_reading_process_output):
866 Rename inner 'proc' to 'p' to avoid shadowing.
867 Indent for consistency with usual Emacs style.
869 2011-11-25 Eli Zaretskii <eliz@gnu.org>
871 * xdisp.c (redisplay_window): If cursor row is not fully visible
872 after recentering, and scroll-conservatively is set to a large
873 number, scroll window by a few more lines to make the cursor fully
874 visible and out of scroll-margin. (Bug#10105)
875 (start_display): Don't move to the next line if the display should
876 start at a newline that is part of a display vector or an overlay
879 2011-11-24 Juri Linkov <juri@jurta.org>
881 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
882 after the `MagickPingImage' call. (Bug#10112)
884 2011-11-23 Chong Yidong <cyd@gnu.org>
886 * window.c (Fcoordinates_in_window_p): Accept only live windows.
888 2011-11-23 Martin Rudalics <rudalics@gmx.at>
890 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
891 making another buffer current. (Bug#10114)
893 2011-11-23 Glenn Morris <rgm@gnu.org>
895 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
897 2011-11-23 Chong Yidong <cyd@gnu.org>
899 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
902 2011-11-22 Eli Zaretskii <eliz@gnu.org>
904 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
905 and header-lines, as they don't have one computed for them.
908 * .gdbinit (prow): Make displayed values more self-explaining.
911 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
913 * process.c (wait_reading_process_output): Fix asynchrounous
914 GnuTLS socket handling on some versions of the GnuTLS library.
915 (wait_reading_process_output): Add comment and URL.
917 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
919 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
921 2011-11-21 Chong Yidong <cyd@gnu.org>
923 * window.c (Fnext_window, Fprevious_window): Doc fix.
925 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
927 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
929 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
931 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
933 2011-11-20 Martin Rudalics <rudalics@gmx.at>
935 * window.c (Fset_window_combination_limit): Rename argument
937 (Vwindow_combination_limit): Remove "status" from doc-string.
939 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
941 * m/ibms390.h: Remove.
942 * m/ibms390x.h: Don't include "ibms390.h".
944 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
946 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
947 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
949 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
951 * casetab.c (Fset_case_table):
952 * charset.c (Fcharset_after): Fix typos.
954 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
956 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
957 Otherwise, valgrind does not work on some platforms.
958 Problem reported by Andreas Schwab in
959 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
960 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
961 is set, removing the need for VIRT_ADDRESS_VARIES.
962 (PURE_P): Use a more-efficient implementation that needs just one
963 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
964 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
965 to 4 (xorl, subq, cmpq, setbe).
966 * alloc.c (pure): Always extern now, since that's the
967 VIRT_ADDR_VARIES behavior.
968 (PURE_POINTER_P): Use a single comparison, not two, for
969 consistency with the new puresize.h.
970 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
971 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
972 Remove VIRT_ADDR_VARIES no longer needed.
974 2011-11-19 Eli Zaretskii <eliz@gnu.org>
976 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
977 (erase_phys_cursor, update_window_cursor, show_mouse_face)
978 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
979 behave as if the cursor position were at the window margin.
981 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
982 and the cursor position is out of bounds, behave as if the cursor
983 position were at the window margin. (Bug#10075)
985 2011-11-18 Chong Yidong <cyd@gnu.org>
987 * window.c (Fwindow_combination_limit): Make first argument
988 non-optional, since it is meaningless for live windows like the
991 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
993 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
995 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
997 * intervals.c: Fix grafting over the whole buffer (bug#10071).
998 (graft_intervals_into_buffer): Simplify.
1000 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1002 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1003 hash values of the two rows.
1004 (copy_row_except_pointers): Preserve the used[] arrays and the
1005 hash values of the two rows. (Bug#10035)
1006 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1008 * xdisp.c (row_hash): New function, body extracted from
1009 compute_line_metrics.
1010 (compute_line_metrics): Call row_hash, instead of computing the
1013 * dispnew.c (verify_row_hash): Call row_hash for computing the
1014 hash code of a row, instead of duplicating code from xdisp.c.
1016 * dispextern.h (row_hash): Add prototype.
1018 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1020 * frame.c (delete_frame): Don't delete the terminal when the last
1021 X frame is closed if emacs is built with GTK toolkit.
1023 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1025 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1027 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1029 * window.c (Vwindow_splits): Rename to
1030 Vwindow_combination_resize. Suggested by Juri Linkov.
1031 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1034 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1036 * nsfns.m (Fns_font_name):
1037 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1039 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1041 * window.h (window): Rename slot "nest" to "combination_limit".
1042 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1043 (Fset_window_nest): Rename to Fset_window_combination_limit.
1044 (Vwindow_nest): Rename to Vwindow_combination_limit.
1045 (recombine_windows, make_parent_window, make_window)
1046 (Fsplit_window_internal, saved_window)
1047 (Fset_window_configuration, save_window_save): Rename all
1048 occurrences of window_nest to window_combination_limit.
1050 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1052 * image.c (imagemagick_load_image): Fix typo.
1054 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1056 * xdisp.c (display_line): Move the call to
1057 highlight_trailing_whitespace before the call to
1058 compute_line_metrics, since the latter needs to see the final
1059 faces of all the glyphs to compute ROW's hash value.
1060 Fixes assertion violations in row_equal_p. (Bug#10035)
1062 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1064 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1065 just return (bug#10044).
1067 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1069 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1070 with user-defined heap size. Bump the default size of the temacs
1071 heap to 27MB, to avoid memory warning when running temacs.
1072 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1074 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1075 current_matrix and desired_matrix. (Bug#9990)
1076 (verify_row_hash) [XASSERTS]: New function.
1077 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1078 that the hash value of glyph rows is correct.
1080 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1082 * window.h (window): Remove splits slot.
1083 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1084 (Fdelete_other_windows_internal, make_parent_window)
1085 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1086 (Fset_window_configuration, save_window_save): Don't deal with
1087 split status of windows.
1088 (saved_window): Remove splits slot.
1089 (Vwindow_splits): Rewrite doc-string.
1091 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1093 * xfns.c (unwind_create_frame):
1094 * nsfns.m (unwind_create_frame):
1095 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1096 Vframe_list (Bug#9999).
1098 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1100 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1102 2011-11-11 Kenichi Handa <handa@m17n.org>
1104 * callproc.c (Fcall_process): Set the member dst_multibyte of
1107 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1109 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1110 avoid a crash (bug#9496).
1112 2011-11-09 Chong Yidong <cyd@gnu.org>
1114 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1115 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1117 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1119 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1121 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1123 Avoid some portability problems by eschewing 'extern inline' functions.
1124 The trivial performance wins aren't worth the portability hassles; see
1125 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1127 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1128 (window_box_width, window_box_left, window_box_left_offset)
1129 (window_box_right, window_box_right_offset): Undo previous change,
1130 by removing the "extern"s.
1131 * intervals.c (adjust_intervals_for_insertion)
1132 (adjust_intervals_for_deletion): Undo previous change,
1133 making these static again.
1134 (offset_intervals, temp_set_point_both, temp_set_point)
1135 (copy_intervals_to_string): No longer inline.
1136 * xdisp.c (window_text_bottom_y, window_box_width)
1137 (window_box_height, window_box_left_offset)
1138 (window_box_right_offset, window_box_left, window_box_right)
1139 (window_box): No longer inline.
1141 2011-11-08 Chong Yidong <cyd@gnu.org>
1143 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1144 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1145 Signal an error if not a live window.
1146 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1147 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1149 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1151 * lisp.h (syms_of_abbrev): Remove declaration.
1152 Reported by CHENG Gao <chenggao@royau.me>.
1154 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1156 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1157 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1158 of temacs in GUI mode.
1160 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1162 * window.h: Declare delete_all_child_windows instead of
1163 delete_all_subwindows.
1164 * window.c (Fwindow_nest, Fset_window_nest)
1165 (Fset_window_new_total, Fset_window_new_normal)
1166 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1167 (delete_all_subwindows): Rename to delete_all_child_windows.
1168 (Fdelete_other_windows_internal, Fset_window_configuration):
1169 Call delete_all_child_windows instead of delete_all_subwindows.
1170 * frame.c (delete_frame): Call delete_all_child_windows instead
1171 of delete_all_subwindows.
1173 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1175 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1176 This is also needed for porting to any host where GC_MARK_STACK is
1177 not GC_MAKE_GCPROS_NOOPS.
1178 (which_symbols): Use it.
1180 2011-11-07 Kenichi Handa <handa@m17n.org>
1182 * coding.c (coding_set_destination): Check coding->src_pos only
1183 when coding->src_object is a buffer (bug#9910).
1185 * process.c (send_process): Set the member src_multibyte of coding
1186 to 0 (bug#9911) when sending a unibyte text.
1188 * callproc.c (Fcall_process): Set the member src_multibyte of
1189 process_coding to 0 (bug#9912).
1191 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1193 * xmenu.c (cleanup_widget_value_tree): New function.
1194 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1195 calling free_menubar_widget_value_tree directly (Bug#9830).
1197 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1199 Fix some portability problems with 'inline'.
1200 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1201 (window_box_width, window_box_left, window_box_left_offset)
1202 (window_box_right, window_box_right_offset): Declare extern.
1203 Otherwise, these inline functions do not conform to C99 and
1204 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1205 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1206 * intervals.c (adjust_intervals_for_insertion)
1207 (adjust_intervals_for_deletion): Now extern, because otherwise the
1208 extern inline functions 'offset_intervals' couldn't refer to it.
1209 (static_offset_intervals): Remove.
1210 (offset_intervals): Rewrite using the old contents of
1211 static_offset_intervals. The old version didn't conform to C99
1212 because an extern inline function contained a reference to an
1213 identifier with static linkage.
1215 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1217 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1220 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1222 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1223 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1224 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1225 return Qleft_to_right.
1227 2011-11-06 Chong Yidong <cyd@gnu.org>
1229 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1230 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1231 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1232 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1233 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1234 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1235 (Fwindow_vscroll): Doc fix.
1236 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1237 argument, since it makes no sense to pass a live window and for
1238 consistency with window-child.
1240 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1242 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1245 2011-11-05 Jason Rumney <jasonr@gnu.org>
1247 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1248 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1250 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1251 bitwise arithmetic preventing use of unicode-sip and non-truetype
1254 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1256 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1259 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1260 initialization code to keep similarity to xfns.c after changes
1263 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1265 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1266 (unwind_create_frame): New function (Bug#9943).
1267 (Fx_create_frame): Restructure code to be more similar to the one in
1268 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1269 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1270 Move terminal->reference_count++ just before making the frame official
1273 * nsterm.m (x_free_frame_resources): New function.
1274 (x_destroy_window): Move code to x_free_frame_resources.
1276 * xfns.c (unwind_create_frame): Fix comment.
1277 (Fx_create_frame, x_create_tip_frame):
1278 Move terminal->reference_count++ just before making the frame
1279 official. Move initialization of image_cache_refcount and
1280 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1282 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1284 Support MSVC build with newer versions of Visual Studio.
1285 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1286 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1289 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1290 which are not supported by MSVC.
1291 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1292 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1294 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1296 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1298 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1300 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1302 Support MSVC build with newer versions of Visual Studio.
1303 * w32.c: Don't include w32api.h for MSVC.
1304 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1306 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1307 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1308 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1309 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1311 (alloca) [_MSC_VER]: Define to _alloca.
1313 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1315 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1317 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1319 * xdisp.c (note_mouse_highlight): If either of
1320 previous/next-single-property-change returns nil, treat that as
1321 the beginning or the end of the buffer. (Bug#9955)
1323 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1325 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1326 label is not null (Bug#9951).
1327 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1330 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1332 * window.c (Fwindow_body_size): Mention in the doc string that the
1333 return value is in frame's canonical units. (Bug#9949)
1335 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1337 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1339 * w32fns.c (unwind_create_frame): If needed, free the glyph
1340 matrices of the partially constructed frame. (Bug#9943)
1341 * xfns.c (unwind_create_frame): Likewise.
1343 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1345 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1346 Don't stop backward scan on the continuation glyph, even though
1347 its CHARPOS is positive.
1348 (mouse_face_from_buffer_pos, note_mouse_highlight):
1349 Rename cover_string to disp_string.
1351 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1353 * window.c (temp_output_buffer_show): Don't use
1354 Vtemp_buffer_show_specifiers.
1355 (Vtemp_buffer_show_specifiers): Remove unused variable.
1357 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1359 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1360 past the beginning of the current glyph matrix.
1362 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1364 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1365 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1366 HAVE_GTK3 (Bug#9869).
1368 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1369 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1371 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1373 * xterm.c: Declare x_handle_net_wm_state to return int.
1374 (handle_one_xevent): Check if we are iconified but don't have
1375 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1376 (get_current_wm_state): Return non-zero if not hidden,
1377 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1378 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1379 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1380 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1382 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1384 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1385 so that this new function doesn't get optimized away by a
1386 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1388 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1390 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1392 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1394 Fix the `xbytecode' command.
1395 * .gdbinit (xprintbytestr): New command.
1396 (xwhichsymbols): Rename from `which'; all callers changed.
1397 (xbytecode): Print the byte-code string as well.
1399 2011-10-29 Kim Storm <storm@cua.dk>
1401 * alloc.c (which_symbols): New function.
1403 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1405 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1408 2011-10-29 Glenn Morris <rgm@gnu.org>
1410 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1411 Not clear what it was for, and it causes various bugs. (Bug#9839)
1413 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1415 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1416 possible random value that matches one of those tested as
1417 condition to clear the mouse face.
1419 2011-10-28 Chong Yidong <cyd@gnu.org>
1421 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1423 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1425 * window.c (make_window): Initialize phys_cursor_on_p.
1427 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1429 * lisp.h (struct Lisp_Symbol): Update comments.
1431 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1433 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1435 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1437 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1438 <oslsachem@gmail.com> for helping to debug this.
1440 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1441 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1442 (g_b_init_get_glyph_outline_w): New static variables.
1443 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1444 (GetGlyphOutlineW_Proc): New typedefs.
1445 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1446 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1448 (w32font_open_internal, compute_metrics):
1449 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1450 instead of calling the "wide" APIs directly.
1452 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1454 * w32.h (syms_of_w32font): Add prototype.
1456 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1458 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1459 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1460 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1461 (Fmove_to_window_line): Doc fix.
1463 2011-10-27 Chong Yidong <cyd@gnu.org>
1465 * process.c (make_process): Set gnutls_state to NULL.
1467 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1468 non-NULL, regardless of GNUTLS_INITSTAGE.
1469 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1470 an error. Set process slots as soon as we allocate them.
1472 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1474 2011-10-27 Chong Yidong <cyd@gnu.org>
1476 * gnutls.c (emacs_gnutls_deinit): New function.
1477 Deallocate credentials structures as well as calling gnutls_deinit.
1478 (Fgnutls_deinit, Fgnutls_boot): Use it.
1480 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1481 (deactivate_process): Call emacs_gnutls_deinit.
1483 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1485 * image.c (x_create_x_image_and_pixmap):
1486 * w32.c (sys_rename, w32_delayed_load):
1487 * w32font.c (fill_in_logfont):
1488 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1490 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1492 * w32fns.c (w32_default_color_map): New function,
1493 extracted from Fw32_default_color_map.
1494 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1496 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1498 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1500 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1502 * keyboard.c (test_undefined): New function (bug#9751).
1503 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1505 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1507 * sysdep.c (init_sys_modes): Fix the check for the controlling
1508 terminal (Bug#6649).
1510 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1512 * dispextern.h (struct bidi_it): New member next_en_type.
1514 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1515 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1516 current character, check also for next_en_type being WEAK_EN.
1517 (bidi_resolve_weak): Don't enter the expensive loop if the current
1518 position is before next_en_pos. Record the bidi type of the first
1519 non-ET, non-BN character we find, in addition to its position.
1520 (bidi_level_of_next_char): Invalidate next_en_type when
1521 next_en_pos is over-stepped.
1523 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1525 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1526 * editfns.c: Rewrite current-time-zone so that it invokes
1527 the equivalent of (format-time-string "%Z") to get the time zone name.
1528 This fixes a bug when the time zone name contains characters that
1529 need converting from the system time locale to Emacs internal format.
1530 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1531 that patch fixed format-time-string to do the conversion, but
1532 I forgot to fix current-time-zone.
1533 (format_time_string): New function, containing most of
1534 what Fformat_time_string used to contain.
1535 (Fformat_time_string): Rewrite in terms of format_time_string.
1536 This doesn't change this function's behavior.
1537 (current-time-zone): Rewrite to use format_time_string.
1538 This fixes the bug reported by Michael Schierl in
1539 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1540 Jason Rumney's 2007-06-07 change worked around this bug, but
1542 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1544 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1546 * xdisp.c (start_display): If the character at POS is displayed
1547 via a display vector, reset IT->current.dpvec_index to zero.
1548 (try_window_reusing_current_matrix): If a line ends in a display
1549 vector or the next line starts in a display vector, continue
1550 redrawing the window even though the character position of
1551 start_row was reached.
1554 2011-10-18 Chong Yidong <cyd@gnu.org>
1556 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1557 with nobreak-char-display too.
1559 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1561 Fix part 3 of bug#9771.
1562 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1563 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1564 non-neutral characters if the current character is a paragraph
1565 separator (a.k.a. Newline). This avoids running the same
1566 expensive loop twice, once when we consume the preceding newline
1567 and the other time when the line actually needs to be displayed.
1568 Avoid the loop when we see neutrals on the base embedding level
1569 following a character whose directionality is the same as the
1570 paragraph's. This avoids running the expensive loop when a line
1571 ends in a long sequence of neutrals, like control characters.
1572 Add assertion against STRONG_AL type. Slightly rearrange code
1573 that determines the type of a neutral given the first non-neutral
1575 (bidi_level_of_next_char): Set next_en_pos to zero when
1576 invalidating its info.
1578 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1580 * xdisp.c (push_display_prop): Determine whether to record string
1581 or buffer position by IT->string, not by IT->method. Allow
1582 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1583 (move_it_vertically_backward): Don't look for character position
1584 immediately after the newline when in a continuation line.
1587 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1589 * window.c (coordinates_in_window): Rewrite and delabelize
1590 vertical border check. (Bug#5357) (Bug#9618)
1592 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1594 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1595 errors in XSetWindowBorder (bug#9310).
1597 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1599 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1600 avoid crash when xmalloc overrun checking is enabled.
1602 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1604 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1605 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1606 cursor motion with <left> and <right> arrow keys.
1608 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1609 some callers set that themselves.
1611 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1613 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1614 display string and the previous row comes from the same string and
1615 is empty. (Bug#9739) (Bug#9738)
1617 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1619 * doc.c (get_doc_string): Encode file name (bug#9735).
1621 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1623 * bidi.c (bidi_level_of_next_char):
1624 * xdisp.c (get_visually_first_element): Remove old incorrect
1625 comments regarding the Unicode Line Separator character.
1627 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1629 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1631 * alloc.c (Fgc_status): Do not access beyond zombies array
1632 boundary if nzombies > MAX_ZOMBIES.
1633 * alloc.c (dump_zombies): Add missing format specifier.
1635 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1637 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1638 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1640 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1641 Some packages use them to denote characters with modifiers.
1643 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1645 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1646 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1647 matching a pp-number. Rename parameter var to var1.
1649 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1651 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1653 2011-10-08 Glenn Morris <rgm@gnu.org>
1655 * callint.c (Fcall_interactively): Give a more explicit error for the
1656 'c' case with a non-character input. (Bug#8479)
1658 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1660 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1662 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1663 lines that are hscrolled on the left.
1665 * dispnew.c (buffer_posn_from_coords): Account for a possible
1666 presence of header-line. (Bug#4426)
1668 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1670 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1671 Don't advertise functionality which we discourage or doesn't work.
1673 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1675 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1676 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1677 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1678 this makes Emacs dump core during garbage collection on rare
1679 occasions. sizeof is obviously inferior to offsetof here, so
1680 stick with offsetof.
1681 (GC_POINTER_ALIGNMENT): New macro.
1682 (mark_memory): Omit 3rd (offset) arg; caller changed.
1683 Don't assume EMACS_INT alignment is the same as pointer alignment.
1685 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1687 * keyboard.c (read_key_sequence_remapped): New var.
1688 (read_key_sequence): Compute remapping in the right buffer.
1689 (command_loop_1): Use read_key_sequence's remapping directly.
1691 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1693 * dired.c (file_name_completion): Don't expand file name.
1694 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1695 before checking file name handler.
1697 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1698 they've been requested explicitly (bug#9591).
1700 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1702 * keymap.c (Fsingle_key_description): Use make_specified_string
1703 instead of build_string to build string from push_key_description.
1706 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1708 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1709 This fixes a Y2038 bug on 64-bit hosts.
1710 * buffer.c (reset_buffer):
1711 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1712 (Fclear_buffer_auto_save_failure):
1713 Use 0, not -1, to represent an unset failure time, since time_t
1714 might not be signed.
1716 Remove dependency on glibc malloc internals.
1717 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1718 Move back here from lisp.h, but with their new implementations.
1719 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1720 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1721 * charset.c (charset_table_init): New static var.
1722 (syms_of_charset): Use it instead of xmalloc. This removes a
1723 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1724 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1725 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1726 Move back to alloc.c.
1727 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1728 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1730 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1732 * nsterm.m (windowDidResize): Call x_set_window_size only when
1733 ns_in_resize is true. Otherwise set pixelwidth/height and
1734 call change_frame_size (Bug#9628).
1736 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1738 Port --enable-checking=all to Fedora 14 x86-64.
1739 * charset.c (syms_of_charset): Also account for glibc malloc's
1740 internal overhead when calculating the initial malloc maximum.
1742 Port --enable-checking=all to Fedora 14 x86.
1743 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1745 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1746 (overrun_check_realloc, overrun_check_free):
1747 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1748 That way, xmalloc returns a properly-aligned pointer even if
1749 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1750 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1751 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1752 into account when calculating the initial malloc maximum.
1753 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1754 Move here from alloc.c, so that charset.c can use it too.
1755 Properly align; the old code wasn't right for common 32-bit hosts
1756 when configured with --enable-checking=all.
1757 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1758 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1760 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1762 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1765 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1767 * xdisp.c (compute_display_string_end): If there's no display
1768 string at CHARPOS, return -1.
1770 * bidi.c (bidi_fetch_char): When compute_display_string_end
1771 returns a negative value, treat the character as a normal
1772 character not covered by a display string. (Bug#9624)
1774 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1776 * lread.c (Fread_from_string): Fix typo in docstring.
1778 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1780 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1781 newline, reseat the iterator instead of bidi-iterating there one
1782 character at a time. (Bug#9610)
1783 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1784 TO_CHARPOS if the bidi iterator is at base embedding level.
1786 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1788 * lread.c (readevalloop): Use correct code for NBSP.
1789 (read1): Likewise. (Bug#9608)
1791 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1793 * dbusbind.c (Fdbus_register_signal): When service is not
1794 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1796 2011-09-25 Glenn Morris <rgm@gnu.org>
1798 * buffer.c (truncate-lines): Doc fix.
1800 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1802 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1803 (Fset_window_next_buffers): Doc fix.
1805 2011-09-24 Glenn Morris <rgm@gnu.org>
1807 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1809 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1811 Fix minor problems found by static checking.
1812 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1813 * indent.c (Fvertical_motion): Fix == vs = typo.
1815 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1817 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1818 Default value is now t. Doc fix.
1820 * indent.c (Fvertical_motion): Compute and apply the overshoot
1821 logic when moving up, not only when moving down. Fix the
1822 confusing name and values of the it_overshoot_expected variable;
1823 logic changes accordingly. (Bug#9254) (Bug#9549)
1825 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1826 CHARPOS is covered by a display string which includes newlines.
1827 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1828 is covered by a display string with embedded newlines.
1830 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1832 * dbusbind.c (Fdbus_register_signal): Add match rule to
1833 Vdbus_registered_objects_table. (Bug#9581)
1834 (Fdbus_register_method, Vdbus_registered_objects_table):
1837 2011-09-24 Jim Meyering <meyering@redhat.com>
1839 do not ignore write error for any output size
1840 The previous change was incomplete.
1841 While it makes emacs --batch detect the vast majority of stdout
1842 write failures, errors were still ignored whenever the output size is
1843 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1844 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1845 && echo FAIL: ignored write error
1846 FAIL: ignored write error
1847 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1848 && echo FAIL: ignored write error
1849 FAIL: ignored write error
1850 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1852 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1854 * emacs.c (Fkill_emacs): In noninteractive mode exit
1855 non-successfully if a write error occurred on stdout. (Bug#9574)
1857 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1859 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1862 * dispextern.h (struct it): Update the comment documenting what
1865 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1867 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1868 a display string, extend search for cursor position to end of row.
1869 (find_row_edges): If the row ends in a newline from a display
1870 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1871 Handle the case of a display string with multiple newlines.
1872 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1873 non-empty line. Fixes confusing cursor motion with arrow keys at
1874 the beginning of a line that starts with whitespace.
1876 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1878 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1881 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1883 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1886 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1888 * xdisp.c (display_line): Record maximum and minimum buffer
1889 positions even if no glyphs were produced (e.g., by a zero-width
1890 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1891 buffer positions that will be removed from the glyph row because
1893 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1894 column is beyond frame width: don't subtract 1 "pixel" when
1895 computing width of the stretch.
1896 (reseat_at_next_visible_line_start): Undo the change made on
1897 2011-09-17 that saved paragraph information and restored it after
1898 the call to `reseat'. (Bug#9545)
1900 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1902 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1903 and turn window cursor on if cleared (Bug#9415).
1905 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1907 * search.c (boyer_moore): Take unibyte characters from pattern
1908 literally. (Bug#9458)
1910 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1912 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1914 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1916 Fix minor problem found by static checking.
1917 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1918 initialized, to pacify gcc -Wuninitialized.
1920 * fileio.c: Report proper errno when syscall falls.
1921 (Finsert_file_contents): Save and restore errno,
1922 so that report_file_error outputs the correct diagnostic.
1923 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1925 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1927 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1929 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1931 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1932 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1934 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1936 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1937 about the current paragraph and restore it after the call to reseat.
1939 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1940 (bidi_find_paragraph_start): Search back for paragraph beginning
1941 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1942 (bidi_move_to_visually_next): Only trigger paragraph-related
1943 computations when the last character is a newline or at EOB, not
1944 just any NEUTRAL_B. (Bug#9470)
1946 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1947 truncated lines if point is covered by a display string. (Bug#9524)
1949 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1951 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1952 (cons_to_x_long): New function.
1953 (lisp_data_to_selection_data): Use it. Correct the test for
1954 short-versus-long data; it was negated. Break out of vector
1955 loop, for efficiency, when a long datum is discovered.
1957 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1959 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1961 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1963 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1964 GCC PR/17406) by declaring this function with external scope.
1966 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1968 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1969 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1971 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1973 * editfns.c (Fformat): Correctly handle text properties on "%%".
1975 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1977 * xterm.c (x_draw_composite_glyph_string_foreground):
1978 * w32term.c (x_draw_composite_glyph_string_foreground):
1979 * term.c (encode_terminal_code):
1980 * composite.c (composition_update_it, get_composition_id):
1981 * xdisp.c (get_next_display_element)
1982 (fill_composite_glyph_string): Add comments about special meaning
1983 of TAB characters in a composition.
1985 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1987 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1988 This occurs when processing a multibyte format.
1989 Problem reported by Wolfgang Jenker.
1991 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1993 * xdisp.c (try_cursor_movement): Only check for exact match if
1994 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1996 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1998 Remove unused external symbols.
1999 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2000 * xdisp.c (calc_pixel_width_or_height): Now static.
2001 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2002 * indent.c (check_display_width):
2003 * w32term.c: Fix comment to match code.
2004 * xterm.c, xterm.h (x_catching_errors): Remove.
2006 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2008 * xselect.c: Use signed conversions more consistently (Bug#9498).
2009 (selection_data_to_lisp_data): Assume incoming selection data are
2010 signed integers, not unsigned. This is to be consistent with
2011 outgoing selection data, which was modified to use signed integers
2012 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2013 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2014 expects long, not unsigned long.
2016 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2018 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2019 computation of loop end. Reported by Johan Bockgård
2022 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2024 * frame.c (Fother_visible_frames_p): Function deleted.
2026 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2028 * indent.c (compute_motion): Process display vector front to back
2029 rather than the other way around. (Bug#2496)
2031 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2033 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2035 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2037 * minibuf.c (Fread_from_minibuffer): Doc fix.
2039 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2041 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2042 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2044 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2046 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2047 value for non-existent files.
2049 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2051 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2052 set its "size" to -1. This will set the modtime_size field of
2053 the corresponding buffer to -1, which is what
2054 verify-visited-file-modtime expects for files that do not exist.
2057 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2059 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2061 * lisp.h: ... from here. push_key_description is no longer
2062 defined in keyboard.c, so its declaration should not be in
2063 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2064 logically belongs with push_key_description.
2066 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2068 * buffer.h: Include <sys/types.h> instead of <time.h>.
2069 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2070 Problem reported by Herbert J. Skuhra.
2072 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2074 * xml.c (parse_region): Make the parsing work for
2075 non-comment-starting XML files again (bug#9144).
2077 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2079 * image.c (gif_load): Fix calculation of bottom and right corner.
2082 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2084 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2085 redisplay in small windows.
2087 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2089 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2091 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2093 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2094 Operate on live windows only.
2096 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2098 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2100 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2102 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2103 only under bidi iteration.
2105 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2107 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2109 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2111 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2112 Without this fix, the command to link temacs failed due to an
2113 undefined symbol __builtin_isnan. This is because
2114 /usr/include/iso/math_c99.h #defines isnan(x) to
2115 __builtin_isnan(x), but the bundled gcc, which identifies itself
2116 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2118 * floatfns.c (isnan): #undef, and then #define to a clone of
2120 (Fisnan): Always define, since it's always available now.
2121 (syms_of_floatfns): Always define isnan at the Lisp level.
2123 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2125 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2127 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2129 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2130 The previous code assumed that file offsets (off_t values) fit in
2131 EMACS_INT variables, which is not true on typical 32-bit hosts.
2132 The code messed up by falsely reporting buffer overflow in cases
2133 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2134 when "big" contains more than 2**29 bytes, even though this
2135 inserts just one byte and does not overflow the buffer.
2136 (Finsert_file_contents): Store file offsets as off_t
2137 values, not as EMACS_INT values. Check for overflow when
2138 converting between EMACS_INT and off_t. When checking for
2139 buffer overflow or for overlap, take the offsets into account.
2140 Don't use EMACS_INT for small values where int suffices.
2141 When checking for overlap, fix a typo: ZV was used where
2142 ZV_BYTE was intended.
2143 (Fwrite_region): Don't assume off_t fits into 'long'.
2144 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2146 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2148 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2150 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2152 sprintf-related integer and memory overflow issues (Bug#9412).
2154 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2155 (esprintf, exprintf, evxprintf): New functions.
2156 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2157 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2158 (modify_event_symbol): Do not assume that the length of
2159 name_alist_or_stem is safe to alloca and fits in int.
2160 (Fexecute_extended_command): Likewise for function name and binding.
2161 (Frecursion_depth): Wrap around reliably on integer overflow.
2162 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2163 since some callers pass EMACS_INT values.
2164 (Fsingle_key_description): Don't crash if symbol name contains more
2165 than MAX_ALLOCA bytes.
2166 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2167 (get_minibuffer): Arg is now EMACS_INT, not int.
2168 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2169 (esprintf, exprintf, evxprintf): New decls.
2170 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2172 * dbusbind.c (signature_cat): New function.
2173 (xd_signature, Fdbus_register_signal):
2174 Do not overrun buffer; instead, report string overflow.
2176 * dispnew.c (add_window_display_history): Don't overrun buffer.
2177 Truncate instead; this is OK since it's just a log.
2179 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2180 even if the time zone offset is outlandishly large.
2181 Don't mishandle offset == INT_MIN.
2183 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2184 when creating daemon; the previous buffer-overflow check was incorrect.
2186 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2187 which has the guts of the old verror function.
2189 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2190 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2192 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2193 (font_unparse_xlfd): Don't blindly alloca long strings.
2194 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2195 fits in int, when using sprintf. Use single snprintf to count
2196 length of string rather than counting it via multiple sprintfs;
2197 that's simpler and more reliable.
2198 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2199 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2200 sprintf, in case result does not fit in int.
2202 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2203 (fontset_from_font): Print it.
2205 * frame.c (tty_frame_count): Now printmax_t, not int.
2206 (make_terminal_frame, set_term_frame_name): Print it.
2207 (x_report_frame_params): In X, window IDs are unsigned long,
2208 not signed long, so print them as unsigned.
2209 (validate_x_resource_name): Check for implausibly long names,
2210 and don't assume name length fits in 'int'.
2211 (x_get_resource_string): Don't blindly alloca invocation name;
2212 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2215 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2216 (xg_check_special_colors, xg_set_geometry):
2217 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2219 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2220 Use esprintf, not sprintf, in case result does not fit in int.
2222 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2223 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2224 it as a large positive number.
2225 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2226 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2228 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2229 in case result does not fit in int.
2231 * print.c (float_to_string): Detect width overflow more reliably.
2232 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2233 buffer overrun. Don't assume list length fits in 'int'. Treat
2234 print length of 0 as 0, not as infinity; to be consistent with other
2235 uses of print length in this function. Don't overflow print length
2236 index. Don't assume hash table size fits in 'long', or that
2237 vectorlike size fits in 'unsigned long'.
2239 * process.c (make_process): Use printmax_t, not int, to format
2240 process-name gensyms.
2242 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2244 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2245 to avoid potential buffer overrun.
2247 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2248 if X resource line is longer than 512 bytes.
2250 * xfns.c (x_window): Make sprintf buffer a bit bigger
2251 to avoid potential buffer overrun.
2253 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2255 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2257 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2259 Integer overflow fixes for scrolling, etc.
2260 Without these, Emacs silently mishandles large integers sometimes.
2261 For example, "C-u 4294967297 M-x recenter" was treated as if
2262 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2264 * xdisp.c (try_window_id): Check Emacs fixnum range before
2265 converting to 'int'.
2267 * window.c (window_scroll_line_based, Frecenter):
2268 Check that an Emacs fixnum is in range before assigning it to 'int'.
2269 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2270 values converted from Emacs fixnums.
2271 (Frecenter): Don't wrap around a line count if it is out of 'int'
2272 range; instead, treat it as an extreme value.
2273 (Fset_window_configuration, compare_window_configurations):
2274 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2276 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2277 that can exceed INT_MAX. Check that EMACS_INT value is in range
2278 before assigning it to the (possibly-narrower) index.
2279 (match_limit): Don't assume that a fixnum can fit in 'int'.
2281 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2284 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2285 (Fvertical_motion): Don't wrap around LINES values that don't fit
2286 in 'int'. Instead, treat them as extreme values. This is good
2287 enough for windows, which can't have more than INT_MAX lines anyway.
2289 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2291 * Require libxml/parser.h to avoid compilation warning.
2293 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2295 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2296 since this reportedly can destroy thread storage.
2298 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2300 * syntax.c (find_defun_start): Update all cache variables if
2301 exiting early (Bug#9401).
2303 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2305 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2307 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2308 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2309 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2311 * term.c (tty_append_glyph): New function.
2312 (produce_stretch_glyph): Static function and its prototype deleted.
2314 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2317 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2319 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2320 when checking :margin (Bug#9390).
2321 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2322 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2323 so that the name doesn't mislead. All uses changed.
2325 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2327 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2330 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2332 * xdisp.c (move_it_to): Don't bail out early when reaching
2333 position beyond to_charpos, if we are scanning backwards.
2334 (move_it_vertically_backward): When DY == 0, make sure we get to
2335 the first character in the line after the newline.
2337 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2339 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2340 (ccl_driver): Do not generate an out-of-range pointer.
2341 (Fccl_execute_on_string): Remove unnecessary check for
2342 integer overflow, noted by Stefan Monnier in
2343 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2344 Remove a FIXME that didn't need fixing.
2345 Simplify the newly-introduced buffer reallocation code.
2347 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2349 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2351 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2353 Integer and memory overflow issues (Bug#9196).
2355 * doc.c (get_doc_string): Rework so that
2356 get_doc_string_buffer_size is the actual buffer size, rather than
2357 being 1 less than the actual buffer size; this makes xpalloc more
2360 * image.c (x_allocate_bitmap_record, cache_image):
2361 * xselect.c (Fx_register_dnd_atom):
2362 Simplify previous changes by using xpalloc.
2364 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2365 since either will do and ptrdiff_t is convenient with xpalloc.
2367 * charset.c (charset_table_size)
2368 (struct charset_sort_data.priority): Now ptrdiff_t.
2369 (charset_compare): Don't overflow if priorities differ greatly.
2370 (Fsort_charsets): Don't assume list length fits in int.
2371 Check for size-calculation overflow when allocating sort data.
2372 (syms_of_charset): Allocate an initial charset table that is
2373 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2375 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2377 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2378 The actual value is always <= INT_MAX, and leaving it unsigned made
2379 overflow checking harder.
2381 * dispextern.h (struct glyph_matrix.rows_allocated)
2382 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2383 with xpalloc. The values are still always <= INT_MAX.
2385 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2387 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2388 (SAFE_NALLOCA): New macro.
2390 * region-cache.c (struct boundary.pos, find_cache_boundary)
2391 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2392 (set_cache_region, invalidate_region_cache)
2393 (revalidate_region_cache, know_region_cache, region_cache_forward)
2394 (region_cache_backward, pp_cache):
2395 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2396 so that ptrdiff_t * can be passed to xpalloc.
2397 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2398 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2399 (pp_cache): Don't assume cache_len fits in int.
2400 * region-cache.h: Adjust extern decls to match.
2402 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2403 EMACS_INT, since either will do, for xpalloc.
2405 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2406 (xnmalloc, xnrealloc, xpalloc): New functions.
2408 * bidi.c (bidi_shelve_header_size): New constant.
2409 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2410 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2412 * bidi.c (bidi_cache_shrink):
2413 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2415 Don't update size of array until after memory allocation succeeds,
2416 because xmalloc/xrealloc may not return.
2417 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2418 now that we have proper integer overflow checking.
2419 (record_overlay_string, overlay_strings): Catch overflows when
2420 calculating size of overlay_str_buf.
2422 * callproc.c (Fcall_process): Check for size overflow when
2423 calculating size of args2.
2424 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2425 Normally we prefer signed values, but sticking with ptrdiff_t would
2426 require adding more-complicated checks.
2428 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2429 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2430 Redo buffer-overflow calculations to avoid integer overflow.
2431 Add a FIXME comment where memory seems to be over-allocated.
2433 * character.c (Fstring): Check for size-calculation overflow.
2435 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2436 unnecessary integer overflow. Check for size overflow.
2437 (encode_coding_object): Don't update size until xmalloc succeeds.
2439 * composite.c (get_composition_id): Check for overflow in glyph
2440 length calculations.
2442 Integer and memory overflow fixes for display code.
2443 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2444 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2445 (scrolling_window): Check for overflow in size calculations.
2446 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2447 Don't assume glyph table len fits in int.
2448 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2449 (row_table_size): Now ptrdiff_t, not int.
2450 (scrolling_window): Avoid overflow in size calculations.
2451 Don't update size until allocation succeeds.
2452 * fns.c (concat): Check for overflow in size calculations.
2453 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2454 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2455 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2457 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2458 (get_doc_string): Check for size calculation overflow.
2459 Don't update size until allocation succeeds.
2460 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2461 EMACS_INT, where ptrdiff_t will do.
2462 (Fsubstitute_command_keys): Check for string overflow.
2464 * editfns.c (set_time_zone_rule): Don't assume environment length
2466 (message_length): Now ptrdiff_t, not int.
2467 (Fmessage_box): Don't update size until allocation succeeds.
2468 Don't assume message length fits in int.
2469 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2471 * emacs.c (main): Do not reallocate argv, since there is a null at
2472 the end that can be overwritten, and this way there's no need to
2473 worry about size-calculation overflow.
2474 (sort_args): Check for size-calculation overflow.
2476 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2478 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2480 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2481 (x_set_scroll_bar_width, x_figure_window_size):
2482 Check for integer overflow.
2483 (x_set_alpha): Do not assume XINT fits in int.
2485 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2486 This is for the members text_lines, text_cols, total_lines, total_cols,
2487 where the system imposes an 'int' limit.
2489 * fringe.c (Fdefine_fringe_bitmap):
2490 Don't update size until alloc works.
2492 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2493 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2495 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2496 Check for size-calculation overflow.
2497 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2498 do, as we prefer signed integers.
2499 (id_to_widget.max_size, id_to_widget.used)
2500 (xg_store_widget_in_map, xg_remove_widget_from_map)
2501 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2502 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2503 Use and return ptrdiff_t, not int.
2504 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2505 * gtkutil.h: Change prototypes to match the above.
2507 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2508 are duplicate now that they've been promoted to lisp.h.
2509 (x_allocate_bitmap_record, x_alloc_image_color)
2510 (make_image_cache, cache_image, xpm_load):
2511 Don't update size until alloc is done.
2512 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2514 Check for size calculation overflow.
2515 (ct_colors_allocated_max): New constant.
2516 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2519 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2520 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2521 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2522 Use ptrdiff_t, not int, to count maps.
2523 (read_char_minibuf_menu_prompt): Check for overflow in size
2524 calculations. Don't update size until allocation succeeds.
2525 Redo calculations to avoid overflow.
2526 * keyboard.h: Change prototypes to match the above.
2528 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2530 (current_minor_maps): Check for size calculation overflow.
2531 * keymap.h: Change prototypes to match the above.
2533 * lread.c (read1, init_obarray): Don't update size until alloc done.
2535 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2536 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2538 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2539 Now ptrdiff_t, not int.
2540 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2541 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2543 * process.c (Fnetwork_interface_list): Check for overflow
2544 in size calculation.
2546 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2548 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2549 overflow. Don't bother calling xmalloc when xrealloc will do.
2551 * search.c (Freplace_match): Check for size calculation overflow.
2552 (Fset_match_data): Don't assume list lengths fit in 'int'.
2554 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2555 for command line length. Do not attempt to address one before the
2556 beginning of an array, as that's not portable.
2558 * term.c (max_frame_lines): Remove; unused.
2559 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2561 (encode_terminal_code, calculate_costs): Check for size
2562 calculation overflow.
2563 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2564 table lengths and related sizes. Don't update size until alloc
2565 done. Redo calculations to avoid overflow.
2566 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2568 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2569 subtracting pointers.
2570 (gobble_line): Check for overflow more carefully. Don't update size
2573 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2574 Don't update size until alloc done.
2575 Redo size calculations to avoid overflow.
2576 Check for size calculation overflow.
2577 (main) [DEBUG]: Fix typo in invoking tparam1.
2579 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2580 Use ptrdiff_t, not int, for sizes.
2581 (store_mode_line_noprop_char): Don't update size until alloc done.
2583 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2584 Use ptrdiff_t, not int, for sizes.
2585 (Finternal_make_lisp_face, cache_face):
2586 Check for size calculation overflow.
2587 (cache_face): Treat size calculation overflows as if they were
2588 memory exhaustion (the usual treatment), rather than aborting.
2590 * xfns.c (x_encode_text, x_set_name_internal)
2591 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2592 sizes, since they can exceed INT_MAX in size. Check for size
2593 calculation overflow.
2595 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2596 (xg_select): Check for size calculation overflow.
2597 Don't update size until alloc done.
2599 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2600 as sprintf is limited to int lengths.
2602 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2603 (X_LONG_MIN): New macros.
2604 Use them to make the following changes clearer.
2605 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2606 This change doesn't affect the value now, but it may help remind
2607 future maintainers not to raise the value too much later.
2608 (SELECTION_QUANTUM): Remove, replacing with ...
2609 (selection_quantum): ... new function, which avoids overflow.
2611 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2612 assumption that selection length fits in 'int'.
2613 (x_reply_selection_request, x_handle_selection_request)
2614 (x_get_window_property, receive_incremental_selection)
2615 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2616 (lisp_data_to_selection_data, clean_local_selection_data):
2617 Use ptrdiff_t, not int, to record length of selection.
2618 (x_reply_selection_request, x_get_window_property)
2619 (receive_incremental_selection, x_property_data_to_lisp):
2620 Redo calculations to avoid overflow.
2621 (x_reply_selection_request): When sending hint, ceiling it at
2622 X_LONG_MAX rather than relying on wraparound overflow to send
2624 (x_get_window_property, receive_incremental_selection)
2625 (lisp_data_to_selection_data, x_property_data_to_lisp):
2626 Check for size-calculation overflow.
2627 (x_get_window_property, receive_incremental_selection)
2628 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2629 Don't store size until memory allocation succeeds.
2630 (x_get_window_property): Plug memory leak on memory exhaustion.
2631 Don't double-block input; malloc is safe here. Don't assume 2**34
2632 - 4 fits in unsigned long. Add an xassert to check
2633 XGetWindowProperty overflow. Be more careful about overflow
2634 calculations, and distinguish size from memory overflow better.
2635 (receive_incremental_selection): When tracing, don't assume
2636 unsigned int is less than INT_MAX.
2637 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2638 harmful) conversions of unsigned short to int.
2639 (lisp_data_to_selection_data): Don't assume that integers
2640 in the range -65535 through -1 fit in an X unsigned short.
2641 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2642 result parameters unless successful. Rely on cons_to_unsigned
2643 to report problems with elements; the old code wasn't right anyway.
2644 (x_check_property_data): Check for int overflow; we cannot use
2645 a wider type due to X limits.
2646 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2648 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2650 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2651 (x_term_init): Check for size calculation overflow.
2652 (x_color_cells): Don't store size until memory allocation succeeds.
2653 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2654 Don't assume alloca size is less than MAX_ALLOCA.
2655 (x_term_init): Don't assume length fits in int (sprintf is limited
2658 Use ptrdiff_t for composition IDs.
2659 * character.c (lisp_string_width):
2660 * composite.c (composition_table_size, n_compositions)
2661 (get_composition_id, composition_gstring_from_id):
2662 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2663 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2664 * window.c (Frecenter):
2665 Use ptrdiff_t, not int, for composition IDs.
2666 * composite.c (get_composition_id): Check for integer overflow.
2667 * composite.h: Adjust prototypes to match the above changes.
2669 Use ptrdiff_t for hash table indexes.
2670 * category.c (hash_get_category_set):
2671 * ccl.c (ccl_driver):
2672 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2673 * coding.c (coding_system_charset_list, detect_coding_system):
2674 * coding.h (struct coding_system.id):
2675 * composite.c (get_composition_id, gstring_lookup_cache):
2676 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2677 * image.c (xpm_get_color_table_h):
2678 * lisp.h (hash_lookup, hash_put):
2679 * minibuf.c (Ftest_completion):
2680 Use ptrdiff_t for hash table indexes, not int (which is too
2681 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2682 32-bit --with-wide-int hosts).
2684 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2685 Add a FIXME comment about memory leaks.
2686 (syms_of_charset): Don't assume xmalloc returns.
2688 Don't assume that stated character widths fit in int.
2689 * character.c (Fchar_width, c_string_width, lisp_string_width):
2690 * character.h (CHAR_WIDTH):
2691 * indent.c (MULTIBYTE_BYTES_WIDTH):
2692 Use sanitize_char_width to avoid undefined and/or bad behavior
2693 with outlandish widths.
2694 * character.h (sanitize_tab_width): Rename from sanitize_width,
2695 now that we have two such functions. All uses changed.
2696 (sanitize_char_width): New inline function.
2698 Don't assume that tab-width fits in int.
2699 * character.h (sanitize_width): New inline function.
2700 (SANE_TAB_WIDTH): New macro.
2701 (ASCII_CHAR_WIDTH): Use it.
2702 * indent.c (sane_tab_width): Remove. All uses replaced by
2703 SANE_TAB_WIDTH (current_buffer).
2704 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2706 * fileio.c: Integer overflow issues with file modes.
2707 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2709 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2710 Remove unreachable code.
2711 (read_hex, load_charset_map_from_file): Check for integer overflow.
2713 * xterm.c: Don't go over XClientMessageEvent limit.
2714 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2715 (x_send_scroll_bar_event): Likewise. Check that the size does not
2716 exceed limits imposed by XClientMessageEvent, as well as the usual
2717 ptrdiff_t and size_t limits.
2719 * keyboard.c: Overflow, signedness and related fixes.
2720 (make_lispy_movement): Use same integer type in forward decl
2721 that is used in the definition.
2722 (read_key_sequence, keyremap_step):
2723 Change bufsize argument back to int, undoing my 2011-03-30 change.
2724 We prefer signed types, and int is wide enough here.
2725 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2726 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2727 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2728 length, not size_t. Use ptrdiff_t for index, not int.
2729 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2730 possibility of integer overflow.
2732 Overflow, signedness and related fixes for images.
2734 * dispextern.h (struct it.stack[0].u.image.image_id)
2735 (struct_it.image_id, struct image.id, struct image_cache.size)
2736 (struct image_cache.used, struct image_cache.ref_count):
2737 * gtkutil.c (update_frame_tool_bar):
2738 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2739 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2740 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2741 * nsmenu.m (update_frame_tool_bar):
2742 * xdisp.c (calc_pixel_width_or_height):
2743 * xfns.c (image_cache_refcount):
2744 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2745 on typical 64-bit hosts.
2747 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2748 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2749 Omit unnecessary casts to int.
2750 (parse_image_spec): Check that integers fall into 'int' range
2751 when the callers expect that.
2752 (image_ascent): Redo ascent calculation to avoid int overflow.
2753 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2754 (lookup_image): Remove unnecessary tests.
2755 (xbm_image_p): Locals are now of int, not EMACS_INT,
2756 since parse_image_check makes sure they fit into int.
2757 (png_load, gif_load, svg_load_image):
2758 Prefer int to unsigned where either will do.
2759 (tiff_handler): New function, combining the cores of the
2760 old tiff_error_handler and tiff_warning_handler.
2761 This function is rewritten to use vsnprintf and thereby avoid
2762 stack buffer overflows. It uses only the features of vsnprintf
2763 that are common to both POSIX and native Microsoft.
2764 (tiff_error_handler, tiff_warning_handler): Use it.
2765 (tiff_load, gif_load, imagemagick_load_image):
2766 Don't assume :index value fits in 'int'.
2767 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2768 (imagemagick_load_image): Check that crop parameters fit into
2769 the integer types that MagickCropImage accepts. Don't assume
2770 Vimagemagick_render_type has a nonnegative value. Don't assume
2771 size_t fits in 'long'.
2772 (gs_load): Use printmax_t to print the widest integers possible.
2773 Check for integer overflow when computing image height and width.
2775 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2777 * xdisp.c (redisplay_window): Don't force window start if point
2778 will be invisible in the resulting window. (Bug#9324)
2780 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2782 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2783 the display spec is of the form `(space ...)'.
2784 (handle_display_spec): Return the value returned by
2785 handle_single_display_spec, not just 1 or zero.
2786 (handle_single_display_spec): If the display spec is of the form
2787 `(space ...)', and specifies display in the text area, return 2
2789 (try_cursor_movement): Check for the need to scroll more
2790 accurately, and prefer exact match for point under bidi.
2791 Don't advance `row' beyond the last row of the window.
2793 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2794 into disp_prop; all users changed.
2796 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2797 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2798 for the text covered by the display property.
2800 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2802 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2803 Change return value to nil.
2804 (Frecord_buffer): Delete unused function.
2806 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2808 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2809 buffers, return left-to-right.
2810 (set_cursor_from_row): Consider candidate row a win if its glyph
2811 represents a newline and point is on that newline. Fixes cursor
2812 positioning on the newline at EOL of R2L text within L2R
2813 paragraph, and vice versa.
2814 (try_cursor_movement): Check continued rows, in addition to
2815 continuation rows. Fixes unwarranted scroll when point enters a
2816 continued line of R2L text within an L2R paragraph, or vice versa.
2817 (cursor_row_p): Consider the case of point being equal to
2818 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2819 from the end of a short line to the beginning of a continued line
2820 of R2L text within L2R paragraph.
2821 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2822 composed characters.
2824 * bidi.c (bidi_check_type): Use xassert.
2825 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2828 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2830 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2833 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2835 * nsfont.m (ns_otf_to_script): Fix typo.
2837 2011-08-22 Kenichi Handa <handa@m17n.org>
2839 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2840 extra slot even if the purpose is char-code-property-table.
2842 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2844 * xdisp.c (redisplay_window): When computing centering_position,
2845 account for the height of the header line. (Bug#8874)
2847 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2848 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2849 candidate is selected by the mouse, and that candidate has a
2850 composed character under the mouse.
2852 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2853 coordinates reported by pos-visible-in-window-p for a composed
2854 character in column zero.
2856 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2858 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2860 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2862 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2863 consider it a hit if to_charpos is anywhere in the range of the
2864 composed buffer positions.
2866 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2868 * image.c (gif_load): Don't assume that each subimage has the same
2869 dimensions as the base image. Handle disposal method that is
2870 "undefined" by the gif spec (Bug#9335).
2872 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2874 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2875 (Fcondition_case): Document `debug' symbol in error handler.
2877 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2879 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2880 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2881 from an Org mode buffer to a Speedbar frame.
2883 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2884 a composition, take its buffer position from IT->cmp_it.charpos.
2885 Fixes cursor positioning at the beginning of a line that begins
2886 with a composed character.
2888 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2890 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2891 character bidirectional type, use STRONG_L instead. Fixes crashes
2892 in a buffer produced by `describe-categories'.
2894 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2895 members before the level stack, so they would be saved and
2896 restored when copying iterator state. Fixes incorrect reordering
2897 around TABs covered by display properties.
2899 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2901 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2903 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2905 * eval.c (internal_condition_case, internal_condition_case_1)
2906 (internal_condition_case_2, internal_condition_case_n):
2907 Remove unnecessary aborts (Bug#9081).
2909 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2911 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2912 has no `load' handler, try opening the file locally. (Bug#9311)
2914 2011-08-16 Ken Brown <kbrown@cornell.edu>
2916 * gmalloc.c: Expand comment.
2918 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2920 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2921 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2923 2011-08-16 Ken Brown <kbrown@cornell.edu>
2925 Fix memory allocation problems in Cygwin build (Bug#9273).
2927 * unexcw.c ( __malloc_initialized): Declare external variable.
2928 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2930 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2932 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2934 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2936 [CYGWIN] (special_realloc): New function.
2937 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2938 requests to realloc storage in the static heap.
2940 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2942 * bidi.c (bidi_initialize): Remove unused local.
2944 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2947 * biditype.h: Remove file.
2948 * makefile.w32-in ($(BLD)/bidi.$(O)):
2949 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2951 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2953 * chartab.c: Improve commentary for the uniprop_table API.
2955 * bidi.c (bidi_paragraph_init): Support zero value of
2956 bidi_ignore_explicit_marks_for_paragraph_level.
2957 (bidi_initialize): Use uniprop_table instead of including
2958 biditype.h and bidimirror.h.
2960 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2961 coordinates of the iterator when restoring from ppos_it.
2964 2011-08-14 Kenichi Handa <handa@m17n.org>
2966 * process.c (create_process): Call setup_process_coding_systems
2967 after the pid of the process is set to -1 (Bug#8162).
2969 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2971 * xdisp.c (move_it_in_display_line_to): Don't invoke
2972 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2973 ppos_it. Fixes vertical cursor motion when line beginning is
2974 covered by an image. (Bug#9296)
2976 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2978 * nsterm.h (ns_run_ascript): Declare.
2979 (NSAPP_DATA2_RUNASSCRIPT): Define.
2981 * nsfns.m (as_script, as_result, as_status): New static variables.
2982 (ns_run_ascript): New function.
2983 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2984 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2985 the event loop. Get status from as_status (Bug#7276).
2987 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2988 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2989 the event loop (Bug#7276).
2991 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2993 * gnutls.c (QCgnutls_bootprop_priority)
2994 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2995 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2996 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2997 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2998 (QCgnutls_bootprop_verify_hostname_error)
2999 (QCgnutls_bootprop_callbacks_verify): Rename from
3000 Qgnutls_bootprop_..., all uses changed.
3002 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3005 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3007 * xfaces.c (Qframe_set_background_mode): Now static.
3008 * dispextern.h (Qframe_set_background_mode): Remove decl.
3010 * process.c (Fnetwork_interface_info): Declare local only if needed.
3012 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3014 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3015 (Fnetwork_interface_list): Allocate in increments of bytes instead
3016 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3017 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3019 (struct ifflag_def): notrailers is smart on OSX.
3020 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3021 Get hardware address with getifaddrs if available.
3023 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3025 * xdisp.c (iterate_out_of_display_property): xassert that
3026 IT->position is set to within IT->object's boundaries. Break from
3027 the loop as soon as EOB is reached; avoids infloops in redisplay
3028 when IT->position is set up wrongly due to some bug.
3029 Set IT->current to match the bidi iterator unconditionally.
3030 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3031 entry. Force push_it to save on the stack the current
3032 buffer/string position, to be restored by pop_it. Fix flags in
3033 the iterator structure wrt the object coming from a display
3034 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3035 properties. (Bug#9284)
3037 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3039 * fontset.c (fontset_get_font_group): Add proper type checks.
3042 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3044 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3045 and LC_VERSION_MIN_MACOSX.
3046 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3047 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3049 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3051 * xdisp.c (forward_to_next_line_start): Allow to use the
3052 no-display-properties-and-no-overlays under bidi display.
3053 Set disp_pos in the bidi iterator to avoid searches for display
3054 properties and overlays.
3056 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3058 * editfns.c (Fset_time_zone_rule): Document relationship with the
3061 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3062 the font entity extracted from the cache (Bug#8109).
3064 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3066 * composite.c (autocmp_chars): Don't reset point. That is done by
3067 restore_point_unwind (Bug#5984).
3069 2011-08-07 Juri Linkov <juri@jurta.org>
3071 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3072 to show the arg `TIME' instead of `TIMEVAL'.
3074 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3076 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3077 display property strides EOL and includes a newline, as in
3078 longlines-mode. (Bug#9254)
3079 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3080 word-wrap under bidirectional display. (Bug#9224)
3082 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3083 is non-zero, even if the data buffer is NULL. Fixes a crash in
3084 vertical-motion with longlines-mode. (Bug#9254)
3086 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3088 * bidi.c <bidi_cache_total_alloc>: Now static.
3089 (bidi_initialize): Initialize bidi_cache_total_alloc.
3091 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3094 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3095 amount allocated this far in `bidi_cache_total_alloc'.
3096 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3097 non-zero, only free the data buffer without restoring the cache
3098 contents. All callers changed.
3100 * dispextern.h (bidi_unshelve_cache): Update prototype.
3102 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3103 (move_it_in_display_line, move_it_to)
3104 (move_it_vertically_backward, move_it_by_lines): Replace the call
3105 to xfree to an equivalent call to bidi_unshelve_cache.
3106 (move_it_in_display_line_to): Fix logic of returning
3107 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3109 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3111 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3112 came from a string character with a `cursor' property. (Bug#9229)
3114 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3116 * Makefile.in (LIB_PTHREAD): New variable.
3117 (LIBES): Add LIB_PTHREAD (Bug#9216).
3119 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3120 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3122 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3124 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3126 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3128 * xterm.c (x_find_topmost_parent): New function.
3129 (x_set_frame_alpha): Find topmost parent window with
3130 x_find_topmost_parent and set the property there also (bug#9181).
3131 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3133 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3135 * callproc.c (Fcall_process): Avoid vfork clobbering
3136 the local vars buffer, coding_systems, current_dir.
3138 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3140 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3142 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3144 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3145 so that it is not optimized away.
3147 * xdisp.c (compute_display_string_pos): Remove unused local.
3149 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3151 Fix slow cursor motion and scrolling in large buffers with
3152 selective display, like Org Mode buffers. (Bug#9218)
3154 * dispextern.h (struct bidi_it): New member disp_prop_p.
3156 * xdisp.c: Remove one-slot cache of display string positions.
3157 (compute_display_string_pos): Accept an additional argument
3158 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3159 for a display string or property. If found, set DISP_PROP_P
3162 * bidi.c (bidi_fetch_char): Accept an additional argument
3163 DISP_PROP_P, and pass it to compute_display_string_pos.
3164 Only handle text covered by a display string if DISP_PROP_P is returned
3165 non-zero. All callers of bidi_fetch_char changed.
3167 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3169 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3171 2010-12-03 Don March <don@ohspite.net>
3173 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3174 last character M-[char] is translated to ESC [char] (bug#7541).
3176 2011-08-02 Kenichi Handa <handa@m17n.org>
3178 * lisp.h (uniprop_table): Extern it.
3180 * chartab.c (uniprop_table): Make it non-static.
3182 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3184 * xdisp.c (forward_to_next_line_start): Accept additional argument
3185 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3187 (reseat_at_next_visible_line_start): Use the bidi iterator state
3188 returned by forward_to_next_line_start to restore the state of
3189 it->bidi_it after backing up to previous newline. (Bug#9212)
3191 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3193 * regex.c (re_comp): Protoize.
3194 (re_exec): Fix return type.
3195 (regexec): Fix type of `ret'. (Bug#9203)
3197 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3199 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3200 This is needed if max-image-size is a floating-point number.
3202 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3204 * print.c (print_object): Print empty symbol as ##.
3206 * lread.c (read1): Read ## as empty symbol.
3208 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3210 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3211 setting frame foreground color (Bug#9175).
3212 (x_set_background_color): Likewise.
3214 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3215 contents (Bug#9176).
3216 (EmacsTooltip -init): Remove bezels and add shadows to
3219 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3220 or scroll bar (Bug#8470).
3222 * nsfont.m (nsfont_open): Remove assignment to voffset and
3223 unnecessary vars hshink, expand, hd, full_height, min_height.
3224 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3226 * nsterm.h (nsfont_info): Remove voffset field.
3228 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3230 Implement strike-through and overline on NextStep (Bug#8863).
3232 * nsfont.m (nsfont_open): Use underline position provided by font,
3233 instead of hard-coded value of 2.
3234 (nsfont_draw): Call ns_draw_text_decoration instead.
3236 * nsterm.h: Add declaration for ns_draw_text_decoration.
3238 * nsterm.m (ns_draw_text_decoration): New function for drawing
3239 underline, overline, and strike-through.
3240 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3241 ns_draw_text_decoration. Change treatment of cursor drawing to
3242 accommodate underlining, etc.
3244 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3246 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3249 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3251 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3252 Without this fix, if a signal arrives just after memory fills up,
3253 'malloc' might be invoked reentrantly.
3255 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3256 In other words, assume that every image size is allowed, on non-X
3257 hosts. This assumption is probably wrong, but it lets Emacs compile.
3259 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3261 * regex.c (re_iswctype): Convert return values to boolean.
3263 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3265 * xdisp.c (compute_display_string_pos): Don't use cached display
3266 string position if the buffer had its restriction changed.
3269 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3271 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3273 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3275 Integer signedness and overflow and related fixes. (Bug#9079)
3277 * bidi.c: Integer size and overflow fixes.
3278 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3279 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3280 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3281 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3282 (bidi_find_other_level_edge):
3283 Use ptrdiff_t instead of EMACS_INT where either will do.
3284 This works better on 32-bit hosts configured --with-wide-int.
3285 (bidi_cache_ensure_space): Check for size-calculation overflow.
3286 Use % rather than repeated addition, for better worst-case speed.
3287 Don't set bidi_cache_size until after xrealloc returns, because it
3289 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3290 (bidi_cache_ensure_space): Also check that the bidi cache size
3291 does not exceed that of the largest Lisp string or buffer. See Eli
3292 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3294 * alloc.c (__malloc_size_t): Remove.
3295 All uses replaced by size_t. See Andreas Schwab's note
3296 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3298 * image.c: Improve checking for integer overflow.
3299 (check_image_size): Assume that f is nonnull, since
3300 it is always nonnull in practice. This is one less thing to
3301 worry about when checking for integer overflow later.
3302 (x_check_image_size): New function, which checks for integer
3303 overflow issues inside X.
3304 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3305 This removes the need for a memory_full check.
3306 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3307 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3308 (xbm_read_bitmap_data): Change locals back to 'int', since
3309 their values must fit in 'int'.
3310 (xpm_load_image, png_load, tiff_load):
3311 Invoke x_create_x_image_and_pixmap earlier,
3312 to avoid much needless work if the image is too large.
3313 (tiff_load): Treat overly large images as if
3314 x_create_x_image_and_pixmap failed, not as malloc failures.
3315 (gs_load): Use x_check_image_size.
3317 * gtkutil.c: Omit integer casts.
3318 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3319 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3321 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3323 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3324 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3325 would wrongly return t on a 64-bit host.
3327 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3328 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3329 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3330 and therefore cause GCC to emit a bogus diagnostic in some cases.
3332 * image.c: Integer signedness and overflow and related fixes.
3333 This is not an exhaustive set of fixes, but it's time to
3334 record what I've got.
3335 (lookup_pixel_color, check_image_size): Remove redundant decls.
3336 (check_image_size): Don't assume that arbitrary EMACS_INT values
3337 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3338 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3339 (tiff_load, imagemagick_load_image):
3340 Check for overflow in size calculations.
3341 (x_create_x_image_and_pixmap): Remove unnecessary test for
3342 xmalloc returning NULL; that can't happen.
3343 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3344 (xpm_color_bucket): Use better integer hashing function.
3345 (xpm_cache_color): Don't possibly over-allocate memory.
3346 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3347 (gif_memory_source):
3348 Use ptrdiff_t, not int or size_t, to record sizes.
3349 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3350 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3351 either works, as we prefer signed integers.
3352 (tiff_read_from_memory, tiff_write_from_memory):
3353 Return tsize_t, not size_t, since that's what the TIFF API wants.
3354 (tiff_read_from_memory): Don't fail simply because the read would
3355 go past EOF; instead, return a short read.
3356 (tiff_load): Omit no-longer-needed casts.
3357 (Fimagemagick_types): Don't assume size fits into 'int'.
3359 Improve hashing quality when configured --with-wide-int.
3360 * fns.c (hash_string): New function, taken from sxhash_string.
3361 Do not discard information about ASCII character case; this
3362 discarding is no longer needed.
3363 (sxhash-string): Use it. Change sig to match it. Caller changed.
3364 * lisp.h: Declare it.
3365 * lread.c (hash_string): Remove, since we now use fns.c's version.
3366 The fns.c version returns a wider integer if --with-wide-int is
3367 specified, so this should help the quality of the hashing a bit.
3369 * emacs.c: Integer overflow minor fix.
3370 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3371 Define only if GNU_LINUX.
3372 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3374 * dispnew.c: Integer signedness and overflow fixes.
3375 Remove unnecessary forward decls, that were a maintenance hassle.
3376 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3378 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3379 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3380 (prepare_desired_row, line_draw_cost):
3381 Use int, not unsigned, where either works.
3382 (save_current_matrix, restore_current_matrix):
3383 Use ptrdiff_t, not size_t, where either works.
3384 (init_display): Check for overflow more accurately, and without
3385 relying on undefined behavior.
3387 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3388 Remove, replacing with the new symbols in lisp.h. All uses changed.
3389 * fileio.c (make_temp_name):
3390 * filelock.c (lock_file_1, lock_file):
3391 * xdisp.c (message_dolog):
3392 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3393 Use pMd etc. instead.
3394 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3395 replacing the pWIDE etc. symbols removed from editfns.c.
3397 * keyboard.h (num_input_events): Now uintmax_t.
3398 This is (very slightly) less likely to mess up due to wraparound.
3401 * buffer.c: Integer signedness fixes.
3402 (alloc_buffer_text, enlarge_buffer_text):
3403 Use ptrdiff_t rather than size_t when either will do, as we prefer
3406 * alloc.c: Integer signedness and overflow fixes.
3407 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3408 (__malloc_size_t): Default to size_t, not to int.
3409 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3410 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3411 Prefer ptrdiff_t to size_t when either would do, as we prefer
3413 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3414 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3415 Now const. Initialize with values that are in range even if char
3417 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3418 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3419 These functions do the right thing with sizes > 2**32.
3420 (check_depth): Now ptrdiff_t, not int.
3421 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3422 Adjust to new way of storing sizes. Check for size overflow bugs
3424 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3425 slightly wrong anyway, as it missed one instance of
3426 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3427 (refill_memory_reserve): Omit needless cast to size_t.
3428 (mark_object_loop_halt): Mark as externally visible.
3430 * xselect.c: Integer signedness and overflow fixes.
3431 (Fx_register_dnd_atom, x_handle_dnd_message):
3432 Use ptrdiff_t, not size_t, since we prefer signed.
3433 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3434 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3435 x_dnd_atoms_size and x_dnd_atoms_length.
3437 * doprnt.c: Prefer signed to unsigned when either works.
3439 * doprnt.c (doprnt):
3441 * xdisp.c (vmessage):
3442 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3443 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3444 prefer signed arithmetic to avoid comparison confusion.
3445 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3446 but is a bit tricky.
3448 Assume freestanding C89 headers, string.h, stdlib.h.
3449 * data.c, doprnt.c, floatfns.c, print.c:
3450 Include float.h unconditionally.
3451 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3452 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3453 * regex.c: Likewise for stddef.h, string.h.
3454 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3455 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3456 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3457 (STDC_HEADERS): Remove obsolete defines.
3458 * sysdep.c: Include limits.h unconditionally.
3460 Assume support for memcmp, memcpy, memmove, memset.
3461 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3462 * regex.c (memcmp, memcpy):
3463 Remove; we assume C89 now.
3465 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3466 (__malloc_safe_bcopy): Remove; no longer needed.
3468 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3469 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3470 well either way, and we prefer signed to unsigned.
3472 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3474 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3475 closes the connection while we're reading (bug#9182).
3477 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3479 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3480 are specified (Bug#9168).
3482 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3484 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3485 Found by GCC static checking and --with-wide-int on a 32-bit host.
3487 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3489 * xdisp.c (compute_display_string_pos): Fix logic of caching
3490 previous display string position. Initialize cached_prev_pos to
3491 -1. Fixes slow-down at the beginning of a buffer.
3493 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3495 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3496 for attrs[LFACE_FONTSET_INDEX].
3498 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3500 * xml.c (parse_region): Remove unused local
3501 that was recently introduced.
3503 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3505 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3506 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3508 * xdisp.c (move_it_in_display_line_to): Record the best matching
3509 position for TO_CHARPOS while scanning the line, and restore it on
3510 exit if none of the characters scanned was an exact match.
3511 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3512 when exact match is impossible due to invisible text, and the
3513 lines are truncated.
3515 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3517 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3520 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3522 Fix a significant slow-down of cursor motion with C-n, C-p,
3523 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3524 auto-repeat under bidi redisplay in fontified buffers.
3525 * xdisp.c (compute_stop_pos_backwards): New function.
3526 (next_element_from_buffer): Call compute_stop_pos_backwards to
3527 find a suitable prev_stop when we find ourselves before
3529 (reseat): Don't look for prev_stop, as that could mean a very long
3531 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3532 <cached_disp_overlay_modiff>: Cache for last found display string
3534 (compute_display_string_pos): Return the cached position if asked
3535 about the same buffer in the same area of character positions, and
3536 the buffer wasn't changed since the time the display string
3537 position was cached.
3539 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3541 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3542 is an integer, which is important for empty lines. (Bug#9149)
3544 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3546 * frame.c (Fmodify_frame_parameters): In tty case, update the
3547 default face if necessary (Bug#4238).
3549 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3551 * editfns.c (Fstring_to_char): No need to explain what a character
3552 is in the docstring (Bug#6576).
3554 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3556 * xml.c (parse_region): Make sure we always return a tree.
3558 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3560 * xml.c (parse_region): If a document contains only comments,
3563 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3565 * xml.c (make_dom): Return comments, too.
3567 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3570 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3571 and the surrounding thread.
3572 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3573 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3574 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3576 * s/openbsd.h (BROKEN_SIGIO): Define.
3577 * unexelf.c (unexec) [__OpenBSD__]:
3578 Don't update the .mdebug section of the Alpha COFF symbol table.
3580 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3582 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3585 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3587 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3588 This fixes some race conditions on the permissions of any newly
3591 * alloc.c (valid_pointer_p): Use pipe, not open.
3592 This fixes some permissions issues when debugging.
3594 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3595 If fchown fails to set both uid and gid, try to set just gid,
3596 as that is sometimes allowed. Adjust the file's mode to eliminate
3597 setuid or setgid bits that are inappropriate if fchown fails.
3599 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3601 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3602 to compare Lisp_Objects.
3603 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3604 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3605 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3607 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3609 * lread.c (read_integer): Unread even EOF character.
3610 (read1): Likewise. Properly record start position of symbol.
3612 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3613 symbol character follows.
3615 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3617 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3618 This works around a problem with the previous change to Fcopy_file.
3619 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3620 and without this change, GCC might complain about discarding
3621 fchown's return value.
3623 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3625 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3627 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3629 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3631 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3633 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3634 it's used from the C level.
3636 * process.c: Use the same condition for POLL_FOR_INPUT in both
3637 keyboard.c and process.c (bug#1858).
3639 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3641 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3642 (Fgnutls_boot): Use it.
3644 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3646 * doc.c (Fsubstitute_command_keys): Revert last change.
3648 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3650 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3651 quotes the next character, and doesn't affect other longer
3652 sequences (bug#8935).
3654 * lread.c (syms_of_lread): Clarify that is isn't only
3655 `eval-buffer' and `eval-defun' that's affected by
3656 `lexical-binding' (bug#8460).
3658 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3660 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3661 bidi redisplay when a line includes both an image and is truncated.
3663 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3665 Fix minor problems found by static checking.
3666 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3667 (elsz): Now a signed constant, not a size_t var. We prefer signed
3668 types to unsigned, to avoid integer comparison confusion. Without
3669 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3670 "cannot optimize loop, the loop counter may overflow", a symptom
3672 * indent.c (Fvertical_motion): Mark locals as initialized.
3673 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3675 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3677 * search.c (Fre_search_backward): Mention `case-fold-search' in
3678 all the re_search_* functions (bug#8138).
3680 * keyboard.c (Fopen_dribble_file): Document when the file is
3683 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3685 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3688 Support bidi reordering of display and overlay strings.
3689 * xdisp.c (compute_display_string_pos)
3690 (compute_display_string_end): Accept additional argument STRING.
3691 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3692 (reseat_to_string): Initialize bidi_it->string.s and
3693 bidi_it->string.schars.
3694 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3695 NULL (avoids a crash in bidi_paragraph_init).
3696 Initialize itb.string.lstring.
3697 (init_iterator): Call bidi_init_it only of a valid
3698 buffer position was specified. Initialize paragraph_embedding to
3700 (reseat_to_string): Initialize the bidi iterator.
3701 (display_string): If we need to ignore text properties of
3702 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3703 original value of -1 will not work with bidi.)
3704 (compute_display_string_pos): First arg is now struct
3705 `text_pos *'; all callers changed. Support display properties on
3707 (compute_display_string_end): Support display properties on Lisp
3709 (init_iterator, reseat_1, reseat_to_string): Initialize the
3710 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3711 when iterating on a string not from display properties).
3712 (compute_display_string_pos, compute_display_string_end):
3713 Fix calculation of the object to scan. Fixes an error when using
3715 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3716 base_level_stop; instead, set base_level_stop to BEGV.
3717 Fixes crashes in vertical-motion.
3718 (next_element_from_buffer): Improve commentary for when
3719 the iterator is before prev_stop.
3720 (init_iterator): Initialize bidi_p from the default value of
3721 bidi-display-reordering, not from buffer-local value. Use the
3722 buffer-local value only if initializing for buffer iteration.
3723 (handle_invisible_prop): Support invisible properties on strings
3724 that are being bidi-reordered.
3725 (set_iterator_to_next): Support bidi reordering of C strings and
3727 (next_element_from_string): Support bidi reordering of Lisp
3729 (handle_stop_backwards): Support Lisp strings as well.
3730 (display_string): Support display of R2L glyph rows.
3731 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3732 (init_iterator): Don't initialize it->bidi_p for strings
3734 (reseat_to_string): Initialize it->bidi_p for strings here.
3735 (next_element_from_string, next_element_from_c_string)
3736 (next_element_from_buffer): Add xassert's for correspondence
3737 between IT's object being iterated and it->bidi_it.string
3739 (face_before_or_after_it_pos): Support bidi iteration.
3740 (next_element_from_c_string): Handle the case of the first string
3741 character that is not the first one in the visual order.
3742 (get_visually_first_element): New function, refactored from common
3743 parts of next_element_from_buffer, next_element_from_string, and
3744 next_element_from_c_string.
3745 (tool_bar_lines_needed, redisplay_tool_bar)
3746 (display_menu_bar): Force left-to-right direction. Add a FIXME
3747 comment for making that be controlled by a user option.
3748 (push_it, pop_it): Save and restore the state of the
3749 bidi iterator. Save and restore the bidi_p flag.
3750 (pop_it): Iterate out of display property for string iteration as
3752 (iterate_out_of_display_property): Support iteration over strings.
3753 (handle_single_display_spec): Set up it->bidi_it for iteration
3754 over a display string, and call bidi_init_it.
3755 (handle_single_display_spec, next_overlay_string)
3756 (get_overlay_strings_1, push_display_prop): Set up the bidi
3757 iterator for displaying display or overlay strings.
3758 (forward_to_next_line_start): Don't use the shortcut if
3760 (back_to_previous_visible_line_start): If handle_display_prop
3761 pushed the iterator stack, restore the internal state of the bidi
3762 iterator by calling bidi_pop_it same number of times.
3763 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3764 and we are bidi-iterating, don't decrement the iterator position;
3765 instead, set the first_elt flag in the bidi iterator, to produce
3767 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3768 (push_display_prop): xassert that we are iterating a buffer.
3769 (push_it, pop_it): Save and restore paragraph_embedding member.
3770 (handle_single_display_spec, next_overlay_string)
3771 (get_overlay_strings_1, reseat_1, reseat_to_string)
3772 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3773 correctly. Don't assume unibyte strings are not bidi-reordered.
3774 (compute_display_string_pos)
3775 (compute_display_string_end): Fix handling the case of C string.
3776 (push_it, pop_it): Save and restore from_disp_prop_p.
3777 (handle_single_display_spec, push_display_prop): Set the
3778 from_disp_prop_p flag.
3779 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3780 (pop_it): Call iterate_out_of_display_property only if we are
3781 popping after iteration over a string that came from a display
3782 property. Fix a typo in popping stretch info. Add an assertion
3783 for verifying that the iterator position is in sync with the bidi
3785 (handle_single_display_spec, get_overlay_strings_1)
3786 (push_display_prop): Fix initialization of paragraph direction for
3787 string when that of the parent object is not yet determined.
3788 (reseat_1): Call bidi_init_it to resync the bidi
3789 iterator with IT's position. (Bug#7616)
3790 (find_row_edges): If ROW->start.pos gives position
3791 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3792 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3793 Reset the from_disp_prop_p flag.
3794 (SAVE_IT, RESTORE_IT): New macros.
3795 (pos_visible_p, face_before_or_after_it_pos)
3796 (back_to_previous_visible_line_start)
3797 (move_it_in_display_line_to, move_it_in_display_line)
3798 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3799 (try_scrolling, redisplay_window, display_line): Use them when
3800 saving a temporary copy of the iterator and restoring it back.
3801 (back_to_previous_visible_line_start, reseat_1)
3802 (init_iterator): Empty the bidi cache "stack".
3803 (move_it_in_display_line_to): If iterator ended up at
3804 EOL, but we never saw any buffer positions smaller than
3805 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3806 motion in bidi-reordered lines.
3807 (move_it_in_display_line_to): Record prev_method and prev_pos
3808 immediately before the call to set_iterator_to_next. Fixes cursor
3809 motion in bidi-reordered lines with stretch glyphs and strings
3810 displayed in margins. (Bug#8133) (Bug#8867)
3811 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3813 (pos_visible_p): Support positions in bidi-reordered lines.
3814 Save and restore bidi cache.
3816 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3817 (bidi_paragraph_info): Delete unused struct.
3818 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3819 (bidi_cache_start): New variable.
3820 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3822 (bidi_cache_fetch_state, bidi_cache_search)
3823 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3824 (bidi_cache_find, bidi_peek_at_next_level)
3825 (bidi_level_of_next_char, bidi_find_other_level_edge)
3826 (bidi_move_to_visually_next): Compare cache index with
3827 bidi_cache_start rather than with zero.
3828 (bidi_fetch_char): Accept new argument STRING; all callers
3829 changed. Support iteration over a string. Support strings with
3830 display properties. Support unibyte strings. Fix the type of
3831 `len' according to what STRING_CHAR_AND_LENGTH expects.
3832 (bidi_paragraph_init, bidi_resolve_explicit_1)
3833 (bidi_resolve_explicit, bidi_resolve_weak)
3834 (bidi_level_of_next_char, bidi_move_to_visually_next):
3835 Support iteration over a string.
3836 (bidi_set_sor_type, bidi_resolve_explicit_1)
3837 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3838 can now be zero (for strings); special values 0 and -1 were
3839 changed to -1 and -2, respectively.
3840 (bidi_char_at_pos): New function.
3841 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3842 Call it instead of FETCH_MULTIBYTE_CHAR.
3843 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3844 initialized to valid values.
3845 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3847 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3848 the test for valid cached positions. Fix the logic for looking up
3849 the sentinel state in the cache. GCPRO the Lisp string we are
3851 (bidi_push_it, bidi_pop_it): New functions.
3852 (bidi_initialize): Initialize the bidi cache start stack pointer.
3853 (bidi_cache_ensure_space): New function, refactored from part of
3854 bidi_cache_iterator_state. Don't assume the required size is just
3855 one BIDI_CACHE_CHUNK away.
3856 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3857 (bidi_count_bytes, bidi_char_at_pos): New functions.
3858 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3859 always valid if bidi_cache_idx is valid.
3860 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3861 is valid if it's going to be used.
3862 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3863 (bidi_cache_fetch_state, bidi_cache_search)
3864 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3865 (bidi_cache_iterator_state, bidi_cache_find)
3866 (bidi_find_other_level_edge, bidi_cache_start_stack):
3867 All variables related to cache indices are now EMACS_INT.
3869 * dispextern.h (struct bidi_string_data): New structure.
3870 (struct bidi_it): New member `string'. Make flag members be 1-bit
3871 fields, and put them last in the struct.
3872 (compute_display_string_pos, compute_display_string_end):
3874 (bidi_push_it, bidi_pop_it): Add prototypes.
3875 (struct iterator_stack_entry): New members bidi_p,
3876 paragraph_embedding, and from_disp_prop_p.
3877 (struct it): Member bidi_p is now a bit field 1 bit wide.
3878 (bidi_shelve_cache, bidi_unshelve_cache):
3881 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3882 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3883 and vector-like objects.
3885 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3886 cache around display iteration.
3888 * window.c (Fwindow_end, window_scroll_pixel_based)
3889 (displayed_window_lines, Frecenter): Save and restore the bidi
3890 cache around display iteration.
3892 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3894 * editfns.c (Fdelete_region): Clarify the use of the named
3895 parameters (bug#6788).
3897 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3899 * indent.c (Fvertical_motion): Set and restore w->pointm when
3900 saving and restoring the window's buffer (Bug#9006).
3902 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3904 * editfns.c (Fstring_to_char): Clarify just what is returned
3905 (bug#6576). Text by Eli Zaretskii.
3907 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3909 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3911 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3913 * buffer.c (mmap_find): Fix a typo.
3915 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3917 Fix execution of x selection hooks.
3918 * xselect.c (Qx_lost_selection_functions)
3919 (Qx_sent_selection_functions): New vars.
3920 (syms_of_xselect): DEFSYM them.
3921 (x_handle_selection_request): Pass Qx_sent_selection_functions
3922 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3923 (x_handle_selection_clear,x_clear_frame_selections):
3924 Pass Qx_lost_selection_functions rather than
3925 Vx_lost_selection_functions to Frun_hook_with_args.
3927 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3929 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3930 The old code sometimes used this field without initializing it.
3932 * alloc.c (gc_sweep): Don't read past end of array.
3933 In theory, the old code could also have corrupted Emacs internals,
3934 though it'd be very unlikely.
3936 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3938 * character.c (Fcharacterp): Don't advertise optional ignored
3939 argument. (Bug#4026)
3941 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3943 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3946 * window.c (Fset_window_start): Doc fix (bug#4199).
3947 (Fset_window_hscroll): Ditto.
3949 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3951 Fix minor new problems caught by GCC 4.6.1.
3952 * term.c (init_tty): Remove unused local.
3953 * xsettings.c (store_monospaced_changed): Define this function only
3954 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3957 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3959 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3961 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3963 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3964 are the mini-buffer and the echo area (bug#3320).
3966 * term.c (init_tty): Remove support for supdup, c10 and perq
3967 terminals, which are no longer supported (bug#1482).
3969 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3971 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3973 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3975 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3976 for non-popups (Bug#3642).
3978 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3980 * alloc.c (reset_malloc_hooks): Protoize.
3981 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3982 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3983 * cm.c (losecursor): Likewise.
3984 * data.c (fmod): Likewise.
3985 * dispnew.c (swap_glyphs_in_rows): Likewise.
3986 * emacs.c (memory_warning_signal): Likewise.
3987 * floatfns.c (float_error): Likewise.
3988 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3989 (otf_open, font_otf_capability, generate_otf_features)
3990 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3992 * image.c (pbm_read_file): Likewise.
3993 * indent.c (string_display_width): Likewise.
3994 * intervals.c (check_for_interval, search_for_interval)
3995 (inc_interval_count, count_intervals, root_interval)
3996 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3997 * lread.c (defalias): Likewise.
3998 * ralloc.c (r_alloc_check): Likewise.
3999 * regex.c (set_image_of_range_1, set_image_of_range)
4000 (regex_grow_registers): Likewise.
4001 * sysdep.c (strerror): Likewise.
4002 * termcap.c (valid_filename_p, tprint, main): Likewise.
4003 * tparam.c (main): Likewise.
4004 * unexhp9k800.c (run_time_remap, save_data_space)
4005 (update_file_ptrs, read_header, write_header, calculate_checksum)
4006 (copy_file, copy_rest, display_header): Likewise.
4007 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4009 * xdisp.c (check_it): Likewise.
4010 * xfaces.c (register_color, unregister_color, unregister_colors):
4012 * xfns.c (print_fontset_result): Likewise.
4013 * xrdb.c (member, fatal, main): Likewise.
4015 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4017 Fix minor problems found by static checking (Bug#9031).
4018 * chartab.c (char_table_set_range, map_sub_char_table):
4019 Remove unused locals.
4020 (uniprop_table): Now static.
4021 * composite.c (_work_char): Remove unused static var.
4023 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4025 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4027 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4029 * gtkutil.c (qttip_cb): Remove code without function.
4031 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4033 * w32.c (pthread_sigmask): New stub.
4035 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4037 Use pthread_sigmask, not sigprocmask (Bug#9010).
4038 sigprocmask is portable only for single-threaded applications, and
4039 Emacs can be multi-threaded when it uses GTK.
4040 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4042 * callproc.c (Fcall_process):
4043 * process.c (create_process):
4044 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4045 Use pthread_sigmask, not sigprocmask.
4047 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4049 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4050 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4053 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4055 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4056 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4057 (xg_hide_tooltip): Fix comment.
4059 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4060 in registerServicesMenuSendTypes.
4061 (validRequestorForSendType): Don't check ns_return_types.
4063 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4066 2011-07-08 Jason Rumney <jasonr@gnu.org>
4068 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4069 SH_SHOW for hidden windows (Bug#5482).
4071 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4072 frame struct members of non-existent frames (Bug#6284).
4074 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4076 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4077 variable firstTime not needed on OSX >= 10.6.
4078 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4079 >= 10.5. Use setKnobProportion, setDoubleValue.
4081 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4082 (MAC_OS_X_VERSION_10_5): Define if not defined.
4083 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4084 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4085 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4087 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4088 cString and lossyCString on OSX >= 10.4
4090 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4091 sizeToFit on OSX >= 10.2.
4093 * nsimage.m (allocInitFromFile): Don't use deprecated method
4094 bestRepresentationForDevice on OSX >= 10.6.
4096 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4099 * emacs.c: Declare unexec_init_emacs_zone.
4101 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4103 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4105 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4106 on svcsMenu (Bug#8842).
4108 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4110 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4112 * nsterm.m (QUTF8_STRING): Declare.
4113 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4114 (validRequestorForSendType): Return type is (id).
4115 Change indexOfObjectIdenticalTo to indexOfObject.
4116 Check if we have local selection before returning self (Bug#8842).
4117 (writeSelectionToPasteboard): Put local selection into paste board
4118 if we have a local selection (Bug#8842).
4119 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4121 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4122 (ns_get_local_selection): Declare.
4124 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4126 * keymap.c (describe_map_tree): Don't insert a double newline at
4127 the end of the buffer (bug#1169) and return whether we inserted
4130 * callint.c (Fcall_interactively): Change "reading args" to
4131 "providing args" to try to clarify what it does (bug#1010).
4133 2011-07-07 Kenichi Handa <handa@m17n.org>
4135 * composite.c (composition_compute_stop_pos): Ignore a static
4136 composition starting before CHARPOS (Bug#8915).
4138 * xdisp.c (handle_composition_prop): Likewise.
4140 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4142 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4145 2011-07-07 Kenichi Handa <handa@m17n.org>
4147 * character.h (unicode_category_t): New enum type.
4149 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4150 (Qchar_code_property_table): New variable.
4151 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4152 (UNIPROP_COMPRESSED_FORM_P): New macros.
4153 (char_table_ascii): Uncompress the compressed values.
4154 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4155 Uncompress the compressed values.
4156 (sub_char_table_ref_and_range): Likewise.
4157 (char_table_ref_and_range): Uncompress the compressed values.
4158 (sub_char_table_set): New arg is_uniprop. Callers changed.
4159 Uncompress the compressed values.
4160 (sub_char_table_set_range): Args changed. Callers changed.
4161 (char_table_set_range): Adjuted for the above change.
4162 (map_sub_char_table): Delete args default_val and parent. Add arg
4163 top. Give decoded values to a Lisp function.
4164 (map_char_table): Adjust for the above change. Give decoded
4165 values to a Lisp function. Gcpro more variables.
4166 (uniprop_table_uncompress)
4167 (uniprop_decode_value_run_length): New functions.
4168 (uniprop_decoder, uniprop_decoder_count): New variables.
4169 (uniprop_get_decoder, uniprop_encode_value_character)
4170 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4172 (uniprop_encoder, uniprop_encoder_count): New variables.
4173 (uniprop_get_encoder, uniprop_table)
4174 (Funicode_property_table_internal, Fget_unicode_property_internal)
4175 (Fput_unicode_property_internal): New functions.
4176 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4177 Sunicode_property_table_internal, Sget_unicode_property_internal,
4178 and Sput_unicode_property_internal. Defvar_lisp
4179 char-code-property-alist.
4181 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4182 Vunicode_category_table.
4184 * font.c (font_range): Adjust for the change of
4185 Vunicode_category_table.
4187 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4189 * m/iris4d.h: Remove file, move contents ...
4190 * s/irix6-5.h: ... here.
4192 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4194 Remove unportable assumption about struct layout (Bug#8884).
4195 * alloc.c (mark_buffer):
4196 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4197 (clone_per_buffer_values): Don't assume that
4198 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4199 This isn't true in general, and it's particularly not true
4200 if Emacs is configured with --with-wide-int.
4201 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4202 New macros, used in the buffer.c change.
4204 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4206 * xsettings.c: Use both GConf and GSettings if both are available.
4207 (store_config_changed_event): Add comment.
4208 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4209 (store_tool_bar_style_changed): New functions.
4210 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4211 (struct xsettings): Move font inside HAVE_XFT.
4212 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4213 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4214 Move inside HAVE_XFT.
4215 (something_changed_gsettingsCB): Rename from something_changedCB.
4216 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4218 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4219 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4220 (something_changed_gconfCB): Rename from something_changedCB.
4221 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4222 (parse_settings): Move check for font inside HAVE_XFT.
4223 (read_settings, apply_xft_settings): Add comment.
4224 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4225 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4226 call store_font_name_changed.
4227 (xft_settings_event): Add comment.
4228 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4229 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4230 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4231 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4232 (xsettings_initialize): Call init_gsettings last.
4233 (xsettings_get_system_font, xsettings_get_system_normal_font):
4236 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4238 Random fixes. E.g., (random) never returned negative values.
4239 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4240 subseconds part to the entropy, as that's a bit more random.
4241 Prefer signed to unsigned, since the signedness doesn't matter and
4242 in general we prefer signed. When given a limit, use a
4243 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4244 latter isn't right if USE_2_TAGS_FOR_INTS.
4245 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4246 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4248 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4250 * textprop.c (text_property_stickiness):
4251 Obey Vtext_property_default_nonsticky.
4252 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4253 * w32fns.c (syms_of_w32fns):
4254 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4256 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4258 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4259 This is more efficient than Ffile_directory_p and avoids a minor race.
4261 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4263 * buffer.c (Foverlay_put): Say what the return value is
4266 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4267 is a directory before asking whether to use the file name
4269 (barf_or_query_if_file_exists): Make the "File is a directory"
4270 error be more correct.
4272 * fns.c (Frequire): Remove the mention of the .gz files, since
4273 that's installation-specific, but keep the mention of
4274 `get-load-suffixes'.
4276 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4278 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4279 Report string overflow if the output is too long.
4281 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4283 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4284 (syms_of_gnutls): Remove duplicate DEFSYM for
4285 Qgnutls_bootprop_verify_hostname_error, an error for
4286 Qgnutls_bootprop_verify_error (which is no longer used).
4288 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4289 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4290 Also (re)move comments that are misplaced or no longer relevant.
4292 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4294 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4296 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4298 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4299 and background color parameters if they have been changed.
4301 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4303 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4305 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4307 * xsettings.c (SYSTEM_FONT): Define only when used.
4308 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4310 * keymap.c (access_keymap_1): Now static.
4312 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4314 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4315 leave any prefix arg for the up event (Bug#1586).
4317 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4319 * lread.c (syms_of_lread): Mention single symbols defined by
4320 `defvar' or `defconst' (bug#7154).
4322 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4323 (Frequire): Mention get-load-suffixes.
4325 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4327 * window.h (window): Remove clone_number slot.
4328 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4330 (make_parent_window, make_window, saved_window)
4331 (Fset_window_configuration, save_window_save): Don't deal with
4333 * buffer.c (Qclone_number): Remove declaration.
4334 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4336 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4338 Add multiple inheritance to keymaps.
4339 * keymap.c (Fmake_composed_keymap): New function.
4340 (Fset_keymap_parent): Simplify.
4341 (fix_submap_inheritance): Remove.
4342 (access_keymap_1): New function extracted from access_keymap to handle
4343 embedded parents and handle lists of maps.
4344 (access_keymap): Use it.
4345 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4346 (Fcopy_keymap): Handle embedded parents.
4347 (Fcommand_remapping, define_as_prefix): Simplify.
4348 (Fkey_binding): Simplify.
4349 (syms_of_keymap): Move minibuffer-local-completion-map,
4350 minibuffer-local-filename-completion-map,
4351 minibuffer-local-must-match-map, and
4352 minibuffer-local-filename-must-match-map to Elisp.
4353 (syms_of_keymap): Defsubr make-composed-keymap.
4354 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4355 (parse_menu_item): Trivial simplification.
4357 2011-07-01 Glenn Morris <rgm@gnu.org>
4359 * Makefile.in (SETTINGS_LIBS): Fix typo.
4361 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4363 * coding.c (Fencode_coding_string): Record the last coding system
4364 used, as the function doc string says (bug#8738).
4366 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4368 * xsettings.c (store_monospaced_changed): Take new font as arg and
4369 check for change against current_mono_font.
4370 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4371 (emacs_settings_constructor, emacs_settings_get_property)
4372 (emacs_settings_set_property, emacs_settings_class_init)
4373 (emacs_settings_init, gsettings_obj): Remove.
4374 (something_changedCB): New function for HAVE_GSETTINGS.
4375 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4376 with value as argument.
4377 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4378 g_settings_new (Bug#8967). Do not create gsettings_obj.
4379 Remove calls to g_settings_bind. Connect something_changedCB to
4382 * xgselect.c: Add defined (HAVE_GSETTINGS).
4383 (xgselect_initialize): Ditto.
4385 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4386 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4389 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4391 * eval.c (struct backtrace): Simplify and port the data structure.
4392 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4393 signed bit field, as this assumption is not portable and it makes
4394 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4395 "char debug_on_exit : 1" as this is not portable either; instead,
4396 use the portable "unsigned int debug_on_exit : 1". Remove unused
4397 member evalargs. Remove obsolete comments about cc bombing out.
4399 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4401 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4402 Let HAVE_GSETTINGS override HAVE_GCONF.
4403 (store_monospaced_changed): New function.
4404 (EMACS_SETTINGS): A new type derived from GObject to handle
4405 GSettings notifications.
4406 (emacs_settings_constructor, emacs_settings_get_property)
4407 (emacs_settings_set_property, emacs_settings_class_init):
4409 (gsettings_client, gsettings_obj): New variables.
4410 (GSETTINGS_SCHEMA): New define.
4411 (something_changedCB): Call store_monospaced_changed.
4412 (init_gsettings): New function.
4413 (xsettings_initialize): Call init_gsettings.
4414 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4417 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4420 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4422 * window.c (resize_root_window, grow_mini_window)
4423 (shrink_mini_window): Rename Qresize_root_window to
4424 Qwindow_resize_root_window and Qresize_root_window_vertically to
4425 Qwindow_resize_root_window_vertically.
4427 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4429 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4431 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4433 * makefile.w32-in: Redesign dependencies so they reflect more
4434 clearly which files are directly included by each source file,
4435 and not through other includes.
4437 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4439 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4440 (sort_overlays, overlay_strings): When an overlay's clone number
4441 matches the window's clone number process the overlay even if
4442 the overlay's window property doesn't match the current window.
4444 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4445 (Fwindow_hchild): Rename to Fwindow_left_child.
4446 (Fwindow_next): Rename to Fwindow_next_sibling.
4447 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4448 (resize_window_check): Rename to window_resize_check.
4449 (resize_window_apply): Rename to window_resize_apply.
4450 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4451 (Fdelete_other_windows_internal, resize_frame_windows)
4452 (Fsplit_window_internal, Fdelete_window_internal)
4453 (grow_mini_window, shrink_mini_window)
4454 (Fresize_mini_window_internal): Fix callers accordingly.
4456 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4458 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4459 (emacs_fixed_set_min_size): Remove.
4460 (emacs_fixed_new): Take frame as argument.
4462 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4463 (_EmacsFixedPrivate): Remove minwidth/height.
4464 Add struct frame *f.
4465 (emacs_fixed_init): Initialize priv->f.
4466 (get_parent_class, emacs_fixed_set_min_size): Remove.
4467 (emacs_fixed_new): Set priv->f to argument.
4468 (emacs_fixed_get_preferred_width)
4469 (emacs_fixed_get_preferred_height): Use min_width/height from
4470 frames size_hint to set minimum and natural (Bug#8919).
4471 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4472 and use min_width/height from frames size_hint to set
4473 min_width/height (Bug#8919).
4475 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4476 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4479 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4481 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4482 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4485 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4487 * process.c (wait_reading_process_output): Bypass select if
4488 waiting for a cell while ignoring keyboard input, and input is
4489 pending. Suggested by Jan Djärv (Bug#8869).
4491 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4493 Use gnulib's dup2 module instead of rolling our own.
4494 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4496 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4498 * dispnew.c (scrolling_window): Before scrolling, turn off a
4499 mouse-highlight in the window being scrolled.
4501 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4503 Move DEFSYM to lisp.h and use everywhere.
4505 * character.h (DEFSYM): Move declaration...
4506 * lisp.h (DEFSYM): ...here.
4512 * w32select.c: Don't include character.h.
4514 * alloc.c (syms_of_alloc):
4515 * buffer.c (syms_of_buffer):
4516 * bytecode.c (syms_of_bytecode):
4517 * callint.c (syms_of_callint):
4518 * casefiddle.c (syms_of_casefiddle):
4519 * casetab.c (init_casetab_once):
4520 * category.c (init_category_once, syms_of_category):
4521 * ccl.c (syms_of_ccl):
4522 * cmds.c (syms_of_cmds):
4523 * composite.c (syms_of_composite):
4524 * dbusbind.c (syms_of_dbusbind):
4525 * dired.c (syms_of_dired):
4526 * dispnew.c (syms_of_display):
4527 * doc.c (syms_of_doc):
4528 * editfns.c (syms_of_editfns):
4529 * emacs.c (syms_of_emacs):
4530 * eval.c (syms_of_eval):
4531 * fileio.c (syms_of_fileio):
4532 * fns.c (syms_of_fns):
4533 * frame.c (syms_of_frame):
4534 * fringe.c (syms_of_fringe):
4535 * insdel.c (syms_of_insdel):
4536 * keymap.c (syms_of_keymap):
4537 * lread.c (init_obarray, syms_of_lread):
4538 * macros.c (syms_of_macros):
4539 * msdos.c (syms_of_msdos):
4540 * print.c (syms_of_print):
4541 * process.c (syms_of_process):
4542 * search.c (syms_of_search):
4543 * sound.c (syms_of_sound):
4544 * syntax.c (init_syntax_once, syms_of_syntax):
4545 * terminal.c (syms_of_terminal):
4546 * textprop.c (syms_of_textprop):
4547 * undo.c (syms_of_undo):
4548 * w32.c (globals_of_w32):
4549 * window.c (syms_of_window):
4550 * xdisp.c (syms_of_xdisp):
4551 * xfaces.c (syms_of_xfaces):
4552 * xfns.c (syms_of_xfns):
4553 * xmenu.c (syms_of_xmenu):
4554 * xsettings.c (syms_of_xsettings):
4555 * xterm.c (syms_of_xterm): Use DEFSYM.
4557 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4559 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4561 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4563 Integer and buffer overflow fixes (Bug#8873).
4565 * print.c (printchar, strout): Check for string overflow.
4566 (PRINTPREPARE, printchar, strout):
4567 Don't set size unless allocation succeeds.
4569 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4570 for sizes. Check for string overflow more accurately.
4571 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4573 * macros.c: Integer and buffer overflow fixes.
4574 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4575 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4576 Use ptrdiff_t, not int, for sizes.
4577 Don't increment bufsize until after realloc succeeds.
4578 Check for size-calculation overflow.
4579 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4581 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4583 * lread.c: Integer overflow fixes.
4584 (read_integer): Radix is now EMACS_INT, not int,
4585 to improve quality of diagnostics for out-of-range radices.
4586 Calculate buffer size correctly for out-of-range radices.
4587 (read1): Check for integer overflow in radices, and in
4588 read-circle numbers.
4589 (read_escape): Avoid int overflow.
4590 (Fload, openp, read_buffer_size, read1)
4591 (substitute_object_recurse, read_vector, read_list, map_obarray):
4592 Use ptrdiff_t, not int, for sizes.
4593 (read1): Use EMACS_INT, not int, for sizes.
4594 Check for size overflow.
4596 * image.c (cache_image): Check for size arithmetic overflow.
4598 * lread.c: Integer overflow issues.
4599 (saved_doc_string_size, saved_doc_string_length)
4600 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4601 Now ptrdiff_t, not int.
4602 (read1): Don't assume doc string length fits in int. Check for
4603 out-of-range doc string lengths.
4604 (read_list): Don't assume file position fits in int.
4605 (read_escape): Check for hex character overflow.
4607 2011-06-22 Leo Liu <sdl.web@gmail.com>
4609 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4610 Move to minibuffer.el.
4612 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4614 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4615 The following patches are for when GLYPH_DEBUG && !XASSERT.
4616 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4617 * dispnew.c (flush_stdout):
4618 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4619 Mark as externally visible.
4620 * dispnew.c (check_window_matrix_pointers): Now static.
4621 * dispnew.c (window_to_frame_vpos):
4622 * xfns.c (unwind_create_frame):
4623 * xterm.c (x_check_font): Remove unused local.
4624 * scroll.c (CHECK_BOUNDS):
4625 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4626 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4627 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4628 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4629 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4631 (debug_method_add): Use va_list and vsprintf rather than relying
4632 on undefined behavior with wrong number of arguments.
4633 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4634 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4635 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4636 since we're not interested in debugging glyphs with old libraries.
4637 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4638 GCC 4.6.0's static checking.
4640 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4642 Integer overflow and signedness fixes (Bug#8873).
4643 A few related buffer overrun fixes, too.
4645 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4647 * dispextern.h (struct face.stipple):
4648 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4649 (x_bitmap_mask, x_allocate_bitmap_record)
4650 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4651 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4652 (x_create_bitmap_from_xpm_data):
4653 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4654 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4656 * xfaces.c (load_pixmap):
4657 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4658 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4659 (.bitmaps_last, struct x_output.icon_bitmap):
4660 Use ptrdiff_t, not int, for bitmap indexes.
4661 (x_allocate_bitmap_record): Check for size overflow.
4662 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4664 Use ptrdiff_t, not int, for overlay counts.
4665 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4666 * editfns.c (overlays_around, get_pos_property):
4667 * textprop.c (get_char_property_and_overlay):
4668 * xdisp.c (next_overlay_change, note_mouse_highlight):
4669 * xfaces.c (face_at_buffer_position):
4670 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4671 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4672 (Fnext_overlay_change, Fprevious_overlay_change)
4673 (mouse_face_overlay_overlaps, Foverlays_in):
4674 Use ptrdiff_t, not int, for sizes.
4675 (overlays_at, overlays_in): Check for size-calculation overflow.
4677 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4679 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4680 (x_session_initialize): Do not assume string length fits in int.
4682 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4683 This is unlikely, but can occur if DPI is outlandish.
4685 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4686 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4688 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4689 * xrdb.c (magic_file_p, search_magic_path):
4690 Omit last arg SUFFIX; it was always 0. All callers changed.
4691 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4693 * xfont.c (xfont_match): Avoid need for strlen.
4695 * xfns.c: Don't assume strlen fits in int.
4696 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4698 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4699 not unsigned long, as we prefer signed integers. All callers changed.
4700 Detect integer overflow in repeat count.
4701 (message_dolog): Don't assume print length fits in 39 bytes.
4702 (display_mode_element): Don't assume strlen fits in int.
4704 * termcap.c: Don't assume sizes fit in int and never overflow.
4705 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4706 (gobble_line): Check for size-calculation overflow.
4708 * minibuf.c (Fread_buffer):
4709 * lread.c (intern, intern_c_string):
4710 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4711 Don't assume string length fits in int.
4713 * keyboard.c (parse_tool_bar_item):
4714 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4716 * font.c: Don't assume string length fits in int.
4717 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4718 Use ptrdiff_t, not int.
4719 (font_intern_prop): Don't assume string length fits in int.
4720 Don't assume integer property fits in fixnum.
4721 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4723 * filelock.c: Fix some buffer overrun and integer overflow issues.
4724 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4725 Reformulate so as not to need the command string.
4726 Invoke gzip -cd rather than gunzip, as it's more portable.
4727 (lock_info_type, lock_file_1, lock_file):
4728 Don't assume pid_t and time_t fit in unsigned long.
4729 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4730 (current_lock_owner): Prefer signed type for sizes.
4731 Use memcpy, not strncpy, where memcpy is what is really wanted.
4732 Don't assume (via atoi) that time_t and pid_t fit in int.
4733 Check for time_t and/or pid_t out of range, e.g., via a network share.
4734 Don't alloca where an auto var works fine.
4736 * fileio.c: Fix some integer overflow issues.
4737 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4738 Don't assume string length fits in int.
4739 (directory_file_name): Don't assume string length fits in long.
4740 (make_temp_name): Don't assume pid fits in int, or that its print
4741 length is less than 20.
4743 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4745 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4747 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4749 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4750 We prefer signed integers, even for size calculations.
4752 * emacs.c: Don't assume string length fits in 'int'.
4753 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4754 (main): Don't invoke strlen when not needed.
4756 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4757 (XD_DEBUG_MESSAGE): Don't waste a byte.
4759 * callproc.c (getenv_internal_1, getenv_internal)
4761 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4763 * lread.c (invalid_syntax): Omit length argument.
4764 All uses changed. This doesn't fix a bug, but it simplifies the
4765 code away from its former Hollerith-constant appearance, and it's
4766 one less 'int' to worry about when looking at integer-overflow issues.
4767 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4769 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4770 This didn't break anything, but it didn't help either.
4771 It's confusing to put a bogus integer in a place where the actual
4772 value does not matter.
4773 (LIST_END_P): Remove unused macro and its bogus comment.
4774 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4776 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4777 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4779 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4780 We prefer signed types, and the value cannot exceed the EMACS_INT
4781 range anyway (because otherwise the length would not be representable).
4782 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4783 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4784 This avoids a GCC warning when WIDE_EMACS_INT.
4786 * indent.c (sane_tab_width): New function.
4787 (current_column, scan_for_column, Findent_to, position_indentation)
4788 (compute_motion): Use it. This is just for clarity.
4789 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4791 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4793 * lisp.h (lint_assume): New macro.
4794 * composite.c (composition_gstring_put_cache):
4795 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4797 * editfns.c, insdel.c:
4798 Omit unnecessary forward decls, to simplify future changes.
4800 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4802 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4804 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4805 Use much-faster test for byte-length change.
4806 Don't assume string byte-length fits in 'int'.
4807 Check that character arg fits in 'int'.
4808 (mapcar1): Declare byte as byte, for clarity.
4810 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4812 * fns.c (concat): Catch string overflow earlier.
4813 Do not rely on integer wraparound.
4815 * dispextern.h (struct it.overlay_strings_charpos)
4816 (struct it.selective): Now EMACS_INT, not int.
4817 * xdisp.c (forward_to_next_line_start)
4818 (back_to_previous_visible_line_start)
4819 (reseat_at_next_visible_line_start, next_element_from_buffer):
4820 Don't arbitrarily truncate the value of 'selective' to int.
4822 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4824 * composite.c: Don't truncate sizes to 'int'.
4825 (composition_gstring_p, composition_reseat_it)
4826 (composition_adjust_point): Use EMACS_INT, not int.
4827 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4828 not EMACS_UINT, for indexes.
4830 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4832 * buffer.c: Include <verify.h>.
4833 (struct sortvec.priority, struct sortstr.priority):
4834 Now EMACS_INT, not int.
4835 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4836 (struct sortstr.size, record_overlay_string)
4837 (struct sortstrlist.size, struct sortlist.used):
4838 Don't truncate size to int.
4839 (record_overlay_string): Check for size-calculation overflow.
4840 (init_buffer_once): Check at compile-time, not run-time.
4842 2011-06-22 Jim Meyering <meyering@redhat.com>
4844 Don't leak an XBM-image-sized buffer
4845 * image.c (xbm_load): Free the image buffer after using it.
4847 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4850 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4851 that Sun C diagnosed.
4852 * fns.c (secure_hash): Fix pointer signedness issue.
4853 * intervals.c (static_offset_intervals): New function.
4854 (offset_intervals): Use it.
4856 2011-06-21 Leo Liu <sdl.web@gmail.com>
4859 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4862 * fns.c (secure_hash): Rename from crypto_hash_function and change
4863 the first arg to accept symbols.
4864 (Fsecure_hash): New primitive.
4865 (syms_of_fns): New symbols.
4867 2011-06-20 Deniz Dogan <deniz@dogan.se>
4869 * process.c (Fset_process_buffer): Clarify return value in
4872 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4874 * dispnew.c (add_window_display_history): Use BVAR.
4876 * xdisp.c (debug_method_add): Use BVAR.
4877 (check_window_end, dump_glyph_matrix, dump_glyph)
4878 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4880 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4883 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4884 check till after the cache is created in init_frame_faces.
4886 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4888 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4890 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4892 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4893 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4894 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4896 Improve buffer-overflow checking (Bug#8873).
4897 * fileio.c (Finsert_file_contents):
4898 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4899 Remove the old (too-loose) buffer overflow checks.
4900 They weren't needed, since make_gap checks for buffer overflow.
4901 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4902 The old code merely checked for Emacs fixnum overflow, and relied
4903 on undefined (wraparound) behavior. The new code avoids undefined
4904 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4906 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4907 Tune. Don't use wider integers than needed. Don't use alloca.
4908 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4910 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4912 * insdel.c, lisp.h (buffer_overflow): New function.
4913 (insert_from_buffer_1, replace_range, replace_range_2):
4914 * insdel.c (make_gap_larger):
4915 * editfns.c (Finsert_char):
4916 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4918 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4920 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4922 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4924 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4925 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4927 * fileio.c: Don't assume EMACS_INT fits in off_t.
4928 (emacs_lseek): New static function.
4929 (Finsert_file_contents, Fwrite_region): Use it.
4930 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4932 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4934 * fns.c: Don't overflow int when computing a list length.
4935 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4936 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4937 truncation on 64-bit hosts. Check for QUIT every
4938 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4939 faster and is responsive enough.
4940 (Flength): Report an error instead of overflowing an integer.
4941 (Fsafe_length): Return a float if the value is not representable
4942 as a fixnum. This shouldn't happen except in contrived situations.
4943 (Fnthcdr, Fsort): Don't assume list length fits in int.
4944 (Fcopy_sequence): Don't assume vector length fits in int.
4946 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4947 (header_size, word_size): New constants.
4948 (allocate_vectorlike): Don't check size overflow here.
4949 (allocate_vector): Check it here instead, since this is the only
4950 caller of allocate_vectorlike that could cause overflow.
4951 Check that the new vector's length is representable as a fixnum.
4953 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4954 The previous code was bogus. For example, next_almost_prime (32)
4955 returned 39, which is undesirable as it is a multiple of 3; and
4956 next_almost_prime (24) returned 25, which is a multiple of 5 so
4957 why was the code bothering to check for multiples of 7?
4959 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4961 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4963 Variadic C functions now count arguments with ptrdiff_t.
4964 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4965 Back then I didn't know that the Emacs coding style prefers signed int.
4966 Also, in the meantime I found a few more instances where arguments
4967 were being counted with int, which may truncate counts on 64-bit
4968 machines, or EMACS_INT, which may be unnecessarily wide.
4969 * lisp.h (struct Lisp_Subr.function.aMANY)
4970 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4971 Arg counts are now ptrdiff_t, not size_t.
4972 All variadic functions and their callers changed accordingly.
4973 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4974 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4975 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4976 * callint.c (Fcall_interactively): Check arg count for overflow,
4977 to avoid potential buffer overrun. Use signed char, not 'int',
4978 for 'varies' array, so that we needn't bother to check its size
4979 calculation for overflow.
4980 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4981 * eval.c (apply_lambda):
4982 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4983 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4984 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4986 * callint.c (Fcall_interactively): Don't use index var as event count.
4988 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4989 * mem-limits.h (SIZE): Remove; no longer used.
4991 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4993 Remove unnecessary casts.
4994 * xterm.c (x_term_init):
4995 * xfns.c (x_set_border_pixel):
4996 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4997 These aren't needed now that we assume ANSI C.
4999 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5000 It's more likely to cause problems (due to unsigned overflow)
5003 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5005 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5007 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5009 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5011 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5013 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5015 GLYPH_CODE_FACE returns EMACS_INT, not int.
5016 * dispextern.h (merge_faces):
5017 * xfaces.c (merge_faces):
5018 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5019 Don't assume EMACS_INT fits in int.
5021 * character.h (CHAR_VALID_P): Remove unused parameter.
5022 * fontset.c, lisp.h, xdisp.c: All uses changed.
5024 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5026 * fns.c (concat): Minor tuning based on overflow analysis.
5027 This doesn't fix any bugs. Use int to hold character, instead
5028 of constantly refetching from Emacs object. Use XFASTINT, not
5029 XINT, for value known to be a character. Don't bother comparing
5030 a single byte to 0400, as it's always less.
5032 * floatfns.c (Fexpt):
5033 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5035 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5038 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5040 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5041 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5042 incorrectly succeed when S was a string, because 4294967386 was
5043 truncated before it was used.
5045 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5046 Otherwise, an out-of-range integer could cause undefined behavior
5049 * composite.c: Use int, not EMACS_INT, for characters.
5050 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5051 EMACS_INT, for values that are known to be in character range.
5052 This doesn't fix any bugs but is the usual style inside Emacs and
5053 may generate better code on 32-bit machines.
5055 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5056 This is for reasons similar to the recent CHAR_STRING fix.
5057 * charset.c (Fencode_char): Check that character arg is actually
5058 a character. Pass an int to ENCODE_CHAR.
5059 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5060 wider than 'int', as a compile-time check to prevent future regressions
5063 * character.c (char_string): Remove unnecessary casts.
5065 Make sure a 64-bit char is never passed to CHAR_STRING.
5066 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5067 by silently ignoring the top 32 bits, allowing some values
5068 that were far too large to be valid characters.
5069 * character.h: Include <verify.h>.
5070 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5071 arguments are no wider than unsigned, as a compile-time check
5072 to prevent future regressions in this area.
5074 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5075 (Fsubst_char_in_region):
5077 * xdisp.c (decode_mode_spec_coding):
5078 Adjust to CHAR_STRING's new requirement.
5079 * editfns.c (Finsert_char, Fsubst_char_in_region):
5080 * fns.c (concat): Check that character args are actually
5081 characters. Without this test, these functions did the wrong
5082 thing with wildly out-of-range values on 64-bit hosts.
5084 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5085 These casts should not be needed on 32-bit hosts, either.
5086 * keyboard.c (read_char):
5087 * lread.c (Fload): Remove casts to unsigned.
5089 * lisp.h (UNSIGNED_CMP): New macro.
5090 This fixes comparison bugs on 64-bit hosts.
5091 (ASCII_CHAR_P): Use it.
5092 * casefiddle.c (casify_object):
5093 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5094 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5095 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5096 * dispextern.h (FACE_FROM_ID):
5097 * keyboard.c (read_char): Use UNSIGNED_CMP.
5099 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5100 not to EMACS_INT, to avoid GCC warning.
5102 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5104 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5105 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5106 isn't needed on 32-bit machines.
5108 * buffer.c (Fgenerate_new_buffer_name):
5109 Use EMACS_INT for count, not int.
5110 (advance_to_char_boundary): Return EMACS_INT, not int.
5112 * data.c (Qcompiled_function): Now static.
5114 * window.c (window_body_lines): Now static.
5116 * image.c (gif_load): Rename local to avoid shadowing.
5118 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5119 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5120 * alloc.c (make_save_value): Integer argument is now of type
5122 (mark_object): Use ptrdiff_t, not int.
5123 * lisp.h (pD): New macro.
5124 * print.c (print_object): Use it.
5126 * alloc.c: Use EMACS_INT, not int, to count objects.
5127 (total_conses, total_markers, total_symbols, total_vector_size)
5128 (total_free_conses, total_free_markers, total_free_symbols)
5129 (total_free_floats, total_floats, total_free_intervals)
5130 (total_intervals, total_strings, total_free_strings):
5131 Now EMACS_INT, not int. All uses changed.
5132 (Fgarbage_collect): Compute overall total using a double, so that
5133 integer overflow is less likely to be a problem. Check for overflow
5134 when converting back to an integer.
5135 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5136 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5137 These were 'int' variables that could overflow on 64-bit hosts;
5138 they were never used, so remove them instead of repairing them.
5139 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5140 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5141 Previously, this ceilinged at INT_MAX, but that doesn't work on
5143 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5145 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5146 (allocate_vectorlike): Check for ptrdiff_t overflow.
5147 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5148 when a (possibly-narrower) signed value would do just as well.
5149 We prefer using signed arithmetic, to avoid comparison confusion.
5151 * alloc.c: Catch some string size overflows that we were missing.
5152 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5153 for convenience in STRING_BYTES_MAX.
5154 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5155 The definition here is exact; the one in lisp.h was approximate.
5156 (allocate_string_data): Check for string overflow. This catches
5157 some instances we weren't catching before. Also, it catches
5158 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5159 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5160 and ptrdiff_t and EMACS_INT are both 64 bits.
5162 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5163 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5164 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5166 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5168 * alloc.c (Fmake_string): Check for out-of-range init.
5170 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5172 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5174 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5176 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5177 xg_get_default_scrollbar_width.
5179 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5180 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5181 (style_changed_cb): Call update_theme_scrollbar_width and call
5182 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5183 all frames (Bug#8505).
5184 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5185 Call gtk_window_set_resizable if HAVE_GTK3.
5186 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5187 and height if HAVE_GTK3 (Bug#8505).
5188 (scroll_bar_width_for_theme): New variable.
5189 (update_theme_scrollbar_width): New function.
5190 (xg_get_default_scrollbar_width): Move code to
5191 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5192 (xg_initialize): Call update_theme_scrollbar_width.
5194 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5196 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5198 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5200 * frame.c (make_frame): Call other_buffer_safely instead of
5203 * window.c (temp_output_buffer_show): Call display_buffer with
5204 second argument Vtemp_buffer_show_specifiers and reset latter
5205 immediately after the call.
5206 (Vtemp_buffer_show_specifiers): New variable.
5207 (auto_window_vscroll_p, next_screen_context_lines)
5208 (Vscroll_preserve_screen_position): Remove leading asterisks from
5211 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5213 Fix minor problems found by GCC 4.6.0 static checking.
5214 * buffer.c (Qclone_number): Remove for now, as it's unused.
5215 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5216 (record_buffer): Remove unused local.
5217 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5218 (set_frame_buffer_list): Remove; unused.
5219 * frame.h (other_visible_frames): Remove decl.
5220 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5221 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5222 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5224 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5225 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5226 Define only if HAVE_GPM.
5227 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5228 (update_hints_inhibit): Remove; never set. All uses removed.
5229 * widgetprv.h (emacsFrameClassRec): Remove decl.
5230 * window.c (delete_deletable_window): Now returns void, since it
5231 wasn't returning anything.
5232 (compare_window_configurations): Remove unused locals.
5233 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5234 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5235 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5236 the same widths as pointers. This follows up on the 2011-05-06 patch.
5237 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5238 * xterm.h: Likewise.
5239 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5241 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5243 * makefile.w32-in: Update dependencies.
5244 (LISP_H): Add lib/intprops.h.
5246 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5248 * image.c (gif_load): Add animation frame delay to the metadata.
5249 (syms_of_image): Use DEFSYM. New symbol `delay'.
5251 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5253 * window.c (delete_deletable_window): Re-add.
5254 (Fset_window_configuration): Rewrite to handle dead buffers and
5255 consequently deletable windows.
5256 (window_tree, Fwindow_tree): Remove. Supply functionality in
5258 (compare_window_configurations): Simplify code.
5260 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5262 * image.c (imagemagick_load_image): Fix type mismatch.
5263 (Fimagemagick_types): Likewise.
5265 * window.h (replace_buffer_in_windows): Declare.
5267 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5269 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5270 Qclone_number. Remove external declaration of Qdelete_window.
5271 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5273 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5274 Run Qbuffer_list_update_hook if allowed.
5275 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5276 buffer list implementation.
5277 (other_buffer_safely): New function.
5278 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5279 calls to replace_buffer_in_windows and
5280 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5282 (record_buffer): Inhibit quitting and rewrite using quittable
5283 functions. Run Qbuffer_list_update_hook if allowed.
5284 (Frecord_buffer, Funrecord_buffer): New functions.
5285 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5286 Move switch-to-buffer to window.el.
5287 (bury-buffer): Move to window.el.
5288 (Vbuffer_list_update_hook): New variable.
5290 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5293 * window.h (resize_frame_windows): Move up in code.
5294 (Fwindow_frame): Remove EXFUN.
5295 (replace_buffer_in_all_windows): Remove prototype.
5296 (replace_buffer_in_windows_safely): Add prototype.
5298 * window.c: Declare Qdelete_window static again. Move down
5299 declaration of select_count.
5300 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5301 (Fother_window): Move to window.el.
5302 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5303 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5304 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5306 (replace_buffer_in_windows): Implement by calling
5307 Qreplace_buffer_in_windows.
5308 (replace_buffer_in_all_windows): Remove with some functionality
5309 moved into replace_buffer_in_windows_safely.
5310 (replace_buffer_in_windows_safely): New function.
5311 (select_window_norecord, select_frame_norecord): Move in front
5312 of run_window_configuration_change_hook. Remove now obsolete
5314 (Fset_window_buffer): Rewrite doc-string.
5315 Call Qrecord_window_buffer.
5316 (keys_of_window): Move binding for other-window to window.el.
5318 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5320 * dispextern.h (struct image): Replace data member, whose int_val
5321 and ptr_val fields were not used by anything, with a single
5324 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5325 (gif_clear_image, gif_load, imagemagick_load_image)
5326 (gs_clear_image, gs_load): Callers changed.
5328 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5330 * buffer.h: Include <time.h>, for time_t.
5331 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5333 Fix minor problems found by static checking.
5335 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5337 Make identifiers static if they are not used in other modules.
5338 * data.c (Qcompiled_function, Qframe, Qvector):
5339 * image.c (QimageMagick, Qsvg):
5340 * minibuf.c (Qmetadata):
5341 * window.c (resize_window_check, resize_root_window): Now static.
5342 * window.h (resize_window_check, resize_root_window): Remove decls.
5344 * window.c (window_deletion_count, delete_deletable_window):
5346 (window_body_lines): Now static.
5347 (Fdelete_other_windows_internal): Mark vars as initialized.
5348 Make sure 'resize_failed' is initialized.
5349 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5350 (resize_window_apply): Remove unused local.
5351 * window.h (delete_deletable_window): Remove decl.
5353 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5354 (imagemagick_load_image): Fix pointer signedness problem by changing
5355 last arg from unsigned char * to char *. All uses changed.
5356 Also, fix a local for similar reasons.
5357 Remove unused locals. Remove locals to avoid shadowing.
5358 (fn_rsvg_handle_free): Remove; unused.
5359 (svg_load, svg_load_image): Fix pointer signedness problem.
5360 (imagemagick_load_image): Don't use garbage pointer image_wand.
5362 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5364 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5366 * image.c (gif_load): Fix omitted cast error introduced by
5369 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5371 * window.h (resize_proportionally, orig_total_lines)
5372 (orig_top_line): Remove from window structure.
5373 (set_window_height, set_window_width, change_window_heights)
5374 (Fdelete_window): Remove prototypes.
5375 (resize_frame_windows): Remove duplicate declaration.
5377 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5379 * window.h (resize_frame_windows, resize_window_check)
5380 (delete_deletable_window, resize_root_window)
5381 (resize_frame_windows): Declare prototypes.
5383 * window.c (resize_window_apply): Make definition be "static" to
5384 match the prototype.
5386 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5388 * window.c: Remove declarations of Qwindow_size_fixed,
5389 window_min_size_1, window_min_size_2, window_min_size,
5390 size_window, window_fixed_size_p, enlarge_window, delete_window.
5391 Remove static from declaration of Qdelete_window, it's
5392 temporarily needed by Fbury_buffer.
5393 (replace_window): Don't assign orig_top_line and
5395 (Fdelete_window, delete_window): Remove. Window deletion is
5396 handled by window.el.
5397 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5398 Replace Fdelete_window calls with calls to Qdelete_window.
5399 (Fdelete_other_windows): Remove. Deleting other windows is
5400 handled by window.el.
5401 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5402 handled in window.el.
5403 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5404 Window minimum sizes are handled in window.el.
5405 (shrink_windows, size_window, set_window_height)
5406 (set_window_width, change_window_heights, window_height)
5407 (window_width, CURBEG, CURSIZE, enlarge_window)
5408 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5409 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5410 handled in window.el.
5411 (make_dummy_parent): Rename to make_parent_window and give it a
5412 second argument horflag.
5413 (make_window): Don't set resize_proportionally any more.
5414 (Fsplit_window): Remove. Windows are split in window.el.
5415 (save_restore_action, save_restore_orig_size)
5416 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5417 Resize mini windows in window.el.
5418 (grow_mini_window, shrink_mini_window): Implement by calling
5419 Qresize_root_window_vertically, resize_window_check and
5420 resize_window_apply.
5421 (saved_window, Fset_window_configuration, save_window_save):
5422 Do not handle orig_top_line, orig_total_lines, and
5423 resize_proportionally.
5424 (window_min_height, window_min_width): Move to window.el.
5425 (keys_of_window): Move bindings for delete-other-windows,
5426 split-window, delete-window and enlarge-window to window.el.
5428 * buffer.c: Temporarily extern Qdelete_window.
5429 (Fbury_buffer): Temporarily call Qdelete_window instead of
5430 Fdelete_window (Fbury_buffer will move to window.el soon).
5432 * frame.c (set_menu_bar_lines_1): Remove code handling
5433 orig_top_line and orig_total_lines.
5435 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5436 set_window_height but set heights directly.
5437 (change_frame_size_1): Use resize_frame_windows.
5439 * xdisp.c (init_xdisp): Don't use set_window_height but set
5442 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5443 Use resize_frame_windows instead of change_window_heights and run
5444 run_window_configuration_change_hook.
5446 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5447 instead of change_window_heights and run
5448 run_window_configuration_change_hook.
5450 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5452 * window.c (replace_window): Rename second argument REPLACEMENT to
5453 NEW. New third argument SETFLAG. Rewrite.
5454 (delete_window, make_dummy_parent): Call replace_window with
5456 (window_list_1): Move down in code.
5457 (run_window_configuration_change_hook): Move set_buffer part
5458 before select_frame_norecord part in order to unwind correctly.
5459 Rename count1 to count.
5460 (recombine_windows, delete_deletable_window, resize_root_window)
5461 (Fdelete_other_windows_internal)
5462 (Frun_window_configuration_change_hook, make_parent_window)
5463 (resize_window_check, resize_window_apply, Fresize_window_apply)
5464 (resize_frame_windows, Fsplit_window_internal)
5465 (Fdelete_window_internal, Fresize_mini_window_internal):
5467 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5469 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5471 * window.h (window): Add some new members to window structure -
5472 normal_lines, normal_cols, new_total, new_normal, clone_number,
5473 splits, nest, prev_buffers, next_buffers.
5474 (WINDOW_TOTAL_SIZE): Move here from window.c.
5475 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5477 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5479 (make_dummy_parent): Set new members of windows structure.
5480 (make_window): Move down in code. Handle new members of window
5482 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5483 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5484 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5485 (Fset_window_prev_buffers, Fwindow_next_buffers)
5486 (Fset_window_next_buffers, Fset_window_clone_number):
5488 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5489 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5491 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5492 Argument WINDOW can be now internal window too.
5493 (Fwindow_use_time): Move up in code.
5494 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5496 (Fset_window_configuration, saved_window)
5497 (Fcurrent_window_configuration, save_window_save): Handle new
5498 members of window structure.
5499 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5500 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5501 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5502 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5503 Qget_mru_window, Qresize_root_window,
5504 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5505 Qauto_buffer_name; staticpro them.
5507 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5509 * window.c (Fwindow_total_size, Fwindow_left_column)
5510 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5511 (Fwindow_list_1): New functions.
5512 (window_box_text_cols): Replace with window_body_cols.
5513 (Fwindow_width, Fscroll_left, Fscroll_right):
5514 Use window_body_cols instead of window_box_text_cols.
5515 (delete_window, Fset_window_configuration):
5516 Call delete_all_subwindows with window as argument.
5517 (delete_all_subwindows): Take a window as argument and not a
5519 (window_loop): Remove handling of GET_LRU_WINDOW and
5521 (Fget_lru_window, Fget_largest_window): Move to window.el.
5523 * window.h: Extern window_body_cols instead of
5524 window_box_text_cols. delete_all_subwindows now takes a
5525 Lisp_Object as argument.
5527 * indent.c (compute_motion, Fcompute_motion):
5528 Use window_body_cols instead of window_box_text_cols.
5530 * frame.c (delete_frame): Call delete_all_subwindows with root
5533 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5535 * fns.c (Fputhash): Document return value.
5537 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5539 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5541 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5543 Cons<->int and similar integer overflow fixes (Bug#8794).
5545 Check for overflow when converting integer to cons and back.
5546 * charset.c (Fdefine_charset_internal, Fdecode_char):
5547 Use cons_to_unsigned to catch overflow.
5548 (Fencode_char): Use INTEGER_TO_CONS.
5549 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5550 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5551 * data.c (long_to_cons, cons_to_long): Remove.
5552 (cons_to_unsigned, cons_to_signed): New functions.
5553 These signal an error for invalid or out-of-range values.
5554 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5555 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5556 * font.c (Ffont_variation_glyphs):
5557 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5558 * lisp.h: Include <intprops.h>.
5559 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5560 (cons_to_signed, cons_to_unsigned): New decls.
5561 (long_to_cons, cons_to_long): Remove decls.
5562 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5563 (Fprimitive_undo): Use CONS_TO_INTEGER.
5564 * xfns.c (Fx_window_property): Likewise.
5565 * xselect.c: Include <limits.h>.
5566 (x_own_selection, selection_data_to_lisp_data):
5567 Use INTEGER_TO_CONS.
5568 (x_handle_selection_request, x_handle_selection_clear)
5569 (x_get_foreign_selection, Fx_disown_selection_internal)
5570 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5571 (lisp_data_to_selection_data): Use cons_to_unsigned.
5572 (x_fill_property_data): Use cons_to_signed.
5573 Report values out of range.
5575 Check for buffer and string overflow more precisely.
5576 * buffer.h (BUF_BYTES_MAX): New macro.
5577 * lisp.h (STRING_BYTES_MAX): New macro.
5578 * alloc.c (Fmake_string):
5579 * character.c (string_escape_byte8):
5580 * coding.c (coding_alloc_by_realloc):
5581 * doprnt.c (doprnt):
5582 * editfns.c (Fformat):
5584 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5585 since they may not be the same number.
5586 * editfns.c (Finsert_char):
5587 * fileio.c (Finsert_file_contents):
5588 Likewise for BUF_BYTES_MAX.
5590 * image.c: Use ptrdiff_t, not int, for sizes.
5591 (slurp_file): Switch from int to ptrdiff_t.
5593 (slurp_file): Check that file size fits in both size_t (for
5594 malloc) and ptrdiff_t (for sanity and safety).
5596 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5597 if b->modtime has its maximal value.
5599 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5601 Don't assume time_t can fit into int.
5602 * buffer.h (struct buffer.modtime): Now time_t, not int.
5603 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5604 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5606 Minor fixes for signed vs unsigned integers.
5607 * character.h (MAYBE_UNIFY_CHAR):
5608 * charset.c (maybe_unify_char):
5609 * keyboard.c (read_char, reorder_modifiers):
5610 XINT -> XFASTINT, since the integer must be nonnegative.
5611 * ftfont.c (ftfont_spec_pattern):
5612 * keymap.c (access_keymap, silly_event_symbol_error):
5613 XUINT -> XFASTINT, since the integer must be nonnegative.
5614 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5615 since it makes no difference and we prefer signed.
5616 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5617 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5620 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5622 * window.h (Fwindow_frame): Declare.
5624 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5626 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5627 (SPARE_MEMORY): Always define.
5628 (LARGE_REQUEST): Remove.
5629 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5631 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5633 * lisp.h: Move EXFUNS for Fframe_root_window,
5634 Fframe_first_window and Fset_frame_selected_window to window.h.
5636 * window.h: Move EXFUNS for Fframe_root_window,
5637 Fframe_first_window and Fset_frame_selected_window here from
5640 * frame.c (Fwindow_frame, Fframe_first_window)
5641 (Fframe_root_window, Fframe_selected_window)
5642 (Fset_frame_selected_window): Move to window.c.
5643 (Factive_minibuffer_window): Move to minibuf.c.
5644 (Fother_visible_frames_p): New function.
5646 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5648 * window.c (decode_window, decode_any_window): Move up in code.
5649 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5650 (inhibit_frame_unsplittable): Remove unused variable.
5651 (Fwindow_buffer): Move up and rewrite doc-string.
5652 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5653 (Fwindow_prev): New functions.
5654 (Fwindow_frame): Move here from frame.c. Accept any window as
5656 (Fframe_root_window, Fframe_first_window)
5657 (Fframe_selected_window): Move here from frame.c. Accept frame
5658 or arbitrary window as argument. Update doc-strings.
5659 (Fminibuffer_window): Move up in code.
5660 (Fwindow_minibuffer_p): Move up in code and simplify.
5661 (Fset_frame_selected_window): Move here from frame.c.
5663 (Fselected_window, select_window, Fselect_window): Move up in
5664 code. Minor doc-string fixes.
5666 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5668 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5669 Do not assume that spare memory exists; that assumption is valid
5670 only if SYSTEM_MALLOC.
5671 (LARGE_REQUEST): New macro, so that the issue of large requests
5672 is separated from the issue of spare memory.
5674 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5676 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5679 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5681 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5684 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5686 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5688 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5690 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5691 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5693 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5695 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5697 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5699 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5700 (x_clipboard_manager_save): Add return value.
5701 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5703 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5704 Obey Vx_select_enable_clipboard_manager. Catch errors in
5705 x_clipboard_manager_save (Bug#8779).
5706 (Vx_select_enable_clipboard_manager): New variable.
5707 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5709 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5711 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5713 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5715 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5716 in the current matrix if keep_current_p is non-zero.
5718 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5720 * bidi.c (bidi_level_of_next_char): Fix last change.
5722 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5724 Support bidi reordering of text covered by display properties.
5726 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5727 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5728 (bidi_cache_search, bidi_cache_iterator_state)
5729 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5730 (bidi_level_of_next_char, bidi_move_to_visually_next):
5731 Support character positions inside a run of characters covered by a
5733 (bidi_paragraph_init, bidi_resolve_explicit_1)
5734 (bidi_level_of_next_char): Call bidi_fetch_char and
5735 bidi_fetch_char_advance instead of FETCH_CHAR and
5737 (bidi_init_it): Initialize new members.
5738 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5740 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5741 instead of using explicit *_CHAR codes.
5742 (bidi_resolve_explicit, bidi_resolve_weak):
5743 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5744 bidirectional text is supported only in multibyte buffers.
5745 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5746 it to initialize the frame_window_p member of struct bidi_it.
5747 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5748 (bidi_resolve_explicit, bidi_resolve_weak)
5749 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5750 bidi_it->nchars is non-positive.
5751 (bidi_level_of_next_char): Don't try to lookup the cache for the
5752 next/previous character if nothing is cached there yet, or if we
5753 were just reseat()'ed to a new position.
5755 * xdisp.c (set_cursor_from_row): Set start and stop points
5756 according to the row's direction when priming the loop that looks
5757 for the glyph on which to display cursor.
5758 (single_display_spec_intangible_p): Function deleted.
5759 (display_prop_intangible_p): Reimplement to call
5760 handle_display_spec instead of single_display_spec_intangible_p.
5761 Accept 3 additional arguments needed by handle_display_spec.
5762 This fixes incorrect cursor motion across display property with complex
5763 values: lists, `(when COND...)' forms, etc.
5764 (single_display_spec_string_p): Support property values that are
5765 lists with the argument STRING its top-level element.
5766 (display_prop_string_p): Fix the condition for processing a
5767 property that is a list to be consistent with handle_display_spec.
5768 (handle_display_spec): New function, refactored from the
5769 last portion of handle_display_prop.
5770 (compute_display_string_pos): Accept additional argument
5771 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5772 value of a `display' property is a "replacing spec".
5773 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5774 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5775 the display property, but just return a value indicating whether
5776 the display property will replace the characters it covers.
5777 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5778 frame_window_p members of struct bidi_it.
5779 (compute_display_string_pos, compute_display_string_end):
5781 (push_it): Accept second argument POSITION, where pop_it should
5782 jump to continue iteration.
5783 (reseat_1): Initialize bidi_it.disp_pos.
5785 * keyboard.c (adjust_point_for_property): Adjust the call to
5786 display_prop_intangible_p to its new signature.
5788 * dispextern.h (struct bidi_it): New member frame_window_p.
5789 (bidi_init_it): Update prototypes.
5790 (display_prop_intangible_p): Update prototype.
5791 (compute_display_string_pos, compute_display_string_end):
5793 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5796 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5798 Malloc failure behavior now depends on size of allocation.
5799 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5800 * lisp.h: Change signatures accordingly.
5801 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5802 All callers changed. (Bug#8762)
5804 * gnutls.c: Use Emacs's memory allocators.
5805 Without this change, the gnutls library would invoke malloc etc.
5806 directly, which causes problems on non-SYNC_INPUT hosts, and which
5807 runs afoul of improving memory_full behavior. (Bug#8761)
5808 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5809 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5810 xfree instead of the default malloc, realloc, free.
5811 (Fgnutls_boot): No need to check for memory allocation failure,
5812 since xmalloc does that for us.
5814 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5815 * category.c (hash_get_category_set):
5816 * ccl.c (ccl_driver):
5817 * charset.c (Fdefine_charset_internal):
5818 * charset.h (struct charset.hash_index):
5819 * composite.c (get_composition_id, gstring_lookup_cache)
5820 (composition_gstring_put_cache):
5821 * composite.h (struct composition.hash_index):
5822 * dispextern.h (struct image.hash):
5823 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5824 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5825 (hashfn_equal, hashfn_user_defined, make_hash_table)
5826 (maybe_resize_hash_table, hash_lookup, hash_put)
5827 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5828 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5829 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5830 * image.c (make_image, search_image_cache, lookup_image)
5831 (xpm_put_color_table_h):
5832 * lisp.h (struct Lisp_Hash_Table):
5833 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5834 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5835 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5836 * alloc.c (allocate_vectorlike):
5837 Check for overflow in vector size calculations.
5838 * ccl.c (ccl_driver):
5839 Check for overflow when converting EMACS_INT to int.
5840 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5841 need to be updated by these changes.
5842 * fns.c (make_hash_table, maybe_resize_hash_table):
5843 Check for integer overflow with large hash tables.
5844 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5845 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5846 (SXHASH_REDUCE): New macro.
5847 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5848 Use it instead of discarding useful hash info with large hash values.
5849 (sxhash_float): New function.
5850 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5851 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5852 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5853 Rewrite to use FIXNUM_BITS, as this simplifies things.
5854 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5855 Adjust signatures to match updated version of code.
5856 (consing_since_gc): Now EMACS_INT, since a single hash table can
5857 use more than INT_MAX bytes.
5859 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5861 Make it possible to build with GCC-4.6+ -O2 -flto.
5863 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5865 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5867 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5868 Call minibuffer-inactive-mode.
5870 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5872 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5873 Update dependencies.
5875 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5877 * data.c (init_data): Remove code for UTS, this system is not
5880 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5882 Don't force ./temacs to start in terminal mode.
5884 * frame.c (make_initial_frame): Initialize faces in all cases, not
5885 only when CANNOT_DUMP is defined.
5886 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5888 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5890 * dispnew.c (add_window_display_history): Use const for the string
5891 pointer. Remove declaration, not needed.
5893 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5895 Use 'inline', not 'INLINE'.
5896 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5897 * alloc.c, fontset.c (INLINE): Remove.
5898 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5899 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5900 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5901 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5902 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5904 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5906 Make it possible to run ./temacs.
5908 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5909 syms_of_callproc does the same thing. Remove test for
5910 "initialized", do it in the caller.
5911 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5913 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5915 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5916 (read_minibuf): Use get_minibuffer.
5917 (syms_of_minibuf): Use DEFSYM.
5918 (Qmetadata): New var.
5919 * data.c (Qbuffer): Don't make it static.
5920 (syms_of_data): Use DEFSYM.
5922 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5924 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5925 (CCL_CODE_MIN): New macro.
5927 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5929 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5931 * eval.c (Qdebug): Now static.
5932 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5933 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5934 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5936 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5938 * image.c: Various fixes to ImageMagick code comments.
5939 (Fimagemagick_types): Doc fix.
5941 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5943 Minor fixes prompted by GCC 4.6.0 warnings.
5945 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5947 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5948 (x_clipboard_manager_save_all): Move extern decl to ...
5949 * xterm.h: ... here, so that it can be checked for consistency.
5951 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5953 * xselect.c (x_clipboard_manager_save_frame)
5954 (x_clipboard_manager_save_all): New functions.
5955 (Fx_clipboard_manager_save): Lisp function deleted.
5957 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5958 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5960 * xterm.h: Update prototype.
5962 2011-05-28 William Xu <william.xwl@gmail.com>
5964 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5967 2011-05-28 Jim Meyering <meyering@redhat.com>
5969 Avoid a sign-extension bug in crypto_hash_function.
5970 * fns.c (to_uchar): Define.
5971 (crypto_hash_function): Use it to convert some newly-signed
5972 variables to unsigned, to avoid sign-extension bugs. For example,
5973 without this change, (md5 "truc") would evaluate to
5974 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5975 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5976 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5978 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5980 Integer overflow fixes.
5982 * dbusbind.c: Serial number integer overflow fixes.
5983 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5984 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5985 to hold a serial number that is too large for a fixnum.
5986 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5987 Check for serial numbers out of range. Decode any serial number
5988 that was so large that it became a float. (Bug#8722)
5990 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5991 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5992 Use XFASTINT rather than XUINT when numbers are nonnegative.
5993 (xd_append_arg, Fdbus_method_return_internal):
5994 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5995 arguments, check that Lisp number is nonnegative, rather than
5996 silently wrapping negative numbers around. (Bug#8722)
5997 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6000 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6002 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6004 ccl: Add integer overflow checks.
6005 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6006 (IN_INT_RANGE): New macros.
6007 (ccl_driver): Use them to check for integer overflow when
6008 decoding a CCL program. Many of the new checks are whether XINT (x)
6009 fits in int; it doesn't always, on 64-bit hosts. The new version
6010 doesn't catch all possible integer overflows, but it's an
6011 improvement. (Bug#8719)
6013 * alloc.c (make_event_array): Use XINT, not XUINT.
6014 There's no need for unsigned here.
6016 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6017 This follows up to the 2011-05-06 change that substituted uintptr_t
6018 for EMACS_INT. This case wasn't caught back then.
6020 Rework Fformat to avoid integer overflow issues.
6021 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6022 now (part of C89). Include <verify.h>.
6023 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6024 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6025 (Fformat): Avoid the prepass trying to compute sizes; it was only
6026 approximate and thus did not catch overflow reliably. Instead, walk
6027 through the format just once, formatting and computing sizes as we go,
6028 checking for integer overflow at every step, and allocating a larger
6029 buffer as needed. Keep track separately whether the format is
6030 multibyte. Keep only the most-recently calculated precision, rather
6031 than them all. Record whether each argument has been converted to
6032 string. Use EMACS_INT, not int, for byte and char and arg counts.
6033 Support field widths and precisions larger than INT_MAX. Avoid
6034 sprintf's undefined behavior with conversion specifications such as %#d
6035 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6036 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6037 formatting out-of-range floating point numbers with int
6040 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6042 * data.c: Avoid integer truncation in expressions involving floats.
6043 * data.c: Include <intprops.h>.
6044 (arith_driver): When there's an integer overflow in an expression
6045 involving floating point, convert the integers to floating point
6046 so that the resulting value does not suffer from catastrophic
6047 integer truncation. For example, on a 64-bit host (* 4
6048 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6049 Do not rely on undefined behavior after integer overflow.
6051 merge count_size_as_multibyte, parse_str_to_multibyte
6052 * character.c, character.h (count_size_as_multibyte):
6053 Rename from parse_str_to_multibyte; all uses changed.
6054 Check for integer overflow.
6055 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6056 since it's now a duplicate of the other. This is more of
6057 a character than a buffer op, so better that it's in character.c.
6058 * fns.c, print.c: Adjust to above changes.
6060 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6062 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6064 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6066 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6067 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6068 (x_clipboard_manager_save): Now static.
6069 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6071 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6072 (crypto_hash_function): Now static.
6073 Fix pointer signedness problems. Avoid unnecessary initializations.
6075 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6077 * termhooks.h (Vselection_alist): Make it terminal-local.
6079 * terminal.c (create_terminal): Initialize it.
6081 * xselect.c: Support for clipboard managers.
6082 (Vselection_alist): Move to termhooks.h as terminal-local var.
6083 (LOCAL_SELECTION): New macro.
6084 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6085 (symbol_to_x_atom): Remove gratuitous arg.
6086 (x_handle_selection_request, lisp_data_to_selection_data)
6087 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6088 (x_own_selection, x_get_local_selection, x_convert_selection):
6089 New arg, specifying work frame. Use terminal-local Vselection_alist.
6090 (some_frame_on_display): Delete unused function.
6091 (Fx_own_selection_internal, Fx_get_selection_internal)
6092 (Fx_disown_selection_internal, Fx_selection_owner_p)
6093 (Fx_selection_exists_p): New optional frame arg.
6094 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6095 (x_handle_selection_clear): Don't treat other terminals with the
6096 same keyboard specially. Use the terminal-local Vselection_alist.
6097 (x_clear_frame_selections): Use Frun_hook_with_args.
6099 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6101 * xterm.h: Add support for those atoms.
6103 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6105 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6106 (converted_selections, conversion_fail_tag): New global variables.
6107 (x_selection_request_lisp_error): Free the above.
6108 (x_get_local_selection): Remove unnecessary code.
6109 (x_reply_selection_request): Args changed; handle arbitrary array
6110 of converted selections stored in converted_selections.
6111 Separate the XChangeProperty and SelectionNotify steps.
6112 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6113 (x_convert_selection): New function.
6114 (x_handle_selection_event): Simplify.
6115 (x_get_foreign_selection): Don't ignore incoming requests while
6116 waiting for an answer; this will fail when we implement
6117 SAVE_TARGETS, and seems unnecessary anyway.
6118 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6119 (Vx_sent_selection_functions): Doc fix.
6121 2011-05-26 Leo Liu <sdl.web@gmail.com>
6123 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6125 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6127 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6129 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6130 for fringe update if it has periodic bitmap.
6131 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6132 and fringe_bitmap_periodic_p.
6134 * fringe.c (get_fringe_bitmap_data): New function.
6135 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6136 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6137 row. Mark glyph row for fringe update if periodicity changed.
6139 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6140 for fringe update unless it has periodic bitmap.
6142 2011-05-25 Kenichi Handa <handa@m17n.org>
6144 * xdisp.c (get_next_display_element): Set correct it->face_id for
6145 a static composition.
6147 2011-05-24 Leo Liu <sdl.web@gmail.com>
6150 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6152 * fns.c (crypto_hash_function, Fsha1): New function.
6153 (Fmd5): Use crypto_hash_function.
6154 (syms_of_fns): Add Ssha1.
6156 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6158 * gnutls.c: Remove unused macros.
6159 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6160 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6161 Remove macros that are defined and never used.
6162 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6164 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6166 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6167 (Fx_get_selection_internal): Minor cleanup.
6168 (Fx_own_selection_internal): Rename arguments for consistency with
6171 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6173 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6175 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6177 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6179 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6181 * dispnew.c (scrolling_window): Don't exclude the case that the
6182 last enabled row in the desired matrix touches the bottom boundary.
6184 2011-05-21 Glenn Morris <rgm@gnu.org>
6186 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6187 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6188 and add some more files.
6190 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6192 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6193 report_file_error introduced by the change from 2011-05-07.
6195 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6197 * systime.h (Time): Define only if emacs is defined.
6198 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6199 where the include path doesn't have X11/X.h by default. See
6200 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6202 2011-05-20 Kenichi Handa <handa@m17n.org>
6204 * composite.c (find_automatic_composition): Fix previous change.
6206 2011-05-20 Glenn Morris <rgm@gnu.org>
6208 * lisp.mk: New file, split from Makefile.in.
6209 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6210 (shortlisp): Remove.
6211 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6213 2011-05-19 Glenn Morris <rgm@gnu.org>
6215 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6216 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6217 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6218 (lisp): Set the order to that of loadup.el.
6219 (shortlisp): Make it a copy of $lisp.
6220 (SOME_MACHINE_LISP): Remove.
6221 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6222 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6224 2011-05-18 Kenichi Handa <handa@m17n.org>
6226 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6227 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6228 (find_automatic_composition): Mostly rewrite for efficiency.
6230 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6232 * makefile.w32-in: Update dependencies.
6234 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6236 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6237 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6239 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6241 Fix some integer overflow issues, such as string length overflow.
6243 * insdel.c (count_size_as_multibyte): Check for string overflow.
6245 * character.c (lisp_string_width): Check for string overflow.
6246 Use EMACS_INT, not int, for string indexes and lengths; in
6247 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6248 the resulting string length overflows an EMACS_INT; instead,
6249 report a string overflow if no precision given. When checking for
6250 precision exhaustion, use a check that cannot possibly have
6251 integer overflow. (Bug#8675)
6252 * character.h (lisp_string_width): Adjust to new signature.
6254 * alloc.c (string_overflow): New function.
6255 (Fmake_string): Use it. This doesn't change behavior, but saves
6256 a few bytes and will simplify future changes.
6257 * character.c (string_escape_byte8): Likewise.
6258 * lisp.h (string_overflow): New decl.
6260 Fixups, following up to the user-interface timestamp change.
6261 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6262 for UI timestamps, instead of unsigned long.
6263 * msdos.c (mouse_get_pos): Likewise.
6264 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6265 * w32gui.h (Time): Define by including "systime.h" rather than by
6266 declaring it ourselves. (Bug#8664)
6268 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6269 * image.c (clear_image_cache): Likewise.
6271 * term.c (term_mouse_position): Don't assume time_t wraparound.
6273 Be more systematic about user-interface timestamps.
6274 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6275 and sometimes 'EMACS_UINT', to represent these timestamps.
6276 This change causes it to use 'Time' uniformly, as that's what X uses.
6277 This makes the code easier to follow, and makes it easier to catch
6278 integer overflow bugs such as Bug#8664.
6279 * frame.c (Fmouse_position, Fmouse_pixel_position):
6280 Use Time, not unsigned long, for user-interface timestamps.
6281 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6282 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6283 * keyboard.h (last_event_timestamp): Likewise.
6284 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6285 * menu.h (xmenu_show): Likewise.
6286 * term.c (term_mouse_position): Likewise.
6287 * termhooks.h (struct input_event.timestamp): Likewise.
6288 (struct terminal.mouse_position_hook): Likewise.
6289 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6290 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6291 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6292 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6294 * menu.h, termhooks.h: Include "systime.h", for Time.
6296 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6297 Don't assume that the difference between two unsigned long values
6298 can fit into an integer. At this point, we know button_down_time
6299 <= event->timestamp, so the difference must be nonnegative, so
6300 there's no need to cast the result if double-click-time is
6301 nonnegative, as it should be; check that it's nonnegative, just in
6302 case. This bug is triggered when events are more than 2**31 ms
6303 apart (about 25 days). (Bug#8664)
6305 * xselect.c (last_event_timestamp): Remove duplicate decl.
6306 (x_own_selection): Remove needless cast to unsigned long.
6308 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6309 that always fit in int. Use a sentinel instead of a counter, to
6310 avoid a temp and to allay GCC's concerns about possible int overflow.
6311 * frame.h (struct frame): Use int for menu_bar_items_used
6312 instead of EMACS_INT, since it always fits in int.
6314 * menu.c (grow_menu_items): Check for int overflow.
6316 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6318 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6319 Before, the code was not consistent. These values cannot exceed
6320 2**31 - 1 so there's no need to make them unsigned.
6321 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6322 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6323 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6325 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6327 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6328 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6329 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6330 presumably because the widths might not match.
6332 * window.c (size_window): Avoid needless test at loop start.
6334 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6336 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6338 2011-05-12 Drew Adams <drew.adams@oracle.com>
6340 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6342 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6344 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6345 `width' to `bar_area_x' and `bar_area_width', respectively.
6346 (x_scroll_run): Take account of fringe background extension.
6348 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6349 Rename local vars `left' and `width' to `bar_area_x' and
6350 `bar_area_width', respectively.
6351 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6352 background extension.
6354 2011-05-10 Jim Meyering <meyering@redhat.com>
6356 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6358 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6360 * image.c (Finit_image_library): Return t for built-in image types,
6361 like pbm and xbm. (Bug#8640)
6363 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6365 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6367 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6369 * w32console.c (Fset_screen_color): Doc fix.
6370 (Fget_screen_color): New function.
6371 (syms_of_ntterm): Defsubr it.
6373 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6374 unlink the temporary file if Fcall_process didn't create it in the
6376 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6377 child process will be redirected to a file specified with `:file'.
6378 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6379 cue to call_process_cleanup not to close that handle.
6381 2011-05-07 Ben Key <bkey76@gmail.com>
6383 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6384 one of two shell specific rules, either bootstrap-temacs-CMD or
6385 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6386 to the previous implementation of the bootstrap-temacs rule.
6387 The bootstrap-temacs-CMD rule is similar to the previous
6388 implementation of the bootstrap-temacs rule except that it
6389 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6392 These changes, along with some changes to nt/configure.bat,
6393 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6394 earlier fix to add support for --cflags and --ldflags options
6395 that include quotes so that it works whether make uses cmd or
6398 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6400 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6401 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6403 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6404 a string. Handle both cases.
6405 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6406 (Fdbus_register_method): Use Qinvalid_function.
6408 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6410 * makefile.w32-in: Update dependencies.
6411 (LISP_H): Add inttypes.h and stdin.h.
6412 (PROCESS_H): Add unistd.h.
6414 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6416 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6417 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6419 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6421 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6423 * term.c (vfatal): Remove stray call to va_end.
6424 It's not needed and the C Standard doesn't allow it here anyway.
6426 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6427 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6429 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6432 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6434 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6436 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6438 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6440 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6442 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6443 * charset.c (Fdefine_charset_internal): Don't initialize
6444 charset.code_space[15]. The value was garbage, on hosts with
6445 32-bit int (Bug#8600).
6447 * lread.c (read_integer): Be more consistent with string-to-number.
6448 Use string_to_number to do the actual conversion; this avoids
6449 rounding errors and fixes some other screwups. Without this fix,
6450 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6451 (digit_to_number): Move earlier, for benefit of read_integer.
6452 Return -1 if the digit is out of range for the base, -2 if it is
6453 not a digit in any supported base. (Bug#8602)
6455 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6457 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6458 to match comment at start of function. This also removes a
6459 GCC warning about overflow in a 32+64-bit port.
6461 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6463 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6464 Reported by Stefan Monnier in
6465 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6466 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6467 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6469 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6470 (EMACS_UINTPTR): Likewise, with uintptr_t.
6472 * lisp.h: Prefer 64-bit EMACS_INT if available.
6473 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6474 on 32-bit hosts that have 64-bit int, so that they can access
6476 However, temporarily disable this change unless the temporary
6477 symbol WIDE_EMACS_INT is defined.
6479 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6481 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6482 This removes an assumption that EMACS_INT and long are the same
6483 width as pointers. The assumption is true for Emacs porting targets
6484 now, but we want to make other targets possible.
6485 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6486 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6487 In the rest of the code, change types of integers that hold casted
6488 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6489 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6490 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6491 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6492 No need to cast type when ORing.
6493 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6494 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6495 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6496 assume EMACS_INT is the same width as char *.
6497 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6498 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6499 Remove no-longer-needed casts.
6500 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6501 (xg_tool_bar_help_callback, xg_make_tool_item):
6502 Use EMACS_INTPTR to hold an integer
6503 that will be cast to void *; this can avoid a GCC warning
6504 if EMACS_INT is not the same width as void *.
6505 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6506 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6507 (current_message_1, set_message_1):
6508 Use a local to convert to proper width without a cast.
6509 * xmenu.c (dialog_selection_callback): Likewise.
6511 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6512 Also, don't assume VALBITS / RAND_BITS is less than 5,
6513 and don't rely on undefined behavior when shifting a 1 left into
6515 * lisp.h (get_random): Change signature to match.
6517 * lread.c (hash_string): Use size_t, not int, for hash computation.
6518 Normally we prefer signed values; but hashing is special, because
6519 it's better to use unsigned division on hash table sizes so that
6520 the remainder is nonnegative. Also, size_t is the natural width
6521 for hashing into memory. The previous code used 'int', which doesn't
6522 retain enough info to hash well into very large tables.
6523 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6525 * dbusbind.c: Don't possibly lose pointer info when converting.
6526 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6527 Use XPNTR rather than XHASH, so that the high-order bits of
6528 the pointer aren't lost when converting through void *.
6530 * eval.c (Fautoload): Don't double-shift a pointer.
6532 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6534 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6536 * gnutls.c (DEF_GNUTLS_FN):
6537 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6539 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6541 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6544 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6546 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6547 New version that can reserve upto 2GB of heap space.
6549 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6551 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6553 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6555 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6556 `gnutls_certificate_set_x509_key_file'.
6558 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6560 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6561 Update dependencies.
6563 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6565 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6566 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6567 Remove unused parameter `fildes'.
6568 * process.c (read_process_output, send_process): Don't pass it.
6570 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6572 Fix previous change: the library cache is defined in w32.c.
6573 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6574 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6576 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6578 Implement dynamic loading of GnuTLS on Windows.
6580 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6581 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6582 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6585 * gnutls.c (Qgnutls_dll): Define.
6586 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6587 (gnutls_*): Declare function pointers.
6588 (init_gnutls_functions): New function to initialize function pointers.
6589 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6590 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6591 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6592 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6593 (emacs_gnutls_write, emacs_gnutls_read)
6594 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6595 (Fgnutls_available_p): New function.
6596 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6597 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6598 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6600 * image.c: Include w32.h.
6601 (Vimage_type_cache): Delete.
6602 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6603 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6604 (w32_delayed_load): Move to w32.c.
6606 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6608 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6609 (w32_delayed_load): Move from image.c. When loading a library, record
6610 its filename in the :loaded-from property of the library id.
6611 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6612 Initialize and staticpro them.
6613 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6615 * process.c: Include lisp.h before w32.h, not after.
6616 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6617 instead of gnutls_record_check_pending.
6619 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6621 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6623 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6624 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6627 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6629 * xterm.c (x_set_frame_alpha): Do not set property on anything
6630 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6632 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6634 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6636 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6638 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6639 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6640 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6641 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6642 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6643 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6644 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6645 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6646 (Qgnutls_bootprop_callbacks_verify): Make static.
6648 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6650 * callproc.c: Indentation fixup.
6652 * sysdep.c (wait_for_termination_1): Make static.
6653 (wait_for_termination, interruptible_wait_for_termination):
6654 Move after wait_for_termination_1.
6656 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6658 * sysdep.c (interruptible_wait_for_termination): New function
6659 which is like wait_for_termination, but allows keyboard
6662 * callproc.c (Fcall_process): Add (:file "file") as an option for
6664 (Fcall_process_region): Ditto.
6666 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6668 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6669 rather than `XVECTOR (FOO)->size'.
6671 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6672 inttypes.h, as a gnulib replacement is used if it not available in
6675 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6677 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6678 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6679 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6681 * coding.c (coding_alloc_by_realloc): Error out if destination
6682 will grow beyond MOST_POSITIVE_FIXNUM.
6683 (decode_coding_emacs_mule): Abort if there isn't enough place in
6684 charbuf for the composition carryover bytes. Reserve an extra
6685 space for up to 2 characters produced in a loop.
6686 (decode_coding_iso_2022): Abort if there isn't enough place in
6687 charbuf for the composition carryover bytes.
6689 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6691 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6692 aborting when %lld or %lll format is passed.
6693 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6694 %llo or %llx format is passed. (Bug#8545)
6696 * window.c (window_scroll_line_based): Use a marker instead of
6697 simple variables to record original value of point. (Bug#7952)
6699 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6700 produced by %s or %c overflows available buffer space. (Bug#8545)
6702 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6704 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6705 (SIZE_MAX): Move defn after all includes, as they might #define it.
6707 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6709 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6711 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6713 * keyboard.c (Qdelayed_warnings_hook): Define.
6714 (command_loop_1): Run `delayed-warnings-hook'
6715 if Vdelayed_warnings_list is non-nil.
6716 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6717 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6719 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6721 * doprnt.c (doprnt): Don't return value smaller than the buffer
6722 size if the message was truncated. (Bug#8545).
6724 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6726 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6727 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6729 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6731 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6733 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6735 * makefile.w32-in: Update dependencies.
6737 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6739 Improve `doprnt' and its usage. (Bug#8545)
6740 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6741 `format_end'. Remove support for %l as a conversion specifier.
6742 Don't use xrealloc. Improve diagnostics when the %l size modifier
6743 is used. Update the commentary.
6745 * eval.c (verror): Simplify calculation of size_t.
6747 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6750 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6752 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6755 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6757 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6758 This makes this file independent of the recent pseudovector change.
6760 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6762 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6764 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6765 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6766 Remove unused local.
6767 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6769 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6770 GCC 4.6.0 optimizes based on type-based alias analysis.
6771 For example, if b is of type struct buffer * and v of type struct
6772 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6773 != &v->size, and therefore "v->size = 1; b->size = 2; return
6774 v->size;" must therefore return 1. This assumption is incorrect
6775 for Emacs, since it type-puns struct Lisp_Vector * with many other
6776 types. To fix this problem, this patch adds a new type struct
6777 vectorlike_header that documents the constraints on layout of vectors
6778 and pseudovectors, and helps optimizing compilers not get fooled
6779 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6780 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6781 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6783 (XSETPVECTYPE): Rewrite in terms of new macro.
6784 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6785 This is a bit clearer, and further avoids the possibility of
6786 undesirable aliasing.
6787 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6788 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6789 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6790 since Lisp_Subr is a special case (no "next" field).
6791 (ASIZE): Now uses header.size rather than size.
6792 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6793 to avoid the hassle of writing XVECTOR (foo)->header.size.
6794 (struct vectorlike_header): New type.
6795 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6796 object, to help avoid aliasing.
6797 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6798 (SUBRP): Likewise, since Lisp_Subr is a special case.
6799 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6800 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6801 (struct Lisp_Hash_Table): Combine first two members into a single
6802 struct vectorlike_header member. All uses of "size" and "next" members
6803 changed to be "header.size" and "header.next".
6804 * buffer.h (struct buffer): Likewise.
6805 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6806 * frame.h (struct frame): Likewise.
6807 * process.h (struct Lisp_Process): Likewise.
6808 * termhooks.h (struct terminal): Likewise.
6809 * window.c (struct save_window_data, struct saved_window): Likewise.
6810 * window.h (struct window): Likewise.
6811 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6812 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6813 * buffer.c (init_buffer_once): Likewise.
6814 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6816 * process.c (Fformat_network_address): Use local var for size,
6819 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6821 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6822 * data.c (atof): Remove decl; no longer used or needed.
6823 (digit_to_number): Move to lread.c.
6824 (Fstring_to_number): Use new string_to_number function, to be
6825 consistent with how the Lisp reader treats infinities and NaNs.
6826 Do not assume that floating-point numbers represent EMACS_INT
6827 without losing information; this is not true on most 64-bit hosts.
6828 Avoid double-rounding errors, by insisting on integers when
6829 parsing non-base-10 numbers, as the documentation specifies.
6830 * lisp.h (string_to_number): New decl, replacing ...
6831 (isfloat_string): Remove.
6832 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6833 (read1): Do not accept +. and -. as integers; this
6834 appears to have been a coding error. Similarly, do not accept
6835 strings like +-1e0 as floating point numbers. Do not report
6836 overflow for integer overflows unless the base is not 10 which
6837 means we have no simple and reliable way to continue.
6838 Break out the floating-point parsing into a new
6839 function string_to_number, so that Fstring_to_number parses
6840 floating point numbers consistently with the Lisp reader.
6841 (digit_to_number): Move here from data.c. Make it static inline.
6842 (E_CHAR, EXP_INT): Remove, replacing with ...
6843 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6844 (string_to_number): New function, replacing isfloat_string.
6845 This function checks for valid syntax and produces the resulting
6846 Lisp float number too. Rework it so that string-to-number
6847 no longer mishandles examples like "1.0e+". Use strtoumax,
6848 so that overflow for non-base-10 numbers is reported only when
6849 there's no portable and simple way to convert to floating point.
6851 * textprop.c (set_text_properties_1): Rewrite for clarity,
6852 and to avoid GCC warning about integer overflow.
6854 * intervals.h (struct interval): Use EMACS_INT for members
6855 where EMACS_UINT might cause problems. See
6856 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6857 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6858 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6860 (offset_intervals): Tell GCC not to worry about length overflow
6861 when negating a negative length.
6863 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6864 (overrun_check_free): Likewise.
6866 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6867 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6870 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6871 (gnutls_make_error): Rename local to avoid shadowing.
6872 (gnutls_emacs_global_deinit): ifdef out; not used.
6873 (Fgnutls_boot): Use const for pointer to readonly storage.
6874 Comment out unused local. Fix pointer signedness problems.
6876 * lread.c (openp): Don't stuff size_t into an 'int'.
6877 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6878 about possible signed overflow.
6880 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6881 (GDK_KEY_g): Don't define if already defined.
6882 (xg_prepare_tooltip): Avoid pointer signedness problem.
6883 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6885 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6886 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6888 * xfns.c (Fx_window_property): Simplify a bit,
6889 to make a bit faster and to avoid GCC 4.6.0 warning.
6890 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6892 * fns.c (internal_equal): Don't assume size_t fits in int.
6894 * alloc.c (compact_small_strings): Tighten assertion a little.
6896 Replace pEd with more-general pI, and fix some printf arg casts.
6897 * lisp.h (pI): New macro, generalizing old pEd macro to other
6898 conversion specifiers. For example, use "...%"pI"d..." rather
6899 than "...%"pEd"...".
6900 (pEd): Remove. All uses replaced with similar uses of pI.
6901 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6902 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6903 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6904 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6905 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6906 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6907 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6909 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6910 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6911 * print.c (safe_debug_print, print_object): Likewise.
6912 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6914 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6915 avoiding the 0 flag, which is not portable.
6916 * process.c (Fmake_network_process): Use pI to avoid cast.
6917 * region-cache.c (pp_cache): Likewise.
6918 * xdisp.c (decode_mode_spec): Likewise.
6919 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6920 behavior on 64-bit hosts with printf arg.
6921 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6922 (x_stop_queuing_selection_requests): Likewise.
6923 (x_get_window_property): Don't truncate byte count to an 'int'
6926 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6927 here, since it parses constructs like leading '-' and spaces,
6928 which are not wanted; and it overflows with large numbers.
6929 Instead, simply match F[0-9]+, which is what is wanted anyway.
6931 * alloc.c: Remove unportable assumptions about struct layout.
6932 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6933 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6934 (allocate_vectorlike, make_pure_vector): Use the new macros,
6935 plus offsetof, to remove unportable assumptions about struct layout.
6936 These assumptions hold on all porting targets that I know of, but
6937 they are not guaranteed, they're easy to remove, and removing them
6938 makes further changes easier.
6940 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6941 This doesn't fix a bug but makes the code clearer.
6942 (string_overrun_cookie): Now const. Use initializers that
6943 don't formally overflow signed char, to avoid warnings.
6944 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6945 can cause Emacs to crash when string overrun checking is enabled.
6946 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6947 multiple of sizeof (EMACS_INT); it need not be, if
6948 alignof(EMACS_INT) < sizeof (EMACS_INT).
6949 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6951 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6953 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6955 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6957 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6958 supposed to be handshaking. (Bug#8556)
6959 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6961 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6963 * lisp.h (Qdebug): List symbol.
6964 * eval.c (Qdebug): Restore global linkage.
6965 * keyboard.c (debug-on-event): New variable.
6966 (handle_user_signal): Break into debugger when debug-on-event
6967 matches the current signal symbol.
6969 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6971 * alloc.c (check_sblock, check_string_bytes)
6972 (check_string_free_list): Convert to standard C.
6974 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6976 * w32.c (emacs_gnutls_push): Fix typo.
6978 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6980 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6981 "cast to pointer from integer of different size".
6983 Improve doprnt and its use in verror. (Bug#8545)
6984 * doprnt.c (doprnt): Document the set of format control sequences
6985 supported by the function. Use SAFE_ALLOCA instead of always
6988 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6989 is one byte too soon. Don't use xrealloc; instead xfree and
6992 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6994 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6997 * gnutls.c: Renamed global_initialized to
6998 gnutls_global_initialized. Added internals for the
6999 :verify-hostname-error, :verify-error, and :verify-flags
7000 parameters of `gnutls-boot' and documented those parameters in the
7001 docstring. Start callback support.
7002 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7003 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7004 on error. Return error code.
7005 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7006 (emacs_gnutls_read): Likewise.
7007 (Fgnutls_boot): Return handshake error code.
7008 (emacs_gnutls_handle_error): New function.
7009 (wsaerror_to_errno): Likewise.
7011 * w32.h (emacs_gnutls_pull): Add prototype.
7012 (emacs_gnutls_push): Likewise.
7014 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7015 (emacs_gnutls_push): Likewise.
7017 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7019 * process.c (wait_reading_process_output): Check if GnuTLS
7020 buffered some data internally if no FDs are set for TLS
7023 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7024 (LIBS): Link to USER_LIBS.
7025 ($(BLD)/gnutls.$(0)): New target.
7027 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7029 * xdisp.c (handle_single_display_spec): Rename the
7030 display_replaced_before_p argument into display_replaced_p, to
7031 make it consistent with the commentary. Fix typos in the
7034 * textprop.c (syms_of_textprop): Remove dead code.
7035 (copy_text_properties): Delete obsolete commentary about an
7036 interface that was deleted long ago. Fix typos in the description
7039 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7040 to changes in oldXMenu/XMenu.h from 2011-04-16.
7041 <menu_help_message, prev_menu_help_message>: Constify.
7042 (IT_menu_make_room): menu->help_text is now `const char **';
7045 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7046 to changes in oldXMenu/XMenu.h from 2011-04-16.
7047 (struct XMenu): Declare `help_text' `const char **'.
7049 * xfaces.c <Qunspecified>: Make extern again.
7051 * syntax.c: Include sys/types.h before including regex.h, as
7054 * doc.c (get_doc_string): Improve the format passed to `error'.
7056 * doprnt.c (doprnt): Improve commentary.
7058 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7060 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7063 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7064 changes in globals.h immediately force recompilation.
7065 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7066 $(CURDIR)/s/ms-w32.h.
7067 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7069 * character.c (Fchar_direction): Function deleted.
7070 (syms_of_character): Don't defsubr it.
7071 <char-direction-table>: Deleted.
7073 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7075 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7076 * doprnt.c: Include limits.h.
7077 (SIZE_MAX): New macro.
7078 (doprnt): Return a size_t value. 2nd arg is now size_t.
7079 Many local variables are now size_t instead of int or unsigned.
7080 Improve overflow protection. Support `l' modifier for integer
7081 conversions. Support %l conversion. Don't assume an EMACS_INT
7082 argument for integer conversions and for %c.
7084 * lisp.h (doprnt): Restore prototype.
7086 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7089 * Makefile.in (base_obj): Add back doprnt.o.
7091 * deps.mk (doprnt.o): Add back prerequisites.
7092 (callint.o): Depend on character.h.
7094 * eval.c (internal_lisp_condition_case): Include the handler
7095 representation in the error message.
7096 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7097 when breaking from the loop.
7099 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7101 * callint.c (Fcall_interactively): When displaying error message
7102 about invalid control letter, pass the character's codepoint, not
7103 a pointer to its multibyte form. Improve display of the character
7104 in octal and display also its hex code.
7106 * character.c (char_string): Use %x to display the (unsigned)
7107 codepoint of an invalid character, to avoid displaying a bogus
7110 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7111 `error', not SYMBOL_NAME itself.
7113 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7114 character arguments to `error'.
7116 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7117 to `error' in error message about FINAL_CHAR argument. Make sure
7118 FINAL_CHAR is a character, and use %c when it is passed as
7119 argument to `error'.
7121 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7123 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7125 * w32.c: Include <time.h>.
7126 (sys_localtime): New function.
7128 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7130 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7132 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7134 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7136 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7139 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7141 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7142 gl_state.e_property when gl_state.object is Qt.
7144 * insdel.c (make_gap_larger): Remove limitation of buffer size
7147 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7149 * xdisp.c (lookup_glyphless_char_display)
7150 (produce_glyphless_glyph): Handle cons cell entry in
7151 glyphless-char-display.
7152 (Vglyphless_char_display): Document it.
7154 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7155 glyphless-char-display.
7157 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7159 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7161 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7163 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7164 definition for no-X builds.
7166 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7168 Static checks with GCC 4.6.0 and non-default toolkits.
7170 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7172 * process.c (keyboard_bit_set): Define only if SIGIO.
7173 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7174 (send_process): Repair possible setjmp clobbering.
7176 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7178 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7180 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7182 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7183 Define only if needed.
7185 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7186 by pacifying GCC about it. Maybe it's time to retire it?
7187 * xfaces.c (USG, __TIMEVAL__): Likewise.
7189 * dispextern.h (struct redisplay_interface): Rename param
7191 * termhooks.h (struct terminal): Likewise.
7192 * xterm.c (xembed_send_message): Likewise.
7194 * insdel.c (make_gap_smaller): Define only if
7195 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7197 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7200 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7201 so that we aren't warned about unused symbols.
7203 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7205 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7207 * xfns.c (x_real_positions): Mark locals as initialized.
7209 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7211 * xterm.c: Fix problems found by static analysis with other toolkits.
7212 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7213 (x_dispatch_event): Declare static if USE_GTK, and
7214 define if USE_GTK || USE_X_TOOLKIT.
7215 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7216 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7217 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7218 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7220 * xmenu.c (menu_help_callback): Pointer type fixes.
7221 Use const pointers when pointing at readonly data. Avoid pointer
7223 (FALSE): Remove unused macro.
7224 (update_frame_menubar): Remove unused decl.
7226 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7228 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7229 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7230 (single_menu_item): Rename local to avoid shadowing.
7232 * keyboard.c (make_lispy_event): Remove unused local var.
7234 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7235 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7237 * bitmaps: Change bitmaps from unsigned char back to the X11
7238 compatible char. Avoid the old compiler warnings about
7239 out-of-range initializers by using, for example, '\xab' rather
7242 * xgselect.c (xgselect_initialize): Check vs interface
7243 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7245 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7247 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7248 to read-only memory.
7250 * fns.c (vector): Remove; this old hack is no longer needed.
7252 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7254 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7256 * xrdb.c (x_load_resources): Omit unused local.
7258 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7259 (x_window): Rename locals to avoid shadowing.
7260 (USG): Use the kludged USG macro, to pacify gcc.
7262 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7263 (x_term_init): Remove local to avoid shadowing.
7265 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7267 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7268 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7270 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7272 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7274 Fix regex.c, syntax.c and friends for buffers > 2GB.
7275 * syntax.h (struct gl_state_s): Declare character position members
7278 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7280 * textprop.c (verify_interval_modification, interval_of):
7281 Declare arguments EMACS_INT.
7283 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7286 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7288 * indent.c (Fvertical_motion): Local variable it_start is now
7291 * regex.c (re_match, re_match_2, re_match_2_internal)
7292 (bcmp_translate, regcomp, regexec, print_double_string)
7293 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7294 (re_compile_pattern, re_exec): Declare arguments and local
7295 variables `size_t' and `ssize_t' and return values `regoff_t', as
7297 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7298 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7299 <compile_stack_type>: `size' and `avail' are now `size_t'.
7301 * regex.h <regoff_t>: Use ssize_t, not int.
7302 (re_search, re_search_2, re_match, re_match_2): Arguments that
7303 specify buffer/string position and length are now ssize_t and
7304 size_t. Return type is regoff_t.
7306 2011-04-16 Ben Key <bkey76@gmail.com>
7308 * nsfont.m: Fixed bugs in ns_get_family and
7309 ns_descriptor_to_entity that were caused by using free to
7310 deallocate memory blocks that were allocated by xmalloc (via
7311 xstrdup). This caused Emacs to crash when compiled with
7312 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7313 --enable-checking=xmallocoverrun). xfree is now used to
7314 deallocate these memory blocks.
7316 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7318 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7320 emacs_write: Accept and return EMACS_INT for sizes.
7321 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7323 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7324 Accept and return EMACS_INT.
7325 (emacs_gnutls_write): Return the number of bytes written on
7327 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7328 (emacs_read, emacs_write): Remove check for negative size, as the
7329 Emacs source code has been audited now.
7330 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7331 (emacs_read, emacs_write): Use it.
7332 * process.c (send_process): Adjust to the new signatures of
7333 emacs_write and emacs_gnutls_write. Do not attempt to store
7334 a byte offset into an 'int'; it might overflow.
7335 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7337 * sound.c: Don't assume sizes fit in 'int'.
7338 (struct sound_device.period_size, alsa_period_size):
7339 Return EMACS_INT, not int.
7340 (struct sound_device.write, vox_write, alsa_write):
7341 Accept EMACS_INT, not int.
7342 (wav_play, au_play): Use EMACS_INT to store sizes and to
7343 record read return values.
7345 2011-04-15 Ben Key <bkey76@gmail.com>
7347 * keyboard.c (Qundefined): Don't declare static since it is used
7349 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7350 static since they are used in nsfont.m.
7352 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7354 * process.c (Qprocessp): Don't declare static.
7355 * lisp.h (Qprocessp): Declare again.
7357 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7359 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7361 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7363 Improve C-level modularity by making more things 'static'.
7365 Don't publish debugger-only interfaces to other modules.
7366 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7367 (verify_bytepos, count_markers): Move decls to the only modules
7369 * region-cache.h (pp_cache): Likewise.
7370 * window.h (check_all_windows): Likewise.
7371 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7373 * sysdep.c (croak): Now static, if
7374 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7375 * syssignal.h (croak): Declare only if not static.
7377 * alloc.c (refill_memory_reserve): Now static if
7378 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7379 * lisp.h (refill_memory_reserve): Declare only if not static.
7381 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7382 Define only if USE_LUCID.
7384 * xrdb.c (x_customization_string, x_rm_string): Now static.
7386 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7387 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7389 * xdisp.c (draw_row_with_mouse_face): Now static.
7390 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7392 * window.h (check_all_windows): Mark externally visible.
7394 * window.c (window_deletion_count): Now static.
7396 * undo.c: Make symbols static if they're not exported.
7397 (last_undo_buffer, last_boundary_position, pending_boundary):
7400 * textprop.c (interval_insert_behind_hooks): Now static.
7401 (interval_insert_in_front_hooks): Likewise.
7403 * term.c: Make symbols static if they're not exported.
7404 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7405 (max_frame_lines, tty_set_terminal_modes):
7406 (tty_reset_terminal_modes, tty_turn_off_highlight):
7407 (get_tty_terminal): Now static.
7408 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7409 * termhooks.h (term_mouse_moveto): Do not declare if
7411 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7412 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7414 * sysdep.c: Make symbols static if they're not exported.
7415 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7417 (sigprocmask_set, full_mask): Remove; unused.
7418 (wait_debugging): Mark as visible.
7419 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7420 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7422 * syntax.c (syntax_temp): Define only if !__GNUC__.
7424 * sound.c (current_sound_device, current_sound): Now static.
7426 * search.c (searchbufs, searchbuf_head): Now static.
7428 * scroll.c (scroll_cost): Remove; unused.
7429 * dispextern.h (scroll_cost): Remove decl.
7431 * region-cache.h (pp_cache): Mark as externally visible.
7433 * process.c: Make symbols static if they're not exported.
7434 (process_tick, update_tick, create_process, chan_process):
7435 (Vprocess_alist, proc_buffered_char, datagram_access):
7436 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7437 (deactivate_process): Mark defn as static, as well as decl.
7438 * lisp.h (create_process): Remove decl.
7439 * process.h (chan_process, Vprocess_alist): Remove decls.
7441 * print.c: Make symbols static if they're not exported.
7442 (print_depth, new_backquote_output, being_printed, print_buffer):
7443 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7444 (print_interval, print_number_index, initial_stderr_stream):
7446 * lisp.h (Fprinc): Remove decl.
7447 (debug_output_compilation_hack): Mark as externally visible.
7449 * sysdep.c (croak): Move decl from here to syssignal.h.
7450 * syssignal.h (croak): Put it here, so the API can be checked when
7451 'croak' is called from dissociate_if_controlling_tty.
7453 * minibuf.c: Make symbols static if they're not exported.
7454 (minibuf_save_list, choose_minibuf_frame): Now static.
7455 * lisp.h (choose_minibuf_frame): Remove decl.
7457 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7459 * lread.c: Make symbols static if they're not exported.
7460 (read_objects, initial_obarray, oblookup_last_bucket_number):
7462 (make_symbol): Remove; unused.
7463 * lisp.h (initial_obarray, make_symbol): Remove decls.
7465 * keyboard.c: Make symbols static if they're not exported.
7466 (single_kboard, recent_keys_index, total_keys, recent_keys):
7467 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7468 (this_single_command_key_start, echoing, last_auto_save):
7469 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7470 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7471 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7472 (Vlispy_mouse_stem, double_click_count):
7474 (force_auto_save_soon): Define only if SIGDANGER.
7475 (ignore_mouse_drag_p): Now static if
7476 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7477 (print_help): Remove; unused.
7478 (stop_character, last_timer_event): Mark as externally visible.
7479 * keyboard.h (ignore_mouse_drag_p): Declare only if
7480 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7481 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7482 * lisp.h (echoing): Remove decl.
7483 (force_auto_save_soon): Declare only if SIGDANGER.
7484 * xdisp.c (redisplay_window): Simplify code, to make it more
7485 obvious that ignore_mouse_drag_p is not accessed if !defined
7486 USE_GTK && !defined HAVE_NS.
7488 * intervals.c: Make symbols static if they're not exported.
7489 (merge_properties_sticky, merge_interval_right, delete_interval):
7491 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7493 * insdel.c: Make symbols static if they're not exported.
7494 However, leave prepare_to_modify_buffer alone. It's never
7495 called from outside this function, but that appears to be a bug.
7496 (combine_after_change_list, combine_after_change_buffer):
7497 (adjust_after_replace, signal_before_change): Now static.
7498 (adjust_after_replace_noundo): Remove; unused.
7499 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7500 (signal_before_change): Remove decls.
7502 * indent.c (val_compute_motion, val_vmotion): Now static.
7504 * image.c: Make symbols static if they're not exported.
7505 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7507 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7508 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7510 * fringe.c (standard_bitmaps): Now static.
7511 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7513 * frame.c: Make symbols static if they're not exported.
7514 (x_report_frame_params, make_terminal_frame): Now static.
7515 (get_frame_param): Now static, unless HAVE_NS.
7516 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7517 (x_get_resource_string): Remove; not used.
7518 * frame.h (make_terminal_frame, x_report_frame_params):
7519 (x_get_resource_string); Remove decls.
7520 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7521 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7523 * font.c, fontset.c: Make symbols static if they're not exported.
7524 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7525 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7526 * font.c (font_close_object): Now static.
7527 * font.h (font_close_object): Remove.
7528 * fontset.c (FONTSET_OBJLIST): Remove.
7529 (free_realized_fontset) #if-0 the body, which does nothing.
7530 (face_suitable_for_char_p): #if-0, as it's never called.
7531 * fontset.h (face_suitable_for_char_p): Remove decl.
7532 * xfaces.c (face_at_string_position):
7533 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7534 since 0 is always ASCII.
7536 * fns.c (weak_hash_tables): Now static.
7538 * fileio.c: Make symbols static if they're not exported.
7539 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7540 (Vwrite_region_annotation_buffers): Now static.
7542 * eval.c: Make symbols static if they're not exported.
7543 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7544 * lisp.h (backtrace_list): Remove decl.
7546 * emacs.c: Make symbols static if they're not exported.
7547 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7548 (fatal_error_code, fatal_error_signal_hook, standard_args):
7550 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7551 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7552 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7553 * lisp.h (fatal_error_signal_hook): Remove decl.
7554 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7556 * editfns.c: Move a (normally-unused) function to its only use.
7557 * editfns.c, lisp.h (get_operating_system_release): Remove.
7558 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7559 worth the hassle of breaking this out.
7561 * xterm.c: Make symbols static if they're not exported.
7562 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7563 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7564 (x_destroy_window, x_delete_display):
7566 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7567 (x_mouse_leave): Remove; unused.
7568 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7569 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7570 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7572 (x_mouse_leave): Declare only if WINDOWSNT.
7573 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7574 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7577 * ftxfont.c: Make symbols static if they're not exported.
7578 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7580 * font.h (ftxfont_driver): Likewise.
7582 * xfns.c: Make symbols static if they're not exported.
7583 (x_last_font_name, x_display_info_for_name):
7584 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7585 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7586 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7587 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7588 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7589 (last_show_tip_args): Now static.
7590 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7591 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7592 (x_screen_planes): Remove; unused.
7593 * dispextern.h (x_screen_planes): Remove decl.
7595 * dispnew.c: Make symbols static if they're not exported.
7596 * dispextern.h (redraw_garbaged_frames, scrolling):
7597 (increment_row_positions): Remove.
7598 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7599 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7601 (redraw_garbaged_frames): Remove; unused.
7603 * xfaces.c: Make symbols static if they're not exported.
7604 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7606 * xterm.h (defined_color): Remove decls.
7607 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7608 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7609 (menu_face_changed_default, defined_color, free_realized_face):
7610 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7611 (ascii_face_of_lisp_face): Remove; unused.
7613 * xdisp.c: Make symbols static if they're not exported.
7614 * dispextern.h (scratch_glyph_row, window_box_edges):
7615 (glyph_to_pixel_coords, set_cursor_from_row):
7616 (get_next_display_element, set_iterator_to_next):
7617 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7618 (show_mouse_face): Remove decls
7619 * frame.h (message_buf_print): Likewise.
7620 * lisp.h (pop_message, set_message, check_point_in_composition):
7622 * xterm.h (set_vertical_scroll_bar): Likewise.
7623 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7624 (message_buf_print, scratch_glyph_row, displayed_buffer):
7625 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7626 (get_next_display_element, show_mouse_face, window_box_edges):
7627 (frame_to_window_pixel_xy, check_point_in_composition):
7628 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7629 (glyph_to_pixel_coords): Remove; unused.
7631 * dired.c (file_name_completion): Now static.
7633 * dbusbind.c (xd_in_read_queued_messages): Now static.
7635 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7636 * data.c (circular_list_error): Remove.
7638 * commands.h (last_point_position, last_point_position_buffer):
7639 (last_point_position_window): Remove decls.
7640 * keyboard.c: Make these variables static.
7642 * coding.h (coding, code_convert_region, encode_coding_gap):
7644 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7645 (iso_code_class, detect_coding, code_convert_region): Now static.
7646 (encode_coding_gap): Remove; unused.
7648 * chartab.c (chartab_chars, chartab_bits): Now static.
7650 * charset.h (charset_iso_8859_1): Remove decl.
7651 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7654 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7655 * ccl.c (Vccl_program_table): Now static.
7656 (check_ccl_update): Remove; unused.
7658 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7659 * category.h: ... from here.
7660 * category.c (check_category_table, set_category_set): Now static.
7662 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7663 * lisp.h: Remove these decls.
7665 * buffer.c (buffer_count): Remove unused var.
7667 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7668 so that it's not optimized away.
7669 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7670 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7671 exported only to the debugger.
7673 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7674 * atimer.h (run_all_atimers): Remove; not exported.
7676 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7677 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7678 was inaccessible from Lisp.
7679 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7680 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7682 alloc.c: Import and export fewer symbols, and remove unused items.
7683 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7685 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7686 it's not optimized away by whole-program optimization.
7687 (message_enable_multibyte, free_misc): Remove.
7688 (catchlist, handlerlist, mark_backtrace):
7689 Declare only if BYTE_MARK_STACK.
7690 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7691 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7692 (message_enable_multibyte): Remove decl.
7693 (free_misc, interval_free_list, float_block, float_block_index):
7694 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7695 (cons_free_list, last_marked_index):
7697 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7698 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7699 (mark_backtrace): Define only if BYTE_MARK_STACK.
7700 * xdisp.c (message_enable_multibyte): Now static.
7702 Declare Lisp_Object Q* variables to be 'static' if not exported.
7703 This makes it easier for human readers (and static analyzers)
7704 to see whether these variables are used from other modules.
7705 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7706 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7707 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7708 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7709 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7710 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7711 * xmenu.c, xselect.c:
7712 Declare Q* vars static if they are not used in other modules.
7713 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7714 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7715 Remove decls of unexported vars.
7716 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7718 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7720 Make Emacs functions such as Fatom 'static' by default.
7721 This makes it easier for human readers (and static analyzers)
7722 to see whether these functions can be called from other modules.
7723 DEFUN now defines a static function. To make the function external
7724 so that it can be used in other C modules, use the new macro DEFUE.
7725 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7726 (Finit_image_library):
7727 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7728 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7729 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7730 Remove decls, since these functions are now static.
7731 (Funintern, Fget_internal_run_time): New decls, since these functions
7732 were already external.
7734 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7735 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7736 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7737 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7738 * keyboard.c, keymap.c, lread.c:
7739 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7740 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7741 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7742 Mark functions with DEFUE instead of DEFUN,
7743 if they are used in other modules.
7744 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7745 decls for now-static functions.
7746 * buffer.h (Fdelete_overlay): Remove decl.
7747 * callproc.c (Fgetenv_internal): Mark as internal.
7748 * composite.c (Fremove_list_of_text_properties): Remove decl.
7749 (Fcomposition_get_gstring): New forward static decl.
7750 * composite.h (Fcomposite_get_gstring): Remove decl.
7751 * dired.c (Ffile_attributes): New forward static decl.
7752 * doc.c (Fdocumntation_property): New forward static decl.
7753 * eval.c (Ffetch_bytecode): New forward static decl.
7754 (Funintern): Remove extern decl; now in .h file where it belongs.
7755 * fileio.c (Fmake_symbolic_link): New forward static decl.
7756 * image.c (Finit_image_library): New forward static decl.
7757 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7758 * intervals.h (Fprevious_property_change):
7759 (Fremove_list_of_text_properties): Remove decls.
7760 * keyboard.c (Fthis_command_keys): Remove decl.
7761 (Fcommand_execute): New forward static decl.
7762 * keymap.c (Flookup_key): New forward static decl.
7763 (Fcopy_keymap): Now static.
7764 * keymap.h (Flookup_key): Remove decl.
7765 * process.c (Fget_process): New forward static decl.
7766 (Fprocess_datagram_address): Mark as internal.
7767 * syntax.c (Fsyntax_table_p): New forward static decl.
7768 (skip_chars): Remove duplicate decl.
7769 * textprop.c (Fprevious_property_change): New forward static decl.
7770 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7772 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7773 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7775 * editfns.c (Fformat): Remove unreachable code.
7777 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7779 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7782 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7784 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7785 when at ZV. (Bug#8487)
7787 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7789 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7791 * keyboard.c (parse_tool_bar_item): Likewise.
7792 * sound.c (sound_cleanup, alsa_close): Likewise.
7793 * termcap.c (tgetent): Likewise.
7794 * xfns.c (x_default_font_parameter): Likewise.
7795 * xsettings.c (read_and_apply_settings): Likewise.
7797 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7798 (overrun_check_free): Protoize.
7800 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7802 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7803 since callers should never pass a negative size.
7804 Change the signature to match that of plain 'read' and 'write'; see
7805 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7806 * lisp.h: Update prototypes of emacs_write and emacs_read.
7808 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7810 * xdisp.c (redisplay_window): Don't try to determine the character
7811 position of the scroll margin if the window start point w->startp
7812 is outside the buffer's accessible region. (Bug#8468)
7814 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7816 Fix write-region and its subroutines for buffers > 2GB.
7817 * fileio.c (a_write, e_write): Modify declaration of arguments and
7818 local variables to support buffers larger than 2GB.
7819 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7821 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7822 argument, local variables, and return value.
7824 * lisp.h: Update prototypes of emacs_write and emacs_read.
7826 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7828 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7830 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7832 Fix more problems found by GCC 4.6.0's static checks.
7834 * xdisp.c (vmessage): Use a better test for character truncation.
7836 * charset.c (load_charset_map): <, not <=, for optimization,
7837 and to avoid potential problems with integer overflow.
7838 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7839 * casetab.c (set_identity, shuffle): Likewise.
7840 * editfns.c (Fformat): Likewise.
7841 * syntax.c (skip_chars): Likewise.
7843 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7844 This also lets GCC 4.6.0 generate slightly better loop code.
7846 * callint.c (Fcall_interactively): <, not <=, for optimization.
7847 (Fcall_interactively): Count the number of arguments produced,
7848 not the number of arguments given. This is simpler and lets GCC
7849 4.6.0 generate slightly better code.
7851 * ftfont.c: Distingish more carefully between FcChar8 and char.
7852 The previous code passed unsigned char * to a functions like
7853 strlen and xstrcasecmp that expect char *, which does not
7854 conform to the C standard.
7855 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7856 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7857 char * when the C standard requires it.
7859 * keyboard.c (read_char): Remove unused var.
7861 * eval.c: Port to Windows vsnprintf (Bug#8435).
7863 (SIZE_MAX): Define if the headers do not.
7864 (verror): Do not give up if vsnprintf returns a negative count.
7865 Instead, grow the buffer. This ports to Windows vsnprintf, which
7866 does not conform to C99. Problem reported by Eli Zaretskii.
7867 Also, simplify the allocation scheme, by avoiding the need for
7868 calling realloc, and removing the ALLOCATED variable.
7870 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7872 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7873 But keep the doprint source code for now, as we might revamp it
7874 and use it again (Bug#8435).
7875 * lisp.h (doprnt): Remove.
7876 * Makefile.in (base_obj): Remove doprnt.o.
7877 * deps.mk (doprnt.o): Remove.
7879 error: Print 32- and 64-bit integers portably (Bug#8435).
7880 Without this change, on typical 64-bit hosts error ("...%d...", N)
7881 was used to print both 32- and 64-bit integers N, which relied on
7883 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7884 * lisp.h (error, verror): Mark as printf-like functions.
7885 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7886 Report overflow in size calculations when allocating printf buffer.
7887 Do not truncate output string at its first null byte.
7888 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7889 Truncate the output at a character boundary, since vsnprintf does not
7891 * charset.c (check_iso_charset_parameter): Convert internal
7892 character to string before calling 'error', since %c now has the
7894 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7895 overflow when computing char to be passed to 'error'. Do not
7896 pass Lisp_Object to 'error'; pass the integer instead.
7897 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7898 formatted with plain %d.
7900 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7902 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7904 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7906 * xterm.c (x_catch_errors): Remove duplicate declaration.
7908 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7910 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7912 2011-04-10 Jim Meyering <meyering@redhat.com>
7914 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7915 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7916 return ssize_t not "int", and use size_t as the buffer length.
7917 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7918 * gnutls.h: Update declarations.
7919 * process.c (read_process_output): Use ssize_t, to match.
7920 (send_process): Likewise.
7922 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7924 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7926 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7928 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7929 Use unsigned char, to match FcChar8 type definition.
7931 * xterm.c (handle_one_xevent):
7932 * xmenu.c (create_and_show_popup_menu):
7933 * xselect.c (x_decline_selection_request)
7934 (x_reply_selection_request): Avoid type-punned deref of X events.
7936 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7938 Fix some uses of `int' instead of EMACS_INT.
7939 * search.c (string_match_1, fast_string_match)
7940 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7941 (scan_buffer, find_next_newline_no_quit)
7942 (find_before_next_newline, search_command, Freplace_match)
7943 (Fmatch_data): Make some `int' variables be EMACS_INT.
7945 * xdisp.c (display_count_lines): 3rd argument and return value now
7946 EMACS_INT. All callers changed.
7947 (pint2hrstr): Last argument is now EMACS_INT.
7949 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7950 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7951 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7952 (decode_coding_utf_16, decode_coding_emacs_mule)
7953 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7954 (decode_coding_ccl, decode_coding_charset)
7955 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7956 (decode_coding_iso_2022, decode_coding_emacs_mule)
7957 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7958 <char_offset, last_offset>: Declare EMACS_INT.
7959 (encode_coding_utf_8, encode_coding_utf_16)
7960 (encode_coding_emacs_mule, encode_invocation_designation)
7961 (encode_designation_at_bol, encode_coding_iso_2022)
7962 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7963 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7965 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7966 (encode_invocation_designation): Last argument P_NCHARS is now
7968 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7969 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7971 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7974 * ccl.c (Fccl_execute_on_string): Declare some variables
7977 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7979 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7981 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7983 * process.c (Fformat_network_address): Doc fix.
7985 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7987 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7989 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7991 * keyboard.c (read_char): Call Lisp function help-form-show,
7992 instead of using internal_with_output_to_temp_buffer.
7993 (Qhelp_form_show): New var.
7994 (syms_of_keyboard): Use DEFSYM macro.
7996 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7998 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8000 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8002 * process.c (Flist_processes): Remove to Lisp.
8003 (list_processes_1): Delete.
8005 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8007 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8009 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8011 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8013 Fix more problems found by GCC 4.6.0's static checks.
8015 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8017 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8019 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8021 * xdisp.c (vmessage): Mark as a printf-like function.
8023 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8025 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8027 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8028 printf-like functions.
8029 (tiff_load): Add casts to remove these marks before passing them
8030 to system-supplied API.
8032 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8034 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8035 This avoids several warnings with gcc -Wstrict-overflow.
8036 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8037 directly, rather than having caller test rule sign. This avoids
8038 some unnecessary tests.
8039 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8040 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8041 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8043 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8044 (xfont_open): Avoid unnecessary tests.
8046 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8048 * composite.h, composite.c (composition_gstring_put_cache):
8049 Use EMACS_INT, not int, for length.
8051 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8052 breaking out part of COMPOSITION_DECODE_RULE.
8053 (COMPOSITION_DECODE_RULE): Use it.
8054 * composite.c (get_composition_id): Remove unused local vars,
8055 by using the new macro.
8057 * textprop.c (set_text_properties_1): Change while to do-while,
8058 since the condition is always true at first.
8060 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8061 (interval_deletion_adjustment): Return unsigned value.
8064 * process.c (list_processes_1, create_pty, read_process_output):
8065 (exec_sentinel): Remove vars that were set but not used.
8066 (create_pty): Remove unnecessary "volatile"s.
8067 (Fnetwork_interface_info): Avoid possibility of int overflow.
8068 (read_process_output): Do adaptive read buffering even if carryover.
8069 (read_process_output): Simplify nbytes computation if buffered.
8071 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8073 * syntax.c (scan_words): Remove var that was set but not used.
8074 (update_syntax_table): Use unsigned instead of int.
8076 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8077 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8078 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8080 * print.c (print_error_message): Avoid int overflow.
8082 * font.c (font_list_entities): Redo for clarity,
8083 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8085 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8086 (font_score): Avoid potential overflow in diff calculation.
8088 * fns.c (substring_both): Remove var that is set but not used.
8089 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8091 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8093 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8094 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8095 can always succeed if overflow has undefined behavior.
8097 * search.c (boyer_moore, wordify): Remove vars set but not used.
8098 (wordify): Omit three unnecessary tests.
8100 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8101 All callers changed. This avoids the need for an unused var.
8103 * casefiddle.c (casify_region): Remove var that is set but not used.
8105 * dired.c (file_name_completion): Remove var that is set but not used.
8107 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8109 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8110 (Finsert_file_contents): Remove unnecessary code checking fd.
8112 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8113 Check for integer overflow on size calculations.
8115 * buffer.c (Fprevious_overlay_change): Remove var that is set
8118 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8119 Remove vars that are set but not used.
8120 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8121 (timer_check_2): Mark vars as initialized.
8123 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8125 * image.c (lookup_image): Remove var that is set but not used.
8126 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8128 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8129 that are set but not used.
8131 * xfns.c (make_invisible_cursor): Don't return garbage
8132 if XCreateBitmapFromData fails (Bug#8410).
8134 * xselect.c (x_get_local_selection, x_handle_property_notify):
8135 Remove vars that are set but not used.
8137 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8138 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8140 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8141 Remove var that is set but not used.
8142 (scroll_bar_windows_size): Now size_t, not int.
8143 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8146 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8147 (map_tty_color) [!defined MSDOS]: Likewise.
8149 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8151 * coding.c: Remove vars that are set but not used.
8152 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8153 All callers changed.
8154 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8155 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8156 (decode_coding_charset): Remove vars that are set but not used.
8158 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8159 that is set but not used.
8161 * print.c (print_object): Remove var that is set but not used.
8163 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8164 The gnulib version avoids calling malloc in the usual case,
8165 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8166 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8167 * filelock.c (current_lock_owner): Likewise.
8168 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8169 * sysdep.c: Include allocator.h, careadlinkat.h.
8170 (emacs_no_realloc_allocator): New static constant.
8171 (emacs_readlink): New function.
8172 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8173 ../lib/careadlinkat.h.
8175 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8177 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8178 first non-nil return value).
8180 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8182 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8183 if not defined (Bug#8403).
8185 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8187 * xdisp.c (display_count_lines): Remove parameter `start',
8188 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8189 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8190 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8191 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8192 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8193 and thereabouts. All callers changed.
8194 (get_per_char_metric): Remove parameter `f', unused since
8195 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8197 2011-04-02 Jim Meyering <meyering@redhat.com>
8199 do not dereference NULL upon failed strdup
8200 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8201 (ns_get_family): Likewise.
8203 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8205 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8207 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8209 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8212 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8214 Add lexical binding.
8216 * window.c (Ftemp_output_buffer_show): New fun.
8217 (Fsave_window_excursion):
8218 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8220 * lread.c (lisp_file_lexically_bound_p): New function.
8221 (Fload): Bind Qlexical_binding.
8222 (readevalloop): Remove `evalfun' arg.
8223 Bind Qinternal_interpreter_environment.
8224 (Feval_buffer): Bind Qlexical_binding.
8225 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8227 (syms_of_lread): Declare `lexical-binding'.
8229 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8231 * keyboard.c (eval_dyn): New fun.
8232 (menu_item_eval_property): Use it.
8234 * image.c (parse_image_spec): Use Ffunctionp.
8236 * fns.c (concat, mapcar1): Accept byte-code-functions.
8238 * eval.c (Fsetq): Handle lexical vars.
8239 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8240 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8241 (FletX, Flet): Obey lexical binding.
8242 (Fcommandp): Handle closures.
8243 (Feval): New `lexical' arg.
8244 (eval_sub): New function extracted from Feval. Use it almost
8245 everywhere where Feval was used. Look up vars in lexical env.
8247 (Ffunctionp): Move from subr.el.
8248 (Ffuncall): Handle closures.
8249 (apply_lambda): Remove `eval_flags'.
8250 (funcall_lambda): Handle closures and new byte-code-functions.
8251 (Fspecial_variable_p): New function.
8252 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8253 but without exporting it to Lisp.
8255 * doc.c (Fdocumentation, store_function_docstring):
8256 * data.c (Finteractive_form): Handle closures.
8258 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8261 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8263 (exec_byte_code): New function extracted from Fbyte_code to handle new
8264 calling convention for byte-code-functions. Add new byte-codes.
8266 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8268 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8270 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8272 * xdisp.c (redisplay_internal): Fix prototype.
8274 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8276 * xdisp.c (SCROLL_LIMIT): New macro.
8277 (try_scrolling): Use it when setting scroll_limit.
8278 Limit scrolling to 100 screen lines.
8279 (redisplay_window): Even when falling back on "recentering",
8280 position point in the window according to scroll-conservatively,
8281 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8283 (try_scrolling): When point is above the window, allow searching
8284 as far as scroll_max, or one screenful, to compute vertical
8285 distance from PT to the scroll margin position. This prevents
8286 try_scrolling from unnecessarily failing when
8287 scroll-conservatively is set to a value slightly larger than the
8288 window height. Clean up the case of PT below the margin at bottom
8289 of window: scroll_max can no longer be INT_MAX. When aggressive
8290 scrolling is in use, don't let point enter the opposite scroll
8291 margin as result of the scroll.
8292 (syms_of_xdisp) <scroll-conservatively>: Document the
8293 threshold of 100 lines for never-recentering scrolling.
8295 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8297 * dispextern.h (move_it_by_lines):
8298 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8299 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8300 (message_log_check_duplicate): Remove parameters `prev_bol' and
8301 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8302 (redisplay_internal): Remove parameter `preserve_echo_area',
8303 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8305 * indent.c (Fvertical_motion):
8306 * window.c (window_scroll_pixel_based, Frecenter):
8307 Don't pass `need_y_p' to `move_it_by_lines'.
8309 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8311 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8312 steal a few bits to be more compact.
8313 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8314 Remove unneeded casts.
8316 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8318 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8320 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8321 binding" message (bug#7967).
8323 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8325 Fix more problems found by GCC 4.6.0's static checks.
8327 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8328 Remove unused local var.
8330 * editfns.c (Fmessage_box): Remove unused local var.
8332 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8333 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8334 Omit unused local vars.
8335 * window.c (shrink_windows): Omit unused local var.
8336 * menu.c (digest_single_submenu): Omit unused local var.
8337 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8338 Omit unused local var.
8340 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8341 Don't assume string length fits in int.
8342 (keyremap_step, read_key_sequence): Use size_t for sizes.
8343 (read_key_sequence): Don't check last_real_key_start redundantly.
8345 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8346 instead of alloca (Bug#8344).
8348 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8349 (Fbacktrace_frame): Don't assume nframes fits in int.
8351 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8353 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8356 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8358 * cm.c (calccost): Turn while-do into do-while, for clarity.
8360 * keyboard.c (syms_of_keyboard): Use the same style as later
8361 in this function when indexing through an array. This also
8362 works around GCC bug 48267.
8364 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8366 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8368 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8369 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8371 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8372 This avoids undefined behavior on integer overflow, and is a bit
8373 more convenient anyway since it is compared to a size_t variable.
8375 Variadic C functions now count arguments with size_t, not int.
8376 This avoids an unnecessary limitation on 64-bit machines, which
8377 caused (substring ...) to crash on large vectors (Bug#8344).
8378 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8379 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8380 All variadic functions and their callers changed accordingly.
8381 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8382 * data.c (arith_driver, float_arith_driver): Likewise.
8383 * editfns.c (general_insert_function): Likewise.
8384 * eval.c (struct backtrace.nargs, interactive_p)
8385 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8386 (funcall_lambda, mark_backtrace): Likewise.
8387 * fns.c (concat): Likewise.
8388 * frame.c (x_set_frame_parameters): Likewise.
8389 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8390 0 if not found, not -1. All callers changed.
8392 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8393 (stack_copy_size): Now size_t, not int.
8394 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8396 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8398 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8399 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8400 All callers changed.
8402 * lisp.h (multibyte_char_to_unibyte):
8403 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8404 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8405 * character.h (CHAR_TO_BYTE8):
8406 * cmds.c (internal_self_insert):
8407 * editfns.c (general_insert_function):
8408 * keymap.c (push_key_description):
8409 * search.c (Freplace_match):
8410 * xdisp.c (message_dolog, set_message_1): All callers changed.
8412 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8414 * keyboard.c (safe_run_hook_funcall): New function.
8415 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8416 don't set the hook to nil, but remove the offending function instead.
8417 (Qcommand_hook_internal): Remove, unused.
8418 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8419 Vcommand_hook_internal.
8421 * eval.c (enum run_hooks_condition): Remove.
8422 (funcall_nil, funcall_not): New functions.
8423 (run_hook_with_args): Call each function through a `funcall' argument.
8424 Remove `cond' argument, now redundant.
8425 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8426 (Frun_hook_with_args_until_failure): Adjust accordingly.
8427 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8429 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8431 * dispextern.h (string_buffer_position): Remove declaration.
8433 * print.c (strout): Remove parameter `multibyte', unused since
8434 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8436 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8437 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8438 All callers changed.
8440 * w32.c (_wsa_errlist): Use braces for struct initializers.
8442 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8443 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8444 All callers changed.
8445 (string_buffer_position): Likewise. Also, make static (it's never
8446 used outside xdisp.c).
8447 (cursor_row_p): Remove parameter `w', unused since
8448 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8449 (decode_mode_spec): Remove parameter `precision', introduced during
8450 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8451 All callers changed.
8453 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8455 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8457 2011-03-27 Anders Lindgren <andlind@gmail.com>
8459 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8460 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8461 (ns_update_auto_hide_menu_bar): New functions.
8462 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8463 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8464 ns_constrain_all_frames.
8465 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8466 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8468 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8470 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8472 2011-03-27 Glenn Morris <rgm@gnu.org>
8474 * syssignal.h: Replace RETSIGTYPE with void.
8475 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8476 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8477 Replace SIGTYPE with void everywhere.
8478 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8479 * s/template.h (SIGTYPE): Remove commented out definition.
8481 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8483 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8484 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8486 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8488 * w32.c (read_unc_volume): Use parameter `henum', instead of
8489 global variable `wget_enum_handle'.
8491 * keymap.c (describe_vector): Remove parameters `indices' and
8492 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8493 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8495 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8497 * keyboard.c (timer_check): Remove parameter `do_it_now',
8498 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8499 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8500 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8502 * keyboard.c (read_char):
8503 * w32menu.c (w32_menu_display_help):
8504 * xmenu.c (show_help_event, menu_help_callback):
8505 Adjust calls to `show_help_echo'.
8507 * gtkutil.c (xg_maybe_add_timer):
8508 * keyboard.c (readable_events):
8509 * process.c (wait_reading_process_output):
8510 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8512 * insdel.c (adjust_markers_gap_motion):
8513 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8514 (gap_left, gap_right): Don't call it.
8516 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8518 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8519 incurred during fontification.
8521 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8523 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8524 (DEFVAR_PER_BUFFER): Don't pass it.
8526 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8527 (scrolling_window): Don't pass it.
8529 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8531 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8533 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8535 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8536 of variables specific to SELinux and computation of `encoded_absname'.
8538 * image.c (XPutPixel): Remove unused variable `height'.
8540 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8542 * unexw32.c (get_section_info): Remove unused variable `section'.
8544 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8545 (system_process_attributes): Remove unused variable `sess'.
8546 (sys_read): Remove unused variable `err'.
8548 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8549 (w32_wnd_proc): Remove unused variable `isdead'.
8550 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8551 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8552 (x_create_tip_frame): Remove unused variable `tem'.
8554 * w32inevt.c (w32_console_read_socket):
8555 Remove unused variable `no_events'.
8557 * w32term.c (x_draw_composite_glyph_string_foreground):
8558 Remove unused variable `width'.
8560 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8562 * w32term.c (x_set_glyph_string_clipping):
8563 Don't pass uninitialized region to CombineRgn.
8565 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8567 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8568 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8569 (Fx_close_connection): Remove unused variable `i'.
8571 * w32font.c (w32font_draw): Return number of glyphs.
8572 (w32font_open_internal): Remove unused variable `i'.
8573 (w32font_driver): Add missing initializer.
8575 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8576 (fill_in_menu): Remove unused variable `items_added'.
8578 * w32term.c (last_mouse_press_frame): Remove static global variable.
8579 (w32_clip_to_row): Remove unused variable `f'.
8580 (x_delete_terminal): Remove unused variable `i'.
8582 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8583 (NOTHING): Remove unused static global variable.
8584 (uniscribe_check_otf): Remove unused variable `table'.
8585 (uniscribe_font_driver): Add missing initializers.
8587 2011-03-23 Julien Danjou <julien@danjou.info>
8589 * term.c (Fsuspend_tty, Fresume_tty):
8590 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8591 * window.c (temp_output_buffer_show):
8592 * insdel.c (signal_before_change):
8593 * frame.c (Fhandle_switch_frame):
8594 * fileio.c (Fdo_auto_save):
8595 * emacs.c (Fkill_emacs):
8596 * editfns.c (save_excursion_restore):
8597 * cmds.c (internal_self_insert):
8598 * callint.c (Fcall_interactively):
8599 * buffer.c (Fkill_all_local_variables):
8600 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8602 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8603 unconditionally since it does the check itself.
8605 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8607 Fix more problems found by GCC 4.5.2's static checks.
8609 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8610 the first time through the loop, since we know p0 < p1 then.
8611 This also avoids a gcc -Wstrict-overflow warning.
8613 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8614 leading to a memory leak, possible in functions like
8615 load_charset_map_from_file that can allocate an unbounded number
8616 of objects (Bug#8318).
8618 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8619 that could (at least in theory) be that large.
8621 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8622 This is less likely to overflow, and avoids undefined behavior if
8623 overflow does occur. All callers changed. Use strtoul to scan
8624 for the unsigned long integer.
8625 (pint2hrstr): Simplify and tune code slightly.
8626 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8628 * scroll.c (do_scrolling): Work around GCC bug 48228.
8629 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8631 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8632 This also avoids a warning with gcc -Wstrict-overflow.
8633 (validate_x_resource_name): Simplify count usage.
8634 This also avoids a warning with gcc -Wstrict-overflow.
8636 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8639 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8641 * process.c (Fmake_network_process): Use socklen_t, not int,
8642 where POSIX says socklen_t is required in portable programs.
8643 This fixes a porting bug on hosts like 64-bit HP-UX, where
8644 socklen_t is wider than int (Bug#8277).
8645 (Fmake_network_process, server_accept_connection):
8646 (wait_reading_process_output, read_process_output):
8649 * process.c: Rename or move locals to avoid shadowing.
8650 (list_processes_1, Fmake_network_process):
8651 (read_process_output_error_handler, exec_sentinel_error_handler):
8652 Rename or move locals.
8653 (Fmake_network_process): Define label "retry_connect" only if needed.
8654 (Fnetwork_interface_info): Fix pointer signedness.
8655 (process_send_signal): Add cast to avoid pointer signedness problem.
8656 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8657 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8659 Make tparam.h and terminfo.c consistent.
8660 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8661 Include tparam.h instead, since it declares them.
8662 * cm.h (PC): Remove extern decl; tparam.h now does this.
8663 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8664 * terminfo.c: Include tparam.h, to check interfaces.
8665 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8666 (tparam): Adjust signature to match interface in tparam.h;
8667 this removes some undefined behavior. Check that outstring and len
8668 are zero, which they always are with Emacs.
8669 * tparam.h (PC, BC, UP): New extern decls.
8671 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8672 (xftfont_open): Rename locals to avoid shadowing.
8674 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8675 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8676 (OTF_TAG_SYM): Omit macro if not needed.
8677 (ftfont_list): Remove unused local.
8678 (get_adstyle_property, ftfont_pattern_entity):
8679 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8680 Rename locals to avoid shadowing.
8682 * xfont.c (xfont_list_family): Mark var as initialized.
8684 * xml.c (make_dom): Now static.
8686 * composite.c (composition_compute_stop_pos): Rename local to
8688 (composition_reseat_it): Remove unused locals.
8689 (find_automatic_composition, composition_adjust_point): Likewise.
8690 (composition_update_it): Mark var as initialized.
8691 (find_automatic_composition): Mark vars as initialized,
8692 with a FIXME (Bug#8290).
8694 character.h: Rename locals to avoid shadowing.
8695 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8696 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8697 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8698 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8701 * textprop.c (property_change_between_p): Remove; unused.
8703 * intervals.c (interval_start_pos): Now static.
8705 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8707 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8708 Rename locals to avoid shadowing.
8710 * sound.c (wav_play, au_play, Fplay_sound_internal):
8711 Fix pointer signedness.
8712 (alsa_choose_format): Remove unused local var.
8713 (wav_play): Initialize a variable to 0, to prevent undefined
8714 behavior (Bug#8278).
8716 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8718 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8720 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8721 clobbering (Bug#8298).
8722 * sysdep.c (sys_subshell): Likewise.
8723 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8725 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8726 This should get cleaned up, so that child_setup has the
8727 same signature on all platforms.
8729 * callproc.c (call_process_cleanup): Now static.
8730 (relocate_fd): Rename locals to avoid shadowing.
8732 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8734 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8735 not to be necessary, and produces flickering.
8737 2011-03-20 Glenn Morris <rgm@gnu.org>
8739 * config.in: Remove file.
8741 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8743 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8744 are now in src/globals.h.
8745 (syms_of_minibuf): Remove spurious & from previous change.
8747 2011-03-20 Leo Liu <sdl.web@gmail.com>
8749 * minibuf.c (completing-read-function): New variable.
8750 (completing-read-default): Rename from completing-read.
8751 (completing-read): Call completing-read-function.
8753 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8755 * xfaces.c (Fx_load_color_file):
8756 Read color file from absolute filename (bug#8250).
8758 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8760 * makefile.w32-in: Update dependencies.
8762 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8764 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8766 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8768 Fix more problems found by GCC 4.5.2's static checks.
8770 * process.c (make_serial_process_unwind, send_process_trap):
8771 (sigchld_handler): Now static.
8773 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8774 That way, the code declares only the vars that it needs.
8775 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8776 * s/cygwin.h (PTY_ITERATION): Likewise.
8777 * s/darwin.h (PTY_ITERATION): Likewise.
8778 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8780 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8781 * process.c (allocate_pty): Don't declare stb unless it's needed.
8783 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8784 (CONSTANTLIM): Remove; unused.
8785 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8786 Define only if needed.
8788 * unexelf.c (unexec): Name an expression,
8789 to avoid gcc -Wbad-function-cast warning.
8790 Use a different way to cause a compilation error if anyone uses
8791 n rather than nn, a way that does not involve shadowing.
8792 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8794 * deps.mk (unexalpha.o): Remove; unused.
8796 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8797 * unexec.h: New file.
8798 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8799 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8801 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8802 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8803 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8804 Change as necessary to match prototype in unexec.h.
8806 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8808 (back_comment, skip_chars): Mark vars as initialized.
8810 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8811 Rename locals to avoid shadowing.
8813 * lread.c (read1): Rewrite so as not to use empty "else".
8814 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8816 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8818 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8819 warning when compiling print.c.
8821 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8822 instead of using an uninitialized var.
8823 (font_sort_entities): Mark var as initialized.
8825 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8827 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8828 pointers to constants.
8829 (font_parse_fcname): Remove unused vars.
8830 (font_delete_unmatched): Now static.
8831 (font_get_spec): Remove; unused.
8832 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8833 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8834 Rename or move locals to avoid shadowing.
8836 * fns.c (require_nesting_list, require_unwind): Now static.
8837 (Ffillarray): Rename locals to avoid shadowing.
8839 * floatfns.c (domain_error2): Define only if needed.
8840 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8842 * alloc.c (mark_backtrace): Move decl from here ...
8843 * lisp.h: ... to here, so that it can be checked.
8845 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8846 (Fdefvar): Rewrite so as not to use empty "else".
8847 (lisp_indirect_variable): Name an expression,
8848 to avoid gcc -Wbad-function-cast warning.
8849 (Fdefvar): Rename locals to avoid shadowing.
8851 * callint.c (quotify_arg, quotify_args): Now static.
8852 (Fcall_interactively): Rename locals to avoid shadowing.
8853 Use const pointer when appropriate.
8855 * lisp.h (get_system_name, get_operating_system_release):
8856 Move decls here, to check interfaces.
8857 * process.c (get_operating_system_release): Move decl to lisp.h.
8858 * xrdb.c (get_system_name): Likewise.
8859 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8860 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8861 some of which prompt warnings from gcc -Wbad-function-cast.
8862 (Fformat_time_string, Fencode_time, Finsert_char):
8863 (Ftranslate_region_internal, Fformat):
8864 Rename or remove local vars to avoid shadowing.
8865 (Ftranslate_region_internal): Mark var as initialized.
8867 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8870 * lisp.h (eassert): Check that the argument compiles, even if
8871 ENABLE_CHECKING is not defined.
8873 * data.c (Findirect_variable): Name an expression, to avoid
8874 gcc -Wbad-function-cast warning.
8875 (default_value, arithcompare, arith_driver, arith_error): Now static.
8876 (store_symval_forwarding): Rename local to avoid shadowing.
8877 (Fmake_variable_buffer_local, Fmake_local_variable):
8878 Mark variables as initialized.
8879 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8881 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8882 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8883 Rename locals to avoid shadowing.
8884 (mark_stack): Move local variables into the #ifdef region where
8886 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8887 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8889 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8890 (GC_STRING_CHARS): Remove; not used.
8891 (Fmemory_limit): Cast sbrk's returned value to char *.
8893 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8894 avoids undefined behavior in theory.
8896 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8898 Use functions, not macros, for up- and down-casing (Bug#8254).
8899 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8900 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8901 to use the following functions instead of these macros.
8902 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8903 EMACS_INT, since callers assume the returned value fits in int.
8904 (upcase1): Likewise, for UPCASE_TABLE.
8905 (uppercasep, lowercasep, upcase): New static inline functions.
8906 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8907 the race-condition problem in the old DOWNCASE.
8909 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8910 Rename locals to avoid shadowing.
8911 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8912 (regex_compile, re_search_2, re_match_2_internal):
8913 Remove unused local vars.
8914 (FREE_VAR): Rewrite so as not to use empty "else",
8915 which gcc can warn about.
8916 (regex_compile, re_match_2_internal): Mark locals as initialized.
8917 (RETALLOC_IF): Define only if needed.
8918 (WORDCHAR_P): Likewise. This one is never needed, but is used
8919 only in a comment talking about a compiler bug, so put inside
8920 the #if 0 of that comment.
8921 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8922 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8925 * search.c (boyer_moore): Rename locals to avoid shadowing.
8926 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8927 (PREV_CHAR_BOUNDARY): Likewise.
8929 * search.c (simple_search): Remove unused var.
8931 * dired.c (compile_pattern): Move decl from here ...
8932 * lisp.h: ... to here, so that it can be checked.
8933 (struct re_registers): New forward decl.
8935 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8937 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8939 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8940 Rename locals to avoid shadowing.
8941 (Fvertical_motion): Mark locals as initialized.
8943 * casefiddle.c (casify_object, casify_region): Now static.
8944 (casify_region): Mark local as initialized.
8946 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8948 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8949 New macros, so that the caller can use some names other than
8950 gcpro1, gcpro2, etc.
8951 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8953 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8954 argument, for consistency with GCPRO2_VAR, etc: it is now the
8955 prefix of the variable, not the variable itself. All uses
8957 * dired.c (directory_files_internal, file_name_completion):
8958 Rename locals to avoid shadowing.
8960 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8961 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8962 dired.c's scmp function, had undefined behavior.
8963 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8964 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8965 * buffer.h: ... to here, because these macros use current_buffer,
8966 and the new implementation with inline functions needs to have
8967 current_buffer in scope now, rather than later when the macros
8969 (downcase, upcase1): New static inline functions.
8970 (DOWNCASE, UPCASE1): Reimplement using these functions.
8971 This avoids undefined behavior in expressions like
8972 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8973 from race conditions in accessing the global variables
8974 case_temp1 and case_temp2.
8975 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8976 * lisp.h (case_temp1, case_temp2): Remove their decls.
8977 * character.h (ASCII_CHAR_P): Move from here ...
8978 * lisp.h: ... to here, so that the inline functions mentioned
8981 * dired.c (directory_files_internal_unwind): Now static.
8983 * fileio.c (file_name_as_directory, directory_file_name):
8984 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8986 (file_name_as_directory): Use const pointers when appropriate.
8987 (Fexpand_file_name): Likewise. In particular, newdir might
8988 point at constant storage, so make it a const pointer.
8989 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8990 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8992 (Fset_file_times, Finsert_file_contents, auto_save_error):
8993 Rename locals to avoid shadowing.
8995 * minibuf.c (choose_minibuf_frame_1): Now static.
8996 (Ftry_completion, Fall_completions): Rename or remove locals
8999 * marker.c (bytepos_to_charpos): Remove; unused.
9001 * lisp.h (verify_bytepos, count_markers): New decls,
9002 so that gcc does not warn that these functions aren't declared.
9004 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9005 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9006 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9007 (copy_text): Remove unused local var.
9009 * filelock.c (within_one_second): Now static.
9010 (lock_file_1): Rename local to avoid shadowing.
9012 * buffer.c (fix_overlays_before): Mark locals as initialized.
9013 (fix_start_end_in_overlays): Likewise. This function should be
9014 simplified by using pointers-to-pointers, but that's a different
9016 (switch_to_buffer_1): Now static.
9017 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9018 (report_overlay_modification): Rename locals to avoid shadowing.
9020 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9021 Fix pointer signedness issue.
9022 (sys_subshell): Mark local as volatile if checking for lint,
9023 to suppress a gcc -Wclobbered warning that does not seem to be right.
9024 (MAXPATHLEN): Define only if needed.
9026 * process.c (serial_open, serial_configure): Move decls from here ...
9027 * systty.h: ... to here, so that they can be checked.
9029 * fns.c (get_random, seed_random): Move extern decls from here ...
9030 * lisp.h: ... to here, so that they can be checked.
9032 * sysdep.c (reset_io): Now static.
9033 (wait_for_termination_signal): Remove; unused.
9035 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9036 (copy_keymap_item, append_key, push_text_char_description):
9038 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9039 (DENSE_TABLE_SIZE): Remove; unused.
9040 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9041 (describe_map_tree):
9042 Rename locals to avoid shadowing.
9044 * keyboard.c: Declare functions static if they are not used elsewhere.
9045 (echo_char, echo_dash, cmd_error, top_level_2):
9046 (poll_for_input, handle_async_input): Now static.
9047 (read_char, kbd_buffer_get_event, make_lispy_position):
9048 (make_lispy_event, make_lispy_movement, apply_modifiers):
9049 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9050 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9051 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9052 (read_key_sequence, read_char): Mark locals as initialized.
9053 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9055 * keyboard.h (make_ctrl_char): New decl.
9056 (mark_kboards): Move decl here ...
9057 * alloc.c (mark_kboards): ... from here.
9059 * lisp.h (force_auto_save_soon): New decl.
9061 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9062 (DEFINE_DUMMY_FUNCTION): New macro.
9063 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9065 (main): Add casts to avoid warnings
9066 if GCC considers string literals to be constants.
9068 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9070 * dbusbind.c: Pointer signedness fixes.
9071 (xd_signature, xd_append_arg, xd_initialize):
9072 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9073 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9074 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9075 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9077 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9078 if GCC considers string literals to be constants.
9079 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9081 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9083 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9084 (print_preprocess, print_object): New macro to fix last change.
9086 * print.c (print_preprocess): Don't forget font objects.
9088 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9090 * emacs.c (USAGE3): Doc fixes.
9092 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9094 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9097 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9099 * lisp.h (VWindow_system, Qfile_name_history):
9100 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9101 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9102 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9104 * w32select.c: Don't #include "keyboard.h".
9105 (run_protected): Add extern declaration for waiting_for_input.
9107 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9108 * w32console.c (detect_input_pending, read_input_pending)
9109 (encode_terminal_code):
9110 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9111 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9112 (w32_system_caret_y, Qfile_name_history):
9113 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9114 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9115 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9116 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9117 * w32proc.c (Qlocal, report_file_error):
9118 * w32term.c (Vwindow_system, updating_frame):
9119 * w32uniscribe.c (initialized, uniscribe_font_driver):
9120 Remove unneeded extern declarations.
9122 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9124 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9126 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9128 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9129 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9130 These macros can no longer be used for assignment.
9132 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9133 Assign struct members directly, instead of using BUF_BEGV etc.
9134 (record_buffer_markers, fetch_buffer_markers): New functions for
9135 recording and fetching special buffer markers.
9136 (set_buffer_internal_1, set_buffer_temp): Use them.
9138 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9140 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9142 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9143 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9145 * xdisp.c (hscroll_window_tree):
9146 (reconsider_clip_changes): Use PT instead of BUF_PT.
9148 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9150 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9151 $(EMACS_ROOT)/lib/intprops.h.
9153 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9155 Fix more problems found by GCC 4.5.2's static checks.
9157 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9158 to unsigned char * to avoid compiler diagnostic.
9159 (xg_free_frame_widgets): Make it clear that a local variable is
9160 needed only if USE_GTK_TOOLTIP.
9161 (gdk_window_get_screen): Make it clear that this macro is needed
9162 only if USE_GTK_TOOLTIP.
9163 (int_gtk_range_get_value): New function, which avoids a diagnostic
9164 from gcc -Wbad-function-cast.
9165 (xg_set_toolkit_scroll_bar_thumb): Use it.
9166 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9167 diagnostic from gcc -Wbad-function-cast.
9168 (get_utf8_string, xg_get_file_with_chooser):
9169 Rename locals to avoid shadowing.
9170 (create_dialog): Move locals to avoid shadowing.
9172 * xgselect.c (xg_select): Remove unused var.
9174 * image.c (four_corners_best): Mark locals as initialized.
9175 (gif_load): Initialize transparent_p to zero (Bug#8238).
9176 Mark another local as initialized.
9177 (my_png_error, my_error_exit): Mark with NO_RETURN.
9179 * image.c (clear_image_cache): Now static.
9180 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9181 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9182 (x_edge_detection): Remove unnecessary cast that
9183 gcc -Wbad-function-cast diagnoses.
9184 (gif_load): Fix pointer signedness.
9185 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9186 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9188 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9190 Improve quality of tests for time stamp overflow.
9191 For example, without this patch (encode-time 0 0 0 1 1
9192 1152921504606846976) returns the obviously-bogus value (-948597
9193 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9194 reports time overflow. See
9195 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9196 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9197 * editfns.c: Include limits.h and intprops.h.
9198 (TIME_T_MIN, TIME_T_MAX): New macros.
9199 (time_overflow): Move earlier, to before first use.
9200 (hi_time, lo_time): New functions, for an accurate test for
9202 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9203 (Fget_internal_run_time): Don't assume time_t fits in int.
9204 (make_time): Use list2 instead of Fcons twice.
9205 (Fdecode_time): More accurate test for out-of-range times.
9206 (check_tm_member): New function.
9207 (Fencode_time): Use it, to test for out-of-range times.
9208 (lisp_time_argument): Don't rely on undefined left-shift and
9209 right-shift behavior when checking for time stamp overflow.
9211 * editfns.c (time_overflow): New function, refactoring common code.
9212 (Fformat_time_string, Fdecode_time, Fencode_time):
9213 (Fcurrent_time_string): Use it.
9215 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9216 * dired.c (make_time): Move to ...
9217 * editfns.c (make_time): ... here.
9218 * systime.h: Note the move.
9220 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9222 * fringe.c (update_window_fringes): Remove unused variables.
9224 * unexmacosx.c (copy_data_segment): Also copy __got section.
9227 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9229 * termcap.c [MSDOS]: Include "msdos.h".
9230 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9231 Constify `char *' arguments and their references according to
9232 prototypes in tparam.h.
9234 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9236 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9237 Adapt all references accordingly.
9239 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9241 2011-03-11 Tom Tromey <tromey@redhat.com>
9243 * buffer.c (syms_of_buffer): Remove obsolete comment.
9245 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9247 * termhooks.h (encode_terminal_code): Declare prototype.
9249 * msdos.c (encode_terminal_code): Don't declare prototype.
9251 * term.c (encode_terminal_code): Now external again, used by
9252 w32console.c and msdos.c.
9254 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9255 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9257 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9259 Fix some minor problems found by GCC 4.5.2's static checks.
9261 * fringe.c (update_window_fringes): Mark locals as initialized
9263 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9265 * alloc.c (mark_fringe_data): Move decl from here ...
9266 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9267 to check its interface.
9268 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9270 * fontset.c (free_realized_fontset): Now static.
9271 (Fset_fontset_font): Rename local to avoid shadowing.
9272 (fontset_font): Mark local as initialized.
9273 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9275 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9277 * xselect.c (x_disown_buffer_selections): Remove; not used.
9278 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9279 (x_own_selection, Fx_disown_selection_internal): Rename locals
9281 (x_handle_dnd_message): Remove local to avoid shadowing.
9283 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9284 so that the caller can use some name other than gcpro1.
9285 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9286 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9287 (Fx_backspace_delete_keys_p):
9288 Use them to avoid shadowing, and rename vars to avoid shadowing.
9289 (x_decode_color, x_set_name, x_window): Now static.
9290 (Fx_create_frame): Add braces to silence GCC warning.
9291 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9292 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9293 Remove unused locals.
9294 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9295 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9296 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9299 * xterm.h (x_mouse_leave): New decl.
9301 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9302 Remove unused functions.
9303 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9304 (x_calc_absolute_position): Now static.
9305 (XTread_socket): Don't define label "out" unless it's used.
9306 Don't declare local "event" unless it's used.
9307 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9308 unless they are used.
9309 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9310 (x_fatal_error_signal): Remove; not used.
9311 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9312 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9313 (x_error_catcher, x_connection_closed, x_error_handler):
9314 (x_error_quitter, xembed_send_message, x_iconify_frame):
9315 (my_log_handler): Rename locals to avoid shadowing.
9316 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9317 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9319 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9320 Rename or move locals to avoid shadowing.
9321 (tty_defined_color, merge_face_heights): Now static.
9322 (free_realized_faces_for_fontset): Remove; not used.
9323 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9324 does not deduce is never used uninitialized.
9325 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9326 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9328 * terminal.c (store_terminal_param): Now static.
9330 * xmenu.c (menu_highlight_callback): Now static.
9331 (set_frame_menubar): Remove unused local.
9332 (xmenu_show): Rename parameter to avoid shadowing.
9333 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9334 since they might point to immutable storage.
9335 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9336 since it's unused otherwise.
9338 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9339 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9340 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9341 avoids a gcc -Wuninitialized diagnostic.
9342 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9343 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9344 does not deduce are never used uninitialized.
9346 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9348 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9349 * window.c (window_loop, size_window):
9350 (run_window_configuration_change_hook, enlarge_window): Likewise.
9352 * window.c (display_buffer): Now static.
9353 (size_window): Mark variables that gcc -Wuninitialized
9354 does not deduce are never used uninitialized.
9355 * window.h (check_all_windows): New decl, to forestall
9356 gcc -Wmissing-prototypes diagnostic.
9357 * dispextern.h (bidi_dump_cached_states): Likewise.
9359 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9361 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9363 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9364 and to avoid gcc -Wuninitialized warning.
9365 (load_charset_map): Mark variables that gcc -Wuninitialized
9366 does not deduce are never used uninitialized.
9367 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9369 * coding.c (coding_set_source, coding_set_destination):
9370 Use "else { /* comment */ }" rather than "else /* comment */;"
9371 for clarity, and to avoid gcc -Wempty-body warning.
9372 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9373 a block, when the outer 'i' will do.
9374 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9375 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9376 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9377 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9378 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9379 Rename locals to avoid shadowing.
9380 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9381 * coding.c (emacs_mule_char, encode_invocation_designation):
9382 Now static, since they're not used elsewhere.
9383 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9384 (decode_coding_object, encode_coding_object, detect_coding_system):
9385 (decode_coding_emacs_mule): Mark variables that gcc
9386 -Wuninitialized does not deduce are never used uninitialized.
9387 (detect_coding_iso_2022): Initialize a local variable that might
9388 be used uninitialized. Leave a FIXME because it's not clear that
9389 this initialization is needed. (Bug#8211)
9390 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9391 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9392 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9393 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9394 Remove unused macros.
9396 * category.c (hash_get_category_set): Remove unused local var.
9397 (copy_category_table): Now static, since it's not used elsewhere.
9398 * character.c (string_count_byte8): Likewise.
9400 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9401 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9403 * chartab.c (copy_sub_char_table): Now static, since it's not used
9405 (sub_char_table_ref_and_range, char_table_ref_and_range):
9406 Rename locals to avoid shadowing.
9407 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9409 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9410 (BIDI_BOB): Remove unused macro.
9412 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9413 deduce are never used uninitialized.
9414 * term.c (encode_terminal_code): Likewise.
9416 * term.c (encode_terminal_code): Now static. Remove unused local.
9418 * tparam.h: New file.
9419 * term.c, tparam.h: Include it.
9420 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9421 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9422 Move these decls to tparam.h, and make them agree with what
9423 is actually in tparam.c. The previous trick of using incompatible
9424 decls in different modules does not conform to the C standard.
9425 All callers of tparam changed to use tparam's actual API.
9426 * tparam.c (tparam1, tparam, tgoto):
9427 Use const pointers where appropriate.
9429 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9430 * cm.h (struct cm): Likewise.
9431 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9432 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9433 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9434 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9435 (turn_on_face, init_tty): Likewise.
9436 * termchar.h (struct tty_display_info): Likewise.
9438 * term.c (term_mouse_position): Rename local to avoid shadowing.
9440 * alloc.c (mark_ttys): Move decl from here ...
9441 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9443 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9445 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9447 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9449 * search.c (compile_pattern_1): Remove argument regp, unused since
9450 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9451 (compile_pattern): Don't pass it.
9453 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9455 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9456 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9458 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9460 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9462 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9463 gdk_window_get_screen, gdk_window_get_geometry,
9464 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9465 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9466 (xg_get_pixbuf_from_pixmap): New function.
9467 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9468 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9469 Call xg_get_pixbuf_from_pixmap instead of
9470 gdk_pixbuf_get_from_drawable.
9471 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9472 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9473 (xg_check_special_colors): Use GtkStyleContext and its functions
9475 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9476 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9477 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9478 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9479 Call gtk_widget_get_preferred_size.
9480 (xg_frame_resized): gdk_window_get_geometry only takes 5
9482 (xg_win_to_widget, xg_event_is_for_menubar):
9483 Call gdk_x11_window_lookup_for_display.
9484 (xg_set_widget_bg): New function.
9485 (delete_cb): New function.
9486 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9487 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9488 (xg_set_background_color): Call xg_set_widget_bg.
9489 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9490 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9491 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9492 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9494 (update_frame_tool_bar): Call gtk_widget_hide.
9495 (xg_initialize): Use GDK_KEY_g.
9497 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9499 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9501 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9502 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9503 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9505 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9507 * w32xfns.c (select_palette): Check success of RealizePalette against
9508 GDI_ERROR, not zero.
9510 See ChangeLog.11 for earlier changes.
9516 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9518 This file is part of GNU Emacs.
9520 GNU Emacs is free software: you can redistribute it and/or modify
9521 it under the terms of the GNU General Public License as published by
9522 the Free Software Foundation, either version 3 of the License, or
9523 (at your option) any later version.
9525 GNU Emacs is distributed in the hope that it will be useful,
9526 but WITHOUT ANY WARRANTY; without even the implied warranty of
9527 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9528 GNU General Public License for more details.
9530 You should have received a copy of the GNU General Public License
9531 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.