Simplify Irix build, remove iris4d.h file.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2
3 * m/iris4d.h: Remove file, move contents ...
4 * s/irix6-5.h: ... here.
5
6 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7
8 Remove unportable assumption about struct layout (Bug#8884).
9 * alloc.c (mark_buffer):
10 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
11 (clone_per_buffer_values): Don't assume that
12 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
13 This isn't true in general, and it's particularly not true
14 if Emacs is configured with --with-wide-int.
15 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
16 New macros, used in the buffer.c change.
17
18 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
19
20 * xsettings.c: Use both GConf and GSettings if both are available.
21 (store_config_changed_event): Add comment.
22 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
23 (store_tool_bar_style_changed): New functions.
24 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
25 (struct xsettings): Move font inside HAVE_XFT.
26 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
27 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
28 Move inside HAVE_XFT.
29 (something_changed_gsettingsCB): Renamed from something_changedCB.
30 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
31 also.
32 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
33 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
34 (something_changed_gconfCB): Renamed from something_changedCB.
35 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
36 (parse_settings): Move check for font inside HAVE_XFT.
37 (read_settings, apply_xft_settings): Add comment.
38 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
39 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
40 call store_font_name_changed.
41 (xft_settings_event): Add comment.
42 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
43 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
44 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
45 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
46 (xsettings_initialize): Call init_gsettings last.
47 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
48 comment.
49
50 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
51
52 Random fixes. E.g., (random) never returned negative values.
53 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
54 subseconds part to the entropy, as that's a bit more random.
55 Prefer signed to unsigned, since the signedness doesn't matter and
56 in general we prefer signed. When given a limit, use a
57 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
58 latter isn't right if USE_2_TAGS_FOR_INTS.
59 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
60 not 0..VALMASK. Don't discard "excess" bits that random () returns.
61
62 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
63
64 * textprop.c (text_property_stickiness):
65 Obey Vtext_property_default_nonsticky.
66 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
67 * w32fns.c (syms_of_w32fns):
68 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
69
70 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
71
72 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
73 This is more efficient than Ffile_directory_p and avoids a minor race.
74
75 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
76
77 * buffer.c (Foverlay_put): Say what the return value is
78 (bug#7835).
79
80 * fileio.c (barf_or_query_if_file_exists): Check first if the file
81 is a directory before asking whether to use the file name
82 (bug#7564).
83 (barf_or_query_if_file_exists): Make the "File is a directory"
84 error be more correct.
85
86 * fns.c (Frequire): Remove the mention of the .gz files, since
87 that's installation-specific, but keep the mention of
88 `get-load-suffixes'.
89
90 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
91
92 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
93 Report string overflow if the output is too long.
94
95 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
96
97 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
98 (syms_of_gnutls): Remove duplicate DEFSYM for
99 Qgnutls_bootprop_verify_hostname_error, an error for
100 Qgnutls_bootprop_verify_error (which is no longer used).
101
102 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
103 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
104 Also (re)move comments that are misplaced or no longer relevant.
105
106 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
107
108 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
109
110 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
111
112 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
113 and background color parameters if they have been changed.
114
115 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
116
117 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
118
119 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
120
121 * xsettings.c (SYSTEM_FONT): Define only when used.
122 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
123
124 * keymap.c (access_keymap_1): Now static.
125
126 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
127
128 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
129 leave any prefix arg for the up event (Bug#1586).
130
131 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
132
133 * lread.c (syms_of_lread): Mention single symbols defined by
134 `defvar' or `defconst' (bug#7154).
135
136 * fns.c (Frequire): Mention .el.gz files (bug#7314).
137 (Frequire): Mention get-load-suffixes.
138
139 2011-07-02 Martin Rudalics <rudalics@gmx.at>
140
141 * window.h (window): Remove clone_number slot.
142 * window.c (Fwindow_clone_number, Fset_window_clone_number):
143 Remove.
144 (make_parent_window, make_window, saved_window)
145 (Fset_window_configuration, save_window_save): Don't deal with
146 clone numbers.
147 * buffer.c (Qclone_number): Remove declaration.
148 (sort_overlays, overlay_strings): Don't deal with clone numbers.
149
150 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
151
152 Add multiple inheritance to keymaps.
153 * keymap.c (Fmake_composed_keymap): New function.
154 (Fset_keymap_parent): Simplify.
155 (fix_submap_inheritance): Remove.
156 (access_keymap_1): New function extracted from access_keymap to handle
157 embedded parents and handle lists of maps.
158 (access_keymap): Use it.
159 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
160 (Fcopy_keymap): Handle embedded parents.
161 (Fcommand_remapping, define_as_prefix): Simplify.
162 (Fkey_binding): Simplify.
163 (syms_of_keymap): Move minibuffer-local-completion-map,
164 minibuffer-local-filename-completion-map,
165 minibuffer-local-must-match-map, and
166 minibuffer-local-filename-must-match-map to Elisp.
167 (syms_of_keymap): Defsubr make-composed-keymap.
168 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
169 (parse_menu_item): Trivial simplification.
170
171 2011-07-01 Glenn Morris <rgm@gnu.org>
172
173 * Makefile.in (SETTINGS_LIBS): Fix typo.
174
175 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
176
177 * coding.c (Fencode_coding_string): Record the last coding system
178 used, as the function doc string says (bug#8738).
179
180 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
181
182 * xsettings.c (store_monospaced_changed): Take new font as arg and
183 check for change against current_mono_font.
184 (EMACS_TYPE_SETTINGS): Remove this and related defines.
185 (emacs_settings_constructor, emacs_settings_get_property)
186 (emacs_settings_set_property, emacs_settings_class_init)
187 (emacs_settings_init, gsettings_obj): Remove.
188 (something_changedCB): New function for HAVE_GSETTINGS.
189 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
190 with value as argument.
191 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
192 g_settings_new (Bug#8967). Do not create gsettings_obj.
193 Remove calls to g_settings_bind. Connect something_changedCB to
194 "changed".
195
196 * xgselect.c: Add defined (HAVE_GSETTINGS).
197 (xgselect_initialize): Ditto.
198
199 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
200 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
201 xg_select.
202
203 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
204
205 * eval.c (struct backtrace): Simplify and port the data structure.
206 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
207 signed bit field, as this assumption is not portable and it makes
208 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
209 "char debug_on_exit : 1" as this is not portable either; instead,
210 use the portable "unsigned int debug_on_exit : 1". Remove unused
211 member evalargs. Remove obsolete comments about cc bombing out.
212
213 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
214
215 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
216 Let HAVE_GSETTINGS override HAVE_GCONF.
217 (store_monospaced_changed): New function.
218 (EMACS_SETTINGS): A new type derived from GObject to handle
219 GSettings notifications.
220 (emacs_settings_constructor, emacs_settings_get_property)
221 (emacs_settings_set_property, emacs_settings_class_init):
222 New functions.
223 (gsettings_client, gsettings_obj): New variables.
224 (GSETTINGS_SCHEMA): New define.
225 (something_changedCB): Call store_monospaced_changed.
226 (init_gsettings): New function.
227 (xsettings_initialize): Call init_gsettings.
228 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
229 to NULL.
230
231 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
232 GCONF_CFLAGS/LIBS.
233
234 2011-06-29 Martin Rudalics <rudalics@gmx.at>
235
236 * window.c (resize_root_window, grow_mini_window)
237 (shrink_mini_window): Rename Qresize_root_window to
238 Qwindow_resize_root_window and Qresize_root_window_vertically to
239 Qwindow_resize_root_window_vertically.
240
241 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
242
243 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
244
245 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
246
247 * makefile.w32-in: Redesign dependencies so they reflect more
248 clearly which files are directly included by each source file,
249 and not through other includes.
250
251 2011-06-27 Martin Rudalics <rudalics@gmx.at>
252
253 * buffer.c (Qclone_number): Declare static and DEFSYM it.
254 (sort_overlays, overlay_strings): When an overlay's clone number
255 matches the window's clone number process the overlay even if
256 the overlay's window property doesn't match the current window.
257
258 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
259 (Fwindow_hchild): Rename to Fwindow_left_child.
260 (Fwindow_next): Rename to Fwindow_next_sibling.
261 (Fwindow_prev): Rename to Fwindow_prev_sibling.
262 (resize_window_check): Rename to window_resize_check.
263 (resize_window_apply): Rename to window_resize_apply.
264 (Fresize_window_apply): Rename to Fwindow_resize_apply.
265 (Fdelete_other_windows_internal, resize_frame_windows)
266 (Fsplit_window_internal, Fdelete_window_internal)
267 (grow_mini_window, shrink_mini_window)
268 (Fresize_mini_window_internal): Fix callers accordingly.
269
270 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
271
272 * emacsgtkfixed.h: State that this is only used with Gtk+3.
273 (emacs_fixed_set_min_size): Remove.
274 (emacs_fixed_new): Take frame as argument.
275
276 * emacsgtkfixed.c: State that this is only used with Gtk+3.
277 (_EmacsFixedPrivate): Remove minwidth/height.
278 Add struct frame *f.
279 (emacs_fixed_init): Initialize priv->f.
280 (get_parent_class, emacs_fixed_set_min_size): Remove.
281 (emacs_fixed_new): Set priv->f to argument.
282 (emacs_fixed_get_preferred_width)
283 (emacs_fixed_get_preferred_height): Use min_width/height from
284 frames size_hint to set minimum and natural (Bug#8919).
285 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
286 and use min_width/height from frames size_hint to set
287 min_width/height (Bug#8919).
288
289 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
290 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
291 Fix indentation.
292
293 2011-06-26 Eli Zaretskii <eliz@gnu.org>
294
295 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
296 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
297 called at ZV.
298
299 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
300
301 * process.c (wait_reading_process_output): Bypass select if
302 waiting for a cell while ignoring keyboard input, and input is
303 pending. Suggested by Jan Djärv (Bug#8869).
304
305 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
306
307 Use gnulib's dup2 module instead of rolling our own.
308 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
309
310 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
311
312 * dispnew.c (scrolling_window): Before scrolling, turn off a
313 mouse-highlight in the window being scrolled.
314
315 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
316
317 Move DEFSYM to lisp.h and use everywhere.
318
319 * character.h (DEFSYM): Move declaration...
320 * lisp.h (DEFSYM): ...here.
321
322 * gnutls.c:
323 * minibuf.c:
324 * w32menu.c:
325 * w32proc.c:
326 * w32select.c: Don't include character.h.
327
328 * alloc.c (syms_of_alloc):
329 * buffer.c (syms_of_buffer):
330 * bytecode.c (syms_of_bytecode):
331 * callint.c (syms_of_callint):
332 * casefiddle.c (syms_of_casefiddle):
333 * casetab.c (init_casetab_once):
334 * category.c (init_category_once, syms_of_category):
335 * ccl.c (syms_of_ccl):
336 * cmds.c (syms_of_cmds):
337 * composite.c (syms_of_composite):
338 * dbusbind.c (syms_of_dbusbind):
339 * dired.c (syms_of_dired):
340 * dispnew.c (syms_of_display):
341 * doc.c (syms_of_doc):
342 * editfns.c (syms_of_editfns):
343 * emacs.c (syms_of_emacs):
344 * eval.c (syms_of_eval):
345 * fileio.c (syms_of_fileio):
346 * fns.c (syms_of_fns):
347 * frame.c (syms_of_frame):
348 * fringe.c (syms_of_fringe):
349 * insdel.c (syms_of_insdel):
350 * keymap.c (syms_of_keymap):
351 * lread.c (init_obarray, syms_of_lread):
352 * macros.c (syms_of_macros):
353 * msdos.c (syms_of_msdos):
354 * print.c (syms_of_print):
355 * process.c (syms_of_process):
356 * search.c (syms_of_search):
357 * sound.c (syms_of_sound):
358 * syntax.c (init_syntax_once, syms_of_syntax):
359 * terminal.c (syms_of_terminal):
360 * textprop.c (syms_of_textprop):
361 * undo.c (syms_of_undo):
362 * w32.c (globals_of_w32):
363 * window.c (syms_of_window):
364 * xdisp.c (syms_of_xdisp):
365 * xfaces.c (syms_of_xfaces):
366 * xfns.c (syms_of_xfns):
367 * xmenu.c (syms_of_xmenu):
368 * xsettings.c (syms_of_xsettings):
369 * xterm.c (syms_of_xterm): Use DEFSYM.
370
371 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
372
373 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
374
375 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
376
377 Integer and buffer overflow fixes (Bug#8873).
378
379 * print.c (printchar, strout): Check for string overflow.
380 (PRINTPREPARE, printchar, strout):
381 Don't set size unless allocation succeeds.
382
383 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
384 for sizes. Check for string overflow more accurately.
385 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
386
387 * macros.c: Integer and buffer overflow fixes.
388 * keyboard.h (struct keyboard.kbd_macro_bufsize):
389 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
390 Use ptrdiff_t, not int, for sizes.
391 Don't increment bufsize until after realloc succeeds.
392 Check for size-calculation overflow.
393 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
394
395 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
396
397 * lread.c: Integer overflow fixes.
398 (read_integer): Radix is now EMACS_INT, not int,
399 to improve quality of diagnostics for out-of-range radices.
400 Calculate buffer size correctly for out-of-range radices.
401 (read1): Check for integer overflow in radices, and in
402 read-circle numbers.
403 (read_escape): Avoid int overflow.
404 (Fload, openp, read_buffer_size, read1)
405 (substitute_object_recurse, read_vector, read_list, map_obarray):
406 Use ptrdiff_t, not int, for sizes.
407 (read1): Use EMACS_INT, not int, for sizes.
408 Check for size overflow.
409
410 * image.c (cache_image): Check for size arithmetic overflow.
411
412 * lread.c: Integer overflow issues.
413 (saved_doc_string_size, saved_doc_string_length)
414 (prev_saved_doc_string_size, prev_saved_doc_string_length):
415 Now ptrdiff_t, not int.
416 (read1): Don't assume doc string length fits in int. Check for
417 out-of-range doc string lengths.
418 (read_list): Don't assume file position fits in int.
419 (read_escape): Check for hex character overflow.
420
421 2011-06-22 Leo Liu <sdl.web@gmail.com>
422
423 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
424 Move to minibuffer.el.
425
426 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
427
428 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
429 The following patches are for when GLYPH_DEBUG && !XASSERT.
430 * dispextern.h (trace_redisplay_p, dump_glyph_string):
431 * dispnew.c (flush_stdout):
432 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
433 Mark as externally visible.
434 * dispnew.c (check_window_matrix_pointers): Now static.
435 * dispnew.c (window_to_frame_vpos):
436 * xfns.c (unwind_create_frame):
437 * xterm.c (x_check_font): Remove unused local.
438 * scroll.c (CHECK_BOUNDS):
439 * xfaces.c (cache_fache): Rename local to avoid shadowing.
440 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
441 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
442 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
443 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
444 Now static.
445 (debug_method_add): Use va_list and vsprintf rather than relying
446 on undefined behavior with wrong number of arguments.
447 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
448 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
449 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
450 since we're not interested in debugging glyphs with old libraries.
451 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
452 GCC 4.6.0's static checking.
453
454 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
455
456 Integer overflow and signedness fixes (Bug#8873).
457 A few related buffer overrun fixes, too.
458
459 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
460
461 * dispextern.h (struct face.stipple):
462 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
463 (x_bitmap_mask, x_allocate_bitmap_record)
464 (x_create_bitmap_from_data, x_create_bitmap_from_file)
465 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
466 (x_create_bitmap_from_xpm_data):
467 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
468 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
469 (.bitmaps_last):
470 * xfaces.c (load_pixmap):
471 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
472 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
473 (.bitmaps_last, struct x_output.icon_bitmap):
474 Use ptrdiff_t, not int, for bitmap indexes.
475 (x_allocate_bitmap_record): Check for size overflow.
476 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
477
478 Use ptrdiff_t, not int, for overlay counts.
479 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
480 * editfns.c (overlays_around, get_pos_property):
481 * textprop.c (get_char_property_and_overlay):
482 * xdisp.c (next_overlay_change, note_mouse_highlight):
483 * xfaces.c (face_at_buffer_position):
484 * buffer.c (OVERLAY_COUNT_MAX): New macro.
485 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
486 (Fnext_overlay_change, Fprevious_overlay_change)
487 (mouse_face_overlay_overlaps, Foverlays_in):
488 Use ptrdiff_t, not int, for sizes.
489 (overlays_at, overlays_in): Check for size-calculation overflow.
490
491 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
492
493 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
494 (x_session_initialize): Do not assume string length fits in int.
495
496 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
497 This is unlikely, but can occur if DPI is outlandish.
498
499 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
500 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
501
502 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
503 * xrdb.c (magic_file_p, search_magic_path):
504 Omit last arg SUFFIX; it was always 0. All callers changed.
505 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
506
507 * xfont.c (xfont_match): Avoid need for strlen.
508
509 * xfns.c: Don't assume strlen fits in int.
510 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
511
512 * xdisp.c (message_log_check_duplicate): Return intmax_t,
513 not unsigned long, as we prefer signed integers. All callers changed.
514 Detect integer overflow in repeat count.
515 (message_dolog): Don't assume print length fits in 39 bytes.
516 (display_mode_element): Don't assume strlen fits in int.
517
518 * termcap.c: Don't assume sizes fit in int and never overflow.
519 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
520 (gobble_line): Check for size-calculation overflow.
521
522 * minibuf.c (Fread_buffer):
523 * lread.c (intern, intern_c_string):
524 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
525 Don't assume string length fits in int.
526
527 * keyboard.c (parse_tool_bar_item):
528 * gtkutil.c (style_changed_cb): Avoid need for strlen.
529
530 * font.c: Don't assume string length fits in int.
531 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
532 Use ptrdiff_t, not int.
533 (font_intern_prop): Don't assume string length fits in int.
534 Don't assume integer property fits in fixnum.
535 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
536
537 * filelock.c: Fix some buffer overrun and integer overflow issues.
538 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
539 Reformulate so as not to need the command string.
540 Invoke gzip -cd rather than gunzip, as it's more portable.
541 (lock_info_type, lock_file_1, lock_file):
542 Don't assume pid_t and time_t fit in unsigned long.
543 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
544 (current_lock_owner): Prefer signed type for sizes.
545 Use memcpy, not strncpy, where memcpy is what is really wanted.
546 Don't assume (via atoi) that time_t and pid_t fit in int.
547 Check for time_t and/or pid_t out of range, e.g., via a network share.
548 Don't alloca where an auto var works fine.
549
550 * fileio.c: Fix some integer overflow issues.
551 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
552 Don't assume string length fits in int.
553 (directory_file_name): Don't assume string length fits in long.
554 (make_temp_name): Don't assume pid fits in int, or that its print
555 length is less than 20.
556
557 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
558
559 * coding.c (make_subsidiaries): Don't assume string length fits in int.
560
561 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
562
563 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
564 We prefer signed integers, even for size calculations.
565
566 * emacs.c: Don't assume string length fits in 'int'.
567 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
568 (main): Don't invoke strlen when not needed.
569
570 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
571 (XD_DEBUG_MESSAGE): Don't waste a byte.
572
573 * callproc.c (getenv_internal_1, getenv_internal)
574 (Fgetenv_internal):
575 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
576
577 * lread.c (invalid_syntax): Omit length argument.
578 All uses changed. This doesn't fix a bug, but it simplifies the
579 code away from its former Hollerith-constant appearance, and it's
580 one less 'int' to worry about when looking at integer-overflow issues.
581 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
582
583 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
584 This didn't break anything, but it didn't help either.
585 It's confusing to put a bogus integer in a place where the actual
586 value does not matter.
587 (LIST_END_P): Remove unused macro and its bogus comment.
588 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
589
590 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
591 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
592 implementation.
593 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
594 We prefer signed types, and the value cannot exceed the EMACS_INT
595 range anyway (because otherwise the length would not be representable).
596 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
597 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
598 This avoids a GCC warning when WIDE_EMACS_INT.
599
600 * indent.c (sane_tab_width): New function.
601 (current_column, scan_for_column, Findent_to, position_indentation)
602 (compute_motion): Use it. This is just for clarity.
603 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
604
605 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
606
607 * lisp.h (lint_assume): New macro.
608 * composite.c (composition_gstring_put_cache):
609 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
610
611 * editfns.c, insdel.c:
612 Omit unnecessary forward decls, to simplify future changes.
613
614 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
615
616 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
617
618 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
619 Use much-faster test for byte-length change.
620 Don't assume string byte-length fits in 'int'.
621 Check that character arg fits in 'int'.
622 (mapcar1): Declare byte as byte, for clarity.
623
624 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
625
626 * fns.c (concat): Catch string overflow earlier.
627 Do not rely on integer wraparound.
628
629 * dispextern.h (struct it.overlay_strings_charpos)
630 (struct it.selective): Now EMACS_INT, not int.
631 * xdisp.c (forward_to_next_line_start)
632 (back_to_previous_visible_line_start)
633 (reseat_at_next_visible_line_start, next_element_from_buffer):
634 Don't arbitrarily truncate the value of 'selective' to int.
635
636 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
637
638 * composite.c: Don't truncate sizes to 'int'.
639 (composition_gstring_p, composition_reseat_it)
640 (composition_adjust_point): Use EMACS_INT, not int.
641 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
642 not EMACS_UINT, for indexes.
643
644 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
645
646 * buffer.c: Include <verify.h>.
647 (struct sortvec.priority, struct sortstr.priority):
648 Now EMACS_INT, not int.
649 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
650 (struct sortstr.size, record_overlay_string)
651 (struct sortstrlist.size, struct sortlist.used):
652 Don't truncate size to int.
653 (record_overlay_string): Check for size-calculation overflow.
654 (init_buffer_once): Check at compile-time, not run-time.
655
656 2011-06-22 Jim Meyering <meyering@redhat.com>
657
658 Don't leak an XBM-image-sized buffer
659 * image.c (xbm_load): Free the image buffer after using it.
660
661 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
662
663 Port to Sun C.
664 * composite.c (find_automatic_composition): Omit needless 'return 0;'
665 that Sun C diagnosed.
666 * fns.c (secure_hash): Fix pointer signedness issue.
667 * intervals.c (static_offset_intervals): New function.
668 (offset_intervals): Use it.
669
670 2011-06-21 Leo Liu <sdl.web@gmail.com>
671
672 * deps.mk (fns.o):
673 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
674 sha512.h.
675
676 * fns.c (secure_hash): Rename from crypto_hash_function and change
677 the first arg to accept symbols.
678 (Fsecure_hash): New primitive.
679 (syms_of_fns): New symbols.
680
681 2011-06-20 Deniz Dogan <deniz@dogan.se>
682
683 * process.c (Fset_process_buffer): Clarify return value in
684 docstring.
685
686 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
687
688 * dispnew.c (add_window_display_history): Use BVAR.
689
690 * xdisp.c (debug_method_add): Use BVAR.
691 (check_window_end, dump_glyph_matrix, dump_glyph)
692 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
693
694 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
695 Likewise.
696
697 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
698 check till after the cache is created in init_frame_faces.
699
700 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
701
702 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
703
704 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
705
706 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
707 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
708 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
709
710 Improve buffer-overflow checking (Bug#8873).
711 * fileio.c (Finsert_file_contents):
712 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
713 Remove the old (too-loose) buffer overflow checks.
714 They weren't needed, since make_gap checks for buffer overflow.
715 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
716 The old code merely checked for Emacs fixnum overflow, and relied
717 on undefined (wraparound) behavior. The new code avoids undefined
718 behavior, and also checks for ptrdiff_t and/or size_t overflow.
719
720 * editfns.c (Finsert_char): Don't dump core with very negative counts.
721 Tune. Don't use wider integers than needed. Don't use alloca.
722 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
723
724 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
725
726 * insdel.c, lisp.h (buffer_overflow): New function.
727 (insert_from_buffer_1, replace_range, replace_range_2):
728 * insdel.c (make_gap_larger):
729 * editfns.c (Finsert_char):
730 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
731
732 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
733
734 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
735
736 Integer overflow and signedness fixes (Bug#8873).
737
738 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
739 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
740
741 * fileio.c: Don't assume EMACS_INT fits in off_t.
742 (emacs_lseek): New static function.
743 (Finsert_file_contents, Fwrite_region): Use it.
744 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
745
746 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
747
748 * fns.c: Don't overflow int when computing a list length.
749 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
750 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
751 truncation on 64-bit hosts. Check for QUIT every
752 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
753 faster and is responsive enough.
754 (Flength): Report an error instead of overflowing an integer.
755 (Fsafe_length): Return a float if the value is not representable
756 as a fixnum. This shouldn't happen except in contrived situations.
757 (Fnthcdr, Fsort): Don't assume list length fits in int.
758 (Fcopy_sequence): Don't assume vector length fits in int.
759
760 * alloc.c: Check that resized vectors' lengths fit in fixnums.
761 (header_size, word_size): New constants.
762 (allocate_vectorlike): Don't check size overflow here.
763 (allocate_vector): Check it here instead, since this is the only
764 caller of allocate_vectorlike that could cause overflow.
765 Check that the new vector's length is representable as a fixnum.
766
767 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
768 The previous code was bogus. For example, next_almost_prime (32)
769 returned 39, which is undesirable as it is a multiple of 3; and
770 next_almost_prime (24) returned 25, which is a multiple of 5 so
771 why was the code bothering to check for multiples of 7?
772
773 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
774
775 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
776
777 Variadic C functions now count arguments with ptrdiff_t.
778 This partly undoes my 2011-03-30 change, which replaced int with size_t.
779 Back then I didn't know that the Emacs coding style prefers signed int.
780 Also, in the meantime I found a few more instances where arguments
781 were being counted with int, which may truncate counts on 64-bit
782 machines, or EMACS_INT, which may be unnecessarily wide.
783 * lisp.h (struct Lisp_Subr.function.aMANY)
784 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
785 Arg counts are now ptrdiff_t, not size_t.
786 All variadic functions and their callers changed accordingly.
787 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
788 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
789 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
790 * callint.c (Fcall_interactively): Check arg count for overflow,
791 to avoid potential buffer overrun. Use signed char, not 'int',
792 for 'varies' array, so that we needn't bother to check its size
793 calculation for overflow.
794 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
795 * eval.c (apply_lambda):
796 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
797 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
798 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
799
800 * callint.c (Fcall_interactively): Don't use index var as event count.
801
802 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
803 * mem-limits.h (SIZE): Remove; no longer used.
804
805 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
806
807 Remove unnecessary casts.
808 * xterm.c (x_term_init):
809 * xfns.c (x_set_border_pixel):
810 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
811 These aren't needed now that we assume ANSI C.
812
813 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
814 It's more likely to cause problems (due to unsigned overflow)
815 than to cure them.
816
817 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
818
819 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
820
821 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
822
823 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
824
825 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
826
827 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
828
829 GLYPH_CODE_FACE returns EMACS_INT, not int.
830 * dispextern.h (merge_faces):
831 * xfaces.c (merge_faces):
832 * xdisp.c (get_next_display_element, next_element_from_display_vector):
833 Don't assume EMACS_INT fits in int.
834
835 * character.h (CHAR_VALID_P): Remove unused parameter.
836 * fontset.c, lisp.h, xdisp.c: All uses changed.
837
838 * editfns.c (Ftranslate_region_internal): Omit redundant test.
839
840 * fns.c (concat): Minor tuning based on overflow analysis.
841 This doesn't fix any bugs. Use int to hold character, instead
842 of constantly refetching from Emacs object. Use XFASTINT, not
843 XINT, for value known to be a character. Don't bother comparing
844 a single byte to 0400, as it's always less.
845
846 * floatfns.c (Fexpt):
847 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
848
849 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
850 for characters.
851
852 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
853
854 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
855 Without this fix, on a 64-bit host (aset S 0 4294967386) would
856 incorrectly succeed when S was a string, because 4294967386 was
857 truncated before it was used.
858
859 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
860 Otherwise, an out-of-range integer could cause undefined behavior
861 on a 64-bit host.
862
863 * composite.c: Use int, not EMACS_INT, for characters.
864 (fill_gstring_body, composition_compute_stop_pos): Use int, not
865 EMACS_INT, for values that are known to be in character range.
866 This doesn't fix any bugs but is the usual style inside Emacs and
867 may generate better code on 32-bit machines.
868
869 Make sure a 64-bit char is never passed to ENCODE_CHAR.
870 This is for reasons similar to the recent CHAR_STRING fix.
871 * charset.c (Fencode_char): Check that character arg is actually
872 a character. Pass an int to ENCODE_CHAR.
873 * charset.h (ENCODE_CHAR): Verify that the character argument is no
874 wider than 'int', as a compile-time check to prevent future regressions
875 in this area.
876
877 * character.c (char_string): Remove unnecessary casts.
878
879 Make sure a 64-bit char is never passed to CHAR_STRING.
880 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
881 by silently ignoring the top 32 bits, allowing some values
882 that were far too large to be valid characters.
883 * character.h: Include <verify.h>.
884 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
885 arguments are no wider than unsigned, as a compile-time check
886 to prevent future regressions in this area.
887 * data.c (Faset):
888 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
889 (Fsubst_char_in_region):
890 * fns.c (concat):
891 * xdisp.c (decode_mode_spec_coding):
892 Adjust to CHAR_STRING's new requirement.
893 * editfns.c (Finsert_char, Fsubst_char_in_region):
894 * fns.c (concat): Check that character args are actually
895 characters. Without this test, these functions did the wrong
896 thing with wildly out-of-range values on 64-bit hosts.
897
898 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
899 These casts should not be needed on 32-bit hosts, either.
900 * keyboard.c (read_char):
901 * lread.c (Fload): Remove casts to unsigned.
902
903 * lisp.h (UNSIGNED_CMP): New macro.
904 This fixes comparison bugs on 64-bit hosts.
905 (ASCII_CHAR_P): Use it.
906 * casefiddle.c (casify_object):
907 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
908 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
909 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
910 * dispextern.h (FACE_FROM_ID):
911 * keyboard.c (read_char): Use UNSIGNED_CMP.
912
913 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
914 not to EMACS_INT, to avoid GCC warning.
915
916 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
917
918 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
919 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
920 isn't needed on 32-bit machines.
921
922 * buffer.c (Fgenerate_new_buffer_name):
923 Use EMACS_INT for count, not int.
924 (advance_to_char_boundary): Return EMACS_INT, not int.
925
926 * data.c (Qcompiled_function): Now static.
927
928 * window.c (window_body_lines): Now static.
929
930 * image.c (gif_load): Rename local to avoid shadowing.
931
932 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
933 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
934 * alloc.c (make_save_value): Integer argument is now of type
935 ptrdiff_t, not int.
936 (mark_object): Use ptrdiff_t, not int.
937 * lisp.h (pD): New macro.
938 * print.c (print_object): Use it.
939
940 * alloc.c: Use EMACS_INT, not int, to count objects.
941 (total_conses, total_markers, total_symbols, total_vector_size)
942 (total_free_conses, total_free_markers, total_free_symbols)
943 (total_free_floats, total_floats, total_free_intervals)
944 (total_intervals, total_strings, total_free_strings):
945 Now EMACS_INT, not int. All uses changed.
946 (Fgarbage_collect): Compute overall total using a double, so that
947 integer overflow is less likely to be a problem. Check for overflow
948 when converting back to an integer.
949 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
950 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
951 These were 'int' variables that could overflow on 64-bit hosts;
952 they were never used, so remove them instead of repairing them.
953 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
954 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
955 Previously, this ceilinged at INT_MAX, but that doesn't work on
956 64-bit machines.
957 (allocate_pseudovector): Don't use EMACS_INT when int would do.
958
959 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
960 (allocate_vectorlike): Check for ptrdiff_t overflow.
961 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
962 when a (possibly-narrower) signed value would do just as well.
963 We prefer using signed arithmetic, to avoid comparison confusion.
964
965 * alloc.c: Catch some string size overflows that we were missing.
966 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
967 for convenience in STRING_BYTES_MAX.
968 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
969 The definition here is exact; the one in lisp.h was approximate.
970 (allocate_string_data): Check for string overflow. This catches
971 some instances we weren't catching before. Also, it catches
972 size_t overflow on (unusual) hosts where SIZE_MAX <= min
973 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
974 and ptrdiff_t and EMACS_INT are both 64 bits.
975
976 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
977 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
978 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
979
980 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
981
982 * alloc.c (Fmake_string): Check for out-of-range init.
983
984 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
985
986 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
987
988 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
989
990 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
991 xg_get_default_scrollbar_width.
992
993 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
994 (int_gtk_range_get_value): Move to the scroll bar part of the file.
995 (style_changed_cb): Call update_theme_scrollbar_width and call
996 x_set_scroll_bar_default_width and xg_frame_set_char_size for
997 all frames (Bug#8505).
998 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
999 Call gtk_window_set_resizable if HAVE_GTK3.
1000 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1001 and height if HAVE_GTK3 (Bug#8505).
1002 (scroll_bar_width_for_theme): New variable.
1003 (update_theme_scrollbar_width): New function.
1004 (xg_get_default_scrollbar_width): Move code to
1005 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1006 (xg_initialize): Call update_theme_scrollbar_width.
1007
1008 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1009
1010 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1011
1012 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1013
1014 * frame.c (make_frame): Call other_buffer_safely instead of
1015 other_buffer.
1016
1017 * window.c (temp_output_buffer_show): Call display_buffer with
1018 second argument Vtemp_buffer_show_specifiers and reset latter
1019 immediately after the call.
1020 (Vtemp_buffer_show_specifiers): New variable.
1021 (auto_window_vscroll_p, next_screen_context_lines)
1022 (Vscroll_preserve_screen_position): Remove leading asterisks from
1023 doc-strings.
1024
1025 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1026
1027 Fix minor problems found by GCC 4.6.0 static checking.
1028 * buffer.c (Qclone_number): Remove for now, as it's unused.
1029 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1030 (record_buffer): Remove unused local.
1031 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1032 (set_frame_buffer_list): Remove; unused.
1033 * frame.h (other_visible_frames): Remove decl.
1034 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1035 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1036 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1037 if HAVE_GPM.
1038 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1039 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1040 Define only if HAVE_GPM.
1041 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1042 (update_hints_inhibit): Remove; never set. All uses removed.
1043 * widgetprv.h (emacsFrameClassRec): Remove decl.
1044 * window.c (delete_deletable_window): Now returns void, since it
1045 wasn't returning anything.
1046 (compare_window_configurations): Remove unused locals.
1047 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1048 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1049 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1050 the same widths as pointers. This follows up on the 2011-05-06 patch.
1051 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1052 * xterm.h: Likewise.
1053 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1054
1055 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1056
1057 * makefile.w32-in: Update dependencies.
1058 (LISP_H): Add lib/intprops.h.
1059
1060 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1061
1062 * image.c (gif_load): Add animation frame delay to the metadata.
1063 (syms_of_image): Use DEFSYM. New symbol `delay'.
1064
1065 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1066
1067 * window.c (delete_deletable_window): Re-add.
1068 (Fset_window_configuration): Rewrite to handle dead buffers and
1069 consequently deletable windows.
1070 (window_tree, Fwindow_tree): Remove. Supply functionality in
1071 window.el.
1072 (compare_window_configurations): Simplify code.
1073
1074 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1075
1076 * image.c (imagemagick_load_image): Fix type mismatch.
1077 (Fimagemagick_types): Likewise.
1078
1079 * window.h (replace_buffer_in_windows): Declare.
1080
1081 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1082
1083 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1084 Qclone_number. Remove external declaration of Qdelete_window.
1085 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1086 code.
1087 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1088 Qbuffer_list_update_hook if allowed.
1089 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1090 buffer list implementation.
1091 (other_buffer_safely): New function.
1092 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1093 calls to replace_buffer_in_windows and
1094 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1095 if allowed.
1096 (record_buffer): Inhibit quitting and rewrite using quittable
1097 functions. Run Qbuffer_list_update_hook if allowed.
1098 (Frecord_buffer, Funrecord_buffer): New functions.
1099 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1100 switch-to-buffer to window.el.
1101 (bury-buffer): Move to window.el.
1102 (Vbuffer_list_update_hook): New variable.
1103
1104 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1105 section.
1106
1107 * window.h (resize_frame_windows): Move up in code.
1108 (Fwindow_frame): Remove EXFUN.
1109 (replace_buffer_in_all_windows): Remove prototype.
1110 (replace_buffer_in_windows_safely): Add prototype.
1111
1112 * window.c: Declare Qdelete_window static again. Move down
1113 declaration of select_count.
1114 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1115 (Fother_window): Move to window.el.
1116 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1117 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1118 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1119 window.el.
1120 (replace_buffer_in_windows): Implement by calling
1121 Qreplace_buffer_in_windows.
1122 (replace_buffer_in_all_windows): Remove with some functionality
1123 moved into replace_buffer_in_windows_safely.
1124 (replace_buffer_in_windows_safely): New function.
1125 (select_window_norecord, select_frame_norecord): Move in front
1126 of run_window_configuration_change_hook. Remove now obsolete
1127 declarations.
1128 (Fset_window_buffer): Rewrite doc-string. Call
1129 Qrecord_window_buffer.
1130 (keys_of_window): Move binding for other-window to window.el.
1131
1132 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1133
1134 * dispextern.h (struct image): Replace data member, whose int_val
1135 and ptr_val fields were not used by anything, with a single
1136 lisp_val object.
1137
1138 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1139 (gif_clear_image, gif_load, imagemagick_load_image)
1140 (gs_clear_image, gs_load): Callers changed.
1141
1142 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1143
1144 * buffer.h: Include <time.h>, for time_t.
1145 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1146
1147 Fix minor problems found by static checking.
1148
1149 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1150
1151 Make identifiers static if they are not used in other modules.
1152 * data.c (Qcompiled_function, Qframe, Qvector):
1153 * image.c (QimageMagick, Qsvg):
1154 * minibuf.c (Qmetadata):
1155 * window.c (resize_window_check, resize_root_window): Now static.
1156 * window.h (resize_window_check, resize_root_window): Remove decls.
1157
1158 * window.c (window_deletion_count, delete_deletable_window):
1159 Remove; unused.
1160 (window_body_lines): Now static.
1161 (Fdelete_other_windows_internal): Mark vars as initialized.
1162 Make sure 'resize_failed' is initialized.
1163 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1164 (resize_window_apply): Remove unused local.
1165 * window.h (delete_deletable_window): Remove decl.
1166
1167 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1168 (imagemagick_load_image): Fix pointer signedness problem by changing
1169 last arg from unsigned char * to char *. All uses changed.
1170 Also, fix a local for similar reasons.
1171 Remove unused locals. Remove locals to avoid shadowing.
1172 (fn_rsvg_handle_free): Remove; unused.
1173 (svg_load, svg_load_image): Fix pointer signedness problem.
1174 (imagemagick_load_image): Don't use garbage pointer image_wand.
1175
1176 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1177
1178 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1179
1180 * image.c (gif_load): Fix omitted cast error introduced by
1181 2011-06-06 change.
1182
1183 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1184
1185 * window.h (resize_proportionally, orig_total_lines)
1186 (orig_top_line): Remove from window structure.
1187 (set_window_height, set_window_width, change_window_heights)
1188 (Fdelete_window): Remove prototypes.
1189 (resize_frame_windows): Remove duplicate declaration.
1190
1191 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1192
1193 * window.h (resize_frame_windows, resize_window_check)
1194 (delete_deletable_window, resize_root_window)
1195 (resize_frame_windows): Declare prototypes.
1196
1197 * window.c (resize_window_apply): Make definition be "static" to
1198 match the prototype.
1199
1200 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1201
1202 * window.c: Remove declarations of Qwindow_size_fixed,
1203 window_min_size_1, window_min_size_2, window_min_size,
1204 size_window, window_fixed_size_p, enlarge_window, delete_window.
1205 Remove static from declaration of Qdelete_window, it's
1206 temporarily needed by Fbury_buffer.
1207 (replace_window): Don't assign orig_top_line and
1208 orig_total_lines.
1209 (Fdelete_window, delete_window): Remove. Window deletion is
1210 handled by window.el.
1211 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1212 Fdelete_window calls with calls to Qdelete_window.
1213 (Fdelete_other_windows): Remove. Deleting other windows is
1214 handled by window.el.
1215 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1216 handled in window.el.
1217 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1218 Window minimum sizes are handled in window.el.
1219 (shrink_windows, size_window, set_window_height)
1220 (set_window_width, change_window_heights, window_height)
1221 (window_width, CURBEG, CURSIZE, enlarge_window)
1222 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1223 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1224 handled in window.el.
1225 (make_dummy_parent): Rename to make_parent_window and give it a
1226 second argument horflag.
1227 (make_window): Don't set resize_proportionally any more.
1228 (Fsplit_window): Remove. Windows are split in window.el.
1229 (save_restore_action, save_restore_orig_size)
1230 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1231 Resize mini windows in window.el.
1232 (grow_mini_window, shrink_mini_window): Implement by calling
1233 Qresize_root_window_vertically, resize_window_check and
1234 resize_window_apply.
1235 (saved_window, Fset_window_configuration, save_window_save): Do
1236 not handle orig_top_line, orig_total_lines, and
1237 resize_proportionally.
1238 (window_min_height, window_min_width): Move to window.el.
1239 (keys_of_window): Move bindings for delete-other-windows,
1240 split-window, delete-window and enlarge-window to window.el.
1241
1242 * buffer.c: Temporarily extern Qdelete_window.
1243 (Fbury_buffer): Temporarily call Qdelete_window instead of
1244 Fdelete_window (Fbury_buffer will move to window.el soon).
1245
1246 * frame.c (set_menu_bar_lines_1): Remove code handling
1247 orig_top_line and orig_total_lines.
1248
1249 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1250 set_window_height but set heights directly.
1251 (change_frame_size_1): Use resize_frame_windows.
1252
1253 * xdisp.c (init_xdisp): Don't use set_window_height but set
1254 heights directly.
1255
1256 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1257 resize_frame_windows instead of change_window_heights and run
1258 run_window_configuration_change_hook.
1259
1260 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1261 instead of change_window_heights and run
1262 run_window_configuration_change_hook.
1263
1264 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1265
1266 * window.c (replace_window): Rename second argument REPLACEMENT to
1267 NEW. New third argument SETFLAG. Rewrite.
1268 (delete_window, make_dummy_parent): Call replace_window with
1269 third argument 1.
1270 (window_list_1): Move down in code.
1271 (run_window_configuration_change_hook): Move set_buffer part
1272 before select_frame_norecord part in order to unwind correctly.
1273 Rename count1 to count.
1274 (recombine_windows, delete_deletable_window, resize_root_window)
1275 (Fdelete_other_windows_internal)
1276 (Frun_window_configuration_change_hook, make_parent_window)
1277 (resize_window_check, resize_window_apply, Fresize_window_apply)
1278 (resize_frame_windows, Fsplit_window_internal)
1279 (Fdelete_window_internal, Fresize_mini_window_internal): New
1280 functions.
1281 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1282
1283 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1284
1285 * window.h (window): Add some new members to window structure -
1286 normal_lines, normal_cols, new_total, new_normal, clone_number,
1287 splits, nest, prev_buffers, next_buffers.
1288 (WINDOW_TOTAL_SIZE): Move here from window.c.
1289 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1290
1291 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1292 Remove.
1293 (make_dummy_parent): Set new members of windows structure.
1294 (make_window): Move down in code. Handle new members of window
1295 structure.
1296 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1297 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1298 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1299 (Fset_window_prev_buffers, Fwindow_next_buffers)
1300 (Fset_window_next_buffers, Fset_window_clone_number): New
1301 functions.
1302 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1303 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1304 Doc-string fixes.
1305 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1306 Argument WINDOW can be now internal window too.
1307 (Fwindow_use_time): Move up in code.
1308 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1309 Rewrite doc-string.
1310 (Fset_window_configuration, saved_window)
1311 (Fcurrent_window_configuration, save_window_save): Handle new
1312 members of window structure.
1313 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1314 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1315 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1316 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1317 Qget_mru_window, Qresize_root_window,
1318 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1319 Qauto_buffer_name; staticpro them.
1320
1321 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1322
1323 * window.c (Fwindow_total_size, Fwindow_left_column)
1324 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1325 (Fwindow_list_1): New functions.
1326 (window_box_text_cols): Replace with window_body_cols.
1327 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1328 window_body_cols instead of window_box_text_cols.
1329 (delete_window, Fset_window_configuration): Call
1330 delete_all_subwindows with window as argument.
1331 (delete_all_subwindows): Take a window as argument and not a
1332 structure. Rewrite.
1333 (window_loop): Remove handling of GET_LRU_WINDOW and
1334 GET_LARGEST_WINDOW.
1335 (Fget_lru_window, Fget_largest_window): Move to window.el.
1336
1337 * window.h: Extern window_body_cols instead of
1338 window_box_text_cols. delete_all_subwindows now takes a
1339 Lisp_Object as argument.
1340
1341 * indent.c (compute_motion, Fcompute_motion): Use
1342 window_body_cols instead of window_box_text_cols.
1343
1344 * frame.c (delete_frame): Call delete_all_subwindows with root
1345 window as argument.
1346
1347 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1348
1349 * fns.c (Fputhash): Document return value.
1350
1351 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1352
1353 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1354
1355 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1356
1357 Cons<->int and similar integer overflow fixes (Bug#8794).
1358
1359 Check for overflow when converting integer to cons and back.
1360 * charset.c (Fdefine_charset_internal, Fdecode_char):
1361 Use cons_to_unsigned to catch overflow.
1362 (Fencode_char): Use INTEGER_TO_CONS.
1363 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1364 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1365 * data.c (long_to_cons, cons_to_long): Remove.
1366 (cons_to_unsigned, cons_to_signed): New functions.
1367 These signal an error for invalid or out-of-range values.
1368 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1369 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1370 * font.c (Ffont_variation_glyphs):
1371 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1372 * lisp.h: Include <intprops.h>.
1373 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1374 (cons_to_signed, cons_to_unsigned): New decls.
1375 (long_to_cons, cons_to_long): Remove decls.
1376 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1377 (Fprimitive_undo): Use CONS_TO_INTEGER.
1378 * xfns.c (Fx_window_property): Likewise.
1379 * xselect.c: Include <limits.h>.
1380 (x_own_selection, selection_data_to_lisp_data):
1381 Use INTEGER_TO_CONS.
1382 (x_handle_selection_request, x_handle_selection_clear)
1383 (x_get_foreign_selection, Fx_disown_selection_internal)
1384 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1385 (lisp_data_to_selection_data): Use cons_to_unsigned.
1386 (x_fill_property_data): Use cons_to_signed.
1387 Report values out of range.
1388
1389 Check for buffer and string overflow more precisely.
1390 * buffer.h (BUF_BYTES_MAX): New macro.
1391 * lisp.h (STRING_BYTES_MAX): New macro.
1392 * alloc.c (Fmake_string):
1393 * character.c (string_escape_byte8):
1394 * coding.c (coding_alloc_by_realloc):
1395 * doprnt.c (doprnt):
1396 * editfns.c (Fformat):
1397 * eval.c (verror):
1398 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1399 since they may not be the same number.
1400 * editfns.c (Finsert_char):
1401 * fileio.c (Finsert_file_contents):
1402 Likewise for BUF_BYTES_MAX.
1403
1404 * image.c: Use ptrdiff_t, not int, for sizes.
1405 (slurp_file): Switch from int to ptrdiff_t.
1406 All uses changed.
1407 (slurp_file): Check that file size fits in both size_t (for
1408 malloc) and ptrdiff_t (for sanity and safety).
1409
1410 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1411 if b->modtime has its maximal value.
1412
1413 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1414
1415 Don't assume time_t can fit into int.
1416 * buffer.h (struct buffer.modtime): Now time_t, not int.
1417 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1418 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1419
1420 Minor fixes for signed vs unsigned integers.
1421 * character.h (MAYBE_UNIFY_CHAR):
1422 * charset.c (maybe_unify_char):
1423 * keyboard.c (read_char, reorder_modifiers):
1424 XINT -> XFASTINT, since the integer must be nonnegative.
1425 * ftfont.c (ftfont_spec_pattern):
1426 * keymap.c (access_keymap, silly_event_symbol_error):
1427 XUINT -> XFASTINT, since the integer must be nonnegative.
1428 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1429 since it makes no difference and we prefer signed.
1430 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1431 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1432 nonnegative.
1433
1434 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1435
1436 * window.h (Fwindow_frame): Declare.
1437
1438 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1439
1440 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1441 (SPARE_MEMORY): Always define.
1442 (LARGE_REQUEST): Remove.
1443 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1444
1445 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1446
1447 * lisp.h: Move EXFUNS for Fframe_root_window,
1448 Fframe_first_window and Fset_frame_selected_window to window.h.
1449
1450 * window.h: Move EXFUNS for Fframe_root_window,
1451 Fframe_first_window and Fset_frame_selected_window here from
1452 lisp.h.
1453
1454 * frame.c (Fwindow_frame, Fframe_first_window)
1455 (Fframe_root_window, Fframe_selected_window)
1456 (Fset_frame_selected_window): Move to window.c.
1457 (Factive_minibuffer_window): Move to minibuf.c.
1458 (Fother_visible_frames_p): New function.
1459
1460 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1461
1462 * window.c (decode_window, decode_any_window): Move up in code.
1463 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1464 (inhibit_frame_unsplittable): Remove unused variable.
1465 (Fwindow_buffer): Move up and rewrite doc-string.
1466 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1467 (Fwindow_prev): New functions.
1468 (Fwindow_frame): Move here from frame.c. Accept any window as
1469 argument.
1470 (Fframe_root_window, Fframe_first_window)
1471 (Fframe_selected_window): Move here from frame.c. Accept frame
1472 or arbitrary window as argument. Update doc-strings.
1473 (Fminibuffer_window): Move up in code.
1474 (Fwindow_minibuffer_p): Move up in code and simplify.
1475 (Fset_frame_selected_window): Move here from frame.c.
1476 Marginal rewrite.
1477 (Fselected_window, select_window, Fselect_window): Move up in
1478 code. Minor doc-string fixes.
1479
1480 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1481
1482 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1483 Do not assume that spare memory exists; that assumption is valid
1484 only if SYSTEM_MALLOC.
1485 (LARGE_REQUEST): New macro, so that the issue of large requests
1486 is separated from the issue of spare memory.
1487
1488 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1489
1490 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1491 format. (Bug#8806)
1492
1493 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1494
1495 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1496 before statements.
1497
1498 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1499
1500 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1501
1502 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1503
1504 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1505 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1506
1507 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1508
1509 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1510
1511 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1512
1513 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1514 (x_clipboard_manager_save): Add return value.
1515 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1516 New error handlers.
1517 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1518 Obey Vx_select_enable_clipboard_manager. Catch errors in
1519 x_clipboard_manager_save (Bug#8779).
1520 (Vx_select_enable_clipboard_manager): New variable.
1521 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1522
1523 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1524
1525 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1526
1527 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1528
1529 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1530 in the current matrix if keep_current_p is non-zero.
1531
1532 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1533
1534 * bidi.c (bidi_level_of_next_char): Fix last change.
1535
1536 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1537
1538 Support bidi reordering of text covered by display properties.
1539
1540 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1541 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1542 (bidi_cache_search, bidi_cache_iterator_state)
1543 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1544 (bidi_level_of_next_char, bidi_move_to_visually_next):
1545 Support character positions inside a run of characters covered by a
1546 display string.
1547 (bidi_paragraph_init, bidi_resolve_explicit_1)
1548 (bidi_level_of_next_char): Call bidi_fetch_char and
1549 bidi_fetch_char_advance instead of FETCH_CHAR and
1550 FETCH_CHAR_ADVANCE.
1551 (bidi_init_it): Initialize new members.
1552 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1553 definitions.
1554 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1555 instead of using explicit *_CHAR codes.
1556 (bidi_resolve_explicit, bidi_resolve_weak):
1557 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1558 bidirectional text is supported only in multibyte buffers.
1559 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1560 it to initialize the frame_window_p member of struct bidi_it.
1561 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1562 (bidi_resolve_explicit, bidi_resolve_weak)
1563 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1564 bidi_it->nchars is non-positive.
1565 (bidi_level_of_next_char): Don't try to lookup the cache for the
1566 next/previous character if nothing is cached there yet, or if we
1567 were just reseat()'ed to a new position.
1568
1569 * xdisp.c (set_cursor_from_row): Set start and stop points
1570 according to the row's direction when priming the loop that looks
1571 for the glyph on which to display cursor.
1572 (single_display_spec_intangible_p): Function deleted.
1573 (display_prop_intangible_p): Reimplement to call
1574 handle_display_spec instead of single_display_spec_intangible_p.
1575 Accept 3 additional arguments needed by handle_display_spec.
1576 This fixes incorrect cursor motion across display property with complex
1577 values: lists, `(when COND...)' forms, etc.
1578 (single_display_spec_string_p): Support property values that are
1579 lists with the argument STRING its top-level element.
1580 (display_prop_string_p): Fix the condition for processing a
1581 property that is a list to be consistent with handle_display_spec.
1582 (handle_display_spec): New function, refactored from the
1583 last portion of handle_display_prop.
1584 (compute_display_string_pos): Accept additional argument
1585 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1586 value of a `display' property is a "replacing spec".
1587 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1588 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1589 the display property, but just return a value indicating whether
1590 the display property will replace the characters it covers.
1591 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1592 frame_window_p members of struct bidi_it.
1593 (compute_display_string_pos, compute_display_string_end):
1594 New functions.
1595 (push_it): Accept second argument POSITION, where pop_it should
1596 jump to continue iteration.
1597 (reseat_1): Initialize bidi_it.disp_pos.
1598
1599 * keyboard.c (adjust_point_for_property): Adjust the call to
1600 display_prop_intangible_p to its new signature.
1601
1602 * dispextern.h (struct bidi_it): New member frame_window_p.
1603 (bidi_init_it): Update prototypes.
1604 (display_prop_intangible_p): Update prototype.
1605 (compute_display_string_pos, compute_display_string_end):
1606 Declare prototypes.
1607 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1608 EMACS_INT.
1609
1610 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1611
1612 Malloc failure behavior now depends on size of allocation.
1613 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1614 * lisp.h: Change signatures accordingly.
1615 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1616 All callers changed. (Bug#8762)
1617
1618 * gnutls.c: Use Emacs's memory allocators.
1619 Without this change, the gnutls library would invoke malloc etc.
1620 directly, which causes problems on non-SYNC_INPUT hosts, and which
1621 runs afoul of improving memory_full behavior. (Bug#8761)
1622 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1623 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1624 xfree instead of the default malloc, realloc, free.
1625 (Fgnutls_boot): No need to check for memory allocation failure,
1626 since xmalloc does that for us.
1627
1628 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1629 * category.c (hash_get_category_set):
1630 * ccl.c (ccl_driver):
1631 * charset.c (Fdefine_charset_internal):
1632 * charset.h (struct charset.hash_index):
1633 * composite.c (get_composition_id, gstring_lookup_cache)
1634 (composition_gstring_put_cache):
1635 * composite.h (struct composition.hash_index):
1636 * dispextern.h (struct image.hash):
1637 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1638 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1639 (hashfn_equal, hashfn_user_defined, make_hash_table)
1640 (maybe_resize_hash_table, hash_lookup, hash_put)
1641 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1642 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1643 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1644 * image.c (make_image, search_image_cache, lookup_image)
1645 (xpm_put_color_table_h):
1646 * lisp.h (struct Lisp_Hash_Table):
1647 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1648 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1649 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1650 * alloc.c (allocate_vectorlike):
1651 Check for overflow in vector size calculations.
1652 * ccl.c (ccl_driver):
1653 Check for overflow when converting EMACS_INT to int.
1654 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1655 need to be updated by these changes.
1656 * fns.c (make_hash_table, maybe_resize_hash_table):
1657 Check for integer overflow with large hash tables.
1658 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1659 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1660 (SXHASH_REDUCE): New macro.
1661 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1662 Use it instead of discarding useful hash info with large hash values.
1663 (sxhash_float): New function.
1664 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1665 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1666 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1667 Rewrite to use FIXNUM_BITS, as this simplifies things.
1668 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1669 Adjust signatures to match updated version of code.
1670 (consing_since_gc): Now EMACS_INT, since a single hash table can
1671 use more than INT_MAX bytes.
1672
1673 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1674
1675 Make it possible to build with GCC-4.6+ -O2 -flto.
1676
1677 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1678
1679 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1680
1681 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1682 Call minibuffer-inactive-mode.
1683
1684 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1685
1686 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1687 Update dependencies.
1688
1689 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1690
1691 * data.c (init_data): Remove code for UTS, this system is not
1692 supported anymore.
1693
1694 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1695
1696 Don't force ./temacs to start in terminal mode.
1697
1698 * frame.c (make_initial_frame): Initialize faces in all cases, not
1699 only when CANNOT_DUMP is defined.
1700 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1701
1702 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1703
1704 * dispnew.c (add_window_display_history): Use const for the string
1705 pointer. Remove declaration, not needed.
1706
1707 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1708
1709 Use 'inline', not 'INLINE'.
1710 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1711 * alloc.c, fontset.c (INLINE): Remove.
1712 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1713 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1714 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1715 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1716 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1717
1718 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1719
1720 Make it possible to run ./temacs.
1721
1722 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1723 syms_of_callproc does the same thing. Remove test for
1724 "initialized", do it in the caller.
1725 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1726
1727 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1728
1729 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1730 (read_minibuf): Use get_minibuffer.
1731 (syms_of_minibuf): Use DEFSYM.
1732 (Qmetadata): New var.
1733 * data.c (Qbuffer): Don't make it static.
1734 (syms_of_data): Use DEFSYM.
1735
1736 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1737
1738 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1739 (CCL_CODE_MIN): New macro.
1740
1741 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1742
1743 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1744
1745 * eval.c (Qdebug): Now static.
1746 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1747 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1748 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1749
1750 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1751
1752 * image.c: Various fixes to ImageMagick code comments.
1753 (Fimagemagick_types): Doc fix.
1754
1755 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1756
1757 Minor fixes prompted by GCC 4.6.0 warnings.
1758
1759 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1760
1761 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1762 (x_clipboard_manager_save_all): Move extern decl to ...
1763 * xterm.h: ... here, so that it can be checked for consistency.
1764
1765 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1766
1767 * xselect.c (x_clipboard_manager_save_frame)
1768 (x_clipboard_manager_save_all): New functions.
1769 (Fx_clipboard_manager_save): Lisp function deleted.
1770
1771 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1772 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1773
1774 * xterm.h: Update prototype.
1775
1776 2011-05-28 William Xu <william.xwl@gmail.com>
1777
1778 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1779 exiting (Bug#8239).
1780
1781 2011-05-28 Jim Meyering <meyering@redhat.com>
1782
1783 Avoid a sign-extension bug in crypto_hash_function.
1784 * fns.c (to_uchar): Define.
1785 (crypto_hash_function): Use it to convert some newly-signed
1786 variables to unsigned, to avoid sign-extension bugs. For example,
1787 without this change, (md5 "truc") would evaluate to
1788 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1789 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1790 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1791
1792 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1793
1794 Integer overflow fixes.
1795
1796 * dbusbind.c: Serial number integer overflow fixes.
1797 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1798 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1799 to hold a serial number that is too large for a fixnum.
1800 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1801 Check for serial numbers out of range. Decode any serial number
1802 that was so large that it became a float. (Bug#8722)
1803
1804 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1805 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1806 Use XFASTINT rather than XUINT when numbers are nonnegative.
1807 (xd_append_arg, Fdbus_method_return_internal):
1808 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1809 arguments, check that Lisp number is nonnegative, rather than
1810 silently wrapping negative numbers around. (Bug#8722)
1811 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1812 (Bug#8722)
1813
1814 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1815
1816 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1817
1818 ccl: add integer overflow checks
1819 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1820 (IN_INT_RANGE): New macros.
1821 (ccl_driver): Use them to check for integer overflow when
1822 decoding a CCL program. Many of the new checks are whether XINT (x)
1823 fits in int; it doesn't always, on 64-bit hosts. The new version
1824 doesn't catch all possible integer overflows, but it's an
1825 improvement. (Bug#8719)
1826
1827 * alloc.c (make_event_array): Use XINT, not XUINT.
1828 There's no need for unsigned here.
1829
1830 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1831 This follows up to the 2011-05-06 change that substituted uintptr_t
1832 for EMACS_INT. This case wasn't caught back then.
1833
1834 Rework Fformat to avoid integer overflow issues.
1835 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1836 now (part of C89). Include <verify.h>.
1837 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1838 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1839 (Fformat): Avoid the prepass trying to compute sizes; it was only
1840 approximate and thus did not catch overflow reliably. Instead, walk
1841 through the format just once, formatting and computing sizes as we go,
1842 checking for integer overflow at every step, and allocating a larger
1843 buffer as needed. Keep track separately whether the format is
1844 multibyte. Keep only the most-recently calculated precision, rather
1845 than them all. Record whether each argument has been converted to
1846 string. Use EMACS_INT, not int, for byte and char and arg counts.
1847 Support field widths and precisions larger than INT_MAX. Avoid
1848 sprintf's undefined behavior with conversion specifications such as %#d
1849 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1850 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1851 formatting out-of-range floating point numbers with int
1852 formats. (Bug#8668)
1853
1854 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1855
1856 * data.c: Avoid integer truncation in expressions involving floats.
1857 * data.c: Include <intprops.h>.
1858 (arith_driver): When there's an integer overflow in an expression
1859 involving floating point, convert the integers to floating point
1860 so that the resulting value does not suffer from catastrophic
1861 integer truncation. For example, on a 64-bit host (* 4
1862 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1863 Do not rely on undefined behavior after integer overflow.
1864
1865 merge count_size_as_multibyte, parse_str_to_multibyte
1866 * character.c, character.h (count_size_as_multibyte):
1867 Rename from parse_str_to_multibyte; all uses changed.
1868 Check for integer overflow.
1869 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1870 since it's now a duplicate of the other. This is more of
1871 a character than a buffer op, so better that it's in character.c.
1872 * fns.c, print.c: Adjust to above changes.
1873
1874 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1875
1876 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1877
1878 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1879
1880 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1881 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1882 (x_clipboard_manager_save): Now static.
1883 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1884
1885 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1886 (crypto_hash_function): Now static.
1887 Fix pointer signedness problems. Avoid unnecessary initializations.
1888
1889 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1890
1891 * termhooks.h (Vselection_alist): Make it terminal-local.
1892
1893 * terminal.c (create_terminal): Initialize it.
1894
1895 * xselect.c: Support for clipboard managers.
1896 (Vselection_alist): Move to termhooks.h as terminal-local var.
1897 (LOCAL_SELECTION): New macro.
1898 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1899 (symbol_to_x_atom): Remove gratuitous arg.
1900 (x_handle_selection_request, lisp_data_to_selection_data)
1901 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1902 (x_own_selection, x_get_local_selection, x_convert_selection):
1903 New arg, specifying work frame. Use terminal-local Vselection_alist.
1904 (some_frame_on_display): Delete unused function.
1905 (Fx_own_selection_internal, Fx_get_selection_internal)
1906 (Fx_disown_selection_internal, Fx_selection_owner_p)
1907 (Fx_selection_exists_p): New optional frame arg.
1908 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1909 (x_handle_selection_clear): Don't treat other terminals with the
1910 same keyboard specially. Use the terminal-local Vselection_alist.
1911 (x_clear_frame_selections): Use Frun_hook_with_args.
1912
1913 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1914
1915 * xterm.h: Add support for those atoms.
1916
1917 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1918
1919 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1920 (converted_selections, conversion_fail_tag): New global variables.
1921 (x_selection_request_lisp_error): Free the above.
1922 (x_get_local_selection): Remove unnecessary code.
1923 (x_reply_selection_request): Args changed; handle arbitrary array
1924 of converted selections stored in converted_selections.
1925 Separate the XChangeProperty and SelectionNotify steps.
1926 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1927 (x_convert_selection): New function.
1928 (x_handle_selection_event): Simplify.
1929 (x_get_foreign_selection): Don't ignore incoming requests while
1930 waiting for an answer; this will fail when we implement
1931 SAVE_TARGETS, and seems unnecessary anyway.
1932 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1933 (Vx_sent_selection_functions): Doc fix.
1934
1935 2011-05-26 Leo Liu <sdl.web@gmail.com>
1936
1937 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1938
1939 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1940
1941 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1942
1943 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1944 for fringe update if it has periodic bitmap.
1945 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1946 and fringe_bitmap_periodic_p.
1947
1948 * fringe.c (get_fringe_bitmap_data): New function.
1949 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1950 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1951 row. Mark glyph row for fringe update if periodicity changed.
1952
1953 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1954 for fringe update unless it has periodic bitmap.
1955
1956 2011-05-25 Kenichi Handa <handa@m17n.org>
1957
1958 * xdisp.c (get_next_display_element): Set correct it->face_id for
1959 a static composition.
1960
1961 2011-05-24 Leo Liu <sdl.web@gmail.com>
1962
1963 * deps.mk (fns.o):
1964 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1965
1966 * fns.c (crypto_hash_function, Fsha1): New function.
1967 (Fmd5): Use crypto_hash_function.
1968 (syms_of_fns): Add Ssha1.
1969
1970 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1971
1972 * gnutls.c: Remove unused macros.
1973 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1974 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1975 Remove macros that are defined and never used.
1976 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1977
1978 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1979
1980 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1981 (Fx_get_selection_internal): Minor cleanup.
1982 (Fx_own_selection_internal): Rename arguments for consistency with
1983 select.el.
1984
1985 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1986
1987 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1988
1989 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1990
1991 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1992
1993 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1994
1995 * dispnew.c (scrolling_window): Don't exclude the case that the
1996 last enabled row in the desired matrix touches the bottom boundary.
1997
1998 2011-05-21 Glenn Morris <rgm@gnu.org>
1999
2000 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2001 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2002 and add some more files.
2003
2004 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2005
2006 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2007 report_file_error introduced by the change from 2011-05-07.
2008
2009 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2010
2011 * systime.h (Time): Define only if emacs is defined.
2012 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2013 where the include path doesn't have X11/X.h by default. See
2014 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2015
2016 2011-05-20 Kenichi Handa <handa@m17n.org>
2017
2018 * composite.c (find_automatic_composition): Fix previous change.
2019
2020 2011-05-20 Glenn Morris <rgm@gnu.org>
2021
2022 * lisp.mk: New file, split from Makefile.in.
2023 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2024 (shortlisp): Remove.
2025 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2026
2027 2011-05-19 Glenn Morris <rgm@gnu.org>
2028
2029 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2030 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2031 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2032 (lisp): Set the order to that of loadup.el.
2033 (shortlisp): Make it a copy of $lisp.
2034 (SOME_MACHINE_LISP): Remove.
2035 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2036 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2037
2038 2011-05-18 Kenichi Handa <handa@m17n.org>
2039
2040 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2041 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2042 (find_automatic_composition): Mostly rewrite for efficiency.
2043
2044 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2045
2046 * makefile.w32-in: Update dependencies.
2047
2048 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2049
2050 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2051 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2052
2053 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2054
2055 Fix some integer overflow issues, such as string length overflow.
2056
2057 * insdel.c (count_size_as_multibyte): Check for string overflow.
2058
2059 * character.c (lisp_string_width): Check for string overflow.
2060 Use EMACS_INT, not int, for string indexes and lengths; in
2061 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2062 the resulting string length overflows an EMACS_INT; instead,
2063 report a string overflow if no precision given. When checking for
2064 precision exhaustion, use a check that cannot possibly have
2065 integer overflow. (Bug#8675)
2066 * character.h (lisp_string_width): Adjust to new signature.
2067
2068 * alloc.c (string_overflow): New function.
2069 (Fmake_string): Use it. This doesn't change behavior, but saves
2070 a few bytes and will simplify future changes.
2071 * character.c (string_escape_byte8): Likewise.
2072 * lisp.h (string_overflow): New decl.
2073
2074 Fixups, following up to the user-interface timestamp change.
2075 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2076 for UI timestamps, instead of unsigned long.
2077 * msdos.c (mouse_get_pos): Likewise.
2078 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2079 * w32gui.h (Time): Define by including "systime.h" rather than by
2080 declaring it ourselves. (Bug#8664)
2081
2082 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2083 * image.c (clear_image_cache): Likewise.
2084
2085 * term.c (term_mouse_position): Don't assume time_t wraparound.
2086
2087 Be more systematic about user-interface timestamps.
2088 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2089 and sometimes 'EMACS_UINT', to represent these timestamps.
2090 This change causes it to use 'Time' uniformly, as that's what X uses.
2091 This makes the code easier to follow, and makes it easier to catch
2092 integer overflow bugs such as Bug#8664.
2093 * frame.c (Fmouse_position, Fmouse_pixel_position):
2094 Use Time, not unsigned long, for user-interface timestamps.
2095 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2096 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2097 * keyboard.h (last_event_timestamp): Likewise.
2098 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2099 * menu.h (xmenu_show): Likewise.
2100 * term.c (term_mouse_position): Likewise.
2101 * termhooks.h (struct input_event.timestamp): Likewise.
2102 (struct terminal.mouse_position_hook): Likewise.
2103 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2104 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2105 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2106 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2107 what it was before.
2108 * menu.h, termhooks.h: Include "systime.h", for Time.
2109
2110 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2111 Don't assume that the difference between two unsigned long values
2112 can fit into an integer. At this point, we know button_down_time
2113 <= event->timestamp, so the difference must be nonnegative, so
2114 there's no need to cast the result if double-click-time is
2115 nonnegative, as it should be; check that it's nonnegative, just in
2116 case. This bug is triggered when events are more than 2**31 ms
2117 apart (about 25 days). (Bug#8664)
2118
2119 * xselect.c (last_event_timestamp): Remove duplicate decl.
2120 (x_own_selection): Remove needless cast to unsigned long.
2121
2122 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2123 that always fit in int. Use a sentinel instead of a counter, to
2124 avoid a temp and to allay GCC's concerns about possible int overflow.
2125 * frame.h (struct frame): Use int for menu_bar_items_used
2126 instead of EMACS_INT, since it always fits in int.
2127
2128 * menu.c (grow_menu_items): Check for int overflow.
2129
2130 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2131
2132 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2133 Before, the code was not consistent. These values cannot exceed
2134 2**31 - 1 so there's no need to make them unsigned.
2135 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2136 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2137 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2138 as modifiers.
2139 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2140
2141 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2142 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2143 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2144 presumably because the widths might not match.
2145
2146 * window.c (size_window): Avoid needless test at loop start.
2147
2148 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2149
2150 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2151
2152 2011-05-12 Drew Adams <drew.adams@oracle.com>
2153
2154 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2155
2156 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2157
2158 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2159 `width' to `bar_area_x' and `bar_area_width', respectively.
2160 (x_scroll_run): Take account of fringe background extension.
2161
2162 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2163 Rename local vars `left' and `width' to `bar_area_x' and
2164 `bar_area_width', respectively.
2165 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2166 background extension.
2167
2168 2011-05-10 Jim Meyering <meyering@redhat.com>
2169
2170 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2171
2172 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2173
2174 * image.c (Finit_image_library): Return t for built-in image types,
2175 like pbm and xbm. (Bug#8640)
2176
2177 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2178
2179 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2180
2181 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2182
2183 * w32console.c (Fset_screen_color): Doc fix.
2184 (Fget_screen_color): New function.
2185 (syms_of_ntterm): Defsubr it.
2186
2187 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2188 unlink the temporary file if Fcall_process didn't create it in the
2189 first place.
2190 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2191 child process will be redirected to a file specified with `:file'.
2192 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2193 cue to call_process_cleanup not to close that handle.
2194
2195 2011-05-07 Ben Key <bkey76@gmail.com>
2196
2197 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2198 one of two shell specific rules, either bootstrap-temacs-CMD or
2199 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2200 to the previous implementation of the bootstrap-temacs rule.
2201 The bootstrap-temacs-CMD rule is similar to the previous
2202 implementation of the bootstrap-temacs rule except that it
2203 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2204 variable.
2205
2206 These changes, along with some changes to nt/configure.bat,
2207 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2208 earlier fix to add support for --cflags and --ldflags options
2209 that include quotes so that it works whether make uses cmd or
2210 sh as the shell.
2211
2212 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2213
2214 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2215 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2216 is a constant.
2217 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2218 a string. Handle both cases.
2219 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2220 (Fdbus_register_method): Use Qinvalid_function.
2221
2222 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2223
2224 * makefile.w32-in: Update dependencies.
2225 (LISP_H): Add inttypes.h and stdin.h.
2226 (PROCESS_H): Add unistd.h.
2227
2228 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2229
2230 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2231 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2232
2233 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2234
2235 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2236
2237 * term.c (vfatal): Remove stray call to va_end.
2238 It's not needed and the C Standard doesn't allow it here anyway.
2239
2240 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2241 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2242
2243 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2244 bytes.
2245
2246 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2247
2248 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2249
2250 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2251
2252 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2253
2254 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2255
2256 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2257 * charset.c (Fdefine_charset_internal): Don't initialize
2258 charset.code_space[15]. The value was garbage, on hosts with
2259 32-bit int (Bug#8600).
2260
2261 * lread.c (read_integer): Be more consistent with string-to-number.
2262 Use string_to_number to do the actual conversion; this avoids
2263 rounding errors and fixes some other screwups. Without this fix,
2264 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2265 (digit_to_number): Move earlier, for benefit of read_integer.
2266 Return -1 if the digit is out of range for the base, -2 if it is
2267 not a digit in any supported base. (Bug#8602)
2268
2269 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2270
2271 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2272 to match comment at start of function. This also removes a
2273 GCC warning about overflow in a 32+64-bit port.
2274
2275 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2276
2277 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2278 Reported by Stefan Monnier in
2279 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2280 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2281 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2282
2283 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2284 (EMACS_UINTPTR): Likewise, with uintptr_t.
2285
2286 * lisp.h: Prefer 64-bit EMACS_INT if available.
2287 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2288 on 32-bit hosts that have 64-bit int, so that they can access
2289 large files.
2290 However, temporarily disable this change unless the temporary
2291 symbol WIDE_EMACS_INT is defined.
2292
2293 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2294
2295 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2296 This removes an assumption that EMACS_INT and long are the same
2297 width as pointers. The assumption is true for Emacs porting targets
2298 now, but we want to make other targets possible.
2299 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2300 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2301 In the rest of the code, change types of integers that hold casted
2302 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2303 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2304 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2305 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2306 No need to cast type when ORing.
2307 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2308 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2309 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2310 assume EMACS_INT is the same width as char *.
2311 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2312 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2313 Remove no-longer-needed casts.
2314 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2315 (xg_tool_bar_help_callback, xg_make_tool_item):
2316 Use EMACS_INTPTR to hold an integer
2317 that will be cast to void *; this can avoid a GCC warning
2318 if EMACS_INT is not the same width as void *.
2319 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2320 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2321 (current_message_1, set_message_1):
2322 Use a local to convert to proper width without a cast.
2323 * xmenu.c (dialog_selection_callback): Likewise.
2324
2325 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2326 Also, don't assume VALBITS / RAND_BITS is less than 5,
2327 and don't rely on undefined behavior when shifting a 1 left into
2328 the sign bit.
2329 * lisp.h (get_random): Change signature to match.
2330
2331 * lread.c (hash_string): Use size_t, not int, for hash computation.
2332 Normally we prefer signed values; but hashing is special, because
2333 it's better to use unsigned division on hash table sizes so that
2334 the remainder is nonnegative. Also, size_t is the natural width
2335 for hashing into memory. The previous code used 'int', which doesn't
2336 retain enough info to hash well into very large tables.
2337 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2338
2339 * dbusbind.c: Don't possibly lose pointer info when converting.
2340 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2341 Use XPNTR rather than XHASH, so that the high-order bits of
2342 the pointer aren't lost when converting through void *.
2343
2344 * eval.c (Fautoload): Don't double-shift a pointer.
2345
2346 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2347
2348 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2349
2350 * gnutls.c (DEF_GNUTLS_FN):
2351 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2352
2353 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2354
2355 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2356 marker. (Bug#8610)
2357
2358 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2359
2360 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2361 New version that can reserve upto 2GB of heap space.
2362
2363 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2364
2365 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2366
2367 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2368
2369 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2370 `gnutls_certificate_set_x509_key_file'.
2371
2372 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2373
2374 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2375 Update dependencies.
2376
2377 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2378
2379 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2380 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2381 Remove unused parameter `fildes'.
2382 * process.c (read_process_output, send_process): Don't pass it.
2383
2384 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2385
2386 Fix previous change: the library cache is defined in w32.c.
2387 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2388 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2389
2390 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2391
2392 Implement dynamic loading of GnuTLS on Windows.
2393
2394 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2395 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2396 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2397 Declare.
2398
2399 * gnutls.c (Qgnutls_dll): Define.
2400 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2401 (gnutls_*): Declare function pointers.
2402 (init_gnutls_functions): New function to initialize function pointers.
2403 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2404 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2405 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2406 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2407 (emacs_gnutls_write, emacs_gnutls_read)
2408 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2409 (Fgnutls_available_p): New function.
2410 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2411 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2412 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2413
2414 * image.c: Include w32.h.
2415 (Vimage_type_cache): Delete.
2416 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2417 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2418 (w32_delayed_load): Move to w32.c.
2419
2420 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2421
2422 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2423 (w32_delayed_load): Move from image.c. When loading a library, record
2424 its filename in the :loaded-from property of the library id.
2425 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2426 Initialize and staticpro them.
2427 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2428
2429 * process.c: Include lisp.h before w32.h, not after.
2430 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2431 instead of gnutls_record_check_pending.
2432
2433 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2434
2435 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2436
2437 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2438 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2439 as passed in.
2440
2441 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2442
2443 * xterm.c (x_set_frame_alpha): Do not set property on anything
2444 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2445
2446 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2447
2448 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2449
2450 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2451
2452 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2453 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2454 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2455 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2456 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2457 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2458 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2459 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2460 (Qgnutls_bootprop_callbacks_verify): Make static.
2461
2462 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2463
2464 * callproc.c: Indentation fixup.
2465
2466 * sysdep.c (wait_for_termination_1): Make static.
2467 (wait_for_termination, interruptible_wait_for_termination):
2468 Move after wait_for_termination_1.
2469
2470 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2471
2472 * sysdep.c (interruptible_wait_for_termination): New function
2473 which is like wait_for_termination, but allows keyboard
2474 interruptions.
2475
2476 * callproc.c (Fcall_process): Add (:file "file") as an option for
2477 the STDOUT buffer.
2478 (Fcall_process_region): Ditto.
2479
2480 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2481
2482 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2483 rather than `XVECTOR (FOO)->size'.
2484
2485 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2486 inttypes.h, as a gnulib replacement is used if it not available in
2487 system headers.
2488
2489 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2490
2491 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2492 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2493 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2494
2495 * coding.c (coding_alloc_by_realloc): Error out if destination
2496 will grow beyond MOST_POSITIVE_FIXNUM.
2497 (decode_coding_emacs_mule): Abort if there isn't enough place in
2498 charbuf for the composition carryover bytes. Reserve an extra
2499 space for up to 2 characters produced in a loop.
2500 (decode_coding_iso_2022): Abort if there isn't enough place in
2501 charbuf for the composition carryover bytes.
2502
2503 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2504
2505 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2506 aborting when %lld or %lll format is passed.
2507 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2508 %llo or %llx format is passed. (Bug#8545)
2509
2510 * window.c (window_scroll_line_based): Use a marker instead of
2511 simple variables to record original value of point. (Bug#7952)
2512
2513 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2514 produced by %s or %c overflows available buffer space. (Bug#8545)
2515
2516 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2517
2518 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2519 (SIZE_MAX): Move defn after all includes, as they might #define it.
2520
2521 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2522
2523 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2524
2525 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2526
2527 * keyboard.c (Qdelayed_warnings_hook): Define.
2528 (command_loop_1): Run `delayed-warnings-hook'
2529 if Vdelayed_warnings_list is non-nil.
2530 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2531 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2532
2533 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2534
2535 * doprnt.c (doprnt): Don't return value smaller than the buffer
2536 size if the message was truncated. (Bug#8545).
2537
2538 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2539
2540 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2541 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2542
2543 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2544
2545 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2546
2547 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2548
2549 * makefile.w32-in: Update dependencies.
2550
2551 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2552
2553 Improve `doprnt' and its usage. (Bug#8545)
2554 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2555 `format_end'. Remove support for %l as a conversion specifier.
2556 Don't use xrealloc. Improve diagnostics when the %l size modifier
2557 is used. Update the commentary.
2558
2559 * eval.c (verror): Simplify calculation of size_t.
2560
2561 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2562 messages.
2563
2564 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2565
2566 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2567 change.
2568
2569 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2570
2571 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2572 This makes this file independent of the recent pseudovector change.
2573
2574 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2575
2576 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2577
2578 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2579 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2580 Remove unused local.
2581 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2582
2583 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2584 GCC 4.6.0 optimizes based on type-based alias analysis.
2585 For example, if b is of type struct buffer * and v of type struct
2586 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2587 != &v->size, and therefore "v->size = 1; b->size = 2; return
2588 v->size;" must therefore return 1. This assumption is incorrect
2589 for Emacs, since it type-puns struct Lisp_Vector * with many other
2590 types. To fix this problem, this patch adds a new type struct
2591 vectorlike_header that documents the constraints on layout of vectors
2592 and pseudovectors, and helps optimizing compilers not get fooled
2593 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2594 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2595 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2596 the size member.
2597 (XSETPVECTYPE): Rewrite in terms of new macro.
2598 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2599 This is a bit clearer, and further avoids the possibility of
2600 undesirable aliasing.
2601 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2602 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2603 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2604 since Lisp_Subr is a special case (no "next" field).
2605 (ASIZE): Now uses header.size rather than size.
2606 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2607 to avoid the hassle of writing XVECTOR (foo)->header.size.
2608 (struct vectorlike_header): New type.
2609 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2610 object, to help avoid aliasing.
2611 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2612 (SUBRP): Likewise, since Lisp_Subr is a special case.
2613 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2614 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2615 (struct Lisp_Hash_Table): Combine first two members into a single
2616 struct vectorlike_header member. All uses of "size" and "next" members
2617 changed to be "header.size" and "header.next".
2618 * buffer.h (struct buffer): Likewise.
2619 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2620 * frame.h (struct frame): Likewise.
2621 * process.h (struct Lisp_Process): Likewise.
2622 * termhooks.h (struct terminal): Likewise.
2623 * window.c (struct save_window_data, struct saved_window): Likewise.
2624 * window.h (struct window): Likewise.
2625 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2626 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2627 * buffer.c (init_buffer_once): Likewise.
2628 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2629 special case.
2630 * process.c (Fformat_network_address): Use local var for size,
2631 for brevity.
2632
2633 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2634
2635 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2636 * data.c (atof): Remove decl; no longer used or needed.
2637 (digit_to_number): Move to lread.c.
2638 (Fstring_to_number): Use new string_to_number function, to be
2639 consistent with how the Lisp reader treats infinities and NaNs.
2640 Do not assume that floating-point numbers represent EMACS_INT
2641 without losing information; this is not true on most 64-bit hosts.
2642 Avoid double-rounding errors, by insisting on integers when
2643 parsing non-base-10 numbers, as the documentation specifies.
2644 * lisp.h (string_to_number): New decl, replacing ...
2645 (isfloat_string): Remove.
2646 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2647 (read1): Do not accept +. and -. as integers; this
2648 appears to have been a coding error. Similarly, do not accept
2649 strings like +-1e0 as floating point numbers. Do not report
2650 overflow for integer overflows unless the base is not 10 which
2651 means we have no simple and reliable way to continue.
2652 Break out the floating-point parsing into a new
2653 function string_to_number, so that Fstring_to_number parses
2654 floating point numbers consistently with the Lisp reader.
2655 (digit_to_number): Move here from data.c. Make it static inline.
2656 (E_CHAR, EXP_INT): Remove, replacing with ...
2657 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2658 (string_to_number): New function, replacing isfloat_string.
2659 This function checks for valid syntax and produces the resulting
2660 Lisp float number too. Rework it so that string-to-number
2661 no longer mishandles examples like "1.0e+". Use strtoumax,
2662 so that overflow for non-base-10 numbers is reported only when
2663 there's no portable and simple way to convert to floating point.
2664
2665 * textprop.c (set_text_properties_1): Rewrite for clarity,
2666 and to avoid GCC warning about integer overflow.
2667
2668 * intervals.h (struct interval): Use EMACS_INT for members
2669 where EMACS_UINT might cause problems. See
2670 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2671 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2672 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2673 All uses changed.
2674 (offset_intervals): Tell GCC not to worry about length overflow
2675 when negating a negative length.
2676
2677 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2678 (overrun_check_free): Likewise.
2679
2680 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2681 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2682 word size.
2683
2684 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2685 (gnutls_make_error): Rename local to avoid shadowing.
2686 (gnutls_emacs_global_deinit): ifdef out; not used.
2687 (Fgnutls_boot): Use const for pointer to readonly storage.
2688 Comment out unused local. Fix pointer signedness problems.
2689
2690 * lread.c (openp): Don't stuff size_t into an 'int'.
2691 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2692 about possible signed overflow.
2693
2694 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2695 (GDK_KEY_g): Don't define if already defined.
2696 (xg_prepare_tooltip): Avoid pointer signedness problem.
2697 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2698
2699 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2700 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2701
2702 * xfns.c (Fx_window_property): Simplify a bit,
2703 to make a bit faster and to avoid GCC 4.6.0 warning.
2704 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2705
2706 * fns.c (internal_equal): Don't assume size_t fits in int.
2707
2708 * alloc.c (compact_small_strings): Tighten assertion a little.
2709
2710 Replace pEd with more-general pI, and fix some printf arg casts.
2711 * lisp.h (pI): New macro, generalizing old pEd macro to other
2712 conversion specifiers. For example, use "...%"pI"d..." rather
2713 than "...%"pEd"...".
2714 (pEd): Remove. All uses replaced with similar uses of pI.
2715 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2716 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2717 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2718 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2719 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2720 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2721 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2722 64-bit hosts.
2723 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2724 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2725 * print.c (safe_debug_print, print_object): Likewise.
2726 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2727 to int.
2728 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2729 avoiding the 0 flag, which is not portable.
2730 * process.c (Fmake_network_process): Use pI to avoid cast.
2731 * region-cache.c (pp_cache): Likewise.
2732 * xdisp.c (decode_mode_spec): Likewise.
2733 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2734 behavior on 64-bit hosts with printf arg.
2735 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2736 (x_stop_queuing_selection_requests): Likewise.
2737 (x_get_window_property): Don't truncate byte count to an 'int'
2738 when tracing.
2739
2740 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2741 here, since it parses constructs like leading '-' and spaces,
2742 which are not wanted; and it overflows with large numbers.
2743 Instead, simply match F[0-9]+, which is what is wanted anyway.
2744
2745 * alloc.c: Remove unportable assumptions about struct layout.
2746 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2747 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2748 (allocate_vectorlike, make_pure_vector): Use the new macros,
2749 plus offsetof, to remove unportable assumptions about struct layout.
2750 These assumptions hold on all porting targets that I know of, but
2751 they are not guaranteed, they're easy to remove, and removing them
2752 makes further changes easier.
2753
2754 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2755 This doesn't fix a bug but makes the code clearer.
2756 (string_overrun_cookie): Now const. Use initializers that
2757 don't formally overflow signed char, to avoid warnings.
2758 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2759 can cause Emacs to crash when string overrun checking is enabled.
2760 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2761 multiple of sizeof (EMACS_INT); it need not be, if
2762 alignof(EMACS_INT) < sizeof (EMACS_INT).
2763 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2764
2765 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2766
2767 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2768
2769 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2770
2771 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2772 supposed to be handshaking. (Bug#8556)
2773 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2774
2775 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2776
2777 * lisp.h (Qdebug): List symbol.
2778 * eval.c (Qdebug): Restore global linkage.
2779 * keyboard.c (debug-on-event): New variable.
2780 (handle_user_signal): Break into debugger when debug-on-event
2781 matches the current signal symbol.
2782
2783 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2784
2785 * alloc.c (check_sblock, check_string_bytes)
2786 (check_string_free_list): Convert to standard C.
2787
2788 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2789
2790 * w32.c (emacs_gnutls_push): Fix typo.
2791
2792 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2793
2794 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2795 "cast to pointer from integer of different size".
2796
2797 Improve doprnt and its use in verror. (Bug#8545)
2798 * doprnt.c (doprnt): Document the set of format control sequences
2799 supported by the function. Use SAFE_ALLOCA instead of always
2800 using `alloca'.
2801
2802 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2803 is one byte too soon. Don't use xrealloc; instead xfree and
2804 xmalloc anew.
2805
2806 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2807
2808 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2809 callbacks stage.
2810
2811 * gnutls.c: Renamed global_initialized to
2812 gnutls_global_initialized. Added internals for the
2813 :verify-hostname-error, :verify-error, and :verify-flags
2814 parameters of `gnutls-boot' and documented those parameters in the
2815 docstring. Start callback support.
2816 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2817 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2818 on error. Return error code.
2819 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2820 (emacs_gnutls_read): Likewise.
2821 (Fgnutls_boot): Return handshake error code.
2822 (emacs_gnutls_handle_error): New function.
2823 (wsaerror_to_errno): Likewise.
2824
2825 * w32.h (emacs_gnutls_pull): Add prototype.
2826 (emacs_gnutls_push): Likewise.
2827
2828 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2829 (emacs_gnutls_push): Likewise.
2830
2831 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2832
2833 * process.c (wait_reading_process_output): Check if GnuTLS
2834 buffered some data internally if no FDs are set for TLS
2835 connections.
2836
2837 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2838 (LIBS): Link to USER_LIBS.
2839 ($(BLD)/gnutls.$(0)): New target.
2840
2841 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2842
2843 * xdisp.c (handle_single_display_spec): Rename the
2844 display_replaced_before_p argument into display_replaced_p, to
2845 make it consistent with the commentary. Fix typos in the
2846 commentary.
2847
2848 * textprop.c (syms_of_textprop): Remove dead code.
2849 (copy_text_properties): Delete obsolete commentary about an
2850 interface that was deleted long ago. Fix typos in the description
2851 of arguments.
2852
2853 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2854 to changes in oldXMenu/XMenu.h from 2011-04-16.
2855 <menu_help_message, prev_menu_help_message>: Constify.
2856 (IT_menu_make_room): menu->help_text is now `const char **';
2857 adjust.
2858
2859 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2860 to changes in oldXMenu/XMenu.h from 2011-04-16.
2861 (struct XMenu): Declare `help_text' `const char **'.
2862
2863 * xfaces.c <Qunspecified>: Make extern again.
2864
2865 * syntax.c: Include sys/types.h before including regex.h, as
2866 required by Posix.
2867
2868 * doc.c (get_doc_string): Improve the format passed to `error'.
2869
2870 * doprnt.c (doprnt): Improve commentary.
2871
2872 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2873
2874 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2875 them with etags.
2876
2877 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2878 changes in globals.h immediately force recompilation.
2879 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2880 $(CURDIR)/s/ms-w32.h.
2881 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2882
2883 * character.c (Fchar_direction): Function deleted.
2884 (syms_of_character): Don't defsubr it.
2885 <char-direction-table>: Deleted.
2886
2887 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2888
2889 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2890 * doprnt.c: Include limits.h.
2891 (SIZE_MAX): New macro.
2892 (doprnt): Return a size_t value. 2nd arg is now size_t.
2893 Many local variables are now size_t instead of int or unsigned.
2894 Improve overflow protection. Support `l' modifier for integer
2895 conversions. Support %l conversion. Don't assume an EMACS_INT
2896 argument for integer conversions and for %c.
2897
2898 * lisp.h (doprnt): Restore prototype.
2899
2900 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2901 $(SRC)/character.h.
2902
2903 * Makefile.in (base_obj): Add back doprnt.o.
2904
2905 * deps.mk (doprnt.o): Add back prerequisites.
2906 (callint.o): Depend on character.h.
2907
2908 * eval.c (internal_lisp_condition_case): Include the handler
2909 representation in the error message.
2910 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2911 when breaking from the loop.
2912
2913 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2914
2915 * callint.c (Fcall_interactively): When displaying error message
2916 about invalid control letter, pass the character's codepoint, not
2917 a pointer to its multibyte form. Improve display of the character
2918 in octal and display also its hex code.
2919
2920 * character.c (char_string): Use %x to display the (unsigned)
2921 codepoint of an invalid character, to avoid displaying a bogus
2922 negative value.
2923
2924 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2925 `error', not SYMBOL_NAME itself.
2926
2927 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2928 character arguments to `error'.
2929
2930 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2931 to `error' in error message about FINAL_CHAR argument. Make sure
2932 FINAL_CHAR is a character, and use %c when it is passed as
2933 argument to `error'.
2934
2935 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2936
2937 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2938
2939 * w32.c: Include <time.h>.
2940 (sys_localtime): New function.
2941
2942 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2943
2944 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2945
2946 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2947
2948 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2949
2950 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2951 zombies (Bug#8467).
2952
2953 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2954
2955 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2956 gl_state.e_property when gl_state.object is Qt.
2957
2958 * insdel.c (make_gap_larger): Remove limitation of buffer size
2959 to <= INT_MAX.
2960
2961 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2962
2963 * xdisp.c (lookup_glyphless_char_display)
2964 (produce_glyphless_glyph): Handle cons cell entry in
2965 glyphless-char-display.
2966 (Vglyphless_char_display): Document it.
2967
2968 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2969 glyphless-char-display.
2970
2971 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2972
2973 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2974
2975 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2976
2977 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2978 definition for no-X builds.
2979
2980 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2981
2982 Static checks with GCC 4.6.0 and non-default toolkits.
2983
2984 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2985
2986 * process.c (keyboard_bit_set): Define only if SIGIO.
2987 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2988 (send_process): Repair possible setjmp clobbering.
2989
2990 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2991
2992 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2993
2994 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2995
2996 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2997 Define only if needed.
2998
2999 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3000 by pacifying GCC about it. Maybe it's time to retire it?
3001 * xfaces.c (USG, __TIMEVAL__): Likewise.
3002
3003 * dispextern.h (struct redisplay_interface): Rename param
3004 to avoid shadowing.
3005 * termhooks.h (struct terminal): Likewise.
3006 * xterm.c (xembed_send_message): Likewise.
3007
3008 * insdel.c (make_gap_smaller): Define only if
3009 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3010
3011 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3012 it.
3013
3014 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3015 so that we aren't warned about unused symbols.
3016
3017 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3018
3019 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3020
3021 * xfns.c (x_real_positions): Mark locals as initialized.
3022
3023 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3024
3025 * xterm.c: Fix problems found by static analysis with other toolkits.
3026 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3027 (x_dispatch_event): Declare static if USE_GTK, and
3028 define if USE_GTK || USE_X_TOOLKIT.
3029 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3030 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3031 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3032 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3033
3034 * xmenu.c (menu_help_callback): Pointer type fixes.
3035 Use const pointers when pointing at readonly data. Avoid pointer
3036 signedness clashes.
3037 (FALSE): Remove unused macro.
3038 (update_frame_menubar): Remove unused decl.
3039
3040 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3041
3042 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3043 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3044 (single_menu_item): Rename local to avoid shadowing.
3045
3046 * keyboard.c (make_lispy_event): Remove unused local var.
3047
3048 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3049 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3050
3051 * bitmaps: Change bitmaps from unsigned char back to the X11
3052 compatible char. Avoid the old compiler warnings about
3053 out-of-range initializers by using, for example, '\xab' rather
3054 than 0xab.
3055
3056 * xgselect.c (xgselect_initialize): Check vs interface
3057 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3058
3059 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3060
3061 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3062 to read-only memory.
3063
3064 * fns.c (vector): Remove; this old hack is no longer needed.
3065
3066 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3067 Remove unused var.
3068 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3069
3070 * xrdb.c (x_load_resources): Omit unused local.
3071
3072 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3073 (x_window): Rename locals to avoid shadowing.
3074 (USG): Use the kludged USG macro, to pacify gcc.
3075
3076 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3077 (x_term_init): Remove local to avoid shadowing.
3078
3079 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3080
3081 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3082 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3083
3084 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3085
3086 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3087
3088 Fix regex.c, syntax.c and friends for buffers > 2GB.
3089 * syntax.h (struct gl_state_s): Declare character position members
3090 EMACS_INT.
3091
3092 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3093
3094 * textprop.c (verify_interval_modification, interval_of):
3095 Declare arguments EMACS_INT.
3096
3097 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3098 EMACS_INT.
3099
3100 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3101
3102 * indent.c (Fvertical_motion): Local variable it_start is now
3103 EMACS_INT.
3104
3105 * regex.c (re_match, re_match_2, re_match_2_internal)
3106 (bcmp_translate, regcomp, regexec, print_double_string)
3107 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3108 (re_compile_pattern, re_exec): Declare arguments and local
3109 variables `size_t' and `ssize_t' and return values `regoff_t', as
3110 appropriate.
3111 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3112 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3113 <compile_stack_type>: `size' and `avail' are now `size_t'.
3114
3115 * regex.h <regoff_t>: Use ssize_t, not int.
3116 (re_search, re_search_2, re_match, re_match_2): Arguments that
3117 specify buffer/string position and length are now ssize_t and
3118 size_t. Return type is regoff_t.
3119
3120 2011-04-16 Ben Key <bkey76@gmail.com>
3121
3122 * nsfont.m: Fixed bugs in ns_get_family and
3123 ns_descriptor_to_entity that were caused by using free to
3124 deallocate memory blocks that were allocated by xmalloc (via
3125 xstrdup). This caused Emacs to crash when compiled with
3126 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3127 --enable-checking=xmallocoverrun). xfree is now used to
3128 deallocate these memory blocks.
3129
3130 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3131
3132 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3133
3134 emacs_write: Accept and return EMACS_INT for sizes.
3135 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3136 et seq.
3137 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3138 Accept and return EMACS_INT.
3139 (emacs_gnutls_write): Return the number of bytes written on
3140 partial writes.
3141 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3142 (emacs_read, emacs_write): Remove check for negative size, as the
3143 Emacs source code has been audited now.
3144 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3145 (emacs_read, emacs_write): Use it.
3146 * process.c (send_process): Adjust to the new signatures of
3147 emacs_write and emacs_gnutls_write. Do not attempt to store
3148 a byte offset into an 'int'; it might overflow.
3149 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3150
3151 * sound.c: Don't assume sizes fit in 'int'.
3152 (struct sound_device.period_size, alsa_period_size):
3153 Return EMACS_INT, not int.
3154 (struct sound_device.write, vox_write, alsa_write):
3155 Accept EMACS_INT, not int.
3156 (wav_play, au_play): Use EMACS_INT to store sizes and to
3157 record read return values.
3158
3159 2011-04-15 Ben Key <bkey76@gmail.com>
3160
3161 * keyboard.c (Qundefined): Don't declare static since it is used
3162 in nsfns.m.
3163 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3164 static since they are used in nsfont.m.
3165
3166 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3167
3168 * process.c (Qprocessp): Don't declare static.
3169 * lisp.h (Qprocessp): Declare again.
3170
3171 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3172
3173 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3174
3175 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3176
3177 Improve C-level modularity by making more things 'static'.
3178
3179 Don't publish debugger-only interfaces to other modules.
3180 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3181 (verify_bytepos, count_markers): Move decls to the only modules
3182 that need them.
3183 * region-cache.h (pp_cache): Likewise.
3184 * window.h (check_all_windows): Likewise.
3185 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3186
3187 * sysdep.c (croak): Now static, if
3188 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3189 * syssignal.h (croak): Declare only if not static.
3190
3191 * alloc.c (refill_memory_reserve): Now static if
3192 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3193 * lisp.h (refill_memory_reserve): Declare only if not static.
3194
3195 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3196 Define only if USE_LUCID.
3197
3198 * xrdb.c (x_customization_string, x_rm_string): Now static.
3199
3200 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3201 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3202
3203 * xdisp.c (draw_row_with_mouse_face): Now static.
3204 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3205
3206 * window.h (check_all_windows): Mark externally visible.
3207
3208 * window.c (window_deletion_count): Now static.
3209
3210 * undo.c: Make symbols static if they're not exported.
3211 (last_undo_buffer, last_boundary_position, pending_boundary):
3212 Now static.
3213
3214 * textprop.c (interval_insert_behind_hooks): Now static.
3215 (interval_insert_in_front_hooks): Likewise.
3216
3217 * term.c: Make symbols static if they're not exported.
3218 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3219 (max_frame_lines, tty_set_terminal_modes):
3220 (tty_reset_terminal_modes, tty_turn_off_highlight):
3221 (get_tty_terminal): Now static.
3222 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3223 * termhooks.h (term_mouse_moveto): Do not declare if
3224 HAVE_WINDOW_SYSTEM.
3225 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3226 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3227
3228 * sysdep.c: Make symbols static if they're not exported.
3229 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3230 Now static.
3231 (sigprocmask_set, full_mask): Remove; unused.
3232 (wait_debugging): Mark as visible.
3233 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3234 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3235
3236 * syntax.c (syntax_temp): Define only if !__GNUC__.
3237
3238 * sound.c (current_sound_device, current_sound): Now static.
3239
3240 * search.c (searchbufs, searchbuf_head): Now static.
3241
3242 * scroll.c (scroll_cost): Remove; unused.
3243 * dispextern.h (scroll_cost): Remove decl.
3244
3245 * region-cache.h (pp_cache): Mark as externally visible.
3246
3247 * process.c: Make symbols static if they're not exported.
3248 (process_tick, update_tick, create_process, chan_process):
3249 (Vprocess_alist, proc_buffered_char, datagram_access):
3250 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3251 (deactivate_process): Mark defn as static, as well as decl.
3252 * lisp.h (create_process): Remove decl.
3253 * process.h (chan_process, Vprocess_alist): Remove decls.
3254
3255 * print.c: Make symbols static if they're not exported.
3256 (print_depth, new_backquote_output, being_printed, print_buffer):
3257 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3258 (print_interval, print_number_index, initial_stderr_stream):
3259 Now static.
3260 * lisp.h (Fprinc): Remove decl.
3261 (debug_output_compilation_hack): Mark as externally visible.
3262
3263 * sysdep.c (croak): Move decl from here to syssignal.h.
3264 * syssignal.h (croak): Put it here, so the API can be checked when
3265 'croak' is called from dissociate_if_controlling_tty.
3266
3267 * minibuf.c: Make symbols static if they're not exported.
3268 (minibuf_save_list, choose_minibuf_frame): Now static.
3269 * lisp.h (choose_minibuf_frame): Remove decl.
3270
3271 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3272
3273 * lread.c: Make symbols static if they're not exported.
3274 (read_objects, initial_obarray, oblookup_last_bucket_number):
3275 Now static.
3276 (make_symbol): Remove; unused.
3277 * lisp.h (initial_obarray, make_symbol): Remove decls.
3278
3279 * keyboard.c: Make symbols static if they're not exported.
3280 (single_kboard, recent_keys_index, total_keys, recent_keys):
3281 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3282 (this_single_command_key_start, echoing, last_auto_save):
3283 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3284 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3285 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3286 (Vlispy_mouse_stem, double_click_count):
3287 Now static.
3288 (force_auto_save_soon): Define only if SIGDANGER.
3289 (ignore_mouse_drag_p): Now static if
3290 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3291 (print_help): Remove; unused.
3292 (stop_character, last_timer_event): Mark as externally visible.
3293 * keyboard.h (ignore_mouse_drag_p): Declare only if
3294 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3295 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3296 * lisp.h (echoing): Remove decl.
3297 (force_auto_save_soon): Declare only if SIGDANGER.
3298 * xdisp.c (redisplay_window): Simplify code, to make it more
3299 obvious that ignore_mouse_drag_p is not accessed if !defined
3300 USE_GTK && !defined HAVE_NS.
3301
3302 * intervals.c: Make symbols static if they're not exported.
3303 (merge_properties_sticky, merge_interval_right, delete_interval):
3304 Now static.
3305 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3306
3307 * insdel.c: Make symbols static if they're not exported.
3308 However, leave prepare_to_modify_buffer alone. It's never
3309 called from outside this function, but that appears to be a bug.
3310 (combine_after_change_list, combine_after_change_buffer):
3311 (adjust_after_replace, signal_before_change): Now static.
3312 (adjust_after_replace_noundo): Remove; unused.
3313 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3314 (signal_before_change): Remove decls.
3315
3316 * indent.c (val_compute_motion, val_vmotion): Now static.
3317
3318 * image.c: Make symbols static if they're not exported.
3319 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3320 if USE_GTK.
3321 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3322 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3323
3324 * fringe.c (standard_bitmaps): Now static.
3325 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3326
3327 * frame.c: Make symbols static if they're not exported.
3328 (x_report_frame_params, make_terminal_frame): Now static.
3329 (get_frame_param): Now static, unless HAVE_NS.
3330 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3331 (x_get_resource_string): Remove; not used.
3332 * frame.h (make_terminal_frame, x_report_frame_params):
3333 (x_get_resource_string); Remove decls.
3334 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3335 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3336
3337 * font.c, fontset.c: Make symbols static if they're not exported.
3338 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3339 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3340 * font.c (font_close_object): Now static.
3341 * font.h (font_close_object): Remove.
3342 * fontset.c (FONTSET_OBJLIST): Remove.
3343 (free_realized_fontset) #if-0 the body, which does nothing.
3344 (face_suitable_for_char_p): #if-0, as it's never called.
3345 * fontset.h (face_suitable_for_char_p): Remove decl.
3346 * xfaces.c (face_at_string_position):
3347 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3348 since 0 is always ASCII.
3349
3350 * fns.c (weak_hash_tables): Now static.
3351
3352 * fileio.c: Make symbols static if they're not exported.
3353 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3354 (Vwrite_region_annotation_buffers): Now static.
3355
3356 * eval.c: Make symbols static if they're not exported.
3357 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3358 * lisp.h (backtrace_list): Remove decl.
3359
3360 * emacs.c: Make symbols static if they're not exported.
3361 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3362 (fatal_error_code, fatal_error_signal_hook, standard_args):
3363 Now static.
3364 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3365 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3366 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3367 * lisp.h (fatal_error_signal_hook): Remove decl.
3368 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3369
3370 * editfns.c: Move a (normally-unused) function to its only use.
3371 * editfns.c, lisp.h (get_operating_system_release): Remove.
3372 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3373 worth the hassle of breaking this out.
3374
3375 * xterm.c: Make symbols static if they're not exported.
3376 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3377 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3378 (x_destroy_window, x_delete_display):
3379 Now static.
3380 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3381 (x_mouse_leave): Remove; unused.
3382 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3383 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3384 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3385 Remove decls.
3386 (x_mouse_leave): Declare only if WINDOWSNT.
3387 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3388 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3389 USE_X_TOOLKIT.
3390
3391 * ftxfont.c: Make symbols static if they're not exported.
3392 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3393 HAVE_FREETYPE.
3394 * font.h (ftxfont_driver): Likewise.
3395
3396 * xfns.c: Make symbols static if they're not exported.
3397 (x_last_font_name, x_display_info_for_name):
3398 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3399 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3400 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3401 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3402 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3403 (last_show_tip_args): Now static.
3404 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3405 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3406 (x_screen_planes): Remove; unused.
3407 * dispextern.h (x_screen_planes): Remove decl.
3408
3409 * dispnew.c: Make symbols static if they're not exported.
3410 * dispextern.h (redraw_garbaged_frames, scrolling):
3411 (increment_row_positions): Remove.
3412 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3413 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3414 Now static.
3415 (redraw_garbaged_frames): Remove; unused.
3416
3417 * xfaces.c: Make symbols static if they're not exported.
3418 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3419 Remove decls.
3420 * xterm.h (defined_color): Remove decls.
3421 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3422 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3423 (menu_face_changed_default, defined_color, free_realized_face):
3424 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3425 (ascii_face_of_lisp_face): Remove; unused.
3426
3427 * xdisp.c: Make symbols static if they're not exported.
3428 * dispextern.h (scratch_glyph_row, window_box_edges):
3429 (glyph_to_pixel_coords, set_cursor_from_row):
3430 (get_next_display_element, set_iterator_to_next):
3431 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3432 (show_mouse_face): Remove decls
3433 * frame.h (message_buf_print): Likewise.
3434 * lisp.h (pop_message, set_message, check_point_in_composition):
3435 Likewise.
3436 * xterm.h (set_vertical_scroll_bar): Likewise.
3437 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3438 (message_buf_print, scratch_glyph_row, displayed_buffer):
3439 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3440 (get_next_display_element, show_mouse_face, window_box_edges):
3441 (frame_to_window_pixel_xy, check_point_in_composition):
3442 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3443 (glyph_to_pixel_coords): Remove; unused.
3444
3445 * dired.c (file_name_completion): Now static.
3446
3447 * dbusbind.c (xd_in_read_queued_messages): Now static.
3448
3449 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3450 * data.c (circular_list_error): Remove.
3451
3452 * commands.h (last_point_position, last_point_position_buffer):
3453 (last_point_position_window): Remove decls.
3454 * keyboard.c: Make these variables static.
3455
3456 * coding.h (coding, code_convert_region, encode_coding_gap):
3457 Remove decls.
3458 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3459 (iso_code_class, detect_coding, code_convert_region): Now static.
3460 (encode_coding_gap): Remove; unused.
3461
3462 * chartab.c (chartab_chars, chartab_bits): Now static.
3463
3464 * charset.h (charset_iso_8859_1): Remove decl.
3465 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3466 Now static.
3467
3468 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3469 * ccl.c (Vccl_program_table): Now static.
3470 (check_ccl_update): Remove; unused.
3471
3472 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3473 * category.h: ... from here.
3474 * category.c (check_category_table, set_category_set): Now static.
3475
3476 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3477 * lisp.h: Remove these decls.
3478
3479 * buffer.c (buffer_count): Remove unused var.
3480
3481 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3482 so that it's not optimized away.
3483 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3484 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3485 exported only to the debugger.
3486
3487 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3488 * atimer.h (run_all_atimers): Remove; not exported.
3489
3490 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3491 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3492 was inaccessible from Lisp.
3493 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3494 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3495
3496 alloc.c: Import and export fewer symbols, and remove unused items.
3497 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3498 is defined.
3499 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3500 it's not optimized away by whole-program optimization.
3501 (message_enable_multibyte, free_misc): Remove.
3502 (catchlist, handlerlist, mark_backtrace):
3503 Declare only if BYTE_MARK_STACK.
3504 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3505 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3506 (message_enable_multibyte): Remove decl.
3507 (free_misc, interval_free_list, float_block, float_block_index):
3508 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3509 (cons_free_list, last_marked_index):
3510 Now static.
3511 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3512 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3513 (mark_backtrace): Define only if BYTE_MARK_STACK.
3514 * xdisp.c (message_enable_multibyte): Now static.
3515
3516 Declare Lisp_Object Q* variables to be 'static' if not exported.
3517 This makes it easier for human readers (and static analyzers)
3518 to see whether these variables are used from other modules.
3519 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3520 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3521 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3522 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3523 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3524 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3525 * xmenu.c, xselect.c:
3526 Declare Q* vars static if they are not used in other modules.
3527 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3528 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3529 Remove decls of unexported vars.
3530 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3531
3532 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3533
3534 Make Emacs functions such as Fatom 'static' by default.
3535 This makes it easier for human readers (and static analyzers)
3536 to see whether these functions can be called from other modules.
3537 DEFUN now defines a static function. To make the function external
3538 so that it can be used in other C modules, use the new macro DEFUE.
3539 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3540 (Finit_image_library):
3541 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3542 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3543 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3544 Remove decls, since these functions are now static.
3545 (Funintern, Fget_internal_run_time): New decls, since these functions
3546 were already external.
3547
3548 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3549 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3550 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3551 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3552 * keyboard.c, keymap.c, lread.c:
3553 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3554 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3555 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3556 Mark functions with DEFUE instead of DEFUN,
3557 if they are used in other modules.
3558 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3559 decls for now-static functions.
3560 * buffer.h (Fdelete_overlay): Remove decl.
3561 * callproc.c (Fgetenv_internal): Mark as internal.
3562 * composite.c (Fremove_list_of_text_properties): Remove decl.
3563 (Fcomposition_get_gstring): New forward static decl.
3564 * composite.h (Fcomposite_get_gstring): Remove decl.
3565 * dired.c (Ffile_attributes): New forward static decl.
3566 * doc.c (Fdocumntation_property): New forward static decl.
3567 * eval.c (Ffetch_bytecode): New forward static decl.
3568 (Funintern): Remove extern decl; now in .h file where it belongs.
3569 * fileio.c (Fmake_symbolic_link): New forward static decl.
3570 * image.c (Finit_image_library): New forward static decl.
3571 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3572 * intervals.h (Fprevious_property_change):
3573 (Fremove_list_of_text_properties): Remove decls.
3574 * keyboard.c (Fthis_command_keys): Remove decl.
3575 (Fcommand_execute): New forward static decl.
3576 * keymap.c (Flookup_key): New forward static decl.
3577 (Fcopy_keymap): Now static.
3578 * keymap.h (Flookup_key): Remove decl.
3579 * process.c (Fget_process): New forward static decl.
3580 (Fprocess_datagram_address): Mark as internal.
3581 * syntax.c (Fsyntax_table_p): New forward static decl.
3582 (skip_chars): Remove duplicate decl.
3583 * textprop.c (Fprevious_property_change): New forward static decl.
3584 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3585 Now internal.
3586 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3587 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3588
3589 * editfns.c (Fformat): Remove unreachable code.
3590
3591 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3592
3593 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3594 change. (Bug#8496)
3595
3596 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3597
3598 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3599 when at ZV. (Bug#8487)
3600
3601 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3602
3603 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3604 (Bug#8437)
3605 * keyboard.c (parse_tool_bar_item): Likewise.
3606 * sound.c (sound_cleanup, alsa_close): Likewise.
3607 * termcap.c (tgetent): Likewise.
3608 * xfns.c (x_default_font_parameter): Likewise.
3609 * xsettings.c (read_and_apply_settings): Likewise.
3610
3611 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3612 (overrun_check_free): Protoize.
3613
3614 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3615
3616 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3617 since callers should never pass a negative size.
3618 Change the signature to match that of plain 'read' and 'write'; see
3619 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3620 * lisp.h: Update prototypes of emacs_write and emacs_read.
3621
3622 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3623
3624 * xdisp.c (redisplay_window): Don't try to determine the character
3625 position of the scroll margin if the window start point w->startp
3626 is outside the buffer's accessible region. (Bug#8468)
3627
3628 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3629
3630 Fix write-region and its subroutines for buffers > 2GB.
3631 * fileio.c (a_write, e_write): Modify declaration of arguments and
3632 local variables to support buffers larger than 2GB.
3633 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3634
3635 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3636 argument, local variables, and return value.
3637
3638 * lisp.h: Update prototypes of emacs_write and emacs_read.
3639
3640 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3641
3642 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3643
3644 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3645
3646 Fix more problems found by GCC 4.6.0's static checks.
3647
3648 * xdisp.c (vmessage): Use a better test for character truncation.
3649
3650 * charset.c (load_charset_map): <, not <=, for optimization,
3651 and to avoid potential problems with integer overflow.
3652 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3653 * casetab.c (set_identity, shuffle): Likewise.
3654 * editfns.c (Fformat): Likewise.
3655 * syntax.c (skip_chars): Likewise.
3656
3657 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3658 This also lets GCC 4.6.0 generate slightly better loop code.
3659
3660 * callint.c (Fcall_interactively): <, not <=, for optimization.
3661 (Fcall_interactively): Count the number of arguments produced,
3662 not the number of arguments given. This is simpler and lets GCC
3663 4.6.0 generate slightly better code.
3664
3665 * ftfont.c: Distingish more carefully between FcChar8 and char.
3666 The previous code passed unsigned char * to a functions like
3667 strlen and xstrcasecmp that expect char *, which does not
3668 conform to the C standard.
3669 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3670 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3671 char * when the C standard requires it.
3672
3673 * keyboard.c (read_char): Remove unused var.
3674
3675 * eval.c: Port to Windows vsnprintf (Bug#8435).
3676 Include <limits.h>.
3677 (SIZE_MAX): Define if the headers do not.
3678 (verror): Do not give up if vsnprintf returns a negative count.
3679 Instead, grow the buffer. This ports to Windows vsnprintf, which
3680 does not conform to C99. Problem reported by Eli Zaretskii.
3681 Also, simplify the allocation scheme, by avoiding the need for
3682 calling realloc, and removing the ALLOCATED variable.
3683
3684 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3685
3686 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3687 But keep the doprint source code for now, as we might revamp it
3688 and use it again (Bug#8435).
3689 * lisp.h (doprnt): Remove.
3690 * Makefile.in (base_obj): Remove doprnt.o.
3691 * deps.mk (doprnt.o): Remove.
3692
3693 error: Print 32- and 64-bit integers portably (Bug#8435).
3694 Without this change, on typical 64-bit hosts error ("...%d...", N)
3695 was used to print both 32- and 64-bit integers N, which relied on
3696 undefined behavior.
3697 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3698 New macro.
3699 * lisp.h (error, verror): Mark as printf-like functions.
3700 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3701 Report overflow in size calculations when allocating printf buffer.
3702 Do not truncate output string at its first null byte.
3703 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3704 Truncate the output at a character boundary, since vsnprintf does not
3705 do that.
3706 * charset.c (check_iso_charset_parameter): Convert internal
3707 character to string before calling 'error', since %c now has the
3708 printf meaning.
3709 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3710 overflow when computing char to be passed to 'error'. Do not
3711 pass Lisp_Object to 'error'; pass the integer instead.
3712 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3713 formatted with plain %d.
3714
3715 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3716
3717 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3718
3719 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3720
3721 * xterm.c (x_catch_errors): Remove duplicate declaration.
3722
3723 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3724
3725 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3726
3727 2011-04-10 Jim Meyering <meyering@redhat.com>
3728
3729 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3730 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3731 return ssize_t not "int", and use size_t as the buffer length.
3732 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3733 * gnutls.h: Update declarations.
3734 * process.c (read_process_output): Use ssize_t, to match.
3735 (send_process): Likewise.
3736
3737 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3738
3739 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3740
3741 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3742
3743 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3744 Use unsigned char, to match FcChar8 type definition.
3745
3746 * xterm.c (handle_one_xevent):
3747 * xmenu.c (create_and_show_popup_menu):
3748 * xselect.c (x_decline_selection_request)
3749 (x_reply_selection_request): Avoid type-punned deref of X events.
3750
3751 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3752
3753 Fix some uses of `int' instead of EMACS_INT.
3754 * search.c (string_match_1, fast_string_match)
3755 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3756 (scan_buffer, find_next_newline_no_quit)
3757 (find_before_next_newline, search_command, Freplace_match)
3758 (Fmatch_data): Make some `int' variables be EMACS_INT.
3759
3760 * xdisp.c (display_count_lines): 3rd argument and return value now
3761 EMACS_INT. All callers changed.
3762 (pint2hrstr): Last argument is now EMACS_INT.
3763
3764 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3765 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3766 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3767 (decode_coding_utf_16, decode_coding_emacs_mule)
3768 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3769 (decode_coding_ccl, decode_coding_charset)
3770 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3771 (decode_coding_iso_2022, decode_coding_emacs_mule)
3772 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3773 <char_offset, last_offset>: Declare EMACS_INT.
3774 (encode_coding_utf_8, encode_coding_utf_16)
3775 (encode_coding_emacs_mule, encode_invocation_designation)
3776 (encode_designation_at_bol, encode_coding_iso_2022)
3777 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3778 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3779 Declare EMACS_INT.
3780 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3781 (encode_invocation_designation): Last argument P_NCHARS is now
3782 EMACS_INT.
3783 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3784 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3785
3786 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3787 All users changed.
3788
3789 * ccl.c (Fccl_execute_on_string): Declare some variables
3790 EMACS_INT.
3791
3792 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3793
3794 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3795
3796 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3797
3798 * process.c (Fformat_network_address): Doc fix.
3799
3800 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3801
3802 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3803
3804 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3805
3806 * keyboard.c (read_char): Call Lisp function help-form-show,
3807 instead of using internal_with_output_to_temp_buffer.
3808 (Qhelp_form_show): New var.
3809 (syms_of_keyboard): Use DEFSYM macro.
3810
3811 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3812
3813 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3814
3815 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3816
3817 * process.c (Flist_processes): Remove to Lisp.
3818 (list_processes_1): Delete.
3819
3820 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3821
3822 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3823
3824 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3825
3826 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3827
3828 Fix more problems found by GCC 4.6.0's static checks.
3829
3830 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3831
3832 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3833
3834 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3835
3836 * xdisp.c (vmessage): Mark as a printf-like function.
3837
3838 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3839
3840 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3841
3842 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3843 printf-like functions.
3844 (tiff_load): Add casts to remove these marks before passing them
3845 to system-supplied API.
3846
3847 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3848
3849 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3850 This avoids several warnings with gcc -Wstrict-overflow.
3851 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3852 directly, rather than having caller test rule sign. This avoids
3853 some unnecessary tests.
3854 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3855 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3856 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3857
3858 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3859 (xfont_open): Avoid unnecessary tests.
3860
3861 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3862
3863 * composite.h, composite.c (composition_gstring_put_cache):
3864 Use EMACS_INT, not int, for length.
3865
3866 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3867 breaking out part of COMPOSITION_DECODE_RULE.
3868 (COMPOSITION_DECODE_RULE): Use it.
3869 * composite.c (get_composition_id): Remove unused local vars,
3870 by using the new macro.
3871
3872 * textprop.c (set_text_properties_1): Change while to do-while,
3873 since the condition is always true at first.
3874
3875 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3876 (interval_deletion_adjustment): Return unsigned value.
3877 All uses changed.
3878
3879 * process.c (list_processes_1, create_pty, read_process_output):
3880 (exec_sentinel): Remove vars that were set but not used.
3881 (create_pty): Remove unnecessary "volatile"s.
3882 (Fnetwork_interface_info): Avoid possibility of int overflow.
3883 (read_process_output): Do adaptive read buffering even if carryover.
3884 (read_process_output): Simplify nbytes computation if buffered.
3885
3886 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3887
3888 * syntax.c (scan_words): Remove var that was set but not used.
3889 (update_syntax_table): Use unsigned instead of int.
3890
3891 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3892 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3893 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3894
3895 * print.c (print_error_message): Avoid int overflow.
3896
3897 * font.c (font_list_entities): Redo for clarity,
3898 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3899
3900 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3901 (font_score): Avoid potential overflow in diff calculation.
3902
3903 * fns.c (substring_both): Remove var that is set but not used.
3904 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3905
3906 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3907
3908 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3909 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3910 can always succeed if overflow has undefined behavior.
3911
3912 * search.c (boyer_moore, wordify): Remove vars set but not used.
3913 (wordify): Omit three unnecessary tests.
3914
3915 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3916 All callers changed. This avoids the need for an unused var.
3917
3918 * casefiddle.c (casify_region): Remove var that is set but not used.
3919
3920 * dired.c (file_name_completion): Remove var that is set but not used.
3921
3922 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3923
3924 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3925 (Finsert_file_contents): Remove unnecessary code checking fd.
3926
3927 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3928 Check for integer overflow on size calculations.
3929
3930 * buffer.c (Fprevious_overlay_change): Remove var that is set
3931 but not used.
3932
3933 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3934 Remove vars that are set but not used.
3935 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3936 (timer_check_2): Mark vars as initialized.
3937
3938 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3939
3940 * image.c (lookup_image): Remove var that is set but not used.
3941 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3942
3943 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3944 that are set but not used.
3945
3946 * xfns.c (make_invisible_cursor): Don't return garbage
3947 if XCreateBitmapFromData fails (Bug#8410).
3948
3949 * xselect.c (x_get_local_selection, x_handle_property_notify):
3950 Remove vars that are set but not used.
3951
3952 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3953 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3954
3955 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3956 Remove var that is set but not used.
3957 (scroll_bar_windows_size): Now size_t, not int.
3958 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3959 Check for overflow.
3960
3961 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3962 (map_tty_color) [!defined MSDOS]: Likewise.
3963
3964 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3965
3966 * coding.c: Remove vars that are set but not used.
3967 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3968 All callers changed.
3969 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3970 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3971 (decode_coding_charset): Remove vars that are set but not used.
3972
3973 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3974 that is set but not used.
3975
3976 * print.c (print_object): Remove var that is set but not used.
3977
3978 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3979 The gnulib version avoids calling malloc in the usual case,
3980 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3981 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3982 * filelock.c (current_lock_owner): Likewise.
3983 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3984 * sysdep.c: Include allocator.h, careadlinkat.h.
3985 (emacs_no_realloc_allocator): New static constant.
3986 (emacs_readlink): New function.
3987 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3988 ../lib/careadlinkat.h.
3989
3990 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3991
3992 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3993 first non-nil return value).
3994
3995 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3996
3997 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3998 if not defined (Bug#8403).
3999
4000 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4001
4002 * xdisp.c (display_count_lines): Remove parameter `start',
4003 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4004 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4005 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4006 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4007 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4008 and thereabouts. All callers changed.
4009 (get_per_char_metric): Remove parameter `f', unused since
4010 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4011
4012 2011-04-02 Jim Meyering <meyering@redhat.com>
4013
4014 do not dereference NULL upon failed strdup
4015 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4016 (ns_get_family): Likewise.
4017
4018 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4019
4020 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4021
4022 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4023
4024 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4025 later (Bug#8403).
4026
4027 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4028
4029 Add lexical binding.
4030
4031 * window.c (Ftemp_output_buffer_show): New fun.
4032 (Fsave_window_excursion):
4033 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4034
4035 * lread.c (lisp_file_lexically_bound_p): New function.
4036 (Fload): Bind Qlexical_binding.
4037 (readevalloop): Remove `evalfun' arg.
4038 Bind Qinternal_interpreter_environment.
4039 (Feval_buffer): Bind Qlexical_binding.
4040 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4041 Mark as dynamic.
4042 (syms_of_lread): Declare `lexical-binding'.
4043
4044 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4045
4046 * keyboard.c (eval_dyn): New fun.
4047 (menu_item_eval_property): Use it.
4048
4049 * image.c (parse_image_spec): Use Ffunctionp.
4050
4051 * fns.c (concat, mapcar1): Accept byte-code-functions.
4052
4053 * eval.c (Fsetq): Handle lexical vars.
4054 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4055 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4056 (FletX, Flet): Obey lexical binding.
4057 (Fcommandp): Handle closures.
4058 (Feval): New `lexical' arg.
4059 (eval_sub): New function extracted from Feval. Use it almost
4060 everywhere where Feval was used. Look up vars in lexical env.
4061 Handle closures.
4062 (Ffunctionp): Move from subr.el.
4063 (Ffuncall): Handle closures.
4064 (apply_lambda): Remove `eval_flags'.
4065 (funcall_lambda): Handle closures and new byte-code-functions.
4066 (Fspecial_variable_p): New function.
4067 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4068 but without exporting it to Lisp.
4069
4070 * doc.c (Fdocumentation, store_function_docstring):
4071 * data.c (Finteractive_form): Handle closures.
4072
4073 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4074 interactive spec.
4075
4076 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4077 New byte-codes.
4078 (exec_byte_code): New function extracted from Fbyte_code to handle new
4079 calling convention for byte-code-functions. Add new byte-codes.
4080
4081 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4082
4083 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4084
4085 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4086
4087 * xdisp.c (redisplay_internal): Fix prototype.
4088
4089 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4090
4091 * xdisp.c (SCROLL_LIMIT): New macro.
4092 (try_scrolling): Use it when setting scroll_limit.
4093 Limit scrolling to 100 screen lines.
4094 (redisplay_window): Even when falling back on "recentering",
4095 position point in the window according to scroll-conservatively,
4096 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4097
4098 (try_scrolling): When point is above the window, allow searching
4099 as far as scroll_max, or one screenful, to compute vertical
4100 distance from PT to the scroll margin position. This prevents
4101 try_scrolling from unnecessarily failing when
4102 scroll-conservatively is set to a value slightly larger than the
4103 window height. Clean up the case of PT below the margin at bottom
4104 of window: scroll_max can no longer be INT_MAX. When aggressive
4105 scrolling is in use, don't let point enter the opposite scroll
4106 margin as result of the scroll.
4107 (syms_of_xdisp) <scroll-conservatively>: Document the
4108 threshold of 100 lines for never-recentering scrolling.
4109
4110 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4111
4112 * dispextern.h (move_it_by_lines):
4113 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4114 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4115 (message_log_check_duplicate): Remove parameters `prev_bol' and
4116 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4117 (redisplay_internal): Remove parameter `preserve_echo_area',
4118 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4119
4120 * indent.c (Fvertical_motion):
4121 * window.c (window_scroll_pixel_based, Frecenter):
4122 Don't pass `need_y_p' to `move_it_by_lines'.
4123
4124 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4125
4126 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4127 steal a few bits to be more compact.
4128 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4129 Remove unneeded casts.
4130
4131 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4132
4133 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4134
4135 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4136 binding" message (bug#7967).
4137
4138 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4139
4140 Fix more problems found by GCC 4.6.0's static checks.
4141
4142 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4143 Remove unused local var.
4144
4145 * editfns.c (Fmessage_box): Remove unused local var.
4146
4147 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4148 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4149 Omit unused local vars.
4150 * window.c (shrink_windows): Omit unused local var.
4151 * menu.c (digest_single_submenu): Omit unused local var.
4152 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4153 Omit unused local var.
4154
4155 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4156 Don't assume string length fits in int.
4157 (keyremap_step, read_key_sequence): Use size_t for sizes.
4158 (read_key_sequence): Don't check last_real_key_start redundantly.
4159
4160 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4161 instead of alloca (Bug#8344).
4162
4163 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4164 (Fbacktrace_frame): Don't assume nframes fits in int.
4165
4166 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4167
4168 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4169 concerns.
4170
4171 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4172
4173 * cm.c (calccost): Turn while-do into do-while, for clarity.
4174
4175 * keyboard.c (syms_of_keyboard): Use the same style as later
4176 in this function when indexing through an array. This also
4177 works around GCC bug 48267.
4178
4179 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4180
4181 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4182
4183 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4184 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4185
4186 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4187 This avoids undefined behavior on integer overflow, and is a bit
4188 more convenient anyway since it is compared to a size_t variable.
4189
4190 Variadic C functions now count arguments with size_t, not int.
4191 This avoids an unnecessary limitation on 64-bit machines, which
4192 caused (substring ...) to crash on large vectors (Bug#8344).
4193 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4194 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4195 All variadic functions and their callers changed accordingly.
4196 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4197 * data.c (arith_driver, float_arith_driver): Likewise.
4198 * editfns.c (general_insert_function): Likewise.
4199 * eval.c (struct backtrace.nargs, interactive_p)
4200 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4201 (funcall_lambda, mark_backtrace): Likewise.
4202 * fns.c (concat): Likewise.
4203 * frame.c (x_set_frame_parameters): Likewise.
4204 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4205 0 if not found, not -1. All callers changed.
4206
4207 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4208 (stack_copy_size): Now size_t, not int.
4209 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4210
4211 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4212
4213 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4214 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4215 All callers changed.
4216
4217 * lisp.h (multibyte_char_to_unibyte):
4218 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4219 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4220 * character.h (CHAR_TO_BYTE8):
4221 * cmds.c (internal_self_insert):
4222 * editfns.c (general_insert_function):
4223 * keymap.c (push_key_description):
4224 * search.c (Freplace_match):
4225 * xdisp.c (message_dolog, set_message_1): All callers changed.
4226
4227 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4228
4229 * keyboard.c (safe_run_hook_funcall): New function.
4230 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4231 don't set the hook to nil, but remove the offending function instead.
4232 (Qcommand_hook_internal): Remove, unused.
4233 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4234 Vcommand_hook_internal.
4235
4236 * eval.c (enum run_hooks_condition): Remove.
4237 (funcall_nil, funcall_not): New functions.
4238 (run_hook_with_args): Call each function through a `funcall' argument.
4239 Remove `cond' argument, now redundant.
4240 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4241 (Frun_hook_with_args_until_failure): Adjust accordingly.
4242 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4243
4244 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4245
4246 * dispextern.h (string_buffer_position): Remove declaration.
4247
4248 * print.c (strout): Remove parameter `multibyte', unused since
4249 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4250
4251 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4252 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4253 All callers changed.
4254
4255 * w32.c (_wsa_errlist): Use braces for struct initializers.
4256
4257 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4258 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4259 All callers changed.
4260 (string_buffer_position): Likewise. Also, make static (it's never
4261 used outside xdisp.c).
4262 (cursor_row_p): Remove parameter `w', unused since
4263 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4264 (decode_mode_spec): Remove parameter `precision', introduced during
4265 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4266 All callers changed.
4267
4268 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4269
4270 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4271
4272 2011-03-27 Anders Lindgren <andlind@gmail.com>
4273
4274 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4275 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4276 (ns_update_auto_hide_menu_bar): New functions.
4277 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4278 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4279 ns_constrain_all_frames.
4280 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4281 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4282
4283 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4284
4285 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4286
4287 2011-03-27 Glenn Morris <rgm@gnu.org>
4288
4289 * syssignal.h: Replace RETSIGTYPE with void.
4290 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4291 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4292 Replace SIGTYPE with void everywhere.
4293 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4294 * s/template.h (SIGTYPE): Remove commented out definition.
4295
4296 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4297
4298 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4299 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4300
4301 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4302
4303 * w32.c (read_unc_volume): Use parameter `henum', instead of
4304 global variable `wget_enum_handle'.
4305
4306 * keymap.c (describe_vector): Remove parameters `indices' and
4307 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4308 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4309
4310 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4311
4312 * keyboard.c (timer_check): Remove parameter `do_it_now',
4313 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4314 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4315 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4316
4317 * keyboard.c (read_char):
4318 * w32menu.c (w32_menu_display_help):
4319 * xmenu.c (show_help_event, menu_help_callback):
4320 Adjust calls to `show_help_echo'.
4321
4322 * gtkutil.c (xg_maybe_add_timer):
4323 * keyboard.c (readable_events):
4324 * process.c (wait_reading_process_output):
4325 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4326
4327 * insdel.c (adjust_markers_gap_motion):
4328 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4329 (gap_left, gap_right): Don't call it.
4330
4331 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4332
4333 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4334 incurred during fontification.
4335
4336 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4337
4338 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4339 (DEFVAR_PER_BUFFER): Don't pass it.
4340
4341 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4342 (scrolling_window): Don't pass it.
4343
4344 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4345
4346 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4347
4348 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4349 and `suffix'.
4350 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4351 of variables specific to SELinux and computation of `encoded_absname'.
4352
4353 * image.c (XPutPixel): Remove unused variable `height'.
4354
4355 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4356
4357 * unexw32.c (get_section_info): Remove unused variable `section'.
4358
4359 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4360 (system_process_attributes): Remove unused variable `sess'.
4361 (sys_read): Remove unused variable `err'.
4362
4363 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4364 (w32_wnd_proc): Remove unused variable `isdead'.
4365 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4366 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4367 (x_create_tip_frame): Remove unused variable `tem'.
4368
4369 * w32inevt.c (w32_console_read_socket):
4370 Remove unused variable `no_events'.
4371
4372 * w32term.c (x_draw_composite_glyph_string_foreground):
4373 Remove unused variable `width'.
4374
4375 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4376
4377 * w32term.c (x_set_glyph_string_clipping):
4378 Don't pass uninitialized region to CombineRgn.
4379
4380 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4381
4382 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4383 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4384 (Fx_close_connection): Remove unused variable `i'.
4385
4386 * w32font.c (w32font_draw): Return number of glyphs.
4387 (w32font_open_internal): Remove unused variable `i'.
4388 (w32font_driver): Add missing initializer.
4389
4390 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4391 (fill_in_menu): Remove unused variable `items_added'.
4392
4393 * w32term.c (last_mouse_press_frame): Remove static global variable.
4394 (w32_clip_to_row): Remove unused variable `f'.
4395 (x_delete_terminal): Remove unused variable `i'.
4396
4397 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4398 (NOTHING): Remove unused static global variable.
4399 (uniscribe_check_otf): Remove unused variable `table'.
4400 (uniscribe_font_driver): Add missing initializers.
4401
4402 2011-03-23 Julien Danjou <julien@danjou.info>
4403
4404 * term.c (Fsuspend_tty, Fresume_tty):
4405 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4406 * window.c (temp_output_buffer_show):
4407 * insdel.c (signal_before_change):
4408 * frame.c (Fhandle_switch_frame):
4409 * fileio.c (Fdo_auto_save):
4410 * emacs.c (Fkill_emacs):
4411 * editfns.c (save_excursion_restore):
4412 * cmds.c (internal_self_insert):
4413 * callint.c (Fcall_interactively):
4414 * buffer.c (Fkill_all_local_variables):
4415 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4416 Use Frun_hooks.
4417 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4418 unconditionnaly since it does the check itself.
4419
4420 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4421
4422 Fix more problems found by GCC 4.5.2's static checks.
4423
4424 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4425 the first time through the loop, since we know p0 < p1 then.
4426 This also avoids a gcc -Wstrict-overflow warning.
4427
4428 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4429 leading to a memory leak, possible in functions like
4430 load_charset_map_from_file that can allocate an unbounded number
4431 of objects (Bug#8318).
4432
4433 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4434 that could (at least in theory) be that large.
4435
4436 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4437 This is less likely to overflow, and avoids undefined behavior if
4438 overflow does occur. All callers changed. Use strtoul to scan
4439 for the unsigned long integer.
4440 (pint2hrstr): Simplify and tune code slightly.
4441 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4442
4443 * scroll.c (do_scrolling): Work around GCC bug 48228.
4444 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4445
4446 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4447 This also avoids a warning with gcc -Wstrict-overflow.
4448 (validate_x_resource_name): Simplify count usage.
4449 This also avoids a warning with gcc -Wstrict-overflow.
4450
4451 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4452 fail (Bug#8306).
4453
4454 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4455
4456 * process.c (Fmake_network_process): Use socklen_t, not int,
4457 where POSIX says socklen_t is required in portable programs.
4458 This fixes a porting bug on hosts like 64-bit HP-UX, where
4459 socklen_t is wider than int (Bug#8277).
4460 (Fmake_network_process, server_accept_connection):
4461 (wait_reading_process_output, read_process_output):
4462 Likewise.
4463
4464 * process.c: Rename or move locals to avoid shadowing.
4465 (list_processes_1, Fmake_network_process):
4466 (read_process_output_error_handler, exec_sentinel_error_handler):
4467 Rename or move locals.
4468 (Fmake_network_process): Define label "retry_connect" only if needed.
4469 (Fnetwork_interface_info): Fix pointer signedness.
4470 (process_send_signal): Add cast to avoid pointer signedness problem.
4471 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4472 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4473
4474 Make tparam.h and terminfo.c consistent.
4475 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4476 Include tparam.h instead, since it declares them.
4477 * cm.h (PC): Remove extern decl; tparam.h now does this.
4478 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4479 * terminfo.c: Include tparam.h, to check interfaces.
4480 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4481 (tparam): Adjust signature to match interface in tparam.h;
4482 this removes some undefined behavior. Check that outstring and len
4483 are zero, which they always are with Emacs.
4484 * tparam.h (PC, BC, UP): New extern decls.
4485
4486 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4487 (xftfont_open): Rename locals to avoid shadowing.
4488
4489 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4490 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4491 (OTF_TAG_SYM): Omit macro if not needed.
4492 (ftfont_list): Remove unused local.
4493 (get_adstyle_property, ftfont_pattern_entity):
4494 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4495 Rename locals to avoid shadowing.
4496
4497 * xfont.c (xfont_list_family): Mark var as initialized.
4498
4499 * xml.c (make_dom): Now static.
4500
4501 * composite.c (composition_compute_stop_pos): Rename local to
4502 avoid shadowing.
4503 (composition_reseat_it): Remove unused locals.
4504 (find_automatic_composition, composition_adjust_point): Likewise.
4505 (composition_update_it): Mark var as initialized.
4506 (find_automatic_composition): Mark vars as initialized,
4507 with a FIXME (Bug#8290).
4508
4509 character.h: Rename locals to avoid shadowing.
4510 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4511 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4512 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4513 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4514 to avoid shadowing.
4515
4516 * textprop.c (property_change_between_p): Remove; unused.
4517
4518 * intervals.c (interval_start_pos): Now static.
4519
4520 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4521
4522 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4523 Rename locals to avoid shadowing.
4524
4525 * sound.c (wav_play, au_play, Fplay_sound_internal):
4526 Fix pointer signedness.
4527 (alsa_choose_format): Remove unused local var.
4528 (wav_play): Initialize a variable to 0, to prevent undefined
4529 behavior (Bug#8278).
4530
4531 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4532
4533 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4534
4535 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4536 clobbering (Bug#8298).
4537 * sysdep.c (sys_subshell): Likewise.
4538 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4539
4540 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4541 This should get cleaned up, so that child_setup has the
4542 same signature on all platforms.
4543
4544 * callproc.c (call_process_cleanup): Now static.
4545 (relocate_fd): Rename locals to avoid shadowing.
4546
4547 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4548
4549 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4550 not to be necessary, and produces flickering.
4551
4552 2011-03-20 Glenn Morris <rgm@gnu.org>
4553
4554 * config.in: Remove file.
4555
4556 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4557
4558 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4559 are now in src/globals.h.
4560 (syms_of_minibuf): Remove spurious & from previous change.
4561
4562 2011-03-20 Leo <sdl.web@gmail.com>
4563
4564 * minibuf.c (completing-read-function): New variable.
4565 (completing-read-default): Rename from completing-read.
4566 (completing-read): Call completing-read-function.
4567
4568 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4569
4570 * xfaces.c (Fx_load_color_file):
4571 Read color file from absolute filename (bug#8250).
4572
4573 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4574
4575 * makefile.w32-in: Update dependencies.
4576
4577 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4578
4579 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4580
4581 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4582
4583 Fix more problems found by GCC 4.5.2's static checks.
4584
4585 * process.c (make_serial_process_unwind, send_process_trap):
4586 (sigchld_handler): Now static.
4587
4588 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4589 That way, the code declares only the vars that it needs.
4590 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4591 * s/cygwin.h (PTY_ITERATION): Likewise.
4592 * s/darwin.h (PTY_ITERATION): Likewise.
4593 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4594
4595 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4596 * process.c (allocate_pty): Don't declare stb unless it's needed.
4597
4598 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4599 (CONSTANTLIM): Remove; unused.
4600 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4601 Define only if needed.
4602
4603 * unexelf.c (unexec): Name an expression,
4604 to avoid gcc -Wbad-function-cast warning.
4605 Use a different way to cause a compilation error if anyone uses
4606 n rather than nn, a way that does not involve shadowing.
4607 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4608
4609 * deps.mk (unexalpha.o): Remove; unused.
4610
4611 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4612 * unexec.h: New file.
4613 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4614 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4615 Depend on unexec.h.
4616 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4617 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4618 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4619 Change as necessary to match prototype in unexec.h.
4620
4621 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4622 shadowing.
4623 (back_comment, skip_chars): Mark vars as initialized.
4624
4625 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4626 Rename locals to avoid shadowing.
4627
4628 * lread.c (read1): Rewrite so as not to use empty "else".
4629 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4630
4631 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4632
4633 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4634 warning when compiling print.c.
4635
4636 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4637 instead of using an uninitialized var.
4638 (font_sort_entities): Mark var as initialized.
4639
4640 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4641
4642 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4643 pointers to constants.
4644 (font_parse_fcname): Remove unused vars.
4645 (font_delete_unmatched): Now static.
4646 (font_get_spec): Remove; unused.
4647 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4648 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4649 Rename or move locals to avoid shadowing.
4650
4651 * fns.c (require_nesting_list, require_unwind): Now static.
4652 (Ffillarray): Rename locals to avoid shadowing.
4653
4654 * floatfns.c (domain_error2): Define only if needed.
4655 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4656
4657 * alloc.c (mark_backtrace): Move decl from here ...
4658 * lisp.h: ... to here, so that it can be checked.
4659
4660 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4661 (Fdefvar): Rewrite so as not to use empty "else".
4662 (lisp_indirect_variable): Name an expression,
4663 to avoid gcc -Wbad-function-cast warning.
4664 (Fdefvar): Rename locals to avoid shadowing.
4665
4666 * callint.c (quotify_arg, quotify_args): Now static.
4667 (Fcall_interactively): Rename locals to avoid shadowing.
4668 Use const pointer when appropriate.
4669
4670 * lisp.h (get_system_name, get_operating_system_release):
4671 Move decls here, to check interfaces.
4672 * process.c (get_operating_system_release): Move decl to lisp.h.
4673 * xrdb.c (get_system_name): Likewise.
4674 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4675 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4676 some of which prompt warnings from gcc -Wbad-function-cast.
4677 (Fformat_time_string, Fencode_time, Finsert_char):
4678 (Ftranslate_region_internal, Fformat):
4679 Rename or remove local vars to avoid shadowing.
4680 (Ftranslate_region_internal): Mark var as initialized.
4681
4682 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4683 avoid shadowing.
4684
4685 * lisp.h (eassert): Check that the argument compiles, even if
4686 ENABLE_CHECKING is not defined.
4687
4688 * data.c (Findirect_variable): Name an expression, to avoid
4689 gcc -Wbad-function-cast warning.
4690 (default_value, arithcompare, arith_driver, arith_error): Now static.
4691 (store_symval_forwarding): Rename local to avoid shadowing.
4692 (Fmake_variable_buffer_local, Fmake_local_variable):
4693 Mark variables as initialized.
4694 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4695
4696 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4697 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4698 Rename locals to avoid shadowing.
4699 (mark_stack): Move local variables into the #ifdef region where
4700 they're used.
4701 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4702 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4703 needed otherwise.
4704 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4705 (GC_STRING_CHARS): Remove; not used.
4706 (Fmemory_limit): Cast sbrk's returned value to char *.
4707
4708 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4709 avoids undefined behavior in theory.
4710
4711 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4712
4713 Use functions, not macros, for up- and down-casing (Bug#8254).
4714 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4715 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4716 to use the following functions instead of these macros.
4717 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4718 EMACS_INT, since callers assume the returned value fits in int.
4719 (upcase1): Likewise, for UPCASE_TABLE.
4720 (uppercasep, lowercasep, upcase): New static inline functions.
4721 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4722 the race-condition problem in the old DOWNCASE.
4723
4724 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4725 Rename locals to avoid shadowing.
4726 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4727 (regex_compile, re_search_2, re_match_2_internal):
4728 Remove unused local vars.
4729 (FREE_VAR): Rewrite so as not to use empty "else",
4730 which gcc can warn about.
4731 (regex_compile, re_match_2_internal): Mark locals as initialized.
4732 (RETALLOC_IF): Define only if needed.
4733 (WORDCHAR_P): Likewise. This one is never needed, but is used
4734 only in a comment talking about a compiler bug, so put inside
4735 the #if 0 of that comment.
4736 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4737 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4738 Remove; unused.
4739
4740 * search.c (boyer_moore): Rename locals to avoid shadowing.
4741 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4742 (PREV_CHAR_BOUNDARY): Likewise.
4743
4744 * search.c (simple_search): Remove unused var.
4745
4746 * dired.c (compile_pattern): Move decl from here ...
4747 * lisp.h: ... to here, so that it can be checked.
4748 (struct re_registers): New forward decl.
4749
4750 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4751
4752 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4753 All uses changed.
4754 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4755 Rename locals to avoid shadowing.
4756 (Fvertical_motion): Mark locals as initialized.
4757
4758 * casefiddle.c (casify_object, casify_region): Now static.
4759 (casify_region): Mark local as initialized.
4760
4761 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4762
4763 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4764 New macros, so that the caller can use some names other than
4765 gcpro1, gcpro2, etc.
4766 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4767 of the new macros.
4768 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4769 argument, for consistency with GCPRO2_VAR, etc: it is now the
4770 prefix of the variable, not the variable itself. All uses
4771 changed.
4772 * dired.c (directory_files_internal, file_name_completion):
4773 Rename locals to avoid shadowing.
4774
4775 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4776 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4777 dired.c's scmp function, had undefined behavior.
4778 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4779 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4780 * buffer.h: ... to here, because these macros use current_buffer,
4781 and the new implementation with inline functions needs to have
4782 current_buffer in scope now, rather than later when the macros
4783 are used.
4784 (downcase, upcase1): New static inline functions.
4785 (DOWNCASE, UPCASE1): Reimplement using these functions.
4786 This avoids undefined behavior in expressions like
4787 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4788 from race conditions in accessing the global variables
4789 case_temp1 and case_temp2.
4790 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4791 * lisp.h (case_temp1, case_temp2): Remove their decls.
4792 * character.h (ASCII_CHAR_P): Move from here ...
4793 * lisp.h: ... to here, so that the inline functions mentioned
4794 above can use them.
4795
4796 * dired.c (directory_files_internal_unwind): Now static.
4797
4798 * fileio.c (file_name_as_directory, directory_file_name):
4799 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4800 Now static.
4801 (file_name_as_directory): Use const pointers when appropriate.
4802 (Fexpand_file_name): Likewise. In particular, newdir might
4803 point at constant storage, so make it a const pointer.
4804 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4805 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4806 signedness issues.
4807 (Fset_file_times, Finsert_file_contents, auto_save_error):
4808 Rename locals to avoid shadowing.
4809
4810 * minibuf.c (choose_minibuf_frame_1): Now static.
4811 (Ftry_completion, Fall_completions): Rename or remove locals
4812 to avoid shadowing.
4813
4814 * marker.c (bytepos_to_charpos): Remove; unused.
4815
4816 * lisp.h (verify_bytepos, count_markers): New decls,
4817 so that gcc does not warn that these functions aren't declared.
4818
4819 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4820 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4821 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4822 (copy_text): Remove unused local var.
4823
4824 * filelock.c (within_one_second): Now static.
4825 (lock_file_1): Rename local to avoid shadowing.
4826
4827 * buffer.c (fix_overlays_before): Mark locals as initialized.
4828 (fix_start_end_in_overlays): Likewise. This function should be
4829 simplified by using pointers-to-pointers, but that's a different
4830 matter.
4831 (switch_to_buffer_1): Now static.
4832 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4833 (report_overlay_modification): Rename locals to avoid shadowing.
4834
4835 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4836 Fix pointer signedness issue.
4837 (sys_subshell): Mark local as volatile if checking for lint,
4838 to suppress a gcc -Wclobbered warning that does not seem to be right.
4839 (MAXPATHLEN): Define only if needed.
4840
4841 * process.c (serial_open, serial_configure): Move decls from here ...
4842 * systty.h: ... to here, so that they can be checked.
4843
4844 * fns.c (get_random, seed_random): Move extern decls from here ...
4845 * lisp.h: ... to here, so that they can be checked.
4846
4847 * sysdep.c (reset_io): Now static.
4848 (wait_for_termination_signal): Remove; unused.
4849
4850 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4851 (copy_keymap_item, append_key, push_text_char_description):
4852 Now static.
4853 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4854 (DENSE_TABLE_SIZE): Remove; unused.
4855 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4856 (describe_map_tree):
4857 Rename locals to avoid shadowing.
4858
4859 * keyboard.c: Declare functions static if they are not used elsewhere.
4860 (echo_char, echo_dash, cmd_error, top_level_2):
4861 (poll_for_input, handle_async_input): Now static.
4862 (read_char, kbd_buffer_get_event, make_lispy_position):
4863 (make_lispy_event, make_lispy_movement, apply_modifiers):
4864 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4865 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4866 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4867 (read_key_sequence, read_char): Mark locals as initialized.
4868 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4869
4870 * keyboard.h (make_ctrl_char): New decl.
4871 (mark_kboards): Move decl here ...
4872 * alloc.c (mark_kboards): ... from here.
4873
4874 * lisp.h (force_auto_save_soon): New decl.
4875
4876 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4877 (DEFINE_DUMMY_FUNCTION): New macro.
4878 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4879 Use it.
4880 (main): Add casts to avoid warnings
4881 if GCC considers string literals to be constants.
4882
4883 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4884
4885 * dbusbind.c: Pointer signedness fixes.
4886 (xd_signature, xd_append_arg, xd_initialize):
4887 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4888 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4889 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4890 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4891
4892 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4893 if GCC considers string literals to be constants.
4894 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4895
4896 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4897
4898 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4899 (print_preprocess, print_object): New macro to fix last change.
4900
4901 * print.c (print_preprocess): Don't forget font objects.
4902
4903 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4904
4905 * emacs.c (USAGE3): Doc fixes.
4906
4907 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4908
4909 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4910 structure.
4911
4912 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4913
4914 * lisp.h (VWindow_system, Qfile_name_history):
4915 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4916 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4917 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4918
4919 * w32select.c: Don't #include "keyboard.h".
4920 (run_protected): Add extern declaration for waiting_for_input.
4921
4922 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4923 * w32console.c (detect_input_pending, read_input_pending)
4924 (encode_terminal_code):
4925 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4926 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4927 (w32_system_caret_y, Qfile_name_history):
4928 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4929 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4930 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4931 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4932 * w32proc.c (Qlocal, report_file_error):
4933 * w32term.c (Vwindow_system, updating_frame):
4934 * w32uniscribe.c (initialized, uniscribe_font_driver):
4935 Remove unneeded extern declarations.
4936
4937 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4938
4939 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4940
4941 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4942
4943 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4944 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4945 These macros can no longer be used for assignment.
4946
4947 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4948 Assign struct members directly, instead of using BUF_BEGV etc.
4949 (record_buffer_markers, fetch_buffer_markers): New functions for
4950 recording and fetching special buffer markers.
4951 (set_buffer_internal_1, set_buffer_temp): Use them.
4952
4953 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4954
4955 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4956
4957 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4958 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4959
4960 * xdisp.c (hscroll_window_tree):
4961 (reconsider_clip_changes): Use PT instead of BUF_PT.
4962
4963 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4964
4965 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4966 $(EMACS_ROOT)/lib/intprops.h.
4967
4968 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4969
4970 Fix more problems found by GCC 4.5.2's static checks.
4971
4972 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4973 to unsigned char * to avoid compiler diagnostic.
4974 (xg_free_frame_widgets): Make it clear that a local variable is
4975 needed only if USE_GTK_TOOLTIP.
4976 (gdk_window_get_screen): Make it clear that this macro is needed
4977 only if USE_GTK_TOOLTIP.
4978 (int_gtk_range_get_value): New function, which avoids a diagnostic
4979 from gcc -Wbad-function-cast.
4980 (xg_set_toolkit_scroll_bar_thumb): Use it.
4981 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4982 diagnostic from gcc -Wbad-function-cast.
4983 (get_utf8_string, xg_get_file_with_chooser):
4984 Rename locals to avoid shadowing.
4985 (create_dialog): Move locals to avoid shadowing.
4986
4987 * xgselect.c (xg_select): Remove unused var.
4988
4989 * image.c (four_corners_best): Mark locals as initialized.
4990 (gif_load): Initialize transparent_p to zero (Bug#8238).
4991 Mark another local as initialized.
4992 (my_png_error, my_error_exit): Mark with NO_RETURN.
4993
4994 * image.c (clear_image_cache): Now static.
4995 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4996 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4997 (x_edge_detection): Remove unnecessary cast that
4998 gcc -Wbad-function-cast diagnoses.
4999 (gif_load): Fix pointer signedness.
5000 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5001 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5002
5003 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5004
5005 Improve quality of tests for time stamp overflow.
5006 For example, without this patch (encode-time 0 0 0 1 1
5007 1152921504606846976) returns the obviously-bogus value (-948597
5008 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5009 reports time overflow. See
5010 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5011 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5012 * editfns.c: Include limits.h and intprops.h.
5013 (TIME_T_MIN, TIME_T_MAX): New macros.
5014 (time_overflow): Move earlier, to before first use.
5015 (hi_time, lo_time): New functions, for an accurate test for
5016 out-of-range times.
5017 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5018 (Fget_internal_run_time): Don't assume time_t fits in int.
5019 (make_time): Use list2 instead of Fcons twice.
5020 (Fdecode_time): More accurate test for out-of-range times.
5021 (check_tm_member): New function.
5022 (Fencode_time): Use it, to test for out-of-range times.
5023 (lisp_time_argument): Don't rely on undefined left-shift and
5024 right-shift behavior when checking for time stamp overflow.
5025
5026 * editfns.c (time_overflow): New function, refactoring common code.
5027 (Fformat_time_string, Fdecode_time, Fencode_time):
5028 (Fcurrent_time_string): Use it.
5029
5030 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5031 * dired.c (make_time): Move to ...
5032 * editfns.c (make_time): ... here.
5033 * systime.h: Note the move.
5034
5035 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5036
5037 * fringe.c (update_window_fringes): Remove unused variables.
5038
5039 * unexmacosx.c (copy_data_segment): Also copy __got section.
5040 (Bug#8223)
5041
5042 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5043
5044 * termcap.c [MSDOS]: Include "msdos.h".
5045 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5046 Constify `char *' arguments and their references according to
5047 prototypes in tparam.h.
5048
5049 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5050
5051 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5052 Adapt all references accordingly.
5053
5054 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5055
5056 2011-03-11 Tom Tromey <tromey@redhat.com>
5057
5058 * buffer.c (syms_of_buffer): Remove obsolete comment.
5059
5060 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5061
5062 * termhooks.h (encode_terminal_code): Declare prototype.
5063
5064 * msdos.c (encode_terminal_code): Don't declare prototype.
5065
5066 * term.c (encode_terminal_code): Now external again, used by
5067 w32console.c and msdos.c.
5068
5069 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5070 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5071
5072 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5073
5074 Fix some minor problems found by GCC 4.5.2's static checks.
5075
5076 * fringe.c (update_window_fringes): Mark locals as initialized
5077 (Bug#8227).
5078 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5079
5080 * alloc.c (mark_fringe_data): Move decl from here ...
5081 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5082 to check its interface.
5083 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5084
5085 * fontset.c (free_realized_fontset): Now static.
5086 (Fset_fontset_font): Rename local to avoid shadowing.
5087 (fontset_font): Mark local as initialized.
5088 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5089
5090 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5091
5092 * xselect.c (x_disown_buffer_selections): Remove; not used.
5093 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5094 (x_own_selection, Fx_disown_selection_internal): Rename locals
5095 to avoid shadowing.
5096 (x_handle_dnd_message): Remove local to avoid shadowing.
5097
5098 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5099 so that the caller can use some name other than gcpro1.
5100 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5101 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5102 (Fx_backspace_delete_keys_p):
5103 Use them to avoid shadowing, and rename vars to avoid shadowing.
5104 (x_decode_color, x_set_name, x_window): Now static.
5105 (Fx_create_frame): Add braces to silence GCC warning.
5106 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5107 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5108 Remove unused locals.
5109 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5110 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5111 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5112 macros.
5113
5114 * xterm.h (x_mouse_leave): New decl.
5115
5116 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5117 Remove unused functions.
5118 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5119 (x_calc_absolute_position): Now static.
5120 (XTread_socket): Don't define label "out" unless it's used.
5121 Don't declare local "event" unless it's used.
5122 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5123 unless they are used.
5124 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5125 (x_fatal_error_signal): Remove; not used.
5126 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5127 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5128 (x_error_catcher, x_connection_closed, x_error_handler):
5129 (x_error_quitter, xembed_send_message, x_iconify_frame):
5130 (my_log_handler): Rename locals to avoid shadowing.
5131 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5132 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5133
5134 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5135 Rename or move locals to avoid shadowing.
5136 (tty_defined_color, merge_face_heights): Now static.
5137 (free_realized_faces_for_fontset): Remove; not used.
5138 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5139 does not deduce is never used uninitialized.
5140 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5141 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5142
5143 * terminal.c (store_terminal_param): Now static.
5144
5145 * xmenu.c (menu_highlight_callback): Now static.
5146 (set_frame_menubar): Remove unused local.
5147 (xmenu_show): Rename parameter to avoid shadowing.
5148 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5149 since they might point to immutable storage.
5150 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5151 since it's unused otherwise.
5152
5153 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5154 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5155 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5156 avoids a gcc -Wuninitialized diagnostic.
5157 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5158 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5159 does not deduce are never used uninitialized.
5160
5161 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5162
5163 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5164 * window.c (window_loop, size_window):
5165 (run_window_configuration_change_hook, enlarge_window): Likewise.
5166
5167 * window.c (display_buffer): Now static.
5168 (size_window): Mark variables that gcc -Wuninitialized
5169 does not deduce are never used uninitialized.
5170 * window.h (check_all_windows): New decl, to forestall
5171 gcc -Wmissing-prototypes diagnostic.
5172 * dispextern.h (bidi_dump_cached_states): Likewise.
5173
5174 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5175 shadowing.
5176 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5177 Include <limits.h>.
5178 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5179 and to avoid gcc -Wuninitialized warning.
5180 (load_charset_map): Mark variables that gcc -Wuninitialized
5181 does not deduce are never used uninitialized.
5182 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5183
5184 * coding.c (coding_set_source, coding_set_destination):
5185 Use "else { /* comment */ }" rather than "else /* comment */;"
5186 for clarity, and to avoid gcc -Wempty-body warning.
5187 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5188 a block, when the outer 'i' will do.
5189 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5190 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5191 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5192 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5193 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5194 Rename locals to avoid shadowing.
5195 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5196 * coding.c (emacs_mule_char, encode_invocation_designation):
5197 Now static, since they're not used elsewhere.
5198 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5199 (decode_coding_object, encode_coding_object, detect_coding_system):
5200 (decode_coding_emacs_mule): Mark variables that gcc
5201 -Wuninitialized does not deduce are never used uninitialized.
5202 (detect_coding_iso_2022): Initialize a local variable that might
5203 be used uninitialized. Leave a FIXME because it's not clear that
5204 this initialization is needed. (Bug#8211)
5205 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5206 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5207 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5208 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5209 Remove unused macros.
5210
5211 * category.c (hash_get_category_set): Remove unused local var.
5212 (copy_category_table): Now static, since it's not used elsewhere.
5213 * character.c (string_count_byte8): Likewise.
5214
5215 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5216 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5217
5218 * chartab.c (copy_sub_char_table): Now static, since it's not used
5219 elsewhere.
5220 (sub_char_table_ref_and_range, char_table_ref_and_range):
5221 Rename locals to avoid shadowing.
5222 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5223
5224 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5225 (BIDI_BOB): Remove unused macro.
5226
5227 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5228 deduce are never used uninitialized.
5229 * term.c (encode_terminal_code): Likewise.
5230
5231 * term.c (encode_terminal_code): Now static. Remove unused local.
5232
5233 * tparam.h: New file.
5234 * term.c, tparam.h: Include it.
5235 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5236 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5237 Move these decls to tparam.h, and make them agree with what
5238 is actually in tparam.c. The previous trick of using incompatible
5239 decls in different modules does not conform to the C standard.
5240 All callers of tparam changed to use tparam's actual API.
5241 * tparam.c (tparam1, tparam, tgoto):
5242 Use const pointers where appropriate.
5243
5244 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5245 * cm.h (struct cm): Likewise.
5246 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5247 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5248 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5249 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5250 (turn_on_face, init_tty): Likewise.
5251 * termchar.h (struct tty_display_info): Likewise.
5252
5253 * term.c (term_mouse_position): Rename local to avoid shadowing.
5254
5255 * alloc.c (mark_ttys): Move decl from here ...
5256 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5257
5258 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5259
5260 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5261
5262 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5263
5264 * search.c (compile_pattern_1): Remove argument regp, unused since
5265 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5266 (compile_pattern): Don't pass it.
5267
5268 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5269
5270 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5271 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5272 for ! HAVE_GTK3.
5273 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5274
5275 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5276
5277 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5278 gdk_window_get_screen, gdk_window_get_geometry,
5279 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5280 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5281 (xg_get_pixbuf_from_pixmap): New function.
5282 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5283 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5284 Call xg_get_pixbuf_from_pixmap instead of
5285 gdk_pixbuf_get_from_drawable.
5286 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5287 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5288 (xg_check_special_colors): Use GtkStyleContext and its functions
5289 for HAVE_GTK3.
5290 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5291 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5292 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5293 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5294 Call gtk_widget_get_preferred_size.
5295 (xg_frame_resized): gdk_window_get_geometry only takes 5
5296 parameters.
5297 (xg_win_to_widget, xg_event_is_for_menubar):
5298 Call gdk_x11_window_lookup_for_display.
5299 (xg_set_widget_bg): New function.
5300 (delete_cb): New function.
5301 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5302 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5303 (xg_set_background_color): Call xg_set_widget_bg.
5304 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5305 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5306 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5307 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5308 if ! HAVE_GTK3.
5309 (update_frame_tool_bar): Call gtk_widget_hide.
5310 (xg_initialize): Use GDK_KEY_g.
5311
5312 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5313 if ! HAVE_GTK3
5314 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5315
5316 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5317 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5318 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5319
5320 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5321
5322 * w32xfns.c (select_palette): Check success of RealizePalette against
5323 GDI_ERROR, not zero.
5324
5325 See ChangeLog.11 for earlier changes.
5326
5327 ;; Local Variables:
5328 ;; coding: utf-8
5329 ;; End:
5330
5331 Copyright (C) 2011 Free Software Foundation, Inc.
5332
5333 This file is part of GNU Emacs.
5334
5335 GNU Emacs is free software: you can redistribute it and/or modify
5336 it under the terms of the GNU General Public License as published by
5337 the Free Software Foundation, either version 3 of the License, or
5338 (at your option) any later version.
5339
5340 GNU Emacs is distributed in the hope that it will be useful,
5341 but WITHOUT ANY WARRANTY; without even the implied warranty of
5342 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5343 GNU General Public License for more details.
5344
5345 You should have received a copy of the GNU General Public License
5346 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.