1 2011-06-20 Paul Eggert <eggert@cs.ucla.edu>
3 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4 Don't assume string length fits in int.
6 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8 * font.c: Don't assume string length fits in int.
9 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10 Use ptrdiff_t, not int.
11 (font_intern_prop): Don't assume string length fits in int.
12 Don't assume integer property fits in fixnum.
13 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
15 * filelock.c: Fix some buffer overrun and integer overflow issues.
16 (get_boot_time): Don't assume that gzip command string fits in 100 bytes.
17 Reformulate so as not to need the command string.
18 Invoke gzip -cd rather than gunzip, as it's more portable.
19 (lock_info_type, lock_file_1, lock_file):
20 Don't assume pid_t and time_t fit in unsigned long.
21 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
22 (current_lock_owner): Prefer signed type for sizes.
23 Use memcpy, not strncpy, where memcpy is what is really wanted.
24 Don't assume (via atoi) that time_t and pid_t fit in int.
25 Check for time_t and/or pid_t out of range, e.g., via a network share.
26 Don't alloca where an auto var works fine.
28 2011-06-19 Paul Eggert <eggert@cs.ucla.edu>
30 * fileio.c: Fix some integer overflow issues.
31 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
32 Don't assume string length fits in int.
33 (directory_file_name): Don't assume string length fits in long.
34 (make_temp_name): Don't assume pid fits in int, or that its print
35 length is less than 20.
37 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
39 * coding.c (make_subsidiaries): Don't assume string length fits in int.
41 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
43 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
44 We prefer signed integers, even for size calculations.
46 * emacs.c: Don't assume string length fits in 'int'.
47 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
48 (main): Don't invoke strlen when not needed.
50 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
51 (XD_DEBUG_MESSAGE): Don't waste a byte.
53 * callproc.c (getenv_internal_1, getenv_internal)
55 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
57 * lread.c (invalid_syntax): Omit length argument.
58 All uses changed. This doesn't fix a bug, but it simplifies the
59 code away from its former Hollerith-constant appearance, and it's
60 one less 'int' to worry about when looking at integer-overflow issues.
61 (string_to_number): Simplify the 2011-04-26 change by invoking xsignal1.
63 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
64 This didn't break anything, but it didn't help either.
65 It's confusing to put a bogus integer in a place where the actual
66 value does not matter.
67 (LIST_END_P): Remove unused macro and its bogus comment.
68 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
70 2011-06-18 Paul Eggert <eggert@cs.ucla.edu>
72 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
73 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
75 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
76 We prefer signed types, and the value cannot exceed the EMACS_INT
77 range anyway (because otherwise the length would not be representable).
78 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
79 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
80 This avoids a GCC warning when WIDE_EMACS_INT.
82 * indent.c (sane_tab_width): New function.
83 (current_column, scan_for_column, Findent_to, position_indentation)
84 (compute_motion): Use it. This is just for clarity.
85 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
87 * image.c (xbm_image_p): Don't assume stated width and height fit in int.
89 * lisp.h (lint_assume): New macro.
90 * composite.c (composition_gstring_put_cache):
91 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
93 * editfns.c, insdel.c:
94 Omit unnecessary forward decls, to simplify future changes.
96 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
98 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
100 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
101 Use much-faster test for byte-length change.
102 Don't assume string byte-length fits in 'int'.
103 Check that character arg fits in 'int'.
104 (mapcar1): Declare byte as byte, for clarity.
106 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
108 * fns.c (concat): Catch string overflow earlier.
109 Do not rely on integer wraparound.
111 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
113 2011-06-17 Paul Eggert <eggert@cs.ucla.edu>
115 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
116 * xdisp.c (forward_to_next_line_start)
117 (back_to_previous_visible_line_start)
118 (reseat_at_next_visible_line_start, next_element_from_buffer):
119 Don't arbitrarily truncate the value of 'selective' to int.
121 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
123 * composite.c: Don't truncate sizes to 'int'.
124 (composition_gstring_p, composition_reseat_it)
125 (composition_adjust_point): Use EMACS_INT, not int.
126 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
127 not EMACS_UINT, for indexes.
129 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
131 * buffer.c: Include <verify.h>.
132 (struct sortvec.priority, struct sortstr.priority):
133 Now EMACS_INT, not int.
134 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
135 (struct sortstr.size, record_overlay_string)
136 (struct sortstrlist.size, struct sortlist.used):
137 Don't truncate size to int.
138 (record_overlay_string): Check for size-calculation overflow.
139 (init_buffer_once): Check at compile-time, not run-time.
141 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
143 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
144 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
145 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
147 Improve buffer-overflow checking (Bug#8873).
148 * fileio.c (Finsert_file_contents):
149 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
150 Remove the old (too-loose) buffer overflow checks.
151 They weren't needed, since make_gap checks for buffer overflow.
152 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
153 The old code merely checked for Emacs fixnum overflow, and relied
154 on undefined (wraparound) behavior. The new code avoids undefined
155 behavior, and also checks for ptrdiff_t and/or size_t overflow.
157 * editfns.c (Finsert_char): Don't dump core with very negative counts.
158 Tune. Don't use wider integers than needed. Don't use alloca.
159 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
161 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
163 * insdel.c, lisp.h (buffer_overflow): New function.
164 (insert_from_buffer_1, replace_range, replace_range_2):
165 * insdel.c (make_gap_larger):
166 * editfns.c (Finsert_char):
167 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
169 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
171 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
173 Integer overflow and signedness fixes (Bug#8873).
175 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
176 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
178 * fileio.c: Don't assume EMACS_INT fits in off_t.
179 (emacs_lseek): New static function.
180 (Finsert_file_contents, Fwrite_region): Use it.
181 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
183 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
185 * fns.c: Don't overflow int when computing a list length.
186 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
187 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
188 truncation on 64-bit hosts. Check for QUIT every
189 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
190 faster and is responsive enough.
191 (Flength): Report an error instead of overflowing an integer.
192 (Fsafe_length): Return a float if the value is not representable
193 as a fixnum. This shouldn't happen except in contrived situations.
194 (Fnthcdr, Fsort): Don't assume list length fits in int.
195 (Fcopy_sequence): Don't assume vector length fits in int.
197 * alloc.c: Check that resized vectors' lengths fit in fixnums.
198 (header_size, word_size): New constants.
199 (allocate_vectorlike): Don't check size overflow here.
200 (allocate_vector): Check it here instead, since this is the only
201 caller of allocate_vectorlike that could cause overflow.
202 Check that the new vector's length is representable as a fixnum.
204 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
205 The previous code was bogus. For example, next_almost_prime (32)
206 returned 39, which is undesirable as it is a multiple of 3; and
207 next_almost_prime (24) returned 25, which is a multiple of 5 so
208 why was the code bothering to check for multiples of 7?
210 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
212 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
214 Variadic C functions now count arguments with ptrdiff_t.
215 This partly undoes my 2011-03-30 change, which replaced int with size_t.
216 Back then I didn't know that the Emacs coding style prefers signed int.
217 Also, in the meantime I found a few more instances where arguments
218 were being counted with int, which may truncate counts on 64-bit
219 machines, or EMACS_INT, which may be unnecessarily wide.
220 * lisp.h (struct Lisp_Subr.function.aMANY)
221 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
222 Arg counts are now ptrdiff_t, not size_t.
223 All variadic functions and their callers changed accordingly.
224 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
225 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
226 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
227 * callint.c (Fcall_interactively): Check arg count for overflow,
228 to avoid potential buffer overrun. Use signed char, not 'int',
229 for 'varies' array, so that we needn't bother to check its size
230 calculation for overflow.
231 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
232 * eval.c (apply_lambda):
233 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
234 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
235 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
237 * callint.c (Fcall_interactively): Don't use index var as event count.
239 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
240 * mem-limits.h (SIZE): Remove; no longer used.
242 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
244 Remove unnecessary casts.
245 * xterm.c (x_term_init):
246 * xfns.c (x_set_border_pixel):
247 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
248 These aren't needed now that we assume ANSI C.
250 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
251 It's more likely to cause problems (due to unsigned overflow)
254 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
256 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
258 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
260 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
262 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
264 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
266 GLYPH_CODE_FACE returns EMACS_INT, not int.
267 * dispextern.h (merge_faces):
268 * xfaces.c (merge_faces):
269 * xdisp.c (get_next_display_element, next_element_from_display_vector):
270 Don't assume EMACS_INT fits in int.
272 * character.h (CHAR_VALID_P): Remove unused parameter.
273 * fontset.c, lisp.h, xdisp.c: All uses changed.
275 * editfns.c (Ftranslate_region_internal): Omit redundant test.
277 * fns.c (concat): Minor tuning based on overflow analysis.
278 This doesn't fix any bugs. Use int to hold character, instead
279 of constantly refetching from Emacs object. Use XFASTINT, not
280 XINT, for value known to be a character. Don't bother comparing
281 a single byte to 0400, as it's always less.
283 * floatfns.c (Fexpt):
284 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
286 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
289 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
291 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
292 Without this fix, on a 64-bit host (aset S 0 4294967386) would
293 incorrectly succeed when S was a string, because 4294967386 was
294 truncated before it was used.
296 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
297 Otherwise, an out-of-range integer could cause undefined behavior
300 * composite.c: Use int, not EMACS_INT, for characters.
301 (fill_gstring_body, composition_compute_stop_pos): Use int, not
302 EMACS_INT, for values that are known to be in character range.
303 This doesn't fix any bugs but is the usual style inside Emacs and
304 may generate better code on 32-bit machines.
306 Make sure a 64-bit char is never passed to ENCODE_CHAR.
307 This is for reasons similar to the recent CHAR_STRING fix.
308 * charset.c (Fencode_char): Check that character arg is actually
309 a character. Pass an int to ENCODE_CHAR.
310 * charset.h (ENCODE_CHAR): Verify that the character argument is no
311 wider than 'int', as a compile-time check to prevent future regressions
314 * character.c (char_string): Remove unnecessary casts.
316 Make sure a 64-bit char is never passed to CHAR_STRING.
317 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
318 by silently ignoring the top 32 bits, allowing some values
319 that were far too large to be valid characters.
320 * character.h: Include <verify.h>.
321 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
322 arguments are no wider than unsigned, as a compile-time check
323 to prevent future regressions in this area.
325 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
326 (Fsubst_char_in_region):
328 * xdisp.c (decode_mode_spec_coding):
329 Adjust to CHAR_STRING's new requirement.
330 * editfns.c (Finsert_char, Fsubst_char_in_region):
331 * fns.c (concat): Check that character args are actually
332 characters. Without this test, these functions did the wrong
333 thing with wildly out-of-range values on 64-bit hosts.
335 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
336 These casts should not be needed on 32-bit hosts, either.
337 * keyboard.c (read_char):
338 * lread.c (Fload): Remove casts to unsigned.
340 * lisp.h (UNSIGNED_CMP): New macro.
341 This fixes comparison bugs on 64-bit hosts.
342 (ASCII_CHAR_P): Use it.
343 * casefiddle.c (casify_object):
344 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
345 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
346 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
347 * dispextern.h (FACE_FROM_ID):
348 * keyboard.c (read_char): Use UNSIGNED_CMP.
350 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
351 not to EMACS_INT, to avoid GCC warning.
353 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
355 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
356 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
357 isn't needed on 32-bit machines.
359 * buffer.c (Fgenerate_new_buffer_name):
360 Use EMACS_INT for count, not int.
361 (advance_to_char_boundary): Return EMACS_INT, not int.
363 * data.c (Qcompiled_function): Now static.
365 * window.c (window_body_lines): Now static.
367 * image.c (gif_load): Rename local to avoid shadowing.
369 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
370 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
371 * alloc.c (make_save_value): Integer argument is now of type
373 (mark_object): Use ptrdiff_t, not int.
374 * lisp.h (pD): New macro.
375 * print.c (print_object): Use it.
377 * alloc.c: Use EMACS_INT, not int, to count objects.
378 (total_conses, total_markers, total_symbols, total_vector_size)
379 (total_free_conses, total_free_markers, total_free_symbols)
380 (total_free_floats, total_floats, total_free_intervals)
381 (total_intervals, total_strings, total_free_strings):
382 Now EMACS_INT, not int. All uses changed.
383 (Fgarbage_collect): Compute overall total using a double, so that
384 integer overflow is less likely to be a problem. Check for overflow
385 when converting back to an integer.
386 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
387 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
388 These were 'int' variables that could overflow on 64-bit hosts;
389 they were never used, so remove them instead of repairing them.
390 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
391 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
392 Previously, this ceilinged at INT_MAX, but that doesn't work on
394 (allocate_pseudovector): Don't use EMACS_INT when int would do.
396 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
397 (allocate_vectorlike): Check for ptrdiff_t overflow.
398 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
399 when a (possibly-narrower) signed value would do just as well.
400 We prefer using signed arithmetic, to avoid comparison confusion.
402 * alloc.c: Catch some string size overflows that we were missing.
403 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
404 for convenience in STRING_BYTES_MAX.
405 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
406 The definition here is exact; the one in lisp.h was approximate.
407 (allocate_string_data): Check for string overflow. This catches
408 some instances we weren't catching before. Also, it catches
409 size_t overflow on (unusual) hosts where SIZE_MAX <= min
410 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
411 and ptrdiff_t and EMACS_INT are both 64 bits.
413 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
414 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
415 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
417 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
419 * alloc.c (Fmake_string): Check for out-of-range init.
421 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
423 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
425 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
427 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
428 xg_get_default_scrollbar_width.
430 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
431 (int_gtk_range_get_value): Move to the scroll bar part of the file.
432 (style_changed_cb): Call update_theme_scrollbar_width and call
433 x_set_scroll_bar_default_width and xg_frame_set_char_size for
434 all frames (Bug#8505).
435 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
436 Call gtk_window_set_resizable if HAVE_GTK3.
437 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
438 and height if HAVE_GTK3 (Bug#8505).
439 (scroll_bar_width_for_theme): New variable.
440 (update_theme_scrollbar_width): New function.
441 (xg_get_default_scrollbar_width): Move code to
442 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
443 (xg_initialize): Call update_theme_scrollbar_width.
445 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
447 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
449 2011-06-12 Martin Rudalics <rudalics@gmx.at>
451 * frame.c (make_frame): Call other_buffer_safely instead of
454 * window.c (temp_output_buffer_show): Call display_buffer with
455 second argument Vtemp_buffer_show_specifiers and reset latter
456 immediately after the call.
457 (Vtemp_buffer_show_specifiers): New variable.
458 (auto_window_vscroll_p, next_screen_context_lines)
459 (Vscroll_preserve_screen_position): Remove leading asterisks from
462 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
464 Fix minor problems found by GCC 4.6.0 static checking.
465 * buffer.c (Qclone_number): Remove for now, as it's unused.
466 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
467 (record_buffer): Remove unused local.
468 * frame.c (other_visible_frames, frame_buffer_list): Now static.
469 (set_frame_buffer_list): Remove; unused.
470 * frame.h (other_visible_frames): Remove decl.
471 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
472 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
473 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
475 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
476 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
477 Define only if HAVE_GPM.
478 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
479 (update_hints_inhibit): Remove; never set. All uses removed.
480 * widgetprv.h (emacsFrameClassRec): Remove decl.
481 * window.c (delete_deletable_window): Now returns void, since it
482 wasn't returning anything.
483 (compare_window_configurations): Remove unused locals.
484 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
485 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
486 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
487 the same widths as pointers. This follows up on the 2011-05-06 patch.
488 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
490 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
492 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
494 * makefile.w32-in: Update dependencies.
495 (LISP_H): Add lib/intprops.h.
497 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
499 * image.c (gif_load): Add animation frame delay to the metadata.
500 (syms_of_image): Use DEFSYM. New symbol `delay'.
502 2011-06-11 Martin Rudalics <rudalics@gmx.at>
504 * window.c (delete_deletable_window): Re-add.
505 (Fset_window_configuration): Rewrite to handle dead buffers and
506 consequently deletable windows.
507 (window_tree, Fwindow_tree): Remove. Supply functionality in
509 (compare_window_configurations): Simplify code.
511 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
513 * image.c (imagemagick_load_image): Fix type mismatch.
514 (Fimagemagick_types): Likewise.
516 * window.h (replace_buffer_in_windows): Declare.
518 2011-06-11 Martin Rudalics <rudalics@gmx.at>
520 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
521 Qclone_number. Remove external declaration of Qdelete_window.
522 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
524 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
525 Qbuffer_list_update_hook if allowed.
526 (Fother_buffer): Rewrite doc-string. Major rewrite for new
527 buffer list implementation.
528 (other_buffer_safely): New function.
529 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
530 calls to replace_buffer_in_windows and
531 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
533 (record_buffer): Inhibit quitting and rewrite using quittable
534 functions. Run Qbuffer_list_update_hook if allowed.
535 (Frecord_buffer, Funrecord_buffer): New functions.
536 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
537 switch-to-buffer to window.el.
538 (bury-buffer): Move to window.el.
539 (Vbuffer_list_update_hook): New variable.
541 * lisp.h (other_buffer_safely): Add prototype in buffer.c
544 * window.h (resize_frame_windows): Move up in code.
545 (Fwindow_frame): Remove EXFUN.
546 (replace_buffer_in_all_windows): Remove prototype.
547 (replace_buffer_in_windows_safely): Add prototype.
549 * window.c: Declare Qdelete_window static again. Move down
550 declaration of select_count.
551 (Fnext_window, Fprevious_window): Rewrite doc-strings.
552 (Fother_window): Move to window.el.
553 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
554 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
555 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
557 (replace_buffer_in_windows): Implement by calling
558 Qreplace_buffer_in_windows.
559 (replace_buffer_in_all_windows): Remove with some functionality
560 moved into replace_buffer_in_windows_safely.
561 (replace_buffer_in_windows_safely): New function.
562 (select_window_norecord, select_frame_norecord): Move in front
563 of run_window_configuration_change_hook. Remove now obsolete
565 (Fset_window_buffer): Rewrite doc-string. Call
566 Qrecord_window_buffer.
567 (keys_of_window): Move binding for other-window to window.el.
569 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
571 * dispextern.h (struct image): Replace data member, whose int_val
572 and ptr_val fields were not used by anything, with a single
575 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
576 (gif_clear_image, gif_load, imagemagick_load_image)
577 (gs_clear_image, gs_load): Callers changed.
579 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
581 * buffer.h: Include <time.h>, for time_t.
582 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
584 Fix minor problems found by static checking.
586 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
588 Make identifiers static if they are not used in other modules.
589 * data.c (Qcompiled_function, Qframe, Qvector):
590 * image.c (QimageMagick, Qsvg):
591 * minibuf.c (Qmetadata):
592 * window.c (resize_window_check, resize_root_window): Now static.
593 * window.h (resize_window_check, resize_root_window): Remove decls.
595 * window.c (window_deletion_count, delete_deletable_window):
597 (window_body_lines): Now static.
598 (Fdelete_other_windows_internal): Mark vars as initialized.
599 Make sure 'resize_failed' is initialized.
600 (run_window_configuration_change_hook): Rename local to avoid shadowing.
601 (resize_window_apply): Remove unused local.
602 * window.h (delete_deletable_window): Remove decl.
604 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
605 (imagemagick_load_image): Fix pointer signedness problem by changing
606 last arg from unsigned char * to char *. All uses changed.
607 Also, fix a local for similar reasons.
608 Remove unused locals. Remove locals to avoid shadowing.
609 (fn_rsvg_handle_free): Remove; unused.
610 (svg_load, svg_load_image): Fix pointer signedness problem.
611 (imagemagick_load_image): Don't use garbage pointer image_wand.
613 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
615 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
617 * image.c (gif_load): Fix omitted cast error introduced by
620 2011-06-10 Martin Rudalics <rudalics@gmx.at>
622 * window.h (resize_proportionally, orig_total_lines)
623 (orig_top_line): Remove from window structure.
624 (set_window_height, set_window_width, change_window_heights)
625 (Fdelete_window): Remove prototypes.
626 (resize_frame_windows): Remove duplicate declaration.
628 2011-06-10 Eli Zaretskii <eliz@gnu.org>
630 * window.h (resize_frame_windows, resize_window_check)
631 (delete_deletable_window, resize_root_window)
632 (resize_frame_windows): Declare prototypes.
634 * window.c (resize_window_apply): Make definition be "static" to
637 2011-06-10 Martin Rudalics <rudalics@gmx.at>
639 * window.c: Remove declarations of Qwindow_size_fixed,
640 window_min_size_1, window_min_size_2, window_min_size,
641 size_window, window_fixed_size_p, enlarge_window, delete_window.
642 Remove static from declaration of Qdelete_window, it's
643 temporarily needed by Fbury_buffer.
644 (replace_window): Don't assign orig_top_line and
646 (Fdelete_window, delete_window): Remove. Window deletion is
647 handled by window.el.
648 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
649 Fdelete_window calls with calls to Qdelete_window.
650 (Fdelete_other_windows): Remove. Deleting other windows is
651 handled by window.el.
652 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
653 handled in window.el.
654 (window_min_size_2, window_min_size_1, window_min_size): Remove.
655 Window minimum sizes are handled in window.el.
656 (shrink_windows, size_window, set_window_height)
657 (set_window_width, change_window_heights, window_height)
658 (window_width, CURBEG, CURSIZE, enlarge_window)
659 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
660 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
661 handled in window.el.
662 (make_dummy_parent): Rename to make_parent_window and give it a
663 second argument horflag.
664 (make_window): Don't set resize_proportionally any more.
665 (Fsplit_window): Remove. Windows are split in window.el.
666 (save_restore_action, save_restore_orig_size)
667 (shrink_window_lowest_first, save_restore_orig_size): Remove.
668 Resize mini windows in window.el.
669 (grow_mini_window, shrink_mini_window): Implement by calling
670 Qresize_root_window_vertically, resize_window_check and
672 (saved_window, Fset_window_configuration, save_window_save): Do
673 not handle orig_top_line, orig_total_lines, and
674 resize_proportionally.
675 (window_min_height, window_min_width): Move to window.el.
676 (keys_of_window): Move bindings for delete-other-windows,
677 split-window, delete-window and enlarge-window to window.el.
679 * buffer.c: Temporarily extern Qdelete_window.
680 (Fbury_buffer): Temporarily call Qdelete_window instead of
681 Fdelete_window (Fbury_buffer will move to window.el soon).
683 * frame.c (set_menu_bar_lines_1): Remove code handling
684 orig_top_line and orig_total_lines.
686 * dispnew.c (adjust_frame_glyphs_initially): Don't use
687 set_window_height but set heights directly.
688 (change_frame_size_1): Use resize_frame_windows.
690 * xdisp.c (init_xdisp): Don't use set_window_height but set
693 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
694 resize_frame_windows instead of change_window_heights and run
695 run_window_configuration_change_hook.
697 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
698 instead of change_window_heights and run
699 run_window_configuration_change_hook.
701 2011-06-09 Martin Rudalics <rudalics@gmx.at>
703 * window.c (replace_window): Rename second argument REPLACEMENT to
704 NEW. New third argument SETFLAG. Rewrite.
705 (delete_window, make_dummy_parent): Call replace_window with
707 (window_list_1): Move down in code.
708 (run_window_configuration_change_hook): Move set_buffer part
709 before select_frame_norecord part in order to unwind correctly.
710 Rename count1 to count.
711 (recombine_windows, delete_deletable_window, resize_root_window)
712 (Fdelete_other_windows_internal)
713 (Frun_window_configuration_change_hook, make_parent_window)
714 (resize_window_check, resize_window_apply, Fresize_window_apply)
715 (resize_frame_windows, Fsplit_window_internal)
716 (Fdelete_window_internal, Fresize_mini_window_internal): New
718 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
720 2011-06-08 Martin Rudalics <rudalics@gmx.at>
722 * window.h (window): Add some new members to window structure -
723 normal_lines, normal_cols, new_total, new_normal, clone_number,
724 splits, nest, prev_buffers, next_buffers.
725 (WINDOW_TOTAL_SIZE): Move here from window.c.
726 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
728 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
730 (make_dummy_parent): Set new members of windows structure.
731 (make_window): Move down in code. Handle new members of window
733 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
734 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
735 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
736 (Fset_window_prev_buffers, Fwindow_next_buffers)
737 (Fset_window_next_buffers, Fset_window_clone_number): New
739 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
740 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
742 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
743 Argument WINDOW can be now internal window too.
744 (Fwindow_use_time): Move up in code.
745 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
747 (Fset_window_configuration, saved_window)
748 (Fcurrent_window_configuration, save_window_save): Handle new
749 members of window structure.
750 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
751 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
752 (syms_of_window): New Lisp objects Qrecord_window_buffer,
753 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
754 Qget_mru_window, Qresize_root_window,
755 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
756 Qauto_buffer_name; staticpro them.
758 2011-06-07 Martin Rudalics <rudalics@gmx.at>
760 * window.c (Fwindow_total_size, Fwindow_left_column)
761 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
762 (Fwindow_list_1): New functions.
763 (window_box_text_cols): Replace with window_body_cols.
764 (Fwindow_width, Fscroll_left, Fscroll_right): Use
765 window_body_cols instead of window_box_text_cols.
766 (delete_window, Fset_window_configuration): Call
767 delete_all_subwindows with window as argument.
768 (delete_all_subwindows): Take a window as argument and not a
770 (window_loop): Remove handling of GET_LRU_WINDOW and
772 (Fget_lru_window, Fget_largest_window): Move to window.el.
774 * window.h: Extern window_body_cols instead of
775 window_box_text_cols. delete_all_subwindows now takes a
776 Lisp_Object as argument.
778 * indent.c (compute_motion, Fcompute_motion): Use
779 window_body_cols instead of window_box_text_cols.
781 * frame.c (delete_frame): Call delete_all_subwindows with root
784 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
786 * fns.c (Fputhash): Document return value.
788 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
790 * image.c (gif_load): Implement gif89a spec "no disposal" method.
792 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
794 Cons<->int and similar integer overflow fixes (Bug#8794).
796 Check for overflow when converting integer to cons and back.
797 * charset.c (Fdefine_charset_internal, Fdecode_char):
798 Use cons_to_unsigned to catch overflow.
799 (Fencode_char): Use INTEGER_TO_CONS.
800 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
801 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
802 * data.c (long_to_cons, cons_to_long): Remove.
803 (cons_to_unsigned, cons_to_signed): New functions.
804 These signal an error for invalid or out-of-range values.
805 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
806 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
807 * font.c (Ffont_variation_glyphs):
808 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
809 * lisp.h: Include <intprops.h>.
810 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
811 (cons_to_signed, cons_to_unsigned): New decls.
812 (long_to_cons, cons_to_long): Remove decls.
813 * undo.c (record_first_change): Use INTEGER_TO_CONS.
814 (Fprimitive_undo): Use CONS_TO_INTEGER.
815 * xfns.c (Fx_window_property): Likewise.
816 * xselect.c: Include <limits.h>.
817 (x_own_selection, selection_data_to_lisp_data):
819 (x_handle_selection_request, x_handle_selection_clear)
820 (x_get_foreign_selection, Fx_disown_selection_internal)
821 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
822 (lisp_data_to_selection_data): Use cons_to_unsigned.
823 (x_fill_property_data): Use cons_to_signed.
824 Report values out of range.
826 Check for buffer and string overflow more precisely.
827 * buffer.h (BUF_BYTES_MAX): New macro.
828 * lisp.h (STRING_BYTES_MAX): New macro.
829 * alloc.c (Fmake_string):
830 * character.c (string_escape_byte8):
831 * coding.c (coding_alloc_by_realloc):
833 * editfns.c (Fformat):
835 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
836 since they may not be the same number.
837 * editfns.c (Finsert_char):
838 * fileio.c (Finsert_file_contents):
839 Likewise for BUF_BYTES_MAX.
841 * image.c: Use ptrdiff_t, not int, for sizes.
842 (slurp_file): Switch from int to ptrdiff_t.
844 (slurp_file): Check that file size fits in both size_t (for
845 malloc) and ptrdiff_t (for sanity and safety).
847 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
848 if b->modtime has its maximal value.
850 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
852 Don't assume time_t can fit into int.
853 * buffer.h (struct buffer.modtime): Now time_t, not int.
854 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
855 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
857 Minor fixes for signed vs unsigned integers.
858 * character.h (MAYBE_UNIFY_CHAR):
859 * charset.c (maybe_unify_char):
860 * keyboard.c (read_char, reorder_modifiers):
861 XINT -> XFASTINT, since the integer must be nonnegative.
862 * ftfont.c (ftfont_spec_pattern):
863 * keymap.c (access_keymap, silly_event_symbol_error):
864 XUINT -> XFASTINT, since the integer must be nonnegative.
865 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
866 since it makes no difference and we prefer signed.
867 * keyboard.c (record_char): Use XUINT when all the neighbors do.
868 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
871 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
873 * window.h (Fwindow_frame): Declare.
875 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
877 * alloc.c: Simplify handling of large-request failures (Bug#8800).
878 (SPARE_MEMORY): Always define.
879 (LARGE_REQUEST): Remove.
880 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
882 2011-06-06 Martin Rudalics <rudalics@gmx.at>
884 * lisp.h: Move EXFUNS for Fframe_root_window,
885 Fframe_first_window and Fset_frame_selected_window to window.h.
887 * window.h: Move EXFUNS for Fframe_root_window,
888 Fframe_first_window and Fset_frame_selected_window here from
891 * frame.c (Fwindow_frame, Fframe_first_window)
892 (Fframe_root_window, Fframe_selected_window)
893 (Fset_frame_selected_window): Move to window.c.
894 (Factive_minibuffer_window): Move to minibuf.c.
895 (Fother_visible_frames_p): New function.
897 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
899 * window.c (decode_window, decode_any_window): Move up in code.
900 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
901 (inhibit_frame_unsplittable): Remove unused variable.
902 (Fwindow_buffer): Move up and rewrite doc-string.
903 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
904 (Fwindow_prev): New functions.
905 (Fwindow_frame): Move here from frame.c. Accept any window as
907 (Fframe_root_window, Fframe_first_window)
908 (Fframe_selected_window): Move here from frame.c. Accept frame
909 or arbitrary window as argument. Update doc-strings.
910 (Fminibuffer_window): Move up in code.
911 (Fwindow_minibuffer_p): Move up in code and simplify.
912 (Fset_frame_selected_window): Move here from frame.c.
914 (Fselected_window, select_window, Fselect_window): Move up in
915 code. Minor doc-string fixes.
917 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
919 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
920 Do not assume that spare memory exists; that assumption is valid
921 only if SYSTEM_MALLOC.
922 (LARGE_REQUEST): New macro, so that the issue of large requests
923 is separated from the issue of spare memory.
925 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
927 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
930 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
932 * xfns.c (x_set_scroll_bar_default_width): Move declarations
935 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
937 * gtkutil.c (xg_get_default_scrollbar_width): New function.
939 * gtkutil.h: Declare xg_get_default_scrollbar_width.
941 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
942 min width by calling x_set_scroll_bar_default_width (Bug#8505).
944 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
946 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
948 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
950 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
951 (x_clipboard_manager_save): Add return value.
952 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
954 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
955 Obey Vx_select_enable_clipboard_manager. Catch errors in
956 x_clipboard_manager_save (Bug#8779).
957 (Vx_select_enable_clipboard_manager): New variable.
958 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
960 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
962 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
964 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
966 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
967 in the current matrix if keep_current_p is non-zero.
969 2011-06-04 Eli Zaretskii <eliz@gnu.org>
971 * bidi.c (bidi_level_of_next_char): Fix last change.
973 2011-06-03 Eli Zaretskii <eliz@gnu.org>
975 Support bidi reordering of text covered by display properties.
977 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
978 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
979 (bidi_cache_search, bidi_cache_iterator_state)
980 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
981 (bidi_level_of_next_char, bidi_move_to_visually_next):
982 Support character positions inside a run of characters covered by a
984 (bidi_paragraph_init, bidi_resolve_explicit_1)
985 (bidi_level_of_next_char): Call bidi_fetch_char and
986 bidi_fetch_char_advance instead of FETCH_CHAR and
988 (bidi_init_it): Initialize new members.
989 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
991 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
992 instead of using explicit *_CHAR codes.
993 (bidi_resolve_explicit, bidi_resolve_weak):
994 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
995 bidirectional text is supported only in multibyte buffers.
996 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
997 it to initialize the frame_window_p member of struct bidi_it.
998 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
999 (bidi_resolve_explicit, bidi_resolve_weak)
1000 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1001 bidi_it->nchars is non-positive.
1002 (bidi_level_of_next_char): Don't try to lookup the cache for the
1003 next/previous character if nothing is cached there yet, or if we
1004 were just reseat()'ed to a new position.
1006 * xdisp.c (set_cursor_from_row): Set start and stop points
1007 according to the row's direction when priming the loop that looks
1008 for the glyph on which to display cursor.
1009 (single_display_spec_intangible_p): Function deleted.
1010 (display_prop_intangible_p): Reimplement to call
1011 handle_display_spec instead of single_display_spec_intangible_p.
1012 Accept 3 additional arguments needed by handle_display_spec.
1013 This fixes incorrect cursor motion across display property with complex
1014 values: lists, `(when COND...)' forms, etc.
1015 (single_display_spec_string_p): Support property values that are
1016 lists with the argument STRING its top-level element.
1017 (display_prop_string_p): Fix the condition for processing a
1018 property that is a list to be consistent with handle_display_spec.
1019 (handle_display_spec): New function, refactored from the
1020 last portion of handle_display_prop.
1021 (compute_display_string_pos): Accept additional argument
1022 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1023 value of a `display' property is a "replacing spec".
1024 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1025 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1026 the display property, but just return a value indicating whether
1027 the display property will replace the characters it covers.
1028 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1029 frame_window_p members of struct bidi_it.
1030 (compute_display_string_pos, compute_display_string_end):
1032 (push_it): Accept second argument POSITION, where pop_it should
1033 jump to continue iteration.
1034 (reseat_1): Initialize bidi_it.disp_pos.
1036 * keyboard.c (adjust_point_for_property): Adjust the call to
1037 display_prop_intangible_p to its new signature.
1039 * dispextern.h (struct bidi_it): New member frame_window_p.
1040 (bidi_init_it): Update prototypes.
1041 (display_prop_intangible_p): Update prototype.
1042 (compute_display_string_pos, compute_display_string_end):
1044 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1047 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1049 Malloc failure behavior now depends on size of allocation.
1050 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1051 * lisp.h: Change signatures accordingly.
1052 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1053 All callers changed. (Bug#8762)
1055 * gnutls.c: Use Emacs's memory allocators.
1056 Without this change, the gnutls library would invoke malloc etc.
1057 directly, which causes problems on non-SYNC_INPUT hosts, and which
1058 runs afoul of improving memory_full behavior. (Bug#8761)
1059 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1060 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1061 xfree instead of the default malloc, realloc, free.
1062 (Fgnutls_boot): No need to check for memory allocation failure,
1063 since xmalloc does that for us.
1065 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1066 * category.c (hash_get_category_set):
1067 * ccl.c (ccl_driver):
1068 * charset.c (Fdefine_charset_internal):
1069 * charset.h (struct charset.hash_index):
1070 * composite.c (get_composition_id, gstring_lookup_cache)
1071 (composition_gstring_put_cache):
1072 * composite.h (struct composition.hash_index):
1073 * dispextern.h (struct image.hash):
1074 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1075 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1076 (hashfn_equal, hashfn_user_defined, make_hash_table)
1077 (maybe_resize_hash_table, hash_lookup, hash_put)
1078 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1079 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1080 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1081 * image.c (make_image, search_image_cache, lookup_image)
1082 (xpm_put_color_table_h):
1083 * lisp.h (struct Lisp_Hash_Table):
1084 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1085 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1086 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1087 * alloc.c (allocate_vectorlike):
1088 Check for overflow in vector size calculations.
1089 * ccl.c (ccl_driver):
1090 Check for overflow when converting EMACS_INT to int.
1091 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1092 need to be updated by these changes.
1093 * fns.c (make_hash_table, maybe_resize_hash_table):
1094 Check for integer overflow with large hash tables.
1095 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1096 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1097 (SXHASH_REDUCE): New macro.
1098 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1099 Use it instead of discarding useful hash info with large hash values.
1100 (sxhash_float): New function.
1101 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1102 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1103 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1104 Rewrite to use FIXNUM_BITS, as this simplifies things.
1105 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1106 Adjust signatures to match updated version of code.
1107 (consing_since_gc): Now EMACS_INT, since a single hash table can
1108 use more than INT_MAX bytes.
1110 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1112 Make it possible to build with GCC-4.6+ -O2 -flto.
1114 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1116 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1118 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1119 Call minibuffer-inactive-mode.
1121 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1123 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1124 Update dependencies.
1126 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1128 * data.c (init_data): Remove code for UTS, this system is not
1131 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1133 Don't force ./temacs to start in terminal mode.
1135 * frame.c (make_initial_frame): Initialize faces in all cases, not
1136 only when CANNOT_DUMP is defined.
1137 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1139 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1141 * dispnew.c (add_window_display_history): Use const for the string
1142 pointer. Remove declaration, not needed.
1144 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1146 Use 'inline', not 'INLINE'.
1147 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1148 * alloc.c, fontset.c (INLINE): Remove.
1149 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1150 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1151 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1152 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1153 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1155 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1157 Make it possible to run ./temacs.
1159 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1160 syms_of_callproc does the same thing. Remove test for
1161 "initialized", do it in the caller.
1162 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1164 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1166 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1167 (read_minibuf): Use get_minibuffer.
1168 (syms_of_minibuf): Use DEFSYM.
1169 (Qmetadata): New var.
1170 * data.c (Qbuffer): Don't make it static.
1171 (syms_of_data): Use DEFSYM.
1173 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1175 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1176 (CCL_CODE_MIN): New macro.
1178 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1180 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1182 * eval.c (Qdebug): Now static.
1183 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1184 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1185 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1187 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1189 * image.c: Various fixes to ImageMagick code comments.
1190 (Fimagemagick_types): Doc fix.
1192 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1194 Minor fixes prompted by GCC 4.6.0 warnings.
1196 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1198 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1199 (x_clipboard_manager_save_all): Move extern decl to ...
1200 * xterm.h: ... here, so that it can be checked for consistency.
1202 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1204 * xselect.c (x_clipboard_manager_save_frame)
1205 (x_clipboard_manager_save_all): New functions.
1206 (Fx_clipboard_manager_save): Lisp function deleted.
1208 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1209 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1211 * xterm.h: Update prototype.
1213 2011-05-28 William Xu <william.xwl@gmail.com>
1215 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1218 2011-05-28 Jim Meyering <meyering@redhat.com>
1220 Avoid a sign-extension bug in crypto_hash_function.
1221 * fns.c (to_uchar): Define.
1222 (crypto_hash_function): Use it to convert some newly-signed
1223 variables to unsigned, to avoid sign-extension bugs. For example,
1224 without this change, (md5 "truc") would evaluate to
1225 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1226 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1227 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1229 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1231 Integer overflow fixes.
1233 * dbusbind.c: Serial number integer overflow fixes.
1234 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1235 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1236 to hold a serial number that is too large for a fixnum.
1237 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1238 Check for serial numbers out of range. Decode any serial number
1239 that was so large that it became a float. (Bug#8722)
1241 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1242 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1243 Use XFASTINT rather than XUINT when numbers are nonnegative.
1244 (xd_append_arg, Fdbus_method_return_internal):
1245 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1246 arguments, check that Lisp number is nonnegative, rather than
1247 silently wrapping negative numbers around. (Bug#8722)
1248 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1251 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1253 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1255 ccl: add integer overflow checks
1256 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1257 (IN_INT_RANGE): New macros.
1258 (ccl_driver): Use them to check for integer overflow when
1259 decoding a CCL program. Many of the new checks are whether XINT (x)
1260 fits in int; it doesn't always, on 64-bit hosts. The new version
1261 doesn't catch all possible integer overflows, but it's an
1262 improvement. (Bug#8719)
1264 * alloc.c (make_event_array): Use XINT, not XUINT.
1265 There's no need for unsigned here.
1267 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1268 This follows up to the 2011-05-06 change that substituted uintptr_t
1269 for EMACS_INT. This case wasn't caught back then.
1271 Rework Fformat to avoid integer overflow issues.
1272 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1273 now (part of C89). Include <verify.h>.
1274 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1275 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1276 (Fformat): Avoid the prepass trying to compute sizes; it was only
1277 approximate and thus did not catch overflow reliably. Instead, walk
1278 through the format just once, formatting and computing sizes as we go,
1279 checking for integer overflow at every step, and allocating a larger
1280 buffer as needed. Keep track separately whether the format is
1281 multibyte. Keep only the most-recently calculated precision, rather
1282 than them all. Record whether each argument has been converted to
1283 string. Use EMACS_INT, not int, for byte and char and arg counts.
1284 Support field widths and precisions larger than INT_MAX. Avoid
1285 sprintf's undefined behavior with conversion specifications such as %#d
1286 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1287 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1288 formatting out-of-range floating point numbers with int
1291 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1293 * data.c: Avoid integer truncation in expressions involving floats.
1294 * data.c: Include <intprops.h>.
1295 (arith_driver): When there's an integer overflow in an expression
1296 involving floating point, convert the integers to floating point
1297 so that the resulting value does not suffer from catastrophic
1298 integer truncation. For example, on a 64-bit host (* 4
1299 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1300 Do not rely on undefined behavior after integer overflow.
1302 merge count_size_as_multibyte, parse_str_to_multibyte
1303 * character.c, character.h (count_size_as_multibyte):
1304 Rename from parse_str_to_multibyte; all uses changed.
1305 Check for integer overflow.
1306 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1307 since it's now a duplicate of the other. This is more of
1308 a character than a buffer op, so better that it's in character.c.
1309 * fns.c, print.c: Adjust to above changes.
1311 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1313 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1315 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1317 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1318 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1319 (x_clipboard_manager_save): Now static.
1320 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1322 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1323 (crypto_hash_function): Now static.
1324 Fix pointer signedness problems. Avoid unnecessary initializations.
1326 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1328 * termhooks.h (Vselection_alist): Make it terminal-local.
1330 * terminal.c (create_terminal): Initialize it.
1332 * xselect.c: Support for clipboard managers.
1333 (Vselection_alist): Move to termhooks.h as terminal-local var.
1334 (LOCAL_SELECTION): New macro.
1335 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1336 (symbol_to_x_atom): Remove gratuitous arg.
1337 (x_handle_selection_request, lisp_data_to_selection_data)
1338 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1339 (x_own_selection, x_get_local_selection, x_convert_selection):
1340 New arg, specifying work frame. Use terminal-local Vselection_alist.
1341 (some_frame_on_display): Delete unused function.
1342 (Fx_own_selection_internal, Fx_get_selection_internal)
1343 (Fx_disown_selection_internal, Fx_selection_owner_p)
1344 (Fx_selection_exists_p): New optional frame arg.
1345 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1346 (x_handle_selection_clear): Don't treat other terminals with the
1347 same keyboard specially. Use the terminal-local Vselection_alist.
1348 (x_clear_frame_selections): Use Frun_hook_with_args.
1350 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1352 * xterm.h: Add support for those atoms.
1354 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1356 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1357 (converted_selections, conversion_fail_tag): New global variables.
1358 (x_selection_request_lisp_error): Free the above.
1359 (x_get_local_selection): Remove unnecessary code.
1360 (x_reply_selection_request): Args changed; handle arbitrary array
1361 of converted selections stored in converted_selections.
1362 Separate the XChangeProperty and SelectionNotify steps.
1363 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1364 (x_convert_selection): New function.
1365 (x_handle_selection_event): Simplify.
1366 (x_get_foreign_selection): Don't ignore incoming requests while
1367 waiting for an answer; this will fail when we implement
1368 SAVE_TARGETS, and seems unnecessary anyway.
1369 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1370 (Vx_sent_selection_functions): Doc fix.
1372 2011-05-26 Leo Liu <sdl.web@gmail.com>
1374 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1376 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1378 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1380 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1381 for fringe update if it has periodic bitmap.
1382 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1383 and fringe_bitmap_periodic_p.
1385 * fringe.c (get_fringe_bitmap_data): New function.
1386 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1387 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1388 row. Mark glyph row for fringe update if periodicity changed.
1390 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1391 for fringe update unless it has periodic bitmap.
1393 2011-05-25 Kenichi Handa <handa@m17n.org>
1395 * xdisp.c (get_next_display_element): Set correct it->face_id for
1396 a static composition.
1398 2011-05-24 Leo Liu <sdl.web@gmail.com>
1401 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1403 * fns.c (crypto_hash_function, Fsha1): New function.
1404 (Fmd5): Use crypto_hash_function.
1405 (syms_of_fns): Add Ssha1.
1407 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1409 * gnutls.c: Remove unused macros.
1410 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1411 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1412 Remove macros that are defined and never used.
1413 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1415 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1417 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1418 (Fx_get_selection_internal): Minor cleanup.
1419 (Fx_own_selection_internal): Rename arguments for consistency with
1422 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1424 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1426 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1428 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1430 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1432 * dispnew.c (scrolling_window): Don't exclude the case that the
1433 last enabled row in the desired matrix touches the bottom boundary.
1435 2011-05-21 Glenn Morris <rgm@gnu.org>
1437 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1438 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1439 and add some more files.
1441 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1443 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1444 report_file_error introduced by the change from 2011-05-07.
1446 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1448 * systime.h (Time): Define only if emacs is defined.
1449 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1450 where the include path doesn't have X11/X.h by default. See
1451 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1453 2011-05-20 Kenichi Handa <handa@m17n.org>
1455 * composite.c (find_automatic_composition): Fix previous change.
1457 2011-05-20 Glenn Morris <rgm@gnu.org>
1459 * lisp.mk: New file, split from Makefile.in.
1460 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1461 (shortlisp): Remove.
1462 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1464 2011-05-19 Glenn Morris <rgm@gnu.org>
1466 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1467 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1468 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1469 (lisp): Set the order to that of loadup.el.
1470 (shortlisp): Make it a copy of $lisp.
1471 (SOME_MACHINE_LISP): Remove.
1472 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1473 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1475 2011-05-18 Kenichi Handa <handa@m17n.org>
1477 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1478 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1479 (find_automatic_composition): Mostly rewrite for efficiency.
1481 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1483 * makefile.w32-in: Update dependencies.
1485 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1487 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1488 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1490 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1492 Fix some integer overflow issues, such as string length overflow.
1494 * insdel.c (count_size_as_multibyte): Check for string overflow.
1496 * character.c (lisp_string_width): Check for string overflow.
1497 Use EMACS_INT, not int, for string indexes and lengths; in
1498 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1499 the resulting string length overflows an EMACS_INT; instead,
1500 report a string overflow if no precision given. When checking for
1501 precision exhaustion, use a check that cannot possibly have
1502 integer overflow. (Bug#8675)
1503 * character.h (lisp_string_width): Adjust to new signature.
1505 * alloc.c (string_overflow): New function.
1506 (Fmake_string): Use it. This doesn't change behavior, but saves
1507 a few bytes and will simplify future changes.
1508 * character.c (string_escape_byte8): Likewise.
1509 * lisp.h (string_overflow): New decl.
1511 Fixups, following up to the user-interface timestamp change.
1512 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1513 for UI timestamps, instead of unsigned long.
1514 * msdos.c (mouse_get_pos): Likewise.
1515 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1516 * w32gui.h (Time): Define by including "systime.h" rather than by
1517 declaring it ourselves. (Bug#8664)
1519 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1520 * image.c (clear_image_cache): Likewise.
1522 * term.c (term_mouse_position): Don't assume time_t wraparound.
1524 Be more systematic about user-interface timestamps.
1525 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1526 and sometimes 'EMACS_UINT', to represent these timestamps.
1527 This change causes it to use 'Time' uniformly, as that's what X uses.
1528 This makes the code easier to follow, and makes it easier to catch
1529 integer overflow bugs such as Bug#8664.
1530 * frame.c (Fmouse_position, Fmouse_pixel_position):
1531 Use Time, not unsigned long, for user-interface timestamps.
1532 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1533 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1534 * keyboard.h (last_event_timestamp): Likewise.
1535 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1536 * menu.h (xmenu_show): Likewise.
1537 * term.c (term_mouse_position): Likewise.
1538 * termhooks.h (struct input_event.timestamp): Likewise.
1539 (struct terminal.mouse_position_hook): Likewise.
1540 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1541 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1542 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1543 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1545 * menu.h, termhooks.h: Include "systime.h", for Time.
1547 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1548 Don't assume that the difference between two unsigned long values
1549 can fit into an integer. At this point, we know button_down_time
1550 <= event->timestamp, so the difference must be nonnegative, so
1551 there's no need to cast the result if double-click-time is
1552 nonnegative, as it should be; check that it's nonnegative, just in
1553 case. This bug is triggered when events are more than 2**31 ms
1554 apart (about 25 days). (Bug#8664)
1556 * xselect.c (last_event_timestamp): Remove duplicate decl.
1557 (x_own_selection): Remove needless cast to unsigned long.
1559 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1560 that always fit in int. Use a sentinel instead of a counter, to
1561 avoid a temp and to allay GCC's concerns about possible int overflow.
1562 * frame.h (struct frame): Use int for menu_bar_items_used
1563 instead of EMACS_INT, since it always fits in int.
1565 * menu.c (grow_menu_items): Check for int overflow.
1567 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1569 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1570 Before, the code was not consistent. These values cannot exceed
1571 2**31 - 1 so there's no need to make them unsigned.
1572 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1573 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1574 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1576 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1578 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1579 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1580 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1581 presumably because the widths might not match.
1583 * window.c (size_window): Avoid needless test at loop start.
1585 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1587 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1589 2011-05-12 Drew Adams <drew.adams@oracle.com>
1591 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1593 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1595 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1596 `width' to `bar_area_x' and `bar_area_width', respectively.
1597 (x_scroll_run): Take account of fringe background extension.
1599 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1600 Rename local vars `left' and `width' to `bar_area_x' and
1601 `bar_area_width', respectively.
1602 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1603 background extension.
1605 2011-05-10 Jim Meyering <meyering@redhat.com>
1607 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1609 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1611 * image.c (Finit_image_library): Return t for built-in image types,
1612 like pbm and xbm. (Bug#8640)
1614 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1616 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1618 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1620 * w32console.c (Fset_screen_color): Doc fix.
1621 (Fget_screen_color): New function.
1622 (syms_of_ntterm): Defsubr it.
1624 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1625 unlink the temporary file if Fcall_process didn't create it in the
1627 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1628 child process will be redirected to a file specified with `:file'.
1629 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1630 cue to call_process_cleanup not to close that handle.
1632 2011-05-07 Ben Key <bkey76@gmail.com>
1634 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1635 one of two shell specific rules, either bootstrap-temacs-CMD or
1636 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1637 to the previous implementation of the bootstrap-temacs rule.
1638 The bootstrap-temacs-CMD rule is similar to the previous
1639 implementation of the bootstrap-temacs rule except that it
1640 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1643 These changes, along with some changes to nt/configure.bat,
1644 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1645 earlier fix to add support for --cflags and --ldflags options
1646 that include quotes so that it works whether make uses cmd or
1649 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1651 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1652 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1654 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1655 a string. Handle both cases.
1656 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1657 (Fdbus_register_method): Use Qinvalid_function.
1659 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1661 * makefile.w32-in: Update dependencies.
1662 (LISP_H): Add inttypes.h and stdin.h.
1663 (PROCESS_H): Add unistd.h.
1665 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1667 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1668 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1670 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1672 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1674 * term.c (vfatal): Remove stray call to va_end.
1675 It's not needed and the C Standard doesn't allow it here anyway.
1677 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1678 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1680 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1683 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1685 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1687 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1689 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1691 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1693 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1694 * charset.c (Fdefine_charset_internal): Don't initialize
1695 charset.code_space[15]. The value was garbage, on hosts with
1696 32-bit int (Bug#8600).
1698 * lread.c (read_integer): Be more consistent with string-to-number.
1699 Use string_to_number to do the actual conversion; this avoids
1700 rounding errors and fixes some other screwups. Without this fix,
1701 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1702 (digit_to_number): Move earlier, for benefit of read_integer.
1703 Return -1 if the digit is out of range for the base, -2 if it is
1704 not a digit in any supported base. (Bug#8602)
1706 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1708 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1709 to match comment at start of function. This also removes a
1710 GCC warning about overflow in a 32+64-bit port.
1712 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1714 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1715 Reported by Stefan Monnier in
1716 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1717 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1718 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1720 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1721 (EMACS_UINTPTR): Likewise, with uintptr_t.
1723 * lisp.h: Prefer 64-bit EMACS_INT if available.
1724 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1725 on 32-bit hosts that have 64-bit int, so that they can access
1727 However, temporarily disable this change unless the temporary
1728 symbol WIDE_EMACS_INT is defined.
1730 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1732 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1733 This removes an assumption that EMACS_INT and long are the same
1734 width as pointers. The assumption is true for Emacs porting targets
1735 now, but we want to make other targets possible.
1736 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1737 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1738 In the rest of the code, change types of integers that hold casted
1739 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1740 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1741 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1742 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1743 No need to cast type when ORing.
1744 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1745 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1746 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1747 assume EMACS_INT is the same width as char *.
1748 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1749 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1750 Remove no-longer-needed casts.
1751 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1752 (xg_tool_bar_help_callback, xg_make_tool_item):
1753 Use EMACS_INTPTR to hold an integer
1754 that will be cast to void *; this can avoid a GCC warning
1755 if EMACS_INT is not the same width as void *.
1756 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1757 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1758 (current_message_1, set_message_1):
1759 Use a local to convert to proper width without a cast.
1760 * xmenu.c (dialog_selection_callback): Likewise.
1762 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1763 Also, don't assume VALBITS / RAND_BITS is less than 5,
1764 and don't rely on undefined behavior when shifting a 1 left into
1766 * lisp.h (get_random): Change signature to match.
1768 * lread.c (hash_string): Use size_t, not int, for hash computation.
1769 Normally we prefer signed values; but hashing is special, because
1770 it's better to use unsigned division on hash table sizes so that
1771 the remainder is nonnegative. Also, size_t is the natural width
1772 for hashing into memory. The previous code used 'int', which doesn't
1773 retain enough info to hash well into very large tables.
1774 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1776 * dbusbind.c: Don't possibly lose pointer info when converting.
1777 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1778 Use XPNTR rather than XHASH, so that the high-order bits of
1779 the pointer aren't lost when converting through void *.
1781 * eval.c (Fautoload): Don't double-shift a pointer.
1783 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1785 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1787 * gnutls.c (DEF_GNUTLS_FN):
1788 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1790 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1792 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1795 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1797 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1798 New version that can reserve upto 2GB of heap space.
1800 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1802 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1804 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1806 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1807 `gnutls_certificate_set_x509_key_file'.
1809 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1811 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1812 Update dependencies.
1814 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1816 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1817 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1818 Remove unused parameter `fildes'.
1819 * process.c (read_process_output, send_process): Don't pass it.
1821 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1823 Fix previous change: the library cache is defined in w32.c.
1824 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1825 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1827 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1829 Implement dynamic loading of GnuTLS on Windows.
1831 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1832 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1833 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1836 * gnutls.c (Qgnutls_dll): Define.
1837 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1838 (gnutls_*): Declare function pointers.
1839 (init_gnutls_functions): New function to initialize function pointers.
1840 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1841 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1842 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1843 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1844 (emacs_gnutls_write, emacs_gnutls_read)
1845 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1846 (Fgnutls_available_p): New function.
1847 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1848 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1849 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1851 * image.c: Include w32.h.
1852 (Vimage_type_cache): Delete.
1853 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1854 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1855 (w32_delayed_load): Move to w32.c.
1857 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1859 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1860 (w32_delayed_load): Move from image.c. When loading a library, record
1861 its filename in the :loaded-from property of the library id.
1862 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1863 Initialize and staticpro them.
1864 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1866 * process.c: Include lisp.h before w32.h, not after.
1867 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1868 instead of gnutls_record_check_pending.
1870 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1872 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1874 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1875 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1878 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1880 * xterm.c (x_set_frame_alpha): Do not set property on anything
1881 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1883 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1885 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1887 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1889 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1890 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1891 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1892 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1893 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1894 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1895 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1896 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1897 (Qgnutls_bootprop_callbacks_verify): Make static.
1899 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1901 * callproc.c: Indentation fixup.
1903 * sysdep.c (wait_for_termination_1): Make static.
1904 (wait_for_termination, interruptible_wait_for_termination):
1905 Move after wait_for_termination_1.
1907 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1909 * sysdep.c (interruptible_wait_for_termination): New function
1910 which is like wait_for_termination, but allows keyboard
1913 * callproc.c (Fcall_process): Add (:file "file") as an option for
1915 (Fcall_process_region): Ditto.
1917 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1919 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1920 rather than `XVECTOR (FOO)->size'.
1922 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1923 inttypes.h, as a gnulib replacement is used if it not available in
1926 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1928 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1929 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1930 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1932 * coding.c (coding_alloc_by_realloc): Error out if destination
1933 will grow beyond MOST_POSITIVE_FIXNUM.
1934 (decode_coding_emacs_mule): Abort if there isn't enough place in
1935 charbuf for the composition carryover bytes. Reserve an extra
1936 space for up to 2 characters produced in a loop.
1937 (decode_coding_iso_2022): Abort if there isn't enough place in
1938 charbuf for the composition carryover bytes.
1940 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1942 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1943 aborting when %lld or %lll format is passed.
1944 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1945 %llo or %llx format is passed. (Bug#8545)
1947 * window.c (window_scroll_line_based): Use a marker instead of
1948 simple variables to record original value of point. (Bug#7952)
1950 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1951 produced by %s or %c overflows available buffer space. (Bug#8545)
1953 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1955 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1956 (SIZE_MAX): Move defn after all includes, as they might #define it.
1958 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1960 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1962 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1964 * keyboard.c (Qdelayed_warnings_hook): Define.
1965 (command_loop_1): Run `delayed-warnings-hook'
1966 if Vdelayed_warnings_list is non-nil.
1967 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1968 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1970 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1972 * doprnt.c (doprnt): Don't return value smaller than the buffer
1973 size if the message was truncated. (Bug#8545).
1975 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1977 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1978 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1980 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1982 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1984 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1986 * makefile.w32-in: Update dependencies.
1988 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1990 Improve `doprnt' and its usage. (Bug#8545)
1991 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1992 `format_end'. Remove support for %l as a conversion specifier.
1993 Don't use xrealloc. Improve diagnostics when the %l size modifier
1994 is used. Update the commentary.
1996 * eval.c (verror): Simplify calculation of size_t.
1998 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2001 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2003 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2006 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2008 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2009 This makes this file independent of the recent pseudovector change.
2011 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2013 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2015 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2016 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2017 Remove unused local.
2018 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2020 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2021 GCC 4.6.0 optimizes based on type-based alias analysis.
2022 For example, if b is of type struct buffer * and v of type struct
2023 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2024 != &v->size, and therefore "v->size = 1; b->size = 2; return
2025 v->size;" must therefore return 1. This assumption is incorrect
2026 for Emacs, since it type-puns struct Lisp_Vector * with many other
2027 types. To fix this problem, this patch adds a new type struct
2028 vectorlike_header that documents the constraints on layout of vectors
2029 and pseudovectors, and helps optimizing compilers not get fooled
2030 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2031 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2032 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2034 (XSETPVECTYPE): Rewrite in terms of new macro.
2035 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2036 This is a bit clearer, and further avoids the possibility of
2037 undesirable aliasing.
2038 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2039 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2040 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2041 since Lisp_Subr is a special case (no "next" field).
2042 (ASIZE): Now uses header.size rather than size.
2043 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2044 to avoid the hassle of writing XVECTOR (foo)->header.size.
2045 (struct vectorlike_header): New type.
2046 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2047 object, to help avoid aliasing.
2048 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2049 (SUBRP): Likewise, since Lisp_Subr is a special case.
2050 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2051 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2052 (struct Lisp_Hash_Table): Combine first two members into a single
2053 struct vectorlike_header member. All uses of "size" and "next" members
2054 changed to be "header.size" and "header.next".
2055 * buffer.h (struct buffer): Likewise.
2056 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2057 * frame.h (struct frame): Likewise.
2058 * process.h (struct Lisp_Process): Likewise.
2059 * termhooks.h (struct terminal): Likewise.
2060 * window.c (struct save_window_data, struct saved_window): Likewise.
2061 * window.h (struct window): Likewise.
2062 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2063 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2064 * buffer.c (init_buffer_once): Likewise.
2065 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2067 * process.c (Fformat_network_address): Use local var for size,
2070 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2072 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2073 * data.c (atof): Remove decl; no longer used or needed.
2074 (digit_to_number): Move to lread.c.
2075 (Fstring_to_number): Use new string_to_number function, to be
2076 consistent with how the Lisp reader treats infinities and NaNs.
2077 Do not assume that floating-point numbers represent EMACS_INT
2078 without losing information; this is not true on most 64-bit hosts.
2079 Avoid double-rounding errors, by insisting on integers when
2080 parsing non-base-10 numbers, as the documentation specifies.
2081 * lisp.h (string_to_number): New decl, replacing ...
2082 (isfloat_string): Remove.
2083 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2084 (read1): Do not accept +. and -. as integers; this
2085 appears to have been a coding error. Similarly, do not accept
2086 strings like +-1e0 as floating point numbers. Do not report
2087 overflow for integer overflows unless the base is not 10 which
2088 means we have no simple and reliable way to continue.
2089 Break out the floating-point parsing into a new
2090 function string_to_number, so that Fstring_to_number parses
2091 floating point numbers consistently with the Lisp reader.
2092 (digit_to_number): Move here from data.c. Make it static inline.
2093 (E_CHAR, EXP_INT): Remove, replacing with ...
2094 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2095 (string_to_number): New function, replacing isfloat_string.
2096 This function checks for valid syntax and produces the resulting
2097 Lisp float number too. Rework it so that string-to-number
2098 no longer mishandles examples like "1.0e+". Use strtoumax,
2099 so that overflow for non-base-10 numbers is reported only when
2100 there's no portable and simple way to convert to floating point.
2102 * textprop.c (set_text_properties_1): Rewrite for clarity,
2103 and to avoid GCC warning about integer overflow.
2105 * intervals.h (struct interval): Use EMACS_INT for members
2106 where EMACS_UINT might cause problems. See
2107 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2108 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2109 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2111 (offset_intervals): Tell GCC not to worry about length overflow
2112 when negating a negative length.
2114 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2115 (overrun_check_free): Likewise.
2117 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2118 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2121 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2122 (gnutls_make_error): Rename local to avoid shadowing.
2123 (gnutls_emacs_global_deinit): ifdef out; not used.
2124 (Fgnutls_boot): Use const for pointer to readonly storage.
2125 Comment out unused local. Fix pointer signedness problems.
2127 * lread.c (openp): Don't stuff size_t into an 'int'.
2128 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2129 about possible signed overflow.
2131 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2132 (GDK_KEY_g): Don't define if already defined.
2133 (xg_prepare_tooltip): Avoid pointer signedness problem.
2134 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2136 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2137 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2139 * xfns.c (Fx_window_property): Simplify a bit,
2140 to make a bit faster and to avoid GCC 4.6.0 warning.
2141 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2143 * fns.c (internal_equal): Don't assume size_t fits in int.
2145 * alloc.c (compact_small_strings): Tighten assertion a little.
2147 Replace pEd with more-general pI, and fix some printf arg casts.
2148 * lisp.h (pI): New macro, generalizing old pEd macro to other
2149 conversion specifiers. For example, use "...%"pI"d..." rather
2150 than "...%"pEd"...".
2151 (pEd): Remove. All uses replaced with similar uses of pI.
2152 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2153 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2154 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2155 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2156 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2157 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2158 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2160 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2161 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2162 * print.c (safe_debug_print, print_object): Likewise.
2163 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2165 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2166 avoiding the 0 flag, which is not portable.
2167 * process.c (Fmake_network_process): Use pI to avoid cast.
2168 * region-cache.c (pp_cache): Likewise.
2169 * xdisp.c (decode_mode_spec): Likewise.
2170 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2171 behavior on 64-bit hosts with printf arg.
2172 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2173 (x_stop_queuing_selection_requests): Likewise.
2174 (x_get_window_property): Don't truncate byte count to an 'int'
2177 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2178 here, since it parses constructs like leading '-' and spaces,
2179 which are not wanted; and it overflows with large numbers.
2180 Instead, simply match F[0-9]+, which is what is wanted anyway.
2182 * alloc.c: Remove unportable assumptions about struct layout.
2183 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2184 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2185 (allocate_vectorlike, make_pure_vector): Use the new macros,
2186 plus offsetof, to remove unportable assumptions about struct layout.
2187 These assumptions hold on all porting targets that I know of, but
2188 they are not guaranteed, they're easy to remove, and removing them
2189 makes further changes easier.
2191 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2192 This doesn't fix a bug but makes the code clearer.
2193 (string_overrun_cookie): Now const. Use initializers that
2194 don't formally overflow signed char, to avoid warnings.
2195 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2196 can cause Emacs to crash when string overrun checking is enabled.
2197 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2198 multiple of sizeof (EMACS_INT); it need not be, if
2199 alignof(EMACS_INT) < sizeof (EMACS_INT).
2200 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2202 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2204 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2206 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2208 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2209 supposed to be handshaking. (Bug#8556)
2210 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2212 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2214 * lisp.h (Qdebug): List symbol.
2215 * eval.c (Qdebug): Restore global linkage.
2216 * keyboard.c (debug-on-event): New variable.
2217 (handle_user_signal): Break into debugger when debug-on-event
2218 matches the current signal symbol.
2220 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2222 * alloc.c (check_sblock, check_string_bytes)
2223 (check_string_free_list): Convert to standard C.
2225 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2227 * w32.c (emacs_gnutls_push): Fix typo.
2229 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2231 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2232 "cast to pointer from integer of different size".
2234 Improve doprnt and its use in verror. (Bug#8545)
2235 * doprnt.c (doprnt): Document the set of format control sequences
2236 supported by the function. Use SAFE_ALLOCA instead of always
2239 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2240 is one byte too soon. Don't use xrealloc; instead xfree and
2243 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2245 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2248 * gnutls.c: Renamed global_initialized to
2249 gnutls_global_initialized. Added internals for the
2250 :verify-hostname-error, :verify-error, and :verify-flags
2251 parameters of `gnutls-boot' and documented those parameters in the
2252 docstring. Start callback support.
2253 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2254 unless a fatal error occured. Call gnutls_alert_send_appropriate
2255 on error. Return error code.
2256 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2257 (emacs_gnutls_read): Likewise.
2258 (Fgnutls_boot): Return handshake error code.
2259 (emacs_gnutls_handle_error): New function.
2260 (wsaerror_to_errno): Likewise.
2262 * w32.h (emacs_gnutls_pull): Add prototype.
2263 (emacs_gnutls_push): Likewise.
2265 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2266 (emacs_gnutls_push): Likewise.
2268 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2270 * process.c (wait_reading_process_output): Check if GnuTLS
2271 buffered some data internally if no FDs are set for TLS
2274 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2275 (LIBS): Link to USER_LIBS.
2276 ($(BLD)/gnutls.$(0)): New target.
2278 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2280 * xdisp.c (handle_single_display_spec): Rename the
2281 display_replaced_before_p argument into display_replaced_p, to
2282 make it consistent with the commentary. Fix typos in the
2285 * textprop.c (syms_of_textprop): Remove dead code.
2286 (copy_text_properties): Delete obsolete commentary about an
2287 interface that was deleted long ago. Fix typos in the description
2290 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2291 to changes in oldXMenu/XMenu.h from 2011-04-16.
2292 <menu_help_message, prev_menu_help_message>: Constify.
2293 (IT_menu_make_room): menu->help_text is now `const char **';
2296 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2297 to changes in oldXMenu/XMenu.h from 2011-04-16.
2298 (struct XMenu): Declare `help_text' `const char **'.
2300 * xfaces.c <Qunspecified>: Make extern again.
2302 * syntax.c: Include sys/types.h before including regex.h, as
2305 * doc.c (get_doc_string): Improve the format passed to `error'.
2307 * doprnt.c (doprnt): Improve commentary.
2309 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2311 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2314 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2315 changes in globals.h immediately force recompilation.
2316 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2317 $(CURDIR)/s/ms-w32.h.
2318 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2320 * character.c (Fchar_direction): Function deleted.
2321 (syms_of_character): Don't defsubr it.
2322 <char-direction-table>: Deleted.
2324 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2326 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2327 * doprnt.c: Include limits.h.
2328 (SIZE_MAX): New macro.
2329 (doprnt): Return a size_t value. 2nd arg is now size_t.
2330 Many local variables are now size_t instead of int or unsigned.
2331 Improve overflow protection. Support `l' modifier for integer
2332 conversions. Support %l conversion. Don't assume an EMACS_INT
2333 argument for integer conversions and for %c.
2335 * lisp.h (doprnt): Restore prototype.
2337 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2340 * Makefile.in (base_obj): Add back doprnt.o.
2342 * deps.mk (doprnt.o): Add back prerequisites.
2343 (callint.o): Depend on character.h.
2345 * eval.c (internal_lisp_condition_case): Include the handler
2346 representation in the error message.
2347 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2348 when breaking from the loop.
2350 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2352 * callint.c (Fcall_interactively): When displaying error message
2353 about invalid control letter, pass the character's codepoint, not
2354 a pointer to its multibyte form. Improve display of the character
2355 in octal and display also its hex code.
2357 * character.c (char_string): Use %x to display the (unsigned)
2358 codepoint of an invalid character, to avoid displaying a bogus
2361 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2362 `error', not SYMBOL_NAME itself.
2364 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2365 character arguments to `error'.
2367 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2368 to `error' in error message about FINAL_CHAR argument. Make sure
2369 FINAL_CHAR is a character, and use %c when it is passed as
2370 argument to `error'.
2372 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2374 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2376 * w32.c: Include <time.h>.
2377 (sys_localtime): New function.
2379 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2381 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2383 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2385 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2387 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2390 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2392 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2393 gl_state.e_property when gl_state.object is Qt.
2395 * insdel.c (make_gap_larger): Remove limitation of buffer size
2398 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2400 * xdisp.c (lookup_glyphless_char_display)
2401 (produce_glyphless_glyph): Handle cons cell entry in
2402 glyphless-char-display.
2403 (Vglyphless_char_display): Document it.
2405 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2406 glyphless-char-display.
2408 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2410 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2412 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2414 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2415 definition for no-X builds.
2417 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2419 Static checks with GCC 4.6.0 and non-default toolkits.
2421 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2423 * process.c (keyboard_bit_set): Define only if SIGIO.
2424 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2425 (send_process): Repair possible setjmp clobbering.
2427 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2429 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2431 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2433 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2434 Define only if needed.
2436 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2437 by pacifying GCC about it. Maybe it's time to retire it?
2438 * xfaces.c (USG, __TIMEVAL__): Likewise.
2440 * dispextern.h (struct redisplay_interface): Rename param
2442 * termhooks.h (struct terminal): Likewise.
2443 * xterm.c (xembed_send_message): Likewise.
2445 * insdel.c (make_gap_smaller): Define only if
2446 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2448 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2451 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2452 so that we aren't warned about unused symbols.
2454 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2456 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2458 * xfns.c (x_real_positions): Mark locals as initialized.
2460 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2462 * xterm.c: Fix problems found by static analysis with other toolkits.
2463 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2464 (x_dispatch_event): Declare static if USE_GTK, and
2465 define if USE_GTK || USE_X_TOOLKIT.
2466 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2467 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2468 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2469 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2471 * xmenu.c (menu_help_callback): Pointer type fixes.
2472 Use const pointers when pointing at readonly data. Avoid pointer
2474 (FALSE): Remove unused macro.
2475 (update_frame_menubar): Remove unused decl.
2477 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2479 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2480 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2481 (single_menu_item): Rename local to avoid shadowing.
2483 * keyboard.c (make_lispy_event): Remove unused local var.
2485 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2486 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2488 * bitmaps: Change bitmaps from unsigned char back to the X11
2489 compatible char. Avoid the old compiler warnings about
2490 out-of-range initializers by using, for example, '\xab' rather
2493 * xgselect.c (xgselect_initialize): Check vs interface
2494 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2496 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2498 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2499 to read-only memory.
2501 * fns.c (vector): Remove; this old hack is no longer needed.
2503 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2505 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2507 * xrdb.c (x_load_resources): Omit unused local.
2509 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2510 (x_window): Rename locals to avoid shadowing.
2511 (USG): Use the kludged USG macro, to pacify gcc.
2513 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2514 (x_term_init): Remove local to avoid shadowing.
2516 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2518 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2519 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2521 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2523 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2525 Fix regex.c, syntax.c and friends for buffers > 2GB.
2526 * syntax.h (struct gl_state_s): Declare character position members
2529 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2531 * textprop.c (verify_interval_modification, interval_of):
2532 Declare arguments EMACS_INT.
2534 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2537 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2539 * indent.c (Fvertical_motion): Local variable it_start is now
2542 * regex.c (re_match, re_match_2, re_match_2_internal)
2543 (bcmp_translate, regcomp, regexec, print_double_string)
2544 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2545 (re_compile_pattern, re_exec): Declare arguments and local
2546 variables `size_t' and `ssize_t' and return values `regoff_t', as
2548 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2549 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2550 <compile_stack_type>: `size' and `avail' are now `size_t'.
2552 * regex.h <regoff_t>: Use ssize_t, not int.
2553 (re_search, re_search_2, re_match, re_match_2): Arguments that
2554 specify buffer/string position and length are now ssize_t and
2555 size_t. Return type is regoff_t.
2557 2011-04-16 Ben Key <bkey76@gmail.com>
2559 * nsfont.m: Fixed bugs in ns_get_family and
2560 ns_descriptor_to_entity that were caused by using free to
2561 deallocate memory blocks that were allocated by xmalloc (via
2562 xstrdup). This caused Emacs to crash when compiled with
2563 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2564 --enable-checking=xmallocoverrun). xfree is now used to
2565 deallocate these memory blocks.
2567 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2569 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2571 emacs_write: Accept and return EMACS_INT for sizes.
2572 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2574 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2575 Accept and return EMACS_INT.
2576 (emacs_gnutls_write): Return the number of bytes written on
2578 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2579 (emacs_read, emacs_write): Remove check for negative size, as the
2580 Emacs source code has been audited now.
2581 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2582 (emacs_read, emacs_write): Use it.
2583 * process.c (send_process): Adjust to the new signatures of
2584 emacs_write and emacs_gnutls_write. Do not attempt to store
2585 a byte offset into an 'int'; it might overflow.
2586 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2588 * sound.c: Don't assume sizes fit in 'int'.
2589 (struct sound_device.period_size, alsa_period_size):
2590 Return EMACS_INT, not int.
2591 (struct sound_device.write, vox_write, alsa_write):
2592 Accept EMACS_INT, not int.
2593 (wav_play, au_play): Use EMACS_INT to store sizes and to
2594 record read return values.
2596 2011-04-15 Ben Key <bkey76@gmail.com>
2598 * keyboard.c (Qundefined): Don't declare static since it is used
2600 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2601 static since they are used in nsfont.m.
2603 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2605 * process.c (Qprocessp): Don't declare static.
2606 * lisp.h (Qprocessp): Declare again.
2608 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2610 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2612 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2614 Improve C-level modularity by making more things 'static'.
2616 Don't publish debugger-only interfaces to other modules.
2617 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2618 (verify_bytepos, count_markers): Move decls to the only modules
2620 * region-cache.h (pp_cache): Likewise.
2621 * window.h (check_all_windows): Likewise.
2622 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2624 * sysdep.c (croak): Now static, if
2625 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2626 * syssignal.h (croak): Declare only if not static.
2628 * alloc.c (refill_memory_reserve): Now static if
2629 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2630 * lisp.h (refill_memory_reserve): Declare only if not static.
2632 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2633 Define only if USE_LUCID.
2635 * xrdb.c (x_customization_string, x_rm_string): Now static.
2637 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2638 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2640 * xdisp.c (draw_row_with_mouse_face): Now static.
2641 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2643 * window.h (check_all_windows): Mark externally visible.
2645 * window.c (window_deletion_count): Now static.
2647 * undo.c: Make symbols static if they're not exported.
2648 (last_undo_buffer, last_boundary_position, pending_boundary):
2651 * textprop.c (interval_insert_behind_hooks): Now static.
2652 (interval_insert_in_front_hooks): Likewise.
2654 * term.c: Make symbols static if they're not exported.
2655 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2656 (max_frame_lines, tty_set_terminal_modes):
2657 (tty_reset_terminal_modes, tty_turn_off_highlight):
2658 (get_tty_terminal): Now static.
2659 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2660 * termhooks.h (term_mouse_moveto): Do not declare if
2662 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2663 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2665 * sysdep.c: Make symbols static if they're not exported.
2666 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2668 (sigprocmask_set, full_mask): Remove; unused.
2669 (wait_debugging): Mark as visible.
2670 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2671 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2673 * syntax.c (syntax_temp): Define only if !__GNUC__.
2675 * sound.c (current_sound_device, current_sound): Now static.
2677 * search.c (searchbufs, searchbuf_head): Now static.
2679 * scroll.c (scroll_cost): Remove; unused.
2680 * dispextern.h (scroll_cost): Remove decl.
2682 * region-cache.h (pp_cache): Mark as externally visible.
2684 * process.c: Make symbols static if they're not exported.
2685 (process_tick, update_tick, create_process, chan_process):
2686 (Vprocess_alist, proc_buffered_char, datagram_access):
2687 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2688 (deactivate_process): Mark defn as static, as well as decl.
2689 * lisp.h (create_process): Remove decl.
2690 * process.h (chan_process, Vprocess_alist): Remove decls.
2692 * print.c: Make symbols static if they're not exported.
2693 (print_depth, new_backquote_output, being_printed, print_buffer):
2694 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2695 (print_interval, print_number_index, initial_stderr_stream):
2697 * lisp.h (Fprinc): Remove decl.
2698 (debug_output_compilation_hack): Mark as externally visible.
2700 * sysdep.c (croak): Move decl from here to syssignal.h.
2701 * syssignal.h (croak): Put it here, so the API can be checked when
2702 'croak' is called from dissociate_if_controlling_tty.
2704 * minibuf.c: Make symbols static if they're not exported.
2705 (minibuf_save_list, choose_minibuf_frame): Now static.
2706 * lisp.h (choose_minibuf_frame): Remove decl.
2708 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2710 * lread.c: Make symbols static if they're not exported.
2711 (read_objects, initial_obarray, oblookup_last_bucket_number):
2713 (make_symbol): Remove; unused.
2714 * lisp.h (initial_obarray, make_symbol): Remove decls.
2716 * keyboard.c: Make symbols static if they're not exported.
2717 (single_kboard, recent_keys_index, total_keys, recent_keys):
2718 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2719 (this_single_command_key_start, echoing, last_auto_save):
2720 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2721 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2722 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2723 (Vlispy_mouse_stem, double_click_count):
2725 (force_auto_save_soon): Define only if SIGDANGER.
2726 (ignore_mouse_drag_p): Now static if
2727 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2728 (print_help): Remove; unused.
2729 (stop_character, last_timer_event): Mark as externally visible.
2730 * keyboard.h (ignore_mouse_drag_p): Declare only if
2731 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2732 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2733 * lisp.h (echoing): Remove decl.
2734 (force_auto_save_soon): Declare only if SIGDANGER.
2735 * xdisp.c (redisplay_window): Simplify code, to make it more
2736 obvious that ignore_mouse_drag_p is not accessed if !defined
2737 USE_GTK && !defined HAVE_NS.
2739 * intervals.c: Make symbols static if they're not exported.
2740 (merge_properties_sticky, merge_interval_right, delete_interval):
2742 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2744 * insdel.c: Make symbols static if they're not exported.
2745 However, leave prepare_to_modify_buffer alone. It's never
2746 called from outside this function, but that appears to be a bug.
2747 (combine_after_change_list, combine_after_change_buffer):
2748 (adjust_after_replace, signal_before_change): Now static.
2749 (adjust_after_replace_noundo): Remove; unused.
2750 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2751 (signal_before_change): Remove decls.
2753 * indent.c (val_compute_motion, val_vmotion): Now static.
2755 * image.c: Make symbols static if they're not exported.
2756 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2758 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2759 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2761 * fringe.c (standard_bitmaps): Now static.
2762 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2764 * frame.c: Make symbols static if they're not exported.
2765 (x_report_frame_params, make_terminal_frame): Now static.
2766 (get_frame_param): Now static, unless HAVE_NS.
2767 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2768 (x_get_resource_string): Remove; not used.
2769 * frame.h (make_terminal_frame, x_report_frame_params):
2770 (x_get_resource_string); Remove decls.
2771 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2772 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2774 * font.c, fontset.c: Make symbols static if they're not exported.
2775 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2776 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2777 * font.c (font_close_object): Now static.
2778 * font.h (font_close_object): Remove.
2779 * fontset.c (FONTSET_OBJLIST): Remove.
2780 (free_realized_fontset) #if-0 the body, which does nothing.
2781 (face_suitable_for_char_p): #if-0, as it's never called.
2782 * fontset.h (face_suitable_for_char_p): Remove decl.
2783 * xfaces.c (face_at_string_position):
2784 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2785 since 0 is always ASCII.
2787 * fns.c (weak_hash_tables): Now static.
2789 * fileio.c: Make symbols static if they're not exported.
2790 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2791 (Vwrite_region_annotation_buffers): Now static.
2793 * eval.c: Make symbols static if they're not exported.
2794 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2795 * lisp.h (backtrace_list): Remove decl.
2797 * emacs.c: Make symbols static if they're not exported.
2798 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2799 (fatal_error_code, fatal_error_signal_hook, standard_args):
2801 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2802 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2803 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2804 * lisp.h (fatal_error_signal_hook): Remove decl.
2805 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2807 * editfns.c: Move a (normally-unused) function to its only use.
2808 * editfns.c, lisp.h (get_operating_system_release): Remove.
2809 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2810 worth the hassle of breaking this out.
2812 * xterm.c: Make symbols static if they're not exported.
2813 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2814 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2815 (x_destroy_window, x_delete_display):
2817 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2818 (x_mouse_leave): Remove; unused.
2819 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2820 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2821 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2823 (x_mouse_leave): Declare only if WINDOWSNT.
2824 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2825 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2828 * ftxfont.c: Make symbols static if they're not exported.
2829 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2831 * font.h (ftxfont_driver): Likewise.
2833 * xfns.c: Make symbols static if they're not exported.
2834 (x_last_font_name, x_display_info_for_name):
2835 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2836 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2837 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2838 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2839 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2840 (last_show_tip_args): Now static.
2841 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2842 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2843 (x_screen_planes): Remove; unused.
2844 * dispextern.h (x_screen_planes): Remove decl.
2846 * dispnew.c: Make symbols static if they're not exported.
2847 * dispextern.h (redraw_garbaged_frames, scrolling):
2848 (increment_row_positions): Remove.
2849 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2850 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2852 (redraw_garbaged_frames): Remove; unused.
2854 * xfaces.c: Make symbols static if they're not exported.
2855 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2857 * xterm.h (defined_color): Remove decls.
2858 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2859 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2860 (menu_face_changed_default, defined_color, free_realized_face):
2861 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2862 (ascii_face_of_lisp_face): Remove; unused.
2864 * xdisp.c: Make symbols static if they're not exported.
2865 * dispextern.h (scratch_glyph_row, window_box_edges):
2866 (glyph_to_pixel_coords, set_cursor_from_row):
2867 (get_next_display_element, set_iterator_to_next):
2868 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2869 (show_mouse_face): Remove decls
2870 * frame.h (message_buf_print): Likewise.
2871 * lisp.h (pop_message, set_message, check_point_in_composition):
2873 * xterm.h (set_vertical_scroll_bar): Likewise.
2874 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2875 (message_buf_print, scratch_glyph_row, displayed_buffer):
2876 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2877 (get_next_display_element, show_mouse_face, window_box_edges):
2878 (frame_to_window_pixel_xy, check_point_in_composition):
2879 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2880 (glyph_to_pixel_coords): Remove; unused.
2882 * dired.c (file_name_completion): Now static.
2884 * dbusbind.c (xd_in_read_queued_messages): Now static.
2886 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2887 * data.c (circular_list_error): Remove.
2889 * commands.h (last_point_position, last_point_position_buffer):
2890 (last_point_position_window): Remove decls.
2891 * keyboard.c: Make these variables static.
2893 * coding.h (coding, code_convert_region, encode_coding_gap):
2895 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2896 (iso_code_class, detect_coding, code_convert_region): Now static.
2897 (encode_coding_gap): Remove; unused.
2899 * chartab.c (chartab_chars, chartab_bits): Now static.
2901 * charset.h (charset_iso_8859_1): Remove decl.
2902 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2905 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2906 * ccl.c (Vccl_program_table): Now static.
2907 (check_ccl_update): Remove; unused.
2909 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2910 * category.h: ... from here.
2911 * category.c (check_category_table, set_category_set): Now static.
2913 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2914 * lisp.h: Remove these decls.
2916 * buffer.c (buffer_count): Remove unused var.
2918 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2919 so that it's not optimized away.
2920 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2921 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2922 exported only to the debugger.
2924 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2925 * atimer.h (run_all_atimers): Remove; not exported.
2927 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2928 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2929 was inaccessible from Lisp.
2930 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2931 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2933 alloc.c: Import and export fewer symbols, and remove unused items.
2934 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2936 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2937 it's not optimized away by whole-program optimization.
2938 (message_enable_multibyte, free_misc): Remove.
2939 (catchlist, handlerlist, mark_backtrace):
2940 Declare only if BYTE_MARK_STACK.
2941 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2942 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2943 (message_enable_multibyte): Remove decl.
2944 (free_misc, interval_free_list, float_block, float_block_index):
2945 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2946 (cons_free_list, last_marked_index):
2948 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2949 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2950 (mark_backtrace): Define only if BYTE_MARK_STACK.
2951 * xdisp.c (message_enable_multibyte): Now static.
2953 Declare Lisp_Object Q* variables to be 'static' if not exported.
2954 This makes it easier for human readers (and static analyzers)
2955 to see whether these variables are used from other modules.
2956 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2957 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2958 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2959 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2960 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2961 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2962 * xmenu.c, xselect.c:
2963 Declare Q* vars static if they are not used in other modules.
2964 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2965 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2966 Remove decls of unexported vars.
2967 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2969 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2971 Make Emacs functions such as Fatom 'static' by default.
2972 This makes it easier for human readers (and static analyzers)
2973 to see whether these functions can be called from other modules.
2974 DEFUN now defines a static function. To make the function external
2975 so that it can be used in other C modules, use the new macro DEFUE.
2976 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2977 (Finit_image_library):
2978 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2979 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2980 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2981 Remove decls, since these functions are now static.
2982 (Funintern, Fget_internal_run_time): New decls, since these functions
2983 were already external.
2985 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2986 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2987 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2988 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2989 * keyboard.c, keymap.c, lread.c:
2990 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2991 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2992 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2993 Mark functions with DEFUE instead of DEFUN,
2994 if they are used in other modules.
2995 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2996 decls for now-static functions.
2997 * buffer.h (Fdelete_overlay): Remove decl.
2998 * callproc.c (Fgetenv_internal): Mark as internal.
2999 * composite.c (Fremove_list_of_text_properties): Remove decl.
3000 (Fcomposition_get_gstring): New forward static decl.
3001 * composite.h (Fcomposite_get_gstring): Remove decl.
3002 * dired.c (Ffile_attributes): New forward static decl.
3003 * doc.c (Fdocumntation_property): New forward static decl.
3004 * eval.c (Ffetch_bytecode): New forward static decl.
3005 (Funintern): Remove extern decl; now in .h file where it belongs.
3006 * fileio.c (Fmake_symbolic_link): New forward static decl.
3007 * image.c (Finit_image_library): New forward static decl.
3008 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3009 * intervals.h (Fprevious_property_change):
3010 (Fremove_list_of_text_properties): Remove decls.
3011 * keyboard.c (Fthis_command_keys): Remove decl.
3012 (Fcommand_execute): New forward static decl.
3013 * keymap.c (Flookup_key): New forward static decl.
3014 (Fcopy_keymap): Now static.
3015 * keymap.h (Flookup_key): Remove decl.
3016 * process.c (Fget_process): New forward static decl.
3017 (Fprocess_datagram_address): Mark as internal.
3018 * syntax.c (Fsyntax_table_p): New forward static decl.
3019 (skip_chars): Remove duplicate decl.
3020 * textprop.c (Fprevious_property_change): New forward static decl.
3021 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3023 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3024 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3026 * editfns.c (Fformat): Remove unreachable code.
3028 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3030 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3033 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3035 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3036 when at ZV. (Bug#8487)
3038 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3040 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3042 * keyboard.c (parse_tool_bar_item): Likewise.
3043 * sound.c (sound_cleanup, alsa_close): Likewise.
3044 * termcap.c (tgetent): Likewise.
3045 * xfns.c (x_default_font_parameter): Likewise.
3046 * xsettings.c (read_and_apply_settings): Likewise.
3048 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3049 (overrun_check_free): Protoize.
3051 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3053 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3054 since callers should never pass a negative size.
3055 Change the signature to match that of plain 'read' and 'write'; see
3056 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3057 * lisp.h: Update prototypes of emacs_write and emacs_read.
3059 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3061 * xdisp.c (redisplay_window): Don't try to determine the character
3062 position of the scroll margin if the window start point w->startp
3063 is outside the buffer's accessible region. (Bug#8468)
3065 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3067 Fix write-region and its subroutines for buffers > 2GB.
3068 * fileio.c (a_write, e_write): Modify declaration of arguments and
3069 local variables to support buffers larger than 2GB.
3070 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3072 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3073 argument, local variables, and return value.
3075 * lisp.h: Update prototypes of emacs_write and emacs_read.
3077 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3079 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3081 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3083 Fix more problems found by GCC 4.6.0's static checks.
3085 * xdisp.c (vmessage): Use a better test for character truncation.
3087 * charset.c (load_charset_map): <, not <=, for optimization,
3088 and to avoid potential problems with integer overflow.
3089 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3090 * casetab.c (set_identity, shuffle): Likewise.
3091 * editfns.c (Fformat): Likewise.
3092 * syntax.c (skip_chars): Likewise.
3094 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3095 This also lets GCC 4.6.0 generate slightly better loop code.
3097 * callint.c (Fcall_interactively): <, not <=, for optimization.
3098 (Fcall_interactively): Count the number of arguments produced,
3099 not the number of arguments given. This is simpler and lets GCC
3100 4.6.0 generate slightly better code.
3102 * ftfont.c: Distingish more carefully between FcChar8 and char.
3103 The previous code passed unsigned char * to a functions like
3104 strlen and xstrcasecmp that expect char *, which does not
3105 conform to the C standard.
3106 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3107 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3108 char * when the C standard requires it.
3110 * keyboard.c (read_char): Remove unused var.
3112 * eval.c: Port to Windows vsnprintf (Bug#8435).
3114 (SIZE_MAX): Define if the headers do not.
3115 (verror): Do not give up if vsnprintf returns a negative count.
3116 Instead, grow the buffer. This ports to Windows vsnprintf, which
3117 does not conform to C99. Problem reported by Eli Zaretskii.
3118 Also, simplify the allocation scheme, by avoiding the need for
3119 calling realloc, and removing the ALLOCATED variable.
3121 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3123 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3124 But keep the doprint source code for now, as we might revamp it
3125 and use it again (Bug#8435).
3126 * lisp.h (doprnt): Remove.
3127 * Makefile.in (base_obj): Remove doprnt.o.
3128 * deps.mk (doprnt.o): Remove.
3130 error: Print 32- and 64-bit integers portably (Bug#8435).
3131 Without this change, on typical 64-bit hosts error ("...%d...", N)
3132 was used to print both 32- and 64-bit integers N, which relied on
3134 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3136 * lisp.h (error, verror): Mark as printf-like functions.
3137 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3138 Report overflow in size calculations when allocating printf buffer.
3139 Do not truncate output string at its first null byte.
3140 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3141 Truncate the output at a character boundary, since vsnprintf does not
3143 * charset.c (check_iso_charset_parameter): Convert internal
3144 character to string before calling 'error', since %c now has the
3146 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3147 overflow when computing char to be passed to 'error'. Do not
3148 pass Lisp_Object to 'error'; pass the integer instead.
3149 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3150 formatted with plain %d.
3152 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3154 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3156 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3158 * xterm.c (x_catch_errors): Remove duplicate declaration.
3160 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3162 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3164 2011-04-10 Jim Meyering <meyering@redhat.com>
3166 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3167 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3168 return ssize_t not "int", and use size_t as the buffer length.
3169 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3170 * gnutls.h: Update declarations.
3171 * process.c (read_process_output): Use ssize_t, to match.
3172 (send_process): Likewise.
3174 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3176 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3178 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3180 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3181 Use unsigned char, to match FcChar8 type definition.
3183 * xterm.c (handle_one_xevent):
3184 * xmenu.c (create_and_show_popup_menu):
3185 * xselect.c (x_decline_selection_request)
3186 (x_reply_selection_request): Avoid type-punned deref of X events.
3188 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3190 Fix some uses of `int' instead of EMACS_INT.
3191 * search.c (string_match_1, fast_string_match)
3192 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3193 (scan_buffer, find_next_newline_no_quit)
3194 (find_before_next_newline, search_command, Freplace_match)
3195 (Fmatch_data): Make some `int' variables be EMACS_INT.
3197 * xdisp.c (display_count_lines): 3rd argument and return value now
3198 EMACS_INT. All callers changed.
3199 (pint2hrstr): Last argument is now EMACS_INT.
3201 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3202 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3203 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3204 (decode_coding_utf_16, decode_coding_emacs_mule)
3205 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3206 (decode_coding_ccl, decode_coding_charset)
3207 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3208 (decode_coding_iso_2022, decode_coding_emacs_mule)
3209 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3210 <char_offset, last_offset>: Declare EMACS_INT.
3211 (encode_coding_utf_8, encode_coding_utf_16)
3212 (encode_coding_emacs_mule, encode_invocation_designation)
3213 (encode_designation_at_bol, encode_coding_iso_2022)
3214 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3215 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3217 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3218 (encode_invocation_designation): Last argument P_NCHARS is now
3220 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3221 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3223 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3226 * ccl.c (Fccl_execute_on_string): Declare some variables
3229 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3231 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3233 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3235 * process.c (Fformat_network_address): Doc fix.
3237 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3239 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3241 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3243 * keyboard.c (read_char): Call Lisp function help-form-show,
3244 instead of using internal_with_output_to_temp_buffer.
3245 (Qhelp_form_show): New var.
3246 (syms_of_keyboard): Use DEFSYM macro.
3248 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3250 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3252 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3254 * process.c (Flist_processes): Remove to Lisp.
3255 (list_processes_1): Delete.
3257 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3259 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3261 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3263 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3265 Fix more problems found by GCC 4.6.0's static checks.
3267 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3269 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3271 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3273 * xdisp.c (vmessage): Mark as a printf-like function.
3275 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3277 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3279 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3280 printf-like functions.
3281 (tiff_load): Add casts to remove these marks before passing them
3282 to system-supplied API.
3284 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3286 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3287 This avoids several warnings with gcc -Wstrict-overflow.
3288 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3289 directly, rather than having caller test rule sign. This avoids
3290 some unnecessary tests.
3291 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3292 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3293 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3295 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3296 (xfont_open): Avoid unnecessary tests.
3298 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3300 * composite.h, composite.c (composition_gstring_put_cache):
3301 Use EMACS_INT, not int, for length.
3303 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3304 breaking out part of COMPOSITION_DECODE_RULE.
3305 (COMPOSITION_DECODE_RULE): Use it.
3306 * composite.c (get_composition_id): Remove unused local vars,
3307 by using the new macro.
3309 * textprop.c (set_text_properties_1): Change while to do-while,
3310 since the condition is always true at first.
3312 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3313 (interval_deletion_adjustment): Return unsigned value.
3316 * process.c (list_processes_1, create_pty, read_process_output):
3317 (exec_sentinel): Remove vars that were set but not used.
3318 (create_pty): Remove unnecessary "volatile"s.
3319 (Fnetwork_interface_info): Avoid possibility of int overflow.
3320 (read_process_output): Do adaptive read buffering even if carryover.
3321 (read_process_output): Simplify nbytes computation if buffered.
3323 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3325 * syntax.c (scan_words): Remove var that was set but not used.
3326 (update_syntax_table): Use unsigned instead of int.
3328 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3329 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3330 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3332 * print.c (print_error_message): Avoid int overflow.
3334 * font.c (font_list_entities): Redo for clarity,
3335 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3337 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3338 (font_score): Avoid potential overflow in diff calculation.
3340 * fns.c (substring_both): Remove var that is set but not used.
3341 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3343 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3345 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3346 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3347 can always succeed if overflow has undefined behavior.
3349 * search.c (boyer_moore, wordify): Remove vars set but not used.
3350 (wordify): Omit three unnecessary tests.
3352 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3353 All callers changed. This avoids the need for an unused var.
3355 * casefiddle.c (casify_region): Remove var that is set but not used.
3357 * dired.c (file_name_completion): Remove var that is set but not used.
3359 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3361 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3362 (Finsert_file_contents): Remove unnecessary code checking fd.
3364 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3365 Check for integer overflow on size calculations.
3367 * buffer.c (Fprevious_overlay_change): Remove var that is set
3370 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3371 Remove vars that are set but not used.
3372 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3373 (timer_check_2): Mark vars as initialized.
3375 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3377 * image.c (lookup_image): Remove var that is set but not used.
3378 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3380 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3381 that are set but not used.
3383 * xfns.c (make_invisible_cursor): Don't return garbage
3384 if XCreateBitmapFromData fails (Bug#8410).
3386 * xselect.c (x_get_local_selection, x_handle_property_notify):
3387 Remove vars that are set but not used.
3389 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3390 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3392 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3393 Remove var that is set but not used.
3394 (scroll_bar_windows_size): Now size_t, not int.
3395 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3398 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3399 (map_tty_color) [!defined MSDOS]: Likewise.
3401 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3403 * coding.c: Remove vars that are set but not used.
3404 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3405 All callers changed.
3406 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3407 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3408 (decode_coding_charset): Remove vars that are set but not used.
3410 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3411 that is set but not used.
3413 * print.c (print_object): Remove var that is set but not used.
3415 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3416 The gnulib version avoids calling malloc in the usual case,
3417 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3418 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3419 * filelock.c (current_lock_owner): Likewise.
3420 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3421 * sysdep.c: Include allocator.h, careadlinkat.h.
3422 (emacs_no_realloc_allocator): New static constant.
3423 (emacs_readlink): New function.
3424 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3425 ../lib/careadlinkat.h.
3427 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3429 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3430 first non-nil return value).
3432 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3434 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3435 if not defined (Bug#8403).
3437 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3439 * xdisp.c (display_count_lines): Remove parameter `start',
3440 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3441 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3442 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3443 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3444 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3445 and thereabouts. All callers changed.
3446 (get_per_char_metric): Remove parameter `f', unused since
3447 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3449 2011-04-02 Jim Meyering <meyering@redhat.com>
3451 do not dereference NULL upon failed strdup
3452 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3453 (ns_get_family): Likewise.
3455 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3457 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3459 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3461 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3464 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3466 Add lexical binding.
3468 * window.c (Ftemp_output_buffer_show): New fun.
3469 (Fsave_window_excursion):
3470 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3472 * lread.c (lisp_file_lexically_bound_p): New function.
3473 (Fload): Bind Qlexical_binding.
3474 (readevalloop): Remove `evalfun' arg.
3475 Bind Qinternal_interpreter_environment.
3476 (Feval_buffer): Bind Qlexical_binding.
3477 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3479 (syms_of_lread): Declare `lexical-binding'.
3481 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3483 * keyboard.c (eval_dyn): New fun.
3484 (menu_item_eval_property): Use it.
3486 * image.c (parse_image_spec): Use Ffunctionp.
3488 * fns.c (concat, mapcar1): Accept byte-code-functions.
3490 * eval.c (Fsetq): Handle lexical vars.
3491 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3492 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3493 (FletX, Flet): Obey lexical binding.
3494 (Fcommandp): Handle closures.
3495 (Feval): New `lexical' arg.
3496 (eval_sub): New function extracted from Feval. Use it almost
3497 everywhere where Feval was used. Look up vars in lexical env.
3499 (Ffunctionp): Move from subr.el.
3500 (Ffuncall): Handle closures.
3501 (apply_lambda): Remove `eval_flags'.
3502 (funcall_lambda): Handle closures and new byte-code-functions.
3503 (Fspecial_variable_p): New function.
3504 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3505 but without exporting it to Lisp.
3507 * doc.c (Fdocumentation, store_function_docstring):
3508 * data.c (Finteractive_form): Handle closures.
3510 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3513 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3515 (exec_byte_code): New function extracted from Fbyte_code to handle new
3516 calling convention for byte-code-functions. Add new byte-codes.
3518 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3520 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3522 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3524 * xdisp.c (redisplay_internal): Fix prototype.
3526 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3528 * xdisp.c (SCROLL_LIMIT): New macro.
3529 (try_scrolling): Use it when setting scroll_limit.
3530 Limit scrolling to 100 screen lines.
3531 (redisplay_window): Even when falling back on "recentering",
3532 position point in the window according to scroll-conservatively,
3533 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3535 (try_scrolling): When point is above the window, allow searching
3536 as far as scroll_max, or one screenful, to compute vertical
3537 distance from PT to the scroll margin position. This prevents
3538 try_scrolling from unnecessarily failing when
3539 scroll-conservatively is set to a value slightly larger than the
3540 window height. Clean up the case of PT below the margin at bottom
3541 of window: scroll_max can no longer be INT_MAX. When aggressive
3542 scrolling is in use, don't let point enter the opposite scroll
3543 margin as result of the scroll.
3544 (syms_of_xdisp) <scroll-conservatively>: Document the
3545 threshold of 100 lines for never-recentering scrolling.
3547 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3549 * dispextern.h (move_it_by_lines):
3550 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3551 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3552 (message_log_check_duplicate): Remove parameters `prev_bol' and
3553 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3554 (redisplay_internal): Remove parameter `preserve_echo_area',
3555 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3557 * indent.c (Fvertical_motion):
3558 * window.c (window_scroll_pixel_based, Frecenter):
3559 Don't pass `need_y_p' to `move_it_by_lines'.
3561 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3563 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3564 steal a few bits to be more compact.
3565 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3566 Remove unneeded casts.
3568 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3570 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3572 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3573 binding" message (bug#7967).
3575 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3577 Fix more problems found by GCC 4.6.0's static checks.
3579 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3580 Remove unused local var.
3582 * editfns.c (Fmessage_box): Remove unused local var.
3584 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3585 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3586 Omit unused local vars.
3587 * window.c (shrink_windows): Omit unused local var.
3588 * menu.c (digest_single_submenu): Omit unused local var.
3589 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3590 Omit unused local var.
3592 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3593 Don't assume string length fits in int.
3594 (keyremap_step, read_key_sequence): Use size_t for sizes.
3595 (read_key_sequence): Don't check last_real_key_start redundantly.
3597 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3598 instead of alloca (Bug#8344).
3600 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3601 (Fbacktrace_frame): Don't assume nframes fits in int.
3603 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3605 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3608 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3610 * cm.c (calccost): Turn while-do into do-while, for clarity.
3612 * keyboard.c (syms_of_keyboard): Use the same style as later
3613 in this function when indexing through an array. This also
3614 works around GCC bug 48267.
3616 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3618 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3620 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3621 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3623 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3624 This avoids undefined behavior on integer overflow, and is a bit
3625 more convenient anyway since it is compared to a size_t variable.
3627 Variadic C functions now count arguments with size_t, not int.
3628 This avoids an unnecessary limitation on 64-bit machines, which
3629 caused (substring ...) to crash on large vectors (Bug#8344).
3630 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3631 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3632 All variadic functions and their callers changed accordingly.
3633 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3634 * data.c (arith_driver, float_arith_driver): Likewise.
3635 * editfns.c (general_insert_function): Likewise.
3636 * eval.c (struct backtrace.nargs, interactive_p)
3637 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3638 (funcall_lambda, mark_backtrace): Likewise.
3639 * fns.c (concat): Likewise.
3640 * frame.c (x_set_frame_parameters): Likewise.
3641 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3642 0 if not found, not -1. All callers changed.
3644 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3645 (stack_copy_size): Now size_t, not int.
3646 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3648 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3650 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3651 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3652 All callers changed.
3654 * lisp.h (multibyte_char_to_unibyte):
3655 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3656 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3657 * character.h (CHAR_TO_BYTE8):
3658 * cmds.c (internal_self_insert):
3659 * editfns.c (general_insert_function):
3660 * keymap.c (push_key_description):
3661 * search.c (Freplace_match):
3662 * xdisp.c (message_dolog, set_message_1): All callers changed.
3664 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3666 * keyboard.c (safe_run_hook_funcall): New function.
3667 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3668 don't set the hook to nil, but remove the offending function instead.
3669 (Qcommand_hook_internal): Remove, unused.
3670 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3671 Vcommand_hook_internal.
3673 * eval.c (enum run_hooks_condition): Remove.
3674 (funcall_nil, funcall_not): New functions.
3675 (run_hook_with_args): Call each function through a `funcall' argument.
3676 Remove `cond' argument, now redundant.
3677 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3678 (Frun_hook_with_args_until_failure): Adjust accordingly.
3679 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3681 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3683 * dispextern.h (string_buffer_position): Remove declaration.
3685 * print.c (strout): Remove parameter `multibyte', unused since
3686 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3688 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3689 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3690 All callers changed.
3692 * w32.c (_wsa_errlist): Use braces for struct initializers.
3694 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3695 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3696 All callers changed.
3697 (string_buffer_position): Likewise. Also, make static (it's never
3698 used outside xdisp.c).
3699 (cursor_row_p): Remove parameter `w', unused since
3700 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3701 (decode_mode_spec): Remove parameter `precision', introduced during
3702 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3703 All callers changed.
3705 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3707 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3709 2011-03-27 Anders Lindgren <andlind@gmail.com>
3711 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3712 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3713 (ns_update_auto_hide_menu_bar): New functions.
3714 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3715 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3716 ns_constrain_all_frames.
3717 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3718 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3720 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3722 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3724 2011-03-27 Glenn Morris <rgm@gnu.org>
3726 * syssignal.h: Replace RETSIGTYPE with void.
3727 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3728 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3729 Replace SIGTYPE with void everywhere.
3730 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3731 * s/template.h (SIGTYPE): Remove commented out definition.
3733 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3735 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3736 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3738 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3740 * w32.c (read_unc_volume): Use parameter `henum', instead of
3741 global variable `wget_enum_handle'.
3743 * keymap.c (describe_vector): Remove parameters `indices' and
3744 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3745 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3747 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3749 * keyboard.c (timer_check): Remove parameter `do_it_now',
3750 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3751 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3752 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3754 * keyboard.c (read_char):
3755 * w32menu.c (w32_menu_display_help):
3756 * xmenu.c (show_help_event, menu_help_callback):
3757 Adjust calls to `show_help_echo'.
3759 * gtkutil.c (xg_maybe_add_timer):
3760 * keyboard.c (readable_events):
3761 * process.c (wait_reading_process_output):
3762 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3764 * insdel.c (adjust_markers_gap_motion):
3765 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3766 (gap_left, gap_right): Don't call it.
3768 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3770 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3771 incurred during fontification.
3773 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3775 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3776 (DEFVAR_PER_BUFFER): Don't pass it.
3778 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3779 (scrolling_window): Don't pass it.
3781 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3783 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3785 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3787 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3788 of variables specific to SELinux and computation of `encoded_absname'.
3790 * image.c (XPutPixel): Remove unused variable `height'.
3792 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3794 * unexw32.c (get_section_info): Remove unused variable `section'.
3796 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3797 (system_process_attributes): Remove unused variable `sess'.
3798 (sys_read): Remove unused variable `err'.
3800 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3801 (w32_wnd_proc): Remove unused variable `isdead'.
3802 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3803 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3804 (x_create_tip_frame): Remove unused variable `tem'.
3806 * w32inevt.c (w32_console_read_socket):
3807 Remove unused variable `no_events'.
3809 * w32term.c (x_draw_composite_glyph_string_foreground):
3810 Remove unused variable `width'.
3812 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3814 * w32term.c (x_set_glyph_string_clipping):
3815 Don't pass uninitialized region to CombineRgn.
3817 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3819 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3820 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3821 (Fx_close_connection): Remove unused variable `i'.
3823 * w32font.c (w32font_draw): Return number of glyphs.
3824 (w32font_open_internal): Remove unused variable `i'.
3825 (w32font_driver): Add missing initializer.
3827 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3828 (fill_in_menu): Remove unused variable `items_added'.
3830 * w32term.c (last_mouse_press_frame): Remove static global variable.
3831 (w32_clip_to_row): Remove unused variable `f'.
3832 (x_delete_terminal): Remove unused variable `i'.
3834 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3835 (NOTHING): Remove unused static global variable.
3836 (uniscribe_check_otf): Remove unused variable `table'.
3837 (uniscribe_font_driver): Add missing initializers.
3839 2011-03-23 Julien Danjou <julien@danjou.info>
3841 * term.c (Fsuspend_tty, Fresume_tty):
3842 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3843 * window.c (temp_output_buffer_show):
3844 * insdel.c (signal_before_change):
3845 * frame.c (Fhandle_switch_frame):
3846 * fileio.c (Fdo_auto_save):
3847 * emacs.c (Fkill_emacs):
3848 * editfns.c (save_excursion_restore):
3849 * cmds.c (internal_self_insert):
3850 * callint.c (Fcall_interactively):
3851 * buffer.c (Fkill_all_local_variables):
3852 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3854 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3855 unconditionnaly since it does the check itself.
3857 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3859 Fix more problems found by GCC 4.5.2's static checks.
3861 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3862 the first time through the loop, since we know p0 < p1 then.
3863 This also avoids a gcc -Wstrict-overflow warning.
3865 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3866 leading to a memory leak, possible in functions like
3867 load_charset_map_from_file that can allocate an unbounded number
3868 of objects (Bug#8318).
3870 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3871 that could (at least in theory) be that large.
3873 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3874 This is less likely to overflow, and avoids undefined behavior if
3875 overflow does occur. All callers changed. Use strtoul to scan
3876 for the unsigned long integer.
3877 (pint2hrstr): Simplify and tune code slightly.
3878 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3880 * scroll.c (do_scrolling): Work around GCC bug 48228.
3881 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3883 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3884 This also avoids a warning with gcc -Wstrict-overflow.
3885 (validate_x_resource_name): Simplify count usage.
3886 This also avoids a warning with gcc -Wstrict-overflow.
3888 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3891 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3893 * process.c (Fmake_network_process): Use socklen_t, not int,
3894 where POSIX says socklen_t is required in portable programs.
3895 This fixes a porting bug on hosts like 64-bit HP-UX, where
3896 socklen_t is wider than int (Bug#8277).
3897 (Fmake_network_process, server_accept_connection):
3898 (wait_reading_process_output, read_process_output):
3901 * process.c: Rename or move locals to avoid shadowing.
3902 (list_processes_1, Fmake_network_process):
3903 (read_process_output_error_handler, exec_sentinel_error_handler):
3904 Rename or move locals.
3905 (Fmake_network_process): Define label "retry_connect" only if needed.
3906 (Fnetwork_interface_info): Fix pointer signedness.
3907 (process_send_signal): Add cast to avoid pointer signedness problem.
3908 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3909 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3911 Make tparam.h and terminfo.c consistent.
3912 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3913 Include tparam.h instead, since it declares them.
3914 * cm.h (PC): Remove extern decl; tparam.h now does this.
3915 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3916 * terminfo.c: Include tparam.h, to check interfaces.
3917 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3918 (tparam): Adjust signature to match interface in tparam.h;
3919 this removes some undefined behavior. Check that outstring and len
3920 are zero, which they always are with Emacs.
3921 * tparam.h (PC, BC, UP): New extern decls.
3923 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3924 (xftfont_open): Rename locals to avoid shadowing.
3926 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3927 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3928 (OTF_TAG_SYM): Omit macro if not needed.
3929 (ftfont_list): Remove unused local.
3930 (get_adstyle_property, ftfont_pattern_entity):
3931 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3932 Rename locals to avoid shadowing.
3934 * xfont.c (xfont_list_family): Mark var as initialized.
3936 * xml.c (make_dom): Now static.
3938 * composite.c (composition_compute_stop_pos): Rename local to
3940 (composition_reseat_it): Remove unused locals.
3941 (find_automatic_composition, composition_adjust_point): Likewise.
3942 (composition_update_it): Mark var as initialized.
3943 (find_automatic_composition): Mark vars as initialized,
3944 with a FIXME (Bug#8290).
3946 character.h: Rename locals to avoid shadowing.
3947 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3948 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3949 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3950 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3953 * textprop.c (property_change_between_p): Remove; unused.
3955 * intervals.c (interval_start_pos): Now static.
3957 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3959 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3960 Rename locals to avoid shadowing.
3962 * sound.c (wav_play, au_play, Fplay_sound_internal):
3963 Fix pointer signedness.
3964 (alsa_choose_format): Remove unused local var.
3965 (wav_play): Initialize a variable to 0, to prevent undefined
3966 behavior (Bug#8278).
3968 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3970 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3972 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3973 clobbering (Bug#8298).
3974 * sysdep.c (sys_subshell): Likewise.
3975 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3977 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3978 This should get cleaned up, so that child_setup has the
3979 same signature on all platforms.
3981 * callproc.c (call_process_cleanup): Now static.
3982 (relocate_fd): Rename locals to avoid shadowing.
3984 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3986 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3987 not to be necessary, and produces flickering.
3989 2011-03-20 Glenn Morris <rgm@gnu.org>
3991 * config.in: Remove file.
3993 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3995 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3996 are now in src/globals.h.
3997 (syms_of_minibuf): Remove spurious & from previous change.
3999 2011-03-20 Leo <sdl.web@gmail.com>
4001 * minibuf.c (completing-read-function): New variable.
4002 (completing-read-default): Rename from completing-read.
4003 (completing-read): Call completing-read-function.
4005 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4007 * xfaces.c (Fx_load_color_file):
4008 Read color file from absolute filename (bug#8250).
4010 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4012 * makefile.w32-in: Update dependencies.
4014 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4016 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4018 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4020 Fix more problems found by GCC 4.5.2's static checks.
4022 * process.c (make_serial_process_unwind, send_process_trap):
4023 (sigchld_handler): Now static.
4025 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4026 That way, the code declares only the vars that it needs.
4027 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4028 * s/cygwin.h (PTY_ITERATION): Likewise.
4029 * s/darwin.h (PTY_ITERATION): Likewise.
4030 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4032 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4033 * process.c (allocate_pty): Don't declare stb unless it's needed.
4035 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4036 (CONSTANTLIM): Remove; unused.
4037 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4038 Define only if needed.
4040 * unexelf.c (unexec): Name an expression,
4041 to avoid gcc -Wbad-function-cast warning.
4042 Use a different way to cause a compilation error if anyone uses
4043 n rather than nn, a way that does not involve shadowing.
4044 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4046 * deps.mk (unexalpha.o): Remove; unused.
4048 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4049 * unexec.h: New file.
4050 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4051 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4053 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4054 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4055 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4056 Change as necessary to match prototype in unexec.h.
4058 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4060 (back_comment, skip_chars): Mark vars as initialized.
4062 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4063 Rename locals to avoid shadowing.
4065 * lread.c (read1): Rewrite so as not to use empty "else".
4066 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4068 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4070 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4071 warning when compiling print.c.
4073 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4074 instead of using an uninitialized var.
4075 (font_sort_entities): Mark var as initialized.
4077 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4079 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4080 pointers to constants.
4081 (font_parse_fcname): Remove unused vars.
4082 (font_delete_unmatched): Now static.
4083 (font_get_spec): Remove; unused.
4084 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4085 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4086 Rename or move locals to avoid shadowing.
4088 * fns.c (require_nesting_list, require_unwind): Now static.
4089 (Ffillarray): Rename locals to avoid shadowing.
4091 * floatfns.c (domain_error2): Define only if needed.
4092 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4094 * alloc.c (mark_backtrace): Move decl from here ...
4095 * lisp.h: ... to here, so that it can be checked.
4097 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4098 (Fdefvar): Rewrite so as not to use empty "else".
4099 (lisp_indirect_variable): Name an expression,
4100 to avoid gcc -Wbad-function-cast warning.
4101 (Fdefvar): Rename locals to avoid shadowing.
4103 * callint.c (quotify_arg, quotify_args): Now static.
4104 (Fcall_interactively): Rename locals to avoid shadowing.
4105 Use const pointer when appropriate.
4107 * lisp.h (get_system_name, get_operating_system_release):
4108 Move decls here, to check interfaces.
4109 * process.c (get_operating_system_release): Move decl to lisp.h.
4110 * xrdb.c (get_system_name): Likewise.
4111 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4112 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4113 some of which prompt warnings from gcc -Wbad-function-cast.
4114 (Fformat_time_string, Fencode_time, Finsert_char):
4115 (Ftranslate_region_internal, Fformat):
4116 Rename or remove local vars to avoid shadowing.
4117 (Ftranslate_region_internal): Mark var as initialized.
4119 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4122 * lisp.h (eassert): Check that the argument compiles, even if
4123 ENABLE_CHECKING is not defined.
4125 * data.c (Findirect_variable): Name an expression, to avoid
4126 gcc -Wbad-function-cast warning.
4127 (default_value, arithcompare, arith_driver, arith_error): Now static.
4128 (store_symval_forwarding): Rename local to avoid shadowing.
4129 (Fmake_variable_buffer_local, Fmake_local_variable):
4130 Mark variables as initialized.
4131 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4133 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4134 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4135 Rename locals to avoid shadowing.
4136 (mark_stack): Move local variables into the #ifdef region where
4138 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4139 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4141 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4142 (GC_STRING_CHARS): Remove; not used.
4143 (Fmemory_limit): Cast sbrk's returned value to char *.
4145 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4146 avoids undefined behavior in theory.
4148 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4150 Use functions, not macros, for up- and down-casing (Bug#8254).
4151 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4152 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4153 to use the following functions instead of these macros.
4154 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4155 EMACS_INT, since callers assume the returned value fits in int.
4156 (upcase1): Likewise, for UPCASE_TABLE.
4157 (uppercasep, lowercasep, upcase): New static inline functions.
4158 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4159 the race-condition problem in the old DOWNCASE.
4161 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4162 Rename locals to avoid shadowing.
4163 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4164 (regex_compile, re_search_2, re_match_2_internal):
4165 Remove unused local vars.
4166 (FREE_VAR): Rewrite so as not to use empty "else",
4167 which gcc can warn about.
4168 (regex_compile, re_match_2_internal): Mark locals as initialized.
4169 (RETALLOC_IF): Define only if needed.
4170 (WORDCHAR_P): Likewise. This one is never needed, but is used
4171 only in a comment talking about a compiler bug, so put inside
4172 the #if 0 of that comment.
4173 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4174 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4177 * search.c (boyer_moore): Rename locals to avoid shadowing.
4178 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4179 (PREV_CHAR_BOUNDARY): Likewise.
4181 * search.c (simple_search): Remove unused var.
4183 * dired.c (compile_pattern): Move decl from here ...
4184 * lisp.h: ... to here, so that it can be checked.
4185 (struct re_registers): New forward decl.
4187 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4189 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4191 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4192 Rename locals to avoid shadowing.
4193 (Fvertical_motion): Mark locals as initialized.
4195 * casefiddle.c (casify_object, casify_region): Now static.
4196 (casify_region): Mark local as initialized.
4198 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4200 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4201 New macros, so that the caller can use some names other than
4202 gcpro1, gcpro2, etc.
4203 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4205 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4206 argument, for consistency with GCPRO2_VAR, etc: it is now the
4207 prefix of the variable, not the variable itself. All uses
4209 * dired.c (directory_files_internal, file_name_completion):
4210 Rename locals to avoid shadowing.
4212 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4213 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4214 dired.c's scmp function, had undefined behavior.
4215 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4216 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4217 * buffer.h: ... to here, because these macros use current_buffer,
4218 and the new implementation with inline functions needs to have
4219 current_buffer in scope now, rather than later when the macros
4221 (downcase, upcase1): New static inline functions.
4222 (DOWNCASE, UPCASE1): Reimplement using these functions.
4223 This avoids undefined behavior in expressions like
4224 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4225 from race conditions in accessing the global variables
4226 case_temp1 and case_temp2.
4227 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4228 * lisp.h (case_temp1, case_temp2): Remove their decls.
4229 * character.h (ASCII_CHAR_P): Move from here ...
4230 * lisp.h: ... to here, so that the inline functions mentioned
4233 * dired.c (directory_files_internal_unwind): Now static.
4235 * fileio.c (file_name_as_directory, directory_file_name):
4236 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4238 (file_name_as_directory): Use const pointers when appropriate.
4239 (Fexpand_file_name): Likewise. In particular, newdir might
4240 point at constant storage, so make it a const pointer.
4241 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4242 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4244 (Fset_file_times, Finsert_file_contents, auto_save_error):
4245 Rename locals to avoid shadowing.
4247 * minibuf.c (choose_minibuf_frame_1): Now static.
4248 (Ftry_completion, Fall_completions): Rename or remove locals
4251 * marker.c (bytepos_to_charpos): Remove; unused.
4253 * lisp.h (verify_bytepos, count_markers): New decls,
4254 so that gcc does not warn that these functions aren't declared.
4256 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4257 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4258 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4259 (copy_text): Remove unused local var.
4261 * filelock.c (within_one_second): Now static.
4262 (lock_file_1): Rename local to avoid shadowing.
4264 * buffer.c (fix_overlays_before): Mark locals as initialized.
4265 (fix_start_end_in_overlays): Likewise. This function should be
4266 simplified by using pointers-to-pointers, but that's a different
4268 (switch_to_buffer_1): Now static.
4269 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4270 (report_overlay_modification): Rename locals to avoid shadowing.
4272 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4273 Fix pointer signedness issue.
4274 (sys_subshell): Mark local as volatile if checking for lint,
4275 to suppress a gcc -Wclobbered warning that does not seem to be right.
4276 (MAXPATHLEN): Define only if needed.
4278 * process.c (serial_open, serial_configure): Move decls from here ...
4279 * systty.h: ... to here, so that they can be checked.
4281 * fns.c (get_random, seed_random): Move extern decls from here ...
4282 * lisp.h: ... to here, so that they can be checked.
4284 * sysdep.c (reset_io): Now static.
4285 (wait_for_termination_signal): Remove; unused.
4287 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4288 (copy_keymap_item, append_key, push_text_char_description):
4290 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4291 (DENSE_TABLE_SIZE): Remove; unused.
4292 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4293 (describe_map_tree):
4294 Rename locals to avoid shadowing.
4296 * keyboard.c: Declare functions static if they are not used elsewhere.
4297 (echo_char, echo_dash, cmd_error, top_level_2):
4298 (poll_for_input, handle_async_input): Now static.
4299 (read_char, kbd_buffer_get_event, make_lispy_position):
4300 (make_lispy_event, make_lispy_movement, apply_modifiers):
4301 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4302 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4303 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4304 (read_key_sequence, read_char): Mark locals as initialized.
4305 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4307 * keyboard.h (make_ctrl_char): New decl.
4308 (mark_kboards): Move decl here ...
4309 * alloc.c (mark_kboards): ... from here.
4311 * lisp.h (force_auto_save_soon): New decl.
4313 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4314 (DEFINE_DUMMY_FUNCTION): New macro.
4315 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4317 (main): Add casts to avoid warnings
4318 if GCC considers string literals to be constants.
4320 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4322 * dbusbind.c: Pointer signedness fixes.
4323 (xd_signature, xd_append_arg, xd_initialize):
4324 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4325 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4326 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4327 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4329 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4330 if GCC considers string literals to be constants.
4331 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4333 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4335 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4336 (print_preprocess, print_object): New macro to fix last change.
4338 * print.c (print_preprocess): Don't forget font objects.
4340 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4342 * emacs.c (USAGE3): Doc fixes.
4344 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4346 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4349 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4351 * lisp.h (VWindow_system, Qfile_name_history):
4352 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4353 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4354 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4356 * w32select.c: Don't #include "keyboard.h".
4357 (run_protected): Add extern declaration for waiting_for_input.
4359 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4360 * w32console.c (detect_input_pending, read_input_pending)
4361 (encode_terminal_code):
4362 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4363 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4364 (w32_system_caret_y, Qfile_name_history):
4365 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4366 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4367 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4368 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4369 * w32proc.c (Qlocal, report_file_error):
4370 * w32term.c (Vwindow_system, updating_frame):
4371 * w32uniscribe.c (initialized, uniscribe_font_driver):
4372 Remove unneeded extern declarations.
4374 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4376 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4378 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4380 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4381 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4382 These macros can no longer be used for assignment.
4384 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4385 Assign struct members directly, instead of using BUF_BEGV etc.
4386 (record_buffer_markers, fetch_buffer_markers): New functions for
4387 recording and fetching special buffer markers.
4388 (set_buffer_internal_1, set_buffer_temp): Use them.
4390 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4392 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4394 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4395 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4397 * xdisp.c (hscroll_window_tree):
4398 (reconsider_clip_changes): Use PT instead of BUF_PT.
4400 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4402 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4403 $(EMACS_ROOT)/lib/intprops.h.
4405 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4407 Fix more problems found by GCC 4.5.2's static checks.
4409 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4410 to unsigned char * to avoid compiler diagnostic.
4411 (xg_free_frame_widgets): Make it clear that a local variable is
4412 needed only if USE_GTK_TOOLTIP.
4413 (gdk_window_get_screen): Make it clear that this macro is needed
4414 only if USE_GTK_TOOLTIP.
4415 (int_gtk_range_get_value): New function, which avoids a diagnostic
4416 from gcc -Wbad-function-cast.
4417 (xg_set_toolkit_scroll_bar_thumb): Use it.
4418 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4419 diagnostic from gcc -Wbad-function-cast.
4420 (get_utf8_string, xg_get_file_with_chooser):
4421 Rename locals to avoid shadowing.
4422 (create_dialog): Move locals to avoid shadowing.
4424 * xgselect.c (xg_select): Remove unused var.
4426 * image.c (four_corners_best): Mark locals as initialized.
4427 (gif_load): Initialize transparent_p to zero (Bug#8238).
4428 Mark another local as initialized.
4429 (my_png_error, my_error_exit): Mark with NO_RETURN.
4431 * image.c (clear_image_cache): Now static.
4432 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4433 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4434 (x_edge_detection): Remove unnecessary cast that
4435 gcc -Wbad-function-cast diagnoses.
4436 (gif_load): Fix pointer signedness.
4437 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4438 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4440 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4442 Improve quality of tests for time stamp overflow.
4443 For example, without this patch (encode-time 0 0 0 1 1
4444 1152921504606846976) returns the obviously-bogus value (-948597
4445 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4446 reports time overflow. See
4447 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4448 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4449 * editfns.c: Include limits.h and intprops.h.
4450 (TIME_T_MIN, TIME_T_MAX): New macros.
4451 (time_overflow): Move earlier, to before first use.
4452 (hi_time, lo_time): New functions, for an accurate test for
4454 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4455 (Fget_internal_run_time): Don't assume time_t fits in int.
4456 (make_time): Use list2 instead of Fcons twice.
4457 (Fdecode_time): More accurate test for out-of-range times.
4458 (check_tm_member): New function.
4459 (Fencode_time): Use it, to test for out-of-range times.
4460 (lisp_time_argument): Don't rely on undefined left-shift and
4461 right-shift behavior when checking for time stamp overflow.
4463 * editfns.c (time_overflow): New function, refactoring common code.
4464 (Fformat_time_string, Fdecode_time, Fencode_time):
4465 (Fcurrent_time_string): Use it.
4467 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4468 * dired.c (make_time): Move to ...
4469 * editfns.c (make_time): ... here.
4470 * systime.h: Note the move.
4472 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4474 * fringe.c (update_window_fringes): Remove unused variables.
4476 * unexmacosx.c (copy_data_segment): Also copy __got section.
4479 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4481 * termcap.c [MSDOS]: Include "msdos.h".
4482 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4483 Constify `char *' arguments and their references according to
4484 prototypes in tparam.h.
4486 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4488 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4489 Adapt all references accordingly.
4491 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4493 2011-03-11 Tom Tromey <tromey@redhat.com>
4495 * buffer.c (syms_of_buffer): Remove obsolete comment.
4497 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4499 * termhooks.h (encode_terminal_code): Declare prototype.
4501 * msdos.c (encode_terminal_code): Don't declare prototype.
4503 * term.c (encode_terminal_code): Now external again, used by
4504 w32console.c and msdos.c.
4506 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4507 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4509 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4511 Fix some minor problems found by GCC 4.5.2's static checks.
4513 * fringe.c (update_window_fringes): Mark locals as initialized
4515 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4517 * alloc.c (mark_fringe_data): Move decl from here ...
4518 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4519 to check its interface.
4520 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4522 * fontset.c (free_realized_fontset): Now static.
4523 (Fset_fontset_font): Rename local to avoid shadowing.
4524 (fontset_font): Mark local as initialized.
4525 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4527 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4529 * xselect.c (x_disown_buffer_selections): Remove; not used.
4530 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4531 (x_own_selection, Fx_disown_selection_internal): Rename locals
4533 (x_handle_dnd_message): Remove local to avoid shadowing.
4535 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4536 so that the caller can use some name other than gcpro1.
4537 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4538 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4539 (Fx_backspace_delete_keys_p):
4540 Use them to avoid shadowing, and rename vars to avoid shadowing.
4541 (x_decode_color, x_set_name, x_window): Now static.
4542 (Fx_create_frame): Add braces to silence GCC warning.
4543 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4544 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4545 Remove unused locals.
4546 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4547 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4548 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4551 * xterm.h (x_mouse_leave): New decl.
4553 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4554 Remove unused functions.
4555 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4556 (x_calc_absolute_position): Now static.
4557 (XTread_socket): Don't define label "out" unless it's used.
4558 Don't declare local "event" unless it's used.
4559 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4560 unless they are used.
4561 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4562 (x_fatal_error_signal): Remove; not used.
4563 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4564 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4565 (x_error_catcher, x_connection_closed, x_error_handler):
4566 (x_error_quitter, xembed_send_message, x_iconify_frame):
4567 (my_log_handler): Rename locals to avoid shadowing.
4568 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4569 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4571 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4572 Rename or move locals to avoid shadowing.
4573 (tty_defined_color, merge_face_heights): Now static.
4574 (free_realized_faces_for_fontset): Remove; not used.
4575 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4576 does not deduce is never used uninitialized.
4577 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4578 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4580 * terminal.c (store_terminal_param): Now static.
4582 * xmenu.c (menu_highlight_callback): Now static.
4583 (set_frame_menubar): Remove unused local.
4584 (xmenu_show): Rename parameter to avoid shadowing.
4585 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4586 since they might point to immutable storage.
4587 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4588 since it's unused otherwise.
4590 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4591 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4592 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4593 avoids a gcc -Wuninitialized diagnostic.
4594 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4595 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4596 does not deduce are never used uninitialized.
4598 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4600 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4601 * window.c (window_loop, size_window):
4602 (run_window_configuration_change_hook, enlarge_window): Likewise.
4604 * window.c (display_buffer): Now static.
4605 (size_window): Mark variables that gcc -Wuninitialized
4606 does not deduce are never used uninitialized.
4607 * window.h (check_all_windows): New decl, to forestall
4608 gcc -Wmissing-prototypes diagnostic.
4609 * dispextern.h (bidi_dump_cached_states): Likewise.
4611 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4613 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4615 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4616 and to avoid gcc -Wuninitialized warning.
4617 (load_charset_map): Mark variables that gcc -Wuninitialized
4618 does not deduce are never used uninitialized.
4619 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4621 * coding.c (coding_set_source, coding_set_destination):
4622 Use "else { /* comment */ }" rather than "else /* comment */;"
4623 for clarity, and to avoid gcc -Wempty-body warning.
4624 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4625 a block, when the outer 'i' will do.
4626 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4627 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4628 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4629 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4630 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4631 Rename locals to avoid shadowing.
4632 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4633 * coding.c (emacs_mule_char, encode_invocation_designation):
4634 Now static, since they're not used elsewhere.
4635 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4636 (decode_coding_object, encode_coding_object, detect_coding_system):
4637 (decode_coding_emacs_mule): Mark variables that gcc
4638 -Wuninitialized does not deduce are never used uninitialized.
4639 (detect_coding_iso_2022): Initialize a local variable that might
4640 be used uninitialized. Leave a FIXME because it's not clear that
4641 this initialization is needed. (Bug#8211)
4642 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4643 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4644 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4645 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4646 Remove unused macros.
4648 * category.c (hash_get_category_set): Remove unused local var.
4649 (copy_category_table): Now static, since it's not used elsewhere.
4650 * character.c (string_count_byte8): Likewise.
4652 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4653 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4655 * chartab.c (copy_sub_char_table): Now static, since it's not used
4657 (sub_char_table_ref_and_range, char_table_ref_and_range):
4658 Rename locals to avoid shadowing.
4659 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4661 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4662 (BIDI_BOB): Remove unused macro.
4664 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4665 deduce are never used uninitialized.
4666 * term.c (encode_terminal_code): Likewise.
4668 * term.c (encode_terminal_code): Now static. Remove unused local.
4670 * tparam.h: New file.
4671 * term.c, tparam.h: Include it.
4672 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4673 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4674 Move these decls to tparam.h, and make them agree with what
4675 is actually in tparam.c. The previous trick of using incompatible
4676 decls in different modules does not conform to the C standard.
4677 All callers of tparam changed to use tparam's actual API.
4678 * tparam.c (tparam1, tparam, tgoto):
4679 Use const pointers where appropriate.
4681 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4682 * cm.h (struct cm): Likewise.
4683 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4684 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4685 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4686 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4687 (turn_on_face, init_tty): Likewise.
4688 * termchar.h (struct tty_display_info): Likewise.
4690 * term.c (term_mouse_position): Rename local to avoid shadowing.
4692 * alloc.c (mark_ttys): Move decl from here ...
4693 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4695 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4697 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4699 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4701 * search.c (compile_pattern_1): Remove argument regp, unused since
4702 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4703 (compile_pattern): Don't pass it.
4705 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4707 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4708 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4710 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4712 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4714 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4715 gdk_window_get_screen, gdk_window_get_geometry,
4716 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4717 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4718 (xg_get_pixbuf_from_pixmap): New function.
4719 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4720 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4721 Call xg_get_pixbuf_from_pixmap instead of
4722 gdk_pixbuf_get_from_drawable.
4723 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4724 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4725 (xg_check_special_colors): Use GtkStyleContext and its functions
4727 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4728 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4729 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4730 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4731 Call gtk_widget_get_preferred_size.
4732 (xg_frame_resized): gdk_window_get_geometry only takes 5
4734 (xg_win_to_widget, xg_event_is_for_menubar):
4735 Call gdk_x11_window_lookup_for_display.
4736 (xg_set_widget_bg): New function.
4737 (delete_cb): New function.
4738 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4739 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4740 (xg_set_background_color): Call xg_set_widget_bg.
4741 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4742 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4743 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4744 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4746 (update_frame_tool_bar): Call gtk_widget_hide.
4747 (xg_initialize): Use GDK_KEY_g.
4749 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4751 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4753 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4754 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4755 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4757 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4759 * w32xfns.c (select_palette): Check success of RealizePalette against
4760 GDI_ERROR, not zero.
4762 See ChangeLog.11 for earlier changes.
4768 Copyright (C) 2011 Free Software Foundation, Inc.
4770 This file is part of GNU Emacs.
4772 GNU Emacs is free software: you can redistribute it and/or modify
4773 it under the terms of the GNU General Public License as published by
4774 the Free Software Foundation, either version 3 of the License, or
4775 (at your option) any later version.
4777 GNU Emacs is distributed in the hope that it will be useful,
4778 but WITHOUT ANY WARRANTY; without even the implied warranty of
4779 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4780 GNU General Public License for more details.
4782 You should have received a copy of the GNU General Public License
4783 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.