Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
1 2011-09-03 Paul Eggert <eggert@cs.ucla.edu>
2
3 * fileio.c: Fix bugs with large file offsets.
4 The previous code assumed that file offsets (off_t values) fit in
5 EMACS_INT variables, which is not true on typical 32-bit hosts.
6 The code messed up by falsely reporting buffer overflow in cases
7 such as (insert-file-contents "big" nil 1 2) into an empty buffer
8 when "big" contains more than 2**29 bytes, even though this
9 inserts just one byte and does not overflow the buffer.
10 (Finsert_file_contents): Store file offsets as off_t
11 values, not as EMACS_INT values. Check for overflow when
12 converting between EMACS_INT and off_t. When checking for
13 buffer overflow or for overlap, take the offsets into account.
14 Don't use EMACS_INT for small values where int suffices.
15 When checking for overlap, fix a typo: ZV was used where
16 ZV_BYTE was intended.
17 (Fwrite_region): Don't assume off_t fits into 'long'.
18 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
19
20 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
21
22 * syntax.c (find_defun_start): Update all cache variables if
23 exiting early (Bug#9401).
24
25 2011-08-30 Eli Zaretskii <eliz@gnu.org>
26
27 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
28
29 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
30 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
31 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
32
33 * term.c (tty_append_glyph): New function.
34 (produce_stretch_glyph): Static function and its prototype deleted.
35
36 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
37 prototypes.
38
39 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
40
41 * image.c (parse_image_spec): Check for nonnegative, not for positive,
42 when checking :margin (Bug#9390).
43 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
44 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
45 so that the name doesn't mislead. All uses changed.
46
47 2011-08-28 Johan Bockgård <bojohan@gnu.org>
48
49 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
50 set_tty_hooks.
51
52 2011-08-27 Eli Zaretskii <eliz@gnu.org>
53
54 * xdisp.c (move_it_to): Don't bail out early when reaching
55 position beyond to_charpos, if we are scanning backwards.
56 (move_it_vertically_backward): When DY == 0, make sure we get to
57 the first character in the line after the newline.
58
59 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
60
61 * ccl.c: Improve and simplify overflow checking (Bug#9196).
62 (ccl_driver): Do not generate an out-of-range pointer.
63 (Fccl_execute_on_string): Remove unnecessary check for
64 integer overflow, noted by Stefan Monnier in
65 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
66 Remove a FIXME that didn't need fixing.
67 Simplify the newly-introduced buffer reallocation code.
68
69 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
70
71 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
72
73 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
74
75 Integer and memory overflow issues (Bug#9196).
76
77 * doc.c (get_doc_string): Rework so that
78 get_doc_string_buffer_size is the actual buffer size, rather than
79 being 1 less than the actual buffer size; this makes xpalloc more
80 convenient.
81
82 * image.c (x_allocate_bitmap_record, cache_image):
83 * xselect.c (Fx_register_dnd_atom):
84 Simplify previous changes by using xpalloc.
85
86 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
87 since either will do and ptrdiff_t is convenient with xpalloc.
88
89 * charset.c (charset_table_size)
90 (struct charset_sort_data.priority): Now ptrdiff_t.
91 (charset_compare): Don't overflow if priorities differ greatly.
92 (Fsort_charsets): Don't assume list length fits in int.
93 Check for size-calculation overflow when allocating sort data.
94 (syms_of_charset): Allocate an initial charset table that is
95 just under 64 KiB, to avoid problems with glibc malloc and mmap.
96
97 * cmds.c (internal_self_insert): Check for size-calculation overflow.
98
99 * composite.h (struct composition.glyph_len): Now int, not unsigned.
100 The actual value is always <= INT_MAX, and leaving it unsigned made
101 overflow checking harder.
102
103 * dispextern.h (struct glyph_matrix.rows_allocated)
104 (struct face_cache.size): Now ptrdiff_t, for convenience in use
105 with xpalloc. The values are still always <= INT_MAX.
106
107 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
108
109 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
110 (SAFE_NALLOCA): New macro.
111
112 * region-cache.c (struct boundary.pos, find_cache_boundary)
113 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
114 (set_cache_region, invalidate_region_cache)
115 (revalidate_region_cache, know_region_cache, region_cache_forward)
116 (region_cache_backward, pp_cache):
117 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
118 so that ptrdiff_t * can be passed to xpalloc.
119 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
120 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
121 (pp_cache): Don't assume cache_len fits in int.
122 * region-cache.h: Adjust extern decls to match.
123
124 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
125 EMACS_INT, since either will do, for xpalloc.
126
127 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
128 (xnmalloc, xnrealloc, xpalloc): New functions.
129
130 * bidi.c (bidi_shelve_header_size): New constant.
131 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
132 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
133
134 * bidi.c (bidi_cache_shrink):
135 * buffer.c (overlays_at, overlays_in, record_overlay_string)
136 (overlay_strings):
137 Don't update size of array until after memory allocation succeeds,
138 because xmalloc/xrealloc may not return.
139 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
140 now that we have proper integer overflow checking.
141 (record_overlay_string, overlay_strings): Catch overflows when
142 calculating size of overlay_str_buf.
143
144 * callproc.c (Fcall_process): Check for size overflow when
145 calculating size of args2.
146 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
147 Normally we prefer signed values, but sticking with ptrdiff_t would
148 require adding more-complicated checks.
149
150 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
151 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
152 Redo buffer-overflow calculations to avoid integer overflow.
153 Add a FIXME comment where memory seems to be over-allocated.
154
155 * character.c (Fstring): Check for size-calculation overflow.
156
157 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
158 unnecessary integer overflow. Check for size overflow.
159 (encode_coding_object): Don't update size until xmalloc succeeds.
160
161 * composite.c (get_composition_id): Check for overflow in glyph
162 length calculations.
163
164 Integer and memory overflow fixes for display code.
165 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
166 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
167 (scrolling_window): Check for overflow in size calculations.
168 (line_draw_cost, realloc_glyph_pool, add_row_entry):
169 Don't assume glyph table len fits in int.
170 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
171 (row_table_size): Now ptrdiff_t, not int.
172 (scrolling_window): Avoid overflow in size calculations.
173 Don't update size until allocation succeeds.
174 * fns.c (concat): Check for overflow in size calculations.
175 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
176 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
177 (NEXT_ALMOST_PRIME_LIMIT): New constant.
178
179 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
180 (get_doc_string): Check for size calculation overflow.
181 Don't update size until allocation succeeds.
182 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
183 EMACS_INT, where ptrdiff_t will do.
184 (Fsubstitute_command_keys): Check for string overflow.
185
186 * editfns.c (set_time_zone_rule): Don't assume environment length
187 fits in int.
188 (message_length): Now ptrdiff_t, not int.
189 (Fmessage_box): Don't update size until allocation succeeds.
190 Don't assume message length fits in int.
191 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
192
193 * emacs.c (main): Do not reallocate argv, since there is a null at
194 the end that can be overwritten, and this way there's no need to
195 worry about size-calculation overflow.
196 (sort_args): Check for size-calculation overflow.
197
198 * eval.c (init_eval_once, grow_specpdl): Don't update size until
199 alloc succeeds.
200 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
201
202 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
203 (x_set_scroll_bar_width, x_figure_window_size):
204 Check for integer overflow.
205 (x_set_alpha): Do not assume XINT fits in int.
206
207 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
208 This is for the members text_lines, text_cols, total_lines, total_cols,
209 where the system imposes an 'int' limit.
210
211 * fringe.c (Fdefine_fringe_bitmap):
212 Don't update size until alloc works.
213
214 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
215 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
216
217 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
218 Check for size-calculation overflow.
219 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
220 do, as we prefer signed integers.
221 (id_to_widget.max_size, id_to_widget.used)
222 (xg_store_widget_in_map, xg_remove_widget_from_map)
223 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
224 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
225 Use and return ptrdiff_t, not int.
226 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
227 * gtkutil.h: Change prototypes to match the above.
228
229 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
230 are duplicate now that they've been promoted to lisp.h.
231 (x_allocate_bitmap_record, x_alloc_image_color)
232 (make_image_cache, cache_image, xpm_load):
233 Don't update size until alloc is done.
234 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
235 (x_detect_edges):
236 Check for size calculation overflow.
237 (ct_colors_allocated_max): New constant.
238 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
239 overflow.
240
241 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
242 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
243 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
244 Use ptrdiff_t, not int, to count maps.
245 (read_char_minibuf_menu_prompt): Check for overflow in size
246 calculations. Don't update size until allocation succeeds. Redo
247 calculations to avoid overflow.
248 * keyboard.h: Change prototypes to match the above.
249
250 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
251 to count maps.
252 (current_minor_maps): Check for size calculation overflow.
253 * keymap.h: Change prototypes to match the above.
254
255 * lread.c (read1, init_obarray): Don't update size until alloc done.
256
257 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
258 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
259
260 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
261 Now ptrdiff_t, not int.
262 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
263 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
264
265 * process.c (Fnetwork_interface_list): Check for overflow
266 in size calculation.
267
268 * region-cache.c (move_cache_gap): Check for size calculation overflow.
269
270 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
271 overflow. Don't bother calling xmalloc when xrealloc will do.
272
273 * search.c (Freplace_match): Check for size calculation overflow.
274 (Fset_match_data): Don't assume list lengths fit in 'int'.
275
276 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
277 for command line length. Do not attempt to address one before the
278 beginning of an array, as that's not portable.
279
280 * term.c (max_frame_lines): Remove; unused.
281 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
282 not int.
283 (encode_terminal_code, calculate_costs): Check for size
284 calculation overflow.
285 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
286 table lengths and related sizes. Don't update size until alloc
287 done. Redo calculations to avoid overflow.
288 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
289
290 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
291 subtracting pointers.
292 (gobble_line): Check for overflow more carefully. Don't update size
293 until alloc done.
294
295 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
296 Don't update size until alloc done.
297 Redo size calculations to avoid overflow.
298 Check for size calculation overflow.
299 (main) [DEBUG]: Fix typo in invoking tparam1.
300
301 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
302 Use ptrdiff_t, not int, for sizes.
303 (store_mode_line_noprop_char): Don't update size until alloc done.
304
305 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
306 Use ptrdiff_t, not int, for sizes.
307 (Finternal_make_lisp_face, cache_face):
308 Check for size calculation overflow.
309 (cache_face): Treat size calculation overflows as if they were
310 memory exhaustion (the usual treatment), rather than aborting.
311
312 * xfns.c (x_encode_text, x_set_name_internal)
313 (Fx_change_window_property): Use ptrdiff_t, not int, to count
314 sizes, since they can exceed INT_MAX in size. Check for size
315 calculation overflow.
316
317 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
318 (xg_select): Check for size calculation overflow.
319 Don't update size until alloc done.
320
321 * xrdb.c (get_environ_db): Don't assume path length fits in int,
322 as sprintf is limited to int lengths.
323
324 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
325 (X_LONG_MIN): New macros.
326 Use them to make the following changes clearer.
327 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
328 This change doesn't affect the value now, but it may help remind
329 future maintainers not to raise the value too much later.
330 (SELECTION_QUANTUM): Remove, replacing with ...
331 (selection_quantum): ... new function, which avoids overflow.
332 All uses changed.
333 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
334 assumption that selection length fits in 'int'.
335 (x_reply_selection_request, x_handle_selection_request)
336 (x_get_window_property, receive_incremental_selection)
337 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
338 (lisp_data_to_selection_data, clean_local_selection_data):
339 Use ptrdiff_t, not int, to record length of selection.
340 (x_reply_selection_request, x_get_window_property)
341 (receive_incremental_selection, x_property_data_to_lisp):
342 Redo calculations to avoid overflow.
343 (x_reply_selection_request): When sending hint, ceiling it at
344 X_LONG_MAX rather than relying on wraparound overflow to send
345 something.
346 (x_get_window_property, receive_incremental_selection)
347 (lisp_data_to_selection_data, x_property_data_to_lisp):
348 Check for size-calculation overflow.
349 (x_get_window_property, receive_incremental_selection)
350 (lisp_data_to_selection_data, Fx_register_dnd_atom):
351 Don't store size until memory allocation succeeds.
352 (x_get_window_property): Plug memory leak on memory exhaustion.
353 Don't double-block input; malloc is safe here. Don't assume 2**34
354 - 4 fits in unsigned long. Add an xassert to check
355 XGetWindowProperty overflow. Be more careful about overflow
356 calculations, and distinguish size from memory overflow better.
357 (receive_incremental_selection): When tracing, don't assume
358 unsigned int is less than INT_MAX.
359 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
360 harmful) conversions of unsigned short to int.
361 (lisp_data_to_selection_data): Don't assume that integers
362 in the range -65535 through -1 fit in an X unsigned short.
363 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
364 result parameters unless successful. Rely on cons_to_unsigned
365 to report problems with elements; the old code wasn't right anyway.
366 (x_check_property_data): Check for int overflow; we cannot use
367 a wider type due to X limits.
368 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
369
370 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
371
372 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
373 (x_term_init): Check for size calculation overflow.
374 (x_color_cells): Don't store size until memory allocation succeeds.
375 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
376 Don't assume alloca size is less than MAX_ALLOCA.
377 (x_term_init): Don't assume length fits in int (sprintf is limited
378 to int size).
379
380 Use ptrdiff_t for composition IDs.
381 * character.c (lisp_string_width):
382 * composite.c (composition_table_size, n_compositions)
383 (get_composition_id, composition_gstring_from_id):
384 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
385 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
386 * window.c (Frecenter):
387 Use ptrdiff_t, not int, for composition IDs.
388 * composite.c (get_composition_id): Check for integer overflow.
389 * composite.h: Adjust prototypes to match the above changes.
390
391 Use ptrdiff_t for hash table indexes.
392 * category.c (hash_get_category_set):
393 * ccl.c (ccl_driver):
394 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
395 * coding.c (coding_system_charset_list, detect_coding_system):
396 * coding.h (struct coding_system.id):
397 * composite.c (get_composition_id, gstring_lookup_cache):
398 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
399 * image.c (xpm_get_color_table_h):
400 * lisp.h (hash_lookup, hash_put):
401 * minibuf.c (Ftest_completion):
402 Use ptrdiff_t for hash table indexes, not int (which is too
403 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
404 32-bit --with-wide-int hosts).
405
406 * charset.c (Fdefine_charset_internal): Check for integer overflow.
407 Add a FIXME comment about memory leaks.
408 (syms_of_charset): Don't assume xmalloc returns.
409
410 Don't assume that stated character widths fit in int.
411 * character.c (Fchar_width, c_string_width, lisp_string_width):
412 * character.h (CHAR_WIDTH):
413 * indent.c (MULTIBYTE_BYTES_WIDTH):
414 Use sanitize_char_width to avoid undefined and/or bad behavior
415 with outlandish widths.
416 * character.h (sanitize_tab_width): Renamed from sanitize_width,
417 now that we have two such functions. All uses changed.
418 (sanitize_char_width): New inline function.
419
420 Don't assume that tab-width fits in int.
421 * character.h (sanitize_width): New inline function.
422 (SANE_TAB_WIDTH): New macro.
423 (ASCII_CHAR_WIDTH): Use it.
424 * indent.c (sane_tab_width): Remove. All uses replaced by
425 SANE_TAB_WIDTH (current_buffer).
426 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
427
428 * fileio.c: Integer overflow issues with file modes.
429 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
430
431 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
432 Remove unreachable code.
433 (read_hex, load_charset_map_from_file): Check for integer overflow.
434
435 * xterm.c: don't go over XClientMessageEvent limit
436 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
437 (x_send_scroll_bar_event): Likewise. Check that the size does not
438 exceed limits imposed by XClientMessageEvent, as well as the usual
439 ptrdiff_t and size_t limits.
440
441 * keyboard.c: Overflow, signedness and related fixes.
442 (make_lispy_movement): Use same integer type in forward decl
443 that is used in the definition.
444 (read_key_sequence, keyremap_step):
445 Change bufsize argument back to int, undoing my 2011-03-30 change.
446 We prefer signed types, and int is wide enough here.
447 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
448 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
449 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
450 length, not size_t. Use ptrdiff_t for index, not int.
451 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
452 possibility of integer overflow.
453
454 Overflow, signedness and related fixes for images.
455
456 * dispextern.h (struct it.stack[0].u.image.image_id)
457 (struct_it.image_id, struct image.id, struct image_cache.size)
458 (struct image_cache.used, struct image_cache.ref_count):
459 * gtkutil.c (update_frame_tool_bar):
460 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
461 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
462 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
463 * nsmenu.m (update_frame_tool_bar):
464 * xdisp.c (calc_pixel_width_or_height):
465 * xfns.c (image_cache_refcount):
466 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
467 on typical 64-bit hosts.
468
469 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
470 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
471 Omit unnecessary casts to int.
472 (parse_image_spec): Check that integers fall into 'int' range
473 when the callers expect that.
474 (image_ascent): Redo ascent calculation to avoid int overflow.
475 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
476 (lookup_image): Remove unnecessary tests.
477 (xbm_image_p): Locals are now of int, not EMACS_INT,
478 since parse_image_check makes sure they fit into int.
479 (png_load, gif_load, svg_load_image):
480 Prefer int to unsigned where either will do.
481 (tiff_handler): New function, combining the cores of the
482 old tiff_error_handler and tiff_warning_handler. This
483 function is rewritten to use vsnprintf and thereby avoid
484 stack buffer overflows. It uses only the features of vsnprintf
485 that are common to both POSIX and native Microsoft.
486 (tiff_error_handler, tiff_warning_handler): Use it.
487 (tiff_load, gif_load, imagemagick_load_image):
488 Don't assume :index value fits in 'int'.
489 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
490 (imagemagick_load_image): Check that crop parameters fit into
491 the integer types that MagickCropImage accepts. Don't assume
492 Vimagemagick_render_type has a nonnegative value. Don't assume
493 size_t fits in 'long'.
494 (gs_load): Use printmax_t to print the widest integers possible.
495 Check for integer overflow when computing image height and width.
496
497 2011-08-26 Eli Zaretskii <eliz@gnu.org>
498
499 * xdisp.c (redisplay_window): Don't force window start if point
500 will be invisible in the resulting window. (Bug#9324)
501
502 2011-08-25 Eli Zaretskii <eliz@gnu.org>
503
504 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
505 the display spec is of the form `(space ...)'.
506 (handle_display_spec): Return the value returned by
507 handle_single_display_spec, not just 1 or zero.
508 (handle_single_display_spec): If the display spec is of the form
509 `(space ...)', and specifies display in the text area, return 2
510 rather than 1.
511 (try_cursor_movement): Check for the need to scroll more
512 accurately, and prefer exact match for point under bidi. Don't
513 advance `row' beyond the last row of the window.
514
515 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
516 into disp_prop; all users changed.
517
518 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
519 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
520 for the text covered by the display property.
521
522 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
523
524 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
525 Change return value to nil.
526 (Frecord_buffer): Delete unused function.
527
528 2011-08-24 Eli Zaretskii <eliz@gnu.org>
529
530 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
531 buffers, return left-to-right.
532 (set_cursor_from_row): Consider candidate row a win if its glyph
533 represents a newline and point is on that newline. Fixes cursor
534 positioning on the newline at EOL of R2L text within L2R
535 paragraph, and vice versa.
536 (try_cursor_movement): Check continued rows, in addition to
537 continuation rows. Fixes unwarranted scroll when point enters a
538 continued line of R2L text within an L2R paragraph, or vice versa.
539 (cursor_row_p): Consider the case of point being equal to
540 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
541 from the end of a short line to the beginning of a continued line
542 of R2L text within L2R paragraph.
543 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
544 composed characters.
545
546 * bidi.c (bidi_check_type): Use xassert.
547 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
548 members.
549
550 2011-08-23 Eli Zaretskii <eliz@gnu.org>
551
552 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
553 a character.
554
555 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
556
557 * nsfont.m (ns_otf_to_script): Fix typo.
558
559 2011-08-22 Kenichi Handa <handa@m17n.org>
560
561 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
562 extra slot even if the purpose is char-code-property-table.
563
564 2011-08-23 Eli Zaretskii <eliz@gnu.org>
565
566 * xdisp.c (redisplay_window): When computing centering_position,
567 account for the height of the header line. (Bug#8874)
568
569 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
570 instead of CHAR_TO_BYTE. Fixes a crash when a completion
571 candidate is selected by the mouse, and that candidate has a
572 composed character under the mouse.
573
574 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
575 coordinates reported by pos-visible-in-window-p for a composed
576 character in column zero.
577
578 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
579
580 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
581
582 2011-08-22 Eli Zaretskii <eliz@gnu.org>
583
584 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
585 consider it a hit if to_charpos is anywhere in the range of the
586 composed buffer positions.
587
588 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
589
590 * image.c (gif_load): Don't assume that each subimage has the same
591 dimensions as the base image. Handle disposal method that is
592 "undefined" by the gif spec (Bug#9335).
593
594 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
595
596 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
597 (Fcondition_case): Document `debug' symbol in error handler.
598
599 2011-08-19 Eli Zaretskii <eliz@gnu.org>
600
601 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
602 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
603 from an Org mode buffer to a Speedbar frame.
604
605 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
606 a composition, take its buffer position from IT->cmp_it.charpos.
607 Fixes cursor positioning at the beginning of a line that begins
608 with a composed character.
609
610 2011-08-18 Eli Zaretskii <eliz@gnu.org>
611
612 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
613 character bidirectional type, use STRONG_L instead. Fixes crashes
614 in a buffer produced by `describe-categories'.
615
616 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
617 members before the level stack, so they would be saved and
618 restored when copying iterator state. Fixes incorrect reordering
619 around TABs covered by display properties.
620
621 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
622
623 * process.c (Fnetwork_interface_list): Correctly determine buffer
624 size.
625
626 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
627
628 * eval.c (internal_condition_case, internal_condition_case_1)
629 (internal_condition_case_2, internal_condition_case_n):
630 Remove unnecessary aborts (Bug#9081).
631
632 2011-08-17 Eli Zaretskii <eliz@gnu.org>
633
634 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
635 has no `load' handler, try opening the file locally. (Bug#9311)
636
637 2011-08-16 Ken Brown <kbrown@cornell.edu>
638
639 * gmalloc.c: Expand comment.
640
641 2011-08-16 Eli Zaretskii <eliz@gnu.org>
642
643 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
644 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
645
646 2011-08-16 Ken Brown <kbrown@cornell.edu>
647
648 Fix memory allocation problems in Cygwin build (Bug#9273).
649
650 * unexcw.c ( __malloc_initialized): Declare external variable.
651 (fixup_executable): Force the dumped emacs to reinitialize malloc.
652
653 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
654 New variables.
655 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
656 dumped emacs.
657 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
658 in the static heap.
659 [CYGWIN] (special_realloc): New function.
660 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
661 requests to realloc storage in the static heap.
662
663 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
664
665 * bidi.c (bidi_initialize): Remove unused local.
666
667 2011-08-15 Eli Zaretskii <eliz@gnu.org>
668
669 * biditype.h: File removed.
670
671 * bidimirror.h: File removed.
672
673 * deps.mk (bidi.o): Remove biditype.h and
674 bidimirror.h.
675
676 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
677 bidimirror.h.
678
679 * dispextern.h: Fix a typo in the comment to bidi_type_t.
680
681 * chartab.c: Improve commentary for the uniprop_table API.
682
683 * bidi.c (bidi_paragraph_init): Support zero value of
684 bidi_ignore_explicit_marks_for_paragraph_level.
685 (bidi_initialize): Use uniprop_table instead of including
686 biditype.h and bidimirror.h.
687
688 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
689 coordinates of the iterator when restoring from ppos_it.
690 (Bug#9296)
691
692 2011-08-14 Kenichi Handa <handa@m17n.org>
693
694 * process.c (create_process): Call setup_process_coding_systems
695 after the pid of the process is set to -1 (Bug#8162).
696
697 2011-08-14 Eli Zaretskii <eliz@gnu.org>
698
699 * xdisp.c (move_it_in_display_line_to): Don't invoke
700 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
701 ppos_it. Fixes vertical cursor motion when line beginning is
702 covered by an image. (Bug#9296)
703
704 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
705
706 * nsterm.h (ns_run_ascript): Declare.
707 (NSAPP_DATA2_RUNASSCRIPT): Define.
708
709 * nsfns.m (as_script, as_result, as_status): New static variables.
710 (ns_run_ascript): New function.
711 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
712 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
713 the event loop. Get status from as_status (Bug#7276).
714
715 * nsterm.m (sendEvent): If event is NSApplicationDefined and
716 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
717 the event loop (Bug#7276).
718
719 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
720
721 * gnutls.c (QCgnutls_bootprop_priority)
722 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
723 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
724 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
725 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
726 (QCgnutls_bootprop_verify_hostname_error)
727 (QCgnutls_bootprop_callbacks_verify): Rename from
728 Qgnutls_bootprop_..., all uses changed.
729
730 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
731 uses changed.
732
733 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
734
735 * xfaces.c (Qframe_set_background_mode): Now static.
736 * dispextern.h (Qframe_set_background_mode): Remove decl.
737
738 * process.c (Fnetwork_interface_info): Declare local only if needed.
739
740 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
741
742 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
743 (Fnetwork_interface_list): Allocate in increments of bytes instead
744 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
745 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
746 sockaddr.
747 (struct ifflag_def): notrailers is smart on OSX.
748 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
749 Get hardware address with getifaddrs if available.
750
751 2011-08-12 Eli Zaretskii <eliz@gnu.org>
752
753 * xdisp.c (iterate_out_of_display_property): xassert that
754 IT->position is set to within IT->object's boundaries. Break from
755 the loop as soon as EOB is reached; avoids infloops in redisplay
756 when IT->position is set up wrongly due to some bug.
757 Set IT->current to match the bidi iterator unconditionally.
758 (push_display_prop): Allow GET_FROM_STRING as IT->method on
759 entry. Force push_it to save on the stack the current
760 buffer/string position, to be restored by pop_it. Fix flags in
761 the iterator structure wrt the object coming from a display
762 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
763 properties. (Bug#9284)
764
765 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
766
767 * fontset.c (fontset_get_font_group): Add proper type checks.
768 (Bug#9172)
769
770 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
771
772 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
773 and LC_VERSION_MIN_MACOSX.
774 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
775 (dump_it) [LC_FUNCTION_STARTS]: Use it.
776
777 2011-08-08 Eli Zaretskii <eliz@gnu.org>
778
779 * xdisp.c (forward_to_next_line_start): Allow to use the
780 no-display-properties-and-no-overlays under bidi display.
781 Set disp_pos in the bidi iterator to avoid searches for display
782 properties and overlays.
783
784 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
785
786 * editfns.c (Fset_time_zone_rule): Document relationship with the
787 setenv function.
788
789 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
790 the font entity extracted from the cache (Bug#8109).
791
792 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
793
794 * composite.c (autocmp_chars): Don't reset point. That is done by
795 restore_point_unwind (Bug#5984).
796
797 2011-08-07 Juri Linkov <juri@jurta.org>
798
799 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
800 to show the arg `TIME' instead of `TIMEVAL'.
801
802 2011-08-06 Eli Zaretskii <eliz@gnu.org>
803
804 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
805 display property strides EOL and includes a newline, as in
806 longlines-mode. (Bug#9254)
807 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
808 word-wrap under bidirectional display. (Bug#9224)
809
810 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
811 is non-zero, even if the data buffer is NULL. Fixes a crash in
812 vertical-motion with longlines-mode. (Bug#9254)
813
814 2011-08-05 Eli Zaretskii <eliz@gnu.org>
815
816 * bidi.c <bidi_cache_total_alloc>: Now static.
817 (bidi_initialize): Initialize bidi_cache_total_alloc.
818
819 * xdisp.c (display_line): Release buffer allocated for shelved bidi
820 cache. (Bug#9221)
821
822 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
823 amount allocated this far in `bidi_cache_total_alloc'.
824 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
825 non-zero, only free the data buffer without restoring the cache
826 contents. All callers changed.
827
828 * dispextern.h (bidi_unshelve_cache): Update prototype.
829
830 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
831 (move_it_in_display_line, move_it_to)
832 (move_it_vertically_backward, move_it_by_lines): Replace the call
833 to xfree to an equivalent call to bidi_unshelve_cache.
834 (move_it_in_display_line_to): Fix logic of returning
835 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
836
837 2011-08-05 Eli Zaretskii <eliz@gnu.org>
838
839 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
840 came from a string character with a `cursor' property. (Bug#9229)
841
842 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
843
844 * Makefile.in (LIB_PTHREAD): New variable.
845 (LIBES): Add LIB_PTHREAD (Bug#9216).
846
847 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
848 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
849
850 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
851
852 * regex.c (re_iswctype): Remove some redundant boolean
853 conversions.
854
855 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
856
857 * xterm.c (x_find_topmost_parent): New function.
858 (x_set_frame_alpha): Find topmost parent window with
859 x_find_topmost_parent and set the property there also (bug#9181).
860 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
861
862 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
863
864 * callproc.c (Fcall_process): Avoid vfork clobbering
865 the local vars buffer, coding_systems, current_dir.
866
867 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
868
869 * keymap.c (Fmake_composed_keymap): Move to subr.el.
870
871 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
872
873 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
874 so that it is not optimized away.
875
876 * xdisp.c (compute_display_string_pos): Remove unused local.
877
878 2011-08-02 Eli Zaretskii <eliz@gnu.org>
879
880 Fix slow cursor motion and scrolling in large buffers with
881 selective display, like Org Mode buffers. (Bug#9218)
882
883 * dispextern.h (struct bidi_it): New member disp_prop_p.
884
885 * xdisp.c: Remove one-slot cache of display string positions.
886 (compute_display_string_pos): Accept an additional argument
887 DISP_PROP_P; callers changed. Scan at most 5K characters forward
888 for a display string or property. If found, set DISP_PROP_P
889 non-zero.
890
891 * bidi.c (bidi_fetch_char): Accept an additional argument
892 DISP_PROP_P, and pass it to compute_display_string_pos.
893 Only handle text covered by a display string if DISP_PROP_P is returned
894 non-zero. All callers of bidi_fetch_char changed.
895
896 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
897
898 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
899
900 2010-12-03 Don March <don@ohspite.net>
901
902 * keymap.c (Fdefine_key): Fix non-prefix key error message when
903 last character M-[char] is translated to ESC [char] (bug#7541).
904
905 2011-08-02 Kenichi Handa <handa@m17n.org>
906
907 * lisp.h (uniprop_table): Extern it.
908
909 * chartab.c (uniprop_table): Make it non-static.
910
911 2011-08-01 Eli Zaretskii <eliz@gnu.org>
912
913 * xdisp.c (forward_to_next_line_start): Accept additional argument
914 BIDI_IT_PREV, and store into it the state of the bidi iterator had
915 on the newline.
916 (reseat_at_next_visible_line_start): Use the bidi iterator state
917 returned by forward_to_next_line_start to restore the state of
918 it->bidi_it after backing up to previous newline. (Bug#9212)
919
920 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
921
922 * regex.c (re_comp): Protoize.
923 (re_exec): Fix return type.
924 (regexec): Fix type of `ret'. (Bug#9203)
925
926 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
927
928 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
929 This is needed if max-image-size is a floating-point number.
930
931 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
932
933 * print.c (print_object): Print empty symbol as ##.
934
935 * lread.c (read1): Read ## as empty symbol.
936
937 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
938
939 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
940 setting frame foreground color (Bug#9175).
941 (x_set_background_color): Likewise.
942
943 * nsmenu.m (-setText): Size tooltip dimensions precisely to
944 contents (Bug#9176).
945 (EmacsTooltip -init): Remove bezels and add shadows to
946 tooltip windows.
947
948 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
949 or scroll bar (Bug#8470).
950
951 * nsfont.m (nsfont_open): Remove assignment to voffset and
952 unnecessary vars hshink, expand, hd, full_height, min_height.
953 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
954
955 * nsterm.h (nsfont_info): Remove voffset field.
956
957 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
958
959 Implement strike-through and overline on NextStep (Bug#8863).
960
961 * nsfont.m (nsfont_open): Use underline position provided by font,
962 instead of hard-coded value of 2.
963 (nsfont_draw): Call ns_draw_text_decoration instead.
964
965 * nsterm.h: Add declaration for ns_draw_text_decoration.
966
967 * nsterm.m (ns_draw_text_decoration): New function for drawing
968 underline, overline, and strike-through.
969 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
970 ns_draw_text_decoration. Change treatment of cursor drawing to
971 accomodate underlining, etc.
972
973 2011-07-28 Eli Zaretskii <eliz@gnu.org>
974
975 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
976 default.
977
978 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
979
980 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
981 Without this fix, if a signal arrives just after memory fills up,
982 'malloc' might be invoked reentrantly.
983
984 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
985 In other words, assume that every image size is allowed, on non-X
986 hosts. This assumption is probably wrong, but it lets Emacs compile.
987
988 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
989
990 * regex.c (re_iswctype): Convert return values to boolean.
991
992 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
993
994 * xdisp.c (compute_display_string_pos): Don't use cached display
995 string position if the buffer had its restriction changed.
996 (Bug#9184)
997
998 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
999
1000 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1001
1002 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1003
1004 Integer signedness and overflow and related fixes. (Bug#9079)
1005
1006 * bidi.c: Integer size and overflow fixes.
1007 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1008 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1009 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1010 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1011 (bidi_find_other_level_edge):
1012 Use ptrdiff_t instead of EMACS_INT where either will do.
1013 This works better on 32-bit hosts configured --with-wide-int.
1014 (bidi_cache_ensure_space): Check for size-calculation overflow.
1015 Use % rather than repeated addition, for better worst-case speed.
1016 Don't set bidi_cache_size until after xrealloc returns, because it
1017 might not return.
1018 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1019 (bidi_cache_ensure_space): Also check that the bidi cache size
1020 does not exceed that of the largest Lisp string or buffer. See Eli
1021 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1022
1023 * alloc.c (__malloc_size_t): Remove.
1024 All uses replaced by size_t. See Andreas Schwab's note
1025 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1026
1027 * image.c: Improve checking for integer overflow.
1028 (check_image_size): Assume that f is nonnull, since
1029 it is always nonnull in practice. This is one less thing to
1030 worry about when checking for integer overflow later.
1031 (x_check_image_size): New function, which checks for integer
1032 overflow issues inside X.
1033 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1034 This removes the need for a memory_full check.
1035 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1036 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1037 (xbm_read_bitmap_data): Change locals back to 'int', since
1038 their values must fit in 'int'.
1039 (xpm_load_image, png_load, tiff_load):
1040 Invoke x_create_x_image_and_pixmap earlier,
1041 to avoid much needless work if the image is too large.
1042 (tiff_load): Treat overly large images as if
1043 x_create_x_image_and_pixmap failed, not as malloc failures.
1044 (gs_load): Use x_check_image_size.
1045
1046 * gtkutil.c: Omit integer casts.
1047 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1048 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1049
1050 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1051
1052 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1053 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1054 would wrongly return t on a 64-bit host.
1055
1056 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1057 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1058 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1059 and therefore cause GCC to emit a bogus diagnostic in some cases.
1060
1061 * image.c: Integer signedness and overflow and related fixes.
1062 This is not an exhaustive set of fixes, but it's time to
1063 record what I've got.
1064 (lookup_pixel_color, check_image_size): Remove redundant decls.
1065 (check_image_size): Don't assume that arbitrary EMACS_INT values
1066 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1067 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1068 (tiff_load, imagemagick_load_image):
1069 Check for overflow in size calculations.
1070 (x_create_x_image_and_pixmap): Remove unnecessary test for
1071 xmalloc returning NULL; that can't happen.
1072 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1073 (xpm_color_bucket): Use better integer hashing function.
1074 (xpm_cache_color): Don't possibly over-allocate memory.
1075 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1076 (gif_memory_source):
1077 Use ptrdiff_t, not int or size_t, to record sizes.
1078 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1079 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1080 either works, as we prefer signed integers.
1081 (tiff_read_from_memory, tiff_write_from_memory):
1082 Return tsize_t, not size_t, since that's what the TIFF API wants.
1083 (tiff_read_from_memory): Don't fail simply because the read would
1084 go past EOF; instead, return a short read.
1085 (tiff_load): Omit no-longer-needed casts.
1086 (Fimagemagick_types): Don't assume size fits into 'int'.
1087
1088 Improve hashing quality when configured --with-wide-int.
1089 * fns.c (hash_string): New function, taken from sxhash_string.
1090 Do not discard information about ASCII character case; this
1091 discarding is no longer needed.
1092 (sxhash-string): Use it. Change sig to match it. Caller changed.
1093 * lisp.h: Declare it.
1094 * lread.c (hash_string): Remove, since we now use fns.c's version.
1095 The fns.c version returns a wider integer if --with-wide-int is
1096 specified, so this should help the quality of the hashing a bit.
1097
1098 * emacs.c: Integer overflow minor fix.
1099 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1100 Define only if GNU_LINUX.
1101 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1102
1103 * dispnew.c: Integer signedness and overflow fixes.
1104 Remove unnecessary forward decls, that were a maintenance hassle.
1105 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1106 All uses changed.
1107 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1108 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1109 (prepare_desired_row, line_draw_cost):
1110 Use int, not unsigned, where either works.
1111 (save_current_matrix, restore_current_matrix):
1112 Use ptrdiff_t, not size_t, where either works.
1113 (init_display): Check for overflow more accurately, and without
1114 relying on undefined behavior.
1115
1116 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1117 Remove, replacing with the new symbols in lisp.h. All uses changed.
1118 * fileio.c (make_temp_name):
1119 * filelock.c (lock_file_1, lock_file):
1120 * xdisp.c (message_dolog):
1121 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1122 Use pMd etc. instead.
1123 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1124 replacing the pWIDE etc. symbols removed from editfns.c.
1125
1126 * keyboard.h (num_input_events): Now uintmax_t.
1127 This is (very slightly) less likely to mess up due to wraparound.
1128 All uses changed.
1129
1130 * buffer.c: Integer signedness fixes.
1131 (alloc_buffer_text, enlarge_buffer_text):
1132 Use ptrdiff_t rather than size_t when either will do, as we prefer
1133 signed integers.
1134
1135 * alloc.c: Integer signedness and overflow fixes.
1136 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1137 (__malloc_size_t): Default to size_t, not to int.
1138 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1139 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1140 Prefer ptrdiff_t to size_t when either would do, as we prefer
1141 signed integers.
1142 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1143 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1144 Now const. Initialize with values that are in range even if char
1145 is signed.
1146 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1147 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1148 These functions do the right thing with sizes > 2**32.
1149 (check_depth): Now ptrdiff_t, not int.
1150 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1151 Adjust to new way of storing sizes. Check for size overflow bugs
1152 in rest of code.
1153 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1154 slightly wrong anyway, as it missed one instance of
1155 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1156 (refill_memory_reserve): Omit needless cast to size_t.
1157 (mark_object_loop_halt): Mark as externally visible.
1158
1159 * xselect.c: Integer signedness and overflow fixes.
1160 (Fx_register_dnd_atom, x_handle_dnd_message):
1161 Use ptrdiff_t, not size_t, since we prefer signed.
1162 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1163 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1164 x_dnd_atoms_size and x_dnd_atoms_length.
1165
1166 * doprnt.c: Prefer signed to unsigned when either works.
1167 * eval.c (verror):
1168 * doprnt.c (doprnt):
1169 * lisp.h (doprnt):
1170 * xdisp.c (vmessage):
1171 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1172 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1173 prefer signed arithmetic to avoid comparison confusion.
1174 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1175 but is a bit tricky.
1176
1177 Assume freestanding C89 headers, string.h, stdlib.h.
1178 * data.c, doprnt.c, floatfns.c, print.c:
1179 Include float.h unconditionally.
1180 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1181 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1182 * regex.c: Likewise for stddef.h, string.h.
1183 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1184 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1185 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1186 (STDC_HEADERS): Remove obsolete defines.
1187 * sysdep.c: Include limits.h unconditionally.
1188
1189 Assume support for memcmp, memcpy, memmove, memset.
1190 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1191 * regex.c (memcmp, memcpy):
1192 Remove; we assume C89 now.
1193
1194 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1195 (__malloc_safe_bcopy): Remove; no longer needed.
1196
1197 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1198 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1199 well either way, and we prefer signed to unsigned.
1200
1201 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1202
1203 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1204 closes the connection while we're reading (bug#9182).
1205
1206 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1207
1208 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1209 are specified (Bug#9168).
1210
1211 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1212
1213 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1214 Found by GCC static checking and --with-wide-int on a 32-bit host.
1215
1216 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1217
1218 * xdisp.c (compute_display_string_pos): Fix logic of caching
1219 previous display string position. Initialize cached_prev_pos to
1220 -1. Fixes slow-down at the beginning of a buffer.
1221
1222 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1223
1224 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1225 for attrs[LFACE_FONTSET_INDEX].
1226
1227 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1228
1229 * xml.c (parse_region): Remove unused local
1230 that was recently introduced.
1231
1232 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1233
1234 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1235 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1236
1237 * xdisp.c (move_it_in_display_line_to): Record the best matching
1238 position for TO_CHARPOS while scanning the line, and restore it on
1239 exit if none of the characters scanned was an exact match.
1240 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1241 when exact match is impossible due to invisible text, and the
1242 lines are truncated.
1243
1244 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1245
1246 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1247 for OSX >= 10.7.
1248
1249 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1250
1251 Fix a significant slow-down of cursor motion with C-n, C-p,
1252 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1253 auto-repeat under bidi redisplay in fontified buffers.
1254 * xdisp.c (compute_stop_pos_backwards): New function.
1255 (next_element_from_buffer): Call compute_stop_pos_backwards to
1256 find a suitable prev_stop when we find ourselves before
1257 base_level_stop.
1258 (reseat): Don't look for prev_stop, as that could mean a very long
1259 run.
1260 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1261 <cached_disp_overlay_modiff>: Cache for last found display string
1262 position.
1263 (compute_display_string_pos): Return the cached position if asked
1264 about the same buffer in the same area of character positions, and
1265 the buffer wasn't changed since the time the display string
1266 position was cached.
1267
1268 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1269
1270 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1271 is an integer, which is important for empty lines. (Bug#9149)
1272
1273 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1274
1275 * frame.c (Fmodify_frame_parameters): In tty case, update the
1276 default face if necessary (Bug#4238).
1277
1278 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1279
1280 * editfns.c (Fstring_to_char): No need to explain what a character
1281 is in the docstring (Bug#6576).
1282
1283 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1284
1285 * xml.c (parse_region): Make sure we always return a tree.
1286
1287 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1288
1289 * xml.c (parse_region): If a document contains only comments,
1290 return that, too.
1291
1292 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1293
1294 * xml.c (make_dom): Return comments, too.
1295
1296 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1297
1298 Port to OpenBSD.
1299 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1300 and the surrounding thread.
1301 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1302 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1303 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1304 timer goes off.
1305 * s/openbsd.h (BROKEN_SIGIO): Define.
1306 * unexelf.c (unexec) [__OpenBSD__]:
1307 Don't update the .mdebug section of the Alpha COFF symbol table.
1308
1309 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1310
1311 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1312 (bug#8460).
1313
1314 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1315
1316 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1317 This fixes some race conditions on the permissions of any newly
1318 created file.
1319
1320 * alloc.c (valid_pointer_p): Use pipe, not open.
1321 This fixes some permissions issues when debugging.
1322
1323 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1324 If fchown fails to set both uid and gid, try to set just gid,
1325 as that is sometimes allowed. Adjust the file's mode to eliminate
1326 setuid or setgid bits that are inappropriate if fchown fails.
1327
1328 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1329
1330 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1331 to compare Lisp_Objects.
1332 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1333 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1334 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1335
1336 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1337
1338 * lread.c (read_integer): Unread even EOF character.
1339 (read1): Likewise. Properly record start position of symbol.
1340
1341 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1342 symbol character follows.
1343
1344 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1345
1346 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1347 This works around a problem with the previous change to Fcopy_file.
1348 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1349 and without this change, GCC might complain about discarding
1350 fchown's return value.
1351
1352 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1353
1354 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1355
1356 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1357
1358 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1359
1360 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1361
1362 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1363 it's used from the C level.
1364
1365 * process.c: Use the same condition for POLL_FOR_INPUT in both
1366 keyboard.c and process.c (bug#1858).
1367
1368 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1369
1370 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1371 (Fgnutls_boot): Use it.
1372
1373 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1374
1375 * doc.c (Fsubstitute_command_keys): Revert last change.
1376
1377 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1378
1379 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1380 quotes the next character, and doesn't affect other longer
1381 sequences (bug#8935).
1382
1383 * lread.c (syms_of_lread): Clarify that is isn't only
1384 `eval-buffer' and `eval-defun' that's affected by
1385 `lexical-binding' (bug#8460).
1386
1387 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1388
1389 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1390 bidi redisplay when a line includes both an image and is
1391 truncated.
1392
1393 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1394
1395 Fix minor problems found by static checking.
1396 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1397 (elsz): Now a signed constant, not a size_t var. We prefer signed
1398 types to unsigned, to avoid integer comparison confusion. Without
1399 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1400 "cannot optimize loop, the loop counter may overflow", a symptom
1401 of the confusion.
1402 * indent.c (Fvertical_motion): Mark locals as initialized.
1403 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1404
1405 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1406
1407 * search.c (Fre_search_backward): Mention `case-fold-search' in
1408 all the re_search_* functions (bug#8138).
1409
1410 * keyboard.c (Fopen_dribble_file): Document when the file is
1411 closed (bug#8056).
1412
1413 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1414
1415 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1416 bidi_cache_idx.
1417
1418 Support bidi reordering of display and overlay strings.
1419 * xdisp.c (compute_display_string_pos)
1420 (compute_display_string_end): Accept additional argument STRING.
1421 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1422 (reseat_to_string): Initialize bidi_it->string.s and
1423 bidi_it->string.schars.
1424 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1425 NULL (avoids a crash in bidi_paragraph_init).
1426 Initialize itb.string.lstring.
1427 (init_iterator): Call bidi_init_it only of a valid
1428 buffer position was specified. Initialize paragraph_embedding to
1429 L2R.
1430 (reseat_to_string): Initialize the bidi iterator.
1431 (display_string): If we need to ignore text properties of
1432 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1433 original value of -1 will not work with bidi.)
1434 (compute_display_string_pos): First arg is now struct
1435 `text_pos *'; all callers changed. Support display properties on
1436 Lisp strings.
1437 (compute_display_string_end): Support display properties on Lisp
1438 strings.
1439 (init_iterator, reseat_1, reseat_to_string): Initialize the
1440 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1441 when iterating on a string not from display properties).
1442 (compute_display_string_pos, compute_display_string_end):
1443 Fix calculation of the object to scan. Fixes an error when using
1444 arrow keys.
1445 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1446 base_level_stop; instead, set base_level_stop to BEGV.
1447 Fixes crashes in vertical-motion.
1448 (next_element_from_buffer): Improve commentary for when
1449 the iterator is before prev_stop.
1450 (init_iterator): Initialize bidi_p from the default value of
1451 bidi-display-reordering, not from buffer-local value. Use the
1452 buffer-local value only if initializing for buffer iteration.
1453 (handle_invisible_prop): Support invisible properties on strings
1454 that are being bidi-reordered.
1455 (set_iterator_to_next): Support bidi reordering of C strings and
1456 Lisp strings.
1457 (next_element_from_string): Support bidi reordering of Lisp
1458 strings.
1459 (handle_stop_backwards): Support Lisp strings as well.
1460 (display_string): Support display of R2L glyph rows.
1461 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1462 (init_iterator): Don't initialize it->bidi_p for strings
1463 here.
1464 (reseat_to_string): Initialize it->bidi_p for strings here.
1465 (next_element_from_string, next_element_from_c_string)
1466 (next_element_from_buffer): Add xassert's for correspondence
1467 between IT's object being iterated and it->bidi_it.string
1468 structure.
1469 (face_before_or_after_it_pos): Support bidi iteration.
1470 (next_element_from_c_string): Handle the case of the first string
1471 character that is not the first one in the visual order.
1472 (get_visually_first_element): New function, refactored from common
1473 parts of next_element_from_buffer, next_element_from_string, and
1474 next_element_from_c_string.
1475 (tool_bar_lines_needed, redisplay_tool_bar)
1476 (display_menu_bar): Force left-to-right direction. Add a FIXME
1477 comment for making that be controlled by a user option.
1478 (push_it, pop_it): Save and restore the state of the
1479 bidi iterator. Save and restore the bidi_p flag.
1480 (pop_it): Iterate out of display property for string iteration as
1481 well.
1482 (iterate_out_of_display_property): Support iteration over strings.
1483 (handle_single_display_spec): Set up it->bidi_it for iteration
1484 over a display string, and call bidi_init_it.
1485 (handle_single_display_spec, next_overlay_string)
1486 (get_overlay_strings_1, push_display_prop): Set up the bidi
1487 iterator for displaying display or overlay strings.
1488 (forward_to_next_line_start): Don't use the shortcut if
1489 bidi-iterating.
1490 (back_to_previous_visible_line_start): If handle_display_prop
1491 pushed the iterator stack, restore the internal state of the bidi
1492 iterator by calling bidi_pop_it same number of times.
1493 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1494 and we are bidi-iterating, don't decrement the iterator position;
1495 instead, set the first_elt flag in the bidi iterator, to produce
1496 the same effect.
1497 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1498 (push_display_prop): xassert that we are iterating a buffer.
1499 (push_it, pop_it): Save and restore paragraph_embedding member.
1500 (handle_single_display_spec, next_overlay_string)
1501 (get_overlay_strings_1, reseat_1, reseat_to_string)
1502 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1503 correctly. Don't assume unibyte strings are not bidi-reordered.
1504 (compute_display_string_pos)
1505 (compute_display_string_end): Fix handling the case of C string.
1506 (push_it, pop_it): Save and restore from_disp_prop_p.
1507 (handle_single_display_spec, push_display_prop): Set the
1508 from_disp_prop_p flag.
1509 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1510 (pop_it): Call iterate_out_of_display_property only if we are
1511 popping after iteration over a string that came from a display
1512 property. Fix a typo in popping stretch info. Add an assertion
1513 for verifying that the iterator position is in sync with the bidi
1514 iterator.
1515 (handle_single_display_spec, get_overlay_strings_1)
1516 (push_display_prop): Fix initialization of paragraph direction for
1517 string when that of the parent object is not yet determined.
1518 (reseat_1): Call bidi_init_it to resync the bidi
1519 iterator with IT's position. (Bug#7616)
1520 (find_row_edges): If ROW->start.pos gives position
1521 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1522 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1523 Reset the from_disp_prop_p flag.
1524 (SAVE_IT, RESTORE_IT): New macros.
1525 (pos_visible_p, face_before_or_after_it_pos)
1526 (back_to_previous_visible_line_start)
1527 (move_it_in_display_line_to, move_it_in_display_line)
1528 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1529 (try_scrolling, redisplay_window, display_line): Use them when
1530 saving a temporary copy of the iterator and restoring it back.
1531 (back_to_previous_visible_line_start, reseat_1)
1532 (init_iterator): Empty the bidi cache "stack".
1533 (move_it_in_display_line_to): If iterator ended up at
1534 EOL, but we never saw any buffer positions smaller than
1535 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1536 motion in bidi-reordered lines.
1537 (move_it_in_display_line_to): Record prev_method and prev_pos
1538 immediately before the call to set_iterator_to_next. Fixes cursor
1539 motion in bidi-reordered lines with stretch glyphs and strings
1540 displayed in margins. (Bug#8133) (Bug#8867)
1541 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1542 TO_CHARPOS.
1543 (pos_visible_p): Support positions in bidi-reordered lines.
1544 Save and restore bidi cache.
1545
1546 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1547 (bidi_paragraph_info): Delete unused struct.
1548 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1549 (bidi_cache_start): New variable.
1550 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1551 to zero.
1552 (bidi_cache_fetch_state, bidi_cache_search)
1553 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1554 (bidi_cache_find, bidi_peek_at_next_level)
1555 (bidi_level_of_next_char, bidi_find_other_level_edge)
1556 (bidi_move_to_visually_next): Compare cache index with
1557 bidi_cache_start rather than with zero.
1558 (bidi_fetch_char): Accept new argument STRING; all callers
1559 changed. Support iteration over a string. Support strings with
1560 display properties. Support unibyte strings. Fix the type of
1561 `len' according to what STRING_CHAR_AND_LENGTH expects.
1562 (bidi_paragraph_init, bidi_resolve_explicit_1)
1563 (bidi_resolve_explicit, bidi_resolve_weak)
1564 (bidi_level_of_next_char, bidi_move_to_visually_next):
1565 Support iteration over a string.
1566 (bidi_set_sor_type, bidi_resolve_explicit_1)
1567 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1568 can now be zero (for strings); special values 0 and -1 were
1569 changed to -1 and -2, respectively.
1570 (bidi_char_at_pos): New function.
1571 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1572 Call it instead of FETCH_MULTIBYTE_CHAR.
1573 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1574 initialized to valid values.
1575 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1576 values.
1577 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1578 the test for valid cached positions. Fix the logic for looking up
1579 the sentinel state in the cache. GCPRO the Lisp string we are
1580 iterating.
1581 (bidi_push_it, bidi_pop_it): New functions.
1582 (bidi_initialize): Initialize the bidi cache start stack pointer.
1583 (bidi_cache_ensure_space): New function, refactored from part of
1584 bidi_cache_iterator_state. Don't assume the required size is just
1585 one BIDI_CACHE_CHUNK away.
1586 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1587 (bidi_count_bytes, bidi_char_at_pos): New functions.
1588 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1589 always valid if bidi_cache_idx is valid.
1590 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1591 is valid if it's going to be used.
1592 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1593 (bidi_cache_fetch_state, bidi_cache_search)
1594 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1595 (bidi_cache_iterator_state, bidi_cache_find)
1596 (bidi_find_other_level_edge, bidi_cache_start_stack):
1597 All variables related to cache indices are now EMACS_INT.
1598
1599 * dispextern.h (struct bidi_string_data): New structure.
1600 (struct bidi_it): New member `string'. Make flag members be 1-bit
1601 fields, and put them last in the struct.
1602 (compute_display_string_pos, compute_display_string_end):
1603 Update prototypes.
1604 (bidi_push_it, bidi_pop_it): Add prototypes.
1605 (struct iterator_stack_entry): New members bidi_p,
1606 paragraph_embedding, and from_disp_prop_p.
1607 (struct it): Member bidi_p is now a bit field 1 bit wide.
1608 (bidi_shelve_cache, bidi_unshelve_cache):
1609 Declare prototypes.
1610
1611 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1612 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1613 and vector-like objects.
1614
1615 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1616 cache around display iteration.
1617
1618 * window.c (Fwindow_end, window_scroll_pixel_based)
1619 (displayed_window_lines, Frecenter): Save and restore the bidi
1620 cache around display iteration.
1621
1622 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1623
1624 * editfns.c (Fdelete_region): Clarify the use of the named
1625 parameters (bug#6788).
1626
1627 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1628
1629 * indent.c (Fvertical_motion): Set and restore w->pointm when
1630 saving and restoring the window's buffer (Bug#9006).
1631
1632 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1633
1634 * editfns.c (Fstring_to_char): Clarify just what is returned
1635 (bug#6576). Text by Eli Zaretskii.
1636
1637 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1638
1639 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1640
1641 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1642
1643 * buffer.c (mmap_find): Fix a typo.
1644
1645 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1646
1647 Fix execution of x selection hooks.
1648 * xselect.c (Qx_lost_selection_functions)
1649 (Qx_sent_selection_functions): New vars.
1650 (syms_of_xselect): DEFSYM them.
1651 (x_handle_selection_request): Pass Qx_sent_selection_functions
1652 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1653 (x_handle_selection_clear,x_clear_frame_selections):
1654 Pass Qx_lost_selection_functions rather than
1655 Vx_lost_selection_functions to Frun_hook_with_args.
1656
1657 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1658
1659 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1660 The old code sometimes used this field without initializing it.
1661
1662 * alloc.c (gc_sweep): Don't read past end of array.
1663 In theory, the old code could also have corrupted Emacs internals,
1664 though it'd be very unlikely.
1665
1666 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1667
1668 * character.c (Fcharacterp): Don't advertise optional ignored
1669 argument. (Bug#4026)
1670
1671 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1672
1673 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1674 key" (bug#4257).
1675
1676 * window.c (Fset_window_start): Doc fix (bug#4199).
1677 (Fset_window_hscroll): Ditto.
1678
1679 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1680
1681 Fix minor new problems caught by GCC 4.6.1.
1682 * term.c (init_tty): Remove unused local.
1683 * xsettings.c (store_monospaced_changed): Define this function only
1684 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1685 not used otherwise.
1686
1687 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1688
1689 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1690
1691 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1692
1693 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1694 are the mini-buffer and the echo area (bug#3320).
1695
1696 * term.c (init_tty): Remove support for supdup, c10 and perq
1697 terminals, which are no longer supported (bug#1482).
1698
1699 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1700
1701 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1702
1703 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1704
1705 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1706 for non-popups (Bug#3642).
1707
1708 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1709
1710 * alloc.c (reset_malloc_hooks): Protoize.
1711 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1712 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1713 * cm.c (losecursor): Likewise.
1714 * data.c (fmod): Likewise.
1715 * dispnew.c (swap_glyphs_in_rows): Likewise.
1716 * emacs.c (memory_warning_signal): Likewise.
1717 * floatfns.c (float_error): Likewise.
1718 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1719 (otf_open, font_otf_capability, generate_otf_features)
1720 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1721 Likewise.
1722 * image.c (pbm_read_file): Likewise.
1723 * indent.c (string_display_width): Likewise.
1724 * intervals.c (check_for_interval, search_for_interval)
1725 (inc_interval_count, count_intervals, root_interval)
1726 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1727 * lread.c (defalias): Likewise.
1728 * ralloc.c (r_alloc_check): Likewise.
1729 * regex.c (set_image_of_range_1, set_image_of_range)
1730 (regex_grow_registers): Likewise.
1731 * sysdep.c (strerror): Likewise.
1732 * termcap.c (valid_filename_p, tprint, main): Likewise.
1733 * tparam.c (main): Likewise.
1734 * unexhp9k800.c (run_time_remap, save_data_space)
1735 (update_file_ptrs, read_header, write_header, calculate_checksum)
1736 (copy_file, copy_rest, display_header): Likewise.
1737 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1738 Likewise.
1739 * xdisp.c (check_it): Likewise.
1740 * xfaces.c (register_color, unregister_color, unregister_colors):
1741 Likewise.
1742 * xfns.c (print_fontset_result): Likewise.
1743 * xrdb.c (member, fatal, main): Likewise.
1744
1745 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1746
1747 Fix minor problems found by static checking (Bug#9031).
1748 * chartab.c (char_table_set_range, map_sub_char_table):
1749 Remove unused locals.
1750 (uniprop_table): Now static.
1751 * composite.c (_work_char): Remove unused static var.
1752
1753 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1754
1755 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1756
1757 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1758
1759 * gtkutil.c (qttip_cb): Remove code without function.
1760
1761 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1762
1763 * w32.c (pthread_sigmask): New stub.
1764
1765 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1766
1767 Use pthread_sigmask, not sigprocmask (Bug#9010).
1768 sigprocmask is portable only for single-threaded applications, and
1769 Emacs can be multi-threaded when it uses GTK.
1770 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1771 (LIBES): Use it.
1772 * callproc.c (Fcall_process):
1773 * process.c (create_process):
1774 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1775 Use pthread_sigmask, not sigprocmask.
1776
1777 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1778
1779 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1780 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1781 wrong (Bug#8591).
1782
1783 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1784
1785 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1786 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1787 (xg_hide_tooltip): Fix comment.
1788
1789 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1790 in registerServicesMenuSendTypes.
1791 (validRequestorForSendType): Don't check ns_return_types.
1792
1793 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1794 ns_return_type.
1795
1796 2011-07-08 Jason Rumney <jasonr@gnu.org>
1797
1798 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1799 frame struct members of non-existent frames (Bug#6284).
1800
1801 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1802
1803 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1804 variable firstTime not needed on OSX >= 10.6.
1805 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1806 >= 10.5. Use setKnobProportion, setDoubleValue.
1807
1808 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1809 (MAC_OS_X_VERSION_10_5): Define if not defined.
1810 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1811 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1812 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1813
1814 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1815 cString and lossyCString on OSX >= 10.4
1816
1817 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1818 sizeToFit on OSX >= 10.2.
1819
1820 * nsimage.m (allocInitFromFile): Don't use deprecated method
1821 bestRepresentationForDevice on OSX >= 10.6.
1822
1823 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1824 to avoid warning.
1825
1826 * emacs.c: Declare unexec_init_emacs_zone.
1827
1828 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1829
1830 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1831
1832 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1833 on svcsMenu (Bug#8842).
1834
1835 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1836 ns_return_types.
1837 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1838
1839 * nsterm.m (QUTF8_STRING): Declare.
1840 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1841 (validRequestorForSendType): Return type is (id).
1842 Change indexOfObjectIdenticalTo to indexOfObject.
1843 Check if we have local selection before returning self (Bug#8842).
1844 (writeSelectionToPasteboard): Put local selection into paste board
1845 if we have a local selection (Bug#8842).
1846 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1847
1848 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1849 (ns_get_local_selection): Declare.
1850
1851 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1852
1853 * keymap.c (describe_map_tree): Don't insert a double newline at
1854 the end of the buffer (bug#1169) and return whether we inserted
1855 something.
1856
1857 * callint.c (Fcall_interactively): Change "reading args" to
1858 "providing args" to try to clarify what it does (bug#1010).
1859
1860 2011-07-07 Kenichi Handa <handa@m17n.org>
1861
1862 * composite.c (composition_compute_stop_pos): Ignore a static
1863 composition starting before CHARPOS (Bug#8915).
1864
1865 * xdisp.c (handle_composition_prop): Likewise.
1866
1867 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1868
1869 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1870 (Bug#9015)
1871
1872 2011-07-07 Kenichi Handa <handa@m17n.org>
1873
1874 * character.h (unicode_category_t): New enum type.
1875
1876 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1877 (Qchar_code_property_table): New variable.
1878 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1879 (UNIPROP_COMPRESSED_FORM_P): New macros.
1880 (char_table_ascii): Uncompress the compressed values.
1881 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1882 Uncompress the compressed values.
1883 (sub_char_table_ref_and_range): Likewise.
1884 (char_table_ref_and_range): Uncompress the compressed values.
1885 (sub_char_table_set): New arg is_uniprop. Callers changed.
1886 Uncompress the compressed values.
1887 (sub_char_table_set_range): Args changed. Callers changed.
1888 (char_table_set_range): Adjuted for the above change.
1889 (map_sub_char_table): Delete args default_val and parent. Add arg
1890 top. Give decoded values to a Lisp function.
1891 (map_char_table): Adjust for the above change. Give decoded
1892 values to a Lisp function. Gcpro more variables.
1893 (uniprop_table_uncompress)
1894 (uniprop_decode_value_run_length): New functions.
1895 (uniprop_decoder, uniprop_decoder_count): New variables.
1896 (uniprop_get_decoder, uniprop_encode_value_character)
1897 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1898 New functions.
1899 (uniprop_encoder, uniprop_encoder_count): New variables.
1900 (uniprop_get_encoder, uniprop_table)
1901 (Funicode_property_table_internal, Fget_unicode_property_internal)
1902 (Fput_unicode_property_internal): New functions.
1903 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1904 Sunicode_property_table_internal, Sget_unicode_property_internal,
1905 and Sput_unicode_property_internal. Defvar_lisp
1906 char-code-property-alist.
1907
1908 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1909 Vunicode_category_table.
1910
1911 * font.c (font_range): Adjust for the change of
1912 Vunicode_category_table.
1913
1914 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1915
1916 * m/iris4d.h: Remove file, move contents ...
1917 * s/irix6-5.h: ... here.
1918
1919 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1920
1921 Remove unportable assumption about struct layout (Bug#8884).
1922 * alloc.c (mark_buffer):
1923 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1924 (clone_per_buffer_values): Don't assume that
1925 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1926 This isn't true in general, and it's particularly not true
1927 if Emacs is configured with --with-wide-int.
1928 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1929 New macros, used in the buffer.c change.
1930
1931 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1932
1933 * xsettings.c: Use both GConf and GSettings if both are available.
1934 (store_config_changed_event): Add comment.
1935 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1936 (store_tool_bar_style_changed): New functions.
1937 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1938 (struct xsettings): Move font inside HAVE_XFT.
1939 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1940 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1941 Move inside HAVE_XFT.
1942 (something_changed_gsettingsCB): Rename from something_changedCB.
1943 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1944 also.
1945 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1946 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1947 (something_changed_gconfCB): Rename from something_changedCB.
1948 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1949 (parse_settings): Move check for font inside HAVE_XFT.
1950 (read_settings, apply_xft_settings): Add comment.
1951 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1952 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1953 call store_font_name_changed.
1954 (xft_settings_event): Add comment.
1955 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1956 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1957 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1958 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1959 (xsettings_initialize): Call init_gsettings last.
1960 (xsettings_get_system_font, xsettings_get_system_normal_font):
1961 Add comment.
1962
1963 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1964
1965 Random fixes. E.g., (random) never returned negative values.
1966 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1967 subseconds part to the entropy, as that's a bit more random.
1968 Prefer signed to unsigned, since the signedness doesn't matter and
1969 in general we prefer signed. When given a limit, use a
1970 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1971 latter isn't right if USE_2_TAGS_FOR_INTS.
1972 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1973 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1974
1975 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1976
1977 * textprop.c (text_property_stickiness):
1978 Obey Vtext_property_default_nonsticky.
1979 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1980 * w32fns.c (syms_of_w32fns):
1981 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1982
1983 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1984
1985 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1986 This is more efficient than Ffile_directory_p and avoids a minor race.
1987
1988 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1989
1990 * buffer.c (Foverlay_put): Say what the return value is
1991 (bug#7835).
1992
1993 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1994 is a directory before asking whether to use the file name
1995 (bug#7564).
1996 (barf_or_query_if_file_exists): Make the "File is a directory"
1997 error be more correct.
1998
1999 * fns.c (Frequire): Remove the mention of the .gz files, since
2000 that's installation-specific, but keep the mention of
2001 `get-load-suffixes'.
2002
2003 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2004
2005 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2006 Report string overflow if the output is too long.
2007
2008 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2009
2010 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2011 (syms_of_gnutls): Remove duplicate DEFSYM for
2012 Qgnutls_bootprop_verify_hostname_error, an error for
2013 Qgnutls_bootprop_verify_error (which is no longer used).
2014
2015 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2016 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2017 Also (re)move comments that are misplaced or no longer relevant.
2018
2019 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2020
2021 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2022
2023 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2024
2025 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2026 and background color parameters if they have been changed.
2027
2028 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2029
2030 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2031
2032 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2033
2034 * xsettings.c (SYSTEM_FONT): Define only when used.
2035 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2036
2037 * keymap.c (access_keymap_1): Now static.
2038
2039 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2040
2041 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2042 leave any prefix arg for the up event (Bug#1586).
2043
2044 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2045
2046 * lread.c (syms_of_lread): Mention single symbols defined by
2047 `defvar' or `defconst' (bug#7154).
2048
2049 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2050 (Frequire): Mention get-load-suffixes.
2051
2052 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2053
2054 * window.h (window): Remove clone_number slot.
2055 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2056 Remove.
2057 (make_parent_window, make_window, saved_window)
2058 (Fset_window_configuration, save_window_save): Don't deal with
2059 clone numbers.
2060 * buffer.c (Qclone_number): Remove declaration.
2061 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2062
2063 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2064
2065 Add multiple inheritance to keymaps.
2066 * keymap.c (Fmake_composed_keymap): New function.
2067 (Fset_keymap_parent): Simplify.
2068 (fix_submap_inheritance): Remove.
2069 (access_keymap_1): New function extracted from access_keymap to handle
2070 embedded parents and handle lists of maps.
2071 (access_keymap): Use it.
2072 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2073 (Fcopy_keymap): Handle embedded parents.
2074 (Fcommand_remapping, define_as_prefix): Simplify.
2075 (Fkey_binding): Simplify.
2076 (syms_of_keymap): Move minibuffer-local-completion-map,
2077 minibuffer-local-filename-completion-map,
2078 minibuffer-local-must-match-map, and
2079 minibuffer-local-filename-must-match-map to Elisp.
2080 (syms_of_keymap): Defsubr make-composed-keymap.
2081 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2082 (parse_menu_item): Trivial simplification.
2083
2084 2011-07-01 Glenn Morris <rgm@gnu.org>
2085
2086 * Makefile.in (SETTINGS_LIBS): Fix typo.
2087
2088 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2089
2090 * coding.c (Fencode_coding_string): Record the last coding system
2091 used, as the function doc string says (bug#8738).
2092
2093 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2094
2095 * xsettings.c (store_monospaced_changed): Take new font as arg and
2096 check for change against current_mono_font.
2097 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2098 (emacs_settings_constructor, emacs_settings_get_property)
2099 (emacs_settings_set_property, emacs_settings_class_init)
2100 (emacs_settings_init, gsettings_obj): Remove.
2101 (something_changedCB): New function for HAVE_GSETTINGS.
2102 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2103 with value as argument.
2104 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2105 g_settings_new (Bug#8967). Do not create gsettings_obj.
2106 Remove calls to g_settings_bind. Connect something_changedCB to
2107 "changed".
2108
2109 * xgselect.c: Add defined (HAVE_GSETTINGS).
2110 (xgselect_initialize): Ditto.
2111
2112 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2113 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2114 xg_select.
2115
2116 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2117
2118 * eval.c (struct backtrace): Simplify and port the data structure.
2119 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2120 signed bit field, as this assumption is not portable and it makes
2121 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2122 "char debug_on_exit : 1" as this is not portable either; instead,
2123 use the portable "unsigned int debug_on_exit : 1". Remove unused
2124 member evalargs. Remove obsolete comments about cc bombing out.
2125
2126 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2127
2128 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2129 Let HAVE_GSETTINGS override HAVE_GCONF.
2130 (store_monospaced_changed): New function.
2131 (EMACS_SETTINGS): A new type derived from GObject to handle
2132 GSettings notifications.
2133 (emacs_settings_constructor, emacs_settings_get_property)
2134 (emacs_settings_set_property, emacs_settings_class_init):
2135 New functions.
2136 (gsettings_client, gsettings_obj): New variables.
2137 (GSETTINGS_SCHEMA): New define.
2138 (something_changedCB): Call store_monospaced_changed.
2139 (init_gsettings): New function.
2140 (xsettings_initialize): Call init_gsettings.
2141 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2142 to NULL.
2143
2144 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2145 GCONF_CFLAGS/LIBS.
2146
2147 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2148
2149 * window.c (resize_root_window, grow_mini_window)
2150 (shrink_mini_window): Rename Qresize_root_window to
2151 Qwindow_resize_root_window and Qresize_root_window_vertically to
2152 Qwindow_resize_root_window_vertically.
2153
2154 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2155
2156 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2157
2158 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2159
2160 * makefile.w32-in: Redesign dependencies so they reflect more
2161 clearly which files are directly included by each source file,
2162 and not through other includes.
2163
2164 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2165
2166 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2167 (sort_overlays, overlay_strings): When an overlay's clone number
2168 matches the window's clone number process the overlay even if
2169 the overlay's window property doesn't match the current window.
2170
2171 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2172 (Fwindow_hchild): Rename to Fwindow_left_child.
2173 (Fwindow_next): Rename to Fwindow_next_sibling.
2174 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2175 (resize_window_check): Rename to window_resize_check.
2176 (resize_window_apply): Rename to window_resize_apply.
2177 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2178 (Fdelete_other_windows_internal, resize_frame_windows)
2179 (Fsplit_window_internal, Fdelete_window_internal)
2180 (grow_mini_window, shrink_mini_window)
2181 (Fresize_mini_window_internal): Fix callers accordingly.
2182
2183 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2184
2185 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2186 (emacs_fixed_set_min_size): Remove.
2187 (emacs_fixed_new): Take frame as argument.
2188
2189 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2190 (_EmacsFixedPrivate): Remove minwidth/height.
2191 Add struct frame *f.
2192 (emacs_fixed_init): Initialize priv->f.
2193 (get_parent_class, emacs_fixed_set_min_size): Remove.
2194 (emacs_fixed_new): Set priv->f to argument.
2195 (emacs_fixed_get_preferred_width)
2196 (emacs_fixed_get_preferred_height): Use min_width/height from
2197 frames size_hint to set minimum and natural (Bug#8919).
2198 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2199 and use min_width/height from frames size_hint to set
2200 min_width/height (Bug#8919).
2201
2202 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2203 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2204 Fix indentation.
2205
2206 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2207
2208 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2209 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2210 called at ZV.
2211
2212 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2213
2214 * process.c (wait_reading_process_output): Bypass select if
2215 waiting for a cell while ignoring keyboard input, and input is
2216 pending. Suggested by Jan Djärv (Bug#8869).
2217
2218 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2219
2220 Use gnulib's dup2 module instead of rolling our own.
2221 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2222
2223 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2224
2225 * dispnew.c (scrolling_window): Before scrolling, turn off a
2226 mouse-highlight in the window being scrolled.
2227
2228 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2229
2230 Move DEFSYM to lisp.h and use everywhere.
2231
2232 * character.h (DEFSYM): Move declaration...
2233 * lisp.h (DEFSYM): ...here.
2234
2235 * gnutls.c:
2236 * minibuf.c:
2237 * w32menu.c:
2238 * w32proc.c:
2239 * w32select.c: Don't include character.h.
2240
2241 * alloc.c (syms_of_alloc):
2242 * buffer.c (syms_of_buffer):
2243 * bytecode.c (syms_of_bytecode):
2244 * callint.c (syms_of_callint):
2245 * casefiddle.c (syms_of_casefiddle):
2246 * casetab.c (init_casetab_once):
2247 * category.c (init_category_once, syms_of_category):
2248 * ccl.c (syms_of_ccl):
2249 * cmds.c (syms_of_cmds):
2250 * composite.c (syms_of_composite):
2251 * dbusbind.c (syms_of_dbusbind):
2252 * dired.c (syms_of_dired):
2253 * dispnew.c (syms_of_display):
2254 * doc.c (syms_of_doc):
2255 * editfns.c (syms_of_editfns):
2256 * emacs.c (syms_of_emacs):
2257 * eval.c (syms_of_eval):
2258 * fileio.c (syms_of_fileio):
2259 * fns.c (syms_of_fns):
2260 * frame.c (syms_of_frame):
2261 * fringe.c (syms_of_fringe):
2262 * insdel.c (syms_of_insdel):
2263 * keymap.c (syms_of_keymap):
2264 * lread.c (init_obarray, syms_of_lread):
2265 * macros.c (syms_of_macros):
2266 * msdos.c (syms_of_msdos):
2267 * print.c (syms_of_print):
2268 * process.c (syms_of_process):
2269 * search.c (syms_of_search):
2270 * sound.c (syms_of_sound):
2271 * syntax.c (init_syntax_once, syms_of_syntax):
2272 * terminal.c (syms_of_terminal):
2273 * textprop.c (syms_of_textprop):
2274 * undo.c (syms_of_undo):
2275 * w32.c (globals_of_w32):
2276 * window.c (syms_of_window):
2277 * xdisp.c (syms_of_xdisp):
2278 * xfaces.c (syms_of_xfaces):
2279 * xfns.c (syms_of_xfns):
2280 * xmenu.c (syms_of_xmenu):
2281 * xsettings.c (syms_of_xsettings):
2282 * xterm.c (syms_of_xterm): Use DEFSYM.
2283
2284 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2285
2286 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2287
2288 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2289
2290 Integer and buffer overflow fixes (Bug#8873).
2291
2292 * print.c (printchar, strout): Check for string overflow.
2293 (PRINTPREPARE, printchar, strout):
2294 Don't set size unless allocation succeeds.
2295
2296 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2297 for sizes. Check for string overflow more accurately.
2298 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2299
2300 * macros.c: Integer and buffer overflow fixes.
2301 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2302 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2303 Use ptrdiff_t, not int, for sizes.
2304 Don't increment bufsize until after realloc succeeds.
2305 Check for size-calculation overflow.
2306 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2307
2308 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2309
2310 * lread.c: Integer overflow fixes.
2311 (read_integer): Radix is now EMACS_INT, not int,
2312 to improve quality of diagnostics for out-of-range radices.
2313 Calculate buffer size correctly for out-of-range radices.
2314 (read1): Check for integer overflow in radices, and in
2315 read-circle numbers.
2316 (read_escape): Avoid int overflow.
2317 (Fload, openp, read_buffer_size, read1)
2318 (substitute_object_recurse, read_vector, read_list, map_obarray):
2319 Use ptrdiff_t, not int, for sizes.
2320 (read1): Use EMACS_INT, not int, for sizes.
2321 Check for size overflow.
2322
2323 * image.c (cache_image): Check for size arithmetic overflow.
2324
2325 * lread.c: Integer overflow issues.
2326 (saved_doc_string_size, saved_doc_string_length)
2327 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2328 Now ptrdiff_t, not int.
2329 (read1): Don't assume doc string length fits in int. Check for
2330 out-of-range doc string lengths.
2331 (read_list): Don't assume file position fits in int.
2332 (read_escape): Check for hex character overflow.
2333
2334 2011-06-22 Leo Liu <sdl.web@gmail.com>
2335
2336 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2337 Move to minibuffer.el.
2338
2339 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2340
2341 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2342 The following patches are for when GLYPH_DEBUG && !XASSERT.
2343 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2344 * dispnew.c (flush_stdout):
2345 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2346 Mark as externally visible.
2347 * dispnew.c (check_window_matrix_pointers): Now static.
2348 * dispnew.c (window_to_frame_vpos):
2349 * xfns.c (unwind_create_frame):
2350 * xterm.c (x_check_font): Remove unused local.
2351 * scroll.c (CHECK_BOUNDS):
2352 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2353 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2354 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2355 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2356 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2357 Now static.
2358 (debug_method_add): Use va_list and vsprintf rather than relying
2359 on undefined behavior with wrong number of arguments.
2360 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2361 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2362 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2363 since we're not interested in debugging glyphs with old libraries.
2364 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2365 GCC 4.6.0's static checking.
2366
2367 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2368
2369 Integer overflow and signedness fixes (Bug#8873).
2370 A few related buffer overrun fixes, too.
2371
2372 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2373
2374 * dispextern.h (struct face.stipple):
2375 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2376 (x_bitmap_mask, x_allocate_bitmap_record)
2377 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2378 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2379 (x_create_bitmap_from_xpm_data):
2380 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2381 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2382 (.bitmaps_last):
2383 * xfaces.c (load_pixmap):
2384 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2385 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2386 (.bitmaps_last, struct x_output.icon_bitmap):
2387 Use ptrdiff_t, not int, for bitmap indexes.
2388 (x_allocate_bitmap_record): Check for size overflow.
2389 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2390
2391 Use ptrdiff_t, not int, for overlay counts.
2392 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2393 * editfns.c (overlays_around, get_pos_property):
2394 * textprop.c (get_char_property_and_overlay):
2395 * xdisp.c (next_overlay_change, note_mouse_highlight):
2396 * xfaces.c (face_at_buffer_position):
2397 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2398 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2399 (Fnext_overlay_change, Fprevious_overlay_change)
2400 (mouse_face_overlay_overlaps, Foverlays_in):
2401 Use ptrdiff_t, not int, for sizes.
2402 (overlays_at, overlays_in): Check for size-calculation overflow.
2403
2404 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2405
2406 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2407 (x_session_initialize): Do not assume string length fits in int.
2408
2409 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2410 This is unlikely, but can occur if DPI is outlandish.
2411
2412 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2413 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2414
2415 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2416 * xrdb.c (magic_file_p, search_magic_path):
2417 Omit last arg SUFFIX; it was always 0. All callers changed.
2418 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2419
2420 * xfont.c (xfont_match): Avoid need for strlen.
2421
2422 * xfns.c: Don't assume strlen fits in int.
2423 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2424
2425 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2426 not unsigned long, as we prefer signed integers. All callers changed.
2427 Detect integer overflow in repeat count.
2428 (message_dolog): Don't assume print length fits in 39 bytes.
2429 (display_mode_element): Don't assume strlen fits in int.
2430
2431 * termcap.c: Don't assume sizes fit in int and never overflow.
2432 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2433 (gobble_line): Check for size-calculation overflow.
2434
2435 * minibuf.c (Fread_buffer):
2436 * lread.c (intern, intern_c_string):
2437 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2438 Don't assume string length fits in int.
2439
2440 * keyboard.c (parse_tool_bar_item):
2441 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2442
2443 * font.c: Don't assume string length fits in int.
2444 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2445 Use ptrdiff_t, not int.
2446 (font_intern_prop): Don't assume string length fits in int.
2447 Don't assume integer property fits in fixnum.
2448 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2449
2450 * filelock.c: Fix some buffer overrun and integer overflow issues.
2451 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2452 Reformulate so as not to need the command string.
2453 Invoke gzip -cd rather than gunzip, as it's more portable.
2454 (lock_info_type, lock_file_1, lock_file):
2455 Don't assume pid_t and time_t fit in unsigned long.
2456 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2457 (current_lock_owner): Prefer signed type for sizes.
2458 Use memcpy, not strncpy, where memcpy is what is really wanted.
2459 Don't assume (via atoi) that time_t and pid_t fit in int.
2460 Check for time_t and/or pid_t out of range, e.g., via a network share.
2461 Don't alloca where an auto var works fine.
2462
2463 * fileio.c: Fix some integer overflow issues.
2464 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2465 Don't assume string length fits in int.
2466 (directory_file_name): Don't assume string length fits in long.
2467 (make_temp_name): Don't assume pid fits in int, or that its print
2468 length is less than 20.
2469
2470 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2471
2472 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2473
2474 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2475
2476 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2477 We prefer signed integers, even for size calculations.
2478
2479 * emacs.c: Don't assume string length fits in 'int'.
2480 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2481 (main): Don't invoke strlen when not needed.
2482
2483 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2484 (XD_DEBUG_MESSAGE): Don't waste a byte.
2485
2486 * callproc.c (getenv_internal_1, getenv_internal)
2487 (Fgetenv_internal):
2488 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2489
2490 * lread.c (invalid_syntax): Omit length argument.
2491 All uses changed. This doesn't fix a bug, but it simplifies the
2492 code away from its former Hollerith-constant appearance, and it's
2493 one less 'int' to worry about when looking at integer-overflow issues.
2494 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2495
2496 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2497 This didn't break anything, but it didn't help either.
2498 It's confusing to put a bogus integer in a place where the actual
2499 value does not matter.
2500 (LIST_END_P): Remove unused macro and its bogus comment.
2501 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2502
2503 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2504 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2505 implementation.
2506 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2507 We prefer signed types, and the value cannot exceed the EMACS_INT
2508 range anyway (because otherwise the length would not be representable).
2509 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2510 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2511 This avoids a GCC warning when WIDE_EMACS_INT.
2512
2513 * indent.c (sane_tab_width): New function.
2514 (current_column, scan_for_column, Findent_to, position_indentation)
2515 (compute_motion): Use it. This is just for clarity.
2516 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2517
2518 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2519
2520 * lisp.h (lint_assume): New macro.
2521 * composite.c (composition_gstring_put_cache):
2522 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2523
2524 * editfns.c, insdel.c:
2525 Omit unnecessary forward decls, to simplify future changes.
2526
2527 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2528
2529 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2530
2531 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2532 Use much-faster test for byte-length change.
2533 Don't assume string byte-length fits in 'int'.
2534 Check that character arg fits in 'int'.
2535 (mapcar1): Declare byte as byte, for clarity.
2536
2537 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2538
2539 * fns.c (concat): Catch string overflow earlier.
2540 Do not rely on integer wraparound.
2541
2542 * dispextern.h (struct it.overlay_strings_charpos)
2543 (struct it.selective): Now EMACS_INT, not int.
2544 * xdisp.c (forward_to_next_line_start)
2545 (back_to_previous_visible_line_start)
2546 (reseat_at_next_visible_line_start, next_element_from_buffer):
2547 Don't arbitrarily truncate the value of 'selective' to int.
2548
2549 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2550
2551 * composite.c: Don't truncate sizes to 'int'.
2552 (composition_gstring_p, composition_reseat_it)
2553 (composition_adjust_point): Use EMACS_INT, not int.
2554 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2555 not EMACS_UINT, for indexes.
2556
2557 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2558
2559 * buffer.c: Include <verify.h>.
2560 (struct sortvec.priority, struct sortstr.priority):
2561 Now EMACS_INT, not int.
2562 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2563 (struct sortstr.size, record_overlay_string)
2564 (struct sortstrlist.size, struct sortlist.used):
2565 Don't truncate size to int.
2566 (record_overlay_string): Check for size-calculation overflow.
2567 (init_buffer_once): Check at compile-time, not run-time.
2568
2569 2011-06-22 Jim Meyering <meyering@redhat.com>
2570
2571 Don't leak an XBM-image-sized buffer
2572 * image.c (xbm_load): Free the image buffer after using it.
2573
2574 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2575
2576 Port to Sun C.
2577 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2578 that Sun C diagnosed.
2579 * fns.c (secure_hash): Fix pointer signedness issue.
2580 * intervals.c (static_offset_intervals): New function.
2581 (offset_intervals): Use it.
2582
2583 2011-06-21 Leo Liu <sdl.web@gmail.com>
2584
2585 * deps.mk (fns.o):
2586 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2587 sha512.h.
2588
2589 * fns.c (secure_hash): Rename from crypto_hash_function and change
2590 the first arg to accept symbols.
2591 (Fsecure_hash): New primitive.
2592 (syms_of_fns): New symbols.
2593
2594 2011-06-20 Deniz Dogan <deniz@dogan.se>
2595
2596 * process.c (Fset_process_buffer): Clarify return value in
2597 docstring.
2598
2599 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2600
2601 * dispnew.c (add_window_display_history): Use BVAR.
2602
2603 * xdisp.c (debug_method_add): Use BVAR.
2604 (check_window_end, dump_glyph_matrix, dump_glyph)
2605 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2606
2607 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2608 Likewise.
2609
2610 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2611 check till after the cache is created in init_frame_faces.
2612
2613 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2614
2615 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2616
2617 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2618
2619 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2620 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2621 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2622
2623 Improve buffer-overflow checking (Bug#8873).
2624 * fileio.c (Finsert_file_contents):
2625 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2626 Remove the old (too-loose) buffer overflow checks.
2627 They weren't needed, since make_gap checks for buffer overflow.
2628 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2629 The old code merely checked for Emacs fixnum overflow, and relied
2630 on undefined (wraparound) behavior. The new code avoids undefined
2631 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2632
2633 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2634 Tune. Don't use wider integers than needed. Don't use alloca.
2635 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2636
2637 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2638
2639 * insdel.c, lisp.h (buffer_overflow): New function.
2640 (insert_from_buffer_1, replace_range, replace_range_2):
2641 * insdel.c (make_gap_larger):
2642 * editfns.c (Finsert_char):
2643 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2644
2645 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2646
2647 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2648
2649 Integer overflow and signedness fixes (Bug#8873).
2650
2651 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2652 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2653
2654 * fileio.c: Don't assume EMACS_INT fits in off_t.
2655 (emacs_lseek): New static function.
2656 (Finsert_file_contents, Fwrite_region): Use it.
2657 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2658
2659 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2660
2661 * fns.c: Don't overflow int when computing a list length.
2662 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2663 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2664 truncation on 64-bit hosts. Check for QUIT every
2665 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2666 faster and is responsive enough.
2667 (Flength): Report an error instead of overflowing an integer.
2668 (Fsafe_length): Return a float if the value is not representable
2669 as a fixnum. This shouldn't happen except in contrived situations.
2670 (Fnthcdr, Fsort): Don't assume list length fits in int.
2671 (Fcopy_sequence): Don't assume vector length fits in int.
2672
2673 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2674 (header_size, word_size): New constants.
2675 (allocate_vectorlike): Don't check size overflow here.
2676 (allocate_vector): Check it here instead, since this is the only
2677 caller of allocate_vectorlike that could cause overflow.
2678 Check that the new vector's length is representable as a fixnum.
2679
2680 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2681 The previous code was bogus. For example, next_almost_prime (32)
2682 returned 39, which is undesirable as it is a multiple of 3; and
2683 next_almost_prime (24) returned 25, which is a multiple of 5 so
2684 why was the code bothering to check for multiples of 7?
2685
2686 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2687
2688 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2689
2690 Variadic C functions now count arguments with ptrdiff_t.
2691 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2692 Back then I didn't know that the Emacs coding style prefers signed int.
2693 Also, in the meantime I found a few more instances where arguments
2694 were being counted with int, which may truncate counts on 64-bit
2695 machines, or EMACS_INT, which may be unnecessarily wide.
2696 * lisp.h (struct Lisp_Subr.function.aMANY)
2697 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2698 Arg counts are now ptrdiff_t, not size_t.
2699 All variadic functions and their callers changed accordingly.
2700 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2701 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2702 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2703 * callint.c (Fcall_interactively): Check arg count for overflow,
2704 to avoid potential buffer overrun. Use signed char, not 'int',
2705 for 'varies' array, so that we needn't bother to check its size
2706 calculation for overflow.
2707 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2708 * eval.c (apply_lambda):
2709 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2710 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2711 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2712
2713 * callint.c (Fcall_interactively): Don't use index var as event count.
2714
2715 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2716 * mem-limits.h (SIZE): Remove; no longer used.
2717
2718 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2719
2720 Remove unnecessary casts.
2721 * xterm.c (x_term_init):
2722 * xfns.c (x_set_border_pixel):
2723 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2724 These aren't needed now that we assume ANSI C.
2725
2726 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2727 It's more likely to cause problems (due to unsigned overflow)
2728 than to cure them.
2729
2730 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2731
2732 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2733
2734 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2735
2736 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2737
2738 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2739
2740 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2741
2742 GLYPH_CODE_FACE returns EMACS_INT, not int.
2743 * dispextern.h (merge_faces):
2744 * xfaces.c (merge_faces):
2745 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2746 Don't assume EMACS_INT fits in int.
2747
2748 * character.h (CHAR_VALID_P): Remove unused parameter.
2749 * fontset.c, lisp.h, xdisp.c: All uses changed.
2750
2751 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2752
2753 * fns.c (concat): Minor tuning based on overflow analysis.
2754 This doesn't fix any bugs. Use int to hold character, instead
2755 of constantly refetching from Emacs object. Use XFASTINT, not
2756 XINT, for value known to be a character. Don't bother comparing
2757 a single byte to 0400, as it's always less.
2758
2759 * floatfns.c (Fexpt):
2760 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2761
2762 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2763 for characters.
2764
2765 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2766
2767 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2768 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2769 incorrectly succeed when S was a string, because 4294967386 was
2770 truncated before it was used.
2771
2772 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2773 Otherwise, an out-of-range integer could cause undefined behavior
2774 on a 64-bit host.
2775
2776 * composite.c: Use int, not EMACS_INT, for characters.
2777 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2778 EMACS_INT, for values that are known to be in character range.
2779 This doesn't fix any bugs but is the usual style inside Emacs and
2780 may generate better code on 32-bit machines.
2781
2782 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2783 This is for reasons similar to the recent CHAR_STRING fix.
2784 * charset.c (Fencode_char): Check that character arg is actually
2785 a character. Pass an int to ENCODE_CHAR.
2786 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2787 wider than 'int', as a compile-time check to prevent future regressions
2788 in this area.
2789
2790 * character.c (char_string): Remove unnecessary casts.
2791
2792 Make sure a 64-bit char is never passed to CHAR_STRING.
2793 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2794 by silently ignoring the top 32 bits, allowing some values
2795 that were far too large to be valid characters.
2796 * character.h: Include <verify.h>.
2797 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2798 arguments are no wider than unsigned, as a compile-time check
2799 to prevent future regressions in this area.
2800 * data.c (Faset):
2801 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2802 (Fsubst_char_in_region):
2803 * fns.c (concat):
2804 * xdisp.c (decode_mode_spec_coding):
2805 Adjust to CHAR_STRING's new requirement.
2806 * editfns.c (Finsert_char, Fsubst_char_in_region):
2807 * fns.c (concat): Check that character args are actually
2808 characters. Without this test, these functions did the wrong
2809 thing with wildly out-of-range values on 64-bit hosts.
2810
2811 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2812 These casts should not be needed on 32-bit hosts, either.
2813 * keyboard.c (read_char):
2814 * lread.c (Fload): Remove casts to unsigned.
2815
2816 * lisp.h (UNSIGNED_CMP): New macro.
2817 This fixes comparison bugs on 64-bit hosts.
2818 (ASCII_CHAR_P): Use it.
2819 * casefiddle.c (casify_object):
2820 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2821 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2822 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2823 * dispextern.h (FACE_FROM_ID):
2824 * keyboard.c (read_char): Use UNSIGNED_CMP.
2825
2826 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2827 not to EMACS_INT, to avoid GCC warning.
2828
2829 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2830
2831 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2832 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2833 isn't needed on 32-bit machines.
2834
2835 * buffer.c (Fgenerate_new_buffer_name):
2836 Use EMACS_INT for count, not int.
2837 (advance_to_char_boundary): Return EMACS_INT, not int.
2838
2839 * data.c (Qcompiled_function): Now static.
2840
2841 * window.c (window_body_lines): Now static.
2842
2843 * image.c (gif_load): Rename local to avoid shadowing.
2844
2845 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2846 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2847 * alloc.c (make_save_value): Integer argument is now of type
2848 ptrdiff_t, not int.
2849 (mark_object): Use ptrdiff_t, not int.
2850 * lisp.h (pD): New macro.
2851 * print.c (print_object): Use it.
2852
2853 * alloc.c: Use EMACS_INT, not int, to count objects.
2854 (total_conses, total_markers, total_symbols, total_vector_size)
2855 (total_free_conses, total_free_markers, total_free_symbols)
2856 (total_free_floats, total_floats, total_free_intervals)
2857 (total_intervals, total_strings, total_free_strings):
2858 Now EMACS_INT, not int. All uses changed.
2859 (Fgarbage_collect): Compute overall total using a double, so that
2860 integer overflow is less likely to be a problem. Check for overflow
2861 when converting back to an integer.
2862 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2863 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2864 These were 'int' variables that could overflow on 64-bit hosts;
2865 they were never used, so remove them instead of repairing them.
2866 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2867 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2868 Previously, this ceilinged at INT_MAX, but that doesn't work on
2869 64-bit machines.
2870 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2871
2872 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2873 (allocate_vectorlike): Check for ptrdiff_t overflow.
2874 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2875 when a (possibly-narrower) signed value would do just as well.
2876 We prefer using signed arithmetic, to avoid comparison confusion.
2877
2878 * alloc.c: Catch some string size overflows that we were missing.
2879 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2880 for convenience in STRING_BYTES_MAX.
2881 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2882 The definition here is exact; the one in lisp.h was approximate.
2883 (allocate_string_data): Check for string overflow. This catches
2884 some instances we weren't catching before. Also, it catches
2885 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2886 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2887 and ptrdiff_t and EMACS_INT are both 64 bits.
2888
2889 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2890 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2891 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2892
2893 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2894
2895 * alloc.c (Fmake_string): Check for out-of-range init.
2896
2897 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2898
2899 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2900
2901 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2902
2903 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2904 xg_get_default_scrollbar_width.
2905
2906 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2907 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2908 (style_changed_cb): Call update_theme_scrollbar_width and call
2909 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2910 all frames (Bug#8505).
2911 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2912 Call gtk_window_set_resizable if HAVE_GTK3.
2913 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2914 and height if HAVE_GTK3 (Bug#8505).
2915 (scroll_bar_width_for_theme): New variable.
2916 (update_theme_scrollbar_width): New function.
2917 (xg_get_default_scrollbar_width): Move code to
2918 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2919 (xg_initialize): Call update_theme_scrollbar_width.
2920
2921 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2922
2923 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2924
2925 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2926
2927 * frame.c (make_frame): Call other_buffer_safely instead of
2928 other_buffer.
2929
2930 * window.c (temp_output_buffer_show): Call display_buffer with
2931 second argument Vtemp_buffer_show_specifiers and reset latter
2932 immediately after the call.
2933 (Vtemp_buffer_show_specifiers): New variable.
2934 (auto_window_vscroll_p, next_screen_context_lines)
2935 (Vscroll_preserve_screen_position): Remove leading asterisks from
2936 doc-strings.
2937
2938 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2939
2940 Fix minor problems found by GCC 4.6.0 static checking.
2941 * buffer.c (Qclone_number): Remove for now, as it's unused.
2942 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2943 (record_buffer): Remove unused local.
2944 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2945 (set_frame_buffer_list): Remove; unused.
2946 * frame.h (other_visible_frames): Remove decl.
2947 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2948 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2949 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2950 if HAVE_GPM.
2951 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2952 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2953 Define only if HAVE_GPM.
2954 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2955 (update_hints_inhibit): Remove; never set. All uses removed.
2956 * widgetprv.h (emacsFrameClassRec): Remove decl.
2957 * window.c (delete_deletable_window): Now returns void, since it
2958 wasn't returning anything.
2959 (compare_window_configurations): Remove unused locals.
2960 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2961 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2962 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2963 the same widths as pointers. This follows up on the 2011-05-06 patch.
2964 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2965 * xterm.h: Likewise.
2966 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2967
2968 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2969
2970 * makefile.w32-in: Update dependencies.
2971 (LISP_H): Add lib/intprops.h.
2972
2973 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2974
2975 * image.c (gif_load): Add animation frame delay to the metadata.
2976 (syms_of_image): Use DEFSYM. New symbol `delay'.
2977
2978 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2979
2980 * window.c (delete_deletable_window): Re-add.
2981 (Fset_window_configuration): Rewrite to handle dead buffers and
2982 consequently deletable windows.
2983 (window_tree, Fwindow_tree): Remove. Supply functionality in
2984 window.el.
2985 (compare_window_configurations): Simplify code.
2986
2987 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2988
2989 * image.c (imagemagick_load_image): Fix type mismatch.
2990 (Fimagemagick_types): Likewise.
2991
2992 * window.h (replace_buffer_in_windows): Declare.
2993
2994 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2995
2996 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2997 Qclone_number. Remove external declaration of Qdelete_window.
2998 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2999 code.
3000 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3001 Run Qbuffer_list_update_hook if allowed.
3002 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3003 buffer list implementation.
3004 (other_buffer_safely): New function.
3005 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3006 calls to replace_buffer_in_windows and
3007 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3008 if allowed.
3009 (record_buffer): Inhibit quitting and rewrite using quittable
3010 functions. Run Qbuffer_list_update_hook if allowed.
3011 (Frecord_buffer, Funrecord_buffer): New functions.
3012 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3013 Move switch-to-buffer to window.el.
3014 (bury-buffer): Move to window.el.
3015 (Vbuffer_list_update_hook): New variable.
3016
3017 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3018 section.
3019
3020 * window.h (resize_frame_windows): Move up in code.
3021 (Fwindow_frame): Remove EXFUN.
3022 (replace_buffer_in_all_windows): Remove prototype.
3023 (replace_buffer_in_windows_safely): Add prototype.
3024
3025 * window.c: Declare Qdelete_window static again. Move down
3026 declaration of select_count.
3027 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3028 (Fother_window): Move to window.el.
3029 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3030 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3031 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3032 window.el.
3033 (replace_buffer_in_windows): Implement by calling
3034 Qreplace_buffer_in_windows.
3035 (replace_buffer_in_all_windows): Remove with some functionality
3036 moved into replace_buffer_in_windows_safely.
3037 (replace_buffer_in_windows_safely): New function.
3038 (select_window_norecord, select_frame_norecord): Move in front
3039 of run_window_configuration_change_hook. Remove now obsolete
3040 declarations.
3041 (Fset_window_buffer): Rewrite doc-string.
3042 Call Qrecord_window_buffer.
3043 (keys_of_window): Move binding for other-window to window.el.
3044
3045 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3046
3047 * dispextern.h (struct image): Replace data member, whose int_val
3048 and ptr_val fields were not used by anything, with a single
3049 lisp_val object.
3050
3051 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3052 (gif_clear_image, gif_load, imagemagick_load_image)
3053 (gs_clear_image, gs_load): Callers changed.
3054
3055 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3056
3057 * buffer.h: Include <time.h>, for time_t.
3058 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3059
3060 Fix minor problems found by static checking.
3061
3062 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3063
3064 Make identifiers static if they are not used in other modules.
3065 * data.c (Qcompiled_function, Qframe, Qvector):
3066 * image.c (QimageMagick, Qsvg):
3067 * minibuf.c (Qmetadata):
3068 * window.c (resize_window_check, resize_root_window): Now static.
3069 * window.h (resize_window_check, resize_root_window): Remove decls.
3070
3071 * window.c (window_deletion_count, delete_deletable_window):
3072 Remove; unused.
3073 (window_body_lines): Now static.
3074 (Fdelete_other_windows_internal): Mark vars as initialized.
3075 Make sure 'resize_failed' is initialized.
3076 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3077 (resize_window_apply): Remove unused local.
3078 * window.h (delete_deletable_window): Remove decl.
3079
3080 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3081 (imagemagick_load_image): Fix pointer signedness problem by changing
3082 last arg from unsigned char * to char *. All uses changed.
3083 Also, fix a local for similar reasons.
3084 Remove unused locals. Remove locals to avoid shadowing.
3085 (fn_rsvg_handle_free): Remove; unused.
3086 (svg_load, svg_load_image): Fix pointer signedness problem.
3087 (imagemagick_load_image): Don't use garbage pointer image_wand.
3088
3089 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3090
3091 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3092
3093 * image.c (gif_load): Fix omitted cast error introduced by
3094 2011-06-06 change.
3095
3096 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3097
3098 * window.h (resize_proportionally, orig_total_lines)
3099 (orig_top_line): Remove from window structure.
3100 (set_window_height, set_window_width, change_window_heights)
3101 (Fdelete_window): Remove prototypes.
3102 (resize_frame_windows): Remove duplicate declaration.
3103
3104 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3105
3106 * window.h (resize_frame_windows, resize_window_check)
3107 (delete_deletable_window, resize_root_window)
3108 (resize_frame_windows): Declare prototypes.
3109
3110 * window.c (resize_window_apply): Make definition be "static" to
3111 match the prototype.
3112
3113 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3114
3115 * window.c: Remove declarations of Qwindow_size_fixed,
3116 window_min_size_1, window_min_size_2, window_min_size,
3117 size_window, window_fixed_size_p, enlarge_window, delete_window.
3118 Remove static from declaration of Qdelete_window, it's
3119 temporarily needed by Fbury_buffer.
3120 (replace_window): Don't assign orig_top_line and
3121 orig_total_lines.
3122 (Fdelete_window, delete_window): Remove. Window deletion is
3123 handled by window.el.
3124 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3125 Replace Fdelete_window calls with calls to Qdelete_window.
3126 (Fdelete_other_windows): Remove. Deleting other windows is
3127 handled by window.el.
3128 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3129 handled in window.el.
3130 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3131 Window minimum sizes are handled in window.el.
3132 (shrink_windows, size_window, set_window_height)
3133 (set_window_width, change_window_heights, window_height)
3134 (window_width, CURBEG, CURSIZE, enlarge_window)
3135 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3136 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3137 handled in window.el.
3138 (make_dummy_parent): Rename to make_parent_window and give it a
3139 second argument horflag.
3140 (make_window): Don't set resize_proportionally any more.
3141 (Fsplit_window): Remove. Windows are split in window.el.
3142 (save_restore_action, save_restore_orig_size)
3143 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3144 Resize mini windows in window.el.
3145 (grow_mini_window, shrink_mini_window): Implement by calling
3146 Qresize_root_window_vertically, resize_window_check and
3147 resize_window_apply.
3148 (saved_window, Fset_window_configuration, save_window_save):
3149 Do not handle orig_top_line, orig_total_lines, and
3150 resize_proportionally.
3151 (window_min_height, window_min_width): Move to window.el.
3152 (keys_of_window): Move bindings for delete-other-windows,
3153 split-window, delete-window and enlarge-window to window.el.
3154
3155 * buffer.c: Temporarily extern Qdelete_window.
3156 (Fbury_buffer): Temporarily call Qdelete_window instead of
3157 Fdelete_window (Fbury_buffer will move to window.el soon).
3158
3159 * frame.c (set_menu_bar_lines_1): Remove code handling
3160 orig_top_line and orig_total_lines.
3161
3162 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3163 set_window_height but set heights directly.
3164 (change_frame_size_1): Use resize_frame_windows.
3165
3166 * xdisp.c (init_xdisp): Don't use set_window_height but set
3167 heights directly.
3168
3169 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3170 Use resize_frame_windows instead of change_window_heights and run
3171 run_window_configuration_change_hook.
3172
3173 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3174 instead of change_window_heights and run
3175 run_window_configuration_change_hook.
3176
3177 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3178
3179 * window.c (replace_window): Rename second argument REPLACEMENT to
3180 NEW. New third argument SETFLAG. Rewrite.
3181 (delete_window, make_dummy_parent): Call replace_window with
3182 third argument 1.
3183 (window_list_1): Move down in code.
3184 (run_window_configuration_change_hook): Move set_buffer part
3185 before select_frame_norecord part in order to unwind correctly.
3186 Rename count1 to count.
3187 (recombine_windows, delete_deletable_window, resize_root_window)
3188 (Fdelete_other_windows_internal)
3189 (Frun_window_configuration_change_hook, make_parent_window)
3190 (resize_window_check, resize_window_apply, Fresize_window_apply)
3191 (resize_frame_windows, Fsplit_window_internal)
3192 (Fdelete_window_internal, Fresize_mini_window_internal):
3193 New functions.
3194 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3195
3196 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3197
3198 * window.h (window): Add some new members to window structure -
3199 normal_lines, normal_cols, new_total, new_normal, clone_number,
3200 splits, nest, prev_buffers, next_buffers.
3201 (WINDOW_TOTAL_SIZE): Move here from window.c.
3202 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3203
3204 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3205 Remove.
3206 (make_dummy_parent): Set new members of windows structure.
3207 (make_window): Move down in code. Handle new members of window
3208 structure.
3209 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3210 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3211 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3212 (Fset_window_prev_buffers, Fwindow_next_buffers)
3213 (Fset_window_next_buffers, Fset_window_clone_number):
3214 New functions.
3215 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3216 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3217 Doc-string fixes.
3218 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3219 Argument WINDOW can be now internal window too.
3220 (Fwindow_use_time): Move up in code.
3221 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3222 Rewrite doc-string.
3223 (Fset_window_configuration, saved_window)
3224 (Fcurrent_window_configuration, save_window_save): Handle new
3225 members of window structure.
3226 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3227 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3228 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3229 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3230 Qget_mru_window, Qresize_root_window,
3231 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3232 Qauto_buffer_name; staticpro them.
3233
3234 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3235
3236 * window.c (Fwindow_total_size, Fwindow_left_column)
3237 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3238 (Fwindow_list_1): New functions.
3239 (window_box_text_cols): Replace with window_body_cols.
3240 (Fwindow_width, Fscroll_left, Fscroll_right):
3241 Use window_body_cols instead of window_box_text_cols.
3242 (delete_window, Fset_window_configuration):
3243 Call delete_all_subwindows with window as argument.
3244 (delete_all_subwindows): Take a window as argument and not a
3245 structure. Rewrite.
3246 (window_loop): Remove handling of GET_LRU_WINDOW and
3247 GET_LARGEST_WINDOW.
3248 (Fget_lru_window, Fget_largest_window): Move to window.el.
3249
3250 * window.h: Extern window_body_cols instead of
3251 window_box_text_cols. delete_all_subwindows now takes a
3252 Lisp_Object as argument.
3253
3254 * indent.c (compute_motion, Fcompute_motion):
3255 Use window_body_cols instead of window_box_text_cols.
3256
3257 * frame.c (delete_frame): Call delete_all_subwindows with root
3258 window as argument.
3259
3260 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3261
3262 * fns.c (Fputhash): Document return value.
3263
3264 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3265
3266 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3267
3268 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3269
3270 Cons<->int and similar integer overflow fixes (Bug#8794).
3271
3272 Check for overflow when converting integer to cons and back.
3273 * charset.c (Fdefine_charset_internal, Fdecode_char):
3274 Use cons_to_unsigned to catch overflow.
3275 (Fencode_char): Use INTEGER_TO_CONS.
3276 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3277 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3278 * data.c (long_to_cons, cons_to_long): Remove.
3279 (cons_to_unsigned, cons_to_signed): New functions.
3280 These signal an error for invalid or out-of-range values.
3281 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3282 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3283 * font.c (Ffont_variation_glyphs):
3284 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3285 * lisp.h: Include <intprops.h>.
3286 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3287 (cons_to_signed, cons_to_unsigned): New decls.
3288 (long_to_cons, cons_to_long): Remove decls.
3289 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3290 (Fprimitive_undo): Use CONS_TO_INTEGER.
3291 * xfns.c (Fx_window_property): Likewise.
3292 * xselect.c: Include <limits.h>.
3293 (x_own_selection, selection_data_to_lisp_data):
3294 Use INTEGER_TO_CONS.
3295 (x_handle_selection_request, x_handle_selection_clear)
3296 (x_get_foreign_selection, Fx_disown_selection_internal)
3297 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3298 (lisp_data_to_selection_data): Use cons_to_unsigned.
3299 (x_fill_property_data): Use cons_to_signed.
3300 Report values out of range.
3301
3302 Check for buffer and string overflow more precisely.
3303 * buffer.h (BUF_BYTES_MAX): New macro.
3304 * lisp.h (STRING_BYTES_MAX): New macro.
3305 * alloc.c (Fmake_string):
3306 * character.c (string_escape_byte8):
3307 * coding.c (coding_alloc_by_realloc):
3308 * doprnt.c (doprnt):
3309 * editfns.c (Fformat):
3310 * eval.c (verror):
3311 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3312 since they may not be the same number.
3313 * editfns.c (Finsert_char):
3314 * fileio.c (Finsert_file_contents):
3315 Likewise for BUF_BYTES_MAX.
3316
3317 * image.c: Use ptrdiff_t, not int, for sizes.
3318 (slurp_file): Switch from int to ptrdiff_t.
3319 All uses changed.
3320 (slurp_file): Check that file size fits in both size_t (for
3321 malloc) and ptrdiff_t (for sanity and safety).
3322
3323 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3324 if b->modtime has its maximal value.
3325
3326 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3327
3328 Don't assume time_t can fit into int.
3329 * buffer.h (struct buffer.modtime): Now time_t, not int.
3330 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3331 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3332
3333 Minor fixes for signed vs unsigned integers.
3334 * character.h (MAYBE_UNIFY_CHAR):
3335 * charset.c (maybe_unify_char):
3336 * keyboard.c (read_char, reorder_modifiers):
3337 XINT -> XFASTINT, since the integer must be nonnegative.
3338 * ftfont.c (ftfont_spec_pattern):
3339 * keymap.c (access_keymap, silly_event_symbol_error):
3340 XUINT -> XFASTINT, since the integer must be nonnegative.
3341 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3342 since it makes no difference and we prefer signed.
3343 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3344 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3345 nonnegative.
3346
3347 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3348
3349 * window.h (Fwindow_frame): Declare.
3350
3351 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3352
3353 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3354 (SPARE_MEMORY): Always define.
3355 (LARGE_REQUEST): Remove.
3356 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3357
3358 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3359
3360 * lisp.h: Move EXFUNS for Fframe_root_window,
3361 Fframe_first_window and Fset_frame_selected_window to window.h.
3362
3363 * window.h: Move EXFUNS for Fframe_root_window,
3364 Fframe_first_window and Fset_frame_selected_window here from
3365 lisp.h.
3366
3367 * frame.c (Fwindow_frame, Fframe_first_window)
3368 (Fframe_root_window, Fframe_selected_window)
3369 (Fset_frame_selected_window): Move to window.c.
3370 (Factive_minibuffer_window): Move to minibuf.c.
3371 (Fother_visible_frames_p): New function.
3372
3373 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3374
3375 * window.c (decode_window, decode_any_window): Move up in code.
3376 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3377 (inhibit_frame_unsplittable): Remove unused variable.
3378 (Fwindow_buffer): Move up and rewrite doc-string.
3379 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3380 (Fwindow_prev): New functions.
3381 (Fwindow_frame): Move here from frame.c. Accept any window as
3382 argument.
3383 (Fframe_root_window, Fframe_first_window)
3384 (Fframe_selected_window): Move here from frame.c. Accept frame
3385 or arbitrary window as argument. Update doc-strings.
3386 (Fminibuffer_window): Move up in code.
3387 (Fwindow_minibuffer_p): Move up in code and simplify.
3388 (Fset_frame_selected_window): Move here from frame.c.
3389 Marginal rewrite.
3390 (Fselected_window, select_window, Fselect_window): Move up in
3391 code. Minor doc-string fixes.
3392
3393 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3394
3395 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3396 Do not assume that spare memory exists; that assumption is valid
3397 only if SYSTEM_MALLOC.
3398 (LARGE_REQUEST): New macro, so that the issue of large requests
3399 is separated from the issue of spare memory.
3400
3401 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3402
3403 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3404 format. (Bug#8806)
3405
3406 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3407
3408 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3409 before statements.
3410
3411 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3412
3413 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3414
3415 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3416
3417 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3418 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3419
3420 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3421
3422 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3423
3424 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3425
3426 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3427 (x_clipboard_manager_save): Add return value.
3428 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3429 New error handlers.
3430 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3431 Obey Vx_select_enable_clipboard_manager. Catch errors in
3432 x_clipboard_manager_save (Bug#8779).
3433 (Vx_select_enable_clipboard_manager): New variable.
3434 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3435
3436 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3437
3438 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3439
3440 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3441
3442 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3443 in the current matrix if keep_current_p is non-zero.
3444
3445 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3446
3447 * bidi.c (bidi_level_of_next_char): Fix last change.
3448
3449 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3450
3451 Support bidi reordering of text covered by display properties.
3452
3453 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3454 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3455 (bidi_cache_search, bidi_cache_iterator_state)
3456 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3457 (bidi_level_of_next_char, bidi_move_to_visually_next):
3458 Support character positions inside a run of characters covered by a
3459 display string.
3460 (bidi_paragraph_init, bidi_resolve_explicit_1)
3461 (bidi_level_of_next_char): Call bidi_fetch_char and
3462 bidi_fetch_char_advance instead of FETCH_CHAR and
3463 FETCH_CHAR_ADVANCE.
3464 (bidi_init_it): Initialize new members.
3465 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3466 definitions.
3467 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3468 instead of using explicit *_CHAR codes.
3469 (bidi_resolve_explicit, bidi_resolve_weak):
3470 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3471 bidirectional text is supported only in multibyte buffers.
3472 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3473 it to initialize the frame_window_p member of struct bidi_it.
3474 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3475 (bidi_resolve_explicit, bidi_resolve_weak)
3476 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3477 bidi_it->nchars is non-positive.
3478 (bidi_level_of_next_char): Don't try to lookup the cache for the
3479 next/previous character if nothing is cached there yet, or if we
3480 were just reseat()'ed to a new position.
3481
3482 * xdisp.c (set_cursor_from_row): Set start and stop points
3483 according to the row's direction when priming the loop that looks
3484 for the glyph on which to display cursor.
3485 (single_display_spec_intangible_p): Function deleted.
3486 (display_prop_intangible_p): Reimplement to call
3487 handle_display_spec instead of single_display_spec_intangible_p.
3488 Accept 3 additional arguments needed by handle_display_spec.
3489 This fixes incorrect cursor motion across display property with complex
3490 values: lists, `(when COND...)' forms, etc.
3491 (single_display_spec_string_p): Support property values that are
3492 lists with the argument STRING its top-level element.
3493 (display_prop_string_p): Fix the condition for processing a
3494 property that is a list to be consistent with handle_display_spec.
3495 (handle_display_spec): New function, refactored from the
3496 last portion of handle_display_prop.
3497 (compute_display_string_pos): Accept additional argument
3498 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3499 value of a `display' property is a "replacing spec".
3500 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3501 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3502 the display property, but just return a value indicating whether
3503 the display property will replace the characters it covers.
3504 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3505 frame_window_p members of struct bidi_it.
3506 (compute_display_string_pos, compute_display_string_end):
3507 New functions.
3508 (push_it): Accept second argument POSITION, where pop_it should
3509 jump to continue iteration.
3510 (reseat_1): Initialize bidi_it.disp_pos.
3511
3512 * keyboard.c (adjust_point_for_property): Adjust the call to
3513 display_prop_intangible_p to its new signature.
3514
3515 * dispextern.h (struct bidi_it): New member frame_window_p.
3516 (bidi_init_it): Update prototypes.
3517 (display_prop_intangible_p): Update prototype.
3518 (compute_display_string_pos, compute_display_string_end):
3519 Declare prototypes.
3520 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3521 EMACS_INT.
3522
3523 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3524
3525 Malloc failure behavior now depends on size of allocation.
3526 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3527 * lisp.h: Change signatures accordingly.
3528 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3529 All callers changed. (Bug#8762)
3530
3531 * gnutls.c: Use Emacs's memory allocators.
3532 Without this change, the gnutls library would invoke malloc etc.
3533 directly, which causes problems on non-SYNC_INPUT hosts, and which
3534 runs afoul of improving memory_full behavior. (Bug#8761)
3535 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3536 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3537 xfree instead of the default malloc, realloc, free.
3538 (Fgnutls_boot): No need to check for memory allocation failure,
3539 since xmalloc does that for us.
3540
3541 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3542 * category.c (hash_get_category_set):
3543 * ccl.c (ccl_driver):
3544 * charset.c (Fdefine_charset_internal):
3545 * charset.h (struct charset.hash_index):
3546 * composite.c (get_composition_id, gstring_lookup_cache)
3547 (composition_gstring_put_cache):
3548 * composite.h (struct composition.hash_index):
3549 * dispextern.h (struct image.hash):
3550 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3551 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3552 (hashfn_equal, hashfn_user_defined, make_hash_table)
3553 (maybe_resize_hash_table, hash_lookup, hash_put)
3554 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3555 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3556 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3557 * image.c (make_image, search_image_cache, lookup_image)
3558 (xpm_put_color_table_h):
3559 * lisp.h (struct Lisp_Hash_Table):
3560 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3561 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3562 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3563 * alloc.c (allocate_vectorlike):
3564 Check for overflow in vector size calculations.
3565 * ccl.c (ccl_driver):
3566 Check for overflow when converting EMACS_INT to int.
3567 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3568 need to be updated by these changes.
3569 * fns.c (make_hash_table, maybe_resize_hash_table):
3570 Check for integer overflow with large hash tables.
3571 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3572 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3573 (SXHASH_REDUCE): New macro.
3574 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3575 Use it instead of discarding useful hash info with large hash values.
3576 (sxhash_float): New function.
3577 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3578 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3579 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3580 Rewrite to use FIXNUM_BITS, as this simplifies things.
3581 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3582 Adjust signatures to match updated version of code.
3583 (consing_since_gc): Now EMACS_INT, since a single hash table can
3584 use more than INT_MAX bytes.
3585
3586 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3587
3588 Make it possible to build with GCC-4.6+ -O2 -flto.
3589
3590 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3591
3592 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3593
3594 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3595 Call minibuffer-inactive-mode.
3596
3597 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3598
3599 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3600 Update dependencies.
3601
3602 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3603
3604 * data.c (init_data): Remove code for UTS, this system is not
3605 supported anymore.
3606
3607 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3608
3609 Don't force ./temacs to start in terminal mode.
3610
3611 * frame.c (make_initial_frame): Initialize faces in all cases, not
3612 only when CANNOT_DUMP is defined.
3613 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3614
3615 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3616
3617 * dispnew.c (add_window_display_history): Use const for the string
3618 pointer. Remove declaration, not needed.
3619
3620 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3621
3622 Use 'inline', not 'INLINE'.
3623 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3624 * alloc.c, fontset.c (INLINE): Remove.
3625 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3626 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3627 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3628 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3629 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3630
3631 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3632
3633 Make it possible to run ./temacs.
3634
3635 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3636 syms_of_callproc does the same thing. Remove test for
3637 "initialized", do it in the caller.
3638 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3639
3640 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3641
3642 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3643 (read_minibuf): Use get_minibuffer.
3644 (syms_of_minibuf): Use DEFSYM.
3645 (Qmetadata): New var.
3646 * data.c (Qbuffer): Don't make it static.
3647 (syms_of_data): Use DEFSYM.
3648
3649 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3650
3651 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3652 (CCL_CODE_MIN): New macro.
3653
3654 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3655
3656 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3657
3658 * eval.c (Qdebug): Now static.
3659 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3660 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3661 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3662
3663 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3664
3665 * image.c: Various fixes to ImageMagick code comments.
3666 (Fimagemagick_types): Doc fix.
3667
3668 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3669
3670 Minor fixes prompted by GCC 4.6.0 warnings.
3671
3672 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3673
3674 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3675 (x_clipboard_manager_save_all): Move extern decl to ...
3676 * xterm.h: ... here, so that it can be checked for consistency.
3677
3678 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3679
3680 * xselect.c (x_clipboard_manager_save_frame)
3681 (x_clipboard_manager_save_all): New functions.
3682 (Fx_clipboard_manager_save): Lisp function deleted.
3683
3684 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3685 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3686
3687 * xterm.h: Update prototype.
3688
3689 2011-05-28 William Xu <william.xwl@gmail.com>
3690
3691 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3692 exiting (Bug#8239).
3693
3694 2011-05-28 Jim Meyering <meyering@redhat.com>
3695
3696 Avoid a sign-extension bug in crypto_hash_function.
3697 * fns.c (to_uchar): Define.
3698 (crypto_hash_function): Use it to convert some newly-signed
3699 variables to unsigned, to avoid sign-extension bugs. For example,
3700 without this change, (md5 "truc") would evaluate to
3701 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3702 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3703 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3704
3705 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3706
3707 Integer overflow fixes.
3708
3709 * dbusbind.c: Serial number integer overflow fixes.
3710 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3711 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3712 to hold a serial number that is too large for a fixnum.
3713 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3714 Check for serial numbers out of range. Decode any serial number
3715 that was so large that it became a float. (Bug#8722)
3716
3717 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3718 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3719 Use XFASTINT rather than XUINT when numbers are nonnegative.
3720 (xd_append_arg, Fdbus_method_return_internal):
3721 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3722 arguments, check that Lisp number is nonnegative, rather than
3723 silently wrapping negative numbers around. (Bug#8722)
3724 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3725 (Bug#8722)
3726
3727 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3728
3729 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3730
3731 ccl: add integer overflow checks
3732 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3733 (IN_INT_RANGE): New macros.
3734 (ccl_driver): Use them to check for integer overflow when
3735 decoding a CCL program. Many of the new checks are whether XINT (x)
3736 fits in int; it doesn't always, on 64-bit hosts. The new version
3737 doesn't catch all possible integer overflows, but it's an
3738 improvement. (Bug#8719)
3739
3740 * alloc.c (make_event_array): Use XINT, not XUINT.
3741 There's no need for unsigned here.
3742
3743 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3744 This follows up to the 2011-05-06 change that substituted uintptr_t
3745 for EMACS_INT. This case wasn't caught back then.
3746
3747 Rework Fformat to avoid integer overflow issues.
3748 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3749 now (part of C89). Include <verify.h>.
3750 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3751 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3752 (Fformat): Avoid the prepass trying to compute sizes; it was only
3753 approximate and thus did not catch overflow reliably. Instead, walk
3754 through the format just once, formatting and computing sizes as we go,
3755 checking for integer overflow at every step, and allocating a larger
3756 buffer as needed. Keep track separately whether the format is
3757 multibyte. Keep only the most-recently calculated precision, rather
3758 than them all. Record whether each argument has been converted to
3759 string. Use EMACS_INT, not int, for byte and char and arg counts.
3760 Support field widths and precisions larger than INT_MAX. Avoid
3761 sprintf's undefined behavior with conversion specifications such as %#d
3762 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3763 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3764 formatting out-of-range floating point numbers with int
3765 formats. (Bug#8668)
3766
3767 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3768
3769 * data.c: Avoid integer truncation in expressions involving floats.
3770 * data.c: Include <intprops.h>.
3771 (arith_driver): When there's an integer overflow in an expression
3772 involving floating point, convert the integers to floating point
3773 so that the resulting value does not suffer from catastrophic
3774 integer truncation. For example, on a 64-bit host (* 4
3775 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3776 Do not rely on undefined behavior after integer overflow.
3777
3778 merge count_size_as_multibyte, parse_str_to_multibyte
3779 * character.c, character.h (count_size_as_multibyte):
3780 Rename from parse_str_to_multibyte; all uses changed.
3781 Check for integer overflow.
3782 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3783 since it's now a duplicate of the other. This is more of
3784 a character than a buffer op, so better that it's in character.c.
3785 * fns.c, print.c: Adjust to above changes.
3786
3787 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3788
3789 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3790
3791 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3792
3793 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3794 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3795 (x_clipboard_manager_save): Now static.
3796 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3797
3798 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3799 (crypto_hash_function): Now static.
3800 Fix pointer signedness problems. Avoid unnecessary initializations.
3801
3802 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3803
3804 * termhooks.h (Vselection_alist): Make it terminal-local.
3805
3806 * terminal.c (create_terminal): Initialize it.
3807
3808 * xselect.c: Support for clipboard managers.
3809 (Vselection_alist): Move to termhooks.h as terminal-local var.
3810 (LOCAL_SELECTION): New macro.
3811 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3812 (symbol_to_x_atom): Remove gratuitous arg.
3813 (x_handle_selection_request, lisp_data_to_selection_data)
3814 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3815 (x_own_selection, x_get_local_selection, x_convert_selection):
3816 New arg, specifying work frame. Use terminal-local Vselection_alist.
3817 (some_frame_on_display): Delete unused function.
3818 (Fx_own_selection_internal, Fx_get_selection_internal)
3819 (Fx_disown_selection_internal, Fx_selection_owner_p)
3820 (Fx_selection_exists_p): New optional frame arg.
3821 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3822 (x_handle_selection_clear): Don't treat other terminals with the
3823 same keyboard specially. Use the terminal-local Vselection_alist.
3824 (x_clear_frame_selections): Use Frun_hook_with_args.
3825
3826 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3827
3828 * xterm.h: Add support for those atoms.
3829
3830 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3831
3832 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3833 (converted_selections, conversion_fail_tag): New global variables.
3834 (x_selection_request_lisp_error): Free the above.
3835 (x_get_local_selection): Remove unnecessary code.
3836 (x_reply_selection_request): Args changed; handle arbitrary array
3837 of converted selections stored in converted_selections.
3838 Separate the XChangeProperty and SelectionNotify steps.
3839 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3840 (x_convert_selection): New function.
3841 (x_handle_selection_event): Simplify.
3842 (x_get_foreign_selection): Don't ignore incoming requests while
3843 waiting for an answer; this will fail when we implement
3844 SAVE_TARGETS, and seems unnecessary anyway.
3845 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3846 (Vx_sent_selection_functions): Doc fix.
3847
3848 2011-05-26 Leo Liu <sdl.web@gmail.com>
3849
3850 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3851
3852 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3853
3854 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3855
3856 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3857 for fringe update if it has periodic bitmap.
3858 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3859 and fringe_bitmap_periodic_p.
3860
3861 * fringe.c (get_fringe_bitmap_data): New function.
3862 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3863 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3864 row. Mark glyph row for fringe update if periodicity changed.
3865
3866 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3867 for fringe update unless it has periodic bitmap.
3868
3869 2011-05-25 Kenichi Handa <handa@m17n.org>
3870
3871 * xdisp.c (get_next_display_element): Set correct it->face_id for
3872 a static composition.
3873
3874 2011-05-24 Leo Liu <sdl.web@gmail.com>
3875
3876 * deps.mk (fns.o):
3877 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3878
3879 * fns.c (crypto_hash_function, Fsha1): New function.
3880 (Fmd5): Use crypto_hash_function.
3881 (syms_of_fns): Add Ssha1.
3882
3883 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3884
3885 * gnutls.c: Remove unused macros.
3886 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3887 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3888 Remove macros that are defined and never used.
3889 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3890
3891 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3892
3893 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3894 (Fx_get_selection_internal): Minor cleanup.
3895 (Fx_own_selection_internal): Rename arguments for consistency with
3896 select.el.
3897
3898 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3899
3900 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3901
3902 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3903
3904 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3905
3906 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3907
3908 * dispnew.c (scrolling_window): Don't exclude the case that the
3909 last enabled row in the desired matrix touches the bottom boundary.
3910
3911 2011-05-21 Glenn Morris <rgm@gnu.org>
3912
3913 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3914 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3915 and add some more files.
3916
3917 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3918
3919 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3920 report_file_error introduced by the change from 2011-05-07.
3921
3922 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3923
3924 * systime.h (Time): Define only if emacs is defined.
3925 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3926 where the include path doesn't have X11/X.h by default. See
3927 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3928
3929 2011-05-20 Kenichi Handa <handa@m17n.org>
3930
3931 * composite.c (find_automatic_composition): Fix previous change.
3932
3933 2011-05-20 Glenn Morris <rgm@gnu.org>
3934
3935 * lisp.mk: New file, split from Makefile.in.
3936 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3937 (shortlisp): Remove.
3938 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3939
3940 2011-05-19 Glenn Morris <rgm@gnu.org>
3941
3942 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3943 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3944 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3945 (lisp): Set the order to that of loadup.el.
3946 (shortlisp): Make it a copy of $lisp.
3947 (SOME_MACHINE_LISP): Remove.
3948 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3949 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3950
3951 2011-05-18 Kenichi Handa <handa@m17n.org>
3952
3953 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3954 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3955 (find_automatic_composition): Mostly rewrite for efficiency.
3956
3957 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3958
3959 * makefile.w32-in: Update dependencies.
3960
3961 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3962
3963 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3964 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3965
3966 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3967
3968 Fix some integer overflow issues, such as string length overflow.
3969
3970 * insdel.c (count_size_as_multibyte): Check for string overflow.
3971
3972 * character.c (lisp_string_width): Check for string overflow.
3973 Use EMACS_INT, not int, for string indexes and lengths; in
3974 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3975 the resulting string length overflows an EMACS_INT; instead,
3976 report a string overflow if no precision given. When checking for
3977 precision exhaustion, use a check that cannot possibly have
3978 integer overflow. (Bug#8675)
3979 * character.h (lisp_string_width): Adjust to new signature.
3980
3981 * alloc.c (string_overflow): New function.
3982 (Fmake_string): Use it. This doesn't change behavior, but saves
3983 a few bytes and will simplify future changes.
3984 * character.c (string_escape_byte8): Likewise.
3985 * lisp.h (string_overflow): New decl.
3986
3987 Fixups, following up to the user-interface timestamp change.
3988 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3989 for UI timestamps, instead of unsigned long.
3990 * msdos.c (mouse_get_pos): Likewise.
3991 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3992 * w32gui.h (Time): Define by including "systime.h" rather than by
3993 declaring it ourselves. (Bug#8664)
3994
3995 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3996 * image.c (clear_image_cache): Likewise.
3997
3998 * term.c (term_mouse_position): Don't assume time_t wraparound.
3999
4000 Be more systematic about user-interface timestamps.
4001 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4002 and sometimes 'EMACS_UINT', to represent these timestamps.
4003 This change causes it to use 'Time' uniformly, as that's what X uses.
4004 This makes the code easier to follow, and makes it easier to catch
4005 integer overflow bugs such as Bug#8664.
4006 * frame.c (Fmouse_position, Fmouse_pixel_position):
4007 Use Time, not unsigned long, for user-interface timestamps.
4008 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4009 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4010 * keyboard.h (last_event_timestamp): Likewise.
4011 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4012 * menu.h (xmenu_show): Likewise.
4013 * term.c (term_mouse_position): Likewise.
4014 * termhooks.h (struct input_event.timestamp): Likewise.
4015 (struct terminal.mouse_position_hook): Likewise.
4016 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4017 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4018 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4019 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4020 what it was before.
4021 * menu.h, termhooks.h: Include "systime.h", for Time.
4022
4023 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4024 Don't assume that the difference between two unsigned long values
4025 can fit into an integer. At this point, we know button_down_time
4026 <= event->timestamp, so the difference must be nonnegative, so
4027 there's no need to cast the result if double-click-time is
4028 nonnegative, as it should be; check that it's nonnegative, just in
4029 case. This bug is triggered when events are more than 2**31 ms
4030 apart (about 25 days). (Bug#8664)
4031
4032 * xselect.c (last_event_timestamp): Remove duplicate decl.
4033 (x_own_selection): Remove needless cast to unsigned long.
4034
4035 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4036 that always fit in int. Use a sentinel instead of a counter, to
4037 avoid a temp and to allay GCC's concerns about possible int overflow.
4038 * frame.h (struct frame): Use int for menu_bar_items_used
4039 instead of EMACS_INT, since it always fits in int.
4040
4041 * menu.c (grow_menu_items): Check for int overflow.
4042
4043 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4044
4045 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4046 Before, the code was not consistent. These values cannot exceed
4047 2**31 - 1 so there's no need to make them unsigned.
4048 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4049 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4050 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4051 as modifiers.
4052 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4053
4054 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4055 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4056 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4057 presumably because the widths might not match.
4058
4059 * window.c (size_window): Avoid needless test at loop start.
4060
4061 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4062
4063 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4064
4065 2011-05-12 Drew Adams <drew.adams@oracle.com>
4066
4067 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4068
4069 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4070
4071 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4072 `width' to `bar_area_x' and `bar_area_width', respectively.
4073 (x_scroll_run): Take account of fringe background extension.
4074
4075 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4076 Rename local vars `left' and `width' to `bar_area_x' and
4077 `bar_area_width', respectively.
4078 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4079 background extension.
4080
4081 2011-05-10 Jim Meyering <meyering@redhat.com>
4082
4083 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4084
4085 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4086
4087 * image.c (Finit_image_library): Return t for built-in image types,
4088 like pbm and xbm. (Bug#8640)
4089
4090 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4091
4092 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4093
4094 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4095
4096 * w32console.c (Fset_screen_color): Doc fix.
4097 (Fget_screen_color): New function.
4098 (syms_of_ntterm): Defsubr it.
4099
4100 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4101 unlink the temporary file if Fcall_process didn't create it in the
4102 first place.
4103 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4104 child process will be redirected to a file specified with `:file'.
4105 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4106 cue to call_process_cleanup not to close that handle.
4107
4108 2011-05-07 Ben Key <bkey76@gmail.com>
4109
4110 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4111 one of two shell specific rules, either bootstrap-temacs-CMD or
4112 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4113 to the previous implementation of the bootstrap-temacs rule.
4114 The bootstrap-temacs-CMD rule is similar to the previous
4115 implementation of the bootstrap-temacs rule except that it
4116 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4117 variable.
4118
4119 These changes, along with some changes to nt/configure.bat,
4120 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4121 earlier fix to add support for --cflags and --ldflags options
4122 that include quotes so that it works whether make uses cmd or
4123 sh as the shell.
4124
4125 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4126
4127 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4128 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4129 is a constant.
4130 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4131 a string. Handle both cases.
4132 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4133 (Fdbus_register_method): Use Qinvalid_function.
4134
4135 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4136
4137 * makefile.w32-in: Update dependencies.
4138 (LISP_H): Add inttypes.h and stdin.h.
4139 (PROCESS_H): Add unistd.h.
4140
4141 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4142
4143 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4144 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4145
4146 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4147
4148 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4149
4150 * term.c (vfatal): Remove stray call to va_end.
4151 It's not needed and the C Standard doesn't allow it here anyway.
4152
4153 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4154 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4155
4156 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4157 bytes.
4158
4159 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4160
4161 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4162
4163 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4164
4165 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4166
4167 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4168
4169 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4170 * charset.c (Fdefine_charset_internal): Don't initialize
4171 charset.code_space[15]. The value was garbage, on hosts with
4172 32-bit int (Bug#8600).
4173
4174 * lread.c (read_integer): Be more consistent with string-to-number.
4175 Use string_to_number to do the actual conversion; this avoids
4176 rounding errors and fixes some other screwups. Without this fix,
4177 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4178 (digit_to_number): Move earlier, for benefit of read_integer.
4179 Return -1 if the digit is out of range for the base, -2 if it is
4180 not a digit in any supported base. (Bug#8602)
4181
4182 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4183
4184 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4185 to match comment at start of function. This also removes a
4186 GCC warning about overflow in a 32+64-bit port.
4187
4188 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4189
4190 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4191 Reported by Stefan Monnier in
4192 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4193 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4194 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4195
4196 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4197 (EMACS_UINTPTR): Likewise, with uintptr_t.
4198
4199 * lisp.h: Prefer 64-bit EMACS_INT if available.
4200 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4201 on 32-bit hosts that have 64-bit int, so that they can access
4202 large files.
4203 However, temporarily disable this change unless the temporary
4204 symbol WIDE_EMACS_INT is defined.
4205
4206 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4207
4208 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4209 This removes an assumption that EMACS_INT and long are the same
4210 width as pointers. The assumption is true for Emacs porting targets
4211 now, but we want to make other targets possible.
4212 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4213 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4214 In the rest of the code, change types of integers that hold casted
4215 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4216 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4217 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4218 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4219 No need to cast type when ORing.
4220 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4221 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4222 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4223 assume EMACS_INT is the same width as char *.
4224 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4225 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4226 Remove no-longer-needed casts.
4227 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4228 (xg_tool_bar_help_callback, xg_make_tool_item):
4229 Use EMACS_INTPTR to hold an integer
4230 that will be cast to void *; this can avoid a GCC warning
4231 if EMACS_INT is not the same width as void *.
4232 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4233 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4234 (current_message_1, set_message_1):
4235 Use a local to convert to proper width without a cast.
4236 * xmenu.c (dialog_selection_callback): Likewise.
4237
4238 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4239 Also, don't assume VALBITS / RAND_BITS is less than 5,
4240 and don't rely on undefined behavior when shifting a 1 left into
4241 the sign bit.
4242 * lisp.h (get_random): Change signature to match.
4243
4244 * lread.c (hash_string): Use size_t, not int, for hash computation.
4245 Normally we prefer signed values; but hashing is special, because
4246 it's better to use unsigned division on hash table sizes so that
4247 the remainder is nonnegative. Also, size_t is the natural width
4248 for hashing into memory. The previous code used 'int', which doesn't
4249 retain enough info to hash well into very large tables.
4250 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4251
4252 * dbusbind.c: Don't possibly lose pointer info when converting.
4253 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4254 Use XPNTR rather than XHASH, so that the high-order bits of
4255 the pointer aren't lost when converting through void *.
4256
4257 * eval.c (Fautoload): Don't double-shift a pointer.
4258
4259 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4260
4261 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4262
4263 * gnutls.c (DEF_GNUTLS_FN):
4264 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4265
4266 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4267
4268 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4269 marker. (Bug#8610)
4270
4271 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4272
4273 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4274 New version that can reserve upto 2GB of heap space.
4275
4276 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4277
4278 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4279
4280 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4281
4282 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4283 `gnutls_certificate_set_x509_key_file'.
4284
4285 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4286
4287 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4288 Update dependencies.
4289
4290 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4291
4292 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4293 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4294 Remove unused parameter `fildes'.
4295 * process.c (read_process_output, send_process): Don't pass it.
4296
4297 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4298
4299 Fix previous change: the library cache is defined in w32.c.
4300 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4301 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4302
4303 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4304
4305 Implement dynamic loading of GnuTLS on Windows.
4306
4307 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4308 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4309 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4310 Declare.
4311
4312 * gnutls.c (Qgnutls_dll): Define.
4313 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4314 (gnutls_*): Declare function pointers.
4315 (init_gnutls_functions): New function to initialize function pointers.
4316 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4317 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4318 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4319 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4320 (emacs_gnutls_write, emacs_gnutls_read)
4321 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4322 (Fgnutls_available_p): New function.
4323 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4324 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4325 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4326
4327 * image.c: Include w32.h.
4328 (Vimage_type_cache): Delete.
4329 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4330 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4331 (w32_delayed_load): Move to w32.c.
4332
4333 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4334
4335 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4336 (w32_delayed_load): Move from image.c. When loading a library, record
4337 its filename in the :loaded-from property of the library id.
4338 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4339 Initialize and staticpro them.
4340 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4341
4342 * process.c: Include lisp.h before w32.h, not after.
4343 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4344 instead of gnutls_record_check_pending.
4345
4346 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4347
4348 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4349
4350 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4351 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4352 as passed in.
4353
4354 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4355
4356 * xterm.c (x_set_frame_alpha): Do not set property on anything
4357 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4358
4359 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4360
4361 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4362
4363 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4364
4365 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4366 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4367 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4368 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4369 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4370 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4371 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4372 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4373 (Qgnutls_bootprop_callbacks_verify): Make static.
4374
4375 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4376
4377 * callproc.c: Indentation fixup.
4378
4379 * sysdep.c (wait_for_termination_1): Make static.
4380 (wait_for_termination, interruptible_wait_for_termination):
4381 Move after wait_for_termination_1.
4382
4383 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4384
4385 * sysdep.c (interruptible_wait_for_termination): New function
4386 which is like wait_for_termination, but allows keyboard
4387 interruptions.
4388
4389 * callproc.c (Fcall_process): Add (:file "file") as an option for
4390 the STDOUT buffer.
4391 (Fcall_process_region): Ditto.
4392
4393 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4394
4395 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4396 rather than `XVECTOR (FOO)->size'.
4397
4398 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4399 inttypes.h, as a gnulib replacement is used if it not available in
4400 system headers.
4401
4402 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4403
4404 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4405 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4406 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4407
4408 * coding.c (coding_alloc_by_realloc): Error out if destination
4409 will grow beyond MOST_POSITIVE_FIXNUM.
4410 (decode_coding_emacs_mule): Abort if there isn't enough place in
4411 charbuf for the composition carryover bytes. Reserve an extra
4412 space for up to 2 characters produced in a loop.
4413 (decode_coding_iso_2022): Abort if there isn't enough place in
4414 charbuf for the composition carryover bytes.
4415
4416 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4417
4418 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4419 aborting when %lld or %lll format is passed.
4420 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4421 %llo or %llx format is passed. (Bug#8545)
4422
4423 * window.c (window_scroll_line_based): Use a marker instead of
4424 simple variables to record original value of point. (Bug#7952)
4425
4426 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4427 produced by %s or %c overflows available buffer space. (Bug#8545)
4428
4429 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4430
4431 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4432 (SIZE_MAX): Move defn after all includes, as they might #define it.
4433
4434 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4435
4436 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4437
4438 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4439
4440 * keyboard.c (Qdelayed_warnings_hook): Define.
4441 (command_loop_1): Run `delayed-warnings-hook'
4442 if Vdelayed_warnings_list is non-nil.
4443 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4444 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4445
4446 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4447
4448 * doprnt.c (doprnt): Don't return value smaller than the buffer
4449 size if the message was truncated. (Bug#8545).
4450
4451 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4452
4453 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4454 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4455
4456 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4457
4458 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4459
4460 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4461
4462 * makefile.w32-in: Update dependencies.
4463
4464 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4465
4466 Improve `doprnt' and its usage. (Bug#8545)
4467 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4468 `format_end'. Remove support for %l as a conversion specifier.
4469 Don't use xrealloc. Improve diagnostics when the %l size modifier
4470 is used. Update the commentary.
4471
4472 * eval.c (verror): Simplify calculation of size_t.
4473
4474 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4475 messages.
4476
4477 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4478
4479 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4480 change.
4481
4482 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4483
4484 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4485 This makes this file independent of the recent pseudovector change.
4486
4487 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4488
4489 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4490
4491 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4492 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4493 Remove unused local.
4494 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4495
4496 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4497 GCC 4.6.0 optimizes based on type-based alias analysis.
4498 For example, if b is of type struct buffer * and v of type struct
4499 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4500 != &v->size, and therefore "v->size = 1; b->size = 2; return
4501 v->size;" must therefore return 1. This assumption is incorrect
4502 for Emacs, since it type-puns struct Lisp_Vector * with many other
4503 types. To fix this problem, this patch adds a new type struct
4504 vectorlike_header that documents the constraints on layout of vectors
4505 and pseudovectors, and helps optimizing compilers not get fooled
4506 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4507 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4508 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4509 the size member.
4510 (XSETPVECTYPE): Rewrite in terms of new macro.
4511 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4512 This is a bit clearer, and further avoids the possibility of
4513 undesirable aliasing.
4514 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4515 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4516 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4517 since Lisp_Subr is a special case (no "next" field).
4518 (ASIZE): Now uses header.size rather than size.
4519 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4520 to avoid the hassle of writing XVECTOR (foo)->header.size.
4521 (struct vectorlike_header): New type.
4522 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4523 object, to help avoid aliasing.
4524 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4525 (SUBRP): Likewise, since Lisp_Subr is a special case.
4526 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4527 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4528 (struct Lisp_Hash_Table): Combine first two members into a single
4529 struct vectorlike_header member. All uses of "size" and "next" members
4530 changed to be "header.size" and "header.next".
4531 * buffer.h (struct buffer): Likewise.
4532 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4533 * frame.h (struct frame): Likewise.
4534 * process.h (struct Lisp_Process): Likewise.
4535 * termhooks.h (struct terminal): Likewise.
4536 * window.c (struct save_window_data, struct saved_window): Likewise.
4537 * window.h (struct window): Likewise.
4538 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4539 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4540 * buffer.c (init_buffer_once): Likewise.
4541 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4542 special case.
4543 * process.c (Fformat_network_address): Use local var for size,
4544 for brevity.
4545
4546 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4547
4548 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4549 * data.c (atof): Remove decl; no longer used or needed.
4550 (digit_to_number): Move to lread.c.
4551 (Fstring_to_number): Use new string_to_number function, to be
4552 consistent with how the Lisp reader treats infinities and NaNs.
4553 Do not assume that floating-point numbers represent EMACS_INT
4554 without losing information; this is not true on most 64-bit hosts.
4555 Avoid double-rounding errors, by insisting on integers when
4556 parsing non-base-10 numbers, as the documentation specifies.
4557 * lisp.h (string_to_number): New decl, replacing ...
4558 (isfloat_string): Remove.
4559 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4560 (read1): Do not accept +. and -. as integers; this
4561 appears to have been a coding error. Similarly, do not accept
4562 strings like +-1e0 as floating point numbers. Do not report
4563 overflow for integer overflows unless the base is not 10 which
4564 means we have no simple and reliable way to continue.
4565 Break out the floating-point parsing into a new
4566 function string_to_number, so that Fstring_to_number parses
4567 floating point numbers consistently with the Lisp reader.
4568 (digit_to_number): Move here from data.c. Make it static inline.
4569 (E_CHAR, EXP_INT): Remove, replacing with ...
4570 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4571 (string_to_number): New function, replacing isfloat_string.
4572 This function checks for valid syntax and produces the resulting
4573 Lisp float number too. Rework it so that string-to-number
4574 no longer mishandles examples like "1.0e+". Use strtoumax,
4575 so that overflow for non-base-10 numbers is reported only when
4576 there's no portable and simple way to convert to floating point.
4577
4578 * textprop.c (set_text_properties_1): Rewrite for clarity,
4579 and to avoid GCC warning about integer overflow.
4580
4581 * intervals.h (struct interval): Use EMACS_INT for members
4582 where EMACS_UINT might cause problems. See
4583 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4584 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4585 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4586 All uses changed.
4587 (offset_intervals): Tell GCC not to worry about length overflow
4588 when negating a negative length.
4589
4590 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4591 (overrun_check_free): Likewise.
4592
4593 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4594 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4595 word size.
4596
4597 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4598 (gnutls_make_error): Rename local to avoid shadowing.
4599 (gnutls_emacs_global_deinit): ifdef out; not used.
4600 (Fgnutls_boot): Use const for pointer to readonly storage.
4601 Comment out unused local. Fix pointer signedness problems.
4602
4603 * lread.c (openp): Don't stuff size_t into an 'int'.
4604 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4605 about possible signed overflow.
4606
4607 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4608 (GDK_KEY_g): Don't define if already defined.
4609 (xg_prepare_tooltip): Avoid pointer signedness problem.
4610 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4611
4612 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4613 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4614
4615 * xfns.c (Fx_window_property): Simplify a bit,
4616 to make a bit faster and to avoid GCC 4.6.0 warning.
4617 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4618
4619 * fns.c (internal_equal): Don't assume size_t fits in int.
4620
4621 * alloc.c (compact_small_strings): Tighten assertion a little.
4622
4623 Replace pEd with more-general pI, and fix some printf arg casts.
4624 * lisp.h (pI): New macro, generalizing old pEd macro to other
4625 conversion specifiers. For example, use "...%"pI"d..." rather
4626 than "...%"pEd"...".
4627 (pEd): Remove. All uses replaced with similar uses of pI.
4628 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4629 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4630 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4631 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4632 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4633 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4634 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4635 64-bit hosts.
4636 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4637 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4638 * print.c (safe_debug_print, print_object): Likewise.
4639 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4640 to int.
4641 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4642 avoiding the 0 flag, which is not portable.
4643 * process.c (Fmake_network_process): Use pI to avoid cast.
4644 * region-cache.c (pp_cache): Likewise.
4645 * xdisp.c (decode_mode_spec): Likewise.
4646 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4647 behavior on 64-bit hosts with printf arg.
4648 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4649 (x_stop_queuing_selection_requests): Likewise.
4650 (x_get_window_property): Don't truncate byte count to an 'int'
4651 when tracing.
4652
4653 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4654 here, since it parses constructs like leading '-' and spaces,
4655 which are not wanted; and it overflows with large numbers.
4656 Instead, simply match F[0-9]+, which is what is wanted anyway.
4657
4658 * alloc.c: Remove unportable assumptions about struct layout.
4659 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4660 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4661 (allocate_vectorlike, make_pure_vector): Use the new macros,
4662 plus offsetof, to remove unportable assumptions about struct layout.
4663 These assumptions hold on all porting targets that I know of, but
4664 they are not guaranteed, they're easy to remove, and removing them
4665 makes further changes easier.
4666
4667 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4668 This doesn't fix a bug but makes the code clearer.
4669 (string_overrun_cookie): Now const. Use initializers that
4670 don't formally overflow signed char, to avoid warnings.
4671 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4672 can cause Emacs to crash when string overrun checking is enabled.
4673 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4674 multiple of sizeof (EMACS_INT); it need not be, if
4675 alignof(EMACS_INT) < sizeof (EMACS_INT).
4676 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4677
4678 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4679
4680 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4681
4682 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4683
4684 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4685 supposed to be handshaking. (Bug#8556)
4686 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4687
4688 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4689
4690 * lisp.h (Qdebug): List symbol.
4691 * eval.c (Qdebug): Restore global linkage.
4692 * keyboard.c (debug-on-event): New variable.
4693 (handle_user_signal): Break into debugger when debug-on-event
4694 matches the current signal symbol.
4695
4696 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4697
4698 * alloc.c (check_sblock, check_string_bytes)
4699 (check_string_free_list): Convert to standard C.
4700
4701 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4702
4703 * w32.c (emacs_gnutls_push): Fix typo.
4704
4705 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4706
4707 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4708 "cast to pointer from integer of different size".
4709
4710 Improve doprnt and its use in verror. (Bug#8545)
4711 * doprnt.c (doprnt): Document the set of format control sequences
4712 supported by the function. Use SAFE_ALLOCA instead of always
4713 using `alloca'.
4714
4715 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4716 is one byte too soon. Don't use xrealloc; instead xfree and
4717 xmalloc anew.
4718
4719 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4720
4721 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4722 callbacks stage.
4723
4724 * gnutls.c: Renamed global_initialized to
4725 gnutls_global_initialized. Added internals for the
4726 :verify-hostname-error, :verify-error, and :verify-flags
4727 parameters of `gnutls-boot' and documented those parameters in the
4728 docstring. Start callback support.
4729 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4730 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4731 on error. Return error code.
4732 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4733 (emacs_gnutls_read): Likewise.
4734 (Fgnutls_boot): Return handshake error code.
4735 (emacs_gnutls_handle_error): New function.
4736 (wsaerror_to_errno): Likewise.
4737
4738 * w32.h (emacs_gnutls_pull): Add prototype.
4739 (emacs_gnutls_push): Likewise.
4740
4741 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4742 (emacs_gnutls_push): Likewise.
4743
4744 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4745
4746 * process.c (wait_reading_process_output): Check if GnuTLS
4747 buffered some data internally if no FDs are set for TLS
4748 connections.
4749
4750 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4751 (LIBS): Link to USER_LIBS.
4752 ($(BLD)/gnutls.$(0)): New target.
4753
4754 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4755
4756 * xdisp.c (handle_single_display_spec): Rename the
4757 display_replaced_before_p argument into display_replaced_p, to
4758 make it consistent with the commentary. Fix typos in the
4759 commentary.
4760
4761 * textprop.c (syms_of_textprop): Remove dead code.
4762 (copy_text_properties): Delete obsolete commentary about an
4763 interface that was deleted long ago. Fix typos in the description
4764 of arguments.
4765
4766 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4767 to changes in oldXMenu/XMenu.h from 2011-04-16.
4768 <menu_help_message, prev_menu_help_message>: Constify.
4769 (IT_menu_make_room): menu->help_text is now `const char **';
4770 adjust.
4771
4772 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4773 to changes in oldXMenu/XMenu.h from 2011-04-16.
4774 (struct XMenu): Declare `help_text' `const char **'.
4775
4776 * xfaces.c <Qunspecified>: Make extern again.
4777
4778 * syntax.c: Include sys/types.h before including regex.h, as
4779 required by Posix.
4780
4781 * doc.c (get_doc_string): Improve the format passed to `error'.
4782
4783 * doprnt.c (doprnt): Improve commentary.
4784
4785 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4786
4787 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4788 them with etags.
4789
4790 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4791 changes in globals.h immediately force recompilation.
4792 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4793 $(CURDIR)/s/ms-w32.h.
4794 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4795
4796 * character.c (Fchar_direction): Function deleted.
4797 (syms_of_character): Don't defsubr it.
4798 <char-direction-table>: Deleted.
4799
4800 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4801
4802 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4803 * doprnt.c: Include limits.h.
4804 (SIZE_MAX): New macro.
4805 (doprnt): Return a size_t value. 2nd arg is now size_t.
4806 Many local variables are now size_t instead of int or unsigned.
4807 Improve overflow protection. Support `l' modifier for integer
4808 conversions. Support %l conversion. Don't assume an EMACS_INT
4809 argument for integer conversions and for %c.
4810
4811 * lisp.h (doprnt): Restore prototype.
4812
4813 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4814 $(SRC)/character.h.
4815
4816 * Makefile.in (base_obj): Add back doprnt.o.
4817
4818 * deps.mk (doprnt.o): Add back prerequisites.
4819 (callint.o): Depend on character.h.
4820
4821 * eval.c (internal_lisp_condition_case): Include the handler
4822 representation in the error message.
4823 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4824 when breaking from the loop.
4825
4826 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4827
4828 * callint.c (Fcall_interactively): When displaying error message
4829 about invalid control letter, pass the character's codepoint, not
4830 a pointer to its multibyte form. Improve display of the character
4831 in octal and display also its hex code.
4832
4833 * character.c (char_string): Use %x to display the (unsigned)
4834 codepoint of an invalid character, to avoid displaying a bogus
4835 negative value.
4836
4837 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4838 `error', not SYMBOL_NAME itself.
4839
4840 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4841 character arguments to `error'.
4842
4843 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4844 to `error' in error message about FINAL_CHAR argument. Make sure
4845 FINAL_CHAR is a character, and use %c when it is passed as
4846 argument to `error'.
4847
4848 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4849
4850 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4851
4852 * w32.c: Include <time.h>.
4853 (sys_localtime): New function.
4854
4855 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4856
4857 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4858
4859 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4860
4861 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4862
4863 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4864 zombies (Bug#8467).
4865
4866 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4867
4868 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4869 gl_state.e_property when gl_state.object is Qt.
4870
4871 * insdel.c (make_gap_larger): Remove limitation of buffer size
4872 to <= INT_MAX.
4873
4874 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4875
4876 * xdisp.c (lookup_glyphless_char_display)
4877 (produce_glyphless_glyph): Handle cons cell entry in
4878 glyphless-char-display.
4879 (Vglyphless_char_display): Document it.
4880
4881 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4882 glyphless-char-display.
4883
4884 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4885
4886 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4887
4888 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4889
4890 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4891 definition for no-X builds.
4892
4893 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4894
4895 Static checks with GCC 4.6.0 and non-default toolkits.
4896
4897 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4898
4899 * process.c (keyboard_bit_set): Define only if SIGIO.
4900 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4901 (send_process): Repair possible setjmp clobbering.
4902
4903 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4904
4905 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4906
4907 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4908
4909 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4910 Define only if needed.
4911
4912 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4913 by pacifying GCC about it. Maybe it's time to retire it?
4914 * xfaces.c (USG, __TIMEVAL__): Likewise.
4915
4916 * dispextern.h (struct redisplay_interface): Rename param
4917 to avoid shadowing.
4918 * termhooks.h (struct terminal): Likewise.
4919 * xterm.c (xembed_send_message): Likewise.
4920
4921 * insdel.c (make_gap_smaller): Define only if
4922 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4923
4924 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4925 it.
4926
4927 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4928 so that we aren't warned about unused symbols.
4929
4930 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4931
4932 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4933
4934 * xfns.c (x_real_positions): Mark locals as initialized.
4935
4936 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4937
4938 * xterm.c: Fix problems found by static analysis with other toolkits.
4939 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4940 (x_dispatch_event): Declare static if USE_GTK, and
4941 define if USE_GTK || USE_X_TOOLKIT.
4942 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4943 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4944 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4945 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4946
4947 * xmenu.c (menu_help_callback): Pointer type fixes.
4948 Use const pointers when pointing at readonly data. Avoid pointer
4949 signedness clashes.
4950 (FALSE): Remove unused macro.
4951 (update_frame_menubar): Remove unused decl.
4952
4953 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4954
4955 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4956 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4957 (single_menu_item): Rename local to avoid shadowing.
4958
4959 * keyboard.c (make_lispy_event): Remove unused local var.
4960
4961 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4962 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4963
4964 * bitmaps: Change bitmaps from unsigned char back to the X11
4965 compatible char. Avoid the old compiler warnings about
4966 out-of-range initializers by using, for example, '\xab' rather
4967 than 0xab.
4968
4969 * xgselect.c (xgselect_initialize): Check vs interface
4970 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4971
4972 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4973
4974 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4975 to read-only memory.
4976
4977 * fns.c (vector): Remove; this old hack is no longer needed.
4978
4979 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4980 Remove unused var.
4981 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4982
4983 * xrdb.c (x_load_resources): Omit unused local.
4984
4985 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4986 (x_window): Rename locals to avoid shadowing.
4987 (USG): Use the kludged USG macro, to pacify gcc.
4988
4989 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4990 (x_term_init): Remove local to avoid shadowing.
4991
4992 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4993
4994 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4995 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4996
4997 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4998
4999 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5000
5001 Fix regex.c, syntax.c and friends for buffers > 2GB.
5002 * syntax.h (struct gl_state_s): Declare character position members
5003 EMACS_INT.
5004
5005 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5006
5007 * textprop.c (verify_interval_modification, interval_of):
5008 Declare arguments EMACS_INT.
5009
5010 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5011 EMACS_INT.
5012
5013 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5014
5015 * indent.c (Fvertical_motion): Local variable it_start is now
5016 EMACS_INT.
5017
5018 * regex.c (re_match, re_match_2, re_match_2_internal)
5019 (bcmp_translate, regcomp, regexec, print_double_string)
5020 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5021 (re_compile_pattern, re_exec): Declare arguments and local
5022 variables `size_t' and `ssize_t' and return values `regoff_t', as
5023 appropriate.
5024 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5025 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5026 <compile_stack_type>: `size' and `avail' are now `size_t'.
5027
5028 * regex.h <regoff_t>: Use ssize_t, not int.
5029 (re_search, re_search_2, re_match, re_match_2): Arguments that
5030 specify buffer/string position and length are now ssize_t and
5031 size_t. Return type is regoff_t.
5032
5033 2011-04-16 Ben Key <bkey76@gmail.com>
5034
5035 * nsfont.m: Fixed bugs in ns_get_family and
5036 ns_descriptor_to_entity that were caused by using free to
5037 deallocate memory blocks that were allocated by xmalloc (via
5038 xstrdup). This caused Emacs to crash when compiled with
5039 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5040 --enable-checking=xmallocoverrun). xfree is now used to
5041 deallocate these memory blocks.
5042
5043 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5044
5045 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5046
5047 emacs_write: Accept and return EMACS_INT for sizes.
5048 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5049 et seq.
5050 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5051 Accept and return EMACS_INT.
5052 (emacs_gnutls_write): Return the number of bytes written on
5053 partial writes.
5054 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5055 (emacs_read, emacs_write): Remove check for negative size, as the
5056 Emacs source code has been audited now.
5057 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5058 (emacs_read, emacs_write): Use it.
5059 * process.c (send_process): Adjust to the new signatures of
5060 emacs_write and emacs_gnutls_write. Do not attempt to store
5061 a byte offset into an 'int'; it might overflow.
5062 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5063
5064 * sound.c: Don't assume sizes fit in 'int'.
5065 (struct sound_device.period_size, alsa_period_size):
5066 Return EMACS_INT, not int.
5067 (struct sound_device.write, vox_write, alsa_write):
5068 Accept EMACS_INT, not int.
5069 (wav_play, au_play): Use EMACS_INT to store sizes and to
5070 record read return values.
5071
5072 2011-04-15 Ben Key <bkey76@gmail.com>
5073
5074 * keyboard.c (Qundefined): Don't declare static since it is used
5075 in nsfns.m.
5076 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5077 static since they are used in nsfont.m.
5078
5079 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5080
5081 * process.c (Qprocessp): Don't declare static.
5082 * lisp.h (Qprocessp): Declare again.
5083
5084 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5085
5086 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5087
5088 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5089
5090 Improve C-level modularity by making more things 'static'.
5091
5092 Don't publish debugger-only interfaces to other modules.
5093 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5094 (verify_bytepos, count_markers): Move decls to the only modules
5095 that need them.
5096 * region-cache.h (pp_cache): Likewise.
5097 * window.h (check_all_windows): Likewise.
5098 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5099
5100 * sysdep.c (croak): Now static, if
5101 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5102 * syssignal.h (croak): Declare only if not static.
5103
5104 * alloc.c (refill_memory_reserve): Now static if
5105 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5106 * lisp.h (refill_memory_reserve): Declare only if not static.
5107
5108 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5109 Define only if USE_LUCID.
5110
5111 * xrdb.c (x_customization_string, x_rm_string): Now static.
5112
5113 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5114 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5115
5116 * xdisp.c (draw_row_with_mouse_face): Now static.
5117 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5118
5119 * window.h (check_all_windows): Mark externally visible.
5120
5121 * window.c (window_deletion_count): Now static.
5122
5123 * undo.c: Make symbols static if they're not exported.
5124 (last_undo_buffer, last_boundary_position, pending_boundary):
5125 Now static.
5126
5127 * textprop.c (interval_insert_behind_hooks): Now static.
5128 (interval_insert_in_front_hooks): Likewise.
5129
5130 * term.c: Make symbols static if they're not exported.
5131 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5132 (max_frame_lines, tty_set_terminal_modes):
5133 (tty_reset_terminal_modes, tty_turn_off_highlight):
5134 (get_tty_terminal): Now static.
5135 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5136 * termhooks.h (term_mouse_moveto): Do not declare if
5137 HAVE_WINDOW_SYSTEM.
5138 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5139 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5140
5141 * sysdep.c: Make symbols static if they're not exported.
5142 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5143 Now static.
5144 (sigprocmask_set, full_mask): Remove; unused.
5145 (wait_debugging): Mark as visible.
5146 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5147 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5148
5149 * syntax.c (syntax_temp): Define only if !__GNUC__.
5150
5151 * sound.c (current_sound_device, current_sound): Now static.
5152
5153 * search.c (searchbufs, searchbuf_head): Now static.
5154
5155 * scroll.c (scroll_cost): Remove; unused.
5156 * dispextern.h (scroll_cost): Remove decl.
5157
5158 * region-cache.h (pp_cache): Mark as externally visible.
5159
5160 * process.c: Make symbols static if they're not exported.
5161 (process_tick, update_tick, create_process, chan_process):
5162 (Vprocess_alist, proc_buffered_char, datagram_access):
5163 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5164 (deactivate_process): Mark defn as static, as well as decl.
5165 * lisp.h (create_process): Remove decl.
5166 * process.h (chan_process, Vprocess_alist): Remove decls.
5167
5168 * print.c: Make symbols static if they're not exported.
5169 (print_depth, new_backquote_output, being_printed, print_buffer):
5170 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5171 (print_interval, print_number_index, initial_stderr_stream):
5172 Now static.
5173 * lisp.h (Fprinc): Remove decl.
5174 (debug_output_compilation_hack): Mark as externally visible.
5175
5176 * sysdep.c (croak): Move decl from here to syssignal.h.
5177 * syssignal.h (croak): Put it here, so the API can be checked when
5178 'croak' is called from dissociate_if_controlling_tty.
5179
5180 * minibuf.c: Make symbols static if they're not exported.
5181 (minibuf_save_list, choose_minibuf_frame): Now static.
5182 * lisp.h (choose_minibuf_frame): Remove decl.
5183
5184 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5185
5186 * lread.c: Make symbols static if they're not exported.
5187 (read_objects, initial_obarray, oblookup_last_bucket_number):
5188 Now static.
5189 (make_symbol): Remove; unused.
5190 * lisp.h (initial_obarray, make_symbol): Remove decls.
5191
5192 * keyboard.c: Make symbols static if they're not exported.
5193 (single_kboard, recent_keys_index, total_keys, recent_keys):
5194 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5195 (this_single_command_key_start, echoing, last_auto_save):
5196 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5197 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5198 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5199 (Vlispy_mouse_stem, double_click_count):
5200 Now static.
5201 (force_auto_save_soon): Define only if SIGDANGER.
5202 (ignore_mouse_drag_p): Now static if
5203 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5204 (print_help): Remove; unused.
5205 (stop_character, last_timer_event): Mark as externally visible.
5206 * keyboard.h (ignore_mouse_drag_p): Declare only if
5207 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5208 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5209 * lisp.h (echoing): Remove decl.
5210 (force_auto_save_soon): Declare only if SIGDANGER.
5211 * xdisp.c (redisplay_window): Simplify code, to make it more
5212 obvious that ignore_mouse_drag_p is not accessed if !defined
5213 USE_GTK && !defined HAVE_NS.
5214
5215 * intervals.c: Make symbols static if they're not exported.
5216 (merge_properties_sticky, merge_interval_right, delete_interval):
5217 Now static.
5218 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5219
5220 * insdel.c: Make symbols static if they're not exported.
5221 However, leave prepare_to_modify_buffer alone. It's never
5222 called from outside this function, but that appears to be a bug.
5223 (combine_after_change_list, combine_after_change_buffer):
5224 (adjust_after_replace, signal_before_change): Now static.
5225 (adjust_after_replace_noundo): Remove; unused.
5226 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5227 (signal_before_change): Remove decls.
5228
5229 * indent.c (val_compute_motion, val_vmotion): Now static.
5230
5231 * image.c: Make symbols static if they're not exported.
5232 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5233 if USE_GTK.
5234 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5235 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5236
5237 * fringe.c (standard_bitmaps): Now static.
5238 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5239
5240 * frame.c: Make symbols static if they're not exported.
5241 (x_report_frame_params, make_terminal_frame): Now static.
5242 (get_frame_param): Now static, unless HAVE_NS.
5243 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5244 (x_get_resource_string): Remove; not used.
5245 * frame.h (make_terminal_frame, x_report_frame_params):
5246 (x_get_resource_string); Remove decls.
5247 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5248 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5249
5250 * font.c, fontset.c: Make symbols static if they're not exported.
5251 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5252 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5253 * font.c (font_close_object): Now static.
5254 * font.h (font_close_object): Remove.
5255 * fontset.c (FONTSET_OBJLIST): Remove.
5256 (free_realized_fontset) #if-0 the body, which does nothing.
5257 (face_suitable_for_char_p): #if-0, as it's never called.
5258 * fontset.h (face_suitable_for_char_p): Remove decl.
5259 * xfaces.c (face_at_string_position):
5260 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5261 since 0 is always ASCII.
5262
5263 * fns.c (weak_hash_tables): Now static.
5264
5265 * fileio.c: Make symbols static if they're not exported.
5266 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5267 (Vwrite_region_annotation_buffers): Now static.
5268
5269 * eval.c: Make symbols static if they're not exported.
5270 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5271 * lisp.h (backtrace_list): Remove decl.
5272
5273 * emacs.c: Make symbols static if they're not exported.
5274 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5275 (fatal_error_code, fatal_error_signal_hook, standard_args):
5276 Now static.
5277 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5278 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5279 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5280 * lisp.h (fatal_error_signal_hook): Remove decl.
5281 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5282
5283 * editfns.c: Move a (normally-unused) function to its only use.
5284 * editfns.c, lisp.h (get_operating_system_release): Remove.
5285 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5286 worth the hassle of breaking this out.
5287
5288 * xterm.c: Make symbols static if they're not exported.
5289 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5290 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5291 (x_destroy_window, x_delete_display):
5292 Now static.
5293 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5294 (x_mouse_leave): Remove; unused.
5295 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5296 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5297 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5298 Remove decls.
5299 (x_mouse_leave): Declare only if WINDOWSNT.
5300 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5301 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5302 USE_X_TOOLKIT.
5303
5304 * ftxfont.c: Make symbols static if they're not exported.
5305 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5306 HAVE_FREETYPE.
5307 * font.h (ftxfont_driver): Likewise.
5308
5309 * xfns.c: Make symbols static if they're not exported.
5310 (x_last_font_name, x_display_info_for_name):
5311 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5312 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5313 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5314 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5315 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5316 (last_show_tip_args): Now static.
5317 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5318 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5319 (x_screen_planes): Remove; unused.
5320 * dispextern.h (x_screen_planes): Remove decl.
5321
5322 * dispnew.c: Make symbols static if they're not exported.
5323 * dispextern.h (redraw_garbaged_frames, scrolling):
5324 (increment_row_positions): Remove.
5325 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5326 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5327 Now static.
5328 (redraw_garbaged_frames): Remove; unused.
5329
5330 * xfaces.c: Make symbols static if they're not exported.
5331 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5332 Remove decls.
5333 * xterm.h (defined_color): Remove decls.
5334 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5335 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5336 (menu_face_changed_default, defined_color, free_realized_face):
5337 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5338 (ascii_face_of_lisp_face): Remove; unused.
5339
5340 * xdisp.c: Make symbols static if they're not exported.
5341 * dispextern.h (scratch_glyph_row, window_box_edges):
5342 (glyph_to_pixel_coords, set_cursor_from_row):
5343 (get_next_display_element, set_iterator_to_next):
5344 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5345 (show_mouse_face): Remove decls
5346 * frame.h (message_buf_print): Likewise.
5347 * lisp.h (pop_message, set_message, check_point_in_composition):
5348 Likewise.
5349 * xterm.h (set_vertical_scroll_bar): Likewise.
5350 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5351 (message_buf_print, scratch_glyph_row, displayed_buffer):
5352 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5353 (get_next_display_element, show_mouse_face, window_box_edges):
5354 (frame_to_window_pixel_xy, check_point_in_composition):
5355 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5356 (glyph_to_pixel_coords): Remove; unused.
5357
5358 * dired.c (file_name_completion): Now static.
5359
5360 * dbusbind.c (xd_in_read_queued_messages): Now static.
5361
5362 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5363 * data.c (circular_list_error): Remove.
5364
5365 * commands.h (last_point_position, last_point_position_buffer):
5366 (last_point_position_window): Remove decls.
5367 * keyboard.c: Make these variables static.
5368
5369 * coding.h (coding, code_convert_region, encode_coding_gap):
5370 Remove decls.
5371 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5372 (iso_code_class, detect_coding, code_convert_region): Now static.
5373 (encode_coding_gap): Remove; unused.
5374
5375 * chartab.c (chartab_chars, chartab_bits): Now static.
5376
5377 * charset.h (charset_iso_8859_1): Remove decl.
5378 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5379 Now static.
5380
5381 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5382 * ccl.c (Vccl_program_table): Now static.
5383 (check_ccl_update): Remove; unused.
5384
5385 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5386 * category.h: ... from here.
5387 * category.c (check_category_table, set_category_set): Now static.
5388
5389 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5390 * lisp.h: Remove these decls.
5391
5392 * buffer.c (buffer_count): Remove unused var.
5393
5394 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5395 so that it's not optimized away.
5396 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5397 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5398 exported only to the debugger.
5399
5400 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5401 * atimer.h (run_all_atimers): Remove; not exported.
5402
5403 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5404 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5405 was inaccessible from Lisp.
5406 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5407 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5408
5409 alloc.c: Import and export fewer symbols, and remove unused items.
5410 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5411 is defined.
5412 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5413 it's not optimized away by whole-program optimization.
5414 (message_enable_multibyte, free_misc): Remove.
5415 (catchlist, handlerlist, mark_backtrace):
5416 Declare only if BYTE_MARK_STACK.
5417 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5418 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5419 (message_enable_multibyte): Remove decl.
5420 (free_misc, interval_free_list, float_block, float_block_index):
5421 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5422 (cons_free_list, last_marked_index):
5423 Now static.
5424 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5425 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5426 (mark_backtrace): Define only if BYTE_MARK_STACK.
5427 * xdisp.c (message_enable_multibyte): Now static.
5428
5429 Declare Lisp_Object Q* variables to be 'static' if not exported.
5430 This makes it easier for human readers (and static analyzers)
5431 to see whether these variables are used from other modules.
5432 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5433 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5434 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5435 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5436 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5437 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5438 * xmenu.c, xselect.c:
5439 Declare Q* vars static if they are not used in other modules.
5440 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5441 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5442 Remove decls of unexported vars.
5443 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5444
5445 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5446
5447 Make Emacs functions such as Fatom 'static' by default.
5448 This makes it easier for human readers (and static analyzers)
5449 to see whether these functions can be called from other modules.
5450 DEFUN now defines a static function. To make the function external
5451 so that it can be used in other C modules, use the new macro DEFUE.
5452 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5453 (Finit_image_library):
5454 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5455 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5456 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5457 Remove decls, since these functions are now static.
5458 (Funintern, Fget_internal_run_time): New decls, since these functions
5459 were already external.
5460
5461 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5462 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5463 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5464 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5465 * keyboard.c, keymap.c, lread.c:
5466 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5467 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5468 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5469 Mark functions with DEFUE instead of DEFUN,
5470 if they are used in other modules.
5471 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5472 decls for now-static functions.
5473 * buffer.h (Fdelete_overlay): Remove decl.
5474 * callproc.c (Fgetenv_internal): Mark as internal.
5475 * composite.c (Fremove_list_of_text_properties): Remove decl.
5476 (Fcomposition_get_gstring): New forward static decl.
5477 * composite.h (Fcomposite_get_gstring): Remove decl.
5478 * dired.c (Ffile_attributes): New forward static decl.
5479 * doc.c (Fdocumntation_property): New forward static decl.
5480 * eval.c (Ffetch_bytecode): New forward static decl.
5481 (Funintern): Remove extern decl; now in .h file where it belongs.
5482 * fileio.c (Fmake_symbolic_link): New forward static decl.
5483 * image.c (Finit_image_library): New forward static decl.
5484 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5485 * intervals.h (Fprevious_property_change):
5486 (Fremove_list_of_text_properties): Remove decls.
5487 * keyboard.c (Fthis_command_keys): Remove decl.
5488 (Fcommand_execute): New forward static decl.
5489 * keymap.c (Flookup_key): New forward static decl.
5490 (Fcopy_keymap): Now static.
5491 * keymap.h (Flookup_key): Remove decl.
5492 * process.c (Fget_process): New forward static decl.
5493 (Fprocess_datagram_address): Mark as internal.
5494 * syntax.c (Fsyntax_table_p): New forward static decl.
5495 (skip_chars): Remove duplicate decl.
5496 * textprop.c (Fprevious_property_change): New forward static decl.
5497 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5498 Now internal.
5499 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5500 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5501
5502 * editfns.c (Fformat): Remove unreachable code.
5503
5504 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5505
5506 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5507 change. (Bug#8496)
5508
5509 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5510
5511 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5512 when at ZV. (Bug#8487)
5513
5514 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5515
5516 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5517 (Bug#8437)
5518 * keyboard.c (parse_tool_bar_item): Likewise.
5519 * sound.c (sound_cleanup, alsa_close): Likewise.
5520 * termcap.c (tgetent): Likewise.
5521 * xfns.c (x_default_font_parameter): Likewise.
5522 * xsettings.c (read_and_apply_settings): Likewise.
5523
5524 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5525 (overrun_check_free): Protoize.
5526
5527 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5528
5529 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5530 since callers should never pass a negative size.
5531 Change the signature to match that of plain 'read' and 'write'; see
5532 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5533 * lisp.h: Update prototypes of emacs_write and emacs_read.
5534
5535 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5536
5537 * xdisp.c (redisplay_window): Don't try to determine the character
5538 position of the scroll margin if the window start point w->startp
5539 is outside the buffer's accessible region. (Bug#8468)
5540
5541 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5542
5543 Fix write-region and its subroutines for buffers > 2GB.
5544 * fileio.c (a_write, e_write): Modify declaration of arguments and
5545 local variables to support buffers larger than 2GB.
5546 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5547
5548 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5549 argument, local variables, and return value.
5550
5551 * lisp.h: Update prototypes of emacs_write and emacs_read.
5552
5553 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5554
5555 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5556
5557 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5558
5559 Fix more problems found by GCC 4.6.0's static checks.
5560
5561 * xdisp.c (vmessage): Use a better test for character truncation.
5562
5563 * charset.c (load_charset_map): <, not <=, for optimization,
5564 and to avoid potential problems with integer overflow.
5565 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5566 * casetab.c (set_identity, shuffle): Likewise.
5567 * editfns.c (Fformat): Likewise.
5568 * syntax.c (skip_chars): Likewise.
5569
5570 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5571 This also lets GCC 4.6.0 generate slightly better loop code.
5572
5573 * callint.c (Fcall_interactively): <, not <=, for optimization.
5574 (Fcall_interactively): Count the number of arguments produced,
5575 not the number of arguments given. This is simpler and lets GCC
5576 4.6.0 generate slightly better code.
5577
5578 * ftfont.c: Distingish more carefully between FcChar8 and char.
5579 The previous code passed unsigned char * to a functions like
5580 strlen and xstrcasecmp that expect char *, which does not
5581 conform to the C standard.
5582 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5583 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5584 char * when the C standard requires it.
5585
5586 * keyboard.c (read_char): Remove unused var.
5587
5588 * eval.c: Port to Windows vsnprintf (Bug#8435).
5589 Include <limits.h>.
5590 (SIZE_MAX): Define if the headers do not.
5591 (verror): Do not give up if vsnprintf returns a negative count.
5592 Instead, grow the buffer. This ports to Windows vsnprintf, which
5593 does not conform to C99. Problem reported by Eli Zaretskii.
5594 Also, simplify the allocation scheme, by avoiding the need for
5595 calling realloc, and removing the ALLOCATED variable.
5596
5597 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5598
5599 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5600 But keep the doprint source code for now, as we might revamp it
5601 and use it again (Bug#8435).
5602 * lisp.h (doprnt): Remove.
5603 * Makefile.in (base_obj): Remove doprnt.o.
5604 * deps.mk (doprnt.o): Remove.
5605
5606 error: Print 32- and 64-bit integers portably (Bug#8435).
5607 Without this change, on typical 64-bit hosts error ("...%d...", N)
5608 was used to print both 32- and 64-bit integers N, which relied on
5609 undefined behavior.
5610 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5611 New macro.
5612 * lisp.h (error, verror): Mark as printf-like functions.
5613 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5614 Report overflow in size calculations when allocating printf buffer.
5615 Do not truncate output string at its first null byte.
5616 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5617 Truncate the output at a character boundary, since vsnprintf does not
5618 do that.
5619 * charset.c (check_iso_charset_parameter): Convert internal
5620 character to string before calling 'error', since %c now has the
5621 printf meaning.
5622 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5623 overflow when computing char to be passed to 'error'. Do not
5624 pass Lisp_Object to 'error'; pass the integer instead.
5625 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5626 formatted with plain %d.
5627
5628 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5629
5630 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5631
5632 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5633
5634 * xterm.c (x_catch_errors): Remove duplicate declaration.
5635
5636 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5637
5638 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5639
5640 2011-04-10 Jim Meyering <meyering@redhat.com>
5641
5642 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5643 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5644 return ssize_t not "int", and use size_t as the buffer length.
5645 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5646 * gnutls.h: Update declarations.
5647 * process.c (read_process_output): Use ssize_t, to match.
5648 (send_process): Likewise.
5649
5650 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5651
5652 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5653
5654 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5655
5656 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5657 Use unsigned char, to match FcChar8 type definition.
5658
5659 * xterm.c (handle_one_xevent):
5660 * xmenu.c (create_and_show_popup_menu):
5661 * xselect.c (x_decline_selection_request)
5662 (x_reply_selection_request): Avoid type-punned deref of X events.
5663
5664 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5665
5666 Fix some uses of `int' instead of EMACS_INT.
5667 * search.c (string_match_1, fast_string_match)
5668 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5669 (scan_buffer, find_next_newline_no_quit)
5670 (find_before_next_newline, search_command, Freplace_match)
5671 (Fmatch_data): Make some `int' variables be EMACS_INT.
5672
5673 * xdisp.c (display_count_lines): 3rd argument and return value now
5674 EMACS_INT. All callers changed.
5675 (pint2hrstr): Last argument is now EMACS_INT.
5676
5677 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5678 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5679 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5680 (decode_coding_utf_16, decode_coding_emacs_mule)
5681 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5682 (decode_coding_ccl, decode_coding_charset)
5683 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5684 (decode_coding_iso_2022, decode_coding_emacs_mule)
5685 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5686 <char_offset, last_offset>: Declare EMACS_INT.
5687 (encode_coding_utf_8, encode_coding_utf_16)
5688 (encode_coding_emacs_mule, encode_invocation_designation)
5689 (encode_designation_at_bol, encode_coding_iso_2022)
5690 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5691 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5692 Declare EMACS_INT.
5693 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5694 (encode_invocation_designation): Last argument P_NCHARS is now
5695 EMACS_INT.
5696 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5697 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5698
5699 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5700 All users changed.
5701
5702 * ccl.c (Fccl_execute_on_string): Declare some variables
5703 EMACS_INT.
5704
5705 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5706
5707 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5708
5709 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5710
5711 * process.c (Fformat_network_address): Doc fix.
5712
5713 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5714
5715 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5716
5717 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5718
5719 * keyboard.c (read_char): Call Lisp function help-form-show,
5720 instead of using internal_with_output_to_temp_buffer.
5721 (Qhelp_form_show): New var.
5722 (syms_of_keyboard): Use DEFSYM macro.
5723
5724 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5725
5726 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5727
5728 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5729
5730 * process.c (Flist_processes): Remove to Lisp.
5731 (list_processes_1): Delete.
5732
5733 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5734
5735 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5736
5737 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5738
5739 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5740
5741 Fix more problems found by GCC 4.6.0's static checks.
5742
5743 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5744
5745 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5746
5747 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5748
5749 * xdisp.c (vmessage): Mark as a printf-like function.
5750
5751 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5752
5753 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5754
5755 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5756 printf-like functions.
5757 (tiff_load): Add casts to remove these marks before passing them
5758 to system-supplied API.
5759
5760 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5761
5762 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5763 This avoids several warnings with gcc -Wstrict-overflow.
5764 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5765 directly, rather than having caller test rule sign. This avoids
5766 some unnecessary tests.
5767 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5768 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5769 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5770
5771 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5772 (xfont_open): Avoid unnecessary tests.
5773
5774 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5775
5776 * composite.h, composite.c (composition_gstring_put_cache):
5777 Use EMACS_INT, not int, for length.
5778
5779 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5780 breaking out part of COMPOSITION_DECODE_RULE.
5781 (COMPOSITION_DECODE_RULE): Use it.
5782 * composite.c (get_composition_id): Remove unused local vars,
5783 by using the new macro.
5784
5785 * textprop.c (set_text_properties_1): Change while to do-while,
5786 since the condition is always true at first.
5787
5788 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5789 (interval_deletion_adjustment): Return unsigned value.
5790 All uses changed.
5791
5792 * process.c (list_processes_1, create_pty, read_process_output):
5793 (exec_sentinel): Remove vars that were set but not used.
5794 (create_pty): Remove unnecessary "volatile"s.
5795 (Fnetwork_interface_info): Avoid possibility of int overflow.
5796 (read_process_output): Do adaptive read buffering even if carryover.
5797 (read_process_output): Simplify nbytes computation if buffered.
5798
5799 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5800
5801 * syntax.c (scan_words): Remove var that was set but not used.
5802 (update_syntax_table): Use unsigned instead of int.
5803
5804 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5805 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5806 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5807
5808 * print.c (print_error_message): Avoid int overflow.
5809
5810 * font.c (font_list_entities): Redo for clarity,
5811 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5812
5813 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5814 (font_score): Avoid potential overflow in diff calculation.
5815
5816 * fns.c (substring_both): Remove var that is set but not used.
5817 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5818
5819 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5820
5821 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5822 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5823 can always succeed if overflow has undefined behavior.
5824
5825 * search.c (boyer_moore, wordify): Remove vars set but not used.
5826 (wordify): Omit three unnecessary tests.
5827
5828 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5829 All callers changed. This avoids the need for an unused var.
5830
5831 * casefiddle.c (casify_region): Remove var that is set but not used.
5832
5833 * dired.c (file_name_completion): Remove var that is set but not used.
5834
5835 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5836
5837 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5838 (Finsert_file_contents): Remove unnecessary code checking fd.
5839
5840 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5841 Check for integer overflow on size calculations.
5842
5843 * buffer.c (Fprevious_overlay_change): Remove var that is set
5844 but not used.
5845
5846 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5847 Remove vars that are set but not used.
5848 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5849 (timer_check_2): Mark vars as initialized.
5850
5851 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5852
5853 * image.c (lookup_image): Remove var that is set but not used.
5854 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5855
5856 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5857 that are set but not used.
5858
5859 * xfns.c (make_invisible_cursor): Don't return garbage
5860 if XCreateBitmapFromData fails (Bug#8410).
5861
5862 * xselect.c (x_get_local_selection, x_handle_property_notify):
5863 Remove vars that are set but not used.
5864
5865 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5866 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5867
5868 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5869 Remove var that is set but not used.
5870 (scroll_bar_windows_size): Now size_t, not int.
5871 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5872 Check for overflow.
5873
5874 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5875 (map_tty_color) [!defined MSDOS]: Likewise.
5876
5877 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5878
5879 * coding.c: Remove vars that are set but not used.
5880 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5881 All callers changed.
5882 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5883 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5884 (decode_coding_charset): Remove vars that are set but not used.
5885
5886 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5887 that is set but not used.
5888
5889 * print.c (print_object): Remove var that is set but not used.
5890
5891 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5892 The gnulib version avoids calling malloc in the usual case,
5893 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5894 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5895 * filelock.c (current_lock_owner): Likewise.
5896 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5897 * sysdep.c: Include allocator.h, careadlinkat.h.
5898 (emacs_no_realloc_allocator): New static constant.
5899 (emacs_readlink): New function.
5900 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5901 ../lib/careadlinkat.h.
5902
5903 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5904
5905 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5906 first non-nil return value).
5907
5908 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5909
5910 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5911 if not defined (Bug#8403).
5912
5913 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5914
5915 * xdisp.c (display_count_lines): Remove parameter `start',
5916 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5917 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5918 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5919 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5920 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5921 and thereabouts. All callers changed.
5922 (get_per_char_metric): Remove parameter `f', unused since
5923 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5924
5925 2011-04-02 Jim Meyering <meyering@redhat.com>
5926
5927 do not dereference NULL upon failed strdup
5928 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5929 (ns_get_family): Likewise.
5930
5931 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5932
5933 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5934
5935 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5936
5937 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5938 later (Bug#8403).
5939
5940 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5941
5942 Add lexical binding.
5943
5944 * window.c (Ftemp_output_buffer_show): New fun.
5945 (Fsave_window_excursion):
5946 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5947
5948 * lread.c (lisp_file_lexically_bound_p): New function.
5949 (Fload): Bind Qlexical_binding.
5950 (readevalloop): Remove `evalfun' arg.
5951 Bind Qinternal_interpreter_environment.
5952 (Feval_buffer): Bind Qlexical_binding.
5953 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5954 Mark as dynamic.
5955 (syms_of_lread): Declare `lexical-binding'.
5956
5957 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5958
5959 * keyboard.c (eval_dyn): New fun.
5960 (menu_item_eval_property): Use it.
5961
5962 * image.c (parse_image_spec): Use Ffunctionp.
5963
5964 * fns.c (concat, mapcar1): Accept byte-code-functions.
5965
5966 * eval.c (Fsetq): Handle lexical vars.
5967 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5968 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5969 (FletX, Flet): Obey lexical binding.
5970 (Fcommandp): Handle closures.
5971 (Feval): New `lexical' arg.
5972 (eval_sub): New function extracted from Feval. Use it almost
5973 everywhere where Feval was used. Look up vars in lexical env.
5974 Handle closures.
5975 (Ffunctionp): Move from subr.el.
5976 (Ffuncall): Handle closures.
5977 (apply_lambda): Remove `eval_flags'.
5978 (funcall_lambda): Handle closures and new byte-code-functions.
5979 (Fspecial_variable_p): New function.
5980 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5981 but without exporting it to Lisp.
5982
5983 * doc.c (Fdocumentation, store_function_docstring):
5984 * data.c (Finteractive_form): Handle closures.
5985
5986 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5987 interactive spec.
5988
5989 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5990 New byte-codes.
5991 (exec_byte_code): New function extracted from Fbyte_code to handle new
5992 calling convention for byte-code-functions. Add new byte-codes.
5993
5994 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5995
5996 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5997
5998 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5999
6000 * xdisp.c (redisplay_internal): Fix prototype.
6001
6002 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6003
6004 * xdisp.c (SCROLL_LIMIT): New macro.
6005 (try_scrolling): Use it when setting scroll_limit.
6006 Limit scrolling to 100 screen lines.
6007 (redisplay_window): Even when falling back on "recentering",
6008 position point in the window according to scroll-conservatively,
6009 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6010
6011 (try_scrolling): When point is above the window, allow searching
6012 as far as scroll_max, or one screenful, to compute vertical
6013 distance from PT to the scroll margin position. This prevents
6014 try_scrolling from unnecessarily failing when
6015 scroll-conservatively is set to a value slightly larger than the
6016 window height. Clean up the case of PT below the margin at bottom
6017 of window: scroll_max can no longer be INT_MAX. When aggressive
6018 scrolling is in use, don't let point enter the opposite scroll
6019 margin as result of the scroll.
6020 (syms_of_xdisp) <scroll-conservatively>: Document the
6021 threshold of 100 lines for never-recentering scrolling.
6022
6023 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6024
6025 * dispextern.h (move_it_by_lines):
6026 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6027 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6028 (message_log_check_duplicate): Remove parameters `prev_bol' and
6029 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6030 (redisplay_internal): Remove parameter `preserve_echo_area',
6031 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6032
6033 * indent.c (Fvertical_motion):
6034 * window.c (window_scroll_pixel_based, Frecenter):
6035 Don't pass `need_y_p' to `move_it_by_lines'.
6036
6037 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6038
6039 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6040 steal a few bits to be more compact.
6041 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6042 Remove unneeded casts.
6043
6044 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6045
6046 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6047
6048 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6049 binding" message (bug#7967).
6050
6051 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6052
6053 Fix more problems found by GCC 4.6.0's static checks.
6054
6055 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6056 Remove unused local var.
6057
6058 * editfns.c (Fmessage_box): Remove unused local var.
6059
6060 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6061 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6062 Omit unused local vars.
6063 * window.c (shrink_windows): Omit unused local var.
6064 * menu.c (digest_single_submenu): Omit unused local var.
6065 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6066 Omit unused local var.
6067
6068 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6069 Don't assume string length fits in int.
6070 (keyremap_step, read_key_sequence): Use size_t for sizes.
6071 (read_key_sequence): Don't check last_real_key_start redundantly.
6072
6073 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6074 instead of alloca (Bug#8344).
6075
6076 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6077 (Fbacktrace_frame): Don't assume nframes fits in int.
6078
6079 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6080
6081 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6082 concerns.
6083
6084 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6085
6086 * cm.c (calccost): Turn while-do into do-while, for clarity.
6087
6088 * keyboard.c (syms_of_keyboard): Use the same style as later
6089 in this function when indexing through an array. This also
6090 works around GCC bug 48267.
6091
6092 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6093
6094 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6095
6096 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6097 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6098
6099 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6100 This avoids undefined behavior on integer overflow, and is a bit
6101 more convenient anyway since it is compared to a size_t variable.
6102
6103 Variadic C functions now count arguments with size_t, not int.
6104 This avoids an unnecessary limitation on 64-bit machines, which
6105 caused (substring ...) to crash on large vectors (Bug#8344).
6106 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6107 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6108 All variadic functions and their callers changed accordingly.
6109 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6110 * data.c (arith_driver, float_arith_driver): Likewise.
6111 * editfns.c (general_insert_function): Likewise.
6112 * eval.c (struct backtrace.nargs, interactive_p)
6113 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6114 (funcall_lambda, mark_backtrace): Likewise.
6115 * fns.c (concat): Likewise.
6116 * frame.c (x_set_frame_parameters): Likewise.
6117 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6118 0 if not found, not -1. All callers changed.
6119
6120 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6121 (stack_copy_size): Now size_t, not int.
6122 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6123
6124 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6125
6126 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6127 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6128 All callers changed.
6129
6130 * lisp.h (multibyte_char_to_unibyte):
6131 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6132 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6133 * character.h (CHAR_TO_BYTE8):
6134 * cmds.c (internal_self_insert):
6135 * editfns.c (general_insert_function):
6136 * keymap.c (push_key_description):
6137 * search.c (Freplace_match):
6138 * xdisp.c (message_dolog, set_message_1): All callers changed.
6139
6140 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6141
6142 * keyboard.c (safe_run_hook_funcall): New function.
6143 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6144 don't set the hook to nil, but remove the offending function instead.
6145 (Qcommand_hook_internal): Remove, unused.
6146 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6147 Vcommand_hook_internal.
6148
6149 * eval.c (enum run_hooks_condition): Remove.
6150 (funcall_nil, funcall_not): New functions.
6151 (run_hook_with_args): Call each function through a `funcall' argument.
6152 Remove `cond' argument, now redundant.
6153 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6154 (Frun_hook_with_args_until_failure): Adjust accordingly.
6155 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6156
6157 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6158
6159 * dispextern.h (string_buffer_position): Remove declaration.
6160
6161 * print.c (strout): Remove parameter `multibyte', unused since
6162 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6163
6164 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6165 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6166 All callers changed.
6167
6168 * w32.c (_wsa_errlist): Use braces for struct initializers.
6169
6170 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6171 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6172 All callers changed.
6173 (string_buffer_position): Likewise. Also, make static (it's never
6174 used outside xdisp.c).
6175 (cursor_row_p): Remove parameter `w', unused since
6176 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6177 (decode_mode_spec): Remove parameter `precision', introduced during
6178 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6179 All callers changed.
6180
6181 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6182
6183 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6184
6185 2011-03-27 Anders Lindgren <andlind@gmail.com>
6186
6187 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6188 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6189 (ns_update_auto_hide_menu_bar): New functions.
6190 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6191 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6192 ns_constrain_all_frames.
6193 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6194 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6195
6196 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6197
6198 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6199
6200 2011-03-27 Glenn Morris <rgm@gnu.org>
6201
6202 * syssignal.h: Replace RETSIGTYPE with void.
6203 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6204 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6205 Replace SIGTYPE with void everywhere.
6206 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6207 * s/template.h (SIGTYPE): Remove commented out definition.
6208
6209 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6210
6211 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6212 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6213
6214 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6215
6216 * w32.c (read_unc_volume): Use parameter `henum', instead of
6217 global variable `wget_enum_handle'.
6218
6219 * keymap.c (describe_vector): Remove parameters `indices' and
6220 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6221 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6222
6223 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6224
6225 * keyboard.c (timer_check): Remove parameter `do_it_now',
6226 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6227 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6228 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6229
6230 * keyboard.c (read_char):
6231 * w32menu.c (w32_menu_display_help):
6232 * xmenu.c (show_help_event, menu_help_callback):
6233 Adjust calls to `show_help_echo'.
6234
6235 * gtkutil.c (xg_maybe_add_timer):
6236 * keyboard.c (readable_events):
6237 * process.c (wait_reading_process_output):
6238 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6239
6240 * insdel.c (adjust_markers_gap_motion):
6241 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6242 (gap_left, gap_right): Don't call it.
6243
6244 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6245
6246 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6247 incurred during fontification.
6248
6249 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6250
6251 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6252 (DEFVAR_PER_BUFFER): Don't pass it.
6253
6254 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6255 (scrolling_window): Don't pass it.
6256
6257 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6258
6259 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6260
6261 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6262 and `suffix'.
6263 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6264 of variables specific to SELinux and computation of `encoded_absname'.
6265
6266 * image.c (XPutPixel): Remove unused variable `height'.
6267
6268 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6269
6270 * unexw32.c (get_section_info): Remove unused variable `section'.
6271
6272 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6273 (system_process_attributes): Remove unused variable `sess'.
6274 (sys_read): Remove unused variable `err'.
6275
6276 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6277 (w32_wnd_proc): Remove unused variable `isdead'.
6278 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6279 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6280 (x_create_tip_frame): Remove unused variable `tem'.
6281
6282 * w32inevt.c (w32_console_read_socket):
6283 Remove unused variable `no_events'.
6284
6285 * w32term.c (x_draw_composite_glyph_string_foreground):
6286 Remove unused variable `width'.
6287
6288 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6289
6290 * w32term.c (x_set_glyph_string_clipping):
6291 Don't pass uninitialized region to CombineRgn.
6292
6293 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6294
6295 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6296 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6297 (Fx_close_connection): Remove unused variable `i'.
6298
6299 * w32font.c (w32font_draw): Return number of glyphs.
6300 (w32font_open_internal): Remove unused variable `i'.
6301 (w32font_driver): Add missing initializer.
6302
6303 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6304 (fill_in_menu): Remove unused variable `items_added'.
6305
6306 * w32term.c (last_mouse_press_frame): Remove static global variable.
6307 (w32_clip_to_row): Remove unused variable `f'.
6308 (x_delete_terminal): Remove unused variable `i'.
6309
6310 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6311 (NOTHING): Remove unused static global variable.
6312 (uniscribe_check_otf): Remove unused variable `table'.
6313 (uniscribe_font_driver): Add missing initializers.
6314
6315 2011-03-23 Julien Danjou <julien@danjou.info>
6316
6317 * term.c (Fsuspend_tty, Fresume_tty):
6318 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6319 * window.c (temp_output_buffer_show):
6320 * insdel.c (signal_before_change):
6321 * frame.c (Fhandle_switch_frame):
6322 * fileio.c (Fdo_auto_save):
6323 * emacs.c (Fkill_emacs):
6324 * editfns.c (save_excursion_restore):
6325 * cmds.c (internal_self_insert):
6326 * callint.c (Fcall_interactively):
6327 * buffer.c (Fkill_all_local_variables):
6328 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6329 Use Frun_hooks.
6330 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6331 unconditionnaly since it does the check itself.
6332
6333 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6334
6335 Fix more problems found by GCC 4.5.2's static checks.
6336
6337 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6338 the first time through the loop, since we know p0 < p1 then.
6339 This also avoids a gcc -Wstrict-overflow warning.
6340
6341 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6342 leading to a memory leak, possible in functions like
6343 load_charset_map_from_file that can allocate an unbounded number
6344 of objects (Bug#8318).
6345
6346 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6347 that could (at least in theory) be that large.
6348
6349 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6350 This is less likely to overflow, and avoids undefined behavior if
6351 overflow does occur. All callers changed. Use strtoul to scan
6352 for the unsigned long integer.
6353 (pint2hrstr): Simplify and tune code slightly.
6354 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6355
6356 * scroll.c (do_scrolling): Work around GCC bug 48228.
6357 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6358
6359 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6360 This also avoids a warning with gcc -Wstrict-overflow.
6361 (validate_x_resource_name): Simplify count usage.
6362 This also avoids a warning with gcc -Wstrict-overflow.
6363
6364 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6365 fail (Bug#8306).
6366
6367 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6368
6369 * process.c (Fmake_network_process): Use socklen_t, not int,
6370 where POSIX says socklen_t is required in portable programs.
6371 This fixes a porting bug on hosts like 64-bit HP-UX, where
6372 socklen_t is wider than int (Bug#8277).
6373 (Fmake_network_process, server_accept_connection):
6374 (wait_reading_process_output, read_process_output):
6375 Likewise.
6376
6377 * process.c: Rename or move locals to avoid shadowing.
6378 (list_processes_1, Fmake_network_process):
6379 (read_process_output_error_handler, exec_sentinel_error_handler):
6380 Rename or move locals.
6381 (Fmake_network_process): Define label "retry_connect" only if needed.
6382 (Fnetwork_interface_info): Fix pointer signedness.
6383 (process_send_signal): Add cast to avoid pointer signedness problem.
6384 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6385 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6386
6387 Make tparam.h and terminfo.c consistent.
6388 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6389 Include tparam.h instead, since it declares them.
6390 * cm.h (PC): Remove extern decl; tparam.h now does this.
6391 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6392 * terminfo.c: Include tparam.h, to check interfaces.
6393 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6394 (tparam): Adjust signature to match interface in tparam.h;
6395 this removes some undefined behavior. Check that outstring and len
6396 are zero, which they always are with Emacs.
6397 * tparam.h (PC, BC, UP): New extern decls.
6398
6399 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6400 (xftfont_open): Rename locals to avoid shadowing.
6401
6402 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6403 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6404 (OTF_TAG_SYM): Omit macro if not needed.
6405 (ftfont_list): Remove unused local.
6406 (get_adstyle_property, ftfont_pattern_entity):
6407 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6408 Rename locals to avoid shadowing.
6409
6410 * xfont.c (xfont_list_family): Mark var as initialized.
6411
6412 * xml.c (make_dom): Now static.
6413
6414 * composite.c (composition_compute_stop_pos): Rename local to
6415 avoid shadowing.
6416 (composition_reseat_it): Remove unused locals.
6417 (find_automatic_composition, composition_adjust_point): Likewise.
6418 (composition_update_it): Mark var as initialized.
6419 (find_automatic_composition): Mark vars as initialized,
6420 with a FIXME (Bug#8290).
6421
6422 character.h: Rename locals to avoid shadowing.
6423 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6424 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6425 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6426 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6427 to avoid shadowing.
6428
6429 * textprop.c (property_change_between_p): Remove; unused.
6430
6431 * intervals.c (interval_start_pos): Now static.
6432
6433 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6434
6435 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6436 Rename locals to avoid shadowing.
6437
6438 * sound.c (wav_play, au_play, Fplay_sound_internal):
6439 Fix pointer signedness.
6440 (alsa_choose_format): Remove unused local var.
6441 (wav_play): Initialize a variable to 0, to prevent undefined
6442 behavior (Bug#8278).
6443
6444 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6445
6446 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6447
6448 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6449 clobbering (Bug#8298).
6450 * sysdep.c (sys_subshell): Likewise.
6451 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6452
6453 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6454 This should get cleaned up, so that child_setup has the
6455 same signature on all platforms.
6456
6457 * callproc.c (call_process_cleanup): Now static.
6458 (relocate_fd): Rename locals to avoid shadowing.
6459
6460 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6461
6462 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6463 not to be necessary, and produces flickering.
6464
6465 2011-03-20 Glenn Morris <rgm@gnu.org>
6466
6467 * config.in: Remove file.
6468
6469 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6470
6471 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6472 are now in src/globals.h.
6473 (syms_of_minibuf): Remove spurious & from previous change.
6474
6475 2011-03-20 Leo <sdl.web@gmail.com>
6476
6477 * minibuf.c (completing-read-function): New variable.
6478 (completing-read-default): Rename from completing-read.
6479 (completing-read): Call completing-read-function.
6480
6481 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6482
6483 * xfaces.c (Fx_load_color_file):
6484 Read color file from absolute filename (bug#8250).
6485
6486 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6487
6488 * makefile.w32-in: Update dependencies.
6489
6490 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6491
6492 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6493
6494 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6495
6496 Fix more problems found by GCC 4.5.2's static checks.
6497
6498 * process.c (make_serial_process_unwind, send_process_trap):
6499 (sigchld_handler): Now static.
6500
6501 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6502 That way, the code declares only the vars that it needs.
6503 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6504 * s/cygwin.h (PTY_ITERATION): Likewise.
6505 * s/darwin.h (PTY_ITERATION): Likewise.
6506 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6507
6508 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6509 * process.c (allocate_pty): Don't declare stb unless it's needed.
6510
6511 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6512 (CONSTANTLIM): Remove; unused.
6513 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6514 Define only if needed.
6515
6516 * unexelf.c (unexec): Name an expression,
6517 to avoid gcc -Wbad-function-cast warning.
6518 Use a different way to cause a compilation error if anyone uses
6519 n rather than nn, a way that does not involve shadowing.
6520 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6521
6522 * deps.mk (unexalpha.o): Remove; unused.
6523
6524 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6525 * unexec.h: New file.
6526 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6527 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6528 Depend on unexec.h.
6529 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6530 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6531 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6532 Change as necessary to match prototype in unexec.h.
6533
6534 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6535 shadowing.
6536 (back_comment, skip_chars): Mark vars as initialized.
6537
6538 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6539 Rename locals to avoid shadowing.
6540
6541 * lread.c (read1): Rewrite so as not to use empty "else".
6542 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6543
6544 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6545
6546 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6547 warning when compiling print.c.
6548
6549 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6550 instead of using an uninitialized var.
6551 (font_sort_entities): Mark var as initialized.
6552
6553 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6554
6555 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6556 pointers to constants.
6557 (font_parse_fcname): Remove unused vars.
6558 (font_delete_unmatched): Now static.
6559 (font_get_spec): Remove; unused.
6560 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6561 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6562 Rename or move locals to avoid shadowing.
6563
6564 * fns.c (require_nesting_list, require_unwind): Now static.
6565 (Ffillarray): Rename locals to avoid shadowing.
6566
6567 * floatfns.c (domain_error2): Define only if needed.
6568 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6569
6570 * alloc.c (mark_backtrace): Move decl from here ...
6571 * lisp.h: ... to here, so that it can be checked.
6572
6573 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6574 (Fdefvar): Rewrite so as not to use empty "else".
6575 (lisp_indirect_variable): Name an expression,
6576 to avoid gcc -Wbad-function-cast warning.
6577 (Fdefvar): Rename locals to avoid shadowing.
6578
6579 * callint.c (quotify_arg, quotify_args): Now static.
6580 (Fcall_interactively): Rename locals to avoid shadowing.
6581 Use const pointer when appropriate.
6582
6583 * lisp.h (get_system_name, get_operating_system_release):
6584 Move decls here, to check interfaces.
6585 * process.c (get_operating_system_release): Move decl to lisp.h.
6586 * xrdb.c (get_system_name): Likewise.
6587 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6588 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6589 some of which prompt warnings from gcc -Wbad-function-cast.
6590 (Fformat_time_string, Fencode_time, Finsert_char):
6591 (Ftranslate_region_internal, Fformat):
6592 Rename or remove local vars to avoid shadowing.
6593 (Ftranslate_region_internal): Mark var as initialized.
6594
6595 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6596 avoid shadowing.
6597
6598 * lisp.h (eassert): Check that the argument compiles, even if
6599 ENABLE_CHECKING is not defined.
6600
6601 * data.c (Findirect_variable): Name an expression, to avoid
6602 gcc -Wbad-function-cast warning.
6603 (default_value, arithcompare, arith_driver, arith_error): Now static.
6604 (store_symval_forwarding): Rename local to avoid shadowing.
6605 (Fmake_variable_buffer_local, Fmake_local_variable):
6606 Mark variables as initialized.
6607 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6608
6609 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6610 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6611 Rename locals to avoid shadowing.
6612 (mark_stack): Move local variables into the #ifdef region where
6613 they're used.
6614 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6615 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6616 needed otherwise.
6617 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6618 (GC_STRING_CHARS): Remove; not used.
6619 (Fmemory_limit): Cast sbrk's returned value to char *.
6620
6621 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6622 avoids undefined behavior in theory.
6623
6624 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6625
6626 Use functions, not macros, for up- and down-casing (Bug#8254).
6627 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6628 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6629 to use the following functions instead of these macros.
6630 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6631 EMACS_INT, since callers assume the returned value fits in int.
6632 (upcase1): Likewise, for UPCASE_TABLE.
6633 (uppercasep, lowercasep, upcase): New static inline functions.
6634 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6635 the race-condition problem in the old DOWNCASE.
6636
6637 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6638 Rename locals to avoid shadowing.
6639 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6640 (regex_compile, re_search_2, re_match_2_internal):
6641 Remove unused local vars.
6642 (FREE_VAR): Rewrite so as not to use empty "else",
6643 which gcc can warn about.
6644 (regex_compile, re_match_2_internal): Mark locals as initialized.
6645 (RETALLOC_IF): Define only if needed.
6646 (WORDCHAR_P): Likewise. This one is never needed, but is used
6647 only in a comment talking about a compiler bug, so put inside
6648 the #if 0 of that comment.
6649 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6650 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6651 Remove; unused.
6652
6653 * search.c (boyer_moore): Rename locals to avoid shadowing.
6654 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6655 (PREV_CHAR_BOUNDARY): Likewise.
6656
6657 * search.c (simple_search): Remove unused var.
6658
6659 * dired.c (compile_pattern): Move decl from here ...
6660 * lisp.h: ... to here, so that it can be checked.
6661 (struct re_registers): New forward decl.
6662
6663 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6664
6665 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6666 All uses changed.
6667 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6668 Rename locals to avoid shadowing.
6669 (Fvertical_motion): Mark locals as initialized.
6670
6671 * casefiddle.c (casify_object, casify_region): Now static.
6672 (casify_region): Mark local as initialized.
6673
6674 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6675
6676 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6677 New macros, so that the caller can use some names other than
6678 gcpro1, gcpro2, etc.
6679 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6680 of the new macros.
6681 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6682 argument, for consistency with GCPRO2_VAR, etc: it is now the
6683 prefix of the variable, not the variable itself. All uses
6684 changed.
6685 * dired.c (directory_files_internal, file_name_completion):
6686 Rename locals to avoid shadowing.
6687
6688 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6689 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6690 dired.c's scmp function, had undefined behavior.
6691 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6692 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6693 * buffer.h: ... to here, because these macros use current_buffer,
6694 and the new implementation with inline functions needs to have
6695 current_buffer in scope now, rather than later when the macros
6696 are used.
6697 (downcase, upcase1): New static inline functions.
6698 (DOWNCASE, UPCASE1): Reimplement using these functions.
6699 This avoids undefined behavior in expressions like
6700 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6701 from race conditions in accessing the global variables
6702 case_temp1 and case_temp2.
6703 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6704 * lisp.h (case_temp1, case_temp2): Remove their decls.
6705 * character.h (ASCII_CHAR_P): Move from here ...
6706 * lisp.h: ... to here, so that the inline functions mentioned
6707 above can use them.
6708
6709 * dired.c (directory_files_internal_unwind): Now static.
6710
6711 * fileio.c (file_name_as_directory, directory_file_name):
6712 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6713 Now static.
6714 (file_name_as_directory): Use const pointers when appropriate.
6715 (Fexpand_file_name): Likewise. In particular, newdir might
6716 point at constant storage, so make it a const pointer.
6717 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6718 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6719 signedness issues.
6720 (Fset_file_times, Finsert_file_contents, auto_save_error):
6721 Rename locals to avoid shadowing.
6722
6723 * minibuf.c (choose_minibuf_frame_1): Now static.
6724 (Ftry_completion, Fall_completions): Rename or remove locals
6725 to avoid shadowing.
6726
6727 * marker.c (bytepos_to_charpos): Remove; unused.
6728
6729 * lisp.h (verify_bytepos, count_markers): New decls,
6730 so that gcc does not warn that these functions aren't declared.
6731
6732 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6733 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6734 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6735 (copy_text): Remove unused local var.
6736
6737 * filelock.c (within_one_second): Now static.
6738 (lock_file_1): Rename local to avoid shadowing.
6739
6740 * buffer.c (fix_overlays_before): Mark locals as initialized.
6741 (fix_start_end_in_overlays): Likewise. This function should be
6742 simplified by using pointers-to-pointers, but that's a different
6743 matter.
6744 (switch_to_buffer_1): Now static.
6745 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6746 (report_overlay_modification): Rename locals to avoid shadowing.
6747
6748 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6749 Fix pointer signedness issue.
6750 (sys_subshell): Mark local as volatile if checking for lint,
6751 to suppress a gcc -Wclobbered warning that does not seem to be right.
6752 (MAXPATHLEN): Define only if needed.
6753
6754 * process.c (serial_open, serial_configure): Move decls from here ...
6755 * systty.h: ... to here, so that they can be checked.
6756
6757 * fns.c (get_random, seed_random): Move extern decls from here ...
6758 * lisp.h: ... to here, so that they can be checked.
6759
6760 * sysdep.c (reset_io): Now static.
6761 (wait_for_termination_signal): Remove; unused.
6762
6763 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6764 (copy_keymap_item, append_key, push_text_char_description):
6765 Now static.
6766 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6767 (DENSE_TABLE_SIZE): Remove; unused.
6768 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6769 (describe_map_tree):
6770 Rename locals to avoid shadowing.
6771
6772 * keyboard.c: Declare functions static if they are not used elsewhere.
6773 (echo_char, echo_dash, cmd_error, top_level_2):
6774 (poll_for_input, handle_async_input): Now static.
6775 (read_char, kbd_buffer_get_event, make_lispy_position):
6776 (make_lispy_event, make_lispy_movement, apply_modifiers):
6777 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6778 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6779 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6780 (read_key_sequence, read_char): Mark locals as initialized.
6781 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6782
6783 * keyboard.h (make_ctrl_char): New decl.
6784 (mark_kboards): Move decl here ...
6785 * alloc.c (mark_kboards): ... from here.
6786
6787 * lisp.h (force_auto_save_soon): New decl.
6788
6789 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6790 (DEFINE_DUMMY_FUNCTION): New macro.
6791 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6792 Use it.
6793 (main): Add casts to avoid warnings
6794 if GCC considers string literals to be constants.
6795
6796 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6797
6798 * dbusbind.c: Pointer signedness fixes.
6799 (xd_signature, xd_append_arg, xd_initialize):
6800 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6801 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6802 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6803 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6804
6805 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6806 if GCC considers string literals to be constants.
6807 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6808
6809 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6810
6811 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6812 (print_preprocess, print_object): New macro to fix last change.
6813
6814 * print.c (print_preprocess): Don't forget font objects.
6815
6816 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6817
6818 * emacs.c (USAGE3): Doc fixes.
6819
6820 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6821
6822 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6823 structure.
6824
6825 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6826
6827 * lisp.h (VWindow_system, Qfile_name_history):
6828 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6829 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6830 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6831
6832 * w32select.c: Don't #include "keyboard.h".
6833 (run_protected): Add extern declaration for waiting_for_input.
6834
6835 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6836 * w32console.c (detect_input_pending, read_input_pending)
6837 (encode_terminal_code):
6838 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6839 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6840 (w32_system_caret_y, Qfile_name_history):
6841 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6842 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6843 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6844 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6845 * w32proc.c (Qlocal, report_file_error):
6846 * w32term.c (Vwindow_system, updating_frame):
6847 * w32uniscribe.c (initialized, uniscribe_font_driver):
6848 Remove unneeded extern declarations.
6849
6850 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6851
6852 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6853
6854 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6855
6856 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6857 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6858 These macros can no longer be used for assignment.
6859
6860 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6861 Assign struct members directly, instead of using BUF_BEGV etc.
6862 (record_buffer_markers, fetch_buffer_markers): New functions for
6863 recording and fetching special buffer markers.
6864 (set_buffer_internal_1, set_buffer_temp): Use them.
6865
6866 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6867
6868 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6869
6870 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6871 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6872
6873 * xdisp.c (hscroll_window_tree):
6874 (reconsider_clip_changes): Use PT instead of BUF_PT.
6875
6876 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6877
6878 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6879 $(EMACS_ROOT)/lib/intprops.h.
6880
6881 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6882
6883 Fix more problems found by GCC 4.5.2's static checks.
6884
6885 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6886 to unsigned char * to avoid compiler diagnostic.
6887 (xg_free_frame_widgets): Make it clear that a local variable is
6888 needed only if USE_GTK_TOOLTIP.
6889 (gdk_window_get_screen): Make it clear that this macro is needed
6890 only if USE_GTK_TOOLTIP.
6891 (int_gtk_range_get_value): New function, which avoids a diagnostic
6892 from gcc -Wbad-function-cast.
6893 (xg_set_toolkit_scroll_bar_thumb): Use it.
6894 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6895 diagnostic from gcc -Wbad-function-cast.
6896 (get_utf8_string, xg_get_file_with_chooser):
6897 Rename locals to avoid shadowing.
6898 (create_dialog): Move locals to avoid shadowing.
6899
6900 * xgselect.c (xg_select): Remove unused var.
6901
6902 * image.c (four_corners_best): Mark locals as initialized.
6903 (gif_load): Initialize transparent_p to zero (Bug#8238).
6904 Mark another local as initialized.
6905 (my_png_error, my_error_exit): Mark with NO_RETURN.
6906
6907 * image.c (clear_image_cache): Now static.
6908 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6909 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6910 (x_edge_detection): Remove unnecessary cast that
6911 gcc -Wbad-function-cast diagnoses.
6912 (gif_load): Fix pointer signedness.
6913 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6914 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6915
6916 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6917
6918 Improve quality of tests for time stamp overflow.
6919 For example, without this patch (encode-time 0 0 0 1 1
6920 1152921504606846976) returns the obviously-bogus value (-948597
6921 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6922 reports time overflow. See
6923 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6924 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6925 * editfns.c: Include limits.h and intprops.h.
6926 (TIME_T_MIN, TIME_T_MAX): New macros.
6927 (time_overflow): Move earlier, to before first use.
6928 (hi_time, lo_time): New functions, for an accurate test for
6929 out-of-range times.
6930 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6931 (Fget_internal_run_time): Don't assume time_t fits in int.
6932 (make_time): Use list2 instead of Fcons twice.
6933 (Fdecode_time): More accurate test for out-of-range times.
6934 (check_tm_member): New function.
6935 (Fencode_time): Use it, to test for out-of-range times.
6936 (lisp_time_argument): Don't rely on undefined left-shift and
6937 right-shift behavior when checking for time stamp overflow.
6938
6939 * editfns.c (time_overflow): New function, refactoring common code.
6940 (Fformat_time_string, Fdecode_time, Fencode_time):
6941 (Fcurrent_time_string): Use it.
6942
6943 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6944 * dired.c (make_time): Move to ...
6945 * editfns.c (make_time): ... here.
6946 * systime.h: Note the move.
6947
6948 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6949
6950 * fringe.c (update_window_fringes): Remove unused variables.
6951
6952 * unexmacosx.c (copy_data_segment): Also copy __got section.
6953 (Bug#8223)
6954
6955 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6956
6957 * termcap.c [MSDOS]: Include "msdos.h".
6958 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6959 Constify `char *' arguments and their references according to
6960 prototypes in tparam.h.
6961
6962 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6963
6964 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6965 Adapt all references accordingly.
6966
6967 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6968
6969 2011-03-11 Tom Tromey <tromey@redhat.com>
6970
6971 * buffer.c (syms_of_buffer): Remove obsolete comment.
6972
6973 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6974
6975 * termhooks.h (encode_terminal_code): Declare prototype.
6976
6977 * msdos.c (encode_terminal_code): Don't declare prototype.
6978
6979 * term.c (encode_terminal_code): Now external again, used by
6980 w32console.c and msdos.c.
6981
6982 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6983 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6984
6985 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6986
6987 Fix some minor problems found by GCC 4.5.2's static checks.
6988
6989 * fringe.c (update_window_fringes): Mark locals as initialized
6990 (Bug#8227).
6991 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6992
6993 * alloc.c (mark_fringe_data): Move decl from here ...
6994 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6995 to check its interface.
6996 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6997
6998 * fontset.c (free_realized_fontset): Now static.
6999 (Fset_fontset_font): Rename local to avoid shadowing.
7000 (fontset_font): Mark local as initialized.
7001 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7002
7003 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7004
7005 * xselect.c (x_disown_buffer_selections): Remove; not used.
7006 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7007 (x_own_selection, Fx_disown_selection_internal): Rename locals
7008 to avoid shadowing.
7009 (x_handle_dnd_message): Remove local to avoid shadowing.
7010
7011 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7012 so that the caller can use some name other than gcpro1.
7013 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7014 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7015 (Fx_backspace_delete_keys_p):
7016 Use them to avoid shadowing, and rename vars to avoid shadowing.
7017 (x_decode_color, x_set_name, x_window): Now static.
7018 (Fx_create_frame): Add braces to silence GCC warning.
7019 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7020 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7021 Remove unused locals.
7022 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7023 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7024 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7025 macros.
7026
7027 * xterm.h (x_mouse_leave): New decl.
7028
7029 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7030 Remove unused functions.
7031 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7032 (x_calc_absolute_position): Now static.
7033 (XTread_socket): Don't define label "out" unless it's used.
7034 Don't declare local "event" unless it's used.
7035 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7036 unless they are used.
7037 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7038 (x_fatal_error_signal): Remove; not used.
7039 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7040 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7041 (x_error_catcher, x_connection_closed, x_error_handler):
7042 (x_error_quitter, xembed_send_message, x_iconify_frame):
7043 (my_log_handler): Rename locals to avoid shadowing.
7044 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7045 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7046
7047 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7048 Rename or move locals to avoid shadowing.
7049 (tty_defined_color, merge_face_heights): Now static.
7050 (free_realized_faces_for_fontset): Remove; not used.
7051 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7052 does not deduce is never used uninitialized.
7053 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7054 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7055
7056 * terminal.c (store_terminal_param): Now static.
7057
7058 * xmenu.c (menu_highlight_callback): Now static.
7059 (set_frame_menubar): Remove unused local.
7060 (xmenu_show): Rename parameter to avoid shadowing.
7061 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7062 since they might point to immutable storage.
7063 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7064 since it's unused otherwise.
7065
7066 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7067 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7068 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7069 avoids a gcc -Wuninitialized diagnostic.
7070 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7071 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7072 does not deduce are never used uninitialized.
7073
7074 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7075
7076 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7077 * window.c (window_loop, size_window):
7078 (run_window_configuration_change_hook, enlarge_window): Likewise.
7079
7080 * window.c (display_buffer): Now static.
7081 (size_window): Mark variables that gcc -Wuninitialized
7082 does not deduce are never used uninitialized.
7083 * window.h (check_all_windows): New decl, to forestall
7084 gcc -Wmissing-prototypes diagnostic.
7085 * dispextern.h (bidi_dump_cached_states): Likewise.
7086
7087 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7088 shadowing.
7089 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7090 Include <limits.h>.
7091 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7092 and to avoid gcc -Wuninitialized warning.
7093 (load_charset_map): Mark variables that gcc -Wuninitialized
7094 does not deduce are never used uninitialized.
7095 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7096
7097 * coding.c (coding_set_source, coding_set_destination):
7098 Use "else { /* comment */ }" rather than "else /* comment */;"
7099 for clarity, and to avoid gcc -Wempty-body warning.
7100 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7101 a block, when the outer 'i' will do.
7102 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7103 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7104 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7105 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7106 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7107 Rename locals to avoid shadowing.
7108 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7109 * coding.c (emacs_mule_char, encode_invocation_designation):
7110 Now static, since they're not used elsewhere.
7111 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7112 (decode_coding_object, encode_coding_object, detect_coding_system):
7113 (decode_coding_emacs_mule): Mark variables that gcc
7114 -Wuninitialized does not deduce are never used uninitialized.
7115 (detect_coding_iso_2022): Initialize a local variable that might
7116 be used uninitialized. Leave a FIXME because it's not clear that
7117 this initialization is needed. (Bug#8211)
7118 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7119 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7120 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7121 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7122 Remove unused macros.
7123
7124 * category.c (hash_get_category_set): Remove unused local var.
7125 (copy_category_table): Now static, since it's not used elsewhere.
7126 * character.c (string_count_byte8): Likewise.
7127
7128 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7129 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7130
7131 * chartab.c (copy_sub_char_table): Now static, since it's not used
7132 elsewhere.
7133 (sub_char_table_ref_and_range, char_table_ref_and_range):
7134 Rename locals to avoid shadowing.
7135 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7136
7137 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7138 (BIDI_BOB): Remove unused macro.
7139
7140 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7141 deduce are never used uninitialized.
7142 * term.c (encode_terminal_code): Likewise.
7143
7144 * term.c (encode_terminal_code): Now static. Remove unused local.
7145
7146 * tparam.h: New file.
7147 * term.c, tparam.h: Include it.
7148 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7149 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7150 Move these decls to tparam.h, and make them agree with what
7151 is actually in tparam.c. The previous trick of using incompatible
7152 decls in different modules does not conform to the C standard.
7153 All callers of tparam changed to use tparam's actual API.
7154 * tparam.c (tparam1, tparam, tgoto):
7155 Use const pointers where appropriate.
7156
7157 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7158 * cm.h (struct cm): Likewise.
7159 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7160 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7161 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7162 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7163 (turn_on_face, init_tty): Likewise.
7164 * termchar.h (struct tty_display_info): Likewise.
7165
7166 * term.c (term_mouse_position): Rename local to avoid shadowing.
7167
7168 * alloc.c (mark_ttys): Move decl from here ...
7169 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7170
7171 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7172
7173 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7174
7175 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7176
7177 * search.c (compile_pattern_1): Remove argument regp, unused since
7178 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7179 (compile_pattern): Don't pass it.
7180
7181 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7182
7183 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7184 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7185 for ! HAVE_GTK3.
7186 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7187
7188 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7189
7190 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7191 gdk_window_get_screen, gdk_window_get_geometry,
7192 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7193 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7194 (xg_get_pixbuf_from_pixmap): New function.
7195 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7196 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7197 Call xg_get_pixbuf_from_pixmap instead of
7198 gdk_pixbuf_get_from_drawable.
7199 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7200 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7201 (xg_check_special_colors): Use GtkStyleContext and its functions
7202 for HAVE_GTK3.
7203 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7204 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7205 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7206 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7207 Call gtk_widget_get_preferred_size.
7208 (xg_frame_resized): gdk_window_get_geometry only takes 5
7209 parameters.
7210 (xg_win_to_widget, xg_event_is_for_menubar):
7211 Call gdk_x11_window_lookup_for_display.
7212 (xg_set_widget_bg): New function.
7213 (delete_cb): New function.
7214 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7215 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7216 (xg_set_background_color): Call xg_set_widget_bg.
7217 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7218 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7219 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7220 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7221 if ! HAVE_GTK3.
7222 (update_frame_tool_bar): Call gtk_widget_hide.
7223 (xg_initialize): Use GDK_KEY_g.
7224
7225 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7226 if ! HAVE_GTK3
7227 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7228
7229 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7230 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7231 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7232
7233 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7234
7235 * w32xfns.c (select_palette): Check success of RealizePalette against
7236 GDI_ERROR, not zero.
7237
7238 See ChangeLog.11 for earlier changes.
7239
7240 ;; Local Variables:
7241 ;; coding: utf-8
7242 ;; End:
7243
7244 Copyright (C) 2011 Free Software Foundation, Inc.
7245
7246 This file is part of GNU Emacs.
7247
7248 GNU Emacs is free software: you can redistribute it and/or modify
7249 it under the terms of the GNU General Public License as published by
7250 the Free Software Foundation, either version 3 of the License, or
7251 (at your option) any later version.
7252
7253 GNU Emacs is distributed in the hope that it will be useful,
7254 but WITHOUT ANY WARRANTY; without even the implied warranty of
7255 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7256 GNU General Public License for more details.
7257
7258 You should have received a copy of the GNU General Public License
7259 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.