Remove aborts from internal_condition_case*.
[bpt/emacs.git] / src / ChangeLog
1 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2
3 * eval.c (internal_condition_case, internal_condition_case_1)
4 (internal_condition_case_2, internal_condition_case_n): Remove
5 unnecessary aborts (Bug#9081).
6
7 2011-08-17 Eli Zaretskii <eliz@gnu.org>
8
9 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
10 has no `load' handler, try opening the file locally. (Bug#9311)
11
12 2011-08-16 Ken Brown <kbrown@cornell.edu>
13
14 * gmalloc.c: Expand comment.
15
16 2011-08-16 Eli Zaretskii <eliz@gnu.org>
17
18 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
19 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
20
21 2011-08-16 Ken Brown <kbrown@cornell.edu>
22
23 Fix memory allocation problems in Cygwin build (Bug#9273).
24
25 * unexcw.c ( __malloc_initialized): Declare external variable.
26 (fixup_executable): Force the dumped emacs to reinitialize malloc.
27
28 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo): New
29 variables.
30 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
31 dumped emacs.
32 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
33 in the static heap.
34 [CYGWIN] (special_realloc): New function.
35 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
36 requests to realloc storage in the static heap.
37
38 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
39
40 * bidi.c (bidi_initialize): Remove unused local.
41
42 2011-08-15 Eli Zaretskii <eliz@gnu.org>
43
44 * biditype.h: File removed.
45
46 * bidimirror.h: File removed.
47
48 * deps.mk (bidi.o): Remove biditype.h and
49 bidimirror.h.
50
51 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
52 bidimirror.h.
53
54 * dispextern.h: Fix a typo in the comment to bidi_type_t.
55
56 * chartab.c: Improve commentary for the uniprop_table API.
57
58 * bidi.c (bidi_paragraph_init): Support zero value of
59 bidi_ignore_explicit_marks_for_paragraph_level.
60 (bidi_initialize): Use uniprop_table instead of including
61 biditype.h and bidimirror.h.
62
63 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
64 coordinates of the iterator when restoring from ppos_it.
65 (Bug#9296)
66
67 2011-08-14 Kenichi Handa <handa@m17n.org>
68
69 * process.c (create_process): Call setup_process_coding_systems
70 after the pid of the process is set to -1 (Bug#8162).
71
72 2011-08-14 Eli Zaretskii <eliz@gnu.org>
73
74 * xdisp.c (move_it_in_display_line_to): Don't invoke
75 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
76 ppos_it. Fixes vertical cursor motion when line beginning is
77 covered by an image. (Bug#9296)
78
79 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
80
81 * nsterm.h (ns_run_ascript): Declare.
82 (NSAPP_DATA2_RUNASSCRIPT): Define.
83
84 * nsfns.m (as_script, as_result, as_status): New static variables.
85 (ns_run_ascript): New function.
86 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
87 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
88 the event loop. Get status from as_status (Bug#7276).
89
90 * nsterm.m (sendEvent): If event is NSApplicationDefined and
91 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
92 the event loop (Bug#7276).
93
94 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
95
96 * gnutls.c (QCgnutls_bootprop_priority)
97 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
98 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
99 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
100 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
101 (QCgnutls_bootprop_verify_hostname_error)
102 (QCgnutls_bootprop_callbacks_verify): Rename from
103 Qgnutls_bootprop_..., all uses changed.
104
105 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
106 uses changed.
107
108 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
109
110 * xfaces.c (Qframe_set_background_mode): Now static.
111 * dispextern.h (Qframe_set_background_mode): Remove decl.
112
113 * process.c (Fnetwork_interface_info): Declare local only if needed.
114
115 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
116
117 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
118 (Fnetwork_interface_list): Allocate in increments of bytes instead
119 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
120 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
121 sockaddr.
122 (struct ifflag_def): notrailers is smart on OSX.
123 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
124 Get hardware address with getifaddrs if available.
125
126 2011-08-12 Eli Zaretskii <eliz@gnu.org>
127
128 * xdisp.c (iterate_out_of_display_property): xassert that
129 IT->position is set to within IT->object's boundaries. Break from
130 the loop as soon as EOB is reached; avoids infloops in redisplay
131 when IT->position is set up wrongly due to some bug. Set
132 IT->current to match the bidi iterator unconditionally.
133 (push_display_prop): Allow GET_FROM_STRING as IT->method on
134 entry. Force push_it to save on the stack the current
135 buffer/string position, to be restored by pop_it. Fix flags in
136 the iterator structure wrt the object coming from a display
137 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
138 properties. (Bug#9284)
139
140 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
141
142 * fontset.c (fontset_get_font_group): Add proper type checks.
143 (Bug#9172)
144
145 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
146
147 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
148 and LC_VERSION_MIN_MACOSX.
149 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
150 (dump_it) [LC_FUNCTION_STARTS]: Use it.
151
152 2011-08-08 Eli Zaretskii <eliz@gnu.org>
153
154 * xdisp.c (forward_to_next_line_start): Allow to use the
155 no-display-properties-and-no-overlays under bidi display. Set
156 disp_pos in the bidi iterator to avoid searches for display
157 properties and overlays.
158
159 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
160
161 * editfns.c (Fset_time_zone_rule): Document relationship with the
162 setenv function.
163
164 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
165 the font entity extracted from the cache (Bug#8109).
166
167 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
168
169 * composite.c (autocmp_chars): Don't reset point. That is done by
170 restore_point_unwind (Bug#5984).
171
172 2011-08-07 Juri Linkov <juri@jurta.org>
173
174 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
175 to show the arg `TIME' instead of `TIMEVAL'.
176
177 2011-08-06 Eli Zaretskii <eliz@gnu.org>
178
179 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
180 display property strides EOL and includes a newline, as in
181 longlines-mode. (Bug#9254)
182 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
183 word-wrap under bidirectional display. (Bug#9224)
184
185 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
186 is non-zero, even if the data buffer is NULL. Fixes a crash in
187 vertical-motion with longlines-mode. (Bug#9254)
188
189 2011-08-05 Eli Zaretskii <eliz@gnu.org>
190
191 * bidi.c <bidi_cache_total_alloc>: Now static.
192 (bidi_initialize): Initialize bidi_cache_total_alloc.
193
194 *xdisp.c (display_line): Release buffer allocated for shelved bidi
195 cache. (Bug#9221)
196
197 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
198 amount allocated this far in `bidi_cache_total_alloc'.
199 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
200 non-zero, only free the data buffer without restoring the cache
201 contents. All callers changed.
202
203 * dispextern.h (bidi_unshelve_cache): Update prototype.
204
205 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
206 (move_it_in_display_line, move_it_to)
207 (move_it_vertically_backward, move_it_by_lines): Replace the call
208 to xfree to an equivalent call to bidi_unshelve_cache.
209 (move_it_in_display_line_to): Fix logic of returning
210 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
211
212 2011-08-05 Eli Zaretskii <eliz@gnu.org>
213
214 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
215 came from a string character with a `cursor' property. (Bug#9229)
216
217 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
218
219 * Makefile.in (LIB_PTHREAD): New variable.
220 (LIBES): Add LIB_PTHREAD (Bug#9216).
221
222 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
223 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
224
225 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
226
227 * regex.c (re_iswctype): Remove some redundant boolean
228 conversions.
229
230 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
231
232 * xterm.c (x_find_topmost_parent): New function.
233 (x_set_frame_alpha): Find topmost parent window with
234 x_find_topmost_parent and set the property there also (bug#9181).
235 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
236
237 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
238
239 * callproc.c (Fcall_process): Avoid vfork clobbering
240 the local vars buffer, coding_systems, current_dir.
241
242 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
243
244 * keymap.c (Fmake_composed_keymap): Move to subr.el.
245
246 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
247
248 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
249 so that it is not optimized away.
250
251 * xdisp.c (compute_display_string_pos): Remove unused local.
252
253 2011-08-02 Eli Zaretskii <eliz@gnu.org>
254
255 Fix slow cursor motion and scrolling in large buffers with
256 selective display, like Org Mode buffers. (Bug#9218)
257
258 * dispextern.h (struct bidi_it): New member disp_prop_p.
259
260 * xdisp.c: Remove one-slot cache of display string positions.
261 (compute_display_string_pos): Accept an additional argument
262 DISP_PROP_P; callers changed. Scan at most 5K characters forward
263 for a display string or property. If found, set DISP_PROP_P
264 non-zero.
265
266 * bidi.c (bidi_fetch_char): Accept an additional argument
267 DISP_PROP_P, and pass it to compute_display_string_pos.
268 Only handle text covered by a display string if DISP_PROP_P is returned
269 non-zero. All callers of bidi_fetch_char changed.
270
271 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
272
273 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
274
275 2010-12-03 Don March <don@ohspite.net>
276
277 * keymap.c (Fdefine_key): Fix non-prefix key error message when
278 last character M-[char] is translated to ESC [char] (bug#7541).
279
280 2011-08-02 Kenichi Handa <handa@m17n.org>
281
282 * lisp.h (uniprop_table): Extern it.
283
284 * chartab.c (uniprop_table): Make it non-static.
285
286 2011-08-01 Eli Zaretskii <eliz@gnu.org>
287
288 * xdisp.c (forward_to_next_line_start): Accept additional argument
289 BIDI_IT_PREV, and store into it the state of the bidi iterator had
290 on the newline.
291 (reseat_at_next_visible_line_start): Use the bidi iterator state
292 returned by forward_to_next_line_start to restore the state of
293 it->bidi_it after backing up to previous newline. (Bug#9212)
294
295 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
296
297 * regex.c (re_comp): Protoize.
298 (re_exec): Fix return type.
299 (regexec): Fix type of `ret'. (Bug#9203)
300
301 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
302
303 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
304 This is needed if max-image-size is a floating-point number.
305
306 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
307
308 * print.c (print_object): Print empty symbol as ##.
309
310 * lread.c (read1): Read ## as empty symbol.
311
312 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
313
314 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
315 setting frame foreground color (Bug#9175).
316 (x_set_background_color): Likewise.
317
318 * nsmenu.m (-setText): Size tooltip dimensions precisely to
319 contents (Bug#9176).
320 (EmacsTooltip -init): Remove bezels and add shadows to
321 tooltip windows.
322
323 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
324 or scroll bar (Bug#8470).
325
326 * nsfont.m (nsfont_open): Remove assignment to voffset and
327 unnecessary vars hshink, expand, hd, full_height, min_height.
328 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
329
330 * nsterm.h (nsfont_info): Remove voffset field.
331
332 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
333
334 Implement strike-through and overline on NextStep (Bug#8863).
335
336 * nsfont.m (nsfont_open): Use underline position provided by font,
337 instead of hard-coded value of 2.
338 (nsfont_draw): Call ns_draw_text_decoration instead.
339
340 * nsterm.h: Add declaration for ns_draw_text_decoration.
341
342 * nsterm.m (ns_draw_text_decoration): New function for drawing
343 underline, overline, and strike-through.
344 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
345 ns_draw_text_decoration. Change treatment of cursor drawing to
346 accomodate underlining, etc.
347
348 2011-07-28 Eli Zaretskii <eliz@gnu.org>
349
350 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
351 default.
352
353 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
354
355 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
356 Without this fix, if a signal arrives just after memory fills up,
357 'malloc' might be invoked reentrantly.
358
359 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
360 In other words, assume that every image size is allowed, on non-X
361 hosts. This assumption is probably wrong, but it lets Emacs compile.
362
363 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
364
365 * regex.c (re_iswctype): Convert return values to boolean.
366
367 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
368
369 * xdisp.c (compute_display_string_pos): Don't use cached display
370 string position if the buffer had its restriction changed.
371 (Bug#9184)
372
373 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
374
375 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
376
377 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
378
379 Integer signedness and overflow and related fixes. (Bug#9079)
380
381 * bidi.c: Integer size and overflow fixes.
382 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
383 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
384 (bidi_cache_find_level_change, bidi_cache_ensure_space)
385 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
386 (bidi_find_other_level_edge):
387 Use ptrdiff_t instead of EMACS_INT where either will do.
388 This works better on 32-bit hosts configured --with-wide-int.
389 (bidi_cache_ensure_space): Check for size-calculation overflow.
390 Use % rather than repeated addition, for better worst-case speed.
391 Don't set bidi_cache_size until after xrealloc returns, because it
392 might not return.
393 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
394 (bidi_cache_ensure_space): Also check that the bidi cache size
395 does not exceed that of the largest Lisp string or buffer. See Eli
396 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
397
398 * alloc.c (__malloc_size_t): Remove.
399 All uses replaced by size_t. See Andreas Schwab's note
400 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
401
402 * image.c: Improve checking for integer overflow.
403 (check_image_size): Assume that f is nonnull, since
404 it is always nonnull in practice. This is one less thing to
405 worry about when checking for integer overflow later.
406 (x_check_image_size): New function, which checks for integer
407 overflow issues inside X.
408 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
409 This removes the need for a memory_full check.
410 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
411 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
412 (xbm_read_bitmap_data): Change locals back to 'int', since
413 their values must fit in 'int'.
414 (xpm_load_image, png_load, tiff_load):
415 Invoke x_create_x_image_and_pixmap earlier,
416 to avoid much needless work if the image is too large.
417 (tiff_load): Treat overly large images as if
418 x_create_x_image_and_pixmap failed, not as malloc failures.
419 (gs_load): Use x_check_image_size.
420
421 * gtkutil.c: Omit integer casts.
422 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
423 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
424
425 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
426
427 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
428 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
429 would wrongly return t on a 64-bit host.
430
431 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
432 The plain *_OVERFLOW macros run afoul of GCC bug 49705
433 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
434 and therefore cause GCC to emit a bogus diagnostic in some cases.
435
436 * image.c: Integer signedness and overflow and related fixes.
437 This is not an exhaustive set of fixes, but it's time to
438 record what I've got.
439 (lookup_pixel_color, check_image_size): Remove redundant decls.
440 (check_image_size): Don't assume that arbitrary EMACS_INT values
441 fit in 'int', or that arbitrary 'double' values fit in 'int'.
442 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
443 (tiff_load, imagemagick_load_image):
444 Check for overflow in size calculations.
445 (x_create_x_image_and_pixmap): Remove unnecessary test for
446 xmalloc returning NULL; that can't happen.
447 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
448 (xpm_color_bucket): Use better integer hashing function.
449 (xpm_cache_color): Don't possibly over-allocate memory.
450 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
451 (gif_memory_source):
452 Use ptrdiff_t, not int or size_t, to record sizes.
453 (png_load): Don't assume values greater than 2**31 fit in 'int'.
454 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
455 either works, as we prefer signed integers.
456 (tiff_read_from_memory, tiff_write_from_memory):
457 Return tsize_t, not size_t, since that's what the TIFF API wants.
458 (tiff_read_from_memory): Don't fail simply because the read would
459 go past EOF; instead, return a short read.
460 (tiff_load): Omit no-longer-needed casts.
461 (Fimagemagick_types): Don't assume size fits into 'int'.
462
463 Improve hashing quality when configured --with-wide-int.
464 * fns.c (hash_string): New function, taken from sxhash_string.
465 Do not discard information about ASCII character case; this
466 discarding is no longer needed.
467 (sxhash-string): Use it. Change sig to match it. Caller changed.
468 * lisp.h: Declare it.
469 * lread.c (hash_string): Remove, since we now use fns.c's version.
470 The fns.c version returns a wider integer if --with-wide-int is
471 specified, so this should help the quality of the hashing a bit.
472
473 * emacs.c: Integer overflow minor fix.
474 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
475 Define only if GNU_LINUX.
476 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
477
478 * dispnew.c: Integer signedness and overflow fixes.
479 Remove unnecessary forward decls, that were a maintenance hassle.
480 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
481 All uses changed.
482 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
483 (scrolling_window): Use ptrdiff_t, not int, for byte count.
484 (prepare_desired_row, line_draw_cost):
485 Use int, not unsigned, where either works.
486 (save_current_matrix, restore_current_matrix):
487 Use ptrdiff_t, not size_t, where either works.
488 (init_display): Check for overflow more accurately, and without
489 relying on undefined behavior.
490
491 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
492 Remove, replacing with the new symbols in lisp.h. All uses changed.
493 * fileio.c (make_temp_name):
494 * filelock.c (lock_file_1, lock_file):
495 * xdisp.c (message_dolog):
496 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
497 Use pMd etc. instead.
498 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
499 replacing the pWIDE etc. symbols removed from editfns.c.
500
501 * keyboard.h (num_input_events): Now uintmax_t.
502 This is (very slightly) less likely to mess up due to wraparound.
503 All uses changed.
504
505 * buffer.c: Integer signedness fixes.
506 (alloc_buffer_text, enlarge_buffer_text):
507 Use ptrdiff_t rather than size_t when either will do, as we prefer
508 signed integers.
509
510 * alloc.c: Integer signedness and overflow fixes.
511 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
512 (__malloc_size_t): Default to size_t, not to int.
513 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
514 (Fgarbage_collect, mark_object_loop_halt, mark_object):
515 Prefer ptrdiff_t to size_t when either would do, as we prefer
516 signed integers.
517 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
518 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
519 Now const. Initialize with values that are in range even if char
520 is signed.
521 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
522 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
523 These functions do the right thing with sizes > 2**32.
524 (check_depth): Now ptrdiff_t, not int.
525 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
526 Adjust to new way of storing sizes. Check for size overflow bugs
527 in rest of code.
528 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
529 slightly wrong anyway, as it missed one instance of
530 XMALLOC_OVERRUN_CHECK_OVERHEAD.
531 (refill_memory_reserve): Omit needless cast to size_t.
532 (mark_object_loop_halt): Mark as externally visible.
533
534 * xselect.c: Integer signedness and overflow fixes.
535 (Fx_register_dnd_atom, x_handle_dnd_message):
536 Use ptrdiff_t, not size_t, since we prefer signed.
537 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
538 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
539 x_dnd_atoms_size and x_dnd_atoms_length.
540
541 * doprnt.c: Prefer signed to unsigned when either works.
542 * eval.c (verror):
543 * doprnt.c (doprnt):
544 * lisp.h (doprnt):
545 * xdisp.c (vmessage):
546 Use ptrdiff_t, not size_t, when using or implementing doprnt,
547 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
548 prefer signed arithmetic to avoid comparison confusion.
549 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
550 but is a bit tricky.
551
552 Assume freestanding C89 headers, string.h, stdlib.h.
553 * data.c, doprnt.c, floatfns.c, print.c:
554 Include float.h unconditionally.
555 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
556 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
557 * regex.c: Likewise for stddef.h, string.h.
558 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
559 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
560 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
561 (STDC_HEADERS): Remove obsolete defines.
562 * sysdep.c: Include limits.h unconditionally.
563
564 Assume support for memcmp, memcpy, memmove, memset.
565 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
566 * regex.c (memcmp, memcpy):
567 Remove; we assume C89 now.
568
569 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
570 (__malloc_safe_bcopy): Remove; no longer needed.
571
572 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
573 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
574 well either way, and we prefer signed to unsigned.
575
576 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
577
578 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
579 closes the connection while we're reading (bug#9182).
580
581 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
582
583 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
584 are specified (Bug#9168).
585
586 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
587
588 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
589 Found by GCC static checking and --with-wide-int on a 32-bit host.
590
591 2011-07-25 Eli Zaretskii <eliz@gnu.org>
592
593 * xdisp.c (compute_display_string_pos): Fix logic of caching
594 previous display string position. Initialize cached_prev_pos to
595 -1. Fixes slow-down at the beginning of a buffer.
596
597 2011-07-24 Eli Zaretskii <eliz@gnu.org>
598
599 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
600 for attrs[LFACE_FONTSET_INDEX].
601
602 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
603
604 * xml.c (parse_region): Remove unused local
605 that was recently introduced.
606
607 2011-07-23 Eli Zaretskii <eliz@gnu.org>
608
609 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
610 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
611
612 * xdisp.c (move_it_in_display_line_to): Record the best matching
613 position for TO_CHARPOS while scanning the line, and restore it on
614 exit if none of the characters scanned was an exact match.
615 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
616 when exact match is impossible due to invisible text, and the
617 lines are truncated.
618
619 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
620
621 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
622 for OSX >= 10.7.
623
624 2011-07-22 Eli Zaretskii <eliz@gnu.org>
625
626 Fix a significant slow-down of cursor motion with C-n, C-p,
627 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
628 auto-repeat under bidi redisplay in fontified buffers.
629 * xdisp.c (compute_stop_pos_backwards): New function.
630 (next_element_from_buffer): Call compute_stop_pos_backwards to
631 find a suitable prev_stop when we find ourselves before
632 base_level_stop.
633 (reseat): Don't look for prev_stop, as that could mean a very long
634 run.
635 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
636 <cached_disp_overlay_modiff>: Cache for last found display string
637 position.
638 (compute_display_string_pos): Return the cached position if asked
639 about the same buffer in the same area of character positions, and
640 the buffer wasn't changed since the time the display string
641 position was cached.
642
643 2011-07-22 Eli Zaretskii <eliz@gnu.org>
644
645 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
646 is an integer, which is important for empty lines. (Bug#9149)
647
648 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
649
650 * frame.c (Fmodify_frame_parameters): In tty case, update the
651 default face if necessary (Bug#4238).
652
653 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
654
655 * editfns.c (Fstring_to_char): No need to explain what a character
656 is in the docstring (Bug#6576).
657
658 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
659
660 * xml.c (parse_region): Make sure we always return a tree.
661
662 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
663
664 * xml.c (parse_region): If a document contains only comments,
665 return that, too.
666
667 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
668
669 * xml.c (make_dom): Return comments, too.
670
671 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
672
673 Port to OpenBSD.
674 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
675 and the surrounding thread.
676 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
677 rather than fgets, and retry after EINTR. Otherwise, 'emacs
678 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
679 timer goes off.
680 * s/openbsd.h (BROKEN_SIGIO): Define.
681 * unexelf.c (unexec) [__OpenBSD__]:
682 Don't update the .mdebug section of the Alpha COFF symbol table.
683
684 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
685
686 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
687 (bug#8460).
688
689 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
690
691 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
692 This fixes some race conditions on the permissions of any newly
693 created file.
694
695 * alloc.c (valid_pointer_p): Use pipe, not open.
696 This fixes some permissions issues when debugging.
697
698 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
699 If fchown fails to set both uid and gid, try to set just gid,
700 as that is sometimes allowed. Adjust the file's mode to eliminate
701 setuid or setgid bits that are inappropriate if fchown fails.
702
703 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
704
705 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
706 to compare Lisp_Objects.
707 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
708 global_gnutls_log_level, don't mistake it for a Lisp_Object.
709 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
710
711 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
712
713 * lread.c (read_integer): Unread even EOF character.
714 (read1): Likewise. Properly record start position of symbol.
715
716 * lread.c (read1): Read `#:' as empty uninterned symbol if no
717 symbol character follows.
718
719 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
720
721 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
722 This works around a problem with the previous change to Fcopy_file.
723 Recent glibc declares fchown with __attribute__((warn_unused_result)),
724 and without this change, GCC might complain about discarding
725 fchown's return value.
726
727 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
728
729 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
730
731 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
732
733 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
734
735 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
736
737 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
738 it's used from the C level.
739
740 * process.c: Use the same condition for POLL_FOR_INPUT in both
741 keyboard.c and process.c (bug#1858).
742
743 2011-07-09 Lawrence Mitchell <wence@gmx.li>
744
745 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
746 (Fgnutls_boot): Use it.
747
748 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
749
750 * doc.c (Fsubstitute_command_keys): Revert last change.
751
752 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
753
754 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
755 quotes the next character, and doesn't affect other longer
756 sequences (bug#8935).
757
758 * lread.c (syms_of_lread): Clarify that is isn't only
759 `eval-buffer' and `eval-defun' that's affected by
760 `lexical-binding' (bug#8460).
761
762 2011-07-15 Eli Zaretskii <eliz@gnu.org>
763
764 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
765 bidi redisplay when a line includes both an image and is
766 truncated.
767
768 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
769
770 Fix minor problems found by static checking.
771 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
772 (elsz): Now a signed constant, not a size_t var. We prefer signed
773 types to unsigned, to avoid integer comparison confusion. Without
774 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
775 "cannot optimize loop, the loop counter may overflow", a symptom
776 of the confusion.
777 * indent.c (Fvertical_motion): Mark locals as initialized.
778 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
779
780 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
781
782 * search.c (Fre_search_backward): Mention `case-fold-search' in
783 all the re_search_* functions (bug#8138).
784
785 * keyboard.c (Fopen_dribble_file): Document when the file is
786 closed (bug#8056).
787
788 2011-07-14 Eli Zaretskii <eliz@gnu.org>
789
790 * bidi.c (bidi_dump_cached_states): Fix format of displaying
791 bidi_cache_idx.
792
793 Support bidi reordering of display and overlay strings.
794 * xdisp.c (compute_display_string_pos)
795 (compute_display_string_end): Accept additional argument STRING.
796 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
797 (reseat_to_string): Initialize bidi_it->string.s and
798 bidi_it->string.schars.
799 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
800 NULL (avoids a crash in bidi_paragraph_init).
801 Initialize itb.string.lstring.
802 (init_iterator): Call bidi_init_it only of a valid
803 buffer position was specified. Initialize paragraph_embedding to
804 L2R.
805 (reseat_to_string): Initialize the bidi iterator.
806 (display_string): If we need to ignore text properties of
807 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
808 original value of -1 will not work with bidi.)
809 (compute_display_string_pos): First arg is now struct
810 `text_pos *'; all callers changed. Support display properties on
811 Lisp strings.
812 (compute_display_string_end): Support display properties on Lisp
813 strings.
814 (init_iterator, reseat_1, reseat_to_string): Initialize the
815 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
816 when iterating on a string not from display properties).
817 (compute_display_string_pos, compute_display_string_end):
818 Fix calculation of the object to scan. Fixes an error when using
819 arrow keys.
820 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
821 base_level_stop; instead, set base_level_stop to BEGV.
822 Fixes crashes in vertical-motion.
823 (next_element_from_buffer): Improve commentary for when
824 the iterator is before prev_stop.
825 (init_iterator): Initialize bidi_p from the default value of
826 bidi-display-reordering, not from buffer-local value. Use the
827 buffer-local value only if initializing for buffer iteration.
828 (handle_invisible_prop): Support invisible properties on strings
829 that are being bidi-reordered.
830 (set_iterator_to_next): Support bidi reordering of C strings and
831 Lisp strings.
832 (next_element_from_string): Support bidi reordering of Lisp
833 strings.
834 (handle_stop_backwards): Support Lisp strings as well.
835 (display_string): Support display of R2L glyph rows.
836 Use IT_STRING_CHARPOS when displaying from a Lisp string.
837 (init_iterator): Don't initialize it->bidi_p for strings
838 here.
839 (reseat_to_string): Initialize it->bidi_p for strings here.
840 (next_element_from_string, next_element_from_c_string)
841 (next_element_from_buffer): Add xassert's for correspondence
842 between IT's object being iterated and it->bidi_it.string
843 structure.
844 (face_before_or_after_it_pos): Support bidi iteration.
845 (next_element_from_c_string): Handle the case of the first string
846 character that is not the first one in the visual order.
847 (get_visually_first_element): New function, refactored from common
848 parts of next_element_from_buffer, next_element_from_string, and
849 next_element_from_c_string.
850 (tool_bar_lines_needed, redisplay_tool_bar)
851 (display_menu_bar): Force left-to-right direction. Add a FIXME
852 comment for making that be controlled by a user option.
853 (push_it, pop_it): Save and restore the state of the
854 bidi iterator. Save and restore the bidi_p flag.
855 (pop_it): Iterate out of display property for string iteration as
856 well.
857 (iterate_out_of_display_property): Support iteration over strings.
858 (handle_single_display_spec): Set up it->bidi_it for iteration
859 over a display string, and call bidi_init_it.
860 (handle_single_display_spec, next_overlay_string)
861 (get_overlay_strings_1, push_display_prop): Set up the bidi
862 iterator for displaying display or overlay strings.
863 (forward_to_next_line_start): Don't use the shortcut if
864 bidi-iterating.
865 (back_to_previous_visible_line_start): If handle_display_prop
866 pushed the iterator stack, restore the internal state of the bidi
867 iterator by calling bidi_pop_it same number of times.
868 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
869 and we are bidi-iterating, don't decrement the iterator position;
870 instead, set the first_elt flag in the bidi iterator, to produce
871 the same effect.
872 (reseat_1): Remove redundant setting of string_from_display_prop_p.
873 (push_display_prop): xassert that we are iterating a buffer.
874 (push_it, pop_it): Save and restore paragraph_embedding member.
875 (handle_single_display_spec, next_overlay_string)
876 (get_overlay_strings_1, reseat_1, reseat_to_string)
877 (push_display_prop): Set up the `unibyte' member of bidi_it.string
878 correctly. Don't assume unibyte strings are not bidi-reordered.
879 (compute_display_string_pos)
880 (compute_display_string_end): Fix handling the case of C string.
881 (push_it, pop_it): Save and restore from_disp_prop_p.
882 (handle_single_display_spec, push_display_prop): Set the
883 from_disp_prop_p flag.
884 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
885 (pop_it): Call iterate_out_of_display_property only if we are
886 popping after iteration over a string that came from a display
887 property. Fix a typo in popping stretch info. Add an assertion
888 for verifying that the iterator position is in sync with the bidi
889 iterator.
890 (handle_single_display_spec, get_overlay_strings_1)
891 (push_display_prop): Fix initialization of paragraph direction for
892 string when that of the parent object is not yet determined.
893 (reseat_1): Call bidi_init_it to resync the bidi
894 iterator with IT's position. (Bug#7616)
895 (find_row_edges): If ROW->start.pos gives position
896 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
897 (handle_stop, back_to_previous_visible_line_start, reseat_1):
898 Reset the from_disp_prop_p flag.
899 (SAVE_IT, RESTORE_IT): New macros.
900 (pos_visible_p, face_before_or_after_it_pos)
901 (back_to_previous_visible_line_start)
902 (move_it_in_display_line_to, move_it_in_display_line)
903 (move_it_to, move_it_vertically_backward, move_it_by_lines)
904 (try_scrolling, redisplay_window, display_line): Use them when
905 saving a temporary copy of the iterator and restoring it back.
906 (back_to_previous_visible_line_start, reseat_1)
907 (init_iterator): Empty the bidi cache "stack".
908 (move_it_in_display_line_to): If iterator ended up at
909 EOL, but we never saw any buffer positions smaller than
910 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
911 motion in bidi-reordered lines.
912 (move_it_in_display_line_to): Record prev_method and prev_pos
913 immediately before the call to set_iterator_to_next. Fixes cursor
914 motion in bidi-reordered lines with stretch glyphs and strings
915 displayed in margins. (Bug#8133) (Bug#8867)
916 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
917 TO_CHARPOS.
918 (pos_visible_p): Support positions in bidi-reordered lines.
919 Save and restore bidi cache.
920
921 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
922 (bidi_paragraph_info): Delete unused struct.
923 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
924 (bidi_cache_start): New variable.
925 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
926 to zero.
927 (bidi_cache_fetch_state, bidi_cache_search)
928 (bidi_cache_find_level_change, bidi_cache_iterator_state)
929 (bidi_cache_find, bidi_peek_at_next_level)
930 (bidi_level_of_next_char, bidi_find_other_level_edge)
931 (bidi_move_to_visually_next): Compare cache index with
932 bidi_cache_start rather than with zero.
933 (bidi_fetch_char): Accept new argument STRING; all callers
934 changed. Support iteration over a string. Support strings with
935 display properties. Support unibyte strings. Fix the type of
936 `len' according to what STRING_CHAR_AND_LENGTH expects.
937 (bidi_paragraph_init, bidi_resolve_explicit_1)
938 (bidi_resolve_explicit, bidi_resolve_weak)
939 (bidi_level_of_next_char, bidi_move_to_visually_next):
940 Support iteration over a string.
941 (bidi_set_sor_type, bidi_resolve_explicit_1)
942 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
943 can now be zero (for strings); special values 0 and -1 were
944 changed to -1 and -2, respectively.
945 (bidi_char_at_pos): New function.
946 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
947 Call it instead of FETCH_MULTIBYTE_CHAR.
948 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
949 initialized to valid values.
950 (bidi_init_it): Don't initialize charpos and bytepos with invalid
951 values.
952 (bidi_level_of_next_char): Allow the sentinel "position" to pass
953 the test for valid cached positions. Fix the logic for looking up
954 the sentinel state in the cache. GCPRO the Lisp string we are
955 iterating.
956 (bidi_push_it, bidi_pop_it): New functions.
957 (bidi_initialize): Initialize the bidi cache start stack pointer.
958 (bidi_cache_ensure_space): New function, refactored from part of
959 bidi_cache_iterator_state. Don't assume the required size is just
960 one BIDI_CACHE_CHUNK away.
961 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
962 (bidi_count_bytes, bidi_char_at_pos): New functions.
963 (bidi_cache_search): Don't assume bidi_cache_last_idx is
964 always valid if bidi_cache_idx is valid.
965 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
966 is valid if it's going to be used.
967 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
968 (bidi_cache_fetch_state, bidi_cache_search)
969 (bidi_cache_find_level_change, bidi_cache_ensure_space)
970 (bidi_cache_iterator_state, bidi_cache_find)
971 (bidi_find_other_level_edge, bidi_cache_start_stack):
972 All variables related to cache indices are now EMACS_INT.
973
974 * dispextern.h (struct bidi_string_data): New structure.
975 (struct bidi_it): New member `string'. Make flag members be 1-bit
976 fields, and put them last in the struct.
977 (compute_display_string_pos, compute_display_string_end):
978 Update prototypes.
979 (bidi_push_it, bidi_pop_it): Add prototypes.
980 (struct iterator_stack_entry): New members bidi_p,
981 paragraph_embedding, and from_disp_prop_p.
982 (struct it): Member bidi_p is now a bit field 1 bit wide.
983 (bidi_shelve_cache, bidi_unshelve_cache):
984 Declare prototypes.
985
986 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
987 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
988 and vector-like objects.
989
990 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
991 cache around display iteration.
992
993 * window.c (Fwindow_end, window_scroll_pixel_based)
994 (displayed_window_lines, Frecenter): Save and restore the bidi
995 cache around display iteration.
996
997 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
998
999 * editfns.c (Fdelete_region): Clarify the use of the named
1000 parameters (bug#6788).
1001
1002 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1003
1004 * indent.c (Fvertical_motion): Set and restore w->pointm when
1005 saving and restoring the window's buffer (Bug#9006).
1006
1007 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1008
1009 * editfns.c (Fstring_to_char): Clarify just what is returned
1010 (bug#6576). Text by Eli Zaretskii.
1011
1012 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1013
1014 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1015
1016 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1017
1018 * buffer.c (mmap_find): Fix a typo.
1019
1020 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1021
1022 Fix execution of x selection hooks.
1023 * xselect.c (Qx_lost_selection_functions)
1024 (Qx_sent_selection_functions): New vars.
1025 (syms_of_xselect): DEFSYM them.
1026 (x_handle_selection_request): Pass Qx_sent_selection_functions
1027 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1028 (x_handle_selection_clear,x_clear_frame_selections):
1029 Pass Qx_lost_selection_functions rather than
1030 Vx_lost_selection_functions to Frun_hook_with_args.
1031
1032 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1033
1034 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1035 The old code sometimes used this field without initializing it.
1036
1037 * alloc.c (gc_sweep): Don't read past end of array.
1038 In theory, the old code could also have corrupted Emacs internals,
1039 though it'd be very unlikely.
1040
1041 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1042
1043 * character.c (Fcharacterp): Don't advertise optional ignored
1044 argument. (Bug#4026)
1045
1046 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1047
1048 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1049 key" (bug#4257).
1050
1051 * window.c (Fset_window_start): Doc fix (bug#4199).
1052 (Fset_window_hscroll): Ditto.
1053
1054 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1055
1056 Fix minor new problems caught by GCC 4.6.1.
1057 * term.c (init_tty): Remove unused local.
1058 * xsettings.c (store_monospaced_changed): Define this function only
1059 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1060 not used otherwise.
1061
1062 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1063
1064 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1065
1066 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1067
1068 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1069 are the mini-buffer and the echo area (bug#3320).
1070
1071 * term.c (init_tty): Remove support for supdup, c10 and perq
1072 terminals, which are no longer supported (bug#1482).
1073
1074 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1075
1076 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1077
1078 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1079
1080 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1081 for non-popups (Bug#3642).
1082
1083 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1084
1085 * alloc.c (reset_malloc_hooks): Protoize.
1086 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1087 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1088 * cm.c (losecursor): Likewise.
1089 * data.c (fmod): Likewise.
1090 * dispnew.c (swap_glyphs_in_rows): Likewise.
1091 * emacs.c (memory_warning_signal): Likewise.
1092 * floatfns.c (float_error): Likewise.
1093 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1094 (otf_open, font_otf_capability, generate_otf_features)
1095 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1096 Likewise.
1097 * image.c (pbm_read_file): Likewise.
1098 * indent.c (string_display_width): Likewise.
1099 * intervals.c (check_for_interval, search_for_interval)
1100 (inc_interval_count, count_intervals, root_interval)
1101 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1102 * lread.c (defalias): Likewise.
1103 * ralloc.c (r_alloc_check): Likewise.
1104 * regex.c (set_image_of_range_1, set_image_of_range)
1105 (regex_grow_registers): Likewise.
1106 * sysdep.c (strerror): Likewise.
1107 * termcap.c (valid_filename_p, tprint, main): Likewise.
1108 * tparam.c (main): Likewise.
1109 * unexhp9k800.c (run_time_remap, save_data_space)
1110 (update_file_ptrs, read_header, write_header, calculate_checksum)
1111 (copy_file, copy_rest, display_header): Likewise.
1112 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1113 Likewise.
1114 * xdisp.c (check_it): Likewise.
1115 * xfaces.c (register_color, unregister_color, unregister_colors):
1116 Likewise.
1117 * xfns.c (print_fontset_result): Likewise.
1118 * xrdb.c (member, fatal, main): Likewise.
1119
1120 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1121
1122 Fix minor problems found by static checking (Bug#9031).
1123 * chartab.c (char_table_set_range, map_sub_char_table):
1124 Remove unused locals.
1125 (uniprop_table): Now static.
1126 * composite.c (_work_char): Remove unused static var.
1127
1128 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1129
1130 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1131
1132 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1133
1134 * gtkutil.c (qttip_cb): Remove code without function.
1135
1136 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1137
1138 * w32.c (pthread_sigmask): New stub.
1139
1140 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1141
1142 Use pthread_sigmask, not sigprocmask (Bug#9010).
1143 sigprocmask is portable only for single-threaded applications, and
1144 Emacs can be multi-threaded when it uses GTK.
1145 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1146 (LIBES): Use it.
1147 * callproc.c (Fcall_process):
1148 * process.c (create_process):
1149 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1150 Use pthread_sigmask, not sigprocmask.
1151
1152 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1153
1154 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1155 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1156 wrong (Bug#8591).
1157
1158 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1159
1160 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1161 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1162 (xg_hide_tooltip): Fix comment.
1163
1164 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1165 in registerServicesMenuSendTypes.
1166 (validRequestorForSendType): Don't check ns_return_types.
1167
1168 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1169 ns_return_type.
1170
1171 2011-07-08 Jason Rumney <jasonr@gnu.org>
1172
1173 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1174 frame struct members of non-existent frames (Bug#6284).
1175
1176 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1177
1178 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1179 variable firstTime not needed on OSX >= 10.6.
1180 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1181 >= 10.5. Use setKnobProportion, setDoubleValue.
1182
1183 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1184 (MAC_OS_X_VERSION_10_5): Define if not defined.
1185 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1186 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1187 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1188
1189 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1190 cString and lossyCString on OSX >= 10.4
1191
1192 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1193 sizeToFit on OSX >= 10.2.
1194
1195 * nsimage.m (allocInitFromFile): Don't use deprecated method
1196 bestRepresentationForDevice on OSX >= 10.6.
1197
1198 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1199 to avoid warning.
1200
1201 * emacs.c: Declare unexec_init_emacs_zone.
1202
1203 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1204
1205 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1206
1207 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1208 on svcsMenu (Bug#8842).
1209
1210 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1211 ns_return_types.
1212 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1213
1214 * nsterm.m (QUTF8_STRING): Declare.
1215 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1216 (validRequestorForSendType): Return type is (id).
1217 Change indexOfObjectIdenticalTo to indexOfObject.
1218 Check if we have local selection before returning self (Bug#8842).
1219 (writeSelectionToPasteboard): Put local selection into paste board
1220 if we have a local selection (Bug#8842).
1221 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1222
1223 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1224 (ns_get_local_selection): Declare.
1225
1226 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1227
1228 * keymap.c (describe_map_tree): Don't insert a double newline at
1229 the end of the buffer (bug#1169) and return whether we inserted
1230 something.
1231
1232 * callint.c (Fcall_interactively): Change "reading args" to
1233 "providing args" to try to clarify what it does (bug#1010).
1234
1235 2011-07-07 Kenichi Handa <handa@m17n.org>
1236
1237 * composite.c (composition_compute_stop_pos): Ignore a static
1238 composition starting before CHARPOS (Bug#8915).
1239
1240 * xdisp.c (handle_composition_prop): Likewise.
1241
1242 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1243
1244 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1245 (Bug#9015)
1246
1247 2011-07-07 Kenichi Handa <handa@m17n.org>
1248
1249 * character.h (unicode_category_t): New enum type.
1250
1251 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1252 (Qchar_code_property_table): New variable.
1253 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1254 (UNIPROP_COMPRESSED_FORM_P): New macros.
1255 (char_table_ascii): Uncompress the compressed values.
1256 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1257 Uncompress the compressed values.
1258 (sub_char_table_ref_and_range): Likewise.
1259 (char_table_ref_and_range): Uncompress the compressed values.
1260 (sub_char_table_set): New arg is_uniprop. Callers changed.
1261 Uncompress the compressed values.
1262 (sub_char_table_set_range): Args changed. Callers changed.
1263 (char_table_set_range): Adjuted for the above change.
1264 (map_sub_char_table): Delete args default_val and parent. Add arg
1265 top. Give decoded values to a Lisp function.
1266 (map_char_table): Adjust for the above change. Give decoded
1267 values to a Lisp function. Gcpro more variables.
1268 (uniprop_table_uncompress)
1269 (uniprop_decode_value_run_length): New functions.
1270 (uniprop_decoder, uniprop_decoder_count): New variables.
1271 (uniprop_get_decoder, uniprop_encode_value_character)
1272 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1273 New functions.
1274 (uniprop_encoder, uniprop_encoder_count): New variables.
1275 (uniprop_get_encoder, uniprop_table)
1276 (Funicode_property_table_internal, Fget_unicode_property_internal)
1277 (Fput_unicode_property_internal): New functions.
1278 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1279 Sunicode_property_table_internal, Sget_unicode_property_internal,
1280 and Sput_unicode_property_internal. Defvar_lisp
1281 char-code-property-alist.
1282
1283 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1284 Vunicode_category_table.
1285
1286 * font.c (font_range): Adjust for the change of
1287 Vunicode_category_table.
1288
1289 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1290
1291 * m/iris4d.h: Remove file, move contents ...
1292 * s/irix6-5.h: ... here.
1293
1294 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1295
1296 Remove unportable assumption about struct layout (Bug#8884).
1297 * alloc.c (mark_buffer):
1298 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1299 (clone_per_buffer_values): Don't assume that
1300 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1301 This isn't true in general, and it's particularly not true
1302 if Emacs is configured with --with-wide-int.
1303 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1304 New macros, used in the buffer.c change.
1305
1306 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1307
1308 * xsettings.c: Use both GConf and GSettings if both are available.
1309 (store_config_changed_event): Add comment.
1310 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1311 (store_tool_bar_style_changed): New functions.
1312 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1313 (struct xsettings): Move font inside HAVE_XFT.
1314 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1315 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1316 Move inside HAVE_XFT.
1317 (something_changed_gsettingsCB): Rename from something_changedCB.
1318 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1319 also.
1320 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1321 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1322 (something_changed_gconfCB): Rename from something_changedCB.
1323 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1324 (parse_settings): Move check for font inside HAVE_XFT.
1325 (read_settings, apply_xft_settings): Add comment.
1326 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1327 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1328 call store_font_name_changed.
1329 (xft_settings_event): Add comment.
1330 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1331 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1332 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1333 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1334 (xsettings_initialize): Call init_gsettings last.
1335 (xsettings_get_system_font, xsettings_get_system_normal_font):
1336 Add comment.
1337
1338 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1339
1340 Random fixes. E.g., (random) never returned negative values.
1341 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1342 subseconds part to the entropy, as that's a bit more random.
1343 Prefer signed to unsigned, since the signedness doesn't matter and
1344 in general we prefer signed. When given a limit, use a
1345 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1346 latter isn't right if USE_2_TAGS_FOR_INTS.
1347 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1348 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1349
1350 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1351
1352 * textprop.c (text_property_stickiness):
1353 Obey Vtext_property_default_nonsticky.
1354 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1355 * w32fns.c (syms_of_w32fns):
1356 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1357
1358 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1359
1360 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1361 This is more efficient than Ffile_directory_p and avoids a minor race.
1362
1363 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1364
1365 * buffer.c (Foverlay_put): Say what the return value is
1366 (bug#7835).
1367
1368 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1369 is a directory before asking whether to use the file name
1370 (bug#7564).
1371 (barf_or_query_if_file_exists): Make the "File is a directory"
1372 error be more correct.
1373
1374 * fns.c (Frequire): Remove the mention of the .gz files, since
1375 that's installation-specific, but keep the mention of
1376 `get-load-suffixes'.
1377
1378 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1379
1380 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1381 Report string overflow if the output is too long.
1382
1383 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1384
1385 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1386 (syms_of_gnutls): Remove duplicate DEFSYM for
1387 Qgnutls_bootprop_verify_hostname_error, an error for
1388 Qgnutls_bootprop_verify_error (which is no longer used).
1389
1390 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1391 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1392 Also (re)move comments that are misplaced or no longer relevant.
1393
1394 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1395
1396 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1397
1398 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1399
1400 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1401 and background color parameters if they have been changed.
1402
1403 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1404
1405 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1406
1407 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1408
1409 * xsettings.c (SYSTEM_FONT): Define only when used.
1410 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1411
1412 * keymap.c (access_keymap_1): Now static.
1413
1414 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1415
1416 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1417 leave any prefix arg for the up event (Bug#1586).
1418
1419 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1420
1421 * lread.c (syms_of_lread): Mention single symbols defined by
1422 `defvar' or `defconst' (bug#7154).
1423
1424 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1425 (Frequire): Mention get-load-suffixes.
1426
1427 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1428
1429 * window.h (window): Remove clone_number slot.
1430 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1431 Remove.
1432 (make_parent_window, make_window, saved_window)
1433 (Fset_window_configuration, save_window_save): Don't deal with
1434 clone numbers.
1435 * buffer.c (Qclone_number): Remove declaration.
1436 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1437
1438 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1439
1440 Add multiple inheritance to keymaps.
1441 * keymap.c (Fmake_composed_keymap): New function.
1442 (Fset_keymap_parent): Simplify.
1443 (fix_submap_inheritance): Remove.
1444 (access_keymap_1): New function extracted from access_keymap to handle
1445 embedded parents and handle lists of maps.
1446 (access_keymap): Use it.
1447 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1448 (Fcopy_keymap): Handle embedded parents.
1449 (Fcommand_remapping, define_as_prefix): Simplify.
1450 (Fkey_binding): Simplify.
1451 (syms_of_keymap): Move minibuffer-local-completion-map,
1452 minibuffer-local-filename-completion-map,
1453 minibuffer-local-must-match-map, and
1454 minibuffer-local-filename-must-match-map to Elisp.
1455 (syms_of_keymap): Defsubr make-composed-keymap.
1456 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1457 (parse_menu_item): Trivial simplification.
1458
1459 2011-07-01 Glenn Morris <rgm@gnu.org>
1460
1461 * Makefile.in (SETTINGS_LIBS): Fix typo.
1462
1463 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1464
1465 * coding.c (Fencode_coding_string): Record the last coding system
1466 used, as the function doc string says (bug#8738).
1467
1468 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1469
1470 * xsettings.c (store_monospaced_changed): Take new font as arg and
1471 check for change against current_mono_font.
1472 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1473 (emacs_settings_constructor, emacs_settings_get_property)
1474 (emacs_settings_set_property, emacs_settings_class_init)
1475 (emacs_settings_init, gsettings_obj): Remove.
1476 (something_changedCB): New function for HAVE_GSETTINGS.
1477 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1478 with value as argument.
1479 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1480 g_settings_new (Bug#8967). Do not create gsettings_obj.
1481 Remove calls to g_settings_bind. Connect something_changedCB to
1482 "changed".
1483
1484 * xgselect.c: Add defined (HAVE_GSETTINGS).
1485 (xgselect_initialize): Ditto.
1486
1487 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1488 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1489 xg_select.
1490
1491 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1492
1493 * eval.c (struct backtrace): Simplify and port the data structure.
1494 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1495 signed bit field, as this assumption is not portable and it makes
1496 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1497 "char debug_on_exit : 1" as this is not portable either; instead,
1498 use the portable "unsigned int debug_on_exit : 1". Remove unused
1499 member evalargs. Remove obsolete comments about cc bombing out.
1500
1501 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1502
1503 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1504 Let HAVE_GSETTINGS override HAVE_GCONF.
1505 (store_monospaced_changed): New function.
1506 (EMACS_SETTINGS): A new type derived from GObject to handle
1507 GSettings notifications.
1508 (emacs_settings_constructor, emacs_settings_get_property)
1509 (emacs_settings_set_property, emacs_settings_class_init):
1510 New functions.
1511 (gsettings_client, gsettings_obj): New variables.
1512 (GSETTINGS_SCHEMA): New define.
1513 (something_changedCB): Call store_monospaced_changed.
1514 (init_gsettings): New function.
1515 (xsettings_initialize): Call init_gsettings.
1516 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1517 to NULL.
1518
1519 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1520 GCONF_CFLAGS/LIBS.
1521
1522 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1523
1524 * window.c (resize_root_window, grow_mini_window)
1525 (shrink_mini_window): Rename Qresize_root_window to
1526 Qwindow_resize_root_window and Qresize_root_window_vertically to
1527 Qwindow_resize_root_window_vertically.
1528
1529 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1530
1531 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1532
1533 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1534
1535 * makefile.w32-in: Redesign dependencies so they reflect more
1536 clearly which files are directly included by each source file,
1537 and not through other includes.
1538
1539 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1540
1541 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1542 (sort_overlays, overlay_strings): When an overlay's clone number
1543 matches the window's clone number process the overlay even if
1544 the overlay's window property doesn't match the current window.
1545
1546 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1547 (Fwindow_hchild): Rename to Fwindow_left_child.
1548 (Fwindow_next): Rename to Fwindow_next_sibling.
1549 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1550 (resize_window_check): Rename to window_resize_check.
1551 (resize_window_apply): Rename to window_resize_apply.
1552 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1553 (Fdelete_other_windows_internal, resize_frame_windows)
1554 (Fsplit_window_internal, Fdelete_window_internal)
1555 (grow_mini_window, shrink_mini_window)
1556 (Fresize_mini_window_internal): Fix callers accordingly.
1557
1558 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1559
1560 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1561 (emacs_fixed_set_min_size): Remove.
1562 (emacs_fixed_new): Take frame as argument.
1563
1564 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1565 (_EmacsFixedPrivate): Remove minwidth/height.
1566 Add struct frame *f.
1567 (emacs_fixed_init): Initialize priv->f.
1568 (get_parent_class, emacs_fixed_set_min_size): Remove.
1569 (emacs_fixed_new): Set priv->f to argument.
1570 (emacs_fixed_get_preferred_width)
1571 (emacs_fixed_get_preferred_height): Use min_width/height from
1572 frames size_hint to set minimum and natural (Bug#8919).
1573 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1574 and use min_width/height from frames size_hint to set
1575 min_width/height (Bug#8919).
1576
1577 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1578 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1579 Fix indentation.
1580
1581 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1582
1583 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1584 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1585 called at ZV.
1586
1587 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1588
1589 * process.c (wait_reading_process_output): Bypass select if
1590 waiting for a cell while ignoring keyboard input, and input is
1591 pending. Suggested by Jan Djärv (Bug#8869).
1592
1593 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1594
1595 Use gnulib's dup2 module instead of rolling our own.
1596 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1597
1598 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1599
1600 * dispnew.c (scrolling_window): Before scrolling, turn off a
1601 mouse-highlight in the window being scrolled.
1602
1603 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1604
1605 Move DEFSYM to lisp.h and use everywhere.
1606
1607 * character.h (DEFSYM): Move declaration...
1608 * lisp.h (DEFSYM): ...here.
1609
1610 * gnutls.c:
1611 * minibuf.c:
1612 * w32menu.c:
1613 * w32proc.c:
1614 * w32select.c: Don't include character.h.
1615
1616 * alloc.c (syms_of_alloc):
1617 * buffer.c (syms_of_buffer):
1618 * bytecode.c (syms_of_bytecode):
1619 * callint.c (syms_of_callint):
1620 * casefiddle.c (syms_of_casefiddle):
1621 * casetab.c (init_casetab_once):
1622 * category.c (init_category_once, syms_of_category):
1623 * ccl.c (syms_of_ccl):
1624 * cmds.c (syms_of_cmds):
1625 * composite.c (syms_of_composite):
1626 * dbusbind.c (syms_of_dbusbind):
1627 * dired.c (syms_of_dired):
1628 * dispnew.c (syms_of_display):
1629 * doc.c (syms_of_doc):
1630 * editfns.c (syms_of_editfns):
1631 * emacs.c (syms_of_emacs):
1632 * eval.c (syms_of_eval):
1633 * fileio.c (syms_of_fileio):
1634 * fns.c (syms_of_fns):
1635 * frame.c (syms_of_frame):
1636 * fringe.c (syms_of_fringe):
1637 * insdel.c (syms_of_insdel):
1638 * keymap.c (syms_of_keymap):
1639 * lread.c (init_obarray, syms_of_lread):
1640 * macros.c (syms_of_macros):
1641 * msdos.c (syms_of_msdos):
1642 * print.c (syms_of_print):
1643 * process.c (syms_of_process):
1644 * search.c (syms_of_search):
1645 * sound.c (syms_of_sound):
1646 * syntax.c (init_syntax_once, syms_of_syntax):
1647 * terminal.c (syms_of_terminal):
1648 * textprop.c (syms_of_textprop):
1649 * undo.c (syms_of_undo):
1650 * w32.c (globals_of_w32):
1651 * window.c (syms_of_window):
1652 * xdisp.c (syms_of_xdisp):
1653 * xfaces.c (syms_of_xfaces):
1654 * xfns.c (syms_of_xfns):
1655 * xmenu.c (syms_of_xmenu):
1656 * xsettings.c (syms_of_xsettings):
1657 * xterm.c (syms_of_xterm): Use DEFSYM.
1658
1659 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1660
1661 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1662
1663 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1664
1665 Integer and buffer overflow fixes (Bug#8873).
1666
1667 * print.c (printchar, strout): Check for string overflow.
1668 (PRINTPREPARE, printchar, strout):
1669 Don't set size unless allocation succeeds.
1670
1671 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1672 for sizes. Check for string overflow more accurately.
1673 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1674
1675 * macros.c: Integer and buffer overflow fixes.
1676 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1677 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1678 Use ptrdiff_t, not int, for sizes.
1679 Don't increment bufsize until after realloc succeeds.
1680 Check for size-calculation overflow.
1681 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1682
1683 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1684
1685 * lread.c: Integer overflow fixes.
1686 (read_integer): Radix is now EMACS_INT, not int,
1687 to improve quality of diagnostics for out-of-range radices.
1688 Calculate buffer size correctly for out-of-range radices.
1689 (read1): Check for integer overflow in radices, and in
1690 read-circle numbers.
1691 (read_escape): Avoid int overflow.
1692 (Fload, openp, read_buffer_size, read1)
1693 (substitute_object_recurse, read_vector, read_list, map_obarray):
1694 Use ptrdiff_t, not int, for sizes.
1695 (read1): Use EMACS_INT, not int, for sizes.
1696 Check for size overflow.
1697
1698 * image.c (cache_image): Check for size arithmetic overflow.
1699
1700 * lread.c: Integer overflow issues.
1701 (saved_doc_string_size, saved_doc_string_length)
1702 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1703 Now ptrdiff_t, not int.
1704 (read1): Don't assume doc string length fits in int. Check for
1705 out-of-range doc string lengths.
1706 (read_list): Don't assume file position fits in int.
1707 (read_escape): Check for hex character overflow.
1708
1709 2011-06-22 Leo Liu <sdl.web@gmail.com>
1710
1711 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1712 Move to minibuffer.el.
1713
1714 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1715
1716 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1717 The following patches are for when GLYPH_DEBUG && !XASSERT.
1718 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1719 * dispnew.c (flush_stdout):
1720 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1721 Mark as externally visible.
1722 * dispnew.c (check_window_matrix_pointers): Now static.
1723 * dispnew.c (window_to_frame_vpos):
1724 * xfns.c (unwind_create_frame):
1725 * xterm.c (x_check_font): Remove unused local.
1726 * scroll.c (CHECK_BOUNDS):
1727 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1728 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1729 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1730 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1731 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1732 Now static.
1733 (debug_method_add): Use va_list and vsprintf rather than relying
1734 on undefined behavior with wrong number of arguments.
1735 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1736 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1737 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1738 since we're not interested in debugging glyphs with old libraries.
1739 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1740 GCC 4.6.0's static checking.
1741
1742 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1743
1744 Integer overflow and signedness fixes (Bug#8873).
1745 A few related buffer overrun fixes, too.
1746
1747 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1748
1749 * dispextern.h (struct face.stipple):
1750 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1751 (x_bitmap_mask, x_allocate_bitmap_record)
1752 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1753 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1754 (x_create_bitmap_from_xpm_data):
1755 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1756 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1757 (.bitmaps_last):
1758 * xfaces.c (load_pixmap):
1759 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1760 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1761 (.bitmaps_last, struct x_output.icon_bitmap):
1762 Use ptrdiff_t, not int, for bitmap indexes.
1763 (x_allocate_bitmap_record): Check for size overflow.
1764 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1765
1766 Use ptrdiff_t, not int, for overlay counts.
1767 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1768 * editfns.c (overlays_around, get_pos_property):
1769 * textprop.c (get_char_property_and_overlay):
1770 * xdisp.c (next_overlay_change, note_mouse_highlight):
1771 * xfaces.c (face_at_buffer_position):
1772 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1773 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1774 (Fnext_overlay_change, Fprevious_overlay_change)
1775 (mouse_face_overlay_overlaps, Foverlays_in):
1776 Use ptrdiff_t, not int, for sizes.
1777 (overlays_at, overlays_in): Check for size-calculation overflow.
1778
1779 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1780
1781 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1782 (x_session_initialize): Do not assume string length fits in int.
1783
1784 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1785 This is unlikely, but can occur if DPI is outlandish.
1786
1787 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1788 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1789
1790 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1791 * xrdb.c (magic_file_p, search_magic_path):
1792 Omit last arg SUFFIX; it was always 0. All callers changed.
1793 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1794
1795 * xfont.c (xfont_match): Avoid need for strlen.
1796
1797 * xfns.c: Don't assume strlen fits in int.
1798 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1799
1800 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1801 not unsigned long, as we prefer signed integers. All callers changed.
1802 Detect integer overflow in repeat count.
1803 (message_dolog): Don't assume print length fits in 39 bytes.
1804 (display_mode_element): Don't assume strlen fits in int.
1805
1806 * termcap.c: Don't assume sizes fit in int and never overflow.
1807 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1808 (gobble_line): Check for size-calculation overflow.
1809
1810 * minibuf.c (Fread_buffer):
1811 * lread.c (intern, intern_c_string):
1812 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1813 Don't assume string length fits in int.
1814
1815 * keyboard.c (parse_tool_bar_item):
1816 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1817
1818 * font.c: Don't assume string length fits in int.
1819 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1820 Use ptrdiff_t, not int.
1821 (font_intern_prop): Don't assume string length fits in int.
1822 Don't assume integer property fits in fixnum.
1823 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1824
1825 * filelock.c: Fix some buffer overrun and integer overflow issues.
1826 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1827 Reformulate so as not to need the command string.
1828 Invoke gzip -cd rather than gunzip, as it's more portable.
1829 (lock_info_type, lock_file_1, lock_file):
1830 Don't assume pid_t and time_t fit in unsigned long.
1831 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1832 (current_lock_owner): Prefer signed type for sizes.
1833 Use memcpy, not strncpy, where memcpy is what is really wanted.
1834 Don't assume (via atoi) that time_t and pid_t fit in int.
1835 Check for time_t and/or pid_t out of range, e.g., via a network share.
1836 Don't alloca where an auto var works fine.
1837
1838 * fileio.c: Fix some integer overflow issues.
1839 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1840 Don't assume string length fits in int.
1841 (directory_file_name): Don't assume string length fits in long.
1842 (make_temp_name): Don't assume pid fits in int, or that its print
1843 length is less than 20.
1844
1845 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1846
1847 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1848
1849 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1850
1851 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1852 We prefer signed integers, even for size calculations.
1853
1854 * emacs.c: Don't assume string length fits in 'int'.
1855 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1856 (main): Don't invoke strlen when not needed.
1857
1858 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1859 (XD_DEBUG_MESSAGE): Don't waste a byte.
1860
1861 * callproc.c (getenv_internal_1, getenv_internal)
1862 (Fgetenv_internal):
1863 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1864
1865 * lread.c (invalid_syntax): Omit length argument.
1866 All uses changed. This doesn't fix a bug, but it simplifies the
1867 code away from its former Hollerith-constant appearance, and it's
1868 one less 'int' to worry about when looking at integer-overflow issues.
1869 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1870
1871 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1872 This didn't break anything, but it didn't help either.
1873 It's confusing to put a bogus integer in a place where the actual
1874 value does not matter.
1875 (LIST_END_P): Remove unused macro and its bogus comment.
1876 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1877
1878 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1879 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1880 implementation.
1881 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1882 We prefer signed types, and the value cannot exceed the EMACS_INT
1883 range anyway (because otherwise the length would not be representable).
1884 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1885 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1886 This avoids a GCC warning when WIDE_EMACS_INT.
1887
1888 * indent.c (sane_tab_width): New function.
1889 (current_column, scan_for_column, Findent_to, position_indentation)
1890 (compute_motion): Use it. This is just for clarity.
1891 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1892
1893 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1894
1895 * lisp.h (lint_assume): New macro.
1896 * composite.c (composition_gstring_put_cache):
1897 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1898
1899 * editfns.c, insdel.c:
1900 Omit unnecessary forward decls, to simplify future changes.
1901
1902 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1903
1904 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1905
1906 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1907 Use much-faster test for byte-length change.
1908 Don't assume string byte-length fits in 'int'.
1909 Check that character arg fits in 'int'.
1910 (mapcar1): Declare byte as byte, for clarity.
1911
1912 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1913
1914 * fns.c (concat): Catch string overflow earlier.
1915 Do not rely on integer wraparound.
1916
1917 * dispextern.h (struct it.overlay_strings_charpos)
1918 (struct it.selective): Now EMACS_INT, not int.
1919 * xdisp.c (forward_to_next_line_start)
1920 (back_to_previous_visible_line_start)
1921 (reseat_at_next_visible_line_start, next_element_from_buffer):
1922 Don't arbitrarily truncate the value of 'selective' to int.
1923
1924 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1925
1926 * composite.c: Don't truncate sizes to 'int'.
1927 (composition_gstring_p, composition_reseat_it)
1928 (composition_adjust_point): Use EMACS_INT, not int.
1929 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1930 not EMACS_UINT, for indexes.
1931
1932 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1933
1934 * buffer.c: Include <verify.h>.
1935 (struct sortvec.priority, struct sortstr.priority):
1936 Now EMACS_INT, not int.
1937 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1938 (struct sortstr.size, record_overlay_string)
1939 (struct sortstrlist.size, struct sortlist.used):
1940 Don't truncate size to int.
1941 (record_overlay_string): Check for size-calculation overflow.
1942 (init_buffer_once): Check at compile-time, not run-time.
1943
1944 2011-06-22 Jim Meyering <meyering@redhat.com>
1945
1946 Don't leak an XBM-image-sized buffer
1947 * image.c (xbm_load): Free the image buffer after using it.
1948
1949 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1950
1951 Port to Sun C.
1952 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1953 that Sun C diagnosed.
1954 * fns.c (secure_hash): Fix pointer signedness issue.
1955 * intervals.c (static_offset_intervals): New function.
1956 (offset_intervals): Use it.
1957
1958 2011-06-21 Leo Liu <sdl.web@gmail.com>
1959
1960 * deps.mk (fns.o):
1961 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1962 sha512.h.
1963
1964 * fns.c (secure_hash): Rename from crypto_hash_function and change
1965 the first arg to accept symbols.
1966 (Fsecure_hash): New primitive.
1967 (syms_of_fns): New symbols.
1968
1969 2011-06-20 Deniz Dogan <deniz@dogan.se>
1970
1971 * process.c (Fset_process_buffer): Clarify return value in
1972 docstring.
1973
1974 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1975
1976 * dispnew.c (add_window_display_history): Use BVAR.
1977
1978 * xdisp.c (debug_method_add): Use BVAR.
1979 (check_window_end, dump_glyph_matrix, dump_glyph)
1980 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1981
1982 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1983 Likewise.
1984
1985 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1986 check till after the cache is created in init_frame_faces.
1987
1988 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1989
1990 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1991
1992 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1993
1994 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1995 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1996 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1997
1998 Improve buffer-overflow checking (Bug#8873).
1999 * fileio.c (Finsert_file_contents):
2000 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2001 Remove the old (too-loose) buffer overflow checks.
2002 They weren't needed, since make_gap checks for buffer overflow.
2003 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2004 The old code merely checked for Emacs fixnum overflow, and relied
2005 on undefined (wraparound) behavior. The new code avoids undefined
2006 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2007
2008 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2009 Tune. Don't use wider integers than needed. Don't use alloca.
2010 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2011
2012 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2013
2014 * insdel.c, lisp.h (buffer_overflow): New function.
2015 (insert_from_buffer_1, replace_range, replace_range_2):
2016 * insdel.c (make_gap_larger):
2017 * editfns.c (Finsert_char):
2018 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2019
2020 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2021
2022 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2023
2024 Integer overflow and signedness fixes (Bug#8873).
2025
2026 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2027 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2028
2029 * fileio.c: Don't assume EMACS_INT fits in off_t.
2030 (emacs_lseek): New static function.
2031 (Finsert_file_contents, Fwrite_region): Use it.
2032 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2033
2034 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2035
2036 * fns.c: Don't overflow int when computing a list length.
2037 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2038 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2039 truncation on 64-bit hosts. Check for QUIT every
2040 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2041 faster and is responsive enough.
2042 (Flength): Report an error instead of overflowing an integer.
2043 (Fsafe_length): Return a float if the value is not representable
2044 as a fixnum. This shouldn't happen except in contrived situations.
2045 (Fnthcdr, Fsort): Don't assume list length fits in int.
2046 (Fcopy_sequence): Don't assume vector length fits in int.
2047
2048 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2049 (header_size, word_size): New constants.
2050 (allocate_vectorlike): Don't check size overflow here.
2051 (allocate_vector): Check it here instead, since this is the only
2052 caller of allocate_vectorlike that could cause overflow.
2053 Check that the new vector's length is representable as a fixnum.
2054
2055 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2056 The previous code was bogus. For example, next_almost_prime (32)
2057 returned 39, which is undesirable as it is a multiple of 3; and
2058 next_almost_prime (24) returned 25, which is a multiple of 5 so
2059 why was the code bothering to check for multiples of 7?
2060
2061 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2062
2063 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2064
2065 Variadic C functions now count arguments with ptrdiff_t.
2066 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2067 Back then I didn't know that the Emacs coding style prefers signed int.
2068 Also, in the meantime I found a few more instances where arguments
2069 were being counted with int, which may truncate counts on 64-bit
2070 machines, or EMACS_INT, which may be unnecessarily wide.
2071 * lisp.h (struct Lisp_Subr.function.aMANY)
2072 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2073 Arg counts are now ptrdiff_t, not size_t.
2074 All variadic functions and their callers changed accordingly.
2075 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2076 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2077 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2078 * callint.c (Fcall_interactively): Check arg count for overflow,
2079 to avoid potential buffer overrun. Use signed char, not 'int',
2080 for 'varies' array, so that we needn't bother to check its size
2081 calculation for overflow.
2082 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2083 * eval.c (apply_lambda):
2084 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2085 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2086 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2087
2088 * callint.c (Fcall_interactively): Don't use index var as event count.
2089
2090 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2091 * mem-limits.h (SIZE): Remove; no longer used.
2092
2093 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2094
2095 Remove unnecessary casts.
2096 * xterm.c (x_term_init):
2097 * xfns.c (x_set_border_pixel):
2098 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2099 These aren't needed now that we assume ANSI C.
2100
2101 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2102 It's more likely to cause problems (due to unsigned overflow)
2103 than to cure them.
2104
2105 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2106
2107 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2108
2109 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2110
2111 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2112
2113 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2114
2115 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2116
2117 GLYPH_CODE_FACE returns EMACS_INT, not int.
2118 * dispextern.h (merge_faces):
2119 * xfaces.c (merge_faces):
2120 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2121 Don't assume EMACS_INT fits in int.
2122
2123 * character.h (CHAR_VALID_P): Remove unused parameter.
2124 * fontset.c, lisp.h, xdisp.c: All uses changed.
2125
2126 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2127
2128 * fns.c (concat): Minor tuning based on overflow analysis.
2129 This doesn't fix any bugs. Use int to hold character, instead
2130 of constantly refetching from Emacs object. Use XFASTINT, not
2131 XINT, for value known to be a character. Don't bother comparing
2132 a single byte to 0400, as it's always less.
2133
2134 * floatfns.c (Fexpt):
2135 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2136
2137 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2138 for characters.
2139
2140 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2141
2142 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2143 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2144 incorrectly succeed when S was a string, because 4294967386 was
2145 truncated before it was used.
2146
2147 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2148 Otherwise, an out-of-range integer could cause undefined behavior
2149 on a 64-bit host.
2150
2151 * composite.c: Use int, not EMACS_INT, for characters.
2152 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2153 EMACS_INT, for values that are known to be in character range.
2154 This doesn't fix any bugs but is the usual style inside Emacs and
2155 may generate better code on 32-bit machines.
2156
2157 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2158 This is for reasons similar to the recent CHAR_STRING fix.
2159 * charset.c (Fencode_char): Check that character arg is actually
2160 a character. Pass an int to ENCODE_CHAR.
2161 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2162 wider than 'int', as a compile-time check to prevent future regressions
2163 in this area.
2164
2165 * character.c (char_string): Remove unnecessary casts.
2166
2167 Make sure a 64-bit char is never passed to CHAR_STRING.
2168 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2169 by silently ignoring the top 32 bits, allowing some values
2170 that were far too large to be valid characters.
2171 * character.h: Include <verify.h>.
2172 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2173 arguments are no wider than unsigned, as a compile-time check
2174 to prevent future regressions in this area.
2175 * data.c (Faset):
2176 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2177 (Fsubst_char_in_region):
2178 * fns.c (concat):
2179 * xdisp.c (decode_mode_spec_coding):
2180 Adjust to CHAR_STRING's new requirement.
2181 * editfns.c (Finsert_char, Fsubst_char_in_region):
2182 * fns.c (concat): Check that character args are actually
2183 characters. Without this test, these functions did the wrong
2184 thing with wildly out-of-range values on 64-bit hosts.
2185
2186 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2187 These casts should not be needed on 32-bit hosts, either.
2188 * keyboard.c (read_char):
2189 * lread.c (Fload): Remove casts to unsigned.
2190
2191 * lisp.h (UNSIGNED_CMP): New macro.
2192 This fixes comparison bugs on 64-bit hosts.
2193 (ASCII_CHAR_P): Use it.
2194 * casefiddle.c (casify_object):
2195 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2196 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2197 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2198 * dispextern.h (FACE_FROM_ID):
2199 * keyboard.c (read_char): Use UNSIGNED_CMP.
2200
2201 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2202 not to EMACS_INT, to avoid GCC warning.
2203
2204 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2205
2206 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2207 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2208 isn't needed on 32-bit machines.
2209
2210 * buffer.c (Fgenerate_new_buffer_name):
2211 Use EMACS_INT for count, not int.
2212 (advance_to_char_boundary): Return EMACS_INT, not int.
2213
2214 * data.c (Qcompiled_function): Now static.
2215
2216 * window.c (window_body_lines): Now static.
2217
2218 * image.c (gif_load): Rename local to avoid shadowing.
2219
2220 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2221 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2222 * alloc.c (make_save_value): Integer argument is now of type
2223 ptrdiff_t, not int.
2224 (mark_object): Use ptrdiff_t, not int.
2225 * lisp.h (pD): New macro.
2226 * print.c (print_object): Use it.
2227
2228 * alloc.c: Use EMACS_INT, not int, to count objects.
2229 (total_conses, total_markers, total_symbols, total_vector_size)
2230 (total_free_conses, total_free_markers, total_free_symbols)
2231 (total_free_floats, total_floats, total_free_intervals)
2232 (total_intervals, total_strings, total_free_strings):
2233 Now EMACS_INT, not int. All uses changed.
2234 (Fgarbage_collect): Compute overall total using a double, so that
2235 integer overflow is less likely to be a problem. Check for overflow
2236 when converting back to an integer.
2237 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2238 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2239 These were 'int' variables that could overflow on 64-bit hosts;
2240 they were never used, so remove them instead of repairing them.
2241 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2242 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2243 Previously, this ceilinged at INT_MAX, but that doesn't work on
2244 64-bit machines.
2245 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2246
2247 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2248 (allocate_vectorlike): Check for ptrdiff_t overflow.
2249 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2250 when a (possibly-narrower) signed value would do just as well.
2251 We prefer using signed arithmetic, to avoid comparison confusion.
2252
2253 * alloc.c: Catch some string size overflows that we were missing.
2254 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2255 for convenience in STRING_BYTES_MAX.
2256 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2257 The definition here is exact; the one in lisp.h was approximate.
2258 (allocate_string_data): Check for string overflow. This catches
2259 some instances we weren't catching before. Also, it catches
2260 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2261 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2262 and ptrdiff_t and EMACS_INT are both 64 bits.
2263
2264 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2265 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2266 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2267
2268 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2269
2270 * alloc.c (Fmake_string): Check for out-of-range init.
2271
2272 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2273
2274 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2275
2276 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2277
2278 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2279 xg_get_default_scrollbar_width.
2280
2281 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2282 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2283 (style_changed_cb): Call update_theme_scrollbar_width and call
2284 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2285 all frames (Bug#8505).
2286 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2287 Call gtk_window_set_resizable if HAVE_GTK3.
2288 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2289 and height if HAVE_GTK3 (Bug#8505).
2290 (scroll_bar_width_for_theme): New variable.
2291 (update_theme_scrollbar_width): New function.
2292 (xg_get_default_scrollbar_width): Move code to
2293 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2294 (xg_initialize): Call update_theme_scrollbar_width.
2295
2296 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2297
2298 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2299
2300 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2301
2302 * frame.c (make_frame): Call other_buffer_safely instead of
2303 other_buffer.
2304
2305 * window.c (temp_output_buffer_show): Call display_buffer with
2306 second argument Vtemp_buffer_show_specifiers and reset latter
2307 immediately after the call.
2308 (Vtemp_buffer_show_specifiers): New variable.
2309 (auto_window_vscroll_p, next_screen_context_lines)
2310 (Vscroll_preserve_screen_position): Remove leading asterisks from
2311 doc-strings.
2312
2313 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2314
2315 Fix minor problems found by GCC 4.6.0 static checking.
2316 * buffer.c (Qclone_number): Remove for now, as it's unused.
2317 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2318 (record_buffer): Remove unused local.
2319 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2320 (set_frame_buffer_list): Remove; unused.
2321 * frame.h (other_visible_frames): Remove decl.
2322 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2323 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2324 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2325 if HAVE_GPM.
2326 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2327 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2328 Define only if HAVE_GPM.
2329 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2330 (update_hints_inhibit): Remove; never set. All uses removed.
2331 * widgetprv.h (emacsFrameClassRec): Remove decl.
2332 * window.c (delete_deletable_window): Now returns void, since it
2333 wasn't returning anything.
2334 (compare_window_configurations): Remove unused locals.
2335 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2336 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2337 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2338 the same widths as pointers. This follows up on the 2011-05-06 patch.
2339 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2340 * xterm.h: Likewise.
2341 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2342
2343 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2344
2345 * makefile.w32-in: Update dependencies.
2346 (LISP_H): Add lib/intprops.h.
2347
2348 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2349
2350 * image.c (gif_load): Add animation frame delay to the metadata.
2351 (syms_of_image): Use DEFSYM. New symbol `delay'.
2352
2353 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2354
2355 * window.c (delete_deletable_window): Re-add.
2356 (Fset_window_configuration): Rewrite to handle dead buffers and
2357 consequently deletable windows.
2358 (window_tree, Fwindow_tree): Remove. Supply functionality in
2359 window.el.
2360 (compare_window_configurations): Simplify code.
2361
2362 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2363
2364 * image.c (imagemagick_load_image): Fix type mismatch.
2365 (Fimagemagick_types): Likewise.
2366
2367 * window.h (replace_buffer_in_windows): Declare.
2368
2369 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2370
2371 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2372 Qclone_number. Remove external declaration of Qdelete_window.
2373 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2374 code.
2375 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2376 Run Qbuffer_list_update_hook if allowed.
2377 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2378 buffer list implementation.
2379 (other_buffer_safely): New function.
2380 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2381 calls to replace_buffer_in_windows and
2382 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2383 if allowed.
2384 (record_buffer): Inhibit quitting and rewrite using quittable
2385 functions. Run Qbuffer_list_update_hook if allowed.
2386 (Frecord_buffer, Funrecord_buffer): New functions.
2387 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2388 Move switch-to-buffer to window.el.
2389 (bury-buffer): Move to window.el.
2390 (Vbuffer_list_update_hook): New variable.
2391
2392 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2393 section.
2394
2395 * window.h (resize_frame_windows): Move up in code.
2396 (Fwindow_frame): Remove EXFUN.
2397 (replace_buffer_in_all_windows): Remove prototype.
2398 (replace_buffer_in_windows_safely): Add prototype.
2399
2400 * window.c: Declare Qdelete_window static again. Move down
2401 declaration of select_count.
2402 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2403 (Fother_window): Move to window.el.
2404 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2405 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2406 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2407 window.el.
2408 (replace_buffer_in_windows): Implement by calling
2409 Qreplace_buffer_in_windows.
2410 (replace_buffer_in_all_windows): Remove with some functionality
2411 moved into replace_buffer_in_windows_safely.
2412 (replace_buffer_in_windows_safely): New function.
2413 (select_window_norecord, select_frame_norecord): Move in front
2414 of run_window_configuration_change_hook. Remove now obsolete
2415 declarations.
2416 (Fset_window_buffer): Rewrite doc-string.
2417 Call Qrecord_window_buffer.
2418 (keys_of_window): Move binding for other-window to window.el.
2419
2420 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2421
2422 * dispextern.h (struct image): Replace data member, whose int_val
2423 and ptr_val fields were not used by anything, with a single
2424 lisp_val object.
2425
2426 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2427 (gif_clear_image, gif_load, imagemagick_load_image)
2428 (gs_clear_image, gs_load): Callers changed.
2429
2430 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2431
2432 * buffer.h: Include <time.h>, for time_t.
2433 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2434
2435 Fix minor problems found by static checking.
2436
2437 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2438
2439 Make identifiers static if they are not used in other modules.
2440 * data.c (Qcompiled_function, Qframe, Qvector):
2441 * image.c (QimageMagick, Qsvg):
2442 * minibuf.c (Qmetadata):
2443 * window.c (resize_window_check, resize_root_window): Now static.
2444 * window.h (resize_window_check, resize_root_window): Remove decls.
2445
2446 * window.c (window_deletion_count, delete_deletable_window):
2447 Remove; unused.
2448 (window_body_lines): Now static.
2449 (Fdelete_other_windows_internal): Mark vars as initialized.
2450 Make sure 'resize_failed' is initialized.
2451 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2452 (resize_window_apply): Remove unused local.
2453 * window.h (delete_deletable_window): Remove decl.
2454
2455 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2456 (imagemagick_load_image): Fix pointer signedness problem by changing
2457 last arg from unsigned char * to char *. All uses changed.
2458 Also, fix a local for similar reasons.
2459 Remove unused locals. Remove locals to avoid shadowing.
2460 (fn_rsvg_handle_free): Remove; unused.
2461 (svg_load, svg_load_image): Fix pointer signedness problem.
2462 (imagemagick_load_image): Don't use garbage pointer image_wand.
2463
2464 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2465
2466 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2467
2468 * image.c (gif_load): Fix omitted cast error introduced by
2469 2011-06-06 change.
2470
2471 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2472
2473 * window.h (resize_proportionally, orig_total_lines)
2474 (orig_top_line): Remove from window structure.
2475 (set_window_height, set_window_width, change_window_heights)
2476 (Fdelete_window): Remove prototypes.
2477 (resize_frame_windows): Remove duplicate declaration.
2478
2479 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2480
2481 * window.h (resize_frame_windows, resize_window_check)
2482 (delete_deletable_window, resize_root_window)
2483 (resize_frame_windows): Declare prototypes.
2484
2485 * window.c (resize_window_apply): Make definition be "static" to
2486 match the prototype.
2487
2488 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2489
2490 * window.c: Remove declarations of Qwindow_size_fixed,
2491 window_min_size_1, window_min_size_2, window_min_size,
2492 size_window, window_fixed_size_p, enlarge_window, delete_window.
2493 Remove static from declaration of Qdelete_window, it's
2494 temporarily needed by Fbury_buffer.
2495 (replace_window): Don't assign orig_top_line and
2496 orig_total_lines.
2497 (Fdelete_window, delete_window): Remove. Window deletion is
2498 handled by window.el.
2499 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2500 Replace Fdelete_window calls with calls to Qdelete_window.
2501 (Fdelete_other_windows): Remove. Deleting other windows is
2502 handled by window.el.
2503 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2504 handled in window.el.
2505 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2506 Window minimum sizes are handled in window.el.
2507 (shrink_windows, size_window, set_window_height)
2508 (set_window_width, change_window_heights, window_height)
2509 (window_width, CURBEG, CURSIZE, enlarge_window)
2510 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2511 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2512 handled in window.el.
2513 (make_dummy_parent): Rename to make_parent_window and give it a
2514 second argument horflag.
2515 (make_window): Don't set resize_proportionally any more.
2516 (Fsplit_window): Remove. Windows are split in window.el.
2517 (save_restore_action, save_restore_orig_size)
2518 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2519 Resize mini windows in window.el.
2520 (grow_mini_window, shrink_mini_window): Implement by calling
2521 Qresize_root_window_vertically, resize_window_check and
2522 resize_window_apply.
2523 (saved_window, Fset_window_configuration, save_window_save):
2524 Do not handle orig_top_line, orig_total_lines, and
2525 resize_proportionally.
2526 (window_min_height, window_min_width): Move to window.el.
2527 (keys_of_window): Move bindings for delete-other-windows,
2528 split-window, delete-window and enlarge-window to window.el.
2529
2530 * buffer.c: Temporarily extern Qdelete_window.
2531 (Fbury_buffer): Temporarily call Qdelete_window instead of
2532 Fdelete_window (Fbury_buffer will move to window.el soon).
2533
2534 * frame.c (set_menu_bar_lines_1): Remove code handling
2535 orig_top_line and orig_total_lines.
2536
2537 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2538 set_window_height but set heights directly.
2539 (change_frame_size_1): Use resize_frame_windows.
2540
2541 * xdisp.c (init_xdisp): Don't use set_window_height but set
2542 heights directly.
2543
2544 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2545 Use resize_frame_windows instead of change_window_heights and run
2546 run_window_configuration_change_hook.
2547
2548 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2549 instead of change_window_heights and run
2550 run_window_configuration_change_hook.
2551
2552 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2553
2554 * window.c (replace_window): Rename second argument REPLACEMENT to
2555 NEW. New third argument SETFLAG. Rewrite.
2556 (delete_window, make_dummy_parent): Call replace_window with
2557 third argument 1.
2558 (window_list_1): Move down in code.
2559 (run_window_configuration_change_hook): Move set_buffer part
2560 before select_frame_norecord part in order to unwind correctly.
2561 Rename count1 to count.
2562 (recombine_windows, delete_deletable_window, resize_root_window)
2563 (Fdelete_other_windows_internal)
2564 (Frun_window_configuration_change_hook, make_parent_window)
2565 (resize_window_check, resize_window_apply, Fresize_window_apply)
2566 (resize_frame_windows, Fsplit_window_internal)
2567 (Fdelete_window_internal, Fresize_mini_window_internal):
2568 New functions.
2569 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2570
2571 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2572
2573 * window.h (window): Add some new members to window structure -
2574 normal_lines, normal_cols, new_total, new_normal, clone_number,
2575 splits, nest, prev_buffers, next_buffers.
2576 (WINDOW_TOTAL_SIZE): Move here from window.c.
2577 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2578
2579 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2580 Remove.
2581 (make_dummy_parent): Set new members of windows structure.
2582 (make_window): Move down in code. Handle new members of window
2583 structure.
2584 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2585 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2586 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2587 (Fset_window_prev_buffers, Fwindow_next_buffers)
2588 (Fset_window_next_buffers, Fset_window_clone_number):
2589 New functions.
2590 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2591 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2592 Doc-string fixes.
2593 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2594 Argument WINDOW can be now internal window too.
2595 (Fwindow_use_time): Move up in code.
2596 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2597 Rewrite doc-string.
2598 (Fset_window_configuration, saved_window)
2599 (Fcurrent_window_configuration, save_window_save): Handle new
2600 members of window structure.
2601 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2602 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2603 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2604 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2605 Qget_mru_window, Qresize_root_window,
2606 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2607 Qauto_buffer_name; staticpro them.
2608
2609 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2610
2611 * window.c (Fwindow_total_size, Fwindow_left_column)
2612 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2613 (Fwindow_list_1): New functions.
2614 (window_box_text_cols): Replace with window_body_cols.
2615 (Fwindow_width, Fscroll_left, Fscroll_right):
2616 Use window_body_cols instead of window_box_text_cols.
2617 (delete_window, Fset_window_configuration):
2618 Call delete_all_subwindows with window as argument.
2619 (delete_all_subwindows): Take a window as argument and not a
2620 structure. Rewrite.
2621 (window_loop): Remove handling of GET_LRU_WINDOW and
2622 GET_LARGEST_WINDOW.
2623 (Fget_lru_window, Fget_largest_window): Move to window.el.
2624
2625 * window.h: Extern window_body_cols instead of
2626 window_box_text_cols. delete_all_subwindows now takes a
2627 Lisp_Object as argument.
2628
2629 * indent.c (compute_motion, Fcompute_motion):
2630 Use window_body_cols instead of window_box_text_cols.
2631
2632 * frame.c (delete_frame): Call delete_all_subwindows with root
2633 window as argument.
2634
2635 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2636
2637 * fns.c (Fputhash): Document return value.
2638
2639 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2640
2641 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2642
2643 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2644
2645 Cons<->int and similar integer overflow fixes (Bug#8794).
2646
2647 Check for overflow when converting integer to cons and back.
2648 * charset.c (Fdefine_charset_internal, Fdecode_char):
2649 Use cons_to_unsigned to catch overflow.
2650 (Fencode_char): Use INTEGER_TO_CONS.
2651 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2652 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2653 * data.c (long_to_cons, cons_to_long): Remove.
2654 (cons_to_unsigned, cons_to_signed): New functions.
2655 These signal an error for invalid or out-of-range values.
2656 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2657 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2658 * font.c (Ffont_variation_glyphs):
2659 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2660 * lisp.h: Include <intprops.h>.
2661 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2662 (cons_to_signed, cons_to_unsigned): New decls.
2663 (long_to_cons, cons_to_long): Remove decls.
2664 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2665 (Fprimitive_undo): Use CONS_TO_INTEGER.
2666 * xfns.c (Fx_window_property): Likewise.
2667 * xselect.c: Include <limits.h>.
2668 (x_own_selection, selection_data_to_lisp_data):
2669 Use INTEGER_TO_CONS.
2670 (x_handle_selection_request, x_handle_selection_clear)
2671 (x_get_foreign_selection, Fx_disown_selection_internal)
2672 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2673 (lisp_data_to_selection_data): Use cons_to_unsigned.
2674 (x_fill_property_data): Use cons_to_signed.
2675 Report values out of range.
2676
2677 Check for buffer and string overflow more precisely.
2678 * buffer.h (BUF_BYTES_MAX): New macro.
2679 * lisp.h (STRING_BYTES_MAX): New macro.
2680 * alloc.c (Fmake_string):
2681 * character.c (string_escape_byte8):
2682 * coding.c (coding_alloc_by_realloc):
2683 * doprnt.c (doprnt):
2684 * editfns.c (Fformat):
2685 * eval.c (verror):
2686 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2687 since they may not be the same number.
2688 * editfns.c (Finsert_char):
2689 * fileio.c (Finsert_file_contents):
2690 Likewise for BUF_BYTES_MAX.
2691
2692 * image.c: Use ptrdiff_t, not int, for sizes.
2693 (slurp_file): Switch from int to ptrdiff_t.
2694 All uses changed.
2695 (slurp_file): Check that file size fits in both size_t (for
2696 malloc) and ptrdiff_t (for sanity and safety).
2697
2698 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2699 if b->modtime has its maximal value.
2700
2701 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2702
2703 Don't assume time_t can fit into int.
2704 * buffer.h (struct buffer.modtime): Now time_t, not int.
2705 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2706 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2707
2708 Minor fixes for signed vs unsigned integers.
2709 * character.h (MAYBE_UNIFY_CHAR):
2710 * charset.c (maybe_unify_char):
2711 * keyboard.c (read_char, reorder_modifiers):
2712 XINT -> XFASTINT, since the integer must be nonnegative.
2713 * ftfont.c (ftfont_spec_pattern):
2714 * keymap.c (access_keymap, silly_event_symbol_error):
2715 XUINT -> XFASTINT, since the integer must be nonnegative.
2716 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2717 since it makes no difference and we prefer signed.
2718 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2719 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2720 nonnegative.
2721
2722 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2723
2724 * window.h (Fwindow_frame): Declare.
2725
2726 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2727
2728 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2729 (SPARE_MEMORY): Always define.
2730 (LARGE_REQUEST): Remove.
2731 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2732
2733 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2734
2735 * lisp.h: Move EXFUNS for Fframe_root_window,
2736 Fframe_first_window and Fset_frame_selected_window to window.h.
2737
2738 * window.h: Move EXFUNS for Fframe_root_window,
2739 Fframe_first_window and Fset_frame_selected_window here from
2740 lisp.h.
2741
2742 * frame.c (Fwindow_frame, Fframe_first_window)
2743 (Fframe_root_window, Fframe_selected_window)
2744 (Fset_frame_selected_window): Move to window.c.
2745 (Factive_minibuffer_window): Move to minibuf.c.
2746 (Fother_visible_frames_p): New function.
2747
2748 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2749
2750 * window.c (decode_window, decode_any_window): Move up in code.
2751 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2752 (inhibit_frame_unsplittable): Remove unused variable.
2753 (Fwindow_buffer): Move up and rewrite doc-string.
2754 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2755 (Fwindow_prev): New functions.
2756 (Fwindow_frame): Move here from frame.c. Accept any window as
2757 argument.
2758 (Fframe_root_window, Fframe_first_window)
2759 (Fframe_selected_window): Move here from frame.c. Accept frame
2760 or arbitrary window as argument. Update doc-strings.
2761 (Fminibuffer_window): Move up in code.
2762 (Fwindow_minibuffer_p): Move up in code and simplify.
2763 (Fset_frame_selected_window): Move here from frame.c.
2764 Marginal rewrite.
2765 (Fselected_window, select_window, Fselect_window): Move up in
2766 code. Minor doc-string fixes.
2767
2768 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2769
2770 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2771 Do not assume that spare memory exists; that assumption is valid
2772 only if SYSTEM_MALLOC.
2773 (LARGE_REQUEST): New macro, so that the issue of large requests
2774 is separated from the issue of spare memory.
2775
2776 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2777
2778 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2779 format. (Bug#8806)
2780
2781 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2782
2783 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2784 before statements.
2785
2786 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2787
2788 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2789
2790 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2791
2792 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2793 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2794
2795 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2796
2797 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2798
2799 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2800
2801 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2802 (x_clipboard_manager_save): Add return value.
2803 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2804 New error handlers.
2805 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2806 Obey Vx_select_enable_clipboard_manager. Catch errors in
2807 x_clipboard_manager_save (Bug#8779).
2808 (Vx_select_enable_clipboard_manager): New variable.
2809 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2810
2811 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2812
2813 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2814
2815 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2816
2817 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2818 in the current matrix if keep_current_p is non-zero.
2819
2820 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2821
2822 * bidi.c (bidi_level_of_next_char): Fix last change.
2823
2824 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2825
2826 Support bidi reordering of text covered by display properties.
2827
2828 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2829 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2830 (bidi_cache_search, bidi_cache_iterator_state)
2831 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2832 (bidi_level_of_next_char, bidi_move_to_visually_next):
2833 Support character positions inside a run of characters covered by a
2834 display string.
2835 (bidi_paragraph_init, bidi_resolve_explicit_1)
2836 (bidi_level_of_next_char): Call bidi_fetch_char and
2837 bidi_fetch_char_advance instead of FETCH_CHAR and
2838 FETCH_CHAR_ADVANCE.
2839 (bidi_init_it): Initialize new members.
2840 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2841 definitions.
2842 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2843 instead of using explicit *_CHAR codes.
2844 (bidi_resolve_explicit, bidi_resolve_weak):
2845 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2846 bidirectional text is supported only in multibyte buffers.
2847 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2848 it to initialize the frame_window_p member of struct bidi_it.
2849 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2850 (bidi_resolve_explicit, bidi_resolve_weak)
2851 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2852 bidi_it->nchars is non-positive.
2853 (bidi_level_of_next_char): Don't try to lookup the cache for the
2854 next/previous character if nothing is cached there yet, or if we
2855 were just reseat()'ed to a new position.
2856
2857 * xdisp.c (set_cursor_from_row): Set start and stop points
2858 according to the row's direction when priming the loop that looks
2859 for the glyph on which to display cursor.
2860 (single_display_spec_intangible_p): Function deleted.
2861 (display_prop_intangible_p): Reimplement to call
2862 handle_display_spec instead of single_display_spec_intangible_p.
2863 Accept 3 additional arguments needed by handle_display_spec.
2864 This fixes incorrect cursor motion across display property with complex
2865 values: lists, `(when COND...)' forms, etc.
2866 (single_display_spec_string_p): Support property values that are
2867 lists with the argument STRING its top-level element.
2868 (display_prop_string_p): Fix the condition for processing a
2869 property that is a list to be consistent with handle_display_spec.
2870 (handle_display_spec): New function, refactored from the
2871 last portion of handle_display_prop.
2872 (compute_display_string_pos): Accept additional argument
2873 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2874 value of a `display' property is a "replacing spec".
2875 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2876 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2877 the display property, but just return a value indicating whether
2878 the display property will replace the characters it covers.
2879 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2880 frame_window_p members of struct bidi_it.
2881 (compute_display_string_pos, compute_display_string_end):
2882 New functions.
2883 (push_it): Accept second argument POSITION, where pop_it should
2884 jump to continue iteration.
2885 (reseat_1): Initialize bidi_it.disp_pos.
2886
2887 * keyboard.c (adjust_point_for_property): Adjust the call to
2888 display_prop_intangible_p to its new signature.
2889
2890 * dispextern.h (struct bidi_it): New member frame_window_p.
2891 (bidi_init_it): Update prototypes.
2892 (display_prop_intangible_p): Update prototype.
2893 (compute_display_string_pos, compute_display_string_end):
2894 Declare prototypes.
2895 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2896 EMACS_INT.
2897
2898 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2899
2900 Malloc failure behavior now depends on size of allocation.
2901 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2902 * lisp.h: Change signatures accordingly.
2903 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2904 All callers changed. (Bug#8762)
2905
2906 * gnutls.c: Use Emacs's memory allocators.
2907 Without this change, the gnutls library would invoke malloc etc.
2908 directly, which causes problems on non-SYNC_INPUT hosts, and which
2909 runs afoul of improving memory_full behavior. (Bug#8761)
2910 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2911 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2912 xfree instead of the default malloc, realloc, free.
2913 (Fgnutls_boot): No need to check for memory allocation failure,
2914 since xmalloc does that for us.
2915
2916 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2917 * category.c (hash_get_category_set):
2918 * ccl.c (ccl_driver):
2919 * charset.c (Fdefine_charset_internal):
2920 * charset.h (struct charset.hash_index):
2921 * composite.c (get_composition_id, gstring_lookup_cache)
2922 (composition_gstring_put_cache):
2923 * composite.h (struct composition.hash_index):
2924 * dispextern.h (struct image.hash):
2925 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2926 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2927 (hashfn_equal, hashfn_user_defined, make_hash_table)
2928 (maybe_resize_hash_table, hash_lookup, hash_put)
2929 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2930 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2931 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2932 * image.c (make_image, search_image_cache, lookup_image)
2933 (xpm_put_color_table_h):
2934 * lisp.h (struct Lisp_Hash_Table):
2935 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2936 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2937 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2938 * alloc.c (allocate_vectorlike):
2939 Check for overflow in vector size calculations.
2940 * ccl.c (ccl_driver):
2941 Check for overflow when converting EMACS_INT to int.
2942 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2943 need to be updated by these changes.
2944 * fns.c (make_hash_table, maybe_resize_hash_table):
2945 Check for integer overflow with large hash tables.
2946 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2947 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2948 (SXHASH_REDUCE): New macro.
2949 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2950 Use it instead of discarding useful hash info with large hash values.
2951 (sxhash_float): New function.
2952 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2953 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2954 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2955 Rewrite to use FIXNUM_BITS, as this simplifies things.
2956 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2957 Adjust signatures to match updated version of code.
2958 (consing_since_gc): Now EMACS_INT, since a single hash table can
2959 use more than INT_MAX bytes.
2960
2961 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2962
2963 Make it possible to build with GCC-4.6+ -O2 -flto.
2964
2965 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2966
2967 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2968
2969 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2970 Call minibuffer-inactive-mode.
2971
2972 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2973
2974 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2975 Update dependencies.
2976
2977 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2978
2979 * data.c (init_data): Remove code for UTS, this system is not
2980 supported anymore.
2981
2982 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2983
2984 Don't force ./temacs to start in terminal mode.
2985
2986 * frame.c (make_initial_frame): Initialize faces in all cases, not
2987 only when CANNOT_DUMP is defined.
2988 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2989
2990 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2991
2992 * dispnew.c (add_window_display_history): Use const for the string
2993 pointer. Remove declaration, not needed.
2994
2995 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2996
2997 Use 'inline', not 'INLINE'.
2998 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2999 * alloc.c, fontset.c (INLINE): Remove.
3000 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3001 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3002 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3003 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3004 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3005
3006 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3007
3008 Make it possible to run ./temacs.
3009
3010 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3011 syms_of_callproc does the same thing. Remove test for
3012 "initialized", do it in the caller.
3013 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3014
3015 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3016
3017 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3018 (read_minibuf): Use get_minibuffer.
3019 (syms_of_minibuf): Use DEFSYM.
3020 (Qmetadata): New var.
3021 * data.c (Qbuffer): Don't make it static.
3022 (syms_of_data): Use DEFSYM.
3023
3024 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3025
3026 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3027 (CCL_CODE_MIN): New macro.
3028
3029 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3030
3031 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3032
3033 * eval.c (Qdebug): Now static.
3034 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3035 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3036 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3037
3038 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3039
3040 * image.c: Various fixes to ImageMagick code comments.
3041 (Fimagemagick_types): Doc fix.
3042
3043 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3044
3045 Minor fixes prompted by GCC 4.6.0 warnings.
3046
3047 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3048
3049 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3050 (x_clipboard_manager_save_all): Move extern decl to ...
3051 * xterm.h: ... here, so that it can be checked for consistency.
3052
3053 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3054
3055 * xselect.c (x_clipboard_manager_save_frame)
3056 (x_clipboard_manager_save_all): New functions.
3057 (Fx_clipboard_manager_save): Lisp function deleted.
3058
3059 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3060 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3061
3062 * xterm.h: Update prototype.
3063
3064 2011-05-28 William Xu <william.xwl@gmail.com>
3065
3066 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3067 exiting (Bug#8239).
3068
3069 2011-05-28 Jim Meyering <meyering@redhat.com>
3070
3071 Avoid a sign-extension bug in crypto_hash_function.
3072 * fns.c (to_uchar): Define.
3073 (crypto_hash_function): Use it to convert some newly-signed
3074 variables to unsigned, to avoid sign-extension bugs. For example,
3075 without this change, (md5 "truc") would evaluate to
3076 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3077 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3078 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3079
3080 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3081
3082 Integer overflow fixes.
3083
3084 * dbusbind.c: Serial number integer overflow fixes.
3085 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3086 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3087 to hold a serial number that is too large for a fixnum.
3088 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3089 Check for serial numbers out of range. Decode any serial number
3090 that was so large that it became a float. (Bug#8722)
3091
3092 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3093 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3094 Use XFASTINT rather than XUINT when numbers are nonnegative.
3095 (xd_append_arg, Fdbus_method_return_internal):
3096 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3097 arguments, check that Lisp number is nonnegative, rather than
3098 silently wrapping negative numbers around. (Bug#8722)
3099 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3100 (Bug#8722)
3101
3102 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3103
3104 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3105
3106 ccl: add integer overflow checks
3107 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3108 (IN_INT_RANGE): New macros.
3109 (ccl_driver): Use them to check for integer overflow when
3110 decoding a CCL program. Many of the new checks are whether XINT (x)
3111 fits in int; it doesn't always, on 64-bit hosts. The new version
3112 doesn't catch all possible integer overflows, but it's an
3113 improvement. (Bug#8719)
3114
3115 * alloc.c (make_event_array): Use XINT, not XUINT.
3116 There's no need for unsigned here.
3117
3118 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3119 This follows up to the 2011-05-06 change that substituted uintptr_t
3120 for EMACS_INT. This case wasn't caught back then.
3121
3122 Rework Fformat to avoid integer overflow issues.
3123 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3124 now (part of C89). Include <verify.h>.
3125 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3126 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3127 (Fformat): Avoid the prepass trying to compute sizes; it was only
3128 approximate and thus did not catch overflow reliably. Instead, walk
3129 through the format just once, formatting and computing sizes as we go,
3130 checking for integer overflow at every step, and allocating a larger
3131 buffer as needed. Keep track separately whether the format is
3132 multibyte. Keep only the most-recently calculated precision, rather
3133 than them all. Record whether each argument has been converted to
3134 string. Use EMACS_INT, not int, for byte and char and arg counts.
3135 Support field widths and precisions larger than INT_MAX. Avoid
3136 sprintf's undefined behavior with conversion specifications such as %#d
3137 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3138 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3139 formatting out-of-range floating point numbers with int
3140 formats. (Bug#8668)
3141
3142 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3143
3144 * data.c: Avoid integer truncation in expressions involving floats.
3145 * data.c: Include <intprops.h>.
3146 (arith_driver): When there's an integer overflow in an expression
3147 involving floating point, convert the integers to floating point
3148 so that the resulting value does not suffer from catastrophic
3149 integer truncation. For example, on a 64-bit host (* 4
3150 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3151 Do not rely on undefined behavior after integer overflow.
3152
3153 merge count_size_as_multibyte, parse_str_to_multibyte
3154 * character.c, character.h (count_size_as_multibyte):
3155 Rename from parse_str_to_multibyte; all uses changed.
3156 Check for integer overflow.
3157 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3158 since it's now a duplicate of the other. This is more of
3159 a character than a buffer op, so better that it's in character.c.
3160 * fns.c, print.c: Adjust to above changes.
3161
3162 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3163
3164 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3165
3166 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3167
3168 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3169 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3170 (x_clipboard_manager_save): Now static.
3171 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3172
3173 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3174 (crypto_hash_function): Now static.
3175 Fix pointer signedness problems. Avoid unnecessary initializations.
3176
3177 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3178
3179 * termhooks.h (Vselection_alist): Make it terminal-local.
3180
3181 * terminal.c (create_terminal): Initialize it.
3182
3183 * xselect.c: Support for clipboard managers.
3184 (Vselection_alist): Move to termhooks.h as terminal-local var.
3185 (LOCAL_SELECTION): New macro.
3186 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3187 (symbol_to_x_atom): Remove gratuitous arg.
3188 (x_handle_selection_request, lisp_data_to_selection_data)
3189 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3190 (x_own_selection, x_get_local_selection, x_convert_selection):
3191 New arg, specifying work frame. Use terminal-local Vselection_alist.
3192 (some_frame_on_display): Delete unused function.
3193 (Fx_own_selection_internal, Fx_get_selection_internal)
3194 (Fx_disown_selection_internal, Fx_selection_owner_p)
3195 (Fx_selection_exists_p): New optional frame arg.
3196 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3197 (x_handle_selection_clear): Don't treat other terminals with the
3198 same keyboard specially. Use the terminal-local Vselection_alist.
3199 (x_clear_frame_selections): Use Frun_hook_with_args.
3200
3201 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3202
3203 * xterm.h: Add support for those atoms.
3204
3205 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3206
3207 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3208 (converted_selections, conversion_fail_tag): New global variables.
3209 (x_selection_request_lisp_error): Free the above.
3210 (x_get_local_selection): Remove unnecessary code.
3211 (x_reply_selection_request): Args changed; handle arbitrary array
3212 of converted selections stored in converted_selections.
3213 Separate the XChangeProperty and SelectionNotify steps.
3214 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3215 (x_convert_selection): New function.
3216 (x_handle_selection_event): Simplify.
3217 (x_get_foreign_selection): Don't ignore incoming requests while
3218 waiting for an answer; this will fail when we implement
3219 SAVE_TARGETS, and seems unnecessary anyway.
3220 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3221 (Vx_sent_selection_functions): Doc fix.
3222
3223 2011-05-26 Leo Liu <sdl.web@gmail.com>
3224
3225 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3226
3227 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3228
3229 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3230
3231 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3232 for fringe update if it has periodic bitmap.
3233 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3234 and fringe_bitmap_periodic_p.
3235
3236 * fringe.c (get_fringe_bitmap_data): New function.
3237 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3238 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3239 row. Mark glyph row for fringe update if periodicity changed.
3240
3241 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3242 for fringe update unless it has periodic bitmap.
3243
3244 2011-05-25 Kenichi Handa <handa@m17n.org>
3245
3246 * xdisp.c (get_next_display_element): Set correct it->face_id for
3247 a static composition.
3248
3249 2011-05-24 Leo Liu <sdl.web@gmail.com>
3250
3251 * deps.mk (fns.o):
3252 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3253
3254 * fns.c (crypto_hash_function, Fsha1): New function.
3255 (Fmd5): Use crypto_hash_function.
3256 (syms_of_fns): Add Ssha1.
3257
3258 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3259
3260 * gnutls.c: Remove unused macros.
3261 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3262 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3263 Remove macros that are defined and never used.
3264 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3265
3266 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3267
3268 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3269 (Fx_get_selection_internal): Minor cleanup.
3270 (Fx_own_selection_internal): Rename arguments for consistency with
3271 select.el.
3272
3273 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3274
3275 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3276
3277 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3278
3279 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3280
3281 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3282
3283 * dispnew.c (scrolling_window): Don't exclude the case that the
3284 last enabled row in the desired matrix touches the bottom boundary.
3285
3286 2011-05-21 Glenn Morris <rgm@gnu.org>
3287
3288 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3289 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3290 and add some more files.
3291
3292 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3293
3294 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3295 report_file_error introduced by the change from 2011-05-07.
3296
3297 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3298
3299 * systime.h (Time): Define only if emacs is defined.
3300 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3301 where the include path doesn't have X11/X.h by default. See
3302 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3303
3304 2011-05-20 Kenichi Handa <handa@m17n.org>
3305
3306 * composite.c (find_automatic_composition): Fix previous change.
3307
3308 2011-05-20 Glenn Morris <rgm@gnu.org>
3309
3310 * lisp.mk: New file, split from Makefile.in.
3311 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3312 (shortlisp): Remove.
3313 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3314
3315 2011-05-19 Glenn Morris <rgm@gnu.org>
3316
3317 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3318 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3319 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3320 (lisp): Set the order to that of loadup.el.
3321 (shortlisp): Make it a copy of $lisp.
3322 (SOME_MACHINE_LISP): Remove.
3323 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3324 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3325
3326 2011-05-18 Kenichi Handa <handa@m17n.org>
3327
3328 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3329 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3330 (find_automatic_composition): Mostly rewrite for efficiency.
3331
3332 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3333
3334 * makefile.w32-in: Update dependencies.
3335
3336 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3337
3338 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3339 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3340
3341 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3342
3343 Fix some integer overflow issues, such as string length overflow.
3344
3345 * insdel.c (count_size_as_multibyte): Check for string overflow.
3346
3347 * character.c (lisp_string_width): Check for string overflow.
3348 Use EMACS_INT, not int, for string indexes and lengths; in
3349 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3350 the resulting string length overflows an EMACS_INT; instead,
3351 report a string overflow if no precision given. When checking for
3352 precision exhaustion, use a check that cannot possibly have
3353 integer overflow. (Bug#8675)
3354 * character.h (lisp_string_width): Adjust to new signature.
3355
3356 * alloc.c (string_overflow): New function.
3357 (Fmake_string): Use it. This doesn't change behavior, but saves
3358 a few bytes and will simplify future changes.
3359 * character.c (string_escape_byte8): Likewise.
3360 * lisp.h (string_overflow): New decl.
3361
3362 Fixups, following up to the user-interface timestamp change.
3363 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3364 for UI timestamps, instead of unsigned long.
3365 * msdos.c (mouse_get_pos): Likewise.
3366 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3367 * w32gui.h (Time): Define by including "systime.h" rather than by
3368 declaring it ourselves. (Bug#8664)
3369
3370 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3371 * image.c (clear_image_cache): Likewise.
3372
3373 * term.c (term_mouse_position): Don't assume time_t wraparound.
3374
3375 Be more systematic about user-interface timestamps.
3376 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3377 and sometimes 'EMACS_UINT', to represent these timestamps.
3378 This change causes it to use 'Time' uniformly, as that's what X uses.
3379 This makes the code easier to follow, and makes it easier to catch
3380 integer overflow bugs such as Bug#8664.
3381 * frame.c (Fmouse_position, Fmouse_pixel_position):
3382 Use Time, not unsigned long, for user-interface timestamps.
3383 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3384 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3385 * keyboard.h (last_event_timestamp): Likewise.
3386 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3387 * menu.h (xmenu_show): Likewise.
3388 * term.c (term_mouse_position): Likewise.
3389 * termhooks.h (struct input_event.timestamp): Likewise.
3390 (struct terminal.mouse_position_hook): Likewise.
3391 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3392 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3393 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3394 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3395 what it was before.
3396 * menu.h, termhooks.h: Include "systime.h", for Time.
3397
3398 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3399 Don't assume that the difference between two unsigned long values
3400 can fit into an integer. At this point, we know button_down_time
3401 <= event->timestamp, so the difference must be nonnegative, so
3402 there's no need to cast the result if double-click-time is
3403 nonnegative, as it should be; check that it's nonnegative, just in
3404 case. This bug is triggered when events are more than 2**31 ms
3405 apart (about 25 days). (Bug#8664)
3406
3407 * xselect.c (last_event_timestamp): Remove duplicate decl.
3408 (x_own_selection): Remove needless cast to unsigned long.
3409
3410 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3411 that always fit in int. Use a sentinel instead of a counter, to
3412 avoid a temp and to allay GCC's concerns about possible int overflow.
3413 * frame.h (struct frame): Use int for menu_bar_items_used
3414 instead of EMACS_INT, since it always fits in int.
3415
3416 * menu.c (grow_menu_items): Check for int overflow.
3417
3418 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3419
3420 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3421 Before, the code was not consistent. These values cannot exceed
3422 2**31 - 1 so there's no need to make them unsigned.
3423 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3424 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3425 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3426 as modifiers.
3427 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3428
3429 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3430 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3431 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3432 presumably because the widths might not match.
3433
3434 * window.c (size_window): Avoid needless test at loop start.
3435
3436 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3437
3438 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3439
3440 2011-05-12 Drew Adams <drew.adams@oracle.com>
3441
3442 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3443
3444 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3445
3446 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3447 `width' to `bar_area_x' and `bar_area_width', respectively.
3448 (x_scroll_run): Take account of fringe background extension.
3449
3450 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3451 Rename local vars `left' and `width' to `bar_area_x' and
3452 `bar_area_width', respectively.
3453 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3454 background extension.
3455
3456 2011-05-10 Jim Meyering <meyering@redhat.com>
3457
3458 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3459
3460 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3461
3462 * image.c (Finit_image_library): Return t for built-in image types,
3463 like pbm and xbm. (Bug#8640)
3464
3465 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3466
3467 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3468
3469 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3470
3471 * w32console.c (Fset_screen_color): Doc fix.
3472 (Fget_screen_color): New function.
3473 (syms_of_ntterm): Defsubr it.
3474
3475 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3476 unlink the temporary file if Fcall_process didn't create it in the
3477 first place.
3478 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3479 child process will be redirected to a file specified with `:file'.
3480 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3481 cue to call_process_cleanup not to close that handle.
3482
3483 2011-05-07 Ben Key <bkey76@gmail.com>
3484
3485 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3486 one of two shell specific rules, either bootstrap-temacs-CMD or
3487 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3488 to the previous implementation of the bootstrap-temacs rule.
3489 The bootstrap-temacs-CMD rule is similar to the previous
3490 implementation of the bootstrap-temacs rule except that it
3491 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3492 variable.
3493
3494 These changes, along with some changes to nt/configure.bat,
3495 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3496 earlier fix to add support for --cflags and --ldflags options
3497 that include quotes so that it works whether make uses cmd or
3498 sh as the shell.
3499
3500 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3501
3502 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3503 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3504 is a constant.
3505 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3506 a string. Handle both cases.
3507 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3508 (Fdbus_register_method): Use Qinvalid_function.
3509
3510 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3511
3512 * makefile.w32-in: Update dependencies.
3513 (LISP_H): Add inttypes.h and stdin.h.
3514 (PROCESS_H): Add unistd.h.
3515
3516 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3517
3518 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3519 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3520
3521 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3522
3523 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3524
3525 * term.c (vfatal): Remove stray call to va_end.
3526 It's not needed and the C Standard doesn't allow it here anyway.
3527
3528 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3529 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3530
3531 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3532 bytes.
3533
3534 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3535
3536 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3537
3538 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3539
3540 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3541
3542 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3543
3544 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3545 * charset.c (Fdefine_charset_internal): Don't initialize
3546 charset.code_space[15]. The value was garbage, on hosts with
3547 32-bit int (Bug#8600).
3548
3549 * lread.c (read_integer): Be more consistent with string-to-number.
3550 Use string_to_number to do the actual conversion; this avoids
3551 rounding errors and fixes some other screwups. Without this fix,
3552 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3553 (digit_to_number): Move earlier, for benefit of read_integer.
3554 Return -1 if the digit is out of range for the base, -2 if it is
3555 not a digit in any supported base. (Bug#8602)
3556
3557 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3558
3559 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3560 to match comment at start of function. This also removes a
3561 GCC warning about overflow in a 32+64-bit port.
3562
3563 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3564
3565 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3566 Reported by Stefan Monnier in
3567 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3568 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3569 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3570
3571 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3572 (EMACS_UINTPTR): Likewise, with uintptr_t.
3573
3574 * lisp.h: Prefer 64-bit EMACS_INT if available.
3575 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3576 on 32-bit hosts that have 64-bit int, so that they can access
3577 large files.
3578 However, temporarily disable this change unless the temporary
3579 symbol WIDE_EMACS_INT is defined.
3580
3581 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3582
3583 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3584 This removes an assumption that EMACS_INT and long are the same
3585 width as pointers. The assumption is true for Emacs porting targets
3586 now, but we want to make other targets possible.
3587 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3588 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3589 In the rest of the code, change types of integers that hold casted
3590 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3591 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3592 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3593 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3594 No need to cast type when ORing.
3595 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3596 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3597 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3598 assume EMACS_INT is the same width as char *.
3599 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3600 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3601 Remove no-longer-needed casts.
3602 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3603 (xg_tool_bar_help_callback, xg_make_tool_item):
3604 Use EMACS_INTPTR to hold an integer
3605 that will be cast to void *; this can avoid a GCC warning
3606 if EMACS_INT is not the same width as void *.
3607 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3608 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3609 (current_message_1, set_message_1):
3610 Use a local to convert to proper width without a cast.
3611 * xmenu.c (dialog_selection_callback): Likewise.
3612
3613 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3614 Also, don't assume VALBITS / RAND_BITS is less than 5,
3615 and don't rely on undefined behavior when shifting a 1 left into
3616 the sign bit.
3617 * lisp.h (get_random): Change signature to match.
3618
3619 * lread.c (hash_string): Use size_t, not int, for hash computation.
3620 Normally we prefer signed values; but hashing is special, because
3621 it's better to use unsigned division on hash table sizes so that
3622 the remainder is nonnegative. Also, size_t is the natural width
3623 for hashing into memory. The previous code used 'int', which doesn't
3624 retain enough info to hash well into very large tables.
3625 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3626
3627 * dbusbind.c: Don't possibly lose pointer info when converting.
3628 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3629 Use XPNTR rather than XHASH, so that the high-order bits of
3630 the pointer aren't lost when converting through void *.
3631
3632 * eval.c (Fautoload): Don't double-shift a pointer.
3633
3634 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3635
3636 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3637
3638 * gnutls.c (DEF_GNUTLS_FN):
3639 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3640
3641 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3642
3643 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3644 marker. (Bug#8610)
3645
3646 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3647
3648 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3649 New version that can reserve upto 2GB of heap space.
3650
3651 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3652
3653 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3654
3655 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3656
3657 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3658 `gnutls_certificate_set_x509_key_file'.
3659
3660 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3661
3662 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3663 Update dependencies.
3664
3665 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3666
3667 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3668 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3669 Remove unused parameter `fildes'.
3670 * process.c (read_process_output, send_process): Don't pass it.
3671
3672 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3673
3674 Fix previous change: the library cache is defined in w32.c.
3675 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3676 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3677
3678 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3679
3680 Implement dynamic loading of GnuTLS on Windows.
3681
3682 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3683 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3684 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3685 Declare.
3686
3687 * gnutls.c (Qgnutls_dll): Define.
3688 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3689 (gnutls_*): Declare function pointers.
3690 (init_gnutls_functions): New function to initialize function pointers.
3691 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3692 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3693 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3694 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3695 (emacs_gnutls_write, emacs_gnutls_read)
3696 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3697 (Fgnutls_available_p): New function.
3698 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3699 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3700 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3701
3702 * image.c: Include w32.h.
3703 (Vimage_type_cache): Delete.
3704 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3705 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3706 (w32_delayed_load): Move to w32.c.
3707
3708 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3709
3710 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3711 (w32_delayed_load): Move from image.c. When loading a library, record
3712 its filename in the :loaded-from property of the library id.
3713 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3714 Initialize and staticpro them.
3715 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3716
3717 * process.c: Include lisp.h before w32.h, not after.
3718 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3719 instead of gnutls_record_check_pending.
3720
3721 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3722
3723 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3724
3725 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3726 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3727 as passed in.
3728
3729 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3730
3731 * xterm.c (x_set_frame_alpha): Do not set property on anything
3732 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3733
3734 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3735
3736 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3737
3738 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3739
3740 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3741 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3742 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3743 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3744 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3745 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3746 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3747 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3748 (Qgnutls_bootprop_callbacks_verify): Make static.
3749
3750 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3751
3752 * callproc.c: Indentation fixup.
3753
3754 * sysdep.c (wait_for_termination_1): Make static.
3755 (wait_for_termination, interruptible_wait_for_termination):
3756 Move after wait_for_termination_1.
3757
3758 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3759
3760 * sysdep.c (interruptible_wait_for_termination): New function
3761 which is like wait_for_termination, but allows keyboard
3762 interruptions.
3763
3764 * callproc.c (Fcall_process): Add (:file "file") as an option for
3765 the STDOUT buffer.
3766 (Fcall_process_region): Ditto.
3767
3768 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3769
3770 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3771 rather than `XVECTOR (FOO)->size'.
3772
3773 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3774 inttypes.h, as a gnulib replacement is used if it not available in
3775 system headers.
3776
3777 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3778
3779 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3780 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3781 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3782
3783 * coding.c (coding_alloc_by_realloc): Error out if destination
3784 will grow beyond MOST_POSITIVE_FIXNUM.
3785 (decode_coding_emacs_mule): Abort if there isn't enough place in
3786 charbuf for the composition carryover bytes. Reserve an extra
3787 space for up to 2 characters produced in a loop.
3788 (decode_coding_iso_2022): Abort if there isn't enough place in
3789 charbuf for the composition carryover bytes.
3790
3791 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3792
3793 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3794 aborting when %lld or %lll format is passed.
3795 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3796 %llo or %llx format is passed. (Bug#8545)
3797
3798 * window.c (window_scroll_line_based): Use a marker instead of
3799 simple variables to record original value of point. (Bug#7952)
3800
3801 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3802 produced by %s or %c overflows available buffer space. (Bug#8545)
3803
3804 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3805
3806 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3807 (SIZE_MAX): Move defn after all includes, as they might #define it.
3808
3809 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3810
3811 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3812
3813 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3814
3815 * keyboard.c (Qdelayed_warnings_hook): Define.
3816 (command_loop_1): Run `delayed-warnings-hook'
3817 if Vdelayed_warnings_list is non-nil.
3818 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3819 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3820
3821 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3822
3823 * doprnt.c (doprnt): Don't return value smaller than the buffer
3824 size if the message was truncated. (Bug#8545).
3825
3826 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3827
3828 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3829 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3830
3831 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3832
3833 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3834
3835 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3836
3837 * makefile.w32-in: Update dependencies.
3838
3839 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3840
3841 Improve `doprnt' and its usage. (Bug#8545)
3842 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3843 `format_end'. Remove support for %l as a conversion specifier.
3844 Don't use xrealloc. Improve diagnostics when the %l size modifier
3845 is used. Update the commentary.
3846
3847 * eval.c (verror): Simplify calculation of size_t.
3848
3849 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3850 messages.
3851
3852 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3853
3854 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3855 change.
3856
3857 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3858
3859 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3860 This makes this file independent of the recent pseudovector change.
3861
3862 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3863
3864 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3865
3866 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3867 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3868 Remove unused local.
3869 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3870
3871 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3872 GCC 4.6.0 optimizes based on type-based alias analysis.
3873 For example, if b is of type struct buffer * and v of type struct
3874 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3875 != &v->size, and therefore "v->size = 1; b->size = 2; return
3876 v->size;" must therefore return 1. This assumption is incorrect
3877 for Emacs, since it type-puns struct Lisp_Vector * with many other
3878 types. To fix this problem, this patch adds a new type struct
3879 vectorlike_header that documents the constraints on layout of vectors
3880 and pseudovectors, and helps optimizing compilers not get fooled
3881 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3882 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3883 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3884 the size member.
3885 (XSETPVECTYPE): Rewrite in terms of new macro.
3886 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3887 This is a bit clearer, and further avoids the possibility of
3888 undesirable aliasing.
3889 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3890 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3891 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3892 since Lisp_Subr is a special case (no "next" field).
3893 (ASIZE): Now uses header.size rather than size.
3894 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3895 to avoid the hassle of writing XVECTOR (foo)->header.size.
3896 (struct vectorlike_header): New type.
3897 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3898 object, to help avoid aliasing.
3899 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3900 (SUBRP): Likewise, since Lisp_Subr is a special case.
3901 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3902 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3903 (struct Lisp_Hash_Table): Combine first two members into a single
3904 struct vectorlike_header member. All uses of "size" and "next" members
3905 changed to be "header.size" and "header.next".
3906 * buffer.h (struct buffer): Likewise.
3907 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3908 * frame.h (struct frame): Likewise.
3909 * process.h (struct Lisp_Process): Likewise.
3910 * termhooks.h (struct terminal): Likewise.
3911 * window.c (struct save_window_data, struct saved_window): Likewise.
3912 * window.h (struct window): Likewise.
3913 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3914 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3915 * buffer.c (init_buffer_once): Likewise.
3916 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3917 special case.
3918 * process.c (Fformat_network_address): Use local var for size,
3919 for brevity.
3920
3921 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3922
3923 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3924 * data.c (atof): Remove decl; no longer used or needed.
3925 (digit_to_number): Move to lread.c.
3926 (Fstring_to_number): Use new string_to_number function, to be
3927 consistent with how the Lisp reader treats infinities and NaNs.
3928 Do not assume that floating-point numbers represent EMACS_INT
3929 without losing information; this is not true on most 64-bit hosts.
3930 Avoid double-rounding errors, by insisting on integers when
3931 parsing non-base-10 numbers, as the documentation specifies.
3932 * lisp.h (string_to_number): New decl, replacing ...
3933 (isfloat_string): Remove.
3934 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3935 (read1): Do not accept +. and -. as integers; this
3936 appears to have been a coding error. Similarly, do not accept
3937 strings like +-1e0 as floating point numbers. Do not report
3938 overflow for integer overflows unless the base is not 10 which
3939 means we have no simple and reliable way to continue.
3940 Break out the floating-point parsing into a new
3941 function string_to_number, so that Fstring_to_number parses
3942 floating point numbers consistently with the Lisp reader.
3943 (digit_to_number): Move here from data.c. Make it static inline.
3944 (E_CHAR, EXP_INT): Remove, replacing with ...
3945 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3946 (string_to_number): New function, replacing isfloat_string.
3947 This function checks for valid syntax and produces the resulting
3948 Lisp float number too. Rework it so that string-to-number
3949 no longer mishandles examples like "1.0e+". Use strtoumax,
3950 so that overflow for non-base-10 numbers is reported only when
3951 there's no portable and simple way to convert to floating point.
3952
3953 * textprop.c (set_text_properties_1): Rewrite for clarity,
3954 and to avoid GCC warning about integer overflow.
3955
3956 * intervals.h (struct interval): Use EMACS_INT for members
3957 where EMACS_UINT might cause problems. See
3958 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3959 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3960 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3961 All uses changed.
3962 (offset_intervals): Tell GCC not to worry about length overflow
3963 when negating a negative length.
3964
3965 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3966 (overrun_check_free): Likewise.
3967
3968 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3969 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3970 word size.
3971
3972 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3973 (gnutls_make_error): Rename local to avoid shadowing.
3974 (gnutls_emacs_global_deinit): ifdef out; not used.
3975 (Fgnutls_boot): Use const for pointer to readonly storage.
3976 Comment out unused local. Fix pointer signedness problems.
3977
3978 * lread.c (openp): Don't stuff size_t into an 'int'.
3979 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3980 about possible signed overflow.
3981
3982 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3983 (GDK_KEY_g): Don't define if already defined.
3984 (xg_prepare_tooltip): Avoid pointer signedness problem.
3985 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3986
3987 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3988 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3989
3990 * xfns.c (Fx_window_property): Simplify a bit,
3991 to make a bit faster and to avoid GCC 4.6.0 warning.
3992 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3993
3994 * fns.c (internal_equal): Don't assume size_t fits in int.
3995
3996 * alloc.c (compact_small_strings): Tighten assertion a little.
3997
3998 Replace pEd with more-general pI, and fix some printf arg casts.
3999 * lisp.h (pI): New macro, generalizing old pEd macro to other
4000 conversion specifiers. For example, use "...%"pI"d..." rather
4001 than "...%"pEd"...".
4002 (pEd): Remove. All uses replaced with similar uses of pI.
4003 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4004 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4005 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4006 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4007 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4008 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4009 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4010 64-bit hosts.
4011 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4012 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4013 * print.c (safe_debug_print, print_object): Likewise.
4014 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4015 to int.
4016 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4017 avoiding the 0 flag, which is not portable.
4018 * process.c (Fmake_network_process): Use pI to avoid cast.
4019 * region-cache.c (pp_cache): Likewise.
4020 * xdisp.c (decode_mode_spec): Likewise.
4021 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4022 behavior on 64-bit hosts with printf arg.
4023 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4024 (x_stop_queuing_selection_requests): Likewise.
4025 (x_get_window_property): Don't truncate byte count to an 'int'
4026 when tracing.
4027
4028 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4029 here, since it parses constructs like leading '-' and spaces,
4030 which are not wanted; and it overflows with large numbers.
4031 Instead, simply match F[0-9]+, which is what is wanted anyway.
4032
4033 * alloc.c: Remove unportable assumptions about struct layout.
4034 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4035 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4036 (allocate_vectorlike, make_pure_vector): Use the new macros,
4037 plus offsetof, to remove unportable assumptions about struct layout.
4038 These assumptions hold on all porting targets that I know of, but
4039 they are not guaranteed, they're easy to remove, and removing them
4040 makes further changes easier.
4041
4042 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4043 This doesn't fix a bug but makes the code clearer.
4044 (string_overrun_cookie): Now const. Use initializers that
4045 don't formally overflow signed char, to avoid warnings.
4046 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4047 can cause Emacs to crash when string overrun checking is enabled.
4048 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4049 multiple of sizeof (EMACS_INT); it need not be, if
4050 alignof(EMACS_INT) < sizeof (EMACS_INT).
4051 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4052
4053 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4054
4055 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4056
4057 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4058
4059 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4060 supposed to be handshaking. (Bug#8556)
4061 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4062
4063 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4064
4065 * lisp.h (Qdebug): List symbol.
4066 * eval.c (Qdebug): Restore global linkage.
4067 * keyboard.c (debug-on-event): New variable.
4068 (handle_user_signal): Break into debugger when debug-on-event
4069 matches the current signal symbol.
4070
4071 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4072
4073 * alloc.c (check_sblock, check_string_bytes)
4074 (check_string_free_list): Convert to standard C.
4075
4076 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4077
4078 * w32.c (emacs_gnutls_push): Fix typo.
4079
4080 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4081
4082 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4083 "cast to pointer from integer of different size".
4084
4085 Improve doprnt and its use in verror. (Bug#8545)
4086 * doprnt.c (doprnt): Document the set of format control sequences
4087 supported by the function. Use SAFE_ALLOCA instead of always
4088 using `alloca'.
4089
4090 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4091 is one byte too soon. Don't use xrealloc; instead xfree and
4092 xmalloc anew.
4093
4094 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4095
4096 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4097 callbacks stage.
4098
4099 * gnutls.c: Renamed global_initialized to
4100 gnutls_global_initialized. Added internals for the
4101 :verify-hostname-error, :verify-error, and :verify-flags
4102 parameters of `gnutls-boot' and documented those parameters in the
4103 docstring. Start callback support.
4104 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4105 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4106 on error. Return error code.
4107 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4108 (emacs_gnutls_read): Likewise.
4109 (Fgnutls_boot): Return handshake error code.
4110 (emacs_gnutls_handle_error): New function.
4111 (wsaerror_to_errno): Likewise.
4112
4113 * w32.h (emacs_gnutls_pull): Add prototype.
4114 (emacs_gnutls_push): Likewise.
4115
4116 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4117 (emacs_gnutls_push): Likewise.
4118
4119 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4120
4121 * process.c (wait_reading_process_output): Check if GnuTLS
4122 buffered some data internally if no FDs are set for TLS
4123 connections.
4124
4125 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4126 (LIBS): Link to USER_LIBS.
4127 ($(BLD)/gnutls.$(0)): New target.
4128
4129 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4130
4131 * xdisp.c (handle_single_display_spec): Rename the
4132 display_replaced_before_p argument into display_replaced_p, to
4133 make it consistent with the commentary. Fix typos in the
4134 commentary.
4135
4136 * textprop.c (syms_of_textprop): Remove dead code.
4137 (copy_text_properties): Delete obsolete commentary about an
4138 interface that was deleted long ago. Fix typos in the description
4139 of arguments.
4140
4141 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4142 to changes in oldXMenu/XMenu.h from 2011-04-16.
4143 <menu_help_message, prev_menu_help_message>: Constify.
4144 (IT_menu_make_room): menu->help_text is now `const char **';
4145 adjust.
4146
4147 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4148 to changes in oldXMenu/XMenu.h from 2011-04-16.
4149 (struct XMenu): Declare `help_text' `const char **'.
4150
4151 * xfaces.c <Qunspecified>: Make extern again.
4152
4153 * syntax.c: Include sys/types.h before including regex.h, as
4154 required by Posix.
4155
4156 * doc.c (get_doc_string): Improve the format passed to `error'.
4157
4158 * doprnt.c (doprnt): Improve commentary.
4159
4160 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4161
4162 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4163 them with etags.
4164
4165 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4166 changes in globals.h immediately force recompilation.
4167 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4168 $(CURDIR)/s/ms-w32.h.
4169 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4170
4171 * character.c (Fchar_direction): Function deleted.
4172 (syms_of_character): Don't defsubr it.
4173 <char-direction-table>: Deleted.
4174
4175 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4176
4177 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4178 * doprnt.c: Include limits.h.
4179 (SIZE_MAX): New macro.
4180 (doprnt): Return a size_t value. 2nd arg is now size_t.
4181 Many local variables are now size_t instead of int or unsigned.
4182 Improve overflow protection. Support `l' modifier for integer
4183 conversions. Support %l conversion. Don't assume an EMACS_INT
4184 argument for integer conversions and for %c.
4185
4186 * lisp.h (doprnt): Restore prototype.
4187
4188 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4189 $(SRC)/character.h.
4190
4191 * Makefile.in (base_obj): Add back doprnt.o.
4192
4193 * deps.mk (doprnt.o): Add back prerequisites.
4194 (callint.o): Depend on character.h.
4195
4196 * eval.c (internal_lisp_condition_case): Include the handler
4197 representation in the error message.
4198 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4199 when breaking from the loop.
4200
4201 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4202
4203 * callint.c (Fcall_interactively): When displaying error message
4204 about invalid control letter, pass the character's codepoint, not
4205 a pointer to its multibyte form. Improve display of the character
4206 in octal and display also its hex code.
4207
4208 * character.c (char_string): Use %x to display the (unsigned)
4209 codepoint of an invalid character, to avoid displaying a bogus
4210 negative value.
4211
4212 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4213 `error', not SYMBOL_NAME itself.
4214
4215 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4216 character arguments to `error'.
4217
4218 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4219 to `error' in error message about FINAL_CHAR argument. Make sure
4220 FINAL_CHAR is a character, and use %c when it is passed as
4221 argument to `error'.
4222
4223 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4224
4225 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4226
4227 * w32.c: Include <time.h>.
4228 (sys_localtime): New function.
4229
4230 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4231
4232 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4233
4234 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4235
4236 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4237
4238 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4239 zombies (Bug#8467).
4240
4241 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4242
4243 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4244 gl_state.e_property when gl_state.object is Qt.
4245
4246 * insdel.c (make_gap_larger): Remove limitation of buffer size
4247 to <= INT_MAX.
4248
4249 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4250
4251 * xdisp.c (lookup_glyphless_char_display)
4252 (produce_glyphless_glyph): Handle cons cell entry in
4253 glyphless-char-display.
4254 (Vglyphless_char_display): Document it.
4255
4256 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4257 glyphless-char-display.
4258
4259 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4260
4261 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4262
4263 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4264
4265 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4266 definition for no-X builds.
4267
4268 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4269
4270 Static checks with GCC 4.6.0 and non-default toolkits.
4271
4272 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4273
4274 * process.c (keyboard_bit_set): Define only if SIGIO.
4275 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4276 (send_process): Repair possible setjmp clobbering.
4277
4278 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4279
4280 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4281
4282 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4283
4284 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4285 Define only if needed.
4286
4287 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4288 by pacifying GCC about it. Maybe it's time to retire it?
4289 * xfaces.c (USG, __TIMEVAL__): Likewise.
4290
4291 * dispextern.h (struct redisplay_interface): Rename param
4292 to avoid shadowing.
4293 * termhooks.h (struct terminal): Likewise.
4294 * xterm.c (xembed_send_message): Likewise.
4295
4296 * insdel.c (make_gap_smaller): Define only if
4297 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4298
4299 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4300 it.
4301
4302 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4303 so that we aren't warned about unused symbols.
4304
4305 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4306
4307 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4308
4309 * xfns.c (x_real_positions): Mark locals as initialized.
4310
4311 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4312
4313 * xterm.c: Fix problems found by static analysis with other toolkits.
4314 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4315 (x_dispatch_event): Declare static if USE_GTK, and
4316 define if USE_GTK || USE_X_TOOLKIT.
4317 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4318 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4319 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4320 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4321
4322 * xmenu.c (menu_help_callback): Pointer type fixes.
4323 Use const pointers when pointing at readonly data. Avoid pointer
4324 signedness clashes.
4325 (FALSE): Remove unused macro.
4326 (update_frame_menubar): Remove unused decl.
4327
4328 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4329
4330 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4331 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4332 (single_menu_item): Rename local to avoid shadowing.
4333
4334 * keyboard.c (make_lispy_event): Remove unused local var.
4335
4336 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4337 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4338
4339 * bitmaps: Change bitmaps from unsigned char back to the X11
4340 compatible char. Avoid the old compiler warnings about
4341 out-of-range initializers by using, for example, '\xab' rather
4342 than 0xab.
4343
4344 * xgselect.c (xgselect_initialize): Check vs interface
4345 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4346
4347 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4348
4349 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4350 to read-only memory.
4351
4352 * fns.c (vector): Remove; this old hack is no longer needed.
4353
4354 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4355 Remove unused var.
4356 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4357
4358 * xrdb.c (x_load_resources): Omit unused local.
4359
4360 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4361 (x_window): Rename locals to avoid shadowing.
4362 (USG): Use the kludged USG macro, to pacify gcc.
4363
4364 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4365 (x_term_init): Remove local to avoid shadowing.
4366
4367 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4368
4369 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4370 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4371
4372 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4373
4374 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4375
4376 Fix regex.c, syntax.c and friends for buffers > 2GB.
4377 * syntax.h (struct gl_state_s): Declare character position members
4378 EMACS_INT.
4379
4380 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4381
4382 * textprop.c (verify_interval_modification, interval_of):
4383 Declare arguments EMACS_INT.
4384
4385 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4386 EMACS_INT.
4387
4388 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4389
4390 * indent.c (Fvertical_motion): Local variable it_start is now
4391 EMACS_INT.
4392
4393 * regex.c (re_match, re_match_2, re_match_2_internal)
4394 (bcmp_translate, regcomp, regexec, print_double_string)
4395 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4396 (re_compile_pattern, re_exec): Declare arguments and local
4397 variables `size_t' and `ssize_t' and return values `regoff_t', as
4398 appropriate.
4399 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4400 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4401 <compile_stack_type>: `size' and `avail' are now `size_t'.
4402
4403 * regex.h <regoff_t>: Use ssize_t, not int.
4404 (re_search, re_search_2, re_match, re_match_2): Arguments that
4405 specify buffer/string position and length are now ssize_t and
4406 size_t. Return type is regoff_t.
4407
4408 2011-04-16 Ben Key <bkey76@gmail.com>
4409
4410 * nsfont.m: Fixed bugs in ns_get_family and
4411 ns_descriptor_to_entity that were caused by using free to
4412 deallocate memory blocks that were allocated by xmalloc (via
4413 xstrdup). This caused Emacs to crash when compiled with
4414 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4415 --enable-checking=xmallocoverrun). xfree is now used to
4416 deallocate these memory blocks.
4417
4418 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4419
4420 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4421
4422 emacs_write: Accept and return EMACS_INT for sizes.
4423 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4424 et seq.
4425 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4426 Accept and return EMACS_INT.
4427 (emacs_gnutls_write): Return the number of bytes written on
4428 partial writes.
4429 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4430 (emacs_read, emacs_write): Remove check for negative size, as the
4431 Emacs source code has been audited now.
4432 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4433 (emacs_read, emacs_write): Use it.
4434 * process.c (send_process): Adjust to the new signatures of
4435 emacs_write and emacs_gnutls_write. Do not attempt to store
4436 a byte offset into an 'int'; it might overflow.
4437 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4438
4439 * sound.c: Don't assume sizes fit in 'int'.
4440 (struct sound_device.period_size, alsa_period_size):
4441 Return EMACS_INT, not int.
4442 (struct sound_device.write, vox_write, alsa_write):
4443 Accept EMACS_INT, not int.
4444 (wav_play, au_play): Use EMACS_INT to store sizes and to
4445 record read return values.
4446
4447 2011-04-15 Ben Key <bkey76@gmail.com>
4448
4449 * keyboard.c (Qundefined): Don't declare static since it is used
4450 in nsfns.m.
4451 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4452 static since they are used in nsfont.m.
4453
4454 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4455
4456 * process.c (Qprocessp): Don't declare static.
4457 * lisp.h (Qprocessp): Declare again.
4458
4459 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4460
4461 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4462
4463 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4464
4465 Improve C-level modularity by making more things 'static'.
4466
4467 Don't publish debugger-only interfaces to other modules.
4468 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4469 (verify_bytepos, count_markers): Move decls to the only modules
4470 that need them.
4471 * region-cache.h (pp_cache): Likewise.
4472 * window.h (check_all_windows): Likewise.
4473 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4474
4475 * sysdep.c (croak): Now static, if
4476 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4477 * syssignal.h (croak): Declare only if not static.
4478
4479 * alloc.c (refill_memory_reserve): Now static if
4480 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4481 * lisp.h (refill_memory_reserve): Declare only if not static.
4482
4483 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4484 Define only if USE_LUCID.
4485
4486 * xrdb.c (x_customization_string, x_rm_string): Now static.
4487
4488 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4489 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4490
4491 * xdisp.c (draw_row_with_mouse_face): Now static.
4492 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4493
4494 * window.h (check_all_windows): Mark externally visible.
4495
4496 * window.c (window_deletion_count): Now static.
4497
4498 * undo.c: Make symbols static if they're not exported.
4499 (last_undo_buffer, last_boundary_position, pending_boundary):
4500 Now static.
4501
4502 * textprop.c (interval_insert_behind_hooks): Now static.
4503 (interval_insert_in_front_hooks): Likewise.
4504
4505 * term.c: Make symbols static if they're not exported.
4506 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4507 (max_frame_lines, tty_set_terminal_modes):
4508 (tty_reset_terminal_modes, tty_turn_off_highlight):
4509 (get_tty_terminal): Now static.
4510 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4511 * termhooks.h (term_mouse_moveto): Do not declare if
4512 HAVE_WINDOW_SYSTEM.
4513 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4514 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4515
4516 * sysdep.c: Make symbols static if they're not exported.
4517 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4518 Now static.
4519 (sigprocmask_set, full_mask): Remove; unused.
4520 (wait_debugging): Mark as visible.
4521 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4522 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4523
4524 * syntax.c (syntax_temp): Define only if !__GNUC__.
4525
4526 * sound.c (current_sound_device, current_sound): Now static.
4527
4528 * search.c (searchbufs, searchbuf_head): Now static.
4529
4530 * scroll.c (scroll_cost): Remove; unused.
4531 * dispextern.h (scroll_cost): Remove decl.
4532
4533 * region-cache.h (pp_cache): Mark as externally visible.
4534
4535 * process.c: Make symbols static if they're not exported.
4536 (process_tick, update_tick, create_process, chan_process):
4537 (Vprocess_alist, proc_buffered_char, datagram_access):
4538 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4539 (deactivate_process): Mark defn as static, as well as decl.
4540 * lisp.h (create_process): Remove decl.
4541 * process.h (chan_process, Vprocess_alist): Remove decls.
4542
4543 * print.c: Make symbols static if they're not exported.
4544 (print_depth, new_backquote_output, being_printed, print_buffer):
4545 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4546 (print_interval, print_number_index, initial_stderr_stream):
4547 Now static.
4548 * lisp.h (Fprinc): Remove decl.
4549 (debug_output_compilation_hack): Mark as externally visible.
4550
4551 * sysdep.c (croak): Move decl from here to syssignal.h.
4552 * syssignal.h (croak): Put it here, so the API can be checked when
4553 'croak' is called from dissociate_if_controlling_tty.
4554
4555 * minibuf.c: Make symbols static if they're not exported.
4556 (minibuf_save_list, choose_minibuf_frame): Now static.
4557 * lisp.h (choose_minibuf_frame): Remove decl.
4558
4559 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4560
4561 * lread.c: Make symbols static if they're not exported.
4562 (read_objects, initial_obarray, oblookup_last_bucket_number):
4563 Now static.
4564 (make_symbol): Remove; unused.
4565 * lisp.h (initial_obarray, make_symbol): Remove decls.
4566
4567 * keyboard.c: Make symbols static if they're not exported.
4568 (single_kboard, recent_keys_index, total_keys, recent_keys):
4569 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4570 (this_single_command_key_start, echoing, last_auto_save):
4571 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4572 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4573 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4574 (Vlispy_mouse_stem, double_click_count):
4575 Now static.
4576 (force_auto_save_soon): Define only if SIGDANGER.
4577 (ignore_mouse_drag_p): Now static if
4578 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4579 (print_help): Remove; unused.
4580 (stop_character, last_timer_event): Mark as externally visible.
4581 * keyboard.h (ignore_mouse_drag_p): Declare only if
4582 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4583 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4584 * lisp.h (echoing): Remove decl.
4585 (force_auto_save_soon): Declare only if SIGDANGER.
4586 * xdisp.c (redisplay_window): Simplify code, to make it more
4587 obvious that ignore_mouse_drag_p is not accessed if !defined
4588 USE_GTK && !defined HAVE_NS.
4589
4590 * intervals.c: Make symbols static if they're not exported.
4591 (merge_properties_sticky, merge_interval_right, delete_interval):
4592 Now static.
4593 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4594
4595 * insdel.c: Make symbols static if they're not exported.
4596 However, leave prepare_to_modify_buffer alone. It's never
4597 called from outside this function, but that appears to be a bug.
4598 (combine_after_change_list, combine_after_change_buffer):
4599 (adjust_after_replace, signal_before_change): Now static.
4600 (adjust_after_replace_noundo): Remove; unused.
4601 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4602 (signal_before_change): Remove decls.
4603
4604 * indent.c (val_compute_motion, val_vmotion): Now static.
4605
4606 * image.c: Make symbols static if they're not exported.
4607 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4608 if USE_GTK.
4609 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4610 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4611
4612 * fringe.c (standard_bitmaps): Now static.
4613 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4614
4615 * frame.c: Make symbols static if they're not exported.
4616 (x_report_frame_params, make_terminal_frame): Now static.
4617 (get_frame_param): Now static, unless HAVE_NS.
4618 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4619 (x_get_resource_string): Remove; not used.
4620 * frame.h (make_terminal_frame, x_report_frame_params):
4621 (x_get_resource_string); Remove decls.
4622 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4623 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4624
4625 * font.c, fontset.c: Make symbols static if they're not exported.
4626 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4627 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4628 * font.c (font_close_object): Now static.
4629 * font.h (font_close_object): Remove.
4630 * fontset.c (FONTSET_OBJLIST): Remove.
4631 (free_realized_fontset) #if-0 the body, which does nothing.
4632 (face_suitable_for_char_p): #if-0, as it's never called.
4633 * fontset.h (face_suitable_for_char_p): Remove decl.
4634 * xfaces.c (face_at_string_position):
4635 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4636 since 0 is always ASCII.
4637
4638 * fns.c (weak_hash_tables): Now static.
4639
4640 * fileio.c: Make symbols static if they're not exported.
4641 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4642 (Vwrite_region_annotation_buffers): Now static.
4643
4644 * eval.c: Make symbols static if they're not exported.
4645 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4646 * lisp.h (backtrace_list): Remove decl.
4647
4648 * emacs.c: Make symbols static if they're not exported.
4649 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4650 (fatal_error_code, fatal_error_signal_hook, standard_args):
4651 Now static.
4652 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4653 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4654 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4655 * lisp.h (fatal_error_signal_hook): Remove decl.
4656 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4657
4658 * editfns.c: Move a (normally-unused) function to its only use.
4659 * editfns.c, lisp.h (get_operating_system_release): Remove.
4660 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4661 worth the hassle of breaking this out.
4662
4663 * xterm.c: Make symbols static if they're not exported.
4664 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4665 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4666 (x_destroy_window, x_delete_display):
4667 Now static.
4668 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4669 (x_mouse_leave): Remove; unused.
4670 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4671 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4672 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4673 Remove decls.
4674 (x_mouse_leave): Declare only if WINDOWSNT.
4675 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4676 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4677 USE_X_TOOLKIT.
4678
4679 * ftxfont.c: Make symbols static if they're not exported.
4680 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4681 HAVE_FREETYPE.
4682 * font.h (ftxfont_driver): Likewise.
4683
4684 * xfns.c: Make symbols static if they're not exported.
4685 (x_last_font_name, x_display_info_for_name):
4686 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4687 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4688 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4689 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4690 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4691 (last_show_tip_args): Now static.
4692 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4693 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4694 (x_screen_planes): Remove; unused.
4695 * dispextern.h (x_screen_planes): Remove decl.
4696
4697 * dispnew.c: Make symbols static if they're not exported.
4698 * dispextern.h (redraw_garbaged_frames, scrolling):
4699 (increment_row_positions): Remove.
4700 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4701 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4702 Now static.
4703 (redraw_garbaged_frames): Remove; unused.
4704
4705 * xfaces.c: Make symbols static if they're not exported.
4706 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4707 Remove decls.
4708 * xterm.h (defined_color): Remove decls.
4709 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4710 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4711 (menu_face_changed_default, defined_color, free_realized_face):
4712 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4713 (ascii_face_of_lisp_face): Remove; unused.
4714
4715 * xdisp.c: Make symbols static if they're not exported.
4716 * dispextern.h (scratch_glyph_row, window_box_edges):
4717 (glyph_to_pixel_coords, set_cursor_from_row):
4718 (get_next_display_element, set_iterator_to_next):
4719 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4720 (show_mouse_face): Remove decls
4721 * frame.h (message_buf_print): Likewise.
4722 * lisp.h (pop_message, set_message, check_point_in_composition):
4723 Likewise.
4724 * xterm.h (set_vertical_scroll_bar): Likewise.
4725 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4726 (message_buf_print, scratch_glyph_row, displayed_buffer):
4727 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4728 (get_next_display_element, show_mouse_face, window_box_edges):
4729 (frame_to_window_pixel_xy, check_point_in_composition):
4730 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4731 (glyph_to_pixel_coords): Remove; unused.
4732
4733 * dired.c (file_name_completion): Now static.
4734
4735 * dbusbind.c (xd_in_read_queued_messages): Now static.
4736
4737 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4738 * data.c (circular_list_error): Remove.
4739
4740 * commands.h (last_point_position, last_point_position_buffer):
4741 (last_point_position_window): Remove decls.
4742 * keyboard.c: Make these variables static.
4743
4744 * coding.h (coding, code_convert_region, encode_coding_gap):
4745 Remove decls.
4746 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4747 (iso_code_class, detect_coding, code_convert_region): Now static.
4748 (encode_coding_gap): Remove; unused.
4749
4750 * chartab.c (chartab_chars, chartab_bits): Now static.
4751
4752 * charset.h (charset_iso_8859_1): Remove decl.
4753 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4754 Now static.
4755
4756 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4757 * ccl.c (Vccl_program_table): Now static.
4758 (check_ccl_update): Remove; unused.
4759
4760 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4761 * category.h: ... from here.
4762 * category.c (check_category_table, set_category_set): Now static.
4763
4764 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4765 * lisp.h: Remove these decls.
4766
4767 * buffer.c (buffer_count): Remove unused var.
4768
4769 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4770 so that it's not optimized away.
4771 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4772 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4773 exported only to the debugger.
4774
4775 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4776 * atimer.h (run_all_atimers): Remove; not exported.
4777
4778 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4779 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4780 was inaccessible from Lisp.
4781 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4782 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4783
4784 alloc.c: Import and export fewer symbols, and remove unused items.
4785 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4786 is defined.
4787 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4788 it's not optimized away by whole-program optimization.
4789 (message_enable_multibyte, free_misc): Remove.
4790 (catchlist, handlerlist, mark_backtrace):
4791 Declare only if BYTE_MARK_STACK.
4792 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4793 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4794 (message_enable_multibyte): Remove decl.
4795 (free_misc, interval_free_list, float_block, float_block_index):
4796 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4797 (cons_free_list, last_marked_index):
4798 Now static.
4799 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4800 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4801 (mark_backtrace): Define only if BYTE_MARK_STACK.
4802 * xdisp.c (message_enable_multibyte): Now static.
4803
4804 Declare Lisp_Object Q* variables to be 'static' if not exported.
4805 This makes it easier for human readers (and static analyzers)
4806 to see whether these variables are used from other modules.
4807 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4808 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4809 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4810 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4811 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4812 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4813 * xmenu.c, xselect.c:
4814 Declare Q* vars static if they are not used in other modules.
4815 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4816 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4817 Remove decls of unexported vars.
4818 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4819
4820 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4821
4822 Make Emacs functions such as Fatom 'static' by default.
4823 This makes it easier for human readers (and static analyzers)
4824 to see whether these functions can be called from other modules.
4825 DEFUN now defines a static function. To make the function external
4826 so that it can be used in other C modules, use the new macro DEFUE.
4827 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4828 (Finit_image_library):
4829 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4830 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4831 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4832 Remove decls, since these functions are now static.
4833 (Funintern, Fget_internal_run_time): New decls, since these functions
4834 were already external.
4835
4836 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4837 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4838 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4839 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4840 * keyboard.c, keymap.c, lread.c:
4841 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4842 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4843 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4844 Mark functions with DEFUE instead of DEFUN,
4845 if they are used in other modules.
4846 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4847 decls for now-static functions.
4848 * buffer.h (Fdelete_overlay): Remove decl.
4849 * callproc.c (Fgetenv_internal): Mark as internal.
4850 * composite.c (Fremove_list_of_text_properties): Remove decl.
4851 (Fcomposition_get_gstring): New forward static decl.
4852 * composite.h (Fcomposite_get_gstring): Remove decl.
4853 * dired.c (Ffile_attributes): New forward static decl.
4854 * doc.c (Fdocumntation_property): New forward static decl.
4855 * eval.c (Ffetch_bytecode): New forward static decl.
4856 (Funintern): Remove extern decl; now in .h file where it belongs.
4857 * fileio.c (Fmake_symbolic_link): New forward static decl.
4858 * image.c (Finit_image_library): New forward static decl.
4859 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4860 * intervals.h (Fprevious_property_change):
4861 (Fremove_list_of_text_properties): Remove decls.
4862 * keyboard.c (Fthis_command_keys): Remove decl.
4863 (Fcommand_execute): New forward static decl.
4864 * keymap.c (Flookup_key): New forward static decl.
4865 (Fcopy_keymap): Now static.
4866 * keymap.h (Flookup_key): Remove decl.
4867 * process.c (Fget_process): New forward static decl.
4868 (Fprocess_datagram_address): Mark as internal.
4869 * syntax.c (Fsyntax_table_p): New forward static decl.
4870 (skip_chars): Remove duplicate decl.
4871 * textprop.c (Fprevious_property_change): New forward static decl.
4872 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4873 Now internal.
4874 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4875 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4876
4877 * editfns.c (Fformat): Remove unreachable code.
4878
4879 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4880
4881 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4882 change. (Bug#8496)
4883
4884 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4885
4886 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4887 when at ZV. (Bug#8487)
4888
4889 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4890
4891 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4892 (Bug#8437)
4893 * keyboard.c (parse_tool_bar_item): Likewise.
4894 * sound.c (sound_cleanup, alsa_close): Likewise.
4895 * termcap.c (tgetent): Likewise.
4896 * xfns.c (x_default_font_parameter): Likewise.
4897 * xsettings.c (read_and_apply_settings): Likewise.
4898
4899 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4900 (overrun_check_free): Protoize.
4901
4902 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4903
4904 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4905 since callers should never pass a negative size.
4906 Change the signature to match that of plain 'read' and 'write'; see
4907 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4908 * lisp.h: Update prototypes of emacs_write and emacs_read.
4909
4910 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4911
4912 * xdisp.c (redisplay_window): Don't try to determine the character
4913 position of the scroll margin if the window start point w->startp
4914 is outside the buffer's accessible region. (Bug#8468)
4915
4916 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4917
4918 Fix write-region and its subroutines for buffers > 2GB.
4919 * fileio.c (a_write, e_write): Modify declaration of arguments and
4920 local variables to support buffers larger than 2GB.
4921 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4922
4923 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4924 argument, local variables, and return value.
4925
4926 * lisp.h: Update prototypes of emacs_write and emacs_read.
4927
4928 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4929
4930 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4931
4932 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4933
4934 Fix more problems found by GCC 4.6.0's static checks.
4935
4936 * xdisp.c (vmessage): Use a better test for character truncation.
4937
4938 * charset.c (load_charset_map): <, not <=, for optimization,
4939 and to avoid potential problems with integer overflow.
4940 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4941 * casetab.c (set_identity, shuffle): Likewise.
4942 * editfns.c (Fformat): Likewise.
4943 * syntax.c (skip_chars): Likewise.
4944
4945 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4946 This also lets GCC 4.6.0 generate slightly better loop code.
4947
4948 * callint.c (Fcall_interactively): <, not <=, for optimization.
4949 (Fcall_interactively): Count the number of arguments produced,
4950 not the number of arguments given. This is simpler and lets GCC
4951 4.6.0 generate slightly better code.
4952
4953 * ftfont.c: Distingish more carefully between FcChar8 and char.
4954 The previous code passed unsigned char * to a functions like
4955 strlen and xstrcasecmp that expect char *, which does not
4956 conform to the C standard.
4957 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4958 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4959 char * when the C standard requires it.
4960
4961 * keyboard.c (read_char): Remove unused var.
4962
4963 * eval.c: Port to Windows vsnprintf (Bug#8435).
4964 Include <limits.h>.
4965 (SIZE_MAX): Define if the headers do not.
4966 (verror): Do not give up if vsnprintf returns a negative count.
4967 Instead, grow the buffer. This ports to Windows vsnprintf, which
4968 does not conform to C99. Problem reported by Eli Zaretskii.
4969 Also, simplify the allocation scheme, by avoiding the need for
4970 calling realloc, and removing the ALLOCATED variable.
4971
4972 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4973
4974 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4975 But keep the doprint source code for now, as we might revamp it
4976 and use it again (Bug#8435).
4977 * lisp.h (doprnt): Remove.
4978 * Makefile.in (base_obj): Remove doprnt.o.
4979 * deps.mk (doprnt.o): Remove.
4980
4981 error: Print 32- and 64-bit integers portably (Bug#8435).
4982 Without this change, on typical 64-bit hosts error ("...%d...", N)
4983 was used to print both 32- and 64-bit integers N, which relied on
4984 undefined behavior.
4985 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4986 New macro.
4987 * lisp.h (error, verror): Mark as printf-like functions.
4988 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4989 Report overflow in size calculations when allocating printf buffer.
4990 Do not truncate output string at its first null byte.
4991 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4992 Truncate the output at a character boundary, since vsnprintf does not
4993 do that.
4994 * charset.c (check_iso_charset_parameter): Convert internal
4995 character to string before calling 'error', since %c now has the
4996 printf meaning.
4997 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4998 overflow when computing char to be passed to 'error'. Do not
4999 pass Lisp_Object to 'error'; pass the integer instead.
5000 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5001 formatted with plain %d.
5002
5003 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5004
5005 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5006
5007 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5008
5009 * xterm.c (x_catch_errors): Remove duplicate declaration.
5010
5011 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5012
5013 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5014
5015 2011-04-10 Jim Meyering <meyering@redhat.com>
5016
5017 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5018 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5019 return ssize_t not "int", and use size_t as the buffer length.
5020 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5021 * gnutls.h: Update declarations.
5022 * process.c (read_process_output): Use ssize_t, to match.
5023 (send_process): Likewise.
5024
5025 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5026
5027 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5028
5029 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5030
5031 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5032 Use unsigned char, to match FcChar8 type definition.
5033
5034 * xterm.c (handle_one_xevent):
5035 * xmenu.c (create_and_show_popup_menu):
5036 * xselect.c (x_decline_selection_request)
5037 (x_reply_selection_request): Avoid type-punned deref of X events.
5038
5039 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5040
5041 Fix some uses of `int' instead of EMACS_INT.
5042 * search.c (string_match_1, fast_string_match)
5043 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5044 (scan_buffer, find_next_newline_no_quit)
5045 (find_before_next_newline, search_command, Freplace_match)
5046 (Fmatch_data): Make some `int' variables be EMACS_INT.
5047
5048 * xdisp.c (display_count_lines): 3rd argument and return value now
5049 EMACS_INT. All callers changed.
5050 (pint2hrstr): Last argument is now EMACS_INT.
5051
5052 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5053 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5054 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5055 (decode_coding_utf_16, decode_coding_emacs_mule)
5056 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5057 (decode_coding_ccl, decode_coding_charset)
5058 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5059 (decode_coding_iso_2022, decode_coding_emacs_mule)
5060 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5061 <char_offset, last_offset>: Declare EMACS_INT.
5062 (encode_coding_utf_8, encode_coding_utf_16)
5063 (encode_coding_emacs_mule, encode_invocation_designation)
5064 (encode_designation_at_bol, encode_coding_iso_2022)
5065 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5066 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5067 Declare EMACS_INT.
5068 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5069 (encode_invocation_designation): Last argument P_NCHARS is now
5070 EMACS_INT.
5071 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5072 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5073
5074 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5075 All users changed.
5076
5077 * ccl.c (Fccl_execute_on_string): Declare some variables
5078 EMACS_INT.
5079
5080 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5081
5082 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5083
5084 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5085
5086 * process.c (Fformat_network_address): Doc fix.
5087
5088 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5089
5090 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5091
5092 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5093
5094 * keyboard.c (read_char): Call Lisp function help-form-show,
5095 instead of using internal_with_output_to_temp_buffer.
5096 (Qhelp_form_show): New var.
5097 (syms_of_keyboard): Use DEFSYM macro.
5098
5099 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5100
5101 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5102
5103 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5104
5105 * process.c (Flist_processes): Remove to Lisp.
5106 (list_processes_1): Delete.
5107
5108 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5109
5110 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5111
5112 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5113
5114 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5115
5116 Fix more problems found by GCC 4.6.0's static checks.
5117
5118 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5119
5120 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5121
5122 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5123
5124 * xdisp.c (vmessage): Mark as a printf-like function.
5125
5126 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5127
5128 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5129
5130 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5131 printf-like functions.
5132 (tiff_load): Add casts to remove these marks before passing them
5133 to system-supplied API.
5134
5135 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5136
5137 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5138 This avoids several warnings with gcc -Wstrict-overflow.
5139 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5140 directly, rather than having caller test rule sign. This avoids
5141 some unnecessary tests.
5142 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5143 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5144 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5145
5146 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5147 (xfont_open): Avoid unnecessary tests.
5148
5149 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5150
5151 * composite.h, composite.c (composition_gstring_put_cache):
5152 Use EMACS_INT, not int, for length.
5153
5154 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5155 breaking out part of COMPOSITION_DECODE_RULE.
5156 (COMPOSITION_DECODE_RULE): Use it.
5157 * composite.c (get_composition_id): Remove unused local vars,
5158 by using the new macro.
5159
5160 * textprop.c (set_text_properties_1): Change while to do-while,
5161 since the condition is always true at first.
5162
5163 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5164 (interval_deletion_adjustment): Return unsigned value.
5165 All uses changed.
5166
5167 * process.c (list_processes_1, create_pty, read_process_output):
5168 (exec_sentinel): Remove vars that were set but not used.
5169 (create_pty): Remove unnecessary "volatile"s.
5170 (Fnetwork_interface_info): Avoid possibility of int overflow.
5171 (read_process_output): Do adaptive read buffering even if carryover.
5172 (read_process_output): Simplify nbytes computation if buffered.
5173
5174 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5175
5176 * syntax.c (scan_words): Remove var that was set but not used.
5177 (update_syntax_table): Use unsigned instead of int.
5178
5179 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5180 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5181 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5182
5183 * print.c (print_error_message): Avoid int overflow.
5184
5185 * font.c (font_list_entities): Redo for clarity,
5186 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5187
5188 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5189 (font_score): Avoid potential overflow in diff calculation.
5190
5191 * fns.c (substring_both): Remove var that is set but not used.
5192 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5193
5194 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5195
5196 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5197 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5198 can always succeed if overflow has undefined behavior.
5199
5200 * search.c (boyer_moore, wordify): Remove vars set but not used.
5201 (wordify): Omit three unnecessary tests.
5202
5203 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5204 All callers changed. This avoids the need for an unused var.
5205
5206 * casefiddle.c (casify_region): Remove var that is set but not used.
5207
5208 * dired.c (file_name_completion): Remove var that is set but not used.
5209
5210 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5211
5212 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5213 (Finsert_file_contents): Remove unnecessary code checking fd.
5214
5215 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5216 Check for integer overflow on size calculations.
5217
5218 * buffer.c (Fprevious_overlay_change): Remove var that is set
5219 but not used.
5220
5221 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5222 Remove vars that are set but not used.
5223 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5224 (timer_check_2): Mark vars as initialized.
5225
5226 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5227
5228 * image.c (lookup_image): Remove var that is set but not used.
5229 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5230
5231 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5232 that are set but not used.
5233
5234 * xfns.c (make_invisible_cursor): Don't return garbage
5235 if XCreateBitmapFromData fails (Bug#8410).
5236
5237 * xselect.c (x_get_local_selection, x_handle_property_notify):
5238 Remove vars that are set but not used.
5239
5240 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5241 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5242
5243 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5244 Remove var that is set but not used.
5245 (scroll_bar_windows_size): Now size_t, not int.
5246 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5247 Check for overflow.
5248
5249 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5250 (map_tty_color) [!defined MSDOS]: Likewise.
5251
5252 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5253
5254 * coding.c: Remove vars that are set but not used.
5255 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5256 All callers changed.
5257 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5258 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5259 (decode_coding_charset): Remove vars that are set but not used.
5260
5261 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5262 that is set but not used.
5263
5264 * print.c (print_object): Remove var that is set but not used.
5265
5266 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5267 The gnulib version avoids calling malloc in the usual case,
5268 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5269 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5270 * filelock.c (current_lock_owner): Likewise.
5271 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5272 * sysdep.c: Include allocator.h, careadlinkat.h.
5273 (emacs_no_realloc_allocator): New static constant.
5274 (emacs_readlink): New function.
5275 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5276 ../lib/careadlinkat.h.
5277
5278 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5279
5280 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5281 first non-nil return value).
5282
5283 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5284
5285 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5286 if not defined (Bug#8403).
5287
5288 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5289
5290 * xdisp.c (display_count_lines): Remove parameter `start',
5291 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5292 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5293 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5294 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5295 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5296 and thereabouts. All callers changed.
5297 (get_per_char_metric): Remove parameter `f', unused since
5298 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5299
5300 2011-04-02 Jim Meyering <meyering@redhat.com>
5301
5302 do not dereference NULL upon failed strdup
5303 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5304 (ns_get_family): Likewise.
5305
5306 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5307
5308 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5309
5310 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5311
5312 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5313 later (Bug#8403).
5314
5315 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5316
5317 Add lexical binding.
5318
5319 * window.c (Ftemp_output_buffer_show): New fun.
5320 (Fsave_window_excursion):
5321 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5322
5323 * lread.c (lisp_file_lexically_bound_p): New function.
5324 (Fload): Bind Qlexical_binding.
5325 (readevalloop): Remove `evalfun' arg.
5326 Bind Qinternal_interpreter_environment.
5327 (Feval_buffer): Bind Qlexical_binding.
5328 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5329 Mark as dynamic.
5330 (syms_of_lread): Declare `lexical-binding'.
5331
5332 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5333
5334 * keyboard.c (eval_dyn): New fun.
5335 (menu_item_eval_property): Use it.
5336
5337 * image.c (parse_image_spec): Use Ffunctionp.
5338
5339 * fns.c (concat, mapcar1): Accept byte-code-functions.
5340
5341 * eval.c (Fsetq): Handle lexical vars.
5342 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5343 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5344 (FletX, Flet): Obey lexical binding.
5345 (Fcommandp): Handle closures.
5346 (Feval): New `lexical' arg.
5347 (eval_sub): New function extracted from Feval. Use it almost
5348 everywhere where Feval was used. Look up vars in lexical env.
5349 Handle closures.
5350 (Ffunctionp): Move from subr.el.
5351 (Ffuncall): Handle closures.
5352 (apply_lambda): Remove `eval_flags'.
5353 (funcall_lambda): Handle closures and new byte-code-functions.
5354 (Fspecial_variable_p): New function.
5355 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5356 but without exporting it to Lisp.
5357
5358 * doc.c (Fdocumentation, store_function_docstring):
5359 * data.c (Finteractive_form): Handle closures.
5360
5361 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5362 interactive spec.
5363
5364 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5365 New byte-codes.
5366 (exec_byte_code): New function extracted from Fbyte_code to handle new
5367 calling convention for byte-code-functions. Add new byte-codes.
5368
5369 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5370
5371 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5372
5373 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5374
5375 * xdisp.c (redisplay_internal): Fix prototype.
5376
5377 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5378
5379 * xdisp.c (SCROLL_LIMIT): New macro.
5380 (try_scrolling): Use it when setting scroll_limit.
5381 Limit scrolling to 100 screen lines.
5382 (redisplay_window): Even when falling back on "recentering",
5383 position point in the window according to scroll-conservatively,
5384 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5385
5386 (try_scrolling): When point is above the window, allow searching
5387 as far as scroll_max, or one screenful, to compute vertical
5388 distance from PT to the scroll margin position. This prevents
5389 try_scrolling from unnecessarily failing when
5390 scroll-conservatively is set to a value slightly larger than the
5391 window height. Clean up the case of PT below the margin at bottom
5392 of window: scroll_max can no longer be INT_MAX. When aggressive
5393 scrolling is in use, don't let point enter the opposite scroll
5394 margin as result of the scroll.
5395 (syms_of_xdisp) <scroll-conservatively>: Document the
5396 threshold of 100 lines for never-recentering scrolling.
5397
5398 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5399
5400 * dispextern.h (move_it_by_lines):
5401 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5402 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5403 (message_log_check_duplicate): Remove parameters `prev_bol' and
5404 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5405 (redisplay_internal): Remove parameter `preserve_echo_area',
5406 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5407
5408 * indent.c (Fvertical_motion):
5409 * window.c (window_scroll_pixel_based, Frecenter):
5410 Don't pass `need_y_p' to `move_it_by_lines'.
5411
5412 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5413
5414 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5415 steal a few bits to be more compact.
5416 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5417 Remove unneeded casts.
5418
5419 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5420
5421 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5422
5423 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5424 binding" message (bug#7967).
5425
5426 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5427
5428 Fix more problems found by GCC 4.6.0's static checks.
5429
5430 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5431 Remove unused local var.
5432
5433 * editfns.c (Fmessage_box): Remove unused local var.
5434
5435 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5436 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5437 Omit unused local vars.
5438 * window.c (shrink_windows): Omit unused local var.
5439 * menu.c (digest_single_submenu): Omit unused local var.
5440 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5441 Omit unused local var.
5442
5443 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5444 Don't assume string length fits in int.
5445 (keyremap_step, read_key_sequence): Use size_t for sizes.
5446 (read_key_sequence): Don't check last_real_key_start redundantly.
5447
5448 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5449 instead of alloca (Bug#8344).
5450
5451 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5452 (Fbacktrace_frame): Don't assume nframes fits in int.
5453
5454 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5455
5456 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5457 concerns.
5458
5459 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5460
5461 * cm.c (calccost): Turn while-do into do-while, for clarity.
5462
5463 * keyboard.c (syms_of_keyboard): Use the same style as later
5464 in this function when indexing through an array. This also
5465 works around GCC bug 48267.
5466
5467 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5468
5469 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5470
5471 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5472 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5473
5474 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5475 This avoids undefined behavior on integer overflow, and is a bit
5476 more convenient anyway since it is compared to a size_t variable.
5477
5478 Variadic C functions now count arguments with size_t, not int.
5479 This avoids an unnecessary limitation on 64-bit machines, which
5480 caused (substring ...) to crash on large vectors (Bug#8344).
5481 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5482 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5483 All variadic functions and their callers changed accordingly.
5484 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5485 * data.c (arith_driver, float_arith_driver): Likewise.
5486 * editfns.c (general_insert_function): Likewise.
5487 * eval.c (struct backtrace.nargs, interactive_p)
5488 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5489 (funcall_lambda, mark_backtrace): Likewise.
5490 * fns.c (concat): Likewise.
5491 * frame.c (x_set_frame_parameters): Likewise.
5492 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5493 0 if not found, not -1. All callers changed.
5494
5495 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5496 (stack_copy_size): Now size_t, not int.
5497 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5498
5499 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5500
5501 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5502 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5503 All callers changed.
5504
5505 * lisp.h (multibyte_char_to_unibyte):
5506 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5507 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5508 * character.h (CHAR_TO_BYTE8):
5509 * cmds.c (internal_self_insert):
5510 * editfns.c (general_insert_function):
5511 * keymap.c (push_key_description):
5512 * search.c (Freplace_match):
5513 * xdisp.c (message_dolog, set_message_1): All callers changed.
5514
5515 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5516
5517 * keyboard.c (safe_run_hook_funcall): New function.
5518 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5519 don't set the hook to nil, but remove the offending function instead.
5520 (Qcommand_hook_internal): Remove, unused.
5521 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5522 Vcommand_hook_internal.
5523
5524 * eval.c (enum run_hooks_condition): Remove.
5525 (funcall_nil, funcall_not): New functions.
5526 (run_hook_with_args): Call each function through a `funcall' argument.
5527 Remove `cond' argument, now redundant.
5528 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5529 (Frun_hook_with_args_until_failure): Adjust accordingly.
5530 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5531
5532 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5533
5534 * dispextern.h (string_buffer_position): Remove declaration.
5535
5536 * print.c (strout): Remove parameter `multibyte', unused since
5537 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5538
5539 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5540 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5541 All callers changed.
5542
5543 * w32.c (_wsa_errlist): Use braces for struct initializers.
5544
5545 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5546 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5547 All callers changed.
5548 (string_buffer_position): Likewise. Also, make static (it's never
5549 used outside xdisp.c).
5550 (cursor_row_p): Remove parameter `w', unused since
5551 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5552 (decode_mode_spec): Remove parameter `precision', introduced during
5553 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5554 All callers changed.
5555
5556 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5557
5558 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5559
5560 2011-03-27 Anders Lindgren <andlind@gmail.com>
5561
5562 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5563 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5564 (ns_update_auto_hide_menu_bar): New functions.
5565 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5566 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5567 ns_constrain_all_frames.
5568 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5569 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5570
5571 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5572
5573 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5574
5575 2011-03-27 Glenn Morris <rgm@gnu.org>
5576
5577 * syssignal.h: Replace RETSIGTYPE with void.
5578 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5579 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5580 Replace SIGTYPE with void everywhere.
5581 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5582 * s/template.h (SIGTYPE): Remove commented out definition.
5583
5584 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5585
5586 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5587 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5588
5589 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5590
5591 * w32.c (read_unc_volume): Use parameter `henum', instead of
5592 global variable `wget_enum_handle'.
5593
5594 * keymap.c (describe_vector): Remove parameters `indices' and
5595 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5596 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5597
5598 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5599
5600 * keyboard.c (timer_check): Remove parameter `do_it_now',
5601 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5602 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5603 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5604
5605 * keyboard.c (read_char):
5606 * w32menu.c (w32_menu_display_help):
5607 * xmenu.c (show_help_event, menu_help_callback):
5608 Adjust calls to `show_help_echo'.
5609
5610 * gtkutil.c (xg_maybe_add_timer):
5611 * keyboard.c (readable_events):
5612 * process.c (wait_reading_process_output):
5613 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5614
5615 * insdel.c (adjust_markers_gap_motion):
5616 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5617 (gap_left, gap_right): Don't call it.
5618
5619 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5620
5621 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5622 incurred during fontification.
5623
5624 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5625
5626 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5627 (DEFVAR_PER_BUFFER): Don't pass it.
5628
5629 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5630 (scrolling_window): Don't pass it.
5631
5632 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5633
5634 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5635
5636 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5637 and `suffix'.
5638 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5639 of variables specific to SELinux and computation of `encoded_absname'.
5640
5641 * image.c (XPutPixel): Remove unused variable `height'.
5642
5643 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5644
5645 * unexw32.c (get_section_info): Remove unused variable `section'.
5646
5647 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5648 (system_process_attributes): Remove unused variable `sess'.
5649 (sys_read): Remove unused variable `err'.
5650
5651 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5652 (w32_wnd_proc): Remove unused variable `isdead'.
5653 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5654 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5655 (x_create_tip_frame): Remove unused variable `tem'.
5656
5657 * w32inevt.c (w32_console_read_socket):
5658 Remove unused variable `no_events'.
5659
5660 * w32term.c (x_draw_composite_glyph_string_foreground):
5661 Remove unused variable `width'.
5662
5663 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5664
5665 * w32term.c (x_set_glyph_string_clipping):
5666 Don't pass uninitialized region to CombineRgn.
5667
5668 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5669
5670 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5671 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5672 (Fx_close_connection): Remove unused variable `i'.
5673
5674 * w32font.c (w32font_draw): Return number of glyphs.
5675 (w32font_open_internal): Remove unused variable `i'.
5676 (w32font_driver): Add missing initializer.
5677
5678 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5679 (fill_in_menu): Remove unused variable `items_added'.
5680
5681 * w32term.c (last_mouse_press_frame): Remove static global variable.
5682 (w32_clip_to_row): Remove unused variable `f'.
5683 (x_delete_terminal): Remove unused variable `i'.
5684
5685 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5686 (NOTHING): Remove unused static global variable.
5687 (uniscribe_check_otf): Remove unused variable `table'.
5688 (uniscribe_font_driver): Add missing initializers.
5689
5690 2011-03-23 Julien Danjou <julien@danjou.info>
5691
5692 * term.c (Fsuspend_tty, Fresume_tty):
5693 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5694 * window.c (temp_output_buffer_show):
5695 * insdel.c (signal_before_change):
5696 * frame.c (Fhandle_switch_frame):
5697 * fileio.c (Fdo_auto_save):
5698 * emacs.c (Fkill_emacs):
5699 * editfns.c (save_excursion_restore):
5700 * cmds.c (internal_self_insert):
5701 * callint.c (Fcall_interactively):
5702 * buffer.c (Fkill_all_local_variables):
5703 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5704 Use Frun_hooks.
5705 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5706 unconditionnaly since it does the check itself.
5707
5708 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5709
5710 Fix more problems found by GCC 4.5.2's static checks.
5711
5712 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5713 the first time through the loop, since we know p0 < p1 then.
5714 This also avoids a gcc -Wstrict-overflow warning.
5715
5716 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5717 leading to a memory leak, possible in functions like
5718 load_charset_map_from_file that can allocate an unbounded number
5719 of objects (Bug#8318).
5720
5721 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5722 that could (at least in theory) be that large.
5723
5724 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5725 This is less likely to overflow, and avoids undefined behavior if
5726 overflow does occur. All callers changed. Use strtoul to scan
5727 for the unsigned long integer.
5728 (pint2hrstr): Simplify and tune code slightly.
5729 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5730
5731 * scroll.c (do_scrolling): Work around GCC bug 48228.
5732 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5733
5734 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5735 This also avoids a warning with gcc -Wstrict-overflow.
5736 (validate_x_resource_name): Simplify count usage.
5737 This also avoids a warning with gcc -Wstrict-overflow.
5738
5739 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5740 fail (Bug#8306).
5741
5742 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5743
5744 * process.c (Fmake_network_process): Use socklen_t, not int,
5745 where POSIX says socklen_t is required in portable programs.
5746 This fixes a porting bug on hosts like 64-bit HP-UX, where
5747 socklen_t is wider than int (Bug#8277).
5748 (Fmake_network_process, server_accept_connection):
5749 (wait_reading_process_output, read_process_output):
5750 Likewise.
5751
5752 * process.c: Rename or move locals to avoid shadowing.
5753 (list_processes_1, Fmake_network_process):
5754 (read_process_output_error_handler, exec_sentinel_error_handler):
5755 Rename or move locals.
5756 (Fmake_network_process): Define label "retry_connect" only if needed.
5757 (Fnetwork_interface_info): Fix pointer signedness.
5758 (process_send_signal): Add cast to avoid pointer signedness problem.
5759 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5760 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5761
5762 Make tparam.h and terminfo.c consistent.
5763 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5764 Include tparam.h instead, since it declares them.
5765 * cm.h (PC): Remove extern decl; tparam.h now does this.
5766 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5767 * terminfo.c: Include tparam.h, to check interfaces.
5768 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5769 (tparam): Adjust signature to match interface in tparam.h;
5770 this removes some undefined behavior. Check that outstring and len
5771 are zero, which they always are with Emacs.
5772 * tparam.h (PC, BC, UP): New extern decls.
5773
5774 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5775 (xftfont_open): Rename locals to avoid shadowing.
5776
5777 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5778 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5779 (OTF_TAG_SYM): Omit macro if not needed.
5780 (ftfont_list): Remove unused local.
5781 (get_adstyle_property, ftfont_pattern_entity):
5782 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5783 Rename locals to avoid shadowing.
5784
5785 * xfont.c (xfont_list_family): Mark var as initialized.
5786
5787 * xml.c (make_dom): Now static.
5788
5789 * composite.c (composition_compute_stop_pos): Rename local to
5790 avoid shadowing.
5791 (composition_reseat_it): Remove unused locals.
5792 (find_automatic_composition, composition_adjust_point): Likewise.
5793 (composition_update_it): Mark var as initialized.
5794 (find_automatic_composition): Mark vars as initialized,
5795 with a FIXME (Bug#8290).
5796
5797 character.h: Rename locals to avoid shadowing.
5798 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5799 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5800 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5801 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5802 to avoid shadowing.
5803
5804 * textprop.c (property_change_between_p): Remove; unused.
5805
5806 * intervals.c (interval_start_pos): Now static.
5807
5808 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5809
5810 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5811 Rename locals to avoid shadowing.
5812
5813 * sound.c (wav_play, au_play, Fplay_sound_internal):
5814 Fix pointer signedness.
5815 (alsa_choose_format): Remove unused local var.
5816 (wav_play): Initialize a variable to 0, to prevent undefined
5817 behavior (Bug#8278).
5818
5819 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5820
5821 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5822
5823 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5824 clobbering (Bug#8298).
5825 * sysdep.c (sys_subshell): Likewise.
5826 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5827
5828 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5829 This should get cleaned up, so that child_setup has the
5830 same signature on all platforms.
5831
5832 * callproc.c (call_process_cleanup): Now static.
5833 (relocate_fd): Rename locals to avoid shadowing.
5834
5835 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5836
5837 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5838 not to be necessary, and produces flickering.
5839
5840 2011-03-20 Glenn Morris <rgm@gnu.org>
5841
5842 * config.in: Remove file.
5843
5844 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5845
5846 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5847 are now in src/globals.h.
5848 (syms_of_minibuf): Remove spurious & from previous change.
5849
5850 2011-03-20 Leo <sdl.web@gmail.com>
5851
5852 * minibuf.c (completing-read-function): New variable.
5853 (completing-read-default): Rename from completing-read.
5854 (completing-read): Call completing-read-function.
5855
5856 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5857
5858 * xfaces.c (Fx_load_color_file):
5859 Read color file from absolute filename (bug#8250).
5860
5861 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5862
5863 * makefile.w32-in: Update dependencies.
5864
5865 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5866
5867 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5868
5869 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5870
5871 Fix more problems found by GCC 4.5.2's static checks.
5872
5873 * process.c (make_serial_process_unwind, send_process_trap):
5874 (sigchld_handler): Now static.
5875
5876 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5877 That way, the code declares only the vars that it needs.
5878 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5879 * s/cygwin.h (PTY_ITERATION): Likewise.
5880 * s/darwin.h (PTY_ITERATION): Likewise.
5881 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5882
5883 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5884 * process.c (allocate_pty): Don't declare stb unless it's needed.
5885
5886 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5887 (CONSTANTLIM): Remove; unused.
5888 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5889 Define only if needed.
5890
5891 * unexelf.c (unexec): Name an expression,
5892 to avoid gcc -Wbad-function-cast warning.
5893 Use a different way to cause a compilation error if anyone uses
5894 n rather than nn, a way that does not involve shadowing.
5895 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5896
5897 * deps.mk (unexalpha.o): Remove; unused.
5898
5899 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5900 * unexec.h: New file.
5901 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5902 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5903 Depend on unexec.h.
5904 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5905 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5906 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5907 Change as necessary to match prototype in unexec.h.
5908
5909 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5910 shadowing.
5911 (back_comment, skip_chars): Mark vars as initialized.
5912
5913 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5914 Rename locals to avoid shadowing.
5915
5916 * lread.c (read1): Rewrite so as not to use empty "else".
5917 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5918
5919 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5920
5921 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5922 warning when compiling print.c.
5923
5924 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5925 instead of using an uninitialized var.
5926 (font_sort_entities): Mark var as initialized.
5927
5928 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5929
5930 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5931 pointers to constants.
5932 (font_parse_fcname): Remove unused vars.
5933 (font_delete_unmatched): Now static.
5934 (font_get_spec): Remove; unused.
5935 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5936 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5937 Rename or move locals to avoid shadowing.
5938
5939 * fns.c (require_nesting_list, require_unwind): Now static.
5940 (Ffillarray): Rename locals to avoid shadowing.
5941
5942 * floatfns.c (domain_error2): Define only if needed.
5943 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5944
5945 * alloc.c (mark_backtrace): Move decl from here ...
5946 * lisp.h: ... to here, so that it can be checked.
5947
5948 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5949 (Fdefvar): Rewrite so as not to use empty "else".
5950 (lisp_indirect_variable): Name an expression,
5951 to avoid gcc -Wbad-function-cast warning.
5952 (Fdefvar): Rename locals to avoid shadowing.
5953
5954 * callint.c (quotify_arg, quotify_args): Now static.
5955 (Fcall_interactively): Rename locals to avoid shadowing.
5956 Use const pointer when appropriate.
5957
5958 * lisp.h (get_system_name, get_operating_system_release):
5959 Move decls here, to check interfaces.
5960 * process.c (get_operating_system_release): Move decl to lisp.h.
5961 * xrdb.c (get_system_name): Likewise.
5962 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5963 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5964 some of which prompt warnings from gcc -Wbad-function-cast.
5965 (Fformat_time_string, Fencode_time, Finsert_char):
5966 (Ftranslate_region_internal, Fformat):
5967 Rename or remove local vars to avoid shadowing.
5968 (Ftranslate_region_internal): Mark var as initialized.
5969
5970 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5971 avoid shadowing.
5972
5973 * lisp.h (eassert): Check that the argument compiles, even if
5974 ENABLE_CHECKING is not defined.
5975
5976 * data.c (Findirect_variable): Name an expression, to avoid
5977 gcc -Wbad-function-cast warning.
5978 (default_value, arithcompare, arith_driver, arith_error): Now static.
5979 (store_symval_forwarding): Rename local to avoid shadowing.
5980 (Fmake_variable_buffer_local, Fmake_local_variable):
5981 Mark variables as initialized.
5982 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5983
5984 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5985 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5986 Rename locals to avoid shadowing.
5987 (mark_stack): Move local variables into the #ifdef region where
5988 they're used.
5989 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5990 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5991 needed otherwise.
5992 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5993 (GC_STRING_CHARS): Remove; not used.
5994 (Fmemory_limit): Cast sbrk's returned value to char *.
5995
5996 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5997 avoids undefined behavior in theory.
5998
5999 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6000
6001 Use functions, not macros, for up- and down-casing (Bug#8254).
6002 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6003 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6004 to use the following functions instead of these macros.
6005 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6006 EMACS_INT, since callers assume the returned value fits in int.
6007 (upcase1): Likewise, for UPCASE_TABLE.
6008 (uppercasep, lowercasep, upcase): New static inline functions.
6009 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6010 the race-condition problem in the old DOWNCASE.
6011
6012 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6013 Rename locals to avoid shadowing.
6014 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6015 (regex_compile, re_search_2, re_match_2_internal):
6016 Remove unused local vars.
6017 (FREE_VAR): Rewrite so as not to use empty "else",
6018 which gcc can warn about.
6019 (regex_compile, re_match_2_internal): Mark locals as initialized.
6020 (RETALLOC_IF): Define only if needed.
6021 (WORDCHAR_P): Likewise. This one is never needed, but is used
6022 only in a comment talking about a compiler bug, so put inside
6023 the #if 0 of that comment.
6024 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6025 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6026 Remove; unused.
6027
6028 * search.c (boyer_moore): Rename locals to avoid shadowing.
6029 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6030 (PREV_CHAR_BOUNDARY): Likewise.
6031
6032 * search.c (simple_search): Remove unused var.
6033
6034 * dired.c (compile_pattern): Move decl from here ...
6035 * lisp.h: ... to here, so that it can be checked.
6036 (struct re_registers): New forward decl.
6037
6038 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6039
6040 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6041 All uses changed.
6042 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6043 Rename locals to avoid shadowing.
6044 (Fvertical_motion): Mark locals as initialized.
6045
6046 * casefiddle.c (casify_object, casify_region): Now static.
6047 (casify_region): Mark local as initialized.
6048
6049 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6050
6051 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6052 New macros, so that the caller can use some names other than
6053 gcpro1, gcpro2, etc.
6054 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6055 of the new macros.
6056 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6057 argument, for consistency with GCPRO2_VAR, etc: it is now the
6058 prefix of the variable, not the variable itself. All uses
6059 changed.
6060 * dired.c (directory_files_internal, file_name_completion):
6061 Rename locals to avoid shadowing.
6062
6063 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6064 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6065 dired.c's scmp function, had undefined behavior.
6066 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6067 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6068 * buffer.h: ... to here, because these macros use current_buffer,
6069 and the new implementation with inline functions needs to have
6070 current_buffer in scope now, rather than later when the macros
6071 are used.
6072 (downcase, upcase1): New static inline functions.
6073 (DOWNCASE, UPCASE1): Reimplement using these functions.
6074 This avoids undefined behavior in expressions like
6075 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6076 from race conditions in accessing the global variables
6077 case_temp1 and case_temp2.
6078 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6079 * lisp.h (case_temp1, case_temp2): Remove their decls.
6080 * character.h (ASCII_CHAR_P): Move from here ...
6081 * lisp.h: ... to here, so that the inline functions mentioned
6082 above can use them.
6083
6084 * dired.c (directory_files_internal_unwind): Now static.
6085
6086 * fileio.c (file_name_as_directory, directory_file_name):
6087 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6088 Now static.
6089 (file_name_as_directory): Use const pointers when appropriate.
6090 (Fexpand_file_name): Likewise. In particular, newdir might
6091 point at constant storage, so make it a const pointer.
6092 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6093 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6094 signedness issues.
6095 (Fset_file_times, Finsert_file_contents, auto_save_error):
6096 Rename locals to avoid shadowing.
6097
6098 * minibuf.c (choose_minibuf_frame_1): Now static.
6099 (Ftry_completion, Fall_completions): Rename or remove locals
6100 to avoid shadowing.
6101
6102 * marker.c (bytepos_to_charpos): Remove; unused.
6103
6104 * lisp.h (verify_bytepos, count_markers): New decls,
6105 so that gcc does not warn that these functions aren't declared.
6106
6107 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6108 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6109 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6110 (copy_text): Remove unused local var.
6111
6112 * filelock.c (within_one_second): Now static.
6113 (lock_file_1): Rename local to avoid shadowing.
6114
6115 * buffer.c (fix_overlays_before): Mark locals as initialized.
6116 (fix_start_end_in_overlays): Likewise. This function should be
6117 simplified by using pointers-to-pointers, but that's a different
6118 matter.
6119 (switch_to_buffer_1): Now static.
6120 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6121 (report_overlay_modification): Rename locals to avoid shadowing.
6122
6123 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6124 Fix pointer signedness issue.
6125 (sys_subshell): Mark local as volatile if checking for lint,
6126 to suppress a gcc -Wclobbered warning that does not seem to be right.
6127 (MAXPATHLEN): Define only if needed.
6128
6129 * process.c (serial_open, serial_configure): Move decls from here ...
6130 * systty.h: ... to here, so that they can be checked.
6131
6132 * fns.c (get_random, seed_random): Move extern decls from here ...
6133 * lisp.h: ... to here, so that they can be checked.
6134
6135 * sysdep.c (reset_io): Now static.
6136 (wait_for_termination_signal): Remove; unused.
6137
6138 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6139 (copy_keymap_item, append_key, push_text_char_description):
6140 Now static.
6141 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6142 (DENSE_TABLE_SIZE): Remove; unused.
6143 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6144 (describe_map_tree):
6145 Rename locals to avoid shadowing.
6146
6147 * keyboard.c: Declare functions static if they are not used elsewhere.
6148 (echo_char, echo_dash, cmd_error, top_level_2):
6149 (poll_for_input, handle_async_input): Now static.
6150 (read_char, kbd_buffer_get_event, make_lispy_position):
6151 (make_lispy_event, make_lispy_movement, apply_modifiers):
6152 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6153 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6154 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6155 (read_key_sequence, read_char): Mark locals as initialized.
6156 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6157
6158 * keyboard.h (make_ctrl_char): New decl.
6159 (mark_kboards): Move decl here ...
6160 * alloc.c (mark_kboards): ... from here.
6161
6162 * lisp.h (force_auto_save_soon): New decl.
6163
6164 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6165 (DEFINE_DUMMY_FUNCTION): New macro.
6166 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6167 Use it.
6168 (main): Add casts to avoid warnings
6169 if GCC considers string literals to be constants.
6170
6171 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6172
6173 * dbusbind.c: Pointer signedness fixes.
6174 (xd_signature, xd_append_arg, xd_initialize):
6175 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6176 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6177 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6178 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6179
6180 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6181 if GCC considers string literals to be constants.
6182 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6183
6184 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6185
6186 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6187 (print_preprocess, print_object): New macro to fix last change.
6188
6189 * print.c (print_preprocess): Don't forget font objects.
6190
6191 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6192
6193 * emacs.c (USAGE3): Doc fixes.
6194
6195 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6196
6197 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6198 structure.
6199
6200 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6201
6202 * lisp.h (VWindow_system, Qfile_name_history):
6203 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6204 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6205 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6206
6207 * w32select.c: Don't #include "keyboard.h".
6208 (run_protected): Add extern declaration for waiting_for_input.
6209
6210 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6211 * w32console.c (detect_input_pending, read_input_pending)
6212 (encode_terminal_code):
6213 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6214 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6215 (w32_system_caret_y, Qfile_name_history):
6216 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6217 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6218 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6219 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6220 * w32proc.c (Qlocal, report_file_error):
6221 * w32term.c (Vwindow_system, updating_frame):
6222 * w32uniscribe.c (initialized, uniscribe_font_driver):
6223 Remove unneeded extern declarations.
6224
6225 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6226
6227 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6228
6229 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6230
6231 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6232 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6233 These macros can no longer be used for assignment.
6234
6235 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6236 Assign struct members directly, instead of using BUF_BEGV etc.
6237 (record_buffer_markers, fetch_buffer_markers): New functions for
6238 recording and fetching special buffer markers.
6239 (set_buffer_internal_1, set_buffer_temp): Use them.
6240
6241 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6242
6243 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6244
6245 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6246 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6247
6248 * xdisp.c (hscroll_window_tree):
6249 (reconsider_clip_changes): Use PT instead of BUF_PT.
6250
6251 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6252
6253 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6254 $(EMACS_ROOT)/lib/intprops.h.
6255
6256 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6257
6258 Fix more problems found by GCC 4.5.2's static checks.
6259
6260 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6261 to unsigned char * to avoid compiler diagnostic.
6262 (xg_free_frame_widgets): Make it clear that a local variable is
6263 needed only if USE_GTK_TOOLTIP.
6264 (gdk_window_get_screen): Make it clear that this macro is needed
6265 only if USE_GTK_TOOLTIP.
6266 (int_gtk_range_get_value): New function, which avoids a diagnostic
6267 from gcc -Wbad-function-cast.
6268 (xg_set_toolkit_scroll_bar_thumb): Use it.
6269 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6270 diagnostic from gcc -Wbad-function-cast.
6271 (get_utf8_string, xg_get_file_with_chooser):
6272 Rename locals to avoid shadowing.
6273 (create_dialog): Move locals to avoid shadowing.
6274
6275 * xgselect.c (xg_select): Remove unused var.
6276
6277 * image.c (four_corners_best): Mark locals as initialized.
6278 (gif_load): Initialize transparent_p to zero (Bug#8238).
6279 Mark another local as initialized.
6280 (my_png_error, my_error_exit): Mark with NO_RETURN.
6281
6282 * image.c (clear_image_cache): Now static.
6283 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6284 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6285 (x_edge_detection): Remove unnecessary cast that
6286 gcc -Wbad-function-cast diagnoses.
6287 (gif_load): Fix pointer signedness.
6288 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6289 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6290
6291 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6292
6293 Improve quality of tests for time stamp overflow.
6294 For example, without this patch (encode-time 0 0 0 1 1
6295 1152921504606846976) returns the obviously-bogus value (-948597
6296 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6297 reports time overflow. See
6298 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6299 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6300 * editfns.c: Include limits.h and intprops.h.
6301 (TIME_T_MIN, TIME_T_MAX): New macros.
6302 (time_overflow): Move earlier, to before first use.
6303 (hi_time, lo_time): New functions, for an accurate test for
6304 out-of-range times.
6305 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6306 (Fget_internal_run_time): Don't assume time_t fits in int.
6307 (make_time): Use list2 instead of Fcons twice.
6308 (Fdecode_time): More accurate test for out-of-range times.
6309 (check_tm_member): New function.
6310 (Fencode_time): Use it, to test for out-of-range times.
6311 (lisp_time_argument): Don't rely on undefined left-shift and
6312 right-shift behavior when checking for time stamp overflow.
6313
6314 * editfns.c (time_overflow): New function, refactoring common code.
6315 (Fformat_time_string, Fdecode_time, Fencode_time):
6316 (Fcurrent_time_string): Use it.
6317
6318 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6319 * dired.c (make_time): Move to ...
6320 * editfns.c (make_time): ... here.
6321 * systime.h: Note the move.
6322
6323 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6324
6325 * fringe.c (update_window_fringes): Remove unused variables.
6326
6327 * unexmacosx.c (copy_data_segment): Also copy __got section.
6328 (Bug#8223)
6329
6330 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6331
6332 * termcap.c [MSDOS]: Include "msdos.h".
6333 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6334 Constify `char *' arguments and their references according to
6335 prototypes in tparam.h.
6336
6337 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6338
6339 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6340 Adapt all references accordingly.
6341
6342 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6343
6344 2011-03-11 Tom Tromey <tromey@redhat.com>
6345
6346 * buffer.c (syms_of_buffer): Remove obsolete comment.
6347
6348 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6349
6350 * termhooks.h (encode_terminal_code): Declare prototype.
6351
6352 * msdos.c (encode_terminal_code): Don't declare prototype.
6353
6354 * term.c (encode_terminal_code): Now external again, used by
6355 w32console.c and msdos.c.
6356
6357 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6358 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6359
6360 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6361
6362 Fix some minor problems found by GCC 4.5.2's static checks.
6363
6364 * fringe.c (update_window_fringes): Mark locals as initialized
6365 (Bug#8227).
6366 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6367
6368 * alloc.c (mark_fringe_data): Move decl from here ...
6369 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6370 to check its interface.
6371 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6372
6373 * fontset.c (free_realized_fontset): Now static.
6374 (Fset_fontset_font): Rename local to avoid shadowing.
6375 (fontset_font): Mark local as initialized.
6376 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6377
6378 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6379
6380 * xselect.c (x_disown_buffer_selections): Remove; not used.
6381 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6382 (x_own_selection, Fx_disown_selection_internal): Rename locals
6383 to avoid shadowing.
6384 (x_handle_dnd_message): Remove local to avoid shadowing.
6385
6386 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6387 so that the caller can use some name other than gcpro1.
6388 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6389 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6390 (Fx_backspace_delete_keys_p):
6391 Use them to avoid shadowing, and rename vars to avoid shadowing.
6392 (x_decode_color, x_set_name, x_window): Now static.
6393 (Fx_create_frame): Add braces to silence GCC warning.
6394 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6395 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6396 Remove unused locals.
6397 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6398 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6399 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6400 macros.
6401
6402 * xterm.h (x_mouse_leave): New decl.
6403
6404 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6405 Remove unused functions.
6406 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6407 (x_calc_absolute_position): Now static.
6408 (XTread_socket): Don't define label "out" unless it's used.
6409 Don't declare local "event" unless it's used.
6410 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6411 unless they are used.
6412 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6413 (x_fatal_error_signal): Remove; not used.
6414 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6415 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6416 (x_error_catcher, x_connection_closed, x_error_handler):
6417 (x_error_quitter, xembed_send_message, x_iconify_frame):
6418 (my_log_handler): Rename locals to avoid shadowing.
6419 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6420 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6421
6422 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6423 Rename or move locals to avoid shadowing.
6424 (tty_defined_color, merge_face_heights): Now static.
6425 (free_realized_faces_for_fontset): Remove; not used.
6426 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6427 does not deduce is never used uninitialized.
6428 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6429 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6430
6431 * terminal.c (store_terminal_param): Now static.
6432
6433 * xmenu.c (menu_highlight_callback): Now static.
6434 (set_frame_menubar): Remove unused local.
6435 (xmenu_show): Rename parameter to avoid shadowing.
6436 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6437 since they might point to immutable storage.
6438 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6439 since it's unused otherwise.
6440
6441 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6442 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6443 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6444 avoids a gcc -Wuninitialized diagnostic.
6445 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6446 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6447 does not deduce are never used uninitialized.
6448
6449 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6450
6451 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6452 * window.c (window_loop, size_window):
6453 (run_window_configuration_change_hook, enlarge_window): Likewise.
6454
6455 * window.c (display_buffer): Now static.
6456 (size_window): Mark variables that gcc -Wuninitialized
6457 does not deduce are never used uninitialized.
6458 * window.h (check_all_windows): New decl, to forestall
6459 gcc -Wmissing-prototypes diagnostic.
6460 * dispextern.h (bidi_dump_cached_states): Likewise.
6461
6462 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6463 shadowing.
6464 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6465 Include <limits.h>.
6466 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6467 and to avoid gcc -Wuninitialized warning.
6468 (load_charset_map): Mark variables that gcc -Wuninitialized
6469 does not deduce are never used uninitialized.
6470 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6471
6472 * coding.c (coding_set_source, coding_set_destination):
6473 Use "else { /* comment */ }" rather than "else /* comment */;"
6474 for clarity, and to avoid gcc -Wempty-body warning.
6475 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6476 a block, when the outer 'i' will do.
6477 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6478 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6479 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6480 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6481 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6482 Rename locals to avoid shadowing.
6483 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6484 * coding.c (emacs_mule_char, encode_invocation_designation):
6485 Now static, since they're not used elsewhere.
6486 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6487 (decode_coding_object, encode_coding_object, detect_coding_system):
6488 (decode_coding_emacs_mule): Mark variables that gcc
6489 -Wuninitialized does not deduce are never used uninitialized.
6490 (detect_coding_iso_2022): Initialize a local variable that might
6491 be used uninitialized. Leave a FIXME because it's not clear that
6492 this initialization is needed. (Bug#8211)
6493 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6494 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6495 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6496 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6497 Remove unused macros.
6498
6499 * category.c (hash_get_category_set): Remove unused local var.
6500 (copy_category_table): Now static, since it's not used elsewhere.
6501 * character.c (string_count_byte8): Likewise.
6502
6503 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6504 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6505
6506 * chartab.c (copy_sub_char_table): Now static, since it's not used
6507 elsewhere.
6508 (sub_char_table_ref_and_range, char_table_ref_and_range):
6509 Rename locals to avoid shadowing.
6510 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6511
6512 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6513 (BIDI_BOB): Remove unused macro.
6514
6515 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6516 deduce are never used uninitialized.
6517 * term.c (encode_terminal_code): Likewise.
6518
6519 * term.c (encode_terminal_code): Now static. Remove unused local.
6520
6521 * tparam.h: New file.
6522 * term.c, tparam.h: Include it.
6523 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6524 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6525 Move these decls to tparam.h, and make them agree with what
6526 is actually in tparam.c. The previous trick of using incompatible
6527 decls in different modules does not conform to the C standard.
6528 All callers of tparam changed to use tparam's actual API.
6529 * tparam.c (tparam1, tparam, tgoto):
6530 Use const pointers where appropriate.
6531
6532 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6533 * cm.h (struct cm): Likewise.
6534 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6535 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6536 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6537 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6538 (turn_on_face, init_tty): Likewise.
6539 * termchar.h (struct tty_display_info): Likewise.
6540
6541 * term.c (term_mouse_position): Rename local to avoid shadowing.
6542
6543 * alloc.c (mark_ttys): Move decl from here ...
6544 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6545
6546 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6547
6548 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6549
6550 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6551
6552 * search.c (compile_pattern_1): Remove argument regp, unused since
6553 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6554 (compile_pattern): Don't pass it.
6555
6556 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6557
6558 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6559 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6560 for ! HAVE_GTK3.
6561 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6562
6563 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6564
6565 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6566 gdk_window_get_screen, gdk_window_get_geometry,
6567 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6568 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6569 (xg_get_pixbuf_from_pixmap): New function.
6570 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6571 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6572 Call xg_get_pixbuf_from_pixmap instead of
6573 gdk_pixbuf_get_from_drawable.
6574 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6575 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6576 (xg_check_special_colors): Use GtkStyleContext and its functions
6577 for HAVE_GTK3.
6578 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6579 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6580 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6581 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6582 Call gtk_widget_get_preferred_size.
6583 (xg_frame_resized): gdk_window_get_geometry only takes 5
6584 parameters.
6585 (xg_win_to_widget, xg_event_is_for_menubar):
6586 Call gdk_x11_window_lookup_for_display.
6587 (xg_set_widget_bg): New function.
6588 (delete_cb): New function.
6589 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6590 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6591 (xg_set_background_color): Call xg_set_widget_bg.
6592 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6593 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6594 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6595 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6596 if ! HAVE_GTK3.
6597 (update_frame_tool_bar): Call gtk_widget_hide.
6598 (xg_initialize): Use GDK_KEY_g.
6599
6600 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6601 if ! HAVE_GTK3
6602 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6603
6604 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6605 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6606 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6607
6608 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6609
6610 * w32xfns.c (select_palette): Check success of RealizePalette against
6611 GDI_ERROR, not zero.
6612
6613 See ChangeLog.11 for earlier changes.
6614
6615 ;; Local Variables:
6616 ;; coding: utf-8
6617 ;; End:
6618
6619 Copyright (C) 2011 Free Software Foundation, Inc.
6620
6621 This file is part of GNU Emacs.
6622
6623 GNU Emacs is free software: you can redistribute it and/or modify
6624 it under the terms of the GNU General Public License as published by
6625 the Free Software Foundation, either version 3 of the License, or
6626 (at your option) any later version.
6627
6628 GNU Emacs is distributed in the hope that it will be useful,
6629 but WITHOUT ANY WARRANTY; without even the implied warranty of
6630 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6631 GNU General Public License for more details.
6632
6633 You should have received a copy of the GNU General Public License
6634 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.