Fix bug #9495 with cursor positioning on truncated lines.
[bpt/emacs.git] / src / ChangeLog
1 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2
3 * xdisp.c (try_cursor_movement): Only check for exact match if
4 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5
6 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7
8 Remove unused external symbols.
9 * dispextern.h (calc_pixel_width_or_height): Remove decl.
10 * xdisp.c (calc_pixel_width_or_height): Now static.
11 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
12 * indent.c (check_display_width):
13 * w32term.c: Fix comment to match code.
14 * xterm.c, xterm.h (x_catching_errors): Remove.
15
16 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
17
18 * xselect.c: Use signed conversions more consistently (Bug#9498).
19 (selection_data_to_lisp_data): Assume incoming selection data are
20 signed integers, not unsigned. This is to be consistent with
21 outgoing selection data, which was modified to use signed integers
22 in as part of the fix to Bug#9196 in response to Jan D.'s comment
23 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
24 expects long, not unsigned long.
25
26 2011-09-14 Eli Zaretskii <eliz@gnu.org>
27
28 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
29 computation of loop end. Reported by Johan Bockgård
30 <bojohan@gnu.org>.
31
32 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
33
34 * frame.c (Fother_visible_frames_p): Function deleted.
35
36 2011-09-12 Eli Zaretskii <eliz@gnu.org>
37
38 * indent.c (compute_motion): Process display vector front to back
39 rather than the other way around. (Bug#2496)
40
41 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
42
43 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
44
45 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
46
47 * minibuf.c (Fread_from_minibuffer): Doc fix.
48
49 2011-09-11 Eli Zaretskii <eliz@gnu.org>
50
51 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
52 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
53
54 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
55
56 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
57 value for non-existent files.
58
59 2011-09-11 Eli Zaretskii <eliz@gnu.org>
60
61 * fileio.c (Finsert_file_contents): If the file cannot be opened,
62 set its "size" to -1. This will set the modtime_size field of
63 the corresponding buffer to -1, which is what
64 verify-visited-file-modtime expects for files that do not exist.
65 (Bug#9139)
66
67 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
68
69 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
70 here ...
71 * lisp.h: ... from here. push_key_description is no longer
72 defined in keyboard.c, so its declaration should not be in
73 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
74 logically belongs with push_key_description.
75
76 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
77
78 * buffer.h: Include <sys/types.h> instead of <time.h>.
79 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
80 Problem reported by Herbert J. Skuhra.
81
82 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
83
84 * xml.c (parse_region): Make the parsing work for
85 non-comment-starting XML files again (bug#9144).
86
87 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
88
89 * image.c (gif_load): Fix calculation of bottom and right corner.
90 (Bug#9468)
91
92 2011-09-10 Eli Zaretskii <eliz@gnu.org>
93
94 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
95 redisplay in small windows.
96
97 2011-09-09 Eli Zaretskii <eliz@gnu.org>
98
99 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
100
101 2011-09-08 Martin Rudalics <rudalics@gmx.at>
102
103 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
104 Operate on live windows only.
105
106 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
107
108 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
109
110 2011-09-07 Eli Zaretskii <eliz@gnu.org>
111
112 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
113 only under bidi iteration.
114
115 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
116
117 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
118
119 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
120
121 isnan: Fix porting problem to Solaris 10 with bundled gcc.
122 Without this fix, the command to link temacs failed due to an
123 undefined symbol __builtin_isnan. This is because
124 /usr/include/iso/math_c99.h #defines isnan(x) to
125 __builtin_isnan(x), but the bundled gcc, which identifies itself
126 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
127 a __builtin_isnan.
128 * floatfns.c (isnan): #undef, and then #define to a clone of
129 what's in data.c.
130 (Fisnan): Always define, since it's always available now.
131 (syms_of_floatfns): Always define isnan at the Lisp level.
132
133 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
134
135 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
136
137 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
138
139 * fileio.c: Fix bugs with large file offsets (Bug#9428).
140 The previous code assumed that file offsets (off_t values) fit in
141 EMACS_INT variables, which is not true on typical 32-bit hosts.
142 The code messed up by falsely reporting buffer overflow in cases
143 such as (insert-file-contents "big" nil 1 2) into an empty buffer
144 when "big" contains more than 2**29 bytes, even though this
145 inserts just one byte and does not overflow the buffer.
146 (Finsert_file_contents): Store file offsets as off_t
147 values, not as EMACS_INT values. Check for overflow when
148 converting between EMACS_INT and off_t. When checking for
149 buffer overflow or for overlap, take the offsets into account.
150 Don't use EMACS_INT for small values where int suffices.
151 When checking for overlap, fix a typo: ZV was used where
152 ZV_BYTE was intended.
153 (Fwrite_region): Don't assume off_t fits into 'long'.
154 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
155
156 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
157
158 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
159
160 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
161
162 sprintf-related integer and memory overflow issues (Bug#9412).
163
164 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
165 (esprintf, exprintf, evxprintf): New functions.
166 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
167 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
168 (modify_event_symbol): Do not assume that the length of
169 name_alist_or_stem is safe to alloca and fits in int.
170 (Fexecute_extended_command): Likewise for function name and binding.
171 (Frecursion_depth): Wrap around reliably on integer overflow.
172 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
173 since some callers pass EMACS_INT values.
174 (Fsingle_key_description): Don't crash if symbol name contains more
175 than MAX_ALLOCA bytes.
176 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
177 (get_minibuffer): Arg is now EMACS_INT, not int.
178 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
179 (esprintf, exprintf, evxprintf): New decls.
180 * window.h (command_loop_level, minibuf_level): Reflect API changes.
181
182 * dbusbind.c (signature_cat): New function.
183 (xd_signature, Fdbus_register_signal):
184 Do not overrun buffer; instead, report string overflow.
185
186 * dispnew.c (add_window_display_history): Don't overrun buffer.
187 Truncate instead; this is OK since it's just a log.
188
189 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
190 even if the time zone offset is outlandishly large.
191 Don't mishandle offset == INT_MIN.
192
193 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
194 when creating daemon; the previous buffer-overflow check was incorrect.
195
196 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
197 which has the guts of the old verror function.
198
199 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
200 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
201
202 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
203 (font_unparse_xlfd): Don't blindly alloca long strings.
204 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
205 fits in int, when using sprintf. Use single snprintf to count
206 length of string rather than counting it via multiple sprintfs;
207 that's simpler and more reliable.
208 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
209 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
210 sprintf, in case result does not fit in int.
211
212 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
213 (fontset_from_font): Print it.
214
215 * frame.c (tty_frame_count): Now printmax_t, not int.
216 (make_terminal_frame, set_term_frame_name): Print it.
217 (x_report_frame_params): In X, window IDs are unsigned long,
218 not signed long, so print them as unsigned.
219 (validate_x_resource_name): Check for implausibly long names,
220 and don't assume name length fits in 'int'.
221 (x_get_resource_string): Don't blindly alloca invocation name;
222 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
223 not fit in int.
224
225 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
226 (xg_check_special_colors, xg_set_geometry):
227 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
228
229 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
230 Use esprintf, not sprintf, in case result does not fit in int.
231
232 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
233 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
234 it as a large positive number.
235 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
236 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
237
238 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
239 in case result does not fit in int.
240
241 * print.c (float_to_string): Detect width overflow more reliably.
242 (print_object): Make sprintf buffer a bit bigger, to avoid potential
243 buffer overrun. Don't assume list length fits in 'int'. Treat
244 print length of 0 as 0, not as infinity; to be consistent with other
245 uses of print length in this function. Don't overflow print length
246 index. Don't assume hash table size fits in 'long', or that
247 vectorlike size fits in 'unsigned long'.
248
249 * process.c (make_process): Use printmax_t, not int, to format
250 process-name gensyms.
251
252 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
253
254 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
255 to avoid potential buffer overrun.
256
257 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
258 if X resource line is longer than 512 bytes.
259
260 * xfns.c (x_window): Make sprintf buffer a bit bigger
261 to avoid potential buffer overrun.
262
263 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
264
265 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
266
267 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
268
269 Integer overflow fixes for scrolling, etc.
270 Without these, Emacs silently mishandles large integers sometimes.
271 For example, "C-u 4294967297 M-x recenter" was treated as if
272 it were "C-u 1 M-x recenter" on a typical 64-bit host.
273
274 * xdisp.c (try_window_id): Check Emacs fixnum range before
275 converting to 'int'.
276
277 * window.c (window_scroll_line_based, Frecenter):
278 Check that an Emacs fixnum is in range before assigning it to 'int'.
279 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
280 values converted from Emacs fixnums.
281 (Frecenter): Don't wrap around a line count if it is out of 'int'
282 range; instead, treat it as an extreme value.
283 (Fset_window_configuration, compare_window_configurations):
284 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
285
286 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
287 that can exceed INT_MAX. Check that EMACS_INT value is in range
288 before assigning it to the (possibly-narrower) index.
289 (match_limit): Don't assume that a fixnum can fit in 'int'.
290
291 * print.c (print_object): Use ptrdiff_t, not int, for index that can
292 exceed INT_MAX.
293
294 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
295 (Fvertical_motion): Don't wrap around LINES values that don't fit
296 in 'int'. Instead, treat them as extreme values. This is good
297 enough for windows, which can't have more than INT_MAX lines anyway.
298
299 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
300
301 * Require libxml/parser.h to avoid compilation warning.
302
303 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
304
305 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
306 since this reportedly can destroy thread storage.
307
308 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
309
310 * syntax.c (find_defun_start): Update all cache variables if
311 exiting early (Bug#9401).
312
313 2011-08-30 Eli Zaretskii <eliz@gnu.org>
314
315 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
316
317 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
318 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
319 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
320
321 * term.c (tty_append_glyph): New function.
322 (produce_stretch_glyph): Static function and its prototype deleted.
323
324 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
325 prototypes.
326
327 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
328
329 * image.c (parse_image_spec): Check for nonnegative, not for positive,
330 when checking :margin (Bug#9390).
331 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
332 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
333 so that the name doesn't mislead. All uses changed.
334
335 2011-08-28 Johan Bockgård <bojohan@gnu.org>
336
337 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
338 set_tty_hooks.
339
340 2011-08-27 Eli Zaretskii <eliz@gnu.org>
341
342 * xdisp.c (move_it_to): Don't bail out early when reaching
343 position beyond to_charpos, if we are scanning backwards.
344 (move_it_vertically_backward): When DY == 0, make sure we get to
345 the first character in the line after the newline.
346
347 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
348
349 * ccl.c: Improve and simplify overflow checking (Bug#9196).
350 (ccl_driver): Do not generate an out-of-range pointer.
351 (Fccl_execute_on_string): Remove unnecessary check for
352 integer overflow, noted by Stefan Monnier in
353 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
354 Remove a FIXME that didn't need fixing.
355 Simplify the newly-introduced buffer reallocation code.
356
357 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
358
359 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
360
361 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
362
363 Integer and memory overflow issues (Bug#9196).
364
365 * doc.c (get_doc_string): Rework so that
366 get_doc_string_buffer_size is the actual buffer size, rather than
367 being 1 less than the actual buffer size; this makes xpalloc more
368 convenient.
369
370 * image.c (x_allocate_bitmap_record, cache_image):
371 * xselect.c (Fx_register_dnd_atom):
372 Simplify previous changes by using xpalloc.
373
374 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
375 since either will do and ptrdiff_t is convenient with xpalloc.
376
377 * charset.c (charset_table_size)
378 (struct charset_sort_data.priority): Now ptrdiff_t.
379 (charset_compare): Don't overflow if priorities differ greatly.
380 (Fsort_charsets): Don't assume list length fits in int.
381 Check for size-calculation overflow when allocating sort data.
382 (syms_of_charset): Allocate an initial charset table that is
383 just under 64 KiB, to avoid problems with glibc malloc and mmap.
384
385 * cmds.c (internal_self_insert): Check for size-calculation overflow.
386
387 * composite.h (struct composition.glyph_len): Now int, not unsigned.
388 The actual value is always <= INT_MAX, and leaving it unsigned made
389 overflow checking harder.
390
391 * dispextern.h (struct glyph_matrix.rows_allocated)
392 (struct face_cache.size): Now ptrdiff_t, for convenience in use
393 with xpalloc. The values are still always <= INT_MAX.
394
395 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
396
397 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
398 (SAFE_NALLOCA): New macro.
399
400 * region-cache.c (struct boundary.pos, find_cache_boundary)
401 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
402 (set_cache_region, invalidate_region_cache)
403 (revalidate_region_cache, know_region_cache, region_cache_forward)
404 (region_cache_backward, pp_cache):
405 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
406 so that ptrdiff_t * can be passed to xpalloc.
407 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
408 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
409 (pp_cache): Don't assume cache_len fits in int.
410 * region-cache.h: Adjust extern decls to match.
411
412 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
413 EMACS_INT, since either will do, for xpalloc.
414
415 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
416 (xnmalloc, xnrealloc, xpalloc): New functions.
417
418 * bidi.c (bidi_shelve_header_size): New constant.
419 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
420 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
421
422 * bidi.c (bidi_cache_shrink):
423 * buffer.c (overlays_at, overlays_in, record_overlay_string)
424 (overlay_strings):
425 Don't update size of array until after memory allocation succeeds,
426 because xmalloc/xrealloc may not return.
427 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
428 now that we have proper integer overflow checking.
429 (record_overlay_string, overlay_strings): Catch overflows when
430 calculating size of overlay_str_buf.
431
432 * callproc.c (Fcall_process): Check for size overflow when
433 calculating size of args2.
434 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
435 Normally we prefer signed values, but sticking with ptrdiff_t would
436 require adding more-complicated checks.
437
438 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
439 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
440 Redo buffer-overflow calculations to avoid integer overflow.
441 Add a FIXME comment where memory seems to be over-allocated.
442
443 * character.c (Fstring): Check for size-calculation overflow.
444
445 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
446 unnecessary integer overflow. Check for size overflow.
447 (encode_coding_object): Don't update size until xmalloc succeeds.
448
449 * composite.c (get_composition_id): Check for overflow in glyph
450 length calculations.
451
452 Integer and memory overflow fixes for display code.
453 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
454 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
455 (scrolling_window): Check for overflow in size calculations.
456 (line_draw_cost, realloc_glyph_pool, add_row_entry):
457 Don't assume glyph table len fits in int.
458 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
459 (row_table_size): Now ptrdiff_t, not int.
460 (scrolling_window): Avoid overflow in size calculations.
461 Don't update size until allocation succeeds.
462 * fns.c (concat): Check for overflow in size calculations.
463 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
464 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
465 (NEXT_ALMOST_PRIME_LIMIT): New constant.
466
467 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
468 (get_doc_string): Check for size calculation overflow.
469 Don't update size until allocation succeeds.
470 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
471 EMACS_INT, where ptrdiff_t will do.
472 (Fsubstitute_command_keys): Check for string overflow.
473
474 * editfns.c (set_time_zone_rule): Don't assume environment length
475 fits in int.
476 (message_length): Now ptrdiff_t, not int.
477 (Fmessage_box): Don't update size until allocation succeeds.
478 Don't assume message length fits in int.
479 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
480
481 * emacs.c (main): Do not reallocate argv, since there is a null at
482 the end that can be overwritten, and this way there's no need to
483 worry about size-calculation overflow.
484 (sort_args): Check for size-calculation overflow.
485
486 * eval.c (init_eval_once, grow_specpdl): Don't update size until
487 alloc succeeds.
488 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
489
490 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
491 (x_set_scroll_bar_width, x_figure_window_size):
492 Check for integer overflow.
493 (x_set_alpha): Do not assume XINT fits in int.
494
495 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
496 This is for the members text_lines, text_cols, total_lines, total_cols,
497 where the system imposes an 'int' limit.
498
499 * fringe.c (Fdefine_fringe_bitmap):
500 Don't update size until alloc works.
501
502 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
503 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
504
505 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
506 Check for size-calculation overflow.
507 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
508 do, as we prefer signed integers.
509 (id_to_widget.max_size, id_to_widget.used)
510 (xg_store_widget_in_map, xg_remove_widget_from_map)
511 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
512 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
513 Use and return ptrdiff_t, not int.
514 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
515 * gtkutil.h: Change prototypes to match the above.
516
517 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
518 are duplicate now that they've been promoted to lisp.h.
519 (x_allocate_bitmap_record, x_alloc_image_color)
520 (make_image_cache, cache_image, xpm_load):
521 Don't update size until alloc is done.
522 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
523 (x_detect_edges):
524 Check for size calculation overflow.
525 (ct_colors_allocated_max): New constant.
526 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
527 overflow.
528
529 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
530 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
531 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
532 Use ptrdiff_t, not int, to count maps.
533 (read_char_minibuf_menu_prompt): Check for overflow in size
534 calculations. Don't update size until allocation succeeds. Redo
535 calculations to avoid overflow.
536 * keyboard.h: Change prototypes to match the above.
537
538 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
539 to count maps.
540 (current_minor_maps): Check for size calculation overflow.
541 * keymap.h: Change prototypes to match the above.
542
543 * lread.c (read1, init_obarray): Don't update size until alloc done.
544
545 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
546 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
547
548 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
549 Now ptrdiff_t, not int.
550 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
551 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
552
553 * process.c (Fnetwork_interface_list): Check for overflow
554 in size calculation.
555
556 * region-cache.c (move_cache_gap): Check for size calculation overflow.
557
558 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
559 overflow. Don't bother calling xmalloc when xrealloc will do.
560
561 * search.c (Freplace_match): Check for size calculation overflow.
562 (Fset_match_data): Don't assume list lengths fit in 'int'.
563
564 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
565 for command line length. Do not attempt to address one before the
566 beginning of an array, as that's not portable.
567
568 * term.c (max_frame_lines): Remove; unused.
569 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
570 not int.
571 (encode_terminal_code, calculate_costs): Check for size
572 calculation overflow.
573 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
574 table lengths and related sizes. Don't update size until alloc
575 done. Redo calculations to avoid overflow.
576 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
577
578 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
579 subtracting pointers.
580 (gobble_line): Check for overflow more carefully. Don't update size
581 until alloc done.
582
583 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
584 Don't update size until alloc done.
585 Redo size calculations to avoid overflow.
586 Check for size calculation overflow.
587 (main) [DEBUG]: Fix typo in invoking tparam1.
588
589 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
590 Use ptrdiff_t, not int, for sizes.
591 (store_mode_line_noprop_char): Don't update size until alloc done.
592
593 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
594 Use ptrdiff_t, not int, for sizes.
595 (Finternal_make_lisp_face, cache_face):
596 Check for size calculation overflow.
597 (cache_face): Treat size calculation overflows as if they were
598 memory exhaustion (the usual treatment), rather than aborting.
599
600 * xfns.c (x_encode_text, x_set_name_internal)
601 (Fx_change_window_property): Use ptrdiff_t, not int, to count
602 sizes, since they can exceed INT_MAX in size. Check for size
603 calculation overflow.
604
605 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
606 (xg_select): Check for size calculation overflow.
607 Don't update size until alloc done.
608
609 * xrdb.c (get_environ_db): Don't assume path length fits in int,
610 as sprintf is limited to int lengths.
611
612 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
613 (X_LONG_MIN): New macros.
614 Use them to make the following changes clearer.
615 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
616 This change doesn't affect the value now, but it may help remind
617 future maintainers not to raise the value too much later.
618 (SELECTION_QUANTUM): Remove, replacing with ...
619 (selection_quantum): ... new function, which avoids overflow.
620 All uses changed.
621 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
622 assumption that selection length fits in 'int'.
623 (x_reply_selection_request, x_handle_selection_request)
624 (x_get_window_property, receive_incremental_selection)
625 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
626 (lisp_data_to_selection_data, clean_local_selection_data):
627 Use ptrdiff_t, not int, to record length of selection.
628 (x_reply_selection_request, x_get_window_property)
629 (receive_incremental_selection, x_property_data_to_lisp):
630 Redo calculations to avoid overflow.
631 (x_reply_selection_request): When sending hint, ceiling it at
632 X_LONG_MAX rather than relying on wraparound overflow to send
633 something.
634 (x_get_window_property, receive_incremental_selection)
635 (lisp_data_to_selection_data, x_property_data_to_lisp):
636 Check for size-calculation overflow.
637 (x_get_window_property, receive_incremental_selection)
638 (lisp_data_to_selection_data, Fx_register_dnd_atom):
639 Don't store size until memory allocation succeeds.
640 (x_get_window_property): Plug memory leak on memory exhaustion.
641 Don't double-block input; malloc is safe here. Don't assume 2**34
642 - 4 fits in unsigned long. Add an xassert to check
643 XGetWindowProperty overflow. Be more careful about overflow
644 calculations, and distinguish size from memory overflow better.
645 (receive_incremental_selection): When tracing, don't assume
646 unsigned int is less than INT_MAX.
647 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
648 harmful) conversions of unsigned short to int.
649 (lisp_data_to_selection_data): Don't assume that integers
650 in the range -65535 through -1 fit in an X unsigned short.
651 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
652 result parameters unless successful. Rely on cons_to_unsigned
653 to report problems with elements; the old code wasn't right anyway.
654 (x_check_property_data): Check for int overflow; we cannot use
655 a wider type due to X limits.
656 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
657
658 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
659
660 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
661 (x_term_init): Check for size calculation overflow.
662 (x_color_cells): Don't store size until memory allocation succeeds.
663 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
664 Don't assume alloca size is less than MAX_ALLOCA.
665 (x_term_init): Don't assume length fits in int (sprintf is limited
666 to int size).
667
668 Use ptrdiff_t for composition IDs.
669 * character.c (lisp_string_width):
670 * composite.c (composition_table_size, n_compositions)
671 (get_composition_id, composition_gstring_from_id):
672 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
673 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
674 * window.c (Frecenter):
675 Use ptrdiff_t, not int, for composition IDs.
676 * composite.c (get_composition_id): Check for integer overflow.
677 * composite.h: Adjust prototypes to match the above changes.
678
679 Use ptrdiff_t for hash table indexes.
680 * category.c (hash_get_category_set):
681 * ccl.c (ccl_driver):
682 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
683 * coding.c (coding_system_charset_list, detect_coding_system):
684 * coding.h (struct coding_system.id):
685 * composite.c (get_composition_id, gstring_lookup_cache):
686 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
687 * image.c (xpm_get_color_table_h):
688 * lisp.h (hash_lookup, hash_put):
689 * minibuf.c (Ftest_completion):
690 Use ptrdiff_t for hash table indexes, not int (which is too
691 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
692 32-bit --with-wide-int hosts).
693
694 * charset.c (Fdefine_charset_internal): Check for integer overflow.
695 Add a FIXME comment about memory leaks.
696 (syms_of_charset): Don't assume xmalloc returns.
697
698 Don't assume that stated character widths fit in int.
699 * character.c (Fchar_width, c_string_width, lisp_string_width):
700 * character.h (CHAR_WIDTH):
701 * indent.c (MULTIBYTE_BYTES_WIDTH):
702 Use sanitize_char_width to avoid undefined and/or bad behavior
703 with outlandish widths.
704 * character.h (sanitize_tab_width): Renamed from sanitize_width,
705 now that we have two such functions. All uses changed.
706 (sanitize_char_width): New inline function.
707
708 Don't assume that tab-width fits in int.
709 * character.h (sanitize_width): New inline function.
710 (SANE_TAB_WIDTH): New macro.
711 (ASCII_CHAR_WIDTH): Use it.
712 * indent.c (sane_tab_width): Remove. All uses replaced by
713 SANE_TAB_WIDTH (current_buffer).
714 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
715
716 * fileio.c: Integer overflow issues with file modes.
717 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
718
719 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
720 Remove unreachable code.
721 (read_hex, load_charset_map_from_file): Check for integer overflow.
722
723 * xterm.c: don't go over XClientMessageEvent limit
724 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
725 (x_send_scroll_bar_event): Likewise. Check that the size does not
726 exceed limits imposed by XClientMessageEvent, as well as the usual
727 ptrdiff_t and size_t limits.
728
729 * keyboard.c: Overflow, signedness and related fixes.
730 (make_lispy_movement): Use same integer type in forward decl
731 that is used in the definition.
732 (read_key_sequence, keyremap_step):
733 Change bufsize argument back to int, undoing my 2011-03-30 change.
734 We prefer signed types, and int is wide enough here.
735 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
736 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
737 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
738 length, not size_t. Use ptrdiff_t for index, not int.
739 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
740 possibility of integer overflow.
741
742 Overflow, signedness and related fixes for images.
743
744 * dispextern.h (struct it.stack[0].u.image.image_id)
745 (struct_it.image_id, struct image.id, struct image_cache.size)
746 (struct image_cache.used, struct image_cache.ref_count):
747 * gtkutil.c (update_frame_tool_bar):
748 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
749 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
750 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
751 * nsmenu.m (update_frame_tool_bar):
752 * xdisp.c (calc_pixel_width_or_height):
753 * xfns.c (image_cache_refcount):
754 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
755 on typical 64-bit hosts.
756
757 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
758 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
759 Omit unnecessary casts to int.
760 (parse_image_spec): Check that integers fall into 'int' range
761 when the callers expect that.
762 (image_ascent): Redo ascent calculation to avoid int overflow.
763 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
764 (lookup_image): Remove unnecessary tests.
765 (xbm_image_p): Locals are now of int, not EMACS_INT,
766 since parse_image_check makes sure they fit into int.
767 (png_load, gif_load, svg_load_image):
768 Prefer int to unsigned where either will do.
769 (tiff_handler): New function, combining the cores of the
770 old tiff_error_handler and tiff_warning_handler. This
771 function is rewritten to use vsnprintf and thereby avoid
772 stack buffer overflows. It uses only the features of vsnprintf
773 that are common to both POSIX and native Microsoft.
774 (tiff_error_handler, tiff_warning_handler): Use it.
775 (tiff_load, gif_load, imagemagick_load_image):
776 Don't assume :index value fits in 'int'.
777 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
778 (imagemagick_load_image): Check that crop parameters fit into
779 the integer types that MagickCropImage accepts. Don't assume
780 Vimagemagick_render_type has a nonnegative value. Don't assume
781 size_t fits in 'long'.
782 (gs_load): Use printmax_t to print the widest integers possible.
783 Check for integer overflow when computing image height and width.
784
785 2011-08-26 Eli Zaretskii <eliz@gnu.org>
786
787 * xdisp.c (redisplay_window): Don't force window start if point
788 will be invisible in the resulting window. (Bug#9324)
789
790 2011-08-25 Eli Zaretskii <eliz@gnu.org>
791
792 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
793 the display spec is of the form `(space ...)'.
794 (handle_display_spec): Return the value returned by
795 handle_single_display_spec, not just 1 or zero.
796 (handle_single_display_spec): If the display spec is of the form
797 `(space ...)', and specifies display in the text area, return 2
798 rather than 1.
799 (try_cursor_movement): Check for the need to scroll more
800 accurately, and prefer exact match for point under bidi. Don't
801 advance `row' beyond the last row of the window.
802
803 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
804 into disp_prop; all users changed.
805
806 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
807 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
808 for the text covered by the display property.
809
810 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
811
812 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
813 Change return value to nil.
814 (Frecord_buffer): Delete unused function.
815
816 2011-08-24 Eli Zaretskii <eliz@gnu.org>
817
818 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
819 buffers, return left-to-right.
820 (set_cursor_from_row): Consider candidate row a win if its glyph
821 represents a newline and point is on that newline. Fixes cursor
822 positioning on the newline at EOL of R2L text within L2R
823 paragraph, and vice versa.
824 (try_cursor_movement): Check continued rows, in addition to
825 continuation rows. Fixes unwarranted scroll when point enters a
826 continued line of R2L text within an L2R paragraph, or vice versa.
827 (cursor_row_p): Consider the case of point being equal to
828 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
829 from the end of a short line to the beginning of a continued line
830 of R2L text within L2R paragraph.
831 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
832 composed characters.
833
834 * bidi.c (bidi_check_type): Use xassert.
835 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
836 members.
837
838 2011-08-23 Eli Zaretskii <eliz@gnu.org>
839
840 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
841 a character.
842
843 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
844
845 * nsfont.m (ns_otf_to_script): Fix typo.
846
847 2011-08-22 Kenichi Handa <handa@m17n.org>
848
849 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
850 extra slot even if the purpose is char-code-property-table.
851
852 2011-08-23 Eli Zaretskii <eliz@gnu.org>
853
854 * xdisp.c (redisplay_window): When computing centering_position,
855 account for the height of the header line. (Bug#8874)
856
857 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
858 instead of CHAR_TO_BYTE. Fixes a crash when a completion
859 candidate is selected by the mouse, and that candidate has a
860 composed character under the mouse.
861
862 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
863 coordinates reported by pos-visible-in-window-p for a composed
864 character in column zero.
865
866 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
867
868 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
869
870 2011-08-22 Eli Zaretskii <eliz@gnu.org>
871
872 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
873 consider it a hit if to_charpos is anywhere in the range of the
874 composed buffer positions.
875
876 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
877
878 * image.c (gif_load): Don't assume that each subimage has the same
879 dimensions as the base image. Handle disposal method that is
880 "undefined" by the gif spec (Bug#9335).
881
882 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
883
884 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
885 (Fcondition_case): Document `debug' symbol in error handler.
886
887 2011-08-19 Eli Zaretskii <eliz@gnu.org>
888
889 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
890 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
891 from an Org mode buffer to a Speedbar frame.
892
893 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
894 a composition, take its buffer position from IT->cmp_it.charpos.
895 Fixes cursor positioning at the beginning of a line that begins
896 with a composed character.
897
898 2011-08-18 Eli Zaretskii <eliz@gnu.org>
899
900 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
901 character bidirectional type, use STRONG_L instead. Fixes crashes
902 in a buffer produced by `describe-categories'.
903
904 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
905 members before the level stack, so they would be saved and
906 restored when copying iterator state. Fixes incorrect reordering
907 around TABs covered by display properties.
908
909 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
910
911 * process.c (Fnetwork_interface_list): Correctly determine buffer
912 size.
913
914 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
915
916 * eval.c (internal_condition_case, internal_condition_case_1)
917 (internal_condition_case_2, internal_condition_case_n):
918 Remove unnecessary aborts (Bug#9081).
919
920 2011-08-17 Eli Zaretskii <eliz@gnu.org>
921
922 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
923 has no `load' handler, try opening the file locally. (Bug#9311)
924
925 2011-08-16 Ken Brown <kbrown@cornell.edu>
926
927 * gmalloc.c: Expand comment.
928
929 2011-08-16 Eli Zaretskii <eliz@gnu.org>
930
931 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
932 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
933
934 2011-08-16 Ken Brown <kbrown@cornell.edu>
935
936 Fix memory allocation problems in Cygwin build (Bug#9273).
937
938 * unexcw.c ( __malloc_initialized): Declare external variable.
939 (fixup_executable): Force the dumped emacs to reinitialize malloc.
940
941 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
942 New variables.
943 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
944 dumped emacs.
945 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
946 in the static heap.
947 [CYGWIN] (special_realloc): New function.
948 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
949 requests to realloc storage in the static heap.
950
951 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
952
953 * bidi.c (bidi_initialize): Remove unused local.
954
955 2011-08-15 Eli Zaretskii <eliz@gnu.org>
956
957 * biditype.h: File removed.
958
959 * bidimirror.h: File removed.
960
961 * deps.mk (bidi.o): Remove biditype.h and
962 bidimirror.h.
963
964 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
965 bidimirror.h.
966
967 * dispextern.h: Fix a typo in the comment to bidi_type_t.
968
969 * chartab.c: Improve commentary for the uniprop_table API.
970
971 * bidi.c (bidi_paragraph_init): Support zero value of
972 bidi_ignore_explicit_marks_for_paragraph_level.
973 (bidi_initialize): Use uniprop_table instead of including
974 biditype.h and bidimirror.h.
975
976 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
977 coordinates of the iterator when restoring from ppos_it.
978 (Bug#9296)
979
980 2011-08-14 Kenichi Handa <handa@m17n.org>
981
982 * process.c (create_process): Call setup_process_coding_systems
983 after the pid of the process is set to -1 (Bug#8162).
984
985 2011-08-14 Eli Zaretskii <eliz@gnu.org>
986
987 * xdisp.c (move_it_in_display_line_to): Don't invoke
988 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
989 ppos_it. Fixes vertical cursor motion when line beginning is
990 covered by an image. (Bug#9296)
991
992 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
993
994 * nsterm.h (ns_run_ascript): Declare.
995 (NSAPP_DATA2_RUNASSCRIPT): Define.
996
997 * nsfns.m (as_script, as_result, as_status): New static variables.
998 (ns_run_ascript): New function.
999 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1000 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1001 the event loop. Get status from as_status (Bug#7276).
1002
1003 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1004 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1005 the event loop (Bug#7276).
1006
1007 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1008
1009 * gnutls.c (QCgnutls_bootprop_priority)
1010 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1011 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1012 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1013 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1014 (QCgnutls_bootprop_verify_hostname_error)
1015 (QCgnutls_bootprop_callbacks_verify): Rename from
1016 Qgnutls_bootprop_..., all uses changed.
1017
1018 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1019 uses changed.
1020
1021 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1022
1023 * xfaces.c (Qframe_set_background_mode): Now static.
1024 * dispextern.h (Qframe_set_background_mode): Remove decl.
1025
1026 * process.c (Fnetwork_interface_info): Declare local only if needed.
1027
1028 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1029
1030 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1031 (Fnetwork_interface_list): Allocate in increments of bytes instead
1032 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1033 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1034 sockaddr.
1035 (struct ifflag_def): notrailers is smart on OSX.
1036 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1037 Get hardware address with getifaddrs if available.
1038
1039 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1040
1041 * xdisp.c (iterate_out_of_display_property): xassert that
1042 IT->position is set to within IT->object's boundaries. Break from
1043 the loop as soon as EOB is reached; avoids infloops in redisplay
1044 when IT->position is set up wrongly due to some bug.
1045 Set IT->current to match the bidi iterator unconditionally.
1046 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1047 entry. Force push_it to save on the stack the current
1048 buffer/string position, to be restored by pop_it. Fix flags in
1049 the iterator structure wrt the object coming from a display
1050 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1051 properties. (Bug#9284)
1052
1053 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1054
1055 * fontset.c (fontset_get_font_group): Add proper type checks.
1056 (Bug#9172)
1057
1058 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1059
1060 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1061 and LC_VERSION_MIN_MACOSX.
1062 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1063 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1064
1065 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1066
1067 * xdisp.c (forward_to_next_line_start): Allow to use the
1068 no-display-properties-and-no-overlays under bidi display.
1069 Set disp_pos in the bidi iterator to avoid searches for display
1070 properties and overlays.
1071
1072 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1073
1074 * editfns.c (Fset_time_zone_rule): Document relationship with the
1075 setenv function.
1076
1077 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1078 the font entity extracted from the cache (Bug#8109).
1079
1080 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1081
1082 * composite.c (autocmp_chars): Don't reset point. That is done by
1083 restore_point_unwind (Bug#5984).
1084
1085 2011-08-07 Juri Linkov <juri@jurta.org>
1086
1087 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1088 to show the arg `TIME' instead of `TIMEVAL'.
1089
1090 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1091
1092 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1093 display property strides EOL and includes a newline, as in
1094 longlines-mode. (Bug#9254)
1095 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1096 word-wrap under bidirectional display. (Bug#9224)
1097
1098 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1099 is non-zero, even if the data buffer is NULL. Fixes a crash in
1100 vertical-motion with longlines-mode. (Bug#9254)
1101
1102 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1103
1104 * bidi.c <bidi_cache_total_alloc>: Now static.
1105 (bidi_initialize): Initialize bidi_cache_total_alloc.
1106
1107 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1108 cache. (Bug#9221)
1109
1110 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1111 amount allocated this far in `bidi_cache_total_alloc'.
1112 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1113 non-zero, only free the data buffer without restoring the cache
1114 contents. All callers changed.
1115
1116 * dispextern.h (bidi_unshelve_cache): Update prototype.
1117
1118 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1119 (move_it_in_display_line, move_it_to)
1120 (move_it_vertically_backward, move_it_by_lines): Replace the call
1121 to xfree to an equivalent call to bidi_unshelve_cache.
1122 (move_it_in_display_line_to): Fix logic of returning
1123 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1124
1125 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1126
1127 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1128 came from a string character with a `cursor' property. (Bug#9229)
1129
1130 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1131
1132 * Makefile.in (LIB_PTHREAD): New variable.
1133 (LIBES): Add LIB_PTHREAD (Bug#9216).
1134
1135 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1136 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1137
1138 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1139
1140 * regex.c (re_iswctype): Remove some redundant boolean
1141 conversions.
1142
1143 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1144
1145 * xterm.c (x_find_topmost_parent): New function.
1146 (x_set_frame_alpha): Find topmost parent window with
1147 x_find_topmost_parent and set the property there also (bug#9181).
1148 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1149
1150 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1151
1152 * callproc.c (Fcall_process): Avoid vfork clobbering
1153 the local vars buffer, coding_systems, current_dir.
1154
1155 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1156
1157 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1158
1159 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1160
1161 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1162 so that it is not optimized away.
1163
1164 * xdisp.c (compute_display_string_pos): Remove unused local.
1165
1166 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1167
1168 Fix slow cursor motion and scrolling in large buffers with
1169 selective display, like Org Mode buffers. (Bug#9218)
1170
1171 * dispextern.h (struct bidi_it): New member disp_prop_p.
1172
1173 * xdisp.c: Remove one-slot cache of display string positions.
1174 (compute_display_string_pos): Accept an additional argument
1175 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1176 for a display string or property. If found, set DISP_PROP_P
1177 non-zero.
1178
1179 * bidi.c (bidi_fetch_char): Accept an additional argument
1180 DISP_PROP_P, and pass it to compute_display_string_pos.
1181 Only handle text covered by a display string if DISP_PROP_P is returned
1182 non-zero. All callers of bidi_fetch_char changed.
1183
1184 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1185
1186 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1187
1188 2010-12-03 Don March <don@ohspite.net>
1189
1190 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1191 last character M-[char] is translated to ESC [char] (bug#7541).
1192
1193 2011-08-02 Kenichi Handa <handa@m17n.org>
1194
1195 * lisp.h (uniprop_table): Extern it.
1196
1197 * chartab.c (uniprop_table): Make it non-static.
1198
1199 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1200
1201 * xdisp.c (forward_to_next_line_start): Accept additional argument
1202 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1203 on the newline.
1204 (reseat_at_next_visible_line_start): Use the bidi iterator state
1205 returned by forward_to_next_line_start to restore the state of
1206 it->bidi_it after backing up to previous newline. (Bug#9212)
1207
1208 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1209
1210 * regex.c (re_comp): Protoize.
1211 (re_exec): Fix return type.
1212 (regexec): Fix type of `ret'. (Bug#9203)
1213
1214 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1215
1216 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1217 This is needed if max-image-size is a floating-point number.
1218
1219 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1220
1221 * print.c (print_object): Print empty symbol as ##.
1222
1223 * lread.c (read1): Read ## as empty symbol.
1224
1225 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1226
1227 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1228 setting frame foreground color (Bug#9175).
1229 (x_set_background_color): Likewise.
1230
1231 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1232 contents (Bug#9176).
1233 (EmacsTooltip -init): Remove bezels and add shadows to
1234 tooltip windows.
1235
1236 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1237 or scroll bar (Bug#8470).
1238
1239 * nsfont.m (nsfont_open): Remove assignment to voffset and
1240 unnecessary vars hshink, expand, hd, full_height, min_height.
1241 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1242
1243 * nsterm.h (nsfont_info): Remove voffset field.
1244
1245 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1246
1247 Implement strike-through and overline on NextStep (Bug#8863).
1248
1249 * nsfont.m (nsfont_open): Use underline position provided by font,
1250 instead of hard-coded value of 2.
1251 (nsfont_draw): Call ns_draw_text_decoration instead.
1252
1253 * nsterm.h: Add declaration for ns_draw_text_decoration.
1254
1255 * nsterm.m (ns_draw_text_decoration): New function for drawing
1256 underline, overline, and strike-through.
1257 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1258 ns_draw_text_decoration. Change treatment of cursor drawing to
1259 accomodate underlining, etc.
1260
1261 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1262
1263 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1264 default.
1265
1266 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1267
1268 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1269 Without this fix, if a signal arrives just after memory fills up,
1270 'malloc' might be invoked reentrantly.
1271
1272 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1273 In other words, assume that every image size is allowed, on non-X
1274 hosts. This assumption is probably wrong, but it lets Emacs compile.
1275
1276 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1277
1278 * regex.c (re_iswctype): Convert return values to boolean.
1279
1280 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1281
1282 * xdisp.c (compute_display_string_pos): Don't use cached display
1283 string position if the buffer had its restriction changed.
1284 (Bug#9184)
1285
1286 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1287
1288 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1289
1290 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1291
1292 Integer signedness and overflow and related fixes. (Bug#9079)
1293
1294 * bidi.c: Integer size and overflow fixes.
1295 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1296 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1297 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1298 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1299 (bidi_find_other_level_edge):
1300 Use ptrdiff_t instead of EMACS_INT where either will do.
1301 This works better on 32-bit hosts configured --with-wide-int.
1302 (bidi_cache_ensure_space): Check for size-calculation overflow.
1303 Use % rather than repeated addition, for better worst-case speed.
1304 Don't set bidi_cache_size until after xrealloc returns, because it
1305 might not return.
1306 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1307 (bidi_cache_ensure_space): Also check that the bidi cache size
1308 does not exceed that of the largest Lisp string or buffer. See Eli
1309 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1310
1311 * alloc.c (__malloc_size_t): Remove.
1312 All uses replaced by size_t. See Andreas Schwab's note
1313 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1314
1315 * image.c: Improve checking for integer overflow.
1316 (check_image_size): Assume that f is nonnull, since
1317 it is always nonnull in practice. This is one less thing to
1318 worry about when checking for integer overflow later.
1319 (x_check_image_size): New function, which checks for integer
1320 overflow issues inside X.
1321 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1322 This removes the need for a memory_full check.
1323 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1324 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1325 (xbm_read_bitmap_data): Change locals back to 'int', since
1326 their values must fit in 'int'.
1327 (xpm_load_image, png_load, tiff_load):
1328 Invoke x_create_x_image_and_pixmap earlier,
1329 to avoid much needless work if the image is too large.
1330 (tiff_load): Treat overly large images as if
1331 x_create_x_image_and_pixmap failed, not as malloc failures.
1332 (gs_load): Use x_check_image_size.
1333
1334 * gtkutil.c: Omit integer casts.
1335 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1336 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1337
1338 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1339
1340 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1341 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1342 would wrongly return t on a 64-bit host.
1343
1344 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1345 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1346 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1347 and therefore cause GCC to emit a bogus diagnostic in some cases.
1348
1349 * image.c: Integer signedness and overflow and related fixes.
1350 This is not an exhaustive set of fixes, but it's time to
1351 record what I've got.
1352 (lookup_pixel_color, check_image_size): Remove redundant decls.
1353 (check_image_size): Don't assume that arbitrary EMACS_INT values
1354 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1355 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1356 (tiff_load, imagemagick_load_image):
1357 Check for overflow in size calculations.
1358 (x_create_x_image_and_pixmap): Remove unnecessary test for
1359 xmalloc returning NULL; that can't happen.
1360 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1361 (xpm_color_bucket): Use better integer hashing function.
1362 (xpm_cache_color): Don't possibly over-allocate memory.
1363 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1364 (gif_memory_source):
1365 Use ptrdiff_t, not int or size_t, to record sizes.
1366 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1367 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1368 either works, as we prefer signed integers.
1369 (tiff_read_from_memory, tiff_write_from_memory):
1370 Return tsize_t, not size_t, since that's what the TIFF API wants.
1371 (tiff_read_from_memory): Don't fail simply because the read would
1372 go past EOF; instead, return a short read.
1373 (tiff_load): Omit no-longer-needed casts.
1374 (Fimagemagick_types): Don't assume size fits into 'int'.
1375
1376 Improve hashing quality when configured --with-wide-int.
1377 * fns.c (hash_string): New function, taken from sxhash_string.
1378 Do not discard information about ASCII character case; this
1379 discarding is no longer needed.
1380 (sxhash-string): Use it. Change sig to match it. Caller changed.
1381 * lisp.h: Declare it.
1382 * lread.c (hash_string): Remove, since we now use fns.c's version.
1383 The fns.c version returns a wider integer if --with-wide-int is
1384 specified, so this should help the quality of the hashing a bit.
1385
1386 * emacs.c: Integer overflow minor fix.
1387 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1388 Define only if GNU_LINUX.
1389 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1390
1391 * dispnew.c: Integer signedness and overflow fixes.
1392 Remove unnecessary forward decls, that were a maintenance hassle.
1393 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1394 All uses changed.
1395 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1396 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1397 (prepare_desired_row, line_draw_cost):
1398 Use int, not unsigned, where either works.
1399 (save_current_matrix, restore_current_matrix):
1400 Use ptrdiff_t, not size_t, where either works.
1401 (init_display): Check for overflow more accurately, and without
1402 relying on undefined behavior.
1403
1404 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1405 Remove, replacing with the new symbols in lisp.h. All uses changed.
1406 * fileio.c (make_temp_name):
1407 * filelock.c (lock_file_1, lock_file):
1408 * xdisp.c (message_dolog):
1409 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1410 Use pMd etc. instead.
1411 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1412 replacing the pWIDE etc. symbols removed from editfns.c.
1413
1414 * keyboard.h (num_input_events): Now uintmax_t.
1415 This is (very slightly) less likely to mess up due to wraparound.
1416 All uses changed.
1417
1418 * buffer.c: Integer signedness fixes.
1419 (alloc_buffer_text, enlarge_buffer_text):
1420 Use ptrdiff_t rather than size_t when either will do, as we prefer
1421 signed integers.
1422
1423 * alloc.c: Integer signedness and overflow fixes.
1424 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1425 (__malloc_size_t): Default to size_t, not to int.
1426 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1427 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1428 Prefer ptrdiff_t to size_t when either would do, as we prefer
1429 signed integers.
1430 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1431 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1432 Now const. Initialize with values that are in range even if char
1433 is signed.
1434 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1435 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1436 These functions do the right thing with sizes > 2**32.
1437 (check_depth): Now ptrdiff_t, not int.
1438 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1439 Adjust to new way of storing sizes. Check for size overflow bugs
1440 in rest of code.
1441 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1442 slightly wrong anyway, as it missed one instance of
1443 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1444 (refill_memory_reserve): Omit needless cast to size_t.
1445 (mark_object_loop_halt): Mark as externally visible.
1446
1447 * xselect.c: Integer signedness and overflow fixes.
1448 (Fx_register_dnd_atom, x_handle_dnd_message):
1449 Use ptrdiff_t, not size_t, since we prefer signed.
1450 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1451 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1452 x_dnd_atoms_size and x_dnd_atoms_length.
1453
1454 * doprnt.c: Prefer signed to unsigned when either works.
1455 * eval.c (verror):
1456 * doprnt.c (doprnt):
1457 * lisp.h (doprnt):
1458 * xdisp.c (vmessage):
1459 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1460 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1461 prefer signed arithmetic to avoid comparison confusion.
1462 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1463 but is a bit tricky.
1464
1465 Assume freestanding C89 headers, string.h, stdlib.h.
1466 * data.c, doprnt.c, floatfns.c, print.c:
1467 Include float.h unconditionally.
1468 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1469 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1470 * regex.c: Likewise for stddef.h, string.h.
1471 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1472 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1473 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1474 (STDC_HEADERS): Remove obsolete defines.
1475 * sysdep.c: Include limits.h unconditionally.
1476
1477 Assume support for memcmp, memcpy, memmove, memset.
1478 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1479 * regex.c (memcmp, memcpy):
1480 Remove; we assume C89 now.
1481
1482 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1483 (__malloc_safe_bcopy): Remove; no longer needed.
1484
1485 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1486 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1487 well either way, and we prefer signed to unsigned.
1488
1489 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1490
1491 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1492 closes the connection while we're reading (bug#9182).
1493
1494 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1495
1496 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1497 are specified (Bug#9168).
1498
1499 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1500
1501 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1502 Found by GCC static checking and --with-wide-int on a 32-bit host.
1503
1504 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1505
1506 * xdisp.c (compute_display_string_pos): Fix logic of caching
1507 previous display string position. Initialize cached_prev_pos to
1508 -1. Fixes slow-down at the beginning of a buffer.
1509
1510 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1511
1512 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1513 for attrs[LFACE_FONTSET_INDEX].
1514
1515 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1516
1517 * xml.c (parse_region): Remove unused local
1518 that was recently introduced.
1519
1520 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1521
1522 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1523 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1524
1525 * xdisp.c (move_it_in_display_line_to): Record the best matching
1526 position for TO_CHARPOS while scanning the line, and restore it on
1527 exit if none of the characters scanned was an exact match.
1528 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1529 when exact match is impossible due to invisible text, and the
1530 lines are truncated.
1531
1532 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1533
1534 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1535 for OSX >= 10.7.
1536
1537 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1538
1539 Fix a significant slow-down of cursor motion with C-n, C-p,
1540 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1541 auto-repeat under bidi redisplay in fontified buffers.
1542 * xdisp.c (compute_stop_pos_backwards): New function.
1543 (next_element_from_buffer): Call compute_stop_pos_backwards to
1544 find a suitable prev_stop when we find ourselves before
1545 base_level_stop.
1546 (reseat): Don't look for prev_stop, as that could mean a very long
1547 run.
1548 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1549 <cached_disp_overlay_modiff>: Cache for last found display string
1550 position.
1551 (compute_display_string_pos): Return the cached position if asked
1552 about the same buffer in the same area of character positions, and
1553 the buffer wasn't changed since the time the display string
1554 position was cached.
1555
1556 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1557
1558 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1559 is an integer, which is important for empty lines. (Bug#9149)
1560
1561 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1562
1563 * frame.c (Fmodify_frame_parameters): In tty case, update the
1564 default face if necessary (Bug#4238).
1565
1566 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1567
1568 * editfns.c (Fstring_to_char): No need to explain what a character
1569 is in the docstring (Bug#6576).
1570
1571 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1572
1573 * xml.c (parse_region): Make sure we always return a tree.
1574
1575 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1576
1577 * xml.c (parse_region): If a document contains only comments,
1578 return that, too.
1579
1580 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1581
1582 * xml.c (make_dom): Return comments, too.
1583
1584 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1585
1586 Port to OpenBSD.
1587 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1588 and the surrounding thread.
1589 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1590 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1591 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1592 timer goes off.
1593 * s/openbsd.h (BROKEN_SIGIO): Define.
1594 * unexelf.c (unexec) [__OpenBSD__]:
1595 Don't update the .mdebug section of the Alpha COFF symbol table.
1596
1597 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1598
1599 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1600 (bug#8460).
1601
1602 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1603
1604 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1605 This fixes some race conditions on the permissions of any newly
1606 created file.
1607
1608 * alloc.c (valid_pointer_p): Use pipe, not open.
1609 This fixes some permissions issues when debugging.
1610
1611 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1612 If fchown fails to set both uid and gid, try to set just gid,
1613 as that is sometimes allowed. Adjust the file's mode to eliminate
1614 setuid or setgid bits that are inappropriate if fchown fails.
1615
1616 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1617
1618 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1619 to compare Lisp_Objects.
1620 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1621 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1622 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1623
1624 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1625
1626 * lread.c (read_integer): Unread even EOF character.
1627 (read1): Likewise. Properly record start position of symbol.
1628
1629 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1630 symbol character follows.
1631
1632 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1633
1634 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1635 This works around a problem with the previous change to Fcopy_file.
1636 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1637 and without this change, GCC might complain about discarding
1638 fchown's return value.
1639
1640 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1641
1642 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1643
1644 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1645
1646 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1647
1648 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1649
1650 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1651 it's used from the C level.
1652
1653 * process.c: Use the same condition for POLL_FOR_INPUT in both
1654 keyboard.c and process.c (bug#1858).
1655
1656 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1657
1658 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1659 (Fgnutls_boot): Use it.
1660
1661 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1662
1663 * doc.c (Fsubstitute_command_keys): Revert last change.
1664
1665 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1666
1667 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1668 quotes the next character, and doesn't affect other longer
1669 sequences (bug#8935).
1670
1671 * lread.c (syms_of_lread): Clarify that is isn't only
1672 `eval-buffer' and `eval-defun' that's affected by
1673 `lexical-binding' (bug#8460).
1674
1675 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1676
1677 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1678 bidi redisplay when a line includes both an image and is
1679 truncated.
1680
1681 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1682
1683 Fix minor problems found by static checking.
1684 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1685 (elsz): Now a signed constant, not a size_t var. We prefer signed
1686 types to unsigned, to avoid integer comparison confusion. Without
1687 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1688 "cannot optimize loop, the loop counter may overflow", a symptom
1689 of the confusion.
1690 * indent.c (Fvertical_motion): Mark locals as initialized.
1691 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1692
1693 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1694
1695 * search.c (Fre_search_backward): Mention `case-fold-search' in
1696 all the re_search_* functions (bug#8138).
1697
1698 * keyboard.c (Fopen_dribble_file): Document when the file is
1699 closed (bug#8056).
1700
1701 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1702
1703 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1704 bidi_cache_idx.
1705
1706 Support bidi reordering of display and overlay strings.
1707 * xdisp.c (compute_display_string_pos)
1708 (compute_display_string_end): Accept additional argument STRING.
1709 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1710 (reseat_to_string): Initialize bidi_it->string.s and
1711 bidi_it->string.schars.
1712 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1713 NULL (avoids a crash in bidi_paragraph_init).
1714 Initialize itb.string.lstring.
1715 (init_iterator): Call bidi_init_it only of a valid
1716 buffer position was specified. Initialize paragraph_embedding to
1717 L2R.
1718 (reseat_to_string): Initialize the bidi iterator.
1719 (display_string): If we need to ignore text properties of
1720 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1721 original value of -1 will not work with bidi.)
1722 (compute_display_string_pos): First arg is now struct
1723 `text_pos *'; all callers changed. Support display properties on
1724 Lisp strings.
1725 (compute_display_string_end): Support display properties on Lisp
1726 strings.
1727 (init_iterator, reseat_1, reseat_to_string): Initialize the
1728 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1729 when iterating on a string not from display properties).
1730 (compute_display_string_pos, compute_display_string_end):
1731 Fix calculation of the object to scan. Fixes an error when using
1732 arrow keys.
1733 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1734 base_level_stop; instead, set base_level_stop to BEGV.
1735 Fixes crashes in vertical-motion.
1736 (next_element_from_buffer): Improve commentary for when
1737 the iterator is before prev_stop.
1738 (init_iterator): Initialize bidi_p from the default value of
1739 bidi-display-reordering, not from buffer-local value. Use the
1740 buffer-local value only if initializing for buffer iteration.
1741 (handle_invisible_prop): Support invisible properties on strings
1742 that are being bidi-reordered.
1743 (set_iterator_to_next): Support bidi reordering of C strings and
1744 Lisp strings.
1745 (next_element_from_string): Support bidi reordering of Lisp
1746 strings.
1747 (handle_stop_backwards): Support Lisp strings as well.
1748 (display_string): Support display of R2L glyph rows.
1749 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1750 (init_iterator): Don't initialize it->bidi_p for strings
1751 here.
1752 (reseat_to_string): Initialize it->bidi_p for strings here.
1753 (next_element_from_string, next_element_from_c_string)
1754 (next_element_from_buffer): Add xassert's for correspondence
1755 between IT's object being iterated and it->bidi_it.string
1756 structure.
1757 (face_before_or_after_it_pos): Support bidi iteration.
1758 (next_element_from_c_string): Handle the case of the first string
1759 character that is not the first one in the visual order.
1760 (get_visually_first_element): New function, refactored from common
1761 parts of next_element_from_buffer, next_element_from_string, and
1762 next_element_from_c_string.
1763 (tool_bar_lines_needed, redisplay_tool_bar)
1764 (display_menu_bar): Force left-to-right direction. Add a FIXME
1765 comment for making that be controlled by a user option.
1766 (push_it, pop_it): Save and restore the state of the
1767 bidi iterator. Save and restore the bidi_p flag.
1768 (pop_it): Iterate out of display property for string iteration as
1769 well.
1770 (iterate_out_of_display_property): Support iteration over strings.
1771 (handle_single_display_spec): Set up it->bidi_it for iteration
1772 over a display string, and call bidi_init_it.
1773 (handle_single_display_spec, next_overlay_string)
1774 (get_overlay_strings_1, push_display_prop): Set up the bidi
1775 iterator for displaying display or overlay strings.
1776 (forward_to_next_line_start): Don't use the shortcut if
1777 bidi-iterating.
1778 (back_to_previous_visible_line_start): If handle_display_prop
1779 pushed the iterator stack, restore the internal state of the bidi
1780 iterator by calling bidi_pop_it same number of times.
1781 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1782 and we are bidi-iterating, don't decrement the iterator position;
1783 instead, set the first_elt flag in the bidi iterator, to produce
1784 the same effect.
1785 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1786 (push_display_prop): xassert that we are iterating a buffer.
1787 (push_it, pop_it): Save and restore paragraph_embedding member.
1788 (handle_single_display_spec, next_overlay_string)
1789 (get_overlay_strings_1, reseat_1, reseat_to_string)
1790 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1791 correctly. Don't assume unibyte strings are not bidi-reordered.
1792 (compute_display_string_pos)
1793 (compute_display_string_end): Fix handling the case of C string.
1794 (push_it, pop_it): Save and restore from_disp_prop_p.
1795 (handle_single_display_spec, push_display_prop): Set the
1796 from_disp_prop_p flag.
1797 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1798 (pop_it): Call iterate_out_of_display_property only if we are
1799 popping after iteration over a string that came from a display
1800 property. Fix a typo in popping stretch info. Add an assertion
1801 for verifying that the iterator position is in sync with the bidi
1802 iterator.
1803 (handle_single_display_spec, get_overlay_strings_1)
1804 (push_display_prop): Fix initialization of paragraph direction for
1805 string when that of the parent object is not yet determined.
1806 (reseat_1): Call bidi_init_it to resync the bidi
1807 iterator with IT's position. (Bug#7616)
1808 (find_row_edges): If ROW->start.pos gives position
1809 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1810 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1811 Reset the from_disp_prop_p flag.
1812 (SAVE_IT, RESTORE_IT): New macros.
1813 (pos_visible_p, face_before_or_after_it_pos)
1814 (back_to_previous_visible_line_start)
1815 (move_it_in_display_line_to, move_it_in_display_line)
1816 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1817 (try_scrolling, redisplay_window, display_line): Use them when
1818 saving a temporary copy of the iterator and restoring it back.
1819 (back_to_previous_visible_line_start, reseat_1)
1820 (init_iterator): Empty the bidi cache "stack".
1821 (move_it_in_display_line_to): If iterator ended up at
1822 EOL, but we never saw any buffer positions smaller than
1823 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1824 motion in bidi-reordered lines.
1825 (move_it_in_display_line_to): Record prev_method and prev_pos
1826 immediately before the call to set_iterator_to_next. Fixes cursor
1827 motion in bidi-reordered lines with stretch glyphs and strings
1828 displayed in margins. (Bug#8133) (Bug#8867)
1829 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1830 TO_CHARPOS.
1831 (pos_visible_p): Support positions in bidi-reordered lines.
1832 Save and restore bidi cache.
1833
1834 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1835 (bidi_paragraph_info): Delete unused struct.
1836 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1837 (bidi_cache_start): New variable.
1838 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1839 to zero.
1840 (bidi_cache_fetch_state, bidi_cache_search)
1841 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1842 (bidi_cache_find, bidi_peek_at_next_level)
1843 (bidi_level_of_next_char, bidi_find_other_level_edge)
1844 (bidi_move_to_visually_next): Compare cache index with
1845 bidi_cache_start rather than with zero.
1846 (bidi_fetch_char): Accept new argument STRING; all callers
1847 changed. Support iteration over a string. Support strings with
1848 display properties. Support unibyte strings. Fix the type of
1849 `len' according to what STRING_CHAR_AND_LENGTH expects.
1850 (bidi_paragraph_init, bidi_resolve_explicit_1)
1851 (bidi_resolve_explicit, bidi_resolve_weak)
1852 (bidi_level_of_next_char, bidi_move_to_visually_next):
1853 Support iteration over a string.
1854 (bidi_set_sor_type, bidi_resolve_explicit_1)
1855 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1856 can now be zero (for strings); special values 0 and -1 were
1857 changed to -1 and -2, respectively.
1858 (bidi_char_at_pos): New function.
1859 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1860 Call it instead of FETCH_MULTIBYTE_CHAR.
1861 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1862 initialized to valid values.
1863 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1864 values.
1865 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1866 the test for valid cached positions. Fix the logic for looking up
1867 the sentinel state in the cache. GCPRO the Lisp string we are
1868 iterating.
1869 (bidi_push_it, bidi_pop_it): New functions.
1870 (bidi_initialize): Initialize the bidi cache start stack pointer.
1871 (bidi_cache_ensure_space): New function, refactored from part of
1872 bidi_cache_iterator_state. Don't assume the required size is just
1873 one BIDI_CACHE_CHUNK away.
1874 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1875 (bidi_count_bytes, bidi_char_at_pos): New functions.
1876 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1877 always valid if bidi_cache_idx is valid.
1878 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1879 is valid if it's going to be used.
1880 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1881 (bidi_cache_fetch_state, bidi_cache_search)
1882 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1883 (bidi_cache_iterator_state, bidi_cache_find)
1884 (bidi_find_other_level_edge, bidi_cache_start_stack):
1885 All variables related to cache indices are now EMACS_INT.
1886
1887 * dispextern.h (struct bidi_string_data): New structure.
1888 (struct bidi_it): New member `string'. Make flag members be 1-bit
1889 fields, and put them last in the struct.
1890 (compute_display_string_pos, compute_display_string_end):
1891 Update prototypes.
1892 (bidi_push_it, bidi_pop_it): Add prototypes.
1893 (struct iterator_stack_entry): New members bidi_p,
1894 paragraph_embedding, and from_disp_prop_p.
1895 (struct it): Member bidi_p is now a bit field 1 bit wide.
1896 (bidi_shelve_cache, bidi_unshelve_cache):
1897 Declare prototypes.
1898
1899 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1900 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1901 and vector-like objects.
1902
1903 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1904 cache around display iteration.
1905
1906 * window.c (Fwindow_end, window_scroll_pixel_based)
1907 (displayed_window_lines, Frecenter): Save and restore the bidi
1908 cache around display iteration.
1909
1910 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1911
1912 * editfns.c (Fdelete_region): Clarify the use of the named
1913 parameters (bug#6788).
1914
1915 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1916
1917 * indent.c (Fvertical_motion): Set and restore w->pointm when
1918 saving and restoring the window's buffer (Bug#9006).
1919
1920 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1921
1922 * editfns.c (Fstring_to_char): Clarify just what is returned
1923 (bug#6576). Text by Eli Zaretskii.
1924
1925 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1926
1927 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1928
1929 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1930
1931 * buffer.c (mmap_find): Fix a typo.
1932
1933 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1934
1935 Fix execution of x selection hooks.
1936 * xselect.c (Qx_lost_selection_functions)
1937 (Qx_sent_selection_functions): New vars.
1938 (syms_of_xselect): DEFSYM them.
1939 (x_handle_selection_request): Pass Qx_sent_selection_functions
1940 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1941 (x_handle_selection_clear,x_clear_frame_selections):
1942 Pass Qx_lost_selection_functions rather than
1943 Vx_lost_selection_functions to Frun_hook_with_args.
1944
1945 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1946
1947 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1948 The old code sometimes used this field without initializing it.
1949
1950 * alloc.c (gc_sweep): Don't read past end of array.
1951 In theory, the old code could also have corrupted Emacs internals,
1952 though it'd be very unlikely.
1953
1954 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1955
1956 * character.c (Fcharacterp): Don't advertise optional ignored
1957 argument. (Bug#4026)
1958
1959 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1960
1961 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1962 key" (bug#4257).
1963
1964 * window.c (Fset_window_start): Doc fix (bug#4199).
1965 (Fset_window_hscroll): Ditto.
1966
1967 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1968
1969 Fix minor new problems caught by GCC 4.6.1.
1970 * term.c (init_tty): Remove unused local.
1971 * xsettings.c (store_monospaced_changed): Define this function only
1972 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1973 not used otherwise.
1974
1975 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1976
1977 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1978
1979 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1980
1981 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1982 are the mini-buffer and the echo area (bug#3320).
1983
1984 * term.c (init_tty): Remove support for supdup, c10 and perq
1985 terminals, which are no longer supported (bug#1482).
1986
1987 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1988
1989 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1990
1991 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1992
1993 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1994 for non-popups (Bug#3642).
1995
1996 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1997
1998 * alloc.c (reset_malloc_hooks): Protoize.
1999 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2000 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2001 * cm.c (losecursor): Likewise.
2002 * data.c (fmod): Likewise.
2003 * dispnew.c (swap_glyphs_in_rows): Likewise.
2004 * emacs.c (memory_warning_signal): Likewise.
2005 * floatfns.c (float_error): Likewise.
2006 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2007 (otf_open, font_otf_capability, generate_otf_features)
2008 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2009 Likewise.
2010 * image.c (pbm_read_file): Likewise.
2011 * indent.c (string_display_width): Likewise.
2012 * intervals.c (check_for_interval, search_for_interval)
2013 (inc_interval_count, count_intervals, root_interval)
2014 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2015 * lread.c (defalias): Likewise.
2016 * ralloc.c (r_alloc_check): Likewise.
2017 * regex.c (set_image_of_range_1, set_image_of_range)
2018 (regex_grow_registers): Likewise.
2019 * sysdep.c (strerror): Likewise.
2020 * termcap.c (valid_filename_p, tprint, main): Likewise.
2021 * tparam.c (main): Likewise.
2022 * unexhp9k800.c (run_time_remap, save_data_space)
2023 (update_file_ptrs, read_header, write_header, calculate_checksum)
2024 (copy_file, copy_rest, display_header): Likewise.
2025 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2026 Likewise.
2027 * xdisp.c (check_it): Likewise.
2028 * xfaces.c (register_color, unregister_color, unregister_colors):
2029 Likewise.
2030 * xfns.c (print_fontset_result): Likewise.
2031 * xrdb.c (member, fatal, main): Likewise.
2032
2033 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2034
2035 Fix minor problems found by static checking (Bug#9031).
2036 * chartab.c (char_table_set_range, map_sub_char_table):
2037 Remove unused locals.
2038 (uniprop_table): Now static.
2039 * composite.c (_work_char): Remove unused static var.
2040
2041 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2042
2043 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2044
2045 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2046
2047 * gtkutil.c (qttip_cb): Remove code without function.
2048
2049 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2050
2051 * w32.c (pthread_sigmask): New stub.
2052
2053 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2054
2055 Use pthread_sigmask, not sigprocmask (Bug#9010).
2056 sigprocmask is portable only for single-threaded applications, and
2057 Emacs can be multi-threaded when it uses GTK.
2058 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2059 (LIBES): Use it.
2060 * callproc.c (Fcall_process):
2061 * process.c (create_process):
2062 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2063 Use pthread_sigmask, not sigprocmask.
2064
2065 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2066
2067 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2068 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2069 wrong (Bug#8591).
2070
2071 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2072
2073 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2074 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2075 (xg_hide_tooltip): Fix comment.
2076
2077 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2078 in registerServicesMenuSendTypes.
2079 (validRequestorForSendType): Don't check ns_return_types.
2080
2081 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2082 ns_return_type.
2083
2084 2011-07-08 Jason Rumney <jasonr@gnu.org>
2085
2086 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2087 frame struct members of non-existent frames (Bug#6284).
2088
2089 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2090
2091 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2092 variable firstTime not needed on OSX >= 10.6.
2093 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2094 >= 10.5. Use setKnobProportion, setDoubleValue.
2095
2096 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2097 (MAC_OS_X_VERSION_10_5): Define if not defined.
2098 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2099 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2100 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2101
2102 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2103 cString and lossyCString on OSX >= 10.4
2104
2105 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2106 sizeToFit on OSX >= 10.2.
2107
2108 * nsimage.m (allocInitFromFile): Don't use deprecated method
2109 bestRepresentationForDevice on OSX >= 10.6.
2110
2111 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2112 to avoid warning.
2113
2114 * emacs.c: Declare unexec_init_emacs_zone.
2115
2116 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2117
2118 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2119
2120 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2121 on svcsMenu (Bug#8842).
2122
2123 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2124 ns_return_types.
2125 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2126
2127 * nsterm.m (QUTF8_STRING): Declare.
2128 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2129 (validRequestorForSendType): Return type is (id).
2130 Change indexOfObjectIdenticalTo to indexOfObject.
2131 Check if we have local selection before returning self (Bug#8842).
2132 (writeSelectionToPasteboard): Put local selection into paste board
2133 if we have a local selection (Bug#8842).
2134 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2135
2136 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2137 (ns_get_local_selection): Declare.
2138
2139 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2140
2141 * keymap.c (describe_map_tree): Don't insert a double newline at
2142 the end of the buffer (bug#1169) and return whether we inserted
2143 something.
2144
2145 * callint.c (Fcall_interactively): Change "reading args" to
2146 "providing args" to try to clarify what it does (bug#1010).
2147
2148 2011-07-07 Kenichi Handa <handa@m17n.org>
2149
2150 * composite.c (composition_compute_stop_pos): Ignore a static
2151 composition starting before CHARPOS (Bug#8915).
2152
2153 * xdisp.c (handle_composition_prop): Likewise.
2154
2155 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2156
2157 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2158 (Bug#9015)
2159
2160 2011-07-07 Kenichi Handa <handa@m17n.org>
2161
2162 * character.h (unicode_category_t): New enum type.
2163
2164 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2165 (Qchar_code_property_table): New variable.
2166 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2167 (UNIPROP_COMPRESSED_FORM_P): New macros.
2168 (char_table_ascii): Uncompress the compressed values.
2169 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2170 Uncompress the compressed values.
2171 (sub_char_table_ref_and_range): Likewise.
2172 (char_table_ref_and_range): Uncompress the compressed values.
2173 (sub_char_table_set): New arg is_uniprop. Callers changed.
2174 Uncompress the compressed values.
2175 (sub_char_table_set_range): Args changed. Callers changed.
2176 (char_table_set_range): Adjuted for the above change.
2177 (map_sub_char_table): Delete args default_val and parent. Add arg
2178 top. Give decoded values to a Lisp function.
2179 (map_char_table): Adjust for the above change. Give decoded
2180 values to a Lisp function. Gcpro more variables.
2181 (uniprop_table_uncompress)
2182 (uniprop_decode_value_run_length): New functions.
2183 (uniprop_decoder, uniprop_decoder_count): New variables.
2184 (uniprop_get_decoder, uniprop_encode_value_character)
2185 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2186 New functions.
2187 (uniprop_encoder, uniprop_encoder_count): New variables.
2188 (uniprop_get_encoder, uniprop_table)
2189 (Funicode_property_table_internal, Fget_unicode_property_internal)
2190 (Fput_unicode_property_internal): New functions.
2191 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2192 Sunicode_property_table_internal, Sget_unicode_property_internal,
2193 and Sput_unicode_property_internal. Defvar_lisp
2194 char-code-property-alist.
2195
2196 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2197 Vunicode_category_table.
2198
2199 * font.c (font_range): Adjust for the change of
2200 Vunicode_category_table.
2201
2202 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2203
2204 * m/iris4d.h: Remove file, move contents ...
2205 * s/irix6-5.h: ... here.
2206
2207 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2208
2209 Remove unportable assumption about struct layout (Bug#8884).
2210 * alloc.c (mark_buffer):
2211 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2212 (clone_per_buffer_values): Don't assume that
2213 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2214 This isn't true in general, and it's particularly not true
2215 if Emacs is configured with --with-wide-int.
2216 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2217 New macros, used in the buffer.c change.
2218
2219 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2220
2221 * xsettings.c: Use both GConf and GSettings if both are available.
2222 (store_config_changed_event): Add comment.
2223 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2224 (store_tool_bar_style_changed): New functions.
2225 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2226 (struct xsettings): Move font inside HAVE_XFT.
2227 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2228 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2229 Move inside HAVE_XFT.
2230 (something_changed_gsettingsCB): Rename from something_changedCB.
2231 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2232 also.
2233 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2234 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2235 (something_changed_gconfCB): Rename from something_changedCB.
2236 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2237 (parse_settings): Move check for font inside HAVE_XFT.
2238 (read_settings, apply_xft_settings): Add comment.
2239 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2240 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2241 call store_font_name_changed.
2242 (xft_settings_event): Add comment.
2243 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2244 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2245 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2246 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2247 (xsettings_initialize): Call init_gsettings last.
2248 (xsettings_get_system_font, xsettings_get_system_normal_font):
2249 Add comment.
2250
2251 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2252
2253 Random fixes. E.g., (random) never returned negative values.
2254 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2255 subseconds part to the entropy, as that's a bit more random.
2256 Prefer signed to unsigned, since the signedness doesn't matter and
2257 in general we prefer signed. When given a limit, use a
2258 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2259 latter isn't right if USE_2_TAGS_FOR_INTS.
2260 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2261 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2262
2263 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2264
2265 * textprop.c (text_property_stickiness):
2266 Obey Vtext_property_default_nonsticky.
2267 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2268 * w32fns.c (syms_of_w32fns):
2269 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2270
2271 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2272
2273 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2274 This is more efficient than Ffile_directory_p and avoids a minor race.
2275
2276 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2277
2278 * buffer.c (Foverlay_put): Say what the return value is
2279 (bug#7835).
2280
2281 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2282 is a directory before asking whether to use the file name
2283 (bug#7564).
2284 (barf_or_query_if_file_exists): Make the "File is a directory"
2285 error be more correct.
2286
2287 * fns.c (Frequire): Remove the mention of the .gz files, since
2288 that's installation-specific, but keep the mention of
2289 `get-load-suffixes'.
2290
2291 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2292
2293 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2294 Report string overflow if the output is too long.
2295
2296 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2297
2298 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2299 (syms_of_gnutls): Remove duplicate DEFSYM for
2300 Qgnutls_bootprop_verify_hostname_error, an error for
2301 Qgnutls_bootprop_verify_error (which is no longer used).
2302
2303 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2304 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2305 Also (re)move comments that are misplaced or no longer relevant.
2306
2307 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2308
2309 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2310
2311 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2312
2313 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2314 and background color parameters if they have been changed.
2315
2316 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2317
2318 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2319
2320 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2321
2322 * xsettings.c (SYSTEM_FONT): Define only when used.
2323 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2324
2325 * keymap.c (access_keymap_1): Now static.
2326
2327 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2328
2329 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2330 leave any prefix arg for the up event (Bug#1586).
2331
2332 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2333
2334 * lread.c (syms_of_lread): Mention single symbols defined by
2335 `defvar' or `defconst' (bug#7154).
2336
2337 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2338 (Frequire): Mention get-load-suffixes.
2339
2340 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2341
2342 * window.h (window): Remove clone_number slot.
2343 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2344 Remove.
2345 (make_parent_window, make_window, saved_window)
2346 (Fset_window_configuration, save_window_save): Don't deal with
2347 clone numbers.
2348 * buffer.c (Qclone_number): Remove declaration.
2349 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2350
2351 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2352
2353 Add multiple inheritance to keymaps.
2354 * keymap.c (Fmake_composed_keymap): New function.
2355 (Fset_keymap_parent): Simplify.
2356 (fix_submap_inheritance): Remove.
2357 (access_keymap_1): New function extracted from access_keymap to handle
2358 embedded parents and handle lists of maps.
2359 (access_keymap): Use it.
2360 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2361 (Fcopy_keymap): Handle embedded parents.
2362 (Fcommand_remapping, define_as_prefix): Simplify.
2363 (Fkey_binding): Simplify.
2364 (syms_of_keymap): Move minibuffer-local-completion-map,
2365 minibuffer-local-filename-completion-map,
2366 minibuffer-local-must-match-map, and
2367 minibuffer-local-filename-must-match-map to Elisp.
2368 (syms_of_keymap): Defsubr make-composed-keymap.
2369 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2370 (parse_menu_item): Trivial simplification.
2371
2372 2011-07-01 Glenn Morris <rgm@gnu.org>
2373
2374 * Makefile.in (SETTINGS_LIBS): Fix typo.
2375
2376 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2377
2378 * coding.c (Fencode_coding_string): Record the last coding system
2379 used, as the function doc string says (bug#8738).
2380
2381 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2382
2383 * xsettings.c (store_monospaced_changed): Take new font as arg and
2384 check for change against current_mono_font.
2385 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2386 (emacs_settings_constructor, emacs_settings_get_property)
2387 (emacs_settings_set_property, emacs_settings_class_init)
2388 (emacs_settings_init, gsettings_obj): Remove.
2389 (something_changedCB): New function for HAVE_GSETTINGS.
2390 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2391 with value as argument.
2392 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2393 g_settings_new (Bug#8967). Do not create gsettings_obj.
2394 Remove calls to g_settings_bind. Connect something_changedCB to
2395 "changed".
2396
2397 * xgselect.c: Add defined (HAVE_GSETTINGS).
2398 (xgselect_initialize): Ditto.
2399
2400 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2401 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2402 xg_select.
2403
2404 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2405
2406 * eval.c (struct backtrace): Simplify and port the data structure.
2407 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2408 signed bit field, as this assumption is not portable and it makes
2409 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2410 "char debug_on_exit : 1" as this is not portable either; instead,
2411 use the portable "unsigned int debug_on_exit : 1". Remove unused
2412 member evalargs. Remove obsolete comments about cc bombing out.
2413
2414 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2415
2416 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2417 Let HAVE_GSETTINGS override HAVE_GCONF.
2418 (store_monospaced_changed): New function.
2419 (EMACS_SETTINGS): A new type derived from GObject to handle
2420 GSettings notifications.
2421 (emacs_settings_constructor, emacs_settings_get_property)
2422 (emacs_settings_set_property, emacs_settings_class_init):
2423 New functions.
2424 (gsettings_client, gsettings_obj): New variables.
2425 (GSETTINGS_SCHEMA): New define.
2426 (something_changedCB): Call store_monospaced_changed.
2427 (init_gsettings): New function.
2428 (xsettings_initialize): Call init_gsettings.
2429 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2430 to NULL.
2431
2432 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2433 GCONF_CFLAGS/LIBS.
2434
2435 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2436
2437 * window.c (resize_root_window, grow_mini_window)
2438 (shrink_mini_window): Rename Qresize_root_window to
2439 Qwindow_resize_root_window and Qresize_root_window_vertically to
2440 Qwindow_resize_root_window_vertically.
2441
2442 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2443
2444 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2445
2446 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2447
2448 * makefile.w32-in: Redesign dependencies so they reflect more
2449 clearly which files are directly included by each source file,
2450 and not through other includes.
2451
2452 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2453
2454 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2455 (sort_overlays, overlay_strings): When an overlay's clone number
2456 matches the window's clone number process the overlay even if
2457 the overlay's window property doesn't match the current window.
2458
2459 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2460 (Fwindow_hchild): Rename to Fwindow_left_child.
2461 (Fwindow_next): Rename to Fwindow_next_sibling.
2462 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2463 (resize_window_check): Rename to window_resize_check.
2464 (resize_window_apply): Rename to window_resize_apply.
2465 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2466 (Fdelete_other_windows_internal, resize_frame_windows)
2467 (Fsplit_window_internal, Fdelete_window_internal)
2468 (grow_mini_window, shrink_mini_window)
2469 (Fresize_mini_window_internal): Fix callers accordingly.
2470
2471 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2472
2473 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2474 (emacs_fixed_set_min_size): Remove.
2475 (emacs_fixed_new): Take frame as argument.
2476
2477 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2478 (_EmacsFixedPrivate): Remove minwidth/height.
2479 Add struct frame *f.
2480 (emacs_fixed_init): Initialize priv->f.
2481 (get_parent_class, emacs_fixed_set_min_size): Remove.
2482 (emacs_fixed_new): Set priv->f to argument.
2483 (emacs_fixed_get_preferred_width)
2484 (emacs_fixed_get_preferred_height): Use min_width/height from
2485 frames size_hint to set minimum and natural (Bug#8919).
2486 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2487 and use min_width/height from frames size_hint to set
2488 min_width/height (Bug#8919).
2489
2490 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2491 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2492 Fix indentation.
2493
2494 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2495
2496 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2497 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2498 called at ZV.
2499
2500 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2501
2502 * process.c (wait_reading_process_output): Bypass select if
2503 waiting for a cell while ignoring keyboard input, and input is
2504 pending. Suggested by Jan Djärv (Bug#8869).
2505
2506 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2507
2508 Use gnulib's dup2 module instead of rolling our own.
2509 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2510
2511 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2512
2513 * dispnew.c (scrolling_window): Before scrolling, turn off a
2514 mouse-highlight in the window being scrolled.
2515
2516 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2517
2518 Move DEFSYM to lisp.h and use everywhere.
2519
2520 * character.h (DEFSYM): Move declaration...
2521 * lisp.h (DEFSYM): ...here.
2522
2523 * gnutls.c:
2524 * minibuf.c:
2525 * w32menu.c:
2526 * w32proc.c:
2527 * w32select.c: Don't include character.h.
2528
2529 * alloc.c (syms_of_alloc):
2530 * buffer.c (syms_of_buffer):
2531 * bytecode.c (syms_of_bytecode):
2532 * callint.c (syms_of_callint):
2533 * casefiddle.c (syms_of_casefiddle):
2534 * casetab.c (init_casetab_once):
2535 * category.c (init_category_once, syms_of_category):
2536 * ccl.c (syms_of_ccl):
2537 * cmds.c (syms_of_cmds):
2538 * composite.c (syms_of_composite):
2539 * dbusbind.c (syms_of_dbusbind):
2540 * dired.c (syms_of_dired):
2541 * dispnew.c (syms_of_display):
2542 * doc.c (syms_of_doc):
2543 * editfns.c (syms_of_editfns):
2544 * emacs.c (syms_of_emacs):
2545 * eval.c (syms_of_eval):
2546 * fileio.c (syms_of_fileio):
2547 * fns.c (syms_of_fns):
2548 * frame.c (syms_of_frame):
2549 * fringe.c (syms_of_fringe):
2550 * insdel.c (syms_of_insdel):
2551 * keymap.c (syms_of_keymap):
2552 * lread.c (init_obarray, syms_of_lread):
2553 * macros.c (syms_of_macros):
2554 * msdos.c (syms_of_msdos):
2555 * print.c (syms_of_print):
2556 * process.c (syms_of_process):
2557 * search.c (syms_of_search):
2558 * sound.c (syms_of_sound):
2559 * syntax.c (init_syntax_once, syms_of_syntax):
2560 * terminal.c (syms_of_terminal):
2561 * textprop.c (syms_of_textprop):
2562 * undo.c (syms_of_undo):
2563 * w32.c (globals_of_w32):
2564 * window.c (syms_of_window):
2565 * xdisp.c (syms_of_xdisp):
2566 * xfaces.c (syms_of_xfaces):
2567 * xfns.c (syms_of_xfns):
2568 * xmenu.c (syms_of_xmenu):
2569 * xsettings.c (syms_of_xsettings):
2570 * xterm.c (syms_of_xterm): Use DEFSYM.
2571
2572 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2573
2574 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2575
2576 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2577
2578 Integer and buffer overflow fixes (Bug#8873).
2579
2580 * print.c (printchar, strout): Check for string overflow.
2581 (PRINTPREPARE, printchar, strout):
2582 Don't set size unless allocation succeeds.
2583
2584 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2585 for sizes. Check for string overflow more accurately.
2586 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2587
2588 * macros.c: Integer and buffer overflow fixes.
2589 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2590 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2591 Use ptrdiff_t, not int, for sizes.
2592 Don't increment bufsize until after realloc succeeds.
2593 Check for size-calculation overflow.
2594 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2595
2596 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2597
2598 * lread.c: Integer overflow fixes.
2599 (read_integer): Radix is now EMACS_INT, not int,
2600 to improve quality of diagnostics for out-of-range radices.
2601 Calculate buffer size correctly for out-of-range radices.
2602 (read1): Check for integer overflow in radices, and in
2603 read-circle numbers.
2604 (read_escape): Avoid int overflow.
2605 (Fload, openp, read_buffer_size, read1)
2606 (substitute_object_recurse, read_vector, read_list, map_obarray):
2607 Use ptrdiff_t, not int, for sizes.
2608 (read1): Use EMACS_INT, not int, for sizes.
2609 Check for size overflow.
2610
2611 * image.c (cache_image): Check for size arithmetic overflow.
2612
2613 * lread.c: Integer overflow issues.
2614 (saved_doc_string_size, saved_doc_string_length)
2615 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2616 Now ptrdiff_t, not int.
2617 (read1): Don't assume doc string length fits in int. Check for
2618 out-of-range doc string lengths.
2619 (read_list): Don't assume file position fits in int.
2620 (read_escape): Check for hex character overflow.
2621
2622 2011-06-22 Leo Liu <sdl.web@gmail.com>
2623
2624 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2625 Move to minibuffer.el.
2626
2627 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2628
2629 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2630 The following patches are for when GLYPH_DEBUG && !XASSERT.
2631 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2632 * dispnew.c (flush_stdout):
2633 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2634 Mark as externally visible.
2635 * dispnew.c (check_window_matrix_pointers): Now static.
2636 * dispnew.c (window_to_frame_vpos):
2637 * xfns.c (unwind_create_frame):
2638 * xterm.c (x_check_font): Remove unused local.
2639 * scroll.c (CHECK_BOUNDS):
2640 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2641 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2642 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2643 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2644 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2645 Now static.
2646 (debug_method_add): Use va_list and vsprintf rather than relying
2647 on undefined behavior with wrong number of arguments.
2648 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2649 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2650 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2651 since we're not interested in debugging glyphs with old libraries.
2652 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2653 GCC 4.6.0's static checking.
2654
2655 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2656
2657 Integer overflow and signedness fixes (Bug#8873).
2658 A few related buffer overrun fixes, too.
2659
2660 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2661
2662 * dispextern.h (struct face.stipple):
2663 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2664 (x_bitmap_mask, x_allocate_bitmap_record)
2665 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2666 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2667 (x_create_bitmap_from_xpm_data):
2668 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2669 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2670 (.bitmaps_last):
2671 * xfaces.c (load_pixmap):
2672 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2673 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2674 (.bitmaps_last, struct x_output.icon_bitmap):
2675 Use ptrdiff_t, not int, for bitmap indexes.
2676 (x_allocate_bitmap_record): Check for size overflow.
2677 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2678
2679 Use ptrdiff_t, not int, for overlay counts.
2680 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2681 * editfns.c (overlays_around, get_pos_property):
2682 * textprop.c (get_char_property_and_overlay):
2683 * xdisp.c (next_overlay_change, note_mouse_highlight):
2684 * xfaces.c (face_at_buffer_position):
2685 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2686 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2687 (Fnext_overlay_change, Fprevious_overlay_change)
2688 (mouse_face_overlay_overlaps, Foverlays_in):
2689 Use ptrdiff_t, not int, for sizes.
2690 (overlays_at, overlays_in): Check for size-calculation overflow.
2691
2692 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2693
2694 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2695 (x_session_initialize): Do not assume string length fits in int.
2696
2697 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2698 This is unlikely, but can occur if DPI is outlandish.
2699
2700 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2701 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2702
2703 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2704 * xrdb.c (magic_file_p, search_magic_path):
2705 Omit last arg SUFFIX; it was always 0. All callers changed.
2706 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2707
2708 * xfont.c (xfont_match): Avoid need for strlen.
2709
2710 * xfns.c: Don't assume strlen fits in int.
2711 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2712
2713 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2714 not unsigned long, as we prefer signed integers. All callers changed.
2715 Detect integer overflow in repeat count.
2716 (message_dolog): Don't assume print length fits in 39 bytes.
2717 (display_mode_element): Don't assume strlen fits in int.
2718
2719 * termcap.c: Don't assume sizes fit in int and never overflow.
2720 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2721 (gobble_line): Check for size-calculation overflow.
2722
2723 * minibuf.c (Fread_buffer):
2724 * lread.c (intern, intern_c_string):
2725 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2726 Don't assume string length fits in int.
2727
2728 * keyboard.c (parse_tool_bar_item):
2729 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2730
2731 * font.c: Don't assume string length fits in int.
2732 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2733 Use ptrdiff_t, not int.
2734 (font_intern_prop): Don't assume string length fits in int.
2735 Don't assume integer property fits in fixnum.
2736 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2737
2738 * filelock.c: Fix some buffer overrun and integer overflow issues.
2739 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2740 Reformulate so as not to need the command string.
2741 Invoke gzip -cd rather than gunzip, as it's more portable.
2742 (lock_info_type, lock_file_1, lock_file):
2743 Don't assume pid_t and time_t fit in unsigned long.
2744 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2745 (current_lock_owner): Prefer signed type for sizes.
2746 Use memcpy, not strncpy, where memcpy is what is really wanted.
2747 Don't assume (via atoi) that time_t and pid_t fit in int.
2748 Check for time_t and/or pid_t out of range, e.g., via a network share.
2749 Don't alloca where an auto var works fine.
2750
2751 * fileio.c: Fix some integer overflow issues.
2752 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2753 Don't assume string length fits in int.
2754 (directory_file_name): Don't assume string length fits in long.
2755 (make_temp_name): Don't assume pid fits in int, or that its print
2756 length is less than 20.
2757
2758 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2759
2760 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2761
2762 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2763
2764 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2765 We prefer signed integers, even for size calculations.
2766
2767 * emacs.c: Don't assume string length fits in 'int'.
2768 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2769 (main): Don't invoke strlen when not needed.
2770
2771 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2772 (XD_DEBUG_MESSAGE): Don't waste a byte.
2773
2774 * callproc.c (getenv_internal_1, getenv_internal)
2775 (Fgetenv_internal):
2776 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2777
2778 * lread.c (invalid_syntax): Omit length argument.
2779 All uses changed. This doesn't fix a bug, but it simplifies the
2780 code away from its former Hollerith-constant appearance, and it's
2781 one less 'int' to worry about when looking at integer-overflow issues.
2782 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2783
2784 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2785 This didn't break anything, but it didn't help either.
2786 It's confusing to put a bogus integer in a place where the actual
2787 value does not matter.
2788 (LIST_END_P): Remove unused macro and its bogus comment.
2789 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2790
2791 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2792 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2793 implementation.
2794 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2795 We prefer signed types, and the value cannot exceed the EMACS_INT
2796 range anyway (because otherwise the length would not be representable).
2797 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2798 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2799 This avoids a GCC warning when WIDE_EMACS_INT.
2800
2801 * indent.c (sane_tab_width): New function.
2802 (current_column, scan_for_column, Findent_to, position_indentation)
2803 (compute_motion): Use it. This is just for clarity.
2804 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2805
2806 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2807
2808 * lisp.h (lint_assume): New macro.
2809 * composite.c (composition_gstring_put_cache):
2810 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2811
2812 * editfns.c, insdel.c:
2813 Omit unnecessary forward decls, to simplify future changes.
2814
2815 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2816
2817 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2818
2819 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2820 Use much-faster test for byte-length change.
2821 Don't assume string byte-length fits in 'int'.
2822 Check that character arg fits in 'int'.
2823 (mapcar1): Declare byte as byte, for clarity.
2824
2825 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2826
2827 * fns.c (concat): Catch string overflow earlier.
2828 Do not rely on integer wraparound.
2829
2830 * dispextern.h (struct it.overlay_strings_charpos)
2831 (struct it.selective): Now EMACS_INT, not int.
2832 * xdisp.c (forward_to_next_line_start)
2833 (back_to_previous_visible_line_start)
2834 (reseat_at_next_visible_line_start, next_element_from_buffer):
2835 Don't arbitrarily truncate the value of 'selective' to int.
2836
2837 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2838
2839 * composite.c: Don't truncate sizes to 'int'.
2840 (composition_gstring_p, composition_reseat_it)
2841 (composition_adjust_point): Use EMACS_INT, not int.
2842 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2843 not EMACS_UINT, for indexes.
2844
2845 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2846
2847 * buffer.c: Include <verify.h>.
2848 (struct sortvec.priority, struct sortstr.priority):
2849 Now EMACS_INT, not int.
2850 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2851 (struct sortstr.size, record_overlay_string)
2852 (struct sortstrlist.size, struct sortlist.used):
2853 Don't truncate size to int.
2854 (record_overlay_string): Check for size-calculation overflow.
2855 (init_buffer_once): Check at compile-time, not run-time.
2856
2857 2011-06-22 Jim Meyering <meyering@redhat.com>
2858
2859 Don't leak an XBM-image-sized buffer
2860 * image.c (xbm_load): Free the image buffer after using it.
2861
2862 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2863
2864 Port to Sun C.
2865 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2866 that Sun C diagnosed.
2867 * fns.c (secure_hash): Fix pointer signedness issue.
2868 * intervals.c (static_offset_intervals): New function.
2869 (offset_intervals): Use it.
2870
2871 2011-06-21 Leo Liu <sdl.web@gmail.com>
2872
2873 * deps.mk (fns.o):
2874 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2875 sha512.h.
2876
2877 * fns.c (secure_hash): Rename from crypto_hash_function and change
2878 the first arg to accept symbols.
2879 (Fsecure_hash): New primitive.
2880 (syms_of_fns): New symbols.
2881
2882 2011-06-20 Deniz Dogan <deniz@dogan.se>
2883
2884 * process.c (Fset_process_buffer): Clarify return value in
2885 docstring.
2886
2887 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2888
2889 * dispnew.c (add_window_display_history): Use BVAR.
2890
2891 * xdisp.c (debug_method_add): Use BVAR.
2892 (check_window_end, dump_glyph_matrix, dump_glyph)
2893 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2894
2895 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2896 Likewise.
2897
2898 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2899 check till after the cache is created in init_frame_faces.
2900
2901 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2902
2903 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2904
2905 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2906
2907 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2908 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2909 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2910
2911 Improve buffer-overflow checking (Bug#8873).
2912 * fileio.c (Finsert_file_contents):
2913 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2914 Remove the old (too-loose) buffer overflow checks.
2915 They weren't needed, since make_gap checks for buffer overflow.
2916 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2917 The old code merely checked for Emacs fixnum overflow, and relied
2918 on undefined (wraparound) behavior. The new code avoids undefined
2919 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2920
2921 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2922 Tune. Don't use wider integers than needed. Don't use alloca.
2923 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2924
2925 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2926
2927 * insdel.c, lisp.h (buffer_overflow): New function.
2928 (insert_from_buffer_1, replace_range, replace_range_2):
2929 * insdel.c (make_gap_larger):
2930 * editfns.c (Finsert_char):
2931 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2932
2933 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2934
2935 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2936
2937 Integer overflow and signedness fixes (Bug#8873).
2938
2939 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2940 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2941
2942 * fileio.c: Don't assume EMACS_INT fits in off_t.
2943 (emacs_lseek): New static function.
2944 (Finsert_file_contents, Fwrite_region): Use it.
2945 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2946
2947 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2948
2949 * fns.c: Don't overflow int when computing a list length.
2950 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2951 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2952 truncation on 64-bit hosts. Check for QUIT every
2953 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2954 faster and is responsive enough.
2955 (Flength): Report an error instead of overflowing an integer.
2956 (Fsafe_length): Return a float if the value is not representable
2957 as a fixnum. This shouldn't happen except in contrived situations.
2958 (Fnthcdr, Fsort): Don't assume list length fits in int.
2959 (Fcopy_sequence): Don't assume vector length fits in int.
2960
2961 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2962 (header_size, word_size): New constants.
2963 (allocate_vectorlike): Don't check size overflow here.
2964 (allocate_vector): Check it here instead, since this is the only
2965 caller of allocate_vectorlike that could cause overflow.
2966 Check that the new vector's length is representable as a fixnum.
2967
2968 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2969 The previous code was bogus. For example, next_almost_prime (32)
2970 returned 39, which is undesirable as it is a multiple of 3; and
2971 next_almost_prime (24) returned 25, which is a multiple of 5 so
2972 why was the code bothering to check for multiples of 7?
2973
2974 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2975
2976 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2977
2978 Variadic C functions now count arguments with ptrdiff_t.
2979 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2980 Back then I didn't know that the Emacs coding style prefers signed int.
2981 Also, in the meantime I found a few more instances where arguments
2982 were being counted with int, which may truncate counts on 64-bit
2983 machines, or EMACS_INT, which may be unnecessarily wide.
2984 * lisp.h (struct Lisp_Subr.function.aMANY)
2985 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2986 Arg counts are now ptrdiff_t, not size_t.
2987 All variadic functions and their callers changed accordingly.
2988 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2989 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2990 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2991 * callint.c (Fcall_interactively): Check arg count for overflow,
2992 to avoid potential buffer overrun. Use signed char, not 'int',
2993 for 'varies' array, so that we needn't bother to check its size
2994 calculation for overflow.
2995 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2996 * eval.c (apply_lambda):
2997 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2998 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2999 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3000
3001 * callint.c (Fcall_interactively): Don't use index var as event count.
3002
3003 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3004 * mem-limits.h (SIZE): Remove; no longer used.
3005
3006 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3007
3008 Remove unnecessary casts.
3009 * xterm.c (x_term_init):
3010 * xfns.c (x_set_border_pixel):
3011 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3012 These aren't needed now that we assume ANSI C.
3013
3014 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3015 It's more likely to cause problems (due to unsigned overflow)
3016 than to cure them.
3017
3018 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3019
3020 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3021
3022 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3023
3024 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3025
3026 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3027
3028 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3029
3030 GLYPH_CODE_FACE returns EMACS_INT, not int.
3031 * dispextern.h (merge_faces):
3032 * xfaces.c (merge_faces):
3033 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3034 Don't assume EMACS_INT fits in int.
3035
3036 * character.h (CHAR_VALID_P): Remove unused parameter.
3037 * fontset.c, lisp.h, xdisp.c: All uses changed.
3038
3039 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3040
3041 * fns.c (concat): Minor tuning based on overflow analysis.
3042 This doesn't fix any bugs. Use int to hold character, instead
3043 of constantly refetching from Emacs object. Use XFASTINT, not
3044 XINT, for value known to be a character. Don't bother comparing
3045 a single byte to 0400, as it's always less.
3046
3047 * floatfns.c (Fexpt):
3048 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3049
3050 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3051 for characters.
3052
3053 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3054
3055 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3056 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3057 incorrectly succeed when S was a string, because 4294967386 was
3058 truncated before it was used.
3059
3060 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3061 Otherwise, an out-of-range integer could cause undefined behavior
3062 on a 64-bit host.
3063
3064 * composite.c: Use int, not EMACS_INT, for characters.
3065 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3066 EMACS_INT, for values that are known to be in character range.
3067 This doesn't fix any bugs but is the usual style inside Emacs and
3068 may generate better code on 32-bit machines.
3069
3070 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3071 This is for reasons similar to the recent CHAR_STRING fix.
3072 * charset.c (Fencode_char): Check that character arg is actually
3073 a character. Pass an int to ENCODE_CHAR.
3074 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3075 wider than 'int', as a compile-time check to prevent future regressions
3076 in this area.
3077
3078 * character.c (char_string): Remove unnecessary casts.
3079
3080 Make sure a 64-bit char is never passed to CHAR_STRING.
3081 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3082 by silently ignoring the top 32 bits, allowing some values
3083 that were far too large to be valid characters.
3084 * character.h: Include <verify.h>.
3085 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3086 arguments are no wider than unsigned, as a compile-time check
3087 to prevent future regressions in this area.
3088 * data.c (Faset):
3089 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3090 (Fsubst_char_in_region):
3091 * fns.c (concat):
3092 * xdisp.c (decode_mode_spec_coding):
3093 Adjust to CHAR_STRING's new requirement.
3094 * editfns.c (Finsert_char, Fsubst_char_in_region):
3095 * fns.c (concat): Check that character args are actually
3096 characters. Without this test, these functions did the wrong
3097 thing with wildly out-of-range values on 64-bit hosts.
3098
3099 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3100 These casts should not be needed on 32-bit hosts, either.
3101 * keyboard.c (read_char):
3102 * lread.c (Fload): Remove casts to unsigned.
3103
3104 * lisp.h (UNSIGNED_CMP): New macro.
3105 This fixes comparison bugs on 64-bit hosts.
3106 (ASCII_CHAR_P): Use it.
3107 * casefiddle.c (casify_object):
3108 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3109 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3110 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3111 * dispextern.h (FACE_FROM_ID):
3112 * keyboard.c (read_char): Use UNSIGNED_CMP.
3113
3114 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3115 not to EMACS_INT, to avoid GCC warning.
3116
3117 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3118
3119 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3120 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3121 isn't needed on 32-bit machines.
3122
3123 * buffer.c (Fgenerate_new_buffer_name):
3124 Use EMACS_INT for count, not int.
3125 (advance_to_char_boundary): Return EMACS_INT, not int.
3126
3127 * data.c (Qcompiled_function): Now static.
3128
3129 * window.c (window_body_lines): Now static.
3130
3131 * image.c (gif_load): Rename local to avoid shadowing.
3132
3133 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3134 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3135 * alloc.c (make_save_value): Integer argument is now of type
3136 ptrdiff_t, not int.
3137 (mark_object): Use ptrdiff_t, not int.
3138 * lisp.h (pD): New macro.
3139 * print.c (print_object): Use it.
3140
3141 * alloc.c: Use EMACS_INT, not int, to count objects.
3142 (total_conses, total_markers, total_symbols, total_vector_size)
3143 (total_free_conses, total_free_markers, total_free_symbols)
3144 (total_free_floats, total_floats, total_free_intervals)
3145 (total_intervals, total_strings, total_free_strings):
3146 Now EMACS_INT, not int. All uses changed.
3147 (Fgarbage_collect): Compute overall total using a double, so that
3148 integer overflow is less likely to be a problem. Check for overflow
3149 when converting back to an integer.
3150 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3151 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3152 These were 'int' variables that could overflow on 64-bit hosts;
3153 they were never used, so remove them instead of repairing them.
3154 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3155 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3156 Previously, this ceilinged at INT_MAX, but that doesn't work on
3157 64-bit machines.
3158 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3159
3160 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3161 (allocate_vectorlike): Check for ptrdiff_t overflow.
3162 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3163 when a (possibly-narrower) signed value would do just as well.
3164 We prefer using signed arithmetic, to avoid comparison confusion.
3165
3166 * alloc.c: Catch some string size overflows that we were missing.
3167 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3168 for convenience in STRING_BYTES_MAX.
3169 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3170 The definition here is exact; the one in lisp.h was approximate.
3171 (allocate_string_data): Check for string overflow. This catches
3172 some instances we weren't catching before. Also, it catches
3173 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3174 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3175 and ptrdiff_t and EMACS_INT are both 64 bits.
3176
3177 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3178 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3179 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3180
3181 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3182
3183 * alloc.c (Fmake_string): Check for out-of-range init.
3184
3185 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3186
3187 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3188
3189 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3190
3191 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3192 xg_get_default_scrollbar_width.
3193
3194 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3195 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3196 (style_changed_cb): Call update_theme_scrollbar_width and call
3197 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3198 all frames (Bug#8505).
3199 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3200 Call gtk_window_set_resizable if HAVE_GTK3.
3201 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3202 and height if HAVE_GTK3 (Bug#8505).
3203 (scroll_bar_width_for_theme): New variable.
3204 (update_theme_scrollbar_width): New function.
3205 (xg_get_default_scrollbar_width): Move code to
3206 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3207 (xg_initialize): Call update_theme_scrollbar_width.
3208
3209 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3210
3211 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3212
3213 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3214
3215 * frame.c (make_frame): Call other_buffer_safely instead of
3216 other_buffer.
3217
3218 * window.c (temp_output_buffer_show): Call display_buffer with
3219 second argument Vtemp_buffer_show_specifiers and reset latter
3220 immediately after the call.
3221 (Vtemp_buffer_show_specifiers): New variable.
3222 (auto_window_vscroll_p, next_screen_context_lines)
3223 (Vscroll_preserve_screen_position): Remove leading asterisks from
3224 doc-strings.
3225
3226 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3227
3228 Fix minor problems found by GCC 4.6.0 static checking.
3229 * buffer.c (Qclone_number): Remove for now, as it's unused.
3230 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3231 (record_buffer): Remove unused local.
3232 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3233 (set_frame_buffer_list): Remove; unused.
3234 * frame.h (other_visible_frames): Remove decl.
3235 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3236 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3237 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3238 if HAVE_GPM.
3239 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3240 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3241 Define only if HAVE_GPM.
3242 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3243 (update_hints_inhibit): Remove; never set. All uses removed.
3244 * widgetprv.h (emacsFrameClassRec): Remove decl.
3245 * window.c (delete_deletable_window): Now returns void, since it
3246 wasn't returning anything.
3247 (compare_window_configurations): Remove unused locals.
3248 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3249 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3250 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3251 the same widths as pointers. This follows up on the 2011-05-06 patch.
3252 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3253 * xterm.h: Likewise.
3254 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3255
3256 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3257
3258 * makefile.w32-in: Update dependencies.
3259 (LISP_H): Add lib/intprops.h.
3260
3261 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3262
3263 * image.c (gif_load): Add animation frame delay to the metadata.
3264 (syms_of_image): Use DEFSYM. New symbol `delay'.
3265
3266 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3267
3268 * window.c (delete_deletable_window): Re-add.
3269 (Fset_window_configuration): Rewrite to handle dead buffers and
3270 consequently deletable windows.
3271 (window_tree, Fwindow_tree): Remove. Supply functionality in
3272 window.el.
3273 (compare_window_configurations): Simplify code.
3274
3275 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3276
3277 * image.c (imagemagick_load_image): Fix type mismatch.
3278 (Fimagemagick_types): Likewise.
3279
3280 * window.h (replace_buffer_in_windows): Declare.
3281
3282 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3283
3284 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3285 Qclone_number. Remove external declaration of Qdelete_window.
3286 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3287 code.
3288 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3289 Run Qbuffer_list_update_hook if allowed.
3290 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3291 buffer list implementation.
3292 (other_buffer_safely): New function.
3293 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3294 calls to replace_buffer_in_windows and
3295 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3296 if allowed.
3297 (record_buffer): Inhibit quitting and rewrite using quittable
3298 functions. Run Qbuffer_list_update_hook if allowed.
3299 (Frecord_buffer, Funrecord_buffer): New functions.
3300 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3301 Move switch-to-buffer to window.el.
3302 (bury-buffer): Move to window.el.
3303 (Vbuffer_list_update_hook): New variable.
3304
3305 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3306 section.
3307
3308 * window.h (resize_frame_windows): Move up in code.
3309 (Fwindow_frame): Remove EXFUN.
3310 (replace_buffer_in_all_windows): Remove prototype.
3311 (replace_buffer_in_windows_safely): Add prototype.
3312
3313 * window.c: Declare Qdelete_window static again. Move down
3314 declaration of select_count.
3315 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3316 (Fother_window): Move to window.el.
3317 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3318 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3319 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3320 window.el.
3321 (replace_buffer_in_windows): Implement by calling
3322 Qreplace_buffer_in_windows.
3323 (replace_buffer_in_all_windows): Remove with some functionality
3324 moved into replace_buffer_in_windows_safely.
3325 (replace_buffer_in_windows_safely): New function.
3326 (select_window_norecord, select_frame_norecord): Move in front
3327 of run_window_configuration_change_hook. Remove now obsolete
3328 declarations.
3329 (Fset_window_buffer): Rewrite doc-string.
3330 Call Qrecord_window_buffer.
3331 (keys_of_window): Move binding for other-window to window.el.
3332
3333 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3334
3335 * dispextern.h (struct image): Replace data member, whose int_val
3336 and ptr_val fields were not used by anything, with a single
3337 lisp_val object.
3338
3339 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3340 (gif_clear_image, gif_load, imagemagick_load_image)
3341 (gs_clear_image, gs_load): Callers changed.
3342
3343 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3344
3345 * buffer.h: Include <time.h>, for time_t.
3346 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3347
3348 Fix minor problems found by static checking.
3349
3350 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3351
3352 Make identifiers static if they are not used in other modules.
3353 * data.c (Qcompiled_function, Qframe, Qvector):
3354 * image.c (QimageMagick, Qsvg):
3355 * minibuf.c (Qmetadata):
3356 * window.c (resize_window_check, resize_root_window): Now static.
3357 * window.h (resize_window_check, resize_root_window): Remove decls.
3358
3359 * window.c (window_deletion_count, delete_deletable_window):
3360 Remove; unused.
3361 (window_body_lines): Now static.
3362 (Fdelete_other_windows_internal): Mark vars as initialized.
3363 Make sure 'resize_failed' is initialized.
3364 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3365 (resize_window_apply): Remove unused local.
3366 * window.h (delete_deletable_window): Remove decl.
3367
3368 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3369 (imagemagick_load_image): Fix pointer signedness problem by changing
3370 last arg from unsigned char * to char *. All uses changed.
3371 Also, fix a local for similar reasons.
3372 Remove unused locals. Remove locals to avoid shadowing.
3373 (fn_rsvg_handle_free): Remove; unused.
3374 (svg_load, svg_load_image): Fix pointer signedness problem.
3375 (imagemagick_load_image): Don't use garbage pointer image_wand.
3376
3377 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3378
3379 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3380
3381 * image.c (gif_load): Fix omitted cast error introduced by
3382 2011-06-06 change.
3383
3384 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3385
3386 * window.h (resize_proportionally, orig_total_lines)
3387 (orig_top_line): Remove from window structure.
3388 (set_window_height, set_window_width, change_window_heights)
3389 (Fdelete_window): Remove prototypes.
3390 (resize_frame_windows): Remove duplicate declaration.
3391
3392 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3393
3394 * window.h (resize_frame_windows, resize_window_check)
3395 (delete_deletable_window, resize_root_window)
3396 (resize_frame_windows): Declare prototypes.
3397
3398 * window.c (resize_window_apply): Make definition be "static" to
3399 match the prototype.
3400
3401 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3402
3403 * window.c: Remove declarations of Qwindow_size_fixed,
3404 window_min_size_1, window_min_size_2, window_min_size,
3405 size_window, window_fixed_size_p, enlarge_window, delete_window.
3406 Remove static from declaration of Qdelete_window, it's
3407 temporarily needed by Fbury_buffer.
3408 (replace_window): Don't assign orig_top_line and
3409 orig_total_lines.
3410 (Fdelete_window, delete_window): Remove. Window deletion is
3411 handled by window.el.
3412 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3413 Replace Fdelete_window calls with calls to Qdelete_window.
3414 (Fdelete_other_windows): Remove. Deleting other windows is
3415 handled by window.el.
3416 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3417 handled in window.el.
3418 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3419 Window minimum sizes are handled in window.el.
3420 (shrink_windows, size_window, set_window_height)
3421 (set_window_width, change_window_heights, window_height)
3422 (window_width, CURBEG, CURSIZE, enlarge_window)
3423 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3424 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3425 handled in window.el.
3426 (make_dummy_parent): Rename to make_parent_window and give it a
3427 second argument horflag.
3428 (make_window): Don't set resize_proportionally any more.
3429 (Fsplit_window): Remove. Windows are split in window.el.
3430 (save_restore_action, save_restore_orig_size)
3431 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3432 Resize mini windows in window.el.
3433 (grow_mini_window, shrink_mini_window): Implement by calling
3434 Qresize_root_window_vertically, resize_window_check and
3435 resize_window_apply.
3436 (saved_window, Fset_window_configuration, save_window_save):
3437 Do not handle orig_top_line, orig_total_lines, and
3438 resize_proportionally.
3439 (window_min_height, window_min_width): Move to window.el.
3440 (keys_of_window): Move bindings for delete-other-windows,
3441 split-window, delete-window and enlarge-window to window.el.
3442
3443 * buffer.c: Temporarily extern Qdelete_window.
3444 (Fbury_buffer): Temporarily call Qdelete_window instead of
3445 Fdelete_window (Fbury_buffer will move to window.el soon).
3446
3447 * frame.c (set_menu_bar_lines_1): Remove code handling
3448 orig_top_line and orig_total_lines.
3449
3450 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3451 set_window_height but set heights directly.
3452 (change_frame_size_1): Use resize_frame_windows.
3453
3454 * xdisp.c (init_xdisp): Don't use set_window_height but set
3455 heights directly.
3456
3457 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3458 Use resize_frame_windows instead of change_window_heights and run
3459 run_window_configuration_change_hook.
3460
3461 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3462 instead of change_window_heights and run
3463 run_window_configuration_change_hook.
3464
3465 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3466
3467 * window.c (replace_window): Rename second argument REPLACEMENT to
3468 NEW. New third argument SETFLAG. Rewrite.
3469 (delete_window, make_dummy_parent): Call replace_window with
3470 third argument 1.
3471 (window_list_1): Move down in code.
3472 (run_window_configuration_change_hook): Move set_buffer part
3473 before select_frame_norecord part in order to unwind correctly.
3474 Rename count1 to count.
3475 (recombine_windows, delete_deletable_window, resize_root_window)
3476 (Fdelete_other_windows_internal)
3477 (Frun_window_configuration_change_hook, make_parent_window)
3478 (resize_window_check, resize_window_apply, Fresize_window_apply)
3479 (resize_frame_windows, Fsplit_window_internal)
3480 (Fdelete_window_internal, Fresize_mini_window_internal):
3481 New functions.
3482 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3483
3484 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3485
3486 * window.h (window): Add some new members to window structure -
3487 normal_lines, normal_cols, new_total, new_normal, clone_number,
3488 splits, nest, prev_buffers, next_buffers.
3489 (WINDOW_TOTAL_SIZE): Move here from window.c.
3490 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3491
3492 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3493 Remove.
3494 (make_dummy_parent): Set new members of windows structure.
3495 (make_window): Move down in code. Handle new members of window
3496 structure.
3497 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3498 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3499 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3500 (Fset_window_prev_buffers, Fwindow_next_buffers)
3501 (Fset_window_next_buffers, Fset_window_clone_number):
3502 New functions.
3503 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3504 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3505 Doc-string fixes.
3506 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3507 Argument WINDOW can be now internal window too.
3508 (Fwindow_use_time): Move up in code.
3509 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3510 Rewrite doc-string.
3511 (Fset_window_configuration, saved_window)
3512 (Fcurrent_window_configuration, save_window_save): Handle new
3513 members of window structure.
3514 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3515 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3516 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3517 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3518 Qget_mru_window, Qresize_root_window,
3519 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3520 Qauto_buffer_name; staticpro them.
3521
3522 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3523
3524 * window.c (Fwindow_total_size, Fwindow_left_column)
3525 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3526 (Fwindow_list_1): New functions.
3527 (window_box_text_cols): Replace with window_body_cols.
3528 (Fwindow_width, Fscroll_left, Fscroll_right):
3529 Use window_body_cols instead of window_box_text_cols.
3530 (delete_window, Fset_window_configuration):
3531 Call delete_all_subwindows with window as argument.
3532 (delete_all_subwindows): Take a window as argument and not a
3533 structure. Rewrite.
3534 (window_loop): Remove handling of GET_LRU_WINDOW and
3535 GET_LARGEST_WINDOW.
3536 (Fget_lru_window, Fget_largest_window): Move to window.el.
3537
3538 * window.h: Extern window_body_cols instead of
3539 window_box_text_cols. delete_all_subwindows now takes a
3540 Lisp_Object as argument.
3541
3542 * indent.c (compute_motion, Fcompute_motion):
3543 Use window_body_cols instead of window_box_text_cols.
3544
3545 * frame.c (delete_frame): Call delete_all_subwindows with root
3546 window as argument.
3547
3548 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3549
3550 * fns.c (Fputhash): Document return value.
3551
3552 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3553
3554 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3555
3556 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3557
3558 Cons<->int and similar integer overflow fixes (Bug#8794).
3559
3560 Check for overflow when converting integer to cons and back.
3561 * charset.c (Fdefine_charset_internal, Fdecode_char):
3562 Use cons_to_unsigned to catch overflow.
3563 (Fencode_char): Use INTEGER_TO_CONS.
3564 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3565 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3566 * data.c (long_to_cons, cons_to_long): Remove.
3567 (cons_to_unsigned, cons_to_signed): New functions.
3568 These signal an error for invalid or out-of-range values.
3569 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3570 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3571 * font.c (Ffont_variation_glyphs):
3572 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3573 * lisp.h: Include <intprops.h>.
3574 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3575 (cons_to_signed, cons_to_unsigned): New decls.
3576 (long_to_cons, cons_to_long): Remove decls.
3577 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3578 (Fprimitive_undo): Use CONS_TO_INTEGER.
3579 * xfns.c (Fx_window_property): Likewise.
3580 * xselect.c: Include <limits.h>.
3581 (x_own_selection, selection_data_to_lisp_data):
3582 Use INTEGER_TO_CONS.
3583 (x_handle_selection_request, x_handle_selection_clear)
3584 (x_get_foreign_selection, Fx_disown_selection_internal)
3585 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3586 (lisp_data_to_selection_data): Use cons_to_unsigned.
3587 (x_fill_property_data): Use cons_to_signed.
3588 Report values out of range.
3589
3590 Check for buffer and string overflow more precisely.
3591 * buffer.h (BUF_BYTES_MAX): New macro.
3592 * lisp.h (STRING_BYTES_MAX): New macro.
3593 * alloc.c (Fmake_string):
3594 * character.c (string_escape_byte8):
3595 * coding.c (coding_alloc_by_realloc):
3596 * doprnt.c (doprnt):
3597 * editfns.c (Fformat):
3598 * eval.c (verror):
3599 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3600 since they may not be the same number.
3601 * editfns.c (Finsert_char):
3602 * fileio.c (Finsert_file_contents):
3603 Likewise for BUF_BYTES_MAX.
3604
3605 * image.c: Use ptrdiff_t, not int, for sizes.
3606 (slurp_file): Switch from int to ptrdiff_t.
3607 All uses changed.
3608 (slurp_file): Check that file size fits in both size_t (for
3609 malloc) and ptrdiff_t (for sanity and safety).
3610
3611 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3612 if b->modtime has its maximal value.
3613
3614 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3615
3616 Don't assume time_t can fit into int.
3617 * buffer.h (struct buffer.modtime): Now time_t, not int.
3618 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3619 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3620
3621 Minor fixes for signed vs unsigned integers.
3622 * character.h (MAYBE_UNIFY_CHAR):
3623 * charset.c (maybe_unify_char):
3624 * keyboard.c (read_char, reorder_modifiers):
3625 XINT -> XFASTINT, since the integer must be nonnegative.
3626 * ftfont.c (ftfont_spec_pattern):
3627 * keymap.c (access_keymap, silly_event_symbol_error):
3628 XUINT -> XFASTINT, since the integer must be nonnegative.
3629 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3630 since it makes no difference and we prefer signed.
3631 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3632 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3633 nonnegative.
3634
3635 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3636
3637 * window.h (Fwindow_frame): Declare.
3638
3639 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3640
3641 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3642 (SPARE_MEMORY): Always define.
3643 (LARGE_REQUEST): Remove.
3644 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3645
3646 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3647
3648 * lisp.h: Move EXFUNS for Fframe_root_window,
3649 Fframe_first_window and Fset_frame_selected_window to window.h.
3650
3651 * window.h: Move EXFUNS for Fframe_root_window,
3652 Fframe_first_window and Fset_frame_selected_window here from
3653 lisp.h.
3654
3655 * frame.c (Fwindow_frame, Fframe_first_window)
3656 (Fframe_root_window, Fframe_selected_window)
3657 (Fset_frame_selected_window): Move to window.c.
3658 (Factive_minibuffer_window): Move to minibuf.c.
3659 (Fother_visible_frames_p): New function.
3660
3661 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3662
3663 * window.c (decode_window, decode_any_window): Move up in code.
3664 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3665 (inhibit_frame_unsplittable): Remove unused variable.
3666 (Fwindow_buffer): Move up and rewrite doc-string.
3667 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3668 (Fwindow_prev): New functions.
3669 (Fwindow_frame): Move here from frame.c. Accept any window as
3670 argument.
3671 (Fframe_root_window, Fframe_first_window)
3672 (Fframe_selected_window): Move here from frame.c. Accept frame
3673 or arbitrary window as argument. Update doc-strings.
3674 (Fminibuffer_window): Move up in code.
3675 (Fwindow_minibuffer_p): Move up in code and simplify.
3676 (Fset_frame_selected_window): Move here from frame.c.
3677 Marginal rewrite.
3678 (Fselected_window, select_window, Fselect_window): Move up in
3679 code. Minor doc-string fixes.
3680
3681 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3682
3683 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3684 Do not assume that spare memory exists; that assumption is valid
3685 only if SYSTEM_MALLOC.
3686 (LARGE_REQUEST): New macro, so that the issue of large requests
3687 is separated from the issue of spare memory.
3688
3689 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3690
3691 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3692 format. (Bug#8806)
3693
3694 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3695
3696 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3697 before statements.
3698
3699 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3700
3701 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3702
3703 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3704
3705 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3706 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3707
3708 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3709
3710 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3711
3712 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3713
3714 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3715 (x_clipboard_manager_save): Add return value.
3716 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3717 New error handlers.
3718 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3719 Obey Vx_select_enable_clipboard_manager. Catch errors in
3720 x_clipboard_manager_save (Bug#8779).
3721 (Vx_select_enable_clipboard_manager): New variable.
3722 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3723
3724 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3725
3726 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3727
3728 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3729
3730 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3731 in the current matrix if keep_current_p is non-zero.
3732
3733 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3734
3735 * bidi.c (bidi_level_of_next_char): Fix last change.
3736
3737 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3738
3739 Support bidi reordering of text covered by display properties.
3740
3741 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3742 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3743 (bidi_cache_search, bidi_cache_iterator_state)
3744 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3745 (bidi_level_of_next_char, bidi_move_to_visually_next):
3746 Support character positions inside a run of characters covered by a
3747 display string.
3748 (bidi_paragraph_init, bidi_resolve_explicit_1)
3749 (bidi_level_of_next_char): Call bidi_fetch_char and
3750 bidi_fetch_char_advance instead of FETCH_CHAR and
3751 FETCH_CHAR_ADVANCE.
3752 (bidi_init_it): Initialize new members.
3753 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3754 definitions.
3755 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3756 instead of using explicit *_CHAR codes.
3757 (bidi_resolve_explicit, bidi_resolve_weak):
3758 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3759 bidirectional text is supported only in multibyte buffers.
3760 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3761 it to initialize the frame_window_p member of struct bidi_it.
3762 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3763 (bidi_resolve_explicit, bidi_resolve_weak)
3764 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3765 bidi_it->nchars is non-positive.
3766 (bidi_level_of_next_char): Don't try to lookup the cache for the
3767 next/previous character if nothing is cached there yet, or if we
3768 were just reseat()'ed to a new position.
3769
3770 * xdisp.c (set_cursor_from_row): Set start and stop points
3771 according to the row's direction when priming the loop that looks
3772 for the glyph on which to display cursor.
3773 (single_display_spec_intangible_p): Function deleted.
3774 (display_prop_intangible_p): Reimplement to call
3775 handle_display_spec instead of single_display_spec_intangible_p.
3776 Accept 3 additional arguments needed by handle_display_spec.
3777 This fixes incorrect cursor motion across display property with complex
3778 values: lists, `(when COND...)' forms, etc.
3779 (single_display_spec_string_p): Support property values that are
3780 lists with the argument STRING its top-level element.
3781 (display_prop_string_p): Fix the condition for processing a
3782 property that is a list to be consistent with handle_display_spec.
3783 (handle_display_spec): New function, refactored from the
3784 last portion of handle_display_prop.
3785 (compute_display_string_pos): Accept additional argument
3786 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3787 value of a `display' property is a "replacing spec".
3788 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3789 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3790 the display property, but just return a value indicating whether
3791 the display property will replace the characters it covers.
3792 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3793 frame_window_p members of struct bidi_it.
3794 (compute_display_string_pos, compute_display_string_end):
3795 New functions.
3796 (push_it): Accept second argument POSITION, where pop_it should
3797 jump to continue iteration.
3798 (reseat_1): Initialize bidi_it.disp_pos.
3799
3800 * keyboard.c (adjust_point_for_property): Adjust the call to
3801 display_prop_intangible_p to its new signature.
3802
3803 * dispextern.h (struct bidi_it): New member frame_window_p.
3804 (bidi_init_it): Update prototypes.
3805 (display_prop_intangible_p): Update prototype.
3806 (compute_display_string_pos, compute_display_string_end):
3807 Declare prototypes.
3808 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3809 EMACS_INT.
3810
3811 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3812
3813 Malloc failure behavior now depends on size of allocation.
3814 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3815 * lisp.h: Change signatures accordingly.
3816 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3817 All callers changed. (Bug#8762)
3818
3819 * gnutls.c: Use Emacs's memory allocators.
3820 Without this change, the gnutls library would invoke malloc etc.
3821 directly, which causes problems on non-SYNC_INPUT hosts, and which
3822 runs afoul of improving memory_full behavior. (Bug#8761)
3823 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3824 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3825 xfree instead of the default malloc, realloc, free.
3826 (Fgnutls_boot): No need to check for memory allocation failure,
3827 since xmalloc does that for us.
3828
3829 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3830 * category.c (hash_get_category_set):
3831 * ccl.c (ccl_driver):
3832 * charset.c (Fdefine_charset_internal):
3833 * charset.h (struct charset.hash_index):
3834 * composite.c (get_composition_id, gstring_lookup_cache)
3835 (composition_gstring_put_cache):
3836 * composite.h (struct composition.hash_index):
3837 * dispextern.h (struct image.hash):
3838 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3839 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3840 (hashfn_equal, hashfn_user_defined, make_hash_table)
3841 (maybe_resize_hash_table, hash_lookup, hash_put)
3842 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3843 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3844 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3845 * image.c (make_image, search_image_cache, lookup_image)
3846 (xpm_put_color_table_h):
3847 * lisp.h (struct Lisp_Hash_Table):
3848 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3849 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3850 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3851 * alloc.c (allocate_vectorlike):
3852 Check for overflow in vector size calculations.
3853 * ccl.c (ccl_driver):
3854 Check for overflow when converting EMACS_INT to int.
3855 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3856 need to be updated by these changes.
3857 * fns.c (make_hash_table, maybe_resize_hash_table):
3858 Check for integer overflow with large hash tables.
3859 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3860 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3861 (SXHASH_REDUCE): New macro.
3862 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3863 Use it instead of discarding useful hash info with large hash values.
3864 (sxhash_float): New function.
3865 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3866 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3867 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3868 Rewrite to use FIXNUM_BITS, as this simplifies things.
3869 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3870 Adjust signatures to match updated version of code.
3871 (consing_since_gc): Now EMACS_INT, since a single hash table can
3872 use more than INT_MAX bytes.
3873
3874 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3875
3876 Make it possible to build with GCC-4.6+ -O2 -flto.
3877
3878 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3879
3880 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3881
3882 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3883 Call minibuffer-inactive-mode.
3884
3885 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3886
3887 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3888 Update dependencies.
3889
3890 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3891
3892 * data.c (init_data): Remove code for UTS, this system is not
3893 supported anymore.
3894
3895 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3896
3897 Don't force ./temacs to start in terminal mode.
3898
3899 * frame.c (make_initial_frame): Initialize faces in all cases, not
3900 only when CANNOT_DUMP is defined.
3901 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3902
3903 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3904
3905 * dispnew.c (add_window_display_history): Use const for the string
3906 pointer. Remove declaration, not needed.
3907
3908 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3909
3910 Use 'inline', not 'INLINE'.
3911 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3912 * alloc.c, fontset.c (INLINE): Remove.
3913 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3914 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3915 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3916 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3917 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3918
3919 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3920
3921 Make it possible to run ./temacs.
3922
3923 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3924 syms_of_callproc does the same thing. Remove test for
3925 "initialized", do it in the caller.
3926 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3927
3928 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3929
3930 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3931 (read_minibuf): Use get_minibuffer.
3932 (syms_of_minibuf): Use DEFSYM.
3933 (Qmetadata): New var.
3934 * data.c (Qbuffer): Don't make it static.
3935 (syms_of_data): Use DEFSYM.
3936
3937 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3938
3939 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3940 (CCL_CODE_MIN): New macro.
3941
3942 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3943
3944 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3945
3946 * eval.c (Qdebug): Now static.
3947 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3948 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3949 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3950
3951 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3952
3953 * image.c: Various fixes to ImageMagick code comments.
3954 (Fimagemagick_types): Doc fix.
3955
3956 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3957
3958 Minor fixes prompted by GCC 4.6.0 warnings.
3959
3960 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3961
3962 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3963 (x_clipboard_manager_save_all): Move extern decl to ...
3964 * xterm.h: ... here, so that it can be checked for consistency.
3965
3966 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3967
3968 * xselect.c (x_clipboard_manager_save_frame)
3969 (x_clipboard_manager_save_all): New functions.
3970 (Fx_clipboard_manager_save): Lisp function deleted.
3971
3972 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3973 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3974
3975 * xterm.h: Update prototype.
3976
3977 2011-05-28 William Xu <william.xwl@gmail.com>
3978
3979 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3980 exiting (Bug#8239).
3981
3982 2011-05-28 Jim Meyering <meyering@redhat.com>
3983
3984 Avoid a sign-extension bug in crypto_hash_function.
3985 * fns.c (to_uchar): Define.
3986 (crypto_hash_function): Use it to convert some newly-signed
3987 variables to unsigned, to avoid sign-extension bugs. For example,
3988 without this change, (md5 "truc") would evaluate to
3989 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3990 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3991 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3992
3993 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3994
3995 Integer overflow fixes.
3996
3997 * dbusbind.c: Serial number integer overflow fixes.
3998 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3999 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4000 to hold a serial number that is too large for a fixnum.
4001 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4002 Check for serial numbers out of range. Decode any serial number
4003 that was so large that it became a float. (Bug#8722)
4004
4005 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4006 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4007 Use XFASTINT rather than XUINT when numbers are nonnegative.
4008 (xd_append_arg, Fdbus_method_return_internal):
4009 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4010 arguments, check that Lisp number is nonnegative, rather than
4011 silently wrapping negative numbers around. (Bug#8722)
4012 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4013 (Bug#8722)
4014
4015 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4016
4017 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4018
4019 ccl: add integer overflow checks
4020 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4021 (IN_INT_RANGE): New macros.
4022 (ccl_driver): Use them to check for integer overflow when
4023 decoding a CCL program. Many of the new checks are whether XINT (x)
4024 fits in int; it doesn't always, on 64-bit hosts. The new version
4025 doesn't catch all possible integer overflows, but it's an
4026 improvement. (Bug#8719)
4027
4028 * alloc.c (make_event_array): Use XINT, not XUINT.
4029 There's no need for unsigned here.
4030
4031 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4032 This follows up to the 2011-05-06 change that substituted uintptr_t
4033 for EMACS_INT. This case wasn't caught back then.
4034
4035 Rework Fformat to avoid integer overflow issues.
4036 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4037 now (part of C89). Include <verify.h>.
4038 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4039 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4040 (Fformat): Avoid the prepass trying to compute sizes; it was only
4041 approximate and thus did not catch overflow reliably. Instead, walk
4042 through the format just once, formatting and computing sizes as we go,
4043 checking for integer overflow at every step, and allocating a larger
4044 buffer as needed. Keep track separately whether the format is
4045 multibyte. Keep only the most-recently calculated precision, rather
4046 than them all. Record whether each argument has been converted to
4047 string. Use EMACS_INT, not int, for byte and char and arg counts.
4048 Support field widths and precisions larger than INT_MAX. Avoid
4049 sprintf's undefined behavior with conversion specifications such as %#d
4050 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4051 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4052 formatting out-of-range floating point numbers with int
4053 formats. (Bug#8668)
4054
4055 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4056
4057 * data.c: Avoid integer truncation in expressions involving floats.
4058 * data.c: Include <intprops.h>.
4059 (arith_driver): When there's an integer overflow in an expression
4060 involving floating point, convert the integers to floating point
4061 so that the resulting value does not suffer from catastrophic
4062 integer truncation. For example, on a 64-bit host (* 4
4063 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4064 Do not rely on undefined behavior after integer overflow.
4065
4066 merge count_size_as_multibyte, parse_str_to_multibyte
4067 * character.c, character.h (count_size_as_multibyte):
4068 Rename from parse_str_to_multibyte; all uses changed.
4069 Check for integer overflow.
4070 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4071 since it's now a duplicate of the other. This is more of
4072 a character than a buffer op, so better that it's in character.c.
4073 * fns.c, print.c: Adjust to above changes.
4074
4075 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4076
4077 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4078
4079 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4080
4081 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4082 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4083 (x_clipboard_manager_save): Now static.
4084 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4085
4086 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4087 (crypto_hash_function): Now static.
4088 Fix pointer signedness problems. Avoid unnecessary initializations.
4089
4090 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4091
4092 * termhooks.h (Vselection_alist): Make it terminal-local.
4093
4094 * terminal.c (create_terminal): Initialize it.
4095
4096 * xselect.c: Support for clipboard managers.
4097 (Vselection_alist): Move to termhooks.h as terminal-local var.
4098 (LOCAL_SELECTION): New macro.
4099 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4100 (symbol_to_x_atom): Remove gratuitous arg.
4101 (x_handle_selection_request, lisp_data_to_selection_data)
4102 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4103 (x_own_selection, x_get_local_selection, x_convert_selection):
4104 New arg, specifying work frame. Use terminal-local Vselection_alist.
4105 (some_frame_on_display): Delete unused function.
4106 (Fx_own_selection_internal, Fx_get_selection_internal)
4107 (Fx_disown_selection_internal, Fx_selection_owner_p)
4108 (Fx_selection_exists_p): New optional frame arg.
4109 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4110 (x_handle_selection_clear): Don't treat other terminals with the
4111 same keyboard specially. Use the terminal-local Vselection_alist.
4112 (x_clear_frame_selections): Use Frun_hook_with_args.
4113
4114 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4115
4116 * xterm.h: Add support for those atoms.
4117
4118 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4119
4120 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4121 (converted_selections, conversion_fail_tag): New global variables.
4122 (x_selection_request_lisp_error): Free the above.
4123 (x_get_local_selection): Remove unnecessary code.
4124 (x_reply_selection_request): Args changed; handle arbitrary array
4125 of converted selections stored in converted_selections.
4126 Separate the XChangeProperty and SelectionNotify steps.
4127 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4128 (x_convert_selection): New function.
4129 (x_handle_selection_event): Simplify.
4130 (x_get_foreign_selection): Don't ignore incoming requests while
4131 waiting for an answer; this will fail when we implement
4132 SAVE_TARGETS, and seems unnecessary anyway.
4133 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4134 (Vx_sent_selection_functions): Doc fix.
4135
4136 2011-05-26 Leo Liu <sdl.web@gmail.com>
4137
4138 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4139
4140 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4141
4142 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4143
4144 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4145 for fringe update if it has periodic bitmap.
4146 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4147 and fringe_bitmap_periodic_p.
4148
4149 * fringe.c (get_fringe_bitmap_data): New function.
4150 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4151 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4152 row. Mark glyph row for fringe update if periodicity changed.
4153
4154 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4155 for fringe update unless it has periodic bitmap.
4156
4157 2011-05-25 Kenichi Handa <handa@m17n.org>
4158
4159 * xdisp.c (get_next_display_element): Set correct it->face_id for
4160 a static composition.
4161
4162 2011-05-24 Leo Liu <sdl.web@gmail.com>
4163
4164 * deps.mk (fns.o):
4165 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4166
4167 * fns.c (crypto_hash_function, Fsha1): New function.
4168 (Fmd5): Use crypto_hash_function.
4169 (syms_of_fns): Add Ssha1.
4170
4171 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4172
4173 * gnutls.c: Remove unused macros.
4174 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4175 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4176 Remove macros that are defined and never used.
4177 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4178
4179 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4180
4181 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4182 (Fx_get_selection_internal): Minor cleanup.
4183 (Fx_own_selection_internal): Rename arguments for consistency with
4184 select.el.
4185
4186 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4187
4188 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4189
4190 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4191
4192 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4193
4194 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4195
4196 * dispnew.c (scrolling_window): Don't exclude the case that the
4197 last enabled row in the desired matrix touches the bottom boundary.
4198
4199 2011-05-21 Glenn Morris <rgm@gnu.org>
4200
4201 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4202 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4203 and add some more files.
4204
4205 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4206
4207 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4208 report_file_error introduced by the change from 2011-05-07.
4209
4210 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4211
4212 * systime.h (Time): Define only if emacs is defined.
4213 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4214 where the include path doesn't have X11/X.h by default. See
4215 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4216
4217 2011-05-20 Kenichi Handa <handa@m17n.org>
4218
4219 * composite.c (find_automatic_composition): Fix previous change.
4220
4221 2011-05-20 Glenn Morris <rgm@gnu.org>
4222
4223 * lisp.mk: New file, split from Makefile.in.
4224 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4225 (shortlisp): Remove.
4226 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4227
4228 2011-05-19 Glenn Morris <rgm@gnu.org>
4229
4230 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4231 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4232 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4233 (lisp): Set the order to that of loadup.el.
4234 (shortlisp): Make it a copy of $lisp.
4235 (SOME_MACHINE_LISP): Remove.
4236 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4237 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4238
4239 2011-05-18 Kenichi Handa <handa@m17n.org>
4240
4241 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4242 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4243 (find_automatic_composition): Mostly rewrite for efficiency.
4244
4245 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4246
4247 * makefile.w32-in: Update dependencies.
4248
4249 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4250
4251 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4252 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4253
4254 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4255
4256 Fix some integer overflow issues, such as string length overflow.
4257
4258 * insdel.c (count_size_as_multibyte): Check for string overflow.
4259
4260 * character.c (lisp_string_width): Check for string overflow.
4261 Use EMACS_INT, not int, for string indexes and lengths; in
4262 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4263 the resulting string length overflows an EMACS_INT; instead,
4264 report a string overflow if no precision given. When checking for
4265 precision exhaustion, use a check that cannot possibly have
4266 integer overflow. (Bug#8675)
4267 * character.h (lisp_string_width): Adjust to new signature.
4268
4269 * alloc.c (string_overflow): New function.
4270 (Fmake_string): Use it. This doesn't change behavior, but saves
4271 a few bytes and will simplify future changes.
4272 * character.c (string_escape_byte8): Likewise.
4273 * lisp.h (string_overflow): New decl.
4274
4275 Fixups, following up to the user-interface timestamp change.
4276 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4277 for UI timestamps, instead of unsigned long.
4278 * msdos.c (mouse_get_pos): Likewise.
4279 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4280 * w32gui.h (Time): Define by including "systime.h" rather than by
4281 declaring it ourselves. (Bug#8664)
4282
4283 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4284 * image.c (clear_image_cache): Likewise.
4285
4286 * term.c (term_mouse_position): Don't assume time_t wraparound.
4287
4288 Be more systematic about user-interface timestamps.
4289 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4290 and sometimes 'EMACS_UINT', to represent these timestamps.
4291 This change causes it to use 'Time' uniformly, as that's what X uses.
4292 This makes the code easier to follow, and makes it easier to catch
4293 integer overflow bugs such as Bug#8664.
4294 * frame.c (Fmouse_position, Fmouse_pixel_position):
4295 Use Time, not unsigned long, for user-interface timestamps.
4296 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4297 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4298 * keyboard.h (last_event_timestamp): Likewise.
4299 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4300 * menu.h (xmenu_show): Likewise.
4301 * term.c (term_mouse_position): Likewise.
4302 * termhooks.h (struct input_event.timestamp): Likewise.
4303 (struct terminal.mouse_position_hook): Likewise.
4304 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4305 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4306 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4307 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4308 what it was before.
4309 * menu.h, termhooks.h: Include "systime.h", for Time.
4310
4311 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4312 Don't assume that the difference between two unsigned long values
4313 can fit into an integer. At this point, we know button_down_time
4314 <= event->timestamp, so the difference must be nonnegative, so
4315 there's no need to cast the result if double-click-time is
4316 nonnegative, as it should be; check that it's nonnegative, just in
4317 case. This bug is triggered when events are more than 2**31 ms
4318 apart (about 25 days). (Bug#8664)
4319
4320 * xselect.c (last_event_timestamp): Remove duplicate decl.
4321 (x_own_selection): Remove needless cast to unsigned long.
4322
4323 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4324 that always fit in int. Use a sentinel instead of a counter, to
4325 avoid a temp and to allay GCC's concerns about possible int overflow.
4326 * frame.h (struct frame): Use int for menu_bar_items_used
4327 instead of EMACS_INT, since it always fits in int.
4328
4329 * menu.c (grow_menu_items): Check for int overflow.
4330
4331 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4332
4333 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4334 Before, the code was not consistent. These values cannot exceed
4335 2**31 - 1 so there's no need to make them unsigned.
4336 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4337 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4338 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4339 as modifiers.
4340 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4341
4342 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4343 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4344 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4345 presumably because the widths might not match.
4346
4347 * window.c (size_window): Avoid needless test at loop start.
4348
4349 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4350
4351 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4352
4353 2011-05-12 Drew Adams <drew.adams@oracle.com>
4354
4355 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4356
4357 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4358
4359 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4360 `width' to `bar_area_x' and `bar_area_width', respectively.
4361 (x_scroll_run): Take account of fringe background extension.
4362
4363 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4364 Rename local vars `left' and `width' to `bar_area_x' and
4365 `bar_area_width', respectively.
4366 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4367 background extension.
4368
4369 2011-05-10 Jim Meyering <meyering@redhat.com>
4370
4371 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4372
4373 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4374
4375 * image.c (Finit_image_library): Return t for built-in image types,
4376 like pbm and xbm. (Bug#8640)
4377
4378 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4379
4380 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4381
4382 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4383
4384 * w32console.c (Fset_screen_color): Doc fix.
4385 (Fget_screen_color): New function.
4386 (syms_of_ntterm): Defsubr it.
4387
4388 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4389 unlink the temporary file if Fcall_process didn't create it in the
4390 first place.
4391 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4392 child process will be redirected to a file specified with `:file'.
4393 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4394 cue to call_process_cleanup not to close that handle.
4395
4396 2011-05-07 Ben Key <bkey76@gmail.com>
4397
4398 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4399 one of two shell specific rules, either bootstrap-temacs-CMD or
4400 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4401 to the previous implementation of the bootstrap-temacs rule.
4402 The bootstrap-temacs-CMD rule is similar to the previous
4403 implementation of the bootstrap-temacs rule except that it
4404 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4405 variable.
4406
4407 These changes, along with some changes to nt/configure.bat,
4408 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4409 earlier fix to add support for --cflags and --ldflags options
4410 that include quotes so that it works whether make uses cmd or
4411 sh as the shell.
4412
4413 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4414
4415 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4416 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4417 is a constant.
4418 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4419 a string. Handle both cases.
4420 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4421 (Fdbus_register_method): Use Qinvalid_function.
4422
4423 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4424
4425 * makefile.w32-in: Update dependencies.
4426 (LISP_H): Add inttypes.h and stdin.h.
4427 (PROCESS_H): Add unistd.h.
4428
4429 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4430
4431 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4432 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4433
4434 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4435
4436 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4437
4438 * term.c (vfatal): Remove stray call to va_end.
4439 It's not needed and the C Standard doesn't allow it here anyway.
4440
4441 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4442 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4443
4444 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4445 bytes.
4446
4447 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4448
4449 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4450
4451 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4452
4453 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4454
4455 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4456
4457 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4458 * charset.c (Fdefine_charset_internal): Don't initialize
4459 charset.code_space[15]. The value was garbage, on hosts with
4460 32-bit int (Bug#8600).
4461
4462 * lread.c (read_integer): Be more consistent with string-to-number.
4463 Use string_to_number to do the actual conversion; this avoids
4464 rounding errors and fixes some other screwups. Without this fix,
4465 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4466 (digit_to_number): Move earlier, for benefit of read_integer.
4467 Return -1 if the digit is out of range for the base, -2 if it is
4468 not a digit in any supported base. (Bug#8602)
4469
4470 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4471
4472 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4473 to match comment at start of function. This also removes a
4474 GCC warning about overflow in a 32+64-bit port.
4475
4476 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4477
4478 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4479 Reported by Stefan Monnier in
4480 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4481 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4482 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4483
4484 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4485 (EMACS_UINTPTR): Likewise, with uintptr_t.
4486
4487 * lisp.h: Prefer 64-bit EMACS_INT if available.
4488 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4489 on 32-bit hosts that have 64-bit int, so that they can access
4490 large files.
4491 However, temporarily disable this change unless the temporary
4492 symbol WIDE_EMACS_INT is defined.
4493
4494 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4495
4496 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4497 This removes an assumption that EMACS_INT and long are the same
4498 width as pointers. The assumption is true for Emacs porting targets
4499 now, but we want to make other targets possible.
4500 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4501 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4502 In the rest of the code, change types of integers that hold casted
4503 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4504 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4505 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4506 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4507 No need to cast type when ORing.
4508 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4509 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4510 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4511 assume EMACS_INT is the same width as char *.
4512 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4513 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4514 Remove no-longer-needed casts.
4515 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4516 (xg_tool_bar_help_callback, xg_make_tool_item):
4517 Use EMACS_INTPTR to hold an integer
4518 that will be cast to void *; this can avoid a GCC warning
4519 if EMACS_INT is not the same width as void *.
4520 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4521 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4522 (current_message_1, set_message_1):
4523 Use a local to convert to proper width without a cast.
4524 * xmenu.c (dialog_selection_callback): Likewise.
4525
4526 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4527 Also, don't assume VALBITS / RAND_BITS is less than 5,
4528 and don't rely on undefined behavior when shifting a 1 left into
4529 the sign bit.
4530 * lisp.h (get_random): Change signature to match.
4531
4532 * lread.c (hash_string): Use size_t, not int, for hash computation.
4533 Normally we prefer signed values; but hashing is special, because
4534 it's better to use unsigned division on hash table sizes so that
4535 the remainder is nonnegative. Also, size_t is the natural width
4536 for hashing into memory. The previous code used 'int', which doesn't
4537 retain enough info to hash well into very large tables.
4538 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4539
4540 * dbusbind.c: Don't possibly lose pointer info when converting.
4541 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4542 Use XPNTR rather than XHASH, so that the high-order bits of
4543 the pointer aren't lost when converting through void *.
4544
4545 * eval.c (Fautoload): Don't double-shift a pointer.
4546
4547 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4548
4549 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4550
4551 * gnutls.c (DEF_GNUTLS_FN):
4552 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4553
4554 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4555
4556 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4557 marker. (Bug#8610)
4558
4559 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4560
4561 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4562 New version that can reserve upto 2GB of heap space.
4563
4564 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4565
4566 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4567
4568 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4569
4570 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4571 `gnutls_certificate_set_x509_key_file'.
4572
4573 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4574
4575 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4576 Update dependencies.
4577
4578 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4579
4580 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4581 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4582 Remove unused parameter `fildes'.
4583 * process.c (read_process_output, send_process): Don't pass it.
4584
4585 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4586
4587 Fix previous change: the library cache is defined in w32.c.
4588 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4589 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4590
4591 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4592
4593 Implement dynamic loading of GnuTLS on Windows.
4594
4595 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4596 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4597 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4598 Declare.
4599
4600 * gnutls.c (Qgnutls_dll): Define.
4601 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4602 (gnutls_*): Declare function pointers.
4603 (init_gnutls_functions): New function to initialize function pointers.
4604 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4605 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4606 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4607 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4608 (emacs_gnutls_write, emacs_gnutls_read)
4609 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4610 (Fgnutls_available_p): New function.
4611 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4612 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4613 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4614
4615 * image.c: Include w32.h.
4616 (Vimage_type_cache): Delete.
4617 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4618 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4619 (w32_delayed_load): Move to w32.c.
4620
4621 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4622
4623 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4624 (w32_delayed_load): Move from image.c. When loading a library, record
4625 its filename in the :loaded-from property of the library id.
4626 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4627 Initialize and staticpro them.
4628 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4629
4630 * process.c: Include lisp.h before w32.h, not after.
4631 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4632 instead of gnutls_record_check_pending.
4633
4634 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4635
4636 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4637
4638 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4639 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4640 as passed in.
4641
4642 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4643
4644 * xterm.c (x_set_frame_alpha): Do not set property on anything
4645 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4646
4647 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4648
4649 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4650
4651 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4652
4653 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4654 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4655 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4656 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4657 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4658 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4659 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4660 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4661 (Qgnutls_bootprop_callbacks_verify): Make static.
4662
4663 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4664
4665 * callproc.c: Indentation fixup.
4666
4667 * sysdep.c (wait_for_termination_1): Make static.
4668 (wait_for_termination, interruptible_wait_for_termination):
4669 Move after wait_for_termination_1.
4670
4671 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4672
4673 * sysdep.c (interruptible_wait_for_termination): New function
4674 which is like wait_for_termination, but allows keyboard
4675 interruptions.
4676
4677 * callproc.c (Fcall_process): Add (:file "file") as an option for
4678 the STDOUT buffer.
4679 (Fcall_process_region): Ditto.
4680
4681 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4682
4683 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4684 rather than `XVECTOR (FOO)->size'.
4685
4686 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4687 inttypes.h, as a gnulib replacement is used if it not available in
4688 system headers.
4689
4690 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4691
4692 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4693 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4694 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4695
4696 * coding.c (coding_alloc_by_realloc): Error out if destination
4697 will grow beyond MOST_POSITIVE_FIXNUM.
4698 (decode_coding_emacs_mule): Abort if there isn't enough place in
4699 charbuf for the composition carryover bytes. Reserve an extra
4700 space for up to 2 characters produced in a loop.
4701 (decode_coding_iso_2022): Abort if there isn't enough place in
4702 charbuf for the composition carryover bytes.
4703
4704 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4705
4706 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4707 aborting when %lld or %lll format is passed.
4708 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4709 %llo or %llx format is passed. (Bug#8545)
4710
4711 * window.c (window_scroll_line_based): Use a marker instead of
4712 simple variables to record original value of point. (Bug#7952)
4713
4714 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4715 produced by %s or %c overflows available buffer space. (Bug#8545)
4716
4717 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4718
4719 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4720 (SIZE_MAX): Move defn after all includes, as they might #define it.
4721
4722 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4723
4724 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4725
4726 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4727
4728 * keyboard.c (Qdelayed_warnings_hook): Define.
4729 (command_loop_1): Run `delayed-warnings-hook'
4730 if Vdelayed_warnings_list is non-nil.
4731 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4732 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4733
4734 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4735
4736 * doprnt.c (doprnt): Don't return value smaller than the buffer
4737 size if the message was truncated. (Bug#8545).
4738
4739 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4740
4741 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4742 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4743
4744 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4745
4746 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4747
4748 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4749
4750 * makefile.w32-in: Update dependencies.
4751
4752 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4753
4754 Improve `doprnt' and its usage. (Bug#8545)
4755 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4756 `format_end'. Remove support for %l as a conversion specifier.
4757 Don't use xrealloc. Improve diagnostics when the %l size modifier
4758 is used. Update the commentary.
4759
4760 * eval.c (verror): Simplify calculation of size_t.
4761
4762 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4763 messages.
4764
4765 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4766
4767 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4768 change.
4769
4770 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4771
4772 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4773 This makes this file independent of the recent pseudovector change.
4774
4775 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4776
4777 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4778
4779 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4780 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4781 Remove unused local.
4782 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4783
4784 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4785 GCC 4.6.0 optimizes based on type-based alias analysis.
4786 For example, if b is of type struct buffer * and v of type struct
4787 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4788 != &v->size, and therefore "v->size = 1; b->size = 2; return
4789 v->size;" must therefore return 1. This assumption is incorrect
4790 for Emacs, since it type-puns struct Lisp_Vector * with many other
4791 types. To fix this problem, this patch adds a new type struct
4792 vectorlike_header that documents the constraints on layout of vectors
4793 and pseudovectors, and helps optimizing compilers not get fooled
4794 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4795 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4796 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4797 the size member.
4798 (XSETPVECTYPE): Rewrite in terms of new macro.
4799 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4800 This is a bit clearer, and further avoids the possibility of
4801 undesirable aliasing.
4802 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4803 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4804 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4805 since Lisp_Subr is a special case (no "next" field).
4806 (ASIZE): Now uses header.size rather than size.
4807 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4808 to avoid the hassle of writing XVECTOR (foo)->header.size.
4809 (struct vectorlike_header): New type.
4810 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4811 object, to help avoid aliasing.
4812 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4813 (SUBRP): Likewise, since Lisp_Subr is a special case.
4814 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4815 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4816 (struct Lisp_Hash_Table): Combine first two members into a single
4817 struct vectorlike_header member. All uses of "size" and "next" members
4818 changed to be "header.size" and "header.next".
4819 * buffer.h (struct buffer): Likewise.
4820 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4821 * frame.h (struct frame): Likewise.
4822 * process.h (struct Lisp_Process): Likewise.
4823 * termhooks.h (struct terminal): Likewise.
4824 * window.c (struct save_window_data, struct saved_window): Likewise.
4825 * window.h (struct window): Likewise.
4826 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4827 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4828 * buffer.c (init_buffer_once): Likewise.
4829 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4830 special case.
4831 * process.c (Fformat_network_address): Use local var for size,
4832 for brevity.
4833
4834 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4835
4836 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4837 * data.c (atof): Remove decl; no longer used or needed.
4838 (digit_to_number): Move to lread.c.
4839 (Fstring_to_number): Use new string_to_number function, to be
4840 consistent with how the Lisp reader treats infinities and NaNs.
4841 Do not assume that floating-point numbers represent EMACS_INT
4842 without losing information; this is not true on most 64-bit hosts.
4843 Avoid double-rounding errors, by insisting on integers when
4844 parsing non-base-10 numbers, as the documentation specifies.
4845 * lisp.h (string_to_number): New decl, replacing ...
4846 (isfloat_string): Remove.
4847 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4848 (read1): Do not accept +. and -. as integers; this
4849 appears to have been a coding error. Similarly, do not accept
4850 strings like +-1e0 as floating point numbers. Do not report
4851 overflow for integer overflows unless the base is not 10 which
4852 means we have no simple and reliable way to continue.
4853 Break out the floating-point parsing into a new
4854 function string_to_number, so that Fstring_to_number parses
4855 floating point numbers consistently with the Lisp reader.
4856 (digit_to_number): Move here from data.c. Make it static inline.
4857 (E_CHAR, EXP_INT): Remove, replacing with ...
4858 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4859 (string_to_number): New function, replacing isfloat_string.
4860 This function checks for valid syntax and produces the resulting
4861 Lisp float number too. Rework it so that string-to-number
4862 no longer mishandles examples like "1.0e+". Use strtoumax,
4863 so that overflow for non-base-10 numbers is reported only when
4864 there's no portable and simple way to convert to floating point.
4865
4866 * textprop.c (set_text_properties_1): Rewrite for clarity,
4867 and to avoid GCC warning about integer overflow.
4868
4869 * intervals.h (struct interval): Use EMACS_INT for members
4870 where EMACS_UINT might cause problems. See
4871 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4872 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4873 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4874 All uses changed.
4875 (offset_intervals): Tell GCC not to worry about length overflow
4876 when negating a negative length.
4877
4878 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4879 (overrun_check_free): Likewise.
4880
4881 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4882 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4883 word size.
4884
4885 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4886 (gnutls_make_error): Rename local to avoid shadowing.
4887 (gnutls_emacs_global_deinit): ifdef out; not used.
4888 (Fgnutls_boot): Use const for pointer to readonly storage.
4889 Comment out unused local. Fix pointer signedness problems.
4890
4891 * lread.c (openp): Don't stuff size_t into an 'int'.
4892 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4893 about possible signed overflow.
4894
4895 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4896 (GDK_KEY_g): Don't define if already defined.
4897 (xg_prepare_tooltip): Avoid pointer signedness problem.
4898 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4899
4900 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4901 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4902
4903 * xfns.c (Fx_window_property): Simplify a bit,
4904 to make a bit faster and to avoid GCC 4.6.0 warning.
4905 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4906
4907 * fns.c (internal_equal): Don't assume size_t fits in int.
4908
4909 * alloc.c (compact_small_strings): Tighten assertion a little.
4910
4911 Replace pEd with more-general pI, and fix some printf arg casts.
4912 * lisp.h (pI): New macro, generalizing old pEd macro to other
4913 conversion specifiers. For example, use "...%"pI"d..." rather
4914 than "...%"pEd"...".
4915 (pEd): Remove. All uses replaced with similar uses of pI.
4916 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4917 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4918 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4919 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4920 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4921 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4922 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4923 64-bit hosts.
4924 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4925 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4926 * print.c (safe_debug_print, print_object): Likewise.
4927 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4928 to int.
4929 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4930 avoiding the 0 flag, which is not portable.
4931 * process.c (Fmake_network_process): Use pI to avoid cast.
4932 * region-cache.c (pp_cache): Likewise.
4933 * xdisp.c (decode_mode_spec): Likewise.
4934 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4935 behavior on 64-bit hosts with printf arg.
4936 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4937 (x_stop_queuing_selection_requests): Likewise.
4938 (x_get_window_property): Don't truncate byte count to an 'int'
4939 when tracing.
4940
4941 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4942 here, since it parses constructs like leading '-' and spaces,
4943 which are not wanted; and it overflows with large numbers.
4944 Instead, simply match F[0-9]+, which is what is wanted anyway.
4945
4946 * alloc.c: Remove unportable assumptions about struct layout.
4947 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4948 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4949 (allocate_vectorlike, make_pure_vector): Use the new macros,
4950 plus offsetof, to remove unportable assumptions about struct layout.
4951 These assumptions hold on all porting targets that I know of, but
4952 they are not guaranteed, they're easy to remove, and removing them
4953 makes further changes easier.
4954
4955 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4956 This doesn't fix a bug but makes the code clearer.
4957 (string_overrun_cookie): Now const. Use initializers that
4958 don't formally overflow signed char, to avoid warnings.
4959 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4960 can cause Emacs to crash when string overrun checking is enabled.
4961 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4962 multiple of sizeof (EMACS_INT); it need not be, if
4963 alignof(EMACS_INT) < sizeof (EMACS_INT).
4964 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4965
4966 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4967
4968 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4969
4970 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4971
4972 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4973 supposed to be handshaking. (Bug#8556)
4974 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4975
4976 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4977
4978 * lisp.h (Qdebug): List symbol.
4979 * eval.c (Qdebug): Restore global linkage.
4980 * keyboard.c (debug-on-event): New variable.
4981 (handle_user_signal): Break into debugger when debug-on-event
4982 matches the current signal symbol.
4983
4984 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4985
4986 * alloc.c (check_sblock, check_string_bytes)
4987 (check_string_free_list): Convert to standard C.
4988
4989 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4990
4991 * w32.c (emacs_gnutls_push): Fix typo.
4992
4993 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4994
4995 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4996 "cast to pointer from integer of different size".
4997
4998 Improve doprnt and its use in verror. (Bug#8545)
4999 * doprnt.c (doprnt): Document the set of format control sequences
5000 supported by the function. Use SAFE_ALLOCA instead of always
5001 using `alloca'.
5002
5003 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5004 is one byte too soon. Don't use xrealloc; instead xfree and
5005 xmalloc anew.
5006
5007 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5008
5009 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5010 callbacks stage.
5011
5012 * gnutls.c: Renamed global_initialized to
5013 gnutls_global_initialized. Added internals for the
5014 :verify-hostname-error, :verify-error, and :verify-flags
5015 parameters of `gnutls-boot' and documented those parameters in the
5016 docstring. Start callback support.
5017 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5018 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5019 on error. Return error code.
5020 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5021 (emacs_gnutls_read): Likewise.
5022 (Fgnutls_boot): Return handshake error code.
5023 (emacs_gnutls_handle_error): New function.
5024 (wsaerror_to_errno): Likewise.
5025
5026 * w32.h (emacs_gnutls_pull): Add prototype.
5027 (emacs_gnutls_push): Likewise.
5028
5029 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5030 (emacs_gnutls_push): Likewise.
5031
5032 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5033
5034 * process.c (wait_reading_process_output): Check if GnuTLS
5035 buffered some data internally if no FDs are set for TLS
5036 connections.
5037
5038 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5039 (LIBS): Link to USER_LIBS.
5040 ($(BLD)/gnutls.$(0)): New target.
5041
5042 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5043
5044 * xdisp.c (handle_single_display_spec): Rename the
5045 display_replaced_before_p argument into display_replaced_p, to
5046 make it consistent with the commentary. Fix typos in the
5047 commentary.
5048
5049 * textprop.c (syms_of_textprop): Remove dead code.
5050 (copy_text_properties): Delete obsolete commentary about an
5051 interface that was deleted long ago. Fix typos in the description
5052 of arguments.
5053
5054 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5055 to changes in oldXMenu/XMenu.h from 2011-04-16.
5056 <menu_help_message, prev_menu_help_message>: Constify.
5057 (IT_menu_make_room): menu->help_text is now `const char **';
5058 adjust.
5059
5060 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5061 to changes in oldXMenu/XMenu.h from 2011-04-16.
5062 (struct XMenu): Declare `help_text' `const char **'.
5063
5064 * xfaces.c <Qunspecified>: Make extern again.
5065
5066 * syntax.c: Include sys/types.h before including regex.h, as
5067 required by Posix.
5068
5069 * doc.c (get_doc_string): Improve the format passed to `error'.
5070
5071 * doprnt.c (doprnt): Improve commentary.
5072
5073 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5074
5075 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5076 them with etags.
5077
5078 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5079 changes in globals.h immediately force recompilation.
5080 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5081 $(CURDIR)/s/ms-w32.h.
5082 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5083
5084 * character.c (Fchar_direction): Function deleted.
5085 (syms_of_character): Don't defsubr it.
5086 <char-direction-table>: Deleted.
5087
5088 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5089
5090 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5091 * doprnt.c: Include limits.h.
5092 (SIZE_MAX): New macro.
5093 (doprnt): Return a size_t value. 2nd arg is now size_t.
5094 Many local variables are now size_t instead of int or unsigned.
5095 Improve overflow protection. Support `l' modifier for integer
5096 conversions. Support %l conversion. Don't assume an EMACS_INT
5097 argument for integer conversions and for %c.
5098
5099 * lisp.h (doprnt): Restore prototype.
5100
5101 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5102 $(SRC)/character.h.
5103
5104 * Makefile.in (base_obj): Add back doprnt.o.
5105
5106 * deps.mk (doprnt.o): Add back prerequisites.
5107 (callint.o): Depend on character.h.
5108
5109 * eval.c (internal_lisp_condition_case): Include the handler
5110 representation in the error message.
5111 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5112 when breaking from the loop.
5113
5114 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5115
5116 * callint.c (Fcall_interactively): When displaying error message
5117 about invalid control letter, pass the character's codepoint, not
5118 a pointer to its multibyte form. Improve display of the character
5119 in octal and display also its hex code.
5120
5121 * character.c (char_string): Use %x to display the (unsigned)
5122 codepoint of an invalid character, to avoid displaying a bogus
5123 negative value.
5124
5125 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5126 `error', not SYMBOL_NAME itself.
5127
5128 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5129 character arguments to `error'.
5130
5131 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5132 to `error' in error message about FINAL_CHAR argument. Make sure
5133 FINAL_CHAR is a character, and use %c when it is passed as
5134 argument to `error'.
5135
5136 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5137
5138 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5139
5140 * w32.c: Include <time.h>.
5141 (sys_localtime): New function.
5142
5143 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5144
5145 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5146
5147 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5148
5149 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5150
5151 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5152 zombies (Bug#8467).
5153
5154 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5155
5156 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5157 gl_state.e_property when gl_state.object is Qt.
5158
5159 * insdel.c (make_gap_larger): Remove limitation of buffer size
5160 to <= INT_MAX.
5161
5162 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5163
5164 * xdisp.c (lookup_glyphless_char_display)
5165 (produce_glyphless_glyph): Handle cons cell entry in
5166 glyphless-char-display.
5167 (Vglyphless_char_display): Document it.
5168
5169 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5170 glyphless-char-display.
5171
5172 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5173
5174 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5175
5176 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5177
5178 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5179 definition for no-X builds.
5180
5181 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5182
5183 Static checks with GCC 4.6.0 and non-default toolkits.
5184
5185 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5186
5187 * process.c (keyboard_bit_set): Define only if SIGIO.
5188 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5189 (send_process): Repair possible setjmp clobbering.
5190
5191 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5192
5193 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5194
5195 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5196
5197 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5198 Define only if needed.
5199
5200 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5201 by pacifying GCC about it. Maybe it's time to retire it?
5202 * xfaces.c (USG, __TIMEVAL__): Likewise.
5203
5204 * dispextern.h (struct redisplay_interface): Rename param
5205 to avoid shadowing.
5206 * termhooks.h (struct terminal): Likewise.
5207 * xterm.c (xembed_send_message): Likewise.
5208
5209 * insdel.c (make_gap_smaller): Define only if
5210 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5211
5212 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5213 it.
5214
5215 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5216 so that we aren't warned about unused symbols.
5217
5218 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5219
5220 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5221
5222 * xfns.c (x_real_positions): Mark locals as initialized.
5223
5224 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5225
5226 * xterm.c: Fix problems found by static analysis with other toolkits.
5227 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5228 (x_dispatch_event): Declare static if USE_GTK, and
5229 define if USE_GTK || USE_X_TOOLKIT.
5230 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5231 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5232 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5233 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5234
5235 * xmenu.c (menu_help_callback): Pointer type fixes.
5236 Use const pointers when pointing at readonly data. Avoid pointer
5237 signedness clashes.
5238 (FALSE): Remove unused macro.
5239 (update_frame_menubar): Remove unused decl.
5240
5241 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5242
5243 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5244 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5245 (single_menu_item): Rename local to avoid shadowing.
5246
5247 * keyboard.c (make_lispy_event): Remove unused local var.
5248
5249 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5250 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5251
5252 * bitmaps: Change bitmaps from unsigned char back to the X11
5253 compatible char. Avoid the old compiler warnings about
5254 out-of-range initializers by using, for example, '\xab' rather
5255 than 0xab.
5256
5257 * xgselect.c (xgselect_initialize): Check vs interface
5258 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5259
5260 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5261
5262 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5263 to read-only memory.
5264
5265 * fns.c (vector): Remove; this old hack is no longer needed.
5266
5267 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5268 Remove unused var.
5269 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5270
5271 * xrdb.c (x_load_resources): Omit unused local.
5272
5273 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5274 (x_window): Rename locals to avoid shadowing.
5275 (USG): Use the kludged USG macro, to pacify gcc.
5276
5277 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5278 (x_term_init): Remove local to avoid shadowing.
5279
5280 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5281
5282 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5283 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5284
5285 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5286
5287 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5288
5289 Fix regex.c, syntax.c and friends for buffers > 2GB.
5290 * syntax.h (struct gl_state_s): Declare character position members
5291 EMACS_INT.
5292
5293 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5294
5295 * textprop.c (verify_interval_modification, interval_of):
5296 Declare arguments EMACS_INT.
5297
5298 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5299 EMACS_INT.
5300
5301 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5302
5303 * indent.c (Fvertical_motion): Local variable it_start is now
5304 EMACS_INT.
5305
5306 * regex.c (re_match, re_match_2, re_match_2_internal)
5307 (bcmp_translate, regcomp, regexec, print_double_string)
5308 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5309 (re_compile_pattern, re_exec): Declare arguments and local
5310 variables `size_t' and `ssize_t' and return values `regoff_t', as
5311 appropriate.
5312 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5313 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5314 <compile_stack_type>: `size' and `avail' are now `size_t'.
5315
5316 * regex.h <regoff_t>: Use ssize_t, not int.
5317 (re_search, re_search_2, re_match, re_match_2): Arguments that
5318 specify buffer/string position and length are now ssize_t and
5319 size_t. Return type is regoff_t.
5320
5321 2011-04-16 Ben Key <bkey76@gmail.com>
5322
5323 * nsfont.m: Fixed bugs in ns_get_family and
5324 ns_descriptor_to_entity that were caused by using free to
5325 deallocate memory blocks that were allocated by xmalloc (via
5326 xstrdup). This caused Emacs to crash when compiled with
5327 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5328 --enable-checking=xmallocoverrun). xfree is now used to
5329 deallocate these memory blocks.
5330
5331 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5332
5333 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5334
5335 emacs_write: Accept and return EMACS_INT for sizes.
5336 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5337 et seq.
5338 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5339 Accept and return EMACS_INT.
5340 (emacs_gnutls_write): Return the number of bytes written on
5341 partial writes.
5342 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5343 (emacs_read, emacs_write): Remove check for negative size, as the
5344 Emacs source code has been audited now.
5345 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5346 (emacs_read, emacs_write): Use it.
5347 * process.c (send_process): Adjust to the new signatures of
5348 emacs_write and emacs_gnutls_write. Do not attempt to store
5349 a byte offset into an 'int'; it might overflow.
5350 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5351
5352 * sound.c: Don't assume sizes fit in 'int'.
5353 (struct sound_device.period_size, alsa_period_size):
5354 Return EMACS_INT, not int.
5355 (struct sound_device.write, vox_write, alsa_write):
5356 Accept EMACS_INT, not int.
5357 (wav_play, au_play): Use EMACS_INT to store sizes and to
5358 record read return values.
5359
5360 2011-04-15 Ben Key <bkey76@gmail.com>
5361
5362 * keyboard.c (Qundefined): Don't declare static since it is used
5363 in nsfns.m.
5364 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5365 static since they are used in nsfont.m.
5366
5367 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5368
5369 * process.c (Qprocessp): Don't declare static.
5370 * lisp.h (Qprocessp): Declare again.
5371
5372 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5373
5374 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5375
5376 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5377
5378 Improve C-level modularity by making more things 'static'.
5379
5380 Don't publish debugger-only interfaces to other modules.
5381 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5382 (verify_bytepos, count_markers): Move decls to the only modules
5383 that need them.
5384 * region-cache.h (pp_cache): Likewise.
5385 * window.h (check_all_windows): Likewise.
5386 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5387
5388 * sysdep.c (croak): Now static, if
5389 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5390 * syssignal.h (croak): Declare only if not static.
5391
5392 * alloc.c (refill_memory_reserve): Now static if
5393 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5394 * lisp.h (refill_memory_reserve): Declare only if not static.
5395
5396 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5397 Define only if USE_LUCID.
5398
5399 * xrdb.c (x_customization_string, x_rm_string): Now static.
5400
5401 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5402 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5403
5404 * xdisp.c (draw_row_with_mouse_face): Now static.
5405 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5406
5407 * window.h (check_all_windows): Mark externally visible.
5408
5409 * window.c (window_deletion_count): Now static.
5410
5411 * undo.c: Make symbols static if they're not exported.
5412 (last_undo_buffer, last_boundary_position, pending_boundary):
5413 Now static.
5414
5415 * textprop.c (interval_insert_behind_hooks): Now static.
5416 (interval_insert_in_front_hooks): Likewise.
5417
5418 * term.c: Make symbols static if they're not exported.
5419 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5420 (max_frame_lines, tty_set_terminal_modes):
5421 (tty_reset_terminal_modes, tty_turn_off_highlight):
5422 (get_tty_terminal): Now static.
5423 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5424 * termhooks.h (term_mouse_moveto): Do not declare if
5425 HAVE_WINDOW_SYSTEM.
5426 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5427 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5428
5429 * sysdep.c: Make symbols static if they're not exported.
5430 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5431 Now static.
5432 (sigprocmask_set, full_mask): Remove; unused.
5433 (wait_debugging): Mark as visible.
5434 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5435 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5436
5437 * syntax.c (syntax_temp): Define only if !__GNUC__.
5438
5439 * sound.c (current_sound_device, current_sound): Now static.
5440
5441 * search.c (searchbufs, searchbuf_head): Now static.
5442
5443 * scroll.c (scroll_cost): Remove; unused.
5444 * dispextern.h (scroll_cost): Remove decl.
5445
5446 * region-cache.h (pp_cache): Mark as externally visible.
5447
5448 * process.c: Make symbols static if they're not exported.
5449 (process_tick, update_tick, create_process, chan_process):
5450 (Vprocess_alist, proc_buffered_char, datagram_access):
5451 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5452 (deactivate_process): Mark defn as static, as well as decl.
5453 * lisp.h (create_process): Remove decl.
5454 * process.h (chan_process, Vprocess_alist): Remove decls.
5455
5456 * print.c: Make symbols static if they're not exported.
5457 (print_depth, new_backquote_output, being_printed, print_buffer):
5458 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5459 (print_interval, print_number_index, initial_stderr_stream):
5460 Now static.
5461 * lisp.h (Fprinc): Remove decl.
5462 (debug_output_compilation_hack): Mark as externally visible.
5463
5464 * sysdep.c (croak): Move decl from here to syssignal.h.
5465 * syssignal.h (croak): Put it here, so the API can be checked when
5466 'croak' is called from dissociate_if_controlling_tty.
5467
5468 * minibuf.c: Make symbols static if they're not exported.
5469 (minibuf_save_list, choose_minibuf_frame): Now static.
5470 * lisp.h (choose_minibuf_frame): Remove decl.
5471
5472 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5473
5474 * lread.c: Make symbols static if they're not exported.
5475 (read_objects, initial_obarray, oblookup_last_bucket_number):
5476 Now static.
5477 (make_symbol): Remove; unused.
5478 * lisp.h (initial_obarray, make_symbol): Remove decls.
5479
5480 * keyboard.c: Make symbols static if they're not exported.
5481 (single_kboard, recent_keys_index, total_keys, recent_keys):
5482 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5483 (this_single_command_key_start, echoing, last_auto_save):
5484 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5485 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5486 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5487 (Vlispy_mouse_stem, double_click_count):
5488 Now static.
5489 (force_auto_save_soon): Define only if SIGDANGER.
5490 (ignore_mouse_drag_p): Now static if
5491 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5492 (print_help): Remove; unused.
5493 (stop_character, last_timer_event): Mark as externally visible.
5494 * keyboard.h (ignore_mouse_drag_p): Declare only if
5495 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5496 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5497 * lisp.h (echoing): Remove decl.
5498 (force_auto_save_soon): Declare only if SIGDANGER.
5499 * xdisp.c (redisplay_window): Simplify code, to make it more
5500 obvious that ignore_mouse_drag_p is not accessed if !defined
5501 USE_GTK && !defined HAVE_NS.
5502
5503 * intervals.c: Make symbols static if they're not exported.
5504 (merge_properties_sticky, merge_interval_right, delete_interval):
5505 Now static.
5506 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5507
5508 * insdel.c: Make symbols static if they're not exported.
5509 However, leave prepare_to_modify_buffer alone. It's never
5510 called from outside this function, but that appears to be a bug.
5511 (combine_after_change_list, combine_after_change_buffer):
5512 (adjust_after_replace, signal_before_change): Now static.
5513 (adjust_after_replace_noundo): Remove; unused.
5514 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5515 (signal_before_change): Remove decls.
5516
5517 * indent.c (val_compute_motion, val_vmotion): Now static.
5518
5519 * image.c: Make symbols static if they're not exported.
5520 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5521 if USE_GTK.
5522 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5523 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5524
5525 * fringe.c (standard_bitmaps): Now static.
5526 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5527
5528 * frame.c: Make symbols static if they're not exported.
5529 (x_report_frame_params, make_terminal_frame): Now static.
5530 (get_frame_param): Now static, unless HAVE_NS.
5531 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5532 (x_get_resource_string): Remove; not used.
5533 * frame.h (make_terminal_frame, x_report_frame_params):
5534 (x_get_resource_string); Remove decls.
5535 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5536 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5537
5538 * font.c, fontset.c: Make symbols static if they're not exported.
5539 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5540 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5541 * font.c (font_close_object): Now static.
5542 * font.h (font_close_object): Remove.
5543 * fontset.c (FONTSET_OBJLIST): Remove.
5544 (free_realized_fontset) #if-0 the body, which does nothing.
5545 (face_suitable_for_char_p): #if-0, as it's never called.
5546 * fontset.h (face_suitable_for_char_p): Remove decl.
5547 * xfaces.c (face_at_string_position):
5548 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5549 since 0 is always ASCII.
5550
5551 * fns.c (weak_hash_tables): Now static.
5552
5553 * fileio.c: Make symbols static if they're not exported.
5554 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5555 (Vwrite_region_annotation_buffers): Now static.
5556
5557 * eval.c: Make symbols static if they're not exported.
5558 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5559 * lisp.h (backtrace_list): Remove decl.
5560
5561 * emacs.c: Make symbols static if they're not exported.
5562 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5563 (fatal_error_code, fatal_error_signal_hook, standard_args):
5564 Now static.
5565 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5566 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5567 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5568 * lisp.h (fatal_error_signal_hook): Remove decl.
5569 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5570
5571 * editfns.c: Move a (normally-unused) function to its only use.
5572 * editfns.c, lisp.h (get_operating_system_release): Remove.
5573 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5574 worth the hassle of breaking this out.
5575
5576 * xterm.c: Make symbols static if they're not exported.
5577 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5578 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5579 (x_destroy_window, x_delete_display):
5580 Now static.
5581 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5582 (x_mouse_leave): Remove; unused.
5583 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5584 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5585 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5586 Remove decls.
5587 (x_mouse_leave): Declare only if WINDOWSNT.
5588 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5589 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5590 USE_X_TOOLKIT.
5591
5592 * ftxfont.c: Make symbols static if they're not exported.
5593 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5594 HAVE_FREETYPE.
5595 * font.h (ftxfont_driver): Likewise.
5596
5597 * xfns.c: Make symbols static if they're not exported.
5598 (x_last_font_name, x_display_info_for_name):
5599 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5600 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5601 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5602 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5603 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5604 (last_show_tip_args): Now static.
5605 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5606 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5607 (x_screen_planes): Remove; unused.
5608 * dispextern.h (x_screen_planes): Remove decl.
5609
5610 * dispnew.c: Make symbols static if they're not exported.
5611 * dispextern.h (redraw_garbaged_frames, scrolling):
5612 (increment_row_positions): Remove.
5613 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5614 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5615 Now static.
5616 (redraw_garbaged_frames): Remove; unused.
5617
5618 * xfaces.c: Make symbols static if they're not exported.
5619 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5620 Remove decls.
5621 * xterm.h (defined_color): Remove decls.
5622 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5623 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5624 (menu_face_changed_default, defined_color, free_realized_face):
5625 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5626 (ascii_face_of_lisp_face): Remove; unused.
5627
5628 * xdisp.c: Make symbols static if they're not exported.
5629 * dispextern.h (scratch_glyph_row, window_box_edges):
5630 (glyph_to_pixel_coords, set_cursor_from_row):
5631 (get_next_display_element, set_iterator_to_next):
5632 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5633 (show_mouse_face): Remove decls
5634 * frame.h (message_buf_print): Likewise.
5635 * lisp.h (pop_message, set_message, check_point_in_composition):
5636 Likewise.
5637 * xterm.h (set_vertical_scroll_bar): Likewise.
5638 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5639 (message_buf_print, scratch_glyph_row, displayed_buffer):
5640 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5641 (get_next_display_element, show_mouse_face, window_box_edges):
5642 (frame_to_window_pixel_xy, check_point_in_composition):
5643 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5644 (glyph_to_pixel_coords): Remove; unused.
5645
5646 * dired.c (file_name_completion): Now static.
5647
5648 * dbusbind.c (xd_in_read_queued_messages): Now static.
5649
5650 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5651 * data.c (circular_list_error): Remove.
5652
5653 * commands.h (last_point_position, last_point_position_buffer):
5654 (last_point_position_window): Remove decls.
5655 * keyboard.c: Make these variables static.
5656
5657 * coding.h (coding, code_convert_region, encode_coding_gap):
5658 Remove decls.
5659 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5660 (iso_code_class, detect_coding, code_convert_region): Now static.
5661 (encode_coding_gap): Remove; unused.
5662
5663 * chartab.c (chartab_chars, chartab_bits): Now static.
5664
5665 * charset.h (charset_iso_8859_1): Remove decl.
5666 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5667 Now static.
5668
5669 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5670 * ccl.c (Vccl_program_table): Now static.
5671 (check_ccl_update): Remove; unused.
5672
5673 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5674 * category.h: ... from here.
5675 * category.c (check_category_table, set_category_set): Now static.
5676
5677 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5678 * lisp.h: Remove these decls.
5679
5680 * buffer.c (buffer_count): Remove unused var.
5681
5682 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5683 so that it's not optimized away.
5684 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5685 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5686 exported only to the debugger.
5687
5688 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5689 * atimer.h (run_all_atimers): Remove; not exported.
5690
5691 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5692 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5693 was inaccessible from Lisp.
5694 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5695 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5696
5697 alloc.c: Import and export fewer symbols, and remove unused items.
5698 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5699 is defined.
5700 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5701 it's not optimized away by whole-program optimization.
5702 (message_enable_multibyte, free_misc): Remove.
5703 (catchlist, handlerlist, mark_backtrace):
5704 Declare only if BYTE_MARK_STACK.
5705 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5706 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5707 (message_enable_multibyte): Remove decl.
5708 (free_misc, interval_free_list, float_block, float_block_index):
5709 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5710 (cons_free_list, last_marked_index):
5711 Now static.
5712 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5713 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5714 (mark_backtrace): Define only if BYTE_MARK_STACK.
5715 * xdisp.c (message_enable_multibyte): Now static.
5716
5717 Declare Lisp_Object Q* variables to be 'static' if not exported.
5718 This makes it easier for human readers (and static analyzers)
5719 to see whether these variables are used from other modules.
5720 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5721 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5722 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5723 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5724 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5725 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5726 * xmenu.c, xselect.c:
5727 Declare Q* vars static if they are not used in other modules.
5728 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5729 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5730 Remove decls of unexported vars.
5731 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5732
5733 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5734
5735 Make Emacs functions such as Fatom 'static' by default.
5736 This makes it easier for human readers (and static analyzers)
5737 to see whether these functions can be called from other modules.
5738 DEFUN now defines a static function. To make the function external
5739 so that it can be used in other C modules, use the new macro DEFUE.
5740 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5741 (Finit_image_library):
5742 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5743 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5744 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5745 Remove decls, since these functions are now static.
5746 (Funintern, Fget_internal_run_time): New decls, since these functions
5747 were already external.
5748
5749 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5750 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5751 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5752 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5753 * keyboard.c, keymap.c, lread.c:
5754 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5755 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5756 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5757 Mark functions with DEFUE instead of DEFUN,
5758 if they are used in other modules.
5759 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5760 decls for now-static functions.
5761 * buffer.h (Fdelete_overlay): Remove decl.
5762 * callproc.c (Fgetenv_internal): Mark as internal.
5763 * composite.c (Fremove_list_of_text_properties): Remove decl.
5764 (Fcomposition_get_gstring): New forward static decl.
5765 * composite.h (Fcomposite_get_gstring): Remove decl.
5766 * dired.c (Ffile_attributes): New forward static decl.
5767 * doc.c (Fdocumntation_property): New forward static decl.
5768 * eval.c (Ffetch_bytecode): New forward static decl.
5769 (Funintern): Remove extern decl; now in .h file where it belongs.
5770 * fileio.c (Fmake_symbolic_link): New forward static decl.
5771 * image.c (Finit_image_library): New forward static decl.
5772 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5773 * intervals.h (Fprevious_property_change):
5774 (Fremove_list_of_text_properties): Remove decls.
5775 * keyboard.c (Fthis_command_keys): Remove decl.
5776 (Fcommand_execute): New forward static decl.
5777 * keymap.c (Flookup_key): New forward static decl.
5778 (Fcopy_keymap): Now static.
5779 * keymap.h (Flookup_key): Remove decl.
5780 * process.c (Fget_process): New forward static decl.
5781 (Fprocess_datagram_address): Mark as internal.
5782 * syntax.c (Fsyntax_table_p): New forward static decl.
5783 (skip_chars): Remove duplicate decl.
5784 * textprop.c (Fprevious_property_change): New forward static decl.
5785 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5786 Now internal.
5787 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5788 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5789
5790 * editfns.c (Fformat): Remove unreachable code.
5791
5792 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5793
5794 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5795 change. (Bug#8496)
5796
5797 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5798
5799 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5800 when at ZV. (Bug#8487)
5801
5802 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5803
5804 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5805 (Bug#8437)
5806 * keyboard.c (parse_tool_bar_item): Likewise.
5807 * sound.c (sound_cleanup, alsa_close): Likewise.
5808 * termcap.c (tgetent): Likewise.
5809 * xfns.c (x_default_font_parameter): Likewise.
5810 * xsettings.c (read_and_apply_settings): Likewise.
5811
5812 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5813 (overrun_check_free): Protoize.
5814
5815 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5816
5817 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5818 since callers should never pass a negative size.
5819 Change the signature to match that of plain 'read' and 'write'; see
5820 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5821 * lisp.h: Update prototypes of emacs_write and emacs_read.
5822
5823 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5824
5825 * xdisp.c (redisplay_window): Don't try to determine the character
5826 position of the scroll margin if the window start point w->startp
5827 is outside the buffer's accessible region. (Bug#8468)
5828
5829 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5830
5831 Fix write-region and its subroutines for buffers > 2GB.
5832 * fileio.c (a_write, e_write): Modify declaration of arguments and
5833 local variables to support buffers larger than 2GB.
5834 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5835
5836 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5837 argument, local variables, and return value.
5838
5839 * lisp.h: Update prototypes of emacs_write and emacs_read.
5840
5841 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5842
5843 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5844
5845 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5846
5847 Fix more problems found by GCC 4.6.0's static checks.
5848
5849 * xdisp.c (vmessage): Use a better test for character truncation.
5850
5851 * charset.c (load_charset_map): <, not <=, for optimization,
5852 and to avoid potential problems with integer overflow.
5853 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5854 * casetab.c (set_identity, shuffle): Likewise.
5855 * editfns.c (Fformat): Likewise.
5856 * syntax.c (skip_chars): Likewise.
5857
5858 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5859 This also lets GCC 4.6.0 generate slightly better loop code.
5860
5861 * callint.c (Fcall_interactively): <, not <=, for optimization.
5862 (Fcall_interactively): Count the number of arguments produced,
5863 not the number of arguments given. This is simpler and lets GCC
5864 4.6.0 generate slightly better code.
5865
5866 * ftfont.c: Distingish more carefully between FcChar8 and char.
5867 The previous code passed unsigned char * to a functions like
5868 strlen and xstrcasecmp that expect char *, which does not
5869 conform to the C standard.
5870 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5871 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5872 char * when the C standard requires it.
5873
5874 * keyboard.c (read_char): Remove unused var.
5875
5876 * eval.c: Port to Windows vsnprintf (Bug#8435).
5877 Include <limits.h>.
5878 (SIZE_MAX): Define if the headers do not.
5879 (verror): Do not give up if vsnprintf returns a negative count.
5880 Instead, grow the buffer. This ports to Windows vsnprintf, which
5881 does not conform to C99. Problem reported by Eli Zaretskii.
5882 Also, simplify the allocation scheme, by avoiding the need for
5883 calling realloc, and removing the ALLOCATED variable.
5884
5885 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5886
5887 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5888 But keep the doprint source code for now, as we might revamp it
5889 and use it again (Bug#8435).
5890 * lisp.h (doprnt): Remove.
5891 * Makefile.in (base_obj): Remove doprnt.o.
5892 * deps.mk (doprnt.o): Remove.
5893
5894 error: Print 32- and 64-bit integers portably (Bug#8435).
5895 Without this change, on typical 64-bit hosts error ("...%d...", N)
5896 was used to print both 32- and 64-bit integers N, which relied on
5897 undefined behavior.
5898 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5899 New macro.
5900 * lisp.h (error, verror): Mark as printf-like functions.
5901 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5902 Report overflow in size calculations when allocating printf buffer.
5903 Do not truncate output string at its first null byte.
5904 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5905 Truncate the output at a character boundary, since vsnprintf does not
5906 do that.
5907 * charset.c (check_iso_charset_parameter): Convert internal
5908 character to string before calling 'error', since %c now has the
5909 printf meaning.
5910 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5911 overflow when computing char to be passed to 'error'. Do not
5912 pass Lisp_Object to 'error'; pass the integer instead.
5913 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5914 formatted with plain %d.
5915
5916 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5917
5918 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5919
5920 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5921
5922 * xterm.c (x_catch_errors): Remove duplicate declaration.
5923
5924 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5925
5926 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5927
5928 2011-04-10 Jim Meyering <meyering@redhat.com>
5929
5930 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5931 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5932 return ssize_t not "int", and use size_t as the buffer length.
5933 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5934 * gnutls.h: Update declarations.
5935 * process.c (read_process_output): Use ssize_t, to match.
5936 (send_process): Likewise.
5937
5938 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5939
5940 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5941
5942 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5943
5944 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5945 Use unsigned char, to match FcChar8 type definition.
5946
5947 * xterm.c (handle_one_xevent):
5948 * xmenu.c (create_and_show_popup_menu):
5949 * xselect.c (x_decline_selection_request)
5950 (x_reply_selection_request): Avoid type-punned deref of X events.
5951
5952 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5953
5954 Fix some uses of `int' instead of EMACS_INT.
5955 * search.c (string_match_1, fast_string_match)
5956 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5957 (scan_buffer, find_next_newline_no_quit)
5958 (find_before_next_newline, search_command, Freplace_match)
5959 (Fmatch_data): Make some `int' variables be EMACS_INT.
5960
5961 * xdisp.c (display_count_lines): 3rd argument and return value now
5962 EMACS_INT. All callers changed.
5963 (pint2hrstr): Last argument is now EMACS_INT.
5964
5965 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5966 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5967 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5968 (decode_coding_utf_16, decode_coding_emacs_mule)
5969 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5970 (decode_coding_ccl, decode_coding_charset)
5971 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5972 (decode_coding_iso_2022, decode_coding_emacs_mule)
5973 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5974 <char_offset, last_offset>: Declare EMACS_INT.
5975 (encode_coding_utf_8, encode_coding_utf_16)
5976 (encode_coding_emacs_mule, encode_invocation_designation)
5977 (encode_designation_at_bol, encode_coding_iso_2022)
5978 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5979 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5980 Declare EMACS_INT.
5981 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5982 (encode_invocation_designation): Last argument P_NCHARS is now
5983 EMACS_INT.
5984 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5985 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5986
5987 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5988 All users changed.
5989
5990 * ccl.c (Fccl_execute_on_string): Declare some variables
5991 EMACS_INT.
5992
5993 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5994
5995 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5996
5997 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5998
5999 * process.c (Fformat_network_address): Doc fix.
6000
6001 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6002
6003 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6004
6005 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6006
6007 * keyboard.c (read_char): Call Lisp function help-form-show,
6008 instead of using internal_with_output_to_temp_buffer.
6009 (Qhelp_form_show): New var.
6010 (syms_of_keyboard): Use DEFSYM macro.
6011
6012 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6013
6014 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6015
6016 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6017
6018 * process.c (Flist_processes): Remove to Lisp.
6019 (list_processes_1): Delete.
6020
6021 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6022
6023 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6024
6025 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6026
6027 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6028
6029 Fix more problems found by GCC 4.6.0's static checks.
6030
6031 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6032
6033 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6034
6035 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6036
6037 * xdisp.c (vmessage): Mark as a printf-like function.
6038
6039 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6040
6041 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6042
6043 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6044 printf-like functions.
6045 (tiff_load): Add casts to remove these marks before passing them
6046 to system-supplied API.
6047
6048 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6049
6050 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6051 This avoids several warnings with gcc -Wstrict-overflow.
6052 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6053 directly, rather than having caller test rule sign. This avoids
6054 some unnecessary tests.
6055 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6056 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6057 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6058
6059 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6060 (xfont_open): Avoid unnecessary tests.
6061
6062 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6063
6064 * composite.h, composite.c (composition_gstring_put_cache):
6065 Use EMACS_INT, not int, for length.
6066
6067 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6068 breaking out part of COMPOSITION_DECODE_RULE.
6069 (COMPOSITION_DECODE_RULE): Use it.
6070 * composite.c (get_composition_id): Remove unused local vars,
6071 by using the new macro.
6072
6073 * textprop.c (set_text_properties_1): Change while to do-while,
6074 since the condition is always true at first.
6075
6076 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6077 (interval_deletion_adjustment): Return unsigned value.
6078 All uses changed.
6079
6080 * process.c (list_processes_1, create_pty, read_process_output):
6081 (exec_sentinel): Remove vars that were set but not used.
6082 (create_pty): Remove unnecessary "volatile"s.
6083 (Fnetwork_interface_info): Avoid possibility of int overflow.
6084 (read_process_output): Do adaptive read buffering even if carryover.
6085 (read_process_output): Simplify nbytes computation if buffered.
6086
6087 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6088
6089 * syntax.c (scan_words): Remove var that was set but not used.
6090 (update_syntax_table): Use unsigned instead of int.
6091
6092 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6093 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6094 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6095
6096 * print.c (print_error_message): Avoid int overflow.
6097
6098 * font.c (font_list_entities): Redo for clarity,
6099 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6100
6101 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6102 (font_score): Avoid potential overflow in diff calculation.
6103
6104 * fns.c (substring_both): Remove var that is set but not used.
6105 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6106
6107 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6108
6109 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6110 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6111 can always succeed if overflow has undefined behavior.
6112
6113 * search.c (boyer_moore, wordify): Remove vars set but not used.
6114 (wordify): Omit three unnecessary tests.
6115
6116 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6117 All callers changed. This avoids the need for an unused var.
6118
6119 * casefiddle.c (casify_region): Remove var that is set but not used.
6120
6121 * dired.c (file_name_completion): Remove var that is set but not used.
6122
6123 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6124
6125 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6126 (Finsert_file_contents): Remove unnecessary code checking fd.
6127
6128 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6129 Check for integer overflow on size calculations.
6130
6131 * buffer.c (Fprevious_overlay_change): Remove var that is set
6132 but not used.
6133
6134 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6135 Remove vars that are set but not used.
6136 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6137 (timer_check_2): Mark vars as initialized.
6138
6139 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6140
6141 * image.c (lookup_image): Remove var that is set but not used.
6142 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6143
6144 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6145 that are set but not used.
6146
6147 * xfns.c (make_invisible_cursor): Don't return garbage
6148 if XCreateBitmapFromData fails (Bug#8410).
6149
6150 * xselect.c (x_get_local_selection, x_handle_property_notify):
6151 Remove vars that are set but not used.
6152
6153 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6154 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6155
6156 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6157 Remove var that is set but not used.
6158 (scroll_bar_windows_size): Now size_t, not int.
6159 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6160 Check for overflow.
6161
6162 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6163 (map_tty_color) [!defined MSDOS]: Likewise.
6164
6165 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6166
6167 * coding.c: Remove vars that are set but not used.
6168 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6169 All callers changed.
6170 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6171 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6172 (decode_coding_charset): Remove vars that are set but not used.
6173
6174 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6175 that is set but not used.
6176
6177 * print.c (print_object): Remove var that is set but not used.
6178
6179 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6180 The gnulib version avoids calling malloc in the usual case,
6181 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6182 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6183 * filelock.c (current_lock_owner): Likewise.
6184 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6185 * sysdep.c: Include allocator.h, careadlinkat.h.
6186 (emacs_no_realloc_allocator): New static constant.
6187 (emacs_readlink): New function.
6188 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6189 ../lib/careadlinkat.h.
6190
6191 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6192
6193 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6194 first non-nil return value).
6195
6196 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6197
6198 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6199 if not defined (Bug#8403).
6200
6201 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6202
6203 * xdisp.c (display_count_lines): Remove parameter `start',
6204 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6205 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6206 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6207 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6208 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6209 and thereabouts. All callers changed.
6210 (get_per_char_metric): Remove parameter `f', unused since
6211 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6212
6213 2011-04-02 Jim Meyering <meyering@redhat.com>
6214
6215 do not dereference NULL upon failed strdup
6216 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6217 (ns_get_family): Likewise.
6218
6219 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6220
6221 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6222
6223 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6224
6225 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6226 later (Bug#8403).
6227
6228 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6229
6230 Add lexical binding.
6231
6232 * window.c (Ftemp_output_buffer_show): New fun.
6233 (Fsave_window_excursion):
6234 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6235
6236 * lread.c (lisp_file_lexically_bound_p): New function.
6237 (Fload): Bind Qlexical_binding.
6238 (readevalloop): Remove `evalfun' arg.
6239 Bind Qinternal_interpreter_environment.
6240 (Feval_buffer): Bind Qlexical_binding.
6241 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6242 Mark as dynamic.
6243 (syms_of_lread): Declare `lexical-binding'.
6244
6245 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6246
6247 * keyboard.c (eval_dyn): New fun.
6248 (menu_item_eval_property): Use it.
6249
6250 * image.c (parse_image_spec): Use Ffunctionp.
6251
6252 * fns.c (concat, mapcar1): Accept byte-code-functions.
6253
6254 * eval.c (Fsetq): Handle lexical vars.
6255 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6256 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6257 (FletX, Flet): Obey lexical binding.
6258 (Fcommandp): Handle closures.
6259 (Feval): New `lexical' arg.
6260 (eval_sub): New function extracted from Feval. Use it almost
6261 everywhere where Feval was used. Look up vars in lexical env.
6262 Handle closures.
6263 (Ffunctionp): Move from subr.el.
6264 (Ffuncall): Handle closures.
6265 (apply_lambda): Remove `eval_flags'.
6266 (funcall_lambda): Handle closures and new byte-code-functions.
6267 (Fspecial_variable_p): New function.
6268 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6269 but without exporting it to Lisp.
6270
6271 * doc.c (Fdocumentation, store_function_docstring):
6272 * data.c (Finteractive_form): Handle closures.
6273
6274 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6275 interactive spec.
6276
6277 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6278 New byte-codes.
6279 (exec_byte_code): New function extracted from Fbyte_code to handle new
6280 calling convention for byte-code-functions. Add new byte-codes.
6281
6282 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6283
6284 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6285
6286 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6287
6288 * xdisp.c (redisplay_internal): Fix prototype.
6289
6290 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6291
6292 * xdisp.c (SCROLL_LIMIT): New macro.
6293 (try_scrolling): Use it when setting scroll_limit.
6294 Limit scrolling to 100 screen lines.
6295 (redisplay_window): Even when falling back on "recentering",
6296 position point in the window according to scroll-conservatively,
6297 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6298
6299 (try_scrolling): When point is above the window, allow searching
6300 as far as scroll_max, or one screenful, to compute vertical
6301 distance from PT to the scroll margin position. This prevents
6302 try_scrolling from unnecessarily failing when
6303 scroll-conservatively is set to a value slightly larger than the
6304 window height. Clean up the case of PT below the margin at bottom
6305 of window: scroll_max can no longer be INT_MAX. When aggressive
6306 scrolling is in use, don't let point enter the opposite scroll
6307 margin as result of the scroll.
6308 (syms_of_xdisp) <scroll-conservatively>: Document the
6309 threshold of 100 lines for never-recentering scrolling.
6310
6311 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6312
6313 * dispextern.h (move_it_by_lines):
6314 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6315 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6316 (message_log_check_duplicate): Remove parameters `prev_bol' and
6317 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6318 (redisplay_internal): Remove parameter `preserve_echo_area',
6319 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6320
6321 * indent.c (Fvertical_motion):
6322 * window.c (window_scroll_pixel_based, Frecenter):
6323 Don't pass `need_y_p' to `move_it_by_lines'.
6324
6325 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6326
6327 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6328 steal a few bits to be more compact.
6329 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6330 Remove unneeded casts.
6331
6332 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6333
6334 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6335
6336 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6337 binding" message (bug#7967).
6338
6339 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6340
6341 Fix more problems found by GCC 4.6.0's static checks.
6342
6343 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6344 Remove unused local var.
6345
6346 * editfns.c (Fmessage_box): Remove unused local var.
6347
6348 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6349 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6350 Omit unused local vars.
6351 * window.c (shrink_windows): Omit unused local var.
6352 * menu.c (digest_single_submenu): Omit unused local var.
6353 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6354 Omit unused local var.
6355
6356 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6357 Don't assume string length fits in int.
6358 (keyremap_step, read_key_sequence): Use size_t for sizes.
6359 (read_key_sequence): Don't check last_real_key_start redundantly.
6360
6361 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6362 instead of alloca (Bug#8344).
6363
6364 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6365 (Fbacktrace_frame): Don't assume nframes fits in int.
6366
6367 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6368
6369 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6370 concerns.
6371
6372 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6373
6374 * cm.c (calccost): Turn while-do into do-while, for clarity.
6375
6376 * keyboard.c (syms_of_keyboard): Use the same style as later
6377 in this function when indexing through an array. This also
6378 works around GCC bug 48267.
6379
6380 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6381
6382 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6383
6384 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6385 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6386
6387 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6388 This avoids undefined behavior on integer overflow, and is a bit
6389 more convenient anyway since it is compared to a size_t variable.
6390
6391 Variadic C functions now count arguments with size_t, not int.
6392 This avoids an unnecessary limitation on 64-bit machines, which
6393 caused (substring ...) to crash on large vectors (Bug#8344).
6394 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6395 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6396 All variadic functions and their callers changed accordingly.
6397 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6398 * data.c (arith_driver, float_arith_driver): Likewise.
6399 * editfns.c (general_insert_function): Likewise.
6400 * eval.c (struct backtrace.nargs, interactive_p)
6401 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6402 (funcall_lambda, mark_backtrace): Likewise.
6403 * fns.c (concat): Likewise.
6404 * frame.c (x_set_frame_parameters): Likewise.
6405 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6406 0 if not found, not -1. All callers changed.
6407
6408 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6409 (stack_copy_size): Now size_t, not int.
6410 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6411
6412 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6413
6414 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6415 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6416 All callers changed.
6417
6418 * lisp.h (multibyte_char_to_unibyte):
6419 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6420 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6421 * character.h (CHAR_TO_BYTE8):
6422 * cmds.c (internal_self_insert):
6423 * editfns.c (general_insert_function):
6424 * keymap.c (push_key_description):
6425 * search.c (Freplace_match):
6426 * xdisp.c (message_dolog, set_message_1): All callers changed.
6427
6428 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6429
6430 * keyboard.c (safe_run_hook_funcall): New function.
6431 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6432 don't set the hook to nil, but remove the offending function instead.
6433 (Qcommand_hook_internal): Remove, unused.
6434 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6435 Vcommand_hook_internal.
6436
6437 * eval.c (enum run_hooks_condition): Remove.
6438 (funcall_nil, funcall_not): New functions.
6439 (run_hook_with_args): Call each function through a `funcall' argument.
6440 Remove `cond' argument, now redundant.
6441 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6442 (Frun_hook_with_args_until_failure): Adjust accordingly.
6443 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6444
6445 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6446
6447 * dispextern.h (string_buffer_position): Remove declaration.
6448
6449 * print.c (strout): Remove parameter `multibyte', unused since
6450 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6451
6452 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6453 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6454 All callers changed.
6455
6456 * w32.c (_wsa_errlist): Use braces for struct initializers.
6457
6458 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6459 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6460 All callers changed.
6461 (string_buffer_position): Likewise. Also, make static (it's never
6462 used outside xdisp.c).
6463 (cursor_row_p): Remove parameter `w', unused since
6464 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6465 (decode_mode_spec): Remove parameter `precision', introduced during
6466 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6467 All callers changed.
6468
6469 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6470
6471 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6472
6473 2011-03-27 Anders Lindgren <andlind@gmail.com>
6474
6475 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6476 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6477 (ns_update_auto_hide_menu_bar): New functions.
6478 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6479 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6480 ns_constrain_all_frames.
6481 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6482 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6483
6484 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6485
6486 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6487
6488 2011-03-27 Glenn Morris <rgm@gnu.org>
6489
6490 * syssignal.h: Replace RETSIGTYPE with void.
6491 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6492 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6493 Replace SIGTYPE with void everywhere.
6494 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6495 * s/template.h (SIGTYPE): Remove commented out definition.
6496
6497 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6498
6499 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6500 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6501
6502 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6503
6504 * w32.c (read_unc_volume): Use parameter `henum', instead of
6505 global variable `wget_enum_handle'.
6506
6507 * keymap.c (describe_vector): Remove parameters `indices' and
6508 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6509 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6510
6511 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6512
6513 * keyboard.c (timer_check): Remove parameter `do_it_now',
6514 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6515 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6516 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6517
6518 * keyboard.c (read_char):
6519 * w32menu.c (w32_menu_display_help):
6520 * xmenu.c (show_help_event, menu_help_callback):
6521 Adjust calls to `show_help_echo'.
6522
6523 * gtkutil.c (xg_maybe_add_timer):
6524 * keyboard.c (readable_events):
6525 * process.c (wait_reading_process_output):
6526 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6527
6528 * insdel.c (adjust_markers_gap_motion):
6529 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6530 (gap_left, gap_right): Don't call it.
6531
6532 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6533
6534 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6535 incurred during fontification.
6536
6537 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6538
6539 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6540 (DEFVAR_PER_BUFFER): Don't pass it.
6541
6542 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6543 (scrolling_window): Don't pass it.
6544
6545 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6546
6547 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6548
6549 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6550 and `suffix'.
6551 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6552 of variables specific to SELinux and computation of `encoded_absname'.
6553
6554 * image.c (XPutPixel): Remove unused variable `height'.
6555
6556 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6557
6558 * unexw32.c (get_section_info): Remove unused variable `section'.
6559
6560 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6561 (system_process_attributes): Remove unused variable `sess'.
6562 (sys_read): Remove unused variable `err'.
6563
6564 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6565 (w32_wnd_proc): Remove unused variable `isdead'.
6566 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6567 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6568 (x_create_tip_frame): Remove unused variable `tem'.
6569
6570 * w32inevt.c (w32_console_read_socket):
6571 Remove unused variable `no_events'.
6572
6573 * w32term.c (x_draw_composite_glyph_string_foreground):
6574 Remove unused variable `width'.
6575
6576 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6577
6578 * w32term.c (x_set_glyph_string_clipping):
6579 Don't pass uninitialized region to CombineRgn.
6580
6581 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6582
6583 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6584 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6585 (Fx_close_connection): Remove unused variable `i'.
6586
6587 * w32font.c (w32font_draw): Return number of glyphs.
6588 (w32font_open_internal): Remove unused variable `i'.
6589 (w32font_driver): Add missing initializer.
6590
6591 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6592 (fill_in_menu): Remove unused variable `items_added'.
6593
6594 * w32term.c (last_mouse_press_frame): Remove static global variable.
6595 (w32_clip_to_row): Remove unused variable `f'.
6596 (x_delete_terminal): Remove unused variable `i'.
6597
6598 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6599 (NOTHING): Remove unused static global variable.
6600 (uniscribe_check_otf): Remove unused variable `table'.
6601 (uniscribe_font_driver): Add missing initializers.
6602
6603 2011-03-23 Julien Danjou <julien@danjou.info>
6604
6605 * term.c (Fsuspend_tty, Fresume_tty):
6606 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6607 * window.c (temp_output_buffer_show):
6608 * insdel.c (signal_before_change):
6609 * frame.c (Fhandle_switch_frame):
6610 * fileio.c (Fdo_auto_save):
6611 * emacs.c (Fkill_emacs):
6612 * editfns.c (save_excursion_restore):
6613 * cmds.c (internal_self_insert):
6614 * callint.c (Fcall_interactively):
6615 * buffer.c (Fkill_all_local_variables):
6616 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6617 Use Frun_hooks.
6618 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6619 unconditionnaly since it does the check itself.
6620
6621 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6622
6623 Fix more problems found by GCC 4.5.2's static checks.
6624
6625 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6626 the first time through the loop, since we know p0 < p1 then.
6627 This also avoids a gcc -Wstrict-overflow warning.
6628
6629 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6630 leading to a memory leak, possible in functions like
6631 load_charset_map_from_file that can allocate an unbounded number
6632 of objects (Bug#8318).
6633
6634 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6635 that could (at least in theory) be that large.
6636
6637 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6638 This is less likely to overflow, and avoids undefined behavior if
6639 overflow does occur. All callers changed. Use strtoul to scan
6640 for the unsigned long integer.
6641 (pint2hrstr): Simplify and tune code slightly.
6642 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6643
6644 * scroll.c (do_scrolling): Work around GCC bug 48228.
6645 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6646
6647 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6648 This also avoids a warning with gcc -Wstrict-overflow.
6649 (validate_x_resource_name): Simplify count usage.
6650 This also avoids a warning with gcc -Wstrict-overflow.
6651
6652 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6653 fail (Bug#8306).
6654
6655 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6656
6657 * process.c (Fmake_network_process): Use socklen_t, not int,
6658 where POSIX says socklen_t is required in portable programs.
6659 This fixes a porting bug on hosts like 64-bit HP-UX, where
6660 socklen_t is wider than int (Bug#8277).
6661 (Fmake_network_process, server_accept_connection):
6662 (wait_reading_process_output, read_process_output):
6663 Likewise.
6664
6665 * process.c: Rename or move locals to avoid shadowing.
6666 (list_processes_1, Fmake_network_process):
6667 (read_process_output_error_handler, exec_sentinel_error_handler):
6668 Rename or move locals.
6669 (Fmake_network_process): Define label "retry_connect" only if needed.
6670 (Fnetwork_interface_info): Fix pointer signedness.
6671 (process_send_signal): Add cast to avoid pointer signedness problem.
6672 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6673 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6674
6675 Make tparam.h and terminfo.c consistent.
6676 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6677 Include tparam.h instead, since it declares them.
6678 * cm.h (PC): Remove extern decl; tparam.h now does this.
6679 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6680 * terminfo.c: Include tparam.h, to check interfaces.
6681 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6682 (tparam): Adjust signature to match interface in tparam.h;
6683 this removes some undefined behavior. Check that outstring and len
6684 are zero, which they always are with Emacs.
6685 * tparam.h (PC, BC, UP): New extern decls.
6686
6687 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6688 (xftfont_open): Rename locals to avoid shadowing.
6689
6690 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6691 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6692 (OTF_TAG_SYM): Omit macro if not needed.
6693 (ftfont_list): Remove unused local.
6694 (get_adstyle_property, ftfont_pattern_entity):
6695 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6696 Rename locals to avoid shadowing.
6697
6698 * xfont.c (xfont_list_family): Mark var as initialized.
6699
6700 * xml.c (make_dom): Now static.
6701
6702 * composite.c (composition_compute_stop_pos): Rename local to
6703 avoid shadowing.
6704 (composition_reseat_it): Remove unused locals.
6705 (find_automatic_composition, composition_adjust_point): Likewise.
6706 (composition_update_it): Mark var as initialized.
6707 (find_automatic_composition): Mark vars as initialized,
6708 with a FIXME (Bug#8290).
6709
6710 character.h: Rename locals to avoid shadowing.
6711 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6712 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6713 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6714 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6715 to avoid shadowing.
6716
6717 * textprop.c (property_change_between_p): Remove; unused.
6718
6719 * intervals.c (interval_start_pos): Now static.
6720
6721 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6722
6723 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6724 Rename locals to avoid shadowing.
6725
6726 * sound.c (wav_play, au_play, Fplay_sound_internal):
6727 Fix pointer signedness.
6728 (alsa_choose_format): Remove unused local var.
6729 (wav_play): Initialize a variable to 0, to prevent undefined
6730 behavior (Bug#8278).
6731
6732 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6733
6734 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6735
6736 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6737 clobbering (Bug#8298).
6738 * sysdep.c (sys_subshell): Likewise.
6739 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6740
6741 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6742 This should get cleaned up, so that child_setup has the
6743 same signature on all platforms.
6744
6745 * callproc.c (call_process_cleanup): Now static.
6746 (relocate_fd): Rename locals to avoid shadowing.
6747
6748 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6749
6750 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6751 not to be necessary, and produces flickering.
6752
6753 2011-03-20 Glenn Morris <rgm@gnu.org>
6754
6755 * config.in: Remove file.
6756
6757 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6758
6759 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6760 are now in src/globals.h.
6761 (syms_of_minibuf): Remove spurious & from previous change.
6762
6763 2011-03-20 Leo <sdl.web@gmail.com>
6764
6765 * minibuf.c (completing-read-function): New variable.
6766 (completing-read-default): Rename from completing-read.
6767 (completing-read): Call completing-read-function.
6768
6769 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6770
6771 * xfaces.c (Fx_load_color_file):
6772 Read color file from absolute filename (bug#8250).
6773
6774 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6775
6776 * makefile.w32-in: Update dependencies.
6777
6778 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6779
6780 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6781
6782 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6783
6784 Fix more problems found by GCC 4.5.2's static checks.
6785
6786 * process.c (make_serial_process_unwind, send_process_trap):
6787 (sigchld_handler): Now static.
6788
6789 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6790 That way, the code declares only the vars that it needs.
6791 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6792 * s/cygwin.h (PTY_ITERATION): Likewise.
6793 * s/darwin.h (PTY_ITERATION): Likewise.
6794 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6795
6796 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6797 * process.c (allocate_pty): Don't declare stb unless it's needed.
6798
6799 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6800 (CONSTANTLIM): Remove; unused.
6801 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6802 Define only if needed.
6803
6804 * unexelf.c (unexec): Name an expression,
6805 to avoid gcc -Wbad-function-cast warning.
6806 Use a different way to cause a compilation error if anyone uses
6807 n rather than nn, a way that does not involve shadowing.
6808 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6809
6810 * deps.mk (unexalpha.o): Remove; unused.
6811
6812 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6813 * unexec.h: New file.
6814 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6815 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6816 Depend on unexec.h.
6817 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6818 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6819 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6820 Change as necessary to match prototype in unexec.h.
6821
6822 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6823 shadowing.
6824 (back_comment, skip_chars): Mark vars as initialized.
6825
6826 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6827 Rename locals to avoid shadowing.
6828
6829 * lread.c (read1): Rewrite so as not to use empty "else".
6830 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6831
6832 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6833
6834 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6835 warning when compiling print.c.
6836
6837 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6838 instead of using an uninitialized var.
6839 (font_sort_entities): Mark var as initialized.
6840
6841 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6842
6843 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6844 pointers to constants.
6845 (font_parse_fcname): Remove unused vars.
6846 (font_delete_unmatched): Now static.
6847 (font_get_spec): Remove; unused.
6848 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6849 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6850 Rename or move locals to avoid shadowing.
6851
6852 * fns.c (require_nesting_list, require_unwind): Now static.
6853 (Ffillarray): Rename locals to avoid shadowing.
6854
6855 * floatfns.c (domain_error2): Define only if needed.
6856 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6857
6858 * alloc.c (mark_backtrace): Move decl from here ...
6859 * lisp.h: ... to here, so that it can be checked.
6860
6861 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6862 (Fdefvar): Rewrite so as not to use empty "else".
6863 (lisp_indirect_variable): Name an expression,
6864 to avoid gcc -Wbad-function-cast warning.
6865 (Fdefvar): Rename locals to avoid shadowing.
6866
6867 * callint.c (quotify_arg, quotify_args): Now static.
6868 (Fcall_interactively): Rename locals to avoid shadowing.
6869 Use const pointer when appropriate.
6870
6871 * lisp.h (get_system_name, get_operating_system_release):
6872 Move decls here, to check interfaces.
6873 * process.c (get_operating_system_release): Move decl to lisp.h.
6874 * xrdb.c (get_system_name): Likewise.
6875 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6876 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6877 some of which prompt warnings from gcc -Wbad-function-cast.
6878 (Fformat_time_string, Fencode_time, Finsert_char):
6879 (Ftranslate_region_internal, Fformat):
6880 Rename or remove local vars to avoid shadowing.
6881 (Ftranslate_region_internal): Mark var as initialized.
6882
6883 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6884 avoid shadowing.
6885
6886 * lisp.h (eassert): Check that the argument compiles, even if
6887 ENABLE_CHECKING is not defined.
6888
6889 * data.c (Findirect_variable): Name an expression, to avoid
6890 gcc -Wbad-function-cast warning.
6891 (default_value, arithcompare, arith_driver, arith_error): Now static.
6892 (store_symval_forwarding): Rename local to avoid shadowing.
6893 (Fmake_variable_buffer_local, Fmake_local_variable):
6894 Mark variables as initialized.
6895 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6896
6897 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6898 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6899 Rename locals to avoid shadowing.
6900 (mark_stack): Move local variables into the #ifdef region where
6901 they're used.
6902 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6903 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6904 needed otherwise.
6905 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6906 (GC_STRING_CHARS): Remove; not used.
6907 (Fmemory_limit): Cast sbrk's returned value to char *.
6908
6909 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6910 avoids undefined behavior in theory.
6911
6912 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6913
6914 Use functions, not macros, for up- and down-casing (Bug#8254).
6915 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6916 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6917 to use the following functions instead of these macros.
6918 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6919 EMACS_INT, since callers assume the returned value fits in int.
6920 (upcase1): Likewise, for UPCASE_TABLE.
6921 (uppercasep, lowercasep, upcase): New static inline functions.
6922 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6923 the race-condition problem in the old DOWNCASE.
6924
6925 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6926 Rename locals to avoid shadowing.
6927 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6928 (regex_compile, re_search_2, re_match_2_internal):
6929 Remove unused local vars.
6930 (FREE_VAR): Rewrite so as not to use empty "else",
6931 which gcc can warn about.
6932 (regex_compile, re_match_2_internal): Mark locals as initialized.
6933 (RETALLOC_IF): Define only if needed.
6934 (WORDCHAR_P): Likewise. This one is never needed, but is used
6935 only in a comment talking about a compiler bug, so put inside
6936 the #if 0 of that comment.
6937 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6938 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6939 Remove; unused.
6940
6941 * search.c (boyer_moore): Rename locals to avoid shadowing.
6942 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6943 (PREV_CHAR_BOUNDARY): Likewise.
6944
6945 * search.c (simple_search): Remove unused var.
6946
6947 * dired.c (compile_pattern): Move decl from here ...
6948 * lisp.h: ... to here, so that it can be checked.
6949 (struct re_registers): New forward decl.
6950
6951 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6952
6953 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6954 All uses changed.
6955 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6956 Rename locals to avoid shadowing.
6957 (Fvertical_motion): Mark locals as initialized.
6958
6959 * casefiddle.c (casify_object, casify_region): Now static.
6960 (casify_region): Mark local as initialized.
6961
6962 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6963
6964 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6965 New macros, so that the caller can use some names other than
6966 gcpro1, gcpro2, etc.
6967 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6968 of the new macros.
6969 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6970 argument, for consistency with GCPRO2_VAR, etc: it is now the
6971 prefix of the variable, not the variable itself. All uses
6972 changed.
6973 * dired.c (directory_files_internal, file_name_completion):
6974 Rename locals to avoid shadowing.
6975
6976 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6977 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6978 dired.c's scmp function, had undefined behavior.
6979 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6980 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6981 * buffer.h: ... to here, because these macros use current_buffer,
6982 and the new implementation with inline functions needs to have
6983 current_buffer in scope now, rather than later when the macros
6984 are used.
6985 (downcase, upcase1): New static inline functions.
6986 (DOWNCASE, UPCASE1): Reimplement using these functions.
6987 This avoids undefined behavior in expressions like
6988 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6989 from race conditions in accessing the global variables
6990 case_temp1 and case_temp2.
6991 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6992 * lisp.h (case_temp1, case_temp2): Remove their decls.
6993 * character.h (ASCII_CHAR_P): Move from here ...
6994 * lisp.h: ... to here, so that the inline functions mentioned
6995 above can use them.
6996
6997 * dired.c (directory_files_internal_unwind): Now static.
6998
6999 * fileio.c (file_name_as_directory, directory_file_name):
7000 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7001 Now static.
7002 (file_name_as_directory): Use const pointers when appropriate.
7003 (Fexpand_file_name): Likewise. In particular, newdir might
7004 point at constant storage, so make it a const pointer.
7005 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7006 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7007 signedness issues.
7008 (Fset_file_times, Finsert_file_contents, auto_save_error):
7009 Rename locals to avoid shadowing.
7010
7011 * minibuf.c (choose_minibuf_frame_1): Now static.
7012 (Ftry_completion, Fall_completions): Rename or remove locals
7013 to avoid shadowing.
7014
7015 * marker.c (bytepos_to_charpos): Remove; unused.
7016
7017 * lisp.h (verify_bytepos, count_markers): New decls,
7018 so that gcc does not warn that these functions aren't declared.
7019
7020 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7021 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7022 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7023 (copy_text): Remove unused local var.
7024
7025 * filelock.c (within_one_second): Now static.
7026 (lock_file_1): Rename local to avoid shadowing.
7027
7028 * buffer.c (fix_overlays_before): Mark locals as initialized.
7029 (fix_start_end_in_overlays): Likewise. This function should be
7030 simplified by using pointers-to-pointers, but that's a different
7031 matter.
7032 (switch_to_buffer_1): Now static.
7033 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7034 (report_overlay_modification): Rename locals to avoid shadowing.
7035
7036 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7037 Fix pointer signedness issue.
7038 (sys_subshell): Mark local as volatile if checking for lint,
7039 to suppress a gcc -Wclobbered warning that does not seem to be right.
7040 (MAXPATHLEN): Define only if needed.
7041
7042 * process.c (serial_open, serial_configure): Move decls from here ...
7043 * systty.h: ... to here, so that they can be checked.
7044
7045 * fns.c (get_random, seed_random): Move extern decls from here ...
7046 * lisp.h: ... to here, so that they can be checked.
7047
7048 * sysdep.c (reset_io): Now static.
7049 (wait_for_termination_signal): Remove; unused.
7050
7051 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7052 (copy_keymap_item, append_key, push_text_char_description):
7053 Now static.
7054 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7055 (DENSE_TABLE_SIZE): Remove; unused.
7056 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7057 (describe_map_tree):
7058 Rename locals to avoid shadowing.
7059
7060 * keyboard.c: Declare functions static if they are not used elsewhere.
7061 (echo_char, echo_dash, cmd_error, top_level_2):
7062 (poll_for_input, handle_async_input): Now static.
7063 (read_char, kbd_buffer_get_event, make_lispy_position):
7064 (make_lispy_event, make_lispy_movement, apply_modifiers):
7065 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7066 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7067 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7068 (read_key_sequence, read_char): Mark locals as initialized.
7069 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7070
7071 * keyboard.h (make_ctrl_char): New decl.
7072 (mark_kboards): Move decl here ...
7073 * alloc.c (mark_kboards): ... from here.
7074
7075 * lisp.h (force_auto_save_soon): New decl.
7076
7077 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7078 (DEFINE_DUMMY_FUNCTION): New macro.
7079 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7080 Use it.
7081 (main): Add casts to avoid warnings
7082 if GCC considers string literals to be constants.
7083
7084 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7085
7086 * dbusbind.c: Pointer signedness fixes.
7087 (xd_signature, xd_append_arg, xd_initialize):
7088 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7089 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7090 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7091 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7092
7093 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7094 if GCC considers string literals to be constants.
7095 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7096
7097 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7098
7099 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7100 (print_preprocess, print_object): New macro to fix last change.
7101
7102 * print.c (print_preprocess): Don't forget font objects.
7103
7104 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7105
7106 * emacs.c (USAGE3): Doc fixes.
7107
7108 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7109
7110 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7111 structure.
7112
7113 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7114
7115 * lisp.h (VWindow_system, Qfile_name_history):
7116 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7117 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7118 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7119
7120 * w32select.c: Don't #include "keyboard.h".
7121 (run_protected): Add extern declaration for waiting_for_input.
7122
7123 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7124 * w32console.c (detect_input_pending, read_input_pending)
7125 (encode_terminal_code):
7126 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7127 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7128 (w32_system_caret_y, Qfile_name_history):
7129 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7130 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7131 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7132 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7133 * w32proc.c (Qlocal, report_file_error):
7134 * w32term.c (Vwindow_system, updating_frame):
7135 * w32uniscribe.c (initialized, uniscribe_font_driver):
7136 Remove unneeded extern declarations.
7137
7138 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7139
7140 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7141
7142 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7143
7144 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7145 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7146 These macros can no longer be used for assignment.
7147
7148 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7149 Assign struct members directly, instead of using BUF_BEGV etc.
7150 (record_buffer_markers, fetch_buffer_markers): New functions for
7151 recording and fetching special buffer markers.
7152 (set_buffer_internal_1, set_buffer_temp): Use them.
7153
7154 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7155
7156 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7157
7158 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7159 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7160
7161 * xdisp.c (hscroll_window_tree):
7162 (reconsider_clip_changes): Use PT instead of BUF_PT.
7163
7164 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7165
7166 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7167 $(EMACS_ROOT)/lib/intprops.h.
7168
7169 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7170
7171 Fix more problems found by GCC 4.5.2's static checks.
7172
7173 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7174 to unsigned char * to avoid compiler diagnostic.
7175 (xg_free_frame_widgets): Make it clear that a local variable is
7176 needed only if USE_GTK_TOOLTIP.
7177 (gdk_window_get_screen): Make it clear that this macro is needed
7178 only if USE_GTK_TOOLTIP.
7179 (int_gtk_range_get_value): New function, which avoids a diagnostic
7180 from gcc -Wbad-function-cast.
7181 (xg_set_toolkit_scroll_bar_thumb): Use it.
7182 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7183 diagnostic from gcc -Wbad-function-cast.
7184 (get_utf8_string, xg_get_file_with_chooser):
7185 Rename locals to avoid shadowing.
7186 (create_dialog): Move locals to avoid shadowing.
7187
7188 * xgselect.c (xg_select): Remove unused var.
7189
7190 * image.c (four_corners_best): Mark locals as initialized.
7191 (gif_load): Initialize transparent_p to zero (Bug#8238).
7192 Mark another local as initialized.
7193 (my_png_error, my_error_exit): Mark with NO_RETURN.
7194
7195 * image.c (clear_image_cache): Now static.
7196 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7197 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7198 (x_edge_detection): Remove unnecessary cast that
7199 gcc -Wbad-function-cast diagnoses.
7200 (gif_load): Fix pointer signedness.
7201 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7202 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7203
7204 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7205
7206 Improve quality of tests for time stamp overflow.
7207 For example, without this patch (encode-time 0 0 0 1 1
7208 1152921504606846976) returns the obviously-bogus value (-948597
7209 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7210 reports time overflow. See
7211 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7212 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7213 * editfns.c: Include limits.h and intprops.h.
7214 (TIME_T_MIN, TIME_T_MAX): New macros.
7215 (time_overflow): Move earlier, to before first use.
7216 (hi_time, lo_time): New functions, for an accurate test for
7217 out-of-range times.
7218 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7219 (Fget_internal_run_time): Don't assume time_t fits in int.
7220 (make_time): Use list2 instead of Fcons twice.
7221 (Fdecode_time): More accurate test for out-of-range times.
7222 (check_tm_member): New function.
7223 (Fencode_time): Use it, to test for out-of-range times.
7224 (lisp_time_argument): Don't rely on undefined left-shift and
7225 right-shift behavior when checking for time stamp overflow.
7226
7227 * editfns.c (time_overflow): New function, refactoring common code.
7228 (Fformat_time_string, Fdecode_time, Fencode_time):
7229 (Fcurrent_time_string): Use it.
7230
7231 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7232 * dired.c (make_time): Move to ...
7233 * editfns.c (make_time): ... here.
7234 * systime.h: Note the move.
7235
7236 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7237
7238 * fringe.c (update_window_fringes): Remove unused variables.
7239
7240 * unexmacosx.c (copy_data_segment): Also copy __got section.
7241 (Bug#8223)
7242
7243 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7244
7245 * termcap.c [MSDOS]: Include "msdos.h".
7246 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7247 Constify `char *' arguments and their references according to
7248 prototypes in tparam.h.
7249
7250 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7251
7252 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7253 Adapt all references accordingly.
7254
7255 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7256
7257 2011-03-11 Tom Tromey <tromey@redhat.com>
7258
7259 * buffer.c (syms_of_buffer): Remove obsolete comment.
7260
7261 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7262
7263 * termhooks.h (encode_terminal_code): Declare prototype.
7264
7265 * msdos.c (encode_terminal_code): Don't declare prototype.
7266
7267 * term.c (encode_terminal_code): Now external again, used by
7268 w32console.c and msdos.c.
7269
7270 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7271 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7272
7273 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7274
7275 Fix some minor problems found by GCC 4.5.2's static checks.
7276
7277 * fringe.c (update_window_fringes): Mark locals as initialized
7278 (Bug#8227).
7279 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7280
7281 * alloc.c (mark_fringe_data): Move decl from here ...
7282 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7283 to check its interface.
7284 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7285
7286 * fontset.c (free_realized_fontset): Now static.
7287 (Fset_fontset_font): Rename local to avoid shadowing.
7288 (fontset_font): Mark local as initialized.
7289 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7290
7291 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7292
7293 * xselect.c (x_disown_buffer_selections): Remove; not used.
7294 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7295 (x_own_selection, Fx_disown_selection_internal): Rename locals
7296 to avoid shadowing.
7297 (x_handle_dnd_message): Remove local to avoid shadowing.
7298
7299 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7300 so that the caller can use some name other than gcpro1.
7301 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7302 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7303 (Fx_backspace_delete_keys_p):
7304 Use them to avoid shadowing, and rename vars to avoid shadowing.
7305 (x_decode_color, x_set_name, x_window): Now static.
7306 (Fx_create_frame): Add braces to silence GCC warning.
7307 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7308 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7309 Remove unused locals.
7310 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7311 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7312 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7313 macros.
7314
7315 * xterm.h (x_mouse_leave): New decl.
7316
7317 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7318 Remove unused functions.
7319 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7320 (x_calc_absolute_position): Now static.
7321 (XTread_socket): Don't define label "out" unless it's used.
7322 Don't declare local "event" unless it's used.
7323 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7324 unless they are used.
7325 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7326 (x_fatal_error_signal): Remove; not used.
7327 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7328 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7329 (x_error_catcher, x_connection_closed, x_error_handler):
7330 (x_error_quitter, xembed_send_message, x_iconify_frame):
7331 (my_log_handler): Rename locals to avoid shadowing.
7332 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7333 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7334
7335 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7336 Rename or move locals to avoid shadowing.
7337 (tty_defined_color, merge_face_heights): Now static.
7338 (free_realized_faces_for_fontset): Remove; not used.
7339 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7340 does not deduce is never used uninitialized.
7341 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7342 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7343
7344 * terminal.c (store_terminal_param): Now static.
7345
7346 * xmenu.c (menu_highlight_callback): Now static.
7347 (set_frame_menubar): Remove unused local.
7348 (xmenu_show): Rename parameter to avoid shadowing.
7349 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7350 since they might point to immutable storage.
7351 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7352 since it's unused otherwise.
7353
7354 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7355 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7356 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7357 avoids a gcc -Wuninitialized diagnostic.
7358 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7359 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7360 does not deduce are never used uninitialized.
7361
7362 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7363
7364 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7365 * window.c (window_loop, size_window):
7366 (run_window_configuration_change_hook, enlarge_window): Likewise.
7367
7368 * window.c (display_buffer): Now static.
7369 (size_window): Mark variables that gcc -Wuninitialized
7370 does not deduce are never used uninitialized.
7371 * window.h (check_all_windows): New decl, to forestall
7372 gcc -Wmissing-prototypes diagnostic.
7373 * dispextern.h (bidi_dump_cached_states): Likewise.
7374
7375 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7376 shadowing.
7377 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7378 Include <limits.h>.
7379 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7380 and to avoid gcc -Wuninitialized warning.
7381 (load_charset_map): Mark variables that gcc -Wuninitialized
7382 does not deduce are never used uninitialized.
7383 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7384
7385 * coding.c (coding_set_source, coding_set_destination):
7386 Use "else { /* comment */ }" rather than "else /* comment */;"
7387 for clarity, and to avoid gcc -Wempty-body warning.
7388 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7389 a block, when the outer 'i' will do.
7390 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7391 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7392 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7393 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7394 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7395 Rename locals to avoid shadowing.
7396 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7397 * coding.c (emacs_mule_char, encode_invocation_designation):
7398 Now static, since they're not used elsewhere.
7399 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7400 (decode_coding_object, encode_coding_object, detect_coding_system):
7401 (decode_coding_emacs_mule): Mark variables that gcc
7402 -Wuninitialized does not deduce are never used uninitialized.
7403 (detect_coding_iso_2022): Initialize a local variable that might
7404 be used uninitialized. Leave a FIXME because it's not clear that
7405 this initialization is needed. (Bug#8211)
7406 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7407 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7408 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7409 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7410 Remove unused macros.
7411
7412 * category.c (hash_get_category_set): Remove unused local var.
7413 (copy_category_table): Now static, since it's not used elsewhere.
7414 * character.c (string_count_byte8): Likewise.
7415
7416 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7417 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7418
7419 * chartab.c (copy_sub_char_table): Now static, since it's not used
7420 elsewhere.
7421 (sub_char_table_ref_and_range, char_table_ref_and_range):
7422 Rename locals to avoid shadowing.
7423 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7424
7425 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7426 (BIDI_BOB): Remove unused macro.
7427
7428 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7429 deduce are never used uninitialized.
7430 * term.c (encode_terminal_code): Likewise.
7431
7432 * term.c (encode_terminal_code): Now static. Remove unused local.
7433
7434 * tparam.h: New file.
7435 * term.c, tparam.h: Include it.
7436 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7437 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7438 Move these decls to tparam.h, and make them agree with what
7439 is actually in tparam.c. The previous trick of using incompatible
7440 decls in different modules does not conform to the C standard.
7441 All callers of tparam changed to use tparam's actual API.
7442 * tparam.c (tparam1, tparam, tgoto):
7443 Use const pointers where appropriate.
7444
7445 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7446 * cm.h (struct cm): Likewise.
7447 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7448 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7449 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7450 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7451 (turn_on_face, init_tty): Likewise.
7452 * termchar.h (struct tty_display_info): Likewise.
7453
7454 * term.c (term_mouse_position): Rename local to avoid shadowing.
7455
7456 * alloc.c (mark_ttys): Move decl from here ...
7457 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7458
7459 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7460
7461 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7462
7463 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7464
7465 * search.c (compile_pattern_1): Remove argument regp, unused since
7466 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7467 (compile_pattern): Don't pass it.
7468
7469 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7470
7471 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7472 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7473 for ! HAVE_GTK3.
7474 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7475
7476 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7477
7478 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7479 gdk_window_get_screen, gdk_window_get_geometry,
7480 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7481 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7482 (xg_get_pixbuf_from_pixmap): New function.
7483 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7484 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7485 Call xg_get_pixbuf_from_pixmap instead of
7486 gdk_pixbuf_get_from_drawable.
7487 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7488 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7489 (xg_check_special_colors): Use GtkStyleContext and its functions
7490 for HAVE_GTK3.
7491 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7492 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7493 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7494 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7495 Call gtk_widget_get_preferred_size.
7496 (xg_frame_resized): gdk_window_get_geometry only takes 5
7497 parameters.
7498 (xg_win_to_widget, xg_event_is_for_menubar):
7499 Call gdk_x11_window_lookup_for_display.
7500 (xg_set_widget_bg): New function.
7501 (delete_cb): New function.
7502 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7503 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7504 (xg_set_background_color): Call xg_set_widget_bg.
7505 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7506 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7507 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7508 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7509 if ! HAVE_GTK3.
7510 (update_frame_tool_bar): Call gtk_widget_hide.
7511 (xg_initialize): Use GDK_KEY_g.
7512
7513 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7514 if ! HAVE_GTK3
7515 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7516
7517 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7518 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7519 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7520
7521 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7522
7523 * w32xfns.c (select_palette): Check success of RealizePalette against
7524 GDI_ERROR, not zero.
7525
7526 See ChangeLog.11 for earlier changes.
7527
7528 ;; Local Variables:
7529 ;; coding: utf-8
7530 ;; End:
7531
7532 Copyright (C) 2011 Free Software Foundation, Inc.
7533
7534 This file is part of GNU Emacs.
7535
7536 GNU Emacs is free software: you can redistribute it and/or modify
7537 it under the terms of the GNU General Public License as published by
7538 the Free Software Foundation, either version 3 of the License, or
7539 (at your option) any later version.
7540
7541 GNU Emacs is distributed in the hope that it will be useful,
7542 but WITHOUT ANY WARRANTY; without even the implied warranty of
7543 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7544 GNU General Public License for more details.
7545
7546 You should have received a copy of the GNU General Public License
7547 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.