Fix services menu empty on OSX 1.6+.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2
3 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4
5 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6 on svcsMenu (Bug#8842).
7
8 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9 ns_return_types.
10 (Fns_list_services): Just return Qnil on 10.6, code not working there.
11
12 * nsterm.m (QUTF8_STRING): Declare.
13 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
14 (validRequestorForSendType): Return type is (id).
15 Change indexOfObjectIdenticalTo to indexOfObject.
16 Check if we have local selection before returning self (Bug#8842).
17 (writeSelectionToPasteboard): Put local selection into paste board
18 if we have a local selection (Bug#8842).
19 (syms_of_nsterm): DEFSYM QUTF8_STRING.
20
21 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
22 (ns_get_local_selection): Declare.
23
24 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
25
26 * keymap.c (describe_map_tree): Don't insert a double newline at
27 the end of the buffer (bug#1169) and return whether we inserted
28 something.
29
30 * callint.c (Fcall_interactively): Change "reading args" to
31 "providing args" to try to clarify what it does (bug#1010).
32
33 2011-07-07 Kenichi Handa <handa@m17n.org>
34
35 * composite.c (composition_compute_stop_pos): Ignore a static
36 composition starting before CHARPOS (Bug#8915).
37
38 * xdisp.c (handle_composition_prop): Likewise.
39
40 2011-07-07 Eli Zaretskii <eliz@gnu.org>
41
42 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
43 (Bug#9015)
44
45 2011-07-07 Kenichi Handa <handa@m17n.org>
46
47 * character.h (unicode_category_t): New enum type.
48
49 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
50 (Qchar_code_property_table): New variable.
51 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
52 (UNIPROP_COMPRESSED_FORM_P): New macros.
53 (char_table_ascii): Uncompress the compressed values.
54 (sub_char_table_ref): New arg is_uniprop. Callers changed.
55 Uncompress the compressed values.
56 (sub_char_table_ref_and_range): Likewise.
57 (char_table_ref_and_range): Uncompress the compressed values.
58 (sub_char_table_set): New arg is_uniprop. Callers changed.
59 Uncompress the compressed values.
60 (sub_char_table_set_range): Args changed. Callers changed.
61 (char_table_set_range): Adjuted for the above change.
62 (map_sub_char_table): Delete args default_val and parent. Add arg
63 top. Give decoded values to a Lisp function.
64 (map_char_table): Adjusted for the above change. Give decoded
65 values to a Lisp function. Gcpro more variables.
66 (uniprop_table_uncompress)
67 (uniprop_decode_value_run_length): New functions.
68 (uniprop_decoder, uniprop_decoder_count): New variables.
69 (uniprop_get_decoder, uniprop_encode_value_character)
70 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
71 New functions.
72 (uniprop_encoder, uniprop_encoder_count): New variables.
73 (uniprop_get_encoder, uniprop_table)
74 (Funicode_property_table_internal, Fget_unicode_property_internal)
75 (Fput_unicode_property_internal): New functions.
76 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
77 Sunicode_property_table_internal, Sget_unicode_property_internal,
78 and Sput_unicode_property_internal. Defvar_lisp
79 char-code-property-alist.
80
81 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
82 Vunicode_category_table.
83
84 * font.c (font_range): Adjusted for the change of
85 Vunicode_category_table.
86
87 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
88
89 * m/iris4d.h: Remove file, move contents ...
90 * s/irix6-5.h: ... here.
91
92 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
93
94 Remove unportable assumption about struct layout (Bug#8884).
95 * alloc.c (mark_buffer):
96 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
97 (clone_per_buffer_values): Don't assume that
98 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
99 This isn't true in general, and it's particularly not true
100 if Emacs is configured with --with-wide-int.
101 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
102 New macros, used in the buffer.c change.
103
104 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
105
106 * xsettings.c: Use both GConf and GSettings if both are available.
107 (store_config_changed_event): Add comment.
108 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
109 (store_tool_bar_style_changed): New functions.
110 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
111 (struct xsettings): Move font inside HAVE_XFT.
112 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
113 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
114 Move inside HAVE_XFT.
115 (something_changed_gsettingsCB): Renamed from something_changedCB.
116 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
117 also.
118 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
119 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
120 (something_changed_gconfCB): Renamed from something_changedCB.
121 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
122 (parse_settings): Move check for font inside HAVE_XFT.
123 (read_settings, apply_xft_settings): Add comment.
124 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
125 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
126 call store_font_name_changed.
127 (xft_settings_event): Add comment.
128 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
129 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
130 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
131 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
132 (xsettings_initialize): Call init_gsettings last.
133 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
134 comment.
135
136 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
137
138 Random fixes. E.g., (random) never returned negative values.
139 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
140 subseconds part to the entropy, as that's a bit more random.
141 Prefer signed to unsigned, since the signedness doesn't matter and
142 in general we prefer signed. When given a limit, use a
143 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
144 latter isn't right if USE_2_TAGS_FOR_INTS.
145 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
146 not 0..VALMASK. Don't discard "excess" bits that random () returns.
147
148 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
149
150 * textprop.c (text_property_stickiness):
151 Obey Vtext_property_default_nonsticky.
152 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
153 * w32fns.c (syms_of_w32fns):
154 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
155
156 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
157
158 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
159 This is more efficient than Ffile_directory_p and avoids a minor race.
160
161 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
162
163 * buffer.c (Foverlay_put): Say what the return value is
164 (bug#7835).
165
166 * fileio.c (barf_or_query_if_file_exists): Check first if the file
167 is a directory before asking whether to use the file name
168 (bug#7564).
169 (barf_or_query_if_file_exists): Make the "File is a directory"
170 error be more correct.
171
172 * fns.c (Frequire): Remove the mention of the .gz files, since
173 that's installation-specific, but keep the mention of
174 `get-load-suffixes'.
175
176 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
177
178 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
179 Report string overflow if the output is too long.
180
181 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
182
183 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
184 (syms_of_gnutls): Remove duplicate DEFSYM for
185 Qgnutls_bootprop_verify_hostname_error, an error for
186 Qgnutls_bootprop_verify_error (which is no longer used).
187
188 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
189 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
190 Also (re)move comments that are misplaced or no longer relevant.
191
192 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
193
194 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
195
196 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
197
198 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
199 and background color parameters if they have been changed.
200
201 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
202
203 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
204
205 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
206
207 * xsettings.c (SYSTEM_FONT): Define only when used.
208 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
209
210 * keymap.c (access_keymap_1): Now static.
211
212 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
213
214 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
215 leave any prefix arg for the up event (Bug#1586).
216
217 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
218
219 * lread.c (syms_of_lread): Mention single symbols defined by
220 `defvar' or `defconst' (bug#7154).
221
222 * fns.c (Frequire): Mention .el.gz files (bug#7314).
223 (Frequire): Mention get-load-suffixes.
224
225 2011-07-02 Martin Rudalics <rudalics@gmx.at>
226
227 * window.h (window): Remove clone_number slot.
228 * window.c (Fwindow_clone_number, Fset_window_clone_number):
229 Remove.
230 (make_parent_window, make_window, saved_window)
231 (Fset_window_configuration, save_window_save): Don't deal with
232 clone numbers.
233 * buffer.c (Qclone_number): Remove declaration.
234 (sort_overlays, overlay_strings): Don't deal with clone numbers.
235
236 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
237
238 Add multiple inheritance to keymaps.
239 * keymap.c (Fmake_composed_keymap): New function.
240 (Fset_keymap_parent): Simplify.
241 (fix_submap_inheritance): Remove.
242 (access_keymap_1): New function extracted from access_keymap to handle
243 embedded parents and handle lists of maps.
244 (access_keymap): Use it.
245 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
246 (Fcopy_keymap): Handle embedded parents.
247 (Fcommand_remapping, define_as_prefix): Simplify.
248 (Fkey_binding): Simplify.
249 (syms_of_keymap): Move minibuffer-local-completion-map,
250 minibuffer-local-filename-completion-map,
251 minibuffer-local-must-match-map, and
252 minibuffer-local-filename-must-match-map to Elisp.
253 (syms_of_keymap): Defsubr make-composed-keymap.
254 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
255 (parse_menu_item): Trivial simplification.
256
257 2011-07-01 Glenn Morris <rgm@gnu.org>
258
259 * Makefile.in (SETTINGS_LIBS): Fix typo.
260
261 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
262
263 * coding.c (Fencode_coding_string): Record the last coding system
264 used, as the function doc string says (bug#8738).
265
266 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
267
268 * xsettings.c (store_monospaced_changed): Take new font as arg and
269 check for change against current_mono_font.
270 (EMACS_TYPE_SETTINGS): Remove this and related defines.
271 (emacs_settings_constructor, emacs_settings_get_property)
272 (emacs_settings_set_property, emacs_settings_class_init)
273 (emacs_settings_init, gsettings_obj): Remove.
274 (something_changedCB): New function for HAVE_GSETTINGS.
275 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
276 with value as argument.
277 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
278 g_settings_new (Bug#8967). Do not create gsettings_obj.
279 Remove calls to g_settings_bind. Connect something_changedCB to
280 "changed".
281
282 * xgselect.c: Add defined (HAVE_GSETTINGS).
283 (xgselect_initialize): Ditto.
284
285 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
286 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
287 xg_select.
288
289 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
290
291 * eval.c (struct backtrace): Simplify and port the data structure.
292 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
293 signed bit field, as this assumption is not portable and it makes
294 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
295 "char debug_on_exit : 1" as this is not portable either; instead,
296 use the portable "unsigned int debug_on_exit : 1". Remove unused
297 member evalargs. Remove obsolete comments about cc bombing out.
298
299 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
300
301 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
302 Let HAVE_GSETTINGS override HAVE_GCONF.
303 (store_monospaced_changed): New function.
304 (EMACS_SETTINGS): A new type derived from GObject to handle
305 GSettings notifications.
306 (emacs_settings_constructor, emacs_settings_get_property)
307 (emacs_settings_set_property, emacs_settings_class_init):
308 New functions.
309 (gsettings_client, gsettings_obj): New variables.
310 (GSETTINGS_SCHEMA): New define.
311 (something_changedCB): Call store_monospaced_changed.
312 (init_gsettings): New function.
313 (xsettings_initialize): Call init_gsettings.
314 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
315 to NULL.
316
317 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
318 GCONF_CFLAGS/LIBS.
319
320 2011-06-29 Martin Rudalics <rudalics@gmx.at>
321
322 * window.c (resize_root_window, grow_mini_window)
323 (shrink_mini_window): Rename Qresize_root_window to
324 Qwindow_resize_root_window and Qresize_root_window_vertically to
325 Qwindow_resize_root_window_vertically.
326
327 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
328
329 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
330
331 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
332
333 * makefile.w32-in: Redesign dependencies so they reflect more
334 clearly which files are directly included by each source file,
335 and not through other includes.
336
337 2011-06-27 Martin Rudalics <rudalics@gmx.at>
338
339 * buffer.c (Qclone_number): Declare static and DEFSYM it.
340 (sort_overlays, overlay_strings): When an overlay's clone number
341 matches the window's clone number process the overlay even if
342 the overlay's window property doesn't match the current window.
343
344 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
345 (Fwindow_hchild): Rename to Fwindow_left_child.
346 (Fwindow_next): Rename to Fwindow_next_sibling.
347 (Fwindow_prev): Rename to Fwindow_prev_sibling.
348 (resize_window_check): Rename to window_resize_check.
349 (resize_window_apply): Rename to window_resize_apply.
350 (Fresize_window_apply): Rename to Fwindow_resize_apply.
351 (Fdelete_other_windows_internal, resize_frame_windows)
352 (Fsplit_window_internal, Fdelete_window_internal)
353 (grow_mini_window, shrink_mini_window)
354 (Fresize_mini_window_internal): Fix callers accordingly.
355
356 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
357
358 * emacsgtkfixed.h: State that this is only used with Gtk+3.
359 (emacs_fixed_set_min_size): Remove.
360 (emacs_fixed_new): Take frame as argument.
361
362 * emacsgtkfixed.c: State that this is only used with Gtk+3.
363 (_EmacsFixedPrivate): Remove minwidth/height.
364 Add struct frame *f.
365 (emacs_fixed_init): Initialize priv->f.
366 (get_parent_class, emacs_fixed_set_min_size): Remove.
367 (emacs_fixed_new): Set priv->f to argument.
368 (emacs_fixed_get_preferred_width)
369 (emacs_fixed_get_preferred_height): Use min_width/height from
370 frames size_hint to set minimum and natural (Bug#8919).
371 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
372 and use min_width/height from frames size_hint to set
373 min_width/height (Bug#8919).
374
375 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
376 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
377 Fix indentation.
378
379 2011-06-26 Eli Zaretskii <eliz@gnu.org>
380
381 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
382 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
383 called at ZV.
384
385 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
386
387 * process.c (wait_reading_process_output): Bypass select if
388 waiting for a cell while ignoring keyboard input, and input is
389 pending. Suggested by Jan Djärv (Bug#8869).
390
391 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
392
393 Use gnulib's dup2 module instead of rolling our own.
394 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
395
396 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
397
398 * dispnew.c (scrolling_window): Before scrolling, turn off a
399 mouse-highlight in the window being scrolled.
400
401 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
402
403 Move DEFSYM to lisp.h and use everywhere.
404
405 * character.h (DEFSYM): Move declaration...
406 * lisp.h (DEFSYM): ...here.
407
408 * gnutls.c:
409 * minibuf.c:
410 * w32menu.c:
411 * w32proc.c:
412 * w32select.c: Don't include character.h.
413
414 * alloc.c (syms_of_alloc):
415 * buffer.c (syms_of_buffer):
416 * bytecode.c (syms_of_bytecode):
417 * callint.c (syms_of_callint):
418 * casefiddle.c (syms_of_casefiddle):
419 * casetab.c (init_casetab_once):
420 * category.c (init_category_once, syms_of_category):
421 * ccl.c (syms_of_ccl):
422 * cmds.c (syms_of_cmds):
423 * composite.c (syms_of_composite):
424 * dbusbind.c (syms_of_dbusbind):
425 * dired.c (syms_of_dired):
426 * dispnew.c (syms_of_display):
427 * doc.c (syms_of_doc):
428 * editfns.c (syms_of_editfns):
429 * emacs.c (syms_of_emacs):
430 * eval.c (syms_of_eval):
431 * fileio.c (syms_of_fileio):
432 * fns.c (syms_of_fns):
433 * frame.c (syms_of_frame):
434 * fringe.c (syms_of_fringe):
435 * insdel.c (syms_of_insdel):
436 * keymap.c (syms_of_keymap):
437 * lread.c (init_obarray, syms_of_lread):
438 * macros.c (syms_of_macros):
439 * msdos.c (syms_of_msdos):
440 * print.c (syms_of_print):
441 * process.c (syms_of_process):
442 * search.c (syms_of_search):
443 * sound.c (syms_of_sound):
444 * syntax.c (init_syntax_once, syms_of_syntax):
445 * terminal.c (syms_of_terminal):
446 * textprop.c (syms_of_textprop):
447 * undo.c (syms_of_undo):
448 * w32.c (globals_of_w32):
449 * window.c (syms_of_window):
450 * xdisp.c (syms_of_xdisp):
451 * xfaces.c (syms_of_xfaces):
452 * xfns.c (syms_of_xfns):
453 * xmenu.c (syms_of_xmenu):
454 * xsettings.c (syms_of_xsettings):
455 * xterm.c (syms_of_xterm): Use DEFSYM.
456
457 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
458
459 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
460
461 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
462
463 Integer and buffer overflow fixes (Bug#8873).
464
465 * print.c (printchar, strout): Check for string overflow.
466 (PRINTPREPARE, printchar, strout):
467 Don't set size unless allocation succeeds.
468
469 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
470 for sizes. Check for string overflow more accurately.
471 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
472
473 * macros.c: Integer and buffer overflow fixes.
474 * keyboard.h (struct keyboard.kbd_macro_bufsize):
475 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
476 Use ptrdiff_t, not int, for sizes.
477 Don't increment bufsize until after realloc succeeds.
478 Check for size-calculation overflow.
479 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
480
481 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
482
483 * lread.c: Integer overflow fixes.
484 (read_integer): Radix is now EMACS_INT, not int,
485 to improve quality of diagnostics for out-of-range radices.
486 Calculate buffer size correctly for out-of-range radices.
487 (read1): Check for integer overflow in radices, and in
488 read-circle numbers.
489 (read_escape): Avoid int overflow.
490 (Fload, openp, read_buffer_size, read1)
491 (substitute_object_recurse, read_vector, read_list, map_obarray):
492 Use ptrdiff_t, not int, for sizes.
493 (read1): Use EMACS_INT, not int, for sizes.
494 Check for size overflow.
495
496 * image.c (cache_image): Check for size arithmetic overflow.
497
498 * lread.c: Integer overflow issues.
499 (saved_doc_string_size, saved_doc_string_length)
500 (prev_saved_doc_string_size, prev_saved_doc_string_length):
501 Now ptrdiff_t, not int.
502 (read1): Don't assume doc string length fits in int. Check for
503 out-of-range doc string lengths.
504 (read_list): Don't assume file position fits in int.
505 (read_escape): Check for hex character overflow.
506
507 2011-06-22 Leo Liu <sdl.web@gmail.com>
508
509 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
510 Move to minibuffer.el.
511
512 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
513
514 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
515 The following patches are for when GLYPH_DEBUG && !XASSERT.
516 * dispextern.h (trace_redisplay_p, dump_glyph_string):
517 * dispnew.c (flush_stdout):
518 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
519 Mark as externally visible.
520 * dispnew.c (check_window_matrix_pointers): Now static.
521 * dispnew.c (window_to_frame_vpos):
522 * xfns.c (unwind_create_frame):
523 * xterm.c (x_check_font): Remove unused local.
524 * scroll.c (CHECK_BOUNDS):
525 * xfaces.c (cache_fache): Rename local to avoid shadowing.
526 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
527 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
528 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
529 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
530 Now static.
531 (debug_method_add): Use va_list and vsprintf rather than relying
532 on undefined behavior with wrong number of arguments.
533 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
534 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
535 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
536 since we're not interested in debugging glyphs with old libraries.
537 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
538 GCC 4.6.0's static checking.
539
540 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
541
542 Integer overflow and signedness fixes (Bug#8873).
543 A few related buffer overrun fixes, too.
544
545 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
546
547 * dispextern.h (struct face.stipple):
548 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
549 (x_bitmap_mask, x_allocate_bitmap_record)
550 (x_create_bitmap_from_data, x_create_bitmap_from_file)
551 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
552 (x_create_bitmap_from_xpm_data):
553 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
554 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
555 (.bitmaps_last):
556 * xfaces.c (load_pixmap):
557 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
558 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
559 (.bitmaps_last, struct x_output.icon_bitmap):
560 Use ptrdiff_t, not int, for bitmap indexes.
561 (x_allocate_bitmap_record): Check for size overflow.
562 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
563
564 Use ptrdiff_t, not int, for overlay counts.
565 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
566 * editfns.c (overlays_around, get_pos_property):
567 * textprop.c (get_char_property_and_overlay):
568 * xdisp.c (next_overlay_change, note_mouse_highlight):
569 * xfaces.c (face_at_buffer_position):
570 * buffer.c (OVERLAY_COUNT_MAX): New macro.
571 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
572 (Fnext_overlay_change, Fprevious_overlay_change)
573 (mouse_face_overlay_overlaps, Foverlays_in):
574 Use ptrdiff_t, not int, for sizes.
575 (overlays_at, overlays_in): Check for size-calculation overflow.
576
577 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
578
579 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
580 (x_session_initialize): Do not assume string length fits in int.
581
582 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
583 This is unlikely, but can occur if DPI is outlandish.
584
585 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
586 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
587
588 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
589 * xrdb.c (magic_file_p, search_magic_path):
590 Omit last arg SUFFIX; it was always 0. All callers changed.
591 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
592
593 * xfont.c (xfont_match): Avoid need for strlen.
594
595 * xfns.c: Don't assume strlen fits in int.
596 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
597
598 * xdisp.c (message_log_check_duplicate): Return intmax_t,
599 not unsigned long, as we prefer signed integers. All callers changed.
600 Detect integer overflow in repeat count.
601 (message_dolog): Don't assume print length fits in 39 bytes.
602 (display_mode_element): Don't assume strlen fits in int.
603
604 * termcap.c: Don't assume sizes fit in int and never overflow.
605 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
606 (gobble_line): Check for size-calculation overflow.
607
608 * minibuf.c (Fread_buffer):
609 * lread.c (intern, intern_c_string):
610 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
611 Don't assume string length fits in int.
612
613 * keyboard.c (parse_tool_bar_item):
614 * gtkutil.c (style_changed_cb): Avoid need for strlen.
615
616 * font.c: Don't assume string length fits in int.
617 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
618 Use ptrdiff_t, not int.
619 (font_intern_prop): Don't assume string length fits in int.
620 Don't assume integer property fits in fixnum.
621 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
622
623 * filelock.c: Fix some buffer overrun and integer overflow issues.
624 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
625 Reformulate so as not to need the command string.
626 Invoke gzip -cd rather than gunzip, as it's more portable.
627 (lock_info_type, lock_file_1, lock_file):
628 Don't assume pid_t and time_t fit in unsigned long.
629 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
630 (current_lock_owner): Prefer signed type for sizes.
631 Use memcpy, not strncpy, where memcpy is what is really wanted.
632 Don't assume (via atoi) that time_t and pid_t fit in int.
633 Check for time_t and/or pid_t out of range, e.g., via a network share.
634 Don't alloca where an auto var works fine.
635
636 * fileio.c: Fix some integer overflow issues.
637 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
638 Don't assume string length fits in int.
639 (directory_file_name): Don't assume string length fits in long.
640 (make_temp_name): Don't assume pid fits in int, or that its print
641 length is less than 20.
642
643 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
644
645 * coding.c (make_subsidiaries): Don't assume string length fits in int.
646
647 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
648
649 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
650 We prefer signed integers, even for size calculations.
651
652 * emacs.c: Don't assume string length fits in 'int'.
653 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
654 (main): Don't invoke strlen when not needed.
655
656 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
657 (XD_DEBUG_MESSAGE): Don't waste a byte.
658
659 * callproc.c (getenv_internal_1, getenv_internal)
660 (Fgetenv_internal):
661 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
662
663 * lread.c (invalid_syntax): Omit length argument.
664 All uses changed. This doesn't fix a bug, but it simplifies the
665 code away from its former Hollerith-constant appearance, and it's
666 one less 'int' to worry about when looking at integer-overflow issues.
667 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
668
669 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
670 This didn't break anything, but it didn't help either.
671 It's confusing to put a bogus integer in a place where the actual
672 value does not matter.
673 (LIST_END_P): Remove unused macro and its bogus comment.
674 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
675
676 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
677 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
678 implementation.
679 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
680 We prefer signed types, and the value cannot exceed the EMACS_INT
681 range anyway (because otherwise the length would not be representable).
682 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
683 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
684 This avoids a GCC warning when WIDE_EMACS_INT.
685
686 * indent.c (sane_tab_width): New function.
687 (current_column, scan_for_column, Findent_to, position_indentation)
688 (compute_motion): Use it. This is just for clarity.
689 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
690
691 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
692
693 * lisp.h (lint_assume): New macro.
694 * composite.c (composition_gstring_put_cache):
695 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
696
697 * editfns.c, insdel.c:
698 Omit unnecessary forward decls, to simplify future changes.
699
700 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
701
702 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
703
704 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
705 Use much-faster test for byte-length change.
706 Don't assume string byte-length fits in 'int'.
707 Check that character arg fits in 'int'.
708 (mapcar1): Declare byte as byte, for clarity.
709
710 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
711
712 * fns.c (concat): Catch string overflow earlier.
713 Do not rely on integer wraparound.
714
715 * dispextern.h (struct it.overlay_strings_charpos)
716 (struct it.selective): Now EMACS_INT, not int.
717 * xdisp.c (forward_to_next_line_start)
718 (back_to_previous_visible_line_start)
719 (reseat_at_next_visible_line_start, next_element_from_buffer):
720 Don't arbitrarily truncate the value of 'selective' to int.
721
722 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
723
724 * composite.c: Don't truncate sizes to 'int'.
725 (composition_gstring_p, composition_reseat_it)
726 (composition_adjust_point): Use EMACS_INT, not int.
727 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
728 not EMACS_UINT, for indexes.
729
730 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
731
732 * buffer.c: Include <verify.h>.
733 (struct sortvec.priority, struct sortstr.priority):
734 Now EMACS_INT, not int.
735 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
736 (struct sortstr.size, record_overlay_string)
737 (struct sortstrlist.size, struct sortlist.used):
738 Don't truncate size to int.
739 (record_overlay_string): Check for size-calculation overflow.
740 (init_buffer_once): Check at compile-time, not run-time.
741
742 2011-06-22 Jim Meyering <meyering@redhat.com>
743
744 Don't leak an XBM-image-sized buffer
745 * image.c (xbm_load): Free the image buffer after using it.
746
747 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
748
749 Port to Sun C.
750 * composite.c (find_automatic_composition): Omit needless 'return 0;'
751 that Sun C diagnosed.
752 * fns.c (secure_hash): Fix pointer signedness issue.
753 * intervals.c (static_offset_intervals): New function.
754 (offset_intervals): Use it.
755
756 2011-06-21 Leo Liu <sdl.web@gmail.com>
757
758 * deps.mk (fns.o):
759 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
760 sha512.h.
761
762 * fns.c (secure_hash): Rename from crypto_hash_function and change
763 the first arg to accept symbols.
764 (Fsecure_hash): New primitive.
765 (syms_of_fns): New symbols.
766
767 2011-06-20 Deniz Dogan <deniz@dogan.se>
768
769 * process.c (Fset_process_buffer): Clarify return value in
770 docstring.
771
772 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
773
774 * dispnew.c (add_window_display_history): Use BVAR.
775
776 * xdisp.c (debug_method_add): Use BVAR.
777 (check_window_end, dump_glyph_matrix, dump_glyph)
778 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
779
780 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
781 Likewise.
782
783 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
784 check till after the cache is created in init_frame_faces.
785
786 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
787
788 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
789
790 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
791
792 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
793 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
794 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
795
796 Improve buffer-overflow checking (Bug#8873).
797 * fileio.c (Finsert_file_contents):
798 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
799 Remove the old (too-loose) buffer overflow checks.
800 They weren't needed, since make_gap checks for buffer overflow.
801 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
802 The old code merely checked for Emacs fixnum overflow, and relied
803 on undefined (wraparound) behavior. The new code avoids undefined
804 behavior, and also checks for ptrdiff_t and/or size_t overflow.
805
806 * editfns.c (Finsert_char): Don't dump core with very negative counts.
807 Tune. Don't use wider integers than needed. Don't use alloca.
808 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
809
810 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
811
812 * insdel.c, lisp.h (buffer_overflow): New function.
813 (insert_from_buffer_1, replace_range, replace_range_2):
814 * insdel.c (make_gap_larger):
815 * editfns.c (Finsert_char):
816 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
817
818 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
819
820 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
821
822 Integer overflow and signedness fixes (Bug#8873).
823
824 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
825 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
826
827 * fileio.c: Don't assume EMACS_INT fits in off_t.
828 (emacs_lseek): New static function.
829 (Finsert_file_contents, Fwrite_region): Use it.
830 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
831
832 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
833
834 * fns.c: Don't overflow int when computing a list length.
835 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
836 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
837 truncation on 64-bit hosts. Check for QUIT every
838 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
839 faster and is responsive enough.
840 (Flength): Report an error instead of overflowing an integer.
841 (Fsafe_length): Return a float if the value is not representable
842 as a fixnum. This shouldn't happen except in contrived situations.
843 (Fnthcdr, Fsort): Don't assume list length fits in int.
844 (Fcopy_sequence): Don't assume vector length fits in int.
845
846 * alloc.c: Check that resized vectors' lengths fit in fixnums.
847 (header_size, word_size): New constants.
848 (allocate_vectorlike): Don't check size overflow here.
849 (allocate_vector): Check it here instead, since this is the only
850 caller of allocate_vectorlike that could cause overflow.
851 Check that the new vector's length is representable as a fixnum.
852
853 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
854 The previous code was bogus. For example, next_almost_prime (32)
855 returned 39, which is undesirable as it is a multiple of 3; and
856 next_almost_prime (24) returned 25, which is a multiple of 5 so
857 why was the code bothering to check for multiples of 7?
858
859 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
860
861 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
862
863 Variadic C functions now count arguments with ptrdiff_t.
864 This partly undoes my 2011-03-30 change, which replaced int with size_t.
865 Back then I didn't know that the Emacs coding style prefers signed int.
866 Also, in the meantime I found a few more instances where arguments
867 were being counted with int, which may truncate counts on 64-bit
868 machines, or EMACS_INT, which may be unnecessarily wide.
869 * lisp.h (struct Lisp_Subr.function.aMANY)
870 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
871 Arg counts are now ptrdiff_t, not size_t.
872 All variadic functions and their callers changed accordingly.
873 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
874 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
875 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
876 * callint.c (Fcall_interactively): Check arg count for overflow,
877 to avoid potential buffer overrun. Use signed char, not 'int',
878 for 'varies' array, so that we needn't bother to check its size
879 calculation for overflow.
880 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
881 * eval.c (apply_lambda):
882 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
883 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
884 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
885
886 * callint.c (Fcall_interactively): Don't use index var as event count.
887
888 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
889 * mem-limits.h (SIZE): Remove; no longer used.
890
891 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
892
893 Remove unnecessary casts.
894 * xterm.c (x_term_init):
895 * xfns.c (x_set_border_pixel):
896 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
897 These aren't needed now that we assume ANSI C.
898
899 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
900 It's more likely to cause problems (due to unsigned overflow)
901 than to cure them.
902
903 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
904
905 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
906
907 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
908
909 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
910
911 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
912
913 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
914
915 GLYPH_CODE_FACE returns EMACS_INT, not int.
916 * dispextern.h (merge_faces):
917 * xfaces.c (merge_faces):
918 * xdisp.c (get_next_display_element, next_element_from_display_vector):
919 Don't assume EMACS_INT fits in int.
920
921 * character.h (CHAR_VALID_P): Remove unused parameter.
922 * fontset.c, lisp.h, xdisp.c: All uses changed.
923
924 * editfns.c (Ftranslate_region_internal): Omit redundant test.
925
926 * fns.c (concat): Minor tuning based on overflow analysis.
927 This doesn't fix any bugs. Use int to hold character, instead
928 of constantly refetching from Emacs object. Use XFASTINT, not
929 XINT, for value known to be a character. Don't bother comparing
930 a single byte to 0400, as it's always less.
931
932 * floatfns.c (Fexpt):
933 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
934
935 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
936 for characters.
937
938 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
939
940 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
941 Without this fix, on a 64-bit host (aset S 0 4294967386) would
942 incorrectly succeed when S was a string, because 4294967386 was
943 truncated before it was used.
944
945 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
946 Otherwise, an out-of-range integer could cause undefined behavior
947 on a 64-bit host.
948
949 * composite.c: Use int, not EMACS_INT, for characters.
950 (fill_gstring_body, composition_compute_stop_pos): Use int, not
951 EMACS_INT, for values that are known to be in character range.
952 This doesn't fix any bugs but is the usual style inside Emacs and
953 may generate better code on 32-bit machines.
954
955 Make sure a 64-bit char is never passed to ENCODE_CHAR.
956 This is for reasons similar to the recent CHAR_STRING fix.
957 * charset.c (Fencode_char): Check that character arg is actually
958 a character. Pass an int to ENCODE_CHAR.
959 * charset.h (ENCODE_CHAR): Verify that the character argument is no
960 wider than 'int', as a compile-time check to prevent future regressions
961 in this area.
962
963 * character.c (char_string): Remove unnecessary casts.
964
965 Make sure a 64-bit char is never passed to CHAR_STRING.
966 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
967 by silently ignoring the top 32 bits, allowing some values
968 that were far too large to be valid characters.
969 * character.h: Include <verify.h>.
970 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
971 arguments are no wider than unsigned, as a compile-time check
972 to prevent future regressions in this area.
973 * data.c (Faset):
974 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
975 (Fsubst_char_in_region):
976 * fns.c (concat):
977 * xdisp.c (decode_mode_spec_coding):
978 Adjust to CHAR_STRING's new requirement.
979 * editfns.c (Finsert_char, Fsubst_char_in_region):
980 * fns.c (concat): Check that character args are actually
981 characters. Without this test, these functions did the wrong
982 thing with wildly out-of-range values on 64-bit hosts.
983
984 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
985 These casts should not be needed on 32-bit hosts, either.
986 * keyboard.c (read_char):
987 * lread.c (Fload): Remove casts to unsigned.
988
989 * lisp.h (UNSIGNED_CMP): New macro.
990 This fixes comparison bugs on 64-bit hosts.
991 (ASCII_CHAR_P): Use it.
992 * casefiddle.c (casify_object):
993 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
994 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
995 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
996 * dispextern.h (FACE_FROM_ID):
997 * keyboard.c (read_char): Use UNSIGNED_CMP.
998
999 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1000 not to EMACS_INT, to avoid GCC warning.
1001
1002 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1003
1004 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1005 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1006 isn't needed on 32-bit machines.
1007
1008 * buffer.c (Fgenerate_new_buffer_name):
1009 Use EMACS_INT for count, not int.
1010 (advance_to_char_boundary): Return EMACS_INT, not int.
1011
1012 * data.c (Qcompiled_function): Now static.
1013
1014 * window.c (window_body_lines): Now static.
1015
1016 * image.c (gif_load): Rename local to avoid shadowing.
1017
1018 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1019 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1020 * alloc.c (make_save_value): Integer argument is now of type
1021 ptrdiff_t, not int.
1022 (mark_object): Use ptrdiff_t, not int.
1023 * lisp.h (pD): New macro.
1024 * print.c (print_object): Use it.
1025
1026 * alloc.c: Use EMACS_INT, not int, to count objects.
1027 (total_conses, total_markers, total_symbols, total_vector_size)
1028 (total_free_conses, total_free_markers, total_free_symbols)
1029 (total_free_floats, total_floats, total_free_intervals)
1030 (total_intervals, total_strings, total_free_strings):
1031 Now EMACS_INT, not int. All uses changed.
1032 (Fgarbage_collect): Compute overall total using a double, so that
1033 integer overflow is less likely to be a problem. Check for overflow
1034 when converting back to an integer.
1035 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1036 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1037 These were 'int' variables that could overflow on 64-bit hosts;
1038 they were never used, so remove them instead of repairing them.
1039 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1040 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1041 Previously, this ceilinged at INT_MAX, but that doesn't work on
1042 64-bit machines.
1043 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1044
1045 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1046 (allocate_vectorlike): Check for ptrdiff_t overflow.
1047 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1048 when a (possibly-narrower) signed value would do just as well.
1049 We prefer using signed arithmetic, to avoid comparison confusion.
1050
1051 * alloc.c: Catch some string size overflows that we were missing.
1052 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1053 for convenience in STRING_BYTES_MAX.
1054 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1055 The definition here is exact; the one in lisp.h was approximate.
1056 (allocate_string_data): Check for string overflow. This catches
1057 some instances we weren't catching before. Also, it catches
1058 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1059 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1060 and ptrdiff_t and EMACS_INT are both 64 bits.
1061
1062 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1063 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1064 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1065
1066 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1067
1068 * alloc.c (Fmake_string): Check for out-of-range init.
1069
1070 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1071
1072 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1073
1074 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1075
1076 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1077 xg_get_default_scrollbar_width.
1078
1079 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1080 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1081 (style_changed_cb): Call update_theme_scrollbar_width and call
1082 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1083 all frames (Bug#8505).
1084 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1085 Call gtk_window_set_resizable if HAVE_GTK3.
1086 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1087 and height if HAVE_GTK3 (Bug#8505).
1088 (scroll_bar_width_for_theme): New variable.
1089 (update_theme_scrollbar_width): New function.
1090 (xg_get_default_scrollbar_width): Move code to
1091 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1092 (xg_initialize): Call update_theme_scrollbar_width.
1093
1094 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1095
1096 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1097
1098 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1099
1100 * frame.c (make_frame): Call other_buffer_safely instead of
1101 other_buffer.
1102
1103 * window.c (temp_output_buffer_show): Call display_buffer with
1104 second argument Vtemp_buffer_show_specifiers and reset latter
1105 immediately after the call.
1106 (Vtemp_buffer_show_specifiers): New variable.
1107 (auto_window_vscroll_p, next_screen_context_lines)
1108 (Vscroll_preserve_screen_position): Remove leading asterisks from
1109 doc-strings.
1110
1111 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1112
1113 Fix minor problems found by GCC 4.6.0 static checking.
1114 * buffer.c (Qclone_number): Remove for now, as it's unused.
1115 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1116 (record_buffer): Remove unused local.
1117 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1118 (set_frame_buffer_list): Remove; unused.
1119 * frame.h (other_visible_frames): Remove decl.
1120 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1121 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1122 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1123 if HAVE_GPM.
1124 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1125 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1126 Define only if HAVE_GPM.
1127 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1128 (update_hints_inhibit): Remove; never set. All uses removed.
1129 * widgetprv.h (emacsFrameClassRec): Remove decl.
1130 * window.c (delete_deletable_window): Now returns void, since it
1131 wasn't returning anything.
1132 (compare_window_configurations): Remove unused locals.
1133 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1134 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1135 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1136 the same widths as pointers. This follows up on the 2011-05-06 patch.
1137 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1138 * xterm.h: Likewise.
1139 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1140
1141 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1142
1143 * makefile.w32-in: Update dependencies.
1144 (LISP_H): Add lib/intprops.h.
1145
1146 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1147
1148 * image.c (gif_load): Add animation frame delay to the metadata.
1149 (syms_of_image): Use DEFSYM. New symbol `delay'.
1150
1151 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1152
1153 * window.c (delete_deletable_window): Re-add.
1154 (Fset_window_configuration): Rewrite to handle dead buffers and
1155 consequently deletable windows.
1156 (window_tree, Fwindow_tree): Remove. Supply functionality in
1157 window.el.
1158 (compare_window_configurations): Simplify code.
1159
1160 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1161
1162 * image.c (imagemagick_load_image): Fix type mismatch.
1163 (Fimagemagick_types): Likewise.
1164
1165 * window.h (replace_buffer_in_windows): Declare.
1166
1167 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1168
1169 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1170 Qclone_number. Remove external declaration of Qdelete_window.
1171 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1172 code.
1173 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1174 Qbuffer_list_update_hook if allowed.
1175 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1176 buffer list implementation.
1177 (other_buffer_safely): New function.
1178 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1179 calls to replace_buffer_in_windows and
1180 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1181 if allowed.
1182 (record_buffer): Inhibit quitting and rewrite using quittable
1183 functions. Run Qbuffer_list_update_hook if allowed.
1184 (Frecord_buffer, Funrecord_buffer): New functions.
1185 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1186 switch-to-buffer to window.el.
1187 (bury-buffer): Move to window.el.
1188 (Vbuffer_list_update_hook): New variable.
1189
1190 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1191 section.
1192
1193 * window.h (resize_frame_windows): Move up in code.
1194 (Fwindow_frame): Remove EXFUN.
1195 (replace_buffer_in_all_windows): Remove prototype.
1196 (replace_buffer_in_windows_safely): Add prototype.
1197
1198 * window.c: Declare Qdelete_window static again. Move down
1199 declaration of select_count.
1200 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1201 (Fother_window): Move to window.el.
1202 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1203 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1204 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1205 window.el.
1206 (replace_buffer_in_windows): Implement by calling
1207 Qreplace_buffer_in_windows.
1208 (replace_buffer_in_all_windows): Remove with some functionality
1209 moved into replace_buffer_in_windows_safely.
1210 (replace_buffer_in_windows_safely): New function.
1211 (select_window_norecord, select_frame_norecord): Move in front
1212 of run_window_configuration_change_hook. Remove now obsolete
1213 declarations.
1214 (Fset_window_buffer): Rewrite doc-string. Call
1215 Qrecord_window_buffer.
1216 (keys_of_window): Move binding for other-window to window.el.
1217
1218 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1219
1220 * dispextern.h (struct image): Replace data member, whose int_val
1221 and ptr_val fields were not used by anything, with a single
1222 lisp_val object.
1223
1224 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1225 (gif_clear_image, gif_load, imagemagick_load_image)
1226 (gs_clear_image, gs_load): Callers changed.
1227
1228 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1229
1230 * buffer.h: Include <time.h>, for time_t.
1231 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1232
1233 Fix minor problems found by static checking.
1234
1235 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1236
1237 Make identifiers static if they are not used in other modules.
1238 * data.c (Qcompiled_function, Qframe, Qvector):
1239 * image.c (QimageMagick, Qsvg):
1240 * minibuf.c (Qmetadata):
1241 * window.c (resize_window_check, resize_root_window): Now static.
1242 * window.h (resize_window_check, resize_root_window): Remove decls.
1243
1244 * window.c (window_deletion_count, delete_deletable_window):
1245 Remove; unused.
1246 (window_body_lines): Now static.
1247 (Fdelete_other_windows_internal): Mark vars as initialized.
1248 Make sure 'resize_failed' is initialized.
1249 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1250 (resize_window_apply): Remove unused local.
1251 * window.h (delete_deletable_window): Remove decl.
1252
1253 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1254 (imagemagick_load_image): Fix pointer signedness problem by changing
1255 last arg from unsigned char * to char *. All uses changed.
1256 Also, fix a local for similar reasons.
1257 Remove unused locals. Remove locals to avoid shadowing.
1258 (fn_rsvg_handle_free): Remove; unused.
1259 (svg_load, svg_load_image): Fix pointer signedness problem.
1260 (imagemagick_load_image): Don't use garbage pointer image_wand.
1261
1262 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1263
1264 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1265
1266 * image.c (gif_load): Fix omitted cast error introduced by
1267 2011-06-06 change.
1268
1269 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1270
1271 * window.h (resize_proportionally, orig_total_lines)
1272 (orig_top_line): Remove from window structure.
1273 (set_window_height, set_window_width, change_window_heights)
1274 (Fdelete_window): Remove prototypes.
1275 (resize_frame_windows): Remove duplicate declaration.
1276
1277 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1278
1279 * window.h (resize_frame_windows, resize_window_check)
1280 (delete_deletable_window, resize_root_window)
1281 (resize_frame_windows): Declare prototypes.
1282
1283 * window.c (resize_window_apply): Make definition be "static" to
1284 match the prototype.
1285
1286 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1287
1288 * window.c: Remove declarations of Qwindow_size_fixed,
1289 window_min_size_1, window_min_size_2, window_min_size,
1290 size_window, window_fixed_size_p, enlarge_window, delete_window.
1291 Remove static from declaration of Qdelete_window, it's
1292 temporarily needed by Fbury_buffer.
1293 (replace_window): Don't assign orig_top_line and
1294 orig_total_lines.
1295 (Fdelete_window, delete_window): Remove. Window deletion is
1296 handled by window.el.
1297 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1298 Fdelete_window calls with calls to Qdelete_window.
1299 (Fdelete_other_windows): Remove. Deleting other windows is
1300 handled by window.el.
1301 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1302 handled in window.el.
1303 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1304 Window minimum sizes are handled in window.el.
1305 (shrink_windows, size_window, set_window_height)
1306 (set_window_width, change_window_heights, window_height)
1307 (window_width, CURBEG, CURSIZE, enlarge_window)
1308 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1309 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1310 handled in window.el.
1311 (make_dummy_parent): Rename to make_parent_window and give it a
1312 second argument horflag.
1313 (make_window): Don't set resize_proportionally any more.
1314 (Fsplit_window): Remove. Windows are split in window.el.
1315 (save_restore_action, save_restore_orig_size)
1316 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1317 Resize mini windows in window.el.
1318 (grow_mini_window, shrink_mini_window): Implement by calling
1319 Qresize_root_window_vertically, resize_window_check and
1320 resize_window_apply.
1321 (saved_window, Fset_window_configuration, save_window_save): Do
1322 not handle orig_top_line, orig_total_lines, and
1323 resize_proportionally.
1324 (window_min_height, window_min_width): Move to window.el.
1325 (keys_of_window): Move bindings for delete-other-windows,
1326 split-window, delete-window and enlarge-window to window.el.
1327
1328 * buffer.c: Temporarily extern Qdelete_window.
1329 (Fbury_buffer): Temporarily call Qdelete_window instead of
1330 Fdelete_window (Fbury_buffer will move to window.el soon).
1331
1332 * frame.c (set_menu_bar_lines_1): Remove code handling
1333 orig_top_line and orig_total_lines.
1334
1335 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1336 set_window_height but set heights directly.
1337 (change_frame_size_1): Use resize_frame_windows.
1338
1339 * xdisp.c (init_xdisp): Don't use set_window_height but set
1340 heights directly.
1341
1342 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1343 resize_frame_windows instead of change_window_heights and run
1344 run_window_configuration_change_hook.
1345
1346 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1347 instead of change_window_heights and run
1348 run_window_configuration_change_hook.
1349
1350 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1351
1352 * window.c (replace_window): Rename second argument REPLACEMENT to
1353 NEW. New third argument SETFLAG. Rewrite.
1354 (delete_window, make_dummy_parent): Call replace_window with
1355 third argument 1.
1356 (window_list_1): Move down in code.
1357 (run_window_configuration_change_hook): Move set_buffer part
1358 before select_frame_norecord part in order to unwind correctly.
1359 Rename count1 to count.
1360 (recombine_windows, delete_deletable_window, resize_root_window)
1361 (Fdelete_other_windows_internal)
1362 (Frun_window_configuration_change_hook, make_parent_window)
1363 (resize_window_check, resize_window_apply, Fresize_window_apply)
1364 (resize_frame_windows, Fsplit_window_internal)
1365 (Fdelete_window_internal, Fresize_mini_window_internal): New
1366 functions.
1367 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1368
1369 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1370
1371 * window.h (window): Add some new members to window structure -
1372 normal_lines, normal_cols, new_total, new_normal, clone_number,
1373 splits, nest, prev_buffers, next_buffers.
1374 (WINDOW_TOTAL_SIZE): Move here from window.c.
1375 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1376
1377 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1378 Remove.
1379 (make_dummy_parent): Set new members of windows structure.
1380 (make_window): Move down in code. Handle new members of window
1381 structure.
1382 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1383 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1384 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1385 (Fset_window_prev_buffers, Fwindow_next_buffers)
1386 (Fset_window_next_buffers, Fset_window_clone_number): New
1387 functions.
1388 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1389 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1390 Doc-string fixes.
1391 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1392 Argument WINDOW can be now internal window too.
1393 (Fwindow_use_time): Move up in code.
1394 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1395 Rewrite doc-string.
1396 (Fset_window_configuration, saved_window)
1397 (Fcurrent_window_configuration, save_window_save): Handle new
1398 members of window structure.
1399 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1400 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1401 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1402 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1403 Qget_mru_window, Qresize_root_window,
1404 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1405 Qauto_buffer_name; staticpro them.
1406
1407 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1408
1409 * window.c (Fwindow_total_size, Fwindow_left_column)
1410 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1411 (Fwindow_list_1): New functions.
1412 (window_box_text_cols): Replace with window_body_cols.
1413 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1414 window_body_cols instead of window_box_text_cols.
1415 (delete_window, Fset_window_configuration): Call
1416 delete_all_subwindows with window as argument.
1417 (delete_all_subwindows): Take a window as argument and not a
1418 structure. Rewrite.
1419 (window_loop): Remove handling of GET_LRU_WINDOW and
1420 GET_LARGEST_WINDOW.
1421 (Fget_lru_window, Fget_largest_window): Move to window.el.
1422
1423 * window.h: Extern window_body_cols instead of
1424 window_box_text_cols. delete_all_subwindows now takes a
1425 Lisp_Object as argument.
1426
1427 * indent.c (compute_motion, Fcompute_motion): Use
1428 window_body_cols instead of window_box_text_cols.
1429
1430 * frame.c (delete_frame): Call delete_all_subwindows with root
1431 window as argument.
1432
1433 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1434
1435 * fns.c (Fputhash): Document return value.
1436
1437 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1438
1439 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1440
1441 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1442
1443 Cons<->int and similar integer overflow fixes (Bug#8794).
1444
1445 Check for overflow when converting integer to cons and back.
1446 * charset.c (Fdefine_charset_internal, Fdecode_char):
1447 Use cons_to_unsigned to catch overflow.
1448 (Fencode_char): Use INTEGER_TO_CONS.
1449 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1450 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1451 * data.c (long_to_cons, cons_to_long): Remove.
1452 (cons_to_unsigned, cons_to_signed): New functions.
1453 These signal an error for invalid or out-of-range values.
1454 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1455 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1456 * font.c (Ffont_variation_glyphs):
1457 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1458 * lisp.h: Include <intprops.h>.
1459 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1460 (cons_to_signed, cons_to_unsigned): New decls.
1461 (long_to_cons, cons_to_long): Remove decls.
1462 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1463 (Fprimitive_undo): Use CONS_TO_INTEGER.
1464 * xfns.c (Fx_window_property): Likewise.
1465 * xselect.c: Include <limits.h>.
1466 (x_own_selection, selection_data_to_lisp_data):
1467 Use INTEGER_TO_CONS.
1468 (x_handle_selection_request, x_handle_selection_clear)
1469 (x_get_foreign_selection, Fx_disown_selection_internal)
1470 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1471 (lisp_data_to_selection_data): Use cons_to_unsigned.
1472 (x_fill_property_data): Use cons_to_signed.
1473 Report values out of range.
1474
1475 Check for buffer and string overflow more precisely.
1476 * buffer.h (BUF_BYTES_MAX): New macro.
1477 * lisp.h (STRING_BYTES_MAX): New macro.
1478 * alloc.c (Fmake_string):
1479 * character.c (string_escape_byte8):
1480 * coding.c (coding_alloc_by_realloc):
1481 * doprnt.c (doprnt):
1482 * editfns.c (Fformat):
1483 * eval.c (verror):
1484 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1485 since they may not be the same number.
1486 * editfns.c (Finsert_char):
1487 * fileio.c (Finsert_file_contents):
1488 Likewise for BUF_BYTES_MAX.
1489
1490 * image.c: Use ptrdiff_t, not int, for sizes.
1491 (slurp_file): Switch from int to ptrdiff_t.
1492 All uses changed.
1493 (slurp_file): Check that file size fits in both size_t (for
1494 malloc) and ptrdiff_t (for sanity and safety).
1495
1496 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1497 if b->modtime has its maximal value.
1498
1499 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1500
1501 Don't assume time_t can fit into int.
1502 * buffer.h (struct buffer.modtime): Now time_t, not int.
1503 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1504 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1505
1506 Minor fixes for signed vs unsigned integers.
1507 * character.h (MAYBE_UNIFY_CHAR):
1508 * charset.c (maybe_unify_char):
1509 * keyboard.c (read_char, reorder_modifiers):
1510 XINT -> XFASTINT, since the integer must be nonnegative.
1511 * ftfont.c (ftfont_spec_pattern):
1512 * keymap.c (access_keymap, silly_event_symbol_error):
1513 XUINT -> XFASTINT, since the integer must be nonnegative.
1514 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1515 since it makes no difference and we prefer signed.
1516 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1517 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1518 nonnegative.
1519
1520 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1521
1522 * window.h (Fwindow_frame): Declare.
1523
1524 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1525
1526 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1527 (SPARE_MEMORY): Always define.
1528 (LARGE_REQUEST): Remove.
1529 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1530
1531 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1532
1533 * lisp.h: Move EXFUNS for Fframe_root_window,
1534 Fframe_first_window and Fset_frame_selected_window to window.h.
1535
1536 * window.h: Move EXFUNS for Fframe_root_window,
1537 Fframe_first_window and Fset_frame_selected_window here from
1538 lisp.h.
1539
1540 * frame.c (Fwindow_frame, Fframe_first_window)
1541 (Fframe_root_window, Fframe_selected_window)
1542 (Fset_frame_selected_window): Move to window.c.
1543 (Factive_minibuffer_window): Move to minibuf.c.
1544 (Fother_visible_frames_p): New function.
1545
1546 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1547
1548 * window.c (decode_window, decode_any_window): Move up in code.
1549 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1550 (inhibit_frame_unsplittable): Remove unused variable.
1551 (Fwindow_buffer): Move up and rewrite doc-string.
1552 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1553 (Fwindow_prev): New functions.
1554 (Fwindow_frame): Move here from frame.c. Accept any window as
1555 argument.
1556 (Fframe_root_window, Fframe_first_window)
1557 (Fframe_selected_window): Move here from frame.c. Accept frame
1558 or arbitrary window as argument. Update doc-strings.
1559 (Fminibuffer_window): Move up in code.
1560 (Fwindow_minibuffer_p): Move up in code and simplify.
1561 (Fset_frame_selected_window): Move here from frame.c.
1562 Marginal rewrite.
1563 (Fselected_window, select_window, Fselect_window): Move up in
1564 code. Minor doc-string fixes.
1565
1566 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1567
1568 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1569 Do not assume that spare memory exists; that assumption is valid
1570 only if SYSTEM_MALLOC.
1571 (LARGE_REQUEST): New macro, so that the issue of large requests
1572 is separated from the issue of spare memory.
1573
1574 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1575
1576 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1577 format. (Bug#8806)
1578
1579 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1580
1581 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1582 before statements.
1583
1584 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1585
1586 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1587
1588 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1589
1590 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1591 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1592
1593 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1594
1595 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1596
1597 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1598
1599 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1600 (x_clipboard_manager_save): Add return value.
1601 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1602 New error handlers.
1603 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1604 Obey Vx_select_enable_clipboard_manager. Catch errors in
1605 x_clipboard_manager_save (Bug#8779).
1606 (Vx_select_enable_clipboard_manager): New variable.
1607 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1608
1609 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1610
1611 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1612
1613 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1614
1615 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1616 in the current matrix if keep_current_p is non-zero.
1617
1618 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1619
1620 * bidi.c (bidi_level_of_next_char): Fix last change.
1621
1622 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1623
1624 Support bidi reordering of text covered by display properties.
1625
1626 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1627 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1628 (bidi_cache_search, bidi_cache_iterator_state)
1629 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1630 (bidi_level_of_next_char, bidi_move_to_visually_next):
1631 Support character positions inside a run of characters covered by a
1632 display string.
1633 (bidi_paragraph_init, bidi_resolve_explicit_1)
1634 (bidi_level_of_next_char): Call bidi_fetch_char and
1635 bidi_fetch_char_advance instead of FETCH_CHAR and
1636 FETCH_CHAR_ADVANCE.
1637 (bidi_init_it): Initialize new members.
1638 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1639 definitions.
1640 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1641 instead of using explicit *_CHAR codes.
1642 (bidi_resolve_explicit, bidi_resolve_weak):
1643 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1644 bidirectional text is supported only in multibyte buffers.
1645 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1646 it to initialize the frame_window_p member of struct bidi_it.
1647 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1648 (bidi_resolve_explicit, bidi_resolve_weak)
1649 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1650 bidi_it->nchars is non-positive.
1651 (bidi_level_of_next_char): Don't try to lookup the cache for the
1652 next/previous character if nothing is cached there yet, or if we
1653 were just reseat()'ed to a new position.
1654
1655 * xdisp.c (set_cursor_from_row): Set start and stop points
1656 according to the row's direction when priming the loop that looks
1657 for the glyph on which to display cursor.
1658 (single_display_spec_intangible_p): Function deleted.
1659 (display_prop_intangible_p): Reimplement to call
1660 handle_display_spec instead of single_display_spec_intangible_p.
1661 Accept 3 additional arguments needed by handle_display_spec.
1662 This fixes incorrect cursor motion across display property with complex
1663 values: lists, `(when COND...)' forms, etc.
1664 (single_display_spec_string_p): Support property values that are
1665 lists with the argument STRING its top-level element.
1666 (display_prop_string_p): Fix the condition for processing a
1667 property that is a list to be consistent with handle_display_spec.
1668 (handle_display_spec): New function, refactored from the
1669 last portion of handle_display_prop.
1670 (compute_display_string_pos): Accept additional argument
1671 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1672 value of a `display' property is a "replacing spec".
1673 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1674 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1675 the display property, but just return a value indicating whether
1676 the display property will replace the characters it covers.
1677 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1678 frame_window_p members of struct bidi_it.
1679 (compute_display_string_pos, compute_display_string_end):
1680 New functions.
1681 (push_it): Accept second argument POSITION, where pop_it should
1682 jump to continue iteration.
1683 (reseat_1): Initialize bidi_it.disp_pos.
1684
1685 * keyboard.c (adjust_point_for_property): Adjust the call to
1686 display_prop_intangible_p to its new signature.
1687
1688 * dispextern.h (struct bidi_it): New member frame_window_p.
1689 (bidi_init_it): Update prototypes.
1690 (display_prop_intangible_p): Update prototype.
1691 (compute_display_string_pos, compute_display_string_end):
1692 Declare prototypes.
1693 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1694 EMACS_INT.
1695
1696 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1697
1698 Malloc failure behavior now depends on size of allocation.
1699 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1700 * lisp.h: Change signatures accordingly.
1701 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1702 All callers changed. (Bug#8762)
1703
1704 * gnutls.c: Use Emacs's memory allocators.
1705 Without this change, the gnutls library would invoke malloc etc.
1706 directly, which causes problems on non-SYNC_INPUT hosts, and which
1707 runs afoul of improving memory_full behavior. (Bug#8761)
1708 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1709 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1710 xfree instead of the default malloc, realloc, free.
1711 (Fgnutls_boot): No need to check for memory allocation failure,
1712 since xmalloc does that for us.
1713
1714 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1715 * category.c (hash_get_category_set):
1716 * ccl.c (ccl_driver):
1717 * charset.c (Fdefine_charset_internal):
1718 * charset.h (struct charset.hash_index):
1719 * composite.c (get_composition_id, gstring_lookup_cache)
1720 (composition_gstring_put_cache):
1721 * composite.h (struct composition.hash_index):
1722 * dispextern.h (struct image.hash):
1723 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1724 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1725 (hashfn_equal, hashfn_user_defined, make_hash_table)
1726 (maybe_resize_hash_table, hash_lookup, hash_put)
1727 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1728 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1729 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1730 * image.c (make_image, search_image_cache, lookup_image)
1731 (xpm_put_color_table_h):
1732 * lisp.h (struct Lisp_Hash_Table):
1733 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1734 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1735 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1736 * alloc.c (allocate_vectorlike):
1737 Check for overflow in vector size calculations.
1738 * ccl.c (ccl_driver):
1739 Check for overflow when converting EMACS_INT to int.
1740 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1741 need to be updated by these changes.
1742 * fns.c (make_hash_table, maybe_resize_hash_table):
1743 Check for integer overflow with large hash tables.
1744 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1745 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1746 (SXHASH_REDUCE): New macro.
1747 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1748 Use it instead of discarding useful hash info with large hash values.
1749 (sxhash_float): New function.
1750 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1751 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1752 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1753 Rewrite to use FIXNUM_BITS, as this simplifies things.
1754 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1755 Adjust signatures to match updated version of code.
1756 (consing_since_gc): Now EMACS_INT, since a single hash table can
1757 use more than INT_MAX bytes.
1758
1759 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1760
1761 Make it possible to build with GCC-4.6+ -O2 -flto.
1762
1763 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1764
1765 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1766
1767 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1768 Call minibuffer-inactive-mode.
1769
1770 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1771
1772 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1773 Update dependencies.
1774
1775 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1776
1777 * data.c (init_data): Remove code for UTS, this system is not
1778 supported anymore.
1779
1780 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1781
1782 Don't force ./temacs to start in terminal mode.
1783
1784 * frame.c (make_initial_frame): Initialize faces in all cases, not
1785 only when CANNOT_DUMP is defined.
1786 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1787
1788 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1789
1790 * dispnew.c (add_window_display_history): Use const for the string
1791 pointer. Remove declaration, not needed.
1792
1793 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1794
1795 Use 'inline', not 'INLINE'.
1796 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1797 * alloc.c, fontset.c (INLINE): Remove.
1798 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1799 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1800 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1801 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1802 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1803
1804 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1805
1806 Make it possible to run ./temacs.
1807
1808 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1809 syms_of_callproc does the same thing. Remove test for
1810 "initialized", do it in the caller.
1811 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1812
1813 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1814
1815 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1816 (read_minibuf): Use get_minibuffer.
1817 (syms_of_minibuf): Use DEFSYM.
1818 (Qmetadata): New var.
1819 * data.c (Qbuffer): Don't make it static.
1820 (syms_of_data): Use DEFSYM.
1821
1822 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1823
1824 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1825 (CCL_CODE_MIN): New macro.
1826
1827 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1828
1829 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1830
1831 * eval.c (Qdebug): Now static.
1832 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1833 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1834 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1835
1836 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1837
1838 * image.c: Various fixes to ImageMagick code comments.
1839 (Fimagemagick_types): Doc fix.
1840
1841 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1842
1843 Minor fixes prompted by GCC 4.6.0 warnings.
1844
1845 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1846
1847 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1848 (x_clipboard_manager_save_all): Move extern decl to ...
1849 * xterm.h: ... here, so that it can be checked for consistency.
1850
1851 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1852
1853 * xselect.c (x_clipboard_manager_save_frame)
1854 (x_clipboard_manager_save_all): New functions.
1855 (Fx_clipboard_manager_save): Lisp function deleted.
1856
1857 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1858 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1859
1860 * xterm.h: Update prototype.
1861
1862 2011-05-28 William Xu <william.xwl@gmail.com>
1863
1864 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1865 exiting (Bug#8239).
1866
1867 2011-05-28 Jim Meyering <meyering@redhat.com>
1868
1869 Avoid a sign-extension bug in crypto_hash_function.
1870 * fns.c (to_uchar): Define.
1871 (crypto_hash_function): Use it to convert some newly-signed
1872 variables to unsigned, to avoid sign-extension bugs. For example,
1873 without this change, (md5 "truc") would evaluate to
1874 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1875 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1876 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1877
1878 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1879
1880 Integer overflow fixes.
1881
1882 * dbusbind.c: Serial number integer overflow fixes.
1883 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1884 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1885 to hold a serial number that is too large for a fixnum.
1886 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1887 Check for serial numbers out of range. Decode any serial number
1888 that was so large that it became a float. (Bug#8722)
1889
1890 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1891 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1892 Use XFASTINT rather than XUINT when numbers are nonnegative.
1893 (xd_append_arg, Fdbus_method_return_internal):
1894 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1895 arguments, check that Lisp number is nonnegative, rather than
1896 silently wrapping negative numbers around. (Bug#8722)
1897 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1898 (Bug#8722)
1899
1900 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1901
1902 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1903
1904 ccl: add integer overflow checks
1905 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1906 (IN_INT_RANGE): New macros.
1907 (ccl_driver): Use them to check for integer overflow when
1908 decoding a CCL program. Many of the new checks are whether XINT (x)
1909 fits in int; it doesn't always, on 64-bit hosts. The new version
1910 doesn't catch all possible integer overflows, but it's an
1911 improvement. (Bug#8719)
1912
1913 * alloc.c (make_event_array): Use XINT, not XUINT.
1914 There's no need for unsigned here.
1915
1916 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1917 This follows up to the 2011-05-06 change that substituted uintptr_t
1918 for EMACS_INT. This case wasn't caught back then.
1919
1920 Rework Fformat to avoid integer overflow issues.
1921 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1922 now (part of C89). Include <verify.h>.
1923 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1924 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1925 (Fformat): Avoid the prepass trying to compute sizes; it was only
1926 approximate and thus did not catch overflow reliably. Instead, walk
1927 through the format just once, formatting and computing sizes as we go,
1928 checking for integer overflow at every step, and allocating a larger
1929 buffer as needed. Keep track separately whether the format is
1930 multibyte. Keep only the most-recently calculated precision, rather
1931 than them all. Record whether each argument has been converted to
1932 string. Use EMACS_INT, not int, for byte and char and arg counts.
1933 Support field widths and precisions larger than INT_MAX. Avoid
1934 sprintf's undefined behavior with conversion specifications such as %#d
1935 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1936 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1937 formatting out-of-range floating point numbers with int
1938 formats. (Bug#8668)
1939
1940 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1941
1942 * data.c: Avoid integer truncation in expressions involving floats.
1943 * data.c: Include <intprops.h>.
1944 (arith_driver): When there's an integer overflow in an expression
1945 involving floating point, convert the integers to floating point
1946 so that the resulting value does not suffer from catastrophic
1947 integer truncation. For example, on a 64-bit host (* 4
1948 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1949 Do not rely on undefined behavior after integer overflow.
1950
1951 merge count_size_as_multibyte, parse_str_to_multibyte
1952 * character.c, character.h (count_size_as_multibyte):
1953 Rename from parse_str_to_multibyte; all uses changed.
1954 Check for integer overflow.
1955 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1956 since it's now a duplicate of the other. This is more of
1957 a character than a buffer op, so better that it's in character.c.
1958 * fns.c, print.c: Adjust to above changes.
1959
1960 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1961
1962 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1963
1964 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1965
1966 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1967 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1968 (x_clipboard_manager_save): Now static.
1969 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1970
1971 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1972 (crypto_hash_function): Now static.
1973 Fix pointer signedness problems. Avoid unnecessary initializations.
1974
1975 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1976
1977 * termhooks.h (Vselection_alist): Make it terminal-local.
1978
1979 * terminal.c (create_terminal): Initialize it.
1980
1981 * xselect.c: Support for clipboard managers.
1982 (Vselection_alist): Move to termhooks.h as terminal-local var.
1983 (LOCAL_SELECTION): New macro.
1984 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1985 (symbol_to_x_atom): Remove gratuitous arg.
1986 (x_handle_selection_request, lisp_data_to_selection_data)
1987 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1988 (x_own_selection, x_get_local_selection, x_convert_selection):
1989 New arg, specifying work frame. Use terminal-local Vselection_alist.
1990 (some_frame_on_display): Delete unused function.
1991 (Fx_own_selection_internal, Fx_get_selection_internal)
1992 (Fx_disown_selection_internal, Fx_selection_owner_p)
1993 (Fx_selection_exists_p): New optional frame arg.
1994 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1995 (x_handle_selection_clear): Don't treat other terminals with the
1996 same keyboard specially. Use the terminal-local Vselection_alist.
1997 (x_clear_frame_selections): Use Frun_hook_with_args.
1998
1999 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2000
2001 * xterm.h: Add support for those atoms.
2002
2003 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2004
2005 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2006 (converted_selections, conversion_fail_tag): New global variables.
2007 (x_selection_request_lisp_error): Free the above.
2008 (x_get_local_selection): Remove unnecessary code.
2009 (x_reply_selection_request): Args changed; handle arbitrary array
2010 of converted selections stored in converted_selections.
2011 Separate the XChangeProperty and SelectionNotify steps.
2012 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2013 (x_convert_selection): New function.
2014 (x_handle_selection_event): Simplify.
2015 (x_get_foreign_selection): Don't ignore incoming requests while
2016 waiting for an answer; this will fail when we implement
2017 SAVE_TARGETS, and seems unnecessary anyway.
2018 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2019 (Vx_sent_selection_functions): Doc fix.
2020
2021 2011-05-26 Leo Liu <sdl.web@gmail.com>
2022
2023 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2024
2025 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2026
2027 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2028
2029 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2030 for fringe update if it has periodic bitmap.
2031 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2032 and fringe_bitmap_periodic_p.
2033
2034 * fringe.c (get_fringe_bitmap_data): New function.
2035 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2036 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2037 row. Mark glyph row for fringe update if periodicity changed.
2038
2039 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2040 for fringe update unless it has periodic bitmap.
2041
2042 2011-05-25 Kenichi Handa <handa@m17n.org>
2043
2044 * xdisp.c (get_next_display_element): Set correct it->face_id for
2045 a static composition.
2046
2047 2011-05-24 Leo Liu <sdl.web@gmail.com>
2048
2049 * deps.mk (fns.o):
2050 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2051
2052 * fns.c (crypto_hash_function, Fsha1): New function.
2053 (Fmd5): Use crypto_hash_function.
2054 (syms_of_fns): Add Ssha1.
2055
2056 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2057
2058 * gnutls.c: Remove unused macros.
2059 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2060 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2061 Remove macros that are defined and never used.
2062 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2063
2064 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2065
2066 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2067 (Fx_get_selection_internal): Minor cleanup.
2068 (Fx_own_selection_internal): Rename arguments for consistency with
2069 select.el.
2070
2071 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2072
2073 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2074
2075 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2076
2077 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2078
2079 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2080
2081 * dispnew.c (scrolling_window): Don't exclude the case that the
2082 last enabled row in the desired matrix touches the bottom boundary.
2083
2084 2011-05-21 Glenn Morris <rgm@gnu.org>
2085
2086 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2087 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2088 and add some more files.
2089
2090 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2091
2092 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2093 report_file_error introduced by the change from 2011-05-07.
2094
2095 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2096
2097 * systime.h (Time): Define only if emacs is defined.
2098 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2099 where the include path doesn't have X11/X.h by default. See
2100 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2101
2102 2011-05-20 Kenichi Handa <handa@m17n.org>
2103
2104 * composite.c (find_automatic_composition): Fix previous change.
2105
2106 2011-05-20 Glenn Morris <rgm@gnu.org>
2107
2108 * lisp.mk: New file, split from Makefile.in.
2109 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2110 (shortlisp): Remove.
2111 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2112
2113 2011-05-19 Glenn Morris <rgm@gnu.org>
2114
2115 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2116 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2117 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2118 (lisp): Set the order to that of loadup.el.
2119 (shortlisp): Make it a copy of $lisp.
2120 (SOME_MACHINE_LISP): Remove.
2121 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2122 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2123
2124 2011-05-18 Kenichi Handa <handa@m17n.org>
2125
2126 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2127 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2128 (find_automatic_composition): Mostly rewrite for efficiency.
2129
2130 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2131
2132 * makefile.w32-in: Update dependencies.
2133
2134 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2135
2136 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2137 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2138
2139 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2140
2141 Fix some integer overflow issues, such as string length overflow.
2142
2143 * insdel.c (count_size_as_multibyte): Check for string overflow.
2144
2145 * character.c (lisp_string_width): Check for string overflow.
2146 Use EMACS_INT, not int, for string indexes and lengths; in
2147 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2148 the resulting string length overflows an EMACS_INT; instead,
2149 report a string overflow if no precision given. When checking for
2150 precision exhaustion, use a check that cannot possibly have
2151 integer overflow. (Bug#8675)
2152 * character.h (lisp_string_width): Adjust to new signature.
2153
2154 * alloc.c (string_overflow): New function.
2155 (Fmake_string): Use it. This doesn't change behavior, but saves
2156 a few bytes and will simplify future changes.
2157 * character.c (string_escape_byte8): Likewise.
2158 * lisp.h (string_overflow): New decl.
2159
2160 Fixups, following up to the user-interface timestamp change.
2161 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2162 for UI timestamps, instead of unsigned long.
2163 * msdos.c (mouse_get_pos): Likewise.
2164 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2165 * w32gui.h (Time): Define by including "systime.h" rather than by
2166 declaring it ourselves. (Bug#8664)
2167
2168 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2169 * image.c (clear_image_cache): Likewise.
2170
2171 * term.c (term_mouse_position): Don't assume time_t wraparound.
2172
2173 Be more systematic about user-interface timestamps.
2174 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2175 and sometimes 'EMACS_UINT', to represent these timestamps.
2176 This change causes it to use 'Time' uniformly, as that's what X uses.
2177 This makes the code easier to follow, and makes it easier to catch
2178 integer overflow bugs such as Bug#8664.
2179 * frame.c (Fmouse_position, Fmouse_pixel_position):
2180 Use Time, not unsigned long, for user-interface timestamps.
2181 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2182 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2183 * keyboard.h (last_event_timestamp): Likewise.
2184 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2185 * menu.h (xmenu_show): Likewise.
2186 * term.c (term_mouse_position): Likewise.
2187 * termhooks.h (struct input_event.timestamp): Likewise.
2188 (struct terminal.mouse_position_hook): Likewise.
2189 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2190 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2191 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2192 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2193 what it was before.
2194 * menu.h, termhooks.h: Include "systime.h", for Time.
2195
2196 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2197 Don't assume that the difference between two unsigned long values
2198 can fit into an integer. At this point, we know button_down_time
2199 <= event->timestamp, so the difference must be nonnegative, so
2200 there's no need to cast the result if double-click-time is
2201 nonnegative, as it should be; check that it's nonnegative, just in
2202 case. This bug is triggered when events are more than 2**31 ms
2203 apart (about 25 days). (Bug#8664)
2204
2205 * xselect.c (last_event_timestamp): Remove duplicate decl.
2206 (x_own_selection): Remove needless cast to unsigned long.
2207
2208 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2209 that always fit in int. Use a sentinel instead of a counter, to
2210 avoid a temp and to allay GCC's concerns about possible int overflow.
2211 * frame.h (struct frame): Use int for menu_bar_items_used
2212 instead of EMACS_INT, since it always fits in int.
2213
2214 * menu.c (grow_menu_items): Check for int overflow.
2215
2216 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2217
2218 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2219 Before, the code was not consistent. These values cannot exceed
2220 2**31 - 1 so there's no need to make them unsigned.
2221 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2222 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2223 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2224 as modifiers.
2225 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2226
2227 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2228 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2229 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2230 presumably because the widths might not match.
2231
2232 * window.c (size_window): Avoid needless test at loop start.
2233
2234 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2235
2236 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2237
2238 2011-05-12 Drew Adams <drew.adams@oracle.com>
2239
2240 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2241
2242 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2243
2244 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2245 `width' to `bar_area_x' and `bar_area_width', respectively.
2246 (x_scroll_run): Take account of fringe background extension.
2247
2248 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2249 Rename local vars `left' and `width' to `bar_area_x' and
2250 `bar_area_width', respectively.
2251 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2252 background extension.
2253
2254 2011-05-10 Jim Meyering <meyering@redhat.com>
2255
2256 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2257
2258 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2259
2260 * image.c (Finit_image_library): Return t for built-in image types,
2261 like pbm and xbm. (Bug#8640)
2262
2263 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2264
2265 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2266
2267 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2268
2269 * w32console.c (Fset_screen_color): Doc fix.
2270 (Fget_screen_color): New function.
2271 (syms_of_ntterm): Defsubr it.
2272
2273 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2274 unlink the temporary file if Fcall_process didn't create it in the
2275 first place.
2276 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2277 child process will be redirected to a file specified with `:file'.
2278 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2279 cue to call_process_cleanup not to close that handle.
2280
2281 2011-05-07 Ben Key <bkey76@gmail.com>
2282
2283 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2284 one of two shell specific rules, either bootstrap-temacs-CMD or
2285 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2286 to the previous implementation of the bootstrap-temacs rule.
2287 The bootstrap-temacs-CMD rule is similar to the previous
2288 implementation of the bootstrap-temacs rule except that it
2289 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2290 variable.
2291
2292 These changes, along with some changes to nt/configure.bat,
2293 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2294 earlier fix to add support for --cflags and --ldflags options
2295 that include quotes so that it works whether make uses cmd or
2296 sh as the shell.
2297
2298 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2299
2300 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2301 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2302 is a constant.
2303 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2304 a string. Handle both cases.
2305 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2306 (Fdbus_register_method): Use Qinvalid_function.
2307
2308 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2309
2310 * makefile.w32-in: Update dependencies.
2311 (LISP_H): Add inttypes.h and stdin.h.
2312 (PROCESS_H): Add unistd.h.
2313
2314 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2315
2316 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2317 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2318
2319 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2320
2321 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2322
2323 * term.c (vfatal): Remove stray call to va_end.
2324 It's not needed and the C Standard doesn't allow it here anyway.
2325
2326 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2327 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2328
2329 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2330 bytes.
2331
2332 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2333
2334 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2335
2336 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2337
2338 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2339
2340 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2341
2342 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2343 * charset.c (Fdefine_charset_internal): Don't initialize
2344 charset.code_space[15]. The value was garbage, on hosts with
2345 32-bit int (Bug#8600).
2346
2347 * lread.c (read_integer): Be more consistent with string-to-number.
2348 Use string_to_number to do the actual conversion; this avoids
2349 rounding errors and fixes some other screwups. Without this fix,
2350 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2351 (digit_to_number): Move earlier, for benefit of read_integer.
2352 Return -1 if the digit is out of range for the base, -2 if it is
2353 not a digit in any supported base. (Bug#8602)
2354
2355 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2356
2357 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2358 to match comment at start of function. This also removes a
2359 GCC warning about overflow in a 32+64-bit port.
2360
2361 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2362
2363 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2364 Reported by Stefan Monnier in
2365 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2366 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2367 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2368
2369 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2370 (EMACS_UINTPTR): Likewise, with uintptr_t.
2371
2372 * lisp.h: Prefer 64-bit EMACS_INT if available.
2373 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2374 on 32-bit hosts that have 64-bit int, so that they can access
2375 large files.
2376 However, temporarily disable this change unless the temporary
2377 symbol WIDE_EMACS_INT is defined.
2378
2379 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2380
2381 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2382 This removes an assumption that EMACS_INT and long are the same
2383 width as pointers. The assumption is true for Emacs porting targets
2384 now, but we want to make other targets possible.
2385 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2386 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2387 In the rest of the code, change types of integers that hold casted
2388 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2389 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2390 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2391 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2392 No need to cast type when ORing.
2393 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2394 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2395 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2396 assume EMACS_INT is the same width as char *.
2397 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2398 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2399 Remove no-longer-needed casts.
2400 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2401 (xg_tool_bar_help_callback, xg_make_tool_item):
2402 Use EMACS_INTPTR to hold an integer
2403 that will be cast to void *; this can avoid a GCC warning
2404 if EMACS_INT is not the same width as void *.
2405 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2406 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2407 (current_message_1, set_message_1):
2408 Use a local to convert to proper width without a cast.
2409 * xmenu.c (dialog_selection_callback): Likewise.
2410
2411 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2412 Also, don't assume VALBITS / RAND_BITS is less than 5,
2413 and don't rely on undefined behavior when shifting a 1 left into
2414 the sign bit.
2415 * lisp.h (get_random): Change signature to match.
2416
2417 * lread.c (hash_string): Use size_t, not int, for hash computation.
2418 Normally we prefer signed values; but hashing is special, because
2419 it's better to use unsigned division on hash table sizes so that
2420 the remainder is nonnegative. Also, size_t is the natural width
2421 for hashing into memory. The previous code used 'int', which doesn't
2422 retain enough info to hash well into very large tables.
2423 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2424
2425 * dbusbind.c: Don't possibly lose pointer info when converting.
2426 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2427 Use XPNTR rather than XHASH, so that the high-order bits of
2428 the pointer aren't lost when converting through void *.
2429
2430 * eval.c (Fautoload): Don't double-shift a pointer.
2431
2432 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2433
2434 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2435
2436 * gnutls.c (DEF_GNUTLS_FN):
2437 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2438
2439 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2440
2441 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2442 marker. (Bug#8610)
2443
2444 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2445
2446 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2447 New version that can reserve upto 2GB of heap space.
2448
2449 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2450
2451 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2452
2453 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2454
2455 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2456 `gnutls_certificate_set_x509_key_file'.
2457
2458 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2459
2460 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2461 Update dependencies.
2462
2463 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2464
2465 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2466 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2467 Remove unused parameter `fildes'.
2468 * process.c (read_process_output, send_process): Don't pass it.
2469
2470 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2471
2472 Fix previous change: the library cache is defined in w32.c.
2473 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2474 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2475
2476 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2477
2478 Implement dynamic loading of GnuTLS on Windows.
2479
2480 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2481 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2482 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2483 Declare.
2484
2485 * gnutls.c (Qgnutls_dll): Define.
2486 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2487 (gnutls_*): Declare function pointers.
2488 (init_gnutls_functions): New function to initialize function pointers.
2489 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2490 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2491 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2492 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2493 (emacs_gnutls_write, emacs_gnutls_read)
2494 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2495 (Fgnutls_available_p): New function.
2496 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2497 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2498 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2499
2500 * image.c: Include w32.h.
2501 (Vimage_type_cache): Delete.
2502 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2503 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2504 (w32_delayed_load): Move to w32.c.
2505
2506 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2507
2508 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2509 (w32_delayed_load): Move from image.c. When loading a library, record
2510 its filename in the :loaded-from property of the library id.
2511 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2512 Initialize and staticpro them.
2513 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2514
2515 * process.c: Include lisp.h before w32.h, not after.
2516 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2517 instead of gnutls_record_check_pending.
2518
2519 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2520
2521 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2522
2523 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2524 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2525 as passed in.
2526
2527 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2528
2529 * xterm.c (x_set_frame_alpha): Do not set property on anything
2530 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2531
2532 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2533
2534 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2535
2536 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2537
2538 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2539 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2540 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2541 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2542 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2543 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2544 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2545 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2546 (Qgnutls_bootprop_callbacks_verify): Make static.
2547
2548 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2549
2550 * callproc.c: Indentation fixup.
2551
2552 * sysdep.c (wait_for_termination_1): Make static.
2553 (wait_for_termination, interruptible_wait_for_termination):
2554 Move after wait_for_termination_1.
2555
2556 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2557
2558 * sysdep.c (interruptible_wait_for_termination): New function
2559 which is like wait_for_termination, but allows keyboard
2560 interruptions.
2561
2562 * callproc.c (Fcall_process): Add (:file "file") as an option for
2563 the STDOUT buffer.
2564 (Fcall_process_region): Ditto.
2565
2566 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2567
2568 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2569 rather than `XVECTOR (FOO)->size'.
2570
2571 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2572 inttypes.h, as a gnulib replacement is used if it not available in
2573 system headers.
2574
2575 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2576
2577 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2578 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2579 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2580
2581 * coding.c (coding_alloc_by_realloc): Error out if destination
2582 will grow beyond MOST_POSITIVE_FIXNUM.
2583 (decode_coding_emacs_mule): Abort if there isn't enough place in
2584 charbuf for the composition carryover bytes. Reserve an extra
2585 space for up to 2 characters produced in a loop.
2586 (decode_coding_iso_2022): Abort if there isn't enough place in
2587 charbuf for the composition carryover bytes.
2588
2589 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2590
2591 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2592 aborting when %lld or %lll format is passed.
2593 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2594 %llo or %llx format is passed. (Bug#8545)
2595
2596 * window.c (window_scroll_line_based): Use a marker instead of
2597 simple variables to record original value of point. (Bug#7952)
2598
2599 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2600 produced by %s or %c overflows available buffer space. (Bug#8545)
2601
2602 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2603
2604 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2605 (SIZE_MAX): Move defn after all includes, as they might #define it.
2606
2607 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2608
2609 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2610
2611 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2612
2613 * keyboard.c (Qdelayed_warnings_hook): Define.
2614 (command_loop_1): Run `delayed-warnings-hook'
2615 if Vdelayed_warnings_list is non-nil.
2616 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2617 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2618
2619 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2620
2621 * doprnt.c (doprnt): Don't return value smaller than the buffer
2622 size if the message was truncated. (Bug#8545).
2623
2624 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2625
2626 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2627 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2628
2629 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2630
2631 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2632
2633 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2634
2635 * makefile.w32-in: Update dependencies.
2636
2637 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2638
2639 Improve `doprnt' and its usage. (Bug#8545)
2640 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2641 `format_end'. Remove support for %l as a conversion specifier.
2642 Don't use xrealloc. Improve diagnostics when the %l size modifier
2643 is used. Update the commentary.
2644
2645 * eval.c (verror): Simplify calculation of size_t.
2646
2647 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2648 messages.
2649
2650 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2651
2652 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2653 change.
2654
2655 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2656
2657 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2658 This makes this file independent of the recent pseudovector change.
2659
2660 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2661
2662 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2663
2664 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2665 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2666 Remove unused local.
2667 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2668
2669 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2670 GCC 4.6.0 optimizes based on type-based alias analysis.
2671 For example, if b is of type struct buffer * and v of type struct
2672 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2673 != &v->size, and therefore "v->size = 1; b->size = 2; return
2674 v->size;" must therefore return 1. This assumption is incorrect
2675 for Emacs, since it type-puns struct Lisp_Vector * with many other
2676 types. To fix this problem, this patch adds a new type struct
2677 vectorlike_header that documents the constraints on layout of vectors
2678 and pseudovectors, and helps optimizing compilers not get fooled
2679 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2680 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2681 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2682 the size member.
2683 (XSETPVECTYPE): Rewrite in terms of new macro.
2684 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2685 This is a bit clearer, and further avoids the possibility of
2686 undesirable aliasing.
2687 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2688 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2689 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2690 since Lisp_Subr is a special case (no "next" field).
2691 (ASIZE): Now uses header.size rather than size.
2692 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2693 to avoid the hassle of writing XVECTOR (foo)->header.size.
2694 (struct vectorlike_header): New type.
2695 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2696 object, to help avoid aliasing.
2697 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2698 (SUBRP): Likewise, since Lisp_Subr is a special case.
2699 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2700 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2701 (struct Lisp_Hash_Table): Combine first two members into a single
2702 struct vectorlike_header member. All uses of "size" and "next" members
2703 changed to be "header.size" and "header.next".
2704 * buffer.h (struct buffer): Likewise.
2705 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2706 * frame.h (struct frame): Likewise.
2707 * process.h (struct Lisp_Process): Likewise.
2708 * termhooks.h (struct terminal): Likewise.
2709 * window.c (struct save_window_data, struct saved_window): Likewise.
2710 * window.h (struct window): Likewise.
2711 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2712 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2713 * buffer.c (init_buffer_once): Likewise.
2714 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2715 special case.
2716 * process.c (Fformat_network_address): Use local var for size,
2717 for brevity.
2718
2719 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2720
2721 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2722 * data.c (atof): Remove decl; no longer used or needed.
2723 (digit_to_number): Move to lread.c.
2724 (Fstring_to_number): Use new string_to_number function, to be
2725 consistent with how the Lisp reader treats infinities and NaNs.
2726 Do not assume that floating-point numbers represent EMACS_INT
2727 without losing information; this is not true on most 64-bit hosts.
2728 Avoid double-rounding errors, by insisting on integers when
2729 parsing non-base-10 numbers, as the documentation specifies.
2730 * lisp.h (string_to_number): New decl, replacing ...
2731 (isfloat_string): Remove.
2732 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2733 (read1): Do not accept +. and -. as integers; this
2734 appears to have been a coding error. Similarly, do not accept
2735 strings like +-1e0 as floating point numbers. Do not report
2736 overflow for integer overflows unless the base is not 10 which
2737 means we have no simple and reliable way to continue.
2738 Break out the floating-point parsing into a new
2739 function string_to_number, so that Fstring_to_number parses
2740 floating point numbers consistently with the Lisp reader.
2741 (digit_to_number): Move here from data.c. Make it static inline.
2742 (E_CHAR, EXP_INT): Remove, replacing with ...
2743 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2744 (string_to_number): New function, replacing isfloat_string.
2745 This function checks for valid syntax and produces the resulting
2746 Lisp float number too. Rework it so that string-to-number
2747 no longer mishandles examples like "1.0e+". Use strtoumax,
2748 so that overflow for non-base-10 numbers is reported only when
2749 there's no portable and simple way to convert to floating point.
2750
2751 * textprop.c (set_text_properties_1): Rewrite for clarity,
2752 and to avoid GCC warning about integer overflow.
2753
2754 * intervals.h (struct interval): Use EMACS_INT for members
2755 where EMACS_UINT might cause problems. See
2756 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2757 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2758 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2759 All uses changed.
2760 (offset_intervals): Tell GCC not to worry about length overflow
2761 when negating a negative length.
2762
2763 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2764 (overrun_check_free): Likewise.
2765
2766 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2767 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2768 word size.
2769
2770 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2771 (gnutls_make_error): Rename local to avoid shadowing.
2772 (gnutls_emacs_global_deinit): ifdef out; not used.
2773 (Fgnutls_boot): Use const for pointer to readonly storage.
2774 Comment out unused local. Fix pointer signedness problems.
2775
2776 * lread.c (openp): Don't stuff size_t into an 'int'.
2777 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2778 about possible signed overflow.
2779
2780 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2781 (GDK_KEY_g): Don't define if already defined.
2782 (xg_prepare_tooltip): Avoid pointer signedness problem.
2783 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2784
2785 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2786 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2787
2788 * xfns.c (Fx_window_property): Simplify a bit,
2789 to make a bit faster and to avoid GCC 4.6.0 warning.
2790 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2791
2792 * fns.c (internal_equal): Don't assume size_t fits in int.
2793
2794 * alloc.c (compact_small_strings): Tighten assertion a little.
2795
2796 Replace pEd with more-general pI, and fix some printf arg casts.
2797 * lisp.h (pI): New macro, generalizing old pEd macro to other
2798 conversion specifiers. For example, use "...%"pI"d..." rather
2799 than "...%"pEd"...".
2800 (pEd): Remove. All uses replaced with similar uses of pI.
2801 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2802 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2803 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2804 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2805 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2806 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2807 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2808 64-bit hosts.
2809 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2810 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2811 * print.c (safe_debug_print, print_object): Likewise.
2812 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2813 to int.
2814 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2815 avoiding the 0 flag, which is not portable.
2816 * process.c (Fmake_network_process): Use pI to avoid cast.
2817 * region-cache.c (pp_cache): Likewise.
2818 * xdisp.c (decode_mode_spec): Likewise.
2819 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2820 behavior on 64-bit hosts with printf arg.
2821 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2822 (x_stop_queuing_selection_requests): Likewise.
2823 (x_get_window_property): Don't truncate byte count to an 'int'
2824 when tracing.
2825
2826 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2827 here, since it parses constructs like leading '-' and spaces,
2828 which are not wanted; and it overflows with large numbers.
2829 Instead, simply match F[0-9]+, which is what is wanted anyway.
2830
2831 * alloc.c: Remove unportable assumptions about struct layout.
2832 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2833 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2834 (allocate_vectorlike, make_pure_vector): Use the new macros,
2835 plus offsetof, to remove unportable assumptions about struct layout.
2836 These assumptions hold on all porting targets that I know of, but
2837 they are not guaranteed, they're easy to remove, and removing them
2838 makes further changes easier.
2839
2840 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2841 This doesn't fix a bug but makes the code clearer.
2842 (string_overrun_cookie): Now const. Use initializers that
2843 don't formally overflow signed char, to avoid warnings.
2844 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2845 can cause Emacs to crash when string overrun checking is enabled.
2846 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2847 multiple of sizeof (EMACS_INT); it need not be, if
2848 alignof(EMACS_INT) < sizeof (EMACS_INT).
2849 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2850
2851 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2852
2853 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2854
2855 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2856
2857 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2858 supposed to be handshaking. (Bug#8556)
2859 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2860
2861 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2862
2863 * lisp.h (Qdebug): List symbol.
2864 * eval.c (Qdebug): Restore global linkage.
2865 * keyboard.c (debug-on-event): New variable.
2866 (handle_user_signal): Break into debugger when debug-on-event
2867 matches the current signal symbol.
2868
2869 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2870
2871 * alloc.c (check_sblock, check_string_bytes)
2872 (check_string_free_list): Convert to standard C.
2873
2874 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2875
2876 * w32.c (emacs_gnutls_push): Fix typo.
2877
2878 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2879
2880 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2881 "cast to pointer from integer of different size".
2882
2883 Improve doprnt and its use in verror. (Bug#8545)
2884 * doprnt.c (doprnt): Document the set of format control sequences
2885 supported by the function. Use SAFE_ALLOCA instead of always
2886 using `alloca'.
2887
2888 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2889 is one byte too soon. Don't use xrealloc; instead xfree and
2890 xmalloc anew.
2891
2892 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2893
2894 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2895 callbacks stage.
2896
2897 * gnutls.c: Renamed global_initialized to
2898 gnutls_global_initialized. Added internals for the
2899 :verify-hostname-error, :verify-error, and :verify-flags
2900 parameters of `gnutls-boot' and documented those parameters in the
2901 docstring. Start callback support.
2902 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2903 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2904 on error. Return error code.
2905 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2906 (emacs_gnutls_read): Likewise.
2907 (Fgnutls_boot): Return handshake error code.
2908 (emacs_gnutls_handle_error): New function.
2909 (wsaerror_to_errno): Likewise.
2910
2911 * w32.h (emacs_gnutls_pull): Add prototype.
2912 (emacs_gnutls_push): Likewise.
2913
2914 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2915 (emacs_gnutls_push): Likewise.
2916
2917 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2918
2919 * process.c (wait_reading_process_output): Check if GnuTLS
2920 buffered some data internally if no FDs are set for TLS
2921 connections.
2922
2923 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2924 (LIBS): Link to USER_LIBS.
2925 ($(BLD)/gnutls.$(0)): New target.
2926
2927 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2928
2929 * xdisp.c (handle_single_display_spec): Rename the
2930 display_replaced_before_p argument into display_replaced_p, to
2931 make it consistent with the commentary. Fix typos in the
2932 commentary.
2933
2934 * textprop.c (syms_of_textprop): Remove dead code.
2935 (copy_text_properties): Delete obsolete commentary about an
2936 interface that was deleted long ago. Fix typos in the description
2937 of arguments.
2938
2939 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2940 to changes in oldXMenu/XMenu.h from 2011-04-16.
2941 <menu_help_message, prev_menu_help_message>: Constify.
2942 (IT_menu_make_room): menu->help_text is now `const char **';
2943 adjust.
2944
2945 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2946 to changes in oldXMenu/XMenu.h from 2011-04-16.
2947 (struct XMenu): Declare `help_text' `const char **'.
2948
2949 * xfaces.c <Qunspecified>: Make extern again.
2950
2951 * syntax.c: Include sys/types.h before including regex.h, as
2952 required by Posix.
2953
2954 * doc.c (get_doc_string): Improve the format passed to `error'.
2955
2956 * doprnt.c (doprnt): Improve commentary.
2957
2958 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2959
2960 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2961 them with etags.
2962
2963 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2964 changes in globals.h immediately force recompilation.
2965 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2966 $(CURDIR)/s/ms-w32.h.
2967 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2968
2969 * character.c (Fchar_direction): Function deleted.
2970 (syms_of_character): Don't defsubr it.
2971 <char-direction-table>: Deleted.
2972
2973 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2974
2975 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2976 * doprnt.c: Include limits.h.
2977 (SIZE_MAX): New macro.
2978 (doprnt): Return a size_t value. 2nd arg is now size_t.
2979 Many local variables are now size_t instead of int or unsigned.
2980 Improve overflow protection. Support `l' modifier for integer
2981 conversions. Support %l conversion. Don't assume an EMACS_INT
2982 argument for integer conversions and for %c.
2983
2984 * lisp.h (doprnt): Restore prototype.
2985
2986 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2987 $(SRC)/character.h.
2988
2989 * Makefile.in (base_obj): Add back doprnt.o.
2990
2991 * deps.mk (doprnt.o): Add back prerequisites.
2992 (callint.o): Depend on character.h.
2993
2994 * eval.c (internal_lisp_condition_case): Include the handler
2995 representation in the error message.
2996 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2997 when breaking from the loop.
2998
2999 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3000
3001 * callint.c (Fcall_interactively): When displaying error message
3002 about invalid control letter, pass the character's codepoint, not
3003 a pointer to its multibyte form. Improve display of the character
3004 in octal and display also its hex code.
3005
3006 * character.c (char_string): Use %x to display the (unsigned)
3007 codepoint of an invalid character, to avoid displaying a bogus
3008 negative value.
3009
3010 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3011 `error', not SYMBOL_NAME itself.
3012
3013 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3014 character arguments to `error'.
3015
3016 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3017 to `error' in error message about FINAL_CHAR argument. Make sure
3018 FINAL_CHAR is a character, and use %c when it is passed as
3019 argument to `error'.
3020
3021 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3022
3023 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3024
3025 * w32.c: Include <time.h>.
3026 (sys_localtime): New function.
3027
3028 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3029
3030 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3031
3032 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3033
3034 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3035
3036 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3037 zombies (Bug#8467).
3038
3039 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3040
3041 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3042 gl_state.e_property when gl_state.object is Qt.
3043
3044 * insdel.c (make_gap_larger): Remove limitation of buffer size
3045 to <= INT_MAX.
3046
3047 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3048
3049 * xdisp.c (lookup_glyphless_char_display)
3050 (produce_glyphless_glyph): Handle cons cell entry in
3051 glyphless-char-display.
3052 (Vglyphless_char_display): Document it.
3053
3054 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3055 glyphless-char-display.
3056
3057 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3058
3059 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3060
3061 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3062
3063 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3064 definition for no-X builds.
3065
3066 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3067
3068 Static checks with GCC 4.6.0 and non-default toolkits.
3069
3070 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3071
3072 * process.c (keyboard_bit_set): Define only if SIGIO.
3073 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3074 (send_process): Repair possible setjmp clobbering.
3075
3076 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3077
3078 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3079
3080 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3081
3082 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3083 Define only if needed.
3084
3085 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3086 by pacifying GCC about it. Maybe it's time to retire it?
3087 * xfaces.c (USG, __TIMEVAL__): Likewise.
3088
3089 * dispextern.h (struct redisplay_interface): Rename param
3090 to avoid shadowing.
3091 * termhooks.h (struct terminal): Likewise.
3092 * xterm.c (xembed_send_message): Likewise.
3093
3094 * insdel.c (make_gap_smaller): Define only if
3095 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3096
3097 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3098 it.
3099
3100 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3101 so that we aren't warned about unused symbols.
3102
3103 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3104
3105 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3106
3107 * xfns.c (x_real_positions): Mark locals as initialized.
3108
3109 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3110
3111 * xterm.c: Fix problems found by static analysis with other toolkits.
3112 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3113 (x_dispatch_event): Declare static if USE_GTK, and
3114 define if USE_GTK || USE_X_TOOLKIT.
3115 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3116 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3117 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3118 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3119
3120 * xmenu.c (menu_help_callback): Pointer type fixes.
3121 Use const pointers when pointing at readonly data. Avoid pointer
3122 signedness clashes.
3123 (FALSE): Remove unused macro.
3124 (update_frame_menubar): Remove unused decl.
3125
3126 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3127
3128 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3129 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3130 (single_menu_item): Rename local to avoid shadowing.
3131
3132 * keyboard.c (make_lispy_event): Remove unused local var.
3133
3134 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3135 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3136
3137 * bitmaps: Change bitmaps from unsigned char back to the X11
3138 compatible char. Avoid the old compiler warnings about
3139 out-of-range initializers by using, for example, '\xab' rather
3140 than 0xab.
3141
3142 * xgselect.c (xgselect_initialize): Check vs interface
3143 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3144
3145 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3146
3147 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3148 to read-only memory.
3149
3150 * fns.c (vector): Remove; this old hack is no longer needed.
3151
3152 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3153 Remove unused var.
3154 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3155
3156 * xrdb.c (x_load_resources): Omit unused local.
3157
3158 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3159 (x_window): Rename locals to avoid shadowing.
3160 (USG): Use the kludged USG macro, to pacify gcc.
3161
3162 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3163 (x_term_init): Remove local to avoid shadowing.
3164
3165 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3166
3167 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3168 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3169
3170 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3171
3172 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3173
3174 Fix regex.c, syntax.c and friends for buffers > 2GB.
3175 * syntax.h (struct gl_state_s): Declare character position members
3176 EMACS_INT.
3177
3178 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3179
3180 * textprop.c (verify_interval_modification, interval_of):
3181 Declare arguments EMACS_INT.
3182
3183 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3184 EMACS_INT.
3185
3186 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3187
3188 * indent.c (Fvertical_motion): Local variable it_start is now
3189 EMACS_INT.
3190
3191 * regex.c (re_match, re_match_2, re_match_2_internal)
3192 (bcmp_translate, regcomp, regexec, print_double_string)
3193 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3194 (re_compile_pattern, re_exec): Declare arguments and local
3195 variables `size_t' and `ssize_t' and return values `regoff_t', as
3196 appropriate.
3197 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3198 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3199 <compile_stack_type>: `size' and `avail' are now `size_t'.
3200
3201 * regex.h <regoff_t>: Use ssize_t, not int.
3202 (re_search, re_search_2, re_match, re_match_2): Arguments that
3203 specify buffer/string position and length are now ssize_t and
3204 size_t. Return type is regoff_t.
3205
3206 2011-04-16 Ben Key <bkey76@gmail.com>
3207
3208 * nsfont.m: Fixed bugs in ns_get_family and
3209 ns_descriptor_to_entity that were caused by using free to
3210 deallocate memory blocks that were allocated by xmalloc (via
3211 xstrdup). This caused Emacs to crash when compiled with
3212 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3213 --enable-checking=xmallocoverrun). xfree is now used to
3214 deallocate these memory blocks.
3215
3216 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3217
3218 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3219
3220 emacs_write: Accept and return EMACS_INT for sizes.
3221 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3222 et seq.
3223 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3224 Accept and return EMACS_INT.
3225 (emacs_gnutls_write): Return the number of bytes written on
3226 partial writes.
3227 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3228 (emacs_read, emacs_write): Remove check for negative size, as the
3229 Emacs source code has been audited now.
3230 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3231 (emacs_read, emacs_write): Use it.
3232 * process.c (send_process): Adjust to the new signatures of
3233 emacs_write and emacs_gnutls_write. Do not attempt to store
3234 a byte offset into an 'int'; it might overflow.
3235 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3236
3237 * sound.c: Don't assume sizes fit in 'int'.
3238 (struct sound_device.period_size, alsa_period_size):
3239 Return EMACS_INT, not int.
3240 (struct sound_device.write, vox_write, alsa_write):
3241 Accept EMACS_INT, not int.
3242 (wav_play, au_play): Use EMACS_INT to store sizes and to
3243 record read return values.
3244
3245 2011-04-15 Ben Key <bkey76@gmail.com>
3246
3247 * keyboard.c (Qundefined): Don't declare static since it is used
3248 in nsfns.m.
3249 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3250 static since they are used in nsfont.m.
3251
3252 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3253
3254 * process.c (Qprocessp): Don't declare static.
3255 * lisp.h (Qprocessp): Declare again.
3256
3257 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3258
3259 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3260
3261 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3262
3263 Improve C-level modularity by making more things 'static'.
3264
3265 Don't publish debugger-only interfaces to other modules.
3266 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3267 (verify_bytepos, count_markers): Move decls to the only modules
3268 that need them.
3269 * region-cache.h (pp_cache): Likewise.
3270 * window.h (check_all_windows): Likewise.
3271 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3272
3273 * sysdep.c (croak): Now static, if
3274 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3275 * syssignal.h (croak): Declare only if not static.
3276
3277 * alloc.c (refill_memory_reserve): Now static if
3278 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3279 * lisp.h (refill_memory_reserve): Declare only if not static.
3280
3281 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3282 Define only if USE_LUCID.
3283
3284 * xrdb.c (x_customization_string, x_rm_string): Now static.
3285
3286 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3287 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3288
3289 * xdisp.c (draw_row_with_mouse_face): Now static.
3290 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3291
3292 * window.h (check_all_windows): Mark externally visible.
3293
3294 * window.c (window_deletion_count): Now static.
3295
3296 * undo.c: Make symbols static if they're not exported.
3297 (last_undo_buffer, last_boundary_position, pending_boundary):
3298 Now static.
3299
3300 * textprop.c (interval_insert_behind_hooks): Now static.
3301 (interval_insert_in_front_hooks): Likewise.
3302
3303 * term.c: Make symbols static if they're not exported.
3304 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3305 (max_frame_lines, tty_set_terminal_modes):
3306 (tty_reset_terminal_modes, tty_turn_off_highlight):
3307 (get_tty_terminal): Now static.
3308 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3309 * termhooks.h (term_mouse_moveto): Do not declare if
3310 HAVE_WINDOW_SYSTEM.
3311 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3312 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3313
3314 * sysdep.c: Make symbols static if they're not exported.
3315 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3316 Now static.
3317 (sigprocmask_set, full_mask): Remove; unused.
3318 (wait_debugging): Mark as visible.
3319 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3320 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3321
3322 * syntax.c (syntax_temp): Define only if !__GNUC__.
3323
3324 * sound.c (current_sound_device, current_sound): Now static.
3325
3326 * search.c (searchbufs, searchbuf_head): Now static.
3327
3328 * scroll.c (scroll_cost): Remove; unused.
3329 * dispextern.h (scroll_cost): Remove decl.
3330
3331 * region-cache.h (pp_cache): Mark as externally visible.
3332
3333 * process.c: Make symbols static if they're not exported.
3334 (process_tick, update_tick, create_process, chan_process):
3335 (Vprocess_alist, proc_buffered_char, datagram_access):
3336 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3337 (deactivate_process): Mark defn as static, as well as decl.
3338 * lisp.h (create_process): Remove decl.
3339 * process.h (chan_process, Vprocess_alist): Remove decls.
3340
3341 * print.c: Make symbols static if they're not exported.
3342 (print_depth, new_backquote_output, being_printed, print_buffer):
3343 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3344 (print_interval, print_number_index, initial_stderr_stream):
3345 Now static.
3346 * lisp.h (Fprinc): Remove decl.
3347 (debug_output_compilation_hack): Mark as externally visible.
3348
3349 * sysdep.c (croak): Move decl from here to syssignal.h.
3350 * syssignal.h (croak): Put it here, so the API can be checked when
3351 'croak' is called from dissociate_if_controlling_tty.
3352
3353 * minibuf.c: Make symbols static if they're not exported.
3354 (minibuf_save_list, choose_minibuf_frame): Now static.
3355 * lisp.h (choose_minibuf_frame): Remove decl.
3356
3357 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3358
3359 * lread.c: Make symbols static if they're not exported.
3360 (read_objects, initial_obarray, oblookup_last_bucket_number):
3361 Now static.
3362 (make_symbol): Remove; unused.
3363 * lisp.h (initial_obarray, make_symbol): Remove decls.
3364
3365 * keyboard.c: Make symbols static if they're not exported.
3366 (single_kboard, recent_keys_index, total_keys, recent_keys):
3367 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3368 (this_single_command_key_start, echoing, last_auto_save):
3369 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3370 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3371 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3372 (Vlispy_mouse_stem, double_click_count):
3373 Now static.
3374 (force_auto_save_soon): Define only if SIGDANGER.
3375 (ignore_mouse_drag_p): Now static if
3376 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3377 (print_help): Remove; unused.
3378 (stop_character, last_timer_event): Mark as externally visible.
3379 * keyboard.h (ignore_mouse_drag_p): Declare only if
3380 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3381 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3382 * lisp.h (echoing): Remove decl.
3383 (force_auto_save_soon): Declare only if SIGDANGER.
3384 * xdisp.c (redisplay_window): Simplify code, to make it more
3385 obvious that ignore_mouse_drag_p is not accessed if !defined
3386 USE_GTK && !defined HAVE_NS.
3387
3388 * intervals.c: Make symbols static if they're not exported.
3389 (merge_properties_sticky, merge_interval_right, delete_interval):
3390 Now static.
3391 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3392
3393 * insdel.c: Make symbols static if they're not exported.
3394 However, leave prepare_to_modify_buffer alone. It's never
3395 called from outside this function, but that appears to be a bug.
3396 (combine_after_change_list, combine_after_change_buffer):
3397 (adjust_after_replace, signal_before_change): Now static.
3398 (adjust_after_replace_noundo): Remove; unused.
3399 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3400 (signal_before_change): Remove decls.
3401
3402 * indent.c (val_compute_motion, val_vmotion): Now static.
3403
3404 * image.c: Make symbols static if they're not exported.
3405 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3406 if USE_GTK.
3407 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3408 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3409
3410 * fringe.c (standard_bitmaps): Now static.
3411 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3412
3413 * frame.c: Make symbols static if they're not exported.
3414 (x_report_frame_params, make_terminal_frame): Now static.
3415 (get_frame_param): Now static, unless HAVE_NS.
3416 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3417 (x_get_resource_string): Remove; not used.
3418 * frame.h (make_terminal_frame, x_report_frame_params):
3419 (x_get_resource_string); Remove decls.
3420 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3421 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3422
3423 * font.c, fontset.c: Make symbols static if they're not exported.
3424 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3425 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3426 * font.c (font_close_object): Now static.
3427 * font.h (font_close_object): Remove.
3428 * fontset.c (FONTSET_OBJLIST): Remove.
3429 (free_realized_fontset) #if-0 the body, which does nothing.
3430 (face_suitable_for_char_p): #if-0, as it's never called.
3431 * fontset.h (face_suitable_for_char_p): Remove decl.
3432 * xfaces.c (face_at_string_position):
3433 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3434 since 0 is always ASCII.
3435
3436 * fns.c (weak_hash_tables): Now static.
3437
3438 * fileio.c: Make symbols static if they're not exported.
3439 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3440 (Vwrite_region_annotation_buffers): Now static.
3441
3442 * eval.c: Make symbols static if they're not exported.
3443 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3444 * lisp.h (backtrace_list): Remove decl.
3445
3446 * emacs.c: Make symbols static if they're not exported.
3447 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3448 (fatal_error_code, fatal_error_signal_hook, standard_args):
3449 Now static.
3450 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3451 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3452 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3453 * lisp.h (fatal_error_signal_hook): Remove decl.
3454 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3455
3456 * editfns.c: Move a (normally-unused) function to its only use.
3457 * editfns.c, lisp.h (get_operating_system_release): Remove.
3458 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3459 worth the hassle of breaking this out.
3460
3461 * xterm.c: Make symbols static if they're not exported.
3462 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3463 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3464 (x_destroy_window, x_delete_display):
3465 Now static.
3466 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3467 (x_mouse_leave): Remove; unused.
3468 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3469 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3470 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3471 Remove decls.
3472 (x_mouse_leave): Declare only if WINDOWSNT.
3473 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3474 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3475 USE_X_TOOLKIT.
3476
3477 * ftxfont.c: Make symbols static if they're not exported.
3478 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3479 HAVE_FREETYPE.
3480 * font.h (ftxfont_driver): Likewise.
3481
3482 * xfns.c: Make symbols static if they're not exported.
3483 (x_last_font_name, x_display_info_for_name):
3484 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3485 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3486 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3487 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3488 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3489 (last_show_tip_args): Now static.
3490 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3491 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3492 (x_screen_planes): Remove; unused.
3493 * dispextern.h (x_screen_planes): Remove decl.
3494
3495 * dispnew.c: Make symbols static if they're not exported.
3496 * dispextern.h (redraw_garbaged_frames, scrolling):
3497 (increment_row_positions): Remove.
3498 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3499 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3500 Now static.
3501 (redraw_garbaged_frames): Remove; unused.
3502
3503 * xfaces.c: Make symbols static if they're not exported.
3504 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3505 Remove decls.
3506 * xterm.h (defined_color): Remove decls.
3507 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3508 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3509 (menu_face_changed_default, defined_color, free_realized_face):
3510 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3511 (ascii_face_of_lisp_face): Remove; unused.
3512
3513 * xdisp.c: Make symbols static if they're not exported.
3514 * dispextern.h (scratch_glyph_row, window_box_edges):
3515 (glyph_to_pixel_coords, set_cursor_from_row):
3516 (get_next_display_element, set_iterator_to_next):
3517 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3518 (show_mouse_face): Remove decls
3519 * frame.h (message_buf_print): Likewise.
3520 * lisp.h (pop_message, set_message, check_point_in_composition):
3521 Likewise.
3522 * xterm.h (set_vertical_scroll_bar): Likewise.
3523 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3524 (message_buf_print, scratch_glyph_row, displayed_buffer):
3525 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3526 (get_next_display_element, show_mouse_face, window_box_edges):
3527 (frame_to_window_pixel_xy, check_point_in_composition):
3528 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3529 (glyph_to_pixel_coords): Remove; unused.
3530
3531 * dired.c (file_name_completion): Now static.
3532
3533 * dbusbind.c (xd_in_read_queued_messages): Now static.
3534
3535 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3536 * data.c (circular_list_error): Remove.
3537
3538 * commands.h (last_point_position, last_point_position_buffer):
3539 (last_point_position_window): Remove decls.
3540 * keyboard.c: Make these variables static.
3541
3542 * coding.h (coding, code_convert_region, encode_coding_gap):
3543 Remove decls.
3544 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3545 (iso_code_class, detect_coding, code_convert_region): Now static.
3546 (encode_coding_gap): Remove; unused.
3547
3548 * chartab.c (chartab_chars, chartab_bits): Now static.
3549
3550 * charset.h (charset_iso_8859_1): Remove decl.
3551 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3552 Now static.
3553
3554 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3555 * ccl.c (Vccl_program_table): Now static.
3556 (check_ccl_update): Remove; unused.
3557
3558 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3559 * category.h: ... from here.
3560 * category.c (check_category_table, set_category_set): Now static.
3561
3562 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3563 * lisp.h: Remove these decls.
3564
3565 * buffer.c (buffer_count): Remove unused var.
3566
3567 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3568 so that it's not optimized away.
3569 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3570 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3571 exported only to the debugger.
3572
3573 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3574 * atimer.h (run_all_atimers): Remove; not exported.
3575
3576 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3577 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3578 was inaccessible from Lisp.
3579 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3580 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3581
3582 alloc.c: Import and export fewer symbols, and remove unused items.
3583 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3584 is defined.
3585 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3586 it's not optimized away by whole-program optimization.
3587 (message_enable_multibyte, free_misc): Remove.
3588 (catchlist, handlerlist, mark_backtrace):
3589 Declare only if BYTE_MARK_STACK.
3590 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3591 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3592 (message_enable_multibyte): Remove decl.
3593 (free_misc, interval_free_list, float_block, float_block_index):
3594 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3595 (cons_free_list, last_marked_index):
3596 Now static.
3597 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3598 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3599 (mark_backtrace): Define only if BYTE_MARK_STACK.
3600 * xdisp.c (message_enable_multibyte): Now static.
3601
3602 Declare Lisp_Object Q* variables to be 'static' if not exported.
3603 This makes it easier for human readers (and static analyzers)
3604 to see whether these variables are used from other modules.
3605 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3606 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3607 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3608 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3609 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3610 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3611 * xmenu.c, xselect.c:
3612 Declare Q* vars static if they are not used in other modules.
3613 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3614 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3615 Remove decls of unexported vars.
3616 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3617
3618 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3619
3620 Make Emacs functions such as Fatom 'static' by default.
3621 This makes it easier for human readers (and static analyzers)
3622 to see whether these functions can be called from other modules.
3623 DEFUN now defines a static function. To make the function external
3624 so that it can be used in other C modules, use the new macro DEFUE.
3625 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3626 (Finit_image_library):
3627 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3628 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3629 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3630 Remove decls, since these functions are now static.
3631 (Funintern, Fget_internal_run_time): New decls, since these functions
3632 were already external.
3633
3634 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3635 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3636 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3637 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3638 * keyboard.c, keymap.c, lread.c:
3639 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3640 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3641 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3642 Mark functions with DEFUE instead of DEFUN,
3643 if they are used in other modules.
3644 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3645 decls for now-static functions.
3646 * buffer.h (Fdelete_overlay): Remove decl.
3647 * callproc.c (Fgetenv_internal): Mark as internal.
3648 * composite.c (Fremove_list_of_text_properties): Remove decl.
3649 (Fcomposition_get_gstring): New forward static decl.
3650 * composite.h (Fcomposite_get_gstring): Remove decl.
3651 * dired.c (Ffile_attributes): New forward static decl.
3652 * doc.c (Fdocumntation_property): New forward static decl.
3653 * eval.c (Ffetch_bytecode): New forward static decl.
3654 (Funintern): Remove extern decl; now in .h file where it belongs.
3655 * fileio.c (Fmake_symbolic_link): New forward static decl.
3656 * image.c (Finit_image_library): New forward static decl.
3657 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3658 * intervals.h (Fprevious_property_change):
3659 (Fremove_list_of_text_properties): Remove decls.
3660 * keyboard.c (Fthis_command_keys): Remove decl.
3661 (Fcommand_execute): New forward static decl.
3662 * keymap.c (Flookup_key): New forward static decl.
3663 (Fcopy_keymap): Now static.
3664 * keymap.h (Flookup_key): Remove decl.
3665 * process.c (Fget_process): New forward static decl.
3666 (Fprocess_datagram_address): Mark as internal.
3667 * syntax.c (Fsyntax_table_p): New forward static decl.
3668 (skip_chars): Remove duplicate decl.
3669 * textprop.c (Fprevious_property_change): New forward static decl.
3670 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3671 Now internal.
3672 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3673 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3674
3675 * editfns.c (Fformat): Remove unreachable code.
3676
3677 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3678
3679 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3680 change. (Bug#8496)
3681
3682 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3683
3684 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3685 when at ZV. (Bug#8487)
3686
3687 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3688
3689 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3690 (Bug#8437)
3691 * keyboard.c (parse_tool_bar_item): Likewise.
3692 * sound.c (sound_cleanup, alsa_close): Likewise.
3693 * termcap.c (tgetent): Likewise.
3694 * xfns.c (x_default_font_parameter): Likewise.
3695 * xsettings.c (read_and_apply_settings): Likewise.
3696
3697 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3698 (overrun_check_free): Protoize.
3699
3700 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3701
3702 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3703 since callers should never pass a negative size.
3704 Change the signature to match that of plain 'read' and 'write'; see
3705 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3706 * lisp.h: Update prototypes of emacs_write and emacs_read.
3707
3708 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3709
3710 * xdisp.c (redisplay_window): Don't try to determine the character
3711 position of the scroll margin if the window start point w->startp
3712 is outside the buffer's accessible region. (Bug#8468)
3713
3714 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3715
3716 Fix write-region and its subroutines for buffers > 2GB.
3717 * fileio.c (a_write, e_write): Modify declaration of arguments and
3718 local variables to support buffers larger than 2GB.
3719 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3720
3721 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3722 argument, local variables, and return value.
3723
3724 * lisp.h: Update prototypes of emacs_write and emacs_read.
3725
3726 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3727
3728 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3729
3730 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3731
3732 Fix more problems found by GCC 4.6.0's static checks.
3733
3734 * xdisp.c (vmessage): Use a better test for character truncation.
3735
3736 * charset.c (load_charset_map): <, not <=, for optimization,
3737 and to avoid potential problems with integer overflow.
3738 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3739 * casetab.c (set_identity, shuffle): Likewise.
3740 * editfns.c (Fformat): Likewise.
3741 * syntax.c (skip_chars): Likewise.
3742
3743 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3744 This also lets GCC 4.6.0 generate slightly better loop code.
3745
3746 * callint.c (Fcall_interactively): <, not <=, for optimization.
3747 (Fcall_interactively): Count the number of arguments produced,
3748 not the number of arguments given. This is simpler and lets GCC
3749 4.6.0 generate slightly better code.
3750
3751 * ftfont.c: Distingish more carefully between FcChar8 and char.
3752 The previous code passed unsigned char * to a functions like
3753 strlen and xstrcasecmp that expect char *, which does not
3754 conform to the C standard.
3755 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3756 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3757 char * when the C standard requires it.
3758
3759 * keyboard.c (read_char): Remove unused var.
3760
3761 * eval.c: Port to Windows vsnprintf (Bug#8435).
3762 Include <limits.h>.
3763 (SIZE_MAX): Define if the headers do not.
3764 (verror): Do not give up if vsnprintf returns a negative count.
3765 Instead, grow the buffer. This ports to Windows vsnprintf, which
3766 does not conform to C99. Problem reported by Eli Zaretskii.
3767 Also, simplify the allocation scheme, by avoiding the need for
3768 calling realloc, and removing the ALLOCATED variable.
3769
3770 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3771
3772 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3773 But keep the doprint source code for now, as we might revamp it
3774 and use it again (Bug#8435).
3775 * lisp.h (doprnt): Remove.
3776 * Makefile.in (base_obj): Remove doprnt.o.
3777 * deps.mk (doprnt.o): Remove.
3778
3779 error: Print 32- and 64-bit integers portably (Bug#8435).
3780 Without this change, on typical 64-bit hosts error ("...%d...", N)
3781 was used to print both 32- and 64-bit integers N, which relied on
3782 undefined behavior.
3783 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3784 New macro.
3785 * lisp.h (error, verror): Mark as printf-like functions.
3786 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3787 Report overflow in size calculations when allocating printf buffer.
3788 Do not truncate output string at its first null byte.
3789 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3790 Truncate the output at a character boundary, since vsnprintf does not
3791 do that.
3792 * charset.c (check_iso_charset_parameter): Convert internal
3793 character to string before calling 'error', since %c now has the
3794 printf meaning.
3795 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3796 overflow when computing char to be passed to 'error'. Do not
3797 pass Lisp_Object to 'error'; pass the integer instead.
3798 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3799 formatted with plain %d.
3800
3801 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3802
3803 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3804
3805 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3806
3807 * xterm.c (x_catch_errors): Remove duplicate declaration.
3808
3809 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3810
3811 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3812
3813 2011-04-10 Jim Meyering <meyering@redhat.com>
3814
3815 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3816 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3817 return ssize_t not "int", and use size_t as the buffer length.
3818 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3819 * gnutls.h: Update declarations.
3820 * process.c (read_process_output): Use ssize_t, to match.
3821 (send_process): Likewise.
3822
3823 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3824
3825 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3826
3827 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3828
3829 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3830 Use unsigned char, to match FcChar8 type definition.
3831
3832 * xterm.c (handle_one_xevent):
3833 * xmenu.c (create_and_show_popup_menu):
3834 * xselect.c (x_decline_selection_request)
3835 (x_reply_selection_request): Avoid type-punned deref of X events.
3836
3837 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3838
3839 Fix some uses of `int' instead of EMACS_INT.
3840 * search.c (string_match_1, fast_string_match)
3841 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3842 (scan_buffer, find_next_newline_no_quit)
3843 (find_before_next_newline, search_command, Freplace_match)
3844 (Fmatch_data): Make some `int' variables be EMACS_INT.
3845
3846 * xdisp.c (display_count_lines): 3rd argument and return value now
3847 EMACS_INT. All callers changed.
3848 (pint2hrstr): Last argument is now EMACS_INT.
3849
3850 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3851 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3852 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3853 (decode_coding_utf_16, decode_coding_emacs_mule)
3854 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3855 (decode_coding_ccl, decode_coding_charset)
3856 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3857 (decode_coding_iso_2022, decode_coding_emacs_mule)
3858 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3859 <char_offset, last_offset>: Declare EMACS_INT.
3860 (encode_coding_utf_8, encode_coding_utf_16)
3861 (encode_coding_emacs_mule, encode_invocation_designation)
3862 (encode_designation_at_bol, encode_coding_iso_2022)
3863 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3864 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3865 Declare EMACS_INT.
3866 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3867 (encode_invocation_designation): Last argument P_NCHARS is now
3868 EMACS_INT.
3869 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3870 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3871
3872 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3873 All users changed.
3874
3875 * ccl.c (Fccl_execute_on_string): Declare some variables
3876 EMACS_INT.
3877
3878 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3879
3880 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3881
3882 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3883
3884 * process.c (Fformat_network_address): Doc fix.
3885
3886 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3887
3888 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3889
3890 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3891
3892 * keyboard.c (read_char): Call Lisp function help-form-show,
3893 instead of using internal_with_output_to_temp_buffer.
3894 (Qhelp_form_show): New var.
3895 (syms_of_keyboard): Use DEFSYM macro.
3896
3897 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3898
3899 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3900
3901 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3902
3903 * process.c (Flist_processes): Remove to Lisp.
3904 (list_processes_1): Delete.
3905
3906 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3907
3908 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3909
3910 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3911
3912 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3913
3914 Fix more problems found by GCC 4.6.0's static checks.
3915
3916 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3917
3918 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3919
3920 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3921
3922 * xdisp.c (vmessage): Mark as a printf-like function.
3923
3924 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3925
3926 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3927
3928 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3929 printf-like functions.
3930 (tiff_load): Add casts to remove these marks before passing them
3931 to system-supplied API.
3932
3933 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3934
3935 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3936 This avoids several warnings with gcc -Wstrict-overflow.
3937 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3938 directly, rather than having caller test rule sign. This avoids
3939 some unnecessary tests.
3940 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3941 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3942 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3943
3944 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3945 (xfont_open): Avoid unnecessary tests.
3946
3947 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3948
3949 * composite.h, composite.c (composition_gstring_put_cache):
3950 Use EMACS_INT, not int, for length.
3951
3952 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3953 breaking out part of COMPOSITION_DECODE_RULE.
3954 (COMPOSITION_DECODE_RULE): Use it.
3955 * composite.c (get_composition_id): Remove unused local vars,
3956 by using the new macro.
3957
3958 * textprop.c (set_text_properties_1): Change while to do-while,
3959 since the condition is always true at first.
3960
3961 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3962 (interval_deletion_adjustment): Return unsigned value.
3963 All uses changed.
3964
3965 * process.c (list_processes_1, create_pty, read_process_output):
3966 (exec_sentinel): Remove vars that were set but not used.
3967 (create_pty): Remove unnecessary "volatile"s.
3968 (Fnetwork_interface_info): Avoid possibility of int overflow.
3969 (read_process_output): Do adaptive read buffering even if carryover.
3970 (read_process_output): Simplify nbytes computation if buffered.
3971
3972 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3973
3974 * syntax.c (scan_words): Remove var that was set but not used.
3975 (update_syntax_table): Use unsigned instead of int.
3976
3977 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3978 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3979 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3980
3981 * print.c (print_error_message): Avoid int overflow.
3982
3983 * font.c (font_list_entities): Redo for clarity,
3984 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3985
3986 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3987 (font_score): Avoid potential overflow in diff calculation.
3988
3989 * fns.c (substring_both): Remove var that is set but not used.
3990 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3991
3992 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3993
3994 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3995 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3996 can always succeed if overflow has undefined behavior.
3997
3998 * search.c (boyer_moore, wordify): Remove vars set but not used.
3999 (wordify): Omit three unnecessary tests.
4000
4001 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4002 All callers changed. This avoids the need for an unused var.
4003
4004 * casefiddle.c (casify_region): Remove var that is set but not used.
4005
4006 * dired.c (file_name_completion): Remove var that is set but not used.
4007
4008 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4009
4010 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4011 (Finsert_file_contents): Remove unnecessary code checking fd.
4012
4013 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4014 Check for integer overflow on size calculations.
4015
4016 * buffer.c (Fprevious_overlay_change): Remove var that is set
4017 but not used.
4018
4019 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4020 Remove vars that are set but not used.
4021 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4022 (timer_check_2): Mark vars as initialized.
4023
4024 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4025
4026 * image.c (lookup_image): Remove var that is set but not used.
4027 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4028
4029 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4030 that are set but not used.
4031
4032 * xfns.c (make_invisible_cursor): Don't return garbage
4033 if XCreateBitmapFromData fails (Bug#8410).
4034
4035 * xselect.c (x_get_local_selection, x_handle_property_notify):
4036 Remove vars that are set but not used.
4037
4038 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4039 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4040
4041 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4042 Remove var that is set but not used.
4043 (scroll_bar_windows_size): Now size_t, not int.
4044 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4045 Check for overflow.
4046
4047 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4048 (map_tty_color) [!defined MSDOS]: Likewise.
4049
4050 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4051
4052 * coding.c: Remove vars that are set but not used.
4053 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4054 All callers changed.
4055 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4056 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4057 (decode_coding_charset): Remove vars that are set but not used.
4058
4059 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4060 that is set but not used.
4061
4062 * print.c (print_object): Remove var that is set but not used.
4063
4064 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4065 The gnulib version avoids calling malloc in the usual case,
4066 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4067 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4068 * filelock.c (current_lock_owner): Likewise.
4069 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4070 * sysdep.c: Include allocator.h, careadlinkat.h.
4071 (emacs_no_realloc_allocator): New static constant.
4072 (emacs_readlink): New function.
4073 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4074 ../lib/careadlinkat.h.
4075
4076 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4077
4078 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4079 first non-nil return value).
4080
4081 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4082
4083 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4084 if not defined (Bug#8403).
4085
4086 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4087
4088 * xdisp.c (display_count_lines): Remove parameter `start',
4089 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4090 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4091 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4092 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4093 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4094 and thereabouts. All callers changed.
4095 (get_per_char_metric): Remove parameter `f', unused since
4096 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4097
4098 2011-04-02 Jim Meyering <meyering@redhat.com>
4099
4100 do not dereference NULL upon failed strdup
4101 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4102 (ns_get_family): Likewise.
4103
4104 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4105
4106 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4107
4108 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4109
4110 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4111 later (Bug#8403).
4112
4113 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4114
4115 Add lexical binding.
4116
4117 * window.c (Ftemp_output_buffer_show): New fun.
4118 (Fsave_window_excursion):
4119 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4120
4121 * lread.c (lisp_file_lexically_bound_p): New function.
4122 (Fload): Bind Qlexical_binding.
4123 (readevalloop): Remove `evalfun' arg.
4124 Bind Qinternal_interpreter_environment.
4125 (Feval_buffer): Bind Qlexical_binding.
4126 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4127 Mark as dynamic.
4128 (syms_of_lread): Declare `lexical-binding'.
4129
4130 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4131
4132 * keyboard.c (eval_dyn): New fun.
4133 (menu_item_eval_property): Use it.
4134
4135 * image.c (parse_image_spec): Use Ffunctionp.
4136
4137 * fns.c (concat, mapcar1): Accept byte-code-functions.
4138
4139 * eval.c (Fsetq): Handle lexical vars.
4140 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4141 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4142 (FletX, Flet): Obey lexical binding.
4143 (Fcommandp): Handle closures.
4144 (Feval): New `lexical' arg.
4145 (eval_sub): New function extracted from Feval. Use it almost
4146 everywhere where Feval was used. Look up vars in lexical env.
4147 Handle closures.
4148 (Ffunctionp): Move from subr.el.
4149 (Ffuncall): Handle closures.
4150 (apply_lambda): Remove `eval_flags'.
4151 (funcall_lambda): Handle closures and new byte-code-functions.
4152 (Fspecial_variable_p): New function.
4153 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4154 but without exporting it to Lisp.
4155
4156 * doc.c (Fdocumentation, store_function_docstring):
4157 * data.c (Finteractive_form): Handle closures.
4158
4159 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4160 interactive spec.
4161
4162 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4163 New byte-codes.
4164 (exec_byte_code): New function extracted from Fbyte_code to handle new
4165 calling convention for byte-code-functions. Add new byte-codes.
4166
4167 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4168
4169 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4170
4171 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4172
4173 * xdisp.c (redisplay_internal): Fix prototype.
4174
4175 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4176
4177 * xdisp.c (SCROLL_LIMIT): New macro.
4178 (try_scrolling): Use it when setting scroll_limit.
4179 Limit scrolling to 100 screen lines.
4180 (redisplay_window): Even when falling back on "recentering",
4181 position point in the window according to scroll-conservatively,
4182 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4183
4184 (try_scrolling): When point is above the window, allow searching
4185 as far as scroll_max, or one screenful, to compute vertical
4186 distance from PT to the scroll margin position. This prevents
4187 try_scrolling from unnecessarily failing when
4188 scroll-conservatively is set to a value slightly larger than the
4189 window height. Clean up the case of PT below the margin at bottom
4190 of window: scroll_max can no longer be INT_MAX. When aggressive
4191 scrolling is in use, don't let point enter the opposite scroll
4192 margin as result of the scroll.
4193 (syms_of_xdisp) <scroll-conservatively>: Document the
4194 threshold of 100 lines for never-recentering scrolling.
4195
4196 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4197
4198 * dispextern.h (move_it_by_lines):
4199 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4200 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4201 (message_log_check_duplicate): Remove parameters `prev_bol' and
4202 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4203 (redisplay_internal): Remove parameter `preserve_echo_area',
4204 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4205
4206 * indent.c (Fvertical_motion):
4207 * window.c (window_scroll_pixel_based, Frecenter):
4208 Don't pass `need_y_p' to `move_it_by_lines'.
4209
4210 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4211
4212 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4213 steal a few bits to be more compact.
4214 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4215 Remove unneeded casts.
4216
4217 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4218
4219 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4220
4221 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4222 binding" message (bug#7967).
4223
4224 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4225
4226 Fix more problems found by GCC 4.6.0's static checks.
4227
4228 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4229 Remove unused local var.
4230
4231 * editfns.c (Fmessage_box): Remove unused local var.
4232
4233 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4234 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4235 Omit unused local vars.
4236 * window.c (shrink_windows): Omit unused local var.
4237 * menu.c (digest_single_submenu): Omit unused local var.
4238 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4239 Omit unused local var.
4240
4241 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4242 Don't assume string length fits in int.
4243 (keyremap_step, read_key_sequence): Use size_t for sizes.
4244 (read_key_sequence): Don't check last_real_key_start redundantly.
4245
4246 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4247 instead of alloca (Bug#8344).
4248
4249 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4250 (Fbacktrace_frame): Don't assume nframes fits in int.
4251
4252 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4253
4254 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4255 concerns.
4256
4257 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4258
4259 * cm.c (calccost): Turn while-do into do-while, for clarity.
4260
4261 * keyboard.c (syms_of_keyboard): Use the same style as later
4262 in this function when indexing through an array. This also
4263 works around GCC bug 48267.
4264
4265 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4266
4267 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4268
4269 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4270 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4271
4272 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4273 This avoids undefined behavior on integer overflow, and is a bit
4274 more convenient anyway since it is compared to a size_t variable.
4275
4276 Variadic C functions now count arguments with size_t, not int.
4277 This avoids an unnecessary limitation on 64-bit machines, which
4278 caused (substring ...) to crash on large vectors (Bug#8344).
4279 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4280 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4281 All variadic functions and their callers changed accordingly.
4282 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4283 * data.c (arith_driver, float_arith_driver): Likewise.
4284 * editfns.c (general_insert_function): Likewise.
4285 * eval.c (struct backtrace.nargs, interactive_p)
4286 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4287 (funcall_lambda, mark_backtrace): Likewise.
4288 * fns.c (concat): Likewise.
4289 * frame.c (x_set_frame_parameters): Likewise.
4290 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4291 0 if not found, not -1. All callers changed.
4292
4293 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4294 (stack_copy_size): Now size_t, not int.
4295 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4296
4297 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4298
4299 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4300 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4301 All callers changed.
4302
4303 * lisp.h (multibyte_char_to_unibyte):
4304 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4305 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4306 * character.h (CHAR_TO_BYTE8):
4307 * cmds.c (internal_self_insert):
4308 * editfns.c (general_insert_function):
4309 * keymap.c (push_key_description):
4310 * search.c (Freplace_match):
4311 * xdisp.c (message_dolog, set_message_1): All callers changed.
4312
4313 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4314
4315 * keyboard.c (safe_run_hook_funcall): New function.
4316 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4317 don't set the hook to nil, but remove the offending function instead.
4318 (Qcommand_hook_internal): Remove, unused.
4319 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4320 Vcommand_hook_internal.
4321
4322 * eval.c (enum run_hooks_condition): Remove.
4323 (funcall_nil, funcall_not): New functions.
4324 (run_hook_with_args): Call each function through a `funcall' argument.
4325 Remove `cond' argument, now redundant.
4326 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4327 (Frun_hook_with_args_until_failure): Adjust accordingly.
4328 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4329
4330 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4331
4332 * dispextern.h (string_buffer_position): Remove declaration.
4333
4334 * print.c (strout): Remove parameter `multibyte', unused since
4335 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4336
4337 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4338 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4339 All callers changed.
4340
4341 * w32.c (_wsa_errlist): Use braces for struct initializers.
4342
4343 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4344 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4345 All callers changed.
4346 (string_buffer_position): Likewise. Also, make static (it's never
4347 used outside xdisp.c).
4348 (cursor_row_p): Remove parameter `w', unused since
4349 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4350 (decode_mode_spec): Remove parameter `precision', introduced during
4351 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4352 All callers changed.
4353
4354 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4355
4356 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4357
4358 2011-03-27 Anders Lindgren <andlind@gmail.com>
4359
4360 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4361 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4362 (ns_update_auto_hide_menu_bar): New functions.
4363 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4364 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4365 ns_constrain_all_frames.
4366 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4367 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4368
4369 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4370
4371 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4372
4373 2011-03-27 Glenn Morris <rgm@gnu.org>
4374
4375 * syssignal.h: Replace RETSIGTYPE with void.
4376 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4377 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4378 Replace SIGTYPE with void everywhere.
4379 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4380 * s/template.h (SIGTYPE): Remove commented out definition.
4381
4382 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4383
4384 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4385 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4386
4387 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4388
4389 * w32.c (read_unc_volume): Use parameter `henum', instead of
4390 global variable `wget_enum_handle'.
4391
4392 * keymap.c (describe_vector): Remove parameters `indices' and
4393 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4394 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4395
4396 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4397
4398 * keyboard.c (timer_check): Remove parameter `do_it_now',
4399 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4400 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4401 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4402
4403 * keyboard.c (read_char):
4404 * w32menu.c (w32_menu_display_help):
4405 * xmenu.c (show_help_event, menu_help_callback):
4406 Adjust calls to `show_help_echo'.
4407
4408 * gtkutil.c (xg_maybe_add_timer):
4409 * keyboard.c (readable_events):
4410 * process.c (wait_reading_process_output):
4411 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4412
4413 * insdel.c (adjust_markers_gap_motion):
4414 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4415 (gap_left, gap_right): Don't call it.
4416
4417 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4418
4419 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4420 incurred during fontification.
4421
4422 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4423
4424 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4425 (DEFVAR_PER_BUFFER): Don't pass it.
4426
4427 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4428 (scrolling_window): Don't pass it.
4429
4430 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4431
4432 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4433
4434 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4435 and `suffix'.
4436 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4437 of variables specific to SELinux and computation of `encoded_absname'.
4438
4439 * image.c (XPutPixel): Remove unused variable `height'.
4440
4441 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4442
4443 * unexw32.c (get_section_info): Remove unused variable `section'.
4444
4445 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4446 (system_process_attributes): Remove unused variable `sess'.
4447 (sys_read): Remove unused variable `err'.
4448
4449 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4450 (w32_wnd_proc): Remove unused variable `isdead'.
4451 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4452 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4453 (x_create_tip_frame): Remove unused variable `tem'.
4454
4455 * w32inevt.c (w32_console_read_socket):
4456 Remove unused variable `no_events'.
4457
4458 * w32term.c (x_draw_composite_glyph_string_foreground):
4459 Remove unused variable `width'.
4460
4461 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4462
4463 * w32term.c (x_set_glyph_string_clipping):
4464 Don't pass uninitialized region to CombineRgn.
4465
4466 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4467
4468 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4469 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4470 (Fx_close_connection): Remove unused variable `i'.
4471
4472 * w32font.c (w32font_draw): Return number of glyphs.
4473 (w32font_open_internal): Remove unused variable `i'.
4474 (w32font_driver): Add missing initializer.
4475
4476 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4477 (fill_in_menu): Remove unused variable `items_added'.
4478
4479 * w32term.c (last_mouse_press_frame): Remove static global variable.
4480 (w32_clip_to_row): Remove unused variable `f'.
4481 (x_delete_terminal): Remove unused variable `i'.
4482
4483 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4484 (NOTHING): Remove unused static global variable.
4485 (uniscribe_check_otf): Remove unused variable `table'.
4486 (uniscribe_font_driver): Add missing initializers.
4487
4488 2011-03-23 Julien Danjou <julien@danjou.info>
4489
4490 * term.c (Fsuspend_tty, Fresume_tty):
4491 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4492 * window.c (temp_output_buffer_show):
4493 * insdel.c (signal_before_change):
4494 * frame.c (Fhandle_switch_frame):
4495 * fileio.c (Fdo_auto_save):
4496 * emacs.c (Fkill_emacs):
4497 * editfns.c (save_excursion_restore):
4498 * cmds.c (internal_self_insert):
4499 * callint.c (Fcall_interactively):
4500 * buffer.c (Fkill_all_local_variables):
4501 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4502 Use Frun_hooks.
4503 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4504 unconditionnaly since it does the check itself.
4505
4506 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4507
4508 Fix more problems found by GCC 4.5.2's static checks.
4509
4510 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4511 the first time through the loop, since we know p0 < p1 then.
4512 This also avoids a gcc -Wstrict-overflow warning.
4513
4514 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4515 leading to a memory leak, possible in functions like
4516 load_charset_map_from_file that can allocate an unbounded number
4517 of objects (Bug#8318).
4518
4519 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4520 that could (at least in theory) be that large.
4521
4522 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4523 This is less likely to overflow, and avoids undefined behavior if
4524 overflow does occur. All callers changed. Use strtoul to scan
4525 for the unsigned long integer.
4526 (pint2hrstr): Simplify and tune code slightly.
4527 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4528
4529 * scroll.c (do_scrolling): Work around GCC bug 48228.
4530 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4531
4532 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4533 This also avoids a warning with gcc -Wstrict-overflow.
4534 (validate_x_resource_name): Simplify count usage.
4535 This also avoids a warning with gcc -Wstrict-overflow.
4536
4537 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4538 fail (Bug#8306).
4539
4540 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4541
4542 * process.c (Fmake_network_process): Use socklen_t, not int,
4543 where POSIX says socklen_t is required in portable programs.
4544 This fixes a porting bug on hosts like 64-bit HP-UX, where
4545 socklen_t is wider than int (Bug#8277).
4546 (Fmake_network_process, server_accept_connection):
4547 (wait_reading_process_output, read_process_output):
4548 Likewise.
4549
4550 * process.c: Rename or move locals to avoid shadowing.
4551 (list_processes_1, Fmake_network_process):
4552 (read_process_output_error_handler, exec_sentinel_error_handler):
4553 Rename or move locals.
4554 (Fmake_network_process): Define label "retry_connect" only if needed.
4555 (Fnetwork_interface_info): Fix pointer signedness.
4556 (process_send_signal): Add cast to avoid pointer signedness problem.
4557 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4558 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4559
4560 Make tparam.h and terminfo.c consistent.
4561 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4562 Include tparam.h instead, since it declares them.
4563 * cm.h (PC): Remove extern decl; tparam.h now does this.
4564 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4565 * terminfo.c: Include tparam.h, to check interfaces.
4566 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4567 (tparam): Adjust signature to match interface in tparam.h;
4568 this removes some undefined behavior. Check that outstring and len
4569 are zero, which they always are with Emacs.
4570 * tparam.h (PC, BC, UP): New extern decls.
4571
4572 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4573 (xftfont_open): Rename locals to avoid shadowing.
4574
4575 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4576 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4577 (OTF_TAG_SYM): Omit macro if not needed.
4578 (ftfont_list): Remove unused local.
4579 (get_adstyle_property, ftfont_pattern_entity):
4580 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4581 Rename locals to avoid shadowing.
4582
4583 * xfont.c (xfont_list_family): Mark var as initialized.
4584
4585 * xml.c (make_dom): Now static.
4586
4587 * composite.c (composition_compute_stop_pos): Rename local to
4588 avoid shadowing.
4589 (composition_reseat_it): Remove unused locals.
4590 (find_automatic_composition, composition_adjust_point): Likewise.
4591 (composition_update_it): Mark var as initialized.
4592 (find_automatic_composition): Mark vars as initialized,
4593 with a FIXME (Bug#8290).
4594
4595 character.h: Rename locals to avoid shadowing.
4596 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4597 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4598 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4599 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4600 to avoid shadowing.
4601
4602 * textprop.c (property_change_between_p): Remove; unused.
4603
4604 * intervals.c (interval_start_pos): Now static.
4605
4606 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4607
4608 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4609 Rename locals to avoid shadowing.
4610
4611 * sound.c (wav_play, au_play, Fplay_sound_internal):
4612 Fix pointer signedness.
4613 (alsa_choose_format): Remove unused local var.
4614 (wav_play): Initialize a variable to 0, to prevent undefined
4615 behavior (Bug#8278).
4616
4617 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4618
4619 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4620
4621 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4622 clobbering (Bug#8298).
4623 * sysdep.c (sys_subshell): Likewise.
4624 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4625
4626 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4627 This should get cleaned up, so that child_setup has the
4628 same signature on all platforms.
4629
4630 * callproc.c (call_process_cleanup): Now static.
4631 (relocate_fd): Rename locals to avoid shadowing.
4632
4633 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4634
4635 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4636 not to be necessary, and produces flickering.
4637
4638 2011-03-20 Glenn Morris <rgm@gnu.org>
4639
4640 * config.in: Remove file.
4641
4642 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4643
4644 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4645 are now in src/globals.h.
4646 (syms_of_minibuf): Remove spurious & from previous change.
4647
4648 2011-03-20 Leo <sdl.web@gmail.com>
4649
4650 * minibuf.c (completing-read-function): New variable.
4651 (completing-read-default): Rename from completing-read.
4652 (completing-read): Call completing-read-function.
4653
4654 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4655
4656 * xfaces.c (Fx_load_color_file):
4657 Read color file from absolute filename (bug#8250).
4658
4659 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4660
4661 * makefile.w32-in: Update dependencies.
4662
4663 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4664
4665 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4666
4667 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4668
4669 Fix more problems found by GCC 4.5.2's static checks.
4670
4671 * process.c (make_serial_process_unwind, send_process_trap):
4672 (sigchld_handler): Now static.
4673
4674 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4675 That way, the code declares only the vars that it needs.
4676 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4677 * s/cygwin.h (PTY_ITERATION): Likewise.
4678 * s/darwin.h (PTY_ITERATION): Likewise.
4679 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4680
4681 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4682 * process.c (allocate_pty): Don't declare stb unless it's needed.
4683
4684 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4685 (CONSTANTLIM): Remove; unused.
4686 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4687 Define only if needed.
4688
4689 * unexelf.c (unexec): Name an expression,
4690 to avoid gcc -Wbad-function-cast warning.
4691 Use a different way to cause a compilation error if anyone uses
4692 n rather than nn, a way that does not involve shadowing.
4693 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4694
4695 * deps.mk (unexalpha.o): Remove; unused.
4696
4697 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4698 * unexec.h: New file.
4699 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4700 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4701 Depend on unexec.h.
4702 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4703 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4704 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4705 Change as necessary to match prototype in unexec.h.
4706
4707 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4708 shadowing.
4709 (back_comment, skip_chars): Mark vars as initialized.
4710
4711 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4712 Rename locals to avoid shadowing.
4713
4714 * lread.c (read1): Rewrite so as not to use empty "else".
4715 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4716
4717 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4718
4719 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4720 warning when compiling print.c.
4721
4722 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4723 instead of using an uninitialized var.
4724 (font_sort_entities): Mark var as initialized.
4725
4726 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4727
4728 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4729 pointers to constants.
4730 (font_parse_fcname): Remove unused vars.
4731 (font_delete_unmatched): Now static.
4732 (font_get_spec): Remove; unused.
4733 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4734 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4735 Rename or move locals to avoid shadowing.
4736
4737 * fns.c (require_nesting_list, require_unwind): Now static.
4738 (Ffillarray): Rename locals to avoid shadowing.
4739
4740 * floatfns.c (domain_error2): Define only if needed.
4741 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4742
4743 * alloc.c (mark_backtrace): Move decl from here ...
4744 * lisp.h: ... to here, so that it can be checked.
4745
4746 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4747 (Fdefvar): Rewrite so as not to use empty "else".
4748 (lisp_indirect_variable): Name an expression,
4749 to avoid gcc -Wbad-function-cast warning.
4750 (Fdefvar): Rename locals to avoid shadowing.
4751
4752 * callint.c (quotify_arg, quotify_args): Now static.
4753 (Fcall_interactively): Rename locals to avoid shadowing.
4754 Use const pointer when appropriate.
4755
4756 * lisp.h (get_system_name, get_operating_system_release):
4757 Move decls here, to check interfaces.
4758 * process.c (get_operating_system_release): Move decl to lisp.h.
4759 * xrdb.c (get_system_name): Likewise.
4760 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4761 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4762 some of which prompt warnings from gcc -Wbad-function-cast.
4763 (Fformat_time_string, Fencode_time, Finsert_char):
4764 (Ftranslate_region_internal, Fformat):
4765 Rename or remove local vars to avoid shadowing.
4766 (Ftranslate_region_internal): Mark var as initialized.
4767
4768 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4769 avoid shadowing.
4770
4771 * lisp.h (eassert): Check that the argument compiles, even if
4772 ENABLE_CHECKING is not defined.
4773
4774 * data.c (Findirect_variable): Name an expression, to avoid
4775 gcc -Wbad-function-cast warning.
4776 (default_value, arithcompare, arith_driver, arith_error): Now static.
4777 (store_symval_forwarding): Rename local to avoid shadowing.
4778 (Fmake_variable_buffer_local, Fmake_local_variable):
4779 Mark variables as initialized.
4780 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4781
4782 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4783 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4784 Rename locals to avoid shadowing.
4785 (mark_stack): Move local variables into the #ifdef region where
4786 they're used.
4787 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4788 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4789 needed otherwise.
4790 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4791 (GC_STRING_CHARS): Remove; not used.
4792 (Fmemory_limit): Cast sbrk's returned value to char *.
4793
4794 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4795 avoids undefined behavior in theory.
4796
4797 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4798
4799 Use functions, not macros, for up- and down-casing (Bug#8254).
4800 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4801 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4802 to use the following functions instead of these macros.
4803 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4804 EMACS_INT, since callers assume the returned value fits in int.
4805 (upcase1): Likewise, for UPCASE_TABLE.
4806 (uppercasep, lowercasep, upcase): New static inline functions.
4807 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4808 the race-condition problem in the old DOWNCASE.
4809
4810 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4811 Rename locals to avoid shadowing.
4812 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4813 (regex_compile, re_search_2, re_match_2_internal):
4814 Remove unused local vars.
4815 (FREE_VAR): Rewrite so as not to use empty "else",
4816 which gcc can warn about.
4817 (regex_compile, re_match_2_internal): Mark locals as initialized.
4818 (RETALLOC_IF): Define only if needed.
4819 (WORDCHAR_P): Likewise. This one is never needed, but is used
4820 only in a comment talking about a compiler bug, so put inside
4821 the #if 0 of that comment.
4822 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4823 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4824 Remove; unused.
4825
4826 * search.c (boyer_moore): Rename locals to avoid shadowing.
4827 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4828 (PREV_CHAR_BOUNDARY): Likewise.
4829
4830 * search.c (simple_search): Remove unused var.
4831
4832 * dired.c (compile_pattern): Move decl from here ...
4833 * lisp.h: ... to here, so that it can be checked.
4834 (struct re_registers): New forward decl.
4835
4836 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4837
4838 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4839 All uses changed.
4840 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4841 Rename locals to avoid shadowing.
4842 (Fvertical_motion): Mark locals as initialized.
4843
4844 * casefiddle.c (casify_object, casify_region): Now static.
4845 (casify_region): Mark local as initialized.
4846
4847 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4848
4849 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4850 New macros, so that the caller can use some names other than
4851 gcpro1, gcpro2, etc.
4852 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4853 of the new macros.
4854 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4855 argument, for consistency with GCPRO2_VAR, etc: it is now the
4856 prefix of the variable, not the variable itself. All uses
4857 changed.
4858 * dired.c (directory_files_internal, file_name_completion):
4859 Rename locals to avoid shadowing.
4860
4861 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4862 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4863 dired.c's scmp function, had undefined behavior.
4864 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4865 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4866 * buffer.h: ... to here, because these macros use current_buffer,
4867 and the new implementation with inline functions needs to have
4868 current_buffer in scope now, rather than later when the macros
4869 are used.
4870 (downcase, upcase1): New static inline functions.
4871 (DOWNCASE, UPCASE1): Reimplement using these functions.
4872 This avoids undefined behavior in expressions like
4873 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4874 from race conditions in accessing the global variables
4875 case_temp1 and case_temp2.
4876 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4877 * lisp.h (case_temp1, case_temp2): Remove their decls.
4878 * character.h (ASCII_CHAR_P): Move from here ...
4879 * lisp.h: ... to here, so that the inline functions mentioned
4880 above can use them.
4881
4882 * dired.c (directory_files_internal_unwind): Now static.
4883
4884 * fileio.c (file_name_as_directory, directory_file_name):
4885 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4886 Now static.
4887 (file_name_as_directory): Use const pointers when appropriate.
4888 (Fexpand_file_name): Likewise. In particular, newdir might
4889 point at constant storage, so make it a const pointer.
4890 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4891 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4892 signedness issues.
4893 (Fset_file_times, Finsert_file_contents, auto_save_error):
4894 Rename locals to avoid shadowing.
4895
4896 * minibuf.c (choose_minibuf_frame_1): Now static.
4897 (Ftry_completion, Fall_completions): Rename or remove locals
4898 to avoid shadowing.
4899
4900 * marker.c (bytepos_to_charpos): Remove; unused.
4901
4902 * lisp.h (verify_bytepos, count_markers): New decls,
4903 so that gcc does not warn that these functions aren't declared.
4904
4905 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4906 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4907 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4908 (copy_text): Remove unused local var.
4909
4910 * filelock.c (within_one_second): Now static.
4911 (lock_file_1): Rename local to avoid shadowing.
4912
4913 * buffer.c (fix_overlays_before): Mark locals as initialized.
4914 (fix_start_end_in_overlays): Likewise. This function should be
4915 simplified by using pointers-to-pointers, but that's a different
4916 matter.
4917 (switch_to_buffer_1): Now static.
4918 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4919 (report_overlay_modification): Rename locals to avoid shadowing.
4920
4921 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4922 Fix pointer signedness issue.
4923 (sys_subshell): Mark local as volatile if checking for lint,
4924 to suppress a gcc -Wclobbered warning that does not seem to be right.
4925 (MAXPATHLEN): Define only if needed.
4926
4927 * process.c (serial_open, serial_configure): Move decls from here ...
4928 * systty.h: ... to here, so that they can be checked.
4929
4930 * fns.c (get_random, seed_random): Move extern decls from here ...
4931 * lisp.h: ... to here, so that they can be checked.
4932
4933 * sysdep.c (reset_io): Now static.
4934 (wait_for_termination_signal): Remove; unused.
4935
4936 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4937 (copy_keymap_item, append_key, push_text_char_description):
4938 Now static.
4939 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4940 (DENSE_TABLE_SIZE): Remove; unused.
4941 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4942 (describe_map_tree):
4943 Rename locals to avoid shadowing.
4944
4945 * keyboard.c: Declare functions static if they are not used elsewhere.
4946 (echo_char, echo_dash, cmd_error, top_level_2):
4947 (poll_for_input, handle_async_input): Now static.
4948 (read_char, kbd_buffer_get_event, make_lispy_position):
4949 (make_lispy_event, make_lispy_movement, apply_modifiers):
4950 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4951 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4952 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4953 (read_key_sequence, read_char): Mark locals as initialized.
4954 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4955
4956 * keyboard.h (make_ctrl_char): New decl.
4957 (mark_kboards): Move decl here ...
4958 * alloc.c (mark_kboards): ... from here.
4959
4960 * lisp.h (force_auto_save_soon): New decl.
4961
4962 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4963 (DEFINE_DUMMY_FUNCTION): New macro.
4964 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4965 Use it.
4966 (main): Add casts to avoid warnings
4967 if GCC considers string literals to be constants.
4968
4969 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4970
4971 * dbusbind.c: Pointer signedness fixes.
4972 (xd_signature, xd_append_arg, xd_initialize):
4973 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4974 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4975 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4976 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4977
4978 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4979 if GCC considers string literals to be constants.
4980 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4981
4982 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4983
4984 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4985 (print_preprocess, print_object): New macro to fix last change.
4986
4987 * print.c (print_preprocess): Don't forget font objects.
4988
4989 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4990
4991 * emacs.c (USAGE3): Doc fixes.
4992
4993 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4994
4995 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4996 structure.
4997
4998 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4999
5000 * lisp.h (VWindow_system, Qfile_name_history):
5001 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5002 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5003 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5004
5005 * w32select.c: Don't #include "keyboard.h".
5006 (run_protected): Add extern declaration for waiting_for_input.
5007
5008 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5009 * w32console.c (detect_input_pending, read_input_pending)
5010 (encode_terminal_code):
5011 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5012 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5013 (w32_system_caret_y, Qfile_name_history):
5014 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5015 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5016 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5017 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5018 * w32proc.c (Qlocal, report_file_error):
5019 * w32term.c (Vwindow_system, updating_frame):
5020 * w32uniscribe.c (initialized, uniscribe_font_driver):
5021 Remove unneeded extern declarations.
5022
5023 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5024
5025 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5026
5027 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5028
5029 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5030 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5031 These macros can no longer be used for assignment.
5032
5033 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5034 Assign struct members directly, instead of using BUF_BEGV etc.
5035 (record_buffer_markers, fetch_buffer_markers): New functions for
5036 recording and fetching special buffer markers.
5037 (set_buffer_internal_1, set_buffer_temp): Use them.
5038
5039 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5040
5041 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5042
5043 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5044 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5045
5046 * xdisp.c (hscroll_window_tree):
5047 (reconsider_clip_changes): Use PT instead of BUF_PT.
5048
5049 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5050
5051 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5052 $(EMACS_ROOT)/lib/intprops.h.
5053
5054 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5055
5056 Fix more problems found by GCC 4.5.2's static checks.
5057
5058 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5059 to unsigned char * to avoid compiler diagnostic.
5060 (xg_free_frame_widgets): Make it clear that a local variable is
5061 needed only if USE_GTK_TOOLTIP.
5062 (gdk_window_get_screen): Make it clear that this macro is needed
5063 only if USE_GTK_TOOLTIP.
5064 (int_gtk_range_get_value): New function, which avoids a diagnostic
5065 from gcc -Wbad-function-cast.
5066 (xg_set_toolkit_scroll_bar_thumb): Use it.
5067 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5068 diagnostic from gcc -Wbad-function-cast.
5069 (get_utf8_string, xg_get_file_with_chooser):
5070 Rename locals to avoid shadowing.
5071 (create_dialog): Move locals to avoid shadowing.
5072
5073 * xgselect.c (xg_select): Remove unused var.
5074
5075 * image.c (four_corners_best): Mark locals as initialized.
5076 (gif_load): Initialize transparent_p to zero (Bug#8238).
5077 Mark another local as initialized.
5078 (my_png_error, my_error_exit): Mark with NO_RETURN.
5079
5080 * image.c (clear_image_cache): Now static.
5081 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5082 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5083 (x_edge_detection): Remove unnecessary cast that
5084 gcc -Wbad-function-cast diagnoses.
5085 (gif_load): Fix pointer signedness.
5086 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5087 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5088
5089 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5090
5091 Improve quality of tests for time stamp overflow.
5092 For example, without this patch (encode-time 0 0 0 1 1
5093 1152921504606846976) returns the obviously-bogus value (-948597
5094 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5095 reports time overflow. See
5096 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5097 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5098 * editfns.c: Include limits.h and intprops.h.
5099 (TIME_T_MIN, TIME_T_MAX): New macros.
5100 (time_overflow): Move earlier, to before first use.
5101 (hi_time, lo_time): New functions, for an accurate test for
5102 out-of-range times.
5103 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5104 (Fget_internal_run_time): Don't assume time_t fits in int.
5105 (make_time): Use list2 instead of Fcons twice.
5106 (Fdecode_time): More accurate test for out-of-range times.
5107 (check_tm_member): New function.
5108 (Fencode_time): Use it, to test for out-of-range times.
5109 (lisp_time_argument): Don't rely on undefined left-shift and
5110 right-shift behavior when checking for time stamp overflow.
5111
5112 * editfns.c (time_overflow): New function, refactoring common code.
5113 (Fformat_time_string, Fdecode_time, Fencode_time):
5114 (Fcurrent_time_string): Use it.
5115
5116 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5117 * dired.c (make_time): Move to ...
5118 * editfns.c (make_time): ... here.
5119 * systime.h: Note the move.
5120
5121 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5122
5123 * fringe.c (update_window_fringes): Remove unused variables.
5124
5125 * unexmacosx.c (copy_data_segment): Also copy __got section.
5126 (Bug#8223)
5127
5128 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5129
5130 * termcap.c [MSDOS]: Include "msdos.h".
5131 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5132 Constify `char *' arguments and their references according to
5133 prototypes in tparam.h.
5134
5135 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5136
5137 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5138 Adapt all references accordingly.
5139
5140 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5141
5142 2011-03-11 Tom Tromey <tromey@redhat.com>
5143
5144 * buffer.c (syms_of_buffer): Remove obsolete comment.
5145
5146 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5147
5148 * termhooks.h (encode_terminal_code): Declare prototype.
5149
5150 * msdos.c (encode_terminal_code): Don't declare prototype.
5151
5152 * term.c (encode_terminal_code): Now external again, used by
5153 w32console.c and msdos.c.
5154
5155 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5156 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5157
5158 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5159
5160 Fix some minor problems found by GCC 4.5.2's static checks.
5161
5162 * fringe.c (update_window_fringes): Mark locals as initialized
5163 (Bug#8227).
5164 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5165
5166 * alloc.c (mark_fringe_data): Move decl from here ...
5167 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5168 to check its interface.
5169 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5170
5171 * fontset.c (free_realized_fontset): Now static.
5172 (Fset_fontset_font): Rename local to avoid shadowing.
5173 (fontset_font): Mark local as initialized.
5174 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5175
5176 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5177
5178 * xselect.c (x_disown_buffer_selections): Remove; not used.
5179 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5180 (x_own_selection, Fx_disown_selection_internal): Rename locals
5181 to avoid shadowing.
5182 (x_handle_dnd_message): Remove local to avoid shadowing.
5183
5184 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5185 so that the caller can use some name other than gcpro1.
5186 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5187 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5188 (Fx_backspace_delete_keys_p):
5189 Use them to avoid shadowing, and rename vars to avoid shadowing.
5190 (x_decode_color, x_set_name, x_window): Now static.
5191 (Fx_create_frame): Add braces to silence GCC warning.
5192 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5193 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5194 Remove unused locals.
5195 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5196 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5197 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5198 macros.
5199
5200 * xterm.h (x_mouse_leave): New decl.
5201
5202 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5203 Remove unused functions.
5204 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5205 (x_calc_absolute_position): Now static.
5206 (XTread_socket): Don't define label "out" unless it's used.
5207 Don't declare local "event" unless it's used.
5208 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5209 unless they are used.
5210 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5211 (x_fatal_error_signal): Remove; not used.
5212 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5213 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5214 (x_error_catcher, x_connection_closed, x_error_handler):
5215 (x_error_quitter, xembed_send_message, x_iconify_frame):
5216 (my_log_handler): Rename locals to avoid shadowing.
5217 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5218 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5219
5220 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5221 Rename or move locals to avoid shadowing.
5222 (tty_defined_color, merge_face_heights): Now static.
5223 (free_realized_faces_for_fontset): Remove; not used.
5224 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5225 does not deduce is never used uninitialized.
5226 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5227 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5228
5229 * terminal.c (store_terminal_param): Now static.
5230
5231 * xmenu.c (menu_highlight_callback): Now static.
5232 (set_frame_menubar): Remove unused local.
5233 (xmenu_show): Rename parameter to avoid shadowing.
5234 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5235 since they might point to immutable storage.
5236 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5237 since it's unused otherwise.
5238
5239 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5240 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5241 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5242 avoids a gcc -Wuninitialized diagnostic.
5243 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5244 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5245 does not deduce are never used uninitialized.
5246
5247 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5248
5249 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5250 * window.c (window_loop, size_window):
5251 (run_window_configuration_change_hook, enlarge_window): Likewise.
5252
5253 * window.c (display_buffer): Now static.
5254 (size_window): Mark variables that gcc -Wuninitialized
5255 does not deduce are never used uninitialized.
5256 * window.h (check_all_windows): New decl, to forestall
5257 gcc -Wmissing-prototypes diagnostic.
5258 * dispextern.h (bidi_dump_cached_states): Likewise.
5259
5260 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5261 shadowing.
5262 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5263 Include <limits.h>.
5264 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5265 and to avoid gcc -Wuninitialized warning.
5266 (load_charset_map): Mark variables that gcc -Wuninitialized
5267 does not deduce are never used uninitialized.
5268 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5269
5270 * coding.c (coding_set_source, coding_set_destination):
5271 Use "else { /* comment */ }" rather than "else /* comment */;"
5272 for clarity, and to avoid gcc -Wempty-body warning.
5273 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5274 a block, when the outer 'i' will do.
5275 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5276 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5277 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5278 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5279 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5280 Rename locals to avoid shadowing.
5281 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5282 * coding.c (emacs_mule_char, encode_invocation_designation):
5283 Now static, since they're not used elsewhere.
5284 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5285 (decode_coding_object, encode_coding_object, detect_coding_system):
5286 (decode_coding_emacs_mule): Mark variables that gcc
5287 -Wuninitialized does not deduce are never used uninitialized.
5288 (detect_coding_iso_2022): Initialize a local variable that might
5289 be used uninitialized. Leave a FIXME because it's not clear that
5290 this initialization is needed. (Bug#8211)
5291 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5292 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5293 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5294 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5295 Remove unused macros.
5296
5297 * category.c (hash_get_category_set): Remove unused local var.
5298 (copy_category_table): Now static, since it's not used elsewhere.
5299 * character.c (string_count_byte8): Likewise.
5300
5301 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5302 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5303
5304 * chartab.c (copy_sub_char_table): Now static, since it's not used
5305 elsewhere.
5306 (sub_char_table_ref_and_range, char_table_ref_and_range):
5307 Rename locals to avoid shadowing.
5308 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5309
5310 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5311 (BIDI_BOB): Remove unused macro.
5312
5313 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5314 deduce are never used uninitialized.
5315 * term.c (encode_terminal_code): Likewise.
5316
5317 * term.c (encode_terminal_code): Now static. Remove unused local.
5318
5319 * tparam.h: New file.
5320 * term.c, tparam.h: Include it.
5321 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5322 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5323 Move these decls to tparam.h, and make them agree with what
5324 is actually in tparam.c. The previous trick of using incompatible
5325 decls in different modules does not conform to the C standard.
5326 All callers of tparam changed to use tparam's actual API.
5327 * tparam.c (tparam1, tparam, tgoto):
5328 Use const pointers where appropriate.
5329
5330 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5331 * cm.h (struct cm): Likewise.
5332 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5333 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5334 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5335 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5336 (turn_on_face, init_tty): Likewise.
5337 * termchar.h (struct tty_display_info): Likewise.
5338
5339 * term.c (term_mouse_position): Rename local to avoid shadowing.
5340
5341 * alloc.c (mark_ttys): Move decl from here ...
5342 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5343
5344 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5345
5346 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5347
5348 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5349
5350 * search.c (compile_pattern_1): Remove argument regp, unused since
5351 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5352 (compile_pattern): Don't pass it.
5353
5354 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5355
5356 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5357 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5358 for ! HAVE_GTK3.
5359 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5360
5361 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5362
5363 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5364 gdk_window_get_screen, gdk_window_get_geometry,
5365 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5366 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5367 (xg_get_pixbuf_from_pixmap): New function.
5368 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5369 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5370 Call xg_get_pixbuf_from_pixmap instead of
5371 gdk_pixbuf_get_from_drawable.
5372 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5373 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5374 (xg_check_special_colors): Use GtkStyleContext and its functions
5375 for HAVE_GTK3.
5376 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5377 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5378 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5379 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5380 Call gtk_widget_get_preferred_size.
5381 (xg_frame_resized): gdk_window_get_geometry only takes 5
5382 parameters.
5383 (xg_win_to_widget, xg_event_is_for_menubar):
5384 Call gdk_x11_window_lookup_for_display.
5385 (xg_set_widget_bg): New function.
5386 (delete_cb): New function.
5387 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5388 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5389 (xg_set_background_color): Call xg_set_widget_bg.
5390 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5391 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5392 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5393 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5394 if ! HAVE_GTK3.
5395 (update_frame_tool_bar): Call gtk_widget_hide.
5396 (xg_initialize): Use GDK_KEY_g.
5397
5398 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5399 if ! HAVE_GTK3
5400 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5401
5402 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5403 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5404 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5405
5406 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5407
5408 * w32xfns.c (select_palette): Check success of RealizePalette against
5409 GDI_ERROR, not zero.
5410
5411 See ChangeLog.11 for earlier changes.
5412
5413 ;; Local Variables:
5414 ;; coding: utf-8
5415 ;; End:
5416
5417 Copyright (C) 2011 Free Software Foundation, Inc.
5418
5419 This file is part of GNU Emacs.
5420
5421 GNU Emacs is free software: you can redistribute it and/or modify
5422 it under the terms of the GNU General Public License as published by
5423 the Free Software Foundation, either version 3 of the License, or
5424 (at your option) any later version.
5425
5426 GNU Emacs is distributed in the hope that it will be useful,
5427 but WITHOUT ANY WARRANTY; without even the implied warranty of
5428 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5429 GNU General Public License for more details.
5430
5431 You should have received a copy of the GNU General Public License
5432 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.