* emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
[bpt/emacs.git] / src / ChangeLog
1 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 sprintf-related integer and memory overflow issues.
4
5 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6 (esprintf, esnprintf, exprintf, evxprintf): New functions.
7 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
8 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
9 (modify_event_symbol): Do not assume that the length of
10 name_alist_or_stem is safe to alloca and fits in int.
11 (Fexecute_extended_command): Likewise for function name and binding.
12 (Frecursion_depth): Wrap around reliably on integer overflow.
13 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
14 since some callers pass EMACS_INT values.
15 (Fsingle_key_description): Don't crash if symbol name contains more
16 than MAX_ALLOCA bytes.
17 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
18 (get_minibuffer): Arg is now EMACS_INT, not int.
19 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
20 (esprintf, esnprintf, exprintf, evxprintf): New decls.
21 * window.h (command_loop_level, minibuf_level): Reflect API changes.
22
23 * dbusbind.c (xd_signature, Fdbus_register_signal):
24 Do not overrun buffer; instead, report string overflow.
25
26 * dispnew.c (add_window_display_history): Don't overrun buffer.
27 Truncate instead; this is OK since it's just a log.
28
29 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
30 even if the time zone offset is outlandishly large.
31 Don't mishandle offset == INT_MIN.
32
33 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
34 when creating daemon; the previous buffer-overflow check was incorrect.
35
36 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
37
38 Integer and memory overflow issues (Bug#9196).
39
40 * doc.c (get_doc_string): Rework so that
41 get_doc_string_buffer_size is the actual buffer size, rather than
42 being 1 less than the actual buffer size; this makes xpalloc more
43 convenient.
44
45 * image.c (x_allocate_bitmap_record, cache_image):
46 * xselect.c (Fx_register_dnd_atom):
47 Simplify previous changes by using xpalloc.
48
49 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
50 since either will do and ptrdiff_t is convenient with xpalloc.
51
52 * charset.c (charset_table_size)
53 (struct charset_sort_data.priority): Now ptrdiff_t.
54 (charset_compare): Don't overflow if priorities differ greatly.
55 (Fsort_charsets): Don't assume list length fits in int.
56 Check for size-calculation overflow when allocating sort data.
57 (syms_of_charset): Allocate an initial charset table that is
58 just under 64 KiB, to avoid problems with glibc malloc and mmap.
59
60 * cmds.c (internal_self_insert): Check for size-calculation overflow.
61
62 * composite.h (struct composition.glyph_len): Now int, not unsigned.
63 The actual value is always <= INT_MAX, and leaving it unsigned made
64 overflow checking harder.
65
66 * dispextern.h (struct glyph_matrix.rows_allocated)
67 (struct face_cache.size): Now ptrdiff_t, for convenience in use
68 with xpalloc. The values are still always <= INT_MAX.
69
70 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
71
72 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
73 (SAFE_NALLOCA): New macro.
74
75 * region-cache.c (struct boundary.pos, find_cache_boundary)
76 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
77 (set_cache_region, invalidate_region_cache)
78 (revalidate_region_cache, know_region_cache, region_cache_forward)
79 (region_cache_backward, pp_cache):
80 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
81 so that ptrdiff_t * can be passed to xpalloc.
82 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
83 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
84 (pp_cache): Don't assume cache_len fits in int.
85 * region-cache.h: Adjust extern decls to match.
86
87 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
88 EMACS_INT, since either will do, for xpalloc.
89
90 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
91 (xnmalloc, xnrealloc, xpalloc): New functions.
92
93 * bidi.c (bidi_shelve_header_size): New constant.
94 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
95 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
96
97 * bidi.c (bidi_cache_shrink):
98 * buffer.c (overlays_at, overlays_in, record_overlay_string)
99 (overlay_strings):
100 Don't update size of array until after memory allocation succeeds,
101 because xmalloc/xrealloc may not return.
102 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
103 now that we have proper integer overflow checking.
104 (record_overlay_string, overlay_strings): Catch overflows when
105 calculating size of overlay_str_buf.
106
107 * callproc.c (Fcall_process): Check for size overflow when
108 calculating size of args2.
109 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
110 Normally we prefer signed values, but sticking with ptrdiff_t would
111 require adding more-complicated checks.
112
113 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
114 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
115 Redo buffer-overflow calculations to avoid integer overflow.
116 Add a FIXME comment where memory seems to be over-allocated.
117
118 * character.c (Fstring): Check for size-calculation overflow.
119
120 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
121 unnecessary integer overflow. Check for size overflow.
122 (encode_coding_object): Don't update size until xmalloc succeeds.
123
124 * composite.c (get_composition_id): Check for overflow in glyph
125 length calculations.
126
127 Integer and memory overflow fixes for display code.
128 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
129 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
130 (scrolling_window): Check for overflow in size calculations.
131 (line_draw_cost, realloc_glyph_pool, add_row_entry):
132 Don't assume glyph table len fits in int.
133 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
134 (row_table_size): Now ptrdiff_t, not int.
135 (scrolling_window): Avoid overflow in size calculations.
136 Don't update size until allocation succeeds.
137 * fns.c (concat): Check for overflow in size calculations.
138 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
139 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
140 (NEXT_ALMOST_PRIME_LIMIT): New constant.
141
142 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
143 (get_doc_string): Check for size calculation overflow.
144 Don't update size until allocation succeeds.
145 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
146 EMACS_INT, where ptrdiff_t will do.
147 (Fsubstitute_command_keys): Check for string overflow.
148
149 * editfns.c (set_time_zone_rule): Don't assume environment length
150 fits in int.
151 (message_length): Now ptrdiff_t, not int.
152 (Fmessage_box): Don't update size until allocation succeeds.
153 Don't assume message length fits in int.
154 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
155
156 * emacs.c (main): Do not reallocate argv, since there is a null at
157 the end that can be overwritten, and this way there's no need to
158 worry about size-calculation overflow.
159 (sort_args): Check for size-calculation overflow.
160
161 * eval.c (init_eval_once, grow_specpdl): Don't update size until
162 alloc succeeds.
163 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
164
165 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
166 (x_set_scroll_bar_width, x_figure_window_size):
167 Check for integer overflow.
168 (x_set_alpha): Do not assume XINT fits in int.
169
170 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
171 This is for the members text_lines, text_cols, total_lines, total_cols,
172 where the system imposes an 'int' limit.
173
174 * fringe.c (Fdefine_fringe_bitmap):
175 Don't update size until alloc works.
176
177 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
178 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
179
180 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
181 Check for size-calculation overflow.
182 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
183 do, as we prefer signed integers.
184 (id_to_widget.max_size, id_to_widget.used)
185 (xg_store_widget_in_map, xg_remove_widget_from_map)
186 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
187 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
188 Use and return ptrdiff_t, not int.
189 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
190 * gtkutil.h: Change prototypes to match the above.
191
192 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
193 are duplicate now that they've been promoted to lisp.h.
194 (x_allocate_bitmap_record, x_alloc_image_color)
195 (make_image_cache, cache_image, xpm_load):
196 Don't update size until alloc is done.
197 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
198 (x_detect_edges):
199 Check for size calculation overflow.
200 (ct_colors_allocated_max): New constant.
201 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
202 overflow.
203
204 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
205 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
206 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
207 Use ptrdiff_t, not int, to count maps.
208 (read_char_minibuf_menu_prompt): Check for overflow in size
209 calculations. Don't update size until allocation succeeds. Redo
210 calculations to avoid overflow.
211 * keyboard.h: Change prototypes to match the above.
212
213 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
214 to count maps.
215 (current_minor_maps): Check for size calculation overflow.
216 * keymap.h: Change prototypes to match the above.
217
218 * lread.c (read1, init_obarray): Don't update size until alloc done.
219
220 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
221 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
222
223 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
224 Now ptrdiff_t, not int.
225 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
226 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
227
228 * process.c (Fnetwork_interface_list): Check for overflow
229 in size calculation.
230
231 * region-cache.c (move_cache_gap): Check for size calculation overflow.
232
233 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
234 overflow. Don't bother calling xmalloc when xrealloc will do.
235
236 * search.c (Freplace_match): Check for size calculation overflow.
237 (Fset_match_data): Don't assume list lengths fit in 'int'.
238
239 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
240 for command line length. Do not attempt to address one before the
241 beginning of an array, as that's not portable.
242
243 * term.c (max_frame_lines): Remove; unused.
244 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
245 not int.
246 (encode_terminal_code, calculate_costs): Check for size
247 calculation overflow.
248 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
249 table lengths and related sizes. Don't update size until alloc
250 done. Redo calculations to avoid overflow.
251 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
252
253 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
254 subtracting pointers.
255 (gobble_line): Check for overflow more carefully. Don't update size
256 until alloc done.
257
258 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
259 Don't update size until alloc done.
260 Redo size calculations to avoid overflow.
261 Check for size calculation overflow.
262 (main) [DEBUG]: Fix typo in invoking tparam1.
263
264 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
265 Use ptrdiff_t, not int, for sizes.
266 (store_mode_line_noprop_char): Don't update size until alloc done.
267
268 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
269 Use ptrdiff_t, not int, for sizes.
270 (Finternal_make_lisp_face, cache_face):
271 Check for size calculation overflow.
272 (cache_face): Treat size calculation overflows as if they were
273 memory exhaustion (the usual treatment), rather than aborting.
274
275 * xfns.c (x_encode_text, x_set_name_internal)
276 (Fx_change_window_property): Use ptrdiff_t, not int, to count
277 sizes, since they can exceed INT_MAX in size. Check for size
278 calculation overflow.
279
280 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
281 (xg_select): Check for size calculation overflow.
282 Don't update size until alloc done.
283
284 * xrdb.c (get_environ_db): Don't assume path length fits in int,
285 as sprintf is limited to int lengths.
286
287 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
288 (X_LONG_MIN): New macros.
289 Use them to make the following changes clearer.
290 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
291 This change doesn't affect the value now, but it may help remind
292 future maintainers not to raise the value too much later.
293 (SELECTION_QUANTUM): Remove, replacing with ...
294 (selection_quantum): ... new function, which avoids overflow.
295 All uses changed.
296 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
297 assumption that selection length fits in 'int'.
298 (x_reply_selection_request, x_handle_selection_request)
299 (x_get_window_property, receive_incremental_selection)
300 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
301 (lisp_data_to_selection_data, clean_local_selection_data):
302 Use ptrdiff_t, not int, to record length of selection.
303 (x_reply_selection_request, x_get_window_property)
304 (receive_incremental_selection, x_property_data_to_lisp):
305 Redo calculations to avoid overflow.
306 (x_reply_selection_request): When sending hint, ceiling it at
307 X_LONG_MAX rather than relying on wraparound overflow to send
308 something.
309 (x_get_window_property, receive_incremental_selection)
310 (lisp_data_to_selection_data, x_property_data_to_lisp):
311 Check for size-calculation overflow.
312 (x_get_window_property, receive_incremental_selection)
313 (lisp_data_to_selection_data, Fx_register_dnd_atom):
314 Don't store size until memory allocation succeeds.
315 (x_get_window_property): Plug memory leak on memory exhaustion.
316 Don't double-block input; malloc is safe here. Don't assume 2**34
317 - 4 fits in unsigned long. Add an xassert to check
318 XGetWindowProperty overflow. Be more careful about overflow
319 calculations, and distinguish size from memory overflow better.
320 (receive_incremental_selection): When tracing, don't assume
321 unsigned int is less than INT_MAX.
322 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
323 harmful) conversions of unsigned short to int.
324 (lisp_data_to_selection_data): Don't assume that integers
325 in the range -65535 through -1 fit in an X unsigned short.
326 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
327 result parameters unless successful. Rely on cons_to_unsigned
328 to report problems with elements; the old code wasn't right anyway.
329 (x_check_property_data): Check for int overflow; we cannot use
330 a wider type due to X limits.
331 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
332
333 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
334
335 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
336 (x_term_init): Check for size calculation overflow.
337 (x_color_cells): Don't store size until memory allocation succeeds.
338 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
339 Don't assume alloca size is less than MAX_ALLOCA.
340 (x_term_init): Don't assume length fits in int (sprintf is limited
341 to int size).
342
343 Use ptrdiff_t for composition IDs.
344 * character.c (lisp_string_width):
345 * composite.c (composition_table_size, n_compositions)
346 (get_composition_id, composition_gstring_from_id):
347 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
348 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
349 * window.c (Frecenter):
350 Use ptrdiff_t, not int, for composition IDs.
351 * composite.c (get_composition_id): Check for integer overflow.
352 * composite.h: Adjust prototypes to match the above changes.
353
354 Use ptrdiff_t for hash table indexes.
355 * category.c (hash_get_category_set):
356 * ccl.c (ccl_driver):
357 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
358 * coding.c (coding_system_charset_list, detect_coding_system):
359 * coding.h (struct coding_system.id):
360 * composite.c (get_composition_id, gstring_lookup_cache):
361 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
362 * image.c (xpm_get_color_table_h):
363 * lisp.h (hash_lookup, hash_put):
364 * minibuf.c (Ftest_completion):
365 Use ptrdiff_t for hash table indexes, not int (which is too
366 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
367 32-bit --with-wide-int hosts).
368
369 * charset.c (Fdefine_charset_internal): Check for integer overflow.
370 Add a FIXME comment about memory leaks.
371 (syms_of_charset): Don't assume xmalloc returns.
372
373 Don't assume that stated character widths fit in int.
374 * character.c (Fchar_width, c_string_width, lisp_string_width):
375 * character.h (CHAR_WIDTH):
376 * indent.c (MULTIBYTE_BYTES_WIDTH):
377 Use sanitize_char_width to avoid undefined and/or bad behavior
378 with outlandish widths.
379 * character.h (sanitize_tab_width): Renamed from sanitize_width,
380 now that we have two such functions. All uses changed.
381 (sanitize_char_width): New inline function.
382
383 Don't assume that tab-width fits in int.
384 * character.h (sanitize_width): New inline function.
385 (SANE_TAB_WIDTH): New macro.
386 (ASCII_CHAR_WIDTH): Use it.
387 * indent.c (sane_tab_width): Remove. All uses replaced by
388 SANE_TAB_WIDTH (current_buffer).
389 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
390
391 * fileio.c: Integer overflow issues with file modes.
392 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
393
394 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
395 Remove unreachable code.
396 (read_hex, load_charset_map_from_file): Check for integer overflow.
397
398 * xterm.c: don't go over XClientMessageEvent limit
399 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
400 (x_send_scroll_bar_event): Likewise. Check that the size does not
401 exceed limits imposed by XClientMessageEvent, as well as the usual
402 ptrdiff_t and size_t limits.
403
404 * keyboard.c: Overflow, signedness and related fixes.
405 (make_lispy_movement): Use same integer type in forward decl
406 that is used in the definition.
407 (read_key_sequence, keyremap_step):
408 Change bufsize argument back to int, undoing my 2011-03-30 change.
409 We prefer signed types, and int is wide enough here.
410 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
411 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
412 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
413 length, not size_t. Use ptrdiff_t for index, not int.
414 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
415 possibility of integer overflow.
416
417 Overflow, signedness and related fixes for images.
418
419 * dispextern.h (struct it.stack[0].u.image.image_id)
420 (struct_it.image_id, struct image.id, struct image_cache.size)
421 (struct image_cache.used, struct image_cache.ref_count):
422 * gtkutil.c (update_frame_tool_bar):
423 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
424 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
425 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
426 * nsmenu.m (update_frame_tool_bar):
427 * xdisp.c (calc_pixel_width_or_height):
428 * xfns.c (image_cache_refcount):
429 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
430 on typical 64-bit hosts.
431
432 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
433 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
434 Omit unnecessary casts to int.
435 (parse_image_spec): Check that integers fall into 'int' range
436 when the callers expect that.
437 (image_ascent): Redo ascent calculation to avoid int overflow.
438 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
439 (lookup_image): Remove unnecessary tests.
440 (xbm_image_p): Locals are now of int, not EMACS_INT,
441 since parse_image_check makes sure they fit into int.
442 (png_load, gif_load, svg_load_image):
443 Prefer int to unsigned where either will do.
444 (tiff_handler): New function, combining the cores of the
445 old tiff_error_handler and tiff_warning_handler. This
446 function is rewritten to use vsnprintf and thereby avoid
447 stack buffer overflows. It uses only the features of vsnprintf
448 that are common to both POSIX and native Microsoft.
449 (tiff_error_handler, tiff_warning_handler): Use it.
450 (tiff_load, gif_load, imagemagick_load_image):
451 Don't assume :index value fits in 'int'.
452 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
453 (imagemagick_load_image): Check that crop parameters fit into
454 the integer types that MagickCropImage accepts. Don't assume
455 Vimagemagick_render_type has a nonnegative value. Don't assume
456 size_t fits in 'long'.
457 (gs_load): Use printmax_t to print the widest integers possible.
458 Check for integer overflow when computing image height and width.
459
460 2011-08-26 Eli Zaretskii <eliz@gnu.org>
461
462 * xdisp.c (redisplay_window): Don't force window start if point
463 will be invisible in the resulting window. (Bug#9324)
464
465 2011-08-25 Eli Zaretskii <eliz@gnu.org>
466
467 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
468 the display spec is of the form `(space ...)'.
469 (handle_display_spec): Return the value returned by
470 handle_single_display_spec, not just 1 or zero.
471 (handle_single_display_spec): If the display spec is of the form
472 `(space ...)', and specifies display in the text area, return 2
473 rather than 1.
474 (try_cursor_movement): Check for the need to scroll more
475 accurately, and prefer exact match for point under bidi. Don't
476 advance `row' beyond the last row of the window.
477
478 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
479 into disp_prop; all users changed.
480
481 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
482 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
483 for the text covered by the display property.
484
485 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
486
487 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
488 Change return value to nil.
489 (Frecord_buffer): Delete unused function.
490
491 2011-08-24 Eli Zaretskii <eliz@gnu.org>
492
493 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
494 buffers, return left-to-right.
495 (set_cursor_from_row): Consider candidate row a win if its glyph
496 represents a newline and point is on that newline. Fixes cursor
497 positioning on the newline at EOL of R2L text within L2R
498 paragraph, and vice versa.
499 (try_cursor_movement): Check continued rows, in addition to
500 continuation rows. Fixes unwarranted scroll when point enters a
501 continued line of R2L text within an L2R paragraph, or vice versa.
502 (cursor_row_p): Consider the case of point being equal to
503 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
504 from the end of a short line to the beginning of a continued line
505 of R2L text within L2R paragraph.
506 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
507 composed characters.
508
509 * bidi.c (bidi_check_type): Use xassert.
510 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
511 members.
512
513 2011-08-23 Eli Zaretskii <eliz@gnu.org>
514
515 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
516 a character.
517
518 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
519
520 * nsfont.m (ns_otf_to_script): Fix typo.
521
522 2011-08-22 Kenichi Handa <handa@m17n.org>
523
524 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
525 extra slot even if the purpose is char-code-property-table.
526
527 2011-08-23 Eli Zaretskii <eliz@gnu.org>
528
529 * xdisp.c (redisplay_window): When computing centering_position,
530 account for the height of the header line. (Bug#8874)
531
532 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
533 instead of CHAR_TO_BYTE. Fixes a crash when a completion
534 candidate is selected by the mouse, and that candidate has a
535 composed character under the mouse.
536
537 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
538 coordinates reported by pos-visible-in-window-p for a composed
539 character in column zero.
540
541 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
542
543 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
544
545 2011-08-22 Eli Zaretskii <eliz@gnu.org>
546
547 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
548 consider it a hit if to_charpos is anywhere in the range of the
549 composed buffer positions.
550
551 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
552
553 * image.c (gif_load): Don't assume that each subimage has the same
554 dimensions as the base image. Handle disposal method that is
555 "undefined" by the gif spec (Bug#9335).
556
557 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
558
559 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
560 (Fcondition_case): Document `debug' symbol in error handler.
561
562 2011-08-19 Eli Zaretskii <eliz@gnu.org>
563
564 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
565 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
566 from an Org mode buffer to a Speedbar frame.
567
568 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
569 a composition, take its buffer position from IT->cmp_it.charpos.
570 Fixes cursor positioning at the beginning of a line that begins
571 with a composed character.
572
573 2011-08-18 Eli Zaretskii <eliz@gnu.org>
574
575 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
576 character bidirectional type, use STRONG_L instead. Fixes crashes
577 in a buffer produced by `describe-categories'.
578
579 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
580 members before the level stack, so they would be saved and
581 restored when copying iterator state. Fixes incorrect reordering
582 around TABs covered by display properties.
583
584 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
585
586 * process.c (Fnetwork_interface_list): Correctly determine buffer
587 size.
588
589 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
590
591 * eval.c (internal_condition_case, internal_condition_case_1)
592 (internal_condition_case_2, internal_condition_case_n):
593 Remove unnecessary aborts (Bug#9081).
594
595 2011-08-17 Eli Zaretskii <eliz@gnu.org>
596
597 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
598 has no `load' handler, try opening the file locally. (Bug#9311)
599
600 2011-08-16 Ken Brown <kbrown@cornell.edu>
601
602 * gmalloc.c: Expand comment.
603
604 2011-08-16 Eli Zaretskii <eliz@gnu.org>
605
606 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
607 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
608
609 2011-08-16 Ken Brown <kbrown@cornell.edu>
610
611 Fix memory allocation problems in Cygwin build (Bug#9273).
612
613 * unexcw.c ( __malloc_initialized): Declare external variable.
614 (fixup_executable): Force the dumped emacs to reinitialize malloc.
615
616 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
617 New variables.
618 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
619 dumped emacs.
620 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
621 in the static heap.
622 [CYGWIN] (special_realloc): New function.
623 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
624 requests to realloc storage in the static heap.
625
626 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
627
628 * bidi.c (bidi_initialize): Remove unused local.
629
630 2011-08-15 Eli Zaretskii <eliz@gnu.org>
631
632 * biditype.h: File removed.
633
634 * bidimirror.h: File removed.
635
636 * deps.mk (bidi.o): Remove biditype.h and
637 bidimirror.h.
638
639 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
640 bidimirror.h.
641
642 * dispextern.h: Fix a typo in the comment to bidi_type_t.
643
644 * chartab.c: Improve commentary for the uniprop_table API.
645
646 * bidi.c (bidi_paragraph_init): Support zero value of
647 bidi_ignore_explicit_marks_for_paragraph_level.
648 (bidi_initialize): Use uniprop_table instead of including
649 biditype.h and bidimirror.h.
650
651 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
652 coordinates of the iterator when restoring from ppos_it.
653 (Bug#9296)
654
655 2011-08-14 Kenichi Handa <handa@m17n.org>
656
657 * process.c (create_process): Call setup_process_coding_systems
658 after the pid of the process is set to -1 (Bug#8162).
659
660 2011-08-14 Eli Zaretskii <eliz@gnu.org>
661
662 * xdisp.c (move_it_in_display_line_to): Don't invoke
663 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
664 ppos_it. Fixes vertical cursor motion when line beginning is
665 covered by an image. (Bug#9296)
666
667 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
668
669 * nsterm.h (ns_run_ascript): Declare.
670 (NSAPP_DATA2_RUNASSCRIPT): Define.
671
672 * nsfns.m (as_script, as_result, as_status): New static variables.
673 (ns_run_ascript): New function.
674 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
675 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
676 the event loop. Get status from as_status (Bug#7276).
677
678 * nsterm.m (sendEvent): If event is NSApplicationDefined and
679 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
680 the event loop (Bug#7276).
681
682 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
683
684 * gnutls.c (QCgnutls_bootprop_priority)
685 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
686 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
687 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
688 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
689 (QCgnutls_bootprop_verify_hostname_error)
690 (QCgnutls_bootprop_callbacks_verify): Rename from
691 Qgnutls_bootprop_..., all uses changed.
692
693 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
694 uses changed.
695
696 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
697
698 * xfaces.c (Qframe_set_background_mode): Now static.
699 * dispextern.h (Qframe_set_background_mode): Remove decl.
700
701 * process.c (Fnetwork_interface_info): Declare local only if needed.
702
703 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
704
705 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
706 (Fnetwork_interface_list): Allocate in increments of bytes instead
707 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
708 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
709 sockaddr.
710 (struct ifflag_def): notrailers is smart on OSX.
711 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
712 Get hardware address with getifaddrs if available.
713
714 2011-08-12 Eli Zaretskii <eliz@gnu.org>
715
716 * xdisp.c (iterate_out_of_display_property): xassert that
717 IT->position is set to within IT->object's boundaries. Break from
718 the loop as soon as EOB is reached; avoids infloops in redisplay
719 when IT->position is set up wrongly due to some bug.
720 Set IT->current to match the bidi iterator unconditionally.
721 (push_display_prop): Allow GET_FROM_STRING as IT->method on
722 entry. Force push_it to save on the stack the current
723 buffer/string position, to be restored by pop_it. Fix flags in
724 the iterator structure wrt the object coming from a display
725 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
726 properties. (Bug#9284)
727
728 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
729
730 * fontset.c (fontset_get_font_group): Add proper type checks.
731 (Bug#9172)
732
733 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
734
735 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
736 and LC_VERSION_MIN_MACOSX.
737 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
738 (dump_it) [LC_FUNCTION_STARTS]: Use it.
739
740 2011-08-08 Eli Zaretskii <eliz@gnu.org>
741
742 * xdisp.c (forward_to_next_line_start): Allow to use the
743 no-display-properties-and-no-overlays under bidi display.
744 Set disp_pos in the bidi iterator to avoid searches for display
745 properties and overlays.
746
747 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
748
749 * editfns.c (Fset_time_zone_rule): Document relationship with the
750 setenv function.
751
752 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
753 the font entity extracted from the cache (Bug#8109).
754
755 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
756
757 * composite.c (autocmp_chars): Don't reset point. That is done by
758 restore_point_unwind (Bug#5984).
759
760 2011-08-07 Juri Linkov <juri@jurta.org>
761
762 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
763 to show the arg `TIME' instead of `TIMEVAL'.
764
765 2011-08-06 Eli Zaretskii <eliz@gnu.org>
766
767 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
768 display property strides EOL and includes a newline, as in
769 longlines-mode. (Bug#9254)
770 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
771 word-wrap under bidirectional display. (Bug#9224)
772
773 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
774 is non-zero, even if the data buffer is NULL. Fixes a crash in
775 vertical-motion with longlines-mode. (Bug#9254)
776
777 2011-08-05 Eli Zaretskii <eliz@gnu.org>
778
779 * bidi.c <bidi_cache_total_alloc>: Now static.
780 (bidi_initialize): Initialize bidi_cache_total_alloc.
781
782 * xdisp.c (display_line): Release buffer allocated for shelved bidi
783 cache. (Bug#9221)
784
785 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
786 amount allocated this far in `bidi_cache_total_alloc'.
787 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
788 non-zero, only free the data buffer without restoring the cache
789 contents. All callers changed.
790
791 * dispextern.h (bidi_unshelve_cache): Update prototype.
792
793 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
794 (move_it_in_display_line, move_it_to)
795 (move_it_vertically_backward, move_it_by_lines): Replace the call
796 to xfree to an equivalent call to bidi_unshelve_cache.
797 (move_it_in_display_line_to): Fix logic of returning
798 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
799
800 2011-08-05 Eli Zaretskii <eliz@gnu.org>
801
802 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
803 came from a string character with a `cursor' property. (Bug#9229)
804
805 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
806
807 * Makefile.in (LIB_PTHREAD): New variable.
808 (LIBES): Add LIB_PTHREAD (Bug#9216).
809
810 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
811 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
812
813 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
814
815 * regex.c (re_iswctype): Remove some redundant boolean
816 conversions.
817
818 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
819
820 * xterm.c (x_find_topmost_parent): New function.
821 (x_set_frame_alpha): Find topmost parent window with
822 x_find_topmost_parent and set the property there also (bug#9181).
823 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
824
825 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
826
827 * callproc.c (Fcall_process): Avoid vfork clobbering
828 the local vars buffer, coding_systems, current_dir.
829
830 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
831
832 * keymap.c (Fmake_composed_keymap): Move to subr.el.
833
834 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
835
836 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
837 so that it is not optimized away.
838
839 * xdisp.c (compute_display_string_pos): Remove unused local.
840
841 2011-08-02 Eli Zaretskii <eliz@gnu.org>
842
843 Fix slow cursor motion and scrolling in large buffers with
844 selective display, like Org Mode buffers. (Bug#9218)
845
846 * dispextern.h (struct bidi_it): New member disp_prop_p.
847
848 * xdisp.c: Remove one-slot cache of display string positions.
849 (compute_display_string_pos): Accept an additional argument
850 DISP_PROP_P; callers changed. Scan at most 5K characters forward
851 for a display string or property. If found, set DISP_PROP_P
852 non-zero.
853
854 * bidi.c (bidi_fetch_char): Accept an additional argument
855 DISP_PROP_P, and pass it to compute_display_string_pos.
856 Only handle text covered by a display string if DISP_PROP_P is returned
857 non-zero. All callers of bidi_fetch_char changed.
858
859 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
860
861 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
862
863 2010-12-03 Don March <don@ohspite.net>
864
865 * keymap.c (Fdefine_key): Fix non-prefix key error message when
866 last character M-[char] is translated to ESC [char] (bug#7541).
867
868 2011-08-02 Kenichi Handa <handa@m17n.org>
869
870 * lisp.h (uniprop_table): Extern it.
871
872 * chartab.c (uniprop_table): Make it non-static.
873
874 2011-08-01 Eli Zaretskii <eliz@gnu.org>
875
876 * xdisp.c (forward_to_next_line_start): Accept additional argument
877 BIDI_IT_PREV, and store into it the state of the bidi iterator had
878 on the newline.
879 (reseat_at_next_visible_line_start): Use the bidi iterator state
880 returned by forward_to_next_line_start to restore the state of
881 it->bidi_it after backing up to previous newline. (Bug#9212)
882
883 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
884
885 * regex.c (re_comp): Protoize.
886 (re_exec): Fix return type.
887 (regexec): Fix type of `ret'. (Bug#9203)
888
889 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
890
891 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
892 This is needed if max-image-size is a floating-point number.
893
894 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
895
896 * print.c (print_object): Print empty symbol as ##.
897
898 * lread.c (read1): Read ## as empty symbol.
899
900 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
901
902 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
903 setting frame foreground color (Bug#9175).
904 (x_set_background_color): Likewise.
905
906 * nsmenu.m (-setText): Size tooltip dimensions precisely to
907 contents (Bug#9176).
908 (EmacsTooltip -init): Remove bezels and add shadows to
909 tooltip windows.
910
911 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
912 or scroll bar (Bug#8470).
913
914 * nsfont.m (nsfont_open): Remove assignment to voffset and
915 unnecessary vars hshink, expand, hd, full_height, min_height.
916 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
917
918 * nsterm.h (nsfont_info): Remove voffset field.
919
920 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
921
922 Implement strike-through and overline on NextStep (Bug#8863).
923
924 * nsfont.m (nsfont_open): Use underline position provided by font,
925 instead of hard-coded value of 2.
926 (nsfont_draw): Call ns_draw_text_decoration instead.
927
928 * nsterm.h: Add declaration for ns_draw_text_decoration.
929
930 * nsterm.m (ns_draw_text_decoration): New function for drawing
931 underline, overline, and strike-through.
932 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
933 ns_draw_text_decoration. Change treatment of cursor drawing to
934 accomodate underlining, etc.
935
936 2011-07-28 Eli Zaretskii <eliz@gnu.org>
937
938 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
939 default.
940
941 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
942
943 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
944 Without this fix, if a signal arrives just after memory fills up,
945 'malloc' might be invoked reentrantly.
946
947 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
948 In other words, assume that every image size is allowed, on non-X
949 hosts. This assumption is probably wrong, but it lets Emacs compile.
950
951 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
952
953 * regex.c (re_iswctype): Convert return values to boolean.
954
955 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
956
957 * xdisp.c (compute_display_string_pos): Don't use cached display
958 string position if the buffer had its restriction changed.
959 (Bug#9184)
960
961 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
962
963 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
964
965 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
966
967 Integer signedness and overflow and related fixes. (Bug#9079)
968
969 * bidi.c: Integer size and overflow fixes.
970 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
971 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
972 (bidi_cache_find_level_change, bidi_cache_ensure_space)
973 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
974 (bidi_find_other_level_edge):
975 Use ptrdiff_t instead of EMACS_INT where either will do.
976 This works better on 32-bit hosts configured --with-wide-int.
977 (bidi_cache_ensure_space): Check for size-calculation overflow.
978 Use % rather than repeated addition, for better worst-case speed.
979 Don't set bidi_cache_size until after xrealloc returns, because it
980 might not return.
981 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
982 (bidi_cache_ensure_space): Also check that the bidi cache size
983 does not exceed that of the largest Lisp string or buffer. See Eli
984 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
985
986 * alloc.c (__malloc_size_t): Remove.
987 All uses replaced by size_t. See Andreas Schwab's note
988 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
989
990 * image.c: Improve checking for integer overflow.
991 (check_image_size): Assume that f is nonnull, since
992 it is always nonnull in practice. This is one less thing to
993 worry about when checking for integer overflow later.
994 (x_check_image_size): New function, which checks for integer
995 overflow issues inside X.
996 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
997 This removes the need for a memory_full check.
998 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
999 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1000 (xbm_read_bitmap_data): Change locals back to 'int', since
1001 their values must fit in 'int'.
1002 (xpm_load_image, png_load, tiff_load):
1003 Invoke x_create_x_image_and_pixmap earlier,
1004 to avoid much needless work if the image is too large.
1005 (tiff_load): Treat overly large images as if
1006 x_create_x_image_and_pixmap failed, not as malloc failures.
1007 (gs_load): Use x_check_image_size.
1008
1009 * gtkutil.c: Omit integer casts.
1010 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1011 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1012
1013 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1014
1015 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1016 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1017 would wrongly return t on a 64-bit host.
1018
1019 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1020 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1021 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1022 and therefore cause GCC to emit a bogus diagnostic in some cases.
1023
1024 * image.c: Integer signedness and overflow and related fixes.
1025 This is not an exhaustive set of fixes, but it's time to
1026 record what I've got.
1027 (lookup_pixel_color, check_image_size): Remove redundant decls.
1028 (check_image_size): Don't assume that arbitrary EMACS_INT values
1029 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1030 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1031 (tiff_load, imagemagick_load_image):
1032 Check for overflow in size calculations.
1033 (x_create_x_image_and_pixmap): Remove unnecessary test for
1034 xmalloc returning NULL; that can't happen.
1035 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1036 (xpm_color_bucket): Use better integer hashing function.
1037 (xpm_cache_color): Don't possibly over-allocate memory.
1038 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1039 (gif_memory_source):
1040 Use ptrdiff_t, not int or size_t, to record sizes.
1041 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1042 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1043 either works, as we prefer signed integers.
1044 (tiff_read_from_memory, tiff_write_from_memory):
1045 Return tsize_t, not size_t, since that's what the TIFF API wants.
1046 (tiff_read_from_memory): Don't fail simply because the read would
1047 go past EOF; instead, return a short read.
1048 (tiff_load): Omit no-longer-needed casts.
1049 (Fimagemagick_types): Don't assume size fits into 'int'.
1050
1051 Improve hashing quality when configured --with-wide-int.
1052 * fns.c (hash_string): New function, taken from sxhash_string.
1053 Do not discard information about ASCII character case; this
1054 discarding is no longer needed.
1055 (sxhash-string): Use it. Change sig to match it. Caller changed.
1056 * lisp.h: Declare it.
1057 * lread.c (hash_string): Remove, since we now use fns.c's version.
1058 The fns.c version returns a wider integer if --with-wide-int is
1059 specified, so this should help the quality of the hashing a bit.
1060
1061 * emacs.c: Integer overflow minor fix.
1062 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1063 Define only if GNU_LINUX.
1064 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1065
1066 * dispnew.c: Integer signedness and overflow fixes.
1067 Remove unnecessary forward decls, that were a maintenance hassle.
1068 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1069 All uses changed.
1070 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1071 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1072 (prepare_desired_row, line_draw_cost):
1073 Use int, not unsigned, where either works.
1074 (save_current_matrix, restore_current_matrix):
1075 Use ptrdiff_t, not size_t, where either works.
1076 (init_display): Check for overflow more accurately, and without
1077 relying on undefined behavior.
1078
1079 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1080 Remove, replacing with the new symbols in lisp.h. All uses changed.
1081 * fileio.c (make_temp_name):
1082 * filelock.c (lock_file_1, lock_file):
1083 * xdisp.c (message_dolog):
1084 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1085 Use pMd etc. instead.
1086 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1087 replacing the pWIDE etc. symbols removed from editfns.c.
1088
1089 * keyboard.h (num_input_events): Now uintmax_t.
1090 This is (very slightly) less likely to mess up due to wraparound.
1091 All uses changed.
1092
1093 * buffer.c: Integer signedness fixes.
1094 (alloc_buffer_text, enlarge_buffer_text):
1095 Use ptrdiff_t rather than size_t when either will do, as we prefer
1096 signed integers.
1097
1098 * alloc.c: Integer signedness and overflow fixes.
1099 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1100 (__malloc_size_t): Default to size_t, not to int.
1101 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1102 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1103 Prefer ptrdiff_t to size_t when either would do, as we prefer
1104 signed integers.
1105 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1106 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1107 Now const. Initialize with values that are in range even if char
1108 is signed.
1109 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1110 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1111 These functions do the right thing with sizes > 2**32.
1112 (check_depth): Now ptrdiff_t, not int.
1113 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1114 Adjust to new way of storing sizes. Check for size overflow bugs
1115 in rest of code.
1116 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1117 slightly wrong anyway, as it missed one instance of
1118 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1119 (refill_memory_reserve): Omit needless cast to size_t.
1120 (mark_object_loop_halt): Mark as externally visible.
1121
1122 * xselect.c: Integer signedness and overflow fixes.
1123 (Fx_register_dnd_atom, x_handle_dnd_message):
1124 Use ptrdiff_t, not size_t, since we prefer signed.
1125 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1126 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1127 x_dnd_atoms_size and x_dnd_atoms_length.
1128
1129 * doprnt.c: Prefer signed to unsigned when either works.
1130 * eval.c (verror):
1131 * doprnt.c (doprnt):
1132 * lisp.h (doprnt):
1133 * xdisp.c (vmessage):
1134 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1135 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1136 prefer signed arithmetic to avoid comparison confusion.
1137 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1138 but is a bit tricky.
1139
1140 Assume freestanding C89 headers, string.h, stdlib.h.
1141 * data.c, doprnt.c, floatfns.c, print.c:
1142 Include float.h unconditionally.
1143 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1144 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1145 * regex.c: Likewise for stddef.h, string.h.
1146 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1147 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1148 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1149 (STDC_HEADERS): Remove obsolete defines.
1150 * sysdep.c: Include limits.h unconditionally.
1151
1152 Assume support for memcmp, memcpy, memmove, memset.
1153 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1154 * regex.c (memcmp, memcpy):
1155 Remove; we assume C89 now.
1156
1157 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1158 (__malloc_safe_bcopy): Remove; no longer needed.
1159
1160 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1161 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1162 well either way, and we prefer signed to unsigned.
1163
1164 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1165
1166 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1167 closes the connection while we're reading (bug#9182).
1168
1169 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1170
1171 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1172 are specified (Bug#9168).
1173
1174 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1175
1176 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1177 Found by GCC static checking and --with-wide-int on a 32-bit host.
1178
1179 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1180
1181 * xdisp.c (compute_display_string_pos): Fix logic of caching
1182 previous display string position. Initialize cached_prev_pos to
1183 -1. Fixes slow-down at the beginning of a buffer.
1184
1185 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1186
1187 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1188 for attrs[LFACE_FONTSET_INDEX].
1189
1190 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1191
1192 * xml.c (parse_region): Remove unused local
1193 that was recently introduced.
1194
1195 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1196
1197 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1198 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1199
1200 * xdisp.c (move_it_in_display_line_to): Record the best matching
1201 position for TO_CHARPOS while scanning the line, and restore it on
1202 exit if none of the characters scanned was an exact match.
1203 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1204 when exact match is impossible due to invisible text, and the
1205 lines are truncated.
1206
1207 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1208
1209 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1210 for OSX >= 10.7.
1211
1212 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1213
1214 Fix a significant slow-down of cursor motion with C-n, C-p,
1215 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1216 auto-repeat under bidi redisplay in fontified buffers.
1217 * xdisp.c (compute_stop_pos_backwards): New function.
1218 (next_element_from_buffer): Call compute_stop_pos_backwards to
1219 find a suitable prev_stop when we find ourselves before
1220 base_level_stop.
1221 (reseat): Don't look for prev_stop, as that could mean a very long
1222 run.
1223 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1224 <cached_disp_overlay_modiff>: Cache for last found display string
1225 position.
1226 (compute_display_string_pos): Return the cached position if asked
1227 about the same buffer in the same area of character positions, and
1228 the buffer wasn't changed since the time the display string
1229 position was cached.
1230
1231 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1232
1233 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1234 is an integer, which is important for empty lines. (Bug#9149)
1235
1236 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1237
1238 * frame.c (Fmodify_frame_parameters): In tty case, update the
1239 default face if necessary (Bug#4238).
1240
1241 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1242
1243 * editfns.c (Fstring_to_char): No need to explain what a character
1244 is in the docstring (Bug#6576).
1245
1246 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1247
1248 * xml.c (parse_region): Make sure we always return a tree.
1249
1250 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1251
1252 * xml.c (parse_region): If a document contains only comments,
1253 return that, too.
1254
1255 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1256
1257 * xml.c (make_dom): Return comments, too.
1258
1259 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1260
1261 Port to OpenBSD.
1262 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1263 and the surrounding thread.
1264 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1265 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1266 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1267 timer goes off.
1268 * s/openbsd.h (BROKEN_SIGIO): Define.
1269 * unexelf.c (unexec) [__OpenBSD__]:
1270 Don't update the .mdebug section of the Alpha COFF symbol table.
1271
1272 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1273
1274 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1275 (bug#8460).
1276
1277 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1278
1279 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1280 This fixes some race conditions on the permissions of any newly
1281 created file.
1282
1283 * alloc.c (valid_pointer_p): Use pipe, not open.
1284 This fixes some permissions issues when debugging.
1285
1286 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1287 If fchown fails to set both uid and gid, try to set just gid,
1288 as that is sometimes allowed. Adjust the file's mode to eliminate
1289 setuid or setgid bits that are inappropriate if fchown fails.
1290
1291 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1292
1293 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1294 to compare Lisp_Objects.
1295 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1296 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1297 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1298
1299 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1300
1301 * lread.c (read_integer): Unread even EOF character.
1302 (read1): Likewise. Properly record start position of symbol.
1303
1304 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1305 symbol character follows.
1306
1307 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1308
1309 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1310 This works around a problem with the previous change to Fcopy_file.
1311 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1312 and without this change, GCC might complain about discarding
1313 fchown's return value.
1314
1315 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1316
1317 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1318
1319 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1320
1321 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1322
1323 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1324
1325 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1326 it's used from the C level.
1327
1328 * process.c: Use the same condition for POLL_FOR_INPUT in both
1329 keyboard.c and process.c (bug#1858).
1330
1331 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1332
1333 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1334 (Fgnutls_boot): Use it.
1335
1336 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1337
1338 * doc.c (Fsubstitute_command_keys): Revert last change.
1339
1340 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1341
1342 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1343 quotes the next character, and doesn't affect other longer
1344 sequences (bug#8935).
1345
1346 * lread.c (syms_of_lread): Clarify that is isn't only
1347 `eval-buffer' and `eval-defun' that's affected by
1348 `lexical-binding' (bug#8460).
1349
1350 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1351
1352 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1353 bidi redisplay when a line includes both an image and is
1354 truncated.
1355
1356 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1357
1358 Fix minor problems found by static checking.
1359 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1360 (elsz): Now a signed constant, not a size_t var. We prefer signed
1361 types to unsigned, to avoid integer comparison confusion. Without
1362 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1363 "cannot optimize loop, the loop counter may overflow", a symptom
1364 of the confusion.
1365 * indent.c (Fvertical_motion): Mark locals as initialized.
1366 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1367
1368 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1369
1370 * search.c (Fre_search_backward): Mention `case-fold-search' in
1371 all the re_search_* functions (bug#8138).
1372
1373 * keyboard.c (Fopen_dribble_file): Document when the file is
1374 closed (bug#8056).
1375
1376 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1377
1378 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1379 bidi_cache_idx.
1380
1381 Support bidi reordering of display and overlay strings.
1382 * xdisp.c (compute_display_string_pos)
1383 (compute_display_string_end): Accept additional argument STRING.
1384 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1385 (reseat_to_string): Initialize bidi_it->string.s and
1386 bidi_it->string.schars.
1387 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1388 NULL (avoids a crash in bidi_paragraph_init).
1389 Initialize itb.string.lstring.
1390 (init_iterator): Call bidi_init_it only of a valid
1391 buffer position was specified. Initialize paragraph_embedding to
1392 L2R.
1393 (reseat_to_string): Initialize the bidi iterator.
1394 (display_string): If we need to ignore text properties of
1395 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1396 original value of -1 will not work with bidi.)
1397 (compute_display_string_pos): First arg is now struct
1398 `text_pos *'; all callers changed. Support display properties on
1399 Lisp strings.
1400 (compute_display_string_end): Support display properties on Lisp
1401 strings.
1402 (init_iterator, reseat_1, reseat_to_string): Initialize the
1403 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1404 when iterating on a string not from display properties).
1405 (compute_display_string_pos, compute_display_string_end):
1406 Fix calculation of the object to scan. Fixes an error when using
1407 arrow keys.
1408 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1409 base_level_stop; instead, set base_level_stop to BEGV.
1410 Fixes crashes in vertical-motion.
1411 (next_element_from_buffer): Improve commentary for when
1412 the iterator is before prev_stop.
1413 (init_iterator): Initialize bidi_p from the default value of
1414 bidi-display-reordering, not from buffer-local value. Use the
1415 buffer-local value only if initializing for buffer iteration.
1416 (handle_invisible_prop): Support invisible properties on strings
1417 that are being bidi-reordered.
1418 (set_iterator_to_next): Support bidi reordering of C strings and
1419 Lisp strings.
1420 (next_element_from_string): Support bidi reordering of Lisp
1421 strings.
1422 (handle_stop_backwards): Support Lisp strings as well.
1423 (display_string): Support display of R2L glyph rows.
1424 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1425 (init_iterator): Don't initialize it->bidi_p for strings
1426 here.
1427 (reseat_to_string): Initialize it->bidi_p for strings here.
1428 (next_element_from_string, next_element_from_c_string)
1429 (next_element_from_buffer): Add xassert's for correspondence
1430 between IT's object being iterated and it->bidi_it.string
1431 structure.
1432 (face_before_or_after_it_pos): Support bidi iteration.
1433 (next_element_from_c_string): Handle the case of the first string
1434 character that is not the first one in the visual order.
1435 (get_visually_first_element): New function, refactored from common
1436 parts of next_element_from_buffer, next_element_from_string, and
1437 next_element_from_c_string.
1438 (tool_bar_lines_needed, redisplay_tool_bar)
1439 (display_menu_bar): Force left-to-right direction. Add a FIXME
1440 comment for making that be controlled by a user option.
1441 (push_it, pop_it): Save and restore the state of the
1442 bidi iterator. Save and restore the bidi_p flag.
1443 (pop_it): Iterate out of display property for string iteration as
1444 well.
1445 (iterate_out_of_display_property): Support iteration over strings.
1446 (handle_single_display_spec): Set up it->bidi_it for iteration
1447 over a display string, and call bidi_init_it.
1448 (handle_single_display_spec, next_overlay_string)
1449 (get_overlay_strings_1, push_display_prop): Set up the bidi
1450 iterator for displaying display or overlay strings.
1451 (forward_to_next_line_start): Don't use the shortcut if
1452 bidi-iterating.
1453 (back_to_previous_visible_line_start): If handle_display_prop
1454 pushed the iterator stack, restore the internal state of the bidi
1455 iterator by calling bidi_pop_it same number of times.
1456 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1457 and we are bidi-iterating, don't decrement the iterator position;
1458 instead, set the first_elt flag in the bidi iterator, to produce
1459 the same effect.
1460 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1461 (push_display_prop): xassert that we are iterating a buffer.
1462 (push_it, pop_it): Save and restore paragraph_embedding member.
1463 (handle_single_display_spec, next_overlay_string)
1464 (get_overlay_strings_1, reseat_1, reseat_to_string)
1465 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1466 correctly. Don't assume unibyte strings are not bidi-reordered.
1467 (compute_display_string_pos)
1468 (compute_display_string_end): Fix handling the case of C string.
1469 (push_it, pop_it): Save and restore from_disp_prop_p.
1470 (handle_single_display_spec, push_display_prop): Set the
1471 from_disp_prop_p flag.
1472 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1473 (pop_it): Call iterate_out_of_display_property only if we are
1474 popping after iteration over a string that came from a display
1475 property. Fix a typo in popping stretch info. Add an assertion
1476 for verifying that the iterator position is in sync with the bidi
1477 iterator.
1478 (handle_single_display_spec, get_overlay_strings_1)
1479 (push_display_prop): Fix initialization of paragraph direction for
1480 string when that of the parent object is not yet determined.
1481 (reseat_1): Call bidi_init_it to resync the bidi
1482 iterator with IT's position. (Bug#7616)
1483 (find_row_edges): If ROW->start.pos gives position
1484 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1485 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1486 Reset the from_disp_prop_p flag.
1487 (SAVE_IT, RESTORE_IT): New macros.
1488 (pos_visible_p, face_before_or_after_it_pos)
1489 (back_to_previous_visible_line_start)
1490 (move_it_in_display_line_to, move_it_in_display_line)
1491 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1492 (try_scrolling, redisplay_window, display_line): Use them when
1493 saving a temporary copy of the iterator and restoring it back.
1494 (back_to_previous_visible_line_start, reseat_1)
1495 (init_iterator): Empty the bidi cache "stack".
1496 (move_it_in_display_line_to): If iterator ended up at
1497 EOL, but we never saw any buffer positions smaller than
1498 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1499 motion in bidi-reordered lines.
1500 (move_it_in_display_line_to): Record prev_method and prev_pos
1501 immediately before the call to set_iterator_to_next. Fixes cursor
1502 motion in bidi-reordered lines with stretch glyphs and strings
1503 displayed in margins. (Bug#8133) (Bug#8867)
1504 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1505 TO_CHARPOS.
1506 (pos_visible_p): Support positions in bidi-reordered lines.
1507 Save and restore bidi cache.
1508
1509 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1510 (bidi_paragraph_info): Delete unused struct.
1511 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1512 (bidi_cache_start): New variable.
1513 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1514 to zero.
1515 (bidi_cache_fetch_state, bidi_cache_search)
1516 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1517 (bidi_cache_find, bidi_peek_at_next_level)
1518 (bidi_level_of_next_char, bidi_find_other_level_edge)
1519 (bidi_move_to_visually_next): Compare cache index with
1520 bidi_cache_start rather than with zero.
1521 (bidi_fetch_char): Accept new argument STRING; all callers
1522 changed. Support iteration over a string. Support strings with
1523 display properties. Support unibyte strings. Fix the type of
1524 `len' according to what STRING_CHAR_AND_LENGTH expects.
1525 (bidi_paragraph_init, bidi_resolve_explicit_1)
1526 (bidi_resolve_explicit, bidi_resolve_weak)
1527 (bidi_level_of_next_char, bidi_move_to_visually_next):
1528 Support iteration over a string.
1529 (bidi_set_sor_type, bidi_resolve_explicit_1)
1530 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1531 can now be zero (for strings); special values 0 and -1 were
1532 changed to -1 and -2, respectively.
1533 (bidi_char_at_pos): New function.
1534 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1535 Call it instead of FETCH_MULTIBYTE_CHAR.
1536 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1537 initialized to valid values.
1538 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1539 values.
1540 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1541 the test for valid cached positions. Fix the logic for looking up
1542 the sentinel state in the cache. GCPRO the Lisp string we are
1543 iterating.
1544 (bidi_push_it, bidi_pop_it): New functions.
1545 (bidi_initialize): Initialize the bidi cache start stack pointer.
1546 (bidi_cache_ensure_space): New function, refactored from part of
1547 bidi_cache_iterator_state. Don't assume the required size is just
1548 one BIDI_CACHE_CHUNK away.
1549 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1550 (bidi_count_bytes, bidi_char_at_pos): New functions.
1551 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1552 always valid if bidi_cache_idx is valid.
1553 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1554 is valid if it's going to be used.
1555 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1556 (bidi_cache_fetch_state, bidi_cache_search)
1557 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1558 (bidi_cache_iterator_state, bidi_cache_find)
1559 (bidi_find_other_level_edge, bidi_cache_start_stack):
1560 All variables related to cache indices are now EMACS_INT.
1561
1562 * dispextern.h (struct bidi_string_data): New structure.
1563 (struct bidi_it): New member `string'. Make flag members be 1-bit
1564 fields, and put them last in the struct.
1565 (compute_display_string_pos, compute_display_string_end):
1566 Update prototypes.
1567 (bidi_push_it, bidi_pop_it): Add prototypes.
1568 (struct iterator_stack_entry): New members bidi_p,
1569 paragraph_embedding, and from_disp_prop_p.
1570 (struct it): Member bidi_p is now a bit field 1 bit wide.
1571 (bidi_shelve_cache, bidi_unshelve_cache):
1572 Declare prototypes.
1573
1574 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1575 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1576 and vector-like objects.
1577
1578 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1579 cache around display iteration.
1580
1581 * window.c (Fwindow_end, window_scroll_pixel_based)
1582 (displayed_window_lines, Frecenter): Save and restore the bidi
1583 cache around display iteration.
1584
1585 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1586
1587 * editfns.c (Fdelete_region): Clarify the use of the named
1588 parameters (bug#6788).
1589
1590 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1591
1592 * indent.c (Fvertical_motion): Set and restore w->pointm when
1593 saving and restoring the window's buffer (Bug#9006).
1594
1595 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1596
1597 * editfns.c (Fstring_to_char): Clarify just what is returned
1598 (bug#6576). Text by Eli Zaretskii.
1599
1600 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1601
1602 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1603
1604 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1605
1606 * buffer.c (mmap_find): Fix a typo.
1607
1608 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1609
1610 Fix execution of x selection hooks.
1611 * xselect.c (Qx_lost_selection_functions)
1612 (Qx_sent_selection_functions): New vars.
1613 (syms_of_xselect): DEFSYM them.
1614 (x_handle_selection_request): Pass Qx_sent_selection_functions
1615 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1616 (x_handle_selection_clear,x_clear_frame_selections):
1617 Pass Qx_lost_selection_functions rather than
1618 Vx_lost_selection_functions to Frun_hook_with_args.
1619
1620 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1621
1622 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1623 The old code sometimes used this field without initializing it.
1624
1625 * alloc.c (gc_sweep): Don't read past end of array.
1626 In theory, the old code could also have corrupted Emacs internals,
1627 though it'd be very unlikely.
1628
1629 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1630
1631 * character.c (Fcharacterp): Don't advertise optional ignored
1632 argument. (Bug#4026)
1633
1634 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1635
1636 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1637 key" (bug#4257).
1638
1639 * window.c (Fset_window_start): Doc fix (bug#4199).
1640 (Fset_window_hscroll): Ditto.
1641
1642 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1643
1644 Fix minor new problems caught by GCC 4.6.1.
1645 * term.c (init_tty): Remove unused local.
1646 * xsettings.c (store_monospaced_changed): Define this function only
1647 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1648 not used otherwise.
1649
1650 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1651
1652 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1653
1654 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1655
1656 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1657 are the mini-buffer and the echo area (bug#3320).
1658
1659 * term.c (init_tty): Remove support for supdup, c10 and perq
1660 terminals, which are no longer supported (bug#1482).
1661
1662 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1663
1664 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1665
1666 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1667
1668 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1669 for non-popups (Bug#3642).
1670
1671 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1672
1673 * alloc.c (reset_malloc_hooks): Protoize.
1674 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1675 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1676 * cm.c (losecursor): Likewise.
1677 * data.c (fmod): Likewise.
1678 * dispnew.c (swap_glyphs_in_rows): Likewise.
1679 * emacs.c (memory_warning_signal): Likewise.
1680 * floatfns.c (float_error): Likewise.
1681 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1682 (otf_open, font_otf_capability, generate_otf_features)
1683 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1684 Likewise.
1685 * image.c (pbm_read_file): Likewise.
1686 * indent.c (string_display_width): Likewise.
1687 * intervals.c (check_for_interval, search_for_interval)
1688 (inc_interval_count, count_intervals, root_interval)
1689 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1690 * lread.c (defalias): Likewise.
1691 * ralloc.c (r_alloc_check): Likewise.
1692 * regex.c (set_image_of_range_1, set_image_of_range)
1693 (regex_grow_registers): Likewise.
1694 * sysdep.c (strerror): Likewise.
1695 * termcap.c (valid_filename_p, tprint, main): Likewise.
1696 * tparam.c (main): Likewise.
1697 * unexhp9k800.c (run_time_remap, save_data_space)
1698 (update_file_ptrs, read_header, write_header, calculate_checksum)
1699 (copy_file, copy_rest, display_header): Likewise.
1700 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1701 Likewise.
1702 * xdisp.c (check_it): Likewise.
1703 * xfaces.c (register_color, unregister_color, unregister_colors):
1704 Likewise.
1705 * xfns.c (print_fontset_result): Likewise.
1706 * xrdb.c (member, fatal, main): Likewise.
1707
1708 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1709
1710 Fix minor problems found by static checking (Bug#9031).
1711 * chartab.c (char_table_set_range, map_sub_char_table):
1712 Remove unused locals.
1713 (uniprop_table): Now static.
1714 * composite.c (_work_char): Remove unused static var.
1715
1716 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1717
1718 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1719
1720 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1721
1722 * gtkutil.c (qttip_cb): Remove code without function.
1723
1724 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1725
1726 * w32.c (pthread_sigmask): New stub.
1727
1728 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1729
1730 Use pthread_sigmask, not sigprocmask (Bug#9010).
1731 sigprocmask is portable only for single-threaded applications, and
1732 Emacs can be multi-threaded when it uses GTK.
1733 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1734 (LIBES): Use it.
1735 * callproc.c (Fcall_process):
1736 * process.c (create_process):
1737 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1738 Use pthread_sigmask, not sigprocmask.
1739
1740 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1741
1742 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1743 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1744 wrong (Bug#8591).
1745
1746 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1747
1748 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1749 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1750 (xg_hide_tooltip): Fix comment.
1751
1752 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1753 in registerServicesMenuSendTypes.
1754 (validRequestorForSendType): Don't check ns_return_types.
1755
1756 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1757 ns_return_type.
1758
1759 2011-07-08 Jason Rumney <jasonr@gnu.org>
1760
1761 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1762 frame struct members of non-existent frames (Bug#6284).
1763
1764 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1765
1766 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1767 variable firstTime not needed on OSX >= 10.6.
1768 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1769 >= 10.5. Use setKnobProportion, setDoubleValue.
1770
1771 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1772 (MAC_OS_X_VERSION_10_5): Define if not defined.
1773 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1774 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1775 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1776
1777 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1778 cString and lossyCString on OSX >= 10.4
1779
1780 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1781 sizeToFit on OSX >= 10.2.
1782
1783 * nsimage.m (allocInitFromFile): Don't use deprecated method
1784 bestRepresentationForDevice on OSX >= 10.6.
1785
1786 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1787 to avoid warning.
1788
1789 * emacs.c: Declare unexec_init_emacs_zone.
1790
1791 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1792
1793 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1794
1795 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1796 on svcsMenu (Bug#8842).
1797
1798 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1799 ns_return_types.
1800 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1801
1802 * nsterm.m (QUTF8_STRING): Declare.
1803 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1804 (validRequestorForSendType): Return type is (id).
1805 Change indexOfObjectIdenticalTo to indexOfObject.
1806 Check if we have local selection before returning self (Bug#8842).
1807 (writeSelectionToPasteboard): Put local selection into paste board
1808 if we have a local selection (Bug#8842).
1809 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1810
1811 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1812 (ns_get_local_selection): Declare.
1813
1814 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1815
1816 * keymap.c (describe_map_tree): Don't insert a double newline at
1817 the end of the buffer (bug#1169) and return whether we inserted
1818 something.
1819
1820 * callint.c (Fcall_interactively): Change "reading args" to
1821 "providing args" to try to clarify what it does (bug#1010).
1822
1823 2011-07-07 Kenichi Handa <handa@m17n.org>
1824
1825 * composite.c (composition_compute_stop_pos): Ignore a static
1826 composition starting before CHARPOS (Bug#8915).
1827
1828 * xdisp.c (handle_composition_prop): Likewise.
1829
1830 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1831
1832 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1833 (Bug#9015)
1834
1835 2011-07-07 Kenichi Handa <handa@m17n.org>
1836
1837 * character.h (unicode_category_t): New enum type.
1838
1839 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1840 (Qchar_code_property_table): New variable.
1841 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1842 (UNIPROP_COMPRESSED_FORM_P): New macros.
1843 (char_table_ascii): Uncompress the compressed values.
1844 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1845 Uncompress the compressed values.
1846 (sub_char_table_ref_and_range): Likewise.
1847 (char_table_ref_and_range): Uncompress the compressed values.
1848 (sub_char_table_set): New arg is_uniprop. Callers changed.
1849 Uncompress the compressed values.
1850 (sub_char_table_set_range): Args changed. Callers changed.
1851 (char_table_set_range): Adjuted for the above change.
1852 (map_sub_char_table): Delete args default_val and parent. Add arg
1853 top. Give decoded values to a Lisp function.
1854 (map_char_table): Adjust for the above change. Give decoded
1855 values to a Lisp function. Gcpro more variables.
1856 (uniprop_table_uncompress)
1857 (uniprop_decode_value_run_length): New functions.
1858 (uniprop_decoder, uniprop_decoder_count): New variables.
1859 (uniprop_get_decoder, uniprop_encode_value_character)
1860 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1861 New functions.
1862 (uniprop_encoder, uniprop_encoder_count): New variables.
1863 (uniprop_get_encoder, uniprop_table)
1864 (Funicode_property_table_internal, Fget_unicode_property_internal)
1865 (Fput_unicode_property_internal): New functions.
1866 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1867 Sunicode_property_table_internal, Sget_unicode_property_internal,
1868 and Sput_unicode_property_internal. Defvar_lisp
1869 char-code-property-alist.
1870
1871 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1872 Vunicode_category_table.
1873
1874 * font.c (font_range): Adjust for the change of
1875 Vunicode_category_table.
1876
1877 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1878
1879 * m/iris4d.h: Remove file, move contents ...
1880 * s/irix6-5.h: ... here.
1881
1882 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1883
1884 Remove unportable assumption about struct layout (Bug#8884).
1885 * alloc.c (mark_buffer):
1886 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1887 (clone_per_buffer_values): Don't assume that
1888 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1889 This isn't true in general, and it's particularly not true
1890 if Emacs is configured with --with-wide-int.
1891 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1892 New macros, used in the buffer.c change.
1893
1894 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1895
1896 * xsettings.c: Use both GConf and GSettings if both are available.
1897 (store_config_changed_event): Add comment.
1898 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1899 (store_tool_bar_style_changed): New functions.
1900 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1901 (struct xsettings): Move font inside HAVE_XFT.
1902 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1903 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1904 Move inside HAVE_XFT.
1905 (something_changed_gsettingsCB): Rename from something_changedCB.
1906 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1907 also.
1908 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1909 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1910 (something_changed_gconfCB): Rename from something_changedCB.
1911 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1912 (parse_settings): Move check for font inside HAVE_XFT.
1913 (read_settings, apply_xft_settings): Add comment.
1914 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1915 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1916 call store_font_name_changed.
1917 (xft_settings_event): Add comment.
1918 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1919 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1920 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1921 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1922 (xsettings_initialize): Call init_gsettings last.
1923 (xsettings_get_system_font, xsettings_get_system_normal_font):
1924 Add comment.
1925
1926 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1927
1928 Random fixes. E.g., (random) never returned negative values.
1929 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1930 subseconds part to the entropy, as that's a bit more random.
1931 Prefer signed to unsigned, since the signedness doesn't matter and
1932 in general we prefer signed. When given a limit, use a
1933 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1934 latter isn't right if USE_2_TAGS_FOR_INTS.
1935 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1936 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1937
1938 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1939
1940 * textprop.c (text_property_stickiness):
1941 Obey Vtext_property_default_nonsticky.
1942 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1943 * w32fns.c (syms_of_w32fns):
1944 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1945
1946 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1947
1948 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1949 This is more efficient than Ffile_directory_p and avoids a minor race.
1950
1951 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1952
1953 * buffer.c (Foverlay_put): Say what the return value is
1954 (bug#7835).
1955
1956 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1957 is a directory before asking whether to use the file name
1958 (bug#7564).
1959 (barf_or_query_if_file_exists): Make the "File is a directory"
1960 error be more correct.
1961
1962 * fns.c (Frequire): Remove the mention of the .gz files, since
1963 that's installation-specific, but keep the mention of
1964 `get-load-suffixes'.
1965
1966 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1967
1968 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1969 Report string overflow if the output is too long.
1970
1971 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1972
1973 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1974 (syms_of_gnutls): Remove duplicate DEFSYM for
1975 Qgnutls_bootprop_verify_hostname_error, an error for
1976 Qgnutls_bootprop_verify_error (which is no longer used).
1977
1978 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1979 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1980 Also (re)move comments that are misplaced or no longer relevant.
1981
1982 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1983
1984 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1985
1986 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1987
1988 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1989 and background color parameters if they have been changed.
1990
1991 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1992
1993 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1994
1995 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1996
1997 * xsettings.c (SYSTEM_FONT): Define only when used.
1998 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1999
2000 * keymap.c (access_keymap_1): Now static.
2001
2002 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2003
2004 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2005 leave any prefix arg for the up event (Bug#1586).
2006
2007 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2008
2009 * lread.c (syms_of_lread): Mention single symbols defined by
2010 `defvar' or `defconst' (bug#7154).
2011
2012 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2013 (Frequire): Mention get-load-suffixes.
2014
2015 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2016
2017 * window.h (window): Remove clone_number slot.
2018 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2019 Remove.
2020 (make_parent_window, make_window, saved_window)
2021 (Fset_window_configuration, save_window_save): Don't deal with
2022 clone numbers.
2023 * buffer.c (Qclone_number): Remove declaration.
2024 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2025
2026 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2027
2028 Add multiple inheritance to keymaps.
2029 * keymap.c (Fmake_composed_keymap): New function.
2030 (Fset_keymap_parent): Simplify.
2031 (fix_submap_inheritance): Remove.
2032 (access_keymap_1): New function extracted from access_keymap to handle
2033 embedded parents and handle lists of maps.
2034 (access_keymap): Use it.
2035 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2036 (Fcopy_keymap): Handle embedded parents.
2037 (Fcommand_remapping, define_as_prefix): Simplify.
2038 (Fkey_binding): Simplify.
2039 (syms_of_keymap): Move minibuffer-local-completion-map,
2040 minibuffer-local-filename-completion-map,
2041 minibuffer-local-must-match-map, and
2042 minibuffer-local-filename-must-match-map to Elisp.
2043 (syms_of_keymap): Defsubr make-composed-keymap.
2044 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2045 (parse_menu_item): Trivial simplification.
2046
2047 2011-07-01 Glenn Morris <rgm@gnu.org>
2048
2049 * Makefile.in (SETTINGS_LIBS): Fix typo.
2050
2051 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2052
2053 * coding.c (Fencode_coding_string): Record the last coding system
2054 used, as the function doc string says (bug#8738).
2055
2056 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2057
2058 * xsettings.c (store_monospaced_changed): Take new font as arg and
2059 check for change against current_mono_font.
2060 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2061 (emacs_settings_constructor, emacs_settings_get_property)
2062 (emacs_settings_set_property, emacs_settings_class_init)
2063 (emacs_settings_init, gsettings_obj): Remove.
2064 (something_changedCB): New function for HAVE_GSETTINGS.
2065 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2066 with value as argument.
2067 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2068 g_settings_new (Bug#8967). Do not create gsettings_obj.
2069 Remove calls to g_settings_bind. Connect something_changedCB to
2070 "changed".
2071
2072 * xgselect.c: Add defined (HAVE_GSETTINGS).
2073 (xgselect_initialize): Ditto.
2074
2075 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2076 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2077 xg_select.
2078
2079 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2080
2081 * eval.c (struct backtrace): Simplify and port the data structure.
2082 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2083 signed bit field, as this assumption is not portable and it makes
2084 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2085 "char debug_on_exit : 1" as this is not portable either; instead,
2086 use the portable "unsigned int debug_on_exit : 1". Remove unused
2087 member evalargs. Remove obsolete comments about cc bombing out.
2088
2089 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2090
2091 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2092 Let HAVE_GSETTINGS override HAVE_GCONF.
2093 (store_monospaced_changed): New function.
2094 (EMACS_SETTINGS): A new type derived from GObject to handle
2095 GSettings notifications.
2096 (emacs_settings_constructor, emacs_settings_get_property)
2097 (emacs_settings_set_property, emacs_settings_class_init):
2098 New functions.
2099 (gsettings_client, gsettings_obj): New variables.
2100 (GSETTINGS_SCHEMA): New define.
2101 (something_changedCB): Call store_monospaced_changed.
2102 (init_gsettings): New function.
2103 (xsettings_initialize): Call init_gsettings.
2104 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2105 to NULL.
2106
2107 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2108 GCONF_CFLAGS/LIBS.
2109
2110 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2111
2112 * window.c (resize_root_window, grow_mini_window)
2113 (shrink_mini_window): Rename Qresize_root_window to
2114 Qwindow_resize_root_window and Qresize_root_window_vertically to
2115 Qwindow_resize_root_window_vertically.
2116
2117 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2118
2119 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2120
2121 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2122
2123 * makefile.w32-in: Redesign dependencies so they reflect more
2124 clearly which files are directly included by each source file,
2125 and not through other includes.
2126
2127 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2128
2129 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2130 (sort_overlays, overlay_strings): When an overlay's clone number
2131 matches the window's clone number process the overlay even if
2132 the overlay's window property doesn't match the current window.
2133
2134 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2135 (Fwindow_hchild): Rename to Fwindow_left_child.
2136 (Fwindow_next): Rename to Fwindow_next_sibling.
2137 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2138 (resize_window_check): Rename to window_resize_check.
2139 (resize_window_apply): Rename to window_resize_apply.
2140 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2141 (Fdelete_other_windows_internal, resize_frame_windows)
2142 (Fsplit_window_internal, Fdelete_window_internal)
2143 (grow_mini_window, shrink_mini_window)
2144 (Fresize_mini_window_internal): Fix callers accordingly.
2145
2146 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2147
2148 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2149 (emacs_fixed_set_min_size): Remove.
2150 (emacs_fixed_new): Take frame as argument.
2151
2152 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2153 (_EmacsFixedPrivate): Remove minwidth/height.
2154 Add struct frame *f.
2155 (emacs_fixed_init): Initialize priv->f.
2156 (get_parent_class, emacs_fixed_set_min_size): Remove.
2157 (emacs_fixed_new): Set priv->f to argument.
2158 (emacs_fixed_get_preferred_width)
2159 (emacs_fixed_get_preferred_height): Use min_width/height from
2160 frames size_hint to set minimum and natural (Bug#8919).
2161 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2162 and use min_width/height from frames size_hint to set
2163 min_width/height (Bug#8919).
2164
2165 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2166 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2167 Fix indentation.
2168
2169 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2170
2171 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2172 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2173 called at ZV.
2174
2175 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2176
2177 * process.c (wait_reading_process_output): Bypass select if
2178 waiting for a cell while ignoring keyboard input, and input is
2179 pending. Suggested by Jan Djärv (Bug#8869).
2180
2181 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2182
2183 Use gnulib's dup2 module instead of rolling our own.
2184 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2185
2186 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2187
2188 * dispnew.c (scrolling_window): Before scrolling, turn off a
2189 mouse-highlight in the window being scrolled.
2190
2191 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2192
2193 Move DEFSYM to lisp.h and use everywhere.
2194
2195 * character.h (DEFSYM): Move declaration...
2196 * lisp.h (DEFSYM): ...here.
2197
2198 * gnutls.c:
2199 * minibuf.c:
2200 * w32menu.c:
2201 * w32proc.c:
2202 * w32select.c: Don't include character.h.
2203
2204 * alloc.c (syms_of_alloc):
2205 * buffer.c (syms_of_buffer):
2206 * bytecode.c (syms_of_bytecode):
2207 * callint.c (syms_of_callint):
2208 * casefiddle.c (syms_of_casefiddle):
2209 * casetab.c (init_casetab_once):
2210 * category.c (init_category_once, syms_of_category):
2211 * ccl.c (syms_of_ccl):
2212 * cmds.c (syms_of_cmds):
2213 * composite.c (syms_of_composite):
2214 * dbusbind.c (syms_of_dbusbind):
2215 * dired.c (syms_of_dired):
2216 * dispnew.c (syms_of_display):
2217 * doc.c (syms_of_doc):
2218 * editfns.c (syms_of_editfns):
2219 * emacs.c (syms_of_emacs):
2220 * eval.c (syms_of_eval):
2221 * fileio.c (syms_of_fileio):
2222 * fns.c (syms_of_fns):
2223 * frame.c (syms_of_frame):
2224 * fringe.c (syms_of_fringe):
2225 * insdel.c (syms_of_insdel):
2226 * keymap.c (syms_of_keymap):
2227 * lread.c (init_obarray, syms_of_lread):
2228 * macros.c (syms_of_macros):
2229 * msdos.c (syms_of_msdos):
2230 * print.c (syms_of_print):
2231 * process.c (syms_of_process):
2232 * search.c (syms_of_search):
2233 * sound.c (syms_of_sound):
2234 * syntax.c (init_syntax_once, syms_of_syntax):
2235 * terminal.c (syms_of_terminal):
2236 * textprop.c (syms_of_textprop):
2237 * undo.c (syms_of_undo):
2238 * w32.c (globals_of_w32):
2239 * window.c (syms_of_window):
2240 * xdisp.c (syms_of_xdisp):
2241 * xfaces.c (syms_of_xfaces):
2242 * xfns.c (syms_of_xfns):
2243 * xmenu.c (syms_of_xmenu):
2244 * xsettings.c (syms_of_xsettings):
2245 * xterm.c (syms_of_xterm): Use DEFSYM.
2246
2247 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2248
2249 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2250
2251 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2252
2253 Integer and buffer overflow fixes (Bug#8873).
2254
2255 * print.c (printchar, strout): Check for string overflow.
2256 (PRINTPREPARE, printchar, strout):
2257 Don't set size unless allocation succeeds.
2258
2259 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2260 for sizes. Check for string overflow more accurately.
2261 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2262
2263 * macros.c: Integer and buffer overflow fixes.
2264 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2265 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2266 Use ptrdiff_t, not int, for sizes.
2267 Don't increment bufsize until after realloc succeeds.
2268 Check for size-calculation overflow.
2269 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2270
2271 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2272
2273 * lread.c: Integer overflow fixes.
2274 (read_integer): Radix is now EMACS_INT, not int,
2275 to improve quality of diagnostics for out-of-range radices.
2276 Calculate buffer size correctly for out-of-range radices.
2277 (read1): Check for integer overflow in radices, and in
2278 read-circle numbers.
2279 (read_escape): Avoid int overflow.
2280 (Fload, openp, read_buffer_size, read1)
2281 (substitute_object_recurse, read_vector, read_list, map_obarray):
2282 Use ptrdiff_t, not int, for sizes.
2283 (read1): Use EMACS_INT, not int, for sizes.
2284 Check for size overflow.
2285
2286 * image.c (cache_image): Check for size arithmetic overflow.
2287
2288 * lread.c: Integer overflow issues.
2289 (saved_doc_string_size, saved_doc_string_length)
2290 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2291 Now ptrdiff_t, not int.
2292 (read1): Don't assume doc string length fits in int. Check for
2293 out-of-range doc string lengths.
2294 (read_list): Don't assume file position fits in int.
2295 (read_escape): Check for hex character overflow.
2296
2297 2011-06-22 Leo Liu <sdl.web@gmail.com>
2298
2299 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2300 Move to minibuffer.el.
2301
2302 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2303
2304 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2305 The following patches are for when GLYPH_DEBUG && !XASSERT.
2306 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2307 * dispnew.c (flush_stdout):
2308 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2309 Mark as externally visible.
2310 * dispnew.c (check_window_matrix_pointers): Now static.
2311 * dispnew.c (window_to_frame_vpos):
2312 * xfns.c (unwind_create_frame):
2313 * xterm.c (x_check_font): Remove unused local.
2314 * scroll.c (CHECK_BOUNDS):
2315 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2316 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2317 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2318 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2319 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2320 Now static.
2321 (debug_method_add): Use va_list and vsprintf rather than relying
2322 on undefined behavior with wrong number of arguments.
2323 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2324 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2325 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2326 since we're not interested in debugging glyphs with old libraries.
2327 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2328 GCC 4.6.0's static checking.
2329
2330 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2331
2332 Integer overflow and signedness fixes (Bug#8873).
2333 A few related buffer overrun fixes, too.
2334
2335 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2336
2337 * dispextern.h (struct face.stipple):
2338 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2339 (x_bitmap_mask, x_allocate_bitmap_record)
2340 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2341 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2342 (x_create_bitmap_from_xpm_data):
2343 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2344 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2345 (.bitmaps_last):
2346 * xfaces.c (load_pixmap):
2347 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2348 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2349 (.bitmaps_last, struct x_output.icon_bitmap):
2350 Use ptrdiff_t, not int, for bitmap indexes.
2351 (x_allocate_bitmap_record): Check for size overflow.
2352 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2353
2354 Use ptrdiff_t, not int, for overlay counts.
2355 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2356 * editfns.c (overlays_around, get_pos_property):
2357 * textprop.c (get_char_property_and_overlay):
2358 * xdisp.c (next_overlay_change, note_mouse_highlight):
2359 * xfaces.c (face_at_buffer_position):
2360 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2361 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2362 (Fnext_overlay_change, Fprevious_overlay_change)
2363 (mouse_face_overlay_overlaps, Foverlays_in):
2364 Use ptrdiff_t, not int, for sizes.
2365 (overlays_at, overlays_in): Check for size-calculation overflow.
2366
2367 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2368
2369 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2370 (x_session_initialize): Do not assume string length fits in int.
2371
2372 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2373 This is unlikely, but can occur if DPI is outlandish.
2374
2375 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2376 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2377
2378 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2379 * xrdb.c (magic_file_p, search_magic_path):
2380 Omit last arg SUFFIX; it was always 0. All callers changed.
2381 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2382
2383 * xfont.c (xfont_match): Avoid need for strlen.
2384
2385 * xfns.c: Don't assume strlen fits in int.
2386 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2387
2388 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2389 not unsigned long, as we prefer signed integers. All callers changed.
2390 Detect integer overflow in repeat count.
2391 (message_dolog): Don't assume print length fits in 39 bytes.
2392 (display_mode_element): Don't assume strlen fits in int.
2393
2394 * termcap.c: Don't assume sizes fit in int and never overflow.
2395 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2396 (gobble_line): Check for size-calculation overflow.
2397
2398 * minibuf.c (Fread_buffer):
2399 * lread.c (intern, intern_c_string):
2400 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2401 Don't assume string length fits in int.
2402
2403 * keyboard.c (parse_tool_bar_item):
2404 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2405
2406 * font.c: Don't assume string length fits in int.
2407 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2408 Use ptrdiff_t, not int.
2409 (font_intern_prop): Don't assume string length fits in int.
2410 Don't assume integer property fits in fixnum.
2411 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2412
2413 * filelock.c: Fix some buffer overrun and integer overflow issues.
2414 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2415 Reformulate so as not to need the command string.
2416 Invoke gzip -cd rather than gunzip, as it's more portable.
2417 (lock_info_type, lock_file_1, lock_file):
2418 Don't assume pid_t and time_t fit in unsigned long.
2419 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2420 (current_lock_owner): Prefer signed type for sizes.
2421 Use memcpy, not strncpy, where memcpy is what is really wanted.
2422 Don't assume (via atoi) that time_t and pid_t fit in int.
2423 Check for time_t and/or pid_t out of range, e.g., via a network share.
2424 Don't alloca where an auto var works fine.
2425
2426 * fileio.c: Fix some integer overflow issues.
2427 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2428 Don't assume string length fits in int.
2429 (directory_file_name): Don't assume string length fits in long.
2430 (make_temp_name): Don't assume pid fits in int, or that its print
2431 length is less than 20.
2432
2433 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2434
2435 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2436
2437 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2438
2439 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2440 We prefer signed integers, even for size calculations.
2441
2442 * emacs.c: Don't assume string length fits in 'int'.
2443 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2444 (main): Don't invoke strlen when not needed.
2445
2446 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2447 (XD_DEBUG_MESSAGE): Don't waste a byte.
2448
2449 * callproc.c (getenv_internal_1, getenv_internal)
2450 (Fgetenv_internal):
2451 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2452
2453 * lread.c (invalid_syntax): Omit length argument.
2454 All uses changed. This doesn't fix a bug, but it simplifies the
2455 code away from its former Hollerith-constant appearance, and it's
2456 one less 'int' to worry about when looking at integer-overflow issues.
2457 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2458
2459 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2460 This didn't break anything, but it didn't help either.
2461 It's confusing to put a bogus integer in a place where the actual
2462 value does not matter.
2463 (LIST_END_P): Remove unused macro and its bogus comment.
2464 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2465
2466 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2467 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2468 implementation.
2469 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2470 We prefer signed types, and the value cannot exceed the EMACS_INT
2471 range anyway (because otherwise the length would not be representable).
2472 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2473 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2474 This avoids a GCC warning when WIDE_EMACS_INT.
2475
2476 * indent.c (sane_tab_width): New function.
2477 (current_column, scan_for_column, Findent_to, position_indentation)
2478 (compute_motion): Use it. This is just for clarity.
2479 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2480
2481 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2482
2483 * lisp.h (lint_assume): New macro.
2484 * composite.c (composition_gstring_put_cache):
2485 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2486
2487 * editfns.c, insdel.c:
2488 Omit unnecessary forward decls, to simplify future changes.
2489
2490 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2491
2492 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2493
2494 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2495 Use much-faster test for byte-length change.
2496 Don't assume string byte-length fits in 'int'.
2497 Check that character arg fits in 'int'.
2498 (mapcar1): Declare byte as byte, for clarity.
2499
2500 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2501
2502 * fns.c (concat): Catch string overflow earlier.
2503 Do not rely on integer wraparound.
2504
2505 * dispextern.h (struct it.overlay_strings_charpos)
2506 (struct it.selective): Now EMACS_INT, not int.
2507 * xdisp.c (forward_to_next_line_start)
2508 (back_to_previous_visible_line_start)
2509 (reseat_at_next_visible_line_start, next_element_from_buffer):
2510 Don't arbitrarily truncate the value of 'selective' to int.
2511
2512 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2513
2514 * composite.c: Don't truncate sizes to 'int'.
2515 (composition_gstring_p, composition_reseat_it)
2516 (composition_adjust_point): Use EMACS_INT, not int.
2517 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2518 not EMACS_UINT, for indexes.
2519
2520 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2521
2522 * buffer.c: Include <verify.h>.
2523 (struct sortvec.priority, struct sortstr.priority):
2524 Now EMACS_INT, not int.
2525 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2526 (struct sortstr.size, record_overlay_string)
2527 (struct sortstrlist.size, struct sortlist.used):
2528 Don't truncate size to int.
2529 (record_overlay_string): Check for size-calculation overflow.
2530 (init_buffer_once): Check at compile-time, not run-time.
2531
2532 2011-06-22 Jim Meyering <meyering@redhat.com>
2533
2534 Don't leak an XBM-image-sized buffer
2535 * image.c (xbm_load): Free the image buffer after using it.
2536
2537 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2538
2539 Port to Sun C.
2540 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2541 that Sun C diagnosed.
2542 * fns.c (secure_hash): Fix pointer signedness issue.
2543 * intervals.c (static_offset_intervals): New function.
2544 (offset_intervals): Use it.
2545
2546 2011-06-21 Leo Liu <sdl.web@gmail.com>
2547
2548 * deps.mk (fns.o):
2549 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2550 sha512.h.
2551
2552 * fns.c (secure_hash): Rename from crypto_hash_function and change
2553 the first arg to accept symbols.
2554 (Fsecure_hash): New primitive.
2555 (syms_of_fns): New symbols.
2556
2557 2011-06-20 Deniz Dogan <deniz@dogan.se>
2558
2559 * process.c (Fset_process_buffer): Clarify return value in
2560 docstring.
2561
2562 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2563
2564 * dispnew.c (add_window_display_history): Use BVAR.
2565
2566 * xdisp.c (debug_method_add): Use BVAR.
2567 (check_window_end, dump_glyph_matrix, dump_glyph)
2568 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2569
2570 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2571 Likewise.
2572
2573 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2574 check till after the cache is created in init_frame_faces.
2575
2576 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2577
2578 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2579
2580 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2581
2582 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2583 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2584 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2585
2586 Improve buffer-overflow checking (Bug#8873).
2587 * fileio.c (Finsert_file_contents):
2588 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2589 Remove the old (too-loose) buffer overflow checks.
2590 They weren't needed, since make_gap checks for buffer overflow.
2591 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2592 The old code merely checked for Emacs fixnum overflow, and relied
2593 on undefined (wraparound) behavior. The new code avoids undefined
2594 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2595
2596 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2597 Tune. Don't use wider integers than needed. Don't use alloca.
2598 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2599
2600 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2601
2602 * insdel.c, lisp.h (buffer_overflow): New function.
2603 (insert_from_buffer_1, replace_range, replace_range_2):
2604 * insdel.c (make_gap_larger):
2605 * editfns.c (Finsert_char):
2606 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2607
2608 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2609
2610 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2611
2612 Integer overflow and signedness fixes (Bug#8873).
2613
2614 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2615 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2616
2617 * fileio.c: Don't assume EMACS_INT fits in off_t.
2618 (emacs_lseek): New static function.
2619 (Finsert_file_contents, Fwrite_region): Use it.
2620 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2621
2622 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2623
2624 * fns.c: Don't overflow int when computing a list length.
2625 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2626 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2627 truncation on 64-bit hosts. Check for QUIT every
2628 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2629 faster and is responsive enough.
2630 (Flength): Report an error instead of overflowing an integer.
2631 (Fsafe_length): Return a float if the value is not representable
2632 as a fixnum. This shouldn't happen except in contrived situations.
2633 (Fnthcdr, Fsort): Don't assume list length fits in int.
2634 (Fcopy_sequence): Don't assume vector length fits in int.
2635
2636 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2637 (header_size, word_size): New constants.
2638 (allocate_vectorlike): Don't check size overflow here.
2639 (allocate_vector): Check it here instead, since this is the only
2640 caller of allocate_vectorlike that could cause overflow.
2641 Check that the new vector's length is representable as a fixnum.
2642
2643 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2644 The previous code was bogus. For example, next_almost_prime (32)
2645 returned 39, which is undesirable as it is a multiple of 3; and
2646 next_almost_prime (24) returned 25, which is a multiple of 5 so
2647 why was the code bothering to check for multiples of 7?
2648
2649 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2650
2651 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2652
2653 Variadic C functions now count arguments with ptrdiff_t.
2654 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2655 Back then I didn't know that the Emacs coding style prefers signed int.
2656 Also, in the meantime I found a few more instances where arguments
2657 were being counted with int, which may truncate counts on 64-bit
2658 machines, or EMACS_INT, which may be unnecessarily wide.
2659 * lisp.h (struct Lisp_Subr.function.aMANY)
2660 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2661 Arg counts are now ptrdiff_t, not size_t.
2662 All variadic functions and their callers changed accordingly.
2663 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2664 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2665 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2666 * callint.c (Fcall_interactively): Check arg count for overflow,
2667 to avoid potential buffer overrun. Use signed char, not 'int',
2668 for 'varies' array, so that we needn't bother to check its size
2669 calculation for overflow.
2670 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2671 * eval.c (apply_lambda):
2672 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2673 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2674 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2675
2676 * callint.c (Fcall_interactively): Don't use index var as event count.
2677
2678 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2679 * mem-limits.h (SIZE): Remove; no longer used.
2680
2681 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2682
2683 Remove unnecessary casts.
2684 * xterm.c (x_term_init):
2685 * xfns.c (x_set_border_pixel):
2686 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2687 These aren't needed now that we assume ANSI C.
2688
2689 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2690 It's more likely to cause problems (due to unsigned overflow)
2691 than to cure them.
2692
2693 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2694
2695 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2696
2697 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2698
2699 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2700
2701 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2702
2703 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2704
2705 GLYPH_CODE_FACE returns EMACS_INT, not int.
2706 * dispextern.h (merge_faces):
2707 * xfaces.c (merge_faces):
2708 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2709 Don't assume EMACS_INT fits in int.
2710
2711 * character.h (CHAR_VALID_P): Remove unused parameter.
2712 * fontset.c, lisp.h, xdisp.c: All uses changed.
2713
2714 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2715
2716 * fns.c (concat): Minor tuning based on overflow analysis.
2717 This doesn't fix any bugs. Use int to hold character, instead
2718 of constantly refetching from Emacs object. Use XFASTINT, not
2719 XINT, for value known to be a character. Don't bother comparing
2720 a single byte to 0400, as it's always less.
2721
2722 * floatfns.c (Fexpt):
2723 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2724
2725 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2726 for characters.
2727
2728 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2729
2730 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2731 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2732 incorrectly succeed when S was a string, because 4294967386 was
2733 truncated before it was used.
2734
2735 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2736 Otherwise, an out-of-range integer could cause undefined behavior
2737 on a 64-bit host.
2738
2739 * composite.c: Use int, not EMACS_INT, for characters.
2740 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2741 EMACS_INT, for values that are known to be in character range.
2742 This doesn't fix any bugs but is the usual style inside Emacs and
2743 may generate better code on 32-bit machines.
2744
2745 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2746 This is for reasons similar to the recent CHAR_STRING fix.
2747 * charset.c (Fencode_char): Check that character arg is actually
2748 a character. Pass an int to ENCODE_CHAR.
2749 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2750 wider than 'int', as a compile-time check to prevent future regressions
2751 in this area.
2752
2753 * character.c (char_string): Remove unnecessary casts.
2754
2755 Make sure a 64-bit char is never passed to CHAR_STRING.
2756 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2757 by silently ignoring the top 32 bits, allowing some values
2758 that were far too large to be valid characters.
2759 * character.h: Include <verify.h>.
2760 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2761 arguments are no wider than unsigned, as a compile-time check
2762 to prevent future regressions in this area.
2763 * data.c (Faset):
2764 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2765 (Fsubst_char_in_region):
2766 * fns.c (concat):
2767 * xdisp.c (decode_mode_spec_coding):
2768 Adjust to CHAR_STRING's new requirement.
2769 * editfns.c (Finsert_char, Fsubst_char_in_region):
2770 * fns.c (concat): Check that character args are actually
2771 characters. Without this test, these functions did the wrong
2772 thing with wildly out-of-range values on 64-bit hosts.
2773
2774 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2775 These casts should not be needed on 32-bit hosts, either.
2776 * keyboard.c (read_char):
2777 * lread.c (Fload): Remove casts to unsigned.
2778
2779 * lisp.h (UNSIGNED_CMP): New macro.
2780 This fixes comparison bugs on 64-bit hosts.
2781 (ASCII_CHAR_P): Use it.
2782 * casefiddle.c (casify_object):
2783 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2784 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2785 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2786 * dispextern.h (FACE_FROM_ID):
2787 * keyboard.c (read_char): Use UNSIGNED_CMP.
2788
2789 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2790 not to EMACS_INT, to avoid GCC warning.
2791
2792 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2793
2794 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2795 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2796 isn't needed on 32-bit machines.
2797
2798 * buffer.c (Fgenerate_new_buffer_name):
2799 Use EMACS_INT for count, not int.
2800 (advance_to_char_boundary): Return EMACS_INT, not int.
2801
2802 * data.c (Qcompiled_function): Now static.
2803
2804 * window.c (window_body_lines): Now static.
2805
2806 * image.c (gif_load): Rename local to avoid shadowing.
2807
2808 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2809 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2810 * alloc.c (make_save_value): Integer argument is now of type
2811 ptrdiff_t, not int.
2812 (mark_object): Use ptrdiff_t, not int.
2813 * lisp.h (pD): New macro.
2814 * print.c (print_object): Use it.
2815
2816 * alloc.c: Use EMACS_INT, not int, to count objects.
2817 (total_conses, total_markers, total_symbols, total_vector_size)
2818 (total_free_conses, total_free_markers, total_free_symbols)
2819 (total_free_floats, total_floats, total_free_intervals)
2820 (total_intervals, total_strings, total_free_strings):
2821 Now EMACS_INT, not int. All uses changed.
2822 (Fgarbage_collect): Compute overall total using a double, so that
2823 integer overflow is less likely to be a problem. Check for overflow
2824 when converting back to an integer.
2825 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2826 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2827 These were 'int' variables that could overflow on 64-bit hosts;
2828 they were never used, so remove them instead of repairing them.
2829 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2830 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2831 Previously, this ceilinged at INT_MAX, but that doesn't work on
2832 64-bit machines.
2833 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2834
2835 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2836 (allocate_vectorlike): Check for ptrdiff_t overflow.
2837 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2838 when a (possibly-narrower) signed value would do just as well.
2839 We prefer using signed arithmetic, to avoid comparison confusion.
2840
2841 * alloc.c: Catch some string size overflows that we were missing.
2842 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2843 for convenience in STRING_BYTES_MAX.
2844 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2845 The definition here is exact; the one in lisp.h was approximate.
2846 (allocate_string_data): Check for string overflow. This catches
2847 some instances we weren't catching before. Also, it catches
2848 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2849 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2850 and ptrdiff_t and EMACS_INT are both 64 bits.
2851
2852 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2853 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2854 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2855
2856 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2857
2858 * alloc.c (Fmake_string): Check for out-of-range init.
2859
2860 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2861
2862 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2863
2864 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2865
2866 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2867 xg_get_default_scrollbar_width.
2868
2869 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2870 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2871 (style_changed_cb): Call update_theme_scrollbar_width and call
2872 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2873 all frames (Bug#8505).
2874 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2875 Call gtk_window_set_resizable if HAVE_GTK3.
2876 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2877 and height if HAVE_GTK3 (Bug#8505).
2878 (scroll_bar_width_for_theme): New variable.
2879 (update_theme_scrollbar_width): New function.
2880 (xg_get_default_scrollbar_width): Move code to
2881 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2882 (xg_initialize): Call update_theme_scrollbar_width.
2883
2884 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2885
2886 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2887
2888 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2889
2890 * frame.c (make_frame): Call other_buffer_safely instead of
2891 other_buffer.
2892
2893 * window.c (temp_output_buffer_show): Call display_buffer with
2894 second argument Vtemp_buffer_show_specifiers and reset latter
2895 immediately after the call.
2896 (Vtemp_buffer_show_specifiers): New variable.
2897 (auto_window_vscroll_p, next_screen_context_lines)
2898 (Vscroll_preserve_screen_position): Remove leading asterisks from
2899 doc-strings.
2900
2901 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2902
2903 Fix minor problems found by GCC 4.6.0 static checking.
2904 * buffer.c (Qclone_number): Remove for now, as it's unused.
2905 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2906 (record_buffer): Remove unused local.
2907 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2908 (set_frame_buffer_list): Remove; unused.
2909 * frame.h (other_visible_frames): Remove decl.
2910 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2911 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2912 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2913 if HAVE_GPM.
2914 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2915 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2916 Define only if HAVE_GPM.
2917 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2918 (update_hints_inhibit): Remove; never set. All uses removed.
2919 * widgetprv.h (emacsFrameClassRec): Remove decl.
2920 * window.c (delete_deletable_window): Now returns void, since it
2921 wasn't returning anything.
2922 (compare_window_configurations): Remove unused locals.
2923 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2924 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2925 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2926 the same widths as pointers. This follows up on the 2011-05-06 patch.
2927 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2928 * xterm.h: Likewise.
2929 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2930
2931 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2932
2933 * makefile.w32-in: Update dependencies.
2934 (LISP_H): Add lib/intprops.h.
2935
2936 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2937
2938 * image.c (gif_load): Add animation frame delay to the metadata.
2939 (syms_of_image): Use DEFSYM. New symbol `delay'.
2940
2941 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2942
2943 * window.c (delete_deletable_window): Re-add.
2944 (Fset_window_configuration): Rewrite to handle dead buffers and
2945 consequently deletable windows.
2946 (window_tree, Fwindow_tree): Remove. Supply functionality in
2947 window.el.
2948 (compare_window_configurations): Simplify code.
2949
2950 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2951
2952 * image.c (imagemagick_load_image): Fix type mismatch.
2953 (Fimagemagick_types): Likewise.
2954
2955 * window.h (replace_buffer_in_windows): Declare.
2956
2957 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2958
2959 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2960 Qclone_number. Remove external declaration of Qdelete_window.
2961 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2962 code.
2963 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2964 Run Qbuffer_list_update_hook if allowed.
2965 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2966 buffer list implementation.
2967 (other_buffer_safely): New function.
2968 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2969 calls to replace_buffer_in_windows and
2970 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2971 if allowed.
2972 (record_buffer): Inhibit quitting and rewrite using quittable
2973 functions. Run Qbuffer_list_update_hook if allowed.
2974 (Frecord_buffer, Funrecord_buffer): New functions.
2975 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2976 Move switch-to-buffer to window.el.
2977 (bury-buffer): Move to window.el.
2978 (Vbuffer_list_update_hook): New variable.
2979
2980 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2981 section.
2982
2983 * window.h (resize_frame_windows): Move up in code.
2984 (Fwindow_frame): Remove EXFUN.
2985 (replace_buffer_in_all_windows): Remove prototype.
2986 (replace_buffer_in_windows_safely): Add prototype.
2987
2988 * window.c: Declare Qdelete_window static again. Move down
2989 declaration of select_count.
2990 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2991 (Fother_window): Move to window.el.
2992 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2993 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2994 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2995 window.el.
2996 (replace_buffer_in_windows): Implement by calling
2997 Qreplace_buffer_in_windows.
2998 (replace_buffer_in_all_windows): Remove with some functionality
2999 moved into replace_buffer_in_windows_safely.
3000 (replace_buffer_in_windows_safely): New function.
3001 (select_window_norecord, select_frame_norecord): Move in front
3002 of run_window_configuration_change_hook. Remove now obsolete
3003 declarations.
3004 (Fset_window_buffer): Rewrite doc-string.
3005 Call Qrecord_window_buffer.
3006 (keys_of_window): Move binding for other-window to window.el.
3007
3008 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3009
3010 * dispextern.h (struct image): Replace data member, whose int_val
3011 and ptr_val fields were not used by anything, with a single
3012 lisp_val object.
3013
3014 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3015 (gif_clear_image, gif_load, imagemagick_load_image)
3016 (gs_clear_image, gs_load): Callers changed.
3017
3018 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3019
3020 * buffer.h: Include <time.h>, for time_t.
3021 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3022
3023 Fix minor problems found by static checking.
3024
3025 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3026
3027 Make identifiers static if they are not used in other modules.
3028 * data.c (Qcompiled_function, Qframe, Qvector):
3029 * image.c (QimageMagick, Qsvg):
3030 * minibuf.c (Qmetadata):
3031 * window.c (resize_window_check, resize_root_window): Now static.
3032 * window.h (resize_window_check, resize_root_window): Remove decls.
3033
3034 * window.c (window_deletion_count, delete_deletable_window):
3035 Remove; unused.
3036 (window_body_lines): Now static.
3037 (Fdelete_other_windows_internal): Mark vars as initialized.
3038 Make sure 'resize_failed' is initialized.
3039 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3040 (resize_window_apply): Remove unused local.
3041 * window.h (delete_deletable_window): Remove decl.
3042
3043 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3044 (imagemagick_load_image): Fix pointer signedness problem by changing
3045 last arg from unsigned char * to char *. All uses changed.
3046 Also, fix a local for similar reasons.
3047 Remove unused locals. Remove locals to avoid shadowing.
3048 (fn_rsvg_handle_free): Remove; unused.
3049 (svg_load, svg_load_image): Fix pointer signedness problem.
3050 (imagemagick_load_image): Don't use garbage pointer image_wand.
3051
3052 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3053
3054 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3055
3056 * image.c (gif_load): Fix omitted cast error introduced by
3057 2011-06-06 change.
3058
3059 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3060
3061 * window.h (resize_proportionally, orig_total_lines)
3062 (orig_top_line): Remove from window structure.
3063 (set_window_height, set_window_width, change_window_heights)
3064 (Fdelete_window): Remove prototypes.
3065 (resize_frame_windows): Remove duplicate declaration.
3066
3067 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3068
3069 * window.h (resize_frame_windows, resize_window_check)
3070 (delete_deletable_window, resize_root_window)
3071 (resize_frame_windows): Declare prototypes.
3072
3073 * window.c (resize_window_apply): Make definition be "static" to
3074 match the prototype.
3075
3076 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3077
3078 * window.c: Remove declarations of Qwindow_size_fixed,
3079 window_min_size_1, window_min_size_2, window_min_size,
3080 size_window, window_fixed_size_p, enlarge_window, delete_window.
3081 Remove static from declaration of Qdelete_window, it's
3082 temporarily needed by Fbury_buffer.
3083 (replace_window): Don't assign orig_top_line and
3084 orig_total_lines.
3085 (Fdelete_window, delete_window): Remove. Window deletion is
3086 handled by window.el.
3087 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3088 Replace Fdelete_window calls with calls to Qdelete_window.
3089 (Fdelete_other_windows): Remove. Deleting other windows is
3090 handled by window.el.
3091 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3092 handled in window.el.
3093 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3094 Window minimum sizes are handled in window.el.
3095 (shrink_windows, size_window, set_window_height)
3096 (set_window_width, change_window_heights, window_height)
3097 (window_width, CURBEG, CURSIZE, enlarge_window)
3098 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3099 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3100 handled in window.el.
3101 (make_dummy_parent): Rename to make_parent_window and give it a
3102 second argument horflag.
3103 (make_window): Don't set resize_proportionally any more.
3104 (Fsplit_window): Remove. Windows are split in window.el.
3105 (save_restore_action, save_restore_orig_size)
3106 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3107 Resize mini windows in window.el.
3108 (grow_mini_window, shrink_mini_window): Implement by calling
3109 Qresize_root_window_vertically, resize_window_check and
3110 resize_window_apply.
3111 (saved_window, Fset_window_configuration, save_window_save):
3112 Do not handle orig_top_line, orig_total_lines, and
3113 resize_proportionally.
3114 (window_min_height, window_min_width): Move to window.el.
3115 (keys_of_window): Move bindings for delete-other-windows,
3116 split-window, delete-window and enlarge-window to window.el.
3117
3118 * buffer.c: Temporarily extern Qdelete_window.
3119 (Fbury_buffer): Temporarily call Qdelete_window instead of
3120 Fdelete_window (Fbury_buffer will move to window.el soon).
3121
3122 * frame.c (set_menu_bar_lines_1): Remove code handling
3123 orig_top_line and orig_total_lines.
3124
3125 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3126 set_window_height but set heights directly.
3127 (change_frame_size_1): Use resize_frame_windows.
3128
3129 * xdisp.c (init_xdisp): Don't use set_window_height but set
3130 heights directly.
3131
3132 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3133 Use resize_frame_windows instead of change_window_heights and run
3134 run_window_configuration_change_hook.
3135
3136 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3137 instead of change_window_heights and run
3138 run_window_configuration_change_hook.
3139
3140 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3141
3142 * window.c (replace_window): Rename second argument REPLACEMENT to
3143 NEW. New third argument SETFLAG. Rewrite.
3144 (delete_window, make_dummy_parent): Call replace_window with
3145 third argument 1.
3146 (window_list_1): Move down in code.
3147 (run_window_configuration_change_hook): Move set_buffer part
3148 before select_frame_norecord part in order to unwind correctly.
3149 Rename count1 to count.
3150 (recombine_windows, delete_deletable_window, resize_root_window)
3151 (Fdelete_other_windows_internal)
3152 (Frun_window_configuration_change_hook, make_parent_window)
3153 (resize_window_check, resize_window_apply, Fresize_window_apply)
3154 (resize_frame_windows, Fsplit_window_internal)
3155 (Fdelete_window_internal, Fresize_mini_window_internal):
3156 New functions.
3157 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3158
3159 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3160
3161 * window.h (window): Add some new members to window structure -
3162 normal_lines, normal_cols, new_total, new_normal, clone_number,
3163 splits, nest, prev_buffers, next_buffers.
3164 (WINDOW_TOTAL_SIZE): Move here from window.c.
3165 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3166
3167 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3168 Remove.
3169 (make_dummy_parent): Set new members of windows structure.
3170 (make_window): Move down in code. Handle new members of window
3171 structure.
3172 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3173 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3174 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3175 (Fset_window_prev_buffers, Fwindow_next_buffers)
3176 (Fset_window_next_buffers, Fset_window_clone_number):
3177 New functions.
3178 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3179 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3180 Doc-string fixes.
3181 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3182 Argument WINDOW can be now internal window too.
3183 (Fwindow_use_time): Move up in code.
3184 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3185 Rewrite doc-string.
3186 (Fset_window_configuration, saved_window)
3187 (Fcurrent_window_configuration, save_window_save): Handle new
3188 members of window structure.
3189 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3190 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3191 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3192 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3193 Qget_mru_window, Qresize_root_window,
3194 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3195 Qauto_buffer_name; staticpro them.
3196
3197 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3198
3199 * window.c (Fwindow_total_size, Fwindow_left_column)
3200 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3201 (Fwindow_list_1): New functions.
3202 (window_box_text_cols): Replace with window_body_cols.
3203 (Fwindow_width, Fscroll_left, Fscroll_right):
3204 Use window_body_cols instead of window_box_text_cols.
3205 (delete_window, Fset_window_configuration):
3206 Call delete_all_subwindows with window as argument.
3207 (delete_all_subwindows): Take a window as argument and not a
3208 structure. Rewrite.
3209 (window_loop): Remove handling of GET_LRU_WINDOW and
3210 GET_LARGEST_WINDOW.
3211 (Fget_lru_window, Fget_largest_window): Move to window.el.
3212
3213 * window.h: Extern window_body_cols instead of
3214 window_box_text_cols. delete_all_subwindows now takes a
3215 Lisp_Object as argument.
3216
3217 * indent.c (compute_motion, Fcompute_motion):
3218 Use window_body_cols instead of window_box_text_cols.
3219
3220 * frame.c (delete_frame): Call delete_all_subwindows with root
3221 window as argument.
3222
3223 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3224
3225 * fns.c (Fputhash): Document return value.
3226
3227 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3228
3229 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3230
3231 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3232
3233 Cons<->int and similar integer overflow fixes (Bug#8794).
3234
3235 Check for overflow when converting integer to cons and back.
3236 * charset.c (Fdefine_charset_internal, Fdecode_char):
3237 Use cons_to_unsigned to catch overflow.
3238 (Fencode_char): Use INTEGER_TO_CONS.
3239 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3240 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3241 * data.c (long_to_cons, cons_to_long): Remove.
3242 (cons_to_unsigned, cons_to_signed): New functions.
3243 These signal an error for invalid or out-of-range values.
3244 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3245 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3246 * font.c (Ffont_variation_glyphs):
3247 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3248 * lisp.h: Include <intprops.h>.
3249 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3250 (cons_to_signed, cons_to_unsigned): New decls.
3251 (long_to_cons, cons_to_long): Remove decls.
3252 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3253 (Fprimitive_undo): Use CONS_TO_INTEGER.
3254 * xfns.c (Fx_window_property): Likewise.
3255 * xselect.c: Include <limits.h>.
3256 (x_own_selection, selection_data_to_lisp_data):
3257 Use INTEGER_TO_CONS.
3258 (x_handle_selection_request, x_handle_selection_clear)
3259 (x_get_foreign_selection, Fx_disown_selection_internal)
3260 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3261 (lisp_data_to_selection_data): Use cons_to_unsigned.
3262 (x_fill_property_data): Use cons_to_signed.
3263 Report values out of range.
3264
3265 Check for buffer and string overflow more precisely.
3266 * buffer.h (BUF_BYTES_MAX): New macro.
3267 * lisp.h (STRING_BYTES_MAX): New macro.
3268 * alloc.c (Fmake_string):
3269 * character.c (string_escape_byte8):
3270 * coding.c (coding_alloc_by_realloc):
3271 * doprnt.c (doprnt):
3272 * editfns.c (Fformat):
3273 * eval.c (verror):
3274 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3275 since they may not be the same number.
3276 * editfns.c (Finsert_char):
3277 * fileio.c (Finsert_file_contents):
3278 Likewise for BUF_BYTES_MAX.
3279
3280 * image.c: Use ptrdiff_t, not int, for sizes.
3281 (slurp_file): Switch from int to ptrdiff_t.
3282 All uses changed.
3283 (slurp_file): Check that file size fits in both size_t (for
3284 malloc) and ptrdiff_t (for sanity and safety).
3285
3286 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3287 if b->modtime has its maximal value.
3288
3289 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3290
3291 Don't assume time_t can fit into int.
3292 * buffer.h (struct buffer.modtime): Now time_t, not int.
3293 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3294 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3295
3296 Minor fixes for signed vs unsigned integers.
3297 * character.h (MAYBE_UNIFY_CHAR):
3298 * charset.c (maybe_unify_char):
3299 * keyboard.c (read_char, reorder_modifiers):
3300 XINT -> XFASTINT, since the integer must be nonnegative.
3301 * ftfont.c (ftfont_spec_pattern):
3302 * keymap.c (access_keymap, silly_event_symbol_error):
3303 XUINT -> XFASTINT, since the integer must be nonnegative.
3304 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3305 since it makes no difference and we prefer signed.
3306 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3307 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3308 nonnegative.
3309
3310 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3311
3312 * window.h (Fwindow_frame): Declare.
3313
3314 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3315
3316 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3317 (SPARE_MEMORY): Always define.
3318 (LARGE_REQUEST): Remove.
3319 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3320
3321 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3322
3323 * lisp.h: Move EXFUNS for Fframe_root_window,
3324 Fframe_first_window and Fset_frame_selected_window to window.h.
3325
3326 * window.h: Move EXFUNS for Fframe_root_window,
3327 Fframe_first_window and Fset_frame_selected_window here from
3328 lisp.h.
3329
3330 * frame.c (Fwindow_frame, Fframe_first_window)
3331 (Fframe_root_window, Fframe_selected_window)
3332 (Fset_frame_selected_window): Move to window.c.
3333 (Factive_minibuffer_window): Move to minibuf.c.
3334 (Fother_visible_frames_p): New function.
3335
3336 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3337
3338 * window.c (decode_window, decode_any_window): Move up in code.
3339 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3340 (inhibit_frame_unsplittable): Remove unused variable.
3341 (Fwindow_buffer): Move up and rewrite doc-string.
3342 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3343 (Fwindow_prev): New functions.
3344 (Fwindow_frame): Move here from frame.c. Accept any window as
3345 argument.
3346 (Fframe_root_window, Fframe_first_window)
3347 (Fframe_selected_window): Move here from frame.c. Accept frame
3348 or arbitrary window as argument. Update doc-strings.
3349 (Fminibuffer_window): Move up in code.
3350 (Fwindow_minibuffer_p): Move up in code and simplify.
3351 (Fset_frame_selected_window): Move here from frame.c.
3352 Marginal rewrite.
3353 (Fselected_window, select_window, Fselect_window): Move up in
3354 code. Minor doc-string fixes.
3355
3356 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3357
3358 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3359 Do not assume that spare memory exists; that assumption is valid
3360 only if SYSTEM_MALLOC.
3361 (LARGE_REQUEST): New macro, so that the issue of large requests
3362 is separated from the issue of spare memory.
3363
3364 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3365
3366 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3367 format. (Bug#8806)
3368
3369 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3370
3371 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3372 before statements.
3373
3374 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3375
3376 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3377
3378 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3379
3380 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3381 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3382
3383 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3384
3385 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3386
3387 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3388
3389 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3390 (x_clipboard_manager_save): Add return value.
3391 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3392 New error handlers.
3393 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3394 Obey Vx_select_enable_clipboard_manager. Catch errors in
3395 x_clipboard_manager_save (Bug#8779).
3396 (Vx_select_enable_clipboard_manager): New variable.
3397 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3398
3399 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3400
3401 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3402
3403 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3404
3405 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3406 in the current matrix if keep_current_p is non-zero.
3407
3408 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3409
3410 * bidi.c (bidi_level_of_next_char): Fix last change.
3411
3412 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3413
3414 Support bidi reordering of text covered by display properties.
3415
3416 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3417 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3418 (bidi_cache_search, bidi_cache_iterator_state)
3419 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3420 (bidi_level_of_next_char, bidi_move_to_visually_next):
3421 Support character positions inside a run of characters covered by a
3422 display string.
3423 (bidi_paragraph_init, bidi_resolve_explicit_1)
3424 (bidi_level_of_next_char): Call bidi_fetch_char and
3425 bidi_fetch_char_advance instead of FETCH_CHAR and
3426 FETCH_CHAR_ADVANCE.
3427 (bidi_init_it): Initialize new members.
3428 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3429 definitions.
3430 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3431 instead of using explicit *_CHAR codes.
3432 (bidi_resolve_explicit, bidi_resolve_weak):
3433 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3434 bidirectional text is supported only in multibyte buffers.
3435 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3436 it to initialize the frame_window_p member of struct bidi_it.
3437 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3438 (bidi_resolve_explicit, bidi_resolve_weak)
3439 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3440 bidi_it->nchars is non-positive.
3441 (bidi_level_of_next_char): Don't try to lookup the cache for the
3442 next/previous character if nothing is cached there yet, or if we
3443 were just reseat()'ed to a new position.
3444
3445 * xdisp.c (set_cursor_from_row): Set start and stop points
3446 according to the row's direction when priming the loop that looks
3447 for the glyph on which to display cursor.
3448 (single_display_spec_intangible_p): Function deleted.
3449 (display_prop_intangible_p): Reimplement to call
3450 handle_display_spec instead of single_display_spec_intangible_p.
3451 Accept 3 additional arguments needed by handle_display_spec.
3452 This fixes incorrect cursor motion across display property with complex
3453 values: lists, `(when COND...)' forms, etc.
3454 (single_display_spec_string_p): Support property values that are
3455 lists with the argument STRING its top-level element.
3456 (display_prop_string_p): Fix the condition for processing a
3457 property that is a list to be consistent with handle_display_spec.
3458 (handle_display_spec): New function, refactored from the
3459 last portion of handle_display_prop.
3460 (compute_display_string_pos): Accept additional argument
3461 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3462 value of a `display' property is a "replacing spec".
3463 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3464 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3465 the display property, but just return a value indicating whether
3466 the display property will replace the characters it covers.
3467 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3468 frame_window_p members of struct bidi_it.
3469 (compute_display_string_pos, compute_display_string_end):
3470 New functions.
3471 (push_it): Accept second argument POSITION, where pop_it should
3472 jump to continue iteration.
3473 (reseat_1): Initialize bidi_it.disp_pos.
3474
3475 * keyboard.c (adjust_point_for_property): Adjust the call to
3476 display_prop_intangible_p to its new signature.
3477
3478 * dispextern.h (struct bidi_it): New member frame_window_p.
3479 (bidi_init_it): Update prototypes.
3480 (display_prop_intangible_p): Update prototype.
3481 (compute_display_string_pos, compute_display_string_end):
3482 Declare prototypes.
3483 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3484 EMACS_INT.
3485
3486 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3487
3488 Malloc failure behavior now depends on size of allocation.
3489 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3490 * lisp.h: Change signatures accordingly.
3491 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3492 All callers changed. (Bug#8762)
3493
3494 * gnutls.c: Use Emacs's memory allocators.
3495 Without this change, the gnutls library would invoke malloc etc.
3496 directly, which causes problems on non-SYNC_INPUT hosts, and which
3497 runs afoul of improving memory_full behavior. (Bug#8761)
3498 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3499 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3500 xfree instead of the default malloc, realloc, free.
3501 (Fgnutls_boot): No need to check for memory allocation failure,
3502 since xmalloc does that for us.
3503
3504 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3505 * category.c (hash_get_category_set):
3506 * ccl.c (ccl_driver):
3507 * charset.c (Fdefine_charset_internal):
3508 * charset.h (struct charset.hash_index):
3509 * composite.c (get_composition_id, gstring_lookup_cache)
3510 (composition_gstring_put_cache):
3511 * composite.h (struct composition.hash_index):
3512 * dispextern.h (struct image.hash):
3513 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3514 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3515 (hashfn_equal, hashfn_user_defined, make_hash_table)
3516 (maybe_resize_hash_table, hash_lookup, hash_put)
3517 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3518 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3519 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3520 * image.c (make_image, search_image_cache, lookup_image)
3521 (xpm_put_color_table_h):
3522 * lisp.h (struct Lisp_Hash_Table):
3523 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3524 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3525 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3526 * alloc.c (allocate_vectorlike):
3527 Check for overflow in vector size calculations.
3528 * ccl.c (ccl_driver):
3529 Check for overflow when converting EMACS_INT to int.
3530 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3531 need to be updated by these changes.
3532 * fns.c (make_hash_table, maybe_resize_hash_table):
3533 Check for integer overflow with large hash tables.
3534 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3535 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3536 (SXHASH_REDUCE): New macro.
3537 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3538 Use it instead of discarding useful hash info with large hash values.
3539 (sxhash_float): New function.
3540 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3541 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3542 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3543 Rewrite to use FIXNUM_BITS, as this simplifies things.
3544 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3545 Adjust signatures to match updated version of code.
3546 (consing_since_gc): Now EMACS_INT, since a single hash table can
3547 use more than INT_MAX bytes.
3548
3549 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3550
3551 Make it possible to build with GCC-4.6+ -O2 -flto.
3552
3553 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3554
3555 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3556
3557 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3558 Call minibuffer-inactive-mode.
3559
3560 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3561
3562 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3563 Update dependencies.
3564
3565 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3566
3567 * data.c (init_data): Remove code for UTS, this system is not
3568 supported anymore.
3569
3570 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3571
3572 Don't force ./temacs to start in terminal mode.
3573
3574 * frame.c (make_initial_frame): Initialize faces in all cases, not
3575 only when CANNOT_DUMP is defined.
3576 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3577
3578 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3579
3580 * dispnew.c (add_window_display_history): Use const for the string
3581 pointer. Remove declaration, not needed.
3582
3583 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3584
3585 Use 'inline', not 'INLINE'.
3586 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3587 * alloc.c, fontset.c (INLINE): Remove.
3588 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3589 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3590 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3591 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3592 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3593
3594 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3595
3596 Make it possible to run ./temacs.
3597
3598 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3599 syms_of_callproc does the same thing. Remove test for
3600 "initialized", do it in the caller.
3601 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3602
3603 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3604
3605 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3606 (read_minibuf): Use get_minibuffer.
3607 (syms_of_minibuf): Use DEFSYM.
3608 (Qmetadata): New var.
3609 * data.c (Qbuffer): Don't make it static.
3610 (syms_of_data): Use DEFSYM.
3611
3612 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3613
3614 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3615 (CCL_CODE_MIN): New macro.
3616
3617 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3618
3619 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3620
3621 * eval.c (Qdebug): Now static.
3622 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3623 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3624 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3625
3626 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3627
3628 * image.c: Various fixes to ImageMagick code comments.
3629 (Fimagemagick_types): Doc fix.
3630
3631 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3632
3633 Minor fixes prompted by GCC 4.6.0 warnings.
3634
3635 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3636
3637 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3638 (x_clipboard_manager_save_all): Move extern decl to ...
3639 * xterm.h: ... here, so that it can be checked for consistency.
3640
3641 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3642
3643 * xselect.c (x_clipboard_manager_save_frame)
3644 (x_clipboard_manager_save_all): New functions.
3645 (Fx_clipboard_manager_save): Lisp function deleted.
3646
3647 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3648 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3649
3650 * xterm.h: Update prototype.
3651
3652 2011-05-28 William Xu <william.xwl@gmail.com>
3653
3654 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3655 exiting (Bug#8239).
3656
3657 2011-05-28 Jim Meyering <meyering@redhat.com>
3658
3659 Avoid a sign-extension bug in crypto_hash_function.
3660 * fns.c (to_uchar): Define.
3661 (crypto_hash_function): Use it to convert some newly-signed
3662 variables to unsigned, to avoid sign-extension bugs. For example,
3663 without this change, (md5 "truc") would evaluate to
3664 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3665 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3666 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3667
3668 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3669
3670 Integer overflow fixes.
3671
3672 * dbusbind.c: Serial number integer overflow fixes.
3673 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3674 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3675 to hold a serial number that is too large for a fixnum.
3676 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3677 Check for serial numbers out of range. Decode any serial number
3678 that was so large that it became a float. (Bug#8722)
3679
3680 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3681 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3682 Use XFASTINT rather than XUINT when numbers are nonnegative.
3683 (xd_append_arg, Fdbus_method_return_internal):
3684 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3685 arguments, check that Lisp number is nonnegative, rather than
3686 silently wrapping negative numbers around. (Bug#8722)
3687 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3688 (Bug#8722)
3689
3690 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3691
3692 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3693
3694 ccl: add integer overflow checks
3695 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3696 (IN_INT_RANGE): New macros.
3697 (ccl_driver): Use them to check for integer overflow when
3698 decoding a CCL program. Many of the new checks are whether XINT (x)
3699 fits in int; it doesn't always, on 64-bit hosts. The new version
3700 doesn't catch all possible integer overflows, but it's an
3701 improvement. (Bug#8719)
3702
3703 * alloc.c (make_event_array): Use XINT, not XUINT.
3704 There's no need for unsigned here.
3705
3706 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3707 This follows up to the 2011-05-06 change that substituted uintptr_t
3708 for EMACS_INT. This case wasn't caught back then.
3709
3710 Rework Fformat to avoid integer overflow issues.
3711 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3712 now (part of C89). Include <verify.h>.
3713 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3714 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3715 (Fformat): Avoid the prepass trying to compute sizes; it was only
3716 approximate and thus did not catch overflow reliably. Instead, walk
3717 through the format just once, formatting and computing sizes as we go,
3718 checking for integer overflow at every step, and allocating a larger
3719 buffer as needed. Keep track separately whether the format is
3720 multibyte. Keep only the most-recently calculated precision, rather
3721 than them all. Record whether each argument has been converted to
3722 string. Use EMACS_INT, not int, for byte and char and arg counts.
3723 Support field widths and precisions larger than INT_MAX. Avoid
3724 sprintf's undefined behavior with conversion specifications such as %#d
3725 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3726 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3727 formatting out-of-range floating point numbers with int
3728 formats. (Bug#8668)
3729
3730 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3731
3732 * data.c: Avoid integer truncation in expressions involving floats.
3733 * data.c: Include <intprops.h>.
3734 (arith_driver): When there's an integer overflow in an expression
3735 involving floating point, convert the integers to floating point
3736 so that the resulting value does not suffer from catastrophic
3737 integer truncation. For example, on a 64-bit host (* 4
3738 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3739 Do not rely on undefined behavior after integer overflow.
3740
3741 merge count_size_as_multibyte, parse_str_to_multibyte
3742 * character.c, character.h (count_size_as_multibyte):
3743 Rename from parse_str_to_multibyte; all uses changed.
3744 Check for integer overflow.
3745 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3746 since it's now a duplicate of the other. This is more of
3747 a character than a buffer op, so better that it's in character.c.
3748 * fns.c, print.c: Adjust to above changes.
3749
3750 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3751
3752 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3753
3754 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3755
3756 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3757 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3758 (x_clipboard_manager_save): Now static.
3759 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3760
3761 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3762 (crypto_hash_function): Now static.
3763 Fix pointer signedness problems. Avoid unnecessary initializations.
3764
3765 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3766
3767 * termhooks.h (Vselection_alist): Make it terminal-local.
3768
3769 * terminal.c (create_terminal): Initialize it.
3770
3771 * xselect.c: Support for clipboard managers.
3772 (Vselection_alist): Move to termhooks.h as terminal-local var.
3773 (LOCAL_SELECTION): New macro.
3774 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3775 (symbol_to_x_atom): Remove gratuitous arg.
3776 (x_handle_selection_request, lisp_data_to_selection_data)
3777 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3778 (x_own_selection, x_get_local_selection, x_convert_selection):
3779 New arg, specifying work frame. Use terminal-local Vselection_alist.
3780 (some_frame_on_display): Delete unused function.
3781 (Fx_own_selection_internal, Fx_get_selection_internal)
3782 (Fx_disown_selection_internal, Fx_selection_owner_p)
3783 (Fx_selection_exists_p): New optional frame arg.
3784 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3785 (x_handle_selection_clear): Don't treat other terminals with the
3786 same keyboard specially. Use the terminal-local Vselection_alist.
3787 (x_clear_frame_selections): Use Frun_hook_with_args.
3788
3789 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3790
3791 * xterm.h: Add support for those atoms.
3792
3793 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3794
3795 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3796 (converted_selections, conversion_fail_tag): New global variables.
3797 (x_selection_request_lisp_error): Free the above.
3798 (x_get_local_selection): Remove unnecessary code.
3799 (x_reply_selection_request): Args changed; handle arbitrary array
3800 of converted selections stored in converted_selections.
3801 Separate the XChangeProperty and SelectionNotify steps.
3802 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3803 (x_convert_selection): New function.
3804 (x_handle_selection_event): Simplify.
3805 (x_get_foreign_selection): Don't ignore incoming requests while
3806 waiting for an answer; this will fail when we implement
3807 SAVE_TARGETS, and seems unnecessary anyway.
3808 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3809 (Vx_sent_selection_functions): Doc fix.
3810
3811 2011-05-26 Leo Liu <sdl.web@gmail.com>
3812
3813 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3814
3815 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3816
3817 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3818
3819 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3820 for fringe update if it has periodic bitmap.
3821 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3822 and fringe_bitmap_periodic_p.
3823
3824 * fringe.c (get_fringe_bitmap_data): New function.
3825 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3826 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3827 row. Mark glyph row for fringe update if periodicity changed.
3828
3829 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3830 for fringe update unless it has periodic bitmap.
3831
3832 2011-05-25 Kenichi Handa <handa@m17n.org>
3833
3834 * xdisp.c (get_next_display_element): Set correct it->face_id for
3835 a static composition.
3836
3837 2011-05-24 Leo Liu <sdl.web@gmail.com>
3838
3839 * deps.mk (fns.o):
3840 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3841
3842 * fns.c (crypto_hash_function, Fsha1): New function.
3843 (Fmd5): Use crypto_hash_function.
3844 (syms_of_fns): Add Ssha1.
3845
3846 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3847
3848 * gnutls.c: Remove unused macros.
3849 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3850 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3851 Remove macros that are defined and never used.
3852 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3853
3854 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3855
3856 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3857 (Fx_get_selection_internal): Minor cleanup.
3858 (Fx_own_selection_internal): Rename arguments for consistency with
3859 select.el.
3860
3861 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3862
3863 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3864
3865 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3866
3867 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3868
3869 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3870
3871 * dispnew.c (scrolling_window): Don't exclude the case that the
3872 last enabled row in the desired matrix touches the bottom boundary.
3873
3874 2011-05-21 Glenn Morris <rgm@gnu.org>
3875
3876 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3877 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3878 and add some more files.
3879
3880 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3881
3882 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3883 report_file_error introduced by the change from 2011-05-07.
3884
3885 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3886
3887 * systime.h (Time): Define only if emacs is defined.
3888 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3889 where the include path doesn't have X11/X.h by default. See
3890 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3891
3892 2011-05-20 Kenichi Handa <handa@m17n.org>
3893
3894 * composite.c (find_automatic_composition): Fix previous change.
3895
3896 2011-05-20 Glenn Morris <rgm@gnu.org>
3897
3898 * lisp.mk: New file, split from Makefile.in.
3899 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3900 (shortlisp): Remove.
3901 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3902
3903 2011-05-19 Glenn Morris <rgm@gnu.org>
3904
3905 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3906 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3907 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3908 (lisp): Set the order to that of loadup.el.
3909 (shortlisp): Make it a copy of $lisp.
3910 (SOME_MACHINE_LISP): Remove.
3911 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3912 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3913
3914 2011-05-18 Kenichi Handa <handa@m17n.org>
3915
3916 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3917 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3918 (find_automatic_composition): Mostly rewrite for efficiency.
3919
3920 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3921
3922 * makefile.w32-in: Update dependencies.
3923
3924 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3925
3926 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3927 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3928
3929 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3930
3931 Fix some integer overflow issues, such as string length overflow.
3932
3933 * insdel.c (count_size_as_multibyte): Check for string overflow.
3934
3935 * character.c (lisp_string_width): Check for string overflow.
3936 Use EMACS_INT, not int, for string indexes and lengths; in
3937 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3938 the resulting string length overflows an EMACS_INT; instead,
3939 report a string overflow if no precision given. When checking for
3940 precision exhaustion, use a check that cannot possibly have
3941 integer overflow. (Bug#8675)
3942 * character.h (lisp_string_width): Adjust to new signature.
3943
3944 * alloc.c (string_overflow): New function.
3945 (Fmake_string): Use it. This doesn't change behavior, but saves
3946 a few bytes and will simplify future changes.
3947 * character.c (string_escape_byte8): Likewise.
3948 * lisp.h (string_overflow): New decl.
3949
3950 Fixups, following up to the user-interface timestamp change.
3951 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3952 for UI timestamps, instead of unsigned long.
3953 * msdos.c (mouse_get_pos): Likewise.
3954 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3955 * w32gui.h (Time): Define by including "systime.h" rather than by
3956 declaring it ourselves. (Bug#8664)
3957
3958 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3959 * image.c (clear_image_cache): Likewise.
3960
3961 * term.c (term_mouse_position): Don't assume time_t wraparound.
3962
3963 Be more systematic about user-interface timestamps.
3964 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3965 and sometimes 'EMACS_UINT', to represent these timestamps.
3966 This change causes it to use 'Time' uniformly, as that's what X uses.
3967 This makes the code easier to follow, and makes it easier to catch
3968 integer overflow bugs such as Bug#8664.
3969 * frame.c (Fmouse_position, Fmouse_pixel_position):
3970 Use Time, not unsigned long, for user-interface timestamps.
3971 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3972 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3973 * keyboard.h (last_event_timestamp): Likewise.
3974 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3975 * menu.h (xmenu_show): Likewise.
3976 * term.c (term_mouse_position): Likewise.
3977 * termhooks.h (struct input_event.timestamp): Likewise.
3978 (struct terminal.mouse_position_hook): Likewise.
3979 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3980 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3981 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3982 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3983 what it was before.
3984 * menu.h, termhooks.h: Include "systime.h", for Time.
3985
3986 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3987 Don't assume that the difference between two unsigned long values
3988 can fit into an integer. At this point, we know button_down_time
3989 <= event->timestamp, so the difference must be nonnegative, so
3990 there's no need to cast the result if double-click-time is
3991 nonnegative, as it should be; check that it's nonnegative, just in
3992 case. This bug is triggered when events are more than 2**31 ms
3993 apart (about 25 days). (Bug#8664)
3994
3995 * xselect.c (last_event_timestamp): Remove duplicate decl.
3996 (x_own_selection): Remove needless cast to unsigned long.
3997
3998 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3999 that always fit in int. Use a sentinel instead of a counter, to
4000 avoid a temp and to allay GCC's concerns about possible int overflow.
4001 * frame.h (struct frame): Use int for menu_bar_items_used
4002 instead of EMACS_INT, since it always fits in int.
4003
4004 * menu.c (grow_menu_items): Check for int overflow.
4005
4006 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4007
4008 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4009 Before, the code was not consistent. These values cannot exceed
4010 2**31 - 1 so there's no need to make them unsigned.
4011 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4012 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4013 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4014 as modifiers.
4015 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4016
4017 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4018 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4019 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4020 presumably because the widths might not match.
4021
4022 * window.c (size_window): Avoid needless test at loop start.
4023
4024 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4025
4026 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4027
4028 2011-05-12 Drew Adams <drew.adams@oracle.com>
4029
4030 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4031
4032 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4033
4034 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4035 `width' to `bar_area_x' and `bar_area_width', respectively.
4036 (x_scroll_run): Take account of fringe background extension.
4037
4038 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4039 Rename local vars `left' and `width' to `bar_area_x' and
4040 `bar_area_width', respectively.
4041 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4042 background extension.
4043
4044 2011-05-10 Jim Meyering <meyering@redhat.com>
4045
4046 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4047
4048 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4049
4050 * image.c (Finit_image_library): Return t for built-in image types,
4051 like pbm and xbm. (Bug#8640)
4052
4053 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4054
4055 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4056
4057 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4058
4059 * w32console.c (Fset_screen_color): Doc fix.
4060 (Fget_screen_color): New function.
4061 (syms_of_ntterm): Defsubr it.
4062
4063 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4064 unlink the temporary file if Fcall_process didn't create it in the
4065 first place.
4066 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4067 child process will be redirected to a file specified with `:file'.
4068 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4069 cue to call_process_cleanup not to close that handle.
4070
4071 2011-05-07 Ben Key <bkey76@gmail.com>
4072
4073 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4074 one of two shell specific rules, either bootstrap-temacs-CMD or
4075 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4076 to the previous implementation of the bootstrap-temacs rule.
4077 The bootstrap-temacs-CMD rule is similar to the previous
4078 implementation of the bootstrap-temacs rule except that it
4079 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4080 variable.
4081
4082 These changes, along with some changes to nt/configure.bat,
4083 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4084 earlier fix to add support for --cflags and --ldflags options
4085 that include quotes so that it works whether make uses cmd or
4086 sh as the shell.
4087
4088 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4089
4090 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4091 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4092 is a constant.
4093 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4094 a string. Handle both cases.
4095 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4096 (Fdbus_register_method): Use Qinvalid_function.
4097
4098 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4099
4100 * makefile.w32-in: Update dependencies.
4101 (LISP_H): Add inttypes.h and stdin.h.
4102 (PROCESS_H): Add unistd.h.
4103
4104 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4105
4106 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4107 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4108
4109 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4110
4111 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4112
4113 * term.c (vfatal): Remove stray call to va_end.
4114 It's not needed and the C Standard doesn't allow it here anyway.
4115
4116 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4117 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4118
4119 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4120 bytes.
4121
4122 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4123
4124 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4125
4126 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4127
4128 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4129
4130 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4131
4132 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4133 * charset.c (Fdefine_charset_internal): Don't initialize
4134 charset.code_space[15]. The value was garbage, on hosts with
4135 32-bit int (Bug#8600).
4136
4137 * lread.c (read_integer): Be more consistent with string-to-number.
4138 Use string_to_number to do the actual conversion; this avoids
4139 rounding errors and fixes some other screwups. Without this fix,
4140 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4141 (digit_to_number): Move earlier, for benefit of read_integer.
4142 Return -1 if the digit is out of range for the base, -2 if it is
4143 not a digit in any supported base. (Bug#8602)
4144
4145 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4146
4147 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4148 to match comment at start of function. This also removes a
4149 GCC warning about overflow in a 32+64-bit port.
4150
4151 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4152
4153 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4154 Reported by Stefan Monnier in
4155 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4156 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4157 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4158
4159 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4160 (EMACS_UINTPTR): Likewise, with uintptr_t.
4161
4162 * lisp.h: Prefer 64-bit EMACS_INT if available.
4163 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4164 on 32-bit hosts that have 64-bit int, so that they can access
4165 large files.
4166 However, temporarily disable this change unless the temporary
4167 symbol WIDE_EMACS_INT is defined.
4168
4169 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4170
4171 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4172 This removes an assumption that EMACS_INT and long are the same
4173 width as pointers. The assumption is true for Emacs porting targets
4174 now, but we want to make other targets possible.
4175 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4176 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4177 In the rest of the code, change types of integers that hold casted
4178 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4179 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4180 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4181 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4182 No need to cast type when ORing.
4183 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4184 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4185 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4186 assume EMACS_INT is the same width as char *.
4187 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4188 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4189 Remove no-longer-needed casts.
4190 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4191 (xg_tool_bar_help_callback, xg_make_tool_item):
4192 Use EMACS_INTPTR to hold an integer
4193 that will be cast to void *; this can avoid a GCC warning
4194 if EMACS_INT is not the same width as void *.
4195 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4196 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4197 (current_message_1, set_message_1):
4198 Use a local to convert to proper width without a cast.
4199 * xmenu.c (dialog_selection_callback): Likewise.
4200
4201 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4202 Also, don't assume VALBITS / RAND_BITS is less than 5,
4203 and don't rely on undefined behavior when shifting a 1 left into
4204 the sign bit.
4205 * lisp.h (get_random): Change signature to match.
4206
4207 * lread.c (hash_string): Use size_t, not int, for hash computation.
4208 Normally we prefer signed values; but hashing is special, because
4209 it's better to use unsigned division on hash table sizes so that
4210 the remainder is nonnegative. Also, size_t is the natural width
4211 for hashing into memory. The previous code used 'int', which doesn't
4212 retain enough info to hash well into very large tables.
4213 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4214
4215 * dbusbind.c: Don't possibly lose pointer info when converting.
4216 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4217 Use XPNTR rather than XHASH, so that the high-order bits of
4218 the pointer aren't lost when converting through void *.
4219
4220 * eval.c (Fautoload): Don't double-shift a pointer.
4221
4222 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4223
4224 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4225
4226 * gnutls.c (DEF_GNUTLS_FN):
4227 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4228
4229 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4230
4231 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4232 marker. (Bug#8610)
4233
4234 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4235
4236 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4237 New version that can reserve upto 2GB of heap space.
4238
4239 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4240
4241 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4242
4243 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4244
4245 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4246 `gnutls_certificate_set_x509_key_file'.
4247
4248 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4249
4250 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4251 Update dependencies.
4252
4253 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4254
4255 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4256 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4257 Remove unused parameter `fildes'.
4258 * process.c (read_process_output, send_process): Don't pass it.
4259
4260 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4261
4262 Fix previous change: the library cache is defined in w32.c.
4263 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4264 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4265
4266 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4267
4268 Implement dynamic loading of GnuTLS on Windows.
4269
4270 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4271 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4272 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4273 Declare.
4274
4275 * gnutls.c (Qgnutls_dll): Define.
4276 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4277 (gnutls_*): Declare function pointers.
4278 (init_gnutls_functions): New function to initialize function pointers.
4279 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4280 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4281 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4282 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4283 (emacs_gnutls_write, emacs_gnutls_read)
4284 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4285 (Fgnutls_available_p): New function.
4286 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4287 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4288 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4289
4290 * image.c: Include w32.h.
4291 (Vimage_type_cache): Delete.
4292 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4293 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4294 (w32_delayed_load): Move to w32.c.
4295
4296 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4297
4298 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4299 (w32_delayed_load): Move from image.c. When loading a library, record
4300 its filename in the :loaded-from property of the library id.
4301 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4302 Initialize and staticpro them.
4303 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4304
4305 * process.c: Include lisp.h before w32.h, not after.
4306 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4307 instead of gnutls_record_check_pending.
4308
4309 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4310
4311 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4312
4313 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4314 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4315 as passed in.
4316
4317 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4318
4319 * xterm.c (x_set_frame_alpha): Do not set property on anything
4320 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4321
4322 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4323
4324 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4325
4326 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4327
4328 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4329 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4330 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4331 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4332 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4333 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4334 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4335 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4336 (Qgnutls_bootprop_callbacks_verify): Make static.
4337
4338 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4339
4340 * callproc.c: Indentation fixup.
4341
4342 * sysdep.c (wait_for_termination_1): Make static.
4343 (wait_for_termination, interruptible_wait_for_termination):
4344 Move after wait_for_termination_1.
4345
4346 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4347
4348 * sysdep.c (interruptible_wait_for_termination): New function
4349 which is like wait_for_termination, but allows keyboard
4350 interruptions.
4351
4352 * callproc.c (Fcall_process): Add (:file "file") as an option for
4353 the STDOUT buffer.
4354 (Fcall_process_region): Ditto.
4355
4356 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4357
4358 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4359 rather than `XVECTOR (FOO)->size'.
4360
4361 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4362 inttypes.h, as a gnulib replacement is used if it not available in
4363 system headers.
4364
4365 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4366
4367 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4368 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4369 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4370
4371 * coding.c (coding_alloc_by_realloc): Error out if destination
4372 will grow beyond MOST_POSITIVE_FIXNUM.
4373 (decode_coding_emacs_mule): Abort if there isn't enough place in
4374 charbuf for the composition carryover bytes. Reserve an extra
4375 space for up to 2 characters produced in a loop.
4376 (decode_coding_iso_2022): Abort if there isn't enough place in
4377 charbuf for the composition carryover bytes.
4378
4379 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4380
4381 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4382 aborting when %lld or %lll format is passed.
4383 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4384 %llo or %llx format is passed. (Bug#8545)
4385
4386 * window.c (window_scroll_line_based): Use a marker instead of
4387 simple variables to record original value of point. (Bug#7952)
4388
4389 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4390 produced by %s or %c overflows available buffer space. (Bug#8545)
4391
4392 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4393
4394 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4395 (SIZE_MAX): Move defn after all includes, as they might #define it.
4396
4397 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4398
4399 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4400
4401 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4402
4403 * keyboard.c (Qdelayed_warnings_hook): Define.
4404 (command_loop_1): Run `delayed-warnings-hook'
4405 if Vdelayed_warnings_list is non-nil.
4406 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4407 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4408
4409 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4410
4411 * doprnt.c (doprnt): Don't return value smaller than the buffer
4412 size if the message was truncated. (Bug#8545).
4413
4414 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4415
4416 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4417 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4418
4419 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4420
4421 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4422
4423 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4424
4425 * makefile.w32-in: Update dependencies.
4426
4427 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4428
4429 Improve `doprnt' and its usage. (Bug#8545)
4430 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4431 `format_end'. Remove support for %l as a conversion specifier.
4432 Don't use xrealloc. Improve diagnostics when the %l size modifier
4433 is used. Update the commentary.
4434
4435 * eval.c (verror): Simplify calculation of size_t.
4436
4437 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4438 messages.
4439
4440 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4441
4442 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4443 change.
4444
4445 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4446
4447 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4448 This makes this file independent of the recent pseudovector change.
4449
4450 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4451
4452 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4453
4454 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4455 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4456 Remove unused local.
4457 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4458
4459 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4460 GCC 4.6.0 optimizes based on type-based alias analysis.
4461 For example, if b is of type struct buffer * and v of type struct
4462 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4463 != &v->size, and therefore "v->size = 1; b->size = 2; return
4464 v->size;" must therefore return 1. This assumption is incorrect
4465 for Emacs, since it type-puns struct Lisp_Vector * with many other
4466 types. To fix this problem, this patch adds a new type struct
4467 vectorlike_header that documents the constraints on layout of vectors
4468 and pseudovectors, and helps optimizing compilers not get fooled
4469 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4470 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4471 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4472 the size member.
4473 (XSETPVECTYPE): Rewrite in terms of new macro.
4474 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4475 This is a bit clearer, and further avoids the possibility of
4476 undesirable aliasing.
4477 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4478 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4479 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4480 since Lisp_Subr is a special case (no "next" field).
4481 (ASIZE): Now uses header.size rather than size.
4482 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4483 to avoid the hassle of writing XVECTOR (foo)->header.size.
4484 (struct vectorlike_header): New type.
4485 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4486 object, to help avoid aliasing.
4487 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4488 (SUBRP): Likewise, since Lisp_Subr is a special case.
4489 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4490 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4491 (struct Lisp_Hash_Table): Combine first two members into a single
4492 struct vectorlike_header member. All uses of "size" and "next" members
4493 changed to be "header.size" and "header.next".
4494 * buffer.h (struct buffer): Likewise.
4495 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4496 * frame.h (struct frame): Likewise.
4497 * process.h (struct Lisp_Process): Likewise.
4498 * termhooks.h (struct terminal): Likewise.
4499 * window.c (struct save_window_data, struct saved_window): Likewise.
4500 * window.h (struct window): Likewise.
4501 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4502 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4503 * buffer.c (init_buffer_once): Likewise.
4504 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4505 special case.
4506 * process.c (Fformat_network_address): Use local var for size,
4507 for brevity.
4508
4509 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4510
4511 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4512 * data.c (atof): Remove decl; no longer used or needed.
4513 (digit_to_number): Move to lread.c.
4514 (Fstring_to_number): Use new string_to_number function, to be
4515 consistent with how the Lisp reader treats infinities and NaNs.
4516 Do not assume that floating-point numbers represent EMACS_INT
4517 without losing information; this is not true on most 64-bit hosts.
4518 Avoid double-rounding errors, by insisting on integers when
4519 parsing non-base-10 numbers, as the documentation specifies.
4520 * lisp.h (string_to_number): New decl, replacing ...
4521 (isfloat_string): Remove.
4522 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4523 (read1): Do not accept +. and -. as integers; this
4524 appears to have been a coding error. Similarly, do not accept
4525 strings like +-1e0 as floating point numbers. Do not report
4526 overflow for integer overflows unless the base is not 10 which
4527 means we have no simple and reliable way to continue.
4528 Break out the floating-point parsing into a new
4529 function string_to_number, so that Fstring_to_number parses
4530 floating point numbers consistently with the Lisp reader.
4531 (digit_to_number): Move here from data.c. Make it static inline.
4532 (E_CHAR, EXP_INT): Remove, replacing with ...
4533 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4534 (string_to_number): New function, replacing isfloat_string.
4535 This function checks for valid syntax and produces the resulting
4536 Lisp float number too. Rework it so that string-to-number
4537 no longer mishandles examples like "1.0e+". Use strtoumax,
4538 so that overflow for non-base-10 numbers is reported only when
4539 there's no portable and simple way to convert to floating point.
4540
4541 * textprop.c (set_text_properties_1): Rewrite for clarity,
4542 and to avoid GCC warning about integer overflow.
4543
4544 * intervals.h (struct interval): Use EMACS_INT for members
4545 where EMACS_UINT might cause problems. See
4546 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4547 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4548 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4549 All uses changed.
4550 (offset_intervals): Tell GCC not to worry about length overflow
4551 when negating a negative length.
4552
4553 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4554 (overrun_check_free): Likewise.
4555
4556 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4557 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4558 word size.
4559
4560 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4561 (gnutls_make_error): Rename local to avoid shadowing.
4562 (gnutls_emacs_global_deinit): ifdef out; not used.
4563 (Fgnutls_boot): Use const for pointer to readonly storage.
4564 Comment out unused local. Fix pointer signedness problems.
4565
4566 * lread.c (openp): Don't stuff size_t into an 'int'.
4567 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4568 about possible signed overflow.
4569
4570 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4571 (GDK_KEY_g): Don't define if already defined.
4572 (xg_prepare_tooltip): Avoid pointer signedness problem.
4573 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4574
4575 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4576 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4577
4578 * xfns.c (Fx_window_property): Simplify a bit,
4579 to make a bit faster and to avoid GCC 4.6.0 warning.
4580 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4581
4582 * fns.c (internal_equal): Don't assume size_t fits in int.
4583
4584 * alloc.c (compact_small_strings): Tighten assertion a little.
4585
4586 Replace pEd with more-general pI, and fix some printf arg casts.
4587 * lisp.h (pI): New macro, generalizing old pEd macro to other
4588 conversion specifiers. For example, use "...%"pI"d..." rather
4589 than "...%"pEd"...".
4590 (pEd): Remove. All uses replaced with similar uses of pI.
4591 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4592 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4593 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4594 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4595 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4596 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4597 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4598 64-bit hosts.
4599 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4600 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4601 * print.c (safe_debug_print, print_object): Likewise.
4602 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4603 to int.
4604 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4605 avoiding the 0 flag, which is not portable.
4606 * process.c (Fmake_network_process): Use pI to avoid cast.
4607 * region-cache.c (pp_cache): Likewise.
4608 * xdisp.c (decode_mode_spec): Likewise.
4609 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4610 behavior on 64-bit hosts with printf arg.
4611 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4612 (x_stop_queuing_selection_requests): Likewise.
4613 (x_get_window_property): Don't truncate byte count to an 'int'
4614 when tracing.
4615
4616 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4617 here, since it parses constructs like leading '-' and spaces,
4618 which are not wanted; and it overflows with large numbers.
4619 Instead, simply match F[0-9]+, which is what is wanted anyway.
4620
4621 * alloc.c: Remove unportable assumptions about struct layout.
4622 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4623 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4624 (allocate_vectorlike, make_pure_vector): Use the new macros,
4625 plus offsetof, to remove unportable assumptions about struct layout.
4626 These assumptions hold on all porting targets that I know of, but
4627 they are not guaranteed, they're easy to remove, and removing them
4628 makes further changes easier.
4629
4630 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4631 This doesn't fix a bug but makes the code clearer.
4632 (string_overrun_cookie): Now const. Use initializers that
4633 don't formally overflow signed char, to avoid warnings.
4634 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4635 can cause Emacs to crash when string overrun checking is enabled.
4636 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4637 multiple of sizeof (EMACS_INT); it need not be, if
4638 alignof(EMACS_INT) < sizeof (EMACS_INT).
4639 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4640
4641 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4642
4643 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4644
4645 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4646
4647 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4648 supposed to be handshaking. (Bug#8556)
4649 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4650
4651 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4652
4653 * lisp.h (Qdebug): List symbol.
4654 * eval.c (Qdebug): Restore global linkage.
4655 * keyboard.c (debug-on-event): New variable.
4656 (handle_user_signal): Break into debugger when debug-on-event
4657 matches the current signal symbol.
4658
4659 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4660
4661 * alloc.c (check_sblock, check_string_bytes)
4662 (check_string_free_list): Convert to standard C.
4663
4664 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4665
4666 * w32.c (emacs_gnutls_push): Fix typo.
4667
4668 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4669
4670 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4671 "cast to pointer from integer of different size".
4672
4673 Improve doprnt and its use in verror. (Bug#8545)
4674 * doprnt.c (doprnt): Document the set of format control sequences
4675 supported by the function. Use SAFE_ALLOCA instead of always
4676 using `alloca'.
4677
4678 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4679 is one byte too soon. Don't use xrealloc; instead xfree and
4680 xmalloc anew.
4681
4682 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4683
4684 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4685 callbacks stage.
4686
4687 * gnutls.c: Renamed global_initialized to
4688 gnutls_global_initialized. Added internals for the
4689 :verify-hostname-error, :verify-error, and :verify-flags
4690 parameters of `gnutls-boot' and documented those parameters in the
4691 docstring. Start callback support.
4692 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4693 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4694 on error. Return error code.
4695 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4696 (emacs_gnutls_read): Likewise.
4697 (Fgnutls_boot): Return handshake error code.
4698 (emacs_gnutls_handle_error): New function.
4699 (wsaerror_to_errno): Likewise.
4700
4701 * w32.h (emacs_gnutls_pull): Add prototype.
4702 (emacs_gnutls_push): Likewise.
4703
4704 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4705 (emacs_gnutls_push): Likewise.
4706
4707 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4708
4709 * process.c (wait_reading_process_output): Check if GnuTLS
4710 buffered some data internally if no FDs are set for TLS
4711 connections.
4712
4713 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4714 (LIBS): Link to USER_LIBS.
4715 ($(BLD)/gnutls.$(0)): New target.
4716
4717 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4718
4719 * xdisp.c (handle_single_display_spec): Rename the
4720 display_replaced_before_p argument into display_replaced_p, to
4721 make it consistent with the commentary. Fix typos in the
4722 commentary.
4723
4724 * textprop.c (syms_of_textprop): Remove dead code.
4725 (copy_text_properties): Delete obsolete commentary about an
4726 interface that was deleted long ago. Fix typos in the description
4727 of arguments.
4728
4729 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4730 to changes in oldXMenu/XMenu.h from 2011-04-16.
4731 <menu_help_message, prev_menu_help_message>: Constify.
4732 (IT_menu_make_room): menu->help_text is now `const char **';
4733 adjust.
4734
4735 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4736 to changes in oldXMenu/XMenu.h from 2011-04-16.
4737 (struct XMenu): Declare `help_text' `const char **'.
4738
4739 * xfaces.c <Qunspecified>: Make extern again.
4740
4741 * syntax.c: Include sys/types.h before including regex.h, as
4742 required by Posix.
4743
4744 * doc.c (get_doc_string): Improve the format passed to `error'.
4745
4746 * doprnt.c (doprnt): Improve commentary.
4747
4748 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4749
4750 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4751 them with etags.
4752
4753 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4754 changes in globals.h immediately force recompilation.
4755 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4756 $(CURDIR)/s/ms-w32.h.
4757 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4758
4759 * character.c (Fchar_direction): Function deleted.
4760 (syms_of_character): Don't defsubr it.
4761 <char-direction-table>: Deleted.
4762
4763 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4764
4765 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4766 * doprnt.c: Include limits.h.
4767 (SIZE_MAX): New macro.
4768 (doprnt): Return a size_t value. 2nd arg is now size_t.
4769 Many local variables are now size_t instead of int or unsigned.
4770 Improve overflow protection. Support `l' modifier for integer
4771 conversions. Support %l conversion. Don't assume an EMACS_INT
4772 argument for integer conversions and for %c.
4773
4774 * lisp.h (doprnt): Restore prototype.
4775
4776 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4777 $(SRC)/character.h.
4778
4779 * Makefile.in (base_obj): Add back doprnt.o.
4780
4781 * deps.mk (doprnt.o): Add back prerequisites.
4782 (callint.o): Depend on character.h.
4783
4784 * eval.c (internal_lisp_condition_case): Include the handler
4785 representation in the error message.
4786 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4787 when breaking from the loop.
4788
4789 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4790
4791 * callint.c (Fcall_interactively): When displaying error message
4792 about invalid control letter, pass the character's codepoint, not
4793 a pointer to its multibyte form. Improve display of the character
4794 in octal and display also its hex code.
4795
4796 * character.c (char_string): Use %x to display the (unsigned)
4797 codepoint of an invalid character, to avoid displaying a bogus
4798 negative value.
4799
4800 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4801 `error', not SYMBOL_NAME itself.
4802
4803 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4804 character arguments to `error'.
4805
4806 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4807 to `error' in error message about FINAL_CHAR argument. Make sure
4808 FINAL_CHAR is a character, and use %c when it is passed as
4809 argument to `error'.
4810
4811 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4812
4813 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4814
4815 * w32.c: Include <time.h>.
4816 (sys_localtime): New function.
4817
4818 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4819
4820 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4821
4822 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4823
4824 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4825
4826 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4827 zombies (Bug#8467).
4828
4829 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4830
4831 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4832 gl_state.e_property when gl_state.object is Qt.
4833
4834 * insdel.c (make_gap_larger): Remove limitation of buffer size
4835 to <= INT_MAX.
4836
4837 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4838
4839 * xdisp.c (lookup_glyphless_char_display)
4840 (produce_glyphless_glyph): Handle cons cell entry in
4841 glyphless-char-display.
4842 (Vglyphless_char_display): Document it.
4843
4844 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4845 glyphless-char-display.
4846
4847 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4848
4849 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4850
4851 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4852
4853 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4854 definition for no-X builds.
4855
4856 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4857
4858 Static checks with GCC 4.6.0 and non-default toolkits.
4859
4860 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4861
4862 * process.c (keyboard_bit_set): Define only if SIGIO.
4863 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4864 (send_process): Repair possible setjmp clobbering.
4865
4866 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4867
4868 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4869
4870 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4871
4872 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4873 Define only if needed.
4874
4875 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4876 by pacifying GCC about it. Maybe it's time to retire it?
4877 * xfaces.c (USG, __TIMEVAL__): Likewise.
4878
4879 * dispextern.h (struct redisplay_interface): Rename param
4880 to avoid shadowing.
4881 * termhooks.h (struct terminal): Likewise.
4882 * xterm.c (xembed_send_message): Likewise.
4883
4884 * insdel.c (make_gap_smaller): Define only if
4885 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4886
4887 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4888 it.
4889
4890 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4891 so that we aren't warned about unused symbols.
4892
4893 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4894
4895 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4896
4897 * xfns.c (x_real_positions): Mark locals as initialized.
4898
4899 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4900
4901 * xterm.c: Fix problems found by static analysis with other toolkits.
4902 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4903 (x_dispatch_event): Declare static if USE_GTK, and
4904 define if USE_GTK || USE_X_TOOLKIT.
4905 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4906 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4907 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4908 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4909
4910 * xmenu.c (menu_help_callback): Pointer type fixes.
4911 Use const pointers when pointing at readonly data. Avoid pointer
4912 signedness clashes.
4913 (FALSE): Remove unused macro.
4914 (update_frame_menubar): Remove unused decl.
4915
4916 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4917
4918 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4919 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4920 (single_menu_item): Rename local to avoid shadowing.
4921
4922 * keyboard.c (make_lispy_event): Remove unused local var.
4923
4924 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4925 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4926
4927 * bitmaps: Change bitmaps from unsigned char back to the X11
4928 compatible char. Avoid the old compiler warnings about
4929 out-of-range initializers by using, for example, '\xab' rather
4930 than 0xab.
4931
4932 * xgselect.c (xgselect_initialize): Check vs interface
4933 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4934
4935 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4936
4937 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4938 to read-only memory.
4939
4940 * fns.c (vector): Remove; this old hack is no longer needed.
4941
4942 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4943 Remove unused var.
4944 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4945
4946 * xrdb.c (x_load_resources): Omit unused local.
4947
4948 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4949 (x_window): Rename locals to avoid shadowing.
4950 (USG): Use the kludged USG macro, to pacify gcc.
4951
4952 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4953 (x_term_init): Remove local to avoid shadowing.
4954
4955 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4956
4957 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4958 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4959
4960 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4961
4962 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4963
4964 Fix regex.c, syntax.c and friends for buffers > 2GB.
4965 * syntax.h (struct gl_state_s): Declare character position members
4966 EMACS_INT.
4967
4968 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4969
4970 * textprop.c (verify_interval_modification, interval_of):
4971 Declare arguments EMACS_INT.
4972
4973 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4974 EMACS_INT.
4975
4976 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4977
4978 * indent.c (Fvertical_motion): Local variable it_start is now
4979 EMACS_INT.
4980
4981 * regex.c (re_match, re_match_2, re_match_2_internal)
4982 (bcmp_translate, regcomp, regexec, print_double_string)
4983 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4984 (re_compile_pattern, re_exec): Declare arguments and local
4985 variables `size_t' and `ssize_t' and return values `regoff_t', as
4986 appropriate.
4987 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4988 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4989 <compile_stack_type>: `size' and `avail' are now `size_t'.
4990
4991 * regex.h <regoff_t>: Use ssize_t, not int.
4992 (re_search, re_search_2, re_match, re_match_2): Arguments that
4993 specify buffer/string position and length are now ssize_t and
4994 size_t. Return type is regoff_t.
4995
4996 2011-04-16 Ben Key <bkey76@gmail.com>
4997
4998 * nsfont.m: Fixed bugs in ns_get_family and
4999 ns_descriptor_to_entity that were caused by using free to
5000 deallocate memory blocks that were allocated by xmalloc (via
5001 xstrdup). This caused Emacs to crash when compiled with
5002 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5003 --enable-checking=xmallocoverrun). xfree is now used to
5004 deallocate these memory blocks.
5005
5006 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5007
5008 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5009
5010 emacs_write: Accept and return EMACS_INT for sizes.
5011 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5012 et seq.
5013 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5014 Accept and return EMACS_INT.
5015 (emacs_gnutls_write): Return the number of bytes written on
5016 partial writes.
5017 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5018 (emacs_read, emacs_write): Remove check for negative size, as the
5019 Emacs source code has been audited now.
5020 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5021 (emacs_read, emacs_write): Use it.
5022 * process.c (send_process): Adjust to the new signatures of
5023 emacs_write and emacs_gnutls_write. Do not attempt to store
5024 a byte offset into an 'int'; it might overflow.
5025 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5026
5027 * sound.c: Don't assume sizes fit in 'int'.
5028 (struct sound_device.period_size, alsa_period_size):
5029 Return EMACS_INT, not int.
5030 (struct sound_device.write, vox_write, alsa_write):
5031 Accept EMACS_INT, not int.
5032 (wav_play, au_play): Use EMACS_INT to store sizes and to
5033 record read return values.
5034
5035 2011-04-15 Ben Key <bkey76@gmail.com>
5036
5037 * keyboard.c (Qundefined): Don't declare static since it is used
5038 in nsfns.m.
5039 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5040 static since they are used in nsfont.m.
5041
5042 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5043
5044 * process.c (Qprocessp): Don't declare static.
5045 * lisp.h (Qprocessp): Declare again.
5046
5047 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5048
5049 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5050
5051 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5052
5053 Improve C-level modularity by making more things 'static'.
5054
5055 Don't publish debugger-only interfaces to other modules.
5056 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5057 (verify_bytepos, count_markers): Move decls to the only modules
5058 that need them.
5059 * region-cache.h (pp_cache): Likewise.
5060 * window.h (check_all_windows): Likewise.
5061 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5062
5063 * sysdep.c (croak): Now static, if
5064 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5065 * syssignal.h (croak): Declare only if not static.
5066
5067 * alloc.c (refill_memory_reserve): Now static if
5068 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5069 * lisp.h (refill_memory_reserve): Declare only if not static.
5070
5071 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5072 Define only if USE_LUCID.
5073
5074 * xrdb.c (x_customization_string, x_rm_string): Now static.
5075
5076 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5077 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5078
5079 * xdisp.c (draw_row_with_mouse_face): Now static.
5080 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5081
5082 * window.h (check_all_windows): Mark externally visible.
5083
5084 * window.c (window_deletion_count): Now static.
5085
5086 * undo.c: Make symbols static if they're not exported.
5087 (last_undo_buffer, last_boundary_position, pending_boundary):
5088 Now static.
5089
5090 * textprop.c (interval_insert_behind_hooks): Now static.
5091 (interval_insert_in_front_hooks): Likewise.
5092
5093 * term.c: Make symbols static if they're not exported.
5094 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5095 (max_frame_lines, tty_set_terminal_modes):
5096 (tty_reset_terminal_modes, tty_turn_off_highlight):
5097 (get_tty_terminal): Now static.
5098 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5099 * termhooks.h (term_mouse_moveto): Do not declare if
5100 HAVE_WINDOW_SYSTEM.
5101 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5102 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5103
5104 * sysdep.c: Make symbols static if they're not exported.
5105 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5106 Now static.
5107 (sigprocmask_set, full_mask): Remove; unused.
5108 (wait_debugging): Mark as visible.
5109 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5110 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5111
5112 * syntax.c (syntax_temp): Define only if !__GNUC__.
5113
5114 * sound.c (current_sound_device, current_sound): Now static.
5115
5116 * search.c (searchbufs, searchbuf_head): Now static.
5117
5118 * scroll.c (scroll_cost): Remove; unused.
5119 * dispextern.h (scroll_cost): Remove decl.
5120
5121 * region-cache.h (pp_cache): Mark as externally visible.
5122
5123 * process.c: Make symbols static if they're not exported.
5124 (process_tick, update_tick, create_process, chan_process):
5125 (Vprocess_alist, proc_buffered_char, datagram_access):
5126 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5127 (deactivate_process): Mark defn as static, as well as decl.
5128 * lisp.h (create_process): Remove decl.
5129 * process.h (chan_process, Vprocess_alist): Remove decls.
5130
5131 * print.c: Make symbols static if they're not exported.
5132 (print_depth, new_backquote_output, being_printed, print_buffer):
5133 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5134 (print_interval, print_number_index, initial_stderr_stream):
5135 Now static.
5136 * lisp.h (Fprinc): Remove decl.
5137 (debug_output_compilation_hack): Mark as externally visible.
5138
5139 * sysdep.c (croak): Move decl from here to syssignal.h.
5140 * syssignal.h (croak): Put it here, so the API can be checked when
5141 'croak' is called from dissociate_if_controlling_tty.
5142
5143 * minibuf.c: Make symbols static if they're not exported.
5144 (minibuf_save_list, choose_minibuf_frame): Now static.
5145 * lisp.h (choose_minibuf_frame): Remove decl.
5146
5147 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5148
5149 * lread.c: Make symbols static if they're not exported.
5150 (read_objects, initial_obarray, oblookup_last_bucket_number):
5151 Now static.
5152 (make_symbol): Remove; unused.
5153 * lisp.h (initial_obarray, make_symbol): Remove decls.
5154
5155 * keyboard.c: Make symbols static if they're not exported.
5156 (single_kboard, recent_keys_index, total_keys, recent_keys):
5157 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5158 (this_single_command_key_start, echoing, last_auto_save):
5159 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5160 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5161 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5162 (Vlispy_mouse_stem, double_click_count):
5163 Now static.
5164 (force_auto_save_soon): Define only if SIGDANGER.
5165 (ignore_mouse_drag_p): Now static if
5166 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5167 (print_help): Remove; unused.
5168 (stop_character, last_timer_event): Mark as externally visible.
5169 * keyboard.h (ignore_mouse_drag_p): Declare only if
5170 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5171 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5172 * lisp.h (echoing): Remove decl.
5173 (force_auto_save_soon): Declare only if SIGDANGER.
5174 * xdisp.c (redisplay_window): Simplify code, to make it more
5175 obvious that ignore_mouse_drag_p is not accessed if !defined
5176 USE_GTK && !defined HAVE_NS.
5177
5178 * intervals.c: Make symbols static if they're not exported.
5179 (merge_properties_sticky, merge_interval_right, delete_interval):
5180 Now static.
5181 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5182
5183 * insdel.c: Make symbols static if they're not exported.
5184 However, leave prepare_to_modify_buffer alone. It's never
5185 called from outside this function, but that appears to be a bug.
5186 (combine_after_change_list, combine_after_change_buffer):
5187 (adjust_after_replace, signal_before_change): Now static.
5188 (adjust_after_replace_noundo): Remove; unused.
5189 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5190 (signal_before_change): Remove decls.
5191
5192 * indent.c (val_compute_motion, val_vmotion): Now static.
5193
5194 * image.c: Make symbols static if they're not exported.
5195 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5196 if USE_GTK.
5197 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5198 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5199
5200 * fringe.c (standard_bitmaps): Now static.
5201 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5202
5203 * frame.c: Make symbols static if they're not exported.
5204 (x_report_frame_params, make_terminal_frame): Now static.
5205 (get_frame_param): Now static, unless HAVE_NS.
5206 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5207 (x_get_resource_string): Remove; not used.
5208 * frame.h (make_terminal_frame, x_report_frame_params):
5209 (x_get_resource_string); Remove decls.
5210 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5211 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5212
5213 * font.c, fontset.c: Make symbols static if they're not exported.
5214 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5215 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5216 * font.c (font_close_object): Now static.
5217 * font.h (font_close_object): Remove.
5218 * fontset.c (FONTSET_OBJLIST): Remove.
5219 (free_realized_fontset) #if-0 the body, which does nothing.
5220 (face_suitable_for_char_p): #if-0, as it's never called.
5221 * fontset.h (face_suitable_for_char_p): Remove decl.
5222 * xfaces.c (face_at_string_position):
5223 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5224 since 0 is always ASCII.
5225
5226 * fns.c (weak_hash_tables): Now static.
5227
5228 * fileio.c: Make symbols static if they're not exported.
5229 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5230 (Vwrite_region_annotation_buffers): Now static.
5231
5232 * eval.c: Make symbols static if they're not exported.
5233 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5234 * lisp.h (backtrace_list): Remove decl.
5235
5236 * emacs.c: Make symbols static if they're not exported.
5237 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5238 (fatal_error_code, fatal_error_signal_hook, standard_args):
5239 Now static.
5240 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5241 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5242 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5243 * lisp.h (fatal_error_signal_hook): Remove decl.
5244 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5245
5246 * editfns.c: Move a (normally-unused) function to its only use.
5247 * editfns.c, lisp.h (get_operating_system_release): Remove.
5248 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5249 worth the hassle of breaking this out.
5250
5251 * xterm.c: Make symbols static if they're not exported.
5252 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5253 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5254 (x_destroy_window, x_delete_display):
5255 Now static.
5256 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5257 (x_mouse_leave): Remove; unused.
5258 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5259 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5260 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5261 Remove decls.
5262 (x_mouse_leave): Declare only if WINDOWSNT.
5263 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5264 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5265 USE_X_TOOLKIT.
5266
5267 * ftxfont.c: Make symbols static if they're not exported.
5268 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5269 HAVE_FREETYPE.
5270 * font.h (ftxfont_driver): Likewise.
5271
5272 * xfns.c: Make symbols static if they're not exported.
5273 (x_last_font_name, x_display_info_for_name):
5274 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5275 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5276 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5277 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5278 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5279 (last_show_tip_args): Now static.
5280 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5281 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5282 (x_screen_planes): Remove; unused.
5283 * dispextern.h (x_screen_planes): Remove decl.
5284
5285 * dispnew.c: Make symbols static if they're not exported.
5286 * dispextern.h (redraw_garbaged_frames, scrolling):
5287 (increment_row_positions): Remove.
5288 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5289 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5290 Now static.
5291 (redraw_garbaged_frames): Remove; unused.
5292
5293 * xfaces.c: Make symbols static if they're not exported.
5294 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5295 Remove decls.
5296 * xterm.h (defined_color): Remove decls.
5297 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5298 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5299 (menu_face_changed_default, defined_color, free_realized_face):
5300 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5301 (ascii_face_of_lisp_face): Remove; unused.
5302
5303 * xdisp.c: Make symbols static if they're not exported.
5304 * dispextern.h (scratch_glyph_row, window_box_edges):
5305 (glyph_to_pixel_coords, set_cursor_from_row):
5306 (get_next_display_element, set_iterator_to_next):
5307 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5308 (show_mouse_face): Remove decls
5309 * frame.h (message_buf_print): Likewise.
5310 * lisp.h (pop_message, set_message, check_point_in_composition):
5311 Likewise.
5312 * xterm.h (set_vertical_scroll_bar): Likewise.
5313 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5314 (message_buf_print, scratch_glyph_row, displayed_buffer):
5315 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5316 (get_next_display_element, show_mouse_face, window_box_edges):
5317 (frame_to_window_pixel_xy, check_point_in_composition):
5318 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5319 (glyph_to_pixel_coords): Remove; unused.
5320
5321 * dired.c (file_name_completion): Now static.
5322
5323 * dbusbind.c (xd_in_read_queued_messages): Now static.
5324
5325 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5326 * data.c (circular_list_error): Remove.
5327
5328 * commands.h (last_point_position, last_point_position_buffer):
5329 (last_point_position_window): Remove decls.
5330 * keyboard.c: Make these variables static.
5331
5332 * coding.h (coding, code_convert_region, encode_coding_gap):
5333 Remove decls.
5334 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5335 (iso_code_class, detect_coding, code_convert_region): Now static.
5336 (encode_coding_gap): Remove; unused.
5337
5338 * chartab.c (chartab_chars, chartab_bits): Now static.
5339
5340 * charset.h (charset_iso_8859_1): Remove decl.
5341 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5342 Now static.
5343
5344 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5345 * ccl.c (Vccl_program_table): Now static.
5346 (check_ccl_update): Remove; unused.
5347
5348 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5349 * category.h: ... from here.
5350 * category.c (check_category_table, set_category_set): Now static.
5351
5352 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5353 * lisp.h: Remove these decls.
5354
5355 * buffer.c (buffer_count): Remove unused var.
5356
5357 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5358 so that it's not optimized away.
5359 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5360 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5361 exported only to the debugger.
5362
5363 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5364 * atimer.h (run_all_atimers): Remove; not exported.
5365
5366 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5367 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5368 was inaccessible from Lisp.
5369 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5370 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5371
5372 alloc.c: Import and export fewer symbols, and remove unused items.
5373 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5374 is defined.
5375 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5376 it's not optimized away by whole-program optimization.
5377 (message_enable_multibyte, free_misc): Remove.
5378 (catchlist, handlerlist, mark_backtrace):
5379 Declare only if BYTE_MARK_STACK.
5380 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5381 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5382 (message_enable_multibyte): Remove decl.
5383 (free_misc, interval_free_list, float_block, float_block_index):
5384 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5385 (cons_free_list, last_marked_index):
5386 Now static.
5387 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5388 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5389 (mark_backtrace): Define only if BYTE_MARK_STACK.
5390 * xdisp.c (message_enable_multibyte): Now static.
5391
5392 Declare Lisp_Object Q* variables to be 'static' if not exported.
5393 This makes it easier for human readers (and static analyzers)
5394 to see whether these variables are used from other modules.
5395 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5396 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5397 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5398 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5399 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5400 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5401 * xmenu.c, xselect.c:
5402 Declare Q* vars static if they are not used in other modules.
5403 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5404 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5405 Remove decls of unexported vars.
5406 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5407
5408 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5409
5410 Make Emacs functions such as Fatom 'static' by default.
5411 This makes it easier for human readers (and static analyzers)
5412 to see whether these functions can be called from other modules.
5413 DEFUN now defines a static function. To make the function external
5414 so that it can be used in other C modules, use the new macro DEFUE.
5415 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5416 (Finit_image_library):
5417 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5418 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5419 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5420 Remove decls, since these functions are now static.
5421 (Funintern, Fget_internal_run_time): New decls, since these functions
5422 were already external.
5423
5424 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5425 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5426 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5427 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5428 * keyboard.c, keymap.c, lread.c:
5429 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5430 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5431 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5432 Mark functions with DEFUE instead of DEFUN,
5433 if they are used in other modules.
5434 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5435 decls for now-static functions.
5436 * buffer.h (Fdelete_overlay): Remove decl.
5437 * callproc.c (Fgetenv_internal): Mark as internal.
5438 * composite.c (Fremove_list_of_text_properties): Remove decl.
5439 (Fcomposition_get_gstring): New forward static decl.
5440 * composite.h (Fcomposite_get_gstring): Remove decl.
5441 * dired.c (Ffile_attributes): New forward static decl.
5442 * doc.c (Fdocumntation_property): New forward static decl.
5443 * eval.c (Ffetch_bytecode): New forward static decl.
5444 (Funintern): Remove extern decl; now in .h file where it belongs.
5445 * fileio.c (Fmake_symbolic_link): New forward static decl.
5446 * image.c (Finit_image_library): New forward static decl.
5447 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5448 * intervals.h (Fprevious_property_change):
5449 (Fremove_list_of_text_properties): Remove decls.
5450 * keyboard.c (Fthis_command_keys): Remove decl.
5451 (Fcommand_execute): New forward static decl.
5452 * keymap.c (Flookup_key): New forward static decl.
5453 (Fcopy_keymap): Now static.
5454 * keymap.h (Flookup_key): Remove decl.
5455 * process.c (Fget_process): New forward static decl.
5456 (Fprocess_datagram_address): Mark as internal.
5457 * syntax.c (Fsyntax_table_p): New forward static decl.
5458 (skip_chars): Remove duplicate decl.
5459 * textprop.c (Fprevious_property_change): New forward static decl.
5460 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5461 Now internal.
5462 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5463 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5464
5465 * editfns.c (Fformat): Remove unreachable code.
5466
5467 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5468
5469 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5470 change. (Bug#8496)
5471
5472 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5473
5474 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5475 when at ZV. (Bug#8487)
5476
5477 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5478
5479 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5480 (Bug#8437)
5481 * keyboard.c (parse_tool_bar_item): Likewise.
5482 * sound.c (sound_cleanup, alsa_close): Likewise.
5483 * termcap.c (tgetent): Likewise.
5484 * xfns.c (x_default_font_parameter): Likewise.
5485 * xsettings.c (read_and_apply_settings): Likewise.
5486
5487 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5488 (overrun_check_free): Protoize.
5489
5490 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5491
5492 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5493 since callers should never pass a negative size.
5494 Change the signature to match that of plain 'read' and 'write'; see
5495 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5496 * lisp.h: Update prototypes of emacs_write and emacs_read.
5497
5498 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5499
5500 * xdisp.c (redisplay_window): Don't try to determine the character
5501 position of the scroll margin if the window start point w->startp
5502 is outside the buffer's accessible region. (Bug#8468)
5503
5504 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5505
5506 Fix write-region and its subroutines for buffers > 2GB.
5507 * fileio.c (a_write, e_write): Modify declaration of arguments and
5508 local variables to support buffers larger than 2GB.
5509 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5510
5511 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5512 argument, local variables, and return value.
5513
5514 * lisp.h: Update prototypes of emacs_write and emacs_read.
5515
5516 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5517
5518 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5519
5520 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5521
5522 Fix more problems found by GCC 4.6.0's static checks.
5523
5524 * xdisp.c (vmessage): Use a better test for character truncation.
5525
5526 * charset.c (load_charset_map): <, not <=, for optimization,
5527 and to avoid potential problems with integer overflow.
5528 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5529 * casetab.c (set_identity, shuffle): Likewise.
5530 * editfns.c (Fformat): Likewise.
5531 * syntax.c (skip_chars): Likewise.
5532
5533 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5534 This also lets GCC 4.6.0 generate slightly better loop code.
5535
5536 * callint.c (Fcall_interactively): <, not <=, for optimization.
5537 (Fcall_interactively): Count the number of arguments produced,
5538 not the number of arguments given. This is simpler and lets GCC
5539 4.6.0 generate slightly better code.
5540
5541 * ftfont.c: Distingish more carefully between FcChar8 and char.
5542 The previous code passed unsigned char * to a functions like
5543 strlen and xstrcasecmp that expect char *, which does not
5544 conform to the C standard.
5545 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5546 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5547 char * when the C standard requires it.
5548
5549 * keyboard.c (read_char): Remove unused var.
5550
5551 * eval.c: Port to Windows vsnprintf (Bug#8435).
5552 Include <limits.h>.
5553 (SIZE_MAX): Define if the headers do not.
5554 (verror): Do not give up if vsnprintf returns a negative count.
5555 Instead, grow the buffer. This ports to Windows vsnprintf, which
5556 does not conform to C99. Problem reported by Eli Zaretskii.
5557 Also, simplify the allocation scheme, by avoiding the need for
5558 calling realloc, and removing the ALLOCATED variable.
5559
5560 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5561
5562 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5563 But keep the doprint source code for now, as we might revamp it
5564 and use it again (Bug#8435).
5565 * lisp.h (doprnt): Remove.
5566 * Makefile.in (base_obj): Remove doprnt.o.
5567 * deps.mk (doprnt.o): Remove.
5568
5569 error: Print 32- and 64-bit integers portably (Bug#8435).
5570 Without this change, on typical 64-bit hosts error ("...%d...", N)
5571 was used to print both 32- and 64-bit integers N, which relied on
5572 undefined behavior.
5573 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5574 New macro.
5575 * lisp.h (error, verror): Mark as printf-like functions.
5576 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5577 Report overflow in size calculations when allocating printf buffer.
5578 Do not truncate output string at its first null byte.
5579 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5580 Truncate the output at a character boundary, since vsnprintf does not
5581 do that.
5582 * charset.c (check_iso_charset_parameter): Convert internal
5583 character to string before calling 'error', since %c now has the
5584 printf meaning.
5585 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5586 overflow when computing char to be passed to 'error'. Do not
5587 pass Lisp_Object to 'error'; pass the integer instead.
5588 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5589 formatted with plain %d.
5590
5591 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5592
5593 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5594
5595 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5596
5597 * xterm.c (x_catch_errors): Remove duplicate declaration.
5598
5599 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5600
5601 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5602
5603 2011-04-10 Jim Meyering <meyering@redhat.com>
5604
5605 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5606 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5607 return ssize_t not "int", and use size_t as the buffer length.
5608 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5609 * gnutls.h: Update declarations.
5610 * process.c (read_process_output): Use ssize_t, to match.
5611 (send_process): Likewise.
5612
5613 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5614
5615 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5616
5617 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5618
5619 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5620 Use unsigned char, to match FcChar8 type definition.
5621
5622 * xterm.c (handle_one_xevent):
5623 * xmenu.c (create_and_show_popup_menu):
5624 * xselect.c (x_decline_selection_request)
5625 (x_reply_selection_request): Avoid type-punned deref of X events.
5626
5627 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5628
5629 Fix some uses of `int' instead of EMACS_INT.
5630 * search.c (string_match_1, fast_string_match)
5631 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5632 (scan_buffer, find_next_newline_no_quit)
5633 (find_before_next_newline, search_command, Freplace_match)
5634 (Fmatch_data): Make some `int' variables be EMACS_INT.
5635
5636 * xdisp.c (display_count_lines): 3rd argument and return value now
5637 EMACS_INT. All callers changed.
5638 (pint2hrstr): Last argument is now EMACS_INT.
5639
5640 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5641 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5642 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5643 (decode_coding_utf_16, decode_coding_emacs_mule)
5644 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5645 (decode_coding_ccl, decode_coding_charset)
5646 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5647 (decode_coding_iso_2022, decode_coding_emacs_mule)
5648 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5649 <char_offset, last_offset>: Declare EMACS_INT.
5650 (encode_coding_utf_8, encode_coding_utf_16)
5651 (encode_coding_emacs_mule, encode_invocation_designation)
5652 (encode_designation_at_bol, encode_coding_iso_2022)
5653 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5654 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5655 Declare EMACS_INT.
5656 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5657 (encode_invocation_designation): Last argument P_NCHARS is now
5658 EMACS_INT.
5659 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5660 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5661
5662 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5663 All users changed.
5664
5665 * ccl.c (Fccl_execute_on_string): Declare some variables
5666 EMACS_INT.
5667
5668 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5669
5670 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5671
5672 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5673
5674 * process.c (Fformat_network_address): Doc fix.
5675
5676 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5677
5678 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5679
5680 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5681
5682 * keyboard.c (read_char): Call Lisp function help-form-show,
5683 instead of using internal_with_output_to_temp_buffer.
5684 (Qhelp_form_show): New var.
5685 (syms_of_keyboard): Use DEFSYM macro.
5686
5687 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5688
5689 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5690
5691 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5692
5693 * process.c (Flist_processes): Remove to Lisp.
5694 (list_processes_1): Delete.
5695
5696 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5697
5698 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5699
5700 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5701
5702 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5703
5704 Fix more problems found by GCC 4.6.0's static checks.
5705
5706 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5707
5708 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5709
5710 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5711
5712 * xdisp.c (vmessage): Mark as a printf-like function.
5713
5714 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5715
5716 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5717
5718 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5719 printf-like functions.
5720 (tiff_load): Add casts to remove these marks before passing them
5721 to system-supplied API.
5722
5723 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5724
5725 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5726 This avoids several warnings with gcc -Wstrict-overflow.
5727 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5728 directly, rather than having caller test rule sign. This avoids
5729 some unnecessary tests.
5730 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5731 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5732 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5733
5734 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5735 (xfont_open): Avoid unnecessary tests.
5736
5737 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5738
5739 * composite.h, composite.c (composition_gstring_put_cache):
5740 Use EMACS_INT, not int, for length.
5741
5742 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5743 breaking out part of COMPOSITION_DECODE_RULE.
5744 (COMPOSITION_DECODE_RULE): Use it.
5745 * composite.c (get_composition_id): Remove unused local vars,
5746 by using the new macro.
5747
5748 * textprop.c (set_text_properties_1): Change while to do-while,
5749 since the condition is always true at first.
5750
5751 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5752 (interval_deletion_adjustment): Return unsigned value.
5753 All uses changed.
5754
5755 * process.c (list_processes_1, create_pty, read_process_output):
5756 (exec_sentinel): Remove vars that were set but not used.
5757 (create_pty): Remove unnecessary "volatile"s.
5758 (Fnetwork_interface_info): Avoid possibility of int overflow.
5759 (read_process_output): Do adaptive read buffering even if carryover.
5760 (read_process_output): Simplify nbytes computation if buffered.
5761
5762 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5763
5764 * syntax.c (scan_words): Remove var that was set but not used.
5765 (update_syntax_table): Use unsigned instead of int.
5766
5767 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5768 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5769 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5770
5771 * print.c (print_error_message): Avoid int overflow.
5772
5773 * font.c (font_list_entities): Redo for clarity,
5774 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5775
5776 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5777 (font_score): Avoid potential overflow in diff calculation.
5778
5779 * fns.c (substring_both): Remove var that is set but not used.
5780 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5781
5782 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5783
5784 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5785 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5786 can always succeed if overflow has undefined behavior.
5787
5788 * search.c (boyer_moore, wordify): Remove vars set but not used.
5789 (wordify): Omit three unnecessary tests.
5790
5791 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5792 All callers changed. This avoids the need for an unused var.
5793
5794 * casefiddle.c (casify_region): Remove var that is set but not used.
5795
5796 * dired.c (file_name_completion): Remove var that is set but not used.
5797
5798 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5799
5800 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5801 (Finsert_file_contents): Remove unnecessary code checking fd.
5802
5803 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5804 Check for integer overflow on size calculations.
5805
5806 * buffer.c (Fprevious_overlay_change): Remove var that is set
5807 but not used.
5808
5809 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5810 Remove vars that are set but not used.
5811 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5812 (timer_check_2): Mark vars as initialized.
5813
5814 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5815
5816 * image.c (lookup_image): Remove var that is set but not used.
5817 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5818
5819 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5820 that are set but not used.
5821
5822 * xfns.c (make_invisible_cursor): Don't return garbage
5823 if XCreateBitmapFromData fails (Bug#8410).
5824
5825 * xselect.c (x_get_local_selection, x_handle_property_notify):
5826 Remove vars that are set but not used.
5827
5828 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5829 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5830
5831 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5832 Remove var that is set but not used.
5833 (scroll_bar_windows_size): Now size_t, not int.
5834 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5835 Check for overflow.
5836
5837 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5838 (map_tty_color) [!defined MSDOS]: Likewise.
5839
5840 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5841
5842 * coding.c: Remove vars that are set but not used.
5843 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5844 All callers changed.
5845 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5846 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5847 (decode_coding_charset): Remove vars that are set but not used.
5848
5849 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5850 that is set but not used.
5851
5852 * print.c (print_object): Remove var that is set but not used.
5853
5854 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5855 The gnulib version avoids calling malloc in the usual case,
5856 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5857 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5858 * filelock.c (current_lock_owner): Likewise.
5859 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5860 * sysdep.c: Include allocator.h, careadlinkat.h.
5861 (emacs_no_realloc_allocator): New static constant.
5862 (emacs_readlink): New function.
5863 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5864 ../lib/careadlinkat.h.
5865
5866 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5867
5868 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5869 first non-nil return value).
5870
5871 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5872
5873 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5874 if not defined (Bug#8403).
5875
5876 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5877
5878 * xdisp.c (display_count_lines): Remove parameter `start',
5879 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5880 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5881 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5882 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5883 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5884 and thereabouts. All callers changed.
5885 (get_per_char_metric): Remove parameter `f', unused since
5886 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5887
5888 2011-04-02 Jim Meyering <meyering@redhat.com>
5889
5890 do not dereference NULL upon failed strdup
5891 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5892 (ns_get_family): Likewise.
5893
5894 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5895
5896 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5897
5898 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5899
5900 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5901 later (Bug#8403).
5902
5903 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5904
5905 Add lexical binding.
5906
5907 * window.c (Ftemp_output_buffer_show): New fun.
5908 (Fsave_window_excursion):
5909 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5910
5911 * lread.c (lisp_file_lexically_bound_p): New function.
5912 (Fload): Bind Qlexical_binding.
5913 (readevalloop): Remove `evalfun' arg.
5914 Bind Qinternal_interpreter_environment.
5915 (Feval_buffer): Bind Qlexical_binding.
5916 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5917 Mark as dynamic.
5918 (syms_of_lread): Declare `lexical-binding'.
5919
5920 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5921
5922 * keyboard.c (eval_dyn): New fun.
5923 (menu_item_eval_property): Use it.
5924
5925 * image.c (parse_image_spec): Use Ffunctionp.
5926
5927 * fns.c (concat, mapcar1): Accept byte-code-functions.
5928
5929 * eval.c (Fsetq): Handle lexical vars.
5930 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5931 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5932 (FletX, Flet): Obey lexical binding.
5933 (Fcommandp): Handle closures.
5934 (Feval): New `lexical' arg.
5935 (eval_sub): New function extracted from Feval. Use it almost
5936 everywhere where Feval was used. Look up vars in lexical env.
5937 Handle closures.
5938 (Ffunctionp): Move from subr.el.
5939 (Ffuncall): Handle closures.
5940 (apply_lambda): Remove `eval_flags'.
5941 (funcall_lambda): Handle closures and new byte-code-functions.
5942 (Fspecial_variable_p): New function.
5943 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5944 but without exporting it to Lisp.
5945
5946 * doc.c (Fdocumentation, store_function_docstring):
5947 * data.c (Finteractive_form): Handle closures.
5948
5949 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5950 interactive spec.
5951
5952 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5953 New byte-codes.
5954 (exec_byte_code): New function extracted from Fbyte_code to handle new
5955 calling convention for byte-code-functions. Add new byte-codes.
5956
5957 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5958
5959 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5960
5961 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5962
5963 * xdisp.c (redisplay_internal): Fix prototype.
5964
5965 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5966
5967 * xdisp.c (SCROLL_LIMIT): New macro.
5968 (try_scrolling): Use it when setting scroll_limit.
5969 Limit scrolling to 100 screen lines.
5970 (redisplay_window): Even when falling back on "recentering",
5971 position point in the window according to scroll-conservatively,
5972 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5973
5974 (try_scrolling): When point is above the window, allow searching
5975 as far as scroll_max, or one screenful, to compute vertical
5976 distance from PT to the scroll margin position. This prevents
5977 try_scrolling from unnecessarily failing when
5978 scroll-conservatively is set to a value slightly larger than the
5979 window height. Clean up the case of PT below the margin at bottom
5980 of window: scroll_max can no longer be INT_MAX. When aggressive
5981 scrolling is in use, don't let point enter the opposite scroll
5982 margin as result of the scroll.
5983 (syms_of_xdisp) <scroll-conservatively>: Document the
5984 threshold of 100 lines for never-recentering scrolling.
5985
5986 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5987
5988 * dispextern.h (move_it_by_lines):
5989 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5990 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5991 (message_log_check_duplicate): Remove parameters `prev_bol' and
5992 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5993 (redisplay_internal): Remove parameter `preserve_echo_area',
5994 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5995
5996 * indent.c (Fvertical_motion):
5997 * window.c (window_scroll_pixel_based, Frecenter):
5998 Don't pass `need_y_p' to `move_it_by_lines'.
5999
6000 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6001
6002 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6003 steal a few bits to be more compact.
6004 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6005 Remove unneeded casts.
6006
6007 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6008
6009 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6010
6011 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6012 binding" message (bug#7967).
6013
6014 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6015
6016 Fix more problems found by GCC 4.6.0's static checks.
6017
6018 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6019 Remove unused local var.
6020
6021 * editfns.c (Fmessage_box): Remove unused local var.
6022
6023 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6024 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6025 Omit unused local vars.
6026 * window.c (shrink_windows): Omit unused local var.
6027 * menu.c (digest_single_submenu): Omit unused local var.
6028 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6029 Omit unused local var.
6030
6031 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6032 Don't assume string length fits in int.
6033 (keyremap_step, read_key_sequence): Use size_t for sizes.
6034 (read_key_sequence): Don't check last_real_key_start redundantly.
6035
6036 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6037 instead of alloca (Bug#8344).
6038
6039 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6040 (Fbacktrace_frame): Don't assume nframes fits in int.
6041
6042 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6043
6044 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6045 concerns.
6046
6047 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6048
6049 * cm.c (calccost): Turn while-do into do-while, for clarity.
6050
6051 * keyboard.c (syms_of_keyboard): Use the same style as later
6052 in this function when indexing through an array. This also
6053 works around GCC bug 48267.
6054
6055 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6056
6057 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6058
6059 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6060 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6061
6062 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6063 This avoids undefined behavior on integer overflow, and is a bit
6064 more convenient anyway since it is compared to a size_t variable.
6065
6066 Variadic C functions now count arguments with size_t, not int.
6067 This avoids an unnecessary limitation on 64-bit machines, which
6068 caused (substring ...) to crash on large vectors (Bug#8344).
6069 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6070 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6071 All variadic functions and their callers changed accordingly.
6072 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6073 * data.c (arith_driver, float_arith_driver): Likewise.
6074 * editfns.c (general_insert_function): Likewise.
6075 * eval.c (struct backtrace.nargs, interactive_p)
6076 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6077 (funcall_lambda, mark_backtrace): Likewise.
6078 * fns.c (concat): Likewise.
6079 * frame.c (x_set_frame_parameters): Likewise.
6080 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6081 0 if not found, not -1. All callers changed.
6082
6083 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6084 (stack_copy_size): Now size_t, not int.
6085 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6086
6087 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6088
6089 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6090 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6091 All callers changed.
6092
6093 * lisp.h (multibyte_char_to_unibyte):
6094 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6095 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6096 * character.h (CHAR_TO_BYTE8):
6097 * cmds.c (internal_self_insert):
6098 * editfns.c (general_insert_function):
6099 * keymap.c (push_key_description):
6100 * search.c (Freplace_match):
6101 * xdisp.c (message_dolog, set_message_1): All callers changed.
6102
6103 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6104
6105 * keyboard.c (safe_run_hook_funcall): New function.
6106 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6107 don't set the hook to nil, but remove the offending function instead.
6108 (Qcommand_hook_internal): Remove, unused.
6109 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6110 Vcommand_hook_internal.
6111
6112 * eval.c (enum run_hooks_condition): Remove.
6113 (funcall_nil, funcall_not): New functions.
6114 (run_hook_with_args): Call each function through a `funcall' argument.
6115 Remove `cond' argument, now redundant.
6116 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6117 (Frun_hook_with_args_until_failure): Adjust accordingly.
6118 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6119
6120 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6121
6122 * dispextern.h (string_buffer_position): Remove declaration.
6123
6124 * print.c (strout): Remove parameter `multibyte', unused since
6125 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6126
6127 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6128 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6129 All callers changed.
6130
6131 * w32.c (_wsa_errlist): Use braces for struct initializers.
6132
6133 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6134 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6135 All callers changed.
6136 (string_buffer_position): Likewise. Also, make static (it's never
6137 used outside xdisp.c).
6138 (cursor_row_p): Remove parameter `w', unused since
6139 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6140 (decode_mode_spec): Remove parameter `precision', introduced during
6141 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6142 All callers changed.
6143
6144 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6145
6146 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6147
6148 2011-03-27 Anders Lindgren <andlind@gmail.com>
6149
6150 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6151 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6152 (ns_update_auto_hide_menu_bar): New functions.
6153 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6154 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6155 ns_constrain_all_frames.
6156 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6157 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6158
6159 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6160
6161 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6162
6163 2011-03-27 Glenn Morris <rgm@gnu.org>
6164
6165 * syssignal.h: Replace RETSIGTYPE with void.
6166 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6167 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6168 Replace SIGTYPE with void everywhere.
6169 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6170 * s/template.h (SIGTYPE): Remove commented out definition.
6171
6172 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6173
6174 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6175 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6176
6177 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6178
6179 * w32.c (read_unc_volume): Use parameter `henum', instead of
6180 global variable `wget_enum_handle'.
6181
6182 * keymap.c (describe_vector): Remove parameters `indices' and
6183 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6184 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6185
6186 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6187
6188 * keyboard.c (timer_check): Remove parameter `do_it_now',
6189 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6190 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6191 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6192
6193 * keyboard.c (read_char):
6194 * w32menu.c (w32_menu_display_help):
6195 * xmenu.c (show_help_event, menu_help_callback):
6196 Adjust calls to `show_help_echo'.
6197
6198 * gtkutil.c (xg_maybe_add_timer):
6199 * keyboard.c (readable_events):
6200 * process.c (wait_reading_process_output):
6201 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6202
6203 * insdel.c (adjust_markers_gap_motion):
6204 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6205 (gap_left, gap_right): Don't call it.
6206
6207 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6208
6209 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6210 incurred during fontification.
6211
6212 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6213
6214 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6215 (DEFVAR_PER_BUFFER): Don't pass it.
6216
6217 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6218 (scrolling_window): Don't pass it.
6219
6220 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6221
6222 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6223
6224 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6225 and `suffix'.
6226 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6227 of variables specific to SELinux and computation of `encoded_absname'.
6228
6229 * image.c (XPutPixel): Remove unused variable `height'.
6230
6231 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6232
6233 * unexw32.c (get_section_info): Remove unused variable `section'.
6234
6235 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6236 (system_process_attributes): Remove unused variable `sess'.
6237 (sys_read): Remove unused variable `err'.
6238
6239 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6240 (w32_wnd_proc): Remove unused variable `isdead'.
6241 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6242 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6243 (x_create_tip_frame): Remove unused variable `tem'.
6244
6245 * w32inevt.c (w32_console_read_socket):
6246 Remove unused variable `no_events'.
6247
6248 * w32term.c (x_draw_composite_glyph_string_foreground):
6249 Remove unused variable `width'.
6250
6251 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6252
6253 * w32term.c (x_set_glyph_string_clipping):
6254 Don't pass uninitialized region to CombineRgn.
6255
6256 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6257
6258 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6259 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6260 (Fx_close_connection): Remove unused variable `i'.
6261
6262 * w32font.c (w32font_draw): Return number of glyphs.
6263 (w32font_open_internal): Remove unused variable `i'.
6264 (w32font_driver): Add missing initializer.
6265
6266 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6267 (fill_in_menu): Remove unused variable `items_added'.
6268
6269 * w32term.c (last_mouse_press_frame): Remove static global variable.
6270 (w32_clip_to_row): Remove unused variable `f'.
6271 (x_delete_terminal): Remove unused variable `i'.
6272
6273 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6274 (NOTHING): Remove unused static global variable.
6275 (uniscribe_check_otf): Remove unused variable `table'.
6276 (uniscribe_font_driver): Add missing initializers.
6277
6278 2011-03-23 Julien Danjou <julien@danjou.info>
6279
6280 * term.c (Fsuspend_tty, Fresume_tty):
6281 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6282 * window.c (temp_output_buffer_show):
6283 * insdel.c (signal_before_change):
6284 * frame.c (Fhandle_switch_frame):
6285 * fileio.c (Fdo_auto_save):
6286 * emacs.c (Fkill_emacs):
6287 * editfns.c (save_excursion_restore):
6288 * cmds.c (internal_self_insert):
6289 * callint.c (Fcall_interactively):
6290 * buffer.c (Fkill_all_local_variables):
6291 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6292 Use Frun_hooks.
6293 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6294 unconditionnaly since it does the check itself.
6295
6296 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6297
6298 Fix more problems found by GCC 4.5.2's static checks.
6299
6300 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6301 the first time through the loop, since we know p0 < p1 then.
6302 This also avoids a gcc -Wstrict-overflow warning.
6303
6304 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6305 leading to a memory leak, possible in functions like
6306 load_charset_map_from_file that can allocate an unbounded number
6307 of objects (Bug#8318).
6308
6309 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6310 that could (at least in theory) be that large.
6311
6312 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6313 This is less likely to overflow, and avoids undefined behavior if
6314 overflow does occur. All callers changed. Use strtoul to scan
6315 for the unsigned long integer.
6316 (pint2hrstr): Simplify and tune code slightly.
6317 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6318
6319 * scroll.c (do_scrolling): Work around GCC bug 48228.
6320 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6321
6322 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6323 This also avoids a warning with gcc -Wstrict-overflow.
6324 (validate_x_resource_name): Simplify count usage.
6325 This also avoids a warning with gcc -Wstrict-overflow.
6326
6327 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6328 fail (Bug#8306).
6329
6330 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6331
6332 * process.c (Fmake_network_process): Use socklen_t, not int,
6333 where POSIX says socklen_t is required in portable programs.
6334 This fixes a porting bug on hosts like 64-bit HP-UX, where
6335 socklen_t is wider than int (Bug#8277).
6336 (Fmake_network_process, server_accept_connection):
6337 (wait_reading_process_output, read_process_output):
6338 Likewise.
6339
6340 * process.c: Rename or move locals to avoid shadowing.
6341 (list_processes_1, Fmake_network_process):
6342 (read_process_output_error_handler, exec_sentinel_error_handler):
6343 Rename or move locals.
6344 (Fmake_network_process): Define label "retry_connect" only if needed.
6345 (Fnetwork_interface_info): Fix pointer signedness.
6346 (process_send_signal): Add cast to avoid pointer signedness problem.
6347 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6348 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6349
6350 Make tparam.h and terminfo.c consistent.
6351 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6352 Include tparam.h instead, since it declares them.
6353 * cm.h (PC): Remove extern decl; tparam.h now does this.
6354 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6355 * terminfo.c: Include tparam.h, to check interfaces.
6356 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6357 (tparam): Adjust signature to match interface in tparam.h;
6358 this removes some undefined behavior. Check that outstring and len
6359 are zero, which they always are with Emacs.
6360 * tparam.h (PC, BC, UP): New extern decls.
6361
6362 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6363 (xftfont_open): Rename locals to avoid shadowing.
6364
6365 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6366 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6367 (OTF_TAG_SYM): Omit macro if not needed.
6368 (ftfont_list): Remove unused local.
6369 (get_adstyle_property, ftfont_pattern_entity):
6370 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6371 Rename locals to avoid shadowing.
6372
6373 * xfont.c (xfont_list_family): Mark var as initialized.
6374
6375 * xml.c (make_dom): Now static.
6376
6377 * composite.c (composition_compute_stop_pos): Rename local to
6378 avoid shadowing.
6379 (composition_reseat_it): Remove unused locals.
6380 (find_automatic_composition, composition_adjust_point): Likewise.
6381 (composition_update_it): Mark var as initialized.
6382 (find_automatic_composition): Mark vars as initialized,
6383 with a FIXME (Bug#8290).
6384
6385 character.h: Rename locals to avoid shadowing.
6386 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6387 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6388 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6389 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6390 to avoid shadowing.
6391
6392 * textprop.c (property_change_between_p): Remove; unused.
6393
6394 * intervals.c (interval_start_pos): Now static.
6395
6396 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6397
6398 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6399 Rename locals to avoid shadowing.
6400
6401 * sound.c (wav_play, au_play, Fplay_sound_internal):
6402 Fix pointer signedness.
6403 (alsa_choose_format): Remove unused local var.
6404 (wav_play): Initialize a variable to 0, to prevent undefined
6405 behavior (Bug#8278).
6406
6407 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6408
6409 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6410
6411 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6412 clobbering (Bug#8298).
6413 * sysdep.c (sys_subshell): Likewise.
6414 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6415
6416 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6417 This should get cleaned up, so that child_setup has the
6418 same signature on all platforms.
6419
6420 * callproc.c (call_process_cleanup): Now static.
6421 (relocate_fd): Rename locals to avoid shadowing.
6422
6423 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6424
6425 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6426 not to be necessary, and produces flickering.
6427
6428 2011-03-20 Glenn Morris <rgm@gnu.org>
6429
6430 * config.in: Remove file.
6431
6432 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6433
6434 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6435 are now in src/globals.h.
6436 (syms_of_minibuf): Remove spurious & from previous change.
6437
6438 2011-03-20 Leo <sdl.web@gmail.com>
6439
6440 * minibuf.c (completing-read-function): New variable.
6441 (completing-read-default): Rename from completing-read.
6442 (completing-read): Call completing-read-function.
6443
6444 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6445
6446 * xfaces.c (Fx_load_color_file):
6447 Read color file from absolute filename (bug#8250).
6448
6449 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6450
6451 * makefile.w32-in: Update dependencies.
6452
6453 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6454
6455 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6456
6457 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6458
6459 Fix more problems found by GCC 4.5.2's static checks.
6460
6461 * process.c (make_serial_process_unwind, send_process_trap):
6462 (sigchld_handler): Now static.
6463
6464 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6465 That way, the code declares only the vars that it needs.
6466 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6467 * s/cygwin.h (PTY_ITERATION): Likewise.
6468 * s/darwin.h (PTY_ITERATION): Likewise.
6469 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6470
6471 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6472 * process.c (allocate_pty): Don't declare stb unless it's needed.
6473
6474 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6475 (CONSTANTLIM): Remove; unused.
6476 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6477 Define only if needed.
6478
6479 * unexelf.c (unexec): Name an expression,
6480 to avoid gcc -Wbad-function-cast warning.
6481 Use a different way to cause a compilation error if anyone uses
6482 n rather than nn, a way that does not involve shadowing.
6483 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6484
6485 * deps.mk (unexalpha.o): Remove; unused.
6486
6487 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6488 * unexec.h: New file.
6489 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6490 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6491 Depend on unexec.h.
6492 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6493 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6494 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6495 Change as necessary to match prototype in unexec.h.
6496
6497 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6498 shadowing.
6499 (back_comment, skip_chars): Mark vars as initialized.
6500
6501 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6502 Rename locals to avoid shadowing.
6503
6504 * lread.c (read1): Rewrite so as not to use empty "else".
6505 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6506
6507 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6508
6509 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6510 warning when compiling print.c.
6511
6512 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6513 instead of using an uninitialized var.
6514 (font_sort_entities): Mark var as initialized.
6515
6516 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6517
6518 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6519 pointers to constants.
6520 (font_parse_fcname): Remove unused vars.
6521 (font_delete_unmatched): Now static.
6522 (font_get_spec): Remove; unused.
6523 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6524 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6525 Rename or move locals to avoid shadowing.
6526
6527 * fns.c (require_nesting_list, require_unwind): Now static.
6528 (Ffillarray): Rename locals to avoid shadowing.
6529
6530 * floatfns.c (domain_error2): Define only if needed.
6531 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6532
6533 * alloc.c (mark_backtrace): Move decl from here ...
6534 * lisp.h: ... to here, so that it can be checked.
6535
6536 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6537 (Fdefvar): Rewrite so as not to use empty "else".
6538 (lisp_indirect_variable): Name an expression,
6539 to avoid gcc -Wbad-function-cast warning.
6540 (Fdefvar): Rename locals to avoid shadowing.
6541
6542 * callint.c (quotify_arg, quotify_args): Now static.
6543 (Fcall_interactively): Rename locals to avoid shadowing.
6544 Use const pointer when appropriate.
6545
6546 * lisp.h (get_system_name, get_operating_system_release):
6547 Move decls here, to check interfaces.
6548 * process.c (get_operating_system_release): Move decl to lisp.h.
6549 * xrdb.c (get_system_name): Likewise.
6550 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6551 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6552 some of which prompt warnings from gcc -Wbad-function-cast.
6553 (Fformat_time_string, Fencode_time, Finsert_char):
6554 (Ftranslate_region_internal, Fformat):
6555 Rename or remove local vars to avoid shadowing.
6556 (Ftranslate_region_internal): Mark var as initialized.
6557
6558 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6559 avoid shadowing.
6560
6561 * lisp.h (eassert): Check that the argument compiles, even if
6562 ENABLE_CHECKING is not defined.
6563
6564 * data.c (Findirect_variable): Name an expression, to avoid
6565 gcc -Wbad-function-cast warning.
6566 (default_value, arithcompare, arith_driver, arith_error): Now static.
6567 (store_symval_forwarding): Rename local to avoid shadowing.
6568 (Fmake_variable_buffer_local, Fmake_local_variable):
6569 Mark variables as initialized.
6570 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6571
6572 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6573 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6574 Rename locals to avoid shadowing.
6575 (mark_stack): Move local variables into the #ifdef region where
6576 they're used.
6577 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6578 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6579 needed otherwise.
6580 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6581 (GC_STRING_CHARS): Remove; not used.
6582 (Fmemory_limit): Cast sbrk's returned value to char *.
6583
6584 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6585 avoids undefined behavior in theory.
6586
6587 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6588
6589 Use functions, not macros, for up- and down-casing (Bug#8254).
6590 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6591 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6592 to use the following functions instead of these macros.
6593 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6594 EMACS_INT, since callers assume the returned value fits in int.
6595 (upcase1): Likewise, for UPCASE_TABLE.
6596 (uppercasep, lowercasep, upcase): New static inline functions.
6597 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6598 the race-condition problem in the old DOWNCASE.
6599
6600 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6601 Rename locals to avoid shadowing.
6602 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6603 (regex_compile, re_search_2, re_match_2_internal):
6604 Remove unused local vars.
6605 (FREE_VAR): Rewrite so as not to use empty "else",
6606 which gcc can warn about.
6607 (regex_compile, re_match_2_internal): Mark locals as initialized.
6608 (RETALLOC_IF): Define only if needed.
6609 (WORDCHAR_P): Likewise. This one is never needed, but is used
6610 only in a comment talking about a compiler bug, so put inside
6611 the #if 0 of that comment.
6612 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6613 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6614 Remove; unused.
6615
6616 * search.c (boyer_moore): Rename locals to avoid shadowing.
6617 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6618 (PREV_CHAR_BOUNDARY): Likewise.
6619
6620 * search.c (simple_search): Remove unused var.
6621
6622 * dired.c (compile_pattern): Move decl from here ...
6623 * lisp.h: ... to here, so that it can be checked.
6624 (struct re_registers): New forward decl.
6625
6626 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6627
6628 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6629 All uses changed.
6630 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6631 Rename locals to avoid shadowing.
6632 (Fvertical_motion): Mark locals as initialized.
6633
6634 * casefiddle.c (casify_object, casify_region): Now static.
6635 (casify_region): Mark local as initialized.
6636
6637 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6638
6639 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6640 New macros, so that the caller can use some names other than
6641 gcpro1, gcpro2, etc.
6642 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6643 of the new macros.
6644 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6645 argument, for consistency with GCPRO2_VAR, etc: it is now the
6646 prefix of the variable, not the variable itself. All uses
6647 changed.
6648 * dired.c (directory_files_internal, file_name_completion):
6649 Rename locals to avoid shadowing.
6650
6651 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6652 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6653 dired.c's scmp function, had undefined behavior.
6654 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6655 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6656 * buffer.h: ... to here, because these macros use current_buffer,
6657 and the new implementation with inline functions needs to have
6658 current_buffer in scope now, rather than later when the macros
6659 are used.
6660 (downcase, upcase1): New static inline functions.
6661 (DOWNCASE, UPCASE1): Reimplement using these functions.
6662 This avoids undefined behavior in expressions like
6663 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6664 from race conditions in accessing the global variables
6665 case_temp1 and case_temp2.
6666 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6667 * lisp.h (case_temp1, case_temp2): Remove their decls.
6668 * character.h (ASCII_CHAR_P): Move from here ...
6669 * lisp.h: ... to here, so that the inline functions mentioned
6670 above can use them.
6671
6672 * dired.c (directory_files_internal_unwind): Now static.
6673
6674 * fileio.c (file_name_as_directory, directory_file_name):
6675 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6676 Now static.
6677 (file_name_as_directory): Use const pointers when appropriate.
6678 (Fexpand_file_name): Likewise. In particular, newdir might
6679 point at constant storage, so make it a const pointer.
6680 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6681 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6682 signedness issues.
6683 (Fset_file_times, Finsert_file_contents, auto_save_error):
6684 Rename locals to avoid shadowing.
6685
6686 * minibuf.c (choose_minibuf_frame_1): Now static.
6687 (Ftry_completion, Fall_completions): Rename or remove locals
6688 to avoid shadowing.
6689
6690 * marker.c (bytepos_to_charpos): Remove; unused.
6691
6692 * lisp.h (verify_bytepos, count_markers): New decls,
6693 so that gcc does not warn that these functions aren't declared.
6694
6695 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6696 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6697 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6698 (copy_text): Remove unused local var.
6699
6700 * filelock.c (within_one_second): Now static.
6701 (lock_file_1): Rename local to avoid shadowing.
6702
6703 * buffer.c (fix_overlays_before): Mark locals as initialized.
6704 (fix_start_end_in_overlays): Likewise. This function should be
6705 simplified by using pointers-to-pointers, but that's a different
6706 matter.
6707 (switch_to_buffer_1): Now static.
6708 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6709 (report_overlay_modification): Rename locals to avoid shadowing.
6710
6711 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6712 Fix pointer signedness issue.
6713 (sys_subshell): Mark local as volatile if checking for lint,
6714 to suppress a gcc -Wclobbered warning that does not seem to be right.
6715 (MAXPATHLEN): Define only if needed.
6716
6717 * process.c (serial_open, serial_configure): Move decls from here ...
6718 * systty.h: ... to here, so that they can be checked.
6719
6720 * fns.c (get_random, seed_random): Move extern decls from here ...
6721 * lisp.h: ... to here, so that they can be checked.
6722
6723 * sysdep.c (reset_io): Now static.
6724 (wait_for_termination_signal): Remove; unused.
6725
6726 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6727 (copy_keymap_item, append_key, push_text_char_description):
6728 Now static.
6729 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6730 (DENSE_TABLE_SIZE): Remove; unused.
6731 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6732 (describe_map_tree):
6733 Rename locals to avoid shadowing.
6734
6735 * keyboard.c: Declare functions static if they are not used elsewhere.
6736 (echo_char, echo_dash, cmd_error, top_level_2):
6737 (poll_for_input, handle_async_input): Now static.
6738 (read_char, kbd_buffer_get_event, make_lispy_position):
6739 (make_lispy_event, make_lispy_movement, apply_modifiers):
6740 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6741 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6742 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6743 (read_key_sequence, read_char): Mark locals as initialized.
6744 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6745
6746 * keyboard.h (make_ctrl_char): New decl.
6747 (mark_kboards): Move decl here ...
6748 * alloc.c (mark_kboards): ... from here.
6749
6750 * lisp.h (force_auto_save_soon): New decl.
6751
6752 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6753 (DEFINE_DUMMY_FUNCTION): New macro.
6754 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6755 Use it.
6756 (main): Add casts to avoid warnings
6757 if GCC considers string literals to be constants.
6758
6759 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6760
6761 * dbusbind.c: Pointer signedness fixes.
6762 (xd_signature, xd_append_arg, xd_initialize):
6763 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6764 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6765 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6766 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6767
6768 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6769 if GCC considers string literals to be constants.
6770 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6771
6772 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6773
6774 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6775 (print_preprocess, print_object): New macro to fix last change.
6776
6777 * print.c (print_preprocess): Don't forget font objects.
6778
6779 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6780
6781 * emacs.c (USAGE3): Doc fixes.
6782
6783 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6784
6785 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6786 structure.
6787
6788 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6789
6790 * lisp.h (VWindow_system, Qfile_name_history):
6791 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6792 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6793 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6794
6795 * w32select.c: Don't #include "keyboard.h".
6796 (run_protected): Add extern declaration for waiting_for_input.
6797
6798 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6799 * w32console.c (detect_input_pending, read_input_pending)
6800 (encode_terminal_code):
6801 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6802 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6803 (w32_system_caret_y, Qfile_name_history):
6804 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6805 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6806 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6807 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6808 * w32proc.c (Qlocal, report_file_error):
6809 * w32term.c (Vwindow_system, updating_frame):
6810 * w32uniscribe.c (initialized, uniscribe_font_driver):
6811 Remove unneeded extern declarations.
6812
6813 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6814
6815 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6816
6817 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6818
6819 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6820 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6821 These macros can no longer be used for assignment.
6822
6823 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6824 Assign struct members directly, instead of using BUF_BEGV etc.
6825 (record_buffer_markers, fetch_buffer_markers): New functions for
6826 recording and fetching special buffer markers.
6827 (set_buffer_internal_1, set_buffer_temp): Use them.
6828
6829 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6830
6831 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6832
6833 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6834 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6835
6836 * xdisp.c (hscroll_window_tree):
6837 (reconsider_clip_changes): Use PT instead of BUF_PT.
6838
6839 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6840
6841 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6842 $(EMACS_ROOT)/lib/intprops.h.
6843
6844 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6845
6846 Fix more problems found by GCC 4.5.2's static checks.
6847
6848 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6849 to unsigned char * to avoid compiler diagnostic.
6850 (xg_free_frame_widgets): Make it clear that a local variable is
6851 needed only if USE_GTK_TOOLTIP.
6852 (gdk_window_get_screen): Make it clear that this macro is needed
6853 only if USE_GTK_TOOLTIP.
6854 (int_gtk_range_get_value): New function, which avoids a diagnostic
6855 from gcc -Wbad-function-cast.
6856 (xg_set_toolkit_scroll_bar_thumb): Use it.
6857 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6858 diagnostic from gcc -Wbad-function-cast.
6859 (get_utf8_string, xg_get_file_with_chooser):
6860 Rename locals to avoid shadowing.
6861 (create_dialog): Move locals to avoid shadowing.
6862
6863 * xgselect.c (xg_select): Remove unused var.
6864
6865 * image.c (four_corners_best): Mark locals as initialized.
6866 (gif_load): Initialize transparent_p to zero (Bug#8238).
6867 Mark another local as initialized.
6868 (my_png_error, my_error_exit): Mark with NO_RETURN.
6869
6870 * image.c (clear_image_cache): Now static.
6871 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6872 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6873 (x_edge_detection): Remove unnecessary cast that
6874 gcc -Wbad-function-cast diagnoses.
6875 (gif_load): Fix pointer signedness.
6876 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6877 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6878
6879 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6880
6881 Improve quality of tests for time stamp overflow.
6882 For example, without this patch (encode-time 0 0 0 1 1
6883 1152921504606846976) returns the obviously-bogus value (-948597
6884 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6885 reports time overflow. See
6886 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6887 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6888 * editfns.c: Include limits.h and intprops.h.
6889 (TIME_T_MIN, TIME_T_MAX): New macros.
6890 (time_overflow): Move earlier, to before first use.
6891 (hi_time, lo_time): New functions, for an accurate test for
6892 out-of-range times.
6893 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6894 (Fget_internal_run_time): Don't assume time_t fits in int.
6895 (make_time): Use list2 instead of Fcons twice.
6896 (Fdecode_time): More accurate test for out-of-range times.
6897 (check_tm_member): New function.
6898 (Fencode_time): Use it, to test for out-of-range times.
6899 (lisp_time_argument): Don't rely on undefined left-shift and
6900 right-shift behavior when checking for time stamp overflow.
6901
6902 * editfns.c (time_overflow): New function, refactoring common code.
6903 (Fformat_time_string, Fdecode_time, Fencode_time):
6904 (Fcurrent_time_string): Use it.
6905
6906 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6907 * dired.c (make_time): Move to ...
6908 * editfns.c (make_time): ... here.
6909 * systime.h: Note the move.
6910
6911 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6912
6913 * fringe.c (update_window_fringes): Remove unused variables.
6914
6915 * unexmacosx.c (copy_data_segment): Also copy __got section.
6916 (Bug#8223)
6917
6918 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6919
6920 * termcap.c [MSDOS]: Include "msdos.h".
6921 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6922 Constify `char *' arguments and their references according to
6923 prototypes in tparam.h.
6924
6925 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6926
6927 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6928 Adapt all references accordingly.
6929
6930 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6931
6932 2011-03-11 Tom Tromey <tromey@redhat.com>
6933
6934 * buffer.c (syms_of_buffer): Remove obsolete comment.
6935
6936 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6937
6938 * termhooks.h (encode_terminal_code): Declare prototype.
6939
6940 * msdos.c (encode_terminal_code): Don't declare prototype.
6941
6942 * term.c (encode_terminal_code): Now external again, used by
6943 w32console.c and msdos.c.
6944
6945 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6946 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6947
6948 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6949
6950 Fix some minor problems found by GCC 4.5.2's static checks.
6951
6952 * fringe.c (update_window_fringes): Mark locals as initialized
6953 (Bug#8227).
6954 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6955
6956 * alloc.c (mark_fringe_data): Move decl from here ...
6957 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6958 to check its interface.
6959 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6960
6961 * fontset.c (free_realized_fontset): Now static.
6962 (Fset_fontset_font): Rename local to avoid shadowing.
6963 (fontset_font): Mark local as initialized.
6964 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6965
6966 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6967
6968 * xselect.c (x_disown_buffer_selections): Remove; not used.
6969 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6970 (x_own_selection, Fx_disown_selection_internal): Rename locals
6971 to avoid shadowing.
6972 (x_handle_dnd_message): Remove local to avoid shadowing.
6973
6974 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6975 so that the caller can use some name other than gcpro1.
6976 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6977 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6978 (Fx_backspace_delete_keys_p):
6979 Use them to avoid shadowing, and rename vars to avoid shadowing.
6980 (x_decode_color, x_set_name, x_window): Now static.
6981 (Fx_create_frame): Add braces to silence GCC warning.
6982 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6983 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6984 Remove unused locals.
6985 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6986 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6987 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6988 macros.
6989
6990 * xterm.h (x_mouse_leave): New decl.
6991
6992 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6993 Remove unused functions.
6994 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6995 (x_calc_absolute_position): Now static.
6996 (XTread_socket): Don't define label "out" unless it's used.
6997 Don't declare local "event" unless it's used.
6998 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6999 unless they are used.
7000 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7001 (x_fatal_error_signal): Remove; not used.
7002 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7003 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7004 (x_error_catcher, x_connection_closed, x_error_handler):
7005 (x_error_quitter, xembed_send_message, x_iconify_frame):
7006 (my_log_handler): Rename locals to avoid shadowing.
7007 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7008 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7009
7010 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7011 Rename or move locals to avoid shadowing.
7012 (tty_defined_color, merge_face_heights): Now static.
7013 (free_realized_faces_for_fontset): Remove; not used.
7014 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7015 does not deduce is never used uninitialized.
7016 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7017 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7018
7019 * terminal.c (store_terminal_param): Now static.
7020
7021 * xmenu.c (menu_highlight_callback): Now static.
7022 (set_frame_menubar): Remove unused local.
7023 (xmenu_show): Rename parameter to avoid shadowing.
7024 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7025 since they might point to immutable storage.
7026 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7027 since it's unused otherwise.
7028
7029 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7030 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7031 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7032 avoids a gcc -Wuninitialized diagnostic.
7033 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7034 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7035 does not deduce are never used uninitialized.
7036
7037 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7038
7039 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7040 * window.c (window_loop, size_window):
7041 (run_window_configuration_change_hook, enlarge_window): Likewise.
7042
7043 * window.c (display_buffer): Now static.
7044 (size_window): Mark variables that gcc -Wuninitialized
7045 does not deduce are never used uninitialized.
7046 * window.h (check_all_windows): New decl, to forestall
7047 gcc -Wmissing-prototypes diagnostic.
7048 * dispextern.h (bidi_dump_cached_states): Likewise.
7049
7050 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7051 shadowing.
7052 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7053 Include <limits.h>.
7054 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7055 and to avoid gcc -Wuninitialized warning.
7056 (load_charset_map): Mark variables that gcc -Wuninitialized
7057 does not deduce are never used uninitialized.
7058 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7059
7060 * coding.c (coding_set_source, coding_set_destination):
7061 Use "else { /* comment */ }" rather than "else /* comment */;"
7062 for clarity, and to avoid gcc -Wempty-body warning.
7063 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7064 a block, when the outer 'i' will do.
7065 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7066 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7067 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7068 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7069 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7070 Rename locals to avoid shadowing.
7071 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7072 * coding.c (emacs_mule_char, encode_invocation_designation):
7073 Now static, since they're not used elsewhere.
7074 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7075 (decode_coding_object, encode_coding_object, detect_coding_system):
7076 (decode_coding_emacs_mule): Mark variables that gcc
7077 -Wuninitialized does not deduce are never used uninitialized.
7078 (detect_coding_iso_2022): Initialize a local variable that might
7079 be used uninitialized. Leave a FIXME because it's not clear that
7080 this initialization is needed. (Bug#8211)
7081 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7082 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7083 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7084 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7085 Remove unused macros.
7086
7087 * category.c (hash_get_category_set): Remove unused local var.
7088 (copy_category_table): Now static, since it's not used elsewhere.
7089 * character.c (string_count_byte8): Likewise.
7090
7091 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7092 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7093
7094 * chartab.c (copy_sub_char_table): Now static, since it's not used
7095 elsewhere.
7096 (sub_char_table_ref_and_range, char_table_ref_and_range):
7097 Rename locals to avoid shadowing.
7098 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7099
7100 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7101 (BIDI_BOB): Remove unused macro.
7102
7103 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7104 deduce are never used uninitialized.
7105 * term.c (encode_terminal_code): Likewise.
7106
7107 * term.c (encode_terminal_code): Now static. Remove unused local.
7108
7109 * tparam.h: New file.
7110 * term.c, tparam.h: Include it.
7111 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7112 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7113 Move these decls to tparam.h, and make them agree with what
7114 is actually in tparam.c. The previous trick of using incompatible
7115 decls in different modules does not conform to the C standard.
7116 All callers of tparam changed to use tparam's actual API.
7117 * tparam.c (tparam1, tparam, tgoto):
7118 Use const pointers where appropriate.
7119
7120 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7121 * cm.h (struct cm): Likewise.
7122 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7123 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7124 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7125 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7126 (turn_on_face, init_tty): Likewise.
7127 * termchar.h (struct tty_display_info): Likewise.
7128
7129 * term.c (term_mouse_position): Rename local to avoid shadowing.
7130
7131 * alloc.c (mark_ttys): Move decl from here ...
7132 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7133
7134 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7135
7136 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7137
7138 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7139
7140 * search.c (compile_pattern_1): Remove argument regp, unused since
7141 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7142 (compile_pattern): Don't pass it.
7143
7144 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7145
7146 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7147 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7148 for ! HAVE_GTK3.
7149 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7150
7151 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7152
7153 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7154 gdk_window_get_screen, gdk_window_get_geometry,
7155 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7156 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7157 (xg_get_pixbuf_from_pixmap): New function.
7158 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7159 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7160 Call xg_get_pixbuf_from_pixmap instead of
7161 gdk_pixbuf_get_from_drawable.
7162 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7163 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7164 (xg_check_special_colors): Use GtkStyleContext and its functions
7165 for HAVE_GTK3.
7166 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7167 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7168 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7169 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7170 Call gtk_widget_get_preferred_size.
7171 (xg_frame_resized): gdk_window_get_geometry only takes 5
7172 parameters.
7173 (xg_win_to_widget, xg_event_is_for_menubar):
7174 Call gdk_x11_window_lookup_for_display.
7175 (xg_set_widget_bg): New function.
7176 (delete_cb): New function.
7177 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7178 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7179 (xg_set_background_color): Call xg_set_widget_bg.
7180 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7181 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7182 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7183 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7184 if ! HAVE_GTK3.
7185 (update_frame_tool_bar): Call gtk_widget_hide.
7186 (xg_initialize): Use GDK_KEY_g.
7187
7188 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7189 if ! HAVE_GTK3
7190 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7191
7192 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7193 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7194 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7195
7196 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7197
7198 * w32xfns.c (select_palette): Check success of RealizePalette against
7199 GDI_ERROR, not zero.
7200
7201 See ChangeLog.11 for earlier changes.
7202
7203 ;; Local Variables:
7204 ;; coding: utf-8
7205 ;; End:
7206
7207 Copyright (C) 2011 Free Software Foundation, Inc.
7208
7209 This file is part of GNU Emacs.
7210
7211 GNU Emacs is free software: you can redistribute it and/or modify
7212 it under the terms of the GNU General Public License as published by
7213 the Free Software Foundation, either version 3 of the License, or
7214 (at your option) any later version.
7215
7216 GNU Emacs is distributed in the hope that it will be useful,
7217 but WITHOUT ANY WARRANTY; without even the implied warranty of
7218 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7219 GNU General Public License for more details.
7220
7221 You should have received a copy of the GNU General Public License
7222 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.