1 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3 * fns.c (Frequire): Mention .el.gz files (bug#7314).
5 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7 * window.h (window): Remove clone_number slot.
8 * window.c (Fwindow_clone_number, Fset_window_clone_number):
10 (make_parent_window, make_window, saved_window)
11 (Fset_window_configuration, save_window_save): Don't deal with
13 * buffer.c (Qclone_number): Remove declaration.
14 (sort_overlays, overlay_strings): Don't deal with clone numbers.
16 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
18 Add multiple inheritance to keymaps.
19 * keymap.c (Fmake_composed_keymap): New function.
20 (Fset_keymap_parent): Simplify.
21 (fix_submap_inheritance): Remove.
22 (access_keymap_1): New function extracted from access_keymap to handle
23 embedded parents and handle lists of maps.
24 (access_keymap): Use it.
25 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
26 (Fcopy_keymap): Handle embedded parents.
27 (Fcommand_remapping, define_as_prefix): Simplify.
28 (Fkey_binding): Simplify.
29 (syms_of_keymap): Move minibuffer-local-completion-map,
30 minibuffer-local-filename-completion-map,
31 minibuffer-local-must-match-map, and
32 minibuffer-local-filename-must-match-map to Elisp.
33 (syms_of_keymap): Defsubr make-composed-keymap.
34 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
35 (parse_menu_item): Trivial simplification.
37 2011-07-01 Glenn Morris <rgm@gnu.org>
39 * Makefile.in (SETTINGS_LIBS): Fix typo.
41 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
43 * coding.c (Fencode_coding_string): Record the last coding system
44 used, as the function doc string says (bug#8738).
46 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
48 * xsettings.c (store_monospaced_changed): Take new font as arg and
49 check for change against current_mono_font.
50 (EMACS_TYPE_SETTINGS): Remove this and related defines.
51 (emacs_settings_constructor, emacs_settings_get_property)
52 (emacs_settings_set_property, emacs_settings_class_init)
53 (emacs_settings_init, gsettings_obj): Remove.
54 (something_changedCB): New function for HAVE_GSETTINGS.
55 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
56 with value as argument.
57 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
58 g_settings_new (Bug#8967). Do not create gsettings_obj.
59 Remove calls to g_settings_bind. Connect something_changedCB to
62 * xgselect.c: Add defined (HAVE_GSETTINGS).
63 (xgselect_initialize): Ditto.
65 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
66 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
69 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
71 * eval.c (struct backtrace): Simplify and port the data structure.
72 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
73 signed bit field, as this assumption is not portable and it makes
74 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
75 "char debug_on_exit : 1" as this is not portable either; instead,
76 use the portable "unsigned int debug_on_exit : 1". Remove unused
77 member evalargs. Remove obsolete comments about cc bombing out.
79 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
81 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
82 Let HAVE_GSETTINGS override HAVE_GCONF.
83 (store_monospaced_changed): New function.
84 (EMACS_SETTINGS): A new type derived from GObject to handle
85 GSettings notifications.
86 (emacs_settings_constructor, emacs_settings_get_property)
87 (emacs_settings_set_property, emacs_settings_class_init):
89 (gsettings_client, gsettings_obj): New variables.
90 (GSETTINGS_SCHEMA): New define.
91 (something_changedCB): Call store_monospaced_changed.
92 (init_gsettings): New function.
93 (xsettings_initialize): Call init_gsettings.
94 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
97 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
100 2011-06-29 Martin Rudalics <rudalics@gmx.at>
102 * window.c (resize_root_window, grow_mini_window)
103 (shrink_mini_window): Rename Qresize_root_window to
104 Qwindow_resize_root_window and Qresize_root_window_vertically to
105 Qwindow_resize_root_window_vertically.
107 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
109 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
111 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
113 * makefile.w32-in: Redesign dependencies so they reflect more
114 clearly which files are directly included by each source file,
115 and not through other includes.
117 2011-06-27 Martin Rudalics <rudalics@gmx.at>
119 * buffer.c (Qclone_number): Declare static and DEFSYM it.
120 (sort_overlays, overlay_strings): When an overlay's clone number
121 matches the window's clone number process the overlay even if
122 the overlay's window property doesn't match the current window.
124 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
125 (Fwindow_hchild): Rename to Fwindow_left_child.
126 (Fwindow_next): Rename to Fwindow_next_sibling.
127 (Fwindow_prev): Rename to Fwindow_prev_sibling.
128 (resize_window_check): Rename to window_resize_check.
129 (resize_window_apply): Rename to window_resize_apply.
130 (Fresize_window_apply): Rename to Fwindow_resize_apply.
131 (Fdelete_other_windows_internal, resize_frame_windows)
132 (Fsplit_window_internal, Fdelete_window_internal)
133 (grow_mini_window, shrink_mini_window)
134 (Fresize_mini_window_internal): Fix callers accordingly.
136 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
138 * emacsgtkfixed.h: State that this is only used with Gtk+3.
139 (emacs_fixed_set_min_size): Remove.
140 (emacs_fixed_new): Take frame as argument.
142 * emacsgtkfixed.c: State that this is only used with Gtk+3.
143 (_EmacsFixedPrivate): Remove minwidth/height.
145 (emacs_fixed_init): Initialize priv->f.
146 (get_parent_class, emacs_fixed_set_min_size): Remove.
147 (emacs_fixed_new): Set priv->f to argument.
148 (emacs_fixed_get_preferred_width)
149 (emacs_fixed_get_preferred_height): Use min_width/height from
150 frames size_hint to set minimum and natural (Bug#8919).
151 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
152 and use min_width/height from frames size_hint to set
153 min_width/height (Bug#8919).
155 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
156 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
159 2011-06-26 Eli Zaretskii <eliz@gnu.org>
161 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
162 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
165 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
167 * process.c (wait_reading_process_output): Bypass select if
168 waiting for a cell while ignoring keyboard input, and input is
169 pending. Suggested by Jan Djärv (Bug#8869).
171 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
173 Use gnulib's dup2 module instead of rolling our own.
174 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
176 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
178 * dispnew.c (scrolling_window): Before scrolling, turn off a
179 mouse-highlight in the window being scrolled.
181 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
183 Move DEFSYM to lisp.h and use everywhere.
185 * character.h (DEFSYM): Move declaration...
186 * lisp.h (DEFSYM): ...here.
192 * w32select.c: Don't include character.h.
194 * alloc.c (syms_of_alloc):
195 * buffer.c (syms_of_buffer):
196 * bytecode.c (syms_of_bytecode):
197 * callint.c (syms_of_callint):
198 * casefiddle.c (syms_of_casefiddle):
199 * casetab.c (init_casetab_once):
200 * category.c (init_category_once, syms_of_category):
201 * ccl.c (syms_of_ccl):
202 * cmds.c (syms_of_cmds):
203 * composite.c (syms_of_composite):
204 * dbusbind.c (syms_of_dbusbind):
205 * dired.c (syms_of_dired):
206 * dispnew.c (syms_of_display):
207 * doc.c (syms_of_doc):
208 * editfns.c (syms_of_editfns):
209 * emacs.c (syms_of_emacs):
210 * eval.c (syms_of_eval):
211 * fileio.c (syms_of_fileio):
212 * fns.c (syms_of_fns):
213 * frame.c (syms_of_frame):
214 * fringe.c (syms_of_fringe):
215 * insdel.c (syms_of_insdel):
216 * keymap.c (syms_of_keymap):
217 * lread.c (init_obarray, syms_of_lread):
218 * macros.c (syms_of_macros):
219 * msdos.c (syms_of_msdos):
220 * print.c (syms_of_print):
221 * process.c (syms_of_process):
222 * search.c (syms_of_search):
223 * sound.c (syms_of_sound):
224 * syntax.c (init_syntax_once, syms_of_syntax):
225 * terminal.c (syms_of_terminal):
226 * textprop.c (syms_of_textprop):
227 * undo.c (syms_of_undo):
228 * w32.c (globals_of_w32):
229 * window.c (syms_of_window):
230 * xdisp.c (syms_of_xdisp):
231 * xfaces.c (syms_of_xfaces):
232 * xfns.c (syms_of_xfns):
233 * xmenu.c (syms_of_xmenu):
234 * xsettings.c (syms_of_xsettings):
235 * xterm.c (syms_of_xterm): Use DEFSYM.
237 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
239 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
241 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
243 Integer and buffer overflow fixes (Bug#8873).
245 * print.c (printchar, strout): Check for string overflow.
246 (PRINTPREPARE, printchar, strout):
247 Don't set size unless allocation succeeds.
249 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
250 for sizes. Check for string overflow more accurately.
251 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
253 * macros.c: Integer and buffer overflow fixes.
254 * keyboard.h (struct keyboard.kbd_macro_bufsize):
255 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
256 Use ptrdiff_t, not int, for sizes.
257 Don't increment bufsize until after realloc succeeds.
258 Check for size-calculation overflow.
259 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
261 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
263 * lread.c: Integer overflow fixes.
264 (read_integer): Radix is now EMACS_INT, not int,
265 to improve quality of diagnostics for out-of-range radices.
266 Calculate buffer size correctly for out-of-range radices.
267 (read1): Check for integer overflow in radices, and in
269 (read_escape): Avoid int overflow.
270 (Fload, openp, read_buffer_size, read1)
271 (substitute_object_recurse, read_vector, read_list, map_obarray):
272 Use ptrdiff_t, not int, for sizes.
273 (read1): Use EMACS_INT, not int, for sizes.
274 Check for size overflow.
276 * image.c (cache_image): Check for size arithmetic overflow.
278 * lread.c: Integer overflow issues.
279 (saved_doc_string_size, saved_doc_string_length)
280 (prev_saved_doc_string_size, prev_saved_doc_string_length):
281 Now ptrdiff_t, not int.
282 (read1): Don't assume doc string length fits in int. Check for
283 out-of-range doc string lengths.
284 (read_list): Don't assume file position fits in int.
285 (read_escape): Check for hex character overflow.
287 2011-06-22 Leo Liu <sdl.web@gmail.com>
289 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
290 Move to minibuffer.el.
292 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
294 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
295 The following patches are for when GLYPH_DEBUG && !XASSERT.
296 * dispextern.h (trace_redisplay_p, dump_glyph_string):
297 * dispnew.c (flush_stdout):
298 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
299 Mark as externally visible.
300 * dispnew.c (check_window_matrix_pointers): Now static.
301 * dispnew.c (window_to_frame_vpos):
302 * xfns.c (unwind_create_frame):
303 * xterm.c (x_check_font): Remove unused local.
304 * scroll.c (CHECK_BOUNDS):
305 * xfaces.c (cache_fache): Rename local to avoid shadowing.
306 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
307 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
308 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
309 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
311 (debug_method_add): Use va_list and vsprintf rather than relying
312 on undefined behavior with wrong number of arguments.
313 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
314 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
315 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
316 since we're not interested in debugging glyphs with old libraries.
317 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
318 GCC 4.6.0's static checking.
320 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
322 Integer overflow and signedness fixes (Bug#8873).
323 A few related buffer overrun fixes, too.
325 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
327 * dispextern.h (struct face.stipple):
328 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
329 (x_bitmap_mask, x_allocate_bitmap_record)
330 (x_create_bitmap_from_data, x_create_bitmap_from_file)
331 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
332 (x_create_bitmap_from_xpm_data):
333 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
334 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
336 * xfaces.c (load_pixmap):
337 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
338 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
339 (.bitmaps_last, struct x_output.icon_bitmap):
340 Use ptrdiff_t, not int, for bitmap indexes.
341 (x_allocate_bitmap_record): Check for size overflow.
342 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
344 Use ptrdiff_t, not int, for overlay counts.
345 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
346 * editfns.c (overlays_around, get_pos_property):
347 * textprop.c (get_char_property_and_overlay):
348 * xdisp.c (next_overlay_change, note_mouse_highlight):
349 * xfaces.c (face_at_buffer_position):
350 * buffer.c (OVERLAY_COUNT_MAX): New macro.
351 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
352 (Fnext_overlay_change, Fprevious_overlay_change)
353 (mouse_face_overlay_overlaps, Foverlays_in):
354 Use ptrdiff_t, not int, for sizes.
355 (overlays_at, overlays_in): Check for size-calculation overflow.
357 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
359 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
360 (x_session_initialize): Do not assume string length fits in int.
362 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
363 This is unlikely, but can occur if DPI is outlandish.
365 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
366 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
368 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
369 * xrdb.c (magic_file_p, search_magic_path):
370 Omit last arg SUFFIX; it was always 0. All callers changed.
371 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
373 * xfont.c (xfont_match): Avoid need for strlen.
375 * xfns.c: Don't assume strlen fits in int.
376 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
378 * xdisp.c (message_log_check_duplicate): Return intmax_t,
379 not unsigned long, as we prefer signed integers. All callers changed.
380 Detect integer overflow in repeat count.
381 (message_dolog): Don't assume print length fits in 39 bytes.
382 (display_mode_element): Don't assume strlen fits in int.
384 * termcap.c: Don't assume sizes fit in int and never overflow.
385 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
386 (gobble_line): Check for size-calculation overflow.
388 * minibuf.c (Fread_buffer):
389 * lread.c (intern, intern_c_string):
390 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
391 Don't assume string length fits in int.
393 * keyboard.c (parse_tool_bar_item):
394 * gtkutil.c (style_changed_cb): Avoid need for strlen.
396 * font.c: Don't assume string length fits in int.
397 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
398 Use ptrdiff_t, not int.
399 (font_intern_prop): Don't assume string length fits in int.
400 Don't assume integer property fits in fixnum.
401 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
403 * filelock.c: Fix some buffer overrun and integer overflow issues.
404 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
405 Reformulate so as not to need the command string.
406 Invoke gzip -cd rather than gunzip, as it's more portable.
407 (lock_info_type, lock_file_1, lock_file):
408 Don't assume pid_t and time_t fit in unsigned long.
409 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
410 (current_lock_owner): Prefer signed type for sizes.
411 Use memcpy, not strncpy, where memcpy is what is really wanted.
412 Don't assume (via atoi) that time_t and pid_t fit in int.
413 Check for time_t and/or pid_t out of range, e.g., via a network share.
414 Don't alloca where an auto var works fine.
416 * fileio.c: Fix some integer overflow issues.
417 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
418 Don't assume string length fits in int.
419 (directory_file_name): Don't assume string length fits in long.
420 (make_temp_name): Don't assume pid fits in int, or that its print
421 length is less than 20.
423 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
425 * coding.c (make_subsidiaries): Don't assume string length fits in int.
427 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
429 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
430 We prefer signed integers, even for size calculations.
432 * emacs.c: Don't assume string length fits in 'int'.
433 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
434 (main): Don't invoke strlen when not needed.
436 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
437 (XD_DEBUG_MESSAGE): Don't waste a byte.
439 * callproc.c (getenv_internal_1, getenv_internal)
441 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
443 * lread.c (invalid_syntax): Omit length argument.
444 All uses changed. This doesn't fix a bug, but it simplifies the
445 code away from its former Hollerith-constant appearance, and it's
446 one less 'int' to worry about when looking at integer-overflow issues.
447 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
449 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
450 This didn't break anything, but it didn't help either.
451 It's confusing to put a bogus integer in a place where the actual
452 value does not matter.
453 (LIST_END_P): Remove unused macro and its bogus comment.
454 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
456 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
457 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
459 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
460 We prefer signed types, and the value cannot exceed the EMACS_INT
461 range anyway (because otherwise the length would not be representable).
462 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
463 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
464 This avoids a GCC warning when WIDE_EMACS_INT.
466 * indent.c (sane_tab_width): New function.
467 (current_column, scan_for_column, Findent_to, position_indentation)
468 (compute_motion): Use it. This is just for clarity.
469 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
471 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
473 * lisp.h (lint_assume): New macro.
474 * composite.c (composition_gstring_put_cache):
475 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
477 * editfns.c, insdel.c:
478 Omit unnecessary forward decls, to simplify future changes.
480 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
482 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
484 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
485 Use much-faster test for byte-length change.
486 Don't assume string byte-length fits in 'int'.
487 Check that character arg fits in 'int'.
488 (mapcar1): Declare byte as byte, for clarity.
490 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
492 * fns.c (concat): Catch string overflow earlier.
493 Do not rely on integer wraparound.
495 * dispextern.h (struct it.overlay_strings_charpos)
496 (struct it.selective): Now EMACS_INT, not int.
497 * xdisp.c (forward_to_next_line_start)
498 (back_to_previous_visible_line_start)
499 (reseat_at_next_visible_line_start, next_element_from_buffer):
500 Don't arbitrarily truncate the value of 'selective' to int.
502 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
504 * composite.c: Don't truncate sizes to 'int'.
505 (composition_gstring_p, composition_reseat_it)
506 (composition_adjust_point): Use EMACS_INT, not int.
507 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
508 not EMACS_UINT, for indexes.
510 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
512 * buffer.c: Include <verify.h>.
513 (struct sortvec.priority, struct sortstr.priority):
514 Now EMACS_INT, not int.
515 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
516 (struct sortstr.size, record_overlay_string)
517 (struct sortstrlist.size, struct sortlist.used):
518 Don't truncate size to int.
519 (record_overlay_string): Check for size-calculation overflow.
520 (init_buffer_once): Check at compile-time, not run-time.
522 2011-06-22 Jim Meyering <meyering@redhat.com>
524 Don't leak an XBM-image-sized buffer
525 * image.c (xbm_load): Free the image buffer after using it.
527 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
530 * composite.c (find_automatic_composition): Omit needless 'return 0;'
531 that Sun C diagnosed.
532 * fns.c (secure_hash): Fix pointer signedness issue.
533 * intervals.c (static_offset_intervals): New function.
534 (offset_intervals): Use it.
536 2011-06-21 Leo Liu <sdl.web@gmail.com>
539 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
542 * fns.c (secure_hash): Rename from crypto_hash_function and change
543 the first arg to accept symbols.
544 (Fsecure_hash): New primitive.
545 (syms_of_fns): New symbols.
547 2011-06-20 Deniz Dogan <deniz@dogan.se>
549 * process.c (Fset_process_buffer): Clarify return value in
552 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
554 * dispnew.c (add_window_display_history): Use BVAR.
556 * xdisp.c (debug_method_add): Use BVAR.
557 (check_window_end, dump_glyph_matrix, dump_glyph)
558 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
560 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
563 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
564 check till after the cache is created in init_frame_faces.
566 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
568 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
570 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
572 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
573 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
574 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
576 Improve buffer-overflow checking (Bug#8873).
577 * fileio.c (Finsert_file_contents):
578 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
579 Remove the old (too-loose) buffer overflow checks.
580 They weren't needed, since make_gap checks for buffer overflow.
581 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
582 The old code merely checked for Emacs fixnum overflow, and relied
583 on undefined (wraparound) behavior. The new code avoids undefined
584 behavior, and also checks for ptrdiff_t and/or size_t overflow.
586 * editfns.c (Finsert_char): Don't dump core with very negative counts.
587 Tune. Don't use wider integers than needed. Don't use alloca.
588 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
590 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
592 * insdel.c, lisp.h (buffer_overflow): New function.
593 (insert_from_buffer_1, replace_range, replace_range_2):
594 * insdel.c (make_gap_larger):
595 * editfns.c (Finsert_char):
596 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
598 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
600 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
602 Integer overflow and signedness fixes (Bug#8873).
604 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
605 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
607 * fileio.c: Don't assume EMACS_INT fits in off_t.
608 (emacs_lseek): New static function.
609 (Finsert_file_contents, Fwrite_region): Use it.
610 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
612 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
614 * fns.c: Don't overflow int when computing a list length.
615 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
616 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
617 truncation on 64-bit hosts. Check for QUIT every
618 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
619 faster and is responsive enough.
620 (Flength): Report an error instead of overflowing an integer.
621 (Fsafe_length): Return a float if the value is not representable
622 as a fixnum. This shouldn't happen except in contrived situations.
623 (Fnthcdr, Fsort): Don't assume list length fits in int.
624 (Fcopy_sequence): Don't assume vector length fits in int.
626 * alloc.c: Check that resized vectors' lengths fit in fixnums.
627 (header_size, word_size): New constants.
628 (allocate_vectorlike): Don't check size overflow here.
629 (allocate_vector): Check it here instead, since this is the only
630 caller of allocate_vectorlike that could cause overflow.
631 Check that the new vector's length is representable as a fixnum.
633 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
634 The previous code was bogus. For example, next_almost_prime (32)
635 returned 39, which is undesirable as it is a multiple of 3; and
636 next_almost_prime (24) returned 25, which is a multiple of 5 so
637 why was the code bothering to check for multiples of 7?
639 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
641 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
643 Variadic C functions now count arguments with ptrdiff_t.
644 This partly undoes my 2011-03-30 change, which replaced int with size_t.
645 Back then I didn't know that the Emacs coding style prefers signed int.
646 Also, in the meantime I found a few more instances where arguments
647 were being counted with int, which may truncate counts on 64-bit
648 machines, or EMACS_INT, which may be unnecessarily wide.
649 * lisp.h (struct Lisp_Subr.function.aMANY)
650 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
651 Arg counts are now ptrdiff_t, not size_t.
652 All variadic functions and their callers changed accordingly.
653 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
654 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
655 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
656 * callint.c (Fcall_interactively): Check arg count for overflow,
657 to avoid potential buffer overrun. Use signed char, not 'int',
658 for 'varies' array, so that we needn't bother to check its size
659 calculation for overflow.
660 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
661 * eval.c (apply_lambda):
662 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
663 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
664 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
666 * callint.c (Fcall_interactively): Don't use index var as event count.
668 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
669 * mem-limits.h (SIZE): Remove; no longer used.
671 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
673 Remove unnecessary casts.
674 * xterm.c (x_term_init):
675 * xfns.c (x_set_border_pixel):
676 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
677 These aren't needed now that we assume ANSI C.
679 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
680 It's more likely to cause problems (due to unsigned overflow)
683 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
685 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
687 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
689 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
691 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
693 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
695 GLYPH_CODE_FACE returns EMACS_INT, not int.
696 * dispextern.h (merge_faces):
697 * xfaces.c (merge_faces):
698 * xdisp.c (get_next_display_element, next_element_from_display_vector):
699 Don't assume EMACS_INT fits in int.
701 * character.h (CHAR_VALID_P): Remove unused parameter.
702 * fontset.c, lisp.h, xdisp.c: All uses changed.
704 * editfns.c (Ftranslate_region_internal): Omit redundant test.
706 * fns.c (concat): Minor tuning based on overflow analysis.
707 This doesn't fix any bugs. Use int to hold character, instead
708 of constantly refetching from Emacs object. Use XFASTINT, not
709 XINT, for value known to be a character. Don't bother comparing
710 a single byte to 0400, as it's always less.
712 * floatfns.c (Fexpt):
713 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
715 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
718 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
720 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
721 Without this fix, on a 64-bit host (aset S 0 4294967386) would
722 incorrectly succeed when S was a string, because 4294967386 was
723 truncated before it was used.
725 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
726 Otherwise, an out-of-range integer could cause undefined behavior
729 * composite.c: Use int, not EMACS_INT, for characters.
730 (fill_gstring_body, composition_compute_stop_pos): Use int, not
731 EMACS_INT, for values that are known to be in character range.
732 This doesn't fix any bugs but is the usual style inside Emacs and
733 may generate better code on 32-bit machines.
735 Make sure a 64-bit char is never passed to ENCODE_CHAR.
736 This is for reasons similar to the recent CHAR_STRING fix.
737 * charset.c (Fencode_char): Check that character arg is actually
738 a character. Pass an int to ENCODE_CHAR.
739 * charset.h (ENCODE_CHAR): Verify that the character argument is no
740 wider than 'int', as a compile-time check to prevent future regressions
743 * character.c (char_string): Remove unnecessary casts.
745 Make sure a 64-bit char is never passed to CHAR_STRING.
746 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
747 by silently ignoring the top 32 bits, allowing some values
748 that were far too large to be valid characters.
749 * character.h: Include <verify.h>.
750 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
751 arguments are no wider than unsigned, as a compile-time check
752 to prevent future regressions in this area.
754 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
755 (Fsubst_char_in_region):
757 * xdisp.c (decode_mode_spec_coding):
758 Adjust to CHAR_STRING's new requirement.
759 * editfns.c (Finsert_char, Fsubst_char_in_region):
760 * fns.c (concat): Check that character args are actually
761 characters. Without this test, these functions did the wrong
762 thing with wildly out-of-range values on 64-bit hosts.
764 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
765 These casts should not be needed on 32-bit hosts, either.
766 * keyboard.c (read_char):
767 * lread.c (Fload): Remove casts to unsigned.
769 * lisp.h (UNSIGNED_CMP): New macro.
770 This fixes comparison bugs on 64-bit hosts.
771 (ASCII_CHAR_P): Use it.
772 * casefiddle.c (casify_object):
773 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
774 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
775 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
776 * dispextern.h (FACE_FROM_ID):
777 * keyboard.c (read_char): Use UNSIGNED_CMP.
779 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
780 not to EMACS_INT, to avoid GCC warning.
782 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
784 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
785 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
786 isn't needed on 32-bit machines.
788 * buffer.c (Fgenerate_new_buffer_name):
789 Use EMACS_INT for count, not int.
790 (advance_to_char_boundary): Return EMACS_INT, not int.
792 * data.c (Qcompiled_function): Now static.
794 * window.c (window_body_lines): Now static.
796 * image.c (gif_load): Rename local to avoid shadowing.
798 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
799 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
800 * alloc.c (make_save_value): Integer argument is now of type
802 (mark_object): Use ptrdiff_t, not int.
803 * lisp.h (pD): New macro.
804 * print.c (print_object): Use it.
806 * alloc.c: Use EMACS_INT, not int, to count objects.
807 (total_conses, total_markers, total_symbols, total_vector_size)
808 (total_free_conses, total_free_markers, total_free_symbols)
809 (total_free_floats, total_floats, total_free_intervals)
810 (total_intervals, total_strings, total_free_strings):
811 Now EMACS_INT, not int. All uses changed.
812 (Fgarbage_collect): Compute overall total using a double, so that
813 integer overflow is less likely to be a problem. Check for overflow
814 when converting back to an integer.
815 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
816 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
817 These were 'int' variables that could overflow on 64-bit hosts;
818 they were never used, so remove them instead of repairing them.
819 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
820 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
821 Previously, this ceilinged at INT_MAX, but that doesn't work on
823 (allocate_pseudovector): Don't use EMACS_INT when int would do.
825 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
826 (allocate_vectorlike): Check for ptrdiff_t overflow.
827 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
828 when a (possibly-narrower) signed value would do just as well.
829 We prefer using signed arithmetic, to avoid comparison confusion.
831 * alloc.c: Catch some string size overflows that we were missing.
832 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
833 for convenience in STRING_BYTES_MAX.
834 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
835 The definition here is exact; the one in lisp.h was approximate.
836 (allocate_string_data): Check for string overflow. This catches
837 some instances we weren't catching before. Also, it catches
838 size_t overflow on (unusual) hosts where SIZE_MAX <= min
839 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
840 and ptrdiff_t and EMACS_INT are both 64 bits.
842 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
843 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
844 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
846 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
848 * alloc.c (Fmake_string): Check for out-of-range init.
850 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
852 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
854 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
856 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
857 xg_get_default_scrollbar_width.
859 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
860 (int_gtk_range_get_value): Move to the scroll bar part of the file.
861 (style_changed_cb): Call update_theme_scrollbar_width and call
862 x_set_scroll_bar_default_width and xg_frame_set_char_size for
863 all frames (Bug#8505).
864 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
865 Call gtk_window_set_resizable if HAVE_GTK3.
866 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
867 and height if HAVE_GTK3 (Bug#8505).
868 (scroll_bar_width_for_theme): New variable.
869 (update_theme_scrollbar_width): New function.
870 (xg_get_default_scrollbar_width): Move code to
871 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
872 (xg_initialize): Call update_theme_scrollbar_width.
874 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
876 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
878 2011-06-12 Martin Rudalics <rudalics@gmx.at>
880 * frame.c (make_frame): Call other_buffer_safely instead of
883 * window.c (temp_output_buffer_show): Call display_buffer with
884 second argument Vtemp_buffer_show_specifiers and reset latter
885 immediately after the call.
886 (Vtemp_buffer_show_specifiers): New variable.
887 (auto_window_vscroll_p, next_screen_context_lines)
888 (Vscroll_preserve_screen_position): Remove leading asterisks from
891 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
893 Fix minor problems found by GCC 4.6.0 static checking.
894 * buffer.c (Qclone_number): Remove for now, as it's unused.
895 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
896 (record_buffer): Remove unused local.
897 * frame.c (other_visible_frames, frame_buffer_list): Now static.
898 (set_frame_buffer_list): Remove; unused.
899 * frame.h (other_visible_frames): Remove decl.
900 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
901 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
902 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
904 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
905 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
906 Define only if HAVE_GPM.
907 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
908 (update_hints_inhibit): Remove; never set. All uses removed.
909 * widgetprv.h (emacsFrameClassRec): Remove decl.
910 * window.c (delete_deletable_window): Now returns void, since it
911 wasn't returning anything.
912 (compare_window_configurations): Remove unused locals.
913 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
914 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
915 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
916 the same widths as pointers. This follows up on the 2011-05-06 patch.
917 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
919 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
921 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
923 * makefile.w32-in: Update dependencies.
924 (LISP_H): Add lib/intprops.h.
926 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
928 * image.c (gif_load): Add animation frame delay to the metadata.
929 (syms_of_image): Use DEFSYM. New symbol `delay'.
931 2011-06-11 Martin Rudalics <rudalics@gmx.at>
933 * window.c (delete_deletable_window): Re-add.
934 (Fset_window_configuration): Rewrite to handle dead buffers and
935 consequently deletable windows.
936 (window_tree, Fwindow_tree): Remove. Supply functionality in
938 (compare_window_configurations): Simplify code.
940 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
942 * image.c (imagemagick_load_image): Fix type mismatch.
943 (Fimagemagick_types): Likewise.
945 * window.h (replace_buffer_in_windows): Declare.
947 2011-06-11 Martin Rudalics <rudalics@gmx.at>
949 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
950 Qclone_number. Remove external declaration of Qdelete_window.
951 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
953 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
954 Qbuffer_list_update_hook if allowed.
955 (Fother_buffer): Rewrite doc-string. Major rewrite for new
956 buffer list implementation.
957 (other_buffer_safely): New function.
958 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
959 calls to replace_buffer_in_windows and
960 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
962 (record_buffer): Inhibit quitting and rewrite using quittable
963 functions. Run Qbuffer_list_update_hook if allowed.
964 (Frecord_buffer, Funrecord_buffer): New functions.
965 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
966 switch-to-buffer to window.el.
967 (bury-buffer): Move to window.el.
968 (Vbuffer_list_update_hook): New variable.
970 * lisp.h (other_buffer_safely): Add prototype in buffer.c
973 * window.h (resize_frame_windows): Move up in code.
974 (Fwindow_frame): Remove EXFUN.
975 (replace_buffer_in_all_windows): Remove prototype.
976 (replace_buffer_in_windows_safely): Add prototype.
978 * window.c: Declare Qdelete_window static again. Move down
979 declaration of select_count.
980 (Fnext_window, Fprevious_window): Rewrite doc-strings.
981 (Fother_window): Move to window.el.
982 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
983 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
984 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
986 (replace_buffer_in_windows): Implement by calling
987 Qreplace_buffer_in_windows.
988 (replace_buffer_in_all_windows): Remove with some functionality
989 moved into replace_buffer_in_windows_safely.
990 (replace_buffer_in_windows_safely): New function.
991 (select_window_norecord, select_frame_norecord): Move in front
992 of run_window_configuration_change_hook. Remove now obsolete
994 (Fset_window_buffer): Rewrite doc-string. Call
995 Qrecord_window_buffer.
996 (keys_of_window): Move binding for other-window to window.el.
998 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1000 * dispextern.h (struct image): Replace data member, whose int_val
1001 and ptr_val fields were not used by anything, with a single
1004 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1005 (gif_clear_image, gif_load, imagemagick_load_image)
1006 (gs_clear_image, gs_load): Callers changed.
1008 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1010 * buffer.h: Include <time.h>, for time_t.
1011 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1013 Fix minor problems found by static checking.
1015 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1017 Make identifiers static if they are not used in other modules.
1018 * data.c (Qcompiled_function, Qframe, Qvector):
1019 * image.c (QimageMagick, Qsvg):
1020 * minibuf.c (Qmetadata):
1021 * window.c (resize_window_check, resize_root_window): Now static.
1022 * window.h (resize_window_check, resize_root_window): Remove decls.
1024 * window.c (window_deletion_count, delete_deletable_window):
1026 (window_body_lines): Now static.
1027 (Fdelete_other_windows_internal): Mark vars as initialized.
1028 Make sure 'resize_failed' is initialized.
1029 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1030 (resize_window_apply): Remove unused local.
1031 * window.h (delete_deletable_window): Remove decl.
1033 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1034 (imagemagick_load_image): Fix pointer signedness problem by changing
1035 last arg from unsigned char * to char *. All uses changed.
1036 Also, fix a local for similar reasons.
1037 Remove unused locals. Remove locals to avoid shadowing.
1038 (fn_rsvg_handle_free): Remove; unused.
1039 (svg_load, svg_load_image): Fix pointer signedness problem.
1040 (imagemagick_load_image): Don't use garbage pointer image_wand.
1042 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1044 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1046 * image.c (gif_load): Fix omitted cast error introduced by
1049 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1051 * window.h (resize_proportionally, orig_total_lines)
1052 (orig_top_line): Remove from window structure.
1053 (set_window_height, set_window_width, change_window_heights)
1054 (Fdelete_window): Remove prototypes.
1055 (resize_frame_windows): Remove duplicate declaration.
1057 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1059 * window.h (resize_frame_windows, resize_window_check)
1060 (delete_deletable_window, resize_root_window)
1061 (resize_frame_windows): Declare prototypes.
1063 * window.c (resize_window_apply): Make definition be "static" to
1064 match the prototype.
1066 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1068 * window.c: Remove declarations of Qwindow_size_fixed,
1069 window_min_size_1, window_min_size_2, window_min_size,
1070 size_window, window_fixed_size_p, enlarge_window, delete_window.
1071 Remove static from declaration of Qdelete_window, it's
1072 temporarily needed by Fbury_buffer.
1073 (replace_window): Don't assign orig_top_line and
1075 (Fdelete_window, delete_window): Remove. Window deletion is
1076 handled by window.el.
1077 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1078 Fdelete_window calls with calls to Qdelete_window.
1079 (Fdelete_other_windows): Remove. Deleting other windows is
1080 handled by window.el.
1081 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1082 handled in window.el.
1083 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1084 Window minimum sizes are handled in window.el.
1085 (shrink_windows, size_window, set_window_height)
1086 (set_window_width, change_window_heights, window_height)
1087 (window_width, CURBEG, CURSIZE, enlarge_window)
1088 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1089 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1090 handled in window.el.
1091 (make_dummy_parent): Rename to make_parent_window and give it a
1092 second argument horflag.
1093 (make_window): Don't set resize_proportionally any more.
1094 (Fsplit_window): Remove. Windows are split in window.el.
1095 (save_restore_action, save_restore_orig_size)
1096 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1097 Resize mini windows in window.el.
1098 (grow_mini_window, shrink_mini_window): Implement by calling
1099 Qresize_root_window_vertically, resize_window_check and
1100 resize_window_apply.
1101 (saved_window, Fset_window_configuration, save_window_save): Do
1102 not handle orig_top_line, orig_total_lines, and
1103 resize_proportionally.
1104 (window_min_height, window_min_width): Move to window.el.
1105 (keys_of_window): Move bindings for delete-other-windows,
1106 split-window, delete-window and enlarge-window to window.el.
1108 * buffer.c: Temporarily extern Qdelete_window.
1109 (Fbury_buffer): Temporarily call Qdelete_window instead of
1110 Fdelete_window (Fbury_buffer will move to window.el soon).
1112 * frame.c (set_menu_bar_lines_1): Remove code handling
1113 orig_top_line and orig_total_lines.
1115 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1116 set_window_height but set heights directly.
1117 (change_frame_size_1): Use resize_frame_windows.
1119 * xdisp.c (init_xdisp): Don't use set_window_height but set
1122 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1123 resize_frame_windows instead of change_window_heights and run
1124 run_window_configuration_change_hook.
1126 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1127 instead of change_window_heights and run
1128 run_window_configuration_change_hook.
1130 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1132 * window.c (replace_window): Rename second argument REPLACEMENT to
1133 NEW. New third argument SETFLAG. Rewrite.
1134 (delete_window, make_dummy_parent): Call replace_window with
1136 (window_list_1): Move down in code.
1137 (run_window_configuration_change_hook): Move set_buffer part
1138 before select_frame_norecord part in order to unwind correctly.
1139 Rename count1 to count.
1140 (recombine_windows, delete_deletable_window, resize_root_window)
1141 (Fdelete_other_windows_internal)
1142 (Frun_window_configuration_change_hook, make_parent_window)
1143 (resize_window_check, resize_window_apply, Fresize_window_apply)
1144 (resize_frame_windows, Fsplit_window_internal)
1145 (Fdelete_window_internal, Fresize_mini_window_internal): New
1147 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1149 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1151 * window.h (window): Add some new members to window structure -
1152 normal_lines, normal_cols, new_total, new_normal, clone_number,
1153 splits, nest, prev_buffers, next_buffers.
1154 (WINDOW_TOTAL_SIZE): Move here from window.c.
1155 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1157 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1159 (make_dummy_parent): Set new members of windows structure.
1160 (make_window): Move down in code. Handle new members of window
1162 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1163 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1164 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1165 (Fset_window_prev_buffers, Fwindow_next_buffers)
1166 (Fset_window_next_buffers, Fset_window_clone_number): New
1168 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1169 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1171 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1172 Argument WINDOW can be now internal window too.
1173 (Fwindow_use_time): Move up in code.
1174 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1176 (Fset_window_configuration, saved_window)
1177 (Fcurrent_window_configuration, save_window_save): Handle new
1178 members of window structure.
1179 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1180 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1181 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1182 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1183 Qget_mru_window, Qresize_root_window,
1184 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1185 Qauto_buffer_name; staticpro them.
1187 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1189 * window.c (Fwindow_total_size, Fwindow_left_column)
1190 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1191 (Fwindow_list_1): New functions.
1192 (window_box_text_cols): Replace with window_body_cols.
1193 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1194 window_body_cols instead of window_box_text_cols.
1195 (delete_window, Fset_window_configuration): Call
1196 delete_all_subwindows with window as argument.
1197 (delete_all_subwindows): Take a window as argument and not a
1199 (window_loop): Remove handling of GET_LRU_WINDOW and
1201 (Fget_lru_window, Fget_largest_window): Move to window.el.
1203 * window.h: Extern window_body_cols instead of
1204 window_box_text_cols. delete_all_subwindows now takes a
1205 Lisp_Object as argument.
1207 * indent.c (compute_motion, Fcompute_motion): Use
1208 window_body_cols instead of window_box_text_cols.
1210 * frame.c (delete_frame): Call delete_all_subwindows with root
1213 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1215 * fns.c (Fputhash): Document return value.
1217 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1219 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1221 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1223 Cons<->int and similar integer overflow fixes (Bug#8794).
1225 Check for overflow when converting integer to cons and back.
1226 * charset.c (Fdefine_charset_internal, Fdecode_char):
1227 Use cons_to_unsigned to catch overflow.
1228 (Fencode_char): Use INTEGER_TO_CONS.
1229 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1230 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1231 * data.c (long_to_cons, cons_to_long): Remove.
1232 (cons_to_unsigned, cons_to_signed): New functions.
1233 These signal an error for invalid or out-of-range values.
1234 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1235 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1236 * font.c (Ffont_variation_glyphs):
1237 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1238 * lisp.h: Include <intprops.h>.
1239 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1240 (cons_to_signed, cons_to_unsigned): New decls.
1241 (long_to_cons, cons_to_long): Remove decls.
1242 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1243 (Fprimitive_undo): Use CONS_TO_INTEGER.
1244 * xfns.c (Fx_window_property): Likewise.
1245 * xselect.c: Include <limits.h>.
1246 (x_own_selection, selection_data_to_lisp_data):
1247 Use INTEGER_TO_CONS.
1248 (x_handle_selection_request, x_handle_selection_clear)
1249 (x_get_foreign_selection, Fx_disown_selection_internal)
1250 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1251 (lisp_data_to_selection_data): Use cons_to_unsigned.
1252 (x_fill_property_data): Use cons_to_signed.
1253 Report values out of range.
1255 Check for buffer and string overflow more precisely.
1256 * buffer.h (BUF_BYTES_MAX): New macro.
1257 * lisp.h (STRING_BYTES_MAX): New macro.
1258 * alloc.c (Fmake_string):
1259 * character.c (string_escape_byte8):
1260 * coding.c (coding_alloc_by_realloc):
1261 * doprnt.c (doprnt):
1262 * editfns.c (Fformat):
1264 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1265 since they may not be the same number.
1266 * editfns.c (Finsert_char):
1267 * fileio.c (Finsert_file_contents):
1268 Likewise for BUF_BYTES_MAX.
1270 * image.c: Use ptrdiff_t, not int, for sizes.
1271 (slurp_file): Switch from int to ptrdiff_t.
1273 (slurp_file): Check that file size fits in both size_t (for
1274 malloc) and ptrdiff_t (for sanity and safety).
1276 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1277 if b->modtime has its maximal value.
1279 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1281 Don't assume time_t can fit into int.
1282 * buffer.h (struct buffer.modtime): Now time_t, not int.
1283 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1284 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1286 Minor fixes for signed vs unsigned integers.
1287 * character.h (MAYBE_UNIFY_CHAR):
1288 * charset.c (maybe_unify_char):
1289 * keyboard.c (read_char, reorder_modifiers):
1290 XINT -> XFASTINT, since the integer must be nonnegative.
1291 * ftfont.c (ftfont_spec_pattern):
1292 * keymap.c (access_keymap, silly_event_symbol_error):
1293 XUINT -> XFASTINT, since the integer must be nonnegative.
1294 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1295 since it makes no difference and we prefer signed.
1296 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1297 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1300 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1302 * window.h (Fwindow_frame): Declare.
1304 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1306 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1307 (SPARE_MEMORY): Always define.
1308 (LARGE_REQUEST): Remove.
1309 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1311 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1313 * lisp.h: Move EXFUNS for Fframe_root_window,
1314 Fframe_first_window and Fset_frame_selected_window to window.h.
1316 * window.h: Move EXFUNS for Fframe_root_window,
1317 Fframe_first_window and Fset_frame_selected_window here from
1320 * frame.c (Fwindow_frame, Fframe_first_window)
1321 (Fframe_root_window, Fframe_selected_window)
1322 (Fset_frame_selected_window): Move to window.c.
1323 (Factive_minibuffer_window): Move to minibuf.c.
1324 (Fother_visible_frames_p): New function.
1326 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1328 * window.c (decode_window, decode_any_window): Move up in code.
1329 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1330 (inhibit_frame_unsplittable): Remove unused variable.
1331 (Fwindow_buffer): Move up and rewrite doc-string.
1332 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1333 (Fwindow_prev): New functions.
1334 (Fwindow_frame): Move here from frame.c. Accept any window as
1336 (Fframe_root_window, Fframe_first_window)
1337 (Fframe_selected_window): Move here from frame.c. Accept frame
1338 or arbitrary window as argument. Update doc-strings.
1339 (Fminibuffer_window): Move up in code.
1340 (Fwindow_minibuffer_p): Move up in code and simplify.
1341 (Fset_frame_selected_window): Move here from frame.c.
1343 (Fselected_window, select_window, Fselect_window): Move up in
1344 code. Minor doc-string fixes.
1346 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1348 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1349 Do not assume that spare memory exists; that assumption is valid
1350 only if SYSTEM_MALLOC.
1351 (LARGE_REQUEST): New macro, so that the issue of large requests
1352 is separated from the issue of spare memory.
1354 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1356 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1359 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1361 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1364 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1366 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1368 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1370 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1371 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1373 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1375 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1377 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1379 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1380 (x_clipboard_manager_save): Add return value.
1381 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1383 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1384 Obey Vx_select_enable_clipboard_manager. Catch errors in
1385 x_clipboard_manager_save (Bug#8779).
1386 (Vx_select_enable_clipboard_manager): New variable.
1387 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1389 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1391 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1393 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1395 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1396 in the current matrix if keep_current_p is non-zero.
1398 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1400 * bidi.c (bidi_level_of_next_char): Fix last change.
1402 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1404 Support bidi reordering of text covered by display properties.
1406 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1407 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1408 (bidi_cache_search, bidi_cache_iterator_state)
1409 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1410 (bidi_level_of_next_char, bidi_move_to_visually_next):
1411 Support character positions inside a run of characters covered by a
1413 (bidi_paragraph_init, bidi_resolve_explicit_1)
1414 (bidi_level_of_next_char): Call bidi_fetch_char and
1415 bidi_fetch_char_advance instead of FETCH_CHAR and
1417 (bidi_init_it): Initialize new members.
1418 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1420 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1421 instead of using explicit *_CHAR codes.
1422 (bidi_resolve_explicit, bidi_resolve_weak):
1423 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1424 bidirectional text is supported only in multibyte buffers.
1425 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1426 it to initialize the frame_window_p member of struct bidi_it.
1427 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1428 (bidi_resolve_explicit, bidi_resolve_weak)
1429 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1430 bidi_it->nchars is non-positive.
1431 (bidi_level_of_next_char): Don't try to lookup the cache for the
1432 next/previous character if nothing is cached there yet, or if we
1433 were just reseat()'ed to a new position.
1435 * xdisp.c (set_cursor_from_row): Set start and stop points
1436 according to the row's direction when priming the loop that looks
1437 for the glyph on which to display cursor.
1438 (single_display_spec_intangible_p): Function deleted.
1439 (display_prop_intangible_p): Reimplement to call
1440 handle_display_spec instead of single_display_spec_intangible_p.
1441 Accept 3 additional arguments needed by handle_display_spec.
1442 This fixes incorrect cursor motion across display property with complex
1443 values: lists, `(when COND...)' forms, etc.
1444 (single_display_spec_string_p): Support property values that are
1445 lists with the argument STRING its top-level element.
1446 (display_prop_string_p): Fix the condition for processing a
1447 property that is a list to be consistent with handle_display_spec.
1448 (handle_display_spec): New function, refactored from the
1449 last portion of handle_display_prop.
1450 (compute_display_string_pos): Accept additional argument
1451 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1452 value of a `display' property is a "replacing spec".
1453 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1454 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1455 the display property, but just return a value indicating whether
1456 the display property will replace the characters it covers.
1457 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1458 frame_window_p members of struct bidi_it.
1459 (compute_display_string_pos, compute_display_string_end):
1461 (push_it): Accept second argument POSITION, where pop_it should
1462 jump to continue iteration.
1463 (reseat_1): Initialize bidi_it.disp_pos.
1465 * keyboard.c (adjust_point_for_property): Adjust the call to
1466 display_prop_intangible_p to its new signature.
1468 * dispextern.h (struct bidi_it): New member frame_window_p.
1469 (bidi_init_it): Update prototypes.
1470 (display_prop_intangible_p): Update prototype.
1471 (compute_display_string_pos, compute_display_string_end):
1473 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1476 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1478 Malloc failure behavior now depends on size of allocation.
1479 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1480 * lisp.h: Change signatures accordingly.
1481 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1482 All callers changed. (Bug#8762)
1484 * gnutls.c: Use Emacs's memory allocators.
1485 Without this change, the gnutls library would invoke malloc etc.
1486 directly, which causes problems on non-SYNC_INPUT hosts, and which
1487 runs afoul of improving memory_full behavior. (Bug#8761)
1488 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1489 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1490 xfree instead of the default malloc, realloc, free.
1491 (Fgnutls_boot): No need to check for memory allocation failure,
1492 since xmalloc does that for us.
1494 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1495 * category.c (hash_get_category_set):
1496 * ccl.c (ccl_driver):
1497 * charset.c (Fdefine_charset_internal):
1498 * charset.h (struct charset.hash_index):
1499 * composite.c (get_composition_id, gstring_lookup_cache)
1500 (composition_gstring_put_cache):
1501 * composite.h (struct composition.hash_index):
1502 * dispextern.h (struct image.hash):
1503 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1504 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1505 (hashfn_equal, hashfn_user_defined, make_hash_table)
1506 (maybe_resize_hash_table, hash_lookup, hash_put)
1507 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1508 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1509 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1510 * image.c (make_image, search_image_cache, lookup_image)
1511 (xpm_put_color_table_h):
1512 * lisp.h (struct Lisp_Hash_Table):
1513 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1514 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1515 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1516 * alloc.c (allocate_vectorlike):
1517 Check for overflow in vector size calculations.
1518 * ccl.c (ccl_driver):
1519 Check for overflow when converting EMACS_INT to int.
1520 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1521 need to be updated by these changes.
1522 * fns.c (make_hash_table, maybe_resize_hash_table):
1523 Check for integer overflow with large hash tables.
1524 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1525 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1526 (SXHASH_REDUCE): New macro.
1527 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1528 Use it instead of discarding useful hash info with large hash values.
1529 (sxhash_float): New function.
1530 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1531 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1532 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1533 Rewrite to use FIXNUM_BITS, as this simplifies things.
1534 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1535 Adjust signatures to match updated version of code.
1536 (consing_since_gc): Now EMACS_INT, since a single hash table can
1537 use more than INT_MAX bytes.
1539 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1541 Make it possible to build with GCC-4.6+ -O2 -flto.
1543 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1545 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1547 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1548 Call minibuffer-inactive-mode.
1550 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1552 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1553 Update dependencies.
1555 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1557 * data.c (init_data): Remove code for UTS, this system is not
1560 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1562 Don't force ./temacs to start in terminal mode.
1564 * frame.c (make_initial_frame): Initialize faces in all cases, not
1565 only when CANNOT_DUMP is defined.
1566 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1568 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1570 * dispnew.c (add_window_display_history): Use const for the string
1571 pointer. Remove declaration, not needed.
1573 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1575 Use 'inline', not 'INLINE'.
1576 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1577 * alloc.c, fontset.c (INLINE): Remove.
1578 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1579 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1580 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1581 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1582 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1584 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1586 Make it possible to run ./temacs.
1588 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1589 syms_of_callproc does the same thing. Remove test for
1590 "initialized", do it in the caller.
1591 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1593 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1595 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1596 (read_minibuf): Use get_minibuffer.
1597 (syms_of_minibuf): Use DEFSYM.
1598 (Qmetadata): New var.
1599 * data.c (Qbuffer): Don't make it static.
1600 (syms_of_data): Use DEFSYM.
1602 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1604 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1605 (CCL_CODE_MIN): New macro.
1607 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1609 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1611 * eval.c (Qdebug): Now static.
1612 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1613 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1614 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1616 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1618 * image.c: Various fixes to ImageMagick code comments.
1619 (Fimagemagick_types): Doc fix.
1621 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1623 Minor fixes prompted by GCC 4.6.0 warnings.
1625 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1627 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1628 (x_clipboard_manager_save_all): Move extern decl to ...
1629 * xterm.h: ... here, so that it can be checked for consistency.
1631 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1633 * xselect.c (x_clipboard_manager_save_frame)
1634 (x_clipboard_manager_save_all): New functions.
1635 (Fx_clipboard_manager_save): Lisp function deleted.
1637 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1638 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1640 * xterm.h: Update prototype.
1642 2011-05-28 William Xu <william.xwl@gmail.com>
1644 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1647 2011-05-28 Jim Meyering <meyering@redhat.com>
1649 Avoid a sign-extension bug in crypto_hash_function.
1650 * fns.c (to_uchar): Define.
1651 (crypto_hash_function): Use it to convert some newly-signed
1652 variables to unsigned, to avoid sign-extension bugs. For example,
1653 without this change, (md5 "truc") would evaluate to
1654 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1655 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1656 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1658 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1660 Integer overflow fixes.
1662 * dbusbind.c: Serial number integer overflow fixes.
1663 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1664 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1665 to hold a serial number that is too large for a fixnum.
1666 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1667 Check for serial numbers out of range. Decode any serial number
1668 that was so large that it became a float. (Bug#8722)
1670 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1671 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1672 Use XFASTINT rather than XUINT when numbers are nonnegative.
1673 (xd_append_arg, Fdbus_method_return_internal):
1674 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1675 arguments, check that Lisp number is nonnegative, rather than
1676 silently wrapping negative numbers around. (Bug#8722)
1677 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1680 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1682 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1684 ccl: add integer overflow checks
1685 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1686 (IN_INT_RANGE): New macros.
1687 (ccl_driver): Use them to check for integer overflow when
1688 decoding a CCL program. Many of the new checks are whether XINT (x)
1689 fits in int; it doesn't always, on 64-bit hosts. The new version
1690 doesn't catch all possible integer overflows, but it's an
1691 improvement. (Bug#8719)
1693 * alloc.c (make_event_array): Use XINT, not XUINT.
1694 There's no need for unsigned here.
1696 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1697 This follows up to the 2011-05-06 change that substituted uintptr_t
1698 for EMACS_INT. This case wasn't caught back then.
1700 Rework Fformat to avoid integer overflow issues.
1701 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1702 now (part of C89). Include <verify.h>.
1703 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1704 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1705 (Fformat): Avoid the prepass trying to compute sizes; it was only
1706 approximate and thus did not catch overflow reliably. Instead, walk
1707 through the format just once, formatting and computing sizes as we go,
1708 checking for integer overflow at every step, and allocating a larger
1709 buffer as needed. Keep track separately whether the format is
1710 multibyte. Keep only the most-recently calculated precision, rather
1711 than them all. Record whether each argument has been converted to
1712 string. Use EMACS_INT, not int, for byte and char and arg counts.
1713 Support field widths and precisions larger than INT_MAX. Avoid
1714 sprintf's undefined behavior with conversion specifications such as %#d
1715 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1716 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1717 formatting out-of-range floating point numbers with int
1720 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1722 * data.c: Avoid integer truncation in expressions involving floats.
1723 * data.c: Include <intprops.h>.
1724 (arith_driver): When there's an integer overflow in an expression
1725 involving floating point, convert the integers to floating point
1726 so that the resulting value does not suffer from catastrophic
1727 integer truncation. For example, on a 64-bit host (* 4
1728 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1729 Do not rely on undefined behavior after integer overflow.
1731 merge count_size_as_multibyte, parse_str_to_multibyte
1732 * character.c, character.h (count_size_as_multibyte):
1733 Rename from parse_str_to_multibyte; all uses changed.
1734 Check for integer overflow.
1735 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1736 since it's now a duplicate of the other. This is more of
1737 a character than a buffer op, so better that it's in character.c.
1738 * fns.c, print.c: Adjust to above changes.
1740 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1742 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1744 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1746 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1747 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1748 (x_clipboard_manager_save): Now static.
1749 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1751 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1752 (crypto_hash_function): Now static.
1753 Fix pointer signedness problems. Avoid unnecessary initializations.
1755 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1757 * termhooks.h (Vselection_alist): Make it terminal-local.
1759 * terminal.c (create_terminal): Initialize it.
1761 * xselect.c: Support for clipboard managers.
1762 (Vselection_alist): Move to termhooks.h as terminal-local var.
1763 (LOCAL_SELECTION): New macro.
1764 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1765 (symbol_to_x_atom): Remove gratuitous arg.
1766 (x_handle_selection_request, lisp_data_to_selection_data)
1767 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1768 (x_own_selection, x_get_local_selection, x_convert_selection):
1769 New arg, specifying work frame. Use terminal-local Vselection_alist.
1770 (some_frame_on_display): Delete unused function.
1771 (Fx_own_selection_internal, Fx_get_selection_internal)
1772 (Fx_disown_selection_internal, Fx_selection_owner_p)
1773 (Fx_selection_exists_p): New optional frame arg.
1774 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1775 (x_handle_selection_clear): Don't treat other terminals with the
1776 same keyboard specially. Use the terminal-local Vselection_alist.
1777 (x_clear_frame_selections): Use Frun_hook_with_args.
1779 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1781 * xterm.h: Add support for those atoms.
1783 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1785 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1786 (converted_selections, conversion_fail_tag): New global variables.
1787 (x_selection_request_lisp_error): Free the above.
1788 (x_get_local_selection): Remove unnecessary code.
1789 (x_reply_selection_request): Args changed; handle arbitrary array
1790 of converted selections stored in converted_selections.
1791 Separate the XChangeProperty and SelectionNotify steps.
1792 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1793 (x_convert_selection): New function.
1794 (x_handle_selection_event): Simplify.
1795 (x_get_foreign_selection): Don't ignore incoming requests while
1796 waiting for an answer; this will fail when we implement
1797 SAVE_TARGETS, and seems unnecessary anyway.
1798 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1799 (Vx_sent_selection_functions): Doc fix.
1801 2011-05-26 Leo Liu <sdl.web@gmail.com>
1803 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1805 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1807 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1809 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1810 for fringe update if it has periodic bitmap.
1811 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1812 and fringe_bitmap_periodic_p.
1814 * fringe.c (get_fringe_bitmap_data): New function.
1815 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1816 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1817 row. Mark glyph row for fringe update if periodicity changed.
1819 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1820 for fringe update unless it has periodic bitmap.
1822 2011-05-25 Kenichi Handa <handa@m17n.org>
1824 * xdisp.c (get_next_display_element): Set correct it->face_id for
1825 a static composition.
1827 2011-05-24 Leo Liu <sdl.web@gmail.com>
1830 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1832 * fns.c (crypto_hash_function, Fsha1): New function.
1833 (Fmd5): Use crypto_hash_function.
1834 (syms_of_fns): Add Ssha1.
1836 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1838 * gnutls.c: Remove unused macros.
1839 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1840 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1841 Remove macros that are defined and never used.
1842 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1844 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1846 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1847 (Fx_get_selection_internal): Minor cleanup.
1848 (Fx_own_selection_internal): Rename arguments for consistency with
1851 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1853 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1855 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1857 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1859 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1861 * dispnew.c (scrolling_window): Don't exclude the case that the
1862 last enabled row in the desired matrix touches the bottom boundary.
1864 2011-05-21 Glenn Morris <rgm@gnu.org>
1866 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1867 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1868 and add some more files.
1870 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1872 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1873 report_file_error introduced by the change from 2011-05-07.
1875 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1877 * systime.h (Time): Define only if emacs is defined.
1878 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1879 where the include path doesn't have X11/X.h by default. See
1880 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1882 2011-05-20 Kenichi Handa <handa@m17n.org>
1884 * composite.c (find_automatic_composition): Fix previous change.
1886 2011-05-20 Glenn Morris <rgm@gnu.org>
1888 * lisp.mk: New file, split from Makefile.in.
1889 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1890 (shortlisp): Remove.
1891 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1893 2011-05-19 Glenn Morris <rgm@gnu.org>
1895 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1896 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1897 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1898 (lisp): Set the order to that of loadup.el.
1899 (shortlisp): Make it a copy of $lisp.
1900 (SOME_MACHINE_LISP): Remove.
1901 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1902 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1904 2011-05-18 Kenichi Handa <handa@m17n.org>
1906 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1907 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1908 (find_automatic_composition): Mostly rewrite for efficiency.
1910 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1912 * makefile.w32-in: Update dependencies.
1914 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1916 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1917 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1919 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1921 Fix some integer overflow issues, such as string length overflow.
1923 * insdel.c (count_size_as_multibyte): Check for string overflow.
1925 * character.c (lisp_string_width): Check for string overflow.
1926 Use EMACS_INT, not int, for string indexes and lengths; in
1927 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1928 the resulting string length overflows an EMACS_INT; instead,
1929 report a string overflow if no precision given. When checking for
1930 precision exhaustion, use a check that cannot possibly have
1931 integer overflow. (Bug#8675)
1932 * character.h (lisp_string_width): Adjust to new signature.
1934 * alloc.c (string_overflow): New function.
1935 (Fmake_string): Use it. This doesn't change behavior, but saves
1936 a few bytes and will simplify future changes.
1937 * character.c (string_escape_byte8): Likewise.
1938 * lisp.h (string_overflow): New decl.
1940 Fixups, following up to the user-interface timestamp change.
1941 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1942 for UI timestamps, instead of unsigned long.
1943 * msdos.c (mouse_get_pos): Likewise.
1944 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1945 * w32gui.h (Time): Define by including "systime.h" rather than by
1946 declaring it ourselves. (Bug#8664)
1948 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1949 * image.c (clear_image_cache): Likewise.
1951 * term.c (term_mouse_position): Don't assume time_t wraparound.
1953 Be more systematic about user-interface timestamps.
1954 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1955 and sometimes 'EMACS_UINT', to represent these timestamps.
1956 This change causes it to use 'Time' uniformly, as that's what X uses.
1957 This makes the code easier to follow, and makes it easier to catch
1958 integer overflow bugs such as Bug#8664.
1959 * frame.c (Fmouse_position, Fmouse_pixel_position):
1960 Use Time, not unsigned long, for user-interface timestamps.
1961 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1962 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1963 * keyboard.h (last_event_timestamp): Likewise.
1964 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1965 * menu.h (xmenu_show): Likewise.
1966 * term.c (term_mouse_position): Likewise.
1967 * termhooks.h (struct input_event.timestamp): Likewise.
1968 (struct terminal.mouse_position_hook): Likewise.
1969 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1970 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1971 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1972 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1974 * menu.h, termhooks.h: Include "systime.h", for Time.
1976 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1977 Don't assume that the difference between two unsigned long values
1978 can fit into an integer. At this point, we know button_down_time
1979 <= event->timestamp, so the difference must be nonnegative, so
1980 there's no need to cast the result if double-click-time is
1981 nonnegative, as it should be; check that it's nonnegative, just in
1982 case. This bug is triggered when events are more than 2**31 ms
1983 apart (about 25 days). (Bug#8664)
1985 * xselect.c (last_event_timestamp): Remove duplicate decl.
1986 (x_own_selection): Remove needless cast to unsigned long.
1988 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1989 that always fit in int. Use a sentinel instead of a counter, to
1990 avoid a temp and to allay GCC's concerns about possible int overflow.
1991 * frame.h (struct frame): Use int for menu_bar_items_used
1992 instead of EMACS_INT, since it always fits in int.
1994 * menu.c (grow_menu_items): Check for int overflow.
1996 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1998 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1999 Before, the code was not consistent. These values cannot exceed
2000 2**31 - 1 so there's no need to make them unsigned.
2001 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2002 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2003 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2005 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2007 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2008 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2009 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2010 presumably because the widths might not match.
2012 * window.c (size_window): Avoid needless test at loop start.
2014 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2016 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2018 2011-05-12 Drew Adams <drew.adams@oracle.com>
2020 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2022 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2024 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2025 `width' to `bar_area_x' and `bar_area_width', respectively.
2026 (x_scroll_run): Take account of fringe background extension.
2028 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2029 Rename local vars `left' and `width' to `bar_area_x' and
2030 `bar_area_width', respectively.
2031 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2032 background extension.
2034 2011-05-10 Jim Meyering <meyering@redhat.com>
2036 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2038 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2040 * image.c (Finit_image_library): Return t for built-in image types,
2041 like pbm and xbm. (Bug#8640)
2043 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2045 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2047 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2049 * w32console.c (Fset_screen_color): Doc fix.
2050 (Fget_screen_color): New function.
2051 (syms_of_ntterm): Defsubr it.
2053 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2054 unlink the temporary file if Fcall_process didn't create it in the
2056 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2057 child process will be redirected to a file specified with `:file'.
2058 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2059 cue to call_process_cleanup not to close that handle.
2061 2011-05-07 Ben Key <bkey76@gmail.com>
2063 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2064 one of two shell specific rules, either bootstrap-temacs-CMD or
2065 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2066 to the previous implementation of the bootstrap-temacs rule.
2067 The bootstrap-temacs-CMD rule is similar to the previous
2068 implementation of the bootstrap-temacs rule except that it
2069 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2072 These changes, along with some changes to nt/configure.bat,
2073 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2074 earlier fix to add support for --cflags and --ldflags options
2075 that include quotes so that it works whether make uses cmd or
2078 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2080 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2081 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2083 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2084 a string. Handle both cases.
2085 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2086 (Fdbus_register_method): Use Qinvalid_function.
2088 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2090 * makefile.w32-in: Update dependencies.
2091 (LISP_H): Add inttypes.h and stdin.h.
2092 (PROCESS_H): Add unistd.h.
2094 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2096 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2097 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2099 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2101 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2103 * term.c (vfatal): Remove stray call to va_end.
2104 It's not needed and the C Standard doesn't allow it here anyway.
2106 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2107 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2109 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2112 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2114 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2116 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2118 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2120 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2122 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2123 * charset.c (Fdefine_charset_internal): Don't initialize
2124 charset.code_space[15]. The value was garbage, on hosts with
2125 32-bit int (Bug#8600).
2127 * lread.c (read_integer): Be more consistent with string-to-number.
2128 Use string_to_number to do the actual conversion; this avoids
2129 rounding errors and fixes some other screwups. Without this fix,
2130 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2131 (digit_to_number): Move earlier, for benefit of read_integer.
2132 Return -1 if the digit is out of range for the base, -2 if it is
2133 not a digit in any supported base. (Bug#8602)
2135 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2137 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2138 to match comment at start of function. This also removes a
2139 GCC warning about overflow in a 32+64-bit port.
2141 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2143 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2144 Reported by Stefan Monnier in
2145 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2146 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2147 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2149 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2150 (EMACS_UINTPTR): Likewise, with uintptr_t.
2152 * lisp.h: Prefer 64-bit EMACS_INT if available.
2153 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2154 on 32-bit hosts that have 64-bit int, so that they can access
2156 However, temporarily disable this change unless the temporary
2157 symbol WIDE_EMACS_INT is defined.
2159 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2161 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2162 This removes an assumption that EMACS_INT and long are the same
2163 width as pointers. The assumption is true for Emacs porting targets
2164 now, but we want to make other targets possible.
2165 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2166 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2167 In the rest of the code, change types of integers that hold casted
2168 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2169 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2170 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2171 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2172 No need to cast type when ORing.
2173 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2174 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2175 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2176 assume EMACS_INT is the same width as char *.
2177 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2178 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2179 Remove no-longer-needed casts.
2180 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2181 (xg_tool_bar_help_callback, xg_make_tool_item):
2182 Use EMACS_INTPTR to hold an integer
2183 that will be cast to void *; this can avoid a GCC warning
2184 if EMACS_INT is not the same width as void *.
2185 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2186 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2187 (current_message_1, set_message_1):
2188 Use a local to convert to proper width without a cast.
2189 * xmenu.c (dialog_selection_callback): Likewise.
2191 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2192 Also, don't assume VALBITS / RAND_BITS is less than 5,
2193 and don't rely on undefined behavior when shifting a 1 left into
2195 * lisp.h (get_random): Change signature to match.
2197 * lread.c (hash_string): Use size_t, not int, for hash computation.
2198 Normally we prefer signed values; but hashing is special, because
2199 it's better to use unsigned division on hash table sizes so that
2200 the remainder is nonnegative. Also, size_t is the natural width
2201 for hashing into memory. The previous code used 'int', which doesn't
2202 retain enough info to hash well into very large tables.
2203 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2205 * dbusbind.c: Don't possibly lose pointer info when converting.
2206 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2207 Use XPNTR rather than XHASH, so that the high-order bits of
2208 the pointer aren't lost when converting through void *.
2210 * eval.c (Fautoload): Don't double-shift a pointer.
2212 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2214 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2216 * gnutls.c (DEF_GNUTLS_FN):
2217 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2219 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2221 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2224 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2226 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2227 New version that can reserve upto 2GB of heap space.
2229 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2231 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2233 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2235 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2236 `gnutls_certificate_set_x509_key_file'.
2238 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2240 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2241 Update dependencies.
2243 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2245 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2246 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2247 Remove unused parameter `fildes'.
2248 * process.c (read_process_output, send_process): Don't pass it.
2250 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2252 Fix previous change: the library cache is defined in w32.c.
2253 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2254 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2256 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2258 Implement dynamic loading of GnuTLS on Windows.
2260 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2261 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2262 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2265 * gnutls.c (Qgnutls_dll): Define.
2266 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2267 (gnutls_*): Declare function pointers.
2268 (init_gnutls_functions): New function to initialize function pointers.
2269 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2270 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2271 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2272 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2273 (emacs_gnutls_write, emacs_gnutls_read)
2274 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2275 (Fgnutls_available_p): New function.
2276 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2277 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2278 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2280 * image.c: Include w32.h.
2281 (Vimage_type_cache): Delete.
2282 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2283 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2284 (w32_delayed_load): Move to w32.c.
2286 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2288 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2289 (w32_delayed_load): Move from image.c. When loading a library, record
2290 its filename in the :loaded-from property of the library id.
2291 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2292 Initialize and staticpro them.
2293 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2295 * process.c: Include lisp.h before w32.h, not after.
2296 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2297 instead of gnutls_record_check_pending.
2299 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2301 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2303 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2304 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2307 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2309 * xterm.c (x_set_frame_alpha): Do not set property on anything
2310 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2312 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2314 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2316 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2318 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2319 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2320 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2321 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2322 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2323 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2324 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2325 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2326 (Qgnutls_bootprop_callbacks_verify): Make static.
2328 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2330 * callproc.c: Indentation fixup.
2332 * sysdep.c (wait_for_termination_1): Make static.
2333 (wait_for_termination, interruptible_wait_for_termination):
2334 Move after wait_for_termination_1.
2336 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2338 * sysdep.c (interruptible_wait_for_termination): New function
2339 which is like wait_for_termination, but allows keyboard
2342 * callproc.c (Fcall_process): Add (:file "file") as an option for
2344 (Fcall_process_region): Ditto.
2346 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2348 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2349 rather than `XVECTOR (FOO)->size'.
2351 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2352 inttypes.h, as a gnulib replacement is used if it not available in
2355 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2357 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2358 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2359 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2361 * coding.c (coding_alloc_by_realloc): Error out if destination
2362 will grow beyond MOST_POSITIVE_FIXNUM.
2363 (decode_coding_emacs_mule): Abort if there isn't enough place in
2364 charbuf for the composition carryover bytes. Reserve an extra
2365 space for up to 2 characters produced in a loop.
2366 (decode_coding_iso_2022): Abort if there isn't enough place in
2367 charbuf for the composition carryover bytes.
2369 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2371 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2372 aborting when %lld or %lll format is passed.
2373 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2374 %llo or %llx format is passed. (Bug#8545)
2376 * window.c (window_scroll_line_based): Use a marker instead of
2377 simple variables to record original value of point. (Bug#7952)
2379 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2380 produced by %s or %c overflows available buffer space. (Bug#8545)
2382 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2384 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2385 (SIZE_MAX): Move defn after all includes, as they might #define it.
2387 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2389 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2391 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2393 * keyboard.c (Qdelayed_warnings_hook): Define.
2394 (command_loop_1): Run `delayed-warnings-hook'
2395 if Vdelayed_warnings_list is non-nil.
2396 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2397 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2399 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2401 * doprnt.c (doprnt): Don't return value smaller than the buffer
2402 size if the message was truncated. (Bug#8545).
2404 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2406 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2407 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2409 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2411 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2413 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2415 * makefile.w32-in: Update dependencies.
2417 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2419 Improve `doprnt' and its usage. (Bug#8545)
2420 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2421 `format_end'. Remove support for %l as a conversion specifier.
2422 Don't use xrealloc. Improve diagnostics when the %l size modifier
2423 is used. Update the commentary.
2425 * eval.c (verror): Simplify calculation of size_t.
2427 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2430 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2432 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2435 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2437 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2438 This makes this file independent of the recent pseudovector change.
2440 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2442 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2444 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2445 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2446 Remove unused local.
2447 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2449 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2450 GCC 4.6.0 optimizes based on type-based alias analysis.
2451 For example, if b is of type struct buffer * and v of type struct
2452 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2453 != &v->size, and therefore "v->size = 1; b->size = 2; return
2454 v->size;" must therefore return 1. This assumption is incorrect
2455 for Emacs, since it type-puns struct Lisp_Vector * with many other
2456 types. To fix this problem, this patch adds a new type struct
2457 vectorlike_header that documents the constraints on layout of vectors
2458 and pseudovectors, and helps optimizing compilers not get fooled
2459 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2460 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2461 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2463 (XSETPVECTYPE): Rewrite in terms of new macro.
2464 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2465 This is a bit clearer, and further avoids the possibility of
2466 undesirable aliasing.
2467 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2468 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2469 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2470 since Lisp_Subr is a special case (no "next" field).
2471 (ASIZE): Now uses header.size rather than size.
2472 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2473 to avoid the hassle of writing XVECTOR (foo)->header.size.
2474 (struct vectorlike_header): New type.
2475 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2476 object, to help avoid aliasing.
2477 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2478 (SUBRP): Likewise, since Lisp_Subr is a special case.
2479 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2480 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2481 (struct Lisp_Hash_Table): Combine first two members into a single
2482 struct vectorlike_header member. All uses of "size" and "next" members
2483 changed to be "header.size" and "header.next".
2484 * buffer.h (struct buffer): Likewise.
2485 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2486 * frame.h (struct frame): Likewise.
2487 * process.h (struct Lisp_Process): Likewise.
2488 * termhooks.h (struct terminal): Likewise.
2489 * window.c (struct save_window_data, struct saved_window): Likewise.
2490 * window.h (struct window): Likewise.
2491 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2492 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2493 * buffer.c (init_buffer_once): Likewise.
2494 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2496 * process.c (Fformat_network_address): Use local var for size,
2499 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2501 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2502 * data.c (atof): Remove decl; no longer used or needed.
2503 (digit_to_number): Move to lread.c.
2504 (Fstring_to_number): Use new string_to_number function, to be
2505 consistent with how the Lisp reader treats infinities and NaNs.
2506 Do not assume that floating-point numbers represent EMACS_INT
2507 without losing information; this is not true on most 64-bit hosts.
2508 Avoid double-rounding errors, by insisting on integers when
2509 parsing non-base-10 numbers, as the documentation specifies.
2510 * lisp.h (string_to_number): New decl, replacing ...
2511 (isfloat_string): Remove.
2512 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2513 (read1): Do not accept +. and -. as integers; this
2514 appears to have been a coding error. Similarly, do not accept
2515 strings like +-1e0 as floating point numbers. Do not report
2516 overflow for integer overflows unless the base is not 10 which
2517 means we have no simple and reliable way to continue.
2518 Break out the floating-point parsing into a new
2519 function string_to_number, so that Fstring_to_number parses
2520 floating point numbers consistently with the Lisp reader.
2521 (digit_to_number): Move here from data.c. Make it static inline.
2522 (E_CHAR, EXP_INT): Remove, replacing with ...
2523 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2524 (string_to_number): New function, replacing isfloat_string.
2525 This function checks for valid syntax and produces the resulting
2526 Lisp float number too. Rework it so that string-to-number
2527 no longer mishandles examples like "1.0e+". Use strtoumax,
2528 so that overflow for non-base-10 numbers is reported only when
2529 there's no portable and simple way to convert to floating point.
2531 * textprop.c (set_text_properties_1): Rewrite for clarity,
2532 and to avoid GCC warning about integer overflow.
2534 * intervals.h (struct interval): Use EMACS_INT for members
2535 where EMACS_UINT might cause problems. See
2536 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2537 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2538 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2540 (offset_intervals): Tell GCC not to worry about length overflow
2541 when negating a negative length.
2543 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2544 (overrun_check_free): Likewise.
2546 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2547 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2550 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2551 (gnutls_make_error): Rename local to avoid shadowing.
2552 (gnutls_emacs_global_deinit): ifdef out; not used.
2553 (Fgnutls_boot): Use const for pointer to readonly storage.
2554 Comment out unused local. Fix pointer signedness problems.
2556 * lread.c (openp): Don't stuff size_t into an 'int'.
2557 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2558 about possible signed overflow.
2560 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2561 (GDK_KEY_g): Don't define if already defined.
2562 (xg_prepare_tooltip): Avoid pointer signedness problem.
2563 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2565 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2566 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2568 * xfns.c (Fx_window_property): Simplify a bit,
2569 to make a bit faster and to avoid GCC 4.6.0 warning.
2570 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2572 * fns.c (internal_equal): Don't assume size_t fits in int.
2574 * alloc.c (compact_small_strings): Tighten assertion a little.
2576 Replace pEd with more-general pI, and fix some printf arg casts.
2577 * lisp.h (pI): New macro, generalizing old pEd macro to other
2578 conversion specifiers. For example, use "...%"pI"d..." rather
2579 than "...%"pEd"...".
2580 (pEd): Remove. All uses replaced with similar uses of pI.
2581 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2582 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2583 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2584 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2585 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2586 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2587 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2589 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2590 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2591 * print.c (safe_debug_print, print_object): Likewise.
2592 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2594 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2595 avoiding the 0 flag, which is not portable.
2596 * process.c (Fmake_network_process): Use pI to avoid cast.
2597 * region-cache.c (pp_cache): Likewise.
2598 * xdisp.c (decode_mode_spec): Likewise.
2599 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2600 behavior on 64-bit hosts with printf arg.
2601 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2602 (x_stop_queuing_selection_requests): Likewise.
2603 (x_get_window_property): Don't truncate byte count to an 'int'
2606 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2607 here, since it parses constructs like leading '-' and spaces,
2608 which are not wanted; and it overflows with large numbers.
2609 Instead, simply match F[0-9]+, which is what is wanted anyway.
2611 * alloc.c: Remove unportable assumptions about struct layout.
2612 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2613 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2614 (allocate_vectorlike, make_pure_vector): Use the new macros,
2615 plus offsetof, to remove unportable assumptions about struct layout.
2616 These assumptions hold on all porting targets that I know of, but
2617 they are not guaranteed, they're easy to remove, and removing them
2618 makes further changes easier.
2620 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2621 This doesn't fix a bug but makes the code clearer.
2622 (string_overrun_cookie): Now const. Use initializers that
2623 don't formally overflow signed char, to avoid warnings.
2624 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2625 can cause Emacs to crash when string overrun checking is enabled.
2626 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2627 multiple of sizeof (EMACS_INT); it need not be, if
2628 alignof(EMACS_INT) < sizeof (EMACS_INT).
2629 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2631 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2633 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2635 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2637 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2638 supposed to be handshaking. (Bug#8556)
2639 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2641 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2643 * lisp.h (Qdebug): List symbol.
2644 * eval.c (Qdebug): Restore global linkage.
2645 * keyboard.c (debug-on-event): New variable.
2646 (handle_user_signal): Break into debugger when debug-on-event
2647 matches the current signal symbol.
2649 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2651 * alloc.c (check_sblock, check_string_bytes)
2652 (check_string_free_list): Convert to standard C.
2654 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2656 * w32.c (emacs_gnutls_push): Fix typo.
2658 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2660 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2661 "cast to pointer from integer of different size".
2663 Improve doprnt and its use in verror. (Bug#8545)
2664 * doprnt.c (doprnt): Document the set of format control sequences
2665 supported by the function. Use SAFE_ALLOCA instead of always
2668 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2669 is one byte too soon. Don't use xrealloc; instead xfree and
2672 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2674 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2677 * gnutls.c: Renamed global_initialized to
2678 gnutls_global_initialized. Added internals for the
2679 :verify-hostname-error, :verify-error, and :verify-flags
2680 parameters of `gnutls-boot' and documented those parameters in the
2681 docstring. Start callback support.
2682 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2683 unless a fatal error occured. Call gnutls_alert_send_appropriate
2684 on error. Return error code.
2685 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2686 (emacs_gnutls_read): Likewise.
2687 (Fgnutls_boot): Return handshake error code.
2688 (emacs_gnutls_handle_error): New function.
2689 (wsaerror_to_errno): Likewise.
2691 * w32.h (emacs_gnutls_pull): Add prototype.
2692 (emacs_gnutls_push): Likewise.
2694 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2695 (emacs_gnutls_push): Likewise.
2697 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2699 * process.c (wait_reading_process_output): Check if GnuTLS
2700 buffered some data internally if no FDs are set for TLS
2703 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2704 (LIBS): Link to USER_LIBS.
2705 ($(BLD)/gnutls.$(0)): New target.
2707 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2709 * xdisp.c (handle_single_display_spec): Rename the
2710 display_replaced_before_p argument into display_replaced_p, to
2711 make it consistent with the commentary. Fix typos in the
2714 * textprop.c (syms_of_textprop): Remove dead code.
2715 (copy_text_properties): Delete obsolete commentary about an
2716 interface that was deleted long ago. Fix typos in the description
2719 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2720 to changes in oldXMenu/XMenu.h from 2011-04-16.
2721 <menu_help_message, prev_menu_help_message>: Constify.
2722 (IT_menu_make_room): menu->help_text is now `const char **';
2725 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2726 to changes in oldXMenu/XMenu.h from 2011-04-16.
2727 (struct XMenu): Declare `help_text' `const char **'.
2729 * xfaces.c <Qunspecified>: Make extern again.
2731 * syntax.c: Include sys/types.h before including regex.h, as
2734 * doc.c (get_doc_string): Improve the format passed to `error'.
2736 * doprnt.c (doprnt): Improve commentary.
2738 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2740 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2743 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2744 changes in globals.h immediately force recompilation.
2745 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2746 $(CURDIR)/s/ms-w32.h.
2747 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2749 * character.c (Fchar_direction): Function deleted.
2750 (syms_of_character): Don't defsubr it.
2751 <char-direction-table>: Deleted.
2753 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2755 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2756 * doprnt.c: Include limits.h.
2757 (SIZE_MAX): New macro.
2758 (doprnt): Return a size_t value. 2nd arg is now size_t.
2759 Many local variables are now size_t instead of int or unsigned.
2760 Improve overflow protection. Support `l' modifier for integer
2761 conversions. Support %l conversion. Don't assume an EMACS_INT
2762 argument for integer conversions and for %c.
2764 * lisp.h (doprnt): Restore prototype.
2766 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2769 * Makefile.in (base_obj): Add back doprnt.o.
2771 * deps.mk (doprnt.o): Add back prerequisites.
2772 (callint.o): Depend on character.h.
2774 * eval.c (internal_lisp_condition_case): Include the handler
2775 representation in the error message.
2776 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2777 when breaking from the loop.
2779 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2781 * callint.c (Fcall_interactively): When displaying error message
2782 about invalid control letter, pass the character's codepoint, not
2783 a pointer to its multibyte form. Improve display of the character
2784 in octal and display also its hex code.
2786 * character.c (char_string): Use %x to display the (unsigned)
2787 codepoint of an invalid character, to avoid displaying a bogus
2790 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2791 `error', not SYMBOL_NAME itself.
2793 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2794 character arguments to `error'.
2796 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2797 to `error' in error message about FINAL_CHAR argument. Make sure
2798 FINAL_CHAR is a character, and use %c when it is passed as
2799 argument to `error'.
2801 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2803 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2805 * w32.c: Include <time.h>.
2806 (sys_localtime): New function.
2808 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2810 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2812 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2814 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2816 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2819 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2821 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2822 gl_state.e_property when gl_state.object is Qt.
2824 * insdel.c (make_gap_larger): Remove limitation of buffer size
2827 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2829 * xdisp.c (lookup_glyphless_char_display)
2830 (produce_glyphless_glyph): Handle cons cell entry in
2831 glyphless-char-display.
2832 (Vglyphless_char_display): Document it.
2834 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2835 glyphless-char-display.
2837 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2839 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2841 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2843 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2844 definition for no-X builds.
2846 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2848 Static checks with GCC 4.6.0 and non-default toolkits.
2850 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2852 * process.c (keyboard_bit_set): Define only if SIGIO.
2853 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2854 (send_process): Repair possible setjmp clobbering.
2856 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2858 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2860 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2862 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2863 Define only if needed.
2865 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2866 by pacifying GCC about it. Maybe it's time to retire it?
2867 * xfaces.c (USG, __TIMEVAL__): Likewise.
2869 * dispextern.h (struct redisplay_interface): Rename param
2871 * termhooks.h (struct terminal): Likewise.
2872 * xterm.c (xembed_send_message): Likewise.
2874 * insdel.c (make_gap_smaller): Define only if
2875 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2877 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2880 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2881 so that we aren't warned about unused symbols.
2883 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2885 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2887 * xfns.c (x_real_positions): Mark locals as initialized.
2889 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2891 * xterm.c: Fix problems found by static analysis with other toolkits.
2892 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2893 (x_dispatch_event): Declare static if USE_GTK, and
2894 define if USE_GTK || USE_X_TOOLKIT.
2895 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2896 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2897 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2898 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2900 * xmenu.c (menu_help_callback): Pointer type fixes.
2901 Use const pointers when pointing at readonly data. Avoid pointer
2903 (FALSE): Remove unused macro.
2904 (update_frame_menubar): Remove unused decl.
2906 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2908 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2909 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2910 (single_menu_item): Rename local to avoid shadowing.
2912 * keyboard.c (make_lispy_event): Remove unused local var.
2914 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2915 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2917 * bitmaps: Change bitmaps from unsigned char back to the X11
2918 compatible char. Avoid the old compiler warnings about
2919 out-of-range initializers by using, for example, '\xab' rather
2922 * xgselect.c (xgselect_initialize): Check vs interface
2923 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2925 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2927 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2928 to read-only memory.
2930 * fns.c (vector): Remove; this old hack is no longer needed.
2932 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2934 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2936 * xrdb.c (x_load_resources): Omit unused local.
2938 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2939 (x_window): Rename locals to avoid shadowing.
2940 (USG): Use the kludged USG macro, to pacify gcc.
2942 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2943 (x_term_init): Remove local to avoid shadowing.
2945 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2947 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2948 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2950 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2952 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2954 Fix regex.c, syntax.c and friends for buffers > 2GB.
2955 * syntax.h (struct gl_state_s): Declare character position members
2958 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2960 * textprop.c (verify_interval_modification, interval_of):
2961 Declare arguments EMACS_INT.
2963 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2966 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2968 * indent.c (Fvertical_motion): Local variable it_start is now
2971 * regex.c (re_match, re_match_2, re_match_2_internal)
2972 (bcmp_translate, regcomp, regexec, print_double_string)
2973 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2974 (re_compile_pattern, re_exec): Declare arguments and local
2975 variables `size_t' and `ssize_t' and return values `regoff_t', as
2977 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2978 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2979 <compile_stack_type>: `size' and `avail' are now `size_t'.
2981 * regex.h <regoff_t>: Use ssize_t, not int.
2982 (re_search, re_search_2, re_match, re_match_2): Arguments that
2983 specify buffer/string position and length are now ssize_t and
2984 size_t. Return type is regoff_t.
2986 2011-04-16 Ben Key <bkey76@gmail.com>
2988 * nsfont.m: Fixed bugs in ns_get_family and
2989 ns_descriptor_to_entity that were caused by using free to
2990 deallocate memory blocks that were allocated by xmalloc (via
2991 xstrdup). This caused Emacs to crash when compiled with
2992 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2993 --enable-checking=xmallocoverrun). xfree is now used to
2994 deallocate these memory blocks.
2996 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2998 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3000 emacs_write: Accept and return EMACS_INT for sizes.
3001 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3003 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3004 Accept and return EMACS_INT.
3005 (emacs_gnutls_write): Return the number of bytes written on
3007 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3008 (emacs_read, emacs_write): Remove check for negative size, as the
3009 Emacs source code has been audited now.
3010 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3011 (emacs_read, emacs_write): Use it.
3012 * process.c (send_process): Adjust to the new signatures of
3013 emacs_write and emacs_gnutls_write. Do not attempt to store
3014 a byte offset into an 'int'; it might overflow.
3015 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3017 * sound.c: Don't assume sizes fit in 'int'.
3018 (struct sound_device.period_size, alsa_period_size):
3019 Return EMACS_INT, not int.
3020 (struct sound_device.write, vox_write, alsa_write):
3021 Accept EMACS_INT, not int.
3022 (wav_play, au_play): Use EMACS_INT to store sizes and to
3023 record read return values.
3025 2011-04-15 Ben Key <bkey76@gmail.com>
3027 * keyboard.c (Qundefined): Don't declare static since it is used
3029 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3030 static since they are used in nsfont.m.
3032 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3034 * process.c (Qprocessp): Don't declare static.
3035 * lisp.h (Qprocessp): Declare again.
3037 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3039 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3041 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3043 Improve C-level modularity by making more things 'static'.
3045 Don't publish debugger-only interfaces to other modules.
3046 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3047 (verify_bytepos, count_markers): Move decls to the only modules
3049 * region-cache.h (pp_cache): Likewise.
3050 * window.h (check_all_windows): Likewise.
3051 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3053 * sysdep.c (croak): Now static, if
3054 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3055 * syssignal.h (croak): Declare only if not static.
3057 * alloc.c (refill_memory_reserve): Now static if
3058 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3059 * lisp.h (refill_memory_reserve): Declare only if not static.
3061 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3062 Define only if USE_LUCID.
3064 * xrdb.c (x_customization_string, x_rm_string): Now static.
3066 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3067 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3069 * xdisp.c (draw_row_with_mouse_face): Now static.
3070 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3072 * window.h (check_all_windows): Mark externally visible.
3074 * window.c (window_deletion_count): Now static.
3076 * undo.c: Make symbols static if they're not exported.
3077 (last_undo_buffer, last_boundary_position, pending_boundary):
3080 * textprop.c (interval_insert_behind_hooks): Now static.
3081 (interval_insert_in_front_hooks): Likewise.
3083 * term.c: Make symbols static if they're not exported.
3084 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3085 (max_frame_lines, tty_set_terminal_modes):
3086 (tty_reset_terminal_modes, tty_turn_off_highlight):
3087 (get_tty_terminal): Now static.
3088 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3089 * termhooks.h (term_mouse_moveto): Do not declare if
3091 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3092 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3094 * sysdep.c: Make symbols static if they're not exported.
3095 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3097 (sigprocmask_set, full_mask): Remove; unused.
3098 (wait_debugging): Mark as visible.
3099 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3100 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3102 * syntax.c (syntax_temp): Define only if !__GNUC__.
3104 * sound.c (current_sound_device, current_sound): Now static.
3106 * search.c (searchbufs, searchbuf_head): Now static.
3108 * scroll.c (scroll_cost): Remove; unused.
3109 * dispextern.h (scroll_cost): Remove decl.
3111 * region-cache.h (pp_cache): Mark as externally visible.
3113 * process.c: Make symbols static if they're not exported.
3114 (process_tick, update_tick, create_process, chan_process):
3115 (Vprocess_alist, proc_buffered_char, datagram_access):
3116 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3117 (deactivate_process): Mark defn as static, as well as decl.
3118 * lisp.h (create_process): Remove decl.
3119 * process.h (chan_process, Vprocess_alist): Remove decls.
3121 * print.c: Make symbols static if they're not exported.
3122 (print_depth, new_backquote_output, being_printed, print_buffer):
3123 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3124 (print_interval, print_number_index, initial_stderr_stream):
3126 * lisp.h (Fprinc): Remove decl.
3127 (debug_output_compilation_hack): Mark as externally visible.
3129 * sysdep.c (croak): Move decl from here to syssignal.h.
3130 * syssignal.h (croak): Put it here, so the API can be checked when
3131 'croak' is called from dissociate_if_controlling_tty.
3133 * minibuf.c: Make symbols static if they're not exported.
3134 (minibuf_save_list, choose_minibuf_frame): Now static.
3135 * lisp.h (choose_minibuf_frame): Remove decl.
3137 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3139 * lread.c: Make symbols static if they're not exported.
3140 (read_objects, initial_obarray, oblookup_last_bucket_number):
3142 (make_symbol): Remove; unused.
3143 * lisp.h (initial_obarray, make_symbol): Remove decls.
3145 * keyboard.c: Make symbols static if they're not exported.
3146 (single_kboard, recent_keys_index, total_keys, recent_keys):
3147 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3148 (this_single_command_key_start, echoing, last_auto_save):
3149 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3150 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3151 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3152 (Vlispy_mouse_stem, double_click_count):
3154 (force_auto_save_soon): Define only if SIGDANGER.
3155 (ignore_mouse_drag_p): Now static if
3156 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3157 (print_help): Remove; unused.
3158 (stop_character, last_timer_event): Mark as externally visible.
3159 * keyboard.h (ignore_mouse_drag_p): Declare only if
3160 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3161 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3162 * lisp.h (echoing): Remove decl.
3163 (force_auto_save_soon): Declare only if SIGDANGER.
3164 * xdisp.c (redisplay_window): Simplify code, to make it more
3165 obvious that ignore_mouse_drag_p is not accessed if !defined
3166 USE_GTK && !defined HAVE_NS.
3168 * intervals.c: Make symbols static if they're not exported.
3169 (merge_properties_sticky, merge_interval_right, delete_interval):
3171 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3173 * insdel.c: Make symbols static if they're not exported.
3174 However, leave prepare_to_modify_buffer alone. It's never
3175 called from outside this function, but that appears to be a bug.
3176 (combine_after_change_list, combine_after_change_buffer):
3177 (adjust_after_replace, signal_before_change): Now static.
3178 (adjust_after_replace_noundo): Remove; unused.
3179 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3180 (signal_before_change): Remove decls.
3182 * indent.c (val_compute_motion, val_vmotion): Now static.
3184 * image.c: Make symbols static if they're not exported.
3185 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3187 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3188 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3190 * fringe.c (standard_bitmaps): Now static.
3191 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3193 * frame.c: Make symbols static if they're not exported.
3194 (x_report_frame_params, make_terminal_frame): Now static.
3195 (get_frame_param): Now static, unless HAVE_NS.
3196 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3197 (x_get_resource_string): Remove; not used.
3198 * frame.h (make_terminal_frame, x_report_frame_params):
3199 (x_get_resource_string); Remove decls.
3200 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3201 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3203 * font.c, fontset.c: Make symbols static if they're not exported.
3204 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3205 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3206 * font.c (font_close_object): Now static.
3207 * font.h (font_close_object): Remove.
3208 * fontset.c (FONTSET_OBJLIST): Remove.
3209 (free_realized_fontset) #if-0 the body, which does nothing.
3210 (face_suitable_for_char_p): #if-0, as it's never called.
3211 * fontset.h (face_suitable_for_char_p): Remove decl.
3212 * xfaces.c (face_at_string_position):
3213 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3214 since 0 is always ASCII.
3216 * fns.c (weak_hash_tables): Now static.
3218 * fileio.c: Make symbols static if they're not exported.
3219 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3220 (Vwrite_region_annotation_buffers): Now static.
3222 * eval.c: Make symbols static if they're not exported.
3223 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3224 * lisp.h (backtrace_list): Remove decl.
3226 * emacs.c: Make symbols static if they're not exported.
3227 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3228 (fatal_error_code, fatal_error_signal_hook, standard_args):
3230 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3231 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3232 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3233 * lisp.h (fatal_error_signal_hook): Remove decl.
3234 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3236 * editfns.c: Move a (normally-unused) function to its only use.
3237 * editfns.c, lisp.h (get_operating_system_release): Remove.
3238 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3239 worth the hassle of breaking this out.
3241 * xterm.c: Make symbols static if they're not exported.
3242 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3243 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3244 (x_destroy_window, x_delete_display):
3246 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3247 (x_mouse_leave): Remove; unused.
3248 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3249 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3250 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3252 (x_mouse_leave): Declare only if WINDOWSNT.
3253 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3254 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3257 * ftxfont.c: Make symbols static if they're not exported.
3258 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3260 * font.h (ftxfont_driver): Likewise.
3262 * xfns.c: Make symbols static if they're not exported.
3263 (x_last_font_name, x_display_info_for_name):
3264 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3265 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3266 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3267 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3268 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3269 (last_show_tip_args): Now static.
3270 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3271 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3272 (x_screen_planes): Remove; unused.
3273 * dispextern.h (x_screen_planes): Remove decl.
3275 * dispnew.c: Make symbols static if they're not exported.
3276 * dispextern.h (redraw_garbaged_frames, scrolling):
3277 (increment_row_positions): Remove.
3278 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3279 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3281 (redraw_garbaged_frames): Remove; unused.
3283 * xfaces.c: Make symbols static if they're not exported.
3284 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3286 * xterm.h (defined_color): Remove decls.
3287 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3288 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3289 (menu_face_changed_default, defined_color, free_realized_face):
3290 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3291 (ascii_face_of_lisp_face): Remove; unused.
3293 * xdisp.c: Make symbols static if they're not exported.
3294 * dispextern.h (scratch_glyph_row, window_box_edges):
3295 (glyph_to_pixel_coords, set_cursor_from_row):
3296 (get_next_display_element, set_iterator_to_next):
3297 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3298 (show_mouse_face): Remove decls
3299 * frame.h (message_buf_print): Likewise.
3300 * lisp.h (pop_message, set_message, check_point_in_composition):
3302 * xterm.h (set_vertical_scroll_bar): Likewise.
3303 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3304 (message_buf_print, scratch_glyph_row, displayed_buffer):
3305 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3306 (get_next_display_element, show_mouse_face, window_box_edges):
3307 (frame_to_window_pixel_xy, check_point_in_composition):
3308 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3309 (glyph_to_pixel_coords): Remove; unused.
3311 * dired.c (file_name_completion): Now static.
3313 * dbusbind.c (xd_in_read_queued_messages): Now static.
3315 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3316 * data.c (circular_list_error): Remove.
3318 * commands.h (last_point_position, last_point_position_buffer):
3319 (last_point_position_window): Remove decls.
3320 * keyboard.c: Make these variables static.
3322 * coding.h (coding, code_convert_region, encode_coding_gap):
3324 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3325 (iso_code_class, detect_coding, code_convert_region): Now static.
3326 (encode_coding_gap): Remove; unused.
3328 * chartab.c (chartab_chars, chartab_bits): Now static.
3330 * charset.h (charset_iso_8859_1): Remove decl.
3331 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3334 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3335 * ccl.c (Vccl_program_table): Now static.
3336 (check_ccl_update): Remove; unused.
3338 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3339 * category.h: ... from here.
3340 * category.c (check_category_table, set_category_set): Now static.
3342 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3343 * lisp.h: Remove these decls.
3345 * buffer.c (buffer_count): Remove unused var.
3347 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3348 so that it's not optimized away.
3349 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3350 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3351 exported only to the debugger.
3353 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3354 * atimer.h (run_all_atimers): Remove; not exported.
3356 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3357 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3358 was inaccessible from Lisp.
3359 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3360 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3362 alloc.c: Import and export fewer symbols, and remove unused items.
3363 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3365 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3366 it's not optimized away by whole-program optimization.
3367 (message_enable_multibyte, free_misc): Remove.
3368 (catchlist, handlerlist, mark_backtrace):
3369 Declare only if BYTE_MARK_STACK.
3370 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3371 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3372 (message_enable_multibyte): Remove decl.
3373 (free_misc, interval_free_list, float_block, float_block_index):
3374 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3375 (cons_free_list, last_marked_index):
3377 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3378 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3379 (mark_backtrace): Define only if BYTE_MARK_STACK.
3380 * xdisp.c (message_enable_multibyte): Now static.
3382 Declare Lisp_Object Q* variables to be 'static' if not exported.
3383 This makes it easier for human readers (and static analyzers)
3384 to see whether these variables are used from other modules.
3385 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3386 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3387 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3388 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3389 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3390 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3391 * xmenu.c, xselect.c:
3392 Declare Q* vars static if they are not used in other modules.
3393 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3394 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3395 Remove decls of unexported vars.
3396 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3398 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3400 Make Emacs functions such as Fatom 'static' by default.
3401 This makes it easier for human readers (and static analyzers)
3402 to see whether these functions can be called from other modules.
3403 DEFUN now defines a static function. To make the function external
3404 so that it can be used in other C modules, use the new macro DEFUE.
3405 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3406 (Finit_image_library):
3407 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3408 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3409 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3410 Remove decls, since these functions are now static.
3411 (Funintern, Fget_internal_run_time): New decls, since these functions
3412 were already external.
3414 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3415 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3416 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3417 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3418 * keyboard.c, keymap.c, lread.c:
3419 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3420 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3421 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3422 Mark functions with DEFUE instead of DEFUN,
3423 if they are used in other modules.
3424 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3425 decls for now-static functions.
3426 * buffer.h (Fdelete_overlay): Remove decl.
3427 * callproc.c (Fgetenv_internal): Mark as internal.
3428 * composite.c (Fremove_list_of_text_properties): Remove decl.
3429 (Fcomposition_get_gstring): New forward static decl.
3430 * composite.h (Fcomposite_get_gstring): Remove decl.
3431 * dired.c (Ffile_attributes): New forward static decl.
3432 * doc.c (Fdocumntation_property): New forward static decl.
3433 * eval.c (Ffetch_bytecode): New forward static decl.
3434 (Funintern): Remove extern decl; now in .h file where it belongs.
3435 * fileio.c (Fmake_symbolic_link): New forward static decl.
3436 * image.c (Finit_image_library): New forward static decl.
3437 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3438 * intervals.h (Fprevious_property_change):
3439 (Fremove_list_of_text_properties): Remove decls.
3440 * keyboard.c (Fthis_command_keys): Remove decl.
3441 (Fcommand_execute): New forward static decl.
3442 * keymap.c (Flookup_key): New forward static decl.
3443 (Fcopy_keymap): Now static.
3444 * keymap.h (Flookup_key): Remove decl.
3445 * process.c (Fget_process): New forward static decl.
3446 (Fprocess_datagram_address): Mark as internal.
3447 * syntax.c (Fsyntax_table_p): New forward static decl.
3448 (skip_chars): Remove duplicate decl.
3449 * textprop.c (Fprevious_property_change): New forward static decl.
3450 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3452 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3453 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3455 * editfns.c (Fformat): Remove unreachable code.
3457 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3459 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3462 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3464 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3465 when at ZV. (Bug#8487)
3467 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3469 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3471 * keyboard.c (parse_tool_bar_item): Likewise.
3472 * sound.c (sound_cleanup, alsa_close): Likewise.
3473 * termcap.c (tgetent): Likewise.
3474 * xfns.c (x_default_font_parameter): Likewise.
3475 * xsettings.c (read_and_apply_settings): Likewise.
3477 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3478 (overrun_check_free): Protoize.
3480 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3482 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3483 since callers should never pass a negative size.
3484 Change the signature to match that of plain 'read' and 'write'; see
3485 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3486 * lisp.h: Update prototypes of emacs_write and emacs_read.
3488 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3490 * xdisp.c (redisplay_window): Don't try to determine the character
3491 position of the scroll margin if the window start point w->startp
3492 is outside the buffer's accessible region. (Bug#8468)
3494 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3496 Fix write-region and its subroutines for buffers > 2GB.
3497 * fileio.c (a_write, e_write): Modify declaration of arguments and
3498 local variables to support buffers larger than 2GB.
3499 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3501 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3502 argument, local variables, and return value.
3504 * lisp.h: Update prototypes of emacs_write and emacs_read.
3506 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3508 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3510 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3512 Fix more problems found by GCC 4.6.0's static checks.
3514 * xdisp.c (vmessage): Use a better test for character truncation.
3516 * charset.c (load_charset_map): <, not <=, for optimization,
3517 and to avoid potential problems with integer overflow.
3518 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3519 * casetab.c (set_identity, shuffle): Likewise.
3520 * editfns.c (Fformat): Likewise.
3521 * syntax.c (skip_chars): Likewise.
3523 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3524 This also lets GCC 4.6.0 generate slightly better loop code.
3526 * callint.c (Fcall_interactively): <, not <=, for optimization.
3527 (Fcall_interactively): Count the number of arguments produced,
3528 not the number of arguments given. This is simpler and lets GCC
3529 4.6.0 generate slightly better code.
3531 * ftfont.c: Distingish more carefully between FcChar8 and char.
3532 The previous code passed unsigned char * to a functions like
3533 strlen and xstrcasecmp that expect char *, which does not
3534 conform to the C standard.
3535 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3536 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3537 char * when the C standard requires it.
3539 * keyboard.c (read_char): Remove unused var.
3541 * eval.c: Port to Windows vsnprintf (Bug#8435).
3543 (SIZE_MAX): Define if the headers do not.
3544 (verror): Do not give up if vsnprintf returns a negative count.
3545 Instead, grow the buffer. This ports to Windows vsnprintf, which
3546 does not conform to C99. Problem reported by Eli Zaretskii.
3547 Also, simplify the allocation scheme, by avoiding the need for
3548 calling realloc, and removing the ALLOCATED variable.
3550 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3552 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3553 But keep the doprint source code for now, as we might revamp it
3554 and use it again (Bug#8435).
3555 * lisp.h (doprnt): Remove.
3556 * Makefile.in (base_obj): Remove doprnt.o.
3557 * deps.mk (doprnt.o): Remove.
3559 error: Print 32- and 64-bit integers portably (Bug#8435).
3560 Without this change, on typical 64-bit hosts error ("...%d...", N)
3561 was used to print both 32- and 64-bit integers N, which relied on
3563 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3565 * lisp.h (error, verror): Mark as printf-like functions.
3566 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3567 Report overflow in size calculations when allocating printf buffer.
3568 Do not truncate output string at its first null byte.
3569 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3570 Truncate the output at a character boundary, since vsnprintf does not
3572 * charset.c (check_iso_charset_parameter): Convert internal
3573 character to string before calling 'error', since %c now has the
3575 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3576 overflow when computing char to be passed to 'error'. Do not
3577 pass Lisp_Object to 'error'; pass the integer instead.
3578 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3579 formatted with plain %d.
3581 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3583 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3585 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3587 * xterm.c (x_catch_errors): Remove duplicate declaration.
3589 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3591 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3593 2011-04-10 Jim Meyering <meyering@redhat.com>
3595 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3596 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3597 return ssize_t not "int", and use size_t as the buffer length.
3598 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3599 * gnutls.h: Update declarations.
3600 * process.c (read_process_output): Use ssize_t, to match.
3601 (send_process): Likewise.
3603 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3605 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3607 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3609 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3610 Use unsigned char, to match FcChar8 type definition.
3612 * xterm.c (handle_one_xevent):
3613 * xmenu.c (create_and_show_popup_menu):
3614 * xselect.c (x_decline_selection_request)
3615 (x_reply_selection_request): Avoid type-punned deref of X events.
3617 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3619 Fix some uses of `int' instead of EMACS_INT.
3620 * search.c (string_match_1, fast_string_match)
3621 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3622 (scan_buffer, find_next_newline_no_quit)
3623 (find_before_next_newline, search_command, Freplace_match)
3624 (Fmatch_data): Make some `int' variables be EMACS_INT.
3626 * xdisp.c (display_count_lines): 3rd argument and return value now
3627 EMACS_INT. All callers changed.
3628 (pint2hrstr): Last argument is now EMACS_INT.
3630 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3631 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3632 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3633 (decode_coding_utf_16, decode_coding_emacs_mule)
3634 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3635 (decode_coding_ccl, decode_coding_charset)
3636 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3637 (decode_coding_iso_2022, decode_coding_emacs_mule)
3638 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3639 <char_offset, last_offset>: Declare EMACS_INT.
3640 (encode_coding_utf_8, encode_coding_utf_16)
3641 (encode_coding_emacs_mule, encode_invocation_designation)
3642 (encode_designation_at_bol, encode_coding_iso_2022)
3643 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3644 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3646 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3647 (encode_invocation_designation): Last argument P_NCHARS is now
3649 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3650 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3652 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3655 * ccl.c (Fccl_execute_on_string): Declare some variables
3658 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3660 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3662 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3664 * process.c (Fformat_network_address): Doc fix.
3666 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3668 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3670 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3672 * keyboard.c (read_char): Call Lisp function help-form-show,
3673 instead of using internal_with_output_to_temp_buffer.
3674 (Qhelp_form_show): New var.
3675 (syms_of_keyboard): Use DEFSYM macro.
3677 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3679 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3681 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3683 * process.c (Flist_processes): Remove to Lisp.
3684 (list_processes_1): Delete.
3686 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3688 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3690 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3692 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3694 Fix more problems found by GCC 4.6.0's static checks.
3696 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3698 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3700 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3702 * xdisp.c (vmessage): Mark as a printf-like function.
3704 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3706 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3708 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3709 printf-like functions.
3710 (tiff_load): Add casts to remove these marks before passing them
3711 to system-supplied API.
3713 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3715 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3716 This avoids several warnings with gcc -Wstrict-overflow.
3717 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3718 directly, rather than having caller test rule sign. This avoids
3719 some unnecessary tests.
3720 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3721 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3722 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3724 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3725 (xfont_open): Avoid unnecessary tests.
3727 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3729 * composite.h, composite.c (composition_gstring_put_cache):
3730 Use EMACS_INT, not int, for length.
3732 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3733 breaking out part of COMPOSITION_DECODE_RULE.
3734 (COMPOSITION_DECODE_RULE): Use it.
3735 * composite.c (get_composition_id): Remove unused local vars,
3736 by using the new macro.
3738 * textprop.c (set_text_properties_1): Change while to do-while,
3739 since the condition is always true at first.
3741 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3742 (interval_deletion_adjustment): Return unsigned value.
3745 * process.c (list_processes_1, create_pty, read_process_output):
3746 (exec_sentinel): Remove vars that were set but not used.
3747 (create_pty): Remove unnecessary "volatile"s.
3748 (Fnetwork_interface_info): Avoid possibility of int overflow.
3749 (read_process_output): Do adaptive read buffering even if carryover.
3750 (read_process_output): Simplify nbytes computation if buffered.
3752 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3754 * syntax.c (scan_words): Remove var that was set but not used.
3755 (update_syntax_table): Use unsigned instead of int.
3757 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3758 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3759 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3761 * print.c (print_error_message): Avoid int overflow.
3763 * font.c (font_list_entities): Redo for clarity,
3764 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3766 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3767 (font_score): Avoid potential overflow in diff calculation.
3769 * fns.c (substring_both): Remove var that is set but not used.
3770 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3772 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3774 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3775 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3776 can always succeed if overflow has undefined behavior.
3778 * search.c (boyer_moore, wordify): Remove vars set but not used.
3779 (wordify): Omit three unnecessary tests.
3781 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3782 All callers changed. This avoids the need for an unused var.
3784 * casefiddle.c (casify_region): Remove var that is set but not used.
3786 * dired.c (file_name_completion): Remove var that is set but not used.
3788 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3790 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3791 (Finsert_file_contents): Remove unnecessary code checking fd.
3793 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3794 Check for integer overflow on size calculations.
3796 * buffer.c (Fprevious_overlay_change): Remove var that is set
3799 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3800 Remove vars that are set but not used.
3801 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3802 (timer_check_2): Mark vars as initialized.
3804 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3806 * image.c (lookup_image): Remove var that is set but not used.
3807 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3809 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3810 that are set but not used.
3812 * xfns.c (make_invisible_cursor): Don't return garbage
3813 if XCreateBitmapFromData fails (Bug#8410).
3815 * xselect.c (x_get_local_selection, x_handle_property_notify):
3816 Remove vars that are set but not used.
3818 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3819 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3821 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3822 Remove var that is set but not used.
3823 (scroll_bar_windows_size): Now size_t, not int.
3824 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3827 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3828 (map_tty_color) [!defined MSDOS]: Likewise.
3830 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3832 * coding.c: Remove vars that are set but not used.
3833 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3834 All callers changed.
3835 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3836 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3837 (decode_coding_charset): Remove vars that are set but not used.
3839 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3840 that is set but not used.
3842 * print.c (print_object): Remove var that is set but not used.
3844 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3845 The gnulib version avoids calling malloc in the usual case,
3846 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3847 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3848 * filelock.c (current_lock_owner): Likewise.
3849 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3850 * sysdep.c: Include allocator.h, careadlinkat.h.
3851 (emacs_no_realloc_allocator): New static constant.
3852 (emacs_readlink): New function.
3853 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3854 ../lib/careadlinkat.h.
3856 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3858 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3859 first non-nil return value).
3861 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3863 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3864 if not defined (Bug#8403).
3866 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3868 * xdisp.c (display_count_lines): Remove parameter `start',
3869 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3870 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3871 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3872 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3873 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3874 and thereabouts. All callers changed.
3875 (get_per_char_metric): Remove parameter `f', unused since
3876 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3878 2011-04-02 Jim Meyering <meyering@redhat.com>
3880 do not dereference NULL upon failed strdup
3881 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3882 (ns_get_family): Likewise.
3884 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3886 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3888 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3890 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3893 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3895 Add lexical binding.
3897 * window.c (Ftemp_output_buffer_show): New fun.
3898 (Fsave_window_excursion):
3899 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3901 * lread.c (lisp_file_lexically_bound_p): New function.
3902 (Fload): Bind Qlexical_binding.
3903 (readevalloop): Remove `evalfun' arg.
3904 Bind Qinternal_interpreter_environment.
3905 (Feval_buffer): Bind Qlexical_binding.
3906 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3908 (syms_of_lread): Declare `lexical-binding'.
3910 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3912 * keyboard.c (eval_dyn): New fun.
3913 (menu_item_eval_property): Use it.
3915 * image.c (parse_image_spec): Use Ffunctionp.
3917 * fns.c (concat, mapcar1): Accept byte-code-functions.
3919 * eval.c (Fsetq): Handle lexical vars.
3920 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3921 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3922 (FletX, Flet): Obey lexical binding.
3923 (Fcommandp): Handle closures.
3924 (Feval): New `lexical' arg.
3925 (eval_sub): New function extracted from Feval. Use it almost
3926 everywhere where Feval was used. Look up vars in lexical env.
3928 (Ffunctionp): Move from subr.el.
3929 (Ffuncall): Handle closures.
3930 (apply_lambda): Remove `eval_flags'.
3931 (funcall_lambda): Handle closures and new byte-code-functions.
3932 (Fspecial_variable_p): New function.
3933 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3934 but without exporting it to Lisp.
3936 * doc.c (Fdocumentation, store_function_docstring):
3937 * data.c (Finteractive_form): Handle closures.
3939 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3942 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3944 (exec_byte_code): New function extracted from Fbyte_code to handle new
3945 calling convention for byte-code-functions. Add new byte-codes.
3947 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3949 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3951 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3953 * xdisp.c (redisplay_internal): Fix prototype.
3955 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3957 * xdisp.c (SCROLL_LIMIT): New macro.
3958 (try_scrolling): Use it when setting scroll_limit.
3959 Limit scrolling to 100 screen lines.
3960 (redisplay_window): Even when falling back on "recentering",
3961 position point in the window according to scroll-conservatively,
3962 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3964 (try_scrolling): When point is above the window, allow searching
3965 as far as scroll_max, or one screenful, to compute vertical
3966 distance from PT to the scroll margin position. This prevents
3967 try_scrolling from unnecessarily failing when
3968 scroll-conservatively is set to a value slightly larger than the
3969 window height. Clean up the case of PT below the margin at bottom
3970 of window: scroll_max can no longer be INT_MAX. When aggressive
3971 scrolling is in use, don't let point enter the opposite scroll
3972 margin as result of the scroll.
3973 (syms_of_xdisp) <scroll-conservatively>: Document the
3974 threshold of 100 lines for never-recentering scrolling.
3976 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3978 * dispextern.h (move_it_by_lines):
3979 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3980 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3981 (message_log_check_duplicate): Remove parameters `prev_bol' and
3982 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3983 (redisplay_internal): Remove parameter `preserve_echo_area',
3984 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3986 * indent.c (Fvertical_motion):
3987 * window.c (window_scroll_pixel_based, Frecenter):
3988 Don't pass `need_y_p' to `move_it_by_lines'.
3990 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3992 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3993 steal a few bits to be more compact.
3994 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3995 Remove unneeded casts.
3997 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3999 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4001 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4002 binding" message (bug#7967).
4004 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4006 Fix more problems found by GCC 4.6.0's static checks.
4008 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4009 Remove unused local var.
4011 * editfns.c (Fmessage_box): Remove unused local var.
4013 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4014 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4015 Omit unused local vars.
4016 * window.c (shrink_windows): Omit unused local var.
4017 * menu.c (digest_single_submenu): Omit unused local var.
4018 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4019 Omit unused local var.
4021 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4022 Don't assume string length fits in int.
4023 (keyremap_step, read_key_sequence): Use size_t for sizes.
4024 (read_key_sequence): Don't check last_real_key_start redundantly.
4026 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4027 instead of alloca (Bug#8344).
4029 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4030 (Fbacktrace_frame): Don't assume nframes fits in int.
4032 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4034 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4037 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4039 * cm.c (calccost): Turn while-do into do-while, for clarity.
4041 * keyboard.c (syms_of_keyboard): Use the same style as later
4042 in this function when indexing through an array. This also
4043 works around GCC bug 48267.
4045 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4047 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4049 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4050 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4052 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4053 This avoids undefined behavior on integer overflow, and is a bit
4054 more convenient anyway since it is compared to a size_t variable.
4056 Variadic C functions now count arguments with size_t, not int.
4057 This avoids an unnecessary limitation on 64-bit machines, which
4058 caused (substring ...) to crash on large vectors (Bug#8344).
4059 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4060 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4061 All variadic functions and their callers changed accordingly.
4062 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4063 * data.c (arith_driver, float_arith_driver): Likewise.
4064 * editfns.c (general_insert_function): Likewise.
4065 * eval.c (struct backtrace.nargs, interactive_p)
4066 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4067 (funcall_lambda, mark_backtrace): Likewise.
4068 * fns.c (concat): Likewise.
4069 * frame.c (x_set_frame_parameters): Likewise.
4070 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4071 0 if not found, not -1. All callers changed.
4073 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4074 (stack_copy_size): Now size_t, not int.
4075 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4077 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4079 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4080 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4081 All callers changed.
4083 * lisp.h (multibyte_char_to_unibyte):
4084 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4085 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4086 * character.h (CHAR_TO_BYTE8):
4087 * cmds.c (internal_self_insert):
4088 * editfns.c (general_insert_function):
4089 * keymap.c (push_key_description):
4090 * search.c (Freplace_match):
4091 * xdisp.c (message_dolog, set_message_1): All callers changed.
4093 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4095 * keyboard.c (safe_run_hook_funcall): New function.
4096 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4097 don't set the hook to nil, but remove the offending function instead.
4098 (Qcommand_hook_internal): Remove, unused.
4099 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4100 Vcommand_hook_internal.
4102 * eval.c (enum run_hooks_condition): Remove.
4103 (funcall_nil, funcall_not): New functions.
4104 (run_hook_with_args): Call each function through a `funcall' argument.
4105 Remove `cond' argument, now redundant.
4106 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4107 (Frun_hook_with_args_until_failure): Adjust accordingly.
4108 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4110 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4112 * dispextern.h (string_buffer_position): Remove declaration.
4114 * print.c (strout): Remove parameter `multibyte', unused since
4115 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4117 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4118 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4119 All callers changed.
4121 * w32.c (_wsa_errlist): Use braces for struct initializers.
4123 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4124 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4125 All callers changed.
4126 (string_buffer_position): Likewise. Also, make static (it's never
4127 used outside xdisp.c).
4128 (cursor_row_p): Remove parameter `w', unused since
4129 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4130 (decode_mode_spec): Remove parameter `precision', introduced during
4131 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4132 All callers changed.
4134 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4136 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4138 2011-03-27 Anders Lindgren <andlind@gmail.com>
4140 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4141 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4142 (ns_update_auto_hide_menu_bar): New functions.
4143 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4144 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4145 ns_constrain_all_frames.
4146 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4147 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4149 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4151 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4153 2011-03-27 Glenn Morris <rgm@gnu.org>
4155 * syssignal.h: Replace RETSIGTYPE with void.
4156 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4157 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4158 Replace SIGTYPE with void everywhere.
4159 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4160 * s/template.h (SIGTYPE): Remove commented out definition.
4162 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4164 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4165 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4167 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4169 * w32.c (read_unc_volume): Use parameter `henum', instead of
4170 global variable `wget_enum_handle'.
4172 * keymap.c (describe_vector): Remove parameters `indices' and
4173 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4174 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4176 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4178 * keyboard.c (timer_check): Remove parameter `do_it_now',
4179 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4180 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4181 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4183 * keyboard.c (read_char):
4184 * w32menu.c (w32_menu_display_help):
4185 * xmenu.c (show_help_event, menu_help_callback):
4186 Adjust calls to `show_help_echo'.
4188 * gtkutil.c (xg_maybe_add_timer):
4189 * keyboard.c (readable_events):
4190 * process.c (wait_reading_process_output):
4191 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4193 * insdel.c (adjust_markers_gap_motion):
4194 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4195 (gap_left, gap_right): Don't call it.
4197 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4199 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4200 incurred during fontification.
4202 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4204 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4205 (DEFVAR_PER_BUFFER): Don't pass it.
4207 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4208 (scrolling_window): Don't pass it.
4210 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4212 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4214 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4216 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4217 of variables specific to SELinux and computation of `encoded_absname'.
4219 * image.c (XPutPixel): Remove unused variable `height'.
4221 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4223 * unexw32.c (get_section_info): Remove unused variable `section'.
4225 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4226 (system_process_attributes): Remove unused variable `sess'.
4227 (sys_read): Remove unused variable `err'.
4229 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4230 (w32_wnd_proc): Remove unused variable `isdead'.
4231 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4232 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4233 (x_create_tip_frame): Remove unused variable `tem'.
4235 * w32inevt.c (w32_console_read_socket):
4236 Remove unused variable `no_events'.
4238 * w32term.c (x_draw_composite_glyph_string_foreground):
4239 Remove unused variable `width'.
4241 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4243 * w32term.c (x_set_glyph_string_clipping):
4244 Don't pass uninitialized region to CombineRgn.
4246 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4248 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4249 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4250 (Fx_close_connection): Remove unused variable `i'.
4252 * w32font.c (w32font_draw): Return number of glyphs.
4253 (w32font_open_internal): Remove unused variable `i'.
4254 (w32font_driver): Add missing initializer.
4256 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4257 (fill_in_menu): Remove unused variable `items_added'.
4259 * w32term.c (last_mouse_press_frame): Remove static global variable.
4260 (w32_clip_to_row): Remove unused variable `f'.
4261 (x_delete_terminal): Remove unused variable `i'.
4263 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4264 (NOTHING): Remove unused static global variable.
4265 (uniscribe_check_otf): Remove unused variable `table'.
4266 (uniscribe_font_driver): Add missing initializers.
4268 2011-03-23 Julien Danjou <julien@danjou.info>
4270 * term.c (Fsuspend_tty, Fresume_tty):
4271 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4272 * window.c (temp_output_buffer_show):
4273 * insdel.c (signal_before_change):
4274 * frame.c (Fhandle_switch_frame):
4275 * fileio.c (Fdo_auto_save):
4276 * emacs.c (Fkill_emacs):
4277 * editfns.c (save_excursion_restore):
4278 * cmds.c (internal_self_insert):
4279 * callint.c (Fcall_interactively):
4280 * buffer.c (Fkill_all_local_variables):
4281 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4283 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4284 unconditionnaly since it does the check itself.
4286 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4288 Fix more problems found by GCC 4.5.2's static checks.
4290 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4291 the first time through the loop, since we know p0 < p1 then.
4292 This also avoids a gcc -Wstrict-overflow warning.
4294 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4295 leading to a memory leak, possible in functions like
4296 load_charset_map_from_file that can allocate an unbounded number
4297 of objects (Bug#8318).
4299 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4300 that could (at least in theory) be that large.
4302 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4303 This is less likely to overflow, and avoids undefined behavior if
4304 overflow does occur. All callers changed. Use strtoul to scan
4305 for the unsigned long integer.
4306 (pint2hrstr): Simplify and tune code slightly.
4307 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4309 * scroll.c (do_scrolling): Work around GCC bug 48228.
4310 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4312 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4313 This also avoids a warning with gcc -Wstrict-overflow.
4314 (validate_x_resource_name): Simplify count usage.
4315 This also avoids a warning with gcc -Wstrict-overflow.
4317 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4320 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4322 * process.c (Fmake_network_process): Use socklen_t, not int,
4323 where POSIX says socklen_t is required in portable programs.
4324 This fixes a porting bug on hosts like 64-bit HP-UX, where
4325 socklen_t is wider than int (Bug#8277).
4326 (Fmake_network_process, server_accept_connection):
4327 (wait_reading_process_output, read_process_output):
4330 * process.c: Rename or move locals to avoid shadowing.
4331 (list_processes_1, Fmake_network_process):
4332 (read_process_output_error_handler, exec_sentinel_error_handler):
4333 Rename or move locals.
4334 (Fmake_network_process): Define label "retry_connect" only if needed.
4335 (Fnetwork_interface_info): Fix pointer signedness.
4336 (process_send_signal): Add cast to avoid pointer signedness problem.
4337 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4338 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4340 Make tparam.h and terminfo.c consistent.
4341 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4342 Include tparam.h instead, since it declares them.
4343 * cm.h (PC): Remove extern decl; tparam.h now does this.
4344 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4345 * terminfo.c: Include tparam.h, to check interfaces.
4346 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4347 (tparam): Adjust signature to match interface in tparam.h;
4348 this removes some undefined behavior. Check that outstring and len
4349 are zero, which they always are with Emacs.
4350 * tparam.h (PC, BC, UP): New extern decls.
4352 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4353 (xftfont_open): Rename locals to avoid shadowing.
4355 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4356 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4357 (OTF_TAG_SYM): Omit macro if not needed.
4358 (ftfont_list): Remove unused local.
4359 (get_adstyle_property, ftfont_pattern_entity):
4360 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4361 Rename locals to avoid shadowing.
4363 * xfont.c (xfont_list_family): Mark var as initialized.
4365 * xml.c (make_dom): Now static.
4367 * composite.c (composition_compute_stop_pos): Rename local to
4369 (composition_reseat_it): Remove unused locals.
4370 (find_automatic_composition, composition_adjust_point): Likewise.
4371 (composition_update_it): Mark var as initialized.
4372 (find_automatic_composition): Mark vars as initialized,
4373 with a FIXME (Bug#8290).
4375 character.h: Rename locals to avoid shadowing.
4376 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4377 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4378 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4379 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4382 * textprop.c (property_change_between_p): Remove; unused.
4384 * intervals.c (interval_start_pos): Now static.
4386 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4388 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4389 Rename locals to avoid shadowing.
4391 * sound.c (wav_play, au_play, Fplay_sound_internal):
4392 Fix pointer signedness.
4393 (alsa_choose_format): Remove unused local var.
4394 (wav_play): Initialize a variable to 0, to prevent undefined
4395 behavior (Bug#8278).
4397 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4399 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4401 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4402 clobbering (Bug#8298).
4403 * sysdep.c (sys_subshell): Likewise.
4404 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4406 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4407 This should get cleaned up, so that child_setup has the
4408 same signature on all platforms.
4410 * callproc.c (call_process_cleanup): Now static.
4411 (relocate_fd): Rename locals to avoid shadowing.
4413 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4415 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4416 not to be necessary, and produces flickering.
4418 2011-03-20 Glenn Morris <rgm@gnu.org>
4420 * config.in: Remove file.
4422 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4424 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4425 are now in src/globals.h.
4426 (syms_of_minibuf): Remove spurious & from previous change.
4428 2011-03-20 Leo <sdl.web@gmail.com>
4430 * minibuf.c (completing-read-function): New variable.
4431 (completing-read-default): Rename from completing-read.
4432 (completing-read): Call completing-read-function.
4434 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4436 * xfaces.c (Fx_load_color_file):
4437 Read color file from absolute filename (bug#8250).
4439 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4441 * makefile.w32-in: Update dependencies.
4443 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4445 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4447 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4449 Fix more problems found by GCC 4.5.2's static checks.
4451 * process.c (make_serial_process_unwind, send_process_trap):
4452 (sigchld_handler): Now static.
4454 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4455 That way, the code declares only the vars that it needs.
4456 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4457 * s/cygwin.h (PTY_ITERATION): Likewise.
4458 * s/darwin.h (PTY_ITERATION): Likewise.
4459 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4461 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4462 * process.c (allocate_pty): Don't declare stb unless it's needed.
4464 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4465 (CONSTANTLIM): Remove; unused.
4466 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4467 Define only if needed.
4469 * unexelf.c (unexec): Name an expression,
4470 to avoid gcc -Wbad-function-cast warning.
4471 Use a different way to cause a compilation error if anyone uses
4472 n rather than nn, a way that does not involve shadowing.
4473 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4475 * deps.mk (unexalpha.o): Remove; unused.
4477 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4478 * unexec.h: New file.
4479 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4480 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4482 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4483 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4484 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4485 Change as necessary to match prototype in unexec.h.
4487 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4489 (back_comment, skip_chars): Mark vars as initialized.
4491 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4492 Rename locals to avoid shadowing.
4494 * lread.c (read1): Rewrite so as not to use empty "else".
4495 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4497 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4499 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4500 warning when compiling print.c.
4502 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4503 instead of using an uninitialized var.
4504 (font_sort_entities): Mark var as initialized.
4506 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4508 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4509 pointers to constants.
4510 (font_parse_fcname): Remove unused vars.
4511 (font_delete_unmatched): Now static.
4512 (font_get_spec): Remove; unused.
4513 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4514 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4515 Rename or move locals to avoid shadowing.
4517 * fns.c (require_nesting_list, require_unwind): Now static.
4518 (Ffillarray): Rename locals to avoid shadowing.
4520 * floatfns.c (domain_error2): Define only if needed.
4521 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4523 * alloc.c (mark_backtrace): Move decl from here ...
4524 * lisp.h: ... to here, so that it can be checked.
4526 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4527 (Fdefvar): Rewrite so as not to use empty "else".
4528 (lisp_indirect_variable): Name an expression,
4529 to avoid gcc -Wbad-function-cast warning.
4530 (Fdefvar): Rename locals to avoid shadowing.
4532 * callint.c (quotify_arg, quotify_args): Now static.
4533 (Fcall_interactively): Rename locals to avoid shadowing.
4534 Use const pointer when appropriate.
4536 * lisp.h (get_system_name, get_operating_system_release):
4537 Move decls here, to check interfaces.
4538 * process.c (get_operating_system_release): Move decl to lisp.h.
4539 * xrdb.c (get_system_name): Likewise.
4540 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4541 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4542 some of which prompt warnings from gcc -Wbad-function-cast.
4543 (Fformat_time_string, Fencode_time, Finsert_char):
4544 (Ftranslate_region_internal, Fformat):
4545 Rename or remove local vars to avoid shadowing.
4546 (Ftranslate_region_internal): Mark var as initialized.
4548 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4551 * lisp.h (eassert): Check that the argument compiles, even if
4552 ENABLE_CHECKING is not defined.
4554 * data.c (Findirect_variable): Name an expression, to avoid
4555 gcc -Wbad-function-cast warning.
4556 (default_value, arithcompare, arith_driver, arith_error): Now static.
4557 (store_symval_forwarding): Rename local to avoid shadowing.
4558 (Fmake_variable_buffer_local, Fmake_local_variable):
4559 Mark variables as initialized.
4560 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4562 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4563 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4564 Rename locals to avoid shadowing.
4565 (mark_stack): Move local variables into the #ifdef region where
4567 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4568 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4570 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4571 (GC_STRING_CHARS): Remove; not used.
4572 (Fmemory_limit): Cast sbrk's returned value to char *.
4574 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4575 avoids undefined behavior in theory.
4577 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4579 Use functions, not macros, for up- and down-casing (Bug#8254).
4580 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4581 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4582 to use the following functions instead of these macros.
4583 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4584 EMACS_INT, since callers assume the returned value fits in int.
4585 (upcase1): Likewise, for UPCASE_TABLE.
4586 (uppercasep, lowercasep, upcase): New static inline functions.
4587 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4588 the race-condition problem in the old DOWNCASE.
4590 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4591 Rename locals to avoid shadowing.
4592 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4593 (regex_compile, re_search_2, re_match_2_internal):
4594 Remove unused local vars.
4595 (FREE_VAR): Rewrite so as not to use empty "else",
4596 which gcc can warn about.
4597 (regex_compile, re_match_2_internal): Mark locals as initialized.
4598 (RETALLOC_IF): Define only if needed.
4599 (WORDCHAR_P): Likewise. This one is never needed, but is used
4600 only in a comment talking about a compiler bug, so put inside
4601 the #if 0 of that comment.
4602 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4603 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4606 * search.c (boyer_moore): Rename locals to avoid shadowing.
4607 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4608 (PREV_CHAR_BOUNDARY): Likewise.
4610 * search.c (simple_search): Remove unused var.
4612 * dired.c (compile_pattern): Move decl from here ...
4613 * lisp.h: ... to here, so that it can be checked.
4614 (struct re_registers): New forward decl.
4616 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4618 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4620 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4621 Rename locals to avoid shadowing.
4622 (Fvertical_motion): Mark locals as initialized.
4624 * casefiddle.c (casify_object, casify_region): Now static.
4625 (casify_region): Mark local as initialized.
4627 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4629 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4630 New macros, so that the caller can use some names other than
4631 gcpro1, gcpro2, etc.
4632 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4634 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4635 argument, for consistency with GCPRO2_VAR, etc: it is now the
4636 prefix of the variable, not the variable itself. All uses
4638 * dired.c (directory_files_internal, file_name_completion):
4639 Rename locals to avoid shadowing.
4641 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4642 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4643 dired.c's scmp function, had undefined behavior.
4644 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4645 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4646 * buffer.h: ... to here, because these macros use current_buffer,
4647 and the new implementation with inline functions needs to have
4648 current_buffer in scope now, rather than later when the macros
4650 (downcase, upcase1): New static inline functions.
4651 (DOWNCASE, UPCASE1): Reimplement using these functions.
4652 This avoids undefined behavior in expressions like
4653 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4654 from race conditions in accessing the global variables
4655 case_temp1 and case_temp2.
4656 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4657 * lisp.h (case_temp1, case_temp2): Remove their decls.
4658 * character.h (ASCII_CHAR_P): Move from here ...
4659 * lisp.h: ... to here, so that the inline functions mentioned
4662 * dired.c (directory_files_internal_unwind): Now static.
4664 * fileio.c (file_name_as_directory, directory_file_name):
4665 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4667 (file_name_as_directory): Use const pointers when appropriate.
4668 (Fexpand_file_name): Likewise. In particular, newdir might
4669 point at constant storage, so make it a const pointer.
4670 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4671 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4673 (Fset_file_times, Finsert_file_contents, auto_save_error):
4674 Rename locals to avoid shadowing.
4676 * minibuf.c (choose_minibuf_frame_1): Now static.
4677 (Ftry_completion, Fall_completions): Rename or remove locals
4680 * marker.c (bytepos_to_charpos): Remove; unused.
4682 * lisp.h (verify_bytepos, count_markers): New decls,
4683 so that gcc does not warn that these functions aren't declared.
4685 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4686 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4687 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4688 (copy_text): Remove unused local var.
4690 * filelock.c (within_one_second): Now static.
4691 (lock_file_1): Rename local to avoid shadowing.
4693 * buffer.c (fix_overlays_before): Mark locals as initialized.
4694 (fix_start_end_in_overlays): Likewise. This function should be
4695 simplified by using pointers-to-pointers, but that's a different
4697 (switch_to_buffer_1): Now static.
4698 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4699 (report_overlay_modification): Rename locals to avoid shadowing.
4701 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4702 Fix pointer signedness issue.
4703 (sys_subshell): Mark local as volatile if checking for lint,
4704 to suppress a gcc -Wclobbered warning that does not seem to be right.
4705 (MAXPATHLEN): Define only if needed.
4707 * process.c (serial_open, serial_configure): Move decls from here ...
4708 * systty.h: ... to here, so that they can be checked.
4710 * fns.c (get_random, seed_random): Move extern decls from here ...
4711 * lisp.h: ... to here, so that they can be checked.
4713 * sysdep.c (reset_io): Now static.
4714 (wait_for_termination_signal): Remove; unused.
4716 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4717 (copy_keymap_item, append_key, push_text_char_description):
4719 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4720 (DENSE_TABLE_SIZE): Remove; unused.
4721 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4722 (describe_map_tree):
4723 Rename locals to avoid shadowing.
4725 * keyboard.c: Declare functions static if they are not used elsewhere.
4726 (echo_char, echo_dash, cmd_error, top_level_2):
4727 (poll_for_input, handle_async_input): Now static.
4728 (read_char, kbd_buffer_get_event, make_lispy_position):
4729 (make_lispy_event, make_lispy_movement, apply_modifiers):
4730 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4731 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4732 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4733 (read_key_sequence, read_char): Mark locals as initialized.
4734 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4736 * keyboard.h (make_ctrl_char): New decl.
4737 (mark_kboards): Move decl here ...
4738 * alloc.c (mark_kboards): ... from here.
4740 * lisp.h (force_auto_save_soon): New decl.
4742 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4743 (DEFINE_DUMMY_FUNCTION): New macro.
4744 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4746 (main): Add casts to avoid warnings
4747 if GCC considers string literals to be constants.
4749 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4751 * dbusbind.c: Pointer signedness fixes.
4752 (xd_signature, xd_append_arg, xd_initialize):
4753 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4754 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4755 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4756 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4758 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4759 if GCC considers string literals to be constants.
4760 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4762 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4764 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4765 (print_preprocess, print_object): New macro to fix last change.
4767 * print.c (print_preprocess): Don't forget font objects.
4769 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4771 * emacs.c (USAGE3): Doc fixes.
4773 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4775 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4778 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4780 * lisp.h (VWindow_system, Qfile_name_history):
4781 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4782 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4783 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4785 * w32select.c: Don't #include "keyboard.h".
4786 (run_protected): Add extern declaration for waiting_for_input.
4788 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4789 * w32console.c (detect_input_pending, read_input_pending)
4790 (encode_terminal_code):
4791 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4792 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4793 (w32_system_caret_y, Qfile_name_history):
4794 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4795 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4796 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4797 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4798 * w32proc.c (Qlocal, report_file_error):
4799 * w32term.c (Vwindow_system, updating_frame):
4800 * w32uniscribe.c (initialized, uniscribe_font_driver):
4801 Remove unneeded extern declarations.
4803 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4805 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4807 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4809 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4810 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4811 These macros can no longer be used for assignment.
4813 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4814 Assign struct members directly, instead of using BUF_BEGV etc.
4815 (record_buffer_markers, fetch_buffer_markers): New functions for
4816 recording and fetching special buffer markers.
4817 (set_buffer_internal_1, set_buffer_temp): Use them.
4819 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4821 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4823 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4824 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4826 * xdisp.c (hscroll_window_tree):
4827 (reconsider_clip_changes): Use PT instead of BUF_PT.
4829 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4831 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4832 $(EMACS_ROOT)/lib/intprops.h.
4834 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4836 Fix more problems found by GCC 4.5.2's static checks.
4838 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4839 to unsigned char * to avoid compiler diagnostic.
4840 (xg_free_frame_widgets): Make it clear that a local variable is
4841 needed only if USE_GTK_TOOLTIP.
4842 (gdk_window_get_screen): Make it clear that this macro is needed
4843 only if USE_GTK_TOOLTIP.
4844 (int_gtk_range_get_value): New function, which avoids a diagnostic
4845 from gcc -Wbad-function-cast.
4846 (xg_set_toolkit_scroll_bar_thumb): Use it.
4847 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4848 diagnostic from gcc -Wbad-function-cast.
4849 (get_utf8_string, xg_get_file_with_chooser):
4850 Rename locals to avoid shadowing.
4851 (create_dialog): Move locals to avoid shadowing.
4853 * xgselect.c (xg_select): Remove unused var.
4855 * image.c (four_corners_best): Mark locals as initialized.
4856 (gif_load): Initialize transparent_p to zero (Bug#8238).
4857 Mark another local as initialized.
4858 (my_png_error, my_error_exit): Mark with NO_RETURN.
4860 * image.c (clear_image_cache): Now static.
4861 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4862 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4863 (x_edge_detection): Remove unnecessary cast that
4864 gcc -Wbad-function-cast diagnoses.
4865 (gif_load): Fix pointer signedness.
4866 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4867 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4869 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4871 Improve quality of tests for time stamp overflow.
4872 For example, without this patch (encode-time 0 0 0 1 1
4873 1152921504606846976) returns the obviously-bogus value (-948597
4874 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4875 reports time overflow. See
4876 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4877 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4878 * editfns.c: Include limits.h and intprops.h.
4879 (TIME_T_MIN, TIME_T_MAX): New macros.
4880 (time_overflow): Move earlier, to before first use.
4881 (hi_time, lo_time): New functions, for an accurate test for
4883 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4884 (Fget_internal_run_time): Don't assume time_t fits in int.
4885 (make_time): Use list2 instead of Fcons twice.
4886 (Fdecode_time): More accurate test for out-of-range times.
4887 (check_tm_member): New function.
4888 (Fencode_time): Use it, to test for out-of-range times.
4889 (lisp_time_argument): Don't rely on undefined left-shift and
4890 right-shift behavior when checking for time stamp overflow.
4892 * editfns.c (time_overflow): New function, refactoring common code.
4893 (Fformat_time_string, Fdecode_time, Fencode_time):
4894 (Fcurrent_time_string): Use it.
4896 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4897 * dired.c (make_time): Move to ...
4898 * editfns.c (make_time): ... here.
4899 * systime.h: Note the move.
4901 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4903 * fringe.c (update_window_fringes): Remove unused variables.
4905 * unexmacosx.c (copy_data_segment): Also copy __got section.
4908 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4910 * termcap.c [MSDOS]: Include "msdos.h".
4911 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4912 Constify `char *' arguments and their references according to
4913 prototypes in tparam.h.
4915 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4917 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4918 Adapt all references accordingly.
4920 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4922 2011-03-11 Tom Tromey <tromey@redhat.com>
4924 * buffer.c (syms_of_buffer): Remove obsolete comment.
4926 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4928 * termhooks.h (encode_terminal_code): Declare prototype.
4930 * msdos.c (encode_terminal_code): Don't declare prototype.
4932 * term.c (encode_terminal_code): Now external again, used by
4933 w32console.c and msdos.c.
4935 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4936 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4938 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4940 Fix some minor problems found by GCC 4.5.2's static checks.
4942 * fringe.c (update_window_fringes): Mark locals as initialized
4944 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4946 * alloc.c (mark_fringe_data): Move decl from here ...
4947 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4948 to check its interface.
4949 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4951 * fontset.c (free_realized_fontset): Now static.
4952 (Fset_fontset_font): Rename local to avoid shadowing.
4953 (fontset_font): Mark local as initialized.
4954 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4956 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4958 * xselect.c (x_disown_buffer_selections): Remove; not used.
4959 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4960 (x_own_selection, Fx_disown_selection_internal): Rename locals
4962 (x_handle_dnd_message): Remove local to avoid shadowing.
4964 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4965 so that the caller can use some name other than gcpro1.
4966 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4967 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4968 (Fx_backspace_delete_keys_p):
4969 Use them to avoid shadowing, and rename vars to avoid shadowing.
4970 (x_decode_color, x_set_name, x_window): Now static.
4971 (Fx_create_frame): Add braces to silence GCC warning.
4972 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4973 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4974 Remove unused locals.
4975 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4976 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4977 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4980 * xterm.h (x_mouse_leave): New decl.
4982 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4983 Remove unused functions.
4984 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4985 (x_calc_absolute_position): Now static.
4986 (XTread_socket): Don't define label "out" unless it's used.
4987 Don't declare local "event" unless it's used.
4988 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4989 unless they are used.
4990 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4991 (x_fatal_error_signal): Remove; not used.
4992 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4993 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4994 (x_error_catcher, x_connection_closed, x_error_handler):
4995 (x_error_quitter, xembed_send_message, x_iconify_frame):
4996 (my_log_handler): Rename locals to avoid shadowing.
4997 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4998 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5000 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5001 Rename or move locals to avoid shadowing.
5002 (tty_defined_color, merge_face_heights): Now static.
5003 (free_realized_faces_for_fontset): Remove; not used.
5004 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5005 does not deduce is never used uninitialized.
5006 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5007 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5009 * terminal.c (store_terminal_param): Now static.
5011 * xmenu.c (menu_highlight_callback): Now static.
5012 (set_frame_menubar): Remove unused local.
5013 (xmenu_show): Rename parameter to avoid shadowing.
5014 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5015 since they might point to immutable storage.
5016 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5017 since it's unused otherwise.
5019 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5020 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5021 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5022 avoids a gcc -Wuninitialized diagnostic.
5023 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5024 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5025 does not deduce are never used uninitialized.
5027 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5029 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5030 * window.c (window_loop, size_window):
5031 (run_window_configuration_change_hook, enlarge_window): Likewise.
5033 * window.c (display_buffer): Now static.
5034 (size_window): Mark variables that gcc -Wuninitialized
5035 does not deduce are never used uninitialized.
5036 * window.h (check_all_windows): New decl, to forestall
5037 gcc -Wmissing-prototypes diagnostic.
5038 * dispextern.h (bidi_dump_cached_states): Likewise.
5040 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5042 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5044 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5045 and to avoid gcc -Wuninitialized warning.
5046 (load_charset_map): Mark variables that gcc -Wuninitialized
5047 does not deduce are never used uninitialized.
5048 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5050 * coding.c (coding_set_source, coding_set_destination):
5051 Use "else { /* comment */ }" rather than "else /* comment */;"
5052 for clarity, and to avoid gcc -Wempty-body warning.
5053 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5054 a block, when the outer 'i' will do.
5055 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5056 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5057 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5058 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5059 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5060 Rename locals to avoid shadowing.
5061 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5062 * coding.c (emacs_mule_char, encode_invocation_designation):
5063 Now static, since they're not used elsewhere.
5064 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5065 (decode_coding_object, encode_coding_object, detect_coding_system):
5066 (decode_coding_emacs_mule): Mark variables that gcc
5067 -Wuninitialized does not deduce are never used uninitialized.
5068 (detect_coding_iso_2022): Initialize a local variable that might
5069 be used uninitialized. Leave a FIXME because it's not clear that
5070 this initialization is needed. (Bug#8211)
5071 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5072 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5073 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5074 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5075 Remove unused macros.
5077 * category.c (hash_get_category_set): Remove unused local var.
5078 (copy_category_table): Now static, since it's not used elsewhere.
5079 * character.c (string_count_byte8): Likewise.
5081 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5082 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5084 * chartab.c (copy_sub_char_table): Now static, since it's not used
5086 (sub_char_table_ref_and_range, char_table_ref_and_range):
5087 Rename locals to avoid shadowing.
5088 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5090 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5091 (BIDI_BOB): Remove unused macro.
5093 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5094 deduce are never used uninitialized.
5095 * term.c (encode_terminal_code): Likewise.
5097 * term.c (encode_terminal_code): Now static. Remove unused local.
5099 * tparam.h: New file.
5100 * term.c, tparam.h: Include it.
5101 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5102 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5103 Move these decls to tparam.h, and make them agree with what
5104 is actually in tparam.c. The previous trick of using incompatible
5105 decls in different modules does not conform to the C standard.
5106 All callers of tparam changed to use tparam's actual API.
5107 * tparam.c (tparam1, tparam, tgoto):
5108 Use const pointers where appropriate.
5110 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5111 * cm.h (struct cm): Likewise.
5112 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5113 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5114 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5115 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5116 (turn_on_face, init_tty): Likewise.
5117 * termchar.h (struct tty_display_info): Likewise.
5119 * term.c (term_mouse_position): Rename local to avoid shadowing.
5121 * alloc.c (mark_ttys): Move decl from here ...
5122 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5124 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5126 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5128 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5130 * search.c (compile_pattern_1): Remove argument regp, unused since
5131 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5132 (compile_pattern): Don't pass it.
5134 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5136 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5137 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5139 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5141 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5143 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5144 gdk_window_get_screen, gdk_window_get_geometry,
5145 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5146 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5147 (xg_get_pixbuf_from_pixmap): New function.
5148 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5149 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5150 Call xg_get_pixbuf_from_pixmap instead of
5151 gdk_pixbuf_get_from_drawable.
5152 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5153 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5154 (xg_check_special_colors): Use GtkStyleContext and its functions
5156 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5157 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5158 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5159 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5160 Call gtk_widget_get_preferred_size.
5161 (xg_frame_resized): gdk_window_get_geometry only takes 5
5163 (xg_win_to_widget, xg_event_is_for_menubar):
5164 Call gdk_x11_window_lookup_for_display.
5165 (xg_set_widget_bg): New function.
5166 (delete_cb): New function.
5167 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5168 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5169 (xg_set_background_color): Call xg_set_widget_bg.
5170 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5171 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5172 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5173 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5175 (update_frame_tool_bar): Call gtk_widget_hide.
5176 (xg_initialize): Use GDK_KEY_g.
5178 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5180 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5182 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5183 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5184 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5186 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5188 * w32xfns.c (select_palette): Check success of RealizePalette against
5189 GDI_ERROR, not zero.
5191 See ChangeLog.11 for earlier changes.
5197 Copyright (C) 2011 Free Software Foundation, Inc.
5199 This file is part of GNU Emacs.
5201 GNU Emacs is free software: you can redistribute it and/or modify
5202 it under the terms of the GNU General Public License as published by
5203 the Free Software Foundation, either version 3 of the License, or
5204 (at your option) any later version.
5206 GNU Emacs is distributed in the hope that it will be useful,
5207 but WITHOUT ANY WARRANTY; without even the implied warranty of
5208 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5209 GNU General Public License for more details.
5211 You should have received a copy of the GNU General Public License
5212 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.