Implement default help-echo for mode line.
[bpt/emacs.git] / src / ChangeLog
1 2012-06-03 Chong Yidong <cyd@gnu.org>
2
3 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
4 (note_mode_line_or_margin_highlight): If there is no help echo,
5 use mode-line-default-help-echo. Handle the case where the mouse
6 position is past the end of the mode line string.
7
8 * buffer.c (buffer_local_value_1): New function, split from
9 Fbuffer_local_value; can return Qunbound.
10 (Fbuffer_local_value): Use it.
11 (Vmode_line_format): Docstring tweaks.
12
13 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
14
15 * sysdep.c (system_process_attributes): Improve comment.
16
17 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
18
19 * keyboard.c: Export real-this-command to Elisp.
20 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
21 and DEFVAR it. Update all users.
22
23 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
24
25 * minibuf.c (Fassoc_string): Remove duplicate declaration.
26
27 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
28 Convert pctcpu and pctmem to Lisp float properly.
29 Let the compiler fold better, as 100.0/0x8000 is exact.
30
31 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
32
33 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
34 cons_block.
35
36 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
37
38 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
39
40 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
41
42 For a 'struct window', replace some Lisp_Object fields to
43 bitfields where appropriate, remove unused fields.
44 * window.h (struct window): Remove unused 'last_mark_x' and
45 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
46 change it's type from Lisp_Object to bitfield.
47 Change type of 'force_start', 'optional_new_start',
48 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
49 fields from Lisp_Object to bitfield. Adjust users accordingly.
50
51 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
52
53 Pacify gcc -Wdouble-precision when using Xaw.
54 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
55 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
56 Use 'float' consistently, rather than 'float' in most places
57 and 'double' in a couple of places.
58
59 2012-05-31 Eli Zaretskii <eliz@gnu.org>
60
61 * xdisp.c (handle_stop): Detect whether we have overlay strings
62 loaded by testing it->current.overlay_string_index to be
63 non-negative, instead of checking whether n_overlay_strings is
64 positive. (Bug#11587)
65
66 2012-05-31 Chong Yidong <cyd@gnu.org>
67
68 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
69
70 * doc.c (Fsubstitute_command_keys): Doc fix.
71
72 2012-05-31 Eli Zaretskii <eliz@gnu.org>
73
74 * search.c (search_buffer): Remove calls to
75 r_alloc_inhibit_buffer_relocation, as it is now called by
76 maybe_unify_char, which was the cause of relocation of buffer text
77 in bug#11519.
78
79 2012-05-31 Eli Zaretskii <eliz@gnu.org>
80
81 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
82 for the duration of call to load_charset, to avoid problems with
83 callers of maybe_unify_char that access buffer text through C
84 pointers.
85
86 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
87 decrement the inhibition flag, instead of just setting or
88 resetting it.
89
90 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
91
92 Remove obsolete '#define static' cruft.
93 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
94 This #undef was "temporary" in 2000; it is no longer needed
95 now that '#define static' has gone away.
96 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
97 (gray_bitmap_bits): Remove; no longer needed.
98 All uses replaced with definiens.
99 * xterm.c: Include "bitmaps/gray.xbm".
100
101 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
102
103 Clean up __executable_start, monstartup when --enable-profiling.
104 The following changes affect the code only when profiling.
105 * dispnew.c (__executable_start): Rename from safe_bcopy.
106 Define only on platforms that need it.
107 * emacs.c: Include <sys/gmon.h> when profiling.
108 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
109 (__executable_start): Remove decl, since lisp.h does it now.
110 (safe_bcopy): Remove decl; no longer has that name.
111 (main): Coalesce #if into single bit of code, for simplicity.
112 Cast pointers to uintptr_t, since standard libraries want integers
113 and not pointers.
114 * lisp.h (__executable_start): New decl.
115
116 2012-05-31 Glenn Morris <rgm@gnu.org>
117
118 * image.c (Fimagemagick_types): Doc fix.
119
120 2012-05-30 Jim Meyering <meyering@redhat.com>
121
122 * callproc.c (Fcall_process_region): Include directory component
123 in mkstemp error message (Bug#11586).
124
125 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
126
127 * alloc.c, lisp.h (make_pure_vector): Now static.
128
129 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
130
131 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
132 Move to byte-run.el.
133 (Fautoload): Do the hash-doc more carefully.
134 * data.c (Fdefalias): Purify definition, except for keymaps.
135 (Qdefun): Move from eval.c.
136 * lisp.h (Qdefun): Remove.
137 * lread.c (read1): Tiny simplification.
138
139 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
140
141 Do not create empty overlays with the evaporate property (Bug#9642).
142 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
143 Bug#9642, but explicitly check that the buffer the overlay would
144 be moved to is live and rearrange lines to make sure that errors
145 will not put the overlay in an inconsistent state.
146 (Fdelete_overlay): Cosmetics.
147
148 2012-05-28 Eli Zaretskii <eliz@gnu.org>
149
150 * w32term.c (my_bring_window_to_top): New function.
151 (x_raise_frame): Use handle returned by DeferWindowPos, which
152 could be different from the original one.
153 Call my_bring_window_to_top instead of my_set_foreground_window.
154 (Bug#11513)
155
156 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
157 by calling BringWindowToTop.
158
159 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
160 (WM_EMACS_END): Increase by one.
161
162 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
163
164 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
165 This avoids undefined behavior that might cause the eassert
166 to not catch an out-of-range value.
167
168 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
169
170 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
171 Update dependencies.
172
173 2012-05-27 Eli Zaretskii <eliz@gnu.org>
174
175 * bidi.c (bidi_mirror_char): Fix last change.
176
177 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
178
179 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
180 when referring to sectname field in printf format.
181
182 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
183
184 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
185 Only r_alloc_inhibit_buffer_relocation needed to be added;
186 the others were already declared.
187
188 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
189 before checking whether it's out of range. Put the check inside
190 eassert. See
191 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
192
193 2012-05-27 Ken Brown <kbrown@cornell.edu>
194
195 * callproc.c (Fcall_process): Restore a line that was accidentally
196 commented out in the 2011-02-13 change (bug#11547).
197
198 2012-05-27 Eli Zaretskii <eliz@gnu.org>
199
200 * lisp.h [REL_ALLOC]: Add prototypes for external functions
201 defined on ralloc.c.
202
203 * buffer.c [REL_ALLOC]: Remove prototypes of
204 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
205 they are now on lisp.h.
206
207 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
208
209 * search.c (search_buffer): Use it to inhibit relocation of buffer
210 text while re_search_2 is doing its job, because re_search_2 is
211 passed C pointers to buffer text. (Bug#11519)
212
213 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
214 Update value to 24.
215
216 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
217 state after an additional call to move_it_in_display_line_to, keep
218 the values of it->max_ascent and it->max_descent found for the
219 entire line.
220 (pos_visible_p): Revert the comparison against bottom_y to what it
221 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
222 (Bug#11464)
223
224 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
225
226 Fix coding-related core dumps with gcc -ftrapv.
227 The code was computing A - B, where A and B are pointers, and B is
228 random garbage. This can lead to core dumps on platforms that
229 have special pointer registers, and it also leads to core dumps on
230 x86-64 when compiled with gcc -ftrapv. The fix is to compute
231 A - B only when B is initialized properly.
232 * coding.c (coding_set_source, coding_set_destination): Return void.
233 (coding_change_source, coding_change_destinations): New functions,
234 with the old behaviors of coding_set_source and coding_set_destination.
235 All callers that need an offset changed to use these new functions.
236
237 2012-05-26 Glenn Morris <rgm@gnu.org>
238
239 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
240
241 2012-05-26 Eli Zaretskii <eliz@gnu.org>
242
243 Extend mouse support on W32 text-mode console.
244 * xdisp.c (draw_row_with_mouse_face):
245 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
246
247 * w32console.c: Include window.h.
248 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
249 New functions.
250 (initialize_w32_display): Initialize mouse-highlight data.
251
252 * w32inevt.c: Include termchar.h and window.h.
253 (do_mouse_event): Support mouse-autoselect-window. When the mouse
254 moves, call note_mouse_highlight. If help_echo changed, call
255 gen_help_event to produce help-echo message in the echo area.
256 Call clear_mouse_face if mouse_face_hidden is set in the mouse
257 highlight info.
258
259 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
260
261 * lread.c (read1): Simplify slightly to avoid an overflow warning
262 with GCC 4.7.0 on x86-64.
263
264 2012-05-26 Eli Zaretskii <eliz@gnu.org>
265
266 * bidi.c (bidi_mirror_char): Revert last change: an int is
267 definitely wide enough here.
268
269 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
270
271 Fix integer width and related bugs (Bug#9874).
272 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
273 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
274 (string_bytes, check_sblock, allocate_string_data):
275 (compact_small_strings, Fmake_bool_vector, make_string)
276 (make_unibyte_string, make_multibyte_string)
277 (make_string_from_bytes, make_specified_string)
278 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
279 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
280 (mark_vectorlike):
281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
282 (allocate_pseudovector):
283 Use int, not EMACS_INT, where int is wide enough.
284 (inhibit_garbage_collection, Fgarbage_collect):
285 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
286 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
287 int might not be wide enough.
288 (bidi_cache_search, bidi_cache_find, bidi_init_it)
289 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
290 (bidi_at_paragraph_end, bidi_find_paragraph_start)
291 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
292 (bidi_level_of_next_char, bidi_move_to_visually_next):
293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
294 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
295 (Fkill_buffer, Fset_buffer_major_mode)
296 (advance_to_char_boundary, Fbuffer_swap_text)
297 (Fset_buffer_multibyte, overlays_at, overlays_in)
298 (overlay_touches_p, struct sortvec, record_overlay_string)
299 (overlay_strings, recenter_overlay_lists)
300 (adjust_overlays_for_insert, adjust_overlays_for_delete)
301 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
302 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
303 (Foverlay_recenter, last_overlay_modification_hooks_used)
304 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
305 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
306 (validate_region): Omit unnecessary test for b <= e,
307 since that's guaranteed by the previous test.
308 (adjust_overlays_for_delete): Avoid pos + length overflow.
309 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
310 (report_overlay_modification):
311 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
312 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
313 Omit pointer cast, which isn't needed anyway, and doesn't work
314 after the EMACS_INT -> ptrdiff_t change.
315 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
316 * buffer.h: Adjust decls to match defn changes elsewhere.
317 (struct buffer_text, struct buffer):
318 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
319 Use EMACS_INT, not int, where int might not be wide enough.
320 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
321 not int, to avoid needless 32-bit limit on 64-bit hosts.
322 (exec_byte_code): Use tighter memory-full test, one that checks
323 for alloca overflow. Don't compute the address of the object just
324 before an array, as that's not portable. Use EMACS_INT, not
325 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
326 * callint.c (Fcall_interactively):
327 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
328 * callproc.c (call_process_kill, Fcall_process):
329 Don't assume pid_t fits into an Emacs fixnum.
330 (call_process_cleanup, Fcall_process, child_setup):
331 Don't assume pid_t fits into int.
332 (call_process_cleanup, Fcall_process, delete_temp_file)
333 (Fcall_process_region):
334 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
335 (Fcall_process): Simplify handling of volatile integers.
336 Use int, not EMACS_INT, where int will do.
337 * casefiddle.c (casify_object, casify_region, operate_on_word)
338 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
339 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
340 (casify_object): Avoid integer overflow when overallocating buffer.
341 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
342 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
343 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
344 * category.h (CATEGORYP): Don't assume arg is nonnegative.
345 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
346 integers are now checked earlier. All uses replaced with XINT.
347 (ccl_driver):
348 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
349 For CCL_MapSingle, check that content and value are in int range.
350 (ccl_driver, Fregister_code_conversion_map):
351 Check that Vcode_version_map_vector is a vector.
352 (resolve_symbol_ccl_program): Check that vector header is in range.
353 Always copy the vector, so that we can check its contents reliably
354 now rather than having to recheck each instruction as it's being
355 executed. Check that vector words fit in 'int'.
356 (ccl_get_compiled_code, Fregister_ccl_program)
357 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
358 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
359 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
360 contents are in range.
361 (Fccl_execute_on_string): Check that status is in range.
362 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
363 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
364 Accept and return EMACS_INT, not int, because callers can pass values
365 out of 'int' range.
366 (c_string_width, strwidth, lisp_string_width, chars_in_text)
367 (multibyte_chars_in_text, parse_str_as_multibyte)
368 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
369 (str_as_unibyte, str_to_unibyte, string_count_byte8)
370 (string_escape_byte8, Fget_byte):
371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
372 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
373 avoid mishandling large integers.
374 * character.h: Adjust decls to match defn changes elsewhere.
375 * charset.c (load_charset_map_from_file, find_charsets_in_text)
376 (Ffind_charset_region):
377 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
378 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
379 (load_charset_map_from_vector, Fdefine_charset_internal):
380 Don't assume fixnum fits in int.
381 (load_charset_map_from_vector, Fmap_charset_chars):
382 Remove now-unnecessary CHECK_NATNUMs.
383 (Fdefine_charset_internal): Check ranges here, more carefully.
384 Don't rely on undefined behavior with signed left shift overflow.
385 Don't assume unsigned int fits into fixnum, or that fixnum fits
386 into unsigned int. Don't require max_code to be a valid fixnum;
387 that's not true for gb10830 4-byte on a 32-bit host. Allow
388 invalid_code to be a cons, for the same reason. Require code_offset
389 to be a character. Avoid int overflow if max_char is close
390 to INT_MAX.
391 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
392 this is intended anyway and avoids some undefined behavior.
393 (load_charset_map): Pass unsigned, not int, as 2nd arg of
394 INDEX_TO_CODE_POINT, as that's what it expects.
395 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
396 * charset.h (DECODE_CHAR): Return int, not unsigned;
397 this is what was intended anyway, and it avoids undefined behavior.
398 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
399 integer-overflow issues.
400 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
401 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
402 where the argument is EMACS_INT, and this behavior is not intended.
403 * chartab.c (Fmake_char_table, Fset_char_table_range)
404 (uniprop_get_decoder, uniprop_get_encoder):
405 Don't assume fixnum fits in int.
406 * cmds.c (move_point): New function, that does the gist of
407 Fforward_char and Fbackward_char, but does so while checking
408 for integer overflow more accurately.
409 (Fforward_char, Fbackward_char): Use it.
410 (Fforward_line, Fend_of_line, internal_self_insert)
411 (internal_self_insert):
412 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
413 Fix a FIXME, by checking for integer overflow when calculating
414 target_clm and actual_clm.
415 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
416 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
417 (ASSURE_DESTINATION, coding_alloc_by_realloc)
418 (coding_alloc_by_making_gap, alloc_destination)
419 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
420 (encode_coding_utf_16, detect_coding_emacs_mule)
421 (decode_coding_emacs_mule, encode_coding_emacs_mule)
422 (detect_coding_iso_2022, decode_coding_iso_2022)
423 (encode_invocation_designation, encode_designation_at_bol)
424 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
425 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
426 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
427 (encode_coding_ccl, encode_coding_raw_text)
428 (detect_coding_charset, decode_coding_charset)
429 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
430 (produce_composition, produce_charset, produce_annotation)
431 (decode_coding, handle_composition_annotation)
432 (handle_charset_annotation, consume_chars, decode_coding_gap)
433 (decode_coding_object, encode_coding_object, detect_coding_system)
434 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
435 (code_convert_region, code_convert_string)
436 (Fdefine_coding_system_internal)
437 (coding_set_source, coding_set_destination):
438 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
439 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
440 (Fdefine_coding_system_internal):
441 Don't assume fixnums fit in int.
442 (decode_coding_gap, decode_coding_object, encode_coding_object)
443 (Fread_coding_system, Fdetect_coding_region)
444 (Funencodable_char_position, Fcheck_coding_systems_region)
445 (get_translation, handle_composition_annotation, consume_chars):
446 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
447 (consume_chars): Rewrite to not calculate an address outside buffer.
448 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
449 Don't access memory outside of the args array.
450 (Fdefine_coding_system_internal): Check for charset-id overflow.
451 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
452 result of ENCODE_CHAR.
453 * coding.h: Adjust decls to match defn changes elsewhere.
454 (struct coding_system):
455 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
456 * composite.c (get_composition_id, find_composition)
457 (run_composition_function, update_compositions)
458 (compose_text, composition_gstring_put_cache)
459 (composition_gstring_p, composition_gstring_width)
460 (fill_gstring_header, fill_gstring_body, autocmp_chars)
461 (composition_compute_stop_pos, composition_reseat_it)
462 (composition_update_it, struct position_record)
463 (find_automatic_composition, composition_adjust_point)
464 (Fcomposition_get_gstring, Ffind_composition_internal):
465 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
466 (update_compositions):
467 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
468 * composite.h: Adjust decls to match defn changes elsewhere.
469 (struct composition):
470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
471 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
472 Do not attempt to compute the address of the object just before a
473 buffer; this is not portable.
474 (Faref, Faset):
475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
476 (Faset): Use int, not EMACS_INT, where int is wide enough.
477 (Fstring_to_number): Don't assume fixnums fit in int.
478 (Frem): Don't assume arg is nonnegative.
479 * dbusbind.c (xd_append_arg): Check for integers out of range.
480 (Fdbus_call_method): Don't overflow the timeout int.
481 (extract_signed, extract_unsigned): New functions.
482 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
483 (xd_get_connection_references): Return ptrdiff_t, not int.
484 All uses changed.
485 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
486 (xd_read_message_1):
487 Use int, not unsigned, where the dbus API uses int.
488 (Fdbus_message_internal): Don't overflow mtype.
489 (syms_of_dbusbind): Allocate right-sized buffer for integers.
490 * dired.c (directory_files_internal, file_name_completion, scmp)
491 (file_name_completion_stat):
492 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
493 (file_name_completion): Don't overflow matchcount.
494 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
495 * dispextern.h: Adjust decls to match defn changes elsewhere.
496 (struct text_pos, struct glyph, struct bidi_saved_info)
497 (struct bidi_string_data, struct bidi_it, struct composition_it)
498 (struct it):
499 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
500 (struct display_pos, struct composition_it, struct it):
501 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
502 * dispnew.c (increment_matrix_positions)
503 (increment_row_positions, mode_line_string)
504 (marginal_area_string):
505 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
506 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
507 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
508 (duration_to_sec_usec): New function, to check for overflow better.
509 (Fsleep_for, sit_for): Use it.
510 * doc.c (get_doc_string, store_function_docstring):
511 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
512 (get_doc_string, Fsnarf_documentation):
513 Use int, not EMACS_INT, where int is wide enough.
514 (get_doc_string):
515 Use SAFE_ALLOCA, not alloca.
516 Check for overflow when converting EMACS_INT to off_t.
517 * doprnt.c (doprnt):
518 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
519 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
520 Don't assume uid_t fits into fixnum.
521 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
522 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
523 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
524 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
525 (general_insert_function)
526 (Finsert_char, make_buffer_string, make_buffer_string_both)
527 (update_buffer_properties, Fbuffer_substring)
528 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
529 (Fsubst_char_in_region, check_translation)
530 (Ftranslate_region_internal, save_restriction_restore, Fformat)
531 (transpose_markers, Ftranspose_regions):
532 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
533 (clip_to_bounds): Move to lisp.h as an inline function).
534 (Fconstrain_to_field): Don't assume integers are nonnegative.
535 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
536 (Fsubst_char_in_region, Fsave_restriction):
537 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
538 (Femacs_pid): Don't assume pid_t fits into fixnum.
539 (lo_time): Use int, not EMACS_INT, when int suffices.
540 (lisp_time_argument): Check for usec out of range.
541 (Fencode_time): Don't assume fixnum fits in int.
542 (Fuser_login_name, Fuser_full_name): Signal an error
543 if a uid argument is out of range, rather than relying on
544 undefined behavior.
545 (Fformat_time_string): Remove now-unnecessary check.
546 lisp_time_argument checks for out-of-range usec now.
547 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
548 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
549 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
550 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
551 (init_cmdargs, Fdump_emacs):
552 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
553 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
554 the bottom (typically) 32 bits of the fixnum.
555 * eval.c (specpdl_size, call_debugger):
556 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
557 (when_entered_debugger, Fbacktrace_debug):
558 Don't assume fixnum can fit in int.
559 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
560 the object just before a buffer; this is not portable.
561 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
562 (grow_specpdl, unbind_to):
563 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
564 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
565 (grow_specpdl): Simplify allocation by using xpalloc.
566 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
567 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
568 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
569 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
570 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
571 (a_write, e_write):
572 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
573 (Fcopy_file, non_regular_nbytes, read_non_regular)
574 (Finsert_file_contents):
575 Use int, not EMACS_INT, where int is wide enough.
576 (READ_BUF_SIZE): Verify that it fits in int.
577 (Finsert_file_contents): Check that counts are in proper range,
578 rather than assuming fixnums fit into ptrdiff_t etc.
579 Don't assume fixnums fit into int.
580 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
581 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
582 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
583 (string_char_to_byte, string_byte_to_char)
584 (string_make_multibyte, string_to_multibyte)
585 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
586 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
587 (substring_both, Fdelete, internal_equal, Ffillarray)
588 (Fclear_string, mapcar1)
589 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
590 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
591 (larger_vector, make_hash_table, maybe_resize_hash_table)
592 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
593 (Fmaphash, secure_hash):
594 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
595 (concat): Check for string index and length overflow.
596 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
597 (Frequire):
598 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
599 (larger_vector): New API (vec, incr_min, size_max) replaces old
600 one (vec, new_size, init). This catches size overflow.
601 INIT was removed because it was always Qnil.
602 All callers changed.
603 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
604 the upper bound on a hash table index size.
605 (make_hash_table, maybe_resize_hash_table): Use it.
606 (secure_hash): Computer start_byte and end_byte only after
607 they're known to be in ptrdiff_t range.
608 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
609 (Ffont_get_glyphs, Ffont_at):
610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
611 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
612 (Flist_fonts, Fopen_font):
613 Don't assume fixnum can fit in int.
614 (check_gstring): Don't assume index can fit in int.
615 (font_match_p): Check that fixnum is a character, not a nonnegative
616 fixnum, since the later code needs to stuff it into an int.
617 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
618 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
619 conversion overflow issues.
620 (Fopen_font): Check for integer out of range.
621 (Ffont_get_glyphs): Don't assume index can fit in int.
622 * font.h: Adjust decls to match defn changes elsewhere.
623 * fontset.c (reorder_font_vector): Redo score calculation to avoid
624 integer overflow.
625 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
626 printmax_t, where ptrdiff_t is wide enough.
627 (Finternal_char_font):
628 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
629 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
630 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
631 (Fset_frame_position, x_set_frame_parameters)
632 (x_set_line_spacing, x_set_border_width)
633 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
634 Check that fixnums are in proper range for system types.
635 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
636 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
637 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
638 Use SAFE_ALLOCA_LISP, not alloca.
639 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
640 intptr_t is wide enough.
641 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
642 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
643 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
644 Check for fixnum out of range.
645 * ftfont.c (ftfont_list): Don't assume index fits in int.
646 Check that fixnums are in proper range for system types.
647 (ftfont_shape_by_flt):
648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
649 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
650 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
651 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
652 Check that fixnums are in proper range for system types.
653 * gnutls.h: Adjust decls to match defn changes elsewhere.
654 * gtkutil.c (xg_dialog_run):
655 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
656 (update_frame_tool_bar):
657 Check that fixnums are in proper range for system types.
658 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
659 (lookup_image): Check that fixnums are in range for system types.
660 * indent.c (last_known_column, last_known_column_point):
661 (current_column_bol_cache):
662 (skip_invisible, current_column, check_display_width):
663 (check_display_width, scan_for_column, current_column_1)
664 (Findent_to, Fcurrent_indentation, position_indentation)
665 (indented_beyond_p, Fmove_to_column, compute_motion):
666 (Fcompute_motion, Fvertical_motion):
667 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
668 (last_known_column_modified): Use EMACS_INT, not int.
669 (check_display_width):
670 (Fcompute_motion):
671 Check that fixnums and floats are in proper range for system types.
672 (compute_motion): Don't assume index or fixnum fits in int.
673 (compute_motion, Fcompute_motion):
674 Use int, not EMACS_INT, when it is wide enough.
675 (vmotion): Omit local var start_hpos that is always 0; that way
676 we don't need to worry about overflow in expressions involving it.
677 * indent.h: Adjust decls to match defn changes elsewhere.
678 (struct position):
679 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
680 Use int, not EMACS_INT, where int is wide enough.
681 Remove unused members ovstring_chars_done and tab_offset;
682 all uses removed.
683 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
684 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
685 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
686 (make_gap, copy_text, insert, insert_and_inherit)
687 (insert_before_markers, insert_before_markers_and_inherit)
688 (insert_1, count_combining_before, count_combining_after)
689 (insert_1_both, insert_from_string)
690 (insert_from_string_before_markers, insert_from_string_1)
691 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
692 (adjust_after_replace, adjust_after_insert, replace_range)
693 (replace_range_2, del_range, del_range_1, del_range_byte)
694 (del_range_both, del_range_2, modify_region)
695 (prepare_to_modify_buffer, signal_before_change)
696 (signal_after_change, Fcombine_after_change_execute):
697 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
698 * intervals.c (traverse_intervals, rotate_right, rotate_left)
699 (balance_an_interval, split_interval_right, split_interval_left)
700 (find_interval, next_interval, update_interval)
701 (adjust_intervals_for_insertion, delete_node, delete_interval)
702 (interval_deletion_adjustment, adjust_intervals_for_deletion)
703 (static_offset_intervals, offset_intervals)
704 (merge_interval_right, merge_interval_left, make_new_interval)
705 (graft_intervals_into_buffer, temp_set_point_both)
706 (temp_set_point, set_point, adjust_for_invis_intang)
707 (set_point_both, move_if_not_intangible, get_property_and_range)
708 (get_local_map, copy_intervals, copy_intervals_to_string)
709 (compare_string_intervals, set_intervals_multibyte_1):
710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
711 * intervals.h: Adjust decls to match defn changes elsewhere.
712 (struct interval):
713 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
714 * keyboard.c (this_command_key_count, this_single_command_key_start)
715 (before_command_key_count, before_command_echo_length, echo_now)
716 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
717 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
718 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
719 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
720 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
721 (last_non_minibuf_size, last_point_position, echo_truncate)
722 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
723 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
724 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
725 (stuff_buffered_input):
726 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
727 (last_auto_save, command_loop_1, read_char):
728 Use EMACS_INT, not int, to avoid integer overflow.
729 (record_char): Avoid overflow in total_keys computation.
730 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
731 * keyboard.h: Adjust decls to match defn changes elsewhere.
732 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
733 (Fkey_description, Fdescribe_vector, Flookup_key):
734 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
735 (click_position): New function, to check that positions are in range.
736 (Fcurrent_active_maps):
737 (describe_command):
738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
739 (Faccessible_keymaps, Fkey_description):
740 (preferred_sequence_p):
741 Don't assume fixnum can fit into int.
742 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
743 Check for integer overflow in size calculations.
744 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
745 avoid mishandling large integers.
746 * lisp.h: Adjust decls to match defn changes elsewhere.
747 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
748 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
749 (struct Lisp_Marker):
750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
751 (clip_to_bounds): Now an inline function, moved here from editfns.c.
752 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
753 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
754 All callers changed.
755 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
756 Assume the arg has valid form, since it always does.
757 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
758 unsigned integer system type.
759 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
760 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
761 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
762 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
763 (duration_to_sec_usec): New decl.
764 * lread.c (read_from_string_index, read_from_string_index_byte)
765 (read_from_string_limit, readchar, unreadchar, openp)
766 (read_internal_start, read1, oblookup):
767 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
768 (Fload, readevalloop, Feval_buffer, Feval_region):
769 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
770 (openp): Check for out-of-range argument to 'access'.
771 (read1): Use int, not EMACS_INT, where int is wide enough.
772 Don't assume fixnum fits into int.
773 Fix off-by-one error that can read outside a buffer.
774 (read_filtered_event): Use duration_to_sec_usec
775 to do proper overflow checking on durations.
776 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
777 in size calculation.
778 (Fexecute_kbd_macro):
779 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
780 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
781 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
782 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
783 (set_marker_both, set_marker_restricted_both, marker_position)
784 (marker_byte_position, Fbuffer_has_markers_at):
785 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
786 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
787 * menu.c (ensure_menu_items): Rename from grow_menu_items.
788 It now merely ensures that the menu is large enough, without
789 necessarily growing it, as this avoids some integer overflow issues.
790 All callers changed.
791 (keymap_panes, parse_single_submenu, Fx_popup_menu):
792 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
793 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
794 Use SAFE_ALLOCA_LISP, not alloca.
795 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
796 to EMACS_INT. Check that fixnums are in proper range for system types.
797 * minibuf.c (minibuf_prompt_width, string_to_object)
798 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
799 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
800 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
801 (get_minibuffer, read_minibuf_unwind):
802 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
803 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
804 this simplifies overflow checking. All callers changed.
805 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
806 (Ftest_completion):
807 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
808 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
809 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
810 Check that fixnums are in proper range for system types.
811 (Fx_create_frame, Fx_show_tip):
812 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
813 * nsfont.m (ns_findfonts, nsfont_list_family):
814 Don't assume fixnum fits in long.
815 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
816 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
817 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
818 wide enough.
819 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
820 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
821 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
822 (PRINTDECLARE, PRINTPREPARE):
823 (strout, print_string):
824 (print, print_preprocess, print_check_string_charset_prop)
825 (print_object):
826 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
827 (PRINTDECLARE):
828 (temp_output_buffer_setup, Fprin1_to_string, print_object):
829 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
830 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
831 (printchar, strout): Use xpalloc to catch size calculation overflow.
832 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
833 (print_error_message): Use SAFE_ALLOCA, not alloca.
834 (print_object): Use int, not EMACS_INT, where int is wide enough.
835 (print_depth, new_backquote_output, print_number_index):
836 Use ptrdiff_t, not int, where int might not be wide enough.
837 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
838 (Fset_process_window_size, Fformat_network_address)
839 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
840 (sigchld_handler):
841 Check that fixnums are in proper range for system types.
842 (Fsignal_process): Simplify by avoiding a goto.
843 Check for process-ids out of pid_t range rather than relying on
844 undefined behavior.
845 (process_tick, update_tick): Use EMACS_INT, not int.
846 (Fformat_network_address, read_process_output, send_process)
847 (Fprocess_send_region, status_notify):
848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
849 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
850 (wait_reading_process_output, read_process_output, exec_sentinel):
851 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
852 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
853 (Faccept_process_output): Use duration_to_sec_usec to do proper
854 overflow checking on durations.
855 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
856 Don't assume pid_t fits in int.
857 * process.h (struct Lisp_Process): Members tick and update_tick
858 are now of type EMACS_INT, not int.
859 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
860 configured --with-wide-int.
861 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
862 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
863 * search.c (looking_at_1, string_match_1):
864 (fast_string_match, fast_c_string_match_ignore_case)
865 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
866 (scan_newline, find_before_next_newline, search_command)
867 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
868 (set_search_regs, wordify):
869 (Freplace_match):
870 (Fmatch_data):
871 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
872 (string_match_1, search_buffer, set_search_regs):
873 (Fmatch_data):
874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
875 (wordify): Check for overflow in size calculation.
876 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
877 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
878 Check that fixnums are in proper range for system types.
879 * sound.c (struct sound_device)
880 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
882 (Fplay_sound_internal):
883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
884 * syntax.c (struct lisp_parse_state, find_start_modiff)
885 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
886 (Fparse_partial_sexp):
887 Don't assume fixnums can fit in int.
888 (struct lisp_parse_state, find_start_pos, find_start_value)
889 (find_start_value_byte, find_start_begv)
890 (update_syntax_table, char_quoted, dec_bytepos)
891 (find_defun_start, prev_char_comend_first, back_comment):
892 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
893 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
894 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
895 (Finternal_describe_syntax_value): Check that match_lisp is a
896 character, not an integer, since the code stuffs it into int.
897 (scan_words, scan_sexps_forward):
898 Check that fixnums are in proper range for system types.
899 (Fforward_word):
900 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
901 (scan_sexps_forward):
902 Use CHARACTERP, not INTEGERP, since the value must fit into int.
903 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
904 * syntax.h: Adjust decls to match defn changes elsewhere.
905 (struct gl_state_s):
906 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
907 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
908 MOST_POSITIVE_FIXNUM.
909 * sysdep.c (wait_for_termination_1, wait_for_termination)
910 (interruptible_wait_for_termination, mkdir):
911 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
912 (emacs_read, emacs_write):
913 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
914 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
915 and double all fit in int.
916 * term.c (set_tty_color_mode):
917 Check that fixnums are in proper range for system types.
918 * termhooks.h (struct input_event):
919 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
920 * textprop.c (validate_interval_range, interval_of)
921 (Fadd_text_properties, set_text_properties_1)
922 (Fremove_text_properties, Fremove_list_of_text_properties)
923 (Ftext_property_any, Ftext_property_not_all)
924 (copy_text_properties, text_property_list, extend_property_ranges)
925 (verify_interval_modification):
926 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
927 (Fnext_single_char_property_change)
928 (Fprevious_single_char_property_change):
929 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
930 (copy_text_properties):
931 Check for integer overflow in index calculation.
932 * undo.c (last_boundary_position, record_point, record_insert)
933 (record_delete, record_marker_adjustment, record_change)
934 (record_property_change):
935 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
936 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
937 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
938 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
939 (Fx_hide_tip, Fx_file_dialog):
940 * w32menu.c (set_frame_menubar):
941 Use ptrdiff_t, not int, for consistency with rest of code.
942 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
943 (select_window, Fdelete_other_windows_internal)
944 (window_scroll_pixel_based, window_scroll_line_based)
945 (Frecenter, Fset_window_configuration):
946 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
947 (Fset_window_hscroll, run_window_configuration_change_hook)
948 (set_window_buffer, temp_output_buffer_show, scroll_command)
949 (Fscroll_other_window, Frecenter):
950 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
951 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
952 Don't assume fixnum fits in int.
953 (Fset_window_scroll_bars):
954 Check that fixnums are in proper range for system types.
955 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
956 (string_pos, c_string_pos, number_of_chars, init_iterator)
957 (in_ellipses_for_invisible_text_p, init_from_display_pos)
958 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
959 (compute_display_string_end, handle_face_prop)
960 (face_before_or_after_it_pos, handle_invisible_prop)
961 (handle_display_prop, handle_display_spec, handle_single_display_spec)
962 (display_prop_intangible_p, string_buffer_position_lim)
963 (string_buffer_position, handle_composition_prop, load_overlay_strings)
964 (get_overlay_strings_1, get_overlay_strings)
965 (iterate_out_of_display_property, forward_to_next_line_start)
966 (back_to_previous_visible_line_start, reseat, reseat_to_string)
967 (get_next_display_element, set_iterator_to_next)
968 (get_visually_first_element, compute_stop_pos_backwards)
969 (handle_stop_backwards, next_element_from_buffer)
970 (move_it_in_display_line_to, move_it_in_display_line)
971 (move_it_to, move_it_vertically_backward, move_it_by_lines)
972 (add_to_log, message_dolog, message_log_check_duplicate)
973 (message2, message2_nolog, message3, message3_nolog
974 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
975 (current_message_1, truncate_echo_area, truncate_message_1)
976 (set_message, set_message_1, store_mode_line_noprop)
977 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
978 (text_outside_line_unchanged_p, check_point_in_composition)
979 (reconsider_clip_changes)
980 (redisplay_internal, set_cursor_from_row, try_scrolling)
981 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
982 (redisplay_window, find_last_unchanged_at_beg_row)
983 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
984 (trailing_whitespace_p, find_row_edges, display_line)
985 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
986 (display_mode_element, store_mode_line_string)
987 (pint2str, pint2hrstr, decode_mode_spec)
988 (display_count_lines, display_string, draw_glyphs)
989 (x_produce_glyphs, x_insert_glyphs)
990 (rows_from_pos_range, mouse_face_from_buffer_pos)
991 (fast_find_string_pos, mouse_face_from_string_pos)
992 (note_mode_line_or_margin_highlight, note_mouse_highlight):
993 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
994 (safe_call, init_from_display_pos, handle_fontified_prop)
995 (handle_single_display_spec, load_overlay_strings)
996 (with_echo_area_buffer, setup_echo_area_for_printing)
997 (display_echo_area, echo_area_display)
998 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
999 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1000 (redisplay_window, dump_glyph_row, display_mode_line)
1001 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1002 (handle_display_spec, display_prop_string_p):
1003 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1004 (handle_single_display_spec, build_desired_tool_bar_string)
1005 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1006 (get_specified_cursor_type):
1007 Check that fixnums are in proper range for system types.
1008 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1009 (Flookup_image_map):
1010 Don't assume fixnums fit in int.
1011 (compare_overlay_entries):
1012 Avoid mishandling comparisons due to subtraction overflow.
1013 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1014 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1015 (handle_tool_bar_click):
1016 Use int, not unsigned, since we prefer signed and the signedness
1017 doesn't matter here.
1018 (get_next_display_element, next_element_from_display_vector):
1019 Use int, not EMACS_INT, when int is wide enough.
1020 (start_hourglass): Use duration_to_sec_usec to do proper
1021 overflow checking on durations.
1022 * xfaces.c (Fbitmap_spec_p):
1023 Check that fixnums are in proper range for system types.
1024 (compare_fonts_by_sort_order):
1025 Avoid mishandling comparisons due to subtraction overflow.
1026 (Fx_family_fonts, realize_basic_faces):
1027 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1028 (Fx_family_fonts):
1029 Don't assume fixnum fits in int.
1030 Use SAFE_ALLOCA_LISP, not alloca.
1031 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1032 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1033 (face_at_buffer_position, face_for_overlay_string)
1034 (face_at_string_position):
1035 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1036 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1037 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1038 (Fx_show_tip):
1039 Check that fixnums are in proper range for system types.
1040 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1041 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1042 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1043 (Fx_change_window_property): Don't assume fixnums fit in int.
1044 * xfont.c (xfont_chars_supported):
1045 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1046 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1047 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1048 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1049 * xml.c (parse_region):
1050 * xrdb.c (magic_file_p):
1051 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1052 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1053 (x_get_local_selection, x_reply_selection_request)
1054 (x_handle_selection_request, wait_for_property_change):
1055 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1056 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1057 short is wide enough.
1058 (x_send_client_event): Don't assume fixnum fits in int.
1059 * xterm.c (x_x_to_emacs_modifiers):
1060 Don't assume EMACS_INT overflows nicely into int.
1061 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1062 may come from Lisp.
1063 (handle_one_xevent): NATNUMP can eval its arg twice.
1064 (x_connection_closed):
1065 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1066 * xterm.h: Adjust decls to match defn changes elsewhere.
1067 (struct scroll_bar): Use struct vectorlike_header
1068 rather than rolling our own approximation.
1069 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1070
1071 2012-05-25 Glenn Morris <rgm@gnu.org>
1072
1073 * lisp.mk (lisp): Update for more files being compiled now.
1074
1075 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1076
1077 * lread.c: Remove `read_pure' which makes no difference.
1078 (read_pure): Remove var.
1079 (unreadpure): Remove function.
1080 (readevalloop): Don't call read_list with -1 flag.
1081 (read1, read_vector): Don't test read_pure any more.
1082 (read_list): Simplify.
1083
1084 * fileio.c, character.h: Minor style tweaks.
1085
1086 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1087
1088 * window.h (clip_changed): Remove useless declaration.
1089
1090 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1091
1092 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1093 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1094
1095 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1096
1097 Remove src/m/*.
1098 This directory predates autoconf and is no longer needed nowadays.
1099 Move its few remaining bits of functionality to where they're needed.
1100 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1101 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1102 * m/template.h: Remove.
1103 * Makefile.in (M_FILE): Remove. All uses removed.
1104 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1105 * lisp.h (USE_LSB_TAG):
1106 * mem-limits.h (EXCEEDS_LISP_PTR):
1107 Use VAL_MAX, not VALBITS, in #if.
1108 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1109 (EMACS_UINT): Define unconditionally now.
1110 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1111 (BITS_PER_EMACS_INT): New constants, replacing
1112 what used to be in config.h, but not useful in #if.
1113 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1114 define them any more.
1115 (VAL_MAX): New macro.
1116 (VALMASK): Use it.
1117 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1118 BITS_PER_EMACS_INT, in #if.
1119 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1120 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1121 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1122 * s/ms-w32.h (DATA_START):
1123 Move here from removed file m/intel386.h.
1124 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1125 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1126
1127 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1128
1129 Assume C89 or later.
1130 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1131 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1132 (xrealloc):
1133 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1134 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1135 * textprop.c, tparam.c (NULL): Remove.
1136 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1137 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1138 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1139 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1140 * xterm.c (input_signal_count): Assume volatile works.
1141
1142 2012-05-21 Ken Brown <kbrown@cornell.edu>
1143
1144 * xgselect.c (xg_select): Fix first argument in call to 'select'
1145 (bug#11508).
1146
1147 2012-05-20 Ken Brown <kbrown@cornell.edu>
1148
1149 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1150 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1151
1152 2012-05-19 Ken Brown <kbrown@cornell.edu>
1153
1154 * xfns.c (x_in_use): Remove `static' qualifier.
1155 * xterm.h (x_in_use): Declare.
1156 * xgselect.c: Include xterm.h.
1157 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1158 and `display_arg' (bug#9754).
1159
1160 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1161
1162 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1163
1164 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1165 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1166
1167 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1168
1169 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1170
1171 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1172 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1173
1174 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1175 reference to image_cache->refcount.
1176 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1177
1178 2012-05-17 Juri Linkov <juri@jurta.org>
1179
1180 * search.c (Fword_search_regexp, Fword_search_backward)
1181 (Fword_search_forward, Fword_search_backward_lax)
1182 (Fword_search_forward_lax): Move functions to isearch.el
1183 (bug#10145, bug#11381).
1184
1185 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1186
1187 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1188
1189 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1190
1191 * lread.c (init_obarray): Declare Qt and Qnil as special.
1192
1193 2012-05-14 Glenn Morris <rgm@gnu.org>
1194
1195 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1196 Put "libexec" before "bin", for the sake of init_callproc_1.
1197
1198 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1199
1200 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1201
1202 * unexaix.c: Port to more-recent AIX compilers.
1203 (report_error, report_error_1, make_hdr, copy_sym)
1204 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1205 Make arguments const char *, not char *, to avoid violations of C
1206 standard and to fix some AIX warnings reported by Gilles Pion.
1207
1208 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1209
1210 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1211 already have overlays loaded.
1212 (handle_single_display_spec): Before returning without displaying
1213 fringe bitmap, synchronize the bidi iterator with the main display
1214 iterator, by calling iterate_out_of_display_property.
1215 (iterate_out_of_display_property): Detect buffer iteration by
1216 testing that it->string is a Lisp string.
1217 (get_next_display_element): When the current object is exhausted,
1218 and there's something on it->stack, call set_iterator_to_next to
1219 proceed with what's on the stack, instead of returning zero.
1220 (set_iterator_to_next): If called at the end of a Lisp string,
1221 proceed to consider_string_end without incrementing string
1222 position. Don't increment display vector index past the end of
1223 the display vector. (Bug#11417)
1224 (pos_visible_p): Don't report a position visible when move_it_to
1225 stopped at the last line of window, which happens to be scanned
1226 backwards by the bidi iteration. (Bug#11464)
1227
1228 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1229
1230 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1231 and right-margin display specs even if the spec is invalid or we
1232 are on a TTY, and thus unable to display on the fringes.
1233 That's because the text with the property will not be displayed anyway,
1234 so we need to signal to the caller that this is a "replacing"
1235 display spec. This fixes display when the spec is invalid or we
1236 are on a TTY.
1237
1238 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1239
1240 * unexaix.c (make_hdr): Fix typo in prototype.
1241 This bug broke the build on AIX. Problem reported by Gilles Pion.
1242
1243 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1244
1245 * keyboard.c (kbd_buffer_get_event): Read special events also in
1246 batch mode. (Bug#11415)
1247
1248 2012-05-12 Glenn Morris <rgm@gnu.org>
1249
1250 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1251
1252 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1253
1254 * lisp.mk (lisp): Add newcomment.elc.
1255
1256 2012-05-12 Glenn Morris <rgm@gnu.org>
1257
1258 * Makefile.in (MKDIR_P): New, set by configure.
1259 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1260
1261 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1262
1263 Remove unused function hourglass_started.
1264 * dispextern.h (hourglass_started):
1265 * w32fns.c (hourglass_started):
1266 * xdisp.c (hourglass_started): Remove.
1267
1268 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1269
1270 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1271 Update dependencies.
1272
1273 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1274
1275 * xgselect.c (xg_select): Put maxfds+1 into a var.
1276 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1277
1278 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1279
1280 2012-05-10 Dave Abrahams <dave@boostpro.com>
1281
1282 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1283 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1284
1285 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1286
1287 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1288 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1289 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1290 Initialize xd_registered_buses.
1291
1292 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1293
1294 Untag more efficiently if USE_LSB_TAG.
1295 This is based on a proposal by YAMAMOTO Mitsuharu in
1296 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1297 For an admittedly artificial (nth 8000 longlist) benchmark on
1298 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1299 Emacs's overall text size by 1%.
1300 * lisp.h (XUNTAG): New macro.
1301 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1302 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1303 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1304 * eval.c (Fautoload):
1305 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1306 * frame.h (XFRAME): Use XUNTAG.
1307
1308 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1309 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1310 Remove unportable assumptions about print widths of types like
1311 dbus_uint32_t.
1312 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1313 intptr_t when converting between pointer and integer, to avoid GCC
1314 warnings about wrong width.
1315
1316 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1317
1318 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1319 stack for each reader_thread, instead of defaulting to 8MB
1320 determined by the linker. This avoids failures in creating
1321 subprocesses on Windows 7, see the discussion in this thread:
1322 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1323
1324 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1325
1326 Fix up display of the *Minibuf-0* buffer in the mini window.
1327 * keyboard.c (read_char): Don't clear the echo area if there's no
1328 message to clear.
1329 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1330 contents of *Minibuf-0*) if there's no message displayed in its stead.
1331
1332 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1333
1334 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1335 batch mode.
1336
1337 2012-05-06 Chong Yidong <cyd@gnu.org>
1338
1339 * lisp.mk (lisp): Update.
1340
1341 2012-05-05 Jim Meyering <meyering@redhat.com>
1342
1343 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1344
1345 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1346
1347 * data.c (PUT_ERROR): New macro.
1348 (syms_of_data): Use it. Add new error type `user-error'.
1349 * undo.c (user_error): New function.
1350 (Fprimitive_undo): Use it.
1351 * print.c (print_error_message): Adjust print style for `user-error'.
1352 * keyboard.c (user_error): New function.
1353 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1354
1355 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1356
1357 Do not limit current-time-string to years 1000..9999.
1358 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1359 (Fcurrent_time_string): Support any year that is supported by the
1360 underlying localtime representation. Don't use asctime, as it
1361 has undefined behavior for years outside the range -999..9999.
1362
1363 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1364
1365 Fix race conditions involving setenv, gmtime, localtime, asctime.
1366 Without this fix, interrupts could mess up code that uses these
1367 nonreentrant functions, since setting TZ invalidates existing
1368 tm_zone or tzname values, and since most of these functions return
1369 pointers to static storage.
1370 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1371 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1372 Grow the critical sections to include not just invoking
1373 localtime/gmtime, but also accessing these functions' results
1374 including their tm_zone values if any, and any related TZ setting.
1375 (format_time_string): Last arg is now struct tm *, not struct tm **,
1376 so that the struct tm is saved in the critical section.
1377 All callers changed. Simplify allocation of initial buffer, partly
1378 motivated by the fact that memory allocation needs to be outside
1379 the critical section.
1380
1381 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1382
1383 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1384 with RESET_INTERVAL.
1385
1386 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1387 Remove duplicated buffer name initialization.
1388
1389 2012-05-02 Jim Meyering <jim@meyering.net>
1390
1391 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1392
1393 * xfns.c (x_window): Use xstrdup (Bug#11375).
1394
1395 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1396
1397 * xdisp.c (pos_visible_p): If already at a newline from the
1398 display string before the 'while' loop, don't walk back the glyphs
1399 from it3.glyph_row. Solves assertion violation when the display
1400 string begins with a newline (egg.el). (Bug#11367)
1401
1402 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1403
1404 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1405 Move to simple.el.
1406
1407 2012-05-01 Glenn Morris <rgm@gnu.org>
1408
1409 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1410 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1411 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1412 All were removed before 23.1.
1413
1414 * dispnew.c: Remove HAVE_LIBNCURSES test;
1415 it is always true on relevant platforms.
1416
1417 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1418 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1419
1420 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1421
1422 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1423
1424 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1425 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1426 Remove.
1427
1428 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1429
1430 Do not avoid creating empty evaporating overlays (Bug#9642).
1431 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1432 That is, do not delete an evaporating overlay if it becomes
1433 empty after its bounds are adjusted to fit within its buffer.
1434 This fix caused other problems, and I'm reverting it until we get
1435 to the bottom of them.
1436
1437 2012-04-27 Chong Yidong <cyd@gnu.org>
1438
1439 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1440
1441 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1442
1443 * xdisp.c (pos_visible_p): If the window start position is beyond
1444 ZV, start the display from buffer beginning. Prevents assertion
1445 violation in init_iterator when the minibuffer window is scrolled
1446 via the scroll bar.
1447
1448 * window.c (window_scroll_pixel_based): Likewise.
1449
1450 2012-04-27 Chong Yidong <cyd@gnu.org>
1451
1452 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1453
1454 2012-04-27 Glenn Morris <rgm@gnu.org>
1455
1456 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1457 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1458
1459 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1460
1461 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1462 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1463
1464 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1465
1466 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1467 display element, check also the underlying string or buffer
1468 character. (Bug#11341)
1469
1470 * w32menu.c: Include w32heap.h.
1471 (add_menu_item): If the call to AppendMenuW (via
1472 unicode_append_menu) fails, disable Unicode menus only if we are
1473 running on Windows 9X/Me.
1474
1475 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1476
1477 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1478 (xgetint): Add missing shift for LSB tags.
1479
1480 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1481
1482 * keyboard.c (read_char): Don't wipe echo area for select window
1483 events: These might get delayed via `mouse-autoselect-window'
1484 (Bug#11304).
1485
1486 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1487
1488 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1489 manipulation of :loaded-from data.
1490
1491 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1492
1493 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1494 now a cons (bug#11311).
1495
1496 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1497
1498 Do not create empty overlays with the evaporate property (Bug#9642).
1499 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1500 if it becomes empty after its bounds are adjusted to fit within
1501 its buffer. Without this fix, in a nonempty buffer (let ((o
1502 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1503 yields an empty overlay that has the evaporate property, which is
1504 not supposed to happen.
1505
1506 Fix minor GTK3 problems found by static checking.
1507 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1508 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1509 (struct _EmacsFixedClass, emacs_fixed_get_type):
1510 Move decls here from emacsgtkfixed.h, since they needn't be public.
1511 (emacs_fixed_get_type): Now static.
1512 (emacs_fixed_class_init): Omit unused local.
1513 (emacs_fixed_child_type): Remove; unused.
1514 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1515 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1516 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1517 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1518 (EMACS_FIXED_GET_CLASS): Remove; unused.
1519 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1520
1521 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1522 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1523
1524 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1525
1526 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1527 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1528 (__malloc_size_t, __malloc_ptrdiff_t):
1529 Remove. All uses removed, replaced by the definiens if needed,
1530 since we can assume C89 or better now.
1531 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1532 (protect_malloc_state, align, get_contiguous_space)
1533 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1534 (malloc_atfork_handler_child, malloc_enable_thread)
1535 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1536 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1537 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1538 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1539 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1540 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1541 Define using prototypes, not old style.
1542 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1543 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1544 (align): Don't assume that signed integer overflow wraps around.
1545 Omit unused local var.
1546 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1547 (_free_internal_nolock, memalign, mallochook, reallochook):
1548 Omit no-longer-needed casts.
1549 (valloc): Use getpagesize, not __getpagesize.
1550 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1551 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1552
1553 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1554
1555 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1556
1557 Move functions from C to Lisp. Make non-blocking method calls
1558 the default. Implement further D-Bus standard interfaces.
1559
1560 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1561 (QCdbus_request_name_allow_replacement)
1562 (QCdbus_request_name_replace_existing)
1563 (QCdbus_request_name_do_not_queue)
1564 (QCdbus_request_name_reply_primary_owner)
1565 (QCdbus_request_name_reply_in_queue)
1566 (QCdbus_request_name_reply_exists)
1567 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1568 (QCdbus_registered_serial, QCdbus_registered_method)
1569 (QCdbus_registered_signal): New Lisp objects.
1570 (XD_DEBUG_MESSAGE): Use sizeof.
1571 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1572 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1573 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1574 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1575 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1576 (xd_signature, xd_append_arg): Allow float for integer types.
1577 (xd_get_connection_references): New function.
1578 (xd_get_connection_address): Rename from xd_initialize.
1579 Return cached address.
1580 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1581 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1582 level.
1583 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1584 Return number of refcounts.
1585 (Fdbus_get_unique_name): Make stronger parameter check.
1586 (Fdbus_message_internal): New defun.
1587 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1588 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1589 (Fdbus_send_signal, Fdbus_register_service)
1590 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1591 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1592 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1593 (Vdbus_compiled_version, Vdbus_runtime_version)
1594 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1595 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1596 (Vdbus_message_type_signal): New defvars.
1597 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1598 Adapt docstring.
1599
1600 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1601
1602 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1603 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1604 Do not assume ptrdiff_t is the same width as 'int'.
1605
1606 * alloc.c: Handle unusual debugging option combinations.
1607 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1608 since the two debugging options are incompatible.
1609 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1610 is defined.
1611 (mem_init, mem_insert, mem_insert_fixup):
1612 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1613 (NEED_MEM_INSERT): Remove; no longer needed.
1614
1615 2012-04-22 Leo Liu <sdl.web@gmail.com>
1616
1617 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1618
1619 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1620
1621 * sysdep.c [__FreeBSD__]: Minor cleanups.
1622 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1623 Use Emacs indenting style more consistently. Avoid some casts.
1624 Use 'double' consistently rather than mixing 'float' and 'double'.
1625
1626 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1627
1628 * sysdep.c (list_system_processes, system_process_attributes):
1629 Add implementation for FreeBSD (Bug#5243).
1630
1631 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1632
1633 * lisp.mk (lisp): Update.
1634
1635 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1636
1637 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1638 It is never used otherwise.
1639
1640 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1641
1642 * print.c (print_preprocess): Only check print_depth if print-circle
1643 is nil.
1644 (print_object): Check for cycles even when print-circle is nil and
1645 print-gensym is t, but only check print_depth if print-circle is nil.
1646
1647 2012-04-20 Chong Yidong <cyd@gnu.org>
1648
1649 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1650 set the status to "failed" and ensure that sentinel is run.
1651
1652 2012-04-20 Glenn Morris <rgm@gnu.org>
1653
1654 * process.c (Fset_process_inherit_coding_system_flag)
1655 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1656 (Fmake_network_process, Fmake_serial_process): Doc fix.
1657
1658 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1659
1660 * xdisp.c (string_buffer_position_lim): Limit starting position to
1661 BEGV.
1662 (set_cursor_from_row): If called for a mode-line or header-line
1663 row, return zero immediately.
1664 (try_cursor_movement): If inside continuation line, don't back up
1665 farther than the first row after the header line, if any.
1666 Don't consider the header-line row as "partially visible", even if
1667 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1668
1669 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1670
1671 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1672 (bug#11238).
1673
1674 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1675 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1676
1677 configure: new option --enable-gcc-warnings (Bug#11207)
1678 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1679 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1680 (ALL_CFLAGS): Use new macros rather than old.
1681 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1682 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1683 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1684 -Wunused-result, -Wunused-variable. This should go away once
1685 the Emacs and Gnulib regex code is merged.
1686 (xmalloc, xrealloc): Now static.
1687
1688 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1689
1690 * dired.c (Fsystem_groups): Remove unused local.
1691
1692 2012-04-17 Glenn Morris <rgm@gnu.org>
1693
1694 * dired.c (Fsystem_users): Doc fix.
1695
1696 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1697
1698 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1699 (syms_of_dired): Add them.
1700
1701 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1702
1703 Fix minor alloc.c problems found by static checking.
1704 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1705 New extern decls, to avoid calling undeclared functions.
1706 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1707 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1708 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1709 (NEED_MEM_INSERT): New macro.
1710 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1711 Remove one incorrect comment and fix another.
1712
1713 Fix minor ralloc.c problems found by static checking.
1714 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1715 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1716 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1717 (r_alloc_sbrk): Now static.
1718
1719 Improve ralloc.c interface checking.
1720 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1721 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1722 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1723 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1724 [REL_ALLOC]: ... to here, to check interface.
1725 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1726 Remove decls. This fixes an "It stinks!".
1727
1728 * alloc.c (which_symbols): Fix alignment issue / type clash.
1729
1730 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1731
1732 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1733 (struct Lisp_Misc_Any): Likewise.
1734 (struct Lisp_Free): Likewise.
1735 * alloc.c (union aligned_Lisp_Symbol): Define.
1736 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1737 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1738 (union aligned_Lisp_Misc): Define.
1739 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1740 aligned_Lisp_Misc instead of union Lisp_Misc.
1741 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1742
1743 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1744
1745 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1746 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1747 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1748 * s/netbsd.h, s/sol2-6.h:
1749 Remove definition of GC_MARK_STACK, since the default now works.
1750 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1751 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1752 no longer the default.
1753 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1754
1755 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1756
1757 * lread.c (lisp_file_lexically_bound_p):
1758 Fix hang at ";-*-\n" (bug#11238).
1759
1760 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1761
1762 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1763 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1764
1765 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1766
1767 * nsterm.m (constrainFrameRect): Always constrain when there is only
1768 one screen (Bug#10962).
1769
1770 2012-04-13 Ken Brown <kbrown@cornell.edu>
1771
1772 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1773
1774 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1775
1776 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1777
1778 2012-04-11 Daniel Colascione <dancol@dancol.org>
1779
1780 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1781 against is gone. It's better to use vfork now so that when Cygwin
1782 gains a new, working vfork, we use it automatically (bug#10398).
1783
1784 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1785
1786 * window.c (save_window_save): Obey window-point-insertion-type.
1787
1788 2012-04-11 Glenn Morris <rgm@gnu.org>
1789
1790 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1791
1792 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1793
1794 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1795
1796 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1797
1798 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1799 (force_quit_count): New var.
1800 (handle_interrupt): Use it.
1801
1802 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1803
1804 * w32.c (w32_delayed_load): Record the full path of the library
1805 being loaded (bug#10424).
1806
1807 2012-04-09 Glenn Morris <rgm@gnu.org>
1808
1809 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1810 not just in the obarray, before snarfing them. (Bug#11036)
1811
1812 * Makefile.in ($(leimdir)/leim-list.el):
1813 Pass EMACS rather than BUILT_EMACS.
1814
1815 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1816
1817 * process.c (make_process):
1818 * process.h: Add integer `gnutls_handshakes_tried' member to
1819 process struct.
1820
1821 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1822 Add convenience `GNUTLS_LOG2i' macro.
1823
1824 * gnutls.c (gnutls_log_function2i): Convenience log function.
1825 (emacs_gnutls_read): Use new log functions,
1826 `gnutls_handshakes_tried' process member, and
1827 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1828 attempts per process (connection).
1829
1830 2012-04-09 Chong Yidong <cyd@gnu.org>
1831
1832 * eval.c (Fuser_variable_p, user_variable_p_eh)
1833 (lisp_indirect_variable): Functions deleted.
1834 (Fdefvar): Caller changed.
1835
1836 * callint.c (Finteractive, Fcall_interactively):
1837 * minibuf.c (Fread_variable): Callers changed.
1838
1839 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1840
1841 * xdisp.c (set_cursor_from_row): If the display string appears in
1842 the buffer at position that is closer to point than the position
1843 after the display string, display the cursor on the first glyph of
1844 the display string. Fixes cursor display when a 'display' text
1845 property immediately follows invisible text. (Bug#11094)
1846
1847 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1848
1849 composite.c: use 'double' consistently
1850 * composite.c (get_composition_id): Use 'double' consistently
1851 instead of converting 'float' to 'double' and vice versa; this is
1852 easier to understand and avoids a GCC warning.
1853
1854 2012-04-09 Glenn Morris <rgm@gnu.org>
1855
1856 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1857 preparation for dumping it with emacs. (Bug#4789)
1858 (leimdir): New variable.
1859 ($(leimdir)/leim-list.el): New rule.
1860 (emacs$(EXEEXT)): Depend on leim-list.el.
1861
1862 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1863 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1864 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1865
1866 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1867
1868 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1869 proper alignment.
1870
1871 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1872
1873 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1874 Remove unused local variable.
1875
1876 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1877
1878 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1879 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1880 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1881 objects, as mark_maybe_pointer will catch them otherwise.
1882 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1883 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1884
1885 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1886
1887 Fix typo that broke non-Windows builds.
1888 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1889
1890 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1891
1892 Support building on MS-Windows with libxml2.
1893
1894 * makefile.w32-in (OBJ2): Add xml.$(O).
1895 (GLOBAL_SOURCES): Add xml.c.
1896 ($(BLD)/xml.$(O)): New dependency list.
1897
1898 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1899 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1900 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1901 [!WINDOWSNT]: New macros.
1902 (init_libxml2_functions, libxml2_loaded_p): New functions.
1903 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1904 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1905 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1906 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1907 linked in).
1908 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1909 Call init_libxml2_functions before calling libxml2 functions.
1910 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1911
1912 * emacs.c: Don't include libxml/parser.h.
1913 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1914 xmlCleanupParser directly.
1915
1916 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1917
1918 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1919
1920 * indent.c (Fvertical_motion): If there is a display string at
1921 point, use it.vpos to compute how many lines to backtrack after
1922 move_it_to point. (Bug#11133)
1923
1924 2012-04-06 Eli Zaretskii <eliz@gnu.org>
1925
1926 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1927 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1928 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1929 macros related to unification of CJK characters. For the details,
1930 see the discussion following the message here:
1931 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1932
1933 2012-04-04 Chong Yidong <cyd@gnu.org>
1934
1935 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1936
1937 2012-04-01 Eli Zaretskii <eliz@gnu.org>
1938
1939 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1940 instead of alloca. (Bug#11138)
1941
1942 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1943
1944 * w32menu.c (is_simple_dialog): Properly check lisp types.
1945 (Bug#11141)
1946
1947 2012-03-31 Eli Zaretskii <eliz@gnu.org>
1948
1949 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1950 position we get to after a call to move_it_to fails the
1951 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1952 only if we wind up in a string from display property. (Bug#11063)
1953
1954 * window.c (Fdelete_other_windows_internal): Invalidate the row
1955 and column information about mouse highlight, so that redisplay
1956 restores it after reallocating the glyph matrices. (Bug#7464)
1957
1958 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1959 string comes from a `display' text property, use the buffer
1960 position of that property as if we actually saw that position in
1961 the row's glyphs.
1962 (move_it_by_lines): Remove the assertion that
1963 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1964 violated when there's a before-string at the beginning of a line.
1965 (Bug#11063)
1966
1967 2012-03-30 Eli Zaretskii <eliz@gnu.org>
1968
1969 * xdisp.c (append_space_for_newline): If the default face was
1970 remapped, use the remapped face for the appended newline.
1971 (extend_face_to_end_of_line): Use the remapped default face for
1972 extending the face to the end of the line.
1973 (display_line): Call extend_face_to_end_of_line when the default
1974 face was remapped. (Bug#11068)
1975
1976 2012-03-29 Eli Zaretskii <eliz@gnu.org>
1977
1978 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1979
1980 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1981
1982 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1983
1984 2012-03-27 Glenn Morris <rgm@gnu.org>
1985
1986 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1987 Doc fixes.
1988
1989 2012-03-26 Kenichi Handa <handa@m17n.org>
1990
1991 * dispextern.h (struct glyph): Fix previous change. Change the
1992 bit length of glyphless.ch to 25 (Bug#11082).
1993
1994 2012-03-26 Chong Yidong <cyd@gnu.org>
1995
1996 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1997 (command_loop_1): Use it; inhibit selection update for
1998 handle-select-window too (Bug#8996).
1999
2000 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2001
2002 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2003
2004 2012-03-25 Kenichi Handa <handa@m17n.org>
2005
2006 * dispextern.h (struct glyph): Change the bit length of
2007 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2008
2009 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2010
2011 * s/ms-w32.h (tzname): Include time.h before redirecting to
2012 _tzname. Fixes the MSVC build. (Bug#9960)
2013
2014 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2015
2016 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2017 characters.
2018
2019 * xterm.c (XTread_socket): Only modify handling_signal if
2020 !SYNC_INPUT. (Bug#11080)
2021
2022 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2023
2024 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2025 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2026 when fetching a multibyte character consumes more bytes than
2027 CHAR_BYTES returns, due to unification of CJK characters in
2028 string_char. (Bug#11073)
2029
2030 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2031
2032 * process.c (wait_reading_process_output): Handle pty disconnect
2033 by refraining from sending oneself a SIGCHLD (bug#10933).
2034
2035 2012-03-22 Chong Yidong <cyd@gnu.org>
2036
2037 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2038
2039 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2040 Mark string as coming from a prefix property.
2041 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2042 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2043
2044 2012-03-21 Chong Yidong <cyd@gnu.org>
2045
2046 * xfaces.c (Vface_remapping_alist): Doc fix.
2047
2048 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2049
2050 * w32proc.c (Fw32_set_console_codepage)
2051 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2052 Doc fixes.
2053
2054 2012-03-20 Chong Yidong <cyd@gnu.org>
2055
2056 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2057 to reflect default non-nil value of redisplay-dont-pause.
2058
2059 2012-03-19 Kenichi Handa <handa@m17n.org>
2060
2061 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2062 it fit in a valid range (Bug#11003).
2063
2064 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2065
2066 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2067 that is not from display property, accept the row as a "cursor
2068 row" if one of the string's character has a non-nil `cursor'
2069 property. Fixes cursor positioning when there are newlines in
2070 overlay strings, e.g. in icomplete.el. (Bug#11035)
2071
2072 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2073
2074 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2075
2076 2012-03-12 Chong Yidong <cyd@gnu.org>
2077
2078 * eval.c (inhibit_lisp_code): Rename from
2079 inhibit_window_configuration_change_hook; move from window.c.
2080
2081 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2082 * window.c (run_window_configuration_change_hook)
2083 (syms_of_window): Callers changed.
2084
2085 2012-03-11 Chong Yidong <cyd@gnu.org>
2086
2087 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2088
2089 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2090
2091 2012-03-10 Chong Yidong <cyd@gnu.org>
2092
2093 * frame.c (other_visible_frames): Don't assume the selected frame
2094 is visible (Bug#10955).
2095
2096 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2097
2098 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2099
2100 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2101
2102 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2103 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2104 zero (Bug#10954).
2105
2106 2012-03-03 Glenn Morris <rgm@gnu.org>
2107
2108 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2109
2110 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2111
2112 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2113 position past the first glyph_row that ends at ZV. (Bug#10902)
2114 (redisplay_window, next_element_from_string): Fix typos in
2115 comments.
2116 (redisplay_window): Pass to move_it_vertically the margin in
2117 pixels, not in screen lines.
2118
2119 2012-03-02 Glenn Morris <rgm@gnu.org>
2120
2121 * buffer.c (buffer-list-update-hook): Doc fix.
2122
2123 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2124
2125 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2126 push_it before setting up the iterator for the first overlay
2127 string, even if we have an empty string loaded.
2128 (next_overlay_string): If there's an empty string on the iterator
2129 stack, pop the stack. (Bug#10903)
2130
2131 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2132
2133 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2134 Suggested by Stefan Monnier in
2135 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2136 * alloc.c (widen_to_Lisp_Object): New static function.
2137 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2138 and widening them to Lisp_Objects. This would work even if
2139 USE_LSB_TAG is defined and wide integers are used, which might
2140 happen in a future version of Emacs.
2141
2142 2012-02-25 Chong Yidong <cyd@gnu.org>
2143
2144 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2145 Doc fix.
2146
2147 * xselect.c (Fx_selection_exists_p): Doc fix.
2148 (x_clipboard_manager_save_all): Print an informative message
2149 before saving to clipboard manager.
2150
2151 2012-02-24 Chong Yidong <cyd@gnu.org>
2152
2153 * keyboard.c (process_special_events): Handle all X selection
2154 requests in kbd_buffer, not just the next one (Bug#8869).
2155
2156 2012-02-23 Chong Yidong <cyd@gnu.org>
2157
2158 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2159 call when setting menu-bar-lines and tool-bar-lines parameters.
2160 (unwind_create_frame_1): New helper function.
2161
2162 * window.c (inhibit_window_configuration_change_hook): New var.
2163 (run_window_configuration_change_hook): Obey it.
2164 (syms_of_window): Initialize it.
2165
2166 2012-02-22 Chong Yidong <cyd@gnu.org>
2167
2168 * xterm.c (x_draw_image_relief): Add missing type check for
2169 Vtool_bar_button_margin (Bug#10743).
2170
2171 2012-02-21 Chong Yidong <cyd@gnu.org>
2172
2173 * fileio.c (Vfile_name_handler_alist): Doc fix.
2174
2175 * buffer.c (Fget_file_buffer): Protect against invalid file
2176 handler return value.
2177
2178 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2179
2180 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2181 when computing $valmask.
2182
2183 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2184 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2185 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2186 It's useless in that case, and it can cause problems on hosts
2187 that allocate halves of EMACS_INT values separately.
2188 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2189 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2190 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2191 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2192 it avoids undefined behavior on hosts where shifting right by more
2193 than the word width has undefined behavior.
2194
2195 2012-02-19 Chong Yidong <cyd@gnu.org>
2196
2197 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2198 (Funhandled_file_name_directory, Ffile_name_as_directory)
2199 (Fdirectory_file_name, Fexpand_file_name)
2200 (Fsubstitute_in_file_name): Protect against invalid file handler
2201 return values (Bug#10845).
2202
2203 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2204
2205 * .gdbinit (pitx): Fix incorrect references to fields of the
2206 iterator stack.
2207
2208 2012-02-17 Chong Yidong <cyd@gnu.org>
2209
2210 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2211
2212 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2213
2214 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2215 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2216
2217 2012-02-15 Chong Yidong <cyd@gnu.org>
2218
2219 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2220 marked as special. Also, starting docstrings with * is obsolete.
2221
2222 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2223
2224 * gnutls.c (emacs_gnutls_write): Fix last change.
2225
2226 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2227
2228 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2229 send_process.
2230
2231 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2232
2233 * keymap.c (Fsingle_key_description): Handle char ranges.
2234
2235 2012-02-12 Chong Yidong <cyd@gnu.org>
2236
2237 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2238 as that creates a dangerous corner case.
2239
2240 * window.c (Fdelete_window_internal): Invalidate the mouse
2241 highlight (Bug#9904).
2242
2243 2012-02-12 Glenn Morris <rgm@gnu.org>
2244
2245 * xselect.c (Fx_own_selection_internal)
2246 (Fx_get_selection_internal, Fx_disown_selection_internal)
2247 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2248 * nsselect.m (Fx_own_selection_internal)
2249 (Fx_disown_selection_internal, Fx_selection_exists_p)
2250 (Fx_selection_owner_p, Fx_get_selection_internal):
2251 Sync docs and argument specs with the xselect.c versions.
2252
2253 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2254
2255 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2256
2257 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2258
2259 * w32select.c (Fx_selection_exists_p): Sync doc string and
2260 argument list with xselect.c. (Bug#10783)
2261
2262 * w16select.c (Fx_selection_exists_p): Sync doc string and
2263 argument list with xselect.c. (Bug#10783)
2264
2265 2012-02-10 Glenn Morris <rgm@gnu.org>
2266
2267 * fns.c (Fsecure_hash): Doc fix.
2268
2269 2012-02-09 Kenichi Handa <handa@m17n.org>
2270
2271 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2272
2273 2012-02-07 Chong Yidong <cyd@gnu.org>
2274
2275 * buffer.c (Fbuffer_local_variables)
2276 (buffer_lisp_local_variables): Handle unbound vars correctly;
2277 don't let Qunbound leak into Lisp.
2278
2279 2012-02-07 Glenn Morris <rgm@gnu.org>
2280
2281 * image.c (Fimagemagick_types): Doc fix.
2282
2283 * image.c (imagemagick-render-type): Change it from a lisp object
2284 to an integer. Move the doc here from the lisp manual.
2285 Treat all values not equal to 0 the same.
2286
2287 2012-02-06 Chong Yidong <cyd@gnu.org>
2288
2289 * doc.c (store_function_docstring): Avoid applying docstring of
2290 alias to base function (Bug#2603).
2291
2292 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2293
2294 * .gdbinit (pp1, pv1): Remove redundant defines.
2295 (pr): Use pp.
2296
2297 2012-02-04 Chong Yidong <cyd@gnu.org>
2298
2299 * nsterm.m: Declare a global (Bug#10694).
2300
2301 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2302
2303 * w32.c (get_emacs_configuration_options):
2304 Include --enable-checking, if specified, in the return value.
2305
2306 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2307
2308 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2309 after rounding frame sizes. (Bug#9723)
2310
2311 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2312
2313 * keyboard.c (adjust_point_for_property): Don't position point
2314 before BEGV. (Bug#10696)
2315
2316 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2317
2318 Handle overflow when computing char display width (Bug#9496).
2319 * character.c (char_width): Return EMACS_INT, not int.
2320 (char_width, c_string_width): Check for overflow when
2321 computing the width; this is possible now that individual
2322 characters can have unbounded width. Problem introduced
2323 by merge from Emacs 23 on 2012-01-19.
2324
2325 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2326
2327 * dbusbind.c (Fdbus_register_method): Mention the return value
2328 :ignore in the docstring.
2329
2330 2012-02-02 Glenn Morris <rgm@gnu.org>
2331
2332 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2333
2334 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2335 Unconditionally set to t. (Bug#10673)
2336 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2337 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2338 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2339
2340 2012-02-02 Kenichi Handa <handa@m17n.org>
2341
2342 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2343 0, do not call append_composite_glyph.
2344
2345 2012-02-02 Kenichi Handa <handa@m17n.org>
2346
2347 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2348 NULL (Bug#6988).
2349 (x_produce_glyphs): If the component of a composition is a null
2350 string, set it->pixel_width to 1 to avoid zero-width glyph.
2351
2352 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2353
2354 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2355 first 2 arguments are identical. This makes inserting large
2356 output from a subprocess an order of magnitude faster on
2357 MS-Windows, where all sbrk'ed memory is always contiguous.
2358
2359 2012-01-31 Glenn Morris <rgm@gnu.org>
2360
2361 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2362 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2363 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2364
2365 2012-01-29 Glenn Morris <rgm@gnu.org>
2366
2367 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2368
2369 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2370
2371 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2372
2373 2012-01-28 Chong Yidong <cyd@gnu.org>
2374
2375 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2376
2377 2012-01-26 Chong Yidong <cyd@gnu.org>
2378
2379 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2380
2381 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2382 repeat counts (Bug#10507).
2383
2384 2012-01-26 Glenn Morris <rgm@gnu.org>
2385
2386 * lread.c (syms_of_lread): Doc fix.
2387
2388 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2389
2390 * coding.c (encode_designation_at_bol): Change return value to
2391 EMACS_INT.
2392
2393 2012-01-25 Chong Yidong <cyd@gnu.org>
2394
2395 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2396
2397 2012-01-21 Chong Yidong <cyd@gnu.org>
2398
2399 * floatfns.c (Fcopysign): Make the second argument non-optional,
2400 since nil is not allowed anyway.
2401
2402 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2403
2404 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2405 (send_process): Likewise.
2406
2407 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2408
2409 * window.c (save_window_save, Fcurrent_window_configuration)
2410 (Vwindow_persistent_parameters): Do not use Qstate.
2411 Rewrite doc-strings.
2412
2413 2012-01-19 Kenichi Handa <handa@m17n.org>
2414
2415 * character.c (char_width): New function.
2416 (Fchar_width, c_string_width, lisp_string_width):
2417 Use char_width (Bug#9496).
2418
2419 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2420
2421 * window.c (Vwindow_persistent_parameters): New variable.
2422 (Fset_window_configuration, save_window_save): Handle persistent
2423 window parameters.
2424
2425 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2426
2427 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2428 thrashing the stack of the thread. (Bug#9087)
2429
2430 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2431
2432 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2433
2434 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2435
2436 * xdisp.c (rows_from_pos_range): Handle the case where the
2437 highlight ends on a newline. (Bug#10464)
2438 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2439 he end column for display of highlight that ends on a newline
2440 before a R2L line.
2441
2442 2012-01-11 Glenn Morris <rgm@gnu.org>
2443
2444 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2445 from load-path also when installation-directory is nil. (Bug#10208)
2446
2447 2012-01-10 Glenn Morris <rgm@gnu.org>
2448
2449 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2450
2451 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2452 Update template values to be closer to their typical values these days.
2453
2454 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2455
2456 * xdisp.c (rows_from_pos_range): Accept additional argument
2457 DISP_STRING, and accept any glyph in a row whose object is that
2458 string as eligible for mouse highlight. Fixes mouse highlight of
2459 display strings from overlays. (Bug#10464)
2460
2461 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2462
2463 emacs: fix an auto-save permissions race condition (Bug#10400)
2464 * fileio.c (auto_saving_dir_umask): New static var.
2465 (Fmake_directory_internal): Use it.
2466 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2467 creating the directory. The old code temporarily assigns
2468 too-generous permissions to the directory.
2469 (do_auto_save_eh): Clear it.
2470 (Fdo_auto_save): Catch all errors, not just file errors, so
2471 that the var is always cleared.
2472
2473 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2474
2475 * search.c (scan_buffer): Pass character positions to
2476 know_region_cache, not byte positions. (Bug#6540)
2477
2478 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2479
2480 * w32.c (sys_rename): Report EXDEV when rename of a directory
2481 fails because the target is on another logical disk. (Bug#10284)
2482
2483 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2484
2485 * xterm.c (x_embed_request_focus): New function.
2486
2487 * xterm.h: Add prototype.
2488
2489 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2490
2491 2012-01-05 Glenn Morris <rgm@gnu.org>
2492
2493 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2494
2495 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2496
2497 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2498 Load gnutls_transport_set_lowat only if GnuTLS version is below
2499 2.11.1.
2500 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2501 GnuTLS versions below 2.11.1.
2502
2503 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2504
2505 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2506 to the doc string advising against its use for altering the way
2507 windows are scrolled.
2508
2509 2011-12-28 Kenichi Handa <handa@m17n.org>
2510
2511 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2512 coding-system ASCII compatible only when it does not produce BOM
2513 on encoding (Bug#10383).
2514
2515 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2516
2517 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2518 can scroll.
2519 (create_and_show_popup_menu): Always use menu_position_func for
2520 Gtk3 (Bug#10361).
2521
2522 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2523
2524 * callint.c (Fcall_interactively): Don't truncate prompt string.
2525
2526 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2527
2528 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2529 property that ends at ZV, so that the bidi iteration could be
2530 resumed from there (after widening). (Bug#10360)
2531
2532 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2533
2534 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2535
2536 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2537
2538 * nsterm.m (x_free_frame_resources):
2539 Release f->output_data.ns->miniimage.
2540 (ns_index_color): Fix indentation. Do not retain
2541 color_table->colors[i].
2542
2543 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2544 before returning.
2545
2546 * nsfns.m (x_set_background_color): Assign return value from
2547 ns_index_color to face-background instead of NSColor*.
2548 (ns_implicitly_set_icon_type): Fix indentation.
2549 Change assignment in for loop to comparison.
2550
2551 * emacs.c (ns_pool): New variable.
2552 (main): Assign ns_pool.
2553 (Fkill_emacs): Call ns_release_autorelease_pool.
2554
2555 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2556 autorelease fdesc, release fdAttrs and tdict.
2557 (ns_get_covering_families): Release charset.
2558 (ns_findfonts): Release NSFontDescriptor created with new.
2559 (ns_uni_to_glyphs): Fix indentation.
2560 (setString): Release attrStr before assigning new value.
2561
2562 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2563
2564 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2565 and NS_IMPL_COCOA.
2566 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2567 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2568
2569 2011-12-18 David Reitter <reitter@cmu.edu>
2570
2571 * nsterm.m (ns_term_init): Subscribe for notifications
2572 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2573 to method trackingNotification in EmacsMenu.
2574
2575 * nsmenu.m (trackingMenu): New variable.
2576 (trackingNotification): New method (from Aquamacs).
2577 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2578 from Aquamacs (Bug#7030).
2579
2580 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2581
2582 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2583 (symbol_to_nsstring): Fix indentation.
2584 (ns_symbol_to_pb): New function.
2585 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2586 (Fns_rotate_cut_buffers_internal): Remove.
2587 (Fns_store_selection_internal): Rename from
2588 Fns_store_cut_buffer_internal.
2589 (ns_get_foreign_selection, Fx_own_selection_internal)
2590 (Fx_disown_selection_internal, Fx_selection_exists_p)
2591 (Fns_get_selection_internal, Fns_store_selection_internal):
2592 Use ns_symbol_to_pb and check if return value is nil.
2593 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2594 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2595 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2596 renamed to Sns_store_selection_internal.
2597 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2598 and remove this function.
2599 (ns_handle_selection_clear): Remove, never used.
2600 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2601 here.
2602
2603 2011-12-17 Ken Brown <kbrown@cornell.edu>
2604
2605 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2606 GID is unknown (Bug#10257).
2607
2608 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2609
2610 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2611 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2612 which caused a build failure on GNU/Linux IA-64. This problem was
2613 introduced by my 2011-10-07 patch.
2614
2615 2011-12-15 Juri Linkov <juri@jurta.org>
2616
2617 * image.c (imagemagick_error): New function. (Bug#10112)
2618 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2619 Use `imagemagick_error' where ImageMagick functions return
2620 `MagickFalse'.
2621 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2622 proper order.
2623
2624 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2625
2626 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2627 fill background (Bug#8992).
2628
2629 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2630
2631 * window.c (Vwindow_combination_resize)
2632 (Vwindow_combination_limit): Use t instead of non-nil in
2633 doc-strings.
2634 (Vrecenter_redisplay): Add first sentence of doc-string on
2635 separate line.
2636 (Frecenter): Fix doc-string typo.
2637
2638 2011-12-11 Kenichi Handa <handa@m17n.org>
2639
2640 * coding.c (Funencodable_char_position): Pay attention to the
2641 buffer text relocation (Bug#9389).
2642
2643 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2644
2645 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2646 gtk_init (Bug#10100).
2647
2648 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2649
2650 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2651 IT->string is nil. (Bug#10263)
2652
2653 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2654
2655 * nsterm.h (x_free_frame_resources): Declare.
2656
2657 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2658 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2659
2660 * nsterm.h (ns_get_defaults_value): Declare.
2661
2662 * nsterm.m (ns_default): Call ns_get_defaults_value.
2663
2664 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2665
2666 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2667 (Bug#10170)
2668
2669 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2670
2671 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2672 that where the value of an _OBJC_* symbol points to is in the .bss
2673 section (Bug#10240).
2674
2675 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2676
2677 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2678 after the loop to call ccl_driver at least once (Bug#8619).
2679
2680 2011-12-08 Kenichi Handa <handa@m17n.org>
2681
2682 * ftfont.c (get_adstyle_property): Fix previous change
2683 (Bug#10233).
2684
2685 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2686
2687 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2688 dirs from the default value of EMACSLOADPATH (bug#10208).
2689
2690 2011-12-07 Glenn Morris <rgm@gnu.org>
2691
2692 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2693 installation and source directories as well. (Bug#10208)
2694
2695 2011-12-06 Chong Yidong <cyd@gnu.org>
2696
2697 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2698
2699 2011-12-06 Glenn Morris <rgm@gnu.org>
2700
2701 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2702 as an error, not just -1. (Bug#10217)
2703
2704 2011-12-05 Chong Yidong <cyd@gnu.org>
2705
2706 * keyboard.c (process_special_events): New function.
2707 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2708
2709 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2710
2711 * coding.c (encode_designation_at_bol): Don't use uninitialized
2712 local variable (Bug#9318).
2713
2714 2011-12-05 Kenichi Handa <handa@m17n.org>
2715
2716 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2717 return Qnil (Bug#8046, Bug#10193).
2718
2719 2011-12-05 Kenichi Handa <handa@m17n.org>
2720
2721 * coding.c (encode_designation_at_bol): New args charbuf_end and
2722 dst. Return the number of produced bytes. Callers changed.
2723 (coding_set_source): Return how many bytes coding->source was
2724 relocated.
2725 (coding_set_destination): Return how many bytes
2726 coding->destination was relocated.
2727 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2728 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2729
2730 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2731
2732 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2733 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2734 macro (Bug#9318).
2735
2736 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2737
2738 The following changes are to fix Bug#9318.
2739
2740 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2741 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2742 (encode_coding_iso_2022, encode_coding_sjis)
2743 (encode_coding_big5, encode_coding_charset): Use the above macros.
2744
2745 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2746
2747 * lisp.h (process_quit_flag): Fix external declaration.
2748
2749 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2750
2751 Don't macro-inline non-performance-critical code.
2752 * eval.c (process_quit_flag): New function.
2753 * lisp.h (QUIT): Use it.
2754
2755 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2756
2757 * nsfns.m (get_geometry_from_preferences): New function.
2758 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2759
2760 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2761
2762 * emacs.c (Qkill_emacs): Define.
2763 (syms_of_emacs): Initialize it.
2764 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2765 Qquit_flag to `kill-emacs' instead.
2766 (quit_throw_to_read_char): Add parameter `from_signal'.
2767 All callers changed. Call Fkill_emacs if requested and safe.
2768 * lisp.h (QUIT): Call Fkill_emacs if requested.
2769
2770 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2771
2772 * widget.c (update_wm_hints): Return if wmshell is null.
2773 (widget_update_wm_size_hints): New function.
2774
2775 * widget.h (widget_update_wm_size_hints): Declare.
2776
2777 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2778 widget_update_wm_size_hints (Bug#10104).
2779
2780 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2781
2782 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2783 before a newline, prepare the bidi iterator for consuming the
2784 newline, and keep the current paragraph direction. (Bug#10183)
2785 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2786
2787 2011-12-02 Juri Linkov <juri@jurta.org>
2788
2789 * search.c (Fword_search_regexp): New Lisp function created from
2790 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2791 (Fword_search_backward, Fword_search_forward)
2792 (Fword_search_backward_lax, Fword_search_forward_lax):
2793 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2794 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2795
2796 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2797
2798 * fileio.c (Finsert_file_contents): Move after-change-function call
2799 to before the "handled:" label, since all "goto handled" appear in
2800 cases where the *-change-functions have already been properly called
2801 (bug#10117).
2802
2803 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2804
2805 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2806 waiting for input. (Bug#10169)
2807
2808 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2809
2810 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2811 verifies glyph row's hash code--we have just reallocated the
2812 glyphs, so their contents can be complete garbage. (Bug#10164)
2813
2814 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2815
2816 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2817
2818 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2819
2820 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2821 attributes are tested _before_ calling verify_row_hash, to protect
2822 against GCC re-ordering of the tests. (Bug#10164)
2823
2824 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2825
2826 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2827
2828 * xterm.c (handle_one_xevent): Only set async_visible and friends
2829 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2830 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2831 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2832
2833 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2834
2835 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2836 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2837 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2838 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2839 All uses changed to use GCPRO1 etc.
2840 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2841 Revert to old implementation (i.e., before 2011-03-11).
2842
2843 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2844
2845 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2846 of scroll runs so as to avoid assigning disabled bogus rows and
2847 unnecessary graphics copy operations.
2848
2849 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2850
2851 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2852 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2853 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2854 (malloc, free, realloc, calloc): Redirect to e_* only when
2855 compiling Emacs.
2856
2857 * lisp.h (GCTYPEBITS): Move before first use.
2858 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2859 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2860 this macro definition.
2861
2862 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2863 _MSC_VER.
2864
2865 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2866
2867 * gtkutil.c (xg_create_frame_widgets):
2868 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2869 present with Gtk+ 2.0.
2870
2871 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2872
2873 * fileio.c (Finsert_file_contents): Undo previous change; see
2874 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2875
2876 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2877
2878 Rename locals to avoid shadowing.
2879 * fileio.c (Finsert_file_contents):
2880 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2881 * process.c (wait_reading_process_output):
2882 Rename inner 'proc' to 'p' to avoid shadowing.
2883 Indent for consistency with usual Emacs style.
2884
2885 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2886
2887 * xdisp.c (redisplay_window): If cursor row is not fully visible
2888 after recentering, and scroll-conservatively is set to a large
2889 number, scroll window by a few more lines to make the cursor fully
2890 visible and out of scroll-margin. (Bug#10105)
2891 (start_display): Don't move to the next line if the display should
2892 start at a newline that is part of a display vector or an overlay
2893 string. (Bug#10119)
2894
2895 2011-11-24 Juri Linkov <juri@jurta.org>
2896
2897 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2898 after the `MagickPingImage' call. (Bug#10112)
2899
2900 2011-11-23 Chong Yidong <cyd@gnu.org>
2901
2902 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2903
2904 2011-11-23 Martin Rudalics <rudalics@gmx.at>
2905
2906 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2907 making another buffer current. (Bug#10114)
2908
2909 2011-11-23 Glenn Morris <rgm@gnu.org>
2910
2911 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2912
2913 2011-11-23 Chong Yidong <cyd@gnu.org>
2914
2915 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2916 using it (Bug#5984).
2917
2918 2011-11-22 Eli Zaretskii <eliz@gnu.org>
2919
2920 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2921 and header-lines, as they don't have one computed for them.
2922 (Bug#10098)
2923
2924 * .gdbinit (prow): Make displayed values more self-explaining.
2925 Add row's hash code.
2926
2927 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2928
2929 * process.c (wait_reading_process_output): Fix asynchrounous
2930 GnuTLS socket handling on some versions of the GnuTLS library.
2931 (wait_reading_process_output): Add comment and URL.
2932
2933 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2934
2935 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2936
2937 2011-11-21 Chong Yidong <cyd@gnu.org>
2938
2939 * window.c (Fnext_window, Fprevious_window): Doc fix.
2940
2941 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2942
2943 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2944
2945 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2946
2947 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2948
2949 2011-11-20 Martin Rudalics <rudalics@gmx.at>
2950
2951 * window.c (Fset_window_combination_limit): Rename argument
2952 STATUS to LIMIT.
2953 (Vwindow_combination_limit): Remove "status" from doc-string.
2954
2955 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2956
2957 * m/ibms390.h: Remove.
2958 * m/ibms390x.h: Don't include "ibms390.h".
2959
2960 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2961
2962 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2963 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2964
2965 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2966
2967 * casetab.c (Fset_case_table):
2968 * charset.c (Fcharset_after): Fix typos.
2969
2970 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
2971
2972 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2973 Otherwise, valgrind does not work on some platforms.
2974 Problem reported by Andreas Schwab in
2975 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2976 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2977 is set, removing the need for VIRT_ADDRESS_VARIES.
2978 (PURE_P): Use a more-efficient implementation that needs just one
2979 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2980 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2981 to 4 (xorl, subq, cmpq, setbe).
2982 * alloc.c (pure): Always extern now, since that's the
2983 VIRT_ADDR_VARIES behavior.
2984 (PURE_POINTER_P): Use a single comparison, not two, for
2985 consistency with the new puresize.h.
2986 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2987 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2988 Remove VIRT_ADDR_VARIES no longer needed.
2989
2990 2011-11-19 Eli Zaretskii <eliz@gnu.org>
2991
2992 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2993 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2994 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2995 behave as if the cursor position were at the window margin.
2996
2997 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2998 and the cursor position is out of bounds, behave as if the cursor
2999 position were at the window margin. (Bug#10075)
3000
3001 2011-11-18 Chong Yidong <cyd@gnu.org>
3002
3003 * window.c (Fwindow_combination_limit): Make first argument
3004 non-optional, since it is meaningless for live windows like the
3005 selected window.
3006
3007 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3008
3009 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3010
3011 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3012
3013 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3014 (graft_intervals_into_buffer): Simplify.
3015
3016 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3017
3018 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3019 hash values of the two rows.
3020 (copy_row_except_pointers): Preserve the used[] arrays and the
3021 hash values of the two rows. (Bug#10035)
3022 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3023
3024 * xdisp.c (row_hash): New function, body extracted from
3025 compute_line_metrics.
3026 (compute_line_metrics): Call row_hash, instead of computing the
3027 hash code inline.
3028
3029 * dispnew.c (verify_row_hash): Call row_hash for computing the
3030 hash code of a row, instead of duplicating code from xdisp.c.
3031
3032 * dispextern.h (row_hash): Add prototype.
3033
3034 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3035
3036 * frame.c (delete_frame): Don't delete the terminal when the last
3037 X frame is closed if emacs is built with GTK toolkit.
3038
3039 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3040
3041 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3042
3043 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3044
3045 * window.c (Vwindow_splits): Rename to
3046 Vwindow_combination_resize. Suggested by Juri Linkov.
3047 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3048 of Vwindow_splits.
3049
3050 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3051
3052 * nsfns.m (Fns_font_name):
3053 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3054
3055 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3056
3057 * window.h (window): Rename slot "nest" to "combination_limit".
3058 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3059 (Fset_window_nest): Rename to Fset_window_combination_limit.
3060 (Vwindow_nest): Rename to Vwindow_combination_limit.
3061 (recombine_windows, make_parent_window, make_window)
3062 (Fsplit_window_internal, saved_window)
3063 (Fset_window_configuration, save_window_save): Rename all
3064 occurrences of window_nest to window_combination_limit.
3065
3066 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3067
3068 * image.c (imagemagick_load_image): Fix typo.
3069
3070 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3071
3072 * xdisp.c (display_line): Move the call to
3073 highlight_trailing_whitespace before the call to
3074 compute_line_metrics, since the latter needs to see the final
3075 faces of all the glyphs to compute ROW's hash value.
3076 Fixes assertion violations in row_equal_p. (Bug#10035)
3077
3078 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3079
3080 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3081 just return (bug#10044).
3082
3083 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3084
3085 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3086 with user-defined heap size. Bump the default size of the temacs
3087 heap to 27MB, to avoid memory warning when running temacs.
3088 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3089
3090 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3091 current_matrix and desired_matrix. (Bug#9990)
3092 (verify_row_hash) [XASSERTS]: New function.
3093 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3094 that the hash value of glyph rows is correct.
3095
3096 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3097
3098 * window.h (window): Remove splits slot.
3099 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3100 (Fdelete_other_windows_internal, make_parent_window)
3101 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3102 (Fset_window_configuration, save_window_save): Don't deal with
3103 split status of windows.
3104 (saved_window): Remove splits slot.
3105 (Vwindow_splits): Rewrite doc-string.
3106
3107 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3108
3109 * xfns.c (unwind_create_frame):
3110 * nsfns.m (unwind_create_frame):
3111 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3112 Vframe_list (Bug#9999).
3113
3114 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3115
3116 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3117
3118 2011-11-11 Kenichi Handa <handa@m17n.org>
3119
3120 * callproc.c (Fcall_process): Set the member dst_multibyte of
3121 process_coding.
3122
3123 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3124
3125 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3126 avoid a crash (bug#9496).
3127
3128 2011-11-09 Chong Yidong <cyd@gnu.org>
3129
3130 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3131 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3132
3133 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3134
3135 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3136
3137 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3138
3139 Avoid some portability problems by eschewing 'extern inline' functions.
3140 The trivial performance wins aren't worth the portability hassles; see
3141 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3142 et seq.
3143 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3144 (window_box_width, window_box_left, window_box_left_offset)
3145 (window_box_right, window_box_right_offset): Undo previous change,
3146 by removing the "extern"s.
3147 * intervals.c (adjust_intervals_for_insertion)
3148 (adjust_intervals_for_deletion): Undo previous change,
3149 making these static again.
3150 (offset_intervals, temp_set_point_both, temp_set_point)
3151 (copy_intervals_to_string): No longer inline.
3152 * xdisp.c (window_text_bottom_y, window_box_width)
3153 (window_box_height, window_box_left_offset)
3154 (window_box_right_offset, window_box_left, window_box_right)
3155 (window_box): No longer inline.
3156
3157 2011-11-08 Chong Yidong <cyd@gnu.org>
3158
3159 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3160 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3161 Signal an error if not a live window.
3162 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3163 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3164
3165 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3166
3167 * lisp.h (syms_of_abbrev): Remove declaration.
3168 Reported by CHENG Gao <chenggao@royau.me>.
3169
3170 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3171
3172 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3173 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3174 of temacs in GUI mode.
3175
3176 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3177
3178 * window.h: Declare delete_all_child_windows instead of
3179 delete_all_subwindows.
3180 * window.c (Fwindow_nest, Fset_window_nest)
3181 (Fset_window_new_total, Fset_window_new_normal)
3182 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3183 (delete_all_subwindows): Rename to delete_all_child_windows.
3184 (Fdelete_other_windows_internal, Fset_window_configuration):
3185 Call delete_all_child_windows instead of delete_all_subwindows.
3186 * frame.c (delete_frame): Call delete_all_child_windows instead
3187 of delete_all_subwindows.
3188
3189 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3190
3191 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3192 This is also needed for porting to any host where GC_MARK_STACK is
3193 not GC_MAKE_GCPROS_NOOPS.
3194 (which_symbols): Use it.
3195
3196 2011-11-07 Kenichi Handa <handa@m17n.org>
3197
3198 * coding.c (coding_set_destination): Check coding->src_pos only
3199 when coding->src_object is a buffer (bug#9910).
3200
3201 * process.c (send_process): Set the member src_multibyte of coding
3202 to 0 (bug#9911) when sending a unibyte text.
3203
3204 * callproc.c (Fcall_process): Set the member src_multibyte of
3205 process_coding to 0 (bug#9912).
3206
3207 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3208
3209 * xmenu.c (cleanup_widget_value_tree): New function.
3210 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3211 calling free_menubar_widget_value_tree directly (Bug#9830).
3212
3213 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3214
3215 Fix some portability problems with 'inline'.
3216 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3217 (window_box_width, window_box_left, window_box_left_offset)
3218 (window_box_right, window_box_right_offset): Declare extern.
3219 Otherwise, these inline functions do not conform to C99 and
3220 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3221 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3222 * intervals.c (adjust_intervals_for_insertion)
3223 (adjust_intervals_for_deletion): Now extern, because otherwise the
3224 extern inline functions 'offset_intervals' couldn't refer to it.
3225 (static_offset_intervals): Remove.
3226 (offset_intervals): Rewrite using the old contents of
3227 static_offset_intervals. The old version didn't conform to C99
3228 because an extern inline function contained a reference to an
3229 identifier with static linkage.
3230
3231 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3232
3233 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3234 GC.
3235
3236 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3237
3238 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3239 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3240 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3241 return Qleft_to_right.
3242
3243 2011-11-06 Chong Yidong <cyd@gnu.org>
3244
3245 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3246 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3247 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3248 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3249 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3250 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3251 (Fwindow_vscroll): Doc fix.
3252 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3253 argument, since it makes no sense to pass a live window and for
3254 consistency with window-child.
3255
3256 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3257
3258 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3259 support MSVC.
3260
3261 2011-11-05 Jason Rumney <jasonr@gnu.org>
3262
3263 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3264 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3265 fonts (Bug#6029).
3266 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3267 bitwise arithmetic preventing use of unicode-sip and non-truetype
3268 opentype fonts.
3269
3270 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3271
3272 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3273 "emacs"-only part.
3274
3275 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3276 initialization code to keep similarity to xfns.c after changes
3277 from 2011-11-05.
3278
3279 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3280
3281 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3282 (unwind_create_frame): New function (Bug#9943).
3283 (Fx_create_frame): Restructure code to be more similar to the one in
3284 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3285 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3286 Move terminal->reference_count++ just before making the frame official
3287 (Bug#9943).
3288
3289 * nsterm.m (x_free_frame_resources): New function.
3290 (x_destroy_window): Move code to x_free_frame_resources.
3291
3292 * xfns.c (unwind_create_frame): Fix comment.
3293 (Fx_create_frame, x_create_tip_frame):
3294 Move terminal->reference_count++ just before making the frame
3295 official. Move initialization of image_cache_refcount and
3296 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3297
3298 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3299
3300 Support MSVC build with newer versions of Visual Studio.
3301 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3302 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3303 nt/gmake.defs.
3304
3305 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3306 which are not supported by MSVC.
3307 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3308 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3309 bitfields.
3310 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3311 types in bitfields.
3312 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3313
3314 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3315
3316 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3317
3318 Support MSVC build with newer versions of Visual Studio.
3319 * w32.c: Don't include w32api.h for MSVC.
3320 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3321
3322 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3323 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3324 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3325 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3326 e_* cousins.
3327 (alloca) [_MSC_VER]: Define to _alloca.
3328
3329 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3330
3331 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3332
3333 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3334
3335 * xdisp.c (note_mouse_highlight): If either of
3336 previous/next-single-property-change returns nil, treat that as
3337 the beginning or the end of the buffer. (Bug#9955)
3338
3339 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3340
3341 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3342 label is not null (Bug#9951).
3343 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3344 may be NULL.
3345
3346 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3347
3348 * window.c (Fwindow_body_size): Mention in the doc string that the
3349 return value is in frame's canonical units. (Bug#9949)
3350
3351 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3352
3353 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3354
3355 * w32fns.c (unwind_create_frame): If needed, free the glyph
3356 matrices of the partially constructed frame. (Bug#9943)
3357 * xfns.c (unwind_create_frame): Likewise.
3358
3359 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3360
3361 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3362 Don't stop backward scan on the continuation glyph, even though
3363 its CHARPOS is positive.
3364 (mouse_face_from_buffer_pos, note_mouse_highlight):
3365 Rename cover_string to disp_string.
3366
3367 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3368
3369 * window.c (temp_output_buffer_show): Don't use
3370 Vtemp_buffer_show_specifiers.
3371 (Vtemp_buffer_show_specifiers): Remove unused variable.
3372
3373 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3374
3375 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3376 past the beginning of the current glyph matrix.
3377
3378 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3379
3380 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3381 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3382 HAVE_GTK3 (Bug#9869).
3383
3384 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3385 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3386
3387 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3388
3389 * xterm.c: Declare x_handle_net_wm_state to return int.
3390 (handle_one_xevent): Check if we are iconified but don't have
3391 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3392 (get_current_wm_state): Return non-zero if not hidden,
3393 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3394 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3395 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3396 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3397
3398 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3399
3400 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3401 so that this new function doesn't get optimized away by a
3402 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3403
3404 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3405
3406 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3407
3408 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3409
3410 Fix the `xbytecode' command.
3411 * .gdbinit (xprintbytestr): New command.
3412 (xwhichsymbols): Rename from `which'; all callers changed.
3413 (xbytecode): Print the byte-code string as well.
3414
3415 2011-10-29 Kim Storm <storm@cua.dk>
3416
3417 * alloc.c (which_symbols): New function.
3418
3419 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3420
3421 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3422 line. (Bug#9903)
3423
3424 2011-10-29 Glenn Morris <rgm@gnu.org>
3425
3426 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3427 Not clear what it was for, and it causes various bugs. (Bug#9839)
3428
3429 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3430
3431 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3432 possible random value that matches one of those tested as
3433 condition to clear the mouse face.
3434
3435 2011-10-28 Chong Yidong <cyd@gnu.org>
3436
3437 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3438
3439 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3440
3441 * window.c (make_window): Initialize phys_cursor_on_p.
3442
3443 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3444
3445 * lisp.h (struct Lisp_Symbol): Update comments.
3446
3447 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3448
3449 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3450
3451 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3452
3453 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3454 <oslsachem@gmail.com> for helping to debug this.
3455
3456 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3457 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3458 (g_b_init_get_glyph_outline_w): New static variables.
3459 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3460 (GetGlyphOutlineW_Proc): New typedefs.
3461 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3462 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3463 New functions.
3464 (w32font_open_internal, compute_metrics):
3465 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3466 instead of calling the "wide" APIs directly.
3467
3468 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3469
3470 * w32.h (syms_of_w32font): Add prototype.
3471
3472 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3473
3474 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3475 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3476 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3477 (Fmove_to_window_line): Doc fix.
3478
3479 2011-10-27 Chong Yidong <cyd@gnu.org>
3480
3481 * process.c (make_process): Set gnutls_state to NULL.
3482
3483 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3484 non-NULL, regardless of GNUTLS_INITSTAGE.
3485 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3486 an error. Set process slots as soon as we allocate them.
3487
3488 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3489
3490 2011-10-27 Chong Yidong <cyd@gnu.org>
3491
3492 * gnutls.c (emacs_gnutls_deinit): New function.
3493 Deallocate credentials structures as well as calling gnutls_deinit.
3494 (Fgnutls_deinit, Fgnutls_boot): Use it.
3495
3496 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3497 (deactivate_process): Call emacs_gnutls_deinit.
3498
3499 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3500
3501 * image.c (x_create_x_image_and_pixmap):
3502 * w32.c (sys_rename, w32_delayed_load):
3503 * w32font.c (fill_in_logfont):
3504 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3505
3506 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3507
3508 * w32fns.c (w32_default_color_map): New function,
3509 extracted from Fw32_default_color_map.
3510 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3511
3512 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3513
3514 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3515
3516 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3517
3518 * keyboard.c (test_undefined): New function (bug#9751).
3519 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3520
3521 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3522
3523 * sysdep.c (init_sys_modes): Fix the check for the controlling
3524 terminal (Bug#6649).
3525
3526 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3527
3528 * dispextern.h (struct bidi_it): New member next_en_type.
3529
3530 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3531 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3532 current character, check also for next_en_type being WEAK_EN.
3533 (bidi_resolve_weak): Don't enter the expensive loop if the current
3534 position is before next_en_pos. Record the bidi type of the first
3535 non-ET, non-BN character we find, in addition to its position.
3536 (bidi_level_of_next_char): Invalidate next_en_type when
3537 next_en_pos is over-stepped.
3538
3539 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3540
3541 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3542 * editfns.c: Rewrite current-time-zone so that it invokes
3543 the equivalent of (format-time-string "%Z") to get the time zone name.
3544 This fixes a bug when the time zone name contains characters that
3545 need converting from the system time locale to Emacs internal format.
3546 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3547 that patch fixed format-time-string to do the conversion, but
3548 I forgot to fix current-time-zone.
3549 (format_time_string): New function, containing most of
3550 what Fformat_time_string used to contain.
3551 (Fformat_time_string): Rewrite in terms of format_time_string.
3552 This doesn't change this function's behavior.
3553 (current-time-zone): Rewrite to use format_time_string.
3554 This fixes the bug reported by Michael Schierl in
3555 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3556 Jason Rumney's 2007-06-07 change worked around this bug, but
3557 didn't fix it.
3558 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3559
3560 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3561
3562 * xdisp.c (start_display): If the character at POS is displayed
3563 via a display vector, reset IT->current.dpvec_index to zero.
3564 (try_window_reusing_current_matrix): If a line ends in a display
3565 vector or the next line starts in a display vector, continue
3566 redrawing the window even though the character position of
3567 start_row was reached.
3568 (Bug#9771, part 2)
3569
3570 2011-10-18 Chong Yidong <cyd@gnu.org>
3571
3572 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3573 with nobreak-char-display too.
3574
3575 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3576
3577 Fix part 3 of bug#9771.
3578 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3579 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3580 non-neutral characters if the current character is a paragraph
3581 separator (a.k.a. Newline). This avoids running the same
3582 expensive loop twice, once when we consume the preceding newline
3583 and the other time when the line actually needs to be displayed.
3584 Avoid the loop when we see neutrals on the base embedding level
3585 following a character whose directionality is the same as the
3586 paragraph's. This avoids running the expensive loop when a line
3587 ends in a long sequence of neutrals, like control characters.
3588 Add assertion against STRONG_AL type. Slightly rearrange code
3589 that determines the type of a neutral given the first non-neutral
3590 that follows it.
3591 (bidi_level_of_next_char): Set next_en_pos to zero when
3592 invalidating its info.
3593
3594 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3595
3596 * xdisp.c (push_display_prop): Determine whether to record string
3597 or buffer position by IT->string, not by IT->method. Allow
3598 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3599 (move_it_vertically_backward): Don't look for character position
3600 immediately after the newline when in a continuation line.
3601 (Bug#9771, part 1)
3602
3603 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3604
3605 * window.c (coordinates_in_window): Rewrite and delabelize
3606 vertical border check. (Bug#5357) (Bug#9618)
3607
3608 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3609
3610 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3611 errors in XSetWindowBorder (bug#9310).
3612
3613 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3614
3615 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3616 avoid crash when xmalloc overrun checking is enabled.
3617
3618 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3619
3620 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3621 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3622 cursor motion with <left> and <right> arrow keys.
3623
3624 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3625 some callers set that themselves.
3626
3627 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3628
3629 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3630 display string and the previous row comes from the same string and
3631 is empty. (Bug#9739) (Bug#9738)
3632
3633 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3634
3635 * doc.c (get_doc_string): Encode file name (bug#9735).
3636
3637 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3638
3639 * bidi.c (bidi_level_of_next_char):
3640 * xdisp.c (get_visually_first_element): Remove old incorrect
3641 comments regarding the Unicode Line Separator character.
3642
3643 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3644
3645 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3646
3647 * alloc.c (Fgc_status): Do not access beyond zombies array
3648 boundary if nzombies > MAX_ZOMBIES.
3649 * alloc.c (dump_zombies): Add missing format specifier.
3650
3651 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3652
3653 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3654 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3655
3656 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3657 Some packages use them to denote characters with modifiers.
3658
3659 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3660
3661 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3662 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3663 matching a pp-number. Rename parameter var to var1.
3664
3665 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3666
3667 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3668
3669 2011-10-08 Glenn Morris <rgm@gnu.org>
3670
3671 * callint.c (Fcall_interactively): Give a more explicit error for the
3672 'c' case with a non-character input. (Bug#8479)
3673
3674 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3675
3676 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3677 lines.
3678 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3679 lines that are hscrolled on the left.
3680
3681 * dispnew.c (buffer_posn_from_coords): Account for a possible
3682 presence of header-line. (Bug#4426)
3683
3684 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3685
3686 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3687 Don't advertise functionality which we discourage or doesn't work.
3688
3689 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3690
3691 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3692 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3693 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3694 this makes Emacs dump core during garbage collection on rare
3695 occasions. sizeof is obviously inferior to offsetof here, so
3696 stick with offsetof.
3697 (GC_POINTER_ALIGNMENT): New macro.
3698 (mark_memory): Omit 3rd (offset) arg; caller changed.
3699 Don't assume EMACS_INT alignment is the same as pointer alignment.
3700
3701 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3702
3703 * keyboard.c (read_key_sequence_remapped): New var.
3704 (read_key_sequence): Compute remapping in the right buffer.
3705 (command_loop_1): Use read_key_sequence's remapping directly.
3706
3707 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3708
3709 * dired.c (file_name_completion): Don't expand file name.
3710 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3711 before checking file name handler.
3712
3713 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3714 they've been requested explicitly (bug#9591).
3715
3716 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3717
3718 * keymap.c (Fsingle_key_description): Use make_specified_string
3719 instead of build_string to build string from push_key_description.
3720 (Bug#5193)
3721
3722 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3723
3724 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3725 This fixes a Y2038 bug on 64-bit hosts.
3726 * buffer.c (reset_buffer):
3727 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3728 (Fclear_buffer_auto_save_failure):
3729 Use 0, not -1, to represent an unset failure time, since time_t
3730 might not be signed.
3731
3732 Remove dependency on glibc malloc internals.
3733 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3734 Move back here from lisp.h, but with their new implementations.
3735 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3736 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3737 * charset.c (charset_table_init): New static var.
3738 (syms_of_charset): Use it instead of xmalloc. This removes a
3739 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3740 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3741 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3742 Move back to alloc.c.
3743 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3744 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3745
3746 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3747
3748 * nsterm.m (windowDidResize): Call x_set_window_size only when
3749 ns_in_resize is true. Otherwise set pixelwidth/height and
3750 call change_frame_size (Bug#9628).
3751
3752 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3753
3754 Port --enable-checking=all to Fedora 14 x86-64.
3755 * charset.c (syms_of_charset): Also account for glibc malloc's
3756 internal overhead when calculating the initial malloc maximum.
3757
3758 Port --enable-checking=all to Fedora 14 x86.
3759 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3760 Move to lisp.h.
3761 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3762 (overrun_check_realloc, overrun_check_free):
3763 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3764 That way, xmalloc returns a properly-aligned pointer even if
3765 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3766 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3767 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3768 into account when calculating the initial malloc maximum.
3769 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3770 Move here from alloc.c, so that charset.c can use it too.
3771 Properly align; the old code wasn't right for common 32-bit hosts
3772 when configured with --enable-checking=all.
3773 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3774 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3775
3776 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3777
3778 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3779 use EDOM.
3780
3781 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3782
3783 * xdisp.c (compute_display_string_end): If there's no display
3784 string at CHARPOS, return -1.
3785
3786 * bidi.c (bidi_fetch_char): When compute_display_string_end
3787 returns a negative value, treat the character as a normal
3788 character not covered by a display string. (Bug#9624)
3789
3790 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3791
3792 * lread.c (Fread_from_string): Fix typo in docstring.
3793
3794 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3795
3796 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3797 newline, reseat the iterator instead of bidi-iterating there one
3798 character at a time. (Bug#9610)
3799 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3800 TO_CHARPOS if the bidi iterator is at base embedding level.
3801
3802 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3803
3804 * lread.c (readevalloop): Use correct code for NBSP.
3805 (read1): Likewise. (Bug#9608)
3806
3807 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3808
3809 * dbusbind.c (Fdbus_register_signal): When service is not
3810 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3811
3812 2011-09-25 Glenn Morris <rgm@gnu.org>
3813
3814 * buffer.c (truncate-lines): Doc fix.
3815
3816 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3817
3818 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3819 (Fset_window_next_buffers): Doc fix.
3820
3821 2011-09-24 Glenn Morris <rgm@gnu.org>
3822
3823 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3824
3825 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3826
3827 Fix minor problems found by static checking.
3828 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3829 * indent.c (Fvertical_motion): Fix == vs = typo.
3830
3831 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3832
3833 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3834 Default value is now t. Doc fix.
3835
3836 * indent.c (Fvertical_motion): Compute and apply the overshoot
3837 logic when moving up, not only when moving down. Fix the
3838 confusing name and values of the it_overshoot_expected variable;
3839 logic changes accordingly. (Bug#9254) (Bug#9549)
3840
3841 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3842 CHARPOS is covered by a display string which includes newlines.
3843 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3844 is covered by a display string with embedded newlines.
3845
3846 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3847
3848 * dbusbind.c (Fdbus_register_signal): Add match rule to
3849 Vdbus_registered_objects_table. (Bug#9581)
3850 (Fdbus_register_method, Vdbus_registered_objects_table):
3851 Fix docstring.
3852
3853 2011-09-24 Jim Meyering <meyering@redhat.com>
3854
3855 do not ignore write error for any output size
3856 The previous change was incomplete.
3857 While it makes emacs --batch detect the vast majority of stdout
3858 write failures, errors were still ignored whenever the output size is
3859 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3860 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3861 && echo FAIL: ignored write error
3862 FAIL: ignored write error
3863 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3864 && echo FAIL: ignored write error
3865 FAIL: ignored write error
3866 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3867
3868 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3869
3870 * emacs.c (Fkill_emacs): In noninteractive mode exit
3871 non-successfully if a write error occurred on stdout. (Bug#9574)
3872
3873 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3874
3875 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3876 the xassert test.
3877
3878 * dispextern.h (struct it): Update the comment documenting what
3879 can it->OBJECT be.
3880
3881 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3882
3883 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3884 a display string, extend search for cursor position to end of row.
3885 (find_row_edges): If the row ends in a newline from a display
3886 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3887 Handle the case of a display string with multiple newlines.
3888 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3889 non-empty line. Fixes confusing cursor motion with arrow keys at
3890 the beginning of a line that starts with whitespace.
3891
3892 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3893
3894 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3895 (bug#9493).
3896
3897 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3898
3899 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3900 boolean (Bug#9154).
3901
3902 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3903
3904 * xdisp.c (display_line): Record maximum and minimum buffer
3905 positions even if no glyphs were produced (e.g., by a zero-width
3906 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3907 buffer positions that will be removed from the glyph row because
3908 they don't fit.
3909 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3910 column is beyond frame width: don't subtract 1 "pixel" when
3911 computing width of the stretch.
3912 (reseat_at_next_visible_line_start): Undo the change made on
3913 2011-09-17 that saved paragraph information and restored it after
3914 the call to `reseat'. (Bug#9545)
3915
3916 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3917
3918 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3919 and turn window cursor on if cleared (Bug#9415).
3920
3921 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
3922
3923 * search.c (boyer_moore): Take unibyte characters from pattern
3924 literally. (Bug#9458)
3925
3926 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3927
3928 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3929
3930 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3931
3932 Fix minor problem found by static checking.
3933 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3934 initialized, to pacify gcc -Wuninitialized.
3935
3936 * fileio.c: Report proper errno when syscall falls.
3937 (Finsert_file_contents): Save and restore errno,
3938 so that report_file_error outputs the correct diagnostic.
3939 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3940
3941 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3942
3943 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3944
3945 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3946
3947 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3948 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3949
3950 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3951
3952 * xdisp.c (reseat_at_next_visible_line_start): Keep information
3953 about the current paragraph and restore it after the call to reseat.
3954
3955 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3956 (bidi_find_paragraph_start): Search back for paragraph beginning
3957 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3958 (bidi_move_to_visually_next): Only trigger paragraph-related
3959 computations when the last character is a newline or at EOB, not
3960 just any NEUTRAL_B. (Bug#9470)
3961
3962 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3963 truncated lines if point is covered by a display string. (Bug#9524)
3964
3965 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3966
3967 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3968 (cons_to_x_long): New function.
3969 (lisp_data_to_selection_data): Use it. Correct the test for
3970 short-versus-long data; it was negated. Break out of vector
3971 loop, for efficiency, when a long datum is discovered.
3972
3973 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3974
3975 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3976
3977 2011-09-16 Eli Zaretskii <eliz@gnu.org>
3978
3979 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3980 GCC PR/17406) by declaring this function with external scope.
3981
3982 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3983
3984 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3985 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3986
3987 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3988
3989 * editfns.c (Fformat): Correctly handle text properties on "%%".
3990
3991 2011-09-15 Eli Zaretskii <eliz@gnu.org>
3992
3993 * xterm.c (x_draw_composite_glyph_string_foreground):
3994 * w32term.c (x_draw_composite_glyph_string_foreground):
3995 * term.c (encode_terminal_code):
3996 * composite.c (composition_update_it, get_composition_id):
3997 * xdisp.c (get_next_display_element)
3998 (fill_composite_glyph_string): Add comments about special meaning
3999 of TAB characters in a composition.
4000
4001 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4002
4003 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4004 This occurs when processing a multibyte format.
4005 Problem reported by Wolfgang Jenker.
4006
4007 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4008
4009 * xdisp.c (try_cursor_movement): Only check for exact match if
4010 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4011
4012 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4013
4014 Remove unused external symbols.
4015 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4016 * xdisp.c (calc_pixel_width_or_height): Now static.
4017 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4018 * indent.c (check_display_width):
4019 * w32term.c: Fix comment to match code.
4020 * xterm.c, xterm.h (x_catching_errors): Remove.
4021
4022 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4023
4024 * xselect.c: Use signed conversions more consistently (Bug#9498).
4025 (selection_data_to_lisp_data): Assume incoming selection data are
4026 signed integers, not unsigned. This is to be consistent with
4027 outgoing selection data, which was modified to use signed integers
4028 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4029 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4030 expects long, not unsigned long.
4031
4032 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4033
4034 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4035 computation of loop end. Reported by Johan Bockgård
4036 <bojohan@gnu.org>.
4037
4038 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4039
4040 * frame.c (Fother_visible_frames_p): Function deleted.
4041
4042 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4043
4044 * indent.c (compute_motion): Process display vector front to back
4045 rather than the other way around. (Bug#2496)
4046
4047 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4048
4049 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4050
4051 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4052
4053 * minibuf.c (Fread_from_minibuffer): Doc fix.
4054
4055 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4056
4057 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4058 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4059
4060 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4061
4062 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4063 value for non-existent files.
4064
4065 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4066
4067 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4068 set its "size" to -1. This will set the modtime_size field of
4069 the corresponding buffer to -1, which is what
4070 verify-visited-file-modtime expects for files that do not exist.
4071 (Bug#9139)
4072
4073 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4074
4075 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4076 here ...
4077 * lisp.h: ... from here. push_key_description is no longer
4078 defined in keyboard.c, so its declaration should not be in
4079 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4080 logically belongs with push_key_description.
4081
4082 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4083
4084 * buffer.h: Include <sys/types.h> instead of <time.h>.
4085 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4086 Problem reported by Herbert J. Skuhra.
4087
4088 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4089
4090 * xml.c (parse_region): Make the parsing work for
4091 non-comment-starting XML files again (bug#9144).
4092
4093 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4094
4095 * image.c (gif_load): Fix calculation of bottom and right corner.
4096 (Bug#9468)
4097
4098 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4099
4100 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4101 redisplay in small windows.
4102
4103 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4104
4105 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4106
4107 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4108
4109 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4110 Operate on live windows only.
4111
4112 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4113
4114 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4115
4116 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4117
4118 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4119 only under bidi iteration.
4120
4121 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4122
4123 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4124
4125 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4126
4127 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4128 Without this fix, the command to link temacs failed due to an
4129 undefined symbol __builtin_isnan. This is because
4130 /usr/include/iso/math_c99.h #defines isnan(x) to
4131 __builtin_isnan(x), but the bundled gcc, which identifies itself
4132 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4133 a __builtin_isnan.
4134 * floatfns.c (isnan): #undef, and then #define to a clone of
4135 what's in data.c.
4136 (Fisnan): Always define, since it's always available now.
4137 (syms_of_floatfns): Always define isnan at the Lisp level.
4138
4139 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4140
4141 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4142
4143 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4144
4145 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4146 The previous code assumed that file offsets (off_t values) fit in
4147 EMACS_INT variables, which is not true on typical 32-bit hosts.
4148 The code messed up by falsely reporting buffer overflow in cases
4149 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4150 when "big" contains more than 2**29 bytes, even though this
4151 inserts just one byte and does not overflow the buffer.
4152 (Finsert_file_contents): Store file offsets as off_t
4153 values, not as EMACS_INT values. Check for overflow when
4154 converting between EMACS_INT and off_t. When checking for
4155 buffer overflow or for overlap, take the offsets into account.
4156 Don't use EMACS_INT for small values where int suffices.
4157 When checking for overlap, fix a typo: ZV was used where
4158 ZV_BYTE was intended.
4159 (Fwrite_region): Don't assume off_t fits into 'long'.
4160 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4161
4162 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4163
4164 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4165
4166 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4167
4168 sprintf-related integer and memory overflow issues (Bug#9412).
4169
4170 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4171 (esprintf, exprintf, evxprintf): New functions.
4172 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4173 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4174 (modify_event_symbol): Do not assume that the length of
4175 name_alist_or_stem is safe to alloca and fits in int.
4176 (Fexecute_extended_command): Likewise for function name and binding.
4177 (Frecursion_depth): Wrap around reliably on integer overflow.
4178 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4179 since some callers pass EMACS_INT values.
4180 (Fsingle_key_description): Don't crash if symbol name contains more
4181 than MAX_ALLOCA bytes.
4182 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4183 (get_minibuffer): Arg is now EMACS_INT, not int.
4184 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4185 (esprintf, exprintf, evxprintf): New decls.
4186 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4187
4188 * dbusbind.c (signature_cat): New function.
4189 (xd_signature, Fdbus_register_signal):
4190 Do not overrun buffer; instead, report string overflow.
4191
4192 * dispnew.c (add_window_display_history): Don't overrun buffer.
4193 Truncate instead; this is OK since it's just a log.
4194
4195 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4196 even if the time zone offset is outlandishly large.
4197 Don't mishandle offset == INT_MIN.
4198
4199 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4200 when creating daemon; the previous buffer-overflow check was incorrect.
4201
4202 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4203 which has the guts of the old verror function.
4204
4205 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4206 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4207
4208 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4209 (font_unparse_xlfd): Don't blindly alloca long strings.
4210 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4211 fits in int, when using sprintf. Use single snprintf to count
4212 length of string rather than counting it via multiple sprintfs;
4213 that's simpler and more reliable.
4214 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4215 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4216 sprintf, in case result does not fit in int.
4217
4218 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4219 (fontset_from_font): Print it.
4220
4221 * frame.c (tty_frame_count): Now printmax_t, not int.
4222 (make_terminal_frame, set_term_frame_name): Print it.
4223 (x_report_frame_params): In X, window IDs are unsigned long,
4224 not signed long, so print them as unsigned.
4225 (validate_x_resource_name): Check for implausibly long names,
4226 and don't assume name length fits in 'int'.
4227 (x_get_resource_string): Don't blindly alloca invocation name;
4228 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4229 not fit in int.
4230
4231 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4232 (xg_check_special_colors, xg_set_geometry):
4233 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4234
4235 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4236 Use esprintf, not sprintf, in case result does not fit in int.
4237
4238 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4239 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4240 it as a large positive number.
4241 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4242 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4243
4244 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4245 in case result does not fit in int.
4246
4247 * print.c (float_to_string): Detect width overflow more reliably.
4248 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4249 buffer overrun. Don't assume list length fits in 'int'. Treat
4250 print length of 0 as 0, not as infinity; to be consistent with other
4251 uses of print length in this function. Don't overflow print length
4252 index. Don't assume hash table size fits in 'long', or that
4253 vectorlike size fits in 'unsigned long'.
4254
4255 * process.c (make_process): Use printmax_t, not int, to format
4256 process-name gensyms.
4257
4258 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4259
4260 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4261 to avoid potential buffer overrun.
4262
4263 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4264 if X resource line is longer than 512 bytes.
4265
4266 * xfns.c (x_window): Make sprintf buffer a bit bigger
4267 to avoid potential buffer overrun.
4268
4269 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4270
4271 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4272
4273 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4274
4275 Integer overflow fixes for scrolling, etc.
4276 Without these, Emacs silently mishandles large integers sometimes.
4277 For example, "C-u 4294967297 M-x recenter" was treated as if
4278 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4279
4280 * xdisp.c (try_window_id): Check Emacs fixnum range before
4281 converting to 'int'.
4282
4283 * window.c (window_scroll_line_based, Frecenter):
4284 Check that an Emacs fixnum is in range before assigning it to 'int'.
4285 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4286 values converted from Emacs fixnums.
4287 (Frecenter): Don't wrap around a line count if it is out of 'int'
4288 range; instead, treat it as an extreme value.
4289 (Fset_window_configuration, compare_window_configurations):
4290 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4291
4292 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4293 that can exceed INT_MAX. Check that EMACS_INT value is in range
4294 before assigning it to the (possibly-narrower) index.
4295 (match_limit): Don't assume that a fixnum can fit in 'int'.
4296
4297 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4298 exceed INT_MAX.
4299
4300 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4301 (Fvertical_motion): Don't wrap around LINES values that don't fit
4302 in 'int'. Instead, treat them as extreme values. This is good
4303 enough for windows, which can't have more than INT_MAX lines anyway.
4304
4305 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4306
4307 * Require libxml/parser.h to avoid compilation warning.
4308
4309 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4310
4311 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4312 since this reportedly can destroy thread storage.
4313
4314 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4315
4316 * syntax.c (find_defun_start): Update all cache variables if
4317 exiting early (Bug#9401).
4318
4319 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4320
4321 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4322
4323 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4324 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4325 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4326
4327 * term.c (tty_append_glyph): New function.
4328 (produce_stretch_glyph): Static function and its prototype deleted.
4329
4330 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4331 Add prototypes.
4332
4333 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4334
4335 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4336 when checking :margin (Bug#9390).
4337 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4338 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4339 so that the name doesn't mislead. All uses changed.
4340
4341 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4342
4343 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4344 set_tty_hooks.
4345
4346 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4347
4348 * xdisp.c (move_it_to): Don't bail out early when reaching
4349 position beyond to_charpos, if we are scanning backwards.
4350 (move_it_vertically_backward): When DY == 0, make sure we get to
4351 the first character in the line after the newline.
4352
4353 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4354
4355 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4356 (ccl_driver): Do not generate an out-of-range pointer.
4357 (Fccl_execute_on_string): Remove unnecessary check for
4358 integer overflow, noted by Stefan Monnier in
4359 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4360 Remove a FIXME that didn't need fixing.
4361 Simplify the newly-introduced buffer reallocation code.
4362
4363 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4364
4365 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4366
4367 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4368
4369 Integer and memory overflow issues (Bug#9196).
4370
4371 * doc.c (get_doc_string): Rework so that
4372 get_doc_string_buffer_size is the actual buffer size, rather than
4373 being 1 less than the actual buffer size; this makes xpalloc more
4374 convenient.
4375
4376 * image.c (x_allocate_bitmap_record, cache_image):
4377 * xselect.c (Fx_register_dnd_atom):
4378 Simplify previous changes by using xpalloc.
4379
4380 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4381 since either will do and ptrdiff_t is convenient with xpalloc.
4382
4383 * charset.c (charset_table_size)
4384 (struct charset_sort_data.priority): Now ptrdiff_t.
4385 (charset_compare): Don't overflow if priorities differ greatly.
4386 (Fsort_charsets): Don't assume list length fits in int.
4387 Check for size-calculation overflow when allocating sort data.
4388 (syms_of_charset): Allocate an initial charset table that is
4389 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4390
4391 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4392
4393 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4394 The actual value is always <= INT_MAX, and leaving it unsigned made
4395 overflow checking harder.
4396
4397 * dispextern.h (struct glyph_matrix.rows_allocated)
4398 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4399 with xpalloc. The values are still always <= INT_MAX.
4400
4401 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4402
4403 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4404 (SAFE_NALLOCA): New macro.
4405
4406 * region-cache.c (struct boundary.pos, find_cache_boundary)
4407 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4408 (set_cache_region, invalidate_region_cache)
4409 (revalidate_region_cache, know_region_cache, region_cache_forward)
4410 (region_cache_backward, pp_cache):
4411 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4412 so that ptrdiff_t * can be passed to xpalloc.
4413 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4414 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4415 (pp_cache): Don't assume cache_len fits in int.
4416 * region-cache.h: Adjust extern decls to match.
4417
4418 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4419 EMACS_INT, since either will do, for xpalloc.
4420
4421 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4422 (xnmalloc, xnrealloc, xpalloc): New functions.
4423
4424 * bidi.c (bidi_shelve_header_size): New constant.
4425 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4426 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4427
4428 * bidi.c (bidi_cache_shrink):
4429 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4430 (overlay_strings):
4431 Don't update size of array until after memory allocation succeeds,
4432 because xmalloc/xrealloc may not return.
4433 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4434 now that we have proper integer overflow checking.
4435 (record_overlay_string, overlay_strings): Catch overflows when
4436 calculating size of overlay_str_buf.
4437
4438 * callproc.c (Fcall_process): Check for size overflow when
4439 calculating size of args2.
4440 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4441 Normally we prefer signed values, but sticking with ptrdiff_t would
4442 require adding more-complicated checks.
4443
4444 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4445 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4446 Redo buffer-overflow calculations to avoid integer overflow.
4447 Add a FIXME comment where memory seems to be over-allocated.
4448
4449 * character.c (Fstring): Check for size-calculation overflow.
4450
4451 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4452 unnecessary integer overflow. Check for size overflow.
4453 (encode_coding_object): Don't update size until xmalloc succeeds.
4454
4455 * composite.c (get_composition_id): Check for overflow in glyph
4456 length calculations.
4457
4458 Integer and memory overflow fixes for display code.
4459 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4460 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4461 (scrolling_window): Check for overflow in size calculations.
4462 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4463 Don't assume glyph table len fits in int.
4464 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4465 (row_table_size): Now ptrdiff_t, not int.
4466 (scrolling_window): Avoid overflow in size calculations.
4467 Don't update size until allocation succeeds.
4468 * fns.c (concat): Check for overflow in size calculations.
4469 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4470 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4471 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4472
4473 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4474 (get_doc_string): Check for size calculation overflow.
4475 Don't update size until allocation succeeds.
4476 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4477 EMACS_INT, where ptrdiff_t will do.
4478 (Fsubstitute_command_keys): Check for string overflow.
4479
4480 * editfns.c (set_time_zone_rule): Don't assume environment length
4481 fits in int.
4482 (message_length): Now ptrdiff_t, not int.
4483 (Fmessage_box): Don't update size until allocation succeeds.
4484 Don't assume message length fits in int.
4485 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4486
4487 * emacs.c (main): Do not reallocate argv, since there is a null at
4488 the end that can be overwritten, and this way there's no need to
4489 worry about size-calculation overflow.
4490 (sort_args): Check for size-calculation overflow.
4491
4492 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4493 alloc succeeds.
4494 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4495
4496 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4497 (x_set_scroll_bar_width, x_figure_window_size):
4498 Check for integer overflow.
4499 (x_set_alpha): Do not assume XINT fits in int.
4500
4501 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4502 This is for the members text_lines, text_cols, total_lines, total_cols,
4503 where the system imposes an 'int' limit.
4504
4505 * fringe.c (Fdefine_fringe_bitmap):
4506 Don't update size until alloc works.
4507
4508 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4509 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4510
4511 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4512 Check for size-calculation overflow.
4513 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4514 do, as we prefer signed integers.
4515 (id_to_widget.max_size, id_to_widget.used)
4516 (xg_store_widget_in_map, xg_remove_widget_from_map)
4517 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4518 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4519 Use and return ptrdiff_t, not int.
4520 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4521 * gtkutil.h: Change prototypes to match the above.
4522
4523 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4524 are duplicate now that they've been promoted to lisp.h.
4525 (x_allocate_bitmap_record, x_alloc_image_color)
4526 (make_image_cache, cache_image, xpm_load):
4527 Don't update size until alloc is done.
4528 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4529 (x_detect_edges):
4530 Check for size calculation overflow.
4531 (ct_colors_allocated_max): New constant.
4532 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4533 overflow.
4534
4535 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4536 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4537 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4538 Use ptrdiff_t, not int, to count maps.
4539 (read_char_minibuf_menu_prompt): Check for overflow in size
4540 calculations. Don't update size until allocation succeeds.
4541 Redo calculations to avoid overflow.
4542 * keyboard.h: Change prototypes to match the above.
4543
4544 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4545 to count maps.
4546 (current_minor_maps): Check for size calculation overflow.
4547 * keymap.h: Change prototypes to match the above.
4548
4549 * lread.c (read1, init_obarray): Don't update size until alloc done.
4550
4551 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4552 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4553
4554 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4555 Now ptrdiff_t, not int.
4556 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4557 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4558
4559 * process.c (Fnetwork_interface_list): Check for overflow
4560 in size calculation.
4561
4562 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4563
4564 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4565 overflow. Don't bother calling xmalloc when xrealloc will do.
4566
4567 * search.c (Freplace_match): Check for size calculation overflow.
4568 (Fset_match_data): Don't assume list lengths fit in 'int'.
4569
4570 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4571 for command line length. Do not attempt to address one before the
4572 beginning of an array, as that's not portable.
4573
4574 * term.c (max_frame_lines): Remove; unused.
4575 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4576 not int.
4577 (encode_terminal_code, calculate_costs): Check for size
4578 calculation overflow.
4579 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4580 table lengths and related sizes. Don't update size until alloc
4581 done. Redo calculations to avoid overflow.
4582 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4583
4584 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4585 subtracting pointers.
4586 (gobble_line): Check for overflow more carefully. Don't update size
4587 until alloc done.
4588
4589 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4590 Don't update size until alloc done.
4591 Redo size calculations to avoid overflow.
4592 Check for size calculation overflow.
4593 (main) [DEBUG]: Fix typo in invoking tparam1.
4594
4595 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4596 Use ptrdiff_t, not int, for sizes.
4597 (store_mode_line_noprop_char): Don't update size until alloc done.
4598
4599 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4600 Use ptrdiff_t, not int, for sizes.
4601 (Finternal_make_lisp_face, cache_face):
4602 Check for size calculation overflow.
4603 (cache_face): Treat size calculation overflows as if they were
4604 memory exhaustion (the usual treatment), rather than aborting.
4605
4606 * xfns.c (x_encode_text, x_set_name_internal)
4607 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4608 sizes, since they can exceed INT_MAX in size. Check for size
4609 calculation overflow.
4610
4611 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4612 (xg_select): Check for size calculation overflow.
4613 Don't update size until alloc done.
4614
4615 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4616 as sprintf is limited to int lengths.
4617
4618 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4619 (X_LONG_MIN): New macros.
4620 Use them to make the following changes clearer.
4621 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4622 This change doesn't affect the value now, but it may help remind
4623 future maintainers not to raise the value too much later.
4624 (SELECTION_QUANTUM): Remove, replacing with ...
4625 (selection_quantum): ... new function, which avoids overflow.
4626 All uses changed.
4627 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4628 assumption that selection length fits in 'int'.
4629 (x_reply_selection_request, x_handle_selection_request)
4630 (x_get_window_property, receive_incremental_selection)
4631 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4632 (lisp_data_to_selection_data, clean_local_selection_data):
4633 Use ptrdiff_t, not int, to record length of selection.
4634 (x_reply_selection_request, x_get_window_property)
4635 (receive_incremental_selection, x_property_data_to_lisp):
4636 Redo calculations to avoid overflow.
4637 (x_reply_selection_request): When sending hint, ceiling it at
4638 X_LONG_MAX rather than relying on wraparound overflow to send
4639 something.
4640 (x_get_window_property, receive_incremental_selection)
4641 (lisp_data_to_selection_data, x_property_data_to_lisp):
4642 Check for size-calculation overflow.
4643 (x_get_window_property, receive_incremental_selection)
4644 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4645 Don't store size until memory allocation succeeds.
4646 (x_get_window_property): Plug memory leak on memory exhaustion.
4647 Don't double-block input; malloc is safe here. Don't assume 2**34
4648 - 4 fits in unsigned long. Add an xassert to check
4649 XGetWindowProperty overflow. Be more careful about overflow
4650 calculations, and distinguish size from memory overflow better.
4651 (receive_incremental_selection): When tracing, don't assume
4652 unsigned int is less than INT_MAX.
4653 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4654 harmful) conversions of unsigned short to int.
4655 (lisp_data_to_selection_data): Don't assume that integers
4656 in the range -65535 through -1 fit in an X unsigned short.
4657 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4658 result parameters unless successful. Rely on cons_to_unsigned
4659 to report problems with elements; the old code wasn't right anyway.
4660 (x_check_property_data): Check for int overflow; we cannot use
4661 a wider type due to X limits.
4662 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4663
4664 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4665
4666 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4667 (x_term_init): Check for size calculation overflow.
4668 (x_color_cells): Don't store size until memory allocation succeeds.
4669 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4670 Don't assume alloca size is less than MAX_ALLOCA.
4671 (x_term_init): Don't assume length fits in int (sprintf is limited
4672 to int size).
4673
4674 Use ptrdiff_t for composition IDs.
4675 * character.c (lisp_string_width):
4676 * composite.c (composition_table_size, n_compositions)
4677 (get_composition_id, composition_gstring_from_id):
4678 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4679 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4680 * window.c (Frecenter):
4681 Use ptrdiff_t, not int, for composition IDs.
4682 * composite.c (get_composition_id): Check for integer overflow.
4683 * composite.h: Adjust prototypes to match the above changes.
4684
4685 Use ptrdiff_t for hash table indexes.
4686 * category.c (hash_get_category_set):
4687 * ccl.c (ccl_driver):
4688 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4689 * coding.c (coding_system_charset_list, detect_coding_system):
4690 * coding.h (struct coding_system.id):
4691 * composite.c (get_composition_id, gstring_lookup_cache):
4692 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4693 * image.c (xpm_get_color_table_h):
4694 * lisp.h (hash_lookup, hash_put):
4695 * minibuf.c (Ftest_completion):
4696 Use ptrdiff_t for hash table indexes, not int (which is too
4697 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4698 32-bit --with-wide-int hosts).
4699
4700 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4701 Add a FIXME comment about memory leaks.
4702 (syms_of_charset): Don't assume xmalloc returns.
4703
4704 Don't assume that stated character widths fit in int.
4705 * character.c (Fchar_width, c_string_width, lisp_string_width):
4706 * character.h (CHAR_WIDTH):
4707 * indent.c (MULTIBYTE_BYTES_WIDTH):
4708 Use sanitize_char_width to avoid undefined and/or bad behavior
4709 with outlandish widths.
4710 * character.h (sanitize_tab_width): Rename from sanitize_width,
4711 now that we have two such functions. All uses changed.
4712 (sanitize_char_width): New inline function.
4713
4714 Don't assume that tab-width fits in int.
4715 * character.h (sanitize_width): New inline function.
4716 (SANE_TAB_WIDTH): New macro.
4717 (ASCII_CHAR_WIDTH): Use it.
4718 * indent.c (sane_tab_width): Remove. All uses replaced by
4719 SANE_TAB_WIDTH (current_buffer).
4720 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4721
4722 * fileio.c: Integer overflow issues with file modes.
4723 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4724
4725 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4726 Remove unreachable code.
4727 (read_hex, load_charset_map_from_file): Check for integer overflow.
4728
4729 * xterm.c: Don't go over XClientMessageEvent limit.
4730 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4731 (x_send_scroll_bar_event): Likewise. Check that the size does not
4732 exceed limits imposed by XClientMessageEvent, as well as the usual
4733 ptrdiff_t and size_t limits.
4734
4735 * keyboard.c: Overflow, signedness and related fixes.
4736 (make_lispy_movement): Use same integer type in forward decl
4737 that is used in the definition.
4738 (read_key_sequence, keyremap_step):
4739 Change bufsize argument back to int, undoing my 2011-03-30 change.
4740 We prefer signed types, and int is wide enough here.
4741 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4742 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4743 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4744 length, not size_t. Use ptrdiff_t for index, not int.
4745 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4746 possibility of integer overflow.
4747
4748 Overflow, signedness and related fixes for images.
4749
4750 * dispextern.h (struct it.stack[0].u.image.image_id)
4751 (struct_it.image_id, struct image.id, struct image_cache.size)
4752 (struct image_cache.used, struct image_cache.ref_count):
4753 * gtkutil.c (update_frame_tool_bar):
4754 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4755 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4756 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4757 * nsmenu.m (update_frame_tool_bar):
4758 * xdisp.c (calc_pixel_width_or_height):
4759 * xfns.c (image_cache_refcount):
4760 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4761 on typical 64-bit hosts.
4762
4763 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4764 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4765 Omit unnecessary casts to int.
4766 (parse_image_spec): Check that integers fall into 'int' range
4767 when the callers expect that.
4768 (image_ascent): Redo ascent calculation to avoid int overflow.
4769 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4770 (lookup_image): Remove unnecessary tests.
4771 (xbm_image_p): Locals are now of int, not EMACS_INT,
4772 since parse_image_check makes sure they fit into int.
4773 (png_load, gif_load, svg_load_image):
4774 Prefer int to unsigned where either will do.
4775 (tiff_handler): New function, combining the cores of the
4776 old tiff_error_handler and tiff_warning_handler.
4777 This function is rewritten to use vsnprintf and thereby avoid
4778 stack buffer overflows. It uses only the features of vsnprintf
4779 that are common to both POSIX and native Microsoft.
4780 (tiff_error_handler, tiff_warning_handler): Use it.
4781 (tiff_load, gif_load, imagemagick_load_image):
4782 Don't assume :index value fits in 'int'.
4783 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4784 (imagemagick_load_image): Check that crop parameters fit into
4785 the integer types that MagickCropImage accepts. Don't assume
4786 Vimagemagick_render_type has a nonnegative value. Don't assume
4787 size_t fits in 'long'.
4788 (gs_load): Use printmax_t to print the widest integers possible.
4789 Check for integer overflow when computing image height and width.
4790
4791 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4792
4793 * xdisp.c (redisplay_window): Don't force window start if point
4794 will be invisible in the resulting window. (Bug#9324)
4795
4796 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4797
4798 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4799 the display spec is of the form `(space ...)'.
4800 (handle_display_spec): Return the value returned by
4801 handle_single_display_spec, not just 1 or zero.
4802 (handle_single_display_spec): If the display spec is of the form
4803 `(space ...)', and specifies display in the text area, return 2
4804 rather than 1.
4805 (try_cursor_movement): Check for the need to scroll more
4806 accurately, and prefer exact match for point under bidi.
4807 Don't advance `row' beyond the last row of the window.
4808
4809 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4810 into disp_prop; all users changed.
4811
4812 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4813 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4814 for the text covered by the display property.
4815
4816 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4817
4818 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4819 Change return value to nil.
4820 (Frecord_buffer): Delete unused function.
4821
4822 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4823
4824 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4825 buffers, return left-to-right.
4826 (set_cursor_from_row): Consider candidate row a win if its glyph
4827 represents a newline and point is on that newline. Fixes cursor
4828 positioning on the newline at EOL of R2L text within L2R
4829 paragraph, and vice versa.
4830 (try_cursor_movement): Check continued rows, in addition to
4831 continuation rows. Fixes unwarranted scroll when point enters a
4832 continued line of R2L text within an L2R paragraph, or vice versa.
4833 (cursor_row_p): Consider the case of point being equal to
4834 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4835 from the end of a short line to the beginning of a continued line
4836 of R2L text within L2R paragraph.
4837 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4838 composed characters.
4839
4840 * bidi.c (bidi_check_type): Use xassert.
4841 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4842 members.
4843
4844 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4845
4846 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4847 a character.
4848
4849 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4850
4851 * nsfont.m (ns_otf_to_script): Fix typo.
4852
4853 2011-08-22 Kenichi Handa <handa@m17n.org>
4854
4855 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4856 extra slot even if the purpose is char-code-property-table.
4857
4858 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4859
4860 * xdisp.c (redisplay_window): When computing centering_position,
4861 account for the height of the header line. (Bug#8874)
4862
4863 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4864 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4865 candidate is selected by the mouse, and that candidate has a
4866 composed character under the mouse.
4867
4868 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4869 coordinates reported by pos-visible-in-window-p for a composed
4870 character in column zero.
4871
4872 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4873
4874 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4875
4876 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4877
4878 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4879 consider it a hit if to_charpos is anywhere in the range of the
4880 composed buffer positions.
4881
4882 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4883
4884 * image.c (gif_load): Don't assume that each subimage has the same
4885 dimensions as the base image. Handle disposal method that is
4886 "undefined" by the gif spec (Bug#9335).
4887
4888 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4889
4890 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4891 (Fcondition_case): Document `debug' symbol in error handler.
4892
4893 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4894
4895 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4896 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4897 from an Org mode buffer to a Speedbar frame.
4898
4899 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4900 a composition, take its buffer position from IT->cmp_it.charpos.
4901 Fixes cursor positioning at the beginning of a line that begins
4902 with a composed character.
4903
4904 2011-08-18 Eli Zaretskii <eliz@gnu.org>
4905
4906 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4907 character bidirectional type, use STRONG_L instead. Fixes crashes
4908 in a buffer produced by `describe-categories'.
4909
4910 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4911 members before the level stack, so they would be saved and
4912 restored when copying iterator state. Fixes incorrect reordering
4913 around TABs covered by display properties.
4914
4915 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4916
4917 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
4918
4919 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
4920
4921 * eval.c (internal_condition_case, internal_condition_case_1)
4922 (internal_condition_case_2, internal_condition_case_n):
4923 Remove unnecessary aborts (Bug#9081).
4924
4925 2011-08-17 Eli Zaretskii <eliz@gnu.org>
4926
4927 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4928 has no `load' handler, try opening the file locally. (Bug#9311)
4929
4930 2011-08-16 Ken Brown <kbrown@cornell.edu>
4931
4932 * gmalloc.c: Expand comment.
4933
4934 2011-08-16 Eli Zaretskii <eliz@gnu.org>
4935
4936 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4937 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4938
4939 2011-08-16 Ken Brown <kbrown@cornell.edu>
4940
4941 Fix memory allocation problems in Cygwin build (Bug#9273).
4942
4943 * unexcw.c ( __malloc_initialized): Declare external variable.
4944 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4945
4946 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4947 New variables.
4948 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4949 dumped emacs.
4950 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4951 in the static heap.
4952 [CYGWIN] (special_realloc): New function.
4953 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4954 requests to realloc storage in the static heap.
4955
4956 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4957
4958 * bidi.c (bidi_initialize): Remove unused local.
4959
4960 2011-08-15 Eli Zaretskii <eliz@gnu.org>
4961
4962 * bidimirror.h:
4963 * biditype.h: Remove file.
4964 * makefile.w32-in ($(BLD)/bidi.$(O)):
4965 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
4966
4967 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4968
4969 * chartab.c: Improve commentary for the uniprop_table API.
4970
4971 * bidi.c (bidi_paragraph_init): Support zero value of
4972 bidi_ignore_explicit_marks_for_paragraph_level.
4973 (bidi_initialize): Use uniprop_table instead of including
4974 biditype.h and bidimirror.h.
4975
4976 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4977 coordinates of the iterator when restoring from ppos_it.
4978 (Bug#9296)
4979
4980 2011-08-14 Kenichi Handa <handa@m17n.org>
4981
4982 * process.c (create_process): Call setup_process_coding_systems
4983 after the pid of the process is set to -1 (Bug#8162).
4984
4985 2011-08-14 Eli Zaretskii <eliz@gnu.org>
4986
4987 * xdisp.c (move_it_in_display_line_to): Don't invoke
4988 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4989 ppos_it. Fixes vertical cursor motion when line beginning is
4990 covered by an image. (Bug#9296)
4991
4992 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4993
4994 * nsterm.h (ns_run_ascript): Declare.
4995 (NSAPP_DATA2_RUNASSCRIPT): Define.
4996
4997 * nsfns.m (as_script, as_result, as_status): New static variables.
4998 (ns_run_ascript): New function.
4999 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5000 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5001 the event loop. Get status from as_status (Bug#7276).
5002
5003 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5004 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5005 the event loop (Bug#7276).
5006
5007 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5008
5009 * gnutls.c (QCgnutls_bootprop_priority)
5010 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5011 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5012 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5013 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5014 (QCgnutls_bootprop_verify_hostname_error)
5015 (QCgnutls_bootprop_callbacks_verify): Rename from
5016 Qgnutls_bootprop_..., all uses changed.
5017
5018 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5019 uses changed.
5020
5021 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5022
5023 * xfaces.c (Qframe_set_background_mode): Now static.
5024 * dispextern.h (Qframe_set_background_mode): Remove decl.
5025
5026 * process.c (Fnetwork_interface_info): Declare local only if needed.
5027
5028 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5029
5030 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5031 (Fnetwork_interface_list): Allocate in increments of bytes instead
5032 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5033 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5034 sockaddr.
5035 (struct ifflag_def): notrailers is smart on OSX.
5036 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5037 Get hardware address with getifaddrs if available.
5038
5039 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5040
5041 * xdisp.c (iterate_out_of_display_property): xassert that
5042 IT->position is set to within IT->object's boundaries. Break from
5043 the loop as soon as EOB is reached; avoids infloops in redisplay
5044 when IT->position is set up wrongly due to some bug.
5045 Set IT->current to match the bidi iterator unconditionally.
5046 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5047 entry. Force push_it to save on the stack the current
5048 buffer/string position, to be restored by pop_it. Fix flags in
5049 the iterator structure wrt the object coming from a display
5050 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5051 properties. (Bug#9284)
5052
5053 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5054
5055 * fontset.c (fontset_get_font_group): Add proper type checks.
5056 (Bug#9172)
5057
5058 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5059
5060 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5061 and LC_VERSION_MIN_MACOSX.
5062 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5063 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5064
5065 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5066
5067 * xdisp.c (forward_to_next_line_start): Allow to use the
5068 no-display-properties-and-no-overlays under bidi display.
5069 Set disp_pos in the bidi iterator to avoid searches for display
5070 properties and overlays.
5071
5072 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5073
5074 * editfns.c (Fset_time_zone_rule): Document relationship with the
5075 setenv function.
5076
5077 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5078 the font entity extracted from the cache (Bug#8109).
5079
5080 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5081
5082 * composite.c (autocmp_chars): Don't reset point. That is done by
5083 restore_point_unwind (Bug#5984).
5084
5085 2011-08-07 Juri Linkov <juri@jurta.org>
5086
5087 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5088 to show the arg `TIME' instead of `TIMEVAL'.
5089
5090 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5091
5092 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5093 display property strides EOL and includes a newline, as in
5094 longlines-mode. (Bug#9254)
5095 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5096 word-wrap under bidirectional display. (Bug#9224)
5097
5098 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5099 is non-zero, even if the data buffer is NULL. Fixes a crash in
5100 vertical-motion with longlines-mode. (Bug#9254)
5101
5102 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5103
5104 * bidi.c <bidi_cache_total_alloc>: Now static.
5105 (bidi_initialize): Initialize bidi_cache_total_alloc.
5106
5107 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5108 cache. (Bug#9221)
5109
5110 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5111 amount allocated this far in `bidi_cache_total_alloc'.
5112 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5113 non-zero, only free the data buffer without restoring the cache
5114 contents. All callers changed.
5115
5116 * dispextern.h (bidi_unshelve_cache): Update prototype.
5117
5118 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5119 (move_it_in_display_line, move_it_to)
5120 (move_it_vertically_backward, move_it_by_lines): Replace the call
5121 to xfree to an equivalent call to bidi_unshelve_cache.
5122 (move_it_in_display_line_to): Fix logic of returning
5123 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5124
5125 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5126
5127 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5128 came from a string character with a `cursor' property. (Bug#9229)
5129
5130 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5131
5132 * Makefile.in (LIB_PTHREAD): New variable.
5133 (LIBES): Add LIB_PTHREAD (Bug#9216).
5134
5135 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5136 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5137
5138 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5139
5140 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5141
5142 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5143
5144 * xterm.c (x_find_topmost_parent): New function.
5145 (x_set_frame_alpha): Find topmost parent window with
5146 x_find_topmost_parent and set the property there also (bug#9181).
5147 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5148
5149 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5150
5151 * callproc.c (Fcall_process): Avoid vfork clobbering
5152 the local vars buffer, coding_systems, current_dir.
5153
5154 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5155
5156 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5157
5158 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5159
5160 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5161 so that it is not optimized away.
5162
5163 * xdisp.c (compute_display_string_pos): Remove unused local.
5164
5165 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5166
5167 Fix slow cursor motion and scrolling in large buffers with
5168 selective display, like Org Mode buffers. (Bug#9218)
5169
5170 * dispextern.h (struct bidi_it): New member disp_prop_p.
5171
5172 * xdisp.c: Remove one-slot cache of display string positions.
5173 (compute_display_string_pos): Accept an additional argument
5174 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5175 for a display string or property. If found, set DISP_PROP_P
5176 non-zero.
5177
5178 * bidi.c (bidi_fetch_char): Accept an additional argument
5179 DISP_PROP_P, and pass it to compute_display_string_pos.
5180 Only handle text covered by a display string if DISP_PROP_P is returned
5181 non-zero. All callers of bidi_fetch_char changed.
5182
5183 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5184
5185 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5186
5187 2010-12-03 Don March <don@ohspite.net>
5188
5189 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5190 last character M-[char] is translated to ESC [char] (bug#7541).
5191
5192 2011-08-02 Kenichi Handa <handa@m17n.org>
5193
5194 * lisp.h (uniprop_table): Extern it.
5195
5196 * chartab.c (uniprop_table): Make it non-static.
5197
5198 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5199
5200 * xdisp.c (forward_to_next_line_start): Accept additional argument
5201 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5202 on the newline.
5203 (reseat_at_next_visible_line_start): Use the bidi iterator state
5204 returned by forward_to_next_line_start to restore the state of
5205 it->bidi_it after backing up to previous newline. (Bug#9212)
5206
5207 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5208
5209 * regex.c (re_comp): Protoize.
5210 (re_exec): Fix return type.
5211 (regexec): Fix type of `ret'. (Bug#9203)
5212
5213 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5214
5215 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5216 This is needed if max-image-size is a floating-point number.
5217
5218 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5219
5220 * print.c (print_object): Print empty symbol as ##.
5221
5222 * lread.c (read1): Read ## as empty symbol.
5223
5224 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5225
5226 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5227 setting frame foreground color (Bug#9175).
5228 (x_set_background_color): Likewise.
5229
5230 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5231 contents (Bug#9176).
5232 (EmacsTooltip -init): Remove bezels and add shadows to
5233 tooltip windows.
5234
5235 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5236 or scroll bar (Bug#8470).
5237
5238 * nsfont.m (nsfont_open): Remove assignment to voffset and
5239 unnecessary vars hshink, expand, hd, full_height, min_height.
5240 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5241
5242 * nsterm.h (nsfont_info): Remove voffset field.
5243
5244 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5245
5246 Implement strike-through and overline on NextStep (Bug#8863).
5247
5248 * nsfont.m (nsfont_open): Use underline position provided by font,
5249 instead of hard-coded value of 2.
5250 (nsfont_draw): Call ns_draw_text_decoration instead.
5251
5252 * nsterm.h: Add declaration for ns_draw_text_decoration.
5253
5254 * nsterm.m (ns_draw_text_decoration): New function for drawing
5255 underline, overline, and strike-through.
5256 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5257 ns_draw_text_decoration. Change treatment of cursor drawing to
5258 accommodate underlining, etc.
5259
5260 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5261
5262 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5263 default.
5264
5265 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5266
5267 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5268 Without this fix, if a signal arrives just after memory fills up,
5269 'malloc' might be invoked reentrantly.
5270
5271 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5272 In other words, assume that every image size is allowed, on non-X
5273 hosts. This assumption is probably wrong, but it lets Emacs compile.
5274
5275 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5276
5277 * regex.c (re_iswctype): Convert return values to boolean.
5278
5279 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5280
5281 * xdisp.c (compute_display_string_pos): Don't use cached display
5282 string position if the buffer had its restriction changed.
5283 (Bug#9184)
5284
5285 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5286
5287 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5288
5289 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5290
5291 Integer signedness and overflow and related fixes. (Bug#9079)
5292
5293 * bidi.c: Integer size and overflow fixes.
5294 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5295 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5296 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5297 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5298 (bidi_find_other_level_edge):
5299 Use ptrdiff_t instead of EMACS_INT where either will do.
5300 This works better on 32-bit hosts configured --with-wide-int.
5301 (bidi_cache_ensure_space): Check for size-calculation overflow.
5302 Use % rather than repeated addition, for better worst-case speed.
5303 Don't set bidi_cache_size until after xrealloc returns, because it
5304 might not return.
5305 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5306 (bidi_cache_ensure_space): Also check that the bidi cache size
5307 does not exceed that of the largest Lisp string or buffer. See Eli
5308 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5309
5310 * alloc.c (__malloc_size_t): Remove.
5311 All uses replaced by size_t. See Andreas Schwab's note
5312 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5313
5314 * image.c: Improve checking for integer overflow.
5315 (check_image_size): Assume that f is nonnull, since
5316 it is always nonnull in practice. This is one less thing to
5317 worry about when checking for integer overflow later.
5318 (x_check_image_size): New function, which checks for integer
5319 overflow issues inside X.
5320 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5321 This removes the need for a memory_full check.
5322 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5323 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5324 (xbm_read_bitmap_data): Change locals back to 'int', since
5325 their values must fit in 'int'.
5326 (xpm_load_image, png_load, tiff_load):
5327 Invoke x_create_x_image_and_pixmap earlier,
5328 to avoid much needless work if the image is too large.
5329 (tiff_load): Treat overly large images as if
5330 x_create_x_image_and_pixmap failed, not as malloc failures.
5331 (gs_load): Use x_check_image_size.
5332
5333 * gtkutil.c: Omit integer casts.
5334 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5335 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5336
5337 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5338
5339 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5340 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5341 would wrongly return t on a 64-bit host.
5342
5343 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5344 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5345 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5346 and therefore cause GCC to emit a bogus diagnostic in some cases.
5347
5348 * image.c: Integer signedness and overflow and related fixes.
5349 This is not an exhaustive set of fixes, but it's time to
5350 record what I've got.
5351 (lookup_pixel_color, check_image_size): Remove redundant decls.
5352 (check_image_size): Don't assume that arbitrary EMACS_INT values
5353 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5354 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5355 (tiff_load, imagemagick_load_image):
5356 Check for overflow in size calculations.
5357 (x_create_x_image_and_pixmap): Remove unnecessary test for
5358 xmalloc returning NULL; that can't happen.
5359 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5360 (xpm_color_bucket): Use better integer hashing function.
5361 (xpm_cache_color): Don't possibly over-allocate memory.
5362 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5363 (gif_memory_source):
5364 Use ptrdiff_t, not int or size_t, to record sizes.
5365 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5366 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5367 either works, as we prefer signed integers.
5368 (tiff_read_from_memory, tiff_write_from_memory):
5369 Return tsize_t, not size_t, since that's what the TIFF API wants.
5370 (tiff_read_from_memory): Don't fail simply because the read would
5371 go past EOF; instead, return a short read.
5372 (tiff_load): Omit no-longer-needed casts.
5373 (Fimagemagick_types): Don't assume size fits into 'int'.
5374
5375 Improve hashing quality when configured --with-wide-int.
5376 * fns.c (hash_string): New function, taken from sxhash_string.
5377 Do not discard information about ASCII character case; this
5378 discarding is no longer needed.
5379 (sxhash-string): Use it. Change sig to match it. Caller changed.
5380 * lisp.h: Declare it.
5381 * lread.c (hash_string): Remove, since we now use fns.c's version.
5382 The fns.c version returns a wider integer if --with-wide-int is
5383 specified, so this should help the quality of the hashing a bit.
5384
5385 * emacs.c: Integer overflow minor fix.
5386 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5387 Define only if GNU_LINUX.
5388 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5389
5390 * dispnew.c: Integer signedness and overflow fixes.
5391 Remove unnecessary forward decls, that were a maintenance hassle.
5392 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5393 All uses changed.
5394 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5395 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5396 (prepare_desired_row, line_draw_cost):
5397 Use int, not unsigned, where either works.
5398 (save_current_matrix, restore_current_matrix):
5399 Use ptrdiff_t, not size_t, where either works.
5400 (init_display): Check for overflow more accurately, and without
5401 relying on undefined behavior.
5402
5403 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5404 Remove, replacing with the new symbols in lisp.h. All uses changed.
5405 * fileio.c (make_temp_name):
5406 * filelock.c (lock_file_1, lock_file):
5407 * xdisp.c (message_dolog):
5408 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5409 Use pMd etc. instead.
5410 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5411 replacing the pWIDE etc. symbols removed from editfns.c.
5412
5413 * keyboard.h (num_input_events): Now uintmax_t.
5414 This is (very slightly) less likely to mess up due to wraparound.
5415 All uses changed.
5416
5417 * buffer.c: Integer signedness fixes.
5418 (alloc_buffer_text, enlarge_buffer_text):
5419 Use ptrdiff_t rather than size_t when either will do, as we prefer
5420 signed integers.
5421
5422 * alloc.c: Integer signedness and overflow fixes.
5423 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5424 (__malloc_size_t): Default to size_t, not to int.
5425 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5426 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5427 Prefer ptrdiff_t to size_t when either would do, as we prefer
5428 signed integers.
5429 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5430 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5431 Now const. Initialize with values that are in range even if char
5432 is signed.
5433 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5434 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5435 These functions do the right thing with sizes > 2**32.
5436 (check_depth): Now ptrdiff_t, not int.
5437 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5438 Adjust to new way of storing sizes. Check for size overflow bugs
5439 in rest of code.
5440 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5441 slightly wrong anyway, as it missed one instance of
5442 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5443 (refill_memory_reserve): Omit needless cast to size_t.
5444 (mark_object_loop_halt): Mark as externally visible.
5445
5446 * xselect.c: Integer signedness and overflow fixes.
5447 (Fx_register_dnd_atom, x_handle_dnd_message):
5448 Use ptrdiff_t, not size_t, since we prefer signed.
5449 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5450 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5451 x_dnd_atoms_size and x_dnd_atoms_length.
5452
5453 * doprnt.c: Prefer signed to unsigned when either works.
5454 * eval.c (verror):
5455 * doprnt.c (doprnt):
5456 * lisp.h (doprnt):
5457 * xdisp.c (vmessage):
5458 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5459 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5460 prefer signed arithmetic to avoid comparison confusion.
5461 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5462 but is a bit tricky.
5463
5464 Assume freestanding C89 headers, string.h, stdlib.h.
5465 * data.c, doprnt.c, floatfns.c, print.c:
5466 Include float.h unconditionally.
5467 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5468 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5469 * regex.c: Likewise for stddef.h, string.h.
5470 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5471 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5472 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5473 (STDC_HEADERS): Remove obsolete defines.
5474 * sysdep.c: Include limits.h unconditionally.
5475
5476 Assume support for memcmp, memcpy, memmove, memset.
5477 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5478 * regex.c (memcmp, memcpy):
5479 Remove; we assume C89 now.
5480
5481 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5482 (__malloc_safe_bcopy): Remove; no longer needed.
5483
5484 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5485 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5486 well either way, and we prefer signed to unsigned.
5487
5488 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5489
5490 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5491 closes the connection while we're reading (bug#9182).
5492
5493 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5494
5495 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5496 are specified (Bug#9168).
5497
5498 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5499
5500 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5501 Found by GCC static checking and --with-wide-int on a 32-bit host.
5502
5503 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5504
5505 * xdisp.c (compute_display_string_pos): Fix logic of caching
5506 previous display string position. Initialize cached_prev_pos to
5507 -1. Fixes slow-down at the beginning of a buffer.
5508
5509 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5510
5511 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5512 for attrs[LFACE_FONTSET_INDEX].
5513
5514 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5515
5516 * xml.c (parse_region): Remove unused local
5517 that was recently introduced.
5518
5519 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5520
5521 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5522 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5523
5524 * xdisp.c (move_it_in_display_line_to): Record the best matching
5525 position for TO_CHARPOS while scanning the line, and restore it on
5526 exit if none of the characters scanned was an exact match.
5527 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5528 when exact match is impossible due to invisible text, and the
5529 lines are truncated.
5530
5531 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5532
5533 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5534 for OSX >= 10.7.
5535
5536 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5537
5538 Fix a significant slow-down of cursor motion with C-n, C-p,
5539 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5540 auto-repeat under bidi redisplay in fontified buffers.
5541 * xdisp.c (compute_stop_pos_backwards): New function.
5542 (next_element_from_buffer): Call compute_stop_pos_backwards to
5543 find a suitable prev_stop when we find ourselves before
5544 base_level_stop.
5545 (reseat): Don't look for prev_stop, as that could mean a very long
5546 run.
5547 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5548 <cached_disp_overlay_modiff>: Cache for last found display string
5549 position.
5550 (compute_display_string_pos): Return the cached position if asked
5551 about the same buffer in the same area of character positions, and
5552 the buffer wasn't changed since the time the display string
5553 position was cached.
5554
5555 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5556
5557 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5558 is an integer, which is important for empty lines. (Bug#9149)
5559
5560 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5561
5562 * frame.c (Fmodify_frame_parameters): In tty case, update the
5563 default face if necessary (Bug#4238).
5564
5565 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5566
5567 * editfns.c (Fstring_to_char): No need to explain what a character
5568 is in the docstring (Bug#6576).
5569
5570 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5571
5572 * xml.c (parse_region): Make sure we always return a tree.
5573
5574 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5575
5576 * xml.c (parse_region): If a document contains only comments,
5577 return that, too.
5578
5579 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5580
5581 * xml.c (make_dom): Return comments, too.
5582
5583 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5584
5585 Port to OpenBSD.
5586 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5587 and the surrounding thread.
5588 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5589 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5590 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5591 timer goes off.
5592 * s/openbsd.h (BROKEN_SIGIO): Define.
5593 * unexelf.c (unexec) [__OpenBSD__]:
5594 Don't update the .mdebug section of the Alpha COFF symbol table.
5595
5596 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5597
5598 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5599 (bug#8460).
5600
5601 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5602
5603 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5604 This fixes some race conditions on the permissions of any newly
5605 created file.
5606
5607 * alloc.c (valid_pointer_p): Use pipe, not open.
5608 This fixes some permissions issues when debugging.
5609
5610 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5611 If fchown fails to set both uid and gid, try to set just gid,
5612 as that is sometimes allowed. Adjust the file's mode to eliminate
5613 setuid or setgid bits that are inappropriate if fchown fails.
5614
5615 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5616
5617 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5618 to compare Lisp_Objects.
5619 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5620 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5621 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5622
5623 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5624
5625 * lread.c (read_integer): Unread even EOF character.
5626 (read1): Likewise. Properly record start position of symbol.
5627
5628 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5629 symbol character follows.
5630
5631 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5632
5633 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5634 This works around a problem with the previous change to Fcopy_file.
5635 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5636 and without this change, GCC might complain about discarding
5637 fchown's return value.
5638
5639 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5640
5641 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5642
5643 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5644
5645 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5646
5647 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5648
5649 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5650 it's used from the C level.
5651
5652 * process.c: Use the same condition for POLL_FOR_INPUT in both
5653 keyboard.c and process.c (bug#1858).
5654
5655 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5656
5657 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5658 (Fgnutls_boot): Use it.
5659
5660 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5661
5662 * doc.c (Fsubstitute_command_keys): Revert last change.
5663
5664 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5665
5666 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5667 quotes the next character, and doesn't affect other longer
5668 sequences (bug#8935).
5669
5670 * lread.c (syms_of_lread): Clarify that is isn't only
5671 `eval-buffer' and `eval-defun' that's affected by
5672 `lexical-binding' (bug#8460).
5673
5674 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5675
5676 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5677 bidi redisplay when a line includes both an image and is truncated.
5678
5679 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5680
5681 Fix minor problems found by static checking.
5682 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5683 (elsz): Now a signed constant, not a size_t var. We prefer signed
5684 types to unsigned, to avoid integer comparison confusion. Without
5685 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5686 "cannot optimize loop, the loop counter may overflow", a symptom
5687 of the confusion.
5688 * indent.c (Fvertical_motion): Mark locals as initialized.
5689 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5690
5691 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5692
5693 * search.c (Fre_search_backward): Mention `case-fold-search' in
5694 all the re_search_* functions (bug#8138).
5695
5696 * keyboard.c (Fopen_dribble_file): Document when the file is
5697 closed (bug#8056).
5698
5699 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5700
5701 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5702 bidi_cache_idx.
5703
5704 Support bidi reordering of display and overlay strings.
5705 * xdisp.c (compute_display_string_pos)
5706 (compute_display_string_end): Accept additional argument STRING.
5707 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5708 (reseat_to_string): Initialize bidi_it->string.s and
5709 bidi_it->string.schars.
5710 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5711 NULL (avoids a crash in bidi_paragraph_init).
5712 Initialize itb.string.lstring.
5713 (init_iterator): Call bidi_init_it only of a valid
5714 buffer position was specified. Initialize paragraph_embedding to
5715 L2R.
5716 (reseat_to_string): Initialize the bidi iterator.
5717 (display_string): If we need to ignore text properties of
5718 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5719 original value of -1 will not work with bidi.)
5720 (compute_display_string_pos): First arg is now struct
5721 `text_pos *'; all callers changed. Support display properties on
5722 Lisp strings.
5723 (compute_display_string_end): Support display properties on Lisp
5724 strings.
5725 (init_iterator, reseat_1, reseat_to_string): Initialize the
5726 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5727 when iterating on a string not from display properties).
5728 (compute_display_string_pos, compute_display_string_end):
5729 Fix calculation of the object to scan. Fixes an error when using
5730 arrow keys.
5731 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5732 base_level_stop; instead, set base_level_stop to BEGV.
5733 Fixes crashes in vertical-motion.
5734 (next_element_from_buffer): Improve commentary for when
5735 the iterator is before prev_stop.
5736 (init_iterator): Initialize bidi_p from the default value of
5737 bidi-display-reordering, not from buffer-local value. Use the
5738 buffer-local value only if initializing for buffer iteration.
5739 (handle_invisible_prop): Support invisible properties on strings
5740 that are being bidi-reordered.
5741 (set_iterator_to_next): Support bidi reordering of C strings and
5742 Lisp strings.
5743 (next_element_from_string): Support bidi reordering of Lisp
5744 strings.
5745 (handle_stop_backwards): Support Lisp strings as well.
5746 (display_string): Support display of R2L glyph rows.
5747 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5748 (init_iterator): Don't initialize it->bidi_p for strings
5749 here.
5750 (reseat_to_string): Initialize it->bidi_p for strings here.
5751 (next_element_from_string, next_element_from_c_string)
5752 (next_element_from_buffer): Add xassert's for correspondence
5753 between IT's object being iterated and it->bidi_it.string
5754 structure.
5755 (face_before_or_after_it_pos): Support bidi iteration.
5756 (next_element_from_c_string): Handle the case of the first string
5757 character that is not the first one in the visual order.
5758 (get_visually_first_element): New function, refactored from common
5759 parts of next_element_from_buffer, next_element_from_string, and
5760 next_element_from_c_string.
5761 (tool_bar_lines_needed, redisplay_tool_bar)
5762 (display_menu_bar): Force left-to-right direction. Add a FIXME
5763 comment for making that be controlled by a user option.
5764 (push_it, pop_it): Save and restore the state of the
5765 bidi iterator. Save and restore the bidi_p flag.
5766 (pop_it): Iterate out of display property for string iteration as
5767 well.
5768 (iterate_out_of_display_property): Support iteration over strings.
5769 (handle_single_display_spec): Set up it->bidi_it for iteration
5770 over a display string, and call bidi_init_it.
5771 (handle_single_display_spec, next_overlay_string)
5772 (get_overlay_strings_1, push_display_prop): Set up the bidi
5773 iterator for displaying display or overlay strings.
5774 (forward_to_next_line_start): Don't use the shortcut if
5775 bidi-iterating.
5776 (back_to_previous_visible_line_start): If handle_display_prop
5777 pushed the iterator stack, restore the internal state of the bidi
5778 iterator by calling bidi_pop_it same number of times.
5779 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5780 and we are bidi-iterating, don't decrement the iterator position;
5781 instead, set the first_elt flag in the bidi iterator, to produce
5782 the same effect.
5783 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5784 (push_display_prop): xassert that we are iterating a buffer.
5785 (push_it, pop_it): Save and restore paragraph_embedding member.
5786 (handle_single_display_spec, next_overlay_string)
5787 (get_overlay_strings_1, reseat_1, reseat_to_string)
5788 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5789 correctly. Don't assume unibyte strings are not bidi-reordered.
5790 (compute_display_string_pos)
5791 (compute_display_string_end): Fix handling the case of C string.
5792 (push_it, pop_it): Save and restore from_disp_prop_p.
5793 (handle_single_display_spec, push_display_prop): Set the
5794 from_disp_prop_p flag.
5795 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5796 (pop_it): Call iterate_out_of_display_property only if we are
5797 popping after iteration over a string that came from a display
5798 property. Fix a typo in popping stretch info. Add an assertion
5799 for verifying that the iterator position is in sync with the bidi
5800 iterator.
5801 (handle_single_display_spec, get_overlay_strings_1)
5802 (push_display_prop): Fix initialization of paragraph direction for
5803 string when that of the parent object is not yet determined.
5804 (reseat_1): Call bidi_init_it to resync the bidi
5805 iterator with IT's position. (Bug#7616)
5806 (find_row_edges): If ROW->start.pos gives position
5807 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5808 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5809 Reset the from_disp_prop_p flag.
5810 (SAVE_IT, RESTORE_IT): New macros.
5811 (pos_visible_p, face_before_or_after_it_pos)
5812 (back_to_previous_visible_line_start)
5813 (move_it_in_display_line_to, move_it_in_display_line)
5814 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5815 (try_scrolling, redisplay_window, display_line): Use them when
5816 saving a temporary copy of the iterator and restoring it back.
5817 (back_to_previous_visible_line_start, reseat_1)
5818 (init_iterator): Empty the bidi cache "stack".
5819 (move_it_in_display_line_to): If iterator ended up at
5820 EOL, but we never saw any buffer positions smaller than
5821 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5822 motion in bidi-reordered lines.
5823 (move_it_in_display_line_to): Record prev_method and prev_pos
5824 immediately before the call to set_iterator_to_next. Fixes cursor
5825 motion in bidi-reordered lines with stretch glyphs and strings
5826 displayed in margins. (Bug#8133) (Bug#8867)
5827 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5828 TO_CHARPOS.
5829 (pos_visible_p): Support positions in bidi-reordered lines.
5830 Save and restore bidi cache.
5831
5832 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5833 (bidi_paragraph_info): Delete unused struct.
5834 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5835 (bidi_cache_start): New variable.
5836 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5837 to zero.
5838 (bidi_cache_fetch_state, bidi_cache_search)
5839 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5840 (bidi_cache_find, bidi_peek_at_next_level)
5841 (bidi_level_of_next_char, bidi_find_other_level_edge)
5842 (bidi_move_to_visually_next): Compare cache index with
5843 bidi_cache_start rather than with zero.
5844 (bidi_fetch_char): Accept new argument STRING; all callers
5845 changed. Support iteration over a string. Support strings with
5846 display properties. Support unibyte strings. Fix the type of
5847 `len' according to what STRING_CHAR_AND_LENGTH expects.
5848 (bidi_paragraph_init, bidi_resolve_explicit_1)
5849 (bidi_resolve_explicit, bidi_resolve_weak)
5850 (bidi_level_of_next_char, bidi_move_to_visually_next):
5851 Support iteration over a string.
5852 (bidi_set_sor_type, bidi_resolve_explicit_1)
5853 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5854 can now be zero (for strings); special values 0 and -1 were
5855 changed to -1 and -2, respectively.
5856 (bidi_char_at_pos): New function.
5857 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5858 Call it instead of FETCH_MULTIBYTE_CHAR.
5859 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5860 initialized to valid values.
5861 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5862 values.
5863 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5864 the test for valid cached positions. Fix the logic for looking up
5865 the sentinel state in the cache. GCPRO the Lisp string we are
5866 iterating.
5867 (bidi_push_it, bidi_pop_it): New functions.
5868 (bidi_initialize): Initialize the bidi cache start stack pointer.
5869 (bidi_cache_ensure_space): New function, refactored from part of
5870 bidi_cache_iterator_state. Don't assume the required size is just
5871 one BIDI_CACHE_CHUNK away.
5872 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5873 (bidi_count_bytes, bidi_char_at_pos): New functions.
5874 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5875 always valid if bidi_cache_idx is valid.
5876 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5877 is valid if it's going to be used.
5878 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5879 (bidi_cache_fetch_state, bidi_cache_search)
5880 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5881 (bidi_cache_iterator_state, bidi_cache_find)
5882 (bidi_find_other_level_edge, bidi_cache_start_stack):
5883 All variables related to cache indices are now EMACS_INT.
5884
5885 * dispextern.h (struct bidi_string_data): New structure.
5886 (struct bidi_it): New member `string'. Make flag members be 1-bit
5887 fields, and put them last in the struct.
5888 (compute_display_string_pos, compute_display_string_end):
5889 Update prototypes.
5890 (bidi_push_it, bidi_pop_it): Add prototypes.
5891 (struct iterator_stack_entry): New members bidi_p,
5892 paragraph_embedding, and from_disp_prop_p.
5893 (struct it): Member bidi_p is now a bit field 1 bit wide.
5894 (bidi_shelve_cache, bidi_unshelve_cache):
5895 Declare prototypes.
5896
5897 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5898 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5899 and vector-like objects.
5900
5901 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5902 cache around display iteration.
5903
5904 * window.c (Fwindow_end, window_scroll_pixel_based)
5905 (displayed_window_lines, Frecenter): Save and restore the bidi
5906 cache around display iteration.
5907
5908 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5909
5910 * editfns.c (Fdelete_region): Clarify the use of the named
5911 parameters (bug#6788).
5912
5913 2011-07-14 Martin Rudalics <rudalics@gmx.at>
5914
5915 * indent.c (Fvertical_motion): Set and restore w->pointm when
5916 saving and restoring the window's buffer (Bug#9006).
5917
5918 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5919
5920 * editfns.c (Fstring_to_char): Clarify just what is returned
5921 (bug#6576). Text by Eli Zaretskii.
5922
5923 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
5924
5925 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5926
5927 2011-07-13 Eli Zaretskii <eliz@gnu.org>
5928
5929 * buffer.c (mmap_find): Fix a typo.
5930
5931 2011-07-13 Johan Bockgård <bojohan@gnu.org>
5932
5933 Fix execution of x selection hooks.
5934 * xselect.c (Qx_lost_selection_functions)
5935 (Qx_sent_selection_functions): New vars.
5936 (syms_of_xselect): DEFSYM them.
5937 (x_handle_selection_request): Pass Qx_sent_selection_functions
5938 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5939 (x_handle_selection_clear,x_clear_frame_selections):
5940 Pass Qx_lost_selection_functions rather than
5941 Vx_lost_selection_functions to Frun_hook_with_args.
5942
5943 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5944
5945 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
5946 The old code sometimes used this field without initializing it.
5947
5948 * alloc.c (gc_sweep): Don't read past end of array.
5949 In theory, the old code could also have corrupted Emacs internals,
5950 though it'd be very unlikely.
5951
5952 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5953
5954 * character.c (Fcharacterp): Don't advertise optional ignored
5955 argument. (Bug#4026)
5956
5957 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5958
5959 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5960 key" (bug#4257).
5961
5962 * window.c (Fset_window_start): Doc fix (bug#4199).
5963 (Fset_window_hscroll): Ditto.
5964
5965 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5966
5967 Fix minor new problems caught by GCC 4.6.1.
5968 * term.c (init_tty): Remove unused local.
5969 * xsettings.c (store_monospaced_changed): Define this function only
5970 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
5971 not used otherwise.
5972
5973 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
5974
5975 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5976
5977 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5978
5979 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5980 are the mini-buffer and the echo area (bug#3320).
5981
5982 * term.c (init_tty): Remove support for supdup, c10 and perq
5983 terminals, which are no longer supported (bug#1482).
5984
5985 2011-07-10 Johan Bockgård <bojohan@gnu.org>
5986
5987 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5988
5989 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5990
5991 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5992 for non-popups (Bug#3642).
5993
5994 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5995
5996 * alloc.c (reset_malloc_hooks): Protoize.
5997 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
5998 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5999 * cm.c (losecursor): Likewise.
6000 * data.c (fmod): Likewise.
6001 * dispnew.c (swap_glyphs_in_rows): Likewise.
6002 * emacs.c (memory_warning_signal): Likewise.
6003 * floatfns.c (float_error): Likewise.
6004 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6005 (otf_open, font_otf_capability, generate_otf_features)
6006 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6007 Likewise.
6008 * image.c (pbm_read_file): Likewise.
6009 * indent.c (string_display_width): Likewise.
6010 * intervals.c (check_for_interval, search_for_interval)
6011 (inc_interval_count, count_intervals, root_interval)
6012 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6013 * lread.c (defalias): Likewise.
6014 * ralloc.c (r_alloc_check): Likewise.
6015 * regex.c (set_image_of_range_1, set_image_of_range)
6016 (regex_grow_registers): Likewise.
6017 * sysdep.c (strerror): Likewise.
6018 * termcap.c (valid_filename_p, tprint, main): Likewise.
6019 * tparam.c (main): Likewise.
6020 * unexhp9k800.c (run_time_remap, save_data_space)
6021 (update_file_ptrs, read_header, write_header, calculate_checksum)
6022 (copy_file, copy_rest, display_header): Likewise.
6023 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6024 Likewise.
6025 * xdisp.c (check_it): Likewise.
6026 * xfaces.c (register_color, unregister_color, unregister_colors):
6027 Likewise.
6028 * xfns.c (print_fontset_result): Likewise.
6029 * xrdb.c (member, fatal, main): Likewise.
6030
6031 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6032
6033 Fix minor problems found by static checking (Bug#9031).
6034 * chartab.c (char_table_set_range, map_sub_char_table):
6035 Remove unused locals.
6036 (uniprop_table): Now static.
6037 * composite.c (_work_char): Remove unused static var.
6038
6039 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6040
6041 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6042
6043 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6044
6045 * gtkutil.c (qttip_cb): Remove code without function.
6046
6047 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6048
6049 * w32.c (pthread_sigmask): New stub.
6050
6051 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6052
6053 Use pthread_sigmask, not sigprocmask (Bug#9010).
6054 sigprocmask is portable only for single-threaded applications, and
6055 Emacs can be multi-threaded when it uses GTK.
6056 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6057 (LIBES): Use it.
6058 * callproc.c (Fcall_process):
6059 * process.c (create_process):
6060 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6061 Use pthread_sigmask, not sigprocmask.
6062
6063 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6064
6065 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6066 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6067 wrong (Bug#8591).
6068
6069 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6070
6071 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6072 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6073 (xg_hide_tooltip): Fix comment.
6074
6075 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6076 in registerServicesMenuSendTypes.
6077 (validRequestorForSendType): Don't check ns_return_types.
6078
6079 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6080 ns_return_type.
6081
6082 2011-07-08 Jason Rumney <jasonr@gnu.org>
6083
6084 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6085 SH_SHOW for hidden windows (Bug#5482).
6086
6087 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6088 frame struct members of non-existent frames (Bug#6284).
6089
6090 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6091
6092 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6093 variable firstTime not needed on OSX >= 10.6.
6094 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6095 >= 10.5. Use setKnobProportion, setDoubleValue.
6096
6097 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6098 (MAC_OS_X_VERSION_10_5): Define if not defined.
6099 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6100 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6101 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6102
6103 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6104 cString and lossyCString on OSX >= 10.4
6105
6106 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6107 sizeToFit on OSX >= 10.2.
6108
6109 * nsimage.m (allocInitFromFile): Don't use deprecated method
6110 bestRepresentationForDevice on OSX >= 10.6.
6111
6112 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6113 to avoid warning.
6114
6115 * emacs.c: Declare unexec_init_emacs_zone.
6116
6117 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6118
6119 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6120
6121 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6122 on svcsMenu (Bug#8842).
6123
6124 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6125 ns_return_types.
6126 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6127
6128 * nsterm.m (QUTF8_STRING): Declare.
6129 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6130 (validRequestorForSendType): Return type is (id).
6131 Change indexOfObjectIdenticalTo to indexOfObject.
6132 Check if we have local selection before returning self (Bug#8842).
6133 (writeSelectionToPasteboard): Put local selection into paste board
6134 if we have a local selection (Bug#8842).
6135 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6136
6137 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6138 (ns_get_local_selection): Declare.
6139
6140 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6141
6142 * keymap.c (describe_map_tree): Don't insert a double newline at
6143 the end of the buffer (bug#1169) and return whether we inserted
6144 something.
6145
6146 * callint.c (Fcall_interactively): Change "reading args" to
6147 "providing args" to try to clarify what it does (bug#1010).
6148
6149 2011-07-07 Kenichi Handa <handa@m17n.org>
6150
6151 * composite.c (composition_compute_stop_pos): Ignore a static
6152 composition starting before CHARPOS (Bug#8915).
6153
6154 * xdisp.c (handle_composition_prop): Likewise.
6155
6156 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6157
6158 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6159 (Bug#9015)
6160
6161 2011-07-07 Kenichi Handa <handa@m17n.org>
6162
6163 * character.h (unicode_category_t): New enum type.
6164
6165 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6166 (Qchar_code_property_table): New variable.
6167 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6168 (UNIPROP_COMPRESSED_FORM_P): New macros.
6169 (char_table_ascii): Uncompress the compressed values.
6170 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6171 Uncompress the compressed values.
6172 (sub_char_table_ref_and_range): Likewise.
6173 (char_table_ref_and_range): Uncompress the compressed values.
6174 (sub_char_table_set): New arg is_uniprop. Callers changed.
6175 Uncompress the compressed values.
6176 (sub_char_table_set_range): Args changed. Callers changed.
6177 (char_table_set_range): Adjuted for the above change.
6178 (map_sub_char_table): Delete args default_val and parent. Add arg
6179 top. Give decoded values to a Lisp function.
6180 (map_char_table): Adjust for the above change. Give decoded
6181 values to a Lisp function. Gcpro more variables.
6182 (uniprop_table_uncompress)
6183 (uniprop_decode_value_run_length): New functions.
6184 (uniprop_decoder, uniprop_decoder_count): New variables.
6185 (uniprop_get_decoder, uniprop_encode_value_character)
6186 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6187 New functions.
6188 (uniprop_encoder, uniprop_encoder_count): New variables.
6189 (uniprop_get_encoder, uniprop_table)
6190 (Funicode_property_table_internal, Fget_unicode_property_internal)
6191 (Fput_unicode_property_internal): New functions.
6192 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6193 Sunicode_property_table_internal, Sget_unicode_property_internal,
6194 and Sput_unicode_property_internal. Defvar_lisp
6195 char-code-property-alist.
6196
6197 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6198 Vunicode_category_table.
6199
6200 * font.c (font_range): Adjust for the change of
6201 Vunicode_category_table.
6202
6203 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6204
6205 * m/iris4d.h: Remove file, move contents ...
6206 * s/irix6-5.h: ... here.
6207
6208 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6209
6210 Remove unportable assumption about struct layout (Bug#8884).
6211 * alloc.c (mark_buffer):
6212 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6213 (clone_per_buffer_values): Don't assume that
6214 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6215 This isn't true in general, and it's particularly not true
6216 if Emacs is configured with --with-wide-int.
6217 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6218 New macros, used in the buffer.c change.
6219
6220 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6221
6222 * xsettings.c: Use both GConf and GSettings if both are available.
6223 (store_config_changed_event): Add comment.
6224 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6225 (store_tool_bar_style_changed): New functions.
6226 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6227 (struct xsettings): Move font inside HAVE_XFT.
6228 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6229 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6230 Move inside HAVE_XFT.
6231 (something_changed_gsettingsCB): Rename from something_changedCB.
6232 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6233 also.
6234 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6235 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6236 (something_changed_gconfCB): Rename from something_changedCB.
6237 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6238 (parse_settings): Move check for font inside HAVE_XFT.
6239 (read_settings, apply_xft_settings): Add comment.
6240 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6241 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6242 call store_font_name_changed.
6243 (xft_settings_event): Add comment.
6244 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6245 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6246 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6247 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6248 (xsettings_initialize): Call init_gsettings last.
6249 (xsettings_get_system_font, xsettings_get_system_normal_font):
6250 Add comment.
6251
6252 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6253
6254 Random fixes. E.g., (random) never returned negative values.
6255 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6256 subseconds part to the entropy, as that's a bit more random.
6257 Prefer signed to unsigned, since the signedness doesn't matter and
6258 in general we prefer signed. When given a limit, use a
6259 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6260 latter isn't right if USE_2_TAGS_FOR_INTS.
6261 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6262 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6263
6264 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6265
6266 * textprop.c (text_property_stickiness):
6267 Obey Vtext_property_default_nonsticky.
6268 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6269 * w32fns.c (syms_of_w32fns):
6270 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6271
6272 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6273
6274 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6275 This is more efficient than Ffile_directory_p and avoids a minor race.
6276
6277 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6278
6279 * buffer.c (Foverlay_put): Say what the return value is
6280 (bug#7835).
6281
6282 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6283 is a directory before asking whether to use the file name
6284 (bug#7564).
6285 (barf_or_query_if_file_exists): Make the "File is a directory"
6286 error be more correct.
6287
6288 * fns.c (Frequire): Remove the mention of the .gz files, since
6289 that's installation-specific, but keep the mention of
6290 `get-load-suffixes'.
6291
6292 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6293
6294 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6295 Report string overflow if the output is too long.
6296
6297 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6298
6299 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6300 (syms_of_gnutls): Remove duplicate DEFSYM for
6301 Qgnutls_bootprop_verify_hostname_error, an error for
6302 Qgnutls_bootprop_verify_error (which is no longer used).
6303
6304 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6305 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6306 Also (re)move comments that are misplaced or no longer relevant.
6307
6308 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6309
6310 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6311
6312 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6313
6314 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6315 and background color parameters if they have been changed.
6316
6317 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6318
6319 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6320
6321 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6322
6323 * xsettings.c (SYSTEM_FONT): Define only when used.
6324 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6325
6326 * keymap.c (access_keymap_1): Now static.
6327
6328 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6329
6330 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6331 leave any prefix arg for the up event (Bug#1586).
6332
6333 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6334
6335 * lread.c (syms_of_lread): Mention single symbols defined by
6336 `defvar' or `defconst' (bug#7154).
6337
6338 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6339 (Frequire): Mention get-load-suffixes.
6340
6341 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6342
6343 * window.h (window): Remove clone_number slot.
6344 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6345 Remove.
6346 (make_parent_window, make_window, saved_window)
6347 (Fset_window_configuration, save_window_save): Don't deal with
6348 clone numbers.
6349 * buffer.c (Qclone_number): Remove declaration.
6350 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6351
6352 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6353
6354 Add multiple inheritance to keymaps.
6355 * keymap.c (Fmake_composed_keymap): New function.
6356 (Fset_keymap_parent): Simplify.
6357 (fix_submap_inheritance): Remove.
6358 (access_keymap_1): New function extracted from access_keymap to handle
6359 embedded parents and handle lists of maps.
6360 (access_keymap): Use it.
6361 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6362 (Fcopy_keymap): Handle embedded parents.
6363 (Fcommand_remapping, define_as_prefix): Simplify.
6364 (Fkey_binding): Simplify.
6365 (syms_of_keymap): Move minibuffer-local-completion-map,
6366 minibuffer-local-filename-completion-map,
6367 minibuffer-local-must-match-map, and
6368 minibuffer-local-filename-must-match-map to Elisp.
6369 (syms_of_keymap): Defsubr make-composed-keymap.
6370 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6371 (parse_menu_item): Trivial simplification.
6372
6373 2011-07-01 Glenn Morris <rgm@gnu.org>
6374
6375 * Makefile.in (SETTINGS_LIBS): Fix typo.
6376
6377 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6378
6379 * coding.c (Fencode_coding_string): Record the last coding system
6380 used, as the function doc string says (bug#8738).
6381
6382 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6383
6384 * xsettings.c (store_monospaced_changed): Take new font as arg and
6385 check for change against current_mono_font.
6386 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6387 (emacs_settings_constructor, emacs_settings_get_property)
6388 (emacs_settings_set_property, emacs_settings_class_init)
6389 (emacs_settings_init, gsettings_obj): Remove.
6390 (something_changedCB): New function for HAVE_GSETTINGS.
6391 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6392 with value as argument.
6393 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6394 g_settings_new (Bug#8967). Do not create gsettings_obj.
6395 Remove calls to g_settings_bind. Connect something_changedCB to
6396 "changed".
6397
6398 * xgselect.c: Add defined (HAVE_GSETTINGS).
6399 (xgselect_initialize): Ditto.
6400
6401 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6402 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6403 xg_select.
6404
6405 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6406
6407 * eval.c (struct backtrace): Simplify and port the data structure.
6408 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6409 signed bit field, as this assumption is not portable and it makes
6410 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6411 "char debug_on_exit : 1" as this is not portable either; instead,
6412 use the portable "unsigned int debug_on_exit : 1". Remove unused
6413 member evalargs. Remove obsolete comments about cc bombing out.
6414
6415 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6416
6417 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6418 Let HAVE_GSETTINGS override HAVE_GCONF.
6419 (store_monospaced_changed): New function.
6420 (EMACS_SETTINGS): A new type derived from GObject to handle
6421 GSettings notifications.
6422 (emacs_settings_constructor, emacs_settings_get_property)
6423 (emacs_settings_set_property, emacs_settings_class_init):
6424 New functions.
6425 (gsettings_client, gsettings_obj): New variables.
6426 (GSETTINGS_SCHEMA): New define.
6427 (something_changedCB): Call store_monospaced_changed.
6428 (init_gsettings): New function.
6429 (xsettings_initialize): Call init_gsettings.
6430 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6431 to NULL.
6432
6433 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6434 GCONF_CFLAGS/LIBS.
6435
6436 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6437
6438 * window.c (resize_root_window, grow_mini_window)
6439 (shrink_mini_window): Rename Qresize_root_window to
6440 Qwindow_resize_root_window and Qresize_root_window_vertically to
6441 Qwindow_resize_root_window_vertically.
6442
6443 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6444
6445 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6446
6447 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6448
6449 * makefile.w32-in: Redesign dependencies so they reflect more
6450 clearly which files are directly included by each source file,
6451 and not through other includes.
6452
6453 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6454
6455 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6456 (sort_overlays, overlay_strings): When an overlay's clone number
6457 matches the window's clone number process the overlay even if
6458 the overlay's window property doesn't match the current window.
6459
6460 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6461 (Fwindow_hchild): Rename to Fwindow_left_child.
6462 (Fwindow_next): Rename to Fwindow_next_sibling.
6463 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6464 (resize_window_check): Rename to window_resize_check.
6465 (resize_window_apply): Rename to window_resize_apply.
6466 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6467 (Fdelete_other_windows_internal, resize_frame_windows)
6468 (Fsplit_window_internal, Fdelete_window_internal)
6469 (grow_mini_window, shrink_mini_window)
6470 (Fresize_mini_window_internal): Fix callers accordingly.
6471
6472 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6473
6474 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6475 (emacs_fixed_set_min_size): Remove.
6476 (emacs_fixed_new): Take frame as argument.
6477
6478 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6479 (_EmacsFixedPrivate): Remove minwidth/height.
6480 Add struct frame *f.
6481 (emacs_fixed_init): Initialize priv->f.
6482 (get_parent_class, emacs_fixed_set_min_size): Remove.
6483 (emacs_fixed_new): Set priv->f to argument.
6484 (emacs_fixed_get_preferred_width)
6485 (emacs_fixed_get_preferred_height): Use min_width/height from
6486 frames size_hint to set minimum and natural (Bug#8919).
6487 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6488 and use min_width/height from frames size_hint to set
6489 min_width/height (Bug#8919).
6490
6491 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6492 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6493 Fix indentation.
6494
6495 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6496
6497 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6498 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6499 called at ZV.
6500
6501 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6502
6503 * process.c (wait_reading_process_output): Bypass select if
6504 waiting for a cell while ignoring keyboard input, and input is
6505 pending. Suggested by Jan Djärv (Bug#8869).
6506
6507 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6508
6509 Use gnulib's dup2 module instead of rolling our own.
6510 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6511
6512 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6513
6514 * dispnew.c (scrolling_window): Before scrolling, turn off a
6515 mouse-highlight in the window being scrolled.
6516
6517 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6518
6519 Move DEFSYM to lisp.h and use everywhere.
6520
6521 * character.h (DEFSYM): Move declaration...
6522 * lisp.h (DEFSYM): ...here.
6523
6524 * gnutls.c:
6525 * minibuf.c:
6526 * w32menu.c:
6527 * w32proc.c:
6528 * w32select.c: Don't include character.h.
6529
6530 * alloc.c (syms_of_alloc):
6531 * buffer.c (syms_of_buffer):
6532 * bytecode.c (syms_of_bytecode):
6533 * callint.c (syms_of_callint):
6534 * casefiddle.c (syms_of_casefiddle):
6535 * casetab.c (init_casetab_once):
6536 * category.c (init_category_once, syms_of_category):
6537 * ccl.c (syms_of_ccl):
6538 * cmds.c (syms_of_cmds):
6539 * composite.c (syms_of_composite):
6540 * dbusbind.c (syms_of_dbusbind):
6541 * dired.c (syms_of_dired):
6542 * dispnew.c (syms_of_display):
6543 * doc.c (syms_of_doc):
6544 * editfns.c (syms_of_editfns):
6545 * emacs.c (syms_of_emacs):
6546 * eval.c (syms_of_eval):
6547 * fileio.c (syms_of_fileio):
6548 * fns.c (syms_of_fns):
6549 * frame.c (syms_of_frame):
6550 * fringe.c (syms_of_fringe):
6551 * insdel.c (syms_of_insdel):
6552 * keymap.c (syms_of_keymap):
6553 * lread.c (init_obarray, syms_of_lread):
6554 * macros.c (syms_of_macros):
6555 * msdos.c (syms_of_msdos):
6556 * print.c (syms_of_print):
6557 * process.c (syms_of_process):
6558 * search.c (syms_of_search):
6559 * sound.c (syms_of_sound):
6560 * syntax.c (init_syntax_once, syms_of_syntax):
6561 * terminal.c (syms_of_terminal):
6562 * textprop.c (syms_of_textprop):
6563 * undo.c (syms_of_undo):
6564 * w32.c (globals_of_w32):
6565 * window.c (syms_of_window):
6566 * xdisp.c (syms_of_xdisp):
6567 * xfaces.c (syms_of_xfaces):
6568 * xfns.c (syms_of_xfns):
6569 * xmenu.c (syms_of_xmenu):
6570 * xsettings.c (syms_of_xsettings):
6571 * xterm.c (syms_of_xterm): Use DEFSYM.
6572
6573 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6574
6575 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6576
6577 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6578
6579 Integer and buffer overflow fixes (Bug#8873).
6580
6581 * print.c (printchar, strout): Check for string overflow.
6582 (PRINTPREPARE, printchar, strout):
6583 Don't set size unless allocation succeeds.
6584
6585 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6586 for sizes. Check for string overflow more accurately.
6587 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6588
6589 * macros.c: Integer and buffer overflow fixes.
6590 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6591 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6592 Use ptrdiff_t, not int, for sizes.
6593 Don't increment bufsize until after realloc succeeds.
6594 Check for size-calculation overflow.
6595 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6596
6597 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6598
6599 * lread.c: Integer overflow fixes.
6600 (read_integer): Radix is now EMACS_INT, not int,
6601 to improve quality of diagnostics for out-of-range radices.
6602 Calculate buffer size correctly for out-of-range radices.
6603 (read1): Check for integer overflow in radices, and in
6604 read-circle numbers.
6605 (read_escape): Avoid int overflow.
6606 (Fload, openp, read_buffer_size, read1)
6607 (substitute_object_recurse, read_vector, read_list, map_obarray):
6608 Use ptrdiff_t, not int, for sizes.
6609 (read1): Use EMACS_INT, not int, for sizes.
6610 Check for size overflow.
6611
6612 * image.c (cache_image): Check for size arithmetic overflow.
6613
6614 * lread.c: Integer overflow issues.
6615 (saved_doc_string_size, saved_doc_string_length)
6616 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6617 Now ptrdiff_t, not int.
6618 (read1): Don't assume doc string length fits in int. Check for
6619 out-of-range doc string lengths.
6620 (read_list): Don't assume file position fits in int.
6621 (read_escape): Check for hex character overflow.
6622
6623 2011-06-22 Leo Liu <sdl.web@gmail.com>
6624
6625 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6626 Move to minibuffer.el.
6627
6628 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6629
6630 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6631 The following patches are for when GLYPH_DEBUG && !XASSERT.
6632 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6633 * dispnew.c (flush_stdout):
6634 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6635 Mark as externally visible.
6636 * dispnew.c (check_window_matrix_pointers): Now static.
6637 * dispnew.c (window_to_frame_vpos):
6638 * xfns.c (unwind_create_frame):
6639 * xterm.c (x_check_font): Remove unused local.
6640 * scroll.c (CHECK_BOUNDS):
6641 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6642 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6643 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6644 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6645 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6646 Now static.
6647 (debug_method_add): Use va_list and vsprintf rather than relying
6648 on undefined behavior with wrong number of arguments.
6649 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6650 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6651 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6652 since we're not interested in debugging glyphs with old libraries.
6653 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6654 GCC 4.6.0's static checking.
6655
6656 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6657
6658 Integer overflow and signedness fixes (Bug#8873).
6659 A few related buffer overrun fixes, too.
6660
6661 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6662
6663 * dispextern.h (struct face.stipple):
6664 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6665 (x_bitmap_mask, x_allocate_bitmap_record)
6666 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6667 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6668 (x_create_bitmap_from_xpm_data):
6669 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6670 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6671 (.bitmaps_last):
6672 * xfaces.c (load_pixmap):
6673 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6674 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6675 (.bitmaps_last, struct x_output.icon_bitmap):
6676 Use ptrdiff_t, not int, for bitmap indexes.
6677 (x_allocate_bitmap_record): Check for size overflow.
6678 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6679
6680 Use ptrdiff_t, not int, for overlay counts.
6681 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6682 * editfns.c (overlays_around, get_pos_property):
6683 * textprop.c (get_char_property_and_overlay):
6684 * xdisp.c (next_overlay_change, note_mouse_highlight):
6685 * xfaces.c (face_at_buffer_position):
6686 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6687 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6688 (Fnext_overlay_change, Fprevious_overlay_change)
6689 (mouse_face_overlay_overlaps, Foverlays_in):
6690 Use ptrdiff_t, not int, for sizes.
6691 (overlays_at, overlays_in): Check for size-calculation overflow.
6692
6693 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6694
6695 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6696 (x_session_initialize): Do not assume string length fits in int.
6697
6698 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6699 This is unlikely, but can occur if DPI is outlandish.
6700
6701 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6702 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6703
6704 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6705 * xrdb.c (magic_file_p, search_magic_path):
6706 Omit last arg SUFFIX; it was always 0. All callers changed.
6707 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6708
6709 * xfont.c (xfont_match): Avoid need for strlen.
6710
6711 * xfns.c: Don't assume strlen fits in int.
6712 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6713
6714 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6715 not unsigned long, as we prefer signed integers. All callers changed.
6716 Detect integer overflow in repeat count.
6717 (message_dolog): Don't assume print length fits in 39 bytes.
6718 (display_mode_element): Don't assume strlen fits in int.
6719
6720 * termcap.c: Don't assume sizes fit in int and never overflow.
6721 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6722 (gobble_line): Check for size-calculation overflow.
6723
6724 * minibuf.c (Fread_buffer):
6725 * lread.c (intern, intern_c_string):
6726 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6727 Don't assume string length fits in int.
6728
6729 * keyboard.c (parse_tool_bar_item):
6730 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6731
6732 * font.c: Don't assume string length fits in int.
6733 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6734 Use ptrdiff_t, not int.
6735 (font_intern_prop): Don't assume string length fits in int.
6736 Don't assume integer property fits in fixnum.
6737 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6738
6739 * filelock.c: Fix some buffer overrun and integer overflow issues.
6740 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6741 Reformulate so as not to need the command string.
6742 Invoke gzip -cd rather than gunzip, as it's more portable.
6743 (lock_info_type, lock_file_1, lock_file):
6744 Don't assume pid_t and time_t fit in unsigned long.
6745 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6746 (current_lock_owner): Prefer signed type for sizes.
6747 Use memcpy, not strncpy, where memcpy is what is really wanted.
6748 Don't assume (via atoi) that time_t and pid_t fit in int.
6749 Check for time_t and/or pid_t out of range, e.g., via a network share.
6750 Don't alloca where an auto var works fine.
6751
6752 * fileio.c: Fix some integer overflow issues.
6753 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6754 Don't assume string length fits in int.
6755 (directory_file_name): Don't assume string length fits in long.
6756 (make_temp_name): Don't assume pid fits in int, or that its print
6757 length is less than 20.
6758
6759 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6760
6761 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6762
6763 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6764
6765 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6766 We prefer signed integers, even for size calculations.
6767
6768 * emacs.c: Don't assume string length fits in 'int'.
6769 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6770 (main): Don't invoke strlen when not needed.
6771
6772 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6773 (XD_DEBUG_MESSAGE): Don't waste a byte.
6774
6775 * callproc.c (getenv_internal_1, getenv_internal)
6776 (Fgetenv_internal):
6777 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6778
6779 * lread.c (invalid_syntax): Omit length argument.
6780 All uses changed. This doesn't fix a bug, but it simplifies the
6781 code away from its former Hollerith-constant appearance, and it's
6782 one less 'int' to worry about when looking at integer-overflow issues.
6783 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6784
6785 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6786 This didn't break anything, but it didn't help either.
6787 It's confusing to put a bogus integer in a place where the actual
6788 value does not matter.
6789 (LIST_END_P): Remove unused macro and its bogus comment.
6790 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6791
6792 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6793 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6794 implementation.
6795 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6796 We prefer signed types, and the value cannot exceed the EMACS_INT
6797 range anyway (because otherwise the length would not be representable).
6798 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6799 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6800 This avoids a GCC warning when WIDE_EMACS_INT.
6801
6802 * indent.c (sane_tab_width): New function.
6803 (current_column, scan_for_column, Findent_to, position_indentation)
6804 (compute_motion): Use it. This is just for clarity.
6805 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6806
6807 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6808
6809 * lisp.h (lint_assume): New macro.
6810 * composite.c (composition_gstring_put_cache):
6811 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6812
6813 * editfns.c, insdel.c:
6814 Omit unnecessary forward decls, to simplify future changes.
6815
6816 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6817
6818 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6819
6820 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6821 Use much-faster test for byte-length change.
6822 Don't assume string byte-length fits in 'int'.
6823 Check that character arg fits in 'int'.
6824 (mapcar1): Declare byte as byte, for clarity.
6825
6826 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6827
6828 * fns.c (concat): Catch string overflow earlier.
6829 Do not rely on integer wraparound.
6830
6831 * dispextern.h (struct it.overlay_strings_charpos)
6832 (struct it.selective): Now EMACS_INT, not int.
6833 * xdisp.c (forward_to_next_line_start)
6834 (back_to_previous_visible_line_start)
6835 (reseat_at_next_visible_line_start, next_element_from_buffer):
6836 Don't arbitrarily truncate the value of 'selective' to int.
6837
6838 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6839
6840 * composite.c: Don't truncate sizes to 'int'.
6841 (composition_gstring_p, composition_reseat_it)
6842 (composition_adjust_point): Use EMACS_INT, not int.
6843 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6844 not EMACS_UINT, for indexes.
6845
6846 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6847
6848 * buffer.c: Include <verify.h>.
6849 (struct sortvec.priority, struct sortstr.priority):
6850 Now EMACS_INT, not int.
6851 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6852 (struct sortstr.size, record_overlay_string)
6853 (struct sortstrlist.size, struct sortlist.used):
6854 Don't truncate size to int.
6855 (record_overlay_string): Check for size-calculation overflow.
6856 (init_buffer_once): Check at compile-time, not run-time.
6857
6858 2011-06-22 Jim Meyering <meyering@redhat.com>
6859
6860 Don't leak an XBM-image-sized buffer
6861 * image.c (xbm_load): Free the image buffer after using it.
6862
6863 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6864
6865 Port to Sun C.
6866 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6867 that Sun C diagnosed.
6868 * fns.c (secure_hash): Fix pointer signedness issue.
6869 * intervals.c (static_offset_intervals): New function.
6870 (offset_intervals): Use it.
6871
6872 2011-06-21 Leo Liu <sdl.web@gmail.com>
6873
6874 * deps.mk (fns.o):
6875 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6876 sha512.h.
6877
6878 * fns.c (secure_hash): Rename from crypto_hash_function and change
6879 the first arg to accept symbols.
6880 (Fsecure_hash): New primitive.
6881 (syms_of_fns): New symbols.
6882
6883 2011-06-20 Deniz Dogan <deniz@dogan.se>
6884
6885 * process.c (Fset_process_buffer): Clarify return value in
6886 docstring.
6887
6888 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6889
6890 * dispnew.c (add_window_display_history): Use BVAR.
6891
6892 * xdisp.c (debug_method_add): Use BVAR.
6893 (check_window_end, dump_glyph_matrix, dump_glyph)
6894 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6895
6896 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6897 Likewise.
6898
6899 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6900 check till after the cache is created in init_frame_faces.
6901
6902 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6903
6904 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6905
6906 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6907
6908 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6909 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6910 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6911
6912 Improve buffer-overflow checking (Bug#8873).
6913 * fileio.c (Finsert_file_contents):
6914 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6915 Remove the old (too-loose) buffer overflow checks.
6916 They weren't needed, since make_gap checks for buffer overflow.
6917 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6918 The old code merely checked for Emacs fixnum overflow, and relied
6919 on undefined (wraparound) behavior. The new code avoids undefined
6920 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6921
6922 * editfns.c (Finsert_char): Don't dump core with very negative counts.
6923 Tune. Don't use wider integers than needed. Don't use alloca.
6924 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
6925
6926 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6927
6928 * insdel.c, lisp.h (buffer_overflow): New function.
6929 (insert_from_buffer_1, replace_range, replace_range_2):
6930 * insdel.c (make_gap_larger):
6931 * editfns.c (Finsert_char):
6932 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6933
6934 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6935
6936 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6937
6938 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
6939
6940 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6941 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6942
6943 * fileio.c: Don't assume EMACS_INT fits in off_t.
6944 (emacs_lseek): New static function.
6945 (Finsert_file_contents, Fwrite_region): Use it.
6946 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6947
6948 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6949
6950 * fns.c: Don't overflow int when computing a list length.
6951 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6952 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6953 truncation on 64-bit hosts. Check for QUIT every
6954 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6955 faster and is responsive enough.
6956 (Flength): Report an error instead of overflowing an integer.
6957 (Fsafe_length): Return a float if the value is not representable
6958 as a fixnum. This shouldn't happen except in contrived situations.
6959 (Fnthcdr, Fsort): Don't assume list length fits in int.
6960 (Fcopy_sequence): Don't assume vector length fits in int.
6961
6962 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6963 (header_size, word_size): New constants.
6964 (allocate_vectorlike): Don't check size overflow here.
6965 (allocate_vector): Check it here instead, since this is the only
6966 caller of allocate_vectorlike that could cause overflow.
6967 Check that the new vector's length is representable as a fixnum.
6968
6969 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6970 The previous code was bogus. For example, next_almost_prime (32)
6971 returned 39, which is undesirable as it is a multiple of 3; and
6972 next_almost_prime (24) returned 25, which is a multiple of 5 so
6973 why was the code bothering to check for multiples of 7?
6974
6975 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6976
6977 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6978
6979 Variadic C functions now count arguments with ptrdiff_t.
6980 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6981 Back then I didn't know that the Emacs coding style prefers signed int.
6982 Also, in the meantime I found a few more instances where arguments
6983 were being counted with int, which may truncate counts on 64-bit
6984 machines, or EMACS_INT, which may be unnecessarily wide.
6985 * lisp.h (struct Lisp_Subr.function.aMANY)
6986 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6987 Arg counts are now ptrdiff_t, not size_t.
6988 All variadic functions and their callers changed accordingly.
6989 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6990 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6991 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6992 * callint.c (Fcall_interactively): Check arg count for overflow,
6993 to avoid potential buffer overrun. Use signed char, not 'int',
6994 for 'varies' array, so that we needn't bother to check its size
6995 calculation for overflow.
6996 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6997 * eval.c (apply_lambda):
6998 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6999 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7000 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7001
7002 * callint.c (Fcall_interactively): Don't use index var as event count.
7003
7004 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7005 * mem-limits.h (SIZE): Remove; no longer used.
7006
7007 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7008
7009 Remove unnecessary casts.
7010 * xterm.c (x_term_init):
7011 * xfns.c (x_set_border_pixel):
7012 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7013 These aren't needed now that we assume ANSI C.
7014
7015 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7016 It's more likely to cause problems (due to unsigned overflow)
7017 than to cure them.
7018
7019 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7020
7021 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7022
7023 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7024
7025 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7026
7027 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7028
7029 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7030
7031 GLYPH_CODE_FACE returns EMACS_INT, not int.
7032 * dispextern.h (merge_faces):
7033 * xfaces.c (merge_faces):
7034 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7035 Don't assume EMACS_INT fits in int.
7036
7037 * character.h (CHAR_VALID_P): Remove unused parameter.
7038 * fontset.c, lisp.h, xdisp.c: All uses changed.
7039
7040 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7041
7042 * fns.c (concat): Minor tuning based on overflow analysis.
7043 This doesn't fix any bugs. Use int to hold character, instead
7044 of constantly refetching from Emacs object. Use XFASTINT, not
7045 XINT, for value known to be a character. Don't bother comparing
7046 a single byte to 0400, as it's always less.
7047
7048 * floatfns.c (Fexpt):
7049 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7050
7051 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7052 for characters.
7053
7054 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7055
7056 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7057 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7058 incorrectly succeed when S was a string, because 4294967386 was
7059 truncated before it was used.
7060
7061 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7062 Otherwise, an out-of-range integer could cause undefined behavior
7063 on a 64-bit host.
7064
7065 * composite.c: Use int, not EMACS_INT, for characters.
7066 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7067 EMACS_INT, for values that are known to be in character range.
7068 This doesn't fix any bugs but is the usual style inside Emacs and
7069 may generate better code on 32-bit machines.
7070
7071 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7072 This is for reasons similar to the recent CHAR_STRING fix.
7073 * charset.c (Fencode_char): Check that character arg is actually
7074 a character. Pass an int to ENCODE_CHAR.
7075 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7076 wider than 'int', as a compile-time check to prevent future regressions
7077 in this area.
7078
7079 * character.c (char_string): Remove unnecessary casts.
7080
7081 Make sure a 64-bit char is never passed to CHAR_STRING.
7082 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7083 by silently ignoring the top 32 bits, allowing some values
7084 that were far too large to be valid characters.
7085 * character.h: Include <verify.h>.
7086 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7087 arguments are no wider than unsigned, as a compile-time check
7088 to prevent future regressions in this area.
7089 * data.c (Faset):
7090 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7091 (Fsubst_char_in_region):
7092 * fns.c (concat):
7093 * xdisp.c (decode_mode_spec_coding):
7094 Adjust to CHAR_STRING's new requirement.
7095 * editfns.c (Finsert_char, Fsubst_char_in_region):
7096 * fns.c (concat): Check that character args are actually
7097 characters. Without this test, these functions did the wrong
7098 thing with wildly out-of-range values on 64-bit hosts.
7099
7100 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7101 These casts should not be needed on 32-bit hosts, either.
7102 * keyboard.c (read_char):
7103 * lread.c (Fload): Remove casts to unsigned.
7104
7105 * lisp.h (UNSIGNED_CMP): New macro.
7106 This fixes comparison bugs on 64-bit hosts.
7107 (ASCII_CHAR_P): Use it.
7108 * casefiddle.c (casify_object):
7109 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7110 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7111 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7112 * dispextern.h (FACE_FROM_ID):
7113 * keyboard.c (read_char): Use UNSIGNED_CMP.
7114
7115 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7116 not to EMACS_INT, to avoid GCC warning.
7117
7118 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7119
7120 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7121 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7122 isn't needed on 32-bit machines.
7123
7124 * buffer.c (Fgenerate_new_buffer_name):
7125 Use EMACS_INT for count, not int.
7126 (advance_to_char_boundary): Return EMACS_INT, not int.
7127
7128 * data.c (Qcompiled_function): Now static.
7129
7130 * window.c (window_body_lines): Now static.
7131
7132 * image.c (gif_load): Rename local to avoid shadowing.
7133
7134 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7135 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7136 * alloc.c (make_save_value): Integer argument is now of type
7137 ptrdiff_t, not int.
7138 (mark_object): Use ptrdiff_t, not int.
7139 * lisp.h (pD): New macro.
7140 * print.c (print_object): Use it.
7141
7142 * alloc.c: Use EMACS_INT, not int, to count objects.
7143 (total_conses, total_markers, total_symbols, total_vector_size)
7144 (total_free_conses, total_free_markers, total_free_symbols)
7145 (total_free_floats, total_floats, total_free_intervals)
7146 (total_intervals, total_strings, total_free_strings):
7147 Now EMACS_INT, not int. All uses changed.
7148 (Fgarbage_collect): Compute overall total using a double, so that
7149 integer overflow is less likely to be a problem. Check for overflow
7150 when converting back to an integer.
7151 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7152 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7153 These were 'int' variables that could overflow on 64-bit hosts;
7154 they were never used, so remove them instead of repairing them.
7155 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7156 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7157 Previously, this ceilinged at INT_MAX, but that doesn't work on
7158 64-bit machines.
7159 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7160
7161 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7162 (allocate_vectorlike): Check for ptrdiff_t overflow.
7163 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7164 when a (possibly-narrower) signed value would do just as well.
7165 We prefer using signed arithmetic, to avoid comparison confusion.
7166
7167 * alloc.c: Catch some string size overflows that we were missing.
7168 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7169 for convenience in STRING_BYTES_MAX.
7170 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7171 The definition here is exact; the one in lisp.h was approximate.
7172 (allocate_string_data): Check for string overflow. This catches
7173 some instances we weren't catching before. Also, it catches
7174 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7175 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7176 and ptrdiff_t and EMACS_INT are both 64 bits.
7177
7178 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7179 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7180 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7181
7182 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7183
7184 * alloc.c (Fmake_string): Check for out-of-range init.
7185
7186 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7187
7188 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7189
7190 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7191
7192 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7193 xg_get_default_scrollbar_width.
7194
7195 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7196 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7197 (style_changed_cb): Call update_theme_scrollbar_width and call
7198 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7199 all frames (Bug#8505).
7200 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7201 Call gtk_window_set_resizable if HAVE_GTK3.
7202 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7203 and height if HAVE_GTK3 (Bug#8505).
7204 (scroll_bar_width_for_theme): New variable.
7205 (update_theme_scrollbar_width): New function.
7206 (xg_get_default_scrollbar_width): Move code to
7207 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7208 (xg_initialize): Call update_theme_scrollbar_width.
7209
7210 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7211
7212 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7213
7214 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7215
7216 * frame.c (make_frame): Call other_buffer_safely instead of
7217 other_buffer.
7218
7219 * window.c (temp_output_buffer_show): Call display_buffer with
7220 second argument Vtemp_buffer_show_specifiers and reset latter
7221 immediately after the call.
7222 (Vtemp_buffer_show_specifiers): New variable.
7223 (auto_window_vscroll_p, next_screen_context_lines)
7224 (Vscroll_preserve_screen_position): Remove leading asterisks from
7225 doc-strings.
7226
7227 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7228
7229 Fix minor problems found by GCC 4.6.0 static checking.
7230 * buffer.c (Qclone_number): Remove for now, as it's unused.
7231 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7232 (record_buffer): Remove unused local.
7233 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7234 (set_frame_buffer_list): Remove; unused.
7235 * frame.h (other_visible_frames): Remove decl.
7236 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7237 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7238 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7239 if HAVE_GPM.
7240 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7241 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7242 Define only if HAVE_GPM.
7243 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7244 (update_hints_inhibit): Remove; never set. All uses removed.
7245 * widgetprv.h (emacsFrameClassRec): Remove decl.
7246 * window.c (delete_deletable_window): Now returns void, since it
7247 wasn't returning anything.
7248 (compare_window_configurations): Remove unused locals.
7249 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7250 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7251 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7252 the same widths as pointers. This follows up on the 2011-05-06 patch.
7253 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7254 * xterm.h: Likewise.
7255 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7256
7257 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7258
7259 * makefile.w32-in: Update dependencies.
7260 (LISP_H): Add lib/intprops.h.
7261
7262 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7263
7264 * image.c (gif_load): Add animation frame delay to the metadata.
7265 (syms_of_image): Use DEFSYM. New symbol `delay'.
7266
7267 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7268
7269 * window.c (delete_deletable_window): Re-add.
7270 (Fset_window_configuration): Rewrite to handle dead buffers and
7271 consequently deletable windows.
7272 (window_tree, Fwindow_tree): Remove. Supply functionality in
7273 window.el.
7274 (compare_window_configurations): Simplify code.
7275
7276 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7277
7278 * image.c (imagemagick_load_image): Fix type mismatch.
7279 (Fimagemagick_types): Likewise.
7280
7281 * window.h (replace_buffer_in_windows): Declare.
7282
7283 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7284
7285 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7286 Qclone_number. Remove external declaration of Qdelete_window.
7287 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7288 code.
7289 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7290 Run Qbuffer_list_update_hook if allowed.
7291 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7292 buffer list implementation.
7293 (other_buffer_safely): New function.
7294 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7295 calls to replace_buffer_in_windows and
7296 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7297 if allowed.
7298 (record_buffer): Inhibit quitting and rewrite using quittable
7299 functions. Run Qbuffer_list_update_hook if allowed.
7300 (Frecord_buffer, Funrecord_buffer): New functions.
7301 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7302 Move switch-to-buffer to window.el.
7303 (bury-buffer): Move to window.el.
7304 (Vbuffer_list_update_hook): New variable.
7305
7306 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7307 section.
7308
7309 * window.h (resize_frame_windows): Move up in code.
7310 (Fwindow_frame): Remove EXFUN.
7311 (replace_buffer_in_all_windows): Remove prototype.
7312 (replace_buffer_in_windows_safely): Add prototype.
7313
7314 * window.c: Declare Qdelete_window static again. Move down
7315 declaration of select_count.
7316 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7317 (Fother_window): Move to window.el.
7318 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7319 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7320 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7321 window.el.
7322 (replace_buffer_in_windows): Implement by calling
7323 Qreplace_buffer_in_windows.
7324 (replace_buffer_in_all_windows): Remove with some functionality
7325 moved into replace_buffer_in_windows_safely.
7326 (replace_buffer_in_windows_safely): New function.
7327 (select_window_norecord, select_frame_norecord): Move in front
7328 of run_window_configuration_change_hook. Remove now obsolete
7329 declarations.
7330 (Fset_window_buffer): Rewrite doc-string.
7331 Call Qrecord_window_buffer.
7332 (keys_of_window): Move binding for other-window to window.el.
7333
7334 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7335
7336 * dispextern.h (struct image): Replace data member, whose int_val
7337 and ptr_val fields were not used by anything, with a single
7338 lisp_val object.
7339
7340 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7341 (gif_clear_image, gif_load, imagemagick_load_image)
7342 (gs_clear_image, gs_load): Callers changed.
7343
7344 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7345
7346 * buffer.h: Include <time.h>, for time_t.
7347 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7348
7349 Fix minor problems found by static checking.
7350
7351 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7352
7353 Make identifiers static if they are not used in other modules.
7354 * data.c (Qcompiled_function, Qframe, Qvector):
7355 * image.c (QimageMagick, Qsvg):
7356 * minibuf.c (Qmetadata):
7357 * window.c (resize_window_check, resize_root_window): Now static.
7358 * window.h (resize_window_check, resize_root_window): Remove decls.
7359
7360 * window.c (window_deletion_count, delete_deletable_window):
7361 Remove; unused.
7362 (window_body_lines): Now static.
7363 (Fdelete_other_windows_internal): Mark vars as initialized.
7364 Make sure 'resize_failed' is initialized.
7365 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7366 (resize_window_apply): Remove unused local.
7367 * window.h (delete_deletable_window): Remove decl.
7368
7369 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7370 (imagemagick_load_image): Fix pointer signedness problem by changing
7371 last arg from unsigned char * to char *. All uses changed.
7372 Also, fix a local for similar reasons.
7373 Remove unused locals. Remove locals to avoid shadowing.
7374 (fn_rsvg_handle_free): Remove; unused.
7375 (svg_load, svg_load_image): Fix pointer signedness problem.
7376 (imagemagick_load_image): Don't use garbage pointer image_wand.
7377
7378 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7379
7380 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7381
7382 * image.c (gif_load): Fix omitted cast error introduced by
7383 2011-06-06 change.
7384
7385 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7386
7387 * window.h (resize_proportionally, orig_total_lines)
7388 (orig_top_line): Remove from window structure.
7389 (set_window_height, set_window_width, change_window_heights)
7390 (Fdelete_window): Remove prototypes.
7391 (resize_frame_windows): Remove duplicate declaration.
7392
7393 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7394
7395 * window.h (resize_frame_windows, resize_window_check)
7396 (delete_deletable_window, resize_root_window)
7397 (resize_frame_windows): Declare prototypes.
7398
7399 * window.c (resize_window_apply): Make definition be "static" to
7400 match the prototype.
7401
7402 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7403
7404 * window.c: Remove declarations of Qwindow_size_fixed,
7405 window_min_size_1, window_min_size_2, window_min_size,
7406 size_window, window_fixed_size_p, enlarge_window, delete_window.
7407 Remove static from declaration of Qdelete_window, it's
7408 temporarily needed by Fbury_buffer.
7409 (replace_window): Don't assign orig_top_line and
7410 orig_total_lines.
7411 (Fdelete_window, delete_window): Remove. Window deletion is
7412 handled by window.el.
7413 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7414 Replace Fdelete_window calls with calls to Qdelete_window.
7415 (Fdelete_other_windows): Remove. Deleting other windows is
7416 handled by window.el.
7417 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7418 handled in window.el.
7419 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7420 Window minimum sizes are handled in window.el.
7421 (shrink_windows, size_window, set_window_height)
7422 (set_window_width, change_window_heights, window_height)
7423 (window_width, CURBEG, CURSIZE, enlarge_window)
7424 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7425 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7426 handled in window.el.
7427 (make_dummy_parent): Rename to make_parent_window and give it a
7428 second argument horflag.
7429 (make_window): Don't set resize_proportionally any more.
7430 (Fsplit_window): Remove. Windows are split in window.el.
7431 (save_restore_action, save_restore_orig_size)
7432 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7433 Resize mini windows in window.el.
7434 (grow_mini_window, shrink_mini_window): Implement by calling
7435 Qresize_root_window_vertically, resize_window_check and
7436 resize_window_apply.
7437 (saved_window, Fset_window_configuration, save_window_save):
7438 Do not handle orig_top_line, orig_total_lines, and
7439 resize_proportionally.
7440 (window_min_height, window_min_width): Move to window.el.
7441 (keys_of_window): Move bindings for delete-other-windows,
7442 split-window, delete-window and enlarge-window to window.el.
7443
7444 * buffer.c: Temporarily extern Qdelete_window.
7445 (Fbury_buffer): Temporarily call Qdelete_window instead of
7446 Fdelete_window (Fbury_buffer will move to window.el soon).
7447
7448 * frame.c (set_menu_bar_lines_1): Remove code handling
7449 orig_top_line and orig_total_lines.
7450
7451 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7452 set_window_height but set heights directly.
7453 (change_frame_size_1): Use resize_frame_windows.
7454
7455 * xdisp.c (init_xdisp): Don't use set_window_height but set
7456 heights directly.
7457
7458 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7459 Use resize_frame_windows instead of change_window_heights and run
7460 run_window_configuration_change_hook.
7461
7462 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7463 instead of change_window_heights and run
7464 run_window_configuration_change_hook.
7465
7466 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7467
7468 * window.c (replace_window): Rename second argument REPLACEMENT to
7469 NEW. New third argument SETFLAG. Rewrite.
7470 (delete_window, make_dummy_parent): Call replace_window with
7471 third argument 1.
7472 (window_list_1): Move down in code.
7473 (run_window_configuration_change_hook): Move set_buffer part
7474 before select_frame_norecord part in order to unwind correctly.
7475 Rename count1 to count.
7476 (recombine_windows, delete_deletable_window, resize_root_window)
7477 (Fdelete_other_windows_internal)
7478 (Frun_window_configuration_change_hook, make_parent_window)
7479 (resize_window_check, resize_window_apply, Fresize_window_apply)
7480 (resize_frame_windows, Fsplit_window_internal)
7481 (Fdelete_window_internal, Fresize_mini_window_internal):
7482 New functions.
7483 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7484
7485 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7486
7487 * window.h (window): Add some new members to window structure -
7488 normal_lines, normal_cols, new_total, new_normal, clone_number,
7489 splits, nest, prev_buffers, next_buffers.
7490 (WINDOW_TOTAL_SIZE): Move here from window.c.
7491 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7492
7493 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7494 Remove.
7495 (make_dummy_parent): Set new members of windows structure.
7496 (make_window): Move down in code. Handle new members of window
7497 structure.
7498 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7499 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7500 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7501 (Fset_window_prev_buffers, Fwindow_next_buffers)
7502 (Fset_window_next_buffers, Fset_window_clone_number):
7503 New functions.
7504 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7505 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7506 Doc-string fixes.
7507 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7508 Argument WINDOW can be now internal window too.
7509 (Fwindow_use_time): Move up in code.
7510 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7511 Rewrite doc-string.
7512 (Fset_window_configuration, saved_window)
7513 (Fcurrent_window_configuration, save_window_save): Handle new
7514 members of window structure.
7515 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7516 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7517 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7518 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7519 Qget_mru_window, Qresize_root_window,
7520 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7521 Qauto_buffer_name; staticpro them.
7522
7523 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7524
7525 * window.c (Fwindow_total_size, Fwindow_left_column)
7526 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7527 (Fwindow_list_1): New functions.
7528 (window_box_text_cols): Replace with window_body_cols.
7529 (Fwindow_width, Fscroll_left, Fscroll_right):
7530 Use window_body_cols instead of window_box_text_cols.
7531 (delete_window, Fset_window_configuration):
7532 Call delete_all_subwindows with window as argument.
7533 (delete_all_subwindows): Take a window as argument and not a
7534 structure. Rewrite.
7535 (window_loop): Remove handling of GET_LRU_WINDOW and
7536 GET_LARGEST_WINDOW.
7537 (Fget_lru_window, Fget_largest_window): Move to window.el.
7538
7539 * window.h: Extern window_body_cols instead of
7540 window_box_text_cols. delete_all_subwindows now takes a
7541 Lisp_Object as argument.
7542
7543 * indent.c (compute_motion, Fcompute_motion):
7544 Use window_body_cols instead of window_box_text_cols.
7545
7546 * frame.c (delete_frame): Call delete_all_subwindows with root
7547 window as argument.
7548
7549 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7550
7551 * fns.c (Fputhash): Document return value.
7552
7553 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7554
7555 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7556
7557 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7558
7559 Cons<->int and similar integer overflow fixes (Bug#8794).
7560
7561 Check for overflow when converting integer to cons and back.
7562 * charset.c (Fdefine_charset_internal, Fdecode_char):
7563 Use cons_to_unsigned to catch overflow.
7564 (Fencode_char): Use INTEGER_TO_CONS.
7565 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7566 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7567 * data.c (long_to_cons, cons_to_long): Remove.
7568 (cons_to_unsigned, cons_to_signed): New functions.
7569 These signal an error for invalid or out-of-range values.
7570 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7571 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7572 * font.c (Ffont_variation_glyphs):
7573 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7574 * lisp.h: Include <intprops.h>.
7575 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7576 (cons_to_signed, cons_to_unsigned): New decls.
7577 (long_to_cons, cons_to_long): Remove decls.
7578 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7579 (Fprimitive_undo): Use CONS_TO_INTEGER.
7580 * xfns.c (Fx_window_property): Likewise.
7581 * xselect.c: Include <limits.h>.
7582 (x_own_selection, selection_data_to_lisp_data):
7583 Use INTEGER_TO_CONS.
7584 (x_handle_selection_request, x_handle_selection_clear)
7585 (x_get_foreign_selection, Fx_disown_selection_internal)
7586 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7587 (lisp_data_to_selection_data): Use cons_to_unsigned.
7588 (x_fill_property_data): Use cons_to_signed.
7589 Report values out of range.
7590
7591 Check for buffer and string overflow more precisely.
7592 * buffer.h (BUF_BYTES_MAX): New macro.
7593 * lisp.h (STRING_BYTES_MAX): New macro.
7594 * alloc.c (Fmake_string):
7595 * character.c (string_escape_byte8):
7596 * coding.c (coding_alloc_by_realloc):
7597 * doprnt.c (doprnt):
7598 * editfns.c (Fformat):
7599 * eval.c (verror):
7600 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7601 since they may not be the same number.
7602 * editfns.c (Finsert_char):
7603 * fileio.c (Finsert_file_contents):
7604 Likewise for BUF_BYTES_MAX.
7605
7606 * image.c: Use ptrdiff_t, not int, for sizes.
7607 (slurp_file): Switch from int to ptrdiff_t.
7608 All uses changed.
7609 (slurp_file): Check that file size fits in both size_t (for
7610 malloc) and ptrdiff_t (for sanity and safety).
7611
7612 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7613 if b->modtime has its maximal value.
7614
7615 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7616
7617 Don't assume time_t can fit into int.
7618 * buffer.h (struct buffer.modtime): Now time_t, not int.
7619 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7620 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7621
7622 Minor fixes for signed vs unsigned integers.
7623 * character.h (MAYBE_UNIFY_CHAR):
7624 * charset.c (maybe_unify_char):
7625 * keyboard.c (read_char, reorder_modifiers):
7626 XINT -> XFASTINT, since the integer must be nonnegative.
7627 * ftfont.c (ftfont_spec_pattern):
7628 * keymap.c (access_keymap, silly_event_symbol_error):
7629 XUINT -> XFASTINT, since the integer must be nonnegative.
7630 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7631 since it makes no difference and we prefer signed.
7632 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7633 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7634 nonnegative.
7635
7636 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7637
7638 * window.h (Fwindow_frame): Declare.
7639
7640 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7641
7642 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7643 (SPARE_MEMORY): Always define.
7644 (LARGE_REQUEST): Remove.
7645 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7646
7647 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7648
7649 * lisp.h: Move EXFUNS for Fframe_root_window,
7650 Fframe_first_window and Fset_frame_selected_window to window.h.
7651
7652 * window.h: Move EXFUNS for Fframe_root_window,
7653 Fframe_first_window and Fset_frame_selected_window here from
7654 lisp.h.
7655
7656 * frame.c (Fwindow_frame, Fframe_first_window)
7657 (Fframe_root_window, Fframe_selected_window)
7658 (Fset_frame_selected_window): Move to window.c.
7659 (Factive_minibuffer_window): Move to minibuf.c.
7660 (Fother_visible_frames_p): New function.
7661
7662 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7663
7664 * window.c (decode_window, decode_any_window): Move up in code.
7665 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7666 (inhibit_frame_unsplittable): Remove unused variable.
7667 (Fwindow_buffer): Move up and rewrite doc-string.
7668 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7669 (Fwindow_prev): New functions.
7670 (Fwindow_frame): Move here from frame.c. Accept any window as
7671 argument.
7672 (Fframe_root_window, Fframe_first_window)
7673 (Fframe_selected_window): Move here from frame.c. Accept frame
7674 or arbitrary window as argument. Update doc-strings.
7675 (Fminibuffer_window): Move up in code.
7676 (Fwindow_minibuffer_p): Move up in code and simplify.
7677 (Fset_frame_selected_window): Move here from frame.c.
7678 Marginal rewrite.
7679 (Fselected_window, select_window, Fselect_window): Move up in
7680 code. Minor doc-string fixes.
7681
7682 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7683
7684 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7685 Do not assume that spare memory exists; that assumption is valid
7686 only if SYSTEM_MALLOC.
7687 (LARGE_REQUEST): New macro, so that the issue of large requests
7688 is separated from the issue of spare memory.
7689
7690 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7691
7692 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7693 format. (Bug#8806)
7694
7695 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7696
7697 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7698 before statements.
7699
7700 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7701
7702 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7703
7704 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7705
7706 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7707 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7708
7709 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7710
7711 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7712
7713 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7714
7715 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7716 (x_clipboard_manager_save): Add return value.
7717 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7718 New error handlers.
7719 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7720 Obey Vx_select_enable_clipboard_manager. Catch errors in
7721 x_clipboard_manager_save (Bug#8779).
7722 (Vx_select_enable_clipboard_manager): New variable.
7723 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7724
7725 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7726
7727 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7728
7729 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7730
7731 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7732 in the current matrix if keep_current_p is non-zero.
7733
7734 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7735
7736 * bidi.c (bidi_level_of_next_char): Fix last change.
7737
7738 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7739
7740 Support bidi reordering of text covered by display properties.
7741
7742 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7743 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7744 (bidi_cache_search, bidi_cache_iterator_state)
7745 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7746 (bidi_level_of_next_char, bidi_move_to_visually_next):
7747 Support character positions inside a run of characters covered by a
7748 display string.
7749 (bidi_paragraph_init, bidi_resolve_explicit_1)
7750 (bidi_level_of_next_char): Call bidi_fetch_char and
7751 bidi_fetch_char_advance instead of FETCH_CHAR and
7752 FETCH_CHAR_ADVANCE.
7753 (bidi_init_it): Initialize new members.
7754 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7755 definitions.
7756 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7757 instead of using explicit *_CHAR codes.
7758 (bidi_resolve_explicit, bidi_resolve_weak):
7759 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7760 bidirectional text is supported only in multibyte buffers.
7761 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7762 it to initialize the frame_window_p member of struct bidi_it.
7763 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7764 (bidi_resolve_explicit, bidi_resolve_weak)
7765 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7766 bidi_it->nchars is non-positive.
7767 (bidi_level_of_next_char): Don't try to lookup the cache for the
7768 next/previous character if nothing is cached there yet, or if we
7769 were just reseat()'ed to a new position.
7770
7771 * xdisp.c (set_cursor_from_row): Set start and stop points
7772 according to the row's direction when priming the loop that looks
7773 for the glyph on which to display cursor.
7774 (single_display_spec_intangible_p): Function deleted.
7775 (display_prop_intangible_p): Reimplement to call
7776 handle_display_spec instead of single_display_spec_intangible_p.
7777 Accept 3 additional arguments needed by handle_display_spec.
7778 This fixes incorrect cursor motion across display property with complex
7779 values: lists, `(when COND...)' forms, etc.
7780 (single_display_spec_string_p): Support property values that are
7781 lists with the argument STRING its top-level element.
7782 (display_prop_string_p): Fix the condition for processing a
7783 property that is a list to be consistent with handle_display_spec.
7784 (handle_display_spec): New function, refactored from the
7785 last portion of handle_display_prop.
7786 (compute_display_string_pos): Accept additional argument
7787 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7788 value of a `display' property is a "replacing spec".
7789 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7790 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7791 the display property, but just return a value indicating whether
7792 the display property will replace the characters it covers.
7793 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7794 frame_window_p members of struct bidi_it.
7795 (compute_display_string_pos, compute_display_string_end):
7796 New functions.
7797 (push_it): Accept second argument POSITION, where pop_it should
7798 jump to continue iteration.
7799 (reseat_1): Initialize bidi_it.disp_pos.
7800
7801 * keyboard.c (adjust_point_for_property): Adjust the call to
7802 display_prop_intangible_p to its new signature.
7803
7804 * dispextern.h (struct bidi_it): New member frame_window_p.
7805 (bidi_init_it): Update prototypes.
7806 (display_prop_intangible_p): Update prototype.
7807 (compute_display_string_pos, compute_display_string_end):
7808 Declare prototypes.
7809 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7810 EMACS_INT.
7811
7812 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7813
7814 Malloc failure behavior now depends on size of allocation.
7815 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7816 * lisp.h: Change signatures accordingly.
7817 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7818 All callers changed. (Bug#8762)
7819
7820 * gnutls.c: Use Emacs's memory allocators.
7821 Without this change, the gnutls library would invoke malloc etc.
7822 directly, which causes problems on non-SYNC_INPUT hosts, and which
7823 runs afoul of improving memory_full behavior. (Bug#8761)
7824 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7825 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7826 xfree instead of the default malloc, realloc, free.
7827 (Fgnutls_boot): No need to check for memory allocation failure,
7828 since xmalloc does that for us.
7829
7830 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7831 * category.c (hash_get_category_set):
7832 * ccl.c (ccl_driver):
7833 * charset.c (Fdefine_charset_internal):
7834 * charset.h (struct charset.hash_index):
7835 * composite.c (get_composition_id, gstring_lookup_cache)
7836 (composition_gstring_put_cache):
7837 * composite.h (struct composition.hash_index):
7838 * dispextern.h (struct image.hash):
7839 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7840 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7841 (hashfn_equal, hashfn_user_defined, make_hash_table)
7842 (maybe_resize_hash_table, hash_lookup, hash_put)
7843 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7844 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7845 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7846 * image.c (make_image, search_image_cache, lookup_image)
7847 (xpm_put_color_table_h):
7848 * lisp.h (struct Lisp_Hash_Table):
7849 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7850 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7851 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7852 * alloc.c (allocate_vectorlike):
7853 Check for overflow in vector size calculations.
7854 * ccl.c (ccl_driver):
7855 Check for overflow when converting EMACS_INT to int.
7856 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7857 need to be updated by these changes.
7858 * fns.c (make_hash_table, maybe_resize_hash_table):
7859 Check for integer overflow with large hash tables.
7860 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7861 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7862 (SXHASH_REDUCE): New macro.
7863 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7864 Use it instead of discarding useful hash info with large hash values.
7865 (sxhash_float): New function.
7866 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7867 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7868 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7869 Rewrite to use FIXNUM_BITS, as this simplifies things.
7870 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7871 Adjust signatures to match updated version of code.
7872 (consing_since_gc): Now EMACS_INT, since a single hash table can
7873 use more than INT_MAX bytes.
7874
7875 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7876
7877 Make it possible to build with GCC-4.6+ -O2 -flto.
7878
7879 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7880
7881 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7882
7883 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7884 Call minibuffer-inactive-mode.
7885
7886 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7887
7888 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7889 Update dependencies.
7890
7891 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7892
7893 * data.c (init_data): Remove code for UTS, this system is not
7894 supported anymore.
7895
7896 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7897
7898 Don't force ./temacs to start in terminal mode.
7899
7900 * frame.c (make_initial_frame): Initialize faces in all cases, not
7901 only when CANNOT_DUMP is defined.
7902 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7903
7904 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7905
7906 * dispnew.c (add_window_display_history): Use const for the string
7907 pointer. Remove declaration, not needed.
7908
7909 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7910
7911 Use 'inline', not 'INLINE'.
7912 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
7913 * alloc.c, fontset.c (INLINE): Remove.
7914 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7915 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7916 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7917 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7918 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7919
7920 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7921
7922 Make it possible to run ./temacs.
7923
7924 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7925 syms_of_callproc does the same thing. Remove test for
7926 "initialized", do it in the caller.
7927 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7928
7929 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7930
7931 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7932 (read_minibuf): Use get_minibuffer.
7933 (syms_of_minibuf): Use DEFSYM.
7934 (Qmetadata): New var.
7935 * data.c (Qbuffer): Don't make it static.
7936 (syms_of_data): Use DEFSYM.
7937
7938 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7939
7940 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7941 (CCL_CODE_MIN): New macro.
7942
7943 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7944
7945 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7946
7947 * eval.c (Qdebug): Now static.
7948 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7949 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7950 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7951
7952 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7953
7954 * image.c: Various fixes to ImageMagick code comments.
7955 (Fimagemagick_types): Doc fix.
7956
7957 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7958
7959 Minor fixes prompted by GCC 4.6.0 warnings.
7960
7961 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7962
7963 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7964 (x_clipboard_manager_save_all): Move extern decl to ...
7965 * xterm.h: ... here, so that it can be checked for consistency.
7966
7967 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7968
7969 * xselect.c (x_clipboard_manager_save_frame)
7970 (x_clipboard_manager_save_all): New functions.
7971 (Fx_clipboard_manager_save): Lisp function deleted.
7972
7973 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7974 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7975
7976 * xterm.h: Update prototype.
7977
7978 2011-05-28 William Xu <william.xwl@gmail.com>
7979
7980 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7981 exiting (Bug#8239).
7982
7983 2011-05-28 Jim Meyering <meyering@redhat.com>
7984
7985 Avoid a sign-extension bug in crypto_hash_function.
7986 * fns.c (to_uchar): Define.
7987 (crypto_hash_function): Use it to convert some newly-signed
7988 variables to unsigned, to avoid sign-extension bugs. For example,
7989 without this change, (md5 "truc") would evaluate to
7990 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7991 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
7992 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
7993
7994 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7995
7996 Integer overflow fixes.
7997
7998 * dbusbind.c: Serial number integer overflow fixes.
7999 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8000 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8001 to hold a serial number that is too large for a fixnum.
8002 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8003 Check for serial numbers out of range. Decode any serial number
8004 that was so large that it became a float. (Bug#8722)
8005
8006 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8007 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8008 Use XFASTINT rather than XUINT when numbers are nonnegative.
8009 (xd_append_arg, Fdbus_method_return_internal):
8010 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8011 arguments, check that Lisp number is nonnegative, rather than
8012 silently wrapping negative numbers around. (Bug#8722)
8013 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8014 (Bug#8722)
8015
8016 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8017
8018 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8019
8020 ccl: Add integer overflow checks.
8021 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8022 (IN_INT_RANGE): New macros.
8023 (ccl_driver): Use them to check for integer overflow when
8024 decoding a CCL program. Many of the new checks are whether XINT (x)
8025 fits in int; it doesn't always, on 64-bit hosts. The new version
8026 doesn't catch all possible integer overflows, but it's an
8027 improvement. (Bug#8719)
8028
8029 * alloc.c (make_event_array): Use XINT, not XUINT.
8030 There's no need for unsigned here.
8031
8032 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8033 This follows up to the 2011-05-06 change that substituted uintptr_t
8034 for EMACS_INT. This case wasn't caught back then.
8035
8036 Rework Fformat to avoid integer overflow issues.
8037 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8038 now (part of C89). Include <verify.h>.
8039 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8040 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8041 (Fformat): Avoid the prepass trying to compute sizes; it was only
8042 approximate and thus did not catch overflow reliably. Instead, walk
8043 through the format just once, formatting and computing sizes as we go,
8044 checking for integer overflow at every step, and allocating a larger
8045 buffer as needed. Keep track separately whether the format is
8046 multibyte. Keep only the most-recently calculated precision, rather
8047 than them all. Record whether each argument has been converted to
8048 string. Use EMACS_INT, not int, for byte and char and arg counts.
8049 Support field widths and precisions larger than INT_MAX. Avoid
8050 sprintf's undefined behavior with conversion specifications such as %#d
8051 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8052 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8053 formatting out-of-range floating point numbers with int
8054 formats. (Bug#8668)
8055
8056 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8057
8058 * data.c: Avoid integer truncation in expressions involving floats.
8059 * data.c: Include <intprops.h>.
8060 (arith_driver): When there's an integer overflow in an expression
8061 involving floating point, convert the integers to floating point
8062 so that the resulting value does not suffer from catastrophic
8063 integer truncation. For example, on a 64-bit host (* 4
8064 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8065 Do not rely on undefined behavior after integer overflow.
8066
8067 merge count_size_as_multibyte, parse_str_to_multibyte
8068 * character.c, character.h (count_size_as_multibyte):
8069 Rename from parse_str_to_multibyte; all uses changed.
8070 Check for integer overflow.
8071 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8072 since it's now a duplicate of the other. This is more of
8073 a character than a buffer op, so better that it's in character.c.
8074 * fns.c, print.c: Adjust to above changes.
8075
8076 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8077
8078 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8079
8080 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8081
8082 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8083 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8084 (x_clipboard_manager_save): Now static.
8085 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8086
8087 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8088 (crypto_hash_function): Now static.
8089 Fix pointer signedness problems. Avoid unnecessary initializations.
8090
8091 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8092
8093 * termhooks.h (Vselection_alist): Make it terminal-local.
8094
8095 * terminal.c (create_terminal): Initialize it.
8096
8097 * xselect.c: Support for clipboard managers.
8098 (Vselection_alist): Move to termhooks.h as terminal-local var.
8099 (LOCAL_SELECTION): New macro.
8100 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8101 (symbol_to_x_atom): Remove gratuitous arg.
8102 (x_handle_selection_request, lisp_data_to_selection_data)
8103 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8104 (x_own_selection, x_get_local_selection, x_convert_selection):
8105 New arg, specifying work frame. Use terminal-local Vselection_alist.
8106 (some_frame_on_display): Delete unused function.
8107 (Fx_own_selection_internal, Fx_get_selection_internal)
8108 (Fx_disown_selection_internal, Fx_selection_owner_p)
8109 (Fx_selection_exists_p): New optional frame arg.
8110 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8111 (x_handle_selection_clear): Don't treat other terminals with the
8112 same keyboard specially. Use the terminal-local Vselection_alist.
8113 (x_clear_frame_selections): Use Frun_hook_with_args.
8114
8115 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8116
8117 * xterm.h: Add support for those atoms.
8118
8119 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8120
8121 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8122 (converted_selections, conversion_fail_tag): New global variables.
8123 (x_selection_request_lisp_error): Free the above.
8124 (x_get_local_selection): Remove unnecessary code.
8125 (x_reply_selection_request): Args changed; handle arbitrary array
8126 of converted selections stored in converted_selections.
8127 Separate the XChangeProperty and SelectionNotify steps.
8128 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8129 (x_convert_selection): New function.
8130 (x_handle_selection_event): Simplify.
8131 (x_get_foreign_selection): Don't ignore incoming requests while
8132 waiting for an answer; this will fail when we implement
8133 SAVE_TARGETS, and seems unnecessary anyway.
8134 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8135 (Vx_sent_selection_functions): Doc fix.
8136
8137 2011-05-26 Leo Liu <sdl.web@gmail.com>
8138
8139 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8140
8141 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8142
8143 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8144
8145 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8146 for fringe update if it has periodic bitmap.
8147 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8148 and fringe_bitmap_periodic_p.
8149
8150 * fringe.c (get_fringe_bitmap_data): New function.
8151 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8152 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8153 row. Mark glyph row for fringe update if periodicity changed.
8154
8155 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8156 for fringe update unless it has periodic bitmap.
8157
8158 2011-05-25 Kenichi Handa <handa@m17n.org>
8159
8160 * xdisp.c (get_next_display_element): Set correct it->face_id for
8161 a static composition.
8162
8163 2011-05-24 Leo Liu <sdl.web@gmail.com>
8164
8165 * deps.mk (fns.o):
8166 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8167
8168 * fns.c (crypto_hash_function, Fsha1): New function.
8169 (Fmd5): Use crypto_hash_function.
8170 (syms_of_fns): Add Ssha1.
8171
8172 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8173
8174 * gnutls.c: Remove unused macros.
8175 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8176 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8177 Remove macros that are defined and never used.
8178 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8179
8180 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8181
8182 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8183 (Fx_get_selection_internal): Minor cleanup.
8184 (Fx_own_selection_internal): Rename arguments for consistency with
8185 select.el.
8186
8187 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8188
8189 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8190
8191 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8192
8193 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8194
8195 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8196
8197 * dispnew.c (scrolling_window): Don't exclude the case that the
8198 last enabled row in the desired matrix touches the bottom boundary.
8199
8200 2011-05-21 Glenn Morris <rgm@gnu.org>
8201
8202 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8203 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8204 and add some more files.
8205
8206 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8207
8208 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8209 report_file_error introduced by the change from 2011-05-07.
8210
8211 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8212
8213 * systime.h (Time): Define only if emacs is defined.
8214 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8215 where the include path doesn't have X11/X.h by default. See
8216 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8217
8218 2011-05-20 Kenichi Handa <handa@m17n.org>
8219
8220 * composite.c (find_automatic_composition): Fix previous change.
8221
8222 2011-05-20 Glenn Morris <rgm@gnu.org>
8223
8224 * lisp.mk: New file, split from Makefile.in.
8225 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8226 (shortlisp): Remove.
8227 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8228
8229 2011-05-19 Glenn Morris <rgm@gnu.org>
8230
8231 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8232 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8233 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8234 (lisp): Set the order to that of loadup.el.
8235 (shortlisp): Make it a copy of $lisp.
8236 (SOME_MACHINE_LISP): Remove.
8237 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8238 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8239
8240 2011-05-18 Kenichi Handa <handa@m17n.org>
8241
8242 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8243 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8244 (find_automatic_composition): Mostly rewrite for efficiency.
8245
8246 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8247
8248 * makefile.w32-in: Update dependencies.
8249
8250 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8251
8252 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8253 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8254
8255 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8256
8257 Fix some integer overflow issues, such as string length overflow.
8258
8259 * insdel.c (count_size_as_multibyte): Check for string overflow.
8260
8261 * character.c (lisp_string_width): Check for string overflow.
8262 Use EMACS_INT, not int, for string indexes and lengths; in
8263 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8264 the resulting string length overflows an EMACS_INT; instead,
8265 report a string overflow if no precision given. When checking for
8266 precision exhaustion, use a check that cannot possibly have
8267 integer overflow. (Bug#8675)
8268 * character.h (lisp_string_width): Adjust to new signature.
8269
8270 * alloc.c (string_overflow): New function.
8271 (Fmake_string): Use it. This doesn't change behavior, but saves
8272 a few bytes and will simplify future changes.
8273 * character.c (string_escape_byte8): Likewise.
8274 * lisp.h (string_overflow): New decl.
8275
8276 Fixups, following up to the user-interface timestamp change.
8277 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8278 for UI timestamps, instead of unsigned long.
8279 * msdos.c (mouse_get_pos): Likewise.
8280 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8281 * w32gui.h (Time): Define by including "systime.h" rather than by
8282 declaring it ourselves. (Bug#8664)
8283
8284 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8285 * image.c (clear_image_cache): Likewise.
8286
8287 * term.c (term_mouse_position): Don't assume time_t wraparound.
8288
8289 Be more systematic about user-interface timestamps.
8290 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8291 and sometimes 'EMACS_UINT', to represent these timestamps.
8292 This change causes it to use 'Time' uniformly, as that's what X uses.
8293 This makes the code easier to follow, and makes it easier to catch
8294 integer overflow bugs such as Bug#8664.
8295 * frame.c (Fmouse_position, Fmouse_pixel_position):
8296 Use Time, not unsigned long, for user-interface timestamps.
8297 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8298 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8299 * keyboard.h (last_event_timestamp): Likewise.
8300 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8301 * menu.h (xmenu_show): Likewise.
8302 * term.c (term_mouse_position): Likewise.
8303 * termhooks.h (struct input_event.timestamp): Likewise.
8304 (struct terminal.mouse_position_hook): Likewise.
8305 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8306 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8307 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8308 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8309 what it was before.
8310 * menu.h, termhooks.h: Include "systime.h", for Time.
8311
8312 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8313 Don't assume that the difference between two unsigned long values
8314 can fit into an integer. At this point, we know button_down_time
8315 <= event->timestamp, so the difference must be nonnegative, so
8316 there's no need to cast the result if double-click-time is
8317 nonnegative, as it should be; check that it's nonnegative, just in
8318 case. This bug is triggered when events are more than 2**31 ms
8319 apart (about 25 days). (Bug#8664)
8320
8321 * xselect.c (last_event_timestamp): Remove duplicate decl.
8322 (x_own_selection): Remove needless cast to unsigned long.
8323
8324 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8325 that always fit in int. Use a sentinel instead of a counter, to
8326 avoid a temp and to allay GCC's concerns about possible int overflow.
8327 * frame.h (struct frame): Use int for menu_bar_items_used
8328 instead of EMACS_INT, since it always fits in int.
8329
8330 * menu.c (grow_menu_items): Check for int overflow.
8331
8332 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8333
8334 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8335 Before, the code was not consistent. These values cannot exceed
8336 2**31 - 1 so there's no need to make them unsigned.
8337 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8338 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8339 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8340 as modifiers.
8341 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8342
8343 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8344 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8345 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8346 presumably because the widths might not match.
8347
8348 * window.c (size_window): Avoid needless test at loop start.
8349
8350 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8351
8352 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8353
8354 2011-05-12 Drew Adams <drew.adams@oracle.com>
8355
8356 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8357
8358 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8359
8360 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8361 `width' to `bar_area_x' and `bar_area_width', respectively.
8362 (x_scroll_run): Take account of fringe background extension.
8363
8364 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8365 Rename local vars `left' and `width' to `bar_area_x' and
8366 `bar_area_width', respectively.
8367 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8368 background extension.
8369
8370 2011-05-10 Jim Meyering <meyering@redhat.com>
8371
8372 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8373
8374 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8375
8376 * image.c (Finit_image_library): Return t for built-in image types,
8377 like pbm and xbm. (Bug#8640)
8378
8379 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8380
8381 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8382
8383 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8384
8385 * w32console.c (Fset_screen_color): Doc fix.
8386 (Fget_screen_color): New function.
8387 (syms_of_ntterm): Defsubr it.
8388
8389 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8390 unlink the temporary file if Fcall_process didn't create it in the
8391 first place.
8392 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8393 child process will be redirected to a file specified with `:file'.
8394 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8395 cue to call_process_cleanup not to close that handle.
8396
8397 2011-05-07 Ben Key <bkey76@gmail.com>
8398
8399 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8400 one of two shell specific rules, either bootstrap-temacs-CMD or
8401 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8402 to the previous implementation of the bootstrap-temacs rule.
8403 The bootstrap-temacs-CMD rule is similar to the previous
8404 implementation of the bootstrap-temacs rule except that it
8405 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8406 variable.
8407
8408 These changes, along with some changes to nt/configure.bat,
8409 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8410 earlier fix to add support for --cflags and --ldflags options
8411 that include quotes so that it works whether make uses cmd or
8412 sh as the shell.
8413
8414 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8415
8416 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8417 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8418 is a constant.
8419 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8420 a string. Handle both cases.
8421 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8422 (Fdbus_register_method): Use Qinvalid_function.
8423
8424 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8425
8426 * makefile.w32-in: Update dependencies.
8427 (LISP_H): Add inttypes.h and stdin.h.
8428 (PROCESS_H): Add unistd.h.
8429
8430 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8431
8432 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8433 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8434
8435 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8436
8437 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8438
8439 * term.c (vfatal): Remove stray call to va_end.
8440 It's not needed and the C Standard doesn't allow it here anyway.
8441
8442 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8443 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8444
8445 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8446 bytes.
8447
8448 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8449
8450 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8451
8452 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8453
8454 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8455
8456 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8457
8458 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8459 * charset.c (Fdefine_charset_internal): Don't initialize
8460 charset.code_space[15]. The value was garbage, on hosts with
8461 32-bit int (Bug#8600).
8462
8463 * lread.c (read_integer): Be more consistent with string-to-number.
8464 Use string_to_number to do the actual conversion; this avoids
8465 rounding errors and fixes some other screwups. Without this fix,
8466 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8467 (digit_to_number): Move earlier, for benefit of read_integer.
8468 Return -1 if the digit is out of range for the base, -2 if it is
8469 not a digit in any supported base. (Bug#8602)
8470
8471 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8472
8473 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8474 to match comment at start of function. This also removes a
8475 GCC warning about overflow in a 32+64-bit port.
8476
8477 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8478
8479 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8480 Reported by Stefan Monnier in
8481 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8482 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8483 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8484
8485 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8486 (EMACS_UINTPTR): Likewise, with uintptr_t.
8487
8488 * lisp.h: Prefer 64-bit EMACS_INT if available.
8489 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8490 on 32-bit hosts that have 64-bit int, so that they can access
8491 large files.
8492 However, temporarily disable this change unless the temporary
8493 symbol WIDE_EMACS_INT is defined.
8494
8495 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8496
8497 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8498 This removes an assumption that EMACS_INT and long are the same
8499 width as pointers. The assumption is true for Emacs porting targets
8500 now, but we want to make other targets possible.
8501 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8502 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8503 In the rest of the code, change types of integers that hold casted
8504 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8505 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8506 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8507 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8508 No need to cast type when ORing.
8509 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8510 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8511 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8512 assume EMACS_INT is the same width as char *.
8513 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8514 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8515 Remove no-longer-needed casts.
8516 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8517 (xg_tool_bar_help_callback, xg_make_tool_item):
8518 Use EMACS_INTPTR to hold an integer
8519 that will be cast to void *; this can avoid a GCC warning
8520 if EMACS_INT is not the same width as void *.
8521 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8522 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8523 (current_message_1, set_message_1):
8524 Use a local to convert to proper width without a cast.
8525 * xmenu.c (dialog_selection_callback): Likewise.
8526
8527 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8528 Also, don't assume VALBITS / RAND_BITS is less than 5,
8529 and don't rely on undefined behavior when shifting a 1 left into
8530 the sign bit.
8531 * lisp.h (get_random): Change signature to match.
8532
8533 * lread.c (hash_string): Use size_t, not int, for hash computation.
8534 Normally we prefer signed values; but hashing is special, because
8535 it's better to use unsigned division on hash table sizes so that
8536 the remainder is nonnegative. Also, size_t is the natural width
8537 for hashing into memory. The previous code used 'int', which doesn't
8538 retain enough info to hash well into very large tables.
8539 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8540
8541 * dbusbind.c: Don't possibly lose pointer info when converting.
8542 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8543 Use XPNTR rather than XHASH, so that the high-order bits of
8544 the pointer aren't lost when converting through void *.
8545
8546 * eval.c (Fautoload): Don't double-shift a pointer.
8547
8548 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8549
8550 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8551
8552 * gnutls.c (DEF_GNUTLS_FN):
8553 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8554
8555 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8556
8557 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8558 marker. (Bug#8610)
8559
8560 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8561
8562 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8563 New version that can reserve upto 2GB of heap space.
8564
8565 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8566
8567 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8568
8569 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8570
8571 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8572 `gnutls_certificate_set_x509_key_file'.
8573
8574 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8575
8576 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8577 Update dependencies.
8578
8579 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8580
8581 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8582 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8583 Remove unused parameter `fildes'.
8584 * process.c (read_process_output, send_process): Don't pass it.
8585
8586 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8587
8588 Fix previous change: the library cache is defined in w32.c.
8589 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8590 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8591
8592 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8593
8594 Implement dynamic loading of GnuTLS on Windows.
8595
8596 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8597 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8598 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8599 Declare.
8600
8601 * gnutls.c (Qgnutls_dll): Define.
8602 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8603 (gnutls_*): Declare function pointers.
8604 (init_gnutls_functions): New function to initialize function pointers.
8605 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8606 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8607 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8608 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8609 (emacs_gnutls_write, emacs_gnutls_read)
8610 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8611 (Fgnutls_available_p): New function.
8612 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8613 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8614 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8615
8616 * image.c: Include w32.h.
8617 (Vimage_type_cache): Delete.
8618 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8619 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8620 (w32_delayed_load): Move to w32.c.
8621
8622 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8623
8624 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8625 (w32_delayed_load): Move from image.c. When loading a library, record
8626 its filename in the :loaded-from property of the library id.
8627 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8628 Initialize and staticpro them.
8629 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8630
8631 * process.c: Include lisp.h before w32.h, not after.
8632 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8633 instead of gnutls_record_check_pending.
8634
8635 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8636
8637 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8638
8639 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8640 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8641 as passed in.
8642
8643 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8644
8645 * xterm.c (x_set_frame_alpha): Do not set property on anything
8646 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8647
8648 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8649
8650 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8651
8652 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8653
8654 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8655 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8656 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8657 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8658 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8659 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8660 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8661 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8662 (Qgnutls_bootprop_callbacks_verify): Make static.
8663
8664 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8665
8666 * callproc.c: Indentation fixup.
8667
8668 * sysdep.c (wait_for_termination_1): Make static.
8669 (wait_for_termination, interruptible_wait_for_termination):
8670 Move after wait_for_termination_1.
8671
8672 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8673
8674 * sysdep.c (interruptible_wait_for_termination): New function
8675 which is like wait_for_termination, but allows keyboard
8676 interruptions.
8677
8678 * callproc.c (Fcall_process): Add (:file "file") as an option for
8679 the STDOUT buffer.
8680 (Fcall_process_region): Ditto.
8681
8682 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8683
8684 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8685 rather than `XVECTOR (FOO)->size'.
8686
8687 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8688 inttypes.h, as a gnulib replacement is used if it not available in
8689 system headers.
8690
8691 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8692
8693 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8694 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8695 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8696
8697 * coding.c (coding_alloc_by_realloc): Error out if destination
8698 will grow beyond MOST_POSITIVE_FIXNUM.
8699 (decode_coding_emacs_mule): Abort if there isn't enough place in
8700 charbuf for the composition carryover bytes. Reserve an extra
8701 space for up to 2 characters produced in a loop.
8702 (decode_coding_iso_2022): Abort if there isn't enough place in
8703 charbuf for the composition carryover bytes.
8704
8705 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8706
8707 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8708 aborting when %lld or %lll format is passed.
8709 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8710 %llo or %llx format is passed. (Bug#8545)
8711
8712 * window.c (window_scroll_line_based): Use a marker instead of
8713 simple variables to record original value of point. (Bug#7952)
8714
8715 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8716 produced by %s or %c overflows available buffer space. (Bug#8545)
8717
8718 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8719
8720 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8721 (SIZE_MAX): Move defn after all includes, as they might #define it.
8722
8723 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8724
8725 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8726
8727 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8728
8729 * keyboard.c (Qdelayed_warnings_hook): Define.
8730 (command_loop_1): Run `delayed-warnings-hook'
8731 if Vdelayed_warnings_list is non-nil.
8732 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8733 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8734
8735 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8736
8737 * doprnt.c (doprnt): Don't return value smaller than the buffer
8738 size if the message was truncated. (Bug#8545).
8739
8740 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8741
8742 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8743 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8744
8745 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8746
8747 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8748
8749 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8750
8751 * makefile.w32-in: Update dependencies.
8752
8753 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8754
8755 Improve `doprnt' and its usage. (Bug#8545)
8756 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8757 `format_end'. Remove support for %l as a conversion specifier.
8758 Don't use xrealloc. Improve diagnostics when the %l size modifier
8759 is used. Update the commentary.
8760
8761 * eval.c (verror): Simplify calculation of size_t.
8762
8763 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8764 messages.
8765
8766 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8767
8768 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8769 change.
8770
8771 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8772
8773 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8774 This makes this file independent of the recent pseudovector change.
8775
8776 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8777
8778 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8779
8780 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8781 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8782 Remove unused local.
8783 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8784
8785 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8786 GCC 4.6.0 optimizes based on type-based alias analysis.
8787 For example, if b is of type struct buffer * and v of type struct
8788 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8789 != &v->size, and therefore "v->size = 1; b->size = 2; return
8790 v->size;" must therefore return 1. This assumption is incorrect
8791 for Emacs, since it type-puns struct Lisp_Vector * with many other
8792 types. To fix this problem, this patch adds a new type struct
8793 vectorlike_header that documents the constraints on layout of vectors
8794 and pseudovectors, and helps optimizing compilers not get fooled
8795 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8796 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8797 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8798 the size member.
8799 (XSETPVECTYPE): Rewrite in terms of new macro.
8800 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8801 This is a bit clearer, and further avoids the possibility of
8802 undesirable aliasing.
8803 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8804 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8805 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8806 since Lisp_Subr is a special case (no "next" field).
8807 (ASIZE): Now uses header.size rather than size.
8808 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8809 to avoid the hassle of writing XVECTOR (foo)->header.size.
8810 (struct vectorlike_header): New type.
8811 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8812 object, to help avoid aliasing.
8813 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8814 (SUBRP): Likewise, since Lisp_Subr is a special case.
8815 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8816 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8817 (struct Lisp_Hash_Table): Combine first two members into a single
8818 struct vectorlike_header member. All uses of "size" and "next" members
8819 changed to be "header.size" and "header.next".
8820 * buffer.h (struct buffer): Likewise.
8821 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8822 * frame.h (struct frame): Likewise.
8823 * process.h (struct Lisp_Process): Likewise.
8824 * termhooks.h (struct terminal): Likewise.
8825 * window.c (struct save_window_data, struct saved_window): Likewise.
8826 * window.h (struct window): Likewise.
8827 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8828 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8829 * buffer.c (init_buffer_once): Likewise.
8830 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8831 special case.
8832 * process.c (Fformat_network_address): Use local var for size,
8833 for brevity.
8834
8835 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8836
8837 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8838 * data.c (atof): Remove decl; no longer used or needed.
8839 (digit_to_number): Move to lread.c.
8840 (Fstring_to_number): Use new string_to_number function, to be
8841 consistent with how the Lisp reader treats infinities and NaNs.
8842 Do not assume that floating-point numbers represent EMACS_INT
8843 without losing information; this is not true on most 64-bit hosts.
8844 Avoid double-rounding errors, by insisting on integers when
8845 parsing non-base-10 numbers, as the documentation specifies.
8846 * lisp.h (string_to_number): New decl, replacing ...
8847 (isfloat_string): Remove.
8848 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8849 (read1): Do not accept +. and -. as integers; this
8850 appears to have been a coding error. Similarly, do not accept
8851 strings like +-1e0 as floating point numbers. Do not report
8852 overflow for integer overflows unless the base is not 10 which
8853 means we have no simple and reliable way to continue.
8854 Break out the floating-point parsing into a new
8855 function string_to_number, so that Fstring_to_number parses
8856 floating point numbers consistently with the Lisp reader.
8857 (digit_to_number): Move here from data.c. Make it static inline.
8858 (E_CHAR, EXP_INT): Remove, replacing with ...
8859 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8860 (string_to_number): New function, replacing isfloat_string.
8861 This function checks for valid syntax and produces the resulting
8862 Lisp float number too. Rework it so that string-to-number
8863 no longer mishandles examples like "1.0e+". Use strtoumax,
8864 so that overflow for non-base-10 numbers is reported only when
8865 there's no portable and simple way to convert to floating point.
8866
8867 * textprop.c (set_text_properties_1): Rewrite for clarity,
8868 and to avoid GCC warning about integer overflow.
8869
8870 * intervals.h (struct interval): Use EMACS_INT for members
8871 where EMACS_UINT might cause problems. See
8872 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8873 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8874 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8875 All uses changed.
8876 (offset_intervals): Tell GCC not to worry about length overflow
8877 when negating a negative length.
8878
8879 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8880 (overrun_check_free): Likewise.
8881
8882 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8883 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8884 word size.
8885
8886 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8887 (gnutls_make_error): Rename local to avoid shadowing.
8888 (gnutls_emacs_global_deinit): ifdef out; not used.
8889 (Fgnutls_boot): Use const for pointer to readonly storage.
8890 Comment out unused local. Fix pointer signedness problems.
8891
8892 * lread.c (openp): Don't stuff size_t into an 'int'.
8893 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8894 about possible signed overflow.
8895
8896 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8897 (GDK_KEY_g): Don't define if already defined.
8898 (xg_prepare_tooltip): Avoid pointer signedness problem.
8899 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8900
8901 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8902 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8903
8904 * xfns.c (Fx_window_property): Simplify a bit,
8905 to make a bit faster and to avoid GCC 4.6.0 warning.
8906 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8907
8908 * fns.c (internal_equal): Don't assume size_t fits in int.
8909
8910 * alloc.c (compact_small_strings): Tighten assertion a little.
8911
8912 Replace pEd with more-general pI, and fix some printf arg casts.
8913 * lisp.h (pI): New macro, generalizing old pEd macro to other
8914 conversion specifiers. For example, use "...%"pI"d..." rather
8915 than "...%"pEd"...".
8916 (pEd): Remove. All uses replaced with similar uses of pI.
8917 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
8918 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8919 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8920 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8921 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8922 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8923 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8924 64-bit hosts.
8925 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8926 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8927 * print.c (safe_debug_print, print_object): Likewise.
8928 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8929 to int.
8930 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8931 avoiding the 0 flag, which is not portable.
8932 * process.c (Fmake_network_process): Use pI to avoid cast.
8933 * region-cache.c (pp_cache): Likewise.
8934 * xdisp.c (decode_mode_spec): Likewise.
8935 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8936 behavior on 64-bit hosts with printf arg.
8937 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
8938 (x_stop_queuing_selection_requests): Likewise.
8939 (x_get_window_property): Don't truncate byte count to an 'int'
8940 when tracing.
8941
8942 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8943 here, since it parses constructs like leading '-' and spaces,
8944 which are not wanted; and it overflows with large numbers.
8945 Instead, simply match F[0-9]+, which is what is wanted anyway.
8946
8947 * alloc.c: Remove unportable assumptions about struct layout.
8948 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8949 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8950 (allocate_vectorlike, make_pure_vector): Use the new macros,
8951 plus offsetof, to remove unportable assumptions about struct layout.
8952 These assumptions hold on all porting targets that I know of, but
8953 they are not guaranteed, they're easy to remove, and removing them
8954 makes further changes easier.
8955
8956 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8957 This doesn't fix a bug but makes the code clearer.
8958 (string_overrun_cookie): Now const. Use initializers that
8959 don't formally overflow signed char, to avoid warnings.
8960 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8961 can cause Emacs to crash when string overrun checking is enabled.
8962 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8963 multiple of sizeof (EMACS_INT); it need not be, if
8964 alignof(EMACS_INT) < sizeof (EMACS_INT).
8965 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
8966
8967 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
8968
8969 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8970
8971 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8972
8973 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
8974 supposed to be handshaking. (Bug#8556)
8975 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8976
8977 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
8978
8979 * lisp.h (Qdebug): List symbol.
8980 * eval.c (Qdebug): Restore global linkage.
8981 * keyboard.c (debug-on-event): New variable.
8982 (handle_user_signal): Break into debugger when debug-on-event
8983 matches the current signal symbol.
8984
8985 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8986
8987 * alloc.c (check_sblock, check_string_bytes)
8988 (check_string_free_list): Convert to standard C.
8989
8990 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8991
8992 * w32.c (emacs_gnutls_push): Fix typo.
8993
8994 2011-04-25 Eli Zaretskii <eliz@gnu.org>
8995
8996 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8997 "cast to pointer from integer of different size".
8998
8999 Improve doprnt and its use in verror. (Bug#8545)
9000 * doprnt.c (doprnt): Document the set of format control sequences
9001 supported by the function. Use SAFE_ALLOCA instead of always
9002 using `alloca'.
9003
9004 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9005 is one byte too soon. Don't use xrealloc; instead xfree and
9006 xmalloc anew.
9007
9008 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9009
9010 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9011 callbacks stage.
9012
9013 * gnutls.c: Renamed global_initialized to
9014 gnutls_global_initialized. Added internals for the
9015 :verify-hostname-error, :verify-error, and :verify-flags
9016 parameters of `gnutls-boot' and documented those parameters in the
9017 docstring. Start callback support.
9018 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9019 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9020 on error. Return error code.
9021 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9022 (emacs_gnutls_read): Likewise.
9023 (Fgnutls_boot): Return handshake error code.
9024 (emacs_gnutls_handle_error): New function.
9025 (wsaerror_to_errno): Likewise.
9026
9027 * w32.h (emacs_gnutls_pull): Add prototype.
9028 (emacs_gnutls_push): Likewise.
9029
9030 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9031 (emacs_gnutls_push): Likewise.
9032
9033 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9034
9035 * process.c (wait_reading_process_output): Check if GnuTLS
9036 buffered some data internally if no FDs are set for TLS
9037 connections.
9038
9039 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9040 (LIBS): Link to USER_LIBS.
9041 ($(BLD)/gnutls.$(0)): New target.
9042
9043 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9044
9045 * xdisp.c (handle_single_display_spec): Rename the
9046 display_replaced_before_p argument into display_replaced_p, to
9047 make it consistent with the commentary. Fix typos in the
9048 commentary.
9049
9050 * textprop.c (syms_of_textprop): Remove dead code.
9051 (copy_text_properties): Delete obsolete commentary about an
9052 interface that was deleted long ago. Fix typos in the description
9053 of arguments.
9054
9055 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9056 to changes in oldXMenu/XMenu.h from 2011-04-16.
9057 <menu_help_message, prev_menu_help_message>: Constify.
9058 (IT_menu_make_room): menu->help_text is now `const char **';
9059 adjust.
9060
9061 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9062 to changes in oldXMenu/XMenu.h from 2011-04-16.
9063 (struct XMenu): Declare `help_text' `const char **'.
9064
9065 * xfaces.c <Qunspecified>: Make extern again.
9066
9067 * syntax.c: Include sys/types.h before including regex.h, as
9068 required by POSIX.
9069
9070 * doc.c (get_doc_string): Improve the format passed to `error'.
9071
9072 * doprnt.c (doprnt): Improve commentary.
9073
9074 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9075
9076 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9077 them with etags.
9078
9079 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9080 changes in globals.h immediately force recompilation.
9081 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9082 $(CURDIR)/s/ms-w32.h.
9083 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9084
9085 * character.c (Fchar_direction): Function deleted.
9086 (syms_of_character): Don't defsubr it.
9087 <char-direction-table>: Deleted.
9088
9089 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9090
9091 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9092 * doprnt.c: Include limits.h.
9093 (SIZE_MAX): New macro.
9094 (doprnt): Return a size_t value. 2nd arg is now size_t.
9095 Many local variables are now size_t instead of int or unsigned.
9096 Improve overflow protection. Support `l' modifier for integer
9097 conversions. Support %l conversion. Don't assume an EMACS_INT
9098 argument for integer conversions and for %c.
9099
9100 * lisp.h (doprnt): Restore prototype.
9101
9102 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9103 $(SRC)/character.h.
9104
9105 * Makefile.in (base_obj): Add back doprnt.o.
9106
9107 * deps.mk (doprnt.o): Add back prerequisites.
9108 (callint.o): Depend on character.h.
9109
9110 * eval.c (internal_lisp_condition_case): Include the handler
9111 representation in the error message.
9112 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9113 when breaking from the loop.
9114
9115 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9116
9117 * callint.c (Fcall_interactively): When displaying error message
9118 about invalid control letter, pass the character's codepoint, not
9119 a pointer to its multibyte form. Improve display of the character
9120 in octal and display also its hex code.
9121
9122 * character.c (char_string): Use %x to display the (unsigned)
9123 codepoint of an invalid character, to avoid displaying a bogus
9124 negative value.
9125
9126 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9127 `error', not SYMBOL_NAME itself.
9128
9129 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9130 character arguments to `error'.
9131
9132 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9133 to `error' in error message about FINAL_CHAR argument. Make sure
9134 FINAL_CHAR is a character, and use %c when it is passed as
9135 argument to `error'.
9136
9137 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9138
9139 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9140
9141 * w32.c: Include <time.h>.
9142 (sys_localtime): New function.
9143
9144 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9145
9146 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9147
9148 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9149
9150 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9151
9152 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9153 zombies (Bug#8467).
9154
9155 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9156
9157 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9158 gl_state.e_property when gl_state.object is Qt.
9159
9160 * insdel.c (make_gap_larger): Remove limitation of buffer size
9161 to <= INT_MAX.
9162
9163 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9164
9165 * xdisp.c (lookup_glyphless_char_display)
9166 (produce_glyphless_glyph): Handle cons cell entry in
9167 glyphless-char-display.
9168 (Vglyphless_char_display): Document it.
9169
9170 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9171 glyphless-char-display.
9172
9173 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9174
9175 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9176
9177 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9178
9179 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9180 definition for no-X builds.
9181
9182 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9183
9184 Static checks with GCC 4.6.0 and non-default toolkits.
9185
9186 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9187
9188 * process.c (keyboard_bit_set): Define only if SIGIO.
9189 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9190 (send_process): Repair possible setjmp clobbering.
9191
9192 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9193
9194 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9195
9196 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9197
9198 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9199 Define only if needed.
9200
9201 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9202 by pacifying GCC about it. Maybe it's time to retire it?
9203 * xfaces.c (USG, __TIMEVAL__): Likewise.
9204
9205 * dispextern.h (struct redisplay_interface): Rename param
9206 to avoid shadowing.
9207 * termhooks.h (struct terminal): Likewise.
9208 * xterm.c (xembed_send_message): Likewise.
9209
9210 * insdel.c (make_gap_smaller): Define only if
9211 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9212
9213 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9214 it.
9215
9216 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9217 so that we aren't warned about unused symbols.
9218
9219 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9220
9221 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9222
9223 * xfns.c (x_real_positions): Mark locals as initialized.
9224
9225 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9226
9227 * xterm.c: Fix problems found by static analysis with other toolkits.
9228 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9229 (x_dispatch_event): Declare static if USE_GTK, and
9230 define if USE_GTK || USE_X_TOOLKIT.
9231 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9232 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9233 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9234 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9235
9236 * xmenu.c (menu_help_callback): Pointer type fixes.
9237 Use const pointers when pointing at readonly data. Avoid pointer
9238 signedness clashes.
9239 (FALSE): Remove unused macro.
9240 (update_frame_menubar): Remove unused decl.
9241
9242 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9243
9244 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9245 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9246 (single_menu_item): Rename local to avoid shadowing.
9247
9248 * keyboard.c (make_lispy_event): Remove unused local var.
9249
9250 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9251 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9252
9253 * bitmaps: Change bitmaps from unsigned char back to the X11
9254 compatible char. Avoid the old compiler warnings about
9255 out-of-range initializers by using, for example, '\xab' rather
9256 than 0xab.
9257
9258 * xgselect.c (xgselect_initialize): Check vs interface
9259 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9260
9261 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9262
9263 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9264 to read-only memory.
9265
9266 * fns.c (vector): Remove; this old hack is no longer needed.
9267
9268 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9269 Remove unused var.
9270 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9271
9272 * xrdb.c (x_load_resources): Omit unused local.
9273
9274 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9275 (x_window): Rename locals to avoid shadowing.
9276 (USG): Use the kludged USG macro, to pacify gcc.
9277
9278 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9279 (x_term_init): Remove local to avoid shadowing.
9280
9281 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9282
9283 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9284 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9285
9286 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9287
9288 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9289
9290 Fix regex.c, syntax.c and friends for buffers > 2GB.
9291 * syntax.h (struct gl_state_s): Declare character position members
9292 EMACS_INT.
9293
9294 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9295
9296 * textprop.c (verify_interval_modification, interval_of):
9297 Declare arguments EMACS_INT.
9298
9299 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9300 EMACS_INT.
9301
9302 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9303
9304 * indent.c (Fvertical_motion): Local variable it_start is now
9305 EMACS_INT.
9306
9307 * regex.c (re_match, re_match_2, re_match_2_internal)
9308 (bcmp_translate, regcomp, regexec, print_double_string)
9309 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9310 (re_compile_pattern, re_exec): Declare arguments and local
9311 variables `size_t' and `ssize_t' and return values `regoff_t', as
9312 appropriate.
9313 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9314 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9315 <compile_stack_type>: `size' and `avail' are now `size_t'.
9316
9317 * regex.h <regoff_t>: Use ssize_t, not int.
9318 (re_search, re_search_2, re_match, re_match_2): Arguments that
9319 specify buffer/string position and length are now ssize_t and
9320 size_t. Return type is regoff_t.
9321
9322 2011-04-16 Ben Key <bkey76@gmail.com>
9323
9324 * nsfont.m: Fixed bugs in ns_get_family and
9325 ns_descriptor_to_entity that were caused by using free to
9326 deallocate memory blocks that were allocated by xmalloc (via
9327 xstrdup). This caused Emacs to crash when compiled with
9328 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9329 --enable-checking=xmallocoverrun). xfree is now used to
9330 deallocate these memory blocks.
9331
9332 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9333
9334 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9335
9336 emacs_write: Accept and return EMACS_INT for sizes.
9337 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9338 et seq.
9339 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9340 Accept and return EMACS_INT.
9341 (emacs_gnutls_write): Return the number of bytes written on
9342 partial writes.
9343 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9344 (emacs_read, emacs_write): Remove check for negative size, as the
9345 Emacs source code has been audited now.
9346 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9347 (emacs_read, emacs_write): Use it.
9348 * process.c (send_process): Adjust to the new signatures of
9349 emacs_write and emacs_gnutls_write. Do not attempt to store
9350 a byte offset into an 'int'; it might overflow.
9351 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9352
9353 * sound.c: Don't assume sizes fit in 'int'.
9354 (struct sound_device.period_size, alsa_period_size):
9355 Return EMACS_INT, not int.
9356 (struct sound_device.write, vox_write, alsa_write):
9357 Accept EMACS_INT, not int.
9358 (wav_play, au_play): Use EMACS_INT to store sizes and to
9359 record read return values.
9360
9361 2011-04-15 Ben Key <bkey76@gmail.com>
9362
9363 * keyboard.c (Qundefined): Don't declare static since it is used
9364 in nsfns.m.
9365 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9366 static since they are used in nsfont.m.
9367
9368 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9369
9370 * process.c (Qprocessp): Don't declare static.
9371 * lisp.h (Qprocessp): Declare again.
9372
9373 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9374
9375 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9376
9377 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9378
9379 Improve C-level modularity by making more things 'static'.
9380
9381 Don't publish debugger-only interfaces to other modules.
9382 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9383 (verify_bytepos, count_markers): Move decls to the only modules
9384 that need them.
9385 * region-cache.h (pp_cache): Likewise.
9386 * window.h (check_all_windows): Likewise.
9387 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9388
9389 * sysdep.c (croak): Now static, if
9390 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9391 * syssignal.h (croak): Declare only if not static.
9392
9393 * alloc.c (refill_memory_reserve): Now static if
9394 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9395 * lisp.h (refill_memory_reserve): Declare only if not static.
9396
9397 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9398 Define only if USE_LUCID.
9399
9400 * xrdb.c (x_customization_string, x_rm_string): Now static.
9401
9402 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9403 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9404
9405 * xdisp.c (draw_row_with_mouse_face): Now static.
9406 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9407
9408 * window.h (check_all_windows): Mark externally visible.
9409
9410 * window.c (window_deletion_count): Now static.
9411
9412 * undo.c: Make symbols static if they're not exported.
9413 (last_undo_buffer, last_boundary_position, pending_boundary):
9414 Now static.
9415
9416 * textprop.c (interval_insert_behind_hooks): Now static.
9417 (interval_insert_in_front_hooks): Likewise.
9418
9419 * term.c: Make symbols static if they're not exported.
9420 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9421 (max_frame_lines, tty_set_terminal_modes):
9422 (tty_reset_terminal_modes, tty_turn_off_highlight):
9423 (get_tty_terminal): Now static.
9424 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9425 * termhooks.h (term_mouse_moveto): Do not declare if
9426 HAVE_WINDOW_SYSTEM.
9427 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9428 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9429
9430 * sysdep.c: Make symbols static if they're not exported.
9431 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9432 Now static.
9433 (sigprocmask_set, full_mask): Remove; unused.
9434 (wait_debugging): Mark as visible.
9435 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9436 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9437
9438 * syntax.c (syntax_temp): Define only if !__GNUC__.
9439
9440 * sound.c (current_sound_device, current_sound): Now static.
9441
9442 * search.c (searchbufs, searchbuf_head): Now static.
9443
9444 * scroll.c (scroll_cost): Remove; unused.
9445 * dispextern.h (scroll_cost): Remove decl.
9446
9447 * region-cache.h (pp_cache): Mark as externally visible.
9448
9449 * process.c: Make symbols static if they're not exported.
9450 (process_tick, update_tick, create_process, chan_process):
9451 (Vprocess_alist, proc_buffered_char, datagram_access):
9452 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9453 (deactivate_process): Mark defn as static, as well as decl.
9454 * lisp.h (create_process): Remove decl.
9455 * process.h (chan_process, Vprocess_alist): Remove decls.
9456
9457 * print.c: Make symbols static if they're not exported.
9458 (print_depth, new_backquote_output, being_printed, print_buffer):
9459 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9460 (print_interval, print_number_index, initial_stderr_stream):
9461 Now static.
9462 * lisp.h (Fprinc): Remove decl.
9463 (debug_output_compilation_hack): Mark as externally visible.
9464
9465 * sysdep.c (croak): Move decl from here to syssignal.h.
9466 * syssignal.h (croak): Put it here, so the API can be checked when
9467 'croak' is called from dissociate_if_controlling_tty.
9468
9469 * minibuf.c: Make symbols static if they're not exported.
9470 (minibuf_save_list, choose_minibuf_frame): Now static.
9471 * lisp.h (choose_minibuf_frame): Remove decl.
9472
9473 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9474
9475 * lread.c: Make symbols static if they're not exported.
9476 (read_objects, initial_obarray, oblookup_last_bucket_number):
9477 Now static.
9478 (make_symbol): Remove; unused.
9479 * lisp.h (initial_obarray, make_symbol): Remove decls.
9480
9481 * keyboard.c: Make symbols static if they're not exported.
9482 (single_kboard, recent_keys_index, total_keys, recent_keys):
9483 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9484 (this_single_command_key_start, echoing, last_auto_save):
9485 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9486 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9487 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9488 (Vlispy_mouse_stem, double_click_count):
9489 Now static.
9490 (force_auto_save_soon): Define only if SIGDANGER.
9491 (ignore_mouse_drag_p): Now static if
9492 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9493 (print_help): Remove; unused.
9494 (stop_character, last_timer_event): Mark as externally visible.
9495 * keyboard.h (ignore_mouse_drag_p): Declare only if
9496 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9497 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9498 * lisp.h (echoing): Remove decl.
9499 (force_auto_save_soon): Declare only if SIGDANGER.
9500 * xdisp.c (redisplay_window): Simplify code, to make it more
9501 obvious that ignore_mouse_drag_p is not accessed if !defined
9502 USE_GTK && !defined HAVE_NS.
9503
9504 * intervals.c: Make symbols static if they're not exported.
9505 (merge_properties_sticky, merge_interval_right, delete_interval):
9506 Now static.
9507 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9508
9509 * insdel.c: Make symbols static if they're not exported.
9510 However, leave prepare_to_modify_buffer alone. It's never
9511 called from outside this function, but that appears to be a bug.
9512 (combine_after_change_list, combine_after_change_buffer):
9513 (adjust_after_replace, signal_before_change): Now static.
9514 (adjust_after_replace_noundo): Remove; unused.
9515 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9516 (signal_before_change): Remove decls.
9517
9518 * indent.c (val_compute_motion, val_vmotion): Now static.
9519
9520 * image.c: Make symbols static if they're not exported.
9521 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9522 if USE_GTK.
9523 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9524 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9525
9526 * fringe.c (standard_bitmaps): Now static.
9527 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9528
9529 * frame.c: Make symbols static if they're not exported.
9530 (x_report_frame_params, make_terminal_frame): Now static.
9531 (get_frame_param): Now static, unless HAVE_NS.
9532 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9533 (x_get_resource_string): Remove; not used.
9534 * frame.h (make_terminal_frame, x_report_frame_params):
9535 (x_get_resource_string); Remove decls.
9536 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9537 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9538
9539 * font.c, fontset.c: Make symbols static if they're not exported.
9540 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9541 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9542 * font.c (font_close_object): Now static.
9543 * font.h (font_close_object): Remove.
9544 * fontset.c (FONTSET_OBJLIST): Remove.
9545 (free_realized_fontset) #if-0 the body, which does nothing.
9546 (face_suitable_for_char_p): #if-0, as it's never called.
9547 * fontset.h (face_suitable_for_char_p): Remove decl.
9548 * xfaces.c (face_at_string_position):
9549 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9550 since 0 is always ASCII.
9551
9552 * fns.c (weak_hash_tables): Now static.
9553
9554 * fileio.c: Make symbols static if they're not exported.
9555 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9556 (Vwrite_region_annotation_buffers): Now static.
9557
9558 * eval.c: Make symbols static if they're not exported.
9559 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9560 * lisp.h (backtrace_list): Remove decl.
9561
9562 * emacs.c: Make symbols static if they're not exported.
9563 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9564 (fatal_error_code, fatal_error_signal_hook, standard_args):
9565 Now static.
9566 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9567 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9568 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9569 * lisp.h (fatal_error_signal_hook): Remove decl.
9570 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9571
9572 * editfns.c: Move a (normally-unused) function to its only use.
9573 * editfns.c, lisp.h (get_operating_system_release): Remove.
9574 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9575 worth the hassle of breaking this out.
9576
9577 * xterm.c: Make symbols static if they're not exported.
9578 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9579 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9580 (x_destroy_window, x_delete_display):
9581 Now static.
9582 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9583 (x_mouse_leave): Remove; unused.
9584 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9585 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9586 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9587 Remove decls.
9588 (x_mouse_leave): Declare only if WINDOWSNT.
9589 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9590 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9591 USE_X_TOOLKIT.
9592
9593 * ftxfont.c: Make symbols static if they're not exported.
9594 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9595 HAVE_FREETYPE.
9596 * font.h (ftxfont_driver): Likewise.
9597
9598 * xfns.c: Make symbols static if they're not exported.
9599 (x_last_font_name, x_display_info_for_name):
9600 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9601 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9602 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9603 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9604 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9605 (last_show_tip_args): Now static.
9606 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9607 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9608 (x_screen_planes): Remove; unused.
9609 * dispextern.h (x_screen_planes): Remove decl.
9610
9611 * dispnew.c: Make symbols static if they're not exported.
9612 * dispextern.h (redraw_garbaged_frames, scrolling):
9613 (increment_row_positions): Remove.
9614 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9615 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9616 Now static.
9617 (redraw_garbaged_frames): Remove; unused.
9618
9619 * xfaces.c: Make symbols static if they're not exported.
9620 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9621 Remove decls.
9622 * xterm.h (defined_color): Remove decls.
9623 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9624 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9625 (menu_face_changed_default, defined_color, free_realized_face):
9626 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9627 (ascii_face_of_lisp_face): Remove; unused.
9628
9629 * xdisp.c: Make symbols static if they're not exported.
9630 * dispextern.h (scratch_glyph_row, window_box_edges):
9631 (glyph_to_pixel_coords, set_cursor_from_row):
9632 (get_next_display_element, set_iterator_to_next):
9633 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9634 (show_mouse_face): Remove decls
9635 * frame.h (message_buf_print): Likewise.
9636 * lisp.h (pop_message, set_message, check_point_in_composition):
9637 Likewise.
9638 * xterm.h (set_vertical_scroll_bar): Likewise.
9639 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9640 (message_buf_print, scratch_glyph_row, displayed_buffer):
9641 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9642 (get_next_display_element, show_mouse_face, window_box_edges):
9643 (frame_to_window_pixel_xy, check_point_in_composition):
9644 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9645 (glyph_to_pixel_coords): Remove; unused.
9646
9647 * dired.c (file_name_completion): Now static.
9648
9649 * dbusbind.c (xd_in_read_queued_messages): Now static.
9650
9651 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9652 * data.c (circular_list_error): Remove.
9653
9654 * commands.h (last_point_position, last_point_position_buffer):
9655 (last_point_position_window): Remove decls.
9656 * keyboard.c: Make these variables static.
9657
9658 * coding.h (coding, code_convert_region, encode_coding_gap):
9659 Remove decls.
9660 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9661 (iso_code_class, detect_coding, code_convert_region): Now static.
9662 (encode_coding_gap): Remove; unused.
9663
9664 * chartab.c (chartab_chars, chartab_bits): Now static.
9665
9666 * charset.h (charset_iso_8859_1): Remove decl.
9667 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9668 Now static.
9669
9670 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9671 * ccl.c (Vccl_program_table): Now static.
9672 (check_ccl_update): Remove; unused.
9673
9674 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9675 * category.h: ... from here.
9676 * category.c (check_category_table, set_category_set): Now static.
9677
9678 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9679 * lisp.h: Remove these decls.
9680
9681 * buffer.c (buffer_count): Remove unused var.
9682
9683 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9684 so that it's not optimized away.
9685 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9686 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9687 exported only to the debugger.
9688
9689 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9690 * atimer.h (run_all_atimers): Remove; not exported.
9691
9692 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9693 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9694 was inaccessible from Lisp.
9695 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9696 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9697
9698 alloc.c: Import and export fewer symbols, and remove unused items.
9699 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9700 is defined.
9701 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9702 it's not optimized away by whole-program optimization.
9703 (message_enable_multibyte, free_misc): Remove.
9704 (catchlist, handlerlist, mark_backtrace):
9705 Declare only if BYTE_MARK_STACK.
9706 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9707 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9708 (message_enable_multibyte): Remove decl.
9709 (free_misc, interval_free_list, float_block, float_block_index):
9710 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9711 (cons_free_list, last_marked_index):
9712 Now static.
9713 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9714 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9715 (mark_backtrace): Define only if BYTE_MARK_STACK.
9716 * xdisp.c (message_enable_multibyte): Now static.
9717
9718 Declare Lisp_Object Q* variables to be 'static' if not exported.
9719 This makes it easier for human readers (and static analyzers)
9720 to see whether these variables are used from other modules.
9721 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9722 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9723 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9724 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9725 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9726 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9727 * xmenu.c, xselect.c:
9728 Declare Q* vars static if they are not used in other modules.
9729 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9730 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9731 Remove decls of unexported vars.
9732 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9733
9734 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9735
9736 Make Emacs functions such as Fatom 'static' by default.
9737 This makes it easier for human readers (and static analyzers)
9738 to see whether these functions can be called from other modules.
9739 DEFUN now defines a static function. To make the function external
9740 so that it can be used in other C modules, use the new macro DEFUE.
9741 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9742 (Finit_image_library):
9743 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9744 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9745 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9746 Remove decls, since these functions are now static.
9747 (Funintern, Fget_internal_run_time): New decls, since these functions
9748 were already external.
9749
9750 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9751 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9752 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9753 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9754 * keyboard.c, keymap.c, lread.c:
9755 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9756 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9757 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9758 Mark functions with DEFUE instead of DEFUN,
9759 if they are used in other modules.
9760 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9761 decls for now-static functions.
9762 * buffer.h (Fdelete_overlay): Remove decl.
9763 * callproc.c (Fgetenv_internal): Mark as internal.
9764 * composite.c (Fremove_list_of_text_properties): Remove decl.
9765 (Fcomposition_get_gstring): New forward static decl.
9766 * composite.h (Fcomposite_get_gstring): Remove decl.
9767 * dired.c (Ffile_attributes): New forward static decl.
9768 * doc.c (Fdocumntation_property): New forward static decl.
9769 * eval.c (Ffetch_bytecode): New forward static decl.
9770 (Funintern): Remove extern decl; now in .h file where it belongs.
9771 * fileio.c (Fmake_symbolic_link): New forward static decl.
9772 * image.c (Finit_image_library): New forward static decl.
9773 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9774 * intervals.h (Fprevious_property_change):
9775 (Fremove_list_of_text_properties): Remove decls.
9776 * keyboard.c (Fthis_command_keys): Remove decl.
9777 (Fcommand_execute): New forward static decl.
9778 * keymap.c (Flookup_key): New forward static decl.
9779 (Fcopy_keymap): Now static.
9780 * keymap.h (Flookup_key): Remove decl.
9781 * process.c (Fget_process): New forward static decl.
9782 (Fprocess_datagram_address): Mark as internal.
9783 * syntax.c (Fsyntax_table_p): New forward static decl.
9784 (skip_chars): Remove duplicate decl.
9785 * textprop.c (Fprevious_property_change): New forward static decl.
9786 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9787 Now internal.
9788 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9789 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9790
9791 * editfns.c (Fformat): Remove unreachable code.
9792
9793 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9794
9795 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9796 change. (Bug#8496)
9797
9798 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9799
9800 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9801 when at ZV. (Bug#8487)
9802
9803 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9804
9805 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9806 (Bug#8437)
9807 * keyboard.c (parse_tool_bar_item): Likewise.
9808 * sound.c (sound_cleanup, alsa_close): Likewise.
9809 * termcap.c (tgetent): Likewise.
9810 * xfns.c (x_default_font_parameter): Likewise.
9811 * xsettings.c (read_and_apply_settings): Likewise.
9812
9813 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9814 (overrun_check_free): Protoize.
9815
9816 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9817
9818 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9819 since callers should never pass a negative size.
9820 Change the signature to match that of plain 'read' and 'write'; see
9821 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9822 * lisp.h: Update prototypes of emacs_write and emacs_read.
9823
9824 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9825
9826 * xdisp.c (redisplay_window): Don't try to determine the character
9827 position of the scroll margin if the window start point w->startp
9828 is outside the buffer's accessible region. (Bug#8468)
9829
9830 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9831
9832 Fix write-region and its subroutines for buffers > 2GB.
9833 * fileio.c (a_write, e_write): Modify declaration of arguments and
9834 local variables to support buffers larger than 2GB.
9835 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9836
9837 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9838 argument, local variables, and return value.
9839
9840 * lisp.h: Update prototypes of emacs_write and emacs_read.
9841
9842 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9843
9844 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9845
9846 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9847
9848 Fix more problems found by GCC 4.6.0's static checks.
9849
9850 * xdisp.c (vmessage): Use a better test for character truncation.
9851
9852 * charset.c (load_charset_map): <, not <=, for optimization,
9853 and to avoid potential problems with integer overflow.
9854 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9855 * casetab.c (set_identity, shuffle): Likewise.
9856 * editfns.c (Fformat): Likewise.
9857 * syntax.c (skip_chars): Likewise.
9858
9859 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9860 This also lets GCC 4.6.0 generate slightly better loop code.
9861
9862 * callint.c (Fcall_interactively): <, not <=, for optimization.
9863 (Fcall_interactively): Count the number of arguments produced,
9864 not the number of arguments given. This is simpler and lets GCC
9865 4.6.0 generate slightly better code.
9866
9867 * ftfont.c: Distingish more carefully between FcChar8 and char.
9868 The previous code passed unsigned char * to a functions like
9869 strlen and xstrcasecmp that expect char *, which does not
9870 conform to the C standard.
9871 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9872 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9873 char * when the C standard requires it.
9874
9875 * keyboard.c (read_char): Remove unused var.
9876
9877 * eval.c: Port to Windows vsnprintf (Bug#8435).
9878 Include <limits.h>.
9879 (SIZE_MAX): Define if the headers do not.
9880 (verror): Do not give up if vsnprintf returns a negative count.
9881 Instead, grow the buffer. This ports to Windows vsnprintf, which
9882 does not conform to C99. Problem reported by Eli Zaretskii.
9883 Also, simplify the allocation scheme, by avoiding the need for
9884 calling realloc, and removing the ALLOCATED variable.
9885
9886 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9887
9888 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9889 But keep the doprint source code for now, as we might revamp it
9890 and use it again (Bug#8435).
9891 * lisp.h (doprnt): Remove.
9892 * Makefile.in (base_obj): Remove doprnt.o.
9893 * deps.mk (doprnt.o): Remove.
9894
9895 error: Print 32- and 64-bit integers portably (Bug#8435).
9896 Without this change, on typical 64-bit hosts error ("...%d...", N)
9897 was used to print both 32- and 64-bit integers N, which relied on
9898 undefined behavior.
9899 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9900 * lisp.h (error, verror): Mark as printf-like functions.
9901 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9902 Report overflow in size calculations when allocating printf buffer.
9903 Do not truncate output string at its first null byte.
9904 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9905 Truncate the output at a character boundary, since vsnprintf does not
9906 do that.
9907 * charset.c (check_iso_charset_parameter): Convert internal
9908 character to string before calling 'error', since %c now has the
9909 printf meaning.
9910 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9911 overflow when computing char to be passed to 'error'. Do not
9912 pass Lisp_Object to 'error'; pass the integer instead.
9913 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9914 formatted with plain %d.
9915
9916 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9917
9918 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9919
9920 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9921
9922 * xterm.c (x_catch_errors): Remove duplicate declaration.
9923
9924 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9925
9926 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9927
9928 2011-04-10 Jim Meyering <meyering@redhat.com>
9929
9930 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9931 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9932 return ssize_t not "int", and use size_t as the buffer length.
9933 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9934 * gnutls.h: Update declarations.
9935 * process.c (read_process_output): Use ssize_t, to match.
9936 (send_process): Likewise.
9937
9938 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9939
9940 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9941
9942 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9943
9944 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9945 Use unsigned char, to match FcChar8 type definition.
9946
9947 * xterm.c (handle_one_xevent):
9948 * xmenu.c (create_and_show_popup_menu):
9949 * xselect.c (x_decline_selection_request)
9950 (x_reply_selection_request): Avoid type-punned deref of X events.
9951
9952 2011-04-09 Eli Zaretskii <eliz@gnu.org>
9953
9954 Fix some uses of `int' instead of EMACS_INT.
9955 * search.c (string_match_1, fast_string_match)
9956 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9957 (scan_buffer, find_next_newline_no_quit)
9958 (find_before_next_newline, search_command, Freplace_match)
9959 (Fmatch_data): Make some `int' variables be EMACS_INT.
9960
9961 * xdisp.c (display_count_lines): 3rd argument and return value now
9962 EMACS_INT. All callers changed.
9963 (pint2hrstr): Last argument is now EMACS_INT.
9964
9965 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9966 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9967 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9968 (decode_coding_utf_16, decode_coding_emacs_mule)
9969 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9970 (decode_coding_ccl, decode_coding_charset)
9971 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9972 (decode_coding_iso_2022, decode_coding_emacs_mule)
9973 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9974 <char_offset, last_offset>: Declare EMACS_INT.
9975 (encode_coding_utf_8, encode_coding_utf_16)
9976 (encode_coding_emacs_mule, encode_invocation_designation)
9977 (encode_designation_at_bol, encode_coding_iso_2022)
9978 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9979 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9980 Declare EMACS_INT.
9981 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9982 (encode_invocation_designation): Last argument P_NCHARS is now
9983 EMACS_INT.
9984 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9985 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9986
9987 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9988 All users changed.
9989
9990 * ccl.c (Fccl_execute_on_string): Declare some variables
9991 EMACS_INT.
9992
9993 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
9994
9995 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9996
9997 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9998
9999 * process.c (Fformat_network_address): Doc fix.
10000
10001 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10002
10003 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10004
10005 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10006
10007 * keyboard.c (read_char): Call Lisp function help-form-show,
10008 instead of using internal_with_output_to_temp_buffer.
10009 (Qhelp_form_show): New var.
10010 (syms_of_keyboard): Use DEFSYM macro.
10011
10012 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10013
10014 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10015
10016 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10017
10018 * process.c (Flist_processes): Remove to Lisp.
10019 (list_processes_1): Delete.
10020
10021 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10022
10023 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10024
10025 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10026
10027 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10028
10029 Fix more problems found by GCC 4.6.0's static checks.
10030
10031 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10032
10033 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10034
10035 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10036
10037 * xdisp.c (vmessage): Mark as a printf-like function.
10038
10039 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10040
10041 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10042
10043 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10044 printf-like functions.
10045 (tiff_load): Add casts to remove these marks before passing them
10046 to system-supplied API.
10047
10048 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10049
10050 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10051 This avoids several warnings with gcc -Wstrict-overflow.
10052 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10053 directly, rather than having caller test rule sign. This avoids
10054 some unnecessary tests.
10055 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10056 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10057 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10058
10059 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10060 (xfont_open): Avoid unnecessary tests.
10061
10062 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10063
10064 * composite.h, composite.c (composition_gstring_put_cache):
10065 Use EMACS_INT, not int, for length.
10066
10067 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10068 breaking out part of COMPOSITION_DECODE_RULE.
10069 (COMPOSITION_DECODE_RULE): Use it.
10070 * composite.c (get_composition_id): Remove unused local vars,
10071 by using the new macro.
10072
10073 * textprop.c (set_text_properties_1): Change while to do-while,
10074 since the condition is always true at first.
10075
10076 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10077 (interval_deletion_adjustment): Return unsigned value.
10078 All uses changed.
10079
10080 * process.c (list_processes_1, create_pty, read_process_output):
10081 (exec_sentinel): Remove vars that were set but not used.
10082 (create_pty): Remove unnecessary "volatile"s.
10083 (Fnetwork_interface_info): Avoid possibility of int overflow.
10084 (read_process_output): Do adaptive read buffering even if carryover.
10085 (read_process_output): Simplify nbytes computation if buffered.
10086
10087 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10088
10089 * syntax.c (scan_words): Remove var that was set but not used.
10090 (update_syntax_table): Use unsigned instead of int.
10091
10092 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10093 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10094 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10095
10096 * print.c (print_error_message): Avoid int overflow.
10097
10098 * font.c (font_list_entities): Redo for clarity,
10099 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10100
10101 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10102 (font_score): Avoid potential overflow in diff calculation.
10103
10104 * fns.c (substring_both): Remove var that is set but not used.
10105 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10106
10107 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10108
10109 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10110 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10111 can always succeed if overflow has undefined behavior.
10112
10113 * search.c (boyer_moore, wordify): Remove vars set but not used.
10114 (wordify): Omit three unnecessary tests.
10115
10116 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10117 All callers changed. This avoids the need for an unused var.
10118
10119 * casefiddle.c (casify_region): Remove var that is set but not used.
10120
10121 * dired.c (file_name_completion): Remove var that is set but not used.
10122
10123 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10124
10125 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10126 (Finsert_file_contents): Remove unnecessary code checking fd.
10127
10128 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10129 Check for integer overflow on size calculations.
10130
10131 * buffer.c (Fprevious_overlay_change): Remove var that is set
10132 but not used.
10133
10134 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10135 Remove vars that are set but not used.
10136 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10137 (timer_check_2): Mark vars as initialized.
10138
10139 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10140
10141 * image.c (lookup_image): Remove var that is set but not used.
10142 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10143
10144 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10145 that are set but not used.
10146
10147 * xfns.c (make_invisible_cursor): Don't return garbage
10148 if XCreateBitmapFromData fails (Bug#8410).
10149
10150 * xselect.c (x_get_local_selection, x_handle_property_notify):
10151 Remove vars that are set but not used.
10152
10153 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10154 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10155
10156 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10157 Remove var that is set but not used.
10158 (scroll_bar_windows_size): Now size_t, not int.
10159 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10160 Check for overflow.
10161
10162 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10163 (map_tty_color) [!defined MSDOS]: Likewise.
10164
10165 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10166
10167 * coding.c: Remove vars that are set but not used.
10168 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10169 All callers changed.
10170 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10171 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10172 (decode_coding_charset): Remove vars that are set but not used.
10173
10174 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10175 that is set but not used.
10176
10177 * print.c (print_object): Remove var that is set but not used.
10178
10179 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10180 The gnulib version avoids calling malloc in the usual case,
10181 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10182 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10183 * filelock.c (current_lock_owner): Likewise.
10184 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10185 * sysdep.c: Include allocator.h, careadlinkat.h.
10186 (emacs_no_realloc_allocator): New static constant.
10187 (emacs_readlink): New function.
10188 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10189 ../lib/careadlinkat.h.
10190
10191 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10192
10193 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10194 first non-nil return value).
10195
10196 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10197
10198 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10199 if not defined (Bug#8403).
10200
10201 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10202
10203 * xdisp.c (display_count_lines): Remove parameter `start',
10204 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10205 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10206 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10207 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10208 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10209 and thereabouts. All callers changed.
10210 (get_per_char_metric): Remove parameter `f', unused since
10211 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10212
10213 2011-04-02 Jim Meyering <meyering@redhat.com>
10214
10215 do not dereference NULL upon failed strdup
10216 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10217 (ns_get_family): Likewise.
10218
10219 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10220
10221 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10222
10223 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10224
10225 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10226 later (Bug#8403).
10227
10228 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10229
10230 Add lexical binding.
10231
10232 * window.c (Ftemp_output_buffer_show): New fun.
10233 (Fsave_window_excursion):
10234 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10235
10236 * lread.c (lisp_file_lexically_bound_p): New function.
10237 (Fload): Bind Qlexical_binding.
10238 (readevalloop): Remove `evalfun' arg.
10239 Bind Qinternal_interpreter_environment.
10240 (Feval_buffer): Bind Qlexical_binding.
10241 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10242 Mark as dynamic.
10243 (syms_of_lread): Declare `lexical-binding'.
10244
10245 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10246
10247 * keyboard.c (eval_dyn): New fun.
10248 (menu_item_eval_property): Use it.
10249
10250 * image.c (parse_image_spec): Use Ffunctionp.
10251
10252 * fns.c (concat, mapcar1): Accept byte-code-functions.
10253
10254 * eval.c (Fsetq): Handle lexical vars.
10255 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10256 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10257 (FletX, Flet): Obey lexical binding.
10258 (Fcommandp): Handle closures.
10259 (Feval): New `lexical' arg.
10260 (eval_sub): New function extracted from Feval. Use it almost
10261 everywhere where Feval was used. Look up vars in lexical env.
10262 Handle closures.
10263 (Ffunctionp): Move from subr.el.
10264 (Ffuncall): Handle closures.
10265 (apply_lambda): Remove `eval_flags'.
10266 (funcall_lambda): Handle closures and new byte-code-functions.
10267 (Fspecial_variable_p): New function.
10268 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10269 but without exporting it to Lisp.
10270
10271 * doc.c (Fdocumentation, store_function_docstring):
10272 * data.c (Finteractive_form): Handle closures.
10273
10274 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10275 interactive spec.
10276
10277 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10278 New byte-codes.
10279 (exec_byte_code): New function extracted from Fbyte_code to handle new
10280 calling convention for byte-code-functions. Add new byte-codes.
10281
10282 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10283
10284 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10285
10286 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10287
10288 * xdisp.c (redisplay_internal): Fix prototype.
10289
10290 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10291
10292 * xdisp.c (SCROLL_LIMIT): New macro.
10293 (try_scrolling): Use it when setting scroll_limit.
10294 Limit scrolling to 100 screen lines.
10295 (redisplay_window): Even when falling back on "recentering",
10296 position point in the window according to scroll-conservatively,
10297 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10298
10299 (try_scrolling): When point is above the window, allow searching
10300 as far as scroll_max, or one screenful, to compute vertical
10301 distance from PT to the scroll margin position. This prevents
10302 try_scrolling from unnecessarily failing when
10303 scroll-conservatively is set to a value slightly larger than the
10304 window height. Clean up the case of PT below the margin at bottom
10305 of window: scroll_max can no longer be INT_MAX. When aggressive
10306 scrolling is in use, don't let point enter the opposite scroll
10307 margin as result of the scroll.
10308 (syms_of_xdisp) <scroll-conservatively>: Document the
10309 threshold of 100 lines for never-recentering scrolling.
10310
10311 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10312
10313 * dispextern.h (move_it_by_lines):
10314 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10315 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10316 (message_log_check_duplicate): Remove parameters `prev_bol' and
10317 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10318 (redisplay_internal): Remove parameter `preserve_echo_area',
10319 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10320
10321 * indent.c (Fvertical_motion):
10322 * window.c (window_scroll_pixel_based, Frecenter):
10323 Don't pass `need_y_p' to `move_it_by_lines'.
10324
10325 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10326
10327 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10328 steal a few bits to be more compact.
10329 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10330 Remove unneeded casts.
10331
10332 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10333
10334 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10335
10336 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10337 binding" message (bug#7967).
10338
10339 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10340
10341 Fix more problems found by GCC 4.6.0's static checks.
10342
10343 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10344 Remove unused local var.
10345
10346 * editfns.c (Fmessage_box): Remove unused local var.
10347
10348 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10349 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10350 Omit unused local vars.
10351 * window.c (shrink_windows): Omit unused local var.
10352 * menu.c (digest_single_submenu): Omit unused local var.
10353 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10354 Omit unused local var.
10355
10356 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10357 Don't assume string length fits in int.
10358 (keyremap_step, read_key_sequence): Use size_t for sizes.
10359 (read_key_sequence): Don't check last_real_key_start redundantly.
10360
10361 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10362 instead of alloca (Bug#8344).
10363
10364 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10365 (Fbacktrace_frame): Don't assume nframes fits in int.
10366
10367 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10368
10369 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10370 concerns.
10371
10372 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10373
10374 * cm.c (calccost): Turn while-do into do-while, for clarity.
10375
10376 * keyboard.c (syms_of_keyboard): Use the same style as later
10377 in this function when indexing through an array. This also
10378 works around GCC bug 48267.
10379
10380 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10381
10382 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10383
10384 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10385 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10386
10387 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10388 This avoids undefined behavior on integer overflow, and is a bit
10389 more convenient anyway since it is compared to a size_t variable.
10390
10391 Variadic C functions now count arguments with size_t, not int.
10392 This avoids an unnecessary limitation on 64-bit machines, which
10393 caused (substring ...) to crash on large vectors (Bug#8344).
10394 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10395 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10396 All variadic functions and their callers changed accordingly.
10397 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10398 * data.c (arith_driver, float_arith_driver): Likewise.
10399 * editfns.c (general_insert_function): Likewise.
10400 * eval.c (struct backtrace.nargs, interactive_p)
10401 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10402 (funcall_lambda, mark_backtrace): Likewise.
10403 * fns.c (concat): Likewise.
10404 * frame.c (x_set_frame_parameters): Likewise.
10405 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10406 0 if not found, not -1. All callers changed.
10407
10408 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10409 (stack_copy_size): Now size_t, not int.
10410 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10411
10412 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10413
10414 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10415 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10416 All callers changed.
10417
10418 * lisp.h (multibyte_char_to_unibyte):
10419 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10420 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10421 * character.h (CHAR_TO_BYTE8):
10422 * cmds.c (internal_self_insert):
10423 * editfns.c (general_insert_function):
10424 * keymap.c (push_key_description):
10425 * search.c (Freplace_match):
10426 * xdisp.c (message_dolog, set_message_1): All callers changed.
10427
10428 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10429
10430 * keyboard.c (safe_run_hook_funcall): New function.
10431 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10432 don't set the hook to nil, but remove the offending function instead.
10433 (Qcommand_hook_internal): Remove, unused.
10434 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10435 Vcommand_hook_internal.
10436
10437 * eval.c (enum run_hooks_condition): Remove.
10438 (funcall_nil, funcall_not): New functions.
10439 (run_hook_with_args): Call each function through a `funcall' argument.
10440 Remove `cond' argument, now redundant.
10441 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10442 (Frun_hook_with_args_until_failure): Adjust accordingly.
10443 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10444
10445 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10446
10447 * dispextern.h (string_buffer_position): Remove declaration.
10448
10449 * print.c (strout): Remove parameter `multibyte', unused since
10450 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10451
10452 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10453 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10454 All callers changed.
10455
10456 * w32.c (_wsa_errlist): Use braces for struct initializers.
10457
10458 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10459 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10460 All callers changed.
10461 (string_buffer_position): Likewise. Also, make static (it's never
10462 used outside xdisp.c).
10463 (cursor_row_p): Remove parameter `w', unused since
10464 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10465 (decode_mode_spec): Remove parameter `precision', introduced during
10466 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10467 All callers changed.
10468
10469 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10470
10471 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10472
10473 2011-03-27 Anders Lindgren <andlind@gmail.com>
10474
10475 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10476 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10477 (ns_update_auto_hide_menu_bar): New functions.
10478 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10479 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10480 ns_constrain_all_frames.
10481 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10482 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10483
10484 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10485
10486 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10487
10488 2011-03-27 Glenn Morris <rgm@gnu.org>
10489
10490 * syssignal.h: Replace RETSIGTYPE with void.
10491 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10492 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10493 Replace SIGTYPE with void everywhere.
10494 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10495 * s/template.h (SIGTYPE): Remove commented out definition.
10496
10497 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10498
10499 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10500 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10501
10502 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10503
10504 * w32.c (read_unc_volume): Use parameter `henum', instead of
10505 global variable `wget_enum_handle'.
10506
10507 * keymap.c (describe_vector): Remove parameters `indices' and
10508 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10509 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10510
10511 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10512
10513 * keyboard.c (timer_check): Remove parameter `do_it_now',
10514 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10515 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10516 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10517
10518 * keyboard.c (read_char):
10519 * w32menu.c (w32_menu_display_help):
10520 * xmenu.c (show_help_event, menu_help_callback):
10521 Adjust calls to `show_help_echo'.
10522
10523 * gtkutil.c (xg_maybe_add_timer):
10524 * keyboard.c (readable_events):
10525 * process.c (wait_reading_process_output):
10526 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10527
10528 * insdel.c (adjust_markers_gap_motion):
10529 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10530 (gap_left, gap_right): Don't call it.
10531
10532 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10533
10534 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10535 incurred during fontification.
10536
10537 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10538
10539 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10540 (DEFVAR_PER_BUFFER): Don't pass it.
10541
10542 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10543 (scrolling_window): Don't pass it.
10544
10545 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10546
10547 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10548
10549 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10550 and `suffix'.
10551 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10552 of variables specific to SELinux and computation of `encoded_absname'.
10553
10554 * image.c (XPutPixel): Remove unused variable `height'.
10555
10556 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10557
10558 * unexw32.c (get_section_info): Remove unused variable `section'.
10559
10560 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10561 (system_process_attributes): Remove unused variable `sess'.
10562 (sys_read): Remove unused variable `err'.
10563
10564 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10565 (w32_wnd_proc): Remove unused variable `isdead'.
10566 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10567 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10568 (x_create_tip_frame): Remove unused variable `tem'.
10569
10570 * w32inevt.c (w32_console_read_socket):
10571 Remove unused variable `no_events'.
10572
10573 * w32term.c (x_draw_composite_glyph_string_foreground):
10574 Remove unused variable `width'.
10575
10576 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10577
10578 * w32term.c (x_set_glyph_string_clipping):
10579 Don't pass uninitialized region to CombineRgn.
10580
10581 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10582
10583 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10584 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10585 (Fx_close_connection): Remove unused variable `i'.
10586
10587 * w32font.c (w32font_draw): Return number of glyphs.
10588 (w32font_open_internal): Remove unused variable `i'.
10589 (w32font_driver): Add missing initializer.
10590
10591 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10592 (fill_in_menu): Remove unused variable `items_added'.
10593
10594 * w32term.c (last_mouse_press_frame): Remove static global variable.
10595 (w32_clip_to_row): Remove unused variable `f'.
10596 (x_delete_terminal): Remove unused variable `i'.
10597
10598 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10599 (NOTHING): Remove unused static global variable.
10600 (uniscribe_check_otf): Remove unused variable `table'.
10601 (uniscribe_font_driver): Add missing initializers.
10602
10603 2011-03-23 Julien Danjou <julien@danjou.info>
10604
10605 * term.c (Fsuspend_tty, Fresume_tty):
10606 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10607 * window.c (temp_output_buffer_show):
10608 * insdel.c (signal_before_change):
10609 * frame.c (Fhandle_switch_frame):
10610 * fileio.c (Fdo_auto_save):
10611 * emacs.c (Fkill_emacs):
10612 * editfns.c (save_excursion_restore):
10613 * cmds.c (internal_self_insert):
10614 * callint.c (Fcall_interactively):
10615 * buffer.c (Fkill_all_local_variables):
10616 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10617 Use Frun_hooks.
10618 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10619 unconditionally since it does the check itself.
10620
10621 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10622
10623 Fix more problems found by GCC 4.5.2's static checks.
10624
10625 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10626 the first time through the loop, since we know p0 < p1 then.
10627 This also avoids a gcc -Wstrict-overflow warning.
10628
10629 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10630 leading to a memory leak, possible in functions like
10631 load_charset_map_from_file that can allocate an unbounded number
10632 of objects (Bug#8318).
10633
10634 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10635 that could (at least in theory) be that large.
10636
10637 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10638 This is less likely to overflow, and avoids undefined behavior if
10639 overflow does occur. All callers changed. Use strtoul to scan
10640 for the unsigned long integer.
10641 (pint2hrstr): Simplify and tune code slightly.
10642 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10643
10644 * scroll.c (do_scrolling): Work around GCC bug 48228.
10645 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10646
10647 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10648 This also avoids a warning with gcc -Wstrict-overflow.
10649 (validate_x_resource_name): Simplify count usage.
10650 This also avoids a warning with gcc -Wstrict-overflow.
10651
10652 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10653 fail (Bug#8306).
10654
10655 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10656
10657 * process.c (Fmake_network_process): Use socklen_t, not int,
10658 where POSIX says socklen_t is required in portable programs.
10659 This fixes a porting bug on hosts like 64-bit HP-UX, where
10660 socklen_t is wider than int (Bug#8277).
10661 (Fmake_network_process, server_accept_connection):
10662 (wait_reading_process_output, read_process_output):
10663 Likewise.
10664
10665 * process.c: Rename or move locals to avoid shadowing.
10666 (list_processes_1, Fmake_network_process):
10667 (read_process_output_error_handler, exec_sentinel_error_handler):
10668 Rename or move locals.
10669 (Fmake_network_process): Define label "retry_connect" only if needed.
10670 (Fnetwork_interface_info): Fix pointer signedness.
10671 (process_send_signal): Add cast to avoid pointer signedness problem.
10672 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10673 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10674
10675 Make tparam.h and terminfo.c consistent.
10676 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10677 Include tparam.h instead, since it declares them.
10678 * cm.h (PC): Remove extern decl; tparam.h now does this.
10679 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10680 * terminfo.c: Include tparam.h, to check interfaces.
10681 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10682 (tparam): Adjust signature to match interface in tparam.h;
10683 this removes some undefined behavior. Check that outstring and len
10684 are zero, which they always are with Emacs.
10685 * tparam.h (PC, BC, UP): New extern decls.
10686
10687 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10688 (xftfont_open): Rename locals to avoid shadowing.
10689
10690 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10691 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10692 (OTF_TAG_SYM): Omit macro if not needed.
10693 (ftfont_list): Remove unused local.
10694 (get_adstyle_property, ftfont_pattern_entity):
10695 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10696 Rename locals to avoid shadowing.
10697
10698 * xfont.c (xfont_list_family): Mark var as initialized.
10699
10700 * xml.c (make_dom): Now static.
10701
10702 * composite.c (composition_compute_stop_pos): Rename local to
10703 avoid shadowing.
10704 (composition_reseat_it): Remove unused locals.
10705 (find_automatic_composition, composition_adjust_point): Likewise.
10706 (composition_update_it): Mark var as initialized.
10707 (find_automatic_composition): Mark vars as initialized,
10708 with a FIXME (Bug#8290).
10709
10710 character.h: Rename locals to avoid shadowing.
10711 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10712 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10713 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10714 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10715 to avoid shadowing.
10716
10717 * textprop.c (property_change_between_p): Remove; unused.
10718
10719 * intervals.c (interval_start_pos): Now static.
10720
10721 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10722
10723 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10724 Rename locals to avoid shadowing.
10725
10726 * sound.c (wav_play, au_play, Fplay_sound_internal):
10727 Fix pointer signedness.
10728 (alsa_choose_format): Remove unused local var.
10729 (wav_play): Initialize a variable to 0, to prevent undefined
10730 behavior (Bug#8278).
10731
10732 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10733
10734 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10735
10736 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10737 clobbering (Bug#8298).
10738 * sysdep.c (sys_subshell): Likewise.
10739 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10740
10741 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10742 This should get cleaned up, so that child_setup has the
10743 same signature on all platforms.
10744
10745 * callproc.c (call_process_cleanup): Now static.
10746 (relocate_fd): Rename locals to avoid shadowing.
10747
10748 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10749
10750 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10751 not to be necessary, and produces flickering.
10752
10753 2011-03-20 Glenn Morris <rgm@gnu.org>
10754
10755 * config.in: Remove file.
10756
10757 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10758
10759 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10760 are now in src/globals.h.
10761 (syms_of_minibuf): Remove spurious & from previous change.
10762
10763 2011-03-20 Leo Liu <sdl.web@gmail.com>
10764
10765 * minibuf.c (completing-read-function): New variable.
10766 (completing-read-default): Rename from completing-read.
10767 (completing-read): Call completing-read-function.
10768
10769 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10770
10771 * xfaces.c (Fx_load_color_file):
10772 Read color file from absolute filename (bug#8250).
10773
10774 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10775
10776 * makefile.w32-in: Update dependencies.
10777
10778 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10779
10780 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10781
10782 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10783
10784 Fix more problems found by GCC 4.5.2's static checks.
10785
10786 * process.c (make_serial_process_unwind, send_process_trap):
10787 (sigchld_handler): Now static.
10788
10789 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10790 That way, the code declares only the vars that it needs.
10791 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10792 * s/cygwin.h (PTY_ITERATION): Likewise.
10793 * s/darwin.h (PTY_ITERATION): Likewise.
10794 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10795
10796 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10797 * process.c (allocate_pty): Don't declare stb unless it's needed.
10798
10799 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10800 (CONSTANTLIM): Remove; unused.
10801 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10802 Define only if needed.
10803
10804 * unexelf.c (unexec): Name an expression,
10805 to avoid gcc -Wbad-function-cast warning.
10806 Use a different way to cause a compilation error if anyone uses
10807 n rather than nn, a way that does not involve shadowing.
10808 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10809
10810 * deps.mk (unexalpha.o): Remove; unused.
10811
10812 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10813 * unexec.h: New file.
10814 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10815 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10816 Depend on unexec.h.
10817 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10818 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10819 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10820 Change as necessary to match prototype in unexec.h.
10821
10822 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10823 shadowing.
10824 (back_comment, skip_chars): Mark vars as initialized.
10825
10826 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10827 Rename locals to avoid shadowing.
10828
10829 * lread.c (read1): Rewrite so as not to use empty "else".
10830 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10831
10832 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10833
10834 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10835 warning when compiling print.c.
10836
10837 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10838 instead of using an uninitialized var.
10839 (font_sort_entities): Mark var as initialized.
10840
10841 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10842
10843 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10844 pointers to constants.
10845 (font_parse_fcname): Remove unused vars.
10846 (font_delete_unmatched): Now static.
10847 (font_get_spec): Remove; unused.
10848 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10849 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10850 Rename or move locals to avoid shadowing.
10851
10852 * fns.c (require_nesting_list, require_unwind): Now static.
10853 (Ffillarray): Rename locals to avoid shadowing.
10854
10855 * floatfns.c (domain_error2): Define only if needed.
10856 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10857
10858 * alloc.c (mark_backtrace): Move decl from here ...
10859 * lisp.h: ... to here, so that it can be checked.
10860
10861 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10862 (Fdefvar): Rewrite so as not to use empty "else".
10863 (lisp_indirect_variable): Name an expression,
10864 to avoid gcc -Wbad-function-cast warning.
10865 (Fdefvar): Rename locals to avoid shadowing.
10866
10867 * callint.c (quotify_arg, quotify_args): Now static.
10868 (Fcall_interactively): Rename locals to avoid shadowing.
10869 Use const pointer when appropriate.
10870
10871 * lisp.h (get_system_name, get_operating_system_release):
10872 Move decls here, to check interfaces.
10873 * process.c (get_operating_system_release): Move decl to lisp.h.
10874 * xrdb.c (get_system_name): Likewise.
10875 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10876 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10877 some of which prompt warnings from gcc -Wbad-function-cast.
10878 (Fformat_time_string, Fencode_time, Finsert_char):
10879 (Ftranslate_region_internal, Fformat):
10880 Rename or remove local vars to avoid shadowing.
10881 (Ftranslate_region_internal): Mark var as initialized.
10882
10883 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10884 avoid shadowing.
10885
10886 * lisp.h (eassert): Check that the argument compiles, even if
10887 ENABLE_CHECKING is not defined.
10888
10889 * data.c (Findirect_variable): Name an expression, to avoid
10890 gcc -Wbad-function-cast warning.
10891 (default_value, arithcompare, arith_driver, arith_error): Now static.
10892 (store_symval_forwarding): Rename local to avoid shadowing.
10893 (Fmake_variable_buffer_local, Fmake_local_variable):
10894 Mark variables as initialized.
10895 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10896
10897 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10898 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10899 Rename locals to avoid shadowing.
10900 (mark_stack): Move local variables into the #ifdef region where
10901 they're used.
10902 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10903 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10904 needed otherwise.
10905 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10906 (GC_STRING_CHARS): Remove; not used.
10907 (Fmemory_limit): Cast sbrk's returned value to char *.
10908
10909 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10910 avoids undefined behavior in theory.
10911
10912 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10913
10914 Use functions, not macros, for up- and down-casing (Bug#8254).
10915 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10916 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10917 to use the following functions instead of these macros.
10918 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10919 EMACS_INT, since callers assume the returned value fits in int.
10920 (upcase1): Likewise, for UPCASE_TABLE.
10921 (uppercasep, lowercasep, upcase): New static inline functions.
10922 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
10923 the race-condition problem in the old DOWNCASE.
10924
10925 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10926 Rename locals to avoid shadowing.
10927 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
10928 (regex_compile, re_search_2, re_match_2_internal):
10929 Remove unused local vars.
10930 (FREE_VAR): Rewrite so as not to use empty "else",
10931 which gcc can warn about.
10932 (regex_compile, re_match_2_internal): Mark locals as initialized.
10933 (RETALLOC_IF): Define only if needed.
10934 (WORDCHAR_P): Likewise. This one is never needed, but is used
10935 only in a comment talking about a compiler bug, so put inside
10936 the #if 0 of that comment.
10937 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10938 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10939 Remove; unused.
10940
10941 * search.c (boyer_moore): Rename locals to avoid shadowing.
10942 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10943 (PREV_CHAR_BOUNDARY): Likewise.
10944
10945 * search.c (simple_search): Remove unused var.
10946
10947 * dired.c (compile_pattern): Move decl from here ...
10948 * lisp.h: ... to here, so that it can be checked.
10949 (struct re_registers): New forward decl.
10950
10951 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10952
10953 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10954 All uses changed.
10955 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10956 Rename locals to avoid shadowing.
10957 (Fvertical_motion): Mark locals as initialized.
10958
10959 * casefiddle.c (casify_object, casify_region): Now static.
10960 (casify_region): Mark local as initialized.
10961
10962 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10963
10964 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10965 New macros, so that the caller can use some names other than
10966 gcpro1, gcpro2, etc.
10967 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10968 of the new macros.
10969 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10970 argument, for consistency with GCPRO2_VAR, etc: it is now the
10971 prefix of the variable, not the variable itself. All uses
10972 changed.
10973 * dired.c (directory_files_internal, file_name_completion):
10974 Rename locals to avoid shadowing.
10975
10976 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10977 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10978 dired.c's scmp function, had undefined behavior.
10979 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10980 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10981 * buffer.h: ... to here, because these macros use current_buffer,
10982 and the new implementation with inline functions needs to have
10983 current_buffer in scope now, rather than later when the macros
10984 are used.
10985 (downcase, upcase1): New static inline functions.
10986 (DOWNCASE, UPCASE1): Reimplement using these functions.
10987 This avoids undefined behavior in expressions like
10988 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10989 from race conditions in accessing the global variables
10990 case_temp1 and case_temp2.
10991 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10992 * lisp.h (case_temp1, case_temp2): Remove their decls.
10993 * character.h (ASCII_CHAR_P): Move from here ...
10994 * lisp.h: ... to here, so that the inline functions mentioned
10995 above can use them.
10996
10997 * dired.c (directory_files_internal_unwind): Now static.
10998
10999 * fileio.c (file_name_as_directory, directory_file_name):
11000 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11001 Now static.
11002 (file_name_as_directory): Use const pointers when appropriate.
11003 (Fexpand_file_name): Likewise. In particular, newdir might
11004 point at constant storage, so make it a const pointer.
11005 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11006 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11007 signedness issues.
11008 (Fset_file_times, Finsert_file_contents, auto_save_error):
11009 Rename locals to avoid shadowing.
11010
11011 * minibuf.c (choose_minibuf_frame_1): Now static.
11012 (Ftry_completion, Fall_completions): Rename or remove locals
11013 to avoid shadowing.
11014
11015 * marker.c (bytepos_to_charpos): Remove; unused.
11016
11017 * lisp.h (verify_bytepos, count_markers): New decls,
11018 so that gcc does not warn that these functions aren't declared.
11019
11020 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11021 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11022 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11023 (copy_text): Remove unused local var.
11024
11025 * filelock.c (within_one_second): Now static.
11026 (lock_file_1): Rename local to avoid shadowing.
11027
11028 * buffer.c (fix_overlays_before): Mark locals as initialized.
11029 (fix_start_end_in_overlays): Likewise. This function should be
11030 simplified by using pointers-to-pointers, but that's a different
11031 matter.
11032 (switch_to_buffer_1): Now static.
11033 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11034 (report_overlay_modification): Rename locals to avoid shadowing.
11035
11036 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11037 Fix pointer signedness issue.
11038 (sys_subshell): Mark local as volatile if checking for lint,
11039 to suppress a gcc -Wclobbered warning that does not seem to be right.
11040 (MAXPATHLEN): Define only if needed.
11041
11042 * process.c (serial_open, serial_configure): Move decls from here ...
11043 * systty.h: ... to here, so that they can be checked.
11044
11045 * fns.c (get_random, seed_random): Move extern decls from here ...
11046 * lisp.h: ... to here, so that they can be checked.
11047
11048 * sysdep.c (reset_io): Now static.
11049 (wait_for_termination_signal): Remove; unused.
11050
11051 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11052 (copy_keymap_item, append_key, push_text_char_description):
11053 Now static.
11054 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11055 (DENSE_TABLE_SIZE): Remove; unused.
11056 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11057 (describe_map_tree):
11058 Rename locals to avoid shadowing.
11059
11060 * keyboard.c: Declare functions static if they are not used elsewhere.
11061 (echo_char, echo_dash, cmd_error, top_level_2):
11062 (poll_for_input, handle_async_input): Now static.
11063 (read_char, kbd_buffer_get_event, make_lispy_position):
11064 (make_lispy_event, make_lispy_movement, apply_modifiers):
11065 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11066 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11067 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11068 (read_key_sequence, read_char): Mark locals as initialized.
11069 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11070
11071 * keyboard.h (make_ctrl_char): New decl.
11072 (mark_kboards): Move decl here ...
11073 * alloc.c (mark_kboards): ... from here.
11074
11075 * lisp.h (force_auto_save_soon): New decl.
11076
11077 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11078 (DEFINE_DUMMY_FUNCTION): New macro.
11079 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11080 Use it.
11081 (main): Add casts to avoid warnings
11082 if GCC considers string literals to be constants.
11083
11084 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11085
11086 * dbusbind.c: Pointer signedness fixes.
11087 (xd_signature, xd_append_arg, xd_initialize):
11088 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11089 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11090 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11091 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11092
11093 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11094 if GCC considers string literals to be constants.
11095 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11096
11097 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11098
11099 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11100 (print_preprocess, print_object): New macro to fix last change.
11101
11102 * print.c (print_preprocess): Don't forget font objects.
11103
11104 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11105
11106 * emacs.c (USAGE3): Doc fixes.
11107
11108 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11109
11110 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11111 structure.
11112
11113 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11114
11115 * lisp.h (VWindow_system, Qfile_name_history):
11116 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11117 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11118 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11119
11120 * w32select.c: Don't #include "keyboard.h".
11121 (run_protected): Add extern declaration for waiting_for_input.
11122
11123 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11124 * w32console.c (detect_input_pending, read_input_pending)
11125 (encode_terminal_code):
11126 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11127 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11128 (w32_system_caret_y, Qfile_name_history):
11129 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11130 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11131 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11132 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11133 * w32proc.c (Qlocal, report_file_error):
11134 * w32term.c (Vwindow_system, updating_frame):
11135 * w32uniscribe.c (initialized, uniscribe_font_driver):
11136 Remove unneeded extern declarations.
11137
11138 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11139
11140 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11141
11142 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11143
11144 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11145 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11146 These macros can no longer be used for assignment.
11147
11148 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11149 Assign struct members directly, instead of using BUF_BEGV etc.
11150 (record_buffer_markers, fetch_buffer_markers): New functions for
11151 recording and fetching special buffer markers.
11152 (set_buffer_internal_1, set_buffer_temp): Use them.
11153
11154 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11155
11156 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11157
11158 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11159 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11160
11161 * xdisp.c (hscroll_window_tree):
11162 (reconsider_clip_changes): Use PT instead of BUF_PT.
11163
11164 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11165
11166 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11167 $(EMACS_ROOT)/lib/intprops.h.
11168
11169 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11170
11171 Fix more problems found by GCC 4.5.2's static checks.
11172
11173 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11174 to unsigned char * to avoid compiler diagnostic.
11175 (xg_free_frame_widgets): Make it clear that a local variable is
11176 needed only if USE_GTK_TOOLTIP.
11177 (gdk_window_get_screen): Make it clear that this macro is needed
11178 only if USE_GTK_TOOLTIP.
11179 (int_gtk_range_get_value): New function, which avoids a diagnostic
11180 from gcc -Wbad-function-cast.
11181 (xg_set_toolkit_scroll_bar_thumb): Use it.
11182 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11183 diagnostic from gcc -Wbad-function-cast.
11184 (get_utf8_string, xg_get_file_with_chooser):
11185 Rename locals to avoid shadowing.
11186 (create_dialog): Move locals to avoid shadowing.
11187
11188 * xgselect.c (xg_select): Remove unused var.
11189
11190 * image.c (four_corners_best): Mark locals as initialized.
11191 (gif_load): Initialize transparent_p to zero (Bug#8238).
11192 Mark another local as initialized.
11193 (my_png_error, my_error_exit): Mark with NO_RETURN.
11194
11195 * image.c (clear_image_cache): Now static.
11196 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11197 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11198 (x_edge_detection): Remove unnecessary cast that
11199 gcc -Wbad-function-cast diagnoses.
11200 (gif_load): Fix pointer signedness.
11201 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11202 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11203
11204 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11205
11206 Improve quality of tests for time stamp overflow.
11207 For example, without this patch (encode-time 0 0 0 1 1
11208 1152921504606846976) returns the obviously-bogus value (-948597
11209 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11210 reports time overflow. See
11211 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11212 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11213 * editfns.c: Include limits.h and intprops.h.
11214 (TIME_T_MIN, TIME_T_MAX): New macros.
11215 (time_overflow): Move earlier, to before first use.
11216 (hi_time, lo_time): New functions, for an accurate test for
11217 out-of-range times.
11218 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11219 (Fget_internal_run_time): Don't assume time_t fits in int.
11220 (make_time): Use list2 instead of Fcons twice.
11221 (Fdecode_time): More accurate test for out-of-range times.
11222 (check_tm_member): New function.
11223 (Fencode_time): Use it, to test for out-of-range times.
11224 (lisp_time_argument): Don't rely on undefined left-shift and
11225 right-shift behavior when checking for time stamp overflow.
11226
11227 * editfns.c (time_overflow): New function, refactoring common code.
11228 (Fformat_time_string, Fdecode_time, Fencode_time):
11229 (Fcurrent_time_string): Use it.
11230
11231 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11232 * dired.c (make_time): Move to ...
11233 * editfns.c (make_time): ... here.
11234 * systime.h: Note the move.
11235
11236 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11237
11238 * fringe.c (update_window_fringes): Remove unused variables.
11239
11240 * unexmacosx.c (copy_data_segment): Also copy __got section.
11241 (Bug#8223)
11242
11243 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11244
11245 * termcap.c [MSDOS]: Include "msdos.h".
11246 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11247 Constify `char *' arguments and their references according to
11248 prototypes in tparam.h.
11249
11250 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11251
11252 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11253 Adapt all references accordingly.
11254
11255 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11256
11257 2011-03-11 Tom Tromey <tromey@redhat.com>
11258
11259 * buffer.c (syms_of_buffer): Remove obsolete comment.
11260
11261 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11262
11263 * termhooks.h (encode_terminal_code): Declare prototype.
11264
11265 * msdos.c (encode_terminal_code): Don't declare prototype.
11266
11267 * term.c (encode_terminal_code): Now external again, used by
11268 w32console.c and msdos.c.
11269
11270 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11271 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11272
11273 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11274
11275 Fix some minor problems found by GCC 4.5.2's static checks.
11276
11277 * fringe.c (update_window_fringes): Mark locals as initialized
11278 (Bug#8227).
11279 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11280
11281 * alloc.c (mark_fringe_data): Move decl from here ...
11282 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11283 to check its interface.
11284 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11285
11286 * fontset.c (free_realized_fontset): Now static.
11287 (Fset_fontset_font): Rename local to avoid shadowing.
11288 (fontset_font): Mark local as initialized.
11289 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11290
11291 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11292
11293 * xselect.c (x_disown_buffer_selections): Remove; not used.
11294 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11295 (x_own_selection, Fx_disown_selection_internal): Rename locals
11296 to avoid shadowing.
11297 (x_handle_dnd_message): Remove local to avoid shadowing.
11298
11299 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11300 so that the caller can use some name other than gcpro1.
11301 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11302 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11303 (Fx_backspace_delete_keys_p):
11304 Use them to avoid shadowing, and rename vars to avoid shadowing.
11305 (x_decode_color, x_set_name, x_window): Now static.
11306 (Fx_create_frame): Add braces to silence GCC warning.
11307 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11308 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11309 Remove unused locals.
11310 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11311 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11312 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11313 macros.
11314
11315 * xterm.h (x_mouse_leave): New decl.
11316
11317 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11318 Remove unused functions.
11319 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11320 (x_calc_absolute_position): Now static.
11321 (XTread_socket): Don't define label "out" unless it's used.
11322 Don't declare local "event" unless it's used.
11323 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11324 unless they are used.
11325 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11326 (x_fatal_error_signal): Remove; not used.
11327 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11328 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11329 (x_error_catcher, x_connection_closed, x_error_handler):
11330 (x_error_quitter, xembed_send_message, x_iconify_frame):
11331 (my_log_handler): Rename locals to avoid shadowing.
11332 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11333 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11334
11335 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11336 Rename or move locals to avoid shadowing.
11337 (tty_defined_color, merge_face_heights): Now static.
11338 (free_realized_faces_for_fontset): Remove; not used.
11339 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11340 does not deduce is never used uninitialized.
11341 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11342 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11343
11344 * terminal.c (store_terminal_param): Now static.
11345
11346 * xmenu.c (menu_highlight_callback): Now static.
11347 (set_frame_menubar): Remove unused local.
11348 (xmenu_show): Rename parameter to avoid shadowing.
11349 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11350 since they might point to immutable storage.
11351 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11352 since it's unused otherwise.
11353
11354 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11355 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11356 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11357 avoids a gcc -Wuninitialized diagnostic.
11358 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11359 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11360 does not deduce are never used uninitialized.
11361
11362 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11363
11364 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11365 * window.c (window_loop, size_window):
11366 (run_window_configuration_change_hook, enlarge_window): Likewise.
11367
11368 * window.c (display_buffer): Now static.
11369 (size_window): Mark variables that gcc -Wuninitialized
11370 does not deduce are never used uninitialized.
11371 * window.h (check_all_windows): New decl, to forestall
11372 gcc -Wmissing-prototypes diagnostic.
11373 * dispextern.h (bidi_dump_cached_states): Likewise.
11374
11375 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11376 shadowing.
11377 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11378 Include <limits.h>.
11379 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11380 and to avoid gcc -Wuninitialized warning.
11381 (load_charset_map): Mark variables that gcc -Wuninitialized
11382 does not deduce are never used uninitialized.
11383 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11384
11385 * coding.c (coding_set_source, coding_set_destination):
11386 Use "else { /* comment */ }" rather than "else /* comment */;"
11387 for clarity, and to avoid gcc -Wempty-body warning.
11388 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11389 a block, when the outer 'i' will do.
11390 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11391 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11392 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11393 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11394 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11395 Rename locals to avoid shadowing.
11396 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11397 * coding.c (emacs_mule_char, encode_invocation_designation):
11398 Now static, since they're not used elsewhere.
11399 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11400 (decode_coding_object, encode_coding_object, detect_coding_system):
11401 (decode_coding_emacs_mule): Mark variables that gcc
11402 -Wuninitialized does not deduce are never used uninitialized.
11403 (detect_coding_iso_2022): Initialize a local variable that might
11404 be used uninitialized. Leave a FIXME because it's not clear that
11405 this initialization is needed. (Bug#8211)
11406 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11407 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11408 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11409 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11410 Remove unused macros.
11411
11412 * category.c (hash_get_category_set): Remove unused local var.
11413 (copy_category_table): Now static, since it's not used elsewhere.
11414 * character.c (string_count_byte8): Likewise.
11415
11416 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11417 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11418
11419 * chartab.c (copy_sub_char_table): Now static, since it's not used
11420 elsewhere.
11421 (sub_char_table_ref_and_range, char_table_ref_and_range):
11422 Rename locals to avoid shadowing.
11423 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11424
11425 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11426 (BIDI_BOB): Remove unused macro.
11427
11428 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11429 deduce are never used uninitialized.
11430 * term.c (encode_terminal_code): Likewise.
11431
11432 * term.c (encode_terminal_code): Now static. Remove unused local.
11433
11434 * tparam.h: New file.
11435 * term.c, tparam.h: Include it.
11436 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11437 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11438 Move these decls to tparam.h, and make them agree with what
11439 is actually in tparam.c. The previous trick of using incompatible
11440 decls in different modules does not conform to the C standard.
11441 All callers of tparam changed to use tparam's actual API.
11442 * tparam.c (tparam1, tparam, tgoto):
11443 Use const pointers where appropriate.
11444
11445 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11446 * cm.h (struct cm): Likewise.
11447 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11448 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11449 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11450 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11451 (turn_on_face, init_tty): Likewise.
11452 * termchar.h (struct tty_display_info): Likewise.
11453
11454 * term.c (term_mouse_position): Rename local to avoid shadowing.
11455
11456 * alloc.c (mark_ttys): Move decl from here ...
11457 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11458
11459 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11460
11461 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11462
11463 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11464
11465 * search.c (compile_pattern_1): Remove argument regp, unused since
11466 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11467 (compile_pattern): Don't pass it.
11468
11469 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11470
11471 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11472 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11473 for ! HAVE_GTK3.
11474 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11475
11476 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11477
11478 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11479 gdk_window_get_screen, gdk_window_get_geometry,
11480 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11481 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11482 (xg_get_pixbuf_from_pixmap): New function.
11483 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11484 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11485 Call xg_get_pixbuf_from_pixmap instead of
11486 gdk_pixbuf_get_from_drawable.
11487 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11488 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11489 (xg_check_special_colors): Use GtkStyleContext and its functions
11490 for HAVE_GTK3.
11491 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11492 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11493 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11494 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11495 Call gtk_widget_get_preferred_size.
11496 (xg_frame_resized): gdk_window_get_geometry only takes 5
11497 parameters.
11498 (xg_win_to_widget, xg_event_is_for_menubar):
11499 Call gdk_x11_window_lookup_for_display.
11500 (xg_set_widget_bg): New function.
11501 (delete_cb): New function.
11502 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11503 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11504 (xg_set_background_color): Call xg_set_widget_bg.
11505 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11506 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11507 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11508 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11509 if ! HAVE_GTK3.
11510 (update_frame_tool_bar): Call gtk_widget_hide.
11511 (xg_initialize): Use GDK_KEY_g.
11512
11513 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11514 if ! HAVE_GTK3
11515 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11516
11517 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11518 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11519 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11520
11521 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11522
11523 * w32xfns.c (select_palette): Check success of RealizePalette against
11524 GDI_ERROR, not zero.
11525
11526 See ChangeLog.11 for earlier changes.
11527
11528 ;; Local Variables:
11529 ;; coding: utf-8
11530 ;; End:
11531
11532 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11533
11534 This file is part of GNU Emacs.
11535
11536 GNU Emacs is free software: you can redistribute it and/or modify
11537 it under the terms of the GNU General Public License as published by
11538 the Free Software Foundation, either version 3 of the License, or
11539 (at your option) any later version.
11540
11541 GNU Emacs is distributed in the hope that it will be useful,
11542 but WITHOUT ANY WARRANTY; without even the implied warranty of
11543 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11544 GNU General Public License for more details.
11545
11546 You should have received a copy of the GNU General Public License
11547 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.