Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
1 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2
3 Fix minor alloc.c problems found by static checking.
4 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5 New extern decls, to avoid calling undeclared functions.
6 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
7 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
8 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
9 (NEED_MEM_INSERT): New macro.
10 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
11
12 Fix minor ralloc.c problems found by static checking.
13 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
14 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
15 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
16 (r_alloc_sbrk): Now static.
17
18 Improve ralloc.c interface checking.
19 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
20 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
21 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
22 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
23 [REL_ALLOC]: ... to here, to check interface.
24 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
25 Remove decls. This fixes an "It stinks!".
26
27 * alloc.c (which_symbols): Fix alignment issue / type clash.
28
29 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
30
31 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
32 (struct Lisp_Misc_Any): Likewise.
33 (struct Lisp_Free): Likewise.
34 * alloc.c (union aligned_Lisp_Symbol): Define.
35 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
36 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
37 (union aligned_Lisp_Misc): Define.
38 (MARKER_BLOCK_SIZE, struct marker_block): Use union
39 aligned_Lisp_Misc instead of union Lisp_Misc.
40 (Fmake_symbol, allocate_misc, gc_sweep): Adjust
41
42 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
43
44 configure: new option --enable-gcc-warnings (Bug#11207)
45 * Makefile.in (C_WARNINGS_SWITCH): Remove.
46 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
47 (ALL_CFLAGS): Use new macros rather than old.
48 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
49 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
50 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
51 -Wunused-result, -Wunused-variable. This should go away once
52 the Emacs and Gnulib regex code is merged.
53 (xmalloc, xrealloc): Now static.
54
55 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
56
57 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
58 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
59 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
60 * s/netbsd.h, s/sol2-6.h:
61 Remove definition of GC_MARK_STACK, since the default now works.
62 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
63 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
64 no longer the default.
65 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
66
67 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
68
69 * lread.c (lisp_file_lexically_bound_p):
70 Fix hang at ";-*-\n" (bug#11238).
71
72 2012-04-14 Eli Zaretskii <eliz@gnu.org>
73
74 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
75 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
76
77 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
78
79 * nsterm.m (constrainFrameRect): Always constrain when there is only
80 one screen (Bug#10962).
81
82 2012-04-13 Ken Brown <kbrown@cornell.edu>
83
84 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
85
86 2012-04-13 Reuben Thomas <rrt@sc3d.org>
87
88 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
89
90 2012-04-11 Daniel Colascione <dancol@dancol.org>
91
92 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
93 against is gone. It's better to use vfork now so that when Cygwin
94 gains a new, working vfork, we use it automatically (bug#10398).
95
96 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
97
98 * window.c (save_window_save): Obey window-point-insertion-type.
99
100 2012-04-11 Glenn Morris <rgm@gnu.org>
101
102 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
103
104 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
105
106 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
107
108 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
109
110 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
111 (force_quit_count): New var.
112 (handle_interrupt): Use it.
113
114 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
115
116 * w32.c (w32_delayed_load): Record the full path of the library
117 being loaded (bug#10424).
118
119 2012-04-09 Glenn Morris <rgm@gnu.org>
120
121 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
122 not just in the obarray, before snarfing them. (Bug#11036)
123
124 * Makefile.in ($(leimdir)/leim-list.el):
125 Pass EMACS rather than BUILT_EMACS.
126
127 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
128
129 * process.c (make_process):
130 * process.h: Add integer `gnutls_handshakes_tried' member to
131 process struct.
132
133 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
134 Add convenience `GNUTLS_LOG2i' macro.
135
136 * gnutls.c (gnutls_log_function2i): Convenience log function.
137 (emacs_gnutls_read): Use new log functions,
138 `gnutls_handshakes_tried' process member, and
139 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
140 attempts per process (connection).
141
142 2012-04-09 Chong Yidong <cyd@gnu.org>
143
144 * eval.c (Fuser_variable_p, user_variable_p_eh)
145 (lisp_indirect_variable): Functions deleted.
146 (Fdefvar): Caller changed.
147
148 * callint.c (Finteractive, Fcall_interactively):
149 * minibuf.c (Fread_variable): Callers changed.
150
151 2012-04-09 Eli Zaretskii <eliz@gnu.org>
152
153 * xdisp.c (set_cursor_from_row): If the display string appears in
154 the buffer at position that is closer to point than the position
155 after the display string, display the cursor on the first glyph of
156 the display string. Fixes cursor display when a 'display' text
157 property immediately follows invisible text. (Bug#11094)
158
159 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
160
161 composite.c: use 'double' consistently
162 * composite.c (get_composition_id): Use 'double' consistently
163 instead of converting 'float' to 'double' and vice versa; this is
164 easier to understand and avoids a GCC warning.
165
166 2012-04-09 Glenn Morris <rgm@gnu.org>
167
168 * Makefile.in: Generate leim-list with bootstrap-emacs, in
169 preparation for dumping it with emacs. (Bug#4789)
170 (leimdir): New variable.
171 ($(leimdir)/leim-list.el): New rule.
172 (emacs$(EXEEXT)): Depend on leim-list.el.
173
174 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
175 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
176 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
177
178 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
179
180 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
181 proper alignment.
182
183 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
184
185 * xml.c (init_libxml2_functions) [WINDOWSNT]:
186 Remove unused local variable.
187
188 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
189
190 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
191 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
192 (mark_memory): Mark Lisp_Objects only if pointers might hide in
193 objects, as mark_maybe_pointer will catch them otherwise.
194 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
195 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
196
197 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
198
199 Fix typo that broke non-Windows builds.
200 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
201
202 2012-04-07 Eli Zaretskii <eliz@gnu.org>
203
204 Support building on MS-Windows with libxml2.
205
206 * makefile.w32-in (OBJ2): Add xml.$(O).
207 (GLOBAL_SOURCES): Add xml.c.
208 ($(BLD)/xml.$(O)): New dependency list.
209
210 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
211 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
212 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
213 [!WINDOWSNT]: New macros.
214 (init_libxml2_functions, libxml2_loaded_p): New functions.
215 (parse_region): Call fn_xmlCheckVersion instead of using the macro
216 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
217 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
218 Calls xmlCleanupParser only if libxml2 was loaded (or statically
219 linked in).
220 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
221 Call init_libxml2_functions before calling libxml2 functions.
222 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
223
224 * emacs.c: Don't include libxml/parser.h.
225 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
226 xmlCleanupParser directly.
227
228 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
229
230 2012-04-07 Eli Zaretskii <eliz@gnu.org>
231
232 * indent.c (Fvertical_motion): If there is a display string at
233 point, use it.vpos to compute how many lines to backtrack after
234 move_it_to point. (Bug#11133)
235
236 2012-04-06 Eli Zaretskii <eliz@gnu.org>
237
238 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
239 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
240 about subtle differences between FETCH_CHAR* and STRING_CHAR*
241 macros related to unification of CJK characters. For the details,
242 see the discussion following the message here:
243 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
244
245 2012-04-04 Chong Yidong <cyd@gnu.org>
246
247 * keyboard.c (Vdelayed_warnings_list): Doc fix.
248
249 2012-04-01 Eli Zaretskii <eliz@gnu.org>
250
251 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
252 instead of alloca. (Bug#11138)
253
254 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
255
256 * w32menu.c (is_simple_dialog): Properly check lisp types.
257 (Bug#11141)
258
259 2012-03-31 Eli Zaretskii <eliz@gnu.org>
260
261 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
262 position we get to after a call to move_it_to fails the
263 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
264 only if we wind up in a string from display property. (Bug#11063)
265
266 * window.c (Fdelete_other_windows_internal): Invalidate the row
267 and column information about mouse highlight, so that redisplay
268 restores it after reallocating the glyph matrices. (Bug#7464)
269
270 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
271 string comes from a `display' text property, use the buffer
272 position of that property as if we actually saw that position in
273 the row's glyphs.
274 (move_it_by_lines): Remove the assertion that
275 "it->current_x == 0 && it->hpos == 0" which can be legitimately
276 violated when there's a before-string at the beginning of a line.
277 (Bug#11063)
278
279 2012-03-30 Eli Zaretskii <eliz@gnu.org>
280
281 * xdisp.c (append_space_for_newline): If the default face was
282 remapped, use the remapped face for the appended newline.
283 (extend_face_to_end_of_line): Use the remapped default face for
284 extending the face to the end of the line.
285 (display_line): Call extend_face_to_end_of_line when the default
286 face was remapped. (Bug#11068)
287
288 2012-03-29 Eli Zaretskii <eliz@gnu.org>
289
290 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
291
292 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
293
294 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
295
296 2012-03-27 Glenn Morris <rgm@gnu.org>
297
298 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
299 Doc fixes.
300
301 2012-03-26 Kenichi Handa <handa@m17n.org>
302
303 * dispextern.h (struct glyph): Fix previous change. Change the
304 bit length of glyphless.ch to 25 (Bug#11082).
305
306 2012-03-26 Chong Yidong <cyd@gnu.org>
307
308 * keyboard.c (Vselection_inhibit_update_commands): New variable.
309 (command_loop_1): Use it; inhibit selection update for
310 handle-select-window too (Bug#8996).
311
312 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
313
314 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
315
316 2012-03-25 Kenichi Handa <handa@m17n.org>
317
318 * dispextern.h (struct glyph): Change the bit length of
319 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
320
321 2012-03-24 Eli Zaretskii <eliz@gnu.org>
322
323 * s/ms-w32.h (tzname): Include time.h before redirecting to
324 _tzname. Fixes the MSVC build. (Bug#9960)
325
326 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
327
328 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
329 characters.
330
331 * xterm.c (XTread_socket): Only modify handling_signal if
332 !SYNC_INPUT. (Bug#11080)
333
334 2012-03-23 Eli Zaretskii <eliz@gnu.org>
335
336 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
337 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
338 when fetching a multibyte character consumes more bytes than
339 CHAR_BYTES returns, due to unification of CJK characters in
340 string_char. (Bug#11073)
341
342 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
343
344 * process.c (wait_reading_process_output): Handle pty disconnect
345 by refraining from sending oneself a SIGCHLD (bug#10933).
346
347 2012-03-22 Chong Yidong <cyd@gnu.org>
348
349 * dispextern.h (struct it): New member string_from_prefix_prop_p.
350
351 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
352 Mark string as coming from a prefix property.
353 (handle_face_prop): Use default face for prefix strings (Bug#4281).
354 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
355
356 2012-03-21 Chong Yidong <cyd@gnu.org>
357
358 * xfaces.c (Vface_remapping_alist): Doc fix.
359
360 2012-03-20 Eli Zaretskii <eliz@gnu.org>
361
362 * w32proc.c (Fw32_set_console_codepage)
363 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
364 Doc fixes.
365
366 2012-03-20 Chong Yidong <cyd@gnu.org>
367
368 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
369 to reflect default non-nil value of redisplay-dont-pause.
370
371 2012-03-19 Kenichi Handa <handa@m17n.org>
372
373 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
374 it fit in a valid range (Bug#11003).
375
376 2012-03-18 Eli Zaretskii <eliz@gnu.org>
377
378 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
379 that is not from display property, accept the row as a "cursor
380 row" if one of the string's character has a non-nil `cursor'
381 property. Fixes cursor positioning when there are newlines in
382 overlay strings, e.g. in icomplete.el. (Bug#11035)
383
384 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
385
386 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
387
388 2012-03-12 Chong Yidong <cyd@gnu.org>
389
390 * eval.c (inhibit_lisp_code): Rename from
391 inhibit_window_configuration_change_hook; move from window.c.
392
393 * xfns.c (unwind_create_frame_1, Fx_create_frame):
394 * window.c (run_window_configuration_change_hook)
395 (syms_of_window): Callers changed.
396
397 2012-03-11 Chong Yidong <cyd@gnu.org>
398
399 * keymap.c (Fkey_description): Doc fix (Bug#9700).
400
401 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
402
403 2012-03-10 Chong Yidong <cyd@gnu.org>
404
405 * frame.c (other_visible_frames): Don't assume the selected frame
406 is visible (Bug#10955).
407
408 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
409
410 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
411
412 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
413
414 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
415 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
416 zero (Bug#10954).
417
418 2012-03-03 Glenn Morris <rgm@gnu.org>
419
420 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
421
422 2012-03-02 Eli Zaretskii <eliz@gnu.org>
423
424 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
425 position past the first glyph_row that ends at ZV. (Bug#10902)
426 (redisplay_window, next_element_from_string): Fix typos in
427 comments.
428 (redisplay_window): Pass to move_it_vertically the margin in
429 pixels, not in screen lines.
430
431 2012-03-02 Glenn Morris <rgm@gnu.org>
432
433 * buffer.c (buffer-list-update-hook): Doc fix.
434
435 2012-02-29 Eli Zaretskii <eliz@gnu.org>
436
437 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
438 push_it before setting up the iterator for the first overlay
439 string, even if we have an empty string loaded.
440 (next_overlay_string): If there's an empty string on the iterator
441 stack, pop the stack. (Bug#10903)
442
443 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
444
445 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
446 Suggested by Stefan Monnier in
447 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
448 * alloc.c (widen_to_Lisp_Object): New static function.
449 (mark_memory): Also mark Lisp_Objects by fetching pointer words
450 and widening them to Lisp_Objects. This would work even if
451 USE_LSB_TAG is defined and wide integers are used, which might
452 happen in a future version of Emacs.
453
454 2012-02-25 Chong Yidong <cyd@gnu.org>
455
456 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
457 Doc fix.
458
459 * xselect.c (Fx_selection_exists_p): Doc fix.
460 (x_clipboard_manager_save_all): Print an informative message
461 before saving to clipboard manager.
462
463 2012-02-24 Chong Yidong <cyd@gnu.org>
464
465 * keyboard.c (process_special_events): Handle all X selection
466 requests in kbd_buffer, not just the next one (Bug#8869).
467
468 2012-02-23 Chong Yidong <cyd@gnu.org>
469
470 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
471 call when setting menu-bar-lines and tool-bar-lines parameters.
472 (unwind_create_frame_1): New helper function.
473
474 * window.c (inhibit_window_configuration_change_hook): New var.
475 (run_window_configuration_change_hook): Obey it.
476 (syms_of_window): Initialize it.
477
478 2012-02-22 Chong Yidong <cyd@gnu.org>
479
480 * xterm.c (x_draw_image_relief): Add missing type check for
481 Vtool_bar_button_margin (Bug#10743).
482
483 2012-02-21 Chong Yidong <cyd@gnu.org>
484
485 * fileio.c (Vfile_name_handler_alist): Doc fix.
486
487 * buffer.c (Fget_file_buffer): Protect against invalid file
488 handler return value.
489
490 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
491
492 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
493 when computing $valmask.
494
495 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
496 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
497 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
498 It's useless in that case, and it can cause problems on hosts
499 that allocate halves of EMACS_INT values separately.
500 Reported by Dan Horák. Diagnosed by Andreas Schwab in
501 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
502 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
503 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
504 it avoids undefined behavior on hosts where shifting right by more
505 than the word width has undefined behavior.
506
507 2012-02-19 Chong Yidong <cyd@gnu.org>
508
509 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
510 (Funhandled_file_name_directory, Ffile_name_as_directory)
511 (Fdirectory_file_name, Fexpand_file_name)
512 (Fsubstitute_in_file_name): Protect against invalid file handler
513 return values (Bug#10845).
514
515 2012-02-18 Eli Zaretskii <eliz@gnu.org>
516
517 * .gdbinit (pitx): Fix incorrect references to fields of the
518 iterator stack.
519
520 2012-02-17 Chong Yidong <cyd@gnu.org>
521
522 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
523
524 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
525
526 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
527 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
528
529 2012-02-15 Chong Yidong <cyd@gnu.org>
530
531 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
532 marked as special. Also, starting docstrings with * is obsolete.
533
534 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
535
536 * gnutls.c (emacs_gnutls_write): Fix last change.
537
538 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
539
540 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
541 send_process.
542
543 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
544
545 * keymap.c (Fsingle_key_description): Handle char ranges.
546
547 2012-02-12 Chong Yidong <cyd@gnu.org>
548
549 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
550 as that creates a dangerous corner case.
551
552 * window.c (Fdelete_window_internal): Invalidate the mouse
553 highlight (Bug#9904).
554
555 2012-02-12 Glenn Morris <rgm@gnu.org>
556
557 * xselect.c (Fx_own_selection_internal)
558 (Fx_get_selection_internal, Fx_disown_selection_internal)
559 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
560 * nsselect.m (Fx_own_selection_internal)
561 (Fx_disown_selection_internal, Fx_selection_exists_p)
562 (Fx_selection_owner_p, Fx_get_selection_internal):
563 Sync docs and argument specs with the xselect.c versions.
564
565 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
566
567 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
568
569 2012-02-11 Eli Zaretskii <eliz@gnu.org>
570
571 * w32select.c (Fx_selection_exists_p): Sync doc string and
572 argument list with xselect.c. (Bug#10783)
573
574 * w16select.c (Fx_selection_exists_p): Sync doc string and
575 argument list with xselect.c. (Bug#10783)
576
577 2012-02-10 Glenn Morris <rgm@gnu.org>
578
579 * fns.c (Fsecure_hash): Doc fix.
580
581 2012-02-09 Kenichi Handa <handa@m17n.org>
582
583 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
584
585 2012-02-07 Chong Yidong <cyd@gnu.org>
586
587 * buffer.c (Fbuffer_local_variables)
588 (buffer_lisp_local_variables): Handle unbound vars correctly;
589 don't let Qunbound leak into Lisp.
590
591 2012-02-07 Glenn Morris <rgm@gnu.org>
592
593 * image.c (Fimagemagick_types): Doc fix.
594
595 * image.c (imagemagick-render-type): Change it from a lisp object
596 to an integer. Move the doc here from the lisp manual.
597 Treat all values not equal to 0 the same.
598
599 2012-02-06 Chong Yidong <cyd@gnu.org>
600
601 * doc.c (store_function_docstring): Avoid applying docstring of
602 alias to base function (Bug#2603).
603
604 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
605
606 * .gdbinit (pp1, pv1): Remove redundant defines.
607 (pr): Use pp.
608
609 2012-02-04 Chong Yidong <cyd@gnu.org>
610
611 * nsterm.m: Declare a global (Bug#10694).
612
613 2012-02-04 Eli Zaretskii <eliz@gnu.org>
614
615 * w32.c (get_emacs_configuration_options):
616 Include --enable-checking, if specified, in the return value.
617
618 2012-02-04 Martin Rudalics <rudalics@gmx.at>
619
620 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
621 after rounding frame sizes. (Bug#9723)
622
623 2012-02-04 Eli Zaretskii <eliz@gnu.org>
624
625 * keyboard.c (adjust_point_for_property): Don't position point
626 before BEGV. (Bug#10696)
627
628 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
629
630 Handle overflow when computing char display width (Bug#9496).
631 * character.c (char_width): Return EMACS_INT, not int.
632 (char_width, c_string_width): Check for overflow when
633 computing the width; this is possible now that individual
634 characters can have unbounded width. Problem introduced
635 by merge from Emacs 23 on 2012-01-19.
636
637 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
638
639 * dbusbind.c (Fdbus_register_method): Mention the return value
640 :ignore in the docstring.
641
642 2012-02-02 Glenn Morris <rgm@gnu.org>
643
644 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
645
646 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
647 Unconditionally set to t. (Bug#10673)
648 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
649 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
650 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
651
652 2012-02-02 Kenichi Handa <handa@m17n.org>
653
654 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
655 0, do not call append_composite_glyph.
656
657 2012-02-02 Kenichi Handa <handa@m17n.org>
658
659 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
660 NULL (Bug#6988).
661 (x_produce_glyphs): If the component of a composition is a null
662 string, set it->pixel_width to 1 to avoid zero-width glyph.
663
664 2012-02-01 Eli Zaretskii <eliz@gnu.org>
665
666 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
667 first 2 arguments are identical. This makes inserting large
668 output from a subprocess an order of magnitude faster on
669 MS-Windows, where all sbrk'ed memory is always contiguous.
670
671 2012-01-31 Glenn Morris <rgm@gnu.org>
672
673 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
674 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
675 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
676
677 2012-01-29 Glenn Morris <rgm@gnu.org>
678
679 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
680
681 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
682
683 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
684
685 2012-01-28 Chong Yidong <cyd@gnu.org>
686
687 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
688
689 2012-01-26 Chong Yidong <cyd@gnu.org>
690
691 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
692
693 * search.c (Fsearch_forward, Fsearch_backward): Document negative
694 repeat counts (Bug#10507).
695
696 2012-01-26 Glenn Morris <rgm@gnu.org>
697
698 * lread.c (syms_of_lread): Doc fix.
699
700 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
701
702 * coding.c (encode_designation_at_bol): Change return value to
703 EMACS_INT.
704
705 2012-01-25 Chong Yidong <cyd@gnu.org>
706
707 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
708
709 2012-01-21 Chong Yidong <cyd@gnu.org>
710
711 * floatfns.c (Fcopysign): Make the second argument non-optional,
712 since nil is not allowed anyway.
713
714 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
715
716 * process.c (read_process_output): Use p instead of XPROCESS (proc).
717 (send_process): Likewise.
718
719 2012-01-19 Martin Rudalics <rudalics@gmx.at>
720
721 * window.c (save_window_save, Fcurrent_window_configuration)
722 (Vwindow_persistent_parameters): Do not use Qstate.
723 Rewrite doc-strings.
724
725 2012-01-19 Kenichi Handa <handa@m17n.org>
726
727 * character.c (char_width): New function.
728 (Fchar_width, c_string_width, lisp_string_width):
729 Use char_width (Bug#9496).
730
731 2012-01-16 Martin Rudalics <rudalics@gmx.at>
732
733 * window.c (Vwindow_persistent_parameters): New variable.
734 (Fset_window_configuration, save_window_save): Handle persistent
735 window parameters.
736
737 2012-01-14 Eli Zaretskii <eliz@gnu.org>
738
739 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
740 thrashing the stack of the thread. (Bug#9087)
741
742 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
743
744 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
745
746 2012-01-11 Eli Zaretskii <eliz@gnu.org>
747
748 * xdisp.c (rows_from_pos_range): Handle the case where the
749 highlight ends on a newline. (Bug#10464)
750 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
751 he end column for display of highlight that ends on a newline
752 before a R2L line.
753
754 2012-01-11 Glenn Morris <rgm@gnu.org>
755
756 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
757 from load-path also when installation-directory is nil. (Bug#10208)
758
759 2012-01-10 Glenn Morris <rgm@gnu.org>
760
761 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
762
763 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
764 Update template values to be closer to their typical values these days.
765
766 2012-01-09 Eli Zaretskii <eliz@gnu.org>
767
768 * xdisp.c (rows_from_pos_range): Accept additional argument
769 DISP_STRING, and accept any glyph in a row whose object is that
770 string as eligible for mouse highlight. Fixes mouse highlight of
771 display strings from overlays. (Bug#10464)
772
773 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
774
775 emacs: fix an auto-save permissions race condition (Bug#10400)
776 * fileio.c (auto_saving_dir_umask): New static var.
777 (Fmake_directory_internal): Use it.
778 (do_auto_save_make_dir): Set it, instead of invoking chmod after
779 creating the directory. The old code temporarily assigns
780 too-generous permissions to the directory.
781 (do_auto_save_eh): Clear it.
782 (Fdo_auto_save): Catch all errors, not just file errors, so
783 that the var is always cleared.
784
785 2012-01-07 Eli Zaretskii <eliz@gnu.org>
786
787 * search.c (scan_buffer): Pass character positions to
788 know_region_cache, not byte positions. (Bug#6540)
789
790 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
791
792 * w32.c (sys_rename): Report EXDEV when rename of a directory
793 fails because the target is on another logical disk. (Bug#10284)
794
795 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
796
797 * xterm.c (x_embed_request_focus): New function.
798
799 * xterm.h: Add prototype.
800
801 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
802
803 2012-01-05 Glenn Morris <rgm@gnu.org>
804
805 * emacs.c (emacs_copyright): Update short copyright year to 2012.
806
807 2012-01-01 Eli Zaretskii <eliz@gnu.org>
808
809 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
810 Load gnutls_transport_set_lowat only if GnuTLS version is below
811 2.11.1.
812 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
813 GnuTLS versions below 2.11.1.
814
815 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
816
817 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
818 to the doc string advising against its use for altering the way
819 windows are scrolled.
820
821 2011-12-28 Kenichi Handa <handa@m17n.org>
822
823 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
824 coding-system ASCII compatible only when it does not produce BOM
825 on encoding (Bug#10383).
826
827 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
828
829 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
830 can scroll.
831 (create_and_show_popup_menu): Always use menu_position_func for
832 Gtk3 (Bug#10361).
833
834 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
835
836 * callint.c (Fcall_interactively): Don't truncate prompt string.
837
838 2011-12-23 Eli Zaretskii <eliz@gnu.org>
839
840 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
841 property that ends at ZV, so that the bidi iteration could be
842 resumed from there (after widening). (Bug#10360)
843
844 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
845
846 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
847
848 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
849
850 * nsterm.m (x_free_frame_resources):
851 Release f->output_data.ns->miniimage.
852 (ns_index_color): Fix indentation. Do not retain
853 color_table->colors[i].
854
855 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
856 before returning.
857
858 * nsfns.m (x_set_background_color): Assign return value from
859 ns_index_color to face-background instead of NSColor*.
860 (ns_implicitly_set_icon_type): Fix indentation.
861 Change assignment in for loop to comparison.
862
863 * emacs.c (ns_pool): New variable.
864 (main): Assign ns_pool.
865 (Fkill_emacs): Call ns_release_autorelease_pool.
866
867 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
868 autorelease fdesc, release fdAttrs and tdict.
869 (ns_get_covering_families): Release charset.
870 (ns_findfonts): Release NSFontDescriptor created with new.
871 (ns_uni_to_glyphs): Fix indentation.
872 (setString): Release attrStr before assigning new value.
873
874 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
875
876 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
877 and NS_IMPL_COCOA.
878 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
879 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
880
881 2011-12-18 David Reitter <reitter@cmu.edu>
882
883 * nsterm.m (ns_term_init): Subscribe for notifications
884 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
885 to method trackingNotification in EmacsMenu.
886
887 * nsmenu.m (trackingMenu): New variable.
888 (trackingNotification): New method (from Aquamacs).
889 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
890 from Aquamacs (Bug#7030).
891
892 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
893
894 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
895 (symbol_to_nsstring): Fix indentation.
896 (ns_symbol_to_pb): New function.
897 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
898 (Fns_rotate_cut_buffers_internal): Remove.
899 (Fns_store_selection_internal): Rename from
900 Fns_store_cut_buffer_internal.
901 (ns_get_foreign_selection, Fx_own_selection_internal)
902 (Fx_disown_selection_internal, Fx_selection_exists_p)
903 (Fns_get_selection_internal, Fns_store_selection_internal):
904 Use ns_symbol_to_pb and check if return value is nil.
905 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
906 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
907 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
908 renamed to Sns_store_selection_internal.
909 (ns_handle_selection_request): Move code to Fx_own_selection_internal
910 and remove this function.
911 (ns_handle_selection_clear): Remove, never used.
912 (Fx_own_selection_internal): Move code from ns_handle_selection_request
913 here.
914
915 2011-12-17 Ken Brown <kbrown@cornell.edu>
916
917 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
918 GID is unknown (Bug#10257).
919
920 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
921
922 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
923 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
924 which caused a build failure on GNU/Linux IA-64. This problem was
925 introduced by my 2011-10-07 patch.
926
927 2011-12-15 Juri Linkov <juri@jurta.org>
928
929 * image.c (imagemagick_error): New function. (Bug#10112)
930 (imagemagick_load_image): Comment out `MagickSetResolution' call.
931 Use `imagemagick_error' where ImageMagick functions return
932 `MagickFalse'.
933 (Fimagemagick_types): Add `Fnreverse' to return the list in the
934 proper order.
935
936 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
937
938 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
939 fill background (Bug#8992).
940
941 2011-12-13 Martin Rudalics <rudalics@gmx.at>
942
943 * window.c (Vwindow_combination_resize)
944 (Vwindow_combination_limit): Use t instead of non-nil in
945 doc-strings.
946 (Vrecenter_redisplay): Add first sentence of doc-string on
947 separate line.
948 (Frecenter): Fix doc-string typo.
949
950 2011-12-11 Kenichi Handa <handa@m17n.org>
951
952 * coding.c (Funencodable_char_position): Pay attention to the
953 buffer text relocation (Bug#9389).
954
955 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
956
957 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
958 gtk_init (Bug#10100).
959
960 2011-12-10 Eli Zaretskii <eliz@gnu.org>
961
962 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
963 IT->string is nil. (Bug#10263)
964
965 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
966
967 * nsterm.h (x_free_frame_resources): Declare.
968
969 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
970 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
971
972 * nsterm.h (ns_get_defaults_value): Declare.
973
974 * nsterm.m (ns_default): Call ns_get_defaults_value.
975
976 2011-12-09 Eli Zaretskii <eliz@gnu.org>
977
978 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
979 (Bug#10170)
980
981 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
982
983 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
984 that where the value of an _OBJC_* symbol points to is in the .bss
985 section (Bug#10240).
986
987 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
988
989 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
990 after the loop to call ccl_driver at least once (Bug#8619).
991
992 2011-12-08 Kenichi Handa <handa@m17n.org>
993
994 * ftfont.c (get_adstyle_property): Fix previous change
995 (Bug#10233).
996
997 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
998
999 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1000 dirs from the default value of EMACSLOADPATH (bug#10208).
1001
1002 2011-12-07 Glenn Morris <rgm@gnu.org>
1003
1004 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1005 installation and source directories as well. (Bug#10208)
1006
1007 2011-12-06 Chong Yidong <cyd@gnu.org>
1008
1009 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1010
1011 2011-12-06 Glenn Morris <rgm@gnu.org>
1012
1013 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1014 as an error, not just -1. (Bug#10217)
1015
1016 2011-12-05 Chong Yidong <cyd@gnu.org>
1017
1018 * keyboard.c (process_special_events): New function.
1019 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1020
1021 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1022
1023 * coding.c (encode_designation_at_bol): Don't use uninitialized
1024 local variable (Bug#9318).
1025
1026 2011-12-05 Kenichi Handa <handa@m17n.org>
1027
1028 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1029 return Qnil (Bug#8046, Bug#10193).
1030
1031 2011-12-05 Kenichi Handa <handa@m17n.org>
1032
1033 * coding.c (encode_designation_at_bol): New args charbuf_end and
1034 dst. Return the number of produced bytes. Callers changed.
1035 (coding_set_source): Return how many bytes coding->source was
1036 relocated.
1037 (coding_set_destination): Return how many bytes
1038 coding->destination was relocated.
1039 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1040 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1041
1042 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1043
1044 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1045 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1046 macro (Bug#9318).
1047
1048 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1049
1050 The following changes are to fix Bug#9318.
1051
1052 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1053 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1054 (encode_coding_iso_2022, encode_coding_sjis)
1055 (encode_coding_big5, encode_coding_charset): Use the above macros.
1056
1057 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1058
1059 * lisp.h (process_quit_flag): Fix external declaration.
1060
1061 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1062
1063 Don't macro-inline non-performance-critical code.
1064 * eval.c (process_quit_flag): New function.
1065 * lisp.h (QUIT): Use it.
1066
1067 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1068
1069 * nsfns.m (get_geometry_from_preferences): New function.
1070 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1071
1072 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1073
1074 * emacs.c (Qkill_emacs): Define.
1075 (syms_of_emacs): Initialize it.
1076 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1077 Qquit_flag to `kill-emacs' instead.
1078 (quit_throw_to_read_char): Add parameter `from_signal'.
1079 All callers changed. Call Fkill_emacs if requested and safe.
1080 * lisp.h (QUIT): Call Fkill_emacs if requested.
1081
1082 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1083
1084 * widget.c (update_wm_hints): Return if wmshell is null.
1085 (widget_update_wm_size_hints): New function.
1086
1087 * widget.h (widget_update_wm_size_hints): Declare.
1088
1089 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1090 widget_update_wm_size_hints (Bug#10104).
1091
1092 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1093
1094 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1095 before a newline, prepare the bidi iterator for consuming the
1096 newline, and keep the current paragraph direction. (Bug#10183)
1097 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1098
1099 2011-12-02 Juri Linkov <juri@jurta.org>
1100
1101 * search.c (Fword_search_regexp): New Lisp function created from
1102 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1103 (Fword_search_backward, Fword_search_forward)
1104 (Fword_search_backward_lax, Fword_search_forward_lax):
1105 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1106 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1107
1108 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1109
1110 * fileio.c (Finsert_file_contents): Move after-change-function call
1111 to before the "handled:" label, since all "goto handled" appear in
1112 cases where the *-change-functions have already been properly called
1113 (bug#10117).
1114
1115 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1116
1117 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1118 waiting for input. (Bug#10169)
1119
1120 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1121
1122 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1123 verifies glyph row's hash code--we have just reallocated the
1124 glyphs, so their contents can be complete garbage. (Bug#10164)
1125
1126 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1127
1128 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1129
1130 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1131
1132 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1133 attributes are tested _before_ calling verify_row_hash, to protect
1134 against GCC re-ordering of the tests. (Bug#10164)
1135
1136 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1137
1138 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1139
1140 * xterm.c (handle_one_xevent): Only set async_visible and friends
1141 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1142 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1143 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1144
1145 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1146
1147 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1148 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1149 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1150 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1151 All uses changed to use GCPRO1 etc.
1152 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1153 Revert to old implementation (i.e., before 2011-03-11).
1154
1155 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1156
1157 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1158 of scroll runs so as to avoid assigning disabled bogus rows and
1159 unnecessary graphics copy operations.
1160
1161 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1162
1163 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1164 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1165 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1166 (malloc, free, realloc, calloc): Redirect to e_* only when
1167 compiling Emacs.
1168
1169 * lisp.h (GCTYPEBITS): Move before first use.
1170 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1171 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1172 this macro definition.
1173
1174 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1175 _MSC_VER.
1176
1177 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1178
1179 * gtkutil.c (xg_create_frame_widgets):
1180 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1181 present with Gtk+ 2.0.
1182
1183 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1184
1185 * fileio.c (Finsert_file_contents): Undo previous change; see
1186 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1187
1188 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1189
1190 Rename locals to avoid shadowing.
1191 * fileio.c (Finsert_file_contents):
1192 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1193 * process.c (wait_reading_process_output):
1194 Rename inner 'proc' to 'p' to avoid shadowing.
1195 Indent for consistency with usual Emacs style.
1196
1197 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1198
1199 * xdisp.c (redisplay_window): If cursor row is not fully visible
1200 after recentering, and scroll-conservatively is set to a large
1201 number, scroll window by a few more lines to make the cursor fully
1202 visible and out of scroll-margin. (Bug#10105)
1203 (start_display): Don't move to the next line if the display should
1204 start at a newline that is part of a display vector or an overlay
1205 string. (Bug#10119)
1206
1207 2011-11-24 Juri Linkov <juri@jurta.org>
1208
1209 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1210 after the `MagickPingImage' call. (Bug#10112)
1211
1212 2011-11-23 Chong Yidong <cyd@gnu.org>
1213
1214 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1215
1216 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1217
1218 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1219 making another buffer current. (Bug#10114)
1220
1221 2011-11-23 Glenn Morris <rgm@gnu.org>
1222
1223 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1224
1225 2011-11-23 Chong Yidong <cyd@gnu.org>
1226
1227 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1228 using it (Bug#5984).
1229
1230 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1231
1232 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1233 and header-lines, as they don't have one computed for them.
1234 (Bug#10098)
1235
1236 * .gdbinit (prow): Make displayed values more self-explaining.
1237 Add row's hash code.
1238
1239 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1240
1241 * process.c (wait_reading_process_output): Fix asynchrounous
1242 GnuTLS socket handling on some versions of the GnuTLS library.
1243 (wait_reading_process_output): Add comment and URL.
1244
1245 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1246
1247 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1248
1249 2011-11-21 Chong Yidong <cyd@gnu.org>
1250
1251 * window.c (Fnext_window, Fprevious_window): Doc fix.
1252
1253 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1254
1255 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1256
1257 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1258
1259 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1260
1261 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1262
1263 * window.c (Fset_window_combination_limit): Rename argument
1264 STATUS to LIMIT.
1265 (Vwindow_combination_limit): Remove "status" from doc-string.
1266
1267 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1268
1269 * m/ibms390.h: Remove.
1270 * m/ibms390x.h: Don't include "ibms390.h".
1271
1272 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1273
1274 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1275 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1276
1277 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1278
1279 * casetab.c (Fset_case_table):
1280 * charset.c (Fcharset_after): Fix typos.
1281
1282 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1283
1284 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1285 Otherwise, valgrind does not work on some platforms.
1286 Problem reported by Andreas Schwab in
1287 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1288 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1289 is set, removing the need for VIRT_ADDRESS_VARIES.
1290 (PURE_P): Use a more-efficient implementation that needs just one
1291 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1292 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1293 to 4 (xorl, subq, cmpq, setbe).
1294 * alloc.c (pure): Always extern now, since that's the
1295 VIRT_ADDR_VARIES behavior.
1296 (PURE_POINTER_P): Use a single comparison, not two, for
1297 consistency with the new puresize.h.
1298 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1299 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1300 Remove VIRT_ADDR_VARIES no longer needed.
1301
1302 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1303
1304 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1305 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1306 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1307 behave as if the cursor position were at the window margin.
1308
1309 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1310 and the cursor position is out of bounds, behave as if the cursor
1311 position were at the window margin. (Bug#10075)
1312
1313 2011-11-18 Chong Yidong <cyd@gnu.org>
1314
1315 * window.c (Fwindow_combination_limit): Make first argument
1316 non-optional, since it is meaningless for live windows like the
1317 selected window.
1318
1319 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1320
1321 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1322
1323 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1324
1325 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1326 (graft_intervals_into_buffer): Simplify.
1327
1328 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1329
1330 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1331 hash values of the two rows.
1332 (copy_row_except_pointers): Preserve the used[] arrays and the
1333 hash values of the two rows. (Bug#10035)
1334 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1335
1336 * xdisp.c (row_hash): New function, body extracted from
1337 compute_line_metrics.
1338 (compute_line_metrics): Call row_hash, instead of computing the
1339 hash code inline.
1340
1341 * dispnew.c (verify_row_hash): Call row_hash for computing the
1342 hash code of a row, instead of duplicating code from xdisp.c.
1343
1344 * dispextern.h (row_hash): Add prototype.
1345
1346 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1347
1348 * frame.c (delete_frame): Don't delete the terminal when the last
1349 X frame is closed if emacs is built with GTK toolkit.
1350
1351 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1352
1353 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1354
1355 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1356
1357 * window.c (Vwindow_splits): Rename to
1358 Vwindow_combination_resize. Suggested by Juri Linkov.
1359 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1360 of Vwindow_splits.
1361
1362 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1363
1364 * nsfns.m (Fns_font_name):
1365 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1366
1367 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1368
1369 * window.h (window): Rename slot "nest" to "combination_limit".
1370 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1371 (Fset_window_nest): Rename to Fset_window_combination_limit.
1372 (Vwindow_nest): Rename to Vwindow_combination_limit.
1373 (recombine_windows, make_parent_window, make_window)
1374 (Fsplit_window_internal, saved_window)
1375 (Fset_window_configuration, save_window_save): Rename all
1376 occurrences of window_nest to window_combination_limit.
1377
1378 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1379
1380 * image.c (imagemagick_load_image): Fix typo.
1381
1382 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1383
1384 * xdisp.c (display_line): Move the call to
1385 highlight_trailing_whitespace before the call to
1386 compute_line_metrics, since the latter needs to see the final
1387 faces of all the glyphs to compute ROW's hash value.
1388 Fixes assertion violations in row_equal_p. (Bug#10035)
1389
1390 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1391
1392 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1393 just return (bug#10044).
1394
1395 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1396
1397 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1398 with user-defined heap size. Bump the default size of the temacs
1399 heap to 27MB, to avoid memory warning when running temacs.
1400 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1401
1402 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1403 current_matrix and desired_matrix. (Bug#9990)
1404 (verify_row_hash) [XASSERTS]: New function.
1405 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1406 that the hash value of glyph rows is correct.
1407
1408 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1409
1410 * window.h (window): Remove splits slot.
1411 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1412 (Fdelete_other_windows_internal, make_parent_window)
1413 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1414 (Fset_window_configuration, save_window_save): Don't deal with
1415 split status of windows.
1416 (saved_window): Remove splits slot.
1417 (Vwindow_splits): Rewrite doc-string.
1418
1419 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1420
1421 * xfns.c (unwind_create_frame):
1422 * nsfns.m (unwind_create_frame):
1423 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1424 Vframe_list (Bug#9999).
1425
1426 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1427
1428 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1429
1430 2011-11-11 Kenichi Handa <handa@m17n.org>
1431
1432 * callproc.c (Fcall_process): Set the member dst_multibyte of
1433 process_coding.
1434
1435 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1436
1437 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1438 avoid a crash (bug#9496).
1439
1440 2011-11-09 Chong Yidong <cyd@gnu.org>
1441
1442 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1443 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1444
1445 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1446
1447 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1448
1449 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1450
1451 Avoid some portability problems by eschewing 'extern inline' functions.
1452 The trivial performance wins aren't worth the portability hassles; see
1453 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1454 et seq.
1455 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1456 (window_box_width, window_box_left, window_box_left_offset)
1457 (window_box_right, window_box_right_offset): Undo previous change,
1458 by removing the "extern"s.
1459 * intervals.c (adjust_intervals_for_insertion)
1460 (adjust_intervals_for_deletion): Undo previous change,
1461 making these static again.
1462 (offset_intervals, temp_set_point_both, temp_set_point)
1463 (copy_intervals_to_string): No longer inline.
1464 * xdisp.c (window_text_bottom_y, window_box_width)
1465 (window_box_height, window_box_left_offset)
1466 (window_box_right_offset, window_box_left, window_box_right)
1467 (window_box): No longer inline.
1468
1469 2011-11-08 Chong Yidong <cyd@gnu.org>
1470
1471 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1472 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1473 Signal an error if not a live window.
1474 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1475 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1476
1477 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1478
1479 * lisp.h (syms_of_abbrev): Remove declaration.
1480 Reported by CHENG Gao <chenggao@royau.me>.
1481
1482 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1483
1484 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1485 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1486 of temacs in GUI mode.
1487
1488 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1489
1490 * window.h: Declare delete_all_child_windows instead of
1491 delete_all_subwindows.
1492 * window.c (Fwindow_nest, Fset_window_nest)
1493 (Fset_window_new_total, Fset_window_new_normal)
1494 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1495 (delete_all_subwindows): Rename to delete_all_child_windows.
1496 (Fdelete_other_windows_internal, Fset_window_configuration):
1497 Call delete_all_child_windows instead of delete_all_subwindows.
1498 * frame.c (delete_frame): Call delete_all_child_windows instead
1499 of delete_all_subwindows.
1500
1501 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1502
1503 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1504 This is also needed for porting to any host where GC_MARK_STACK is
1505 not GC_MAKE_GCPROS_NOOPS.
1506 (which_symbols): Use it.
1507
1508 2011-11-07 Kenichi Handa <handa@m17n.org>
1509
1510 * coding.c (coding_set_destination): Check coding->src_pos only
1511 when coding->src_object is a buffer (bug#9910).
1512
1513 * process.c (send_process): Set the member src_multibyte of coding
1514 to 0 (bug#9911) when sending a unibyte text.
1515
1516 * callproc.c (Fcall_process): Set the member src_multibyte of
1517 process_coding to 0 (bug#9912).
1518
1519 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1520
1521 * xmenu.c (cleanup_widget_value_tree): New function.
1522 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1523 calling free_menubar_widget_value_tree directly (Bug#9830).
1524
1525 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1526
1527 Fix some portability problems with 'inline'.
1528 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1529 (window_box_width, window_box_left, window_box_left_offset)
1530 (window_box_right, window_box_right_offset): Declare extern.
1531 Otherwise, these inline functions do not conform to C99 and
1532 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1533 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1534 * intervals.c (adjust_intervals_for_insertion)
1535 (adjust_intervals_for_deletion): Now extern, because otherwise the
1536 extern inline functions 'offset_intervals' couldn't refer to it.
1537 (static_offset_intervals): Remove.
1538 (offset_intervals): Rewrite using the old contents of
1539 static_offset_intervals. The old version didn't conform to C99
1540 because an extern inline function contained a reference to an
1541 identifier with static linkage.
1542
1543 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1544
1545 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1546 GC.
1547
1548 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1549
1550 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1551 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1552 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1553 return Qleft_to_right.
1554
1555 2011-11-06 Chong Yidong <cyd@gnu.org>
1556
1557 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1558 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1559 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1560 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1561 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1562 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1563 (Fwindow_vscroll): Doc fix.
1564 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1565 argument, since it makes no sense to pass a live window and for
1566 consistency with window-child.
1567
1568 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1569
1570 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1571 support MSVC.
1572
1573 2011-11-05 Jason Rumney <jasonr@gnu.org>
1574
1575 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1576 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1577 fonts (Bug#6029).
1578 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1579 bitwise arithmetic preventing use of unicode-sip and non-truetype
1580 opentype fonts.
1581
1582 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1583
1584 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1585 "emacs"-only part.
1586
1587 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1588 initialization code to keep similarity to xfns.c after changes
1589 from 2011-11-05.
1590
1591 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1592
1593 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1594 (unwind_create_frame): New function (Bug#9943).
1595 (Fx_create_frame): Restructure code to be more similar to the one in
1596 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1597 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1598 Move terminal->reference_count++ just before making the frame official
1599 (Bug#9943).
1600
1601 * nsterm.m (x_free_frame_resources): New function.
1602 (x_destroy_window): Move code to x_free_frame_resources.
1603
1604 * xfns.c (unwind_create_frame): Fix comment.
1605 (Fx_create_frame, x_create_tip_frame):
1606 Move terminal->reference_count++ just before making the frame
1607 official. Move initialization of image_cache_refcount and
1608 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1609
1610 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1611
1612 Support MSVC build with newer versions of Visual Studio.
1613 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1614 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1615 nt/gmake.defs.
1616
1617 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1618 which are not supported by MSVC.
1619 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1620 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1621 bitfields.
1622 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1623 types in bitfields.
1624 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1625
1626 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1627
1628 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1629
1630 Support MSVC build with newer versions of Visual Studio.
1631 * w32.c: Don't include w32api.h for MSVC.
1632 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1633
1634 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1635 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1636 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1637 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1638 e_* cousins.
1639 (alloca) [_MSC_VER]: Define to _alloca.
1640
1641 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1642
1643 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1644
1645 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1646
1647 * xdisp.c (note_mouse_highlight): If either of
1648 previous/next-single-property-change returns nil, treat that as
1649 the beginning or the end of the buffer. (Bug#9955)
1650
1651 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1652
1653 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1654 label is not null (Bug#9951).
1655 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1656 may be NULL.
1657
1658 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1659
1660 * window.c (Fwindow_body_size): Mention in the doc string that the
1661 return value is in frame's canonical units. (Bug#9949)
1662
1663 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1664
1665 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1666
1667 * w32fns.c (unwind_create_frame): If needed, free the glyph
1668 matrices of the partially constructed frame. (Bug#9943)
1669 * xfns.c (unwind_create_frame): Likewise.
1670
1671 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1672
1673 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1674 Don't stop backward scan on the continuation glyph, even though
1675 its CHARPOS is positive.
1676 (mouse_face_from_buffer_pos, note_mouse_highlight):
1677 Rename cover_string to disp_string.
1678
1679 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1680
1681 * window.c (temp_output_buffer_show): Don't use
1682 Vtemp_buffer_show_specifiers.
1683 (Vtemp_buffer_show_specifiers): Remove unused variable.
1684
1685 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1686
1687 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1688 past the beginning of the current glyph matrix.
1689
1690 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1691
1692 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1693 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1694 HAVE_GTK3 (Bug#9869).
1695
1696 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1697 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1698
1699 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1700
1701 * xterm.c: Declare x_handle_net_wm_state to return int.
1702 (handle_one_xevent): Check if we are iconified but don't have
1703 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1704 (get_current_wm_state): Return non-zero if not hidden,
1705 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1706 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1707 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1708 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1709
1710 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1711
1712 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1713 so that this new function doesn't get optimized away by a
1714 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1715
1716 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1717
1718 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1719
1720 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1721
1722 Fix the `xbytecode' command.
1723 * .gdbinit (xprintbytestr): New command.
1724 (xwhichsymbols): Rename from `which'; all callers changed.
1725 (xbytecode): Print the byte-code string as well.
1726
1727 2011-10-29 Kim Storm <storm@cua.dk>
1728
1729 * alloc.c (which_symbols): New function.
1730
1731 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1732
1733 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1734 line. (Bug#9903)
1735
1736 2011-10-29 Glenn Morris <rgm@gnu.org>
1737
1738 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1739 Not clear what it was for, and it causes various bugs. (Bug#9839)
1740
1741 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1742
1743 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1744 possible random value that matches one of those tested as
1745 condition to clear the mouse face.
1746
1747 2011-10-28 Chong Yidong <cyd@gnu.org>
1748
1749 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1750
1751 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1752
1753 * window.c (make_window): Initialize phys_cursor_on_p.
1754
1755 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1756
1757 * lisp.h (struct Lisp_Symbol): Update comments.
1758
1759 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1760
1761 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1762
1763 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1764
1765 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1766 <oslsachem@gmail.com> for helping to debug this.
1767
1768 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1769 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1770 (g_b_init_get_glyph_outline_w): New static variables.
1771 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1772 (GetGlyphOutlineW_Proc): New typedefs.
1773 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1774 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1775 New functions.
1776 (w32font_open_internal, compute_metrics):
1777 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1778 instead of calling the "wide" APIs directly.
1779
1780 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1781
1782 * w32.h (syms_of_w32font): Add prototype.
1783
1784 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1785
1786 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1787 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1788 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1789 (Fmove_to_window_line): Doc fix.
1790
1791 2011-10-27 Chong Yidong <cyd@gnu.org>
1792
1793 * process.c (make_process): Set gnutls_state to NULL.
1794
1795 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1796 non-NULL, regardless of GNUTLS_INITSTAGE.
1797 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1798 an error. Set process slots as soon as we allocate them.
1799
1800 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1801
1802 2011-10-27 Chong Yidong <cyd@gnu.org>
1803
1804 * gnutls.c (emacs_gnutls_deinit): New function.
1805 Deallocate credentials structures as well as calling gnutls_deinit.
1806 (Fgnutls_deinit, Fgnutls_boot): Use it.
1807
1808 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1809 (deactivate_process): Call emacs_gnutls_deinit.
1810
1811 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1812
1813 * image.c (x_create_x_image_and_pixmap):
1814 * w32.c (sys_rename, w32_delayed_load):
1815 * w32font.c (fill_in_logfont):
1816 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1817
1818 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1819
1820 * w32fns.c (w32_default_color_map): New function,
1821 extracted from Fw32_default_color_map.
1822 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1823
1824 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1825
1826 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1827
1828 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1829
1830 * keyboard.c (test_undefined): New function (bug#9751).
1831 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1832
1833 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1834
1835 * sysdep.c (init_sys_modes): Fix the check for the controlling
1836 terminal (Bug#6649).
1837
1838 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1839
1840 * dispextern.h (struct bidi_it): New member next_en_type.
1841
1842 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1843 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1844 current character, check also for next_en_type being WEAK_EN.
1845 (bidi_resolve_weak): Don't enter the expensive loop if the current
1846 position is before next_en_pos. Record the bidi type of the first
1847 non-ET, non-BN character we find, in addition to its position.
1848 (bidi_level_of_next_char): Invalidate next_en_type when
1849 next_en_pos is over-stepped.
1850
1851 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1852
1853 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1854 * editfns.c: Rewrite current-time-zone so that it invokes
1855 the equivalent of (format-time-string "%Z") to get the time zone name.
1856 This fixes a bug when the time zone name contains characters that
1857 need converting from the system time locale to Emacs internal format.
1858 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1859 that patch fixed format-time-string to do the conversion, but
1860 I forgot to fix current-time-zone.
1861 (format_time_string): New function, containing most of
1862 what Fformat_time_string used to contain.
1863 (Fformat_time_string): Rewrite in terms of format_time_string.
1864 This doesn't change this function's behavior.
1865 (current-time-zone): Rewrite to use format_time_string.
1866 This fixes the bug reported by Michael Schierl in
1867 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1868 Jason Rumney's 2007-06-07 change worked around this bug, but
1869 didn't fix it.
1870 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1871
1872 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1873
1874 * xdisp.c (start_display): If the character at POS is displayed
1875 via a display vector, reset IT->current.dpvec_index to zero.
1876 (try_window_reusing_current_matrix): If a line ends in a display
1877 vector or the next line starts in a display vector, continue
1878 redrawing the window even though the character position of
1879 start_row was reached.
1880 (Bug#9771, part 2)
1881
1882 2011-10-18 Chong Yidong <cyd@gnu.org>
1883
1884 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1885 with nobreak-char-display too.
1886
1887 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1888
1889 Fix part 3 of bug#9771.
1890 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1891 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1892 non-neutral characters if the current character is a paragraph
1893 separator (a.k.a. Newline). This avoids running the same
1894 expensive loop twice, once when we consume the preceding newline
1895 and the other time when the line actually needs to be displayed.
1896 Avoid the loop when we see neutrals on the base embedding level
1897 following a character whose directionality is the same as the
1898 paragraph's. This avoids running the expensive loop when a line
1899 ends in a long sequence of neutrals, like control characters.
1900 Add assertion against STRONG_AL type. Slightly rearrange code
1901 that determines the type of a neutral given the first non-neutral
1902 that follows it.
1903 (bidi_level_of_next_char): Set next_en_pos to zero when
1904 invalidating its info.
1905
1906 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1907
1908 * xdisp.c (push_display_prop): Determine whether to record string
1909 or buffer position by IT->string, not by IT->method. Allow
1910 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1911 (move_it_vertically_backward): Don't look for character position
1912 immediately after the newline when in a continuation line.
1913 (Bug#9771, part 1)
1914
1915 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1916
1917 * window.c (coordinates_in_window): Rewrite and delabelize
1918 vertical border check. (Bug#5357) (Bug#9618)
1919
1920 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1921
1922 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1923 errors in XSetWindowBorder (bug#9310).
1924
1925 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1926
1927 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1928 avoid crash when xmalloc overrun checking is enabled.
1929
1930 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1931
1932 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1933 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1934 cursor motion with <left> and <right> arrow keys.
1935
1936 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1937 some callers set that themselves.
1938
1939 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1940
1941 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1942 display string and the previous row comes from the same string and
1943 is empty. (Bug#9739) (Bug#9738)
1944
1945 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1946
1947 * doc.c (get_doc_string): Encode file name (bug#9735).
1948
1949 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1950
1951 * bidi.c (bidi_level_of_next_char):
1952 * xdisp.c (get_visually_first_element): Remove old incorrect
1953 comments regarding the Unicode Line Separator character.
1954
1955 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1956
1957 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1958
1959 * alloc.c (Fgc_status): Do not access beyond zombies array
1960 boundary if nzombies > MAX_ZOMBIES.
1961 * alloc.c (dump_zombies): Add missing format specifier.
1962
1963 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1964
1965 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1966 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1967
1968 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1969 Some packages use them to denote characters with modifiers.
1970
1971 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1972
1973 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1974 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1975 matching a pp-number. Rename parameter var to var1.
1976
1977 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1978
1979 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1980
1981 2011-10-08 Glenn Morris <rgm@gnu.org>
1982
1983 * callint.c (Fcall_interactively): Give a more explicit error for the
1984 'c' case with a non-character input. (Bug#8479)
1985
1986 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1987
1988 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1989 lines.
1990 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1991 lines that are hscrolled on the left.
1992
1993 * dispnew.c (buffer_posn_from_coords): Account for a possible
1994 presence of header-line. (Bug#4426)
1995
1996 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1997
1998 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1999 Don't advertise functionality which we discourage or doesn't work.
2000
2001 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2002
2003 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2004 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2005 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2006 this makes Emacs dump core during garbage collection on rare
2007 occasions. sizeof is obviously inferior to offsetof here, so
2008 stick with offsetof.
2009 (GC_POINTER_ALIGNMENT): New macro.
2010 (mark_memory): Omit 3rd (offset) arg; caller changed.
2011 Don't assume EMACS_INT alignment is the same as pointer alignment.
2012
2013 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2014
2015 * keyboard.c (read_key_sequence_remapped): New var.
2016 (read_key_sequence): Compute remapping in the right buffer.
2017 (command_loop_1): Use read_key_sequence's remapping directly.
2018
2019 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2020
2021 * dired.c (file_name_completion): Don't expand file name.
2022 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2023 before checking file name handler.
2024
2025 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2026 they've been requested explicitly (bug#9591).
2027
2028 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2029
2030 * keymap.c (Fsingle_key_description): Use make_specified_string
2031 instead of build_string to build string from push_key_description.
2032 (Bug#5193)
2033
2034 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2035
2036 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2037 This fixes a Y2038 bug on 64-bit hosts.
2038 * buffer.c (reset_buffer):
2039 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2040 (Fclear_buffer_auto_save_failure):
2041 Use 0, not -1, to represent an unset failure time, since time_t
2042 might not be signed.
2043
2044 Remove dependency on glibc malloc internals.
2045 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2046 Move back here from lisp.h, but with their new implementations.
2047 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2048 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2049 * charset.c (charset_table_init): New static var.
2050 (syms_of_charset): Use it instead of xmalloc. This removes a
2051 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2052 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2053 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2054 Move back to alloc.c.
2055 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2056 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2057
2058 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2059
2060 * nsterm.m (windowDidResize): Call x_set_window_size only when
2061 ns_in_resize is true. Otherwise set pixelwidth/height and
2062 call change_frame_size (Bug#9628).
2063
2064 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2065
2066 Port --enable-checking=all to Fedora 14 x86-64.
2067 * charset.c (syms_of_charset): Also account for glibc malloc's
2068 internal overhead when calculating the initial malloc maximum.
2069
2070 Port --enable-checking=all to Fedora 14 x86.
2071 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2072 Move to lisp.h.
2073 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2074 (overrun_check_realloc, overrun_check_free):
2075 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2076 That way, xmalloc returns a properly-aligned pointer even if
2077 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2078 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2079 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2080 into account when calculating the initial malloc maximum.
2081 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2082 Move here from alloc.c, so that charset.c can use it too.
2083 Properly align; the old code wasn't right for common 32-bit hosts
2084 when configured with --enable-checking=all.
2085 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2086 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2087
2088 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2089
2090 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2091 use EDOM.
2092
2093 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2094
2095 * xdisp.c (compute_display_string_end): If there's no display
2096 string at CHARPOS, return -1.
2097
2098 * bidi.c (bidi_fetch_char): When compute_display_string_end
2099 returns a negative value, treat the character as a normal
2100 character not covered by a display string. (Bug#9624)
2101
2102 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2103
2104 * lread.c (Fread_from_string): Fix typo in docstring.
2105
2106 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2107
2108 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2109 newline, reseat the iterator instead of bidi-iterating there one
2110 character at a time. (Bug#9610)
2111 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2112 TO_CHARPOS if the bidi iterator is at base embedding level.
2113
2114 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2115
2116 * lread.c (readevalloop): Use correct code for NBSP.
2117 (read1): Likewise. (Bug#9608)
2118
2119 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2120
2121 * dbusbind.c (Fdbus_register_signal): When service is not
2122 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2123
2124 2011-09-25 Glenn Morris <rgm@gnu.org>
2125
2126 * buffer.c (truncate-lines): Doc fix.
2127
2128 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2129
2130 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2131 (Fset_window_next_buffers): Doc fix.
2132
2133 2011-09-24 Glenn Morris <rgm@gnu.org>
2134
2135 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2136
2137 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2138
2139 Fix minor problems found by static checking.
2140 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2141 * indent.c (Fvertical_motion): Fix == vs = typo.
2142
2143 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2144
2145 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2146 Default value is now t. Doc fix.
2147
2148 * indent.c (Fvertical_motion): Compute and apply the overshoot
2149 logic when moving up, not only when moving down. Fix the
2150 confusing name and values of the it_overshoot_expected variable;
2151 logic changes accordingly. (Bug#9254) (Bug#9549)
2152
2153 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2154 CHARPOS is covered by a display string which includes newlines.
2155 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2156 is covered by a display string with embedded newlines.
2157
2158 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2159
2160 * dbusbind.c (Fdbus_register_signal): Add match rule to
2161 Vdbus_registered_objects_table. (Bug#9581)
2162 (Fdbus_register_method, Vdbus_registered_objects_table):
2163 Fix docstring.
2164
2165 2011-09-24 Jim Meyering <meyering@redhat.com>
2166
2167 do not ignore write error for any output size
2168 The previous change was incomplete.
2169 While it makes emacs --batch detect the vast majority of stdout
2170 write failures, errors were still ignored whenever the output size is
2171 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2172 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2173 && echo FAIL: ignored write error
2174 FAIL: ignored write error
2175 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2176 && echo FAIL: ignored write error
2177 FAIL: ignored write error
2178 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2179
2180 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2181
2182 * emacs.c (Fkill_emacs): In noninteractive mode exit
2183 non-successfully if a write error occurred on stdout. (Bug#9574)
2184
2185 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2186
2187 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2188 the xassert test.
2189
2190 * dispextern.h (struct it): Update the comment documenting what
2191 can it->OBJECT be.
2192
2193 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2194
2195 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2196 a display string, extend search for cursor position to end of row.
2197 (find_row_edges): If the row ends in a newline from a display
2198 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2199 Handle the case of a display string with multiple newlines.
2200 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2201 non-empty line. Fixes confusing cursor motion with arrow keys at
2202 the beginning of a line that starts with whitespace.
2203
2204 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2205
2206 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2207 (bug#9493).
2208
2209 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2210
2211 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2212 boolean (Bug#9154).
2213
2214 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2215
2216 * xdisp.c (display_line): Record maximum and minimum buffer
2217 positions even if no glyphs were produced (e.g., by a zero-width
2218 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2219 buffer positions that will be removed from the glyph row because
2220 they don't fit.
2221 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2222 column is beyond frame width: don't subtract 1 "pixel" when
2223 computing width of the stretch.
2224 (reseat_at_next_visible_line_start): Undo the change made on
2225 2011-09-17 that saved paragraph information and restored it after
2226 the call to `reseat'. (Bug#9545)
2227
2228 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2229
2230 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2231 and turn window cursor on if cleared (Bug#9415).
2232
2233 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2234
2235 * search.c (boyer_moore): Take unibyte characters from pattern
2236 literally. (Bug#9458)
2237
2238 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2239
2240 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2241
2242 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2243
2244 Fix minor problem found by static checking.
2245 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2246 initialized, to pacify gcc -Wuninitialized.
2247
2248 * fileio.c: Report proper errno when syscall falls.
2249 (Finsert_file_contents): Save and restore errno,
2250 so that report_file_error outputs the correct diagnostic.
2251 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2252
2253 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2254
2255 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2256
2257 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2258
2259 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2260 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2261
2262 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2263
2264 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2265 about the current paragraph and restore it after the call to reseat.
2266
2267 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2268 (bidi_find_paragraph_start): Search back for paragraph beginning
2269 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2270 (bidi_move_to_visually_next): Only trigger paragraph-related
2271 computations when the last character is a newline or at EOB, not
2272 just any NEUTRAL_B. (Bug#9470)
2273
2274 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2275 truncated lines if point is covered by a display string. (Bug#9524)
2276
2277 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2278
2279 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2280 (cons_to_x_long): New function.
2281 (lisp_data_to_selection_data): Use it. Correct the test for
2282 short-versus-long data; it was negated. Break out of vector
2283 loop, for efficiency, when a long datum is discovered.
2284
2285 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2286
2287 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2288
2289 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2290
2291 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2292 GCC PR/17406) by declaring this function with external scope.
2293
2294 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2295
2296 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2297 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2298
2299 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2300
2301 * editfns.c (Fformat): Correctly handle text properties on "%%".
2302
2303 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2304
2305 * xterm.c (x_draw_composite_glyph_string_foreground):
2306 * w32term.c (x_draw_composite_glyph_string_foreground):
2307 * term.c (encode_terminal_code):
2308 * composite.c (composition_update_it, get_composition_id):
2309 * xdisp.c (get_next_display_element)
2310 (fill_composite_glyph_string): Add comments about special meaning
2311 of TAB characters in a composition.
2312
2313 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2314
2315 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2316 This occurs when processing a multibyte format.
2317 Problem reported by Wolfgang Jenker.
2318
2319 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2320
2321 * xdisp.c (try_cursor_movement): Only check for exact match if
2322 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2323
2324 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2325
2326 Remove unused external symbols.
2327 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2328 * xdisp.c (calc_pixel_width_or_height): Now static.
2329 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2330 * indent.c (check_display_width):
2331 * w32term.c: Fix comment to match code.
2332 * xterm.c, xterm.h (x_catching_errors): Remove.
2333
2334 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2335
2336 * xselect.c: Use signed conversions more consistently (Bug#9498).
2337 (selection_data_to_lisp_data): Assume incoming selection data are
2338 signed integers, not unsigned. This is to be consistent with
2339 outgoing selection data, which was modified to use signed integers
2340 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2341 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2342 expects long, not unsigned long.
2343
2344 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2345
2346 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2347 computation of loop end. Reported by Johan Bockgård
2348 <bojohan@gnu.org>.
2349
2350 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2351
2352 * frame.c (Fother_visible_frames_p): Function deleted.
2353
2354 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2355
2356 * indent.c (compute_motion): Process display vector front to back
2357 rather than the other way around. (Bug#2496)
2358
2359 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2360
2361 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2362
2363 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2364
2365 * minibuf.c (Fread_from_minibuffer): Doc fix.
2366
2367 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2368
2369 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2370 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2371
2372 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2373
2374 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2375 value for non-existent files.
2376
2377 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2378
2379 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2380 set its "size" to -1. This will set the modtime_size field of
2381 the corresponding buffer to -1, which is what
2382 verify-visited-file-modtime expects for files that do not exist.
2383 (Bug#9139)
2384
2385 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2386
2387 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2388 here ...
2389 * lisp.h: ... from here. push_key_description is no longer
2390 defined in keyboard.c, so its declaration should not be in
2391 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2392 logically belongs with push_key_description.
2393
2394 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2395
2396 * buffer.h: Include <sys/types.h> instead of <time.h>.
2397 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2398 Problem reported by Herbert J. Skuhra.
2399
2400 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2401
2402 * xml.c (parse_region): Make the parsing work for
2403 non-comment-starting XML files again (bug#9144).
2404
2405 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2406
2407 * image.c (gif_load): Fix calculation of bottom and right corner.
2408 (Bug#9468)
2409
2410 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2411
2412 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2413 redisplay in small windows.
2414
2415 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2416
2417 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2418
2419 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2420
2421 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2422 Operate on live windows only.
2423
2424 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2425
2426 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2427
2428 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2429
2430 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2431 only under bidi iteration.
2432
2433 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2434
2435 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2436
2437 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2438
2439 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2440 Without this fix, the command to link temacs failed due to an
2441 undefined symbol __builtin_isnan. This is because
2442 /usr/include/iso/math_c99.h #defines isnan(x) to
2443 __builtin_isnan(x), but the bundled gcc, which identifies itself
2444 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2445 a __builtin_isnan.
2446 * floatfns.c (isnan): #undef, and then #define to a clone of
2447 what's in data.c.
2448 (Fisnan): Always define, since it's always available now.
2449 (syms_of_floatfns): Always define isnan at the Lisp level.
2450
2451 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2452
2453 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2454
2455 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2456
2457 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2458 The previous code assumed that file offsets (off_t values) fit in
2459 EMACS_INT variables, which is not true on typical 32-bit hosts.
2460 The code messed up by falsely reporting buffer overflow in cases
2461 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2462 when "big" contains more than 2**29 bytes, even though this
2463 inserts just one byte and does not overflow the buffer.
2464 (Finsert_file_contents): Store file offsets as off_t
2465 values, not as EMACS_INT values. Check for overflow when
2466 converting between EMACS_INT and off_t. When checking for
2467 buffer overflow or for overlap, take the offsets into account.
2468 Don't use EMACS_INT for small values where int suffices.
2469 When checking for overlap, fix a typo: ZV was used where
2470 ZV_BYTE was intended.
2471 (Fwrite_region): Don't assume off_t fits into 'long'.
2472 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2473
2474 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2475
2476 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2477
2478 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2479
2480 sprintf-related integer and memory overflow issues (Bug#9412).
2481
2482 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2483 (esprintf, exprintf, evxprintf): New functions.
2484 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2485 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2486 (modify_event_symbol): Do not assume that the length of
2487 name_alist_or_stem is safe to alloca and fits in int.
2488 (Fexecute_extended_command): Likewise for function name and binding.
2489 (Frecursion_depth): Wrap around reliably on integer overflow.
2490 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2491 since some callers pass EMACS_INT values.
2492 (Fsingle_key_description): Don't crash if symbol name contains more
2493 than MAX_ALLOCA bytes.
2494 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2495 (get_minibuffer): Arg is now EMACS_INT, not int.
2496 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2497 (esprintf, exprintf, evxprintf): New decls.
2498 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2499
2500 * dbusbind.c (signature_cat): New function.
2501 (xd_signature, Fdbus_register_signal):
2502 Do not overrun buffer; instead, report string overflow.
2503
2504 * dispnew.c (add_window_display_history): Don't overrun buffer.
2505 Truncate instead; this is OK since it's just a log.
2506
2507 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2508 even if the time zone offset is outlandishly large.
2509 Don't mishandle offset == INT_MIN.
2510
2511 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2512 when creating daemon; the previous buffer-overflow check was incorrect.
2513
2514 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2515 which has the guts of the old verror function.
2516
2517 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2518 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2519
2520 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2521 (font_unparse_xlfd): Don't blindly alloca long strings.
2522 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2523 fits in int, when using sprintf. Use single snprintf to count
2524 length of string rather than counting it via multiple sprintfs;
2525 that's simpler and more reliable.
2526 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2527 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2528 sprintf, in case result does not fit in int.
2529
2530 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2531 (fontset_from_font): Print it.
2532
2533 * frame.c (tty_frame_count): Now printmax_t, not int.
2534 (make_terminal_frame, set_term_frame_name): Print it.
2535 (x_report_frame_params): In X, window IDs are unsigned long,
2536 not signed long, so print them as unsigned.
2537 (validate_x_resource_name): Check for implausibly long names,
2538 and don't assume name length fits in 'int'.
2539 (x_get_resource_string): Don't blindly alloca invocation name;
2540 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2541 not fit in int.
2542
2543 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2544 (xg_check_special_colors, xg_set_geometry):
2545 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2546
2547 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2548 Use esprintf, not sprintf, in case result does not fit in int.
2549
2550 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2551 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2552 it as a large positive number.
2553 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2554 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2555
2556 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2557 in case result does not fit in int.
2558
2559 * print.c (float_to_string): Detect width overflow more reliably.
2560 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2561 buffer overrun. Don't assume list length fits in 'int'. Treat
2562 print length of 0 as 0, not as infinity; to be consistent with other
2563 uses of print length in this function. Don't overflow print length
2564 index. Don't assume hash table size fits in 'long', or that
2565 vectorlike size fits in 'unsigned long'.
2566
2567 * process.c (make_process): Use printmax_t, not int, to format
2568 process-name gensyms.
2569
2570 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2571
2572 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2573 to avoid potential buffer overrun.
2574
2575 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2576 if X resource line is longer than 512 bytes.
2577
2578 * xfns.c (x_window): Make sprintf buffer a bit bigger
2579 to avoid potential buffer overrun.
2580
2581 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2582
2583 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2584
2585 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2586
2587 Integer overflow fixes for scrolling, etc.
2588 Without these, Emacs silently mishandles large integers sometimes.
2589 For example, "C-u 4294967297 M-x recenter" was treated as if
2590 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2591
2592 * xdisp.c (try_window_id): Check Emacs fixnum range before
2593 converting to 'int'.
2594
2595 * window.c (window_scroll_line_based, Frecenter):
2596 Check that an Emacs fixnum is in range before assigning it to 'int'.
2597 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2598 values converted from Emacs fixnums.
2599 (Frecenter): Don't wrap around a line count if it is out of 'int'
2600 range; instead, treat it as an extreme value.
2601 (Fset_window_configuration, compare_window_configurations):
2602 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2603
2604 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2605 that can exceed INT_MAX. Check that EMACS_INT value is in range
2606 before assigning it to the (possibly-narrower) index.
2607 (match_limit): Don't assume that a fixnum can fit in 'int'.
2608
2609 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2610 exceed INT_MAX.
2611
2612 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2613 (Fvertical_motion): Don't wrap around LINES values that don't fit
2614 in 'int'. Instead, treat them as extreme values. This is good
2615 enough for windows, which can't have more than INT_MAX lines anyway.
2616
2617 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2618
2619 * Require libxml/parser.h to avoid compilation warning.
2620
2621 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2622
2623 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2624 since this reportedly can destroy thread storage.
2625
2626 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2627
2628 * syntax.c (find_defun_start): Update all cache variables if
2629 exiting early (Bug#9401).
2630
2631 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2632
2633 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2634
2635 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2636 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2637 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2638
2639 * term.c (tty_append_glyph): New function.
2640 (produce_stretch_glyph): Static function and its prototype deleted.
2641
2642 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2643 Add prototypes.
2644
2645 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2646
2647 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2648 when checking :margin (Bug#9390).
2649 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2650 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2651 so that the name doesn't mislead. All uses changed.
2652
2653 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2654
2655 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2656 set_tty_hooks.
2657
2658 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2659
2660 * xdisp.c (move_it_to): Don't bail out early when reaching
2661 position beyond to_charpos, if we are scanning backwards.
2662 (move_it_vertically_backward): When DY == 0, make sure we get to
2663 the first character in the line after the newline.
2664
2665 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2666
2667 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2668 (ccl_driver): Do not generate an out-of-range pointer.
2669 (Fccl_execute_on_string): Remove unnecessary check for
2670 integer overflow, noted by Stefan Monnier in
2671 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2672 Remove a FIXME that didn't need fixing.
2673 Simplify the newly-introduced buffer reallocation code.
2674
2675 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2676
2677 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2678
2679 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2680
2681 Integer and memory overflow issues (Bug#9196).
2682
2683 * doc.c (get_doc_string): Rework so that
2684 get_doc_string_buffer_size is the actual buffer size, rather than
2685 being 1 less than the actual buffer size; this makes xpalloc more
2686 convenient.
2687
2688 * image.c (x_allocate_bitmap_record, cache_image):
2689 * xselect.c (Fx_register_dnd_atom):
2690 Simplify previous changes by using xpalloc.
2691
2692 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2693 since either will do and ptrdiff_t is convenient with xpalloc.
2694
2695 * charset.c (charset_table_size)
2696 (struct charset_sort_data.priority): Now ptrdiff_t.
2697 (charset_compare): Don't overflow if priorities differ greatly.
2698 (Fsort_charsets): Don't assume list length fits in int.
2699 Check for size-calculation overflow when allocating sort data.
2700 (syms_of_charset): Allocate an initial charset table that is
2701 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2702
2703 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2704
2705 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2706 The actual value is always <= INT_MAX, and leaving it unsigned made
2707 overflow checking harder.
2708
2709 * dispextern.h (struct glyph_matrix.rows_allocated)
2710 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2711 with xpalloc. The values are still always <= INT_MAX.
2712
2713 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2714
2715 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2716 (SAFE_NALLOCA): New macro.
2717
2718 * region-cache.c (struct boundary.pos, find_cache_boundary)
2719 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2720 (set_cache_region, invalidate_region_cache)
2721 (revalidate_region_cache, know_region_cache, region_cache_forward)
2722 (region_cache_backward, pp_cache):
2723 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2724 so that ptrdiff_t * can be passed to xpalloc.
2725 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2726 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2727 (pp_cache): Don't assume cache_len fits in int.
2728 * region-cache.h: Adjust extern decls to match.
2729
2730 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2731 EMACS_INT, since either will do, for xpalloc.
2732
2733 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2734 (xnmalloc, xnrealloc, xpalloc): New functions.
2735
2736 * bidi.c (bidi_shelve_header_size): New constant.
2737 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2738 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2739
2740 * bidi.c (bidi_cache_shrink):
2741 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2742 (overlay_strings):
2743 Don't update size of array until after memory allocation succeeds,
2744 because xmalloc/xrealloc may not return.
2745 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2746 now that we have proper integer overflow checking.
2747 (record_overlay_string, overlay_strings): Catch overflows when
2748 calculating size of overlay_str_buf.
2749
2750 * callproc.c (Fcall_process): Check for size overflow when
2751 calculating size of args2.
2752 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2753 Normally we prefer signed values, but sticking with ptrdiff_t would
2754 require adding more-complicated checks.
2755
2756 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2757 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2758 Redo buffer-overflow calculations to avoid integer overflow.
2759 Add a FIXME comment where memory seems to be over-allocated.
2760
2761 * character.c (Fstring): Check for size-calculation overflow.
2762
2763 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2764 unnecessary integer overflow. Check for size overflow.
2765 (encode_coding_object): Don't update size until xmalloc succeeds.
2766
2767 * composite.c (get_composition_id): Check for overflow in glyph
2768 length calculations.
2769
2770 Integer and memory overflow fixes for display code.
2771 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2772 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2773 (scrolling_window): Check for overflow in size calculations.
2774 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2775 Don't assume glyph table len fits in int.
2776 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2777 (row_table_size): Now ptrdiff_t, not int.
2778 (scrolling_window): Avoid overflow in size calculations.
2779 Don't update size until allocation succeeds.
2780 * fns.c (concat): Check for overflow in size calculations.
2781 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2782 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2783 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2784
2785 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2786 (get_doc_string): Check for size calculation overflow.
2787 Don't update size until allocation succeeds.
2788 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2789 EMACS_INT, where ptrdiff_t will do.
2790 (Fsubstitute_command_keys): Check for string overflow.
2791
2792 * editfns.c (set_time_zone_rule): Don't assume environment length
2793 fits in int.
2794 (message_length): Now ptrdiff_t, not int.
2795 (Fmessage_box): Don't update size until allocation succeeds.
2796 Don't assume message length fits in int.
2797 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2798
2799 * emacs.c (main): Do not reallocate argv, since there is a null at
2800 the end that can be overwritten, and this way there's no need to
2801 worry about size-calculation overflow.
2802 (sort_args): Check for size-calculation overflow.
2803
2804 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2805 alloc succeeds.
2806 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2807
2808 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2809 (x_set_scroll_bar_width, x_figure_window_size):
2810 Check for integer overflow.
2811 (x_set_alpha): Do not assume XINT fits in int.
2812
2813 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2814 This is for the members text_lines, text_cols, total_lines, total_cols,
2815 where the system imposes an 'int' limit.
2816
2817 * fringe.c (Fdefine_fringe_bitmap):
2818 Don't update size until alloc works.
2819
2820 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2821 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2822
2823 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2824 Check for size-calculation overflow.
2825 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2826 do, as we prefer signed integers.
2827 (id_to_widget.max_size, id_to_widget.used)
2828 (xg_store_widget_in_map, xg_remove_widget_from_map)
2829 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2830 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2831 Use and return ptrdiff_t, not int.
2832 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2833 * gtkutil.h: Change prototypes to match the above.
2834
2835 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2836 are duplicate now that they've been promoted to lisp.h.
2837 (x_allocate_bitmap_record, x_alloc_image_color)
2838 (make_image_cache, cache_image, xpm_load):
2839 Don't update size until alloc is done.
2840 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2841 (x_detect_edges):
2842 Check for size calculation overflow.
2843 (ct_colors_allocated_max): New constant.
2844 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2845 overflow.
2846
2847 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2848 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2849 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2850 Use ptrdiff_t, not int, to count maps.
2851 (read_char_minibuf_menu_prompt): Check for overflow in size
2852 calculations. Don't update size until allocation succeeds.
2853 Redo calculations to avoid overflow.
2854 * keyboard.h: Change prototypes to match the above.
2855
2856 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2857 to count maps.
2858 (current_minor_maps): Check for size calculation overflow.
2859 * keymap.h: Change prototypes to match the above.
2860
2861 * lread.c (read1, init_obarray): Don't update size until alloc done.
2862
2863 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2864 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2865
2866 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2867 Now ptrdiff_t, not int.
2868 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2869 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2870
2871 * process.c (Fnetwork_interface_list): Check for overflow
2872 in size calculation.
2873
2874 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2875
2876 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2877 overflow. Don't bother calling xmalloc when xrealloc will do.
2878
2879 * search.c (Freplace_match): Check for size calculation overflow.
2880 (Fset_match_data): Don't assume list lengths fit in 'int'.
2881
2882 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2883 for command line length. Do not attempt to address one before the
2884 beginning of an array, as that's not portable.
2885
2886 * term.c (max_frame_lines): Remove; unused.
2887 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2888 not int.
2889 (encode_terminal_code, calculate_costs): Check for size
2890 calculation overflow.
2891 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2892 table lengths and related sizes. Don't update size until alloc
2893 done. Redo calculations to avoid overflow.
2894 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2895
2896 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2897 subtracting pointers.
2898 (gobble_line): Check for overflow more carefully. Don't update size
2899 until alloc done.
2900
2901 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2902 Don't update size until alloc done.
2903 Redo size calculations to avoid overflow.
2904 Check for size calculation overflow.
2905 (main) [DEBUG]: Fix typo in invoking tparam1.
2906
2907 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2908 Use ptrdiff_t, not int, for sizes.
2909 (store_mode_line_noprop_char): Don't update size until alloc done.
2910
2911 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2912 Use ptrdiff_t, not int, for sizes.
2913 (Finternal_make_lisp_face, cache_face):
2914 Check for size calculation overflow.
2915 (cache_face): Treat size calculation overflows as if they were
2916 memory exhaustion (the usual treatment), rather than aborting.
2917
2918 * xfns.c (x_encode_text, x_set_name_internal)
2919 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2920 sizes, since they can exceed INT_MAX in size. Check for size
2921 calculation overflow.
2922
2923 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2924 (xg_select): Check for size calculation overflow.
2925 Don't update size until alloc done.
2926
2927 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2928 as sprintf is limited to int lengths.
2929
2930 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2931 (X_LONG_MIN): New macros.
2932 Use them to make the following changes clearer.
2933 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2934 This change doesn't affect the value now, but it may help remind
2935 future maintainers not to raise the value too much later.
2936 (SELECTION_QUANTUM): Remove, replacing with ...
2937 (selection_quantum): ... new function, which avoids overflow.
2938 All uses changed.
2939 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2940 assumption that selection length fits in 'int'.
2941 (x_reply_selection_request, x_handle_selection_request)
2942 (x_get_window_property, receive_incremental_selection)
2943 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2944 (lisp_data_to_selection_data, clean_local_selection_data):
2945 Use ptrdiff_t, not int, to record length of selection.
2946 (x_reply_selection_request, x_get_window_property)
2947 (receive_incremental_selection, x_property_data_to_lisp):
2948 Redo calculations to avoid overflow.
2949 (x_reply_selection_request): When sending hint, ceiling it at
2950 X_LONG_MAX rather than relying on wraparound overflow to send
2951 something.
2952 (x_get_window_property, receive_incremental_selection)
2953 (lisp_data_to_selection_data, x_property_data_to_lisp):
2954 Check for size-calculation overflow.
2955 (x_get_window_property, receive_incremental_selection)
2956 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2957 Don't store size until memory allocation succeeds.
2958 (x_get_window_property): Plug memory leak on memory exhaustion.
2959 Don't double-block input; malloc is safe here. Don't assume 2**34
2960 - 4 fits in unsigned long. Add an xassert to check
2961 XGetWindowProperty overflow. Be more careful about overflow
2962 calculations, and distinguish size from memory overflow better.
2963 (receive_incremental_selection): When tracing, don't assume
2964 unsigned int is less than INT_MAX.
2965 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2966 harmful) conversions of unsigned short to int.
2967 (lisp_data_to_selection_data): Don't assume that integers
2968 in the range -65535 through -1 fit in an X unsigned short.
2969 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2970 result parameters unless successful. Rely on cons_to_unsigned
2971 to report problems with elements; the old code wasn't right anyway.
2972 (x_check_property_data): Check for int overflow; we cannot use
2973 a wider type due to X limits.
2974 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2975
2976 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2977
2978 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2979 (x_term_init): Check for size calculation overflow.
2980 (x_color_cells): Don't store size until memory allocation succeeds.
2981 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2982 Don't assume alloca size is less than MAX_ALLOCA.
2983 (x_term_init): Don't assume length fits in int (sprintf is limited
2984 to int size).
2985
2986 Use ptrdiff_t for composition IDs.
2987 * character.c (lisp_string_width):
2988 * composite.c (composition_table_size, n_compositions)
2989 (get_composition_id, composition_gstring_from_id):
2990 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2991 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2992 * window.c (Frecenter):
2993 Use ptrdiff_t, not int, for composition IDs.
2994 * composite.c (get_composition_id): Check for integer overflow.
2995 * composite.h: Adjust prototypes to match the above changes.
2996
2997 Use ptrdiff_t for hash table indexes.
2998 * category.c (hash_get_category_set):
2999 * ccl.c (ccl_driver):
3000 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3001 * coding.c (coding_system_charset_list, detect_coding_system):
3002 * coding.h (struct coding_system.id):
3003 * composite.c (get_composition_id, gstring_lookup_cache):
3004 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3005 * image.c (xpm_get_color_table_h):
3006 * lisp.h (hash_lookup, hash_put):
3007 * minibuf.c (Ftest_completion):
3008 Use ptrdiff_t for hash table indexes, not int (which is too
3009 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3010 32-bit --with-wide-int hosts).
3011
3012 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3013 Add a FIXME comment about memory leaks.
3014 (syms_of_charset): Don't assume xmalloc returns.
3015
3016 Don't assume that stated character widths fit in int.
3017 * character.c (Fchar_width, c_string_width, lisp_string_width):
3018 * character.h (CHAR_WIDTH):
3019 * indent.c (MULTIBYTE_BYTES_WIDTH):
3020 Use sanitize_char_width to avoid undefined and/or bad behavior
3021 with outlandish widths.
3022 * character.h (sanitize_tab_width): Rename from sanitize_width,
3023 now that we have two such functions. All uses changed.
3024 (sanitize_char_width): New inline function.
3025
3026 Don't assume that tab-width fits in int.
3027 * character.h (sanitize_width): New inline function.
3028 (SANE_TAB_WIDTH): New macro.
3029 (ASCII_CHAR_WIDTH): Use it.
3030 * indent.c (sane_tab_width): Remove. All uses replaced by
3031 SANE_TAB_WIDTH (current_buffer).
3032 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3033
3034 * fileio.c: Integer overflow issues with file modes.
3035 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3036
3037 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3038 Remove unreachable code.
3039 (read_hex, load_charset_map_from_file): Check for integer overflow.
3040
3041 * xterm.c: Don't go over XClientMessageEvent limit.
3042 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3043 (x_send_scroll_bar_event): Likewise. Check that the size does not
3044 exceed limits imposed by XClientMessageEvent, as well as the usual
3045 ptrdiff_t and size_t limits.
3046
3047 * keyboard.c: Overflow, signedness and related fixes.
3048 (make_lispy_movement): Use same integer type in forward decl
3049 that is used in the definition.
3050 (read_key_sequence, keyremap_step):
3051 Change bufsize argument back to int, undoing my 2011-03-30 change.
3052 We prefer signed types, and int is wide enough here.
3053 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3054 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3055 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3056 length, not size_t. Use ptrdiff_t for index, not int.
3057 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3058 possibility of integer overflow.
3059
3060 Overflow, signedness and related fixes for images.
3061
3062 * dispextern.h (struct it.stack[0].u.image.image_id)
3063 (struct_it.image_id, struct image.id, struct image_cache.size)
3064 (struct image_cache.used, struct image_cache.ref_count):
3065 * gtkutil.c (update_frame_tool_bar):
3066 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3067 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3068 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3069 * nsmenu.m (update_frame_tool_bar):
3070 * xdisp.c (calc_pixel_width_or_height):
3071 * xfns.c (image_cache_refcount):
3072 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3073 on typical 64-bit hosts.
3074
3075 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3076 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3077 Omit unnecessary casts to int.
3078 (parse_image_spec): Check that integers fall into 'int' range
3079 when the callers expect that.
3080 (image_ascent): Redo ascent calculation to avoid int overflow.
3081 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3082 (lookup_image): Remove unnecessary tests.
3083 (xbm_image_p): Locals are now of int, not EMACS_INT,
3084 since parse_image_check makes sure they fit into int.
3085 (png_load, gif_load, svg_load_image):
3086 Prefer int to unsigned where either will do.
3087 (tiff_handler): New function, combining the cores of the
3088 old tiff_error_handler and tiff_warning_handler.
3089 This function is rewritten to use vsnprintf and thereby avoid
3090 stack buffer overflows. It uses only the features of vsnprintf
3091 that are common to both POSIX and native Microsoft.
3092 (tiff_error_handler, tiff_warning_handler): Use it.
3093 (tiff_load, gif_load, imagemagick_load_image):
3094 Don't assume :index value fits in 'int'.
3095 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3096 (imagemagick_load_image): Check that crop parameters fit into
3097 the integer types that MagickCropImage accepts. Don't assume
3098 Vimagemagick_render_type has a nonnegative value. Don't assume
3099 size_t fits in 'long'.
3100 (gs_load): Use printmax_t to print the widest integers possible.
3101 Check for integer overflow when computing image height and width.
3102
3103 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3104
3105 * xdisp.c (redisplay_window): Don't force window start if point
3106 will be invisible in the resulting window. (Bug#9324)
3107
3108 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3109
3110 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3111 the display spec is of the form `(space ...)'.
3112 (handle_display_spec): Return the value returned by
3113 handle_single_display_spec, not just 1 or zero.
3114 (handle_single_display_spec): If the display spec is of the form
3115 `(space ...)', and specifies display in the text area, return 2
3116 rather than 1.
3117 (try_cursor_movement): Check for the need to scroll more
3118 accurately, and prefer exact match for point under bidi.
3119 Don't advance `row' beyond the last row of the window.
3120
3121 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3122 into disp_prop; all users changed.
3123
3124 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3125 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3126 for the text covered by the display property.
3127
3128 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3129
3130 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3131 Change return value to nil.
3132 (Frecord_buffer): Delete unused function.
3133
3134 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3135
3136 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3137 buffers, return left-to-right.
3138 (set_cursor_from_row): Consider candidate row a win if its glyph
3139 represents a newline and point is on that newline. Fixes cursor
3140 positioning on the newline at EOL of R2L text within L2R
3141 paragraph, and vice versa.
3142 (try_cursor_movement): Check continued rows, in addition to
3143 continuation rows. Fixes unwarranted scroll when point enters a
3144 continued line of R2L text within an L2R paragraph, or vice versa.
3145 (cursor_row_p): Consider the case of point being equal to
3146 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3147 from the end of a short line to the beginning of a continued line
3148 of R2L text within L2R paragraph.
3149 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3150 composed characters.
3151
3152 * bidi.c (bidi_check_type): Use xassert.
3153 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3154 members.
3155
3156 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3157
3158 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3159 a character.
3160
3161 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3162
3163 * nsfont.m (ns_otf_to_script): Fix typo.
3164
3165 2011-08-22 Kenichi Handa <handa@m17n.org>
3166
3167 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3168 extra slot even if the purpose is char-code-property-table.
3169
3170 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3171
3172 * xdisp.c (redisplay_window): When computing centering_position,
3173 account for the height of the header line. (Bug#8874)
3174
3175 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3176 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3177 candidate is selected by the mouse, and that candidate has a
3178 composed character under the mouse.
3179
3180 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3181 coordinates reported by pos-visible-in-window-p for a composed
3182 character in column zero.
3183
3184 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3185
3186 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3187
3188 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3189
3190 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3191 consider it a hit if to_charpos is anywhere in the range of the
3192 composed buffer positions.
3193
3194 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3195
3196 * image.c (gif_load): Don't assume that each subimage has the same
3197 dimensions as the base image. Handle disposal method that is
3198 "undefined" by the gif spec (Bug#9335).
3199
3200 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3201
3202 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3203 (Fcondition_case): Document `debug' symbol in error handler.
3204
3205 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3206
3207 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3208 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3209 from an Org mode buffer to a Speedbar frame.
3210
3211 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3212 a composition, take its buffer position from IT->cmp_it.charpos.
3213 Fixes cursor positioning at the beginning of a line that begins
3214 with a composed character.
3215
3216 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3217
3218 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3219 character bidirectional type, use STRONG_L instead. Fixes crashes
3220 in a buffer produced by `describe-categories'.
3221
3222 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3223 members before the level stack, so they would be saved and
3224 restored when copying iterator state. Fixes incorrect reordering
3225 around TABs covered by display properties.
3226
3227 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3228
3229 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3230
3231 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3232
3233 * eval.c (internal_condition_case, internal_condition_case_1)
3234 (internal_condition_case_2, internal_condition_case_n):
3235 Remove unnecessary aborts (Bug#9081).
3236
3237 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3238
3239 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3240 has no `load' handler, try opening the file locally. (Bug#9311)
3241
3242 2011-08-16 Ken Brown <kbrown@cornell.edu>
3243
3244 * gmalloc.c: Expand comment.
3245
3246 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3247
3248 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3249 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3250
3251 2011-08-16 Ken Brown <kbrown@cornell.edu>
3252
3253 Fix memory allocation problems in Cygwin build (Bug#9273).
3254
3255 * unexcw.c ( __malloc_initialized): Declare external variable.
3256 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3257
3258 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3259 New variables.
3260 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3261 dumped emacs.
3262 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3263 in the static heap.
3264 [CYGWIN] (special_realloc): New function.
3265 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3266 requests to realloc storage in the static heap.
3267
3268 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3269
3270 * bidi.c (bidi_initialize): Remove unused local.
3271
3272 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3273
3274 * bidimirror.h:
3275 * biditype.h: Remove file.
3276 * makefile.w32-in ($(BLD)/bidi.$(O)):
3277 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3278
3279 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3280
3281 * chartab.c: Improve commentary for the uniprop_table API.
3282
3283 * bidi.c (bidi_paragraph_init): Support zero value of
3284 bidi_ignore_explicit_marks_for_paragraph_level.
3285 (bidi_initialize): Use uniprop_table instead of including
3286 biditype.h and bidimirror.h.
3287
3288 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3289 coordinates of the iterator when restoring from ppos_it.
3290 (Bug#9296)
3291
3292 2011-08-14 Kenichi Handa <handa@m17n.org>
3293
3294 * process.c (create_process): Call setup_process_coding_systems
3295 after the pid of the process is set to -1 (Bug#8162).
3296
3297 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3298
3299 * xdisp.c (move_it_in_display_line_to): Don't invoke
3300 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3301 ppos_it. Fixes vertical cursor motion when line beginning is
3302 covered by an image. (Bug#9296)
3303
3304 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3305
3306 * nsterm.h (ns_run_ascript): Declare.
3307 (NSAPP_DATA2_RUNASSCRIPT): Define.
3308
3309 * nsfns.m (as_script, as_result, as_status): New static variables.
3310 (ns_run_ascript): New function.
3311 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3312 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3313 the event loop. Get status from as_status (Bug#7276).
3314
3315 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3316 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3317 the event loop (Bug#7276).
3318
3319 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3320
3321 * gnutls.c (QCgnutls_bootprop_priority)
3322 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3323 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3324 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3325 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3326 (QCgnutls_bootprop_verify_hostname_error)
3327 (QCgnutls_bootprop_callbacks_verify): Rename from
3328 Qgnutls_bootprop_..., all uses changed.
3329
3330 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3331 uses changed.
3332
3333 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3334
3335 * xfaces.c (Qframe_set_background_mode): Now static.
3336 * dispextern.h (Qframe_set_background_mode): Remove decl.
3337
3338 * process.c (Fnetwork_interface_info): Declare local only if needed.
3339
3340 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3341
3342 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3343 (Fnetwork_interface_list): Allocate in increments of bytes instead
3344 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3345 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3346 sockaddr.
3347 (struct ifflag_def): notrailers is smart on OSX.
3348 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3349 Get hardware address with getifaddrs if available.
3350
3351 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3352
3353 * xdisp.c (iterate_out_of_display_property): xassert that
3354 IT->position is set to within IT->object's boundaries. Break from
3355 the loop as soon as EOB is reached; avoids infloops in redisplay
3356 when IT->position is set up wrongly due to some bug.
3357 Set IT->current to match the bidi iterator unconditionally.
3358 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3359 entry. Force push_it to save on the stack the current
3360 buffer/string position, to be restored by pop_it. Fix flags in
3361 the iterator structure wrt the object coming from a display
3362 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3363 properties. (Bug#9284)
3364
3365 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3366
3367 * fontset.c (fontset_get_font_group): Add proper type checks.
3368 (Bug#9172)
3369
3370 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3371
3372 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3373 and LC_VERSION_MIN_MACOSX.
3374 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3375 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3376
3377 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3378
3379 * xdisp.c (forward_to_next_line_start): Allow to use the
3380 no-display-properties-and-no-overlays under bidi display.
3381 Set disp_pos in the bidi iterator to avoid searches for display
3382 properties and overlays.
3383
3384 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3385
3386 * editfns.c (Fset_time_zone_rule): Document relationship with the
3387 setenv function.
3388
3389 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3390 the font entity extracted from the cache (Bug#8109).
3391
3392 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3393
3394 * composite.c (autocmp_chars): Don't reset point. That is done by
3395 restore_point_unwind (Bug#5984).
3396
3397 2011-08-07 Juri Linkov <juri@jurta.org>
3398
3399 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3400 to show the arg `TIME' instead of `TIMEVAL'.
3401
3402 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3403
3404 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3405 display property strides EOL and includes a newline, as in
3406 longlines-mode. (Bug#9254)
3407 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3408 word-wrap under bidirectional display. (Bug#9224)
3409
3410 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3411 is non-zero, even if the data buffer is NULL. Fixes a crash in
3412 vertical-motion with longlines-mode. (Bug#9254)
3413
3414 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3415
3416 * bidi.c <bidi_cache_total_alloc>: Now static.
3417 (bidi_initialize): Initialize bidi_cache_total_alloc.
3418
3419 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3420 cache. (Bug#9221)
3421
3422 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3423 amount allocated this far in `bidi_cache_total_alloc'.
3424 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3425 non-zero, only free the data buffer without restoring the cache
3426 contents. All callers changed.
3427
3428 * dispextern.h (bidi_unshelve_cache): Update prototype.
3429
3430 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3431 (move_it_in_display_line, move_it_to)
3432 (move_it_vertically_backward, move_it_by_lines): Replace the call
3433 to xfree to an equivalent call to bidi_unshelve_cache.
3434 (move_it_in_display_line_to): Fix logic of returning
3435 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3436
3437 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3438
3439 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3440 came from a string character with a `cursor' property. (Bug#9229)
3441
3442 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3443
3444 * Makefile.in (LIB_PTHREAD): New variable.
3445 (LIBES): Add LIB_PTHREAD (Bug#9216).
3446
3447 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3448 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3449
3450 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3451
3452 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3453
3454 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3455
3456 * xterm.c (x_find_topmost_parent): New function.
3457 (x_set_frame_alpha): Find topmost parent window with
3458 x_find_topmost_parent and set the property there also (bug#9181).
3459 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3460
3461 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3462
3463 * callproc.c (Fcall_process): Avoid vfork clobbering
3464 the local vars buffer, coding_systems, current_dir.
3465
3466 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3467
3468 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3469
3470 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3471
3472 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3473 so that it is not optimized away.
3474
3475 * xdisp.c (compute_display_string_pos): Remove unused local.
3476
3477 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3478
3479 Fix slow cursor motion and scrolling in large buffers with
3480 selective display, like Org Mode buffers. (Bug#9218)
3481
3482 * dispextern.h (struct bidi_it): New member disp_prop_p.
3483
3484 * xdisp.c: Remove one-slot cache of display string positions.
3485 (compute_display_string_pos): Accept an additional argument
3486 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3487 for a display string or property. If found, set DISP_PROP_P
3488 non-zero.
3489
3490 * bidi.c (bidi_fetch_char): Accept an additional argument
3491 DISP_PROP_P, and pass it to compute_display_string_pos.
3492 Only handle text covered by a display string if DISP_PROP_P is returned
3493 non-zero. All callers of bidi_fetch_char changed.
3494
3495 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3496
3497 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3498
3499 2010-12-03 Don March <don@ohspite.net>
3500
3501 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3502 last character M-[char] is translated to ESC [char] (bug#7541).
3503
3504 2011-08-02 Kenichi Handa <handa@m17n.org>
3505
3506 * lisp.h (uniprop_table): Extern it.
3507
3508 * chartab.c (uniprop_table): Make it non-static.
3509
3510 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3511
3512 * xdisp.c (forward_to_next_line_start): Accept additional argument
3513 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3514 on the newline.
3515 (reseat_at_next_visible_line_start): Use the bidi iterator state
3516 returned by forward_to_next_line_start to restore the state of
3517 it->bidi_it after backing up to previous newline. (Bug#9212)
3518
3519 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3520
3521 * regex.c (re_comp): Protoize.
3522 (re_exec): Fix return type.
3523 (regexec): Fix type of `ret'. (Bug#9203)
3524
3525 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3526
3527 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3528 This is needed if max-image-size is a floating-point number.
3529
3530 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3531
3532 * print.c (print_object): Print empty symbol as ##.
3533
3534 * lread.c (read1): Read ## as empty symbol.
3535
3536 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3537
3538 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3539 setting frame foreground color (Bug#9175).
3540 (x_set_background_color): Likewise.
3541
3542 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3543 contents (Bug#9176).
3544 (EmacsTooltip -init): Remove bezels and add shadows to
3545 tooltip windows.
3546
3547 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3548 or scroll bar (Bug#8470).
3549
3550 * nsfont.m (nsfont_open): Remove assignment to voffset and
3551 unnecessary vars hshink, expand, hd, full_height, min_height.
3552 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3553
3554 * nsterm.h (nsfont_info): Remove voffset field.
3555
3556 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3557
3558 Implement strike-through and overline on NextStep (Bug#8863).
3559
3560 * nsfont.m (nsfont_open): Use underline position provided by font,
3561 instead of hard-coded value of 2.
3562 (nsfont_draw): Call ns_draw_text_decoration instead.
3563
3564 * nsterm.h: Add declaration for ns_draw_text_decoration.
3565
3566 * nsterm.m (ns_draw_text_decoration): New function for drawing
3567 underline, overline, and strike-through.
3568 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3569 ns_draw_text_decoration. Change treatment of cursor drawing to
3570 accommodate underlining, etc.
3571
3572 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3573
3574 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3575 default.
3576
3577 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3578
3579 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3580 Without this fix, if a signal arrives just after memory fills up,
3581 'malloc' might be invoked reentrantly.
3582
3583 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3584 In other words, assume that every image size is allowed, on non-X
3585 hosts. This assumption is probably wrong, but it lets Emacs compile.
3586
3587 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3588
3589 * regex.c (re_iswctype): Convert return values to boolean.
3590
3591 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3592
3593 * xdisp.c (compute_display_string_pos): Don't use cached display
3594 string position if the buffer had its restriction changed.
3595 (Bug#9184)
3596
3597 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3598
3599 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3600
3601 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3602
3603 Integer signedness and overflow and related fixes. (Bug#9079)
3604
3605 * bidi.c: Integer size and overflow fixes.
3606 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3607 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3608 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3609 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3610 (bidi_find_other_level_edge):
3611 Use ptrdiff_t instead of EMACS_INT where either will do.
3612 This works better on 32-bit hosts configured --with-wide-int.
3613 (bidi_cache_ensure_space): Check for size-calculation overflow.
3614 Use % rather than repeated addition, for better worst-case speed.
3615 Don't set bidi_cache_size until after xrealloc returns, because it
3616 might not return.
3617 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3618 (bidi_cache_ensure_space): Also check that the bidi cache size
3619 does not exceed that of the largest Lisp string or buffer. See Eli
3620 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3621
3622 * alloc.c (__malloc_size_t): Remove.
3623 All uses replaced by size_t. See Andreas Schwab's note
3624 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3625
3626 * image.c: Improve checking for integer overflow.
3627 (check_image_size): Assume that f is nonnull, since
3628 it is always nonnull in practice. This is one less thing to
3629 worry about when checking for integer overflow later.
3630 (x_check_image_size): New function, which checks for integer
3631 overflow issues inside X.
3632 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3633 This removes the need for a memory_full check.
3634 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3635 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3636 (xbm_read_bitmap_data): Change locals back to 'int', since
3637 their values must fit in 'int'.
3638 (xpm_load_image, png_load, tiff_load):
3639 Invoke x_create_x_image_and_pixmap earlier,
3640 to avoid much needless work if the image is too large.
3641 (tiff_load): Treat overly large images as if
3642 x_create_x_image_and_pixmap failed, not as malloc failures.
3643 (gs_load): Use x_check_image_size.
3644
3645 * gtkutil.c: Omit integer casts.
3646 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3647 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3648
3649 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3650
3651 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3652 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3653 would wrongly return t on a 64-bit host.
3654
3655 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3656 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3657 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3658 and therefore cause GCC to emit a bogus diagnostic in some cases.
3659
3660 * image.c: Integer signedness and overflow and related fixes.
3661 This is not an exhaustive set of fixes, but it's time to
3662 record what I've got.
3663 (lookup_pixel_color, check_image_size): Remove redundant decls.
3664 (check_image_size): Don't assume that arbitrary EMACS_INT values
3665 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3666 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3667 (tiff_load, imagemagick_load_image):
3668 Check for overflow in size calculations.
3669 (x_create_x_image_and_pixmap): Remove unnecessary test for
3670 xmalloc returning NULL; that can't happen.
3671 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3672 (xpm_color_bucket): Use better integer hashing function.
3673 (xpm_cache_color): Don't possibly over-allocate memory.
3674 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3675 (gif_memory_source):
3676 Use ptrdiff_t, not int or size_t, to record sizes.
3677 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3678 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3679 either works, as we prefer signed integers.
3680 (tiff_read_from_memory, tiff_write_from_memory):
3681 Return tsize_t, not size_t, since that's what the TIFF API wants.
3682 (tiff_read_from_memory): Don't fail simply because the read would
3683 go past EOF; instead, return a short read.
3684 (tiff_load): Omit no-longer-needed casts.
3685 (Fimagemagick_types): Don't assume size fits into 'int'.
3686
3687 Improve hashing quality when configured --with-wide-int.
3688 * fns.c (hash_string): New function, taken from sxhash_string.
3689 Do not discard information about ASCII character case; this
3690 discarding is no longer needed.
3691 (sxhash-string): Use it. Change sig to match it. Caller changed.
3692 * lisp.h: Declare it.
3693 * lread.c (hash_string): Remove, since we now use fns.c's version.
3694 The fns.c version returns a wider integer if --with-wide-int is
3695 specified, so this should help the quality of the hashing a bit.
3696
3697 * emacs.c: Integer overflow minor fix.
3698 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3699 Define only if GNU_LINUX.
3700 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3701
3702 * dispnew.c: Integer signedness and overflow fixes.
3703 Remove unnecessary forward decls, that were a maintenance hassle.
3704 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3705 All uses changed.
3706 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3707 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3708 (prepare_desired_row, line_draw_cost):
3709 Use int, not unsigned, where either works.
3710 (save_current_matrix, restore_current_matrix):
3711 Use ptrdiff_t, not size_t, where either works.
3712 (init_display): Check for overflow more accurately, and without
3713 relying on undefined behavior.
3714
3715 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3716 Remove, replacing with the new symbols in lisp.h. All uses changed.
3717 * fileio.c (make_temp_name):
3718 * filelock.c (lock_file_1, lock_file):
3719 * xdisp.c (message_dolog):
3720 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3721 Use pMd etc. instead.
3722 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3723 replacing the pWIDE etc. symbols removed from editfns.c.
3724
3725 * keyboard.h (num_input_events): Now uintmax_t.
3726 This is (very slightly) less likely to mess up due to wraparound.
3727 All uses changed.
3728
3729 * buffer.c: Integer signedness fixes.
3730 (alloc_buffer_text, enlarge_buffer_text):
3731 Use ptrdiff_t rather than size_t when either will do, as we prefer
3732 signed integers.
3733
3734 * alloc.c: Integer signedness and overflow fixes.
3735 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3736 (__malloc_size_t): Default to size_t, not to int.
3737 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3738 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3739 Prefer ptrdiff_t to size_t when either would do, as we prefer
3740 signed integers.
3741 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3742 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3743 Now const. Initialize with values that are in range even if char
3744 is signed.
3745 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3746 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3747 These functions do the right thing with sizes > 2**32.
3748 (check_depth): Now ptrdiff_t, not int.
3749 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3750 Adjust to new way of storing sizes. Check for size overflow bugs
3751 in rest of code.
3752 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3753 slightly wrong anyway, as it missed one instance of
3754 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3755 (refill_memory_reserve): Omit needless cast to size_t.
3756 (mark_object_loop_halt): Mark as externally visible.
3757
3758 * xselect.c: Integer signedness and overflow fixes.
3759 (Fx_register_dnd_atom, x_handle_dnd_message):
3760 Use ptrdiff_t, not size_t, since we prefer signed.
3761 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3762 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3763 x_dnd_atoms_size and x_dnd_atoms_length.
3764
3765 * doprnt.c: Prefer signed to unsigned when either works.
3766 * eval.c (verror):
3767 * doprnt.c (doprnt):
3768 * lisp.h (doprnt):
3769 * xdisp.c (vmessage):
3770 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3771 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3772 prefer signed arithmetic to avoid comparison confusion.
3773 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3774 but is a bit tricky.
3775
3776 Assume freestanding C89 headers, string.h, stdlib.h.
3777 * data.c, doprnt.c, floatfns.c, print.c:
3778 Include float.h unconditionally.
3779 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3780 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3781 * regex.c: Likewise for stddef.h, string.h.
3782 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3783 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3784 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3785 (STDC_HEADERS): Remove obsolete defines.
3786 * sysdep.c: Include limits.h unconditionally.
3787
3788 Assume support for memcmp, memcpy, memmove, memset.
3789 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3790 * regex.c (memcmp, memcpy):
3791 Remove; we assume C89 now.
3792
3793 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3794 (__malloc_safe_bcopy): Remove; no longer needed.
3795
3796 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3797 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3798 well either way, and we prefer signed to unsigned.
3799
3800 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3801
3802 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3803 closes the connection while we're reading (bug#9182).
3804
3805 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3806
3807 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3808 are specified (Bug#9168).
3809
3810 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3811
3812 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3813 Found by GCC static checking and --with-wide-int on a 32-bit host.
3814
3815 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3816
3817 * xdisp.c (compute_display_string_pos): Fix logic of caching
3818 previous display string position. Initialize cached_prev_pos to
3819 -1. Fixes slow-down at the beginning of a buffer.
3820
3821 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3822
3823 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3824 for attrs[LFACE_FONTSET_INDEX].
3825
3826 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3827
3828 * xml.c (parse_region): Remove unused local
3829 that was recently introduced.
3830
3831 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3832
3833 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3834 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3835
3836 * xdisp.c (move_it_in_display_line_to): Record the best matching
3837 position for TO_CHARPOS while scanning the line, and restore it on
3838 exit if none of the characters scanned was an exact match.
3839 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3840 when exact match is impossible due to invisible text, and the
3841 lines are truncated.
3842
3843 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3844
3845 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3846 for OSX >= 10.7.
3847
3848 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3849
3850 Fix a significant slow-down of cursor motion with C-n, C-p,
3851 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3852 auto-repeat under bidi redisplay in fontified buffers.
3853 * xdisp.c (compute_stop_pos_backwards): New function.
3854 (next_element_from_buffer): Call compute_stop_pos_backwards to
3855 find a suitable prev_stop when we find ourselves before
3856 base_level_stop.
3857 (reseat): Don't look for prev_stop, as that could mean a very long
3858 run.
3859 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3860 <cached_disp_overlay_modiff>: Cache for last found display string
3861 position.
3862 (compute_display_string_pos): Return the cached position if asked
3863 about the same buffer in the same area of character positions, and
3864 the buffer wasn't changed since the time the display string
3865 position was cached.
3866
3867 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3868
3869 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3870 is an integer, which is important for empty lines. (Bug#9149)
3871
3872 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3873
3874 * frame.c (Fmodify_frame_parameters): In tty case, update the
3875 default face if necessary (Bug#4238).
3876
3877 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3878
3879 * editfns.c (Fstring_to_char): No need to explain what a character
3880 is in the docstring (Bug#6576).
3881
3882 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3883
3884 * xml.c (parse_region): Make sure we always return a tree.
3885
3886 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3887
3888 * xml.c (parse_region): If a document contains only comments,
3889 return that, too.
3890
3891 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3892
3893 * xml.c (make_dom): Return comments, too.
3894
3895 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3896
3897 Port to OpenBSD.
3898 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3899 and the surrounding thread.
3900 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3901 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3902 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3903 timer goes off.
3904 * s/openbsd.h (BROKEN_SIGIO): Define.
3905 * unexelf.c (unexec) [__OpenBSD__]:
3906 Don't update the .mdebug section of the Alpha COFF symbol table.
3907
3908 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3909
3910 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3911 (bug#8460).
3912
3913 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3914
3915 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3916 This fixes some race conditions on the permissions of any newly
3917 created file.
3918
3919 * alloc.c (valid_pointer_p): Use pipe, not open.
3920 This fixes some permissions issues when debugging.
3921
3922 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3923 If fchown fails to set both uid and gid, try to set just gid,
3924 as that is sometimes allowed. Adjust the file's mode to eliminate
3925 setuid or setgid bits that are inappropriate if fchown fails.
3926
3927 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3928
3929 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3930 to compare Lisp_Objects.
3931 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3932 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3933 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3934
3935 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3936
3937 * lread.c (read_integer): Unread even EOF character.
3938 (read1): Likewise. Properly record start position of symbol.
3939
3940 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3941 symbol character follows.
3942
3943 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3944
3945 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3946 This works around a problem with the previous change to Fcopy_file.
3947 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3948 and without this change, GCC might complain about discarding
3949 fchown's return value.
3950
3951 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3952
3953 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3954
3955 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3956
3957 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3958
3959 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3960
3961 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3962 it's used from the C level.
3963
3964 * process.c: Use the same condition for POLL_FOR_INPUT in both
3965 keyboard.c and process.c (bug#1858).
3966
3967 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3968
3969 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3970 (Fgnutls_boot): Use it.
3971
3972 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3973
3974 * doc.c (Fsubstitute_command_keys): Revert last change.
3975
3976 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3977
3978 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3979 quotes the next character, and doesn't affect other longer
3980 sequences (bug#8935).
3981
3982 * lread.c (syms_of_lread): Clarify that is isn't only
3983 `eval-buffer' and `eval-defun' that's affected by
3984 `lexical-binding' (bug#8460).
3985
3986 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3987
3988 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3989 bidi redisplay when a line includes both an image and is truncated.
3990
3991 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3992
3993 Fix minor problems found by static checking.
3994 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3995 (elsz): Now a signed constant, not a size_t var. We prefer signed
3996 types to unsigned, to avoid integer comparison confusion. Without
3997 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3998 "cannot optimize loop, the loop counter may overflow", a symptom
3999 of the confusion.
4000 * indent.c (Fvertical_motion): Mark locals as initialized.
4001 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4002
4003 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4004
4005 * search.c (Fre_search_backward): Mention `case-fold-search' in
4006 all the re_search_* functions (bug#8138).
4007
4008 * keyboard.c (Fopen_dribble_file): Document when the file is
4009 closed (bug#8056).
4010
4011 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4012
4013 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4014 bidi_cache_idx.
4015
4016 Support bidi reordering of display and overlay strings.
4017 * xdisp.c (compute_display_string_pos)
4018 (compute_display_string_end): Accept additional argument STRING.
4019 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4020 (reseat_to_string): Initialize bidi_it->string.s and
4021 bidi_it->string.schars.
4022 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4023 NULL (avoids a crash in bidi_paragraph_init).
4024 Initialize itb.string.lstring.
4025 (init_iterator): Call bidi_init_it only of a valid
4026 buffer position was specified. Initialize paragraph_embedding to
4027 L2R.
4028 (reseat_to_string): Initialize the bidi iterator.
4029 (display_string): If we need to ignore text properties of
4030 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4031 original value of -1 will not work with bidi.)
4032 (compute_display_string_pos): First arg is now struct
4033 `text_pos *'; all callers changed. Support display properties on
4034 Lisp strings.
4035 (compute_display_string_end): Support display properties on Lisp
4036 strings.
4037 (init_iterator, reseat_1, reseat_to_string): Initialize the
4038 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4039 when iterating on a string not from display properties).
4040 (compute_display_string_pos, compute_display_string_end):
4041 Fix calculation of the object to scan. Fixes an error when using
4042 arrow keys.
4043 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4044 base_level_stop; instead, set base_level_stop to BEGV.
4045 Fixes crashes in vertical-motion.
4046 (next_element_from_buffer): Improve commentary for when
4047 the iterator is before prev_stop.
4048 (init_iterator): Initialize bidi_p from the default value of
4049 bidi-display-reordering, not from buffer-local value. Use the
4050 buffer-local value only if initializing for buffer iteration.
4051 (handle_invisible_prop): Support invisible properties on strings
4052 that are being bidi-reordered.
4053 (set_iterator_to_next): Support bidi reordering of C strings and
4054 Lisp strings.
4055 (next_element_from_string): Support bidi reordering of Lisp
4056 strings.
4057 (handle_stop_backwards): Support Lisp strings as well.
4058 (display_string): Support display of R2L glyph rows.
4059 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4060 (init_iterator): Don't initialize it->bidi_p for strings
4061 here.
4062 (reseat_to_string): Initialize it->bidi_p for strings here.
4063 (next_element_from_string, next_element_from_c_string)
4064 (next_element_from_buffer): Add xassert's for correspondence
4065 between IT's object being iterated and it->bidi_it.string
4066 structure.
4067 (face_before_or_after_it_pos): Support bidi iteration.
4068 (next_element_from_c_string): Handle the case of the first string
4069 character that is not the first one in the visual order.
4070 (get_visually_first_element): New function, refactored from common
4071 parts of next_element_from_buffer, next_element_from_string, and
4072 next_element_from_c_string.
4073 (tool_bar_lines_needed, redisplay_tool_bar)
4074 (display_menu_bar): Force left-to-right direction. Add a FIXME
4075 comment for making that be controlled by a user option.
4076 (push_it, pop_it): Save and restore the state of the
4077 bidi iterator. Save and restore the bidi_p flag.
4078 (pop_it): Iterate out of display property for string iteration as
4079 well.
4080 (iterate_out_of_display_property): Support iteration over strings.
4081 (handle_single_display_spec): Set up it->bidi_it for iteration
4082 over a display string, and call bidi_init_it.
4083 (handle_single_display_spec, next_overlay_string)
4084 (get_overlay_strings_1, push_display_prop): Set up the bidi
4085 iterator for displaying display or overlay strings.
4086 (forward_to_next_line_start): Don't use the shortcut if
4087 bidi-iterating.
4088 (back_to_previous_visible_line_start): If handle_display_prop
4089 pushed the iterator stack, restore the internal state of the bidi
4090 iterator by calling bidi_pop_it same number of times.
4091 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4092 and we are bidi-iterating, don't decrement the iterator position;
4093 instead, set the first_elt flag in the bidi iterator, to produce
4094 the same effect.
4095 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4096 (push_display_prop): xassert that we are iterating a buffer.
4097 (push_it, pop_it): Save and restore paragraph_embedding member.
4098 (handle_single_display_spec, next_overlay_string)
4099 (get_overlay_strings_1, reseat_1, reseat_to_string)
4100 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4101 correctly. Don't assume unibyte strings are not bidi-reordered.
4102 (compute_display_string_pos)
4103 (compute_display_string_end): Fix handling the case of C string.
4104 (push_it, pop_it): Save and restore from_disp_prop_p.
4105 (handle_single_display_spec, push_display_prop): Set the
4106 from_disp_prop_p flag.
4107 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4108 (pop_it): Call iterate_out_of_display_property only if we are
4109 popping after iteration over a string that came from a display
4110 property. Fix a typo in popping stretch info. Add an assertion
4111 for verifying that the iterator position is in sync with the bidi
4112 iterator.
4113 (handle_single_display_spec, get_overlay_strings_1)
4114 (push_display_prop): Fix initialization of paragraph direction for
4115 string when that of the parent object is not yet determined.
4116 (reseat_1): Call bidi_init_it to resync the bidi
4117 iterator with IT's position. (Bug#7616)
4118 (find_row_edges): If ROW->start.pos gives position
4119 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4120 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4121 Reset the from_disp_prop_p flag.
4122 (SAVE_IT, RESTORE_IT): New macros.
4123 (pos_visible_p, face_before_or_after_it_pos)
4124 (back_to_previous_visible_line_start)
4125 (move_it_in_display_line_to, move_it_in_display_line)
4126 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4127 (try_scrolling, redisplay_window, display_line): Use them when
4128 saving a temporary copy of the iterator and restoring it back.
4129 (back_to_previous_visible_line_start, reseat_1)
4130 (init_iterator): Empty the bidi cache "stack".
4131 (move_it_in_display_line_to): If iterator ended up at
4132 EOL, but we never saw any buffer positions smaller than
4133 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4134 motion in bidi-reordered lines.
4135 (move_it_in_display_line_to): Record prev_method and prev_pos
4136 immediately before the call to set_iterator_to_next. Fixes cursor
4137 motion in bidi-reordered lines with stretch glyphs and strings
4138 displayed in margins. (Bug#8133) (Bug#8867)
4139 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4140 TO_CHARPOS.
4141 (pos_visible_p): Support positions in bidi-reordered lines.
4142 Save and restore bidi cache.
4143
4144 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4145 (bidi_paragraph_info): Delete unused struct.
4146 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4147 (bidi_cache_start): New variable.
4148 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4149 to zero.
4150 (bidi_cache_fetch_state, bidi_cache_search)
4151 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4152 (bidi_cache_find, bidi_peek_at_next_level)
4153 (bidi_level_of_next_char, bidi_find_other_level_edge)
4154 (bidi_move_to_visually_next): Compare cache index with
4155 bidi_cache_start rather than with zero.
4156 (bidi_fetch_char): Accept new argument STRING; all callers
4157 changed. Support iteration over a string. Support strings with
4158 display properties. Support unibyte strings. Fix the type of
4159 `len' according to what STRING_CHAR_AND_LENGTH expects.
4160 (bidi_paragraph_init, bidi_resolve_explicit_1)
4161 (bidi_resolve_explicit, bidi_resolve_weak)
4162 (bidi_level_of_next_char, bidi_move_to_visually_next):
4163 Support iteration over a string.
4164 (bidi_set_sor_type, bidi_resolve_explicit_1)
4165 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4166 can now be zero (for strings); special values 0 and -1 were
4167 changed to -1 and -2, respectively.
4168 (bidi_char_at_pos): New function.
4169 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4170 Call it instead of FETCH_MULTIBYTE_CHAR.
4171 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4172 initialized to valid values.
4173 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4174 values.
4175 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4176 the test for valid cached positions. Fix the logic for looking up
4177 the sentinel state in the cache. GCPRO the Lisp string we are
4178 iterating.
4179 (bidi_push_it, bidi_pop_it): New functions.
4180 (bidi_initialize): Initialize the bidi cache start stack pointer.
4181 (bidi_cache_ensure_space): New function, refactored from part of
4182 bidi_cache_iterator_state. Don't assume the required size is just
4183 one BIDI_CACHE_CHUNK away.
4184 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4185 (bidi_count_bytes, bidi_char_at_pos): New functions.
4186 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4187 always valid if bidi_cache_idx is valid.
4188 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4189 is valid if it's going to be used.
4190 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4191 (bidi_cache_fetch_state, bidi_cache_search)
4192 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4193 (bidi_cache_iterator_state, bidi_cache_find)
4194 (bidi_find_other_level_edge, bidi_cache_start_stack):
4195 All variables related to cache indices are now EMACS_INT.
4196
4197 * dispextern.h (struct bidi_string_data): New structure.
4198 (struct bidi_it): New member `string'. Make flag members be 1-bit
4199 fields, and put them last in the struct.
4200 (compute_display_string_pos, compute_display_string_end):
4201 Update prototypes.
4202 (bidi_push_it, bidi_pop_it): Add prototypes.
4203 (struct iterator_stack_entry): New members bidi_p,
4204 paragraph_embedding, and from_disp_prop_p.
4205 (struct it): Member bidi_p is now a bit field 1 bit wide.
4206 (bidi_shelve_cache, bidi_unshelve_cache):
4207 Declare prototypes.
4208
4209 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4210 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4211 and vector-like objects.
4212
4213 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4214 cache around display iteration.
4215
4216 * window.c (Fwindow_end, window_scroll_pixel_based)
4217 (displayed_window_lines, Frecenter): Save and restore the bidi
4218 cache around display iteration.
4219
4220 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4221
4222 * editfns.c (Fdelete_region): Clarify the use of the named
4223 parameters (bug#6788).
4224
4225 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4226
4227 * indent.c (Fvertical_motion): Set and restore w->pointm when
4228 saving and restoring the window's buffer (Bug#9006).
4229
4230 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4231
4232 * editfns.c (Fstring_to_char): Clarify just what is returned
4233 (bug#6576). Text by Eli Zaretskii.
4234
4235 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4236
4237 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4238
4239 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4240
4241 * buffer.c (mmap_find): Fix a typo.
4242
4243 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4244
4245 Fix execution of x selection hooks.
4246 * xselect.c (Qx_lost_selection_functions)
4247 (Qx_sent_selection_functions): New vars.
4248 (syms_of_xselect): DEFSYM them.
4249 (x_handle_selection_request): Pass Qx_sent_selection_functions
4250 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4251 (x_handle_selection_clear,x_clear_frame_selections):
4252 Pass Qx_lost_selection_functions rather than
4253 Vx_lost_selection_functions to Frun_hook_with_args.
4254
4255 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4256
4257 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4258 The old code sometimes used this field without initializing it.
4259
4260 * alloc.c (gc_sweep): Don't read past end of array.
4261 In theory, the old code could also have corrupted Emacs internals,
4262 though it'd be very unlikely.
4263
4264 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4265
4266 * character.c (Fcharacterp): Don't advertise optional ignored
4267 argument. (Bug#4026)
4268
4269 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4270
4271 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4272 key" (bug#4257).
4273
4274 * window.c (Fset_window_start): Doc fix (bug#4199).
4275 (Fset_window_hscroll): Ditto.
4276
4277 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4278
4279 Fix minor new problems caught by GCC 4.6.1.
4280 * term.c (init_tty): Remove unused local.
4281 * xsettings.c (store_monospaced_changed): Define this function only
4282 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4283 not used otherwise.
4284
4285 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4286
4287 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4288
4289 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4290
4291 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4292 are the mini-buffer and the echo area (bug#3320).
4293
4294 * term.c (init_tty): Remove support for supdup, c10 and perq
4295 terminals, which are no longer supported (bug#1482).
4296
4297 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4298
4299 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4300
4301 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4302
4303 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4304 for non-popups (Bug#3642).
4305
4306 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4307
4308 * alloc.c (reset_malloc_hooks): Protoize.
4309 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4310 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4311 * cm.c (losecursor): Likewise.
4312 * data.c (fmod): Likewise.
4313 * dispnew.c (swap_glyphs_in_rows): Likewise.
4314 * emacs.c (memory_warning_signal): Likewise.
4315 * floatfns.c (float_error): Likewise.
4316 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4317 (otf_open, font_otf_capability, generate_otf_features)
4318 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4319 Likewise.
4320 * image.c (pbm_read_file): Likewise.
4321 * indent.c (string_display_width): Likewise.
4322 * intervals.c (check_for_interval, search_for_interval)
4323 (inc_interval_count, count_intervals, root_interval)
4324 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4325 * lread.c (defalias): Likewise.
4326 * ralloc.c (r_alloc_check): Likewise.
4327 * regex.c (set_image_of_range_1, set_image_of_range)
4328 (regex_grow_registers): Likewise.
4329 * sysdep.c (strerror): Likewise.
4330 * termcap.c (valid_filename_p, tprint, main): Likewise.
4331 * tparam.c (main): Likewise.
4332 * unexhp9k800.c (run_time_remap, save_data_space)
4333 (update_file_ptrs, read_header, write_header, calculate_checksum)
4334 (copy_file, copy_rest, display_header): Likewise.
4335 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4336 Likewise.
4337 * xdisp.c (check_it): Likewise.
4338 * xfaces.c (register_color, unregister_color, unregister_colors):
4339 Likewise.
4340 * xfns.c (print_fontset_result): Likewise.
4341 * xrdb.c (member, fatal, main): Likewise.
4342
4343 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4344
4345 Fix minor problems found by static checking (Bug#9031).
4346 * chartab.c (char_table_set_range, map_sub_char_table):
4347 Remove unused locals.
4348 (uniprop_table): Now static.
4349 * composite.c (_work_char): Remove unused static var.
4350
4351 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4352
4353 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4354
4355 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4356
4357 * gtkutil.c (qttip_cb): Remove code without function.
4358
4359 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4360
4361 * w32.c (pthread_sigmask): New stub.
4362
4363 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4364
4365 Use pthread_sigmask, not sigprocmask (Bug#9010).
4366 sigprocmask is portable only for single-threaded applications, and
4367 Emacs can be multi-threaded when it uses GTK.
4368 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4369 (LIBES): Use it.
4370 * callproc.c (Fcall_process):
4371 * process.c (create_process):
4372 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4373 Use pthread_sigmask, not sigprocmask.
4374
4375 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4376
4377 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4378 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4379 wrong (Bug#8591).
4380
4381 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4382
4383 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4384 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4385 (xg_hide_tooltip): Fix comment.
4386
4387 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4388 in registerServicesMenuSendTypes.
4389 (validRequestorForSendType): Don't check ns_return_types.
4390
4391 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4392 ns_return_type.
4393
4394 2011-07-08 Jason Rumney <jasonr@gnu.org>
4395
4396 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4397 SH_SHOW for hidden windows (Bug#5482).
4398
4399 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4400 frame struct members of non-existent frames (Bug#6284).
4401
4402 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4403
4404 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4405 variable firstTime not needed on OSX >= 10.6.
4406 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4407 >= 10.5. Use setKnobProportion, setDoubleValue.
4408
4409 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4410 (MAC_OS_X_VERSION_10_5): Define if not defined.
4411 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4412 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4413 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4414
4415 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4416 cString and lossyCString on OSX >= 10.4
4417
4418 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4419 sizeToFit on OSX >= 10.2.
4420
4421 * nsimage.m (allocInitFromFile): Don't use deprecated method
4422 bestRepresentationForDevice on OSX >= 10.6.
4423
4424 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4425 to avoid warning.
4426
4427 * emacs.c: Declare unexec_init_emacs_zone.
4428
4429 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4430
4431 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4432
4433 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4434 on svcsMenu (Bug#8842).
4435
4436 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4437 ns_return_types.
4438 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4439
4440 * nsterm.m (QUTF8_STRING): Declare.
4441 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4442 (validRequestorForSendType): Return type is (id).
4443 Change indexOfObjectIdenticalTo to indexOfObject.
4444 Check if we have local selection before returning self (Bug#8842).
4445 (writeSelectionToPasteboard): Put local selection into paste board
4446 if we have a local selection (Bug#8842).
4447 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4448
4449 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4450 (ns_get_local_selection): Declare.
4451
4452 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4453
4454 * keymap.c (describe_map_tree): Don't insert a double newline at
4455 the end of the buffer (bug#1169) and return whether we inserted
4456 something.
4457
4458 * callint.c (Fcall_interactively): Change "reading args" to
4459 "providing args" to try to clarify what it does (bug#1010).
4460
4461 2011-07-07 Kenichi Handa <handa@m17n.org>
4462
4463 * composite.c (composition_compute_stop_pos): Ignore a static
4464 composition starting before CHARPOS (Bug#8915).
4465
4466 * xdisp.c (handle_composition_prop): Likewise.
4467
4468 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4469
4470 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4471 (Bug#9015)
4472
4473 2011-07-07 Kenichi Handa <handa@m17n.org>
4474
4475 * character.h (unicode_category_t): New enum type.
4476
4477 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4478 (Qchar_code_property_table): New variable.
4479 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4480 (UNIPROP_COMPRESSED_FORM_P): New macros.
4481 (char_table_ascii): Uncompress the compressed values.
4482 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4483 Uncompress the compressed values.
4484 (sub_char_table_ref_and_range): Likewise.
4485 (char_table_ref_and_range): Uncompress the compressed values.
4486 (sub_char_table_set): New arg is_uniprop. Callers changed.
4487 Uncompress the compressed values.
4488 (sub_char_table_set_range): Args changed. Callers changed.
4489 (char_table_set_range): Adjuted for the above change.
4490 (map_sub_char_table): Delete args default_val and parent. Add arg
4491 top. Give decoded values to a Lisp function.
4492 (map_char_table): Adjust for the above change. Give decoded
4493 values to a Lisp function. Gcpro more variables.
4494 (uniprop_table_uncompress)
4495 (uniprop_decode_value_run_length): New functions.
4496 (uniprop_decoder, uniprop_decoder_count): New variables.
4497 (uniprop_get_decoder, uniprop_encode_value_character)
4498 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4499 New functions.
4500 (uniprop_encoder, uniprop_encoder_count): New variables.
4501 (uniprop_get_encoder, uniprop_table)
4502 (Funicode_property_table_internal, Fget_unicode_property_internal)
4503 (Fput_unicode_property_internal): New functions.
4504 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4505 Sunicode_property_table_internal, Sget_unicode_property_internal,
4506 and Sput_unicode_property_internal. Defvar_lisp
4507 char-code-property-alist.
4508
4509 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4510 Vunicode_category_table.
4511
4512 * font.c (font_range): Adjust for the change of
4513 Vunicode_category_table.
4514
4515 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4516
4517 * m/iris4d.h: Remove file, move contents ...
4518 * s/irix6-5.h: ... here.
4519
4520 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4521
4522 Remove unportable assumption about struct layout (Bug#8884).
4523 * alloc.c (mark_buffer):
4524 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4525 (clone_per_buffer_values): Don't assume that
4526 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4527 This isn't true in general, and it's particularly not true
4528 if Emacs is configured with --with-wide-int.
4529 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4530 New macros, used in the buffer.c change.
4531
4532 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4533
4534 * xsettings.c: Use both GConf and GSettings if both are available.
4535 (store_config_changed_event): Add comment.
4536 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4537 (store_tool_bar_style_changed): New functions.
4538 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4539 (struct xsettings): Move font inside HAVE_XFT.
4540 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4541 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4542 Move inside HAVE_XFT.
4543 (something_changed_gsettingsCB): Rename from something_changedCB.
4544 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4545 also.
4546 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4547 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4548 (something_changed_gconfCB): Rename from something_changedCB.
4549 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4550 (parse_settings): Move check for font inside HAVE_XFT.
4551 (read_settings, apply_xft_settings): Add comment.
4552 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4553 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4554 call store_font_name_changed.
4555 (xft_settings_event): Add comment.
4556 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4557 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4558 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4559 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4560 (xsettings_initialize): Call init_gsettings last.
4561 (xsettings_get_system_font, xsettings_get_system_normal_font):
4562 Add comment.
4563
4564 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4565
4566 Random fixes. E.g., (random) never returned negative values.
4567 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4568 subseconds part to the entropy, as that's a bit more random.
4569 Prefer signed to unsigned, since the signedness doesn't matter and
4570 in general we prefer signed. When given a limit, use a
4571 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4572 latter isn't right if USE_2_TAGS_FOR_INTS.
4573 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4574 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4575
4576 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4577
4578 * textprop.c (text_property_stickiness):
4579 Obey Vtext_property_default_nonsticky.
4580 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4581 * w32fns.c (syms_of_w32fns):
4582 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4583
4584 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4585
4586 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4587 This is more efficient than Ffile_directory_p and avoids a minor race.
4588
4589 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4590
4591 * buffer.c (Foverlay_put): Say what the return value is
4592 (bug#7835).
4593
4594 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4595 is a directory before asking whether to use the file name
4596 (bug#7564).
4597 (barf_or_query_if_file_exists): Make the "File is a directory"
4598 error be more correct.
4599
4600 * fns.c (Frequire): Remove the mention of the .gz files, since
4601 that's installation-specific, but keep the mention of
4602 `get-load-suffixes'.
4603
4604 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4605
4606 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4607 Report string overflow if the output is too long.
4608
4609 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4610
4611 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4612 (syms_of_gnutls): Remove duplicate DEFSYM for
4613 Qgnutls_bootprop_verify_hostname_error, an error for
4614 Qgnutls_bootprop_verify_error (which is no longer used).
4615
4616 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4617 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4618 Also (re)move comments that are misplaced or no longer relevant.
4619
4620 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4621
4622 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4623
4624 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4625
4626 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4627 and background color parameters if they have been changed.
4628
4629 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4630
4631 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4632
4633 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4634
4635 * xsettings.c (SYSTEM_FONT): Define only when used.
4636 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4637
4638 * keymap.c (access_keymap_1): Now static.
4639
4640 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4641
4642 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4643 leave any prefix arg for the up event (Bug#1586).
4644
4645 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4646
4647 * lread.c (syms_of_lread): Mention single symbols defined by
4648 `defvar' or `defconst' (bug#7154).
4649
4650 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4651 (Frequire): Mention get-load-suffixes.
4652
4653 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4654
4655 * window.h (window): Remove clone_number slot.
4656 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4657 Remove.
4658 (make_parent_window, make_window, saved_window)
4659 (Fset_window_configuration, save_window_save): Don't deal with
4660 clone numbers.
4661 * buffer.c (Qclone_number): Remove declaration.
4662 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4663
4664 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4665
4666 Add multiple inheritance to keymaps.
4667 * keymap.c (Fmake_composed_keymap): New function.
4668 (Fset_keymap_parent): Simplify.
4669 (fix_submap_inheritance): Remove.
4670 (access_keymap_1): New function extracted from access_keymap to handle
4671 embedded parents and handle lists of maps.
4672 (access_keymap): Use it.
4673 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4674 (Fcopy_keymap): Handle embedded parents.
4675 (Fcommand_remapping, define_as_prefix): Simplify.
4676 (Fkey_binding): Simplify.
4677 (syms_of_keymap): Move minibuffer-local-completion-map,
4678 minibuffer-local-filename-completion-map,
4679 minibuffer-local-must-match-map, and
4680 minibuffer-local-filename-must-match-map to Elisp.
4681 (syms_of_keymap): Defsubr make-composed-keymap.
4682 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4683 (parse_menu_item): Trivial simplification.
4684
4685 2011-07-01 Glenn Morris <rgm@gnu.org>
4686
4687 * Makefile.in (SETTINGS_LIBS): Fix typo.
4688
4689 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4690
4691 * coding.c (Fencode_coding_string): Record the last coding system
4692 used, as the function doc string says (bug#8738).
4693
4694 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4695
4696 * xsettings.c (store_monospaced_changed): Take new font as arg and
4697 check for change against current_mono_font.
4698 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4699 (emacs_settings_constructor, emacs_settings_get_property)
4700 (emacs_settings_set_property, emacs_settings_class_init)
4701 (emacs_settings_init, gsettings_obj): Remove.
4702 (something_changedCB): New function for HAVE_GSETTINGS.
4703 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4704 with value as argument.
4705 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4706 g_settings_new (Bug#8967). Do not create gsettings_obj.
4707 Remove calls to g_settings_bind. Connect something_changedCB to
4708 "changed".
4709
4710 * xgselect.c: Add defined (HAVE_GSETTINGS).
4711 (xgselect_initialize): Ditto.
4712
4713 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4714 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4715 xg_select.
4716
4717 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4718
4719 * eval.c (struct backtrace): Simplify and port the data structure.
4720 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4721 signed bit field, as this assumption is not portable and it makes
4722 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4723 "char debug_on_exit : 1" as this is not portable either; instead,
4724 use the portable "unsigned int debug_on_exit : 1". Remove unused
4725 member evalargs. Remove obsolete comments about cc bombing out.
4726
4727 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4728
4729 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4730 Let HAVE_GSETTINGS override HAVE_GCONF.
4731 (store_monospaced_changed): New function.
4732 (EMACS_SETTINGS): A new type derived from GObject to handle
4733 GSettings notifications.
4734 (emacs_settings_constructor, emacs_settings_get_property)
4735 (emacs_settings_set_property, emacs_settings_class_init):
4736 New functions.
4737 (gsettings_client, gsettings_obj): New variables.
4738 (GSETTINGS_SCHEMA): New define.
4739 (something_changedCB): Call store_monospaced_changed.
4740 (init_gsettings): New function.
4741 (xsettings_initialize): Call init_gsettings.
4742 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4743 to NULL.
4744
4745 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4746 GCONF_CFLAGS/LIBS.
4747
4748 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4749
4750 * window.c (resize_root_window, grow_mini_window)
4751 (shrink_mini_window): Rename Qresize_root_window to
4752 Qwindow_resize_root_window and Qresize_root_window_vertically to
4753 Qwindow_resize_root_window_vertically.
4754
4755 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4756
4757 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4758
4759 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4760
4761 * makefile.w32-in: Redesign dependencies so they reflect more
4762 clearly which files are directly included by each source file,
4763 and not through other includes.
4764
4765 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4766
4767 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4768 (sort_overlays, overlay_strings): When an overlay's clone number
4769 matches the window's clone number process the overlay even if
4770 the overlay's window property doesn't match the current window.
4771
4772 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4773 (Fwindow_hchild): Rename to Fwindow_left_child.
4774 (Fwindow_next): Rename to Fwindow_next_sibling.
4775 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4776 (resize_window_check): Rename to window_resize_check.
4777 (resize_window_apply): Rename to window_resize_apply.
4778 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4779 (Fdelete_other_windows_internal, resize_frame_windows)
4780 (Fsplit_window_internal, Fdelete_window_internal)
4781 (grow_mini_window, shrink_mini_window)
4782 (Fresize_mini_window_internal): Fix callers accordingly.
4783
4784 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4785
4786 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4787 (emacs_fixed_set_min_size): Remove.
4788 (emacs_fixed_new): Take frame as argument.
4789
4790 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4791 (_EmacsFixedPrivate): Remove minwidth/height.
4792 Add struct frame *f.
4793 (emacs_fixed_init): Initialize priv->f.
4794 (get_parent_class, emacs_fixed_set_min_size): Remove.
4795 (emacs_fixed_new): Set priv->f to argument.
4796 (emacs_fixed_get_preferred_width)
4797 (emacs_fixed_get_preferred_height): Use min_width/height from
4798 frames size_hint to set minimum and natural (Bug#8919).
4799 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4800 and use min_width/height from frames size_hint to set
4801 min_width/height (Bug#8919).
4802
4803 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4804 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4805 Fix indentation.
4806
4807 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4808
4809 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4810 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4811 called at ZV.
4812
4813 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4814
4815 * process.c (wait_reading_process_output): Bypass select if
4816 waiting for a cell while ignoring keyboard input, and input is
4817 pending. Suggested by Jan Djärv (Bug#8869).
4818
4819 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4820
4821 Use gnulib's dup2 module instead of rolling our own.
4822 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4823
4824 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4825
4826 * dispnew.c (scrolling_window): Before scrolling, turn off a
4827 mouse-highlight in the window being scrolled.
4828
4829 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4830
4831 Move DEFSYM to lisp.h and use everywhere.
4832
4833 * character.h (DEFSYM): Move declaration...
4834 * lisp.h (DEFSYM): ...here.
4835
4836 * gnutls.c:
4837 * minibuf.c:
4838 * w32menu.c:
4839 * w32proc.c:
4840 * w32select.c: Don't include character.h.
4841
4842 * alloc.c (syms_of_alloc):
4843 * buffer.c (syms_of_buffer):
4844 * bytecode.c (syms_of_bytecode):
4845 * callint.c (syms_of_callint):
4846 * casefiddle.c (syms_of_casefiddle):
4847 * casetab.c (init_casetab_once):
4848 * category.c (init_category_once, syms_of_category):
4849 * ccl.c (syms_of_ccl):
4850 * cmds.c (syms_of_cmds):
4851 * composite.c (syms_of_composite):
4852 * dbusbind.c (syms_of_dbusbind):
4853 * dired.c (syms_of_dired):
4854 * dispnew.c (syms_of_display):
4855 * doc.c (syms_of_doc):
4856 * editfns.c (syms_of_editfns):
4857 * emacs.c (syms_of_emacs):
4858 * eval.c (syms_of_eval):
4859 * fileio.c (syms_of_fileio):
4860 * fns.c (syms_of_fns):
4861 * frame.c (syms_of_frame):
4862 * fringe.c (syms_of_fringe):
4863 * insdel.c (syms_of_insdel):
4864 * keymap.c (syms_of_keymap):
4865 * lread.c (init_obarray, syms_of_lread):
4866 * macros.c (syms_of_macros):
4867 * msdos.c (syms_of_msdos):
4868 * print.c (syms_of_print):
4869 * process.c (syms_of_process):
4870 * search.c (syms_of_search):
4871 * sound.c (syms_of_sound):
4872 * syntax.c (init_syntax_once, syms_of_syntax):
4873 * terminal.c (syms_of_terminal):
4874 * textprop.c (syms_of_textprop):
4875 * undo.c (syms_of_undo):
4876 * w32.c (globals_of_w32):
4877 * window.c (syms_of_window):
4878 * xdisp.c (syms_of_xdisp):
4879 * xfaces.c (syms_of_xfaces):
4880 * xfns.c (syms_of_xfns):
4881 * xmenu.c (syms_of_xmenu):
4882 * xsettings.c (syms_of_xsettings):
4883 * xterm.c (syms_of_xterm): Use DEFSYM.
4884
4885 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4886
4887 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4888
4889 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4890
4891 Integer and buffer overflow fixes (Bug#8873).
4892
4893 * print.c (printchar, strout): Check for string overflow.
4894 (PRINTPREPARE, printchar, strout):
4895 Don't set size unless allocation succeeds.
4896
4897 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4898 for sizes. Check for string overflow more accurately.
4899 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4900
4901 * macros.c: Integer and buffer overflow fixes.
4902 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4903 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4904 Use ptrdiff_t, not int, for sizes.
4905 Don't increment bufsize until after realloc succeeds.
4906 Check for size-calculation overflow.
4907 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4908
4909 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4910
4911 * lread.c: Integer overflow fixes.
4912 (read_integer): Radix is now EMACS_INT, not int,
4913 to improve quality of diagnostics for out-of-range radices.
4914 Calculate buffer size correctly for out-of-range radices.
4915 (read1): Check for integer overflow in radices, and in
4916 read-circle numbers.
4917 (read_escape): Avoid int overflow.
4918 (Fload, openp, read_buffer_size, read1)
4919 (substitute_object_recurse, read_vector, read_list, map_obarray):
4920 Use ptrdiff_t, not int, for sizes.
4921 (read1): Use EMACS_INT, not int, for sizes.
4922 Check for size overflow.
4923
4924 * image.c (cache_image): Check for size arithmetic overflow.
4925
4926 * lread.c: Integer overflow issues.
4927 (saved_doc_string_size, saved_doc_string_length)
4928 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4929 Now ptrdiff_t, not int.
4930 (read1): Don't assume doc string length fits in int. Check for
4931 out-of-range doc string lengths.
4932 (read_list): Don't assume file position fits in int.
4933 (read_escape): Check for hex character overflow.
4934
4935 2011-06-22 Leo Liu <sdl.web@gmail.com>
4936
4937 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4938 Move to minibuffer.el.
4939
4940 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4941
4942 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4943 The following patches are for when GLYPH_DEBUG && !XASSERT.
4944 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4945 * dispnew.c (flush_stdout):
4946 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4947 Mark as externally visible.
4948 * dispnew.c (check_window_matrix_pointers): Now static.
4949 * dispnew.c (window_to_frame_vpos):
4950 * xfns.c (unwind_create_frame):
4951 * xterm.c (x_check_font): Remove unused local.
4952 * scroll.c (CHECK_BOUNDS):
4953 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4954 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4955 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4956 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4957 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4958 Now static.
4959 (debug_method_add): Use va_list and vsprintf rather than relying
4960 on undefined behavior with wrong number of arguments.
4961 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4962 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4963 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4964 since we're not interested in debugging glyphs with old libraries.
4965 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4966 GCC 4.6.0's static checking.
4967
4968 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4969
4970 Integer overflow and signedness fixes (Bug#8873).
4971 A few related buffer overrun fixes, too.
4972
4973 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4974
4975 * dispextern.h (struct face.stipple):
4976 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4977 (x_bitmap_mask, x_allocate_bitmap_record)
4978 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4979 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4980 (x_create_bitmap_from_xpm_data):
4981 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4982 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4983 (.bitmaps_last):
4984 * xfaces.c (load_pixmap):
4985 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4986 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4987 (.bitmaps_last, struct x_output.icon_bitmap):
4988 Use ptrdiff_t, not int, for bitmap indexes.
4989 (x_allocate_bitmap_record): Check for size overflow.
4990 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4991
4992 Use ptrdiff_t, not int, for overlay counts.
4993 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4994 * editfns.c (overlays_around, get_pos_property):
4995 * textprop.c (get_char_property_and_overlay):
4996 * xdisp.c (next_overlay_change, note_mouse_highlight):
4997 * xfaces.c (face_at_buffer_position):
4998 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4999 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5000 (Fnext_overlay_change, Fprevious_overlay_change)
5001 (mouse_face_overlay_overlaps, Foverlays_in):
5002 Use ptrdiff_t, not int, for sizes.
5003 (overlays_at, overlays_in): Check for size-calculation overflow.
5004
5005 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5006
5007 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5008 (x_session_initialize): Do not assume string length fits in int.
5009
5010 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5011 This is unlikely, but can occur if DPI is outlandish.
5012
5013 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5014 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5015
5016 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5017 * xrdb.c (magic_file_p, search_magic_path):
5018 Omit last arg SUFFIX; it was always 0. All callers changed.
5019 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5020
5021 * xfont.c (xfont_match): Avoid need for strlen.
5022
5023 * xfns.c: Don't assume strlen fits in int.
5024 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5025
5026 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5027 not unsigned long, as we prefer signed integers. All callers changed.
5028 Detect integer overflow in repeat count.
5029 (message_dolog): Don't assume print length fits in 39 bytes.
5030 (display_mode_element): Don't assume strlen fits in int.
5031
5032 * termcap.c: Don't assume sizes fit in int and never overflow.
5033 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5034 (gobble_line): Check for size-calculation overflow.
5035
5036 * minibuf.c (Fread_buffer):
5037 * lread.c (intern, intern_c_string):
5038 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5039 Don't assume string length fits in int.
5040
5041 * keyboard.c (parse_tool_bar_item):
5042 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5043
5044 * font.c: Don't assume string length fits in int.
5045 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5046 Use ptrdiff_t, not int.
5047 (font_intern_prop): Don't assume string length fits in int.
5048 Don't assume integer property fits in fixnum.
5049 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5050
5051 * filelock.c: Fix some buffer overrun and integer overflow issues.
5052 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5053 Reformulate so as not to need the command string.
5054 Invoke gzip -cd rather than gunzip, as it's more portable.
5055 (lock_info_type, lock_file_1, lock_file):
5056 Don't assume pid_t and time_t fit in unsigned long.
5057 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5058 (current_lock_owner): Prefer signed type for sizes.
5059 Use memcpy, not strncpy, where memcpy is what is really wanted.
5060 Don't assume (via atoi) that time_t and pid_t fit in int.
5061 Check for time_t and/or pid_t out of range, e.g., via a network share.
5062 Don't alloca where an auto var works fine.
5063
5064 * fileio.c: Fix some integer overflow issues.
5065 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5066 Don't assume string length fits in int.
5067 (directory_file_name): Don't assume string length fits in long.
5068 (make_temp_name): Don't assume pid fits in int, or that its print
5069 length is less than 20.
5070
5071 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5072
5073 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5074
5075 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5076
5077 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5078 We prefer signed integers, even for size calculations.
5079
5080 * emacs.c: Don't assume string length fits in 'int'.
5081 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5082 (main): Don't invoke strlen when not needed.
5083
5084 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5085 (XD_DEBUG_MESSAGE): Don't waste a byte.
5086
5087 * callproc.c (getenv_internal_1, getenv_internal)
5088 (Fgetenv_internal):
5089 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5090
5091 * lread.c (invalid_syntax): Omit length argument.
5092 All uses changed. This doesn't fix a bug, but it simplifies the
5093 code away from its former Hollerith-constant appearance, and it's
5094 one less 'int' to worry about when looking at integer-overflow issues.
5095 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5096
5097 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5098 This didn't break anything, but it didn't help either.
5099 It's confusing to put a bogus integer in a place where the actual
5100 value does not matter.
5101 (LIST_END_P): Remove unused macro and its bogus comment.
5102 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5103
5104 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5105 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5106 implementation.
5107 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5108 We prefer signed types, and the value cannot exceed the EMACS_INT
5109 range anyway (because otherwise the length would not be representable).
5110 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5111 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5112 This avoids a GCC warning when WIDE_EMACS_INT.
5113
5114 * indent.c (sane_tab_width): New function.
5115 (current_column, scan_for_column, Findent_to, position_indentation)
5116 (compute_motion): Use it. This is just for clarity.
5117 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5118
5119 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5120
5121 * lisp.h (lint_assume): New macro.
5122 * composite.c (composition_gstring_put_cache):
5123 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5124
5125 * editfns.c, insdel.c:
5126 Omit unnecessary forward decls, to simplify future changes.
5127
5128 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5129
5130 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5131
5132 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5133 Use much-faster test for byte-length change.
5134 Don't assume string byte-length fits in 'int'.
5135 Check that character arg fits in 'int'.
5136 (mapcar1): Declare byte as byte, for clarity.
5137
5138 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5139
5140 * fns.c (concat): Catch string overflow earlier.
5141 Do not rely on integer wraparound.
5142
5143 * dispextern.h (struct it.overlay_strings_charpos)
5144 (struct it.selective): Now EMACS_INT, not int.
5145 * xdisp.c (forward_to_next_line_start)
5146 (back_to_previous_visible_line_start)
5147 (reseat_at_next_visible_line_start, next_element_from_buffer):
5148 Don't arbitrarily truncate the value of 'selective' to int.
5149
5150 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5151
5152 * composite.c: Don't truncate sizes to 'int'.
5153 (composition_gstring_p, composition_reseat_it)
5154 (composition_adjust_point): Use EMACS_INT, not int.
5155 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5156 not EMACS_UINT, for indexes.
5157
5158 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5159
5160 * buffer.c: Include <verify.h>.
5161 (struct sortvec.priority, struct sortstr.priority):
5162 Now EMACS_INT, not int.
5163 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5164 (struct sortstr.size, record_overlay_string)
5165 (struct sortstrlist.size, struct sortlist.used):
5166 Don't truncate size to int.
5167 (record_overlay_string): Check for size-calculation overflow.
5168 (init_buffer_once): Check at compile-time, not run-time.
5169
5170 2011-06-22 Jim Meyering <meyering@redhat.com>
5171
5172 Don't leak an XBM-image-sized buffer
5173 * image.c (xbm_load): Free the image buffer after using it.
5174
5175 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5176
5177 Port to Sun C.
5178 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5179 that Sun C diagnosed.
5180 * fns.c (secure_hash): Fix pointer signedness issue.
5181 * intervals.c (static_offset_intervals): New function.
5182 (offset_intervals): Use it.
5183
5184 2011-06-21 Leo Liu <sdl.web@gmail.com>
5185
5186 * deps.mk (fns.o):
5187 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5188 sha512.h.
5189
5190 * fns.c (secure_hash): Rename from crypto_hash_function and change
5191 the first arg to accept symbols.
5192 (Fsecure_hash): New primitive.
5193 (syms_of_fns): New symbols.
5194
5195 2011-06-20 Deniz Dogan <deniz@dogan.se>
5196
5197 * process.c (Fset_process_buffer): Clarify return value in
5198 docstring.
5199
5200 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5201
5202 * dispnew.c (add_window_display_history): Use BVAR.
5203
5204 * xdisp.c (debug_method_add): Use BVAR.
5205 (check_window_end, dump_glyph_matrix, dump_glyph)
5206 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5207
5208 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5209 Likewise.
5210
5211 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5212 check till after the cache is created in init_frame_faces.
5213
5214 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5215
5216 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5217
5218 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5219
5220 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5221 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5222 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5223
5224 Improve buffer-overflow checking (Bug#8873).
5225 * fileio.c (Finsert_file_contents):
5226 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5227 Remove the old (too-loose) buffer overflow checks.
5228 They weren't needed, since make_gap checks for buffer overflow.
5229 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5230 The old code merely checked for Emacs fixnum overflow, and relied
5231 on undefined (wraparound) behavior. The new code avoids undefined
5232 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5233
5234 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5235 Tune. Don't use wider integers than needed. Don't use alloca.
5236 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5237
5238 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5239
5240 * insdel.c, lisp.h (buffer_overflow): New function.
5241 (insert_from_buffer_1, replace_range, replace_range_2):
5242 * insdel.c (make_gap_larger):
5243 * editfns.c (Finsert_char):
5244 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5245
5246 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5247
5248 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5249
5250 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5251
5252 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5253 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5254
5255 * fileio.c: Don't assume EMACS_INT fits in off_t.
5256 (emacs_lseek): New static function.
5257 (Finsert_file_contents, Fwrite_region): Use it.
5258 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5259
5260 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5261
5262 * fns.c: Don't overflow int when computing a list length.
5263 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5264 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5265 truncation on 64-bit hosts. Check for QUIT every
5266 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5267 faster and is responsive enough.
5268 (Flength): Report an error instead of overflowing an integer.
5269 (Fsafe_length): Return a float if the value is not representable
5270 as a fixnum. This shouldn't happen except in contrived situations.
5271 (Fnthcdr, Fsort): Don't assume list length fits in int.
5272 (Fcopy_sequence): Don't assume vector length fits in int.
5273
5274 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5275 (header_size, word_size): New constants.
5276 (allocate_vectorlike): Don't check size overflow here.
5277 (allocate_vector): Check it here instead, since this is the only
5278 caller of allocate_vectorlike that could cause overflow.
5279 Check that the new vector's length is representable as a fixnum.
5280
5281 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5282 The previous code was bogus. For example, next_almost_prime (32)
5283 returned 39, which is undesirable as it is a multiple of 3; and
5284 next_almost_prime (24) returned 25, which is a multiple of 5 so
5285 why was the code bothering to check for multiples of 7?
5286
5287 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5288
5289 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5290
5291 Variadic C functions now count arguments with ptrdiff_t.
5292 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5293 Back then I didn't know that the Emacs coding style prefers signed int.
5294 Also, in the meantime I found a few more instances where arguments
5295 were being counted with int, which may truncate counts on 64-bit
5296 machines, or EMACS_INT, which may be unnecessarily wide.
5297 * lisp.h (struct Lisp_Subr.function.aMANY)
5298 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5299 Arg counts are now ptrdiff_t, not size_t.
5300 All variadic functions and their callers changed accordingly.
5301 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5302 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5303 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5304 * callint.c (Fcall_interactively): Check arg count for overflow,
5305 to avoid potential buffer overrun. Use signed char, not 'int',
5306 for 'varies' array, so that we needn't bother to check its size
5307 calculation for overflow.
5308 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5309 * eval.c (apply_lambda):
5310 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5311 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5312 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5313
5314 * callint.c (Fcall_interactively): Don't use index var as event count.
5315
5316 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5317 * mem-limits.h (SIZE): Remove; no longer used.
5318
5319 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5320
5321 Remove unnecessary casts.
5322 * xterm.c (x_term_init):
5323 * xfns.c (x_set_border_pixel):
5324 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5325 These aren't needed now that we assume ANSI C.
5326
5327 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5328 It's more likely to cause problems (due to unsigned overflow)
5329 than to cure them.
5330
5331 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5332
5333 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5334
5335 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5336
5337 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5338
5339 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5340
5341 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5342
5343 GLYPH_CODE_FACE returns EMACS_INT, not int.
5344 * dispextern.h (merge_faces):
5345 * xfaces.c (merge_faces):
5346 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5347 Don't assume EMACS_INT fits in int.
5348
5349 * character.h (CHAR_VALID_P): Remove unused parameter.
5350 * fontset.c, lisp.h, xdisp.c: All uses changed.
5351
5352 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5353
5354 * fns.c (concat): Minor tuning based on overflow analysis.
5355 This doesn't fix any bugs. Use int to hold character, instead
5356 of constantly refetching from Emacs object. Use XFASTINT, not
5357 XINT, for value known to be a character. Don't bother comparing
5358 a single byte to 0400, as it's always less.
5359
5360 * floatfns.c (Fexpt):
5361 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5362
5363 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5364 for characters.
5365
5366 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5367
5368 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5369 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5370 incorrectly succeed when S was a string, because 4294967386 was
5371 truncated before it was used.
5372
5373 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5374 Otherwise, an out-of-range integer could cause undefined behavior
5375 on a 64-bit host.
5376
5377 * composite.c: Use int, not EMACS_INT, for characters.
5378 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5379 EMACS_INT, for values that are known to be in character range.
5380 This doesn't fix any bugs but is the usual style inside Emacs and
5381 may generate better code on 32-bit machines.
5382
5383 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5384 This is for reasons similar to the recent CHAR_STRING fix.
5385 * charset.c (Fencode_char): Check that character arg is actually
5386 a character. Pass an int to ENCODE_CHAR.
5387 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5388 wider than 'int', as a compile-time check to prevent future regressions
5389 in this area.
5390
5391 * character.c (char_string): Remove unnecessary casts.
5392
5393 Make sure a 64-bit char is never passed to CHAR_STRING.
5394 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5395 by silently ignoring the top 32 bits, allowing some values
5396 that were far too large to be valid characters.
5397 * character.h: Include <verify.h>.
5398 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5399 arguments are no wider than unsigned, as a compile-time check
5400 to prevent future regressions in this area.
5401 * data.c (Faset):
5402 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5403 (Fsubst_char_in_region):
5404 * fns.c (concat):
5405 * xdisp.c (decode_mode_spec_coding):
5406 Adjust to CHAR_STRING's new requirement.
5407 * editfns.c (Finsert_char, Fsubst_char_in_region):
5408 * fns.c (concat): Check that character args are actually
5409 characters. Without this test, these functions did the wrong
5410 thing with wildly out-of-range values on 64-bit hosts.
5411
5412 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5413 These casts should not be needed on 32-bit hosts, either.
5414 * keyboard.c (read_char):
5415 * lread.c (Fload): Remove casts to unsigned.
5416
5417 * lisp.h (UNSIGNED_CMP): New macro.
5418 This fixes comparison bugs on 64-bit hosts.
5419 (ASCII_CHAR_P): Use it.
5420 * casefiddle.c (casify_object):
5421 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5422 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5423 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5424 * dispextern.h (FACE_FROM_ID):
5425 * keyboard.c (read_char): Use UNSIGNED_CMP.
5426
5427 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5428 not to EMACS_INT, to avoid GCC warning.
5429
5430 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5431
5432 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5433 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5434 isn't needed on 32-bit machines.
5435
5436 * buffer.c (Fgenerate_new_buffer_name):
5437 Use EMACS_INT for count, not int.
5438 (advance_to_char_boundary): Return EMACS_INT, not int.
5439
5440 * data.c (Qcompiled_function): Now static.
5441
5442 * window.c (window_body_lines): Now static.
5443
5444 * image.c (gif_load): Rename local to avoid shadowing.
5445
5446 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5447 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5448 * alloc.c (make_save_value): Integer argument is now of type
5449 ptrdiff_t, not int.
5450 (mark_object): Use ptrdiff_t, not int.
5451 * lisp.h (pD): New macro.
5452 * print.c (print_object): Use it.
5453
5454 * alloc.c: Use EMACS_INT, not int, to count objects.
5455 (total_conses, total_markers, total_symbols, total_vector_size)
5456 (total_free_conses, total_free_markers, total_free_symbols)
5457 (total_free_floats, total_floats, total_free_intervals)
5458 (total_intervals, total_strings, total_free_strings):
5459 Now EMACS_INT, not int. All uses changed.
5460 (Fgarbage_collect): Compute overall total using a double, so that
5461 integer overflow is less likely to be a problem. Check for overflow
5462 when converting back to an integer.
5463 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5464 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5465 These were 'int' variables that could overflow on 64-bit hosts;
5466 they were never used, so remove them instead of repairing them.
5467 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5468 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5469 Previously, this ceilinged at INT_MAX, but that doesn't work on
5470 64-bit machines.
5471 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5472
5473 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5474 (allocate_vectorlike): Check for ptrdiff_t overflow.
5475 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5476 when a (possibly-narrower) signed value would do just as well.
5477 We prefer using signed arithmetic, to avoid comparison confusion.
5478
5479 * alloc.c: Catch some string size overflows that we were missing.
5480 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5481 for convenience in STRING_BYTES_MAX.
5482 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5483 The definition here is exact; the one in lisp.h was approximate.
5484 (allocate_string_data): Check for string overflow. This catches
5485 some instances we weren't catching before. Also, it catches
5486 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5487 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5488 and ptrdiff_t and EMACS_INT are both 64 bits.
5489
5490 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5491 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5492 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5493
5494 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5495
5496 * alloc.c (Fmake_string): Check for out-of-range init.
5497
5498 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5499
5500 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5501
5502 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5503
5504 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5505 xg_get_default_scrollbar_width.
5506
5507 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5508 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5509 (style_changed_cb): Call update_theme_scrollbar_width and call
5510 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5511 all frames (Bug#8505).
5512 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5513 Call gtk_window_set_resizable if HAVE_GTK3.
5514 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5515 and height if HAVE_GTK3 (Bug#8505).
5516 (scroll_bar_width_for_theme): New variable.
5517 (update_theme_scrollbar_width): New function.
5518 (xg_get_default_scrollbar_width): Move code to
5519 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5520 (xg_initialize): Call update_theme_scrollbar_width.
5521
5522 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5523
5524 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5525
5526 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5527
5528 * frame.c (make_frame): Call other_buffer_safely instead of
5529 other_buffer.
5530
5531 * window.c (temp_output_buffer_show): Call display_buffer with
5532 second argument Vtemp_buffer_show_specifiers and reset latter
5533 immediately after the call.
5534 (Vtemp_buffer_show_specifiers): New variable.
5535 (auto_window_vscroll_p, next_screen_context_lines)
5536 (Vscroll_preserve_screen_position): Remove leading asterisks from
5537 doc-strings.
5538
5539 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5540
5541 Fix minor problems found by GCC 4.6.0 static checking.
5542 * buffer.c (Qclone_number): Remove for now, as it's unused.
5543 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5544 (record_buffer): Remove unused local.
5545 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5546 (set_frame_buffer_list): Remove; unused.
5547 * frame.h (other_visible_frames): Remove decl.
5548 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5549 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5550 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5551 if HAVE_GPM.
5552 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5553 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5554 Define only if HAVE_GPM.
5555 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5556 (update_hints_inhibit): Remove; never set. All uses removed.
5557 * widgetprv.h (emacsFrameClassRec): Remove decl.
5558 * window.c (delete_deletable_window): Now returns void, since it
5559 wasn't returning anything.
5560 (compare_window_configurations): Remove unused locals.
5561 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5562 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5563 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5564 the same widths as pointers. This follows up on the 2011-05-06 patch.
5565 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5566 * xterm.h: Likewise.
5567 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5568
5569 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5570
5571 * makefile.w32-in: Update dependencies.
5572 (LISP_H): Add lib/intprops.h.
5573
5574 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5575
5576 * image.c (gif_load): Add animation frame delay to the metadata.
5577 (syms_of_image): Use DEFSYM. New symbol `delay'.
5578
5579 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5580
5581 * window.c (delete_deletable_window): Re-add.
5582 (Fset_window_configuration): Rewrite to handle dead buffers and
5583 consequently deletable windows.
5584 (window_tree, Fwindow_tree): Remove. Supply functionality in
5585 window.el.
5586 (compare_window_configurations): Simplify code.
5587
5588 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5589
5590 * image.c (imagemagick_load_image): Fix type mismatch.
5591 (Fimagemagick_types): Likewise.
5592
5593 * window.h (replace_buffer_in_windows): Declare.
5594
5595 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5596
5597 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5598 Qclone_number. Remove external declaration of Qdelete_window.
5599 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5600 code.
5601 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5602 Run Qbuffer_list_update_hook if allowed.
5603 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5604 buffer list implementation.
5605 (other_buffer_safely): New function.
5606 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5607 calls to replace_buffer_in_windows and
5608 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5609 if allowed.
5610 (record_buffer): Inhibit quitting and rewrite using quittable
5611 functions. Run Qbuffer_list_update_hook if allowed.
5612 (Frecord_buffer, Funrecord_buffer): New functions.
5613 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5614 Move switch-to-buffer to window.el.
5615 (bury-buffer): Move to window.el.
5616 (Vbuffer_list_update_hook): New variable.
5617
5618 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5619 section.
5620
5621 * window.h (resize_frame_windows): Move up in code.
5622 (Fwindow_frame): Remove EXFUN.
5623 (replace_buffer_in_all_windows): Remove prototype.
5624 (replace_buffer_in_windows_safely): Add prototype.
5625
5626 * window.c: Declare Qdelete_window static again. Move down
5627 declaration of select_count.
5628 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5629 (Fother_window): Move to window.el.
5630 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5631 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5632 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5633 window.el.
5634 (replace_buffer_in_windows): Implement by calling
5635 Qreplace_buffer_in_windows.
5636 (replace_buffer_in_all_windows): Remove with some functionality
5637 moved into replace_buffer_in_windows_safely.
5638 (replace_buffer_in_windows_safely): New function.
5639 (select_window_norecord, select_frame_norecord): Move in front
5640 of run_window_configuration_change_hook. Remove now obsolete
5641 declarations.
5642 (Fset_window_buffer): Rewrite doc-string.
5643 Call Qrecord_window_buffer.
5644 (keys_of_window): Move binding for other-window to window.el.
5645
5646 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5647
5648 * dispextern.h (struct image): Replace data member, whose int_val
5649 and ptr_val fields were not used by anything, with a single
5650 lisp_val object.
5651
5652 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5653 (gif_clear_image, gif_load, imagemagick_load_image)
5654 (gs_clear_image, gs_load): Callers changed.
5655
5656 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5657
5658 * buffer.h: Include <time.h>, for time_t.
5659 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5660
5661 Fix minor problems found by static checking.
5662
5663 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5664
5665 Make identifiers static if they are not used in other modules.
5666 * data.c (Qcompiled_function, Qframe, Qvector):
5667 * image.c (QimageMagick, Qsvg):
5668 * minibuf.c (Qmetadata):
5669 * window.c (resize_window_check, resize_root_window): Now static.
5670 * window.h (resize_window_check, resize_root_window): Remove decls.
5671
5672 * window.c (window_deletion_count, delete_deletable_window):
5673 Remove; unused.
5674 (window_body_lines): Now static.
5675 (Fdelete_other_windows_internal): Mark vars as initialized.
5676 Make sure 'resize_failed' is initialized.
5677 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5678 (resize_window_apply): Remove unused local.
5679 * window.h (delete_deletable_window): Remove decl.
5680
5681 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5682 (imagemagick_load_image): Fix pointer signedness problem by changing
5683 last arg from unsigned char * to char *. All uses changed.
5684 Also, fix a local for similar reasons.
5685 Remove unused locals. Remove locals to avoid shadowing.
5686 (fn_rsvg_handle_free): Remove; unused.
5687 (svg_load, svg_load_image): Fix pointer signedness problem.
5688 (imagemagick_load_image): Don't use garbage pointer image_wand.
5689
5690 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5691
5692 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5693
5694 * image.c (gif_load): Fix omitted cast error introduced by
5695 2011-06-06 change.
5696
5697 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5698
5699 * window.h (resize_proportionally, orig_total_lines)
5700 (orig_top_line): Remove from window structure.
5701 (set_window_height, set_window_width, change_window_heights)
5702 (Fdelete_window): Remove prototypes.
5703 (resize_frame_windows): Remove duplicate declaration.
5704
5705 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5706
5707 * window.h (resize_frame_windows, resize_window_check)
5708 (delete_deletable_window, resize_root_window)
5709 (resize_frame_windows): Declare prototypes.
5710
5711 * window.c (resize_window_apply): Make definition be "static" to
5712 match the prototype.
5713
5714 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5715
5716 * window.c: Remove declarations of Qwindow_size_fixed,
5717 window_min_size_1, window_min_size_2, window_min_size,
5718 size_window, window_fixed_size_p, enlarge_window, delete_window.
5719 Remove static from declaration of Qdelete_window, it's
5720 temporarily needed by Fbury_buffer.
5721 (replace_window): Don't assign orig_top_line and
5722 orig_total_lines.
5723 (Fdelete_window, delete_window): Remove. Window deletion is
5724 handled by window.el.
5725 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5726 Replace Fdelete_window calls with calls to Qdelete_window.
5727 (Fdelete_other_windows): Remove. Deleting other windows is
5728 handled by window.el.
5729 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5730 handled in window.el.
5731 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5732 Window minimum sizes are handled in window.el.
5733 (shrink_windows, size_window, set_window_height)
5734 (set_window_width, change_window_heights, window_height)
5735 (window_width, CURBEG, CURSIZE, enlarge_window)
5736 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5737 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5738 handled in window.el.
5739 (make_dummy_parent): Rename to make_parent_window and give it a
5740 second argument horflag.
5741 (make_window): Don't set resize_proportionally any more.
5742 (Fsplit_window): Remove. Windows are split in window.el.
5743 (save_restore_action, save_restore_orig_size)
5744 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5745 Resize mini windows in window.el.
5746 (grow_mini_window, shrink_mini_window): Implement by calling
5747 Qresize_root_window_vertically, resize_window_check and
5748 resize_window_apply.
5749 (saved_window, Fset_window_configuration, save_window_save):
5750 Do not handle orig_top_line, orig_total_lines, and
5751 resize_proportionally.
5752 (window_min_height, window_min_width): Move to window.el.
5753 (keys_of_window): Move bindings for delete-other-windows,
5754 split-window, delete-window and enlarge-window to window.el.
5755
5756 * buffer.c: Temporarily extern Qdelete_window.
5757 (Fbury_buffer): Temporarily call Qdelete_window instead of
5758 Fdelete_window (Fbury_buffer will move to window.el soon).
5759
5760 * frame.c (set_menu_bar_lines_1): Remove code handling
5761 orig_top_line and orig_total_lines.
5762
5763 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5764 set_window_height but set heights directly.
5765 (change_frame_size_1): Use resize_frame_windows.
5766
5767 * xdisp.c (init_xdisp): Don't use set_window_height but set
5768 heights directly.
5769
5770 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5771 Use resize_frame_windows instead of change_window_heights and run
5772 run_window_configuration_change_hook.
5773
5774 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5775 instead of change_window_heights and run
5776 run_window_configuration_change_hook.
5777
5778 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5779
5780 * window.c (replace_window): Rename second argument REPLACEMENT to
5781 NEW. New third argument SETFLAG. Rewrite.
5782 (delete_window, make_dummy_parent): Call replace_window with
5783 third argument 1.
5784 (window_list_1): Move down in code.
5785 (run_window_configuration_change_hook): Move set_buffer part
5786 before select_frame_norecord part in order to unwind correctly.
5787 Rename count1 to count.
5788 (recombine_windows, delete_deletable_window, resize_root_window)
5789 (Fdelete_other_windows_internal)
5790 (Frun_window_configuration_change_hook, make_parent_window)
5791 (resize_window_check, resize_window_apply, Fresize_window_apply)
5792 (resize_frame_windows, Fsplit_window_internal)
5793 (Fdelete_window_internal, Fresize_mini_window_internal):
5794 New functions.
5795 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5796
5797 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5798
5799 * window.h (window): Add some new members to window structure -
5800 normal_lines, normal_cols, new_total, new_normal, clone_number,
5801 splits, nest, prev_buffers, next_buffers.
5802 (WINDOW_TOTAL_SIZE): Move here from window.c.
5803 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5804
5805 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5806 Remove.
5807 (make_dummy_parent): Set new members of windows structure.
5808 (make_window): Move down in code. Handle new members of window
5809 structure.
5810 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5811 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5812 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5813 (Fset_window_prev_buffers, Fwindow_next_buffers)
5814 (Fset_window_next_buffers, Fset_window_clone_number):
5815 New functions.
5816 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5817 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5818 Doc-string fixes.
5819 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5820 Argument WINDOW can be now internal window too.
5821 (Fwindow_use_time): Move up in code.
5822 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5823 Rewrite doc-string.
5824 (Fset_window_configuration, saved_window)
5825 (Fcurrent_window_configuration, save_window_save): Handle new
5826 members of window structure.
5827 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5828 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5829 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5830 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5831 Qget_mru_window, Qresize_root_window,
5832 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5833 Qauto_buffer_name; staticpro them.
5834
5835 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5836
5837 * window.c (Fwindow_total_size, Fwindow_left_column)
5838 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5839 (Fwindow_list_1): New functions.
5840 (window_box_text_cols): Replace with window_body_cols.
5841 (Fwindow_width, Fscroll_left, Fscroll_right):
5842 Use window_body_cols instead of window_box_text_cols.
5843 (delete_window, Fset_window_configuration):
5844 Call delete_all_subwindows with window as argument.
5845 (delete_all_subwindows): Take a window as argument and not a
5846 structure. Rewrite.
5847 (window_loop): Remove handling of GET_LRU_WINDOW and
5848 GET_LARGEST_WINDOW.
5849 (Fget_lru_window, Fget_largest_window): Move to window.el.
5850
5851 * window.h: Extern window_body_cols instead of
5852 window_box_text_cols. delete_all_subwindows now takes a
5853 Lisp_Object as argument.
5854
5855 * indent.c (compute_motion, Fcompute_motion):
5856 Use window_body_cols instead of window_box_text_cols.
5857
5858 * frame.c (delete_frame): Call delete_all_subwindows with root
5859 window as argument.
5860
5861 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5862
5863 * fns.c (Fputhash): Document return value.
5864
5865 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5866
5867 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5868
5869 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5870
5871 Cons<->int and similar integer overflow fixes (Bug#8794).
5872
5873 Check for overflow when converting integer to cons and back.
5874 * charset.c (Fdefine_charset_internal, Fdecode_char):
5875 Use cons_to_unsigned to catch overflow.
5876 (Fencode_char): Use INTEGER_TO_CONS.
5877 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5878 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5879 * data.c (long_to_cons, cons_to_long): Remove.
5880 (cons_to_unsigned, cons_to_signed): New functions.
5881 These signal an error for invalid or out-of-range values.
5882 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5883 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5884 * font.c (Ffont_variation_glyphs):
5885 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5886 * lisp.h: Include <intprops.h>.
5887 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5888 (cons_to_signed, cons_to_unsigned): New decls.
5889 (long_to_cons, cons_to_long): Remove decls.
5890 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5891 (Fprimitive_undo): Use CONS_TO_INTEGER.
5892 * xfns.c (Fx_window_property): Likewise.
5893 * xselect.c: Include <limits.h>.
5894 (x_own_selection, selection_data_to_lisp_data):
5895 Use INTEGER_TO_CONS.
5896 (x_handle_selection_request, x_handle_selection_clear)
5897 (x_get_foreign_selection, Fx_disown_selection_internal)
5898 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5899 (lisp_data_to_selection_data): Use cons_to_unsigned.
5900 (x_fill_property_data): Use cons_to_signed.
5901 Report values out of range.
5902
5903 Check for buffer and string overflow more precisely.
5904 * buffer.h (BUF_BYTES_MAX): New macro.
5905 * lisp.h (STRING_BYTES_MAX): New macro.
5906 * alloc.c (Fmake_string):
5907 * character.c (string_escape_byte8):
5908 * coding.c (coding_alloc_by_realloc):
5909 * doprnt.c (doprnt):
5910 * editfns.c (Fformat):
5911 * eval.c (verror):
5912 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5913 since they may not be the same number.
5914 * editfns.c (Finsert_char):
5915 * fileio.c (Finsert_file_contents):
5916 Likewise for BUF_BYTES_MAX.
5917
5918 * image.c: Use ptrdiff_t, not int, for sizes.
5919 (slurp_file): Switch from int to ptrdiff_t.
5920 All uses changed.
5921 (slurp_file): Check that file size fits in both size_t (for
5922 malloc) and ptrdiff_t (for sanity and safety).
5923
5924 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5925 if b->modtime has its maximal value.
5926
5927 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5928
5929 Don't assume time_t can fit into int.
5930 * buffer.h (struct buffer.modtime): Now time_t, not int.
5931 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5932 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5933
5934 Minor fixes for signed vs unsigned integers.
5935 * character.h (MAYBE_UNIFY_CHAR):
5936 * charset.c (maybe_unify_char):
5937 * keyboard.c (read_char, reorder_modifiers):
5938 XINT -> XFASTINT, since the integer must be nonnegative.
5939 * ftfont.c (ftfont_spec_pattern):
5940 * keymap.c (access_keymap, silly_event_symbol_error):
5941 XUINT -> XFASTINT, since the integer must be nonnegative.
5942 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5943 since it makes no difference and we prefer signed.
5944 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5945 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5946 nonnegative.
5947
5948 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5949
5950 * window.h (Fwindow_frame): Declare.
5951
5952 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5953
5954 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5955 (SPARE_MEMORY): Always define.
5956 (LARGE_REQUEST): Remove.
5957 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5958
5959 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5960
5961 * lisp.h: Move EXFUNS for Fframe_root_window,
5962 Fframe_first_window and Fset_frame_selected_window to window.h.
5963
5964 * window.h: Move EXFUNS for Fframe_root_window,
5965 Fframe_first_window and Fset_frame_selected_window here from
5966 lisp.h.
5967
5968 * frame.c (Fwindow_frame, Fframe_first_window)
5969 (Fframe_root_window, Fframe_selected_window)
5970 (Fset_frame_selected_window): Move to window.c.
5971 (Factive_minibuffer_window): Move to minibuf.c.
5972 (Fother_visible_frames_p): New function.
5973
5974 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5975
5976 * window.c (decode_window, decode_any_window): Move up in code.
5977 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5978 (inhibit_frame_unsplittable): Remove unused variable.
5979 (Fwindow_buffer): Move up and rewrite doc-string.
5980 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5981 (Fwindow_prev): New functions.
5982 (Fwindow_frame): Move here from frame.c. Accept any window as
5983 argument.
5984 (Fframe_root_window, Fframe_first_window)
5985 (Fframe_selected_window): Move here from frame.c. Accept frame
5986 or arbitrary window as argument. Update doc-strings.
5987 (Fminibuffer_window): Move up in code.
5988 (Fwindow_minibuffer_p): Move up in code and simplify.
5989 (Fset_frame_selected_window): Move here from frame.c.
5990 Marginal rewrite.
5991 (Fselected_window, select_window, Fselect_window): Move up in
5992 code. Minor doc-string fixes.
5993
5994 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5995
5996 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5997 Do not assume that spare memory exists; that assumption is valid
5998 only if SYSTEM_MALLOC.
5999 (LARGE_REQUEST): New macro, so that the issue of large requests
6000 is separated from the issue of spare memory.
6001
6002 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6003
6004 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6005 format. (Bug#8806)
6006
6007 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6008
6009 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6010 before statements.
6011
6012 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6013
6014 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6015
6016 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6017
6018 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6019 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6020
6021 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6022
6023 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6024
6025 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6026
6027 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6028 (x_clipboard_manager_save): Add return value.
6029 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6030 New error handlers.
6031 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6032 Obey Vx_select_enable_clipboard_manager. Catch errors in
6033 x_clipboard_manager_save (Bug#8779).
6034 (Vx_select_enable_clipboard_manager): New variable.
6035 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6036
6037 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6038
6039 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6040
6041 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6042
6043 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6044 in the current matrix if keep_current_p is non-zero.
6045
6046 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6047
6048 * bidi.c (bidi_level_of_next_char): Fix last change.
6049
6050 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6051
6052 Support bidi reordering of text covered by display properties.
6053
6054 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6055 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6056 (bidi_cache_search, bidi_cache_iterator_state)
6057 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6058 (bidi_level_of_next_char, bidi_move_to_visually_next):
6059 Support character positions inside a run of characters covered by a
6060 display string.
6061 (bidi_paragraph_init, bidi_resolve_explicit_1)
6062 (bidi_level_of_next_char): Call bidi_fetch_char and
6063 bidi_fetch_char_advance instead of FETCH_CHAR and
6064 FETCH_CHAR_ADVANCE.
6065 (bidi_init_it): Initialize new members.
6066 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6067 definitions.
6068 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6069 instead of using explicit *_CHAR codes.
6070 (bidi_resolve_explicit, bidi_resolve_weak):
6071 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6072 bidirectional text is supported only in multibyte buffers.
6073 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6074 it to initialize the frame_window_p member of struct bidi_it.
6075 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6076 (bidi_resolve_explicit, bidi_resolve_weak)
6077 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6078 bidi_it->nchars is non-positive.
6079 (bidi_level_of_next_char): Don't try to lookup the cache for the
6080 next/previous character if nothing is cached there yet, or if we
6081 were just reseat()'ed to a new position.
6082
6083 * xdisp.c (set_cursor_from_row): Set start and stop points
6084 according to the row's direction when priming the loop that looks
6085 for the glyph on which to display cursor.
6086 (single_display_spec_intangible_p): Function deleted.
6087 (display_prop_intangible_p): Reimplement to call
6088 handle_display_spec instead of single_display_spec_intangible_p.
6089 Accept 3 additional arguments needed by handle_display_spec.
6090 This fixes incorrect cursor motion across display property with complex
6091 values: lists, `(when COND...)' forms, etc.
6092 (single_display_spec_string_p): Support property values that are
6093 lists with the argument STRING its top-level element.
6094 (display_prop_string_p): Fix the condition for processing a
6095 property that is a list to be consistent with handle_display_spec.
6096 (handle_display_spec): New function, refactored from the
6097 last portion of handle_display_prop.
6098 (compute_display_string_pos): Accept additional argument
6099 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6100 value of a `display' property is a "replacing spec".
6101 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6102 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6103 the display property, but just return a value indicating whether
6104 the display property will replace the characters it covers.
6105 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6106 frame_window_p members of struct bidi_it.
6107 (compute_display_string_pos, compute_display_string_end):
6108 New functions.
6109 (push_it): Accept second argument POSITION, where pop_it should
6110 jump to continue iteration.
6111 (reseat_1): Initialize bidi_it.disp_pos.
6112
6113 * keyboard.c (adjust_point_for_property): Adjust the call to
6114 display_prop_intangible_p to its new signature.
6115
6116 * dispextern.h (struct bidi_it): New member frame_window_p.
6117 (bidi_init_it): Update prototypes.
6118 (display_prop_intangible_p): Update prototype.
6119 (compute_display_string_pos, compute_display_string_end):
6120 Declare prototypes.
6121 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6122 EMACS_INT.
6123
6124 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6125
6126 Malloc failure behavior now depends on size of allocation.
6127 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6128 * lisp.h: Change signatures accordingly.
6129 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6130 All callers changed. (Bug#8762)
6131
6132 * gnutls.c: Use Emacs's memory allocators.
6133 Without this change, the gnutls library would invoke malloc etc.
6134 directly, which causes problems on non-SYNC_INPUT hosts, and which
6135 runs afoul of improving memory_full behavior. (Bug#8761)
6136 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6137 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6138 xfree instead of the default malloc, realloc, free.
6139 (Fgnutls_boot): No need to check for memory allocation failure,
6140 since xmalloc does that for us.
6141
6142 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6143 * category.c (hash_get_category_set):
6144 * ccl.c (ccl_driver):
6145 * charset.c (Fdefine_charset_internal):
6146 * charset.h (struct charset.hash_index):
6147 * composite.c (get_composition_id, gstring_lookup_cache)
6148 (composition_gstring_put_cache):
6149 * composite.h (struct composition.hash_index):
6150 * dispextern.h (struct image.hash):
6151 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6152 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6153 (hashfn_equal, hashfn_user_defined, make_hash_table)
6154 (maybe_resize_hash_table, hash_lookup, hash_put)
6155 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6156 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6157 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6158 * image.c (make_image, search_image_cache, lookup_image)
6159 (xpm_put_color_table_h):
6160 * lisp.h (struct Lisp_Hash_Table):
6161 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6162 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6163 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6164 * alloc.c (allocate_vectorlike):
6165 Check for overflow in vector size calculations.
6166 * ccl.c (ccl_driver):
6167 Check for overflow when converting EMACS_INT to int.
6168 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6169 need to be updated by these changes.
6170 * fns.c (make_hash_table, maybe_resize_hash_table):
6171 Check for integer overflow with large hash tables.
6172 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6173 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6174 (SXHASH_REDUCE): New macro.
6175 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6176 Use it instead of discarding useful hash info with large hash values.
6177 (sxhash_float): New function.
6178 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6179 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6180 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6181 Rewrite to use FIXNUM_BITS, as this simplifies things.
6182 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6183 Adjust signatures to match updated version of code.
6184 (consing_since_gc): Now EMACS_INT, since a single hash table can
6185 use more than INT_MAX bytes.
6186
6187 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6188
6189 Make it possible to build with GCC-4.6+ -O2 -flto.
6190
6191 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6192
6193 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6194
6195 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6196 Call minibuffer-inactive-mode.
6197
6198 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6199
6200 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6201 Update dependencies.
6202
6203 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6204
6205 * data.c (init_data): Remove code for UTS, this system is not
6206 supported anymore.
6207
6208 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6209
6210 Don't force ./temacs to start in terminal mode.
6211
6212 * frame.c (make_initial_frame): Initialize faces in all cases, not
6213 only when CANNOT_DUMP is defined.
6214 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6215
6216 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6217
6218 * dispnew.c (add_window_display_history): Use const for the string
6219 pointer. Remove declaration, not needed.
6220
6221 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6222
6223 Use 'inline', not 'INLINE'.
6224 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6225 * alloc.c, fontset.c (INLINE): Remove.
6226 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6227 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6228 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6229 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6230 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6231
6232 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6233
6234 Make it possible to run ./temacs.
6235
6236 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6237 syms_of_callproc does the same thing. Remove test for
6238 "initialized", do it in the caller.
6239 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6240
6241 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6242
6243 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6244 (read_minibuf): Use get_minibuffer.
6245 (syms_of_minibuf): Use DEFSYM.
6246 (Qmetadata): New var.
6247 * data.c (Qbuffer): Don't make it static.
6248 (syms_of_data): Use DEFSYM.
6249
6250 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6251
6252 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6253 (CCL_CODE_MIN): New macro.
6254
6255 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6256
6257 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6258
6259 * eval.c (Qdebug): Now static.
6260 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6261 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6262 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6263
6264 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6265
6266 * image.c: Various fixes to ImageMagick code comments.
6267 (Fimagemagick_types): Doc fix.
6268
6269 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6270
6271 Minor fixes prompted by GCC 4.6.0 warnings.
6272
6273 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6274
6275 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6276 (x_clipboard_manager_save_all): Move extern decl to ...
6277 * xterm.h: ... here, so that it can be checked for consistency.
6278
6279 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6280
6281 * xselect.c (x_clipboard_manager_save_frame)
6282 (x_clipboard_manager_save_all): New functions.
6283 (Fx_clipboard_manager_save): Lisp function deleted.
6284
6285 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6286 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6287
6288 * xterm.h: Update prototype.
6289
6290 2011-05-28 William Xu <william.xwl@gmail.com>
6291
6292 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6293 exiting (Bug#8239).
6294
6295 2011-05-28 Jim Meyering <meyering@redhat.com>
6296
6297 Avoid a sign-extension bug in crypto_hash_function.
6298 * fns.c (to_uchar): Define.
6299 (crypto_hash_function): Use it to convert some newly-signed
6300 variables to unsigned, to avoid sign-extension bugs. For example,
6301 without this change, (md5 "truc") would evaluate to
6302 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6303 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6304 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6305
6306 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6307
6308 Integer overflow fixes.
6309
6310 * dbusbind.c: Serial number integer overflow fixes.
6311 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6312 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6313 to hold a serial number that is too large for a fixnum.
6314 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6315 Check for serial numbers out of range. Decode any serial number
6316 that was so large that it became a float. (Bug#8722)
6317
6318 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6319 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6320 Use XFASTINT rather than XUINT when numbers are nonnegative.
6321 (xd_append_arg, Fdbus_method_return_internal):
6322 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6323 arguments, check that Lisp number is nonnegative, rather than
6324 silently wrapping negative numbers around. (Bug#8722)
6325 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6326 (Bug#8722)
6327
6328 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6329
6330 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6331
6332 ccl: Add integer overflow checks.
6333 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6334 (IN_INT_RANGE): New macros.
6335 (ccl_driver): Use them to check for integer overflow when
6336 decoding a CCL program. Many of the new checks are whether XINT (x)
6337 fits in int; it doesn't always, on 64-bit hosts. The new version
6338 doesn't catch all possible integer overflows, but it's an
6339 improvement. (Bug#8719)
6340
6341 * alloc.c (make_event_array): Use XINT, not XUINT.
6342 There's no need for unsigned here.
6343
6344 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6345 This follows up to the 2011-05-06 change that substituted uintptr_t
6346 for EMACS_INT. This case wasn't caught back then.
6347
6348 Rework Fformat to avoid integer overflow issues.
6349 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6350 now (part of C89). Include <verify.h>.
6351 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6352 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6353 (Fformat): Avoid the prepass trying to compute sizes; it was only
6354 approximate and thus did not catch overflow reliably. Instead, walk
6355 through the format just once, formatting and computing sizes as we go,
6356 checking for integer overflow at every step, and allocating a larger
6357 buffer as needed. Keep track separately whether the format is
6358 multibyte. Keep only the most-recently calculated precision, rather
6359 than them all. Record whether each argument has been converted to
6360 string. Use EMACS_INT, not int, for byte and char and arg counts.
6361 Support field widths and precisions larger than INT_MAX. Avoid
6362 sprintf's undefined behavior with conversion specifications such as %#d
6363 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6364 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6365 formatting out-of-range floating point numbers with int
6366 formats. (Bug#8668)
6367
6368 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6369
6370 * data.c: Avoid integer truncation in expressions involving floats.
6371 * data.c: Include <intprops.h>.
6372 (arith_driver): When there's an integer overflow in an expression
6373 involving floating point, convert the integers to floating point
6374 so that the resulting value does not suffer from catastrophic
6375 integer truncation. For example, on a 64-bit host (* 4
6376 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6377 Do not rely on undefined behavior after integer overflow.
6378
6379 merge count_size_as_multibyte, parse_str_to_multibyte
6380 * character.c, character.h (count_size_as_multibyte):
6381 Rename from parse_str_to_multibyte; all uses changed.
6382 Check for integer overflow.
6383 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6384 since it's now a duplicate of the other. This is more of
6385 a character than a buffer op, so better that it's in character.c.
6386 * fns.c, print.c: Adjust to above changes.
6387
6388 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6389
6390 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6391
6392 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6393
6394 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6395 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6396 (x_clipboard_manager_save): Now static.
6397 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6398
6399 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6400 (crypto_hash_function): Now static.
6401 Fix pointer signedness problems. Avoid unnecessary initializations.
6402
6403 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6404
6405 * termhooks.h (Vselection_alist): Make it terminal-local.
6406
6407 * terminal.c (create_terminal): Initialize it.
6408
6409 * xselect.c: Support for clipboard managers.
6410 (Vselection_alist): Move to termhooks.h as terminal-local var.
6411 (LOCAL_SELECTION): New macro.
6412 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6413 (symbol_to_x_atom): Remove gratuitous arg.
6414 (x_handle_selection_request, lisp_data_to_selection_data)
6415 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6416 (x_own_selection, x_get_local_selection, x_convert_selection):
6417 New arg, specifying work frame. Use terminal-local Vselection_alist.
6418 (some_frame_on_display): Delete unused function.
6419 (Fx_own_selection_internal, Fx_get_selection_internal)
6420 (Fx_disown_selection_internal, Fx_selection_owner_p)
6421 (Fx_selection_exists_p): New optional frame arg.
6422 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6423 (x_handle_selection_clear): Don't treat other terminals with the
6424 same keyboard specially. Use the terminal-local Vselection_alist.
6425 (x_clear_frame_selections): Use Frun_hook_with_args.
6426
6427 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6428
6429 * xterm.h: Add support for those atoms.
6430
6431 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6432
6433 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6434 (converted_selections, conversion_fail_tag): New global variables.
6435 (x_selection_request_lisp_error): Free the above.
6436 (x_get_local_selection): Remove unnecessary code.
6437 (x_reply_selection_request): Args changed; handle arbitrary array
6438 of converted selections stored in converted_selections.
6439 Separate the XChangeProperty and SelectionNotify steps.
6440 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6441 (x_convert_selection): New function.
6442 (x_handle_selection_event): Simplify.
6443 (x_get_foreign_selection): Don't ignore incoming requests while
6444 waiting for an answer; this will fail when we implement
6445 SAVE_TARGETS, and seems unnecessary anyway.
6446 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6447 (Vx_sent_selection_functions): Doc fix.
6448
6449 2011-05-26 Leo Liu <sdl.web@gmail.com>
6450
6451 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6452
6453 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6454
6455 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6456
6457 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6458 for fringe update if it has periodic bitmap.
6459 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6460 and fringe_bitmap_periodic_p.
6461
6462 * fringe.c (get_fringe_bitmap_data): New function.
6463 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6464 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6465 row. Mark glyph row for fringe update if periodicity changed.
6466
6467 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6468 for fringe update unless it has periodic bitmap.
6469
6470 2011-05-25 Kenichi Handa <handa@m17n.org>
6471
6472 * xdisp.c (get_next_display_element): Set correct it->face_id for
6473 a static composition.
6474
6475 2011-05-24 Leo Liu <sdl.web@gmail.com>
6476
6477 * deps.mk (fns.o):
6478 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6479
6480 * fns.c (crypto_hash_function, Fsha1): New function.
6481 (Fmd5): Use crypto_hash_function.
6482 (syms_of_fns): Add Ssha1.
6483
6484 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6485
6486 * gnutls.c: Remove unused macros.
6487 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6488 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6489 Remove macros that are defined and never used.
6490 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6491
6492 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6493
6494 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6495 (Fx_get_selection_internal): Minor cleanup.
6496 (Fx_own_selection_internal): Rename arguments for consistency with
6497 select.el.
6498
6499 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6500
6501 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6502
6503 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6504
6505 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6506
6507 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6508
6509 * dispnew.c (scrolling_window): Don't exclude the case that the
6510 last enabled row in the desired matrix touches the bottom boundary.
6511
6512 2011-05-21 Glenn Morris <rgm@gnu.org>
6513
6514 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6515 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6516 and add some more files.
6517
6518 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6519
6520 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6521 report_file_error introduced by the change from 2011-05-07.
6522
6523 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6524
6525 * systime.h (Time): Define only if emacs is defined.
6526 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6527 where the include path doesn't have X11/X.h by default. See
6528 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6529
6530 2011-05-20 Kenichi Handa <handa@m17n.org>
6531
6532 * composite.c (find_automatic_composition): Fix previous change.
6533
6534 2011-05-20 Glenn Morris <rgm@gnu.org>
6535
6536 * lisp.mk: New file, split from Makefile.in.
6537 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6538 (shortlisp): Remove.
6539 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6540
6541 2011-05-19 Glenn Morris <rgm@gnu.org>
6542
6543 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6544 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6545 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6546 (lisp): Set the order to that of loadup.el.
6547 (shortlisp): Make it a copy of $lisp.
6548 (SOME_MACHINE_LISP): Remove.
6549 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6550 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6551
6552 2011-05-18 Kenichi Handa <handa@m17n.org>
6553
6554 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6555 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6556 (find_automatic_composition): Mostly rewrite for efficiency.
6557
6558 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6559
6560 * makefile.w32-in: Update dependencies.
6561
6562 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6563
6564 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6565 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6566
6567 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6568
6569 Fix some integer overflow issues, such as string length overflow.
6570
6571 * insdel.c (count_size_as_multibyte): Check for string overflow.
6572
6573 * character.c (lisp_string_width): Check for string overflow.
6574 Use EMACS_INT, not int, for string indexes and lengths; in
6575 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6576 the resulting string length overflows an EMACS_INT; instead,
6577 report a string overflow if no precision given. When checking for
6578 precision exhaustion, use a check that cannot possibly have
6579 integer overflow. (Bug#8675)
6580 * character.h (lisp_string_width): Adjust to new signature.
6581
6582 * alloc.c (string_overflow): New function.
6583 (Fmake_string): Use it. This doesn't change behavior, but saves
6584 a few bytes and will simplify future changes.
6585 * character.c (string_escape_byte8): Likewise.
6586 * lisp.h (string_overflow): New decl.
6587
6588 Fixups, following up to the user-interface timestamp change.
6589 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6590 for UI timestamps, instead of unsigned long.
6591 * msdos.c (mouse_get_pos): Likewise.
6592 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6593 * w32gui.h (Time): Define by including "systime.h" rather than by
6594 declaring it ourselves. (Bug#8664)
6595
6596 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6597 * image.c (clear_image_cache): Likewise.
6598
6599 * term.c (term_mouse_position): Don't assume time_t wraparound.
6600
6601 Be more systematic about user-interface timestamps.
6602 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6603 and sometimes 'EMACS_UINT', to represent these timestamps.
6604 This change causes it to use 'Time' uniformly, as that's what X uses.
6605 This makes the code easier to follow, and makes it easier to catch
6606 integer overflow bugs such as Bug#8664.
6607 * frame.c (Fmouse_position, Fmouse_pixel_position):
6608 Use Time, not unsigned long, for user-interface timestamps.
6609 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6610 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6611 * keyboard.h (last_event_timestamp): Likewise.
6612 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6613 * menu.h (xmenu_show): Likewise.
6614 * term.c (term_mouse_position): Likewise.
6615 * termhooks.h (struct input_event.timestamp): Likewise.
6616 (struct terminal.mouse_position_hook): Likewise.
6617 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6618 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6619 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6620 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6621 what it was before.
6622 * menu.h, termhooks.h: Include "systime.h", for Time.
6623
6624 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6625 Don't assume that the difference between two unsigned long values
6626 can fit into an integer. At this point, we know button_down_time
6627 <= event->timestamp, so the difference must be nonnegative, so
6628 there's no need to cast the result if double-click-time is
6629 nonnegative, as it should be; check that it's nonnegative, just in
6630 case. This bug is triggered when events are more than 2**31 ms
6631 apart (about 25 days). (Bug#8664)
6632
6633 * xselect.c (last_event_timestamp): Remove duplicate decl.
6634 (x_own_selection): Remove needless cast to unsigned long.
6635
6636 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6637 that always fit in int. Use a sentinel instead of a counter, to
6638 avoid a temp and to allay GCC's concerns about possible int overflow.
6639 * frame.h (struct frame): Use int for menu_bar_items_used
6640 instead of EMACS_INT, since it always fits in int.
6641
6642 * menu.c (grow_menu_items): Check for int overflow.
6643
6644 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6645
6646 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6647 Before, the code was not consistent. These values cannot exceed
6648 2**31 - 1 so there's no need to make them unsigned.
6649 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6650 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6651 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6652 as modifiers.
6653 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6654
6655 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6656 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6657 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6658 presumably because the widths might not match.
6659
6660 * window.c (size_window): Avoid needless test at loop start.
6661
6662 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6663
6664 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6665
6666 2011-05-12 Drew Adams <drew.adams@oracle.com>
6667
6668 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6669
6670 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6671
6672 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6673 `width' to `bar_area_x' and `bar_area_width', respectively.
6674 (x_scroll_run): Take account of fringe background extension.
6675
6676 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6677 Rename local vars `left' and `width' to `bar_area_x' and
6678 `bar_area_width', respectively.
6679 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6680 background extension.
6681
6682 2011-05-10 Jim Meyering <meyering@redhat.com>
6683
6684 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6685
6686 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6687
6688 * image.c (Finit_image_library): Return t for built-in image types,
6689 like pbm and xbm. (Bug#8640)
6690
6691 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6692
6693 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6694
6695 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6696
6697 * w32console.c (Fset_screen_color): Doc fix.
6698 (Fget_screen_color): New function.
6699 (syms_of_ntterm): Defsubr it.
6700
6701 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6702 unlink the temporary file if Fcall_process didn't create it in the
6703 first place.
6704 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6705 child process will be redirected to a file specified with `:file'.
6706 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6707 cue to call_process_cleanup not to close that handle.
6708
6709 2011-05-07 Ben Key <bkey76@gmail.com>
6710
6711 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6712 one of two shell specific rules, either bootstrap-temacs-CMD or
6713 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6714 to the previous implementation of the bootstrap-temacs rule.
6715 The bootstrap-temacs-CMD rule is similar to the previous
6716 implementation of the bootstrap-temacs rule except that it
6717 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6718 variable.
6719
6720 These changes, along with some changes to nt/configure.bat,
6721 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6722 earlier fix to add support for --cflags and --ldflags options
6723 that include quotes so that it works whether make uses cmd or
6724 sh as the shell.
6725
6726 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6727
6728 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6729 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6730 is a constant.
6731 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6732 a string. Handle both cases.
6733 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6734 (Fdbus_register_method): Use Qinvalid_function.
6735
6736 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6737
6738 * makefile.w32-in: Update dependencies.
6739 (LISP_H): Add inttypes.h and stdin.h.
6740 (PROCESS_H): Add unistd.h.
6741
6742 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6743
6744 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6745 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6746
6747 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6748
6749 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6750
6751 * term.c (vfatal): Remove stray call to va_end.
6752 It's not needed and the C Standard doesn't allow it here anyway.
6753
6754 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6755 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6756
6757 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6758 bytes.
6759
6760 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6761
6762 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6763
6764 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6765
6766 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6767
6768 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6769
6770 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6771 * charset.c (Fdefine_charset_internal): Don't initialize
6772 charset.code_space[15]. The value was garbage, on hosts with
6773 32-bit int (Bug#8600).
6774
6775 * lread.c (read_integer): Be more consistent with string-to-number.
6776 Use string_to_number to do the actual conversion; this avoids
6777 rounding errors and fixes some other screwups. Without this fix,
6778 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6779 (digit_to_number): Move earlier, for benefit of read_integer.
6780 Return -1 if the digit is out of range for the base, -2 if it is
6781 not a digit in any supported base. (Bug#8602)
6782
6783 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6784
6785 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6786 to match comment at start of function. This also removes a
6787 GCC warning about overflow in a 32+64-bit port.
6788
6789 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6790
6791 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6792 Reported by Stefan Monnier in
6793 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6794 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6795 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6796
6797 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6798 (EMACS_UINTPTR): Likewise, with uintptr_t.
6799
6800 * lisp.h: Prefer 64-bit EMACS_INT if available.
6801 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6802 on 32-bit hosts that have 64-bit int, so that they can access
6803 large files.
6804 However, temporarily disable this change unless the temporary
6805 symbol WIDE_EMACS_INT is defined.
6806
6807 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6808
6809 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6810 This removes an assumption that EMACS_INT and long are the same
6811 width as pointers. The assumption is true for Emacs porting targets
6812 now, but we want to make other targets possible.
6813 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6814 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6815 In the rest of the code, change types of integers that hold casted
6816 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6817 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6818 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6819 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6820 No need to cast type when ORing.
6821 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6822 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6823 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6824 assume EMACS_INT is the same width as char *.
6825 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6826 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6827 Remove no-longer-needed casts.
6828 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6829 (xg_tool_bar_help_callback, xg_make_tool_item):
6830 Use EMACS_INTPTR to hold an integer
6831 that will be cast to void *; this can avoid a GCC warning
6832 if EMACS_INT is not the same width as void *.
6833 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6834 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6835 (current_message_1, set_message_1):
6836 Use a local to convert to proper width without a cast.
6837 * xmenu.c (dialog_selection_callback): Likewise.
6838
6839 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6840 Also, don't assume VALBITS / RAND_BITS is less than 5,
6841 and don't rely on undefined behavior when shifting a 1 left into
6842 the sign bit.
6843 * lisp.h (get_random): Change signature to match.
6844
6845 * lread.c (hash_string): Use size_t, not int, for hash computation.
6846 Normally we prefer signed values; but hashing is special, because
6847 it's better to use unsigned division on hash table sizes so that
6848 the remainder is nonnegative. Also, size_t is the natural width
6849 for hashing into memory. The previous code used 'int', which doesn't
6850 retain enough info to hash well into very large tables.
6851 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6852
6853 * dbusbind.c: Don't possibly lose pointer info when converting.
6854 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6855 Use XPNTR rather than XHASH, so that the high-order bits of
6856 the pointer aren't lost when converting through void *.
6857
6858 * eval.c (Fautoload): Don't double-shift a pointer.
6859
6860 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6861
6862 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6863
6864 * gnutls.c (DEF_GNUTLS_FN):
6865 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6866
6867 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6868
6869 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6870 marker. (Bug#8610)
6871
6872 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6873
6874 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6875 New version that can reserve upto 2GB of heap space.
6876
6877 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6878
6879 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6880
6881 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6882
6883 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6884 `gnutls_certificate_set_x509_key_file'.
6885
6886 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6887
6888 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6889 Update dependencies.
6890
6891 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6892
6893 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6894 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6895 Remove unused parameter `fildes'.
6896 * process.c (read_process_output, send_process): Don't pass it.
6897
6898 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6899
6900 Fix previous change: the library cache is defined in w32.c.
6901 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6902 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6903
6904 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6905
6906 Implement dynamic loading of GnuTLS on Windows.
6907
6908 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6909 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6910 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6911 Declare.
6912
6913 * gnutls.c (Qgnutls_dll): Define.
6914 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6915 (gnutls_*): Declare function pointers.
6916 (init_gnutls_functions): New function to initialize function pointers.
6917 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6918 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6919 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6920 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6921 (emacs_gnutls_write, emacs_gnutls_read)
6922 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6923 (Fgnutls_available_p): New function.
6924 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6925 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6926 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6927
6928 * image.c: Include w32.h.
6929 (Vimage_type_cache): Delete.
6930 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6931 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6932 (w32_delayed_load): Move to w32.c.
6933
6934 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6935
6936 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6937 (w32_delayed_load): Move from image.c. When loading a library, record
6938 its filename in the :loaded-from property of the library id.
6939 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6940 Initialize and staticpro them.
6941 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6942
6943 * process.c: Include lisp.h before w32.h, not after.
6944 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6945 instead of gnutls_record_check_pending.
6946
6947 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6948
6949 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6950
6951 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6952 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6953 as passed in.
6954
6955 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6956
6957 * xterm.c (x_set_frame_alpha): Do not set property on anything
6958 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6959
6960 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6961
6962 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6963
6964 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6965
6966 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6967 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6968 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6969 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6970 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6971 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6972 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6973 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6974 (Qgnutls_bootprop_callbacks_verify): Make static.
6975
6976 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6977
6978 * callproc.c: Indentation fixup.
6979
6980 * sysdep.c (wait_for_termination_1): Make static.
6981 (wait_for_termination, interruptible_wait_for_termination):
6982 Move after wait_for_termination_1.
6983
6984 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6985
6986 * sysdep.c (interruptible_wait_for_termination): New function
6987 which is like wait_for_termination, but allows keyboard
6988 interruptions.
6989
6990 * callproc.c (Fcall_process): Add (:file "file") as an option for
6991 the STDOUT buffer.
6992 (Fcall_process_region): Ditto.
6993
6994 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6995
6996 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6997 rather than `XVECTOR (FOO)->size'.
6998
6999 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7000 inttypes.h, as a gnulib replacement is used if it not available in
7001 system headers.
7002
7003 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7004
7005 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7006 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7007 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7008
7009 * coding.c (coding_alloc_by_realloc): Error out if destination
7010 will grow beyond MOST_POSITIVE_FIXNUM.
7011 (decode_coding_emacs_mule): Abort if there isn't enough place in
7012 charbuf for the composition carryover bytes. Reserve an extra
7013 space for up to 2 characters produced in a loop.
7014 (decode_coding_iso_2022): Abort if there isn't enough place in
7015 charbuf for the composition carryover bytes.
7016
7017 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7018
7019 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7020 aborting when %lld or %lll format is passed.
7021 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7022 %llo or %llx format is passed. (Bug#8545)
7023
7024 * window.c (window_scroll_line_based): Use a marker instead of
7025 simple variables to record original value of point. (Bug#7952)
7026
7027 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7028 produced by %s or %c overflows available buffer space. (Bug#8545)
7029
7030 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7031
7032 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7033 (SIZE_MAX): Move defn after all includes, as they might #define it.
7034
7035 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7036
7037 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7038
7039 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7040
7041 * keyboard.c (Qdelayed_warnings_hook): Define.
7042 (command_loop_1): Run `delayed-warnings-hook'
7043 if Vdelayed_warnings_list is non-nil.
7044 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7045 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7046
7047 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7048
7049 * doprnt.c (doprnt): Don't return value smaller than the buffer
7050 size if the message was truncated. (Bug#8545).
7051
7052 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7053
7054 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7055 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7056
7057 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7058
7059 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7060
7061 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7062
7063 * makefile.w32-in: Update dependencies.
7064
7065 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7066
7067 Improve `doprnt' and its usage. (Bug#8545)
7068 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7069 `format_end'. Remove support for %l as a conversion specifier.
7070 Don't use xrealloc. Improve diagnostics when the %l size modifier
7071 is used. Update the commentary.
7072
7073 * eval.c (verror): Simplify calculation of size_t.
7074
7075 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7076 messages.
7077
7078 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7079
7080 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7081 change.
7082
7083 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7084
7085 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7086 This makes this file independent of the recent pseudovector change.
7087
7088 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7089
7090 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7091
7092 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7093 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7094 Remove unused local.
7095 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7096
7097 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7098 GCC 4.6.0 optimizes based on type-based alias analysis.
7099 For example, if b is of type struct buffer * and v of type struct
7100 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7101 != &v->size, and therefore "v->size = 1; b->size = 2; return
7102 v->size;" must therefore return 1. This assumption is incorrect
7103 for Emacs, since it type-puns struct Lisp_Vector * with many other
7104 types. To fix this problem, this patch adds a new type struct
7105 vectorlike_header that documents the constraints on layout of vectors
7106 and pseudovectors, and helps optimizing compilers not get fooled
7107 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7108 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7109 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7110 the size member.
7111 (XSETPVECTYPE): Rewrite in terms of new macro.
7112 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7113 This is a bit clearer, and further avoids the possibility of
7114 undesirable aliasing.
7115 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7116 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7117 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7118 since Lisp_Subr is a special case (no "next" field).
7119 (ASIZE): Now uses header.size rather than size.
7120 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7121 to avoid the hassle of writing XVECTOR (foo)->header.size.
7122 (struct vectorlike_header): New type.
7123 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7124 object, to help avoid aliasing.
7125 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7126 (SUBRP): Likewise, since Lisp_Subr is a special case.
7127 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7128 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7129 (struct Lisp_Hash_Table): Combine first two members into a single
7130 struct vectorlike_header member. All uses of "size" and "next" members
7131 changed to be "header.size" and "header.next".
7132 * buffer.h (struct buffer): Likewise.
7133 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7134 * frame.h (struct frame): Likewise.
7135 * process.h (struct Lisp_Process): Likewise.
7136 * termhooks.h (struct terminal): Likewise.
7137 * window.c (struct save_window_data, struct saved_window): Likewise.
7138 * window.h (struct window): Likewise.
7139 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7140 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7141 * buffer.c (init_buffer_once): Likewise.
7142 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7143 special case.
7144 * process.c (Fformat_network_address): Use local var for size,
7145 for brevity.
7146
7147 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7148
7149 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7150 * data.c (atof): Remove decl; no longer used or needed.
7151 (digit_to_number): Move to lread.c.
7152 (Fstring_to_number): Use new string_to_number function, to be
7153 consistent with how the Lisp reader treats infinities and NaNs.
7154 Do not assume that floating-point numbers represent EMACS_INT
7155 without losing information; this is not true on most 64-bit hosts.
7156 Avoid double-rounding errors, by insisting on integers when
7157 parsing non-base-10 numbers, as the documentation specifies.
7158 * lisp.h (string_to_number): New decl, replacing ...
7159 (isfloat_string): Remove.
7160 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7161 (read1): Do not accept +. and -. as integers; this
7162 appears to have been a coding error. Similarly, do not accept
7163 strings like +-1e0 as floating point numbers. Do not report
7164 overflow for integer overflows unless the base is not 10 which
7165 means we have no simple and reliable way to continue.
7166 Break out the floating-point parsing into a new
7167 function string_to_number, so that Fstring_to_number parses
7168 floating point numbers consistently with the Lisp reader.
7169 (digit_to_number): Move here from data.c. Make it static inline.
7170 (E_CHAR, EXP_INT): Remove, replacing with ...
7171 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7172 (string_to_number): New function, replacing isfloat_string.
7173 This function checks for valid syntax and produces the resulting
7174 Lisp float number too. Rework it so that string-to-number
7175 no longer mishandles examples like "1.0e+". Use strtoumax,
7176 so that overflow for non-base-10 numbers is reported only when
7177 there's no portable and simple way to convert to floating point.
7178
7179 * textprop.c (set_text_properties_1): Rewrite for clarity,
7180 and to avoid GCC warning about integer overflow.
7181
7182 * intervals.h (struct interval): Use EMACS_INT for members
7183 where EMACS_UINT might cause problems. See
7184 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7185 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7186 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7187 All uses changed.
7188 (offset_intervals): Tell GCC not to worry about length overflow
7189 when negating a negative length.
7190
7191 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7192 (overrun_check_free): Likewise.
7193
7194 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7195 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7196 word size.
7197
7198 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7199 (gnutls_make_error): Rename local to avoid shadowing.
7200 (gnutls_emacs_global_deinit): ifdef out; not used.
7201 (Fgnutls_boot): Use const for pointer to readonly storage.
7202 Comment out unused local. Fix pointer signedness problems.
7203
7204 * lread.c (openp): Don't stuff size_t into an 'int'.
7205 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7206 about possible signed overflow.
7207
7208 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7209 (GDK_KEY_g): Don't define if already defined.
7210 (xg_prepare_tooltip): Avoid pointer signedness problem.
7211 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7212
7213 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7214 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7215
7216 * xfns.c (Fx_window_property): Simplify a bit,
7217 to make a bit faster and to avoid GCC 4.6.0 warning.
7218 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7219
7220 * fns.c (internal_equal): Don't assume size_t fits in int.
7221
7222 * alloc.c (compact_small_strings): Tighten assertion a little.
7223
7224 Replace pEd with more-general pI, and fix some printf arg casts.
7225 * lisp.h (pI): New macro, generalizing old pEd macro to other
7226 conversion specifiers. For example, use "...%"pI"d..." rather
7227 than "...%"pEd"...".
7228 (pEd): Remove. All uses replaced with similar uses of pI.
7229 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7230 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7231 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7232 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7233 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7234 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7235 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7236 64-bit hosts.
7237 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7238 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7239 * print.c (safe_debug_print, print_object): Likewise.
7240 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7241 to int.
7242 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7243 avoiding the 0 flag, which is not portable.
7244 * process.c (Fmake_network_process): Use pI to avoid cast.
7245 * region-cache.c (pp_cache): Likewise.
7246 * xdisp.c (decode_mode_spec): Likewise.
7247 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7248 behavior on 64-bit hosts with printf arg.
7249 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7250 (x_stop_queuing_selection_requests): Likewise.
7251 (x_get_window_property): Don't truncate byte count to an 'int'
7252 when tracing.
7253
7254 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7255 here, since it parses constructs like leading '-' and spaces,
7256 which are not wanted; and it overflows with large numbers.
7257 Instead, simply match F[0-9]+, which is what is wanted anyway.
7258
7259 * alloc.c: Remove unportable assumptions about struct layout.
7260 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7261 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7262 (allocate_vectorlike, make_pure_vector): Use the new macros,
7263 plus offsetof, to remove unportable assumptions about struct layout.
7264 These assumptions hold on all porting targets that I know of, but
7265 they are not guaranteed, they're easy to remove, and removing them
7266 makes further changes easier.
7267
7268 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7269 This doesn't fix a bug but makes the code clearer.
7270 (string_overrun_cookie): Now const. Use initializers that
7271 don't formally overflow signed char, to avoid warnings.
7272 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7273 can cause Emacs to crash when string overrun checking is enabled.
7274 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7275 multiple of sizeof (EMACS_INT); it need not be, if
7276 alignof(EMACS_INT) < sizeof (EMACS_INT).
7277 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7278
7279 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7280
7281 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7282
7283 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7284
7285 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7286 supposed to be handshaking. (Bug#8556)
7287 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7288
7289 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7290
7291 * lisp.h (Qdebug): List symbol.
7292 * eval.c (Qdebug): Restore global linkage.
7293 * keyboard.c (debug-on-event): New variable.
7294 (handle_user_signal): Break into debugger when debug-on-event
7295 matches the current signal symbol.
7296
7297 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7298
7299 * alloc.c (check_sblock, check_string_bytes)
7300 (check_string_free_list): Convert to standard C.
7301
7302 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7303
7304 * w32.c (emacs_gnutls_push): Fix typo.
7305
7306 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7307
7308 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7309 "cast to pointer from integer of different size".
7310
7311 Improve doprnt and its use in verror. (Bug#8545)
7312 * doprnt.c (doprnt): Document the set of format control sequences
7313 supported by the function. Use SAFE_ALLOCA instead of always
7314 using `alloca'.
7315
7316 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7317 is one byte too soon. Don't use xrealloc; instead xfree and
7318 xmalloc anew.
7319
7320 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7321
7322 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7323 callbacks stage.
7324
7325 * gnutls.c: Renamed global_initialized to
7326 gnutls_global_initialized. Added internals for the
7327 :verify-hostname-error, :verify-error, and :verify-flags
7328 parameters of `gnutls-boot' and documented those parameters in the
7329 docstring. Start callback support.
7330 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7331 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7332 on error. Return error code.
7333 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7334 (emacs_gnutls_read): Likewise.
7335 (Fgnutls_boot): Return handshake error code.
7336 (emacs_gnutls_handle_error): New function.
7337 (wsaerror_to_errno): Likewise.
7338
7339 * w32.h (emacs_gnutls_pull): Add prototype.
7340 (emacs_gnutls_push): Likewise.
7341
7342 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7343 (emacs_gnutls_push): Likewise.
7344
7345 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7346
7347 * process.c (wait_reading_process_output): Check if GnuTLS
7348 buffered some data internally if no FDs are set for TLS
7349 connections.
7350
7351 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7352 (LIBS): Link to USER_LIBS.
7353 ($(BLD)/gnutls.$(0)): New target.
7354
7355 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7356
7357 * xdisp.c (handle_single_display_spec): Rename the
7358 display_replaced_before_p argument into display_replaced_p, to
7359 make it consistent with the commentary. Fix typos in the
7360 commentary.
7361
7362 * textprop.c (syms_of_textprop): Remove dead code.
7363 (copy_text_properties): Delete obsolete commentary about an
7364 interface that was deleted long ago. Fix typos in the description
7365 of arguments.
7366
7367 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7368 to changes in oldXMenu/XMenu.h from 2011-04-16.
7369 <menu_help_message, prev_menu_help_message>: Constify.
7370 (IT_menu_make_room): menu->help_text is now `const char **';
7371 adjust.
7372
7373 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7374 to changes in oldXMenu/XMenu.h from 2011-04-16.
7375 (struct XMenu): Declare `help_text' `const char **'.
7376
7377 * xfaces.c <Qunspecified>: Make extern again.
7378
7379 * syntax.c: Include sys/types.h before including regex.h, as
7380 required by POSIX.
7381
7382 * doc.c (get_doc_string): Improve the format passed to `error'.
7383
7384 * doprnt.c (doprnt): Improve commentary.
7385
7386 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7387
7388 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7389 them with etags.
7390
7391 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7392 changes in globals.h immediately force recompilation.
7393 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7394 $(CURDIR)/s/ms-w32.h.
7395 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7396
7397 * character.c (Fchar_direction): Function deleted.
7398 (syms_of_character): Don't defsubr it.
7399 <char-direction-table>: Deleted.
7400
7401 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7402
7403 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7404 * doprnt.c: Include limits.h.
7405 (SIZE_MAX): New macro.
7406 (doprnt): Return a size_t value. 2nd arg is now size_t.
7407 Many local variables are now size_t instead of int or unsigned.
7408 Improve overflow protection. Support `l' modifier for integer
7409 conversions. Support %l conversion. Don't assume an EMACS_INT
7410 argument for integer conversions and for %c.
7411
7412 * lisp.h (doprnt): Restore prototype.
7413
7414 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7415 $(SRC)/character.h.
7416
7417 * Makefile.in (base_obj): Add back doprnt.o.
7418
7419 * deps.mk (doprnt.o): Add back prerequisites.
7420 (callint.o): Depend on character.h.
7421
7422 * eval.c (internal_lisp_condition_case): Include the handler
7423 representation in the error message.
7424 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7425 when breaking from the loop.
7426
7427 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7428
7429 * callint.c (Fcall_interactively): When displaying error message
7430 about invalid control letter, pass the character's codepoint, not
7431 a pointer to its multibyte form. Improve display of the character
7432 in octal and display also its hex code.
7433
7434 * character.c (char_string): Use %x to display the (unsigned)
7435 codepoint of an invalid character, to avoid displaying a bogus
7436 negative value.
7437
7438 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7439 `error', not SYMBOL_NAME itself.
7440
7441 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7442 character arguments to `error'.
7443
7444 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7445 to `error' in error message about FINAL_CHAR argument. Make sure
7446 FINAL_CHAR is a character, and use %c when it is passed as
7447 argument to `error'.
7448
7449 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7450
7451 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7452
7453 * w32.c: Include <time.h>.
7454 (sys_localtime): New function.
7455
7456 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7457
7458 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7459
7460 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7461
7462 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7463
7464 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7465 zombies (Bug#8467).
7466
7467 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7468
7469 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7470 gl_state.e_property when gl_state.object is Qt.
7471
7472 * insdel.c (make_gap_larger): Remove limitation of buffer size
7473 to <= INT_MAX.
7474
7475 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7476
7477 * xdisp.c (lookup_glyphless_char_display)
7478 (produce_glyphless_glyph): Handle cons cell entry in
7479 glyphless-char-display.
7480 (Vglyphless_char_display): Document it.
7481
7482 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7483 glyphless-char-display.
7484
7485 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7486
7487 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7488
7489 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7490
7491 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7492 definition for no-X builds.
7493
7494 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7495
7496 Static checks with GCC 4.6.0 and non-default toolkits.
7497
7498 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7499
7500 * process.c (keyboard_bit_set): Define only if SIGIO.
7501 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7502 (send_process): Repair possible setjmp clobbering.
7503
7504 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7505
7506 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7507
7508 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7509
7510 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7511 Define only if needed.
7512
7513 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7514 by pacifying GCC about it. Maybe it's time to retire it?
7515 * xfaces.c (USG, __TIMEVAL__): Likewise.
7516
7517 * dispextern.h (struct redisplay_interface): Rename param
7518 to avoid shadowing.
7519 * termhooks.h (struct terminal): Likewise.
7520 * xterm.c (xembed_send_message): Likewise.
7521
7522 * insdel.c (make_gap_smaller): Define only if
7523 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7524
7525 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7526 it.
7527
7528 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7529 so that we aren't warned about unused symbols.
7530
7531 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7532
7533 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7534
7535 * xfns.c (x_real_positions): Mark locals as initialized.
7536
7537 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7538
7539 * xterm.c: Fix problems found by static analysis with other toolkits.
7540 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7541 (x_dispatch_event): Declare static if USE_GTK, and
7542 define if USE_GTK || USE_X_TOOLKIT.
7543 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7544 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7545 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7546 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7547
7548 * xmenu.c (menu_help_callback): Pointer type fixes.
7549 Use const pointers when pointing at readonly data. Avoid pointer
7550 signedness clashes.
7551 (FALSE): Remove unused macro.
7552 (update_frame_menubar): Remove unused decl.
7553
7554 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7555
7556 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7557 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7558 (single_menu_item): Rename local to avoid shadowing.
7559
7560 * keyboard.c (make_lispy_event): Remove unused local var.
7561
7562 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7563 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7564
7565 * bitmaps: Change bitmaps from unsigned char back to the X11
7566 compatible char. Avoid the old compiler warnings about
7567 out-of-range initializers by using, for example, '\xab' rather
7568 than 0xab.
7569
7570 * xgselect.c (xgselect_initialize): Check vs interface
7571 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7572
7573 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7574
7575 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7576 to read-only memory.
7577
7578 * fns.c (vector): Remove; this old hack is no longer needed.
7579
7580 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7581 Remove unused var.
7582 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7583
7584 * xrdb.c (x_load_resources): Omit unused local.
7585
7586 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7587 (x_window): Rename locals to avoid shadowing.
7588 (USG): Use the kludged USG macro, to pacify gcc.
7589
7590 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7591 (x_term_init): Remove local to avoid shadowing.
7592
7593 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7594
7595 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7596 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7597
7598 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7599
7600 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7601
7602 Fix regex.c, syntax.c and friends for buffers > 2GB.
7603 * syntax.h (struct gl_state_s): Declare character position members
7604 EMACS_INT.
7605
7606 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7607
7608 * textprop.c (verify_interval_modification, interval_of):
7609 Declare arguments EMACS_INT.
7610
7611 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7612 EMACS_INT.
7613
7614 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7615
7616 * indent.c (Fvertical_motion): Local variable it_start is now
7617 EMACS_INT.
7618
7619 * regex.c (re_match, re_match_2, re_match_2_internal)
7620 (bcmp_translate, regcomp, regexec, print_double_string)
7621 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7622 (re_compile_pattern, re_exec): Declare arguments and local
7623 variables `size_t' and `ssize_t' and return values `regoff_t', as
7624 appropriate.
7625 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7626 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7627 <compile_stack_type>: `size' and `avail' are now `size_t'.
7628
7629 * regex.h <regoff_t>: Use ssize_t, not int.
7630 (re_search, re_search_2, re_match, re_match_2): Arguments that
7631 specify buffer/string position and length are now ssize_t and
7632 size_t. Return type is regoff_t.
7633
7634 2011-04-16 Ben Key <bkey76@gmail.com>
7635
7636 * nsfont.m: Fixed bugs in ns_get_family and
7637 ns_descriptor_to_entity that were caused by using free to
7638 deallocate memory blocks that were allocated by xmalloc (via
7639 xstrdup). This caused Emacs to crash when compiled with
7640 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7641 --enable-checking=xmallocoverrun). xfree is now used to
7642 deallocate these memory blocks.
7643
7644 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7645
7646 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7647
7648 emacs_write: Accept and return EMACS_INT for sizes.
7649 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7650 et seq.
7651 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7652 Accept and return EMACS_INT.
7653 (emacs_gnutls_write): Return the number of bytes written on
7654 partial writes.
7655 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7656 (emacs_read, emacs_write): Remove check for negative size, as the
7657 Emacs source code has been audited now.
7658 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7659 (emacs_read, emacs_write): Use it.
7660 * process.c (send_process): Adjust to the new signatures of
7661 emacs_write and emacs_gnutls_write. Do not attempt to store
7662 a byte offset into an 'int'; it might overflow.
7663 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7664
7665 * sound.c: Don't assume sizes fit in 'int'.
7666 (struct sound_device.period_size, alsa_period_size):
7667 Return EMACS_INT, not int.
7668 (struct sound_device.write, vox_write, alsa_write):
7669 Accept EMACS_INT, not int.
7670 (wav_play, au_play): Use EMACS_INT to store sizes and to
7671 record read return values.
7672
7673 2011-04-15 Ben Key <bkey76@gmail.com>
7674
7675 * keyboard.c (Qundefined): Don't declare static since it is used
7676 in nsfns.m.
7677 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7678 static since they are used in nsfont.m.
7679
7680 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7681
7682 * process.c (Qprocessp): Don't declare static.
7683 * lisp.h (Qprocessp): Declare again.
7684
7685 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7686
7687 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7688
7689 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7690
7691 Improve C-level modularity by making more things 'static'.
7692
7693 Don't publish debugger-only interfaces to other modules.
7694 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7695 (verify_bytepos, count_markers): Move decls to the only modules
7696 that need them.
7697 * region-cache.h (pp_cache): Likewise.
7698 * window.h (check_all_windows): Likewise.
7699 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7700
7701 * sysdep.c (croak): Now static, if
7702 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7703 * syssignal.h (croak): Declare only if not static.
7704
7705 * alloc.c (refill_memory_reserve): Now static if
7706 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7707 * lisp.h (refill_memory_reserve): Declare only if not static.
7708
7709 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7710 Define only if USE_LUCID.
7711
7712 * xrdb.c (x_customization_string, x_rm_string): Now static.
7713
7714 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7715 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7716
7717 * xdisp.c (draw_row_with_mouse_face): Now static.
7718 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7719
7720 * window.h (check_all_windows): Mark externally visible.
7721
7722 * window.c (window_deletion_count): Now static.
7723
7724 * undo.c: Make symbols static if they're not exported.
7725 (last_undo_buffer, last_boundary_position, pending_boundary):
7726 Now static.
7727
7728 * textprop.c (interval_insert_behind_hooks): Now static.
7729 (interval_insert_in_front_hooks): Likewise.
7730
7731 * term.c: Make symbols static if they're not exported.
7732 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7733 (max_frame_lines, tty_set_terminal_modes):
7734 (tty_reset_terminal_modes, tty_turn_off_highlight):
7735 (get_tty_terminal): Now static.
7736 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7737 * termhooks.h (term_mouse_moveto): Do not declare if
7738 HAVE_WINDOW_SYSTEM.
7739 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7740 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7741
7742 * sysdep.c: Make symbols static if they're not exported.
7743 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7744 Now static.
7745 (sigprocmask_set, full_mask): Remove; unused.
7746 (wait_debugging): Mark as visible.
7747 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7748 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7749
7750 * syntax.c (syntax_temp): Define only if !__GNUC__.
7751
7752 * sound.c (current_sound_device, current_sound): Now static.
7753
7754 * search.c (searchbufs, searchbuf_head): Now static.
7755
7756 * scroll.c (scroll_cost): Remove; unused.
7757 * dispextern.h (scroll_cost): Remove decl.
7758
7759 * region-cache.h (pp_cache): Mark as externally visible.
7760
7761 * process.c: Make symbols static if they're not exported.
7762 (process_tick, update_tick, create_process, chan_process):
7763 (Vprocess_alist, proc_buffered_char, datagram_access):
7764 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7765 (deactivate_process): Mark defn as static, as well as decl.
7766 * lisp.h (create_process): Remove decl.
7767 * process.h (chan_process, Vprocess_alist): Remove decls.
7768
7769 * print.c: Make symbols static if they're not exported.
7770 (print_depth, new_backquote_output, being_printed, print_buffer):
7771 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7772 (print_interval, print_number_index, initial_stderr_stream):
7773 Now static.
7774 * lisp.h (Fprinc): Remove decl.
7775 (debug_output_compilation_hack): Mark as externally visible.
7776
7777 * sysdep.c (croak): Move decl from here to syssignal.h.
7778 * syssignal.h (croak): Put it here, so the API can be checked when
7779 'croak' is called from dissociate_if_controlling_tty.
7780
7781 * minibuf.c: Make symbols static if they're not exported.
7782 (minibuf_save_list, choose_minibuf_frame): Now static.
7783 * lisp.h (choose_minibuf_frame): Remove decl.
7784
7785 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7786
7787 * lread.c: Make symbols static if they're not exported.
7788 (read_objects, initial_obarray, oblookup_last_bucket_number):
7789 Now static.
7790 (make_symbol): Remove; unused.
7791 * lisp.h (initial_obarray, make_symbol): Remove decls.
7792
7793 * keyboard.c: Make symbols static if they're not exported.
7794 (single_kboard, recent_keys_index, total_keys, recent_keys):
7795 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7796 (this_single_command_key_start, echoing, last_auto_save):
7797 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7798 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7799 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7800 (Vlispy_mouse_stem, double_click_count):
7801 Now static.
7802 (force_auto_save_soon): Define only if SIGDANGER.
7803 (ignore_mouse_drag_p): Now static if
7804 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7805 (print_help): Remove; unused.
7806 (stop_character, last_timer_event): Mark as externally visible.
7807 * keyboard.h (ignore_mouse_drag_p): Declare only if
7808 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7809 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7810 * lisp.h (echoing): Remove decl.
7811 (force_auto_save_soon): Declare only if SIGDANGER.
7812 * xdisp.c (redisplay_window): Simplify code, to make it more
7813 obvious that ignore_mouse_drag_p is not accessed if !defined
7814 USE_GTK && !defined HAVE_NS.
7815
7816 * intervals.c: Make symbols static if they're not exported.
7817 (merge_properties_sticky, merge_interval_right, delete_interval):
7818 Now static.
7819 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7820
7821 * insdel.c: Make symbols static if they're not exported.
7822 However, leave prepare_to_modify_buffer alone. It's never
7823 called from outside this function, but that appears to be a bug.
7824 (combine_after_change_list, combine_after_change_buffer):
7825 (adjust_after_replace, signal_before_change): Now static.
7826 (adjust_after_replace_noundo): Remove; unused.
7827 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7828 (signal_before_change): Remove decls.
7829
7830 * indent.c (val_compute_motion, val_vmotion): Now static.
7831
7832 * image.c: Make symbols static if they're not exported.
7833 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7834 if USE_GTK.
7835 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7836 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7837
7838 * fringe.c (standard_bitmaps): Now static.
7839 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7840
7841 * frame.c: Make symbols static if they're not exported.
7842 (x_report_frame_params, make_terminal_frame): Now static.
7843 (get_frame_param): Now static, unless HAVE_NS.
7844 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7845 (x_get_resource_string): Remove; not used.
7846 * frame.h (make_terminal_frame, x_report_frame_params):
7847 (x_get_resource_string); Remove decls.
7848 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7849 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7850
7851 * font.c, fontset.c: Make symbols static if they're not exported.
7852 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7853 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7854 * font.c (font_close_object): Now static.
7855 * font.h (font_close_object): Remove.
7856 * fontset.c (FONTSET_OBJLIST): Remove.
7857 (free_realized_fontset) #if-0 the body, which does nothing.
7858 (face_suitable_for_char_p): #if-0, as it's never called.
7859 * fontset.h (face_suitable_for_char_p): Remove decl.
7860 * xfaces.c (face_at_string_position):
7861 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7862 since 0 is always ASCII.
7863
7864 * fns.c (weak_hash_tables): Now static.
7865
7866 * fileio.c: Make symbols static if they're not exported.
7867 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7868 (Vwrite_region_annotation_buffers): Now static.
7869
7870 * eval.c: Make symbols static if they're not exported.
7871 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7872 * lisp.h (backtrace_list): Remove decl.
7873
7874 * emacs.c: Make symbols static if they're not exported.
7875 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7876 (fatal_error_code, fatal_error_signal_hook, standard_args):
7877 Now static.
7878 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7879 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7880 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7881 * lisp.h (fatal_error_signal_hook): Remove decl.
7882 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7883
7884 * editfns.c: Move a (normally-unused) function to its only use.
7885 * editfns.c, lisp.h (get_operating_system_release): Remove.
7886 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7887 worth the hassle of breaking this out.
7888
7889 * xterm.c: Make symbols static if they're not exported.
7890 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7891 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7892 (x_destroy_window, x_delete_display):
7893 Now static.
7894 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7895 (x_mouse_leave): Remove; unused.
7896 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7897 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7898 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7899 Remove decls.
7900 (x_mouse_leave): Declare only if WINDOWSNT.
7901 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7902 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7903 USE_X_TOOLKIT.
7904
7905 * ftxfont.c: Make symbols static if they're not exported.
7906 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7907 HAVE_FREETYPE.
7908 * font.h (ftxfont_driver): Likewise.
7909
7910 * xfns.c: Make symbols static if they're not exported.
7911 (x_last_font_name, x_display_info_for_name):
7912 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7913 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7914 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7915 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7916 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7917 (last_show_tip_args): Now static.
7918 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7919 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7920 (x_screen_planes): Remove; unused.
7921 * dispextern.h (x_screen_planes): Remove decl.
7922
7923 * dispnew.c: Make symbols static if they're not exported.
7924 * dispextern.h (redraw_garbaged_frames, scrolling):
7925 (increment_row_positions): Remove.
7926 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7927 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7928 Now static.
7929 (redraw_garbaged_frames): Remove; unused.
7930
7931 * xfaces.c: Make symbols static if they're not exported.
7932 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7933 Remove decls.
7934 * xterm.h (defined_color): Remove decls.
7935 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7936 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7937 (menu_face_changed_default, defined_color, free_realized_face):
7938 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7939 (ascii_face_of_lisp_face): Remove; unused.
7940
7941 * xdisp.c: Make symbols static if they're not exported.
7942 * dispextern.h (scratch_glyph_row, window_box_edges):
7943 (glyph_to_pixel_coords, set_cursor_from_row):
7944 (get_next_display_element, set_iterator_to_next):
7945 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7946 (show_mouse_face): Remove decls
7947 * frame.h (message_buf_print): Likewise.
7948 * lisp.h (pop_message, set_message, check_point_in_composition):
7949 Likewise.
7950 * xterm.h (set_vertical_scroll_bar): Likewise.
7951 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7952 (message_buf_print, scratch_glyph_row, displayed_buffer):
7953 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7954 (get_next_display_element, show_mouse_face, window_box_edges):
7955 (frame_to_window_pixel_xy, check_point_in_composition):
7956 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7957 (glyph_to_pixel_coords): Remove; unused.
7958
7959 * dired.c (file_name_completion): Now static.
7960
7961 * dbusbind.c (xd_in_read_queued_messages): Now static.
7962
7963 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7964 * data.c (circular_list_error): Remove.
7965
7966 * commands.h (last_point_position, last_point_position_buffer):
7967 (last_point_position_window): Remove decls.
7968 * keyboard.c: Make these variables static.
7969
7970 * coding.h (coding, code_convert_region, encode_coding_gap):
7971 Remove decls.
7972 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7973 (iso_code_class, detect_coding, code_convert_region): Now static.
7974 (encode_coding_gap): Remove; unused.
7975
7976 * chartab.c (chartab_chars, chartab_bits): Now static.
7977
7978 * charset.h (charset_iso_8859_1): Remove decl.
7979 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7980 Now static.
7981
7982 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7983 * ccl.c (Vccl_program_table): Now static.
7984 (check_ccl_update): Remove; unused.
7985
7986 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7987 * category.h: ... from here.
7988 * category.c (check_category_table, set_category_set): Now static.
7989
7990 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7991 * lisp.h: Remove these decls.
7992
7993 * buffer.c (buffer_count): Remove unused var.
7994
7995 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7996 so that it's not optimized away.
7997 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7998 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7999 exported only to the debugger.
8000
8001 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8002 * atimer.h (run_all_atimers): Remove; not exported.
8003
8004 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8005 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8006 was inaccessible from Lisp.
8007 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8008 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8009
8010 alloc.c: Import and export fewer symbols, and remove unused items.
8011 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8012 is defined.
8013 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8014 it's not optimized away by whole-program optimization.
8015 (message_enable_multibyte, free_misc): Remove.
8016 (catchlist, handlerlist, mark_backtrace):
8017 Declare only if BYTE_MARK_STACK.
8018 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8019 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8020 (message_enable_multibyte): Remove decl.
8021 (free_misc, interval_free_list, float_block, float_block_index):
8022 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8023 (cons_free_list, last_marked_index):
8024 Now static.
8025 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8026 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8027 (mark_backtrace): Define only if BYTE_MARK_STACK.
8028 * xdisp.c (message_enable_multibyte): Now static.
8029
8030 Declare Lisp_Object Q* variables to be 'static' if not exported.
8031 This makes it easier for human readers (and static analyzers)
8032 to see whether these variables are used from other modules.
8033 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8034 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8035 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8036 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8037 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8038 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8039 * xmenu.c, xselect.c:
8040 Declare Q* vars static if they are not used in other modules.
8041 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8042 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8043 Remove decls of unexported vars.
8044 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8045
8046 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8047
8048 Make Emacs functions such as Fatom 'static' by default.
8049 This makes it easier for human readers (and static analyzers)
8050 to see whether these functions can be called from other modules.
8051 DEFUN now defines a static function. To make the function external
8052 so that it can be used in other C modules, use the new macro DEFUE.
8053 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8054 (Finit_image_library):
8055 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8056 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8057 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8058 Remove decls, since these functions are now static.
8059 (Funintern, Fget_internal_run_time): New decls, since these functions
8060 were already external.
8061
8062 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8063 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8064 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8065 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8066 * keyboard.c, keymap.c, lread.c:
8067 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8068 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8069 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8070 Mark functions with DEFUE instead of DEFUN,
8071 if they are used in other modules.
8072 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8073 decls for now-static functions.
8074 * buffer.h (Fdelete_overlay): Remove decl.
8075 * callproc.c (Fgetenv_internal): Mark as internal.
8076 * composite.c (Fremove_list_of_text_properties): Remove decl.
8077 (Fcomposition_get_gstring): New forward static decl.
8078 * composite.h (Fcomposite_get_gstring): Remove decl.
8079 * dired.c (Ffile_attributes): New forward static decl.
8080 * doc.c (Fdocumntation_property): New forward static decl.
8081 * eval.c (Ffetch_bytecode): New forward static decl.
8082 (Funintern): Remove extern decl; now in .h file where it belongs.
8083 * fileio.c (Fmake_symbolic_link): New forward static decl.
8084 * image.c (Finit_image_library): New forward static decl.
8085 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8086 * intervals.h (Fprevious_property_change):
8087 (Fremove_list_of_text_properties): Remove decls.
8088 * keyboard.c (Fthis_command_keys): Remove decl.
8089 (Fcommand_execute): New forward static decl.
8090 * keymap.c (Flookup_key): New forward static decl.
8091 (Fcopy_keymap): Now static.
8092 * keymap.h (Flookup_key): Remove decl.
8093 * process.c (Fget_process): New forward static decl.
8094 (Fprocess_datagram_address): Mark as internal.
8095 * syntax.c (Fsyntax_table_p): New forward static decl.
8096 (skip_chars): Remove duplicate decl.
8097 * textprop.c (Fprevious_property_change): New forward static decl.
8098 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8099 Now internal.
8100 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8101 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8102
8103 * editfns.c (Fformat): Remove unreachable code.
8104
8105 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8106
8107 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8108 change. (Bug#8496)
8109
8110 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8111
8112 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8113 when at ZV. (Bug#8487)
8114
8115 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8116
8117 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8118 (Bug#8437)
8119 * keyboard.c (parse_tool_bar_item): Likewise.
8120 * sound.c (sound_cleanup, alsa_close): Likewise.
8121 * termcap.c (tgetent): Likewise.
8122 * xfns.c (x_default_font_parameter): Likewise.
8123 * xsettings.c (read_and_apply_settings): Likewise.
8124
8125 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8126 (overrun_check_free): Protoize.
8127
8128 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8129
8130 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8131 since callers should never pass a negative size.
8132 Change the signature to match that of plain 'read' and 'write'; see
8133 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8134 * lisp.h: Update prototypes of emacs_write and emacs_read.
8135
8136 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8137
8138 * xdisp.c (redisplay_window): Don't try to determine the character
8139 position of the scroll margin if the window start point w->startp
8140 is outside the buffer's accessible region. (Bug#8468)
8141
8142 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8143
8144 Fix write-region and its subroutines for buffers > 2GB.
8145 * fileio.c (a_write, e_write): Modify declaration of arguments and
8146 local variables to support buffers larger than 2GB.
8147 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8148
8149 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8150 argument, local variables, and return value.
8151
8152 * lisp.h: Update prototypes of emacs_write and emacs_read.
8153
8154 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8155
8156 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8157
8158 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8159
8160 Fix more problems found by GCC 4.6.0's static checks.
8161
8162 * xdisp.c (vmessage): Use a better test for character truncation.
8163
8164 * charset.c (load_charset_map): <, not <=, for optimization,
8165 and to avoid potential problems with integer overflow.
8166 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8167 * casetab.c (set_identity, shuffle): Likewise.
8168 * editfns.c (Fformat): Likewise.
8169 * syntax.c (skip_chars): Likewise.
8170
8171 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8172 This also lets GCC 4.6.0 generate slightly better loop code.
8173
8174 * callint.c (Fcall_interactively): <, not <=, for optimization.
8175 (Fcall_interactively): Count the number of arguments produced,
8176 not the number of arguments given. This is simpler and lets GCC
8177 4.6.0 generate slightly better code.
8178
8179 * ftfont.c: Distingish more carefully between FcChar8 and char.
8180 The previous code passed unsigned char * to a functions like
8181 strlen and xstrcasecmp that expect char *, which does not
8182 conform to the C standard.
8183 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8184 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8185 char * when the C standard requires it.
8186
8187 * keyboard.c (read_char): Remove unused var.
8188
8189 * eval.c: Port to Windows vsnprintf (Bug#8435).
8190 Include <limits.h>.
8191 (SIZE_MAX): Define if the headers do not.
8192 (verror): Do not give up if vsnprintf returns a negative count.
8193 Instead, grow the buffer. This ports to Windows vsnprintf, which
8194 does not conform to C99. Problem reported by Eli Zaretskii.
8195 Also, simplify the allocation scheme, by avoiding the need for
8196 calling realloc, and removing the ALLOCATED variable.
8197
8198 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8199
8200 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8201 But keep the doprint source code for now, as we might revamp it
8202 and use it again (Bug#8435).
8203 * lisp.h (doprnt): Remove.
8204 * Makefile.in (base_obj): Remove doprnt.o.
8205 * deps.mk (doprnt.o): Remove.
8206
8207 error: Print 32- and 64-bit integers portably (Bug#8435).
8208 Without this change, on typical 64-bit hosts error ("...%d...", N)
8209 was used to print both 32- and 64-bit integers N, which relied on
8210 undefined behavior.
8211 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8212 * lisp.h (error, verror): Mark as printf-like functions.
8213 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8214 Report overflow in size calculations when allocating printf buffer.
8215 Do not truncate output string at its first null byte.
8216 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8217 Truncate the output at a character boundary, since vsnprintf does not
8218 do that.
8219 * charset.c (check_iso_charset_parameter): Convert internal
8220 character to string before calling 'error', since %c now has the
8221 printf meaning.
8222 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8223 overflow when computing char to be passed to 'error'. Do not
8224 pass Lisp_Object to 'error'; pass the integer instead.
8225 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8226 formatted with plain %d.
8227
8228 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8229
8230 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8231
8232 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8233
8234 * xterm.c (x_catch_errors): Remove duplicate declaration.
8235
8236 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8237
8238 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8239
8240 2011-04-10 Jim Meyering <meyering@redhat.com>
8241
8242 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8243 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8244 return ssize_t not "int", and use size_t as the buffer length.
8245 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8246 * gnutls.h: Update declarations.
8247 * process.c (read_process_output): Use ssize_t, to match.
8248 (send_process): Likewise.
8249
8250 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8251
8252 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8253
8254 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8255
8256 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8257 Use unsigned char, to match FcChar8 type definition.
8258
8259 * xterm.c (handle_one_xevent):
8260 * xmenu.c (create_and_show_popup_menu):
8261 * xselect.c (x_decline_selection_request)
8262 (x_reply_selection_request): Avoid type-punned deref of X events.
8263
8264 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8265
8266 Fix some uses of `int' instead of EMACS_INT.
8267 * search.c (string_match_1, fast_string_match)
8268 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8269 (scan_buffer, find_next_newline_no_quit)
8270 (find_before_next_newline, search_command, Freplace_match)
8271 (Fmatch_data): Make some `int' variables be EMACS_INT.
8272
8273 * xdisp.c (display_count_lines): 3rd argument and return value now
8274 EMACS_INT. All callers changed.
8275 (pint2hrstr): Last argument is now EMACS_INT.
8276
8277 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8278 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8279 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8280 (decode_coding_utf_16, decode_coding_emacs_mule)
8281 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8282 (decode_coding_ccl, decode_coding_charset)
8283 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8284 (decode_coding_iso_2022, decode_coding_emacs_mule)
8285 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8286 <char_offset, last_offset>: Declare EMACS_INT.
8287 (encode_coding_utf_8, encode_coding_utf_16)
8288 (encode_coding_emacs_mule, encode_invocation_designation)
8289 (encode_designation_at_bol, encode_coding_iso_2022)
8290 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8291 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8292 Declare EMACS_INT.
8293 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8294 (encode_invocation_designation): Last argument P_NCHARS is now
8295 EMACS_INT.
8296 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8297 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8298
8299 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8300 All users changed.
8301
8302 * ccl.c (Fccl_execute_on_string): Declare some variables
8303 EMACS_INT.
8304
8305 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8306
8307 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8308
8309 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8310
8311 * process.c (Fformat_network_address): Doc fix.
8312
8313 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8314
8315 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8316
8317 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8318
8319 * keyboard.c (read_char): Call Lisp function help-form-show,
8320 instead of using internal_with_output_to_temp_buffer.
8321 (Qhelp_form_show): New var.
8322 (syms_of_keyboard): Use DEFSYM macro.
8323
8324 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8325
8326 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8327
8328 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8329
8330 * process.c (Flist_processes): Remove to Lisp.
8331 (list_processes_1): Delete.
8332
8333 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8334
8335 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8336
8337 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8338
8339 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8340
8341 Fix more problems found by GCC 4.6.0's static checks.
8342
8343 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8344
8345 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8346
8347 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8348
8349 * xdisp.c (vmessage): Mark as a printf-like function.
8350
8351 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8352
8353 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8354
8355 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8356 printf-like functions.
8357 (tiff_load): Add casts to remove these marks before passing them
8358 to system-supplied API.
8359
8360 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8361
8362 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8363 This avoids several warnings with gcc -Wstrict-overflow.
8364 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8365 directly, rather than having caller test rule sign. This avoids
8366 some unnecessary tests.
8367 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8368 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8369 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8370
8371 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8372 (xfont_open): Avoid unnecessary tests.
8373
8374 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8375
8376 * composite.h, composite.c (composition_gstring_put_cache):
8377 Use EMACS_INT, not int, for length.
8378
8379 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8380 breaking out part of COMPOSITION_DECODE_RULE.
8381 (COMPOSITION_DECODE_RULE): Use it.
8382 * composite.c (get_composition_id): Remove unused local vars,
8383 by using the new macro.
8384
8385 * textprop.c (set_text_properties_1): Change while to do-while,
8386 since the condition is always true at first.
8387
8388 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8389 (interval_deletion_adjustment): Return unsigned value.
8390 All uses changed.
8391
8392 * process.c (list_processes_1, create_pty, read_process_output):
8393 (exec_sentinel): Remove vars that were set but not used.
8394 (create_pty): Remove unnecessary "volatile"s.
8395 (Fnetwork_interface_info): Avoid possibility of int overflow.
8396 (read_process_output): Do adaptive read buffering even if carryover.
8397 (read_process_output): Simplify nbytes computation if buffered.
8398
8399 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8400
8401 * syntax.c (scan_words): Remove var that was set but not used.
8402 (update_syntax_table): Use unsigned instead of int.
8403
8404 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8405 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8406 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8407
8408 * print.c (print_error_message): Avoid int overflow.
8409
8410 * font.c (font_list_entities): Redo for clarity,
8411 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8412
8413 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8414 (font_score): Avoid potential overflow in diff calculation.
8415
8416 * fns.c (substring_both): Remove var that is set but not used.
8417 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8418
8419 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8420
8421 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8422 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8423 can always succeed if overflow has undefined behavior.
8424
8425 * search.c (boyer_moore, wordify): Remove vars set but not used.
8426 (wordify): Omit three unnecessary tests.
8427
8428 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8429 All callers changed. This avoids the need for an unused var.
8430
8431 * casefiddle.c (casify_region): Remove var that is set but not used.
8432
8433 * dired.c (file_name_completion): Remove var that is set but not used.
8434
8435 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8436
8437 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8438 (Finsert_file_contents): Remove unnecessary code checking fd.
8439
8440 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8441 Check for integer overflow on size calculations.
8442
8443 * buffer.c (Fprevious_overlay_change): Remove var that is set
8444 but not used.
8445
8446 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8447 Remove vars that are set but not used.
8448 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8449 (timer_check_2): Mark vars as initialized.
8450
8451 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8452
8453 * image.c (lookup_image): Remove var that is set but not used.
8454 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8455
8456 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8457 that are set but not used.
8458
8459 * xfns.c (make_invisible_cursor): Don't return garbage
8460 if XCreateBitmapFromData fails (Bug#8410).
8461
8462 * xselect.c (x_get_local_selection, x_handle_property_notify):
8463 Remove vars that are set but not used.
8464
8465 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8466 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8467
8468 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8469 Remove var that is set but not used.
8470 (scroll_bar_windows_size): Now size_t, not int.
8471 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8472 Check for overflow.
8473
8474 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8475 (map_tty_color) [!defined MSDOS]: Likewise.
8476
8477 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8478
8479 * coding.c: Remove vars that are set but not used.
8480 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8481 All callers changed.
8482 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8483 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8484 (decode_coding_charset): Remove vars that are set but not used.
8485
8486 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8487 that is set but not used.
8488
8489 * print.c (print_object): Remove var that is set but not used.
8490
8491 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8492 The gnulib version avoids calling malloc in the usual case,
8493 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8494 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8495 * filelock.c (current_lock_owner): Likewise.
8496 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8497 * sysdep.c: Include allocator.h, careadlinkat.h.
8498 (emacs_no_realloc_allocator): New static constant.
8499 (emacs_readlink): New function.
8500 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8501 ../lib/careadlinkat.h.
8502
8503 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8504
8505 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8506 first non-nil return value).
8507
8508 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8509
8510 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8511 if not defined (Bug#8403).
8512
8513 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8514
8515 * xdisp.c (display_count_lines): Remove parameter `start',
8516 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8517 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8518 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8519 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8520 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8521 and thereabouts. All callers changed.
8522 (get_per_char_metric): Remove parameter `f', unused since
8523 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8524
8525 2011-04-02 Jim Meyering <meyering@redhat.com>
8526
8527 do not dereference NULL upon failed strdup
8528 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8529 (ns_get_family): Likewise.
8530
8531 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8532
8533 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8534
8535 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8536
8537 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8538 later (Bug#8403).
8539
8540 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8541
8542 Add lexical binding.
8543
8544 * window.c (Ftemp_output_buffer_show): New fun.
8545 (Fsave_window_excursion):
8546 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8547
8548 * lread.c (lisp_file_lexically_bound_p): New function.
8549 (Fload): Bind Qlexical_binding.
8550 (readevalloop): Remove `evalfun' arg.
8551 Bind Qinternal_interpreter_environment.
8552 (Feval_buffer): Bind Qlexical_binding.
8553 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8554 Mark as dynamic.
8555 (syms_of_lread): Declare `lexical-binding'.
8556
8557 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8558
8559 * keyboard.c (eval_dyn): New fun.
8560 (menu_item_eval_property): Use it.
8561
8562 * image.c (parse_image_spec): Use Ffunctionp.
8563
8564 * fns.c (concat, mapcar1): Accept byte-code-functions.
8565
8566 * eval.c (Fsetq): Handle lexical vars.
8567 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8568 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8569 (FletX, Flet): Obey lexical binding.
8570 (Fcommandp): Handle closures.
8571 (Feval): New `lexical' arg.
8572 (eval_sub): New function extracted from Feval. Use it almost
8573 everywhere where Feval was used. Look up vars in lexical env.
8574 Handle closures.
8575 (Ffunctionp): Move from subr.el.
8576 (Ffuncall): Handle closures.
8577 (apply_lambda): Remove `eval_flags'.
8578 (funcall_lambda): Handle closures and new byte-code-functions.
8579 (Fspecial_variable_p): New function.
8580 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8581 but without exporting it to Lisp.
8582
8583 * doc.c (Fdocumentation, store_function_docstring):
8584 * data.c (Finteractive_form): Handle closures.
8585
8586 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8587 interactive spec.
8588
8589 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8590 New byte-codes.
8591 (exec_byte_code): New function extracted from Fbyte_code to handle new
8592 calling convention for byte-code-functions. Add new byte-codes.
8593
8594 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8595
8596 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8597
8598 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8599
8600 * xdisp.c (redisplay_internal): Fix prototype.
8601
8602 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8603
8604 * xdisp.c (SCROLL_LIMIT): New macro.
8605 (try_scrolling): Use it when setting scroll_limit.
8606 Limit scrolling to 100 screen lines.
8607 (redisplay_window): Even when falling back on "recentering",
8608 position point in the window according to scroll-conservatively,
8609 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8610
8611 (try_scrolling): When point is above the window, allow searching
8612 as far as scroll_max, or one screenful, to compute vertical
8613 distance from PT to the scroll margin position. This prevents
8614 try_scrolling from unnecessarily failing when
8615 scroll-conservatively is set to a value slightly larger than the
8616 window height. Clean up the case of PT below the margin at bottom
8617 of window: scroll_max can no longer be INT_MAX. When aggressive
8618 scrolling is in use, don't let point enter the opposite scroll
8619 margin as result of the scroll.
8620 (syms_of_xdisp) <scroll-conservatively>: Document the
8621 threshold of 100 lines for never-recentering scrolling.
8622
8623 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8624
8625 * dispextern.h (move_it_by_lines):
8626 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8627 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8628 (message_log_check_duplicate): Remove parameters `prev_bol' and
8629 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8630 (redisplay_internal): Remove parameter `preserve_echo_area',
8631 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8632
8633 * indent.c (Fvertical_motion):
8634 * window.c (window_scroll_pixel_based, Frecenter):
8635 Don't pass `need_y_p' to `move_it_by_lines'.
8636
8637 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8638
8639 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8640 steal a few bits to be more compact.
8641 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8642 Remove unneeded casts.
8643
8644 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8645
8646 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8647
8648 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8649 binding" message (bug#7967).
8650
8651 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8652
8653 Fix more problems found by GCC 4.6.0's static checks.
8654
8655 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8656 Remove unused local var.
8657
8658 * editfns.c (Fmessage_box): Remove unused local var.
8659
8660 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8661 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8662 Omit unused local vars.
8663 * window.c (shrink_windows): Omit unused local var.
8664 * menu.c (digest_single_submenu): Omit unused local var.
8665 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8666 Omit unused local var.
8667
8668 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8669 Don't assume string length fits in int.
8670 (keyremap_step, read_key_sequence): Use size_t for sizes.
8671 (read_key_sequence): Don't check last_real_key_start redundantly.
8672
8673 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8674 instead of alloca (Bug#8344).
8675
8676 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8677 (Fbacktrace_frame): Don't assume nframes fits in int.
8678
8679 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8680
8681 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8682 concerns.
8683
8684 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8685
8686 * cm.c (calccost): Turn while-do into do-while, for clarity.
8687
8688 * keyboard.c (syms_of_keyboard): Use the same style as later
8689 in this function when indexing through an array. This also
8690 works around GCC bug 48267.
8691
8692 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8693
8694 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8695
8696 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8697 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8698
8699 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8700 This avoids undefined behavior on integer overflow, and is a bit
8701 more convenient anyway since it is compared to a size_t variable.
8702
8703 Variadic C functions now count arguments with size_t, not int.
8704 This avoids an unnecessary limitation on 64-bit machines, which
8705 caused (substring ...) to crash on large vectors (Bug#8344).
8706 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8707 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8708 All variadic functions and their callers changed accordingly.
8709 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8710 * data.c (arith_driver, float_arith_driver): Likewise.
8711 * editfns.c (general_insert_function): Likewise.
8712 * eval.c (struct backtrace.nargs, interactive_p)
8713 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8714 (funcall_lambda, mark_backtrace): Likewise.
8715 * fns.c (concat): Likewise.
8716 * frame.c (x_set_frame_parameters): Likewise.
8717 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8718 0 if not found, not -1. All callers changed.
8719
8720 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8721 (stack_copy_size): Now size_t, not int.
8722 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8723
8724 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8725
8726 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8727 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8728 All callers changed.
8729
8730 * lisp.h (multibyte_char_to_unibyte):
8731 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8732 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8733 * character.h (CHAR_TO_BYTE8):
8734 * cmds.c (internal_self_insert):
8735 * editfns.c (general_insert_function):
8736 * keymap.c (push_key_description):
8737 * search.c (Freplace_match):
8738 * xdisp.c (message_dolog, set_message_1): All callers changed.
8739
8740 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8741
8742 * keyboard.c (safe_run_hook_funcall): New function.
8743 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8744 don't set the hook to nil, but remove the offending function instead.
8745 (Qcommand_hook_internal): Remove, unused.
8746 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8747 Vcommand_hook_internal.
8748
8749 * eval.c (enum run_hooks_condition): Remove.
8750 (funcall_nil, funcall_not): New functions.
8751 (run_hook_with_args): Call each function through a `funcall' argument.
8752 Remove `cond' argument, now redundant.
8753 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8754 (Frun_hook_with_args_until_failure): Adjust accordingly.
8755 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8756
8757 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8758
8759 * dispextern.h (string_buffer_position): Remove declaration.
8760
8761 * print.c (strout): Remove parameter `multibyte', unused since
8762 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8763
8764 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8765 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8766 All callers changed.
8767
8768 * w32.c (_wsa_errlist): Use braces for struct initializers.
8769
8770 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8771 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8772 All callers changed.
8773 (string_buffer_position): Likewise. Also, make static (it's never
8774 used outside xdisp.c).
8775 (cursor_row_p): Remove parameter `w', unused since
8776 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8777 (decode_mode_spec): Remove parameter `precision', introduced during
8778 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8779 All callers changed.
8780
8781 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8782
8783 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8784
8785 2011-03-27 Anders Lindgren <andlind@gmail.com>
8786
8787 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8788 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8789 (ns_update_auto_hide_menu_bar): New functions.
8790 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8791 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8792 ns_constrain_all_frames.
8793 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8794 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8795
8796 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8797
8798 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8799
8800 2011-03-27 Glenn Morris <rgm@gnu.org>
8801
8802 * syssignal.h: Replace RETSIGTYPE with void.
8803 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8804 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8805 Replace SIGTYPE with void everywhere.
8806 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8807 * s/template.h (SIGTYPE): Remove commented out definition.
8808
8809 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8810
8811 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8812 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8813
8814 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8815
8816 * w32.c (read_unc_volume): Use parameter `henum', instead of
8817 global variable `wget_enum_handle'.
8818
8819 * keymap.c (describe_vector): Remove parameters `indices' and
8820 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8821 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8822
8823 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8824
8825 * keyboard.c (timer_check): Remove parameter `do_it_now',
8826 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8827 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8828 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8829
8830 * keyboard.c (read_char):
8831 * w32menu.c (w32_menu_display_help):
8832 * xmenu.c (show_help_event, menu_help_callback):
8833 Adjust calls to `show_help_echo'.
8834
8835 * gtkutil.c (xg_maybe_add_timer):
8836 * keyboard.c (readable_events):
8837 * process.c (wait_reading_process_output):
8838 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8839
8840 * insdel.c (adjust_markers_gap_motion):
8841 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8842 (gap_left, gap_right): Don't call it.
8843
8844 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8845
8846 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8847 incurred during fontification.
8848
8849 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8850
8851 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8852 (DEFVAR_PER_BUFFER): Don't pass it.
8853
8854 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8855 (scrolling_window): Don't pass it.
8856
8857 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8858
8859 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8860
8861 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8862 and `suffix'.
8863 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8864 of variables specific to SELinux and computation of `encoded_absname'.
8865
8866 * image.c (XPutPixel): Remove unused variable `height'.
8867
8868 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8869
8870 * unexw32.c (get_section_info): Remove unused variable `section'.
8871
8872 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8873 (system_process_attributes): Remove unused variable `sess'.
8874 (sys_read): Remove unused variable `err'.
8875
8876 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8877 (w32_wnd_proc): Remove unused variable `isdead'.
8878 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8879 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8880 (x_create_tip_frame): Remove unused variable `tem'.
8881
8882 * w32inevt.c (w32_console_read_socket):
8883 Remove unused variable `no_events'.
8884
8885 * w32term.c (x_draw_composite_glyph_string_foreground):
8886 Remove unused variable `width'.
8887
8888 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8889
8890 * w32term.c (x_set_glyph_string_clipping):
8891 Don't pass uninitialized region to CombineRgn.
8892
8893 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8894
8895 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8896 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8897 (Fx_close_connection): Remove unused variable `i'.
8898
8899 * w32font.c (w32font_draw): Return number of glyphs.
8900 (w32font_open_internal): Remove unused variable `i'.
8901 (w32font_driver): Add missing initializer.
8902
8903 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8904 (fill_in_menu): Remove unused variable `items_added'.
8905
8906 * w32term.c (last_mouse_press_frame): Remove static global variable.
8907 (w32_clip_to_row): Remove unused variable `f'.
8908 (x_delete_terminal): Remove unused variable `i'.
8909
8910 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8911 (NOTHING): Remove unused static global variable.
8912 (uniscribe_check_otf): Remove unused variable `table'.
8913 (uniscribe_font_driver): Add missing initializers.
8914
8915 2011-03-23 Julien Danjou <julien@danjou.info>
8916
8917 * term.c (Fsuspend_tty, Fresume_tty):
8918 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8919 * window.c (temp_output_buffer_show):
8920 * insdel.c (signal_before_change):
8921 * frame.c (Fhandle_switch_frame):
8922 * fileio.c (Fdo_auto_save):
8923 * emacs.c (Fkill_emacs):
8924 * editfns.c (save_excursion_restore):
8925 * cmds.c (internal_self_insert):
8926 * callint.c (Fcall_interactively):
8927 * buffer.c (Fkill_all_local_variables):
8928 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8929 Use Frun_hooks.
8930 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8931 unconditionally since it does the check itself.
8932
8933 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8934
8935 Fix more problems found by GCC 4.5.2's static checks.
8936
8937 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8938 the first time through the loop, since we know p0 < p1 then.
8939 This also avoids a gcc -Wstrict-overflow warning.
8940
8941 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8942 leading to a memory leak, possible in functions like
8943 load_charset_map_from_file that can allocate an unbounded number
8944 of objects (Bug#8318).
8945
8946 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8947 that could (at least in theory) be that large.
8948
8949 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8950 This is less likely to overflow, and avoids undefined behavior if
8951 overflow does occur. All callers changed. Use strtoul to scan
8952 for the unsigned long integer.
8953 (pint2hrstr): Simplify and tune code slightly.
8954 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8955
8956 * scroll.c (do_scrolling): Work around GCC bug 48228.
8957 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8958
8959 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8960 This also avoids a warning with gcc -Wstrict-overflow.
8961 (validate_x_resource_name): Simplify count usage.
8962 This also avoids a warning with gcc -Wstrict-overflow.
8963
8964 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8965 fail (Bug#8306).
8966
8967 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8968
8969 * process.c (Fmake_network_process): Use socklen_t, not int,
8970 where POSIX says socklen_t is required in portable programs.
8971 This fixes a porting bug on hosts like 64-bit HP-UX, where
8972 socklen_t is wider than int (Bug#8277).
8973 (Fmake_network_process, server_accept_connection):
8974 (wait_reading_process_output, read_process_output):
8975 Likewise.
8976
8977 * process.c: Rename or move locals to avoid shadowing.
8978 (list_processes_1, Fmake_network_process):
8979 (read_process_output_error_handler, exec_sentinel_error_handler):
8980 Rename or move locals.
8981 (Fmake_network_process): Define label "retry_connect" only if needed.
8982 (Fnetwork_interface_info): Fix pointer signedness.
8983 (process_send_signal): Add cast to avoid pointer signedness problem.
8984 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8985 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8986
8987 Make tparam.h and terminfo.c consistent.
8988 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8989 Include tparam.h instead, since it declares them.
8990 * cm.h (PC): Remove extern decl; tparam.h now does this.
8991 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8992 * terminfo.c: Include tparam.h, to check interfaces.
8993 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8994 (tparam): Adjust signature to match interface in tparam.h;
8995 this removes some undefined behavior. Check that outstring and len
8996 are zero, which they always are with Emacs.
8997 * tparam.h (PC, BC, UP): New extern decls.
8998
8999 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9000 (xftfont_open): Rename locals to avoid shadowing.
9001
9002 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9003 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9004 (OTF_TAG_SYM): Omit macro if not needed.
9005 (ftfont_list): Remove unused local.
9006 (get_adstyle_property, ftfont_pattern_entity):
9007 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9008 Rename locals to avoid shadowing.
9009
9010 * xfont.c (xfont_list_family): Mark var as initialized.
9011
9012 * xml.c (make_dom): Now static.
9013
9014 * composite.c (composition_compute_stop_pos): Rename local to
9015 avoid shadowing.
9016 (composition_reseat_it): Remove unused locals.
9017 (find_automatic_composition, composition_adjust_point): Likewise.
9018 (composition_update_it): Mark var as initialized.
9019 (find_automatic_composition): Mark vars as initialized,
9020 with a FIXME (Bug#8290).
9021
9022 character.h: Rename locals to avoid shadowing.
9023 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9024 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9025 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9026 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9027 to avoid shadowing.
9028
9029 * textprop.c (property_change_between_p): Remove; unused.
9030
9031 * intervals.c (interval_start_pos): Now static.
9032
9033 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9034
9035 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9036 Rename locals to avoid shadowing.
9037
9038 * sound.c (wav_play, au_play, Fplay_sound_internal):
9039 Fix pointer signedness.
9040 (alsa_choose_format): Remove unused local var.
9041 (wav_play): Initialize a variable to 0, to prevent undefined
9042 behavior (Bug#8278).
9043
9044 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9045
9046 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9047
9048 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9049 clobbering (Bug#8298).
9050 * sysdep.c (sys_subshell): Likewise.
9051 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9052
9053 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9054 This should get cleaned up, so that child_setup has the
9055 same signature on all platforms.
9056
9057 * callproc.c (call_process_cleanup): Now static.
9058 (relocate_fd): Rename locals to avoid shadowing.
9059
9060 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9061
9062 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9063 not to be necessary, and produces flickering.
9064
9065 2011-03-20 Glenn Morris <rgm@gnu.org>
9066
9067 * config.in: Remove file.
9068
9069 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9070
9071 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9072 are now in src/globals.h.
9073 (syms_of_minibuf): Remove spurious & from previous change.
9074
9075 2011-03-20 Leo Liu <sdl.web@gmail.com>
9076
9077 * minibuf.c (completing-read-function): New variable.
9078 (completing-read-default): Rename from completing-read.
9079 (completing-read): Call completing-read-function.
9080
9081 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9082
9083 * xfaces.c (Fx_load_color_file):
9084 Read color file from absolute filename (bug#8250).
9085
9086 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9087
9088 * makefile.w32-in: Update dependencies.
9089
9090 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9091
9092 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9093
9094 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9095
9096 Fix more problems found by GCC 4.5.2's static checks.
9097
9098 * process.c (make_serial_process_unwind, send_process_trap):
9099 (sigchld_handler): Now static.
9100
9101 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9102 That way, the code declares only the vars that it needs.
9103 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9104 * s/cygwin.h (PTY_ITERATION): Likewise.
9105 * s/darwin.h (PTY_ITERATION): Likewise.
9106 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9107
9108 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9109 * process.c (allocate_pty): Don't declare stb unless it's needed.
9110
9111 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9112 (CONSTANTLIM): Remove; unused.
9113 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9114 Define only if needed.
9115
9116 * unexelf.c (unexec): Name an expression,
9117 to avoid gcc -Wbad-function-cast warning.
9118 Use a different way to cause a compilation error if anyone uses
9119 n rather than nn, a way that does not involve shadowing.
9120 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9121
9122 * deps.mk (unexalpha.o): Remove; unused.
9123
9124 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9125 * unexec.h: New file.
9126 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9127 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9128 Depend on unexec.h.
9129 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9130 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9131 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9132 Change as necessary to match prototype in unexec.h.
9133
9134 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9135 shadowing.
9136 (back_comment, skip_chars): Mark vars as initialized.
9137
9138 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9139 Rename locals to avoid shadowing.
9140
9141 * lread.c (read1): Rewrite so as not to use empty "else".
9142 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9143
9144 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9145
9146 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9147 warning when compiling print.c.
9148
9149 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9150 instead of using an uninitialized var.
9151 (font_sort_entities): Mark var as initialized.
9152
9153 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9154
9155 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9156 pointers to constants.
9157 (font_parse_fcname): Remove unused vars.
9158 (font_delete_unmatched): Now static.
9159 (font_get_spec): Remove; unused.
9160 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9161 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9162 Rename or move locals to avoid shadowing.
9163
9164 * fns.c (require_nesting_list, require_unwind): Now static.
9165 (Ffillarray): Rename locals to avoid shadowing.
9166
9167 * floatfns.c (domain_error2): Define only if needed.
9168 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9169
9170 * alloc.c (mark_backtrace): Move decl from here ...
9171 * lisp.h: ... to here, so that it can be checked.
9172
9173 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9174 (Fdefvar): Rewrite so as not to use empty "else".
9175 (lisp_indirect_variable): Name an expression,
9176 to avoid gcc -Wbad-function-cast warning.
9177 (Fdefvar): Rename locals to avoid shadowing.
9178
9179 * callint.c (quotify_arg, quotify_args): Now static.
9180 (Fcall_interactively): Rename locals to avoid shadowing.
9181 Use const pointer when appropriate.
9182
9183 * lisp.h (get_system_name, get_operating_system_release):
9184 Move decls here, to check interfaces.
9185 * process.c (get_operating_system_release): Move decl to lisp.h.
9186 * xrdb.c (get_system_name): Likewise.
9187 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9188 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9189 some of which prompt warnings from gcc -Wbad-function-cast.
9190 (Fformat_time_string, Fencode_time, Finsert_char):
9191 (Ftranslate_region_internal, Fformat):
9192 Rename or remove local vars to avoid shadowing.
9193 (Ftranslate_region_internal): Mark var as initialized.
9194
9195 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9196 avoid shadowing.
9197
9198 * lisp.h (eassert): Check that the argument compiles, even if
9199 ENABLE_CHECKING is not defined.
9200
9201 * data.c (Findirect_variable): Name an expression, to avoid
9202 gcc -Wbad-function-cast warning.
9203 (default_value, arithcompare, arith_driver, arith_error): Now static.
9204 (store_symval_forwarding): Rename local to avoid shadowing.
9205 (Fmake_variable_buffer_local, Fmake_local_variable):
9206 Mark variables as initialized.
9207 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9208
9209 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9210 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9211 Rename locals to avoid shadowing.
9212 (mark_stack): Move local variables into the #ifdef region where
9213 they're used.
9214 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9215 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9216 needed otherwise.
9217 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9218 (GC_STRING_CHARS): Remove; not used.
9219 (Fmemory_limit): Cast sbrk's returned value to char *.
9220
9221 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9222 avoids undefined behavior in theory.
9223
9224 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9225
9226 Use functions, not macros, for up- and down-casing (Bug#8254).
9227 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9228 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9229 to use the following functions instead of these macros.
9230 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9231 EMACS_INT, since callers assume the returned value fits in int.
9232 (upcase1): Likewise, for UPCASE_TABLE.
9233 (uppercasep, lowercasep, upcase): New static inline functions.
9234 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9235 the race-condition problem in the old DOWNCASE.
9236
9237 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9238 Rename locals to avoid shadowing.
9239 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9240 (regex_compile, re_search_2, re_match_2_internal):
9241 Remove unused local vars.
9242 (FREE_VAR): Rewrite so as not to use empty "else",
9243 which gcc can warn about.
9244 (regex_compile, re_match_2_internal): Mark locals as initialized.
9245 (RETALLOC_IF): Define only if needed.
9246 (WORDCHAR_P): Likewise. This one is never needed, but is used
9247 only in a comment talking about a compiler bug, so put inside
9248 the #if 0 of that comment.
9249 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9250 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9251 Remove; unused.
9252
9253 * search.c (boyer_moore): Rename locals to avoid shadowing.
9254 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9255 (PREV_CHAR_BOUNDARY): Likewise.
9256
9257 * search.c (simple_search): Remove unused var.
9258
9259 * dired.c (compile_pattern): Move decl from here ...
9260 * lisp.h: ... to here, so that it can be checked.
9261 (struct re_registers): New forward decl.
9262
9263 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9264
9265 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9266 All uses changed.
9267 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9268 Rename locals to avoid shadowing.
9269 (Fvertical_motion): Mark locals as initialized.
9270
9271 * casefiddle.c (casify_object, casify_region): Now static.
9272 (casify_region): Mark local as initialized.
9273
9274 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9275
9276 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9277 New macros, so that the caller can use some names other than
9278 gcpro1, gcpro2, etc.
9279 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9280 of the new macros.
9281 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9282 argument, for consistency with GCPRO2_VAR, etc: it is now the
9283 prefix of the variable, not the variable itself. All uses
9284 changed.
9285 * dired.c (directory_files_internal, file_name_completion):
9286 Rename locals to avoid shadowing.
9287
9288 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9289 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9290 dired.c's scmp function, had undefined behavior.
9291 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9292 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9293 * buffer.h: ... to here, because these macros use current_buffer,
9294 and the new implementation with inline functions needs to have
9295 current_buffer in scope now, rather than later when the macros
9296 are used.
9297 (downcase, upcase1): New static inline functions.
9298 (DOWNCASE, UPCASE1): Reimplement using these functions.
9299 This avoids undefined behavior in expressions like
9300 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9301 from race conditions in accessing the global variables
9302 case_temp1 and case_temp2.
9303 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9304 * lisp.h (case_temp1, case_temp2): Remove their decls.
9305 * character.h (ASCII_CHAR_P): Move from here ...
9306 * lisp.h: ... to here, so that the inline functions mentioned
9307 above can use them.
9308
9309 * dired.c (directory_files_internal_unwind): Now static.
9310
9311 * fileio.c (file_name_as_directory, directory_file_name):
9312 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9313 Now static.
9314 (file_name_as_directory): Use const pointers when appropriate.
9315 (Fexpand_file_name): Likewise. In particular, newdir might
9316 point at constant storage, so make it a const pointer.
9317 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9318 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9319 signedness issues.
9320 (Fset_file_times, Finsert_file_contents, auto_save_error):
9321 Rename locals to avoid shadowing.
9322
9323 * minibuf.c (choose_minibuf_frame_1): Now static.
9324 (Ftry_completion, Fall_completions): Rename or remove locals
9325 to avoid shadowing.
9326
9327 * marker.c (bytepos_to_charpos): Remove; unused.
9328
9329 * lisp.h (verify_bytepos, count_markers): New decls,
9330 so that gcc does not warn that these functions aren't declared.
9331
9332 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9333 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9334 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9335 (copy_text): Remove unused local var.
9336
9337 * filelock.c (within_one_second): Now static.
9338 (lock_file_1): Rename local to avoid shadowing.
9339
9340 * buffer.c (fix_overlays_before): Mark locals as initialized.
9341 (fix_start_end_in_overlays): Likewise. This function should be
9342 simplified by using pointers-to-pointers, but that's a different
9343 matter.
9344 (switch_to_buffer_1): Now static.
9345 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9346 (report_overlay_modification): Rename locals to avoid shadowing.
9347
9348 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9349 Fix pointer signedness issue.
9350 (sys_subshell): Mark local as volatile if checking for lint,
9351 to suppress a gcc -Wclobbered warning that does not seem to be right.
9352 (MAXPATHLEN): Define only if needed.
9353
9354 * process.c (serial_open, serial_configure): Move decls from here ...
9355 * systty.h: ... to here, so that they can be checked.
9356
9357 * fns.c (get_random, seed_random): Move extern decls from here ...
9358 * lisp.h: ... to here, so that they can be checked.
9359
9360 * sysdep.c (reset_io): Now static.
9361 (wait_for_termination_signal): Remove; unused.
9362
9363 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9364 (copy_keymap_item, append_key, push_text_char_description):
9365 Now static.
9366 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9367 (DENSE_TABLE_SIZE): Remove; unused.
9368 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9369 (describe_map_tree):
9370 Rename locals to avoid shadowing.
9371
9372 * keyboard.c: Declare functions static if they are not used elsewhere.
9373 (echo_char, echo_dash, cmd_error, top_level_2):
9374 (poll_for_input, handle_async_input): Now static.
9375 (read_char, kbd_buffer_get_event, make_lispy_position):
9376 (make_lispy_event, make_lispy_movement, apply_modifiers):
9377 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9378 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9379 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9380 (read_key_sequence, read_char): Mark locals as initialized.
9381 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9382
9383 * keyboard.h (make_ctrl_char): New decl.
9384 (mark_kboards): Move decl here ...
9385 * alloc.c (mark_kboards): ... from here.
9386
9387 * lisp.h (force_auto_save_soon): New decl.
9388
9389 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9390 (DEFINE_DUMMY_FUNCTION): New macro.
9391 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9392 Use it.
9393 (main): Add casts to avoid warnings
9394 if GCC considers string literals to be constants.
9395
9396 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9397
9398 * dbusbind.c: Pointer signedness fixes.
9399 (xd_signature, xd_append_arg, xd_initialize):
9400 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9401 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9402 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9403 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9404
9405 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9406 if GCC considers string literals to be constants.
9407 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9408
9409 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9410
9411 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9412 (print_preprocess, print_object): New macro to fix last change.
9413
9414 * print.c (print_preprocess): Don't forget font objects.
9415
9416 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9417
9418 * emacs.c (USAGE3): Doc fixes.
9419
9420 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9421
9422 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9423 structure.
9424
9425 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9426
9427 * lisp.h (VWindow_system, Qfile_name_history):
9428 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9429 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9430 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9431
9432 * w32select.c: Don't #include "keyboard.h".
9433 (run_protected): Add extern declaration for waiting_for_input.
9434
9435 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9436 * w32console.c (detect_input_pending, read_input_pending)
9437 (encode_terminal_code):
9438 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9439 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9440 (w32_system_caret_y, Qfile_name_history):
9441 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9442 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9443 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9444 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9445 * w32proc.c (Qlocal, report_file_error):
9446 * w32term.c (Vwindow_system, updating_frame):
9447 * w32uniscribe.c (initialized, uniscribe_font_driver):
9448 Remove unneeded extern declarations.
9449
9450 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9451
9452 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9453
9454 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9455
9456 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9457 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9458 These macros can no longer be used for assignment.
9459
9460 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9461 Assign struct members directly, instead of using BUF_BEGV etc.
9462 (record_buffer_markers, fetch_buffer_markers): New functions for
9463 recording and fetching special buffer markers.
9464 (set_buffer_internal_1, set_buffer_temp): Use them.
9465
9466 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9467
9468 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9469
9470 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9471 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9472
9473 * xdisp.c (hscroll_window_tree):
9474 (reconsider_clip_changes): Use PT instead of BUF_PT.
9475
9476 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9477
9478 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9479 $(EMACS_ROOT)/lib/intprops.h.
9480
9481 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9482
9483 Fix more problems found by GCC 4.5.2's static checks.
9484
9485 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9486 to unsigned char * to avoid compiler diagnostic.
9487 (xg_free_frame_widgets): Make it clear that a local variable is
9488 needed only if USE_GTK_TOOLTIP.
9489 (gdk_window_get_screen): Make it clear that this macro is needed
9490 only if USE_GTK_TOOLTIP.
9491 (int_gtk_range_get_value): New function, which avoids a diagnostic
9492 from gcc -Wbad-function-cast.
9493 (xg_set_toolkit_scroll_bar_thumb): Use it.
9494 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9495 diagnostic from gcc -Wbad-function-cast.
9496 (get_utf8_string, xg_get_file_with_chooser):
9497 Rename locals to avoid shadowing.
9498 (create_dialog): Move locals to avoid shadowing.
9499
9500 * xgselect.c (xg_select): Remove unused var.
9501
9502 * image.c (four_corners_best): Mark locals as initialized.
9503 (gif_load): Initialize transparent_p to zero (Bug#8238).
9504 Mark another local as initialized.
9505 (my_png_error, my_error_exit): Mark with NO_RETURN.
9506
9507 * image.c (clear_image_cache): Now static.
9508 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9509 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9510 (x_edge_detection): Remove unnecessary cast that
9511 gcc -Wbad-function-cast diagnoses.
9512 (gif_load): Fix pointer signedness.
9513 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9514 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9515
9516 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9517
9518 Improve quality of tests for time stamp overflow.
9519 For example, without this patch (encode-time 0 0 0 1 1
9520 1152921504606846976) returns the obviously-bogus value (-948597
9521 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9522 reports time overflow. See
9523 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9524 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9525 * editfns.c: Include limits.h and intprops.h.
9526 (TIME_T_MIN, TIME_T_MAX): New macros.
9527 (time_overflow): Move earlier, to before first use.
9528 (hi_time, lo_time): New functions, for an accurate test for
9529 out-of-range times.
9530 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9531 (Fget_internal_run_time): Don't assume time_t fits in int.
9532 (make_time): Use list2 instead of Fcons twice.
9533 (Fdecode_time): More accurate test for out-of-range times.
9534 (check_tm_member): New function.
9535 (Fencode_time): Use it, to test for out-of-range times.
9536 (lisp_time_argument): Don't rely on undefined left-shift and
9537 right-shift behavior when checking for time stamp overflow.
9538
9539 * editfns.c (time_overflow): New function, refactoring common code.
9540 (Fformat_time_string, Fdecode_time, Fencode_time):
9541 (Fcurrent_time_string): Use it.
9542
9543 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9544 * dired.c (make_time): Move to ...
9545 * editfns.c (make_time): ... here.
9546 * systime.h: Note the move.
9547
9548 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9549
9550 * fringe.c (update_window_fringes): Remove unused variables.
9551
9552 * unexmacosx.c (copy_data_segment): Also copy __got section.
9553 (Bug#8223)
9554
9555 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9556
9557 * termcap.c [MSDOS]: Include "msdos.h".
9558 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9559 Constify `char *' arguments and their references according to
9560 prototypes in tparam.h.
9561
9562 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9563
9564 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9565 Adapt all references accordingly.
9566
9567 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9568
9569 2011-03-11 Tom Tromey <tromey@redhat.com>
9570
9571 * buffer.c (syms_of_buffer): Remove obsolete comment.
9572
9573 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9574
9575 * termhooks.h (encode_terminal_code): Declare prototype.
9576
9577 * msdos.c (encode_terminal_code): Don't declare prototype.
9578
9579 * term.c (encode_terminal_code): Now external again, used by
9580 w32console.c and msdos.c.
9581
9582 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9583 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9584
9585 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9586
9587 Fix some minor problems found by GCC 4.5.2's static checks.
9588
9589 * fringe.c (update_window_fringes): Mark locals as initialized
9590 (Bug#8227).
9591 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9592
9593 * alloc.c (mark_fringe_data): Move decl from here ...
9594 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9595 to check its interface.
9596 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9597
9598 * fontset.c (free_realized_fontset): Now static.
9599 (Fset_fontset_font): Rename local to avoid shadowing.
9600 (fontset_font): Mark local as initialized.
9601 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9602
9603 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9604
9605 * xselect.c (x_disown_buffer_selections): Remove; not used.
9606 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9607 (x_own_selection, Fx_disown_selection_internal): Rename locals
9608 to avoid shadowing.
9609 (x_handle_dnd_message): Remove local to avoid shadowing.
9610
9611 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9612 so that the caller can use some name other than gcpro1.
9613 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9614 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9615 (Fx_backspace_delete_keys_p):
9616 Use them to avoid shadowing, and rename vars to avoid shadowing.
9617 (x_decode_color, x_set_name, x_window): Now static.
9618 (Fx_create_frame): Add braces to silence GCC warning.
9619 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9620 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9621 Remove unused locals.
9622 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9623 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9624 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9625 macros.
9626
9627 * xterm.h (x_mouse_leave): New decl.
9628
9629 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9630 Remove unused functions.
9631 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9632 (x_calc_absolute_position): Now static.
9633 (XTread_socket): Don't define label "out" unless it's used.
9634 Don't declare local "event" unless it's used.
9635 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9636 unless they are used.
9637 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9638 (x_fatal_error_signal): Remove; not used.
9639 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9640 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9641 (x_error_catcher, x_connection_closed, x_error_handler):
9642 (x_error_quitter, xembed_send_message, x_iconify_frame):
9643 (my_log_handler): Rename locals to avoid shadowing.
9644 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9645 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9646
9647 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9648 Rename or move locals to avoid shadowing.
9649 (tty_defined_color, merge_face_heights): Now static.
9650 (free_realized_faces_for_fontset): Remove; not used.
9651 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9652 does not deduce is never used uninitialized.
9653 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9654 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9655
9656 * terminal.c (store_terminal_param): Now static.
9657
9658 * xmenu.c (menu_highlight_callback): Now static.
9659 (set_frame_menubar): Remove unused local.
9660 (xmenu_show): Rename parameter to avoid shadowing.
9661 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9662 since they might point to immutable storage.
9663 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9664 since it's unused otherwise.
9665
9666 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9667 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9668 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9669 avoids a gcc -Wuninitialized diagnostic.
9670 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9671 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9672 does not deduce are never used uninitialized.
9673
9674 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9675
9676 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9677 * window.c (window_loop, size_window):
9678 (run_window_configuration_change_hook, enlarge_window): Likewise.
9679
9680 * window.c (display_buffer): Now static.
9681 (size_window): Mark variables that gcc -Wuninitialized
9682 does not deduce are never used uninitialized.
9683 * window.h (check_all_windows): New decl, to forestall
9684 gcc -Wmissing-prototypes diagnostic.
9685 * dispextern.h (bidi_dump_cached_states): Likewise.
9686
9687 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9688 shadowing.
9689 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9690 Include <limits.h>.
9691 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9692 and to avoid gcc -Wuninitialized warning.
9693 (load_charset_map): Mark variables that gcc -Wuninitialized
9694 does not deduce are never used uninitialized.
9695 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9696
9697 * coding.c (coding_set_source, coding_set_destination):
9698 Use "else { /* comment */ }" rather than "else /* comment */;"
9699 for clarity, and to avoid gcc -Wempty-body warning.
9700 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9701 a block, when the outer 'i' will do.
9702 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9703 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9704 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9705 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9706 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9707 Rename locals to avoid shadowing.
9708 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9709 * coding.c (emacs_mule_char, encode_invocation_designation):
9710 Now static, since they're not used elsewhere.
9711 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9712 (decode_coding_object, encode_coding_object, detect_coding_system):
9713 (decode_coding_emacs_mule): Mark variables that gcc
9714 -Wuninitialized does not deduce are never used uninitialized.
9715 (detect_coding_iso_2022): Initialize a local variable that might
9716 be used uninitialized. Leave a FIXME because it's not clear that
9717 this initialization is needed. (Bug#8211)
9718 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9719 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9720 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9721 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9722 Remove unused macros.
9723
9724 * category.c (hash_get_category_set): Remove unused local var.
9725 (copy_category_table): Now static, since it's not used elsewhere.
9726 * character.c (string_count_byte8): Likewise.
9727
9728 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9729 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9730
9731 * chartab.c (copy_sub_char_table): Now static, since it's not used
9732 elsewhere.
9733 (sub_char_table_ref_and_range, char_table_ref_and_range):
9734 Rename locals to avoid shadowing.
9735 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9736
9737 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9738 (BIDI_BOB): Remove unused macro.
9739
9740 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9741 deduce are never used uninitialized.
9742 * term.c (encode_terminal_code): Likewise.
9743
9744 * term.c (encode_terminal_code): Now static. Remove unused local.
9745
9746 * tparam.h: New file.
9747 * term.c, tparam.h: Include it.
9748 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9749 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9750 Move these decls to tparam.h, and make them agree with what
9751 is actually in tparam.c. The previous trick of using incompatible
9752 decls in different modules does not conform to the C standard.
9753 All callers of tparam changed to use tparam's actual API.
9754 * tparam.c (tparam1, tparam, tgoto):
9755 Use const pointers where appropriate.
9756
9757 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9758 * cm.h (struct cm): Likewise.
9759 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9760 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9761 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9762 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9763 (turn_on_face, init_tty): Likewise.
9764 * termchar.h (struct tty_display_info): Likewise.
9765
9766 * term.c (term_mouse_position): Rename local to avoid shadowing.
9767
9768 * alloc.c (mark_ttys): Move decl from here ...
9769 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9770
9771 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9772
9773 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9774
9775 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9776
9777 * search.c (compile_pattern_1): Remove argument regp, unused since
9778 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9779 (compile_pattern): Don't pass it.
9780
9781 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9782
9783 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9784 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9785 for ! HAVE_GTK3.
9786 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9787
9788 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9789
9790 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9791 gdk_window_get_screen, gdk_window_get_geometry,
9792 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9793 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9794 (xg_get_pixbuf_from_pixmap): New function.
9795 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9796 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9797 Call xg_get_pixbuf_from_pixmap instead of
9798 gdk_pixbuf_get_from_drawable.
9799 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9800 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9801 (xg_check_special_colors): Use GtkStyleContext and its functions
9802 for HAVE_GTK3.
9803 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9804 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9805 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9806 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9807 Call gtk_widget_get_preferred_size.
9808 (xg_frame_resized): gdk_window_get_geometry only takes 5
9809 parameters.
9810 (xg_win_to_widget, xg_event_is_for_menubar):
9811 Call gdk_x11_window_lookup_for_display.
9812 (xg_set_widget_bg): New function.
9813 (delete_cb): New function.
9814 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9815 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9816 (xg_set_background_color): Call xg_set_widget_bg.
9817 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9818 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9819 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9820 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9821 if ! HAVE_GTK3.
9822 (update_frame_tool_bar): Call gtk_widget_hide.
9823 (xg_initialize): Use GDK_KEY_g.
9824
9825 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9826 if ! HAVE_GTK3
9827 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9828
9829 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9830 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9831 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9832
9833 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9834
9835 * w32xfns.c (select_palette): Check success of RealizePalette against
9836 GDI_ERROR, not zero.
9837
9838 See ChangeLog.11 for earlier changes.
9839
9840 ;; Local Variables:
9841 ;; coding: utf-8
9842 ;; End:
9843
9844 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9845
9846 This file is part of GNU Emacs.
9847
9848 GNU Emacs is free software: you can redistribute it and/or modify
9849 it under the terms of the GNU General Public License as published by
9850 the Free Software Foundation, either version 3 of the License, or
9851 (at your option) any later version.
9852
9853 GNU Emacs is distributed in the hope that it will be useful,
9854 but WITHOUT ANY WARRANTY; without even the implied warranty of
9855 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9856 GNU General Public License for more details.
9857
9858 You should have received a copy of the GNU General Public License
9859 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.