1 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3 Assume support for memcmp, memcpy, memmove, memset.
4 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5 * regex.c (memcmp, memcpy):
6 Remove; we assume C89 now.
8 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9 (__malloc_safe_bcopy): Remove; no longer needed.
11 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
12 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
13 well either way, and we prefer signed to unsigned.
15 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
17 Remove unportable assumption about struct layout (Bug#8884).
18 * alloc.c (mark_buffer):
19 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
20 (clone_per_buffer_values): Don't assume that
21 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
22 This isn't true in general, and it's particularly not true
23 if Emacs is configured with --with-wide-int.
24 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
25 New macros, used in the buffer.c change.
27 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
29 * xsettings.c: Use both GConf and GSettings if both are available.
30 (store_config_changed_event): Add comment.
31 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
32 (store_tool_bar_style_changed): New functions.
33 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
34 (struct xsettings): Move font inside HAVE_XFT.
35 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
36 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
38 (something_changed_gsettingsCB): Renamed from something_changedCB.
39 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
41 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
42 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
43 (something_changed_gconfCB): Renamed from something_changedCB.
44 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
45 (parse_settings): Move check for font inside HAVE_XFT.
46 (read_settings, apply_xft_settings): Add comment.
47 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
48 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
49 call store_font_name_changed.
50 (xft_settings_event): Add comment.
51 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
52 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
53 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
54 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
55 (xsettings_initialize): Call init_gsettings last.
56 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
59 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
61 Random fixes. E.g., (random) never returned negative values.
62 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
63 subseconds part to the entropy, as that's a bit more random.
64 Prefer signed to unsigned, since the signedness doesn't matter and
65 in general we prefer signed. When given a limit, use a
66 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
67 latter isn't right if USE_2_TAGS_FOR_INTS.
68 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
69 not 0..VALMASK. Don't discard "excess" bits that random () returns.
71 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
73 * textprop.c (text_property_stickiness):
74 Obey Vtext_property_default_nonsticky.
75 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
76 * w32fns.c (syms_of_w32fns):
77 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
79 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
81 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
82 This is more efficient than Ffile_directory_p and avoids a minor race.
84 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
86 * buffer.c (Foverlay_put): Say what the return value is
89 * fileio.c (barf_or_query_if_file_exists): Check first if the file
90 is a directory before asking whether to use the file name
92 (barf_or_query_if_file_exists): Make the "File is a directory"
93 error be more correct.
95 * fns.c (Frequire): Remove the mention of the .gz files, since
96 that's installation-specific, but keep the mention of
99 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
101 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
102 Report string overflow if the output is too long.
104 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
106 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
107 (syms_of_gnutls): Remove duplicate DEFSYM for
108 Qgnutls_bootprop_verify_hostname_error, an error for
109 Qgnutls_bootprop_verify_error (which is no longer used).
111 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
112 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
113 Also (re)move comments that are misplaced or no longer relevant.
115 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
117 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
119 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
121 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
122 and background color parameters if they have been changed.
124 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
126 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
128 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
130 * xsettings.c (SYSTEM_FONT): Define only when used.
131 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
133 * keymap.c (access_keymap_1): Now static.
135 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
137 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
138 leave any prefix arg for the up event (Bug#1586).
140 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
142 * lread.c (syms_of_lread): Mention single symbols defined by
143 `defvar' or `defconst' (bug#7154).
145 * fns.c (Frequire): Mention .el.gz files (bug#7314).
146 (Frequire): Mention get-load-suffixes.
148 2011-07-02 Martin Rudalics <rudalics@gmx.at>
150 * window.h (window): Remove clone_number slot.
151 * window.c (Fwindow_clone_number, Fset_window_clone_number):
153 (make_parent_window, make_window, saved_window)
154 (Fset_window_configuration, save_window_save): Don't deal with
156 * buffer.c (Qclone_number): Remove declaration.
157 (sort_overlays, overlay_strings): Don't deal with clone numbers.
159 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
161 Add multiple inheritance to keymaps.
162 * keymap.c (Fmake_composed_keymap): New function.
163 (Fset_keymap_parent): Simplify.
164 (fix_submap_inheritance): Remove.
165 (access_keymap_1): New function extracted from access_keymap to handle
166 embedded parents and handle lists of maps.
167 (access_keymap): Use it.
168 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
169 (Fcopy_keymap): Handle embedded parents.
170 (Fcommand_remapping, define_as_prefix): Simplify.
171 (Fkey_binding): Simplify.
172 (syms_of_keymap): Move minibuffer-local-completion-map,
173 minibuffer-local-filename-completion-map,
174 minibuffer-local-must-match-map, and
175 minibuffer-local-filename-must-match-map to Elisp.
176 (syms_of_keymap): Defsubr make-composed-keymap.
177 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
178 (parse_menu_item): Trivial simplification.
180 2011-07-01 Glenn Morris <rgm@gnu.org>
182 * Makefile.in (SETTINGS_LIBS): Fix typo.
184 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
186 * coding.c (Fencode_coding_string): Record the last coding system
187 used, as the function doc string says (bug#8738).
189 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
191 * xsettings.c (store_monospaced_changed): Take new font as arg and
192 check for change against current_mono_font.
193 (EMACS_TYPE_SETTINGS): Remove this and related defines.
194 (emacs_settings_constructor, emacs_settings_get_property)
195 (emacs_settings_set_property, emacs_settings_class_init)
196 (emacs_settings_init, gsettings_obj): Remove.
197 (something_changedCB): New function for HAVE_GSETTINGS.
198 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
199 with value as argument.
200 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
201 g_settings_new (Bug#8967). Do not create gsettings_obj.
202 Remove calls to g_settings_bind. Connect something_changedCB to
205 * xgselect.c: Add defined (HAVE_GSETTINGS).
206 (xgselect_initialize): Ditto.
208 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
209 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
212 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
214 * eval.c (struct backtrace): Simplify and port the data structure.
215 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
216 signed bit field, as this assumption is not portable and it makes
217 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
218 "char debug_on_exit : 1" as this is not portable either; instead,
219 use the portable "unsigned int debug_on_exit : 1". Remove unused
220 member evalargs. Remove obsolete comments about cc bombing out.
222 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
224 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
225 Let HAVE_GSETTINGS override HAVE_GCONF.
226 (store_monospaced_changed): New function.
227 (EMACS_SETTINGS): A new type derived from GObject to handle
228 GSettings notifications.
229 (emacs_settings_constructor, emacs_settings_get_property)
230 (emacs_settings_set_property, emacs_settings_class_init):
232 (gsettings_client, gsettings_obj): New variables.
233 (GSETTINGS_SCHEMA): New define.
234 (something_changedCB): Call store_monospaced_changed.
235 (init_gsettings): New function.
236 (xsettings_initialize): Call init_gsettings.
237 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
240 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
243 2011-06-29 Martin Rudalics <rudalics@gmx.at>
245 * window.c (resize_root_window, grow_mini_window)
246 (shrink_mini_window): Rename Qresize_root_window to
247 Qwindow_resize_root_window and Qresize_root_window_vertically to
248 Qwindow_resize_root_window_vertically.
250 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
252 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
254 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
256 * makefile.w32-in: Redesign dependencies so they reflect more
257 clearly which files are directly included by each source file,
258 and not through other includes.
260 2011-06-27 Martin Rudalics <rudalics@gmx.at>
262 * buffer.c (Qclone_number): Declare static and DEFSYM it.
263 (sort_overlays, overlay_strings): When an overlay's clone number
264 matches the window's clone number process the overlay even if
265 the overlay's window property doesn't match the current window.
267 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
268 (Fwindow_hchild): Rename to Fwindow_left_child.
269 (Fwindow_next): Rename to Fwindow_next_sibling.
270 (Fwindow_prev): Rename to Fwindow_prev_sibling.
271 (resize_window_check): Rename to window_resize_check.
272 (resize_window_apply): Rename to window_resize_apply.
273 (Fresize_window_apply): Rename to Fwindow_resize_apply.
274 (Fdelete_other_windows_internal, resize_frame_windows)
275 (Fsplit_window_internal, Fdelete_window_internal)
276 (grow_mini_window, shrink_mini_window)
277 (Fresize_mini_window_internal): Fix callers accordingly.
279 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
281 * emacsgtkfixed.h: State that this is only used with Gtk+3.
282 (emacs_fixed_set_min_size): Remove.
283 (emacs_fixed_new): Take frame as argument.
285 * emacsgtkfixed.c: State that this is only used with Gtk+3.
286 (_EmacsFixedPrivate): Remove minwidth/height.
288 (emacs_fixed_init): Initialize priv->f.
289 (get_parent_class, emacs_fixed_set_min_size): Remove.
290 (emacs_fixed_new): Set priv->f to argument.
291 (emacs_fixed_get_preferred_width)
292 (emacs_fixed_get_preferred_height): Use min_width/height from
293 frames size_hint to set minimum and natural (Bug#8919).
294 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
295 and use min_width/height from frames size_hint to set
296 min_width/height (Bug#8919).
298 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
299 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
302 2011-06-26 Eli Zaretskii <eliz@gnu.org>
304 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
305 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
308 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
310 * process.c (wait_reading_process_output): Bypass select if
311 waiting for a cell while ignoring keyboard input, and input is
312 pending. Suggested by Jan Djärv (Bug#8869).
314 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
316 Use gnulib's dup2 module instead of rolling our own.
317 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
319 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
321 * dispnew.c (scrolling_window): Before scrolling, turn off a
322 mouse-highlight in the window being scrolled.
324 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
326 Move DEFSYM to lisp.h and use everywhere.
328 * character.h (DEFSYM): Move declaration...
329 * lisp.h (DEFSYM): ...here.
335 * w32select.c: Don't include character.h.
337 * alloc.c (syms_of_alloc):
338 * buffer.c (syms_of_buffer):
339 * bytecode.c (syms_of_bytecode):
340 * callint.c (syms_of_callint):
341 * casefiddle.c (syms_of_casefiddle):
342 * casetab.c (init_casetab_once):
343 * category.c (init_category_once, syms_of_category):
344 * ccl.c (syms_of_ccl):
345 * cmds.c (syms_of_cmds):
346 * composite.c (syms_of_composite):
347 * dbusbind.c (syms_of_dbusbind):
348 * dired.c (syms_of_dired):
349 * dispnew.c (syms_of_display):
350 * doc.c (syms_of_doc):
351 * editfns.c (syms_of_editfns):
352 * emacs.c (syms_of_emacs):
353 * eval.c (syms_of_eval):
354 * fileio.c (syms_of_fileio):
355 * fns.c (syms_of_fns):
356 * frame.c (syms_of_frame):
357 * fringe.c (syms_of_fringe):
358 * insdel.c (syms_of_insdel):
359 * keymap.c (syms_of_keymap):
360 * lread.c (init_obarray, syms_of_lread):
361 * macros.c (syms_of_macros):
362 * msdos.c (syms_of_msdos):
363 * print.c (syms_of_print):
364 * process.c (syms_of_process):
365 * search.c (syms_of_search):
366 * sound.c (syms_of_sound):
367 * syntax.c (init_syntax_once, syms_of_syntax):
368 * terminal.c (syms_of_terminal):
369 * textprop.c (syms_of_textprop):
370 * undo.c (syms_of_undo):
371 * w32.c (globals_of_w32):
372 * window.c (syms_of_window):
373 * xdisp.c (syms_of_xdisp):
374 * xfaces.c (syms_of_xfaces):
375 * xfns.c (syms_of_xfns):
376 * xmenu.c (syms_of_xmenu):
377 * xsettings.c (syms_of_xsettings):
378 * xterm.c (syms_of_xterm): Use DEFSYM.
380 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
382 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
384 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
386 Integer and buffer overflow fixes (Bug#8873).
388 * print.c (printchar, strout): Check for string overflow.
389 (PRINTPREPARE, printchar, strout):
390 Don't set size unless allocation succeeds.
392 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
393 for sizes. Check for string overflow more accurately.
394 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
396 * macros.c: Integer and buffer overflow fixes.
397 * keyboard.h (struct keyboard.kbd_macro_bufsize):
398 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
399 Use ptrdiff_t, not int, for sizes.
400 Don't increment bufsize until after realloc succeeds.
401 Check for size-calculation overflow.
402 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
404 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
406 * lread.c: Integer overflow fixes.
407 (read_integer): Radix is now EMACS_INT, not int,
408 to improve quality of diagnostics for out-of-range radices.
409 Calculate buffer size correctly for out-of-range radices.
410 (read1): Check for integer overflow in radices, and in
412 (read_escape): Avoid int overflow.
413 (Fload, openp, read_buffer_size, read1)
414 (substitute_object_recurse, read_vector, read_list, map_obarray):
415 Use ptrdiff_t, not int, for sizes.
416 (read1): Use EMACS_INT, not int, for sizes.
417 Check for size overflow.
419 * image.c (cache_image): Check for size arithmetic overflow.
421 * lread.c: Integer overflow issues.
422 (saved_doc_string_size, saved_doc_string_length)
423 (prev_saved_doc_string_size, prev_saved_doc_string_length):
424 Now ptrdiff_t, not int.
425 (read1): Don't assume doc string length fits in int. Check for
426 out-of-range doc string lengths.
427 (read_list): Don't assume file position fits in int.
428 (read_escape): Check for hex character overflow.
430 2011-06-22 Leo Liu <sdl.web@gmail.com>
432 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
433 Move to minibuffer.el.
435 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
437 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
438 The following patches are for when GLYPH_DEBUG && !XASSERT.
439 * dispextern.h (trace_redisplay_p, dump_glyph_string):
440 * dispnew.c (flush_stdout):
441 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
442 Mark as externally visible.
443 * dispnew.c (check_window_matrix_pointers): Now static.
444 * dispnew.c (window_to_frame_vpos):
445 * xfns.c (unwind_create_frame):
446 * xterm.c (x_check_font): Remove unused local.
447 * scroll.c (CHECK_BOUNDS):
448 * xfaces.c (cache_fache): Rename local to avoid shadowing.
449 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
450 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
451 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
452 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
454 (debug_method_add): Use va_list and vsprintf rather than relying
455 on undefined behavior with wrong number of arguments.
456 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
457 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
458 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
459 since we're not interested in debugging glyphs with old libraries.
460 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
461 GCC 4.6.0's static checking.
463 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
465 Integer overflow and signedness fixes (Bug#8873).
466 A few related buffer overrun fixes, too.
468 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
470 * dispextern.h (struct face.stipple):
471 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
472 (x_bitmap_mask, x_allocate_bitmap_record)
473 (x_create_bitmap_from_data, x_create_bitmap_from_file)
474 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
475 (x_create_bitmap_from_xpm_data):
476 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
477 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
479 * xfaces.c (load_pixmap):
480 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
481 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
482 (.bitmaps_last, struct x_output.icon_bitmap):
483 Use ptrdiff_t, not int, for bitmap indexes.
484 (x_allocate_bitmap_record): Check for size overflow.
485 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
487 Use ptrdiff_t, not int, for overlay counts.
488 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
489 * editfns.c (overlays_around, get_pos_property):
490 * textprop.c (get_char_property_and_overlay):
491 * xdisp.c (next_overlay_change, note_mouse_highlight):
492 * xfaces.c (face_at_buffer_position):
493 * buffer.c (OVERLAY_COUNT_MAX): New macro.
494 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
495 (Fnext_overlay_change, Fprevious_overlay_change)
496 (mouse_face_overlay_overlaps, Foverlays_in):
497 Use ptrdiff_t, not int, for sizes.
498 (overlays_at, overlays_in): Check for size-calculation overflow.
500 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
502 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
503 (x_session_initialize): Do not assume string length fits in int.
505 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
506 This is unlikely, but can occur if DPI is outlandish.
508 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
509 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
511 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
512 * xrdb.c (magic_file_p, search_magic_path):
513 Omit last arg SUFFIX; it was always 0. All callers changed.
514 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
516 * xfont.c (xfont_match): Avoid need for strlen.
518 * xfns.c: Don't assume strlen fits in int.
519 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
521 * xdisp.c (message_log_check_duplicate): Return intmax_t,
522 not unsigned long, as we prefer signed integers. All callers changed.
523 Detect integer overflow in repeat count.
524 (message_dolog): Don't assume print length fits in 39 bytes.
525 (display_mode_element): Don't assume strlen fits in int.
527 * termcap.c: Don't assume sizes fit in int and never overflow.
528 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
529 (gobble_line): Check for size-calculation overflow.
531 * minibuf.c (Fread_buffer):
532 * lread.c (intern, intern_c_string):
533 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
534 Don't assume string length fits in int.
536 * keyboard.c (parse_tool_bar_item):
537 * gtkutil.c (style_changed_cb): Avoid need for strlen.
539 * font.c: Don't assume string length fits in int.
540 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
541 Use ptrdiff_t, not int.
542 (font_intern_prop): Don't assume string length fits in int.
543 Don't assume integer property fits in fixnum.
544 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
546 * filelock.c: Fix some buffer overrun and integer overflow issues.
547 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
548 Reformulate so as not to need the command string.
549 Invoke gzip -cd rather than gunzip, as it's more portable.
550 (lock_info_type, lock_file_1, lock_file):
551 Don't assume pid_t and time_t fit in unsigned long.
552 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
553 (current_lock_owner): Prefer signed type for sizes.
554 Use memcpy, not strncpy, where memcpy is what is really wanted.
555 Don't assume (via atoi) that time_t and pid_t fit in int.
556 Check for time_t and/or pid_t out of range, e.g., via a network share.
557 Don't alloca where an auto var works fine.
559 * fileio.c: Fix some integer overflow issues.
560 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
561 Don't assume string length fits in int.
562 (directory_file_name): Don't assume string length fits in long.
563 (make_temp_name): Don't assume pid fits in int, or that its print
564 length is less than 20.
566 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
568 * coding.c (make_subsidiaries): Don't assume string length fits in int.
570 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
572 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
573 We prefer signed integers, even for size calculations.
575 * emacs.c: Don't assume string length fits in 'int'.
576 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
577 (main): Don't invoke strlen when not needed.
579 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
580 (XD_DEBUG_MESSAGE): Don't waste a byte.
582 * callproc.c (getenv_internal_1, getenv_internal)
584 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
586 * lread.c (invalid_syntax): Omit length argument.
587 All uses changed. This doesn't fix a bug, but it simplifies the
588 code away from its former Hollerith-constant appearance, and it's
589 one less 'int' to worry about when looking at integer-overflow issues.
590 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
592 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
593 This didn't break anything, but it didn't help either.
594 It's confusing to put a bogus integer in a place where the actual
595 value does not matter.
596 (LIST_END_P): Remove unused macro and its bogus comment.
597 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
599 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
600 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
602 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
603 We prefer signed types, and the value cannot exceed the EMACS_INT
604 range anyway (because otherwise the length would not be representable).
605 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
606 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
607 This avoids a GCC warning when WIDE_EMACS_INT.
609 * indent.c (sane_tab_width): New function.
610 (current_column, scan_for_column, Findent_to, position_indentation)
611 (compute_motion): Use it. This is just for clarity.
612 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
614 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
616 * lisp.h (lint_assume): New macro.
617 * composite.c (composition_gstring_put_cache):
618 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
620 * editfns.c, insdel.c:
621 Omit unnecessary forward decls, to simplify future changes.
623 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
625 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
627 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
628 Use much-faster test for byte-length change.
629 Don't assume string byte-length fits in 'int'.
630 Check that character arg fits in 'int'.
631 (mapcar1): Declare byte as byte, for clarity.
633 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
635 * fns.c (concat): Catch string overflow earlier.
636 Do not rely on integer wraparound.
638 * dispextern.h (struct it.overlay_strings_charpos)
639 (struct it.selective): Now EMACS_INT, not int.
640 * xdisp.c (forward_to_next_line_start)
641 (back_to_previous_visible_line_start)
642 (reseat_at_next_visible_line_start, next_element_from_buffer):
643 Don't arbitrarily truncate the value of 'selective' to int.
645 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
647 * composite.c: Don't truncate sizes to 'int'.
648 (composition_gstring_p, composition_reseat_it)
649 (composition_adjust_point): Use EMACS_INT, not int.
650 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
651 not EMACS_UINT, for indexes.
653 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
655 * buffer.c: Include <verify.h>.
656 (struct sortvec.priority, struct sortstr.priority):
657 Now EMACS_INT, not int.
658 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
659 (struct sortstr.size, record_overlay_string)
660 (struct sortstrlist.size, struct sortlist.used):
661 Don't truncate size to int.
662 (record_overlay_string): Check for size-calculation overflow.
663 (init_buffer_once): Check at compile-time, not run-time.
665 2011-06-22 Jim Meyering <meyering@redhat.com>
667 Don't leak an XBM-image-sized buffer
668 * image.c (xbm_load): Free the image buffer after using it.
670 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
673 * composite.c (find_automatic_composition): Omit needless 'return 0;'
674 that Sun C diagnosed.
675 * fns.c (secure_hash): Fix pointer signedness issue.
676 * intervals.c (static_offset_intervals): New function.
677 (offset_intervals): Use it.
679 2011-06-21 Leo Liu <sdl.web@gmail.com>
682 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
685 * fns.c (secure_hash): Rename from crypto_hash_function and change
686 the first arg to accept symbols.
687 (Fsecure_hash): New primitive.
688 (syms_of_fns): New symbols.
690 2011-06-20 Deniz Dogan <deniz@dogan.se>
692 * process.c (Fset_process_buffer): Clarify return value in
695 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
697 * dispnew.c (add_window_display_history): Use BVAR.
699 * xdisp.c (debug_method_add): Use BVAR.
700 (check_window_end, dump_glyph_matrix, dump_glyph)
701 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
703 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
706 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
707 check till after the cache is created in init_frame_faces.
709 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
711 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
713 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
715 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
716 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
717 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
719 Improve buffer-overflow checking (Bug#8873).
720 * fileio.c (Finsert_file_contents):
721 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
722 Remove the old (too-loose) buffer overflow checks.
723 They weren't needed, since make_gap checks for buffer overflow.
724 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
725 The old code merely checked for Emacs fixnum overflow, and relied
726 on undefined (wraparound) behavior. The new code avoids undefined
727 behavior, and also checks for ptrdiff_t and/or size_t overflow.
729 * editfns.c (Finsert_char): Don't dump core with very negative counts.
730 Tune. Don't use wider integers than needed. Don't use alloca.
731 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
733 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
735 * insdel.c, lisp.h (buffer_overflow): New function.
736 (insert_from_buffer_1, replace_range, replace_range_2):
737 * insdel.c (make_gap_larger):
738 * editfns.c (Finsert_char):
739 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
741 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
743 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
745 Integer overflow and signedness fixes (Bug#8873).
747 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
748 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
750 * fileio.c: Don't assume EMACS_INT fits in off_t.
751 (emacs_lseek): New static function.
752 (Finsert_file_contents, Fwrite_region): Use it.
753 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
755 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
757 * fns.c: Don't overflow int when computing a list length.
758 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
759 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
760 truncation on 64-bit hosts. Check for QUIT every
761 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
762 faster and is responsive enough.
763 (Flength): Report an error instead of overflowing an integer.
764 (Fsafe_length): Return a float if the value is not representable
765 as a fixnum. This shouldn't happen except in contrived situations.
766 (Fnthcdr, Fsort): Don't assume list length fits in int.
767 (Fcopy_sequence): Don't assume vector length fits in int.
769 * alloc.c: Check that resized vectors' lengths fit in fixnums.
770 (header_size, word_size): New constants.
771 (allocate_vectorlike): Don't check size overflow here.
772 (allocate_vector): Check it here instead, since this is the only
773 caller of allocate_vectorlike that could cause overflow.
774 Check that the new vector's length is representable as a fixnum.
776 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
777 The previous code was bogus. For example, next_almost_prime (32)
778 returned 39, which is undesirable as it is a multiple of 3; and
779 next_almost_prime (24) returned 25, which is a multiple of 5 so
780 why was the code bothering to check for multiples of 7?
782 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
784 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
786 Variadic C functions now count arguments with ptrdiff_t.
787 This partly undoes my 2011-03-30 change, which replaced int with size_t.
788 Back then I didn't know that the Emacs coding style prefers signed int.
789 Also, in the meantime I found a few more instances where arguments
790 were being counted with int, which may truncate counts on 64-bit
791 machines, or EMACS_INT, which may be unnecessarily wide.
792 * lisp.h (struct Lisp_Subr.function.aMANY)
793 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
794 Arg counts are now ptrdiff_t, not size_t.
795 All variadic functions and their callers changed accordingly.
796 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
797 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
798 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
799 * callint.c (Fcall_interactively): Check arg count for overflow,
800 to avoid potential buffer overrun. Use signed char, not 'int',
801 for 'varies' array, so that we needn't bother to check its size
802 calculation for overflow.
803 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
804 * eval.c (apply_lambda):
805 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
806 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
807 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
809 * callint.c (Fcall_interactively): Don't use index var as event count.
811 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
812 * mem-limits.h (SIZE): Remove; no longer used.
814 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
816 Remove unnecessary casts.
817 * xterm.c (x_term_init):
818 * xfns.c (x_set_border_pixel):
819 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
820 These aren't needed now that we assume ANSI C.
822 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
823 It's more likely to cause problems (due to unsigned overflow)
826 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
828 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
830 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
832 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
834 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
836 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
838 GLYPH_CODE_FACE returns EMACS_INT, not int.
839 * dispextern.h (merge_faces):
840 * xfaces.c (merge_faces):
841 * xdisp.c (get_next_display_element, next_element_from_display_vector):
842 Don't assume EMACS_INT fits in int.
844 * character.h (CHAR_VALID_P): Remove unused parameter.
845 * fontset.c, lisp.h, xdisp.c: All uses changed.
847 * editfns.c (Ftranslate_region_internal): Omit redundant test.
849 * fns.c (concat): Minor tuning based on overflow analysis.
850 This doesn't fix any bugs. Use int to hold character, instead
851 of constantly refetching from Emacs object. Use XFASTINT, not
852 XINT, for value known to be a character. Don't bother comparing
853 a single byte to 0400, as it's always less.
855 * floatfns.c (Fexpt):
856 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
858 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
861 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
863 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
864 Without this fix, on a 64-bit host (aset S 0 4294967386) would
865 incorrectly succeed when S was a string, because 4294967386 was
866 truncated before it was used.
868 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
869 Otherwise, an out-of-range integer could cause undefined behavior
872 * composite.c: Use int, not EMACS_INT, for characters.
873 (fill_gstring_body, composition_compute_stop_pos): Use int, not
874 EMACS_INT, for values that are known to be in character range.
875 This doesn't fix any bugs but is the usual style inside Emacs and
876 may generate better code on 32-bit machines.
878 Make sure a 64-bit char is never passed to ENCODE_CHAR.
879 This is for reasons similar to the recent CHAR_STRING fix.
880 * charset.c (Fencode_char): Check that character arg is actually
881 a character. Pass an int to ENCODE_CHAR.
882 * charset.h (ENCODE_CHAR): Verify that the character argument is no
883 wider than 'int', as a compile-time check to prevent future regressions
886 * character.c (char_string): Remove unnecessary casts.
888 Make sure a 64-bit char is never passed to CHAR_STRING.
889 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
890 by silently ignoring the top 32 bits, allowing some values
891 that were far too large to be valid characters.
892 * character.h: Include <verify.h>.
893 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
894 arguments are no wider than unsigned, as a compile-time check
895 to prevent future regressions in this area.
897 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
898 (Fsubst_char_in_region):
900 * xdisp.c (decode_mode_spec_coding):
901 Adjust to CHAR_STRING's new requirement.
902 * editfns.c (Finsert_char, Fsubst_char_in_region):
903 * fns.c (concat): Check that character args are actually
904 characters. Without this test, these functions did the wrong
905 thing with wildly out-of-range values on 64-bit hosts.
907 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
908 These casts should not be needed on 32-bit hosts, either.
909 * keyboard.c (read_char):
910 * lread.c (Fload): Remove casts to unsigned.
912 * lisp.h (UNSIGNED_CMP): New macro.
913 This fixes comparison bugs on 64-bit hosts.
914 (ASCII_CHAR_P): Use it.
915 * casefiddle.c (casify_object):
916 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
917 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
918 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
919 * dispextern.h (FACE_FROM_ID):
920 * keyboard.c (read_char): Use UNSIGNED_CMP.
922 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
923 not to EMACS_INT, to avoid GCC warning.
925 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
927 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
928 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
929 isn't needed on 32-bit machines.
931 * buffer.c (Fgenerate_new_buffer_name):
932 Use EMACS_INT for count, not int.
933 (advance_to_char_boundary): Return EMACS_INT, not int.
935 * data.c (Qcompiled_function): Now static.
937 * window.c (window_body_lines): Now static.
939 * image.c (gif_load): Rename local to avoid shadowing.
941 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
942 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
943 * alloc.c (make_save_value): Integer argument is now of type
945 (mark_object): Use ptrdiff_t, not int.
946 * lisp.h (pD): New macro.
947 * print.c (print_object): Use it.
949 * alloc.c: Use EMACS_INT, not int, to count objects.
950 (total_conses, total_markers, total_symbols, total_vector_size)
951 (total_free_conses, total_free_markers, total_free_symbols)
952 (total_free_floats, total_floats, total_free_intervals)
953 (total_intervals, total_strings, total_free_strings):
954 Now EMACS_INT, not int. All uses changed.
955 (Fgarbage_collect): Compute overall total using a double, so that
956 integer overflow is less likely to be a problem. Check for overflow
957 when converting back to an integer.
958 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
959 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
960 These were 'int' variables that could overflow on 64-bit hosts;
961 they were never used, so remove them instead of repairing them.
962 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
963 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
964 Previously, this ceilinged at INT_MAX, but that doesn't work on
966 (allocate_pseudovector): Don't use EMACS_INT when int would do.
968 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
969 (allocate_vectorlike): Check for ptrdiff_t overflow.
970 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
971 when a (possibly-narrower) signed value would do just as well.
972 We prefer using signed arithmetic, to avoid comparison confusion.
974 * alloc.c: Catch some string size overflows that we were missing.
975 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
976 for convenience in STRING_BYTES_MAX.
977 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
978 The definition here is exact; the one in lisp.h was approximate.
979 (allocate_string_data): Check for string overflow. This catches
980 some instances we weren't catching before. Also, it catches
981 size_t overflow on (unusual) hosts where SIZE_MAX <= min
982 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
983 and ptrdiff_t and EMACS_INT are both 64 bits.
985 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
986 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
987 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
989 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
991 * alloc.c (Fmake_string): Check for out-of-range init.
993 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
995 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
997 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
999 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1000 xg_get_default_scrollbar_width.
1002 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1003 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1004 (style_changed_cb): Call update_theme_scrollbar_width and call
1005 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1006 all frames (Bug#8505).
1007 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1008 Call gtk_window_set_resizable if HAVE_GTK3.
1009 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1010 and height if HAVE_GTK3 (Bug#8505).
1011 (scroll_bar_width_for_theme): New variable.
1012 (update_theme_scrollbar_width): New function.
1013 (xg_get_default_scrollbar_width): Move code to
1014 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1015 (xg_initialize): Call update_theme_scrollbar_width.
1017 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1019 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1021 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1023 * frame.c (make_frame): Call other_buffer_safely instead of
1026 * window.c (temp_output_buffer_show): Call display_buffer with
1027 second argument Vtemp_buffer_show_specifiers and reset latter
1028 immediately after the call.
1029 (Vtemp_buffer_show_specifiers): New variable.
1030 (auto_window_vscroll_p, next_screen_context_lines)
1031 (Vscroll_preserve_screen_position): Remove leading asterisks from
1034 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1036 Fix minor problems found by GCC 4.6.0 static checking.
1037 * buffer.c (Qclone_number): Remove for now, as it's unused.
1038 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1039 (record_buffer): Remove unused local.
1040 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1041 (set_frame_buffer_list): Remove; unused.
1042 * frame.h (other_visible_frames): Remove decl.
1043 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1044 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1045 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1047 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1048 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1049 Define only if HAVE_GPM.
1050 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1051 (update_hints_inhibit): Remove; never set. All uses removed.
1052 * widgetprv.h (emacsFrameClassRec): Remove decl.
1053 * window.c (delete_deletable_window): Now returns void, since it
1054 wasn't returning anything.
1055 (compare_window_configurations): Remove unused locals.
1056 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1057 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1058 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1059 the same widths as pointers. This follows up on the 2011-05-06 patch.
1060 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1061 * xterm.h: Likewise.
1062 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1064 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1066 * makefile.w32-in: Update dependencies.
1067 (LISP_H): Add lib/intprops.h.
1069 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1071 * image.c (gif_load): Add animation frame delay to the metadata.
1072 (syms_of_image): Use DEFSYM. New symbol `delay'.
1074 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1076 * window.c (delete_deletable_window): Re-add.
1077 (Fset_window_configuration): Rewrite to handle dead buffers and
1078 consequently deletable windows.
1079 (window_tree, Fwindow_tree): Remove. Supply functionality in
1081 (compare_window_configurations): Simplify code.
1083 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1085 * image.c (imagemagick_load_image): Fix type mismatch.
1086 (Fimagemagick_types): Likewise.
1088 * window.h (replace_buffer_in_windows): Declare.
1090 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1092 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1093 Qclone_number. Remove external declaration of Qdelete_window.
1094 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1096 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1097 Qbuffer_list_update_hook if allowed.
1098 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1099 buffer list implementation.
1100 (other_buffer_safely): New function.
1101 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1102 calls to replace_buffer_in_windows and
1103 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1105 (record_buffer): Inhibit quitting and rewrite using quittable
1106 functions. Run Qbuffer_list_update_hook if allowed.
1107 (Frecord_buffer, Funrecord_buffer): New functions.
1108 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1109 switch-to-buffer to window.el.
1110 (bury-buffer): Move to window.el.
1111 (Vbuffer_list_update_hook): New variable.
1113 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1116 * window.h (resize_frame_windows): Move up in code.
1117 (Fwindow_frame): Remove EXFUN.
1118 (replace_buffer_in_all_windows): Remove prototype.
1119 (replace_buffer_in_windows_safely): Add prototype.
1121 * window.c: Declare Qdelete_window static again. Move down
1122 declaration of select_count.
1123 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1124 (Fother_window): Move to window.el.
1125 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1126 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1127 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1129 (replace_buffer_in_windows): Implement by calling
1130 Qreplace_buffer_in_windows.
1131 (replace_buffer_in_all_windows): Remove with some functionality
1132 moved into replace_buffer_in_windows_safely.
1133 (replace_buffer_in_windows_safely): New function.
1134 (select_window_norecord, select_frame_norecord): Move in front
1135 of run_window_configuration_change_hook. Remove now obsolete
1137 (Fset_window_buffer): Rewrite doc-string. Call
1138 Qrecord_window_buffer.
1139 (keys_of_window): Move binding for other-window to window.el.
1141 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1143 * dispextern.h (struct image): Replace data member, whose int_val
1144 and ptr_val fields were not used by anything, with a single
1147 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1148 (gif_clear_image, gif_load, imagemagick_load_image)
1149 (gs_clear_image, gs_load): Callers changed.
1151 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1153 * buffer.h: Include <time.h>, for time_t.
1154 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1156 Fix minor problems found by static checking.
1158 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1160 Make identifiers static if they are not used in other modules.
1161 * data.c (Qcompiled_function, Qframe, Qvector):
1162 * image.c (QimageMagick, Qsvg):
1163 * minibuf.c (Qmetadata):
1164 * window.c (resize_window_check, resize_root_window): Now static.
1165 * window.h (resize_window_check, resize_root_window): Remove decls.
1167 * window.c (window_deletion_count, delete_deletable_window):
1169 (window_body_lines): Now static.
1170 (Fdelete_other_windows_internal): Mark vars as initialized.
1171 Make sure 'resize_failed' is initialized.
1172 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1173 (resize_window_apply): Remove unused local.
1174 * window.h (delete_deletable_window): Remove decl.
1176 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1177 (imagemagick_load_image): Fix pointer signedness problem by changing
1178 last arg from unsigned char * to char *. All uses changed.
1179 Also, fix a local for similar reasons.
1180 Remove unused locals. Remove locals to avoid shadowing.
1181 (fn_rsvg_handle_free): Remove; unused.
1182 (svg_load, svg_load_image): Fix pointer signedness problem.
1183 (imagemagick_load_image): Don't use garbage pointer image_wand.
1185 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1187 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1189 * image.c (gif_load): Fix omitted cast error introduced by
1192 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1194 * window.h (resize_proportionally, orig_total_lines)
1195 (orig_top_line): Remove from window structure.
1196 (set_window_height, set_window_width, change_window_heights)
1197 (Fdelete_window): Remove prototypes.
1198 (resize_frame_windows): Remove duplicate declaration.
1200 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1202 * window.h (resize_frame_windows, resize_window_check)
1203 (delete_deletable_window, resize_root_window)
1204 (resize_frame_windows): Declare prototypes.
1206 * window.c (resize_window_apply): Make definition be "static" to
1207 match the prototype.
1209 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1211 * window.c: Remove declarations of Qwindow_size_fixed,
1212 window_min_size_1, window_min_size_2, window_min_size,
1213 size_window, window_fixed_size_p, enlarge_window, delete_window.
1214 Remove static from declaration of Qdelete_window, it's
1215 temporarily needed by Fbury_buffer.
1216 (replace_window): Don't assign orig_top_line and
1218 (Fdelete_window, delete_window): Remove. Window deletion is
1219 handled by window.el.
1220 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1221 Fdelete_window calls with calls to Qdelete_window.
1222 (Fdelete_other_windows): Remove. Deleting other windows is
1223 handled by window.el.
1224 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1225 handled in window.el.
1226 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1227 Window minimum sizes are handled in window.el.
1228 (shrink_windows, size_window, set_window_height)
1229 (set_window_width, change_window_heights, window_height)
1230 (window_width, CURBEG, CURSIZE, enlarge_window)
1231 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1232 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1233 handled in window.el.
1234 (make_dummy_parent): Rename to make_parent_window and give it a
1235 second argument horflag.
1236 (make_window): Don't set resize_proportionally any more.
1237 (Fsplit_window): Remove. Windows are split in window.el.
1238 (save_restore_action, save_restore_orig_size)
1239 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1240 Resize mini windows in window.el.
1241 (grow_mini_window, shrink_mini_window): Implement by calling
1242 Qresize_root_window_vertically, resize_window_check and
1243 resize_window_apply.
1244 (saved_window, Fset_window_configuration, save_window_save): Do
1245 not handle orig_top_line, orig_total_lines, and
1246 resize_proportionally.
1247 (window_min_height, window_min_width): Move to window.el.
1248 (keys_of_window): Move bindings for delete-other-windows,
1249 split-window, delete-window and enlarge-window to window.el.
1251 * buffer.c: Temporarily extern Qdelete_window.
1252 (Fbury_buffer): Temporarily call Qdelete_window instead of
1253 Fdelete_window (Fbury_buffer will move to window.el soon).
1255 * frame.c (set_menu_bar_lines_1): Remove code handling
1256 orig_top_line and orig_total_lines.
1258 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1259 set_window_height but set heights directly.
1260 (change_frame_size_1): Use resize_frame_windows.
1262 * xdisp.c (init_xdisp): Don't use set_window_height but set
1265 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1266 resize_frame_windows instead of change_window_heights and run
1267 run_window_configuration_change_hook.
1269 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1270 instead of change_window_heights and run
1271 run_window_configuration_change_hook.
1273 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1275 * window.c (replace_window): Rename second argument REPLACEMENT to
1276 NEW. New third argument SETFLAG. Rewrite.
1277 (delete_window, make_dummy_parent): Call replace_window with
1279 (window_list_1): Move down in code.
1280 (run_window_configuration_change_hook): Move set_buffer part
1281 before select_frame_norecord part in order to unwind correctly.
1282 Rename count1 to count.
1283 (recombine_windows, delete_deletable_window, resize_root_window)
1284 (Fdelete_other_windows_internal)
1285 (Frun_window_configuration_change_hook, make_parent_window)
1286 (resize_window_check, resize_window_apply, Fresize_window_apply)
1287 (resize_frame_windows, Fsplit_window_internal)
1288 (Fdelete_window_internal, Fresize_mini_window_internal): New
1290 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1292 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1294 * window.h (window): Add some new members to window structure -
1295 normal_lines, normal_cols, new_total, new_normal, clone_number,
1296 splits, nest, prev_buffers, next_buffers.
1297 (WINDOW_TOTAL_SIZE): Move here from window.c.
1298 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1300 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1302 (make_dummy_parent): Set new members of windows structure.
1303 (make_window): Move down in code. Handle new members of window
1305 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1306 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1307 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1308 (Fset_window_prev_buffers, Fwindow_next_buffers)
1309 (Fset_window_next_buffers, Fset_window_clone_number): New
1311 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1312 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1314 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1315 Argument WINDOW can be now internal window too.
1316 (Fwindow_use_time): Move up in code.
1317 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1319 (Fset_window_configuration, saved_window)
1320 (Fcurrent_window_configuration, save_window_save): Handle new
1321 members of window structure.
1322 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1323 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1324 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1325 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1326 Qget_mru_window, Qresize_root_window,
1327 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1328 Qauto_buffer_name; staticpro them.
1330 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1332 * window.c (Fwindow_total_size, Fwindow_left_column)
1333 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1334 (Fwindow_list_1): New functions.
1335 (window_box_text_cols): Replace with window_body_cols.
1336 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1337 window_body_cols instead of window_box_text_cols.
1338 (delete_window, Fset_window_configuration): Call
1339 delete_all_subwindows with window as argument.
1340 (delete_all_subwindows): Take a window as argument and not a
1342 (window_loop): Remove handling of GET_LRU_WINDOW and
1344 (Fget_lru_window, Fget_largest_window): Move to window.el.
1346 * window.h: Extern window_body_cols instead of
1347 window_box_text_cols. delete_all_subwindows now takes a
1348 Lisp_Object as argument.
1350 * indent.c (compute_motion, Fcompute_motion): Use
1351 window_body_cols instead of window_box_text_cols.
1353 * frame.c (delete_frame): Call delete_all_subwindows with root
1356 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1358 * fns.c (Fputhash): Document return value.
1360 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1362 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1364 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1366 Cons<->int and similar integer overflow fixes (Bug#8794).
1368 Check for overflow when converting integer to cons and back.
1369 * charset.c (Fdefine_charset_internal, Fdecode_char):
1370 Use cons_to_unsigned to catch overflow.
1371 (Fencode_char): Use INTEGER_TO_CONS.
1372 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1373 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1374 * data.c (long_to_cons, cons_to_long): Remove.
1375 (cons_to_unsigned, cons_to_signed): New functions.
1376 These signal an error for invalid or out-of-range values.
1377 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1378 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1379 * font.c (Ffont_variation_glyphs):
1380 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1381 * lisp.h: Include <intprops.h>.
1382 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1383 (cons_to_signed, cons_to_unsigned): New decls.
1384 (long_to_cons, cons_to_long): Remove decls.
1385 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1386 (Fprimitive_undo): Use CONS_TO_INTEGER.
1387 * xfns.c (Fx_window_property): Likewise.
1388 * xselect.c: Include <limits.h>.
1389 (x_own_selection, selection_data_to_lisp_data):
1390 Use INTEGER_TO_CONS.
1391 (x_handle_selection_request, x_handle_selection_clear)
1392 (x_get_foreign_selection, Fx_disown_selection_internal)
1393 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1394 (lisp_data_to_selection_data): Use cons_to_unsigned.
1395 (x_fill_property_data): Use cons_to_signed.
1396 Report values out of range.
1398 Check for buffer and string overflow more precisely.
1399 * buffer.h (BUF_BYTES_MAX): New macro.
1400 * lisp.h (STRING_BYTES_MAX): New macro.
1401 * alloc.c (Fmake_string):
1402 * character.c (string_escape_byte8):
1403 * coding.c (coding_alloc_by_realloc):
1404 * doprnt.c (doprnt):
1405 * editfns.c (Fformat):
1407 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1408 since they may not be the same number.
1409 * editfns.c (Finsert_char):
1410 * fileio.c (Finsert_file_contents):
1411 Likewise for BUF_BYTES_MAX.
1413 * image.c: Use ptrdiff_t, not int, for sizes.
1414 (slurp_file): Switch from int to ptrdiff_t.
1416 (slurp_file): Check that file size fits in both size_t (for
1417 malloc) and ptrdiff_t (for sanity and safety).
1419 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1420 if b->modtime has its maximal value.
1422 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1424 Don't assume time_t can fit into int.
1425 * buffer.h (struct buffer.modtime): Now time_t, not int.
1426 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1427 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1429 Minor fixes for signed vs unsigned integers.
1430 * character.h (MAYBE_UNIFY_CHAR):
1431 * charset.c (maybe_unify_char):
1432 * keyboard.c (read_char, reorder_modifiers):
1433 XINT -> XFASTINT, since the integer must be nonnegative.
1434 * ftfont.c (ftfont_spec_pattern):
1435 * keymap.c (access_keymap, silly_event_symbol_error):
1436 XUINT -> XFASTINT, since the integer must be nonnegative.
1437 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1438 since it makes no difference and we prefer signed.
1439 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1440 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1443 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1445 * window.h (Fwindow_frame): Declare.
1447 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1449 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1450 (SPARE_MEMORY): Always define.
1451 (LARGE_REQUEST): Remove.
1452 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1454 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1456 * lisp.h: Move EXFUNS for Fframe_root_window,
1457 Fframe_first_window and Fset_frame_selected_window to window.h.
1459 * window.h: Move EXFUNS for Fframe_root_window,
1460 Fframe_first_window and Fset_frame_selected_window here from
1463 * frame.c (Fwindow_frame, Fframe_first_window)
1464 (Fframe_root_window, Fframe_selected_window)
1465 (Fset_frame_selected_window): Move to window.c.
1466 (Factive_minibuffer_window): Move to minibuf.c.
1467 (Fother_visible_frames_p): New function.
1469 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1471 * window.c (decode_window, decode_any_window): Move up in code.
1472 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1473 (inhibit_frame_unsplittable): Remove unused variable.
1474 (Fwindow_buffer): Move up and rewrite doc-string.
1475 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1476 (Fwindow_prev): New functions.
1477 (Fwindow_frame): Move here from frame.c. Accept any window as
1479 (Fframe_root_window, Fframe_first_window)
1480 (Fframe_selected_window): Move here from frame.c. Accept frame
1481 or arbitrary window as argument. Update doc-strings.
1482 (Fminibuffer_window): Move up in code.
1483 (Fwindow_minibuffer_p): Move up in code and simplify.
1484 (Fset_frame_selected_window): Move here from frame.c.
1486 (Fselected_window, select_window, Fselect_window): Move up in
1487 code. Minor doc-string fixes.
1489 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1491 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1492 Do not assume that spare memory exists; that assumption is valid
1493 only if SYSTEM_MALLOC.
1494 (LARGE_REQUEST): New macro, so that the issue of large requests
1495 is separated from the issue of spare memory.
1497 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1499 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1502 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1504 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1507 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1509 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1511 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1513 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1514 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1516 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1518 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1520 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1522 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1523 (x_clipboard_manager_save): Add return value.
1524 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1526 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1527 Obey Vx_select_enable_clipboard_manager. Catch errors in
1528 x_clipboard_manager_save (Bug#8779).
1529 (Vx_select_enable_clipboard_manager): New variable.
1530 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1532 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1534 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1536 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1538 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1539 in the current matrix if keep_current_p is non-zero.
1541 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1543 * bidi.c (bidi_level_of_next_char): Fix last change.
1545 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1547 Support bidi reordering of text covered by display properties.
1549 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1550 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1551 (bidi_cache_search, bidi_cache_iterator_state)
1552 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1553 (bidi_level_of_next_char, bidi_move_to_visually_next):
1554 Support character positions inside a run of characters covered by a
1556 (bidi_paragraph_init, bidi_resolve_explicit_1)
1557 (bidi_level_of_next_char): Call bidi_fetch_char and
1558 bidi_fetch_char_advance instead of FETCH_CHAR and
1560 (bidi_init_it): Initialize new members.
1561 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1563 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1564 instead of using explicit *_CHAR codes.
1565 (bidi_resolve_explicit, bidi_resolve_weak):
1566 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1567 bidirectional text is supported only in multibyte buffers.
1568 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1569 it to initialize the frame_window_p member of struct bidi_it.
1570 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1571 (bidi_resolve_explicit, bidi_resolve_weak)
1572 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1573 bidi_it->nchars is non-positive.
1574 (bidi_level_of_next_char): Don't try to lookup the cache for the
1575 next/previous character if nothing is cached there yet, or if we
1576 were just reseat()'ed to a new position.
1578 * xdisp.c (set_cursor_from_row): Set start and stop points
1579 according to the row's direction when priming the loop that looks
1580 for the glyph on which to display cursor.
1581 (single_display_spec_intangible_p): Function deleted.
1582 (display_prop_intangible_p): Reimplement to call
1583 handle_display_spec instead of single_display_spec_intangible_p.
1584 Accept 3 additional arguments needed by handle_display_spec.
1585 This fixes incorrect cursor motion across display property with complex
1586 values: lists, `(when COND...)' forms, etc.
1587 (single_display_spec_string_p): Support property values that are
1588 lists with the argument STRING its top-level element.
1589 (display_prop_string_p): Fix the condition for processing a
1590 property that is a list to be consistent with handle_display_spec.
1591 (handle_display_spec): New function, refactored from the
1592 last portion of handle_display_prop.
1593 (compute_display_string_pos): Accept additional argument
1594 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1595 value of a `display' property is a "replacing spec".
1596 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1597 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1598 the display property, but just return a value indicating whether
1599 the display property will replace the characters it covers.
1600 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1601 frame_window_p members of struct bidi_it.
1602 (compute_display_string_pos, compute_display_string_end):
1604 (push_it): Accept second argument POSITION, where pop_it should
1605 jump to continue iteration.
1606 (reseat_1): Initialize bidi_it.disp_pos.
1608 * keyboard.c (adjust_point_for_property): Adjust the call to
1609 display_prop_intangible_p to its new signature.
1611 * dispextern.h (struct bidi_it): New member frame_window_p.
1612 (bidi_init_it): Update prototypes.
1613 (display_prop_intangible_p): Update prototype.
1614 (compute_display_string_pos, compute_display_string_end):
1616 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1619 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1621 Malloc failure behavior now depends on size of allocation.
1622 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1623 * lisp.h: Change signatures accordingly.
1624 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1625 All callers changed. (Bug#8762)
1627 * gnutls.c: Use Emacs's memory allocators.
1628 Without this change, the gnutls library would invoke malloc etc.
1629 directly, which causes problems on non-SYNC_INPUT hosts, and which
1630 runs afoul of improving memory_full behavior. (Bug#8761)
1631 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1632 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1633 xfree instead of the default malloc, realloc, free.
1634 (Fgnutls_boot): No need to check for memory allocation failure,
1635 since xmalloc does that for us.
1637 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1638 * category.c (hash_get_category_set):
1639 * ccl.c (ccl_driver):
1640 * charset.c (Fdefine_charset_internal):
1641 * charset.h (struct charset.hash_index):
1642 * composite.c (get_composition_id, gstring_lookup_cache)
1643 (composition_gstring_put_cache):
1644 * composite.h (struct composition.hash_index):
1645 * dispextern.h (struct image.hash):
1646 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1647 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1648 (hashfn_equal, hashfn_user_defined, make_hash_table)
1649 (maybe_resize_hash_table, hash_lookup, hash_put)
1650 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1651 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1652 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1653 * image.c (make_image, search_image_cache, lookup_image)
1654 (xpm_put_color_table_h):
1655 * lisp.h (struct Lisp_Hash_Table):
1656 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1657 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1658 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1659 * alloc.c (allocate_vectorlike):
1660 Check for overflow in vector size calculations.
1661 * ccl.c (ccl_driver):
1662 Check for overflow when converting EMACS_INT to int.
1663 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1664 need to be updated by these changes.
1665 * fns.c (make_hash_table, maybe_resize_hash_table):
1666 Check for integer overflow with large hash tables.
1667 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1668 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1669 (SXHASH_REDUCE): New macro.
1670 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1671 Use it instead of discarding useful hash info with large hash values.
1672 (sxhash_float): New function.
1673 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1674 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1675 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1676 Rewrite to use FIXNUM_BITS, as this simplifies things.
1677 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1678 Adjust signatures to match updated version of code.
1679 (consing_since_gc): Now EMACS_INT, since a single hash table can
1680 use more than INT_MAX bytes.
1682 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1684 Make it possible to build with GCC-4.6+ -O2 -flto.
1686 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1688 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1690 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1691 Call minibuffer-inactive-mode.
1693 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1695 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1696 Update dependencies.
1698 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1700 * data.c (init_data): Remove code for UTS, this system is not
1703 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1705 Don't force ./temacs to start in terminal mode.
1707 * frame.c (make_initial_frame): Initialize faces in all cases, not
1708 only when CANNOT_DUMP is defined.
1709 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1711 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1713 * dispnew.c (add_window_display_history): Use const for the string
1714 pointer. Remove declaration, not needed.
1716 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1718 Use 'inline', not 'INLINE'.
1719 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1720 * alloc.c, fontset.c (INLINE): Remove.
1721 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1722 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1723 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1724 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1725 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1727 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1729 Make it possible to run ./temacs.
1731 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1732 syms_of_callproc does the same thing. Remove test for
1733 "initialized", do it in the caller.
1734 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1736 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1738 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1739 (read_minibuf): Use get_minibuffer.
1740 (syms_of_minibuf): Use DEFSYM.
1741 (Qmetadata): New var.
1742 * data.c (Qbuffer): Don't make it static.
1743 (syms_of_data): Use DEFSYM.
1745 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1747 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1748 (CCL_CODE_MIN): New macro.
1750 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1752 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1754 * eval.c (Qdebug): Now static.
1755 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1756 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1757 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1759 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1761 * image.c: Various fixes to ImageMagick code comments.
1762 (Fimagemagick_types): Doc fix.
1764 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1766 Minor fixes prompted by GCC 4.6.0 warnings.
1768 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1770 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1771 (x_clipboard_manager_save_all): Move extern decl to ...
1772 * xterm.h: ... here, so that it can be checked for consistency.
1774 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1776 * xselect.c (x_clipboard_manager_save_frame)
1777 (x_clipboard_manager_save_all): New functions.
1778 (Fx_clipboard_manager_save): Lisp function deleted.
1780 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1781 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1783 * xterm.h: Update prototype.
1785 2011-05-28 William Xu <william.xwl@gmail.com>
1787 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1790 2011-05-28 Jim Meyering <meyering@redhat.com>
1792 Avoid a sign-extension bug in crypto_hash_function.
1793 * fns.c (to_uchar): Define.
1794 (crypto_hash_function): Use it to convert some newly-signed
1795 variables to unsigned, to avoid sign-extension bugs. For example,
1796 without this change, (md5 "truc") would evaluate to
1797 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1798 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1799 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1801 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1803 Integer overflow fixes.
1805 * dbusbind.c: Serial number integer overflow fixes.
1806 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1807 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1808 to hold a serial number that is too large for a fixnum.
1809 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1810 Check for serial numbers out of range. Decode any serial number
1811 that was so large that it became a float. (Bug#8722)
1813 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1814 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1815 Use XFASTINT rather than XUINT when numbers are nonnegative.
1816 (xd_append_arg, Fdbus_method_return_internal):
1817 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1818 arguments, check that Lisp number is nonnegative, rather than
1819 silently wrapping negative numbers around. (Bug#8722)
1820 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1823 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1825 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1827 ccl: add integer overflow checks
1828 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1829 (IN_INT_RANGE): New macros.
1830 (ccl_driver): Use them to check for integer overflow when
1831 decoding a CCL program. Many of the new checks are whether XINT (x)
1832 fits in int; it doesn't always, on 64-bit hosts. The new version
1833 doesn't catch all possible integer overflows, but it's an
1834 improvement. (Bug#8719)
1836 * alloc.c (make_event_array): Use XINT, not XUINT.
1837 There's no need for unsigned here.
1839 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1840 This follows up to the 2011-05-06 change that substituted uintptr_t
1841 for EMACS_INT. This case wasn't caught back then.
1843 Rework Fformat to avoid integer overflow issues.
1844 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1845 now (part of C89). Include <verify.h>.
1846 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1847 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1848 (Fformat): Avoid the prepass trying to compute sizes; it was only
1849 approximate and thus did not catch overflow reliably. Instead, walk
1850 through the format just once, formatting and computing sizes as we go,
1851 checking for integer overflow at every step, and allocating a larger
1852 buffer as needed. Keep track separately whether the format is
1853 multibyte. Keep only the most-recently calculated precision, rather
1854 than them all. Record whether each argument has been converted to
1855 string. Use EMACS_INT, not int, for byte and char and arg counts.
1856 Support field widths and precisions larger than INT_MAX. Avoid
1857 sprintf's undefined behavior with conversion specifications such as %#d
1858 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1859 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1860 formatting out-of-range floating point numbers with int
1863 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1865 * data.c: Avoid integer truncation in expressions involving floats.
1866 * data.c: Include <intprops.h>.
1867 (arith_driver): When there's an integer overflow in an expression
1868 involving floating point, convert the integers to floating point
1869 so that the resulting value does not suffer from catastrophic
1870 integer truncation. For example, on a 64-bit host (* 4
1871 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1872 Do not rely on undefined behavior after integer overflow.
1874 merge count_size_as_multibyte, parse_str_to_multibyte
1875 * character.c, character.h (count_size_as_multibyte):
1876 Rename from parse_str_to_multibyte; all uses changed.
1877 Check for integer overflow.
1878 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1879 since it's now a duplicate of the other. This is more of
1880 a character than a buffer op, so better that it's in character.c.
1881 * fns.c, print.c: Adjust to above changes.
1883 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1885 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1887 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1889 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1890 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1891 (x_clipboard_manager_save): Now static.
1892 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1894 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1895 (crypto_hash_function): Now static.
1896 Fix pointer signedness problems. Avoid unnecessary initializations.
1898 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1900 * termhooks.h (Vselection_alist): Make it terminal-local.
1902 * terminal.c (create_terminal): Initialize it.
1904 * xselect.c: Support for clipboard managers.
1905 (Vselection_alist): Move to termhooks.h as terminal-local var.
1906 (LOCAL_SELECTION): New macro.
1907 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1908 (symbol_to_x_atom): Remove gratuitous arg.
1909 (x_handle_selection_request, lisp_data_to_selection_data)
1910 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1911 (x_own_selection, x_get_local_selection, x_convert_selection):
1912 New arg, specifying work frame. Use terminal-local Vselection_alist.
1913 (some_frame_on_display): Delete unused function.
1914 (Fx_own_selection_internal, Fx_get_selection_internal)
1915 (Fx_disown_selection_internal, Fx_selection_owner_p)
1916 (Fx_selection_exists_p): New optional frame arg.
1917 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1918 (x_handle_selection_clear): Don't treat other terminals with the
1919 same keyboard specially. Use the terminal-local Vselection_alist.
1920 (x_clear_frame_selections): Use Frun_hook_with_args.
1922 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1924 * xterm.h: Add support for those atoms.
1926 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1928 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1929 (converted_selections, conversion_fail_tag): New global variables.
1930 (x_selection_request_lisp_error): Free the above.
1931 (x_get_local_selection): Remove unnecessary code.
1932 (x_reply_selection_request): Args changed; handle arbitrary array
1933 of converted selections stored in converted_selections.
1934 Separate the XChangeProperty and SelectionNotify steps.
1935 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1936 (x_convert_selection): New function.
1937 (x_handle_selection_event): Simplify.
1938 (x_get_foreign_selection): Don't ignore incoming requests while
1939 waiting for an answer; this will fail when we implement
1940 SAVE_TARGETS, and seems unnecessary anyway.
1941 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1942 (Vx_sent_selection_functions): Doc fix.
1944 2011-05-26 Leo Liu <sdl.web@gmail.com>
1946 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1948 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1950 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1952 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1953 for fringe update if it has periodic bitmap.
1954 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1955 and fringe_bitmap_periodic_p.
1957 * fringe.c (get_fringe_bitmap_data): New function.
1958 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1959 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1960 row. Mark glyph row for fringe update if periodicity changed.
1962 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1963 for fringe update unless it has periodic bitmap.
1965 2011-05-25 Kenichi Handa <handa@m17n.org>
1967 * xdisp.c (get_next_display_element): Set correct it->face_id for
1968 a static composition.
1970 2011-05-24 Leo Liu <sdl.web@gmail.com>
1973 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1975 * fns.c (crypto_hash_function, Fsha1): New function.
1976 (Fmd5): Use crypto_hash_function.
1977 (syms_of_fns): Add Ssha1.
1979 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1981 * gnutls.c: Remove unused macros.
1982 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1983 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1984 Remove macros that are defined and never used.
1985 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1987 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1989 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1990 (Fx_get_selection_internal): Minor cleanup.
1991 (Fx_own_selection_internal): Rename arguments for consistency with
1994 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1996 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1998 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2000 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2002 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2004 * dispnew.c (scrolling_window): Don't exclude the case that the
2005 last enabled row in the desired matrix touches the bottom boundary.
2007 2011-05-21 Glenn Morris <rgm@gnu.org>
2009 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2010 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2011 and add some more files.
2013 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2015 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2016 report_file_error introduced by the change from 2011-05-07.
2018 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2020 * systime.h (Time): Define only if emacs is defined.
2021 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2022 where the include path doesn't have X11/X.h by default. See
2023 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2025 2011-05-20 Kenichi Handa <handa@m17n.org>
2027 * composite.c (find_automatic_composition): Fix previous change.
2029 2011-05-20 Glenn Morris <rgm@gnu.org>
2031 * lisp.mk: New file, split from Makefile.in.
2032 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2033 (shortlisp): Remove.
2034 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2036 2011-05-19 Glenn Morris <rgm@gnu.org>
2038 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2039 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2040 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2041 (lisp): Set the order to that of loadup.el.
2042 (shortlisp): Make it a copy of $lisp.
2043 (SOME_MACHINE_LISP): Remove.
2044 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2045 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2047 2011-05-18 Kenichi Handa <handa@m17n.org>
2049 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2050 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2051 (find_automatic_composition): Mostly rewrite for efficiency.
2053 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2055 * makefile.w32-in: Update dependencies.
2057 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2059 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2060 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2062 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2064 Fix some integer overflow issues, such as string length overflow.
2066 * insdel.c (count_size_as_multibyte): Check for string overflow.
2068 * character.c (lisp_string_width): Check for string overflow.
2069 Use EMACS_INT, not int, for string indexes and lengths; in
2070 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2071 the resulting string length overflows an EMACS_INT; instead,
2072 report a string overflow if no precision given. When checking for
2073 precision exhaustion, use a check that cannot possibly have
2074 integer overflow. (Bug#8675)
2075 * character.h (lisp_string_width): Adjust to new signature.
2077 * alloc.c (string_overflow): New function.
2078 (Fmake_string): Use it. This doesn't change behavior, but saves
2079 a few bytes and will simplify future changes.
2080 * character.c (string_escape_byte8): Likewise.
2081 * lisp.h (string_overflow): New decl.
2083 Fixups, following up to the user-interface timestamp change.
2084 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2085 for UI timestamps, instead of unsigned long.
2086 * msdos.c (mouse_get_pos): Likewise.
2087 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2088 * w32gui.h (Time): Define by including "systime.h" rather than by
2089 declaring it ourselves. (Bug#8664)
2091 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2092 * image.c (clear_image_cache): Likewise.
2094 * term.c (term_mouse_position): Don't assume time_t wraparound.
2096 Be more systematic about user-interface timestamps.
2097 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2098 and sometimes 'EMACS_UINT', to represent these timestamps.
2099 This change causes it to use 'Time' uniformly, as that's what X uses.
2100 This makes the code easier to follow, and makes it easier to catch
2101 integer overflow bugs such as Bug#8664.
2102 * frame.c (Fmouse_position, Fmouse_pixel_position):
2103 Use Time, not unsigned long, for user-interface timestamps.
2104 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2105 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2106 * keyboard.h (last_event_timestamp): Likewise.
2107 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2108 * menu.h (xmenu_show): Likewise.
2109 * term.c (term_mouse_position): Likewise.
2110 * termhooks.h (struct input_event.timestamp): Likewise.
2111 (struct terminal.mouse_position_hook): Likewise.
2112 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2113 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2114 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2115 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2117 * menu.h, termhooks.h: Include "systime.h", for Time.
2119 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2120 Don't assume that the difference between two unsigned long values
2121 can fit into an integer. At this point, we know button_down_time
2122 <= event->timestamp, so the difference must be nonnegative, so
2123 there's no need to cast the result if double-click-time is
2124 nonnegative, as it should be; check that it's nonnegative, just in
2125 case. This bug is triggered when events are more than 2**31 ms
2126 apart (about 25 days). (Bug#8664)
2128 * xselect.c (last_event_timestamp): Remove duplicate decl.
2129 (x_own_selection): Remove needless cast to unsigned long.
2131 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2132 that always fit in int. Use a sentinel instead of a counter, to
2133 avoid a temp and to allay GCC's concerns about possible int overflow.
2134 * frame.h (struct frame): Use int for menu_bar_items_used
2135 instead of EMACS_INT, since it always fits in int.
2137 * menu.c (grow_menu_items): Check for int overflow.
2139 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2141 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2142 Before, the code was not consistent. These values cannot exceed
2143 2**31 - 1 so there's no need to make them unsigned.
2144 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2145 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2146 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2148 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2150 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2151 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2152 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2153 presumably because the widths might not match.
2155 * window.c (size_window): Avoid needless test at loop start.
2157 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2159 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2161 2011-05-12 Drew Adams <drew.adams@oracle.com>
2163 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2165 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2167 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2168 `width' to `bar_area_x' and `bar_area_width', respectively.
2169 (x_scroll_run): Take account of fringe background extension.
2171 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2172 Rename local vars `left' and `width' to `bar_area_x' and
2173 `bar_area_width', respectively.
2174 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2175 background extension.
2177 2011-05-10 Jim Meyering <meyering@redhat.com>
2179 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2181 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2183 * image.c (Finit_image_library): Return t for built-in image types,
2184 like pbm and xbm. (Bug#8640)
2186 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2188 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2190 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2192 * w32console.c (Fset_screen_color): Doc fix.
2193 (Fget_screen_color): New function.
2194 (syms_of_ntterm): Defsubr it.
2196 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2197 unlink the temporary file if Fcall_process didn't create it in the
2199 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2200 child process will be redirected to a file specified with `:file'.
2201 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2202 cue to call_process_cleanup not to close that handle.
2204 2011-05-07 Ben Key <bkey76@gmail.com>
2206 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2207 one of two shell specific rules, either bootstrap-temacs-CMD or
2208 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2209 to the previous implementation of the bootstrap-temacs rule.
2210 The bootstrap-temacs-CMD rule is similar to the previous
2211 implementation of the bootstrap-temacs rule except that it
2212 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2215 These changes, along with some changes to nt/configure.bat,
2216 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2217 earlier fix to add support for --cflags and --ldflags options
2218 that include quotes so that it works whether make uses cmd or
2221 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2223 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2224 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2226 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2227 a string. Handle both cases.
2228 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2229 (Fdbus_register_method): Use Qinvalid_function.
2231 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2233 * makefile.w32-in: Update dependencies.
2234 (LISP_H): Add inttypes.h and stdin.h.
2235 (PROCESS_H): Add unistd.h.
2237 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2239 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2240 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2242 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2244 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2246 * term.c (vfatal): Remove stray call to va_end.
2247 It's not needed and the C Standard doesn't allow it here anyway.
2249 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2250 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2252 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2255 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2257 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2259 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2261 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2263 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2265 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2266 * charset.c (Fdefine_charset_internal): Don't initialize
2267 charset.code_space[15]. The value was garbage, on hosts with
2268 32-bit int (Bug#8600).
2270 * lread.c (read_integer): Be more consistent with string-to-number.
2271 Use string_to_number to do the actual conversion; this avoids
2272 rounding errors and fixes some other screwups. Without this fix,
2273 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2274 (digit_to_number): Move earlier, for benefit of read_integer.
2275 Return -1 if the digit is out of range for the base, -2 if it is
2276 not a digit in any supported base. (Bug#8602)
2278 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2280 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2281 to match comment at start of function. This also removes a
2282 GCC warning about overflow in a 32+64-bit port.
2284 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2286 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2287 Reported by Stefan Monnier in
2288 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2289 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2290 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2292 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2293 (EMACS_UINTPTR): Likewise, with uintptr_t.
2295 * lisp.h: Prefer 64-bit EMACS_INT if available.
2296 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2297 on 32-bit hosts that have 64-bit int, so that they can access
2299 However, temporarily disable this change unless the temporary
2300 symbol WIDE_EMACS_INT is defined.
2302 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2304 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2305 This removes an assumption that EMACS_INT and long are the same
2306 width as pointers. The assumption is true for Emacs porting targets
2307 now, but we want to make other targets possible.
2308 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2309 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2310 In the rest of the code, change types of integers that hold casted
2311 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2312 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2313 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2314 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2315 No need to cast type when ORing.
2316 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2317 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2318 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2319 assume EMACS_INT is the same width as char *.
2320 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2321 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2322 Remove no-longer-needed casts.
2323 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2324 (xg_tool_bar_help_callback, xg_make_tool_item):
2325 Use EMACS_INTPTR to hold an integer
2326 that will be cast to void *; this can avoid a GCC warning
2327 if EMACS_INT is not the same width as void *.
2328 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2329 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2330 (current_message_1, set_message_1):
2331 Use a local to convert to proper width without a cast.
2332 * xmenu.c (dialog_selection_callback): Likewise.
2334 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2335 Also, don't assume VALBITS / RAND_BITS is less than 5,
2336 and don't rely on undefined behavior when shifting a 1 left into
2338 * lisp.h (get_random): Change signature to match.
2340 * lread.c (hash_string): Use size_t, not int, for hash computation.
2341 Normally we prefer signed values; but hashing is special, because
2342 it's better to use unsigned division on hash table sizes so that
2343 the remainder is nonnegative. Also, size_t is the natural width
2344 for hashing into memory. The previous code used 'int', which doesn't
2345 retain enough info to hash well into very large tables.
2346 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2348 * dbusbind.c: Don't possibly lose pointer info when converting.
2349 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2350 Use XPNTR rather than XHASH, so that the high-order bits of
2351 the pointer aren't lost when converting through void *.
2353 * eval.c (Fautoload): Don't double-shift a pointer.
2355 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2357 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2359 * gnutls.c (DEF_GNUTLS_FN):
2360 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2362 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2364 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2367 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2369 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2370 New version that can reserve upto 2GB of heap space.
2372 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2374 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2376 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2378 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2379 `gnutls_certificate_set_x509_key_file'.
2381 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2383 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2384 Update dependencies.
2386 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2388 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2389 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2390 Remove unused parameter `fildes'.
2391 * process.c (read_process_output, send_process): Don't pass it.
2393 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2395 Fix previous change: the library cache is defined in w32.c.
2396 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2397 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2399 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2401 Implement dynamic loading of GnuTLS on Windows.
2403 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2404 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2405 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2408 * gnutls.c (Qgnutls_dll): Define.
2409 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2410 (gnutls_*): Declare function pointers.
2411 (init_gnutls_functions): New function to initialize function pointers.
2412 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2413 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2414 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2415 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2416 (emacs_gnutls_write, emacs_gnutls_read)
2417 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2418 (Fgnutls_available_p): New function.
2419 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2420 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2421 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2423 * image.c: Include w32.h.
2424 (Vimage_type_cache): Delete.
2425 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2426 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2427 (w32_delayed_load): Move to w32.c.
2429 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2431 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2432 (w32_delayed_load): Move from image.c. When loading a library, record
2433 its filename in the :loaded-from property of the library id.
2434 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2435 Initialize and staticpro them.
2436 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2438 * process.c: Include lisp.h before w32.h, not after.
2439 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2440 instead of gnutls_record_check_pending.
2442 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2444 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2446 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2447 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2450 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2452 * xterm.c (x_set_frame_alpha): Do not set property on anything
2453 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2455 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2457 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2459 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2461 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2462 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2463 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2464 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2465 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2466 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2467 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2468 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2469 (Qgnutls_bootprop_callbacks_verify): Make static.
2471 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2473 * callproc.c: Indentation fixup.
2475 * sysdep.c (wait_for_termination_1): Make static.
2476 (wait_for_termination, interruptible_wait_for_termination):
2477 Move after wait_for_termination_1.
2479 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2481 * sysdep.c (interruptible_wait_for_termination): New function
2482 which is like wait_for_termination, but allows keyboard
2485 * callproc.c (Fcall_process): Add (:file "file") as an option for
2487 (Fcall_process_region): Ditto.
2489 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2491 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2492 rather than `XVECTOR (FOO)->size'.
2494 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2495 inttypes.h, as a gnulib replacement is used if it not available in
2498 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2500 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2501 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2502 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2504 * coding.c (coding_alloc_by_realloc): Error out if destination
2505 will grow beyond MOST_POSITIVE_FIXNUM.
2506 (decode_coding_emacs_mule): Abort if there isn't enough place in
2507 charbuf for the composition carryover bytes. Reserve an extra
2508 space for up to 2 characters produced in a loop.
2509 (decode_coding_iso_2022): Abort if there isn't enough place in
2510 charbuf for the composition carryover bytes.
2512 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2514 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2515 aborting when %lld or %lll format is passed.
2516 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2517 %llo or %llx format is passed. (Bug#8545)
2519 * window.c (window_scroll_line_based): Use a marker instead of
2520 simple variables to record original value of point. (Bug#7952)
2522 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2523 produced by %s or %c overflows available buffer space. (Bug#8545)
2525 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2527 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2528 (SIZE_MAX): Move defn after all includes, as they might #define it.
2530 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2532 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2534 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2536 * keyboard.c (Qdelayed_warnings_hook): Define.
2537 (command_loop_1): Run `delayed-warnings-hook'
2538 if Vdelayed_warnings_list is non-nil.
2539 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2540 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2542 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2544 * doprnt.c (doprnt): Don't return value smaller than the buffer
2545 size if the message was truncated. (Bug#8545).
2547 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2549 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2550 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2552 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2554 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2556 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2558 * makefile.w32-in: Update dependencies.
2560 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2562 Improve `doprnt' and its usage. (Bug#8545)
2563 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2564 `format_end'. Remove support for %l as a conversion specifier.
2565 Don't use xrealloc. Improve diagnostics when the %l size modifier
2566 is used. Update the commentary.
2568 * eval.c (verror): Simplify calculation of size_t.
2570 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2573 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2575 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2578 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2580 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2581 This makes this file independent of the recent pseudovector change.
2583 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2585 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2587 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2588 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2589 Remove unused local.
2590 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2592 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2593 GCC 4.6.0 optimizes based on type-based alias analysis.
2594 For example, if b is of type struct buffer * and v of type struct
2595 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2596 != &v->size, and therefore "v->size = 1; b->size = 2; return
2597 v->size;" must therefore return 1. This assumption is incorrect
2598 for Emacs, since it type-puns struct Lisp_Vector * with many other
2599 types. To fix this problem, this patch adds a new type struct
2600 vectorlike_header that documents the constraints on layout of vectors
2601 and pseudovectors, and helps optimizing compilers not get fooled
2602 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2603 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2604 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2606 (XSETPVECTYPE): Rewrite in terms of new macro.
2607 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2608 This is a bit clearer, and further avoids the possibility of
2609 undesirable aliasing.
2610 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2611 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2612 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2613 since Lisp_Subr is a special case (no "next" field).
2614 (ASIZE): Now uses header.size rather than size.
2615 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2616 to avoid the hassle of writing XVECTOR (foo)->header.size.
2617 (struct vectorlike_header): New type.
2618 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2619 object, to help avoid aliasing.
2620 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2621 (SUBRP): Likewise, since Lisp_Subr is a special case.
2622 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2623 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2624 (struct Lisp_Hash_Table): Combine first two members into a single
2625 struct vectorlike_header member. All uses of "size" and "next" members
2626 changed to be "header.size" and "header.next".
2627 * buffer.h (struct buffer): Likewise.
2628 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2629 * frame.h (struct frame): Likewise.
2630 * process.h (struct Lisp_Process): Likewise.
2631 * termhooks.h (struct terminal): Likewise.
2632 * window.c (struct save_window_data, struct saved_window): Likewise.
2633 * window.h (struct window): Likewise.
2634 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2635 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2636 * buffer.c (init_buffer_once): Likewise.
2637 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2639 * process.c (Fformat_network_address): Use local var for size,
2642 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2644 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2645 * data.c (atof): Remove decl; no longer used or needed.
2646 (digit_to_number): Move to lread.c.
2647 (Fstring_to_number): Use new string_to_number function, to be
2648 consistent with how the Lisp reader treats infinities and NaNs.
2649 Do not assume that floating-point numbers represent EMACS_INT
2650 without losing information; this is not true on most 64-bit hosts.
2651 Avoid double-rounding errors, by insisting on integers when
2652 parsing non-base-10 numbers, as the documentation specifies.
2653 * lisp.h (string_to_number): New decl, replacing ...
2654 (isfloat_string): Remove.
2655 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2656 (read1): Do not accept +. and -. as integers; this
2657 appears to have been a coding error. Similarly, do not accept
2658 strings like +-1e0 as floating point numbers. Do not report
2659 overflow for integer overflows unless the base is not 10 which
2660 means we have no simple and reliable way to continue.
2661 Break out the floating-point parsing into a new
2662 function string_to_number, so that Fstring_to_number parses
2663 floating point numbers consistently with the Lisp reader.
2664 (digit_to_number): Move here from data.c. Make it static inline.
2665 (E_CHAR, EXP_INT): Remove, replacing with ...
2666 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2667 (string_to_number): New function, replacing isfloat_string.
2668 This function checks for valid syntax and produces the resulting
2669 Lisp float number too. Rework it so that string-to-number
2670 no longer mishandles examples like "1.0e+". Use strtoumax,
2671 so that overflow for non-base-10 numbers is reported only when
2672 there's no portable and simple way to convert to floating point.
2674 * textprop.c (set_text_properties_1): Rewrite for clarity,
2675 and to avoid GCC warning about integer overflow.
2677 * intervals.h (struct interval): Use EMACS_INT for members
2678 where EMACS_UINT might cause problems. See
2679 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2680 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2681 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2683 (offset_intervals): Tell GCC not to worry about length overflow
2684 when negating a negative length.
2686 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2687 (overrun_check_free): Likewise.
2689 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2690 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2693 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2694 (gnutls_make_error): Rename local to avoid shadowing.
2695 (gnutls_emacs_global_deinit): ifdef out; not used.
2696 (Fgnutls_boot): Use const for pointer to readonly storage.
2697 Comment out unused local. Fix pointer signedness problems.
2699 * lread.c (openp): Don't stuff size_t into an 'int'.
2700 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2701 about possible signed overflow.
2703 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2704 (GDK_KEY_g): Don't define if already defined.
2705 (xg_prepare_tooltip): Avoid pointer signedness problem.
2706 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2708 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2709 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2711 * xfns.c (Fx_window_property): Simplify a bit,
2712 to make a bit faster and to avoid GCC 4.6.0 warning.
2713 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2715 * fns.c (internal_equal): Don't assume size_t fits in int.
2717 * alloc.c (compact_small_strings): Tighten assertion a little.
2719 Replace pEd with more-general pI, and fix some printf arg casts.
2720 * lisp.h (pI): New macro, generalizing old pEd macro to other
2721 conversion specifiers. For example, use "...%"pI"d..." rather
2722 than "...%"pEd"...".
2723 (pEd): Remove. All uses replaced with similar uses of pI.
2724 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2725 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2726 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2727 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2728 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2729 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2730 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2732 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2733 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2734 * print.c (safe_debug_print, print_object): Likewise.
2735 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2737 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2738 avoiding the 0 flag, which is not portable.
2739 * process.c (Fmake_network_process): Use pI to avoid cast.
2740 * region-cache.c (pp_cache): Likewise.
2741 * xdisp.c (decode_mode_spec): Likewise.
2742 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2743 behavior on 64-bit hosts with printf arg.
2744 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2745 (x_stop_queuing_selection_requests): Likewise.
2746 (x_get_window_property): Don't truncate byte count to an 'int'
2749 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2750 here, since it parses constructs like leading '-' and spaces,
2751 which are not wanted; and it overflows with large numbers.
2752 Instead, simply match F[0-9]+, which is what is wanted anyway.
2754 * alloc.c: Remove unportable assumptions about struct layout.
2755 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2756 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2757 (allocate_vectorlike, make_pure_vector): Use the new macros,
2758 plus offsetof, to remove unportable assumptions about struct layout.
2759 These assumptions hold on all porting targets that I know of, but
2760 they are not guaranteed, they're easy to remove, and removing them
2761 makes further changes easier.
2763 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2764 This doesn't fix a bug but makes the code clearer.
2765 (string_overrun_cookie): Now const. Use initializers that
2766 don't formally overflow signed char, to avoid warnings.
2767 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2768 can cause Emacs to crash when string overrun checking is enabled.
2769 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2770 multiple of sizeof (EMACS_INT); it need not be, if
2771 alignof(EMACS_INT) < sizeof (EMACS_INT).
2772 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2774 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2776 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2778 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2780 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2781 supposed to be handshaking. (Bug#8556)
2782 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2784 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2786 * lisp.h (Qdebug): List symbol.
2787 * eval.c (Qdebug): Restore global linkage.
2788 * keyboard.c (debug-on-event): New variable.
2789 (handle_user_signal): Break into debugger when debug-on-event
2790 matches the current signal symbol.
2792 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2794 * alloc.c (check_sblock, check_string_bytes)
2795 (check_string_free_list): Convert to standard C.
2797 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2799 * w32.c (emacs_gnutls_push): Fix typo.
2801 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2803 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2804 "cast to pointer from integer of different size".
2806 Improve doprnt and its use in verror. (Bug#8545)
2807 * doprnt.c (doprnt): Document the set of format control sequences
2808 supported by the function. Use SAFE_ALLOCA instead of always
2811 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2812 is one byte too soon. Don't use xrealloc; instead xfree and
2815 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2817 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2820 * gnutls.c: Renamed global_initialized to
2821 gnutls_global_initialized. Added internals for the
2822 :verify-hostname-error, :verify-error, and :verify-flags
2823 parameters of `gnutls-boot' and documented those parameters in the
2824 docstring. Start callback support.
2825 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2826 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2827 on error. Return error code.
2828 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2829 (emacs_gnutls_read): Likewise.
2830 (Fgnutls_boot): Return handshake error code.
2831 (emacs_gnutls_handle_error): New function.
2832 (wsaerror_to_errno): Likewise.
2834 * w32.h (emacs_gnutls_pull): Add prototype.
2835 (emacs_gnutls_push): Likewise.
2837 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2838 (emacs_gnutls_push): Likewise.
2840 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2842 * process.c (wait_reading_process_output): Check if GnuTLS
2843 buffered some data internally if no FDs are set for TLS
2846 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2847 (LIBS): Link to USER_LIBS.
2848 ($(BLD)/gnutls.$(0)): New target.
2850 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2852 * xdisp.c (handle_single_display_spec): Rename the
2853 display_replaced_before_p argument into display_replaced_p, to
2854 make it consistent with the commentary. Fix typos in the
2857 * textprop.c (syms_of_textprop): Remove dead code.
2858 (copy_text_properties): Delete obsolete commentary about an
2859 interface that was deleted long ago. Fix typos in the description
2862 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2863 to changes in oldXMenu/XMenu.h from 2011-04-16.
2864 <menu_help_message, prev_menu_help_message>: Constify.
2865 (IT_menu_make_room): menu->help_text is now `const char **';
2868 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2869 to changes in oldXMenu/XMenu.h from 2011-04-16.
2870 (struct XMenu): Declare `help_text' `const char **'.
2872 * xfaces.c <Qunspecified>: Make extern again.
2874 * syntax.c: Include sys/types.h before including regex.h, as
2877 * doc.c (get_doc_string): Improve the format passed to `error'.
2879 * doprnt.c (doprnt): Improve commentary.
2881 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2883 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2886 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2887 changes in globals.h immediately force recompilation.
2888 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2889 $(CURDIR)/s/ms-w32.h.
2890 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2892 * character.c (Fchar_direction): Function deleted.
2893 (syms_of_character): Don't defsubr it.
2894 <char-direction-table>: Deleted.
2896 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2898 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2899 * doprnt.c: Include limits.h.
2900 (SIZE_MAX): New macro.
2901 (doprnt): Return a size_t value. 2nd arg is now size_t.
2902 Many local variables are now size_t instead of int or unsigned.
2903 Improve overflow protection. Support `l' modifier for integer
2904 conversions. Support %l conversion. Don't assume an EMACS_INT
2905 argument for integer conversions and for %c.
2907 * lisp.h (doprnt): Restore prototype.
2909 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2912 * Makefile.in (base_obj): Add back doprnt.o.
2914 * deps.mk (doprnt.o): Add back prerequisites.
2915 (callint.o): Depend on character.h.
2917 * eval.c (internal_lisp_condition_case): Include the handler
2918 representation in the error message.
2919 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2920 when breaking from the loop.
2922 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2924 * callint.c (Fcall_interactively): When displaying error message
2925 about invalid control letter, pass the character's codepoint, not
2926 a pointer to its multibyte form. Improve display of the character
2927 in octal and display also its hex code.
2929 * character.c (char_string): Use %x to display the (unsigned)
2930 codepoint of an invalid character, to avoid displaying a bogus
2933 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2934 `error', not SYMBOL_NAME itself.
2936 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2937 character arguments to `error'.
2939 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2940 to `error' in error message about FINAL_CHAR argument. Make sure
2941 FINAL_CHAR is a character, and use %c when it is passed as
2942 argument to `error'.
2944 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2946 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2948 * w32.c: Include <time.h>.
2949 (sys_localtime): New function.
2951 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2953 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2955 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2957 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2959 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2962 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2964 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2965 gl_state.e_property when gl_state.object is Qt.
2967 * insdel.c (make_gap_larger): Remove limitation of buffer size
2970 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2972 * xdisp.c (lookup_glyphless_char_display)
2973 (produce_glyphless_glyph): Handle cons cell entry in
2974 glyphless-char-display.
2975 (Vglyphless_char_display): Document it.
2977 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2978 glyphless-char-display.
2980 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2982 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2984 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2986 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2987 definition for no-X builds.
2989 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2991 Static checks with GCC 4.6.0 and non-default toolkits.
2993 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2995 * process.c (keyboard_bit_set): Define only if SIGIO.
2996 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2997 (send_process): Repair possible setjmp clobbering.
2999 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3001 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3003 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3005 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3006 Define only if needed.
3008 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3009 by pacifying GCC about it. Maybe it's time to retire it?
3010 * xfaces.c (USG, __TIMEVAL__): Likewise.
3012 * dispextern.h (struct redisplay_interface): Rename param
3014 * termhooks.h (struct terminal): Likewise.
3015 * xterm.c (xembed_send_message): Likewise.
3017 * insdel.c (make_gap_smaller): Define only if
3018 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3020 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3023 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3024 so that we aren't warned about unused symbols.
3026 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3028 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3030 * xfns.c (x_real_positions): Mark locals as initialized.
3032 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3034 * xterm.c: Fix problems found by static analysis with other toolkits.
3035 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3036 (x_dispatch_event): Declare static if USE_GTK, and
3037 define if USE_GTK || USE_X_TOOLKIT.
3038 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3039 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3040 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3041 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3043 * xmenu.c (menu_help_callback): Pointer type fixes.
3044 Use const pointers when pointing at readonly data. Avoid pointer
3046 (FALSE): Remove unused macro.
3047 (update_frame_menubar): Remove unused decl.
3049 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3051 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3052 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3053 (single_menu_item): Rename local to avoid shadowing.
3055 * keyboard.c (make_lispy_event): Remove unused local var.
3057 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3058 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3060 * bitmaps: Change bitmaps from unsigned char back to the X11
3061 compatible char. Avoid the old compiler warnings about
3062 out-of-range initializers by using, for example, '\xab' rather
3065 * xgselect.c (xgselect_initialize): Check vs interface
3066 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3068 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3070 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3071 to read-only memory.
3073 * fns.c (vector): Remove; this old hack is no longer needed.
3075 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3077 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3079 * xrdb.c (x_load_resources): Omit unused local.
3081 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3082 (x_window): Rename locals to avoid shadowing.
3083 (USG): Use the kludged USG macro, to pacify gcc.
3085 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3086 (x_term_init): Remove local to avoid shadowing.
3088 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3090 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3091 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3093 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3095 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3097 Fix regex.c, syntax.c and friends for buffers > 2GB.
3098 * syntax.h (struct gl_state_s): Declare character position members
3101 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3103 * textprop.c (verify_interval_modification, interval_of):
3104 Declare arguments EMACS_INT.
3106 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3109 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3111 * indent.c (Fvertical_motion): Local variable it_start is now
3114 * regex.c (re_match, re_match_2, re_match_2_internal)
3115 (bcmp_translate, regcomp, regexec, print_double_string)
3116 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3117 (re_compile_pattern, re_exec): Declare arguments and local
3118 variables `size_t' and `ssize_t' and return values `regoff_t', as
3120 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3121 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3122 <compile_stack_type>: `size' and `avail' are now `size_t'.
3124 * regex.h <regoff_t>: Use ssize_t, not int.
3125 (re_search, re_search_2, re_match, re_match_2): Arguments that
3126 specify buffer/string position and length are now ssize_t and
3127 size_t. Return type is regoff_t.
3129 2011-04-16 Ben Key <bkey76@gmail.com>
3131 * nsfont.m: Fixed bugs in ns_get_family and
3132 ns_descriptor_to_entity that were caused by using free to
3133 deallocate memory blocks that were allocated by xmalloc (via
3134 xstrdup). This caused Emacs to crash when compiled with
3135 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3136 --enable-checking=xmallocoverrun). xfree is now used to
3137 deallocate these memory blocks.
3139 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3141 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3143 emacs_write: Accept and return EMACS_INT for sizes.
3144 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3146 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3147 Accept and return EMACS_INT.
3148 (emacs_gnutls_write): Return the number of bytes written on
3150 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3151 (emacs_read, emacs_write): Remove check for negative size, as the
3152 Emacs source code has been audited now.
3153 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3154 (emacs_read, emacs_write): Use it.
3155 * process.c (send_process): Adjust to the new signatures of
3156 emacs_write and emacs_gnutls_write. Do not attempt to store
3157 a byte offset into an 'int'; it might overflow.
3158 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3160 * sound.c: Don't assume sizes fit in 'int'.
3161 (struct sound_device.period_size, alsa_period_size):
3162 Return EMACS_INT, not int.
3163 (struct sound_device.write, vox_write, alsa_write):
3164 Accept EMACS_INT, not int.
3165 (wav_play, au_play): Use EMACS_INT to store sizes and to
3166 record read return values.
3168 2011-04-15 Ben Key <bkey76@gmail.com>
3170 * keyboard.c (Qundefined): Don't declare static since it is used
3172 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3173 static since they are used in nsfont.m.
3175 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3177 * process.c (Qprocessp): Don't declare static.
3178 * lisp.h (Qprocessp): Declare again.
3180 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3182 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3184 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3186 Improve C-level modularity by making more things 'static'.
3188 Don't publish debugger-only interfaces to other modules.
3189 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3190 (verify_bytepos, count_markers): Move decls to the only modules
3192 * region-cache.h (pp_cache): Likewise.
3193 * window.h (check_all_windows): Likewise.
3194 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3196 * sysdep.c (croak): Now static, if
3197 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3198 * syssignal.h (croak): Declare only if not static.
3200 * alloc.c (refill_memory_reserve): Now static if
3201 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3202 * lisp.h (refill_memory_reserve): Declare only if not static.
3204 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3205 Define only if USE_LUCID.
3207 * xrdb.c (x_customization_string, x_rm_string): Now static.
3209 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3210 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3212 * xdisp.c (draw_row_with_mouse_face): Now static.
3213 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3215 * window.h (check_all_windows): Mark externally visible.
3217 * window.c (window_deletion_count): Now static.
3219 * undo.c: Make symbols static if they're not exported.
3220 (last_undo_buffer, last_boundary_position, pending_boundary):
3223 * textprop.c (interval_insert_behind_hooks): Now static.
3224 (interval_insert_in_front_hooks): Likewise.
3226 * term.c: Make symbols static if they're not exported.
3227 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3228 (max_frame_lines, tty_set_terminal_modes):
3229 (tty_reset_terminal_modes, tty_turn_off_highlight):
3230 (get_tty_terminal): Now static.
3231 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3232 * termhooks.h (term_mouse_moveto): Do not declare if
3234 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3235 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3237 * sysdep.c: Make symbols static if they're not exported.
3238 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3240 (sigprocmask_set, full_mask): Remove; unused.
3241 (wait_debugging): Mark as visible.
3242 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3243 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3245 * syntax.c (syntax_temp): Define only if !__GNUC__.
3247 * sound.c (current_sound_device, current_sound): Now static.
3249 * search.c (searchbufs, searchbuf_head): Now static.
3251 * scroll.c (scroll_cost): Remove; unused.
3252 * dispextern.h (scroll_cost): Remove decl.
3254 * region-cache.h (pp_cache): Mark as externally visible.
3256 * process.c: Make symbols static if they're not exported.
3257 (process_tick, update_tick, create_process, chan_process):
3258 (Vprocess_alist, proc_buffered_char, datagram_access):
3259 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3260 (deactivate_process): Mark defn as static, as well as decl.
3261 * lisp.h (create_process): Remove decl.
3262 * process.h (chan_process, Vprocess_alist): Remove decls.
3264 * print.c: Make symbols static if they're not exported.
3265 (print_depth, new_backquote_output, being_printed, print_buffer):
3266 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3267 (print_interval, print_number_index, initial_stderr_stream):
3269 * lisp.h (Fprinc): Remove decl.
3270 (debug_output_compilation_hack): Mark as externally visible.
3272 * sysdep.c (croak): Move decl from here to syssignal.h.
3273 * syssignal.h (croak): Put it here, so the API can be checked when
3274 'croak' is called from dissociate_if_controlling_tty.
3276 * minibuf.c: Make symbols static if they're not exported.
3277 (minibuf_save_list, choose_minibuf_frame): Now static.
3278 * lisp.h (choose_minibuf_frame): Remove decl.
3280 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3282 * lread.c: Make symbols static if they're not exported.
3283 (read_objects, initial_obarray, oblookup_last_bucket_number):
3285 (make_symbol): Remove; unused.
3286 * lisp.h (initial_obarray, make_symbol): Remove decls.
3288 * keyboard.c: Make symbols static if they're not exported.
3289 (single_kboard, recent_keys_index, total_keys, recent_keys):
3290 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3291 (this_single_command_key_start, echoing, last_auto_save):
3292 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3293 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3294 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3295 (Vlispy_mouse_stem, double_click_count):
3297 (force_auto_save_soon): Define only if SIGDANGER.
3298 (ignore_mouse_drag_p): Now static if
3299 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3300 (print_help): Remove; unused.
3301 (stop_character, last_timer_event): Mark as externally visible.
3302 * keyboard.h (ignore_mouse_drag_p): Declare only if
3303 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3304 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3305 * lisp.h (echoing): Remove decl.
3306 (force_auto_save_soon): Declare only if SIGDANGER.
3307 * xdisp.c (redisplay_window): Simplify code, to make it more
3308 obvious that ignore_mouse_drag_p is not accessed if !defined
3309 USE_GTK && !defined HAVE_NS.
3311 * intervals.c: Make symbols static if they're not exported.
3312 (merge_properties_sticky, merge_interval_right, delete_interval):
3314 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3316 * insdel.c: Make symbols static if they're not exported.
3317 However, leave prepare_to_modify_buffer alone. It's never
3318 called from outside this function, but that appears to be a bug.
3319 (combine_after_change_list, combine_after_change_buffer):
3320 (adjust_after_replace, signal_before_change): Now static.
3321 (adjust_after_replace_noundo): Remove; unused.
3322 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3323 (signal_before_change): Remove decls.
3325 * indent.c (val_compute_motion, val_vmotion): Now static.
3327 * image.c: Make symbols static if they're not exported.
3328 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3330 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3331 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3333 * fringe.c (standard_bitmaps): Now static.
3334 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3336 * frame.c: Make symbols static if they're not exported.
3337 (x_report_frame_params, make_terminal_frame): Now static.
3338 (get_frame_param): Now static, unless HAVE_NS.
3339 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3340 (x_get_resource_string): Remove; not used.
3341 * frame.h (make_terminal_frame, x_report_frame_params):
3342 (x_get_resource_string); Remove decls.
3343 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3344 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3346 * font.c, fontset.c: Make symbols static if they're not exported.
3347 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3348 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3349 * font.c (font_close_object): Now static.
3350 * font.h (font_close_object): Remove.
3351 * fontset.c (FONTSET_OBJLIST): Remove.
3352 (free_realized_fontset) #if-0 the body, which does nothing.
3353 (face_suitable_for_char_p): #if-0, as it's never called.
3354 * fontset.h (face_suitable_for_char_p): Remove decl.
3355 * xfaces.c (face_at_string_position):
3356 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3357 since 0 is always ASCII.
3359 * fns.c (weak_hash_tables): Now static.
3361 * fileio.c: Make symbols static if they're not exported.
3362 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3363 (Vwrite_region_annotation_buffers): Now static.
3365 * eval.c: Make symbols static if they're not exported.
3366 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3367 * lisp.h (backtrace_list): Remove decl.
3369 * emacs.c: Make symbols static if they're not exported.
3370 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3371 (fatal_error_code, fatal_error_signal_hook, standard_args):
3373 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3374 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3375 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3376 * lisp.h (fatal_error_signal_hook): Remove decl.
3377 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3379 * editfns.c: Move a (normally-unused) function to its only use.
3380 * editfns.c, lisp.h (get_operating_system_release): Remove.
3381 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3382 worth the hassle of breaking this out.
3384 * xterm.c: Make symbols static if they're not exported.
3385 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3386 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3387 (x_destroy_window, x_delete_display):
3389 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3390 (x_mouse_leave): Remove; unused.
3391 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3392 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3393 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3395 (x_mouse_leave): Declare only if WINDOWSNT.
3396 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3397 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3400 * ftxfont.c: Make symbols static if they're not exported.
3401 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3403 * font.h (ftxfont_driver): Likewise.
3405 * xfns.c: Make symbols static if they're not exported.
3406 (x_last_font_name, x_display_info_for_name):
3407 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3408 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3409 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3410 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3411 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3412 (last_show_tip_args): Now static.
3413 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3414 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3415 (x_screen_planes): Remove; unused.
3416 * dispextern.h (x_screen_planes): Remove decl.
3418 * dispnew.c: Make symbols static if they're not exported.
3419 * dispextern.h (redraw_garbaged_frames, scrolling):
3420 (increment_row_positions): Remove.
3421 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3422 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3424 (redraw_garbaged_frames): Remove; unused.
3426 * xfaces.c: Make symbols static if they're not exported.
3427 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3429 * xterm.h (defined_color): Remove decls.
3430 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3431 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3432 (menu_face_changed_default, defined_color, free_realized_face):
3433 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3434 (ascii_face_of_lisp_face): Remove; unused.
3436 * xdisp.c: Make symbols static if they're not exported.
3437 * dispextern.h (scratch_glyph_row, window_box_edges):
3438 (glyph_to_pixel_coords, set_cursor_from_row):
3439 (get_next_display_element, set_iterator_to_next):
3440 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3441 (show_mouse_face): Remove decls
3442 * frame.h (message_buf_print): Likewise.
3443 * lisp.h (pop_message, set_message, check_point_in_composition):
3445 * xterm.h (set_vertical_scroll_bar): Likewise.
3446 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3447 (message_buf_print, scratch_glyph_row, displayed_buffer):
3448 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3449 (get_next_display_element, show_mouse_face, window_box_edges):
3450 (frame_to_window_pixel_xy, check_point_in_composition):
3451 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3452 (glyph_to_pixel_coords): Remove; unused.
3454 * dired.c (file_name_completion): Now static.
3456 * dbusbind.c (xd_in_read_queued_messages): Now static.
3458 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3459 * data.c (circular_list_error): Remove.
3461 * commands.h (last_point_position, last_point_position_buffer):
3462 (last_point_position_window): Remove decls.
3463 * keyboard.c: Make these variables static.
3465 * coding.h (coding, code_convert_region, encode_coding_gap):
3467 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3468 (iso_code_class, detect_coding, code_convert_region): Now static.
3469 (encode_coding_gap): Remove; unused.
3471 * chartab.c (chartab_chars, chartab_bits): Now static.
3473 * charset.h (charset_iso_8859_1): Remove decl.
3474 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3477 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3478 * ccl.c (Vccl_program_table): Now static.
3479 (check_ccl_update): Remove; unused.
3481 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3482 * category.h: ... from here.
3483 * category.c (check_category_table, set_category_set): Now static.
3485 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3486 * lisp.h: Remove these decls.
3488 * buffer.c (buffer_count): Remove unused var.
3490 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3491 so that it's not optimized away.
3492 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3493 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3494 exported only to the debugger.
3496 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3497 * atimer.h (run_all_atimers): Remove; not exported.
3499 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3500 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3501 was inaccessible from Lisp.
3502 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3503 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3505 alloc.c: Import and export fewer symbols, and remove unused items.
3506 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3508 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3509 it's not optimized away by whole-program optimization.
3510 (message_enable_multibyte, free_misc): Remove.
3511 (catchlist, handlerlist, mark_backtrace):
3512 Declare only if BYTE_MARK_STACK.
3513 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3514 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3515 (message_enable_multibyte): Remove decl.
3516 (free_misc, interval_free_list, float_block, float_block_index):
3517 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3518 (cons_free_list, last_marked_index):
3520 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3521 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3522 (mark_backtrace): Define only if BYTE_MARK_STACK.
3523 * xdisp.c (message_enable_multibyte): Now static.
3525 Declare Lisp_Object Q* variables to be 'static' if not exported.
3526 This makes it easier for human readers (and static analyzers)
3527 to see whether these variables are used from other modules.
3528 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3529 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3530 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3531 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3532 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3533 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3534 * xmenu.c, xselect.c:
3535 Declare Q* vars static if they are not used in other modules.
3536 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3537 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3538 Remove decls of unexported vars.
3539 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3541 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3543 Make Emacs functions such as Fatom 'static' by default.
3544 This makes it easier for human readers (and static analyzers)
3545 to see whether these functions can be called from other modules.
3546 DEFUN now defines a static function. To make the function external
3547 so that it can be used in other C modules, use the new macro DEFUE.
3548 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3549 (Finit_image_library):
3550 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3551 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3552 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3553 Remove decls, since these functions are now static.
3554 (Funintern, Fget_internal_run_time): New decls, since these functions
3555 were already external.
3557 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3558 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3559 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3560 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3561 * keyboard.c, keymap.c, lread.c:
3562 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3563 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3564 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3565 Mark functions with DEFUE instead of DEFUN,
3566 if they are used in other modules.
3567 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3568 decls for now-static functions.
3569 * buffer.h (Fdelete_overlay): Remove decl.
3570 * callproc.c (Fgetenv_internal): Mark as internal.
3571 * composite.c (Fremove_list_of_text_properties): Remove decl.
3572 (Fcomposition_get_gstring): New forward static decl.
3573 * composite.h (Fcomposite_get_gstring): Remove decl.
3574 * dired.c (Ffile_attributes): New forward static decl.
3575 * doc.c (Fdocumntation_property): New forward static decl.
3576 * eval.c (Ffetch_bytecode): New forward static decl.
3577 (Funintern): Remove extern decl; now in .h file where it belongs.
3578 * fileio.c (Fmake_symbolic_link): New forward static decl.
3579 * image.c (Finit_image_library): New forward static decl.
3580 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3581 * intervals.h (Fprevious_property_change):
3582 (Fremove_list_of_text_properties): Remove decls.
3583 * keyboard.c (Fthis_command_keys): Remove decl.
3584 (Fcommand_execute): New forward static decl.
3585 * keymap.c (Flookup_key): New forward static decl.
3586 (Fcopy_keymap): Now static.
3587 * keymap.h (Flookup_key): Remove decl.
3588 * process.c (Fget_process): New forward static decl.
3589 (Fprocess_datagram_address): Mark as internal.
3590 * syntax.c (Fsyntax_table_p): New forward static decl.
3591 (skip_chars): Remove duplicate decl.
3592 * textprop.c (Fprevious_property_change): New forward static decl.
3593 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3595 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3596 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3598 * editfns.c (Fformat): Remove unreachable code.
3600 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3602 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3605 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3607 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3608 when at ZV. (Bug#8487)
3610 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3612 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3614 * keyboard.c (parse_tool_bar_item): Likewise.
3615 * sound.c (sound_cleanup, alsa_close): Likewise.
3616 * termcap.c (tgetent): Likewise.
3617 * xfns.c (x_default_font_parameter): Likewise.
3618 * xsettings.c (read_and_apply_settings): Likewise.
3620 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3621 (overrun_check_free): Protoize.
3623 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3625 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3626 since callers should never pass a negative size.
3627 Change the signature to match that of plain 'read' and 'write'; see
3628 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3629 * lisp.h: Update prototypes of emacs_write and emacs_read.
3631 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3633 * xdisp.c (redisplay_window): Don't try to determine the character
3634 position of the scroll margin if the window start point w->startp
3635 is outside the buffer's accessible region. (Bug#8468)
3637 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3639 Fix write-region and its subroutines for buffers > 2GB.
3640 * fileio.c (a_write, e_write): Modify declaration of arguments and
3641 local variables to support buffers larger than 2GB.
3642 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3644 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3645 argument, local variables, and return value.
3647 * lisp.h: Update prototypes of emacs_write and emacs_read.
3649 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3651 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3653 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3655 Fix more problems found by GCC 4.6.0's static checks.
3657 * xdisp.c (vmessage): Use a better test for character truncation.
3659 * charset.c (load_charset_map): <, not <=, for optimization,
3660 and to avoid potential problems with integer overflow.
3661 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3662 * casetab.c (set_identity, shuffle): Likewise.
3663 * editfns.c (Fformat): Likewise.
3664 * syntax.c (skip_chars): Likewise.
3666 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3667 This also lets GCC 4.6.0 generate slightly better loop code.
3669 * callint.c (Fcall_interactively): <, not <=, for optimization.
3670 (Fcall_interactively): Count the number of arguments produced,
3671 not the number of arguments given. This is simpler and lets GCC
3672 4.6.0 generate slightly better code.
3674 * ftfont.c: Distingish more carefully between FcChar8 and char.
3675 The previous code passed unsigned char * to a functions like
3676 strlen and xstrcasecmp that expect char *, which does not
3677 conform to the C standard.
3678 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3679 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3680 char * when the C standard requires it.
3682 * keyboard.c (read_char): Remove unused var.
3684 * eval.c: Port to Windows vsnprintf (Bug#8435).
3686 (SIZE_MAX): Define if the headers do not.
3687 (verror): Do not give up if vsnprintf returns a negative count.
3688 Instead, grow the buffer. This ports to Windows vsnprintf, which
3689 does not conform to C99. Problem reported by Eli Zaretskii.
3690 Also, simplify the allocation scheme, by avoiding the need for
3691 calling realloc, and removing the ALLOCATED variable.
3693 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3695 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3696 But keep the doprint source code for now, as we might revamp it
3697 and use it again (Bug#8435).
3698 * lisp.h (doprnt): Remove.
3699 * Makefile.in (base_obj): Remove doprnt.o.
3700 * deps.mk (doprnt.o): Remove.
3702 error: Print 32- and 64-bit integers portably (Bug#8435).
3703 Without this change, on typical 64-bit hosts error ("...%d...", N)
3704 was used to print both 32- and 64-bit integers N, which relied on
3706 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3708 * lisp.h (error, verror): Mark as printf-like functions.
3709 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3710 Report overflow in size calculations when allocating printf buffer.
3711 Do not truncate output string at its first null byte.
3712 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3713 Truncate the output at a character boundary, since vsnprintf does not
3715 * charset.c (check_iso_charset_parameter): Convert internal
3716 character to string before calling 'error', since %c now has the
3718 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3719 overflow when computing char to be passed to 'error'. Do not
3720 pass Lisp_Object to 'error'; pass the integer instead.
3721 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3722 formatted with plain %d.
3724 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3726 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3728 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3730 * xterm.c (x_catch_errors): Remove duplicate declaration.
3732 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3734 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3736 2011-04-10 Jim Meyering <meyering@redhat.com>
3738 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3739 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3740 return ssize_t not "int", and use size_t as the buffer length.
3741 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3742 * gnutls.h: Update declarations.
3743 * process.c (read_process_output): Use ssize_t, to match.
3744 (send_process): Likewise.
3746 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3748 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3750 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3752 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3753 Use unsigned char, to match FcChar8 type definition.
3755 * xterm.c (handle_one_xevent):
3756 * xmenu.c (create_and_show_popup_menu):
3757 * xselect.c (x_decline_selection_request)
3758 (x_reply_selection_request): Avoid type-punned deref of X events.
3760 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3762 Fix some uses of `int' instead of EMACS_INT.
3763 * search.c (string_match_1, fast_string_match)
3764 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3765 (scan_buffer, find_next_newline_no_quit)
3766 (find_before_next_newline, search_command, Freplace_match)
3767 (Fmatch_data): Make some `int' variables be EMACS_INT.
3769 * xdisp.c (display_count_lines): 3rd argument and return value now
3770 EMACS_INT. All callers changed.
3771 (pint2hrstr): Last argument is now EMACS_INT.
3773 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3774 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3775 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3776 (decode_coding_utf_16, decode_coding_emacs_mule)
3777 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3778 (decode_coding_ccl, decode_coding_charset)
3779 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3780 (decode_coding_iso_2022, decode_coding_emacs_mule)
3781 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3782 <char_offset, last_offset>: Declare EMACS_INT.
3783 (encode_coding_utf_8, encode_coding_utf_16)
3784 (encode_coding_emacs_mule, encode_invocation_designation)
3785 (encode_designation_at_bol, encode_coding_iso_2022)
3786 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3787 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3789 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3790 (encode_invocation_designation): Last argument P_NCHARS is now
3792 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3793 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3795 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3798 * ccl.c (Fccl_execute_on_string): Declare some variables
3801 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3803 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3805 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3807 * process.c (Fformat_network_address): Doc fix.
3809 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3811 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3813 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3815 * keyboard.c (read_char): Call Lisp function help-form-show,
3816 instead of using internal_with_output_to_temp_buffer.
3817 (Qhelp_form_show): New var.
3818 (syms_of_keyboard): Use DEFSYM macro.
3820 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3822 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3824 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3826 * process.c (Flist_processes): Remove to Lisp.
3827 (list_processes_1): Delete.
3829 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3831 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3833 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3835 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3837 Fix more problems found by GCC 4.6.0's static checks.
3839 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3841 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3843 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3845 * xdisp.c (vmessage): Mark as a printf-like function.
3847 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3849 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3851 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3852 printf-like functions.
3853 (tiff_load): Add casts to remove these marks before passing them
3854 to system-supplied API.
3856 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3858 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3859 This avoids several warnings with gcc -Wstrict-overflow.
3860 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3861 directly, rather than having caller test rule sign. This avoids
3862 some unnecessary tests.
3863 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3864 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3865 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3867 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3868 (xfont_open): Avoid unnecessary tests.
3870 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3872 * composite.h, composite.c (composition_gstring_put_cache):
3873 Use EMACS_INT, not int, for length.
3875 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3876 breaking out part of COMPOSITION_DECODE_RULE.
3877 (COMPOSITION_DECODE_RULE): Use it.
3878 * composite.c (get_composition_id): Remove unused local vars,
3879 by using the new macro.
3881 * textprop.c (set_text_properties_1): Change while to do-while,
3882 since the condition is always true at first.
3884 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3885 (interval_deletion_adjustment): Return unsigned value.
3888 * process.c (list_processes_1, create_pty, read_process_output):
3889 (exec_sentinel): Remove vars that were set but not used.
3890 (create_pty): Remove unnecessary "volatile"s.
3891 (Fnetwork_interface_info): Avoid possibility of int overflow.
3892 (read_process_output): Do adaptive read buffering even if carryover.
3893 (read_process_output): Simplify nbytes computation if buffered.
3895 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3897 * syntax.c (scan_words): Remove var that was set but not used.
3898 (update_syntax_table): Use unsigned instead of int.
3900 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3901 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3902 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3904 * print.c (print_error_message): Avoid int overflow.
3906 * font.c (font_list_entities): Redo for clarity,
3907 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3909 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3910 (font_score): Avoid potential overflow in diff calculation.
3912 * fns.c (substring_both): Remove var that is set but not used.
3913 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3915 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3917 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3918 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3919 can always succeed if overflow has undefined behavior.
3921 * search.c (boyer_moore, wordify): Remove vars set but not used.
3922 (wordify): Omit three unnecessary tests.
3924 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3925 All callers changed. This avoids the need for an unused var.
3927 * casefiddle.c (casify_region): Remove var that is set but not used.
3929 * dired.c (file_name_completion): Remove var that is set but not used.
3931 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3933 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3934 (Finsert_file_contents): Remove unnecessary code checking fd.
3936 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3937 Check for integer overflow on size calculations.
3939 * buffer.c (Fprevious_overlay_change): Remove var that is set
3942 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3943 Remove vars that are set but not used.
3944 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3945 (timer_check_2): Mark vars as initialized.
3947 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3949 * image.c (lookup_image): Remove var that is set but not used.
3950 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3952 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3953 that are set but not used.
3955 * xfns.c (make_invisible_cursor): Don't return garbage
3956 if XCreateBitmapFromData fails (Bug#8410).
3958 * xselect.c (x_get_local_selection, x_handle_property_notify):
3959 Remove vars that are set but not used.
3961 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3962 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3964 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3965 Remove var that is set but not used.
3966 (scroll_bar_windows_size): Now size_t, not int.
3967 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3970 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3971 (map_tty_color) [!defined MSDOS]: Likewise.
3973 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3975 * coding.c: Remove vars that are set but not used.
3976 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3977 All callers changed.
3978 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3979 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3980 (decode_coding_charset): Remove vars that are set but not used.
3982 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3983 that is set but not used.
3985 * print.c (print_object): Remove var that is set but not used.
3987 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3988 The gnulib version avoids calling malloc in the usual case,
3989 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3990 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3991 * filelock.c (current_lock_owner): Likewise.
3992 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3993 * sysdep.c: Include allocator.h, careadlinkat.h.
3994 (emacs_no_realloc_allocator): New static constant.
3995 (emacs_readlink): New function.
3996 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3997 ../lib/careadlinkat.h.
3999 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4001 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4002 first non-nil return value).
4004 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4006 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4007 if not defined (Bug#8403).
4009 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4011 * xdisp.c (display_count_lines): Remove parameter `start',
4012 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4013 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4014 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4015 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4016 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4017 and thereabouts. All callers changed.
4018 (get_per_char_metric): Remove parameter `f', unused since
4019 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4021 2011-04-02 Jim Meyering <meyering@redhat.com>
4023 do not dereference NULL upon failed strdup
4024 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4025 (ns_get_family): Likewise.
4027 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4029 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4031 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4033 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4036 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4038 Add lexical binding.
4040 * window.c (Ftemp_output_buffer_show): New fun.
4041 (Fsave_window_excursion):
4042 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4044 * lread.c (lisp_file_lexically_bound_p): New function.
4045 (Fload): Bind Qlexical_binding.
4046 (readevalloop): Remove `evalfun' arg.
4047 Bind Qinternal_interpreter_environment.
4048 (Feval_buffer): Bind Qlexical_binding.
4049 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4051 (syms_of_lread): Declare `lexical-binding'.
4053 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4055 * keyboard.c (eval_dyn): New fun.
4056 (menu_item_eval_property): Use it.
4058 * image.c (parse_image_spec): Use Ffunctionp.
4060 * fns.c (concat, mapcar1): Accept byte-code-functions.
4062 * eval.c (Fsetq): Handle lexical vars.
4063 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4064 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4065 (FletX, Flet): Obey lexical binding.
4066 (Fcommandp): Handle closures.
4067 (Feval): New `lexical' arg.
4068 (eval_sub): New function extracted from Feval. Use it almost
4069 everywhere where Feval was used. Look up vars in lexical env.
4071 (Ffunctionp): Move from subr.el.
4072 (Ffuncall): Handle closures.
4073 (apply_lambda): Remove `eval_flags'.
4074 (funcall_lambda): Handle closures and new byte-code-functions.
4075 (Fspecial_variable_p): New function.
4076 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4077 but without exporting it to Lisp.
4079 * doc.c (Fdocumentation, store_function_docstring):
4080 * data.c (Finteractive_form): Handle closures.
4082 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4085 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4087 (exec_byte_code): New function extracted from Fbyte_code to handle new
4088 calling convention for byte-code-functions. Add new byte-codes.
4090 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4092 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4094 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4096 * xdisp.c (redisplay_internal): Fix prototype.
4098 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4100 * xdisp.c (SCROLL_LIMIT): New macro.
4101 (try_scrolling): Use it when setting scroll_limit.
4102 Limit scrolling to 100 screen lines.
4103 (redisplay_window): Even when falling back on "recentering",
4104 position point in the window according to scroll-conservatively,
4105 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4107 (try_scrolling): When point is above the window, allow searching
4108 as far as scroll_max, or one screenful, to compute vertical
4109 distance from PT to the scroll margin position. This prevents
4110 try_scrolling from unnecessarily failing when
4111 scroll-conservatively is set to a value slightly larger than the
4112 window height. Clean up the case of PT below the margin at bottom
4113 of window: scroll_max can no longer be INT_MAX. When aggressive
4114 scrolling is in use, don't let point enter the opposite scroll
4115 margin as result of the scroll.
4116 (syms_of_xdisp) <scroll-conservatively>: Document the
4117 threshold of 100 lines for never-recentering scrolling.
4119 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4121 * dispextern.h (move_it_by_lines):
4122 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4123 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4124 (message_log_check_duplicate): Remove parameters `prev_bol' and
4125 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4126 (redisplay_internal): Remove parameter `preserve_echo_area',
4127 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4129 * indent.c (Fvertical_motion):
4130 * window.c (window_scroll_pixel_based, Frecenter):
4131 Don't pass `need_y_p' to `move_it_by_lines'.
4133 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4135 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4136 steal a few bits to be more compact.
4137 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4138 Remove unneeded casts.
4140 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4142 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4144 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4145 binding" message (bug#7967).
4147 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4149 Fix more problems found by GCC 4.6.0's static checks.
4151 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4152 Remove unused local var.
4154 * editfns.c (Fmessage_box): Remove unused local var.
4156 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4157 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4158 Omit unused local vars.
4159 * window.c (shrink_windows): Omit unused local var.
4160 * menu.c (digest_single_submenu): Omit unused local var.
4161 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4162 Omit unused local var.
4164 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4165 Don't assume string length fits in int.
4166 (keyremap_step, read_key_sequence): Use size_t for sizes.
4167 (read_key_sequence): Don't check last_real_key_start redundantly.
4169 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4170 instead of alloca (Bug#8344).
4172 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4173 (Fbacktrace_frame): Don't assume nframes fits in int.
4175 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4177 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4180 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4182 * cm.c (calccost): Turn while-do into do-while, for clarity.
4184 * keyboard.c (syms_of_keyboard): Use the same style as later
4185 in this function when indexing through an array. This also
4186 works around GCC bug 48267.
4188 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4190 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4192 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4193 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4195 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4196 This avoids undefined behavior on integer overflow, and is a bit
4197 more convenient anyway since it is compared to a size_t variable.
4199 Variadic C functions now count arguments with size_t, not int.
4200 This avoids an unnecessary limitation on 64-bit machines, which
4201 caused (substring ...) to crash on large vectors (Bug#8344).
4202 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4203 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4204 All variadic functions and their callers changed accordingly.
4205 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4206 * data.c (arith_driver, float_arith_driver): Likewise.
4207 * editfns.c (general_insert_function): Likewise.
4208 * eval.c (struct backtrace.nargs, interactive_p)
4209 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4210 (funcall_lambda, mark_backtrace): Likewise.
4211 * fns.c (concat): Likewise.
4212 * frame.c (x_set_frame_parameters): Likewise.
4213 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4214 0 if not found, not -1. All callers changed.
4216 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4217 (stack_copy_size): Now size_t, not int.
4218 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4220 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4222 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4223 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4224 All callers changed.
4226 * lisp.h (multibyte_char_to_unibyte):
4227 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4228 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4229 * character.h (CHAR_TO_BYTE8):
4230 * cmds.c (internal_self_insert):
4231 * editfns.c (general_insert_function):
4232 * keymap.c (push_key_description):
4233 * search.c (Freplace_match):
4234 * xdisp.c (message_dolog, set_message_1): All callers changed.
4236 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4238 * keyboard.c (safe_run_hook_funcall): New function.
4239 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4240 don't set the hook to nil, but remove the offending function instead.
4241 (Qcommand_hook_internal): Remove, unused.
4242 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4243 Vcommand_hook_internal.
4245 * eval.c (enum run_hooks_condition): Remove.
4246 (funcall_nil, funcall_not): New functions.
4247 (run_hook_with_args): Call each function through a `funcall' argument.
4248 Remove `cond' argument, now redundant.
4249 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4250 (Frun_hook_with_args_until_failure): Adjust accordingly.
4251 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4253 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4255 * dispextern.h (string_buffer_position): Remove declaration.
4257 * print.c (strout): Remove parameter `multibyte', unused since
4258 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4260 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4261 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4262 All callers changed.
4264 * w32.c (_wsa_errlist): Use braces for struct initializers.
4266 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4267 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4268 All callers changed.
4269 (string_buffer_position): Likewise. Also, make static (it's never
4270 used outside xdisp.c).
4271 (cursor_row_p): Remove parameter `w', unused since
4272 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4273 (decode_mode_spec): Remove parameter `precision', introduced during
4274 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4275 All callers changed.
4277 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4279 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4281 2011-03-27 Anders Lindgren <andlind@gmail.com>
4283 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4284 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4285 (ns_update_auto_hide_menu_bar): New functions.
4286 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4287 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4288 ns_constrain_all_frames.
4289 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4290 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4292 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4294 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4296 2011-03-27 Glenn Morris <rgm@gnu.org>
4298 * syssignal.h: Replace RETSIGTYPE with void.
4299 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4300 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4301 Replace SIGTYPE with void everywhere.
4302 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4303 * s/template.h (SIGTYPE): Remove commented out definition.
4305 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4307 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4308 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4310 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4312 * w32.c (read_unc_volume): Use parameter `henum', instead of
4313 global variable `wget_enum_handle'.
4315 * keymap.c (describe_vector): Remove parameters `indices' and
4316 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4317 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4319 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4321 * keyboard.c (timer_check): Remove parameter `do_it_now',
4322 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4323 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4324 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4326 * keyboard.c (read_char):
4327 * w32menu.c (w32_menu_display_help):
4328 * xmenu.c (show_help_event, menu_help_callback):
4329 Adjust calls to `show_help_echo'.
4331 * gtkutil.c (xg_maybe_add_timer):
4332 * keyboard.c (readable_events):
4333 * process.c (wait_reading_process_output):
4334 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4336 * insdel.c (adjust_markers_gap_motion):
4337 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4338 (gap_left, gap_right): Don't call it.
4340 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4342 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4343 incurred during fontification.
4345 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4347 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4348 (DEFVAR_PER_BUFFER): Don't pass it.
4350 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4351 (scrolling_window): Don't pass it.
4353 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4355 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4357 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4359 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4360 of variables specific to SELinux and computation of `encoded_absname'.
4362 * image.c (XPutPixel): Remove unused variable `height'.
4364 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4366 * unexw32.c (get_section_info): Remove unused variable `section'.
4368 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4369 (system_process_attributes): Remove unused variable `sess'.
4370 (sys_read): Remove unused variable `err'.
4372 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4373 (w32_wnd_proc): Remove unused variable `isdead'.
4374 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4375 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4376 (x_create_tip_frame): Remove unused variable `tem'.
4378 * w32inevt.c (w32_console_read_socket):
4379 Remove unused variable `no_events'.
4381 * w32term.c (x_draw_composite_glyph_string_foreground):
4382 Remove unused variable `width'.
4384 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4386 * w32term.c (x_set_glyph_string_clipping):
4387 Don't pass uninitialized region to CombineRgn.
4389 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4391 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4392 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4393 (Fx_close_connection): Remove unused variable `i'.
4395 * w32font.c (w32font_draw): Return number of glyphs.
4396 (w32font_open_internal): Remove unused variable `i'.
4397 (w32font_driver): Add missing initializer.
4399 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4400 (fill_in_menu): Remove unused variable `items_added'.
4402 * w32term.c (last_mouse_press_frame): Remove static global variable.
4403 (w32_clip_to_row): Remove unused variable `f'.
4404 (x_delete_terminal): Remove unused variable `i'.
4406 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4407 (NOTHING): Remove unused static global variable.
4408 (uniscribe_check_otf): Remove unused variable `table'.
4409 (uniscribe_font_driver): Add missing initializers.
4411 2011-03-23 Julien Danjou <julien@danjou.info>
4413 * term.c (Fsuspend_tty, Fresume_tty):
4414 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4415 * window.c (temp_output_buffer_show):
4416 * insdel.c (signal_before_change):
4417 * frame.c (Fhandle_switch_frame):
4418 * fileio.c (Fdo_auto_save):
4419 * emacs.c (Fkill_emacs):
4420 * editfns.c (save_excursion_restore):
4421 * cmds.c (internal_self_insert):
4422 * callint.c (Fcall_interactively):
4423 * buffer.c (Fkill_all_local_variables):
4424 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4426 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4427 unconditionnaly since it does the check itself.
4429 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4431 Fix more problems found by GCC 4.5.2's static checks.
4433 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4434 the first time through the loop, since we know p0 < p1 then.
4435 This also avoids a gcc -Wstrict-overflow warning.
4437 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4438 leading to a memory leak, possible in functions like
4439 load_charset_map_from_file that can allocate an unbounded number
4440 of objects (Bug#8318).
4442 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4443 that could (at least in theory) be that large.
4445 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4446 This is less likely to overflow, and avoids undefined behavior if
4447 overflow does occur. All callers changed. Use strtoul to scan
4448 for the unsigned long integer.
4449 (pint2hrstr): Simplify and tune code slightly.
4450 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4452 * scroll.c (do_scrolling): Work around GCC bug 48228.
4453 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4455 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4456 This also avoids a warning with gcc -Wstrict-overflow.
4457 (validate_x_resource_name): Simplify count usage.
4458 This also avoids a warning with gcc -Wstrict-overflow.
4460 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4463 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4465 * process.c (Fmake_network_process): Use socklen_t, not int,
4466 where POSIX says socklen_t is required in portable programs.
4467 This fixes a porting bug on hosts like 64-bit HP-UX, where
4468 socklen_t is wider than int (Bug#8277).
4469 (Fmake_network_process, server_accept_connection):
4470 (wait_reading_process_output, read_process_output):
4473 * process.c: Rename or move locals to avoid shadowing.
4474 (list_processes_1, Fmake_network_process):
4475 (read_process_output_error_handler, exec_sentinel_error_handler):
4476 Rename or move locals.
4477 (Fmake_network_process): Define label "retry_connect" only if needed.
4478 (Fnetwork_interface_info): Fix pointer signedness.
4479 (process_send_signal): Add cast to avoid pointer signedness problem.
4480 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4481 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4483 Make tparam.h and terminfo.c consistent.
4484 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4485 Include tparam.h instead, since it declares them.
4486 * cm.h (PC): Remove extern decl; tparam.h now does this.
4487 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4488 * terminfo.c: Include tparam.h, to check interfaces.
4489 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4490 (tparam): Adjust signature to match interface in tparam.h;
4491 this removes some undefined behavior. Check that outstring and len
4492 are zero, which they always are with Emacs.
4493 * tparam.h (PC, BC, UP): New extern decls.
4495 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4496 (xftfont_open): Rename locals to avoid shadowing.
4498 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4499 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4500 (OTF_TAG_SYM): Omit macro if not needed.
4501 (ftfont_list): Remove unused local.
4502 (get_adstyle_property, ftfont_pattern_entity):
4503 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4504 Rename locals to avoid shadowing.
4506 * xfont.c (xfont_list_family): Mark var as initialized.
4508 * xml.c (make_dom): Now static.
4510 * composite.c (composition_compute_stop_pos): Rename local to
4512 (composition_reseat_it): Remove unused locals.
4513 (find_automatic_composition, composition_adjust_point): Likewise.
4514 (composition_update_it): Mark var as initialized.
4515 (find_automatic_composition): Mark vars as initialized,
4516 with a FIXME (Bug#8290).
4518 character.h: Rename locals to avoid shadowing.
4519 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4520 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4521 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4522 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4525 * textprop.c (property_change_between_p): Remove; unused.
4527 * intervals.c (interval_start_pos): Now static.
4529 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4531 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4532 Rename locals to avoid shadowing.
4534 * sound.c (wav_play, au_play, Fplay_sound_internal):
4535 Fix pointer signedness.
4536 (alsa_choose_format): Remove unused local var.
4537 (wav_play): Initialize a variable to 0, to prevent undefined
4538 behavior (Bug#8278).
4540 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4542 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4544 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4545 clobbering (Bug#8298).
4546 * sysdep.c (sys_subshell): Likewise.
4547 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4549 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4550 This should get cleaned up, so that child_setup has the
4551 same signature on all platforms.
4553 * callproc.c (call_process_cleanup): Now static.
4554 (relocate_fd): Rename locals to avoid shadowing.
4556 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4558 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4559 not to be necessary, and produces flickering.
4561 2011-03-20 Glenn Morris <rgm@gnu.org>
4563 * config.in: Remove file.
4565 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4567 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4568 are now in src/globals.h.
4569 (syms_of_minibuf): Remove spurious & from previous change.
4571 2011-03-20 Leo <sdl.web@gmail.com>
4573 * minibuf.c (completing-read-function): New variable.
4574 (completing-read-default): Rename from completing-read.
4575 (completing-read): Call completing-read-function.
4577 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4579 * xfaces.c (Fx_load_color_file):
4580 Read color file from absolute filename (bug#8250).
4582 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4584 * makefile.w32-in: Update dependencies.
4586 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4588 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4590 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4592 Fix more problems found by GCC 4.5.2's static checks.
4594 * process.c (make_serial_process_unwind, send_process_trap):
4595 (sigchld_handler): Now static.
4597 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4598 That way, the code declares only the vars that it needs.
4599 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4600 * s/cygwin.h (PTY_ITERATION): Likewise.
4601 * s/darwin.h (PTY_ITERATION): Likewise.
4602 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4604 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4605 * process.c (allocate_pty): Don't declare stb unless it's needed.
4607 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4608 (CONSTANTLIM): Remove; unused.
4609 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4610 Define only if needed.
4612 * unexelf.c (unexec): Name an expression,
4613 to avoid gcc -Wbad-function-cast warning.
4614 Use a different way to cause a compilation error if anyone uses
4615 n rather than nn, a way that does not involve shadowing.
4616 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4618 * deps.mk (unexalpha.o): Remove; unused.
4620 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4621 * unexec.h: New file.
4622 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4623 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4625 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4626 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4627 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4628 Change as necessary to match prototype in unexec.h.
4630 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4632 (back_comment, skip_chars): Mark vars as initialized.
4634 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4635 Rename locals to avoid shadowing.
4637 * lread.c (read1): Rewrite so as not to use empty "else".
4638 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4640 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4642 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4643 warning when compiling print.c.
4645 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4646 instead of using an uninitialized var.
4647 (font_sort_entities): Mark var as initialized.
4649 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4651 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4652 pointers to constants.
4653 (font_parse_fcname): Remove unused vars.
4654 (font_delete_unmatched): Now static.
4655 (font_get_spec): Remove; unused.
4656 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4657 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4658 Rename or move locals to avoid shadowing.
4660 * fns.c (require_nesting_list, require_unwind): Now static.
4661 (Ffillarray): Rename locals to avoid shadowing.
4663 * floatfns.c (domain_error2): Define only if needed.
4664 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4666 * alloc.c (mark_backtrace): Move decl from here ...
4667 * lisp.h: ... to here, so that it can be checked.
4669 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4670 (Fdefvar): Rewrite so as not to use empty "else".
4671 (lisp_indirect_variable): Name an expression,
4672 to avoid gcc -Wbad-function-cast warning.
4673 (Fdefvar): Rename locals to avoid shadowing.
4675 * callint.c (quotify_arg, quotify_args): Now static.
4676 (Fcall_interactively): Rename locals to avoid shadowing.
4677 Use const pointer when appropriate.
4679 * lisp.h (get_system_name, get_operating_system_release):
4680 Move decls here, to check interfaces.
4681 * process.c (get_operating_system_release): Move decl to lisp.h.
4682 * xrdb.c (get_system_name): Likewise.
4683 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4684 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4685 some of which prompt warnings from gcc -Wbad-function-cast.
4686 (Fformat_time_string, Fencode_time, Finsert_char):
4687 (Ftranslate_region_internal, Fformat):
4688 Rename or remove local vars to avoid shadowing.
4689 (Ftranslate_region_internal): Mark var as initialized.
4691 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4694 * lisp.h (eassert): Check that the argument compiles, even if
4695 ENABLE_CHECKING is not defined.
4697 * data.c (Findirect_variable): Name an expression, to avoid
4698 gcc -Wbad-function-cast warning.
4699 (default_value, arithcompare, arith_driver, arith_error): Now static.
4700 (store_symval_forwarding): Rename local to avoid shadowing.
4701 (Fmake_variable_buffer_local, Fmake_local_variable):
4702 Mark variables as initialized.
4703 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4705 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4706 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4707 Rename locals to avoid shadowing.
4708 (mark_stack): Move local variables into the #ifdef region where
4710 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4711 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4713 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4714 (GC_STRING_CHARS): Remove; not used.
4715 (Fmemory_limit): Cast sbrk's returned value to char *.
4717 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4718 avoids undefined behavior in theory.
4720 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4722 Use functions, not macros, for up- and down-casing (Bug#8254).
4723 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4724 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4725 to use the following functions instead of these macros.
4726 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4727 EMACS_INT, since callers assume the returned value fits in int.
4728 (upcase1): Likewise, for UPCASE_TABLE.
4729 (uppercasep, lowercasep, upcase): New static inline functions.
4730 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4731 the race-condition problem in the old DOWNCASE.
4733 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4734 Rename locals to avoid shadowing.
4735 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4736 (regex_compile, re_search_2, re_match_2_internal):
4737 Remove unused local vars.
4738 (FREE_VAR): Rewrite so as not to use empty "else",
4739 which gcc can warn about.
4740 (regex_compile, re_match_2_internal): Mark locals as initialized.
4741 (RETALLOC_IF): Define only if needed.
4742 (WORDCHAR_P): Likewise. This one is never needed, but is used
4743 only in a comment talking about a compiler bug, so put inside
4744 the #if 0 of that comment.
4745 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4746 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4749 * search.c (boyer_moore): Rename locals to avoid shadowing.
4750 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4751 (PREV_CHAR_BOUNDARY): Likewise.
4753 * search.c (simple_search): Remove unused var.
4755 * dired.c (compile_pattern): Move decl from here ...
4756 * lisp.h: ... to here, so that it can be checked.
4757 (struct re_registers): New forward decl.
4759 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4761 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4763 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4764 Rename locals to avoid shadowing.
4765 (Fvertical_motion): Mark locals as initialized.
4767 * casefiddle.c (casify_object, casify_region): Now static.
4768 (casify_region): Mark local as initialized.
4770 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4772 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4773 New macros, so that the caller can use some names other than
4774 gcpro1, gcpro2, etc.
4775 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4777 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4778 argument, for consistency with GCPRO2_VAR, etc: it is now the
4779 prefix of the variable, not the variable itself. All uses
4781 * dired.c (directory_files_internal, file_name_completion):
4782 Rename locals to avoid shadowing.
4784 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4785 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4786 dired.c's scmp function, had undefined behavior.
4787 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4788 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4789 * buffer.h: ... to here, because these macros use current_buffer,
4790 and the new implementation with inline functions needs to have
4791 current_buffer in scope now, rather than later when the macros
4793 (downcase, upcase1): New static inline functions.
4794 (DOWNCASE, UPCASE1): Reimplement using these functions.
4795 This avoids undefined behavior in expressions like
4796 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4797 from race conditions in accessing the global variables
4798 case_temp1 and case_temp2.
4799 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4800 * lisp.h (case_temp1, case_temp2): Remove their decls.
4801 * character.h (ASCII_CHAR_P): Move from here ...
4802 * lisp.h: ... to here, so that the inline functions mentioned
4805 * dired.c (directory_files_internal_unwind): Now static.
4807 * fileio.c (file_name_as_directory, directory_file_name):
4808 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4810 (file_name_as_directory): Use const pointers when appropriate.
4811 (Fexpand_file_name): Likewise. In particular, newdir might
4812 point at constant storage, so make it a const pointer.
4813 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4814 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4816 (Fset_file_times, Finsert_file_contents, auto_save_error):
4817 Rename locals to avoid shadowing.
4819 * minibuf.c (choose_minibuf_frame_1): Now static.
4820 (Ftry_completion, Fall_completions): Rename or remove locals
4823 * marker.c (bytepos_to_charpos): Remove; unused.
4825 * lisp.h (verify_bytepos, count_markers): New decls,
4826 so that gcc does not warn that these functions aren't declared.
4828 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4829 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4830 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4831 (copy_text): Remove unused local var.
4833 * filelock.c (within_one_second): Now static.
4834 (lock_file_1): Rename local to avoid shadowing.
4836 * buffer.c (fix_overlays_before): Mark locals as initialized.
4837 (fix_start_end_in_overlays): Likewise. This function should be
4838 simplified by using pointers-to-pointers, but that's a different
4840 (switch_to_buffer_1): Now static.
4841 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4842 (report_overlay_modification): Rename locals to avoid shadowing.
4844 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4845 Fix pointer signedness issue.
4846 (sys_subshell): Mark local as volatile if checking for lint,
4847 to suppress a gcc -Wclobbered warning that does not seem to be right.
4848 (MAXPATHLEN): Define only if needed.
4850 * process.c (serial_open, serial_configure): Move decls from here ...
4851 * systty.h: ... to here, so that they can be checked.
4853 * fns.c (get_random, seed_random): Move extern decls from here ...
4854 * lisp.h: ... to here, so that they can be checked.
4856 * sysdep.c (reset_io): Now static.
4857 (wait_for_termination_signal): Remove; unused.
4859 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4860 (copy_keymap_item, append_key, push_text_char_description):
4862 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4863 (DENSE_TABLE_SIZE): Remove; unused.
4864 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4865 (describe_map_tree):
4866 Rename locals to avoid shadowing.
4868 * keyboard.c: Declare functions static if they are not used elsewhere.
4869 (echo_char, echo_dash, cmd_error, top_level_2):
4870 (poll_for_input, handle_async_input): Now static.
4871 (read_char, kbd_buffer_get_event, make_lispy_position):
4872 (make_lispy_event, make_lispy_movement, apply_modifiers):
4873 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4874 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4875 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4876 (read_key_sequence, read_char): Mark locals as initialized.
4877 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4879 * keyboard.h (make_ctrl_char): New decl.
4880 (mark_kboards): Move decl here ...
4881 * alloc.c (mark_kboards): ... from here.
4883 * lisp.h (force_auto_save_soon): New decl.
4885 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4886 (DEFINE_DUMMY_FUNCTION): New macro.
4887 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4889 (main): Add casts to avoid warnings
4890 if GCC considers string literals to be constants.
4892 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4894 * dbusbind.c: Pointer signedness fixes.
4895 (xd_signature, xd_append_arg, xd_initialize):
4896 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4897 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4898 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4899 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4901 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4902 if GCC considers string literals to be constants.
4903 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4905 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4907 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4908 (print_preprocess, print_object): New macro to fix last change.
4910 * print.c (print_preprocess): Don't forget font objects.
4912 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4914 * emacs.c (USAGE3): Doc fixes.
4916 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4918 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4921 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4923 * lisp.h (VWindow_system, Qfile_name_history):
4924 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4925 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4926 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4928 * w32select.c: Don't #include "keyboard.h".
4929 (run_protected): Add extern declaration for waiting_for_input.
4931 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4932 * w32console.c (detect_input_pending, read_input_pending)
4933 (encode_terminal_code):
4934 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4935 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4936 (w32_system_caret_y, Qfile_name_history):
4937 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4938 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4939 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4940 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4941 * w32proc.c (Qlocal, report_file_error):
4942 * w32term.c (Vwindow_system, updating_frame):
4943 * w32uniscribe.c (initialized, uniscribe_font_driver):
4944 Remove unneeded extern declarations.
4946 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4948 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4950 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4952 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4953 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4954 These macros can no longer be used for assignment.
4956 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4957 Assign struct members directly, instead of using BUF_BEGV etc.
4958 (record_buffer_markers, fetch_buffer_markers): New functions for
4959 recording and fetching special buffer markers.
4960 (set_buffer_internal_1, set_buffer_temp): Use them.
4962 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4964 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4966 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4967 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4969 * xdisp.c (hscroll_window_tree):
4970 (reconsider_clip_changes): Use PT instead of BUF_PT.
4972 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4974 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4975 $(EMACS_ROOT)/lib/intprops.h.
4977 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4979 Fix more problems found by GCC 4.5.2's static checks.
4981 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4982 to unsigned char * to avoid compiler diagnostic.
4983 (xg_free_frame_widgets): Make it clear that a local variable is
4984 needed only if USE_GTK_TOOLTIP.
4985 (gdk_window_get_screen): Make it clear that this macro is needed
4986 only if USE_GTK_TOOLTIP.
4987 (int_gtk_range_get_value): New function, which avoids a diagnostic
4988 from gcc -Wbad-function-cast.
4989 (xg_set_toolkit_scroll_bar_thumb): Use it.
4990 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4991 diagnostic from gcc -Wbad-function-cast.
4992 (get_utf8_string, xg_get_file_with_chooser):
4993 Rename locals to avoid shadowing.
4994 (create_dialog): Move locals to avoid shadowing.
4996 * xgselect.c (xg_select): Remove unused var.
4998 * image.c (four_corners_best): Mark locals as initialized.
4999 (gif_load): Initialize transparent_p to zero (Bug#8238).
5000 Mark another local as initialized.
5001 (my_png_error, my_error_exit): Mark with NO_RETURN.
5003 * image.c (clear_image_cache): Now static.
5004 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5005 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5006 (x_edge_detection): Remove unnecessary cast that
5007 gcc -Wbad-function-cast diagnoses.
5008 (gif_load): Fix pointer signedness.
5009 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5010 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5012 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5014 Improve quality of tests for time stamp overflow.
5015 For example, without this patch (encode-time 0 0 0 1 1
5016 1152921504606846976) returns the obviously-bogus value (-948597
5017 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5018 reports time overflow. See
5019 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5020 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5021 * editfns.c: Include limits.h and intprops.h.
5022 (TIME_T_MIN, TIME_T_MAX): New macros.
5023 (time_overflow): Move earlier, to before first use.
5024 (hi_time, lo_time): New functions, for an accurate test for
5026 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5027 (Fget_internal_run_time): Don't assume time_t fits in int.
5028 (make_time): Use list2 instead of Fcons twice.
5029 (Fdecode_time): More accurate test for out-of-range times.
5030 (check_tm_member): New function.
5031 (Fencode_time): Use it, to test for out-of-range times.
5032 (lisp_time_argument): Don't rely on undefined left-shift and
5033 right-shift behavior when checking for time stamp overflow.
5035 * editfns.c (time_overflow): New function, refactoring common code.
5036 (Fformat_time_string, Fdecode_time, Fencode_time):
5037 (Fcurrent_time_string): Use it.
5039 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5040 * dired.c (make_time): Move to ...
5041 * editfns.c (make_time): ... here.
5042 * systime.h: Note the move.
5044 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5046 * fringe.c (update_window_fringes): Remove unused variables.
5048 * unexmacosx.c (copy_data_segment): Also copy __got section.
5051 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5053 * termcap.c [MSDOS]: Include "msdos.h".
5054 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5055 Constify `char *' arguments and their references according to
5056 prototypes in tparam.h.
5058 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5060 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5061 Adapt all references accordingly.
5063 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5065 2011-03-11 Tom Tromey <tromey@redhat.com>
5067 * buffer.c (syms_of_buffer): Remove obsolete comment.
5069 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5071 * termhooks.h (encode_terminal_code): Declare prototype.
5073 * msdos.c (encode_terminal_code): Don't declare prototype.
5075 * term.c (encode_terminal_code): Now external again, used by
5076 w32console.c and msdos.c.
5078 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5079 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5081 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5083 Fix some minor problems found by GCC 4.5.2's static checks.
5085 * fringe.c (update_window_fringes): Mark locals as initialized
5087 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5089 * alloc.c (mark_fringe_data): Move decl from here ...
5090 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5091 to check its interface.
5092 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5094 * fontset.c (free_realized_fontset): Now static.
5095 (Fset_fontset_font): Rename local to avoid shadowing.
5096 (fontset_font): Mark local as initialized.
5097 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5099 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5101 * xselect.c (x_disown_buffer_selections): Remove; not used.
5102 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5103 (x_own_selection, Fx_disown_selection_internal): Rename locals
5105 (x_handle_dnd_message): Remove local to avoid shadowing.
5107 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5108 so that the caller can use some name other than gcpro1.
5109 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5110 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5111 (Fx_backspace_delete_keys_p):
5112 Use them to avoid shadowing, and rename vars to avoid shadowing.
5113 (x_decode_color, x_set_name, x_window): Now static.
5114 (Fx_create_frame): Add braces to silence GCC warning.
5115 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5116 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5117 Remove unused locals.
5118 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5119 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5120 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5123 * xterm.h (x_mouse_leave): New decl.
5125 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5126 Remove unused functions.
5127 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5128 (x_calc_absolute_position): Now static.
5129 (XTread_socket): Don't define label "out" unless it's used.
5130 Don't declare local "event" unless it's used.
5131 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5132 unless they are used.
5133 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5134 (x_fatal_error_signal): Remove; not used.
5135 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5136 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5137 (x_error_catcher, x_connection_closed, x_error_handler):
5138 (x_error_quitter, xembed_send_message, x_iconify_frame):
5139 (my_log_handler): Rename locals to avoid shadowing.
5140 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5141 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5143 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5144 Rename or move locals to avoid shadowing.
5145 (tty_defined_color, merge_face_heights): Now static.
5146 (free_realized_faces_for_fontset): Remove; not used.
5147 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5148 does not deduce is never used uninitialized.
5149 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5150 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5152 * terminal.c (store_terminal_param): Now static.
5154 * xmenu.c (menu_highlight_callback): Now static.
5155 (set_frame_menubar): Remove unused local.
5156 (xmenu_show): Rename parameter to avoid shadowing.
5157 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5158 since they might point to immutable storage.
5159 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5160 since it's unused otherwise.
5162 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5163 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5164 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5165 avoids a gcc -Wuninitialized diagnostic.
5166 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5167 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5168 does not deduce are never used uninitialized.
5170 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5172 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5173 * window.c (window_loop, size_window):
5174 (run_window_configuration_change_hook, enlarge_window): Likewise.
5176 * window.c (display_buffer): Now static.
5177 (size_window): Mark variables that gcc -Wuninitialized
5178 does not deduce are never used uninitialized.
5179 * window.h (check_all_windows): New decl, to forestall
5180 gcc -Wmissing-prototypes diagnostic.
5181 * dispextern.h (bidi_dump_cached_states): Likewise.
5183 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5185 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5187 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5188 and to avoid gcc -Wuninitialized warning.
5189 (load_charset_map): Mark variables that gcc -Wuninitialized
5190 does not deduce are never used uninitialized.
5191 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5193 * coding.c (coding_set_source, coding_set_destination):
5194 Use "else { /* comment */ }" rather than "else /* comment */;"
5195 for clarity, and to avoid gcc -Wempty-body warning.
5196 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5197 a block, when the outer 'i' will do.
5198 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5199 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5200 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5201 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5202 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5203 Rename locals to avoid shadowing.
5204 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5205 * coding.c (emacs_mule_char, encode_invocation_designation):
5206 Now static, since they're not used elsewhere.
5207 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5208 (decode_coding_object, encode_coding_object, detect_coding_system):
5209 (decode_coding_emacs_mule): Mark variables that gcc
5210 -Wuninitialized does not deduce are never used uninitialized.
5211 (detect_coding_iso_2022): Initialize a local variable that might
5212 be used uninitialized. Leave a FIXME because it's not clear that
5213 this initialization is needed. (Bug#8211)
5214 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5215 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5216 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5217 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5218 Remove unused macros.
5220 * category.c (hash_get_category_set): Remove unused local var.
5221 (copy_category_table): Now static, since it's not used elsewhere.
5222 * character.c (string_count_byte8): Likewise.
5224 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5225 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5227 * chartab.c (copy_sub_char_table): Now static, since it's not used
5229 (sub_char_table_ref_and_range, char_table_ref_and_range):
5230 Rename locals to avoid shadowing.
5231 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5233 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5234 (BIDI_BOB): Remove unused macro.
5236 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5237 deduce are never used uninitialized.
5238 * term.c (encode_terminal_code): Likewise.
5240 * term.c (encode_terminal_code): Now static. Remove unused local.
5242 * tparam.h: New file.
5243 * term.c, tparam.h: Include it.
5244 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5245 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5246 Move these decls to tparam.h, and make them agree with what
5247 is actually in tparam.c. The previous trick of using incompatible
5248 decls in different modules does not conform to the C standard.
5249 All callers of tparam changed to use tparam's actual API.
5250 * tparam.c (tparam1, tparam, tgoto):
5251 Use const pointers where appropriate.
5253 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5254 * cm.h (struct cm): Likewise.
5255 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5256 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5257 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5258 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5259 (turn_on_face, init_tty): Likewise.
5260 * termchar.h (struct tty_display_info): Likewise.
5262 * term.c (term_mouse_position): Rename local to avoid shadowing.
5264 * alloc.c (mark_ttys): Move decl from here ...
5265 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5267 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5269 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5271 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5273 * search.c (compile_pattern_1): Remove argument regp, unused since
5274 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5275 (compile_pattern): Don't pass it.
5277 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5279 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5280 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5282 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5284 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5286 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5287 gdk_window_get_screen, gdk_window_get_geometry,
5288 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5289 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5290 (xg_get_pixbuf_from_pixmap): New function.
5291 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5292 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5293 Call xg_get_pixbuf_from_pixmap instead of
5294 gdk_pixbuf_get_from_drawable.
5295 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5296 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5297 (xg_check_special_colors): Use GtkStyleContext and its functions
5299 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5300 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5301 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5302 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5303 Call gtk_widget_get_preferred_size.
5304 (xg_frame_resized): gdk_window_get_geometry only takes 5
5306 (xg_win_to_widget, xg_event_is_for_menubar):
5307 Call gdk_x11_window_lookup_for_display.
5308 (xg_set_widget_bg): New function.
5309 (delete_cb): New function.
5310 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5311 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5312 (xg_set_background_color): Call xg_set_widget_bg.
5313 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5314 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5315 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5316 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5318 (update_frame_tool_bar): Call gtk_widget_hide.
5319 (xg_initialize): Use GDK_KEY_g.
5321 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5323 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5325 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5326 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5327 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5329 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5331 * w32xfns.c (select_palette): Check success of RealizePalette against
5332 GDI_ERROR, not zero.
5334 See ChangeLog.11 for earlier changes.
5340 Copyright (C) 2011 Free Software Foundation, Inc.
5342 This file is part of GNU Emacs.
5344 GNU Emacs is free software: you can redistribute it and/or modify
5345 it under the terms of the GNU General Public License as published by
5346 the Free Software Foundation, either version 3 of the License, or
5347 (at your option) any later version.
5349 GNU Emacs is distributed in the hope that it will be useful,
5350 but WITHOUT ANY WARRANTY; without even the implied warranty of
5351 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5352 GNU General Public License for more details.
5354 You should have received a copy of the GNU General Public License
5355 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.